Datasets:
YabTad
/
CodeRev

Dataset card Data Studio Files
xet
 Community
ReviewComments
stringlengths
1
2.35k
OriginalCode
stringlengths
28
487
ReviewedCode
stringlengths
14
463
line triggers a java lang _CODE_ code : $a = 012_345 ;
private boolean METHOD_1 ( String value ) { <START> return value . length ( ) == 4 || Integer . parseInt ( value ) < INT_1 ; <END> }
private static boolean METHOD_1 ( String value ) { return value . length ( ) == 4 || Integer . parseInt ( value ) < INT_1 ; }
I ve noticed location = = null NPE exceptions thrown check null
public TYPE_1 METHOD_1 ( ) { <START> TYPE_2 VAR_1 = ( TYPE_2 ) METHOD_2 ( ) . get ( STRING_1 ) ; <END> return new TYPE_1 ( VAR_1 . METHOD_3 ( ) , VAR_1 . METHOD_4 ( ) ) ; }
public TYPE_1 METHOD_1 ( ) { return METHOD_2 ( ) . METHOD_1 ( ) ; }
parent null caller / log indication a problem desired
public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; try { TYPE_2 VAR_2 = METHOD_2 ( ) ; if ( VAR_2 != null ) { TYPE_3 VAR_3 = new TYPE_3 ( VAR_2 ) ; VAR_3 . METHOD_3 ( ) ; VAR_1 . add ( VAR_2 ) ; <START> } <END> } catch ( Exception ex ) { TYPE_4 . log ( TYPE_5 . class , TYPE_6 . VAR_5 , STRING_1 , ex ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 ) { super . METHOD_1 ( VAR_1 ) ; try { TYPE_2 VAR_2 = METHOD_2 ( ) ; TYPE_3 VAR_3 = new TYPE_3 ( VAR_2 ) ; VAR_3 . METHOD_3 ( ) ; VAR_1 . add ( VAR_2 ) ; } catch ( Exception ex ) { TYPE_4 . log ( TYPE_5 . class , TYPE_6 . VAR_5 , STRING_1 , ex ) ; } }
usar generics tipo de retorno
<START> public List METHOD_1 ( ) <END> { return VAR_1 ; }
public List < File > METHOD_1 ( ) { return VAR_1 ; }
nitjavafor ( long filter : VAR_1 ) { VAR_2 | = filter ; }
private static long METHOD_1 ( long [ ] VAR_1 ) { if ( VAR_1 == null ) { return 0 ; } int VAR_2 = 0 ; <START> for ( int i = 0 ; i < VAR_1 . length ; i ++ ) { <END> VAR_2 |= VAR_1 [ i ] ; } return VAR_2 ; }
private static long METHOD_1 ( long [ ] VAR_1 ) { if ( VAR_1 == null ) { return 0 ; } int VAR_2 = 0 ; for ( long filter : VAR_1 ) { VAR_2 |= filter ; } return VAR_2 ; }
extra whitespace forming neat columns code arguably HARDER read inarguably harder write maintain - - turning future single - line changes multi - line whitespace changes PLEASE DESIST
private boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , <START> TYPE_3 VAR_3 ) { <END> if ( VAR_1 instanceof TYPE_4 ) { TYPE_4 VAR_4 = ( TYPE_4 ) VAR_1 ; if ( VAR_4 . METHOD_2 ( ) . equals ( VAR_3 . METHOD_2 ( ) ) && VAR_4 . METHOD_3 ( ) . equals ( VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ) ) { return true ; } } return false ; }
private static boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { if ( VAR_1 instanceof TYPE_4 ) { TYPE_4 VAR_4 = ( TYPE_4 ) VAR_1 ; if ( VAR_4 . METHOD_2 ( ) . equals ( VAR_3 . METHOD_2 ( ) ) && VAR_4 . METHOD_3 ( ) . equals ( VAR_2 . METHOD_4 ( ) . METHOD_5 ( ) ) ) { return true ; } } return false ; }
localized ? don t localize log message a translated IOException log hard understand submit bug
public static void log ( Throwable e ) { <START> log ( new Status ( TYPE_1 . VAR_2 , VAR_3 , TYPE_1 . VAR_4 , e . VAR_5 ( ) , e ) ) ; <END> }
public static void log ( Throwable e ) { log ( new Status ( TYPE_1 . VAR_2 , VAR_3 , TYPE_1 . VAR_4 , e . getMessage ( ) , e ) ) ; }
Boolean TRUE equals ( obj ) want s explicit I don t mind : - )
private boolean METHOD_1 ( TYPE_1 channel ) { <START> boolean VAR_1 = TYPE_2 . METHOD_2 ( channel . VAR_2 ( ) , false ) ; <END> boolean VAR_3 = TYPE_2 . METHOD_2 ( channel . VAR_4 ( ) , false ) ; return ! ( VAR_1 || VAR_3 ) ; }
boolean METHOD_1 ( TYPE_1 channel ) { boolean VAR_1 = TYPE_2 . METHOD_2 ( channel . VAR_2 ( ) , false ) ; boolean VAR_3 = TYPE_2 . METHOD_2 ( channel . VAR_4 ( ) , false ) ; return ! ( VAR_1 || VAR_3 ) ; }
lose typing TYPE_1 define method a generic _CODE_
default TYPE_1 VAR_2 ( ) { <START> throw new TYPE_2 ( ) ; <END> }
default TYPE_1 < ? > VAR_2 ( ) { throw new TYPE_2 ( ) ; }
original query cacheable I param false
public TYPE_1 METHOD_1 ( Context context , String token ) throws TYPE_2 { TYPE_3 VAR_1 = METHOD_2 ( context ) ; TYPE_4 VAR_2 = METHOD_3 ( VAR_1 , TYPE_1 . class ) ; TYPE_5 < TYPE_1 > VAR_3 = VAR_2 . from ( TYPE_1 . class ) ; VAR_2 . METHOD_4 ( VAR_3 ) ; VAR_2 . METHOD_5 ( VAR_1 . METHOD_6 ( VAR_3 . get ( TYPE_6 . token ) , token ) ) ; <START> return METHOD_7 ( context , VAR_2 , true , TYPE_1 . class , - 1 , - 1 ) ; <END> }
public TYPE_1 METHOD_1 ( Context context , String token ) throws TYPE_2 { TYPE_3 VAR_1 = METHOD_2 ( context ) ; TYPE_4 VAR_2 = METHOD_3 ( VAR_1 , TYPE_1 . class ) ; TYPE_5 < TYPE_1 > VAR_3 = VAR_2 . from ( TYPE_1 . class ) ; VAR_2 . METHOD_4 ( VAR_3 ) ; VAR_2 . METHOD_5 ( VAR_1 . METHOD_6 ( VAR_3 . get ( TYPE_6 . token ) , token ) ) ; return METHOD_7 ( context , VAR_2 , false , TYPE_1 . class , - 1 , - 1 ) ; }
saving preferences a setter please follow pattern other preferences
public static void METHOD_1 ( TYPE_1 project , boolean VAR_1 ) { if ( VAR_1 != METHOD_2 ( project ) ) { METHOD_3 ( project ) . METHOD_4 ( VAR_2 , VAR_1 ) ; <START> TYPE_2 . METHOD_5 ( project , true ) ; <END> } }
public static void METHOD_1 ( TYPE_1 project , boolean VAR_1 ) { if ( VAR_1 != METHOD_2 ( project ) ) { METHOD_3 ( project ) . METHOD_4 ( VAR_2 , VAR_1 ) ; } }
elena VAR_4 a _CODE_ suggestion : invert meaning Boolean : true problem false problem
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 element ) { T VAR_2 = METHOD_2 ( element ) ; if ( VAR_2 != null ) { boolean VAR_3 = METHOD_3 ( VAR_2 , VAR_1 ) ; if ( ! VAR_3 ) { VAR_4 . put ( VAR_2 , true ) ; <START> } else if ( ! VAR_4 . containsKey ( VAR_2 ) ) { <END> VAR_4 . put ( VAR_2 , false ) ; } } }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 element ) { T VAR_2 = METHOD_2 ( element ) ; if ( VAR_2 != null ) { boolean VAR_3 = METHOD_3 ( VAR_2 , VAR_1 ) ; if ( ! VAR_3 ) { VAR_4 . put ( VAR_2 , false ) ; } else if ( ! VAR_4 . containsKey ( VAR_2 ) ) { VAR_4 . put ( VAR_2 , true ) ; } } }
extra
public String toString ( ) { return METHOD_1 ( this ) . METHOD_2 ( ) <START> . add ( STRING_1 , this . VAR_1 ) <END> . add ( STRING_2 , VAR_2 ) . add ( STRING_3 , VAR_3 ) . toString ( ) ; }
public String toString ( ) { return METHOD_1 ( this ) . METHOD_2 ( ) . add ( STRING_1 , VAR_1 ) . add ( STRING_2 , VAR_2 ) . add ( STRING_3 , VAR_3 ) . toString ( ) ; }
checks unrelated actual check want perform
public void METHOD_1 ( ) throws Exception { TYPE_1 msg = METHOD_2 ( METHOD_3 ( STRING_1 + STRING_2 + STRING_3 + STRING_4 + STRING_5 + STRING_6 + STRING_7 + STRING_8 ) ) ; METHOD_4 ( msg . VAR_1 ( ) , STRING_9 ) ; <START> METHOD_4 ( msg . VAR_2 ( TYPE_3 . VAR_4 ) , STRING_10 ) ; <END> METHOD_5 ( TYPE_2 . METHOD_6 ( msg . VAR_5 ( ) ) ) ; }
public void METHOD_1 ( ) throws Exception { TYPE_1 msg = METHOD_2 ( METHOD_3 ( STRING_1 + STRING_2 + STRING_3 + STRING_4 + STRING_5 + STRING_6 + STRING_7 + STRING_8 ) ) ; TYPE_2 . METHOD_6 ( msg . VAR_5 ( ) ) ; }
I d protected
<START> public TYPE_1 METHOD_1 ( ) { <END> return new TYPE_1 ( VAR_1 , config . VAR_2 ( ) + STRING_1 ) ; }
protected TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( VAR_1 , config . VAR_2 ( ) + STRING_1 ) ; }
method private
<START> private void METHOD_1 ( TYPE_1 result ) { <END> assertNotNull ( result ) ; assertTrue ( result . VAR_1 ( ) ) ; }
static private void METHOD_1 ( TYPE_1 result ) { assertNotNull ( result ) ; assertTrue ( result . VAR_1 ( ) ) ; }
define a constant 1
public static TYPE_1 METHOD_1 ( TYPE_2 stream , TYPE_3 VAR_1 ) throws IOException { TYPE_4 VAR_2 = stream . VAR_3 ( ) ; if ( ! VAR_2 . equals ( VAR_4 ) ) { throw new IllegalStateException ( STRING_1 + VAR_4 ) ; } TYPE_5 VAR_5 = TYPE_5 . values ( ) [ stream . VAR_3 ( ) ] ; <START> boolean VAR_6 = stream . VAR_7 ( ) == 1 ; <END> return new TYPE_1 ( VAR_5 , VAR_6 , VAR_1 ) ; }
public static TYPE_1 METHOD_1 ( TYPE_2 stream , TYPE_3 VAR_1 ) throws IOException { TYPE_4 VAR_2 = stream . VAR_3 ( ) ; if ( ! VAR_2 . equals ( VAR_4 ) ) { throw new IllegalStateException ( STRING_1 + VAR_2 ) ; } TYPE_5 VAR_5 = TYPE_5 . values ( ) [ stream . VAR_3 ( ) ] ; boolean VAR_6 = stream . VAR_7 ( ) == 1 ; return new TYPE_1 ( VAR_5 , VAR_6 , VAR_1 ) ; }
expecting workflow jobs ? I work
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { if ( ! METHOD_2 ( VAR_1 ) ) return ; for ( TYPE_3 config : VAR_3 ) { <START> List < TYPE_1 > VAR_4 = TYPE_4 . filter ( config . VAR_5 ( VAR_1 . METHOD_3 ( ) , null ) , TYPE_1 . class ) ; <END> for ( TYPE_1 project : VAR_4 ) TYPE_5 . add ( VAR_1 , project , config , VAR_2 ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { if ( ! METHOD_2 ( VAR_1 ) ) return ; for ( TYPE_3 config : VAR_3 ) { List < TYPE_1 > VAR_4 = config . VAR_5 ( VAR_1 . METHOD_3 ( ) , null ) ; for ( TYPE_1 project : VAR_4 ) { TYPE_5 . add ( VAR_1 , project , config , VAR_2 ) ; } } }
method returns option < TYPE_2 > API null check METHOD_2 ( ) some ( )
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = null ; TYPE_2 VAR_2 = <START> METHOD_2 ( ) . get ( ) ; <END> TYPE_3 VAR_3 = new TYPE_4 ( VAR_2 ) . METHOD_3 ( ) ; TYPE_5 VAR_4 = TYPE_6 . METHOD_4 ( VAR_3 , false ) ; if ( VAR_4 instanceof TYPE_1 ) { VAR_1 = ( TYPE_1 ) VAR_4 ; } return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = null ; TYPE_2 VAR_2 = METHOD_2 ( ) . get ( ) ; if ( VAR_2 != null ) { TYPE_3 VAR_3 = new TYPE_4 ( VAR_2 ) . METHOD_3 ( ) ; TYPE_5 VAR_4 = TYPE_6 . METHOD_4 ( VAR_3 , false ) ; if ( VAR_4 instanceof TYPE_1 ) { VAR_1 = ( TYPE_1 ) VAR_4 ; } } return VAR_1 ; }
unnecessary ; call ( )
public TYPE_2 ( TYPE_1 VAR_2 ) { this ( VAR_2 . METHOD_1 ( ) ) ; <START> VAR_3 = new HashSet < > ( ) ; <END> }
public TYPE_2 ( TYPE_1 VAR_2 ) { this ( VAR_2 . METHOD_1 ( ) ) ; }
clear map EMF observable holds _CODE_ disposal prevent GC collect model observable retained similar reasons please set match null
public synchronized void METHOD_1 ( ) { for ( Entry < String , TYPE_1 > entry : VAR_1 . entrySet ( ) ) { entry . getValue ( ) . METHOD_1 ( ) ; } <START> super . METHOD_1 ( ) ; <END> }
public synchronized void METHOD_1 ( ) { for ( Entry < String , TYPE_1 > entry : VAR_1 . entrySet ( ) ) { entry . getValue ( ) . METHOD_1 ( ) ; } VAR_1 . clear ( ) ; super . METHOD_1 ( ) ; }
discussed main issue check entire method moved METHOD_3 method
private void METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_1 VAR_2 = VAR_1 . METHOD_2 ( ) . METHOD_2 ( ) ; if ( VAR_2 . getType ( ) == TYPE_3 . VAR_4 && METHOD_3 ( VAR_2 ) && METHOD_4 ( VAR_2 ) <START> && ! TYPE_2 . METHOD_5 ( VAR_2 , STRING_1 ) ) { <END> METHOD_6 ( VAR_1 ) ; } }
private void METHOD_1 ( TYPE_1 VAR_1 ) { final TYPE_1 VAR_2 = VAR_1 . METHOD_2 ( ) . METHOD_2 ( ) ; if ( VAR_2 . getType ( ) == TYPE_3 . VAR_4 && METHOD_3 ( VAR_2 ) ) { METHOD_6 ( VAR_1 ) ; } }
implementation return false
public static boolean METHOD_1 ( int [ ] version ) { <START> int VAR_1 = METHOD_2 ( version , VAR_2 ) ; <END> if ( VAR_1 < 0 ) return true ; else if ( VAR_1 == 0 ) return false ; if ( METHOD_2 ( version , VAR_3 ) <= 0 ) return true ; return false ; }
public static boolean METHOD_1 ( int [ ] version ) { return false ; }
removing NPE check
protected void METHOD_1 ( ) { this . VAR_1 = new TYPE_1 ( METHOD_2 ( ) , this ) ; <START> METHOD_3 ( ) . METHOD_4 ( this . VAR_1 ) ; <END> }
protected void METHOD_1 ( ) { this . VAR_1 = new TYPE_1 ( METHOD_2 ( ) , this ) ; if ( METHOD_3 ( ) != null ) { METHOD_3 ( ) . METHOD_4 ( this . VAR_1 ) ; } }
s multi - catch
public static TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 VAR_1 ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public TYPE_2 apply ( TYPE_4 VAR_2 ) { try { TYPE_5 element = METHOD_2 ( VAR_1 , VAR_2 ) ; return element . VAR_3 ( ) ? METHOD_3 ( VAR_1 , element , VAR_2 ) : null ; <START> } catch ( TYPE_6 e ) { <END> return null ; } catch ( TYPE_7 e ) { return null ; } } @Override public String toString ( ) { return STRING_1 + VAR_1 ; } } ; }
public static TYPE_1 < TYPE_2 > METHOD_1 ( final TYPE_3 VAR_1 ) { return new TYPE_1 < TYPE_2 > ( ) { @Override public TYPE_2 apply ( TYPE_4 VAR_2 ) { try { TYPE_5 element = METHOD_2 ( VAR_1 , VAR_2 ) ; return element . VAR_3 ( ) ? METHOD_3 ( VAR_1 , element , VAR_2 ) : null ; } catch ( TYPE_6 | TYPE_7 e ) { return null ; } } @Override public String toString ( ) { return STRING_1 + VAR_1 ; } } ; }
fault PR feels weird environment * * * * zk connection string
public TYPE_1 < ? > METHOD_1 ( TYPE_2 context ) { TYPE_3 VAR_1 = new TYPE_3 ( true ) ; VAR_1 . METHOD_2 ( context . VAR_2 ( ) ) ; <START> if ( VAR_3 != null ) { <END> VAR_1 . METHOD_3 ( VAR_3 . METHOD_4 ( ) . METHOD_5 ( ) . METHOD_6 ( ) ) ; } return new TYPE_4 ( context , VAR_1 ) ; }
public TYPE_1 < ? > METHOD_1 ( TYPE_2 context ) { TYPE_3 VAR_1 = new TYPE_3 ( true ) ; VAR_1 . METHOD_2 ( context . VAR_2 ( ) ) ; return new TYPE_4 ( context , VAR_1 ) ; }
array length ( based VAR_1 size )
public String [ ] METHOD_1 ( ) { <START> return this . VAR_1 . METHOD_2 ( new String [ ] { } ) ; <END> }
public String [ ] METHOD_1 ( ) { return this . VAR_1 . METHOD_2 ( new String [ VAR_1 . size ( ) ] ) ; }
minor return VAR_2 parse ( VAR_1 ) METHOD_2 ( )
public static Long METHOD_1 ( String VAR_1 ) { try { TYPE_1 VAR_2 = new TYPE_1 ( VAR_3 , TYPE_3 . VAR_5 ) ; Date VAR_6 = VAR_2 . parse ( VAR_1 ) ; <START> return VAR_6 . METHOD_2 ( ) ; <END> } catch ( TYPE_2 e ) { logger . warn ( STRING_1 + VAR_1 + STRING_2 ) ; return null ; } }
public static Long METHOD_1 ( String VAR_1 ) { try { TYPE_1 VAR_2 = new TYPE_1 ( VAR_3 , TYPE_3 . VAR_5 ) ; return VAR_2 . parse ( VAR_1 ) . METHOD_2 ( ) ; } catch ( TYPE_2 e ) { logger . warn ( STRING_1 + VAR_1 + STRING_2 ) ; return null ; } }
please remove public modifier
<START> public TYPE_2 ( TYPE_1 context ) { <END> this . context = context ; }
TYPE_2 ( TYPE_1 context ) { this . context = context ; }
consistency ! TYPE_2 METHOD_3 ( VAR_2 ) && ! TYPE_2 METHOD_3 ( target ) please
public void METHOD_1 ( final TYPE_1 VAR_1 ) { final Object target = METHOD_2 ( VAR_1 ) ; <START> if ( this . VAR_2 != null && ! TYPE_2 . METHOD_3 ( target ) ) { <END> VAR_2 . METHOD_4 ( VAR_1 ) ; } }
public void METHOD_1 ( final TYPE_1 VAR_1 ) { final Object target = METHOD_2 ( VAR_1 ) ; if ( ! TYPE_2 . METHOD_3 ( VAR_2 ) && ! TYPE_2 . METHOD_3 ( target ) ) { VAR_2 . METHOD_4 ( VAR_1 ) ; } }
new METHOD_1 method implementation existing _CODE_ method case reuse
<START> public void METHOD_1 ( Class < ? extends TYPE_1 > filter , <END> Class < ? extends TYPE_1 > VAR_1 ) { Integer position = METHOD_2 ( VAR_1 ) ; if ( position == null ) { throw new IllegalArgumentException ( STRING_1 + VAR_1 ) ; } put ( filter , position + 1 ) ; }
public void METHOD_1 ( Class < ? extends TYPE_1 > filter , Class < ? extends TYPE_1 > VAR_1 ) { Integer position = METHOD_2 ( VAR_1 ) ; if ( position == null ) { throw new IllegalArgumentException ( STRING_1 + VAR_1 ) ; } put ( filter , position ) ; }
a otimization : VAR_2 METHOD_1 don t need check others writeif ( VAR_2 matcher ( VAR_1 ) METHOD_1 ( ) ) return true ;
public boolean METHOD_1 ( String VAR_1 ) { if ( VAR_1 == null || VAR_1 . isEmpty ( ) ) { return false ; } boolean result = false ; for ( TYPE_1 VAR_2 : VAR_3 ) { <START> result |= VAR_2 . matcher ( VAR_1 ) . METHOD_1 ( ) ; <END> } return result ; }
public boolean METHOD_1 ( String VAR_1 ) { if ( StringUtils . isEmpty ( VAR_1 ) ) { return false ; } for ( TYPE_1 VAR_2 : VAR_3 ) { if ( VAR_2 . matcher ( VAR_1 ) . METHOD_1 ( ) ) { return true ; } } return false ; }
pass map TYPE_3 constructor ( copy internally )
public TYPE_1 < String , TYPE_2 > build ( ) { <START> return new TYPE_3 < TYPE_2 > ( VAR_1 , new TYPE_4 < String , TYPE_2 > ( map ) ) ; <END> }
public TYPE_1 < String , TYPE_2 > build ( ) { return new TYPE_3 < TYPE_2 > ( VAR_1 , map ) ; }
suggestionprivate static boolean METHOD_1 ( TYPE_1 VAR_1 ) { return ( VAR_1 instanceof TYPE_2 ) ; }
<START> static boolean METHOD_1 ( TYPE_1 VAR_1 ) { return ( VAR_1 instanceof TYPE_2 ) ; } <END>
private static boolean METHOD_1 ( TYPE_1 VAR_1 ) { return ( VAR_1 instanceof TYPE_2 ) ; }
a TYPE_1 error more proper ? generally error early late
public static TYPE_1 < byte [ ] > METHOD_1 ( String url , TYPE_2 VAR_1 ) { TYPE_3 VAR_2 = TYPE_4 . create ( TYPE_3 . class , VAR_1 ) ; try { return VAR_2 . METHOD_2 ( METHOD_3 ( url ) , METHOD_4 ( url ) ) . METHOD_5 ( response - > TYPE_5 . METHOD_6 ( response . getValue ( ) ) ) ; } catch ( TYPE_6 ex ) { <START> return TYPE_1 . empty ( ) ; <END> } }
public static TYPE_1 < byte [ ] > METHOD_1 ( String url , TYPE_2 VAR_1 ) { TYPE_3 VAR_2 = TYPE_4 . create ( TYPE_3 . class , VAR_1 ) ; try { return VAR_2 . METHOD_2 ( METHOD_3 ( url ) , METHOD_4 ( url ) ) . METHOD_5 ( response - > TYPE_5 . METHOD_6 ( response . getValue ( ) ) ) ; } catch ( TYPE_6 ex ) { return TYPE_1 . error ( ( ) - > ex ) ; } }
add explicit else blockif ( condition ) { } else { }
public long METHOD_1 ( ) { if ( VAR_1 . size ( ) == 0 ) { return Long . VAR_2 ; } <START> TYPE_1 VAR_3 = VAR_1 . get ( 0 ) ; <END> return VAR_3 . METHOD_2 ( ) ; }
public long METHOD_1 ( ) { if ( VAR_1 . size ( ) == 0 ) { return Long . VAR_2 ; } else { TYPE_1 VAR_3 = VAR_1 . get ( 0 ) ; return VAR_3 . METHOD_2 ( ) ; } }
asuming allways argument case
private static String METHOD_1 ( List < String > VAR_1 ) <START> { <END> int VAR_2 = VAR_1 . METHOD_2 ( STRING_1 ) + 1 ; return VAR_1 . get ( VAR_2 ) ; }
private static String METHOD_1 ( List < String > VAR_1 ) { int index = VAR_1 . METHOD_2 ( STRING_1 ) ; if ( index == - 1 ) { return "" ; } return VAR_1 . get ( ++ index ) ; }
changes relevant patch
private void METHOD_1 ( ) { <START> METHOD_1 ( METHOD_2 ( ) . METHOD_3 ( ) ) ; <END> }
private void METHOD_1 ( ) { METHOD_1 ( ( Integer ) METHOD_2 ( ) . METHOD_3 ( ) ) ; }
I don t understand purpose local variable VAR_1 : IMHO remove variable
public TYPE_1 METHOD_1 ( TYPE_2 element ) { <START> TYPE_2 VAR_1 = element ; <END> if ( VAR_1 . METHOD_2 ( VAR_2 ) ) { if ( element . VAR_3 ( VAR_2 ) ) { return TYPE_1 . VAR_4 ; } } if ( element instanceof TYPE_3 ) { VAR_5 ++ ; } return TYPE_1 . VAR_6 ; }
public TYPE_1 METHOD_1 ( TYPE_2 element ) { if ( element . VAR_3 ( VAR_2 ) ) { return TYPE_1 . VAR_4 ; } if ( element instanceof TYPE_3 ) { VAR_5 ++ ; } return TYPE_1 . VAR_6 ; }
correct ? deleting a product I assume reports parent interesting file delta
protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { <START> return ! METHOD_2 ( VAR_1 , false ) . isEmpty ( ) ; <END> }
protected boolean METHOD_1 ( TYPE_1 VAR_1 ) { return true ; }
place put else returns - - consistency change else statement
protected TYPE_1 METHOD_1 ( String VAR_1 ) { if ( TYPE_2 . getInstance ( ) . METHOD_2 ( VAR_1 ) ) { return TYPE_3 . VAR_3 ; <START> } else { <END> return TYPE_3 . VAR_4 ; } }
protected TYPE_1 METHOD_1 ( String VAR_1 ) { if ( TYPE_2 . getInstance ( ) . METHOD_2 ( VAR_1 ) ) { return TYPE_3 . VAR_3 ; } return TYPE_3 . VAR_4 ; }
wondering check VAR_1 belonged auto - assigned partitions ? straight throw TYPE_4 ? a behavioral change
public void METHOD_1 ( final Map < TYPE_1 , TYPE_2 > VAR_1 , TYPE_3 VAR_2 ) { METHOD_2 ( ) ; try { METHOD_3 ( ) ; METHOD_4 ( VAR_1 ) ; log . debug ( STRING_1 , VAR_1 ) ; VAR_1 . forEach ( this : : METHOD_5 ) ; VAR_3 . METHOD_6 ( new HashMap < > ( VAR_1 ) , VAR_2 ) ; } catch ( TYPE_4 e ) { <START> log . error ( STRING_2 ) ; <END> VAR_2 . METHOD_7 ( VAR_1 , e ) ; } finally { METHOD_8 ( ) ; } }
public void METHOD_1 ( final Map < TYPE_1 , TYPE_2 > VAR_1 , TYPE_3 VAR_2 ) { METHOD_2 ( ) ; try { METHOD_3 ( ) ; log . debug ( STRING_1 , VAR_1 ) ; VAR_1 . forEach ( this : : METHOD_5 ) ; VAR_3 . METHOD_6 ( new HashMap < > ( VAR_1 ) , VAR_2 ) ; } finally { METHOD_8 ( ) ; } }
trace log doesn t allow easily entries s informative debug log : ) Long lines log a PITA deal I suggest logging number entries debug level a separate line processed / skipped entry
public void METHOD_1 ( TYPE_1 [ ] VAR_1 ) throws Exception { if ( trace ) { log . VAR_2 ( STRING_1 , METHOD_2 ( VAR_1 ) ) ; } else if ( debug ) { <START> log . VAR_3 ( STRING_2 , VAR_1 . length ) ; <END> } if ( VAR_4 != null ) { METHOD_3 ( VAR_1 ) ; } else { METHOD_4 ( VAR_1 ) ; } }
public void METHOD_1 ( TYPE_1 [ ] VAR_1 ) throws Exception { if ( debug ) { log . VAR_3 ( STRING_2 , VAR_1 . length ) ; } if ( VAR_4 != null ) { METHOD_3 ( VAR_1 ) ; } else { METHOD_4 ( VAR_1 ) ; } }
define enums operation type
protected TYPE_4 ( TYPE_1 VAR_2 , String VAR_3 , TYPE_2 VAR_4 , TYPE_2 VAR_5 ) { this . VAR_2 = VAR_2 ; <START> this . VAR_3 = VAR_3 ; <END> this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; VAR_6 = TYPE_3 . METHOD_1 ( VAR_2 ) ; }
TYPE_4 ( TYPE_1 VAR_2 , String VAR_3 , TYPE_2 VAR_4 , TYPE_2 VAR_5 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; this . VAR_5 = VAR_5 ; VAR_6 = TYPE_3 . METHOD_1 ( VAR_2 ) ; }
move closer method ? VAR_1 remove happen shell disposed s TBR false
public void METHOD_1 ( ) { <START> VAR_1 . METHOD_2 ( ) . remove ( VAR_2 ) ; <END> VAR_3 . METHOD_1 ( ) ; VAR_4 . METHOD_1 ( ) ; VAR_5 . METHOD_1 ( ) ; VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; VAR_2 . METHOD_3 ( ) . METHOD_1 ( ) ; ( ( TYPE_1 ) VAR_2 . METHOD_5 ( ) ) . METHOD_1 ( ) ; }
public void METHOD_1 ( ) { VAR_3 . METHOD_1 ( ) ; VAR_4 . METHOD_1 ( ) ; VAR_5 . METHOD_1 ( ) ; VAR_2 . METHOD_3 ( ) . METHOD_4 ( ) ; VAR_2 . METHOD_3 ( ) . METHOD_1 ( ) ; ( ( TYPE_1 ) VAR_2 . METHOD_5 ( ) ) . METHOD_1 ( ) ; VAR_1 . METHOD_2 ( ) . remove ( VAR_2 ) ; }
butreturn metadata getType ( ) METHOD_2 ( ) = = TYPE_1 VAR_2 ||metadata getType ( ) METHOD_2 ( ) = = TYPE_1 VAR_3 ||metadata getType ( ) METHOD_2 ( ) = = TYPE_1 VAR_4 ;
public boolean METHOD_1 ( ) { if ( metadata . getType ( ) . METHOD_2 ( ) == TYPE_1 . VAR_2 || metadata . getType ( ) . METHOD_2 ( ) == TYPE_1 . VAR_3 || metadata . getType ( ) . METHOD_2 ( ) == TYPE_1 . VAR_4 ) { return true ; } <START> return false ; <END> }
public boolean METHOD_1 ( ) { return metadata . getType ( ) . METHOD_2 ( ) == TYPE_1 . VAR_2 || metadata . getType ( ) . METHOD_2 ( ) == TYPE_1 . VAR_3 || metadata . getType ( ) . METHOD_2 ( ) == TYPE_1 . VAR_4 ; }
remove list preferred install part TYPE_6 done
protected Builder ( ) { super ( TYPE_1 . class ) ; id ( STRING_1 ) . name ( STRING_2 ) . METHOD_1 ( STRING_3 ) . METHOD_2 ( STRING_4 ) . METHOD_3 ( TYPE_2 . create ( STRING_5 ) ) . version ( STRING_6 ) . METHOD_4 ( STRING_7 ) . METHOD_5 ( TYPE_3 . METHOD_5 ( ) ) . METHOD_6 ( TYPE_7 < Class < ? extends TYPE_4 > > of ( <START> TYPE_5 . class , <END> TYPE_6 . class ) ) ; }
protected Builder ( ) { super ( TYPE_1 . class ) ; id ( STRING_1 ) . name ( STRING_2 ) . METHOD_1 ( STRING_3 ) . METHOD_2 ( STRING_4 ) . METHOD_3 ( TYPE_2 . create ( STRING_5 ) ) . version ( STRING_6 ) . METHOD_4 ( STRING_7 ) . METHOD_5 ( TYPE_3 . METHOD_5 ( ) ) . METHOD_6 ( TYPE_7 < Class < ? extends TYPE_4 > > of ( TYPE_6 . class ) ) ; }
optional : import VAR_2 static
TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( new TYPE_2 ( System . err , <START> TYPE_3 . VAR_2 ) ) ; <END> }
TYPE_1 METHOD_1 ( ) { return new TYPE_1 ( new TYPE_2 ( System . err , VAR_2 ) ) ; }
file a directory check necessary
public void METHOD_1 ( ) { int VAR_1 = VAR_2 . METHOD_2 ( ) ; for ( int i = 0 ; i < VAR_1 ; i ++ ) { File file = ( File ) VAR_2 . METHOD_3 ( i ) ; if ( file != null ) { <START> if ( file . VAR_3 ( ) ) { <END> } else { METHOD_4 ( ) . METHOD_5 ( i , true ) ; VAR_4 . METHOD_6 ( file ) ; } } } }
public void METHOD_1 ( ) { int VAR_1 = VAR_2 . METHOD_2 ( ) ; for ( int i = 0 ; i < VAR_1 ; i ++ ) { File file = ( File ) VAR_2 . METHOD_3 ( i ) ; if ( file != null ) { if ( ! file . VAR_3 ( ) ) { METHOD_4 ( ) . METHOD_5 ( i , true ) ; VAR_4 . METHOD_6 ( file ) ; } } } }
I tend agree I existing naming pattern I d fix consistent
<START> public TYPE_1 METHOD_1 ( ) { <END> TYPE_1 VAR_1 = null ; try { VAR_1 = VAR_2 == null ? null : new TYPE_1 ( VAR_2 ) ; } catch ( TYPE_2 VAR_3 ) { METHOD_2 ( STRING_1 , this . name , VAR_2 ) ; } for ( TYPE_3 p : METHOD_3 ( ) ) { TYPE_1 v = p . VAR_4 ( ) ; if ( v == null ) { continue ; } if ( VAR_1 == null || v . VAR_5 ( VAR_1 ) ) { VAR_1 = v ; } } return VAR_1 ; }
public TYPE_1 METHOD_1 ( ) { TYPE_1 VAR_1 = null ; try { VAR_1 = VAR_2 == null ? null : new TYPE_1 ( VAR_2 ) ; } catch ( TYPE_2 VAR_3 ) { METHOD_2 ( ) ; } for ( TYPE_3 p : METHOD_3 ( ) ) { TYPE_1 v = p . VAR_4 ( ) ; if ( v == null ) { continue ; } if ( VAR_1 == null || v . VAR_5 ( VAR_1 ) ) { VAR_1 = v ; } } return VAR_1 ; }
throw a RuntimeException a simulation
public void METHOD_1 ( ) { <START> throw new TYPE_1 ( STRING_1 ) ; <END> }
public void METHOD_1 ( ) { throw new RuntimeException ( STRING_1 ) ; }
remove empty line
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; METHOD_2 ( VAR_2 ) ; METHOD_2 ( VAR_3 ) ; METHOD_2 ( VAR_4 ) ; <START> <END> }
public void METHOD_1 ( ) { METHOD_2 ( VAR_1 ) ; METHOD_2 ( VAR_2 ) ; METHOD_2 ( VAR_3 ) ; }
replace : ( ( TYPE_2 ) VAR_2 METHOD_1 ( ) ) ;
public TYPE_3 ( TYPE_1 VAR_2 ) { <START> this . VAR_3 = ( TYPE_2 ) VAR_2 . METHOD_1 ( ) ; this . VAR_4 = VAR_3 . METHOD_2 ( ) . METHOD_3 ( ) . METHOD_4 ( ) . METHOD_5 ( ) ; <END> }
public TYPE_3 ( TYPE_1 VAR_2 ) { this ( ( TYPE_2 ) VAR_2 . METHOD_1 ( ) ) ; }
explicit cast done prevent overflow I safe remove castsame question other occurrences
public static long METHOD_1 ( byte [ ] VAR_1 ) { int p = 0 ; long VAR_2 = 0 ; int c , VAR_3 = 0 ; do { c = VAR_1 [ p ++ ] & INT_1 ; <START> VAR_2 |= ( ( c & INT_2 ) < < VAR_3 ) ; <END> VAR_3 += INT_3 ; } while ( ( c & INT_4 ) != 0 ) ; return VAR_2 ; }
public static long METHOD_1 ( byte [ ] VAR_1 ) { int p = 0 ; long VAR_2 = 0 ; int c , VAR_3 = 0 ; do { c = VAR_1 [ p ++ ] & INT_1 ; VAR_2 |= ( ( long ) ( c & INT_2 ) ) < < VAR_3 ; VAR_3 += INT_3 ; } while ( ( c & INT_4 ) != 0 ) ; return VAR_2 ; }
static import TYPE_6 METHOD_2
public TYPE_1 apply ( TYPE_2 node , TYPE_3 VAR_1 , Context context ) { Map < TYPE_4 , TYPE_5 > VAR_2 = <START> METHOD_1 ( TYPE_6 . METHOD_2 ( node ) , context , metadata , VAR_3 ) ; <END> if ( VAR_2 . isEmpty ( ) ) { return TYPE_1 . empty ( ) ; } return TYPE_1 . METHOD_3 ( new TYPE_7 ( context . VAR_4 ( ) . METHOD_4 ( ) , METHOD_5 ( context , node , TYPE_8 . create ( VAR_2 ) ) , METHOD_6 ( node . VAR_5 ( ) ) ) ) ; }
public TYPE_1 apply ( TYPE_2 node , TYPE_3 VAR_1 , Context context ) { Map < TYPE_4 , TYPE_5 > VAR_2 = METHOD_1 ( METHOD_2 ( node ) , context , metadata , VAR_3 ) ; if ( VAR_2 . isEmpty ( ) ) { return TYPE_1 . empty ( ) ; } return TYPE_1 . METHOD_3 ( new TYPE_7 ( context . VAR_4 ( ) . METHOD_4 ( ) , METHOD_5 ( context , node , TYPE_8 . create ( VAR_2 ) ) , METHOD_6 ( node . VAR_5 ( ) ) ) ) ; }
move call start method s generally s done
protected void METHOD_1 ( ) { String action = METHOD_2 ( ) . METHOD_3 ( ) ; if ( action == null || ! action . equals ( STRING_1 ) ) { TYPE_1 VAR_1 = new TYPE_1 ( this , TYPE_2 . class ) ; METHOD_4 ( VAR_1 ) ; METHOD_5 ( ) ; } else { METHOD_2 ( ) . METHOD_6 ( null ) ; } <START> super . METHOD_1 ( ) ; <END> }
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; String action = METHOD_2 ( ) . METHOD_3 ( ) ; if ( action == null || ! action . equals ( STRING_1 ) ) { TYPE_1 VAR_1 = new TYPE_1 ( this , TYPE_2 . class ) ; METHOD_4 ( VAR_1 ) ; METHOD_5 ( ) ; } else { METHOD_2 ( ) . METHOD_6 ( null ) ; } }
I want string computation lazy lose info overriding toString
public TYPE_2 ( TYPE_1 VAR_2 , double value , double VAR_3 ) { <START> super ( VAR_2 + STRING_1 ) ; <END> this . VAR_2 = VAR_2 ; this . value = value ; this . VAR_3 = VAR_3 ; }
public TYPE_2 ( TYPE_1 VAR_2 , double value , double VAR_3 ) { this . VAR_2 = VAR_2 ; this . value = value ; this . VAR_3 = VAR_3 ; }
needs cloning
public TYPE_1 METHOD_1 ( ) { final TYPE_2 properties = TYPE_3 . VAR_2 . METHOD_2 ( ) ; <START> properties . VAR_3 ( ) . addAll ( METHOD_3 ( ) . entrySet ( ) ) ; <END> return properties ; }
public TYPE_1 METHOD_1 ( ) { final TYPE_2 properties = TYPE_3 . VAR_2 . METHOD_2 ( ) ; for ( final Entry < String , Object > entry : METHOD_3 ( ) . entrySet ( ) ) { properties . VAR_3 ( ) . put ( entry . getKey ( ) , entry . getValue ( ) ) ; } return properties ; }
sync
<START> public static TYPE_1 getInstance ( ) { <END> if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( ) ; } return VAR_1 ; }
public static synchronized TYPE_1 getInstance ( ) { if ( VAR_1 == null ) { VAR_1 = new TYPE_1 ( ) ; } return VAR_1 ; }
s a bug VAR_11 compile work ( a warning ) I ll remove extra
private void METHOD_1 ( Throwable t ) { if ( message . VAR_1 ( ) ) { TYPE_1 response = new TYPE_1 ( TYPE_2 . TYPE_7 . VAR_3 ) . METHOD_2 ( TYPE_5 . VAR_5 , TYPE_2 . VAR_6 ) ; if ( t instanceof TYPE_3 ) { <START> response = response . VAR_7 ( TYPE_5 . VAR_8 . VAR_8 , TYPE_4 . METHOD_3 ( TYPE_6 . VAR_10 . VAR_11 ) ) ; <END> } TYPE_2 . instance ( ) . METHOD_4 ( response , id , message . from ) ; } }
private void METHOD_1 ( Throwable t ) { if ( message . VAR_1 ( ) ) { TYPE_1 response = new TYPE_1 ( TYPE_2 . TYPE_7 . VAR_3 ) . METHOD_2 ( TYPE_5 . VAR_5 , TYPE_2 . VAR_6 ) ; if ( t instanceof TYPE_3 ) { response = response . VAR_7 ( TYPE_5 . VAR_8 , TYPE_4 . METHOD_3 ( TYPE_6 . VAR_10 . VAR_11 ) ) ; } TYPE_2 . instance ( ) . METHOD_4 ( response , id , message . from ) ; } }
I m surprised VAR_2 return Optional : )
public Optional < TYPE_1 > METHOD_1 ( TYPE_2 context ) { <START> final String VAR_1 = context . VAR_2 ( this . VAR_3 ) ; <END> final String VAR_4 = context . VAR_2 ( this . VAR_5 ) ; if ( VAR_1 == null || VAR_4 == null ) { return Optional . empty ( ) ; } return Optional . of ( new TYPE_1 ( VAR_1 , VAR_4 ) ) ; }
public Optional < TYPE_1 > METHOD_1 ( TYPE_2 context ) { final Optional < String > VAR_1 = context . VAR_2 ( this . VAR_3 ) ; final Optional < String > VAR_4 = context . VAR_2 ( this . VAR_5 ) ; if ( VAR_1 . isPresent ( ) && VAR_4 . isPresent ( ) ) { return Optional . of ( new TYPE_1 ( VAR_1 . get ( ) , VAR_4 . get ( ) ) ) ; } return Optional . empty ( ) ; }
editor open ( ) BP hit debug view hidden - a single window open java perspective start debugging close editor hide view resume times editor opened
public void METHOD_1 ( TYPE_1 VAR_1 ) { <START> METHOD_2 ( VAR_1 , <END> false ) ; }
public void METHOD_1 ( TYPE_1 VAR_1 ) { }
I don t modify generated methods need set merge
public boolean METHOD_1 ( ) { <START> if ( parent != null ) { <END> return parent . VAR_1 ( ) ; } return VAR_2 ; }
public boolean METHOD_1 ( ) { return VAR_2 ; }
final
<START> public TYPE_1 value ( ) { <END> return METHOD_1 ( ) . run ( ) ; }
public final TYPE_1 value ( ) { return METHOD_1 ( ) . run ( ) ; }
operands initialized : VAR_3 = VAR_3 ; super ( ) constructor required
private TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_2 VAR_4 ) { <START> super ( VAR_3 , VAR_4 ) ; <END> this . VAR_2 = VAR_2 ; }
private TYPE_3 ( TYPE_1 VAR_2 , TYPE_2 VAR_3 , TYPE_2 VAR_4 ) { this . VAR_2 = VAR_2 ; this . VAR_3 = VAR_3 ; this . VAR_4 = VAR_4 ; }
please 4 loop vars node delta
private void METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_2 = new HashMap < > ( 1 ) ; return ; } VAR_2 = new HashMap < > ( VAR_1 . size ( ) * 4 / 3 ) ; for ( TYPE_1 <START> element : <END> VAR_1 ) { METHOD_2 ( element ) ; } }
private void METHOD_1 ( ) { if ( VAR_1 == null ) { VAR_2 = new HashMap < > ( 1 ) ; return ; } VAR_2 = new HashMap < > ( VAR_1 . size ( ) * 4 / 3 ) ; for ( TYPE_1 node : VAR_1 ) { METHOD_2 ( node ) ; } }
please [ - - resources ] ( ) statement instead handling manually
public File METHOD_1 ( Collection < TYPE_1 > VAR_1 , TYPE_2 VAR_2 ) throws IOException { TYPE_3 VAR_3 = new TYPE_3 ( ) ; File file = new File ( STRING_1 ) ; TYPE_4 VAR_4 = new TYPE_4 ( file ) ; <START> try { <END> VAR_3 . METHOD_2 ( VAR_1 , VAR_4 , new File ( VAR_2 ) ) ; } catch ( IOException e ) { throw new IOException ( e . getMessage ( ) ) ; } finally { VAR_4 . METHOD_3 ( ) ; VAR_4 . close ( ) ; } return file ; }
public File METHOD_1 ( Collection < TYPE_1 > VAR_1 , TYPE_2 VAR_2 ) throws IOException { TYPE_3 VAR_3 = new TYPE_3 ( ) ; File file = new File ( STRING_1 ) ; try ( TYPE_4 VAR_4 = new TYPE_4 ( file ) ) { VAR_3 . METHOD_2 ( VAR_1 , VAR_4 , new File ( VAR_2 ) ) ; } catch ( IOException e ) { throw new IOException ( e . getMessage ( ) ) ; } return file ; }
style : missing braces
private TYPE_1 source ( TYPE_2 iterator ) { <START> if ( iterator instanceof TYPE_3 ) <END> return TYPE_1 . create ( ( TYPE_3 ) iterator ) ; return TYPE_1 . create ( db . VAR_1 ( ) ) ; }
private TYPE_1 source ( TYPE_2 iterator ) { if ( iterator instanceof TYPE_3 ) { return TYPE_1 . create ( ( TYPE_3 ) iterator ) ; } return TYPE_1 . create ( db . VAR_1 ( ) ) ; }
submonitor needed method original monitor passed mutually exclusive method calls
public void METHOD_1 ( TYPE_1 VAR_1 , int options , TYPE_2 monitor ) throws TYPE_3 { TYPE_4 <START> VAR_2 = <END> TYPE_4 . METHOD_2 ( monitor , 1 ) ; final TYPE_5 VAR_3 = METHOD_3 ( VAR_4 . NONE , null ) ; if ( VAR_3 . METHOD_4 ( ) ) { METHOD_5 ( VAR_3 , VAR_1 , options , VAR_2 . split ( 1 ) ) ; } else { METHOD_6 ( VAR_3 , VAR_1 , options , VAR_2 . split ( 1 ) ) ; } }
public void METHOD_1 ( TYPE_1 VAR_1 , int options , TYPE_2 monitor ) throws TYPE_3 { final TYPE_5 VAR_3 = METHOD_3 ( VAR_4 . NONE , null ) ; if ( VAR_3 . METHOD_4 ( ) ) { METHOD_5 ( VAR_3 , VAR_1 , options , monitor ) ; } else { METHOD_6 ( VAR_3 , VAR_1 , options , monitor ) ; } }
I meant brackets encapsulate entire rest method
public void METHOD_1 ( ) { if ( VAR_1 != null && VAR_2 == TYPE_2 . VAR_4 ) <START> VAR_1 . METHOD_2 ( ) ; <END> VAR_2 = TYPE_2 . VAR_5 ; try { METHOD_3 ( ) ; } catch ( Exception e ) { throw new TYPE_1 ( e ) ; } }
public void METHOD_1 ( ) { if ( VAR_1 != null && VAR_2 == TYPE_2 . VAR_4 ) { VAR_1 . METHOD_2 ( ) ; VAR_2 = TYPE_2 . VAR_5 ; try { METHOD_3 ( ) ; } catch ( Exception e ) { throw new TYPE_1 ( e ) ; } } }
case jadx replace continue else I correct change jadx don t information restore VAR_2 I miss ? P S time complex VAR_2 write check method check method logic changed transformations decompilation ( example [ _CODE_ ] ( ) test ) VAR_2 changed heavily logic preserved hard check case eye
public void METHOD_1 ( ) throws Exception { TYPE_1 VAR_1 = METHOD_2 ( TYPE_2 . class ) ; String VAR_2 = VAR_1 . METHOD_3 ( ) . toString ( ) ; <START> assertThat ( VAR_2 , METHOD_4 ( STRING_1 ) ) ; <END> }
public void METHOD_1 ( ) throws Exception { METHOD_2 ( TYPE_2 . class ) ; }
_CODE_
public List < TYPE_1 > METHOD_1 ( ) { METHOD_2 ( ) ; <START> return VAR_1 . values ( ) . stream ( ) . collect ( Collectors . VAR_2 ( ) ) ; <END> }
public Set < String > METHOD_1 ( ) { METHOD_2 ( ) ; return VAR_1 ; }
worth extending timeout ? AFIACT won t effect correct working latch prevent issues tests running especially slow device / simulator
public void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , Map < String , String > VAR_3 ) throws TYPE_2 , TYPE_3 { try { <START> VAR_4 . METHOD_2 ( INT_1 , TimeUnit . VAR_5 ) ; <END> } catch ( InterruptedException exception ) { exception . VAR_6 ( ) ; } super . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 ) ; }
public void METHOD_1 ( String VAR_1 , TYPE_1 VAR_2 , Map < String , String > VAR_3 ) throws TYPE_2 , TYPE_3 { try { VAR_4 . METHOD_2 ( 100 , TimeUnit . VAR_5 ) ; } catch ( InterruptedException exception ) { exception . VAR_6 ( ) ; } super . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 ) ; }
method - static private - isn t class
<START> public static String <END> METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { return METHOD_1 ( VAR_1 , VAR_2 , VAR_1 . METHOD_2 ( ) ) ; }
private String METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 ) { return METHOD_1 ( VAR_1 , VAR_2 , VAR_1 . METHOD_2 ( ) ) ; }
remove seq
private void METHOD_1 ( String VAR_1 , int VAR_2 , String message , Object ... VAR_3 ) { TYPE_1 . METHOD_2 ( VAR_2 , METHOD_3 ( VAR_1 ) , ( TYPE_2 ) METHOD_4 ( VAR_1 , VAR_4 , false ) , ( TYPE_2 ) METHOD_4 ( VAR_1 , VAR_5 , false ) , message , VAR_3 ) ; VAR_6 . remove ( VAR_1 ) ; <START> METHOD_5 ( ) . METHOD_6 ( ) . METHOD_7 ( VAR_1 ) ; <END> }
private void METHOD_1 ( String VAR_1 , int VAR_2 , String message , Object ... VAR_3 ) { TYPE_1 . METHOD_2 ( VAR_2 , METHOD_3 ( VAR_1 ) , ( TYPE_2 ) METHOD_4 ( VAR_1 , VAR_4 , false ) , ( TYPE_2 ) METHOD_4 ( VAR_1 , VAR_5 , false ) , message , VAR_3 ) ; METHOD_5 ( ) . METHOD_6 ( ) . METHOD_7 ( VAR_1 ) ; VAR_6 . remove ( VAR_1 ) ; }
VAR_4 null ( don t null check equals ( ) method ) change
private int METHOD_1 ( ) { int result = System . VAR_1 ( VAR_2 ) ; result = INT_1 * result + System . VAR_1 ( VAR_3 ) ; <START> result = INT_1 * result + ( VAR_4 != null ? VAR_4 . METHOD_2 ( ) : 0 ) ; <END> result = INT_1 * result + System . VAR_1 ( VAR_5 ) ; return result ; }
private int METHOD_1 ( ) { int result = System . VAR_1 ( VAR_2 ) ; result = INT_1 * result + System . VAR_1 ( VAR_3 ) ; result = INT_1 * result + VAR_4 . METHOD_2 ( ) ; result = INT_1 * result + System . VAR_1 ( VAR_5 ) ; return result ; }
I suspect code unused ( lightly ) else complained doesn t work processor max ( 1 TYPE_1 METHOD_3 ( ) METHOD_4 ( ) - 1 )
public int METHOD_1 ( ) { int VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != VAR_2 ) { return VAR_1 ; } else { <START> return TYPE_1 . METHOD_3 ( ) . METHOD_4 ( ) - 1 ; <END> } }
public int METHOD_1 ( ) { int VAR_1 = METHOD_2 ( ) ; if ( VAR_1 != VAR_2 ) { return VAR_1 ; } else { return Math . max ( TYPE_1 . METHOD_3 ( ) . METHOD_4 ( ) - 1 , 1 ) ; } }
shouldn t store application a slug abstract implementation control rely implementation calling method
<START> protected String METHOD_1 ( TYPE_1 id ) { <END> return STRING_1 + VAR_1 . METHOD_2 ( id . VAR_2 ( ) ) ; }
private String METHOD_1 ( TYPE_1 id ) { return STRING_1 + VAR_1 . METHOD_2 ( id . VAR_2 ( ) ) ; }
invoking METHOD_2 ( true ) a fragment UI risky ( / leak views ) need ? _CODE_ currently holds a reference activity leak a configuration change wdyt
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { <START> METHOD_2 ( true ) ; <END> return new TYPE_3 ( METHOD_3 ( ) , METHOD_4 ( ) ) ; }
public TYPE_1 METHOD_1 ( TYPE_2 VAR_1 ) { return new TYPE_3 ( METHOD_3 ( ) , METHOD_4 ( ) ) ; }
redundant instanceof casts
public boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { <START> if ( ! TYPE_4 . METHOD_2 ( VAR_1 ) && this instanceof TYPE_5 && ( ( TYPE_5 ) this ) . METHOD_3 ( ) ) { <END> for ( TYPE_2 VAR_4 : ( ( TYPE_5 ) this ) . METHOD_4 ( VAR_1 , VAR_3 . VAR_5 , VAR_3 , VAR_2 ) ) { METHOD_5 ( VAR_1 , VAR_3 , VAR_4 , VAR_2 ) ; } } return super . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 ) ; }
public boolean METHOD_1 ( TYPE_1 VAR_1 , TYPE_2 VAR_2 , TYPE_3 VAR_3 ) { if ( ! TYPE_4 . METHOD_2 ( VAR_1 ) && this . METHOD_3 ( ) ) { for ( TYPE_2 VAR_4 : ( ( TYPE_5 ) this ) . METHOD_4 ( VAR_1 , VAR_3 . VAR_5 , VAR_3 , VAR_2 ) ) { METHOD_5 ( VAR_1 , VAR_3 , VAR_4 , VAR_2 ) ; } } return super . METHOD_1 ( VAR_1 , VAR_2 , VAR_3 ) ; }
subclasses allowed override method
<START> protected void METHOD_1 ( final TYPE_1 VAR_1 ) { <END> if ( VAR_1 != null ) { VAR_2 . METHOD_1 ( VAR_3 . VAR_4 . create ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( ) ) ; } }
protected final void METHOD_1 ( final TYPE_1 VAR_1 ) { if ( VAR_1 != null ) { VAR_2 . METHOD_1 ( VAR_3 . VAR_4 . create ( VAR_1 . METHOD_2 ( ) ) . METHOD_3 ( ) ) ; } }
mag 1 weg
public TYPE_1 METHOD_1 ( TYPE_2 message , TYPE_3 session ) throws TYPE_4 { <START> try { try ( TYPE_5 target = TYPE_5 . METHOD_2 ( this , session , METHOD_3 ( ) ) ) { try ( TYPE_6 out = target . VAR_1 ( ) ) { <END> VAR_2 . run ( message . VAR_3 ( ) , out ) ; } return target . VAR_4 ( ) ; } } catch ( Exception e ) { throw new TYPE_4 ( this , STRING_1 , e ) ; } }
public TYPE_1 METHOD_1 ( TYPE_2 message , TYPE_3 session ) throws TYPE_4 { try ( TYPE_5 target = TYPE_5 . METHOD_2 ( this , session , METHOD_3 ( ) ) ) { try ( TYPE_6 out = target . VAR_1 ( ) ) { VAR_2 . run ( message . VAR_3 ( ) , out ) ; } return target . VAR_4 ( ) ; } catch ( Exception e ) { throw new TYPE_4 ( this , STRING_1 , e ) ; } }
&& more line existing coding pattern minor
public void METHOD_1 ( TYPE_1 session , Object VAR_1 ) { session . VAR_2 ( VAR_3 , VAR_1 ) ; if ( VAR_4 != null ) { <START> if ( VAR_4 . METHOD_2 ( VAR_1 ) . METHOD_3 ( ) < 0 ) { <END> throw new TYPE_2 ( STRING_1 ) ; } } VAR_5 . METHOD_4 ( session , VAR_1 ) ; }
public void METHOD_1 ( TYPE_1 session , Object VAR_1 ) { session . VAR_2 ( VAR_3 , VAR_1 ) ; if ( VAR_4 != null && VAR_4 . METHOD_2 ( VAR_1 ) . METHOD_3 ( ) < 0 ) { throw new TYPE_2 ( STRING_1 ) ; } VAR_5 . METHOD_4 ( session , VAR_1 ) ; }
false enough constant
private static boolean METHOD_1 ( TYPE_1 VAR_1 , Map < String , TYPE_2 > VAR_2 ) { String VAR_3 = VAR_1 . getKey ( ) ; TYPE_2 VAR_4 = VAR_2 . get ( VAR_3 ) ; if ( VAR_4 == null ) { if ( TYPE_1 . Type . VAR_5 == VAR_1 . getType ( ) ) { <START> return VAR_6 ; <END> } throw new IllegalStateException ( String . format ( STRING_1 , VAR_3 ) ) ; } return VAR_4 . METHOD_2 ( ) ; }
private static boolean METHOD_1 ( TYPE_1 VAR_1 , Map < String , TYPE_2 > VAR_2 ) { String VAR_3 = VAR_1 . getKey ( ) ; TYPE_2 VAR_4 = VAR_2 . get ( VAR_3 ) ; if ( VAR_4 == null ) { if ( TYPE_1 . Type . VAR_5 == VAR_1 . getType ( ) ) { return false ; } throw new IllegalStateException ( String . format ( STRING_1 , VAR_3 ) ) ; } return VAR_4 . METHOD_2 ( ) ; }
I missing method doesn t throws a TYPE_2 throw e
<START> public void error ( TYPE_1 e ) throws TYPE_2 { <END> if ( VAR_1 == null ) { VAR_1 = e ; VAR_2 = new StringBuilder ( INT_1 ) ; VAR_2 . append ( CHAR_1 ) . append ( VAR_3 ) . append ( CHAR_1 ) . append ( STRING_1 ) ; } VAR_2 . append ( CHAR_2 ) . append ( e . toString ( ) ) ; }
public void error ( TYPE_1 e ) { if ( VAR_1 == null ) { VAR_1 = e ; VAR_2 = new StringBuilder ( INT_1 ) ; VAR_2 . append ( CHAR_1 ) . append ( VAR_3 ) . append ( CHAR_1 ) . append ( STRING_1 ) ; } VAR_2 . append ( CHAR_2 ) . append ( e . toString ( ) ) ; }
shouldn t METHOD_3 ( true ) ? I flag meant identify - hosted WP logins WP signups count
public void METHOD_1 ( String name , String VAR_1 , String VAR_2 , String VAR_3 ) { TYPE_1 . METHOD_2 ( TYPE_1 . TYPE_3 . VAR_5 ) ; <START> VAR_6 . METHOD_3 ( false ) ; <END> if ( VAR_7 ) { TYPE_2 . METHOD_4 ( this , name , VAR_1 , VAR_2 , VAR_3 , false ) ; } else { TYPE_2 . METHOD_5 ( this , name , VAR_1 , VAR_2 , VAR_3 ) ; } METHOD_6 ( TYPE_4 . VAR_9 ) ; METHOD_7 ( ) ; }
public void METHOD_1 ( String name , String VAR_1 , String VAR_2 , String VAR_3 ) { TYPE_1 . METHOD_2 ( TYPE_1 . TYPE_3 . VAR_5 ) ; if ( VAR_7 ) { TYPE_2 . METHOD_4 ( this , name , VAR_1 , VAR_2 , VAR_3 , false ) ; } else { TYPE_2 . METHOD_5 ( this , name , VAR_1 , VAR_2 , VAR_3 ) ; } METHOD_6 ( TYPE_4 . VAR_9 ) ; METHOD_7 ( ) ; }
warning : static field _CODE_ logger accessed a static
protected void log ( final Level VAR_1 , final String msg , final Throwable t ) { <START> this . logger . log ( VAR_1 , this . VAR_2 + STRING_1 + msg , t ) ; <END> }
protected void log ( final Level VAR_1 , final String msg , final Throwable t ) { this . LOGGER . log ( VAR_1 , this . VAR_2 + STRING_1 + msg , t ) ; }
minor : static
<START> private short [ ] METHOD_1 ( int [ ] VAR_1 ) { <END> if ( VAR_1 == null ) { return null ; } short [ ] VAR_2 = new short [ VAR_1 . length ] ; for ( int i = 0 ; i < VAR_2 . length ; i ++ ) { VAR_2 [ i ] = METHOD_2 ( VAR_1 [ i ] ) ; } return VAR_2 ; }
private static short [ ] METHOD_1 ( int [ ] VAR_1 ) { if ( VAR_1 == null ) { return null ; } short [ ] VAR_2 = new short [ VAR_1 . length ] ; for ( int i = 0 ; i < VAR_2 . length ; i ++ ) { VAR_2 [ i ] = METHOD_2 ( VAR_1 [ i ] ) ; } return VAR_2 ; }
ここは、 VAR_3 addAll ( VAR_1 ) ; γ¨ζ›Έγγ¨γ™γ£γγ‚Šγ—γΎγ™γ­γ€‚
protected void METHOD_1 ( List < TYPE_1 > VAR_1 ) { if ( VAR_1 == null ) { METHOD_2 ( STRING_1 , STRING_2 ) ; } else { <START> for ( TYPE_1 VAR_2 : VAR_1 ) { <END> VAR_3 . add ( VAR_2 ) ; } } for ( int i = 0 ; i < INT_1 ; i ++ ) VAR_3 . add ( new TYPE_1 ( STRING_3 + i , STRING_4 + i , STRING_5 + i ) ) ; VAR_4 . METHOD_3 ( ) ; }
protected void METHOD_1 ( List < TYPE_1 > VAR_1 ) { if ( VAR_1 == null ) { METHOD_2 ( STRING_1 , STRING_2 ) ; } else { VAR_4 . clear ( ) ; for ( TYPE_1 VAR_2 : VAR_1 ) { VAR_4 . add ( VAR_2 ) ; } VAR_4 . METHOD_3 ( ) ; } }
picking don t need extra brackets s : VAR_5 = STRING_1 equalsIgnoreCase ( VAR_3 ) ? TYPE_1 VAR_7 : TYPE_1 VAR_8 ;
public TYPE_2 ( String VAR_2 , String VAR_3 ) { VAR_4 = VAR_2 . substring ( 1 , VAR_2 . length ( ) - 1 ) ; <START> VAR_5 = ( STRING_1 . equalsIgnoreCase ( VAR_3 ) ) ? TYPE_1 . VAR_7 : TYPE_1 . VAR_8 ; <END> }
public TYPE_2 ( String VAR_2 , String VAR_3 ) { VAR_4 = VAR_2 . substring ( 1 , VAR_2 . length ( ) - 1 ) ; VAR_5 = STRING_1 . equalsIgnoreCase ( VAR_3 ) ? TYPE_1 . VAR_7 : TYPE_1 . VAR_8 ; }
nulls allowed filter - deterministic ; consider adding a test array ( real ) test _CODE_ = filter = = null || VAR_6 || filter VAR_9 ( ) ;
public TYPE_4 ( TYPE_1 VAR_2 , Optional < TYPE_2 > filter , boolean VAR_3 , TYPE_3 VAR_4 ) { this . VAR_2 = METHOD_1 ( VAR_2 , STRING_1 ) ; this . filter = filter . VAR_5 ( null ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = METHOD_1 ( VAR_4 , STRING_2 ) ; this . VAR_6 = this . filter != null && ! this . filter . VAR_7 ( ) ; <START> this . VAR_8 = this . filter == null || this . filter . VAR_9 ( ) ; <END> }
public TYPE_4 ( TYPE_1 VAR_2 , Optional < TYPE_2 > filter , boolean VAR_3 , TYPE_3 VAR_4 ) { this . VAR_2 = METHOD_1 ( VAR_2 , STRING_1 ) ; this . filter = filter . VAR_5 ( null ) ; this . VAR_3 = VAR_3 ; this . VAR_4 = METHOD_1 ( VAR_4 , STRING_2 ) ; this . VAR_6 = this . filter != null && ! this . filter . VAR_7 ( ) ; this . VAR_8 = this . filter == null || VAR_6 || this . filter . VAR_9 ( ) ; }
need clear collection inbound collection null drop entire single line : VAR_1 = VAR_1 ! = null ? new HashSet < > ( VAR_1 ) : null ;
public void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { this . VAR_2 = null ; if ( VAR_1 != null ) { <START> this . VAR_1 = new HashSet < > ( VAR_1 ) ; <END> } }
public void METHOD_1 ( Collection < TYPE_1 > VAR_1 ) { this . VAR_2 = null ; if ( VAR_1 != null ) { this . VAR_1 = new HashSet < > ( VAR_1 ) ; } else { this . VAR_1 = new HashSet < > ( ) ; } }
changes line relevant _CODE_ please remove modify : _CODE_ _CODE_ ( ) METHOD_2 ( ) instead a safe a follower patch
public TYPE_1 ( T parameters ) { super ( parameters ) ; <START> this . METHOD_1 ( METHOD_2 ( ) . METHOD_3 ( ) ) ; <END> }
public TYPE_1 ( T parameters ) { super ( parameters ) ; }
need close directory stream
private Collection < File > METHOD_1 ( File VAR_1 ) throws IOException { Collection < File > VAR_2 = new ArrayList < > ( ) ; <START> TYPE_1 < Path > VAR_3 = TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) , STRING_1 ) ; <END> VAR_3 . forEach ( path - > VAR_2 . add ( path . VAR_4 ( ) ) ) ; return VAR_2 ; }
private Collection < File > METHOD_1 ( File VAR_1 ) throws IOException { Collection < File > VAR_2 = new ArrayList < > ( ) ; TYPE_1 < Path > VAR_3 = TYPE_2 . METHOD_2 ( VAR_1 . METHOD_3 ( ) , STRING_1 ) ; VAR_3 . forEach ( path - > VAR_2 . add ( path . VAR_4 ( ) ) ) ; VAR_3 . close ( ) ; return VAR_2 ; }
url checked null
private String METHOD_1 ( ) { TYPE_1 VAR_1 = getClass ( ) . METHOD_2 ( ) ; if ( VAR_1 instanceof TYPE_2 ) { <START> TYPE_3 url = ( ( TYPE_2 ) VAR_1 ) . METHOD_3 ( TYPE_5 . VAR_3 ) ; <END> try { TYPE_4 VAR_4 = new TYPE_4 ( url . VAR_5 ( ) ) ; return VAR_4 . METHOD_4 ( ) . getValue ( STRING_1 ) ; } catch ( IOException e ) { } } return null ; }
private String METHOD_1 ( ) { TYPE_1 VAR_1 = getClass ( ) . METHOD_2 ( ) ; if ( VAR_1 instanceof TYPE_2 ) { TYPE_3 url = ( ( TYPE_2 ) VAR_1 ) . METHOD_3 ( TYPE_5 . VAR_3 ) ; if ( url != null ) return METHOD_1 ( url ) ; } return null ; }
simpler : javabind ( TYPE_6 class ) ( TYPE_7 class ) ;
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; METHOD_2 ( new TYPE_1 ( ) ) ; bind ( new TYPE_2 < TYPE_3 < TYPE_4 > > ( ) { } ) . to ( new TYPE_2 < TYPE_5 > ( ) { } ) ; <START> bind ( TYPE_6 . class ) . to ( new TYPE_2 < TYPE_7 > ( ) { } ) ; <END> }
protected void METHOD_1 ( ) { super . METHOD_1 ( ) ; METHOD_2 ( new TYPE_1 ( ) ) ; bind ( TYPE_6 . class ) . to ( TYPE_7 . class ) ; }
done test case _CODE_ s constructor line 33
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( ) ; TYPE_2 user = METHOD_3 ( TYPE_2 . class ) ; when ( VAR_1 . remove ( METHOD_4 ( ) ) ) . METHOD_5 ( 1 ) ; <START> VAR_2 . METHOD_6 ( TYPE_3 . TYPE_4 , INT_1 ) ; <END> VAR_5 . METHOD_7 ( session , user ) ; }
public void METHOD_1 ( ) { TYPE_1 . METHOD_2 ( ) ; TYPE_2 user = METHOD_3 ( TYPE_2 . class ) ; when ( VAR_1 . remove ( METHOD_4 ( ) ) ) . METHOD_5 ( 1 ) ; VAR_5 . METHOD_7 ( session , user ) ; }
useless statement
public void clear ( ) { VAR_1 . clear ( ) ; <START> ; <END> VAR_2 . clear ( ) ; METHOD_1 ( ) . clear ( ) ; }
public void clear ( ) { VAR_1 . clear ( ) ; VAR_2 . clear ( ) ; METHOD_1 ( ) . clear ( ) ; }
I d write : VAR_2 = _CODE_ I d method a checkstyle warning
public void METHOD_1 ( float VAR_1 ) { <START> VAR_2 = VAR_1 ; <END> }
public void METHOD_1 ( float VAR_1 ) { this . VAR_2 = VAR_1 ; }
i ! testing purposes src / test correct stay πŸ‘
public void METHOD_1 ( TYPE_1 task ) throws TYPE_2 { boolean contains = false ; <START> for ( String VAR_1 : VAR_2 ) { <END> if ( VAR_1 . equals ( task . getName ( ) ) ) { contains = true ; break ; } } if ( ! contains ) { VAR_2 . add ( task . getName ( ) ) ; } }
public void METHOD_1 ( TYPE_1 task ) throws TYPE_2 { if ( ! VAR_2 . contains ( task ) ) { VAR_2 . add ( task ) ; } }