WhereIsAI/github-issue-similarity huggingface dataset:
Issue 1:
Electron version: Latest

Operating system: OSX, Windows

I've been rebuilding the spellchecker for notion.so and I thought I would compile some of the quirks I ran into.

The de facto solution right now is to use electron-spellchecker and we've been using it for the past year, but recently the language auto-detect stopped working on Mac. Probably a recent OS update or something. Slack has language select in their settings menu so I'd imagine fixing this issue isn't such a high priority for them (I believe the maintainer works there ;).

So I went about building my own solution that uses node-cld to detect the language on selectionchange events and node-spellchecker to access native spellcheck APIs on MacOS and Window 8+. Here are some feature requests:

Async webFrame.setSpellCheckProvider #10734 -- if we could throttle spellcheck to wait for users to stop typing, there would be a lot less jank and feel a lot more performant.

webFrame.checkSpelling(elm: HTMLElement) -- currently, a user has to move their selection through an editable element before the spellchecker will run. It would be nice if we could trigger this manually.

webContents.replaceMisspelling doesn't remove misspelling underline -- The webFrame.checkSpelling API could be a simple workaround to fix this.

Multi-language support is not quite possible because the webFrame.setSpellCheckProvider API only lets you check one word at a time. Thus you cannot have multiple languages in the same input because it needs to decide on only one language. One solution is for the API to pass the entire textContent and return a list of selections that are misspelled.

Tangentially related: node-spellchecker has Add to Dictionary and Remove from Dictionary support, but it doesn't have isAddedToDictionary so its hard to know when to show the Remove from Dictionary option in the context menu.

Finally, I just want to highlight how good the Google Chrome spellchecker is. It handles language detection with multiple languages in the same input. Its asynchronous and non-blocking. It has all the native dictionary support. If we were able to pull the Google Chrome spellchecker into Chromium, then all the Electron-based note taking apps and email clients would benefit greatly. #3211

CC: @paulcbetts

Thanks!

Issue 2:
On OS X apart from the basic spell-checking it also provides a "Spelling and Grammar" menu that allows some more advanced operations:

Chrome browser has implemented most of the features, we should find a way to make Electron apps use it without any pain.
Issue 1:
The current implementation of the Image Sizes listview is having usability issues: the trash can icon gets cut off while the design is not following OS design guidelines for lists. It allows for in-line editing, which makes sense in a datagrid that holds a lot of information that you want to 'quick edit'.

The issues:

The ListView is too wide, the delete button gets cut off on smaller resolutions (and the default window width)

Users reported that they would like to have a better description of the stretch modes, there's no space to integrate that.

Inline editing is common for DataGrids, not for ListViews.

Current state:

Proposal (non-functional XAML mock-up):

Would be great to get feedback on this - any features we'd be missing, any UX concerns?

If you'd like to see this feature implemented, add a 👍 reaction to this post.

Issue 2:
We should restructure the table to make it easier to visually capture the table.

Original

Proposal
Issue 1:
Lines 808/809

button(): JQuery;
button(methodName: string): JQuery;

and line 1007

tooltip(methodName: string): JQuery;

cause "Duplicate overload signature".

Issue 2:
Today my builds started failing because of a conflict between requirejs and node require

This is the compile error I received from typescript:

d:/a/1/s/node_modules/@types/node/index.d.ts(99,13):
error TS2403: Subsequent variable declarations must have the same type.
Variable 'require' must be of type 'Require', but here has type 'NodeRequire'.

Lookin at the npm install diff since last known good built showed that it was introduced from react-dom:

15.5.1 didn't have the dependency to @types/node
Issue 1:
System info

Playwright Version: [v1.32.1]

Operating System: [Windows 10]

Browser: [ Chromium]

Source code

I provided exact source code that allows reproducing the issue locally.

Link to the GitHub repository with the repro

Config file

Test file (self-contained)

sync getText(): Promise<string> {
const context = await chromium.launchPersistentContext('C:\\temp\\playwright-cache', {headless: false, channel: 'chrome' });
const page = context.pages()[0];
await page.goto("url behind SSO");
//here user login to the SSO manually for the first time
const text= await page.locator('cssSelector').innerHTML({timeout: 60*1000});
await page.close();
return text
}

Steps

Playwright opens a browser with persistent context

Playwright navigates to a URL with behind SSO

User enters credentials and logins

Playwright grabs the text and we return it

Function is run for second time

Expected

SSO not to be shown as user has already logged in once.

Actual

SSO page is shown every time as session is not saved.

Workaround

If await page.close(); is removed, session is correctly saved at the end of the test run and SSO page is no longer shown. However, the browser that was used to get the text required for other tests (that run in an non-persistent browser) remains open through out the test suite running and that is not ideal.

It was mentioned in this issue that page is being closed too early and it is causing the session not to be persisted.

However, adding some explicit timeout to try this theory did not proof useful:

await page.waitForTimeout(30000);

it seem like that as long as the page closed via page.close(), it is not saving the session.

Note:

Due to compliance and other technical decisions, this is the only way that I am able to save session instead of using storageState.

I already raised this issue this issue, however, it was closed without an answer that works. So I am not sure if I should leave a comment there or create a new issue. Please advice.

Issue 2:
It would be great if Playwright had something similar to CodeceptJS methods:

or

I guess this could be in a form similar to waitForProperty? which waits for an element to exist and waits for a property of key and value

e.g. waitForProperty(selector, "innerText", "Foo",{timeout}) waitForProperty(selector, "value", "bar",{timeout})
Issue 1:
Hi, I'm noticing that the back button doesn't trigger getInitialProps.

I have searched the issues of this repository and believe that this is not a duplicate.

Steps to Reproduce

Go to https://wecured.com/condition/depression

Click on 'Symptoms' tab, which will trigger a shallow client transition.

Click on 'hay fever' on the left rail, which will trigger a client transition.

Press back.

Expected: page should end up on the depression page with symptoms tab.

Actual: page ended up on hay fever on the symptoms tab.

I did some debugging and found that this is because getInitialProps wasn't called.

Issue 2:
I have an app with a single page index.js, and I parse the query parameters in getInitialProps:

static async getInitialProps ({query}) {
console.log('PAGE', query.screenId);
try {
const projectData = await ProjectLoader.loadProject(query);
return projectData;
}
catch (err) {
console.error(err);
}
};

I use <Link href={pathname, query} prefetch> tags to build my links.

The screenId property is key to finding the right page to render.

However, when I use the back button in the browser to a page without screenId set, getInitialProps doesn’t return screenId:undefined as expected, but another value (as you can see in the console log):

When I refresh the page, I get the right properties and see the correct results.

The “imaginary” screenId is actually a valid value, but I have no idea where this value comes from.

Why is this happening?
Issue 1:
request.meta['handle_httpstatus_all'] = True
dfd = self.crawler.engine.download(request, info.spider)

When Media Pipeline schedules request it attached handle_httpstatus_all meta which prevents Redirect Middleware from doing it's job. This breaks download of images that require redirect, mostly urls that need to redirect from http to https.

Maybe implement a setting to enable redirects in this pipeline?

Issue 2:
Basically, what's happened is that my spider is unable to download the files because the file_urls provided are actually redirected to the final download link. However, because of the following code, the redirect download middleware is effectively disabled, which makes the download fail.

def _check_media_to_download(self, result, request, info):
if result is not None:
return result
if self.download_func:
# this ugly code was left only to support tests. TODO: remove
dfd = mustbe_deferred(self.download_func, request, info.spider)
dfd.addCallbacks(
callback=self.media_downloaded, callbackArgs=(request, info),
errback=self.media_failed, errbackArgs=(request, info))
else:
request.meta['handle_httpstatus_all'] = True
dfd = self.crawler.engine.download(request, info.spider)
dfd.addCallbacks(
callback=self.media_downloaded, callbackArgs=(request, info),
errback=self.media_failed, errbackArgs=(request, info))
return dfd

And here is the check in the redirect middleware that disables it:

if (request.meta.get('dont_redirect', False) or
response.status in getattr(spider, 'handle_httpstatus_list', []) or
response.status in request.meta.get('handle_httpstatus_list', []) or
request.meta.get('handle_httpstatus_all', False)):
return response

My question is: What is the point of enabling the handling of httpstatus_all, when it effectively disables all of the checks?
Issue 1:
$ npm install @discordjs/opus

npm ERR! cb() never called!

npm ERR! This is an error with npm itself. Please report this error at:

this is the error that i got on installing some packages for my app

Issue 2:
Is there an existing issue for this?

I have searched the existing issues

Current Behavior

When I try to install a package from github using ssh

npm i -g github:georgestech/denis-cli

I have to following output

/usr/local/lib/node_modules/@georgestech/denis-cli $ ls
README.md bin	node_modules package-lock.json package.json types

$ denis
CLI to manage developer's common tasks

VERSION
@georgestech/denis-cli/21.8.24-3379953 linux-x64 node-v14.16.0

USAGE
$ denis [COMMAND]

COMMANDS
help display help for denis

Expected Behavior

When I install the same package from github repository

npm config set @georgestech:registry https://npm.pkg.github.com/
npm config set //npm.pkg.github.com/:_authToken ***
npm i -g @georgestech/denis-cli

I have to following output

/usr/local/lib/node_modules/@georgestech/denis-cli $ ls
README.md bin	lib node_modules package-lock.json package.json types

$ denis
CLI to manage developer's common tasks

VERSION
@georgestech/denis-cli/21.8.24-3379953 linux-x64 node-v14.16.0

USAGE
$ denis [COMMAND]

TOPICS
db manage your local database

COMMANDS
help display help for denis
install install project dependencies
publish publish current project on our github registry
release create a release of the current project using calver version number
update update project dependencies

Steps To Reproduce

on each commit, the github ci do:

update package.json version field with $version
git add package.json package-lock.json
git commit -m "🔖 Release $version"
git tag -a $version -m "🔖 Release $version"
git tag -f -a $daily_version
git push
git push -f --tags

21.8.24-3379953 and 21.8.24 point to the same commit

Environment

OS: Ubuntu 20.04, docker node:lts, github action,...

Node: lts

npm: 6.14.11 and 7@latest
Issue 1:
Describe the bug

There is an issue with some incorrect texture colours when loading a GLTF model via GLTFLoader when WebGLRenderer is instantiated with alpha set to true.

To Reproduce

Steps to reproduce the behavior:

Instantiate WebGLRenderer with alpha set to false.

Code

import * as THREE from "three";
import { GLTFLoader } from "three/examples/jsm/loaders/GLTFLoader";

const renderer = new THREE.WebGLRenderer({
// ...
antialias: true,
alpha: true // this is what causes the texture colour issue
});

const width = 1024;
const height = 768;
const scene = new THREE.Scene();
const camera = new THREE.PerspectiveCamera(75, width / height, 0.1, 1000);

const ambientLight = new THREE.AmbientLight();
scene.add(ambientLight);

// Load model and add to scene
const loader = new GLTFLoader();
loader.load("model.gltf", (gltf) => {
scene.add(gltf.scene);
});

// Render scene
(function render() {
renderer.render(scene, camera);
requestAnimationFrame(animate);
})();

Live Demos

alpha: true
alpha: false

https://codesandbox.io/s/pedantic-cloud-vgppt?file=/src/index.js
https://codesandbox.io/s/dry-http-fdykp?file=/src/index.js

Below is the output where WebGLRenderer has been instantiated with alpha set to true and false

alpha: true
alpha: false

Expected behavior

I believe setting the alpha to true or false shouldn't have an effect on how solid textures are rendered. The expected behaviour would be for textures to render consistently regardless of the alpha setting.

Issue 2:
Redundant AR button on Safari

A clear and concise description of what the bug is. Before submitting, please remove unnecessary sections.

To Reproduce

Steps to reproduce the behavior:

Go to 'AR sample'

See 2 icon of AR overlaid

Expected behavior

Single AR button

Screenshots

Platform:

Device: [Mobile]

OS: [iOS 15]

Browser: [Safari]

Three.js version: [main]
Issue 1:
Pattern comprehension now supports

RETURN [(a)-->(b)-->(c) WHERE b:Movie | [b.year,c.prop1] ] AS myColl

but is does not support

RETURN [(a)-->(b)-->(c),(b)-->(d) WHERE b:Movie | [b.year,c.prop1,d.prop2] ] AS myColl

Issue 2:
Regex Failure for neo4j-admin

Regex not detecting files along path, even though regex has successfully been tested on an online regex platform, as well as in Python. I have tried this regex with, and without double-quotes, and confirmed the path it's intended to represent is valid by successfully ingesting from the full-path.

Neo4j version: 4.4.12

Operating system: Ubuntu 20.04

API/Driver: Neo4j-admin import

Steps to reproduce:

Place multiple .tsv files with headers in a path like this (spread across multiple date sub-directories):

- /media/user/ext4_ssd/tsvs/entities/authors/2022-12-23/authors_xxx.tsv

Execute the following command:

./neo4j-admin import --high-io=true --database=zero --skip-duplicate-nodes --ignore-empty-strings=true --verbose --delimiter='\t' --nodes=authors=/media/user/ext4_ssd/tsvs/entities/.*authors.*.tsv

Expected behavior

ingest all the .tsv files in the dated directory ending with xxx.tsv

Actual behavior

Invalid value for option '--nodes' at index 0 ([<label>[:<label>]...=]<files>): Invalid nodes file: authors=/media/suciokhan/ext4_ssd/extracted_tsvs_mini/entities/.*authors.*.tsv (java.lang.IllegalArgumentException: File '/media/suciokhan/ext4_ssd/extracted_tsvs_mini/entities/.*authors.*.tsv' doesn't exist)

I have attempted this both with/without quoting (single and double) the regex path, as well as replacing "nodes=authors=/path" with "nodes /path", to reflect the example given in the 4.4 operations manual (https://neo4j.com/docs/operations-manual/current/tools/neo4j-admin/neo4j-admin-import/#import-tool-multiple-input-files-regex-example).

Link to similar (closed) issue: #12610
Issue 1:
Currently when users use words that can't be use as an identifier (this case will be more common as module and class becomes strict mode code), we should then have better binding diagnostics to report this error instead of Duplicate identifier '(Missing)'.

Issue 2:
interface Struct {
a: boolean
b: number
}
let v1: Struct = {a: true, b:1}
let v2: Struct = Object.assign({}, v1, {
b: false
})

v2 variable now contains {a: true, b: false}, which is definetely not Struct type. But there is no compile-time error there. How come?
Issue 1:
An arrow function as part of an extends clause requires parenthesis. This was changed before ES2015 became final, see http://wiki.ecmascript.org/doku.php?id=harmony%3Aspecification_drafts#january_20_2014_draft_rev_22

@gabelevi summarized the issue internally at FB:

After "extends" there is a LeftHandSideExpression: http://www.ecma-international.org/ecma-262/6.0/#sec-class-definitions

LeftHandSideExpression is a CallExpression or a NewExpression: http://www.ecma-international.org/ecma-262/6.0/#sec-left-hand-side-expressions

ArrowFunction is an AssignmentExpression: http://www.ecma-international.org/ecma-262/6.0/#sec-assignment-operators

Issue 2:
These non-programs are accepted by babel: !()=>0, a + ()=>0, a || ()=>0, etc.

Arrows should have the precedence of an assignment expression.
Issue 1:
The first failure happened at ~9:20 PST 29/04/2015. The failure looks like that:

/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/density.go:158

Expected error:

<*errors.errorString | 0xc20b84daa0>: {

s: "Controller my-hostname-density3000-75cb549b-ee8e-11e4-ae78-42010af01555: Only found 3052 replicas out of 3000",

}

Controller my-hostname-density3000-75cb549b-ee8e-11e4-ae78-42010af01555: Only found 3052 replicas out of 3000

not to have occurred

It seems that because of some reason we are starting much more pods within a replication controller than expected. Another related failure:

Expected error:

<*errors.errorString | 0xc2083b3050>: {

s: "Number of reported pods changed: 3222 vs 3000",

}

Number of reported pods changed: 3222 vs 3000

not to have occurred

cc @quinton-hoole @lavalamp @bprashanth @fgrzadkowski

Issue 2:
I haven't looked into the details yet, but it seems that a PR went in at around 16:30 PDT today (Wed 04/29) that is causing significantly more e2e failures than usual in our continuous integration.

I'll dig into it in the morning unless one of the oncalls gets there before me.
Issue 1:
The mathtext rendered in the 1.3.1 release does't work with the bundled pyparsing.py module (1.5.0).

Simply installing the latest version of the pyparsing.py module with easy install doesn't work. It does if the matplotlib\pyparsing.py file is overvritten with the newer version (2.0.1).

I don't know why the pyparsing.py module comes with the matplotlib source, but it could be useful to provide an option to allow using that installed manually.

Thank you!

Issue 2:
Bug report

Bug summary

Because IndexFormatter.__call__ doesn't round to the nearest integer but truncates/round up to the next integer, x ticks labels are duplicated when user pans plot to left, displaying values below minimum.

Code for reproduction

import matplotlib.pyplot as plt
from matplotlib.ticker import IndexFormatter

x = [1, 2, 3, 4, 5]
y = [1, 3, 5, 6, 0]
x_labels = ['under', 'a', 'b', 'c', 'd', 'e', 'over']

fig, ax = plt.subplots()
print(x[1])
ax.xaxis.set_major_formatter(IndexFormatter(x_labels))
ax.plot(x, y, '-o')
plt.show()

Actual outcome

class IndexFormatter(Formatter):

[...]

def __call__(self, x, pos=None):
"""
Return the format for tick value `x` at position pos.

The position is ignored and the value is rounded to the nearest
integer ******** NOT TRUE *********, which is used to look up the label.
"""
i = int(x + 0.5)
if i < 0 or i >= self.n:
return ''
else:
return self.labels[i]

IndexFormatter returns self.labels[0] for x = -1 instead of an empty string

Expected outcome

Proposed solution to correct [IndexFormatter] (https://matplotlib.org/3.1.3/_modules/matplotlib/ticker.html#IndexFormatter)

def __call__(self, x, pos=None):
"""
Return the format for tick value `x` at position pos.

The position is ignored and the value is rounded to the nearest
integer, which is used to look up the label.
"""
i = int(round(x))
if i < 0 or i >= self.n:
return ''
else:
return self.labels[i]

Matplotlib version

Matplotlib version: 3.1.3
Issue 1:
Using

pmap(sqrt,[-1]); "some other return val"

hides the error to be displayed to stdout.

This also partially applied to warnings, but I couldn't find a simple way to reproduce it (pmap(warn,["warning"]) actually shows the warning, but nested warnings in my real life code actually don't get displayed).

Issue 2:
@everywhere function do_work(i)
r = [1,2,3][i]
println(r)
return r
end

for r in pmap(do_work, [3,2,1,0])
println("pmap got result")
println(typeof(r))
end

The pmap() call above returns a RemoteException object in the result array instead of re-throwing it.

The output is:

./julia -p4 test.jl
From worker 3: 2
From worker 4: 1
From worker 2: 3
pmap got result
Int64
pmap got result
Int64
pmap got result
Int64
pmap got result
RemoteException

Changing pmap() to map() results in BoundsError as expected.
Issue 1:
I got the following two errors running "nosetests pandas":

FAIL: test_fred_multi (pandas.io.tests.test_data.TestFred)

Traceback (most recent call last):

File "/Users/hbi16088/python-virtual-env/basic/lib/python2.7/site-packages/pandas/util/testing.py", line 1135, in wrapper

return t(_args, *_kwargs)

File "/Users/hbi16088/python-virtual-env/basic/lib/python2.7/site-packages/pandas/io/tests/test_data.py", line 455, in test_fred_multi

assert_frame_equal(received, expected, check_less_precise=True)

File "/Users/hbi16088/python-virtual-env/basic/lib/python2.7/site-packages/pandas/util/testing.py", line 509, in assert_frame_equal

check_less_precise=check_less_precise)

File "/Users/hbi16088/python-virtual-env/basic/lib/python2.7/site-packages/pandas/util/testing.py", line 458, in assert_series_equal

assert_almost_equal(left.values, right.values, check_less_precise)

File "testing.pyx", line 58, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2464)

File "testing.pyx", line 93, in pandas._testing.assert_almost_equal (pandas/src/testing.c:1716)

File "testing.pyx", line 140, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2300)

AssertionError: expected 217.47800 but got 217.46600

FAIL: test_fred_parts (pandas.io.tests.test_data.TestFred)

Traceback (most recent call last):

File "/Users/hbi16088/python-virtual-env/basic/lib/python2.7/site-packages/pandas/util/testing.py", line 1135, in wrapper

return t(_args, *_kwargs)

File "/Users/hbi16088/python-virtual-env/basic/lib/python2.7/site-packages/pandas/io/tests/test_data.py", line 424, in test_fred_parts

self.assertEqual(df.ix['2010-05-01'][0], 217.23)

AssertionError: 217.29900000000001 != 217.23

Issue 2:
Note the duplication of the assignment is not a copy/paste error-- the first one works, the second one fails, presumably because a different path is taken if the column already exists than if it doesn't.

>>> pd.__version__
'0.12.0-1081-ge684bdc'
>>> df = pd.DataFrame({"A": [1,2]})
>>> df._is_copy
False
>>> df.to_pickle("tmp.pk")
>>> df2 = pd.read_pickle("tmp.pk")
>>> hasattr(df2, "_is_copy")
False
>>> df2["B"] = df2["A"]
>>> df2["B"] = df2["A"]
Traceback (most recent call last):
File "<ipython-input-155-e1fb2db534a8>", line 1, in <module>
df2["B"] = df2["A"]
File "/usr/local/lib/python2.7/dist-packages/pandas-0.12.0_1081_ge684bdc-py2.7-linux-i686.egg/pandas/core/frame.py", line 1841, in __setitem__
self._set_item(key, value)
File "/usr/local/lib/python2.7/dist-packages/pandas-0.12.0_1081_ge684bdc-py2.7-linux-i686.egg/pandas/core/frame.py", line 1907, in _set_item
self._check_setitem_copy()
File "/usr/local/lib/python2.7/dist-packages/pandas-0.12.0_1081_ge684bdc-py2.7-linux-i686.egg/pandas/core/generic.py", line 1001, in _check_setitem_copy
if self._is_copy:
File "/usr/local/lib/python2.7/dist-packages/pandas-0.12.0_1081_ge684bdc-py2.7-linux-i686.egg/pandas/core/generic.py", line 1525, in __getattr__
(type(self).__name__, name))
AttributeError: 'DataFrame' object has no attribute '_is_copy'