Issue 1:
I'm submitting a ...

[x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior

Building angular on windows throws the following error:

Error at D:/GitHub/angular/modules/@angular/benchpress/src/reporter/console_reporter.ts:10:21: Cannot find module '../facade/lang'.

There is a missing symlink to facade in benchpress/src. The developer guide advises that running ./scripts/windows/create-symlinks.sh should create the symlinks required, but the text file the script uses as input to decide where to create them is missing an entry for benchpress/src.

Expected behavior

Build should proceed without this error.

Minimal reproduction of the problem with instructions

Clone the angular repo to Windows. Run the create-symlinks.sh script, observe there is no symlink to facade in @angular/benchpress/src/ . After following the other instructions in the developer guide run build.sh and see the error listed above.

What is the motivation / use case for changing the behavior?

It is broken.

Please tell us about your environment:

Windows 10, Bash scripts run on MINGW64 that came with my git installation.

Angular version: 2.0.X

Angular Master Branch forked today.

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

N/A

Language: [all | TypeScript X.X | ES6/7 | ES5]

N/A

Node (for AoT issues): node --version =

N/A

Issue 2:
I'm submitting a ...

[x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior

Building angular on windows throws the following error:

Error: Error at D:/GitHub/angular/modules/@angular/upgrade/src/aot/upgrade_component.ts:12:30: Cannot find module '../facade/lang'.

There is a missing symlink to facade in upgrade/src. The developer guide advises that running ./scripts/windows/create-symlinks.sh should create the symlinks required. This reads packages.txt to get the list of folders that need the links. In the text file each folder is listed on its own line. The upgrade/src folder is the last entry in that file, however because the line does not end in a \n, the bash script fails to read it. While a newline could be added to the packages.txt file, its likely that someone could delete it in future, so the bash script should be updated to work either way.

Expected behavior

Build should proceed without this error.

Minimal reproduction of the problem with instructions

Clone the angular repo to Windows. If #12420 is not fixed yet add the line

benchpress/src

to the top of

./scripts/windows/packages.txt

Run the create-symlinks.sh script, observe there is no symlink to facade in @angular/upgrade/src/ . After following the other instructions in the developer guide run build.sh and see the error listed above.

What is the motivation / use case for changing the behavior?

Its broken and best to fix in a way that the issue isn't likely to be reintroduced.

Please tell us about your environment:

Windows 10, Bash scripts run on MINGW64 that came with my git installation.

Angular version: 2.0.X

Angular Master Branch forked today.

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

N/A

Language: [all | TypeScript X.X | ES6/7 | ES5]

N/A

Node (for AoT issues): node --version =

N/A