| [09:01] <manadart> stickupkid or achilleasa: More NetworkInfo mechanix: https://github.com/juju/juju/pull/12364 | |
| [09:02] <stickupkid> manadart, not sure how i feel about this sentence "Given that this intermediate type is no longer required, it is removed and the params type is returned directly. Increased brevity results." | |
| [09:03] <manadart> If you look, the type was used so as not to return the params type (dependency on apiserver from state) when the method resided in state. | |
| [09:03] <stickupkid> but given that we don't have a vertical boundary for this kind of thing, I have feeling that this is ok | |
| [09:04] <manadart> Now that the method is in a sub-package of apiserver and we're handling the params return in the same module, the translation of one type to another is superfluous. | |
| [09:04] <stickupkid> sure sure | |
| [09:05] <stickupkid> apiserver is a glorified controller, but a shit version | |
| [09:06] <manadart> stickupkid: Once the nips and tucks are done. I will indirect it all, move the current tests to xxx_integration_test.go and start with unit tests based on mocks. | |
| [09:06] <manadart> That package is very slow to test, because we spin up the scenarios with the DB for them all. Even when testing trivial units. | |
| [09:07] <stickupkid> I still think that the api server should use the command pattern | |
| [09:07] <manadart> Yes. | |
| [09:08] <stickupkid> Then the apiserver just invokes the commands... that would actually be nice | |
| [09:08] <stickupkid> you could even hide the state behind a repository - o the joys | |
| [11:26] <achilleasa> stickupkid: finished reviewing 12363 | |
| [11:28] <stickupkid> ta | |
| [12:47] <stickupkid> achilleasa, updated | |
| [13:00] <oscarf_> is anyone familiar with a weird issue where a model which is supposed to be shared with users X, Y and Z, but still users X, Y and Z cannot see the model even when logging in and out of a controller? | |
| [13:12] <manadart> achilleasa, stickupkid: One patch forward-merge - https://github.com/juju/juju/pull/12368 | |
| [16:36] <manadart> achilleasa, stickupkid: https://github.com/juju/juju/pull/12371 | |
| [16:36] <stickupkid> manadart, for you in the morning https://github.com/juju/juju/pull/12369 | |
| [16:36] <manadart> stickupkid: Yep. | |