| [08:03] <Chipaca> good morning peeps! | |
| [08:05] <jam> morning Chipaca | |
| [10:56] <facubatista> Muy buenos días a todos! | |
| [11:20] <Chipaca> facubatista: I just lied to stub! | |
| [11:20] <Chipaca> facubatista: src is *not* in our dispatch's pythonpatgh | |
| [11:20] <Chipaca> facubatista: i thought we'd agreed to that :-| | |
| [11:20] <jam> Chipaca, i think we should if we don't right now | |
| [11:20] <facubatista> mmm | |
| [11:21] <jam> unless python always includes siblings. | |
| [11:21] <facubatista> we talked about mod, and then we said that all charms were symlinking from lib to that anyway | |
| [11:21] <facubatista> about 'mod' dir, I mean | |
| [11:22] <facubatista> don't remember about 'src' | |
| [11:22] <jam> I wouldn't include mod, because you generally want a subdir of that anyway | |
| [11:23] <mup> Issue operator#339 opened: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339> | |
| [11:24] <jam> Chipaca, you already set my pr as non draft? Or it just accepted our earlier attempts | |
| [11:24] <Chipaca> jam: i did it | |
| [11:32] <mup> Issue operator#339 closed: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339> | |
| [11:33] <mup> Issue operator#339 opened: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339> | |
| [11:41] <mup> Issue operator#339 closed: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339> | |
| [11:42] <mup> Issue operator#339 opened: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339> | |
| [11:43] <facubatista> Chipaca, jam, added 'src' to PYTHONPATH - https://github.com/canonical/charmcraft/pull/63 | |
| [11:43] <mup> PR charmcraft#63: Added 'src' to PYTHONPATH <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/63> | |
| [11:44] <jam> facubatista, Chipaca : isn't it automatically part of PYTHONPATH if you exec src/charm.py ? | |
| [11:46] <facubatista> ah, wait, we don't want 'src' hardcoded | |
| [11:46] <facubatista> that PR is wrong | |
| [11:48] <Chipaca> jam: not part of pythonpath, but effectively the same thing | |
| [11:48] <Chipaca> but i thought it wouldn't work when going via the symlinks | |
| [11:48] <Chipaca> maybe i was wrong? | |
| [11:49] <Chipaca> trying to get it to break here :) | |
| [11:49] <Chipaca> so, there's something the site thing is doing | |
| [11:49] <Chipaca> if you run it in isolated mode, it fails | |
| [11:50] <facubatista> Chipaca, what do you mean? | |
| [11:50] <Chipaca> facubatista: I mean: if you have src/charm.py importing potato, and you have src/potato.py | |
| [11:50] <Chipaca> facubatista: and you do 'python3 src/charm.py' | |
| [11:50] <facubatista> it works | |
| [11:50] <Chipaca> it will find potato, at least on ubuntu focal | |
| [11:50] <Chipaca> but now try with python3 -I src/charm.py | |
| [11:50] <Chipaca> and it no longer finds potato.py | |
| [11:51] <Chipaca> so the site configuration is doing something | |
| [11:51] <Chipaca> i'd have to dig to figure it out | |
| [11:51] <Chipaca> this means we probably want src/ on the pythonpath so it works in pythons weirder than just plain ubuntu | |
| [11:51] <stub> https://bugs.launchpad.net/juju/+bug/1885555 | |
| [11:51] <Chipaca> but i need more data to be confident :) | |
| [11:54] <facubatista> Chipaca, -I: "In isolated mode sys.path contains neither the script’s directory..." | |
| [11:54] <facubatista> Chipaca, so, the -I is removing the script dir | |
| [11:54] <facubatista> not that something else is adding it | |
| [11:55] <facubatista> "All PYTHON* environment variables are ignored, too. " | |
| [11:55] <facubatista> Chipaca, so, if you run it isolated, it would not respect our path fixings either, so... | |
| [12:29] <Chipaca> facubatista: ah :-) thanks | |
| [12:29] <Chipaca> facubatista: yeah i knew it ignored pythonpath, i wasn't suggesting to run it with that | |
| [12:29] <Chipaca> facubatista: I just wanted -S, i guess | |
| [12:41] <Chipaca> facubatista: jam: https://discourse.juju.is/t/charmcraft-bi-weekly-dev-summary-2020w25-26/3289 | |
| [12:42] <Chipaca> facubatista: jam: can you give it a quick read in case i forgot anything, before sending it out to the non-editable things? | |
| [12:42] <facubatista> yes | |
| [12:44] <jam> Chipaca, I just remembered we need to confirm whether collect-metrics is going to cause problems. I'll start working on that tomorrow after all my meetings. | |
| [12:44] <facubatista> Chipaca, the "snap" part looks too detailed, I wonder if we should have a tl;dr part | |
| [12:44] <mup> PR operator#323 closed: 317 state get <Created by jameinel> <Merged by jameinel> <https://github.com/canonical/operator/pull/323> | |
| [12:44] <jam> (meetings today) | |
| [12:44] <Chipaca> jam: congrats on landing that | |
| [12:45] <jam> Chipaca, is it worth holding the summary for tomorrow and be able to just announce 0.7 ? | |
| [12:46] <Chipaca> jam: i'm happy to do a smaller we-got-0.7-up one on wednesday | |
| [12:46] <facubatista> can't we release 0.7 today? | |
| [12:47] <jam> It seems like we could | |
| [12:47] <Chipaca> should I do those changes to ops.lib.use before that? | |
| [12:50] <jam> Chipaca, autoimport ? | |
| [12:50] <jam> I'd happily review it for you | |
| [13:01] <jam> Chipaca, meeting? | |
| [13:02] <Chipaca> omw | |
| [13:41] <jam> Chipaca, I noted that it did include PyYAML but no .so extensions | |
| [13:42] <Chipaca> i think it including pyyaml is a bug :) but that's just me | |
| [13:42] <jam> Chipaca, I'd rather not, but that is a side effect if people prefer "include system packages = false" | |
| [13:43] <Chipaca> i wonder which yaml you get when you import it tho | |
| [13:47] <jam> all of them simultaneously | |
| [13:48] <Chipaca> jam: maybe then it'll be fastest! | |
| [14:06] <facubatista> Chipaca, jam, as a conclusion from the debugging some minutes ago... shall we fix dispatch execution bits or not? | |
| [14:21] <Chipaca> facubatista: i think we should, but not zomg-release-this | |
| [14:24] <facubatista> Chipaca, https://github.com/canonical/charmcraft/issues/64 | |
| [15:05] * facubatista -> lunch | |
| [16:16] <Chipaca> jam, facubatista, if you're still around jay responded | |
| [16:20] <Chipaca> jam, facubatista, never mind then :) | |
| [16:42] * facubatista is back | |
| [16:59] <Chipaca> and I'm EOD :-) | |
| [16:59] <Chipaca> facubatista: 👋 ttfn | |
| [16:59] <mup> PR operator#340 opened: make ops.lib.autoimport use optional <Created by chipaca> <https://github.com/canonical/operator/pull/340> | |
| [17:00] <facubatista> Chipaca, bye | |
| [21:16] * facubatista eods | |