2020/02/07/#snappy.txt

[06:32] <mborzecki> morning
[06:38] <mborzecki> driving kids to school, back in 30
[07:06] <mborzecki> re
[07:26] <mborzecki> git pull
[07:26] <mborzecki> pff wrong window
[07:32] <mup> PR snapd#7863 closed: interfaces: add uio interface <Squash-merge> <Created by zyga> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7863>
[08:04] <pstolowski> morning
[08:04] <mborzecki> pstolowski: hey
[08:18] <mup> PR snapd#8107 opened: tests/lib/prepare: use a local copy of uc20 initramfs skeleton <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8107>
[08:41] <mup> PR snapd#8075 closed: boot: don't use "kernel" from the modeenv anymore <Simple 😃> <UC20> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8075>
[08:42] <mborzecki> pedronis: hey, thanks for merging 8075, there's some conflicts in #8076 now but i'll push an update there
[08:42] <mup> PR #8076: boot: add TryBase and BaseStatus to modeenv; use in snap-bootstrap <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8076>
[08:43] <pedronis> mborzecki: thank you
[08:43] <pedronis> mborzecki: and hi, reminder about reviewing #7588
[08:43] <mup> PR #7588: cmd/snap: add a "snap routine portal-info" command <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/7588>
[08:44] <mborzecki> pedronis: yeah, got it in my queue, wanted to push out the uc20 kernel thing first
[08:45] <pedronis> mborzecki: makes sense, but we are over the of hump of getting snap-bootstrap injected/things booting
[08:45] <mborzecki> pedronis: yeah, finally
[08:48] <uajain> No snap packaging for Dropbox?
[08:49] <mborzecki> 8076 needs a 2nd review
[08:52] <pedronis> mborzecki: I'll look at it in a bit
[09:10] <pedronis> pstolowski: hi, did a pass on #8102
[09:10] <pedronis> thank you for it
[09:10] <mup> PR #8102: o/ifacestate: move ResolveDisconnect to ifacestate <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8102>
[09:10] <pstolowski> pedronis: hey, thanks!
[09:19] <mborzecki> mvo took a sick day?
[09:20] <pstolowski> mborzecki: not sure about the reason, but he said he would be off today
[09:23] <mborzecki> wonder if https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1861648 is snapd running xdelta maybe
[09:23] <mup> Bug #1861648: When booting 20.04 an 'ld-2.23.so' process consumes 100% CPU for minutes <champagne> <focal> <performance> <snapd (Ubuntu):New> <https://launchpad.net/bugs/1861648>
[09:28] <zyga> o/
[09:28] <Saviq> hey all, do you guys know if there's API to trigger builds on build.snapcraft.io?
[09:28] <Lukewh> Saviq you'd need to use the launchpad API directly I think
[09:29] <mup> PR snapd#8093 closed: cmd/snap-confine: detect base transitions on core16 <Bug> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8093>
[09:29] <Saviq> Lukewh: right, so I'd need a recipe on LP, that we do know
[09:29] <Lukewh> to answer your question directly though - build.snapcraft.io doesn't have an api :)
[09:29] <Lukewh> probably should have started with that
[09:35] <zyga> pedronis: good morning! did mvo decide to do another 2.43.x?
[09:36] <pedronis> zyga: yes, but he is off today, there's a couple of things marked from 2.43 that are not backported yet, that we should discuss with him whether to backport or not
[09:36] <zyga> aha, I see
[09:36] <zyga> thanks, I'll add a launchpad milestone then
[09:38] <pedronis> mborzecki: pstolowski: I think it was planned either way for him to be off, he is using a swap day from CPT
[09:38] <pedronis> same as me on Monday
[09:38] <zyga> pedronis: thank you for backporting uio dependencies and working on the feedback, I read the comments now
[09:38] <pstolowski> ack
[09:39] <pstolowski> hey zyga !
[09:39] <zyga> I didn't notice the uio hotplug leftover, thanks for chasing that
[09:39] <zyga> hey pawel :)
[09:39] <mborzecki> zyga: hey! feeling better?
[09:39] <zyga> mborzecki: yeah, no more fever, just some cough left
[09:39] <zyga> mborzecki: kind of wished I was sick next week but what can you do
[09:41] <zyga> looking at the list of open PRs I have this feeling: https://imgflip.com/i/3ogq6y
[11:09] <mborzecki> hmmm, taken from environment.d manpage: `If multiple files specify the same option, the entry in the file with the lexicographically latest name will take precedence` and we have `990-snapd.conf`
[11:15] <pstolowski> pedronis: found the bug in rawsockstopper, details coming shortly
[11:15] <pedronis> pstolowski: thx
[11:24]  * pedronis lunch
[11:30]  * zyga did first real c20 review in a while https://github.com/snapcore/snapd/pull/8103#pullrequestreview-355082288
[11:30] <mup> PR #8103: snap-bootstrap: store encrypted partition recovery key <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8103>
[11:34] <pstolowski> pedronis: commented on 8101
[11:36] <zyga> pedronis, pstolowski: I did a pass over https://github.com/snapcore/snapd/pull/8102#issuecomment-583352987
[11:36] <mup> PR #8102: o/ifacestate: move ResolveDisconnect to ifacestate <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8102>
[11:36] <pstolowski> zyga: yep, just saw it, thank oyu
[11:36] <pstolowski> *you
[11:40] <pstolowski> zyga: interesting remark about KeepAlive
[11:40] <pstolowski> didn't know about it
[11:40] <zyga> pstolowski: https://github.com/snapcore/snapd/pull/8101#issuecomment-583354904
[11:40] <mup> PR #8101: netlink: fix/support stopping goroutines reading netlink raw sockets <Created by mvo5> <https://github.com/snapcore/snapd/pull/8101>
[11:40] <zyga> pstolowski: yeah, golang is full of that
[11:42] <pstolowski> zyga: afaiu setting non-blocking mode is not possible here until go-1.11 (see PR desc)
[11:43] <zyga> pstolowski: why?
[11:43] <zyga> pstolowski: I mean, we do syscall* everything
[11:43] <zyga> so we can just do it too
[11:43] <zyga> pstolowski: but regardless of what go provides, my comment stands, it's a system, not go, property
[11:44] <zyga> pstolowski: we can use non-blocking IO without wrapping it in existing structs
[11:47] <mborzecki> zyga: did land the code to parse the snap apparmor labels (or just security labels)?
[11:47] <pstolowski> zyga: i don't know the details of why non-blocking is problematic, pedronis / mvo investigated this
[11:48] <zyga> mborzecki: I don't recall us having such code
[11:49] <mborzecki> zyga: i recall us-2 discussing the need to have such code in the context of cgroupv2, but i don't remember whether anything was written actually
[11:49] <zyga> mborzecki: no, my code needs review
[11:49] <zyga> mborzecki: can you look, I can iterate once it lands :/
[11:50] <zyga> https://github.com/snapcore/snapd/pull/7825
[11:50] <mup> PR #7825: many: use transient scope for tracking apps and hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/7825>
[11:53] <jdstrand> zyga: fyi, that PR is high on the list. I hoped today, likely monday now
[11:53] <jdstrand> zyga: it is a big one for me
[11:53] <zyga> jdstrand: hey :)
[11:53] <zyga> jdstrand: thanks,
[11:53] <zyga> jdstrand: big note: that's still behind a feature flag
[11:53] <jdstrand> so I need a big chunk of time to devote to it
[11:53] <zyga> jdstrand: and I want to iterate on more {features,tests,stuff}
[11:54] <zyga> jdstrand: so please keep that in mind, I just want to make progress
[11:54] <zyga> jdstrand: understood (on time)
[11:55] <jdstrand> zyga: I understand. code and future work is one thing, but the design is novel (to me) and I want to make sure I give your code due respect :)
[11:55] <zyga> yep :)
[11:55] <jdstrand> but ack
[11:55] <zyga> I'm just saying there are TODOs there and I know :)
[11:55]  * jdstrand nods
[11:56] <jdstrand> I'm not concerned with that bit
[11:56] <jdstrand> this is milestoned for 2.44
[11:56] <jdstrand> I'm just letting you know I haven't forgotten about it
[11:56] <zyga> sure :)
[11:56] <zyga> jdstrand: given you are here, is my response to https://github.com/snapcore/snapd/pull/7614#issuecomment-580649998 sensible?
[11:56] <mup> PR #7614: cmd/snap-confine: implement snap-device-helper internally <Created by zyga> <https://github.com/snapcore/snapd/pull/7614>
[12:00] <jdstrand> zyga: yes
[12:00]  * jdstrand thumbs ups the comment
[12:04] <mborzecki> pedronis: some comments in #7588, but nothing large, i can push some fixes there
[12:04] <mup> PR #7588: cmd/snap: add a "snap routine portal-info" command <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/7588>
[12:13] <mborzecki> pedronis: wdyt about https://github.com/snapcore/snapd/pull/7588#discussion_r376358272 ?
[12:13] <mup> PR #7588: cmd/snap: add a "snap routine portal-info" command <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/7588>
[12:24] <pedronis> grumble, google:ubuntu-20.04-64:tests/main/interfaces-pulseaudio
[12:26] <mborzecki> heh, again?
[12:28] <pedronis> mborzecki: we have context things for snaps,  I still think SnapApp is what we want
[12:29] <mborzecki> ok
[12:29] <mborzecki> pstolowski: is pulseaudio trying to poke bluez again?
[12:29] <pedronis> mborzecki: I commented in the PR as well
[12:34] <pstolowski> mborzecki: i've no idea
[12:41] <pedronis> pstolowski: thanks for finding that issue out, I will try to do a pass also taking zyga comment into account later today
[12:41] <pstolowski> pedronis: yw, and thanks for investigating it further
[12:57]  * zyga reads about x509
[13:00] <mborzecki> zyga: have headache pills ready
[13:00] <zyga> mborzecki: hmm?
[13:00] <zyga> are you sending a long review :D ?
[13:00] <mborzecki> zyga: for x509
[13:00] <zyga> ah :)
[13:01] <pedronis> #8063 needs reviews, at this point both mvo and me have added code to it
[13:01] <mup> PR #8063: cmd/snap: implement 'snap remove-user' <Created by chipaca> <https://github.com/snapcore/snapd/pull/8063>
[13:02] <zyga> pedronis: just after 8100
[13:02] <zyga> wrapping up
[13:05]  * zyga is very happy with the "viewed" tick on gh
[13:07] <mborzecki> pedronis: do you have logs from the stuck pulseaudio interfaces test?
[13:08] <zyga> pedronis: doing remove-user review now
[13:11] <pedronis> mborzecki: this one failed, not stuck, but yes
[13:12] <pedronis> mborzecki: here, https://api.travis-ci.org/v3/job/647158169/log.txt
[13:12] <pedronis> is the other jamesh PR
=== ricab is now known as ricab|lunch
[13:12] <mborzecki> pedronis: thx
[13:20] <mborzecki> ok, let's see if the test order matters
[13:21] <mup> PR snapcraft#2914 closed: meta: ensure Application passthrough is scrubbed for snap.yaml <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2914>
[13:21] <mup> PR snapcraft#2915 closed: rust plugin: respect Cargo.lock if present in project <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2915>
[13:33] <ijohnson> hey all o/
[13:33] <zyga> good morning Ian
[13:34] <ijohnson> morning zyga
[13:34] <ijohnson> or afternoon :-)
[13:34] <ijohnson> are you feeling better today ?
[13:34] <zyga> indeed, it's half past two for me
[13:34] <zyga> yeah, I think I had the easiest ride out of our bunch
[13:34] <zyga> $wife took $baby to the doc to check up on her
[13:34] <zyga> now that she's better and safer to handle
[13:35] <zyga> $son is pretty happy to have skipped this week, now that it's just cough and no fever :)
[13:35] <zyga> fever sucks, makes you useless
[13:35] <zyga> just sleep all day
[13:35] <ijohnson> yeah fevers are pretty bad
[13:36] <ijohnson> glad to hear that you're doing better, I hope the rest of your family does likewise
[13:36] <zyga> yeah, it's passing now, I only worry it will jump to $olderdaughter just as winter holidays start
[13:38] <ijohnson> yeah getting sick over holidays isn't fun, I was sick the latter half of holidays this past christmas, no bueno
[13:39] <ijohnson> pedronis: is it okay to add the TODO:UC20: comment you requested in 8076 to 8077 instead? 8076 is green with 2 +1s now, so would be good to merge I think :-)
[13:40] <pedronis> ijohnson: yes, it's fine
[13:40] <ijohnson> pedronis: ack
[13:41] <mup> PR snapd#8076 closed: boot: add TryBase and BaseStatus to modeenv; use in snap-bootstrap <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8076>
[13:41] <zyga> brb, door
[13:48] <mborzecki> ijohnson: thanks for cleanups un #8097!
[13:48] <mup> PR #8097: tests/lib/prepare: fix hardcoded loopback device names for UC images <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8097>
[13:49] <mborzecki> uh meant #8094 :)
[13:49] <mup> PR #8094:  tests: repack the initramfs + kernel snap for UC20 spread tests <UC20> <Created by bboozzoo> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8094>
[13:49] <ijohnson> mborzecki: yes I'm happy we have working tests now, but I'm a bit worried that it's going to lead to more timeouts though
[13:49] <ijohnson> I think we should look at your firmware dropping changes ASAP
[13:49] <mborzecki> ijohnson: firmare is already dropped, we can enable dropping the kernel modules too though
[13:51] <ijohnson> mborzecki: oh right, well in addition to that we should probably also not even extract the firmware given how big it is, the tests are probably getting slowed down by decompressing all of that as well
[13:51] <mborzecki> ijohnson: oh and #8107 should interest you
[13:51] <mup> PR #8107: tests/lib/prepare: use a local copy of uc20 initramfs skeleton <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8107>
[13:51] <ijohnson> mborzecki: yes I was looking at that this morning
[13:52] <mborzecki> ijohnson: i think something's getting broken when the initrd is extracted by unmkinitramfs, there's a log about cpio stripping ../../ prefixes form hardlinks (?!)
[13:52] <ijohnson> mborzecki: have you asked xnox about that yet?
[13:53] <mborzecki> ijohnson: no, looks like he's busy with other stuff, and we have a workaround for now
[13:53] <ijohnson> mborzecki: ack, I might try to add a PR which doesn't extract the firmware at least to see if that helps
[13:54] <mborzecki> ijohnson: we need to extrac to get the modules (probably could hack a solution that uses the actual kernel snap modules), but i supose there may be something fishy in the way that unmkinitramfs does it
[13:55] <xnox> ouch
[13:55] <ijohnson> mborzecki: but we shouldn't need to extract the firmware at all should we ?
[13:55] <ijohnson> (from the kernel snap that is)
[13:56] <mborzecki> ijohnson: i think we could skip it, if we build the right directory structure with lib/modules/<kver> to satisfy dracut ;)
[14:00] <zyga> 2fa
[14:00] <pedronis> cachio: standup?
[14:13] <mup> PR snapcraft#2917 opened: rust plugin: fetch correct (locked) crates during pull <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2917>
[14:22] <zyga> cachio: I sent a small review for the udisks test
[14:22] <ijohnson> mborzecki: I sent you an invite to colloborate on the ubuntu-core-initramfs-snap github repo
[14:22] <ijohnson> so you can push to it directly
[14:23] <mborzecki> ijohnson: cool, thanks!
[14:23] <ijohnson> (and I merged your PR you opened as well)
[14:28] <cachio> zyga, tx
[14:38] <zyga> pedronis: https://github.com/snapcore/snapd/pull/8063#pullrequestreview-355155796
[14:38] <mup> PR #8063: cmd/snap: implement 'snap remove-user' <Created by chipaca> <https://github.com/snapcore/snapd/pull/8063>
=== ricab|lunch is now known as ricab
[14:42] <zyga> cmatsuoka: thanks for the replies on cryptsetup PR, I only have one follow-up https://github.com/snapcore/snapd/pull/8103#discussion_r376425353
[14:42] <mup> PR #8103: snap-bootstrap: store encrypted partition recovery key <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8103>
[14:44] <cmatsuoka> zyga: thanks, I'm still verifying the cryptsetup kill thing, will check that after lunch and the parents meeting at the school
[14:44] <pedronis> zyga: some it is more for mvo, we are behind documenting our API
[14:47] <ijohnson> cachio: any idea what might be the cause of the failure on https://github.com/snapcore/snapd/pull/8106 ?
[14:47] <mup> PR #8106: tests: add "core" suite for UC specific tests <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8106>
[14:48] <cachio> ijohnson, let me see
[14:48] <ijohnson> cachio: it seems to be that the new "core" suite directory isn't getting copied over, but it only happens for uc18 and uc16 confusingly, uc20 is fine
[14:49] <zyga> ijohnson: that's so weird
[14:49] <zyga> ijohnson: maybe it's something unrelated, like an exclude mechanism?
[14:50] <ijohnson> yeah I looked at all our excludes and couldn't find anything
[14:50] <ijohnson> though note it only happens when we go to reboot, so I think it might be something with how we prepare the new image before we reflash that
[14:51] <cachio> ijohnson, first time I see that, let me check a bit more
[14:53]  * zyga has hot soup for lunch
=== ricab is now known as ricab|bbl
[15:00] <cachio> ijohnson, I am running the tests here
[15:00] <cachio> ijohnson, I see that hte core20 directory is still created in tests dir
[15:00] <ijohnson> hmmm interesting
[15:01] <ijohnson> are you running on google or via qemu ?
[15:01] <ijohnson> I wonder if it has something to do with the repack git thing we do to reduce delta when running on google
[15:02] <ijohnson> cachio: ^
[15:06] <zyga> pstolowski: https://github.com/snapcore/snapd/pull/8102#pullrequestreview-355216316
[15:06] <mup> PR #8102: o/ifacestate: move ResolveDisconnect to ifacestate <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8102>
[15:12]  * cachio lunch
[15:32] <ijohnson> cachio: the reason that it's not copied over is due to the `-C` option we pass to rsync in setup_reflash_magic
[15:33] <ijohnson> not sure what's the implications of removing that, nor why rsync following CVS (?!?!?) exclude patterns makes tests/core/ be ignored
[15:34] <ijohnson> silly CVS.... https://stackoverflow.com/questions/8746419/using-cvs-exclude-in-rsync-suddenly-ignores-core-folder
[15:36]  * zyga goes afk for a while
[15:36] <ijohnson> it doesn't happen for uc20 because we don't use rsync for uc20, we create a tar archive instead which is extracted after the img is reflashed
=== ricab|bbl is now known as ricab
[15:40] <pstolowski> zyga: thanks for the review
[15:52] <zyga> ah
[15:57] <cachio> ijohnson, ahh, not sure, did you tried removing it?
[16:00] <ijohnson> cachio: I added `--include core` and it worked on my local run, seeing what travis spread does now
[16:00] <ijohnson> afk little bit
[16:00] <cachio> ijohnson, nice, thanks!!
[16:10] <pstolowski> can we land https://github.com/snapcore/snapd/pull/8058 ?
[16:10] <mup> PR #8058: run-checks, travis: allow skipping spread jobs by adding a label <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8058>
[16:10] <pstolowski> zyga: ^ do you know?
[16:11] <zyga> I don't mind
[16:11] <zyga> but I think it should be acked by cachio
[16:12] <cachio> pstolowski, zyga checking
[16:14] <pedronis> ijohnson: #8077 seems to need a merge, there's conflicts now
[16:14] <mup> PR #8077: boot: enable base snap updates in bootstate20 <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8077>
[16:17] <cachio> pstolowski, zyga I see this is a bit dangerous, is there any way to just allow to some people to add this labels?
[16:18] <ijohnson> pedronis: yes resolving now just a few minutes
[16:18] <zyga> cachio: no, it's all or nothing
[16:19] <cachio> zyga, I would like to discuss it on monday during standup
[16:19] <zyga> that's reasonable, let's hold it until
[16:19] <cachio> just to make sure all agree with this
[16:19] <pstolowski> sure
[16:20] <cachio> nice, thanks
[16:20] <pstolowski> cachio: mark it blocked then
[16:22] <cachio> pstolowski, done
[16:22] <pstolowski> thx
[16:33] <ijohnson> pedronis: resolved now, I also made one more small tweak to `snap-bootstrap initramfs-mounts`, where we don't read the modeenv if the base is already mounted
[16:34] <ijohnson> pedronis: what do you think of that? it makes sense to me because it removes unnecessary read/write cycles when we don't need it
[16:34] <pedronis> ijohnson: makes sense, but when we get the valid kernel thing next will need to tweak again
[16:35] <ijohnson> pedronis: oh right I forgot about that
[16:35] <ijohnson> hmm oh well I already pushed the commit, so I will just undo that change when we get to the valid kernel thing
[16:35] <ijohnson> pedronis: thoughts on what to name the modeenv setting for the kernels ? I had current_kernels but was thinking maybe something like trusted_kernels is better ?
[16:55] <ijohnson> pstolowski: I approved #7705, not sure if that's ready to go in now then, but it's green now :-)
[16:55] <mup> PR #7705: o/devicestate: handle preseed in firstboot <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/7705>
[17:00] <pstolowski> ijohnson: yay, thank you!
[17:00] <ijohnson> pstolowski: you're very welcome
[17:00] <ijohnson> pstolowski: pedronis: which is the next preseeding/services PR I should look at?
[17:02] <pstolowski> ijohnson: #8046, give me a sec, i'll merge master
[17:02] <mup> PR #8046: many, tests: integrate all preseed bits and add spread tests <Complex> <Needs Samuele review> <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8046>
[17:02] <mup> PR snapd#7705 closed: o/devicestate: handle preseed in firstboot <Preseeding 🍞> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/7705>
[17:02] <ijohnson> ack, I probably won't get to it til my PM
[17:05] <pstolowski> updated
[17:05] <pstolowski> .. and eow. cu!
[17:10] <mup> PR snapd#7983 closed: tests: adding more tests to core20 test suite <Created by sergiocazzolato> <Closed by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7983>
[18:33] <cachio> ijohnson, a question in #8106
[18:33] <mup> PR #8106: tests: add "core" suite for UC specific tests <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8106>
[18:33] <cachio> the rest is ok for me
[18:34] <ijohnson> cachio: I didn't try "core/", I can try locally after my lunch
[18:35] <ijohnson> cachio: if it works I'll update the PR
[18:35] <cachio> ijohnson, nice, thanks
[19:52]  * cachio afk
[20:50] <mup> PR snapcraft#2917 closed: rust plugin: fetch correct (locked) crates during pull <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2917>
[20:53] <mup> PR snapcraft#2918 opened: elf: ensure _GNU_VERSION_R section is of type GNUVerNeedSection <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2918>
[21:20] <mup> PR snapcraft#2800 closed: introduce `--apt-mirror` build provider flag <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/2800>
[21:20] <mup> PR snapcraft#2819 closed: isort: automatic formatting/sorting of imports <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/2819>
[21:20] <zyga> cjp256: hey
[21:20] <zyga> cjp256: question about python stuff
[21:21] <zyga> cjp256: is isort doing something that black is not?
[21:21] <zyga> cjp256: should I stick to black or is there more beyond that?
[21:22] <roadmr> zyga: isort does something black does not do
[21:22] <cjp256> yeah, it organizes imports.  black really just controls the spacing between them, but doesn't sort by pep8 rules
[21:22] <roadmr> ... yes that :)
[21:22] <zyga> I see, thanks!
[21:23] <cjp256> the problem is historically is that isort does not currently fully support black formatting, so the two fight each other in some cases - they have a 5.0 release coming up which should work well together with black
[21:31] <techalchemy> cjp256, you can just fix that though
[21:31] <techalchemy> it's pretty simple
[21:33] <cjp256> techalchemy: there was one edge case affecting snapcraft they fixed but won't be in until 5.0: https://github.com/psf/black/issues/251
[21:33] <cjp256> but yeah, you can get it pretty close in config
[21:34] <techalchemy> cjp256, oh that's interesting actually
[21:35] <cjp256> i'm a big fan of automatic formatting, so I'm gonna reopen that PR once it lands..
[21:35] <techalchemy> I never bothered looking into it but it makes perfect sense because of how the introspection works
[21:35] <techalchemy> I just use # fmt: off
[21:36] <cjp256> ah
[21:36] <techalchemy> cjp256, https://github.com/sarugaku/vistir/blob/master/src/vistir/compat.py#L135 <- like this
[21:38]  * sergiusens is not a fan of fmt: off
[21:39] <sergiusens> so glad we got rid of that with our move to python "greater-than" 3.5
[21:39] <techalchemy> i rather use fmt: off for a line here and there than have 0 automated formatting :)
[21:39] <techalchemy> sometimes it is necessary
[21:44] <mup> PR snapcraft#2919 opened: sanity_checks: fix sanity check on Windows <Created by NickZ> <https://github.com/snapcore/snapcraft/pull/2919>
[22:08] <mup> PR snapcraft#2920 opened: meta: initialize Snap at once in from_dict() <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2920>
[22:14] <mup> PR snapcraft#2921 opened: storeapi: remove exposure of series <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2921>