| [08:02] <wgrant> cjwatson: Replied to your bugsummary triggers MP, finally. I think my revised version is cleaner, but interested to hear your thoughts. | |
| [08:02] <wgrant> https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/373765 | |
| [08:03] <wgrant> Would be a bit nicer were it not for the lack of anonymous composite types, and an apparent inability to do a FOR loop with a list of scalars despite the error message saying that it is possible. | |
| [10:17] <cjwatson> wgrant: Thanks, will look with interest once I've sorted out staging | |
| [10:37] <tomwardill> fixed a test! Broke 6 others. | |
| [10:38] <SpecialK|Canon> hurrah! | |
| [10:40] <ilasc> tomwardill: welcome to the club :) | |
| [10:45] <ilasc> SpecialK|Canon, tomwardill, pappacena, cjwatson: will be away for about 1 hour over lunch today (doctor app. I couldn't reschedule), I've let Tony know I won't make his meeting today | |
| [10:45] <tomwardill> oh, I forgot about the retro! | |
| [10:46] <ilasc> :) I will definitely make Standup | |
| [10:46] <SpecialK|Canon> We talked in London about if we still wanted to attend those or do our own | |
| [10:46] <SpecialK|Canon> I forget what we concluded and didn't take a note... | |
| [10:46] <ilasc> SpecialK|Canon I think we concluded to split them | |
| [10:48] <tomwardill> that's my memory too | |
| [10:50] <SpecialK|Canon> In which case I wouldn't be expecting you to attend "the store retro" today at all ;) | |
| [10:50] <tomwardill> excellent! | |
| [10:50] <SpecialK|Canon> I would be expecting me to schedule an LP retro though! | |
| [10:51] * tomwardill claims that's what I originally intended | |
| [10:51] <SpecialK|Canon> I'll do that after the Store one | |
| [10:51] <SpecialK|Canon> all part of the grand plan, honest... | |
| [10:52] <cjwatson> retro> ack | |
| [10:53] <SpecialK|Canon> you might say that's... | |
| [10:53] <SpecialK|Canon> retro...ack..tive | |
| [10:53] <tomwardill> you might | |
| [10:53] <SpecialK|Canon> sorrynotsorry | |
| [10:53] <tomwardill> but you wouldn't | |
| [10:53] <tomwardill> because it's a terrible pun and you would be ashamed | |
| [10:53] <SpecialK|Canon> you're half right | |
| [10:56] <cjwatson> don't make me start relaying all the terrible astronomy institute whiteboard jokes here | |
| [10:56] <cjwatson> how do you hire a horse? | |
| [10:56] <cjwatson> put it on four bricks | |
| [10:57] <SpecialK|Canon> you say terrible | |
| [10:57] <SpecialK|Canon> I'm totally here for this | |
| [11:00] <cjwatson> (the whiteboard is headed "putting the LOL in cosmlology since 2017" or some such) | |
| [11:01] <SpecialK|Canon> amazing | |
| [11:08] <SpecialK|Canon> it would be a kindness if y'all would respond appropriately to Tony's calendar invite if you're not attending ;) | |
| [11:08] * tomwardill does the thing | |
| [11:11] <cjwatson> done | |
| [11:23] <tomwardill> cjwatson: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/376132 is updated (I think) for the latest DB patch changes, if you have a moment to look over it again | |
| [11:23] <tomwardill> https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/377768 is my getopts rocketfuel patch from London if anyone has a mo to look at that too | |
| [11:28] <cjwatson> reviewed the second, will look at the first today | |
| [11:28] <tomwardill> ta | |
| [11:29] <cjwatson> tomwardill: did you forget to push the first? I don't see your changes | |
| [11:30] <tomwardill> errr,I might've done a silly with branches | |
| [11:30] <tomwardill> sec | |
| [11:32] <tomwardill> cjwatson: done, had forgotten I was on a different branch and pushed the original | |
| [11:51] <cjwatson> tomwardill: Could you look over https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378716 ? I think it should actually fix (qa)staging this time | |
| [11:53] <cjwatson> pappacena: Do you think you could look into removing auditor and friends from LP at some point, since we have the new approach in place now? | |
| [11:54] <cjwatson> Should get Django out of our virtualenv, I think ... | |
| [12:02] <pappacena> Sure... I just need to understand what auditor and friends are... | |
| [12:14] <cjwatson> That's the old unfinished microservice approach to the queue audit trail problem, which you've done with an extra DB table instead | |
| [12:14] <cjwatson> Was never finished enough to be enabled on production AFAIK | |
| [12:14] <pappacena> ahhh, now I remember. | |
| [12:14] <pappacena> Sure, I'll work on it as soon as I'm done with this signing thing integration, probably early next week | |
| [12:15] <cjwatson> Cool, no rush, thanks | |
| [12:16] <cjwatson> Hm, it did actually get deployed to staging, see https://portal.admin.canonical.com/C55785 | |
| [12:16] <cjwatson> So I guess we should clean stuff up there | |
| [12:17] <cjwatson> I can help if needed but it might be a good exercise in chasing things down with IS :) | |
| [12:18] <pappacena> Sure! It will be good to better know people/processes/machines involved in this part | |
| [12:35] <cjwatson> Anyone else able to look at https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/378716 ? I'd like to get this in ASAP since stuff is broken right now | |
| [12:35] <pappacena> On it | |
| [12:35] <cjwatson> Thanks | |
| [12:41] <pappacena> Approved | |
| [12:44] <tomwardill> sorry, was out getting a samwich | |
| [12:50] <cjwatson> pappacena: thanks | |
| [12:55] <pappacena> 👍 | |
| [14:47] <tomwardill> cjwatson: I can't find/create/write an early exit in the case of errors in the getopts line | |
| [15:40] <cjwatson> tomwardill: https://paste.ubuntu.com/p/xpM3DTv3zB/ | |
| [15:40] <tomwardill> ah, neat! | |
| [16:00] <tomwardill> taht's that branch fixed up, seems to still work | |
| [16:00] <tomwardill> going to land | |
| [16:00] <tomwardill> in fact, I'l lwait till Monday morning :) | |
| [20:22] <wgrant> cjwatson: ah, can you fix my todo type names too? I was hoping to make them anonymous, but failed | |
| [20:32] <cjwatson> wgrant: Do you think I just need to try harder to make them anonymous, or that I should find better names? | |
| [20:39] <cjwatson> I assumed you'd meant "todo" as in "rows to process" rather than as in "need to fix this name" | |
| [20:46] <wgrant> cjwatson: I don't think it's possible to make them anonymous, unfortunately. | |
| [20:47] <wgrant> Nah, they should probably have bugsummary_temp_* names or something like that | |
| [21:04] <cjwatson> OK, will fix, possibly on Monday | |