| === kirkland is now known as Guest45646 | |
| === CyberJacob|Away is now known as CyberJacob | |
| === CyberJacob is now known as CyberJacob|Away | |
| === ubot5` is now known as ubot5 | |
| [10:24] <gmb> allenap, rvba: I realise you’re hella busy today, but I’ve got three branches that need revewing. All of them are pretty simple despite their size, and they’re blocking me from landing the final fix for https://bugs.launchpad.net/maas/+bug/1330765 | |
| [10:24] <ubot5> Ubuntu bug 1330765 in MAAS "If start_nodes() fails, it doesn't clean up after itself." [Critical,In progress] | |
| [10:24] <gmb> (Because I foolishly marked the final branch as depending on the others, which it doesn’t, not really). | |
| [10:25] <allenap> gmb: I shall take a look now. | |
| [10:25] <gmb> allenap: Thanks. Actually there are only two that need review: | |
| [10:25] <gmb> https://code.launchpad.net/~gmb/maas/use-node.stop-instead-of-stop_nodes-bug-1330765 | |
| [10:25] <gmb> and | |
| [10:25] <gmb> https://code.launchpad.net/~gmb/maas/remove-stop_nodes-and-start_nodes-bug-1330765 | |
| [10:25] <gmb> The first is a refactor and the second is a removal. | |
| [10:25] <gmb> s/refactor/refactor of sorts/ | |
| [10:26] <rvba> allenap: gmb's changes seem related to what we just talked about. | |
| [10:28] <gmb> ? | |
| [10:29] <allenap> gmb: +1 to both of them. | |
| [10:29] <gmb> allenap: Molto buona! Grazie! | |
| [10:55] <gmb> allenap, rvba: A quickie to take you to lunch if you want it: https://code.launchpad.net/~gmb/maas/fix-network-error-bug-1383237/+merge/239026 | |
| [10:59] <allenap> gmb: +1. I will now have lunch. | |
| [10:59] <gmb> allenap: Ta. | |
| [11:38] <gmb> rvba, allenap: Another trivial one to review (I’m on a fix-irritating-bugs roll today, I think): https://code.launchpad.net/~gmb/maas/fix-dupe-ip-address-error-bug-1383231/+merge/239033 | |
| [11:38] <rvba> gmb: I'll take it. | |
| [11:38] <gmb> Thx | |
| [11:56] <gmb> And another one for *after* lunch: https://code.launchpad.net/~gmb/maas/fix-null-when-releasing-ip-bug-1383668/+merge/239034 | |
| [12:25] <rvba> gmb: allenap: CI is back online for trunk. | |
| [12:25] <gmb> rvba: Cool, thanks. | |
| [12:26] <rvba> Let's make sure it runs next time we land a branch. | |
| === alexpilotti_ is now known as alexpilotti | |
| === roadmr is now known as roadmr_afk | |
| === roadmr_afk is now known as roadmr | |
| === CyberJacob|Away is now known as CyberJacob | |
| === CyberJacob is now known as CyberJacob|Away | |
| === jfarschman is now known as MilesDenver | |
| === roadmr is now known as roadmr_afk | |
| === roadmr_afk is now known as roadmr | |
| === CyberJacob|Away is now known as CyberJacob | |
| === CyberJacob is now known as CyberJacob|Away | |
| === CyberJacob|Away is now known as CyberJacob | |
| === CyberJacob is now known as CyberJacob|Away | |
| === CyberJacob|Away is now known as CyberJacob | |
| === CyberJacob is now known as CyberJacob|Away | |
| === CyberJacob|Away is now known as CyberJacob | |
| === CyberJacob is now known as CyberJacob|Away | |