| [00:16] <mhall119> daker: sure | |
| [00:20] <daker> mhall119: we can have it tomorrow, sleeping... | |
| [00:27] <mhall119> daker: sure, PM me any time | |
| === _salem is now known as salem_ | |
| === chihchun is now known as chihchun_afk | |
| === chihchun_afk is now known as chihchun | |
| === salem_ is now known as _salem | |
| === chriadam is now known as chriadam|away | |
| [07:15] <dholbach> good morning | |
| [07:15] <justCarakas> good morning :) | |
| [07:56] <dpm> morning mardy, could you give us a hand with bug 1351041 to help unblock image promotion? I've added more information in the comments, and I've noticed we're not getting the token. I did as you mentioned in your comment, but /var/log/syslog didn't show anything related to accounts, and I wasn't sure how to run dbus-monitor | |
| [07:56] <ubot5> bug 1351041 in Ubuntu Reminders app "App is unable to retrieve notes" [Critical,Triaged] https://launchpad.net/bugs/1351041 | |
| [08:03] <mardy> dpm: I added a comment | |
| [08:03] <mardy> dpm: what I find more suspicious is this: file:///usr/share/click/preinstalled/com.ubuntu.reminders/0.5.203/qml/reminders.qml:143: TypeError: Cannot read property 'HostName' of undefined | |
| [08:04] <mardy> dpm: actually, that line happens if you get an access token | |
| [08:07] <dpm> mardy, generally when we get an access token, it's output on the app's log, that's what made me think we're not getting the token. Should we be using dbus-monitor to see if it gets it? | |
| [08:08] <mardy> dpm: I'm quite sure you get it: see http://bazaar.launchpad.net/~reminders-app-dev/reminders-app/trunk/view/head:/src/app/qml/reminders.qml#L143 | |
| [08:08] <mardy> dpm: this is the error line, in the logs | |
| [08:08] <dpm> yes, that's the line I'm looking on Qt Creator | |
| [08:09] <mardy> dpm: try to print accountService.authData | |
| [08:09] <mardy> dpm: you probably need to use JSON.stringify() | |
| [08:11] <dpm> mardy, ok, will take me a while, I'm upgrading now to image 158 to reproduce the issue | |
| [08:15] <dpm> mardy, something like this? -> http://pastebin.ubuntu.com/7968339/ | |
| [08:16] <mardy> dpm: change line 15 with console.log('params: ' + JSON.stringify(accountService.authData.parameters)) | |
| [08:17] <dpm> ok | |
| [08:23] <zsombi> dpm: thx for changing teh status of teh statesaver bug for trusty :) | |
| [08:23] <zsombi> s/teh/the | |
| [08:24] <dpm> zsombi, np ;) | |
| [08:24] <zsombi> dpm: no idea why it was grayed out for me... | |
| [08:24] <dpm> zsombi, I think you need to be a member of the bug squad to change some statuses of bugs in the distro | |
| [08:25] <dpm> if they have been milestoned | |
| [08:25] <zsombi> dpm: aha... ok :) | |
| [08:30] <dpm> mardy, ok, so it seems we're getting the token, but we're not able to read any params, that's the issue. See lines 31 and 32 | |
| [08:33] <mardy> dpm: you probably forgot to link to the pastebin :-) | |
| [08:34] <dpm> mardy, argh, it was the excitement about finding a hint for the cause of the bug :-) There you are: http://pastebin.ubuntu.com/7968430/ | |
| [08:35] <popey> dholbach: fyi, for core apps, we're treating them like any other app, so can be processed in the store like 3rd party apps. | |
| [08:35] <dholbach> popey, gotcha | |
| [08:35] <mardy> dpm: weird. If the app can authenticate, it should also be able to read that setting | |
| [08:36] <mardy> dpm: can you please paste the .provider and .service files (not from the source tree, but from the installed locations) | |
| [08:36] <dpm> ok | |
| [08:36] <mardy> dpm: also check if you have something in /usr/share/accounts vs. ~/.local/share/accounts | |
| [08:39] <dpm> mardy, here are the contents of the two locations -> http://pastebin.ubuntu.com/7968500/ | |
| [08:42] <mardy> dpm: OK. and what are the contents of the evernote files there? | |
| [08:42] <dpm> mardy, and here are the contents of the .provider and .service files: http://pastebin.ubuntu.com/7968518/ | |
| [08:42] <mardy> dpm: all looks fine | |
| [08:43] <mardy> dpm: in the older image (where it works), are you using the same version of reminders app, or an older one? | |
| [08:43] <dpm> mardy, the same version of reminders: 203 | |
| [08:43] <mardy> weeeird | |
| [08:44] <mardy> dpm: and if you change accountService.authData to just authData, does it behave differently? | |
| [08:50] <dpm> mardy, unfortunately, same result, same log | |
| [08:51] <mardy> dpm: anything interesting in the syslog? | |
| [08:52] <dpm> mardy, I could not see anything related to accounts in the syslog, even after I set the logging to verbose for signond | |
| [08:52] <dpm> but I can try again | |
| [08:53] <mardy> dpm: no, no need | |
| === hatchetation_ is now known as hatchetation | |
| [08:54] <mardy> dpm: I see that the authData can return an empty variant map if the underlying libaccounts's AccountService is NULL | |
| [08:54] <mardy> dpm: and that's the only case | |
| [08:54] <mardy> dpm: that could happen if you change the accountService object (for instance by changing its objectHandle property) | |
| [08:55] <mardy> dpm: or if the object referred to by the objectHandle property dies | |
| [08:57] <dpm> mardy, I don't think we do the first, but not sure if the later happens. In any case, if I understand it correctly this is something we have no control over in the app, do we? | |
| [08:57] <mardy> dpm: can you please add some debug message on the onObjectHandleChanged inside AccountService? | |
| [08:58] <mardy> dpm: you have only one evernote account, right? | |
| [09:00] <dpm> mardy, yes, I only have one account. Here's what I'm going to try now, I've added the debug message on object handle changed: http://pastebin.ubuntu.com/7968611/ | |
| [09:00] <mardy> dpm: nope, you need {} around that code | |
| [09:02] <dpm> argh, typed too fast | |
| [09:05] <dpm> mardy, no luck, it seems that that callback is not triggered: http://pastebin.ubuntu.com/7968658/ | |
| [09:07] <mardy> dpm: I'm running out of ideas | |
| [09:07] <dpm> mardy, can we add a bug task for the relevant project and leave it in your hands? I'm not sure what else we can do in the app itself. | |
| [09:17] <mardy> dpm: yes, but how urgent is it? I've my hands full, and I have to prioritize another work, before bugfixing | |
| [09:20] <dpm> mardy, right now this is blocking promotion and we're entering TRAINCON-0 from what I see on #ubuntu-ci-eng. I guess the priority depends on your other tasks and what the QA folks say | |
| [09:21] <dpm> mardy, in any case, regardless of the priority, what would be the best project to add the bug task for? | |
| [09:24] <mardy> dpm: accounts-qml-module | |
| [09:25] <mardy> dpm: one more thing: can you please move the printing of authData inside the onObjectHandleChanged handler? | |
| [09:26] <dpm> mardy, sure, but will that make a difference? It seems that the handler is not called | |
| [09:26] <mardy> dpm: it is called once | |
| [09:26] <mardy> dpm: or you wouldn't authenticate :-) | |
| [09:27] <dpm> oh, then I missed it in the outpug | |
| [09:27] <dpm> *output | |
| [09:27] <mardy> dpm: line 18 of http://pastebin.ubuntu.com/7968658/ | |
| [09:27] <dpm> ok, cool, yes, let me do that | |
| [09:31] <popey> Mirv: when you get a moment, could you please re-upload latest sudoku from jenkins to the store, current upload is borked. thanks! /cc dholbach | |
| [09:31] <dpm> mardy, progress :) -> http://pastebin.ubuntu.com/7968816/ | |
| [09:36] <Mirv> popey: uploaded. weirdly, different behavior from before (too "quick"), so check also this one | |
| [09:36] <Mirv> or maybe something on the server side has just been made faster | |
| [09:36] <mardy> dpm: well, then at least we have a workaround: you can do "EvernoteConnection.hostname = accountService.authData.parameters["HostName"];" right before calling authenticate() | |
| [09:37] <popey> thanks Mirv | |
| [09:39] <dpm> mardy, awesome, thanks! | |
| [09:40] <mardy> dpm: let's keep the bug open anyways, I'll have a look at it when I can | |
| [09:48] <dpm> ok, thank you mardy, I've updated the bug description with the discussion this morning | |
| [09:48] <dpm> hi rpadovani, popey, could you review/test https://code.launchpad.net/~dpm/reminders-app/workaround-for-1351041/+merge/229753 ? | |
| [09:49] * popey looks | |
| [09:49] * rpadovani is on i | |
| [09:49] <rpadovani> *it | |
| [09:49] <popey> dpm: got a click? | |
| [09:50] <dpm> yes, let me upload it | |
| [09:51] <popey> thanks | |
| [09:54] <dpm> popey, http://people.canonical.com/~dpm/click/com.ubuntu.reminders_0.5.204_armhf.click | |
| [09:57] <popey> ta | |
| [09:58] <popey> dpm: yup, that works | |
| [09:59] <davmor2> dpm: \o/ we might have notes again \o/ | |
| [10:00] <dpm> excellent :) | |
| [10:04] <rpadovani> dpm, just to confirm, works also for me :-) | |
| [10:05] <popey> ship it! | |
| [10:05] <dpm> rpadovani, popey, in this case, could you guys approve/top-approve? | |
| [10:05] <popey> i have approved | |
| [10:05] <popey> rpadovani: can you top-approve pls? | |
| [10:05] <dpm> and popey, start the process to publish the click package from Jenkins? | |
| [10:06] <popey> yup, doing as soon as it merges | |
| [10:06] <rpadovani> done | |
| [10:06] * dpm high-fives rpadovani and popey | |
| [10:06] <popey> \o/ | |
| [10:06] <rpadovani> :-) | |
| [10:14] <mihir> popey: ping | |
| [10:14] <popey> yo | |
| [10:16] <mihir> popey: how can we upgrade Calendar to qt 5.3 , as per comment https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1351024 | |
| [10:16] <ubot5> Launchpad bug 1351024 in Ubuntu Calendar App "Date & Time picker is not working on device." [Critical,Triaged] | |
| [10:16] <popey> mihir: the device _is_ on 5.3 | |
| [10:17] <popey> meaning we ship with qt5.3 on the image, and it's in the utopic archive. | |
| [10:17] <mihir> popey: okay ,so what should we conclude from comments , should we use DatePicker instead of panel | |
| [10:17] <mihir> ? | |
| [10:20] <popey> mihir: you running utopic? | |
| [10:20] <mihir> not now , but yes i do have on VM. | |
| [10:20] <popey> so on utopic do you see the date picker? | |
| [10:21] <mihir> i need to check that. | |
| [10:22] <mihir> so if it does , then it should work on device that's what you meant to say ? | |
| [10:24] <popey> well, trying to figure out where the issue lies | |
| [10:24] <popey> t1mp: did you unassign yourself because you dont believe uitk to be at fault for date picker? | |
| [10:26] <davmor2> popey: he unassigned himself because he is already assigned to https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1349366 which is the bug he linked to which causes the issue I guess | |
| [10:26] <ubot5> Launchpad bug 1349366 in Ubuntu UI Toolkit "[PageStack] Pages does not get correct anchored in the PageStack area" [Critical,Confirmed] | |
| [10:27] <popey> ah, so he did | |
| [10:27] <popey> mihir: ^ ☻ | |
| [10:27] <mihir> popey: yeah , i did look at that now, will try tonight and then revert back | |
| [10:38] <t1mp> popey, davmor2 I unassigned myself because I convinced zsombi to take it (I won't be around for long today) | |
| [10:39] <t1mp> popey: zsombi has the bug now in the uitk project, but I cannot assign people in uitk (ubuntu) | |
| [10:39] <t1mp> zsombi: ^ https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1351024 | |
| [10:39] <ubot5> Launchpad bug 1351024 in Ubuntu Calendar App "Date & Time picker is not working on device." [Critical,Triaged] | |
| [10:39] <t1mp> davmor2: the other bug that I linked, I thought it might be related, but it seems not | |
| [10:39] <popey> t1mp: gotcha, thanks! | |
| [10:52] <zsombi> oSoMoN: kalikiana: please review https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/statesaver-path/+merge/229762 | |
| [10:54] <oSoMoN> zsombi, will do | |
| [10:54] <zsombi> oSoMoN: thx | |
| === MacSlow is now known as MacSlow|lunch | |
| [10:57] <kalikiana> zsombi: looking | |
| [10:58] <zsombi> kalikiana: thx 4 U 2 :) | |
| [11:05] <kalikiana> zsombi: should we unit test this? though it's kinda "obvious" if we had one place that checks all paths might be nice | |
| [11:08] <kalikiana> brb | |
| [11:18] * nik90 sighs.. its TRAINCO mode :/ the indicator-datetime silo for enabling alarm vibrations is blocked | |
| [11:22] <t1mp> bzoltan: https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1351024 | |
| [11:22] <ubot5> Launchpad bug 1351024 in Ubuntu Calendar App "Date & Time picker is not working on device." [Critical,Triaged] | |
| [11:30] <dholbach> hey nik90, could sergiusens help in any way? | |
| [11:31] <nik90> dholbach: I think he got busy yesterday to work on it. | |
| [11:31] <dholbach> ah ok | |
| [11:31] <nik90> dholbach: he said he would work on it 2h+ later, but I didnt see any reply from him | |
| [11:32] <dholbach> probably got too busy with cocktails with those small umbrellas by the pool :-P | |
| [11:33] <nik90> zsombi: hi, you are back. How was your vac? | |
| [11:34] <zsombi> kalikiana: well, maybe we could have unit test for that, but for all paths the toolkit uses, not for this particular one. OTOH there's a test which checks whether the state file is in teh proper place, that's why I have the test updated as well | |
| [11:34] <zsombi> nik90: yeah, I'm back, and I'm on 1338697 | |
| [11:35] <zsombi> nik90: bug #1338697 | |
| [11:35] <ubot5> bug 1338697 in Ubuntu UI Toolkit "Alarm sound url read from a saved alarm is always empty" [Critical,In progress] https://launchpad.net/bugs/1338697 | |
| [11:35] <zsombi> nik90: the vacation was awesome, relaxing, after the first 2 weeks I forgot where I've parked my car in teh airport :D | |
| [11:35] <nik90> zsombi: lol | |
| [11:35] <zsombi> nik90: it took me ~20 mins to find it :D | |
| [11:36] <zsombi> nik90: but back to the bug | |
| [11:36] <zsombi> nik90: it is QOrganizer who eats it... :/ | |
| [11:36] <nik90> zsombi: oh..would that require a patch upstream then? | |
| [11:36] <zsombi> nik90: damn it :( it doesn't get saved into the occurence... | |
| [11:37] <zsombi> nik90: perhaps... | |
| [11:39] <nik90> zsombi: oh also I added some crash logs to https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1337405 which causes the clock app to crash. It used to happen since the old clock app times. | |
| [11:39] <ubot5> Launchpad bug 1337405 in Ubuntu Clock App reboot "Clock App crashes frequently when UCAlarmModel::clear() is called" [Critical,Triaged] | |
| [11:39] <zsombi> nik90: I'll check that too | |
| [11:40] <nik90> zsombi: I realise you will be busy with the datetime picker crash for calendar app. So bug 1337405 can go later if you wish | |
| [11:40] <ubot5> bug 1337405 in Ubuntu Clock App reboot "Clock App crashes frequently when UCAlarmModel::clear() is called" [Critical,Triaged] https://launchpad.net/bugs/1337405 | |
| [11:41] <zsombi> nik90: ok, seems it was a false alarm... the URL gets converted from QTodoItem to RawData, but then in the alarms << alarm it get lost... | |
| [11:41] <zsombi> nik90: which is weird | |
| [11:41] <nik90> ok | |
| [11:41] <zsombi> nik90: well, the crash is as bad as the DatePicker | |
| [11:45] <zsombi> nik90: OH DEAR!!!! :s | |
| [11:46] * nik90 waits for zsombi to explain | |
| [11:46] <zsombi> nik90: in organizerEventFromAlarmData() teh sound is saved as QOrganizerItemAudibleReminder... | |
| [11:47] <zsombi> nik90: but in alarmDataFromOrganizerEvent() there's alarm.sound = QUrl(event.description()) :/ | |
| [11:47] <zsombi> nik90: so the fix is obvious :/ | |
| [11:48] <nik90> zsombi: so why :/ then? | |
| [11:48] <nik90> mismatched variable types | |
| [11:48] <zsombi> nik90: because this wouldn't had have to wait me to fix it :) | |
| [11:48] <nik90> :P | |
| [11:48] <zsombi> nik90: however the event.description is also set to sound's URL, so it should work! | |
| [11:50] <zsombi> nik90: so then we have a problem: why teh detail was missing from it? | |
| [11:50] <mardy> dpm: hi! I won't be able to attend the meeting about the evernote plugin | |
| [11:50] <zsombi> renato___: ping | |
| [11:51] <mardy> dpm: but as David wrote, it's possible to have the plugin shipped by the click package, just for trusted third parties | |
| [11:51] <dpm> mardy, that's fine, thanks for the heads up. We devised a plan after Pat's last e-mail. It seems we can ship everything (app+plugin) in one same click package, which would address all our problems. I had meant to cancel the meeting, so let me do that. | |
| [11:52] <mardy> dpm: cool | |
| [11:52] <qtros> Hi all | |
| [11:52] <qtros> popey ping | |
| [11:53] <popey> qtros: heya | |
| [11:54] <qtros> popey can you push new version of Shorts to store?) As far as I know you are doing it manually) | |
| [11:55] <popey> sure can | |
| [11:55] <renato___> zsombi, hi | |
| [11:56] <zsombi> renato___: I have a problem with the alarm sounds, seems the todos do not save the description, that's where the sound is saved too. | |
| [11:56] <renato___> zsombi, let me check, I think I have a unit test for that | |
| [11:57] <popey> Mirv: could you please also upload shorts? http://s-jenkins.ubuntu-ci:8080/job/rssreader-app-click/lastSuccessfulBuild/artifact/out/com.ubuntu.shorts_0.2.281_all.click | |
| [11:57] <zsombi> renato___: kewl@ | |
| [11:57] <qtros> popey maybe update version to 0.3 too, because after 0.2 we fixed a lot) | |
| [11:58] <popey> tricky, you'd need to do that in trunk, lets do that another time. | |
| [12:01] <zsombi> renato___: huhh???! QUrl(QString) gives me an empty invalid URL!!! | |
| [12:02] <renato___> zsombi, what do you mean? | |
| [12:02] <zsombi> renato___: I have an alarm.sound = QUrl(event.description()) conversion | |
| [12:02] <Mirv> popey: done | |
| [12:02] <zsombi> renato___: if I print out the event.description() that has the file:///..... URL | |
| [12:03] <popey> thanks Mirv | |
| [12:03] <zsombi> renato___: but the QUrl() ends up to be invalid | |
| [12:03] <popey> qtros: there you go, latest pushed and approved | |
| [12:03] <renato___> zsombi, humm, yes that is strange | |
| [12:06] <qtros> popey I'll test it soon) Thanks! | |
| [12:08] <zsombi> renato___: ok, it is not the conversion... when I'm storing the AlarmData in the QList<AlarmData> the QUrl sound content is getting lost | |
| [12:11] <renato___> zsombi, yeah I did some tests and I can store and restore the description value, and parse it using QUrl | |
| [12:11] <zsombi> renato___: because I do not copy that field in the copy constructor of AlarmData :D | |
| [12:12] <zsombi> renato___: me stupid!!! | |
| [12:12] <renato___> nice, that you found the problem | |
| [12:12] <zsombi> renato___: nik90: the fix for bug #1338697 seems a one-liner :D | |
| [12:12] <ubot5> bug 1338697 in Ubuntu UI Toolkit "Alarm sound url read from a saved alarm is always empty" [Critical,In progress] https://launchpad.net/bugs/1338697 | |
| [12:13] <zsombi> renato___: nik90: and we don't have any tests on that because we didn't knew how the sounds will get stored in the system, whether will it be indexed or simply stored as a URL | |
| [12:15] * zsombi lunch, brb | |
| [12:18] <renato___> Saviq, Kaleo , do you know if we have a fix for the ubuntushape already? | |
| [12:18] <Saviq> renato___, you have along tail today ;) | |
| [12:18] <Saviq> renato___, the batching fix landed, yes | |
| [12:19] <renato___> Saviq, the ubuntushape size fix? | |
| [12:19] <renato___> nice this was quick :D | |
| [12:19] <Saviq> renato___, size? | |
| [12:20] <renato___> Saviq, yes the address book is broken, the ubuntu shape is not respecting the size | |
| [12:20] <Saviq> renato___, not sure about that, no | |
| [12:20] <renato___> Saviq, http://imgur.com/EnFvIP8 | |
| [12:20] <Saviq> renato___, easy to check https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk | |
| [12:21] <renato___> I just want to know who is working for fix that | |
| [12:21] <renato___> I want to try the patch | |
| [12:21] <Saviq> renato___, is there a bug? | |
| [12:21] <Saviq> renato___, in any case, not me, or anyone in my team | |
| [12:21] <renato___> I think so kaleo and bzoltan was discussing that yesterday | |
| [12:23] <nik90> renato___: I can also confirm that that ubuntushape bug is also affecting other apps like music-app, my personal app etc. | |
| [12:23] <bzoltan> nik90: renato___: would you please elaborate what bug are you talking about? | |
| [12:24] <renato___> bzoltan, this one: http://imgur.com/EnFvIP8 | |
| [12:24] <renato___> that ken report yesterday | |
| [12:24] <nik90> bzoltan: it seems like the width and height assigned to UbuntuShape is not respected | |
| [12:25] <bzoltan> Kaleo: ^ | |
| [12:26] <nik90> renato___: are you also aware of https://imgur.com/lkEvmRm | |
| [12:26] <renato___> nik90, no this is new :D | |
| [12:27] <nik90> renato___: I reflashed my phone to make sure it is not some remanants from an older image or something. I will create a bug report for this | |
| [12:27] <renato___> nik90, this should be the same problem with ubuntu shape | |
| [12:28] <nik90> renato___: there are 2 issues in that screenshot. the first is the ubuntu shape. The second is the bottom edge tab is missing, or is that intentional? | |
| [12:28] <renato___> nik90, the bottom edge indicator should disappear as soon as you start to drag the page | |
| [12:29] <renato___> but it should be visible in the bottom | |
| [12:29] <nik90> renato___: ah ok. Yeah I noticed it missing only when dragging it up. | |
| [12:30] <brendand> renato___, talking about this issue? https://bugs.launchpad.net/address-book-app/+bug/1353420 | |
| [12:30] <ubot5> Launchpad bug 1353420 in messaging-app "Autopilot tests that use the bottom edge failing since #174" [Undecided,New] | |
| [12:30] <jgdx> elopio, here's the merged branch plus tests. Thanks. https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/call-fwd-wait-dual-sim/+merge/229774 | |
| [12:31] <nik90> zsombi, popey: Looks like indirectly we might have alarm snooze being implemented | |
| [12:32] <nik90> zsombi, popey: The indicator-datetime will provide a snooze button which on clicked will hide the alarm notification and show it against after x minutes. | |
| [12:32] * ogra_ looks for some QML advise about bindings ... i have some code like: http://paste.ubuntu.com/7970031/ ... how do i define the Binding to actualy en/disable the element if the securityPrivacy.securityType property changes (since securityPrivacy.securityType is an enum i guess i need to call a function or some such instead of dirctly binding property to property) | |
| [12:33] <popey> nik90: nice! | |
| [12:35] <renato___> brendand, yes this bug is because the ubuntu shape change the object type | |
| [12:35] <renato___> we need to update the autopilot test | |
| [12:36] <brendand> renato___, how did it get past CI testing? | |
| [12:36] <renato___> brendand, I do not know, maybe because both changes land together | |
| [12:37] <renato___> brendand, I do not know which change land first | |
| [12:37] <brendand> renato___, where did Ubuntu Shape change? which project? | |
| [12:37] <renato___> brendand, SDK | |
| [12:38] <brendand> renato___, can you identify the package it belonged to? the sdk team don't seem to think they had anything to do with it | |
| [12:38] <renato___> brendand, this is a SDK change that cause it to fail for sure | |
| [12:39] <brendand> renato___, these are the changes : http://people.canonical.com/~ogra/touch-image-stats/174.changes | |
| [12:39] <brendand> renato___, do you see a culprit in there? | |
| [12:41] <renato___> brendand, the package is: qtdeclarative5-ubuntu-ui-toolkit-plugin | |
| [12:41] <renato___> I do not know when this land | |
| [12:41] <brendand> renato___, 173 | |
| [12:42] <brendand> renato___, so i guess the problem is that the test/release cycle is not tight enough | |
| [12:42] <brendand> renato___, so maybe you did your test on #172 or earlier | |
| [12:44] <renato___> brendand, probably, something out of the sync, I remember that we approved the silo one day and it was released in another day | |
| [12:46] <renato___> brendand, but anyway boiko has branches to fix that already, he will be online soon | |
| === _salem is now known as salem_ | |
| [12:58] <nik90> ogra_: were you able to fix your binding issue? | |
| [12:58] <ogra_> nik90, heh, yeah | |
| [12:58] <ogra_> found a way easier solution (which turned the whole code into a one liner) | |
| [12:58] <nik90> ogra_: ok, I was just about to suggest a solution. But glad to know its fixed | |
| [12:59] <nik90> lol nice | |
| [12:59] <ogra_> https://code.launchpad.net/~ogra/ubuntu-system-settings/dev-mode-password-binding/+merge/229780 | |
| [13:00] <nik90> ogra_: hmm I not so sure if securityPrivacy.securityType changes it would actually also change the developer mode switch value | |
| [13:00] <ogra_> nik90, it does | |
| [13:01] <ogra_> works just fine ... tested it | |
| [13:01] <nik90> ah ok | |
| [13:01] <ogra_> secirityPrivacy properly emits its changed state so the "enabled" property just picks it up | |
| [13:02] <ogra_> no need for extra bindings or anything | |
| [13:02] <nik90> ogra_: I was more going for http://paste.ubuntu.com/7970232/, but your solution works as well | |
| [13:03] * nik90 brb..goes to get some lunch | |
| [13:03] <ogra_> ah, yeah | |
| [13:03] <bzoltan> nik90: do you have a bug report for that UbunuShape width-height problem? | |
| [13:04] <nik90> bzoltan: not that I am aware of. I will be back in 15 mins to write a sample app and report a bug. | |
| [13:04] <bzoltan> nik90: OK | |
| [13:14] <bzoltan> nik90: I filed this bug https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1353493 and Kaleo is working on it already. | |
| [13:14] <ubot5> Launchpad bug 1353493 in Ubuntu UI Toolkit "UbunuShape does not respect width/height" [Critical,Confirmed] | |
| [13:15] <bzoltan> renato___: Not sure if you have heard, but you should not use the UbuntuShape as an object type when selecting an object with autopilot. Just simple select the object name. | |
| [13:28] <brendand> renato___, btw did you know about the visual problem with the bottom edge? | |
| [13:28] <brendand> renato___, it might be a different issue to the one causing the AP failures | |
| [13:30] <nik90> bzoltan: ack | |
| [13:45] <bzoltan> nik90: and we have the fix for the size problem | |
| [13:46] <nik90> bzoltan: that was fast | |
| [13:47] <bzoltan> nik90: I will give you a PPA with the .deb to verify | |
| [13:47] <nik90> bzoltan: sure | |
| [13:48] <renato___> brendand, the visual is caused by the bug on UbuntuShape | |
| [13:49] <nik90> renato___: once I get the PPA from bzoltan I will update you on whether it fixes the address book and dialer app issue | |
| [13:49] <brendand> renato___, ok | |
| [13:50] <renato___> bzoltan, nik90 great | |
| [13:51] <bzoltan> nik90: it will be available in this PPA https://launchpad.net/~ubuntu-sdk-team/+archive/ubuntu/testing in 30 minutes | |
| [13:51] <bzoltan> renato___: nik90: that is only for the sizing problem | |
| [13:52] <nik90> bzoltan: ok, I think dialer, address have the issue due to the sizing problem,but we will see | |
| [13:52] <bzoltan> nik90: OK | |
| [13:53] <dholbach> DanChapman, popey: looks like some trojita tests are failing again: https://launchpadlibrarian.net/181654609/buildlog_ubuntu-utopic-amd64.trojita_0.4.1%2B2-0~201408060805.gita0e7ec1~ubuntu14.10.1_FAILEDTOBUILD.txt.gz | |
| [13:53] <renato___> brendand, boiko has the fix for the autopilot | |
| [13:54] <dholbach> link to build records: https://code.launchpad.net/~ubuntu-touch-coreapps-drivers/+recipe/trojita-daily | |
| [14:00] <dpm> rpadovani, are you up for the reminders meeting today? I think mzanetti is on holiday, so he probably won't join us | |
| [14:00] <rpadovani> dpm, if there is something to talking about, I'm in :-) | |
| [14:00] <dpm> rpadovani, sure | |
| [14:01] <rpadovani> ok then :-) | |
| [14:02] <nik90> rpadovani: after the meeting, would have have few minutes to review a MP? | |
| [14:04] <rpadovani> nik90, link it to me, I'll do this evening, no time now, sorry | |
| [14:04] <nik90> rpadovani: not a hurry, so that's fine | |
| [14:05] <nik90> rpadovani: https://code.launchpad.net/~nik90/ubuntu-clock-app/add-vibration-support/+merge/229327 | |
| [14:09] <rpadovani> nik90, saved, I'll take a look asap | |
| [14:24] <zsombi> nik90: kalikiana: alarm sound lost fix: https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/alarm-sound-fix/+merge/229800 | |
| [14:25] <zsombi> and now, DatePicker's turn | |
| [14:26] <nik90> zsombi: sweet! Onward to custom alarm sounds in the clock app :D | |
| [14:29] <dholbach> bzoltan, jdstrand, lool: do you know of any documentation we have about frameworks, ie what the definition means, differences between frameworks or how to target a framework different from what you're running? | |
| [14:30] <dholbach> just asking, so we can write this up at some stage, but any pointers to code, examples, notes or any kind of docs would be appreciated :) | |
| [14:30] <bzoltan> dholbach: I know as much as visible in the lp:click click/chroot.py and in the SDK frontent. The frameworks are just simple list of packages without versions to be installed on the click chroot. | |
| [14:31] <dholbach> bzoltan, for an app developer they will mean a bit more than that, right? what I can think of is: support time frame, which frameworks are used on which devices, which APIs are supported where, how do I stay on the LTS but still test/develop for a more recent framework, etc | |
| [14:32] <dholbach> bzoltan, that's at least what I could think of for now which might be interesting | |
| [14:32] <zsombi> nik90: ok, so the PickerPanel in the toolkit - on desktop at least - seems to work | |
| [14:32] <nik90> zsombi: it is a calendar app issue, but what I heard was that the PickerPanel doesn't only work on the device | |
| [14:33] <nik90> zsombi: In the clock app, I am using the Picker instead of the PickerPanel | |
| [14:33] <zsombi> nik90: so the device is wrong there... ok, we can check that as well | |
| [14:33] <zsombi> nik90: PickerPanel yet works only with teh DatePickers | |
| [14:34] <zsombi> nik90: ah, you meant DatePicker not the PickerPanel :) | |
| [14:34] <bzoltan> dholbach: I know little about the frameworks... so far I did not find an API to request the supported frameworks... | |
| [14:34] * dholbach nods | |
| [14:34] <nik90> zsombi: ok. I remember you telling that the PickerPanel is meant to be used to replace the OSK (it is placed there). However our clock designs wanted that as a component in the UI instead. | |
| [14:35] <lool> dholbach: https://wiki.ubuntu.com/Click/Frameworks has the most docs I believe | |
| [14:35] <lool> dholbach: we could extend to cover more | |
| [14:35] * nik90 again refers to DatePicker | |
| [14:35] <dholbach> thanks bzoltan, lool | |
| [14:35] <zsombi> nik90: np, that's why we have a separate component as well | |
| [14:35] <zsombi> nik90: I had a feeling that "always in OSK area" will mean yeah, sometimes emberred in teh app UI :D | |
| [14:36] <nik90> yup | |
| [14:37] <jdstrand> dholbach: https://wiki.ubuntu.com/Click/Frameworks is what I know of | |
| [14:37] <dholbach> thanks jdstrand | |
| [14:38] <zsombi> nik90: oh dear, you shoudl look after these logs: (qml/qqmlcomponent.cpp:1143, QQmlComponent_setQmlParent) - QQmlComponent: Created graphical object was not placed in the graphics scene | |
| [14:38] <zsombi> nik90: this happens when I open the "New Event" | |
| [14:39] <nik90> zsombi: I don't work on the calendar app ;) | |
| [14:39] <nik90> mihir: ^^ | |
| [14:39] <zsombi> nik90: I saw the code has some createQmlObject() calls, and seems these are having troubles | |
| [14:39] <zsombi> mihir: ^^ | |
| [14:40] <jdstrand> dholbach: also, 'click framework list' shows available frameworks | |
| [14:40] <dholbach> jdstrand, ah, great! | |
| [15:19] <nik90> popey: I updated https://code.launchpad.net/~nik90/ubuntu-clock-app/add-custom-sound-backend/+merge/225812 by merging trunk into it and then commiting it. But then on bzr push it says branches have diverged and that it won't push it. | |
| [15:19] <nik90> popey: is there any way to resolve that? | |
| [15:23] <popey> and if you bzr merge from trunk again does it show any differences? | |
| [15:23] <nik90> nope | |
| [15:23] <nik90> it says nothing to merge | |
| [15:24] <popey> hmm. | |
| [15:24] <nik90> I suppose I will have to copy this over to a new branch :/ | |
| [15:24] <popey> let me see | |
| [15:25] <popey> i see 1 conflict in app/alarm/EditAlarmPage.qml | |
| [15:25] <popey> i just did bzr branch lp:~nik90/ubuntu-clock-app/add-custom-sound-backend | |
| [15:25] <popey> cd add-custom-sound-backend/ | |
| [15:25] <nik90> I fixed that conflict and did bzr resolve. It resolved the conflicts and the I did bzr merge | |
| [15:25] <popey> bzr merge lp:ubuntu-clock-app/reboot | |
| [15:26] <popey> hmm, dunno. need a bzr expert. | |
| [15:26] * popey pokes dholbach | |
| [15:26] <nik90> it isn't a huge branch thankfully, so wouldn't mind just restarting a new branch | |
| [15:26] <dholbach> popey, what what? | |
| [15:26] <nik90> dholbach: I am getting bzr branches diverged error | |
| [15:27] <nik90> dholbach: which we are unable to solve | |
| [15:27] <dholbach> nik90, ubuntu-clock-app/reboot trying to merge which other branch? | |
| [15:27] <nik90> bzr branch lp:~nik90/ubuntu-clock-app/add-custom-sound-backend && cd add-custom-sound-backend/ | |
| [15:27] <nik90> bzr merge lp:ubuntu-clock-app/reboot | |
| [15:28] <nik90> dholbach: when you try merging you will get a conflict. You can fix the conflict by changing the conflicted code to http://paste.ubuntu.com/7971240/ | |
| [15:28] <dholbach> nik90, if you have two branches which make changes to the same file and the changes are not contained in both branches in the same way, you can have conflicts | |
| [15:28] <dholbach> nik90, edit the file, resolve the issue | |
| [15:28] <dholbach> then run "bzr resolve <filename>" | |
| [15:28] <nik90> after resolving and bzr merging it says branches diverged | |
| [15:28] <dholbach> hum | |
| [15:28] <nik90> i did bzr resolve | |
| [15:28] <dholbach> let me see | |
| [15:30] <kalikiana> elopio: can you have a look at this? it looks like j is trying to run a non-existing -autopilot package; it was intentionally removed https://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3082/console | |
| [15:31] <dholbach> nik90, I ran 'bzr commit' after resolving it and that worked | |
| [15:31] <dholbach> nik90, shall I push the change somewhere, so you can grab it? | |
| [15:31] <nik90> dholbach: did you then do bzr push? | |
| [15:31] <nik90> dholbach: for me bzr commit after resolving worked as well | |
| [15:31] <dholbach> nik90, where would you like to push it? | |
| [15:32] <nik90> dholbach: back to lp:~nik90/ubuntu-clock-app/add-custom-sound-backend | |
| [15:32] <dholbach> I can't push it there | |
| [15:32] <nik90> oh yeah | |
| [15:32] <dholbach> I'm not nik90 - don't have his good looks, etc :-P | |
| [15:32] <nik90> lol :P | |
| [15:32] <dholbach> lp:~dholbach/ubuntu-clock-app/add-custom-sound-backend | |
| [15:32] <nik90> that would do | |
| [15:32] <dholbach> rock on | |
| [15:32] <dholbach> popey, ^ | |
| [15:33] <popey> ♥ | |
| [15:33] <nik90> dholbach: so do I merge your branch into mine? | |
| [15:34] <nik90> ok that worked. I merged your branch into mine and then pushed it | |
| [15:35] <dholbach> brilliant | |
| [15:35] <nik90> thnx | |
| [15:46] <bzoltan> nik90: the 1.1.1179+14.10.20140804-0ubuntu2 uitk is ready for testing | |
| === gatox is now known as gatox_lunch | |
| [15:46] <nik90> bzoltan: testing now | |
| [15:55] <zsombi> nik90: popey: any idea when the DatePicker stopped working on the Calendar app? | |
| [15:56] <nik90> bzoltan: Yup that works! | |
| [15:56] <nik90> bzoltan: address book and dialer work as expected | |
| [15:58] <nik90> zsombi: according to balloons there wasn't any AP test to say when it starting failing | |
| [15:58] <nik90> balloons: any thoughts may be? ^^ | |
| [15:58] <zsombi> nik90: but manually, noone checked it recently, whether it works? | |
| [15:58] <zsombi> balloons: ^ | |
| [15:59] <popey> zsombi: no, not really, sorry. | |
| [15:59] <zsombi> popey: :( | |
| [15:59] <zsombi> popey: seems something more serious - and I suspect Qt5.3 | |
| [16:00] <zsombi> popey: I cannot open neither a popover nor a panel from the PickerPanel singleton object :/ | |
| [16:00] <balloons> zsombi, yes due to https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1328600, the tests using the datepicker had to be disabled in the interim | |
| [16:00] <ubot5> Launchpad bug 1328600 in Ubuntu UI Toolkit "Autopilot lacks support for large timestamps" [Critical,Confirmed] | |
| [16:00] <balloons> so sometime after June 10th | |
| [16:00] <popey> nice one balloons | |
| [16:00] <zsombi> popey: nik90: balloons: on desktop everything works fine, but not on teh device... | |
| [16:00] <popey> yeah | |
| [16:00] <balloons> nik90, I thought clock worked on the device? | |
| [16:01] <balloons> you confused me, I thought this was a calendar bug, not a toolkit issue | |
| [16:01] <nik90> balloons: clock uses Picker, not DatePicker | |
| [16:01] <zsombi> balloons: nik90: I cannot open any popover, not just the datepicker one | |
| [16:01] <balloons> my guess is it broke at somepoint in Mid July then | |
| [16:01] <balloons> when did qt 5.3 come? | |
| [16:01] <nik90> zsombi: wait you cant open any popovers? | |
| [16:01] <zsombi> balloons: way earlier... but DatePicker had been modified last time then | |
| [16:01] <zsombi> nik90: from PickerPanel, no | |
| [16:03] <balloons> zsombi the other thing is I worked on the ui toolkit tests in relation to that bug.. they still work | |
| [16:03] <balloons> how can we say it's a toolkit bug then, what's different? | |
| [16:04] <balloons> in other words, the pickers have test coverage, despite the app itself not having tests using the pickers | |
| [16:10] <nik90> renato___: the PPA bzoltan provided fixed the dialer and addressbook visual issues. | |
| [16:10] <renato___> nik90, nice | |
| [16:10] <bzoltan> nik90: Cool, I start the landing procedure | |
| [16:11] <nik90> renato___: btw the header section in the address book looks really nice ':D | |
| [16:13] <renato___> nik90, yes timp did a good job | |
| [16:14] <nik90> zsombi: btw I tested your alarm sound fix branch with my own branch. It works. Will comment on the MR | |
| [16:14] <zsombi> nik90: thx | |
| [16:18] <renato___> nik90, I will work on your fast scroll branch today | |
| [16:19] <nik90> renato___: thnx :-) | |
| [16:40] <nik90> popey, dpm: Any further info on the RTM branching that needs to be done for RTM? Frankly it shouldn't affect the clock app since the reboot is indeed for RTM specifically. | |
| === gatox_lunch is now known as gatox | |
| [16:44] <ahayzen> balloons, ping | |
| [16:45] <balloons> ahayzen, pong (pretend this occurs 15 mins from now) | |
| [16:46] <ahayzen> balloons, hah :) ... actually may not need u...just gonna left jenkins have another go as the new ms2 package has appeared here http://packages.ubuntu.com/utopic/mediascanner2.0 | |
| [16:46] <balloons> ahayzen, I can kick something off.. | |
| [16:46] <ahayzen> balloons, i'm just gonna top approve again... | |
| [16:47] <ahayzen> balloons, the mp u just commented on is/was failing because it needs the new ms2 package | |
| [16:47] <ahayzen> balloons, i had just assumed it had landed into the repo when i top approved earlier...but obviously not lol | |
| [16:47] <ahayzen> balloons, so i'm gonna try again.. | |
| [16:49] <ahayzen> t1mp, ping | |
| [17:04] <mhall119> bzoltan: zbenjamin: I'm getting the following click package validation error: ERROR: Could not find scope INI file 'ubuntucommunityscope/com.ubuntu.developer.mhall119.ubuntucommunity.ini' | |
| [17:04] <mhall119> I don't know where it's getting the .ini name from, because mine is called ubuntucommunityscope.ini | |
| [17:05] <mhall119> ${CMAKE_BINARY_DIR}/src/com.ubuntu.developer.mhall119.ubuntucommunity_ubuntucommunityscope.ini | |
| [17:05] <mhall119> it's like it left off the _ubuntucommunityscope part | |
| [17:06] <mhall119> and when I install the package in my emulator, it fails with: http://paste.ubuntu.com/7971969/ | |
| [17:07] <mhall119> I can confirm that the first .so path exists on the emulator | |
| [17:07] <mhall119> this may be unrelated to the .ini error | |
| [17:21] <jgdx> elopio, not sure you had the latest diff when you reviewed? | |
| [17:21] <jgdx> elopio, the test failures in https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/call-fwd-wait-dual-sim/+merge/229774 is also due to an unrelated issue we are trying to resolve | |
| [17:35] <elopio> jgdx: oh, I might have looked at the wrong one. I'm sorry. | |
| [17:36] <jgdx> could be I forgot to push actually | |
| [17:37] <elopio> jgdx: you still have things like | |
| [17:37] <elopio> 641 ->>>>>>> MERGE-SOURCE | |
| [17:39] <jgdx> elopio, I'm not sure why that is there. | |
| [17:43] <elopio> jgdx: oh, nevermind. I'm still looking at the old review. | |
| [17:43] <elopio> wow, I need some vacations. I'm slow today :) | |
| [17:44] <jgdx> :) | |
| [17:47] <elopio> jgdx: we have helpers for switches, so you won't have to check if they are checked before clicking them. | |
| [17:48] <elopio> http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/view/head:/tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_checkbox.py | |
| [17:49] <elopio> you use them like this: self.wait_select_single(ubuntuuitoolkit.Checkbox, | |
| [17:49] <elopio> objectName="callWaitingSwitch") | |
| [17:52] <elopio> also one for textfields: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/view/head:/tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_textfield.py | |
| [17:52] <elopio> jgdx: you could do | |
| [17:52] <elopio> text_field = self.wait_select_single(ubuntuuitoolkit.TextField, objectName='destNumberField') | |
| [17:52] <elopio> text_field.write('...') | |
| [17:52] <elopio> it will take care of focusing the field, of using the right input device and of checking that it was written. | |
| [17:57] <jgdx> elopio, thanks! | |
| [18:01] <elopio> jgdx: I think you are not asserting the calls to the mocks anywhere. | |
| [18:02] <elopio> I got to go for a while. I'll leave this and a couple of other comments on the branch. | |
| [18:02] <elopio> thanks again jgdx. Nice work with this. | |
| [18:03] <jgdx> elopio, thanks!:) | |
| [18:19] <renato___> nik90, I posted a comment on your fast scroll branch | |
| [18:19] <nik90> renato___: looking now | |
| [18:20] <nik90> renato___: can't believe I missed that :P | |
| [18:26] <renato___> nik90, this will avoid the fast scroll letters to apear behind the list items: http://paste.ubuntu.com/7972496/ | |
| [18:27] <nik90> renato___: ah you reordered it after the listview | |
| [18:27] <renato___> nik90, yes | |
| [18:28] <nik90> renato___: I noticed this https://imgur.com/xmAEkIi in the address book where the section header separator appears below the fastscroll instead of reducing its width. Is that part of the new design? | |
| [18:28] <nik90> renato___: I still need to sync your changes from the fit-n-finish branch for these components | |
| [18:28] <renato___> yes | |
| [18:29] <renato___> the designers ask for that, the fast scroll should not push the items to the left | |
| [18:29] <nik90> ok | |
| [18:29] <nik90> thnx a lot for your help. I am almost done with fastscroll and custom swipe delete then :-) | |
| [18:30] <renato___> welcome | |
| [19:59] <daker> mhall119: PM ? | |
| [20:01] <mhall119> daker: give me a few minutes, on a call | |
| [20:01] <daker> ok tyt | |
| [20:07] <nik90> Letozaf_: can I merge your branch now? | |
| [20:07] <Letozaf_> nik90, yes | |
| [20:07] <nik90> Letozaf_: awesome | |
| [20:07] <Letozaf_> nik90, :-) | |
| [20:07] <nik90> balloons: hey, we just got 3 AP tests for the new clock app :D | |
| [20:34] <josharenson> How do I inform qmltestrunner of the path to my custom module.. The app finds the module just fine, but all the tests fail because they can't find it. | |
| [21:12] <balloons> nik90, awesome ;-) | |
| [21:14] <nik90> balloons: I am going to break it soon enough :P..but I guess who ever breaks it fixes it :P | |
| [21:20] <balloons> that's right | |
| [21:20] <balloons> :p | |
| [21:33] <nik90> ahayzen: did you figure out the AP tests for the custom listitem actions? | |
| [21:34] <ahayzen> balloons, o/ the errors todo with https://code.launchpad.net/~vthompson/music-app/fix-swipe-delete-test/+merge/229718 are because of the toolbar not being shown | |
| [21:34] <ahayzen> balloons, now suffering the same isssues with https://code.launchpad.net/~andrew-hayzen/music-app/listitem-actions-take-2/+merge/229536 | |
| [21:34] <balloons> ahayzen, that was my first stop.. and right you are | |
| [21:34] <balloons> I know the bug.. d'oh! | |
| [21:34] <ahayzen> nik90, yep just got them 'working' except the toolbar isn't shown | |
| [21:34] <nik90> ahayzen: and also the upstream ListItemWithActions.qml file was updated upstream. The changes mainly involve around a new multiselection mode. | |
| [21:35] <balloons> https://bugs.launchpad.net/bugs/1353420 yes? | |
| [21:35] <ubot5> Launchpad bug 1353420 in messaging-app (Ubuntu) "Autopilot tests that use the bottom edge failing since #174" [Undecided,New] | |
| [21:35] <ahayzen> nik90, hah so i've gotta do my first 'pull'... i put // CUSTOM next to everything i changed :) so should be able to figure it out | |
| [21:35] <ahayzen> balloons, no... | |
| [21:35] <ahayzen> balloons, the toolbar should be shown when in wideaspect as default | |
| [21:35] <ahayzen> balloons, but for whtever reason the toolbar is hidden something somewhere has broken it | |
| [21:36] <nik90> ahayzen: Check https://code.launchpad.net/~renatofilho/address-book-app/release-2014-08-04/+merge/229528 for those changes. If they benefit you, then update. If not leave it | |
| [21:37] <ahayzen> balloons, basically to get the music-app working again we need to solve the ap tests and get... https://code.launchpad.net/~vthompson/music-app/lookup-file/+merge/229612 https://code.launchpad.net/~vthompson/music-app/prevent-incorrect-no-music-screen/+merge/228972 ... https://code.launchpad.net/~vthompson/music-app/fix-swipe-delete-test/+merge/229718 or https://code.launchpad.net/~andrew-hayzen/music-app/listit | |
| [21:37] <ahayzen> em-actions-take-2/+merge/229536 landed .. with one of the last two landing first as they block the others | |
| [21:37] <ahayzen> nik90, awesome thanks :) | |
| [21:37] <nik90> yw | |
| [21:37] <ahayzen> nik90, i assume this same component will eventually be part of the sdk? | |
| [21:38] <ahayzen> balloons, oh and.. https://code.launchpad.net/~vthompson/music-app/remove-white-error-labels-1353173/+merge/229713 | |
| [21:38] <nik90> ahayzen: well may be not as it since they might need to generalise it a bit more but more or less yes | |
| [21:38] <ahayzen> balloons, both mediascanner2 and uitk have broken us.... | |
| [21:38] <ahayzen> balloons, nik90 oh yeah the new UbuntuShape may have broken us as well .... u guys seen this before? https://bugs.launchpad.net/music-app/+bug/1353229 | |
| [21:38] <ubot5> Launchpad bug 1353229 in Ubuntu Music App "Music app's Now Playing queue has stretched and squished cover art" [Undecided,New] | |
| [21:39] <ahayzen> chaos! lol | |
| [21:39] <nik90> ahayzen: that's been fixed today | |
| [21:39] <nik90> ahayzen: let me grab the link for you | |
| [21:39] <ahayzen> nik90, oh sweet! | |
| [21:40] <nik90> ahayzen: https://code.launchpad.net/~fboucault/ubuntu-ui-toolkit/shape_reliable_geometry_changes/+merge/229790 | |
| [21:40] <ahayzen> nik90, awesome i'll mark it as a dup of that bug | |
| [21:41] <nik90> ahayzen: yeah. I tested the music app against that MP. It is fixed :D | |
| [21:41] <ahayzen> nik90, awesome thanks :) | |
| [21:43] <balloons> ahayzen, whoa.. that's alot.. How can I help? | |
| [21:44] <balloons> I must admit, I'm confused because of the many branches | |
| [21:44] <ahayzen> balloons, figure out the toolbar not being shown then should just be matter of approve approve approve done :) lol | |
| [21:44] <ahayzen> balloons, remember jenkins is wideAspect and device isn;t | |
| [21:49] <balloons> ahayzen, ok, so I can work on the failures I see in em-actions-take-2/+merge/229536 | |
| [21:49] <balloons> and you are not sure why, except that the toolbar doesn't appear | |
| [21:49] <balloons> yes? | |
| [21:49] <ahayzen> balloons, yeah that one of the swipe-delete one... i suspect my listitem-actions will require further review | |
| [21:49] <ahayzen> balloons, so probably best to figure out this one https://code.launchpad.net/~vthompson/music-app/fix-swipe-delete-test/+merge/229718 | |
| [21:50] <ahayzen> balloons, i'll just double check why that was failing again as there are so many mps lol | |
| [21:50] <ahayzen> balloons, yeah resolve ^^ mp | |
| [21:50] <ahayzen> balloons, u can see it clicking offscreen (as that is where the toolbar is) lol | |
| [21:54] <balloons> ahayzen, got it.. ok, let's see | |
| [21:54] <ahayzen> balloons, i'm gonna try and figure too...but i don't have an environ to test with | |
| [21:54] <ahayzen> balloons, ping me if u need any help with the logic i can tell u what it should be doing | |
| === salem_ is now known as _salem | |
| [21:58] <ahayzen> balloons, unless the Panel has changed with the new UITK | |
| [21:59] <ahayzen> balloons, place to start is to check if onWideAspectChanged {} is run in the musicToolbar ~L150 | |
| [21:59] <ahayzen> balloons, and ensure showToolbar() is called | |
| [22:06] <ahayzen> nik90, u still around? | |
| [22:06] <nik90> ahayzen: what's up? | |
| [22:07] <ahayzen> nik90, if u have something listening to the onChanged ... will the onChanged get called when it is first set .. i always forget if it does(n't) | |
| [22:08] <nik90> ahayzen: it does | |
| [22:08] <ahayzen> nik90, and with the listitemactions any idea if they plan to add reordering? | |
| [22:08] <ahayzen> nik90, ok so thats not the issue then ;) | |
| [22:08] <nik90> ahayzen: regarding the reordering no idea | |
| [22:09] <ahayzen> nik90, cool my reordering works...but it limited to the view u can see... ie u cannot scroll yet be dragging the item near the top/bottom | |
| [22:09] <nik90> ahayzen: ah | |
| [22:09] <ahayzen> nik90, but it does the job for now.... it has always been like this | |
| [22:10] <ahayzen> nik90, i did attempt scrolling at one point but then with our view with listitems of different sizes the calcs becomes super complex | |
| [22:10] <ahayzen> nik90, but then again we have taken out the different sizes in this merge...maybe i can reinvestigate in a second iteration | |
| [22:11] <nik90> ahayzen: yes I suppose | |
| [22:12] <nik90> ahayzen: did you try it in a sample app with constant listitem heights? | |
| [22:12] <ahayzen> nik90, not yet that was in my old version like start of this yr ... need to reimplement it | |
| [22:13] <ahayzen> nik90, do u know if the Panel has changed recently? | |
| [22:13] <nik90> ahayzen: afaik no | |
| [22:14] <ahayzen> ....something must have happened to make the toolbar just disappear (stay offview)... | |
| [22:14] <ahayzen> hmmm actually u can just see the progress bar...suggesting it is not in wideAspect? ... maybe the width of the jenkins window has changed? | |
| [22:15] <ahayzen> hmm but i think that would be shown even it is in wideaspect grrr | |
| [22:15] <ahayzen> balloons, u got any further? | |