| [11:51] <stub> wgrant: new rev of the db patch up, https://pastebin.canonical.com/114208/ contains the before/after schema diff from a dev db. | |
| [11:53] <stub> I need a new pastebin bookmark. Lost colorization somewhere. | |
| [11:54] <wgrant> stub: I don't speak 1970 | |
| [11:54] <wgrant> But let me see. | |
| [11:56] <stub> fab | |
| [12:21] <wgrant> stub: That looks pretty sensible, I think. | |
| [12:35] <stub> I'll approve and land it now then and we can start the ball rolling next week. Its all standard until we get to the last step. | |
| [12:37] <stub> Things to confirm on staging are if adding the new column with a FK reference needs to do an unnecessary scan, and similarly that final primary key. | |
| [12:38] <stub> wgrant: Or do you want to do a proper review first? | |
| [13:40] <wgrant> stub: I know those two things don't require full scans; I've done them each several times. So we're pretty safe except for the pg_attribute hackery, but that looks fine. | |
| [13:40] <wgrant> stub: I'll have another look at the patch on Monday before you awake, if you don't mind. Just to ensure it makes sense with a fresh mind. | |
| [13:41] <wgrant> cprov, cjwatson: Thanks for the reviews. | |
| [13:42] <cprov> wgrant: sorry for letting them slip until today | |
| [13:44] <wgrant> cprov: No worries. Could you please also look at https://code.launchpad.net/~wgrant/launchpad/htaccess-in-archiveroot/+merge/225783 and https://code.launchpad.net/~wgrant/launchpad/delete-archiveroot/+merge/225797 soonish? I expect to get moving on migrating production early next week, if possible. | |
| [13:44] <cprov> wgrant: will do | |
| [14:21] <cjohnston> wgrant: in Malta we discussed increasing the scan timeout by a minute or two to see if that would help with LP branches... did you have thoughts on the possibility of actually implementing that? | |
| === daker_ is now known as daker | |
| === Ursinha_ is now known as Ursinha | |
| === cjohnston_ is now known as cjohnston | |