|
=== arosales_ is now known as arosales |
|
[01:55] <hatch> Makyo still around? |
|
[01:55] <rick_h_> he ran away |
|
[01:55] <rick_h_> I would :P |
|
[01:55] <Makyo> hatch, yeah |
|
[01:55] <hatch> lhaha |
|
[01:55] <Makyo> Ohhhh no :S |
|
[01:55] <rick_h_> huwshimi: did I get your card right? You're working on the container token? |
|
[01:55] <hatch> Makyo I think that you borked up the commits |
|
[01:56] <Makyo> hatch, They look right to me on my other comp, gimme a sec |
|
[01:56] <Makyo> Oh, ffs. |
|
[01:56] <Makyo> I had a local conflict on my develop. Let me see what I can do. |
|
[01:56] <hatch> :) sorry |
|
[01:57] <huwshimi> rick_h_: Yep, that's right |
|
[01:57] <rick_h_> huwshimi: k cool |
|
[01:57] <huwshimi> rick_h_: We don't currently have that data available though right? |
|
[01:57] <Makyo> hatch, fixed |
|
[01:58] <hatch> Makyo cool thanks :) |
|
[01:58] <rick_h_> huwshimi: well you should have data for 'bare metal' if you deploy a service |
|
[01:58] <Makyo> hatch, did rebase develop, instead of rebase juju/develop |
|
[01:58] <rick_h_> huwshimi: but I don't think we've got a way to build data for the lxc/etc containers |
|
[01:59] <huwshimi> rick_h_: Ah ok, I'll have a poke around. |
|
[01:59] <hatch> ahhh, that's a good idea, I always pull down and update develop then rebase develop |
|
[01:59] <hatch> I'll have to remember that |
|
[01:59] <hatch> don't have to switch branches that way |
|
[02:01] <hatch> Makyo I'll review/qa tonight, looks good at first glance though |
|
[02:31] <hatch> hmm |
|
[03:04] <hazmat> so can gui display the name of the environment instead of the type of environment? |
|
[03:06] <hatch> hazmat rick_h_ is working on that card now |
|
[03:07] <hazmat> hatch, thanks |
|
[03:07] <hatch> no problemo |
|
[03:07] <hatch> Makyo sorry I found a QA issue |
|
[03:09] <hazmat> should be straightforward name comes back on env.Info() call |
|
[03:10] <hatch> hazmat I think the card he was working on was to add the ability to set the env name to whatever you want for demo |
|
[03:10] <hazmat> hatch, um.. |
|
[03:10] <hazmat> hatch, setting the env name to the actual env name would be good and preferrable |
|
[03:10] <hazmat> as in what the gui should be doing anyways |
|
[03:11] <hatch> I haven't been partial to all of the discussions...I think there were some issues with doing that right away |
|
[03:12] <hazmat> rick_h_, ^ can we talk about this tomorrow |
|
[03:12] <hatch> it's 11 there, might be best to email |
|
[03:13] <hatch> sorry, I've been pretty head down, so much going on atm hah |
|
[03:14] <Makyo> hatch, why does destroyed remain true when init is called agian? |
|
[03:14] <hazmat> hmm.. found a gui export bug.. always does series as precise. |
|
[03:14] <Makyo> Will just add my own attr, nevermind. |
|
[03:15] <hatch> Makyo I don't think a class instance can be 'un-destroyed' |
|
[03:15] <Makyo> That's what we're doing with the inspector. |
|
[03:15] <Makyo> I'll just add my own attr. |
|
[03:16] <hatch> well...shoudln't we be destroying and creating a new inspector entirely? |
|
[03:16] <hatch> just sharing the model? |
|
[03:17] <Makyo> hatch, Apparently not :P |
|
[03:17] <hatch> hmm ok we should look into that |
|
[03:18] <Makyo> It's too late here. Ping me tomorrow morning? I'm out of brain. |
|
[03:18] <hatch> yeah I'm the same :) |
|
[03:18] <hatch> yeah lets investigate in the am |
|
[03:18] <Makyo> +1 |
|
[03:19] <hatch> hazmat hmm yep that's definitely a bug, please do file a bug thanks :) |
|
[03:19] <hazmat> done |
|
[03:20] <hatch> thanks |
|
[11:29] <rick_h_> hazmat: rgr let me know. I was told they wanted special strings for demo vs something real so just hacking a branch |
|
[11:34] * frankban lunches |
|
[11:42] <rick_h_> frankban: when you get back ping me please |
|
[11:53] <rick_h_> afk taking boy to day care |
|
[12:13] <rick_h_> back |
|
[12:33] <frankban> rick_h_: I am back |
|
[12:34] <frankban> guihelp: I need two reviews + QA for https://github.com/juju/juju-gui/pull/228 (local charm icons). Thanks! |
|
[12:35] <rick_h_> frankban: the only other icon I think we HAVE to have for local charms in this case is in the inspector |
|
[12:35] <rick_h_> frankban: as they'll pull that up in demos, but probably not the details page and you won't see a charm icon for it right now |
|
[12:35] <frankban> rick_h_: the branch includes the inspector header icon |
|
[12:35] <rick_h_> frankban: oh, you rock. One step ahead of me thanks! |
|
[12:36] <rick_h_> frankban: will look, bac kadams54 please help with a second. This is very high priority |
|
[12:36] <kadams54> frankban, rick_h_ : sure, I'll take a look. |
|
[12:36] <frankban> rick_h_: thanks, where is the details icon? I don;t see that |
|
[12:36] <frankban> thank you both |
|
[12:37] <rick_h_> frankban: there's a second card for the charm details and the charm tokens for local charms |
|
[12:37] <rick_h_> frankban: but upon reflection don't think we need it for the demo |
|
[12:38] <frankban> rick_h_: what's the case when a local charm has a token? |
|
[12:38] <rick_h_> frankban: machine view and such. We'll have tokens with local charms that will need the icon |
|
[12:38] <frankban> rick_h_: OIC |
|
[12:38] <rick_h_> frankban: and the token and details shares a common method in the charmworld store |
|
[12:39] <rick_h_> frankban: so making it work in the charmworld store will make it work in all places anyway |
|
[12:39] <frankban> rick_h_: I am still not sure about icons in the charm details panel, I am not able to find an icon even for cs scharms |
|
[12:39] <rick_h_> frankban: this is from the juju environment? |
|
[12:40] * rick_h_ isn't following |
|
[12:40] <frankban> rick_h_: I mean, maybe I am looking at the wrong place, but if I open the charm details of a cs charm deployed on a real env, I don't see icons in the details panel |
|
[12:41] <rick_h_> frankban: oh, no you're right |
|
[12:41] <rick_h_> but that might change as well, though I'm not sure I guess. It shares the same details view as the normal charm browser details but it gets cut down. |
|
[12:41] <frankban> rick_h_: but I guess that's not so important for now, I am going to work on the follow up branch for fallback icons in the gui server, shoudl be able to propose later |
|
[12:41] <rick_h_> frankban: right now the header is turned off because of space/the way it flies out from the inspector |
|
[12:41] <rick_h_> frankban: yep, I'll move that other card down from urgent, thanks |
|
[12:50] <frankban> rick_h_: can we move down also the card about non-icon files? |
|
[12:50] <rick_h_> frankban: yes |
|
[12:52] <frankban> rick_h_: thank you. also this morning I QAed the final trusty quickstart package, Robie uploaded it and it should be ready soon |
|
[12:52] <rick_h_> frankban: awesome! |
|
[12:52] * rick_h_ will be glad to get trusty behind us |
|
[12:52] <frankban> yeah |
|
[12:53] <frankban> rick_h_: is 1.18 the final trusty core release? |
|
[12:53] <rick_h_> frankban: I'm not 100% sure. There's talk of a 1.20, but I don't think it's making it. |
|
[12:54] <rick_h_> frankban: but the changes shouldn't effect us. I'm trying hard to keep an eye on the code reviews and such of core. |
|
[12:54] <rick_h_> some interesting stuff in the pipes, new constraint types/etc. But nothing jumpout out as worrisome to us |
|
[12:55] <frankban> rick_h_: cool, ok |
|
[12:55] <rick_h_> frankban: there's talk of a CME? or some new type of exception to get an HA juju into trusty, and it was mentioned we might be able to use the same to get joyent into quickstart |
|
[12:55] <rick_h_> but that would be post-release |
|
[12:55] <rick_h_> post-release of trusty that is |
|
[12:56] <frankban> ack |
|
[12:58] <rick_h_> bah, /me drinks more coffee |
|
[12:59] <rick_h_> cursed toddlers and not sleeping right |
|
[13:29] <frankban> rick_h_: so the ghost charm has a mysql icon? |
|
[13:29] <rick_h_> frankban: it's just how I tested it |
|
[13:29] <rick_h_> I stuck the mysql icon into my local zip of hatch's ghost local charm and uploaded it |
|
[13:29] <frankban> rick_h_: oh, ok :-) |
|
[13:32] <rick_h_> hazmat: ping, so to verify the desire is to not have the ProviderType but the Name in there correct? |
|
[13:44] <hazmat> rick_h_, g'morning.. sleep provided enlightenment. ideal is env annotation for name, with fallback to actual env name. actual env name is fixed at bootstrap. |
|
[13:45] <rick_h_> hazmat: so I've got two things I can do for you at the moment. http://paste.ubuntu.com/7226275/ |
|
[13:48] <hazmat> rick_h_, hmmm okay |
|
[13:49] <hazmat> rick_h_, also if i'm using a branch.. i need the charm to be able to use a release tarball within itself |
|
[13:49] <rick_h_> hazmat: so right now we're shooint for you able to use trunk |
|
[13:49] <hazmat> rick_h_, ie. lp and archive net access only. |
|
[13:49] <rick_h_> hazmat: and maybe even a release |
|
[13:49] <hazmat> rick_h_, well.. having the charm support using a tarball within itself would be useful |
|
[13:49] <rick_h_> frankban: has icons landing, he's updating the charm as well, if I can get something in shortly you can use we'll have a full release |
|
[13:49] <hazmat> ie.. build hook style. |
|
[13:49] <rick_h_> hazmat: it does do that, it's part of releaase |
|
[13:50] <rick_h_> well, we have a releases directory |
|
[13:50] <rick_h_> it's all self contained |
|
[13:50] <hazmat> rick_h_, cool |
|
[13:50] <rick_h_> thus the desire to just make a release today if we can |
|
[13:50] <rick_h_> and find a quick solution for your naming issues so that can push forward |
|
[13:50] <rick_h_> had hoped to do a release tomorrow anyway |
|
[14:06] <rick_h_> jujugui need a review and qa please. Requires a live env to complete qa https://github.com/juju/juju-gui/pull/229 |
|
[14:06] <hatch> rick_h_ I can do it |
|
[14:06] <rick_h_> hatch: ty sir |
|
[14:06] <rick_h_> kadams54: how goes the check of frankban's branch? |
|
[14:06] <hatch> did you say my ghost charm has a mysql icon? I was pretty sure the svg I created used their real icon.... |
|
[14:06] <rick_h_> hatch: I needed a live icon to test that it was picking it up |
|
[14:07] <kadams54> Working on getting a live env up and running for it. juju-quickstart is working its magic right now |
|
[14:07] <rick_h_> so saved the mysql svg and stuck it in the zip to test with :P |
|
[14:07] <rick_h_> kadams54: awesome thanks |
|
[14:07] <hatch> rick_h_ ohh ok so it wasn't picking up the one in the actual charm |
|
[14:07] <hatch> gotha :) |
|
[14:07] <rick_h_> sorry to press, kadams54, just wnat to make sure we can start release process after standup |
|
[14:07] <kadams54> Yeah, no problem |
|
[14:08] <hatch> should probably do heavy qa just in case some of our new flagged work broke anything else :) |
|
[14:08] <rick_h_> reminds me, Makyo qa day gentle reminder |
|
[14:08] <rick_h_> hatch: definitely, hopefully some recent qa days help some and trying to qa some more while I wait for review |
|
[14:09] <rick_h_> hatch: but think a release before your next few branches go in will be a good point of safety :) |
|
[14:10] <hatch> a----greed! |
|
[14:11] <rick_h_> :P |
|
[14:14] <kadams54> So the QA instructions say to deploy a local charm. Is there someplace I can get my hands on a charm? Or do I need to create one? |
|
[14:14] <hatch__> kadams54 download my ghost charm |
|
[14:15] <kadams54> link? |
|
[14:15] <rick_h_> hatch: maybe get one with a custom icon already? |
|
[14:15] <hatch__> https://github.com/hatched/ghost-charm |
|
[14:15] <rick_h_> skip the update step I did |
|
[14:15] <hatch__> it has a custom icon |
|
[14:15] <kadams54> k |
|
[14:15] <rick_h_> oh, /me must have had an old download then |
|
[14:15] <hatch__> rick_h_ https://github.com/hatched/ghost-charm/blob/master/icon.svg |
|
[14:15] <hatch__> it's been in there fo eva |
|
[14:15] <hatch__> 5 months ago |
|
[14:16] <hatch__> yours didn't have that file? |
|
=== hatch__ is now known as hatch |
|
[14:17] <rick_h_> it had a file but didn't show as custom |
|
[14:17] <rick_h_> showed as grey default |
|
[14:17] <rick_h_> so that's why I dropped the mysql one on there |
|
[14:17] <rick_h_> to make sure it was in fact getting a custom icon from teh charm itself |
|
[14:17] <hatch> hmm |
|
[14:18] <rick_h_> hatch: oh hmm I do see it locally |
|
[14:18] <hatch> I don't have anything that can open a svg right now |
|
[14:18] <rick_h_> well 'in my file browser' |
|
[14:18] <hatch> does that icon in there look like the ghost icon? |
|
[14:18] <rick_h_> kadams54: so ignore me, go with hatch |
|
[14:18] <rick_h_> hatch: no |
|
[14:18] <kadams54> Oh, I do that by default. |
|
[14:18] <rick_h_> ruh roh |
|
[14:18] <rick_h_> hatch: ok, well not sure what I did then. |
|
[14:19] <hatch> rick_h_ yeah the icon in the downloaded zip is the proper ghost svg icon... just tested in Ubuntu |
|
[14:19] <hatch> so not sure what happened there.... |
|
[14:19] <rick_h_> hatch: yep |
|
[14:19] <hatch> ^ kadams54 if you don't see the ghost icon then there is a bug in the branch |
|
[14:19] <kadams54> OK |
|
[14:20] <hatch> my vagrant image somehow deleted my .juju folder |
|
[14:20] <hatch> .... |
|
[14:20] <rick_h_> or the gui hates hatch's charm |
|
[14:20] <rick_h_> that's ungood |
|
[14:20] <hatch> impressed I am not |
|
[14:20] <hatch> well it passes proof so... that means there is a bug somewhere :) |
|
[14:21] <hatch> rick_h_ looks like you forgot to update the selenium test for the environment |
|
[14:21] <hatch> http://ci.jujugui.org:8080/job/juju-gui/694/console |
|
[14:22] <hatch> that might be the only real thing the selenium tests are actually testing lol |
|
[14:22] <hatch> brb |
|
[14:24] <rick_h_> hatch: yea, already have another run going |
|
[14:35] <frankban> rick_h_: this can be interesting: https://github.com/frankban/juju-git-deploy/issues/1 |
|
[14:36] <rick_h_> frankban: yes, I've been following that conversation. I didn't worry about it right now because we force users to select a series on upload of local charms |
|
[14:36] <rick_h_> frankban: and we'll have to support that on ingest in charmworld soon as charms start to define it |
|
[14:37] <frankban> rick_h_: yes, for the GUI right now is a nice to have IMHO |
|
[14:37] <rick_h_> frankban: yep, but definitely on the radar and we'll have to make some adjustments going forward |
|
[14:37] <rick_h_> that just got landed in 1.18 so we're still reacting |
|
[14:50] <rick_h_> jujugui call in 10 kanban please |
|
[14:58] <Makyo> jujugui call in 2 |
|
[15:08] <kadams54> frankban: wrapped up QA. Looks good. |
|
[15:08] <frankban> kadams54: cool thanks |
|
[15:09] <rick_h_> jujugui oh was supposed to bring up release after frankban and my branches land. Will start gui releaase with a charm release after frankban's current branch lands for the demo |
|
[15:09] <kadams54> rick_h_: I can take a look at 229 now, since I setup a full env for frankban's branch |
|
[15:09] <rick_h_> kadams54: k |
|
[15:09] <rick_h_> kadams54: yea, should be able to just change the source branch again and see it in action in a live env |
|
[15:10] <frankban> rick_h_: charm branch almost done, it would be nice to include that in the release |
|
[15:10] <rick_h_> frankban: yes, will do |
|
[15:11] <frankban> rick_h_: great thanks |
|
[15:11] <rick_h_> frankban: I'll just start the gui release once our branches land, and will get gui release after the WIP. |
|
[15:11] <frankban> rick_h_: sounds good |
|
[15:11] <rick_h_> frankban: we've got until noon est tomorrow I think? but will try to get it to hazmat by tonight sometime |
|
[15:12] <frankban> rick_h_: yeah, if you don;t have time today, and the the GUI release is done, I can take care of the charm release tomorrow morning |
|
[15:14] <rick_h_> frankban: rgr |
|
[15:19] <hatch> rick_h_ sorry, for whatever reason this vagrant image has 0 juju bits so it's taking a bit to get set up then I'll finish the QA |
|
[15:26] <rick_h_> hatch: k, I think kadams54 volunteered to do qa |
|
[15:26] <rick_h_> hatch: so if you want to split review and qa with him I'd appreciate it |
|
[15:26] <hatch> ok awesome |
|
[15:27] <hatch> I'd like to get on to working heh |
|
[15:27] <hatch> codereview done |
|
[15:27] <rick_h_> hatch: rgr, have fun |
|
[15:27] <rick_h_> thanks for the review |
|
[15:32] <hatch> rick_h_ can we maybe remove the id then? It's just a little confusing |
|
[15:32] <hatch> I prefer classes anyways :) |
|
[15:33] <rick_h_> hatch: maybe, there's some login stuff that hits that specifically as an id |
|
[15:33] <rick_h_> hatch: I'll add a note to the follow up card to generate better looking names |
|
[15:33] <hatch> ahh ok cool np |
|
[15:36] <kadams54> QA is good |
|
[15:36] <rick_h_> kadams54: awesome ty much. What did it read for you? |
|
[15:36] <kadams54> "test on ec2" |
|
[15:36] <rick_h_> cool |
|
[15:37] <kadams54> That would've been really embarrassing if I'd named my environment something like "I'm a lumberjack and I'm OK" |
|
[15:37] <rick_h_> :) |
|
[15:39] * hatch is changing his environment to be "the empire" |
|
[15:40] <rick_h_> lol |
|
[15:40] <rick_h_> "the empire on ec2" had a nice ring to it |
|
[15:53] <hatch> right?! |
|
[16:04] <frankban> guihelp: high priority branch ready for for review: https://codereview.appspot.com/86100043 (charm/python). Anyone available? thanks |
|
[16:05] <bac> frankban: i can review but not qa atm |
|
[16:05] <bac> nah, i can QA too |
|
[16:05] <rick_h_> frankban: will look/qa |
|
[16:05] <rick_h_> or bac has it |
|
[16:05] * bac has it |
|
[16:06] <frankban> heh, thank you! |
|
[16:07] <hatch> does anyone know if there are any side effects to comparing two objects by converting them to json? |
|
[16:07] <rick_h_> hatch: potential ordering issue? |
|
[16:07] <hatch> that's valid |
|
[16:07] <hatch> bleh I really don't want to write a recursive object comparison method |
|
[16:07] <hatch> maybe the internets have something |
|
[16:07] <hatch> YUI is always missing something |
|
[16:08] <rick_h_> hatch: what do we need to compare? |
|
[16:08] <hatch> previous/parsed state |
|
[16:08] <rick_h_> hatch: but typically we check a single thing right? not mass changes in nested objects? |
|
[16:09] <hatch> when the url changes I need to know if the state object generated is different in order to dispatch or not |
|
[16:09] <rick_h_> hatch: always dispatch and the dispatch methods are smart |
|
[16:10] <rick_h_> the dispatch methods have to be anyway |
|
[16:10] <rick_h_> so not saving any code on that end |
|
[16:10] <rick_h_> the only case you're saving is if "nothing at all changed, don't do anything" you still need to check if 'this one thing changed, or that one thing did' |
|
[16:11] <hatch> well I was only going to dispatch the changed items |
|
[16:11] <rick_h_> but the decisions are more complicated than that |
|
[16:11] <rick_h_> check out the existing stuff |
|
[16:11] <rick_h_> you can't just dispatch the one thing, you have to know what did/didn't in concert, at least that's the experience so far |
|
[16:12] <rick_h_> I thought the point was to dipatch to two controllers, one for each section, that then decided what to draw/render/destroy? |
|
[16:12] <hatch> yeah I was trying to write something smarter than that |
|
[16:12] <hatch> s/trying to write/writing/ |
|
[16:13] <hatch> apparently my s/ stopped working |
|
[16:13] <hatch> ok I can do a 'dumb' dispatch |
|
[16:13] <rick_h_> maybe start dumb and look for refactoring chances as the patterns emerge? |
|
[16:14] <rick_h_> but try not to think too far ahead of what we need to move forward |
|
[16:14] <rick_h_> ? |
|
[16:14] <hatch> it's that thinking that got us into all of our messes haha |
|
[16:15] <hatch> ok question |
|
[16:15] <hatch> if the state 'changes' to the exact same state, does previous still get set to current? then previous and current will be the same |
|
[16:15] <rick_h_> I don't quite think that's fair. as the mess isn't to do with that pattern of code/refactor |
|
[16:15] <hatch> inspector issue was lack of foresight for sure |
|
[16:16] <rick_h_> hatch: how does the change end up the exact same state? |
|
[16:16] <rick_h_> say you click on the machine view button again and again |
|
[16:16] <rick_h_> ? |
|
[16:16] <Makyo> hatch, branch updated. |
|
[16:16] <hatch> there's that...but if you say have a /fullscreen/ url and then navigate to the 'proper' url the outcome state will be identical |
|
[16:17] <rick_h_> hatch: ok, exept you'll dispatch the new url which will have fullscreen removed |
|
[16:17] <hatch> so I don't think I should update the previous state unless they truly are different |
|
[16:17] <rick_h_> hatch: so the state is the same, but the url is updated for the user |
|
[16:17] <hatch> exactly, the state didn't change....but the current code will update the previous state to the current state which is the same |
|
[16:17] <hatch> Makyo thanks, I'll take a look in a bit |
|
[16:17] <rick_h_> and in that case the prev/new state are the same, but who cares. If you hit the back button nothing changed because there was nothing to change to |
|
[16:18] <rick_h_> hatch: right, but to what damage? the only way to get a fullscren url is to enter it or go to a bookmark |
|
[16:18] <rick_h_> there's no prev state to mess with anyway |
|
[16:18] <rick_h_> so there's no harm, no complication, or issue with updating the prev state |
|
[16:18] <rick_h_> that I can see atm |
|
[16:22] <hatch> i suppose if the user clicks back and the url changes but nothing in the UI changes that would be alright |
|
[16:22] <hatch> they are old/invalid urls now anyways |
|
[16:24] <rick_h_> I agree. It's not worth a primary concern/test case. It's deprecated behavior. It should 'work' but the odds of hitting it and the experience detriment to the user is minimal. |
|
[16:33] <rick_h_> frankban: if you get a few min can we chat about guiserver? |
|
[16:34] <frankban> rick_h_: sure, now is ok |
|
[16:34] <rick_h_> frankban: https://plus.google.com/hangouts/_/72cpjuub3p0v5iljobcmvkevb8?hl=en thanks |
|
[16:49] <frankban> bac: thanks for the review, are you QAing it? |
|
[16:49] <bac> frankban: yes |
|
[16:49] <frankban> cool |
|
[16:50] * rick_h_ goes to make lunch before starting the release launch process |
|
[17:05] <bac> frankban: doing QA everthing is getting the default icon. i deployed a zip with mongodb which has an icon.svg but it gets the default as does a local charm with no icon. |
|
[17:05] <frankban> bac: juju version? |
|
[17:06] <bac> frankban: hmm, handbuilt from 1.18 |
|
[17:06] <bac> r2262 |
|
[17:06] <frankban> bac: should be ok, is develop correctly installed? |
|
[17:07] <frankban> bac: I mean, the GUI trunk |
|
[17:07] <bac> correctly installed where? |
|
[17:07] <frankban> juju-gui-source=develop, it takes some time |
|
[17:07] <bac> yes i did that |
|
[17:07] <bac> and that causes it to fetch it anew, correct? |
|
[17:08] <frankban> bac: yes it builds a release from trunk |
|
[17:08] <bac> right. |
|
[17:08] <hatch> jujugui could I get another set of eyes on this WIP https://github.com/juju/juju-gui/pull/230 before I write the tests....It's the dispatcher implementation for the state manager |
|
[17:09] <kadams54> hatch: Taking a look |
|
[17:09] <hatch> kadams54 thx |
|
[17:09] <kadams54> My eyes! They burn! |
|
[17:09] <frankban> bac: some browser cache? |
|
[17:09] <hatch> Makyo ok looking at your branch now |
|
[17:10] <hatch> kadams54 lol - hey this is a lot simpler than the original implementation I had planned :) |
|
[17:10] * frankban bbiab |
|
[17:12] <bac> frankban: that was it. cleared cache and then mongo got its icon |
|
[17:12] <bac> upon next deploy |
|
[17:12] <bac> QA-AOK. lunch commences. |
|
[17:14] <kadams54> hatch: am I correct in thinking that sectionA == sidebar and sectionB == content? |
|
[17:14] <hatch> yup |
|
[17:17] <kadams54> So the dispatch stuff - is that pulled over from browser.js? |
|
[17:19] <rick_h_> kadams54: some of it yes, the routeView and such turns into this state dispatch work |
|
[17:19] <rick_h_> kadams54: the actually dispatch methods are app logic that can live in browser.js still I think, but not 100% sure on hatch's plan |
|
[17:19] <jcastro> hey rick_h_ |
|
[17:19] <jcastro> local bundles working and whatnot, that's EOD today still? |
|
[17:20] <rick_h_> local bundles don't work, local icons getting shown is landed and I'm about to start a gui release that will include it |
|
[17:20] <rick_h_> jcastro: I'll be on the 3:30pm call to update and with progress, but trying to get an updated gui release/charm with the changes required right now |
|
[17:20] <hatch> rick_h_ yep you're dead on, I figured the view rendering logic should be in the browser not in the state manager cc kadams54 |
|
[17:20] * jcastro nods |
|
[17:21] <rick_h_> send beers to frankban in quantity |
|
[17:21] <hatch> yeah that was a solid branch frankban in such a quick time |
|
[17:21] <hatch> ^5 |
|
[17:22] <rick_h_> speaking of |
|
[17:22] <rick_h_> jujugui release process is starting. Please no :shipit: until done |
|
[17:22] <rick_h_> sorry for the blockage |
|
[17:22] <hatch> roger |
|
[17:24] <kadams54> hatch: review doen |
|
[17:24] <kadams54> done even |
|
[17:24] <hatch> cool thanks I'll take a look in a second |
|
[17:32] <hatch> Makyo review and qa done |
|
[17:36] <hatch> kadams54 I don't understand the context of your last comment |
|
[18:06] <frankban> rick_h_: charm branch landed! have a nice evening |
|
[18:06] <kadams54> hatch: Sorry, review on https://github.com/juju/juju-gui/pull/230 is done |
|
[18:07] <rick_h_> frankban: woot thanks, 1.0.2 is built so working on charm now |
|
[18:07] <hatch> kadams54 I mean the context of your last review comment |
|
[18:07] <frankban> rick_h_: cool |
|
[18:08] <kadams54> hatch: state used to be stored in raw objects (_current and _previous), now it looks like you've moved to a Model… was wondering what advantages prompted the change? |
|
[18:09] <hatch> ohh I moved it to an attribute |
|
[18:09] <hatch> we cna chat about it in a bit though |
|
[18:10] <kadams54> Hangout? |
|
[18:11] <hatch> yeah just in a call now |
|
[18:11] <kadams54> OK, ping me when ready |
|
[18:21] <hatch> kadams54 when r u back from pycon? |
|
[18:21] <kadams54> 4/17 |
|
[18:25] <hatch> kadams54 https://plus.google.com/hangouts/_/72cpjpk8lfbqkkqmr8ram0gglc?hl=en |
|
[18:26] <rick_h_> kadams54: make sure that if you cna't finsh your branch you get it handed off before you EOD so that it won't hang for the week away please |
|
[18:27] <kadams54> Yup |
|
[18:42] <Makyo> jujugui I have graze box invites if anyone wants. |
|
[18:42] <bac> i do! (what is it?) |
|
[18:42] <bac> oh, no i don't |
|
[18:42] <Makyo> Hahaha |
|
[18:42] <Makyo> No snack boxes? |
|
[18:43] <hatch> ?? |
|
[18:43] <Makyo> https://www.graze.com/us/products |
|
[18:44] <bac> Makyo: they'd probably be stale and soggy by the time they got here |
|
[18:44] <bac> super paranoid? check out the chromebleed extension |
|
[18:44] <Makyo> Yeah, I'm curious to see how it works over the summer. |
|
[18:44] <hatch> wow these order food online things are popping up everywhere, must be huge margins |
|
[18:44] <bac> hatch: yeah, like pets.com |
|
[18:45] <hatch> hah yepp |
|
[18:45] <bac> those were the days. 50# of dog food delivered for free... |
|
[18:48] <Makyo> *dreamy sigh* |
|
[18:48] <Makyo> Two shepherds go through a lot of food. |
|
[18:49] <Makyo> Especially when one's a big chunk. |
|
[18:51] <rick_h_> jujugui heads up release is done and safe to land again |
|
[18:51] <hatch> yay |
|
[18:51] <rick_h_> jujugui just working on the charm release part now |
|
[19:08] <rick_h_> here we go...charm functional tests. |
|
[19:08] <rick_h_> wheeee |
|
[19:08] <rick_h_> blog post time I suppose |
|
[19:44] <hatch> weeee |
|
[19:47] <hatch> new roof this weekend...oooo boy |
|
[19:48] <rick_h_> wheee |
|
[19:48] <hatch> not going to enjoy THAT bill |
|
[19:49] <hatch> but, gota be done I suppose |
|
[19:50] <rick_h_> jujugui anyone recognize http://paste.ubuntu.com/7227836/ running charm tests? |
|
[19:50] <rick_h_> I've got the ec2 env set to precise as default series |
|
[19:50] <hatch> yikes |
|
[19:51] <bac> rick_h_: sure you aren't running local? |
|
[19:52] <rick_h_> bac: yes, I can see the aws instance running |
|
[19:52] <rick_h_> bac: now the tests are trying to colocate the unit on machine 0 in teh test env on ec2 |
|
[19:52] <rick_h_> and I can verify a .juju/environments/ec2.jenv is created withthe default series set to precise |
|
[19:53] <bac> rick_h_: i believe you. just looks like what you get when you try to run functional tests on lxc |
|
[19:53] <rick_h_> bac: yea |
|
[19:53] <bac> juju status shows 0 is precise? |
|
[19:54] <rick_h_> agent-state: pending |
|
[19:54] <rick_h_> instance-id: i-3eb9876f |
|
[19:54] <rick_h_> series: precise |
|
[19:54] <rick_h_> yep |
|
[19:59] <hatch> Makyo wow people really liked my growth hacking tweet lol |
|
[19:59] <hatch> some even say they ARE 'growth hackers'....I wonder if they missed the sarcasm.... |
|
[20:07] <hatch> rick_h_ lastpass is so cool http://blog.lastpass.com/2014/04/lastpass-now-checks-if-your-sites-are.html |
|
[20:07] <rick_h_> :) been there done that |
|
[20:08] <hatch> it's just nice to see that they are actually doing stuff like that instead of just making a 'dumb' storage app |
|
[20:08] <hatch> very cool |
|
[20:16] <hatch> kadams54 it's nearing your EOD no? Need any help to get your branch ready by EOD? |
|
[20:17] <kadams54> Yeah, I'm trying to squeeze every bit of time I can :-) |
|
[20:17] <hatch> haha ok well if you want to pair if that will help speed it up at all lemme know |
|
[20:18] <kadams54> hatch: I'll have some downtime during a layover tomorrow and once I get to the hotel - I've got nothing planned until Friday. If I don't get it handed off today, I'll be sure to do so tomorrow. |
|
[20:19] <hatch> ohh ok alright then |
|
[20:19] <rick_h_> kadams54: which hotel you in for pycon? |
|
[20:19] * rick_h_ will hunt him down for his code |
|
[20:21] <kadams54> lol |
|
[20:21] <kadams54> Hang on… I'm not sure. My hotel info was sent to my old work address :-b |
|
[20:22] <rick_h_> hah |
|
[20:23] <hatch> It's in Montreal so just remember to be super rude |
|
[20:24] <rick_h_> hah |
|
[20:25] <kadams54> So long as I don't have to be rude in French (*ahem* Quebec City) |
|
[20:26] <rick_h_> damn these ec2 tests |
|
[20:26] <kadams54> I can be rude in English and Spanish, does that fulfill the bilingual requirements? |
|
[20:28] <hatch> bleh |
|
[20:28] <hatch> yeah speed in Spanish |
|
[20:28] <hatch> speak* |
|
[20:34] <Makyo> Alright, back on this comp. Super nice out, so I worked on the other laptop while doing a timelapse: https://www.youtube.com/watch?v=87_4e_Ac46A |
|
[20:35] <hatch> cool clouds |
|
[20:35] <hatch> the just appear |
|
[20:36] <Makyo> Yeah. Just under the bottom of the frame is the Rocky Mountains, so the weather coming off of them is always dramatic. |
|
[20:36] <rick_h_> yay tests passed! |
|
[20:36] <rick_h_> push all the things! |
|
[20:36] <Makyo> \o/ |
|
[20:38] <rick_h_> hazmat: https://code.launchpad.net/~juju-gui/charms/precise/juju-gui/trunk updated |
|
[20:38] <rick_h_> hazmat: should hit store soon |
|
[20:39] <rick_h_> hazmat: and reminder that http://paste.ubuntu.com/7226275/ is the manual change to the provider type for the UI |
|
[20:40] <rick_h_> jujugui woot on 1.0.2 http://jujugui.wordpress.com/2014/04/09/juju-gui-1-0-2-released-safari-users-rejoice/ and https://github.com/juju/juju-gui/blob/develop/CHANGES.yaml#L24 |
|
[20:42] <hatch> rick_h_ http://jujugui.wordpress.com/2013/11/07/juju-gui-0-12-0-bundles-beta/comment-page-1/#comment-275 there is a comment here we should reply to |
|
[20:42] <rick_h_> hatch: he emailed gary and gary forwarded it to me and I emailed him on the matter |
|
[20:42] <hatch> ohh ok |
|
[20:43] <rick_h_> hatch: I didn't reply because of that, but I suppose we should as this is public facing. Didn't want to dual slam the guy with answers |
|
[20:44] <hatch> yeah...oh well two answers is better than none :D |
|
[20:44] <rick_h_> well, when the answer is "we don't support it yet" it's a sucky answer to give |
|
[20:49] <rick_h_> woot got the ghost charm icon in my lxc env |
|
[20:50] <rick_h_> hah, and machines in my machine view |
|
[20:50] <rick_h_> all though they're all NAN constraints lol |
|
[20:55] <rick_h_> ok, with that I'm out for the day then. Feel free to ping/call/hangout/etc if you need anything, but hit me up on the personal accounts vs the work accounts. |
|
[20:56] <hatch> sounds good |
|
[20:56] <hatch> cya |
|
[20:56] <hatch> \safe travels |
|
[22:03] <hatch> jujugui anyone around for a review? https://github.com/juju/juju-gui/pull/231 no qa |
|
[23:01] <huwshimi> Morning |
|
[23:13] <rick_h_> morning huwshimi |
|
[23:13] <rick_h_> huwshimi: let me know if you get a few min to chat |
|
[23:13] <huwshimi> rick_h_: Anytime! |
|
[23:14] <rick_h_> huwshimi: want to invite me then or you want me to create the link to invite you? |
|
[23:15] <huwshimi> rick_h_: Either is fine, I have a webcam now :) |
|
[23:15] <rick_h_> woot |
|
[23:15] <rick_h_> huwshimi: https://plus.google.com/hangouts/_/lite/72cpit3iqn5c45ua3duavolva4?hl=en |
|
[23:16] <huwshimi> rick_h_: Can you invite my canonical address? |
|
[23:18] <rick_h_> huwshimi: https://plus.google.com/hangouts/_/72cpi4l0deqtenanpq2b5rtdro?authuser=1&hl=en |
|
[23:50] <hatch> nice, rocking Trusty on metal |
|
[23:50] <hatch> :-) |
|
[23:50] <hatch> hi huwshimi |
|
|