2012/09/28/#maas.txt

=== matsubara is now known as matsubara-afk
[06:47] <jam> jtv: I updated Martin's branch here: https://code.launchpad.net/~jameinel/maas/cpu_mem_tag_constraints/+merge/126863
[06:47] <jam> can you look at it?
[06:47] <jam> I'd like to get it landed today, so that we can set up the rules for diogo to test it.
[06:48] <jtv> OK
[06:49] <jam> bbiab, grocery run.
[06:55] <jtv> jam: thanks for clarifying that mapping...  The InvalidConstraint error looks a bit confusing in that it doesn't distinguish between "unknown tag" and "unusable value for tag."
[06:56] <jtv> Imagine you're using this and you get an error: "Invalid 'architecture' constraint: armhf/nintendo"
[06:56] <jtv> You'd be driving yourself mad figuring out what the problem is with Nintendo ARM support.
[06:57] <jtv> But the error might actually be trying to tell you that you mis-spelled "arch" in the first place.
[06:58] <jtv> Maybe this would work best with separate error classes: UnknownConstraint and BadConstraintValue.
[08:30] <jam> mgz: morning
[08:31] <jam> where's w7z ?
[08:57] <jam> rvba: so, I can do a make run and see where I end up. I know I was missing 'maas-provision' at one point.
[08:57] <jam> I don't quite see how that would  be related, but it was something I installed.
[08:58] <rvba> jam: shouldn't be needed, the dev instance should use bin/maas-provision.
[08:58] <jam> rvba: k, it is listed in HACKING as something you need to install.
[08:58] <jam> I'm getting a failure for 'rndc'
[08:59] <jam> connect failed: 127.0.0.1#9154
[08:59] <jam> and now it runs...
[08:59] <rvba> rvba: Failing tasks should not be a problem really. Let me see what If I can get everything to work with trunk…
[09:00] <jam> I see a lot of failures in the celery log, but those *aren't* IOError unhandled exceptions trying to read a file.
[09:00] <rvba> The dns server takes a few seconds to come up so some of the tasks fail, then are retried, then they work.
[09:00] <jam> so I have a feeling 'captured exception' vs 'unhandled exception' was what was killing the celery working and breaking the startup.
[09:01] <jam> So I still have failures, but it fails in a way that I can use it.
[09:02] <jam> rvba: so thank you for scaring my machine into working
[09:03] <rvba> jam: does the web interface work now? (http://0.0.0.0:5240)
[09:04] <jam> rvba: localhost:5240 works now, yes
[09:11] <jam> allenap: is there a way to figure out what is generating "bin/maascli: error: u'name'" ?
[09:12] <jam> (I wonder if the issue is something is meant to be sent as 'name' but it is labeled 'tag_name' somewhere else)
[09:12] <allenap> jam: In src/maascli/__init__.py, raise instead where it catches StandardError, might help. otp right now.
[09:15] <jam> allenap: essentially, things seem broken when trying to access Node or Tag apis, because the URL has a sub-component.  For example, I would expect to do: bin/maascli api maas tag tag-name read rather than bin/maascli tag read tag-name. Because the URL is GET api/1.0/tags/tag-name/
[09:16] <mgz> okay, am back now
[09:16] <jam> hi mgz, mumble?
[09:21] <mgz> jam: lets
[09:36] <jam> jtv: so you didn't actually vote on my MP, we can just put your code in there and do it, is that enough to land it?
[09:37] <jtv> jam: not enough, no.  Wanted to hear your answers first!
[09:37] <jtv> If it's a problem to address them today, we can negotiate a more lenient sentence.
[09:37] <jam> jtv: well, the immediate thing is getting something that can be QA'd
[09:38] <jam> which needs something to land
[09:38] <jam> I don't particularly mind module vs class
[09:40] <jtv> The class thing is a valid technique, but since it contains nasty bits that are out of the ordinary it does need to be made clear.  In this case, it doesn't provide any convenience at all, so the cleverness seems out of place.
[09:42] <jtv> If you want to keep it the way it is, please document how those private methods fit in.
[09:46] <jam> mgz: https://code.launchpad.net/~jameinel/maas/tag-name-api/+merge/126897
[10:18] <mgz> juju.errors.ConstraintError: Bad 'maas-tags' constraint 'speedy': tag 'speedy' does not exist
[10:31] <jam> mgz: as in it now works?
[10:35] <mgz> jam: indeed
[10:36] <jam> mgz: I seem to have broken whatever code you had that turned InvalidConstraint into a NOT_FOUND (though we really want BAD_REQUEST, right?)
[10:38] <mgz> you probably just want to flip the expectation in the test
[10:54] <jam> mgz: yep, that was enough, I was just confused by the traceback it showed for context.
[10:55] <jam> jtv: care to look at https://code.launchpad.net/~jameinel/maas/cpu_mem_tag_constraints/+merge/126863 again?
[10:57] <jtv> Coming
[10:57] <jam> I have one more quick patch to line up the constraint name with the db field name
[10:57] <jam> but that should be small.
[11:07] <jtv> jam: done
[12:12] <mgz> allenap: forgive me for what I am about to do
[12:13]  * allenap dons ceremonial robes
[12:17] <mgz> it's not that I don't respect your reviews, it's just the easiest way of landing the finished branch :)
[12:27] <allenap> mgz: I was just going through the queue, tidying up; I don't have any objection whatsoever to you landing that branch :)
[12:28] <allenap> Morning ahasenack :)
[12:28] <ahasenack> hi allenap
=== matsubara-afk is now known as matsubara
[13:33] <roaksoax> allenap: howdy
[13:33] <roaksoax> allenap: any luck with the tftp stuff?
[13:33] <allenap> roaksoax: Hi three.
[13:34] <allenap> roaksoax: We talked about it this morning. The answer is: use http :) We don't have time to address that problem. I'm sorry about that.
[13:34] <allenap> roaksoax: We can revisit it after 12.10 if it's important.
[13:35] <roaksoax> allenap: no worries :) HTTP was my approach too :)
[13:35] <allenap> roaksoax: Cool. Let me know if you need someone for fisticuffs with Daviey :)
[13:37] <roaksoax> allenap: thanks but I think he will understand :)
[13:41] <Daviey> fisticuffs ?!
[13:41] <Daviey> I'm not that kinda man!
[13:41] <Daviey> at least buy me dinner first.
[13:46] <allenap> I think you misunderstood. Not /those/ kinds of cuffs Daviey. Keep those for the weekends.
[13:49] <smoser> how do i configure maas-cli ?
[13:50] <smoser> allenap, ^
[13:52] <allenap> smoser: Do you mean, how do you get started? maascli api login local http://localhost:5240/MAAS/api/1.0/ $CREDS
[13:53] <allenap> smoser: Then: maasapi api local --help
[13:53] <allenap> smoser: If you omit $CREDS, you'll be prompted for them. You can also specify them as an empty string for anon access only, or pipe them in.
[13:54] <smoser> right.
[13:54] <allenap> smoser: Sorry, specify them as - in order to pipe in.
[13:54] <smoser> $ maas-cli api list
[13:54] <smoser> maaslocal http://localhost/MAAS/api/1.0/ 8mnmG6X3Erxmw5SzGV:KFmZYJYsewXxD5RSjR:WKbZWmrt63hNQVXG7JzyjRtTRjkj3esK
[13:55] <smoser> probably didn't want it to print my creds there.
[13:55] <allenap> smoser: I'm guessing that machine isn't accessible from here :)
[13:55] <smoser> try them!
[13:55] <smoser> i suggest rooting the machine 'localhost' and destroying it!
[13:55] <smoser> :)
[13:55] <allenap> Haha :)
[13:58] <smoser> allenap, so the first thing i wanted to do with my shiney new api client...
[13:58] <smoser> was to upload some ssh keys
[13:58] <smoser> as i have to do that in the web ui , and that sucks.
[13:58] <allenap> ... doesn't work?
[13:58] <smoser> can i do that?
[13:58] <allenap> I don't think so; matsubara filed a bug about it.
[13:59] <smoser> ah. k.
[13:59] <smoser> next question
[13:59] <smoser> using 'maas' (not 'maas-cli') how can i get a user's creds ?
[13:59] <smoser> (again to avoid going to web ui)
[13:59] <allenap> This is the first proper client of the API, so not everything that's in the web is available in the API yet :-/
[13:59] <allenap> rvba: ^?
[14:00] <smoser> allenap, thats fine.
[14:00] <smoser> i'm just trying to work through a path that would be able to actually do something useful
[14:00] <smoser> without a human clicking buttons
[14:01] <smoser> (as much as i enjoy clicking buttons, i enjoy complaining more)
[14:01] <rvba> smoser: there is the create_authorisation_token API method.
[14:01] <allenap> rvba: I guess that's a chicken and egg scenario.
[14:01] <smoser> rvba, i think you're missing my goal.
[14:01] <smoser> i added the user with 'maas createadmin'
[14:01] <rvba> allenap: right :)
[14:02] <smoser> (or i suppose i can add a user somehow with 'maas' cli)
[14:02] <smoser> i want to then get (or create) credentials for that user
[14:02] <rvba> Right, chicken and egg, as allenap said.
[14:02] <allenap> smoser: You might be able to do: echo "SELECT ..." | maas dbshell
[14:02] <smoser> its not really chicken and egg.
[14:02] <smoser> i'm using hte 'maas' executable. so i have a suitable chicken.
[14:03] <smoser> i'll poke around in the db
[14:03] <rvba> Indeed.  From the right angle, it looks like a chicken.
[14:04] <smoser> allenap, http://paste.ubuntu.com/1247554/
[14:04] <allenap> maas lay_eggs_dammit
[14:04] <smoser> maas dbshell stacktrace
[14:04] <allenap> Ahh.
[14:05] <allenap> We don't ship the test code in packages.
[14:06] <smoser> https://bugs.launchpad.net/maas/+bug/1058126
[14:06] <ubot5> Ubuntu bug 1058126 in MAAS "maas dhshell stacktraces in package" [Undecided,New]
[14:06] <smoser> i'll open a bug for "please give me some creds!"
[14:10] <rvba> smoser: we could create a command for that but to give you a workaround, you can pipe http://paste.ubuntu.com/1247565/ in ./bin/maas shell.
[14:10] <smoser> gracias.
[14:10] <smoser> can a user change their password via api?
[14:11] <smoser> web login password
[14:11] <rvba> No.
[14:12] <rvba> But there is a *changepassword* command.
[14:12] <rvba> But no API method yet, sorry.
[14:12] <allenap> So it can't be done remotely.
[14:13] <rvba> No. it cannot be done remotely.
[14:19] <roaksoax> allenap: do you mind, think is correct that I install the squashfs image at the same place where the tftp image are available, and then make it available through tftp?
[14:19] <roaksoax> err
[14:19] <roaksoax> s/tftp/HTTP?
[14:20] <smoser> is there a way to make maas shell not interactive ?
[14:23] <allenap> smoser: I've been trying that... and it seems not :-/
[14:23] <allenap> roaksoax: Erm, for expediency, okay. Otherwise I'd say it's not the right place.
[14:24] <roaksoax> allenap: so I guess i'd have to modify maas-provision install-pxe-image to support a --image="squashfs" method then?
[14:26] <smoser> why is it that we're not going over http with this ?
[14:26] <allenap> roaksoax: That command is for a kernel and initrd image, rather than a root filesystem, but for 12.10 I think it's okay to piggyback on it without change, and just serve the whole tftp tree over http too.
[14:26] <roaksoax> smoser: we are going through http
[14:26] <smoser> ah. ok.
[14:26] <roaksoax> allenap: ok
[14:26] <smoser> then can we make a different command instead?
[14:27] <smoser> a generic one, that just says "make this file avialable at this path"
[14:27] <roaksoax> yes I think that would be better instead
[14:27] <smoser> i'm not sure what i think about it really.
[14:28] <allenap> smoser: Yeah, we could. install-pxe-image is basically that command, except in name, so I think it's okay for 12.10, unless you think it's just storing up pain?
[14:28] <smoser> hm..
[14:28] <smoser> well i reallythink you should not put the stuff int eh same path as tftp
[14:28] <allenap> What's downloading the squashfs image from the archive?
[14:29] <allenap> smoser: I agree, perhaps I don't feel as strongly, but if we can avoid extra work that would be good too :)
[14:29] <smoser> and i thikn that install-pxe-image's arcane behavior of deleting data is generally unsuitable
[14:30] <roaksoax> ok there's an issue with maas-import-pxe-files
[14:30] <smoser> its not *terrible* as an internal tool, but its *not* an internal tool
[14:30] <smoser> (/usr/sbin)
[14:31] <smoser> errr... wait . ignore that last comment.
[14:31] <roaksoax> when we call maas-import-pxe-files with RELEASES="precise quantal", then maas-import-ephemerals dies in quantal, causing maas-import-pxe-files to die as well
[14:32] <roaksoax> smoser: ^^
[14:33] <roaksoax> allenap: ^
[14:34] <allenap> roaksoax: How does it die?
[14:35] <roaksoax> allenap: so maas-import-ephemerals exits becuase there's no quantal image right? so if you put something to be done after that, it won't be executed
[14:36] <roaksoax> allenap: so if i enable RELEASE="precise quantal" for import_pxe_files config file
[14:36] <roaksoax> allenap: when it runs maas-import-ephemerals it dies with: failed to get https://maas.ubuntu.com/images/query/quantal/ephemeral/released-dl.current.txt
[14:36] <roaksoax> remote query of https://maas.ubuntu.com/images failed
[14:36] <roaksoax> and then maas-import-pxe-files stops there and does not continue
[14:37] <roaksoax> so if I add the maas-import-squashfs execution, then it wont be executed due to maas-import-ephemerals failed making maas-import-pxe-files terminate
[14:37] <roaksoax> rvba: in the templating system, can we test for the existance of files in particular locations?
[14:37] <smoser> roaksoax, known issue
[14:38] <smoser>  echo "STREAM=daily" | sudo tee -a /etc/maas/import_ephemerals
[14:38] <smoser> there are no released quantal ephemerals
[14:38] <roaksoax> rvba: what I wanna do is test whether the squashfs image exists in the directory, if it doesn't then don't make the intsaller try to use it
[14:39] <roaksoax> smoser: yeah I know, but my point being is that maas-import-pxe-files should not stop when maas-import-ephemerals has stopped
[14:39] <roaksoax> smoser: so maas-import-pxe-files should continue to do everything else that it was supposed to do
[14:39] <roaksoax> but it doesn't
[14:39] <allenap> roaksoax: The call out to maas-import-ephemerals (in the import_ephemeral_images function) could be || echo "Importing ephemerals from ... failed" >&2 so that it doesn't cause everything to stop. Is that reasonable?
[14:40] <smoser> roaksoax, i consider that arguable.
[14:40] <smoser> it should most definitely error if something errored.
[14:40] <smoser> going down a sour path and pretending life is fine is notuseful
[14:41] <roaksoax> smoser: indeed. but for example, if I were to add the function for maas-import-squashfs after the maas-import-ephemerals, then becuase the latter failed, maas-import-squashfs function won't be executed
[14:41] <smoser> if the package installation fails that will also not happen
[14:41] <smoser> should we make dpkg just ignore failure?
[14:41] <roaksoax> allenap: i think so yes, it should error as smoser mentioned
[14:42] <smoser> i think the behavior is correct right now. if something fails, generally, it should exit.
[14:42] <roaksoax> smoser: i'm not saying that we should ignore that error, I'm saying that because commissioning image is not available in the release we want, it means that we will fail to download the squashfs image that we know exists
[14:43] <rvba> roaksoax: I think it would be better to create a variable that will be True or False depending on the existence of the files and pass that to the template.
[14:43] <smoser> this is a development release issue only, roaksoax
[14:43] <smoser> and it is easily fixable
[14:43] <smoser> i can make a quantal daily based on the beta-2, test it, and call it "released"
[14:43] <roaksoax> rvba: where do we do that?
[14:43] <smoser> in fact, i probably *should* do that.
[14:45] <rvba> roaksoax: src/maasserver/preseed.py:get_preseed_context.  Simply create a utility method like "def is_squashfs_image_present" (or something) and then add that to the context in get_preseed_context.
[14:46] <rvba> roaksoax: also, please don't forget to review Julian's branch (https://code.launchpad.net/~julian-edwards/maas/add-maas-cluster-packaging/+merge/125427).  It's fairly critical for us to get this landed asap.
[14:47] <roaksoax> smoser: so the thing is that we can't globally say "import release X,Y,Z" and fail because scriptX doesn't make use of release Y.
[14:47] <roaksoax> smoser: as in, the maas-import-squashfs only supports quantal and up
[14:47] <roaksoax> smoser: and maas-import-ephemerals only supports precise for now
[14:48] <smoser> roaksoax, well, a.) you can actually configure that seperatly (as shown above in /etc/maas/import_ephemerals)
[14:48] <smoser> b.) i'm not sure that i agree with that statement anyway.
[14:48] <smoser> if something is busted, it shoudl fail
[14:48] <roaksoax> rvba: i'm aware
[14:48] <smoser> if config says "import squashfs for precise" then it should fial trying to do that.
[14:49] <rvba> roaksoax: All right :). Thanks.
[14:49] <roaksoax> rvba: there's things to test such as precise upgrades, quantal upgrades after the split is in place, etc etc
[14:49] <rvba> Yep, lots of testing and fixing.
[14:49] <allenap> roaksoax: smoser's right; we shouldn't ignore errors too broadly. I'd say, if the query_remote in maas-import-ephemerals returns HTTP 404, then (and only then) can we continue.
[14:49] <roaksoax> smoser: right, exactly, should fail to import precise, but should not fail to import quantal
[14:50] <roaksoax> smoser: so it should say: "failed to import precise, not existant\n successfully imported quantal"
[14:50] <smoser> it should exit non-zero
[14:50] <smoser> which is probably going to cause any automation based on it to fail
[14:50] <smoser> in which case the problem has to be fixed *right now*
[14:50] <smoser> so you might as well fix it.
[14:50] <roaksoax> smoser: the problem is not on maas-import-ephemerals
[14:50] <roaksoax> smoser: the problem is in maas-import-pxe-files
[14:51] <smoser> fix the problem. do not ignore the errors.
[14:51] <smoser> i realize you're basically arguing that you want 'make -i' (just go as far as you can)
[14:51] <smoser> which is not entirely unreasonable.
[14:51] <smoser> but i dont think it *really* buys you anything here.
[14:53] <rbasak> rvba: when I try doing a schemamigration --auto, I get a bunch of extra changes. I take it this is a problem? http://paste.ubuntu.com/1247643/
[14:53] <roaksoax> smoser: ok so for example, lets consider this case. import_pxe_files says RELEASES="precise quantal". So currently, we are making the assumption that there's Ephemerals and Squashfs images available because all scripts source import_pxe_files
[14:53] <rvba> rbasak: these are the changes from migration 29 and 30.  they should not be there.
[14:54] <rvba> rbasak: make sure you distclean your env and create the migrations again.
[14:54] <rbasak> rvba: will do, thanks
[14:54] <roaksoax> smoser: however, the problme is that squashfs only supports quantal and Up, and ephemerals only has precise available.
[14:54] <smoser> so
[14:54] <smoser> a.) change /etc/maas/import_ephemerals to have RELEASES="precise"
[14:55] <smoser> b.) add some configuration explicitly for SQUASHFS and turn it off by default for < quantal
[14:55] <smoser> but if the user configures that on, then you need to fail
[14:55] <roaksoax> smoser: so as a user, comes an runs maas-import-pxe-files and finds itself with a failing import
[14:55] <smoser> ie, if they say "oh look i'll install squashfs for precise by adding that line here"
[14:55] <smoser> then you should fail when it does that.
[14:55] <smoser> not ignore and go on
[14:56] <smoser> i'm saying the user will not find a failing import
[14:56] <smoser> unless they change something, explicitly asking for a configuration that does not work.
[14:56] <roaksoax> alright
[14:56] <roaksoax> i give up
[14:57] <smoser> i really dont care all that much.
[14:57] <smoser> but ignoring the errors is wrong
[14:57] <smoser> the default shoudl be to work correctly.
[14:57] <smoser> we need to fix the defaults (or release a 'released' of ephemeral for quantal. i will do that now)
[14:57] <roaksoax> again, i'm NOT ignoring errors
=== hazmat` is now known as hazmat
[14:58] <roaksoax> i'm NOT suggesting to ignore errors
[14:59] <smoser> you said: "we are making the assumption that there's Ephemerals and Squashfs images available because all scripts source import_pxe_files"
[14:59] <roaksoax> maas-import-pxe-files calls maas-import-ephemerals, if the latter failed, good, it failed, that shouldn't stop maas-import-pxe-files from continuing because the fail is not in maas-import-pxe-files, it is in maas-import-epehemrals
[14:59] <smoser> i'm saying "that assumption is your problem"
[15:00] <rbasak> rvba: so after distclean, schemamigration --auto says that nothing has changed, presumably because my code was already post-schema-change
[15:00] <rbasak> rvba: I'm a bit worried about screwing this up. Do I need to revert the schema change, run syncdb, reapply the schema change and then run schemamigration --auto?
[15:00] <rbasak> rvba: or is there another way?
[15:01] <smoser> maas-import-ephemerals is part of maas-import-pxe-files .
[15:01] <smoser> its no less part of that than adding tftp files
[15:01] <rvba> rbasak: South should compare the state it has in the last migration file, compare it with the state of the model, and identify the migrations to be done.
[15:01] <smoser> $ grep EPHEM /etc/maas/import_pxe_files
[15:01] <smoser> #IMPORT_EPHEMERALS=1
[15:01] <rvba> rbasak: let me have a look at that branch.
[15:01] <rbasak> rvba: there was a merge conflict merging trunk. Shall I push the dropping of the migration files and the trunk merge?
[15:02] <rvba> rbasak: yes please.
[15:02] <roaksoax> smoser: oyu are the expert, you know best
[15:02] <roaksoax> i give up
[15:02] <rbasak> rvba: done
[15:11] <rvba> rbasak: migration seems all right to me: http://paste.ubuntu.com/1247675/
[15:18] <rvba> rbasak: it was created simply by running: './bin/maas schemamigration maasserver --auto change'. Then you need to create the other migration by hand of course since it's not a schema change.
=== matsubara is now known as matsubara-lunch
[15:23] <rbasak> rvba: I'm running make distclean, then make, then bin/maas schemamigration maasserver --auto change, and I get "Nothing seems to have changed."
[15:23] <rbasak> rvba: never mind
[15:24] <rbasak> rvba: I think distclean was missing something
[15:24] <rbasak> rvba: I ran rsync -a --delete from a different checkout of the branch, and using that it worked
[15:24] <rvba> rbasak: it would be good to know what is was missing so that I could fix this.
[15:25] <rbasak> rvba: it's gone now :-/
[15:47] <rbasak> rvba: would you mind checking if https://code.launchpad.net/~racb/maas/subarch-model/+merge/126712 looks good to you now please?
[15:47] <rvba> rbasak: sure
[15:52] <roaksoax> rvba: so like this: http://paste.ubuntu.com/1247761/
[15:53] <rvba> rbasak: the migrations looks fine to me… but I get 2 failures when I run the test suite: http://paste.ubuntu.com/1247762/
[15:54] <rbasak> rvba: ah. That'll be caused by me merging trunk. I should have ran tests again after that, sorry.
[15:54] <rvba> rbasak: no problem.
[15:56] <rvba> roaksoax: looks ok but: a) you can return directly os.path.exists(..) (no need for the "if" statement) and b) "TFTPROOT/node.architecture/generic/node.distro_series/install/filesystem.squashfs" will need to be fixed of course :).
[15:57] <rbasak> roaksoax: do we need a precise task for bug 1056816?
[15:57] <ubot5> Launchpad bug 1056816 in maas-enlist (Ubuntu) "maas-enlist does not post subarch" [Undecided,Fix released] https://launchpad.net/bugs/1056816
[15:57] <roaksoax> rvba: yeah! alright I will have a MP for monday cause I have yet to test that.
[15:57] <roaksoax> rbasak: yes we do
[15:58] <rvba> roaksoax: cool.
[15:58] <rbasak> roaksoax: could you create one for me please? I can only nominate.
[15:58] <roaksoax> rbasak: sure
[16:12] <rbasak> rvba: I've pushed a fix to those two tests. I get one other error. Did you see this too? http://paste.ubuntu.com/1247800/
[16:13] <rvba> rbasak: looks like it's a warning, not an error. jtv ^, I think you've seen that problem already right?
[16:13] <jtv> Huh what?
[16:13] <rbasak> jtv: Exception socket.error: (107, 'Transport endpoint is not connected') in <bound method TCPTransport.__del__ of <amqplib.client_0_8.transport.TCPTransport object at 0x8834c10>> ignored
[16:13] <jtv> Test noise.
[16:14] <jtv> Yeah, I had that at one point but I killed it.
[16:14] <rbasak> OK
[16:14] <rbasak> rvba: I'll merge my branch in then
[16:14] <jtv> It happened when I ran the full test suite, but not when I ran _any_ individual test.
[16:14] <rbasak> rvba: unless you object...
[16:14] <jtv> Well wait a moment...
[16:14]  * rbasak hopes he hasn't missed anything
[16:14] <jtv> We don't want that test noise in trunk.
[16:14] <rbasak> This is probably the riskiest thing I've landed so far, but I'm not sure what else I can check
[16:14] <jtv> Let me see if I can remember what happened.
[16:15]  * rbasak waits
[16:15] <mgz> looks like a shutdown race
[16:15] <rvba> rbasak: I think that branch is fine now.  Let's see if jtv can help with the test noise.
[16:15] <mgz> __del__ methods are fun, just print rather than propogate exceptions
[16:15] <jtv> My hypothesis was that I caused something like a celery connection to be set up that exited immediately, after which the cleanup failed.
[16:17] <jtv> So the problem may be that you're touching a real-world resource in testing.
[16:17] <jtv> Celery/rabbit-related resource.
[16:18] <jtv> Does it happen somewhere during shutdown of one chapter of the test suite, or setup of the other?
[16:22] <rbasak> jtv: it's in http://paste.ubuntu.com/1247800/
[16:23] <rvba> jtv: branch approved but with comments.
[16:23] <jtv> Thanks.
[16:24] <jtv> rbasak: yes, that's very similar
[16:26] <jtv> I'd look for places where you may have brought tests in contact with celery, e.g. by introducing a celery task invocation.
[16:27] <jtv> The error will happen, most of the time, if you run the maasserver tests plus any portion of our test suite right after it.
[16:27] <jtv> I think that you may need a celery fixture on any test case that may end up triggering a task.delay call.
[16:30] <roaksoax> rvba: btw... how do I get the tftp root. Config.objects.get_ etc etc?
[16:34] <rvba> roaksoax: no, the config in pserv is managed differently, see src/provisioningserver/boot_images.py but basically, you can do from provisioningserver.config import Config / Config.load_from_cache()['tftp']['root'].
[16:34] <rvba> I'd like allenap to confirm that if possible? (^)
[16:34] <roaksoax> allenap: ^^
[16:35] <allenap> roaksoax: That looks about right.
[16:35] <roaksoax> awesome thanks :)
[16:36] <rbasak> jtv: I don't understand what I could have changed that caused this. All the tests I've touched haven't changed in what they do
[16:36] <jtv> rbasak: it may not be the tests
[16:37] <jtv> Did you change any code in maasserver?
[16:37] <rbasak> Yes, but only in pure python stuff. Nothing that should hit any libraries any differently
[16:38] <rbasak> string changes, a data migration, a schema migration, and creating a new QueryDict
[16:39] <rbasak> That's it as far as I can see
[16:39]  * rbasak has a hard stop in 20 minutes :-/
[16:39] <rbasak> Yet I can't reproduce the problem in trunk but it is present in my branch AFAICT
[16:43] <rbasak> Just failed to reproduce on another run
[16:43] <rbasak> on my branch
[16:43] <rbasak> I'm going to assume that it's not an issue in my branch unless anyone objects
[16:43] <rbasak> I can't fathom how I could have introduced it
[16:44] <jtv> I guess you'll have to land it.  :/
[16:46] <jtv> rbasak: got an MP I could have a look at?
[16:47] <rbasak> jtv: https://code.launchpad.net/~racb/maas/subarch-model/+merge/126712
[16:47] <jtv> Thanks.  No promises.
[16:47] <jtv> (Nearly midnight)
[16:51] <jtv> rbasak: conflicts in the branch?  :(
[16:53] <rbasak> jtv: rev 1108?
[16:53] <jtv> Not showing a revision for some reason, but it's in the MP.
[16:54] <rbasak> jtv: aargh. I only merged trunk about an hour ago!
[16:54] <jtv> Welcome to the Agile world!
[16:54] <jtv> I introduced a new model in a similar time and was told that you had _two_ database migrations landing that had to go before mine.  :)
[16:56] <rbasak> ...and I'd already had to redo those two migrations because a constraints related one had landed during my review
=== matsubara-lunch is now known as matsubara
[17:00] <jtv> Welcome to Saturday.
[17:00]  * rbasak is waiting for tests to finish
[17:00] <mgz> matsubara: is there anything else you need from us before you can try the tagging and constraint testing? jam sent an email with some general instructions to the list.
[17:01] <matsubara> mgz, I'll take a look later on today. I need to finish some other stuff
[17:01] <rbasak> jtv: merged trunk and pushed. Now on 1109
[17:02] <jtv> \o/
[17:02] <rbasak> jtv: I need to go shortly. If you decide it's OK to land, could you please mark it approved please, so I don't come back on Monday to redo it all over again?
[17:02] <mgz> matsubara: no problem, I'm just nearing EOD
[17:02] <jtv> I will.
[17:02] <rbasak> Thank you!
[17:04] <jtv> nn
[17:05] <smoser> released quantal ephemeral images at https://maas.ubuntu.com/images/query/quantal/ephemeral/
[17:06] <smoser> i'm working on right now testing the daily images of precise
[17:06] <smoser> so that we could mark them as released
[17:09] <rbasak> thanks jtv!
[17:09] <jtv> It's landing.
[17:10] <jtv> Enjoy your weekend.
[17:10] <roaksoax> rvba: still around? https://pastebin.canonical.com/75579/
[17:11] <rvba> roaksoax: looking
[17:11] <roaksoax> rvba: that's the latest package julian made available on experimental
[17:11] <rvba> roaksoax: right, this has been fixed upstream this morning.
[17:11] <roaksoax> rvba: alroight coo.
[17:11] <roaksoax> alright cool
[17:11] <roaksoax> thanks
[17:12] <rvba> roaksoax: revision 1098
[17:12] <roaksoax> rvba: alright, awesome thanks
[17:12] <rvba> np
[17:17] <matsubara> roaksoax, this /var/lib/dpkg/info/maas-cluster-controller.postinst: 25: local: not in a function is fixed by your recent fixes?
[17:17] <roaksoax> matsubara: yes, I'm gonna upload something now
[17:17] <matsubara> cool
[17:22] <roaksoax> matsubara: ok so I've uploaded, should build and yadah yadah in the next few mins :)
[17:23] <matsubara> thanks roaksoax
[17:23] <matsubara> roaksoax, are you dputting this directly into the ppa?
[17:24] <roaksoax> matsubara: yeah
[17:24] <matsubara> ok
[17:35] <smoser> random comment.
[17:36] <smoser> maas in quantal is a lot nicer than maas in precise.
[17:36] <smoser> so good work on that.
[17:36] <smoser> i was just trying to test ephemeral images that they're good for 12.04 and realizing it is much nicer over all
[17:38] <jtv> Glad to hear that, in the middle of the current rush to get anything working at all.  :)
[17:45] <matsubara> roaksoax, is the maas-dhcp working on that ppa?
[17:45] <matsubara> any known issues, I mean
[17:46] <matsubara> looks like it didn't write /etc/maas/dhcpd.conf
[17:47] <roaksoax> matsubara: maas-dhcp is only a virutal package that installs isc-dhcp-server
[17:47] <roaksoax> and required files
[17:47] <roaksoax> you have to enable dhcp stuff differently now
[17:50] <matsubara> roaksoax, how? through the web-ui?
[17:50] <roaksoax> matsubara: maas-provision I believe
[17:50] <matsubara> hmm the web-ui doesn't have a option anymore
[17:50] <roaksoax> i can't see the options on the webUI anymore
[17:51] <roaksoax> jtv: ^^
[17:51] <matsubara> are we really making it extra hard to install MAAs
[17:51] <matsubara> ?
[17:52] <jtv> You should still be able to configure dhcp through the UI.
[17:52] <matsubara> jtv, there's no option anymore in the web ui
[17:52] <jtv> rvba would be the person to ask -- he's had to make some changes tonight
[17:53] <jtv> Those IP fields are of a different type now, inside Django.
[17:53] <jtv> Because the regular IPAddress field didn't support nulls.
[17:53] <smoser> matsubara, it worked for me earlier today from ppa
[17:54] <matsubara> jtv, which IP fields?
[17:54] <matsubara> jtv, the only IP fields I had to configure through the web ui before was the IPMI addresses
[17:54] <roaksoax> jtv: there's no UI option for DNS nor DHCP
[17:54] <jtv> The IP-address fields in a nodegroup's interfaces.
[17:54] <roaksoax> they are gone for quite some time now
[17:54] <matsubara> smoser, I'm using a new package now
[17:54] <smoser> roaksoax, i'm on 12.04 maas.
[17:54] <smoser> and i boot for enlistment
[17:54] <jtv> roaksoax: is that related?
[17:54] <smoser> and it seems to sit forever on a blank-ish screen
[17:54] <matsubara> smoser, I'm on the experimental package
[17:55] <matsubara> jtv, with the new package looks scheme, maas-dhcp is a suggested package and I'm not asked anymore if I want MAAS to be the dhcp server
[17:55] <matsubara> s/looks//
[17:56] <jtv> I'm sorry, this is a bit more than I can process at this time of Saturday.  Can we take this in steps?
[17:57] <roaksoax> jtv: 1. Install package from maas-maintainers/experimental
[17:57] <roaksoax> 2. maas-dhcp installs only files
[17:58] <roaksoax> hold on
[18:00] <roaksoax> 2. maas-dhcp no longer configure the DHCP server
[18:00] <roaksoax> 3. when you go to the WebUI Settings page, there's no obtions to enable DHCP
[18:03] <jtv> Well I'm not sure it'd be in the settings page.
[18:04] <jtv> I do think we have a 3-way switch somewhere (manage dhcp/dns, manage dhcp, manage neither) but DHCP management must now be enabled per cluster.
[18:26] <smoser> jtv, you have an idea maybe ?
[18:26] <smoser> http://paste.ubuntu.com/1248056/
[18:27] <smoser> running that does this:
[18:27] <smoser> http://paste.ubuntu.com/1248061/
[18:28] <jtv> No...  haven't done much yaml parsing
[18:29] <smoser> well, the point is its valid with yaml.load()
[18:29] <smoser> but not with yaml.safe_load()
[18:32] <jtv> Yes, and I have no idea what that means or why it is the case.  Sorry.
[18:34] <roaksoax> Daviey: btw.. squashfs support is done. Needs to be merged which will happen next week
[18:35] <Daviey> roaksoax: i wonder if we can end the week with it merged?
[18:35] <Daviey> roaksoax: what sort of speed improvement did you see?
[18:36] <roaksoax> Daviey: i haven't really compared
[18:37] <roaksoax> Daviey: but installing the system from squashfs seems much faster than downloading everything
[18:37] <roaksoax> and installing to disk
[18:37] <Daviey> ok, thanks
[18:38] <roaksoax> Daviey: and as to the merge... i need to fix/add tests
[18:38] <roaksoax> Daviey: but since I wanna finish testing the packaging I might not have the time to do so
[18:38] <Daviey> ah ok
[18:38] <roaksoax> Daviey: ideally, I'd like to merge the packaging today
[18:38] <Daviey> yeah
[18:38] <roaksoax> so that we can upload next week
[18:38] <roaksoax> i have yet to test precise upgrades
[18:39] <roaksoax> to new packaging though
[18:39] <roaksoax> but the best way to do that is having it on the archives
[18:39] <Daviey> yeah
[18:59] <matsubara> roaksoax, should I file bugs for the experimental package? (i.e. the dhcp issue with the new package scheme)
[19:00] <matsubara> not sure if it's a packaging bug or upstream though...
[19:00] <roaksoax> matsubara: yes, but file them in upstream
[19:00] <matsubara> ok
[19:00] <roaksoax> matsubara: i'll merge it later today
[19:00] <roaksoax> so monday all the autobuilds use the new packaging scheme
[19:00] <matsubara> cool
[19:04] <jtv> Well, that's it from me.  Good luck everyone, and good weekend!
[19:04] <matsubara> you too jtv
[19:04] <jtv> thanks
[19:05] <jtv> zzzz:)
[19:09] <roaksoax> Daviey: ok so sqiuashfs installation is ahead by ~85 seconds
[19:11] <Daviey> roaksoax: total time?
[19:11] <roaksoax> yeah
[19:11] <roaksoax> Daviey: so squaqshfs in my VM ~9.05 seconds
[19:11] <roaksoax> Daviey: without squashfs ~10.30 minutors
[19:11] <roaksoax> Daviey: so squaqshfs in my VM ~9.05 mins
[19:11] <roaksoax> Daviey: without squashfs ~10.30 mins
[19:12] <Daviey> thanks!
[19:12] <roaksoax> wicch means that my SSD has degraded performance by 200%
[19:12] <roaksoax> iit iused to take 5 mins to install
[19:13] <Daviey> hah
=== matsubara is now known as matsubara-afk