|
[10:22] <frankban> hi gmb? |
|
[10:30] <frankban> gmb: if you have time: https://code.launchpad.net/~frankban/lpsetup/steps/+merge/98815 |
|
[10:41] <gmb> frankban, Hi. Sure, I'll take a look in a few minutes |
|
[10:41] <frankban> thanks gmb |
|
[10:51] <frankban> Oh, I almost forgot gmb: approve that code or I will put a random "strong" (in place of "outstanding") in your allhands review ;-) |
|
[10:56] <gmb> Haha. |
|
[10:57] <gmb> It's approved, it's approved! Don't do it! |
|
[11:00] <frankban> :-) thank you gmb |
|
[11:00] <gmb> np. |
|
[11:27] <bac> perhaps we should teach @leankitkanban how to quickly redeploy with juju |
|
[11:28] <gmb> Hah. |
|
[11:28] <gmb> Although if it goes wrong, you wonder how loudly they'd lay into us in a public forum. |
|
[11:50] <bac> gmb: well juju is careful *not* to claim 100% success rate. personally i'd steer clear of any hosting provider that makes such a silly claim. |
|
[11:50] <gmb> Yeah, fair point. |
|
[13:04] <bac> hi frankban, i'm reviewing your lpsetup branch. can you explain the change to the ssh call? you replaced -a with -s. does -s imply -a? |
|
[13:06] <frankban> bac: that fixes a previous commit, -s is the new -a, actions are now called "steps" |
|
[13:07] <bac> frankban: so it has nothing to do with disabling the forwarding agent? |
|
[13:08] <frankban> bac: no |
|
[13:08] <gary_poster> bac benji frankban gmb call in 2 |
|
[13:08] <gary_poster> also, kanban board is back; please update before call if appropriate |
|
[13:09] <frankban> bac: that's just an lpsetup option that was renamed in the previous change |
|
[13:10] <gary_poster> frankban, ping |
|
[13:33] <bac> frankban: how did you do the debian packaging for lpsetup? by hand, pkgme, other? |
|
[13:34] <frankban> bac: by hand, copy/paste, and using dch for the changelog |
|
[13:34] * gmb lunches |
|
[14:38] <gary_poster> frankban, approved objectives. I *think* you should now be able to enter your evaluation. |
|
[14:43] <benji> gary_poster: I'm looking for something to do. Do you know if anyone is working on adding the /dev/random hack to setuplxc |
|
[14:43] <frankban> gary_poster: thanks, I still don't have the self assessment task, but maybe that's because i've set next monday as target. np |
|
[14:43] <gary_poster> benji, frankban was the only one who mentioned it |
|
[14:43] <gary_poster> frankban, yeah, that sounds believable |
|
[14:44] <gary_poster> benji, bac might or might not appreciate someone pairing on the translations thing |
|
[14:45] <gary_poster> I know it's been tricky/annoying |
|
[14:45] <gary_poster> and you are our translations expert ;-) |
|
[14:45] <benji> bac: it looks like a fun bug, I'm interested if there's anything I can do to help |
|
[14:45] <bac> benji is neither tricky nor annoying |
|
[14:45] <benji> gary_poster: it's a sad state |
|
[14:45] <gary_poster> :-) |
|
[14:45] <bac> benji: sure, want to chat in a second? |
|
[14:45] <benji> heh |
|
[14:45] <benji> bac: sure |
|
[14:45] <frankban> benji: I've not started that, so, you can take it if you want |
|
[14:46] * bac -> tea |
|
[14:46] <gary_poster> I suggest that frankban should do the setuplxc thing, and benji help bac |
|
[14:46] <benji> frankban: it looks like I'm going to work with bac first |
|
[14:46] <benji> +1 |
|
[14:46] <gary_poster> assuming that still fits with your schedule frankban |
|
[14:48] <frankban> gary_poster, benji: ok, that should be a fast fix, do you think initialize_host is the good place for the random trick? |
|
[14:48] <gary_poster> yes, frankban |
|
[14:48] <benji> seems so to me |
|
[14:58] <bac> benji: normal hangout? |
|
[14:58] <benji> bac: sure |
|
[16:09] <frankban> gary_poster: 2 mps are ready (random/urandom hack). |
|
[16:09] <frankban> https://code.launchpad.net/~frankban/launchpad/setuplxc-random-trick/+merge/99044 |
|
[16:09] <frankban> https://code.launchpad.net/~frankban/charms/oneiric/buildbot-slave/urandom-script-argument/+merge/99056 |
|
[16:10] <gary_poster> awesome, thanks frankban. I'll look at them now so you can wrap this up... |
|
[16:11] <frankban> thanks |
|
[16:13] <gary_poster> frankban, approved both with no changes. thank you! |
|
[16:15] <frankban> cool gary_poster, I am going to land them |
|
[16:15] <gary_poster> perfect |
|
[19:16] <gmb> gary_poster: Is it okay with you if I take Tuesday off and work Sunday instead? |
|
[19:16] <gary_poster> sure gmb |
|
[19:17] <gmb> gary_poster: Thanks. I'll submit a request in CA now. |
|
[19:17] <gary_poster> cool have a great weekend |
|
[19:17] <gmb> gary_poster: Thanks; likewise. |
|
[19:17] * gmb -> exeunt. |
|
[19:21] <bac> benji: sorry i haven't caught back up with you. i've been doing reviews since lunch. |
|
[19:22] <benji> bac: no worries, I've been plugging away; nothing of interest to report yet. |
|
[20:38] <benji> bac: I have convinced myself that the second half of the asserts in test_splits_and_merges are meaningless; I've removed the guts of the tests and they still pass |
|
[20:39] <benji> I'm still not sure what the root problem is though. |
|
[20:55] <benji> bac: I have it: http://paste.ubuntu.com/896964/ |
|
[21:10] <benji> gary_poster: I don't know why the diff isn't updating, but if you can review https://code.launchpad.net/~benji/launchpad/bug-953913/+merge/99120 (diff at 16:55 < benji:#launchpad-yellow> bac: I have it: http://paste.ubuntu.com/896964/ |
|
[21:10] <benji> oops |
|
[21:10] <gary_poster> :-) |
|
[21:11] <gary_poster> ok benji |
|
[21:11] <benji> gary_poster: I don't know why the diff isn't updating, but if you can review https://code.launchpad.net/~benji/launchpad/bug-953913/+merge/99120 (diff at http://paste.ubuntu.com/896964/) then I can get EC2 crunching over the weekend. |
|
[21:11] <gary_poster> cool |
|
[21:12] <gary_poster> approved benji |
|
[21:12] <benji> gary_poster: thanks |
|
[21:12] <gary_poster> thank you benji. have a great weekend |
|
[21:13] <benji> gary_poster: you too |
|
[21:18] <benji> man, why is this EC2 instance taking so long to start |
|
[21:24] <bac> benji: hey i just saw your diff |
|
[21:25] <benji> bac: it's running though EC2 now. Hopefully it'll work as well there as on my machine. |
|
[21:25] <bac> benji: i don't understand why that fixes things |
|
[21:26] <benji> bac: it provides a constant sort order for sharingKey, the product focus is early in the sharingKey tuple |
|
[21:27] <bac> hmmm, so it was the sort order then |
|
[21:27] <benji> I can't explain why, but aparently variations in sharingKey is the culpret. |
|
[21:27] <bac> i'm *very* glad you figured that out |
|
[21:28] <bac> have a good weekend |
|
|