| === Ursinha is now known as Ursinha-afk | |
| [00:21] <lifeless> bryceh: what was up ? | |
| [00:25] <lifeless> rockstar/thumper: can I get you to look at a small diff for me: 1 liner . | |
| [00:25] <lifeless> http://bazaar.launchpad.net/~lifeless/launchpad/oops/revision/11435 | |
| [00:25] <rockstar> lifeless, ugh, loggerhead. | |
| [00:25] <lifeless> I loaded it for you already , should be fast | |
| [00:25] <rockstar> lifeless, why are we making the timeout bigger? | |
| [00:25] <lifeless> because that number is in milliseconds | |
| [00:25] <lifeless> in a test | |
| [00:26] <rockstar> lifeless, why are you only changing the test? | |
| [00:26] <rockstar> Is this a testfix? | |
| [00:26] <lifeless> for a branch I'm trying to merge | |
| [00:26] <lifeless> what happening is that this test, which is independent of all my changes, is breaking | |
| [00:27] <bryceh> lifeless, mind reviewing https://code.edge.launchpad.net/~bryceharrington/launchpad/lp-617679-db/+merge/34321 when you get a chance? | |
| [00:27] <lifeless> hmm, I might dig deeper | |
| [00:27] <lifeless> rockstar: thanks for asking those questions | |
| [00:27] <lifeless> rockstar: it passes locally | |
| [00:28] <lifeless> rockstar: which is extremely frustrating | |
| [00:28] <rockstar> lifeless, yeah, I suspect there's a timing issue somewhere. | |
| [00:28] <lifeless> what it does | |
| [00:28] <lifeless> is sleeps for 0.1 second while the time taken is < that the soft reques ttimeout | |
| [00:28] <lifeless> the failure is in | |
| [00:29] <lifeless> the report() below - it shows a soft timeout | |
| [00:30] <lifeless> but its expecting a hard timeout not a soft one, presumably because the soft timeout is higher than the hard one | |
| [00:31] <lifeless> rockstar: if its ok with you, I'll try this change | |
| [00:31] <lifeless> rockstar: and if it works chalk it up to terrible-testing-approaches | |
| [00:31] <lifeless> rockstar: if it doesn't I'll dig deep | |
| [00:32] <rockstar> lifeless, I defer to your judgment then. | |
| [00:32] <lifeless> rockstar: thanks! | |
| === Ursinha-afk is now known as Ursinha | |
| === Ursinha is now known as Ursinha-afk | |
| === Ursinha-afk is now known as Ursinha | |
| === Ursinha is now known as Ursinha-zzz | |
| [06:34] <lifeless> https://code.edge.launchpad.net/~lifeless/launchpad/bug-618372/+merge/34383 | |
| === lifeless changed the topic of #launchpad-reviews to: On Call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [06:34] <lifeless> ^ that branch is a 2 liner; if anyone wants to eyeball it | |
| [06:38] <mwhudson> lifeless: done | |
| [06:50] <lifeless> thanks | |
| [06:50] <lifeless> I have another | |
| [06:50] <lifeless> but I'll do that after dinner | |
| === henninge_ is now known as henninge | |
| === danilo_ is now known as danilos | |
| === noodles775 changed the topic of #launchpad-reviews to: On Call: noodles775 || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [12:12] <bac> hi noodles775, i have a MP for review: https://code.edge.launchpad.net/~bac/launchpad/bug-154587/+merge/34401 . i need to go away for a bit to eat breakfast, though. | |
| [13:01] <jtv> noodles775, would you mind this one on your queue while I'm already EOD? https://code.launchpad.net/~jtv/launchpad/recife-diverge/+merge/34407 | |
| [13:12] <noodles775> bac, jtv: sure | |
| [13:12] <jtv> noodles775: fantastic, thanks | |
| === noodles775 changed the topic of #launchpad-reviews to: On Call: noodles775 || reviewing: bac || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [13:13] <wgrant> noodles775: https://code.edge.launchpad.net/~wgrant/launchpad/ppa-key-name/+merge/34408, if you have a few minutes. | |
| [13:14] <noodles775> wgrant: oooh, nice easy one :) | |
| [13:15] <wgrant> Indeed. | |
| [13:19] <noodles775> wgrant: approved and ec2 landing. | |
| [13:20] <wgrant> noodles775: Thanks. | |
| [13:21] <StevenK> I still maintain that wgrant should use ec2 test. :-P | |
| [13:21] <noodles775> With a paid-for account? | |
| [13:21] <wgrant> StevenK: I can use it... it just can't land. | |
| [13:22] <wgrant> noodles775: And it wasn't really formally reviewed before. | |
| [13:22] <StevenK> wgrant: 'ec2 test' | |
| [13:22] <noodles775> wgrant: I know, I still treated it as if unreviewed :) | |
| [13:23] <wgrant> StevenK: Hmmm? | |
| [13:24] <StevenK> wgrant: 'ec2 test' runs the tests and mails you the results, 'ec2 land' runs the tests, and lands it if the tests passed | |
| [13:25] <wgrant> StevenK: Yes, but there's not much point me running ec2 test. | |
| [13:25] <StevenK> wgrant: IE, you can quite happily run 'ec2 test' and then ask someone to submit it to PQM, but meh | |
| [13:25] <wgrant> People generally won't. | |
| [13:29] <StevenK> wgrant: It isn't fair when you respond to my teasing with rationale. | |
| [13:29] <wgrant> :( | |
| === Ursinha-zzz is now known as Ursinha | |
| === kiko` is now known as kiko | |
| === noodles775 changed the topic of #launchpad-reviews to: On Call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [15:07] <leonardr> salgado, take a look at http://pastebin.ubuntu.com/487261/ and hopefully we can wrap up this branch | |
| [15:08] <salgado> leonardr, looks fine to me | |
| === matsubara is now known as matsubara-lunch | |
| === rockstar changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [16:19] <EdwinGrubbs> deryck: can you do a ui review of my branch modifying bugs.lp.net/$project/+index? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-597738-bug-service-status/+merge/34250 | |
| [16:20] <deryck> EdwinGrubbs, yes, was just about to look at in fact. However, I'm not a UI reviewer or UI reviewer mentee. | |
| === Ursinha is now known as Ursinha-lunch | |
| [16:22] <EdwinGrubbs> deryck: oh, I misread the reviewer wiki page. If you're interested, I'm open to feedback, but don't feel like I'm waiting on you for the review. | |
| [16:23] <EdwinGrubbs> noodles775, rockstar: can one of you do a UI review for me? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-597738-bug-service-status/+merge/34250 | |
| [16:23] <rockstar> EdwinGrubbs, I'll take a look. | |
| [16:23] <EdwinGrubbs> thanks | |
| [16:23] <deryck> EdwinGrubbs, I'll just glance at the page since it's bugs related | |
| [16:23] <deryck> and leave ui to rockstar :-) | |
| [16:24] <noodles775> Thanks rockstar. Might be worth seeing if henninge wants a first look too (although he's probably EODing soon like me). | |
| [16:24] <rockstar> Oh, I thought he would have EOD'd. | |
| [16:24] <henninge> rockstar: I can have a look. | |
| [16:24] <rockstar> henninge, oh yay! Yeah, take a look. | |
| [16:28] <rockstar> EdwinGrubbs, what? No screenshot?! :) | |
| [16:28] <henninge> Yes, I am a bit disappointed myself ... ;) | |
| [16:29] * henninge just branched | |
| [16:30] <henninge> rocketfuel-get ... | |
| === salgado is now known as salgado-lunch | |
| [17:00] <allenap> rockstar: Could you review a snippet for me please? It's a workaround for bug 628762 so I can get lp:~allenap/launchpad/cache-experiment-roll-out landed. http://paste.ubuntu.com/487315/ | |
| [17:00] <_mup_> Bug #628762: propertycache adaption failures in test suite <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/628762> | |
| [17:01] <allenap> rockstar: The merge proposal for the whole branch is at https://code.edge.launchpad.net/~allenap/launchpad/cache-experiment-roll-out/+merge/33542 | |
| [17:02] <rockstar> allenap, I suspect I need to look at the whole branch. | |
| [17:04] <allenap> rockstar: The whole branch is pretty huge; there are a lot of mechanical changes. I think you'll be able to understand it if you look at propertycache.py, propertycache.txt and bug 628762. | |
| [17:04] <_mup_> Bug #628762: propertycache adaption failures in test suite <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/628762> | |
| === benji is now known as benji-lunch | |
| [17:04] <rockstar> allenap, I'd be happier of you had lifeless review that. | |
| [17:04] <allenap> rockstar: Okay. | |
| [17:05] <allenap> rockstar: Can I put myself in the queue for a couple of tarmac branches then? One, lp:~allenap/tarmac/votes-needed-plugin, is for the benefit of Landscape (though it's generally useful), and the other is just a clean up. | |
| [17:07] <rockstar> allenap, I'm happy to take some Tarmac branches, yes. | |
| [17:07] <allenap> rockstar: Cool, thanks. | |
| === allenap changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: - || queue: [allenap, allenap] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| === jcsackett changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: - || queue: [allenap, allenap, jcsackett] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [17:26] <jcsackett> rockstar: when you're able to get to it, here's the MP. https://code.edge.launchpad.net/~jcsackett/launchpad/deprecate-remaining-official-bools/+merge/34436 | |
| [17:29] <henninge> rockstar: done | |
| [17:29] <henninge> *now* I am EOD | |
| [17:29] <rockstar> henninge, have a good night! | |
| [17:29] <henninge> thanks ;) | |
| [17:31] <rockstar> jcsackett, it looks like your branch has conflicts. | |
| [17:31] <jcsackett> rockstar: blast, you're right, i forgot to merge in devel. | |
| [17:31] <jcsackett> one sec, sorry for the bother. | |
| === Ursinha-lunch is now known as Ursinha | |
| === matsubara-lunch is now known as matsubara | |
| [17:40] <jcsackett> rockstar: should be pushed up momentarily. | |
| [17:44] <rockstar> allenap, didn't you already have a thing class? | |
| === salgado-lunch is now known as salgado | |
| === benji-lunch is now known as benji | |
| === deryck is now known as deryck[lunch] | |
| === rockstar changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: jcsackett || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [18:49] <abentley> rockstar, could you please review https://code.launchpad.net/~abentley/launchpad/recipe-interfaces/+merge/34453 ? | |
| === abentley changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: jcsackett || queue: [abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [19:02] <abentley> rockstar, could you please review https://code.launchpad.net/~abentley/launchpad/permit-commands/+merge/34456 ? | |
| === abentley changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: jcsackett || queue: [abentley, abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| === deryck[lunch] is now known as deryck | |
| [20:03] <rockstar> abentley, on it. | |
| [20:11] <abentley> rockstar, could you please review https://code.edge.launchpad.net/~abentley/launchpad/safe-v3/+merge/34465 ? | |
| [20:11] <rockstar> abentley, add it to the backlog and I'll get to it. | |
| === abentley changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: jcsackett || queue: [abentley, abentley, abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [20:48] <leonardr> salgado, take a wild guess what's in this diff: http://pastebin.ubuntu.com/487423/ | |
| [20:50] <rockstar> abentley, these branches were all pipes, correct? | |
| [20:52] <salgado> leonardr, heh. seems fine to me | |
| [20:53] <abentley> rockstar, yes, but not all the same pipeline. The last one is in a pipeline with the build-outside-chroot one. | |
| [20:56] <rockstar> abentley, yeah, I think there might have been a hiccup in setting a dependent branch somewhere. | |
| [20:56] <abentley> rockstar, something wrong? | |
| [20:56] <rockstar> Was permit commands related to the recipe-interfaces pipe? | |
| [20:56] <abentley> rockstar, yes. | |
| [20:57] <rockstar> abentley, I think the dependent branch didn't get set right on permit-commands | |
| [21:00] <abentley> rockstar, I think you're right. | |
| [21:00] <rockstar> abentley, it would be great if you could fix it. | |
| === rockstar changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [21:01] <abentley> rockstar, I can't fix it without creating a new merge proposal. | |
| [21:01] <rockstar> abentley, would you mind? I assume this diff is much smaller that way. | |
| [21:03] <abentley> rockstar, ah. I thought you'd already reviewed that one. sure. | |
| [21:06] <abentley> rockstar, corrected version: https://code.edge.launchpad.net/~abentley/launchpad/permit-commands/+merge/34476 | |
| [21:09] <rockstar> abentley, thanks | |
| === abentley_ is now known as abentley | |
| [21:17] <abentley> rockstar, could you please review https://code.edge.launchpad.net/~abentley/launchpad/allow-0.3/+merge/34478 ? | |
| [21:18] <rockstar> abentley, you're an ANIMAL! | |
| === abentley changed the topic of #launchpad-reviews to: On Call: rockstar || reviewing: abentley || queue: [abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| [21:18] <abentley> rockstar, they're all small. | |
| [21:24] <jcsackett> rockstar: branch was updated per your remarks. | |
| [21:24] <rockstar> jcsackett, great, I'll take a look. | |
| [21:24] <jcsackett> thanks. | |
| === matsubara is now known as matsubara-afk | |
| === rockstar changed the topic of #launchpad-reviews to: On Call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.launchpad.net/launchpad/+activereviews | |
| === salgado is now known as salgado-afk | |
| [23:50] <thumper> mwhudson: feel like a review? | |
| [23:50] <thumper> mwhudson: it is a codehosting type xmlrpc one | |
| [23:50] <thumper> just your cuppa tea | |