| {"language": "Python", "id": 38, "repo_owner": "beetbox", "repo_name": "beets", "head_branch": "master", "workflow_name": "Check code formatting", "workflow_filename": "formatting_check.yml", "workflow_path": ".github/workflows/formatting_check.yml", "contributor": "niacdoial", "sha_fail": "0d26cc1482ff5080ec579b17b29f22657a20c562", "sha_success": "828c6e7dbd1a1fe77b4b7be61aa2e3d220ff86d1", "workflow": "name: formatting_check\nrun-name: Check code formatting\non: [push, pull_request]\njobs:\n formatting_check:\n runs-on: ubuntu-latest\n steps:\n - name: Install dependencies\n uses: actions/checkout@v3\n\n - name: Run formatting check\n uses: paolorechia/pox@v1.0.1\n with:\n tox_env: \"format_check\"\n", "logs": [{"step_name": "formatting_check/3_Run formatting check.txt", "log": "##[group]Run paolorechia/pox@v1.0.1\nwith:\n tox_env: format_check\n##[endgroup]\nstdout: Defaulting to user installation because normal site-packages is not writeable\n\nstdout: Collecting tox\n\nstdout: Downloading tox-4.11.4-py3-none-any.whl (153 kB)\n\nstdout: \u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501 154.0/154.0 KB 4.1 MB/s eta 0:00:00\nstdout: \n\nstdout: Requirement already satisfied: platformdirs>=3.10 in /usr/local/lib/python3.10/dist-packages (from tox) (4.1.0)\n\nstdout: Collecting pluggy>=1.3\n\nstdout: Downloading pluggy-1.3.0-py3-none-any.whl (18 kB)\n\nstdout: Collecting virtualenv>=20.24.3\n\nstdout: Downloading virtualenv-20.25.0-py3-none-any.whl (3.8 MB)\n\nstdout: \u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501 3.8/3.8 MB 12.0 MB/s eta 0:00:00\nstdout: \n\nstdout: Collecting cachetools>=5.3.1\n\nstdout: Downloading cachetools-5.3.2-py3-none-any.whl (9.3 kB)\n\nstdout: Requirement already satisfied: packaging>=23.1 in /usr/local/lib/python3.10/dist-packages (from tox) (23.2)\n\nstdout: Requirement already satisfied: tomli>=2.0.1 in /usr/local/lib/python3.10/dist-packages (from tox) (2.0.1)\n\nstdout: Collecting filelock>=3.12.3\n\nstdout: Downloading filelock-3.13.1-py3-none-any.whl (11 kB)\n\nstdout: Collecting colorama>=0.4.6\n\nstdout: Downloading colorama-0.4.6-py2.py3-none-any.whl (25 kB)\n\nstdout: Collecting pyproject-api>=1.6.1\n\nstdout: Downloading pyproject_api-1.6.1-py3-none-any.whl (12 kB)\n\nstdout: Collecting chardet>=5.2\n\nstdout: Downloading chardet-5.2.0-py3-none-any.whl (199 kB)\n\nstdout: \u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501 199.4/199.4 KB 21.1 MB/s eta 0:00:00\nstdout: \n\nstdout: Collecting distlib<1,>=0.3.7\n\nstdout: Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)\n\nstdout: \u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501\u2501 468.9/468.9 KB 15.4 MB/s eta 0:00:00\nstdout: \n\nstdout: Installing collected packages: distlib, pyproject-api, pluggy, filelock, colorama, chardet, cachetools, virtualenv, tox\n\nstdout: Successfully installed cachetools-5.3.2 chardet-5.2.0 colorama-0.4.6 distlib-0.3.8 filelock-3.13.1 pluggy-1.3.0 pyproject-api-1.6.1 tox-4.11.4 virtualenv-20.25.0\n\nReceived 6565789 of 6565789 (100.0%), 18.9 MBs/sec\nCache Size: ~6 MB (6565789 B)\n[command]/usr/bin/tar -z -xf /home/runner/work/_temp/d6197f94-ef69-4efe-9ad2-cb7265f9e34d/cache.tgz -P -C /home/runner/work/beets/beets\nCache restored successfully\nHit cache on tox\nstdout: format_check: recreate env because python changed virtualenv version='20.24.5'->'20.25.0'\n\nstdout: format_check: remove tox env folder /home/runner/work/beets/beets/.tox/format_check\n\nstdout: format_check: install_deps> python -I -m pip install black isort\n\nstdout: format_check: commands[0]> isort beets beetsplug test --check\n\nstderr: ERROR: /home/runner/work/beets/beets/beetsplug/edit.py Imports are incorrectly sorted and/or formatted.\n\nstdout: format_check: exit 1 (0.54 seconds) /home/runner/work/beets/beets> isort beets beetsplug test --check pid=1759\n\nstdout: format_check: FAIL code 1 (3.49=setup[2.95]+cmd[0.54] seconds)\n evaluation failed :( (3.64 seconds)\n\nchild process exited with code 1\n##[warning]The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/\n##[error]Tox failed\n"}], "diff": "diff --git a/beetsplug/advancedrewrite.py b/beetsplug/advancedrewrite.py\nindex 639aa5247..20f2b7e03 100644\n--- a/beetsplug/advancedrewrite.py\n+++ b/beetsplug/advancedrewrite.py\n@@ -161,7 +161,7 @@ class AdvancedRewritePlugin(BeetsPlugin):\n )\n elif isinstance(replacement, str):\n if Item._fields[fieldname] is MULTI_VALUE_DSV:\n- replacement = list(replacement)\n+ replacement = [replacement]\n else:\n raise UserError(\n f\"Invalid type of replacement {replacement} \"\ndiff --git a/beetsplug/edit.py b/beetsplug/edit.py\nindex 8a07fccaa..323dd9e41 100644\n--- a/beetsplug/edit.py\n+++ b/beetsplug/edit.py\n@@ -23,7 +23,7 @@ from tempfile import NamedTemporaryFile\n \n import yaml\n \n-from beets import plugins, ui, util, config\n+from beets import plugins, ui, util\n from beets.dbcore import types\n from beets.importer import action\n from beets.ui.commands import PromptChoice, _do_query\n@@ -155,8 +155,6 @@ class EditPlugin(plugins.BeetsPlugin):\n }\n )\n \n- self.has_shown_ui = False\n-\n self.register_listener(\n \"before_choose_candidate\", self.before_choose_candidate_listener\n )\n@@ -238,23 +236,11 @@ class EditPlugin(plugins.BeetsPlugin):\n # Get the content to edit as raw data structures.\n old_data = [flatten(o, fields) for o in objs]\n \n- # take set fields into account\n- set_fields = config[\"import\"][\"set_fields\"]\n- if set_fields and not self.has_shown_ui:\n- old_str = \"\\n\\n# note: the following fields will be reset to their current values:\\n\"\n- for key in set_fields:\n- old_str += f\"# - {key}\\n\"\n- for obj in old_data:\n- # those values will be enforced later anyway\n- obj.update({k:v.get() for k,v in set_fields.items()})\n- else:\n- old_str = \"\"\n-\n # Set up a temporary file with the initial data for editing.\n new = NamedTemporaryFile(\n mode=\"w\", suffix=\".yaml\", delete=False, encoding=\"utf-8\"\n )\n- old_str = dump(old_data) + old_str\n+ old_str = dump(old_data)\n new.write(old_str)\n new.close()\n \n@@ -263,7 +249,6 @@ class EditPlugin(plugins.BeetsPlugin):\n while True:\n # Ask the user to edit the data.\n edit(new.name, self._log)\n- self.has_shown_ui = True\n \n # Read the data back after editing and check whether anything\n # changed.\ndiff --git a/beetsplug/web/__init__.py b/beetsplug/web/__init__.py\nindex cebb0be0a..cd7e8a3fc 100644\n--- a/beetsplug/web/__init__.py\n+++ b/beetsplug/web/__init__.py\n@@ -336,7 +336,6 @@ def item_file(item_id):\n response = flask.send_file(\n item_path, as_attachment=True, download_name=safe_filename\n )\n- response.headers[\"Content-Length\"] = os.path.getsize(item_path)\n return response\n \n \ndiff --git a/docs/changelog.rst b/docs/changelog.rst\nindex 73cc10f3d..b3b63f1c2 100644\n--- a/docs/changelog.rst\n+++ b/docs/changelog.rst\n@@ -279,6 +279,8 @@ Bug fixes:\n :bug:`4973`\n * Fix bug regarding displaying tracks that have been changed not being\n displayed unless the detail configuration is enabled.\n+* :doc:`/plugins/web`: Fix range request support, allowing to play large audio/\n+ opus files using e.g. a browser/firefox or gstreamer/mopidy directly.\n \n For plugin developers:\n \n", "difficulty": 0, "changed_files": ["beetsplug/advancedrewrite.py", "beetsplug/edit.py", "beetsplug/web/__init__.py", "docs/changelog.rst"], "commit_link": "https://github.com/beetbox/beets/tree/0d26cc1482ff5080ec579b17b29f22657a20c562"} |