|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
"""Does google-lint on c++ files. |
|
|
|
The goal of this script is to identify places in the code that *may* |
|
be in non-compliance with google style. It does not attempt to fix |
|
up these problems -- the point is to educate. It does also not |
|
attempt to find all problems, or to ensure that everything it does |
|
find is legitimately a problem. |
|
|
|
In particular, we can get very confused by /* and // inside strings! |
|
We do a small hack, which is to ignore //'s with "'s after them on the |
|
same line, but it is far from perfect (in either direction). |
|
""" |
|
|
|
import codecs |
|
import copy |
|
import getopt |
|
import math |
|
import os |
|
import re |
|
import sre_compile |
|
import string |
|
import sys |
|
import unicodedata |
|
|
|
import six |
|
|
|
from six import iteritems, itervalues |
|
from six.moves import xrange |
|
|
|
_USAGE = """ |
|
Syntax: cpp_lint.py [--verbose=#] [--output=vs7] [--filter=-x,+y,...] |
|
[--counting=total|toplevel|detailed] [--root=subdir] |
|
[--linelength=digits] |
|
<file> [file] ... |
|
|
|
The style guidelines this tries to follow are those in |
|
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml |
|
|
|
Every problem is given a confidence score from 1-5, with 5 meaning we are |
|
certain of the problem, and 1 meaning it could be a legitimate construct. |
|
This will miss some errors, and is not a substitute for a code review. |
|
|
|
To suppress false-positive errors of a certain category, add a |
|
'NOLINT(category)' comment to the line. NOLINT or NOLINT(*) |
|
suppresses errors of all categories on that line. |
|
|
|
The files passed in will be linted; at least one file must be provided. |
|
Default linted extensions are .cc, .cpp, .cu, .cuh and .h. Change the |
|
extensions with the --extensions flag. |
|
|
|
Flags: |
|
|
|
output=vs7 |
|
By default, the output is formatted to ease emacs parsing. Visual Studio |
|
compatible output (vs7) may also be used. Other formats are unsupported. |
|
|
|
verbose=# |
|
Specify a number 0-5 to restrict errors to certain verbosity levels. |
|
|
|
filter=-x,+y,... |
|
Specify a comma-separated list of category-filters to apply: only |
|
error messages whose category names pass the filters will be printed. |
|
(Category names are printed with the message and look like |
|
"[whitespace/indent]".) Filters are evaluated left to right. |
|
"-FOO" and "FOO" means "do not print categories that start with FOO". |
|
"+FOO" means "do print categories that start with FOO". |
|
|
|
Examples: --filter=-whitespace,+whitespace/braces |
|
--filter=whitespace,runtime/printf,+runtime/printf_format |
|
--filter=-,+build/include_what_you_use |
|
|
|
To see a list of all the categories used in cpplint, pass no arg: |
|
--filter= |
|
|
|
counting=total|toplevel|detailed |
|
The total number of errors found is always printed. If |
|
'toplevel' is provided, then the count of errors in each of |
|
the top-level categories like 'build' and 'whitespace' will |
|
also be printed. If 'detailed' is provided, then a count |
|
is provided for each category like 'build/class'. |
|
|
|
root=subdir |
|
The root directory used for deriving header guard CPP variable. |
|
By default, the header guard CPP variable is calculated as the relative |
|
path to the directory that contains .git, .hg, or .svn. When this flag |
|
is specified, the relative path is calculated from the specified |
|
directory. If the specified directory does not exist, this flag is |
|
ignored. |
|
|
|
Examples: |
|
Assuing that src/.git exists, the header guard CPP variables for |
|
src/chrome/browser/ui/browser.h are: |
|
|
|
No flag => CHROME_BROWSER_UI_BROWSER_H_ |
|
--root=chrome => BROWSER_UI_BROWSER_H_ |
|
--root=chrome/browser => UI_BROWSER_H_ |
|
|
|
linelength=digits |
|
This is the allowed line length for the project. The default value is |
|
80 characters. |
|
|
|
Examples: |
|
--linelength=120 |
|
|
|
extensions=extension,extension,... |
|
The allowed file extensions that cpplint will check |
|
|
|
Examples: |
|
--extensions=hpp,cpp |
|
""" |
|
|
|
|
|
|
|
|
|
|
|
_ERROR_CATEGORIES = [ |
|
'build/class', |
|
'build/deprecated', |
|
'build/endif_comment', |
|
'build/explicit_make_pair', |
|
'build/forward_decl', |
|
'build/header_guard', |
|
'build/include', |
|
'build/include_alpha', |
|
'build/include_dir', |
|
'build/include_order', |
|
'build/include_what_you_use', |
|
'build/namespaces', |
|
'build/printf_format', |
|
'build/storage_class', |
|
'caffe/alt_fn', |
|
'caffe/data_layer_setup', |
|
'caffe/random_fn', |
|
'legal/copyright', |
|
'readability/alt_tokens', |
|
'readability/braces', |
|
'readability/casting', |
|
'readability/check', |
|
'readability/constructors', |
|
'readability/fn_size', |
|
'readability/function', |
|
'readability/multiline_comment', |
|
'readability/multiline_string', |
|
'readability/namespace', |
|
'readability/nolint', |
|
'readability/nul', |
|
'readability/streams', |
|
'readability/todo', |
|
'readability/utf8', |
|
'runtime/arrays', |
|
'runtime/casting', |
|
'runtime/explicit', |
|
'runtime/int', |
|
'runtime/init', |
|
'runtime/invalid_increment', |
|
'runtime/member_string_references', |
|
'runtime/memset', |
|
'runtime/operator', |
|
'runtime/printf', |
|
'runtime/printf_format', |
|
'runtime/references', |
|
'runtime/string', |
|
'runtime/threadsafe_fn', |
|
'runtime/vlog', |
|
'whitespace/blank_line', |
|
'whitespace/braces', |
|
'whitespace/comma', |
|
'whitespace/comments', |
|
'whitespace/empty_conditional_body', |
|
'whitespace/empty_loop_body', |
|
'whitespace/end_of_line', |
|
'whitespace/ending_newline', |
|
'whitespace/forcolon', |
|
'whitespace/indent', |
|
'whitespace/line_length', |
|
'whitespace/newline', |
|
'whitespace/operators', |
|
'whitespace/parens', |
|
'whitespace/semicolon', |
|
'whitespace/tab', |
|
'whitespace/todo' |
|
] |
|
|
|
|
|
|
|
|
|
|
|
_DEFAULT_FILTERS = [ |
|
'-build/include_dir', |
|
'-readability/todo', |
|
] |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
_CPP_HEADERS = frozenset([ |
|
|
|
'algobase.h', |
|
'algo.h', |
|
'alloc.h', |
|
'builtinbuf.h', |
|
'bvector.h', |
|
'complex.h', |
|
'defalloc.h', |
|
'deque.h', |
|
'editbuf.h', |
|
'fstream.h', |
|
'function.h', |
|
'hash_map', |
|
'hash_map.h', |
|
'hash_set', |
|
'hash_set.h', |
|
'hashtable.h', |
|
'heap.h', |
|
'indstream.h', |
|
'iomanip.h', |
|
'iostream.h', |
|
'istream.h', |
|
'iterator.h', |
|
'list.h', |
|
'map.h', |
|
'multimap.h', |
|
'multiset.h', |
|
'ostream.h', |
|
'pair.h', |
|
'parsestream.h', |
|
'pfstream.h', |
|
'procbuf.h', |
|
'pthread_alloc', |
|
'pthread_alloc.h', |
|
'rope', |
|
'rope.h', |
|
'ropeimpl.h', |
|
'set.h', |
|
'slist', |
|
'slist.h', |
|
'stack.h', |
|
'stdiostream.h', |
|
'stl_alloc.h', |
|
'stl_relops.h', |
|
'streambuf.h', |
|
'stream.h', |
|
'strfile.h', |
|
'strstream.h', |
|
'tempbuf.h', |
|
'tree.h', |
|
'type_traits.h', |
|
'vector.h', |
|
|
|
'algorithm', |
|
'array', |
|
'atomic', |
|
'bitset', |
|
'chrono', |
|
'codecvt', |
|
'complex', |
|
'condition_variable', |
|
'deque', |
|
'exception', |
|
'forward_list', |
|
'fstream', |
|
'functional', |
|
'future', |
|
'initializer_list', |
|
'iomanip', |
|
'ios', |
|
'iosfwd', |
|
'iostream', |
|
'istream', |
|
'iterator', |
|
'limits', |
|
'list', |
|
'locale', |
|
'map', |
|
'memory', |
|
'mutex', |
|
'new', |
|
'numeric', |
|
'ostream', |
|
'queue', |
|
'random', |
|
'ratio', |
|
'regex', |
|
'set', |
|
'sstream', |
|
'stack', |
|
'stdexcept', |
|
'streambuf', |
|
'string', |
|
'strstream', |
|
'system_error', |
|
'thread', |
|
'tuple', |
|
'typeindex', |
|
'typeinfo', |
|
'type_traits', |
|
'unordered_map', |
|
'unordered_set', |
|
'utility', |
|
'valarray', |
|
'vector', |
|
|
|
'cassert', |
|
'ccomplex', |
|
'cctype', |
|
'cerrno', |
|
'cfenv', |
|
'cfloat', |
|
'cinttypes', |
|
'ciso646', |
|
'climits', |
|
'clocale', |
|
'cmath', |
|
'csetjmp', |
|
'csignal', |
|
'cstdalign', |
|
'cstdarg', |
|
'cstdbool', |
|
'cstddef', |
|
'cstdint', |
|
'cstdio', |
|
'cstdlib', |
|
'cstring', |
|
'ctgmath', |
|
'ctime', |
|
'cuchar', |
|
'cwchar', |
|
'cwctype', |
|
]) |
|
|
|
|
|
|
|
|
|
_CHECK_MACROS = [ |
|
'DCHECK', 'CHECK', |
|
'EXPECT_TRUE_M', 'EXPECT_TRUE', |
|
'ASSERT_TRUE_M', 'ASSERT_TRUE', |
|
'EXPECT_FALSE_M', 'EXPECT_FALSE', |
|
'ASSERT_FALSE_M', 'ASSERT_FALSE', |
|
] |
|
|
|
|
|
_CHECK_REPLACEMENT = dict([(m, {}) for m in _CHECK_MACROS]) |
|
|
|
for op, replacement in [('==', 'EQ'), ('!=', 'NE'), |
|
('>=', 'GE'), ('>', 'GT'), |
|
('<=', 'LE'), ('<', 'LT')]: |
|
_CHECK_REPLACEMENT['DCHECK'][op] = 'DCHECK_%s' % replacement |
|
_CHECK_REPLACEMENT['CHECK'][op] = 'CHECK_%s' % replacement |
|
_CHECK_REPLACEMENT['EXPECT_TRUE'][op] = 'EXPECT_%s' % replacement |
|
_CHECK_REPLACEMENT['ASSERT_TRUE'][op] = 'ASSERT_%s' % replacement |
|
_CHECK_REPLACEMENT['EXPECT_TRUE_M'][op] = 'EXPECT_%s_M' % replacement |
|
_CHECK_REPLACEMENT['ASSERT_TRUE_M'][op] = 'ASSERT_%s_M' % replacement |
|
|
|
for op, inv_replacement in [('==', 'NE'), ('!=', 'EQ'), |
|
('>=', 'LT'), ('>', 'LE'), |
|
('<=', 'GT'), ('<', 'GE')]: |
|
_CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement |
|
_CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement |
|
_CHECK_REPLACEMENT['EXPECT_FALSE_M'][op] = 'EXPECT_%s_M' % inv_replacement |
|
_CHECK_REPLACEMENT['ASSERT_FALSE_M'][op] = 'ASSERT_%s_M' % inv_replacement |
|
|
|
|
|
|
|
|
|
|
|
|
|
_ALT_TOKEN_REPLACEMENT = { |
|
'and': '&&', |
|
'bitor': '|', |
|
'or': '||', |
|
'xor': '^', |
|
'compl': '~', |
|
'bitand': '&', |
|
'and_eq': '&=', |
|
'or_eq': '|=', |
|
'xor_eq': '^=', |
|
'not': '!', |
|
'not_eq': '!=' |
|
} |
|
|
|
|
|
|
|
|
|
|
|
|
|
_ALT_TOKEN_REPLACEMENT_PATTERN = re.compile( |
|
r'[ =()](' + ('|'.join(_ALT_TOKEN_REPLACEMENT.keys())) + r')(?=[ (]|$)') |
|
|
|
|
|
|
|
|
|
_C_SYS_HEADER = 1 |
|
_CPP_SYS_HEADER = 2 |
|
_LIKELY_MY_HEADER = 3 |
|
_POSSIBLE_MY_HEADER = 4 |
|
_OTHER_HEADER = 5 |
|
|
|
|
|
_NO_ASM = 0 |
|
_INSIDE_ASM = 1 |
|
_END_ASM = 2 |
|
_BLOCK_ASM = 3 |
|
|
|
|
|
_MATCH_ASM = re.compile(r'^\s*(?:asm|_asm|__asm|__asm__)' |
|
r'(?:\s+(volatile|__volatile__))?' |
|
r'\s*[{(]') |
|
|
|
|
|
_regexp_compile_cache = {} |
|
|
|
|
|
_RE_SUPPRESSION = re.compile(r'\bNOLINT(_NEXT_LINE)?\b(\([^)]*\))?') |
|
|
|
|
|
|
|
_error_suppressions = {} |
|
|
|
|
|
_RE_COPYRIGHT = re.compile(r'Copyright') |
|
|
|
|
|
|
|
_root = None |
|
|
|
|
|
|
|
_line_length = 80 |
|
|
|
|
|
|
|
_valid_extensions = set(['cc', 'h', 'cpp', 'hpp', 'cu', 'cuh']) |
|
|
|
def ParseNolintSuppressions(filename, raw_line, linenum, error): |
|
"""Updates the global list of error-suppressions. |
|
|
|
Parses any NOLINT comments on the current line, updating the global |
|
error_suppressions store. Reports an error if the NOLINT comment |
|
was malformed. |
|
|
|
Args: |
|
filename: str, the name of the input file. |
|
raw_line: str, the line of input text, with comments. |
|
linenum: int, the number of the current line. |
|
error: function, an error handler. |
|
""" |
|
|
|
matched = _RE_SUPPRESSION.search(raw_line) |
|
if matched: |
|
if matched.group(1) == '_NEXT_LINE': |
|
linenum += 1 |
|
category = matched.group(2) |
|
if category in (None, '(*)'): |
|
_error_suppressions.setdefault(None, set()).add(linenum) |
|
else: |
|
if category.startswith('(') and category.endswith(')'): |
|
category = category[1:-1] |
|
if category in _ERROR_CATEGORIES: |
|
_error_suppressions.setdefault(category, set()).add(linenum) |
|
else: |
|
error(filename, linenum, 'readability/nolint', 5, |
|
'Unknown NOLINT error category: %s' % category) |
|
|
|
|
|
def ResetNolintSuppressions(): |
|
"Resets the set of NOLINT suppressions to empty." |
|
_error_suppressions.clear() |
|
|
|
|
|
def IsErrorSuppressedByNolint(category, linenum): |
|
"""Returns true if the specified error category is suppressed on this line. |
|
|
|
Consults the global error_suppressions map populated by |
|
ParseNolintSuppressions/ResetNolintSuppressions. |
|
|
|
Args: |
|
category: str, the category of the error. |
|
linenum: int, the current line number. |
|
Returns: |
|
bool, True iff the error should be suppressed due to a NOLINT comment. |
|
""" |
|
return (linenum in _error_suppressions.get(category, set()) or |
|
linenum in _error_suppressions.get(None, set())) |
|
|
|
def Match(pattern, s): |
|
"""Matches the string with the pattern, caching the compiled regexp.""" |
|
|
|
|
|
|
|
if pattern not in _regexp_compile_cache: |
|
_regexp_compile_cache[pattern] = sre_compile.compile(pattern) |
|
return _regexp_compile_cache[pattern].match(s) |
|
|
|
|
|
def ReplaceAll(pattern, rep, s): |
|
"""Replaces instances of pattern in a string with a replacement. |
|
|
|
The compiled regex is kept in a cache shared by Match and Search. |
|
|
|
Args: |
|
pattern: regex pattern |
|
rep: replacement text |
|
s: search string |
|
|
|
Returns: |
|
string with replacements made (or original string if no replacements) |
|
""" |
|
if pattern not in _regexp_compile_cache: |
|
_regexp_compile_cache[pattern] = sre_compile.compile(pattern) |
|
return _regexp_compile_cache[pattern].sub(rep, s) |
|
|
|
|
|
def Search(pattern, s): |
|
"""Searches the string for the pattern, caching the compiled regexp.""" |
|
if pattern not in _regexp_compile_cache: |
|
_regexp_compile_cache[pattern] = sre_compile.compile(pattern) |
|
return _regexp_compile_cache[pattern].search(s) |
|
|
|
|
|
class _IncludeState(dict): |
|
"""Tracks line numbers for includes, and the order in which includes appear. |
|
|
|
As a dict, an _IncludeState object serves as a mapping between include |
|
filename and line number on which that file was included. |
|
|
|
Call CheckNextIncludeOrder() once for each header in the file, passing |
|
in the type constants defined above. Calls in an illegal order will |
|
raise an _IncludeError with an appropriate error message. |
|
|
|
""" |
|
|
|
|
|
_INITIAL_SECTION = 0 |
|
_MY_H_SECTION = 1 |
|
_C_SECTION = 2 |
|
_CPP_SECTION = 3 |
|
_OTHER_H_SECTION = 4 |
|
|
|
_TYPE_NAMES = { |
|
_C_SYS_HEADER: 'C system header', |
|
_CPP_SYS_HEADER: 'C++ system header', |
|
_LIKELY_MY_HEADER: 'header this file implements', |
|
_POSSIBLE_MY_HEADER: 'header this file may implement', |
|
_OTHER_HEADER: 'other header', |
|
} |
|
_SECTION_NAMES = { |
|
_INITIAL_SECTION: "... nothing. (This can't be an error.)", |
|
_MY_H_SECTION: 'a header this file implements', |
|
_C_SECTION: 'C system header', |
|
_CPP_SECTION: 'C++ system header', |
|
_OTHER_H_SECTION: 'other header', |
|
} |
|
|
|
def __init__(self): |
|
dict.__init__(self) |
|
self.ResetSection() |
|
|
|
def ResetSection(self): |
|
|
|
self._section = self._INITIAL_SECTION |
|
|
|
self._last_header = '' |
|
|
|
def SetLastHeader(self, header_path): |
|
self._last_header = header_path |
|
|
|
def CanonicalizeAlphabeticalOrder(self, header_path): |
|
"""Returns a path canonicalized for alphabetical comparison. |
|
|
|
- replaces "-" with "_" so they both cmp the same. |
|
- removes '-inl' since we don't require them to be after the main header. |
|
- lowercase everything, just in case. |
|
|
|
Args: |
|
header_path: Path to be canonicalized. |
|
|
|
Returns: |
|
Canonicalized path. |
|
""" |
|
return header_path.replace('-inl.h', '.h').replace('-', '_').lower() |
|
|
|
def IsInAlphabeticalOrder(self, clean_lines, linenum, header_path): |
|
"""Check if a header is in alphabetical order with the previous header. |
|
|
|
Args: |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
header_path: Canonicalized header to be checked. |
|
|
|
Returns: |
|
Returns true if the header is in alphabetical order. |
|
""" |
|
|
|
|
|
|
|
|
|
|
|
if (self._last_header > header_path and |
|
not Match(r'^\s*$', clean_lines.elided[linenum - 1])): |
|
return False |
|
return True |
|
|
|
def CheckNextIncludeOrder(self, header_type): |
|
"""Returns a non-empty error message if the next header is out of order. |
|
|
|
This function also updates the internal state to be ready to check |
|
the next include. |
|
|
|
Args: |
|
header_type: One of the _XXX_HEADER constants defined above. |
|
|
|
Returns: |
|
The empty string if the header is in the right order, or an |
|
error message describing what's wrong. |
|
|
|
""" |
|
error_message = ('Found %s after %s' % |
|
(self._TYPE_NAMES[header_type], |
|
self._SECTION_NAMES[self._section])) |
|
|
|
last_section = self._section |
|
|
|
if header_type == _C_SYS_HEADER: |
|
if self._section <= self._C_SECTION: |
|
self._section = self._C_SECTION |
|
else: |
|
self._last_header = '' |
|
return error_message |
|
elif header_type == _CPP_SYS_HEADER: |
|
if self._section <= self._CPP_SECTION: |
|
self._section = self._CPP_SECTION |
|
else: |
|
self._last_header = '' |
|
return error_message |
|
elif header_type == _LIKELY_MY_HEADER: |
|
if self._section <= self._MY_H_SECTION: |
|
self._section = self._MY_H_SECTION |
|
else: |
|
self._section = self._OTHER_H_SECTION |
|
elif header_type == _POSSIBLE_MY_HEADER: |
|
if self._section <= self._MY_H_SECTION: |
|
self._section = self._MY_H_SECTION |
|
else: |
|
|
|
|
|
self._section = self._OTHER_H_SECTION |
|
else: |
|
assert header_type == _OTHER_HEADER |
|
self._section = self._OTHER_H_SECTION |
|
|
|
if last_section != self._section: |
|
self._last_header = '' |
|
|
|
return '' |
|
|
|
|
|
class _CppLintState(object): |
|
"""Maintains module-wide state..""" |
|
|
|
def __init__(self): |
|
self.verbose_level = 1 |
|
self.error_count = 0 |
|
|
|
self.filters = _DEFAULT_FILTERS[:] |
|
self.counting = 'total' |
|
self.errors_by_category = {} |
|
|
|
|
|
|
|
|
|
self.output_format = 'emacs' |
|
|
|
def SetOutputFormat(self, output_format): |
|
"""Sets the output format for errors.""" |
|
self.output_format = output_format |
|
|
|
def SetVerboseLevel(self, level): |
|
"""Sets the module's verbosity, and returns the previous setting.""" |
|
last_verbose_level = self.verbose_level |
|
self.verbose_level = level |
|
return last_verbose_level |
|
|
|
def SetCountingStyle(self, counting_style): |
|
"""Sets the module's counting options.""" |
|
self.counting = counting_style |
|
|
|
def SetFilters(self, filters): |
|
"""Sets the error-message filters. |
|
|
|
These filters are applied when deciding whether to emit a given |
|
error message. |
|
|
|
Args: |
|
filters: A string of comma-separated filters (eg "+whitespace/indent"). |
|
Each filter should start with + or -; else we die. |
|
|
|
Raises: |
|
ValueError: The comma-separated filters did not all start with '+' or '-'. |
|
E.g. "-,+whitespace,-whitespace/indent,whitespace/badfilter" |
|
""" |
|
|
|
self.filters = _DEFAULT_FILTERS[:] |
|
for filt in filters.split(','): |
|
clean_filt = filt.strip() |
|
if clean_filt: |
|
self.filters.append(clean_filt) |
|
for filt in self.filters: |
|
if not (filt.startswith('+') or filt.startswith('-')): |
|
raise ValueError('Every filter in --filters must start with + or -' |
|
' (%s does not)' % filt) |
|
|
|
def ResetErrorCounts(self): |
|
"""Sets the module's error statistic back to zero.""" |
|
self.error_count = 0 |
|
self.errors_by_category = {} |
|
|
|
def IncrementErrorCount(self, category): |
|
"""Bumps the module's error statistic.""" |
|
self.error_count += 1 |
|
if self.counting in ('toplevel', 'detailed'): |
|
if self.counting != 'detailed': |
|
category = category.split('/')[0] |
|
if category not in self.errors_by_category: |
|
self.errors_by_category[category] = 0 |
|
self.errors_by_category[category] += 1 |
|
|
|
def PrintErrorCounts(self): |
|
"""Print a summary of errors by category, and the total.""" |
|
for category, count in iteritems(self.errors_by_category): |
|
sys.stderr.write('Category \'%s\' errors found: %d\n' % |
|
(category, count)) |
|
sys.stderr.write('Total errors found: %d\n' % self.error_count) |
|
|
|
_cpplint_state = _CppLintState() |
|
|
|
|
|
def _OutputFormat(): |
|
"""Gets the module's output format.""" |
|
return _cpplint_state.output_format |
|
|
|
|
|
def _SetOutputFormat(output_format): |
|
"""Sets the module's output format.""" |
|
_cpplint_state.SetOutputFormat(output_format) |
|
|
|
|
|
def _VerboseLevel(): |
|
"""Returns the module's verbosity setting.""" |
|
return _cpplint_state.verbose_level |
|
|
|
|
|
def _SetVerboseLevel(level): |
|
"""Sets the module's verbosity, and returns the previous setting.""" |
|
return _cpplint_state.SetVerboseLevel(level) |
|
|
|
|
|
def _SetCountingStyle(level): |
|
"""Sets the module's counting options.""" |
|
_cpplint_state.SetCountingStyle(level) |
|
|
|
|
|
def _Filters(): |
|
"""Returns the module's list of output filters, as a list.""" |
|
return _cpplint_state.filters |
|
|
|
|
|
def _SetFilters(filters): |
|
"""Sets the module's error-message filters. |
|
|
|
These filters are applied when deciding whether to emit a given |
|
error message. |
|
|
|
Args: |
|
filters: A string of comma-separated filters (eg "whitespace/indent"). |
|
Each filter should start with + or -; else we die. |
|
""" |
|
_cpplint_state.SetFilters(filters) |
|
|
|
|
|
class _FunctionState(object): |
|
"""Tracks current function name and the number of lines in its body.""" |
|
|
|
_NORMAL_TRIGGER = 250 |
|
_TEST_TRIGGER = 400 |
|
|
|
def __init__(self): |
|
self.in_a_function = False |
|
self.lines_in_function = 0 |
|
self.current_function = '' |
|
|
|
def Begin(self, function_name): |
|
"""Start analyzing function body. |
|
|
|
Args: |
|
function_name: The name of the function being tracked. |
|
""" |
|
self.in_a_function = True |
|
self.lines_in_function = 0 |
|
self.current_function = function_name |
|
|
|
def Count(self): |
|
"""Count line in current function body.""" |
|
if self.in_a_function: |
|
self.lines_in_function += 1 |
|
|
|
def Check(self, error, filename, linenum): |
|
"""Report if too many lines in function body. |
|
|
|
Args: |
|
error: The function to call with any errors found. |
|
filename: The name of the current file. |
|
linenum: The number of the line to check. |
|
""" |
|
if Match(r'T(EST|est)', self.current_function): |
|
base_trigger = self._TEST_TRIGGER |
|
else: |
|
base_trigger = self._NORMAL_TRIGGER |
|
trigger = base_trigger * 2**_VerboseLevel() |
|
|
|
if self.lines_in_function > trigger: |
|
error_level = int(math.log(self.lines_in_function / base_trigger, 2)) |
|
|
|
if error_level > 5: |
|
error_level = 5 |
|
error(filename, linenum, 'readability/fn_size', error_level, |
|
'Small and focused functions are preferred:' |
|
' %s has %d non-comment lines' |
|
' (error triggered by exceeding %d lines).' % ( |
|
self.current_function, self.lines_in_function, trigger)) |
|
|
|
def End(self): |
|
"""Stop analyzing function body.""" |
|
self.in_a_function = False |
|
|
|
|
|
class _IncludeError(Exception): |
|
"""Indicates a problem with the include order in a file.""" |
|
pass |
|
|
|
|
|
class FileInfo: |
|
"""Provides utility functions for filenames. |
|
|
|
FileInfo provides easy access to the components of a file's path |
|
relative to the project root. |
|
""" |
|
|
|
def __init__(self, filename): |
|
self._filename = filename |
|
|
|
def FullName(self): |
|
"""Make Windows paths like Unix.""" |
|
return os.path.abspath(self._filename).replace('\\', '/') |
|
|
|
def RepositoryName(self): |
|
"""FullName after removing the local path to the repository. |
|
|
|
If we have a real absolute path name here we can try to do something smart: |
|
detecting the root of the checkout and truncating /path/to/checkout from |
|
the name so that we get header guards that don't include things like |
|
"C:\Documents and Settings\..." or "/home/username/..." in them and thus |
|
people on different computers who have checked the source out to different |
|
locations won't see bogus errors. |
|
""" |
|
fullname = self.FullName() |
|
|
|
if os.path.exists(fullname): |
|
project_dir = os.path.dirname(fullname) |
|
|
|
if os.path.exists(os.path.join(project_dir, ".svn")): |
|
|
|
|
|
root_dir = project_dir |
|
one_up_dir = os.path.dirname(root_dir) |
|
while os.path.exists(os.path.join(one_up_dir, ".svn")): |
|
root_dir = os.path.dirname(root_dir) |
|
one_up_dir = os.path.dirname(one_up_dir) |
|
|
|
prefix = os.path.commonprefix([root_dir, project_dir]) |
|
return fullname[len(prefix) + 1:] |
|
|
|
|
|
|
|
root_dir = os.path.dirname(fullname) |
|
while (root_dir != os.path.dirname(root_dir) and |
|
not os.path.exists(os.path.join(root_dir, ".git")) and |
|
not os.path.exists(os.path.join(root_dir, ".hg")) and |
|
not os.path.exists(os.path.join(root_dir, ".svn"))): |
|
root_dir = os.path.dirname(root_dir) |
|
|
|
if (os.path.exists(os.path.join(root_dir, ".git")) or |
|
os.path.exists(os.path.join(root_dir, ".hg")) or |
|
os.path.exists(os.path.join(root_dir, ".svn"))): |
|
prefix = os.path.commonprefix([root_dir, project_dir]) |
|
return fullname[len(prefix) + 1:] |
|
|
|
|
|
return fullname |
|
|
|
def Split(self): |
|
"""Splits the file into the directory, basename, and extension. |
|
|
|
For 'chrome/browser/browser.cc', Split() would |
|
return ('chrome/browser', 'browser', '.cc') |
|
|
|
Returns: |
|
A tuple of (directory, basename, extension). |
|
""" |
|
|
|
googlename = self.RepositoryName() |
|
project, rest = os.path.split(googlename) |
|
return (project,) + os.path.splitext(rest) |
|
|
|
def BaseName(self): |
|
"""File base name - text after the final slash, before the final period.""" |
|
return self.Split()[1] |
|
|
|
def Extension(self): |
|
"""File extension - text following the final period.""" |
|
return self.Split()[2] |
|
|
|
def NoExtension(self): |
|
"""File has no source file extension.""" |
|
return '/'.join(self.Split()[0:2]) |
|
|
|
def IsSource(self): |
|
"""File has a source file extension.""" |
|
return self.Extension()[1:] in ('c', 'cc', 'cpp', 'cxx') |
|
|
|
|
|
def _ShouldPrintError(category, confidence, linenum): |
|
"""If confidence >= verbose, category passes filter and is not suppressed.""" |
|
|
|
|
|
|
|
|
|
if IsErrorSuppressedByNolint(category, linenum): |
|
return False |
|
if confidence < _cpplint_state.verbose_level: |
|
return False |
|
|
|
is_filtered = False |
|
for one_filter in _Filters(): |
|
if one_filter.startswith('-'): |
|
if category.startswith(one_filter[1:]): |
|
is_filtered = True |
|
elif one_filter.startswith('+'): |
|
if category.startswith(one_filter[1:]): |
|
is_filtered = False |
|
else: |
|
assert False |
|
if is_filtered: |
|
return False |
|
|
|
return True |
|
|
|
|
|
def Error(filename, linenum, category, confidence, message): |
|
"""Logs the fact we've found a lint error. |
|
|
|
We log where the error was found, and also our confidence in the error, |
|
that is, how certain we are this is a legitimate style regression, and |
|
not a misidentification or a use that's sometimes justified. |
|
|
|
False positives can be suppressed by the use of |
|
"cpplint(category)" comments on the offending line. These are |
|
parsed into _error_suppressions. |
|
|
|
Args: |
|
filename: The name of the file containing the error. |
|
linenum: The number of the line containing the error. |
|
category: A string used to describe the "category" this bug |
|
falls under: "whitespace", say, or "runtime". Categories |
|
may have a hierarchy separated by slashes: "whitespace/indent". |
|
confidence: A number from 1-5 representing a confidence score for |
|
the error, with 5 meaning that we are certain of the problem, |
|
and 1 meaning that it could be a legitimate construct. |
|
message: The error message. |
|
""" |
|
if _ShouldPrintError(category, confidence, linenum): |
|
_cpplint_state.IncrementErrorCount(category) |
|
if _cpplint_state.output_format == 'vs7': |
|
sys.stderr.write('%s(%s): %s [%s] [%d]\n' % ( |
|
filename, linenum, message, category, confidence)) |
|
elif _cpplint_state.output_format == 'eclipse': |
|
sys.stderr.write('%s:%s: warning: %s [%s] [%d]\n' % ( |
|
filename, linenum, message, category, confidence)) |
|
else: |
|
sys.stderr.write('%s:%s: %s [%s] [%d]\n' % ( |
|
filename, linenum, message, category, confidence)) |
|
|
|
|
|
|
|
_RE_PATTERN_CLEANSE_LINE_ESCAPES = re.compile( |
|
r'\\([abfnrtv?"\\\']|\d+|x[0-9a-fA-F]+)') |
|
|
|
_RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES = re.compile(r'"[^"]*"') |
|
|
|
_RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES = re.compile(r"'.'") |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
_RE_PATTERN_CLEANSE_LINE_C_COMMENTS = re.compile( |
|
r"""(\s*/\*.*\*/\s*$| |
|
/\*.*\*/\s+| |
|
\s+/\*.*\*/(?=\W)| |
|
/\*.*\*/)""", re.VERBOSE) |
|
|
|
|
|
def IsCppString(line): |
|
"""Does line terminate so, that the next symbol is in string constant. |
|
|
|
This function does not consider single-line nor multi-line comments. |
|
|
|
Args: |
|
line: is a partial line of code starting from the 0..n. |
|
|
|
Returns: |
|
True, if next character appended to 'line' is inside a |
|
string constant. |
|
""" |
|
|
|
line = line.replace(r'\\', 'XX') |
|
return ((line.count('"') - line.count(r'\"') - line.count("'\"'")) & 1) == 1 |
|
|
|
|
|
def CleanseRawStrings(raw_lines): |
|
"""Removes C++11 raw strings from lines. |
|
|
|
Before: |
|
static const char kData[] = R"( |
|
multi-line string |
|
)"; |
|
|
|
After: |
|
static const char kData[] = "" |
|
(replaced by blank line) |
|
""; |
|
|
|
Args: |
|
raw_lines: list of raw lines. |
|
|
|
Returns: |
|
list of lines with C++11 raw strings replaced by empty strings. |
|
""" |
|
|
|
delimiter = None |
|
lines_without_raw_strings = [] |
|
for line in raw_lines: |
|
if delimiter: |
|
|
|
end = line.find(delimiter) |
|
if end >= 0: |
|
|
|
|
|
|
|
leading_space = Match(r'^(\s*)\S', line) |
|
line = leading_space.group(1) + '""' + line[end + len(delimiter):] |
|
delimiter = None |
|
else: |
|
|
|
line = '' |
|
|
|
else: |
|
|
|
|
|
matched = Match(r'^(.*)\b(?:R|u8R|uR|UR|LR)"([^\s\\()]*)\((.*)$', line) |
|
if matched: |
|
delimiter = ')' + matched.group(2) + '"' |
|
|
|
end = matched.group(3).find(delimiter) |
|
if end >= 0: |
|
|
|
line = (matched.group(1) + '""' + |
|
matched.group(3)[end + len(delimiter):]) |
|
delimiter = None |
|
else: |
|
|
|
line = matched.group(1) + '""' |
|
|
|
lines_without_raw_strings.append(line) |
|
|
|
|
|
|
|
return lines_without_raw_strings |
|
|
|
|
|
def FindNextMultiLineCommentStart(lines, lineix): |
|
"""Find the beginning marker for a multiline comment.""" |
|
while lineix < len(lines): |
|
if lines[lineix].strip().startswith('/*'): |
|
|
|
if lines[lineix].strip().find('*/', 2) < 0: |
|
return lineix |
|
lineix += 1 |
|
return len(lines) |
|
|
|
|
|
def FindNextMultiLineCommentEnd(lines, lineix): |
|
"""We are inside a comment, find the end marker.""" |
|
while lineix < len(lines): |
|
if lines[lineix].strip().endswith('*/'): |
|
return lineix |
|
lineix += 1 |
|
return len(lines) |
|
|
|
|
|
def RemoveMultiLineCommentsFromRange(lines, begin, end): |
|
"""Clears a range of lines for multi-line comments.""" |
|
|
|
|
|
for i in range(begin, end): |
|
lines[i] = '// dummy' |
|
|
|
|
|
def RemoveMultiLineComments(filename, lines, error): |
|
"""Removes multiline (c-style) comments from lines.""" |
|
lineix = 0 |
|
while lineix < len(lines): |
|
lineix_begin = FindNextMultiLineCommentStart(lines, lineix) |
|
if lineix_begin >= len(lines): |
|
return |
|
lineix_end = FindNextMultiLineCommentEnd(lines, lineix_begin) |
|
if lineix_end >= len(lines): |
|
error(filename, lineix_begin + 1, 'readability/multiline_comment', 5, |
|
'Could not find end of multi-line comment') |
|
return |
|
RemoveMultiLineCommentsFromRange(lines, lineix_begin, lineix_end + 1) |
|
lineix = lineix_end + 1 |
|
|
|
|
|
def CleanseComments(line): |
|
"""Removes //-comments and single-line C-style /* */ comments. |
|
|
|
Args: |
|
line: A line of C++ source. |
|
|
|
Returns: |
|
The line with single-line comments removed. |
|
""" |
|
commentpos = line.find('//') |
|
if commentpos != -1 and not IsCppString(line[:commentpos]): |
|
line = line[:commentpos].rstrip() |
|
|
|
return _RE_PATTERN_CLEANSE_LINE_C_COMMENTS.sub('', line) |
|
|
|
|
|
class CleansedLines(object): |
|
"""Holds 3 copies of all lines with different preprocessing applied to them. |
|
|
|
1) elided member contains lines without strings and comments, |
|
2) lines member contains lines without comments, and |
|
3) raw_lines member contains all the lines without processing. |
|
All these three members are of <type 'list'>, and of the same length. |
|
""" |
|
|
|
def __init__(self, lines): |
|
self.elided = [] |
|
self.lines = [] |
|
self.raw_lines = lines |
|
self.num_lines = len(lines) |
|
self.lines_without_raw_strings = CleanseRawStrings(lines) |
|
for linenum in range(len(self.lines_without_raw_strings)): |
|
self.lines.append(CleanseComments( |
|
self.lines_without_raw_strings[linenum])) |
|
elided = self._CollapseStrings(self.lines_without_raw_strings[linenum]) |
|
self.elided.append(CleanseComments(elided)) |
|
|
|
def NumLines(self): |
|
"""Returns the number of lines represented.""" |
|
return self.num_lines |
|
|
|
@staticmethod |
|
def _CollapseStrings(elided): |
|
"""Collapses strings and chars on a line to simple "" or '' blocks. |
|
|
|
We nix strings first so we're not fooled by text like '"http://"' |
|
|
|
Args: |
|
elided: The line being processed. |
|
|
|
Returns: |
|
The line with collapsed strings. |
|
""" |
|
if not _RE_PATTERN_INCLUDE.match(elided): |
|
|
|
|
|
|
|
elided = _RE_PATTERN_CLEANSE_LINE_ESCAPES.sub('', elided) |
|
elided = _RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES.sub("''", elided) |
|
elided = _RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES.sub('""', elided) |
|
return elided |
|
|
|
|
|
def FindEndOfExpressionInLine(line, startpos, depth, startchar, endchar): |
|
"""Find the position just after the matching endchar. |
|
|
|
Args: |
|
line: a CleansedLines line. |
|
startpos: start searching at this position. |
|
depth: nesting level at startpos. |
|
startchar: expression opening character. |
|
endchar: expression closing character. |
|
|
|
Returns: |
|
On finding matching endchar: (index just after matching endchar, 0) |
|
Otherwise: (-1, new depth at end of this line) |
|
""" |
|
for i in xrange(startpos, len(line)): |
|
if line[i] == startchar: |
|
depth += 1 |
|
elif line[i] == endchar: |
|
depth -= 1 |
|
if depth == 0: |
|
return (i + 1, 0) |
|
return (-1, depth) |
|
|
|
|
|
def CloseExpression(clean_lines, linenum, pos): |
|
"""If input points to ( or { or [ or <, finds the position that closes it. |
|
|
|
If lines[linenum][pos] points to a '(' or '{' or '[' or '<', finds the |
|
linenum/pos that correspond to the closing of the expression. |
|
|
|
Args: |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
pos: A position on the line. |
|
|
|
Returns: |
|
A tuple (line, linenum, pos) pointer *past* the closing brace, or |
|
(line, len(lines), -1) if we never find a close. Note we ignore |
|
strings and comments when matching; and the line we return is the |
|
'cleansed' line at linenum. |
|
""" |
|
|
|
line = clean_lines.elided[linenum] |
|
startchar = line[pos] |
|
if startchar not in '({[<': |
|
return (line, clean_lines.NumLines(), -1) |
|
if startchar == '(': endchar = ')' |
|
if startchar == '[': endchar = ']' |
|
if startchar == '{': endchar = '}' |
|
if startchar == '<': endchar = '>' |
|
|
|
|
|
(end_pos, num_open) = FindEndOfExpressionInLine( |
|
line, pos, 0, startchar, endchar) |
|
if end_pos > -1: |
|
return (line, linenum, end_pos) |
|
|
|
|
|
while linenum < clean_lines.NumLines() - 1: |
|
linenum += 1 |
|
line = clean_lines.elided[linenum] |
|
(end_pos, num_open) = FindEndOfExpressionInLine( |
|
line, 0, num_open, startchar, endchar) |
|
if end_pos > -1: |
|
return (line, linenum, end_pos) |
|
|
|
|
|
return (line, clean_lines.NumLines(), -1) |
|
|
|
|
|
def FindStartOfExpressionInLine(line, endpos, depth, startchar, endchar): |
|
"""Find position at the matching startchar. |
|
|
|
This is almost the reverse of FindEndOfExpressionInLine, but note |
|
that the input position and returned position differs by 1. |
|
|
|
Args: |
|
line: a CleansedLines line. |
|
endpos: start searching at this position. |
|
depth: nesting level at endpos. |
|
startchar: expression opening character. |
|
endchar: expression closing character. |
|
|
|
Returns: |
|
On finding matching startchar: (index at matching startchar, 0) |
|
Otherwise: (-1, new depth at beginning of this line) |
|
""" |
|
for i in xrange(endpos, -1, -1): |
|
if line[i] == endchar: |
|
depth += 1 |
|
elif line[i] == startchar: |
|
depth -= 1 |
|
if depth == 0: |
|
return (i, 0) |
|
return (-1, depth) |
|
|
|
|
|
def ReverseCloseExpression(clean_lines, linenum, pos): |
|
"""If input points to ) or } or ] or >, finds the position that opens it. |
|
|
|
If lines[linenum][pos] points to a ')' or '}' or ']' or '>', finds the |
|
linenum/pos that correspond to the opening of the expression. |
|
|
|
Args: |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
pos: A position on the line. |
|
|
|
Returns: |
|
A tuple (line, linenum, pos) pointer *at* the opening brace, or |
|
(line, 0, -1) if we never find the matching opening brace. Note |
|
we ignore strings and comments when matching; and the line we |
|
return is the 'cleansed' line at linenum. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
endchar = line[pos] |
|
if endchar not in ')}]>': |
|
return (line, 0, -1) |
|
if endchar == ')': startchar = '(' |
|
if endchar == ']': startchar = '[' |
|
if endchar == '}': startchar = '{' |
|
if endchar == '>': startchar = '<' |
|
|
|
|
|
(start_pos, num_open) = FindStartOfExpressionInLine( |
|
line, pos, 0, startchar, endchar) |
|
if start_pos > -1: |
|
return (line, linenum, start_pos) |
|
|
|
|
|
while linenum > 0: |
|
linenum -= 1 |
|
line = clean_lines.elided[linenum] |
|
(start_pos, num_open) = FindStartOfExpressionInLine( |
|
line, len(line) - 1, num_open, startchar, endchar) |
|
if start_pos > -1: |
|
return (line, linenum, start_pos) |
|
|
|
|
|
return (line, 0, -1) |
|
|
|
|
|
def CheckForCopyright(filename, lines, error): |
|
"""Logs an error if a Copyright message appears at the top of the file.""" |
|
|
|
|
|
|
|
for line in xrange(1, min(len(lines), 11)): |
|
if _RE_COPYRIGHT.search(lines[line], re.I): |
|
error(filename, 0, 'legal/copyright', 5, |
|
'Copyright message found. ' |
|
'You should not include a copyright line.') |
|
|
|
|
|
def GetHeaderGuardCPPVariable(filename): |
|
"""Returns the CPP variable that should be used as a header guard. |
|
|
|
Args: |
|
filename: The name of a C++ header file. |
|
|
|
Returns: |
|
The CPP variable that should be used as a header guard in the |
|
named file. |
|
|
|
""" |
|
|
|
|
|
|
|
filename = re.sub(r'_flymake\.h$', '.h', filename) |
|
filename = re.sub(r'/\.flymake/([^/]*)$', r'/\1', filename) |
|
|
|
fileinfo = FileInfo(filename) |
|
file_path_from_root = fileinfo.RepositoryName() |
|
if _root: |
|
file_path_from_root = re.sub('^' + _root + os.sep, '', file_path_from_root) |
|
return re.sub(r'[-./\s]', '_', file_path_from_root).upper() + '_' |
|
|
|
|
|
def CheckForHeaderGuard(filename, lines, error): |
|
"""Checks that the file contains a header guard. |
|
|
|
Logs an error if no #ifndef header guard is present. For other |
|
headers, checks that the full pathname is used. |
|
|
|
Args: |
|
filename: The name of the C++ header file. |
|
lines: An array of strings, each representing a line of the file. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
cppvar = GetHeaderGuardCPPVariable(filename) |
|
|
|
ifndef = None |
|
ifndef_linenum = 0 |
|
define = None |
|
endif = None |
|
endif_linenum = 0 |
|
for linenum, line in enumerate(lines): |
|
linesplit = line.split() |
|
if len(linesplit) >= 2: |
|
|
|
if not ifndef and linesplit[0] == '#ifndef': |
|
|
|
ifndef = linesplit[1] |
|
ifndef_linenum = linenum |
|
if not define and linesplit[0] == '#define': |
|
define = linesplit[1] |
|
|
|
if line.startswith('#endif'): |
|
endif = line |
|
endif_linenum = linenum |
|
|
|
if not ifndef: |
|
error(filename, 0, 'build/header_guard', 5, |
|
'No #ifndef header guard found, suggested CPP variable is: %s' % |
|
cppvar) |
|
return |
|
|
|
if not define: |
|
error(filename, 0, 'build/header_guard', 5, |
|
'No #define header guard found, suggested CPP variable is: %s' % |
|
cppvar) |
|
return |
|
|
|
|
|
|
|
if ifndef != cppvar: |
|
error_level = 0 |
|
if ifndef != cppvar + '_': |
|
error_level = 5 |
|
|
|
ParseNolintSuppressions(filename, lines[ifndef_linenum], ifndef_linenum, |
|
error) |
|
error(filename, ifndef_linenum, 'build/header_guard', error_level, |
|
'#ifndef header guard has wrong style, please use: %s' % cppvar) |
|
|
|
if define != ifndef: |
|
error(filename, 0, 'build/header_guard', 5, |
|
'#ifndef and #define don\'t match, suggested CPP variable is: %s' % |
|
cppvar) |
|
return |
|
|
|
if endif != ('#endif // %s' % cppvar): |
|
error_level = 0 |
|
if endif != ('#endif // %s' % (cppvar + '_')): |
|
error_level = 5 |
|
|
|
ParseNolintSuppressions(filename, lines[endif_linenum], endif_linenum, |
|
error) |
|
error(filename, endif_linenum, 'build/header_guard', error_level, |
|
'#endif line should be "#endif // %s"' % cppvar) |
|
|
|
|
|
def CheckForBadCharacters(filename, lines, error): |
|
"""Logs an error for each line containing bad characters. |
|
|
|
Two kinds of bad characters: |
|
|
|
1. Unicode replacement characters: These indicate that either the file |
|
contained invalid UTF-8 (likely) or Unicode replacement characters (which |
|
it shouldn't). Note that it's possible for this to throw off line |
|
numbering if the invalid UTF-8 occurred adjacent to a newline. |
|
|
|
2. NUL bytes. These are problematic for some tools. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
lines: An array of strings, each representing a line of the file. |
|
error: The function to call with any errors found. |
|
""" |
|
for linenum, line in enumerate(lines): |
|
if u'\ufffd' in line: |
|
error(filename, linenum, 'readability/utf8', 5, |
|
'Line contains invalid UTF-8 (or Unicode replacement character).') |
|
if '\0' in line: |
|
error(filename, linenum, 'readability/nul', 5, 'Line contains NUL byte.') |
|
|
|
|
|
def CheckForNewlineAtEOF(filename, lines, error): |
|
"""Logs an error if there is no newline char at the end of the file. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
lines: An array of strings, each representing a line of the file. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
|
|
|
|
|
|
if len(lines) < 3 or lines[-2]: |
|
error(filename, len(lines) - 2, 'whitespace/ending_newline', 5, |
|
'Could not find a newline character at the end of the file.') |
|
|
|
|
|
def CheckForMultilineCommentsAndStrings(filename, clean_lines, linenum, error): |
|
"""Logs an error if we see /* ... */ or "..." that extend past one line. |
|
|
|
/* ... */ comments are legit inside macros, for one line. |
|
Otherwise, we prefer // comments, so it's ok to warn about the |
|
other. Likewise, it's ok for strings to extend across multiple |
|
lines, as long as a line continuation character (backslash) |
|
terminates each line. Although not currently prohibited by the C++ |
|
style guide, it's ugly and unnecessary. We don't do well with either |
|
in this lint program, so we warn about both. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
|
|
|
|
|
|
line = line.replace('\\\\', '') |
|
|
|
if line.count('/*') > line.count('*/'): |
|
error(filename, linenum, 'readability/multiline_comment', 5, |
|
'Complex multi-line /*...*/-style comment found. ' |
|
'Lint may give bogus warnings. ' |
|
'Consider replacing these with //-style comments, ' |
|
'with #if 0...#endif, ' |
|
'or with more clearly structured multi-line comments.') |
|
|
|
if (line.count('"') - line.count('\\"')) % 2: |
|
error(filename, linenum, 'readability/multiline_string', 5, |
|
'Multi-line string ("...") found. This lint script doesn\'t ' |
|
'do well with such strings, and may give bogus warnings. ' |
|
'Use C++11 raw strings or concatenation instead.') |
|
|
|
|
|
caffe_alt_function_list = ( |
|
('memset', ['caffe_set', 'caffe_memset']), |
|
('cudaMemset', ['caffe_gpu_set', 'caffe_gpu_memset']), |
|
('memcpy', ['caffe_copy']), |
|
('cudaMemcpy', ['caffe_copy', 'caffe_gpu_memcpy']), |
|
) |
|
|
|
|
|
def CheckCaffeAlternatives(filename, clean_lines, linenum, error): |
|
"""Checks for C(++) functions for which a Caffe substitute should be used. |
|
|
|
For certain native C functions (memset, memcpy), there is a Caffe alternative |
|
which should be used instead. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
for function, alts in caffe_alt_function_list: |
|
ix = line.find(function + '(') |
|
if ix >= 0 and (ix == 0 or (not line[ix - 1].isalnum() and |
|
line[ix - 1] not in ('_', '.', '>'))): |
|
disp_alts = ['%s(...)' % alt for alt in alts] |
|
error(filename, linenum, 'caffe/alt_fn', 2, |
|
'Use Caffe function %s instead of %s(...).' % |
|
(' or '.join(disp_alts), function)) |
|
|
|
|
|
def CheckCaffeDataLayerSetUp(filename, clean_lines, linenum, error): |
|
"""Except the base classes, Caffe DataLayer should define DataLayerSetUp |
|
instead of LayerSetUp. |
|
|
|
The base DataLayers define common SetUp steps, the subclasses should |
|
not override them. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
ix = line.find('DataLayer<Dtype>::LayerSetUp') |
|
if ix >= 0 and ( |
|
line.find('void DataLayer<Dtype>::LayerSetUp') != -1 or |
|
line.find('void ImageDataLayer<Dtype>::LayerSetUp') != -1 or |
|
line.find('void MemoryDataLayer<Dtype>::LayerSetUp') != -1 or |
|
line.find('void WindowDataLayer<Dtype>::LayerSetUp') != -1): |
|
error(filename, linenum, 'caffe/data_layer_setup', 2, |
|
'Except the base classes, Caffe DataLayer should define' |
|
+ ' DataLayerSetUp instead of LayerSetUp. The base DataLayers' |
|
+ ' define common SetUp steps, the subclasses should' |
|
+ ' not override them.') |
|
ix = line.find('DataLayer<Dtype>::DataLayerSetUp') |
|
if ix >= 0 and ( |
|
line.find('void Base') == -1 and |
|
line.find('void DataLayer<Dtype>::DataLayerSetUp') == -1 and |
|
line.find('void ImageDataLayer<Dtype>::DataLayerSetUp') == -1 and |
|
line.find('void MemoryDataLayer<Dtype>::DataLayerSetUp') == -1 and |
|
line.find('void WindowDataLayer<Dtype>::DataLayerSetUp') == -1): |
|
error(filename, linenum, 'caffe/data_layer_setup', 2, |
|
'Except the base classes, Caffe DataLayer should define' |
|
+ ' DataLayerSetUp instead of LayerSetUp. The base DataLayers' |
|
+ ' define common SetUp steps, the subclasses should' |
|
+ ' not override them.') |
|
|
|
|
|
c_random_function_list = ( |
|
'rand(', |
|
'rand_r(', |
|
'random(', |
|
) |
|
|
|
def CheckCaffeRandom(filename, clean_lines, linenum, error): |
|
"""Checks for calls to C random functions (rand, rand_r, random, ...). |
|
|
|
Caffe code should (almost) always use the caffe_rng_* functions rather |
|
than these, as the internal state of these C functions is independent of the |
|
native Caffe RNG system which should produce deterministic results for a |
|
fixed Caffe seed set using Caffe::set_random_seed(...). |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
for function in c_random_function_list: |
|
ix = line.find(function) |
|
|
|
if ix >= 0 and (ix == 0 or (not line[ix - 1].isalnum() and |
|
line[ix - 1] not in ('_', '.', '>'))): |
|
error(filename, linenum, 'caffe/random_fn', 2, |
|
'Use caffe_rng_rand() (or other caffe_rng_* function) instead of ' |
|
+ function + |
|
') to ensure results are deterministic for a fixed Caffe seed.') |
|
|
|
|
|
threading_list = ( |
|
('asctime(', 'asctime_r('), |
|
('ctime(', 'ctime_r('), |
|
('getgrgid(', 'getgrgid_r('), |
|
('getgrnam(', 'getgrnam_r('), |
|
('getlogin(', 'getlogin_r('), |
|
('getpwnam(', 'getpwnam_r('), |
|
('getpwuid(', 'getpwuid_r('), |
|
('gmtime(', 'gmtime_r('), |
|
('localtime(', 'localtime_r('), |
|
('strtok(', 'strtok_r('), |
|
('ttyname(', 'ttyname_r('), |
|
) |
|
|
|
|
|
def CheckPosixThreading(filename, clean_lines, linenum, error): |
|
"""Checks for calls to thread-unsafe functions. |
|
|
|
Much code has been originally written without consideration of |
|
multi-threading. Also, engineers are relying on their old experience; |
|
they have learned posix before threading extensions were added. These |
|
tests guide the engineers to use thread-safe functions (when using |
|
posix directly). |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
for single_thread_function, multithread_safe_function in threading_list: |
|
ix = line.find(single_thread_function) |
|
|
|
if ix >= 0 and (ix == 0 or (not line[ix - 1].isalnum() and |
|
line[ix - 1] not in ('_', '.', '>'))): |
|
error(filename, linenum, 'runtime/threadsafe_fn', 2, |
|
'Consider using ' + multithread_safe_function + |
|
'...) instead of ' + single_thread_function + |
|
'...) for improved thread safety.') |
|
|
|
|
|
def CheckVlogArguments(filename, clean_lines, linenum, error): |
|
"""Checks that VLOG() is only used for defining a logging level. |
|
|
|
For example, VLOG(2) is correct. VLOG(INFO), VLOG(WARNING), VLOG(ERROR), and |
|
VLOG(FATAL) are not. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
if Search(r'\bVLOG\((INFO|ERROR|WARNING|DFATAL|FATAL)\)', line): |
|
error(filename, linenum, 'runtime/vlog', 5, |
|
'VLOG() should be used with numeric verbosity level. ' |
|
'Use LOG() if you want symbolic severity levels.') |
|
|
|
|
|
|
|
|
|
_RE_PATTERN_INVALID_INCREMENT = re.compile( |
|
r'^\s*\*\w+(\+\+|--);') |
|
|
|
|
|
def CheckInvalidIncrement(filename, clean_lines, linenum, error): |
|
"""Checks for invalid increment *count++. |
|
|
|
For example following function: |
|
void increment_counter(int* count) { |
|
*count++; |
|
} |
|
is invalid, because it effectively does count++, moving pointer, and should |
|
be replaced with ++*count, (*count)++ or *count += 1. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
if _RE_PATTERN_INVALID_INCREMENT.match(line): |
|
error(filename, linenum, 'runtime/invalid_increment', 5, |
|
'Changing pointer instead of value (or unused value of operator*).') |
|
|
|
|
|
class _BlockInfo(object): |
|
"""Stores information about a generic block of code.""" |
|
|
|
def __init__(self, seen_open_brace): |
|
self.seen_open_brace = seen_open_brace |
|
self.open_parentheses = 0 |
|
self.inline_asm = _NO_ASM |
|
|
|
def CheckBegin(self, filename, clean_lines, linenum, error): |
|
"""Run checks that applies to text up to the opening brace. |
|
|
|
This is mostly for checking the text after the class identifier |
|
and the "{", usually where the base class is specified. For other |
|
blocks, there isn't much to check, so we always pass. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
pass |
|
|
|
def CheckEnd(self, filename, clean_lines, linenum, error): |
|
"""Run checks that applies to text after the closing brace. |
|
|
|
This is mostly used for checking end of namespace comments. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
pass |
|
|
|
|
|
class _ClassInfo(_BlockInfo): |
|
"""Stores information about a class.""" |
|
|
|
def __init__(self, name, class_or_struct, clean_lines, linenum): |
|
_BlockInfo.__init__(self, False) |
|
self.name = name |
|
self.starting_linenum = linenum |
|
self.is_derived = False |
|
if class_or_struct == 'struct': |
|
self.access = 'public' |
|
self.is_struct = True |
|
else: |
|
self.access = 'private' |
|
self.is_struct = False |
|
|
|
|
|
|
|
initial_indent = Match(r'^( *)\S', clean_lines.raw_lines[linenum]) |
|
if initial_indent: |
|
self.class_indent = len(initial_indent.group(1)) |
|
else: |
|
self.class_indent = 0 |
|
|
|
|
|
|
|
|
|
|
|
|
|
self.last_line = 0 |
|
depth = 0 |
|
for i in range(linenum, clean_lines.NumLines()): |
|
line = clean_lines.elided[i] |
|
depth += line.count('{') - line.count('}') |
|
if not depth: |
|
self.last_line = i |
|
break |
|
|
|
def CheckBegin(self, filename, clean_lines, linenum, error): |
|
|
|
if Search('(^|[^:]):($|[^:])', clean_lines.elided[linenum]): |
|
self.is_derived = True |
|
|
|
def CheckEnd(self, filename, clean_lines, linenum, error): |
|
|
|
|
|
|
|
indent = Match(r'^( *)\}', clean_lines.elided[linenum]) |
|
if indent and len(indent.group(1)) != self.class_indent: |
|
if self.is_struct: |
|
parent = 'struct ' + self.name |
|
else: |
|
parent = 'class ' + self.name |
|
error(filename, linenum, 'whitespace/indent', 3, |
|
'Closing brace should be aligned with beginning of %s' % parent) |
|
|
|
|
|
class _NamespaceInfo(_BlockInfo): |
|
"""Stores information about a namespace.""" |
|
|
|
def __init__(self, name, linenum): |
|
_BlockInfo.__init__(self, False) |
|
self.name = name or '' |
|
self.starting_linenum = linenum |
|
|
|
def CheckEnd(self, filename, clean_lines, linenum, error): |
|
"""Check end of namespace comments.""" |
|
line = clean_lines.raw_lines[linenum] |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if (linenum - self.starting_linenum < 10 |
|
and not Match(r'};*\s*(//|/\*).*\bnamespace\b', line)): |
|
return |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if self.name: |
|
|
|
if not Match((r'};*\s*(//|/\*).*\bnamespace\s+' + re.escape(self.name) + |
|
r'[\*/\.\\\s]*$'), |
|
line): |
|
error(filename, linenum, 'readability/namespace', 5, |
|
'Namespace should be terminated with "// namespace %s"' % |
|
self.name) |
|
else: |
|
|
|
if not Match(r'};*\s*(//|/\*).*\bnamespace[\*/\.\\\s]*$', line): |
|
error(filename, linenum, 'readability/namespace', 5, |
|
'Namespace should be terminated with "// namespace"') |
|
|
|
|
|
class _PreprocessorInfo(object): |
|
"""Stores checkpoints of nesting stacks when #if/#else is seen.""" |
|
|
|
def __init__(self, stack_before_if): |
|
|
|
self.stack_before_if = stack_before_if |
|
|
|
|
|
self.stack_before_else = [] |
|
|
|
|
|
self.seen_else = False |
|
|
|
|
|
class _NestingState(object): |
|
"""Holds states related to parsing braces.""" |
|
|
|
def __init__(self): |
|
|
|
|
|
|
|
|
|
|
|
|
|
self.stack = [] |
|
|
|
|
|
self.pp_stack = [] |
|
|
|
def SeenOpenBrace(self): |
|
"""Check if we have seen the opening brace for the innermost block. |
|
|
|
Returns: |
|
True if we have seen the opening brace, False if the innermost |
|
block is still expecting an opening brace. |
|
""" |
|
return (not self.stack) or self.stack[-1].seen_open_brace |
|
|
|
def InNamespaceBody(self): |
|
"""Check if we are currently one level inside a namespace body. |
|
|
|
Returns: |
|
True if top of the stack is a namespace block, False otherwise. |
|
""" |
|
return self.stack and isinstance(self.stack[-1], _NamespaceInfo) |
|
|
|
def UpdatePreprocessor(self, line): |
|
"""Update preprocessor stack. |
|
|
|
We need to handle preprocessors due to classes like this: |
|
#ifdef SWIG |
|
struct ResultDetailsPageElementExtensionPoint { |
|
#else |
|
struct ResultDetailsPageElementExtensionPoint : public Extension { |
|
#endif |
|
|
|
We make the following assumptions (good enough for most files): |
|
- Preprocessor condition evaluates to true from #if up to first |
|
#else/#elif/#endif. |
|
|
|
- Preprocessor condition evaluates to false from #else/#elif up |
|
to #endif. We still perform lint checks on these lines, but |
|
these do not affect nesting stack. |
|
|
|
Args: |
|
line: current line to check. |
|
""" |
|
if Match(r'^\s*#\s*(if|ifdef|ifndef)\b', line): |
|
|
|
|
|
self.pp_stack.append(_PreprocessorInfo(copy.deepcopy(self.stack))) |
|
elif Match(r'^\s*#\s*(else|elif)\b', line): |
|
|
|
if self.pp_stack: |
|
if not self.pp_stack[-1].seen_else: |
|
|
|
|
|
|
|
self.pp_stack[-1].seen_else = True |
|
self.pp_stack[-1].stack_before_else = copy.deepcopy(self.stack) |
|
|
|
|
|
self.stack = copy.deepcopy(self.pp_stack[-1].stack_before_if) |
|
else: |
|
|
|
pass |
|
elif Match(r'^\s*#\s*endif\b', line): |
|
|
|
if self.pp_stack: |
|
|
|
|
|
|
|
if self.pp_stack[-1].seen_else: |
|
|
|
|
|
self.stack = self.pp_stack[-1].stack_before_else |
|
|
|
self.pp_stack.pop() |
|
else: |
|
|
|
pass |
|
|
|
def Update(self, filename, clean_lines, linenum, error): |
|
"""Update nesting state with current line. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
|
|
|
|
self.UpdatePreprocessor(line) |
|
|
|
|
|
|
|
if self.stack: |
|
inner_block = self.stack[-1] |
|
depth_change = line.count('(') - line.count(')') |
|
inner_block.open_parentheses += depth_change |
|
|
|
|
|
if inner_block.inline_asm in (_NO_ASM, _END_ASM): |
|
if (depth_change != 0 and |
|
inner_block.open_parentheses == 1 and |
|
_MATCH_ASM.match(line)): |
|
|
|
inner_block.inline_asm = _INSIDE_ASM |
|
else: |
|
|
|
|
|
inner_block.inline_asm = _NO_ASM |
|
elif (inner_block.inline_asm == _INSIDE_ASM and |
|
inner_block.open_parentheses == 0): |
|
|
|
inner_block.inline_asm = _END_ASM |
|
|
|
|
|
|
|
|
|
while True: |
|
|
|
|
|
|
|
|
|
namespace_decl_match = Match(r'^\s*namespace\b\s*([:\w]+)?(.*)$', line) |
|
if not namespace_decl_match: |
|
break |
|
|
|
new_namespace = _NamespaceInfo(namespace_decl_match.group(1), linenum) |
|
self.stack.append(new_namespace) |
|
|
|
line = namespace_decl_match.group(2) |
|
if line.find('{') != -1: |
|
new_namespace.seen_open_brace = True |
|
line = line[line.find('{') + 1:] |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class_decl_match = Match( |
|
r'\s*(template\s*<[\w\s<>,:]*>\s*)?' |
|
r'(class|struct)\s+([A-Z_]+\s+)*(\w+(?:::\w+)*)' |
|
r'(([^=>]|<[^<>]*>|<[^<>]*<[^<>]*>\s*>)*)$', line) |
|
if (class_decl_match and |
|
(not self.stack or self.stack[-1].open_parentheses == 0)): |
|
self.stack.append(_ClassInfo( |
|
class_decl_match.group(4), class_decl_match.group(2), |
|
clean_lines, linenum)) |
|
line = class_decl_match.group(5) |
|
|
|
|
|
|
|
if not self.SeenOpenBrace(): |
|
self.stack[-1].CheckBegin(filename, clean_lines, linenum, error) |
|
|
|
|
|
if self.stack and isinstance(self.stack[-1], _ClassInfo): |
|
classinfo = self.stack[-1] |
|
access_match = Match( |
|
r'^(.*)\b(public|private|protected|signals)(\s+(?:slots\s*)?)?' |
|
r':(?:[^:]|$)', |
|
line) |
|
if access_match: |
|
classinfo.access = access_match.group(2) |
|
|
|
|
|
|
|
indent = access_match.group(1) |
|
if (len(indent) != classinfo.class_indent + 1 and |
|
Match(r'^\s*$', indent)): |
|
if classinfo.is_struct: |
|
parent = 'struct ' + classinfo.name |
|
else: |
|
parent = 'class ' + classinfo.name |
|
slots = '' |
|
if access_match.group(3): |
|
slots = access_match.group(3) |
|
error(filename, linenum, 'whitespace/indent', 3, |
|
'%s%s: should be indented +1 space inside %s' % ( |
|
access_match.group(2), slots, parent)) |
|
|
|
|
|
while True: |
|
|
|
matched = Match(r'^[^{;)}]*([{;)}])(.*)$', line) |
|
if not matched: |
|
break |
|
|
|
token = matched.group(1) |
|
if token == '{': |
|
|
|
|
|
|
|
if not self.SeenOpenBrace(): |
|
self.stack[-1].seen_open_brace = True |
|
else: |
|
self.stack.append(_BlockInfo(True)) |
|
if _MATCH_ASM.match(line): |
|
self.stack[-1].inline_asm = _BLOCK_ASM |
|
elif token == ';' or token == ')': |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if not self.SeenOpenBrace(): |
|
self.stack.pop() |
|
else: |
|
|
|
if self.stack: |
|
self.stack[-1].CheckEnd(filename, clean_lines, linenum, error) |
|
self.stack.pop() |
|
line = matched.group(2) |
|
|
|
def InnermostClass(self): |
|
"""Get class info on the top of the stack. |
|
|
|
Returns: |
|
A _ClassInfo object if we are inside a class, or None otherwise. |
|
""" |
|
for i in range(len(self.stack), 0, -1): |
|
classinfo = self.stack[i - 1] |
|
if isinstance(classinfo, _ClassInfo): |
|
return classinfo |
|
return None |
|
|
|
def CheckCompletedBlocks(self, filename, error): |
|
"""Checks that all classes and namespaces have been completely parsed. |
|
|
|
Call this when all lines in a file have been processed. |
|
Args: |
|
filename: The name of the current file. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
|
|
for obj in self.stack: |
|
if isinstance(obj, _ClassInfo): |
|
error(filename, obj.starting_linenum, 'build/class', 5, |
|
'Failed to find complete declaration of class %s' % |
|
obj.name) |
|
elif isinstance(obj, _NamespaceInfo): |
|
error(filename, obj.starting_linenum, 'build/namespaces', 5, |
|
'Failed to find complete declaration of namespace %s' % |
|
obj.name) |
|
|
|
|
|
def CheckForNonStandardConstructs(filename, clean_lines, linenum, |
|
nesting_state, error): |
|
r"""Logs an error if we see certain non-ANSI constructs ignored by gcc-2. |
|
|
|
Complain about several constructs which gcc-2 accepts, but which are |
|
not standard C++. Warning about these in lint is one way to ease the |
|
transition to new compilers. |
|
- put storage class first (e.g. "static const" instead of "const static"). |
|
- "%lld" instead of %qd" in printf-type functions. |
|
- "%1$d" is non-standard in printf-type functions. |
|
- "\%" is an undefined character escape sequence. |
|
- text after #endif is not allowed. |
|
- invalid inner-style forward declaration. |
|
- >? and <? operators, and their >?= and <?= cousins. |
|
|
|
Additionally, check for constructor/destructor style violations and reference |
|
members, as it is very convenient to do so while checking for |
|
gcc-2 compliance. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
nesting_state: A _NestingState instance which maintains information about |
|
the current stack of nested blocks being parsed. |
|
error: A callable to which errors are reported, which takes 4 arguments: |
|
filename, line number, error level, and message |
|
""" |
|
|
|
|
|
line = clean_lines.lines[linenum] |
|
|
|
if Search(r'printf\s*\(.*".*%[-+ ]?\d*q', line): |
|
error(filename, linenum, 'runtime/printf_format', 3, |
|
'%q in format strings is deprecated. Use %ll instead.') |
|
|
|
if Search(r'printf\s*\(.*".*%\d+\$', line): |
|
error(filename, linenum, 'runtime/printf_format', 2, |
|
'%N$ formats are unconventional. Try rewriting to avoid them.') |
|
|
|
|
|
line = line.replace('\\\\', '') |
|
|
|
if Search(r'("|\').*\\(%|\[|\(|{)', line): |
|
error(filename, linenum, 'build/printf_format', 3, |
|
'%, [, (, and { are undefined character escapes. Unescape them.') |
|
|
|
|
|
line = clean_lines.elided[linenum] |
|
|
|
if Search(r'\b(const|volatile|void|char|short|int|long' |
|
r'|float|double|signed|unsigned' |
|
r'|schar|u?int8|u?int16|u?int32|u?int64)' |
|
r'\s+(register|static|extern|typedef)\b', |
|
line): |
|
error(filename, linenum, 'build/storage_class', 5, |
|
'Storage class (static, extern, typedef, etc) should be first.') |
|
|
|
if Match(r'\s*#\s*endif\s*[^/\s]+', line): |
|
error(filename, linenum, 'build/endif_comment', 5, |
|
'Uncommented text after #endif is non-standard. Use a comment.') |
|
|
|
if Match(r'\s*class\s+(\w+\s*::\s*)+\w+\s*;', line): |
|
error(filename, linenum, 'build/forward_decl', 5, |
|
'Inner-style forward declarations are invalid. Remove this line.') |
|
|
|
if Search(r'(\w+|[+-]?\d+(\.\d*)?)\s*(<|>)\?=?\s*(\w+|[+-]?\d+)(\.\d*)?', |
|
line): |
|
error(filename, linenum, 'build/deprecated', 3, |
|
'>? and <? (max and min) operators are non-standard and deprecated.') |
|
|
|
if Search(r'^\s*const\s*string\s*&\s*\w+\s*;', line): |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
error(filename, linenum, 'runtime/member_string_references', 2, |
|
'const string& members are dangerous. It is much better to use ' |
|
'alternatives, such as pointers or simple constants.') |
|
|
|
|
|
|
|
|
|
classinfo = nesting_state.InnermostClass() |
|
if not classinfo or not classinfo.seen_open_brace: |
|
return |
|
|
|
|
|
|
|
base_classname = classinfo.name.split('::')[-1] |
|
|
|
|
|
|
|
args = Match(r'\s+(?:inline\s+)?%s\s*\(([^,()]+)\)' |
|
% re.escape(base_classname), |
|
line) |
|
if (args and |
|
args.group(1) != 'void' and |
|
not Match(r'(const\s+)?%s(\s+const)?\s*(?:<\w+>\s*)?&' |
|
% re.escape(base_classname), args.group(1).strip())): |
|
error(filename, linenum, 'runtime/explicit', 5, |
|
'Single-argument constructors should be marked explicit.') |
|
|
|
|
|
def CheckSpacingForFunctionCall(filename, line, linenum, error): |
|
"""Checks for the correctness of various spacing around function calls. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
line: The text of the line to check. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
|
|
|
|
|
|
fncall = line |
|
for pattern in (r'\bif\s*\((.*)\)\s*{', |
|
r'\bfor\s*\((.*)\)\s*{', |
|
r'\bwhile\s*\((.*)\)\s*[{;]', |
|
r'\bswitch\s*\((.*)\)\s*{'): |
|
match = Search(pattern, line) |
|
if match: |
|
fncall = match.group(1) |
|
break |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if ( |
|
not Search(r'\b(if|for|while|switch|return|new|delete|catch|sizeof)\b', |
|
fncall) and |
|
|
|
not Search(r' \([^)]+\)\([^)]*(\)|,$)', fncall) and |
|
|
|
not Search(r' \([^)]+\)\[[^\]]+\]', fncall)): |
|
if Search(r'\w\s*\(\s(?!\s*\\$)', fncall): |
|
error(filename, linenum, 'whitespace/parens', 4, |
|
'Extra space after ( in function call') |
|
elif Search(r'\(\s+(?!(\s*\\)|\()', fncall): |
|
error(filename, linenum, 'whitespace/parens', 2, |
|
'Extra space after (') |
|
if (Search(r'\w\s+\(', fncall) and |
|
not Search(r'#\s*define|typedef', fncall) and |
|
not Search(r'\w\s+\((\w+::)*\*\w+\)\(', fncall)): |
|
error(filename, linenum, 'whitespace/parens', 4, |
|
'Extra space before ( in function call') |
|
|
|
|
|
if Search(r'[^)]\s+\)\s*[^{\s]', fncall): |
|
|
|
|
|
if Search(r'^\s+\)', fncall): |
|
error(filename, linenum, 'whitespace/parens', 2, |
|
'Closing ) should be moved to the previous line') |
|
else: |
|
error(filename, linenum, 'whitespace/parens', 2, |
|
'Extra space before )') |
|
|
|
|
|
def IsBlankLine(line): |
|
"""Returns true if the given line is blank. |
|
|
|
We consider a line to be blank if the line is empty or consists of |
|
only white spaces. |
|
|
|
Args: |
|
line: A line of a string. |
|
|
|
Returns: |
|
True, if the given line is blank. |
|
""" |
|
return not line or line.isspace() |
|
|
|
|
|
def CheckForFunctionLengths(filename, clean_lines, linenum, |
|
function_state, error): |
|
"""Reports for long function bodies. |
|
|
|
For an overview why this is done, see: |
|
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Write_Short_Functions |
|
|
|
Uses a simplistic algorithm assuming other style guidelines |
|
(especially spacing) are followed. |
|
Only checks unindented functions, so class members are unchecked. |
|
Trivial bodies are unchecked, so constructors with huge initializer lists |
|
may be missed. |
|
Blank/comment lines are not counted so as to avoid encouraging the removal |
|
of vertical space and comments just to get through a lint check. |
|
NOLINT *on the last line of a function* disables this check. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
function_state: Current function name and lines in body so far. |
|
error: The function to call with any errors found. |
|
""" |
|
lines = clean_lines.lines |
|
line = lines[linenum] |
|
raw = clean_lines.raw_lines |
|
raw_line = raw[linenum] |
|
joined_line = '' |
|
|
|
starting_func = False |
|
regexp = r'(\w(\w|::|\*|\&|\s)*)\(' |
|
match_result = Match(regexp, line) |
|
if match_result: |
|
|
|
|
|
function_name = match_result.group(1).split()[-1] |
|
if function_name == 'TEST' or function_name == 'TEST_F' or ( |
|
not Match(r'[A-Z_]+$', function_name)): |
|
starting_func = True |
|
|
|
if starting_func: |
|
body_found = False |
|
for start_linenum in xrange(linenum, clean_lines.NumLines()): |
|
start_line = lines[start_linenum] |
|
joined_line += ' ' + start_line.lstrip() |
|
if Search(r'(;|})', start_line): |
|
body_found = True |
|
break |
|
elif Search(r'{', start_line): |
|
body_found = True |
|
function = Search(r'((\w|:)*)\(', line).group(1) |
|
if Match(r'TEST', function): |
|
parameter_regexp = Search(r'(\(.*\))', joined_line) |
|
if parameter_regexp: |
|
function += parameter_regexp.group(1) |
|
else: |
|
function += '()' |
|
function_state.Begin(function) |
|
break |
|
if not body_found: |
|
|
|
error(filename, linenum, 'readability/fn_size', 5, |
|
'Lint failed to find start of function body.') |
|
elif Match(r'^\}\s*$', line): |
|
function_state.Check(error, filename, linenum) |
|
function_state.End() |
|
elif not Match(r'^\s*$', line): |
|
function_state.Count() |
|
|
|
|
|
_RE_PATTERN_TODO = re.compile(r'^//(\s*)TODO(\(.+?\))?:?(\s|$)?') |
|
|
|
|
|
def CheckComment(comment, filename, linenum, error): |
|
"""Checks for common mistakes in TODO comments. |
|
|
|
Args: |
|
comment: The text of the comment from the line in question. |
|
filename: The name of the current file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
match = _RE_PATTERN_TODO.match(comment) |
|
if match: |
|
|
|
leading_whitespace = match.group(1) |
|
if len(leading_whitespace) > 1: |
|
error(filename, linenum, 'whitespace/todo', 2, |
|
'Too many spaces before TODO') |
|
|
|
username = match.group(2) |
|
if not username: |
|
error(filename, linenum, 'readability/todo', 2, |
|
'Missing username in TODO; it should look like ' |
|
'"// TODO(my_username): Stuff."') |
|
|
|
middle_whitespace = match.group(3) |
|
|
|
if middle_whitespace != ' ' and middle_whitespace != '': |
|
error(filename, linenum, 'whitespace/todo', 2, |
|
'TODO(my_username) should be followed by a space') |
|
|
|
def CheckAccess(filename, clean_lines, linenum, nesting_state, error): |
|
"""Checks for improper use of DISALLOW* macros. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
nesting_state: A _NestingState instance which maintains information about |
|
the current stack of nested blocks being parsed. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
|
|
matched = Match((r'\s*(DISALLOW_COPY_AND_ASSIGN|' |
|
r'DISALLOW_EVIL_CONSTRUCTORS|' |
|
r'DISALLOW_IMPLICIT_CONSTRUCTORS)'), line) |
|
if not matched: |
|
return |
|
if nesting_state.stack and isinstance(nesting_state.stack[-1], _ClassInfo): |
|
if nesting_state.stack[-1].access != 'private': |
|
error(filename, linenum, 'readability/constructors', 3, |
|
'%s must be in the private: section' % matched.group(1)) |
|
|
|
else: |
|
|
|
|
|
|
|
|
|
pass |
|
|
|
|
|
def FindNextMatchingAngleBracket(clean_lines, linenum, init_suffix): |
|
"""Find the corresponding > to close a template. |
|
|
|
Args: |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: Current line number. |
|
init_suffix: Remainder of the current line after the initial <. |
|
|
|
Returns: |
|
True if a matching bracket exists. |
|
""" |
|
line = init_suffix |
|
nesting_stack = ['<'] |
|
while True: |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
match = Search(r'^[^<>(),;\[\]]*([<>(),;\[\]])(.*)$', line) |
|
if match: |
|
|
|
operator = match.group(1) |
|
line = match.group(2) |
|
|
|
if nesting_stack[-1] == '<': |
|
|
|
if operator in ('<', '(', '['): |
|
nesting_stack.append(operator) |
|
elif operator == '>': |
|
nesting_stack.pop() |
|
if not nesting_stack: |
|
|
|
return True |
|
elif operator == ',': |
|
|
|
|
|
|
|
|
|
return True |
|
else: |
|
|
|
return False |
|
|
|
else: |
|
|
|
if operator in ('<', '(', '['): |
|
nesting_stack.append(operator) |
|
elif operator in (')', ']'): |
|
|
|
|
|
nesting_stack.pop() |
|
|
|
else: |
|
|
|
linenum += 1 |
|
if linenum >= len(clean_lines.elided): |
|
break |
|
line = clean_lines.elided[linenum] |
|
|
|
|
|
|
|
|
|
return True |
|
|
|
|
|
def FindPreviousMatchingAngleBracket(clean_lines, linenum, init_prefix): |
|
"""Find the corresponding < that started a template. |
|
|
|
Args: |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: Current line number. |
|
init_prefix: Part of the current line before the initial >. |
|
|
|
Returns: |
|
True if a matching bracket exists. |
|
""" |
|
line = init_prefix |
|
nesting_stack = ['>'] |
|
while True: |
|
|
|
match = Search(r'^(.*)([<>(),;\[\]])[^<>(),;\[\]]*$', line) |
|
if match: |
|
|
|
operator = match.group(2) |
|
line = match.group(1) |
|
|
|
if nesting_stack[-1] == '>': |
|
|
|
if operator in ('>', ')', ']'): |
|
nesting_stack.append(operator) |
|
elif operator == '<': |
|
nesting_stack.pop() |
|
if not nesting_stack: |
|
|
|
return True |
|
elif operator == ',': |
|
|
|
|
|
|
|
return True |
|
else: |
|
|
|
return False |
|
|
|
else: |
|
|
|
if operator in ('>', ')', ']'): |
|
nesting_stack.append(operator) |
|
elif operator in ('(', '['): |
|
nesting_stack.pop() |
|
|
|
else: |
|
|
|
linenum -= 1 |
|
if linenum < 0: |
|
break |
|
line = clean_lines.elided[linenum] |
|
|
|
|
|
return False |
|
|
|
|
|
def CheckSpacing(filename, clean_lines, linenum, nesting_state, error): |
|
"""Checks for the correctness of various spacing issues in the code. |
|
|
|
Things we check for: spaces around operators, spaces after |
|
if/for/while/switch, no spaces around parens in function calls, two |
|
spaces between code and comment, don't start a block with a blank |
|
line, don't end a function with a blank line, don't add a blank line |
|
after public/protected/private, don't have too many blank lines in a row. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
nesting_state: A _NestingState instance which maintains information about |
|
the current stack of nested blocks being parsed. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
|
|
|
|
raw = clean_lines.lines_without_raw_strings |
|
line = raw[linenum] |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if IsBlankLine(line) and not nesting_state.InNamespaceBody(): |
|
elided = clean_lines.elided |
|
prev_line = elided[linenum - 1] |
|
prevbrace = prev_line.rfind('{') |
|
|
|
|
|
|
|
|
|
if prevbrace != -1 and prev_line[prevbrace:].find('}') == -1: |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
exception = False |
|
if Match(r' {6}\w', prev_line): |
|
|
|
|
|
search_position = linenum-2 |
|
while (search_position >= 0 |
|
and Match(r' {6}\w', elided[search_position])): |
|
search_position -= 1 |
|
exception = (search_position >= 0 |
|
and elided[search_position][:5] == ' :') |
|
else: |
|
|
|
|
|
|
|
|
|
|
|
|
|
exception = (Match(r' {4}\w[^\(]*\)\s*(const\s*)?(\{\s*$|:)', |
|
prev_line) |
|
or Match(r' {4}:', prev_line)) |
|
|
|
if not exception: |
|
error(filename, linenum, 'whitespace/blank_line', 2, |
|
'Redundant blank line at the start of a code block ' |
|
'should be deleted.') |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if linenum + 1 < clean_lines.NumLines(): |
|
next_line = raw[linenum + 1] |
|
if (next_line |
|
and Match(r'\s*}', next_line) |
|
and next_line.find('} else ') == -1): |
|
error(filename, linenum, 'whitespace/blank_line', 3, |
|
'Redundant blank line at the end of a code block ' |
|
'should be deleted.') |
|
|
|
matched = Match(r'\s*(public|protected|private):', prev_line) |
|
if matched: |
|
error(filename, linenum, 'whitespace/blank_line', 3, |
|
'Do not leave a blank line after "%s:"' % matched.group(1)) |
|
|
|
|
|
commentpos = line.find('//') |
|
if commentpos != -1: |
|
|
|
|
|
if (line.count('"', 0, commentpos) - |
|
line.count('\\"', 0, commentpos)) % 2 == 0: |
|
|
|
if (not Match(r'^\s*{ //', line) and |
|
((commentpos >= 1 and |
|
line[commentpos-1] not in string.whitespace) or |
|
(commentpos >= 2 and |
|
line[commentpos-2] not in string.whitespace))): |
|
error(filename, linenum, 'whitespace/comments', 2, |
|
'At least two spaces is best between code and comments') |
|
|
|
commentend = commentpos + 2 |
|
if commentend < len(line) and not line[commentend] == ' ': |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
match = (Search(r'[=/-]{4,}\s*$', line[commentend:]) or |
|
Search(r'^/$', line[commentend:]) or |
|
Search(r'^!< ', line[commentend:]) or |
|
Search(r'^/< ', line[commentend:]) or |
|
Search(r'^/+ ', line[commentend:])) |
|
if not match: |
|
error(filename, linenum, 'whitespace/comments', 4, |
|
'Should have a space between // and comment') |
|
CheckComment(line[commentpos:], filename, linenum, error) |
|
|
|
line = clean_lines.elided[linenum] |
|
|
|
|
|
line = re.sub(r'operator(==|!=|<|<<|<=|>=|>>|>)\(', 'operator\(', line) |
|
|
|
|
|
|
|
|
|
|
|
if Search(r'[\w.]=[\w.]', line) and not Search(r'\b(if|while) ', line): |
|
error(filename, linenum, 'whitespace/operators', 4, |
|
'Missing spaces around =') |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
match = Search(r'[^<>=!\s](==|!=|<=|>=)[^<>=!\s]', line) |
|
if match: |
|
error(filename, linenum, 'whitespace/operators', 3, |
|
'Missing spaces around %s' % match.group(1)) |
|
|
|
|
|
|
|
match = Search(r'(operator|\S)(?:L|UL|ULL|l|ul|ull)?<<(\S)', line) |
|
if (match and |
|
not (match.group(1).isdigit() and match.group(2).isdigit()) and |
|
not (match.group(1) == 'operator' and match.group(2) == ';')): |
|
error(filename, linenum, 'whitespace/operators', 3, |
|
'Missing spaces around <<') |
|
elif not Match(r'#.*include', line): |
|
|
|
reduced_line = line.replace('->', '') |
|
|
|
|
|
|
|
|
|
|
|
match = Search(r'[^\s<]<([^\s=<].*)', reduced_line) |
|
if (match and |
|
not FindNextMatchingAngleBracket(clean_lines, linenum, match.group(1))): |
|
error(filename, linenum, 'whitespace/operators', 3, |
|
'Missing spaces around <') |
|
|
|
|
|
|
|
|
|
match = Search(r'^(.*[^\s>])>[^\s=>]', reduced_line) |
|
if (match and |
|
not FindPreviousMatchingAngleBracket(clean_lines, linenum, |
|
match.group(1))): |
|
error(filename, linenum, 'whitespace/operators', 3, |
|
'Missing spaces around >') |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
match = Search(r'>>[a-zA-Z_]', line) |
|
if match: |
|
error(filename, linenum, 'whitespace/operators', 3, |
|
'Missing spaces around >>') |
|
|
|
|
|
match = Search(r'(!\s|~\s|[\s]--[\s;]|[\s]\+\+[\s;])', line) |
|
if match: |
|
error(filename, linenum, 'whitespace/operators', 4, |
|
'Extra space for operator %s' % match.group(1)) |
|
|
|
|
|
match = Search(r' (if\(|for\(|while\(|switch\()', line) |
|
if match: |
|
error(filename, linenum, 'whitespace/parens', 5, |
|
'Missing space before ( in %s' % match.group(1)) |
|
|
|
|
|
|
|
|
|
|
|
|
|
match = Search(r'\b(if|for|while|switch)\s*' |
|
r'\(([ ]*)(.).*[^ ]+([ ]*)\)\s*{\s*$', |
|
line) |
|
if match: |
|
if len(match.group(2)) != len(match.group(4)): |
|
if not (match.group(3) == ';' and |
|
len(match.group(2)) == 1 + len(match.group(4)) or |
|
not match.group(2) and Search(r'\bfor\s*\(.*; \)', line)): |
|
error(filename, linenum, 'whitespace/parens', 5, |
|
'Mismatching spaces inside () in %s' % match.group(1)) |
|
if len(match.group(2)) not in [0, 1]: |
|
error(filename, linenum, 'whitespace/parens', 5, |
|
'Should have zero or one spaces inside ( and ) in %s' % |
|
match.group(1)) |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if Search(r',[^,\s]', line) and Search(r',[^,\s]', raw[linenum]): |
|
error(filename, linenum, 'whitespace/comma', 3, |
|
'Missing space after ,') |
|
|
|
|
|
|
|
|
|
|
|
if Search(r';[^\s};\\)/]', line): |
|
error(filename, linenum, 'whitespace/semicolon', 3, |
|
'Missing space after ;') |
|
|
|
|
|
CheckSpacingForFunctionCall(filename, line, linenum, error) |
|
|
|
|
|
|
|
|
|
|
|
match = Match(r'^(.*[^ ({]){', line) |
|
if match: |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
(endline, endlinenum, endpos) = CloseExpression( |
|
clean_lines, linenum, len(match.group(1))) |
|
trailing_text = '' |
|
if endpos > -1: |
|
trailing_text = endline[endpos:] |
|
for offset in xrange(endlinenum + 1, |
|
min(endlinenum + 3, clean_lines.NumLines() - 1)): |
|
trailing_text += clean_lines.elided[offset] |
|
if not Match(r'^[\s}]*[{.;,)<\]]', trailing_text): |
|
error(filename, linenum, 'whitespace/braces', 5, |
|
'Missing space before {') |
|
|
|
|
|
if Search(r'}else', line): |
|
error(filename, linenum, 'whitespace/braces', 5, |
|
'Missing space before else') |
|
|
|
|
|
|
|
if Search(r'\w\s+\[', line) and not Search(r'delete\s+\[', line): |
|
error(filename, linenum, 'whitespace/braces', 5, |
|
'Extra space before [') |
|
|
|
|
|
|
|
|
|
if Search(r':\s*;\s*$', line): |
|
error(filename, linenum, 'whitespace/semicolon', 5, |
|
'Semicolon defining empty statement. Use {} instead.') |
|
elif Search(r'^\s*;\s*$', line): |
|
error(filename, linenum, 'whitespace/semicolon', 5, |
|
'Line contains only semicolon. If this should be an empty statement, ' |
|
'use {} instead.') |
|
elif (Search(r'\s+;\s*$', line) and |
|
not Search(r'\bfor\b', line)): |
|
error(filename, linenum, 'whitespace/semicolon', 5, |
|
'Extra space before last semicolon. If this should be an empty ' |
|
'statement, use {} instead.') |
|
|
|
|
|
|
|
if (Search('for *\(.*[^:]:[^: ]', line) or |
|
Search('for *\(.*[^: ]:[^:]', line)): |
|
error(filename, linenum, 'whitespace/forcolon', 2, |
|
'Missing space around colon in range-based for loop') |
|
|
|
|
|
def CheckSectionSpacing(filename, clean_lines, class_info, linenum, error): |
|
"""Checks for additional blank line issues related to sections. |
|
|
|
Currently the only thing checked here is blank line before protected/private. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
class_info: A _ClassInfo objects. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if (class_info.last_line - class_info.starting_linenum <= 24 or |
|
linenum <= class_info.starting_linenum): |
|
return |
|
|
|
matched = Match(r'\s*(public|protected|private):', clean_lines.lines[linenum]) |
|
if matched: |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
prev_line = clean_lines.lines[linenum - 1] |
|
if (not IsBlankLine(prev_line) and |
|
not Search(r'\b(class|struct)\b', prev_line) and |
|
not Search(r'\\$', prev_line)): |
|
|
|
|
|
|
|
|
|
end_class_head = class_info.starting_linenum |
|
for i in range(class_info.starting_linenum, linenum): |
|
if Search(r'\{\s*$', clean_lines.lines[i]): |
|
end_class_head = i |
|
break |
|
if end_class_head < linenum - 1: |
|
error(filename, linenum, 'whitespace/blank_line', 3, |
|
'"%s:" should be preceded by a blank line' % matched.group(1)) |
|
|
|
|
|
def GetPreviousNonBlankLine(clean_lines, linenum): |
|
"""Return the most recent non-blank line and its line number. |
|
|
|
Args: |
|
clean_lines: A CleansedLines instance containing the file contents. |
|
linenum: The number of the line to check. |
|
|
|
Returns: |
|
A tuple with two elements. The first element is the contents of the last |
|
non-blank line before the current line, or the empty string if this is the |
|
first non-blank line. The second is the line number of that line, or -1 |
|
if this is the first non-blank line. |
|
""" |
|
|
|
prevlinenum = linenum - 1 |
|
while prevlinenum >= 0: |
|
prevline = clean_lines.elided[prevlinenum] |
|
if not IsBlankLine(prevline): |
|
return (prevline, prevlinenum) |
|
prevlinenum -= 1 |
|
return ('', -1) |
|
|
|
|
|
def CheckBraces(filename, clean_lines, linenum, error): |
|
"""Looks for misplaced braces (e.g. at the end of line). |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
line = clean_lines.elided[linenum] |
|
|
|
if Match(r'\s*{\s*$', line): |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0] |
|
if (not Search(r'[,;:}{(]\s*$', prevline) and |
|
not Match(r'\s*#', prevline)): |
|
error(filename, linenum, 'whitespace/braces', 4, |
|
'{ should almost always be at the end of the previous line') |
|
|
|
|
|
if Match(r'\s*else\s*', line): |
|
prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0] |
|
if Match(r'\s*}\s*$', prevline): |
|
error(filename, linenum, 'whitespace/newline', 4, |
|
'An else should appear on the same line as the preceding }') |
|
|
|
|
|
|
|
if Search(r'}\s*else[^{]*$', line) or Match(r'[^}]*else\s*{', line): |
|
if Search(r'}\s*else if([^{]*)$', line): |
|
|
|
pos = line.find('else if') |
|
pos = line.find('(', pos) |
|
if pos > 0: |
|
(endline, _, endpos) = CloseExpression(clean_lines, linenum, pos) |
|
if endline[endpos:].find('{') == -1: |
|
error(filename, linenum, 'readability/braces', 5, |
|
'If an else has a brace on one side, it should have it on both') |
|
else: |
|
error(filename, linenum, 'readability/braces', 5, |
|
'If an else has a brace on one side, it should have it on both') |
|
|
|
|
|
if Search(r'\belse [^\s{]', line) and not Search(r'\belse if\b', line): |
|
error(filename, linenum, 'whitespace/newline', 4, |
|
'Else clause should never be on same line as else (use 2 lines)') |
|
|
|
|
|
if Match(r'\s*do [^\s{]', line): |
|
error(filename, linenum, 'whitespace/newline', 4, |
|
'do/while clauses should not be on a single line') |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
match = Match(r'^(.*\)\s*)\{', line) |
|
if match: |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
closing_brace_pos = match.group(1).rfind(')') |
|
opening_parenthesis = ReverseCloseExpression( |
|
clean_lines, linenum, closing_brace_pos) |
|
if opening_parenthesis[2] > -1: |
|
line_prefix = opening_parenthesis[0][0:opening_parenthesis[2]] |
|
macro = Search(r'\b([A-Z_]+)\s*$', line_prefix) |
|
if ((macro and |
|
macro.group(1) not in ( |
|
'TEST', 'TEST_F', 'MATCHER', 'MATCHER_P', 'TYPED_TEST', |
|
'EXCLUSIVE_LOCKS_REQUIRED', 'SHARED_LOCKS_REQUIRED', |
|
'LOCKS_EXCLUDED', 'INTERFACE_DEF')) or |
|
Search(r'\s+=\s*$', line_prefix)): |
|
match = None |
|
|
|
else: |
|
|
|
match = Match(r'^(.*(?:else|\)\s*const)\s*)\{', line) |
|
if not match: |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0] |
|
if prevline and Search(r'[;{}]\s*$', prevline): |
|
match = Match(r'^(\s*)\{', line) |
|
|
|
|
|
if match: |
|
(endline, endlinenum, endpos) = CloseExpression( |
|
clean_lines, linenum, len(match.group(1))) |
|
if endpos > -1 and Match(r'^\s*;', endline[endpos:]): |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
error(filename, endlinenum, 'readability/braces', 4, |
|
"You don't need a ; after a }") |
|
|
|
|
|
def CheckEmptyBlockBody(filename, clean_lines, linenum, error): |
|
"""Look for empty loop/conditional body with only a single semicolon. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
line = clean_lines.elided[linenum] |
|
matched = Match(r'\s*(for|while|if)\s*\(', line) |
|
if matched: |
|
|
|
(end_line, end_linenum, end_pos) = CloseExpression( |
|
clean_lines, linenum, line.find('(')) |
|
|
|
|
|
|
|
|
|
if end_pos >= 0 and Match(r';', end_line[end_pos:]): |
|
if matched.group(1) == 'if': |
|
error(filename, end_linenum, 'whitespace/empty_conditional_body', 5, |
|
'Empty conditional bodies should use {}') |
|
else: |
|
error(filename, end_linenum, 'whitespace/empty_loop_body', 5, |
|
'Empty loop bodies should use {} or continue') |
|
|
|
|
|
def CheckCheck(filename, clean_lines, linenum, error): |
|
"""Checks the use of CHECK and EXPECT macros. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
lines = clean_lines.elided |
|
check_macro = None |
|
start_pos = -1 |
|
for macro in _CHECK_MACROS: |
|
i = lines[linenum].find(macro) |
|
if i >= 0: |
|
check_macro = macro |
|
|
|
|
|
|
|
|
|
|
|
matched = Match(r'^(.*\b' + check_macro + r'\s*)\(', lines[linenum]) |
|
if not matched: |
|
continue |
|
start_pos = len(matched.group(1)) |
|
break |
|
if not check_macro or start_pos < 0: |
|
|
|
return |
|
|
|
|
|
(last_line, end_line, end_pos) = CloseExpression( |
|
clean_lines, linenum, start_pos) |
|
if end_pos < 0: |
|
return |
|
if linenum == end_line: |
|
expression = lines[linenum][start_pos + 1:end_pos - 1] |
|
else: |
|
expression = lines[linenum][start_pos + 1:] |
|
for i in xrange(linenum + 1, end_line): |
|
expression += lines[i] |
|
expression += last_line[0:end_pos - 1] |
|
|
|
|
|
|
|
|
|
lhs = '' |
|
rhs = '' |
|
operator = None |
|
while expression: |
|
matched = Match(r'^\s*(<<|<<=|>>|>>=|->\*|->|&&|\|\||' |
|
r'==|!=|>=|>|<=|<|\()(.*)$', expression) |
|
if matched: |
|
token = matched.group(1) |
|
if token == '(': |
|
|
|
expression = matched.group(2) |
|
(end, _) = FindEndOfExpressionInLine(expression, 0, 1, '(', ')') |
|
if end < 0: |
|
return |
|
lhs += '(' + expression[0:end] |
|
expression = expression[end:] |
|
elif token in ('&&', '||'): |
|
|
|
|
|
|
|
|
|
|
|
return |
|
elif token in ('<<', '<<=', '>>', '>>=', '->*', '->'): |
|
|
|
lhs += token |
|
expression = matched.group(2) |
|
else: |
|
|
|
operator = token |
|
rhs = matched.group(2) |
|
break |
|
else: |
|
|
|
|
|
|
|
|
|
|
|
matched = Match(r'^([^-=!<>()&|]+)(.*)$', expression) |
|
if not matched: |
|
matched = Match(r'^(\s*\S)(.*)$', expression) |
|
if not matched: |
|
break |
|
lhs += matched.group(1) |
|
expression = matched.group(2) |
|
|
|
|
|
if not (lhs and operator and rhs): |
|
return |
|
|
|
|
|
|
|
if rhs.find('&&') > -1 or rhs.find('||') > -1: |
|
return |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
lhs = lhs.strip() |
|
rhs = rhs.strip() |
|
match_constant = r'^([-+]?(\d+|0[xX][0-9a-fA-F]+)[lLuU]{0,3}|".*"|\'.*\')$' |
|
if Match(match_constant, lhs) or Match(match_constant, rhs): |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
error(filename, linenum, 'readability/check', 2, |
|
'Consider using %s instead of %s(a %s b)' % ( |
|
_CHECK_REPLACEMENT[check_macro][operator], |
|
check_macro, operator)) |
|
|
|
|
|
def CheckAltTokens(filename, clean_lines, linenum, error): |
|
"""Check alternative keywords being used in boolean expressions. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
|
|
|
|
if Match(r'^\s*#', line): |
|
return |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if line.find('/*') >= 0 or line.find('*/') >= 0: |
|
return |
|
|
|
for match in _ALT_TOKEN_REPLACEMENT_PATTERN.finditer(line): |
|
error(filename, linenum, 'readability/alt_tokens', 2, |
|
'Use operator %s instead of %s' % ( |
|
_ALT_TOKEN_REPLACEMENT[match.group(1)], match.group(1))) |
|
|
|
|
|
def GetLineWidth(line): |
|
"""Determines the width of the line in column positions. |
|
|
|
Args: |
|
line: A string, which may be a Unicode string. |
|
|
|
Returns: |
|
The width of the line in column positions, accounting for Unicode |
|
combining characters and wide characters. |
|
""" |
|
if six.PY2: |
|
if isinstance(line, unicode): |
|
width = 0 |
|
for uc in unicodedata.normalize('NFC', line): |
|
if unicodedata.east_asian_width(uc) in ('W', 'F'): |
|
width += 2 |
|
elif not unicodedata.combining(uc): |
|
width += 1 |
|
return width |
|
return len(line) |
|
|
|
|
|
def CheckStyle(filename, clean_lines, linenum, file_extension, nesting_state, |
|
error): |
|
"""Checks rules from the 'C++ style rules' section of cppguide.html. |
|
|
|
Most of these rules are hard to test (naming, comment style), but we |
|
do what we can. In particular we check for 2-space indents, line lengths, |
|
tab usage, spaces inside code, etc. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
file_extension: The extension (without the dot) of the filename. |
|
nesting_state: A _NestingState instance which maintains information about |
|
the current stack of nested blocks being parsed. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
|
|
|
|
raw_lines = clean_lines.lines_without_raw_strings |
|
line = raw_lines[linenum] |
|
|
|
if line.find('\t') != -1: |
|
error(filename, linenum, 'whitespace/tab', 1, |
|
'Tab found; better to use spaces') |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
initial_spaces = 0 |
|
cleansed_line = clean_lines.elided[linenum] |
|
while initial_spaces < len(line) and line[initial_spaces] == ' ': |
|
initial_spaces += 1 |
|
if line and line[-1].isspace(): |
|
error(filename, linenum, 'whitespace/end_of_line', 4, |
|
'Line ends in whitespace. Consider deleting these extra spaces.') |
|
|
|
elif ((initial_spaces == 1 or initial_spaces == 3) and |
|
not Match(r'\s*\w+\s*:\s*$', cleansed_line)): |
|
error(filename, linenum, 'whitespace/indent', 3, |
|
'Weird number of spaces at line-start. ' |
|
'Are you using a 2-space indent?') |
|
|
|
|
|
is_header_guard = False |
|
if file_extension == 'h': |
|
cppvar = GetHeaderGuardCPPVariable(filename) |
|
if (line.startswith('#ifndef %s' % cppvar) or |
|
line.startswith('#define %s' % cppvar) or |
|
line.startswith('#endif // %s' % cppvar)): |
|
is_header_guard = True |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if (not line.startswith('#include') and not is_header_guard and |
|
not Match(r'^\s*//.*http(s?)://\S*$', line) and |
|
not Match(r'^// \$Id:.*#[0-9]+ \$$', line)): |
|
line_width = GetLineWidth(line) |
|
extended_length = int((_line_length * 1.25)) |
|
if line_width > extended_length: |
|
error(filename, linenum, 'whitespace/line_length', 4, |
|
'Lines should very rarely be longer than %i characters' % |
|
extended_length) |
|
elif line_width > _line_length: |
|
error(filename, linenum, 'whitespace/line_length', 2, |
|
'Lines should be <= %i characters long' % _line_length) |
|
|
|
if (cleansed_line.count(';') > 1 and |
|
|
|
cleansed_line.find('for') == -1 and |
|
(GetPreviousNonBlankLine(clean_lines, linenum)[0].find('for') == -1 or |
|
GetPreviousNonBlankLine(clean_lines, linenum)[0].find(';') != -1) and |
|
|
|
not ((cleansed_line.find('case ') != -1 or |
|
cleansed_line.find('default:') != -1) and |
|
cleansed_line.find('break;') != -1)): |
|
error(filename, linenum, 'whitespace/newline', 0, |
|
'More than one command on the same line') |
|
|
|
|
|
CheckBraces(filename, clean_lines, linenum, error) |
|
CheckEmptyBlockBody(filename, clean_lines, linenum, error) |
|
CheckAccess(filename, clean_lines, linenum, nesting_state, error) |
|
CheckSpacing(filename, clean_lines, linenum, nesting_state, error) |
|
CheckCheck(filename, clean_lines, linenum, error) |
|
CheckAltTokens(filename, clean_lines, linenum, error) |
|
classinfo = nesting_state.InnermostClass() |
|
if classinfo: |
|
CheckSectionSpacing(filename, clean_lines, classinfo, linenum, error) |
|
|
|
|
|
_RE_PATTERN_INCLUDE_NEW_STYLE = re.compile(r'#include +"[^/]+\.h"') |
|
_RE_PATTERN_INCLUDE = re.compile(r'^\s*#\s*include\s*([<"])([^>"]*)[>"].*$') |
|
|
|
|
|
|
|
|
|
|
|
_RE_FIRST_COMPONENT = re.compile(r'^[^-_.]+') |
|
|
|
|
|
def _DropCommonSuffixes(filename): |
|
"""Drops common suffixes like _test.cc or -inl.h from filename. |
|
|
|
For example: |
|
>>> _DropCommonSuffixes('foo/foo-inl.h') |
|
'foo/foo' |
|
>>> _DropCommonSuffixes('foo/bar/foo.cc') |
|
'foo/bar/foo' |
|
>>> _DropCommonSuffixes('foo/foo_internal.h') |
|
'foo/foo' |
|
>>> _DropCommonSuffixes('foo/foo_unusualinternal.h') |
|
'foo/foo_unusualinternal' |
|
|
|
Args: |
|
filename: The input filename. |
|
|
|
Returns: |
|
The filename with the common suffix removed. |
|
""" |
|
for suffix in ('test.cc', 'regtest.cc', 'unittest.cc', |
|
'inl.h', 'impl.h', 'internal.h'): |
|
if (filename.endswith(suffix) and len(filename) > len(suffix) and |
|
filename[-len(suffix) - 1] in ('-', '_')): |
|
return filename[:-len(suffix) - 1] |
|
return os.path.splitext(filename)[0] |
|
|
|
|
|
def _IsTestFilename(filename): |
|
"""Determines if the given filename has a suffix that identifies it as a test. |
|
|
|
Args: |
|
filename: The input filename. |
|
|
|
Returns: |
|
True if 'filename' looks like a test, False otherwise. |
|
""" |
|
if (filename.endswith('_test.cc') or |
|
filename.endswith('_unittest.cc') or |
|
filename.endswith('_regtest.cc')): |
|
return True |
|
else: |
|
return False |
|
|
|
|
|
def _ClassifyInclude(fileinfo, include, is_system): |
|
"""Figures out what kind of header 'include' is. |
|
|
|
Args: |
|
fileinfo: The current file cpplint is running over. A FileInfo instance. |
|
include: The path to a #included file. |
|
is_system: True if the #include used <> rather than "". |
|
|
|
Returns: |
|
One of the _XXX_HEADER constants. |
|
|
|
For example: |
|
>>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'stdio.h', True) |
|
_C_SYS_HEADER |
|
>>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'string', True) |
|
_CPP_SYS_HEADER |
|
>>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/foo.h', False) |
|
_LIKELY_MY_HEADER |
|
>>> _ClassifyInclude(FileInfo('foo/foo_unknown_extension.cc'), |
|
... 'bar/foo_other_ext.h', False) |
|
_POSSIBLE_MY_HEADER |
|
>>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/bar.h', False) |
|
_OTHER_HEADER |
|
""" |
|
|
|
|
|
is_cpp_h = include in _CPP_HEADERS |
|
|
|
if is_system: |
|
if is_cpp_h: |
|
return _CPP_SYS_HEADER |
|
else: |
|
return _C_SYS_HEADER |
|
|
|
|
|
|
|
|
|
target_dir, target_base = ( |
|
os.path.split(_DropCommonSuffixes(fileinfo.RepositoryName()))) |
|
include_dir, include_base = os.path.split(_DropCommonSuffixes(include)) |
|
if target_base == include_base and ( |
|
include_dir == target_dir or |
|
include_dir == os.path.normpath(target_dir + '/../public')): |
|
return _LIKELY_MY_HEADER |
|
|
|
|
|
|
|
|
|
|
|
target_first_component = _RE_FIRST_COMPONENT.match(target_base) |
|
include_first_component = _RE_FIRST_COMPONENT.match(include_base) |
|
if (target_first_component and include_first_component and |
|
target_first_component.group(0) == |
|
include_first_component.group(0)): |
|
return _POSSIBLE_MY_HEADER |
|
|
|
return _OTHER_HEADER |
|
|
|
|
|
|
|
def CheckIncludeLine(filename, clean_lines, linenum, include_state, error): |
|
"""Check rules that are applicable to #include lines. |
|
|
|
Strings on #include lines are NOT removed from elided line, to make |
|
certain tasks easier. However, to prevent false positives, checks |
|
applicable to #include lines in CheckLanguage must be put here. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
include_state: An _IncludeState instance in which the headers are inserted. |
|
error: The function to call with any errors found. |
|
""" |
|
fileinfo = FileInfo(filename) |
|
|
|
line = clean_lines.lines[linenum] |
|
|
|
|
|
if _RE_PATTERN_INCLUDE_NEW_STYLE.search(line): |
|
error(filename, linenum, 'build/include_dir', 4, |
|
'Include the directory when naming .h files') |
|
|
|
|
|
|
|
|
|
match = _RE_PATTERN_INCLUDE.search(line) |
|
if match: |
|
include = match.group(2) |
|
is_system = (match.group(1) == '<') |
|
if include in include_state: |
|
error(filename, linenum, 'build/include', 4, |
|
'"%s" already included at %s:%s' % |
|
(include, filename, include_state[include])) |
|
else: |
|
include_state[include] = linenum |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
error_message = include_state.CheckNextIncludeOrder( |
|
_ClassifyInclude(fileinfo, include, is_system)) |
|
if error_message: |
|
error(filename, linenum, 'build/include_order', 4, |
|
'%s. Should be: %s.h, c system, c++ system, other.' % |
|
(error_message, fileinfo.BaseName())) |
|
canonical_include = include_state.CanonicalizeAlphabeticalOrder(include) |
|
if not include_state.IsInAlphabeticalOrder( |
|
clean_lines, linenum, canonical_include): |
|
error(filename, linenum, 'build/include_alpha', 4, |
|
'Include "%s" not in alphabetical order' % include) |
|
include_state.SetLastHeader(canonical_include) |
|
|
|
|
|
match = _RE_PATTERN_INCLUDE.match(line) |
|
if match: |
|
include = match.group(2) |
|
if Match(r'(f|ind|io|i|o|parse|pf|stdio|str|)?stream$', include): |
|
|
|
if not _IsTestFilename(filename): |
|
error(filename, linenum, 'readability/streams', 3, |
|
'Streams are highly discouraged.') |
|
|
|
|
|
def _GetTextInside(text, start_pattern): |
|
r"""Retrieves all the text between matching open and close parentheses. |
|
|
|
Given a string of lines and a regular expression string, retrieve all the text |
|
following the expression and between opening punctuation symbols like |
|
(, [, or {, and the matching close-punctuation symbol. This properly nested |
|
occurrences of the punctuations, so for the text like |
|
printf(a(), b(c())); |
|
a call to _GetTextInside(text, r'printf\(') will return 'a(), b(c())'. |
|
start_pattern must match string having an open punctuation symbol at the end. |
|
|
|
Args: |
|
text: The lines to extract text. Its comments and strings must be elided. |
|
It can be single line and can span multiple lines. |
|
start_pattern: The regexp string indicating where to start extracting |
|
the text. |
|
Returns: |
|
The extracted text. |
|
None if either the opening string or ending punctuation could not be found. |
|
""" |
|
|
|
|
|
|
|
|
|
matching_punctuation = {'(': ')', '{': '}', '[': ']'} |
|
closing_punctuation = set(itervalues(matching_punctuation)) |
|
|
|
|
|
match = re.search(start_pattern, text, re.M) |
|
if not match: |
|
return None |
|
start_position = match.end(0) |
|
|
|
assert start_position > 0, ( |
|
'start_pattern must ends with an opening punctuation.') |
|
assert text[start_position - 1] in matching_punctuation, ( |
|
'start_pattern must ends with an opening punctuation.') |
|
|
|
punctuation_stack = [matching_punctuation[text[start_position - 1]]] |
|
position = start_position |
|
while punctuation_stack and position < len(text): |
|
if text[position] == punctuation_stack[-1]: |
|
punctuation_stack.pop() |
|
elif text[position] in closing_punctuation: |
|
|
|
return None |
|
elif text[position] in matching_punctuation: |
|
punctuation_stack.append(matching_punctuation[text[position]]) |
|
position += 1 |
|
if punctuation_stack: |
|
|
|
return None |
|
|
|
return text[start_position:position - 1] |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
_RE_PATTERN_IDENT = r'[_a-zA-Z]\w*' |
|
_RE_PATTERN_TYPE = ( |
|
r'(?:const\s+)?(?:typename\s+|class\s+|struct\s+|union\s+|enum\s+)?' |
|
r'(?:\w|' |
|
r'\s*<(?:<(?:<[^<>]*>|[^<>])*>|[^<>])*>|' |
|
r'::)+') |
|
|
|
_RE_PATTERN_REF_PARAM = re.compile( |
|
r'(' + _RE_PATTERN_TYPE + r'(?:\s*(?:\bconst\b|[*]))*\s*' |
|
r'&\s*' + _RE_PATTERN_IDENT + r')\s*(?:=[^,()]+)?[,)]') |
|
|
|
|
|
_RE_PATTERN_CONST_REF_PARAM = ( |
|
r'(?:.*\s*\bconst\s*&\s*' + _RE_PATTERN_IDENT + |
|
r'|const\s+' + _RE_PATTERN_TYPE + r'\s*&\s*' + _RE_PATTERN_IDENT + r')') |
|
|
|
|
|
def CheckLanguage(filename, clean_lines, linenum, file_extension, |
|
include_state, nesting_state, error): |
|
"""Checks rules from the 'C++ language rules' section of cppguide.html. |
|
|
|
Some of these rules are hard to test (function overloading, using |
|
uint32 inappropriately), but we do the best we can. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
file_extension: The extension (without the dot) of the filename. |
|
include_state: An _IncludeState instance in which the headers are inserted. |
|
nesting_state: A _NestingState instance which maintains information about |
|
the current stack of nested blocks being parsed. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
|
|
line = clean_lines.elided[linenum] |
|
if not line: |
|
return |
|
|
|
match = _RE_PATTERN_INCLUDE.search(line) |
|
if match: |
|
CheckIncludeLine(filename, clean_lines, linenum, include_state, error) |
|
return |
|
|
|
|
|
|
|
if Match(r'^\s*#\s*(?:ifdef|elif|else|endif)\b', line): |
|
include_state.ResetSection() |
|
|
|
|
|
fullname = os.path.abspath(filename).replace('\\', '/') |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
match = Search( |
|
r'(\bnew\s+)?\b' |
|
r'(int|float|double|bool|char|int32|uint32|int64|uint64)' |
|
r'(\([^)].*)', line) |
|
if match: |
|
matched_new = match.group(1) |
|
matched_type = match.group(2) |
|
matched_funcptr = match.group(3) |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if (matched_new is None and |
|
not (Match(r'^\s*MOCK_(CONST_)?METHOD\d+(_T)?\(', line) or |
|
Search(r'\bMockCallback<.*>', line) or |
|
Search(r'\bstd::function<.*>', line)) and |
|
not (matched_funcptr and |
|
Match(r'\((?:[^() ]+::\s*\*\s*)?[^() ]+\)\s*\(', |
|
matched_funcptr))): |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if (linenum < 2 or |
|
not (Match(r'^\s*MOCK_(?:CONST_)?METHOD\d+(?:_T)?\((?:\S+,)?\s*$', |
|
clean_lines.elided[linenum - 1]) or |
|
Match(r'^\s*MOCK_(?:CONST_)?METHOD\d+(?:_T)?\(\s*$', |
|
clean_lines.elided[linenum - 2]))): |
|
error(filename, linenum, 'readability/casting', 4, |
|
'Using deprecated casting style. ' |
|
'Use static_cast<%s>(...) instead' % |
|
matched_type) |
|
|
|
CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum], |
|
'static_cast', |
|
r'\((int|float|double|bool|char|u?int(16|32|64))\)', error) |
|
|
|
|
|
|
|
|
|
|
|
if CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum], |
|
'const_cast', r'\((char\s?\*+\s?)\)\s*"', error): |
|
pass |
|
else: |
|
|
|
CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum], |
|
'reinterpret_cast', r'\((\w+\s?\*+\s?)\)', error) |
|
|
|
|
|
|
|
|
|
match = Search( |
|
r'(?:&\(([^)]+)\)[\w(])|' |
|
r'(?:&(static|dynamic|down|reinterpret)_cast\b)', line) |
|
if match and match.group(1) != '*': |
|
error(filename, linenum, 'runtime/casting', 4, |
|
('Are you taking an address of a cast? ' |
|
'This is dangerous: could be a temp var. ' |
|
'Take the address before doing the cast, rather than after')) |
|
|
|
|
|
|
|
|
|
if linenum + 1 < clean_lines.NumLines(): |
|
extended_line = line + clean_lines.elided[linenum + 1] |
|
else: |
|
extended_line = line |
|
|
|
|
|
|
|
|
|
match = Match( |
|
r'((?:|static +)(?:|const +))string +([a-zA-Z0-9_:]+)\b(.*)', |
|
line) |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if (match and |
|
not Search(r'\boperator\W', line) and |
|
not Match(r'\s*(<.*>)?(::[a-zA-Z0-9_]+)?\s*\(([^"]|$)', match.group(3))): |
|
error(filename, linenum, 'runtime/string', 4, |
|
'For a static/global string constant, use a C style string instead: ' |
|
'"%schar %s[]".' % |
|
(match.group(1), match.group(2))) |
|
|
|
if Search(r'\b([A-Za-z0-9_]*_)\(\1\)', line): |
|
error(filename, linenum, 'runtime/init', 4, |
|
'You seem to be initializing a member variable with itself.') |
|
|
|
if file_extension == 'h': |
|
|
|
|
|
|
|
|
|
|
|
pass |
|
|
|
|
|
|
|
if Search(r'\bshort port\b', line): |
|
if not Search(r'\bunsigned short port\b', line): |
|
error(filename, linenum, 'runtime/int', 4, |
|
'Use "unsigned short" for ports, not "short"') |
|
else: |
|
match = Search(r'\b(short|long(?! +double)|long long)\b', line) |
|
if match: |
|
error(filename, linenum, 'runtime/int', 4, |
|
'Use int16/int64/etc, rather than the C type %s' % match.group(1)) |
|
|
|
|
|
match = Search(r'snprintf\s*\(([^,]*),\s*([0-9]*)\s*,', line) |
|
if match and match.group(2) != '0': |
|
|
|
error(filename, linenum, 'runtime/printf', 3, |
|
'If you can, use sizeof(%s) instead of %s as the 2nd arg ' |
|
'to snprintf.' % (match.group(1), match.group(2))) |
|
|
|
|
|
if Search(r'\bsprintf\b', line): |
|
error(filename, linenum, 'runtime/printf', 5, |
|
'Never use sprintf. Use snprintf instead.') |
|
match = Search(r'\b(strcpy|strcat)\b', line) |
|
if match: |
|
error(filename, linenum, 'runtime/printf', 4, |
|
'Almost always, snprintf is better than %s' % match.group(1)) |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if Search(r'\boperator\s*&\s*\(\s*\)', line): |
|
error(filename, linenum, 'runtime/operator', 4, |
|
'Unary operator& is dangerous. Do not use it.') |
|
|
|
|
|
|
|
if Search(r'\}\s*if\s*\(', line): |
|
error(filename, linenum, 'readability/braces', 4, |
|
'Did you mean "else if"? If not, start a new line for "if".') |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
printf_args = _GetTextInside(line, r'(?i)\b(string)?printf\s*\(') |
|
if printf_args: |
|
match = Match(r'([\w.\->()]+)$', printf_args) |
|
if match and match.group(1) != '__VA_ARGS__': |
|
function_name = re.search(r'\b((?:string)?printf)\s*\(', |
|
line, re.I).group(1) |
|
error(filename, linenum, 'runtime/printf', 4, |
|
'Potential format string bug. Do %s("%%s", %s) instead.' |
|
% (function_name, match.group(1))) |
|
|
|
|
|
match = Search(r'memset\s*\(([^,]*),\s*([^,]*),\s*0\s*\)', line) |
|
if match and not Match(r"^''|-?[0-9]+|0x[0-9A-Fa-f]$", match.group(2)): |
|
error(filename, linenum, 'runtime/memset', 4, |
|
'Did you mean "memset(%s, 0, %s)"?' |
|
% (match.group(1), match.group(2))) |
|
|
|
if Search(r'\busing namespace\b', line): |
|
error(filename, linenum, 'build/namespaces', 5, |
|
'Do not use namespace using-directives. ' |
|
'Use using-declarations instead.') |
|
|
|
|
|
match = Match(r'\s*(.+::)?(\w+) [a-z]\w*\[(.+)];', line) |
|
if (match and match.group(2) != 'return' and match.group(2) != 'delete' and |
|
match.group(3).find(']') == -1): |
|
|
|
|
|
|
|
tokens = re.split(r'\s|\+|\-|\*|\/|<<|>>]', match.group(3)) |
|
is_const = True |
|
skip_next = False |
|
for tok in tokens: |
|
if skip_next: |
|
skip_next = False |
|
continue |
|
|
|
if Search(r'sizeof\(.+\)', tok): continue |
|
if Search(r'arraysize\(\w+\)', tok): continue |
|
|
|
tok = tok.lstrip('(') |
|
tok = tok.rstrip(')') |
|
if not tok: continue |
|
if Match(r'\d+', tok): continue |
|
if Match(r'0[xX][0-9a-fA-F]+', tok): continue |
|
if Match(r'k[A-Z0-9]\w*', tok): continue |
|
if Match(r'(.+::)?k[A-Z0-9]\w*', tok): continue |
|
if Match(r'(.+::)?[A-Z][A-Z0-9_]*', tok): continue |
|
|
|
|
|
|
|
if tok.startswith('sizeof'): |
|
skip_next = True |
|
continue |
|
is_const = False |
|
break |
|
if not is_const: |
|
error(filename, linenum, 'runtime/arrays', 1, |
|
'Do not use variable-length arrays. Use an appropriately named ' |
|
"('k' followed by CamelCase) compile-time constant for the size.") |
|
|
|
|
|
|
|
|
|
match = Match( |
|
(r'\s*' |
|
r'(DISALLOW_(EVIL_CONSTRUCTORS|COPY_AND_ASSIGN|IMPLICIT_CONSTRUCTORS))' |
|
r'\(.*\);$'), |
|
line) |
|
if match and linenum + 1 < clean_lines.NumLines(): |
|
next_line = clean_lines.elided[linenum + 1] |
|
|
|
|
|
|
|
|
|
|
|
|
|
if not Search(r'^\s*}[\w\*,\s]*;', next_line): |
|
error(filename, linenum, 'readability/constructors', 3, |
|
match.group(1) + ' should be the last thing in the class') |
|
|
|
|
|
|
|
|
|
if (file_extension == 'h' |
|
and Search(r'\bnamespace\s*{', line) |
|
and line[-1] != '\\'): |
|
error(filename, linenum, 'build/namespaces', 4, |
|
'Do not use unnamed namespaces in header files. See ' |
|
'http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces' |
|
' for more information.') |
|
|
|
def CheckForNonConstReference(filename, clean_lines, linenum, |
|
nesting_state, error): |
|
"""Check for non-const references. |
|
|
|
Separate from CheckLanguage since it scans backwards from current |
|
line, instead of scanning forward. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
nesting_state: A _NestingState instance which maintains information about |
|
the current stack of nested blocks being parsed. |
|
error: The function to call with any errors found. |
|
""" |
|
|
|
line = clean_lines.elided[linenum] |
|
if '&' not in line: |
|
return |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if linenum > 1: |
|
previous = None |
|
if Match(r'\s*::(?:[\w<>]|::)+\s*&\s*\S', line): |
|
|
|
previous = Search(r'\b((?:const\s*)?(?:[\w<>]|::)+[\w<>])\s*$', |
|
clean_lines.elided[linenum - 1]) |
|
elif Match(r'\s*[a-zA-Z_]([\w<>]|::)+\s*&\s*\S', line): |
|
|
|
previous = Search(r'\b((?:const\s*)?(?:[\w<>]|::)+::)\s*$', |
|
clean_lines.elided[linenum - 1]) |
|
if previous: |
|
line = previous.group(1) + line.lstrip() |
|
else: |
|
|
|
endpos = line.rfind('>') |
|
if endpos > -1: |
|
(_, startline, startpos) = ReverseCloseExpression( |
|
clean_lines, linenum, endpos) |
|
if startpos > -1 and startline < linenum: |
|
|
|
|
|
line = '' |
|
for i in xrange(startline, linenum + 1): |
|
line += clean_lines.elided[i].strip() |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
check_params = False |
|
if not nesting_state.stack: |
|
check_params = True |
|
elif (isinstance(nesting_state.stack[-1], _ClassInfo) or |
|
isinstance(nesting_state.stack[-1], _NamespaceInfo)): |
|
check_params = True |
|
elif Match(r'.*{\s*$', line): |
|
if (len(nesting_state.stack) == 1 or |
|
isinstance(nesting_state.stack[-2], _ClassInfo) or |
|
isinstance(nesting_state.stack[-2], _NamespaceInfo)): |
|
check_params = True |
|
|
|
|
|
|
|
|
|
|
|
|
|
whitelisted_functions = (r'(?:[sS]wap(?:<\w:+>)?|' |
|
r'operator\s*[<>][<>]|' |
|
r'static_assert|COMPILE_ASSERT' |
|
r')\s*\(') |
|
if Search(whitelisted_functions, line): |
|
check_params = False |
|
elif not Search(r'\S+\([^)]*$', line): |
|
|
|
|
|
|
|
for i in xrange(2): |
|
if (linenum > i and |
|
Search(whitelisted_functions, clean_lines.elided[linenum - i - 1])): |
|
check_params = False |
|
break |
|
|
|
if check_params: |
|
decls = ReplaceAll(r'{[^}]*}', ' ', line) |
|
for parameter in re.findall(_RE_PATTERN_REF_PARAM, decls): |
|
if not Match(_RE_PATTERN_CONST_REF_PARAM, parameter): |
|
error(filename, linenum, 'runtime/references', 2, |
|
'Is this a non-const reference? ' |
|
'If so, make const or use a pointer: ' + |
|
ReplaceAll(' *<', '<', parameter)) |
|
|
|
|
|
def CheckCStyleCast(filename, linenum, line, raw_line, cast_type, pattern, |
|
error): |
|
"""Checks for a C-style cast by looking for the pattern. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
linenum: The number of the line to check. |
|
line: The line of code to check. |
|
raw_line: The raw line of code to check, with comments. |
|
cast_type: The string for the C++ cast to recommend. This is either |
|
reinterpret_cast, static_cast, or const_cast, depending. |
|
pattern: The regular expression used to find C-style casts. |
|
error: The function to call with any errors found. |
|
|
|
Returns: |
|
True if an error was emitted. |
|
False otherwise. |
|
""" |
|
match = Search(pattern, line) |
|
if not match: |
|
return False |
|
|
|
|
|
sizeof_match = Match(r'.*sizeof\s*$', line[0:match.start(1) - 1]) |
|
if sizeof_match: |
|
return False |
|
|
|
|
|
if (line[0:match.start(1) - 1].endswith(' operator++') or |
|
line[0:match.start(1) - 1].endswith(' operator--')): |
|
return False |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
remainder = line[match.end(0):] |
|
if Match(r'^\s*(?:;|const\b|throw\b|=|>|\{|\))', remainder): |
|
|
|
|
|
|
|
if Match(r'^\s*>', remainder): |
|
return False |
|
|
|
|
|
|
|
|
|
|
|
matched_zero = Match(r'^\s=\s*(\S+)\s*;', remainder) |
|
if matched_zero and matched_zero.group(1) != '0': |
|
return False |
|
|
|
|
|
|
|
if Match(r'.*\)\s*$', line[0:match.start(0)]): |
|
return False |
|
|
|
|
|
|
|
if '/*' in raw_line: |
|
return False |
|
|
|
|
|
error(filename, linenum, 'readability/function', 3, |
|
'All parameters should be named in a function') |
|
return True |
|
|
|
|
|
error(filename, linenum, 'readability/casting', 4, |
|
'Using C-style cast. Use %s<%s>(...) instead' % |
|
(cast_type, match.group(1))) |
|
|
|
return True |
|
|
|
|
|
_HEADERS_CONTAINING_TEMPLATES = ( |
|
('<deque>', ('deque',)), |
|
('<functional>', ('unary_function', 'binary_function', |
|
'plus', 'minus', 'multiplies', 'divides', 'modulus', |
|
'negate', |
|
'equal_to', 'not_equal_to', 'greater', 'less', |
|
'greater_equal', 'less_equal', |
|
'logical_and', 'logical_or', 'logical_not', |
|
'unary_negate', 'not1', 'binary_negate', 'not2', |
|
'bind1st', 'bind2nd', |
|
'pointer_to_unary_function', |
|
'pointer_to_binary_function', |
|
'ptr_fun', |
|
'mem_fun_t', 'mem_fun', 'mem_fun1_t', 'mem_fun1_ref_t', |
|
'mem_fun_ref_t', |
|
'const_mem_fun_t', 'const_mem_fun1_t', |
|
'const_mem_fun_ref_t', 'const_mem_fun1_ref_t', |
|
'mem_fun_ref', |
|
)), |
|
('<limits>', ('numeric_limits',)), |
|
('<list>', ('list',)), |
|
('<map>', ('map', 'multimap',)), |
|
('<memory>', ('allocator',)), |
|
('<queue>', ('queue', 'priority_queue',)), |
|
('<set>', ('set', 'multiset',)), |
|
('<stack>', ('stack',)), |
|
('<string>', ('char_traits', 'basic_string',)), |
|
('<utility>', ('pair',)), |
|
('<vector>', ('vector',)), |
|
|
|
|
|
|
|
('<hash_map>', ('hash_map', 'hash_multimap',)), |
|
('<hash_set>', ('hash_set', 'hash_multiset',)), |
|
('<slist>', ('slist',)), |
|
) |
|
|
|
_RE_PATTERN_STRING = re.compile(r'\bstring\b') |
|
|
|
_re_pattern_algorithm_header = [] |
|
for _template in ('copy', 'max', 'min', 'min_element', 'sort', 'swap', |
|
'transform'): |
|
|
|
|
|
_re_pattern_algorithm_header.append( |
|
(re.compile(r'[^>.]\b' + _template + r'(<.*?>)?\([^\)]'), |
|
_template, |
|
'<algorithm>')) |
|
|
|
_re_pattern_templates = [] |
|
for _header, _templates in _HEADERS_CONTAINING_TEMPLATES: |
|
for _template in _templates: |
|
_re_pattern_templates.append( |
|
(re.compile(r'(\<|\b)' + _template + r'\s*\<'), |
|
_template + '<>', |
|
_header)) |
|
|
|
|
|
def FilesBelongToSameModule(filename_cc, filename_h): |
|
"""Check if these two filenames belong to the same module. |
|
|
|
The concept of a 'module' here is a as follows: |
|
foo.h, foo-inl.h, foo.cc, foo_test.cc and foo_unittest.cc belong to the |
|
same 'module' if they are in the same directory. |
|
some/path/public/xyzzy and some/path/internal/xyzzy are also considered |
|
to belong to the same module here. |
|
|
|
If the filename_cc contains a longer path than the filename_h, for example, |
|
'/absolute/path/to/base/sysinfo.cc', and this file would include |
|
'base/sysinfo.h', this function also produces the prefix needed to open the |
|
header. This is used by the caller of this function to more robustly open the |
|
header file. We don't have access to the real include paths in this context, |
|
so we need this guesswork here. |
|
|
|
Known bugs: tools/base/bar.cc and base/bar.h belong to the same module |
|
according to this implementation. Because of this, this function gives |
|
some false positives. This should be sufficiently rare in practice. |
|
|
|
Args: |
|
filename_cc: is the path for the .cc file |
|
filename_h: is the path for the header path |
|
|
|
Returns: |
|
Tuple with a bool and a string: |
|
bool: True if filename_cc and filename_h belong to the same module. |
|
string: the additional prefix needed to open the header file. |
|
""" |
|
|
|
if not filename_cc.endswith('.cc'): |
|
return (False, '') |
|
filename_cc = filename_cc[:-len('.cc')] |
|
if filename_cc.endswith('_unittest'): |
|
filename_cc = filename_cc[:-len('_unittest')] |
|
elif filename_cc.endswith('_test'): |
|
filename_cc = filename_cc[:-len('_test')] |
|
filename_cc = filename_cc.replace('/public/', '/') |
|
filename_cc = filename_cc.replace('/internal/', '/') |
|
|
|
if not filename_h.endswith('.h'): |
|
return (False, '') |
|
filename_h = filename_h[:-len('.h')] |
|
if filename_h.endswith('-inl'): |
|
filename_h = filename_h[:-len('-inl')] |
|
filename_h = filename_h.replace('/public/', '/') |
|
filename_h = filename_h.replace('/internal/', '/') |
|
|
|
files_belong_to_same_module = filename_cc.endswith(filename_h) |
|
common_path = '' |
|
if files_belong_to_same_module: |
|
common_path = filename_cc[:-len(filename_h)] |
|
return files_belong_to_same_module, common_path |
|
|
|
|
|
def UpdateIncludeState(filename, include_state, io=codecs): |
|
"""Fill up the include_state with new includes found from the file. |
|
|
|
Args: |
|
filename: the name of the header to read. |
|
include_state: an _IncludeState instance in which the headers are inserted. |
|
io: The io factory to use to read the file. Provided for testability. |
|
|
|
Returns: |
|
True if a header was successfully added. False otherwise. |
|
""" |
|
headerfile = None |
|
try: |
|
headerfile = io.open(filename, 'r', 'utf8', 'replace') |
|
except IOError: |
|
return False |
|
linenum = 0 |
|
for line in headerfile: |
|
linenum += 1 |
|
clean_line = CleanseComments(line) |
|
match = _RE_PATTERN_INCLUDE.search(clean_line) |
|
if match: |
|
include = match.group(2) |
|
|
|
|
|
include_state.setdefault(include, '%s:%d' % (filename, linenum)) |
|
return True |
|
|
|
|
|
def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error, |
|
io=codecs): |
|
"""Reports for missing stl includes. |
|
|
|
This function will output warnings to make sure you are including the headers |
|
necessary for the stl containers and functions that you use. We only give one |
|
reason to include a header. For example, if you use both equal_to<> and |
|
less<> in a .h file, only one (the latter in the file) of these will be |
|
reported as a reason to include the <functional>. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
include_state: An _IncludeState instance. |
|
error: The function to call with any errors found. |
|
io: The IO factory to use to read the header file. Provided for unittest |
|
injection. |
|
""" |
|
required = {} |
|
|
|
|
|
for linenum in xrange(clean_lines.NumLines()): |
|
line = clean_lines.elided[linenum] |
|
if not line or line[0] == '#': |
|
continue |
|
|
|
|
|
matched = _RE_PATTERN_STRING.search(line) |
|
if matched: |
|
|
|
|
|
prefix = line[:matched.start()] |
|
if prefix.endswith('std::') or not prefix.endswith('::'): |
|
required['<string>'] = (linenum, 'string') |
|
|
|
for pattern, template, header in _re_pattern_algorithm_header: |
|
if pattern.search(line): |
|
required[header] = (linenum, template) |
|
|
|
|
|
if not '<' in line: |
|
continue |
|
|
|
for pattern, template, header in _re_pattern_templates: |
|
if pattern.search(line): |
|
required[header] = (linenum, template) |
|
|
|
|
|
|
|
|
|
include_state = include_state.copy() |
|
|
|
|
|
header_found = False |
|
|
|
|
|
abs_filename = FileInfo(filename).FullName() |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
abs_filename = re.sub(r'_flymake\.cc$', '.cc', abs_filename) |
|
|
|
|
|
|
|
header_keys = include_state.keys() |
|
for header in header_keys: |
|
(same_module, common_path) = FilesBelongToSameModule(abs_filename, header) |
|
fullpath = common_path + header |
|
if same_module and UpdateIncludeState(fullpath, include_state, io): |
|
header_found = True |
|
|
|
|
|
|
|
|
|
|
|
|
|
if filename.endswith('.cc') and not header_found: |
|
return |
|
|
|
|
|
for required_header_unstripped in required: |
|
template = required[required_header_unstripped][1] |
|
if required_header_unstripped.strip('<>"') not in include_state: |
|
error(filename, required[required_header_unstripped][0], |
|
'build/include_what_you_use', 4, |
|
'Add #include ' + required_header_unstripped + ' for ' + template) |
|
|
|
|
|
_RE_PATTERN_EXPLICIT_MAKEPAIR = re.compile(r'\bmake_pair\s*<') |
|
|
|
|
|
def CheckMakePairUsesDeduction(filename, clean_lines, linenum, error): |
|
"""Check that make_pair's template arguments are deduced. |
|
|
|
G++ 4.6 in C++0x mode fails badly if make_pair's template arguments are |
|
specified explicitly, and such use isn't intended in any case. |
|
|
|
Args: |
|
filename: The name of the current file. |
|
clean_lines: A CleansedLines instance containing the file. |
|
linenum: The number of the line to check. |
|
error: The function to call with any errors found. |
|
""" |
|
line = clean_lines.elided[linenum] |
|
match = _RE_PATTERN_EXPLICIT_MAKEPAIR.search(line) |
|
if match: |
|
error(filename, linenum, 'build/explicit_make_pair', |
|
4, |
|
'For C++11-compatibility, omit template arguments from make_pair' |
|
' OR use pair directly OR if appropriate, construct a pair directly') |
|
|
|
|
|
def ProcessLine(filename, file_extension, clean_lines, line, |
|
include_state, function_state, nesting_state, error, |
|
extra_check_functions=[]): |
|
"""Processes a single line in the file. |
|
|
|
Args: |
|
filename: Filename of the file that is being processed. |
|
file_extension: The extension (dot not included) of the file. |
|
clean_lines: An array of strings, each representing a line of the file, |
|
with comments stripped. |
|
line: Number of line being processed. |
|
include_state: An _IncludeState instance in which the headers are inserted. |
|
function_state: A _FunctionState instance which counts function lines, etc. |
|
nesting_state: A _NestingState instance which maintains information about |
|
the current stack of nested blocks being parsed. |
|
error: A callable to which errors are reported, which takes 4 arguments: |
|
filename, line number, error level, and message |
|
extra_check_functions: An array of additional check functions that will be |
|
run on each source line. Each function takes 4 |
|
arguments: filename, clean_lines, line, error |
|
""" |
|
raw_lines = clean_lines.raw_lines |
|
ParseNolintSuppressions(filename, raw_lines[line], line, error) |
|
nesting_state.Update(filename, clean_lines, line, error) |
|
if nesting_state.stack and nesting_state.stack[-1].inline_asm != _NO_ASM: |
|
return |
|
CheckForFunctionLengths(filename, clean_lines, line, function_state, error) |
|
CheckForMultilineCommentsAndStrings(filename, clean_lines, line, error) |
|
CheckStyle(filename, clean_lines, line, file_extension, nesting_state, error) |
|
CheckLanguage(filename, clean_lines, line, file_extension, include_state, |
|
nesting_state, error) |
|
CheckForNonConstReference(filename, clean_lines, line, nesting_state, error) |
|
CheckForNonStandardConstructs(filename, clean_lines, line, |
|
nesting_state, error) |
|
CheckVlogArguments(filename, clean_lines, line, error) |
|
CheckCaffeAlternatives(filename, clean_lines, line, error) |
|
CheckCaffeDataLayerSetUp(filename, clean_lines, line, error) |
|
CheckCaffeRandom(filename, clean_lines, line, error) |
|
CheckPosixThreading(filename, clean_lines, line, error) |
|
CheckInvalidIncrement(filename, clean_lines, line, error) |
|
CheckMakePairUsesDeduction(filename, clean_lines, line, error) |
|
for check_fn in extra_check_functions: |
|
check_fn(filename, clean_lines, line, error) |
|
|
|
def ProcessFileData(filename, file_extension, lines, error, |
|
extra_check_functions=[]): |
|
"""Performs lint checks and reports any errors to the given error function. |
|
|
|
Args: |
|
filename: Filename of the file that is being processed. |
|
file_extension: The extension (dot not included) of the file. |
|
lines: An array of strings, each representing a line of the file, with the |
|
last element being empty if the file is terminated with a newline. |
|
error: A callable to which errors are reported, which takes 4 arguments: |
|
filename, line number, error level, and message |
|
extra_check_functions: An array of additional check functions that will be |
|
run on each source line. Each function takes 4 |
|
arguments: filename, clean_lines, line, error |
|
""" |
|
lines = (['// marker so line numbers and indices both start at 1'] + lines + |
|
['// marker so line numbers end in a known way']) |
|
|
|
include_state = _IncludeState() |
|
function_state = _FunctionState() |
|
nesting_state = _NestingState() |
|
|
|
ResetNolintSuppressions() |
|
|
|
CheckForCopyright(filename, lines, error) |
|
|
|
if file_extension == 'h': |
|
CheckForHeaderGuard(filename, lines, error) |
|
|
|
RemoveMultiLineComments(filename, lines, error) |
|
clean_lines = CleansedLines(lines) |
|
for line in xrange(clean_lines.NumLines()): |
|
ProcessLine(filename, file_extension, clean_lines, line, |
|
include_state, function_state, nesting_state, error, |
|
extra_check_functions) |
|
nesting_state.CheckCompletedBlocks(filename, error) |
|
|
|
CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error) |
|
|
|
|
|
|
|
CheckForBadCharacters(filename, lines, error) |
|
|
|
CheckForNewlineAtEOF(filename, lines, error) |
|
|
|
def ProcessFile(filename, vlevel, extra_check_functions=[]): |
|
"""Does google-lint on a single file. |
|
|
|
Args: |
|
filename: The name of the file to parse. |
|
|
|
vlevel: The level of errors to report. Every error of confidence |
|
>= verbose_level will be reported. 0 is a good default. |
|
|
|
extra_check_functions: An array of additional check functions that will be |
|
run on each source line. Each function takes 4 |
|
arguments: filename, clean_lines, line, error |
|
""" |
|
|
|
_SetVerboseLevel(vlevel) |
|
|
|
try: |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if filename == '-': |
|
lines = codecs.StreamReaderWriter(sys.stdin, |
|
codecs.getreader('utf8'), |
|
codecs.getwriter('utf8'), |
|
'replace').read().split('\n') |
|
else: |
|
lines = codecs.open(filename, 'r', 'utf8', 'replace').read().split('\n') |
|
|
|
carriage_return_found = False |
|
|
|
for linenum in range(len(lines)): |
|
if lines[linenum].endswith('\r'): |
|
lines[linenum] = lines[linenum].rstrip('\r') |
|
carriage_return_found = True |
|
|
|
except IOError: |
|
sys.stderr.write( |
|
"Skipping input '%s': Can't open for reading\n" % filename) |
|
return |
|
|
|
|
|
file_extension = filename[filename.rfind('.') + 1:] |
|
|
|
|
|
|
|
if filename != '-' and file_extension not in _valid_extensions: |
|
sys.stderr.write('Ignoring %s; not a valid file name ' |
|
'(%s)\n' % (filename, ', '.join(_valid_extensions))) |
|
else: |
|
ProcessFileData(filename, file_extension, lines, Error, |
|
extra_check_functions) |
|
if carriage_return_found and os.linesep != '\r\n': |
|
|
|
|
|
Error(filename, 0, 'whitespace/newline', 1, |
|
'One or more unexpected \\r (^M) found;' |
|
'better to use only a \\n') |
|
|
|
sys.stderr.write('Done processing %s\n' % filename) |
|
|
|
|
|
def PrintUsage(message): |
|
"""Prints a brief usage string and exits, optionally with an error message. |
|
|
|
Args: |
|
message: The optional error message. |
|
""" |
|
sys.stderr.write(_USAGE) |
|
if message: |
|
sys.exit('\nFATAL ERROR: ' + message) |
|
else: |
|
sys.exit(1) |
|
|
|
|
|
def PrintCategories(): |
|
"""Prints a list of all the error-categories used by error messages. |
|
|
|
These are the categories used to filter messages via --filter. |
|
""" |
|
sys.stderr.write(''.join(' %s\n' % cat for cat in _ERROR_CATEGORIES)) |
|
sys.exit(0) |
|
|
|
|
|
def ParseArguments(args): |
|
"""Parses the command line arguments. |
|
|
|
This may set the output format and verbosity level as side-effects. |
|
|
|
Args: |
|
args: The command line arguments: |
|
|
|
Returns: |
|
The list of filenames to lint. |
|
""" |
|
try: |
|
(opts, filenames) = getopt.getopt(args, '', ['help', 'output=', 'verbose=', |
|
'counting=', |
|
'filter=', |
|
'root=', |
|
'linelength=', |
|
'extensions=']) |
|
except getopt.GetoptError: |
|
PrintUsage('Invalid arguments.') |
|
|
|
verbosity = _VerboseLevel() |
|
output_format = _OutputFormat() |
|
filters = '' |
|
counting_style = '' |
|
|
|
for (opt, val) in opts: |
|
if opt == '--help': |
|
PrintUsage(None) |
|
elif opt == '--output': |
|
if val not in ('emacs', 'vs7', 'eclipse'): |
|
PrintUsage('The only allowed output formats are emacs, vs7 and eclipse.') |
|
output_format = val |
|
elif opt == '--verbose': |
|
verbosity = int(val) |
|
elif opt == '--filter': |
|
filters = val |
|
if not filters: |
|
PrintCategories() |
|
elif opt == '--counting': |
|
if val not in ('total', 'toplevel', 'detailed'): |
|
PrintUsage('Valid counting options are total, toplevel, and detailed') |
|
counting_style = val |
|
elif opt == '--root': |
|
global _root |
|
_root = val |
|
elif opt == '--linelength': |
|
global _line_length |
|
try: |
|
_line_length = int(val) |
|
except ValueError: |
|
PrintUsage('Line length must be digits.') |
|
elif opt == '--extensions': |
|
global _valid_extensions |
|
try: |
|
_valid_extensions = set(val.split(',')) |
|
except ValueError: |
|
PrintUsage('Extensions must be comma separated list.') |
|
|
|
if not filenames: |
|
PrintUsage('No files were specified.') |
|
|
|
_SetOutputFormat(output_format) |
|
_SetVerboseLevel(verbosity) |
|
_SetFilters(filters) |
|
_SetCountingStyle(counting_style) |
|
|
|
return filenames |
|
|
|
|
|
def main(): |
|
filenames = ParseArguments(sys.argv[1:]) |
|
|
|
|
|
|
|
if six.PY2: |
|
sys.stderr = codecs.StreamReaderWriter(sys.stderr, |
|
codecs.getreader('utf8'), |
|
codecs.getwriter('utf8'), |
|
'replace') |
|
|
|
_cpplint_state.ResetErrorCounts() |
|
for filename in filenames: |
|
ProcessFile(filename, _cpplint_state.verbose_level) |
|
_cpplint_state.PrintErrorCounts() |
|
|
|
sys.exit(_cpplint_state.error_count > 0) |
|
|
|
|
|
if __name__ == '__main__': |
|
main() |
|
|