Datasets:

spasis

/

datasets-github-issues

like 0

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1459", "html_url": "https://github.com/huggingface/datasets/pull/1459", "diff_url": "https://github.com/huggingface/datasets/pull/1459.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1459.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1459/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "cahya-wirawan", "id": 7669893, "node_id": "MDQ6VXNlcjc2Njk4OTM=", "avatar_url": "https://avatars.githubusercontent.com/u/7669893?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cahya-wirawan", "html_url": "https://github.com/cahya-wirawan", "followers_url": "https://api.github.com/users/cahya-wirawan/followers", "following_url": "https://api.github.com/users/cahya-wirawan/following{/other_user}", "gists_url": "https://api.github.com/users/cahya-wirawan/gists{/gist_id}", "starred_url": "https://api.github.com/users/cahya-wirawan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cahya-wirawan/subscriptions", "organizations_url": "https://api.github.com/users/cahya-wirawan/orgs", "repos_url": "https://api.github.com/users/cahya-wirawan/repos", "events_url": "https://api.github.com/users/cahya-wirawan/events{/privacy}", "received_events_url": "https://api.github.com/users/cahya-wirawan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1458", "html_url": "https://github.com/huggingface/datasets/pull/1458", "diff_url": "https://github.com/huggingface/datasets/pull/1458.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1458.patch", "merged_at": 1608201915000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1458/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "IvanZidov", "id": 11391118, "node_id": "MDQ6VXNlcjExMzkxMTE4", "avatar_url": "https://avatars.githubusercontent.com/u/11391118?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IvanZidov", "html_url": "https://github.com/IvanZidov", "followers_url": "https://api.github.com/users/IvanZidov/followers", "following_url": "https://api.github.com/users/IvanZidov/following{/other_user}", "gists_url": "https://api.github.com/users/IvanZidov/gists{/gist_id}", "starred_url": "https://api.github.com/users/IvanZidov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IvanZidov/subscriptions", "organizations_url": "https://api.github.com/users/IvanZidov/orgs", "repos_url": "https://api.github.com/users/IvanZidov/repos", "events_url": "https://api.github.com/users/IvanZidov/events{/privacy}", "received_events_url": "https://api.github.com/users/IvanZidov/received_events", "type": "User", "site_admin": false }

[]

[]

[ "duplicate" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1457", "html_url": "https://github.com/huggingface/datasets/pull/1457", "diff_url": "https://github.com/huggingface/datasets/pull/1457.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1457.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1456", "html_url": "https://github.com/huggingface/datasets/pull/1456", "diff_url": "https://github.com/huggingface/datasets/pull/1456.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1456.patch", "merged_at": 1607941207000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1456/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mariagrandury", "id": 57645283, "node_id": "MDQ6VXNlcjU3NjQ1Mjgz", "avatar_url": "https://avatars.githubusercontent.com/u/57645283?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mariagrandury", "html_url": "https://github.com/mariagrandury", "followers_url": "https://api.github.com/users/mariagrandury/followers", "following_url": "https://api.github.com/users/mariagrandury/following{/other_user}", "gists_url": "https://api.github.com/users/mariagrandury/gists{/gist_id}", "starred_url": "https://api.github.com/users/mariagrandury/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mariagrandury/subscriptions", "organizations_url": "https://api.github.com/users/mariagrandury/orgs", "repos_url": "https://api.github.com/users/mariagrandury/repos", "events_url": "https://api.github.com/users/mariagrandury/events{/privacy}", "received_events_url": "https://api.github.com/users/mariagrandury/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you for your review @lhoestq, I've changed the types of `qid` and `ra` and now they are integers as `aid`.\r\n\r\nReady for another review!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1455", "html_url": "https://github.com/huggingface/datasets/pull/1455", "diff_url": "https://github.com/huggingface/datasets/pull/1455.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1455.patch", "merged_at": 1608224291000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1455/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "saradhix", "id": 1351362, "node_id": "MDQ6VXNlcjEzNTEzNjI=", "avatar_url": "https://avatars.githubusercontent.com/u/1351362?v=4", "gravatar_id": "", "url": "https://api.github.com/users/saradhix", "html_url": "https://github.com/saradhix", "followers_url": "https://api.github.com/users/saradhix/followers", "following_url": "https://api.github.com/users/saradhix/following{/other_user}", "gists_url": "https://api.github.com/users/saradhix/gists{/gist_id}", "starred_url": "https://api.github.com/users/saradhix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/saradhix/subscriptions", "organizations_url": "https://api.github.com/users/saradhix/orgs", "repos_url": "https://api.github.com/users/saradhix/repos", "events_url": "https://api.github.com/users/saradhix/events{/privacy}", "received_events_url": "https://api.github.com/users/saradhix/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1454", "html_url": "https://github.com/huggingface/datasets/pull/1454", "diff_url": "https://github.com/huggingface/datasets/pull/1454.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1454.patch", "merged_at": 1608230056000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1454/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "iamollas", "id": 22838900, "node_id": "MDQ6VXNlcjIyODM4OTAw", "avatar_url": "https://avatars.githubusercontent.com/u/22838900?v=4", "gravatar_id": "", "url": "https://api.github.com/users/iamollas", "html_url": "https://github.com/iamollas", "followers_url": "https://api.github.com/users/iamollas/followers", "following_url": "https://api.github.com/users/iamollas/following{/other_user}", "gists_url": "https://api.github.com/users/iamollas/gists{/gist_id}", "starred_url": "https://api.github.com/users/iamollas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iamollas/subscriptions", "organizations_url": "https://api.github.com/users/iamollas/orgs", "repos_url": "https://api.github.com/users/iamollas/repos", "events_url": "https://api.github.com/users/iamollas/events{/privacy}", "received_events_url": "https://api.github.com/users/iamollas/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Thanks !\r\n\r\nThanks as well for your hard work 😊!!", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1453", "html_url": "https://github.com/huggingface/datasets/pull/1453", "diff_url": "https://github.com/huggingface/datasets/pull/1453.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1453.patch", "merged_at": 1607941884000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aarnetalman", "id": 11405654, "node_id": "MDQ6VXNlcjExNDA1NjU0", "avatar_url": "https://avatars.githubusercontent.com/u/11405654?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aarnetalman", "html_url": "https://github.com/aarnetalman", "followers_url": "https://api.github.com/users/aarnetalman/followers", "following_url": "https://api.github.com/users/aarnetalman/following{/other_user}", "gists_url": "https://api.github.com/users/aarnetalman/gists{/gist_id}", "starred_url": "https://api.github.com/users/aarnetalman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aarnetalman/subscriptions", "organizations_url": "https://api.github.com/users/aarnetalman/orgs", "repos_url": "https://api.github.com/users/aarnetalman/repos", "events_url": "https://api.github.com/users/aarnetalman/events{/privacy}", "received_events_url": "https://api.github.com/users/aarnetalman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I believe the `-1` label is used for missing/NULL data as per HuggingFace Dataset conventions. If I recall correctly SNLI has some entries with no (gold) labels in the dataset.", "Ah, you're right. The dataset has some pairs with missing labels. Thanks for reminding me." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1452/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "SBrandeis", "id": 33657802, "node_id": "MDQ6VXNlcjMzNjU3ODAy", "avatar_url": "https://avatars.githubusercontent.com/u/33657802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SBrandeis", "html_url": "https://github.com/SBrandeis", "followers_url": "https://api.github.com/users/SBrandeis/followers", "following_url": "https://api.github.com/users/SBrandeis/following{/other_user}", "gists_url": "https://api.github.com/users/SBrandeis/gists{/gist_id}", "starred_url": "https://api.github.com/users/SBrandeis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SBrandeis/subscriptions", "organizations_url": "https://api.github.com/users/SBrandeis/orgs", "repos_url": "https://api.github.com/users/SBrandeis/repos", "events_url": "https://api.github.com/users/SBrandeis/events{/privacy}", "received_events_url": "https://api.github.com/users/SBrandeis/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1451", "html_url": "https://github.com/huggingface/datasets/pull/1451", "diff_url": "https://github.com/huggingface/datasets/pull/1451.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1451.patch", "merged_at": 1607705409000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1450", "html_url": "https://github.com/huggingface/datasets/pull/1450", "diff_url": "https://github.com/huggingface/datasets/pull/1450.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1450.patch", "merged_at": 1607704840000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1450/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aseifert", "id": 4944799, "node_id": "MDQ6VXNlcjQ5NDQ3OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/4944799?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aseifert", "html_url": "https://github.com/aseifert", "followers_url": "https://api.github.com/users/aseifert/followers", "following_url": "https://api.github.com/users/aseifert/following{/other_user}", "gists_url": "https://api.github.com/users/aseifert/gists{/gist_id}", "starred_url": "https://api.github.com/users/aseifert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aseifert/subscriptions", "organizations_url": "https://api.github.com/users/aseifert/orgs", "repos_url": "https://api.github.com/users/aseifert/repos", "events_url": "https://api.github.com/users/aseifert/events{/privacy}", "received_events_url": "https://api.github.com/users/aseifert/received_events", "type": "User", "site_admin": false }

[]

[]

[ "linter your code with flake8 and also run the commands present in Makefile for proper formatting \r\n", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1449", "html_url": "https://github.com/huggingface/datasets/pull/1449", "diff_url": "https://github.com/huggingface/datasets/pull/1449.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1449.patch", "merged_at": 1607706466000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1449/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "cstorm125", "id": 15519308, "node_id": "MDQ6VXNlcjE1NTE5MzA4", "avatar_url": "https://avatars.githubusercontent.com/u/15519308?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cstorm125", "html_url": "https://github.com/cstorm125", "followers_url": "https://api.github.com/users/cstorm125/followers", "following_url": "https://api.github.com/users/cstorm125/following{/other_user}", "gists_url": "https://api.github.com/users/cstorm125/gists{/gist_id}", "starred_url": "https://api.github.com/users/cstorm125/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cstorm125/subscriptions", "organizations_url": "https://api.github.com/users/cstorm125/orgs", "repos_url": "https://api.github.com/users/cstorm125/repos", "events_url": "https://api.github.com/users/cstorm125/events{/privacy}", "received_events_url": "https://api.github.com/users/cstorm125/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1448", "html_url": "https://github.com/huggingface/datasets/pull/1448", "diff_url": "https://github.com/huggingface/datasets/pull/1448.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1448.patch", "merged_at": 1607703687000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1448/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "thomwolf", "id": 7353373, "node_id": "MDQ6VXNlcjczNTMzNzM=", "avatar_url": "https://avatars.githubusercontent.com/u/7353373?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomwolf", "html_url": "https://github.com/thomwolf", "followers_url": "https://api.github.com/users/thomwolf/followers", "following_url": "https://api.github.com/users/thomwolf/following{/other_user}", "gists_url": "https://api.github.com/users/thomwolf/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomwolf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomwolf/subscriptions", "organizations_url": "https://api.github.com/users/thomwolf/orgs", "repos_url": "https://api.github.com/users/thomwolf/repos", "events_url": "https://api.github.com/users/thomwolf/events{/privacy}", "received_events_url": "https://api.github.com/users/thomwolf/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @thomwolf, for simplification purposes, I think you could remove the \"`pip install ...`\" steps from this commit, 'cause these deps (black, isort, flake8) are already installed on `pip install -e \".[dev]\"` on the [Start by preparing your environment](https://github.com/huggingface/datasets/blob/704107f924e74445f6f0fbde69a218b72178b588/ADD_NEW_DATASET.md#start-by-preparing-your-environment)\r\n" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1447", "html_url": "https://github.com/huggingface/datasets/pull/1447", "diff_url": "https://github.com/huggingface/datasets/pull/1447.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1447.patch", "merged_at": 1607592674000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1446", "html_url": "https://github.com/huggingface/datasets/pull/1446", "diff_url": "https://github.com/huggingface/datasets/pull/1446.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1446.patch", "merged_at": 1607706187000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1446/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tsvm", "id": 1083319, "node_id": "MDQ6VXNlcjEwODMzMTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1083319?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tsvm", "html_url": "https://github.com/tsvm", "followers_url": "https://api.github.com/users/tsvm/followers", "following_url": "https://api.github.com/users/tsvm/following{/other_user}", "gists_url": "https://api.github.com/users/tsvm/gists{/gist_id}", "starred_url": "https://api.github.com/users/tsvm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tsvm/subscriptions", "organizations_url": "https://api.github.com/users/tsvm/orgs", "repos_url": "https://api.github.com/users/tsvm/repos", "events_url": "https://api.github.com/users/tsvm/events{/privacy}", "received_events_url": "https://api.github.com/users/tsvm/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looks like this PR includes changes about many other files than the ones for clickbait_news_bg\r\n\r\nCan you create another branch and another PR please ?", "I created a new branch with the dataset code and submitted a new PR for it: https://github.com/huggingface/datasets/pull/1568" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1445", "html_url": "https://github.com/huggingface/datasets/pull/1445", "diff_url": "https://github.com/huggingface/datasets/pull/1445.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1445.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1445/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sadakmed", "id": 18331629, "node_id": "MDQ6VXNlcjE4MzMxNjI5", "avatar_url": "https://avatars.githubusercontent.com/u/18331629?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sadakmed", "html_url": "https://github.com/sadakmed", "followers_url": "https://api.github.com/users/sadakmed/followers", "following_url": "https://api.github.com/users/sadakmed/following{/other_user}", "gists_url": "https://api.github.com/users/sadakmed/gists{/gist_id}", "starred_url": "https://api.github.com/users/sadakmed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sadakmed/subscriptions", "organizations_url": "https://api.github.com/users/sadakmed/orgs", "repos_url": "https://api.github.com/users/sadakmed/repos", "events_url": "https://api.github.com/users/sadakmed/events{/privacy}", "received_events_url": "https://api.github.com/users/sadakmed/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This dataset will be available in version-2 of the library. If you want to use this dataset now, install datasets from `master` branch rather.\r\n\r\nCommand to install datasets from `master` branch:\r\n`!pip install git+https://github.com/huggingface/datasets.git@master`", "Closing this, thanks @VasudevGupta7 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1444/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1443", "html_url": "https://github.com/huggingface/datasets/pull/1443", "diff_url": "https://github.com/huggingface/datasets/pull/1443.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1443.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1443/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "albertvillanova", "id": 8515462, "node_id": "MDQ6VXNlcjg1MTU0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/albertvillanova", "html_url": "https://github.com/albertvillanova", "followers_url": "https://api.github.com/users/albertvillanova/followers", "following_url": "https://api.github.com/users/albertvillanova/following{/other_user}", "gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}", "starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions", "organizations_url": "https://api.github.com/users/albertvillanova/orgs", "repos_url": "https://api.github.com/users/albertvillanova/repos", "events_url": "https://api.github.com/users/albertvillanova/events{/privacy}", "received_events_url": "https://api.github.com/users/albertvillanova/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1442", "html_url": "https://github.com/huggingface/datasets/pull/1442", "diff_url": "https://github.com/huggingface/datasets/pull/1442.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1442.patch", "merged_at": 1608199183000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1442/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1441", "html_url": "https://github.com/huggingface/datasets/pull/1441", "diff_url": "https://github.com/huggingface/datasets/pull/1441.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1441.patch", "merged_at": 1607702092000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1441/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "purvimisal", "id": 22298787, "node_id": "MDQ6VXNlcjIyMjk4Nzg3", "avatar_url": "https://avatars.githubusercontent.com/u/22298787?v=4", "gravatar_id": "", "url": "https://api.github.com/users/purvimisal", "html_url": "https://github.com/purvimisal", "followers_url": "https://api.github.com/users/purvimisal/followers", "following_url": "https://api.github.com/users/purvimisal/following{/other_user}", "gists_url": "https://api.github.com/users/purvimisal/gists{/gist_id}", "starred_url": "https://api.github.com/users/purvimisal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/purvimisal/subscriptions", "organizations_url": "https://api.github.com/users/purvimisal/orgs", "repos_url": "https://api.github.com/users/purvimisal/repos", "events_url": "https://api.github.com/users/purvimisal/events{/privacy}", "received_events_url": "https://api.github.com/users/purvimisal/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @purvimisal, thanks for your contributions!\r\n\r\nThis jokes dataset has come up before, and after a conversation with the initial submitter, we decided not to add it then. Humor is important, but looking at the actual data points in this set raises several concerns :) \r\n\r\nThe main issue is the Reddit part of the dataset which has most of the examples. A cursory look at the data shows a large number of highly offensive jokes that reproduce some pretty harmful biases (the second one from the top is a Holocaust joke). \r\n\r\nThe other two sources have similar issues (especially the \"Blond Jokes\") to a slightly lesser extent.\r\n\r\nWhile such datasets can be useful in the right context, there is a real concern that people using the library might miss some of this context (however much we outline it), and end up unwittingly training models that rely on some pretty racist and sexist associations.\r\n\r\nWe would recommend skipping this dataset altogether.\r\n\r\nIf you feel really strongly about having a joke dataset, then we would ask that you:\r\n- remove the Reddit part of the dataset altogether\r\n- write an in-depth description of the social biases present in the remaining data\r\n\r\nLet us know which of the two you decide! And if you want recommendations on other datasets to add, hit us up on Slack 🤗 ", "Hi @yjernite, thanks so much. I should've totally thought about this earlier. The harmful biases make so much sense. I should've consulted before making a PR. \r\nI will be closing this one and skipping this dataset altogether. \r\nThanks again \r\n" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1440", "html_url": "https://github.com/huggingface/datasets/pull/1440", "diff_url": "https://github.com/huggingface/datasets/pull/1440.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1440.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1440/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tuner007", "id": 46425391, "node_id": "MDQ6VXNlcjQ2NDI1Mzkx", "avatar_url": "https://avatars.githubusercontent.com/u/46425391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tuner007", "html_url": "https://github.com/tuner007", "followers_url": "https://api.github.com/users/tuner007/followers", "following_url": "https://api.github.com/users/tuner007/following{/other_user}", "gists_url": "https://api.github.com/users/tuner007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tuner007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tuner007/subscriptions", "organizations_url": "https://api.github.com/users/tuner007/orgs", "repos_url": "https://api.github.com/users/tuner007/repos", "events_url": "https://api.github.com/users/tuner007/events{/privacy}", "received_events_url": "https://api.github.com/users/tuner007/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1439", "html_url": "https://github.com/huggingface/datasets/pull/1439", "diff_url": "https://github.com/huggingface/datasets/pull/1439.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1439.patch", "merged_at": 1607700173000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1439/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rahul-art", "id": 56379013, "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rahul-art", "html_url": "https://github.com/rahul-art", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "repos_url": "https://api.github.com/users/rahul-art/repos", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I have noticed that the master branch of your fork has diverged from the one of the repo. This is probably what causes the mess in the github diff \"Files changed\".\r\n\r\nI would suggest to re-fork the `datasets` repo and recreate a new branch and a new PR. ", "You're pretty close to having all things ready to merge !\r\nFeel free to ping me when you have a new PR", "Closing this one in favor of #1575 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1438", "html_url": "https://github.com/huggingface/datasets/pull/1438", "diff_url": "https://github.com/huggingface/datasets/pull/1438.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1438.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1438/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "prasastoadi", "id": 11614678, "node_id": "MDQ6VXNlcjExNjE0Njc4", "avatar_url": "https://avatars.githubusercontent.com/u/11614678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/prasastoadi", "html_url": "https://github.com/prasastoadi", "followers_url": "https://api.github.com/users/prasastoadi/followers", "following_url": "https://api.github.com/users/prasastoadi/following{/other_user}", "gists_url": "https://api.github.com/users/prasastoadi/gists{/gist_id}", "starred_url": "https://api.github.com/users/prasastoadi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/prasastoadi/subscriptions", "organizations_url": "https://api.github.com/users/prasastoadi/orgs", "repos_url": "https://api.github.com/users/prasastoadi/repos", "events_url": "https://api.github.com/users/prasastoadi/events{/privacy}", "received_events_url": "https://api.github.com/users/prasastoadi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @prasastoadi have you had a chance to take a look at my suggestions ?\r\n\r\nFeel free to ping ;e if you have questions or when you're ready for a review" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1437", "html_url": "https://github.com/huggingface/datasets/pull/1437", "diff_url": "https://github.com/huggingface/datasets/pull/1437.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1437.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1437/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "chameleonTK", "id": 6429850, "node_id": "MDQ6VXNlcjY0Mjk4NTA=", "avatar_url": "https://avatars.githubusercontent.com/u/6429850?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chameleonTK", "html_url": "https://github.com/chameleonTK", "followers_url": "https://api.github.com/users/chameleonTK/followers", "following_url": "https://api.github.com/users/chameleonTK/following{/other_user}", "gists_url": "https://api.github.com/users/chameleonTK/gists{/gist_id}", "starred_url": "https://api.github.com/users/chameleonTK/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chameleonTK/subscriptions", "organizations_url": "https://api.github.com/users/chameleonTK/orgs", "repos_url": "https://api.github.com/users/chameleonTK/repos", "events_url": "https://api.github.com/users/chameleonTK/events{/privacy}", "received_events_url": "https://api.github.com/users/chameleonTK/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The errors in de CI are fixed on master so it's fine" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1436", "html_url": "https://github.com/huggingface/datasets/pull/1436", "diff_url": "https://github.com/huggingface/datasets/pull/1436.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1436.patch", "merged_at": 1607701961000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1436/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 2, "eyes": 0 }

{ "login": "anaerobeth", "id": 3663322, "node_id": "MDQ6VXNlcjM2NjMzMjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3663322?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anaerobeth", "html_url": "https://github.com/anaerobeth", "followers_url": "https://api.github.com/users/anaerobeth/followers", "following_url": "https://api.github.com/users/anaerobeth/following{/other_user}", "gists_url": "https://api.github.com/users/anaerobeth/gists{/gist_id}", "starred_url": "https://api.github.com/users/anaerobeth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anaerobeth/subscriptions", "organizations_url": "https://api.github.com/users/anaerobeth/orgs", "repos_url": "https://api.github.com/users/anaerobeth/repos", "events_url": "https://api.github.com/users/anaerobeth/events{/privacy}", "received_events_url": "https://api.github.com/users/anaerobeth/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@yjernite @lhoestq Any suggestions on how to get the dummy data generator to recognize the columns? The structure of the json is:\r\n```\r\n{\r\n \"Dataset\": \"FreebaseQA-eval\", \r\n \"Version\": \"1.0\", \r\n \"Questions\": [\r\n {\r\n \"Question-ID\": \"FreebaseQA-eval-0\", \r\n \"RawQuestion\": \"Who is the female presenter of the Channel 4 quiz show '1001 things you should know'?\", \r\n \"ProcessedQuestion\": \"who is the female presenter of the channel 4 quiz show '1001 things you should know'\", \r\n \"Parses\": [\r\n {\r\n \"Parse-Id\": \"FreebaseQA-eval-0.P0\", \r\n \"PotentialTopicEntityMention\": \"1001 things you should know\", \r\n \"TopicEntityName\": \"1001 things you should know\", \r\n \"TopicEntityMid\": \"m.0nd3t34\", \r\n \"InferentialChain\": \"tv.tv_program.regular_personal_appearances..tv.tv_regular_personal_appearance.person\", \r\n \"Answers\": [\r\n {\r\n \"AnswersMid\": \"m.0216y_\", \r\n \"AnswersName\": [\r\n \"sandi toksvig\"\r\n ]\r\n }\r\n ]\r\n }\r\n ]\r\n }, \r\n ...\r\n ]\r\n}\r\n```\r\n\r\nThanks!", "Unfortunately this json structure is not recognized by the auto-generation yet, so you'd have to create the dummy data manually. \r\nYou can get some instructions on how to do that with: `python datasets-cli dummy_data datasets/freebase_qa`\r\nWe can definitely help you with that if there are too many files! ", "@yjernite Thanks for the instructions. I manually added dummy data and created the zip file but one of the splits seem to return an empty list.\r\n\r\n```\r\ntests/test_dataset_common.py F [100%]\r\n\r\n========================= FAILURES ==========================\r\n_ LocalDatasetTest.test_load_dataset_all_configs_freebase_qa _\r\n\r\nself = <tests.test_dataset_common.LocalDatasetTest testMethod=test_load_dataset_all_configs_freebase_qa>\r\ndataset_name = 'freebase_qa'\r\n\r\n @slow\r\n def test_load_dataset_all_configs(self, dataset_name):\r\n configs = self.dataset_tester.load_all_configs(dataset_name, is_local=True)\r\n> self.dataset_tester.check_load_dataset(dataset_name, configs, is_local=True)\r\n\r\ntests/test_dataset_common.py:237:\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\ntests/test_dataset_common.py:198: in check_load_dataset\r\n self.parent.assertTrue(len(dataset[split]) > 0)\r\nE AssertionError: False is not true\r\n```\r\n\r\nNote that the dataset has `train`, `eval`, and `dev` (no test split). I am not sure if I am mapping them correctly when I called the Split Generator.\r\n", "The dummy json files must follow the exact same structure as the original json files.\r\n\r\nHowever it looks like the dummy json files you have in your dummy_data.zip file are not structured the same way.\r\nFor example the original json is a dict with a field \"Questions\" that is a list of items.\r\nHowever your dummy json is simply a list of items.\r\n\r\nCan you update your dummy json files to follow the same structure ?", "And I'm pretty sure that this structure is supported by the dummy data auto-generation tool\r\n```\r\npython datasets-cli dummy_data ./datasets/freebase_qa --json_field \"Questions\"\r\n```", "Hi @anaerobeth did you manage to get the dummy data right ?\r\n\r\nFeel free to ping me if you have questions or when you're ready for a review", "Thanks for your help! I am able to create the dummy data with the dict structure as suggested. I'll add the tags and update this PR shortly.", "Also don't forget to run `make style` to fix the code formatting check in the CI :)", "Hi @anaerobeth ! Have you had a chance to consider updating the dataset script to yield one example per question ?\r\n\r\nFeel free to ping me if you have questions or if I can help :) ", "Hi @lhoestq,\r\n\r\nI am willing to take this forward if you and @anaerobeth don't mind.\r\n", "Hi @gchhablani thanks for proposing your help :) \r\nSure if you want to take this forward feel free to do so.\r\nAlso pinging @anaerobeth to make sure that you both don't work on the same thing at the same time", "Hi ! Closing this one since the dataset was added in #1814 \r\n\r\nThanks you two @anaerobeth and @gchhablani for adding this dataset !" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1435", "html_url": "https://github.com/huggingface/datasets/pull/1435", "diff_url": "https://github.com/huggingface/datasets/pull/1435.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1435.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1435/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ZacharySBrown", "id": 7950786, "node_id": "MDQ6VXNlcjc5NTA3ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/7950786?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ZacharySBrown", "html_url": "https://github.com/ZacharySBrown", "followers_url": "https://api.github.com/users/ZacharySBrown/followers", "following_url": "https://api.github.com/users/ZacharySBrown/following{/other_user}", "gists_url": "https://api.github.com/users/ZacharySBrown/gists{/gist_id}", "starred_url": "https://api.github.com/users/ZacharySBrown/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ZacharySBrown/subscriptions", "organizations_url": "https://api.github.com/users/ZacharySBrown/orgs", "repos_url": "https://api.github.com/users/ZacharySBrown/repos", "events_url": "https://api.github.com/users/ZacharySBrown/events{/privacy}", "received_events_url": "https://api.github.com/users/ZacharySBrown/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hey @lhoestq , thanks for the feedback on this! I updated the `_generate_examples` with some comments on the process, and reduced the `dummy_data.zip` down quite a bit as well. \r\n\r\nFor the dummy data, I reduced the text to only three sentences, and aligned the corresponding entity/token/sentence annotations to that (reduced accordingly). The frames file is a strange combined format for the annotations and I found if I reduced that that would break the parser no matter what I did, so I left that as is. The difference between a reduced frames and non-reduced frames file in the compressed dummy data was only about ~4kb, so hopefully leaving this as is will be ok!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1434", "html_url": "https://github.com/huggingface/datasets/pull/1434", "diff_url": "https://github.com/huggingface/datasets/pull/1434.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1434.patch", "merged_at": 1608199194000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1434/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonatasgrosman", "id": 5097052, "node_id": "MDQ6VXNlcjUwOTcwNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/5097052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatasgrosman", "html_url": "https://github.com/jonatasgrosman", "followers_url": "https://api.github.com/users/jonatasgrosman/followers", "following_url": "https://api.github.com/users/jonatasgrosman/following{/other_user}", "gists_url": "https://api.github.com/users/jonatasgrosman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatasgrosman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatasgrosman/subscriptions", "organizations_url": "https://api.github.com/users/jonatasgrosman/orgs", "repos_url": "https://api.github.com/users/jonatasgrosman/repos", "events_url": "https://api.github.com/users/jonatasgrosman/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatasgrosman/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1433", "html_url": "https://github.com/huggingface/datasets/pull/1433", "diff_url": "https://github.com/huggingface/datasets/pull/1433.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1433.patch", "merged_at": 1607697176000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "MaramHasanain", "id": 3918663, "node_id": "MDQ6VXNlcjM5MTg2NjM=", "avatar_url": "https://avatars.githubusercontent.com/u/3918663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MaramHasanain", "html_url": "https://github.com/MaramHasanain", "followers_url": "https://api.github.com/users/MaramHasanain/followers", "following_url": "https://api.github.com/users/MaramHasanain/following{/other_user}", "gists_url": "https://api.github.com/users/MaramHasanain/gists{/gist_id}", "starred_url": "https://api.github.com/users/MaramHasanain/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MaramHasanain/subscriptions", "organizations_url": "https://api.github.com/users/MaramHasanain/orgs", "repos_url": "https://api.github.com/users/MaramHasanain/repos", "events_url": "https://api.github.com/users/MaramHasanain/events{/privacy}", "received_events_url": "https://api.github.com/users/MaramHasanain/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Thanks a lot for checking! I hope I addressed all your comments. ", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1432", "html_url": "https://github.com/huggingface/datasets/pull/1432", "diff_url": "https://github.com/huggingface/datasets/pull/1432.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1432.patch", "merged_at": 1607953864000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1432/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Fatima-Haouari", "id": 71061623, "node_id": "MDQ6VXNlcjcxMDYxNjIz", "avatar_url": "https://avatars.githubusercontent.com/u/71061623?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Fatima-Haouari", "html_url": "https://github.com/Fatima-Haouari", "followers_url": "https://api.github.com/users/Fatima-Haouari/followers", "following_url": "https://api.github.com/users/Fatima-Haouari/following{/other_user}", "gists_url": "https://api.github.com/users/Fatima-Haouari/gists{/gist_id}", "starred_url": "https://api.github.com/users/Fatima-Haouari/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Fatima-Haouari/subscriptions", "organizations_url": "https://api.github.com/users/Fatima-Haouari/orgs", "repos_url": "https://api.github.com/users/Fatima-Haouari/repos", "events_url": "https://api.github.com/users/Fatima-Haouari/events{/privacy}", "received_events_url": "https://api.github.com/users/Fatima-Haouari/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1431", "html_url": "https://github.com/huggingface/datasets/pull/1431", "diff_url": "https://github.com/huggingface/datasets/pull/1431.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1431.patch", "merged_at": 1607698883000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1431/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zaidalyafeai", "id": 15667714, "node_id": "MDQ6VXNlcjE1NjY3NzE0", "avatar_url": "https://avatars.githubusercontent.com/u/15667714?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zaidalyafeai", "html_url": "https://github.com/zaidalyafeai", "followers_url": "https://api.github.com/users/zaidalyafeai/followers", "following_url": "https://api.github.com/users/zaidalyafeai/following{/other_user}", "gists_url": "https://api.github.com/users/zaidalyafeai/gists{/gist_id}", "starred_url": "https://api.github.com/users/zaidalyafeai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zaidalyafeai/subscriptions", "organizations_url": "https://api.github.com/users/zaidalyafeai/orgs", "repos_url": "https://api.github.com/users/zaidalyafeai/repos", "events_url": "https://api.github.com/users/zaidalyafeai/events{/privacy}", "received_events_url": "https://api.github.com/users/zaidalyafeai/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Can't pass dummy data tests. For the instructions, it asks me to generate the following file `dummy_data/Youm7_XML_utf_8.rar/Youm7_utf_8.xml` which is strange, any ideas @lhoestq ?\r\n\r\ncc: I tested the data locally and it works, maybe the dummy tests doesn't support `rar` ? ", "In the dummy_data.zip files you must include the rar file as if is was already extracted.\r\nIn particular here `Youm7_XML_utf_8.rar` is a directory (not an archive).", "Also I'm getting `BadRarFile: Failed the read enough data: req=16384 got=51` while trying to download and extract the `Alittihad_XML_utf_8.rar` file. Do you have this issue as well ?\r\n\r\nI have rarfile 4.0", "Sorry it was my mistake, I missed up the directories, it works now. Not sure why you got that error. I have the same version of `rarfile`. Between, there were some suggestions to change the dataset from `1bn_words_arabic` to `arabic_billion_words` like https://github.com/huggingface/datasets/tree/master/datasets/spanish_billion_words. \r\n", "I'm ok with renaming the dataset `arabic_billion_words` if you want.\r\nNote that you will need to rename class name `ArabicBillionWords` instead of `BillionWords`\r\n(though `BillionWords` was not matching `1bn_words_arabic` anyway)\r\n\r\nYou will need to regenerate the dataset_infos.json file after this change.\r\nOR alternatively just replace all mentions of `billion_words` with `arabic_billion_words` in dataset_infos.json <- this trick should save you some time :)", "Hmmm I'm still not able to run it on my side because of the rar error (I'm running macos)\r\nI just tried with rarfile 3.1 and it didn't work either.\r\nI would like to be able to run it end-to-end on my side before merging if you don't mind. Let me investigate this issue a little bit", "No worries, I will investigate it as well. ", "I created a minimal example in [colab ](https://colab.research.google.com/drive/11ijesuGbrQylANka0VdsZ5vXwIuxkheY?usp=sharing).", "Nice thanks, maybe it's just an issue on my side then", "Ok I managed to solve the BadRarFile issue on my side :) \r\nTo fix it I had to install the `unrar` tool for macos (though it seems it's not available with `brew install` anymore, I had to install it from elsewhere)." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1430", "html_url": "https://github.com/huggingface/datasets/pull/1430", "diff_url": "https://github.com/huggingface/datasets/pull/1430.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1430.patch", "merged_at": 1608631439000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1430/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zaidalyafeai", "id": 15667714, "node_id": "MDQ6VXNlcjE1NjY3NzE0", "avatar_url": "https://avatars.githubusercontent.com/u/15667714?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zaidalyafeai", "html_url": "https://github.com/zaidalyafeai", "followers_url": "https://api.github.com/users/zaidalyafeai/followers", "following_url": "https://api.github.com/users/zaidalyafeai/following{/other_user}", "gists_url": "https://api.github.com/users/zaidalyafeai/gists{/gist_id}", "starred_url": "https://api.github.com/users/zaidalyafeai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zaidalyafeai/subscriptions", "organizations_url": "https://api.github.com/users/zaidalyafeai/orgs", "repos_url": "https://api.github.com/users/zaidalyafeai/repos", "events_url": "https://api.github.com/users/zaidalyafeai/events{/privacy}", "received_events_url": "https://api.github.com/users/zaidalyafeai/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1429", "html_url": "https://github.com/huggingface/datasets/pull/1429", "diff_url": "https://github.com/huggingface/datasets/pull/1429.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1429.patch", "merged_at": 1608303817000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1429/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1428", "html_url": "https://github.com/huggingface/datasets/pull/1428", "diff_url": "https://github.com/huggingface/datasets/pull/1428.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1428.patch", "merged_at": 1607695052000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1428/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "imvladikon", "id": 10088963, "node_id": "MDQ6VXNlcjEwMDg4OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/10088963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/imvladikon", "html_url": "https://github.com/imvladikon", "followers_url": "https://api.github.com/users/imvladikon/followers", "following_url": "https://api.github.com/users/imvladikon/following{/other_user}", "gists_url": "https://api.github.com/users/imvladikon/gists{/gist_id}", "starred_url": "https://api.github.com/users/imvladikon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imvladikon/subscriptions", "organizations_url": "https://api.github.com/users/imvladikon/orgs", "repos_url": "https://api.github.com/users/imvladikon/repos", "events_url": "https://api.github.com/users/imvladikon/events{/privacy}", "received_events_url": "https://api.github.com/users/imvladikon/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1427", "html_url": "https://github.com/huggingface/datasets/pull/1427", "diff_url": "https://github.com/huggingface/datasets/pull/1427.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1427.patch", "merged_at": 1607708363000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1427/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Karthik-Bhaskar", "id": 13200370, "node_id": "MDQ6VXNlcjEzMjAwMzcw", "avatar_url": "https://avatars.githubusercontent.com/u/13200370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Karthik-Bhaskar", "html_url": "https://github.com/Karthik-Bhaskar", "followers_url": "https://api.github.com/users/Karthik-Bhaskar/followers", "following_url": "https://api.github.com/users/Karthik-Bhaskar/following{/other_user}", "gists_url": "https://api.github.com/users/Karthik-Bhaskar/gists{/gist_id}", "starred_url": "https://api.github.com/users/Karthik-Bhaskar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthik-Bhaskar/subscriptions", "organizations_url": "https://api.github.com/users/Karthik-Bhaskar/orgs", "repos_url": "https://api.github.com/users/Karthik-Bhaskar/repos", "events_url": "https://api.github.com/users/Karthik-Bhaskar/events{/privacy}", "received_events_url": "https://api.github.com/users/Karthik-Bhaskar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "good dataset card as well :) ", "@lhoestq Thank you :) " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1426", "html_url": "https://github.com/huggingface/datasets/pull/1426", "diff_url": "https://github.com/huggingface/datasets/pull/1426.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1426.patch", "merged_at": 1607693828000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1426/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Phil1108", "id": 39518904, "node_id": "MDQ6VXNlcjM5NTE4OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/39518904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Phil1108", "html_url": "https://github.com/Phil1108", "followers_url": "https://api.github.com/users/Phil1108/followers", "following_url": "https://api.github.com/users/Phil1108/following{/other_user}", "gists_url": "https://api.github.com/users/Phil1108/gists{/gist_id}", "starred_url": "https://api.github.com/users/Phil1108/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Phil1108/subscriptions", "organizations_url": "https://api.github.com/users/Phil1108/orgs", "repos_url": "https://api.github.com/users/Phil1108/repos", "events_url": "https://api.github.com/users/Phil1108/events{/privacy}", "received_events_url": "https://api.github.com/users/Phil1108/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @Phil1108 !\r\nHave you had a chance to take a look at my suggestions ?\r\nFeel free to ping me if you have questions or if you're ready for a review\r\n\r\nThanks again for adding this dataset, this one is very useful !", "> \r\n> \r\n> Hi @Phil1108 !\r\n> Have you had a chance to take a look at my suggestions ?\r\n> Feel free to ping me if you have questions or if you're ready for a review\r\n> \r\n> Thanks again for adding this dataset, this one is very useful !\r\n\r\nHello @lhoestq , \r\n\r\nokay so should we go on with only the 2 parts or wait until the hosting of all 200 GB is cleared at HF? \r\nIf you want to merge it with the 2 parts only at first und upgrade later to all, sure I'll include the minor changes in the next few days and update it here", "I think we can wait a bit to find a solution for the hosting and update the PR to include all the files when it's done.\r\nIn the meantime you can update the PR to take into account the suggestions regarding the dataset card, the parallel downloads and the use of eval.\r\n\r\nA safer alternative to eval is `ast.literal_eval`, it should do the job" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1425", "html_url": "https://github.com/huggingface/datasets/pull/1425", "diff_url": "https://github.com/huggingface/datasets/pull/1425.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1425.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1425/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1424", "html_url": "https://github.com/huggingface/datasets/pull/1424", "diff_url": "https://github.com/huggingface/datasets/pull/1424.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1424.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1424/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aclifton314", "id": 53267795, "node_id": "MDQ6VXNlcjUzMjY3Nzk1", "avatar_url": "https://avatars.githubusercontent.com/u/53267795?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aclifton314", "html_url": "https://github.com/aclifton314", "followers_url": "https://api.github.com/users/aclifton314/followers", "following_url": "https://api.github.com/users/aclifton314/following{/other_user}", "gists_url": "https://api.github.com/users/aclifton314/gists{/gist_id}", "starred_url": "https://api.github.com/users/aclifton314/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aclifton314/subscriptions", "organizations_url": "https://api.github.com/users/aclifton314/orgs", "repos_url": "https://api.github.com/users/aclifton314/repos", "events_url": "https://api.github.com/users/aclifton314/events{/privacy}", "received_events_url": "https://api.github.com/users/aclifton314/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Feel free to ping me once you're ready for another review :) ", "For sure! Gonna work on this now!", "I incorporated all the changes but when I go to rebase I get the following error:\r\n```python\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git rebase upstream/master\r\nerror: cannot rebase: You have unstaged changes.\r\nerror: Please commit or stash them.\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git stash\r\nSaved working directory and index state WIP on imppres: 51736236 Incorporated secondary sets as configurations instead of splits.\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git rebase upstream/master\r\nCONFLICT (add/add): Merge conflict in datasets/wiki_movies/wiki_movies.py\r\nAuto-merging datasets/wiki_movies/wiki_movies.py\r\nCONFLICT (add/add): Merge conflict in datasets/wiki_movies/dataset_infos.json\r\nAuto-merging datasets/wiki_movies/dataset_infos.json\r\nCONFLICT (add/add): Merge conflict in datasets/wiki_movies/README.md\r\nAuto-merging datasets/wiki_movies/README.md\r\nerror: could not apply 04d08587... Created wiki_movies dataset.\r\nResolve all conflicts manually, mark them as resolved with\r\n\"git add/rm <conflicted_files>\", then run \"git rebase --continue\".\r\nYou can instead skip this commit: run \"git rebase --skip\".\r\nTo abort and get back to the state before \"git rebase\", run \"git rebase --abort\".\r\nCould not apply 04d08587... Created wiki_movies dataset.\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git branch\r\n* (no branch, rebasing imppres)\r\n imppres\r\n logiqa_en\r\n master\r\n wiki_movies\r\n wiki_movies_htl\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git checkout imppres \r\ndatasets/wiki_movies/README.md: needs merge\r\ndatasets/wiki_movies/dataset_infos.json: needs merge\r\ndatasets/wiki_movies/wiki_movies.py: needs merge\r\nerror: you need to resolve your current index first\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ \r\n```", "I think it's because the current branch includes changes about wiki_movies.\r\n\r\nCan you create a new branch from `master` and create another PR please ?", "I get this response when I try to switch to master:\r\n```\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git checkout master\r\ndatasets/wiki_movies/README.md: needs merge\r\ndatasets/wiki_movies/dataset_infos.json: needs merge\r\ndatasets/wiki_movies/wiki_movies.py: needs merge\r\nerror: you need to resolve your current index first\r\n```", "Maybe you have to remove the changes in wiki_movies before checkout to master\r\n```\r\ngit stash\r\n```\r\n\r\nshould do the job", "Here is what I get:\r\n```\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git stash\r\ndatasets/wiki_movies/README.md: needs merge\r\ndatasets/wiki_movies/dataset_infos.json: needs merge\r\ndatasets/wiki_movies/wiki_movies.py: needs merge\r\n```", "Ok I see\r\nLooks like you're in a `merge` process.\r\nYou can abort it with `git reset --merge`\r\n\r\nThen `git checkout master` should work", "So close! I got the new branch made and went through all the tests. When I went to push, I got the following:\r\n```\r\naclifton@pop-os:~/hf_datasets_sprint/datasets$ git push -u origin imppres\r\nUsername for 'https://github.com': aclifton314\r\nPassword for 'https://aclifton314@github.com': \r\nTo https://github.com/aclifton314/datasets\r\n ! [rejected] imppres -> imppres (non-fast-forward)\r\nerror: failed to push some refs to 'https://github.com/aclifton314/datasets'\r\nhint: Updates were rejected because the tip of your current branch is behind\r\nhint: its remote counterpart. Integrate the remote changes (e.g.\r\nhint: 'git pull ...') before pushing again.\r\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\r\n```", "after a rebase you need to `git push --force`", "Done!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1423", "html_url": "https://github.com/huggingface/datasets/pull/1423", "diff_url": "https://github.com/huggingface/datasets/pull/1423.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1423.patch", "merged_at": 1608229634000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1423/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 2, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "SolomidHero", "id": 28161779, "node_id": "MDQ6VXNlcjI4MTYxNzc5", "avatar_url": "https://avatars.githubusercontent.com/u/28161779?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SolomidHero", "html_url": "https://github.com/SolomidHero", "followers_url": "https://api.github.com/users/SolomidHero/followers", "following_url": "https://api.github.com/users/SolomidHero/following{/other_user}", "gists_url": "https://api.github.com/users/SolomidHero/gists{/gist_id}", "starred_url": "https://api.github.com/users/SolomidHero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SolomidHero/subscriptions", "organizations_url": "https://api.github.com/users/SolomidHero/orgs", "repos_url": "https://api.github.com/users/SolomidHero/repos", "events_url": "https://api.github.com/users/SolomidHero/events{/privacy}", "received_events_url": "https://api.github.com/users/SolomidHero/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Please could you post the whole script? I can't reproduce your issue. After updating the feature names/labels to match with the data, everything works fine for me. Try to update datasets/transformers to the newest version.", "Actually, the problem was how `tokenize` function was defined. This was completely my side mistake, so there are really no needs in this issue anymore" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1422/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1421", "html_url": "https://github.com/huggingface/datasets/pull/1421", "diff_url": "https://github.com/huggingface/datasets/pull/1421.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1421.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1421/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "michael-aloys", "id": 1858628, "node_id": "MDQ6VXNlcjE4NTg2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1858628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/michael-aloys", "html_url": "https://github.com/michael-aloys", "followers_url": "https://api.github.com/users/michael-aloys/followers", "following_url": "https://api.github.com/users/michael-aloys/following{/other_user}", "gists_url": "https://api.github.com/users/michael-aloys/gists{/gist_id}", "starred_url": "https://api.github.com/users/michael-aloys/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/michael-aloys/subscriptions", "organizations_url": "https://api.github.com/users/michael-aloys/orgs", "repos_url": "https://api.github.com/users/michael-aloys/repos", "events_url": "https://api.github.com/users/michael-aloys/events{/privacy}", "received_events_url": "https://api.github.com/users/michael-aloys/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1420", "html_url": "https://github.com/huggingface/datasets/pull/1420", "diff_url": "https://github.com/huggingface/datasets/pull/1420.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1420.patch", "merged_at": 1607693644000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1420/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "basakbuluz", "id": 41359672, "node_id": "MDQ6VXNlcjQxMzU5Njcy", "avatar_url": "https://avatars.githubusercontent.com/u/41359672?v=4", "gravatar_id": "", "url": "https://api.github.com/users/basakbuluz", "html_url": "https://github.com/basakbuluz", "followers_url": "https://api.github.com/users/basakbuluz/followers", "following_url": "https://api.github.com/users/basakbuluz/following{/other_user}", "gists_url": "https://api.github.com/users/basakbuluz/gists{/gist_id}", "starred_url": "https://api.github.com/users/basakbuluz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/basakbuluz/subscriptions", "organizations_url": "https://api.github.com/users/basakbuluz/orgs", "repos_url": "https://api.github.com/users/basakbuluz/repos", "events_url": "https://api.github.com/users/basakbuluz/events{/privacy}", "received_events_url": "https://api.github.com/users/basakbuluz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq, can you please review this PR?\r\n", "@SBrandeis,\r\nSorry. All of the latest version came to my branch. You can find final version. \r\nResubmitted as a clean final version of #1466\r\nI have completed all the review comments.", "Closing this as PR is now https://github.com/huggingface/datasets/pull/1466" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1419", "html_url": "https://github.com/huggingface/datasets/pull/1419", "diff_url": "https://github.com/huggingface/datasets/pull/1419.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1419.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1419/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mcmillanmajora", "id": 26722925, "node_id": "MDQ6VXNlcjI2NzIyOTI1", "avatar_url": "https://avatars.githubusercontent.com/u/26722925?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mcmillanmajora", "html_url": "https://github.com/mcmillanmajora", "followers_url": "https://api.github.com/users/mcmillanmajora/followers", "following_url": "https://api.github.com/users/mcmillanmajora/following{/other_user}", "gists_url": "https://api.github.com/users/mcmillanmajora/gists{/gist_id}", "starred_url": "https://api.github.com/users/mcmillanmajora/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mcmillanmajora/subscriptions", "organizations_url": "https://api.github.com/users/mcmillanmajora/orgs", "repos_url": "https://api.github.com/users/mcmillanmajora/repos", "events_url": "https://api.github.com/users/mcmillanmajora/events{/privacy}", "received_events_url": "https://api.github.com/users/mcmillanmajora/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1418", "html_url": "https://github.com/huggingface/datasets/pull/1418", "diff_url": "https://github.com/huggingface/datasets/pull/1418.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1418.patch", "merged_at": 1608198056000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1418/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "vinaykudari", "id": 34424769, "node_id": "MDQ6VXNlcjM0NDI0NzY5", "avatar_url": "https://avatars.githubusercontent.com/u/34424769?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vinaykudari", "html_url": "https://github.com/vinaykudari", "followers_url": "https://api.github.com/users/vinaykudari/followers", "following_url": "https://api.github.com/users/vinaykudari/following{/other_user}", "gists_url": "https://api.github.com/users/vinaykudari/gists{/gist_id}", "starred_url": "https://api.github.com/users/vinaykudari/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vinaykudari/subscriptions", "organizations_url": "https://api.github.com/users/vinaykudari/orgs", "repos_url": "https://api.github.com/users/vinaykudari/repos", "events_url": "https://api.github.com/users/vinaykudari/events{/privacy}", "received_events_url": "https://api.github.com/users/vinaykudari/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1417", "html_url": "https://github.com/huggingface/datasets/pull/1417", "diff_url": "https://github.com/huggingface/datasets/pull/1417.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1417.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1417/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bhctsntrk", "id": 22636672, "node_id": "MDQ6VXNlcjIyNjM2Njcy", "avatar_url": "https://avatars.githubusercontent.com/u/22636672?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bhctsntrk", "html_url": "https://github.com/bhctsntrk", "followers_url": "https://api.github.com/users/bhctsntrk/followers", "following_url": "https://api.github.com/users/bhctsntrk/following{/other_user}", "gists_url": "https://api.github.com/users/bhctsntrk/gists{/gist_id}", "starred_url": "https://api.github.com/users/bhctsntrk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bhctsntrk/subscriptions", "organizations_url": "https://api.github.com/users/bhctsntrk/orgs", "repos_url": "https://api.github.com/users/bhctsntrk/repos", "events_url": "https://api.github.com/users/bhctsntrk/events{/privacy}", "received_events_url": "https://api.github.com/users/bhctsntrk/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1416", "html_url": "https://github.com/huggingface/datasets/pull/1416", "diff_url": "https://github.com/huggingface/datasets/pull/1416.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1416.patch", "merged_at": 1607685811000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1416/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "hugoabonizio", "id": 1206395, "node_id": "MDQ6VXNlcjEyMDYzOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1206395?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hugoabonizio", "html_url": "https://github.com/hugoabonizio", "followers_url": "https://api.github.com/users/hugoabonizio/followers", "following_url": "https://api.github.com/users/hugoabonizio/following{/other_user}", "gists_url": "https://api.github.com/users/hugoabonizio/gists{/gist_id}", "starred_url": "https://api.github.com/users/hugoabonizio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hugoabonizio/subscriptions", "organizations_url": "https://api.github.com/users/hugoabonizio/orgs", "repos_url": "https://api.github.com/users/hugoabonizio/repos", "events_url": "https://api.github.com/users/hugoabonizio/events{/privacy}", "received_events_url": "https://api.github.com/users/hugoabonizio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq done! The failing testes don't seem to be related, it seems to be a connection issue, if I understand it correctly.", "@lhoestq done!", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1415", "html_url": "https://github.com/huggingface/datasets/pull/1415", "diff_url": "https://github.com/huggingface/datasets/pull/1415.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1415.patch", "merged_at": 1607963131000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1415/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mahajandiwakar", "id": 10516432, "node_id": "MDQ6VXNlcjEwNTE2NDMy", "avatar_url": "https://avatars.githubusercontent.com/u/10516432?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mahajandiwakar", "html_url": "https://github.com/mahajandiwakar", "followers_url": "https://api.github.com/users/mahajandiwakar/followers", "following_url": "https://api.github.com/users/mahajandiwakar/following{/other_user}", "gists_url": "https://api.github.com/users/mahajandiwakar/gists{/gist_id}", "starred_url": "https://api.github.com/users/mahajandiwakar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mahajandiwakar/subscriptions", "organizations_url": "https://api.github.com/users/mahajandiwakar/orgs", "repos_url": "https://api.github.com/users/mahajandiwakar/repos", "events_url": "https://api.github.com/users/mahajandiwakar/events{/privacy}", "received_events_url": "https://api.github.com/users/mahajandiwakar/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1414", "html_url": "https://github.com/huggingface/datasets/pull/1414", "diff_url": "https://github.com/huggingface/datasets/pull/1414.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1414.patch", "merged_at": 1607685460000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1414/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "hugoabonizio", "id": 1206395, "node_id": "MDQ6VXNlcjEyMDYzOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1206395?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hugoabonizio", "html_url": "https://github.com/hugoabonizio", "followers_url": "https://api.github.com/users/hugoabonizio/followers", "following_url": "https://api.github.com/users/hugoabonizio/following{/other_user}", "gists_url": "https://api.github.com/users/hugoabonizio/gists{/gist_id}", "starred_url": "https://api.github.com/users/hugoabonizio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hugoabonizio/subscriptions", "organizations_url": "https://api.github.com/users/hugoabonizio/orgs", "repos_url": "https://api.github.com/users/hugoabonizio/repos", "events_url": "https://api.github.com/users/hugoabonizio/events{/privacy}", "received_events_url": "https://api.github.com/users/hugoabonizio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hello @hugoabonizio, thanks for the contribution.\r\nRegarding the fake data, you can generate it manually.\r\nRunning the `python datasets-cli dummy_data datasets/offcombr` should give you instructions on how to manually create the dummy data.\r\nFor reference, here is a spec for `.arff` files : https://www.cs.waikato.ac.nz/ml/weka/arff.html", "@lhoestq again the failing tests doesn't seem to be related", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1413", "html_url": "https://github.com/huggingface/datasets/pull/1413", "diff_url": "https://github.com/huggingface/datasets/pull/1413.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1413.patch", "merged_at": 1607964670000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1413/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonatasgrosman", "id": 5097052, "node_id": "MDQ6VXNlcjUwOTcwNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/5097052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatasgrosman", "html_url": "https://github.com/jonatasgrosman", "followers_url": "https://api.github.com/users/jonatasgrosman/followers", "following_url": "https://api.github.com/users/jonatasgrosman/following{/other_user}", "gists_url": "https://api.github.com/users/jonatasgrosman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatasgrosman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatasgrosman/subscriptions", "organizations_url": "https://api.github.com/users/jonatasgrosman/orgs", "repos_url": "https://api.github.com/users/jonatasgrosman/repos", "events_url": "https://api.github.com/users/jonatasgrosman/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatasgrosman/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1412", "html_url": "https://github.com/huggingface/datasets/pull/1412", "diff_url": "https://github.com/huggingface/datasets/pull/1412.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1412.patch", "merged_at": 1607683270000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1412/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "dezow", "id": 47401160, "node_id": "MDQ6VXNlcjQ3NDAxMTYw", "avatar_url": "https://avatars.githubusercontent.com/u/47401160?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dezow", "html_url": "https://github.com/dezow", "followers_url": "https://api.github.com/users/dezow/followers", "following_url": "https://api.github.com/users/dezow/following{/other_user}", "gists_url": "https://api.github.com/users/dezow/gists{/gist_id}", "starred_url": "https://api.github.com/users/dezow/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dezow/subscriptions", "organizations_url": "https://api.github.com/users/dezow/orgs", "repos_url": "https://api.github.com/users/dezow/repos", "events_url": "https://api.github.com/users/dezow/events{/privacy}", "received_events_url": "https://api.github.com/users/dezow/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1411", "html_url": "https://github.com/huggingface/datasets/pull/1411", "diff_url": "https://github.com/huggingface/datasets/pull/1411.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1411.patch", "merged_at": 1607683145000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1411/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "harshalmittal4", "id": 24206326, "node_id": "MDQ6VXNlcjI0MjA2MzI2", "avatar_url": "https://avatars.githubusercontent.com/u/24206326?v=4", "gravatar_id": "", "url": "https://api.github.com/users/harshalmittal4", "html_url": "https://github.com/harshalmittal4", "followers_url": "https://api.github.com/users/harshalmittal4/followers", "following_url": "https://api.github.com/users/harshalmittal4/following{/other_user}", "gists_url": "https://api.github.com/users/harshalmittal4/gists{/gist_id}", "starred_url": "https://api.github.com/users/harshalmittal4/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/harshalmittal4/subscriptions", "organizations_url": "https://api.github.com/users/harshalmittal4/orgs", "repos_url": "https://api.github.com/users/harshalmittal4/repos", "events_url": "https://api.github.com/users/harshalmittal4/events{/privacy}", "received_events_url": "https://api.github.com/users/harshalmittal4/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@yjernite I have updated the PR to be language modeling task specific. Please review!\r\n", "Yes a line corresponds to a sentence in this data." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1410", "html_url": "https://github.com/huggingface/datasets/pull/1410", "diff_url": "https://github.com/huggingface/datasets/pull/1410.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1410.patch", "merged_at": 1608111503000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonatasgrosman", "id": 5097052, "node_id": "MDQ6VXNlcjUwOTcwNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/5097052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatasgrosman", "html_url": "https://github.com/jonatasgrosman", "followers_url": "https://api.github.com/users/jonatasgrosman/followers", "following_url": "https://api.github.com/users/jonatasgrosman/following{/other_user}", "gists_url": "https://api.github.com/users/jonatasgrosman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatasgrosman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatasgrosman/subscriptions", "organizations_url": "https://api.github.com/users/jonatasgrosman/orgs", "repos_url": "https://api.github.com/users/jonatasgrosman/repos", "events_url": "https://api.github.com/users/jonatasgrosman/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatasgrosman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I wrongly commited data from another branch in this PR, I'll close this a reopen another PR with the fixed branch" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1409", "html_url": "https://github.com/huggingface/datasets/pull/1409", "diff_url": "https://github.com/huggingface/datasets/pull/1409.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1409.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1409/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "MisbahKhan789", "id": 15351802, "node_id": "MDQ6VXNlcjE1MzUxODAy", "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MisbahKhan789", "html_url": "https://github.com/MisbahKhan789", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "type": "User", "site_admin": false }

[]

[]

[ "also don't forget to format your code using `make style` to fix the CI" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1408", "html_url": "https://github.com/huggingface/datasets/pull/1408", "diff_url": "https://github.com/huggingface/datasets/pull/1408.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1408.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1408/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @lhoestq,\r\n\r\nSeeing that it has been almost two months to this draft, I'm willing to take this forward if you and @abhishekkrthakur don't mind. :)", "Hi @gchhablani !\r\nSure if @abhishekkrthakur doesn't mind\r\nThanks for your help :)", "Please feel free :) ", "Hi @lhoestq, @abhishekkrthakur \r\n\r\nI believe this can be closed. Merged in #1829." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1407", "html_url": "https://github.com/huggingface/datasets/pull/1407", "diff_url": "https://github.com/huggingface/datasets/pull/1407.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1407.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1407/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "hugoabonizio", "id": 1206395, "node_id": "MDQ6VXNlcjEyMDYzOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1206395?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hugoabonizio", "html_url": "https://github.com/hugoabonizio", "followers_url": "https://api.github.com/users/hugoabonizio/followers", "following_url": "https://api.github.com/users/hugoabonizio/following{/other_user}", "gists_url": "https://api.github.com/users/hugoabonizio/gists{/gist_id}", "starred_url": "https://api.github.com/users/hugoabonizio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hugoabonizio/subscriptions", "organizations_url": "https://api.github.com/users/hugoabonizio/orgs", "repos_url": "https://api.github.com/users/hugoabonizio/repos", "events_url": "https://api.github.com/users/hugoabonizio/events{/privacy}", "received_events_url": "https://api.github.com/users/hugoabonizio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq done! (The failing tests don't seem to be related)", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1406", "html_url": "https://github.com/huggingface/datasets/pull/1406", "diff_url": "https://github.com/huggingface/datasets/pull/1406.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1406.patch", "merged_at": 1607962940000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1406/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pacman100", "id": 13534540, "node_id": "MDQ6VXNlcjEzNTM0NTQw", "avatar_url": "https://avatars.githubusercontent.com/u/13534540?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pacman100", "html_url": "https://github.com/pacman100", "followers_url": "https://api.github.com/users/pacman100/followers", "following_url": "https://api.github.com/users/pacman100/following{/other_user}", "gists_url": "https://api.github.com/users/pacman100/gists{/gist_id}", "starred_url": "https://api.github.com/users/pacman100/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pacman100/subscriptions", "organizations_url": "https://api.github.com/users/pacman100/orgs", "repos_url": "https://api.github.com/users/pacman100/repos", "events_url": "https://api.github.com/users/pacman100/events{/privacy}", "received_events_url": "https://api.github.com/users/pacman100/received_events", "type": "User", "site_admin": false }

[]

[]

[ "We want to keep the repo as light as possible so that it doesn't take ages to clone, that's why we ask for small dummy data files (especially when there are many of them). Let me know if you have questions or if we can help you on this", "Hello @lhoestq , made the changes as you suggested and pushed, please review. By default, the dummy data was generated the way it was by the dummy data auto generate command. Thank you." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1405", "html_url": "https://github.com/huggingface/datasets/pull/1405", "diff_url": "https://github.com/huggingface/datasets/pull/1405.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1405.patch", "merged_at": 1607886678000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1405/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "fixed @lhoestq " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1404", "html_url": "https://github.com/huggingface/datasets/pull/1404", "diff_url": "https://github.com/huggingface/datasets/pull/1404.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1404.patch", "merged_at": 1607951520000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1404/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tsvm", "id": 1083319, "node_id": "MDQ6VXNlcjEwODMzMTk=", "avatar_url": "https://avatars.githubusercontent.com/u/1083319?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tsvm", "html_url": "https://github.com/tsvm", "followers_url": "https://api.github.com/users/tsvm/followers", "following_url": "https://api.github.com/users/tsvm/following{/other_user}", "gists_url": "https://api.github.com/users/tsvm/gists{/gist_id}", "starred_url": "https://api.github.com/users/tsvm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tsvm/subscriptions", "organizations_url": "https://api.github.com/users/tsvm/orgs", "repos_url": "https://api.github.com/users/tsvm/repos", "events_url": "https://api.github.com/users/tsvm/events{/privacy}", "received_events_url": "https://api.github.com/users/tsvm/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Closing this pull request, will submit a new one for this dataset." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1403", "html_url": "https://github.com/huggingface/datasets/pull/1403", "diff_url": "https://github.com/huggingface/datasets/pull/1403.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1403.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1403/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "forest1988", "id": 2755894, "node_id": "MDQ6VXNlcjI3NTU4OTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/2755894?v=4", "gravatar_id": "", "url": "https://api.github.com/users/forest1988", "html_url": "https://github.com/forest1988", "followers_url": "https://api.github.com/users/forest1988/followers", "following_url": "https://api.github.com/users/forest1988/following{/other_user}", "gists_url": "https://api.github.com/users/forest1988/gists{/gist_id}", "starred_url": "https://api.github.com/users/forest1988/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/forest1988/subscriptions", "organizations_url": "https://api.github.com/users/forest1988/orgs", "repos_url": "https://api.github.com/users/forest1988/repos", "events_url": "https://api.github.com/users/forest1988/events{/privacy}", "received_events_url": "https://api.github.com/users/forest1988/received_events", "type": "User", "site_admin": false }

[]

[]

[ "README.md is not created yet. I'll add it soon.", "Thank you for your detailed code review! It's so helpful.\r\nI'll reflect them to the code in 24 hours.\r\n\r\nYou may have told me in Slack (I cannot find the conversation log though I've looked through threads), but I'm sorry it seems I'm still misunderstanding how to get YAML from the tagger.\r\nI'm now asking on Slack if I am looking at the tagger the wrong way.", "One more thing I'd like to ask.\r\nShould I make changes by myself, or can I use the \"Commit suggestion\" feature?\r\nI'm new to this feature and I don't know how the rules work in this repository, so I'd like to ask just in case.", "Thank you very much for merging!" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1402", "html_url": "https://github.com/huggingface/datasets/pull/1402", "diff_url": "https://github.com/huggingface/datasets/pull/1402.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1402.patch", "merged_at": 1607881656000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1402/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "saradhix", "id": 1351362, "node_id": "MDQ6VXNlcjEzNTEzNjI=", "avatar_url": "https://avatars.githubusercontent.com/u/1351362?v=4", "gravatar_id": "", "url": "https://api.github.com/users/saradhix", "html_url": "https://github.com/saradhix", "followers_url": "https://api.github.com/users/saradhix/followers", "following_url": "https://api.github.com/users/saradhix/following{/other_user}", "gists_url": "https://api.github.com/users/saradhix/gists{/gist_id}", "starred_url": "https://api.github.com/users/saradhix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/saradhix/subscriptions", "organizations_url": "https://api.github.com/users/saradhix/orgs", "repos_url": "https://api.github.com/users/saradhix/repos", "events_url": "https://api.github.com/users/saradhix/events{/privacy}", "received_events_url": "https://api.github.com/users/saradhix/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi @saradhix have you had the chance to reduce the size of the dummy data ?\r\n\r\nFeel free to ping me when it's done so we can merge :) ", "@lhoestq I have reduced the size of the dummy data manually and pushed the changes.", "The CI errors are not related to your dataset.\r\nThey're fixed on master, you can ignore them", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1401", "html_url": "https://github.com/huggingface/datasets/pull/1401", "diff_url": "https://github.com/huggingface/datasets/pull/1401.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1401.patch", "merged_at": 1608223842000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1401/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "SBrandeis", "id": 33657802, "node_id": "MDQ6VXNlcjMzNjU3ODAy", "avatar_url": "https://avatars.githubusercontent.com/u/33657802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SBrandeis", "html_url": "https://github.com/SBrandeis", "followers_url": "https://api.github.com/users/SBrandeis/followers", "following_url": "https://api.github.com/users/SBrandeis/following{/other_user}", "gists_url": "https://api.github.com/users/SBrandeis/gists{/gist_id}", "starred_url": "https://api.github.com/users/SBrandeis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SBrandeis/subscriptions", "organizations_url": "https://api.github.com/users/SBrandeis/orgs", "repos_url": "https://api.github.com/users/SBrandeis/repos", "events_url": "https://api.github.com/users/SBrandeis/events{/privacy}", "received_events_url": "https://api.github.com/users/SBrandeis/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1400", "html_url": "https://github.com/huggingface/datasets/pull/1400", "diff_url": "https://github.com/huggingface/datasets/pull/1400.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1400.patch", "merged_at": 1607951207000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1400/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq all comments addressed :) ", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1399", "html_url": "https://github.com/huggingface/datasets/pull/1399", "diff_url": "https://github.com/huggingface/datasets/pull/1399.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1399.patch", "merged_at": 1607943442000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1399/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "vinaykudari", "id": 34424769, "node_id": "MDQ6VXNlcjM0NDI0NzY5", "avatar_url": "https://avatars.githubusercontent.com/u/34424769?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vinaykudari", "html_url": "https://github.com/vinaykudari", "followers_url": "https://api.github.com/users/vinaykudari/followers", "following_url": "https://api.github.com/users/vinaykudari/following{/other_user}", "gists_url": "https://api.github.com/users/vinaykudari/gists{/gist_id}", "starred_url": "https://api.github.com/users/vinaykudari/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vinaykudari/subscriptions", "organizations_url": "https://api.github.com/users/vinaykudari/orgs", "repos_url": "https://api.github.com/users/vinaykudari/repos", "events_url": "https://api.github.com/users/vinaykudari/events{/privacy}", "received_events_url": "https://api.github.com/users/vinaykudari/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Refactored into new branch, please review :) ", "The `RemoteDatasetTest ` errors in the CI are fixed on master so it's fine", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1398", "html_url": "https://github.com/huggingface/datasets/pull/1398", "diff_url": "https://github.com/huggingface/datasets/pull/1398.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1398.patch", "merged_at": 1607536947000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1398/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tanmoyio", "id": 33005287, "node_id": "MDQ6VXNlcjMzMDA1Mjg3", "avatar_url": "https://avatars.githubusercontent.com/u/33005287?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tanmoyio", "html_url": "https://github.com/tanmoyio", "followers_url": "https://api.github.com/users/tanmoyio/followers", "following_url": "https://api.github.com/users/tanmoyio/following{/other_user}", "gists_url": "https://api.github.com/users/tanmoyio/gists{/gist_id}", "starred_url": "https://api.github.com/users/tanmoyio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tanmoyio/subscriptions", "organizations_url": "https://api.github.com/users/tanmoyio/orgs", "repos_url": "https://api.github.com/users/tanmoyio/repos", "events_url": "https://api.github.com/users/tanmoyio/events{/privacy}", "received_events_url": "https://api.github.com/users/tanmoyio/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1397", "html_url": "https://github.com/huggingface/datasets/pull/1397", "diff_url": "https://github.com/huggingface/datasets/pull/1397.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1397.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1397/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Karthik-Bhaskar", "id": 13200370, "node_id": "MDQ6VXNlcjEzMjAwMzcw", "avatar_url": "https://avatars.githubusercontent.com/u/13200370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Karthik-Bhaskar", "html_url": "https://github.com/Karthik-Bhaskar", "followers_url": "https://api.github.com/users/Karthik-Bhaskar/followers", "following_url": "https://api.github.com/users/Karthik-Bhaskar/following{/other_user}", "gists_url": "https://api.github.com/users/Karthik-Bhaskar/gists{/gist_id}", "starred_url": "https://api.github.com/users/Karthik-Bhaskar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthik-Bhaskar/subscriptions", "organizations_url": "https://api.github.com/users/Karthik-Bhaskar/orgs", "repos_url": "https://api.github.com/users/Karthik-Bhaskar/repos", "events_url": "https://api.github.com/users/Karthik-Bhaskar/events{/privacy}", "received_events_url": "https://api.github.com/users/Karthik-Bhaskar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Subsequent [PR #1426 ](https://github.com/huggingface/datasets/pull/1426) since this PR has uploaded other files along with the MultiReQA dataset.", "closing this one since a new PR has been created" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1396", "html_url": "https://github.com/huggingface/datasets/pull/1396", "diff_url": "https://github.com/huggingface/datasets/pull/1396.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1396.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1396/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq fixed :) " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1395", "html_url": "https://github.com/huggingface/datasets/pull/1395", "diff_url": "https://github.com/huggingface/datasets/pull/1395.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1395.patch", "merged_at": 1607941453000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1395/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq fixed :) " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1394", "html_url": "https://github.com/huggingface/datasets/pull/1394", "diff_url": "https://github.com/huggingface/datasets/pull/1394.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1394.patch", "merged_at": 1607941409000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "joeddav", "id": 9353833, "node_id": "MDQ6VXNlcjkzNTM4MzM=", "avatar_url": "https://avatars.githubusercontent.com/u/9353833?v=4", "gravatar_id": "", "url": "https://api.github.com/users/joeddav", "html_url": "https://github.com/joeddav", "followers_url": "https://api.github.com/users/joeddav/followers", "following_url": "https://api.github.com/users/joeddav/following{/other_user}", "gists_url": "https://api.github.com/users/joeddav/gists{/gist_id}", "starred_url": "https://api.github.com/users/joeddav/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/joeddav/subscriptions", "organizations_url": "https://api.github.com/users/joeddav/orgs", "repos_url": "https://api.github.com/users/joeddav/repos", "events_url": "https://api.github.com/users/joeddav/events{/privacy}", "received_events_url": "https://api.github.com/users/joeddav/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1393", "html_url": "https://github.com/huggingface/datasets/pull/1393", "diff_url": "https://github.com/huggingface/datasets/pull/1393.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1393.patch", "merged_at": 1607624225000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1393/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq fixed :) " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1392", "html_url": "https://github.com/huggingface/datasets/pull/1392", "diff_url": "https://github.com/huggingface/datasets/pull/1392.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1392.patch", "merged_at": 1607941352000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1392/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1391", "html_url": "https://github.com/huggingface/datasets/pull/1391", "diff_url": "https://github.com/huggingface/datasets/pull/1391.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1391.patch", "merged_at": 1607625584000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1391/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1390", "html_url": "https://github.com/huggingface/datasets/pull/1390", "diff_url": "https://github.com/huggingface/datasets/pull/1390.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1390.patch", "merged_at": 1607944432000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1390/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "hfawaz", "id": 29229602, "node_id": "MDQ6VXNlcjI5MjI5NjAy", "avatar_url": "https://avatars.githubusercontent.com/u/29229602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hfawaz", "html_url": "https://github.com/hfawaz", "followers_url": "https://api.github.com/users/hfawaz/followers", "following_url": "https://api.github.com/users/hfawaz/following{/other_user}", "gists_url": "https://api.github.com/users/hfawaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/hfawaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hfawaz/subscriptions", "organizations_url": "https://api.github.com/users/hfawaz/orgs", "repos_url": "https://api.github.com/users/hfawaz/repos", "events_url": "https://api.github.com/users/hfawaz/events{/privacy}", "received_events_url": "https://api.github.com/users/hfawaz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "`amazon_polarity` is probably a subset of `amazon_us_reviews` but I am not entirely sure about that.\r\nI guess `amazon_polarity` will help in reproducing results of papers using this dataset since even if it is a subset from `amazon_us_reviews`, it is not trivial how to extract `amazon_polarity` from `amazon_us_reviews`, especially since `amazon_us_reviews` was released after `amazon_polarity`. ", "do you know what the problem would be ? should I pull the master before ? @lhoestq ", "The error just appeared on master. I will try to fix it today.\r\nYou can ignore them since it's not related to the dataset you added", "merging since the CI is fixed on master", "Great thanks for the help. " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1389", "html_url": "https://github.com/huggingface/datasets/pull/1389", "diff_url": "https://github.com/huggingface/datasets/pull/1389.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1389.patch", "merged_at": 1607686861000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1389/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rahul-art", "id": 56379013, "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rahul-art", "html_url": "https://github.com/rahul-art", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "repos_url": "https://api.github.com/users/rahul-art/repos", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1388", "html_url": "https://github.com/huggingface/datasets/pull/1388", "diff_url": "https://github.com/huggingface/datasets/pull/1388.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1388.patch", "merged_at": null }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "hugoabonizio", "id": 1206395, "node_id": "MDQ6VXNlcjEyMDYzOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1206395?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hugoabonizio", "html_url": "https://github.com/hugoabonizio", "followers_url": "https://api.github.com/users/hugoabonizio/followers", "following_url": "https://api.github.com/users/hugoabonizio/following{/other_user}", "gists_url": "https://api.github.com/users/hugoabonizio/gists{/gist_id}", "starred_url": "https://api.github.com/users/hugoabonizio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hugoabonizio/subscriptions", "organizations_url": "https://api.github.com/users/hugoabonizio/orgs", "repos_url": "https://api.github.com/users/hugoabonizio/repos", "events_url": "https://api.github.com/users/hugoabonizio/events{/privacy}", "received_events_url": "https://api.github.com/users/hugoabonizio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq done! The failing testes don't seem to be related, it seems to be a connection issue, if I understand it correctly.", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1387", "html_url": "https://github.com/huggingface/datasets/pull/1387", "diff_url": "https://github.com/huggingface/datasets/pull/1387.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1387.patch", "merged_at": 1607963039000 }

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1387/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq yes. I asked the authors for direct link but unfortunately we need to fill a form (captcha)" ]