Datasets:

loubnabnl

/

pre-processed-issues

like 0

{ "number": 4622, "repo": "spark", "user_login": "apache" }

[ { "action": "opened", "author": "viirya", "comment_id": null, "datetime": 1424076267000, "masked_author": "username_0", "text": "Affinity Propagation (AP), a graph clustering algorithm based on the concept of \"message passing\" between data points. Unlike clustering algorithms such as k-means or k-medoids, AP does not require the number of clusters to be determined or estimated before running it. AP is developed by Frey and Dueck. Please refer to the [paper](http://www.psi.toronto.edu/affinitypropagation/FreyDueckScience07.pdf).", "title": "[SPARK-5832][Mllib] Add Affinity Propagation clustering algorithm", "type": "issue" }, { "action": "created", "author": "mengxr", "comment_id": 74559761, "datetime": 1424114694000, "masked_author": "username_1", "text": "@username_0 For new algorithms, we need to discuss whether we want to include it in MLlib on the JIRA page first (before implementing it). Could you describe more about this algorithm on the JIRA page, e.g., scalability, usage, and alternatives?", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 74622054, "datetime": 1424153796000, "masked_author": "username_0", "text": "@username_1 okay.", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 74638488, "datetime": 1424164888000, "masked_author": "username_0", "text": "@username_1 I updated the JIRA page. Please take a look. Thanks!", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 75284420, "datetime": 1424453901000, "masked_author": "username_0", "text": "@username_1 have we decided no to include this algorithm? If so, please let me know. Then I will close this pr and maintain it as third-party package. Thanks!", "title": null, "type": "comment" }, { "action": "created", "author": "mengxr", "comment_id": 75288067, "datetime": 1424455202000, "masked_author": "username_1", "text": "I didn't see `cartesian` in your code. So the complexity is really `O(nnz * k)` but not `O(n^2 * k)`, correct? This is the same complexity as PIC/PageRank. If this is the case, let's check the code.", "title": null, "type": "comment" }, { "action": "created", "author": "mengxr", "comment_id": 75297368, "datetime": 1424458423000, "masked_author": "username_1", "text": "@username_0 I made a pass on the code. Some high-level feedback:\r\n\r\n1. What is the expected size of the model? Should we store it distributively?\r\n2. Defining a private case class to replace `Seq(Double, Double, Double)` would make the code much easier to read.\r\n3. Please try to add a Java example, which helps test Java API compatibility.\r\n\r\nI will go through the algorithm part again after 2).", "title": null, "type": "comment" }, { "action": "created", "author": "mengxr", "comment_id": 89915614, "datetime": 1428294910000, "masked_author": "username_1", "text": "@username_0 Any plan to update this PR?", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 89915963, "datetime": 1428295333000, "masked_author": "username_0", "text": "@username_1 I will update this soon.", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 90643243, "datetime": 1428425469000, "masked_author": "username_0", "text": "@username_1 I updated for small comments. For the bigger ones, I will update later.", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 91229215, "datetime": 1428585490000, "masked_author": "username_0", "text": "@username_1 I have added a new function to automatically calculate the preferences used in AP algorithm. In fact, it just the median of similarities.\r\n\r\nBecause I use the function `percentile_approx` in Hive to calculate the median value, it has to add spark-hive as dependency of MLlib. I don't know if this is a good idea? How do you think?\r\n\r\nIf it is not, in order to provide this function to users, where it is better to put this in? Or it is better to implement a custom method to compute the median value?", "title": null, "type": "comment" }, { "action": "created", "author": "vanzin", "comment_id": 91299289, "datetime": 1428600275000, "masked_author": "username_2", "text": "spark-hive can be disabled (in fact it has to be explicitly enabled, it's disabled by default), while mllib cannot, so I guess that is a non-starter.", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 91304199, "datetime": 1428601218000, "masked_author": "username_0", "text": "Thanks @username_2, I think it might be a problem. I decided to move to custom method for median computation.", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 91319694, "datetime": 1428604196000, "masked_author": "username_0", "text": "@username_1 The model is now distributed. Edge messages and vertex data are defined as private case classes too. I will try to add Java examples later.", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 91601780, "datetime": 1428681789000, "masked_author": "username_0", "text": "@username_1 I have addressed all your comments. Please take a look. Thanks.", "title": null, "type": "comment" }, { "action": "created", "author": "dbtsai", "comment_id": 99354269, "datetime": 1430897393000, "masked_author": "username_3", "text": "General question. In euclidean space, the negative squared error is used as similarity. If we want to use affinity propagation to clustering lots of samples in euclidean space, it's impossible to create all the pairs of similarity data even it's symmetrical. What's the criteria to filter out those pairs which have very low similarity? Also, it's impossible to compute all the pairs of `RDD[Vector]` since it's O(N^2) operation, and how people address this in practice? \r\n\r\nI really like this algorithm, but still have concern about how people can use it in practice. \r\n\r\nThanks.", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 99541423, "datetime": 1430932472000, "masked_author": "username_0", "text": "@username_3 Thanks for comments and the question.\r\nI have no very good answer to the question. We have used a threshold to filter out the insignificant similarities of large scale data. As you said, it is impossible to compute all the pairs. However, the data we process is very high dimensional and very sparse, so the all-pair computation can be much reduced by only considering the pairs having corresponding dimensions with values more than zero (or a threshold defined).", "title": null, "type": "comment" }, { "action": "created", "author": "dbtsai", "comment_id": 99565738, "datetime": 1430937180000, "masked_author": "username_3", "text": "@username_0 Maybe you can comment on this in the documentation and in the comment of the code, and it will be useful for people trying to understand the use-case.", "title": null, "type": "comment" }, { "action": "created", "author": "viirya", "comment_id": 121487220, "datetime": 1436936041000, "masked_author": "username_0", "text": "@username_1 any plan to revisit this and merge it?", "title": null, "type": "comment" }, { "action": "created", "author": "rxin", "comment_id": 168112592, "datetime": 1451529759000, "masked_author": "username_4", "text": "I'm going to close this pull request. If this is still relevant and you are interested in pushing it forward, please open a new pull request. Thanks!", "title": null, "type": "comment" } ]

{ "number": 19, "repo": "ecco", "user_login": "twingly" }

[ { "action": "opened", "author": "walro", "comment_id": null, "datetime": 1462962909000, "masked_author": "username_0", "text": "", "title": "Use standard rvm key for jruby version", "type": "issue" }, { "action": "created", "author": "jage", "comment_id": 218425254, "datetime": 1462963767000, "masked_author": "username_1", "text": "LGTM!", "title": null, "type": "comment" } ]

{ "number": 55, "repo": "zmon-worker", "user_login": "zalando-zmon" }

[ { "action": "opened", "author": "hjacobs", "comment_id": null, "datetime": 1465311761000, "masked_author": "username_0", "text": "", "title": "Add .zappr.yaml", "type": "issue" }, { "action": "created", "author": "mohabusama", "comment_id": 224309980, "datetime": 1465311909000, "masked_author": "username_1", "text": "👍", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "Tybobobo", "comment_id": null, "datetime": 1476791562000, "masked_author": "username_0", "text": "When I look at this character, I do not believe the voice that the jumping voice is his. \r\nOn first impression, I get the impression he has a bit of a scrawny voice, not a deep \"Huff!\" :)", "title": "Audio clip for jumping does not feel like the character", "type": "issue" }, { "action": "created", "author": "oliver-ruehl", "comment_id": 258639773, "datetime": 1478379018000, "masked_author": "username_1", "text": "I have scheduled a session with my son to record some samples :)", "title": null, "type": "comment" }, { "action": "created", "author": "oliver-ruehl", "comment_id": 260120691, "datetime": 1478955467000, "masked_author": "username_1", "text": "Can we implment this globally so that ugly looping is not possible for SFX?", "title": null, "type": "comment" }, { "action": "created", "author": "oliver-ruehl", "comment_id": 261701480, "datetime": 1479544667000, "masked_author": "username_1", "text": "Added my sons voice. Im happy with the result", "title": null, "type": "comment" }, { "action": "closed", "author": "oliver-ruehl", "comment_id": null, "datetime": 1479544668000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "Colmea", "comment_id": null, "datetime": 1460538939000, "masked_author": "username_0", "text": "Just a reminder for the bug in the Arrow Helper.\r\n\r\n'origin' prop throws a warning on each frame: \"_warning.js:44 Warning: updating prop origin ( [object Object] ) for ArrowHelperDescripto_r\"\r\n\r\n\r\nI would like to help you but cannot undertand where I should fix this bug :D", "title": "[ArrowHelper] bug updating prop 'origin'", "type": "issue" }, { "action": "created", "author": "toxicFork", "comment_id": 209533714, "datetime": 1460565163000, "masked_author": "username_1", "text": "Thanks for the report, I remember it from the chat :) This will make it easier to track, I fill fix this as soon as possible!", "title": null, "type": "comment" }, { "action": "closed", "author": "toxicFork", "comment_id": null, "datetime": 1464463729000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

{ "number": 17, "repo": "node-stats", "user_login": "FreiFunkMuenster" }

[ { "action": "opened", "author": "badewanne", "comment_id": null, "datetime": 1492006917000, "masked_author": "username_0", "text": "68725136fad8 , 6872514a59e6 alias cosimo", "title": "id", "type": "issue" }, { "action": "created", "author": "MPW1412", "comment_id": 293689800, "datetime": 1492027018000, "masked_author": "username_1", "text": "Hallo Cosimo,\r\n\r\nwir haben nicht genau verstanden, was du hier gemacht hast. Du hättest das Repo forken müssen, dann die beiden IDs an der passenden Stelle in der Datei advnodes eintragen müssen. Und dann den PR von deinem Repo gegen dieses stellen sollen.\r\n\r\nIch mach das jetzt mal, das mir dem PR zeigen wir dir nochmal ;).\r\n\r\nGrüße\r\nMatthias", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "Flenix", "comment_id": null, "datetime": 1446139008000, "masked_author": "username_0", "text": "An old issue I had (https://github.com/MyEssentials/MyTown2/issues/289) seems to have returned. When a player makes a town, it's claiming the town as SERVER_ADMINS and telling him the land is already claimed. The town has zero claims, but the name is then used. The player can try making as many towns as they want, and it does this every time.\r\nIt seems to be player specific, as only happens to certain players (Or it did last time - I've not been able to test enough this time around)\r\n\r\nThe latest instance was happening with a new player called PHAT_Boy, trying to make a town called Col. There's a total of 40 towns on the server, 38 player owned, one actually owned by SERVER_ADMINS and then his town, which is also claimed as SERVER_ADMINS.\r\nIn case it's UUID-related, here's a sample of UUIDs from my server. PHAT_Boy is the problem player, while the others listed are all long term players who have the largest towns. \r\nhttp://pastebin.com/cGDLKv3R\r\n\r\nWe tested town creation with only that one player online, where the TPS was a solid 20, however when he initially joined the server there was 5 players online and the TPS was roughly 17.5 (due to a player flying a plane and loading chunks quickly)\r\n\r\nHere's some configs:\r\nDefaultFlags.json: http://pastebin.com/YS5STzsZ\r\nDefaultTownRanks.json: http://pastebin.com/ZvQKW0uE\r\nMyTown.cfg*: http://pastebin.com/WTaZp2A6\r\nWildPerms: http://pastebin.com/1yJLPLEG\r\n*Obviously DB info is removed.\r\n\r\nWe're using a MySQL database located on the same server.\r\nFull mod list: http://ctrlv.in/660031\r\n\r\nAnd finally, the server itself: https://www.hetzner.de/gb/hosting/produkte_rootserver/ex40 - 16GB of RAM is dedicated to the Minecraft instance. Only other things running on the server are a Jenkins installation (which hasn't been used for over a week), a TeamSpeak server and an IRC bot.\r\n\r\nLet me know if you need anything else.", "title": "Return of the SERVER_ADMINS", "type": "issue" }, { "action": "created", "author": "krwminer", "comment_id": 154741855, "datetime": 1446924931000, "masked_author": "username_1", "text": "I am going to close this down. Please re-open it if you ever get this error again. I will leave the debug in so we can narrow down the cause.", "title": null, "type": "comment" }, { "action": "closed", "author": "krwminer", "comment_id": null, "datetime": 1446924931000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "lmivan", "comment_id": null, "datetime": 1429772703000, "masked_author": "username_0", "text": "I'm using the last version of the plugin (6.0.0.4) and Grails 2.5.0 and when I execute `run-app` I get the following error:\r\n\r\n```\r\n| Error 2015-04-23 09:03:09,987 [localhost-startStop-1] ERROR context.GrailsContextLoaderListener - Error initializing the application: net/kencochrane/raven/event/Event$Level\r\nMessage: net/kencochrane/raven/event/Event$Level\r\n Line | Method\r\n->> 2701 | privateGetDeclaredMethods in java.lang.Class\r\n- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \r\n| 1975 | getDeclaredMethods in ''\r\n| 266 | run . . . . . . . . . . . in java.util.concurrent.FutureTask\r\n| 1142 | runWorker in java.util.concurrent.ThreadPoolExecutor\r\n| 617 | run . . . . . . . . . . . in java.util.concurrent.ThreadPoolExecutor$Worker\r\n^ 745 | run in java.lang.Thread\r\nCaused by ClassNotFoundException: net.kencochrane.raven.event.Event$Level\r\n->> 381 | findClass in java.net.URLClassLoader\r\n- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \r\n| 424 | loadClass in java.lang.ClassLoader\r\n| 357 | loadClass . . . . . . . . in ''\r\n| 2701 | privateGetDeclaredMethods in java.lang.Class\r\n| 1975 | getDeclaredMethods . . . in ''\r\n| 266 | run in java.util.concurrent.FutureTask\r\n| 1142 | runWorker . . . . . . . . in java.util.concurrent.ThreadPoolExecutor\r\n| 617 | run in java.util.concurrent.ThreadPoolExecutor$Worker\r\n^ 745 | run . . . . . . . . . . . in java.lang.Thread\r\n```\r\n\r\nIs this a know issue?", "title": "Error initializing the application: net/kencochrane/raven/event/Event$Level", "type": "issue" }, { "action": "created", "author": "benorama", "comment_id": 95507716, "datetime": 1429781008000, "masked_author": "username_1", "text": "There is some strange class loading issues with this lib. But I have not tested it against Grails 2.5.\nI'm currently migrating the plugin to Grails 3 and LogBack.\nIf I might have a look on this this next week or fix/pull request welcome ;)", "title": null, "type": "comment" }, { "action": "created", "author": "lmivan", "comment_id": 95508140, "datetime": 1429781068000, "masked_author": "username_0", "text": "Thank you.", "title": null, "type": "comment" }, { "action": "created", "author": "benorama", "comment_id": 95871909, "datetime": 1429868485000, "masked_author": "username_1", "text": "Hi Ivan,\r\n\r\nI could not reproduce the issue on two of our apps that I've migrated to Grails 2.5.0.\r\nIs it a blank new app or an existing app?\r\nWhich JVM do you use?\r\n\r\nI'm running:\r\n```\r\njava version \"1.8.0_25\"\r\nJava(TM) SE Runtime Environment (build 1.8.0_25-b17)\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "lmivan", "comment_id": 95879076, "datetime": 1429869471000, "masked_author": "username_0", "text": "It's an existing app and I'm using:\r\n\r\n```\r\njava version \"1.8.0_31\"\r\nJava(TM) SE Runtime Environment (build 1.8.0_31-b13)\r\nJava HotSpot(TM) 64-Bit Server VM (build 25.31-b07, mixed mode\r\n```\r\n\r\nI could try with a new app to see if it happen in my environment.", "title": null, "type": "comment" }, { "action": "created", "author": "anujku", "comment_id": 108083830, "datetime": 1433276123000, "masked_author": "username_2", "text": "@username_0 by any chance is it related to the Intellij ? I have seen classNotFound exceptions thanks to Intellij 14.0.11 or something version which was later solved by them.", "title": null, "type": "comment" }, { "action": "created", "author": "lmivan", "comment_id": 109180851, "datetime": 1433487517000, "masked_author": "username_0", "text": "@username_2: No, I always run my grails applications from the command line.", "title": null, "type": "comment" }, { "action": "created", "author": "rblazquez", "comment_id": 113511280, "datetime": 1434719747000, "masked_author": "username_3", "text": "java.lang.NoClassDefFoundError: net/kencochrane/raven/event/Event$Level\r\n\r\nSame problem here ... something new about this?\r\n\r\nThis is:\r\n\r\njava version \"1.7.0_71\"\r\nJava(TM) SE Runtime Environment (build 1.7.0_71-b14)\r\nJava HotSpot(TM) 64-Bit Server VM (build 24.71-b01, mixed mode)\r\n\r\nAND:\r\n\r\nGrails version: 2.4.3", "title": null, "type": "comment" }, { "action": "created", "author": "benorama", "comment_id": 113516585, "datetime": 1434720790000, "masked_author": "username_1", "text": "@username_3 no, we have not found the source of this issue, which occurs under certain conditions on existing apps.", "title": null, "type": "comment" }, { "action": "created", "author": "smallufo", "comment_id": 173821389, "datetime": 1453442867000, "masked_author": "username_4", "text": "I am having the same exception \r\n```\r\n[ERROR] 2016-01-22 14:01:53 context.GrailsContextLoaderListener - Error initializing the application: net/kencochrane/raven/event/Event\r\njava.lang.NoClassDefFoundError: net/kencochrane/raven/event/Event\r\n\tat java.lang.Class.privateGetDeclaredMethods(Class.java:2701)\r\n\tat java.lang.Class.getDeclaredMethods(Class.java:1975)\r\n\tat java.util.concurrent.FutureTask.run(FutureTask.java:266)\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\r\n\tat java.lang.Thread.run(Thread.java:745)\r\nCaused by: java.lang.ClassNotFoundException: net.kencochrane.raven.event.Event\r\n\tat java.net.URLClassLoader.findClass(URLClassLoader.java:381)\r\n\tat java.lang.ClassLoader.loadClass(ClassLoader.java:424)\r\n\tat java.lang.ClassLoader.loadClass(ClassLoader.java:357)\r\n```\r\n\r\nenv \r\n```\r\ngrails 2.5.3\r\n\r\n$ java -version\r\njava version \"1.8.0_66\"\r\nJava(TM) SE Runtime Environment (build 1.8.0_66-b17)\r\nJava HotSpot(TM) 64-Bit Server VM (build 25.66-b17, mixed mode)\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "ocomsoft", "comment_id": 177766799, "datetime": 1454303312000, "masked_author": "username_5", "text": "I am getting the same on Grails 2.3.11 and \r\njava version \"1.7.0_91\"\r\nOpenJDK Runtime Environment (IcedTea 2.6.3) (7u91-2.6.3-0ubuntu0.15.04.1)\r\nOpenJDK Server VM (build 24.91-b01, mixed mode)", "title": null, "type": "comment" }, { "action": "created", "author": "mhuebner", "comment_id": 179176888, "datetime": 1454498824000, "masked_author": "username_6", "text": "Having the same issue", "title": null, "type": "comment" }, { "action": "created", "author": "Nr9", "comment_id": 182487864, "datetime": 1455124470000, "masked_author": "username_7", "text": "Same issue!", "title": null, "type": "comment" }, { "action": "created", "author": "dbpfindexp", "comment_id": 255808410, "datetime": 1477330204000, "masked_author": "username_8", "text": "Anyone have a solution for this? I am trying with grails 2.5.3 and having the issue.", "title": null, "type": "comment" }, { "action": "created", "author": "dbpfindexp", "comment_id": 255820855, "datetime": 1477332847000, "masked_author": "username_8", "text": "Found the solution - disabled forked grails execution in your Config.groovy.", "title": null, "type": "comment" }, { "action": "closed", "author": "benorama", "comment_id": null, "datetime": 1477397153000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "benorama", "comment_id": 256016310, "datetime": 1477397153000, "masked_author": "username_1", "text": "Glad you found the solution !", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "Vexatos", "comment_id": null, "datetime": 1452251054000, "masked_author": "username_0", "text": "[This line](https://github.com/username_1/MoarPeripherals/blob/18f550a61c62c2d90feb3bb07214a23279f096ef/src/main/java/com/username_1/framework/peripheral/PeripheralProvider.java#L53) assumes that every Peripheral belongs to a TileEntity, so if there is a peripheral for a block that has no TileEntity, it will error. See the bug report at asiekierka/Computronics#173.", "title": "Error in log file for peripherals that do not belong to TileEntities", "type": "issue" }, { "action": "closed", "author": "theoriginalbit", "comment_id": null, "datetime": 1530836036000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

{ "number": 4109, "repo": "scikit-learn", "user_login": "scikit-learn" }

[ { "action": "opened", "author": "amueller", "comment_id": null, "datetime": 1421444055000, "masked_author": "username_0", "text": "Following up on #4039, minor fixes.", "title": "[MRG] Gmm tied covariance fixes from #4039", "type": "issue" }, { "action": "created", "author": "agramfort", "comment_id": 70359212, "datetime": 1421482954000, "masked_author": "username_1", "text": "besides LGTM", "title": null, "type": "comment" }, { "action": "created", "author": "agramfort", "comment_id": 70359214, "datetime": 1421482959000, "masked_author": "username_1", "text": "you'll need to rebase", "title": null, "type": "comment" }, { "action": "created", "author": "agramfort", "comment_id": 72710379, "datetime": 1422989542000, "masked_author": "username_1", "text": "thanks @username_0 !", "title": null, "type": "comment" }, { "action": "created", "author": "amueller", "comment_id": 72712423, "datetime": 1422990163000, "masked_author": "username_0", "text": "@username_1 thanks for the merge. But you didn't count you and your past self as two reviewers, did you? ;) Well I guess I and you both :+1:'ed the original PR.", "title": null, "type": "comment" }, { "action": "created", "author": "agramfort", "comment_id": 72726408, "datetime": 1422994853000, "masked_author": "username_1", "text": "lol ;)", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "wojtek-t", "comment_id": null, "datetime": 1445344250000, "masked_author": "username_0", "text": "### Background\r\nCurrently, to serve LIST operation in apiserver we do the following:\r\n- read all objects of a given resource from etcd\r\n- filter out objects that user is not interested in\r\n- return the result\r\n\r\nThis means, that complexity of LIST operation is proportional to the number of all objects of a given type, not to the number of objects returned to the user.\r\n\r\nAs an example, consider 1000-node cluster with 30.000 pods running in it. If a user has a ReplicationController with, say 10 replicas, then listing them requires requires reading all 30.000 from etcd, filtering them and returning just 10 which are interesting for the user.\r\n\r\n\r\n### Proposal\r\n\r\nWe would like to make the LIST operation proportional to the number of elements it returns as a result.\r\n\r\nWith the \"Cacher\" layer (used by watch in apiserver: #10475), we already store a copies of objects with a given type in apiserver so if we add an Indexer to it (which should be simple), we would be able to effectively serve list operations from it.\r\n\r\nThe problem is that a cache in apiserver is delayed (usually by tens to hundreds milliseconds). So if we just start to serve list operations from there we will change the semantics - e.g. it can happen that if you POST an object to apiserver and call LIST immediately after, the returned list may not contain already POSTed object.\r\n\r\nIn many cases, this doesn't really matter, for example if LIST is only done to start watching from that point, we will get eventual consistency anyway (just the starting point changes). However, it can possibly break some other clients.\r\n\r\nI can see 3 main options:\r\n- just change the semantics\r\n- add an option (parameter) to LIST operation to force listing from database; however, in this case we should probably make listing from database by switched off by default to take advantage from it wherever it's possible\r\n- change the LIST operation to take ResourceVersion paramater and ensure that what we return in a result is no older than the given ResourceVersion (however, to make it efficient, we don't give any guarantees on how fresh the result is - we only promise to return the result not older than the given ResourceVersion).\r\n\r\n[The third option is the best in my opinion].\r\n\r\nWhat do you think about it?\r\n\r\n@kubernetes/goog-control-plane @kubernetes/goog-csi \r\n@username_2 @brendandburns @username_4 @username_3 \r\n@username_1 @derekwaynecarr", "title": "Speed-up LIST operations by serving them from memory", "type": "issue" }, { "action": "created", "author": "smarterclayton", "comment_id": 149580847, "datetime": 1445350499000, "masked_author": "username_1", "text": "Today, we don't enforce that guarantee necessarily in a cluster because we\ndon't specify quorum=true reads. This will make it more likely though.\n\nWe had proposed taking the resourceVersion as minimum read before, I'm in\nfavor of that as well.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 149581461, "datetime": 1445350651000, "masked_author": "username_0", "text": "We had proposed taking the resourceVersion as minimum read before, I'm in\r\nfavor of that as well.\r\n\r\nWas this discussed somewhere on github? I didn't see that...", "title": null, "type": "comment" }, { "action": "created", "author": "smarterclayton", "comment_id": 149588541, "datetime": 1445352108000, "masked_author": "username_1", "text": "Very old https://github.com/kubernetes/kubernetes/pull/846#issuecomment-54387892", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 149625173, "datetime": 1445358929000, "masked_author": "username_2", "text": "@username_0 and I discussed this IRL yesterday and I'm also in favor of accepting a resourceVersion on list. It means clients that care have to change, e.g. kubectl may want to cache the resource version it got on a POST for reuse in a subsequent LIST.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 149625547, "datetime": 1445359019000, "masked_author": "username_2", "text": "@username_0 do you plan on fixing watches at the same time or will that be a second step? I think most of the benefit is quite possibly in fixing the number of times the watches invoke filterfuncs...", "title": null, "type": "comment" }, { "action": "created", "author": "smarterclayton", "comment_id": 149630123, "datetime": 1445359722000, "masked_author": "username_1", "text": "We *might* want to make clients stateful and observe this themselves.", "title": null, "type": "comment" }, { "action": "created", "author": "bgrant0607", "comment_id": 149630631, "datetime": 1445359854000, "masked_author": "username_3", "text": "Hah. I'm not the only one who remembers old issues. :-)\r\n\r\nI'm in favor of accepting resourceVersion on GET, as well, as you could guess from that comment. That would only help new, smart clients, however.\r\n\r\nAn option not mentioned was implementing a full-blown cache coherence protocol, to invalidate on write and subsequently fetch the most recent copy of the resource.", "title": null, "type": "comment" }, { "action": "created", "author": "quinton-hoole", "comment_id": 149636592, "datetime": 1445361200000, "masked_author": "username_4", "text": "@username_3 that's the write-through cache that I proposed above. It sounds like you're also in favor of that.\r\n\r\nWhile the \"minimum resource version on get\" option is theoretically correct, it does impose quite a burden on less sophisticated client developers. We will definitely cause a lot of difficult to track down bugs in clients which write and then read dumbly, no matter how loudly we tell developers not to do that.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 149647105, "datetime": 1445363671000, "masked_author": "username_2", "text": "That sounds quite complex-- does a write on apiserver A invalidate the cache of apiserver B? It must, to be useful, but then we're replicating much of etcd's functionality.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 149647908, "datetime": 1445363858000, "masked_author": "username_2", "text": "I can see making a correct write-through cache on a single apiserver by just stopping the world until your write shows up in the watch from etcd.\r\n\r\nSimply adding the written object to the cache before seeing it in the watch means that you decouple the cache's state from etcd's state and sounds dangerous-but-possibly-fixable in the single apiserver case, and infeasible in the multiple apiserver case.", "title": null, "type": "comment" }, { "action": "created", "author": "erictune", "comment_id": 149651031, "datetime": 1445364609000, "masked_author": "username_5", "text": "Seems like the \"semantics\" you are worried about changing already happen in an HA cluster? I think that is what clayton means in his comment about quorum=true (though even with quorum=true a read could still occasionally get stale data I think?)\r\n\r\nIf so, then isn't option 1 the best choice?", "title": null, "type": "comment" }, { "action": "created", "author": "erictune", "comment_id": 149652403, "datetime": 1445364935000, "masked_author": "username_5", "text": "Also, option 4: \r\nAdd indexer to cache. Within a single apiserver, queue up pending requests, the do the following:\r\n```\r\nfor ever:\r\n refresh cache and indexes\r\n while (head of queue is readonly op):\r\n pop(head) and handle op using cache/index\r\n while (head of queue is read/write op):\r\n pop(head) and handle op using direct etcd access.\r\n```\r\n\r\nThis maintains the \"semantics\" in the case of a single apiserver, and in the case of multiple apiservers with session affinity (which I predict will become common for larger clusters).", "title": null, "type": "comment" }, { "action": "created", "author": "erictune", "comment_id": 149653471, "datetime": 1445365172000, "masked_author": "username_5", "text": "Option 4 does not require updating the cache bit by bit, and so may be much less bug-prone and easier to implement.\r\n\r\nAssuming read operations are 10x to 1000x more common than write operations, then you still get huge batching benefits.\r\n\r\nAlso, since many writes are going to be status updates, and since the semantics you want to preserve are less relevant for status writes, you could possibly modify the algorithm to handle \"readonly and status-only-writing\" operations in a single batch. That would increase the reuse frequency of the cache and indices.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 149666278, "datetime": 1445367207000, "masked_author": "username_2", "text": "@username_5 I don't see how that works. How does apiserver know that a given\nlist needs to see a given write?", "title": null, "type": "comment" }, { "action": "created", "author": "erictune", "comment_id": 149670481, "datetime": 1445368041000, "masked_author": "username_5", "text": "In option 4, it conservatively assume that all reads need to see any write.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 149673009, "datetime": 1445368518000, "masked_author": "username_2", "text": "OK, so that's what I said above \"I can see making a correct write-through cache on a single apiserver by just stopping the world until your write shows up in the watch from etcd\" + go to etcd instead of stopping the world.\r\n\r\nThe problem with going to etcd is that it reverts to n^2 behavior for a little bit after every write. Since the time for the cache to see the write should be measured in 100's of ms, I think it may be better to just block everyone until it shows up.", "title": null, "type": "comment" }, { "action": "created", "author": "erictune", "comment_id": 149676270, "datetime": 1445369408000, "masked_author": "username_5", "text": "Okay, what @username_2 said SGTM.", "title": null, "type": "comment" }, { "action": "created", "author": "smarterclayton", "comment_id": 149689460, "datetime": 1445372080000, "masked_author": "username_1", "text": "Yuck. This still seems like an optimization for infrastructure components\nand advanced clients, so forcing clients to be smarter is 100% ok by me.\nNo one runs list all namespaces who isn't a list watcher and a reflector.\nI'd prefer to optimize smart clients first.", "title": null, "type": "comment" }, { "action": "created", "author": "bgrant0607", "comment_id": 149771690, "datetime": 1445398657000, "masked_author": "username_3", "text": "In addition to caching performed by the apiserver, caching is also performed outside it, in clients, but potentially also in intermediate caches.\r\n\r\nWe do have to make it possible for a client to DTRT in the presence of an arbitrary number of intermediate caches. So, we at least need the resourceVersion-based solution.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 149807609, "datetime": 1445413757000, "masked_author": "username_0", "text": "Simply adding the written object to the cache before seeing it in the watch means that you decouple the cache's state from etcd's state and sounds dangerous-but-possibly-fixable in the single apiserver case, and infeasible in the multiple apiserver case.\r\n\r\nI completely agree.\r\n\r\n\r\nSo do I understand correctly, that we want to do resourceVersion-based solution first and then possibly implement something more difficult in the future (if needed)? I think that's reasonable.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 149952624, "datetime": 1445444970000, "masked_author": "username_2", "text": "@username_0, SGTM", "title": null, "type": "comment" }, { "action": "created", "author": "smarterclayton", "comment_id": 150015605, "datetime": 1445459395000, "masked_author": "username_1", "text": "When you say intermediate caches, which ones are you referring to? Anyone\nusing an intermediate cache is probably doing so for resilience or\nperformance, and is by definition a sophisticated client. The vast\nmajority of clients have no sophistication. If we accept multiple\napiservers, DTRT for unsophisticated clients is slow but correct. DTRT for\nsophisticated clients is resource version tracking with resource version\npreconditions. What else do we need?\n\nOn Wed, Oct 21, 2015 at 12:29 PM, Daniel Smith <notifications@github.com>\nwrote:\n\n> @username_0, SGTM\n>\n>", "title": null, "type": "comment" }, { "action": "created", "author": "janetkuo", "comment_id": 161491592, "datetime": 1449107366000, "masked_author": "username_6", "text": "This may affect deployment. Deployment needs to keep track of the number of available pods, scale rcs accordingly, and make sure the number of available pods is within a certain range (depends on deployment strategy).", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 161539530, "datetime": 1449127277000, "masked_author": "username_0", "text": "@username_6 - it will be possible to still list \"the current\" version from etcd (by setting parameters correctly). So it will not be breaking change.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 161620943, "datetime": 1449145949000, "masked_author": "username_0", "text": "The initial version (without indexers) is very close to be done.\r\n\r\nHowever, after some deeper thinking I would like to suggest a slightly different semantics:\r\n\r\n1. if \"resourceVersion\" parameter is NOT specified for the request (today this is the case for all requests), we still serve this request from etcd\r\n\r\n2. if \"resourceVersion\" parameter is specified for the request - than we only guarantee that the returned result is at least that fresh\r\n\r\n This makes this mechanism backward compatible (which I think is a huge advantage).\r\n\r\n However, to do it, we need to be able to distinguish set & not-set \"resourceVersion\". And to do it, I would need to change the \"storage.Interface\":\r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/storage/interfaces.go#L74\r\nso that resourceVersion is passed as string there (not uin64). \r\n\r\n If we do that - it's easy to distinguish empty and non-empty string (it doesn't work for uint64, because it should be fine to set \"0\" as resourceVersion if we don't need any guarantees).\r\n\r\n@username_2 @username_1 @username_7 - any thoughts on it ^^", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 161725814, "datetime": 1449164177000, "masked_author": "username_2", "text": "@username_0 I agree with your suggested semantics (actually I thought that's what we were going to do originally-- maybe I misunderstood).\r\n\r\nAnother solution--possibly less invasive--is to make it a pointer so you can pass nil.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 161726527, "datetime": 1449164342000, "masked_author": "username_0", "text": "@username_2 - I'm also fine with pointer, but since in the whole system we are using \"resourceVersion\" as string - see e.g.\r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go#L96\r\n\r\nit would be more consistent to pass it as string (we will not need any transformations in that case).", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 161736290, "datetime": 1449166480000, "masked_author": "username_2", "text": "By which you mean the transformations can be hidden behind the storage\ninterface? I think I'm fine with that.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 161737378, "datetime": 1449166761000, "masked_author": "username_0", "text": "I think I'm fine with that.\r\n\r\nThanks - I will prepare a PR tomorrow.", "title": null, "type": "comment" }, { "action": "created", "author": "smarterclayton", "comment_id": 161782282, "datetime": 1449176213000, "masked_author": "username_1", "text": "Yes, hiding RV transformation behind storage is right.\n\nQuestion on 2\n\n- as a controller doing list watch - If I list, I don't specify RV. I get\nthe latest. If I watch from that RV it's extremely likely to be current\n(as close as possible)\n- as a sophisticated client, if I specify RV, I get RV or newer or an error?", "title": null, "type": "comment" }, { "action": "created", "author": "timothysc", "comment_id": 161797937, "datetime": 1449179911000, "masked_author": "username_7", "text": "While I like this, I wonder at what point can we/should we just be passing a constraint filter to the kV store itself. \r\n\r\n@xiang90 ^ SELECT resource FROM table WHERE (constraint)", "title": null, "type": "comment" }, { "action": "created", "author": "smarterclayton", "comment_id": 161819584, "datetime": 1449184487000, "masked_author": "username_1", "text": "Range scans are part of the etcd 3 API design.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 161906693, "datetime": 1449217374000, "masked_author": "username_0", "text": "- as a controller doing list watch - If I list, I don't specify RV. I get\r\nthe latest. If I watch from that RV it's extremely likely to be current\r\n(as close as possible)\r\n- as a sophisticated client, if I specify RV, I get RV or newer or an error?\r\n\r\nI'm afraid I didn't fully understand your question.\r\n\r\n[Once this is implemented] if you specify RV in the LIST operation, you are guaranteed to get at least that fresh response. However, you also get the exact RV from which the results is returned. So you can then start watching from exactly that point.\r\nDoes it answer your question or I misunderstood it?", "title": null, "type": "comment" }, { "action": "created", "author": "smarterclayton", "comment_id": 161999322, "datetime": 1449243681000, "masked_author": "username_1", "text": "My original concern was a change that breaks naive clients. I was trying\nto validate that naive clients (no rv) are unaffected. The question about\nerror was for expired rv versions or rv versions in the future for List.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 162000029, "datetime": 1449243860000, "masked_author": "username_0", "text": "Yes - naive clients will be unaffected.\r\n\r\nPassing rv for list that is old - will result in returning ~current state (the guarantee that the result is at least that fresh as the rv passed, is then satisfied).\r\nPassing rv that is in the future, will simply block the LIST call until then.", "title": null, "type": "comment" }, { "action": "created", "author": "smarterclayton", "comment_id": 162000745, "datetime": 1449244027000, "masked_author": "username_1", "text": "How long do we block for? Timeout specified on request? What error is\nreturned on timeout (our server timeout error)?\n\nHow long do we block for? Timeout specified on request? What error is\nreturned on timeout (our server timeout error)?\n\nOn Dec 4, 2015, at 10:44 AM, Wojciech Tyczynski <notifications@github.com>\nwrote:\n\nYes - naive clients will be unaffected.\n\nPassing rv for list that is old - will result in returning ~current state\n(the guarantee that the result is at least that fresh as the rv passed, is\nthen satisfied).\nPassing rv that is in the future, will simply block the LIST call until\nthen.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 162437977, "datetime": 1449473712000, "masked_author": "username_0", "text": "How long do we block for? Timeout specified on request? What error is\r\nreturned on timeout (our server timeout error)?\r\n\r\nCurrently specific timeout is not supported (other than the default http server timeouts, which is a generic mechanism IIUC). Do you think it's not enough?", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 179285015, "datetime": 1454512166000, "masked_author": "username_0", "text": "Actually, @username_2 added timeout in #20433", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 179526412, "datetime": 1454541769000, "masked_author": "username_2", "text": "I randomly made it 60 seconds, I think we need to be defensive about clients asking for RVs in the distant future (or from other collections).", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 179685167, "datetime": 1454570114000, "masked_author": "username_0", "text": "@username_2 - what do you mean by \"or from other collections\" ?", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 180087162, "datetime": 1454625890000, "masked_author": "username_2", "text": "E.g., reading from /pods, sending that RV to /services.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 180232424, "datetime": 1454656614000, "masked_author": "username_0", "text": "That shouldn't be a big deal - resource version is common for all resources (there is a single RV in etcd). I agree that technically it's incorrect, but that shouldn't cause problems in my opinion.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 180240953, "datetime": 1454658625000, "masked_author": "username_2", "text": "It *does* cause problems, though! See the other commit in #20433. Someone read from one table, passed that (big) RV into list of services. But the service watch RV was stuck at the last service write, *not* the global number--which had since advanced--so apiserver hung on startup.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 180241792, "datetime": 1454658809000, "masked_author": "username_2", "text": "And anyway, clients need to treat it as separate, because we could swap out the storage, like we do with events.", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 180244896, "datetime": 1454659820000, "masked_author": "username_0", "text": "I agree that client need to treat is as separate - I just though that it's not urgent...", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 181566519, "datetime": 1454965343000, "masked_author": "username_2", "text": "Anything left to do here? @username_0 can we close this?", "title": null, "type": "comment" }, { "action": "created", "author": "wojtek-t", "comment_id": 181745126, "datetime": 1455002949000, "masked_author": "username_0", "text": "The missing thing here is the Indexer mechanism. But this is definitely not for 1.2 and I think we can create a separate issue for it.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 182142313, "datetime": 1455063171000, "masked_author": "username_2", "text": "#4817 already exists, we can reuse that. Thanks!", "title": null, "type": "comment" }, { "action": "closed", "author": "lavalamp", "comment_id": null, "datetime": 1455063171000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]

{ "number": 1288, "repo": "AndroidN-ify", "user_login": "wasdennnoch" }

[ { "action": "opened", "author": "numeprenume", "comment_id": null, "datetime": 1484072011000, "masked_author": "username_0", "text": "", "title": "Fix Neko crash, improve notifications & status bar header", "type": "issue" }, { "action": "created", "author": "paphonbth", "comment_id": 271785020, "datetime": 1484114145000, "masked_author": "username_1", "text": "What are the header improvements?", "title": null, "type": "comment" }, { "action": "created", "author": "paphonbth", "comment_id": 271785022, "datetime": 1484114147000, "masked_author": "username_1", "text": "What are the header improvements?", "title": null, "type": "comment" }, { "action": "created", "author": "numeprenume", "comment_id": 271794400, "datetime": 1484118307000, "masked_author": "username_0", "text": "Basically increased the width according to how it is in N and enabled 2 rows in landscape. I don't know if you had it disabled on purpose, but I've been using it for 2 weeks without any problem.", "title": null, "type": "comment" }, { "action": "created", "author": "yzyboost", "comment_id": 272076851, "datetime": 1484197386000, "masked_author": "username_2", "text": "When will merge these?", "title": null, "type": "comment" }, { "action": "created", "author": "paphonbth", "comment_id": 272687264, "datetime": 1484477159000, "masked_author": "username_1", "text": "I need to do some changes to support theming then it'll be merged.", "title": null, "type": "comment" }, { "action": "created", "author": "numeprenume", "comment_id": 272691481, "datetime": 1484482629000, "masked_author": "username_0", "text": "I have some more changes to commit, should I do that now or wait until you finish your changes? @username_1", "title": null, "type": "comment" }, { "action": "created", "author": "wasdennnoch", "comment_id": 272694544, "datetime": 1484486161000, "masked_author": "username_3", "text": "If the changes are related to this PR you can push them, create a new branch if it's something different.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "hkuhn42", "comment_id": null, "datetime": 1452076477000, "masked_author": "username_0", "text": "The readme does not event give a hint on how to download opennlp-models and wordnet on a windows machine. At least a hint to GnutWget (or a link to https://eternallybored.org/misc/wget/ ) would be nice", "title": "readme is not very windows friendly", "type": "issue" }, { "action": "created", "author": "drewfarris", "comment_id": 191023846, "datetime": 1456886185000, "masked_author": "username_1", "text": "Appreciate the pull request.", "title": null, "type": "comment" }, { "action": "closed", "author": "drewfarris", "comment_id": null, "datetime": 1456886185000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

{ "number": 140, "repo": "gman", "user_login": "benbalter" }

[ { "action": "created", "author": "jbjonesjr", "comment_id": 252527527, "datetime": 1476064351000, "masked_author": "username_0", "text": ":+1:", "title": null, "type": "comment" }, { "action": "created", "author": "benbalter", "comment_id": 252663355, "datetime": 1476114915000, "masked_author": "username_1", "text": "Thanks @domjtalbot!", "title": null, "type": "comment" } ]

{ "number": 23, "repo": "sharedb-mongo", "user_login": "share" }

[ { "action": "opened", "author": "vmakhaev", "comment_id": null, "datetime": 1451510796000, "masked_author": "username_0", "text": "Rewrote to use cursor methods instead deprecated operators.\r\nUses last mongodb 2.1 syntax.\r\nTransforms user query operators to cursor methods.\r\n$orderby -> .sort()\r\n$skip -> .skip()\r\n$limit -> .limit()\r\n\r\nPasses tests.", "title": "mongo 3.2 support", "type": "issue" }, { "action": "created", "author": "ovvn", "comment_id": 172533880, "datetime": 1453125768000, "masked_author": "username_1", "text": "+1", "title": null, "type": "comment" }, { "action": "created", "author": "Dignifiedquire", "comment_id": 172540489, "datetime": 1453127315000, "masked_author": "username_2", "text": "@username_0 looks like this needs a rebase or merge with the latest master branch as there seem to be merge conflicts", "title": null, "type": "comment" }, { "action": "created", "author": "vmakhaev", "comment_id": 172566794, "datetime": 1453132092000, "masked_author": "username_0", "text": "@username_2 I would be happy to merge it with master branch if there will be any reaction from @nateps to know if this PR gonna be accepted or rejected", "title": null, "type": "comment" }, { "action": "created", "author": "avital", "comment_id": 215790201, "datetime": 1461946791000, "masked_author": "username_3", "text": "I fixed merge conflicts locally and test this pull request against Mongo 2.6, 3.0 and 3.2 and they all pass the [improved test suite](https://github.com/share/sharedb-mongo/pull/31).\r\n\r\nBTW an easy way to run different versions of Mongo in parallel is with Docker:\r\n```sh\r\ndocker run -p 27017:27017 mongo:2.6\r\ndocker run -p 27018:27017 mongo:3.0\r\ndocker run -p 27019:27017 mongo:3.2\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "avital", "comment_id": 215796821, "datetime": 1461947596000, "masked_author": "username_3", "text": "We need to also figure out the plan for the other \"`metaOperators`\", such as [`$comment`](https://docs.mongodb.org/manual/reference/operator/meta/comment/). And there should be probably be a test for each.", "title": null, "type": "comment" }, { "action": "created", "author": "avital", "comment_id": 215801077, "datetime": 1461948144000, "masked_author": "username_3", "text": "I filed a new issue to document and test all the metaOperators. https://github.com/share/sharedb-mongo/issues/33", "title": null, "type": "comment" }, { "action": "created", "author": "avital", "comment_id": 221140922, "datetime": 1464052570000, "masked_author": "username_3", "text": "Superseded by #33", "title": null, "type": "comment" } ]

{ "number": 40, "repo": "gaiden", "user_login": "getninjas" }

[ { "action": "opened", "author": "MarcoBrunoBR", "comment_id": null, "datetime": 1478805265000, "masked_author": "username_0", "text": "**CHANGELOG** :memo:\r\n\r\nCreated service__title components", "title": "Created service__title components", "type": "issue" }, { "action": "created", "author": "GeorgeJegon", "comment_id": 259786180, "datetime": 1478806626000, "masked_author": "username_1", "text": "Would be nice to had a print to see how this component looks like 😁 \r\nFor example, i don't know why we are defining `before/after` with `39%` as width value", "title": null, "type": "comment" }, { "action": "created", "author": "eduardojmatos", "comment_id": 259791097, "datetime": 1478807837000, "masked_author": "username_2", "text": "@username_0 the `sass-lint` is showing some errors to fix", "title": null, "type": "comment" }, { "action": "created", "author": "eduardojmatos", "comment_id": 259813861, "datetime": 1478813622000, "masked_author": "username_2", "text": "@username_0 :shipit:", "title": null, "type": "comment" } ]

{ "number": 1, "repo": "ngconf2016", "user_login": "DeborahK" }

[ { "action": "opened", "author": "johnlindquist", "comment_id": null, "datetime": 1462836594000, "masked_author": "username_0", "text": "Hi Deborah!\r\n\r\nI thought the `valueChanges` approach for validation was a little unwieldy so I thought I'd update the part I saw on a slide of your ngconf presentation to using a more declarative approach with template validation and .ng-invalid.\r\n\r\nCheers,\r\nJohn", "title": "An example of moving validation into the templates and using .ng-inva…", "type": "issue" }, { "action": "created", "author": "DeborahK", "comment_id": 218028792, "datetime": 1462840282000, "masked_author": "username_1", "text": "Hey John! Thanks for your suggestion.\r\nDid you see in the slides/talk that I covered *3* approaches?\r\n1) Template driven ... with the code in the template (similar to what you did here). The code for that is in the movie-edit-template.component.* files.\r\n2) Partial model-driven ... with the code partially in the template and partially in the component class. The code for that is in the movie-edit-model.component.* files.\r\n3) Fully model-driven ... with the code *primarily* in the component class. That allows for unit testing of the code and for more advanced logic scenarios (such as retrieving the messages from a file/table or adjusting the validation/messages based on the user, etc).\r\nOr is there something different that you have done here than what I provided in movie-edit-template.component.*?\r\nThanks again!", "title": null, "type": "comment" }, { "action": "created", "author": "johnlindquist", "comment_id": 218034849, "datetime": 1462843125000, "masked_author": "username_0", "text": "I do understand the differences between the approaches so I was mostly speeding through the recording of your video, but let me backup a bit:\r\n\r\nWhat caught my eye was how you were using `valueChanges` in the \"fully-model driven\" approach. Instead of moving everything into the template, I should have shown what I would have done with combining streams in Rx to achieve what was written the `subscribe` block. I believe if you're going to use streams (such as `valueChanges`) that messages/errors/etc should all be separate streams that you would subscribe to and create off of the `valueChanges` stream. I'll create a separate pull request to explain what I mean.\r\n\r\nI did jump the gun without seeing that you already implemented template approach, but I did add your `range` validator to a custom validator directive just for fun. :)", "title": null, "type": "comment" } ]

{ "number": 281, "repo": "aurelia-materialize-bridge", "user_login": "aurelia-ui-toolkits" }

[ { "action": "opened", "author": "Ullfis", "comment_id": null, "datetime": 1474444066000, "masked_author": "username_0", "text": "Issue:\r\n\r\n- Loading data from server and change tooltip doesn't update tooltip text.\r\n\r\nRelated? #266", "title": "fix(md-tooltip): update tooltip when tooltip text change", "type": "issue" }, { "action": "created", "author": "Thanood", "comment_id": 248538622, "datetime": 1474444571000, "masked_author": "username_1", "text": "Thank you! :+1:", "title": null, "type": "comment" } ]

{ "number": 5, "repo": "google-distance-matrix", "user_login": "ecteodoro" }

[ { "action": "opened", "author": "schwimmfuzzi", "comment_id": null, "datetime": 1477854149000, "masked_author": "username_0", "text": "Let me know if there are any issues =)", "title": "added arrival_time option", "type": "issue" }, { "action": "created", "author": "ecteodoro", "comment_id": 257188073, "datetime": 1477869918000, "masked_author": "username_1", "text": "👍", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "geocine", "comment_id": null, "datetime": 1474362651000, "masked_author": "username_0", "text": "I want to suggest supporting the Postman Collection Schema https://schema.getpostman.com/ for document generation", "title": "Suggestion to support postman collection for document generation", "type": "issue" }, { "action": "created", "author": "RomanGotsiy", "comment_id": 248452493, "datetime": 1474410026000, "masked_author": "username_1", "text": "Unfortunately, this is out-of-scope of this project. Postman btw has it's own documentation.\r\nMaybe there is a convertor from postman collection schema to swagger", "title": null, "type": "comment" }, { "action": "closed", "author": "RomanGotsiy", "comment_id": null, "datetime": 1474410026000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "sahas-", "comment_id": null, "datetime": 1465778247000, "masked_author": "username_0", "text": "is there a way to do append new objects to a file?", "title": "does it support append file?", "type": "issue" }, { "action": "created", "author": "ajsingh007", "comment_id": 228241266, "datetime": 1466735143000, "masked_author": "username_1", "text": "I have the same question. Its working well for me but it overwrites the existing json rather than adding to it", "title": null, "type": "comment" }, { "action": "created", "author": "dudleyjosh", "comment_id": 228849883, "datetime": 1467055802000, "masked_author": "username_2", "text": "Same here... this would be a perfect little json to file utility if it included fs.appendFile() and fs.appendFileSync() functionality too.", "title": null, "type": "comment" }, { "action": "created", "author": "SCBuergel", "comment_id": 236989924, "datetime": 1470161089000, "masked_author": "username_3", "text": ":+1: without this I cant use it.", "title": null, "type": "comment" }, { "action": "created", "author": "kamikazechaser", "comment_id": 239619645, "datetime": 1471093143000, "masked_author": "username_4", "text": "please support append file", "title": null, "type": "comment" }, { "action": "created", "author": "andela-anandaa", "comment_id": 287753621, "datetime": 1490015272000, "masked_author": "username_5", "text": "See [my comments here](https://github.com/username_7/node-jsonfile/issues/67#issuecomment-287752793), I think it's related.\r\n\r\nI had a similar issue, wanted to to hack our `package.json` file to update the `browser` key depending on the environment, and this approach worked okay. \r\n\r\n**TL;DR - read the file in the object, update the update, and write the object back to the file afresh.**", "title": null, "type": "comment" }, { "action": "created", "author": "RyanZim", "comment_id": 297041063, "datetime": 1493129164000, "masked_author": "username_6", "text": "As discussed in https://github.com/username_7/node-jsonfile/issues/67, you can use `Object.assign` to accomplish something like this. You can't truly append to a JSON file in the filesystem sense, so I don't see the point of adding this syntax sugar to jsonfile.\r\n\r\n@username_7 what are your thoughts here?", "title": null, "type": "comment" }, { "action": "created", "author": "jprichardson", "comment_id": 297087423, "datetime": 1493137848000, "masked_author": "username_7", "text": "Agreed. I'd prefer to rework (move to its own section) the README a bit to make it very clear and distinct on the two cases of appending or updating.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "rtsisyk", "comment_id": null, "datetime": 1439997279000, "masked_author": "username_0", "text": "```\r\nbox/transaction.test.lua [ fail ]\r\n\r\nTest failed! Result content mismatch:\r\n--- box/transaction.result Mon Aug 17 18:00:18 2015\r\n+++ box/transaction.reject Wed Aug 19 18:12:26 2015\r\n@@ -231,7 +231,7 @@\r\n -- It's rolled back automatically\r\n s:select{};\r\n ---\r\n-- []\r\n+- - [1, 'Must be rolled back']\r\n ...\r\n function sloppy()\r\n box.begin()\r\n@@ -252,11 +252,11 @@\r\n ...\r\n t;\r\n ---\r\n-- []\r\n-...\r\n-s:select{};\r\n----\r\n-- []\r\n+- - [1, 'first row']\r\n+...\r\n+s:select{};\r\n+---\r\n+- - [1, 'Must be rolled back']\r\n ...\r\n s:drop();\r\n ---\r\n```\r\n\r\n\r\n```\r\nbox/transaction.test.lua [ fail ]\r\n\r\nTest failed! Result content mismatch:\r\n--- box/transaction.result Mon Aug 17 18:00:18 2015\r\n+++ box/transaction.reject Wed Aug 19 18:12:16 2015\r\n@@ -252,7 +252,7 @@\r\n ...\r\n t;\r\n ---\r\n-- []\r\n+- - [1, 'first row']\r\n ...\r\n s:select{};\r\n ---\r\n```", "title": "box/transaction.test.lua spontaneously fails ", "type": "issue" }, { "action": "closed", "author": "kostja", "comment_id": null, "datetime": 1447428627000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "kostja", "comment_id": 156464143, "datetime": 1447428627000, "masked_author": "username_1", "text": "Haven't seen this for a while.", "title": null, "type": "comment" } ]

{ "number": 1067, "repo": "rdkit", "user_login": "rdkit" }

[ { "action": "opened", "author": "ptosco", "comment_id": null, "datetime": 1474035368000, "masked_author": "username_0", "text": "- Small change to enable timings to be collected on Windows with Python 3", "title": "Timings on Windows with Python 3", "type": "issue" }, { "action": "created", "author": "greglandrum", "comment_id": 247903925, "datetime": 1474254012000, "masked_author": "username_1", "text": "@username_0 what about doing it this way instead?\r\n```(py27_rdkit) glandrum@Otter:/scratch/RDKit_git/Regress/Scripts$ git diff\r\ndiff --git a/Regress/Scripts/timings.py b/Regress/Scripts/timings.py\r\nindex 88e42cf..5dfc486 100644\r\n--- a/Regress/Scripts/timings.py\r\n+++ b/Regress/Scripts/timings.py\r\n@@ -15,7 +15,7 @@ if len(sys.argv)>1:\r\n tests[x] = 1\r\n ts = []\r\n \r\n-sdData = gzip.open('../Data/mols.1000.sdf.gz','rt').read()\r\n+sdData = gzip.open('../Data/mols.1000.sdf.gz').read()\r\n logger.info('mols from sdf')\r\n suppl = Chem.SDMolSupplier()\r\n suppl.SetData(sdData)\r\n@@ -34,13 +34,13 @@ logger.info('Results1: %.2f seconds, %d passed, %d failed'%(t2-t1,nMols,nBad))\r\n ts.append(t2-t1)\r\n \r\n if tests[2]:\r\n- lines = gzip.open('../Data/mols.1000.txt.gz','rt').readlines()\r\n+ lines = gzip.open('../Data/mols.1000.txt.gz').readlines()\r\n logger.info('mols from smiles')\r\n nMols=0\r\n nBad=0\r\n t1=time.time()\r\n for line in lines:\r\n- line = line.strip().split(' ')\r\n+ line = line.decode().strip().split(' ')\r\n m = Chem.MolFromSmiles(line[1])\r\n if m:\r\n nMols+=1\r\n@@ -51,8 +51,8 @@ if tests[2]:\r\n ts.append(t2-t1)\r\n \r\n if tests[3] or tests[4] or tests[5]:\r\n- pattData = gzip.open('../Data/queries.txt.gz','rt').readlines()\r\n- pattData = [x.strip().replace('[H]','').replace('()','') for x in pattData]\r\n+ pattData = gzip.open('../Data/queries.txt.gz').readlines()\r\n+ pattData = [x.decode().strip().replace('[H]','').replace('()','') for x in pattData]\r\n logger.info('patterns from smiles')\r\n patts = []\r\n t1=time.time()\r\n@@ -224,6 +224,6 @@ if tests[17]:\r\n ts.append(t2-t1)\r\n \r\n \r\n- \r\n+\r\n \r\n print('times: ',' || '.join(['%.1f'%x for x in ts]))\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "ptosco", "comment_id": 248112915, "datetime": 1474316377000, "masked_author": "username_0", "text": "Yes, of course. I have become overly paranoid about 'rt' and 'rb' in connection with Windows because of the CR+LF issue, but here I can relax :-)", "title": null, "type": "comment" } ]

{ "number": 107, "repo": "preact-www", "user_login": "developit" }

[ { "action": "opened", "author": "malcolmyu", "comment_id": null, "datetime": 1489310990000, "masked_author": "username_0", "text": "1. Add space between Chinese characters and letters.\r\n2. Replace all half-width punctuation by full-width punctuation.\r\n3. Fixe spelling mistakes.\r\n4. Optimize expression.\r\n5. Use more authentic statements.", "title": "doc: Optimize Chinese Document", "type": "issue" }, { "action": "created", "author": "lcxfs1991", "comment_id": 285938484, "datetime": 1489318234000, "masked_author": "username_1", "text": "Thank you! Let me take a look tmr. @username_0", "title": null, "type": "comment" }, { "action": "created", "author": "malcolmyu", "comment_id": 296052430, "datetime": 1492747833000, "masked_author": "username_0", "text": "好的，其实就是用的[这个工具](https://github.com/vinta/pangu.js)……", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "kevinonik", "comment_id": null, "datetime": 1472990450000, "masked_author": "username_0", "text": "Hello,\r\n\r\nFirst of all great work. I just made a wrapper for webservice calling using alamofire. I need to insert your library in that wrapper but since you used it for uiviewcontroller only it is quite not achievable by me. Can you help me out.\r\n\r\n\r\n`\r\n\r\n\r\n \r\n class func serviceCall(urlEnum: URLRequestConvertible, vC : UIViewController, success:(JSON) -> Void, failure:(NSError) -> Void) {**\r\n \r\n let size = CGSize(width: 30, height:30)\r\n vC.startActivityAnimating(size, message: \"Loading...\", type: NVActivityIndicatorType(rawValue: 9)!)\r\n \r\n \r\n \r\n Alamofire.request(urlEnum).responseJSON { (responseObject) -> Void in\r\n \r\n print(responseObject)\r\n \r\n if responseObject.result.isSuccess {\r\n let resJson = JSON(responseObject.result.value!)\r\n success(resJson)\r\n }\r\n if responseObject.result.isFailure {\r\n let error : NSError = responseObject.result.error!\r\n failure(error)\r\n }\r\n }\r\n }`\r\n\r\n\r\nAbove is my a function in my wrapper class.", "title": "How to add this in an object file rather than using it in view controllers", "type": "issue" }, { "action": "created", "author": "ninjaprox", "comment_id": 244739440, "datetime": 1473079778000, "masked_author": "username_1", "text": "@username_0: I'm not sure why the above snippet doesn't work for you, could you explain more? Apart from `UIViewController`, you can purely create `NVActivityIndicatorView` which is subclass of `UIView`and use it by your own way.", "title": null, "type": "comment" }, { "action": "created", "author": "dernster", "comment_id": 244841514, "datetime": 1473132351000, "masked_author": "username_2", "text": "@username_0 you can create a dummy view controller like\r\n\r\n```swift\r\nclass PresenterViewController: UIViewController, NVActivityIndicatorViewable { }\r\n```\r\n\r\nand then use it from anywhere:\r\n\r\n```swift\r\nlet presenter = PresenterViewController()\r\npresenter.startActivityAnimating(...)\r\n```\r\n\r\nSince the current implementation of the start and stop activity functions don't really need anything from the view controller maybe the framework should also expose those methods from a singleton instance or something like that. What do you think?", "title": null, "type": "comment" }, { "action": "created", "author": "ninjaprox", "comment_id": 244948147, "datetime": 1473168177000, "masked_author": "username_1", "text": "Well I think decoupling it from view controller is good idea. With `PresenterViewController` user can display UI blocker wherever and still have convenient call from `UIViewController` that conforms `NVActivityIndicatorViewable`.", "title": null, "type": "comment" }, { "action": "created", "author": "kevinonik", "comment_id": 247245957, "datetime": 1473920688000, "masked_author": "username_0", "text": "Thanks", "title": null, "type": "comment" }, { "action": "closed", "author": "ninjaprox", "comment_id": null, "datetime": 1473947372000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

{ "number": 1237, "repo": "rubygems", "user_login": "rubygems" }

[ { "action": "opened", "author": "whip112", "comment_id": null, "datetime": 1430331969000, "masked_author": "username_0", "text": "", "title": "Create yahpay-iron-core", "type": "issue" }, { "action": "created", "author": "drbrain", "comment_id": 97534499, "datetime": 1430332453000, "masked_author": "username_1", "text": "This seems like abuse, closing.", "title": null, "type": "comment" } ]

{ "number": 118, "repo": "bootstrap-social", "user_login": "lipis" }

[ { "action": "opened", "author": "jacknguyen", "comment_id": null, "datetime": 1467329428000, "masked_author": "username_0", "text": "", "title": "Font Awesome 4.6.3", "type": "issue" }, { "action": "created", "author": "lipis", "comment_id": 229818935, "datetime": 1467330159000, "masked_author": "username_1", "text": "🍻", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "sriv", "comment_id": null, "datetime": 1450702515000, "masked_author": "username_0", "text": "ref : https://github.com/getgauge/gauge-ruby/issues/17\r\n\r\nAlthough this came up when @cococoder found an issue with pry + gauge-ruby, this is because of the way Gauge treats the Stdout stream from the runners.\r\n\r\nGauge-core redirects stdout, stderr from the runner. Pry brings up a REPL for users to use, and this causes stdin characters to be reflected in stdout immediately. Gauge intercepts this stdout writes and logs them in a new line.", "title": "Stdin input is printed as log", "type": "issue" }, { "action": "closed", "author": "kashishm", "comment_id": null, "datetime": 1452154518000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "kashishm", "comment_id": 169592052, "datetime": 1452154518000, "masked_author": "username_1", "text": "Fixed via 08ee26c3e6354be9974571f42a618a22a3f4e559", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "trunet", "comment_id": null, "datetime": 1480857433000, "masked_author": "username_0", "text": "It uses a completely new API. More info on https://developer.honeywell.com/content/getting-started-guide.\r\n\r\n\r\n\r\nI didn't find any python library to deal with the new API.", "title": "Support Honeywell Lyric Thermostat", "type": "issue" }, { "action": "created", "author": "jzwack", "comment_id": 264976436, "datetime": 1480971806000, "masked_author": "username_1", "text": "Should be pretty straightforward... does home assistant support auth code OAuth2 flow via a browser?", "title": null, "type": "comment" }, { "action": "created", "author": "trunet", "comment_id": 287303702, "datetime": 1489741973000, "masked_author": "username_0", "text": "This is still not added to latest home-assistant. home-assistant support oauth2 on the webui.", "title": null, "type": "comment" }, { "action": "created", "author": "trunet", "comment_id": 305718542, "datetime": 1496390558000, "masked_author": "username_0", "text": "hello, there is a custom_component that make the deal. should be easy to port to trunk.\r\n\r\ncheck this post:\r\nhttps://community.home-assistant.io/t/honeywell-lyric-thermostat/3520/52", "title": null, "type": "comment" }, { "action": "created", "author": "trunet", "comment_id": 338270980, "datetime": 1508520443000, "masked_author": "username_0", "text": "hello, the thread is still going on, we still should have lyric support available", "title": null, "type": "comment" }, { "action": "created", "author": "jonathanweinberg", "comment_id": 371230385, "datetime": 1520446252000, "masked_author": "username_2", "text": "Thread is still trucking!", "title": null, "type": "comment" } ]

{ "number": 105, "repo": "osin", "user_login": "RangelReale" }

[ { "action": "opened", "author": "UrielCh", "comment_id": null, "datetime": 1450448125000, "masked_author": "username_0", "text": "- add a default salted Password implementation in client.go\r\n- the new Implementation is tested in client_test.go\r\n- reduce and improce utilitise function in urlvalidate.go", "title": "Add a default salted Password implementation + Testing + Small code improvement.", "type": "issue" }, { "action": "created", "author": "UrielCh", "comment_id": 166155305, "datetime": 1450645885000, "masked_author": "username_0", "text": "thx for your feed back.", "title": null, "type": "comment" }, { "action": "created", "author": "UrielCh", "comment_id": 166372423, "datetime": 1450720106000, "masked_author": "username_0", "text": "Change completed :)", "title": null, "type": "comment" }, { "action": "created", "author": "UrielCh", "comment_id": 166408546, "datetime": 1450729522000, "masked_author": "username_0", "text": "Patched again.", "title": null, "type": "comment" }, { "action": "created", "author": "UrielCh", "comment_id": 166477060, "datetime": 1450749068000, "masked_author": "username_0", "text": "patched again.", "title": null, "type": "comment" }, { "action": "created", "author": "UrielCh", "comment_id": 166690517, "datetime": 1450806994000, "masked_author": "username_0", "text": "I had some more small patch to reduce duplicate code and code size.\r\ncan I submit them in this PR ?", "title": null, "type": "comment" }, { "action": "created", "author": "liggitt", "comment_id": 166691578, "datetime": 1450807328000, "masked_author": "username_1", "text": "@username_3 has the definitive answer, but my preference would be to limit this to the salted client example", "title": null, "type": "comment" }, { "action": "created", "author": "UrielCh", "comment_id": 166740720, "datetime": 1450821304000, "masked_author": "username_0", "text": "okey just my local change in access.go\r\n\r\nit's time for final comments", "title": null, "type": "comment" }, { "action": "created", "author": "leetal", "comment_id": 167762253, "datetime": 1451385010000, "masked_author": "username_2", "text": "To me this PR seems OK, but with some smaller spelling mistakes. The pros is that this does not mess with the base implementation (other than improving it), and the cons is that it adds three new dependencies and also a new client that we need to mess with in case of updates. \r\n\r\nNevertheless, I'm in favor of a PR.", "title": null, "type": "comment" }, { "action": "created", "author": "UrielCh", "comment_id": 168949303, "datetime": 1451986957000, "masked_author": "username_0", "text": "I'm back :)\r\n\r\nIs my go docs are all Ok? As you can guess I'm not a native english speaker.", "title": null, "type": "comment" }, { "action": "created", "author": "RangelReale", "comment_id": 169664896, "datetime": 1452173516000, "masked_author": "username_3", "text": "Like #107, I don't think this belongs on the library, for the library to be simple, it shoudl just focus on the spec, this kind of thing I think would be better on another repository. If it is generic enough, I could point to it on the README.", "title": null, "type": "comment" }, { "action": "created", "author": "arekkas", "comment_id": 169709276, "datetime": 1452182979000, "masked_author": "username_4", "text": "Hi, I am the author of [Hydra](https://github.com/ory-am/hydra) and am currently writing an security-first framework for OAuth2 a osin-familiar API called [**fosite**](https://github.com/ory-am/fosite). If your changes don't make it to osin, as username_3 validly pointed out (and I believe the [same](https://github.com/username_3/osin/issues/107#issuecomment-169708348)), feel free to check it out. I am looking forward to any contributions, problems or use cases. :)", "title": null, "type": "comment" }, { "action": "created", "author": "UrielCh", "comment_id": 170510662, "datetime": 1452510656000, "masked_author": "username_0", "text": "I know your Hydra project I will probably contribute to it in the next Weeks.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "tnordberg", "comment_id": null, "datetime": 1441217673000, "masked_author": "username_0", "text": "When the `doc` parameter of the autoForm changes, child afQuickFields should update accordingly. However, the fileUpload preview image does not react. Clicking the Reset button seems to force a refresh and the expected preview image is displayed. Is this as intended?\r\n\r\nIn the following example, the `title` (text input) will correctly update when the`activeSlide` helper changes, but the `background` (fileUpload) preview image does not change until the Reset button is clicked. \r\n```html\r\n{{#autoForm id=\"form_editSlide\" collection=\"Slides\" doc=activeSlide}}\r\n {{> afQuickField name=\"title\"}}\r\n {{> afQuickField name=\"background\"}}\r\n <button type=\"submit\" class=\"btn btn-primary\">Submit</button>\r\n <button type=\"reset\" class=\"btn btn-default\">Reset</button>\r\n{{/autoForm}}\r\n```", "title": "Preview image not reactive to document change.", "type": "issue" }, { "action": "created", "author": "kristijanbambir", "comment_id": 138381100, "datetime": 1441661705000, "masked_author": "username_1", "text": "+1\r\nAnd I can say that this issue was not present in version 0.2.5.", "title": null, "type": "comment" }, { "action": "created", "author": "mpowaga", "comment_id": 145528601, "datetime": 1444051934000, "masked_author": "username_2", "text": "This should be fixed in 0.3.0.", "title": null, "type": "comment" }, { "action": "created", "author": "ralph-fuechtenkort", "comment_id": 163791220, "datetime": 1449792166000, "masked_author": "username_3", "text": "I still have the same problem on 0.4.0 even with the reset button. Any comment on this?", "title": null, "type": "comment" }, { "action": "created", "author": "caffpain", "comment_id": 184989892, "datetime": 1455677878000, "masked_author": "username_4", "text": "I'm using yogiben:autoform-file@0.4.2 and still have this problem. Anyone got a workaround?", "title": null, "type": "comment" }, { "action": "created", "author": "kuka", "comment_id": 185704042, "datetime": 1455799279000, "masked_author": "username_5", "text": "+1, experienced just now.\r\n\r\nAny workaround or ideas?", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "S--Minecraft", "comment_id": null, "datetime": 1473776841000, "masked_author": "username_0", "text": "- [ ] awef#18 Bookmark APIのクオータ対策が不十分\r\n- [ ] awef#23 read.crxを開いているタブが別サイトに移動したとき、「read.crx 2 を終了しています」ウィンドウが開きっぱなしになる\r\n- [ ] awef#25 全角半角混じりのアンカーの参照判定が誤っている\r\n- [ ] awef#38 2chのdatの差分取得\r\n- [ ] awef#40 AAと判定したレスの改行抑止、縮小表示機能\r\n- [ ] awef#44 最終閲覧位置の保存方式の変更\r\n- [ ] awef#46 投稿履歴\r\n- [ ] awef#53 /view/index.htmlと、そこに埋め込んだiframe間の通信をしっかり整理すべき\r\n- [ ] awef#57 画像として扱うURLのパターンを正規表現で指定するオプション機能\r\n- [ ] awef#62 2chのサーバー移転時に、移転前のデータが残留していた場合に対する対応\r\n- [ ] awef#64 ブックマークが重複してしまっている場合が有る\r\n- [ ] awef#67 DAT落ちしているスレの既読情報更新処理に改善が必要\r\n- [ ] awef#68 スレ内検索時、ヒットしたレスの前後の流れを把握するのが面倒\r\n- [ ] awef#69 テーブルの各項目を任意にリサイズ、及び表示/非表示の変更を出来るようにすべき\r\n- [ ] awef#71 ブラウザのリロードボタンを押した時、read.crx 2のタブがフリーズを起こす場合が有る\r\n- [ ] awef#72 1000レスを超えたスレで、スレが終わっていなくても「次スレ検索」のボタンが表示されてしまう\r\n- [ ] awef#74 IndexedDBへの移行\r\n- [ ] awef#75 コンテキストメニューはmenu要素で実装するべき\r\n- [ ] awef#76 閲覧したことのないスレッドと、未読数0のスレッドが判別出来無いのは問題\r\n- [ ] awef#77 古いキャッシュ/履歴のみを削除する機能\r\n- [ ] awef#79 板/スレ内検索は、変換中の文字列を無視するべき\r\n- [ ] awef#84 1001まで到達したスレッドを開いた時、自動で次スレ検索を行っても良いのではないか\r\n- [ ] awef#85 板一覧からも次スレ検索が出来るようにすべき\r\n- [ ] awef#92 IP表示にも、ID表示のようにカウント/ポップアップ機能が有るべき\r\n- [ ] awef#93 書き込みダイアログの名前欄/メール欄に、履歴からのオートコンプリート\r\n- [ ] awef#97 板一覧表示中の板も右クリックからブックマークに追加/削除出来るようにするべき\r\n- [ ] awef#99 各種検索ボックスをinput[type=\"search\"]にすべき\r\n- [ ] awef#101 板内/スレ内検索ボックス内に入力した文字列と、ヒット数文字列が重なってしまう\r\n- [ ] awef#102 前スレへのアンカー対応\r\n- [ ] awef#103 DAT落ち検出時にも次スレ検索ボタンが表示されるべき\r\n- [ ] awef#106 投稿ダイアログの埋め込み表示\r\n- [ ] awef#107 エラーメッセージの改善が必要\r\n- [ ] awef#110 タブの固定（閉じないようにする）機能\r\n- [ ] awef#111 タブの横幅は揃えるべき\r\n- [ ] awef#112 ポップアップの表示方法を「クリック」に設定した時、アンカーポップアップにも反映する事を検討すべき\r\n- [ ] awef#113 スレッド検索の検索結果もソート出来るようにするべき\r\n- [ ] awef#114 スレッド検索は初回20件程表示するべき\r\n- [ ] awef#116 板ブックマークを任意の順番に並び替えられるように\r\n- [ ] awef#117 IDポップアップ内で同一のIDにポップアップ操作を行った時、ポップアップをせずに代替メッセージを表示すべき\r\n- [ ] awef#121 chrome.storage経由のブックマークの閲覧状況の同期\r\n- [ ] awef#122 ブックマークを任意に並び替え可能に\r\n- [ ] awef#123 板名も検索出来るようにすべき\r\n- [ ] awef#124 新着スレッドの監視機能\r\n- [ ] awef#125 2chのスレッド一覧データ破損に対する何らかの対策が必要\r\n- [ ] awef#126 スレ内/板内検索の挙動をChromeのページ内検索と同等の物に変更\r\n- [ ] awef#127 オートリロード\r\n- [ ] awef#128 「同一のタブ内で開かれるリンク以外は新規タブで開く」設定\r\n- [ ] awef#129 戻る/進むボタンをクリック長押し、もしくは右クリックで履歴を表示する機能\r\n- [ ] awef#132 タブの戻る/進むボタンをミドルクリックした時に、新しいタブで該当するタブを開く\r\n- [ ] awef#133 optional_permissionsへの移行\r\n- [ ] awef#134 タブのリサイズ時、実際の要素をリアルタイムにリサイズしないようにする\r\n- [ ] awef#135 P2経由での書き込み機能の利用方法が解り辛い\r\n- [ ] awef#136 リンクにコンテキストメニュー追加\r\n- [ ] awef#137 JSLint、もしくはJSHint等のツールを導入する事を検討\r\n- [ ] awef#139 サムネイル表示に画像サイズ情報を追加\r\n- [ ] awef#142 >>3-1のようなアンカーは内部的に>>1-3と同等に扱うべき\r\n- [ ] awef#143 ID表示を「何個目の書き込みか」が解るよう改良\r\n- [ ] awef#151 Gnome環境でinputにフォーカスがあっている状態で他の部位をミドルクリックした時、inputに選択テキストの貼り付けが実行されてしまう\r\n- [ ] awef#153 ブックマーク保存処理の改修\r\n- [ ] awef#162 独自のログ記録/表示システムを備えるべき\r\n- [ ] awef#164 起動時にタブを復元しないオプションの追加\r\n- [ ] awef#165 起動時のタブ復元が完了する前にread.crx 2を閉じてしまうと、次回起動時に復元されないタブが生じる場合が有る\r\n- [ ] awef#166 スレタイ検索の結果表示にも未読数を表示すべき\r\n- [ ] awef#169 次スレ検索の検索結果の表示項目を、板一覧と同程度にまで拡充すべき\r\n- [ ] awef#170 2chとドメインの規則が異なるサイトも閲覧できるようにすべき\r\n- [ ] awef#172 現在のブックマーク保存フォルダを表示する機能\r\n- [ ] awef#173 キーボードショートカットによる書き込み窓のオープン\r\n- [ ] awef#174 アイコンのみで表現されている、ラベルの無いボタンには必ずツールチップによる説明が存在するべき\r\n- [ ] awef#175 ファイル構造について見直すべき\r\n- [ ] awef#178 Chromeのブックマーク以外の同期手段\r\n- [ ] awef#179 テストの大部分をPhantomJSでも通るようにする\r\n- [ ] awef#181 Chrome Appsで無効化されている機能に関する対応\r\n- [ ] awef#183 「read.crx 2 で開く」で開いたタブがアクティブにならない場合が有る\r\n- [ ] awef#184 初回起動前に「read.crx 2 で開く」を使用した場合、タブが開かれない\r\n- [ ] awef#186 ブックマーク表示への板名表示追加\r\n- [ ] awef#190 bower導入", "title": "本家issue", "type": "issue" }, { "action": "created", "author": "S--Minecraft", "comment_id": 246703431, "datetime": 1473777598000, "masked_author": "username_0", "text": "- awef#18\r\n- awef#23\r\n- awef#25\r\n- awef#38 htmlの差分取得は実装 datは未実装\r\n- awef#40\r\n- awef#44\r\n- awef#46 実装済み\r\n- awef#53\r\n- awef#57 実装済み\r\n- awef#62\r\n- awef#64 #18 へ\r\n- awef#67\r\n- awef#68\r\n- awef#69\r\n- awef#71\r\n- awef#72\r\n- awef#74\r\n- awef#75\r\n- awef#76\r\n- awef#77 履歴に関しては実装済み\r\n- awef#79\r\n- awef#84\r\n- awef#85\r\n- awef#92 実装済み\r\n- awef#93 実装済み\r\n- awef#97\r\n- awef#99\r\n- awef#101\r\n- awef#102\r\n- awef#103\r\n- awef#106\r\n- awef#107\r\n- awef#110 実装済み\r\n- awef#111\r\n- awef#112\r\n- awef#113\r\n- awef#114\r\n- awef#116\r\n- awef#117 実装済み\r\n- awef#121\r\n- awef#122\r\n- awef#123\r\n- awef#124\r\n- awef#125\r\n- awef#126\r\n- awef#127 実装済み\r\n- awef#128\r\n- awef#129\r\n- awef#132\r\n- awef#133\r\n- awef#134 タブのリサイズ時、実際の要素をリアルタイムにリサイズしないようにする\r\n- awef#135\r\n- awef#136\r\n- awef#137\r\n- awef#139\r\n- awef#142\r\n- awef#143\r\n- awef#151\r\n- awef#153\r\n- awef#162\r\n- awef#164\r\n- awef#165\r\n- awef#166\r\n- awef#169\r\n- awef#170\r\n- awef#172\r\n- awef#173\r\n- awef#174 \r\n- awef#175\r\n- awef#178\r\n- awef#179 そもそもテストを削除\r\n- awef#181\r\n- awef#183\r\n- awef#184\r\n- awef#186\r\n- awef#190 移行済み", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "hellxcz", "comment_id": null, "datetime": 1410168983000, "masked_author": "username_0", "text": "hi,\r\n.select2-choice should have something like this\r\n\r\nhtml[dir=\"rtl\"] .select2-search-choice-close {\r\nright: auto;\r\nleft: 24px;\r\n}", "title": ".select2-choice in RTL is behind select2-arrow", "type": "issue" }, { "action": "created", "author": "kevin-brown", "comment_id": 228563983, "datetime": 1466879732000, "masked_author": "username_1", "text": "This issue has been fixed in later versions of Select2.", "title": null, "type": "comment" }, { "action": "closed", "author": "kevin-brown", "comment_id": null, "datetime": 1466879732000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "conal", "comment_id": null, "datetime": 1411523532000, "masked_author": "username_0", "text": "Is Haddock documentation building on Hackage broken (or turned off)? I released [Boolean-0.2.2](http://hackage.haskell.org/package/Boolean-0.2.2) last week, and no documentation is showing up, nor any error log.", "title": "Documentation building broken/off?", "type": "issue" }, { "action": "created", "author": "crockeea", "comment_id": 71375992, "datetime": 1422197660000, "masked_author": "username_1", "text": "Has anyone looked into this recently?", "title": null, "type": "comment" }, { "action": "created", "author": "crockeea", "comment_id": 158213229, "datetime": 1447970668000, "masked_author": "username_1", "text": "This is still a problem. I uploaded a new version of [lol](https://hackage.haskell.org/package/lol-0.1.0.0) last week, but still no docs. Status is \"Docs Pending\".", "title": null, "type": "comment" }, { "action": "created", "author": "crockeea", "comment_id": 162684135, "datetime": 1449526548000, "masked_author": "username_1", "text": "I also \"deleted the documentation and triggered a rebuild\" on [lol](https://hackage.haskell.org/package/lol-0.1.0.0), to no avail. The differences between the previous version of the library (where Hackage build the documentation fine) is tiny, so I can't imagine what the probem is. Can we get someone to dig through server logs somewhere and figure out what the holdup on doc generation is?", "title": null, "type": "comment" }, { "action": "created", "author": "gbaz", "comment_id": 179507348, "datetime": 1454539094000, "masked_author": "username_2", "text": "closing this as its an old ticket.", "title": null, "type": "comment" }, { "action": "closed", "author": "gbaz", "comment_id": null, "datetime": 1454539094000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "gbaz", "comment_id": 179507416, "datetime": 1454539114000, "masked_author": "username_2", "text": "(it would be better to not use this one ticket for all docbuilder issues)", "title": null, "type": "comment" }, { "action": "created", "author": "crockeea", "comment_id": 179593160, "datetime": 1454555498000, "masked_author": "username_1", "text": "@username_2 Can you link to a newer ticket? I posted #244, and you've also closed this ticket. Both address documentation not being built, which is still a very big problem. Is this issue being addressed somewhere else?", "title": null, "type": "comment" }, { "action": "created", "author": "gbaz", "comment_id": 226277081, "datetime": 1466015254000, "masked_author": "username_2", "text": "sorry i missed this -- clearing out old emails now. here's the ticket to track the general issue: https://github.com/haskell/hackage-server/issues/478", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "kifahhk", "comment_id": null, "datetime": 1455720395000, "masked_author": "username_0", "text": "Hello, \r\n\r\nDirectionsRenderer doesn't seem to pass props to map options.\r\nFor example:\r\n<DirectionsRenderer suppressMarkers={true} .../> does not hide markers.\r\netc..\r\n\r\nam I doing something wrong?", "title": "DirectionsRenderer apply props", "type": "issue" }, { "action": "created", "author": "tomchentw", "comment_id": 186512324, "datetime": 1455944946000, "masked_author": "username_1", "text": "Could you be more elaborate?\r\nhttps://username_1.github.io/react-google-maps/#basics/directions", "title": null, "type": "comment" }, { "action": "created", "author": "kifahhk", "comment_id": 186566229, "datetime": 1455964676000, "masked_author": "username_0", "text": "Sorry, I forgot code pattern. ^^\r\n`<DirectionsRenderer` suppressMarkers={true} markerOptions.../>`\r\n\r\nIdea?", "title": null, "type": "comment" }, { "action": "created", "author": "tomchentw", "comment_id": 186571304, "datetime": 1455966125000, "masked_author": "username_1", "text": "Set it in the `options` props:\r\n\r\n```js\r\n<DirectionsRenderer\r\n options={{suppressMarkers: true}}\r\n/>\r\n```\r\n\r\nSee `README.md` for more information.", "title": null, "type": "comment" }, { "action": "created", "author": "tomchentw", "comment_id": 222348340, "datetime": 1464509490000, "masked_author": "username_1", "text": "We're working on this to make it clearer.\r\n\r\nWe're also looking for maintainers. Involve in #266 to help strengthen our community!", "title": null, "type": "comment" }, { "action": "closed", "author": "tomchentw", "comment_id": null, "datetime": 1464509491000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "cep21", "comment_id": null, "datetime": 1451954252000, "masked_author": "username_0", "text": "Traceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/usr/local/lib/python2.6/site-packages/troposphere/__init__.py\", line 168\r\n k: v for k, v in self.resource.items()\r\n ^\r\nSyntaxError: invalid syntax\r\n```\r\n\r\nhttps://github.com/cloudtools/troposphere/commit/77320c91cf86589df0f1e861d1a273d251f4f127", "title": "Python 2.6.9 unsupported", "type": "issue" }, { "action": "created", "author": "markpeek", "comment_id": 168898454, "datetime": 1451970249000, "masked_author": "username_1", "text": "@username_0 I only validate troposphere to work against 2.7, 3.3, and 3.4 via [travis](https://github.com/cloudtools/troposphere/blob/master/.travis.yml). That particular usage of dictionary comprehension could be recoded via a loop if there is a need to support 2.6. But I do worry about needing to support future compatibility to 2.6. Let me know what your use case is for needing it or whether you can move to 2.7+.", "title": null, "type": "comment" }, { "action": "created", "author": "cep21", "comment_id": 169216544, "datetime": 1452054112000, "masked_author": "username_0", "text": "Only the normal operations issues around upgrading python being a scary thing to do. It would be nice to add 2.6 to .travis, especially since it was previously working.", "title": null, "type": "comment" }, { "action": "created", "author": "wt", "comment_id": 169837716, "datetime": 1452208591000, "masked_author": "username_2", "text": "If you're validating for 2.7, 2.6 should be pretty straightforward to support in most cases. Without trying, it was only 1.4.0 that broke python 2.6 support.\r\n\r\nWould it be possible to add py2.6 to the travis just so you know when it breaks?", "title": null, "type": "comment" }, { "action": "created", "author": "markpeek", "comment_id": 169847855, "datetime": 1452212344000, "masked_author": "username_1", "text": "I took a quick look at 2.6 compatibility but there are some test regressions I need to resolve first. If I can get it working I'll add 2.6.", "title": null, "type": "comment" }, { "action": "closed", "author": "markpeek", "comment_id": null, "datetime": 1453164591000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "coreydaley", "comment_id": null, "datetime": 1477417732000, "masked_author": "username_0", "text": "https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_networking/595/console", "title": "dnf update failure from category flake", "type": "issue" }, { "action": "created", "author": "knobunc", "comment_id": 256951145, "datetime": 1477668461000, "masked_author": "username_1", "text": "@username_2 I don't think this is a networking (well... at least the SDN) failure. The test is bombing because the dnf command failed. I'm not sure what to do with this bug... any thoughts?", "title": null, "type": "comment" }, { "action": "created", "author": "danmcp", "comment_id": 256969707, "datetime": 1477673085000, "masked_author": "username_2", "text": "@username_1 AFAICT, it's logic in the networking tests failing while calling yum. I can't say I have seen that particular error.\r\n\r\n@username_3 Does it ring a bell for you?\r\n\r\nIt looks like @juanvallejo hit the same error., so we should probably figure out what's causing it. The solution is probably going to be a retry a changing yum config.", "title": null, "type": "comment" }, { "action": "created", "author": "stevekuznetsov", "comment_id": 257015209, "datetime": 1477685054000, "masked_author": "username_3", "text": "This is a dupe of #11452 which is describing network/infra flakes around the Fedora `@updates` repo, which other projects that interact with `dnf` also are seeing recently. This is best solved in Origin by breaking all of our image builds into two -- one to inject dependencies, and another to add volatile code like `oc`. See also #9622", "title": null, "type": "comment" }, { "action": "closed", "author": "stevekuznetsov", "comment_id": null, "datetime": 1477685054000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" } ]

{ "number": 143, "repo": "documentation", "user_login": "nextcloud" }

[ { "action": "opened", "author": "nickvergessen", "comment_id": null, "datetime": 1472740977000, "masked_author": "username_0", "text": "Copied from https://github.com/nextcloud/server/wiki/Nextcloud-10-Features\r\n\r\n@username_1 @blizzz @username_2", "title": "Add release notes from the wiki", "type": "issue" }, { "action": "created", "author": "MorrisJobke", "comment_id": 244108720, "datetime": 1472742381000, "masked_author": "username_1", "text": "Beside that :+1:", "title": null, "type": "comment" }, { "action": "created", "author": "mar1u5", "comment_id": 244204434, "datetime": 1472762240000, "masked_author": "username_2", "text": "Besides Branding Stuff :+1: ... But I think this is true anyway cause it references to Feature PRs we dont have over here in Nextcloud :grin: @username_1", "title": null, "type": "comment" }, { "action": "created", "author": "nickvergessen", "comment_id": 244229126, "datetime": 1472768064000, "masked_author": "username_0", "text": "Well this one app link is wrong ;)", "title": null, "type": "comment" }, { "action": "created", "author": "nickvergessen", "comment_id": 244301878, "datetime": 1472800811000, "masked_author": "username_0", "text": "Fixed", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "FRosner", "comment_id": null, "datetime": 1435043819000, "masked_author": "username_0", "text": "", "title": "Normalized Mutual Information: Redundancy", "type": "issue" }, { "action": "created", "author": "bkomboz", "comment_id": 117918002, "datetime": 1435816094000, "masked_author": "username_1", "text": "@username_0: I'll look into this.", "title": null, "type": "comment" }, { "action": "created", "author": "FRosner", "comment_id": 117935372, "datetime": 1435820074000, "masked_author": "username_0", "text": "It's not as trivial as renaming a variable but I think you can try this one. Let me know if you need help.", "title": null, "type": "comment" }, { "action": "created", "author": "bkomboz", "comment_id": 146553928, "datetime": 1444312728000, "masked_author": "username_1", "text": "@username_0: I made it finally. Please check branch issue/175 for my proposed solution. I also added an additional test for the metric variant.\r\n\r\nPlease note: According to [the english Wikipedia article](https://en.wikipedia.org/wiki/Mutual_information), the proposed redundancy measure is not between 0 and 1 but between 0 and \r\n\r\n", "title": null, "type": "comment" }, { "action": "created", "author": "FRosner", "comment_id": 146571255, "datetime": 1444316282000, "masked_author": "username_0", "text": "@username_1 thanks for the contribution. I will look into it later. I am currently quite busy with #255", "title": null, "type": "comment" }, { "action": "created", "author": "bkomboz", "comment_id": 146577503, "datetime": 1444317692000, "masked_author": "username_1", "text": "@username_0: No problem, I will grab some more issues in the meantime if that is fine... :)", "title": null, "type": "comment" }, { "action": "created", "author": "FRosner", "comment_id": 146577850, "datetime": 1444317762000, "masked_author": "username_0", "text": "Stop! Who is supposed to merge all of them? :D\r\n\r\nPlease contribute to other projects like DDQ.", "title": null, "type": "comment" }, { "action": "created", "author": "bkomboz", "comment_id": 146578187, "datetime": 1444317841000, "masked_author": "username_1", "text": "Oki doki ... ;)", "title": null, "type": "comment" }, { "action": "created", "author": "FRosner", "comment_id": 146578485, "datetime": 1444317908000, "masked_author": "username_0", "text": "No I'm joking. Feel free but maybe we can sync in person on the next steps :)", "title": null, "type": "comment" }, { "action": "created", "author": "bkomboz", "comment_id": 146600150, "datetime": 1444321223000, "masked_author": "username_1", "text": "So far my commits should be easily mergeable. ;) Let's discuss tomorrow with a Chai Latte.", "title": null, "type": "comment" } ]

{ "number": 9435, "repo": "nixpkgs", "user_login": "NixOS" }

[ { "action": "opened", "author": "wmertens", "comment_id": null, "datetime": 1440484518000, "masked_author": "username_0", "text": "* Verify configuration with httpd -t\r\n* Some minor editing of option descriptions\r\n* Make Event MPM the default on v2.4 \r\n\r\n@username_3 any objections? The config check can be turned off and Event is good starting with kernel 2.6...", "title": "Apache configuration improvements", "type": "issue" }, { "action": "created", "author": "lethalman", "comment_id": 134515192, "datetime": 1440489556000, "masked_author": "username_1", "text": "Did you try PHP with mpm? It's a different setup, I guess this is going to break every php deployment.", "title": null, "type": "comment" }, { "action": "created", "author": "wmertens", "comment_id": 134523814, "datetime": 1440491807000, "masked_author": "username_0", "text": "Hmm I see, mod_php is threadsafe nowadays but extensions may not be... http://serverfault.com/questions/383526/how-do-i-select-which-apache-mpm-to-use\r\n\r\nSo I propose we force the event model to be prefork when mod_php is enabled?", "title": null, "type": "comment" }, { "action": "created", "author": "lethalman", "comment_id": 134524953, "datetime": 1440492190000, "masked_author": "username_1", "text": "@username_0 no it's just completely different. mpm event is similar to how you setup nginx with php using fpm and external servers. It doesn't use mod_php.", "title": null, "type": "comment" }, { "action": "created", "author": "wmertens", "comment_id": 134704482, "datetime": 1440529770000, "masked_author": "username_0", "text": "@username_1 if one is not using mod_php there is no problem, that works fine\nwith event and worker…", "title": null, "type": "comment" }, { "action": "created", "author": "wmertens", "comment_id": 134707888, "datetime": 1440530685000, "masked_author": "username_0", "text": "Here's how PHP should be configured on Apache v2.4: http://wiki.apache.org/httpd/PHP-FPM\r\n\r\nI think enabling PHP on the service should configure that instead of mod_php.", "title": null, "type": "comment" }, { "action": "created", "author": "wmertens", "comment_id": 134715560, "datetime": 1440531882000, "masked_author": "username_0", "text": "I just realized that choosing the MPM module based on the version rebuilds the man pages when changing the package version so I took that out again.\r\n\r\n@username_3 the test now works when the user doesn't exist yet, good catch :)", "title": null, "type": "comment" }, { "action": "created", "author": "globin", "comment_id": 134749888, "datetime": 1440538817000, "masked_author": "username_2", "text": "Yeah we should definitely go for using php-fpm only and ditch mod_php if possible. PHP internals has thought about deprecating mod_php but it sadly still is used too often to get rid of it.. I'll have a look at freshening up the fpm module to be configurable in a more human-friendly way soon and try to get support for that into apache by flicking over a simple switch.", "title": null, "type": "comment" }, { "action": "created", "author": "edolstra", "comment_id": 134905047, "datetime": 1440579646000, "masked_author": "username_3", "text": "Note that we used to check the Apache configuration file, but we got rid of it because it was too much trouble: 4a95f8996b11ca9876e24a37d4b521925a1c33bf", "title": null, "type": "comment" }, { "action": "created", "author": "wmertens", "comment_id": 135658506, "datetime": 1440746031000, "masked_author": "username_0", "text": "Another reason for having an out… looks like I need to fix ssl key testing\nin sandbox :-)", "title": null, "type": "comment" }, { "action": "created", "author": "rasendubi", "comment_id": 235065338, "datetime": 1469476545000, "masked_author": "username_4", "text": "(triage) @username_0 status?", "title": null, "type": "comment" }, { "action": "created", "author": "wmertens", "comment_id": 235067571, "datetime": 1469477030000, "masked_author": "username_0", "text": "Hmm totally forgot about this one. IIRC the problem was that when testing the configuration it needed to access the network for verifying SSL certificates. I suppose that could be fixed by stripping them out before testing, or at least filter out errors due to SSL certificates.\r\n\r\nProblem is that I'm not using Apache at the moment. Anybody up for completing this?", "title": null, "type": "comment" }, { "action": "created", "author": "wmertens", "comment_id": 318227848, "datetime": 1501117797000, "masked_author": "username_0", "text": "It is indeed too bothersome to have this.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "jonasrichard", "comment_id": null, "datetime": 1406281836000, "masked_author": "username_0", "text": "In `riak-debug` when dmesg is called it should call dmesg with `-T` or something which dumps dmesg logs with human readable timestamps. Now it is called with just `dmesg`.\r\n\r\nThere are kernel setups when there is no timestamp at all, in that case the operators should enable timestamp during logging, we cannot do anything in that case.", "title": "dmesg should contain timestamps in riak-debug", "type": "issue" }, { "action": "created", "author": "TheOnlyRew", "comment_id": 90756979, "datetime": 1428448488000, "masked_author": "username_1", "text": "It should be noted that `-T` is a non-standard extension to dmesg. If anything, we should add `dmesg -T` to the command list rather than replacing `dmesg`. Even then, we would be polluting some debug archives with spurious failures.", "title": null, "type": "comment" }, { "action": "created", "author": "jonasrichard", "comment_id": 90947709, "datetime": 1428506327000, "masked_author": "username_0", "text": "According to this conversation, it has been introduced in `util-linux 2.20.1` and yes, some older OSes don't support it. Is there any way to check if dmesg -T is supported?\r\n\r\nhttp://stackoverflow.com/questions/13890789/convert-dmesg-timestamp-to-custom-date-format", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "matt-oc", "comment_id": null, "datetime": 1459872029000, "masked_author": "username_0", "text": "nodezoo-search is our baseline", "title": "Linting needs to be added", "type": "issue" }, { "action": "created", "author": "Georgette", "comment_id": 205953358, "datetime": 1459883569000, "masked_author": "username_1", "text": "If we need listing, then what am I getting when I run `npm run lint ` and I get reprimanded for bad code style?", "title": null, "type": "comment" }, { "action": "created", "author": "matt-oc", "comment_id": 205972066, "datetime": 1459886965000, "masked_author": "username_0", "text": "@username_1 We were just going through one by one and making sure each repo had the correct linting files and were linted, web may well be already sorted so this will be closed tomorrow once it has been checked if all is ok (certainly it needs linting anyway)", "title": null, "type": "comment" }, { "action": "created", "author": "Georgette", "comment_id": 206003083, "datetime": 1459893886000, "masked_author": "username_1", "text": "Yeah, I linted my open PR because I had an outstanding mess to fix :) So it was working great!", "title": null, "type": "comment" }, { "action": "closed", "author": "matt-oc", "comment_id": null, "datetime": 1459935766000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "matt-oc", "comment_id": 206263083, "datetime": 1459935766000, "masked_author": "username_0", "text": "done!", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "leighwoltman", "comment_id": null, "datetime": 1462557893000, "masked_author": "username_0", "text": "Code to do so looks something like:\r\n\r\nRibbonGalleryItem galleryItem = new RibbonGalleryItem();\r\ngalleryItem.Content = \"Test\";\r\n\r\nScannerDropDownRibbonGallery.Items.Add(galleryItem);", "title": "Populate Scanners in WPF DropDown Box", "type": "issue" }, { "action": "created", "author": "tocaner", "comment_id": 217718128, "datetime": 1462713470000, "masked_author": "username_1", "text": "Code to do this is not very straightforward", "title": null, "type": "comment" }, { "action": "closed", "author": "leighwoltman", "comment_id": null, "datetime": 1467743682000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "bluesmoon", "comment_id": null, "datetime": 1464042210000, "masked_author": "username_0", "text": "I would like to specify the output date format as `%Y-%m-%dT%H:%M:%S` but without using Syslog. Can this be made configurable?\r\n\r\nThanks", "title": "Make output date format configurable", "type": "issue" }, { "action": "created", "author": "kmsquire", "comment_id": 221129053, "datetime": 1464047465000, "masked_author": "username_1", "text": "A pull request would be gladly accepted!", "title": null, "type": "comment" }, { "action": "created", "author": "bluesmoon", "comment_id": 221130551, "datetime": 1464048047000, "masked_author": "username_0", "text": "Will work on it", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "SimoneTaliercio", "comment_id": null, "datetime": 1415978460000, "masked_author": "username_0", "text": "Hi Guys, thanks for this awesome module!\r\n\r\nRight now I'm stuck in a error and I run out of idea :_(\r\n\r\nDid you ever experience this error message:\r\n\r\n{ [Error: spawn ENOENT] code: 'ENOENT', errno: 'ENOENT', syscall: 'spawn' }\r\n\r\nI tried to reinstall imagemagick and I'm running on v0.10.28 .\r\n\r\nThanks a LOT for your help!", "title": "[Help] spawn ENOENT error.", "type": "issue" }, { "action": "created", "author": "raeesaacapita", "comment_id": 220915614, "datetime": 1463991523000, "masked_author": "username_1", "text": "Could anyone get this to work? Even I am facing similar issue after deploying codes?", "title": null, "type": "comment" }, { "action": "created", "author": "hacksparrow", "comment_id": 221024158, "datetime": 1464021021000, "masked_author": "username_2", "text": "@username_1 which version of Node and what OS?", "title": null, "type": "comment" }, { "action": "created", "author": "raeesaacapita", "comment_id": 221164285, "datetime": 1464064517000, "masked_author": "username_1", "text": "Node - v5.0.0 and OS - Debian 8.", "title": null, "type": "comment" }, { "action": "created", "author": "mrkmg", "comment_id": 356719058, "datetime": 1515614399000, "masked_author": "username_3", "text": "Make sure ImageMagick is installed on the server.", "title": null, "type": "comment" }, { "action": "closed", "author": "mrkmg", "comment_id": null, "datetime": 1515614399000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "AdamsLair", "comment_id": null, "datetime": 1430557769000, "masked_author": "username_0", "text": "The v2.0 update is an ideal time to remove stuff. Find classes and systems that are largely unused and get rid of them.\r\n\r\n## Candidates for Removal\r\n\r\n- The whole Animation subsystem.\r\n - Not aware of anyone using it, didn't ever use it myself.\r\n - Feels a bit clumsy to programmers and is mostly useless to artists without editor support.\r\n - Extending it doesn't seem useful in the wake of far better systems like Spine.\r\n- Certain very specialized MathF methods.\r\n - GetLinearPrediction, GetLinearPrediction2", "title": "Cleanup Unused Classes", "type": "issue" }, { "action": "created", "author": "AdamsLair", "comment_id": 98403089, "datetime": 1430601678000, "masked_author": "username_0", "text": "Done.", "title": null, "type": "comment" }, { "action": "closed", "author": "AdamsLair", "comment_id": null, "datetime": 1430601678000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]

{ "number": 12, "repo": "GMnet-ENGINE", "user_login": "Parakoopa" }

[ { "action": "opened", "author": "The-any-Key", "comment_id": null, "datetime": 1453314255000, "masked_author": "username_0", "text": "When connection fail the client is still in the connecting room. That is\r\nbecause the script udphp_stopClient() destroy the obj_htme. And the\r\nscript htme_clientConnectionFailed dont check if the obj_htme still\r\nexists. The scripts htme_clientIsConnected and htme_debugOverlayEnabled\r\nis also fixed to handle this new client stop procedure.", "title": "Error when connection fail", "type": "issue" }, { "action": "created", "author": "Parakoopa", "comment_id": 173340799, "datetime": 1453319690000, "masked_author": "username_1", "text": "Wait but this was working before. Did I break it? o_o\r\nWell anyways, merged.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "evelynStraigt", "comment_id": null, "datetime": 1456449032000, "masked_author": "username_0", "text": "Hey! I'm one of a group of mentors running NodeSchool events in NYC. We've mentored your workshop at our events a few times and we love it!\r\n\r\nToday we had some attendees point out that the explanation of the initial template strings problem was misleading. They had gotten confused and thought there was a need to escape the initial backtick due to the way the explanation rendered.\r\n\r\nImage : https://s3.amazonaws.com/uploads.hipchat.com/22279/1042749/nBHBM5ItyiFMmyp/IMG_20160225_195901.jpg\r\n\r\nShould be a really fast, easy fix - I'm doing this from my phone now but I'd be glad to take a look and help fix it this weekend if you're not going to beat me to it before then. (=", "title": "Extra Escape Character Rendered in Problem \"Template Strings\"", "type": "issue" }, { "action": "created", "author": "evelynStraigt", "comment_id": 189063450, "datetime": 1456449078000, "masked_author": "username_0", "text": "Sorry for huge image. O=", "title": null, "type": "comment" }, { "action": "created", "author": "domenic", "comment_id": 189066354, "datetime": 1456449412000, "masked_author": "username_1", "text": "Oh, hmm, OK, I wonder if the markdown processing for nodeschool has changed since I first did this. Pull requests appreciated!", "title": null, "type": "comment" }, { "action": "closed", "author": "domenic", "comment_id": null, "datetime": 1457289259000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "burnce", "comment_id": null, "datetime": 1444836742000, "masked_author": "username_0", "text": "Hello,\r\n\r\nI performed a recursive `itrim` on a collection. The command succeeded in trimming a number of copies, but after a while encountered 5 or six `status = -806000 status = -806000 CAT_SQL_ERR` errors followed by a sequence of `status = -856000 status = -856000 CAT_BIND_VARIABLE_LIMIT_EXCEEDED` errors. Rerunning the command allowed it to run past the already trimmed data objects and trim new ones, but each time it only progressed so far before the same issue cropped up again. There were over 600 data objects in the collection and its subcollections.\r\n\r\nI am running irods version 4.0.3\r\nThe exact flags used were: `itrim -N 1 -S $RESC_NAME -Vr -M $COLLECTION`\r\n\r\nCheers,\r\n\r\nBernhard", "title": "Errors when performing recursive itrim", "type": "issue" }, { "action": "created", "author": "trel", "comment_id": 148543681, "datetime": 1444948843000, "masked_author": "username_1", "text": "We've got a recursive itrim in the tests - but will probably need to add a new test that creates more replicas first.\r\n\r\nhttps://github.com/irods/irods/blob/4-1-stable/tests/pydevtest/test_chunkydevtest.py#L249", "title": null, "type": "comment" }, { "action": "created", "author": "trel", "comment_id": 148543810, "datetime": 1444948895000, "masked_author": "username_1", "text": "The first step will be to reproduce on a 4-1-stable (4.1.6) installation.", "title": null, "type": "comment" }, { "action": "created", "author": "trel", "comment_id": 239482957, "datetime": 1471016863000, "masked_author": "username_1", "text": "@username_0 Is this still an issue for you?", "title": null, "type": "comment" }, { "action": "created", "author": "burnce", "comment_id": 241359992, "datetime": 1471858220000, "masked_author": "username_0", "text": "Hi username_1,\r\n\r\nI have not encountered it again. However, I have not performed big trim operations recently. Regarding your comment on testing for this, it is the number of objects (possibly, the number of objects in a single collection) rather than the number of replicas which was high.\r\n\r\nCheers,\r\nBernhard", "title": null, "type": "comment" }, { "action": "closed", "author": "trel", "comment_id": null, "datetime": 1544762320000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "trel", "comment_id": 447210944, "datetime": 1544762320000, "masked_author": "username_1", "text": "Closing without specific use case that triggers the error. 4.0.x and 4.1.x were a long time ago.\r\n\r\nWe'll open a new issue if we see this again.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "FarzanRNobakht", "comment_id": null, "datetime": 1484474237000, "masked_author": "username_0", "text": "It would be nice if we have The Telegram Bot API version that is supported by yagop/node-telegram-bot-api at the top of the main readme file!", "title": "Specifiy The compatibe Telegram Bot API version", "type": "issue" }, { "action": "closed", "author": "GochoMugo", "comment_id": null, "datetime": 1485341339000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "GochoMugo", "comment_id": 275077031, "datetime": 1485341339000, "masked_author": "username_1", "text": "**Done**", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "swap1992", "comment_id": null, "datetime": 1470837817000, "masked_author": "username_0", "text": "", "title": "how to handle multi step validation?", "type": "issue" }, { "action": "created", "author": "1000hz", "comment_id": 261330450, "datetime": 1479407868000, "masked_author": "username_1", "text": "See #444", "title": null, "type": "comment" }, { "action": "closed", "author": "1000hz", "comment_id": null, "datetime": 1479407868000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "davidsielert", "comment_id": null, "datetime": 1430895192000, "masked_author": "username_0", "text": "Unable to set game mode using the default map command it needs to come out quotes e.g. +map \"station push\" but adding quotes doesn't work.. I added quotes in the parms command and it works in debug mode but not in live mode so Idk what the hell is going on..", "title": "[insserver] map variable issue", "type": "issue" } ]

[ { "action": "opened", "author": "JunkMyFunk", "comment_id": null, "datetime": 1479976972000, "masked_author": "username_0", "text": "Injecting this service into another service causes the `createAnalytics()` method to be called, which accesses the request stack to get the `User-Agent` header. In the case this is not set (which often happens with requests from bots or 3rd party API callbacks) an exception is thrown. Since this happens when the services are instantiated, it's hard to handle gracefully.\r\n\r\nPassing an empty string to the `setUserAgentOverride()` method does not throw an exception, only a null value does. Since the user-agent isn't required by the GAMP API anyway, it seems this method should not be called in the constructor or gracefully handle a null value.", "title": "createAnalytics method in factory throws InvalidArgumentException when no user-agent set", "type": "issue" }, { "action": "created", "author": "foaly-nr1", "comment_id": 262754466, "datetime": 1479986816000, "masked_author": "username_1", "text": "Thanks @username_0. Are you happy to open a pull request?", "title": null, "type": "comment" }, { "action": "closed", "author": "foaly-nr1", "comment_id": null, "datetime": 1480000936000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "dwelch2101", "comment_id": null, "datetime": 1435079824000, "masked_author": "username_0", "text": "For the synthetic ecosystem work on MIDAS, we need a class to represent employee role.", "title": "Create employee role ", "type": "issue" }, { "action": "created", "author": "aellenhicks", "comment_id": 114583779, "datetime": 1435081134000, "masked_author": "username_1", "text": "URI created - OMRSE_00000077\r\nDefinition and class restrictions still need to be created", "title": null, "type": "comment" }, { "action": "closed", "author": "aellenhicks", "comment_id": null, "datetime": 1435846123000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

{ "number": 127, "repo": "libmill", "user_login": "sustrik" }

[ { "action": "opened", "author": "paulofaria", "comment_id": null, "datetime": 1453615582000, "masked_author": "username_0", "text": "I'm not sure about the naming. `mfile` could be named `file`, but I think that's dangerous. The functions could be renamed to `mfopen`, `mfclose`, `mftell`, etc.. though.\r\n\r\nSubmitted under MIT/X11 license", "title": "add file wrapper", "type": "issue" }, { "action": "created", "author": "sustrik", "comment_id": 174338264, "datetime": 1453667221000, "masked_author": "username_1", "text": "Merged. Thanks!\r\n\r\nIn the subsequent patch I've removed all attach/detach functions from tcp/unix/udp/file.", "title": null, "type": "comment" }, { "action": "created", "author": "sustrik", "comment_id": 174338429, "datetime": 1453667394000, "masked_author": "username_1", "text": "Tested on Linux, OSX and FreeBSD.", "title": null, "type": "comment" }, { "action": "created", "author": "sustrik", "comment_id": 174340192, "datetime": 1453668636000, "masked_author": "username_1", "text": "FYI, I've tried using stdin in non-blocking way and it seems to work ok both on Linux and FreeBSD:\r\n\r\n```\r\n#include <assert.h>\r\n#include <fcntl.h>\r\n#include <stdio.h>\r\n#include <poll.h>\r\n#include <unistd.h>\r\n\r\nint main(void) {\r\n\r\n int flags = fcntl(STDIN_FILENO, F_GETFL, 0);\r\n assert(flags != -1);\r\n flags |= O_NONBLOCK;\r\n flags = fcntl(STDIN_FILENO, F_SETFL, flags) != -1;\r\n assert(flags != -1);\r\n\r\n while(1) {\r\n struct pollfd pfd = {STDIN_FILENO, POLLIN, 0};\r\n int rc = poll(&pfd, 1, -1);\r\n assert(rc == 1);\r\n assert(pfd.revents == POLLIN);\r\n\r\n char buf[1024];\r\n ssize_t sz = read(STDIN_FILENO, buf, sizeof(buf));\r\n assert(sz >= 0);\r\n printf(\"%d\\n\", (int)sz);\r\n if(sz == 0)\r\n break;\r\n }\r\n return 0;\r\n}\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "sustrik", "comment_id": 174345295, "datetime": 1453672810000, "masked_author": "username_1", "text": "I've committed a simple implementation of mfin, mfout and mferr. Feel free to comment, complain, ridicule...", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "littlecharva", "comment_id": null, "datetime": 1496260129000, "masked_author": "username_0", "text": "Is there a way to control the order of the layers?\r\n\r\nI'm loading layers in the order I want, but then at some stage I need to clear some layers and load them in again. Unfortunately this loads them in on top of everything else, but I need them to be in a specific order.\r\n\r\nAnthony", "title": "How to re-order the layers", "type": "issue" }, { "action": "created", "author": "jany-tenaj", "comment_id": 305308650, "datetime": 1496262791000, "masked_author": "username_1", "text": "Check whether you can find the move function in Map.Layers. It can be used to move layers up or down.", "title": null, "type": "comment" }, { "action": "created", "author": "littlecharva", "comment_id": 305421184, "datetime": 1496304477000, "masked_author": "username_0", "text": "Perfect - thanks for the help!", "title": null, "type": "comment" }, { "action": "closed", "author": "littlecharva", "comment_id": null, "datetime": 1496304477000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]

{ "number": 3, "repo": "dir2cast", "user_login": "ben-xo" }

[ { "action": "opened", "author": "jeffbearer", "comment_id": null, "datetime": 1419347385000, "masked_author": "username_0", "text": "Here is the pull request you asked for. if you need me to do / change anything let me know.", "title": "updates to dir2cast.", "type": "issue" }, { "action": "created", "author": "marctytus", "comment_id": 224583184, "datetime": 1465391343000, "masked_author": "username_1", "text": "Hi @username_2 - just wondering why you didn't merge this pull request.", "title": null, "type": "comment" }, { "action": "created", "author": "ben-xo", "comment_id": 229605885, "datetime": 1467278083000, "masked_author": "username_2", "text": "Hi @username_1 - no, I just completely forgot about it! I will merge. The changes look great.", "title": null, "type": "comment" }, { "action": "created", "author": "jeffbearer", "comment_id": 229731375, "datetime": 1467307940000, "masked_author": "username_0", "text": "👍 Thanks.", "title": null, "type": "comment" }, { "action": "created", "author": "marctytus", "comment_id": 229793753, "datetime": 1467321975000, "masked_author": "username_1", "text": "Woo! 👍", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "erelsgl", "comment_id": null, "datetime": 1487946291000, "masked_author": "username_0", "text": "0.33333333333333337", "title": "Kendall tau distance", "type": "issue" }, { "action": "created", "author": "josef-pkt", "comment_id": 282311624, "datetime": 1487948285000, "masked_author": "username_1", "text": "array([[1, 3],\r\n [2, 2],\r\n [3, 1]])\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "josef-pkt", "comment_id": 282312580, "datetime": 1487948499000, "masked_author": "username_1", "text": "maybe that doesn't answer the issue, I'm thinking of spearman and don't have much intuition for kendall", "title": null, "type": "comment" }, { "action": "created", "author": "mirca", "comment_id": 282514113, "datetime": 1488058470000, "masked_author": "username_2", "text": "Hi @username_0, the results looks correct. In your first example you have ``x = [1, 3, 2]`` and ``y = [3, 1, 2]`` which gives ``#{discordant pairs} = 3``, ``#{concordant pairs} = 0``, resulting in ``tau = (0 - 3) / 3 = -1``. In the second example, ``x = [1, 3, 2]`` and ``y = [1, 2, 3]``, so ``#{discordant pairs} = 1 `` and ``#{concordant pairs} = 2 ``, hence ``tau = (2 - 1) / 3 = 1 / 3``. \r\n Take a look at https://en.wikipedia.org/wiki/Kendall_rank_correlation_coefficient", "title": null, "type": "comment" }, { "action": "created", "author": "erelsgl", "comment_id": 282514364, "datetime": 1488058723000, "masked_author": "username_0", "text": "Hmmm... the Wikipedia page on https://en.wikipedia.org/wiki/Kendall_tau_distance says that \"Kendall tau distance is also called bubble-sort distance since it is equivalent to **the number of swaps that the bubble sort algorithm would make to place one list in the same order as the other list**\". The number of swaps in my example is obviously small (1), while the number of discordant pairs is large (3). They are not the same. Is this a mistake in the Wikipedia page?", "title": null, "type": "comment" }, { "action": "created", "author": "evgenyzhurko", "comment_id": 282804021, "datetime": 1488219585000, "masked_author": "username_3", "text": "Kendall rank correlation coefficient and Kendall tau distance are the different measurement.\r\n\r\n@username_0 say true information about Kendall tau distance. `kendall_tau_distance = m / (n * (n - 1) / 2)`, where `m` - pairs whose values are in opposite order and `n` - size of list. As a result, Kendall tau distance therefore lies in the interval `[0,1]`, because `m` in never less than `0`.\r\n\r\n@username_2 also say true information, but about Kendall rank correlation coefficient. `kendall_tau_correlation = (p - q) / (n * (n - 1) / 2)`, where `p` - number of concordant pairs, `q` - number of discordant pairs, `n` - size of list. `kendall_tau_correlation` lies in the interval `[-1;1]`.\r\n\r\nscipy.stats.kendall tau is a function to find Kendall rank correlation coefficient but not for Kendall tau distance. I didn't find the implementation of Kendall tau distance in SciPy.\r\n\r\nIf the implementation is not exist in SciPy actually, I can implement it.", "title": null, "type": "comment" }, { "action": "created", "author": "masdeseiscaracteres", "comment_id": 383105623, "datetime": 1524232891000, "masked_author": "username_4", "text": "Hi all! Interesting discussion. For those interested (and answering @username_0 question) I wrote a post trying to shed some light on what is going on with the Kendall Tau distance and the Wikipedia page. Basically the confusion roots in two distinct usages of the word \"ranking\". Sometimes it refers to \"ranking lists\", and, some others, to \"ranked lists of items\". We get weird results when the type of \"ranking\" we have at hand does not match the one used in the definition we are applying.", "title": null, "type": "comment" }, { "action": "created", "author": "sina-mansour", "comment_id": 628356901, "datetime": 1589425203000, "masked_author": "username_5", "text": "Hi all, \r\n\r\nI was just reading this thread and noticed a **major misunderstanding** in the very definition of Kendall's tau.\r\n\r\nThere are two distinct concepts, Kendall's tau **distance** and **correlation**. To give a clear reference to an article that defines both have a look at [this paper](https://arxiv.org/pdf/1905.02752.pdf) (pages 3-4)\r\n\r\n---\r\n\r\nThese definitions are computed mainly by two values:\r\n\r\n**Concordant pairs**: Pairs with conforming orders between permutations\r\n\r\n\r\n\r\nAnd **Discordant pairs**: Pairs with opposing (inverse) orders between permutations\r\n\r\n\r\n\r\nHaving computed these two values,\r\n\r\nThe Kendall's tau **distance** (normalized) is computed by:\r\n\r\n\r\n\r\nThe Kendall's tau rank **correlation** is computed by:\r\n\r\n\r\n\r\n---\r\n\r\nTo better clarify, let's take the example provided by @username_0.\r\n\r\nWe have two permutations: p1 = [1,3,2], and p2 = [3,1,2]\r\n\r\nWe have three pairs in the list: (1,2), (1,3), and (2,3)\r\n\r\nWe have two **concordant** pairs (C=1): (1,2) -> this means that the pair (1,2) appear in the same order in both permutations p1 & p2.\r\n\r\nWe have two **discordant** pairs (D=2): (1,3) & (2,3) these pairs have a different order across p1 & p2.\r\n\r\nThus, for our example:\r\n\r\nKendall's tau **distance** = 0.667\r\n\r\nKendall's tau rank **correlation** = - 0.333\r\n\r\n---\r\n\r\n**TLDR**\r\n\r\nSo as a brief conclusion, @username_0 is right in raising the issue, the current implementation is incorrect, as the definition of concordant and discordant pairs is not correctly implemented. as @username_3 also mentioned there's a difference between Kendall's tau distance and correlation. But it would be really easy to implement two functions that compute both.", "title": null, "type": "comment" }, { "action": "created", "author": "masdeseiscaracteres", "comment_id": 629824389, "datetime": 1589732872000, "masked_author": "username_4", "text": "KendalltauResult(correlation=-1.0, pvalue=0.3333333333333333)\r\n```\r\n#### So, what is the right way to look at the input parameters? \r\nWe must think of `x` and `y` as coordinates of two data samples from which you compute your correlation coefficient. That is, we must think of Kendall's tau as a correlation coefficient in the same way you would do with [Pearson's r correlation coefficient](https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.pearsonr.html). They serve similar purposes, so they should be used similarly:\r\n\r\n- Pearson's r:\r\n - Goal: quantify the extent to which the relationship between two data samples is **linear**.\r\n - Extreme values interpretation: 1 means a perfect increasing-slope linear relationship, -1 means a perfect decreasing-slope linear relationship.\r\n\r\n- Kendall's tau \r\n - Goal: quantify the extent to which the relationship between two data samples is **monotonic**.\r\n - Extreme values interpretation: 1 means a monotonically-increasing relationship, -1 means a monotonically-decreasing relationship.\r\n\r\nLet's illustrate this with some examples. First, the one provided by @username_0:\r\n\r\n```python\r\nimport matplotlib.pyplot as plt\r\nfrom scipy.stats import kendalltau, pearsonr\r\n\r\ndef plot_data(x, y, labels):\r\n plt.scatter(x, y)\r\n for xi, yi, lab in zip(x, y, labels):\r\n plt.annotate(lab, (xi, yi), xytext=(3, 3), textcoords=\"offset points\", ha='left', va='bottom')\r\n plt.axis([0, 4, 0, 4])\r\n\r\nlabels = ['A', 'B', 'C']\r\n\r\nx = [1, 3, 2]\r\ny = [3, 1, 2]\r\n\r\nprint(\"Pearson\\'s r correlation coefficient: {:.2f}\".format(pearsonr(x, y)[0]))\r\nprint(\"Kendall\\'s tau correlation coefficient: {:.2f}\".format(kendalltau(x, y)[0]))\r\nplot_data(x, y, labels)\r\n```\r\n\r\n\r\n\r\nThen, let's modify it to keep the monotonicity but change the strength of the linear relationship:\r\n```python\r\nx = [1, 3, 2]\r\ny = [3, 1, 2]\r\ny[1] = 1.9 # we replace 1 by 1.9 in the second dataset\r\n\r\nprint(\"Pearson\\'s r correlation coefficient: {:.2f}\".format(pearsonr(x, y)[0])) # linear relationship is now weaker\r\nprint(\"Kendall\\'s tau correlation coefficient: {:.2f}\".format(kendalltau(x, y)[0])) # stays perfectly monotone\r\nplot_data(x, y, labels)\r\n```\r\n\r\n\r\nAs you can see, the results provided by the function are correct. We only need to interpret the input parameters differently (in the same way we do with Pearson's r).\r\n\r\n#### What if we want to explain the results in terms of concordant & discordant pairs?\r\nFor counting the pairs, I'll use the fictitious labels (`'A', 'B', 'C'`) used in the plots above:\r\n\r\n| label | A | B | C |\r\n| - | - | - | - |\r\n| coordinates 1 | 1.0 | 3.0 | 2.0 |\r\n| coordinates 2 | 3.0 | 1.0 | 2.0 |\r\n\r\nNow, sort the labels according to their coordinates (lower coordinates first):\r\n\r\n| position (don't confuse with coordinates) | 1st | 2nd | 3rd |\r\n| - | - | - | - |\r\n| label ordering 1 | A | C | B |\r\n| label ordering 2 | B | C | A |\r\n\r\nFinally, count the number of concordant and discordant pairs:\r\n- Discordant pairs (pairs whose elements order changed across orderings 1 and 2):\r\n - (A, B), (A, C) & (B, C). Three discordants pairs (D=3).\r\n- Concordant pairs (pairs whose elements order stayed the same across orderings 1 and 2):\r\n - None. Three discordants pairs (D=3).\r\n\r\nTherefore, if we now evaluate the formula (provided above by @username_5):\r\n\r\nwe get a Kendall's tau correlation coeffient = - 1.\r\n\r\n## Summary\r\nThe current implementation **is not wrong** but the parameter interpretation may be ambiguous. It correctly provides the Kendall's tau rank correlation coefficient when passed two lists of element coordinates. It won't provide correct results when passed two lists of elements. It may be sufficient to clarify this extent through some disclaimer note or example. Also, providing another function for those willing to compute the Kendall's tau rank correlation from two lists of elements may be useful.\r\n\r\nI agree with @username_5 that providing a function implementing the Kendall's tau rank distance it's simple and might be useful to clarify the difference between the two concepts.", "title": null, "type": "comment" }, { "action": "created", "author": "tupui", "comment_id": 809587803, "datetime": 1617040746000, "masked_author": "username_6", "text": "@username_5 @username_4 the PR addressing this is stalled. Feel free to drop in and add review the proposal so that it finally get merged.", "title": null, "type": "comment" }, { "action": "created", "author": "sina-mansour", "comment_id": 810713250, "datetime": 1617158212000, "masked_author": "username_5", "text": "I agree with @username_4 that by this interpretation the function does what it has to do. But I personally find the function ambiguous in its current form. I believe many users are actually interested to get to Kendall's correlation/distance from a permutation rather than rankings and the current description will not guide them towards the right solution.\r\n\r\nMaybe if this was further clarified in the description this could avoid future confusion. On the other hand, one can use `np.argsort()` to convert a permutation to a ranking, this could either be added as a flag that the user selects (`kendalltau(x,y,from_permutations=True`) or at least as an example for people to know that if they are working with permutations they should feed `x=np.argsort(permutation)` to the function for it to work correctly.", "title": null, "type": "comment" } ]

{ "number": 16, "repo": "webslides", "user_login": "jlantunez" }

[ { "action": "opened", "author": "Justahelper", "comment_id": null, "datetime": 1484676058000, "masked_author": "username_0", "text": "Some changes to button in the slide 1", "title": "Changes to button", "type": "issue" }, { "action": "created", "author": "Justahelper", "comment_id": 273248209, "datetime": 1484676145000, "masked_author": "username_0", "text": "Sorry! accidently pulled the request", "title": null, "type": "comment" }, { "action": "created", "author": "jlantunez", "comment_id": 273249943, "datetime": 1484676531000, "masked_author": "username_1", "text": "No problem :)", "title": null, "type": "comment" } ]

{ "number": 155, "repo": "microsoft-authentication-library-for-android", "user_login": "AzureAD" }

[ { "action": "opened", "author": "weijjia", "comment_id": null, "datetime": 1493686002000, "masked_author": "username_0", "text": "#141: update authority validation. When using the resolved endpoints from cache, we should check if authority is validated. If authority validation is turned on and the cached authority has not been validated yet, we should do instance discovery and tenant discovery.", "title": "#141: update authority validation", "type": "issue" }, { "action": "created", "author": "addev-ashish", "comment_id": 299057325, "datetime": 1493851802000, "masked_author": "username_1", "text": ":shipit:", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "fqhuy", "comment_id": null, "datetime": 1448090826000, "masked_author": "username_0", "text": "Hi username_1,\r\n\r\nFirst of all, I would like to thank you guys for the great library that you are building and making it open to the research community. I just want to report a bug related to the version of scikit-learn package. The Kmeans fit and fit_predict worked well on 1.6.1 but not 1.7. I got this error message:\r\n\r\n~/lib/python2.7/site-packages/sklearn/lda.py:4: DeprecationWarning: lda.LDA has been moved to discriminant_analysis.LinearDiscriminantAnalysis in 0.17 and will be removed in 0.19\r\n \"in 0.17 and will be removed in 0.19\", DeprecationWarning)\r\nTraceback (most recent call last):\r\n File \"main.py\", line 429, in <module>\r\n cluster_covariances(params['covars'].reshape((-1, 3, 3)), n_clusters=7, means=params['means'].reshape((-1, 3)), viz=True)\r\n File \"main.py\", line 70, in cluster_covariances\r\n km.fit(covars)\r\n File \"~/lib/python2.7/site-packages/pyriemann-0.2.3-py2.7.egg/pyriemann/clustering.py\", line 155, in fit\r\n tol=self.tol)\r\n File \"~/lib/python2.7/site-packages/pyriemann-0.2.3-py2.7.egg/pyriemann/clustering.py\", line 20, in _fit_single\r\n X, n_clusters, init, random_state=random_state)\r\n File \"~/lib/python2.7/site-packages/sklearn/cluster/k_means_.py\", line 620, in _init_centroids\r\n x_squared_norms = row_norms(X, squared=True)\r\n File \"~/lib/python2.7/site-packages/sklearn/utils/extmath.py\", line 69, in row_norms\r\n norms = np.einsum('ij,ij->i', X, X)\r\nValueError: operand has more dimensions than subscripts given in einstein sum, but no '...' ellipsis provided to broadcast the extra dimensions.\r\n\r\nProcess finished with exit code 1", "title": "clustering.Kmeans works with sklearn 1.6.1 but not 1.7", "type": "issue" }, { "action": "created", "author": "alexandrebarachant", "comment_id": 158662887, "datetime": 1448126114000, "masked_author": "username_1", "text": "Hi,\r\nI'm aware of this bug, but i couldn't reproduce it locally (only on travis).\r\nI will try to fix it ASAP.", "title": null, "type": "comment" }, { "action": "closed", "author": "alexandrebarachant", "comment_id": null, "datetime": 1448129305000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "rosenfeld", "comment_id": null, "datetime": 1421176607000, "masked_author": "username_0", "text": "It boils down to this according to my experiments:\r\n\r\n```\r\nirb -r net/http -r openssl\r\nirb(main):001:0> Net::HTTP.get 'bundler.rubygems.org', '/api/v1/dependencies?gems=railties,actionmailer,sprockets-rails,sprockets,puma,foreman,jruby-openssl,rsolr,activesupport,rake,rspec,guard-rspec,nokogiri,tidy_ffi,fakefs,pry-byebug'\r\n=> \"\"\r\n```\r\n\r\nThe response is not empty as you can confirm by either downloading the URL or running this on MRI or on 1.9 mode.", "title": "Bundler won't use dependency API in 2.0 mode for JRuby 1.7.18", "type": "issue" }, { "action": "created", "author": "Who828", "comment_id": 69873857, "datetime": 1421216169000, "masked_author": "username_1", "text": "I can confirm that it's working on master (JRuby 9000) with 2.x mode. \r\nguess this will be fixed once its out.", "title": null, "type": "comment" }, { "action": "created", "author": "headius", "comment_id": 69918476, "datetime": 1421243639000, "masked_author": "username_2", "text": "One liner that reproduces this on 1.7:\r\n\r\n```\r\njruby -rnet/http -ropenssl -e \"p Net::HTTP.get 'bundler.rubygems.org', '/api/v1/dependencies?gems=railties,actionmailer,sprockets-rails,sprockets,puma,foreman,jruby-openssl,rsolr,activesupport,rake,rspec,guard-rspec,nokogiri,tidy_ffi,fakefs,pry-byebug'\"\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "mkristian", "comment_id": 69918774, "datetime": 1421243789000, "masked_author": "username_3", "text": "I needed to add ```--2.0```:\r\n\r\n```\r\njruby --2.0 -rnet/http -ropenssl -e \"p Net::HTTP.get 'bundler.rubygems.org', '/api/v1/dependencies?gems=railties,actionmailer,sprockets-rails,sprockets,puma,foreman,jruby-openssl,rsolr,activesupport,rake,rspec,guard-rspec,nokogiri,tidy_ffi,fakefs,pry-byebug'\"\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "headius", "comment_id": 69921232, "datetime": 1421244911000, "masked_author": "username_2", "text": "Oh, right, you need that too :-)", "title": null, "type": "comment" }, { "action": "created", "author": "perlun", "comment_id": 69933264, "datetime": 1421249482000, "masked_author": "username_4", "text": "Does this work properly on older JRuby 1.7 versions?", "title": null, "type": "comment" }, { "action": "created", "author": "rosenfeld", "comment_id": 69935996, "datetime": 1421250380000, "masked_author": "username_0", "text": "This is the only one I tried. I wanted to test one request in my app without the GVL in MRI, that is how I found out this issue...", "title": null, "type": "comment" }, { "action": "created", "author": "rosenfeld", "comment_id": 72507071, "datetime": 1422900743000, "masked_author": "username_0", "text": "This issue also prevents rbenv from installing JRuby if you have `compat.version=2.0` in your ~/.jrubyrc, which is my case:\r\n\r\nhttps://github.com/sstephenson/ruby-build/issues/718", "title": null, "type": "comment" }, { "action": "created", "author": "hathawad", "comment_id": 115289023, "datetime": 1435245320000, "masked_author": "username_5", "text": "This works properly in JRuby 1.7.13", "title": null, "type": "comment" }, { "action": "created", "author": "rosenfeld", "comment_id": 115360656, "datetime": 1435258224000, "masked_author": "username_0", "text": "Weird... I just checked that one-liner with 1.7.19 and it worked... Maybe the guys in bundler.rubygems.org changed something that affected this somehow... Not sure how to proceed from here... Should we close this ticket and re-open if it happens again? I suspect there's still some hidden bug but now it's no longer reproducible...", "title": null, "type": "comment" }, { "action": "created", "author": "digitalextremist", "comment_id": 122597203, "datetime": 1437253750000, "masked_author": "username_6", "text": "This is occurring with `1.7.21`", "title": null, "type": "comment" }, { "action": "created", "author": "kares", "comment_id": 303357108, "datetime": 1495535167000, "masked_author": "username_7", "text": "closing since this was a JRuby 1.7.x issue ... seems fine by now (on JRuby 1.7.25+ using Bundler 1.13)", "title": null, "type": "comment" }, { "action": "closed", "author": "kares", "comment_id": null, "datetime": 1495535167000, "masked_author": "username_7", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "hainm", "comment_id": null, "datetime": 1477426955000, "masked_author": "username_0", "text": "hi,\r\n\r\nPlease see the figure (I used recent `ngl` version in `nglview`).\r\n\r\n\r\n\r\npdb \r\n\r\n```bash\r\nATOM 1 HH31 ACE 1 2.000 1.000 -0.000 1.00 0.00 H \r\nATOM 2 CH3 ACE 1 2.000 2.090 0.000 1.00 0.00 C \r\nATOM 3 HH32 ACE 1 1.486 2.454 0.890 1.00 0.00 H \r\nATOM 4 HH33 ACE 1 1.486 2.454 -0.890 1.00 0.00 H \r\nATOM 5 C ACE 1 3.427 2.641 -0.000 1.00 0.00 C \r\nATOM 6 O ACE 1 4.391 1.877 -0.000 1.00 0.00 O \r\nATOM 7 N ALA 2 3.555 3.970 -0.000 1.00 0.00 N \r\nATOM 8 H ALA 2 2.733 4.556 -0.000 1.00 0.00 H \r\nATOM 9 CA ALA 2 4.853 4.614 -0.000 1.00 0.00 C \r\nATOM 10 HA ALA 2 5.408 4.316 0.890 1.00 0.00 H \r\nATOM 11 CB ALA 2 5.661 4.221 -1.232 1.00 0.00 C \r\nATOM 12 HB1 ALA 2 5.123 4.521 -2.131 1.00 0.00 H \r\nATOM 13 HB2 ALA 2 6.630 4.719 -1.206 1.00 0.00 H \r\nATOM 14 HB3 ALA 2 5.809 3.141 -1.241 1.00 0.00 H \r\nATOM 15 C ALA 2 4.713 6.129 0.000 1.00 0.00 C \r\nATOM 16 O ALA 2 3.601 6.653 0.000 1.00 0.00 O \r\nATOM 17 N ALA 3 5.846 6.835 0.000 1.00 0.00 N \r\nATOM 18 H ALA 3 6.737 6.359 -0.000 1.00 0.00 H \r\nATOM 19 CA ALA 3 5.846 8.284 0.000 1.00 0.00 C \r\nATOM 20 HA ALA 3 5.332 8.648 -0.890 1.00 0.00 H \r\nATOM 21 CB ALA 3 5.135 8.833 1.232 1.00 0.00 C \r\nATOM 22 HB1 ALA 3 5.643 8.485 2.131 1.00 0.00 H \r\nATOM 23 HB2 ALA 3 5.150 9.922 1.206 1.00 0.00 H \r\nATOM 24 HB3 ALA 3 4.102 8.485 1.241 1.00 0.00 H \r\nATOM 25 C ALA 3 7.266 8.832 0.000 1.00 0.00 C \r\nATOM 26 O ALA 3 8.229 8.068 -0.000 1.00 0.00 O \r\nATOM 27 N ALA 4 7.394 10.161 0.000 1.00 0.00 N \r\nATOM 28 H ALA 4 6.572 10.747 0.000 1.00 0.00 H \r\nATOM 29 CA ALA 4 8.692 10.805 -0.000 1.00 0.00 C \r\nATOM 30 HA ALA 4 9.246 10.507 0.890 1.00 0.00 H \r\nATOM 31 CB ALA 4 9.500 10.412 -1.232 1.00 0.00 C \r\nATOM 32 HB1 ALA 4 8.962 10.712 -2.131 1.00 0.00 H \r\nATOM 33 HB2 ALA 4 10.469 10.910 -1.206 1.00 0.00 H \r\nATOM 34 HB3 ALA 4 9.647 9.332 -1.241 1.00 0.00 H \r\nATOM 35 C ALA 4 8.551 12.320 0.000 1.00 0.00 C \r\nATOM 36 O ALA 4 7.439 12.844 0.000 1.00 0.00 O \r\nATOM 37 N NME 5 9.685 13.026 0.000 1.00 0.00 N \r\nATOM 38 H NME 5 10.576 12.550 0.000 1.00 0.00 H \r\nATOM 39 CH3 NME 5 9.685 14.475 0.000 1.00 0.00 C \r\nATOM 40 HH31 NME 5 8.657 14.839 0.000 1.00 0.00 H \r\nATOM 41 HH32 NME 5 10.198 14.839 0.890 1.00 0.00 H \r\nATOM 42 HH33 NME 5 10.198 14.839 -0.890 1.00 0.00 H \r\nEND \r\n```", "title": "ACE and NME amber resnames", "type": "issue" }, { "action": "created", "author": "arose", "comment_id": 256170149, "datetime": 1477428275000, "masked_author": "username_1", "text": "It would indeed be nice to have automatic bounds for common peptide capping groups\r\n\r\n- ACE (N-terminal)\r\n- NME (C-terminal)", "title": null, "type": "comment" }, { "action": "created", "author": "arose", "comment_id": 330389119, "datetime": 1505779154000, "masked_author": "username_1", "text": "are there more common peptide capping groups you know @username_0 (or anyone else)?", "title": null, "type": "comment" }, { "action": "created", "author": "hainm", "comment_id": 330390128, "datetime": 1505779568000, "masked_author": "username_0", "text": "1.\r\n\r\n\r\n\r\n2. Amine ending group\t NHE", "title": null, "type": "comment" }, { "action": "created", "author": "arose", "comment_id": 330392045, "datetime": 1505780361000, "masked_author": "username_1", "text": "Do you have example files for those?", "title": null, "type": "comment" }, { "action": "created", "author": "arose", "comment_id": 330392089, "datetime": 1505780383000, "masked_author": "username_1", "text": "would need residue and atom names", "title": null, "type": "comment" }, { "action": "created", "author": "hainm", "comment_id": 330392469, "datetime": 1505780552000, "masked_author": "username_0", "text": "Will update later.", "title": null, "type": "comment" }, { "action": "created", "author": "hainm", "comment_id": 330396495, "datetime": 1505782430000, "masked_author": "username_0", "text": "- NME\r\n```\r\nHETATM 1 N NME 1 3.326 1.548 -0.000 0.00 0.00 N \r\nHETATM 2 H NME 1 3.909 0.724 -0.000 0.00 0.00 H \r\nHETATM 3 CH3 NME 1 3.970 2.846 -0.000 0.00 0.00 C \r\nEND \r\n```\r\n\r\n- NHE\r\n```\r\nHETATM 1 N NHE 1 2.194 1.598 -0.000 0.00 0.00 N \r\nHETATM 2 HN1 NHE 1 3.035 1.039 -0.000 0.00 0.00 H \r\nHETATM 3 HN2 NHE 1 2.250 2.606 -0.000 0.00 0.00 H \r\nEND \r\n```\r\n\r\n- ACE\r\nhttps://github.com/username_1/ngl/issues/224#issue-185223637", "title": null, "type": "comment" }, { "action": "created", "author": "tmgriffiths", "comment_id": 331078648, "datetime": 1505979819000, "masked_author": "username_2", "text": "There's a couple extra termini I can think of for building proteins for molecular dynamics.\r\n\r\n- C-termini form the Charm36 FF\r\n - O-methyl (C(=O)OCH3)\r\n - amide (C(=O)NH2)\r\n\r\nThere's a couple specific to proline too. I'll put these and atoms names for all up later.", "title": null, "type": "comment" }, { "action": "created", "author": "arose", "comment_id": 333703134, "datetime": 1506990392000, "masked_author": "username_1", "text": "Gave this some thought and I think this is better solved by general distance-based bond perception.", "title": null, "type": "comment" }, { "action": "created", "author": "hainm", "comment_id": 333703471, "datetime": 1506990517000, "masked_author": "username_0", "text": "A good plan.", "title": null, "type": "comment" }, { "action": "created", "author": "arose", "comment_id": 333938394, "datetime": 1507055833000, "masked_author": "username_1", "text": "added a quick fix to look for bonds from non-polymers to other groups, see 8a0a81d1f8d0e1f6620ca23be8fdb37fd1f9a50a", "title": null, "type": "comment" }, { "action": "created", "author": "arose", "comment_id": 333938731, "datetime": 1507055910000, "masked_author": "username_1", "text": "Does the trick for @username_0's example\r\n\r\n", "title": null, "type": "comment" }, { "action": "closed", "author": "arose", "comment_id": null, "datetime": 1507055937000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "hainm", "comment_id": 333938940, "datetime": 1507055959000, "masked_author": "username_0", "text": "Kool", "title": null, "type": "comment" }, { "action": "created", "author": "hainm", "comment_id": 334623589, "datetime": 1507247867000, "masked_author": "username_0", "text": "@username_1 is this change in beta 3 yet?\r\n\r\nI still see the unbond here.\r\n\r\n<img width=\"818\" alt=\"screen shot 2017-10-05 at 7 56 25 pm\" src=\"https://user-images.githubusercontent.com/4451957/31257585-53d6e726-aa07-11e7-9665-27b8fd9dcc8d.png\">\r\n\r\nline repr is fine.\r\n\r\n<img width=\"1145\" alt=\"screen shot 2017-10-05 at 7 57 15 pm\" src=\"https://user-images.githubusercontent.com/4451957/31257602-708b2e68-aa07-11e7-8edb-414f32b59432.png\">\r\n\r\nmay be different issue?", "title": null, "type": "comment" }, { "action": "created", "author": "arose", "comment_id": 334623877, "datetime": 1507247981000, "masked_author": "username_1", "text": "yeah, different issue, basically need and option to display bonds when only one of the atoms is in the selection", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "carlosviol", "comment_id": null, "datetime": 1434491839000, "masked_author": "username_0", "text": "The Openshift Platform uses a \".env\" folder, that has VARIABLE_NAME file with the value as file content, and that conflicts with decouple.\r\n\r\nMaybe we need to create other Parser for this format, or change the .env parser.\r\n\r\nTraceback:\r\n File \"/var/lib/openshift/558098a099fc7700aa/app-root/runtime/dependencies/python/virtenv/lib/python2.7/site-packages/decouple.py\", line 196, in __call__\r\n self._load(self._caller_path())\r\n File \"/var/lib/openshift/558098a099fc7700aa/app-root/runtime/dependencies/python/virtenv/lib/python2.7/site-packages/decouple.py\", line 186, in _load\r\n self.config = Config(Repository(filename))\r\n File \"/var/lib/openshift/558098a099fc7700aa/app-root/runtime/dependencies/python/virtenv/lib/python2.7/site-packages/decouple.py\", line 115, in __init__\r\n for line in open(source):\r\nIOError: [Errno 21] Is a directory: '/var/lib/openshift/558098a099fc7700aa/.env'", "title": "Problem with Openshift Platform and .env folder", "type": "issue" }, { "action": "closed", "author": "henriquebastos", "comment_id": null, "datetime": 1442274420000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "henriquebastos", "comment_id": 140234799, "datetime": 1442274420000, "masked_author": "username_1", "text": "Fixed by #17", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "AkashiX", "comment_id": null, "datetime": 1492995827000, "masked_author": "username_0", "text": "<!--\r\nThank you for reporting an issue.\r\n\r\n1. It's RECOMMENDED to submit PR for typo or tiny bug fix.\r\n2. If this's a BUG, please provide: course repetition, error log and configuration. Fill in as much of the template below as you're able.\r\n3. If this's a FEATURE request, please provide: details, pseudo codes if necessary.\r\n\r\n感谢您向我们反馈问题。\r\n\r\n1. 我们推荐如果是小问题（错别字修改，小的 bug fix）直接提交 PR。\r\n2. 如果是一个 BUG，请提供：复现步骤，错误日志以及相关配置，并尽量填写下面的模板中的条目。\r\n3. 如果是一个新需求，请提供：详细需求描述，最好是有伪代码实现。\r\n-->\r\n\r\n* **Node Version**:\r\n* **Egg Version**:\r\n* **Plugin Name**:\r\n* **Plugin Version**:\r\n* **Platform**:\r\n\r\n<!-- Enter your issue details below this comment. -->", "title": "请求STS增加Callback参数达成客户端请求触发回调的目的，请问有没有对应的简单实现？", "type": "issue" }, { "action": "created", "author": "atian25", "comment_id": 296505179, "datetime": 1492997610000, "masked_author": "username_1", "text": "没看懂", "title": null, "type": "comment" }, { "action": "created", "author": "AkashiX", "comment_id": 296506365, "datetime": 1492998351000, "masked_author": "username_0", "text": "https://help.aliyun.com/document_detail/31989.html?spm=5176.product31815.6.870.FR5KGy", "title": null, "type": "comment" }, { "action": "created", "author": "popomore", "comment_id": 296929210, "datetime": 1493102244000, "masked_author": "username_2", "text": "这要看 [ali-oss](https://github.com/ali-sdk/ali-oss) 支不支持", "title": null, "type": "comment" }, { "action": "created", "author": "popomore", "comment_id": 297900069, "datetime": 1493351241000, "masked_author": "username_2", "text": "研究下 https://github.com/ali-sdk/ali-oss 好了，没使用过这个功能。", "title": null, "type": "comment" }, { "action": "closed", "author": "popomore", "comment_id": null, "datetime": 1493351241000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "bobbydp", "comment_id": null, "datetime": 1464328496000, "masked_author": "username_0", "text": "I seem to always get this warning even though the volume works property works fine. Am I writing this incorrectly? Here is how I have it inside my React Component:\r\n\r\n`<ReactPlayer className=\"react-player\" url={videoLink} playing width=\"100%\" height=\"100%\" volume=\"1\" onEnded={this.handleStop} />;`\r\n\r\nThis seems minor seeing as the volume property works flawlessly.", "title": "Warning: Failed propType: Invalid prop 'volume' of type 'string' supplied to 'Vimeo', expected 'number'. Check the render method of 'ReactPlayer'.", "type": "issue" }, { "action": "created", "author": "gridsane", "comment_id": 222071215, "datetime": 1464330927000, "masked_author": "username_1", "text": "Props in quotes is always strings. Use curly braces to pass exact type:\r\n\r\n```jsx\r\n<ReactPlayer volume={1} />\r\n```", "title": null, "type": "comment" }, { "action": "created", "author": "bobbydp", "comment_id": 222072109, "datetime": 1464331359000, "masked_author": "username_0", "text": "Thank you! I am learninggggg...", "title": null, "type": "comment" }, { "action": "closed", "author": "bobbydp", "comment_id": null, "datetime": 1464332434000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "emilwestergren", "comment_id": null, "datetime": 1449580468000, "masked_author": "username_0", "text": "How do I modify ownership? Accessing `_owner` doesn't seem right. @username_2 @username_1 \r\n\r\n```ooc\r\nClosure: cover {\r\n\tthunk: Pointer\r\n\tcontext: Pointer\r\n\t_owner: Owner\r\n\towner ::= this _owner\r\n\tisOwned ::= this _owner != Owner Unknown && this _owner != Owner Static && this _owner != Owner Stack && this context != null\r\n\ttake: func -> This { // call by value -> modifies copy of cover\r\n\t\tif (this _owner == Owner Receiver && this context != null)\r\n\t\t\tthis _owner = Owner Sender\r\n\t\tthis\r\n\t}\r\n\tgive: func -> This { // call by value -> modifies copy of cover\r\n\t\tif (this _owner == Owner Sender && this context != null)\r\n\t\t\tthis _owner = Owner Receiver\r\n\t\tthis\r\n\t}\r\n\tfree: func@ ~withCriteria (criteria: Owner) -> Bool {\r\n\t\tthis _owner == criteria && this free()\r\n\t}\r\n\tfree: func@ -> Bool {\r\n\t\tresult := this context != null\r\n\t\tif (result) {\r\n\t\t\tgc_free(this context)\r\n\t\t\tthis context = null\r\n\t\t\tthis thunk = null\r\n\t\t}\r\n\t\tresult\r\n\t}\r\n}\r\n```", "title": "Ownership for Closure incomplete", "type": "issue" }, { "action": "created", "author": "sebastianbaginski", "comment_id": 162877706, "datetime": 1449580890000, "masked_author": "username_1", "text": "Typically owner is modified by `take / give`. `Owner Static / Unknown` is set only in constructor. What do you need ?", "title": null, "type": "comment" }, { "action": "created", "author": "emilwestergren", "comment_id": 162879915, "datetime": 1449581432000, "masked_author": "username_0", "text": "owner is defaulted to Unknown for closures, so `take / give` have no effect.", "title": null, "type": "comment" }, { "action": "created", "author": "sebastianbaginski", "comment_id": 162880307, "datetime": 1449581561000, "masked_author": "username_1", "text": "In OwnedBuffer there is a `claim` method\r\n```ooc\r\nclaim: func -> This {\r\n\tthis isOwned ? this : this copy()\r\n}\r\n```\r\nwhich sets owner to Receiver, but I don't know how to copy a closure.", "title": null, "type": "comment" }, { "action": "created", "author": "simonmika", "comment_id": 163137106, "datetime": 1449645258000, "masked_author": "username_2", "text": "Owner needs to default to `Owner Receiver` in this case.", "title": null, "type": "comment" }, { "action": "closed", "author": "marcusnaslund", "comment_id": null, "datetime": 1449825998000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "baffo32", "comment_id": null, "datetime": 1477180485000, "masked_author": "username_0", "text": "start() absorbs errors (for some reason?)\r\n\r\nso even if I try to get a continuous sntp sync from 'time.blackhole.nowhere:123' it will happily report success", "title": "errors ignored in start()", "type": "issue" }, { "action": "closed", "author": "hueniverse", "comment_id": null, "datetime": 1508979208000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

{ "number": 2530, "repo": "OpenMS", "user_login": "OpenMS" }

[ { "action": "opened", "author": "hroest", "comment_id": null, "datetime": 1492573306000, "masked_author": "username_0", "text": "Warning: unknown N-terminal modification '2475.8875650638' - adding it to the database\r\nSegmentation fault (core dumped)\r\n```\r\n\r\nit turns out that when parsing a sequence like N[2457.877]VSVK our `AASequence` \"eats\" the AA before the square brackets and when calling `toString` it outputs a sequence which is one AA shorter. Firstly, that is incorrect and secondly it means that repeated parsing of strings by OpenMS shorten it by 1 each time until we end up with a String like '[2475.8875650638]VSVK' which then leads to a segfault.\r\n\r\nI looked at the code for quite some time and decided that it needed a major overhaul. This PR now substantially enhances our support for the bracket notation syntax which is also evident in the expanded AASequence test:\r\n\r\n- `AASequence::fromString().toString()` not produces reproducibly the same result, no more \"eating\" of AA\r\n- masses are calculated as expected\r\n- `PEPT[+160.230654]IDE` gets correctly parsed as having a T with a modification of the correct mass (for residue as well as for full peptide)\r\n- no more \"funny\" residues with arbitrary masses, now all modifications are true modifications with the underlying AA residue\r\n- AASequence created from the same string compare as equal\r\n- This allows `b = AASequence::fromString(a.toString())` such that `a == b`\r\n- `.[1600.230654]IDE` gets parsed as N-terminal modification\r\n- `IDE.[1600.230654]` gets parsed as C-terminal modification", "title": "Feature/fix square mods", "type": "issue" }, { "action": "created", "author": "timosachsenberg", "comment_id": 295157142, "datetime": 1492589835000, "masked_author": "username_1", "text": "looks good. maybe a second opinion from @hendrikweisser or @enetz ? both have quite a good understanding of mod internals", "title": null, "type": "comment" }, { "action": "created", "author": "jpfeuffer", "comment_id": 295193933, "datetime": 1492595447000, "masked_author": "username_2", "text": "Can you have a look if it handles unknown AAs correctly now?\r\nhttps://github.com/OpenMS/OpenMS/issues/2320", "title": null, "type": "comment" }, { "action": "created", "author": "jpfeuffer", "comment_id": 295263759, "datetime": 1492607369000, "masked_author": "username_2", "text": "Can you add e.g. in ResidueModification.h documentation on how you defined the new rules for using the (full)ID members? It seems like you use the rule that an unknown modification has no ID but a fullID with all the brackets and potentially Termspecifier? Currently there is no documentation on how to handle unknown ones, I think.\r\n\r\nRegarding my last comment: Looking at the extensive tests, unknown AAs seem to be handled fine in toString.\r\nCan you only additionally check toBracketString and toUnmodifiedString?", "title": null, "type": "comment" }, { "action": "created", "author": "jpfeuffer", "comment_id": 295408573, "datetime": 1492630983000, "masked_author": "username_2", "text": "Awesome! This looks great now.", "title": null, "type": "comment" }, { "action": "created", "author": "hroest", "comment_id": 295409620, "datetime": 1492631137000, "masked_author": "username_0", "text": "I also added the test from #2320 - there is only a single issue that I came across:\r\n\r\nthe mass of `DFPANGER` differs from `DFPANGERX` and `DFPANXGER` -> the latter are 18 Da *lighter* than the initial sequence. That is strange, it must be some weird interaction with the Internal/Full calculation of monoisotopic weight. I am not really sure what the expected behavior is but it is definitely unexpected. I will look into this some more ...", "title": null, "type": "comment" }, { "action": "created", "author": "hroest", "comment_id": 295409778, "datetime": 1492631167000, "masked_author": "username_0", "text": "maybe you can argue that you should never add an \"X\" amino acid without any mass -- but still...", "title": null, "type": "comment" }, { "action": "created", "author": "hroest", "comment_id": 295898818, "datetime": 1492720437000, "masked_author": "username_0", "text": "lets go ahead with this PR and put the discussion about `X` into #2532 where it belongs", "title": null, "type": "comment" } ]

{ "number": 9, "repo": "quickstart-aws-vpc", "user_login": "aws-quickstart" }

[ { "action": "opened", "author": "FireballDWF", "comment_id": null, "datetime": 1488831619000, "masked_author": "username_0", "text": "Optional creation of VPC Flow Logs. If enabled, requires additional stack included in this pull request to be executed first", "title": "Vpcflowlogs", "type": "issue" }, { "action": "created", "author": "santiagocardenas", "comment_id": 284520673, "datetime": 1488831830000, "masked_author": "username_1", "text": "Hi @username_0,\r\nCan you please sync up your fork to the repo? I see some changes that we have eliminated from the repo following the last merge.\r\n\r\nThanks,\r\nSantiago", "title": null, "type": "comment" }, { "action": "created", "author": "santiagocardenas", "comment_id": 284523258, "datetime": 1488832388000, "masked_author": "username_1", "text": "Also, I don't see how the VPC flow logs are integral to the VPC itself. They are often used as a diagnotic tool. I recommend separating that logic into its own VPC flow log template that uses the VPC outputs as parameters to run itself.", "title": null, "type": "comment" }, { "action": "created", "author": "FireballDWF", "comment_id": 287550957, "datetime": 1489848577000, "masked_author": "username_0", "text": "I agree the VPC flow logs are not integral to the VPC itself, and I'm willing to make the change you recommend. However, what I did submit has a parameter to enable/disable the flow logs. And as it's a Security Best Practice to enable them, we should consider making it as easy as possible for people to do so. How about this to resolve which direction to take: You go to whomever you trust as an authority on AWS Best Practices to get their opinion, consider it, then let me know which way you want me to go with the change, and I'll comply.", "title": null, "type": "comment" }, { "action": "created", "author": "0rc", "comment_id": 295694907, "datetime": 1492687703000, "masked_author": "username_2", "text": "@username_0 why do you think it's better to have iam role for flow logs in a separate template?\r\nWhy not put that to original template with conditional statement?", "title": null, "type": "comment" }, { "action": "created", "author": "FireballDWF", "comment_id": 295698497, "datetime": 1492688300000, "masked_author": "username_0", "text": "Reuse same role across multiple VPCs, where multiple VPCs can be build in\nparallel", "title": null, "type": "comment" }, { "action": "created", "author": "0rc", "comment_id": 296166061, "datetime": 1492773852000, "masked_author": "username_2", "text": "Then I would agree with @username_1 - it makes sense to keep flow logs in separate template", "title": null, "type": "comment" }, { "action": "created", "author": "santiagocardenas", "comment_id": 315260052, "datetime": 1500002799000, "masked_author": "username_1", "text": "Closing since it should be added separate template.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "SunLz", "comment_id": null, "datetime": 1428133103000, "masked_author": "username_0", "text": "self.gpuImageView = [[GPUImageView alloc] initWithFrame:self.frame];\r\n [self addSubview:self.gpuImageView];\r\n \r\n self.movieMaskWithTopFilter = [[GPUImageScreenBlendFilter alloc] init];\r\n self.imageWithMovieMaskFilter = [[GPUImageColorBurnBlendFilter alloc] init];\r\n \r\n self.imagePicture = [[GPUImagePicture alloc] initWithImage:[self.images objectAtIndex:0]];\r\n self.currentIndex = 1;\r\n\r\n \r\n self.movieMaskItem = [[AVPlayerItem alloc]initWithURL:movieMaskUrl];\r\n self.movieMaskPlayer = [AVPlayer playerWithPlayerItem:self.movieMaskItem];\r\n self.movieMaskPlayer.rate = 1.0f;\r\n self.movieMaskFile = [[GPUImageMovie alloc] initWithPlayerItem:self.movieMaskItem];\r\n self.movieMaskFile.runBenchmark = YES;\r\n self.movieMaskFile.playAtActualSpeed = YES;\r\n [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(playerMovieMaskItemDidReachEnd:) name:AVPlayerItemDidPlayToEndTimeNotification object:self.movieMaskItem];\r\n \r\n self.movieItem = [[AVPlayerItem alloc] initWithURL:movieUrl];\r\n self.moviePlayer = [AVPlayer playerWithPlayerItem:self.movieItem];\r\n self.moviePlayer.rate = 1.0f;\r\n self.movieFile = [[GPUImageMovie alloc] initWithPlayerItem:self.movieItem];\r\n self.movieFile.runBenchmark = YES;\r\n self.movieFile.playAtActualSpeed = YES;\r\n self.movieFile.delegate = self;\r\n \r\n [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(playerMovieItemDidReachEnd:) name:AVPlayerItemDidPlayToEndTimeNotification object:self.movieItem];\r\n \r\n self.imagePicture2 = [[GPUImagePicture alloc] initWithImage:[self.images objectAtIndex:(self.currentIndex)]];\r\n self.alphaBlendFilter = [[GPUImageAlphaBlendFilter alloc] init];\r\n self.alphaBlendFilter.mix = 0.5f;\r\n\r\n[self.imagePicture addTarget:self.alphaBlendFilter];\r\n [self.imagePicture2 addTarget:self.alphaBlendFilter];\r\n [self.alphaBlendFilter addTarget:self.imageWithMovieMaskFilter];\r\n [self.movieMaskFile addTarget:self.imageWithMovieMaskFilter];\r\n [self.imageWithMovieMaskFilter addTarget:self.movieMaskWithTopFilter];\r\n [self.movieFile addTarget:self.movieMaskWithTopFilter];\r\n [self.movieMaskWithTopFilter addTarget:self.gpuImageView];\r\n\r\n[self.imagePicture processImage];\r\n [self.imagePicture2 processImage];\r\n [self.movieFile startProcessing];\r\n [self.moviePlayer play];\r\n \r\n [self.movieMaskFile startProcessing];\r\n [self.movieMaskPlayer play];\r\n\r\nThis is my code,but when I run it ,the code still get a crash:\r\n*** Assertion failure in -[GPUImageFramebuffer unlock], /Users/sunzliu/Documents/code/iPhoneQQMusic/QQMusic/Librarys/GPUImage/framework/Source/GPUImageFramebuffer.m:301\r\n2015-04-04 15:34:09.650 QQMusic[1184:303218] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Tried to overrelease a framebuffer, did you forget to call -useNextFrameForImageCapture before using -imageFromCurrentFramebuffer?'\r\n*** First throw call stack:\r\n(0x1822e6530 0x1932bc0e4 0x1822e63f0 0x183191c34 0x10126af60 0x1012534e0 0x10125cd7c 0x1012531c8 0x10124e414 0x101250ad4 0x1012698c0 0x10124e414 0x101250ad4 0x1012698c0 0x1012667a0 0x101264ea0 0x102f20f94 0x102f2b08c 0x10125cd8c 0x101264e1c 0x102e64a9c 0x186495094 0x186494f2c 0x18347d510 0x1822898dc 0x18229e548 0x18229e4a8 0x18229c428 0x1821c91f4 0x18b5eb6fc 0x186b5a10c 0x1005996a0 0x19393aa08)\r\nlibc++abi.dylib: terminating with uncaught exception of type NSException\r\n\r\nCan anyone tell why and how to solve it?", "title": "Why can not mix two GPUImagePicture with GPUImageMovie", "type": "issue" }, { "action": "closed", "author": "BradLarson", "comment_id": null, "datetime": 1428367734000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "BradLarson", "comment_id": 90298895, "datetime": 1428367734000, "masked_author": "username_1", "text": "Please don't spam issues: #1951", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "dfalster", "comment_id": null, "datetime": 1453260436000, "masked_author": "username_0", "text": "Notes from our previous bootcamp:\r\n\r\nGood\r\n\r\n- people find it really useful, can easily relate\r\n- humour is good\r\n- feeds into git and reproducible really well\r\n\r\nBad\r\n\r\n- can be slow\r\n- focus more on philosophy, less on mechanics: e.g. don't mess with data", "title": "Revise project setup lesson", "type": "issue" } ]

[ { "action": "opened", "author": "iNFaMoUZGaming", "comment_id": null, "datetime": 1438388629000, "masked_author": "username_0", "text": "I'm getting an error which occours everytime I try to install or uninstall a mod, it doesn't break the program but makes me unable to close it without using the task manager.\r\n\r\nHere's the error message: \r\n************** Exception Text **************\r\nSystem.MissingMethodException: Method not found: 'System.Collections.Generic.Dictionary`2<System.String,CKAN.Version> CKAN.Registry.Installed()'.\r\n at PartManagerPlugin.PartManagerUI.RefreshInstalledModsList()\r\n at PartManagerPlugin.PartManagerUI.OnModChanged(CkanModule module, GUIModChangeType changeType)\r\n at CKAN.Main.PostInstallMods(Object sender, RunWorkerCompletedEventArgs e)\r\n at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e)\r\n\r\nHow can I fix this?", "title": "\"System.String,CKAN.Version> CKAN.Registry.Installed\"", "type": "issue" }, { "action": "created", "author": "iNFaMoUZGaming", "comment_id": 126840050, "datetime": 1438388768000, "masked_author": "username_0", "text": "I'm sorry, I'm stupid, it was blatantly obvious as I saw the name of the plugin which was causing the error \"Part manager\".", "title": null, "type": "comment" }, { "action": "created", "author": "mgsdk", "comment_id": 126851009, "datetime": 1438395782000, "masked_author": "username_1", "text": "I'm not sure if the PartManager plugin works with the latest versions of CKAN. It hasn't been updated in a while.", "title": null, "type": "comment" }, { "action": "created", "author": "Postremus", "comment_id": 129128309, "datetime": 1439102049000, "masked_author": "username_2", "text": "Someone should probably update most of nlight's plugins. Some of them (like the Kerbalstuff plugin) were really nice.", "title": null, "type": "comment" }, { "action": "closed", "author": "Dazpoet", "comment_id": null, "datetime": 1439883133000, "masked_author": "username_3", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "Dazpoet", "comment_id": 132102773, "datetime": 1439883133000, "masked_author": "username_3", "text": "pretty sure the most stable CKAN version for nlights plugins to work is still 1.5.6, although the changes to the registry makes going back to that one very hard nowadays.\r\n\r\nClosing this since the issue is resolved.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "vunh79", "comment_id": null, "datetime": 1484502887000, "masked_author": "username_0", "text": "- VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:49:23.350Z)\r\n- OS Version: Windows_NT ia32 10.0.14393\r\n- Extensions:\r\n\r\n|Extension|Author|Version|\r\n|---|---|---|\r\n|vscode-github-file-folder-url|cycloware|1.0.0|\r\n|copy-github-url|mattlott|0.1.0|\r\n\r\n---\r\n\r\nSteps to Reproduce:\r\n\r\n1.\r\n2.", "title": "Can't commit", "type": "issue" }, { "action": "created", "author": "dbaeumer", "comment_id": 272822719, "datetime": 1484561896000, "masked_author": "username_1", "text": "@username_0 can you please provide steps or an example demonstrating the problem", "title": null, "type": "comment" }, { "action": "closed", "author": "joaomoreno", "comment_id": null, "datetime": 1493131862000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" } ]

{ "number": 8932, "repo": "manageiq", "user_login": "ManageIQ" }

[ { "action": "opened", "author": "mzazrivec", "comment_id": null, "datetime": 1464104328000, "masked_author": "username_0", "text": "This is to fix the following error:\r\n\r\n```\r\nFATAL -- : Error caught: [ArgumentError] comparison of NilClass with String failed\r\napp/controllers/application_controller/tags.rb:350:in `sort_by' app/controllers/application_controller/tags.rb:350:in `tag_edit_build_screen'\r\napp/controllers/application_controller/tags.rb:172:in `tagging_tags_set_form_vars'\r\napp/controllers/application_controller/tags.rb:152:in `tagging_edit_tags_reset'\r\napp/controllers/application_controller/tags.rb:15:in `tagging_edit'\r\n...\r\n```\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1339170", "title": "Fix error when tagging objects with null / nil name attribute", "type": "issue" }, { "action": "created", "author": "chessbyte", "comment_id": 221316484, "datetime": 1464105154000, "masked_author": "username_1", "text": "/cc @h-kataria", "title": null, "type": "comment" }, { "action": "created", "author": "martinpovolny", "comment_id": 221323426, "datetime": 1464106473000, "masked_author": "username_2", "text": "Looks good.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "genebean", "comment_id": null, "datetime": 1488296960000, "masked_author": "username_0", "text": "What are the odds we could get the ability to require at least a password for uploading? Ideally, I'd like to create accounts in this app just like on the public Forge so that there are unique name/password combos. The workflow I have in mind for this would be so that I could let anyone in our IT org see what modules are published but restrict uploads to authorized people to prevent the accidental or intentional overwriting of a production module with something unauthorized.\r\n\r\nFor reference, we are also planning to use this in conjunction with GitLab CI where tags in our module repos are built and then uploaded to this awesome product by way of [puppet-blacksmith](https://github.com/voxpupuli/puppet-blacksmith) or similar.", "title": "Passwords and/or user accounts", "type": "issue" }, { "action": "created", "author": "djjudas21", "comment_id": 306453663, "datetime": 1496747175000, "masked_author": "username_1", "text": ":+1:", "title": null, "type": "comment" } ]

{ "number": 88, "repo": "Mobile-Checker", "user_login": "w3c" }

[ { "action": "opened", "author": "astorije", "comment_id": null, "datetime": 1433290872000, "masked_author": "username_0", "text": "", "title": "Dependencies", "type": "issue" }, { "action": "created", "author": "guibbs", "comment_id": 108429388, "datetime": 1433339514000, "masked_author": "username_1", "text": "yay! thank you J!", "title": null, "type": "comment" }, { "action": "created", "author": "astorije", "comment_id": 108465146, "datetime": 1433342809000, "masked_author": "username_0", "text": "Oups, I wasn't finished ^^ Nevermind, at least this is done!", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "Munter", "comment_id": null, "datetime": 1433507200000, "masked_author": "username_0", "text": "Fusile should be able to deal with rewriting extensions from source asset to target asset and be able to auto discover the correct source asset based on a request for a target asset.\r\n\r\nTodo:\r\n\r\n - [ ] Refactor our the compile step and let [tolk](https://githuv.com/username_0/tolk)\r\n - [ ] Switch to fuse `direct_io` mode\r\n - [ ] Map extensions when reading directories and cache the mappings\r\n - [ ] On both `stat` and `open` look for a target to source file mapping in cache, run auto discovery if miss\r\n - [ ] On `open` with read mode, cache a tolk transpiler promise\r\n - [ ] On `read` check the tolk cache and stream from the buffer when found, fail if not.", "title": "Extension rewriting", "type": "issue" }, { "action": "created", "author": "Munter", "comment_id": 109278870, "datetime": 1433507229000, "masked_author": "username_0", "text": "This issue replaces #7", "title": null, "type": "comment" }, { "action": "created", "author": "Munter", "comment_id": 112080875, "datetime": 1434376926000, "masked_author": "username_0", "text": "Work in progress: https://github.com/username_0/fusile/tree/direct_io", "title": null, "type": "comment" }, { "action": "created", "author": "Munter", "comment_id": 112080946, "datetime": 1434376947000, "masked_author": "username_0", "text": "Currently blocking on https://twitter.com/_munter_/status/610434557192589312", "title": null, "type": "comment" }, { "action": "closed", "author": "Munter", "comment_id": null, "datetime": 1434578609000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "souporserious", "comment_id": null, "datetime": 1438475546000, "masked_author": "username_0", "text": "Can't do something like this right now, will not receive transition props.\r\n\r\n```\r\n<Transition>\r\n <CustomComponent />\r\n</Transition>\r\n```", "title": "Can't pass just a component", "type": "issue" }, { "action": "closed", "author": "souporserious", "comment_id": null, "datetime": 1442548813000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "souporserious", "comment_id": 141336750, "datetime": 1442548813000, "masked_author": "username_0", "text": "This was actually never an issue, props get passed into custom components and it's up to the user to determine where they should be applied.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "Meatballs1", "comment_id": null, "datetime": 1429544478000, "masked_author": "username_0", "text": "I was attempting to use meterpreter/reverse_https to use the default IE proxy settings and connect back to a host. \r\n\r\nThis worked fine for the initial connection. However when the meterpreter stage takes over it is unable. It is attempting to perform a direct connection to the host ignoring the proxy which gets blocked by the firewall.\r\n\r\nI assume this is something to do with @username_2's changes to WinHTTP (which wont pick up the proxy settings like WinINET). I'm not into the blame game but I'm going to ping @username_3 and @bturner-r7's as they have also been involved with reverse_http(s) changes and proxy settings. \r\n\r\nI reverted back to 1b3dfe66352dd3b32da58 and things started working again. \r\n\r\nNote that unless your test target is actually firewalled correctly it can be difficult to spot this behaviour. E.g. the proxy will show a CONNECT, you get a session, then it falls back to a direct connection but you dont notice...", "title": "Meterpreter Fails to Detect Default Proxy Settings", "type": "issue" }, { "action": "created", "author": "Meatballs1", "comment_id": 94493570, "datetime": 1429545691000, "masked_author": "username_0", "text": "n.b. in this scenario SYSTEM default proxy settings are not available:\r\n\r\n`netsh winhttp show proxy` -> Direct Access", "title": null, "type": "comment" }, { "action": "created", "author": "Meatballs1", "comment_id": 94529349, "datetime": 1429553999000, "masked_author": "username_0", "text": "To create a windows host firewall to block 443 to your msfconsole:\r\n\r\n`netsh advfirewall firewall add rule name=\"Block MSF 443\" dir=out action=block protocol=TCP remoteport=443 remoteip=192.168.0.77`", "title": null, "type": "comment" }, { "action": "created", "author": "Meatballs1", "comment_id": 94532513, "datetime": 1429554892000, "masked_author": "username_0", "text": "MSDN docs re user proxy settings:\r\n\r\nhttps://msdn.microsoft.com/en-us/library/windows/desktop/aa384075%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396#setting_the_proxy_configuration_on_a_session\r\n\r\nThe call to `WinHttpGetIEProxyConfigForCurrentUser` only appears in the stdapi get_proxy_config call. So unless it is manually receiving the proxy settings from Registry or elsewhere it wont use them :(", "title": null, "type": "comment" }, { "action": "created", "author": "bcook-r7", "comment_id": 94559737, "datetime": 1429561555000, "masked_author": "username_1", "text": "I'm working on harmonizing the WinHttpOpen flags between the reverse_http stager and meterpreter.", "title": null, "type": "comment" }, { "action": "created", "author": "Meatballs1", "comment_id": 94567938, "datetime": 1429563925000, "masked_author": "username_0", "text": "title is probably more accurate now", "title": null, "type": "comment" }, { "action": "created", "author": "OJ", "comment_id": 94573952, "datetime": 1429565405000, "masked_author": "username_2", "text": "Pfff.. yeah like this has anything to do with me! \\*whistles\\* ...\r\n\r\nI'll take a look at it today :) Thanks @username_0.", "title": null, "type": "comment" }, { "action": "created", "author": "OJ", "comment_id": 100446391, "datetime": 1431159051000, "masked_author": "username_2", "text": "OK so it turns out that using the WinInet settings in WinHTTP is a little bit of a pain. More details [here on MSDN](https://msdn.microsoft.com/en-us/library/windows/desktop/aa384075(v=vs.85).aspx#setting_the_proxy_configuration_on_a_session). It's going to make the stager a little bigger, but for now I'll get it working in Metsrv first, then at least we can pair up a `reverse_http/s` stager with a version of `metsrv` and we'll get proxy functionality back to something usable.\r\n\r\nIncluding in the `reverse_winhttp/s` stager will come later.", "title": null, "type": "comment" }, { "action": "created", "author": "Meatballs1", "comment_id": 100449000, "datetime": 1431161039000, "masked_author": "username_0", "text": "TBH I don't expect reverse_winhttp stagers to pick up the proxy settings, which is why I would stick with reverse_https for all kinds of phishing/social engineering attempts.", "title": null, "type": "comment" }, { "action": "created", "author": "OJ", "comment_id": 100454964, "datetime": 1431163538000, "masked_author": "username_2", "text": "Ok cool. I've almost got meterpreter using the proxy stuff via WinHTTP. I'd\nappreciate the help with some testing when fixed if that's OK.", "title": null, "type": "comment" }, { "action": "created", "author": "Meatballs1", "comment_id": 100463608, "datetime": 1431168143000, "masked_author": "username_0", "text": "Sure I have an environment where it currently fails ready to roll :D", "title": null, "type": "comment" }, { "action": "created", "author": "hmoore-r7", "comment_id": 100506665, "datetime": 1431185884000, "masked_author": "username_3", "text": "It looks like passing WINHTTP_ACCESS_TYPE_DEFAULT_PROXY to WinHttpOpen may be enough for both the user and service cases.", "title": null, "type": "comment" }, { "action": "created", "author": "OJ", "comment_id": 100541071, "datetime": 1431202896000, "masked_author": "username_2", "text": "That's what we do now both in meterpreter and the stagers, neither of which\nworks :(", "title": null, "type": "comment" }, { "action": "created", "author": "hmoore-r7", "comment_id": 100541198, "datetime": 1431203114000, "masked_author": "username_3", "text": "Ah, lame, I guess we need to add WinHttpGetIEProxyConfigForCurrentUser() instead", "title": null, "type": "comment" }, { "action": "created", "author": "OJ", "comment_id": 100541840, "datetime": 1431203315000, "masked_author": "username_2", "text": "Yes. And the result of that requires a few other changes too. If wpad is\nused it's not so bad, but if its a custom proxy that requires auth I can't\nyet see how to get it to use the creds automatically.", "title": null, "type": "comment" }, { "action": "created", "author": "Meatballs1", "comment_id": 100559636, "datetime": 1431213503000, "masked_author": "username_0", "text": "Most of the time the auth will be NTLM and should be automatic based on user token?", "title": null, "type": "comment" }, { "action": "created", "author": "OJ", "comment_id": 100559711, "datetime": 1431213716000, "masked_author": "username_2", "text": "True, but not so for basic auth.", "title": null, "type": "comment" }, { "action": "created", "author": "busterb", "comment_id": 107951932, "datetime": 1433251375000, "masked_author": "username_4", "text": "While there is still a ticket for adding stager support that needs more review, the Windows meterpreter bits are now in place. Thanks everyone.", "title": null, "type": "comment" }, { "action": "closed", "author": "bcook-r7", "comment_id": null, "datetime": 1433251390000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

{ "number": 1, "repo": "tf_aws_vpc", "user_login": "terraform-community-modules" }

[ { "action": "opened", "author": "phinze", "comment_id": null, "datetime": 1432993741000, "masked_author": "username_0", "text": "Hi there @username_1!\r\n\r\nI've been kicking around this VPC module locally, and I wanted to toss it up here for discussion. (If you're invested in keeping this as-is I'm happy to push a separate module.)\r\n\r\nThis gives the module the responsibility for creating public and private subnets as well as the VPC.\r\n\r\nIt's by no means a finished product, but let me know what you think!", "title": "[WIP] Revamp w/ public/private subnets ", "type": "issue" }, { "action": "created", "author": "cransom", "comment_id": 107734835, "datetime": 1433197412000, "masked_author": "username_1", "text": "Hi @username_0 , I'll take a look.\r\n\r\nI definitely have no qualms with a merge and this has been largely ignored after the initial push.", "title": null, "type": "comment" }, { "action": "created", "author": "phinze", "comment_id": 114152069, "datetime": 1434986449000, "masked_author": "username_0", "text": "Going to make the executive decision and merge this, since it's useful to me on a daily basis and I'm willing to support it. Happy to make any tweaks you might deem necessary post-merge @username_1 :+1:", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "LeoYao", "comment_id": null, "datetime": 1435175297000, "masked_author": "username_0", "text": "I am trying using \"exist\" keyword to check if a checkbox is checked or not. I found no matter what status the checkbox is in, sikuli-slide always return true as the result of \"exist\" action. I think it should be related to the similarity of the image, because I have similar issue in SikuliX and fix it by increase the similarity threshold. However, I found even if I increased the threshold in Sikuli Slides by setting \"-min_score\" from 0.80 to 0.99 on command line, the result remains incorrect.\r\n\r\nI checked the source code and I found a possible cause. \r\nIn `org.sikuli.slides.api.sikuli.CrossSearchStrategy`, there is some hardcode like below:\r\n``` Java\r\nTarget target = hypothesis.getTarget();\r\ntarget.setMinScore(0.8f);\r\n```\r\nI tried changing 0.8f to 0.95f, and the result seems correct now. However, it seems there are lots of place not using min_score, such as ContextImageTarget.\r\n\r\nI am wondering if the min_score is really in use or has not been implemented?", "title": "-min_score does not work", "type": "issue" } ]

{ "number": 20, "repo": "grunt-nsp", "user_login": "nodesecurity" }

[ { "action": "opened", "author": "grantjforrester", "comment_id": null, "datetime": 1467650167000, "masked_author": "username_0", "text": "We want to use the grunt-nsp task as part of a larger build process and would like it to output in a way that can be picked up by other tools (i.e. a file) and not fail the build so other tasks can run.\r\n\r\nThis pull request adds these two simple options which are both optional so existing users will be unaffected by the change.", "title": "Added 2 new configuration options 'failOnVulns' and 'outputFile'", "type": "issue" }, { "action": "created", "author": "nlf", "comment_id": 231376416, "datetime": 1467988592000, "masked_author": "username_1", "text": "i think the `outputFile` option belongs in nsp itself rather than here.\r\n\r\nthe `failOnVulns` option is an interesting idea, but how you have it implemented here looks like if `failOnVulns` is `false` and `outputFile` is not set, the results of the check are never displayed anywhere", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "davecgh", "comment_id": null, "datetime": 1455246594000, "masked_author": "username_0", "text": "Nowhere else in the software stack refers to atomic units as dbits. They are referred to as atoms everywhere else, so this should match as well.", "title": "Rename dbits to atoms", "type": "issue" }, { "action": "created", "author": "davecgh", "comment_id": 184925856, "datetime": 1455666180000, "masked_author": "username_0", "text": "Confirmed this has been fixed in the most recent update.", "title": null, "type": "comment" }, { "action": "closed", "author": "alexlyp", "comment_id": null, "datetime": 1455731812000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "ImSanchez", "comment_id": null, "datetime": 1434949837000, "masked_author": "username_0", "text": "Hello, I sincerely apologize for any errors or mistakes - this is the first time using Github. \r\n\r\nLine 744 of the master CSS has a forced box-shadow with a blue highlight on all buttons.\r\n\r\n<code>\r\n/*--------------\r\n Focus\r\n---------------*/\r\n.ui.button:focus {\r\n background-color: '';\r\n color: rgba(0, 0, 0, 0.8);\r\n background-image: '' !important;\r\n box-shadow:0 0 0 1px transparent inset,0 0 1px rgba(81,167,232,.8)inset,0 0 3px 2px rgba(81,167,232,.8)!important\r\n}\r\n</code>\r\n\r\n\r\n\r\nThe documents say \"A button will only be keyboard focusable if you set the property <code>tabindex=\"0\"</code>, or if you use a <code>&lt;button&gt;</code>. You can read more about keyboard focus standards at webAIM.\"\r\n\r\nSo should it be this instead?\r\n<code>\r\n/*--------------\r\n Focus\r\n---------------*/\r\n.ui.button:focus {\r\n background-color: '';\r\n color: rgba(0, 0, 0, 0.8);\r\n background-image: '' !important;\r\n box-shadow:0 0 0 1px transparent inset\r\n}\r\nbutton:focus, .ui.button[tabindex=\"0\"]:focus { box-shadow:0 0 0 1px transparent inset,0 0 1px rgba(81,167,232,.8)inset,0 0 3px 2px rgba(81,167,232,.8)!important }\r\n</code>", "title": "Buttons Forced Box Shadow", "type": "issue" }, { "action": "closed", "author": "ImSanchez", "comment_id": null, "datetime": 1434951466000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "ImSanchez", "comment_id": 114010416, "datetime": 1434951466000, "masked_author": "username_0", "text": "It seems that it was changed / fixed in 2.0.", "title": null, "type": "comment" }, { "action": "created", "author": "jlukic", "comment_id": 114178818, "datetime": 1434992383000, "masked_author": "username_1", "text": "Focus colors have been improved in 2.0 for buttons.", "title": null, "type": "comment" } ]

{ "number": 657, "repo": "prism", "user_login": "PrismJS" }

[ { "action": "opened", "author": "manfer", "comment_id": null, "datetime": 1439071964000, "masked_author": "username_0", "text": "If I understood correctly this is how you want to solve https://github.com/PrismJS/prism/issues/645. By adding a new complete hook and changing line numbers plugin to run in that hook instead of running on after highlight hook.", "title": "Complete hook", "type": "issue" }, { "action": "created", "author": "apfelbox", "comment_id": 129745995, "datetime": 1439279468000, "masked_author": "username_1", "text": ":+1:", "title": null, "type": "comment" }, { "action": "created", "author": "manfer", "comment_id": 130014559, "datetime": 1439318903000, "masked_author": "username_0", "text": "Not sure if you mean that an empty code block now triggers the complete hook and it shouldn't or if you want to trigger it and it doesn't. Anyway this code has nothing to do with that issue.\r\n\r\nIf,\r\n\r\n```\r\n<pre><code></code></pre>\r\n```\r\n\r\nis a problem before or after this code,\r\n\r\n```\r\n<pre><code class=\"lang-xxx\"></code></pre>\r\n```\r\n\r\nfor a valid xxx language is/was either. And this code does not deal in any way with that issue if there is any.\r\n\r\nThe hook addition has been suggested on https://github.com/PrismJS/prism/issues/645 and the problem that tries to solve is to include line numbers on source code for which there is no grammar.\r\n\r\nSo the complete hook runs at the end of proccess. For source code for which there is a grammar that's at the end, line 233. But for source code for which there is no grammar (`!grammar`) that's on line 196 before the `return`.\r\n\r\nI'm not too familiarized with the library so the PR can be wrong of course. So needs review.", "title": null, "type": "comment" }, { "action": "created", "author": "Golmote", "comment_id": 130555583, "datetime": 1439447808000, "masked_author": "username_2", "text": "I made a few changes to your PR (see fd549959cd57d1c5de8be2f6d7600fe9bd050857) to take @uranusjr's comment into account.", "title": null, "type": "comment" }, { "action": "created", "author": "markg85", "comment_id": 160429947, "datetime": 1448814045000, "masked_author": "username_3", "text": "Thank you folks for fixing this (issue #645). It looks perfectly fine to me now.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "shurcooL", "comment_id": null, "datetime": 1465798496000, "masked_author": "username_0", "text": "So this line, for example, would fail to work as expected if one has 2 or more workspaces:\r\n\r\n```Go\r\nfi, err := ioutil.ReadDir(build.Default.GOPATH + \"/bin\")\r\n```\r\n\r\nBecause the value of `build.Default.GOPATH` would be something like `/path/to/workspace1:/path/to/workspace2`.\r\n\r\nThe correct solution is to use [`filepath.SplitList`](https://godoc.org/path/filepath#SplitList) to parse GOPATH environment variable and extract all workspaces that are included. Then, you'd want to process them in a way that works.\r\n\r\nYou can look at `binstale` for [an example](https://github.com/username_0/binstale/blob/14c3c3e47f8a05aa0396e611d616d9487cfe040d/main.go#L59) of how to work with multiple workspaces.", "title": "gorebuild will fail in environments where GOPATH includes 2 or more workspaces.", "type": "issue" } ]

[ { "action": "opened", "author": "arrufat", "comment_id": null, "datetime": 1475677736000, "masked_author": "username_0", "text": "I am having the following build error on Arch Linux with node 6.3.0 and imagemagick 6.9.5.10\r\n\r\n```\r\nCXX(target) Release/obj.target/imagemagick/src/imagemagick.o\r\nIn file included from ../../nan/nan.h:196:0,\r\n from ../src/imagemagick.h:5,\r\n from ../src/imagemagick.cc:9:\r\n../../nan/nan_new.h: In instantiation of ‘typename Nan::imp::Factory<T>::return_t Nan::New(A0) [with T = v8::Integer; A0 = float; typename Nan::imp::Factory<T>::return_t = v8::Local<v8::Integer>]’:\r\n../src/imagemagick.cc:810:93: required from here\r\n../../nan/nan_new.h:208:30: error: call of overloaded ‘New(float&)’ is ambiguous\r\n return imp::Factory<T>::New(arg0);\r\n ~~~~~~~~~~~~~~~~~~~~^~~~~~\r\nIn file included from ../../nan/nan_new.h:189:0,\r\n from ../../nan/nan.h:196,\r\n from ../src/imagemagick.h:5,\r\n from ../src/imagemagick.cc:9:\r\n../../nan/nan_implementation_12_inl.h:162:1: note: candidate: static Nan::imp::IntegerFactory<T>::return_t Nan::imp::IntegerFactory<T>::New(int32_t) [with T = v8::Integer; Nan::imp::IntegerFactory<T>::return_t = v8::Local<v8::Integer>; int32_t = int]\r\n IntegerFactory<T>::New(int32_t value) {\r\n ^~~~~~~~~~~~~~~~~\r\nIn file included from ../../nan/nan.h:196:0,\r\n from ../src/imagemagick.h:5,\r\n from ../src/imagemagick.cc:9:\r\n../../nan/nan_new.h:114:26: note: candidate: static Nan::imp::IntegerFactory<T>::return_t Nan::imp::IntegerFactory<T>::New(uint32_t) [with T = v8::Integer; Nan::imp::IntegerFactory<T>::return_t = v8::Local<v8::Integer>; uint32_t = unsigned int]\r\n static inline return_t New(uint32_t value);\r\n```\r\n\r\nAny suggestions?\r\n\r\nThanks in advance", "title": "Build error with imagemagick 6.9.5.10", "type": "issue" }, { "action": "created", "author": "BooDoo", "comment_id": 257768980, "datetime": 1478060553000, "masked_author": "username_1", "text": "Same issue with node 7.0.0 and IM 6.9.6.2 (on Arch)\r\n\r\nWill update if I find a resolution, but for now, just: +1", "title": null, "type": "comment" } ]

{ "number": 45, "repo": "estatico", "user_login": "unic" }

[ { "action": "opened", "author": "marbor3", "comment_id": null, "datetime": 1486804266000, "masked_author": "username_0", "text": "Updating jQuery to the latest.\r\nRight now found only two breaking changes - `$(document).on('ready'` removal and `data()` not returning requested whole data object when data attribute name is in kebab-case.\r\n\r\nFull list of changes and a migration guide:\r\nhttps://jquery.com/upgrade-guide/3.0/", "title": "Updating jQuery to 3.2.1", "type": "issue" }, { "action": "created", "author": "orioltf", "comment_id": 299483316, "datetime": 1493995292000, "masked_author": "username_1", "text": "Hi @username_0 the Unit test from Slideshow fails. Could you have a look at it, please?", "title": null, "type": "comment" }, { "action": "created", "author": "backflip", "comment_id": 307185490, "datetime": 1496945901000, "masked_author": "username_2", "text": "@username_1, same issue as in https://github.com/unic/estatico/pull/64#issuecomment-307172434\r\nRebasing fixed the issue for me.", "title": null, "type": "comment" } ]

{ "number": 91, "repo": "Motif", "user_login": "erichoracek" }

[ { "action": "opened", "author": "erichoracek", "comment_id": null, "datetime": 1484155999000, "masked_author": "username_0", "text": "This extracts the expensive operation of iterating through the source observation directory into a method that is only invoked once per observation, rather than invoked once per theme per observation.", "title": "Speed up theme source observation with deep source directories and theme hierarchies", "type": "issue" } ]

[ { "action": "opened", "author": "rappo", "comment_id": null, "datetime": 1454460953000, "masked_author": "username_0", "text": "\r\n\r\nif a contributor change that to \"Edit Contribution\" and link to settings/support_levels", "title": "Change \"Support [team]\" text if you're a supporter", "type": "issue" }, { "action": "created", "author": "3rdwiki", "comment_id": 180102466, "datetime": 1454628797000, "masked_author": "username_1", "text": "username_0, could you put the bounty contribution button on this and other/s listed below for ease.\r\nThanks.\r\n\r\n[/1003](https://github.com/bountysource/core/issues/1003)", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "derekwaynecarr", "comment_id": null, "datetime": 1443194037000, "masked_author": "username_0", "text": "I agree.\r\n\r\ncc @username_1 @kubernetes/rh-cluster-infra \r\ncc @kubernetes/goog-control-plane", "title": "Remove experimentalMode from namespace_controller", "type": "issue" }, { "action": "created", "author": "deads2k", "comment_id": 143251153, "datetime": 1443194594000, "masked_author": "username_1", "text": "@username_0 Yes please.", "title": null, "type": "comment" }, { "action": "created", "author": "mikedanese", "comment_id": 143251626, "datetime": 1443194721000, "masked_author": "username_2", "text": "@username_3 any recommendation on how to do this?", "title": null, "type": "comment" }, { "action": "created", "author": "caesarxuchao", "comment_id": 143280905, "datetime": 1443200216000, "masked_author": "username_3", "text": "This [line](https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-controller-manager/app/controllermanager.go#L277) seems wrong: \r\n```\r\nexperimentalMode := s.EnableHorizontalPodAutoscaler || s.EnableDeploymentController\r\n```\r\nIt should deduce if experimental group is registered by checking if latest.Group(\"experimental\") returns an error.\r\n\r\nI think we should remove experimentalMode, keep s.EnableHorizontalPodAutoscaler and s.EnableDeploymentController, and checks these two flags and latest.Group(\"experimental\") before execute the code related to these two controllers.", "title": null, "type": "comment" }, { "action": "created", "author": "caesarxuchao", "comment_id": 143281040, "datetime": 1443200235000, "masked_author": "username_3", "text": "@nikhiljindal @username_4", "title": null, "type": "comment" }, { "action": "created", "author": "deads2k", "comment_id": 143282829, "datetime": 1443200408000, "masked_author": "username_1", "text": "Checking if the group is registered is not the same as knowing whether the resources are being served. It's possible to have the schemes and codecs present, but not serve the resources to be cleaned up.", "title": null, "type": "comment" }, { "action": "created", "author": "caesarxuchao", "comment_id": 143290622, "datetime": 1443201124000, "masked_author": "username_3", "text": "By \"being served\", do you mean if there are endpoints exposed on API server? If so, the controller manager can use the API discovery mechanism introduced in #13955, i.e., it needs to check if these two controllers exist in the APIReourceList returned at /apis/experimental/version", "title": null, "type": "comment" }, { "action": "created", "author": "deads2k", "comment_id": 143292516, "datetime": 1443201558000, "masked_author": "username_1", "text": "I think that would be more appropriate. Find the exposed, namespaced resources and delete them. That fulfills the intent.", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 143302613, "datetime": 1443203544000, "masked_author": "username_4", "text": "namespace controller runs in controller manager, not apiserver, right? (please say yes)\r\n\r\nIt should deduce whether experimental is on by querying apiserver, not by what is compiled into it.\r\n\r\nFuture: In fact it should not use the high level client at all. It should use raw RESTClients (like kubectl builder). And it should discover the entire list of namespaced resources by querying apiserver, which @username_3 recently made possible.\r\n\r\n(disclaimer: I've never looked at the component, so I don't know how much of that it does already)", "title": null, "type": "comment" }, { "action": "created", "author": "derekwaynecarr", "comment_id": 143312483, "datetime": 1443204982000, "masked_author": "username_0", "text": "@username_4 - its in controller manager.", "title": null, "type": "comment" }, { "action": "created", "author": "derekwaynecarr", "comment_id": 143313317, "datetime": 1443205229000, "masked_author": "username_0", "text": "@username_3 - are there client libraries for dealing with the API discovery mechanism you can direct me towards?", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 143313460, "datetime": 1443205275000, "masked_author": "username_4", "text": "We are still building them :(", "title": null, "type": "comment" }, { "action": "created", "author": "derekwaynecarr", "comment_id": 143313825, "datetime": 1443205364000, "masked_author": "username_0", "text": "@username_4 - is there a PR i can track?", "title": null, "type": "comment" }, { "action": "created", "author": "lavalamp", "comment_id": 143315194, "datetime": 1443205696000, "masked_author": "username_4", "text": "The issue #14321 is the closest thing I can give you at the moment.", "title": null, "type": "comment" }, { "action": "created", "author": "derekwaynecarr", "comment_id": 148188188, "datetime": 1444854882000, "masked_author": "username_0", "text": "The change in https://github.com/kubernetes/kubernetes/pull/15427 will remove the experimental flag and work against the discovery API. \r\n\r\nAs a result, I am closing this issue.\r\n\r\nI will shift focus to https://github.com/kubernetes/kubernetes/issues/14765 to make it delete all resources based on discovery with no manual need for future developers to write code in namespace_controller to take part in deletion lifecycle.", "title": null, "type": "comment" }, { "action": "closed", "author": "derekwaynecarr", "comment_id": null, "datetime": 1444854886000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "cinaradem", "comment_id": null, "datetime": 1452007610000, "masked_author": "username_0", "text": "{\r\nerror: {\r\ncode: \"\",\r\nmessage: \"An error has occurred.\",\r\ninnererror: {\r\nmessage: \"The 'ObjectContent`1' type failed to serialize the response body for content type 'application/json; odata.metadata=minimal'.\",\r\ntype: \"System.InvalidOperationException\",\r\nstacktrace: \"\",\r\ninternalexception: {\r\nmessage: \"The given model does not contain the type 'Model.Enums.HeadlineType'.\",\r\ntype: \"System.InvalidOperationException\",\r\nstacktrace: \" at System.Web.OData.Formatter.Serialization.ODataSerializerContext.GetEdmType(Object instance, Type type) at System.Web.OData.Formatter.Serialization.ODataEntityTypeSerializer.CreateStructuralProperty(IEdmStructuralProperty structuralProperty, EntityInstanceContext entityInstanceContext) at System.Web.OData.Formatter.Serialization.ODataEntityTypeSerializer.CreateStructuralPropertyBag(IEnumerable`1 structuralProperties, EntityInstanceContext entityInstanceContext) at System.Web.OData.Formatter.Serialization.ODataEntityTypeSerializer.CreateEntry(SelectExpandNode selectExpandNode, EntityInstanceContext entityInstanceContext) at System.Web.OData.Formatter.Serialization.ODataEntityTypeSerializer.WriteEntry(Object graph, ODataWriter writer, ODataSerializerContext writeContext) at System.Web.OData.Formatter.Serialization.ODataEntityTypeSerializer.WriteObjectInline(Object graph, IEdmTypeReference expectedType, ODataWriter writer, ODataSerializerContext writeContext) at System.Web.OData.Formatter.Serialization.ODataFeedSerializer.WriteFeed(IEnumerable enumerable, IEdmTypeReference feedType, ODataWriter writer, ODataSerializerContext writeContext) at System.Web.OData.Formatter.Serialization.ODataFeedSerializer.WriteObjectInline(Object graph, IEdmTypeReference expectedType, ODataWriter writer, ODataSerializerContext writeContext) at System.Web.OData.Formatter.Serialization.ODataFeedSerializer.WriteObject(Object graph, Type type, ODataMessageWriter messageWriter, ODataSerializerContext writeContext) at Microsoft.Restier.WebApi.Formatter.Serialization.RestierFeedSerializer.WriteObject(Object graph, Type type, ODataMessageWriter messageWriter, ODataSerializerContext writeContext) at System.Web.OData.Formatter.ODataMediaTypeFormatter.WriteToStream(Type type, Object value, Stream writeStream, HttpContent content, HttpContentHeaders contentHeaders) at System.Web.OData.Formatter.ODataMediaTypeFormatter.WriteToStreamAsync(Type type, Object value, Stream writeStream, HttpContent content, TransportContext transportContext, CancellationToken cancellationToken) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter.GetResult() at System.Web.Http.WebHost.HttpControllerHandler.<WriteBufferedResponseContentAsync>d__1b.MoveNext()\"\r\n}\r\n}\r\n}\r\n}", "title": "The 'ObjectContent`1' type failed to serialize the response body for content type 'application/json; odata.metadata=minimal", "type": "issue" }, { "action": "created", "author": "xuzhg", "comment_id": 170425070, "datetime": 1452483390000, "masked_author": "username_1", "text": "@username_0 \r\n\r\nWould you please share us your metadata document? \r\nWould you please help check whether or not the \"'Model.Enums.HeadlineType\" type is in the EdmModel?", "title": null, "type": "comment" }, { "action": "closed", "author": "LaylaLiu", "comment_id": null, "datetime": 1458282929000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "hikalkan", "comment_id": 249828737, "datetime": 1474972624000, "masked_author": "username_3", "text": "See also https://github.com/OData/WebApi/issues/170", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "steelejoe", "comment_id": null, "datetime": 1445321876000, "masked_author": "username_0", "text": "Section 9.4 contains the following text:\r\n\r\n\"Such implementations should not use identifiers for a device or user of a device in the individualization process.\"\r\n\r\nThis is too broad. I proposed instead the following:\r\n\"Such implementations should not directly provide identifiers for a device or user of a device in any messages sent during the individualization process. \"\r\n\r\nThis allows for implementations which generate unique identifiers not directly associable with the device or user by digesting a mixture of device identifiers. These identifiers can have the security property that two different devices are unlikely to generate the same identifier, but also have the privacy property that it is very difficult to match an identifier to a user+device.\r\n\r\nDavid suggested looking for guidance to [this email thread](https://lists.w3.org/Archives/Public/public-html-media/2014Oct/0092.html).\r\n\r\nOriginal bug was [Bug 27168](https://www.w3.org/Bugs/Public/show_bug.cgi?id=27168).", "title": "Individualization text regarding device identifiers is overly broad and restrictive", "type": "issue" }, { "action": "created", "author": "ddorwin", "comment_id": 150019152, "datetime": 1445460284000, "masked_author": "username_1", "text": "The point is to prevent tracking, especially across origins and after the user clears Distinctive Identifier(s) and other state. I believe \"not directly provide\" is too vague to cover the privacy concerns. Specifically, data passed to the application should be be reversible (i.e. just XORing the origin) and data/identifiers provided to the application after the user clears the previous identifiers must be different and not reversible or otherwise correlatable with the previous value.\r\n\r\nIt appears that @username_4's [description of Firefox's implementation](https://lists.w3.org/Archives/Public/public-html-media/2014Oct/0092.html) (search for \"ingredients\") meets these requirements, and the spec text is not intended to prevent such implementations.\r\n\r\nI see how the current text could prohibit the first ingredient, so we should figure out how to place appropriate restrictions on the use of such ingredients.", "title": null, "type": "comment" }, { "action": "created", "author": "steelejoe", "comment_id": 151051587, "datetime": 1445845711000, "masked_author": "username_0", "text": "I agree that we should add some specific text that references this requirement. Is this text specific enough in your opinion?\r\n\r\n\"Such implementations which use Distinctive Identifier(s) for a device or user of a device during the individualization process must apply a non-reversible data transformation to the identifiers which includes per-origin information (e.g. a cryptographic hash algorithm).\"", "title": null, "type": "comment" }, { "action": "created", "author": "jdsmith3000", "comment_id": 151753201, "datetime": 1446017922000, "masked_author": "username_2", "text": "@username_0 This language appears to allow a non-origin specific Distinctive Identifier that is permanently modified with origin specific information. That would appear to make it an origin specific identifier in actual use, though one apparently derived from a single non-origin specific root identifier. Is that your intent? Does this actually need to be stated as such in the EME spec?", "title": null, "type": "comment" }, { "action": "created", "author": "ddorwin", "comment_id": 152308777, "datetime": 1446150488000, "masked_author": "username_1", "text": "We'll need a clear definition of Distinctive Identifier (issue #117) before we can decide on text that references it.", "title": null, "type": "comment" }, { "action": "created", "author": "ddorwin", "comment_id": 195058722, "datetime": 1457645583000, "masked_author": "username_1", "text": "Let's re-triage this after blocking bug #117 is resolved.", "title": null, "type": "comment" }, { "action": "created", "author": "jdsmith3000", "comment_id": 222188941, "datetime": 1464365687000, "masked_author": "username_2", "text": "Reviewed by the editors (@username_1, @username_3, @jdsmith). We believe this issue may resolve when issue #117 is completed. We will confirm back with @username_0 then.", "title": null, "type": "comment" }, { "action": "created", "author": "ddorwin", "comment_id": 224444389, "datetime": 1465342027000, "masked_author": "username_1", "text": "The language referenced in the original report was probably intended to prevent permanent/indelible values from being passed to the application. This is still disallowed. However, a Distinctive Identifier is not a permanent identifier, so the language may not be appropriate. Because Distinctive Identifiers are per-origin, clearable, non-associable, etc., it should be okay to pass them to the application for Per-Origin Individualization just as they are passed to \r\n\r\nOne way to look at this might be that the hash of the ingredients is a Distinctive Identifier that is passed to the application to generate a new Distinctive Identifier.\r\n\r\nI believe the changes for #117 address the issue of associability and \"non-reversible data transformation.\"\r\n\r\nIt seems we want to allow (the new definition of) Distinctive Identifiers while prohibiting exposure of permanent/indelible/associable values.\r\n\r\nI will make a PR for review and discussion.", "title": null, "type": "comment" }, { "action": "created", "author": "ddorwin", "comment_id": 224686442, "datetime": 1465410912000, "masked_author": "username_1", "text": "I created PR #234. Please review so I can move forward with related issues.", "title": null, "type": "comment" }, { "action": "created", "author": "mwatson2", "comment_id": 224758048, "datetime": 1465427278000, "masked_author": "username_3", "text": "LGTM with the small comments I made in the PR.", "title": null, "type": "comment" }, { "action": "created", "author": "mwatson2", "comment_id": 224769856, "datetime": 1465431666000, "masked_author": "username_3", "text": "The present text appears to class such identifiers as \"Distinctive Identifiers\" even if they are not associable by any entity across clearing by the user or across origins.\r\n\r\nIsn't the definition of Distinctive Identifier supposed to be those that are associable by some entity ?", "title": null, "type": "comment" }, { "action": "created", "author": "ddorwin", "comment_id": 224771730, "datetime": 1465432473000, "masked_author": "username_1", "text": "I interpreted the original point as the requirement that \"Such implementations MUST NOT use Distinctive Identifier(s)\" was too restrictive. This allows Distinctive Identifiers to be used, but the resulting values are still Distinctive Identifiers.\r\n\r\nAs noted in https://github.com/w3c/encrypted-media/pull/234#discussion_r66361853, this is due to the current definition of Distinctive Identifier. We don't have a definition for which types of derivations are acceptable. See also #219.", "title": null, "type": "comment" }, { "action": "created", "author": "ddorwin", "comment_id": 224774599, "datetime": 1465433735000, "masked_author": "username_1", "text": "I believe PR #234 significantly improves the state of this section, which was out of date, and brings us much closer to addressing this issue. In the interest of the timeline and conflicting PRs, should we remove \"Fix\" from the commit summary, merge the PR, and continue to work on this issue with a new more-relevant base?", "title": null, "type": "comment" }, { "action": "created", "author": "mwatson2", "comment_id": 224782368, "datetime": 1465437601000, "masked_author": "username_3", "text": "Yes, that makes sense.", "title": null, "type": "comment" }, { "action": "created", "author": "hsivonen", "comment_id": 224845536, "datetime": 1465464748000, "masked_author": "username_4", "text": "If any random tracking script can initiate an EME flow and get back a stable (until cleared by explicit user action), even if origin-specific, identifier without ever talking to an indiv or key server (i.e. not continuing the EME flow beyond initial poking at the API to elicit the initial message), this adds a new, and illegitimate in the light of the purpose of EME, repeat visit tracking mechanism.\r\n\r\nIn the indiv case, it would be problematic if tracking tech could trigger indiv in a way that exposes a Distinctive Identifier visibly to the JS and not only to an indiv server is possession of some secret to decrypt the indiv request and the same Distinctive Identifier was exposed on a subsequent visit. Then tracking tech could elicit indiv messages and never forward them to an indiv server as a way to track repeat visits to a site.\r\n\r\nObviously, if the site actually has a key server or indiv server for the Key System, then, technically, the site/app gets to see a Distinctive Identifier as unwrapped by the server, but at least tracking tech has the barrier of obtaining and operating such a server as well as potentially the licensing terms for such server.", "title": null, "type": "comment" }, { "action": "created", "author": "jdsmith3000", "comment_id": 225080647, "datetime": 1465526501000, "masked_author": "username_2", "text": "Issue #246 carries forward some discussion topics for EME during CR. Issue #110 is closed.", "title": null, "type": "comment" }, { "action": "closed", "author": "jdsmith3000", "comment_id": null, "datetime": 1465526501000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "ddorwin", "comment_id": 225082194, "datetime": 1465527469000, "masked_author": "username_1", "text": "@username_4, I hope the following is helpful. Please let us know if you still have concerns or if you have suggestions for improvement. For general issues not related to App-Assisted Individualization, it might help to file separate issues.\r\n\r\nI agree with the concerns in your first paragraph. For Distinctive Identifiers, we essentially only require consent if the value cannot be cleared like a cookie and other site data. See #246. Otherwise, the implementation must \"Inform the user that... Distinctive Identifier(s) and/or Distinctive Permanent Identifier(s) as appropriate will be used...\" What form \"informing\" takes is left up to the implementation, but it is certainly not as strong as obtaining consent.\r\n\r\nFor all other identifiers or potentially identifying/trackable values, there is no requirement except that they must be [clearable](https://w3c.github.io/encrypted-media/#allow-identifiers-cleared) and SHOULD be [clearable along with cookies and other site data](https://w3c.github.io/encrypted-media/#allow-persistent-data-cleared). Thus, it is possible to get a \"cookie-like\" tracking value, though not necessary that it be as easy to clear as a cookie. (Perhaps the \"SHOULD\" should be a \"MUST\" if there is no consent or informing.)\r\n\r\nhttps://w3c.github.io/encrypted-media/#encrypt-identifiers addresses some of the concerns in your second paragraph:\r\n- Distinctive Identifiers MUST be encrypted.\r\n- \"The encryption MUST ensure that the ciphertext cannot be used as a proxy for the actual identifier, even given the same plaintext.\"\r\n- \"The CDM MUST verify that the encryption key belongs to a valid server for its Key System.\"\r\n\r\nHowever, other types of values only SHOULD be encrypted. We could make that a MUST, but we would need to define \"identifier\" since nearly anything exposed to the application could be used as an identifier (just like cookies and other site data). The question is where to draw the line given the existence of many other types of persistent data. Allowing all types of data to be cleared together seems important as does ensuring values (other than Distinctive Identifiers and Permanent Identifiers, which have separate considerations) are no worse than other types of data seems important. See my third paragraph above.\r\n\r\nSpecific to the\"indiv case,\" I'm not sure this is much different from generating a request where such individualization is not necessary. In both cases, a message with an identifier may be generated. If there are differences, we may want to address them. Note that no message can be sent to the application (and neither type of provisioning may occur, though I'm not sure this is explicitly stated) without going through `requestMediaKeySystemAccess()`, so all the _opportunities_ for a user agent to _choose_ to get consent or otherwise inform the user are still available. (While it may not be obvious in the text, the individualization process can only use Distinctive Identifiers if the result of the `requestMediaKeySystemAccess()` call included `distinctiveIdentifier=\"required\"`. See #248.)\r\n\r\nRegarding your last paragraph, this controlling access to servers (and server certificates) is an important option for implementations, but I don't think we should assume all Key System vendors closely control them or they are only given to \"good actors.\" Thus, the other privacy mitigations remain important.\r\n\r\nAdmittedly, the mitigations above depend on the implementations, including the CDM, which the user agent may not have great insight into. Even the ability to clear cookies depends on the user agent, though it is a much more well-established pattern.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "thomwithoutanh", "comment_id": null, "datetime": 1484042358000, "masked_author": "username_0", "text": "Ozren hasn't designed this yet but it would essentially be:\r\na) six questions with free text field answers\r\nb) no need to register to input answers\r\nc) a PDF and text output option at the end", "title": "Creating one page with a six-question 'mini' version of the tool. ", "type": "issue" }, { "action": "created", "author": "IronRunes", "comment_id": 277755668, "datetime": 1486402798000, "masked_author": "username_1", "text": "#33", "title": null, "type": "comment" }, { "action": "closed", "author": "IronRunes", "comment_id": null, "datetime": 1486402838000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "boydkr", "comment_id": null, "datetime": 1464890754000, "masked_author": "username_0", "text": "I tried to use `ember-power-select` to create a searchable dropdown in a modal, and it was impossible to focus on the search input because `lm-container#focus` steals focus from anything outside of the modal.\r\n\r\nI implemented a hacky workaround, but it would be nice if liquid-fire had a way to deal with this.\r\n\r\nAre there any suggestions for how to go about fixing this issue? I would be willing to work on a PR.\r\n\r\n###### My Workaround\r\n`app/components/lm-container.js`\r\n``` javascript\r\n focus: function() {\r\n if (this.get('element').contains(document.activeElement)) {\r\n // just let it be if we already contain the activeElement\r\n return;\r\n }\r\n\r\n //workaround to avoid stealing focus from wormholes\r\n let isWormhole = $('#ember-basic-dropdown-wormhole, #paper-wormhole')\r\n .toArray()\r\n .some(function(elem) {\r\n return elem.contains(document.activeElement);\r\n });\r\n\r\n if (isWormhole) { \r\n return;\r\n }\r\n\r\n var target = this.$('[autofocus]');\r\n if (!target.length) {\r\n target = this.$(':tabbable');\r\n }\r\n\r\n if (!target.length) {\r\n target = this.$();\r\n }\r\n\r\n target[0].focus();\r\n },\r\n```", "title": "Modals steal focus from wormholes", "type": "issue" }, { "action": "created", "author": "ef4", "comment_id": 224427669, "datetime": 1465336736000, "masked_author": "username_1", "text": "Yeah, this is a concern. I have run into similar issues.\r\n\r\nMy long game is to build a more composable shared solution for all modals and floats -- including both liquid-modal (which may not need to even exist) and ember-power-select's dropdown.\r\n\r\n[ember-sidebars](https://github.com/username_1/ember-sidebars) is basically already the right primitive. If we extended it to understand stacking context, something like a power-select inside a modal could be made to work correctly out of the box.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "mpapis", "comment_id": null, "datetime": 1428097831000, "masked_author": "username_0", "text": "start with http://contributor-covenant.org/\r\nsome good points https://adainitiative.org/2014/02/howto-design-a-code-of-conduct-for-your-community/", "title": "Add Code of Conduct", "type": "issue" }, { "action": "created", "author": "CoralineAda", "comment_id": 93039886, "datetime": 1429041105000, "masked_author": "username_1", "text": "Thanks for doing this!", "title": null, "type": "comment" }, { "action": "closed", "author": "havenwood", "comment_id": null, "datetime": 1429041429000, "masked_author": "username_2", "text": "", "title": null, "type": "issue" }, { "action": "created", "author": "havenwood", "comment_id": 93040971, "datetime": 1429041429000, "masked_author": "username_2", "text": "RVM now adheres to the Contributor Code of Conduct. Closed by 86b5579fae2b3a7f2474b39362909697c6b3d128.", "title": null, "type": "comment" } ]

[ { "action": "opened", "author": "xDaizu", "comment_id": null, "datetime": 1433144083000, "masked_author": "username_0", "text": "When creating a category, the field \"UrlCode\" returns error with some characters, like **quotes** and **slashes**, but accepts other invalid characters, like **#**", "title": "UrlCode accepts invalid characters", "type": "issue" }, { "action": "created", "author": "kasperisager", "comment_id": 125165068, "datetime": 1437994545000, "masked_author": "username_1", "text": "All sanitisation is performed by Vanilla core and not the API shim.", "title": null, "type": "comment" }, { "action": "closed", "author": "kasperisager", "comment_id": null, "datetime": 1437994545000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "tmat", "comment_id": null, "datetime": 1470085218000, "masked_author": "username_0", "text": "http://dotnet-ci.cloudapp.net/job/dotnet_roslyn/job/master/job/windows_debug_unit32_prtest/1832/testReport/junit/Microsoft.CodeAnalysis.UnitTests/SnapshotSerializationTests/Workspace_RoundTrip_Test_Desktop/", "title": "Workspace_RoundTrip_Test_Desktop is flaky", "type": "issue" }, { "action": "created", "author": "tmat", "comment_id": 236706246, "datetime": 1470085226000, "masked_author": "username_0", "text": "@username_1", "title": null, "type": "comment" }, { "action": "created", "author": "heejaechang", "comment_id": 236706754, "datetime": 1470085342000, "masked_author": "username_1", "text": "this is already fixed in preivew 4 branch. I will bring the change to master.", "title": null, "type": "comment" }, { "action": "closed", "author": "heejaechang", "comment_id": null, "datetime": 1470088296000, "masked_author": "username_1", "text": "", "title": null, "type": "issue" } ]

[ { "action": "opened", "author": "Kikobeats", "comment_id": null, "datetime": 1460656693000, "masked_author": "username_0", "text": "Hey!\r\n\r\nPagination widgets looks awesome. I'm interested in add infinite scroll in my project. Altought pagination widget support many options, I don't see nothing related with infinite scroll.\r\n\r\nDo you think that could be possible add this feature and have sense be resolved from the library instead of use a external dependency?", "title": "[Question] Infinite Scroll Support", "type": "issue" }, { "action": "created", "author": "hkdobrev", "comment_id": 210084763, "datetime": 1460657834000, "masked_author": "username_1", "text": "Duplicate of #936, previous discussion in #328.", "title": null, "type": "comment" }, { "action": "created", "author": "Kikobeats", "comment_id": 210121078, "datetime": 1460663663000, "masked_author": "username_0", "text": "Oh dammit! I used the search before create the issue. Maybe the title is clever :P", "title": null, "type": "comment" }, { "action": "closed", "author": "Kikobeats", "comment_id": null, "datetime": 1460663663000, "masked_author": "username_0", "text": "", "title": null, "type": "issue" } ]