url
stringlengths 59
59
| repository_url
stringclasses 1
value | labels_url
stringlengths 73
73
| comments_url
stringlengths 68
68
| events_url
stringlengths 66
66
| html_url
stringlengths 49
49
| id
int64 782M
1.89B
| node_id
stringlengths 18
24
| number
int64 4.97k
9.98k
| title
stringlengths 2
306
| user
dict | labels
list | state
stringclasses 2
values | locked
bool 1
class | assignee
dict | assignees
list | milestone
dict | comments
sequence | created_at
unknown | updated_at
unknown | closed_at
unknown | author_association
stringclasses 4
values | active_lock_reason
null | body
stringlengths 0
63.6k
⌀ | reactions
dict | timeline_url
stringlengths 68
68
| performed_via_github_app
null | state_reason
stringclasses 3
values | draft
bool 0
classes | pull_request
dict | is_pull_request
bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/kubeflow/pipelines/issues/5902 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5902/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5902/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5902/events | https://github.com/kubeflow/pipelines/issues/5902 | 926,906,366 | MDU6SXNzdWU5MjY5MDYzNjY= | 5,902 | Gcp Ml training and deploying prebuild component from on premise | {
"login": "motilalmeher",
"id": 49094780,
"node_id": "MDQ6VXNlcjQ5MDk0Nzgw",
"avatar_url": "https://avatars.githubusercontent.com/u/49094780?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/motilalmeher",
"html_url": "https://github.com/motilalmeher",
"followers_url": "https://api.github.com/users/motilalmeher/followers",
"following_url": "https://api.github.com/users/motilalmeher/following{/other_user}",
"gists_url": "https://api.github.com/users/motilalmeher/gists{/gist_id}",
"starred_url": "https://api.github.com/users/motilalmeher/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/motilalmeher/subscriptions",
"organizations_url": "https://api.github.com/users/motilalmeher/orgs",
"repos_url": "https://api.github.com/users/motilalmeher/repos",
"events_url": "https://api.github.com/users/motilalmeher/events{/privacy}",
"received_events_url": "https://api.github.com/users/motilalmeher/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"Hi @motilalmeher, you can find how to mount GCP service account credentials in doc: https://www.kubeflow.org/docs/distributions/gke/pipelines/authentication-pipelines/#authoring-pipelines-to-use-gsa-keys",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-22T07:09:23" | "2022-03-03T03:05:34" | "2022-03-03T03:05:34" | NONE | null | In kubeflow prebuild component(Gcp Ml training and deploying) there is no option for giving credential to use AI platform of a GCP for training and deployment purpose from on premise. How to handle that? Do we need to write our customize code for traing job and deplying job? | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5902/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5902/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5901 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5901/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5901/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5901/events | https://github.com/kubeflow/pipelines/issues/5901 | 926,862,447 | MDU6SXNzdWU5MjY4NjI0NDc= | 5,901 | How to use customized name of the component(pre build component) used in kubeflow. | {
"login": "motilalmeher",
"id": 49094780,
"node_id": "MDQ6VXNlcjQ5MDk0Nzgw",
"avatar_url": "https://avatars.githubusercontent.com/u/49094780?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/motilalmeher",
"html_url": "https://github.com/motilalmeher",
"followers_url": "https://api.github.com/users/motilalmeher/followers",
"following_url": "https://api.github.com/users/motilalmeher/following{/other_user}",
"gists_url": "https://api.github.com/users/motilalmeher/gists{/gist_id}",
"starred_url": "https://api.github.com/users/motilalmeher/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/motilalmeher/subscriptions",
"organizations_url": "https://api.github.com/users/motilalmeher/orgs",
"repos_url": "https://api.github.com/users/motilalmeher/repos",
"events_url": "https://api.github.com/users/motilalmeher/events{/privacy}",
"received_events_url": "https://api.github.com/users/motilalmeher/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi @motilalmeher, you can refer to https://github.com/kubeflow/pipelines/blob/d9c019641ef9ebd78db60cdb78ea29b0d9933008/samples/core/continue_training_from_prod/continue_training_from_prod.py#L63 which sets a display name for different tasks.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-22T06:03:31" | "2022-03-03T03:05:35" | "2022-03-03T03:05:35" | NONE | null | I am using GCP ml traning and deploying prebuild component for training and deployment. In my kubeflow pipliline, I am using multiple models for hyperparameter tuning and final model traing on best set of parameters. But I can not able to add a name to the pre build component. So in pipeline dashboard, every training component have same name. I want to add name by my own like for logistic regression model, I want different name and for other model like random forest, i want to give another name. So that from UI , I can able to know which component is for what. | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5901/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5901/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5900 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5900/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5900/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5900/events | https://github.com/kubeflow/pipelines/issues/5900 | 926,856,969 | MDU6SXNzdWU5MjY4NTY5Njk= | 5,900 | kfp.components.structures.ComponentsSpec to create run in kubeflow | {
"login": "swamat",
"id": 53515128,
"node_id": "MDQ6VXNlcjUzNTE1MTI4",
"avatar_url": "https://avatars.githubusercontent.com/u/53515128?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/swamat",
"html_url": "https://github.com/swamat",
"followers_url": "https://api.github.com/users/swamat/followers",
"following_url": "https://api.github.com/users/swamat/following{/other_user}",
"gists_url": "https://api.github.com/users/swamat/gists{/gist_id}",
"starred_url": "https://api.github.com/users/swamat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/swamat/subscriptions",
"organizations_url": "https://api.github.com/users/swamat/orgs",
"repos_url": "https://api.github.com/users/swamat/repos",
"events_url": "https://api.github.com/users/swamat/events{/privacy}",
"received_events_url": "https://api.github.com/users/swamat/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Did kfp.components.structures.ComponentsSpec.save() and loaded the yaml file.. But unable to get how to pass file outputs from one component to other component.Right now we are using\r\n **kfp.components.structures.InputSpec(name=<file name which was output of the previous component> )**\r\nThis shows below error\r\nTypeError: Arguments for output is not compatible with type\r\ncan someone please help on this",
"Hi @swamat, we do not document ComponentsSpec very well. I'd recommend learning https://www.kubeflow.org/docs/components/pipelines/sdk/component-development/. They are the same format in different languages (python vs yaml)",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-22T05:53:30" | "2022-03-03T03:05:36" | "2022-03-03T03:05:36" | NONE | null | ### Environment
* KFP version:1.2
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP SDK version: 1.6.0
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* All dependencies version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
### Steps to reproduce
I am currently using containerop to create pipeline functions. But I see warnings saying that it will be deprecated. Is there any equivalent kfp package which uses docker image.? I tried kfp.components.structures.ComponentsSpec but this does not get executed. Created componentsspec, saved the yaml file and tried to load using load_component_from_file inside pipeline. Though the run gets triggered, it does not execute the module
### Expected result
Expected the run to happen executing the module
### Materials and Reference
I am currently using containerop to create pipeline functions. But I see warnings saying that it will be deprecated. Is there any equivalent kfp package which uses docker image.? I tried kfp.components.structures.ComponentsSpec but this does not create container pods and am unable to see the logs as well
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5900/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5900/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5897 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5897/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5897/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5897/events | https://github.com/kubeflow/pipelines/issues/5897 | 926,709,276 | MDU6SXNzdWU5MjY3MDkyNzY= | 5,897 | [bug] outputUri prevents caching | {
"login": "boarder7395",
"id": 37314943,
"node_id": "MDQ6VXNlcjM3MzE0OTQz",
"avatar_url": "https://avatars.githubusercontent.com/u/37314943?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/boarder7395",
"html_url": "https://github.com/boarder7395",
"followers_url": "https://api.github.com/users/boarder7395/followers",
"following_url": "https://api.github.com/users/boarder7395/following{/other_user}",
"gists_url": "https://api.github.com/users/boarder7395/gists{/gist_id}",
"starred_url": "https://api.github.com/users/boarder7395/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/boarder7395/subscriptions",
"organizations_url": "https://api.github.com/users/boarder7395/orgs",
"repos_url": "https://api.github.com/users/boarder7395/repos",
"events_url": "https://api.github.com/users/boarder7395/events{/privacy}",
"received_events_url": "https://api.github.com/users/boarder7395/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi @boarder7395, we are redesigning caching, see https://github.com/kubeflow/pipelines/issues/5667.\r\nThe problem will be solved with the brand new caching mechanism that understands KFP semantics.",
"The issue you reported is expected, and we'll not fix because of v1 caching design limitations."
] | "2021-06-22T00:12:55" | "2021-06-25T01:07:42" | "2021-06-25T01:07:42" | CONTRIBUTOR | null | ### What steps did you take
Ran a pipeline with an outputUri, and ran a pipeline with an outputValue.
### What happened:
The pipeline using outputValue cached the component correctly, while the pipeline using outputUri did not cache the component.
### What did you expect to happen:
I expected both pipelines to cache.
### Environment:
KFP 1.4.1
Launched with minikube locally. Also so similar behavior with KFP on EKS.
* How do you deploy Kubeflow Pipelines (KFP)?
* KFP version:
1.4.1
* KFP SDK version:
1.6.3
### Anything else you would like to add:
I'm not sure if caching support has been added to outputUri's yet so it could be that functionality has not yet been added for outputUri's.
### Labels
/area backend
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5897/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5897/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5896 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5896/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5896/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5896/events | https://github.com/kubeflow/pipelines/issues/5896 | 926,294,028 | MDU6SXNzdWU5MjYyOTQwMjg= | 5,896 | [feature] Automatically json serialize pipeline run arguments that are of type list or dict | {
"login": "Eliacus",
"id": 25045629,
"node_id": "MDQ6VXNlcjI1MDQ1NjI5",
"avatar_url": "https://avatars.githubusercontent.com/u/25045629?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Eliacus",
"html_url": "https://github.com/Eliacus",
"followers_url": "https://api.github.com/users/Eliacus/followers",
"following_url": "https://api.github.com/users/Eliacus/following{/other_user}",
"gists_url": "https://api.github.com/users/Eliacus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Eliacus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Eliacus/subscriptions",
"organizations_url": "https://api.github.com/users/Eliacus/orgs",
"repos_url": "https://api.github.com/users/Eliacus/repos",
"events_url": "https://api.github.com/users/Eliacus/events{/privacy}",
"received_events_url": "https://api.github.com/users/Eliacus/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930476737,
"node_id": "MDU6TGFiZWw5MzA0NzY3Mzc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/help%20wanted",
"name": "help wanted",
"color": "db1203",
"default": true,
"description": "The community is welcome to contribute."
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Agree the feature would be a nice to have!\r\nWelcome contribution on this",
"Created a small fix and opened a pull request in https://github.com/kubeflow/pipelines/pull/5927"
] | "2021-06-21T14:44:53" | "2021-07-01T10:23:26" | "2021-07-01T10:23:26" | CONTRIBUTOR | null | ### Feature Area
/area sdk
### What feature would you like to see?
This feature concerns having list/dict inputs to pipelines when running them with the SDK. Right now, when starting runs with the python SDK, one must manually serialize lists to json, otherwise it will get falsely serialized and it can't be passed to components properly.
It would be nice if the `arguments` input to `client.create_run_from_pipeline_func` or the `params` input to `run_pipeline` could automatically json serialize values whos type is list/dict
### What is the use case or pain point?
The pain point is that this is a hard issue to track down, and it's unintuitive to have list/dict inputs to pipelines and running them from a python script
### Is there a workaround currently?
The current workaround is to manually use `json.dumps()` on any lists in the input argument to the run
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5896/reactions",
"total_count": 6,
"+1": 6,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5896/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5895 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5895/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5895/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5895/events | https://github.com/kubeflow/pipelines/issues/5895 | 926,250,970 | MDU6SXNzdWU5MjYyNTA5NzA= | 5,895 | [bug] Error when naming components dynamically in a recursion | {
"login": "f-wole",
"id": 40437714,
"node_id": "MDQ6VXNlcjQwNDM3NzE0",
"avatar_url": "https://avatars.githubusercontent.com/u/40437714?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/f-wole",
"html_url": "https://github.com/f-wole",
"followers_url": "https://api.github.com/users/f-wole/followers",
"following_url": "https://api.github.com/users/f-wole/following{/other_user}",
"gists_url": "https://api.github.com/users/f-wole/gists{/gist_id}",
"starred_url": "https://api.github.com/users/f-wole/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/f-wole/subscriptions",
"organizations_url": "https://api.github.com/users/f-wole/orgs",
"repos_url": "https://api.github.com/users/f-wole/repos",
"events_url": "https://api.github.com/users/f-wole/events{/privacy}",
"received_events_url": "https://api.github.com/users/f-wole/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1126834402,
"node_id": "MDU6TGFiZWwxMTI2ODM0NDAy",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/components",
"name": "area/components",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"I have the same problem. Every comment is really welcomed!! ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-21T14:02:15" | "2022-03-03T03:05:30" | "2022-03-03T03:05:30" | NONE | null | /kind bug
### What steps did you take
I inserted a cycle in my pipeline, in order to define a new component at each iteration. My pipeline looks like this (where op in my real pipeline is the training component):
```python
import kfp
from kfp import dsl, components
import kfp.components as comp
def iterator(i: int) -> int:
print('i: {}'.format(i))
yyy=1
return i+yyy
iter_op = comp.create_component_from_func(iterator,base_image='python:3.7')
def init() -> int:
return 0
init_op = comp.create_component_from_func(init,base_image='python:3.7')
@dsl.graph_component
def recursion(kk: int,xx: int):
iter = iter_op(i=xx)
Op = dsl.ContainerOp(
name="train",
image="library/bash:4.4.23",
command=["sh", "-c"],
arguments=['echo "$0"',iter.output]).after(iter).set_display_name('iteration-'+str(iter.output))
with kfp.dsl.Condition(iter.output < kk):
recursion(kk,xx=iter.output).after(Op)
@dsl.pipeline(
name="loop",
description="loop test",
)
def pp(k:int):
i0 = init_op().output
recursion(kk=k, xx=i0)
kfp.compiler.Compiler().compile(pp, __file__ + ".tar.gz")
````
### What happened:
The following image is an example of execution of the pipeline for k=3. Notice that the name of the op component is iteration-{{inputs.parameters.iterator-Output}}
### What did you expect to happen
I expected each op component to be named with the actual value of the iterator at each cycle (e.g. "iteration-1", "iteration-2", ...) instead of {{inputs.parameters.iterator-Output}}
**Environment:**
* KFP version: 1.3
* KFP SDK version: 1.3
### Anything else you would like to add:
In my real pipeline the op component will be a training component. I need to do it in this "sequential" way instead of using dsl.ParallelFor for infrastructural constraints.
### Labels
/area components
---
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5895/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5895/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5893 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5893/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5893/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5893/events | https://github.com/kubeflow/pipelines/issues/5893 | 925,586,863 | MDU6SXNzdWU5MjU1ODY4NjM= | 5,893 | [backend] column name same with reserved keyword of mysql 8.0 | {
"login": "algs",
"id": 13183602,
"node_id": "MDQ6VXNlcjEzMTgzNjAy",
"avatar_url": "https://avatars.githubusercontent.com/u/13183602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/algs",
"html_url": "https://github.com/algs",
"followers_url": "https://api.github.com/users/algs/followers",
"following_url": "https://api.github.com/users/algs/following{/other_user}",
"gists_url": "https://api.github.com/users/algs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/algs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/algs/subscriptions",
"organizations_url": "https://api.github.com/users/algs/orgs",
"repos_url": "https://api.github.com/users/algs/repos",
"events_url": "https://api.github.com/users/algs/events{/privacy}",
"received_events_url": "https://api.github.com/users/algs/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930476737,
"node_id": "MDU6TGFiZWw5MzA0NzY3Mzc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/help%20wanted",
"name": "help wanted",
"color": "db1203",
"default": true,
"description": "The community is welcome to contribute."
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | open | false | null | [] | null | [
"https://dev.mysql.com/doc/refman/8.0/en/keywords.html\r\nIt says description is a nonreserved keyword, am I missing anything?\r\n\r\nWelcome contribution if anyone figures out how to deploy KFP with mysql 8.0",
"> https://dev.mysql.com/doc/refman/8.0/en/keywords.html\r\n> It says description is a nonreserved keyword, am I missing anything?\r\n> \r\n> Welcome contribution if anyone figures out how to deploy KFP with mysql 8.0\r\n\r\nIt's been covered in [MySQL 8.0 New Keywords and Reserved Words](https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-new-in-current-series)",
"I have tried it out with MySQL 8 and [got it working](https://github.com/NikeNano/pipelines/tree/nikenano/mysql8), some [very minor things](https://stackoverflow.com/questions/49945091/latest-mysql-not-coming-up-in-kubernetes/49952285) needed to change. I can make a PR with it, could you point me to how we build the images for gcr @Bobgy?\r\n\r\nAs @Bobgy points out `description` is a `non-reserved` keyword:\r\n\r\n```\r\nDESCRIPTION; added in 8.0.4 (nonreserved)\r\n```\r\n\r\nand \r\n\r\n```\r\nNonreserved keywords are permitted as identifiers without quoting. Reserved words are permitted as identifiers if you quote them as ...\r\n```\r\n\r\nSource: https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-new-in-current-series. Maybe you could try to check out the branch @algs and see if it work for you? Let me know if you have any questions so I can help out. \r\n\r\n\r\n",
"Access to gcr is restricted to admins. I can help you upload : )",
"FWIW, I have successfully deployed KFP 1.5.0 on GKE with MySQL 8 running in CloudSQL. \r\n\r\nI haven't done much testing yet but was able to successfully run some pipelines and store the associated data.",
"> FWIW, I have successfully deployed KFP 1.5.0 on GKE with MySQL 8 running in CloudSQL.\r\n> \r\n> I haven't done much testing yet but was able to successfully run some pipelines and store the associated data.\r\n\r\nAwesome, let me know if you get some issues @sidpalas! ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"
] | "2021-06-20T12:18:44" | "2022-03-03T02:05:38" | null | CONTRIBUTOR | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
* create table in mysql and deploy the KFP services
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version:
* 1.5
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
### Steps to reproduce
When creating table in mysql 8.0, it would report fail because there are columns name `Description` in tables `experiments`, `jobs`, `pipelines`, `run_details`, which is the reserved keyword of mysql
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
### Expected result
Creating tables without error.
Shall we use `Descriptions` as the columns' name?
<!-- What should the correct behavior be? -->
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
cc @Jeffwan | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5893/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5893/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5885 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5885/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5885/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5885/events | https://github.com/kubeflow/pipelines/issues/5885 | 924,276,957 | MDU6SXNzdWU5MjQyNzY5NTc= | 5,885 | [components]: TrainingPipeline Custom Task accepting multiple datasets defaulting to incorrect dataset type | {
"login": "SinaChavoshi",
"id": 20114005,
"node_id": "MDQ6VXNlcjIwMTE0MDA1",
"avatar_url": "https://avatars.githubusercontent.com/u/20114005?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SinaChavoshi",
"html_url": "https://github.com/SinaChavoshi",
"followers_url": "https://api.github.com/users/SinaChavoshi/followers",
"following_url": "https://api.github.com/users/SinaChavoshi/following{/other_user}",
"gists_url": "https://api.github.com/users/SinaChavoshi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SinaChavoshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SinaChavoshi/subscriptions",
"organizations_url": "https://api.github.com/users/SinaChavoshi/orgs",
"repos_url": "https://api.github.com/users/SinaChavoshi/repos",
"events_url": "https://api.github.com/users/SinaChavoshi/events{/privacy}",
"received_events_url": "https://api.github.com/users/SinaChavoshi/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1126834402,
"node_id": "MDU6TGFiZWwxMTI2ODM0NDAy",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/components",
"name": "area/components",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi team, any update on this one? "
] | "2021-06-17T19:52:02" | "2021-07-02T19:41:49" | "2021-07-02T19:41:49" | COLLABORATOR | null | Originally raised in [stackoverflow - #68025813](https://stackoverflow.com/questions/67999255/error-tabular-dataset-treated-as-image-dataset-vertex-ai-pipelines-custom-tra/68025813#68025813)
## Environment
python 3.7.3
kfp==1.6.2
kfp-pipeline-spec==0.1.7
kfp-server-api==1.6.0
google-cloud-pipeline-components==0.1.1
## Error message
```
ValueError: ImageDataset class can not be used to retrieve dataset resource projects/nnnnnnnnnnnn/locations/us-central1/datasets/3781554739456507904, check the dataset type
f"{self.__class__.__name__} class can not be used to retrieve "
File "/opt/python3.7/lib/python3.7/site-packages/google/cloud/aiplatform/datasets/dataset.py", line 100, in _validate_metadata_schema_uri
self._validate_metadata_schema_uri()
File "/opt/python3.7/lib/python3.7/site-packages/google/cloud/aiplatform/datasets/dataset.py", line 82, in __init__
return annotation_type(value)
File "/opt/python3.7/lib/python3.7/site-packages/google_cloud_pipeline_components/aiplatform/remote_runner.py", line 176, in cast
value = cast(value, param_type)
File "/opt/python3.7/lib/python3.7/site-packages/google_cloud_pipeline_components/aiplatform/remote_runner.py", line 205, in prepare_parameters
prepare_parameters(serialized_args[METHOD_KEY], method, is_init=False)
File "/opt/python3.7/lib/python3.7/site-packages/google_cloud_pipeline_components/aiplatform/remote_runner.py", line 236, in runner
print(runner(args.cls_name, args.method_name, executor_input, kwargs))
File "/opt/python3.7/lib/python3.7/site-packages/google_cloud_pipeline_components/aiplatform/remote_runner.py", line 280, in main
main()
File "/opt/python3.7/lib/python3.7/site-packages/google_cloud_pipeline_components/aiplatform/remote_runner.py", line 284, in <module>
exec(code, run_globals)
File "/opt/python3.7/lib/python3.7/runpy.py", line 85, in _run_code
"__main__", mod_spec)
File "/opt/python3.7/lib/python3.7/runpy.py", line 193, in _run_module_as_main
Traceback (most recent call last):
```
## Sample pipeline:
```python
import datetime
from kfp.v2 import dsl, compiler
from kfp.v2.google.client import AIPlatformClient
import google_cloud_pipeline_components.aiplatform as gcc_ai
PROJECT = "my-project"
PIPELINE_NAME = "test-pipeline"
PIPELINE_ROOT_PATH = f"gs://test-pipeline-20210525/{PIPELINE_NAME}"
@dsl.pipeline(
name=PIPELINE_NAME,
pipeline_root=PIPELINE_ROOT_PATH
)
def test_pipeline(
display_name: str=f"{PIPELINE_NAME}-2021MMDD-nn"
):
dataset_create_op = gcc_ai.TabularDatasetCreateOp(
project=PROJECT, display_name=display_name,
gcs_source="gs://used_apartment/datasource/train.csv"
)
training_job_run_op = gcc_ai.CustomContainerTrainingJobRunOp(
project=PROJECT, display_name=display_name,
container_uri="us-central1-docker.pkg.dev/my-project/dataops-rc2021/custom-train:latest",
staging_bucket="vertex_ai_staging_rc2021",
base_output_dir="gs://used_apartment/cstm_img_scrf/artifact",
model_serving_container_image_uri="us-central1-docker.pkg.dev/my-project/dataops-rc2021/custom-pred:latest",
model_serving_container_predict_route="/",
model_serving_container_health_route="/health",
model_serving_container_ports=[8080],
training_fraction_split=0.8,
validation_fraction_split=0.1,
test_fraction_split=0.1,
dataset=dataset_create_op.outputs["dataset"]
)
``` | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5885/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5885/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5882 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5882/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5882/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5882/events | https://github.com/kubeflow/pipelines/issues/5882 | 923,809,927 | MDU6SXNzdWU5MjM4MDk5Mjc= | 5,882 | [launcher] make debugging launcher easier | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"I'm now leaning towards turn on warning level logging by default.\r\nDuring developing, developers can build a launcher image with default changed to INFO level. This sounds like a good enough stopgap solution."
] | "2021-06-17T11:23:50" | "2021-06-21T01:55:16" | "2021-06-21T01:55:16" | CONTRIBUTOR | null | KFP v2 compatible launcher doesn't log anything unless an error occurs, therefore when there's an launcher logic error. It's very hard to debug what actually happened.
Propose inventing some mechanism to support this use-case.
## Option 1 - add basic logging which is turned on by default
Pros:
* we can always find some information in logs
Cons:
* confusing to users, because launcher log is now mixing with user component logs
## Option 2 - add a config that can turn on verbose launcher logging
Pros: minimal confusion usually
Cons: the complexity to design the config switch & efforts to turn it on & rerun a pipeline is huge
What do you think? Are there better options? | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5882/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5882/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5881 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5881/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5881/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5881/events | https://github.com/kubeflow/pipelines/issues/5881 | 923,725,502 | MDU6SXNzdWU5MjM3MjU1MDI= | 5,881 | [feature] Support specifying a pipline version when uploading a new pipeline | {
"login": "jmendesky",
"id": 56542576,
"node_id": "MDQ6VXNlcjU2NTQyNTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/56542576?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jmendesky",
"html_url": "https://github.com/jmendesky",
"followers_url": "https://api.github.com/users/jmendesky/followers",
"following_url": "https://api.github.com/users/jmendesky/following{/other_user}",
"gists_url": "https://api.github.com/users/jmendesky/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jmendesky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jmendesky/subscriptions",
"organizations_url": "https://api.github.com/users/jmendesky/orgs",
"repos_url": "https://api.github.com/users/jmendesky/repos",
"events_url": "https://api.github.com/users/jmendesky/events{/privacy}",
"received_events_url": "https://api.github.com/users/jmendesky/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"option 1: upload version api can accept pipeline parameter\r\noption 2: combine upload pipeline and upload version in one api, which means user can specify pipeline and version at the same time.",
"> option 1: upload version api can accept pipeline parameter\r\n\r\nIt already accepts the pipeline name or id as a parameter. Do you mean that this could be optional so that the pipeline would be created if not present?\r\n\r\n> option 2: combine upload pipeline and upload version in one api, which means user can specify pipeline and version at the same time.\r\n\r\nI think something like this makes sense. Specifying the version when uploading would be of great benefit. We could still keep the default option of setting the version to the pipeline name if no version is specified.\r\n",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n",
"any news on this?"
] | "2021-06-17T09:54:05" | "2022-03-04T08:07:00" | "2022-03-03T03:05:29" | NONE | null | ### Feature Area
/area backend
/area sdk
### What feature would you like to see?
Currently, when uploading a new pipeline, no version can be specified and the name of the pipeline is used to create an initial version. Uploading a pipeline version without first creating a pipeline by uploading that initial version will fail. This is not intuitive and breaks automation or requires workarounds like first uploading the initial version and then creating the proper version.
### What is the use case or pain point?
We are currently building automation and continuous deployment around our ML infrastructure. As part of this, we want all of our pipelines to be versioned so that code changes can be tracked consistently. This should also be true when creating a new pipeline with the first version.
### Is there a workaround currently?
upload pipeline ( => version == name)
upload version (=> version == 'abcdef')
delete version 'name'
---
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5881/reactions",
"total_count": 5,
"+1": 5,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5881/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5880 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5880/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5880/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5880/events | https://github.com/kubeflow/pipelines/issues/5880 | 923,712,274 | MDU6SXNzdWU5MjM3MTIyNzQ= | 5,880 | [sdk] v2 python component does not support parameter default values | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign @chensun "
] | "2021-06-17T09:40:43" | "2021-06-23T20:25:20" | "2021-06-23T20:25:20" | CONTRIBUTOR | null | Reproduction: see PR https://github.com/kubeflow/pipelines/pull/5879 | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5880/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5880/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5878 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5878/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5878/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5878/events | https://github.com/kubeflow/pipelines/issues/5878 | 923,699,200 | MDU6SXNzdWU5MjM2OTkyMDA= | 5,878 | [backend] Retry run failed.: InternalServerError: Workflow cannot be retried with node ... in Omitted phase: workflow cannot be retried | {
"login": "skogsbrus",
"id": 17073827,
"node_id": "MDQ6VXNlcjE3MDczODI3",
"avatar_url": "https://avatars.githubusercontent.com/u/17073827?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skogsbrus",
"html_url": "https://github.com/skogsbrus",
"followers_url": "https://api.github.com/users/skogsbrus/followers",
"following_url": "https://api.github.com/users/skogsbrus/following{/other_user}",
"gists_url": "https://api.github.com/users/skogsbrus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skogsbrus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skogsbrus/subscriptions",
"organizations_url": "https://api.github.com/users/skogsbrus/orgs",
"repos_url": "https://api.github.com/users/skogsbrus/repos",
"events_url": "https://api.github.com/users/skogsbrus/events{/privacy}",
"received_events_url": "https://api.github.com/users/skogsbrus/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"fixed by #5738 . You need to wait for the next KFP release. ",
"Ok, thanks! ",
"Any idea when this fix will land in a 1.6 release?"
] | "2021-06-17T09:27:46" | "2021-06-25T14:42:46" | "2021-06-18T00:47:04" | NONE | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)? KF 1.3 Manifests release, on premises
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version: 1.5.0
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
```
$ pip list | grep kfp
kfp 1.6.2
kfp-pipeline-spec 0.1.7
kfp-server-api 1.5.0
```
### Steps to reproduce
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
1. Run a pipeline with a failing component
2. Retry the run
```
Failed to retry run: 10ff9a33-bc37-4224-914a-8278036a163c with error: "{"error":"Retry run failed.: InternalServerError: Workflow cannot be retried with node pipeline-vlkt4-400844542 in Omitted phase: workflow cannot be retried","code":13,"message":"Retry run failed.: InternalServerError: Workflow cannot be retried with node pipeline-vlkt4-400844542 in Omitted phase: workflow cannot be retried","details":[{"@type":"type.googleapis.com/api.Error","error_message":"Internal Server Error","error_details":"Retry run failed.: InternalServerError: Workflow cannot be retried with node pipeline-vlkt4-400844542 in Omitted phase: workflow cannot be retried"}]}"
```
### Expected result
A successful retry of the run, starting off from the failed component.
<!-- What should the correct behavior be? -->
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
I've found this Argo bug.
https://github.com/argoproj/argo-workflows/issues/3524
But unclear if that's the root cause. Retries worked previously when I ran KF 1.1 on premises, but since upgrading to 1.3 they fail with this error.
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5878/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5878/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5877 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5877/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5877/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5877/events | https://github.com/kubeflow/pipelines/issues/5877 | 923,642,014 | MDU6SXNzdWU5MjM2NDIwMTQ= | 5,877 | [sdk] Uploading a new pipeline and specifying a version sets the wrong version number | {
"login": "jmendesky",
"id": 56542576,
"node_id": "MDQ6VXNlcjU2NTQyNTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/56542576?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jmendesky",
"html_url": "https://github.com/jmendesky",
"followers_url": "https://api.github.com/users/jmendesky/followers",
"following_url": "https://api.github.com/users/jmendesky/following{/other_user}",
"gists_url": "https://api.github.com/users/jmendesky/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jmendesky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jmendesky/subscriptions",
"organizations_url": "https://api.github.com/users/jmendesky/orgs",
"repos_url": "https://api.github.com/users/jmendesky/repos",
"events_url": "https://api.github.com/users/jmendesky/events{/privacy}",
"received_events_url": "https://api.github.com/users/jmendesky/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | "2021-06-17T08:35:19" | "2021-06-17T09:46:39" | "2021-06-17T09:46:39" | NONE | null | ### Environment
* KFP version:
1.0.4
* KFP SDK version:
1.3.0
### Steps to reproduce
```
client.pipeline_uploads.upload_pipeline_version(
pipeline_file, name="my_pipeline", pipelineid="0.0.1"
)
```
will create a new pipeline with a single version of "my_pipeline"
### Expected result
A new Pipeline with an initial version of "0.0.1"
### Materials and Reference
I believe that this, at the moment, is the documented behaviour. I would argue, however, that this is unintuitive and breaks automation (or requires workarounds)
---
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5877/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5877/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5875 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5875/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5875/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5875/events | https://github.com/kubeflow/pipelines/issues/5875 | 923,426,227 | MDU6SXNzdWU5MjM0MjYyMjc= | 5,875 | [sdk] refer to doc when type mismatch error occurs | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-06-17T04:39:36" | "2021-07-20T00:14:18" | "2021-07-20T00:14:18" | CONTRIBUTOR | null | It'll be ideal to refer to documentation https://www.kubeflow.org/docs/components/pipelines/sdk/v2/v2-compatibility/#building-pipelines-using-the-kubeflow-pipelines-sdk-v2, when we detect a type mismatch error.
Because the extra context in the doc helps users understand how to fix the issue. | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5875/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5875/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5872 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5872/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5872/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5872/events | https://github.com/kubeflow/pipelines/issues/5872 | 922,814,192 | MDU6SXNzdWU5MjI4MTQxOTI= | 5,872 | Metadata writer component error | {
"login": "santoshmarepally",
"id": 68669422,
"node_id": "MDQ6VXNlcjY4NjY5NDIy",
"avatar_url": "https://avatars.githubusercontent.com/u/68669422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/santoshmarepally",
"html_url": "https://github.com/santoshmarepally",
"followers_url": "https://api.github.com/users/santoshmarepally/followers",
"following_url": "https://api.github.com/users/santoshmarepally/following{/other_user}",
"gists_url": "https://api.github.com/users/santoshmarepally/gists{/gist_id}",
"starred_url": "https://api.github.com/users/santoshmarepally/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/santoshmarepally/subscriptions",
"organizations_url": "https://api.github.com/users/santoshmarepally/orgs",
"repos_url": "https://api.github.com/users/santoshmarepally/repos",
"events_url": "https://api.github.com/users/santoshmarepally/events{/privacy}",
"received_events_url": "https://api.github.com/users/santoshmarepally/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930476737,
"node_id": "MDU6TGFiZWw5MzA0NzY3Mzc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/help%20wanted",
"name": "help wanted",
"color": "db1203",
"default": true,
"description": "The community is welcome to contribute."
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-16T16:12:22" | "2022-03-03T03:05:27" | "2022-03-03T03:05:27" | NONE | null | There is an error in metadata writer component that seems to be not propagated to the application. When I run describe on application, it is coming back with "NoError".
### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version:
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
kfp 1.4.0
kfp-pipeline-spec 0.1.7
kfp-server-api 1 .5.0
### Steps to reproduce
**kubectl apply -k ./**. (this is creating issues)
**Error from the logs:**
2021-06-16T14:07:48.349192561Z2021-06-16 14:07:48.348369: F ml_metadata/metadata_store/metadata_store_server_main.cc:226] Non-OK-status: status status: Internal: mysql_real_connect failed: errno: 0, error: MetadataStore cannot be created with the given connection config.
(this is failing because of metadata component issues from above command)
**kubectl wait applications/pipeline -n kubeflow --for condition=Ready --timeout=1800s**
error: timed out waiting for the condition on applications/pipeline
**kubectl get applications -n kubeflow**
NAME AGE
pipeline 8d
**kubectl describe applications -n kubeflow**
Conditions:
Last Transition Time: 2021-06-16T04:18:53Z
Last Update Time: 2021-06-16T04:18:53Z
Message: some components not ready
Reason: ComponentsNotReady
Status: False
Type: Ready
Last Transition Time: 2021-06-07T19:19:14Z
Last Update Time: 2021-06-07T19:19:14Z
Message: No error seen
Reason: NoError
Status: False
Type: Error
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
### Expected result
this should run without errors
**kubectl wait applications/pipeline -n kubeflow --for condition=Ready --timeout=1800s**
<!-- What should the correct behavior be? -->
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5872/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5872/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5868 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5868/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5868/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5868/events | https://github.com/kubeflow/pipelines/issues/5868 | 922,652,103 | MDU6SXNzdWU5MjI2NTIxMDM= | 5,868 | [feature] Output artifacts from AI platform jobs and have them cached. | {
"login": "zygm0nt",
"id": 179461,
"node_id": "MDQ6VXNlcjE3OTQ2MQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/179461?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zygm0nt",
"html_url": "https://github.com/zygm0nt",
"followers_url": "https://api.github.com/users/zygm0nt/followers",
"following_url": "https://api.github.com/users/zygm0nt/following{/other_user}",
"gists_url": "https://api.github.com/users/zygm0nt/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zygm0nt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zygm0nt/subscriptions",
"organizations_url": "https://api.github.com/users/zygm0nt/orgs",
"repos_url": "https://api.github.com/users/zygm0nt/repos",
"events_url": "https://api.github.com/users/zygm0nt/events{/privacy}",
"received_events_url": "https://api.github.com/users/zygm0nt/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1260031624,
"node_id": "MDU6TGFiZWwxMjYwMDMxNjI0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/samples",
"name": "area/samples",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Can you help share your pipeline? In addition, KFP supports cache https://www.kubeflow.org/docs/components/pipelines/caching/",
"Hi, sorry for late reply.\r\n\r\nSo here is an illustrative example of my pipeline's behavior:\r\n\r\n```\r\nimport kfp\r\nfrom kfp import dsl\r\nfrom kfp.dsl.types import GCSPath\r\n\r\nfrom components.gcp.ml_engine_train import ml_engine_train_task_factory # this is our copy of https://github.com/kubeflow/pipelines/tree/master/components/gcp/container/component_sdk/python/kfp_component/google/ml_engine\r\n\r\ndef ml_job(task_id: str,\r\n endpoint: str,\r\n args: List[Tuple[str, Any]],\r\n master_type: str,\r\n gpu_type: Optional[str] = None\r\n):\r\n return ml_engine_train_task_factory(\r\n ...\r\n ).set_display_name(task_id.replace(\"_\", \" \"))\r\n\r\n\r\n@dsl.pipeline(\r\n name=\"Content vectors training pipeline\",\r\n description=\"Content vectors training pipeline\",\r\n)\r\ndef pipeline(\r\n input_path: GCSPath(),\r\n output_path: GCSPath(),\r\n output_path2: GCSPath(),\r\n):\r\n\r\n infer_op = ml_job(\r\n task_id=\"infer\",\r\n endpoint=\"make\",\r\n args=[\r\n (\"ifpath\", input_path),\r\n (\"ofpath\", output_path),\r\n ],\r\n master_type=\"n1-highmem-16\",\r\n )\r\n\r\n infer2_op = ml_job(\r\n task_id=\"infer\",\r\n endpoint=\"make\",\r\n args=[\r\n (\"ifpath\", output_path),\r\n (\"ofpath\", output_path2),\r\n ],\r\n master_type=\"n1-highmem-16\",\r\n ).after(infer_op)\r\n```\r\n\r\nSo, when I iterate over this pipeline, be it I need to change somewhat the pipeline internal parameters, or I have a bug along the pipeline, in the job itself, I always need to rerun the whole pipeline. \r\nWhat I'd like to do is:\r\n* job `infer_op` passes, but `infer2_op` fails due to some error\r\n* if I rerun the pipeline with the same parameters, then `infer_op` should find out that it already has the artifact (in this case `output_path`), and to silently skip `infer_op` (or mark as succeded), and run just `infer2_op`\r\n\r\nSo far I don't see how this could be done without a lot of manual code around each and every component. \r\nAny advice about to handle that kind of situation?",
"Hi @zygm0nt, to utilize cache, your pipeline / component inputs need to be the same each run.\r\nCan you confirm?\r\n\r\nAlso, which Kubeflow distribution did you install? I've heard some that do not enable the caching feature.",
"@Bobgy input params are the same in this case. I'm using the distribution provided by Google, deployable in GCP as AI Pipelines.\r\n\r\nBut this behaviour is about caching already run jobs, can this be extended to marking as finished jobs that have their outputs already calculated? Suppose I'm deploying a somewhat new pipeline, that has some steps borrowed from already running pipeline. There are some artifacts on GCS calculated by that previous pipeline, and I'd like the new pipeline to skip the steps due to already existing data.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-16T13:59:20" | "2022-03-03T03:05:37" | "2022-03-03T03:05:37" | NONE | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
/area backend
/area sdk
/area samples
<!-- /area components -->
### What feature would you like to see?
Is it possible to cache steps in a pipeline if the output already exists?
### What is the use case or pain point?
My scenario here is that I'm running a bunch of jobs with https://github.com/kubeflow/pipelines/tree/master/components/gcp/container/component_sdk/python/kfp_component/google/ml_engine (with Docker images) and if working on a specific pipeline need to constantly recalculate all the steps. This could be somewhat mitigated by creating a very small subset of the target data, but I'm wondering if there's a better approach here.
I've found some indications that caching could solve this issue, but I don't see the connection here. Especially since AI platform jobs currently do not emit any artefacts.
### Is there a workaround currently?
The workaround I have for this right now is creating dummy jobs, that are fast to complete, but this is quite complex approach.
Other one would be to have a relatively small subset of my data and iterate on that.
Both of theses approaches still need to rerun the whole pipeline over and over again.
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5868/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5868/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5867 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5867/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5867/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5867/events | https://github.com/kubeflow/pipelines/issues/5867 | 922,529,897 | MDU6SXNzdWU5MjI1Mjk4OTc= | 5,867 | PVC used from cache thereby causing issues when pvc is manually deleted. | {
"login": "divyadilip91",
"id": 57779683,
"node_id": "MDQ6VXNlcjU3Nzc5Njgz",
"avatar_url": "https://avatars.githubusercontent.com/u/57779683?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/divyadilip91",
"html_url": "https://github.com/divyadilip91",
"followers_url": "https://api.github.com/users/divyadilip91/followers",
"following_url": "https://api.github.com/users/divyadilip91/following{/other_user}",
"gists_url": "https://api.github.com/users/divyadilip91/gists{/gist_id}",
"starred_url": "https://api.github.com/users/divyadilip91/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/divyadilip91/subscriptions",
"organizations_url": "https://api.github.com/users/divyadilip91/orgs",
"repos_url": "https://api.github.com/users/divyadilip91/repos",
"events_url": "https://api.github.com/users/divyadilip91/events{/privacy}",
"received_events_url": "https://api.github.com/users/divyadilip91/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"https://github.com/kubeflow/pipelines/issues/1327\r\n",
"I think this is the same issue as https://github.com/kubeflow/pipelines/issues/5844",
"@skogsbrus Yes it is. Does anyone know if this issue has been solved in the latest kubeflow \r\nversion which is 1.6.",
"Don't know, but I suggest you close this and give a :+1: to the other issue.",
"Hi, as mentioned in this comment: https://github.com/kubeflow/pipelines/issues/5844#issuecomment-863110659 this issue is duplicate of https://github.com/kubeflow/pipelines/issues/5257 and https://github.com/kubeflow/pipelines/issues/5844.\r\n\r\nI also suggest we close this one in favor of #5257.",
"Closing the issue- Redirected to #5257 and #5844"
] | "2021-06-16T12:10:02" | "2021-06-17T10:39:16" | "2021-06-17T10:39:16" | NONE | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
I deployed kubeflow in GCP using AI Platform
* KFP version:
1.4.1
* KFP SDK version:
1.4.1
### Steps to reproduce
1. Create a pipeline that first creates a pvc that uses a dynamicaly generated disk of size 10Gi which is then used by subsequent containerops.
2. After successful execution , I manually delete the job pods and pvc that automatically deletes the dynamically generated disk
3. Next time when I schedule a pipeline run, I changed my pvcname but not size. I notice that the pod uses the deleted old pvc and the subsequent container ops shows the below error
**_This step is in Pending state with this message: Unschedulable: persistentvolumeclaim "{{tasks.new-disk.outputs.parameters.new-disk-name}}" not found_**
This is so frustrating since I have to change the disk size each time to create a new pipeline.
How to avoid the pvc to be used from cache.
### Expected result
A new pvc needs to get created of same size 10Gi instead of the old pvc
### Materials and Reference
https://github.com/kubeflow/pipelines/blob/1.4.1/samples/contrib/volume_ops/volumeop_sequential.py
A similar pipeline used.
Kindly help regarding this issue as soon as possible.
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5867/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5867/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5866 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5866/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5866/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5866/events | https://github.com/kubeflow/pipelines/issues/5866 | 922,312,166 | MDU6SXNzdWU5MjIzMTIxNjY= | 5,866 | [backend] Dockerfile fails build | {
"login": "mishraprafful",
"id": 32913433,
"node_id": "MDQ6VXNlcjMyOTEzNDMz",
"avatar_url": "https://avatars.githubusercontent.com/u/32913433?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mishraprafful",
"html_url": "https://github.com/mishraprafful",
"followers_url": "https://api.github.com/users/mishraprafful/followers",
"following_url": "https://api.github.com/users/mishraprafful/following{/other_user}",
"gists_url": "https://api.github.com/users/mishraprafful/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mishraprafful/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mishraprafful/subscriptions",
"organizations_url": "https://api.github.com/users/mishraprafful/orgs",
"repos_url": "https://api.github.com/users/mishraprafful/repos",
"events_url": "https://api.github.com/users/mishraprafful/events{/privacy}",
"received_events_url": "https://api.github.com/users/mishraprafful/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Did you build under root directory or under backend directory? You need to build under root directory",
"Thanks @capri-xiyue. This was solved with your suggestions and a few other things we were doing wrong. 😄 "
] | "2021-06-16T08:36:35" | "2021-06-21T10:06:42" | "2021-06-21T10:06:42" | NONE | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
Not yet deployed
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version: Release v1.6.0
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version: None
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
### Steps to reproduce
* Docker build `backend/dockerfile` fails with the following trail logs
```bash
Setting up llvm-3.8 (1:3.8.1-24) ...
Setting up cmake (3.7.2-1) ...
Setting up llvm-3.8-dev (1:3.8.1-24) ...
Setting up clang-3.8 (1:3.8.1-24) ...
Setting up clang (1:3.8-36) ...
Processing triggers for sgml-base (1.29) ...
Processing triggers for libc-bin (2.24-11+deb9u4) ...
Removing intermediate container b0ebf531b1ac
---> a76cd53b1770
Step 3/36 : WORKDIR /go/src/github.com/kubeflow/pipelines
---> Running in 1e93112fe0a1
Removing intermediate container 1e93112fe0a1
---> d50ce7ad7ae0
Step 4/36 : COPY . .
---> 730bd4c847e8
Step 5/36 : RUN go mod vendor
---> Running in d94a1eeedc7f
268
go: cannot find main module; see 'go help modules'
```
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
### Expected result
* `backend` successfully built as a docker image
<!-- What should the correct behavior be? -->
### Materials and Reference
Trying to build the backend service as a docker image, but it fails to build.
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5866/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5866/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5858 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5858/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5858/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5858/events | https://github.com/kubeflow/pipelines/issues/5858 | 920,826,556 | MDU6SXNzdWU5MjA4MjY1NTY= | 5,858 | [sdk] dsl.ExitHandler error: bad replacement for`{{workflow.failures}}` placeholder results in SyntaxError | {
"login": "jli",
"id": 133466,
"node_id": "MDQ6VXNlcjEzMzQ2Ng==",
"avatar_url": "https://avatars.githubusercontent.com/u/133466?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jli",
"html_url": "https://github.com/jli",
"followers_url": "https://api.github.com/users/jli/followers",
"following_url": "https://api.github.com/users/jli/following{/other_user}",
"gists_url": "https://api.github.com/users/jli/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jli/subscriptions",
"organizations_url": "https://api.github.com/users/jli/orgs",
"repos_url": "https://api.github.com/users/jli/repos",
"events_url": "https://api.github.com/users/jli/events{/privacy}",
"received_events_url": "https://api.github.com/users/jli/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | open | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Hi team, any progress on this issue?\r\n\r\nMy team is use KFP in production, and we want to add monitoring/alerting to our production pipelines so we know when things fail. The KFP ExitHandler seems like the perfect tool for this, but we cannot use it due to this bug.\r\n\r\nAny hints about workarounds would also be appreciated. It seems like it's most likely an underlying Argo problem, right? Will this get fixed with a more recent Argo or KFP release?",
"FWIW, I switched to using a yaml-based component definition instead of `create_component_from_func`, and that seems to have fixed the issue with the parse error.\r\n\r\nIt still seems that the `workflow.failures` is string-escaped twice (as if the value is from `str(json.dumps(failure_object))` instead of just `json_dumps.(failure_object)`, so I had to undo that extra escaping with `ast.literal_eval`.\r\n\r\nSo, I'm guessing that my original example would have worked if i used single quotes instead of double quotes around `{{workflow.failures}}` in my function definition.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"
] | "2021-06-14T22:37:13" | "2022-03-02T21:05:26" | null | CONTRIBUTOR | null | I ran into this issue while trying to use ExitHandler for workflow completion/failure notifications, see https://github.com/kubeflow/pipelines/issues/3516 for context.
### Environment
* KFP version: 1.4.1
* KFP SDK version: 1.4.0
* All dependencies version:
* kfp 1.4.0
* kfp-pipeline-spec 0.1.7
* kfp-server-api 1.5.0
### Steps to reproduce
- Try to use `dsl.ExitHandler` with a function that uses workflow variable `{{workflow.failures}}`. (See sample pipeline code at the bottom of this issue.)
- Launch pipeline run on KFP.
- Get error `SyntaxError: invalid syntax`.
My exit handler component uses a bunch of other workflow variables, and all the other ones seem to work. When I remove `{{workflow.failures}}`, my exit handler runs correctly.
When I change my example task to fail so that the `workflow.failures` variable is populated, I get a different SyntaxError (see below for full details).
### Materials and Reference
Here's the full pipeline that results in the syntax error:
```python
from kfp import dsl
import kfp.components as comp
@dsl.pipeline(name="Pipeline for testing exit handler")
def exit_handler_test_pipeline():
@comp.create_component_from_func
def exit_handler_component(
name: str = "{{workflow.name}}",
namespace: str = "{{workflow.namespace}}",
uid: str = "{{workflow.uid}}",
creationTimestamp: str = "{{workflow.creationTimestamp}}",
failures: str = "{{workflow.failures}}",
status: str = "{{workflow.status}}",
):
print(f"my test exit handler!")
print(f"name: {name}")
print(f"namespace: {namespace}")
print(f"uid: {uid}")
print(f"creationTimestamp: {creationTimestamp}")
print(f"failures: {failures}")
print(f"status: {status}")
@comp.create_component_from_func
def some_example_component():
print("do some task")
exit_handler_op = exit_handler_component()
with dsl.ExitHandler(exit_handler_op):
_example_task = some_example_component()
```
I get the following error in the exit handler task logs on KFP:
```python
File "/tmp/tmp.jPJXqdBDsc", line 6
failures = ""null"",
^
SyntaxError: invalid syntax
```
Here's a screenshot of the error from the run on KFP:
---
**Similar SyntaxError when the pipeline has a task failure**
I also tested the exit handler when there are task failures by changing `some_example_component` to this:
```python
@comp.create_component_from_func
def some_example_component():
print("do some task")
raise ValueError("cause task failure")
```
This results in `workflow.failures` being populated with some JSON, but this still causes a SyntaxError:
```python
File "/tmp/tmp.W7x1yGRiSo", line 6
failures = ""[{\"displayName\":\"some-example-component\",\"message\":\"failed with exit code 1\",\"templateName\":\"some-example-component\",\"phase\":\"Failed\",\"podName\":\"pipeline-for-testing-exit-handler-pcm5g-1464849803\",\"finishedAt\":\"2021-06-14T22:27:44Z\"},{\"displayName\":\"exit-handler-1\",\"message\":\"\",\"templateName\":\"exit-handler-1\",\"phase\":\"Failed\",\"podName\":\"pipeline-for-testing-exit-handler-pcm5g-655720480\",\"finishedAt\":\"2021-06-14T22:27:45Z\"},{\"displayName\":\"pipeline-for-testing-exit-handler-pcm5g\",\"message\":\"\",\"templateName\":\"pipeline-for-testing-exit-handler\",\"phase\":\"Failed\",\"podName\":\"pipeline-for-testing-exit-handler-pcm5g\",\"finishedAt\":\"2021-06-14T22:27:45Z\"}]"",
^
SyntaxError: unexpected character after line continuation character
```
It looks like the underlying problem is the same: KFP (or maybe it's Argo?) is inserting extra double quotes when replacing `"{{workflow.failures}}"`, which is causing a syntax error in Python.
I also tried annotating the `faillures` argument with `Optional[str]` instead of `str`, but the result seems to be the same.
Is there any way to work around this? Is there a way to access these workflow variables via Python code rather than having KFP/Argo replacing these placeholder strings?
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5858/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5858/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5855 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5855/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5855/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5855/events | https://github.com/kubeflow/pipelines/issues/5855 | 920,137,821 | MDU6SXNzdWU5MjAxMzc4MjE= | 5,855 | Unable to select the instance in kubeflow experiment | {
"login": "swamat",
"id": 53515128,
"node_id": "MDQ6VXNlcjUzNTE1MTI4",
"avatar_url": "https://avatars.githubusercontent.com/u/53515128?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/swamat",
"html_url": "https://github.com/swamat",
"followers_url": "https://api.github.com/users/swamat/followers",
"following_url": "https://api.github.com/users/swamat/following{/other_user}",
"gists_url": "https://api.github.com/users/swamat/gists{/gist_id}",
"starred_url": "https://api.github.com/users/swamat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/swamat/subscriptions",
"organizations_url": "https://api.github.com/users/swamat/orgs",
"repos_url": "https://api.github.com/users/swamat/repos",
"events_url": "https://api.github.com/users/swamat/events{/privacy}",
"received_events_url": "https://api.github.com/users/swamat/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"You can use https://kubeflow-pipelines.readthedocs.io/en/stable/source/kfp.dsl.html?highlight=node#kfp.dsl.PipelineConf.set_default_pod_node_selector to add a constraint for nodeSelector for a pipeline.\r\nYou can use https://kubeflow-pipelines.readthedocs.io/en/stable/source/kfp.dsl.html?highlight=node#kfp.dsl.Sidecar.set_memory_limit to set the memory limit",
"Feel free to reopen the issue if you have further questions.",
"@capri-xiyue Thank you "
] | "2021-06-14T08:00:05" | "2021-06-24T11:30:50" | "2021-06-18T01:01:47" | NONE | null | ### What steps did you take
I have installed kubeflow 1.12 inAWS environment. Its running on EKS cluster with one gpu node and one cpu node
### What happened:
When am creating the kfp pipeline and creating run am unable to select the node(gpu/cpu) on which it can run
### What did you expect to happen:
I can select the node on which it can run
### Environment:
AWS
<!-- Please fill in those that seem relevant. -->
* How do you deploy Kubeflow Pipelines (KFP)?
https://www.kubeflow.org/docs/distributions/aws/deploy/install-kubeflow/
* KFP version: 1.12
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version: 1.6.0
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5855/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5855/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5854 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5854/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5854/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5854/events | https://github.com/kubeflow/pipelines/issues/5854 | 919,989,995 | MDU6SXNzdWU5MTk5ODk5OTU= | 5,854 | [sdk] Error occurs for component_input_parameter in v2 compiler | {
"login": "TrsNium",
"id": 11388424,
"node_id": "MDQ6VXNlcjExMzg4NDI0",
"avatar_url": "https://avatars.githubusercontent.com/u/11388424?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/TrsNium",
"html_url": "https://github.com/TrsNium",
"followers_url": "https://api.github.com/users/TrsNium/followers",
"following_url": "https://api.github.com/users/TrsNium/following{/other_user}",
"gists_url": "https://api.github.com/users/TrsNium/gists{/gist_id}",
"starred_url": "https://api.github.com/users/TrsNium/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/TrsNium/subscriptions",
"organizations_url": "https://api.github.com/users/TrsNium/orgs",
"repos_url": "https://api.github.com/users/TrsNium/repos",
"events_url": "https://api.github.com/users/TrsNium/events{/privacy}",
"received_events_url": "https://api.github.com/users/TrsNium/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"I noticed that I can compile without using the exit handler.\r\nI just did a print debugging.\r\nThe target_date is recognized as a input_parameter of the subgroup component, but there is no such parameter in the parent, which may be causing the above error.\r\n\r\n```\r\n**********************group.name***************\r\ngroup.name: exit-handler-1, rootgroup_name: 8a1b7dd5281c40c3aee5c15a24814903\r\n********************root spec******************\r\ninput_definitions {\r\n parameters {\r\n key: \"category_models\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"dataset_id\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"metric_bucket_url\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"metric_image\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"output_gcs_path\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"parallel_num\"\r\n value {\r\n type: INT\r\n }\r\n }\r\n parameters {\r\n key: \"pipelines_url\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"service_project_id\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"slack_webhook\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"snap_item_limit\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"target_date\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n parameters {\r\n key: \"vertex_pipelines_project_id\"\r\n value {\r\n type: STRING\r\n }\r\n }\r\n}\r\ndag {\r\n tasks {\r\n key: \"exit-handler-1\"\r\n value {\r\n task_info {\r\n name: \"exit-handler-1\"\r\n }\r\n component_ref {\r\n name: \"comp-exit-handler-1\"\r\n }\r\n }\r\n }\r\n}\r\n\r\n********************group component spec******************\r\n{'comp-exit-handler-1': }\r\n\r\n********************subgroup params*****************\r\n[{{pipelineparam:op=;name=target_date}}]\r\n```\r\nhttps://github.com/kubeflow/pipelines/blob/a41a72f61461569e60107a1c85bfde7ffe05ca88/sdk/python/kfp/v2/compiler/compiler.py#L615-L618\r\nhttps://github.com/kubeflow/pipelines/blob/a41a72f61461569e60107a1c85bfde7ffe05ca88/sdk/python/kfp/v2/compiler/compiler.py#L663\r\n\r\n`exit-handler` group does not have parameters, So I figured the error would occur.\r\n",
"@chensun hello.\r\nCould you review this PR? #5899 "
] | "2021-06-14T04:37:16" | "2021-06-22T09:21:56" | "2021-06-22T09:21:56" | CONTRIBUTOR | null | ### Environment
* KFP SDK version:
1.6.3
### Steps to reproduce
Define and execute a pipeline with the following code
```python
slack_notification_op = comp.load_component_from_text(
read_file("components/slack-notification/component.yaml")
)
def get_before_days(date: str, fmt: str, days: int) -> str:
"""
Subtract the number of days from the date from the date and the number of days specified in the argument.
Parameters
----------
date: str
Original Date
fmt: str
Date formate with a (strftime, strptime) format
days: int
The number of days to subtract.
"""
from datetime import datetime, timedelta
dt = datetime.strptime(date, fmt)
new_dt = dt - timedelta(days=days)
return new_dt.strftime(fmt)
@dsl.pipeline(
name="test",
description="",
)
def feature_extract_pipeline(
vertex_pipelines_project_id: str,
dataset_id: str,
pipelines_url: str,
slack_webhook: str,
target_date: str,
):
with dsl.ExitHandler(
exit_op=slack_notification_op(
job_name="{{workflow.name}}",
webhook_url=slack_webhook,
status="{{workflow.status}}",
pipelines_url=f"{pipelines_url}/pipeline/#/runs/details/{{{{workflow.uid}}}}",
)
):
get_before_a_days_op = comp.create_component_from_func(
func=get_before_days, base_image="python:alpine"
)
before_a_day = get_before_a_days_op(
target_date, "%Y%m%d", 1
)
from kfp.v2 import compiler
import tempfile
with tempfile.TemporaryDirectory() as tempdir:
package_path = os.path.join(tempdir, "pipeline.json")
# NOTE: The type_check argument is probably not working.
compiler.Compiler().compile(pipeline_func=feature_extract_pipeline, package_path=package_path)
```
following is error messsage
```
ata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/kfp/v2/compiler/compiler.py", line 687, in _group_to_dag_spec
input_artifacts_in_current_dag,
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/kfp/dsl/component_spec.py", line 338, in update_task_inputs_spec
component_input_parameter, parent_component_inputs)
AssertionError: component_input_parameter: pipelineparam--pipelineparam--target_date not found. All inputs:
```
I got same error occurred when using `from kfp.v2.dsl import component`.
~If you use a python function with component, you will get an error like the one above~
### Expected result
No errors occur during compilation.
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5854/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5854/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5853 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5853/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5853/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5853/events | https://github.com/kubeflow/pipelines/issues/5853 | 919,928,785 | MDU6SXNzdWU5MTk5Mjg3ODU= | 5,853 | [bug] Unable to start the built-in pipeline. rpc error: code = DeadlineExceeded desc = context deadline exceeded | {
"login": "huang06",
"id": 20633863,
"node_id": "MDQ6VXNlcjIwNjMzODYz",
"avatar_url": "https://avatars.githubusercontent.com/u/20633863?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huang06",
"html_url": "https://github.com/huang06",
"followers_url": "https://api.github.com/users/huang06/followers",
"following_url": "https://api.github.com/users/huang06/following{/other_user}",
"gists_url": "https://api.github.com/users/huang06/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huang06/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huang06/subscriptions",
"organizations_url": "https://api.github.com/users/huang06/orgs",
"repos_url": "https://api.github.com/users/huang06/repos",
"events_url": "https://api.github.com/users/huang06/events{/privacy}",
"received_events_url": "https://api.github.com/users/huang06/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"The error is from k8s itself. It is not related to KFP. You will need to check the logs of your cluster."
] | "2021-06-14T01:21:23" | "2021-06-18T01:05:34" | "2021-06-18T01:05:33" | NONE | null | ### What steps did you take
Run the built-in pipeline experiment: **[Tutorial] Data passing in python components**
<!-- A clear and concise description of what the bug is.-->
### What happened:
After the Kubeflow v1.20.0 installation, I try to run the built-in pipeline **[Tutorial] Data passing in python components**.
Those pipeline components stuck for a long time.
The following is the Pods info:
```bash
$ k get po -n admin
NAME READY STATUS RESTARTS AGE
file-passing-pipelines-8r7df-1316978937 0/2 Init:0/1 0 126m
file-passing-pipelines-8r7df-3202420753 0/2 ContainerCreating 0 126m
file-passing-pipelines-8r7df-4267582061 0/2 ContainerCreating 0 126m
ml-pipeline-ui-artifact-c8fbcb8f9-p9t8l 0/2 Init:0/1 0 140m
ml-pipeline-visualizationserver-6b78c9646-b7jgk 0/2 Init:0/1 0 11h
```
```bash
$ k describe po file-passing-pipelines-8r7df-1316978937 -n admin
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning FailedSync 14s (x67 over 113m) kubelet error determining status: rpc error: code = DeadlineExceeded desc = context deadline exceeded
```
```bash
$ k describe po file-passing-pipelines-8r7df-3202420753 -n admin
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning FailedSync 2m36s (x64 over 105m) kubelet error determining status: rpc error: code = DeadlineExceeded desc = context deadline exceeded
```
```bash
$ k describe po file-passing-pipelines-8r7df-4267582061 -n admin
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning FailedSync 2m33s (x66 over 107m) kubelet error determining status: rpc error: code = DeadlineExceeded desc = context deadline exceeded
```
```bash
$ k describe po ml-pipeline-ui-artifact-c8fbcb8f9-p9t8l -n admin
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning FailedSync 2m50s (x79 over 124m) kubelet error determining status: rpc error: code = DeadlineExceeded desc = context deadline exceeded
```
```bash
$ k describe po ml-pipeline-visualizationserver-6b78c9646-b7jgk -n admin
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning FailedSync 3m32s (x735 over 11h) kubelet error determining status: rpc error: code = DeadlineExceeded desc = context deadline exceeded
```
### Environment:
<!-- Please fill in those that seem relevant. -->
|Application|Version|
|---|---|
|OS|Ubuntu Desktop 18.04.5 LTS|
|Kubernetes on-premise|v1.20.7|
|Container runtime|Docker 19.03.15|
|Network plugin|flannel 0.13.0|
|Kubeflow|v1.2.0 (**kfctl_istio_dex.v1.2.0.yaml**)|
### Anything else you would like to add:
<!-- Miscellaneous information that will assist in solving the issue.-->
### Labels
<!-- Please include labels below by uncommenting them to help us better triage issues -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
<!-- /area testing -->
<!-- /area samples -->
<!-- /area components -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5853/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5853/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5851 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5851/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5851/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5851/events | https://github.com/kubeflow/pipelines/issues/5851 | 919,791,952 | MDU6SXNzdWU5MTk3OTE5NTI= | 5,851 | [bug] Kubeflow Pipeline experiment run is always running | {
"login": "achikars",
"id": 83945961,
"node_id": "MDQ6VXNlcjgzOTQ1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/83945961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/achikars",
"html_url": "https://github.com/achikars",
"followers_url": "https://api.github.com/users/achikars/followers",
"following_url": "https://api.github.com/users/achikars/following{/other_user}",
"gists_url": "https://api.github.com/users/achikars/gists{/gist_id}",
"starred_url": "https://api.github.com/users/achikars/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/achikars/subscriptions",
"organizations_url": "https://api.github.com/users/achikars/orgs",
"repos_url": "https://api.github.com/users/achikars/repos",
"events_url": "https://api.github.com/users/achikars/events{/privacy}",
"received_events_url": "https://api.github.com/users/achikars/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"Have you set TTL via https://kubeflow-pipelines.readthedocs.io/en/stable/source/kfp.dsl.html?highlight=node#kfp.dsl.PipelineConf.set_ttl_seconds_after_finished?\r\nIt is not the correct way to set TTL.\r\nThe correct way to set TTL in KFP is recorded in #3938 ",
"@capri-xiyue \r\nCan you give some more details ?\r\nI am experiencing the same issue and I am using `set_ttl_seconds_after_finished` to set ttl on the workflow.\r\nWhy it's not the correct way to set TTL ? what is the purpose of this method ?\r\nThe correct way you linked to is a way to set a TTL globally, what if I want a different TTL per pipeline ? \r\nit seems like this method is the way to go\r\nAbove all, how/why the way I'm setting the TTL affecting whether my pipeline is being correctly moving between states or not ?",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"I fixed the first part and the default from persistenceagent is working now with kubernetes resources https://github.com/kubeflow/pipelines/pull/6622 , but i still think that pipelineconf `TTL_SECONDS_AFTER_WORKFLOW_FINISH` per workflow is broken as mentioned in https://github.com/kubeflow/pipelines/issues/6432",
"> \r\n> \r\n> @capri-xiyue Can you give some more details ? I am experiencing the same issue and I am using `set_ttl_seconds_after_finished` to set ttl on the workflow. Why it's not the correct way to set TTL ? what is the purpose of this method ? The correct way you linked to is a way to set a TTL globally, what if I want a different TTL per pipeline ? it seems like this method is the way to go Above all, how/why the way I'm setting the TTL affecting whether my pipeline is being correctly moving between states or not ?\r\n\r\nWhy does this pipelineconf function exist if it is unusable and broken?",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-13T12:48:42" | "2022-03-03T03:05:13" | "2022-03-03T03:05:13" | NONE | null | ### What steps did you take
Ran an experiment , created in a workflow.py file and run from jupyterlab.
<!-- A clear and concise description of what the bug is.-->
### What happened:
I have multiple experiment runs(workflow) which runs sets of kuberenets pods(children inside the workflow) but from some reason some of the runs are still running for days even though all the child pods are completed (Succeeded/Failed).
I have been looking at the logs of the workflow controller but couldn't find the issue. I have went through the workflow.py file to see if something is wrong there but could find the reason why some of the runs are completed and some are still running. Just to remind - I am talking on different runs of the same experiment.
When reviewing the logs of succeeded workflow vs a keep running workflow I some differences:
From the successful workflow:
time="2021-06-11T17:38:37Z" level=info msg="Found Workflow default-tenant/txyz set expire at 2021-06-11 17:50:37 +0000 UTC (11m59.461359494s from now)"
time="2021-06-11T17:38:37Z" level=info msg="Queueing workflow default-tenant/xyz for delete in 11m59.461359494s"
time="2021-06-11T17:50:37Z" level=info msg="Deleting TTL expired workflow default-tenant/xyz"
time="2021-06-11T17:50:37Z" level=info msg="Successfully deleted 'default-tenant/xyz'"
. .
From the still running workflow:
time="2021-06-11T09:13:10Z" level=info msg="Node not set to be retried after status: Error" namespace=default-tenant workflow=xyz
and getting the following message until now:
time="2021-06-11T09:38:42Z" level=info msg="Processing workflow" namespace=default-tenant workflow=xyz
### What did you expect to happen:
I was expecting to see all runs in a completed state (Succeeded/Failed)
### Environment:
<!-- Please fill in those that seem relevant. -->
* How do you deploy Kubeflow Pipelines (KFP)?
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version:
1.0.1
* KFP SDK version:
1.0.1
### Anything else you would like to add:
<!-- Miscellaneous information that will assist in solving the issue.-->
### Labels
<!-- Please include labels below by uncommenting them to help us better triage issues -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
<!-- /area testing -->
<!-- /area samples -->
<!-- /area components -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5851/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5851/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5848 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5848/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5848/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5848/events | https://github.com/kubeflow/pipelines/issues/5848 | 919,074,713 | MDU6SXNzdWU5MTkwNzQ3MTM= | 5,848 | [frontend] [UI] [aws] [need help] Not able to retrieve the image to KFP UI from S3 | {
"login": "dutingda",
"id": 38673967,
"node_id": "MDQ6VXNlcjM4NjczOTY3",
"avatar_url": "https://avatars.githubusercontent.com/u/38673967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dutingda",
"html_url": "https://github.com/dutingda",
"followers_url": "https://api.github.com/users/dutingda/followers",
"following_url": "https://api.github.com/users/dutingda/following{/other_user}",
"gists_url": "https://api.github.com/users/dutingda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dutingda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dutingda/subscriptions",
"organizations_url": "https://api.github.com/users/dutingda/orgs",
"repos_url": "https://api.github.com/users/dutingda/repos",
"events_url": "https://api.github.com/users/dutingda/events{/privacy}",
"received_events_url": "https://api.github.com/users/dutingda/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930619516,
"node_id": "MDU6TGFiZWw5MzA2MTk1MTY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/frontend",
"name": "area/frontend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"Thank you for your understanding ",
"No good PC and Tools to work on further. Need more times in learning more on how to smoothen enhanced works.",
"@JODIN1727 Do you mean we do not have a solution to it now?\r\n",
"It is moderately good to go as way out but need more times for tools to support ",
"I don't understand what you are trying to express here, please give comment directly answers the question",
"Currently we don't support this feature for security reason.\r\nWorkaround is to encode image and store it inline in html",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-11T18:30:30" | "2022-03-03T03:05:28" | "2022-03-03T03:05:28" | NONE | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
Kubeflow pipeline runs normally, but the frontend is not working as expected.
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version: 1.1
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
### Steps to reproduce
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
By using the similar code in [`this example`](https://github.com/kubeflow/pipelines/tree/master/samples/contrib/versioned-pipeline-ci-samples/kaggle-ci-sample/visualize_html), I do not know how to do the configuration to let the UI have the access to S3 without making it public.
<img width="1024" alt="Screen Shot 2021-06-11 at 2 27 51 PM" src="https://user-images.githubusercontent.com/38673967/121733706-d078ab00-cac1-11eb-8938-7d1e2a966c63.png">
### Expected result
<!-- What should the correct behavior be? -->
It will show the image
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5848/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5848/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5846 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5846/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5846/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5846/events | https://github.com/kubeflow/pipelines/issues/5846 | 919,049,771 | MDU6SXNzdWU5MTkwNDk3NzE= | 5,846 | [feature] Azure - Authenticating Kfp client using client id, secret id and tenant id | {
"login": "pablofiumara",
"id": 4154361,
"node_id": "MDQ6VXNlcjQxNTQzNjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/4154361?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablofiumara",
"html_url": "https://github.com/pablofiumara",
"followers_url": "https://api.github.com/users/pablofiumara/followers",
"following_url": "https://api.github.com/users/pablofiumara/following{/other_user}",
"gists_url": "https://api.github.com/users/pablofiumara/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablofiumara/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablofiumara/subscriptions",
"organizations_url": "https://api.github.com/users/pablofiumara/orgs",
"repos_url": "https://api.github.com/users/pablofiumara/repos",
"events_url": "https://api.github.com/users/pablofiumara/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablofiumara/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"cc @aronchick ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n",
"Can we re-open this issue? How can we authenticate a kfp client dynamically?"
] | "2021-06-11T18:05:44" | "2022-03-05T01:10:21" | null | NONE | null | Is that possible? Something like the following (point 3) but for Azure: https://www.kubeflow.org/docs/distributions/gke/pipelines/authentication-sdk/#connecting-to-kubeflow-pipelines-in-a-full-kubeflow-deployment | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5846/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5846/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5844 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5844/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5844/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5844/events | https://github.com/kubeflow/pipelines/issues/5844 | 918,787,641 | MDU6SXNzdWU5MTg3ODc2NDE= | 5,844 | [backend] Cached volume creations leads to unschedulable runs, if the pvc is deleted in the pipeline | {
"login": "skogsbrus",
"id": 17073827,
"node_id": "MDQ6VXNlcjE3MDczODI3",
"avatar_url": "https://avatars.githubusercontent.com/u/17073827?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skogsbrus",
"html_url": "https://github.com/skogsbrus",
"followers_url": "https://api.github.com/users/skogsbrus/followers",
"following_url": "https://api.github.com/users/skogsbrus/following{/other_user}",
"gists_url": "https://api.github.com/users/skogsbrus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skogsbrus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skogsbrus/subscriptions",
"organizations_url": "https://api.github.com/users/skogsbrus/orgs",
"repos_url": "https://api.github.com/users/skogsbrus/repos",
"events_url": "https://api.github.com/users/skogsbrus/events{/privacy}",
"received_events_url": "https://api.github.com/users/skogsbrus/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi there,\r\n\r\nthis is a duplicate of https://github.com/kubeflow/pipelines/issues/5257. Should we close this in favor of the other one.\r\n\r\nCopying [my comment](https://github.com/kubeflow/pipelines/issues/5257#issuecomment-852326538) here as well, for the sake of completeness of this issue:\r\n>I think the problem here is that\r\n>1. the mechanism is caching steps that it shouldn't do so\r\n>2. there is no \"user\" selection on whether to cache some specific step or not, only global API server configuration. The API server overrides any configuration: https://github.com/kubeflow/pipelines/blob/601b104c0beba8049dfee493d0b07c0aea390b78/backend/src/apiserver/resource/resource_manager.go#L377"
] | "2021-06-11T13:58:01" | "2021-06-17T10:21:30" | "2021-06-17T10:21:30" | NONE | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)? KF 1.3 Manifests release, on premises
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version: 1.5.0
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
```
$ pip list | grep kfp
kfp 1.6.2
kfp-pipeline-spec 0.1.7
kfp-server-api 1.5.0
```
### Steps to reproduce
1. Define a pipeline that creates a volume, mounts it, and then destroys it:
```
import kfp
from kfp import dsl
def glob_volume(volume):
@kfp.components.create_component_from_func
def glob_files(directory: str) -> list:
import pathlib
paths = pathlib.Path(directory).glob('**/*')
filepaths = [str(p) for p in paths if p.is_file()]
return filepaths
component_function = glob_files
return component_function("/volume") \
.add_pvolumes({
"/volume": volume
})
@dsl.pipeline(name="vol-cache-bug", description="Demonstrates a caching bug in KF 1.3")
def volume_caching_bug():
vop = dsl.VolumeOp(name='create-a-volume', resource_name='a-volume', size="1Gi", modes=dsl.VOLUME_MODE_RWO)
glob_vol_op = glob_volume(vop.volume)
vop.delete().after(glob_vol_op)
if __name__ == "__main__":
kfp.compiler.Compiler().compile(volume_caching_bug, "volume_caching_bug.yaml")
```
2. Create a pipeline and an experiment in the UI from the above sample
3. Launch a run, let it complete
4. (delete mounting pods if the PVC is stuck at terminating)
5. Clone the run
6. The first step is cached and never run
7. The second step is never scheduled, because the volume got deleted in the previous run and was never created in this run.
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
### Expected result
<!-- What should the correct behavior be? -->
I expected that volume ops should not be cached at all. If the PVC already exists it should be reused and if it doesn't it should be created. Alternatively, that VolumeOp supported an equivalent to `.execution_options.caching_strategy.max_cache_staleness = "P0D"`.
FWIW: Recently upgraded from KF 1.1 to KF 1.3. Did not experience this on 1.1.
### Workarounds
1. Rename the volume creation step to prevent it from fetching from cache. Needs to be done after each run (i.e. upload a new pipeline version before issuing a new run)
2. Disable caching on the whole KF instance.
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5844/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5844/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5843 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5843/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5843/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5843/events | https://github.com/kubeflow/pipelines/issues/5843 | 918,781,244 | MDU6SXNzdWU5MTg3ODEyNDQ= | 5,843 | Possible to use ImagePullSecret on a func_to_container_op? | {
"login": "aronchick",
"id": 51317,
"node_id": "MDQ6VXNlcjUxMzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/51317?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aronchick",
"html_url": "https://github.com/aronchick",
"followers_url": "https://api.github.com/users/aronchick/followers",
"following_url": "https://api.github.com/users/aronchick/following{/other_user}",
"gists_url": "https://api.github.com/users/aronchick/gists{/gist_id}",
"starred_url": "https://api.github.com/users/aronchick/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aronchick/subscriptions",
"organizations_url": "https://api.github.com/users/aronchick/orgs",
"repos_url": "https://api.github.com/users/aronchick/repos",
"events_url": "https://api.github.com/users/aronchick/events{/privacy}",
"received_events_url": "https://api.github.com/users/aronchick/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1682717392,
"node_id": "MDU6TGFiZWwxNjgyNzE3Mzky",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/question",
"name": "kind/question",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"`func_to_container_op` function creates components. This function does not access images, so it does not need secrets.\r\n\r\nComponents are expected to be portable and self-contained. We do not support adding cluster-specific information like secret names or volumes to the component definitions.\r\n\r\nHowever, after creating an instance of the component, some of these options can be configured on the resulting task. Some pipeline-wide options are configurable using the `PipelineConf` object that can be passed to the compiler or client.\r\n\r\nExample with set_image_pull_secrets:\r\n```python\r\nmy_op = create_component_from_func(...)\r\n\r\ndef my_pipeline():\r\n my_task = my_op()\r\n\r\nfrom kubernetes import client as k8s_client\r\npipeline_conf = kfp.dsl.PipelineConf()\r\npipeline_conf.set_image_pull_secrets([k8s_client.V1ObjectReference(name=\"secretA\")])\r\n\r\nkfp.Client(host=...).create_run_from_pipeline_func(\r\n my_pipeline,\r\n arguments={},\r\n pipeline_conf=pipeline_conf,\r\n)\r\n```\r\n\r\n\r\nP.S. Perhaps you can use the canonical function name - `create_component_from_func` instead of the older name `func_to_container_op`.",
"AH, thank you - changing to the new function and switching to the pipeline_conf did it (I kept trying to hack at it with annotations).\r\n\r\nFeel free to close - but, it may be worth allowing setting a specific imagePullSecret by component (in the rare case i need to pull from two separate private repos in a pipeline)",
"OH, never mind - misread your comment. Yes, setting `pipeline_conf` by component is exactly what i was thinking of. Perfect. Thanks!",
">setting pipeline_conf by component\r\n\r\npipeline_conf is pipeline-level configuration.\r\n\r\ntask-level configuration can be set using `ContainerOp` members. All Kubernetes' options are supported, but only few Kubeernetes' Pod-level options are supported.\r\n\r\n```\r\nmy_task = my_op()\r\nmy_task.container.foo = bar\r\n```\r\n\r\n>it may be worth allowing setting a specific imagePullSecret by component (in the rare case i need to pull from two separate private repos in a pipeline)\r\n\r\nUnfortunately, Argo does not support setting the imagePullSecrets per Argo Template, inly per-Workflow.\r\n\r\nHowever the `set_image_pull_secrets` accepts a list of secrets, so you can specify both.",
"> changing to the new function\r\n\r\nThese functions have the same code and behavior. Just different names. We've deprecated the direct construction of COntainerOp and added support for components in TFX SDK where the ContainerOp does not exist. So the `create_component_from_func` is just a more fitting name compared to `func_to_container_op`."
] | "2021-06-11T13:52:38" | "2021-06-12T05:57:19" | "2021-06-12T05:54:53" | NONE | null | Is it possible to use an ImagePullSecret on a func_to_container_op? | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5843/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5843/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5841 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5841/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5841/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5841/events | https://github.com/kubeflow/pipelines/issues/5841 | 918,317,021 | MDU6SXNzdWU5MTgzMTcwMjE= | 5,841 | [pH] propose using a golang linter | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-11T07:08:42" | "2022-03-03T03:05:18" | "2022-03-03T03:05:18" | CONTRIBUTOR | null | Rationale: a linter can catch non-obvious but common problems, for example, I guess https://github.com/kubeflow/pipelines/pull/5836/files#r649683859 should be an issue that can be caught by a golang linter.
Candidates:
* https://github.com/golangci/golangci-lint | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5841/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5841/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5840 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5840/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5840/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5840/events | https://github.com/kubeflow/pipelines/issues/5840 | 918,308,738 | MDU6SXNzdWU5MTgzMDg3Mzg= | 5,840 | [feature] dsl-compile supports v2 compatible mode | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 942985146,
"node_id": "MDU6TGFiZWw5NDI5ODUxNDY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/XS",
"name": "size/XS",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-06-11T06:57:37" | "2021-07-03T09:22:49" | "2021-07-03T09:22:49" | CONTRIBUTOR | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
<!-- /area backend -->
/area sdk
<!-- /area samples -->
<!-- /area components -->
### What feature would you like to see?
Add a flag to enable v2 compatible mode when using dsl-compile.
Ideally, v2 compatible mode can be enabled using an env var, so that we can switch to v2 compatible mode and do not need an explicit flag each time.
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5840/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5840/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5839 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5839/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5839/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5839/events | https://github.com/kubeflow/pipelines/issues/5839 | 918,302,758 | MDU6SXNzdWU5MTgzMDI3NTg= | 5,839 | [samples] consistent main block for pipeline samples | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1260031624,
"node_id": "MDU6TGFiZWwxMjYwMDMxNjI0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/samples",
"name": "area/samples",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"## Idea for long term\r\n\r\nI think the best experience is doing https://github.com/kubeflow/pipelines/issues/5381 first.\r\n\r\nThen samples do not even need a main block.\r\n\r\nTo run a sample: `kfp run xxxxx.py`.\r\nTo compile a sample: `kfp compile xxxx.py`.\r\n\r\nIf env-specific args are needed (e.g. KFP host name, enabling v2 compatible mode), configure them as env vars / config files, so they are not needed in each `kfp` CLI run.\r\n\r\nI think we should also think about what's the best choice right now before implementing the long term idea",
"I suggest we keep v1_legacy mode as the default compilation mode for now. \r\nSome samples need to be updated, and some v2 compatible bugs needs to be fixed before it's ready to be the default mode in our sample. \r\n\r\nWe have warning saying that v2 compatible is in beta state and many features may not work as expected. I think by the time we feel like we can remove this warning, then v2 compatible mode can be the default.",
"@chensun I think you made a great point!\r\n\r\nNote that there are also v2 only samples, I think we should use v2 compatible mode for them as the default.\r\n\r\nTherefore, the overall guideline is:\r\n* any pipelines that work in v1 should default to compile in v1 legacy mode\r\n* any pipelines that only work in v2 should default to compile to v2 compatible mode\r\n\r\nDoes this match your expectation?",
"Q2: do we write main block as `kfp.Client().create_run_from_pipeline_func` or `kfp.Compiler().compile`?\r\n\r\ncreate_run_from_pipeline_func requires some connection setup, so it has harder learning curve.\r\nAfter finishing the config, it makes future iterations much easier (editing pipelines & resubmitting).\r\n\r\ncompile has minimum learning curve, just compile and then upload the compiled file in UI.\r\nbut it's cumbersome afterwards once the user knows how to use create_run_from_pipeline_func.\r\n\r\nI haven't figured out the right default option by myself yet.\r\n\r\nQ3: some samples are notebooks, do we make a different choice for notebooks?",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-11T06:49:31" | "2022-03-03T03:05:20" | "2022-03-03T03:05:20" | CONTRIBUTOR | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
/area samples
<!-- /area components -->
### What feature would you like to see?
<!-- Provide a description of this feature and the user experience. -->
I'd like to see a consistent __main__ block for pipeline samples.
### What is the use case or pain point?
Make samples easy to use with just `python xxxx.py`.
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
1. Use `dsl-compile` to compile a sample and run it
2. Edie the sample or copy the sample elsewhere to inject a `kfp.Client()` call
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5839/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5839/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5838 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5838/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5838/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5838/events | https://github.com/kubeflow/pipelines/issues/5838 | 918,289,726 | MDU6SXNzdWU5MTgyODk3MjY= | 5,838 | [v2compat] support minio/s3 pipeline root for v2 python components | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1116354964,
"node_id": "MDU6TGFiZWwxMTE2MzU0OTY0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/S",
"name": "size/S",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Thank you Yuan for the fix!\r\n\r\nValidated artifact is created for minio path:\r\n\r\n\r\n"
] | "2021-06-11T06:32:52" | "2021-06-24T15:53:38" | "2021-06-24T07:47:19" | CONTRIBUTOR | null | ### Environment
* KFP SDK version: head
### Steps to reproduce
1. run https://github.com/kubeflow/pipelines/blob/master/samples/test/lightweight_python_functions_v2_pipeline.py with minio pipeline root
2. it fails with
```
Traceback (most recent call last):
File "/tmp/tmp.k9PitIcFpw", line 841, in <module>
executor_main()
File "/tmp/tmp.k9PitIcFpw", line 835, in executor_main
function_to_execute=function_to_execute)
File "/tmp/tmp.k9PitIcFpw", line 549, in __init__
artifacts_list[0])
File "/tmp/tmp.k9PitIcFpw", line 562, in _make_output_artifact
os.makedirs(os.path.dirname(artifact.path), exist_ok=True)
File "/usr/local/lib/python3.7/posixpath.py", line 156, in dirname
p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not NoneType
F0611 06:22:43.823995 1 main.go:56] Failed to execute component: exit status 1
```
I further outputted v2 python component wrapper code and found that it only supports gs:// pipeline root:
### Expected result
<!-- What should the correct behavior be? -->
This pipeline should work regardless of pipeline root chosen.
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
The current launcher contract for other types of storage is: https://github.com/kubeflow/pipelines/blob/a37ba15706f0f5c3e07afe42602a457c217e928c/v2/component/launcher.go#L472-L483
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5838/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5838/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5835 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5835/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5835/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5835/events | https://github.com/kubeflow/pipelines/issues/5835 | 917,867,185 | MDU6SXNzdWU5MTc4NjcxODU= | 5,835 | [sdk] V2_COMPATIBLE mode don't work with parameter input for setting resources. | {
"login": "NikeNano",
"id": 22057410,
"node_id": "MDQ6VXNlcjIyMDU3NDEw",
"avatar_url": "https://avatars.githubusercontent.com/u/22057410?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NikeNano",
"html_url": "https://github.com/NikeNano",
"followers_url": "https://api.github.com/users/NikeNano/followers",
"following_url": "https://api.github.com/users/NikeNano/following{/other_user}",
"gists_url": "https://api.github.com/users/NikeNano/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NikeNano/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NikeNano/subscriptions",
"organizations_url": "https://api.github.com/users/NikeNano/orgs",
"repos_url": "https://api.github.com/users/NikeNano/repos",
"events_url": "https://api.github.com/users/NikeNano/events{/privacy}",
"received_events_url": "https://api.github.com/users/NikeNano/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | open | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign @chensun ",
"Feel free to update the name as well @chensun. ",
"Hi @NikeNano, we continue to welcome contribution to this.\r\n\r\nI heard that you were blocked by permission to access v2 sample test.\r\n\r\nTwo paths forward:\r\n* get https://github.com/kubeflow/pipelines/tree/master/v2/test to run on your env, can you share more info on how you test KFP? Would it be enough making it possible to run the entire test suite with minio only?\r\n* grant you access to https://github.com/kubeflow/internal-acls/blob/master/google_groups/groups/ci-team.yaml, I think given the amount of contributions you've made. I can trust you for this.",
"Yeah it was hard to debug the failing tests due to the restrictions. \r\n\r\n> * get https://github.com/kubeflow/pipelines/tree/master/v2/test to run on your env, can you share more info on how you test KFP? Would it be enough making it possible to run the entire test suite with minio only?\r\n\r\nI usually set up Kubeflow pipelines locally on `minikube` when I need to run the test suits, which usually works well. However only do this if I cant manage to debug it through the integration tests. \r\n\r\n> * grant you access to https://github.com/kubeflow/internal-acls/blob/master/google_groups/groups/ci-team.yaml, I think given the amount of contributions you've made. I can trust you for this.\r\n\r\nThis would be awesome! \r\n",
"Cool, then you can submit a PR for ci-team.yaml and ask me for approval.",
"@NikeNano it seems that you haven't been added automatically to ci-team google group, see https://groups.google.com/a/kubeflow.org/g/ci-team/members.\r\n\r\nlet me troubleshoot why the automation broke",
"I found some error syncing the `ci-team.yaml` file,\r\n> {\"level\":\"error\",\"ts\":1626158808.1679611,\"caller\":\"api/util.go:38\",\"msg\":\"Error parsing GoogleGroup from file.\",\"file\":\"/data/internal-acls.git/google_groups/groups/ci-team.yaml\",\"error\":\"error converting YAML to JSON: yaml: line 12: did not find expected key\",\"stacktrace\":\"github\r\n.com/kubeflow/internal-acls/google_groups/pkg/api.ReadGroups\\n\\t/workspace/pkg/api/util.go:38\\nmain.run.func1\\n\\t/workspace/cmd/main.go:234\\nmain.run\\n\\t/workspace/cmd/main.go:277\\nmain.glob..func1\\n\\t/workspace/cmd/main.go:52\\ngithub.com/spf13/cobra.(*Command).execute\\n\\t/go/pkg/\r\nmod/github.com/spf13/cobra@v1.1.1/command.go:854\\ngithub.com/spf13/cobra.(*Command).ExecuteC\\n\\t/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:958\\ngithub.com/spf13/cobra.(*Command).Execute\\n\\t/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:895\\nmain.main\\n\\t/workspace/\r\ncmd/main.go:395\\nruntime.main\\n\\t/usr/local/go/src/runtime/proc.go:203\"}",
"Fixed that in https://github.com/kubeflow/internal-acls/commit/c900718e0738c27289a3b19c674ef78c1f86b672",
"Hi @NikeNano, you are now part of the ci-team@kubeflow.org!\r\nWelcome, and you should be able to visit kfp v2 sample test infra now!",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"
] | "2021-06-10T20:22:45" | "2022-03-03T02:05:32" | null | MEMBER | null | ### Environment
For more info: https://github.com/kubeflow/pipelines/pull/5447#issuecomment-858482668
* KFP version:
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP SDK version:
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* All dependencies version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
### Steps to reproduce
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
### Expected result
<!-- What should the correct behavior be? -->
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5835/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5835/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5834 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5834/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5834/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5834/events | https://github.com/kubeflow/pipelines/issues/5834 | 917,225,205 | MDU6SXNzdWU5MTcyMjUyMDU= | 5,834 | [v2compat] cannot override container image as parameters | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Generated workflow. It's clear that the error message means that the \"train\" template uses `{{inputs.parameters.tf_image}}` in image field, but the template does not have `tf_image` added as an input parameter.\r\n\r\n```yaml\r\napiVersion: argoproj.io/v1alpha1\r\nkind: Workflow\r\nmetadata:\r\n generateName: pipeline-tensorboard-minio-\r\n annotations:\r\n pipelines.kubeflow.org/kfp_sdk_version: 1.6.4\r\n pipelines.kubeflow.org/pipeline_compilation_time: '2021-06-30T07:57:21.370042'\r\n pipelines.kubeflow.org/pipeline_spec: '{\"inputs\": [{\"default\": \"minio-service:9000\",\r\n \"name\": \"minio_endpoint\", \"optional\": true, \"type\": \"String\"}, {\"default\": \"mlpipeline\",\r\n \"name\": \"log_bucket\", \"optional\": true, \"type\": \"String\"}, {\"default\": \"tensorboard/logs/{{workflow.uid}}\",\r\n \"name\": \"log_dir\", \"optional\": true, \"type\": \"String\"}, {\"default\": \"gcr.io/deeplearning-platform-release/tf2-cpu.2-3:latest\",\r\n \"name\": \"tf_image\", \"optional\": true, \"type\": \"String\"}, {\"default\": \"\", \"name\":\r\n \"pipeline-output-directory\"}, {\"default\": \"pipeline-tensorboard-minio\", \"name\":\r\n \"pipeline-name\"}], \"name\": \"pipeline-tensorboard-minio\"}'\r\n pipelines.kubeflow.org/v2_pipeline: \"true\"\r\n labels:\r\n pipelines.kubeflow.org/v2_pipeline: \"true\"\r\n pipelines.kubeflow.org/kfp_sdk_version: 1.6.4\r\nspec:\r\n entrypoint: pipeline-tensorboard-minio\r\n templates:\r\n - name: create-tensorboard-visualization\r\n container:\r\n args:\r\n - sh\r\n - -ex\r\n - -c\r\n - |\r\n log_dir=\"$0\"\r\n output_metadata_path=\"$1\"\r\n pod_template_spec=\"$2\"\r\n image=\"$3\"\r\n\r\n mkdir -p \"$(dirname \"$output_metadata_path\")\"\r\n\r\n echo '\r\n {\r\n \"outputs\" : [{\r\n \"type\": \"tensorboard\",\r\n \"source\": \"'\"$log_dir\"'\",\r\n \"image\": \"'\"$image\"'\",\r\n \"pod_template_spec\": '\"$pod_template_spec\"'\r\n }]\r\n }\r\n ' >\"$output_metadata_path\"\r\n - '{{$.inputs.parameters[''Log dir URI'']}}'\r\n - '{{$.outputs.artifacts[''mlpipeline-ui-metadata''].path}}'\r\n - '{{$.inputs.parameters[''Pod Template Spec'']}}'\r\n - '{{$.inputs.parameters[''Image'']}}'\r\n command: [/kfp-launcher/launch, --mlmd_server_address, $(METADATA_GRPC_SERVICE_HOST),\r\n --mlmd_server_port, $(METADATA_GRPC_SERVICE_PORT), --runtime_info_json, $(KFP_V2_RUNTIME_INFO),\r\n --container_image, $(KFP_V2_IMAGE), --task_name, create-tensorboard-visualization,\r\n --pipeline_name, '{{inputs.parameters.pipeline-name}}', --pipeline_run_id,\r\n $(WORKFLOW_ID), --pipeline_task_id, $(KFP_POD_NAME), --pipeline_root, '{{inputs.parameters.pipeline-output-directory}}']\r\n env:\r\n - name: KFP_POD_NAME\r\n valueFrom:\r\n fieldRef: {fieldPath: metadata.name}\r\n - name: KFP_NAMESPACE\r\n valueFrom:\r\n fieldRef: {fieldPath: metadata.namespace}\r\n - name: WORKFLOW_ID\r\n valueFrom:\r\n fieldRef: {fieldPath: 'metadata.labels[''workflows.argoproj.io/workflow'']'}\r\n - {name: KFP_V2_IMAGE, value: alpine}\r\n - {name: KFP_V2_RUNTIME_INFO, value: '{\"inputParameters\": {\"Image\": {\"type\":\r\n \"STRING\", \"value\": \"BEGIN-KFP-PARAM[{{inputs.parameters.tf_image}}]END-KFP-PARAM\"},\r\n \"Log dir URI\": {\"type\": \"STRING\", \"value\": \"BEGIN-KFP-PARAM[s3://{{inputs.parameters.log_bucket}}/{{inputs.parameters.log_dir}}]END-KFP-PARAM\"},\r\n \"Pod Template Spec\": {\"type\": \"STRING\", \"value\": \"BEGIN-KFP-PARAM[{\\\"spec\\\":\r\n {\\\"containers\\\": [{\\\"env\\\": [{\\\"name\\\": \\\"AWS_ACCESS_KEY_ID\\\", \\\"valueFrom\\\":\r\n {\\\"secretKeyRef\\\": {\\\"name\\\": \\\"mlpipeline-minio-artifact\\\", \\\"key\\\": \\\"accesskey\\\"}}},\r\n {\\\"name\\\": \\\"AWS_SECRET_ACCESS_KEY\\\", \\\"valueFrom\\\": {\\\"secretKeyRef\\\":\r\n {\\\"name\\\": \\\"mlpipeline-minio-artifact\\\", \\\"key\\\": \\\"secretkey\\\"}}}, {\\\"name\\\":\r\n \\\"AWS_REGION\\\", \\\"value\\\": \\\"minio\\\"}, {\\\"name\\\": \\\"S3_ENDPOINT\\\", \\\"value\\\":\r\n \\\"{{inputs.parameters.minio_endpoint}}\\\"}, {\\\"name\\\": \\\"S3_USE_HTTPS\\\",\r\n \\\"value\\\": \\\"0\\\"}, {\\\"name\\\": \\\"S3_VERIFY_SSL\\\", \\\"value\\\": \\\"0\\\"}]}]}}]END-KFP-PARAM\"}},\r\n \"inputArtifacts\": {}, \"outputParameters\": {}, \"outputArtifacts\": {\"mlpipeline-ui-metadata\":\r\n {\"schemaTitle\": \"system.Artifact\", \"instanceSchema\": \"\", \"metadataPath\":\r\n \"/tmp/outputs/mlpipeline-ui-metadata/data\"}}}'}\r\n envFrom:\r\n - configMapRef: {name: metadata-grpc-configmap, optional: true}\r\n image: alpine\r\n volumeMounts:\r\n - {mountPath: /kfp-launcher, name: kfp-launcher}\r\n inputs:\r\n parameters:\r\n - {name: log_bucket}\r\n - {name: log_dir}\r\n - {name: minio_endpoint}\r\n - {name: pipeline-name}\r\n - {name: pipeline-output-directory}\r\n - {name: tf_image}\r\n outputs:\r\n artifacts:\r\n - {name: create-tensorboard-visualization-mlpipeline-ui-metadata, path: /tmp/outputs/mlpipeline-ui-metadata/data}\r\n metadata:\r\n annotations:\r\n pipelines.kubeflow.org/v2_component: \"true\"\r\n pipelines.kubeflow.org/component_ref: '{\"digest\": \"583d215a7b720ecea88eb3a53346a137f69c0d1e8ba130895a304aeabee1f14f\",\r\n \"url\": \"../../../components/tensorflow/tensorboard/prepare_tensorboard/component.yaml\"}'\r\n pipelines.kubeflow.org/arguments.parameters: '{\"Image\": \"{{inputs.parameters.tf_image}}\",\r\n \"Log dir URI\": \"s3://{{inputs.parameters.log_bucket}}/{{inputs.parameters.log_dir}}\",\r\n \"Pod Template Spec\": \"{\\\"spec\\\": {\\\"containers\\\": [{\\\"env\\\": [{\\\"name\\\":\r\n \\\"AWS_ACCESS_KEY_ID\\\", \\\"valueFrom\\\": {\\\"secretKeyRef\\\": {\\\"name\\\": \\\"mlpipeline-minio-artifact\\\",\r\n \\\"key\\\": \\\"accesskey\\\"}}}, {\\\"name\\\": \\\"AWS_SECRET_ACCESS_KEY\\\", \\\"valueFrom\\\":\r\n {\\\"secretKeyRef\\\": {\\\"name\\\": \\\"mlpipeline-minio-artifact\\\", \\\"key\\\": \\\"secretkey\\\"}}},\r\n {\\\"name\\\": \\\"AWS_REGION\\\", \\\"value\\\": \\\"minio\\\"}, {\\\"name\\\": \\\"S3_ENDPOINT\\\",\r\n \\\"value\\\": \\\"{{inputs.parameters.minio_endpoint}}\\\"}, {\\\"name\\\": \\\"S3_USE_HTTPS\\\",\r\n \\\"value\\\": \\\"0\\\"}, {\\\"name\\\": \\\"S3_VERIFY_SSL\\\", \\\"value\\\": \\\"0\\\"}]}]}}\"}'\r\n labels:\r\n pipelines.kubeflow.org/kfp_sdk_version: 1.6.4\r\n pipelines.kubeflow.org/pipeline-sdk-type: kfp\r\n pipelines.kubeflow.org/v2_component: \"true\"\r\n initContainers:\r\n - command: [/bin/mount_launcher.sh]\r\n image: gcr.io/ml-pipeline/kfp-launcher:1.6.4\r\n name: kfp-launcher\r\n mirrorVolumeMounts: true\r\n volumes:\r\n - {name: kfp-launcher}\r\n - name: pipeline-tensorboard-minio\r\n inputs:\r\n parameters:\r\n - {name: log_bucket}\r\n - {name: log_dir}\r\n - {name: minio_endpoint}\r\n - {name: pipeline-name}\r\n - {name: pipeline-output-directory}\r\n - {name: tf_image}\r\n dag:\r\n tasks:\r\n - name: create-tensorboard-visualization\r\n template: create-tensorboard-visualization\r\n arguments:\r\n parameters:\r\n - {name: log_bucket, value: '{{inputs.parameters.log_bucket}}'}\r\n - {name: log_dir, value: '{{inputs.parameters.log_dir}}'}\r\n - {name: minio_endpoint, value: '{{inputs.parameters.minio_endpoint}}'}\r\n - {name: pipeline-name, value: '{{inputs.parameters.pipeline-name}}'}\r\n - {name: pipeline-output-directory, value: '{{inputs.parameters.pipeline-output-directory}}'}\r\n - {name: tf_image, value: '{{inputs.parameters.tf_image}}'}\r\n - name: train\r\n template: train\r\n dependencies: [create-tensorboard-visualization]\r\n arguments:\r\n parameters:\r\n - {name: log_bucket, value: '{{inputs.parameters.log_bucket}}'}\r\n - {name: log_dir, value: '{{inputs.parameters.log_dir}}'}\r\n - {name: minio_endpoint, value: '{{inputs.parameters.minio_endpoint}}'}\r\n - {name: pipeline-name, value: '{{inputs.parameters.pipeline-name}}'}\r\n - {name: pipeline-output-directory, value: '{{inputs.parameters.pipeline-output-directory}}'}\r\n - name: train\r\n container:\r\n args:\r\n - sh\r\n - -c\r\n - (PIP_DISABLE_PIP_VERSION_CHECK=1 python3 -m pip install --quiet --no-warn-script-location\r\n 'minio' || PIP_DISABLE_PIP_VERSION_CHECK=1 python3 -m pip install --quiet\r\n --no-warn-script-location 'minio' --user) && \"$0\" \"$@\"\r\n - sh\r\n - -ec\r\n - |\r\n program_path=$(mktemp)\r\n printf \"%s\" \"$0\" > \"$program_path\"\r\n python3 -u \"$program_path\" \"$@\"\r\n - |\r\n def train(minio_endpoint, log_bucket, log_dir):\r\n # Reference: https://www.tensorflow.org/tensorboard/get_started\r\n import tensorflow as tf\r\n\r\n mnist = tf.keras.datasets.mnist\r\n\r\n (x_train, y_train), (x_test, y_test) = mnist.load_data()\r\n x_train, x_test = x_train / 255.0, x_test / 255.0\r\n\r\n def create_model():\r\n return tf.keras.models.Sequential([\r\n tf.keras.layers.Flatten(input_shape=(28, 28)),\r\n tf.keras.layers.Dense(512, activation='relu'),\r\n tf.keras.layers.Dropout(0.2),\r\n tf.keras.layers.Dense(10, activation='softmax')\r\n ])\r\n\r\n model = create_model()\r\n model.compile(\r\n optimizer='adam',\r\n loss='sparse_categorical_crossentropy',\r\n metrics=['accuracy']\r\n )\r\n\r\n log_dir_local = \"logs/fit\"\r\n tensorboard_callback = tf.keras.callbacks.TensorBoard(\r\n log_dir=log_dir_local, histogram_freq=1\r\n )\r\n\r\n model.fit(\r\n x=x_train,\r\n y=y_train,\r\n epochs=5,\r\n validation_data=(x_test, y_test),\r\n callbacks=[tensorboard_callback]\r\n )\r\n\r\n # Copy the local logs folder to minio.\r\n #\r\n # TODO: we may write a filesystem watch process that continuously copy logs\r\n # dir to minio, so that we can watch live training logs via tensorboard.\r\n #\r\n # Note, although tensorflow supports minio via s3:// protocol. We want to\r\n # demo how minio can be used instead, e.g. the same approach can be used with\r\n # frameworks only support local path.\r\n from minio import Minio\r\n import os\r\n minio_access_key = os.getenv('MINIO_ACCESS_KEY')\r\n minio_secret_key = os.getenv('MINIO_SECRET_KEY')\r\n if not minio_access_key or not minio_secret_key:\r\n raise Exception('MINIO_ACCESS_KEY or MINIO_SECRET_KEY env is not set')\r\n client = Minio(\r\n minio_endpoint,\r\n access_key=minio_access_key,\r\n secret_key=minio_secret_key,\r\n secure=False\r\n )\r\n count = 0\r\n from pathlib import Path\r\n for path in Path(\"logs\").rglob(\"*\"):\r\n if not path.is_dir():\r\n object_name = os.path.join(\r\n log_dir, os.path.relpath(start=log_dir_local, path=path)\r\n )\r\n client.fput_object(\r\n bucket_name=log_bucket,\r\n object_name=object_name,\r\n file_path=path,\r\n )\r\n count = count + 1\r\n print(f'{path} uploaded to minio://{log_bucket}/{object_name}')\r\n print(f'{count} log files uploaded to minio://{log_bucket}/{log_dir}')\r\n\r\n import argparse\r\n _parser = argparse.ArgumentParser(prog='Train', description='')\r\n _parser.add_argument(\"--minio-endpoint\", dest=\"minio_endpoint\", type=str, required=True, default=argparse.SUPPRESS)\r\n _parser.add_argument(\"--log-bucket\", dest=\"log_bucket\", type=str, required=True, default=argparse.SUPPRESS)\r\n _parser.add_argument(\"--log-dir\", dest=\"log_dir\", type=str, required=True, default=argparse.SUPPRESS)\r\n _parsed_args = vars(_parser.parse_args())\r\n\r\n _outputs = train(**_parsed_args)\r\n - --minio-endpoint\r\n - '{{$.inputs.parameters[''minio_endpoint'']}}'\r\n - --log-bucket\r\n - '{{$.inputs.parameters[''log_bucket'']}}'\r\n - --log-dir\r\n - '{{$.inputs.parameters[''log_dir'']}}'\r\n command: [/kfp-launcher/launch, --mlmd_server_address, $(METADATA_GRPC_SERVICE_HOST),\r\n --mlmd_server_port, $(METADATA_GRPC_SERVICE_PORT), --runtime_info_json, $(KFP_V2_RUNTIME_INFO),\r\n --container_image, $(KFP_V2_IMAGE), --task_name, train, --pipeline_name, '{{inputs.parameters.pipeline-name}}',\r\n --pipeline_run_id, $(WORKFLOW_ID), --pipeline_task_id, $(KFP_POD_NAME), --pipeline_root,\r\n '{{inputs.parameters.pipeline-output-directory}}']\r\n env:\r\n - name: MINIO_SECRET_KEY\r\n valueFrom:\r\n secretKeyRef: {key: secretkey, name: mlpipeline-minio-artifact}\r\n - name: MINIO_ACCESS_KEY\r\n valueFrom:\r\n secretKeyRef: {key: accesskey, name: mlpipeline-minio-artifact}\r\n - name: KFP_POD_NAME\r\n valueFrom:\r\n fieldRef: {fieldPath: metadata.name}\r\n - name: KFP_NAMESPACE\r\n valueFrom:\r\n fieldRef: {fieldPath: metadata.namespace}\r\n - name: WORKFLOW_ID\r\n valueFrom:\r\n fieldRef: {fieldPath: 'metadata.labels[''workflows.argoproj.io/workflow'']'}\r\n - {name: KFP_V2_IMAGE, value: '{{inputs.parameters.tf_image}}'}\r\n - {name: KFP_V2_RUNTIME_INFO, value: '{\"inputParameters\": {\"log_bucket\": {\"type\":\r\n \"STRING\", \"value\": \"BEGIN-KFP-PARAM[{{inputs.parameters.log_bucket}}]END-KFP-PARAM\"},\r\n \"log_dir\": {\"type\": \"STRING\", \"value\": \"BEGIN-KFP-PARAM[{{inputs.parameters.log_dir}}]END-KFP-PARAM\"},\r\n \"minio_endpoint\": {\"type\": \"STRING\", \"value\": \"BEGIN-KFP-PARAM[{{inputs.parameters.minio_endpoint}}]END-KFP-PARAM\"}},\r\n \"inputArtifacts\": {}, \"outputParameters\": {}, \"outputArtifacts\": {}}'}\r\n envFrom:\r\n - configMapRef: {name: metadata-grpc-configmap, optional: true}\r\n image: '{{inputs.parameters.tf_image}}'\r\n volumeMounts:\r\n - {mountPath: /kfp-launcher, name: kfp-launcher}\r\n inputs:\r\n parameters:\r\n - {name: log_bucket}\r\n - {name: log_dir}\r\n - {name: minio_endpoint}\r\n - {name: pipeline-name}\r\n - {name: pipeline-output-directory}\r\n metadata:\r\n annotations:\r\n pipelines.kubeflow.org/v2_component: \"true\"\r\n pipelines.kubeflow.org/component_ref: '{}'\r\n pipelines.kubeflow.org/arguments.parameters: '{\"log_bucket\": \"{{inputs.parameters.log_bucket}}\",\r\n \"log_dir\": \"{{inputs.parameters.log_dir}}\", \"minio_endpoint\": \"{{inputs.parameters.minio_endpoint}}\"}'\r\n labels:\r\n pipelines.kubeflow.org/kfp_sdk_version: 1.6.4\r\n pipelines.kubeflow.org/pipeline-sdk-type: kfp\r\n pipelines.kubeflow.org/v2_component: \"true\"\r\n initContainers:\r\n - command: [/bin/mount_launcher.sh]\r\n image: gcr.io/ml-pipeline/kfp-launcher:1.6.4\r\n name: kfp-launcher\r\n mirrorVolumeMounts: true\r\n volumes:\r\n - {name: kfp-launcher}\r\n arguments:\r\n parameters:\r\n - {name: minio_endpoint, value: 'minio-service:9000'}\r\n - {name: log_bucket, value: mlpipeline}\r\n - {name: log_dir, value: 'tensorboard/logs/{{workflow.uid}}'}\r\n - {name: tf_image, value: 'gcr.io/deeplearning-platform-release/tf2-cpu.2-3:latest'}\r\n - {name: pipeline-output-directory, value: ''}\r\n - {name: pipeline-name, value: pipeline-tensorboard-minio}\r\n serviceAccountName: pipeline-runner\r\n\r\n```",
"Workaround:\r\n\r\n```\r\nimport kfp\r\ndef create_sleep_op(image):\r\n sleep_op = kfp.components.load_component_from_file('template.yaml')\r\n sleep_op.component_spec.implementation.container.image = 'my-new-image-'\r\n return sleep_op\r\n```\r\n\r\nIt'll be better not to support overriding image using parameters from outside of the component, because it breaks component interface.",
"Note, because we decided not to support this feature, it is still a breaking change from v1 to v2 compatible. We have some ideas to support the same functionality in a component interface friendly way later."
] | "2021-06-10T11:16:40" | "2021-07-26T03:17:47" | "2021-07-20T03:48:33" | CONTRIBUTOR | null | ### Environment
* KFP SDK version: master
### Steps to reproduce
1. Write any pipeline that tries to override task container image at pipeline level using a parameter, e.g.
https://github.com/kubeflow/pipelines/blob/b3c2351a02231f02ecb3f144d3bade06d854ad18/samples/core/visualization/tensorboard_minio.py#L182-L183
1. compile in v2 compatible mode
1. It fails immediately when running the pipeline
I got 500 api error when running the pipeline, error log on kfp api server is:
```
I0630 07:49:58.838375 6 error.go:247] templates.pipeline-tensorboard-minio.tasks.train templates.train: failed to resolve {{inputs.parameters.tf_image}}
```
so it seems we generated an invalid argo workflow
### Expected result
<!-- What should the correct behavior be? -->
The pipeline should work
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5834/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5834/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5831 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5831/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5831/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5831/events | https://github.com/kubeflow/pipelines/issues/5831 | 917,099,567 | MDU6SXNzdWU5MTcwOTk1Njc= | 5,831 | [v2compat] pipeline with output name containing space cannot compile | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign @chensun ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-10T09:03:16" | "2022-03-03T03:05:14" | "2022-03-03T03:05:14" | CONTRIBUTOR | null | ### Environment
* KFP SDK version: master
### Steps to reproduce
1. Start with https://github.com/kubeflow/pipelines/blob/master/samples/test/reused_component.py,
1. Rename output name from `sum` to `Total Value`.
1. Compile and run in v2 compatible mode.
1. It fails with a KeyError looking for `Total Value`
### Expected result
<!-- What should the correct behavior be? -->
The pipeline should compile and run.
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5831/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5831/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5830 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5830/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5830/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5830/events | https://github.com/kubeflow/pipelines/issues/5830 | 917,091,304 | MDU6SXNzdWU5MTcwOTEzMDQ= | 5,830 | [v2compat] wrong param passed when param contains JSON | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign @chensun ",
"this is obviously a corner case we didn't think of for the \"BEGIN-KFP-PARAM[...]END-KFP-PARAM\" hack",
"There is a corner case where we pass empty string to a component function: https://github.com/kubeflow/pipelines/pull/5938#discussion_r660498207.\r\n\r\nIn the example above, I passed `empty string` to `gcsPath` parameter, but I got `BEGIN-KFP-PARAM[]END-KFP-PARAM` within the component function. This behavior is unexpected to user, so recording this here.",
"Currently FE implements a hack to workaround `MLPipeline UI Metadata` name conversion, we need to make sure to update frontend to remove the hack, once SDK has made corresponding change:\r\n\r\nhttps://github.com/kubeflow/pipelines/pull/5961#discussion_r662785344",
"> Currently FE implements a hack to workaround `MLPipeline UI Metadata` name conversion, we need to make sure to update frontend to remove the hack, once SDK has made corresponding change:\r\n> \r\n> [#5961 (comment)](https://github.com/kubeflow/pipelines/pull/5961#discussion_r662785344)\r\n\r\n@zijianjoy we might consider keeping the sanitization in UI permanently, because artifact naming convention changed when going to KFP v2. In v2, we will no longer sanitize artifact names automatically in SDK.",
"After some investigation, I think I understood the root cause.\r\n\r\n1. Compiler `json.dumps` when encoding runtime info\r\nhttps://github.com/kubeflow/pipelines/blob/07ac566fcbaf12387e5e2bef89a029e5ef183ee6/sdk/python/kfp/compiler/v2_compat.py#L139-L141\r\n At this point, constant text will be encoded once, but text passed from parameters are written as \"{{inputs.parameters.<name>}}\", therefore they won't be JSON encoded. The difference is the root cause of this bug.\r\n2. Launcher tries to JSON encode for the second time, because string value passed from parameters are not JSON encoded: https://github.com/kubeflow/pipelines/blob/bd6350dc2730514b53733be5890426b315d0eda9/v2/component/runtime_info.go#L83-L85\r\n3. Launcher tries to JSON decode, but because of the difference in 1, some part of the parameters are JSON encoded for 1 extra time.",
"Therefore, I can think of two ways to fix:\r\n1. BEGIN-KFP-PARAM token should only be injected wrapping parameter placeholders, but I'm not sure whether further corner cases may exist.\r\n2. (preferred) Design a new way to pass raw data, so that we do not need to play around with JSON encoding.\r\n\r\nI'd like to choose option 2, because I prefer a solid solution.",
"## Proposal\r\n\r\nop.command + op.args will have the following sections:\r\n1. args passed to kfp-launcher\r\n2. a separator \"--\"\r\n3. input parameters in format \"key1=value1\", \"key2=value2\", ... (we need to assume keys cannot contain \"=\" character, is it a fair assumption?)\r\n4. a separator \"--\" as end of arguments passed to launcher\r\n5. (start of op.args) arguments of the original user program command + args\r\n\r\nthis will make it possible to pass parameter values without JSON encoding",
"\r\n> @zijianjoy we might consider keeping the sanitization in UI permanently, because artifact naming convention changed when going to KFP v2. In v2, we will no longer sanitize artifact names automatically in SDK.\r\n\r\nI see, thank you for confirming!"
] | "2021-06-10T08:55:22" | "2021-07-09T17:37:00" | "2021-07-09T05:02:23" | CONTRIBUTOR | null | ### Environment
* KFP SDK version: master branch
### Steps to reproduce
```python
import kfp
from kfp import dsl
from kfp.components import create_component_from_func
@create_component_from_func
def test(json_param: str):
print(json_param)
@dsl.pipeline(name='bug-json-param')
def my_pipeline(
json_param: str = '{"a":"b"}',
value: str = 'c',
):
test(json_param).set_display_name('test1')
test('{"a":"' + f'{value}' + '"}').set_display_name('test2')
if __name__ == '__main__':
kfp.Client().create_run_from_pipeline_func(
my_pipeline,
arguments={},
mode=dsl.PipelineExecutionMode.V2_COMPATIBLE,
)
```
I got the following log for `test2` task (`task1` is expected).
```
{\"a\":\"c\"}
```
### Expected result
<!-- What should the correct behavior be? -->
```
{"a":"c"}
```
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5830/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5830/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5825 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5825/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5825/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5825/events | https://github.com/kubeflow/pipelines/issues/5825 | 916,374,043 | MDU6SXNzdWU5MTYzNzQwNDM= | 5,825 | [UI] Use metadata instead of customProperties to visualize artifact metrics. | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-06-09T16:03:23" | "2021-06-10T20:28:51" | "2021-06-10T20:28:51" | COLLABORATOR | null | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5825/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5825/timeline | null | completed | null | null | false |
|
https://api.github.com/repos/kubeflow/pipelines/issues/5820 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5820/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5820/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5820/events | https://github.com/kubeflow/pipelines/issues/5820 | 915,545,578 | MDU6SXNzdWU5MTU1NDU1Nzg= | 5,820 | [v2compat] cache integration test | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign @capri-xiyue "
] | "2021-06-08T21:39:29" | "2021-07-15T07:25:48" | "2021-07-15T07:25:48" | CONTRIBUTOR | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
### What feature would you like to see?
cache integration test
Set up integration test. One for enabling caching scenario. One for disabling caching scenario.
<!-- Provide a description of this feature and the user experience. -->
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5820/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5820/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5819 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5819/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5819/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5819/events | https://github.com/kubeflow/pipelines/issues/5819 | 915,543,260 | MDU6SXNzdWU5MTU1NDMyNjA= | 5,819 | [v2compat] Fetch cache result from MLMD and put cache result into argo output artifacts/parameters | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-06-08T21:37:15" | "2021-07-09T06:38:23" | "2021-07-09T06:38:23" | CONTRIBUTOR | null | ### Feature Area
### What feature would you like to see?
Fetch cache result from MLMD and put cache result into argo output artifacts/parameters
<!-- Provide a description of this feature and the user experience. -->
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5819/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5819/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5818 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5818/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5818/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5818/events | https://github.com/kubeflow/pipelines/issues/5818 | 915,525,601 | MDU6SXNzdWU5MTU1MjU2MDE= | 5,818 | [v2compat] add enable cache option in v2 compatible mode | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
},
{
"login": "ji-yaqi",
"id": 17338099,
"node_id": "MDQ6VXNlcjE3MzM4MDk5",
"avatar_url": "https://avatars.githubusercontent.com/u/17338099?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ji-yaqi",
"html_url": "https://github.com/ji-yaqi",
"followers_url": "https://api.github.com/users/ji-yaqi/followers",
"following_url": "https://api.github.com/users/ji-yaqi/following{/other_user}",
"gists_url": "https://api.github.com/users/ji-yaqi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ji-yaqi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ji-yaqi/subscriptions",
"organizations_url": "https://api.github.com/users/ji-yaqi/orgs",
"repos_url": "https://api.github.com/users/ji-yaqi/repos",
"events_url": "https://api.github.com/users/ji-yaqi/events{/privacy}",
"received_events_url": "https://api.github.com/users/ji-yaqi/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"fyi: @neuromage @chensun ",
"fixed by https://github.com/kubeflow/pipelines/pull/6032"
] | "2021-06-08T21:20:54" | "2021-07-15T07:38:25" | "2021-07-15T07:38:25" | CONTRIBUTOR | null | ### Feature Area
/area sdk
### What feature would you like to see?
Similar to <KFP V2>{https://github.com/kubeflow/pipelines/blob/28431fc3fdf6b117eaad0a2986e7fa270a50596d/sdk/python/kfp/v2/google/client/client.py#L264}, add enable cache option in v2 compatible mode. Compiler should be able to pass enable cache option to launcher
<!-- Provide a description of this feature and the user experience. -->
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5818/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5818/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5817 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5817/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5817/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5817/events | https://github.com/kubeflow/pipelines/issues/5817 | 915,522,351 | MDU6SXNzdWU5MTU1MjIzNTE= | 5,817 | [v2 compat] DB and API for creating/querying cache entries | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-06-08T21:17:53" | "2021-07-06T02:41:04" | "2021-06-30T18:30:23" | CONTRIBUTOR | null | ### Feature Area
/area backend
### What feature would you like to see?
Set up DB and create API for for creating/querying cache entries
--
</div></b>
<!-- Provide a description of this feature and the user experience. -->
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5817/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5817/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5816 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5816/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5816/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5816/events | https://github.com/kubeflow/pipelines/issues/5816 | 915,505,845 | MDU6SXNzdWU5MTU1MDU4NDU= | 5,816 | [v2compat] generate cache key and calculate hash of the cache key | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | "2021-06-08T21:03:25" | "2021-06-17T02:04:28" | "2021-06-17T02:04:28" | CONTRIBUTOR | null | ### Feature Area
### What feature would you like to see?
generate cache key and calculate hash of the cache key.
key.
Specifically the cache key include:
- the mapping between the input artifact names and MLMD artifact ids
- the mapping between input parameter name and input parameter value
- the mapping between output artifact name and output artifact spec
- the mapping between output parameter name and output parameter spec
- the full execution template/spec.
We will follow [KFP V1](https://github.com/kubeflow/pipelines/blob/43994abb7e07c71084d7b0fbebab8c9e6b7aa33f/backend/src/cache/server/mutation.go#L252) which uses the [sha256](https://pkg.go.dev/crypto/sha256) to generate the hash of the cache key.
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5816/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5816/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5815 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5815/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5815/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5815/events | https://github.com/kubeflow/pipelines/issues/5815 | 915,323,815 | MDU6SXNzdWU5MTUzMjM4MTU= | 5,815 | Cert Manager + Istio + Kubeflow + Azure + LetsEncrypt | {
"login": "pablofiumara-azumo",
"id": 74205824,
"node_id": "MDQ6VXNlcjc0MjA1ODI0",
"avatar_url": "https://avatars.githubusercontent.com/u/74205824?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablofiumara-azumo",
"html_url": "https://github.com/pablofiumara-azumo",
"followers_url": "https://api.github.com/users/pablofiumara-azumo/followers",
"following_url": "https://api.github.com/users/pablofiumara-azumo/following{/other_user}",
"gists_url": "https://api.github.com/users/pablofiumara-azumo/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablofiumara-azumo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablofiumara-azumo/subscriptions",
"organizations_url": "https://api.github.com/users/pablofiumara-azumo/orgs",
"repos_url": "https://api.github.com/users/pablofiumara-azumo/repos",
"events_url": "https://api.github.com/users/pablofiumara-azumo/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablofiumara-azumo/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"I'm working together with @pablofiumara-azumo to get this solved, so the issue can be closed.\r\n\r\n/close",
"@DavidSpek: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubeflow/pipelines/issues/5815#issuecomment-857621354):\n\n>I'm working together with @pablofiumara-azumo to get this solved, so the issue can be closed.\r\n>\r\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>"
] | "2021-06-08T18:10:26" | "2021-06-09T11:38:03" | "2021-06-09T11:38:02" | NONE | null | How can I setup SSL for a Kubeflow installation (using Istio and Cert Manager) on Azure? URL is https://mydns.westus.cloudapp.azure.com/
Thanks in advance | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5815/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5815/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5807 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5807/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5807/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5807/events | https://github.com/kubeflow/pipelines/issues/5807 | 913,449,583 | MDU6SXNzdWU5MTM0NDk1ODM= | 5,807 | [sdk] Component parameters with 'Bool' type cannot be used in conditions ("invalid truth value") | {
"login": "senarvi",
"id": 2337787,
"node_id": "MDQ6VXNlcjIzMzc3ODc=",
"avatar_url": "https://avatars.githubusercontent.com/u/2337787?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/senarvi",
"html_url": "https://github.com/senarvi",
"followers_url": "https://api.github.com/users/senarvi/followers",
"following_url": "https://api.github.com/users/senarvi/following{/other_user}",
"gists_url": "https://api.github.com/users/senarvi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/senarvi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/senarvi/subscriptions",
"organizations_url": "https://api.github.com/users/senarvi/orgs",
"repos_url": "https://api.github.com/users/senarvi/repos",
"events_url": "https://api.github.com/users/senarvi/events{/privacy}",
"received_events_url": "https://api.github.com/users/senarvi/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
}
] | open | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/cc @chensun ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"Bump",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"Is there any workaround or alternative that can be used?",
"Started using Kubeflow after a long while and ran into this problem again with Kubeflow 1.8.22. I think this workaround should work:\r\n\r\n- Make the default value of all Bool parameters False.\r\n- Use isPresent instead of the inputValue condition.\r\n- Never set a parameter to False, i.e. either use the default or True.",
"The workaround gets tricky if you want to pass a boolean pipeline parameter to the component. I thought it would be possible (although ugly) using two `dsl.Condition`s in the pipeline: one `dsl.Condition` is executed when the pipeline parameter is True and passes a True value to the component and the other one is executed when the pipeline parameter is False and doesn't pass the component parameter. However, I couldn't get it to work due to [another bug](https://github.com/kubeflow/pipelines/issues/8203). Maybe it works in KFP 2.0."
] | "2021-06-07T11:31:06" | "2023-07-27T08:36:09" | null | NONE | null | ### Environment
* KFP SDK version:
kfp 1.6.3
kfp-pipeline-spec 0.1.8
kfp-server-api 1.6.0
### Steps to reproduce
Using a boolean parameter in an "if" condition in container arguments used to work in kfp==1.4.0, but kfp==1.6.x gives the following "invalid truth value" error (apparently trying to pass the parameter placeholder to `strtobool()` even if the value is available):
```bash
Traceback (most recent call last):
File "test_case.py", line 25, in <module>
compiler.Compiler().compile(pipeline, 'pipeline.yaml')
File ".../lib/python3.9/site-packages/kfp/compiler/compiler.py", line 1053, in compile
self._create_and_write_workflow(
File ".../lib/python3.9/site-packages/kfp/compiler/compiler.py", line 1106, in _create_and_write_workflow
workflow = self._create_workflow(
File ".../lib/python3.9/site-packages/kfp/compiler/compiler.py", line 896, in _create_workflow
pipeline_func(*args_list, **kwargs_dict)
File "test_case.py", line 22, in pipeline
op()
File ".../lib/python3.9/site-packages/kfp/components/_dynamic.py", line 34, in Component
return dict_func(locals()) # noqa: F821 TODO
File ".../lib/python3.9/site-packages/kfp/components/_components.py", line 343, in create_task_object_from_component_and_pythonic_arguments
return _create_task_object_from_component_and_arguments(
File ".../lib/python3.9/site-packages/kfp/components/_components.py", line 290, in _create_task_object_from_component_and_arguments
task = _container_task_constructor(
File ".../lib/python3.9/site-packages/kfp/dsl/_component_bridge.py", line 302, in _create_container_op_from_component_and_arguments
_attach_v2_specs(task, component_spec, original_arguments)
File ".../lib/python3.9/site-packages/kfp/dsl/_component_bridge.py", line 596, in _attach_v2_specs
resolved_cmd = _resolve_commands_and_args_v2(
File ".../lib/python3.9/site-packages/kfp/dsl/_component_bridge.py", line 442, in _resolve_commands_and_args_v2
resolved_cmd = _components._resolve_command_line_and_paths(
File ".../lib/python3.9/site-packages/kfp/components/_components.py", line 511, in _resolve_command_line_and_paths
expanded_args = expand_argument_list(container_spec.args)
File ".../lib/python3.9/site-packages/kfp/components/_components.py", line 502, in expand_argument_list
expanded_part = expand_command_part(part)
File ".../lib/python3.9/site-packages/kfp/components/_components.py", line 482, in expand_command_part
condition_result_bool = condition_result and strtobool(condition_result) #Python gotcha: bool('False') == True; Need to use strtobool; Also need to handle None and []
File ".../lib/python3.9/distutils/util.py", line 320, in strtobool
raise ValueError("invalid truth value %r" % (val,))
ValueError: invalid truth value "{{$.inputs.parameters['enable']}}"
```
Code to reproduce the problem:
```python
# test_case.py
@dsl.pipeline(name="Pipeline", description="Pipeline")
def pipeline() -> None:
op = components.load_component_from_text(
"""
name: Component
inputs:
- {name: enable, type: Bool, default: False}
implementation:
container:
image: some/container
args:
- if:
cond:
inputValue: enable
then:
- '--enable'
"""
)
op()
if __name__ == '__main__':
compiler.Compiler().compile(pipeline, 'pipeline.yaml')
```
### Expected result
The pipeline is expected to compile. In the code sample, the component would not have any arguments. Calling `op(True)` would add the `--enable` argument to the component. (This is how kfp==1.4.0 works.)
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5807/reactions",
"total_count": 8,
"+1": 8,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5807/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5806 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5806/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5806/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5806/events | https://github.com/kubeflow/pipelines/issues/5806 | 913,362,588 | MDU6SXNzdWU5MTMzNjI1ODg= | 5,806 | [feature] support timeout option for watching | {
"login": "anencore94",
"id": 37469330,
"node_id": "MDQ6VXNlcjM3NDY5MzMw",
"avatar_url": "https://avatars.githubusercontent.com/u/37469330?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anencore94",
"html_url": "https://github.com/anencore94",
"followers_url": "https://api.github.com/users/anencore94/followers",
"following_url": "https://api.github.com/users/anencore94/following{/other_user}",
"gists_url": "https://api.github.com/users/anencore94/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anencore94/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anencore94/subscriptions",
"organizations_url": "https://api.github.com/users/anencore94/orgs",
"repos_url": "https://api.github.com/users/anencore94/repos",
"events_url": "https://api.github.com/users/anencore94/events{/privacy}",
"received_events_url": "https://api.github.com/users/anencore94/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930476737,
"node_id": "MDU6TGFiZWw5MzA0NzY3Mzc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/help%20wanted",
"name": "help wanted",
"color": "db1203",
"default": true,
"description": "The community is welcome to contribute."
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "anencore94",
"id": 37469330,
"node_id": "MDQ6VXNlcjM3NDY5MzMw",
"avatar_url": "https://avatars.githubusercontent.com/u/37469330?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anencore94",
"html_url": "https://github.com/anencore94",
"followers_url": "https://api.github.com/users/anencore94/followers",
"following_url": "https://api.github.com/users/anencore94/following{/other_user}",
"gists_url": "https://api.github.com/users/anencore94/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anencore94/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anencore94/subscriptions",
"organizations_url": "https://api.github.com/users/anencore94/orgs",
"repos_url": "https://api.github.com/users/anencore94/repos",
"events_url": "https://api.github.com/users/anencore94/events{/privacy}",
"received_events_url": "https://api.github.com/users/anencore94/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "anencore94",
"id": 37469330,
"node_id": "MDQ6VXNlcjM3NDY5MzMw",
"avatar_url": "https://avatars.githubusercontent.com/u/37469330?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anencore94",
"html_url": "https://github.com/anencore94",
"followers_url": "https://api.github.com/users/anencore94/followers",
"following_url": "https://api.github.com/users/anencore94/following{/other_user}",
"gists_url": "https://api.github.com/users/anencore94/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anencore94/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anencore94/subscriptions",
"organizations_url": "https://api.github.com/users/anencore94/orgs",
"repos_url": "https://api.github.com/users/anencore94/repos",
"events_url": "https://api.github.com/users/anencore94/events{/privacy}",
"received_events_url": "https://api.github.com/users/anencore94/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Welcome contribution! This seems useful",
"/assign @anencore94 "
] | "2021-06-07T09:55:25" | "2021-06-23T21:13:19" | "2021-06-23T21:13:19" | MEMBER | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
<!-- /area backend -->
/area sdk
<!-- /area samples -->
<!-- /area components -->
### What feature would you like to see?
- When we use `kfp run submit -w`, we have to wait forever when run stay at pending.
- However, I'd like to specify the timeout option with it.
### What is the use case or pain point?
- `kfp run submit -t 60` will wait 60 seconds max, until run be completed
- it would use [kfp client's wait_for_run_completion function](https://github.com/kubeflow/pipelines/blob/6a1b841db923e39016f5c6e66eac8698af27831d/sdk/python/kfp/_client.py#L922)
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
If you guys agree, I'd like to implement this feature.
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5806/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5806/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5804 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5804/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5804/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5804/events | https://github.com/kubeflow/pipelines/issues/5804 | 912,857,019 | MDU6SXNzdWU5MTI4NTcwMTk= | 5,804 | OOM error when running a pipeline job | {
"login": "jayadeep-jayaraman",
"id": 53975210,
"node_id": "MDQ6VXNlcjUzOTc1MjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/53975210?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jayadeep-jayaraman",
"html_url": "https://github.com/jayadeep-jayaraman",
"followers_url": "https://api.github.com/users/jayadeep-jayaraman/followers",
"following_url": "https://api.github.com/users/jayadeep-jayaraman/following{/other_user}",
"gists_url": "https://api.github.com/users/jayadeep-jayaraman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jayadeep-jayaraman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayadeep-jayaraman/subscriptions",
"organizations_url": "https://api.github.com/users/jayadeep-jayaraman/orgs",
"repos_url": "https://api.github.com/users/jayadeep-jayaraman/repos",
"events_url": "https://api.github.com/users/jayadeep-jayaraman/events{/privacy}",
"received_events_url": "https://api.github.com/users/jayadeep-jayaraman/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Okay I found a workaround by leveraging `experimental.run_as_aiplatform_custom_job` where I could specify the machine type."
] | "2021-06-06T15:05:07" | "2021-06-07T15:42:23" | "2021-06-07T15:42:23" | NONE | null | I am currently using Vertex AI pipelines and using `component` decorator to preprocess data. When I submit the pipeline I am getting OOM error, I checked the documentation and couldn't find a way to specify `machineType` in `create_component_from_func`.
Is the option to resolve the issue is by submitting a CustomTrainingJob ?
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5804/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5804/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5803 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5803/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5803/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5803/events | https://github.com/kubeflow/pipelines/issues/5803 | 912,765,055 | MDU6SXNzdWU5MTI3NjUwNTU= | 5,803 | [v2compat] use declared inputs/outputs in MLMD model | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Confirmed this is intentional for us, because KFP doesn't have non-declared inputs and outputs. So this is simpler for us.\n\nWe might need a doc to introduce KFP MLMD spec differences from the original spec.",
"/cc @zijianjoy \nThis answers one of your questions"
] | "2021-06-06T10:13:14" | "2021-07-07T02:16:13" | "2021-07-07T02:16:13" | CONTRIBUTOR | null | > For example, the DECLARED_INPUT and DECLARED_OUTPUT events are part of the signature of an execution.
https://github.com/google/ml-metadata/blob/47150524ee5ceee9766a034c4fbe5427440dd79e/ml_metadata/proto/metadata_store.proto#L100-L138
> However, until now, because KFP does not have the non-declared inputs/outputs concept, we are logging all inputs & outputs as pure inputs and outputs. We need to confirm whether this is sth we need to change.
Figure out what should be KFP's canonical way to log input/output events | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5803/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5803/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5801 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5801/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5801/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5801/events | https://github.com/kubeflow/pipelines/issues/5801 | 911,236,774 | MDU6SXNzdWU5MTEyMzY3NzQ= | 5,801 | Update KFP samples to use types that are compatible in v2. | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1126834402,
"node_id": "MDU6TGFiZWwxMTI2ODM0NDAy",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/components",
"name": "area/components",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1260031624,
"node_id": "MDU6TGFiZWwxMjYwMDMxNjI0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/samples",
"name": "area/samples",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
},
{
"login": "NikeNano",
"id": 22057410,
"node_id": "MDQ6VXNlcjIyMDU3NDEw",
"avatar_url": "https://avatars.githubusercontent.com/u/22057410?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NikeNano",
"html_url": "https://github.com/NikeNano",
"followers_url": "https://api.github.com/users/NikeNano/followers",
"following_url": "https://api.github.com/users/NikeNano/following{/other_user}",
"gists_url": "https://api.github.com/users/NikeNano/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NikeNano/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NikeNano/subscriptions",
"organizations_url": "https://api.github.com/users/NikeNano/orgs",
"repos_url": "https://api.github.com/users/NikeNano/repos",
"events_url": "https://api.github.com/users/NikeNano/events{/privacy}",
"received_events_url": "https://api.github.com/users/NikeNano/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign",
"Lets hold this for now given the new focus on KFP parity and compatibility with existing customer components and pipelines.",
">An example could be the type GCPProjectID. It is meant to be a string parameter instead of an artifact.\r\n\r\nGCPProjectID type is not the same as a string. Just like an integer or boolean or date it can be *stored* as string, but that does not make it a string.\r\n\r\n`GCPProjectID` is useful for the pipeline parameters. The UX is supposed to show the GCP Project picker control and pre-select the current project (has not been implemented yet).\r\n\r\n`GcsPath` has validator for the URI format. It could also benefit from a GCS bucket picker.\r\n\r\n>We should update our components and samples to change such types to String instead.\r\n\r\nI'm not sure we want to downgrade all types and lose all type information. There is too much confusion when all types are replaced with String.\r\n\r\nMLMD already has the technical ability to store type information for arbitrary execution properties and we should take advantage of this. Each MLMD custom property is a protobuf Value , which can hold arbitrary JSON structures. We can use that to store arbitrary typed data as `{\"type\": \"GCPProjectID\", \"value\": \"chesu\"}`.",
"I'm not denying there's potential value for custom parameter types. But often they are overuse of types. `GCPProjectID` and `GCSPath` can be replaced with `String` with little loss of functionality as of today -- the `open_schema_validator` for `GCSPath`, if I'm not mistaken helps only on value present at compile time but not value produced as runtime; and the GCP Project picker is an interesting idea I didn't hear before, do you have bug# or doc for this proposal?\r\n\r\nThe issue of keeping the usage of these types is that they would break right now on Vertex AI and KFP v2 compatible mode. And I think it's a bigger issue that needs to be addressed right now. I'd rather we \"downgrade\" such types but revert the change in the future than having samples not working out of the box. \r\n\r\n\r\n\r\n",
"There are many reasons why computer languages introduce support for typing. C++ is not using `void*` for every pointer even though that would have been possible. Same with the artifacts. Artifact is just a file (or directory of files), but nobody is proposing to remove all artifact typing and replace everything with `Blob` or `File`.\r\n\r\nBut this is exactly what's happening here. The v2 arbitrary takes half of the KFP types and destroys the type information, forcing them to become untyped strings.\r\n\r\nThis is especially apparent when you look at MLMD: In KFP v1 all outputs are properly recorded as MLMD artifacts. They're recorded as `CSV`, `Date`, `URL`, `JsonObject`, `URL`, `XGBoostModel` etc, not `String`, `String`, `String`, `String`, `String`.\r\n\r\n>The issue of keeping the usage of these types is that they would break right now on Vertex AI and KFP v2 compatible mode.\r\n\r\nAs demonstrated by the Managed Pipeline Runner (May 2020) and the recent fix PRs (https://github.com/kubeflow/pipelines/pull/5478) the architectural limitations of the Cloud IR can be worked around, so that they do not frustrate the users.\r\n\r\n>I'd rather we \"downgrade\" such types \r\n\r\nWe cannot really downgrade the user content. Instead of forcing 1000 people to downgrade their code, we might want to upgrade our code instead.\r\n",
"> There are many reasons why computer languages introduce support for typing. C++ is not using `void*` for every pointer even though that would have been possible. \r\n\r\nDon't think it's a good comparison. We aren't creating a programming language, but a DSL for a specialized application -- a pipeline that runs containerized apps. It's not our goal to reach parity with a common programming language.\r\n\r\n> Same with the artifacts. Artifact is just a file (or directory of files), but nobody is proposing to remove all artifact typing and replace everything with `Blob` or `File`.\r\n> \r\n\r\nArtifact is not just a file, but also the metadata associated with it. Different artifact types have different sets of operations ([source](https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/io_types.py)). The types do matter. \r\n\r\nIn comparison, some \"types\" your mentioned above are just aliases to the string type. For example, when you define a component input with type `Date` -- BTW, `Date` is neither a defined type in KFP DSL nor a defined type in Python -- the component never get a `datetime` object or similar, but always a string value whose content is meant to be a date representation. Whether the content is actually a valid date or not doesn't even matter. And there's no date-related operations for such a type. Same for `CSV` and `URL`, they are just some arbitrary names that carry no meaning from our system's point of view. One component author may write the type as `URL`, while others could write `Url`, and they are viewed as different types, thus incompatible with each other. \r\n\r\n> But this is exactly what's happening here. The v2 arbitrary takes half of the KFP types and destroys the type information, forcing them to become untyped strings.\r\n> \r\n\r\nSince KFP v1 \"types\" can be arbitrary names, we can't quantify \"half\" here. \r\n\r\n> This is especially apparent when you look at MLMD: In KFP v1 all outputs are properly recorded as MLMD artifacts. They're recorded as `CSV`, `Date`, `URL`, `JsonObject`, `URL`, `XGBoostModel` etc, not `String`, `String`, `String`, `String`, `String`.\r\n> \r\n\r\nAs said above, `CSV`, `Date`, `URL` are not real types but meant to be aliases to string type. I tend to agree that using such \"types\" may improve code readability over using `String`, although in some cases they also seem to be over-use of typing. Allowing arbitrary user provided names as types could be troublesome. With our current DSL syntax, there's no good way to decide whether an arbitrary name should be a parameter type or an artifact type. I recall you also agreed on 1) arbitrary unknown types should be treated as artifact types by default for maximum compatibility; 2) It's not a good idea to whitelist some arbitrary names as parameter types.\r\n`JsonObject` is supported like an alias to `dict` type, which is treated as a parameter type. User can keep using `JsonObject` as the type. And with the new v2 `@component` decorator, they can pass a Python dict object instead of a serialized string.\r\n`XGBoostModel` should really be an artifact type, which is the current behavior -- it is treated as a generic artifact. Supporting custom artifact types is on our roadmap, but supporting user defined parameter types is not.\r\n\r\n> > The issue of keeping the usage of these types is that they would break right now on Vertex AI and KFP v2 compatible mode.\r\n> \r\n> As demonstrated by the Managed Pipeline Runner (May 2020) and the recent fix PRs (#5478) the architectural limitations of the Cloud IR can be worked around, so that they do not frustrate the users.\r\n> \r\n\r\nI don't know enough about \"Managed Pipeline Runner (May 2020)\", but #5478 does not fix the issue discussed here. This has been discussed several times internally and externally -- it does special handling for certain cases but cannot address all cases uniformly. Our team has decided not to move forward this PR. \r\n\r\n> > I'd rather we \"downgrade\" such types\r\n> \r\n> We cannot really downgrade the user content. Instead of forcing 1000 people to downgrade their code, we might want to upgrade our code instead.\r\n\r\n\"Downgrade\" is the word you used. I quoted, and argued there's little lose of functionality as of today. The features you mentioned about project picker etc. are still up in the air, which I don't even see the proposal let alone the timeline. Again, my philosophy here is that it's more important to make our samples work today than preserving the incompatible factors with the hope that they could be compatible and useful in the future.\r\n\r\nThe issue reflect not only my own opinion but the consensus from the team.\r\n\r\n",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-04T07:55:33" | "2022-03-03T04:05:14" | "2022-03-03T04:05:14" | COLLABORATOR | null | KFP SDK v2 has the distinction between Artifacts vs. Parameters. And they are decided by the input/output type annotation.
See the doc for more details: https://www.kubeflow.org/docs/components/pipelines/sdk/v2/component-development/#designing-a-pipeline-component
Some of our existing components or samples may use types that are intended to be parameters but would result as artifacts instead when compiling to v2. An example could be the type [`GCPProjectID`](https://github.com/kubeflow/pipelines/blob/1c66f93f5149a8d5ed7f33895d3ebc01e662d837/components/gcp/bigquery/query/to_CSV/component.yaml#L30). It is meant to be a string parameter instead of an artifact. We should update our components and samples to change such types to `String` instead.
/area samples
/area components
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5801/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5801/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5798 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5798/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5798/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5798/events | https://github.com/kubeflow/pipelines/issues/5798 | 911,095,194 | MDU6SXNzdWU5MTEwOTUxOTQ= | 5,798 | [sdk] Support artifact custom types in V2 compatible mode | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Thank you @zijianjoy! for starting the issue\r\n\r\nslightly adjusting some wordings",
"Several options for open discussion:\r\n* Add new system artifact types for HTML, Markdown, etc in https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/io_types.py.\r\n* Use duck typing to determine type, e.g. if metadata.type == 'HTML', we treat it as HTML artifact.",
">Use duck typing to determine type, e.g. if metadata.type == 'HTML', we treat it as HTML artifact.\r\n\r\nPerhaps we can start with this.\r\n\r\nWe'll need the ability to preserve the original types names for all custom artifact types, so adding system types might not be feasible or scalable.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"We have determined to use HTML and Markdown types."
] | "2021-06-04T04:01:59" | "2021-10-07T17:11:00" | "2021-10-07T17:11:00" | COLLABORATOR | null | Reference: https://github.com/kubeflow/pipelines/issues/5668
Blocks: https://github.com/kubeflow/pipelines/issues/3970
In KFP v1, we log output artifact types to MLMD as annotated in DSL. KFP UI can use it to visualize HTML, Markdown, etc as planned in https://github.com/kubeflow/pipelines/issues/3970. However, in KFP v2 compatible mode, such artifact type is `system.Artifact`. We are not able to retrieve type name from component definition in UI.
In order to support visualization compatibility in V2 compatible mode, we need to support custom artifact types from SDK. Once UI can retrieve artifact type from MLMD, we can visualize HTML/Markdown according to the artifact type.
cc @Bobgy @Ark-kun
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5798/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5798/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5794 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5794/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5794/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5794/events | https://github.com/kubeflow/pipelines/issues/5794 | 910,722,547 | MDU6SXNzdWU5MTA3MjI1NDc= | 5,794 | [frontend] Upgrade react-scripts to v4 | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930619516,
"node_id": "MDU6TGFiZWw5MzA2MTk1MTY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/frontend",
"name": "area/frontend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
}
] | closed | false | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-06-03T17:43:34" | "2021-06-23T07:35:32" | "2021-06-23T07:35:32" | COLLABORATOR | null |
### Steps to reproduce
We are adding ad-hoc fix if we cannot upgrade to latest version of react-scripts: https://github.com/kubeflow/pipelines/blob/0b32f9f9d8a572d48257f06c3b0683c047c027f2/frontend/src/components/tabs/MetricsTab.test.tsx#L222-L224.
### Expected result
We should upgrade react-scripts and remove ad-hoc fix.
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
https://github.com/testing-library/dom-testing-library/issues/477
cc @Bobgy
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5794/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5794/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5791 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5791/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5791/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5791/events | https://github.com/kubeflow/pipelines/issues/5791 | 910,566,178 | MDU6SXNzdWU5MTA1NjYxNzg= | 5,791 | [UI] add link from execution to KFP run | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
},
{
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign @zijianjoy \r\nlogging an improvement I just came up with, I think we can add more links like this, to make KFP UI inter-connected. For any resource shown on the UI, we can link to a page where we can observe its details.",
"Thank you Yuan!\r\n\r\nI confirm that we can get the related `kfp.PipelineRun` context using `Execution ID`. However, I don't see custom properties for pipeline run ID, is there a reference to the code for adding this property?",
"You are right, it's not currently logged there.\nLet me add it first",
"Fixed by https://github.com/kubeflow/pipelines/pull/6556"
] | "2021-06-03T14:45:50" | "2021-09-16T00:13:56" | "2021-09-16T00:13:56" | CONTRIBUTOR | null | A KFP task execution has one context of KFP run. So it's possible to get the related KFP run context (type `kfp.PipelineRun`), and extract run id from the context's custom properties.
After that, we can generate a link to the run and show it on MLMD UI. | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5791/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5791/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5790 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5790/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5790/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5790/events | https://github.com/kubeflow/pipelines/issues/5790 | 910,563,255 | MDU6SXNzdWU5MTA1NjMyNTU= | 5,790 | [v2compat] remove redundant fields from execution custom properties | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 942985146,
"node_id": "MDU6TGFiZWw5NDI5ODUxNDY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/XS",
"name": "size/XS",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"They should be kept"
] | "2021-06-03T14:42:47" | "2021-06-21T08:31:29" | "2021-06-21T08:31:29" | CONTRIBUTOR | null | “pipeline_name”, “pipeline_run_id”
These fields are already present in pipeline/pipeline run contexts, so they are unnecessary | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5790/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5790/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5789 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5789/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5789/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5789/events | https://github.com/kubeflow/pipelines/issues/5789 | 910,562,081 | MDU6SXNzdWU5MTA1NjIwODE= | 5,789 | [v2compat] log MLMD artifact state during execution | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1116354964,
"node_id": "MDU6TGFiZWwxMTE2MzU0OTY0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/S",
"name": "size/S",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-06-03T14:41:34" | "2021-07-09T07:31:23" | "2021-07-09T07:31:23" | CONTRIBUTOR | null | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5789/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5789/timeline | null | completed | null | null | false |
|
https://api.github.com/repos/kubeflow/pipelines/issues/5788 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5788/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5788/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5788/events | https://github.com/kubeflow/pipelines/issues/5788 | 910,560,621 | MDU6SXNzdWU5MTA1NjA2MjE= | 5,788 | [v2compat] move component emitted metadata to metadata struct field | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 942985146,
"node_id": "MDU6TGFiZWw5NDI5ODUxNDY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/XS",
"name": "size/XS",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-06-03T14:39:56" | "2021-06-08T05:37:45" | "2021-06-08T05:37:45" | CONTRIBUTOR | null | /size m | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5788/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5788/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5783 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5783/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5783/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5783/events | https://github.com/kubeflow/pipelines/issues/5783 | 910,073,385 | MDU6SXNzdWU5MTAwNzMzODU= | 5,783 | [feature] How can I delete a run completely, including the records in the cachedb and metadb mysql database? | {
"login": "Shuai-Xie",
"id": 18352713,
"node_id": "MDQ6VXNlcjE4MzUyNzEz",
"avatar_url": "https://avatars.githubusercontent.com/u/18352713?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Shuai-Xie",
"html_url": "https://github.com/Shuai-Xie",
"followers_url": "https://api.github.com/users/Shuai-Xie/followers",
"following_url": "https://api.github.com/users/Shuai-Xie/following{/other_user}",
"gists_url": "https://api.github.com/users/Shuai-Xie/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Shuai-Xie/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Shuai-Xie/subscriptions",
"organizations_url": "https://api.github.com/users/Shuai-Xie/orgs",
"repos_url": "https://api.github.com/users/Shuai-Xie/repos",
"events_url": "https://api.github.com/users/Shuai-Xie/events{/privacy}",
"received_events_url": "https://api.github.com/users/Shuai-Xie/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | open | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"I guess the problem may arise from the mechanism of **Argo**. Because kfp will add suffix for runs with the same name by default. By the way, is the suffix generated uniquely by taking the previously generated suffixes into consideration?\r\n\r\nI submit 4 runs with the same **RUN_NAME** as `add_two_numbers`. The kfp will append a unique suffix for each run.\r\n\r\n\r\n\r\ncode\r\n\r\n```py\r\nimport kfp\r\nimport kfp.dsl as dsl\r\nfrom kfp.components import func_to_container_op\r\nfrom typing import NamedTuple\r\n\r\nEXP_NAME = 'demo'\r\nRUN_NAME = 'add_two_numbers'\r\n\r\n\r\n@func_to_container_op\r\ndef add(a: int, b: int) -> NamedTuple('output', [('func_name', str), ('result', int)]):\r\n from collections import namedtuple\r\n output = namedtuple('output', ['func_name', 'result'])\r\n return output('add_two_numbers', a + b)\r\n\r\n\r\n@func_to_container_op\r\ndef show_result(func_name, result):\r\n print(f'{func_name} result: {result}')\r\n\r\n\r\n@dsl.pipeline(name=RUN_NAME)\r\ndef pipeline_func(a: int, b: int):\r\n add_task = add(a, b)\r\n show_result(add_task.outputs['func_name'], add_task.outputs['result'])\r\n\r\n\r\nif __name__ == '__main__':\r\n client = kfp.Client(host='my_k8s_master_ip:8888', namespace='kubeflow')\r\n client.create_run_from_pipeline_func(pipeline_func,\r\n arguments={\r\n 'a': 1,\r\n 'b': 100\r\n },\r\n experiment_name=EXP_NAME,\r\n run_name=RUN_NAME)\r\n print('submit pipeline in pod')\r\n```",
"I'm too unable to clear all the artifacts and executions for deleted runs.",
"We plan to implement deleting cachedb when deleting a run record in V2 compatible mode. However, currently MLMD doesn't support deleting metadb in mysql database, you can file issue to MLMD repo.",
"https://github.com/google/ml-metadata",
"Cleaning up MLMD entries requires upstream feature request: https://github.com/google/ml-metadata/issues/69",
"reassigned it to @chensun ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"@stale this is still important",
"> \r\n\r\n@Shuai-Xie What are you passing to `RunServiceApi()` to correctly authenticate to your kfp instance?\r\n\r\nI'm currently using the following but keep getting \"None\" as a response from list_runs\r\n\r\n```\r\nrun_api = RunServiceApi(kfp_server_api.ApiClient(kfp_server_api.Configuration(\r\n host = \"https://<my_kfp_hostname>\"\r\n)))\r\n```\r\n\r\nAny idea what's going on here?"
] | "2021-06-03T04:06:51" | "2022-08-03T23:14:44" | null | NONE | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
/area backend
Currently, I can use the `kfp` Python SDK to delete runs by following codes.
```py
from kfp_server_api.api.run_service_api import RunServiceApi
run_api = RunServiceApi()
def list_all_runs(sort_by='name'):
list_runs_rsp = run_api.list_runs(sort_by=sort_by)
runs = list_runs_rsp.runs
if runs is None:
print('no runs')
else:
print('list runs')
for run in runs:
print(run.id, run.name)
return runs
def delete_all_runs(runs):
if runs is not None:
print('delete runs')
for run in runs:
print('delete', run.name)
run_api.delete_run(id=run.id)
if __name__ == '__main__':
runs = list_all_runs()
delete_all_runs(runs)
list_all_runs()
```
**However, I find there are still many artifacts not cleared even if I have deleted all the runs, which may have an impact on the runs submitted later if the run names are the same. Supposing we have two submitted runs both named `add_two_numbers`. The component states of the latter run may use the states of the earlier one. I mean the component state of the latter run may be `Succeed` when the run just starts as it uses the state of the earlier one.**
A great number of cache and meta records are not cleared in mysql database.
```mysql
# exec into the kubeflow mysql pod, and run the following queries.
mysql> show databases;
+--------------------+
| Database |
+--------------------+
| information_schema |
| cachedb | # new
| metadb | # new
| mlpipeline | # new
| mysql |
| performance_schema |
| sys |
+--------------------+
7 rows in set (0.00 sec)
# cache db
mysql> show tables;
+-------------------+
| Tables_in_cachedb |
+-------------------+
| execution_caches |
+-------------------+
1 row in set (0.00 sec)
mysql> select count(*) from execution_caches;
+----------+
| count(*) |
+----------+
| 204 | # many cache records
+----------+
1 row in set (0.00 sec)
# meta db
mysql> show tables;
+-------------------+
| Tables_in_metadb |
+-------------------+
| Artifact |
| ArtifactProperty |
| Association |
| Attribution |
| Context |
| ContextProperty |
| Event |
| EventPath |
| Execution |
| ExecutionProperty |
| MLMDEnv |
| ParentContext |
| ParentType |
| Type |
| TypeProperty |
+-------------------+
15 rows in set (0.01 sec)
mysql> select count(*) from Artifact;
+----------+
| count(*) |
+----------+
| 395 | # many meta records
+----------+
1 row in set (0.01 sec)
```
<!-- /area sdk -->
<!-- /area samples -->
<!-- /area components -->
### What feature would you like to see?
<!-- Provide a description of this feature and the user experience. -->
If I delete a run, the records in the cachedb and metadb mysql database should be deleted, too.
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
**Pain Point:** Supposing we have two submitted runs both named `add_two_numbers`. The component states of the latter run may use the states of the earlier one, which may make the latter run not execute normally.
### Is there a workaround currently?
<!-- Without this feature, how do you accomplish your task today? -->
Maybe directly delete the records in mysql by myself.
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5783/reactions",
"total_count": 9,
"+1": 9,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5783/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5779 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5779/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5779/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5779/events | https://github.com/kubeflow/pipelines/issues/5779 | 909,411,003 | MDU6SXNzdWU5MDk0MTEwMDM= | 5,779 | [release] 1.7.0 tracker | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Updated to 1.7.0 release, because we have big changes like upgrading MLMD store to 1.0.0",
"https://github.com/kubeflow/testing/commit/03c625828ac9cc13283bd226371280b0f5704c09\r\nupdated kfp-ci test cluster to 1.7.0-alpha.2 for further testing (with argo v3.1.1)",
"Issue: #6294\r\n\r\nkfp gcp marketplace -- support section should include github issues, instead of slack channel, because maintainers only check github issues regularly. Also, we should add a link to documentations.\r\n\r\n",
"Issue: https://github.com/kubeflow/pipelines/issues/6294\r\n\r\nmkp \"use emissary executor\" option tool tip is malformed, we cannot use markdown there:\r\n\r\n",
"Issue: https://github.com/kubeflow/pipelines/issues/6306\r\n\r\nFR: add v2 DSL sample to the \"Getting Started\" page\r\n\r\nThe sample was added as a built-in Pipeline sample. We should add it to the \"Getting Started\" page as well.\r\n\r\nEDIT:\r\nsimilar FR by @Bobgy: add v2 DSL documentation to \"Getting Started\" page",
"Issue: https://github.com/kubeflow/pipelines/issues/6307\r\n\r\npipeline root parameter is called `pipeline-output-directory` in KFP UI/SDK\r\ncan we rename it to `pipeline-root` to be consistent with SDK API?",
"EDIT: already fixed, see https://github.com/kubeflow/pipelines/issues/5779#issuecomment-897232373\r\n\r\nRunning the sample that adds integers passes the 1st time, but fails the 2nd time:\r\n**F0811 23:31:33.486213 15 main.go:50] Failed to execute component: failed to store output parameter value from cache: failed to parse parameter name=\"Output\" value =15 to double: %!w(<nil>)**\r\n\r\nhttps://2d99063a196f3ce0-dot-us-central1.pipelines.googleusercontent.com/#/runs/details/4de32ffc-f51f-4fc5-95d2-d084213d9f56\r\n```\r\nimport kfp\r\nimport kfp.dsl as dsl\r\nfrom kfp.v2.dsl import component\r\n\r\n@component\r\ndef add(a: float, b: float) -> float:\r\n '''Calculates sum of two arguments'''\r\n return a + b\r\n\r\n@dsl.pipeline(\r\n name='addition-pipeline',\r\n description='An example pipeline that performs addition calculations.',\r\n# pipeline_root='gs://my-pipeline-root/example-pipeline'\r\n)\r\ndef add_pipeline(a: float=1, b: float=7):\r\n add_task = add(a, b)\r\n\r\nfrom kfp import compiler\r\ncompiler.Compiler(mode=kfp.dsl.PipelineExecutionMode.V2_COMPATIBLE).compile(pipeline_func=add_pipeline, package_path='pipeline.yaml')\r\n\r\nclient.create_run_from_pipeline_func(\r\n add_pipeline,\r\n arguments={'a': 7, 'b': 8},\r\n mode=kfp.dsl.PipelineExecutionMode.V2_COMPATIBLE,\r\n)\r\n```",
"I think above error was fixed by https://github.com/kubeflow/pipelines/commit/2b78d16e03b1f0024389135af7f95807bb1d6354#diff-e5ea1eac6ea305b6e11fb743d381b3d9189a086e1a88ac8bf53bf64add225977L328-R330.\r\nWe just need to release KFP SDK 1.7.1 with v2 compatible.",
"The status icon doesn't get updated until refresh the page. (Is this not supported yet or a bug?)\r\n\r\n",
"labels name is a bit confusing:\r\npipelines.kubeflow.org/cache_enabled: 'true'\r\npipelines.kubeflow.org/enable_caching: 'true'\r\n\r\nMaybe we should add a documentation for this two labels.",
"> labels name is a bit confusing:\r\n> pipelines.kubeflow.org/cache_enabled: 'true'\r\n> pipelines.kubeflow.org/enable_caching: 'true'\r\n> \r\n> Maybe we should add a documentation for this two labels.\r\n\r\npipelines.kubeflow.org/cache_enabled: 'true' is for v1 and pipelines.kubeflow.org/enable_caching: 'true' is for v2 compatible and v2. We should document it somewhere\r\n",
"PR: https://github.com/kubeflow/pipelines/pull/6309\r\n\r\nWhen I deploy a new AI Platform Pipelines cluster with managed storage, the v2 compatible tutorial does not work out of the box, because it's still defaulting to minio://mlpipeline bucket, but the bucket doesn't exist.\r\n\r\n> F0811 23:48:42.309367 20 main.go:72] Failed to execute component: failed to upload output artifact \"output_dataset_one\" to remote storage URI \"minio://mlpipeline/v2/artifacts/pipeline/[Tutorial] V2 lightweight Python components/31b88af6-8aad-45a1-aed8-58c935ea3fb5/preprocess/output_dataset_one\": uploadFile(): unable to complete copying \"/minio/mlpipeline/v2/artifacts/pipeline/[Tutorial] V2 lightweight Python components/31b88af6-8aad-45a1-aed8-58c935ea3fb5/preprocess/output_dataset_one\" to remote storage \"pipeline/[Tutorial] V2 lightweight Python components/31b88af6-8aad-45a1-aed8-58c935ea3fb5/preprocess/output_dataset_one\": failed to close Writer for bucket: blob (key \"pipeline/[Tutorial] V2 lightweight Python components/31b88af6-8aad-45a1-aed8-58c935ea3fb5/preprocess/output_dataset_one\") (code=Unknown): AccessDenied: Access Denied.\r\n\tstatus code: 403, request id: 169A656A37803974, host id: \r\n\r\nfix: we should configure default pipeline root to GCS, when managed storage is enabled.\r\n",
"Issue: https://github.com/kubeflow/pipelines/issues/6308\r\n\r\nUI bug, for v2 compatible mode, output artifacts have URI \"gcs://xxxx\", but it should be \"gs://xxxx\", when using gcs bucket as pipeline root.\r\n\r\n\r\n",
"Compiling the Vertex Pipeline sample produced an error:\r\n...\r\n/opt/conda/lib/python3.7/site-packages/kfp/compiler/v2_compat.py in update_op(op, pipeline_name, pipeline_root, launcher_image)\r\n 127 k8s_client.V1EnvFromSource(config_map_ref=config_map_ref))\r\n 128 \r\n--> 129 op.arguments = list(op.container_spec.command) + list(op.container_spec.args)\r\n 130 \r\n 131 runtime_info = {\r\n\r\nAttributeError: 'NoneType' object has no attribute 'command'",
"My attempt to fix the TFX taxi prediction tutorial issue: I tried to download tfx dependency from the first cell of https://github.com/kubeflow/pipelines/blob/master/samples/core/parameterized_tfx_oss/taxi_pipeline_notebook.ipynb, I removed the tfx version specification flag:\r\n\r\n```\r\n!python3 -m pip install pip --upgrade --quiet --user\r\n```\r\n\r\nI tried this as well:\r\n\r\n```\r\npip install tfx\r\n```\r\n\r\nbut it has been very slow on my notebook to finish the download. And I cannot run them locally because tfx supports ubuntu and linux only: https://github.com/tensorflow/tfx/issues/1229. \r\n\r\n",
"How should cache work when everything is same except the pipeline_root?\r\nFor example, \r\npipeline #1 uses minio://xxxx as the pipeline_root\r\npipeline #2 uses gs://xxxx as the pipeline_root\r\nother configs of pipeline#1 and pipeline#2 are same.\r\nNow pipeline #2 will hit the cache of pipeline #1 but it won't use the pipeline root under gs://xxxx, it will use the pipeline root under minio://xxxx as what pipeline#1 does.\r\n\r\nDiscussed with @Bobgy @IronPan, this is the expected behavior.\r\n\r\nEDIT by @Bobgy :\r\nHowever, before implementing support for downloading artifacts not from the pipeline root, the pipeline still breaks.\r\nTODOs:\r\n* [ ] add this as a known caveat\r\n* [ ] when supporting importer, we need to do the same fix",
"Fix postsubmit tests: https://github.com/kubeflow/pipelines/commits/master",
"We need documentation for pipeline root\r\n\r\nhttps://github.com/kubeflow/pipelines/issues/6310",
"@rui5i yes, that's expected behavior for now.\r\ncc @zijianjoy to consider as a FR.\r\n\r\nhttps://github.com/kubeflow/pipelines/issues/5779#issuecomment-897233672",
"> @rui5i yes, that's expected behavior for now.\r\n> cc @zijianjoy to consider as a FR.\r\n> \r\n> [#5779 (comment)](https://github.com/kubeflow/pipelines/issues/5779#issuecomment-897233672)\r\n\r\n@Bobgy @rui5i Sounds good, created https://github.com/kubeflow/pipelines/issues/6317 to track this issue.",
"I got the following errors when I run the following samples using KFP backend 1.7.0-rc.3 and SDK 1.7.0.\r\n\r\n```\r\npython3 -m samples.test.metrics_visualization_v2_test\r\npython3 -m samples.test.metrics_visualization_v1_test\r\n```\r\n\r\nThe error I got:\r\n\r\n\r\n",
"Until this comment, every open issue has been added to https://github.com/kubeflow/pipelines/projects/13#column-14866979.",
"Hello @chensun , should we export HTML and Markdown in https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/v2/dsl/__init__.py#L23? I am not able to use them when building visualization pipeline.",
"Update: I will send out a PR to fix this. Reason is that MLMD custom properties `name` has been changed to `display_name`\r\n\r\nAll visualization in v2 syntax is not available:\r\n\r\n\r\n\r\nLogs\r\n\r\n```\r\ntime=\"2021-08-13T18:25:45.311Z\" level=info msg=\"capturing logs\" argo=true\r\nI0813 18:25:45.368149 15 cache.go:120] Connecting to cache endpoint 10.119.242.61:8887\r\nWARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: \r\nhttps://pip.pypa.io/warnings/venv\r\nLoading KFP component module ephemeral_component from dir /tmp/tmp.ibcrdjWT5C\r\nW0813 18:26:51.561024 15 launcher.go:548] Local filepath \"/gcs/jamxl-kfp-bucket/v2/pipeline/metrics-visualization-pipeline/6872a7f7-70e7-470b-937b-9475b684ba1d/wine-classification/metrics\" does not exist\r\ntime=\"2021-08-13T18:26:51.674Z\" level=info msg=\"/tmp/outputs/metrics/data -> /var/run/argo/outputs/artifacts//tmp/outputs/metrics/data.tgz\" argo=true\r\ntime=\"2021-08-13T18:26:51.675Z\" level=info msg=\"Taring /tmp/outputs/metrics/data\"\r\n```",
"@zijianjoy visualization testing has always been an area of headache, because it needs to be done manually. I think it's possible to automate this by building an e2e test that\n1. run the visualization pipeline, returns a URI to the run details page\n2. run a UI e2e test (maybe use cypress) that goes to the run details page, click the node and visualization tab, verify the visualization tab content.\n\nThis can remove the need for manual testing.\n\nRecording this idea for reference, we can continue to observe how often it breaks.",
"1.7.0 on Google Cloud Marketplace also released!"
] | "2021-06-02T11:44:12" | "2022-01-20T12:23:52" | "2021-09-09T05:53:56" | CONTRIBUTOR | null | UPDATE: 1.7.0 release is out! https://github.com/kubeflow/pipelines/releases/tag/1.7.0
Code release blockers:
* [x] TFX issues
* [x] https://github.com/kubeflow/pipelines/issues/6311
* [x] (blockers resolved) https://github.com/kubeflow/pipelines/issues/6138
* [x] https://github.com/kubeflow/pipelines/pull/6331
* [x] https://github.com/kubeflow/pipelines/pull/6342
* [x] https://github.com/kubeflow/pipelines/issues/6252
After code release:
* [x] https://github.com/kubeflow/pipelines/issues/6350
* [ ] if argo releases 3.1.7, we should upgrade
Docs release blockers:
* [x] https://github.com/kubeflow/pipelines/issues/6306
* [x] https://github.com/kubeflow/pipelines/issues/6310
* [x] https://github.com/kubeflow/pipelines/issues/6294#issuecomment-897340923
DONE:
* [x] https://github.com/kubeflow/pipelines/issues/6293
* [x] https://github.com/kubeflow/pipelines/issues/5689
* [x] [Mitigated] https://github.com/kubeflow/pipelines/issues/6189
* [x] https://github.com/kubeflow/pipelines/issues/6130
* [x] https://github.com/kubeflow/pipelines/issues/6053
* [x] https://github.com/kubeflow/pipelines/issues/5303#issuecomment-879565407
* [x] https://github.com/kubeflow/pipelines/issues/5954 (waiting for revert)
* [x] https://github.com/kubeflow/pipelines/issues/5943
* [x] https://github.com/tensorflow/tfx/issues/3933
After release:
* [x] manual verification of fix https://github.com/kubeflow/pipelines/issues/5717#issuecomment-852955515
* [x] we can update reference and merge https://github.com/kubeflow/gcp-blueprints/pull/284
Prepare:
* [x] https://github.com/kubeflow/pipelines/issues/4800
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5779/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5779/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5775 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5775/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5775/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5775/events | https://github.com/kubeflow/pipelines/issues/5775 | 909,295,029 | MDU6SXNzdWU5MDkyOTUwMjk= | 5,775 | postsubmit failing after 1.6.0 release | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"ai_platform sample is failing\r\nhttps://oss-prow.knative.dev/view/gs/oss-prow/logs/kubeflow-pipeline-postsubmit-integration-test/1396731834997411840#1:build-log.txt%3A8245"
] | "2021-06-02T09:28:37" | "2021-06-02T11:27:02" | "2021-06-02T11:27:02" | CONTRIBUTOR | null | https://oss-prow.knative.dev/view/gs/oss-prow/logs/kubeflow-pipeline-postsubmit-integration-test/1396731834997411840
https://github.com/kubeflow/pipelines/commit/fd72b3c9d59803726c41f287cd1ee98b8f95cc5a | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5775/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5775/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5774 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5774/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5774/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5774/events | https://github.com/kubeflow/pipelines/issues/5774 | 909,262,597 | MDU6SXNzdWU5MDkyNjI1OTc= | 5,774 | [sdk] kfp cli giving errors | {
"login": "Ruminateer",
"id": 31800808,
"node_id": "MDQ6VXNlcjMxODAwODA4",
"avatar_url": "https://avatars.githubusercontent.com/u/31800808?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ruminateer",
"html_url": "https://github.com/Ruminateer",
"followers_url": "https://api.github.com/users/Ruminateer/followers",
"following_url": "https://api.github.com/users/Ruminateer/following{/other_user}",
"gists_url": "https://api.github.com/users/Ruminateer/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ruminateer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ruminateer/subscriptions",
"organizations_url": "https://api.github.com/users/Ruminateer/orgs",
"repos_url": "https://api.github.com/users/Ruminateer/repos",
"events_url": "https://api.github.com/users/Ruminateer/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ruminateer/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"Hi @Ruminateer, did you configure access to your KFP API endpoint?\r\nhttps://www.kubeflow.org/docs/components/pipelines/sdk/connect-api/\r\n\r\ne.g. for the CLI, configure your endpoint using env vars\r\n```\r\nexport KF_PIPELINES_ENDPOINT=http://localhost:3000\r\n```",
"> Hi @Ruminateer, did you configure access to your KFP API endpoint?\r\n> https://www.kubeflow.org/docs/components/pipelines/sdk/connect-api/\r\n> \r\n> e.g. for the CLI, configure your endpoint using env vars\r\n> \r\n> ```\r\n> export KF_PIPELINES_ENDPOINT=http://localhost:3000\r\n> ```\r\n\r\nNo, I did miss that. But after setting `KF_PIPELINES_ENDPOINT`, I am getting a different error message.\r\n```console\r\n$ export KF_PIPELINES_ENDPOINT=https://localhost:3000\r\n$ kfp -n default run list\r\n/usr/lib/python3/dist-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.5) or chardet (4.0.0) doesn't match a supported version!\r\n warnings.warn(\"urllib3 ({}) or chardet ({}) doesn't match a supported \"\r\nRetrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f385ccef6a0>: Failed to establish a new connection: [Errno 111] Connection refused')': /apis/v1beta1/healthz\r\nRetrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f385ccef9a0>: Failed to establish a new connection: [Errno 111] Connection refused')': /apis/v1beta1/healthz\r\nRetrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f385ccefb20>: Failed to establish a new connection: [Errno 111] Connection refused')': /apis/v1beta1/healthz\r\nHTTPSConnectionPool(host='localhost', port=3000): Max retries exceeded with url: /apis/v1beta1/healthz (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f385cd5ed00>: Failed to establish a new connection: [Errno 111] Connection refused'))\r\n```\r\nI also tried the remote server address in my `KUBECONFIG` for `KF_PIPELINES_ENDPOINT`, but I got the same error as above. How can I decide the address for `KF_PIPELINES_ENDPOINT`?",
"Did you fully read https://www.kubeflow.org/docs/components/pipelines/sdk/connect-api/?\nAll answered in it.",
"Sorry, my bad. I set up the port forward but I am getting new errors. Cannot find an answer on that page 😥\r\n```console\r\n$ kubectl port-forward svc/ml-pipeline-ui 3000:80 --namespace kubeflow\r\nForwarding from 127.0.0.1:3000 -> 3000\r\nForwarding from [::1]:3000 -> 3000\r\nHandling connection for 3000\r\nHandling connection for 3000\r\n```\r\n\r\n```console\r\n$ kfp -n default run list\r\n/usr/lib/python3/dist-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.5) or chardet (4.0.0) doesn't match a supported version!\r\n warnings.warn(\"urllib3 ({}) or chardet ({}) doesn't match a supported \"\r\n(504)\r\nReason: Gateway Timeout\r\nHTTP response headers: HTTPHeaderDict({'X-Powered-By': 'Express', 'Date': 'Thu, 03 Jun 2021 03:37:07 GMT', 'Connection': 'keep-alive', 'Transfer-Encoding': 'chunked'})\r\nHTTP response body: Error occured while trying to proxy to: localhost:3000/apis/v1beta1/runs?page_token=&page_size=100&sort_by=created_at+desc\r\n\r\n$ kfp -n default run submit -e Default -w -f mnist.py.yml\r\n/usr/lib/python3/dist-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.5) or chardet (4.0.0) doesn't match a supported version!\r\n warnings.warn(\"urllib3 ({}) or chardet ({}) doesn't match a supported \"\r\n(504)\r\nReason: Gateway Timeout\r\nHTTP response headers: HTTPHeaderDict({'X-Powered-By': 'Express', 'Date': 'Thu, 03 Jun 2021 03:45:14 GMT', 'Connection': 'keep-alive', 'Transfer-Encoding': 'chunked'})\r\nHTTP response body: Error occured while trying to proxy to: localhost:3000/apis/v1beta1/experiments?page_token=&page_size=100&sort_by=&resource_reference_key.type=NAMESPACE&resource_reference_key.id=\r\n\r\n```",
"No prob!\n\nThe new error seems a bit weird. Did you check opening localhost:3000 in your browser? Everything working?\n\nI didn't quite remember what the -n flag do. Can we remove it?",
"> Did you check opening localhost:3000 in your browser? Everything working?\r\n\r\nIt is not working either. Error message\r\n```console\r\nError occured while trying to proxy to: localhost:3000/apis/v1beta1/pipelines?page_token=&page_size=10&sort_by=created_at%20desc&filter=\r\n```\r\n\r\n\r\n> I didn't quite remember what the -n flag do. Can we remove it?\r\n\r\nIt just specifies the namespace. Removing it makes no difference.\r\n```console\r\n$ kfp run list\r\n/usr/lib/python3/dist-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.5) or chardet (4.0.0) doesn't match a supported version!\r\n warnings.warn(\"urllib3 ({}) or chardet ({}) doesn't match a supported \"\r\n(504)\r\nReason: Gateway Timeout\r\nHTTP response headers: HTTPHeaderDict({'X-Powered-By': 'Express', 'Date': 'Thu, 03 Jun 2021 05:55:31 GMT', 'Connection': 'keep-alive', 'Transfer-Encoding': 'chunked'})\r\nHTTP response body: Error occured while trying to proxy to: localhost:3000/apis/v1beta1/runs?page_token=&page_size=100&sort_by=created_at+desc\r\n\r\n```\r\n\r\nBTW I'm not using a proxy if that matters.\r\n```console\r\n$ env | grep proxy\r\nGOPROXY=https://goproxy.io,https://goproxy.cn,direct\r\n```",
"If visiting localhost:3000 already has errors, then sth is wrong with your deployment or the kubectl proxy. Use kubectl to debug your deployment.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-02T08:59:25" | "2022-03-03T04:05:29" | "2022-03-03T04:05:29" | MEMBER | null | ### Environment
* KFP version: 1.6.0
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP SDK version: 1.4.0
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* All dependencies version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
```console
$ pip list | grep kfp
kfp 1.4.0
kfp-pipeline-spec 0.1.7
kfp-server-api 1.5.0
```
### Steps to reproduce
Installed Kubeflow pipeline on an existing cluster. Installed SDK
```console
export PIPELINE_VERSION=1.6.0
kubectl apply -k "github.com/kubeflow/pipelines/manifests/kustomize/cluster-scoped-resources?ref=$PIPELINE_VERSION"
kubectl wait --for condition=established --timeout=60s crd/applications.app.k8s.io
kubectl apply -k "github.com/kubeflow/pipelines/manifests/kustomize/env/dev?ref=$PIPELINE_VERSION"
pip3 install kfp --upgrade
```
Got these errors. What I am doing wrong? Have no idea how to solve it.
```console
$ kfp run list
/usr/lib/python3/dist-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.5) or chardet (4.0.0) doesn't match a supported version!
warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported "
Failed to get healthz info attempt 1 of 5.
Traceback (most recent call last):
File "/home/zzy/.local/lib/python3.8/site-packages/kfp/_client.py", line 312, in get_kfp_healthz
response = self._healthz_api.get_healthz()
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 63, in get_healthz
return self.get_healthz_with_http_info(**kwargs) # noqa: E501
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 134, in get_healthz_with_http_info
return self.api_client.call_api(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 364, in call_api
return self.__call_api(resource_path, method,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 188, in __call_api
raise e
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 181, in __call_api
response_data = self.request(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 389, in request
return self.rest_client.GET(url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 230, in GET
return self.request("GET", url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 224, in request
raise ApiException(http_resp=r)
kfp_server_api.exceptions.ApiException: (503)
Reason: Service Unavailable
HTTP response headers: HTTPHeaderDict({'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Date': 'Wed, 02 Jun 2021 07:23:00 GMT', 'Content-Length': '178'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"no endpoints available for service \"ml-pipeline:http\"","reason":"ServiceUnavailable","code":503}
Failed to get healthz info attempt 2 of 5.
Traceback (most recent call last):
File "/home/zzy/.local/lib/python3.8/site-packages/kfp/_client.py", line 312, in get_kfp_healthz
response = self._healthz_api.get_healthz()
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 63, in get_healthz
return self.get_healthz_with_http_info(**kwargs) # noqa: E501
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 134, in get_healthz_with_http_info
return self.api_client.call_api(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 364, in call_api
return self.__call_api(resource_path, method,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 188, in __call_api
raise e
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 181, in __call_api
response_data = self.request(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 389, in request
return self.rest_client.GET(url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 230, in GET
return self.request("GET", url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 224, in request
raise ApiException(http_resp=r)
kfp_server_api.exceptions.ApiException: (503)
Reason: Service Unavailable
HTTP response headers: HTTPHeaderDict({'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Date': 'Wed, 02 Jun 2021 07:23:05 GMT', 'Content-Length': '178'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"no endpoints available for service \"ml-pipeline:http\"","reason":"ServiceUnavailable","code":503}
^C
Aborted!
$ kfp -n default run list
/usr/lib/python3/dist-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.5) or chardet (4.0.0) doesn't match a supported version!
warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported "
Failed to get healthz info attempt 1 of 5.
Traceback (most recent call last):
File "/home/zzy/.local/lib/python3.8/site-packages/kfp/_client.py", line 312, in get_kfp_healthz
response = self._healthz_api.get_healthz()
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 63, in get_healthz
return self.get_healthz_with_http_info(**kwargs) # noqa: E501
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 134, in get_healthz_with_http_info
return self.api_client.call_api(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 364, in call_api
return self.__call_api(resource_path, method,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 188, in __call_api
raise e
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 181, in __call_api
response_data = self.request(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 389, in request
return self.rest_client.GET(url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 230, in GET
return self.request("GET", url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 224, in request
raise ApiException(http_resp=r)
kfp_server_api.exceptions.ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Date': 'Wed, 02 Jun 2021 07:23:25 GMT', 'Content-Length': '198'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"services \"ml-pipeline\" not found","reason":"NotFound","details":{"name":"ml-pipeline","kind":"services"},"code":404}
Failed to get healthz info attempt 2 of 5.
Traceback (most recent call last):
File "/home/zzy/.local/lib/python3.8/site-packages/kfp/_client.py", line 312, in get_kfp_healthz
response = self._healthz_api.get_healthz()
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 63, in get_healthz
return self.get_healthz_with_http_info(**kwargs) # noqa: E501
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 134, in get_healthz_with_http_info
return self.api_client.call_api(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 364, in call_api
return self.__call_api(resource_path, method,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 188, in __call_api
raise e
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 181, in __call_api
response_data = self.request(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 389, in request
return self.rest_client.GET(url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 230, in GET
return self.request("GET", url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 224, in request
raise ApiException(http_resp=r)
kfp_server_api.exceptions.ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Date': 'Wed, 02 Jun 2021 07:23:30 GMT', 'Content-Length': '198'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"services \"ml-pipeline\" not found","reason":"NotFound","details":{"name":"ml-pipeline","kind":"services"},"code":404}
^C
Aborted!
$ kfp -n default run submit -e Default -w -f mnist.py.yml
/usr/lib/python3/dist-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.5) or chardet (4.0.0) doesn't match a supported version!
warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported "
Failed to get healthz info attempt 1 of 5.
Traceback (most recent call last):
File "/home/zzy/.local/lib/python3.8/site-packages/kfp/_client.py", line 312, in get_kfp_healthz
response = self._healthz_api.get_healthz()
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 63, in get_healthz
return self.get_healthz_with_http_info(**kwargs) # noqa: E501
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 134, in get_healthz_with_http_info
return self.api_client.call_api(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 364, in call_api
return self.__call_api(resource_path, method,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 188, in __call_api
raise e
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 181, in __call_api
response_data = self.request(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 389, in request
return self.rest_client.GET(url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 230, in GET
return self.request("GET", url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 224, in request
raise ApiException(http_resp=r)
kfp_server_api.exceptions.ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Date': 'Wed, 02 Jun 2021 09:01:22 GMT', 'Content-Length': '198'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"services \"ml-pipeline\" not found","reason":"NotFound","details":{"name":"ml-pipeline","kind":"services"},"code":404}
Failed to get healthz info attempt 2 of 5.
Traceback (most recent call last):
File "/home/zzy/.local/lib/python3.8/site-packages/kfp/_client.py", line 312, in get_kfp_healthz
response = self._healthz_api.get_healthz()
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 63, in get_healthz
return self.get_healthz_with_http_info(**kwargs) # noqa: E501
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api/healthz_service_api.py", line 134, in get_healthz_with_http_info
return self.api_client.call_api(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 364, in call_api
return self.__call_api(resource_path, method,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 188, in __call_api
raise e
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 181, in __call_api
response_data = self.request(
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/api_client.py", line 389, in request
return self.rest_client.GET(url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 230, in GET
return self.request("GET", url,
File "/home/zzy/.local/lib/python3.8/site-packages/kfp_server_api/rest.py", line 224, in request
raise ApiException(http_resp=r)
kfp_server_api.exceptions.ApiException: (404)
Reason: Not Found
HTTP response headers: HTTPHeaderDict({'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Date': 'Wed, 02 Jun 2021 09:01:27 GMT', 'Content-Length': '198'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"services \"ml-pipeline\" not found","reason":"NotFound","details":{"name":"ml-pipeline","kind":"services"},"code":404}
^C
Aborted!
```
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
### Expected result
<!-- What should the correct behavior be? -->
kfp doesn't give the errors and tells that there is 0 run history.
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5774/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5774/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5773 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5773/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5773/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5773/events | https://github.com/kubeflow/pipelines/issues/5773 | 909,222,345 | MDU6SXNzdWU5MDkyMjIzNDU= | 5,773 | deploying the trained model using deploy component is throwing an Internal Error: | {
"login": "priya170807",
"id": 47265581,
"node_id": "MDQ6VXNlcjQ3MjY1NTgx",
"avatar_url": "https://avatars.githubusercontent.com/u/47265581?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/priya170807",
"html_url": "https://github.com/priya170807",
"followers_url": "https://api.github.com/users/priya170807/followers",
"following_url": "https://api.github.com/users/priya170807/following{/other_user}",
"gists_url": "https://api.github.com/users/priya170807/gists{/gist_id}",
"starred_url": "https://api.github.com/users/priya170807/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/priya170807/subscriptions",
"organizations_url": "https://api.github.com/users/priya170807/orgs",
"repos_url": "https://api.github.com/users/priya170807/repos",
"events_url": "https://api.github.com/users/priya170807/events{/privacy}",
"received_events_url": "https://api.github.com/users/priya170807/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Hi @priya170807 \r\n> Internal error occurred. Please retry in a few minutes. If you still experience errors, contact Cloud ML.\r\n\r\nDid you retry? This seems like a problem with the service, rather than KFP/component.",
"Hi Bobgy,\r\n\r\nThank you responding...I was continuosly retrying. It worked today...\r\n\r\nThanks\r\nPriya"
] | "2021-06-02T07:49:48" | "2021-06-03T16:41:42" | "2021-06-03T16:41:42" | NONE | null | I have created an XgBoost model and performed hyperparameter tuning. I am trying to deploy using deploy component,
mlengine_deploy_op = component_store.load_component('ml_engine/deploy').
I am getting the following error.
Traceback (most recent call last):
File "/usr/local/lib/python2.7/runpy.py", line 174, in _run_module_as_main
"__main__", fname, loader, pkg_name)
File "/usr/local/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/ml/kfp_component/launcher/__main__.py", line 45, in <module>
main()
File "/ml/kfp_component/launcher/__main__.py", line 42, in main
launch(args.file_or_module, args.args)
File "kfp_component/launcher/launcher.py", line 45, in launch
return fire.Fire(module, command=args, name=module.__name__)
File "/usr/local/lib/python2.7/site-packages/fire/core.py", line 127, in Fire
component_trace = _Fire(component, args, context, name)
File "/usr/local/lib/python2.7/site-packages/fire/core.py", line 366, in _Fire
component, remaining_args)
File "/usr/local/lib/python2.7/site-packages/fire/core.py", line 542, in _CallCallable
result = fn(*varargs, **kwargs)
File "kfp_component/google/ml_engine/_deploy.py", line 68, in deploy
wait_interval)
File "kfp_component/google/ml_engine/_create_version.py", line 64, in create_version
replace_existing, wait_interval).execute_and_wait()
File "kfp_component/google/ml_engine/_create_version.py", line 101, in execute_and_wait
created_version = self._create_version_and_wait()
File "kfp_component/google/ml_engine/_create_version.py", line 135, in _create_version_and_wait
self._wait_interval)
File "kfp_component/google/ml_engine/_common_ops.py", line 67, in wait_for_operation_done
error.get('message', 'Unknown message'),
**RuntimeError**: Failed to complete create version operation projects/test-project-one-307022/operations/create_cashdemand_regressor_v01-1622618056480: 13 Internal error occurred. Please retry in a few minutes. If you still experience errors, contact Cloud ML.
Please help.
priya | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5773/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5773/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5768 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5768/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5768/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5768/events | https://github.com/kubeflow/pipelines/issues/5768 | 908,395,312 | MDU6SXNzdWU5MDgzOTUzMTI= | 5,768 | [feature] Add PyTorch Components for KFP | {
"login": "chauhang",
"id": 4461127,
"node_id": "MDQ6VXNlcjQ0NjExMjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/4461127?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chauhang",
"html_url": "https://github.com/chauhang",
"followers_url": "https://api.github.com/users/chauhang/followers",
"following_url": "https://api.github.com/users/chauhang/following{/other_user}",
"gists_url": "https://api.github.com/users/chauhang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chauhang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chauhang/subscriptions",
"organizations_url": "https://api.github.com/users/chauhang/orgs",
"repos_url": "https://api.github.com/users/chauhang/repos",
"events_url": "https://api.github.com/users/chauhang/events{/privacy}",
"received_events_url": "https://api.github.com/users/chauhang/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1126834402,
"node_id": "MDU6TGFiZWwxMTI2ODM0NDAy",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/components",
"name": "area/components",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1260031624,
"node_id": "MDU6TGFiZWwxMjYwMDMxNjI0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/samples",
"name": "area/samples",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Added support for [PyTorch KFP Components](https://github.com/kubeflow/pipelines/tree/master/components/PyTorch/pytorch-kfp-components) and [Samples](https://github.com/kubeflow/pipelines/tree/master/components/PyTorch/pytorch-kfp-components) for:\r\n- Model training for PyTorch \r\n- Profiling and visualizations using [PyTorch Tensorboard profiler](https://pytorch.org/blog/introducing-pytorch-profiler-the-new-and-improved-performance-tool/) plugin and KFP Confusion matrix support,\r\n- Model deployment using [KFServing + TorchServe](https://github.com/kubeflow/kfserving/tree/master/docs/samples/v1beta1/torchserve), \r\n- Distributed training using [PyTorch Operator](https://github.com/kubeflow/pytorch-operator), \r\n- Hyper parameter optimizations using [Ax/BoTorch](https://ax.dev/)\r\n- Model Interpretability using [Captum](https://captum.ai/)"
] | "2021-06-01T15:07:53" | "2021-08-16T04:58:13" | "2021-08-16T04:58:12" | CONTRIBUTOR | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
/area components
/area samples
### What feature would you like to see?
This feature will add support for PyTorch components in Kubeflow pipelines, providing ability to train models and deploy them using KFServing with TorchServe for an End to end PyTorch model training to prediction loop.
The components will be packaged as a pip install and getting started examples will be provided for Computer Vision and NLP.
The components and examples are expected to run on any deployment scenarios, for both cloud and on-prem scenarios.
### What is the use case or pain point?
Currently there is no easy solution for this and KFP community is expected to figure out on their own.
### Is there a workaround currently?
Write own components
---
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5768/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5768/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5765 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5765/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5765/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5765/events | https://github.com/kubeflow/pipelines/issues/5765 | 907,958,054 | MDU6SXNzdWU5MDc5NTgwNTQ= | 5,765 | [backend] Kale pipeline steps are not getting cached but HP tuning jobs has the cache feature | {
"login": "cloudbow",
"id": 144680,
"node_id": "MDQ6VXNlcjE0NDY4MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/144680?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cloudbow",
"html_url": "https://github.com/cloudbow",
"followers_url": "https://api.github.com/users/cloudbow/followers",
"following_url": "https://api.github.com/users/cloudbow/following{/other_user}",
"gists_url": "https://api.github.com/users/cloudbow/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cloudbow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cloudbow/subscriptions",
"organizations_url": "https://api.github.com/users/cloudbow/orgs",
"repos_url": "https://api.github.com/users/cloudbow/repos",
"events_url": "https://api.github.com/users/cloudbow/events{/privacy}",
"received_events_url": "https://api.github.com/users/cloudbow/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1260031624,
"node_id": "MDU6TGFiZWwxMjYwMDMxNjI0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/samples",
"name": "area/samples",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign",
"Hi @cloudbow, this seems like a feature request to Kale, because using a new volume snapshot as pipeline input makes it impossible for KFP to predict whether there were any changes in the pipeline.\r\n\r\nTo utilize caching, you should better have smaller granularity for your input data, so that the pipeline can easily know which changed and which didn't.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-06-01T06:49:29" | "2022-03-03T04:05:23" | "2022-03-03T04:05:23" | NONE | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
/area backend
/area sdk
/area samples
<!-- /area components -->
### What feature would you like to see?
Use cache feature to rerun kale generated pipelines which will reduce the total amount of time to re-run the pipelines with code changes
<!-- Provide a description of this feature and the user experience. -->
### What is the use case or pain point?
Currently when I installed minkf-1.3 for datascientists the compiled pipelines are taking a long time to execute. The reason is that the steps are not getting cached. There is no way to create a cache from converting jupyter to pipelines because everytime it creates a new rok snashot. Is there anyway to provide a "Compile and Run with Cache" option so that only changed code is converted to kubeflow pipelines.
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
Not to my knowledge
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5765/reactions",
"total_count": 5,
"+1": 5,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5765/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5764 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5764/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5764/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5764/events | https://github.com/kubeflow/pipelines/issues/5764 | 907,952,144 | MDU6SXNzdWU5MDc5NTIxNDQ= | 5,764 | [backend] Steps not getting cached when input parameters are same | {
"login": "cloudbow",
"id": 144680,
"node_id": "MDQ6VXNlcjE0NDY4MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/144680?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cloudbow",
"html_url": "https://github.com/cloudbow",
"followers_url": "https://api.github.com/users/cloudbow/followers",
"following_url": "https://api.github.com/users/cloudbow/following{/other_user}",
"gists_url": "https://api.github.com/users/cloudbow/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cloudbow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cloudbow/subscriptions",
"organizations_url": "https://api.github.com/users/cloudbow/orgs",
"repos_url": "https://api.github.com/users/cloudbow/repos",
"events_url": "https://api.github.com/users/cloudbow/events{/privacy}",
"received_events_url": "https://api.github.com/users/cloudbow/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930619535,
"node_id": "MDU6TGFiZWw5MzA2MTk1MzU=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/priority/p2",
"name": "priority/p2",
"color": "fc9915",
"default": false,
"description": ""
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1682717392,
"node_id": "MDU6TGFiZWwxNjgyNzE3Mzky",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/question",
"name": "kind/question",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"Hi @cloudbow, I tried running your example on KFP standalone 1.6.0 on GCP, it is cached as expected after second run.\r\n\r\n\r\n\r\nTherefore, this issue might be specific to either your env or MiniKF. Can you use `kubectl get pod -n kubeflow` `kubectl describe pod <pod-name>` `kubectl logs <pod-name>` etc techniques to check your deployment. The key servers to look at is `cache-server` and `cache-deployer`. Sth might be failing with them.",
"Hi @Bobgy , I have the same issue with a different environment so I might provide some informations.\r\n\r\nI tried with KFP 1.6/1.5/1.4 standalone on GCP and AI Platform deployed on an existing cluster and never get caching. All deployment are fine including cache-server and cache-deployer but the cachedb is always empty (other db seems fine).\r\n\r\nWith AI Platform and a new cluster I actually have cache so it may come from the environment ?\r\nI tried with private clusters with autoscaling (min 3 nodes, 2vCPU and 4.5GB RAM).\r\n\r\nEdit: After further investigations, this seems to be related to the use of a private cluster in my case.",
"@Itega what do you mean by private cluster ? I am running kubeflow on minikf 1.3 from market place. can this also be called private cluster?\r\n@Bobgy let me check",
"ubuntu@ip-10-101-8-247:~$ kubectl get po -n kubeflow\r\nNAME READY STATUS RESTARTS AGE\r\nadmission-webhook-deployment-8c9cdf478-q2lmt 2/2 Running 0 7d19h\r\ncentraldashboard-77cb6bbb48-nktsx 2/2 Running 0 7d19h\r\njupyter-web-app-deployment-75795878-ts9t2 2/2 Running 0 7d19h\r\nkatib-controller-6d6bb5495d-zc29z 2/2 Running 0 7d19h\r\nkatib-db-manager-6ff648f5cc-r5mgc 2/2 Running 0 7d19h\r\nkatib-mysql-6495dccdd5-vpffx 2/2 Running 0 7d19h\r\nkatib-ui-7ddf4965f9-j49ss 2/2 Running 0 7d19h\r\nkfp-cache-7fd4488b7f-t2kcn 3/3 Running 0 7d19h\r\nkfserving-controller-manager-0 3/3 Running 0 7d19h\r\nkubeflow-reception-7895dd4d69-lxlss 2/2 Running 0 7d19h\r\nmetadata-db-6bf8b57f97-jqg29 2/2 Running 0 7d19h\r\nmetadata-envoy-deployment-549d875989-r4kk8 1/1 Running 0 7d19h\r\nmetadata-grpc-deployment-ccc8c8bd9-rw2xz 2/2 Running 4 7d19h\r\nminio-6cfd7cb4f-25zkp 2/2 Running 0 7d19h\r\nml-pipeline-5dc8fff45b-nj76p 2/2 Running 0 7d19h\r\nml-pipeline-persistenceagent-c6b4d475f-hmnwt 2/2 Running 0 7d19h\r\nml-pipeline-scheduledworkflow-64dc954c6c-tzp4x 2/2 Running 0 7d19h\r\nml-pipeline-ui-78846f6754-tmnth 2/2 Running 1 7d19h\r\nml-pipeline-viewer-crd-5ffbd79f68-dx667 2/2 Running 0 7d19h\r\nml-pipeline-visualizationserver-5977df9c45-6xq5x 2/2 Running 0 7d19h\r\nmodels-web-app-7bfdc5c585-rznv7 2/2 Running 0 7d19h\r\nmpi-operator-754d876fd8-gppnx 1/1 Running 1 7d19h\r\nmxnet-operator-c5f7b6798-gzmxv 1/1 Running 1 7d19h\r\nmysql-65ff8d5dfd-wqbbd 2/2 Running 0 7d19h\r\nnotebook-controller-deployment-7c46fdd957-f957p 2/2 Running 0 7d19h\r\nprofiles-deployment-588f5fdcf8-26xmv 3/3 Running 0 7d19h\r\npvcviewer-controller-controller-manager-5998dc798b-jx2hf 3/3 Running 1 7d19h\r\npytorch-operator-77b7ff46c-hhfhj 2/2 Running 1 7d19h\r\nspark-operatorsparkoperator-579554d99d-mnkz2 2/2 Running 0 7d19h\r\ntensorboard-controller-controller-manager-6d99664986-n624x 3/3 Running 1 7d19h\r\ntensorboards-web-app-deployment-6b98985bc5-xv6rv 1/1 Running 0 7d19h\r\ntf-job-operator-5bb7675fb8-4nfhq 2/2 Running 1 7d19h\r\nvolumes-web-app-deployment-b8d6cc797-xwdmz 2/2 Running 0 7d19h\r\nworkflow-controller-5f9dbb559c-dw2tk 2/2 Running 0 7d19h\r\nxgboost-operator-deployment-7bf56c6d4f-cf7jc 2/2 Running 0 7d19h",
"I see only kfp cache . I did try turning on logs and running but here is what I got.\r\n\r\nFirst run\r\n{\"level\":\"info\",\"ts\":1622631681.9666345,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631681.9666553,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631681.9760761,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631681.9761019,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631682.023542,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631682.0235684,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631684.0169182,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631684.0169406,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631685.1026225,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631685.1026473,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631685.4869857,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631685.487011,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631686.1834323,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631686.1834562,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631692.0271308,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631692.0308237,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631692.0488806,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631692.048913,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631692.065883,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631692.0659041,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2880583143\"}\r\n{\"level\":\"info\",\"ts\":1622631692.110993,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631692.1110253,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631693.9256918,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631693.9257143,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631695.0097864,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631695.009808,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631695.2612553,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631695.2612772,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631696.0857518,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631696.0857756,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631702.0451055,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n{\"level\":\"info\",\"ts\":1622631702.045128,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-pcbfb-2404255012\"}\r\n\r\n\r\nNext run\r\n{\"level\":\"info\",\"ts\":1622631768.5726974,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631768.572721,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631768.5772638,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631768.5772843,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631768.6517446,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631768.6517673,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631769.8138227,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631769.8138506,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631770.8717377,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631770.8717608,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631771.2016962,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631771.2017179,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631771.949174,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631771.9491968,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631778.463374,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-mvkk7-3840758880\"}\r\n{\"level\":\"info\",\"ts\":1622631778.4633968,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-mvkk7-3840758880\"}\r\n{\"level\":\"info\",\"ts\":1622631778.4745355,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-mvkk7-3827168991\"}\r\n{\"level\":\"info\",\"ts\":1622631778.4745579,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-mvkk7-3827168991\"}\r\n{\"level\":\"info\",\"ts\":1622631778.4745853,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod does not exist\",\"pod\":\"kubeflow-user/addition-pipeline-mvkk7-3840758880\"}\r\n{\"level\":\"info\",\"ts\":1622631778.4823828,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod does not exist\",\"pod\":\"kubeflow-user/addition-pipeline-mvkk7-3827168991\"}\r\n{\"level\":\"info\",\"ts\":1622631778.7625508,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631778.7625754,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631778.7830899,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631778.783113,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631778.7965403,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631778.7965593,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-687887970\"}\r\n{\"level\":\"info\",\"ts\":1622631778.8399537,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631778.8399792,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631780.6956744,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631780.695712,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631781.8212683,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631781.8212938,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631782.109519,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631782.1095474,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631782.8937457,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631782.893769,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631788.7896814,\"logger\":\"kfp-cache-controller\",\"msg\":\"Successfully retrieved pod\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n{\"level\":\"info\",\"ts\":1622631788.7897058,\"logger\":\"kfp-cache-controller\",\"msg\":\"Pod is not a Kale step\",\"pod\":\"kubeflow-user/addition-pipeline-wshhv-1927489725\"}\r\n",
"/kind question\r\n/priority p2\r\n/area pipelines",
"@jbottum: The label(s) `area/pipeliines` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubeflow/pipelines/issues/5764#issuecomment-859037860):\n\n>/kind question\r\n>/priority p2\r\n>/area pipeliines\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"It seems KFP cache deployer is missing in minikf.\n@yanniszark @elikatsis who is the best person to ask about minikf?",
"Hi all!\r\n\r\nIt's true, we don't deploy the official KFP cache in MiniKF, for a few reasons:\r\n1. We are running into issues related to https://github.com/kubeflow/pipelines/issues/5257 because every Kale pipeline starts with a VolumeOp creating a PVC with the notebook environment & data. Thus, we cannot have this step cached because no PVC will get created.\r\n2. As mentioned in the aforementioned issue, currently the official cache is either enabled or disabled and doesn't permit excluding specific steps or components. This would solve (1). We already have some proposals (see https://github.com/kubeflow/pipelines/issues/5257#issuecomment-852326538) and we will elaborate on them since we want to make the KFP cache available on MiniKF as well.\r\n3. Our current approach for caching KFP steps relies on MLMD exclusively without using extra DB. We believe this is the way to go. This also seems to be in line with KFPv2 making MLMD the backbone of data passing and artifact logging.\r\n\r\nBy the way, our caching mechanism is deployed in the `kubeflow` namespace as the `kfp-cache` deployment, and that's what the logs above are about.\r\n\r\ncc @StefanoFioravanzo ",
"@elikatsis shall we document this on MiniKF side?\r\nCan we close the issue now?",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"
] | "2021-06-01T06:41:49" | "2022-03-03T02:05:26" | null | NONE | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
minikf-1.3 from aws market place
* KFP version:
Same as minikf-1.3 provided
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version:
kfp 1.5.0
kfp-pipeline-spec 0.1.7
kfp-server-api 1.5.0
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
### Steps to reproduce
I have attached the notebook I used. Please try it with that . The input is already provided. Its a simple add_op pipeline which adds two numbers. But why is the step being executed again and again even if the run is cloned or a new run created using the same pipeline.
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
### Expected result
The steps should have been cached as the input the docker image, the output everything is same.
<!-- What should the correct behavior be? -->
### Materials and Reference
Attached sample [code]([simple_function_based_component_pipeline (1).ipynb.zip](https://github.com/kubeflow/pipelines/files/6573897/simple_function_based_component_pipeline.1.ipynb.zip))
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5764/reactions",
"total_count": 8,
"+1": 8,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5764/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5763 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5763/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5763/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5763/events | https://github.com/kubeflow/pipelines/issues/5763 | 907,787,587 | MDU6SXNzdWU5MDc3ODc1ODc= | 5,763 | [bug] pipeline's child pods are not deleted after workflow's status became success | {
"login": "anencore94",
"id": 37469330,
"node_id": "MDQ6VXNlcjM3NDY5MzMw",
"avatar_url": "https://avatars.githubusercontent.com/u/37469330?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anencore94",
"html_url": "https://github.com/anencore94",
"followers_url": "https://api.github.com/users/anencore94/followers",
"following_url": "https://api.github.com/users/anencore94/following{/other_user}",
"gists_url": "https://api.github.com/users/anencore94/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anencore94/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anencore94/subscriptions",
"organizations_url": "https://api.github.com/users/anencore94/orgs",
"repos_url": "https://api.github.com/users/anencore94/repos",
"events_url": "https://api.github.com/users/anencore94/events{/privacy}",
"received_events_url": "https://api.github.com/users/anencore94/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This is expected behavior, default TTL is 1 day.\r\nSee https://github.com/kubeflow/pipelines/blob/5d0f3a3d32f35d3dbca9cd27f4ee476e87f6d41e/manifests/kustomize/base/pipeline/ml-pipeline-persistenceagent-deployment.yaml#L24-L25\r\n\r\nAfter the workflow is GCed, Pods will be removed.",
"Thanks @Bobgy !\r\nI'm a bit confused, so I created a new pipeline yesterday on success and see what happen today. (after 24 hours)\r\nAnd they really removed automatically.\r\nThank you for checking this :) you may close this issue."
] | "2021-06-01T01:18:36" | "2021-06-03T00:09:47" | "2021-06-03T00:09:47" | MEMBER | null | ### What steps did you take
- create kf pipeline
- all components were spawned well as pods.
- all components' status became COMPLETED
- pipeline's status became SUCCESS
### What happened:
- HOWEVER, child pods didn't killed automatically.
- I should kill them manually.
### What did you expect to happen:
- They should be killed after pipeline succeeded.
### Environment:
* How do you deploy Kubeflow Pipelines (KFP)?
* with kubeflow manifests repo, kustomize + kubectl apply
* KFP version:
- tag : 1.5.0 (https://github.com/kubeflow/pipelines/tree/1.5.0/manifests/kustomize)
- on UI : build version v1beta1
* KFP SDK version:
* Kubernetes env:
* on-premise k8s v1.19.3
### Anything else you would like to add:
I searched about this and I guess `spec.podGC.strategy` has some releation on this issue.
But, I didn't specify that parameter on my pipeline.yaml (kind : workflow).
In my case, is this situation is normal ? (all completed pods are not deleted until their parent pipeline will be deleted)
Also, if i want my pod would be deleted when my pipeline finished successfully, Do I have to specify spec.podGC.strategy everytime?
### Labels
<!-- Please include labels below by uncommenting them to help us better triage issues -->
/area backend
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
<!-- /area testing -->
<!-- /area samples -->
<!-- /area components -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5763/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5763/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5762 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5762/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5762/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5762/events | https://github.com/kubeflow/pipelines/issues/5762 | 907,628,968 | MDU6SXNzdWU5MDc2Mjg5Njg= | 5,762 | [bug] Execution not caching | {
"login": "Itega",
"id": 8017414,
"node_id": "MDQ6VXNlcjgwMTc0MTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8017414?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Itega",
"html_url": "https://github.com/Itega",
"followers_url": "https://api.github.com/users/Itega/followers",
"following_url": "https://api.github.com/users/Itega/following{/other_user}",
"gists_url": "https://api.github.com/users/Itega/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Itega/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Itega/subscriptions",
"organizations_url": "https://api.github.com/users/Itega/orgs",
"repos_url": "https://api.github.com/users/Itega/repos",
"events_url": "https://api.github.com/users/Itega/events{/privacy}",
"received_events_url": "https://api.github.com/users/Itega/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"@Ark-kun is this sample still working properly?\r\nIt fails in our test infra too:\r\nhttps://testgrid.k8s.io/googleoss-kubeflow-pipelines#kubeflow-pipeline-postsubmit-integration-test",
"I can give you more information about my case as I have now found a way to install KFP 1.6 with caching on GCP. \r\nMy problem was that I was using a GKE private cluster, I tried with a public cluster and it's working fine. \r\nDid some search and Kubeflow does not seems to be compatible with private cluster on GKE : https://github.com/kubeflow/gcp-blueprints/issues/267 Maybe you have more informations on this ?\r\n\r\nCan confirm the sample is working well on my public cluster so I really think there is a problem with caching on some Kubernetes cluster configurations.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-31T17:31:57" | "2022-03-03T04:05:29" | "2022-03-03T04:05:29" | NONE | null | ### What steps did you take:
- [Deploy Kubeflow Pipelines on a new GKE cluster](https://www.kubeflow.org/docs/components/pipelines/installation/standalone-deployment/#deploying-kubeflow-pipelines)
- Run the [Kubeflow caching sample](https://github.com/kubeflow/pipelines/blob/master/samples/core/caching/caching_sample.py)
### What happened:
The sample failed with error :
`RuntimeError: The cached execution was not re-used or pipeline run took to long to complete.`
### What did you expect to happen:
The sample should have run successfully.
### Environment:
Kubernetes : 1.18.18-gke.1100
KFP version : 1.6.0
KFP SDK version: 1.6.2
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5762/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5762/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5758 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5758/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5758/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5758/events | https://github.com/kubeflow/pipelines/issues/5758 | 906,508,856 | MDU6SXNzdWU5MDY1MDg4NTY= | 5,758 | [feature] Pipeline parameter description | {
"login": "skogsbrus",
"id": 17073827,
"node_id": "MDQ6VXNlcjE3MDczODI3",
"avatar_url": "https://avatars.githubusercontent.com/u/17073827?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skogsbrus",
"html_url": "https://github.com/skogsbrus",
"followers_url": "https://api.github.com/users/skogsbrus/followers",
"following_url": "https://api.github.com/users/skogsbrus/following{/other_user}",
"gists_url": "https://api.github.com/users/skogsbrus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skogsbrus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skogsbrus/subscriptions",
"organizations_url": "https://api.github.com/users/skogsbrus/orgs",
"repos_url": "https://api.github.com/users/skogsbrus/repos",
"events_url": "https://api.github.com/users/skogsbrus/events{/privacy}",
"received_events_url": "https://api.github.com/users/skogsbrus/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930619516,
"node_id": "MDU6TGFiZWw5MzA2MTk1MTY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/frontend",
"name": "area/frontend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"Implementing this in the SDK, one suggestion would be to follow the same principle as #5757 and add a description decorator that would assign a private field to the pipeline function (e.g. `_param_descriptions`). The compiler would read this field, and write it to the pipeline yaml.\r\n\r\n`{\"name\": \"num_batches\", \"type\": \"Integer\"}` could then become `{\"name\": \"num_batches\", \"type\": \"Integer\", \"description\": \"Number of batches to train\"}` if it had the decorator `@pipeline_param_description(num_batches='Number of batches to train')`\r\n",
"/cc @chensun \r\nAnother issue that requires adding metadata to parameters.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-29T16:26:49" | "2022-03-03T04:05:26" | "2022-03-03T04:05:26" | NONE | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
/area frontend
/area backend
/area sdk
<!-- /area samples -->
<!-- /area components -->
### What feature would you like to see?
<!-- Provide a description of this feature and the user experience. -->
Pipeline parameter descriptions / comments, as offered by e.g. Jenkins.
In the UI, pipeline parameters would have an optional field that describes that parameter. For example any considerations to make when deciding on the parameter value, how it would interact with other pipeline parameters, etc.
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
As of today, documentation is only visible in the source code of the pipeline definition (if it exists). Adding this to PipelineParam would make it visible in the UI, but still have it documented in the code.
Suggestions:
- parse docstrings
- add a 'description' field to PipelineParam
### Is there a workaround currently?
As of today, documentation is forced to be separate from the pipeline. Giving it a native place would increase developer productivity and onboarding.
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5758/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5758/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5757 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5757/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5757/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5757/events | https://github.com/kubeflow/pipelines/issues/5757 | 906,507,364 | MDU6SXNzdWU5MDY1MDczNjQ= | 5,757 | [feature] Multiple choice pipeline parameter | {
"login": "skogsbrus",
"id": 17073827,
"node_id": "MDQ6VXNlcjE3MDczODI3",
"avatar_url": "https://avatars.githubusercontent.com/u/17073827?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skogsbrus",
"html_url": "https://github.com/skogsbrus",
"followers_url": "https://api.github.com/users/skogsbrus/followers",
"following_url": "https://api.github.com/users/skogsbrus/following{/other_user}",
"gists_url": "https://api.github.com/users/skogsbrus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skogsbrus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skogsbrus/subscriptions",
"organizations_url": "https://api.github.com/users/skogsbrus/orgs",
"repos_url": "https://api.github.com/users/skogsbrus/repos",
"events_url": "https://api.github.com/users/skogsbrus/events{/privacy}",
"received_events_url": "https://api.github.com/users/skogsbrus/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930619516,
"node_id": "MDU6TGFiZWw5MzA2MTk1MTY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/frontend",
"name": "area/frontend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"Haven't dived deep enough into kubeflow's implementation to know how compilation works and how this would propagate to the UI / API, but I'm thinking something along the lines of this (akin to the `@pipeline` decorator):\r\n\r\n```\r\nfrom functools import wraps\r\n\r\ndef pipeline_multiplechoice(**valid_kwargs):\r\n def verify_inputs(passed_kwargs):\r\n for k, v in passed_kwargs.items():\r\n if k in valid_kwargs and v not in valid_kwargs[k]:\r\n raise ValueError(f\"{v} is not a valid value for {k}. Choose from {valid_kwargs[k]}\")\r\n\r\n def decorator(f):\r\n @wraps(f)\r\n def wrapper(*f_args, **f_kwargs):\r\n verify_inputs(f_kwargs)\r\n return f(*f_args, **f_kwargs)\r\n return wrapper\r\n return decorator\r\n\r\n\r\n@pipeline_multiplechoice(\r\n a={\"a1\", \"a2\", \"a3\"},\r\n b={\"b1\", \"b2\", \"b3\"},\r\n c={\"c1\", \"c2\", \"c3\"}\r\n)\r\ndef function(a, b, c):\r\n print(f\"{a=}\")\r\n print(f\"{b=}\")\r\n print(f\"{c=}\")\r\n\r\n\r\nif __name__ == \"__main__\":\r\n # valid\r\n function(a='a1',b='b2',c='c3')\r\n # invalid\r\n function(a=1,b=2,c=3)\r\n```",
"So I've read up _a bit_ more on the [compiler](https://kubeflow-pipelines.readthedocs.io/en/stable/_modules/kfp/compiler/compiler.html#Compiler.compile) and this looks like a pretty easy add-on.\r\n\r\n1. The decorator assigns e.g. `_multiplechoice` to the function object\r\n2. The compiler checks if the pipeline function has a `_multiplechoice` field, and if it does writes these values to the pipeline yaml. \r\n\r\n`\"inputs\": [{\"name\": \"num_batches\", \"type\": \"Integer\"}` could for example become `\"inputs\": [{\"name\": \"num_batches\", \"type\": \"Integer\", \"valid_values\": [0, 100, 1000]}` if it had a multiplechoice decorator.\r\n\r\nFinally, adding the necessary validations in frontend and API would also be necessary.\r\n\r\nI'd be happy to do the work on this, but would appreciate any thoughts on the matter before I commence :slightly_smiling_face: ",
"An alternative approach would be to add these options to the existing `pipeline` decorator.\r\n\r\nFor example:\r\n```\r\n@dsl.pipeline(\r\n name=\"training-pipeline\",\r\n description=\"Trains a model\",\r\n num_batches_options={0,100,1000},\r\n learning_rate_options={0.1, 0.01, 0.001, 0.0001},\r\n num_batches_description=\"Number of batches to train\",\r\n learning_rate_description=\"Learning rate of the optimizer\"\r\n)\r\ndef my_training_pipeline(num_batches: int, learning_rate: float):\r\n pass\r\n\r\n```\r\n\r\nThen in order to match e.g. `num_batches` to `num_batches_options` and `num_batches_description`, we'd need `inspect.getfullargspec` to retrieve the parameter names in `my_training_pipeline`.\r\n\r\nThis would be a pretty nice solution IMO:\r\n- We solve this and #5758 in one implementation\r\n- We keep the dsl tidy: one pipeline decorator only\r\n- No backwards compat. issues, since these would be optional keyword arguments in the decorator\r\n- Extensible: if we need to pass more information in the future, we simply add support for new `<argname>_<specifier>` arguments to the pipeline decorator",
"/cc @chensun \r\nWhat do you think? We need to start from letting people specify extra metadata on parameters first to support this.",
"Would be cool if we could make this into generic validations for parameters, I have a need for validating things like names so that they fit into the Kubenetes validations",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-29T16:19:07" | "2022-03-03T04:05:18" | "2022-03-03T04:05:18" | NONE | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
/area frontend
/area backend
/area sdk
<!-- /area samples -->
<!-- /area components -->
### What feature would you like to see?
<!-- Provide a description of this feature and the user experience. -->
Multiple choice pipeline parameters, as offered by e.g. Jenkins.
User experience:
- When triggering a run via UI, all valid multiple choice values are displayed as radio buttons. The user selects one of them.
- When triggering a run via API with a bad parameter value, the user gets an error response (400) with a message explaining the valid values for the relevant parameter.
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
As of today, multiple choice parameters are implicit. Users have to know the implementation details of the pipeline in order to know which values are permitted.
This discourages unfamiliar users to use the pipeline, as well as being an obstacle in the workflow of the ordinary developer. Having it available as a native form of PipelineParam would:
1. Enable people that have not read the pipeline definition to trigger a run
2. Increase documentation: having multiple choice parameters is a form of 'documentation as code'
### Is there a workaround currently?
Validate parameter value inside the relevant component.
This is hidden from the user. The user has to trigger the pipeline, watch it fail, and then check the logs in order to find out what went wrong. This also assumes that the pipeline developer has put in the effort of making a well formatted error message.
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5757/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5757/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5756 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5756/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5756/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5756/events | https://github.com/kubeflow/pipelines/issues/5756 | 906,301,623 | MDU6SXNzdWU5MDYzMDE2MjM= | 5,756 | Kfp cli throwing an error: Error: No such command 'submit'. | {
"login": "priya170807",
"id": 47265581,
"node_id": "MDQ6VXNlcjQ3MjY1NTgx",
"avatar_url": "https://avatars.githubusercontent.com/u/47265581?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/priya170807",
"html_url": "https://github.com/priya170807",
"followers_url": "https://api.github.com/users/priya170807/followers",
"following_url": "https://api.github.com/users/priya170807/following{/other_user}",
"gists_url": "https://api.github.com/users/priya170807/gists{/gist_id}",
"starred_url": "https://api.github.com/users/priya170807/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/priya170807/subscriptions",
"organizations_url": "https://api.github.com/users/priya170807/orgs",
"repos_url": "https://api.github.com/users/priya170807/repos",
"events_url": "https://api.github.com/users/priya170807/events{/privacy}",
"received_events_url": "https://api.github.com/users/priya170807/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Hi @priya170807, it seems you should move `--endpoint $ENDPOINT` argument to after `run submit`,\r\n\r\ne.g.\r\n```\r\nkfp run submit --endpoint $ENDPOINT ...\r\n```",
"> \r\n> \r\n> Hi @priya170807, it seems you should move `--endpoint $ENDPOINT` argument to after `run submit`,\r\n> \r\n> e.g.\r\n> \r\n> ```\r\n> kfp run submit --endpoint $ENDPOINT ...\r\n> ```\r\n\r\n"
] | "2021-05-29T02:27:13" | "2021-06-03T19:51:32" | "2021-06-03T19:51:32" | NONE | null | Hi,
I have created a pipeline and compile it. I am getting an error submitting a run to the end point.
Command:
`!kfp --endpoint $ENDPOINT run submit \ -e $EXPERIMENT_NAME \ -r $RUN_ID \ -p $PIPELINE_ID \ project_id=$PROJECT_ID \ gcs_root=$GCS_STAGING_PATH \ region=$REGION \ source_bucket_name=$SOURCE_BUCKET_NAME \ source_prefix=$SOURCE_PREFIX \ dest_bucket_name=$DEST_BUCKET_NAME \ dest_prefix=$DEST_PREFIX \ dest_file_name=$DEST_FILE_NAME \ evaluation_metric_name=$EVALUATION_METRIC \ evaluation_metric_threshold=$EVALUATION_METRIC_THRESHOLD \ model_id=$MODEL_ID \ version_id=$VERSION_ID \ replace_existing_version=$REPLACE_EXISTING_VERSION`
Error:
Usage: kfp [OPTIONS] COMMAND [ARGS]...
Try 'kfp --help' for help.
**Error: No such command 'submit'.**
Any help is appreciated.
Priya | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5756/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5756/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5755 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5755/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5755/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5755/events | https://github.com/kubeflow/pipelines/issues/5755 | 906,269,825 | MDU6SXNzdWU5MDYyNjk4MjU= | 5,755 | [chore] Add the components/kfp/Run_Component sample to the v2 sample tests | {
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1260031624,
"node_id": "MDU6TGFiZWwxMjYwMDMxNjI0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/samples",
"name": "area/samples",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-29T01:04:12" | "2022-03-03T06:05:20" | "2022-03-03T06:05:20" | CONTRIBUTOR | null | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5755/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5755/timeline | null | completed | null | null | false |
|
https://api.github.com/repos/kubeflow/pipelines/issues/5754 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5754/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5754/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5754/events | https://github.com/kubeflow/pipelines/issues/5754 | 906,263,954 | MDU6SXNzdWU5MDYyNjM5NTQ= | 5,754 | [sdk] failed to create Cloud Scheduler job when App Engine location and Pipeline region are different | {
"login": "hideto0710",
"id": 13478110,
"node_id": "MDQ6VXNlcjEzNDc4MTEw",
"avatar_url": "https://avatars.githubusercontent.com/u/13478110?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hideto0710",
"html_url": "https://github.com/hideto0710",
"followers_url": "https://api.github.com/users/hideto0710/followers",
"following_url": "https://api.github.com/users/hideto0710/following{/other_user}",
"gists_url": "https://api.github.com/users/hideto0710/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hideto0710/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hideto0710/subscriptions",
"organizations_url": "https://api.github.com/users/hideto0710/orgs",
"repos_url": "https://api.github.com/users/hideto0710/repos",
"events_url": "https://api.github.com/users/hideto0710/events{/privacy}",
"received_events_url": "https://api.github.com/users/hideto0710/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"workaround\r\n1. path region\r\n2. fix Cloud Scheduler Job [request body `_url`](https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/v2/google/client/schedule.py#L108)\r\n\r\n```python\r\nfrom kfp.v2.google.client.schedule import create_from_pipeline_file\r\nresponse = create_from_pipeline_file(\r\n project_id=PROJECT_ID,\r\n region=\"asia-northeast1\",\r\n pipeline_path=\"hw_pipeline_job.json\",\r\n schedule=\"2 * * * *\",\r\n time_zone=\"America/Los_Angeles\", # change this as necessary\r\n parameter_values={\"text\": \"Hello world!\"},\r\n # pipeline_root=PIPELINE_ROOT # this argument is necessary if you did not specify PIPELINE_ROOT as part of the pipeline definition.\r\n)\r\n```",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-29T00:49:09" | "2022-03-03T06:05:19" | "2022-03-03T06:05:19" | NONE | null | ### Environment
* KFP version:
Vertex Pipelines
* KFP SDK version:
```
!pip list | grep kfp
kfp 1.6.2
kfp-pipeline-spec 0.1.7
kfp-server-api 1.6.0
```
### Steps to reproduce
Create App Engine app in asia-northeast1 and follow [this notebook](https://github.com/GoogleCloudPlatform/ai-platform-samples/blob/master/ai-platform-unified/notebooks/unofficial/pipelines/pipelines_intro_kfp.ipynb).
```console
!gcloud app describe --project $PROJECT_ID
authDomain: gmail.com
codeBucket: staging.PROJECT_ID.appspot.com
databaseType: CLOUD_FIRESTORE
defaultBucket: PROJECT_ID.appspot.com
defaultHostname: PROJECT_ID.an.r.appspot.com
featureSettings:
splitHealthChecks: true
useContainerOptimizedOs: true
gcrDomain: asia.gcr.io
id: PROJECT_ID
locationId: asia-northeast1
name: apps/PROJECT_ID
servingStatus: SERVING
```
```python
REGION = "us-central1"
```
```python
from kfp.v2.google.client import AIPlatformClient # noqa: F811
api_client = AIPlatformClient(
project_id=PROJECT_ID,
region=REGION,
)
response = api_client.create_schedule_from_job_spec(
job_spec_path="hw_pipeline_job.json",
schedule="2 * * * *",
time_zone="America/Los_Angeles", # change this as necessary
parameter_values={"text": "Hello world!"},
# pipeline_root=PIPELINE_ROOT # this argument is necessary if you did not specify PIPELINE_ROOT as part of the pipeline definition.
)
```
```console
HttpError: <HttpError 400 when requesting https://cloudscheduler.googleapis.com/v1/projects/PROJECT_ID/locations/us-central1/jobs?alt=json returned "Location must equal asia-northeast1 because the App Engine app that is associated with this project is located in asia-northeast1". Details: "Location must equal asia-northeast1 because the App Engine app that is associated with this project is located in asia-northeast1">
```
### Expected result
Cloud Scheduler Job and Cloud Function will be created in specified location.
Should be able to pass **scheduler job** location.
### Materials and Reference
- https://cloud.google.com/scheduler/docs#supported_regions
- https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/v2/google/client/schedule.py#L40
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5754/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5754/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5753 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5753/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5753/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5753/events | https://github.com/kubeflow/pipelines/issues/5753 | 905,170,076 | MDU6SXNzdWU5MDUxNzAwNzY= | 5,753 | [v2compat] support s3 pipeline_root with endpoint, region, insecure etc | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 2152751095,
"node_id": "MDU6TGFiZWwyMTUyNzUxMDk1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/frozen",
"name": "lifecycle/frozen",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"/lifecycle frozen",
"@bobgy TFX pipelines already supports this by appending pipeline wide env vars and by not assuming a default S3 instance. Using another Minio is basically the only viable option for on-prem deployments.",
"Closing as v2 compatible mode is no longer supported."
] | "2021-05-28T10:53:24" | "2023-01-18T08:21:56" | "2023-01-18T08:21:56" | CONTRIBUTOR | null | Part of https://github.com/kubeflow/pipelines/issues/5704
Support s3 pipeline_root with generic options: endpoint, region, insecure, etc, so that it can be used with user maintained MinIO or other compatible storages.
Credentials can be set similar to aws/gcp credentials, but not using the same env vars as AWS. (Needs a detailed design) | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5753/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5753/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5809 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5809/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5809/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5809/events | https://github.com/kubeflow/pipelines/issues/5809 | 913,480,000 | MDU6SXNzdWU5MTM0ODAwMDA= | 5,809 | Declarative Pipeline deployment | {
"login": "jmendesky",
"id": 56542576,
"node_id": "MDQ6VXNlcjU2NTQyNTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/56542576?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jmendesky",
"html_url": "https://github.com/jmendesky",
"followers_url": "https://api.github.com/users/jmendesky/followers",
"following_url": "https://api.github.com/users/jmendesky/following{/other_user}",
"gists_url": "https://api.github.com/users/jmendesky/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jmendesky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jmendesky/subscriptions",
"organizations_url": "https://api.github.com/users/jmendesky/orgs",
"repos_url": "https://api.github.com/users/jmendesky/repos",
"events_url": "https://api.github.com/users/jmendesky/events{/privacy}",
"received_events_url": "https://api.github.com/users/jmendesky/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930476737,
"node_id": "MDU6TGFiZWw5MzA0NzY3Mzc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/help%20wanted",
"name": "help wanted",
"color": "db1203",
"default": true,
"description": "The community is welcome to contribute."
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"@jmendesky Could you please move this issue to https://github.com/kubeflow/pipelines so that the feature request can be properly tracked? The Pipeline developers do not regularly go through the issues in this repository. ",
"cc @Bobgy I think you have permissions to move the issue.",
"Would be happy to move it but I don't have the permissions and would have to close this issue and reopen it again.",
"Thanks for the proposal, I just transferred this issue",
"I'm curious why an operator would be preferred over kustomize manifests: https://github.com/kubeflow/pipelines/tree/master/manifests/kustomize.\r\n\r\nSee documentation: https://www.kubeflow.org/docs/components/pipelines/installation/standalone-deployment/",
"Thanks for getting back :)\r\nI am referring to submitting an actual ML pipeline to a running KubeFlow Pipelines instance rather than installing Kubeflow Pipelines using an operator.",
"Understood, welcome contribution on this area",
"We are currently discussing a potential solution internally in our team. Once we have clarified our requirements and come up with an initial design we should be able to present our approach and then see whether it makes sense to contribute it to the community.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-28T08:15:53" | "2022-03-03T03:05:19" | "2022-03-03T03:05:19" | NONE | null | /kind feature
Good morning,
when deploying ML pipelines, we would like to build on existing tooling and follow similar patterns as when deploying other resources to our infrastructure. This would usually be done declaratively rather than programmatically. From our research, it seems that the only way to deploy Kubeflow pipelines at the moment is to use either kfctl or the Kubeflow Client libraries.
**Why you need this feature:**
Instead of having to execute Kubeflow clients, we'd like to have a declarative way of deploying Kubeflow Pipelines.
**Describe the solution you'd like:**
Provide a Kubeflow Pipeline Custom Resource Definition which gets picked up by an operator which then applies the changes to Kubeflow.
**Anything else you would like to add:**
We are considering implementing the above approach but would like to validate whether this would be useful for other people as well or whether something similar already exists. | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5809/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5809/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5748 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5748/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5748/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5748/events | https://github.com/kubeflow/pipelines/issues/5748 | 904,401,031 | MDU6SXNzdWU5MDQ0MDEwMzE= | 5,748 | [frontend] CRON schedule default in UI once per minute - too frequent | {
"login": "hsezhiyan",
"id": 40924035,
"node_id": "MDQ6VXNlcjQwOTI0MDM1",
"avatar_url": "https://avatars.githubusercontent.com/u/40924035?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsezhiyan",
"html_url": "https://github.com/hsezhiyan",
"followers_url": "https://api.github.com/users/hsezhiyan/followers",
"following_url": "https://api.github.com/users/hsezhiyan/following{/other_user}",
"gists_url": "https://api.github.com/users/hsezhiyan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsezhiyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsezhiyan/subscriptions",
"organizations_url": "https://api.github.com/users/hsezhiyan/orgs",
"repos_url": "https://api.github.com/users/hsezhiyan/repos",
"events_url": "https://api.github.com/users/hsezhiyan/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsezhiyan/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930476737,
"node_id": "MDU6TGFiZWw5MzA0NzY3Mzc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/help%20wanted",
"name": "help wanted",
"color": "db1203",
"default": true,
"description": "The community is welcome to contribute."
},
{
"id": 930619516,
"node_id": "MDU6TGFiZWw5MzA2MTk1MTY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/frontend",
"name": "area/frontend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 2186355346,
"node_id": "MDU6TGFiZWwyMTg2MzU1MzQ2",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/good%20first%20issue",
"name": "good first issue",
"color": "fef2c0",
"default": true,
"description": ""
}
] | closed | false | {
"login": "difince",
"id": 11557050,
"node_id": "MDQ6VXNlcjExNTU3MDUw",
"avatar_url": "https://avatars.githubusercontent.com/u/11557050?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/difince",
"html_url": "https://github.com/difince",
"followers_url": "https://api.github.com/users/difince/followers",
"following_url": "https://api.github.com/users/difince/following{/other_user}",
"gists_url": "https://api.github.com/users/difince/gists{/gist_id}",
"starred_url": "https://api.github.com/users/difince/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/difince/subscriptions",
"organizations_url": "https://api.github.com/users/difince/orgs",
"repos_url": "https://api.github.com/users/difince/repos",
"events_url": "https://api.github.com/users/difince/events{/privacy}",
"received_events_url": "https://api.github.com/users/difince/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "difince",
"id": 11557050,
"node_id": "MDQ6VXNlcjExNTU3MDUw",
"avatar_url": "https://avatars.githubusercontent.com/u/11557050?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/difince",
"html_url": "https://github.com/difince",
"followers_url": "https://api.github.com/users/difince/followers",
"following_url": "https://api.github.com/users/difince/following{/other_user}",
"gists_url": "https://api.github.com/users/difince/gists{/gist_id}",
"starred_url": "https://api.github.com/users/difince/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/difince/subscriptions",
"organizations_url": "https://api.github.com/users/difince/orgs",
"repos_url": "https://api.github.com/users/difince/repos",
"events_url": "https://api.github.com/users/difince/events{/privacy}",
"received_events_url": "https://api.github.com/users/difince/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Hi @hsezhiyan, this sounds reasonable.\r\nWelcome contribution on this",
"/cc @zijianjoy \r\nwhat do you think?",
"I agree with making `run every hour` as the default setting. To me it usually is too frequent as once per minute, and it actually takes longer than 1 minute to start the recurring run in my case. So I fell into confusion that `why doesn't the recurring run happens within 1 minute since I create this recurring run?` in the past. \r\n\r\nWelcome for contribution! Code location:\r\nhttps://github.com/kubeflow/pipelines/blob/HEAD/frontend/src/components/Trigger.tsx#L125",
"Hi @Bobgy, @zijianjoy Can I work on this issue ? ",
"@difince Sure, you are welcome to work on this!",
"/assign difince"
] | "2021-05-27T23:52:48" | "2021-06-10T21:34:02" | "2021-06-10T21:34:02" | NONE | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
We deployed by using the Kubeflow manifests, which comes with the default UI provided in this repo.
* KFP version: `v.1.2.0`
### Issue
When you do onto the Kubeflow UI and try to create a recurring run, the default periodic scheduled/cron schedule is `once per minute`, or `0 * * * *`.
Our deployment of Kubeflow is now being used by a large number of customers, so there is a real possibility that a customer will accidentally schedule a large pipeline run every minute. There is also the possibility that someone will experiment with scheduled runs and forget to the off the run after done testing. In both these scenarios, there will be a lot of wasteful use of the K8s clusters (added cost) and possible overloading of the cluster (affecting SLAs, reducing reliability).
Is it possible to remove the "run every minute" dropdown menu bar, or at least make the "run every hour" the default setting?
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5748/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5748/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5746 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5746/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5746/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5746/events | https://github.com/kubeflow/pipelines/issues/5746 | 904,166,231 | MDU6SXNzdWU5MDQxNjYyMzE= | 5,746 | [feature] Add retry in dataproc component | {
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930476737,
"node_id": "MDU6TGFiZWw5MzA0NzY3Mzc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/help%20wanted",
"name": "help wanted",
"color": "db1203",
"default": true,
"description": "The community is welcome to contribute."
},
{
"id": 930619513,
"node_id": "MDU6TGFiZWw5MzA2MTk1MTM=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/priority/p1",
"name": "priority/p1",
"color": "cb03cc",
"default": false,
"description": ""
},
{
"id": 1126834402,
"node_id": "MDU6TGFiZWwxMTI2ODM0NDAy",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/components",
"name": "area/components",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
},
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"This issue is breaking customers who are using https://github.com/kubeflow/pipelines/tree/master/components/gcp/dataproc/submit_pyspark_job with large data sets."
] | "2021-05-27T20:37:11" | "2021-07-30T23:18:36" | "2021-07-30T23:18:36" | CONTRIBUTOR | null | ### Feature Area
/area components
### What feature would you like to see?
Add retry in dataproc component. Similar to https://github.com/kubeflow/pipelines/pull/5250
<!-- Provide a description of this feature and the user experience. -->
### What is the use case or pain point?
`BrokenPipeError` when using https://github.com/kubeflow/pipelines/tree/master/components/gcp/dataproc/submit_pyspark_job with large datasets
<!-- It helps us understand the benefit of this feature for your use case. -->
### Is there a workaround currently?
<!-- Without this feature, how do you accomplish your task today? -->
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5746/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5746/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5745 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5745/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5745/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5745/events | https://github.com/kubeflow/pipelines/issues/5745 | 904,162,924 | MDU6SXNzdWU5MDQxNjI5MjQ= | 5,745 | Error occured while trying to proxy to: pipelines/upload | {
"login": "gordonsilvera",
"id": 13377661,
"node_id": "MDQ6VXNlcjEzMzc3NjYx",
"avatar_url": "https://avatars.githubusercontent.com/u/13377661?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gordonsilvera",
"html_url": "https://github.com/gordonsilvera",
"followers_url": "https://api.github.com/users/gordonsilvera/followers",
"following_url": "https://api.github.com/users/gordonsilvera/following{/other_user}",
"gists_url": "https://api.github.com/users/gordonsilvera/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gordonsilvera/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gordonsilvera/subscriptions",
"organizations_url": "https://api.github.com/users/gordonsilvera/orgs",
"repos_url": "https://api.github.com/users/gordonsilvera/repos",
"events_url": "https://api.github.com/users/gordonsilvera/events{/privacy}",
"received_events_url": "https://api.github.com/users/gordonsilvera/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Note, this is corrected by specifying a namespace (rather than accepting \"Default\"). ",
"Strange, I don't expect it being a problem when namespace is default.\r\nThere might be sth else going wrong.\r\n\r\nI guess we'll have to wait for more feedback",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-27T20:32:53" | "2022-03-03T04:05:26" | "2022-03-03T04:05:26" | NONE | null | When entering the Kubeflow Pipeline, received the error:
```
Error occured while trying to proxy to:
#############-dot-us-central1.pipelines.googleusercontent.com/apis/v1beta1/pipelines?page_token=&page_size=10&sort_by=created_at%20desc&filter=
```
### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
Via the [GCP AI Platform Pipelines UI](https://console.cloud.google.com/ai-platform/pipelines/clusters). This instance uses managed storage.
* KFP version: **1.4.1**
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version:
```
kfp 1.6.2
kfp-pipeline-spec 0.1.7
kfp-server-api 1.6.0
```
### Steps to reproduce
1. Initially, I tried to load the pipeline from GCP hosted Jupyter Notebook via the Python API:
```
self.load_response = self.client.upload_pipeline(
pipeline_package_path=self.pipeline_path,
pipeline_name=self.pipeline_name,
description=self.pipeline_description
)
```
I also tried to enter `client.list_pipelines()` in a hosted Notebook. In both scenarios, I receive the error: "Error 504 (Gateway Timeout)!"
2. Secondly, I tried to upload the .zip from the Kubeflow dashboards interface. The screenshot below shows the error message I received.
[Error in Kubeflow Dashboard](https://storage.googleapis.com/algom-tmp-files/Screen%20Shot%202021-05-27%20at%2010.20.50%20PM.png)
### Expected result
Expect for pipeline to be added to Kubeflow interface.
### Materials and Reference
Based on the error logs, the source of the issue is the initialization of MySQL. The container logs show multiple errors after initialization, MySQL shuts down, reinitializes ... and this cycle repeats itself. Also, **this error did not occur when not using managed storage**.
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5745/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5745/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5744 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5744/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5744/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5744/events | https://github.com/kubeflow/pipelines/issues/5744 | 903,903,119 | MDU6SXNzdWU5MDM5MDMxMTk= | 5,744 | [bug] Can't run kubeflow pipeline | {
"login": "hanpeiyu94",
"id": 37461004,
"node_id": "MDQ6VXNlcjM3NDYxMDA0",
"avatar_url": "https://avatars.githubusercontent.com/u/37461004?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hanpeiyu94",
"html_url": "https://github.com/hanpeiyu94",
"followers_url": "https://api.github.com/users/hanpeiyu94/followers",
"following_url": "https://api.github.com/users/hanpeiyu94/following{/other_user}",
"gists_url": "https://api.github.com/users/hanpeiyu94/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hanpeiyu94/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hanpeiyu94/subscriptions",
"organizations_url": "https://api.github.com/users/hanpeiyu94/orgs",
"repos_url": "https://api.github.com/users/hanpeiyu94/repos",
"events_url": "https://api.github.com/users/hanpeiyu94/events{/privacy}",
"received_events_url": "https://api.github.com/users/hanpeiyu94/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1260031624,
"node_id": "MDU6TGFiZWwxMjYwMDMxNjI0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/samples",
"name": "area/samples",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"What is the version of KFP when you use Kubeflow on MicroK8s?",
"Sorry, I already deleted MicroK8s. I did not install KFP on my own, and I am not sure KFP is installed by MicroK8s or not. In case i am not understanding this correctly. Do you have to install Kubeflow pipeline after install Kubeflow in order to run pipeline? ",
"No, you only need to install kubeflow, but I am not clear on the kubeflow pipelines version included",
"how do you check kubeflow pipelines version? I'll reinstall Microk8s to check it for you.\r\n",
"On the kubeflow dashboard under Experiment(KFP) tab, It shows Version: 1.5.0-rc.0. Hope this is what you are looking for.\r\n",
"Thank you, this seems a problem with microk8s's kubeflow distribution. Do you know how to contact them?",
"Thanks for you help, I am not using Microk8s for right now, I'll ask them when I need to. "
] | "2021-05-27T15:19:07" | "2021-06-04T21:18:19" | "2021-06-04T21:18:19" | NONE | null | ### What steps did you take
Running Kubeflow on Microk8s cluster that is running on my local computer.
Got access to Kubeflow dashboard and trying to run pipeline.
<!-- A clear and concise description of what the bug is.-->
### What happened:
When I try to run any of the pipeline examples, The job never show up on `Runs` tab. And when I try to create experiment, it has this error:
```
{"error":"Validate experiment request failed.: Invalid input error: In single-user mode, CreateExperimentRequest shouldn't contain resource references.","code":3,"message":"Validate experiment request failed.: Invalid input error: In single-user mode, CreateExperimentRequest shouldn't contain resource references.","details":[{"@type":"type.googleapis.com/api.Error","error_message":"In single-user mode, CreateExperimentRequest shouldn't contain resource references.","error_details":"Validate experiment request failed.: Invalid input error: In single-user mode, CreateExperimentRequest shouldn't contain resource references."}]}
```
### What did you expect to happen:
To be able to run the example pipeline.
### Environment:
Microk8s v1.21
<!-- Please fill in those that seem relevant. -->
* How do you deploy Kubeflow Pipelines (KFP)?
I am not sure if KFP is need if Kubeflow is deployed by Microk8s
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version:
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
### Anything else you would like to add:
<!-- Miscellaneous information that will assist in solving the issue.-->
### Labels
<!-- Please include labels below by uncommenting them to help us better triage issues -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
<!-- /area testing -->
/area samples
<!-- /area components -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5744/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5744/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5741 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5741/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5741/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5741/events | https://github.com/kubeflow/pipelines/issues/5741 | 903,537,224 | MDU6SXNzdWU5MDM1MzcyMjQ= | 5,741 | [bug] FutureWarning raised on VolumeOp.delete() | {
"login": "skogsbrus",
"id": 17073827,
"node_id": "MDQ6VXNlcjE3MDczODI3",
"avatar_url": "https://avatars.githubusercontent.com/u/17073827?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skogsbrus",
"html_url": "https://github.com/skogsbrus",
"followers_url": "https://api.github.com/users/skogsbrus/followers",
"following_url": "https://api.github.com/users/skogsbrus/following{/other_user}",
"gists_url": "https://api.github.com/users/skogsbrus/gists{/gist_id}",
"starred_url": "https://api.github.com/users/skogsbrus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skogsbrus/subscriptions",
"organizations_url": "https://api.github.com/users/skogsbrus/orgs",
"repos_url": "https://api.github.com/users/skogsbrus/repos",
"events_url": "https://api.github.com/users/skogsbrus/events{/privacy}",
"received_events_url": "https://api.github.com/users/skogsbrus/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"/cc @elikatsis ",
"/cc @chensun ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-27T10:39:56" | "2022-03-03T04:05:27" | "2022-03-03T04:05:27" | NONE | null | ### What steps did you take
<!-- A clear and concise description of what the bug is.-->
A FutureWarning re: direct use of `ContainerOp` is raised when using `VolumeOp.delete()`
```
# example.py
import kfp
def pipeline_with_delete():
data_vop = kfp.dsl.VolumeOp(name='create-data-volume', resource_name='data-volume', size="2Gi")
data_vop.delete()
def pipeline_without_delete():
data_vop = kfp.dsl.VolumeOp(name='create-data-volume', resource_name='data-volume', size="2Gi")
if __name__ == "__main__":
print("Pipeline with delete")
kfp.compiler.Compiler().compile(pipeline_with_delete, "pipeline.yaml")
print("Pipeline without delete")
kfp.compiler.Compiler().compile(pipeline_without_delete, "pipeline.yaml")
print("-"*40)
print(f"KFP version: {kfp.__version__}")
print("-"*40)
```
### What happened:
```
$ python example.py
Pipeline with delete
.../venv/lib/python3.8/site-packages/kfp/dsl/_container_op.py:1149: FutureWarning: Please create reusable components instead of constructing ContainerOp instances directly. Reusable components are shareable, portable and have compatibility and support guarantees. Please see the documentation: https://www.kubeflow.org/docs/pipelines/sdk/component-development/#writing-your-component-definition-file The components can be created manually (or, in case of python, using kfp.components.create_component_from_func or func_to_container_op) and then loaded using kfp.components.load_component_from_file, load_component_from_uri or load_component_from_text: https://kubeflow-pipelines.readthedocs.io/en/stable/source/kfp.components.html#kfp.components.load_component_from_file
warnings.warn(
Pipeline without delete
----------------------------------------
KFP version: 1.6.2
----------------------------------------
```
### What did you expect to happen:
There is no direct use of ContainerOp in this example. The warning should not have been raised.
AFAIK using volumes is not detrimental to reusability of components, so the warning doesn't seem relevant either.
### Environment:
<!-- Please fill in those that seem relevant. -->
* KFP SDK version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
```
kfp 1.6.2
kfp-pipeline-spec 0.1.7
kfp-server-api 1.5.0
```
### Anything else you would like to add:
<!-- Miscellaneous information that will assist in solving the issue.-->
### Labels
<!-- Please include labels below by uncommenting them to help us better triage issues -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
<!-- /area testing -->
<!-- /area samples -->
<!-- /area components -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5741/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5741/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5737 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5737/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5737/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5737/events | https://github.com/kubeflow/pipelines/issues/5737 | 901,725,933 | MDU6SXNzdWU5MDE3MjU5MzM= | 5,737 | [frontend] Add `Create Experiment` button when selecting experiement | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930619516,
"node_id": "MDU6TGFiZWw5MzA2MTk1MTY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/frontend",
"name": "area/frontend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 2152751095,
"node_id": "MDU6TGFiZWwyMTUyNzUxMDk1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/frozen",
"name": "lifecycle/frozen",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 2186355346,
"node_id": "MDU6TGFiZWwyMTg2MzU1MzQ2",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/good%20first%20issue",
"name": "good first issue",
"color": "fef2c0",
"default": true,
"description": ""
}
] | open | false | null | [] | null | [
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"/lifecycle frozen"
] | "2021-05-26T04:08:57" | "2021-09-14T05:57:18" | null | COLLABORATOR | null |
### Steps to reproduce
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
In Full Kubeflow mode, select a pipeline and click `Create Run`. During selecting experiment, open a dialog to select existing experiment.
By default, there is no available experiment, but there is no way to create new experiment on the current dialog. User needs to go back to experiment entry to create one.
### Expected result
<!-- What should the correct behavior be? -->
Have a button on experiment selection dialog to create experiment. Or automatically create one experiment for user.
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5737/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5737/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5730 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5730/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5730/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5730/events | https://github.com/kubeflow/pipelines/issues/5730 | 899,947,661 | MDU6SXNzdWU4OTk5NDc2NjE= | 5,730 | [backend] Wait container stuck. | {
"login": "boarder7395",
"id": 37314943,
"node_id": "MDQ6VXNlcjM3MzE0OTQz",
"avatar_url": "https://avatars.githubusercontent.com/u/37314943?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/boarder7395",
"html_url": "https://github.com/boarder7395",
"followers_url": "https://api.github.com/users/boarder7395/followers",
"following_url": "https://api.github.com/users/boarder7395/following{/other_user}",
"gists_url": "https://api.github.com/users/boarder7395/gists{/gist_id}",
"starred_url": "https://api.github.com/users/boarder7395/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/boarder7395/subscriptions",
"organizations_url": "https://api.github.com/users/boarder7395/orgs",
"repos_url": "https://api.github.com/users/boarder7395/repos",
"events_url": "https://api.github.com/users/boarder7395/events{/privacy}",
"received_events_url": "https://api.github.com/users/boarder7395/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1499519734,
"node_id": "MDU6TGFiZWwxNDk5NTE5NzM0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/upstream_issue",
"name": "upstream_issue",
"color": "006b75",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi @boarder7395, this issue seems only related to argo workflow.\r\nCan open up an issue in argo workflows github repo instead?",
"@Bobgy Sure! How familiar is the argo workflow team with kfp? If I submit the same code to replicate the issue will that be enough or should I update my code to replicate the issue to be argo workflow based and remove the kfp code?",
"Opened https://github.com/argoproj/argo-workflows/issues/6153 with the argo team. Going to mark this resolved here and this can be tracked with the issue over in argo."
] | "2021-05-24T19:36:24" | "2021-06-15T11:48:11" | "2021-06-15T11:48:11" | CONTRIBUTOR | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
EKS
* KFP version:
1.3.0
* KFP SDK version:
1.1.1
### Steps to reproduce
Using multiple processes in python to log messages causes the docker logs command in the argo wait container to get stuck indefinitely, resulting in the component running indefinitely even though the main container completed successfully. Exec'ing into the pod's wait container and killing the process results in the pipeline completing successfully.
Code snippet to replicate the issue.
```
import argparse
# You'll need these imports in your own code
import logging
import logging.handlers
import multiprocessing
# Next two import lines for this demo only
from random import choice, random
import time
#
# Because you'll want to define the logging configurations for listener and workers, the
# listener and worker process functions take a configurer parameter which is a callable
# for configuring logging for that process. These functions are also passed the queue,
# which they use for communication.
#
# In practice, you can configure the listener however you want, but note that in this
# simple example, the listener does not apply level or filter logic to received records.
# In practice, you would probably want to do this logic in the worker processes, to avoid
# sending events which would be filtered out between processes.
#
# The size of the rotated files is made small so you can see the results easily.
def listener_configurer():
root = logging.getLogger()
# h = logging.handlers.RotatingFileHandler('mptest.log', 'a', 300, 10)
h = logging.StreamHandler()
f = logging.Formatter('%(asctime)s %(processName)-10s %(name)s %(levelname)-8s %(message)s')
h.setFormatter(f)
root.addHandler(h)
def handle_command_line():
parser = argparse.ArgumentParser()
parser.add_argument('--n-logs', type=int, required=True, help='Number of logs to print.')
return parser.parse_args()
# This is the listener process top-level loop: wait for logging events
# (LogRecords)on the queue and handle them, quit when you get a None for a
# LogRecord.
def listener_process(queue, configurer):
configurer()
while True:
try:
record = queue.get()
if record is None: # We send this as a sentinel to tell the listener to quit.
break
logger = logging.getLogger(record.name)
logger.handle(record) # No level or filter logic applied - just do it!
except Exception:
import sys, traceback
print('Whoops! Problem:', file=sys.stderr)
traceback.print_exc(file=sys.stderr)
# Arrays used for random selections in this demo
LEVELS = [logging.DEBUG, logging.INFO, logging.WARNING,
logging.ERROR, logging.CRITICAL]
LOGGERS = ['a.b.c', 'd.e.f', 'd.e.f', 'g.h.i', 'j.k.l']
MESSAGES = [
'Random message #1',
'Random message #2',
'Random message #3',
'Random message #4',
'Random message #5',
]
# The worker configuration is done at the start of the worker process run.
# Note that on Windows you can't rely on fork semantics, so each process
# will run the logging configuration code when it starts.
def worker_configurer(queue):
h = logging.handlers.QueueHandler(queue) # Just the one handler needed
root = logging.getLogger()
root.addHandler(h)
# send all messages, for demo; no other level or filter logic applied.
root.setLevel(logging.DEBUG)
# This is the worker process top-level loop, which just logs ten events with
# random intervening delays before terminating.
# The print messages are just so you know it's doing something!
def worker_process(queue, configurer):
configurer(queue)
name = multiprocessing.current_process().name
print('Worker started: %s' % name)
for i in range(100):
time.sleep(random())
logger = logging.getLogger(choice(LOGGERS))
level = choice(LEVELS)
message = choice(MESSAGES)
logger.log(level, message)
print('Worker finished: %s' % name)
# Here's where the demo gets orchestrated. Create the queue, create and start
# the listener, create ten workers and start them, wait for them to finish,
# then send a None to the queue to tell the listener to finish.
def main():
queue = multiprocessing.Queue(-1)
listener = multiprocessing.Process(target=listener_process,
args=(queue, listener_configurer))
listener.start()
workers = []
for i in range(96):
worker = multiprocessing.Process(target=worker_process,
args=(queue, worker_configurer))
workers.append(worker)
worker.start()
for w in workers:
w.join()
queue.put_nowait(None)
listener.join()
if __name__ == '__main__':
main()
```
### Expected result
The pipeline should finish when the main container finishes.
### Materials and Reference
Minimal example. Comment out set_project (test.py line 76) call to remove taints specific to my cluster.
[debug.zip](https://github.com/kubeflow/pipelines/files/6534609/debug.zip)
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5730/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5730/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5728 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5728/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5728/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5728/events | https://github.com/kubeflow/pipelines/issues/5728 | 899,575,293 | MDU6SXNzdWU4OTk1NzUyOTM= | 5,728 | [feature] Merge Pipelines Profile Controller functionality into the general profile controller | {
"login": "DavidSpek",
"id": 28541758,
"node_id": "MDQ6VXNlcjI4NTQxNzU4",
"avatar_url": "https://avatars.githubusercontent.com/u/28541758?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/DavidSpek",
"html_url": "https://github.com/DavidSpek",
"followers_url": "https://api.github.com/users/DavidSpek/followers",
"following_url": "https://api.github.com/users/DavidSpek/following{/other_user}",
"gists_url": "https://api.github.com/users/DavidSpek/gists{/gist_id}",
"starred_url": "https://api.github.com/users/DavidSpek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DavidSpek/subscriptions",
"organizations_url": "https://api.github.com/users/DavidSpek/orgs",
"repos_url": "https://api.github.com/users/DavidSpek/repos",
"events_url": "https://api.github.com/users/DavidSpek/events{/privacy}",
"received_events_url": "https://api.github.com/users/DavidSpek/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Thank you for raising the concern @DavidSpek!\r\n\r\nLet me share some past context, at the time when KFP introduced KFP profile controller, we had many discussions with Kubeflow engineering team at Google (who was maintaining the main profile controller). The conclusion we reached was that it's better for everyone that KFP starts its own profile controller.\r\n\r\nThe major reason is to reduce coupling, KFP can be self contained and released on its own.\r\nIt's simpler for KFP to maintain its own profile controller than enhancing a special syntax in kubeflow profile controller and configure it to do so.\r\n\r\nFor more previous discussion, you can refer to @yanniszark's doc on profile management\r\n[Kubeflow: Evaluate and Improve our Multi-Tenancy Implementation](https://docs.google.com/document/d/11Xi-I2OqJvUuy_Zg0NskMF9GmworRDJhlu68poDgK5c/edit#heading=h.n8iafkmnb492)\r\n\r\n> ### Profile Plugins should be implemented as separate controllers\r\n> At the moment, Profile Plugins are implemented as additional code inside the Profile controller.\r\nThis monolithic approach isn’t scalable and also makes the plugin functionality non-reusable.\r\nInstead, plugins should follow a controller-like approach, where they watch for user-namespaces (e.g. with a specific label) and configure them accordingly.\r\nNew applications that need namespace-specific initialization should handle it themselves.\r\n",
"The difference between profile controller and #5681 is that, the nature of profile controller is user requests are ad-hoc:\r\n* kubeflow has its own resources it wants to deploy to user namespaces\r\n* KFP has some resources\r\n* KFServing has some resources\r\n* Kubeflow cluster admins may have some cluster-specific resources they want to deploy\r\n \r\nA generic profile controller that can deploy any resource with configuration is only ever a worse version of more generic controller helpers like https://github.com/metacontroller/metacontroller or https://sdk.operatorframework.io/docs/building-operators/helm/tutorial/. Therefore, it's meaningless to recreate our own wheels. The existing toolings are what we recommend for these specific use-cases, because building a controller for your own requirements is no longer a hard thing.",
"Another point is that, the necessity of a profile controller itself is also questionable, cluster admin can use git-ops to manage namespace default resources using a parameterizable common kustomize package too. The major reason we needed kfam and profile controller was because we needed the ability to provide self service experience -- users can come and register their own namespaces. However, there are already many Kubeflow members clarifying they don't want this experience at all, it's better admin configure ACL directly.",
"I completely agree with all the points you've raised. The reason I brought this up is because I thought it would make sense to make it easier for admins to customize the user on-boarding experience. However, if there are existing tools it makes more sense to use those.\r\n\r\n@karlschriek and I have been working a lot on [ArgoFlow](https://github.com/argoflow/argoflow-aws) for AWS using Argo CD. After re-implementing authentication I started to work on adding Keycloak as a deployment option and it got me thinking about integrating the Keycloak user creation with the profile controller. The need for the profile controller is indeed a bit questionable, the default service accounts it creates also do not cater to using fine grained permissions for users.\r\n\r\nI've also thought the use of something like [RBAC Manager](https://github.com/FairwindsOps/rbac-manager) or [Permission Manager](https://github.com/sighupio/permission-manager) (the former being Apache2, the latter BSD-3 but including a UI) would be a good a good integration to give administrators the possibility to easily assign fine grained permissions to users. I haven't looked into this much yet, but I believe the main thing that would need to be changed for not relying on the profile controller is the namespace selection process in the central dashboard.",
"@Bobgy I find it interesting you've gotten feedback from Kubeflow members don't want the experience of users being able to generate their profiles. From our org I think we actually appreciate this feature quite a bit, as it lets us spread access easily. Not to say it couldn't be achieved in a way other than the profile controller though of course",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-24T11:29:37" | "2022-03-03T06:05:15" | "2022-03-03T06:05:15" | CONTRIBUTOR | null | ### Feature Area
/area backend
The Kubeflow Pipelines profile controller now takes care of launching 2 deployments (UI Artifact and Visualization Server) in each user namespace when a profile is created. While busy implementing AWS RDS and S3 support for KFP in [ArgoFlow](https://github.com/argoflow/argoflow-aws/tree/master/distribution/kubeflow/pipelines) @karlschriek ended up using the KFP profile controller to create other resources (in this case an ExternalSecret) when a profile is created.
### What feature would you like to see?
The flexibility and extendable nature of the KFP profile controller should be part of the main [profile controller](https://github.com/kubeflow/kubeflow/tree/master/components/profile-controller).
### What is the use case or pain point?
Many Kubeflow admins would most likely want to automate creating arbitrary resources when a new Kubeflow profile is created. For example, registry secrets or secrets with credentials to object storage buckets.
### Is there a workaround currently?
The KFP profile controller can be extended and used to create arbitrary resources on profile creation. However, similar to https://github.com/kubeflow/pipelines/issues/5681, it would be best to consolidate this functionality into a single profile controller. Especially given that the use cases are not strictly tied to KFP.
/cc @kubeflow/wg-pipeline-leads @kubeflow/wg-notebooks-leads
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5728/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5728/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5727 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5727/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5727/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5727/events | https://github.com/kubeflow/pipelines/issues/5727 | 899,497,818 | MDU6SXNzdWU4OTk0OTc4MTg= | 5,727 | [bug] VertexAI Pipeline does not work ContainerOp | {
"login": "TrsNium",
"id": 11388424,
"node_id": "MDQ6VXNlcjExMzg4NDI0",
"avatar_url": "https://avatars.githubusercontent.com/u/11388424?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/TrsNium",
"html_url": "https://github.com/TrsNium",
"followers_url": "https://api.github.com/users/TrsNium/followers",
"following_url": "https://api.github.com/users/TrsNium/following{/other_user}",
"gists_url": "https://api.github.com/users/TrsNium/gists{/gist_id}",
"starred_url": "https://api.github.com/users/TrsNium/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/TrsNium/subscriptions",
"organizations_url": "https://api.github.com/users/TrsNium/orgs",
"repos_url": "https://api.github.com/users/TrsNium/repos",
"events_url": "https://api.github.com/users/TrsNium/events{/privacy}",
"received_events_url": "https://api.github.com/users/TrsNium/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
}
] | closed | false | {
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Hello.\r\nThank you for trying Vertex AI.\r\nDirectly creating instances of `ContainerOp` has been deprecated for ~11 months. See https://github.com/kubeflow/pipelines/pull/4166\r\nThere should be a deprecation warning every time you call `ContainerOp` manually.\r\n\r\nCould you please use components instead? The comment in https://github.com/kubeflow/pipelines/pull/4166/files provides some examples of conversion.\r\n\r\n>If I have a problem with vertex ai pipelines, is it okay to create an issue in this repository?\r\n\r\nI think so. @chensun has written the whole KFP -> Vertex AI compiler and can help you with the `kfp.v2.compiler` questions.",
"Hi @TrsNium,\r\n\r\nThanks for filing the bug. Yes, please feel free to file bugs against vertex AI here. \r\n\r\nUnfortunately, ContainerOp isn't supported going forward. For now, you should be able to write it like so instead:\r\n\r\n```\r\nimport kfp\r\nwhalesay = kfp.components.load_component_from_text('''\r\nname: WhaleSay\r\nimplementation:\r\n container:\r\n image: docker/whalesay:latest\r\n command:\r\n - cowsay\r\n - hello world\r\n''')\r\n\r\n@dsl.pipeline(\r\n name=\"hello-world\",\r\n description=\"test\",\r\n pipeline_root=pipeline_root_path\r\n)\r\ndef pipeline():\r\n whalesay_op = whalesay()\r\n```\r\n\r\n\r\nWe're working on adding back a drop-in replacement asap so you won't need to write a yaml text for container components like this going forward. Please stay tuned. In the meantime, @chensun, can we throw a more useful error in this case for the user?",
"Hi,\r\n\r\nI have a similar issue, but I can't seem to be able to fix this. I am following the codelab [Intro to Vertex AI pipelines](https://codelabs.developers.google.com/vertex-pipelines-intro#0). At the final step, when I try to run the pipeline, I get the following error:\r\n`HttpError: <HttpError 404 when requesting https://eu-aiplatform.googleapis.com/v1beta1/projects/arex-data/locations/eu/pipelineJobs?pipelineJobId=hello-world-20210909102517&alt=json returned \"Not Found\">`\r\n\r\nHere is the code from my notebook:\r\n\r\n```\r\n@dsl.pipeline(\r\n name=\"hello-world\",\r\n description=\"An intro pipeline\",\r\n pipeline_root=PIPELINE_ROOT,\r\n)\r\n\r\ndef intro_pipeline(text: str = \"Vertex Pipelines\", emoji_str: str = \"sparkles\"):\r\n product_task = product_name(text)\r\n emoji_task = emoji(emoji_str)\r\n consumer_task = build_sentence(\r\n product_task.output,\r\n emoji_task.outputs[\"emoji\"],\r\n emoji_task.outputs[\"emoji_text\"],\r\n )\r\n\r\ncompiler.Compiler().compile(\r\n pipeline_func=intro_pipeline, package_path=\"intro_pipeline_job.json\"\r\n)\r\n\r\napi_client = AIPlatformClient(\r\n project_id=PROJECT_ID,\r\n region=REGION,\r\n)\r\nresponse = api_client.create_run_from_job_spec(\r\n job_spec_path=\"intro_pipeline_job.json\",\r\n # pipeline_root=PIPELINE_ROOT # this argument is necessary if you did not specify PIPELINE_ROOT as part of the pipeline definition.\r\n)\r\n```\r\nAny ideas what might be the issue? Thanks!"
] | "2021-05-24T09:46:10" | "2021-09-09T10:49:36" | "2021-05-31T20:39:05" | CONTRIBUTOR | null | ### What steps did you take
If you run the following code, you will get an error
```python
import kfp.v2.dsl as dsl
from kfp.v2 import compiler
from kfp.v2.google.client import AIPlatformClient
pipeline_root_path = ....
@dsl.pipeline(
name="hello-world",
description="test",
pipeline_root=pipeline_root_path
)
def pipeline():
dsl.ContainerOp(
name="whalesay",
image="docker/whalesay:latest",
command=["cowsay"],
arguments=["hello world"])
client = AIPlatformClient(project_id=MyProject, region="asia-east1")
with tempfile.TemporaryDirectory() as tmpdir:
pipeline_package_path = os.path.join(tmpdir, 'pipeline.json')
compiler.Compiler().compile(pipeline_func=pipeline, package_path=pipeline_package_path)
client.create_run_from_job_spec(pipeline_package_path,)
```
### What happened:
The error message is as follows.
```
Traceback (most recent call last):
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "pipelines/test/__main__.py", line 43, in <module>
app()
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/typer/main.py", line 214, in __call__
return get_command(self)(*args, **kwargs)
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/typer/main.py", line 497, in wrapper
return callback(**use_params) # type: ignore
File "pipelines/test/__main__.py", line 34, in create_run
parameter_values={},
File "pipelines/test/../client_wrapper.py", line 38, in create_run_from_pipeline_func
labels
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/kfp/v2/google/client/client.py", line 344, in create_run_from_job_spec
job_id=job_id,
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/kfp/v2/google/client/client.py", line 228, in _submit_job
response = request.execute()
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/googleapiclient/_helpers.py", line 130, in positional_wrapper
return wrapped(*args, **kwargs)
File "/Users/takuya.hirata/.pyenv/versions/3.7.1rc1/lib/python3.7/site-packages/googleapiclient/http.py", line 856, in execute
raise HttpError(resp, content, uri=self.uri)
googleapiclient.errors.HttpError: <HttpError 400 when requesting https://asia-east1-aiplatform.googleapis.com/v1beta1/projects/MyProject/locations/asia-east1/pipelineJobs?pipelineJobId=hello-world-20210524165548&alt=json returned "Exactly one of deployment_config and deployment_spec is expected.">
```
### What did you expect to happen:
Successful deploy of the pipeline
### Environment:
<!-- Please fill in those that seem relevant. -->
* KFP SDK version:
* 1.6.2
If I have a problem with vertex ai pipelines, is it okay to create an issue in this repository?
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5727/reactions",
"total_count": 4,
"+1": 4,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5727/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5726 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5726/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5726/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5726/events | https://github.com/kubeflow/pipelines/issues/5726 | 899,396,917 | MDU6SXNzdWU4OTkzOTY5MTc= | 5,726 | [v2compat] caching design | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 955884211,
"node_id": "MDU6TGFiZWw5NTU4ODQyMTE=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/L",
"name": "size/L",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
},
{
"login": "capri-xiyue",
"id": 52932582,
"node_id": "MDQ6VXNlcjUyOTMyNTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/52932582?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/capri-xiyue",
"html_url": "https://github.com/capri-xiyue",
"followers_url": "https://api.github.com/users/capri-xiyue/followers",
"following_url": "https://api.github.com/users/capri-xiyue/following{/other_user}",
"gists_url": "https://api.github.com/users/capri-xiyue/gists{/gist_id}",
"starred_url": "https://api.github.com/users/capri-xiyue/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/capri-xiyue/subscriptions",
"organizations_url": "https://api.github.com/users/capri-xiyue/orgs",
"repos_url": "https://api.github.com/users/capri-xiyue/repos",
"events_url": "https://api.github.com/users/capri-xiyue/events{/privacy}",
"received_events_url": "https://api.github.com/users/capri-xiyue/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"@bobgy please keep in mind that cpu and memory ressource requests must be set for compatibility with kubeflow profile quotas. I tried something but could not get it working yet https://github.com/kubeflow/pipelines/pull/5743",
"Hi @juliusvonkohout , the problem you mentioned is with KFP v1 caching.\r\n\r\nIn [v2 compatible caching design](https://bit.ly/kfp-v2-compatible), we won't change the Pod spec when it's cached, so this will no longer be a problem.\r\nIn [v2 design](https://bit.ly/kfp-v2), we will skip the Pod entirely, so this won't be a problem either.",
"Design Doc finished"
] | "2021-05-24T07:51:00" | "2021-06-16T23:28:09" | "2021-06-16T23:28:09" | CONTRIBUTOR | null | Part of #5667 | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5726/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5726/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5724 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5724/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5724/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5724/events | https://github.com/kubeflow/pipelines/issues/5724 | 899,346,313 | MDU6SXNzdWU4OTkzNDYzMTM= | 5,724 | Move MLMD API from kubeflow/frontend to kubeflow/pipelines | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [] | closed | false | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Duplicate of https://github.com/kubeflow/pipelines/issues/5705"
] | "2021-05-24T07:00:23" | "2021-05-24T07:01:01" | "2021-05-24T07:01:01" | CONTRIBUTOR | null | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5724/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5724/timeline | null | completed | null | null | false |
|
https://api.github.com/repos/kubeflow/pipelines/issues/5723 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5723/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5723/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5723/events | https://github.com/kubeflow/pipelines/issues/5723 | 899,247,742 | MDU6SXNzdWU4OTkyNDc3NDI= | 5,723 | [sample] Use dsl.get_pipeline_conf() to apply secrets to the entire pipeline | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1260031624,
"node_id": "MDU6TGFiZWwxMjYwMDMxNjI0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/samples",
"name": "area/samples",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2415263031,
"node_id": "MDU6TGFiZWwyNDE1MjYzMDMx",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/components/aws/sagemaker",
"name": "area/components/aws/sagemaker",
"color": "0263f4",
"default": false,
"description": "AWS SageMaker components"
}
] | open | false | null | [] | null | [
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"/area components/aws/sagemaker",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"
] | "2021-05-24T05:00:44" | "2022-04-28T04:59:40" | null | CONTRIBUTOR | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
area samples
<!-- /area components -->
### What feature would you like to see?
<!-- Provide a description of this feature and the user experience. -->
We have get_pipeline_conf().xxxx which can apply some config to the entire pipeline. See example: https://github.com/kubeflow/pipelines/blob/d9c019641ef9ebd78db60cdb78ea29b0d9933008/components/aws/sagemaker/tests/integration_tests/resources/definition/update_endpoint_pipeline.py#L65
https://kubeflow-pipelines.readthedocs.io/en/stable/source/kfp.dsl.html?highlight=pipelineconf#kfp.dsl.PipelineConf.add_op_transformer
Use the pipelineconf.add_op_transformer method to apply methods like use_gcp_secret etc
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5723/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5723/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5722 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5722/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5722/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5722/events | https://github.com/kubeflow/pipelines/issues/5722 | 898,927,141 | MDU6SXNzdWU4OTg5MjcxNDE= | 5,722 | [backend] persistence agent don't update pipeline run status after workflow deleted | {
"login": "algs",
"id": 13183602,
"node_id": "MDQ6VXNlcjEzMTgzNjAy",
"avatar_url": "https://avatars.githubusercontent.com/u/13183602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/algs",
"html_url": "https://github.com/algs",
"followers_url": "https://api.github.com/users/algs/followers",
"following_url": "https://api.github.com/users/algs/following{/other_user}",
"gists_url": "https://api.github.com/users/algs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/algs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/algs/subscriptions",
"organizations_url": "https://api.github.com/users/algs/orgs",
"repos_url": "https://api.github.com/users/algs/repos",
"events_url": "https://api.github.com/users/algs/events{/privacy}",
"received_events_url": "https://api.github.com/users/algs/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930476737,
"node_id": "MDU6TGFiZWw5MzA0NzY3Mzc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/help%20wanted",
"name": "help wanted",
"color": "db1203",
"default": true,
"description": "The community is welcome to contribute."
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2152751095,
"node_id": "MDU6TGFiZWwyMTUyNzUxMDk1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/frozen",
"name": "lifecycle/frozen",
"color": "ededed",
"default": false,
"description": null
}
] | open | false | null | [] | null | [
"Thank you @algs for flagging this bug report!\r\nThis is a real problem from the persistence agent design.\r\n\r\nMy rough idea to improve would be that, persistence agent should also periodically list all runs from KFP API that are still in running state, if any of the runs do not have a corresponding argo workflow. We should update the DB record to maybe a special state called \"WORKFLOW_DELETED\" etc.\r\n\r\nWhat do you think?",
"Maybe just list runs which have not been updated/reported for a certain time, it should be a few runs. ",
"> Maybe just list runs which have not been updated/reported for a certain time, it should be a few runs.\r\n\r\nwould this because of service error rather than the corresponding workflow deleted?",
"> My rough idea to improve would be that, persistence agent should also periodically list all runs from KFP API that are still in running state, if any of the runs do not have a corresponding argo workflow. We should update the DB record to maybe a special state called \"WORKFLOW_DELETED\" etc.\r\n\r\nAn alternative could be persistent agent watches workflow changes and if there's a delete workflow event, check running state of associated run and update DB. I prefer to choose the way which can reduce apiserver pressure. :D ",
"@Jeffwan great idea! That feels like the most efficient solution.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"/lifecycle frozen\nWelcome anyone to contribute this!"
] | "2021-05-23T03:33:21" | "2021-09-12T13:26:17" | null | CONTRIBUTOR | null | ### Environment
* How did you deploy Kubeflow Pipelines (KFP)?
<!-- For more information, see an overview of KFP installation options: https://www.kubeflow.org/docs/pipelines/installation/overview/. -->
* KFP version: 1.5.0
<!-- Specify the version of Kubeflow Pipelines that you are using. The version number appears in the left side navigation of user interface.
To find the version number, See version number shows on bottom of KFP UI left sidenav. -->
* KFP SDK version:
<!-- Specify the output of the following shell command: $pip list | grep kfp -->
### Steps to reproduce
<!--
Specify how to reproduce the problem.
This may include information such as: a description of the process, code snippets, log output, or screenshots.
-->
1. launch a pipeline run, and observe the status of nodes in the run as expected from UI.
2. use command `kubectl delete workflow xxx` to delete the workflow corresponding to the pipeline run, then the unfinished nodes in the pipeline run stay **running**, and never been updated.
3. the `delete workflow` may happen when we delete the scheduledworkflow, and then the workflow without the parent scheduledworkflow got GC
### Expected result
The running nodes in the pipeline run been marked as `terminated`
<!-- What should the correct behavior be? -->
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
cc @Jeffwan | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5722/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5722/timeline | null | null | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5718 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5718/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5718/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5718/events | https://github.com/kubeflow/pipelines/issues/5718 | 897,774,761 | MDU6SXNzdWU4OTc3NzQ3NjE= | 5,718 | [feature] default to the emissary executor | {
"login": "juliusvonkohout",
"id": 45896133,
"node_id": "MDQ6VXNlcjQ1ODk2MTMz",
"avatar_url": "https://avatars.githubusercontent.com/u/45896133?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/juliusvonkohout",
"html_url": "https://github.com/juliusvonkohout",
"followers_url": "https://api.github.com/users/juliusvonkohout/followers",
"following_url": "https://api.github.com/users/juliusvonkohout/following{/other_user}",
"gists_url": "https://api.github.com/users/juliusvonkohout/gists{/gist_id}",
"starred_url": "https://api.github.com/users/juliusvonkohout/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/juliusvonkohout/subscriptions",
"organizations_url": "https://api.github.com/users/juliusvonkohout/orgs",
"repos_url": "https://api.github.com/users/juliusvonkohout/repos",
"events_url": "https://api.github.com/users/juliusvonkohout/events{/privacy}",
"received_events_url": "https://api.github.com/users/juliusvonkohout/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 955884211,
"node_id": "MDU6TGFiZWw5NTU4ODQyMTE=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/L",
"name": "size/L",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
},
{
"login": "NikeNano",
"id": 22057410,
"node_id": "MDQ6VXNlcjIyMDU3NDEw",
"avatar_url": "https://avatars.githubusercontent.com/u/22057410?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NikeNano",
"html_url": "https://github.com/NikeNano",
"followers_url": "https://api.github.com/users/NikeNano/followers",
"following_url": "https://api.github.com/users/NikeNano/following{/other_user}",
"gists_url": "https://api.github.com/users/NikeNano/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NikeNano/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NikeNano/subscriptions",
"organizations_url": "https://api.github.com/users/NikeNano/orgs",
"repos_url": "https://api.github.com/users/NikeNano/repos",
"events_url": "https://api.github.com/users/NikeNano/events{/privacy}",
"received_events_url": "https://api.github.com/users/NikeNano/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"@juliusvonkohout can you clarify how visualization is broken?\r\n> Sadly visualizations are broken(26.04.2021) for k8sapi and emissary",
"> @juliusvonkohout can you clarify how visualization is broken?\n> > Sadly visualizations are broken(26.04.2021) for k8sapi and emissary\n\nThe pipeline finishes, but e.g. no html or markdown visualizations.\n\nIt just does not show in the UI. As far as I remember the stuff was in minio but not properly displayed by pipeline-ui. But I would have to check again. Such problems are expected, since I just replaced the Argo images instead of properly updating Argo everywhere in kubeflow pipelines. Since it appeared with emissary AND k8sapi it should be fine with a proper Argo update in kubeflow.\n\nIf you need more information you can obtain them with my instructions above or tell me what exactly you want and I will check it on Tuesday.",
"/assign\nI believe there is no doubt this is the right way to go.",
"I can help out updating argo to v3 @Bobgy \r\n/assign",
">\"Output artifacts must be saved on volumes (e.g. emptyDir) and not the base image layer (e.g. /tmp)\" so it breaks the leightweight python components if there is no volume mounted or the output directory is inside the base layer #4645\r\n\r\nEach output is placed in it's own directory. And those directories are in `/tmp/outputs/`, not just in `/tmp/`. Couldn't Argo mount EmptyDir volumes under the outputs directories? Argo already does that for inputs.\r\n\r\nP.S. The SDK could change the paths to `/outputs/` without a need to change components or pipelines. It was like that at some point in the past.",
"@Ark-kun this has all been discussed extensively in the links provided above. You will find detailed answers there.",
"The release of 3.1 is very close. 3.1.0-rc8 is already there https://github.com/argoproj/argo-workflows/releases and 3.0-rc9 https://github.com/argoproj/argo-workflows/releases/tag/v3.0.0-rc9 was the last prerelease for the 3.0 branch. Based on that 3.1.0 should land in 1-2 weeks.",
"Have started the work to upgrade should be easy to go to the next version when it is out. ",
"TODO: I'll review argo v3 images for licenses and upgrade the manifests.",
"I think we should add a test for a simple pipeline that runs as non-root. That way we know that the emissary executor works properly. \r\nThe following tests runasnonroot and kubeflow profile quotas. \r\n\r\n``` python\r\n\r\npython\r\nfrom kfp.components import create_component_from_func\r\nfrom typing import NamedTuple\r\n\r\ndef pod_defaults(op, user = 1000):\r\n from kubernetes import client as k8s_client\r\n from kubernetes.client.models import V1SecurityContext\r\n op.set_security_context(V1SecurityContext(run_as_user=user, run_as_group=0))\r\n op.set_memory_request('10Mi');# op.set_memory_limit('1000Mi')\r\n op.set_cpu_request('10m');# op.set_cpu_limit('1000m')\r\n return op\r\n\r\ndef produce_markdown() -> NamedTuple('Outputs', [('mlpipeline_ui_metadata', 'UI_metadata'), ('mlpipeline_metrics', 'Metrics')]):\r\n #https://www.kubeflow.org/docs/components/pipelines/sdk/output-viewer/\r\n metadata = {\"outputs\": [\r\n {\"storage\": \"inline\", \"source\": \"*this should be bold*\", \"type\": \"markdown\"}\r\n ]}\r\n # https://www.kubeflow.org/docs/components/pipelines/sdk/pipelines-metrics/\r\n metrics = {'metrics': [\r\n {\r\n 'name': 'train-accuracy', # underscores are not allowed... https://github.com/kubeflow/pipelines/issues/3809\r\n 'numberValue': 0.9,\r\n },\r\n {\r\n 'name': 'test-accuracy', # underscores are not allowed...\r\n 'numberValue': 0.7,\r\n }\r\n ]}\r\n #return [json.dumps(markdown)]\r\n from collections import namedtuple; import json\r\n return namedtuple('output', ['mlpipeline_ui_metadata', 'mlpipeline_metrics'])(json.dumps(metadata), json.dumps(metrics))\r\n\r\n...\r\n\r\nmarkdown_component = func_to_container_op(func=produce_markdown, base_image=BASE_IMAGE)()\r\npod_defaults(markdown_component)\r\n\r\n```\r\n\r\nBut you have to use PSPs or consider https://argoproj.github.io/argo-workflows/workflow-pod-security-context/ and use a kubeflow profile with quotas.",
"Note, there's a breaking change. When using emissary executor, your components must specify the command explicitly.\r\n\r\n> step group deemed errored due to child integration-test-vzl9f[0].build-initialization-test-image error: when using the emissary executor you must either explicitly specify the command, or list the image's command in the index: https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary \r\n └───⚠ build-initialization-test-image(0) build-image integration-test-vzl9f-2173864179 0s when using the emissary executor you must either explicitly specify the command, or list the image's command in the index: https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary ",
"The breaking changes is also required for bit.ly/kfp-v2-compatible and bit.ly/kfp-v2. So I think we can introduce it now.\r\n\r\nSee https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary",
"user facing documentation candidate\r\n\r\n### Breaking change\r\nArgo emissary executor requires that each container has explicit command and args defined, refer to https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary.\r\n\r\nWhy we decide to adopt the breaking change? We'd have the same breaking change in bit.ly/kfp-v2-compatible and bit.ly/kfp-v2. So I think it aligns with KFP's long term goal, and it's OK to introduce the breaking change now.\r\n",
"Filed upstream issue for using argo emissary executor with rootless container: https://github.com/argoproj/argo-workflows/issues/6238.\r\n\r\nThe current blocker in e2e test failure is at selenium image: https://github.com/kubeflow/pipelines/blob/76f8b3e9acf09bdc5a7e7729b0dfa64dd51b922a/test/frontend-integration-test/Dockerfile#L4. It runs as non-root.",
"(added status update to the issue description itself: https://github.com/kubeflow/pipelines/issues/5718#issue-897774761)",
"\r\n“This step is in Error state with this message: failed to save outputs: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?”\r\n\r\n> I think we should add a test for a simple pipeline that runs as non-root. That way we know that the emissary executor works properly.\r\n> The following tests runasnonroot and kubeflow profile quotas.\r\n> \r\n> ```python\r\n> python\r\n> from kfp.components import create_component_from_func\r\n> from typing import NamedTuple\r\n> \r\n> def pod_defaults(op, user = 1000):\r\n> from kubernetes import client as k8s_client\r\n> from kubernetes.client.models import V1SecurityContext\r\n> op.set_security_context(V1SecurityContext(run_as_user=user, run_as_group=0))\r\n> op.set_memory_request('10Mi');# op.set_memory_limit('1000Mi')\r\n> op.set_cpu_request('10m');# op.set_cpu_limit('1000m')\r\n> return op\r\n> \r\n> def produce_markdown() -> NamedTuple('Outputs', [('mlpipeline_ui_metadata', 'UI_metadata'), ('mlpipeline_metrics', 'Metrics')]):\r\n> #https://www.kubeflow.org/docs/components/pipelines/sdk/output-viewer/\r\n> metadata = {\"outputs\": [\r\n> {\"storage\": \"inline\", \"source\": \"*this should be bold*\", \"type\": \"markdown\"}\r\n> ]}\r\n> # https://www.kubeflow.org/docs/components/pipelines/sdk/pipelines-metrics/\r\n> metrics = {'metrics': [\r\n> {\r\n> 'name': 'train-accuracy', # underscores are not allowed... https://github.com/kubeflow/pipelines/issues/3809\r\n> 'numberValue': 0.9,\r\n> },\r\n> {\r\n> 'name': 'test-accuracy', # underscores are not allowed...\r\n> 'numberValue': 0.7,\r\n> }\r\n> ]}\r\n> #return [json.dumps(markdown)]\r\n> from collections import namedtuple; import json\r\n> return namedtuple('output', ['mlpipeline_ui_metadata', 'mlpipeline_metrics'])(json.dumps(metadata), json.dumps(metrics))\r\n> \r\n> ...\r\n> \r\n> markdown_component = func_to_container_op(func=produce_markdown, base_image=BASE_IMAGE)()\r\n> pod_defaults(markdown_component)\r\n> ```\r\n> \r\n> But you have to use PSPs or consider https://argoproj.github.io/argo-workflows/workflow-pod-security-context/ and use a kubeflow profile with quotas.\r\n\r\nUsed \r\n`kubectl -n kubeflow patch configmap/workflow-controller-configmap --type='json' -p='[{\"op\": \"replace\", \"path\": \"/data/containerRuntimeExecutor\", \"value\": \"emissary\"}]'`\r\n\r\n`kubectl edit deployment/workflow-controller -n kubeflow`\r\n\r\nA new error:\r\n\"This step is in Error state with this message: failed to save outputs: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?\"\r\n\r\nHow solve this error?",
"@nongqiqin how did you deploy KFP and argo? You need at least KFP 1.7.0-alpha.2 to get an argo version of v3.1.1. v3.0.x and before do not support emissary executor",
"> @nongqiqin how did you deploy KFP and argo? You need at least KFP 1.7.0-alpha.2 to get an argo version of v3.1.1. v3.0.x and before do not support emissary executor\r\n\r\nYes you need to upgrade to argo 3.1 first",
"Discussed with @kramachandran and decided to delay the default change for at least one KFP minor version, because argo emissary executor is still in Alpha state, despite we verified it in our test infra. There can be other corner cases too, so we should give people some time to test it out.\r\n\r\nAction Items:\r\n* [x] document how to use docker executor in GKE by configuring nodepools to use OS images with docker\r\n* [x] document how to switch to emissary executor\r\n* [x] document the breaking changes made in emissary executor",
"Renaming to just default to emissary executor, because we've finished the upgrade.",
"Is there any estimation of when the emissary is going to be the default executed? ",
"> Is there any estimation of when the emissary is going to be the default executed? \n\nI think there are some small runasbonnroot bugs for V2 pipelines, but V1 and V2-Compatible should be fine. Feel free to help there... So I hope that they change the default to emissary in 1.9. (kubeflow 1.5 most likely) . I bet that @Bobgy wants to update argo argo to >= 3.2.2 to get the most mature emissary executor. There is also an emissary feedback issue somewhere here where you can ask.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"Fixed by https://github.com/kubeflow/pipelines/pull/7137",
" when using the emissary executor you must either explicitly specify the command, or list the image's command in the index: https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary\r\n\r\nkubeflow version:1.7.1"
] | "2021-05-21T07:33:15" | "2022-09-05T12:18:16" | "2022-03-02T23:43:53" | MEMBER | null | #### Update - 2021.9.13
edited by @Bobgy
KFP 1.7.0 is released.
documentation is live: https://www.kubeflow.org/docs/components/pipelines/installation/choose-executor/
choosing an executor will be an option starting from KFP 1.7.
#### Update - 2021.8.6
edited by @Bobgy
Discussed with @kramachandran and decided to delay the default change for at least one KFP minor version, because argo emissary executor is still in Alpha state. There can be other corner cases that we haven't found, so we should give people some time to test it out.
Therefore, I'd like to propose the following:
* still default to docker executor in 1.7.0 release
* provide emissary executor as an option and document how to migrate
* collect feedback from people who starts to try emissary executor
TODOs:
* [x] https://github.com/kubeflow/website/pull/2857
* [x] Make emissary available in installations
* [x] #6294
* [x] Make env/platform-agnostic-emissary
* [x] #6252
* [x] Upgrade kfp-ci test infra to argo v3.1.1 https://github.com/kubeflow/testing/commit/03c625828ac9cc13283bd226371280b0f5704c09
Issues discovered when testing argo v3.1.0 with KFP:
* [x] https://github.com/kubeflow/pipelines/issues/5930
* [x] https://github.com/kubeflow/pipelines/issues/5937 (fixed in v3.1.1)
* [x] https://github.com/kubeflow/pipelines/issues/5944 (fixed in v3.1.1)
* [x] https://github.com/argoproj/argo-workflows/issues/6238
=== the following are the original proposal ===
### What feature would you like to see?
Update argo to 3.11 such that we can use the emissary executor as decided by @bobgy in https://github.com/kubeflow/pipelines/pull/4645#issuecomment-845691359
### What is the use case or pain point?
The Docker, Kubelet, PNS and K8sapi executors have severe limitations that will be solved by Argo 3.1 and the emissary executor.
Here is an overview https://argoproj.github.io/argo-workflows/workflow-executors/
In a nutshell docker breaks security completely and is incompatible with kubernetes 1.19
https://github.com/kubeflow/pipelines/issues/5714 Kubernetes is also moving to containerd anyway and a lot of users want proper non-docker support for a long time https://github.com/kubeflow/pipelines/issues/1654
Kubelet needs some configuration and has the same limitation as k8sapi and rootless PNS: "Output artifacts must be saved on volumes (e.g. emptyDir) and not the base image layer (e.g. /tmp)" so it breaks the leightweight python components if there is no volume mounted or the output directory is inside the base layer https://github.com/kubeflow/pipelines/pull/4645
One can use a PNS with root rights (PTRACE and CHROOT) to circumvent this, but this obviously breaks the security again.
So only the emissary executor https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary is feasible which does more ore less what i proposed in https://github.com/kubeflow/pipelines/pull/4645 and what was started by Argos @alexec in https://github.com/argoproj/argo-workflows/pull/4766
The Argo update has been done before in https://github.com/kubeflow/pipelines/pull/5266 and https://github.com/kubeflow/pipelines/pull/4693 by @xinbinhuang @Bobgy
### Is there a workaround currently?
```
# Emmissary executor, needs argo 3.1+
# Sadly visualizations are broken(26.04.2021) for k8sapi and emissary
kubectl -n kubeflow patch configmap/workflow-controller-configmap --type='json' -p='[{"op": "replace", "path": "/data/containerRuntimeExecutor", "value": "emissary"}]'
kubectl edit deployment/workflow-controller -n kubeflow
...
spec:
containers:
- env:
- name: "LEADER_ELECTION_DISABLE"
value: true
- args:
- --configmap
- workflow-controller-configmap
- --executor-image
- docker.io/argoproj/argoexec:latest
command:
- workflow-controller
image: docker.io/argoproj/workflow-controller:latest
env:
- name: "LEADER_ELECTION_DISABLE"
value: "true"
...
kubectl -n kubeflow patch configmap/workflow-controller-configmap --type='json' -p='[{"op": "replace", "path": "/data/containerRuntimeExecutor", "value": "emissary"}]'
kubectl rollout restart deployment workflow-controller -n kubeflow
or manually patching the sdk and using k8sapi as done in https://github.com/kubeflow/pipelines/pull/4645
Or use kfp-tekton
```
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5718/reactions",
"total_count": 25,
"+1": 24,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 1,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5718/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5717 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5717/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5717/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5717/events | https://github.com/kubeflow/pipelines/issues/5717 | 897,760,161 | MDU6SXNzdWU4OTc3NjAxNjE= | 5,717 | [bug] GCP marketplace default config values do not work | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930619531,
"node_id": "MDU6TGFiZWw5MzA2MTk1MzE=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/platform/gcp",
"name": "platform/gcp",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"@Bobgy: The label(s) `area/deployment` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubeflow/pipelines/issues/5717):\n\n>### What steps did you take\r\n>\r\n>\r\n>1. Install KFP from AI Platform Pipelines\r\n>2. check managed storage\r\n>3. fill in db connection name and gcs bucket name\r\n>4. leave the rest as empty\r\n>\r\n>### What happened:\r\n>\r\n>All the default values are filled by empty strings.\r\n>\r\n>### What did you expect to happen:\r\n>\r\n>I was expecting default values in values.yaml are set, e.g. https://github.com/kubeflow/pipelines/blob/a1ecb3dc0af905b6fd5710b10d635b7666745a4c/manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml#L27.\r\n>### Labels\r\n>\r\n>\r\n>\r\n>\r\n>\r\n>\r\n>\r\n>\r\n>/area deployment\r\n>\r\n>---\r\n>\r\n>\r\n>Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.\r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"We should define default values in schema.yaml, see https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/blob/master/docs/schema.md#helm-chart-values",
"Cases we need to test after the release:\r\n* [x] when deploying with managed storage, leave db username as empty, and verify it defaults to \"root\".\r\n* [x] similarly leave databasePrefixName as empty, verify dbs are created as `_cache`, `_pipeline` etc.",
"Reopen to wait for verification",
"Now the database username defaults to \"root\" on the UI.\r\n\r\n"
] | "2021-05-21T07:13:41" | "2021-08-11T11:55:06" | "2021-08-11T11:55:06" | CONTRIBUTOR | null | ### What steps did you take
<!-- A clear and concise description of what the bug is.-->
1. Install KFP from [AI Platform Pipelines](https://console.cloud.google.com/marketplace/product/google-cloud-ai-platform/kubeflow-pipelines)
2. check managed storage
3. fill in db connection name and gcs bucket name
4. leave the rest as empty
### What happened:
All the default values are filled by empty strings.
### What did you expect to happen:
I was expecting default values in values.yaml are set, e.g. https://github.com/kubeflow/pipelines/blob/a1ecb3dc0af905b6fd5710b10d635b7666745a4c/manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml#L27.
However, I verified that cache configmap in fact has db name as `_cache` without the prefix.
### Labels
<!-- Please include labels below by uncommenting them to help us better triage issues -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
<!-- /area testing -->
<!-- /area samples -->
<!-- /area components -->
/area deployment
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5717/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5717/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5714 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5714/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5714/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5714/events | https://github.com/kubeflow/pipelines/issues/5714 | 897,593,152 | MDU6SXNzdWU4OTc1OTMxNTI= | 5,714 | KFP docker executor doesn't support Kubernetes 1.19 or above | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign",
"I have created an extended description of everything at https://github.com/kubeflow/pipelines/issues/5718 . What you describe here is just one single out of many reasons to upgrade argo and use the emissary executor.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"Kubeflow Pipelines backend v1.8.1 has released. We have switched to Emissary Executor by default. Therefore you can use KFP on K8s 1.19 or above without further configuraiton."
] | "2021-05-21T01:15:50" | "2022-03-02T21:47:20" | "2022-03-02T21:47:19" | COLLABORATOR | null | ## UPDATE 2021-8-16
you can use emissary executor instead starting from Kubeflow Pipelines 1.7, this is the only executor that works, if you don't have Docker runtime in your cluster (Docker runtime is not the default installation option since GKE 1.18).
Documentation: https://www.kubeflow.org/docs/components/pipelines/installation/choose-executor/
## issue reference
https://github.com/kubeflow/pipelines/issues/5663
### Error message:
1. If you deploy KFP on Google Cloud Marketplace, you will see the following message if you select `create a cluster`
```
Basic authentication was removed for GKE cluster versions >= 1.19.
The cluster cannot be created with basic authentication enabled.
Instructions for choosing an alternative authentication method can be found at: https://cloud.google.com/kubernetes-engine/docs/how-to/api-server-authentication.
```
2. If you deploy KFP on an existing K8s cluster with version v1.19 or above, you will see following error if you run any pipeline:
```
This step is in Error state with this message: failed to save outputs: Error response from daemon: No such container: XXXXXX
```
### Workaround
Kubeflow Pipelines docker executor doesn't support containerd nodes which come by default with Kubernetes 1.19 or above.
To deploy KFP, you need to create a cluster satisfying one of the following conditions:
* a K8s cluster with version 1.18 or earlier
* Explicitly using docker nodepools (Container-Optimized OS with Docker (cos)) https://cloud.google.com/kubernetes-engine/docs/concepts/node-images
Example command to create kubernetes cluster:
```bash
# The following parameters can be customized based on your needs.
CLUSTER_NAME="kubeflow-pipelines-standalone"
ZONE="us-central1-a"
MACHINE_TYPE="e2-standard-2"
SCOPES="cloud-platform" # This scope is needed for running some pipeline samples. Read the warning below for its security implication
gcloud container clusters create $CLUSTER_NAME \
--zone $ZONE \
--machine-type $MACHINE_TYPE \
--scopes $SCOPES \
--cluster-version 1.18
```
Warning: Using SCOPES="cloud-platform" grants all GCP permissions to the cluster. For a more secure cluster setup, refer to [Authenticating Pipelines to GCP](https://www.kubeflow.org/docs/gke/authentication/#authentication-from-kubeflow-pipelines).
Install KFP on Google Cloud:
If you are on Google Cloud, install KFP by following this documentation: https://cloud.google.com/ai-platform/pipelines/docs/setting-up#existing-cluster
Install KFP standalone:
If you are on other platform, follow the documentation here to install standalone KFP: https://www.kubeflow.org/docs/components/pipelines/installation/standalone-deployment/#deploying-kubeflow-pipelines
### Root cause
Kubeflow Pipelines docker executor doesn't support GKE 1.19 or above, because new GKE 1.19 clusters have containerd nodes by default.
Kubeflow Pipelines need to migrate to new argo version and use emissary executor. tracking issue: https://github.com/kubeflow/pipelines/issues/1654
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5714/reactions",
"total_count": 13,
"+1": 13,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5714/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5711 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5711/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5711/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5711/events | https://github.com/kubeflow/pipelines/issues/5711 | 897,217,980 | MDU6SXNzdWU4OTcyMTc5ODA= | 5,711 | v2 compiler has data passing limitations | {
"login": "jackwhelpton",
"id": 6883147,
"node_id": "MDQ6VXNlcjY4ODMxNDc=",
"avatar_url": "https://avatars.githubusercontent.com/u/6883147?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jackwhelpton",
"html_url": "https://github.com/jackwhelpton",
"followers_url": "https://api.github.com/users/jackwhelpton/followers",
"following_url": "https://api.github.com/users/jackwhelpton/following{/other_user}",
"gists_url": "https://api.github.com/users/jackwhelpton/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jackwhelpton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jackwhelpton/subscriptions",
"organizations_url": "https://api.github.com/users/jackwhelpton/orgs",
"repos_url": "https://api.github.com/users/jackwhelpton/repos",
"events_url": "https://api.github.com/users/jackwhelpton/events{/privacy}",
"received_events_url": "https://api.github.com/users/jackwhelpton/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1682634265,
"node_id": "MDU6TGFiZWwxNjgyNjM0MjY1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/status/wontfix",
"name": "status/wontfix",
"color": "4d48b5",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
},
{
"login": "chensun",
"id": 2043310,
"node_id": "MDQ6VXNlcjIwNDMzMTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2043310?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chensun",
"html_url": "https://github.com/chensun",
"followers_url": "https://api.github.com/users/chensun/followers",
"following_url": "https://api.github.com/users/chensun/following{/other_user}",
"gists_url": "https://api.github.com/users/chensun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/chensun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chensun/subscriptions",
"organizations_url": "https://api.github.com/users/chensun/orgs",
"repos_url": "https://api.github.com/users/chensun/repos",
"events_url": "https://api.github.com/users/chensun/events{/privacy}",
"received_events_url": "https://api.github.com/users/chensun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
">The fix appears straightforward, to include the String type on the Data\r\n\r\nThis won't work. The v2 compiler imposes severe limitations on the `String` type. The pipeline will still not compile and also you'll lose the ability to upload any binary data like models.\r\n\r\nA fix for this v2 compiler issue was proposed and implemented in https://github.com/kubeflow/pipelines/pull/5478 Please take a look.",
"I'll take a look, cheers!\r\n\r\nFor reference, my version that uses a local component with this change _does_ compile, and works as expected. I imagine you'd run into trouble if you wanted to upload an artifact rather than a string, but as most of my pipelines are being ported from v1 they don't use artifact types (at least not intentionally: a lot of previously untyped parameters started being handled that way).",
"With the current state of the \"v2 compiler\", you'll need two separate uploader components - one for uploading strings (String-typed outputs) and another for uploading non-strings...",
"## KFP v1\r\n\r\nKFP has simple and easy data passing model that users like. There are different kinds of arguments and different ways to consume an input argument. All combinations working.\r\n\r\nAny input can be consumed\r\n1. As value (`inputValue` placeholder) \r\n2. As file (`inputPath` placeholder).\r\n\r\nAnd the argument for any input can come from\r\n1. Constant value\r\n2. Pipeline parameter\r\n3. Upstream component output\r\n\r\nCombining these options there are 6 end-to-end data passing cases, each of which works regardless of types:\r\n\r\n1. Pass constant value which gets consumed as value.\r\n2. Pass constant value which gets consumed as file.\r\n3. Pass pipeline parameter that gets consumed as value.\r\n4. Pass pipeline parameter that gets consumed as file.\r\n5. Pass task output that gets consumed as value.\r\n6. Pass task output that gets consumed as file.\r\n\r\nThe only way types come into play is that when both upstream output and downstream input have types, the types must match.\r\n\r\n## Current KFP v2 compiler limitations:\r\n\r\nThe current version of the v2 compiler adds numerous data-passing limitations. Most limitations can easily be lifted (see #5478), but the compiler team wants to hear more user feedback.\r\n\r\n1. Pass constant value which gets consumed as value. **Limitation: The input must be typed String, Integer or Float.** Cannot pass constant values for inputs of type `Date`, `Uri`, `JsonObject`, `GcpProjectId` and all other types.\r\n2. Pass constant value which gets consumed as file. **Not supported.** Cannot pass small texts or JSON structures etc that get consumed as files.\r\n3. Pass pipeline parameter that gets consumed as value. **Limitation: Both component input and pipeline parameter must be typed String, Integer or Float.** Cannot pass pipeline parameters to inputs of type `Date`, `Uri`, `JsonObject`, `GcpProjectId` and all other types.\r\n4. Pass pipeline parameter that gets consumed as file. **Not supported.** Cannot pass small texts or JSON structures etc that get consumed as files.\r\n5. Pass task output that gets consumed as value. **Limitation: Both upstream output and downstream input must be typed String, Integer or Float** Cannot consume inputs of type `Date`, `Uri`, `JsonObject`, `GcpProjectId` and most other types by value.\r\n6. Pass task output that gets consumed as file. **Limitation: Both upstream output and downstream input must NOT be typed String, Integer or Float.** Cannot upload strings (this issue).\r\n",
"> ## KFP v1\r\n> KFP has simple and easy data passing model that users like. There are different kinds of arguments and different ways to consume an input argument. All combinations working.\r\n> \r\n> Any input can be consumed\r\n> \r\n> 1. As value (`inputValue` placeholder)\r\n> 2. As file (`inputPath` placeholder).\r\n> \r\n> And the argument for any input can come from\r\n> \r\n> 1. Constant value\r\n> 2. Pipeline parameter\r\n> 3. Upstream component output\r\n> \r\n> Combining these options there are 6 end-to-end data passing cases, each of which works regardless of types:\r\n> \r\n> 1. Pass constant value which gets consumed as value.\r\n> 2. Pass constant value which gets consumed as file.\r\n> 3. Pass pipeline parameter that gets consumed as value.\r\n> 4. Pass pipeline parameter that gets consumed as file.\r\n> 5. Pass task output that gets consumed as value.\r\n> 6. Pass task output that gets consumed as file.\r\n> \r\n> The only way types come into play is that when both upstream output and downstream input have types, the types must match.\r\n> \r\n> ## Current KFP v2 compiler limitations:\r\n> The current version of the v2 compiler adds numerous data-passing limitations. Most limitations can easily be lifted (see #5478), but the compiler team wants to hear more user feedback.\r\n> \r\n> 1. Pass constant value which gets consumed as value. **Limitation: The input must be typed String, Integer or Float.** Cannot pass constant values for inputs of type `Date`, `Uri`, `JsonObject`, `GcpProjectId` and all other types.\r\n> 2. Pass constant value which gets consumed as file. **Not supported.** Cannot pass small texts or JSON structures etc that get consumed as files.\r\n> 3. Pass pipeline parameter that gets consumed as value. **Limitation: Both component input and pipeline parameter must be typed String, Integer or Float.** Cannot pass pipeline parameters to inputs of type `Date`, `Uri`, `JsonObject`, `GcpProjectId` and all other types.\r\n> 4. Pass pipeline parameter that gets consumed as file. **Not supported.** Cannot pass small texts or JSON structures etc that get consumed as files.\r\n> 5. Pass task output that gets consumed as value. **Limitation: Both upstream output and downstream input must be typed String, Integer or Float** Cannot consume inputs of type `Date`, `Uri`, `JsonObject`, `GcpProjectId` and most other types by value.\r\n> 6. Pass task output that gets consumed as file. **Limitation: Both upstream output and downstream input must NOT be typed String, Integer or Float.** Cannot upload strings (this issue).\r\n\r\nKFP v2 has a different data model from KFP v1. In KFP v2, we have the distinction between parameters and artifacts. They have different behaviors. For instance, parameters are stored in MLMD, and they can be queried, while for artifacts, we don't store the file content in MLMD, but artifacts can have additional metadata. I consider this as a feature improvement over the KFP v1 data model. \r\n\r\nThis [doc](https://www.kubeflow.org/docs/components/pipelines/sdk/v2/v2-compatibility/#building-pipelines-using-the-kubeflow-pipelines-sdk-v2) describes which types are treated as parameters and which are treated as artifacts. We have a simple rule of how parameters vs. artifacts are decided. The decision should be deterministic, but not based on how a component is used. The proposed fix (https://github.com/kubeflow/pipelines/pull/5478) you mentioned above would infer user's intention in specific scenarios. As we've discussed offline, it could lead to inconsistent behavior and the team decided to not move forward with it.\r\n\r\nI believe most of the related issues user may have can simply be fixed by adding/updating types. And we need to update our samples and components to make them compatible as well (tracked by https://github.com/kubeflow/pipelines/issues/5801). \r\nWe will also prioritize on adding a new doc that better describes the difference between parameters and artifacts. And we will include a detailed migration guide on how to fix issues like this one.\r\n\r\n\r\n",
"> I'll take a look, cheers!\r\n> \r\n> For reference, my version that uses a local component with this change _does_ compile, and works as expected. I imagine you'd run into trouble if you wanted to upload an artifact rather than a string, but as most of my pipelines are being ported from v1 they don't use artifact types (at least not intentionally: a lot of previously untyped parameters started being handled that way).\r\n\r\nHi @jackwhelpton, as we spoke last time on this issue, I believe your use case is unblocked by adding/updating the type.\r\nWe will have a new doc with the detailed migration guide, and we will also update our components and samples to be compatible with v2 (https://github.com/kubeflow/pipelines/issues/5801).\r\n\r\nIf there are no other blockers, do you think we can close this issue? Thanks!\r\n\r\n",
"It seems like everything I'd wanted from this ticket is covered by https://github.com/kubeflow/pipelines/issues/5801, so I'm fine with closing this one. Thanks!",
"Thanks Jack. Closing this issue.",
"/reopen\r\nbecause we plan to support this in #6080\r\n\r\nlet's keep this open\r\n",
"@Bobgy: Reopened this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubeflow/pipelines/issues/5711#issuecomment-886339090):\n\n>/reopen\r\n>because we plan to support this in #6080\r\n>\r\n>let's keep this open\r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"> /reopen\r\n> because we plan to support this in #6080\r\n> \r\n> let's keep this open\r\n\r\n#6080 was meant to be temporary in the first place (I propose to revert it by KFP SDK 2.0 release). \r\nThe more we discussed the pros and cons of the change, the more we feel like it probably shouldn't be merged even for a short period. \r\nClosing again per https://github.com/kubeflow/pipelines/pull/6080#issuecomment-887069438."
] | "2021-05-20T18:02:34" | "2021-08-20T06:14:10" | "2021-07-26T22:34:03" | CONTRIBUTOR | null | ### Environment
kfp 1.6.2
kfp-pipeline-spec 0.1.7
kfp-server-api 1.5.0
### Steps to reproduce
Use the `upload_to_explicit_url` component in a pipeline (picking a version that includes the latest v2 updates):
```python
upload_op = load_component_from_url("https://raw.githubusercontent.com/kubeflow/pipelines/961b17fa6844e1d79e5d3686bb557d830d7b5a95/components/google-cloud/storage/upload_to_explicit_uri/component.yaml")
upload_task = upload_op(eval_task.output, results) # pylint: disable=not-callable
```
As the `Data` input is untyped, it is treated as an artifact, and compiling produces this error:
```
TypeError: Passing PipelineParam "run-predictions-Results" with type "String" (as "Parameter") to component input "Data" with type "None" (as "Artifact") is incompatible. Please fix the type of the component input.
```
The fix appears straightforward, to include the `String` type on the `Data` input as well as the `GCS path` input and output.
### Expected result
Pipeline compiles successfully.
### Materials and Reference
<!-- Help us debug this issue by providing resources such as: sample code, background context, or links to references. -->
https://raw.githubusercontent.com/kubeflow/pipelines/961b17fa6844e1d79e5d3686bb557d830d7b5a95/components/google-cloud/storage/upload_to_explicit_uri/component.yaml
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5711/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5711/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5710 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5710/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5710/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5710/events | https://github.com/kubeflow/pipelines/issues/5710 | 897,092,224 | MDU6SXNzdWU4OTcwOTIyMjQ= | 5,710 | [sdk] Regression in 1.6.2, it generates wrong indentation when compiling to YAML | {
"login": "juangon",
"id": 1306127,
"node_id": "MDQ6VXNlcjEzMDYxMjc=",
"avatar_url": "https://avatars.githubusercontent.com/u/1306127?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/juangon",
"html_url": "https://github.com/juangon",
"followers_url": "https://api.github.com/users/juangon/followers",
"following_url": "https://api.github.com/users/juangon/following{/other_user}",
"gists_url": "https://api.github.com/users/juangon/gists{/gist_id}",
"starred_url": "https://api.github.com/users/juangon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/juangon/subscriptions",
"organizations_url": "https://api.github.com/users/juangon/orgs",
"repos_url": "https://api.github.com/users/juangon/repos",
"events_url": "https://api.github.com/users/juangon/events{/privacy}",
"received_events_url": "https://api.github.com/users/juangon/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"It seems I can't reproduce it anymore, closing..."
] | "2021-05-20T16:35:08" | "2021-05-26T09:03:10" | "2021-05-26T09:03:10" | NONE | null | ### Environment
* KFP version: 1.6.2
* KFP SDK version: 1.6.2
* All dependencies version:
### Steps to reproduce
Upgrade to latest kfp (1.6.2)
Compile a pipeline (using dsl.component annotations in my case)
When executing pipeline, an "Indent" error will show up.
It works in 1.6.0. Fails in 1.6.2
### Expected result
It executes pipeline properly.
### Materials and Reference
---
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5710/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5710/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5709 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5709/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5709/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5709/events | https://github.com/kubeflow/pipelines/issues/5709 | 897,070,930 | MDU6SXNzdWU4OTcwNzA5MzA= | 5,709 | [sdk] Regression - func_to_container_op no longer handles backslash characters correctly | {
"login": "rclough",
"id": 186589,
"node_id": "MDQ6VXNlcjE4NjU4OQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/186589?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rclough",
"html_url": "https://github.com/rclough",
"followers_url": "https://api.github.com/users/rclough/followers",
"following_url": "https://api.github.com/users/rclough/following{/other_user}",
"gists_url": "https://api.github.com/users/rclough/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rclough/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rclough/subscriptions",
"organizations_url": "https://api.github.com/users/rclough/orgs",
"repos_url": "https://api.github.com/users/rclough/repos",
"events_url": "https://api.github.com/users/rclough/events{/privacy}",
"received_events_url": "https://api.github.com/users/rclough/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"@Ark-kun ",
"This was expected to be fixed in https://github.com/kubeflow/pipelines/pull/4993 v1.4.0\r\nLooking...",
"This does not reproduce for me in v1.4.0+\r\n\r\n\r\nHere is the generated `component.yaml`:\r\n```yaml\r\nname: Break ftco\r\noutputs:\r\n- {name: Output, type: String}\r\nimplementation:\r\n container:\r\n image: python:3.7\r\n command:\r\n - sh\r\n - -ec\r\n - |\r\n program_path=$(mktemp)\r\n printf \"%s\" \"$0\" > \"$program_path\"\r\n python3 -u \"$program_path\" \"$@\"\r\n - |\r\n def break_ftco():\r\n print(\"Printing an escaped quote \\\\\\\" will break\")\r\n return \"something\"\r\n\r\n def _serialize_str(str_value: str) -> str:\r\n if not isinstance(str_value, str):\r\n raise TypeError('Value \"{}\" has type \"{}\" instead of str.'.format(str(str_value), str(type(str_value))))\r\n return str_value\r\n\r\n import argparse\r\n _parser = argparse.ArgumentParser(prog='Break ftco', description='')\r\n _parser.add_argument(\"----output-paths\", dest=\"_output_paths\", type=str, nargs=1)\r\n _parsed_args = vars(_parser.parse_args())\r\n _output_files = _parsed_args.pop(\"_output_paths\", [])\r\n\r\n _outputs = break_ftco(**_parsed_args)\r\n\r\n _outputs = [_outputs]\r\n\r\n _output_serializers = [\r\n _serialize_str,\r\n\r\n ]\r\n\r\n import os\r\n for idx, output_file in enumerate(_output_files):\r\n try:\r\n os.makedirs(os.path.dirname(output_file))\r\n except OSError:\r\n pass\r\n with open(output_file, 'w') as f:\r\n f.write(_output_serializers[idx](_outputs[idx]))\r\n args:\r\n - '----output-paths'\r\n - {outputPath: Output}\r\n\r\n```",
"Ah, we're currently on 1.3.0, good to know it's already fixed, we'll update ASAP",
">Ah, we're currently on 1.3.0, good to know it's already fixed, we'll update ASAP\r\n\r\nNote that only the SDK needs to be updated."
] | "2021-05-20T16:21:28" | "2021-05-26T21:21:21" | "2021-05-26T21:21:21" | NONE | null | ### Environment
* KFP version: Works <1.2.0, broken in 1.2.0+
### Steps to reproduce
This is a super simplified version of what I've found:
```python
def break_ftco() -> str:
print("Printing an escaped quote \\\" will break")
return "something"
@pipeline(name="test-ftco", description="")
def pipeline():
irrelevant = func_to_container_op(
func=break_ftco,
base_image="gcr.io/my-image/name:tag
)()
```
### Expected result
Component should print:
```
Printing an escaped quote \" will break
```
This works in kfp<1.2.0, but not >=1.2.0, in >=1.2.0, the component fails and the following is logged:
```
File "/tmp/tmp.87n1N4N8zw", line 2
print("Printing an escaped quote \\" will break")
^
SyntaxError: invalid syntax
```
### Materials and Reference
Context:
When updating kfp SDK recently, one of our customers reported that one of their func_to_container_op functions stopped working properly. It ran, but was producing invalid results. In their case, they were doing a regex substitution on a string, where the regex substitution contained a backslash (`\`).
I compared pod definitions between the two versions and discovered that KFP changed the way they were executing python code for func_to_container_op, found the location in the code, and the relevant PR that introduced this regression: https://github.com/kubeflow/pipelines/pull/4861
More info on the original use case can be found there, but I narrowed it down to an example where `func_to_container_op` will fail to run for what is otherwise valid python code.
It may also be worth noting that since the code changed from being directly run with python to being passed through `sh` into a file, there may be other similar special shell characters to be escaped, but that's beyond my knowledge
---
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5709/reactions",
"total_count": 5,
"+1": 5,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5709/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5708 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5708/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5708/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5708/events | https://github.com/kubeflow/pipelines/issues/5708 | 896,680,591 | MDU6SXNzdWU4OTY2ODA1OTE= | 5,708 | [feature] Provide a `kfp.components.load_component_from_dict` function | {
"login": "omarzouk",
"id": 18171182,
"node_id": "MDQ6VXNlcjE4MTcxMTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/18171182?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/omarzouk",
"html_url": "https://github.com/omarzouk",
"followers_url": "https://api.github.com/users/omarzouk/followers",
"following_url": "https://api.github.com/users/omarzouk/following{/other_user}",
"gists_url": "https://api.github.com/users/omarzouk/gists{/gist_id}",
"starred_url": "https://api.github.com/users/omarzouk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/omarzouk/subscriptions",
"organizations_url": "https://api.github.com/users/omarzouk/orgs",
"repos_url": "https://api.github.com/users/omarzouk/repos",
"events_url": "https://api.github.com/users/omarzouk/events{/privacy}",
"received_events_url": "https://api.github.com/users/omarzouk/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1122445895,
"node_id": "MDU6TGFiZWwxMTIyNDQ1ODk1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk/components",
"name": "area/sdk/components",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Ark-kun",
"id": 1829149,
"node_id": "MDQ6VXNlcjE4MjkxNDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1829149?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ark-kun",
"html_url": "https://github.com/Ark-kun",
"followers_url": "https://api.github.com/users/Ark-kun/followers",
"following_url": "https://api.github.com/users/Ark-kun/following{/other_user}",
"gists_url": "https://api.github.com/users/Ark-kun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ark-kun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ark-kun/subscriptions",
"organizations_url": "https://api.github.com/users/Ark-kun/orgs",
"repos_url": "https://api.github.com/users/Ark-kun/repos",
"events_url": "https://api.github.com/users/Ark-kun/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ark-kun/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"Would a `load_component_spec_from_component_spec(ComponentSpec)` function be desirable as a replacement?",
"> Would a `load_component_spec_from_component_spec(ComponentSpec)` function be desirable as a replacement?\r\n\r\nyes absolutely, as long as this way of building containers is guaranteed to be maintained in the future, it is a pain in the ass to have to re-write all components just to describe basic properties such as image name and inputs and outputs.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"
] | "2021-05-20T11:27:13" | "2021-10-28T17:27:58" | "2021-10-28T17:27:58" | CONTRIBUTOR | null | ### Feature Area
/area sdk
### What feature would you like to see?
Provide a `load_component_from_dict` function that calls `ComponentSpec.from_dict` under the hood, which would allw the user to create operators in a fashion similar to the old `dsl.ContainerOp` without having to generate an intermediate yaml representation. The spec of this dictionary can be 1-to-1 with the yaml and this would be easy to maintain.
Today the main loader (`_load_component_spec_from_component_text`) looks like this:
```
component_dict = load_yaml(text)
component_spec = ComponentSpec.from_dict(component_dict)
```
Let me skip the yaml...
### What is the use case or pain point?
Forcing the use of yaml files on the SDK users is an arbitrary decision/choice of configuration vessel, and is fairly unnatural in an environment where users are already using a fully featured programming language like python
### Is there a workaround currently?
https://github.com/kubeflow/pipelines/issues/3748#issuecomment-627698554 however it seems to be using the internals of the SDK which means its not future proof or safe to use.
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5708/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5708/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5706 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5706/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5706/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5706/events | https://github.com/kubeflow/pipelines/issues/5706 | 896,454,302 | MDU6SXNzdWU4OTY0NTQzMDI= | 5,706 | [sdk] compile() got an unexpected keyword argument 'mode' | {
"login": "lambertsbennett",
"id": 46295426,
"node_id": "MDQ6VXNlcjQ2Mjk1NDI2",
"avatar_url": "https://avatars.githubusercontent.com/u/46295426?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lambertsbennett",
"html_url": "https://github.com/lambertsbennett",
"followers_url": "https://api.github.com/users/lambertsbennett/followers",
"following_url": "https://api.github.com/users/lambertsbennett/following{/other_user}",
"gists_url": "https://api.github.com/users/lambertsbennett/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lambertsbennett/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lambertsbennett/subscriptions",
"organizations_url": "https://api.github.com/users/lambertsbennett/orgs",
"repos_url": "https://api.github.com/users/lambertsbennett/repos",
"events_url": "https://api.github.com/users/lambertsbennett/events{/privacy}",
"received_events_url": "https://api.github.com/users/lambertsbennett/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1136110037,
"node_id": "MDU6TGFiZWwxMTM2MTEwMDM3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/sdk",
"name": "area/sdk",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | null | [] | null | [
"Also, if I change the package_path to 'prophet-test.yaml' the upper error disappears, but the compiler error remains.",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"> This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\r\n\r\nTo my knowledge this has not been resolved.",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-20T08:07:09" | "2022-03-03T04:05:33" | "2022-03-03T04:05:33" | NONE | null | ### Environment
I have a minikube cluster running on a linux server (Ubuntu 18.04) where kubeflow pipelines is running. I am connected via an ssh tunnel from my laptop running Windows 10. I am writing code in Python 3.8.5. I can connect with kf pipelines and list current experiments/runs and all that from my environment. I also previously used function-based components and was able to submit those to KFP for execution.
* KFP version: 1.5.0
* KFP SDK version: 1.6.2
### Steps to reproduce
I am new to kfp, so I tried to model my own pipeline after the example found here: https://www.kubeflow.org/docs/components/pipelines/sdk/v2/build-pipeline/
When I run:
```
compiler.Compiler().compile(
pipeline_func=prophet_pipeline,
package_path='prophet-test.yaml',
mode=kfp.dsl.PipelineExecutionMode.V2_COMPATIBLE
)
client.create_run_from_pipeline_package('prophet-test.yaml', arguments=arguments)
```
I get the error:
```
Traceback (most recent call last):
File "kfp_prophet.py", line 138, in <module>
run_pipeline(args.path)
File "kfp_prophet.py", line 126, in run_pipeline
client.create_run_from_pipeline_package('prophet-test.json', arguments=arguments)
File "\lib\site-packages\kfp\_client.py", line 843, in create_run_from_pipeline_package
run_info = self.run_pipeline(
File "\Anaconda3\lib\site-packages\kfp\_client.py", line 603, in run_pipeline
job_config = self._create_job_config(
File "\Anaconda3\lib\site-packages\kfp\_client.py", line 706, in _create_job_config
pipeline_obj = self._extract_pipeline_yaml(pipeline_package_path)
File "\Anaconda3\lib\site-packages\kfp\_client.py", line 532, in _extract_pipeline_yaml
raise ValueError('The package_file '+ package_file + ' should end with one of the following formats: [.tar.gz, .tgz, .zip, .yaml, .yml]')
ValueError: The package_file prophet-test.json should end with one of the following formats: [.tar.gz, .tgz, .zip, .yaml, .yml]
Prophet> python kfp_prophet.py --f data.pkl
Traceback (most recent call last):
File "kfp_prophet.py", line 131, in <module>
compiler.Compiler().compile(
TypeError: compile() got an unexpected keyword argument 'mode'
```
### Expected result
The pipeline should be compiled and submitted to KFP for execution.
### Materials and Reference
I followed the example provided here https://www.kubeflow.org/docs/components/pipelines/sdk/v2/build-pipeline/ and modified it to execute my own code.
Thanks for your help! I can provide more code snippets if necessary to debug the issue. | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5706/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5706/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5705 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5705/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5705/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5705/events | https://github.com/kubeflow/pipelines/issues/5705 | 896,301,948 | MDU6SXNzdWU4OTYzMDE5NDg= | 5,705 | [pH] move kubeflow/frontend into KFP repo | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1116354964,
"node_id": "MDU6TGFiZWwxMTE2MzU0OTY0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/S",
"name": "size/S",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "zijianjoy",
"id": 37026441,
"node_id": "MDQ6VXNlcjM3MDI2NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/37026441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zijianjoy",
"html_url": "https://github.com/zijianjoy",
"followers_url": "https://api.github.com/users/zijianjoy/followers",
"following_url": "https://api.github.com/users/zijianjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/zijianjoy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zijianjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zijianjoy/subscriptions",
"organizations_url": "https://api.github.com/users/zijianjoy/orgs",
"repos_url": "https://api.github.com/users/zijianjoy/repos",
"events_url": "https://api.github.com/users/zijianjoy/events{/privacy}",
"received_events_url": "https://api.github.com/users/zijianjoy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign @zijianjoy "
] | "2021-05-20T05:35:04" | "2021-07-03T11:16:49" | "2021-07-03T11:16:49" | CONTRIBUTOR | null | https://github.com/kubeflow/frontend
imports: https://github.com/kubeflow/pipelines/search?q=kubeflow%2Ffrontend | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5705/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5705/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5704 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5704/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5704/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5704/events | https://github.com/kubeflow/pipelines/issues/5704 | 896,249,280 | MDU6SXNzdWU4OTYyNDkyODA= | 5,704 | [v2compat] configurable default pipeline root | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 952830767,
"node_id": "MDU6TGFiZWw5NTI4MzA3Njc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/M",
"name": "size/M",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"/assign @capri-xiyue ",
"Discussed with @capri-xiyue, we agree on:\r\n\r\n* P0 configurable default pipeline root #5750 \r\n* P1 support s3 pipeline_root with generic options: endpoint, region, insecure, etc, so that it can be used with user maintained MinIO or other compatible storages. Credentials can be set similar to aws/gcp credentials, but not using the same env vars as AWS. (Needs a detailed design)\r\n\r\nFor this issue we only target P0 items"
] | "2021-05-20T04:10:05" | "2021-06-02T15:52:02" | "2021-06-02T15:52:02" | CONTRIBUTOR | null | Quoted from https://github.com/kubeflow/pipelines/issues/4649#issuecomment-844035914
Blocks https://github.com/kubeflow/pipelines/issues/5680
> FYI, KFP v2 compatible mode has been released, see documentation: https://www.kubeflow.org/docs/components/pipelines/sdk/v2/.
>
> It doesn't support artifact repository configuration, this is one of the things we want to support too. So I'm posting early thoughts on this related issue.
>
> Let me first try to summarize requirements for configuring artifact repositories for both KFP v2 compatible and v2.
>
> ## Object store specific credentials requirements
> For GCS, AWS S3, we suggest setting up credentials, so that they represent identity of the pipeline step, so that not only artifact upload/download, calls to other Cloud services should also use the same credentials. For this reason, we don't recommend setting credentials in artifact repository config. The suggestion is to configure the identity transparently if possible using GCP workload identity or AWS IRSA. If credentials are really necessary, they can be configured using pipeline DSL via [kfp.gcp.use_gcp_secret](https://kubeflow-pipelines.readthedocs.io/en/latest/source/kfp.extensions.html#kfp.gcp.use_gcp_secret) or [kfp.aws.use_aws_secret](https://kubeflow-pipelines.readthedocs.io/en/latest/source/kfp.extensions.html#kfp.aws.use_aws_secret) etc. These principles should apply to other Cloud Providers that has credentials that can be used with all its services.
>
> For on-prem object store like MinIO, the credentials do not represent an identity, they are only used to access a specified object store instance. Therefore, it's reasonable to include them in artifact repository config.
>
> ## In summary
> * For GCS, only pipeline root needs to be configurable.
> * For AWS S3, besides pipeline root, we also need region, endpoint etc to be configurable.
> * For MinIO or similar on-prem object stores, besides pipeline root, we also need endpoint, credentials to be configurable.
>
> We cannot implement a spec for every possible object stores, so likely we should use the same spec as what [Go CDK](https://gocloud.dev/) supports or depend on cloud provider contributions.
>
> Go CDK supports provider specific query params to configure some things other than object key, so we might consider adopting these query params, so that pipeline root can be more expressive, so we might not need other configurations.
> e.g. for S3, it's possible to configure region via a query param: https://gocloud.dev/howto/blob/#s3
>
> ```
> s3://my-bucket?region=us-west-1
> ```
>
> ## How we configure pipeline root, other configs and credentials?
> Ideally, pipeline root can include all other configs, so that we can uniquely identify an artifact.
> Ideally, credentials should be configurable transparently.
>
> When both ideal requirements are met, we only need to support namespace level default pipeline root. All other configurations can be done by specifying different pipeline roots.
>
> However, now MinIO violates the requirement that credentials can be configured transparently. Therefore, we need a mechanism to either
>
> * configure which credentials should be used with which pipeline root (probably, write rules like which pipeline_root prefix/query param should use which credentials)
> * or configure credentials with pipeline root together as artifact repository (but then we should specify artifact repos, not pipeline roots)
> * or ask users to configure credentials separately from pipeline_root
>
> We probably need more thoughts on the exact config format, this seems like a complex problem.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5704/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5704/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5703 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5703/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5703/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5703/events | https://github.com/kubeflow/pipelines/issues/5703 | 896,050,194 | MDU6SXNzdWU4OTYwNTAxOTQ= | 5,703 | [feature] Consistent timezones | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1118896905,
"node_id": "MDU6TGFiZWwxMTE4ODk2OTA1",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/backend",
"name": "area/backend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1289588140,
"node_id": "MDU6TGFiZWwxMjg5NTg4MTQw",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/feature",
"name": "kind/feature",
"color": "2515fc",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-19T23:41:30" | "2022-03-03T06:05:16" | "2022-03-03T06:05:16" | CONTRIBUTOR | null | ### Feature Area
<!-- Uncomment the labels below which are relevant to this feature: -->
<!-- /area frontend -->
/area backend
<!-- /area sdk -->
<!-- /area samples -->
<!-- /area components -->
### What feature would you like to see?
<!-- Provide a description of this feature and the user experience. -->
Consistent timezone experience in KFP.
Config: default to local time zone, configurable to any timezone.
UX: all the code that deals with time should act in this timezone:
- API server - time related pipeline placeholders
- Cron expression timezone
- are there more?
Challenge:
How to handle upgrade? This is a breaking change.
### What is the use case or pain point?
<!-- It helps us understand the benefit of this feature for your use case. -->
It's easier for people to work with the local timezone.
### Is there a workaround currently?
<!-- Without this feature, how do you accomplish your task today? -->
Use a different cron scheduler than KFP recurring runs.
---
<!-- Don't delete message below to encourage users to support your feature request! -->
Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5703/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5703/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5700 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5700/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5700/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5700/events | https://github.com/kubeflow/pipelines/issues/5700 | 895,856,799 | MDU6SXNzdWU4OTU4NTY3OTk= | 5,700 | [bug] kserving-component still uses minio however boto3 is officially added in kf-serving to use IRSA | {
"login": "ahsan-n",
"id": 74932557,
"node_id": "MDQ6VXNlcjc0OTMyNTU3",
"avatar_url": "https://avatars.githubusercontent.com/u/74932557?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ahsan-n",
"html_url": "https://github.com/ahsan-n",
"followers_url": "https://api.github.com/users/ahsan-n/followers",
"following_url": "https://api.github.com/users/ahsan-n/following{/other_user}",
"gists_url": "https://api.github.com/users/ahsan-n/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ahsan-n/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ahsan-n/subscriptions",
"organizations_url": "https://api.github.com/users/ahsan-n/orgs",
"repos_url": "https://api.github.com/users/ahsan-n/repos",
"events_url": "https://api.github.com/users/ahsan-n/events{/privacy}",
"received_events_url": "https://api.github.com/users/ahsan-n/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
},
{
"id": 2710158147,
"node_id": "MDU6TGFiZWwyNzEwMTU4MTQ3",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/needs%20more%20info",
"name": "needs more info",
"color": "DBEF12",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@ahsan-n, I think the problem is solved in next release `0.6` of kfserving.\r\n\r\nBut the docker image `quay.io/aipipeline/kfserving-component:v0.6.0` is not yet available. Think this still needs some attention to confirm it's been resolved.",
"Hi @rawc0der just wondering what is the release timeline for `quay.io/aipipeline/kfserving-component:v0.6.0` ?",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-19T20:29:58" | "2022-03-03T04:05:23" | "2022-03-03T04:05:23" | NONE | null | ### What steps did you take
Hi, so i am creating pipeline to host / serve model that resides in s3. For that I used [example for sample pipeline](https://github.com/kubeflow/kfserving/blob/master/docs/samples/pipelines/sample-tf-pipeline.py) which has [kfserving-component ](https://raw.githubusercontent.com/kubeflow/pipelines/master/components/kubeflow/kfserving/component.yaml). I replaced gc path with my s3 bucket.
### What happened:
I get the following error in storage
```
[I 210519 20:13:05 initializer-entrypoint:13] Initializing, args: src_uri [s3://my-bucket/saved_model] dest_path[ [/mnt/models]
[I 210519 20:13:05 storage:45] Copying contents of s3://my-bucket/saved_model to local
Traceback (most recent call last):
File "/storage-initializer/scripts/initializer-entrypoint", line 14, in <module>
kfserving.Storage.download(src_uri, dest_path)
File "/usr/local/lib/python3.7/site-packages/kfserving/storage.py", line 62, in download
Storage._download_s3(uri, out_dir)
File "/usr/local/lib/python3.7/site-packages/kfserving/storage.py", line 89, in _download_s3
for obj in objects:
File "/usr/local/lib/python3.7/site-packages/minio/api.py", line 2297, in _list_objects
query=query,
File "/usr/local/lib/python3.7/site-packages/minio/api.py", line 2229, in _url_open
object_name).get_exception()
minio.error.AccessDenied: AccessDenied: message: Access Denied
```
### What did you expect to happen:
When looking over github i found out that because minio does not support iam role for service accounts, [boto3 has replaced minio](https://github.com/kubeflow/kfserving/pull/1472). Now I am wondering how can i use that kfserving-component but with boto3 :)
### Environment:
kubeflow v1.3
* How do you deploy Kubeflow Pipelines (KFP)?
use kfp.Compile to extract out yaml and uploaded in pipelines UI
* KFP SDK version:
v1.6.2
### Anything else you would like to add:
<!-- Miscellaneous information that will assist in solving the issue.-->
### Labels
<!-- Please include labels below by uncommenting them to help us better triage issues -->
<!-- /area frontend -->
<!-- /area backend -->
<!-- /area sdk -->
<!-- /area testing -->
<!-- /area samples -->
/area components
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5700/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5700/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5694 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5694/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5694/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5694/events | https://github.com/kubeflow/pipelines/issues/5694 | 895,067,746 | MDU6SXNzdWU4OTUwNjc3NDY= | 5,694 | [bug] Broken pipe when using AI platform training operator | {
"login": "zygm0nt",
"id": 179461,
"node_id": "MDQ6VXNlcjE3OTQ2MQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/179461?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zygm0nt",
"html_url": "https://github.com/zygm0nt",
"followers_url": "https://api.github.com/users/zygm0nt/followers",
"following_url": "https://api.github.com/users/zygm0nt/following{/other_user}",
"gists_url": "https://api.github.com/users/zygm0nt/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zygm0nt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zygm0nt/subscriptions",
"organizations_url": "https://api.github.com/users/zygm0nt/orgs",
"repos_url": "https://api.github.com/users/zygm0nt/repos",
"events_url": "https://api.github.com/users/zygm0nt/events{/privacy}",
"received_events_url": "https://api.github.com/users/zygm0nt/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 930619516,
"node_id": "MDU6TGFiZWw5MzA2MTk1MTY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/frontend",
"name": "area/frontend",
"color": "d2b48c",
"default": false,
"description": ""
},
{
"id": 1073153908,
"node_id": "MDU6TGFiZWwxMDczMTUzOTA4",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/kind/bug",
"name": "kind/bug",
"color": "fc2515",
"default": false,
"description": ""
},
{
"id": 1126834402,
"node_id": "MDU6TGFiZWwxMTI2ODM0NDAy",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/area/components",
"name": "area/components",
"color": "d2b48c",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"I see this was solved by a previous CR: https://github.com/kubeflow/pipelines/issues/5085"
] | "2021-05-19T07:02:39" | "2021-05-19T08:58:26" | "2021-05-19T08:58:26" | NONE | null | ### What steps did you take
Start a long-running job on AI platform and have it succeed, to be able to progress to subsequent steps.
I have a job defined using this operator:
```
mlengine_train_op = kfp.components.load_component_from_url(
'https://raw.githubusercontent.com/kubeflow/pipelines/master/components/gcp/ml_engine/train/component.yaml')
```
and I start it with the following parameters set (note that I'm running the job from docker image):
```
mlengine_train_op(
name="",
project_id=project_id,
region=region,
job_dir=job_dir,
master_image_uri=master_image_uri,
training_input=training_input,
job_id=job_id,
wait_interval=wait_interval
```
### What happened:
After some time the job fails with the following error - this is roughly an hour.
```
INFO:root:job status is RUNNING, wait for 30s
INFO:googleapiclient.discovery:URL being requested: GET
https://ml.googleapis.com/v1/projects/xxx/jobs/xxxyyy_20210518_17000?alt=json
Traceback (most recent call last):
File "/ml/kfp_component/google/ml_engine/_client.py", line 40, in wrapper
return func(self, *args, **kwargs)
File "/ml/kfp_component/google/ml_engine/_client.py", line 113, in get_job
name=job_name).execute()
File "/usr/local/lib/python3.7/site-packages/googleapiclient/_helpers.py", line 130, in positional_wrapper
return wrapped(*args, **kwargs)
File "/usr/local/lib/python3.7/site-packages/googleapiclient/http.py", line 846, in execute
method=str(self.method), body=self.body, headers=self.headers)
File "/usr/local/lib/python3.7/site-packages/googleapiclient/http.py", line 183, in _retry_request
raise exception
File "/usr/local/lib/python3.7/site-packages/googleapiclient/http.py", line 164, in _retry_request
resp, content = http.request(uri, method, *args, **kwargs)
File "/usr/local/lib/python3.7/site-packages/google_auth_httplib2.py", line 209, in request
self.credentials.before_request(self._request, method, uri, request_headers)
File "/usr/local/lib/python3.7/site-packages/google/auth/credentials.py", line 133, in before_request
self.refresh(request)
File "/usr/local/lib/python3.7/site-packages/google/auth/compute_engine/credentials.py", line 111, in refresh
self._retrieve_info(request)
File "/usr/local/lib/python3.7/site-packages/google/auth/compute_engine/credentials.py", line 88, in _retrieve_info
request, service_account=self._service_account_email
File "/usr/local/lib/python3.7/site-packages/google/auth/compute_engine/_metadata.py", line 234, in get_service_account_info
return get(request, path, params={"recursive": "true"})
File "/usr/local/lib/python3.7/site-packages/google/auth/compute_engine/_metadata.py", line 150, in get
response = request(url=url, method="GET", headers=_METADATA_HEADERS)
File "/usr/local/lib/python3.7/site-packages/google_auth_httplib2.py", line 120, in __call__
url, method=method, body=body, headers=headers, **kwargs
File "/usr/local/lib/python3.7/site-packages/googleapiclient/http.py", line 1724, in new_request
redirections, connection_type)
File "/usr/local/lib/python3.7/site-packages/httplib2/__init__.py", line 1991, in request
cachekey,
File "/usr/local/lib/python3.7/site-packages/httplib2/__init__.py", line 1651, in _request
conn, request_uri, method, body, headers
File "/usr/local/lib/python3.7/site-packages/httplib2/__init__.py", line 1558, in _conn_request
conn.request(method, request_uri, body, headers)
File "/usr/local/lib/python3.7/http/client.py", line 1277, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/usr/local/lib/python3.7/http/client.py", line 1323, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/usr/local/lib/python3.7/http/client.py", line 1272, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/usr/local/lib/python3.7/http/client.py", line 1032, in _send_output
self.send(msg)
File "/usr/local/lib/python3.7/http/client.py", line 993, in send
self.sock.sendall(data)
BrokenPipeError: [Errno 32] Broken pipe
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/ml/kfp_component/launcher/__main__.py", line 45, in <module>
main()
File "/ml/kfp_component/launcher/__main__.py", line 42, in main
launch(args.file_or_module, args.args)
File "/ml/kfp_component/launcher/launcher.py", line 45, in launch
return fire.Fire(module, command=args, name=module.__name__)
File "/usr/local/lib/python3.7/site-packages/fire/core.py", line 127, in Fire
component_trace = _Fire(component, args, context, name)
File "/usr/local/lib/python3.7/site-packages/fire/core.py", line 366, in _Fire
component, remaining_args)
File "/usr/local/lib/python3.7/site-packages/fire/core.py", line 542, in _CallCallable
result = fn(*varargs, **kwargs)
File "/ml/kfp_component/google/ml_engine/_train.py", line 105, in train
job_dir_output_path=job_dir_output_path)
File "/ml/kfp_component/google/ml_engine/_create_job.py", line 62, in create_job
job_dir_output_path=job_dir_output_path,
File "/ml/kfp_component/google/ml_engine/_create_job.py", line 89, in execute_and_wait
job_dir_output_path=self._job_dir_output_path,
File "/ml/kfp_component/google/ml_engine/_common_ops.py", line 93, in wait_for_job_done
job = ml_client.get_job(project_id, job_id)
File "/ml/kfp_component/google/ml_engine/_client.py", line 48, in wrapper
e._class__.__name__, _delay
AttributeError: 'BrokenPipeError' object has no attribute '_class__
```
### What did you expect to happen:
Correct job tracking behaviour. The job itself is still running in AI platform, and finishes successfully after some more time - this particular job takes around 2h30min to complete.
### Environment:
* How do you deploy Kubeflow Pipelines (KFP)?
Deployed to GCP
* KFP version:
1.4.1
* KFP SDK version:
1.4.0
### Anything else you would like to add:
### Labels
/area frontend
<!-- /area backend -->
<!-- /area sdk -->
<!-- /area testing -->
<!-- /area samples -->
/area components
---
<!-- Don't delete message below to encourage users to support your issue! -->
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
| {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5694/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5694/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5693 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5693/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5693/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5693/events | https://github.com/kubeflow/pipelines/issues/5693 | 895,037,033 | MDU6SXNzdWU4OTUwMzcwMzM= | 5,693 | [Release] KFP 1.6.0 release | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 942985146,
"node_id": "MDU6TGFiZWw5NDI5ODUxNDY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/XS",
"name": "size/XS",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"The pending changes can be released in 1.6.1 either, so let's release 1.6.0 first.",
"DONE: https://github.com/kubeflow/pipelines/releases/tag/1.6.0"
] | "2021-05-19T06:22:16" | "2021-05-24T07:26:15" | "2021-05-24T06:44:26" | CONTRIBUTOR | null | Changes we need:
* add permission for token request (prepare for auth token change in SDK)
* running v2 compatible mode in Kubeflow 1.3.1 https://github.com/kubeflow/pipelines/issues/5680
* https://github.com/kubeflow/pipelines/issues/5717
Only the first change seems reasonable in a short time period, so I plan to implement it. The other changes can probably wait for 1.7.0 or 1.6.x | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5693/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5693/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5692 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5692/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5692/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5692/events | https://github.com/kubeflow/pipelines/issues/5692 | 895,035,682 | MDU6SXNzdWU4OTUwMzU2ODI= | 5,692 | Migrate v2 sample tests to use v2 compatible pipelines | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 952830767,
"node_id": "MDU6TGFiZWw5NTI4MzA3Njc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/M",
"name": "size/M",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 2157634204,
"node_id": "MDU6TGFiZWwyMTU3NjM0MjA0",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/lifecycle/stale",
"name": "lifecycle/stale",
"color": "bbbbbb",
"default": false,
"description": "The issue / pull request is stale, any activities remove this label."
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"This issue has been automatically closed because it has not had recent activity. Please comment \"/reopen\" to reopen it.\n"
] | "2021-05-19T06:20:23" | "2022-03-03T06:05:12" | "2022-03-03T06:05:12" | CONTRIBUTOR | null | This helps:
* validation of v2 compatible mode
* inspire new ideas to improve the UX | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5692/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5692/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5691 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5691/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5691/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5691/events | https://github.com/kubeflow/pipelines/issues/5691 | 895,034,670 | MDU6SXNzdWU4OTUwMzQ2NzA= | 5,691 | [Doc] introduce v2 compatible mode current caveats | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 942985146,
"node_id": "MDU6TGFiZWw5NDI5ODUxNDY=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/XS",
"name": "size/XS",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-05-19T06:19:00" | "2021-05-24T07:26:12" | "2021-05-22T00:41:30" | CONTRIBUTOR | null | current caveats introduced in https://bit.ly/kfp-v2-compatible,
we also need to link to this section in kubeflow.org documentation https://www.kubeflow.org/docs/components/pipelines/sdk/v2/v2-compatibility/ | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5691/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5691/timeline | null | completed | null | null | false |
https://api.github.com/repos/kubeflow/pipelines/issues/5690 | https://api.github.com/repos/kubeflow/pipelines | https://api.github.com/repos/kubeflow/pipelines/issues/5690/labels{/name} | https://api.github.com/repos/kubeflow/pipelines/issues/5690/comments | https://api.github.com/repos/kubeflow/pipelines/issues/5690/events | https://github.com/kubeflow/pipelines/issues/5690 | 895,030,708 | MDU6SXNzdWU4OTUwMzA3MDg= | 5,690 | [Doc] generic introduction of connecting KFP SDK to a cluster | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"id": 952830767,
"node_id": "MDU6TGFiZWw5NTI4MzA3Njc=",
"url": "https://api.github.com/repos/kubeflow/pipelines/labels/size/M",
"name": "size/M",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
} | [
{
"login": "Bobgy",
"id": 4957653,
"node_id": "MDQ6VXNlcjQ5NTc2NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/4957653?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bobgy",
"html_url": "https://github.com/Bobgy",
"followers_url": "https://api.github.com/users/Bobgy/followers",
"following_url": "https://api.github.com/users/Bobgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Bobgy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bobgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bobgy/subscriptions",
"organizations_url": "https://api.github.com/users/Bobgy/orgs",
"repos_url": "https://api.github.com/users/Bobgy/repos",
"events_url": "https://api.github.com/users/Bobgy/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bobgy/received_events",
"type": "User",
"site_admin": false
}
] | null | [] | "2021-05-19T06:13:13" | "2021-05-27T05:01:17" | "2021-05-27T05:01:17" | CONTRIBUTOR | null | https://github.com/kubeflow/website/pull/2715#discussion_r632715772 | {
"url": "https://api.github.com/repos/kubeflow/pipelines/issues/5690/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/kubeflow/pipelines/issues/5690/timeline | null | completed | null | null | false |