Datasets:

bug-localization

/

apache_bugs

like 0

Bug 57436 Java 1.5 fails to run classes produced by ajc

Java 1.5 beta reports a ClassFormatError when running programs (e.g., spacewar) compiled by ajc 1.1.1 and the latest CVS head. Sun's Java 1.5 beta binary-compatibility docs say that some obfuscators violated the .class format specification, so those .class files will fail when run under 1.5. (The docs also say they are still incomplete.) Although 1.5 is still beta, we would want to submit a bug to Sun if our implementation techniques are valid, so we don't have to change those techniques. For 1.2, we should at document if we don't fix, since many people are using 1.5.

resolved fixed

b0d32ca

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 57430 exception printing

Exceptions thrown from the compiler used to be printed once, with the submit-bug header. Now they are printed twice, without and with the header. True of CVS version.

resolved fixed

e7ac54f

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/AjCompilerAdapter.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 55341 error Type mismatch: cannot convert from java.lang.String to java.lang.String

When compiling a binary concrete aspect library (for later LTW) consisting of more than one aspect that performs an ITD on a target class not exposed to the weaver I get the following error: error Type mismatch: cannot convert from java.lang.String to java.lang.String The error does not oocur if a complete build & weave is performed. Testcase attached.

resolved fixed

0521e79

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InterTypeMemberFinder.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/BcweaverJarMaker.java", "tests/bugs/StringToString/HW.java", "tests/bugs/StringToString/X.java", "weaver/testsrc/org/aspectj/weaver/WeavingURLClassLoaderTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 31460 Weaving class loader

Hi! As discussed on the mailing list a few days ago I implemented a weaving class loader to enable bytecode based weaving at class loading time. The class loader is based on the URLClassLoader and can be used like any other URLClassLoader. In addition to that you can add aspects to the weaving loader. These aspects got woven into each class that is loaded. The test cases for the class loader aren't implemented yet, I am still thinking about how to implement them. I will contribute them later, okay? -Martin

resolved fixed

33d8ee9

["org.aspectj.ajdt.core/testdata/src1/LTWHelloWorld.java", "org.aspectj.ajdt.core/testdata/src1/ltw/LTWPackageTest.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/BcweaverJarMaker.java", "util/src/org/aspectj/util/FileUtil.java", "weaver/src/org/aspectj/weaver/ExtensibleURLClassLoader.java", "weaver/src/org/aspectj/weaver/WeavingURLClassLoader.java", "weaver/src/org/aspectj/weaver/tools/GeneratedClassHandler.java", "weaver/src/org/aspectj/weaver/tools/WeavingAdaptor.java", "weaver/src/org/aspectj/weaver/tools/WeavingClassLoader.java", "weaver/testsrc/BcweaverModuleTests.java", "weaver/testsrc/org/aspectj/weaver/BcweaverTests.java", "weaver/testsrc/org/aspectj/weaver/WeavingURLClassLoaderTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 53012 declare precedence on a class should be a compile-time error

The compiler silently accepts ---- public class DeclarePrecedence { public static void main(String[] args) { System.out.println("hello"); } } aspect DP { declare precedence: DeclarePrecedence, DP; before() : staticinitialization(DeclarePrecedence) { System.out.println("ok"); } } ---- Since this is likely to be a mistake, an error would be nice. However, that would mean saying (!TargetClass && TargetClass+) to pick out the aspect subtypes of TargetClass.

resolved fixed

0a01759

["tests/bugs/declarePrecedenceWithClasses/DeclarePrecedenceTestClass.java", "weaver/src/org/aspectj/weaver/patterns/DeclarePrecedence.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 52928 Private members introduced via an interface are visible to the class

If private members are introduced via an interface to classes, the introduced members are visible inside the classes themselves, although the visibility is supposed to be relative to the aspect. Here's a sample: public class Sample { public static void main(String[] args) { Sample s = new Sample(); s.aMethod(); } public void aMethod() { // x is introduced by the following aspect as private // so it should not be accessible here System.out.println("I have " + x); } } aspect SampleAspect { private interface Tag {}; private int Tag.x = 0; declare parents: Sample implements Tag; }

resolved fixed

5795b4a

["tests/bugs/VisiblePrivateInterfaceITDs.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 55134 Incremental compilation does not delete weaver-generated class files

During incremental compilation, AjState records classes generated from source files following the initial compile phase, but before weaving. (So that these can be passed to the weaver on a subsequent iteration if we need to reweave the world). During weaving of a given class file, the weaver may generate additional class files (for e.g. around closures) that get written to the output. If the orginal source file is deleted, these additional weaver generated classes are not deleted from the output since AjState does not know about them.

resolved fixed

7d6b500

["tests/incremental/initialTests/classWAroundClosureRemoved/AdviceOnIntroduced.delete.20.java", "tests/incremental/initialTests/classWAroundClosureRemoved/AdviceOnIntroduced.java", "tests/incremental/initialTests/classWAroundClosureRemoved/Main.java", "weaver/src/org/aspectj/weaver/bcel/UnwovenClassFile.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 40192 build cancel during weaving

The build can not be cancelled during the bytecode weaving stage.

resolved fixed

183fc23

["ajde/src/org/aspectj/ajde/internal/BuildNotifierAdapter.java", "ajde/testdata/BuildCancelling/Cl1.java", "ajde/testdata/BuildCancelling/Cl2.java", "ajde/testdata/BuildCancelling/Cl3.java", "ajde/testdata/BuildCancelling/HW.java", "ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/BuildCancellingTest.java", "bridge/src/org/aspectj/bridge/IProgressListener.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/AjCompilerAdapter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/WeaverAdapter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 47910 ajc -outjar jarfile does not contain MANIFEST.MF

I call ajc -sourceroots <mydir> -outjar <my.jar> and an output file is created with a .jar extension, but it is not a valid jar file because there is no MANIFEST.MF file. I see that the text for ajc says: -outjar <file> put output classes in zip file <file> which might imply that it is supposed to be a zip file, but a parameter called - outjar which creates a zip file doesn't really make sense. If -outjar is used, the resulting file should be a valid jar file, i.e. with a META-INF/MANIFEST.MF file inside.

resolved fixed

34dbb0c

["ajde/testdata/JarManifestTest/src/Main.java", "ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/InpathTestcase.java", "ajde/testsrc/org/aspectj/ajde/JarManifestTest.java", "ajde/testsrc/org/aspectj/ajde/ResourceCopyTestCase.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 54625 Incremental support does not work with outjar

Either fix the class file deleting etc. to work with jars, or always do a batch build when working with outjars.

resolved fixed

1a4c02c

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjState.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 54965 Incremental compilation does twice as much work as necessary

When I added support for -outjar in the test harness, I was surprised to find duplicate entry exceptions coming from the output file writing to the outjar. I traced it through, and found that every source file passed to an incremental compile is in fact compiled twice! The first time round we note the references, and of course each file has a reference to itself. Then we call "AjState.getFilesToCompile" looking to see if there are any further files to compile in another iteration. This method does not remember the set of files it just compiled, so since we have referenced each type we just compiled, and we have no reord of that fact, we compile them again. Second time around, the bytecodes are identical to the previous go, so recordClassFile doesn't note their dependents - and thus this time we terminate.

resolved fixed

41c6f6d

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjState.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 51322 Introduce Unknown Type to class causes Null pointer exception

resolved fixed

5c67166

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeMethodDeclaration.java", "tests/bugs/Pr51322.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 44272 retitle warning to "circular {advice} dependency at ..."

When writing aspects with cycles in the advice precedence, get warning "circular dependency at {join point}" -- should be "circular advice dependency..." or "circular advice precedences at {join point} -- reorder the advice in the aspect". FWIW, here's an example of circularity in advice precedence: ---- aspect A { pointcut crun() : execution (void run()) ; before() : crun() {} after() returning : crun() {} void around() : crun() { proceed(); } } ---- See programming guide for more discussion of circularity in advice precedence.

resolved fixed

0109534

["tests/bugs/CircularAdvicePrecedence.java", "weaver/src/org/aspectj/weaver/Shadow.java", "weaver/src/org/aspectj/weaver/patterns/DeclarePrecedence.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 50776 fail in compiling aspect with overriding method introduction with different throws clause

A first class (class A) declares only one method with some exceptions in the throws clause ( void m() throws Exception ). A second class (class B) extends it without redefinig the method. An aspect declares a method introduction in the class B, with the same name, signature and return type of the one in class A, but without throws clause; this is a legal override. In the second class (class B) each invocation to the overriden method doesn't need a try-catch block, because it refers to his hown method that raises no exception. This code compiles using ajc version 1.0.6 (built Jul 24, 2002 6:21 PM PST) running on java 1.4.0 But not using AspectJ Compiler 1.1.1 AspectJ Compiler 1.1.0 class A{ public A(){} public void m() throws Exception{} } class B extends A{ public B(){} public void some_code(){ m();} } aspect C{ public void B.m(){} }

resolved fixed

c798923

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InterTypeMemberFinder.java", "tests/bugs/IntertypeDifferentThrows.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 52394 inter-type declarations cause JRockit Crash

resolved fixed

5d73494

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectClinit.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 51320 ClasscastException on concretization of if(false)

I get the following exception when weaving the attached aspect on the dev build. java.lang.ClassCastException at org.aspectj.weaver.patterns.IfPointcut.concretize1(IfPointcut.java:156) at org.aspectj.weaver.patterns.IfPointcut.concretize(IfPointcut.java:143) at org.aspectj.weaver.patterns.Pointcut.concretize(Pointcut.java:119) at org.aspectj.weaver.Checker.concretize(Checker.java:35) at org.aspectj.weaver.CrosscuttingMembers. addShadowMunger(CrosscuttingMembers.java:78) at org.aspectj.weaver.CrosscuttingMembers.addDeclare(CrosscuttingMembers. java:102) at org.aspectj.weaver.CrosscuttingMembers.addDeclares(CrosscuttingMembers. java:92) at org.aspectj.weaver.CrosscuttingMembersSet. addAdviceLikeDeclares(CrosscuttingMembersSet.java:65) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment. addAdviceLikeDeclares(AjLookupEnvironment.java:147) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment. completeTypeBindings(AjLookupEnvironment.java:122) at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java: 300) at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:314) at org.aspectj.ajdt.internal.core.builder.AjBuildManager. performCompilation(AjBuildManager.java:384) at org.aspectj.ajdt.internal.core.builder.AjBuildManager. doBuild(AjBuildManager.java:125) at org.aspectj.ajdt.internal.core.builder.AjBuildManager. batchBuild(AjBuildManager.java:70) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:104) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:53) at org.aspectj.tools.ajc.Main.run(Main.java:234) at org.aspectj.tools.ajc.Main.runMain(Main.java:170) at org.aspectj.tools.ajc.Main.main(Main.java:81)

resolved fixed

fbc0aa3

["tests/bugs/DecwClassCastException.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java", "weaver/src/org/aspectj/weaver/patterns/CflowPointcut.java", "weaver/src/org/aspectj/weaver/patterns/IfPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 36430 Support -Xreweavable option

resolved fixed

16a0abd

["ajde/testdata/ReweavableTest/CalculatePI.java", "ajde/testdata/ReweavableTest/tjp/Demo.java", "ajde/testdata/ReweavableTest/tjp/GetInfo.java", "ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/ReweavableTestCase.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildConfig.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "taskdefs/src/org/aspectj/tools/ant/taskdefs/AjcTask.java", "testing/src/org/aspectj/testing/harness/bridge/CompilerRun.java", "weaver/src/org/aspectj/weaver/Advice.java", "weaver/src/org/aspectj/weaver/CrosscuttingMembers.java", "weaver/src/org/aspectj/weaver/CrosscuttingMembersSet.java", "weaver/src/org/aspectj/weaver/Shadow.java", "weaver/src/org/aspectj/weaver/WeaverStateInfo.java", "weaver/src/org/aspectj/weaver/bcel/BcelCflowStackFieldAdder.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java", "weaver/src/org/aspectj/weaver/patterns/CflowPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 51929 Advice calling protected super method causing java.lang.VerifyError 'Bad access to protected data'

A java.lang.VerifyError is thrown at runtime complaining about 'Bad access to protected data' when advice, on a sub-aspect, that calls a protected method, on the super-aspect, is woven into a class. However another call to the same method woven into the same class but due to advice declared in the super-aspect works fine. The aspects were woven into precompiled (by sun's 1.4 javac) classes. The verify error occurs under both sun's 1.4 and blackdowns 1.3 VMs, and presumably all VMs. Workaround: Making the protected method public fixes the verify error. A test case is available in CVS: tests/bugs/protectedvf/... tests/ajcTestFailing.xml

resolved fixed

6ddae42

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AccessForInlineVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InlineAccessFieldBinding.java", "tests/bugs/protectedvf/main/Driver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 45489 Structure model is wrong when re-opened

Some elements have the wrong kinds when a saved structure model is loaded. E.g. if I close then re-open the eclipse workbench classes are shown as interface in the outline view. Also if I traverse the tree with the code below I get the wrong kinds assigned to classed, interfaces, aspects and import declarations. List list = StructureModelUtil.getPackagesInModel(); for(Iterator i = list.iterator(); i.hasNext();){ Object[] o = (Object[])i.next(); IProgramElement node = (IProgramElement)o[0]; List files = StructureModelUtil.getFilesInPackage(node); for(Iterator i2 = files.iterator(); i2.hasNext();){ IProgramElement file = (IProgramElement)i2.next (); System.out.println("file " + file.getKind ().toString() + ", " + file.getName()); boolean added2 = false; List file_children = file.getChildren(); // file children can be classes, aspects or other things for(Iterator i3 = file_children.iterator(); i3.hasNext();){ IProgramElement file_child = (IProgramElement)i3.next(); System.out.println("kind: " + file_child.getKind().toString() +", " + file_child.getName());

resolved fixed

669cd7c

["ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/SavedModelConsistencyTest.java", "asm/src/org/aspectj/asm/IProgramElement.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 50570 CatchClauseSignature has broken operation

It looks like the getParameterName() operation on org.aspectj.lang.reflect. CatchClauseSignature is not working. Instead of returning the name of the exception as declared in the matched handler, returns the string value "<missing>". Here is a test case that shows the problem :- ------START OF TEST CASE CODE----------- public class MyApp { public void doSomething() { // Get around "unreachable code error... if (true) { throw new BusinessException("Surprise!!"); } System.out.println("Busy doing something."); } public static void main(String[] args) { try { MyApp m = new MyApp(); m.doSomething(); } catch (BusinessException be) { System.out.println("Exception caught : " + be.getMessage()); } } } class BusinessException extends RuntimeException { BusinessException(String message) { super(message); } } aspect AppMonitor { pointcut problemHandling() : handler(Throwable+); before() : problemHandling() { CatchClauseSignature cSig = (CatchClauseSignature) thisJoinPointStaticPart.getSignature(); System.out.println( "MONITOR::\tCaught a " + cSig.getParameterType().getName() + " called " + cSig.getParameterName()); } } ------END OF TEST CASE CODE----------- The output from running the above was ... MONITOR:: Caught a BusinessException called <missing> Exception caught : Surprise !!!! Operating system : Windows XP AspectJ : 1.1.1 final and also on latest from CVS HEAD

resolved fixed

19bac86

["tests/bugs/HandlerSig.java", "weaver/src/org/aspectj/weaver/Member.java", "weaver/src/org/aspectj/weaver/ResolvedMember.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 48091 Lazy instantiation of thisJoinPoint

In cases where the body of advice refers to a non-statically evaluable portion of thisJoinPoint (so that it can't be optimized by the compiler to thisJoinPointStaticPart), the JoinPoint object is currently always created before entering the advice body - even if the JoinPoint object would never actually be accessed (because of a test within the advice for example). Since a) thisJoinPoint is often used in tracing applications b) tracing applications tend to be very pervasive, c) they must have low overhead when tracing is disabled, and d) creation of thisJoinPoint objects is expensive (v. expensive compared to just testing a flag) it would be nice if there was a way to create JoinPoint objects lazily on first actual reference within the advice body.

resolved fixed

0c83343

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildConfig.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/AjdtBatchTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/CommandTestCase.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/PerformanceTestCase.java", "runtime/src/org/aspectj/runtime/reflect/Factory.java", "weaver/src/org/aspectj/weaver/Lint.java", "weaver/src/org/aspectj/weaver/World.java", "weaver/src/org/aspectj/weaver/bcel/BcelAdvice.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 48072 Complete relationship information in the structure model

Complete the set of relationships surfaced by the structure model (e.g. including support for declare parents etc.) - Mik you had a document listing the things yet to be done here?

resolved fixed

f24286d

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "weaver/src/org/aspectj/weaver/Checker.java", "weaver/src/org/aspectj/weaver/ICrossReferenceHandler.java", "weaver/src/org/aspectj/weaver/Shadow.java", "weaver/src/org/aspectj/weaver/World.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 50200 aspectjrt.jar manifest file name needs changing to upper case

resolved fixed

6f099df

["build/src/org/aspectj/internal/tools/ant/taskdefs/AntBuilder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 42515 NPE When compiling intertype declaration

resolved fixed

6d2abc1

["tests/bugs/caseSensitivity/uniqueId/Numbered.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 36234 out of memory error when compiling

Getting an out of memory error when compiling with Ajc 1.1 RC1. I know this is not very descriptive, but maybe you can point me into a direction of getting more output. here some additional information though: Code base is medium size (about 1500 classfiles) I removed all my aspects and still receive the error. Running it from the command line: ajc -classpath whateveritis -sourceroots whateveritis -d whateveritis

resolved fixed

b3b1eec

["org.aspectj.ajdt.core/src/org/aspectj/tools/ajc/Main.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 47952 SoftException.printStackTrace(..) should print wrapped throwable too

SoftExceptions should print not only their trace but also that of the wrapped throwable. We should be able to set a flag on class initialization whether we are running under 1.4 and then implement it under 1.4 using initCause() and otherwise by direct delegation. I can do this fix if we're agreed.

resolved fixed

ad2fb7a

["runtime/src/org/aspectj/lang/SoftException.java", "runtime/testsrc/RuntimeModuleTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 38824 Anomalous handling of inter-type declarations to abstract base classes in aspectj 1.1

Version 1.1 of aspectj does not handle correctly inter-type declarations to abstract base classes. This appears when the following pattern is present in the code: Suppose there is an interface InterfaceA, another interface InterfaceB and a third interface InterfaceC extending InterfaceA and InterfaceB and containing some method declarations of its own. Suppose also there is an aspect AConcretisingAspect that contains inter-type declarations providing default implementations for all InterfaceC's methods (both own and inherited). Now suppose we have a class hierarchy emanating from an abstract class BaseClass, and an aspect BaseClassAspect declaring that BaseClass implements InterfaceC: aspect BaseClassAspect { declare parents: BaseClass implements InterfaceC; } Unfortunately, during compilation iajc complains for each offspring of BaseClass that it does not implement any of the abstract methods of InterfaceA and InterfaceB (but not of InterfaceC's own!). This does not happen when BaseClass is not abstract; and it does not occur in version 1.0.6 of aspectj.

resolved fixed

0071cb4

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/bugs/AbstractBaseAndInterTypeInterface.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 44587 Erroneous exception conversion

resolved fixed

5834de9

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectClinit.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java", "runtime/src/org/aspectj/lang/NoAspectBoundException.java", "runtime/testsrc/RuntimeModuleTests.java", "tests/bugs/ErroneousExceptionConversion.java", "tests/bugs/ErroneousExceptionConversion1.java", "tests/new/ConstructorExecInitFails.java", "weaver/src/org/aspectj/weaver/AjcMemberMaker.java", "weaver/src/org/aspectj/weaver/NameMangler.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 46280 compiler issues error on inner aspects when privilieged

The compiler complains that "inner aspects must be static" whenever I try to qualify an inner (and static) aspect as privileged, no matter what the enclosing type is (aspect, interface or class). I was using j2sdk1.4.0_02, AspectJ 1.1, eclipse 2.1 (with AJDT 1.1.3). Test case: ------------------ BASE CLASS: public class Capsule { private int hidden; public int visible; public Capsule(int priv, int pub) { hidden = priv; visible = pub; } public void doSomething() { System.out.println(""" + hidden + ", " + visible + """); } public static void main(String[] args) { Capsule capsule = new Capsule(1, 1); capsule.doSomething(); } } ------------------ ASPECT: public aspect Outer { static //privileged <== JUST TRY TO UNCOMMENT THIS! aspect Inner { pointcut call2doSomething(Capsule capsule): call(void Capsule.doSomething()) && target(capsule); before(Capsule capsule): call2doSomething(capsule) { capsule.visible++; //capsule.hidden++; } } } ------------------ INTERFACE: public interface Marker { static //privileged <== JUST TRY TO UNCOMMENT THIS! aspect Inner { pointcut call2doSomething(Capsule capsule): call(void Capsule.doSomething()) && target(capsule); before(Capsule capsule): call2doSomething(capsule) { capsule.visible++; //capsule.hidden++; } } }

resolved fixed

7bbd1f4

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/parser/AjParser.java", "tests/bugs/PrivilegedParsing.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 44586 After throwing advice on ctors doesn't execute for inter-type decls

The following code doesn't work in Ajc 1.1.1, in Ajc built from CVS HEAD (as of yesterday), nor in Ajc 1.0.6: Output: C:\devel\test\excHandling>java AfterThrowingCtor Exception in thread "main" java.lang.IllegalStateException: crash at Foo.initVal(AfterThrowingCtor.java:21) at AfterThrowingCtor.ajc$interFieldInit$AfterThrowingCtor$Foo$val (AfterT hrowingCtor.java:9) at Foo.<init>(AfterThrowingCtor.java:13) at AfterThrowingCtor.main(AfterThrowingCtor.java:6) Correct Output: threw java.lang.IllegalStateException: crash at execution(Foo()) Exception in thread "main" java.lang.IllegalStateException: crash at Foo.initVal(AfterThrowingCtor.java:21) at AfterThrowingCtor.ajc$interFieldInit$AfterThrowingCtor$Foo$val (AfterT hrowingCtor.java:9) at Foo.<init>(AfterThrowingCtor.java:13) at AfterThrowingCtor.main(AfterThrowingCtor.java:6) Input source: public aspect AfterThrowingCtor { after() throwing (Throwable t) : execution(Foo.new(..)) { System.err.println("threw "+t+" at "+thisJoinPointStaticPart); } public static void main(String args[]) { new Foo(); } private Object Foo.val = Foo.initVal(); } class Foo { Foo() { } // if you uncomment this line and comment out the inter-type decl. // the advice runs correctly //private Object val = initVal(); static Object initVal() { throw new IllegalStateException("crash"); } } --- AspectJ 1.1.1 runs the after throwing advice correctly if the field is declared normally (AspectJ 1.0.6 fails to do even this).

resolved fixed

87db1e7

["tests/bugs/AfterThrowingCtor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 49814 ConfigParser.java:132

resolved fixed

a4a1234

["org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/ajc/BuildArgParserTestCase.java", "util/src/org/aspectj/util/ConfigParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 49638 exception logging: after() throwing advice can't convert Throwable obj to string and ajc aborts

resolved fixed

7b081f2

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/parser/AjParser.java", "tests/bugs/AfterThrowingAdviceSyntaxError.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 41952 XLint warning for call PCD's using subtype of defining type

resolved fixed

97ab1e9

["bridge/src/org/aspectj/bridge/IMessage.java", "bridge/src/org/aspectj/bridge/Message.java", "bridge/src/org/aspectj/bridge/MessageUtil.java", "bridge/src/org/aspectj/bridge/SourceLocation.java", "org.aspectj.ajdt.core/src/org/aspectj/tools/ajc/Main.java", "testing/src/org/aspectj/testing/xml/SoftMessage.java", "tests/bugs/DeclaringTypeWarning.java", "tests/new/CallTypesI.java", "tests/new/IndeterminateArg.java", "tests/new/IndeterminateArgType.java", "weaver/src/org/aspectj/weaver/Checker.java", "weaver/src/org/aspectj/weaver/Lint.java", "weaver/src/org/aspectj/weaver/patterns/AndPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ExactTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/KindedPointcut.java", "weaver/src/org/aspectj/weaver/patterns/NotPointcut.java", "weaver/src/org/aspectj/weaver/patterns/OrPointcut.java", "weaver/src/org/aspectj/weaver/patterns/Pointcut.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java", "weaver/src/org/aspectj/weaver/patterns/SignaturePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 47754 illegal method modifier

the attached example throws this at class load time. please note that this bug results in a different exception when happens in a different setup, and when the class is loaded by JBoss. (more cryptic, talking about generic class format error) Exception in thread "main" java.lang.ClassFormatError: com/netvisor/nvsr/client/InvalidByteCodeBug$Test$ITest (Illegal method modifiers: 0x409) at java.lang.ClassLoader.defineClass0(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:537) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java: 123) at java.net.URLClassLoader.defineClass(URLClassLoader.java:251) at java.net.URLClassLoader.access$100(URLClassLoader.java:55) at java.net.URLClassLoader$1.run(URLClassLoader.java:194) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:187) at java.lang.ClassLoader.loadClass(ClassLoader.java:289) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:274) at java.lang.ClassLoader.loadClass(ClassLoader.java:235) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:302) at java.lang.ClassLoader.defineClass0(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:537) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java: 123) at java.net.URLClassLoader.defineClass(URLClassLoader.java:251) at java.net.URLClassLoader.access$100(URLClassLoader.java:55) at java.net.URLClassLoader$1.run(URLClassLoader.java:194) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:187) at java.lang.ClassLoader.loadClass(ClassLoader.java:289) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:274) at java.lang.ClassLoader.loadClass(ClassLoader.java:235) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:302) at com.netvisor.nvsr.client.InvalidByteCodeBug.run(InvalidByteCodeBug. java:15) at com.netvisor.nvsr.client.InvalidByteCodeBug.main(InvalidByteCodeBug. java:8)

resolved fixed

7322131

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeMethodDeclaration.java", "tests/bugs/StaticInterfaceMethods.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 49250 alias getCause for getWrappedThrowable in SoftException

SoftException should implement getCause(): public Throwable getCause() { return inner; } (As pointed out by Ramnivas, misc mail messages, code comments...) Using getCause() means the chain should print as expected in 1.4+, esp. when SoftException is itself wrapped as a RemoteException. Since getCause() replicates getWrappedThrowable(), we could deprecate that, but we must continue to support it to maintain upwards binary compatibility in the runtime classes.

resolved fixed

eac16ae

["runtime/src/org/aspectj/lang/SoftException.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 49457 No error on overloaded pointcuts unless binding variables

The compiler might not be detecting overloaded pointcut names when parameters are not bound, and/or might not be implementing the pointcut correctly. Below is the context from my reply to Ron Bodkin on aspectj-dev "Proper behavior of overloaded pointcut definitions". (I have not checked this code recently or submitted a test case, nor have I evaluated whether my code below actually replicates Ron's bug.) ---- context from the email The programming guide says, It is an error for two pointcuts to be named with the same name in the same class or aspect declaration. When I compile with overloaded pointcut names, I do get an error. pointcut pc(Runnable r) : target(r) && call(void run()); pointcut pc(SubRunnable r) : target(r) && call(void run()); $ aspectj-1.1.1 -classpath $ajrt11 OverloadedPointcut.java ...\OverloadedPointcut.java:14 duplicate pointcut name: pc ...\OverloadedPointcut.java:15 duplicate pointcut name: pc ... When I use these pointcuts with bound parameters, I get an error. before(Runnable r) : pc(r) { log("pc(Runnable r)"); } before(SubRunnable r) : pc(r) { log("pc(SubRunnable r)"); } When I use these pointcuts with type parameters, I get no errors. before() : pc(Runnable) { log("pc(Runnable)"); } before() : pc(SubRunnable) { log("pc(SubRunnable)"); } before() : pc(*) { log("pc(*)"); } [...] ---- my code public class OverloadedPointcut { public static void main(String[] args) { new C().run(); } } class C { public void run() {} } aspect A { declare parents: C implements Runnable; declare parents: C implements SubRunnable; interface SubRunnable extends Runnable {} pointcut pc(Runnable r) : target(r) && call(void run()); pointcut pc(SubRunnable r) : target(r) && call(void run()); before(Runnable r) : pc(r) { log("pc(Runnable r)"); } before(SubRunnable r) : pc(r) { log("pc(SubRunnable r)"); } before() : pc(Runnable) { log("pc(Runnable)"); } before() : pc(SubRunnable) { log("pc(SubRunnable)"); } before() : pc(*) { log("pc(*)"); } void log(String s) { System.out.println(s); } } ---- Ron's code [...] the following program compiles with no warnings, produces no output when run under AspectJ 1.1.1. It appears to behave as if the more specific definition is the only definition of the pointcut [...] Here is a simple program that illustrates the question and odd behavior: package lib; public class RunnablePointcuts { public pointcut runnableCalls(Runnable runnable, Object caller) : call(* run(..)) && target(runnable) && this(caller); //public pointcut specialRunnableCalls(SpecialRunnable runnable, Object caller) : public pointcut runnableCalls(SpecialRunnable runnable, Object caller) : call(* run(..)) && target(runnable) && this(caller); } --- package lib; public interface SpecialRunnable extends Runnable { } --- package client; import lib.RunnablePointcuts; import lib.SpecialRunnable; public aspect Use { before(Object caller) : RunnablePointcuts.runnableCalls(*, caller) && target(MyRunnable) { System.out.println("my runnable called from "+caller); } public static void main(String args[]) { Use.aspectOf().doIt(); } public void doIt() { new MyRunnable().run(); } } // the advice will run if you make this implement SpecialRunnable //class MyRunnable implements SpecialRunnable { class MyRunnable implements Runnable { public void run() {} }

resolved fixed

c517e85

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java", "tests/bugs/OverloadedPointcutsInAspect.java", "tests/bugs/OverloadedPointcutsInClass.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 47318 org.aspectj.asm.IRelationship.Kind.ALL does not contain all kinds

org.aspectj.asm.IRelationship.Kind.ALL is an array that should contain all kinds that an IRelationship may have. There are three possible kinds defined in IRelationship.java: ADVICE, DECLARE and DECLARE_INTER_TYPE. The Kind[] ALL does only contain ADVICE and DECLARE. This can lead to an ArrayIndexOutOfBoundsException.

resolved fixed

bdc79f1

["asm/src/org/aspectj/asm/IRelationship.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 43783 AJDT not very stable when confronted with java/aspect errors.

AJDT is not very stable when an eclipse project contains errors like missing classes, wrong package statements etc. etc. This may occurs when refactoring a project (sometimes by changing the source outside eclipse). Note I am using Eclipse 2.1.1, AJDT 1.1.4 + incremental compilation. Generally a lot of exceptions will occur (mostly nullpointer). Here are some of them: I: java.lang.NullPointerException at org.aspectj.asm.internal.ProgramElement.toLinkLabelString (ProgramElement.java:403) at org.eclipse.ajdt.internal.core.AJDTStructureViewNode.getLabel (AJDTStructureViewNode.java:171) at org.eclipse.ajdt.internal.core.AJDTStructureViewNodeAdapter.getLabel (AJDTStructureViewNodeAdapter.java:89) at org.eclipse.ui.model.WorkbenchLabelProvider.getText (WorkbenchLabelProvider.java:142) II: java.lang.NullPointerException at org.eclipse.ajdt.internal.ui.editor.AspectJEditor$1.run (AspectJEditor.java:242) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) III: java.lang.NullPointerException at org.aspectj.ajde.internal.CompilerAdapter.compile (CompilerAdapter.java:79) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:165) !

resolved fixed

3e4b59a

["ajde/src/org/aspectj/ajde/internal/CompilerAdapter.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 44117 NPE on compile

java.lang.NullPointerException at org.aspectj.weaver.AsmRelationshipProvider.checkerMunger (AsmRelationshipProvider.java:51) at org.aspectj.weaver.Checker.match(Checker.java:58) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:985) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:791) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:291) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:77) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:417) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:390) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:316) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.weaveAndGenerateClassFile s(AjBuildManager.java:256) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild (AjBuildManager.java:156) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (AjBuildManager.java:70) at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:103) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:165)

resolved fixed

3117255

["weaver/src/org/aspectj/weaver/AsmRelationshipProvider.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 43709 structure view crash when extending library aspects

I have an library with an aspect that includes advice, which I compile into an outjar. In my client project I extend it, and make a concrete pointcut that results in the library aspect affecting parts of my system. There is a bug and an enhancement request here: 1) A bug: when you look at the structure view for affected classes, there is a problem if you try to navigate from calls to advice (in AJDT, it results in an NPE). Here is the stack trace in AJDT: java.lang.NullPointerException at org.aspectj.asm.internal.ProgramElement.toLinkLabelString (ProgramElement.java:403) at org.eclipse.ajdt.internal.core.AJDTStructureViewNode.getLabel (AJDTStructureViewNode.java:171) at org.eclipse.ajdt.internal.core.AJDTStructureViewNodeAdapter.getLabel (AJDTStructureViewNodeAdapter.java:89) at org.eclipse.ui.model.WorkbenchLabelProvider.getText (WorkbenchLabelProvider.java:142) at org.eclipse.jface.viewers.TreeViewer.doUpdateItem(TreeViewer.java:95) at org.eclipse.jface.viewers.AbstractTreeViewer$UpdateItemSafeRunnable.run (AbstractTreeViewer.java:87) at org.eclipse.core.internal.runtime.InternalPlatform.run (InternalPlatform.java:1006) at org.eclipse.core.runtime.Platform.run(Platform.java:413) at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem (AbstractTreeViewer.java:406) at org.eclipse.jface.viewers.StructuredViewer$UpdateItemSafeRunnable.run (StructuredViewer.java:119) at org.eclipse.core.internal.runtime.InternalPlatform.run (InternalPlatform.java:1006) at org.eclipse.core.runtime.Platform.run(Platform.java:413) at org.eclipse.jface.viewers.StructuredViewer.updateItem (StructuredViewer.java:1271) at org.eclipse.jface.viewers.AbstractTreeViewer.createTreeItem (AbstractTreeViewer.java:320) at org.eclipse.jface.viewers.AbstractTreeViewer$1.run (AbstractTreeViewer.java:303) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren (AbstractTreeViewer.java:289) at org.eclipse.jface.viewers.AbstractTreeViewer.handleTreeExpand (AbstractTreeViewer.java:697) at org.eclipse.jface.viewers.AbstractTreeViewer$4.treeExpanded (AbstractTreeViewer.java:709) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:175) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:81) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:840) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:865) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:849) at org.eclipse.swt.widgets.Tree.wmNotifyChild(Tree.java:1909) at org.eclipse.swt.widgets.Control.WM_NOTIFY(Control.java:3815) at org.eclipse.swt.widgets.Composite.WM_NOTIFY(Composite.java:642) at org.eclipse.swt.widgets.Control.windowProc(Control.java:2816) at org.eclipse.swt.widgets.Display.windowProc(Display.java:2361) at org.eclipse.swt.internal.win32.OS.CallWindowProcW(Native Method) at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:1236) at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:156) at org.eclipse.swt.widgets.Tree.WM_LBUTTONDOWN(Tree.java:1517) at org.eclipse.swt.widgets.Control.windowProc(Control.java:2799) at org.eclipse.swt.widgets.Display.windowProc(Display.java:2361) at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method) at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:1303) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1543) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1402) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1385) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:858) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:461) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.core.launcher.Main.basicRun(Main.java:291) at org.eclipse.core.launcher.Main.run(Main.java:747) at org.eclipse.core.launcher.Main.main(Main.java:583) 2) The enhancement request: the concrete aspect that applies the advice should also show what is affected in the project. Of course, it would also be nice to see how a given concrete library aspect in the aspect path affects your project too.

resolved fixed

426d89b

["asm/src/org/aspectj/asm/internal/ProgramElement.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 43033 Compiler crash in ajc head (post 1.1.1 rc1) on erroneous program

resolved fixed

5357086

["tests/bugs/concretizeNpe/base/ExceptionHandling.java", "tests/bugs/concretizeNpe/model/ModelExceptionHandling.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 43194 java.lang.VerifyError in generated code

See the attached file VerifyBug.jar for the source files. You won't need anything else to compiler and reproduce this bug: ~/bug> ls AbstractCaching.java TreeNode.java VerifyBug.jar ContainerCaching.java TreeNodeFolding.java WorkspaceGroup.java ContainerLoader.java TreePanel.java WorkspaceNode.java Makefile TreeWorkspace.java ~/bug> gmake /cygdrive/c/aspectj1.1.1/bin/ajc -classpath "C:\aspectj1.1.1 \lib\aspectjrt.jar" -version AspectJ Compiler 1.1.1 /cygdrive/c/aspectj1.1.1/bin/ajc -classpath "C:\aspectj1.1.1\lib\aspectjrt.jar" *.java java -classpath "C:\aspectj1.1.1\lib\aspectjrt.jar;." TreeNode java.lang.VerifyError: (class: TreeNode, method: doShowAction signature: ()V) Unable to pop operand off an empty stack Exception in thread "main" make: *** [all] Error 1

resolved fixed

fc0d2af

["tests/bugs/AdviceInteraction.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 42993 Language regression, or possible language improvement?

The file AspectBug.java: public aspect AspectBug extends AbstractCaching perthis(execution(ContainerLoader+.new(..))) { declare parents: ContainerDescriptor implements AbstractCaching.Key; protected pointcut loadExecutions( Key key ): ContainerLoader.containerLoads( *, key ); } abstract aspect AbstractCaching { interface Key {} protected abstract pointcut loadExecutions(Key key); } class Key { } class ContainerDescriptor { } class ActiveContainer { } class ContainerLoader { public ActiveContainer createContainer(ContainerDescriptor c) { return null; } public pointcut containerLoads(ContainerLoader loader, ContainerDescriptor containerDesc ): this(loader) && args(containerDesc) && execution(ActiveContainer ContainerLoader.createContainer (ContainerDescriptor)); } First, here are the versions of AspectJ I'm using (this is a bash shell under cygwin on Windows XP): ~> CLASSPATH='C:\aspectj1.0\lib\aspectjrt.jar' /cygdrive/c/aspectj1.0/bin/ajc - version ajc version 1.0.6 (built Jul 24, 2002 6:21 PM PST) running on java 1.4.1_02 ~> CLASSPATH='C:\aspectj1.1\lib\aspectjrt.jar' /cygdrive/c/aspectj1.1/bin/ajc - version AspectJ Compiler 1.1.0 ~> CLASSPATH='C:\aspectj1.1.1rc1 \lib\aspectjrt.jar' /cygdrive/c/aspectj1.1.1rc1/bin/ajc -version AspectJ Compiler 1.1.1rc1 ~> CLASSPATH='C:\aspectj1.1.1 \lib\aspectjrt.jar' /cygdrive/c/aspectj1.1.1/bin/ajc -version AspectJ Compiler 1.1.1 For all four of these compilers, I give them the AspectBug.java file (which is attached): ~> CLASSPATH='C:\aspectj1.0\lib\aspectjrt.jar' /cygdrive/c/aspectj1.0/bin/ajc AspectBug.java ~> CLASSPATH='C:\aspectj1.1\lib\aspectjrt.jar' /cygdrive/c/aspectj1.1/bin/ajc AspectBug.java ~> CLASSPATH='C:\aspectj1.1.1rc1 \lib\aspectjrt.jar' /cygdrive/c/aspectj1.1.1rc1/bin/ajc AspectBug.java ~> CLASSPATH='C:\aspectj1.1.1 \lib\aspectjrt.jar' /cygdrive/c/aspectj1.1.1/bin/ajc AspectBug.java C:\Documents and Settings\Macneil Shonle\AspectBug.java:7 incompatible type, expected ContainerDescriptor found BindingTypePattern(AbstractCaching$Key, 0) 1 error As you can see, only the final run (with the Sept 11 build of ajc) do we see the "incompatible type" error. If this is not a regression but a desirable result, how should the code be ported?

resolved fixed

b512738

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java", "tests/bugs/ParentsAndPointcuts.java", "weaver/src/org/aspectj/weaver/CrosscuttingMembersSet.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 42740 declare error fails on pointcuts composed from multiple classes

This error occurs in both 1.1.0 and in the head of CVS as of 9/8/03. The compiler crash output from the CVS head version is at the end. It may be related to 42739, but they may be distinct problems. Sample source: /* * Created on Sep 8, 2003 * * Copyright (c) 2003 New Aspects of Security. All Rights Reserved. */ aspect Library { public pointcut executionsThrowingChecked() : execution(* *(..) throws (Exception+ && !RuntimeException)); } public aspect SampleExceptionHandling { public pointcut scope() : within(org.atrack.model..*); public pointcut executionsThrowingChecked() : Library.executionsThrowingChecked() && scope(); declare error : executionsThrowingChecked(): "no checked exceptions"; } sample compile: C:\eclipse\workspace\atrack>ajc src\SampleExceptionHandling.java java.lang.Exception: Stack trace at java.lang.Thread.dumpStack(Thread.java:1071) at org.aspectj.weaver.patterns.ReferencePointcut.concretize1 (ReferencePo intcut.java:215) at org.aspectj.weaver.patterns.AndPointcut.concretize1 (AndPointcut.java: 88) at org.aspectj.weaver.patterns.ReferencePointcut.concretize1 (ReferencePo intcut.java:272) at org.aspectj.weaver.patterns.AndPointcut.concretize1 (AndPointcut.java: 88) at org.aspectj.weaver.patterns.ReferencePointcut.concretize1 (ReferencePo intcut.java:272) at org.aspectj.weaver.patterns.Pointcut.concretize(Pointcut.java:127) at org.aspectj.weaver.patterns.Pointcut.concretize(Pointcut.java:120) at org.aspectj.weaver.Checker.concretize(Checker.java:37) at org.aspectj.weaver.CrosscuttingMembers.addShadowMunger (CrosscuttingMe mbers.java:78) at org.aspectj.weaver.CrosscuttingMembers.addDeclare (CrosscuttingMembers .java:102) at org.aspectj.weaver.CrosscuttingMembers.addDeclares (CrosscuttingMember s.java:92) at org.aspectj.weaver.ResolvedTypeX.collectCrosscuttingMembers (ResolvedT ypeX.java:332) at org.aspectj.weaver.CrosscuttingMembersSet.addOrReplaceAspect (Crosscut tingMembersSet.java:50) at org.aspectj.ajdt.internal.compiler.ast.AspectDeclaration.buildInterTy peAndPerClause(AspectDeclaration.java:754) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.buildIn terTypeAndPerClause(AjLookupEnvironment.java:124) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.complet eTypeBindings(AjLookupEnvironment.java:91) at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile (Compiler.ja va:310) at org.eclipse.jdt.internal.compiler.Compiler.compile (Compiler.java:324) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilat ion(AjBuildManager.java:373) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild (AjBuild Manager.java:125) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (AjBu ildManager.java:70) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:99) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:53) at org.aspectj.tools.ajc.Main.run(Main.java:217) at org.aspectj.tools.ajc.Main.runMain(Main.java:155) at org.aspectj.tools.ajc.Main.main(Main.java:72) C:\eclipse\workspace\atrack\src\SampleExceptionHandling.java:15 circular pointcu t declaration involving: executionsThrowingChecked() 1 error

resolved fixed

d78d9ed

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/PointcutDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java", "tests/bugs/declareBinding/SampleExceptionHandling1.java", "tests/bugs/declareSoftWithin/test/NoSoftener.java", "weaver/src/org/aspectj/weaver/ResolvedPointcutDefinition.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 42539 throw derivative pointcuts not advised.

Given the following point cut and advice: public aspect ExceptionAspect { pointcut exceptionThrower() : execution(public * ExceptionBugTest.*(..) throws Exception+); declare warning : exceptionThrower() : "throws Exception+"; } And the to be aspected code: public class ExceptionBugTest { class MyException extends Exception { } public void method1() throws Exception { } public void method2() throws MyException { } } listing file default.lst: C:\temp\AJC Bug\ExceptionAspect.aj C:\temp\AJC Bug\ExceptionBugTest.java AJC does not advise ExceptionBugTest.method2(). The output from the compilation is the following: C:\temp\AJC Bug>ajc -argfile default.lst -classpath %ASPECTJ_HOME%\lib\aspectjrt.jar C:\eclipse\workspace\AJC Bug\ExceptionBugTest.java:11 throws Exception+ From the aspect-j mailing list, contributed by Jim Hugunin: &lt;detail&gt;The bug was caused because the code for ThrowsPattern mistakenly used the internal protected method TypePattern.matchesExactly instead of the external public method TypePattern.matchesStatically. Because the classes were in the same package, Java's accessibility rules allowed this. It would be nice if there was an easy way to specifiy that a method could only be accessed from subtypes.&lt;/detail&gt;

resolved fixed

8660cc1

["tests/bugs/throwsSignature/ExceptionAspect.java", "tests/bugs/throwsSignature/ExceptionBugTest.java", "weaver/src/org/aspectj/weaver/patterns/ThrowsPattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 41359 percflow aspects compiled from jars share one instance for all entry points

When a percflow aspect is woven into source code from a jar using the aspectPath compiler option, it produces only one instance of the aspect for each entrypoint defined in the source code.

resolved fixed

5a07dce

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java", "tests/bugs/perCflowAndJar/PerCFlowCompileFromJar.java", "tests/bugs/perCflowAndJar/PerCFlowCompileFromJarTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 41888 call PCD fails when given subtype of defining type

resolved wontfix

9df9062

["tests/bugs/CallReference.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 39436 [Tasks] No summary shown in status line

build I20030625 The old tasks view showed a summary of the number of tasks, errors, warnings and infos in the status line. This is missing in the reworked view.

verified fixed

d90acdc

["weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 41254 revise asm and create interfaces

resolved fixed

f1deb9c

["ajbrowser/src/org/aspectj/tools/ajbrowser/BrowserManager.java", "ajbrowser/src/org/aspectj/tools/ajbrowser/TopFrame.java", "ajde/src/org/aspectj/ajde/internal/LstBuildConfigManager.java", "ajde/src/org/aspectj/ajde/ui/AbstractIconRegistry.java", "ajde/src/org/aspectj/ajde/ui/BuildConfigModel.java", "ajde/src/org/aspectj/ajde/ui/BuildConfigNode.java", "ajde/src/org/aspectj/ajde/ui/StructureModelUtil.java", "ajde/src/org/aspectj/ajde/ui/StructureSearchManager.java", "ajde/src/org/aspectj/ajde/ui/StructureView.java", "ajde/src/org/aspectj/ajde/ui/StructureViewManager.java", "ajde/src/org/aspectj/ajde/ui/StructureViewNode.java", "ajde/src/org/aspectj/ajde/ui/StructureViewNodeFactory.java", "ajde/src/org/aspectj/ajde/ui/StructureViewProperties.java", "ajde/src/org/aspectj/ajde/ui/internal/NavigationHistoryModel.java", "ajde/src/org/aspectj/ajde/ui/internal/TreeStructureViewBuilder.java", "ajde/src/org/aspectj/ajde/ui/swing/AjdeUIManager.java", "ajde/src/org/aspectj/ajde/ui/swing/BrowserStructureViewToolPanel.java", "ajde/src/org/aspectj/ajde/ui/swing/BrowserView.java", "ajde/src/org/aspectj/ajde/ui/swing/BrowserViewManager.java", "ajde/src/org/aspectj/ajde/ui/swing/BrowserViewTreeListener.java", "ajde/src/org/aspectj/ajde/ui/swing/BuildConfigPopupMenu.java", "ajde/src/org/aspectj/ajde/ui/swing/IconRegistry.java", "ajde/src/org/aspectj/ajde/ui/swing/PointcutWizard.java", "ajde/src/org/aspectj/ajde/ui/swing/SimpleStructureViewToolPanel.java", "ajde/src/org/aspectj/ajde/ui/swing/StructureTreeManager.java", "ajde/src/org/aspectj/ajde/ui/swing/StructureViewPanel.java", "ajde/src/org/aspectj/ajde/ui/swing/SwingTreeViewNode.java", "ajde/src/org/aspectj/ajde/ui/swing/SwingTreeViewNodeFactory.java", "ajde/src/org/aspectj/ajde/ui/swing/SwingTreeViewNodeRenderer.java", "ajde/src/org/aspectj/ajde/ui/swing/TreeViewBuildConfigEditor.java", "ajde/testdata/examples/coverage/ModelCoverage.java", "ajde/testdata/examples/coverage/pkg/InPackage.java", "ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/AsmDeclarationsTest.java", "ajde/testsrc/org/aspectj/ajde/AsmRelationshipsTest.java", "ajde/testsrc/org/aspectj/ajde/NullIdeErrorHandler.java", "ajde/testsrc/org/aspectj/ajde/NullIdeManager.java", "ajde/testsrc/org/aspectj/ajde/NullIdeProgressMonitor.java", "ajde/testsrc/org/aspectj/ajde/NullIdeTaskListManager.java", "ajde/testsrc/org/aspectj/ajde/NullIdeUIAdapter.java", "ajde/testsrc/org/aspectj/ajde/StructureModelRegressionTest.java", "ajde/testsrc/org/aspectj/ajde/StructureModelTest.java", "ajde/testsrc/org/aspectj/ajde/ui/StructureModelUtilTest.java", "ajde/testsrc/org/aspectj/ajde/ui/StructureSearchManagerTest.java", "ajde/testsrc/org/aspectj/ajde/ui/StructureViewManagerTest.java", "asm/src/org/aspectj/asm/AdviceAssociation.java", "asm/src/org/aspectj/asm/Association.java", "asm/src/org/aspectj/asm/HierarchyWalker.java", "asm/src/org/aspectj/asm/IProgramElement.java", "asm/src/org/aspectj/asm/IRelationship.java", "asm/src/org/aspectj/asm/IStructureModelListener.java", "asm/src/org/aspectj/asm/InheritanceAssociation.java", "asm/src/org/aspectj/asm/IntroductionAssociation.java", "asm/src/org/aspectj/asm/LinkNode.java", "asm/src/org/aspectj/asm/ModelWalker.java", "asm/src/org/aspectj/asm/ProgramElementNode.java", "asm/src/org/aspectj/asm/ReferenceAssociation.java", "asm/src/org/aspectj/asm/Relation.java", "asm/src/org/aspectj/asm/RelationNode.java", "asm/src/org/aspectj/asm/StructureModel.java", "asm/src/org/aspectj/asm/StructureModelListener.java", "asm/src/org/aspectj/asm/StructureModelManager.java", "asm/src/org/aspectj/asm/StructureNode.java", "asm/src/org/aspectj/asm/StructureNodeFactory.java", "asm/src/org/aspectj/asm/internal/ProgramElement.java", "asm/src/org/aspectj/asm/internal/Relationship.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmBuilder.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmHierarchyBuilder.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmNodeFormatter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/EmacsStructureModelManager.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/core/builder/AsmBuilderTest.java", "testing/src/org/aspectj/testing/ajde/CompileCommand.java", "weaver/src/org/aspectj/weaver/AsmAdaptor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 41123 Weaving failure when using injars

Sample run that fails using injars: C:\devel\test\libraryWeave>ajc ajee\testing\ExecutionMonitor.aj C:\devel\test\libraryWeave>jar cf ajee.jar ajee\testing\*.class C:\devel\test\libraryWeave>ajc -injars ajee.jar model\BusObj.java model\MonitorB usObj.java C:\devel\test\libraryWeave\model\BusObj.java:3 Class must implement the inherite d abstract method ExecutionMonitor.MonitoredItem.ajc$interMethodDispatch2 $ajee_t esting_ExecutionMonitor$record(String, String) public class BusObj { ^^^^^^ 1 error It works in a single pass compilation: C:\devel\test\libraryWeave>ajc ajee\testing\ExecutionMonitor.aj model\BusObj.jav a model\MonitorBusObj.java C:\devel\test\libraryWeave> Sample source code: package ajee.testing; public aspect ExecutionMonitor { public interface MonitoredItem {} private void MonitoredItem.record(String eventType, String eventName) {} } --- package model; public class BusObj { } --- package model; import ajee.testing.ExecutionMonitor; public aspect MonitorBusObj { declare parents: BusObj implements ExecutionMonitor.MonitoredItem; }

resolved fixed

3e59745

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java", "tests/bugs/moreInterfaceLibrary/model/BusObj.java", "tests/bugs/moreInterfaceLibrary/model/MonitorBusObj.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 40534 Declare warning/error output - more detail required.

At present the declare warning and declare error functionality of the compiler provides no detailed information about what it is in the user code that has led to the generation of the compile-time warning or error. Consider the following test case... public class A { public static void main(String[] args) { A a = new A(); a.doSomething(); System.out.println("All done"); } void doSomething() { System.out.println("Doing something"); } } // end of class A public aspect MyAspect { pointcut noDoing() : call(* *.doSomething(..)); declare warning : noDoing() : "Don't do it!"; } When I compile these two files I get the following warning ... c:\src\A.java:16 Don't do it! ..which is great if all I want to know is where the offending code is. But not nearly enough if I want to know what it is on the line that is contravening the policy (or policies) that I have specified in my aspect. In the above example it would be even more useful if the warning message was something like ... c:\src\A.java:16 Don't do it! : calling method : void A.doSomething() For large projects where there is an architectural imperative to reduce or completely remove coupling between certain components declare warning/error would be of far greater use if it could return more detailed info to say *why* not just *where* the desired enforcement rules have been broken.

resolved fixed

684c9c1

["bridge/src/org/aspectj/bridge/IMessage.java", "bridge/src/org/aspectj/bridge/Message.java", "testing/src/org/aspectj/testing/xml/SoftMessage.java", "weaver/src/org/aspectj/weaver/Checker.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 40257 parsing of "../" paths in LST files is broken

Relative paths (e.g. "../") are no longer parser properly in AJDE 1.1.0.

resolved fixed

acdf688

["ajbrowser/testsrc/org/aspectj/tools/ajbrowser/BrowserManagerTest.java", "ajbrowser/testsrc/org/aspectj/tools/ajbrowser/InteractiveBrowserTest.java", "ajde/src/org/aspectj/ajde/ui/swing/CompilerMessagesCellRenderer.java", "org.aspectj.ajdt.core/testdata/bug-40257/d1/A.java", "org.aspectj.ajdt.core/testdata/bug-40257/d1/d2/B.java", "org.aspectj.ajdt.core/testdata/bug-40257/d3/C.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/ajc/AjdtAjcTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/ajc/BuildArgParserTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 41170 -classpath entries in .lst files overwrite command-line -classpath entries

If the command-line specifies both a -classpath entry and a .lst file with a -classpath entry, the .lst file entry seems to replace rather than supplement the command-line entry. I expect options to be cumulative. See tests/bugs/options/classpath

resolved wontfix

40fb451

["tests/bugs/options/classpath/Client.java", "tests/bugs/options/classpath/lib/Library.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 38717 ".lst" file parsing errors should include sourceline information

To check for this bug add an erroneous line to an ".lst" file and compile it with AJDE. The error message returned is project-specific. It should be specific to the ".lst" file in which the error originated (i.e. the message needs a SourceLocation).

resolved fixed

a26cac9

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/AjdtCommand.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 39974 Some strange error when compiling the observer example with JBuilder7 integrated AJDE

When I compiled the observer/subject protocol example with JBuilder7 integrated AJDE,there was a strange internal error C:/JBuilder7/extras/aspectj-110/doc/examples/observer/Observer.java:0: Internal compiler error java.lang.NullPointerException at org.aspectj.ajdt.internal.compiler.lookup.EclipseWorld.makeResolvedMember (Unknown Source) at org.aspectj.ajdt.internal.core.builder.AsmBuilder.visit(Unknown Source) at org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse (Unknown Source) at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse (Unknown Source) at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse (Unknown Source) at org.aspectj.ajdt.internal.core.builder.AsmBuilder.internalBuild (Unknown Source) at org.aspectj.ajdt.internal.core.builder.AsmBuilder.build(Unknown Source) at org.aspectj.ajdt.internal.compiler.lookup.EclipseWorld.finishedCompilationUnit (Unknown Source) at org.aspectj.ajdt.internal.compiler.AjCompiler.process(Unknown Source) at org.eclipse.jdt.internal.compiler.Compiler.compile(Unknown Source) at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile (Unknown Source) at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile (Unknown Source) at org.aspectj.ajdt.internal.core.builder.AjBuildManager$BatchBuilder.run(Unknown Source) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (Unknown Source) at org.aspectj.ajde.internal.CompilerAdapter.compile(Unknown Source) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (Unknown Source) I firstly fix it by changing the interface Subject and Observer like this: interface Observer { void update();} interface Subject { Object getData(); } then it could compile successfully ,however,I immediately got another confusing.The compiler only made Display.java Observer.java Subject.java SubjectObserverProtocol.java and SubjectObserverProtocolImpl.java but ignoring the others.I don't know why,it seems to be a bug. Meanwhile, I use ajc command-line to compile this example ,it can get through without any exceptions.

resolved fixed

f5d31ba

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmBuilder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 39626 Compiler error when compiling a buggy class

I use AspectJ 1.1 from within eclipse. After some time of developing, I get following stack trace (Wrapped in the eclipse gui), when I try to compile a java file with a huge amount of syntax errors, missing variables, and other problems. As soon as I have fixed these issues, I can comnpile normally as ever. Unfortunatly I can not provide any more detailed information because: this errors pops up randomly, disappears when the bug is fixed, I have neither the time nor the permission to create a more accurate sample java.lang.NullPointerException at java.lang.String.<init>(String.java:214) at org.aspectj.ajdt.internal.core.builder.AsmBuilder.visit (AsmBuilder.java:231) at org.aspectj.ajdt.internal.core.builder.AsmBuilder.visit (AsmBuilder.java:259) at org.eclipse.jdt.internal.compiler.ast.AnonymousLocalTypeDeclaration.traverse (AnonymousLocalTypeDeclaration.java:138) at org.eclipse.jdt.internal.compiler.ast.QualifiedAllocationExpression.traverse (QualifiedAllocationExpression.java:342) at org.eclipse.jdt.internal.compiler.ast.MessageSend.traverse (MessageSend.java:299) at org.eclipse.jdt.internal.compiler.ast.Block.traverse(Block.java:147) at org.eclipse.jdt.internal.compiler.ast.ForStatement.traverse (ForStatement.java:347) at org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse (MethodDeclaration.java:157) at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse (TypeDeclaration.java:946) at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse (CompilationUnitDeclaration.java:303) at org.aspectj.ajdt.internal.core.builder.AsmBuilder.internalBuild (AsmBuilder.java:169) at org.aspectj.ajdt.internal.core.builder.AsmBuilder.build (AsmBuilder.java:66) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.finishedCompilationUnit (EclipseFactory.java:303) at org.aspectj.ajdt.internal.compiler.AjCompiler.process(AjCompiler.java:67) at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:338) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation (AjBuildManager.java:372) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild (AjBuildManager.java:133) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (AjBuildManager.java:78) at org.aspectj.ajde.internal.CompilerAdapter.compile (CompilerAdapter.java:117) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:164) LoadTest.java CrefoClient/src/com/dcbank/scoring/socketserver kind regards Arno Schmidmeier

resolved fixed

7886970

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmBuilder.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/core/builder/AjdtBuilderTests.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/core/builder/AsmBuilderTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 39959 AJC Compiler generates invalid class files under certain circunstances.

I made a package (I will attach it to this bug with the name bug.zip) which shows a sample Java program that correctly runs when compiled with javac and have classloading problems every time it is compiled with ajc. Please see the file README.TO.DEMONSTRATE.BUG inside the bug.zip archive for detailed (although simple) instructions on reproducing the bug. There are two shell scripts attached to make things easier. Please keep me informed of the status of this issue.

resolved fixed

ee03a3e

["tests/bugs/bootstrapClasspath/UsesDOMParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 40824 asm treats "declare parents" as methods

"declare parents" member declarations report their kind as "method" instead of what they are.

resolved fixed

58e3cb2

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmBuilder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 39842 allow use of an environment variable to set compiler arguments

I'm trying to create a special jsp compilation servlet in Tomcat 4.x that uses the aspectj compiler. I can plug in the compiler adapter, but I don't have control of the ant code they use to invoke the compiler, so I'd like to use an environment variable to do this (apparently the only mechanism they do support). I'm doing this so I can pass an aspectpath in to weave aspects into the compiled jsp servlet.

resolved fixed

2502ee5

["taskdefs/src/org/aspectj/tools/ant/taskdefs/AjcTask.java", "taskdefs/src/org/aspectj/tools/ant/taskdefs/ICommandEditor.java", "taskdefs/testsrc/org/aspectj/tools/ant/taskdefs/AjcTaskTest.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 40771 ajde apis are unnecessariy coupled to swing

The AJDE APIs are coupled to javax.swing by org.aspectj.ajde.EditorManager. The EditorManager needs to be refactored, have swing specific parts moved to org.aspectj.ajde.ui.swing and org.aspectj.ajbrowser.

resolved fixed

bbd832b

["ajbrowser/src/org/aspectj/tools/ajbrowser/BasicEditor.java", "ajbrowser/src/org/aspectj/tools/ajbrowser/BrowserManager.java", "ajbrowser/src/org/aspectj/tools/ajbrowser/BuildConfigPopupMenu.java", "ajbrowser/src/org/aspectj/tools/ajbrowser/CompilerMessagesPanel.java", "ajbrowser/src/org/aspectj/tools/ajbrowser/EditorManager.java", "ajbrowser/src/org/aspectj/tools/ajbrowser/TopFrame.java", "ajde/src/org/aspectj/ajde/Ajde.java", "ajde/src/org/aspectj/ajde/ui/EditorManager.java", "ajde/src/org/aspectj/ajde/ui/StructureModelUtil.java", "ajde/src/org/aspectj/ajde/ui/StructureViewManager.java", "ajde/src/org/aspectj/ajde/ui/swing/AjdeUIManager.java", "ajde/src/org/aspectj/ajde/ui/swing/BasicEditor.java", "ajde/src/org/aspectj/ajde/ui/swing/BrowserViewManager.java", "ajde/src/org/aspectj/ajde/ui/swing/BrowserViewTreeListener.java", "ajde/src/org/aspectj/ajde/ui/swing/BuildConfigPopupMenu.java", "ajde/src/org/aspectj/ajde/ui/swing/PointcutWizard.java", "ajde/src/org/aspectj/ajde/ui/swing/StructureViewPanel.java", "ajde/testsrc/AjdeModuleTests.java", "ajde/testsrc/org/aspectj/ajde/CompilerMessagesTest.java", "ajde/testsrc/org/aspectj/ajde/NullIdeEditorAdapter.java", "ajde/testsrc/org/aspectj/ajde/NullIdeManager.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 40380 AspectJ does not honour libraries defined via Project Properties

AJDT 1.1.3, Eclipse 2.1 To build a JDK 1.4. program under Eclipse using JDK 1.3 the appropriate build library should be selected in the Project Properties "Java Build Path". However AspectJ continues to use the JDK associated with Eclipse so errors result from using 1.4 APIs. The same will occur running Eclipse under 1.4 and compiling programs for 1.5 Testcase: 1. Run Eclipse under JDK 1.3 2. Create a Java project which uses a 1.4 JDK 3. Write a Java classes that uses 1.4 APIs e.g. public class TestStringBuffer { public static void main(String[] args) { new StringBuffer("Test").indexOf("T"); } } 4. Convert to AspectJ project

resolved fixed

d5ea336

["ajde/src/org/aspectj/ajde/internal/CompilerAdapter.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/AjdtCommand.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 39993 ajc stack trace on declaring hashcode() method in aspect

From an email sent to the user's list 6/26/2003: ------------------------------------------ ajc 1.1 NPE when an aspect declares hashcode() as follows: interface Identifiable { void setId(Id id); Id getId(); } aspect IdentifiableAspect { private Id Identifiable.id = null; public Id Identifiable.getId() { return this.id; } public void Identifiable.setId(Id id) { this.id = id; } public int Identifiable.hashCode() { return (this.getId() == null) ? super.hashCode() : this.getId().hashCode(); } } A workaround for callers the compiler controls is to replace the declaration with around advice: int around(Identifiable i): target(i) && call(public int hashCode()) { return (i.getId() == null) ? proceed(i) : i.getId().hashCode(); }

resolved fixed

026b272

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterSuperFixerVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterSuperReference.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeDeclaration.java", "tests/bugs/MultipleSuperCf.java", "tests/bugs/OverridingInterfaceObjectMethod.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 39458 Compiler crash in ajc 1.1

resolved fixed

ba41fae

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AccessForInlineVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AdviceDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/PrivilegedHandler.java", "tests/bugs/MissingImport.java", "tests/bugs/NewVoid.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 38131 ajc needs -d . option while correctly compiling classes from subpackage

resolved fixed

c509c6f

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/testdata/src1/WrongPackage.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/BasicCommandTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 37739 Unexpected Xlint:unresolvableMember warning with withincode

The following code produces an Xlint:unresolvableMember warning: class A { A(Class type) {} A() { this(String.class); } } class B { public void test() { } public void test2() { test(); } } aspect C { void around() : (call (void B.test()) && withincode (void B.test2())) { proceed(); } } The warning text is: Warning.java:22 can not resolve this member: void A.<catch>(java.lang.ClassNotFoundException) [Xlint:unresolvableMember] Line 22 is the line in the aspect that says "withincode". If I comment out the aspect, the warning goes away. Also, if I comment out A's default constructor, it goes away. The "String.class" seems to have something to do with the warning. I can reproduce this with 1.1rc1 and 1.1rc2.

resolved fixed

2072ac1

["tests/bugs/CatchSig.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 37021 source path wrong in declare warning on binary files

In declare warning messages when targeting .class files from -injars, the source path is listed in the form "app.Main.class" rather than "app/Main.[java|aj]". See tests/new/binaryWarnings/.. for code to run to see the problem. Limitations of the tests: - These tests return false positives when detecting this error because filename checking is not enabled in harness verification of messages. - I have also see the filenames not appear at all, but these tests do not reproduce that problem. (I saw it in AJDT, so perhaps if the filename makes no sense to AJDT, AJDT simply omits it.)

resolved fixed

9b30f9f

["tests/new/binaryWarnings/src/app/Main.java", "tests/new/binaryWarnings/src/aspects/MainWarnings.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 30663 lame error message: "negation doesn't allow binding"

AspectJ Compiler 1.1beta4 This program: public aspect Foo { pointcut p(int i): call(void f(i)); } produces these error messages: negation doesn't allow binding formal unbound in pointcut 2 errors It should say something like "binding is only allowed in state-based pointcuts", and it should print the file and line number. --Doug

resolved fixed

7d14432

["tests/bugs/BadBindingError.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/patterns/TypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 36936 Error when introducing members of type Class

Using AspectJ 1.1 RC1 public aspect Asp { public Class Trg.member = String.class; } public class Trg { public static void main(String args[]) { new Trg(); System.out.println("All ok"); } } Compiling with "ajc Asp.java Trg.java" and running Trg, prints "All ok", as it should. Compiling with "ajc Trg.java Asp.java" and running Trg gives: Exception in thread "main" java.lang.NoSuchFieldError: class$0 at Asp.ajc$interFieldInit$Asp$Trg$member(Asp.java:2) at Trg.<init>(Trg.java:1) at Trg.main(Trg.java:3) Note, introduced field must be of type Class, or array of Classes, works fine else.

resolved fixed

8d793a3

["tests/bugs/interSpecials/Asp.java", "tests/bugs/interSpecials/Trg.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 34951 NPE compiling without aspectjrt.jar

Compiling spacewar without specifying aspectjrt.jar on the classpath causes a NPE. Expected an error message "aspectjrt.jar required". Steps to reproduce 1) install latest 2) cd doc/examples 3) java -jar ../../lib/aspectjtools.jar -verbose @spacewar/debug.lst RESULT:NPE in attached log

resolved fixed

f236927

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/BasicCommandTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 36803 BCException thrown by AspectJ 1.1rc1

[iajc] expected state: resolved got: concrete [iajc] expected state: resolved got: concrete [iajc] org.aspectj.weaver.BCException: expected state: resolved got: concrete [iajc] at org.aspectj.weaver.patterns.Pointcut.assertState (Pointcut.java:236) [iajc] at org.aspectj.weaver.patterns.Pointcut.concretize (Pointcut.java:126) [iajc] at org.aspectj.weaver.patterns.CflowPointcut.concretize1 (CflowPointcut.java:143) [iajc] at org.aspectj.weaver.patterns.NotPointcut.concretize1 (NotPointcut.java:94) [iajc] at org.aspectj.weaver.patterns.AndPointcut.concretize1 (AndPointcut.java:88) [iajc] at org.aspectj.weaver.patterns.ReferencePointcut.concretize1 (ReferencePointcut.java:270) [iajc] at org.aspectj.weaver.patterns.AndPointcut.concretize1 (AndPointcut.java:88) [iajc] at org.aspectj.weaver.patterns.ReferencePointcut.concretize1 (ReferencePointcut.java:270) [iajc] at org.aspectj.weaver.patterns.Pointcut.concretize (Pointcut.java:127) [iajc] at org.aspectj.weaver.patterns.Pointcut.concretize (Pointcut.java:120) [iajc] at org.aspectj.weaver.Advice.concretize(Advice.java:207) [iajc] at org.aspectj.weaver.CrosscuttingMembers.addShadowMunger (CrosscuttingMembers.java:78) [iajc] at org.aspectj.weaver.CrosscuttingMembers.addShadowMungers (CrosscuttingMembers.java:72) [iajc] at org.aspectj.weaver.ResolvedTypeX.collectCrosscuttingMembers (ResolvedTypeX.java:328) [iajc] at org.aspectj.weaver.CrosscuttingMembersSet.addOrReplaceAspect (CrosscuttingMembersSet.java:54) [iajc] at org.aspectj.weaver.bcel.BcelWeaver.prepareForWeave (BcelWeaver.java:164) [iajc] at org.aspectj.weaver.bcel.BcelWeaver.weave (BcelWeaver.java:214) [iajc] at org.aspectj.ajdt.internal.core.builder.AjBuildManager.weaveAndGenerateClassFile s(AjBuildManager.java:394) [iajc] at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (AjBuildManager.java:149) [iajc] at org.aspectj.ajdt.ajc.AjdtCommand.runCommand (AjdtCommand.java:55) [iajc] at org.aspectj.tools.ajc.Main.run(Main.java:216) [iajc] at org.aspectj.tools.ajc.Main.runMain(Main.java:155) [iajc] at org.aspectj.tools.ant.taskdefs.AjcTask.execute (AjcTask.java:646) [iajc] at org.apache.tools.ant.UnknownElement.execute (UnknownElement.java:193) [iajc] at org.apache.tools.ant.Task.perform(Task.java:341) [iajc] at org.apache.tools.ant.Target.execute(Target.java:309) [iajc] at org.apache.tools.ant.Target.performTasks(Target.java:336) [iajc] at org.apache.tools.ant.Project.executeTarget (Project.java:1339) [iajc] at org.apache.tools.ant.Project.executeTargets (Project.java:1255) [iajc] at org.apache.tools.ant.Main.runBuild(Main.java:609) [iajc] at org.apache.tools.ant.Main.start(Main.java:196) [iajc] at org.apache.tools.ant.Main.main(Main.java:235)

resolved fixed

1e502f5

["tests/bugs/CflowConcrete.java", "weaver/src/org/aspectj/weaver/patterns/KindedPointcut.java", "weaver/src/org/aspectj/weaver/patterns/Pointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithincodePointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 29665 Inconsistant stack height

Using AspectJ1.1b4 running the following program crashes it with this message: "Inconsistent stack height 0 != 2". While reducing my original program to the minimum example below I had also stack height 0 != 1, but I guess that is related, so I didn't reproduce it (mail me if this you need this, too). mport java.lang.reflect.Method; public class StackError { public static void main(String args[]) {} void assertTrue(String msg, boolean b) {} public void testEqualsNull() { StackError one = new StackError(); StackError two = new StackError(); assertTrue("equal", one.equals(two)); // does not work boolean yes = one.equals(two); // works } public boolean equals(Object other) { return true; } } aspect EqualsContract { pointcut equalsCall(Object thisOne, Object otherOne): target(Object+) && target(thisOne) && call(public boolean equals(Object+)) && args(otherOne) && !within(EqualsContract); boolean around(Object thisOne, Object otherOne): equalsCall(thisOne, otherOne) { boolean result = proceed(thisOne, otherOne); Class cls = thisOne.getClass(); String name = cls.getName(); boolean hasHashCode = false; try { Method m = cls.getDeclaredMethod("hashCode", null); String lookFor = "public int " + name + ".hashCode()"; hasHashCode = lookFor.equals(m.toString()); } catch (NoSuchMethodException nsme) {} return result; } } The program does not crash if you comment out the line indicated with the "does not work" comment. Note the line below that (comment "works") does work.

resolved fixed

6c9118b

["tests/bugs/StackError.java", "tests/bugs/messyAround/cap/OptionList.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 36564 Internal compiler error

Eclipse: 2.1.0, 200302211557 AspectJ: 1.1.1 I get the following internal error when using "thisJoinPoint.getStaticPart()" in around advice at a call joinpoit (source below). Using just "thisJoinPoint" is fine. java.lang.NullPointerException at org.eclipse.jdt.internal.compiler.ast.MessageSend.analyseCode (MessageSend.java:40) at org.eclipse.jdt.internal.compiler.ast.MessageSend.analyseCode (MessageSend.java:44) at org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.analyseCode (AbstractMethodDeclaration.java:106) at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.analyseCode (TypeDeclaration.java:445) at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.analyseCode (CompilationUnitDeclaration.java:76) at org.eclipse.jdt.internal.compiler.Compiler.process (Compiler.java:539) at org.aspectj.ajdt.internal.compiler.AjCompiler.process (AjCompiler.java:65) at org.eclipse.jdt.internal.compiler.Compiler.compile (Compiler.java:340) at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile (AbstractImageBuilder.java:232) at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile (AbstractImageBuilder.java:171) at org.aspectj.ajdt.internal.core.builder.AjBuildManager$BatchBuilder.run (AjBuildManager.java:655) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (AjBuildManager.java:139) at org.aspectj.ajde.internal.CompilerAdapter.compile (CompilerAdapter.java:92) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:213) Exceptions.java AspectJ Bugs/src/compiler Source: package compiler; import java.io.*; /** * @author websterm * * To change this generated comment go to * Window>Preferences>Java>Code Generation>Code and Comments */ public class Test { public static void main(String[] args) throws Exception{ FileInputStream in = new FileInputStream("test"); } } /* * Created on 14-Apr-03 * * To change this generated comment go to * Window>Preferences>Java>Code Generation>Code and Comments */ package compiler; import java.io.*; import org.aspectj.lang.*; /** * @author websterm * * To change this generated comment go to * Window>Preferences>Java>Code Generation>Code and Comments */ public aspect Exceptions { pointcut exceptionMethods () : call(* java.io.*.*(..) throws IOException); Object around () throws IOException : exceptionMethods() && !within (Exceptions) { Object obj = proceed(); System.out.println(thisJoinPoint.getStaticPart()); return obj; } }

resolved fixed

0a8dbde

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/ThisJoinPointVisitor.java", "tests/bugs/tjpStaticPart/Exceptions.java", "tests/bugs/tjpStaticPart/Test.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 35725 Inter type declaration to base class not seen by derived class

The following code shows what I believe is an incorrect error - the base class AImpl is made concrete by the aspect Af, but the compilation of BImpl does not recognize this fact. This problem is for version 1.1rc1 and is not seen in 1.0.6. // --------------------- // A.java package a_intf; public interface A { A f(); } // --------------------- // AImpl.java package a_impl; import a_intf.A; public class AImpl implements A { } // --------------------- // Af.java package a_impl; import a_intf.A; aspect Af { public A AImpl.f() { System.out.println( "f called" ); return null; } } // --------------------- // B.java package b_intf; import a_intf.A; public interface B extends A { B g(); } // --------------------- // BImpl.java package b_impl; import a_impl.AImpl; import b_intf.B; public class BImpl extends AImpl implements B { public B g() { System.out.println( "g called" ); return null; } } // Compiler Error: // BImpl.java:7 Class must implement the inherited abstract method a_intf.A.f()

resolved fixed

11b3b07

["tests/bugs/interInherit/a_impl/AImpl.java", "tests/bugs/interInherit/a_impl/Af.java", "tests/bugs/interInherit/a_intf/A.java", "tests/bugs/interInherit/b_impl/BImpl.java", "tests/bugs/interInherit/b_intf/B.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 36046 inter-type declaration bug with abstract classes

This error occurs when you do an inter-type declaration on an interface, use declare parents to make an abstract base class implement it, and then try to use the declared (method), it fails. If you make the base class concrete, then this doesn't fail. The following code demonstrates the error. If you run java Driver you get: java.lang.AbstractMethodError: Derived.getExecutions(Ljava/lang/String;)I at Driver.main(Driver.java:23) Exception in thread "main" public class Driver { public static void main(String args[]) { Derived generator = new Derived(); System.out.println(generator.getExecutions("processEvents")); } static aspect MonitorBase { declare parents: Base implements ExecutionMonitor.MonitoredItem; } } class Derived extends Base { public String getName() { return null; } } abstract class Base { abstract public String getName(); } aspect ExecutionMonitor { /** marker interface to indicate the execution monitor should track calls and executions on this class. */ public interface MonitoredItem { int getExecutions(String methodName); } /** a Map of events to mutable integers */ public int MonitoredItem.getExecutions(String methodName) { return 0; } }

resolved fixed

808bae8

["tests/bugs/interAbstract/Driver.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 33474 bad source locations for declare error/warning

resolved fixed

989aaf7

["ajde/testdata/examples/declare-warning/apackage/InitCatcher.java", "ajde/testdata/examples/declare-warning/apackage/SomeClass.java", "ajde/testsrc/org/aspectj/ajde/AjdeTestCase.java", "ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/CompilerMessagesTest.java", "ajde/testsrc/org/aspectj/ajde/NullIdeManager.java", "ajde/testsrc/org/aspectj/ajde/NullIdeTaskListManager.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 34925 compiler crash on yesterday's rc1 build

resolved fixed

56cc4f2

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseShadow.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/bugs/ConvertToUnchecked.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 34858 Weaver crash

resolved fixed

7746fcb

["tests/bugs/CflowBinding.java", "tests/bugs/CflowBindingOrig.java", "weaver/src/org/aspectj/weaver/patterns/CflowPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 34820 ajc -aspectpath fails with NPE for cflow pointcuts

resolved fixed

db37189

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseAdvice.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 29934 runtime NullPointerException when applying around advice to other around advice

When the program below is run, it produces a NullPointerException... java.lang.NullPointerException at A2.ajc$around$A2$3b6proceed(CflowCycles.java) at A2.ajc$around$A2$3b6_aroundBody3(CflowCycles.java:35) at Target.run(CflowCycles.java:24) at CflowCycles.run_aroundBody4(CflowCycles.java:8) at CflowCycles.main_aroundBody6(CflowCycles.java:24) at CflowCycles.main(CflowCycles.java:24) ---(in new/CflowCycles.java and in ajcTestsFailing.xml) import org.aspectj.testing.Tester; /** @testcase cflow cycles in advice from different aspects */ public class CflowCycles { public static void main( String args[] ) { Tester.expectEvent("target A1"); Tester.expectEvent("target A2"); new Target().run(); Tester.checkAllEventsIgnoreDups(); } } class Target { public void run(){ } } aspect A1 { pointcut TargetRunFlow () // ok if no cflow: within(Target) && execution(* *(..)) && !within (A1+); : !within(A1+) && !preinitialization(new(..)) && !initialization(new (..))//cflow(within(Target) && execution(* *(..))) && !within(A1+) ; Object around () : TargetRunFlow() { Tester.event("target A1"); return proceed(); } // ok if in the same class } aspect A2 { pointcut TargetRun () : within(Target) && execution(* *(..)) && !within(A2+); ; Object around () : TargetRun() { Tester.event("target A2"); return proceed(); } }

resolved fixed

0fb5f69

["weaver/src/org/aspectj/weaver/bcel/BcelShadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 32239 Dumps assembly code if Object[] used in args (BcelRenderer.java:152)

resolved fixed

ae0ef30

["weaver/src/org/aspectj/weaver/bcel/BcelRenderer.java", "weaver/src/org/aspectj/weaver/bcel/Utility.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 32421 can't resolve nested public interfaces

This may be caused by the bug as 32399 file TransactionTest.java: import sub.ExecutionMonitor; public class TransactionTest { static Transaction theTransaction; private void assertCommitted() { theTransaction.getCount("method-execution", "commit"); } static aspect MonitorTest { declare parents: Transaction implements ExecutionMonitor.MonitoredItem; } } class Transaction { } file sub/ExecutionMonitor.aj: package sub; public aspect ExecutionMonitor { public interface MonitoredItem { int getCount(String eventType, String eventName); } public int MonitoredItem.getCount(String eventType, String eventName) { return 0; } } sample compilation: C:\devel>ajc -1.4 TransactionTest.java sub\ExecutionMonitor.aj can't bind type name 'ExecutionMonitor$MonitoredItem' C:/devel/TransactionTest.java:7: The method getCount(java.lang.String, java.lang .String) is undefined for the type Transaction theTransaction.getCount("method-execution", "commit"); ^^^^^^^^ 2 errors

resolved fixed

0a175d2

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseScope.java", "tests/bugs/InnerPointcut.java", "tests/bugs/interfaceNames/TransactionTest.java", "tests/bugs/interfaceNames/sub/ExecutionMonitor.java", "tests/new/EachObjectInDeepPackage.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 33948 inter-type no-arg constructor declaration conflict with compiler-generated constructor

Get error "inter-type declaration from A conflicts with existing member" when declaring a no-arg constructor in an aspect on another type which has no constructors. Likely the compiler is generating a default constructor which collides in the weaver. See test case: tests/bugs/ConstructorDeclaration.java Can the weaver reliably check that a default constructor was generated by the compiler (ours or javac or ...)? Otherwise, this could be a known limitation.

resolved fixed

6a8fa08

["tests/bugs/ConstructorDeclaration.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 32463 ajc reports error when encountering static declaration of nested classes

Version: AspectJ Compiler 1.1beta4 The ajc compiler issues a spurious error message and exits with a negative error code when weaving code containing static declaration of a nested class. The compiler seem to write the classfiles correctly but the negative exit status causes problems when e.g. using the AjcCompilerAdapter in ant. To reproduce: 1) Extract the following two files into an empty directory: // File: A.aj: aspect A { pointcut withinTest(): within(Test); pointcut callToHandleOrder() : (withinTest() && call(* handleOrder(..))); Object around(): callToHandleOrder() { return "DUMMY inserted by ASPECT" ; } } // End of File A.aj // File : Test.java public class Test { // Commenting out the static declaration makes everything work OK static { class StaticNestedClass { } } public static void main(String[] args) { System.out.println(new Test().handleOrder("test")); } private String handleOrder(String t) { return t; } } // End of Test.java 2) Compile the files ajc -sourceroots . -verbose Output: ----- compiling c:/aspectj1.1/doc/examples/bug/./A.aj compiling c:/aspectj1.1/doc/examples/bug/./Test.java weaving might need to weave [UnwovenClassFile(null, Test$1$StaticNestedClass), UnwovenClassFile(null, A), UnwovenClassFile(null, Test)](world=true) wrote class file: c:\aspectj1.1\doc\examples\bug\A.class can't find type Test$1 wrote class file: c:\aspectj1.1\doc\examples\bug\Test$1$StaticNestedClass.class wrote class file: c:\aspectj1.1\doc\examples\bug\Test.class 1 error ------

resolved fixed

d1e5c0a

["tests/bugs/WeaveLocal.java", "weaver/src/org/aspectj/weaver/NameMangler.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java", "weaver/src/org/aspectj/weaver/TypeX.java", "weaver/src/org/aspectj/weaver/patterns/WithinPointcut.java", "weaver/testsrc/org/aspectj/weaver/TypeXTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 33635 Negation of if pointcut does not work

resolved fixed

cb77524

["tests/bugs/NotIf.java", "weaver/src/org/aspectj/weaver/patterns/IfPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 30026 NullPointerException when compiling

With the following program I get a NullPointerException during compiling and a warning that the source code of Object is not available for weaving: public class NullPtr { public static void main(String args[]) { NullPtr np = new NullPtr(); np = null; } public void finalize() throws Throwable { } } aspect FinalizeContract { pointcut finalizeCall(Object o): this(Object+) && this(o) && execution(void finalize()); void around(Object o) throws Throwable: finalizeCall(o) { o.finalize(); // error ((NullPtr) o).finalize(); // ok proceed(o); } } It works if I comment out the line indicated by the // error comment or if I declare the aspect as privileged.

resolved fixed

8e6cef0

["tests/bugs/Finalizer.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 31423 Pointcut adviceexecution() does not work

Pointcut adviceexecution() does not seem to pick advice execution join points in beta4. Here is a program that shows the problem: public class Test { public static void main(String[] args) { } } aspect Aspect1 { before() : execution(* Test.*(..)) { System.out.println("Reached " + thisJoinPoint); } } aspect Aspect2 { before() : adviceexecution() && !within(Aspect2) { System.out.println("Reached " + thisJoinPoint); } } F:\aop\bugs\1.1\b4\adviceexecution>ajc -version AspectJ Compiler 1.1beta4 F:\aop\bugs\1.1\b4\adviceexecution>ajc Test.java F:\aop\bugs\1.1\b4\adviceexecution>java Test Reached execution(void Test.main(String[]))

resolved fixed

19c3e16

["tests/bugs/AdviceExec.java", "weaver/src/org/aspectj/weaver/patterns/KindedPointcut.java", "weaver/src/org/aspectj/weaver/patterns/SignaturePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 30168 Error with certain combination of advice

resolved fixed

d15eb32

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/ThisJoinPointVisitor.java", "tests/bugs/crashes/test/Test3.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 29959 super call in intertype method declaration body causes VerifyError

AspectJ Compiler 1.1beta4 This program: aspect Foo { void A.foo() { } void B.foo() { super.foo(); } } class A { } class B extends A { } class Main { public static void main(String[] args) { new B(); } } causes this error at runtime: Exception in thread "main" java.lang.VerifyError: (class: B, method: ajc$superDispatch$B$foo signature: ()V) Illegal use of nonvirtual function call at Main.main(Foo.java:11) Note that foo is never even called; the error happens at load time when the new B() expression causes class B to be loaded. There's no error if either one of the foo methods is declared in its class directly. This is kind of a showstopper... --Doug

resolved fixed

3e2801a

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeConstructorDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/SuperFixerVisitor.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InterTypeMethodBinding.java", "org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/AllocationExpression.java", "org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/ExplicitConstructorCall.java", "org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/MessageSend.java", "org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodBinding.java", "tests/bugs/SuperToIntro.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 29769 Ajde does not support new AspectJ 1.1 compiler options

The org.aspectj.ajde.BuildOptionsAdapter interface does not yet support the new AspectJ 1.1 compiler options. These need to be added to the interface, any old or renamed options deprecated, and then the correct processing needs to happen within Ajde to pass these options to the compiler. This enhancement is needed by the various IDE projects for there AspectJ 1.1 support.

resolved fixed

85a827a

["ajbrowser/src/org/aspectj/tools/ajbrowser/BrowserProperties.java", "ajde/src/org/aspectj/ajde/BuildOptionsAdapter.java", "ajde/src/org/aspectj/ajde/ProjectPropertiesAdapter.java", "ajde/src/org/aspectj/ajde/internal/AspectJBuildManager.java", "ajde/src/org/aspectj/ajde/internal/CompilerAdapter.java", "ajde/src/org/aspectj/ajde/ui/internal/AjcBuildOptions.java", "ajde/testdata/examples/figures-coverage/figures/Figure.java", "ajde/testsrc/org/aspectj/ajde/AjdeTests.java", "ajde/testsrc/org/aspectj/ajde/BuildConfigurationTests.java", "ajde/testsrc/org/aspectj/ajde/BuildOptionsTest.java", "ajde/testsrc/org/aspectj/ajde/NullIdeManager.java", "ajde/testsrc/org/aspectj/ajde/NullIdeProperties.java", "ajde/testsrc/org/aspectj/ajde/StructureModelRegressionTest.java", "ajde/testsrc/org/aspectj/ajde/StructureModelTest.java", "ajde/testsrc/org/aspectj/ajde/ui/StructureViewManagerTest.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildConfig.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/ajc/BuildArgParserTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 29662 VerifyError on accessing objects not accessible to the weaver: Incompatible object argument for invokespecial

I use aspectj1.1b4 (the version list box did not let me choose, it offered only "unspecified"). Compiling the program below yields a warning that a affected type is not exposed to the weaver. Running it crashes the program with this message: "java.lang.VerifyError: (class: VerifyError, method: finalize signature: ()V) Incompatible object argument for invokespecial" public class VerifyError { public static void main(String args[]) { VerifyError ve = new VerifyError(); } protected void finalize() {} } aspect FinalizeContract { pointcut finalizeCall(Object o): this(Object+) && this(o) && execution(void finalize()); void around(Object o) throws Throwable: finalizeCall(o) { super.finalize(); proceed(o); } }

resolved fixed

2d297d7

["tests/bugs/AroundAccess.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 29186 ajc -emacssym chokes on pointcut that includes an intertype method

resolved fixed

c1260e6

["asm/src/org/aspectj/asm/StructureModel.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmBuilder.java", "weaver/src/org/aspectj/weaver/AsmAdaptor.java", "weaver/src/org/aspectj/weaver/Lint.java", "weaver/src/org/aspectj/weaver/ResolvedTypeX.java", "weaver/src/org/aspectj/weaver/Shadow.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 28919 waever tries to weave into native methods ...

If you don't find the exception below in a bug, please add a new bug To make the bug a priority, please include a test program that can reproduce this exception. bad non-abstract method with no code: private native int nativeMessagePumpInitialize() on public class plc.comm.pvi.PviCom$LinkEventHandlerImpl bad non-abstract method with no code: private native int nativeMessagePumpInitialize() on public class plc.comm.pvi.PviCom$LinkEventHandlerImpl java.lang.RuntimeException: bad non-abstract method with no code: private native int nativeMessagePumpInitialize() on public class plc.comm.pvi.PviCom$LinkEventHandlerImpl at org.aspectj.weaver.bcel.LazyMethodGen.<init>(Unknown Source) at org.aspectj.weaver.bcel.LazyClassGen.<init>(Unknown Source) at org.aspectj.weaver.bcel.BcelObjectType.getLazyClassGen(Unknown Source) at org.aspectj.weaver.bcel.BcelWeaver.weave(Unknown Source) at org.aspectj.weaver.bcel.BcelWeaver.weave(Unknown Source) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.weaveAndGenerateClassFiles (Unknown Source) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (Unknown Source) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(Unknown Source) at org.aspectj.tools.ajc.Main.run(Unknown Source) at org.aspectj.tools.ajc.Main.runMain(Unknown Source) at org.aspectj.tools.ajc.Main.main(Unknown Source)

resolved fixed

2781720

["weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 28974 Compiler error when introducing a "final" field

The aspect below fails to compile with 1.1b2, producing the compilation error: -------------------- $ ajc com/ibm/amc/*.java com/ibm/amc/ejb/*.java d:/eclipse/runtime-workspace-ajsamples/Mock EJBs/com/ibm/amc/DemoBeanEJB.java:1: Cannot assign a value to the final field com.ibm.amc.DemoBean.ajc$interField$co m_ibm_amc$verbose !! no source information available !! 1 error --------------------------- package com.ibm.amc; import com.ibm.amc.ejb.SessionBean; /** * @author colyer * * To change this generated comment edit the template variable "typecomment": * Window>Preferences>Java>Templates. * To enable and disable the creation of type comments go to * Window>Preferences>Java>Code Generation. */ public aspect DemoBeanEJB { declare parents: DemoBean implements SessionBean; // THIS NEXT LINE IS THE CULPRIT static final boolean DemoBean.verbose = true; private transient String DemoBean.ctx; public void DemoBean.ejbActivate( ) { if ( verbose ) { System.out.println( "ejbActivate Called" ); } } } ------------------- Making the inter-type declaration non-final solves the problem...

resolved fixed

99a873c

["weaver/src/org/aspectj/weaver/AjcMemberMaker.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 422205 Missing help content reference in MongoDB ODA Data Set UI page

The help context ID is not referenced by the MongoDB DOA data set query page.

resolved fixed

345f01b

["data/org.eclipse.birt.data.oda.mongodb.ui/src/org/eclipse/birt/data/oda/mongodb/ui/impl/MongoDBDataSetWizardPage.java"]

Birt

https://github.com/eclipse/birt

eclipse/birt

java

Bug 389229 Documentation of possible values/objects of property IDeviceRenderer.FILE_IDENTIFIER

resolved fixed

37c1c08

["chart/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/device/IDeviceRenderer.java"]

Birt

https://github.com/eclipse/birt

eclipse/birt

java

Bug 403306 Nested DataEngineSessions and wrong initialization of classLoaderHolder

I have following use case: - Data Cube with measure or level attribute of DataType JavaObject - The concrete value type is loaded from the EAR where BIRT is integrated - Crosstab with Highlight conditions defined The type of the measure value is loaded by the ClassLoader provided by current DataEngineSession: DataEngineSession.getCurrentClassLoader(). DataEngineSession defines a static ThreadLocal classLoaderHolder that is (1) initialized (with correct classloader) on instantiation of DataEngineSession (along with creation of DataEngine instance) (2) reset to null on shutdown of DataEngine instance Problem arises when some code creates a new DataEngine instance within an active DataEngine instance / DataEngineSession (within the same thread). Then on shutdown of the nested / inner DataEngine instance the static ThreadLocal classLoaderHolder is reset to null. Afterwards the ClassLoader is missing (null) also in outer DataEngineSession, resulting in the error that external classes can not be loaded any longer from the EAR (or from an included library). This error occurs in above use case. On processing of the Crosstab's highlight styles a new DataEngine and DataEngineSession is created and directly shutdown after processing. The attached stacktrace files show the sequence of DataEngine(Session) creation and shutdown in above use case: - 1st: create outer DataEngine - 2nd: create inner DataEngine (for hightlight style processing) - 3rd: shutdown inner DataEngine Possible fixes: - convert classLoaderHolder from static thread-local class attribute to instance attribute (if there is no real reason for thread-local nature) - manage a stack of classloaders with classLoaderHolder (this one i used as workaround because i am not aware of the necessity of the thread-local nature of classLoaderHolder)

closed fixed

8299b4a

["data/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/DataEngineSession.java"]

Birt

https://github.com/eclipse/birt

eclipse/birt

java

Bug 375294 JBoss + Sybase database issue

Build Identifier: 3.7.100.v20110510-0712 Hi, JBoss modify the UnsupportedOperationException send by sybase driver by a org.jboss.util.NestedSQLException Code of org.jboss.resource.adapter.jdbc.WrappedConnection : protected SQLException checkException(Throwable t) throws SQLException { Throwable result = null; if (mc != null) result = mc.connectionError(t); if (result instanceof SQLException) { throw (SQLException) result; } else { throw new NestedSQLException("Error", result); } } In org.eclipse.birt.report.data.oda.jdbc.ResultSet : /* (non-Javadoc) * @see org.eclipse.datatools.connectivity.oda.IAdvancedQuery#getBlob(java.lang.String) */ public IBlob getBlob( String columnName ) throws OdaException { assertNotNull( rs ); try { java.sql.Blob blob = rs.getBlob( columnName ); return new Blob( blob ); } // especially for MS Access, which does not support getBlob method catch ( UnsupportedOperationException e1 ) { try { InputStream inputStream = rs.getBinaryStream( columnName ); return new Blob( SqlBlobUtil.newBlob( inputStream ) ); } catch ( SQLException e2 ) { ... } } catch ( SQLException e ) { // especially for the PostgreSQL driver, which does blobs via byte // array try { byte[] bytes = rs.getBytes( columnName ); if( bytes == null ) return null; return new Blob( SqlBlobUtil.newBlob( new ByteArrayInputStream( bytes ) ) ); } catch ( SQLException e2 ) { .... } } } Example of correction: /* (non-Javadoc) * @see org.eclipse.datatools.connectivity.oda.IAdvancedQuery#getBlob(java.lang.String) */ public IBlob getBlob( String columnName ) throws OdaException { assertNotNull( rs ); try { java.sql.Blob blob = rs.getBlob( columnName ); return new Blob( blob ); } // especially for MS Access, which does not support getBlob method catch ( Exception e ) { Exception e1; if (e.getClass().getName().equals("org.jboss.util.NestedSQLException")) { Class cls = e.getClass(); Method meth = cls.getMethod("getNested", null); e1 = meth.invoke(e, null); } else { e1 = e; } if ( e1 instanceof UnsupportedOperationException ) { try { InputStream inputStream = rs.getBinaryStream( columnName ); return new Blob( SqlBlobUtil.newBlob( inputStream ) ); } catch ( SQLException e2 ) { ... } } else if( e1 instance SQLException ) { // especially for the PostgreSQL driver, which does blobs via byte // array try { byte[] bytes = rs.getBytes( columnName ); if( bytes == null ) return null; return new Blob( SqlBlobUtil.newBlob( new ByteArrayInputStream( bytes ) ) ); } catch ( SQLException e2 ) { .... } } } } Reproducible: Always Steps to Reproduce: 1. Install JBoos 2. Install Jconn3.jar (the sybase driver) in JBoss 3. Deploy Birt in JBoss 4. Try to generate a report

resolved fixed

ffe1c1f

["data/org.eclipse.birt.report.data.oda.jdbc/src/org/eclipse/birt/report/data/oda/jdbc/ResultSet.java"]

Birt

https://github.com/eclipse/birt

eclipse/birt

java

Bug 416987 ArrayIndexOutOfBoundsException when parsing padding style in HTML text

There is a bug in org.eclipse.birt.report.engine.layout.pdf.util.ShortHandProcessor at line 124 that causes ArrayIndexOutOfBoundsException when parsing padding like "padding:1pt 1.5pt 2pt 2.5pt": org.eclipse.birt.report.engine.layout.pdf.util.HTMLStyleProcessor - The css statement is:width:87.95pt;padding:1pt 1.5pt 2pt 2.5pt java.lang.ArrayIndexOutOfBoundsException: 4 at org.eclipse.birt.report.engine.layout.pdf.util.ShortHandProcessor$3.process(ShortHandProcessor.java:124) at org.eclipse.birt.report.engine.layout.pdf.util.ShortHandProcessor.process(ShortHandProcessor.java:617) at org.eclipse.birt.report.engine.layout.pdf.util.HTMLStyleProcessor.execute(HTMLStyleProcessor.java:161) at org.eclipse.birt.report.engine.layout.pdf.util.HTMLStyleProcessor.execute(HTMLStyleProcessor.java:251) at org.eclipse.birt.report.engine.layout.pdf.util.HTMLStyleProcessor.execute(HTMLStyleProcessor.java:251) at org.eclipse.birt.report.engine.layout.pdf.util.HTMLStyleProcessor.execute(HTMLStyleProcessor.java:251) at org.eclipse.birt.report.engine.layout.pdf.util.HTMLStyleProcessor.execute(HTMLStyleProcessor.java:251) at org.eclipse.birt.report.engine.layout.pdf.util.HTML2Content.processForeignData(HTML2Content.java:466) at org.eclipse.birt.report.engine.layout.pdf.util.HTML2Content.html2Content(HTML2Content.java:431) at org.eclipse.birt.report.engine.nLayout.LayoutEngine.startForeign(LayoutEngine.java:761) at org.eclipse.birt.report.engine.emitter.CompositeContentEmitter.startForeign(CompositeContentEmitter.java:266) at org.eclipse.birt.report.engine.emitter.ContentEmitterUtil.startContent(ContentEmitterUtil.java:77) Let me know if you need an .rptdesign file to reproduce the error. The error is obvious. The following code tries to access an element at index 4 in the array of size 4: case 4 : buildPadding( buffer, vs[0], vs[1], vs[2], vs[4] );

resolved fixed

5eeefcf

["engine/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/layout/pdf/util/ShortHandProcessor.java"]

Birt

https://github.com/eclipse/birt

eclipse/birt

java

Bug 416703 Mongodb : Display correctly the Number data type

resolved fixed

4381f4f

["data/org.eclipse.birt.data.oda.mongodb/src/org/eclipse/birt/data/oda/mongodb/impl/MDbResultSet.java", "data/org.eclipse.birt.data.oda.mongodb/src/org/eclipse/birt/data/oda/mongodb/internal/impl/MDbMetaData.java", "data/org.eclipse.birt.data.oda.mongodb/src/org/eclipse/birt/data/oda/mongodb/nls/Messages.java"]

Birt

https://github.com/eclipse/birt

eclipse/birt

java

Bug 417317 Error when running chart example SwingInteractivityViewer.java.

verified fixed

ec88e80

["chart/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/render/InteractiveRenderer.java"]

Birt

https://github.com/eclipse/birt

eclipse/birt

java