Datasets:

bug-localization

/

apache_bugs

like 0

Bug 111667 Produce a compile warning when default advice precedence is applied

I propose that the compiler spit out a warning anytime that it has to apply the default advice precedence. Also, it should spit out the recommendation that default ordering is not guaranteed from release to release of the compiler. You can see the thread on aspectj-dev titled "change in runtime execution order" and the one on aspectj-users titled "AJDT 1.3 and aspectj" for the reasoning behind why this is a good thing.

resolved fixed

2c81907

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/Lint.java", "weaver/src/org/aspectj/weaver/Shadow.java", "weaver/src/org/aspectj/weaver/World.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 118337 Use weaver's ClassLoader not the usingClassLoader in 1.5 factory

In ReflectionBasedReferenceTypeDelegateFactory this line (44) of code is breaking my use of the weaver for looking up bootstrap classes (where the classloader is null and the AspectJ weaver isn't accessible to the bootstrap loader). The commented out code works just fine for me. Is there a real need to resolve the AspectJ runtime from a different classloader than the one that was already used to load this class from the AspectJ runtime? Class delegateClass = Class.forName("org.aspectj.weaver.reflect.Java15ReflectionBasedReferenceTypeDelegate",false,usingClassLoader);//ReflectionBasedReferenceTypeDelegate.class.getClassLoader());

resolved fixed

d1a295c

["weaver/src/org/aspectj/weaver/reflect/ReflectionBasedReferenceTypeDelegateFactory.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 11280 [View Mgmt] Switching perspectives loses view maximized state

1. Open the CVS repository view in the Java perspective. 2. Double click the title bar to maximize it 3. Switch to the resource perspective. 4. Come back to the Java perspective. The CVS repository view is no longer maximized. A view that is maximized should stay maximized.

resolved wontfix

508dbcb

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionBasedReferenceTypeDelegateFactory.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 117614 ajc crashes on common-logging-1.0.4.jar

--- Dump Properties --- Dump file: ajcore.20051122.152749.326.txt Dump reason: org.aspectj.weaver.BCException Dump on exception: true Dump at exit condition: abort ---- Exception Information --- org.aspectj.weaver.BCException: bad resolve of void org.apache.log4j.Category.log(java.lang.String, org.apache.log4j.Level, java.lang.Object, java.lang.Throwable) at org.aspectj.weaver.World.getModifiers(World.java:216) at org.aspectj.weaver.Member.getModifiers(Member.java:406) at org.aspectj.weaver.patterns.KindedPointcut.warnOnConfusingSig(KindedPointcut.java:109) at org.aspectj.weaver.patterns.KindedPointcut.match(KindedPointcut.java:69) at org.aspectj.weaver.patterns.OrPointcut.match(OrPointcut.java:44) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:43) at org.aspectj.weaver.patterns.AndPointcut.match(AndPointcut.java:43) at org.aspectj.weaver.ShadowMunger.match(ShadowMunger.java:62) at org.aspectj.weaver.Advice.match(Advice.java:91) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:1126) at org.aspectj.weaver.bcel.BcelClassWeaver.matchInvokeInstruction(BcelClassWeaver.java:1115) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:987) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:827) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:348) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:83) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:742) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump(BcelWeaver.java:707) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:634) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:577) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave(AjCompilerAdapter.java:243) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling(AjCompilerAdapter.java:118) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:383) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:680) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:168) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:102) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:109) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:60) at org.aspectj.tools.ajc.Main.run(Main.java:291)

resolved fixed

6eb77c5

["tests/src/org/aspectj/systemtest/ajc150/GenericsTests.java", "weaver/src/org/aspectj/weaver/Lint.java", "weaver/src/org/aspectj/weaver/MissingResolvedTypeWithKnownSignature.java", "weaver/src/org/aspectj/weaver/World.java", "weaver/src/org/aspectj/weaver/bcel/BcelAdvice.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java", "weaver/src/org/aspectj/weaver/patterns/ArgsAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java", "weaver/src/org/aspectj/weaver/patterns/KindedPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 116899 Using -verbose in aop.xml does not yield info messages

The interpretation of the -verbose option for LTW is not consistent with other uses in AspectJ e.g. ajc, iajc. It should allow info as well as warining and error messages to be output. The option parser and testcase need to be updated.

resolved fixed

76d7e83

["loadtime/src/org/aspectj/weaver/loadtime/Options.java", "tests/java5/ataspectj/ataspectj/ltwlog/Main.java", "tests/java5/ataspectj/ataspectj/ltwlog/MessageHolder.java", "tests/src/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 114495 unqualified superaspect<T> pointcut sortafunny in subaspect

resolved fixed

86880f7

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/ReferenceType.java", "weaver/src/org/aspectj/weaver/ResolvedType.java", "weaver/src/org/aspectj/weaver/bcel/BcelAdvice.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 114054 NPE in CContentOutlinePage.createContentProvider()

CUIPlugin.getActiveWorkbenchWindow().getActivePage() can return null.

resolved fixed

a4caeb9

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/PerThisOrTargetPointcutVisitor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 116254 AjTypeSystem interface cannot be used in LTW environment

resolved fixed

81e6b60

["aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/DeclareSoftImpl.java", "aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/StringToType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 117681 VerifyError when using annotations to define inter-type annotation

Using Sun JDK1.5.0_04 Audit.java public interface Audit { public String getLastUpdatedBy(); public void setLastUpdatedBy(String un); } AuditImpl.java public class AuditImpl implements Audit { private String lastUpdatedBy; public String getLastUpdatedBy() { return lastUpdatedBy; } public void setLastUpdatedBy(String un) { lastUpdatedBy = un; } } TestAspect.java import org.aspectj.lang.annotation.*; Test.java @Aspect public class TestAspect { @DeclareParents("Test") public static Audit introduced = new AuditImpl(); } public class Test { public static void main(String[] args) { Test t = new Test(); Audit a = (Audit)t; a.setLastUpdatedBy("username"); System.out.println("Username ="+a.getLastUpdatedBy()); } } files.lst Audit.java AuditImpl.java TestAspect.java Test.java Compiled using the following command d:\aspectj1.5\bin\ajc -classpath "d:\aspectj1.5\lib\aspectjrt.jar" -argfi le files.lst -1.5 d:\aspectj1.5\bin\aj5 Test Exception in thread "main" java.lang.VerifyError: (class: Test, method: setLastUpdatedBy signature: (Ljava/lang/String;)V) Incompatible argument to function d:\aspectj1.5\bin\aj5 -noverify Test Username=

resolved fixed

11ab99f

["tests/bugs150/pr117681/Audit.java", "tests/bugs150/pr117681/AuditImpl.java", "tests/bugs150/pr117681/MoodIndicator.java", "tests/bugs150/pr117681/Test.java", "tests/bugs150/pr117681/TestAspect.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 103157 after returning should not bind "null" as return value

Today I found out the following. When writing an advice as... after() returning(Object o): staticinitialization(*) { System.out.println(o); } This advice is indeed executed every time a type returns from staticinitialization. However, since there is no returned object, o is bound to "null". I think this is inconsistent with the fact where we have something like: after() returning(T o): call(Object Foo.bar()) { System.out.println(o); } Here, AFAIK the advice would not execute in cases where the returned object is not an instance of T. Thus, I would propose that the first advice should only execute at joinpoints where a return value is available.

resolved fixed

8b294d9

["tests/new/AfterReturningParam.java", "tests/new/ConstructorExecInit.java", "tests/new/OddConstructors.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/Advice.java", "weaver/src/org/aspectj/weaver/Shadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 117189 Contribution: reduce overhead when no aspects define

This patch to the ClassLoaderWeavingAdaptor adds two optimizations when enabled is false for the adaptor: it immediately returns false for accept and it also avoids the overhead of constructing a weaver or world. It also contains commented out code that was letting me improve performance by loading reflective proxies instead of creating BCEL objects for a resolution loader (which is currently broken since reflective proxies now require a ReflectionWorld...)

resolved fixed

a5ac5af

["loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java", "weaver/src/org/aspectj/weaver/tools/WeavingAdaptor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 103051 Declare Soft not Affecting Explicit Adviceexecution

The following aspect should compile successfully: import java.io.IOException; public aspect SoftenAdvice { declare soft: IOException: within(SoftenAdvice) && adviceexecution(); before() : execution(* main(..)) { throw new IOException("test"); } public static void main(String args[]) { } } But both 1.5.0M2 and HEAD (from 2 days ago) give this output: C:\devel\scratch\err>ajc SoftenAdvice.aj C:\devel\scratch\err\SoftenAdvice.aj:7 [error] Unhandled exception type IOExcept ion throw new IOException("test"); ^^^^^^^^^^^^^^^^^^^^ 1 error However if you change the declare soft to be the following, it correctly softens at the advice execution join point. declare soft: IOException: within(SoftenAdvice) && !withincode(* *(..));

resolved fixed

554e733

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseShadow.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 114332 Reflection API not detecting ITD method correctly in all circumstances

resolved fixed

735d94f

["aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/AjTypeImpl.java", "aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/InterTypeConstructorDeclarationImpl.java", "aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/InterTypeDeclarationImpl.java", "aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/InterTypeFieldDeclarationImpl.java", "aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/InterTypeMethodDeclarationImpl.java", "tests/java5/reflection/ReflectBilling.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 115607 Incorrect structure model for simple declare @type program?

This program: ---8<----- @interface I {} class Simple {} public aspect C { declare @type: Simple : @I; } ---8<----- (all in a file called C.java, open with the AJ editor) when built shows incorrect gutter markers, it shows a double headed arrow on Simple implying that it annotates itself - rather than something outgoing from the declare statement and something incoming on the Simple type.

resolved fixed

9ed75a1

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseSourceLocation.java", "tests/bugs150/pr115607.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 116755 PointcutParser is not configurable

I'm testing the reflection and weaver tools APIs. When I using following code: PointcutParser parse = new PointcutParser(); String expr = "call(public * main.hello(..)"; PointcutExpression pex = parse.parsePointcutExpression(expr); Whenever I use a full qualified class name in pointcut expression, an exception is throwed out: java.lang.IllegalArgumentException: warning no match for this type name: obj [Xlint:invalidAbsoluteTypeName] I try to turn off this Lint exception. But it seems I must access to world field of PointcutParser. This is inconvenient because world field is not exposed by PointcutParser. The existing PointcutParser interface implicitly creates a World and does not allow any configuration including classpath or lint. But developers may need this kind of control.

resolved fixed

522911e

["tests/java5/ataspectj/annotationGen/RuntimePointcuts.java", "tests/java5/reflection/ReflectOnAjcCompiledPointcuts.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java", "weaver/src/org/aspectj/weaver/internal/tools/TypePatternMatcherImpl.java", "weaver/src/org/aspectj/weaver/ltw/LTWWorld.java", "weaver/src/org/aspectj/weaver/ltw/LTWeaver.java", "weaver/src/org/aspectj/weaver/reflect/AnnotationFinder.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionBasedReferenceTypeDelegate.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionBasedReferenceTypeDelegateFactory.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionBasedResolvedMemberImpl.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionShadow.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionVar.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionWorld.java", "weaver/src/org/aspectj/weaver/tools/PointcutParser.java", "weaver/src/org/aspectj/weaver/tools/TypePatternMatcher.java", "weaver/testsrc/org/aspectj/weaver/tools/PointcutParserTest.java", "weaver/testsrc/org/aspectj/weaver/tools/ToolsTests.java", "weaver/testsrc/org/aspectj/weaver/tools/TypePatternMatcherTest.java", "weaver5/java5-src/org/aspectj/weaver/reflect/Java15AnnotationFinder.java", "weaver5/java5-src/org/aspectj/weaver/reflect/Java15ReflectionBasedReferenceTypeDelegate.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 115204 WildAnnotationTypePattern.java:61 NPE after renaming method-annotation class

Sorry I don't have a small test case. It looks like the NPE happens when the annotation refered to by a (compiled?) aspect no longer exists because it was renamed. The class being woven is the first one (alphabetically), and the method being woven does not have the annotation on it. Let me know if you need a test case. (And sorry for the late bugs - I'm just now writing the article.) ------------------------------------------------------------------ java.lang.NullPointerException at org.aspectj.weaver.patterns.WildAnnotationTypePattern.matches(WildAnnotationTypePattern.java:61) at org.aspectj.weaver.patterns.SignaturePattern.matchesAnnotations(SignaturePattern.java:321) at org.aspectj.weaver.patterns.SignaturePattern.matchesExactly(SignaturePattern.java:169) at org.aspectj.weaver.patterns.SignaturePattern.matches(SignaturePattern.java:131) at org.aspectj.weaver.patterns.WithincodePointcut.matchInternal(WithincodePointcut.java:73) at org.aspectj.weaver.patterns.Pointcut.match(Pointcut.java:143) at org.aspectj.weaver.patterns.AndPointcut.matchInternal(AndPointcut.java:55) at org.aspectj.weaver.patterns.Pointcut.match(Pointcut.java:143) at org.aspectj.weaver.patterns.AndPointcut.matchInternal(AndPointcut.java:55) at org.aspectj.weaver.patterns.Pointcut.match(Pointcut.java:143) at org.aspectj.weaver.ShadowMunger.match(ShadowMunger.java:64) at org.aspectj.weaver.Advice.match(Advice.java:109) at org.aspectj.weaver.bcel.BcelAdvice.match(BcelAdvice.java:97) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:1749) at org.aspectj.weaver.bcel.BcelClassWeaver.matchInvokeInstruction(BcelClassWeaver.java:1736) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:1533) at org.aspectj.weaver.bcel.BcelClassWeaver.match(BcelClassWeaver.java:1359) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:382) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:98) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1478) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump(BcelWeaver.java:1443) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:1217) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1021) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave(AjCompilerAdapter.java:300) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling(AjCompilerAdapter.java:178) at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$afterReturning$org_aspectj_ajdt_internal_compiler_CompilerAdapter$2$f9cc9ca0(CompilerAdapter.aj:70) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:367) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:759) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:225) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:151) at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:122) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run(AspectJBuildManager.java:191) trouble in: public class com.isberg.articles.aop7.bean.ABeanTest$APlus extends java.lang.Object: TypeMungers: [(BcelTypeMunger ResolvedTypeMunger(Method, java.lang.String com.isberg.articles.aop7.bean.ABeanTest$CPlus.propertyName(java.lang.String)))] declares: [declare parents: com.isberg.articles.aop7.bean.ABeanTest$CPlus extends (com.isberg.articles.aop7.bean.ABean$IBean);] private static Throwable ajc$initFailureCause public static final com.isberg.articles.aop7.bean.ABeanTest$APlus ajc$perSingletonInstance static void <clinit>(): staticinitialization(void com.isberg.articles.aop7.bean.ABeanTest$APlus.<clinit>()) | catch java.lang.Throwable -> E0 | | INVOKESTATIC com.isberg.articles.aop7.bean.ABeanTest$APlus.ajc$postClinit ()V (line 125) | catch java.lang.Throwable -> E0 | GOTO L0 | E0: ASTORE_0 | ALOAD_0 | PUTSTATIC com.isberg.articles.aop7.bean.ABeanTest$APlus.ajc$initFailureCause Ljava/lang/Throwable; | L0: RETURN staticinitialization(void com.isberg.articles.aop7.bean.ABeanTest$APlus.<clinit>()) end static void <clinit>() void <init>(): ALOAD_0 // com.isberg.articles.aop7.bean.ABeanTest$APlus this (line 125) INVOKESPECIAL java.lang.Object.<init> ()V constructor-execution(void com.isberg.articles.aop7.bean.ABeanTest$APlus.<init>()) | RETURN constructor-execution(void com.isberg.articles.aop7.bean.ABeanTest$APlus.<init>()) end void <init>() void ajc$declare_parents_1() org.aspectj.weaver.MethodDeclarationLineNumber: 127:3678 : RETURN (line 127) end void ajc$declare_parents_1() public static String ajc$interMethod$com_isberg_articles_aop7_bean_ABeanTest$APlus$com_isberg_articles_aop7_bean_ABeanTest$CPlus$propertyName(com.isberg.articles.aop7.bean.ABeanTest$CPlus, String) EffectiveSignatureAttribute(java.lang.String com.isberg.articles.aop7.bean.ABeanTest$CPlus.propertyName(java.lang.String), method-execution) : method-execution(java.lang.String com.isberg.articles.aop7.bean.ABeanTest$CPlus.propertyName(java.lang.String)) | ALOAD_0 // com.isberg.articles.aop7.bean.ABeanTest$CPlus ajc$this_ (line 132) | ALOAD_1 // java.lang.String methodName | INVOKESTATIC com.isberg.articles.aop7.bean.ABean.ajc$interMethod$com_isberg_articles_aop7_bean_ABean$com_isberg_articles_aop7_bean_ABean$IBean$propertyName (Lcom/isberg/articles/aop7/bean/ABean$IBean;Ljava/lang/String;)Ljava/lang/String; | ASTORE_2 | LDC "something" (line 133) | ALOAD_2 // java.lang.String result | method-call(boolean java.lang.String.equals(java.lang.Object)) | | INVOKEVIRTUAL java.lang.String.equals (Ljava/lang/Object;)Z | method-call(boolean java.lang.String.equals(java.lang.Object)) | IFEQ L0 | LDC "a" (line 134) | ASTORE_2 // java.lang.String result | L0: ALOAD_2 // java.lang.String result (line 136) | ARETURN method-execution(java.lang.String com.isberg.articles.aop7.bean.ABeanTest$CPlus.propertyName(java.lang.String)) end public static String ajc$interMethod$com_isberg_articles_aop7_bean_ABeanTest$APlus$com_isberg_articles_aop7_bean_ABeanTest$CPlus$propertyName(com.isberg.articles.aop7.bean.ABeanTest$CPlus, String) public static String ajc$interMethodDispatch1$com_isberg_articles_aop7_bean_ABeanTest$APlus$com_isberg_articles_aop7_bean_ABeanTest$CPlus$propertyName(com.isberg.articles.aop7.bean.ABeanTest$CPlus, String) EffectiveSignatureAttribute(java.lang.String com.isberg.articles.aop7.bean.ABeanTest$CPlus.propertyName(java.lang.String), method-call) : ALOAD_0 ALOAD_1 INVOKEVIRTUAL com.isberg.articles.aop7.bean.ABeanTest$CPlus.propertyName (Ljava/lang/String;)Ljava/lang/String; ARETURN end public static String ajc$interMethodDispatch1$com_isberg_articles_aop7_bean_ABeanTest$APlus$com_isberg_articles_aop7_bean_ABeanTest$CPlus$propertyName(com.isberg.articles.aop7.bean.ABeanTest$CPlus, String) public static com.isberg.articles.aop7.bean.ABeanTest$APlus aspectOf() org.aspectj.weaver.AjAttribute$AjSynthetic@591171 : GETSTATIC com.isberg.articles.aop7.bean.ABeanTest$APlus.ajc$perSingletonInstance Lcom/isberg/articles/aop7/bean/ABeanTest$APlus; IFNONNULL L0 NEW org.aspectj.lang.NoAspectBoundException DUP LDC "com_isberg_articles_aop7_bean_ABeanTest$APlus" GETSTATIC com.isberg.articles.aop7.bean.ABeanTest$APlus.ajc$initFailureCause Ljava/lang/Throwable; INVOKESPECIAL org.aspectj.lang.NoAspectBoundException.<init> (Ljava/lang/String;Ljava/lang/Throwable;)V ATHROW L0: GETSTATIC com.isberg.articles.aop7.bean.ABeanTest$APlus.ajc$perSingletonInstance Lcom/isberg/articles/aop7/bean/ABeanTest$APlus; ARETURN end public static com.isberg.articles.aop7.bean.ABeanTest$APlus aspectOf() public static boolean hasAspect() org.aspectj.weaver.AjAttribute$AjSynthetic@16e3eb3 : GETSTATIC com.isberg.articles.aop7.bean.ABeanTest$APlus.ajc$perSingletonInstance Lcom/isberg/articles/aop7/bean/ABeanTest$APlus; IFNULL L0 ICONST_1 IRETURN L0: ICONST_0 IRETURN end public static boolean hasAspect() private static void ajc$postClinit() org.aspectj.weaver.AjAttribute$AjSynthetic@d7cf62 : NEW com.isberg.articles.aop7.bean.ABeanTest$APlus DUP INVOKESPECIAL com.isberg.articles.aop7.bean.ABeanTest$APlus.<init> ()V PUTSTATIC com.isberg.articles.aop7.bean.ABeanTest$APlus.ajc$perSingletonInstance Lcom/isberg/articles/aop7/bean/ABeanTest$APlus; RETURN end private static void ajc$postClinit() end public class com.isberg.articles.aop7.bean.ABeanTest$APlus when matching pointcut ((withincode(@(Parallel) * *(..)) && call(void *(..))) && percflow(com.isberg.articles.aop7.concurrent.ParallelMethodImpl on execution(@(Parallel) * *(..)))) when matching shadow method-call(boolean java.lang.String.equals(java.lang.Object)) when weaving type com.isberg.articles.aop7.bean.ABeanTest$APlus when weaving aspects when weaving when batch building BuildConfig[c:\home\ws\main-31\.metadata\.plugins\org.eclipse.ajdt.core\devworks-fall.generated.lst] #Files=70

resolved fixed

557f5b4

["weaver/src/org/aspectj/weaver/patterns/WildAnnotationTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 116949 [waitingOnAJDTdrop]Exception thrown from AspectJ compiler

java.lang.ClassCastException at org.aspectj.weaver.bcel.BcelClassWeaver.checkForOverride (BcelClassWeaver.java:607) at org.aspectj.weaver.bcel.BcelClassWeaver.calculateAnyRequiredBridgeMethods (BcelClassWeaver.java:676) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1537) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump(BcelWeaver.java:1485) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:1266) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1088) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave (AjCompilerAdapter.java:300) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling (AjCompilerAdapter.java:178) at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$afterReturning$org_aspect j_ajdt_internal_compiler_CompilerAdapter$2$f9cc9ca0(CompilerAdapter.aj:70) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile (Compiler.java:367) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation (AjBuildManager.java:809) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild (AjBuildManager.java:254) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.incrementalBuild (AjBuildManager.java:163) at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:117) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:191) trouble in: public class ts.simul.client.AbstractClient$OptionSetter extends ts.util.CmdLineProgram$OptionSetterBase: final ts.simul.client.AbstractClient this$0 private static final org.aspectj.lang.JoinPoint$StaticPart ajc$tjp_0 public void <init>(ts.simul.client.AbstractClient) org.aspectj.weaver.MethodDeclarationLineNumber: 59:1411 : ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this (line 60) ALOAD_1 PUTFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this (line 59) ALOAD_1 INVOKESPECIAL ts.util.CmdLineProgram$OptionSetterBase.<init> (Lts/util/CmdLineProgram;)V constructor-execution(void ts.simul.client.AbstractClient$OptionSetter.<init> (ts.simul.client.AbstractClient)) | RETURN constructor-execution(void ts.simul.client.AbstractClient$OptionSetter.<init> (ts.simul.client.AbstractClient)) end public void <init>(ts.simul.client.AbstractClient) public boolean setOption_file(String) throws ts.util.IllegalProgramArgumentException org.aspectj.weaver.MethodDeclarationLineNumber: 62:1469 : method-execution(boolean ts.simul.client.AbstractClient$OptionSetter.setOption_file(java.lang.String)) | ALOAD_1 // java.lang.String optParam (line 65) | method-call(int java.lang.String.length()) | | INVOKEVIRTUAL java.lang.String.length ()I | method-call(int java.lang.String.length()) | IFLE L1 | ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this (line 66) | GETFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; | ALOAD_1 // java.lang.String optParam | PUTFIELD ts.simul.client.AbstractClient.fileName Ljava/lang/String; | NEW java.io.File (line 67) | DUP | ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this | GETFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; | GETFIELD ts.simul.client.AbstractClient.fileName Ljava/lang/String; | constructor-call(void java.io.File.<init>(java.lang.String)) | | INVOKESPECIAL java.io.File.<init> (Ljava/lang/String;)V | constructor-call(void java.io.File.<init>(java.lang.String)) | ASTORE_2 | ALOAD_2 // java.io.File file (line 68) | method-call(boolean java.io.File.exists()) | | INVOKEVIRTUAL java.io.File.exists ()Z | method-call(boolean java.io.File.exists()) | IFNE L0 | NEW ts.util.IllegalProgramArgumentException (line 69) | DUP | NEW java.lang.StringBuilder | DUP | LDC "Cannot find file: [" | constructor-call(void java.lang.StringBuilder.<init>(java.lang.String)) | | INVOKESPECIAL java.lang.StringBuilder.<init> (Ljava/lang/String;)V | constructor-call(void java.lang.StringBuilder.<init>(java.lang.String)) | ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this | GETFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; | GETFIELD ts.simul.client.AbstractClient.fileName Ljava/lang/String; | method-call(java.lang.StringBuilder java.lang.StringBuilder.append (java.lang.String)) | | INVOKEVIRTUAL java.lang.StringBuilder.append (Ljava/lang/String;)Ljava/lang/StringBuilder; | method-call(java.lang.StringBuilder java.lang.StringBuilder.append (java.lang.String)) | LDC "]" | method-call(java.lang.StringBuilder java.lang.StringBuilder.append (java.lang.String)) | | INVOKEVIRTUAL java.lang.StringBuilder.append (Ljava/lang/String;)Ljava/lang/StringBuilder; | method-call(java.lang.StringBuilder java.lang.StringBuilder.append (java.lang.String)) | method-call(java.lang.String java.lang.StringBuilder.toString()) | | INVOKEVIRTUAL java.lang.StringBuilder.toString () Ljava/lang/String; | method-call(java.lang.String java.lang.StringBuilder.toString()) | constructor-call(void ts.util.IllegalProgramArgumentException.<init> (java.lang.String)) | | INVOKESPECIAL ts.util.IllegalProgramArgumentException.<init> (Ljava/lang/String;)V | constructor-call(void ts.util.IllegalProgramArgumentException.<init> (java.lang.String)) | ATHROW | L0: ICONST_1 (line 70) | IRETURN | L1: ICONST_0 (line 73) | IRETURN method-execution(boolean ts.simul.client.AbstractClient$OptionSetter.setOption_file(java.lang.String)) end public boolean setOption_file(String) throws ts.util.IllegalProgramArgumentException public boolean setOption_class(String) throws ts.util.IllegalProgramArgumentException org.aspectj.weaver.MethodDeclarationLineNumber: 76:1971 : method-execution(boolean ts.simul.client.AbstractClient$OptionSetter.setOption_class(java.lang.String)) | ALOAD_1 // java.lang.String optParam (line 79) | method-call(int java.lang.String.length()) | | INVOKEVIRTUAL java.lang.String.length ()I | method-call(int java.lang.String.length()) | IFLE L1 | ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this (line 80) | GETFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; | ALOAD_1 // java.lang.String optParam | PUTFIELD ts.simul.client.AbstractClient.className Ljava/lang/String; | catch ts.simul.SimulationException -> E0 | | ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this (line 82) | | GETFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; | | ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this | | GETFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; | | GETFIELD ts.simul.client.AbstractClient.className Ljava/lang/String; | | method-call(java.lang.Class ts.simul.SceneFactory.getSceneClass (java.lang.String)) | | | INVOKESTATIC ts.simul.SceneFactory.getSceneClass (Ljava/lang/String;)Ljava/lang/Class; | | method-call(java.lang.Class ts.simul.SceneFactory.getSceneClass (java.lang.String)) | | PUTFIELD ts.simul.client.AbstractClient.sceneClass Ljava/lang/Class; | | ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this (line 83) | | GETFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; | | method-call(void ts.simul.client.AbstractClient.setBeanInfoSearchPath()) | | | INVOKESTATIC ts.simul.Architecture.aspectOf () Lts/simul/Architecture; | | | GETSTATIC ts.simul.client.AbstractClient$OptionSetter.ajc$tjp_0 Lorg/aspectj/lang/JoinPoint$StaticPart; | | | INVOKEVIRTUAL ts.simul.Architecture.ajc$before$ts_simul_Architecture$1$ae285a4d (Lorg/aspectj/lang/JoinPoint$StaticPart;)V | | | INVOKEVIRTUAL ts.simul.client.AbstractClient.setBeanInfoSearchPath ()V | | method-call(void ts.simul.client.AbstractClient.setBeanInfoSearchPath()) | | GOTO L0 | catch ts.simul.SimulationException -> E0 | E0: ASTORE_2 (line 85) | NEW ts.util.IllegalProgramArgumentException (line 86) | DUP | ALOAD_2 // ts.simul.SimulationException e | method-call(java.lang.String ts.simul.SimulationException.getMessage()) | | INVOKEVIRTUAL ts.simul.SimulationException.getMessage () Ljava/lang/String; | method-call(java.lang.String ts.simul.SimulationException.getMessage()) | constructor-call(void ts.util.IllegalProgramArgumentException.<init> (java.lang.String)) | | INVOKESPECIAL ts.util.IllegalProgramArgumentException.<init> (Ljava/lang/String;)V | constructor-call(void ts.util.IllegalProgramArgumentException.<init> (java.lang.String)) | ATHROW | L0: ICONST_1 (line 88) | IRETURN | L1: ICONST_0 (line 91) | IRETURN method-execution(boolean ts.simul.client.AbstractClient$OptionSetter.setOption_class(java.lang.String)) end public boolean setOption_class(String) throws ts.util.IllegalProgramArgumentException public boolean setOption_name(String) org.aspectj.weaver.MethodDeclarationLineNumber: 94:2593 : method-execution(boolean ts.simul.client.AbstractClient$OptionSetter.setOption_name(java.lang.String)) | ALOAD_0 // ts.simul.client.AbstractClient$OptionSetter this (line 96) | GETFIELD ts.simul.client.AbstractClient$OptionSetter.this$0 Lts/simul/client/AbstractClient; | ALOAD_1 // java.lang.String optParam | PUTFIELD ts.simul.client.AbstractClient.sceneName Ljava/lang/String; | ICONST_1 (line 97) | IRETURN method-execution(boolean ts.simul.client.AbstractClient$OptionSetter.setOption_name(java.lang.String)) end public boolean setOption_name(String) public boolean setOption_actors(String) org.aspectj.weaver.MethodDeclarationLineNumber: 100:2739 : method-execution(boolean ts.simul.client.AbstractClient$OptionSetter.setOption_actors(java.lang.String)) | catch java.lang.NumberFormatException -> E0 | | ALOAD_1 // java.lang.String optParam (line 103) | | method-call(int java.lang.Integer.parseInt(java.lang.String)) | | | INVOKESTATIC java.lang.Integer.parseInt (Ljava/lang/String;) I | | method-call(int java.lang.Integer.parseInt(java.lang.String)) | | ISTORE_2 | | GOTO L0 | catch java.lang.NumberFormatException -> E0 | E0: ASTORE_2 // int n (line 105) | ICONST_0 (line 106) | IRETURN | L0: ICONST_1 (line 108) | IRETURN method-execution(boolean ts.simul.client.AbstractClient$OptionSetter.setOption_actors(java.lang.String)) end public boolean setOption_actors(String) end public class ts.simul.client.AbstractClient$OptionSetter when weaving type ts.simul.client.AbstractClient$OptionSetter when weaving classes when weaving when incrementally building BuildConfig [c:\Projects\eclipse\.metadata\.plugins\org.eclipse.ajdt.core\TS.generated.lst] #Files=79

verified fixed

dd9a9b2

["weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 116626 Load-time weaving - exception from the weaver

Hi again :-) I'm trying to use loadtime weaving and getting an exception. Please look at the testcase: Java code: ========== public class Test<T> { Set<T> intsSet; public Test() { this.intsSet = new HashSet<T>(); } public <T> T[] getObjs(T[] a) { return intsSet.toArray(a); } public static void main(String[] args) { System.out.println("AAA :-)"); new TTT().foo(); } } class TTT { public void foo() { Test<Object> mt = new Test<Object>(); Object[] arr = mt.getObjs(new Object[]{}); } } Aspect: ======= public privileged aspect TestAspect { pointcut TestToArray(Test mt) : target(mt) && !within(TestAspect); Object[] around(Test mt, Object[] objs) : TestToArray(mt) && args(objs) && execution(Object[] com.mprv.secsph.Test.getObjs(Object[])) { objs = proceed(mt, objs); System.out.println("GO Aspects!"); return objs; } } aop.xml ======= <aspectj> <aspects> <aspect name="com.mprv.secsph.TestAspect"/> </aspects> <weaver options="-verbose -XlazyTjp -showWeaveInfo"> <include within="com.mprv.*"/> </weaver> </aspectj> Program output: ============== AAA :-) info weaving 'com/mprv/secsph/TestAspect' java.lang.NullPointerException at org.aspectj.weaver.tools.WeavingAdaptor$WeavingClassFileProvider.getBytes (WeavingAdaptor.java:390) at org.aspectj.weaver.tools.WeavingAdaptor.getAtAspectJAspectBytes (WeavingAdaptor.java:259) at org.aspectj.weaver.tools.WeavingAdaptor.weaveClass (WeavingAdaptor.java:181) at org.aspectj.weaver.loadtime.Aj.preProcess(Aj.java:66) at org.aspectj.weaver.loadtime.ClassPreProcessorAgentAdapter.transform (ClassPreProcessorAgentAdapter.java:52) at sun.instrument.TransformerManager.transform (TransformerManager.java:122) at sun.instrument.InstrumentationImpl.transform (InstrumentationImpl.java:155) at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:620) at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:124) at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) at java.net.URLClassLoader.access$100(URLClassLoader.java:56) at java.net.URLClassLoader$1.run(URLClassLoader.java:195) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:188) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:268) at java.lang.ClassLoader.loadClass(ClassLoader.java:251) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319) at com.mprv.secsph.Test.getObjs(Test.java:1) at com.mprv.secsph.TTT.foo(Test.java:34) at com.mprv.secsph.Test.main(Test.java:27) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at com.intellij.rt.execution.application.AppMain.main(AppMain.java:86) GO Aspects! ==== This exception doesn't happen all the time ... but if you will try a few times, you will probably get it. May you can understand what is the problem event without running the test case. Anyway, I took a look at your code, and have a guess (but it's only the guess) - My aspect is in the application classpath. Actually it's in the same package, so may be you are trying to weave the aspect with itself somehow ... Thanks! Misha.

resolved fixed

c760895

["tests/bugs150/pr116626/com/foo/bar/Test.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/tools/WeavingAdaptor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 116255 XML Linkage Error with LTW

I am trying out a recent dev build of AspectJ and am now seeing a new linkage error when I load a Web app that contains an XML deployment descriptor. I'm trying to narrow down the date when this error first appeared. If I build and run with the Sept. 23 dev build all works properly. If I build and run with the Nov. 14 dev build it fails like this ... Here's the output: SEVERE: Error deploying configuration descriptor jpetstore.xml java.lang.LinkageError: org/apache/xerces/jaxp/SAXParserFactoryImpl : already defined in loader at java.lang.ClassLoader.defineClass(Ljava.lang.String; [BIILjava.security.ProtectionDomain;)Ljava.lang.Class;(Unknown Source ) at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:124) at org.apache.catalina.loader.WebappClassLoader.findClassInternal (WebappClassLoader.java:1629) at org.apache.catalina.loader.WebappClassLoader.findClass (WebappClassLoader.java:850) at org.apache.catalina.loader.WebappClassLoader.loadClass (WebappClassLoader.java:1299) at org.apache.catalina.loader.WebappClassLoader.loadClass (WebappClassLoader.java:1181) at javax.xml.parsers.FactoryFinder.newInstance(FactoryFinder.java:88) at javax.xml.parsers.FactoryFinder.findJarServiceProvider (FactoryFinder.java:278) at javax.xml.parsers.FactoryFinder.find(FactoryFinder.java:185) at javax.xml.parsers.SAXParserFactory.newInstance (SAXParserFactory.java:107) at org.apache.tomcat.util.digester.Digester.getFactory (Digester.java:486) at org.apache.tomcat.util.digester.Digester.getParser(Digester.java:691) at org.apache.tomcat.util.digester.Digester.getXMLReader (Digester.java:899) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1561) at org.apache.catalina.startup.TldConfig.tldScanStream (TldConfig.java:513) at org.apache.catalina.startup.TldConfig.tldScanTld(TldConfig.java:545) at org.apache.catalina.startup.TldConfig.execute(TldConfig.java:300) at org.apache.catalina.core.StandardContext.processTlds (StandardContext.java:4193) at org.apache.catalina.core.StandardContext.start (StandardContext.java:4049) at org.apache.catalina.core.ContainerBase.addChildInternal (ContainerBase.java:759) at org.apache.catalina.core.ContainerBase.addChild (ContainerBase.java:739) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:524) at org.apache.catalina.startup.HostConfig.deployDescriptor (HostConfig.java:589) at org.apache.catalina.startup.HostConfig.deployDescriptors (HostConfig.java:536) at org.apache.catalina.startup.HostConfig.deployApps (HostConfig.java:471) at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1102) at org.apache.catalina.startup.HostConfig.lifecycleEvent (HostConfig.java:311) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent (LifecycleSupport.java:119) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1020) at org.apache.catalina.core.StandardHost.start(StandardHost.java:718) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1012) error can't determine implemented interfaces of missing type javax.xml.rpc.Call when matching pointcut ((((within(*) && call(public * javax.xml.rpc.Call.invoke* (..))) && target(BindingTypePattern(java.lang.Object , 0))) && if(boolean glassbox.inspector.monitor.resource.RemoteCallMonitor.ajc$if_12())) && persingleton(glassbox.inspector.monitor. resource.RemoteCallMonitor)) when matching shadow method-call(boolean org.apache.crimson.parser.ContentModel.empty()) when weaving type org.apache.crimson.parser.ContentModel when weaving classes when weaving abort trouble in: final class org.apache.crimson.parser.ContentModel extends java.lang.Object: public char type public Object content public org.apache.crimson.parser.ContentModel next private org.apache.crimson.parser.SimpleHashtable cache public void <init>(String): ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 116) INVOKESPECIAL java.lang.Object.<init> ()V constructor-execution(void org.apache.crimson.parser.ContentModel.<init> (java.lang.String)) | ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 110) | NEW org.apache.crimson.parser.SimpleHashtable | DUP | constructor-call(void org.apache.crimson.parser.SimpleHashtable.<init>()) | | INVOKESPECIAL org.apache.crimson.parser.SimpleHashtable.<init> ()V | constructor-call(void org.apache.crimson.parser.SimpleHashtable.<init>()) | PUTFIELD org.apache.crimson.parser.ContentModel.cache Lorg/apache/crimson/parser/SimpleHashtable; | ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 117) | ICONST_0 | PUTFIELD org.apache.crimson.parser.ContentModel.type C | ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 118) | ALOAD_1 // java.lang.String element | PUTFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; | RETURN (line 119) constructor-execution(void org.apache.crimson.parser.ContentModel.<init> (java.lang.String)) end public void <init>(String) public void <init>(char, org.apache.crimson.parser.ContentModel): ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 125) INVOKESPECIAL java.lang.Object.<init> ()V constructor-execution(void org.apache.crimson.parser.ContentModel.<init> (char, org.apache.crimson.parser.ContentModel)) | ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 110) | NEW org.apache.crimson.parser.SimpleHashtable | DUP | constructor-call(void org.apache.crimson.parser.SimpleHashtable.<init>()) | | INVOKESPECIAL org.apache.crimson.parser.SimpleHashtable.<init> ()V | constructor-call(void org.apache.crimson.parser.SimpleHashtable.<init>()) | PUTFIELD org.apache.crimson.parser.ContentModel.cache Lorg/apache/crimson/parser/SimpleHashtable; | ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 126) | ILOAD_1 // char type | PUTFIELD org.apache.crimson.parser.ContentModel.type C | ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 127) | ALOAD_2 // org.apache.crimson.parser.ContentModel content | PUTFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; | RETURN (line 128) constructor-execution(void org.apache.crimson.parser.ContentModel.<init> (char, org.apache.crimson.parser.ContentModel)) end public void <init>(char, org.apache.crimson.parser.ContentModel) public boolean empty(): method-execution(boolean org.apache.crimson.parser.ContentModel.empty()) | ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 137) | GETFIELD org.apache.crimson.parser.ContentModel.type C | LOOKUPSWITCH | 0: L1 | 42: L0 | 43: L1 | 44: L7 | 63: L0 | 124: L2 | default: L13 | L0: ICONST_1 (line 140) | IRETURN | L1: ICONST_0 (line 144) | IRETURN | L2: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 147) | GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; | INSTANCEOF org.apache.crimson.parser.ContentModel | IFEQ L3 | ALOAD_0 // org.apache.crimson.parser.ContentModel this | GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; | CHECKCAST org.apache.crimson.parser.ContentModel | method-call(boolean org.apache.crimson.parser.ContentModel.empty()) | | INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.empty ()Z | method-call(boolean org.apache.crimson.parser.ContentModel.empty()) | IFEQ L3 | ICONST_1 (line 149) | IRETURN | L3: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 151) | GETFIELD org.apache.crimson.parser.ContentModel.next Lorg/apache/crimson/parser/ContentModel; | ASTORE_1 | GOTO L6 | L4: ALOAD_1 // org.apache.crimson.parser.ContentModel m (line 154) | INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.empty ()Z | IFEQ L5 | ICONST_1 (line 155) | IRETURN | L5: ALOAD_1 // org.apache.crimson.parser.ContentModel m (line 153) | GETFIELD org.apache.crimson.parser.ContentModel.next Lorg/apache/crimson/parser/ContentModel; | ASTORE_1 // org.apache.crimson.parser.ContentModel m | L6: ALOAD_1 // org.apache.crimson.parser.ContentModel m (line 152) | IFNONNULL L4 | ICONST_0 (line 157) | IRETURN | L7: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 160) | GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; | INSTANCEOF org.apache.crimson.parser.ContentModel | IFEQ L8 | ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 161) | GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; | CHECKCAST org.apache.crimson.parser.ContentModel | INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.empty ()Z | IFNE L9 | ICONST_0 (line 162) | IRETURN | L8: ICONST_0 (line 165) | IRETURN | L9: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 167) | GETFIELD org.apache.crimson.parser.ContentModel.next Lorg/apache/crimson/parser/ContentModel; | ASTORE_2 | GOTO L12 | L10: ALOAD_2 // org.apache.crimson.parser.ContentModel m (line 170) | INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.empty ()Z | IFNE L11 | ICONST_0 (line 171) | IRETURN | L11: ALOAD_2 // org.apache.crimson.parser.ContentModel m (line 169) | GETFIELD org.apache.crimson.parser.ContentModel.next Lorg/apache/crimson/parser/ContentModel; | ASTORE_2 // org.apache.crimson.parser.ContentModel m | L12: ALOAD_2 // org.apache.crimson.parser.ContentModel m (line 168) | IFNONNULL L10 | ICONST_1 (line 173) | IRETURN | L13: NEW java.lang.InternalError (line 176) | DUP | INVOKESPECIAL java.lang.InternalError.<init> ()V | ATHROW method-execution(boolean org.apache.crimson.parser.ContentModel.empty()) end public boolean empty() public boolean first(String): ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 186) GETFIELD org.apache.crimson.parser.ContentModel.cache Lorg/apache/crimson/parser/SimpleHashtable; ALOAD_1 // java.lang.String token INVOKEVIRTUAL org.apache.crimson.parser.SimpleHashtable.get (Ljava/lang/String;)Ljava/lang/Object; CHECKCAST java.lang.Boolean ASTORE_2 ALOAD_2 // java.lang.Boolean b (line 189) IFNULL L0 ALOAD_2 // java.lang.Boolean b (line 190) INVOKEVIRTUAL java.lang.Boolean.booleanValue ()Z IRETURN L0: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 193) GETFIELD org.apache.crimson.parser.ContentModel.type C LOOKUPSWITCH 0: L1 42: L1 43: L1 44: L5 63: L1 124: L12 default: L16 L1: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 198) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; INSTANCEOF java.lang.String IFEQ L4 ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 199) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; ALOAD_1 // java.lang.String token IF_ACMPNE L2 ICONST_1 GOTO L3 L2: ICONST_0 L3: ISTORE_3 GOTO L17 L4: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 201) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; CHECKCAST org.apache.crimson.parser.ContentModel ALOAD_1 // java.lang.String token INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.first (Ljava/lang/String;)Z ISTORE_3 // boolean retval GOTO L17 (line 202) L5: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 205) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; INSTANCEOF java.lang.String IFEQ L8 ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 206) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; ALOAD_1 // java.lang.String token IF_ACMPNE L6 ICONST_1 GOTO L7 L6: ICONST_0 L7: ISTORE_3 // boolean retval GOTO L17 L8: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 207) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; CHECKCAST org.apache.crimson.parser.ContentModel ALOAD_1 // java.lang.String token INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.first (Ljava/lang/String;)Z IFEQ L9 ICONST_1 (line 208) ISTORE_3 // boolean retval GOTO L17 L9: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 209) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; CHECKCAST org.apache.crimson.parser.ContentModel INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.empty ()Z IFNE L10 ICONST_0 (line 210) ISTORE_3 // boolean retval GOTO L17 L10: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 211) GETFIELD org.apache.crimson.parser.ContentModel.next Lorg/apache/crimson/parser/ContentModel; IFNULL L11 ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 212) GETFIELD org.apache.crimson.parser.ContentModel.next Lorg/apache/crimson/parser/ContentModel; ALOAD_1 // java.lang.String token INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.first (Ljava/lang/String;)Z ISTORE_3 // boolean retval GOTO L17 L11: ICONST_0 (line 214) ISTORE_3 // boolean retval GOTO L17 (line 215) L12: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 218) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; INSTANCEOF java.lang.String IFEQ L13 ALOAD_0 // org.apache.crimson.parser.ContentModel this GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; ALOAD_1 // java.lang.String token IF_ACMPNE L13 ICONST_1 (line 219) ISTORE_3 // boolean retval GOTO L17 L13: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 220) GETFIELD org.apache.crimson.parser.ContentModel.content Ljava/lang/Object; CHECKCAST org.apache.crimson.parser.ContentModel ALOAD_1 // java.lang.String token INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.first (Ljava/lang/String;)Z IFEQ L14 ICONST_1 (line 221) ISTORE_3 // boolean retval GOTO L17 L14: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 222) GETFIELD org.apache.crimson.parser.ContentModel.next Lorg/apache/crimson/parser/ContentModel; IFNULL L15 ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 223) GETFIELD org.apache.crimson.parser.ContentModel.next Lorg/apache/crimson/parser/ContentModel; ALOAD_1 // java.lang.String token INVOKEVIRTUAL org.apache.crimson.parser.ContentModel.first (Ljava/lang/String;)Z ISTORE_3 // boolean retval GOTO L17 L15: ICONST_0 (line 225) ISTORE_3 // boolean retval GOTO L17 (line 226) L16: NEW java.lang.InternalError (line 229) DUP INVOKESPECIAL java.lang.InternalError.<init> ()V ATHROW L17: ILOAD_3 // boolean retval (line 233) IFEQ L18 ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 234) GETFIELD org.apache.crimson.parser.ContentModel.cache Lorg/apache/crimson/parser/SimpleHashtable; ALOAD_1 // java.lang.String token GETSTATIC java.lang.Boolean.TRUE Ljava/lang/Boolean; INVOKEVIRTUAL org.apache.crimson.parser.SimpleHashtable.put (Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Obj ect; POP GOTO L19 L18: ALOAD_0 // org.apache.crimson.parser.ContentModel this (line 236) GETFIELD org.apache.crimson.parser.ContentModel.cache Lorg/apache/crimson/parser/SimpleHashtable; ALOAD_1 // java.lang.String token GETSTATIC java.lang.Boolean.FALSE Ljava/lang/Boolean; INVOKEVIRTUAL org.apache.crimson.parser.SimpleHashtable.put (Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Obj ect; POP L19: ILOAD_3 // boolean retval (line 238) IRETURN end public boolean first(String) end final class org.apache.crimson.parser.ContentModel

verified fixed

fabf159

["loadtime/src/org/aspectj/weaver/loadtime/definition/DocumentParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 116305 Unexpected error: can't determine implemented interfaces of missing type

I have reusable library code that imports a type (a JAX-RPC Call in this case) for use in two ways: 1) matching in a method signature. 2) casting and use in an advice body It used to work properly when I used it in a load-time weaving configuration without the (Call) type being available on the classpath (I think it broke in the last week). However, I am now getting an abort error "can't determine implemented interfaces of missing type" when weaving this aspect into another type when the imported (Call) type isnt visible in a classloader. I tried changing the code to remove the import and to use a fully qualified name in the pointcut (and a reflective invocation in the advice body). However, this still fails in the same way. These pointcuts are presumably causing the error: public abstract aspect AbstractRequestMonitor { protected pointcut scope() : within(*);//if(true); protected pointcut monitorEnabled() : isMonitorEnabled() && scope(); protected abstract pointcut isMonitorEnabled(); ... } public abstract aspect AbstractResourceMonitor extends AbstractRequestMonitor { ... } public aspect RemoteCallMonitor extends AbstractResourceMonitor { protected pointcut isMonitorEnabled() : if(aspectOf().isEnabled()); public pointcut jaxRpcClientCall(Object wsCallObj) : call(public * javax.xml.rpc.Call.invoke*(..)) && target(wsCallObj); Object around(final Object wsCallObj) : jaxRpcClientCall(wsCallObj) && monitorEnabled() { ... Here is the output: org.aspectj.bridge.AbortException: can't determine implemented interfaces of missing type javax.xml.rpc.Call when matching pointcut ((((within(*) && call(public * javax.xml.rpc.Call.invoke* (..))) && target(BindingTypePattern(java.lang.Object, 0))) && if(boolean glassbox.inspector.monitor.resource.RemoteCallMonitor.ajc$if_12())) && persingleton(glassbox.inspector.monitor.resource.RemoteCallMonitor)) when matching shadow method-call(java.util.Locale java.util.Locale.getDefault()) when weaving type org.apache.struts.action.ActionServlet when weaving classes when weaving at org.aspectj.weaver.tools.WeavingAdaptor$WeavingAdaptorMessageHandler.handleMessa ge(WeavingAdaptor.java:364) at org.aspectj.bridge.MessageUtil.error(MessageUtil.java:81) at org.aspectj.weaver.MissingResolvedTypeWithKnownSignature.raiseCantFindType (MissingResolvedTypeWithKnownSignature.java:195) at org.aspectj.weaver.MissingResolvedTypeWithKnownSignature.getDeclaredInterfaces (MissingResolvedTypeWithKnownSignature.java:77) at org.aspectj.weaver.ResolvedType.getDirectSupertypes (ResolvedType.java:64) at org.aspectj.weaver.ReferenceType.isAssignableFrom (ReferenceType.java:312) at org.aspectj.weaver.ReferenceType.isAssignableFrom (ReferenceType.java:236) at org.aspectj.weaver.patterns.KindedPointcut.warnOnConfusingSig (KindedPointcut.java:151) at org.aspectj.weaver.patterns.KindedPointcut.matchInternal (KindedPointcut.java:108) at org.aspectj.weaver.patterns.Pointcut.match(Pointcut.java:145) at org.aspectj.weaver.patterns.AndPointcut.matchInternal (AndPointcut.java:57) at org.aspectj.weaver.patterns.Pointcut.match(Pointcut.java:145) at org.aspectj.weaver.patterns.AndPointcut.matchInternal (AndPointcut.java:55) at org.aspectj.weaver.patterns.Pointcut.match(Pointcut.java:145) at org.aspectj.weaver.patterns.AndPointcut.matchInternal (AndPointcut.java:55) at org.aspectj.weaver.patterns.Pointcut.match(Pointcut.java:145) at org.aspectj.weaver.patterns.AndPointcut.matchInternal (AndPointcut.java:55) at org.aspectj.weaver.patterns.Pointcut.match(Pointcut.java:145) at org.aspectj.weaver.ShadowMunger.match(ShadowMunger.java:64) at org.aspectj.weaver.Advice.match(Advice.java:109) at org.aspectj.weaver.bcel.BcelAdvice.match(BcelAdvice.java:98) at org.aspectj.weaver.bcel.BcelClassWeaver.match (BcelClassWeaver.java:2098) at org.aspectj.weaver.bcel.BcelClassWeaver.matchInvokeInstruction (BcelClassWeaver.java:2085) at org.aspectj.weaver.bcel.BcelClassWeaver.match (BcelClassWeaver.java:1867) at org.aspectj.weaver.bcel.BcelClassWeaver.matchInit (BcelClassWeaver.java:1731) at org.aspectj.weaver.bcel.BcelClassWeaver.match (BcelClassWeaver.java:1660) at org.aspectj.weaver.bcel.BcelClassWeaver.weave (BcelClassWeaver.java:445) at org.aspectj.weaver.bcel.BcelClassWeaver.weave (BcelClassWeaver.java:101) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1531) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump (BcelWeaver.java:1485) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify (BcelWeaver.java:1266) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1088) at org.aspectj.weaver.tools.WeavingAdaptor.getWovenBytes (WeavingAdaptor.java:266) at org.aspectj.weaver.tools.WeavingAdaptor.weaveClass (WeavingAdaptor.java:198) at org.aspectj.weaver.loadtime.Aj.preProcess(Aj.java:67) at org.aspectj.weaver.loadtime.ClassPreProcessorAgentAdapter.transform (ClassPreProcessorAgentAdapter.java:52) ...

resolved fixed

676aa08

["weaver/src/org/aspectj/weaver/patterns/KindedPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 115235 StackOverflowError on circular pointcut iff aspect parameterized

The code below overflows when concretizing a circular pointcut from a parameterized aspect. Not true when the aspect is not parameterized. --------------------------------------------- public class SelfPC { public static void main(String[] args) { new C().foo(); } static class C { pointcut doit() : C.doit(); // CE expected void foo() {} } // ------------ pertarget<T> static abstract aspect PT_PARM<T> pertarget(pc()) { abstract protected pointcut pc(); before() : pc() {} } static aspect CPT_PARM extends PT_PARM<C> { protected pointcut pc() : C.doit(); } // // ------------ issingleton<T> // static abstract aspect IS_PARM<T> { // abstract protected pointcut pc(); // before() : pc() {} // } // static aspect CIS_PARM extends IS_PARM<C> { // protected pointcut pc() : C.doit(); // } // // ------------ pertarget // static abstract aspect PT pertarget(pc()) { // abstract protected pointcut pc(); // before() : pc() {} // } // static aspect CPT extends PT{ // protected pointcut pc() : C.doit(); // } // // ------------ issingleton // static abstract aspect SIS { // abstract protected pointcut pc(); // before() : pc() {} // } // static aspect CSIS extends SIS { // protected pointcut pc() : C.doit(); // } } --------------------------------------------- java.lang.StackOverflowError at java.lang.StringBuffer.append(StringBuffer.java:225) at org.aspectj.weaver.UnresolvedType.nameToSignature(UnresolvedType.java:734) at org.aspectj.weaver.UnresolvedType.forName(UnresolvedType.java:308) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.fromBinding(EclipseFactory.java:302) at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.fromEclipse(EclipseFactory.java:129) at org.aspectj.ajdt.internal.compiler.lookup.EclipseSourceType.getSuperclass(EclipseSourceType.java:119) at org.aspectj.weaver.ReferenceType.getSuperclass(ReferenceType.java:481) at org.aspectj.weaver.ResolvedType.getDirectSupertypes(ResolvedType.java:65) at org.aspectj.weaver.ResolvedType$6.get(ResolvedType.java:447) at org.aspectj.weaver.Iterators$4.next(Iterators.java:148) at org.aspectj.weaver.Iterators$3$1.hasNext(Iterators.java:117) at org.aspectj.weaver.Iterators$3.hasNext(Iterators.java:128) at org.aspectj.weaver.ResolvedType.findPointcut(ResolvedType.java:466) at org.aspectj.weaver.patterns.ReferencePointcut.concretize1(ReferencePointcut.java:269) at org.aspectj.weaver.patterns.Pointcut.concretize(Pointcut.java:229) at org.aspectj.weaver.patterns.ReferencePointcut.concretize1(ReferencePointcut.java:326) at org.aspectj.weaver.patterns.Pointcut.concretize(Pointcut.java:229) ... ---------------------------------------------

resolved fixed

4b8bed7

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/Pointcut.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 113118 ClassFormatException with tracing aspect

Build id: 20051017111807 AspectJ version: 1.5.0.200510141300 The following aspect resulted in the CFE: public aspect CallTrace { /** * A marker interface used to pick the classes to trace. Declare any class you want to * trace to implement this interface. The best way is using an aspect like the one in * the class comment block above. */ public static interface Traced {} /** * A marker annoation, can be used instead of {@link Traced}. */ @Documented @Retention(RetentionPolicy.RUNTIME) @Target({ElementType.TYPE, ElementType.ANNOTATION_TYPE}) public @interface TracedAnno {} private static Level level = Level.INFO; /** * Set the global logging level used for reporting traced calls. Defaults to INFO. * @param newLevel */ public static void setLevel (Level newLevel) { level = newLevel; } /** * @return the Level used for writing traced output. */ public static Level getLevel () { return level; } private static Logger log = Logger.getLogger(Traced.class); private int nesting = 0; private static StringBuffer prefixStr = null; static { new StringBuffer(1024); for (int i=0; i<128; i++) { // stuff with "+". prefixStr.append("++++++++"); } } public pointcut exclusions(): within(CallTrace) || within(*Tracer); // Distinguish between initialization JPs and other method calls, to work // around AJ limitation that around advice isn't supported for initializations. public pointcut traceIntfInit(): initialization(Traced+.new(..)); public pointcut traceIntf(): call(* Traced+.*(..)); public pointcut traceAnnoInit(): initialization(com.adteractive..*.new(..)) && @target(TracedAnno); public pointcut traceAnno(): call(* com.adteractive..*.*(..)) && @target(TracedAnno); public pointcut traceInit(): !exclusions() && (traceIntfInit() || traceAnnoInit()); public pointcut trace(): !exclusions() && (traceIntf() || traceAnno()); before(): traceInit() { nesting++; String pre = prefixStr.substring(0,nesting); log.log (level, pre+"> "+thisJoinPointStaticPart); } after(): traceInit() { String pre = prefixStr.substring(0,nesting); log.log (level, pre+"< "+thisJoinPointStaticPart); nesting--; } Object around(): trace() { nesting++; String pre = prefixStr.substring(0,nesting); log.log (level, pre+"> "+thisJoinPointStaticPart); Object result = proceed(); log.log (level, pre+"< "+thisJoinPointStaticPart); nesting--; return result; } } A separate aspect is used to "declare parent" or "declare @type" either the marker interface or annotation, thereby adding tracing to the user-specified classes. E.g., public aspect CallTraceTestTracer { // declare @type: com.me.foo..*: @CallTrace.TracedAnno; declare parents: com.me.foo..* implements CallTrace.Traced; } The exception wasn't thrown in a previous version when I used just before advice for both the "trace" and "traceInit" pointcuts. org.aspectj.apache.bcel.classfile.ClassFormatException at org.aspectj.apache.bcel.classfile.Utility.typeOfSignature(Utility.java:1293) at org.aspectj.apache.bcel.generic.Type.getTypeInternal(Type.java:166) at org.aspectj.apache.bcel.generic.Type.getTypeInternal(Type.java:174) at org.aspectj.apache.bcel.generic.Type.getType(Type.java:155) at org.aspectj.weaver.bcel.BcelWorld.makeBcelType(BcelWorld.java:198) at org.aspectj.weaver.bcel.BcelShadow.createMethodGen(BcelShadow.java:2999) at org.aspectj.weaver.bcel.BcelShadow.extractMethod(BcelShadow.java:2826) at org.aspectj.weaver.bcel.BcelShadow.weaveAroundInline(BcelShadow.java:2020) at org.aspectj.weaver.bcel.BcelAdvice.implementOn(BcelAdvice.java:211) at org.aspectj.weaver.Shadow.implementMungers(Shadow.java:514) at org.aspectj.weaver.Shadow.implement(Shadow.java:391) at org.aspectj.weaver.bcel.BcelClassWeaver.implement(BcelClassWeaver.java:1781) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:394) at org.aspectj.weaver.bcel.BcelClassWeaver.weave(BcelClassWeaver.java:98) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1464) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump(BcelWeaver.java:1429) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:1203) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1039) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave(AjCompilerAdapter.java:300) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling(AjCompilerAdapter.java:178) at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$afterReturning$org_aspectj_ajdt_internal_compiler_CompilerAdapter$2$f9cc9ca0(CompilerAdapter.aj:70) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:367) at org.aspectj.a jdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:759) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:249) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.incrementalBuild(AjBuildManager.java:158) at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:117) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run(AspectJBuildManager.java:191) trouble in: public class com.adteractive.framework.test.ConditionTestFilterTest extends junit.framework.TestCase: com.adteractive.framework.ConditionTestFilter ctf [Signature(Lcom/adteractive/framework/ConditionTestFilter<Lcom/adteractive/framework/test/InputStub;Lcom/adteractive/framework/test/OutputStub;>;)] static Class class$0 private static final org.aspectj.lang.JoinPoint$StaticPart ajc$tjp_0 public void <init>(): ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 16) INVOKESPECIAL junit.framework.TestCase.<init> ()V constructor-execution(void com.adteractive.framework.test.ConditionTestFilterTest.<init>()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 17) | ACONST_NULL | PUTFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | RETURN (line 16) constructor-execution(void com.adteractive.framework.test.ConditionTestFilterTest.<init>()) end public void <init>() protected void setUp() throws java.lang.Exception org.aspectj.weaver.MethodDeclarationLineNumber: 23:543 : method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.setUp()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 24) | INVOKESPECIAL junit.framework.TestCase.setUp ()V | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 25) | NEW com.adteractive.framework.test.ConditionTestFilterStub | DUP | LDC "ctf" | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this | ASTORE_1 | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) | | ALOAD_1 | | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterTest.makeBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterStub.<init> (Ljava/lang/String;[Lcom/adteractive/framework/Filter;)V | PUTFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | RETURN (line 26) method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.setUp()) end protected void setUp() throws java.lang.Exception public void testExecute() org.aspectj.weaver.MethodDeclarationLineNumber: 31:754 : method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testExecute()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 32) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | NEW com.adteractive.framework.test.InputStub | DUP | INVOKESPECIAL com.adteractive.framework.test.InputStub.<init> ()V | method-call(com.adteractive.framework.Output com.adteractive.framework.ConditionTestFilter.execute(com.adteractive.framework.Input)) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.execute (Lcom/adteractive/framework/Input;)Lcom/adteractive/framework/Output; | method-call(com.adteractive.framework.Output com.adteractive.framework.ConditionTestFilter.execute(com.adteractive.framework.Input)) | CHECKCAST com.adteractive.framework.test.OutputStub | ASTORE_1 | LDC "bf12" (line 33) | ALOAD_1 // com.adteractive.framework.test.OutputStub output | method-call(com.adteractive.framework.Status com.adteractive.framework.test.OutputStub.getStatus()) | | INVOKEVIRTUAL com.adteractive.framework.test.OutputStub.getStatus ()Lcom/adteractive/framework/Status; | method-call(com.adteractive.framework.Status com.adteractive.framework.test.OutputStub.getStatus()) | method-call(java.lang.String com.adteractive.framework.Status.getAdditionalMessage()) | | INVOKEINTERFACE com.adteractive.framework.Status.getAdditionalMessage ()Ljava/lang/String; | method-call(java.lang.String com.adteractive.framework.Status.getAdditionalMessage()) | method-call(void junit.framework.Assert.assertEquals(java.lang.String, java.lang.String)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertEquals (Ljava/lang/String;Ljava/lang/String;)V | method-call(void junit.framework.Assert.assertEquals(java.lang.String, java.lang.String)) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 34) | NEW com.adteractive.framework.test.ConditionTestFilterStub | DUP | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterStub.<init> ()V | PUTFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 35) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | NEW com.adteractive.framework.test.InputStub | DUP | INVOKESPECIAL com.adteractive.framework.test.InputStub.<init> ()V | method-call(com.adteractive.framework.Output com.adteractive.framework.ConditionTestFilter.execute(com.adteractive.framework.Input)) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.execute (Lcom/adteractive/framework/Input;)Lcom/adteractive/framework/Output; | method-call(com.adteractive.framework.Output com.adteractive.framework.ConditionTestFilter.execute(com.adteractive.framework.Input)) | CHECKCAST com.adteractive.framework.test.OutputStub | ASTORE_1 // com.adteractive.framework.test.OutputStub output | ALOAD_1 // com.adteractive.framework.test.OutputStub output (line 36) | method-call(void junit.framework.Assert.assertNotNull(java.lang.Object)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertNotNull (Ljava/lang/Object;)V | method-call(void junit.framework.Assert.assertNotNull(java.lang.Object)) | RETURN (line 37) method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testExecute()) end public void testExecute() public void testGetFilterBranches() org.aspectj.weaver.MethodDeclarationLineNumber: 42:1111 : method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testGetFilterBranches()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 43) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | method-call(void junit.framework.Assert.assertNotNull(java.lang.Object)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertNotNull (Ljava/lang/Object;)V | method-call(void junit.framework.Assert.assertNotNull(java.lang.Object)) | ICONST_3 (line 44) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | ARRAYLENGTH | method-call(void junit.framework.Assert.assertEquals(int, int)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertEquals (II)V | method-call(void junit.framework.Assert.assertEquals(int, int)) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 45) | NEW com.adteractive.framework.test.ConditionTestFilterStub | DUP | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterStub.<init> ()V | PUTFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 46) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | method-call(void junit.framework.Assert.assertNull(java.lang.Object)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertNull (Ljava/lang/Object;)V | method-call(void junit.framework.Assert.assertNull(java.lang.Object)) | RETURN (line 47) method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testGetFilterBranches()) end public void testGetFilterBranches() public void testSetFilterBranches() org.aspectj.weaver.MethodDeclarationLineNumber: 52:1441 : method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testSetFilterBranches()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 53) | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) | | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterTest.makeBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) | ASTORE_1 | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 54) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | ALOAD_1 // com.adteractive.framework.Filter[] branches | method-call(void com.adteractive.framework.ConditionTestFilter.setFilterBranches(com.adteractive.framework.Filter[])) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.setFilterBranches ([Lcom/adteractive/framework/Filter;)V | method-call(void com.adteractive.framework.ConditionTestFilter.setFilterBranches(com.adteractive.framework.Filter[])) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 55) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | method-call(void junit.framework.Assert.assertNotNull(java.lang.Object)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertNotNull (Ljava/lang/Object;)V | method-call(void junit.framework.Assert.assertNotNull(java.lang.Object)) | ICONST_3 (line 56) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | ARRAYLENGTH | method-call(void junit.framework.Assert.assertEquals(int, int)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertEquals (II)V | method-call(void junit.framework.Assert.assertEquals(int, int)) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 57) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | ACONST_NULL | method-call(void com.adteractive.framework.ConditionTestFilter.setFilterBranches(com.adteractive.framework.Filter[])) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.setFilterBranches ([Lcom/adteractive/framework/Filter;)V | method-call(void com.adteractive.framework.ConditionTestFilter.setFilterBranches(com.adteractive.framework.Filter[])) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 58) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | method-call(void junit.framework.Assert.assertNull(java.lang.Object)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertNull (Ljava/lang/Object;)V | method-call(void junit.framework.Assert.assertNull(java.lang.Object)) | RETURN (line 59) method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testSetFilterBranches()) end public void testSetFilterBranches() public void testConditionTestFilter() org.aspectj.weaver.MethodDeclarationLineNumber: 64:1847 : method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testConditionTestFilter()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 65) | NEW com.adteractive.framework.test.ConditionTestFilterStub | DUP | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterStub.<init> ()V | PUTFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 66) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | method-call(void junit.framework.Assert.assertNull(java.lang.Object)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertNull (Ljava/lang/Object;)V | method-call(void junit.framework.Assert.assertNull(java.lang.Object)) | LDC com.adteractive.framework.test.ConditionTestFilterStub (line 67) | method-call(java.lang.String java.lang.Class.getSimpleName()) | | INVOKEVIRTUAL java.lang.Class.getSimpleName ()Ljava/lang/String; | method-call(java.lang.String java.lang.Class.getSimpleName()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(java.lang.String com.adteractive.framework.FilterHelper.getName()) | | INVOKEVIRTUAL com.adteractive.framework.FilterHelper.getName ()Ljava/lang/String; | method-call(java.lang.String com.adteractive.framework.FilterHelper.getName()) | method-call(void junit.framework.Assert.assertEquals(java.lang.String, java.lang.String)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertEquals (Ljava/lang/String;Ljava/lang/String;)V | method-call(void junit.framework.Assert.assertEquals(java.lang.String, java.lang.String)) | RETURN (line 68) method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testConditionTestFilter()) end public void testConditionTestFilter() public void testConditionTestFilterString() org.aspectj.weaver.MethodDeclarationLineNumber: 73:2158 : method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testConditionTestFilterString()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 74) | NEW com.adteractive.framework.test.ConditionTestFilterStub | DUP | LDC "foo" | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterStub.<init> (Ljava/lang/String;)V | PUTFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 75) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | method-call(void junit.framework.Assert.assertNull(java.lang.Object)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertNull (Ljava/lang/Object;)V | method-call(void junit.framework.Assert.assertNull(java.lang.Object)) | LDC "foo" (line 76) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(java.lang.String com.adteractive.framework.FilterHelper.getName()) | | INVOKEVIRTUAL com.adteractive.framework.FilterHelper.getName ()Ljava/lang/String; | method-call(java.lang.String com.adteractive.framework.FilterHelper.getName()) | method-call(void junit.framework.Assert.assertEquals(java.lang.String, java.lang.String)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertEquals (Ljava/lang/String;Ljava/lang/String;)V | method-call(void junit.framework.Assert.assertEquals(java.lang.String, java.lang.String)) | RETURN (line 77) method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testConditionTestFilterString()) end public void testConditionTestFilterString() public void testConditionTestFilterStringFilterOfIOArray() org.aspectj.weaver.MethodDeclarationLineNumber: 82:2456 : method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testConditionTestFilterStringFilterOfIOArray()) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 83) | NEW com.adteractive.framework.test.ConditionTestFilterStub | DUP | LDC "foo" | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) | | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterTest.makeBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) | INVOKESPECIAL com.adteractive.framework.test.ConditionTestFilterStub.<init> (Ljava/lang/String;[Lcom/adteractive/framework/Filter;)V | PUTFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this (line 84) | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | method-call(void junit.framework.Assert.assertNotNull(java.lang.Object)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertNotNull (Ljava/lang/Object;)V | method-call(void junit.framework.Assert.assertNotNull(java.lang.Object)) | ICONST_3 (line 85) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | | INVOKEVIRTUAL com.adteractive.framework.ConditionTestFilter.getFilterBranches ()[Lcom/adteractive/framework/Filter; | method-call(com.adteractive.framework.Filter[] com.adteractive.framework.ConditionTestFilter.getFilterBranches()) | ARRAYLENGTH | method-call(void junit.framework.Assert.assertEquals(int, int)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertEquals (II)V | method-call(void junit.framework.Assert.assertEquals(int, int)) | LDC "foo" (line 86) | ALOAD_0 // com.adteractive.framework.test.ConditionTestFilterTest this | GETFIELD com.adteractive.framework.test.ConditionTestFilterTest.ctf Lcom/adteractive/framework/ConditionTestFilter; | method-call(java.lang.String com.adteractive.framework.FilterHelper.getName()) | | INVOKEVIRTUAL com.adteractive.framework.FilterHelper.getName ()Ljava/lang/String; | method-call(java.lang.String com.adteractive.framework.FilterHelper.getName()) | method-call(void junit.framework.Assert.assertEquals(java.lang.String, java.lang.String)) | | INVOKESTATIC com.adteractive.framework.test.ConditionTestFilterTest.assertEquals (Ljava/lang/String;Ljava/lang/String;)V | method-call(void junit.framework.Assert.assertEquals(java.lang.String, java.lang.String)) | RETURN (line 87) method-execution(void com.adteractive.framework.test.ConditionTestFilterTest.testConditionTestFilterStringFilterOfIOArray()) end public void testConditionTestFilterStringFilterOfIOArray() private com.adteractive.framework.Filter[] makeBranches() org.aspectj.weaver.MethodDeclarationLineNumber: 89:2749 : method-execution(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) | ICONST_3 (line 90) | ANEWARRAY com.adteractive.framework.test.FilterHelperStub | ASTORE_1 | ALOAD_1 // com.adteractive.framework.Filter[] branches (line 91) | ICONST_0 | NEW com.adteractive.framework.test.FilterHelperStub | DUP | LDC "bf1" | INVOKESPECIAL com.adteractive.framework.test.FilterHelperStub.<init> (Ljava/lang/String;)V | AASTORE | ALOAD_1 // com.adteractive.framework.Filter[] branches (line 92) | ICONST_1 | NEW com.adteractive.framework.test.FilterHelperStub | DUP | LDC "bf12" | INVOKESPECIAL com.adteractive.framework.test.FilterHelperStub.<init> (Ljava/lang/String;)V | AASTORE | ALOAD_1 // com.adteractive.framework.Filter[] branches (line 93) | ICONST_2 | NEW com.adteractive.framework.test.FilterHelperStub | DUP | LDC "bf" | INVOKESPECIAL com.adteractive.framework.test.FilterHelperStub.<init> (Ljava/lang/String;)V | AASTORE | ALOAD_1 // com.adteractive.framework.Filter[] branches (line 94) | ARETURN method-execution(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) end private com.adteractive.framework.Filter[] makeBranches() end public class com.adteractive.framework.test.ConditionTestFilterTest when implementing on shadow method-call(com.adteractive.framework.Filter[] com.adteractive.framework.test.ConditionTestFilterTest.makeBranches()) when weaving type com.adteractive.framework.test.ConditionTestFilterTest when weaving classes when weaving when incrementally building BuildConfig[C:\cygwin\home\dwampler\work\workspace\.metadata\.plugins\org.eclipse.ajdt.core\adserver-service.generated.lst] #Files=259

resolved fixed

d7d5947

["weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 112756 ajdt compiler generate false warnings

I was working on aspect that should raise an error for junit test methods that didn't use any assertions. Apparently I had to use pointcut like "call(void Assert+.assert*(..))" on which ajdt compiler complained about using "assert" keyword. I don't think such warning should be shown in such case. Anyway, here is the complete aspect code. import junit.framework.Test; import junit.framework.Assert; import junit.framework.AssertionFailedError; public aspect AssertionCounter { private ThreadLocal counts = new ThreadLocal(); public pointcut testMethodExecution() : execution(void Test+.test*()); public pointcut assertCall() : cflow(testMethodExecution()) && call(void Assert+.assert*(..)); void around() : testMethodExecution() { counts.set( new Counter()); proceed(); if(((Counter) counts.get()).getCount()==0) { throw new AssertionFailedError("No assertions had been called"); } } before() : assertCall() { ((Counter) counts.get()).inc(); } }

resolved fixed

7a1002a

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 112830 Warning "couldn't find aspectjrt.jar on classpath"

The compiler makes this warning if "aspectrt.jar" file has a different name like "aspectrt-1.3.jar", which is the case when compiling with maven.

resolved fixed

1f51499

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 114005 annotated ITD fields on interfaces have no annotation

resolved fixed

d9757d7

["tests/bugs150/pr114005/Declaration1.java", "tests/bugs150/pr114005/Declaration2.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 90143 [itds] Problem with an ITD on an interface

If an ITD method is declared on an interface with an anonymous inner class returned as the result, the compiler generates an error for any "super.xxx" calls in the anonymous inner class. The example project shows this with a nested inner interface, but the same problem occurs with an ITD of this kind on any interface. The error does not occur if the ITD is declared on an inner class (as shown in the example) or a normal class.

resolved fixed

21cf37d

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterSuperFixerVisitor.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 112476 "declare parents" does not work with bytecode weaving

resolved fixed

a7e13f1

["tests/bugs150/pr112476/case1/lib/A.java", "tests/bugs150/pr112476/case1/lib/B.java", "tests/bugs150/pr112476/case1/lib/C.java", "tests/bugs150/pr112476/case1/weaved/SuperC.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 114744 NPE at CaptureBinding.java on wildcard in intertype field type

When compiling this program with ajc -1.5 public aspect Wildcard { Class<? extends Wildcard> Wildcard.cl; void foo() throws Exception { Wildcard ci = cl.newInstance(); } } ajc throws this exception java.lang.NullPointerException at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.CaptureBinding.initializeBounds(CaptureBinding.java:75) at org.aspectj.org.eclipse.jdt.internal.compiler.lookup.ParameterizedTypeBinding.capture(ParameterizedTypeBinding.java:105) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.SingleNameReference.resolveType(SingleNameReference.java:772) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.MessageSend.resolveType(MessageSend.java:293) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:199) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:422) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:178) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:400) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1076) at org.aspectj.ajdt.internal.compiler.ast.AspectDeclaration.resolve(AspectDeclaration.java:114) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1125) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:305) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:514) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:329) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:759) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:225) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:151) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:112) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:60) at org.aspectj.tools.ajc.Main.run(Main.java:326) at org.aspectj.tools.ajc.Main.runMain(Main.java:240) at org.aspectj.tools.ajc.Main.main(Main.java:83)

resolved fixed

ade32bc

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 113510 readAspect

clearly define what the goal for readAspect is old byte per byte reading cause NPE in some test case current impl is hashcode for aspect name + classloader - ie unstable across startups.

resolved fixed

62d16d5

["loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108892 Load Time Weaving problem with Aspect Definition at 2 Levels of Hierarchy

I am trying to weave into Tomcat with a system-level aspect (META-INF/aop.xml is found in a jar on the system classpath), and also have a Web application with an aop.xml properly deployed. When I try to run them both together, only the system-level aspects work. If I remove the system-level aspect jar from the classpath, the application-level aspects work. What would be a reasonable way to isolate this into a test case? If I could package up a simple system.jar and app.war file for Tomcat 5.5.9, would that be useful for you to use in debugging it? I tried making a simple standalone version with 2 aop.xml files in the same app classloader but that works just fine.

resolved fixed

794f9b5

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/ValidateAtAspectJAnnotationsVisitor.java", "tests/java5/ataspectj/ataspectj/hierarchy/AppContainerTest.java", "tests/java5/ataspectj/ataspectj/hierarchy/app/SubApp.java", "tests/src/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java", "weaver/src/org/aspectj/weaver/bcel/AtAjAttributes.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 113861 [generics] field-get problems when generic field is used.

Hi, When i'm compiling the following example, i'm getting this errors: TestAspect.aj:21 [error] incompatible return type applying to field-get (java.util.Set com.mprv.secsph.Test.intsSet) Test.java:18 [error] incompatible return type applying to field-get (java.util.Set com.mprv.secsph.Test.intsSet) Here is the example ------------------- Java Code: package com; public class Test { Set<Integer> intsSet; public Set<Integer> foo() { 18: return intsSet; } } Aspect: public privileged aspect TestAspect { pointcut gettingMember(Test t) : target(t) && get(!public Set<Integer> com.*.*) && !within(TestAspect); 21: Set<Integer> around(Test t) : gettingMemberCollection(t) { Set s = proceed(t); return s; } } I've tried many kinds of workarounds, and the only thing which worked, is defining the member field without using generics (regular Set) ... One more disturbing is, that this fiture worked(!) in M2 release. This is an example of the functionality that worked in my project (with M2), but now, also reports the same error: Java code is the same, Aspect is: public privileged aspect TestAspect { pointcut gettingMember(Test t) : target(t) && get(!public Set com.*.*) && !within(TestAspect); Set around(Test t) : gettingMemberCollection(t) { Set s = proceed(t); return s; } } Is it a bug? Or am i doing something wrong? Thanks! Misha.

resolved fixed

8cea30f

["tests/bugs150/pr113861/Test.java", "tests/bugs150/pr113861/TestAspect.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/Advice.java", "weaver/src/org/aspectj/weaver/Member.java", "weaver/src/org/aspectj/weaver/MemberImpl.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 99191 declare @field allowed for non existent fields

///// in this code @interface anInterface{} aspect B { declare @field : int B.noSuchField : @anInterface; // should be an error } ////////////////// I don't get an error, even though B.noSuchField doesn't exist. If I try declare @field on NoSuchCLass.noSuchField I do get an error though.

resolved fixed

2da9b31

["tests/bugs150/pr99191/pr99191_1.java", "tests/bugs150/pr99191/pr99191_2.java", "tests/bugs150/pr99191/pr99191_3.java", "tests/bugs150/pr99191/pr99191_4.java", "tests/bugs150/pr99191/pr99191_5.java", "tests/bugs150/pr99191/pr99191_6.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 112615 -XhasMember is not processed correctly when passed from AJDT

To test this in AJDT install the bean example, add a new interface called I and then add the following line to BoundPoint.aj: declare parents: hasmethod(* set*(..)) implements I; Now open the AspectJ Compiler preference page and select "Has Member" on the advanced tab. Click OK, rebuild and if the option was working the project would build correctly. As it stands there is an error: the type pattern hasmethod(* set*(..)) can only be used when the -XhasMember option is set

resolved fixed

cc6862f

["ajde/testsrc/org/aspectj/ajde/BuildConfigurationTests.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildConfig.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 113511 LTW enhancements

Alex, here is the basic patch that is working well before you leave for the weekend ;-) I'll let Matthew post it officially to bugzilla since it was his idea. The earlier return from !enabled is a small addition I made that seems to help further. It would be great to have this in HEAD so I can report performance numbers based on it in part 2 of my article on developerworks ;-) Hope you are enjoying your new addition! Thanks! Index: ClassLoaderWeavingAdaptor.java =================================================================== RCS file: /home/technology/org.aspectj/modules/loadtime/src/org/aspectj/weaver/loadtim e/ClassLoaderWeavingAdaptor.java,v retrieving revision 1.18 diff -u -r1.18 ClassLoaderWeavingAdaptor.java --- ClassLoaderWeavingAdaptor.java 19 Oct 2005 13:11:36 -0000 1.18 +++ ClassLoaderWeavingAdaptor.java 21 Oct 2005 16:04:41 -0000 @@ -107,8 +107,13 @@ // register the definitions registerDefinitions(weaver, loader); + if (!enabled) { + return; + } messageHandler = bcelWorld.getMessageHandler(); + bcelWorld.setResolutionLoader((ClassLoader)null);//loader.getParent()); + // after adding aspects weaver.prepareForWeave(); } @@ -148,7 +153,11 @@ definitions.add(DocumentParser.parse(xml)); } } - + if (definitions.isEmpty()) { + enabled = false; + return; + } + // still go thru if definitions is empty since we will configure // the default message handler in there registerOptions(weaver, loader, definitions);

resolved fixed

70888dd

["loadtime/src/org/aspectj/weaver/loadtime/Aj.java", "loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 111915 illegal change to pointcut declaration

org.aspectj.weaver.BCException at org.aspectj.weaver.patterns.ReferencePointcut.concretize1(ReferencePointcut.java:306) at org.aspectj.weaver.patterns.Pointcut.concretize(Pointcut.java:229) at org.aspectj.weaver.patterns.ReferencePointcut.concretize1(ReferencePointcut.java:331) at org.aspectj.weaver.patterns.Pointcut.concretize(Pointcut.java:229) at org.aspectj.weaver.patterns.Pointcut.concretize(Pointcut.java:216) at org.aspectj.weaver.Advice.concretize(Advice.java:273) at org.aspectj.weaver.bcel.BcelAdvice.concretize(BcelAdvice.java:83) at org.aspectj.weaver.CrosscuttingMembers.addShadowMunger(CrosscuttingMembers.java:84) at org.aspectj.weaver.CrosscuttingMembers.addShadowMungers(CrosscuttingMembers.java:78) at org.aspectj.weaver.ResolvedType.collectCrosscuttingMembers(ResolvedType.java:462) at org.aspectj.weaver.CrosscuttingMembersSet.addOrReplaceAspect(CrosscuttingMembersSet.java:62) at org.aspectj.weaver.bcel.BcelWeaver.prepareForWeave(BcelWeaver.java:426) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave(AjCompilerAdapter.java:283) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling(AjCompilerAdapter.java:178) at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$afterReturning$org_aspectj_ajdt_internal_compiler_CompilerAdapter$2$f9cc9ca0(CompilerAdapter.aj:70) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:367) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:760) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuildManager.java:225) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:151) at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:122) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run(AspectJBuildManager.java:191) BCException thrown: illegal change to pointcut declaration: spike.np.CommandCase.handleCommand(BindingTypePattern(spike.np.OtherHandler$MyWorld, 0)) when batch building BuildConfig[/home/guido/workspace/.metadata/.plugins/org.eclipse.ajdt.core/np.generated.lst] #Files=11

resolved fixed

3021284

["tests/bugs150/pr111915.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 113073 weaveinfo messages not reported if applying declare @method on an ITD'd method

Given the following class: @interface Annotation{} aspect B { declare @method : public * C.anotherMethod(..) : @Annotation; } class C { } aspect D { public void C.anotherMethod(String s) { } public void C.anotherMethod() { } } I would expect a two weaveinfo messages of the form: weaveinfo 'public void C.anotherMethod()' (pr99191_4.java) is annotated with @Annotation method annotation from 'B' (pr99191_4.java:3) weaveinfo 'public void C.anotherMethod(String)' (pr99191_4.java) is annotated with @Annotation method annotation from 'B' (pr99191_4.java:3) However, only the two "intertyped" messages are coming out.

resolved fixed

f06df41

["tests/bugs150/pr113073.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 112027 unexpected error unboundFormalInPC

In 1.5.0M4, I get error "the parameter tis is not bound in [all branches of] pointcut". Not true of 1.2.1. Untested in other development versions of 1.5.0. No branches (all &&) but duplicate specification of this(..). ------------------------------------------ package demo; /** * PerThis */ public class PerThis { public static void main(String[] args) { new This().test(); } } aspect PerThisTest perthis(pc()) { // TutIndex example-basic-perthis pointcut pc() : this(This) && !within(PerThisTest) && call(void run()); before(This tis) : pc() && this(tis){ System.out.println("bef " + this + " <-- " + tis); } } class This { int i; void test() { run(); } void run() { System.out.println("run " + this); } }

resolved fixed

ae612d9

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/BindingTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/ExactTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 107299 -aspectpath -inpath arguments fail without drive letter

ajc doesn't recognize Windows absolute file paths that don't start with a drive letter, e.g., run: ajc -inpath \test.jar [error] build config error: bad inpath component: \test.jar but ajc -inpath c:\test.jar works ajc -aspectpath \test.jar Test.aj [error] build config error: bad aspectpath: \test.jar ajc -aspectpath c:\test.jar Test.aj (works)

resolved fixed

332a5df

["util/src/org/aspectj/util/ConfigParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 112514 ajc compile crash, not giving information which class file cause it

resolved fixed

999d9b0

["bcel-builder/src/org/aspectj/apache/bcel/classfile/ClassParser.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 112243 Compiler Core Dump with Apparent Fix

resolved fixed

04e8dca

["weaver/src/org/aspectj/weaver/World.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 56779 [ajdoc] add ajdoc support for inter-type declarations and other declare forms

Currently ajdoc only exposes the "Advises" and "Advised by" relationships from the structure model. It needs to support inter-type field and member declarations using a UI similar to how Javadoc presents inherited members. It also needs to support the other declare forms: error, warning, soft, parents, and precedence.

resolved fixed

ab6c7a5

["ajdoc/src/org/aspectj/tools/ajdoc/HtmlDecorator.java", "ajdoc/src/org/aspectj/tools/ajdoc/StructureUtil.java", "ajdoc/src/org/aspectj/tools/ajdoc/StubFileGenerator.java", "ajdoc/testdata/declareForms/DeclareCoverage.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/AjdocTests.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/CoverageTestCase.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/DeclareFormsTest.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/ExecutionTestCase.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/PatternsTestCase.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/PointcutVisibilityTest.java", "ajdoc/testsrc/org/aspectj/tools/ajdoc/SpacewarTestCase.java", "asm/src/org/aspectj/asm/IRelationship.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 92837 [inc-compilation] Incremental Compilation Fails for ITD's on Aspects

On my project, when I save an aspect that calls an inter-type declaration defined on itself, the incremental compiler gives a message like this: The method logError(String, Exception) is undefined for the type Foo Foo.java Running a full build clears the error. This might be a compiler bug, or it might be AJDT (I never run command-line incremental compilation, so I don't know :-)). Unfortunately, simple test cases or extracts of just the 2 aspects aren't reproducing the issue, so let me know if you need me to spend some time trying to create a small isolated version of the issue.

resolved fixed

727b0f5

["tests/multiIncremental/PR92837/base/sample/AbstractDerived.java", "tests/multiIncremental/PR92837/base/sample/Holder.java", "tests/multiIncremental/PR92837/inc1/sample/AbstractDerived.java", "tests/src/org/aspectj/systemtest/incremental/tools/MultiProjectIncrementalTests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 91417 -Xreweavable should be the default

In order to facilitate widespread use of LTW we need to ensure code is compiled with Xreweavable. However we cannot rely on developers to use this flag so it must be the default. Unfortunately the current code bloat is unacceptable for large projects.

resolved fixed

12e6334

["loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java", "loadtime/src/org/aspectj/weaver/loadtime/Options.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/ajc/BuildArgParser.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/core/AspectJCore.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildConfig.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjCompilerOptions.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AspectJBuilder.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/compiler/batch/BinaryFormsTestCase.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/core/builder/AjCompilerOptionsTest.java", "taskdefs/src/org/aspectj/tools/ant/taskdefs/AjcTask.java", "testing/newsrc/org/aspectj/testing/WeaveSpec.java", "testing/src/org/aspectj/testing/harness/bridge/CompilerRun.java", "tests/java5/ataspectj/ataspectj/ltwlog/MainVerboseAndShow.java", "tests/src/org/aspectj/systemtest/ajc150/ataspectj/AtAjLTWTests.java", "weaver/src/org/aspectj/weaver/WeaverStateInfo.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108117 Complete implementation of abstract generic aspects

this requires 1/ completion of the parameterizeWith implementation in the pointcut AST nodes 2/ a much more exhaustive test suite around it.

resolved fixed

451fea8

["weaver/src/org/aspectj/weaver/patterns/AnnotationPatternList.java", "weaver/src/org/aspectj/weaver/patterns/AnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ArgsAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java", "weaver/src/org/aspectj/weaver/patterns/CflowPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ConcreteCflowPointcut.java", "weaver/src/org/aspectj/weaver/patterns/DeclareAnnotation.java", "weaver/src/org/aspectj/weaver/patterns/DeclarePrecedence.java", "weaver/src/org/aspectj/weaver/patterns/HandlerPointcut.java", "weaver/src/org/aspectj/weaver/patterns/PerCflow.java", "weaver/src/org/aspectj/weaver/patterns/PerFromSuper.java", "weaver/src/org/aspectj/weaver/patterns/PerObject.java", "weaver/src/org/aspectj/weaver/patterns/PerSingleton.java", "weaver/src/org/aspectj/weaver/patterns/PerTypeWithin.java", "weaver/src/org/aspectj/weaver/patterns/Pointcut.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetPointcut.java", "weaver/src/org/aspectj/weaver/patterns/TypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WithinAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinCodeAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithincodePointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 111481 varargs doesn't work for ITD'd constructors

resolved fixed

2b0e675

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeConstructorDeclaration.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 77269 Advice on inner classes not show in Outline view or gutter

Advice associated with pointcuts that match join points in inner classes are not shown. Declare warning/error are shown however. See attached screenshot for example below. Notice WEAVEINFO messages indicate problem is in AJDT not AspectJ. Also notice phantom entry in Outline view "injar aspectL Test.java". package bug_nnnnn; public class Test { public void test () { new Runnable() { public void run() { try { throw new Exception(); } catch (Exception ex) { handleException(ex); } } }; } public static void handleException (Throwable th) { } public static void main(String[] args) { try { throw new Exception(); } catch (Exception ex) { handleException(ex); } } } aspect Aspect { declare warning : call(void handleException(..)) && !within(Aspect) : "Only Aspect should handle exceptions"; pointcut caughtExceptions (Throwable th) : handler(Throwable+) && args(th); before (Throwable th) : caughtExceptions(th) { Test.handleException(th); } }

resolved fixed

4573068

["asm/src/org/aspectj/asm/internal/AspectJElementHierarchy.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AsmHierarchyBuilder.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108118 Complete implementation of @SuppressAjWarnings

ensure that @SuppressAJWarnings are indeed suppressed during pointcut operations. This requires wrapping major pointcut operations with calls to Lint from the associated advice.

resolved fixed

81a0790

["tests/src/org/aspectj/systemtest/ajc150/SuppressedWarnings.java", "weaver/src/org/aspectj/weaver/bcel/BcelAdvice.java", "weaver/src/org/aspectj/weaver/bcel/Utility.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 101047 Weaver produces wrong local variable table bytecode

AspectJ version: DEVELOPMENT (also observed in 1.2.1) When weaving with a before or after advice, the generated local variable table will, on branch instructions, offset the "length" field of a local variable wrongly by one instruction. Also, the weaver will mix up local variables with the same name, thus violating the java VM specification: // Test.aj aspect Test { before() : ( execution(* Foo.foo(..) ) ) { System.out.println("before"); } // Foo.java public class Foo { private String myString = "A String"; public static void main(String[] args) { new Foo().foo(); } private void foo() { String myLocal = myString; if (myLocal.endsWith("X")) { String local1 = "local1"; System.out.println(local1); } else if (myLocal.endsWith("Y")) { String local2 = "local2"; System.out.println(local2); } else { String local1 = "local3"; System.out.println(local1); } } } --- We compilw with ajc -sourceroots . and dumps Foo with javap: javap -c -l -s -private Foo .... .... private void foo(); Signature: ()V Code: 0: invokestatic #65; //Method Test.aspectOf:()LTest; 3: invokevirtual #68; //Method Test.ajc$before$Test$1$f0485e90:()V 6: aload_0 7: getfield #15; //Field myString:Ljava/lang/String; 10: astore_1 11: aload_1 12: ldc #30; //String X 14: invokevirtual #36; //Method java/lang/String.endsWith: (Ljava/lang/String;)Z 17: ifeq 33 20: ldc #38; //String local1 22: astore_2 23: getstatic #44; //Field java/lang/System.out:Ljava/io/PrintStream; 26: aload_2 27: invokevirtual #50; //Method java/io/PrintStream.println: (Ljava/lang/String;)V 30: goto 65 33: aload_1 34: ldc #52; //String Y 36: invokevirtual #36; //Method java/lang/String.endsWith: (Ljava/lang/String;)Z 39: ifeq 55 42: ldc #54; //String local2 44: astore_2 45: getstatic #44; //Field java/lang/System.out:Ljava/io/PrintStream; 48: aload_2 49: invokevirtual #50; //Method java/io/PrintStream.println: (Ljava/lang/String;)V 52: goto 65 55: ldc #56; //String local3 57: astore_2 58: getstatic #44; //Field java/lang/System.out:Ljava/io/PrintStream; 61: aload_2 62: invokevirtual #50; //Method java/io/PrintStream.println: (Ljava/lang/String;)V 65: return LineNumberTable: line 7: 6 line 8: 11 line 9: 20 line 10: 23 line 11: 33 line 12: 42 line 13: 45 line 15: 55 line 16: 58 line 18: 65 LocalVariableTable: Start Length Slot Name Signature 6 60 0 this LFoo; 11 55 1 myLocal Ljava/lang/String; 45 12 2 local2 Ljava/lang/String; 23 43 2 local1 Ljava/lang/String; We see that the two occurences of the "local1" variable erroneously have been combined into one entry, starting at byte 23 and ending at byte 66. This is obviously wrong, since "local1" has no value in the "local2" block. Secondly, the "local2" variable end is wrongly offset by one instruction offset.

resolved fixed

85a4b0a

["bcel-builder/src/org/aspectj/apache/bcel/generic/MethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 101407 NullPointerException when selecting Save As in top menu

The Steps of Reproduce: 1. Open BIRT 2. New a project 3. In top menu of File, click New -> Report to create a report 4. Drag a table element from Palette into the report of Layout view 5. Save the report 6. Drag mouse to select two cells in the table 7. Select the report in Navigator view 8. In the top menu, select Save As... 9. In the Save As pop up dialog window, change the file name in the File name field, then click OK button Expected Result: There is no error to click OK button Actual Result: Error window pops up and the error log as follows: java.lang.NullPointerException at org.eclipse.gef.editparts.AbstractEditPart.getRoot (AbstractEditPart.java:587) at org.eclipse.gef.editparts.AbstractEditPart.getRoot (AbstractEditPart.java:587) at org.eclipse.gef.editparts.AbstractEditPart.getViewer (AbstractEditPart.java:637) at org.eclipse.birt.report.designer.internal.ui.editors.schematic.editparts.TableU til.getSelectionCells(TableUtil.java:258) at org.eclipse.birt.report.designer.internal.ui.editors.schematic.editparts.TableE ditPart.canMerge(TableEditPart.java:1244) at org.eclipse.birt.report.designer.internal.ui.editors.schematic.actions.MergeAct ion.calculateEnabled(MergeAction.java:51) at org.eclipse.gef.ui.actions.WorkbenchPartAction.isEnabled (WorkbenchPartAction.java:111) at org.eclipse.ui.actions.RetargetAction.setActionHandler (RetargetAction.java:249) at org.eclipse.ui.actions.RetargetAction.partActivated (RetargetAction.java:144) at org.eclipse.ui.internal.PartListenerList$1.run (PartListenerList.java:49) at org.eclipse.core.internal.runtime.InternalPlatform.run (InternalPlatform.java:616) at org.eclipse.core.runtime.Platform.run(Platform.java:747) at org.eclipse.ui.internal.PartListenerList.firePartActivated (PartListenerList.java:47) at org.eclipse.ui.internal.WorkbenchPage.firePartActivated (WorkbenchPage.java:1370) at org.eclipse.ui.internal.WorkbenchPage.setActivePart (WorkbenchPage.java:2738) at org.eclipse.ui.internal.WorkbenchPage.requestActivation (WorkbenchPage.java:2415) at org.eclipse.ui.internal.PartPane.requestActivation (PartPane.java:304) at org.eclipse.ui.internal.EditorPane.requestActivation (EditorPane.java:127) at org.eclipse.ui.internal.PartPane.handleEvent(PartPane.java:284) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:796) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:820) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:801) at org.eclipse.swt.widgets.Shell.setActiveControl(Shell.java:935) at org.eclipse.swt.widgets.Control.sendFocusEvent(Control.java:1768) at org.eclipse.swt.widgets.Control.WM_SETFOCUS(Control.java:4139) at org.eclipse.swt.widgets.Canvas.WM_SETFOCUS(Canvas.java:239) at org.eclipse.swt.widgets.Control.windowProc(Control.java:3032) at org.eclipse.swt.widgets.Display.windowProc(Display.java:3338) at org.eclipse.swt.internal.win32.OS.SetFocus(Native Method) at org.eclipse.swt.widgets.Control.forceFocus(Control.java:607) at org.eclipse.swt.widgets.Control.setFocus(Control.java:2054) at org.eclipse.swt.widgets.Composite.setFocus(Composite.java:447) at org.eclipse.gef.ui.parts.GraphicalEditor.setFocus (GraphicalEditor.java:346) at org.eclipse.ui.part.MultiPageEditorPart.setFocus (MultiPageEditorPart.java:545) at org.eclipse.ui.part.MultiPageEditorPart.setFocus (MultiPageEditorPart.java:519) at org.eclipse.ui.part.MultiPageEditorPart.setFocus (MultiPageEditorPart.java:545) at org.eclipse.ui.part.MultiPageEditorPart.setFocus (MultiPageEditorPart.java:519) at org.eclipse.ui.part.MultiPageEditorPart.pageChange (MultiPageEditorPart.java:433) at org.eclipse.birt.report.designer.ui.editors.ReportEditor.pageChange (ReportEditor.java:1179) at org.eclipse.birt.report.designer.ui.editors.ReportEditor.rebuildReportDesign (ReportEditor.java:584) at org.eclipse.birt.report.designer.ui.editors.ReportEditor.setInput (ReportEditor.java:547) at org.eclipse.birt.report.designer.ui.editors.ReportEditor.performSaveAs (ReportEditor.java:870) at org.eclipse.birt.report.designer.ui.editors.ReportEditor.doSaveAs (ReportEditor.java:812) at org.eclipse.ui.internal.SaveAsAction.run(SaveAsAction.java:64) at org.eclipse.jface.action.Action.runWithEvent(Action.java:881) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:915) at org.eclipse.jface.action.ActionContributionItem.access$2 (ActionContributionItem.java:866) at org.eclipse.jface.action.ActionContributionItem$7.handleEvent (ActionContributionItem.java:785) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:796) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2772) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2431) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1377) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1348) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench (Workbench.java:254) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:141) at org.eclipse.ui.internal.ide.IDEApplication.run (IDEApplication.java:96) at org.eclipse.core.internal.runtime.PlatformActivator$1.run (PlatformActivator.java:335) at org.eclipse.core.runtime.adaptor.EclipseStarter.run (EclipseStarter.java:273) at org.eclipse.core.runtime.adaptor.EclipseStarter.run (EclipseStarter.java:129) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.eclipse.core.launcher.Main.basicRun(Main.java:185) at org.eclipse.core.launcher.Main.run(Main.java:704) at org.eclipse.core.launcher.Main.main(Main.java:688)

closed fixed

97520cf

["bcel-builder/src/org/aspectj/apache/bcel/generic/LocalVariableGen.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java", "weaver/src/org/aspectj/weaver/bcel/LocalVariableTag.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 102933 problem with Object arrays and clone() with 1.4 .class compatibility

resolved fixed

fb428d0

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 88900 Unnecessary warning for ITDs

Consider the following aspect: public aspect RunnableDefaultImpl { public void Runnable.run() { } } (Note that it makes little sense to have a default implementation for Runnable. However, I am using it to allow easy reproduction of the bug.) Compiling this aspect leads to the following warning: ...\test\RunnableDefaultImpl.aj:9 [warning] this affected type is not exposed to the weaver: java.lang.Runnable [Xlint:type NotExposedToWeaver] public void Runnable.run() { ^^^ This warning isn't really necessary as weaver doesn't (and shouldn't) need to have Runnable exposed. In fact, everything works as expected already. Now it will be a good warning (or even error), if I was trying to introduce a new method, such as in the following aspect: public aspect RunnableDefaultImpl { public void Runnable.walk() { } }

resolved fixed

e76b370

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/ResolvedTypeMunger.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 77076 Weaving into jar fails if some of the referred classes are unavailable

I am trying to profile JDBC access in a Spring-based application. Since all the JDBC interaction is performed through Spring classes, I need to weave into spring.jar. However, many of the classes referred by spring.jar aren't available to me (I am not using the functionality implemented by many of the classes). When I try to weave into spring.jar I get errors complaining that it can't find types for those classes. I expected that ajc would ignore unknown classes unless weaving would be affected by content/API of those classes. Using jar files that refer to foreign classes that one may never have/need is a common scenario. For example, spring.jar refers to Velocity, Struts, JDO, Hibernate, Quartz classes; I am unlikely to use all of these referred frameworks in an application. This bug/limitation prevents using AspectJ with such jars. To reproduce the bug in a controlled environment, I created the following aspect which should make the weaving process a pass-thru filter (no join point is matched by the pointcut) class TemporaryClass { } public aspect NoWeaveAspect { before() : call(* TemporaryClass.*(..)) && within(org.spring..*) { } } Weaving this aspect with spring.jar should result in logically identical jar file. However, when I compile using the following command (or equivalent ant task), I get the following errors: C:\work\aop\bugs\injar-with-nonexisting-classes>ajc -version AspectJ Compiler 1.2.1rc1 built on Friday Oct 22, 2004 at 13:31:47 GMT C:\work\aop\bugs\injar-with-nonexisting-classes>ajc -injars spring.jar -outjar s pring-woven.jar NoWeaveAspect.java C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.quartz.xml.JobSchedulingDataProcessor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.quartz.StatefulJob (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.quartz.SimpleTrigger (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe freemarker.cache.TemplateLoader (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.quartz.CronTrigger (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.quartz.JobDetail (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.quartz.Job (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.quartz.impl.jdbcjobstore.JobStoreCMT (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.struts.action.PlugIn (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.velocity.tools.generic.NumberTool (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.struts.action.Action (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.struts.tiles.TilesRequestProcessor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.struts.action.RequestProcessor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.velocity.runtime.resource.loader.ResourceLoader (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.velocity.runtime.log.LogSystem (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe javax.faces.el.VariableResolver (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.velocity.tools.generic.DateTool (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.commons.attributes.AttributeRepositoryClass (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.cglib.proxy.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.commons.pool.PoolableObjectFactory (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.cglib.proxy.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.cglib.proxy.Dispatcher (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInvocation (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.cglib.proxy.CallbackFilter (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.cglib.proxy.NoOp (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.hibernate.transaction.TransactionManagerLookup (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.hibernate.connection.ConnectionProvider (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.hibernate.UserType (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.apache.ojb.broker.accesslayer.ConnectionFactoryManagedImpl (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.cglib.proxy.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe net.sf.cglib.proxy.CallbackFilter (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) C:\work\aop\bugs\injar-with-nonexisting-classes\spring.jar [error] can't find ty pe org.aopalliance.intercept.MethodInterceptor (no source information available) 41 errors

resolved fixed

a4a9090

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java", "org.aspectj.ajdt.core/testsrc/org/aspectj/ajdt/internal/core/builder/OutjarTest.java", "weaver/src/org/aspectj/weaver/JoinPointSignature.java", "weaver/src/org/aspectj/weaver/JoinPointSignatureIterator.java", "weaver/src/org/aspectj/weaver/Member.java", "weaver/src/org/aspectj/weaver/MemberImpl.java", "weaver/src/org/aspectj/weaver/MissingResolvedTypeWithKnownSignature.java", "weaver/src/org/aspectj/weaver/ReferenceType.java", "weaver/src/org/aspectj/weaver/ResolvedMemberImpl.java", "weaver/src/org/aspectj/weaver/ResolvedType.java", "weaver/src/org/aspectj/weaver/WeaverMessages.java", "weaver/src/org/aspectj/weaver/World.java", "weaver/src/org/aspectj/weaver/bcel/BcelAccessForInlineMunger.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java", "weaver/src/org/aspectj/weaver/patterns/SignaturePattern.java", "weaver/src/org/aspectj/weaver/patterns/TypePatternList.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 109173 Weaving Adaptor enhancements for performance, configuration and diagnosis

Here are some suggested enhancements as a result of exhaustive testing in the Eclipse/OSGi environment. 1. If no aspects are declared for a particular class loader, either because there are no visible aop.xml files or they contain no aspect definitions, then we should short-circuit the implementation of weaveClass() so that byte-code is not unnecessarily passed to the weaver. This is especially important under OSGi where there may be hundreds of class bundles, each with their own class loader only some of which are being woven. We can use the existing enabled flag. 2. As previously discussed on aspectj-dev the META-INF directory is considered private in OSGi and is therefore an inappropriate location for aop.xml files declaring shared aspects. I therefore propose a System property to set the a resource names for finding aop.xml files which would default to META-INF/aop.xml e.g. -Dorg.aspectj.weaver.loadtime.configuration=META- INF/aop.xml;org/aspectj/aop.xml. 3. We should not be catching Throwable in Aj. Instead we should catch known exceptions e.g. BCException and issue messages while letting other runtime exceptions pass back to the class loader. A user provided IMessageHandler implementation can decide under what circumstances to abort. Alternatively if Aj is considered to be a safe interface for weaving agents e.g. JVMTI then the dump logic it contains should be moved to the WeavingAdaptor so that it can be used directly from a class loader.

resolved fixed

03b20bc

["loadtime/src/org/aspectj/weaver/loadtime/Aj.java", "loadtime/src/org/aspectj/weaver/loadtime/ClassLoaderWeavingAdaptor.java", "loadtime/src/org/aspectj/weaver/loadtime/DefaultWeavingContext.java", "loadtime/src/org/aspectj/weaver/loadtime/IWeavingContext.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 109283 Invalid "indirect static access" warning on EnumSet.noneOf

When compiling AspectJ enabled projects in Java 5.0 source mode with "Indirect access to static modifier" warnings on, the following code incorrectly gives a compiler warning (this doesn't occur in non-AspectJ enabled projects): public class Test { enum Foo { Wibble, Wobble, Woo; } public static void main(String[] args) { EnumSet<Foo> set = EnumSet.noneOf(Foo.class); } }

resolved fixed

8a0f59a

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AspectDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/AjcMemberMaker.java", "weaver/src/org/aspectj/weaver/bcel/BcelPerClauseAspectAdder.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 76374 Problem with declare parents when using non-public classes

Non-public classes, when explicitly named, do not get woven. The test case below exhibits this problem when the package declaration is uncommented. If the package declaration is commented out, the class is woven correctly. If the package declaration is uncommented, a compilation failure occurs with AspectJ 1.2. According to Andrew Clement, AspectJ 1.2.1 compiles, but does not weave. If the "MyInnerClass" is changed to be public [regardless of the package declaration status], the class is woven correctly. Also: When the "MyInnerClass" is moved out of "MyClass", but kept in the MyClass.java file, then the following behavior is exhibited: If the package declaration is commented out, the class is woven correctly. If the package declaration is uncommented out, a compilation failure occurs with AspectJ 1.2. Note, in this case, MyInnerClass cannot be declared as public. It also appears that if the RunnableAspect is placed in the same package as "MyClass", weaving occurs correctly, regardless of any class access modifiers <MyClass.java> // package mypackage; public class MyClass { public MyClass() { MyInnerClass mic = new MyInnerClass(); if (mic instanceof Runnable) mic.run(); } class MyInnerClass { public void run() { System.out.println("In MyInnerClass.run()!!"); } } public static void main(String args[]) { new MyClass(); } } </MyClass.java> <RunnableAspect.aj> public aspect RunnableAspect { declare parents: MyClass$MyInnerClass implements Runnable; // declare parents: mypackage.MyClass$MyInnerClass implements Runnable; } </RunnableAspect.aj>

resolved fixed

ca9c1f7

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 104957 NullPointerException when running ajc on gij

When running ajc 1.2.1 on the GNU Interpreter for Java 4.0.1, I received this error: java.lang.NullPointerException at org.aspectj.apache.bcel.generic.InstructionComparator$1.equals(org.aspectj.apache.bcel.generic.Instruction, org.aspectj.apache.bcel.g eneric.Instruction) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.apache.bcel.generic.Instruction.equals(java.lang.Object) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at java.util.AbstractMap.equals(java.lang.Object, java.lang.Object) (/usr/lib/libgcj.so.6.0.0) at java.util.HashMap.put(java.lang.Object, java.lang.Object) (/usr/lib/libgcj.so.6.0.0) at java.util.HashSet.add(java.lang.Object) (/usr/lib/libgcj.so.6.0.0) at org.aspectj.apache.bcel.generic.InstructionHandle.addTargeter(org.aspectj.apache.bcel.generic.InstructionTargeter) (/tmp/cache/local/ aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.apache.bcel.generic.BranchInstruction.notifyTarget(org.aspectj.apache.bcel.generic.InstructionHandle, org.aspectj.apache. bcel.generic.InstructionHandle, org.aspectj.apache.bcel.generic.InstructionTargeter) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.apache.bcel.generic.BranchInstruction.setTarget(org.aspectj.apache.bcel.generic.InstructionHandle) (/tmp/cache/local/aspe ctj1.2/lib/aspectjweaver.jar.so) at org.aspectj.apache.bcel.generic.BranchInstruction.BranchInstruction(short, org.aspectj.apache.bcel.generic.InstructionHandle) (/tmp/c ache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.apache.bcel.generic.Select.Select(short, int[], org.aspectj.apache.bcel.generic.InstructionHandle[], org.aspectj.apache.b cel.generic.InstructionHandle) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.apache.bcel.generic.LOOKUPSWITCH.LOOKUPSWITCH(int[], org.aspectj.apache.bcel.generic.InstructionHandle[], org.aspectj.apa che.bcel.generic.InstructionHandle) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.apache.bcel.generic.SWITCH.SWITCH(int[], org.aspectj.apache.bcel.generic.InstructionHandle[], org.aspectj.apache.bcel.gen eric.InstructionHandle, int) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.apache.bcel.generic.SWITCH.SWITCH(int[], org.aspectj.apache.bcel.generic.InstructionHandle[], org.aspectj.apache.bcel.gen eric.InstructionHandle) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.weaver.bcel.Utility.copyInstruction(org.aspectj.apache.bcel.generic.Instruction) (/tmp/cache/local/aspectj1.2/lib/aspectj weaver.jar.so) at org.aspectj.weaver.bcel.LazyMethodGen.packBody(org.aspectj.apache.bcel.generic.MethodGen) (/tmp/cache/local/aspectj1.2/lib/aspectjwea ver.jar.so) at org.aspectj.weaver.bcel.LazyMethodGen.pack() (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.weaver.bcel.LazyMethodGen.getMethod() (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.weaver.bcel.LazyClassGen.writeBack(org.aspectj.weaver.bcel.BcelWorld) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar. so) at org.aspectj.weaver.bcel.LazyClassGen.getJavaClass(org.aspectj.weaver.bcel.BcelWorld) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.j ar.so) at org.aspectj.weaver.bcel.BcelWeaver.getClassFilesFor(org.aspectj.weaver.bcel.LazyClassGen) (/tmp/cache/local/aspectj1.2/lib/aspectjwea ver.jar.so) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(org.aspectj.weaver.bcel.UnwovenClassFile, org.aspectj.weaver.bcel.BcelObjectType, o rg.aspectj.weaver.IWeaveRequestor) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so) at org.aspectj.weaver.bcel.BcelWeaver.weave(org.aspectj.weaver.IClassFileProvider) (/tmp/cache/local/aspectj1.2/lib/aspectjweaver.jar.so ) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave() (Unknown Source) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling() (Unknown Source) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(org.aspectj.org.eclipse.jdt.internal.compiler.env.ICompilationUnit[]) (Unknown Source) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(java.util.List) (Unknown Source) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(org.aspectj.ajdt.internal.core.builder.AjBuildConfig, org.aspectj.bridg e.IMessageHandler, boolean) (Unknown Source) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(org.aspectj.ajdt.internal.core.builder.AjBuildConfig, org.aspectj.br idge.IMessageHandler) (Unknown Source) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(org.aspectj.bridge.IMessageHandler, boolean) (Unknown Source) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(java.lang.String[], org.aspectj.bridge.IMessageHandler) (Unknown Source) at org.aspectj.tools.ajc.Main.run(java.lang.String[], org.aspectj.bridge.IMessageHolder) (Unknown Source) at org.aspectj.tools.ajc.Main.runMain(java.lang.String[], boolean) (Unknown Source) at org.aspectj.tools.ajc.Main.main(java.lang.String[]) (Unknown Source) at gnu.java.lang.MainThread.call_main() (/usr/lib/libgcj.so.6.0.0) at gnu.java.lang.MainThread.run() (/usr/lib/libgcj.so.6.0.0) Unfortunately, the above stack trace contains no line number information; however, by running the program under the gdb debugger, I was able to get a backtrace with line numbers for the relevant part of the stack trace: (gdb) bt #0 0x011a0246 in org.aspectj.apache.bcel.generic.InstructionComparator$1.equals(org.aspectj.apache.bcel.generic.Instruction, org.aspectj.apache.bcel.generic.Instruction) (this=@5c71ea8, i1=@610fe70, i2=@610fc60) at org/aspectj/apache/bcel/generic/InstructionComparator.java:79 #1 0x011a004e in org.aspectj.apache.bcel.generic.Instruction.equals(java.lang.Object) (this=@610fe70, that=@610fc60) at org/aspectj/apache/bcel/generic/Instruction.java:499 #2 0x031b5f9b in java.util.AbstractMap.equals(java.lang.Object, java.lang.Object) (o1=@610fe70, o2=@610fc60) at ../../../libjava/java/util/AbstractMap.java:603 #3 0x031cc0ae in java.util.HashMap.put(java.lang.Object, java.lang.Object) (this=@6483690, key=@610fe70, value=@2dfc0) at ../../../libjava/java/util/HashMap.java:349 #4 0x031cca00 in java.util.HashSet.add(java.lang.Object) (this=null, o=@610fe70) at ../../../libjava/java/util/HashSet.java:151 #5 0x011b30ad in org.aspectj.apache.bcel.generic.InstructionHandle.addTargeter(org.aspectj.apache.bcel.generic.InstructionTargeter) ( this=@6949d20, t=@610fe70) at org/aspectj/apache/bcel/generic/InstructionHandle.java:208 #6 0x011861e6 in org.aspectj.apache.bcel.generic.BranchInstruction.notifyTarget(org.aspectj.apache.bcel.generic.InstructionHandle, org.aspectj.apache.bcel.generic.InstructionHandle, org.aspectj.apache.bcel.generic.InstructionTargeter) (old_ih=null, new_ih=@6949d20, t=@610fe70) at org/aspectj/apache/bcel/generic/BranchInstruction.java:217 #7 0x01186133 in org.aspectj.apache.bcel.generic.BranchInstruction.setTarget(org.aspectj.apache.bcel.generic.InstructionHandle) ( this=@610fe70, target=@6949d20) at org/aspectj/apache/bcel/generic/BranchInstruction.java:205 #8 0x011857ef in org.aspectj.apache.bcel.generic.BranchInstruction.BranchInstruction(short, org.aspectj.apache.bcel.generic.InstructionHandle) (this=@610fe70, opcode=171, target=@6949d20) at org/aspectj/apache/bcel/generic/BranchInstruction.java:86 #9 0x011d3489 in org.aspectj.apache.bcel.generic.Select.Select(short, int[], org.aspectj.apache.bcel.generic.InstructionHandle[], org.aspectj.apache.bcel.generic.InstructionHandle) (this=@610fe70, opcode=171, match=@6f63b90, targets=@6eeabe0, target=@6949d20) at org/aspectj/apache/bcel/generic/Select.java:106 #10 0x011c3152 in org.aspectj.apache.bcel.generic.LOOKUPSWITCH.LOOKUPSWITCH(int[], org.aspectj.apache.bcel.generic.InstructionHandle[], org.aspectj.apache.bcel.generic.InstructionHandle) (this=@610fe70, match=@6f63b90, targets=@6eeabe0, target=@6949d20) at org/aspectj/apache/bcel/generic/LOOKUPSWITCH.java:80 #11 0x011d4f94 in org.aspectj.apache.bcel.generic.SWITCH.SWITCH(int[], org.aspectj.apache.bcel.generic.InstructionHandle[], org.aspectj.apache.bcel.generic.InstructionHandle, int) (this=@6a20978, match=@5b1ccd0, targets=@6eeac08, target=@6949d20, max_gap=1) at org/aspectj/apache/bcel/generic/SWITCH.java:104 #12 0x011d5002 in org.aspectj.apache.bcel.generic.SWITCH.SWITCH(int[], org.aspectj.apache.bcel.generic.InstructionHandle[], org.aspectj.apache.bcel.generic.InstructionHandle) (this=@6a20978, match=@5b1ccd0, targets=@6eeac08, target=@6949d20) at org/aspectj/apache/bcel/generic/SWITCH.java:109 #13 0x01332eb6 in org.aspectj.weaver.bcel.Utility.copyInstruction(org.aspectj.apache.bcel.generic.Instruction) (i=@610fc60) at org/aspectj/weaver/bcel/Utility.java:474 #14 0x01326f66 in org.aspectj.weaver.bcel.LazyMethodGen.packBody(org.aspectj.apache.bcel.generic.MethodGen) (this=@6d98000, gen=@6d983c0) at org/aspectj/weaver/bcel/LazyMethodGen.java:813 #15 0x01326d08 in org.aspectj.weaver.bcel.LazyMethodGen.pack() (this=@6d98000) at org/aspectj/weaver/bcel/LazyMethodGen.java:790 #16 0x01324c81 in org.aspectj.weaver.bcel.LazyMethodGen.getMethod() (this=@6d98000) at org/aspectj/weaver/bcel/LazyMethodGen.java:336 #17 0x0131b502 in org.aspectj.weaver.bcel.LazyClassGen.writeBack(org.aspectj.weaver.bcel.BcelWorld) (this=@610ff00, world=@5642d20) at org/aspectj/weaver/bcel/LazyClassGen.java:418 #18 0x0131b95e in org.aspectj.weaver.bcel.LazyClassGen.getJavaClass(org.aspectj.weaver.bcel.BcelWorld) (this=@610ff00, world=@5642d20) at org/aspectj/weaver/bcel/LazyClassGen.java:446 #19 0x01311589 in org.aspectj.weaver.bcel.BcelWeaver.getClassFilesFor(org.aspectj.weaver.bcel.LazyClassGen) (this=@a33c0, clazz=@610ff00) <snip> It might be difficult for me to provide a reproducable test case (it might depend on the gij version, but I can try if wanted). However, happily, having examined the bytecode of the BCEL classes from the first few lines of the stack trace, I think I can explain why this exception occurs without needing to provide a test case. It's very simple. Whoever wrote the BCEL code in question, obviously never ran it with a data set and on a virtual machine where a hash collision in the HashSet would occur. Because, with this BCEL snapshot, if a hash collision does occur, the object being added to the HashSet is *guaranteed* to cause a NullPointerException in the Comparator method. This can be seen merely by examining the code path described by this stack trace. The field "targets" in the LOOKUPSWITCH object has not been initialized when notifyTarget is called, so if there is a hash collision in the HashSet, the InstructionComparator will be called - and it is guaranteed to call getTargets () and access its array length, which will cause a NullPointerException. I hope this explanation is sufficiently clear. If not, I will be happy to provide further details.

resolved fixed

0e1bb19

["bcel-builder/src/org/aspectj/apache/bcel/generic/InstructionComparator.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108120 Complete implemenation of runtime pointcut parsing and matching

The weaver API for runtime pointcut parsing and matching needs extending for all of the new pointcuts we have added in AJ5. Recommended approach is to implement JavaLangReflectObjectType as a new ReferenceTypeDelegate, and a JavaLangReflectWorld in place of BcelWorld.

resolved fixed

a39f595

["aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/AjTypeImpl.java", "aspectj5rt/java5-src/org/aspectj/internal/lang/reflect/PointcutImpl.java", "aspectj5rt/java5-src/org/aspectj/lang/annotation/Pointcut.java", "aspectj5rt/java5-src/org/aspectj/lang/reflect/Pointcut.java", "bcel-builder/src/org/aspectj/apache/bcel/classfile/JavaClass.java", "bcel-builder/src/org/aspectj/apache/bcel/generic/Type.java", "bcel-builder/testsrc/org/aspectj/apache/bcel/classfile/tests/GetReflectMembersTest.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AtAspectJAnnotationFactory.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/PointcutDeclaration.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/PointcutDesignator.java", "tests/java5/ataspectj/annotationGen/RuntimePointcuts.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "tests/src/org/aspectj/systemtest/ajc150/ataspectj/AtAjAnnotationGenTests.java", "weaver/java5-src/org/aspectj/weaver/reflect/Java15AnnotationFinder.java", "weaver/java5-src/org/aspectj/weaver/reflect/Java15ReflectionBasedReferenceTypeDelegate.java", "weaver/java5-testsrc/org/aspectj/weaver/tools/Java15PointcutExpressionTest.java", "weaver/src/org/aspectj/weaver/Shadow.java", "weaver/src/org/aspectj/weaver/UnresolvedType.java", "weaver/src/org/aspectj/weaver/World.java", "weaver/src/org/aspectj/weaver/internal/tools/PointcutExpressionImpl.java", "weaver/src/org/aspectj/weaver/patterns/AndPointcut.java", "weaver/src/org/aspectj/weaver/patterns/AndTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/AnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ArgsAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java", "weaver/src/org/aspectj/weaver/patterns/CflowPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ConcreteCflowPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ExactTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/HandlerPointcut.java", "weaver/src/org/aspectj/weaver/patterns/HasMemberTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/IfPointcut.java", "weaver/src/org/aspectj/weaver/patterns/KindedPointcut.java", "weaver/src/org/aspectj/weaver/patterns/NotPointcut.java", "weaver/src/org/aspectj/weaver/patterns/NotTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/OrPointcut.java", "weaver/src/org/aspectj/weaver/patterns/OrTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/PerCflow.java", "weaver/src/org/aspectj/weaver/patterns/PerClause.java", "weaver/src/org/aspectj/weaver/patterns/PerFromSuper.java", "weaver/src/org/aspectj/weaver/patterns/PerObject.java", "weaver/src/org/aspectj/weaver/patterns/PerSingleton.java", "weaver/src/org/aspectj/weaver/patterns/PerTypeWithin.java", "weaver/src/org/aspectj/weaver/patterns/Pointcut.java", "weaver/src/org/aspectj/weaver/patterns/PointcutExpressionMatching.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java", "weaver/src/org/aspectj/weaver/patterns/SignaturePattern.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ThisOrTargetPointcut.java", "weaver/src/org/aspectj/weaver/patterns/ThrowsPattern.java", "weaver/src/org/aspectj/weaver/patterns/TypePattern.java", "weaver/src/org/aspectj/weaver/patterns/TypePatternList.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java", "weaver/src/org/aspectj/weaver/patterns/WithinAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinCodeAnnotationPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithinPointcut.java", "weaver/src/org/aspectj/weaver/patterns/WithincodePointcut.java", "weaver/src/org/aspectj/weaver/reflect/AnnotationFinder.java", "weaver/src/org/aspectj/weaver/reflect/JoinPointMatchImpl.java", "weaver/src/org/aspectj/weaver/reflect/PointcutParameterImpl.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionBasedReferenceTypeDelegate.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionBasedReferenceTypeDelegateFactory.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionBasedResolvedMemberImpl.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionShadow.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionVar.java", "weaver/src/org/aspectj/weaver/reflect/ReflectionWorld.java", "weaver/src/org/aspectj/weaver/reflect/ShadowMatchImpl.java", "weaver/src/org/aspectj/weaver/tools/JoinPointMatch.java", "weaver/src/org/aspectj/weaver/tools/PointcutExpression.java", "weaver/src/org/aspectj/weaver/tools/PointcutParameter.java", "weaver/src/org/aspectj/weaver/tools/PointcutParser.java", "weaver/src/org/aspectj/weaver/tools/PointcutPrimitive.java", "weaver/src/org/aspectj/weaver/tools/ShadowMatch.java", "weaver/testsrc/BcweaverModuleTests15.java", "weaver/testsrc/org/aspectj/weaver/patterns/AndOrNotTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/ArgsTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/HandlerTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/KindedTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/PatternsTests.java", "weaver/testsrc/org/aspectj/weaver/patterns/PointcutTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/ThisOrTargetTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/WithinCodeTestCase.java", "weaver/testsrc/org/aspectj/weaver/patterns/WithinTestCase.java", "weaver/testsrc/org/aspectj/weaver/reflect/ReflectionBasedReferenceTypeDelegateTest.java", "weaver/testsrc/org/aspectj/weaver/reflect/ReflectionWorldTest.java", "weaver/testsrc/org/aspectj/weaver/tools/PointcutExpressionTest.java", "weaver/testsrc/org/aspectj/weaver/tools/PointcutParserTest.java", "weaver/testsrc/reflect/tests/C.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 109486 Internal compiler error (ClassParser.java:242)

Testcase: A.aj containing: final abstract aspect A {} This causes the compiler to abort with an internal compiler error: C:\Documents and Settings\mchapman\A.aj [error] Internal compiler error org.aspectj.apache.bcel.classfile.ClassFormatException: Class can't be both final and abstract at org.aspectj.apache.bcel.classfile.ClassParser.readClassInfo(ClassPars er.java:242) at org.aspectj.apache.bcel.classfile.ClassParser.parse(ClassParser.java: 165) at org.aspectj.weaver.bcel.Utility.makeJavaClass(Utility.java:489) at org.aspectj.weaver.bcel.UnwovenClassFile.getJavaClass(UnwovenClassFil e.java:63) at org.aspectj.weaver.bcel.UnwovenClassFile.getClassName(UnwovenClassFil e.java:147) at org.aspectj.ajdt.internal.core.builder.AjState.noteResult(AjState.jav a:497) at org.aspectj.ajdt.internal.core.builder.AjBuildManager$3.acceptResult( AjBuildManager.java:748) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterProcessing( AjCompilerAdapter.java:186) at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$afterReturning $org_aspectj_ajdt_internal_compiler_CompilerAdapter$4$6b855184(CompilerAdapter.a j:89) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.process(Compil er.java:528) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compil er.java:329) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilat ion(AjBuildManager.java:728) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild(AjBuild Manager.java:206) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBu ildManager.java:140) at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:112) at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:60) at org.aspectj.tools.ajc.Main.run(Main.java:324) at org.aspectj.tools.ajc.Main.runMain(Main.java:238) at org.aspectj.tools.ajc.Main.main(Main.java:82) (no source information available) C:\Documents and Settings\mchapman\A.aj:1 [error] The class A can be either abst ract or final, not both final abstract aspect A {} ABORT Exception thrown from AspectJ DEVELOPMENT C:\Documents and Settings\mchapman>ajc -version AspectJ Compiler DEVELOPMENT built on Tuesday Sep 13, 2005 at 22:31:40 GMT The expected behaviour is naturally just to get a regular compiler errror saying "The aspect A can be either abstract or final, not both".

resolved fixed

87e5c2e

["bcel-builder/src/org/aspectj/apache/bcel/classfile/ClassParser.java", "tests/bugs150/PR109486.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 103740 Compiler failure on @annotation

I'm using the ajc embedded in the latest dev build of AJDT (build 20050713163417) This small example illustrates the problem: public abstract aspect AbstractRequestMonitor { public pointcut requestExecution(RequestContext requestContext) : execution(* RequestContext.execute(..)) && this(requestContext); public abstract class RequestContext { public abstract Object execute(); } after(RequestContext requestContext) throwing (Throwable t) : requestExecution(requestContext) { } } import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; @Retention(RetentionPolicy.RUNTIME) public @interface AroundAdvice { } public aspect ErrorHandling { declare soft: Exception: !@annotation(AroundAdvice) && !withincode(* * (..)); Object around() : adviceexecution() && !@annotation(AroundAdvice) { try { return proceed(); } catch (Exception e) { return null; } } } Here's the stack trace I get: org.aspectj.weaver.BCException: bad at org.aspectj.weaver.bcel.BcelRenderer.visit(BcelRenderer.java:228) at org.aspectj.weaver.ast.Literal.accept(Literal.java:29) at org.aspectj.weaver.bcel.BcelRenderer.recur(BcelRenderer.java:151) at org.aspectj.weaver.bcel.BcelRenderer.renderTest (BcelRenderer.java:117) at org.aspectj.weaver.bcel.BcelAdvice.getTestInstructions (BcelAdvice.java:445) at org.aspectj.weaver.bcel.BcelShadow.weaveAroundClosure (BcelShadow.java:2585) at org.aspectj.weaver.bcel.BcelAdvice.implementOn(BcelAdvice.java:182) at org.aspectj.weaver.Shadow.implementMungers(Shadow.java:480) at org.aspectj.weaver.Shadow.implement(Shadow.java:358) at org.aspectj.weaver.bcel.BcelClassWeaver.implement (BcelClassWeaver.java:1703) at org.aspectj.weaver.bcel.BcelClassWeaver.weave (BcelClassWeaver.java:389) at org.aspectj.weaver.bcel.BcelClassWeaver.weave (BcelClassWeaver.java:94) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1362) at org.aspectj.weaver.bcel.BcelWeaver.weaveWithoutDump (BcelWeaver.java:1327) at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify (BcelWeaver.java:1106) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:981) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.weave (AjCompilerAdapter.java:286) at org.aspectj.ajdt.internal.compiler.AjCompilerAdapter.afterCompiling (AjCompilerAdapter.java:165) at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$afterReturning$org_aspec tj_ajdt_internal_compiler_CompilerAdapter$2$f9cc9ca0(CompilerAdapter.aj:70) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile (Compiler.java:368) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation (AjBuildManager.java:727) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.doBuild (AjBuildManager.java:206) at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild (AjBuildManager.java:140) at org.aspectj.ajde.internal.CompilerAdapter.compile (CompilerAdapter.java:121) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run (AspectJBuildManager.java:191)

resolved fixed

2ae4f53

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/AnnotationPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108826 AJDT Error: Can't find type

In Eclipse 3.1, using the latest AspectJ build (1.5.0_M3a compiler and 1.3.0 plugin) I get an error "can't find type test.T" , using the following code: =============== package test; public class CantFindType { public <T> T[] method(T[] array) { return null; } } ================ The error occurs, if the return type, or the parameter is an array of a generic type. The code compiles fine, but Eclipse shows the error, but doesn't show the folder or the location for the error.

resolved fixed

2942ca0

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 109124 VerifyError with inner classes

resolved fixed

a9ca915

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelField.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 109016 NullPointerException when building configuration

The exception below seems to be happening with any .lst file: Message: NullPointerException thrown: null Stack trace: java.lang.NullPointerException at org.aspectj.ajde.internal.CompilerAdapter.configureBuildOptions(CompilerAdapter.java:296) at org.aspectj.ajde.internal.CompilerAdapter.genBuildConfig(CompilerAdapter.java:170) at org.aspectj.ajde.internal.CompilerAdapter.compile(CompilerAdapter.java:95) at org.aspectj.ajde.internal.AspectJBuildManager$CompilerThread.run(AspectJBuildManager.java:191)

resolved fixed

5187437

["ajde/src/org/aspectj/ajde/internal/CompilerAdapter.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108886 Getting Exception during compilation : java.lang.RuntimeException: Internal Compiler Error: Unexpected null source location passed as 'see also' location.

Am attaching a small test case to reproduce the error (Not sure how to attach it - hopefully should be feasible to do so after I log the bug).

resolved fixed

2d21db0

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/AjLookupEnvironment.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseSourceType.java", "weaver/src/org/aspectj/weaver/ResolvedMemberImpl.java", "weaver/src/org/aspectj/weaver/ResolvedType.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 109042 parameter ajc_aroundclosure is never read

resolved fixed

08d6a5d

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108902 Type mismatch: cannot convert from Collection to Collection

(From aspectj-users) The program below produces the erroneous message: [iajc] D:\workdir\DPsample\main\src\com\designpattern\observer\ObserverProt ocol.aj:39 [error] Type mismatch: cannot convert from Collection to Collection [iajc] return observers; [iajc] ^^^^^ //Subject.java interface Subject { public void addObserver(Observer observer); public void removeObserver(Observer observer); public Collection getObservers(); } //Observer.java interface Observer { public void update(); } //ObserverProtocol public abstract aspect ObserverProtocol{ abstract pointcut stateChange(Subject subject); after(Subject subject):stateChange(subject){ Iterator it=subject.getObservers().iterator(); while(it.hasNext()){ Observer observer=(Observer)it.next(); observer.update(); } } private Collection Subject.observers=new ArrayList(); public void Subject.addObserver(Observer observer){ observers.add(observer); } public void Subject.removeObserver(Observer observer){ observers.remove(observer); } public Collection Subject.getObservers() { return observers; } }

resolved fixed

2505485

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/InterTypeMethodDeclaration.java", "tests/bugs150/pr108902/Observer.java", "tests/bugs150/pr108902/Subject.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108816 AspectJ 1.5.0 Development Compiler Chokes on Advice with Cflow

resolved fixed

71771ab

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 99125 Repetitive method name/signature in class file

This is what the VM sais: java.lang.ClassFormatError: Repetitive method name/signature in class file com/ netvisor/metadata_view/ComponentFactory at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:620) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java: 124) at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) at java.net.URLClassLoader.access$100(URLClassLoader.java:56) at java.net.URLClassLoader$1.run(URLClassLoader.java:195) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:188) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:268) at java.lang.ClassLoader.loadClass(ClassLoader.java:251) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319) And this is why: I've got an interface (ComponentFactory) and an aspect that adds various ITD methods trough that interface. I've added some methods to both the interface and the aspect, some other methods are only added trough the aspect. (The situation is a bit more complex, I've got a base interface/aspect with these two methods and the subaspects implement the problematic two methods .) And those methods that are both in the interface and the aspect are the ones that get duplicated in the interface class file. This is working fine in the old CVS branch (1.2.*). Hope it helps, good luck!

resolved fixed

df46c6f

["tests/bugs150/pr99125/p/I.java", "tests/bugs150/pr99125/p/J.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 101606 AspectJ compiler does not process unused code compiler options properly for aspects

In Eclipse (3.0) click 'Window' > 'Preferences' > 'Java' > 'Compiler'. Select the 'Unused Code' tab on the compiler preference page. Change 'Unused or unread private members' to Warning or Error. Create a project that contains an aspect with some private pointcuts. You will see warnings or errors for these pointcuts saying that they are unused.

resolved fixed

2c88c59

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 102212 [itds] abstract synchronized: compile error expected

when using intertype declaration, the compiler doesn't check for illegal modifier combinations such as "abstract synchronized". another manifestation of this problem is when using intertype declaration to add a synchronized method to an interface. the problem is more severe in this case because conceptually, this method is not abstract at all. interface Interface {} abstract class Parent {} class Child extends Parent implements Interface {} aspect Bug { // illegal modifier combination not caught by ajc public abstract synchronized void Parent._abstract(); public synchronized void Child._abstract() {} // the following has the same effect, but is easier to miss public /* implicit abstract */ synchronized void Interface._interface() {} // use Child to make java complain: "illegal modifiers: 0x421" // (this corresponds to "public abstract synchronized") public static void main(String[] args) { new Child(); } }

resolved fixed

b17ff4e

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/bcel/BcelTypeMunger.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 99136 xlint advice not applied appears twice with cflows

////////////// in the following code aspect A{ before(): call(* *(..)) && cflow(execution(* *(..))) {} } //////////////////////////////////// two "advice not appied" xlint messages are produced, one for the before advice and one for the cflow within the before advice.

resolved fixed

047173e

["tests/bugs150/pr105479/Driver.java", "tests/bugs150/pr105479/ReturnTypeTester.java", "tests/harness/XLintcflow.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "tests/src/org/aspectj/systemtest/xlint/XLintTests.java", "weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108062 NPE when opening resources from CVS resources history

NPE when opening resources (double-click) from CVS resources history view. java.lang.NullPointerException at org.eclipse.mylar.java.ui.editor.MylarJavaElementDescriptor.drawCompositeImage(MylarJavaElementDescriptor.java:40) at org.eclipse.jface.resource.CompositeImageDescriptor.getImageData(CompositeImageDescriptor.java:205) at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:279) at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:233) at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:211) at org.eclipse.mylar.ui.MylarImages.getImage(MylarImages.java:108) at org.eclipse.mylar.java.ui.editor.MylarCompilationUnitEditor.updatedTitleImage(MylarCompilationUnitEditor.java:55) at org.eclipse.jdt.internal.ui.javaeditor.JavaEditorErrorTickUpdater$1.run(JavaEditorErrorTickUpdater.java:86) at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:152) at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:28) at org.eclipse.swt.widgets.Display.syncExec(Display.java:3413) at org.eclipse.jdt.internal.ui.javaeditor.JavaEditorErrorTickUpdater.postImageChange(JavaEditorErrorTickUpdater.java:84) at org.eclipse.jdt.internal.ui.javaeditor.JavaEditorErrorTickUpdater.updateEditorImage(JavaEditorErrorTickUpdater.java:77) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.doSetInput(CompilationUnitEditor.java:1548) at org.eclipse.ui.texteditor.AbstractTextEditor$16.run(AbstractTextEditor.java:2360) at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:346) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:291) at org.eclipse.jface.window.ApplicationWindow$1.run(ApplicationWindow.java:624) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.jface.window.ApplicationWindow.run(ApplicationWindow.java:621) at org.eclipse.ui.internal.WorkbenchWindow.run(WorkbenchWindow.java:2135) at org.eclipse.ui.texteditor.AbstractTextEditor.internalInit(AbstractTextEditor.java:2378) at org.eclipse.ui.texteditor.AbstractTextEditor.init(AbstractTextEditor.java:2405) at org.eclipse.ui.internal.EditorManager.createSite(EditorManager.java:773) at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:572) at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:365) at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:552) at org.eclipse.ui.internal.EditorReference.getEditor(EditorReference.java:214) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2325) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2258) at org.eclipse.ui.internal.WorkbenchPage.access$9(WorkbenchPage.java:2250) at org.eclipse.ui.internal.WorkbenchPage$9.run(WorkbenchPage.java:2236) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2231) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2204) at org.eclipse.team.internal.ccvs.ui.actions.OpenLogEntryAction$1.run(OpenLogEntryAction.java:85) at org.eclipse.team.internal.ccvs.ui.repo.RepositoryManager.run(RepositoryManager.java:651) at org.eclipse.team.internal.ccvs.ui.actions.CVSAction$2.run(CVSAction.java:347) at org.eclipse.team.internal.ccvs.ui.actions.CVSAction$3.run(CVSAction.java:356) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.team.internal.ccvs.ui.actions.CVSAction.run(CVSAction.java:353) at org.eclipse.team.internal.ccvs.ui.actions.OpenLogEntryAction.execute(OpenLogEntryAction.java:64) at org.eclipse.team.internal.ccvs.ui.actions.CVSAction.run(CVSAction.java:117) at org.eclipse.team.internal.ccvs.ui.HistoryView$6.handleEvent(HistoryView.java:199) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:843) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3080) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2713) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1699) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1663) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:367) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:226) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:376) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:163) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:334) at org.eclipse.core.launcher.Main.basicRun(Main.java:278) at org.eclipse.core.launcher.Main.run(Main.java:973) at org.eclipse.core.launcher.Main.main(Main.java:948)

resolved fixed

ad753aa

["bcel-builder/src/org/aspectj/apache/bcel/classfile/GenericSignatureParser.java", "tests/bugs150/pr108602.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 98290 no "matches declare" entry in structure model for single declare warning statement

A project containing one class and one aspect: ----------------------------------------------------- package pack; public class C { public static void main(String[] args) { new C().sayHello(); } public void sayHello() { System.out.println("HELLO"); } } ---------------------------------------------------- package pack; public aspect A { declare warning : execution(* C.sayHello(..)) : "blah blah"; } ----------------------------------------------------- has the "matched by" entry for A.aj, but doesn't have the "matches declare" entry for C.java. This means that in AJDT, C.sayHello isn't added to our map and consequently we don't get any relationships showing in the Cross Reference view for A.aj.

resolved fixed

619f8bc

["weaver/src/org/aspectj/weaver/bcel/BcelShadow.java", "weaver/src/org/aspectj/weaver/bcel/LazyMethodGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 102459 provide more detail in -showWeaveInfo messages

When advice is executed, the object you have to work with is the joinpoint. This can then be queried to get various information out of it. It would be nice, if as part of the weaving you could get hold of the same information. This is particularly useful in the case of writing a coverage tool. In order to measure where you've been, you have to know all the places you could possibly go. The introduction of the -showWeaveInfo option means that we can record these places, however, this would be greatly enhanced by providing similar information as to that which is collected as the program is running. The information which would be good is the same as that obtained from JoinPoint.StaticPart.getSignature().toLongString().

resolved fixed

c6bc7a2

["bridge/src/org/aspectj/bridge/WeaveMessage.java", "tests/java5/ataspectj/ataspectj/ltwlog/MainVerboseAndShow.java", "weaver/src/org/aspectj/weaver/Shadow.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 59076 Reduce footprint of JoinPoint.StaticPart objects

Tests show that each object consumes 180+ bytes. For a large project (1000+ classes) where an aspect is used to implement a pervasive cross-cutting concern e.g. exception logging this can lead to >1MB of additional heap space. Two possible approaches could be: 1. Break literal String used by Factory.makeXXXSig() methods into component parts e.g. package, class, method. ... names. These could then be shared automatically by the JVM as interned Strings. 2. Lazy instantiation of handler static JPs in the catch block. Any enhancements could be enabled by a compiler option similar to -XlazyTjp.

resolved fixed

a5e645f

["runtime/src/org/aspectj/runtime/reflect/Factory.java", "runtime/src/org/aspectj/runtime/reflect/SignatureImpl.java", "weaver/src/org/aspectj/weaver/bcel/LazyClassGen.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 74048 AJDT reports unnecessary compile time warnings for private static aspects

resolved fixed

16512b2

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/problem/AjProblemReporter.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 59196 "adviceexecution() && args()" pcd does not pick up around advice execution because args() does not match the AroundClosure parameter.

In the following sample, the advice defined in "other_aspect" does not pick up the execution of around advice defined in "some_aspect". It matches only against the before advice defined in "some_aspect". The implicit AroundClosure parameter of an around advice seems to come in the way of args() matching. ------------------------------------------------------ aspect some_aspect { pointcut call_m(int a, int b) : call(int test.m(..)) && args(a, b); before(int x, int y) : call_m(x, y) { ... } int around(int x, int y) : call_m(x, y) { ... } } aspect other_aspect { before(int x, int y) : adviceexecution() && within(some_aspect) && args(x, y){ ... } } -------------------------------------------------------- AspectJ doc has to state this explicitly.

resolved fixed

a66e0a2

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/ArgsPointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 71159 pointcut call(MethodPattern) matches non-visible methods in parent class

aspectjtools.jar / ajc v1.2 We believe that the call(methodpattern) pointcut has matching behaviour that is inconsistent with what we expect from Java in relation to invocations of methods on subclasses and superclasses. Background: Our goal is to use an aspect to declare ajc compiler warnings on any invocation to a target method, where the space of targets is defined as any visible method of any class in a specified package P or its subpackages. As well as straight invocations from types in packages oustide P and its subpackages, we wish to match method invocations on P where the methods invoked are inherited from P -- that is , they are obtained in a type that directly extends a type in P or its subpackages. The fragment of the aspect we are using is: public aspect Aspect1 { pointcut methodCalls() : !within(Aspect1) && call(* P..*.*(..)) ; // 'P' is the target package space declare warning : methodCalls() : "invoking"; //... } Consider these cases: Case 1 method inheritance: Superclass A in package P declares and implements a public method M. A direct subclass B (in a package outside P) directly extends A and inherits this method. Now, any calls inside B to M or this.M() are matched by the call() join point above which seeks to match calls to P..*.*() This is as we would expect since the implementation in package space P is actually being called. Case 2 method overriding: Superclass A in package P declares and implements a public method M. Direct subclass B (in a package outside P) overrides A.M with its own implementation M'. M' does not invoke M. Now, calls inside B to M' or this.M'() are still matched by the call() join point above which seeks to match calls to P..*.*() even though M' does not invoke or depend on M. We do not expect this result since we do not think M is actually called. Case 3 redeclaration of non-visible method with the same name: Superclass A in package P declares and implements a private method M. Direct subclass B (in a package outside P) introduces its own method M having the same signature as A.M. Now, calls in B to M or this.M() are still matched by the call() join point above which seeks to match calls to P..*.*() even though A.M is not visible to B and is never called by it. We do not expect this result since we do not think A.M is ever called. The only way we can explain this apparent behaviour is by reasoning that the compiler is treating the subclass B "as a type of" its parent A and somehow concluding that method calls on B can be equated with calls to methods of identical signature on A. However this seems at odds with the rules for Java visibility and with our expectations for when the call(...) joinpoint should match. We have experimented with execution(...) join points to perform this matching but that has turned up a different set of problems which we are still analyzing. Please can you shed any light on what the call joinpoint is doing here? regards, Dave

resolved fixed

7e0c3cd

["tests/bugs150/pr71159/pkg1/A.java", "tests/bugs150/pr71159/pkg1/B.java", "tests/bugs150/pr71159/pkg1/C.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/ResolvedMemberImpl.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 107858 illegal argument to proceed crashes the parser

in a context where proceed requires zero arguments, calling it with an extra argument crashes the compiler, but only if that argument is a field access: class Foo { Foo field; void test() {} } public aspect Bug { void around() : call(void Foo.test()) { Foo foo = new Foo().field; proceed(foo); // caught at compile time proceed(new Foo().field); // crashes } } /home/user/sgelin3/dev/java/ajc/new_bug/Bug.java [error] Internal compiler error java.lang.NullPointerException at org.aspectj.ajdt.internal.compiler.ast.AccessForInlineVisitor.getAccessibleField(AccessForInlineVisitor.java:145) at org.aspectj.ajdt.internal.compiler.ast.AccessForInlineVisitor.endVisit(AccessForInlineVisitor.java:108) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.FieldReference.traverse(FieldReference.java:609) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.MessageSend.traverse(MessageSend.java:467) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse(MethodDeclaration.java:212)

resolved fixed

6c8747b

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/AccessForInlineVisitor.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 104024 combining varargs and inner classes crashes the parser

class Outer { public class Inner {} } public class Bug { public void varargs(Object... varargs) {} public void test() { Outer.Inner inner = new Outer().new Inner(); varargs(inner); // works varargs(new Outer().new Inner()); // crashes } }

resolved fixed

f2af562

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 95992 Problems resolving type name inside generic class

ajc reports an error when compiling the following code: interface Base<T> { static interface Inner { } } class Test<T extends Test.InnerTest> implements Base<T> { static class InnerTest implements Inner { } } $ ajc -1.5 Test.java Test.java:14 [error] Inner cannot be resolved to a type static class InnerTest implements Inner { Sun's javac compiles it without any error. The error can be avoided by simply writing "Base.Inner" instead of just "Inner". Also, it compiles fine if the constraint "extends Test.InnerTest" is left away.

resolved fixed

b953c03

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108448 IllegalStateException: Undeclared type variable when hiding

resolved fixed

2c9ea11

["weaver/src/org/aspectj/weaver/bcel/BcelField.java", "weaver/src/org/aspectj/weaver/bcel/BcelGenericSignatureToTypeXConverter.java", "weaver/src/org/aspectj/weaver/bcel/BcelMethod.java", "weaver/src/org/aspectj/weaver/bcel/BcelObjectType.java", "weaver/testsrc/org/aspectj/weaver/bcel/BcelGenericSignatureToTypeXTestCase.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108377 Verify Error on intertype field indirection in intertype method

When I run this program: public class A { public static void main(String[] args) { System.out.println(new A().foo()); } } aspect Aspect1 { public A A.a; public String A.value; public String A.foo() { return a.value; } } I get the error: Exception in thread "main" java.lang.VerifyError: (class: Aspect1, method: ajc$interMethod$Aspect1$A$foo signature: (LA;)Ljava/lang/String;) Incompatible type for getting or setting field at A.<init>(A.java:1) at A.main(A.java:3) Javap reveals that the field name is missing the class name part: 1: getfield #50; //Field a:LA; 4: getfield #46; //Field A.value:Ljava/lang/String; If I replace a.value by this.a.value, the correct code is generated: 1: getfield #37; //Field A.a:LA; 4: getfield #46; //Field A.value:Ljava/lang/String;

resolved fixed

be750d5

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 108050 Execution not matching override in doubly derived method

The following sample code fails because the compiler isn't matching the execution of doPost in MockServlet4. The declare warning for "servlet request" doesn't match in that case, nor does advice on the join point actually run at runtime (though this simplified code only shows the problem with declare warning). This was working until fairly recently (certainly in M2, even in AJDT from August 11). public abstract class MockServlet extends HttpServlet { protected void doPost() { } private static aspect FindMatches { declare warning: execution(* HttpServlet.do*(..)): "servlet request"; declare warning: execution(* HttpServlet+.do*(..)): "servlet request2"; } } class HttpServlet { protected void doPost() { } } public class MockDelayingServlet extends MockServlet { private static final long serialVersionUID = 1; } public class MockServlet4 extends MockDelayingServlet { protected void doPost() { } } compiler output (should have 6 warnings, including two for MockServlet4): C:\devel\workspace\test\src\MockServlet.java:16 [warning] servlet request protected void doPost() { ^^^^^^^^^^^^^^^^^^^^^^^^^ method-execution(void MockServlet.doPost()) see also: C:\devel\workspace\test\src\MockServlet.java:20::0 C:\devel\workspace\test\src\MockServlet.java:16 [warning] servlet request2 protected void doPost() { ^^^^^^^^^^^^^^^^^^^^^^^^^ method-execution(void MockServlet.doPost()) see also: C:\devel\workspace\test\src\MockServlet.java:21::0 C:\devel\workspace\test\src\MockServlet.java:26 [warning] servlet request protected void doPost() { ^^^^^^^^^^^^^^^^^^^^^^^^^ method-execution(void HttpServlet.doPost()) see also: C:\devel\workspace\test\src\MockServlet.java:20::0 C:\devel\workspace\test\src\MockServlet.java:26 [warning] servlet request2 protected void doPost() { ^^^^^^^^^^^^^^^^^^^^^^^^^ method-execution(void HttpServlet.doPost()) see also: C:\devel\workspace\test\src\MockServlet.java:21::0 C:\devel\workspace\test\src\MockServlet4.java:9 [warning] servlet request2 protected void doPost() ^^^^^^^^^^^^^^^^^^^^^^^ method-execution(void MockServlet4.doPost()) see also: C:\devel\workspace\test\src\MockServlet.java:21::0 5 warnings

resolved fixed

27e68f3

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/JoinPointSignature.java", "weaver/src/org/aspectj/weaver/ResolvedMemberImpl.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 107713 ClassCastException popup

Whenever I change any file and save(auto-compile) I get this in a popup. ClassCastException thrown: org.aspectj.ajdt.internal.compiler.lookup.EclipseSourceType cannot be cast to org.aspectj.weaver.bcel.BcelObjectType This started happening when I wrote these aspects. Before this started happening the IDE showed this line as an error. b.support.firePropertyChange( property, ( oldval == null ) ? oldval : new String(oldval), new String(newval)); ---------------------------------------------------------------- /** * */ package com.blueprint.util.mixin.test; import java.beans.PropertyChangeListener; import java.beans.PropertyChangeSupport; import java.lang.reflect.Field; import com.blueprint.util.mixin.test.*; import org.aspectj.lang.Signature; public aspect PropertySupportAspect { PropertyChangeSupport PropertySupport.support = new PropertyChangeSupport(this); public interface PropertySupport{ public void addPropertyChangeListener( PropertyChangeListener listener ); public void addPropertyChangeListener( String propertyName, PropertyChangeListener listener ); public void removePropertyChangeListener( String propertyName, PropertyChangeListener listener ); public void removePropertyChangeListener( PropertyChangeListener listener ); public void hasListeners( String propertyName ); } public void PropertySupport.addPropertyChangeListener (PropertyChangeListener listener){ support.addPropertyChangeListener(listener); } public void PropertySupport.addPropertyChangeListener( String propertyName, PropertyChangeListener listener){ support.addPropertyChangeListener(propertyName, listener); } public void PropertySupport.removePropertyChangeListener( String propertyName, PropertyChangeListener listener) { support.removePropertyChangeListener(propertyName, listener); } public void PropertySupport.removePropertyChangeListener (PropertyChangeListener listener) { support.removePropertyChangeListener(listener); } public void PropertySupport.hasListeners(String propertyName) { support.hasListeners(propertyName); } pointcut callSetter( Bean b ) : call( public void com.blueprint.util.test.Bean.setName( String ) ) && target( b ); void around( Bean b ) : callSetter( b ) { String propertyName = getField( thisJoinPointStaticPart.getSignature() ). getName (); System.out.println( "The property is [" + propertyName + "]" ); String oldValue = b.getName(); proceed( b ); firePropertyChange( b, propertyName, oldValue, b.getName ()); } private Field getField( Signature signature ){ Field field = null; System.out.println( "Getting the field name of [" +signature.getName() + "]" ); try{ String methodName = signature.getName(); field = signature.getDeclaringType(). getDeclaredField( methodName. substring( 3, methodName.length() ). toLowerCase()); field.setAccessible(true); }catch( NoSuchFieldException nsfe ){ nsfe.printStackTrace(); } return field; } void firePropertyChange( Bean b, String property, String oldval, String newval) { System.out.println( "The property is [" + property + "]"); System.out.println( "The old value is [" + oldval + "]"); System.out.println( "The new value is [" + newval + "]"); b.support.firePropertyChange( property, ( oldval == null ) ? oldval : new String(oldval), new String(newval)); } } ---------------------------------------------------------------- import java.io.Serializable; public class Bean implements Serializable{ private String name; public String getName() { return name; } public void setName( String name ) { this.name = name; } } ---------------------------------------------------------------- public aspect BeanSupport { declare parents: Bean implements PropertySupportAspect.PropertySupport; } ----------------------------------------------------------------

resolved fixed

100d9e0

["weaver/src/org/aspectj/weaver/bcel/BcelWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 104720 VerifyError after weaving around trivial switch statement

After compiling the attached source file and class file with ajc -inpath . -outjar t.jar Tracer.aj (on any of 1.2.1, 1.5.0M2 or the June 2005 snapshot) and then attempting to run it with gij -classpath ./t.jar:$CLASSPATH Test the following error is obtained: Exception in thread "main" java.lang.VerifyError: verification failed at PC 1 in Test:newTest_aroundBody2((I)LTest;): branch out of range at java.lang.VMClassLoader.resolveClass(java.lang.Class) (/usr/lib/libgcj.so.6.0.0) at java.lang.Class.initializeClass() (/usr/lib/libgcj.so.6.0.0) at java.lang.Class.forName(java.lang.String, boolean, java.lang.ClassLoader) (/usr/lib/libgcj.so.6.0.0) at gnu.java.lang.MainThread.run() (/usr/lib/libgcj.so.6.0.0) An excerpt from the output of javap -private -classpath t.jar -c Test shows that the generated switch is indeed bogus: private static final Test newTest_aroundBody2(int); Code: 0: iload_0 1: tableswitch{ //0 to 0 0: -1157627302; default: 16 } 20: invokespecial #3; //Method "<init>":()V 23: areturn

resolved fixed

bf767a9

["bcel-builder/src/org/aspectj/apache/bcel/generic/SWITCH.java", "bcel-builder/src/org/aspectj/apache/bcel/generic/TABLESWITCH.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 82989 Compiler error due to a wrong exception check in try blocks

Compiler error on correct code when an aspect performs a method introdiction. The method introduction contains an invocation to a method from the class and such an invocation is inside an appropriate try block. The ajc compiler performs a wrong check on the exception types. To understand better, please see the attached example

resolved fixed

cc6e681

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "tests/src/org/aspectj/systemtest/ajc150/GenericsTests.java", "weaver/src/org/aspectj/weaver/AjcMemberMaker.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 79523 BCException: illegal change to pointcut declaration: calls(<nothing>)

resolved fixed

93fdce1

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/ReferencePointcut.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 104529 @SuppressWarnings( "unchecked" ) is not ignoring type safety checks

AJDT is ignoring the @SuppressWarnings( "unchecked" ) annotation. It is giving me a type safety warning when I don't specify the type when declaring a generic even though I have the @SuppressWarnings( "unchecked" ) annotation specified.

resolved fixed

7b32570

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 86057 expect error when overriding final pointcuts

I get no compiler error when I "override"/redefine a final pointcut: ------------ public class Main { static void walk() {} static void run() {} public static void main(String[] args) { walk(); run(); } } abstract aspect AA { public final pointcut publicPointcut() : call(void walk()); before() : publicPointcut() { System.out.print("here: " + thisJoinPoint); } } aspect AA1 extends AA { // expecting error here b/c pointcut is final public pointcut publicPointcut() : call(void run()); } ------------ When run, it picks out run() rather than walk().

resolved fixed

86ce1f7

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/ResolvedType.java", "weaver/src/org/aspectj/weaver/WeaverMessages.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 78261 field pattern with "void" type should be compile-time error

We really should barf early on get(void i) as opposed to just compiling through and treating it as something that'll never match. I rated this as minor since this is just an error message issue.

resolved fixed

2b23e91

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 91114 [jdt-parser] Parser error on System.out.printf("..." + (after-before) + "...")

Following code fragment: ***************************** class Foo { public void bar () { long before = 0; long after = 0; System.out.println("... " + (before - after) + " ..."); } } ***************************** leads to following parser error ***************************** [...].java:25 [error] Syntax error on token "-", invalid AssignmentOperator System.out.println("... " + (before - after) + " ..."); ***************************** Problems seems to vanish when I rename the before variable.

resolved fixed

169a488

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 64568 Wildcarding in ITDs needs clearer compiler error message.

If a user attempts to define an ITD using a type pattern (illegal since AspectJ 1.1) they get back a compiler error message of the following form :- MyAspect.java:4 error Syntax error on token "*", around expected public String foo.bar.*.name; A clearer error message informing the user of their use of illegal syntax would help.

resolved fixed

5e9aca9

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 106634 regression: argument causes BcelGenericSignatureToTypeXConverter.java:203

the following reported a compile error using AspectJ Compiler DEVELOPMENT built on Monday Jun 20, 2005 at 08:14:57 GMT but now crashes using AspectJ Compiler DEVELOPMENT built on Wednesday Aug 10, 2005 at 13:12:53 GMT import java.util.Vector; // works if java.util.* is used public class Bug extends Vector { // works if Vector is not extended void test(DoesNotExist argument) {} // works without the argument } also, the bug only appears if the -1.5 flag is used.

resolved fixed

477c575

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 106461 org.aspectj.weaver.patterns.WildTypePattern.maybeGetCleanName(WildTypePattern.java:500)

resolved fixed

5735e96

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/patterns/PatternParser.java", "weaver/src/org/aspectj/weaver/patterns/WildTypePattern.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 104212 static method call from subclass signature is wrong

a very bad bug... or ? in the snip below, getMethod() says null and the factory is actually thinking that test() is a static method of AspectJBugMain instead of Assert... wondering why we don't catch that in the test suite or what could happen recently around that. Or is it something I am confused about ? (i doubt a jp.getSignature().getMethod is supposed to return null in some cases though..) @Aspect public class Sam { @Pointcut("call(* *.*(..))") public void methodCalls() { } @Around("methodCalls() && !within(alex.sam.Sam) && within(alex..*)") public Object aroundMethodCalls(ProceedingJoinPoint jp) throws Throwable { String typeName = jp.getSignature().getDeclaringTypeName(); System.out.println("declType " + typeName); System.out.println("method " + ((MethodSignature)jp.getSignature()).getMethod()); return jp.proceed(); } } class Assert { public static void test() { System.out.println("RUN Assert.test"); } } class AspectJBugMain extends Assert { public static void main(String[] args) { test(); } // public static void test() { // System.out.println("RUN AspectJBugMain.test"); // } }

resolved fixed

619a6ad

["tests/java5/ataspectj/ataspectj/Bug104212.java", "tests/src/org/aspectj/systemtest/ajc150/ataspectj/AtAjSyntaxTests.java", "weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java", "weaver/src/org/aspectj/weaver/bcel/BcelShadow.java", "weaver/src/org/aspectj/weaver/bcel/BcelWorld.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 103266 NPE on syntax error

This example program generates an NPE on CVS HEAD and M2. I will attach the ajcore file. public abstract aspect WorkerExample { after() returning (RequestContext newContext) : call(RequestContext+.new (..)) { System.out.println("constructing "+newContext+" at "+thisJoinPoint.toLongString()+" from "+thisEnclosingJoinPointStaticPart+":"); } public abstract class RequestContext { public final Object execute() { return doExecute(); } /** template method */ public abstract Object doExecute(); } public static void main(String args[]) { new Runnable() { public void run() {} }.run(); }; } aspect ConcreteAlpha extends WorkerExample { Object around(final Object runnable) : execution(void Runnable.run()) && this(runnable) { System.out.println("monitoring operation: "+runnable+" at "+thisJoinPoint+", for "+thisJoinPoint.getThis()); RequestContext requestContext = new RequestContext() { public Object doExecute() { return proceed(runnable); } }; return requestContext.execute(); } } aspect ConcreteBeta extends WorkerExample { Object around() : call(void awqeyuwqer()) { RequestContext requestContext = new ConnectionRequestContext() { public Object doExecute() { return proceed(); } }; return requestContext.execute(); } }

resolved fixed

bba9c50

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/MakeDeclsPublicVisitor.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 83935 @AJ and formal binding impl

Some notes on formal binding impl for @AJ In code style, the advice signature is always looking the same (..bindings.., org.aspectj.lang.Part thisJoinPointStaticPart, JoinPoint thisJoinPoint, org.aspectj.lang.Part thisEnclosingJoinPointStaticPart) In @ style, it is user defined. The current impl is handling the formal binding in a way that only args/this/target can be bound. I had to add some conditionals to handles cases like that: void myAdvice(JoinPoint jp, Object target) {..} where target() binding is at index 1, while the index 0 is not an unbound but actually "virtually" bound to the joinpoint. Pointcut are thus having a virtuallyBoundedNames String[] that is the list of arguments for which we don't want any complain if it not bound. This one is populated during @ extraction, and Pointcut.concretize() make sure the info is not lost when composition occurs (with PerClause f.e.) The only issue is that currently, binding JP/SJP/ESJP themselves is not possible f.e. "... && args(jp)" myAdvice(JoinPoint jp, JoinPoint currentJp) Is that a big issue ? May be impact adviceexecution() and could impact some use cases around mock testing.

resolved fixed

639b4fd

["tests/java5/ataspectj/ataspectj/MultipleBindingTest.java", "tests/java5/ataspectj/ataspectj/SingletonAspectBindingsTest.java", "tests/src/org/aspectj/systemtest/ajc150/ataspectj/AtAjSyntaxTests.java", "weaver/src/org/aspectj/weaver/bcel/BcelAdvice.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 100260 [generics][itds] methods inherited from a generic parent

when using an intertype declaration to add a method to a generic class, the method is not correctly inherited. the bug doesn't apply to fields. Strangely enough, raw types (generic types instantiated without specifying a type parameter) inherit the methods properly: class Generic_Parent<T> {} class Child extends Generic_Parent<Integer> {} class Generic_Child<T> extends Generic_Parent<Integer> {} aspect Injector { public void Generic_Parent.inherited_method() {} public int Generic_Parent.inherited_field; public void test() { int inherited_field; inherited_field = new Generic_Child().inherited_field; // works inherited_field = new Generic_Child<Integer>().inherited_field; // works inherited_field = new Child().inherited_field; // works new Generic_Child().inherited_method(); // works new Generic_Child<Integer>().inherited_method(); // unresolved new Child().inherited_method(); // unresolved } }

resolved fixed

b54831f

["tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 100227 [generics][itds] inner class with generic enclosing class

ajc crashes with a NullPointerException when an intertype declaration tries to modify an inner class, if the enclosing (outer) class is generic: class Outer { class Inner {} } class Generic_Outer<T> { class Inner {} } aspect Injector { int Outer.outer; // works int Outer.Inner.inner; // works int Generic_Outer.outer; // works int Generic_Outer.Inner.inner; // crashes } /home/user/sgelin3/dev/java/ajc/new_bug/Bug.java [error] Internal compiler error java.lang.NullPointerException at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.fromBinding(EclipseFactory.java:202) at org.aspectj.ajdt.internal.compiler.ast.InterTypeFieldDeclaration.build(InterTypeFieldDeclaration.java:173) at org.aspectj.ajdt.internal.compiler.ast.AspectDeclaration.buildInterTypeAndPerClause(AspectDeclaration.java:1020) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.buildInterTypeAndPerClause(AjLookupEnvironment.java:306) at org.aspectj.ajdt.internal.compiler.lookup.AjLookupEnvironment.completeTypeBindings(AjLookupEnvironment.java:122) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:302) at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:316) ...

resolved fixed

7d5002a

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/EclipseFactory.java", "tests/src/org/aspectj/systemtest/ajc150/Ajc150Tests.java", "weaver/src/org/aspectj/weaver/TypeX.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java

Bug 99168 [generics][itds] ITD on generic inner class crashes ajc

inter-type declaration on a generic inner class crashes the compiler: class Outer { class Inner {} class Generic_Inner<T> {} } class Generic_Outer<T> { } aspect Injector { int Outer.outer; // works int Outer.Inner.inner; // works int Generic_Outer.outer; // works int Outer.Generic_Inner.inner; // crashes } /home/user/sgelin3/dev/java/ajc/new_bug/Bug.java [error] Internal compiler error java.lang.RuntimeException: can't handle: class Generic_Inner#RAW extends NULL TYPENULL SUPERINTERFACES enclosing type : OuterNULL FIELDSNULL METHODS at org.aspectj.ajdt.internal.compiler.lookup.InterTypeScope.makeSourceTypeBinding(InterTypeScope.java:35) at org.aspectj.ajdt.internal.compiler.lookup.InterTypeScope.<init>(InterTypeScope.java:28) at org.aspectj.ajdt.internal.compiler.ast.InterTypeDeclaration.resolve(InterTypeDeclaration.java:101) at org.aspectj.ajdt.internal.compiler.ast.InterTypeFieldDeclaration.resolve(InterTypeFieldDeclaration.java:141) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1076) at org.aspectj.ajdt.internal.compiler.ast.AspectDeclaration.resolve(AspectDeclaration.java:110) at org.aspectj.org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1125) ...

resolved fixed

588023e

["org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/lookup/InterTypeScope.java"]

AspectJ

https://github.com/eclipse/org.aspectj

eclipse/org.aspectj

java