Datasets:

SamSaver

/

react-issues

like 0

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18234/builds/13578) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 89ba9114ec7fa6d1f502f38219186bf085eb9607:\n\n|Sandbox| Source |\n|--|--|\n|[confident-shannon-6b5zg](https://codesandbox.io/s/confident-shannon-6b5zg)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 4027f2a3b82ecc325224f7827fc2c8e71a284279...89ba9114ec7fa6d1f502f38219186bf085eb9607</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-dev.js | +0.5% | +0.6% | 907.29 KB | 911.46 KB | 202.52 KB | 203.64 KB | FB_WWW_DEV\nReactDOMServer-dev.js | +0.2% | +0.1% | 137.4 KB | 137.64 KB | 35.11 KB | 35.16 KB | FB_WWW_DEV\nReactDOMTesting-dev.js | 0.0% | 0.0% | 873.31 KB | 873.31 KB | 195.61 KB | 195.61 KB | FB_WWW_DEV\nreact-dom-server.node.development.js | 0.0% | -0.0% | 131.08 KB | 131.08 KB | 34.83 KB | 34.83 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\nreact-dom.development.js | 0.0% | 0.0% | 914.35 KB | 914.35 KB | 200.16 KB | 200.16 KB | UMD_DEV\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 136.87 KB | 136.87 KB | 34.99 KB | 34.99 KB | UMD_DEV\nReactTestUtils-dev.js | +0.5% | +0.4% | 51.37 KB | 51.61 KB | 13.72 KB | 13.77 KB | FB_WWW_DEV\nreact-dom.development.js | 0.0% | 0.0% | 870.34 KB | 870.34 KB | 197.7 KB | 197.7 KB | NODE_DEV\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 129.87 KB | 129.87 KB | 34.58 KB | 34.58 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **120.04 KB** | **120.04 KB** | **37.53 KB** | **37.52 KB** | **NODE_PROD**\n**ReactDOM-prod.js** | **0.0%** | **0.0%** | **376.26 KB** | **376.34 KB** | **68.37 KB** | **68.38 KB** | **FB_WWW_PROD**\nReactDOM-profiling.js | 0.0% | 0.0% | 387.95 KB | 388.04 KB | 70.54 KB | 70.55 KB | FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.87 KB | 55.87 KB | 14.47 KB | 14.47 KB | NODE_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **10 KB** | **10 KB** | **3.37 KB** | **3.38 KB** | **NODE_PROD**\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **-0.2%** | **1.16 KB** | **1.16 KB** | **663 B** | **662 B** | **NODE_PROD**\n\n## react-art\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-art.development.js | 0.0% | 0.0% | 635.52 KB | 635.52 KB | 133.57 KB | 133.57 KB | UMD_DEV\n**react-art.production.min.js** | **0.0%** | **0.0%** | **106.64 KB** | **106.64 KB** | **32.25 KB** | **32.25 KB** | **UMD_PROD**\nreact-art.development.js | 0.0% | 0.0% | 539.67 KB | 539.67 KB | 115.97 KB | 115.97 KB | NODE_DEV\nReactART-dev.js | +0.8% | +1.0% | 543.41 KB | 547.59 KB | 114.11 KB | 115.26 KB | FB_WWW_DEV\n**ReactART-prod.js** | **0.0%** | **0.0%** | **226.66 KB** | **226.7 KB** | **38.52 KB** | **38.53 KB** | **FB_WWW_PROD**\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 89ba9114ec7fa6d1f502f38219186bf085eb9607\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 4027f2a3b82ecc325224f7827fc2c8e71a284279...89ba9114ec7fa6d1f502f38219186bf085eb9607</p>\n\n\n \n## react-art\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactART-dev.js | +0.8% | +0.9% | 569.13 KB | 573.42 KB | 119.38 KB | 120.51 KB | FB_WWW_DEV\n**ReactART-prod.js** | **0.0%** | **0.0%** | **233.84 KB** | **233.88 KB** | **39.73 KB** | **39.74 KB** | **FB_WWW_PROD**\nreact-art.development.js | 0.0% | 0.0% | 616.35 KB | 616.35 KB | 130.17 KB | 130.17 KB | UMD_DEV\nreact-art.development.js | 0.0% | 0.0% | 521.24 KB | 521.25 KB | 112.53 KB | 112.53 KB | NODE_DEV\n\n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-profiling.js | 0.0% | 0.0% | 412.95 KB | 413.03 KB | 75.11 KB | 75.12 KB | FB_WWW_PROFILING\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 135.28 KB | 135.28 KB | 34.78 KB | 34.79 KB | UMD_DEV\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **-0.2%** | **1.15 KB** | **1.15 KB** | **654 B** | **653 B** | **NODE_PROD**\nReactTestUtils-dev.js | +0.5% | +0.4% | 51.38 KB | 51.62 KB | 13.71 KB | 13.76 KB | FB_WWW_DEV\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\nreact-dom.development.js | 0.0% | 0.0% | 885.67 KB | 885.67 KB | 195.23 KB | 195.23 KB | UMD_DEV\nreact-dom.development.js | 0.0% | 0.0% | 842.84 KB | 842.85 KB | 192.79 KB | 192.79 KB | NODE_DEV\nreact-dom-server.node.development.js | 0.0% | -0.0% | 129.57 KB | 129.57 KB | 34.61 KB | 34.61 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **116.09 KB** | **116.09 KB** | **36.5 KB** | **36.5 KB** | **NODE_PROD**\nReactDOM-dev.js | +0.5% | +0.5% | 950.85 KB | 955.14 KB | 212.11 KB | 213.25 KB | FB_WWW_DEV\n**ReactDOM-prod.js** | **0.0%** | **0.0%** | **401.18 KB** | **401.26 KB** | **72.85 KB** | **72.86 KB** | **FB_WWW_PROD**\nReactDOMTesting-dev.js | 0.0% | 0.0% | 899.95 KB | 899.95 KB | 201.19 KB | 201.19 KB | FB_WWW_DEV\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 128.35 KB | 128.35 KB | 34.36 KB | 34.36 KB | NODE_DEV\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 53.77 KB | 53.77 KB | 14 KB | 14 KB | UMD_DEV\nReactDOMServer-dev.js | +0.2% | +0.1% | 138.25 KB | 138.5 KB | 35.25 KB | 35.3 KB | FB_WWW_DEV\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.1% | 2.94 KB | 2.94 KB | 1.17 KB | 1.17 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 89ba9114ec7fa6d1f502f38219186bf085eb9607\n</p>\n" ]

[ "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 024a764310e64ef38963df16970364b9942a60cd...aa3719acd23e36924f8d9dfac40c8bd555751ee0</p>\n\n\n \n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactFabric-dev.js | +0.7% | +0.5% | 615.72 KB | 619.82 KB | 133.15 KB | 133.8 KB | RN_OSS_DEV\nReactNativeRenderer-dev.js | +0.7% | +0.5% | 633.61 KB | 637.87 KB | 137.47 KB | 138.14 KB | RN_OSS_DEV\n**ReactNativeRenderer-prod.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.2%** | **259.8 KB** | **260.13 KB** | **45.2 KB** | **45.27 KB** | **RN_OSS_PROD**\nReactNativeRenderer-profiling.js | +0.1% | +0.1% | 271.59 KB | 271.92 KB | 47.44 KB | 47.5 KB | RN_OSS_PROFILING\n**ReactFabric-prod.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **251.76 KB** | **251.96 KB** | **43.71 KB** | **43.75 KB** | **RN_OSS_PROD**\nReactFabric-profiling.js | +0.1% | +0.1% | 263.56 KB | 263.76 KB | 45.98 KB | 46.01 KB | RN_OSS_PROFILING\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against aa3719acd23e36924f8d9dfac40c8bd555751ee0\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 024a764310e64ef38963df16970364b9942a60cd...aa3719acd23e36924f8d9dfac40c8bd555751ee0</p>\n\n\n \n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \n**ReactNativeRenderer-prod.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.2%** | **259.81 KB** | **260.14 KB** | **45.21 KB** | **45.28 KB** | **RN_OSS_PROD**\nReactNativeRenderer-profiling.js | +0.1% | +0.1% | 271.61 KB | 271.94 KB | 47.45 KB | 47.51 KB | RN_OSS_PROFILING\n**ReactFabric-prod.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **251.77 KB** | **251.97 KB** | **43.72 KB** | **43.75 KB** | **RN_OSS_PROD**\nReactFabric-profiling.js | +0.1% | +0.1% | 263.57 KB | 263.77 KB | 45.99 KB | 46.02 KB | RN_OSS_PROFILING\nReactFabric-dev.js | +0.7% | +0.5% | 618.36 KB | 622.47 KB | 133.49 KB | 134.14 KB | RN_FB_DEV\n**ReactFabric-prod.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **251.93 KB** | **252.13 KB** | **43.75 KB** | **43.78 KB** | **RN_FB_PROD**\nReactNativeRenderer-dev.js | +0.7% | +0.5% | 633.63 KB | 637.88 KB | 137.47 KB | 138.15 KB | RN_OSS_DEV\nReactFabric-profiling.js | +0.1% | +0.1% | 263.72 KB | 263.92 KB | 46.02 KB | 46.06 KB | RN_FB_PROFILING\nReactNativeRenderer-dev.js | +0.7% | +0.5% | 636.25 KB | 640.51 KB | 137.81 KB | 138.48 KB | RN_FB_DEV\n**ReactNativeRenderer-prod.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.2%** | **259.96 KB** | **260.28 KB** | **45.23 KB** | **45.3 KB** | **RN_FB_PROD**\nReactNativeRenderer-profiling.js | +0.1% | +0.1% | 271.75 KB | 272.08 KB | 47.48 KB | 47.54 KB | RN_FB_PROFILING\nReactFabric-dev.js | +0.7% | +0.5% | 615.73 KB | 619.84 KB | 133.16 KB | 133.81 KB | RN_OSS_DEV\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against aa3719acd23e36924f8d9dfac40c8bd555751ee0\n</p>\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18233/builds/14290) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit aa3719acd23e36924f8d9dfac40c8bd555751ee0:\n\n|Sandbox| Source |\n|--|--|\n|[trusting-chaum-vgmil](https://codesandbox.io/s/trusting-chaum-vgmil)| Configuration |\n", "I reverted this to unblock the sync but it's probably an easy fix. Feel free to reland after fixing the Flow errors etc." ]

[ "Hi @kerolloz! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nIf you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Freact%20%2318232). Thanks!", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18232/builds/13488) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 95ec98e17ca6200a5cb08a67920e690b6c5050a1:\n\n|Sandbox| Source |\n|--|--|\n|[little-wave-2q723](https://codesandbox.io/s/little-wave-2q723)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 95ec98e17ca6200a5cb08a67920e690b6c5050a1\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 95ec98e17ca6200a5cb08a67920e690b6c5050a1\n</p>\n", "Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!", "Looks good to me. Thank you for your PR!" ]

[]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18230/builds/13486) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 266d7e1db2675f15c1612d4a068237e02fdf4123:\n\n|Sandbox| Source |\n|--|--|\n|[currying-wave-3nq51](https://codesandbox.io/s/currying-wave-3nq51)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 024a764310e64ef38963df16970364b9942a60cd...266d7e1db2675f15c1612d4a068237e02fdf4123</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom.profiling.min.js | 0.0% | -0.0% | 124.01 KB | 124.01 KB | 38.69 KB | 38.69 KB | NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 58.91 KB | 58.91 KB | 14.71 KB | 14.71 KB | UMD_DEV\nReactDOM-dev.js | +0.8% | +0.5% | 906.87 KB | 914.41 KB | 202.42 KB | 203.49 KB | FB_WWW_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.0%** | **10.27 KB** | **10.27 KB** | **3.5 KB** | **3.5 KB** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | -0.0% | 137.31 KB | 137.31 KB | 35.08 KB | 35.08 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 53.78 KB | 53.78 KB | 14.01 KB | 14.01 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.96 KB** | **10.96 KB** | **4.17 KB** | **4.17 KB** | **UMD_PROD**\nReactDOMTesting-dev.js | 0.0% | -0.0% | 872.9 KB | 872.9 KB | 195.5 KB | 195.49 KB | FB_WWW_DEV\nreact-dom-server.node.development.js | 0.0% | -0.0% | 131 KB | 131 KB | 34.81 KB | 34.81 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **-0.0%** | **20.83 KB** | **20.83 KB** | **7.61 KB** | **7.61 KB** | **NODE_PROD**\nreact-dom.development.js | 0.0% | -0.0% | 914.01 KB | 914.01 KB | 200.07 KB | 200.07 KB | UMD_DEV\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 136.78 KB | 136.78 KB | 34.96 KB | 34.96 KB | UMD_DEV\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **119.89 KB** | **119.89 KB** | **38.28 KB** | **38.28 KB** | **UMD_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **-0.0%** | **20.51 KB** | **20.51 KB** | **7.51 KB** | **7.51 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | -0.0% | 123.71 KB | 123.71 KB | 39.54 KB | 39.53 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | -0.0% | 870.01 KB | 870.01 KB | 197.61 KB | 197.61 KB | NODE_DEV\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 129.78 KB | 129.78 KB | 34.55 KB | 34.55 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **120.04 KB** | **120.04 KB** | **37.53 KB** | **37.52 KB** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **-0.0%** | **20.43 KB** | **20.43 KB** | **7.46 KB** | **7.46 KB** | **NODE_PROD**\nReactDOM-profiling.js | +1.4% | +1.2% | 387.95 KB | 393.52 KB | 70.54 KB | 71.37 KB | FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 55.87 KB | 55.87 KB | 14.47 KB | 14.47 KB | NODE_DEV\nreact-dom-unstable-fizz.node.development.js | 0.0% | -0.1% | 3.69 KB | 3.69 KB | 1.34 KB | 1.34 KB | NODE_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.0%** | **10 KB** | **10 KB** | **3.38 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **-0.3%** | **1.16 KB** | **1.16 KB** | **664 B** | **662 B** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.2% | 3.35 KB | 3.35 KB | 1.27 KB | 1.27 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **-0.1%** | **1.19 KB** | **1.19 KB** | **700 B** | **699 B** | **UMD_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.2% | 2.95 KB | 2.95 KB | 1.18 KB | 1.18 KB | NODE_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **-0.2%** | **1 KB** | **1 KB** | **611 B** | **610 B** | **NODE_PROD**\n\n## react-art\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-art.development.js | 0.0% | -0.0% | 635.35 KB | 635.35 KB | 133.49 KB | 133.49 KB | UMD_DEV\n**react-art.production.min.js** | **0.0%** | **-0.0%** | **106.64 KB** | **106.64 KB** | **32.25 KB** | **32.25 KB** | **UMD_PROD**\nreact-art.development.js | 0.0% | -0.0% | 539.5 KB | 539.5 KB | 115.89 KB | 115.89 KB | NODE_DEV\n**react-art.production.min.js** | **0.0%** | **-0.0%** | **71.62 KB** | **71.62 KB** | **21.44 KB** | **21.44 KB** | **NODE_PROD**\nReactART-dev.js | +1.4% | +1.0% | 543.15 KB | 550.69 KB | 114.02 KB | 115.16 KB | FB_WWW_DEV\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 266d7e1db2675f15c1612d4a068237e02fdf4123\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 024a764310e64ef38963df16970364b9942a60cd...266d7e1db2675f15c1612d4a068237e02fdf4123</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-profiling.js | +1.3% | +1.1% | 412.95 KB | 418.49 KB | 75.11 KB | 75.91 KB | FB_WWW_PROFILING\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 135.19 KB | 135.19 KB | 34.76 KB | 34.75 KB | UMD_DEV\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **-0.3%** | **1.15 KB** | **1.15 KB** | **655 B** | **653 B** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **-0.0%** | **20.05 KB** | **20.05 KB** | **7.42 KB** | **7.42 KB** | **UMD_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\nreact-dom.development.js | 0.0% | -0.0% | 885.33 KB | 885.33 KB | 195.14 KB | 195.14 KB | UMD_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.0%** | **9.99 KB** | **9.99 KB** | **3.37 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **116.01 KB** | **116.01 KB** | **37.17 KB** | **37.18 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | -0.0% | 119.72 KB | 119.72 KB | 38.39 KB | 38.39 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | -0.0% | 842.51 KB | 842.51 KB | 192.7 KB | 192.7 KB | NODE_DEV\nreact-dom-server.node.development.js | 0.0% | -0.0% | 129.48 KB | 129.48 KB | 34.59 KB | 34.58 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **116.09 KB** | **116.09 KB** | **36.5 KB** | **36.5 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **-0.0%** | **20.38 KB** | **20.38 KB** | **7.53 KB** | **7.53 KB** | **NODE_PROD**\nreact-dom.profiling.min.js | 0.0% | -0.0% | 119.95 KB | 119.95 KB | 37.63 KB | 37.63 KB | NODE_PROFILING\nReactDOM-dev.js | +0.8% | +0.5% | 950.44 KB | 957.97 KB | 212.01 KB | 213.07 KB | FB_WWW_DEV\nreact-dom-unstable-fizz.node.development.js | 0.0% | -0.1% | 3.68 KB | 3.68 KB | 1.33 KB | 1.33 KB | NODE_DEV\nReactDOMTesting-dev.js | 0.0% | -0.0% | 899.54 KB | 899.54 KB | 201.04 KB | 201.04 KB | FB_WWW_DEV\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 128.27 KB | 128.27 KB | 34.33 KB | 34.33 KB | NODE_DEV\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 53.77 KB | 53.77 KB | 14 KB | 14 KB | UMD_DEV\n**react-dom-server.browser.production.min.js** | **0.0%** | **-0.0%** | **19.97 KB** | **19.97 KB** | **7.38 KB** | **7.38 KB** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.2% | 3.34 KB | 3.34 KB | 1.26 KB | 1.26 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.94 KB** | **10.94 KB** | **4.16 KB** | **4.16 KB** | **UMD_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **-0.3%** | **1.17 KB** | **1.17 KB** | **692 B** | **690 B** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | -0.0% | 138.16 KB | 138.16 KB | 35.22 KB | 35.22 KB | FB_WWW_DEV\n**ReactDOMServer-prod.js** | **0.0%** | **-0.0%** | **47.49 KB** | **47.49 KB** | **11.05 KB** | **11.05 KB** | **FB_WWW_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.3% | 2.94 KB | 2.94 KB | 1.17 KB | 1.17 KB | NODE_DEV\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **-0.2%** | **1013 B** | **1013 B** | **603 B** | **602 B** | **NODE_PROD**\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.0%** | **10.26 KB** | **10.26 KB** | **3.49 KB** | **3.49 KB** | **UMD_PROD**\n\n## react-art\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactART-dev.js | +1.3% | +1.0% | 568.87 KB | 576.4 KB | 119.3 KB | 120.44 KB | FB_WWW_DEV\n**ReactART-prod.js** | **0.0%** | **0.0%** | **233.84 KB** | **233.84 KB** | **39.73 KB** | **39.74 KB** | **FB_WWW_PROD**\nreact-art.development.js | 0.0% | -0.0% | 616.17 KB | 616.17 KB | 130.09 KB | 130.09 KB | UMD_DEV\n**react-art.production.min.js** | **0.0%** | **-0.0%** | **104.21 KB** | **104.21 KB** | **31.61 KB** | **31.61 KB** | **UMD_PROD**\nreact-art.development.js | 0.0% | -0.0% | 521.07 KB | 521.07 KB | 112.45 KB | 112.45 KB | NODE_DEV\n**react-art.production.min.js** | **0.0%** | **-0.0%** | **69.25 KB** | **69.25 KB** | **20.79 KB** | **20.79 KB** | **NODE_PROD**\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 266d7e1db2675f15c1612d4a068237e02fdf4123\n</p>\n" ]

[ "This is seems like a non-problem: just add an array itself as a single dependency.", "@vkurchatkin I can't guarantee the referential equality of the array (it is derived itself, a list of ids mapped against a dictionary). The items within it stay referentially the same unless explcitily modified. \r\n\r\nTrying to keep the array referentially equal creates a whole host of cache invalidation issues and becomes very fragile in its implementation. \r\n\r\nThis is a problem anywhere where `useMemo` would want to reduce a variable length list. ", "Generally in React you should:\r\n - use immutable structures\r\n - use pure functions to transform immutable structures\r\n\r\nIf you follow these two rules, then `useMemo` just works.\r\n\r\n> is derived itself, a list of ids mapped against a dictionary\r\n\r\nIf it is derived, then you should derive it using `useMemo` as well\r\n\r\n", "@vkurchatkin I am following all these rules.\r\n\r\nI can't use `useMemo` to create it because of the issue above.\r\n\r\nConsider this:\r\n\r\nI have normalized dictionary of objects, they are immutable and I change it by doing shallow clones down to the appropriate level of change.\r\n\r\nElsewhere I store a list of selected IDs that reference the keys of that dictionary.\r\n\r\nI map that list into an array of the selected objects. I do not want to `useMemo` that because the IDs don't change but the items do, therefore due to the immutable nature in which I update the items I would be left with stale copies in that array. To `useMemo` that effectively I need to pass the variable length list of items in as dependencies again.\r\n\r\nI now want to derive some information from those selected items. I need `useMemo` to have the objects as dependencies. I am unable to because the size of the list of objects changes (the selection) and at the same the objects themselves will update (immutably hence why I can't store a referentially equal subset of them in an array). \r\n\r\nIn short I am trying to follow the principles but in this case `useMemo` does not work as I am unable to give it a variable dependency list when the data I am computing changes in size.\r\n\r\nI could `useMemo` and pass in the dictionary as a whole buts its hugely inefficient and causes tons of unnecessary recalculations of that data, that I only need to recompute if the selected items change.", "I don't understand the reasons behind this technical limitation, it feels weird to me that perhaps the simplest, cleanest, possible use of `useMemo` isn't supported out of the box:\r\n\r\n```ts\r\nuseMemo ( () => x, x );\r\n```", "I'd like to see this, too.\r\n\r\nAs a slightly-contrived example, let's consider the following case:\r\n\r\n```JavaScript\r\nfunction formValuesReducer(oldValues, update) {\r\n return { ...oldValues, [update[0]]: update[1] };\r\n}\r\n\r\nconst initialFormValues = {\r\n firstName: 'John',\r\n lastName: 'Doe',\r\n city: 'Boise',\r\n state: 'Idaho'\r\n};\r\n\r\nconst nameTemplatePieces = ['firstName', 'lastName'];\r\n\r\nconst MyComponent = (props) => {\r\n const formValues = useReducer(formValuesReducer, initialFormValues);\r\n \r\n const nameValues = useMemo(\r\n () => nameTemplatePieces.map(templatePieces => formValues[templatePieces]),\r\n [formValues, nameTemplatePieces]\r\n );\r\n \r\n const fullName = useMemo(\r\n () => doExpensiveOperation(nameValues),\r\n [nameValues]\r\n );\r\n}\r\n```\r\n\r\nIn the above example, `fullName` is recalculated any time that _any_ field in `formValues` changes. Ideally, though, `fullName` would only be recalculated when either `nameValues.firstName` or `nameValues.lastName` has changed.\r\n\r\nSince `nameTemplatePieces` is a constant with a fixed length, we could guarantee that `fullName` only gets recalculated when `nameValues.firstName` or `nameValues.lastName` change by changing this:\r\n\r\n```JavaScript\r\nconst fullName = useMemo(\r\n () => doExpensiveOperation(nameValues),\r\n [nameValues]\r\n );\r\n```\r\n\r\nto this:\r\n\r\n```JavaScript\r\nconst fullName = useMemo(\r\n () => doExpensiveOperation(nameValues),\r\n [...nameValues]\r\n );\r\n```\r\n\r\nHowever, if the length of `nameTemplatePieces` (and therefore `nameValues`) isn't fixed, then this no longer works, because React throws an error saying that the same number of arguments must always be passed to `useMemo()`", "This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "Yes I still care about this.", "I agree with OP, I also don't understand why instead of throwing an error \r\n`prevDeps.length !== nextDeps.length` can't just count as a change in the dependencies itself.\r\n\r\nI want to be able to memoize an array but spreading over the values inside the dependency would throw an error if the array changes in size.\r\n\r\nA temporary solution could be to use `JSON.stringify(arr)` inside hook's deps, but this will only work for serializable data.", "This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "This issue still affects me. Recoil is an example of a library that attempts to overcome this issue of memorising n length derived data from other derived data. ", "Yeah I've been bitten by this one too. Not a `useMemo`, but the same limitation and error: I wanted to fire a `useEffect` whenever the contents of a variable length array changes. The array could contain many different data shapes, and I want to check equality using `Object.is()` style strict equality, so tried to do this:\r\n\r\n```js\r\nlet items: T[] = [];\r\n// ^ or [{foo: true}], or [1,2,3], or [true] etc depending on the generics used outside of this component\r\n\r\nuseEffect(() => {\r\n console.log(\"changed\");\r\n}, items);\r\n```\r\nAnd obviously hit this odd limitation.\r\n\r\nMy potential approaches seem to be:\r\n- Use one `useEffect` per `item`? Items can change length, so the rules of hooks disallow this, which is fine. \r\n- Use one `useEffect` and pass in an array of items? The dependency length error is thrown.\r\n- Transform the array to get it into a format that `useEffect` is ok with\r\n - If the array is homogeneous, elements are uniquely identifiable, and the data shape can be known to the hook, then this can sometimes work i.e. `let users: User = [{id: 'foo'}];` and `useEffect(() => {}, [users.map(user => user.id).join(',')])`, but is not suitable for my case as I can't / shouldn't need to know the shape of the items in advance, and I need to use Object.is() style strict equality for comparison.\r\n - If the array is fine with being checked for equality deeply then `useEffect(() => {}, [JSON.stringify(items)])` might be ok sometimes, but is not suitable for my case as I need to use `Object.is()` style strict equality for comparison\r\n - If you're ok with a maximum limit on your items then maybe `useEffect(() => {}, Array(10).fill(undefined).map((v,i) => items[i]))`, but is not suitable for my case as I have no reasonable limit I can impose\r\n - Roll my own hook that circumvents the limitation\r\n \r\nSo just had to do the last one. It's for `useEffect`, but equally applicable to the other hooks. My tests say it's ok but please use it with caution.\r\n\r\n```js\r\nimport {useEffect, useRef} from 'react';\r\n\r\nconst equal = (a: unknown[], b: unknown[]): boolean => {\r\n if(a === b) return true;\r\n if(a.length !== b.length) return false;\r\n return a.every((e,i) => Object.is(e,b[i]));\r\n};\r\n\r\nexport const useEffectVariadic = (create: () => (() => void)|void, deps: unknown[]): void => {\r\n const prevDeps = useRef<unknown[]>([]);\r\n const count = useRef<number>(0);\r\n\r\n if(!equal(prevDeps.current, deps)) count.current++;\r\n prevDeps.current = deps;\r\n\r\n useEffect(create, [count.current]);\r\n};\r\n\r\n// usage like normal useEffect\r\n\r\nuseEffectVariadic(() => {\r\n console.log(\"hi\");\r\n}, variableLengthArrayOfStuff);\r\n```", "> > is derived itself, a list of ids mapped against a dictionary\r\n> \r\n> If it is derived, then you should derive it using `useMemo` as well\r\n\r\n\r\nI don't understand this at all. Going with the example of an API function that I don't control that returns a newly created array of results, could you please elaborate on how I could ensure that a certain value is only recalculated when the length or elements of this array change?", "I noticed that I can add the length of the array and then the elements and this works fine:\r\n`useMemo(() => x, [x.length, ...x]);`\r\nThe nice thing about it is that it even works for multiple arrays\r\n`[x.length, ...x, y.length, ...y]`\r\nAnd for arrays of arrays\r\n`[x.length, ...x.map(y => [y.length, ...y]).flat(1)]`\r\nAnd any variation of the above.\r\n\r\nI actually think that this strategy is much better than just passing arrays because one might accidentally do this:\r\n`[...x, ...y]`\r\nwhich would treat `x=[1,2];y=[3,4]` and `x=[1];y=[2,3,4]` as equal even with length mismatch detection, however this should definitely be mentioned in the docs. Currently useMemo doesn't even show an error on different lengths which is very confusing.", "I don't know how just adding the length and the elements is supposed to prevent the size of the dependencies from changing.\r\n\r\nI was thinking something might this might workaround the issue:\r\n```typescript\r\ntype DependencyList = ReadonlyArray<any>;\r\n\r\nfunction sameDeps(a: DependencyList, b: DependencyList): boolean {\r\n return a.length === b.length && a.every((value, index) => Object.is(value, b[index]));\r\n}\r\n\r\nfunction useMemoDynamic<T>(factory: () => T, deps: DependencyList): T {\r\n const ref = useRef<DependencyList>();\r\n const next = ref.current !== undefined && sameDeps(ref.current, deps) ? ref.current : deps;\r\n useEffect(() => { ref.current = next });\r\n return useMemo(factory, [next]);\r\n}\r\n```\r\n\r\nThis is a very frustrating problem. There are many reasons why the size of the dependencies should be able to grow and shrink while still conforming to all the hook rules.", "@steinybot the length of the dependency array can change and this should be detected, but that would only allow us to flatten one variable length collection into the dependency array, otherwise, eg. if we spread two arrays into a single dependency array, the arrays may change in a way that the resulting dependency array remains the same. Prepending the length of each variable length collection is a comparatively simple way to avoid this problem altogether such that we never even have to think about it.\r\n\r\nedit: the dependency array's length still changes but if we prepend lengths in this way then a difference is guaranteed to occur in the shorter of the old and new arrays and therefore comparing lengths is not necessary.", "After a bit of consideration I've realised that we should special case variable length arrays because allowing them in any dependency list would lead people to make the mistake I've discussed above and there's no way to detect that and issue warnings. React may consider adding a special hook for this because it cannot be intuitively expressed with the current ones, but I went ahead and created this package [@lbfalvy/react-utils](https://www.npmjs.com/package/@lbfalvy/react-utils#usearray) because if most people are getting by without it then maybe it shouldn't be taking space in the main React bundle.\r\n\r\nThe package has other stuff as well but it's tree-shakeable so it shouldn't end up in your bundles.", "This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "I believe the OP's suggestion is still the correct way to go.", "useMemo dependency length 发生改变的时候，建议是触发更新。就按字面意思来清楚 dependency 的改变，毕竟长度改变也的确证明依赖项发生了改变\r\n```\r\n// 同时认为如下的方式 是合理的，他们应该被判定为等价\r\nconst x1 = [1]; \r\nconst y1 = [2,3,4];\r\n\r\nconst x2 = [1, 2]; \r\nconst y2 = [3,4];\r\n\r\n[...x1, ...y1] === [...x2,...y2]\r\n```\r\n\r\n另外一个问题 为什么 dev 和 prod. 模式下两者表现不一致？ 因为有如下代码\r\n\r\n```\r\n// react-hot-loader\r\nvar hookWrapper = function hookWrapper(hook) {\r\n var wrappedHook = function wrappedHook(cb, deps) {\r\n if (configuration.reloadHooks && deps) {\r\n var inputs = [].concat(deps);\r\n\r\n // 重点在于它在结尾统一增加了 函数callback 导致数组判断的时候刚好行为不一致\r\n // reload hooks which have changed string representation\r\n if (configuration.reloadHooksOnBodyChange) {\r\n inputs.push(String(cb));\r\n }\r\n\r\n if (\r\n // reload hooks with dependencies\r\n deps.length > 0 ||\r\n // reload all hooks of option is set\r\n configuration.reloadLifeCycleHooks && deps.length === 0) {\r\n inputs.push(getHotGeneration());\r\n }\r\n\r\n return hook(cb, inputs);\r\n }\r\n return hook(cb, deps);\r\n };\r\n wrappedHook.isPatchedByReactHotLoader = true;\r\n return wrappedHook;\r\n};\r\n```\r\n因为 inputs.push(String(cb)); 的存在，导致。dependency 的依赖项的比较可能跟线上不一致，例如\r\ninput1 = [1, 2] output1 = [1,2, String(callback)]\r\ninput2 = [1, 2, 3] output2 = [1,2, 3, String(callback)]\r\n\r\n按照 useMemo 的 dependency 判断（不进行长度判断） prod : input1 == input2 , dev : output2 != output2; \r\n" ]

[ "Isn't it really dangerous to render an array without keys? Shouldn't it be treated as an error rather than a warning?\r\n\r\nIf all that needs to change is the error -> warning for `console` then I'd like to take this on as a PR.", "In my years of working in this ecosystem it has proved to be entirely benign durring development. But that may not be true for everyones compositions.\r\n\r\nIn many cases the arrays in question are static content being mapped to reduce space and provide a clear compositional architecture. You should key, that is not a question, when content may mutate depending on state. \r\n\r\nAs there are atleast two differing usecases, one, in which I would rather not hear at all about my usage, and another where an error would be appropriate. I can understand attempting to get the best of both worlds out of an error that says warning.", "This error is absolutely critical to address. It is **not** benign. We’ve had severe issues in the past when developers ignored it. Think sending a message to a wrong person or buying a wrong product. That’s what happens when one person thinks “this won’t reorder” then it does after another person’s change.\r\n\r\nIf the order is truly static you should be able to express it in JSX without using arrays. As a last resort you can spread children manually as rest arguments to `createElement` — which is what JSX does today for static children. But do this at your own peril. This is dangerous. ", "I know my usecase may not be everyone elses. But I was under the impression that this message would be suppressed aswell as per the readme of react and verbage.\r\n\r\n```\r\nNote: by default, React will be in development mode. The development version includes extra warnings about common mistakes, whereas the production version includes extra performance optimizations and strips all error messages. Don't forget to use the production build when deploying your application.\r\n```\r\n\r\nI test production to observe how it will behave and was under the impression that would have been my first line of catching distracting messages. I do appreciate your suggestion however considering who you are. My want for perfect magic stringless functional code and a process that might not be everyones cup of tea falls under features if thats your opinion and I'll just edit it in on my own copy to reduce the error to a warn while I'm over here grinding it out alone.\r\n\r\nBetter yet! Could you please reference me in the direction of addressing keys better than grep? And a means of replicating your present issues and limitations in unkeyed serial elements?" ]

[ "Hi @bvaughn, I'd like to take this ticket", "This issue is all yours! 😄\r\n\r\nI've added the **\"good first issue (taken)\"** label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.\r\n\r\nCheers!", "I'm going to go ahead and roll this into #18226 :smile:", "Implemented via #18248" ]

[ "Hello @bvaughn, I want to get started with this issue, I am not sure which one is the \"standalone DevTools\".\r\n I think https://github.com/facebook/react/tree/master/packages/react-devtools is what you mean, right? ", "Yes, that's the one.", "This issue is all yours! 😄\r\n\r\nI've added the **\"good first issue (taken)\"** label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.\r\n\r\nCheers!", "Thank you @bvaughn :smile: \r\n\r\nfor the past two hours, I have been trying to get started with building the package from source as [mentioned](https://github.com/facebook/react/tree/master/packages/react-devtools#build-from-source). \r\nI did `yarn build-for-devtools` but it throws the following error \r\n\r\n```\r\n➜ yarn build-for-devtools\r\n\r\nyarn run v1.22.0\r\n$ cross-env RELEASE_CHANNEL=experimental yarn build -- react/index,react-dom,react-is,react-debug-tools,scheduler,react-test-renderer --type=NODE\r\nwarning From Yarn 1.0 onwards, scripts don't require \"--\" for options to be forwarded. In a future version, any explicit \"--\" will be forwarded as-is to the scripts.\r\n$ node ./scripts/rollup/build.js react/index,react-dom,react-is,react-debug-tools,scheduler,react-test-renderer --type=NODE\r\n BUILDING react.development.js (node_dev)\r\n COMPLETE react.development.js (node_dev)\r\n\r\n BUILDING react.production.min.js (node_prod)\r\n OH NOES! react.production.min.js (node_prod)\r\n \r\n-- PLUGIN_ERROR (scripts/rollup/plugins/closure-plugin) -- \r\nError: Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true \r\n \r\n at /home/kerolloz/react/scripts/rollup/plugins/closure-plugin.js:16:16 \r\n at ChildProcess.<anonymous> (/home/kerolloz/react/node_modules/google-closure-compiler/lib/node/closure-compiler.js:103:9) \r\n at ChildProcess.emit (events.js:321:20) \r\n at maybeClose (internal/child_process.js:1026:16) \r\n at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5) \r\nerror Command failed with exit code 1. \r\ninfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.\r\nerror Command failed with exit code 1.\r\ninfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.\r\n```\r\n---\r\nmore info: \r\n\r\n\r\nis this a problem with Java?", "You'll need Java to build React source, because of the Closure Compiler, but I suggest just using the [download script](https://github.com/facebook/react/tree/master/packages/react-devtools#download-from-ci) instead.\r\n```\r\n./scripts/release/download-experimental-build.js\r\n```\r\nShould only take a few seconds.", "Thank you @bvaughn :smile: \r\nI tried using the script but it depends on some packages that didn't exist despite running `yarn` in the main root directory. \r\n\r\n---\r\nback to the `yarn build-for-devtools` command\r\nI followed the stack trace of the error and I managed to fix it.\r\nhttps://github.com/facebook/react/blob/024a764310e64ef38963df16970364b9942a60cd/scripts/rollup/plugins/closure-plugin.js#L9-L20\r\n\r\nI changed line 13 to be `if (!exitCode)` instead of `if (!stdErr)` and the issue was fixed and I managed to compile it. ", "oh my bad\r\nI should have run `yarn` first inside the _`scripts/release`_ dir. Sorry.\r\n\r\n", "for the sake of documenting the errors I face, when I try to run `yarn start` at _`react/packages/react-devtools`_ nothing happens. I tried running the electron executable at _`node_modules`_ dir and the following error was given \r\n```\r\n➜ ./node_modules/.bin/electron \r\n[112941:0306/004904.433464:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/kerolloz/react/node_modules/electron/dist/chrome-sandbox is owned by root and has mode 4755.\r\n```\r\nThat is how I managed to solve it.\r\n```sh\r\nsudo sysctl kernel.unprivileged_userns_clone=1\r\n```\r\n\r\nrefer to: https://github.com/electron/electron/issues/17972", "Hi @bvaughn \r\nI have been playing around the devtools packages codebase the whole night. I'm a little bit confused, I should implement the tab switching shortcut feature in the _`rect-devtools`_ dir. I don't really get to understand how the standalone devtools is connected to the frontend part. I see frontend bridge. what is the right approach to get started implementing the shortcuts feature only for the standalone version. According to Electron documentation, the [keyboard shortcuts](https://www.electronjs.org/docs/tutorial/keyboard-shortcuts) suggests 3 approaches, I see that the first approach might be a good choice (Local Shortcuts). but how can I manage the frontend part and switch tab from the electron part?", "@kerolloz In case the READMEs aren't clear, here's a high level overview of the DevTools packages:\r\n* [`packages/react-devtools-core`](https://github.com/facebook/react/tree/master/packages/react-devtools-core): Lower level package used by the standalone shell, React Native, and some other dev tooling.\r\n* [`packages/react-devtools-extensions`](https://github.com/facebook/react/tree/master/packages/react-devtools-extensions): Browser-specific code for extensions.\r\n* [`packages/react-devtools-inline`](https://github.com/facebook/react/tree/master/packages/react-devtools-inline): Embed friendly version of DevTools used by Code Sandbox.\r\n* [`packages/react-devtools-shared`](https://github.com/facebook/react/tree/master/packages/react-devtools-shared): Code shared between all of the other packages.\r\n* [`packages/react-devtools-shell`](https://github.com/facebook/react/tree/master/packages/react-devtools-shell): Test harness used for local development.\r\n* [`packages/react-devtools`](https://github.com/facebook/react/tree/master/packages/react-devtools): Small wrapper around core package that launches an Electron shell with the DevTools UI embedded into it.\r\n\r\nWorking on this feature will mean you'll want to test the following packages:\r\n* `packages/react-devtools-core`: This is the standalone UI with built-in tabs.\r\n* `packages/react-devtools-inline`: This UI has built-in tabs too.\r\n* `packages/react-devtools-shell`: This UI has tabs too and also allows you to test the change more quickly when you're initially working on it.\r\n\r\nYou will also likely end up needing to work with `packages/react-devtools-shared` since it's where most of the code lives. 🙂 Specifically, you may end up adding code to:\r\n* [`DevTools`](https://github.com/facebook/react/blob/master/packages/react-devtools-shared/src/devtools/views/DevTools.js) to remember the last selected tab, set the right default, and wire up the shortcut keys. (Although please be sure to only do this if `showTabBar` is true.)\r\n* [`TabBar`](https://github.com/facebook/react/blob/master/packages/react-devtools-shared/src/devtools/views/TabBar.js) since this is where the Tabs live. (You may not need to do anything here though.)\r\n\r\nI do not expected that you would end up needing to do anything in either `packages/react-devtools` or `packages/react-devtools-extensions`." ]

[ "<img width=\"1300\" alt=\"image\" src=\"https://user-images.githubusercontent.com/2384105/76006956-3fbf3100-5f48-11ea-8323-1c929eb9d129.png\">\r\nit seems that wrong happen at yarn build step", "Can you change the path from `/cjs/` to `/umd/` and try again?", "You need to build `--type=NODE` for npm packages. \r\nI clarified in https://github.com/reactjs/reactjs.org/commit/b3c7540a10498328d981e38731253ffa0e1798d4." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18224/builds/13472) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 2176e6d935d518946e53b107b8226501d67df9bb:\n\n|Sandbox| Source |\n|--|--|\n|[ancient-breeze-vjpd0](https://codesandbox.io/s/ancient-breeze-vjpd0)| Configuration |\n|[Context.Consumer.displayName](https://codesandbox.io/s/contextconsumerdisplayname-yyvl0)| PR |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 3ee812e6b67d52a6f262144e78721f9340c36a04...2176e6d935d518946e53b107b8226501d67df9bb</p>\n\n\n \n## react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact.development.js | +0.7% | +0.5% | 99.63 KB | 100.31 KB | 24.51 KB | 24.65 KB | UMD_DEV\n**react.production.min.js** | **0.0%** | **0.0%** | **11.59 KB** | **11.59 KB** | **4.56 KB** | **4.56 KB** | **UMD_PROD**\nreact.profiling.min.js | 0.0% | 0.0% | 15.13 KB | 15.13 KB | 5.67 KB | 5.68 KB | UMD_PROFILING\nreact.development.js | +1.1% | +0.8% | 61.49 KB | 62.14 KB | 16.79 KB | 16.92 KB | NODE_DEV\n**react.production.min.js** | **0.0%** | **0.0%** | **6.53 KB** | **6.53 KB** | **2.65 KB** | **2.65 KB** | **NODE_PROD**\nReact-dev.js | +0.9% | +0.6% | 74.61 KB | 75.3 KB | 18.95 KB | 19.07 KB | FB_WWW_DEV\n**React-prod.js** | **0.0%** | **0.0%** | **17.69 KB** | **17.69 KB** | **4.56 KB** | **4.56 KB** | **FB_WWW_PROD**\nReact-profiling.js | 0.0% | 0.0% | 17.69 KB | 17.69 KB | 4.56 KB | 4.56 KB | FB_WWW_PROFILING\n\n </details>\n \n\nReact: size: 0.0%, gzip: 0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2176e6d935d518946e53b107b8226501d67df9bb\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 3ee812e6b67d52a6f262144e78721f9340c36a04...2176e6d935d518946e53b107b8226501d67df9bb</p>\n\n\n \n## react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact.development.js | +0.6% | +0.5% | 107.52 KB | 108.2 KB | 25.72 KB | 25.85 KB | UMD_DEV\n**react.production.min.js** | **0.0%** | **0.0%** | **12.45 KB** | **12.45 KB** | **4.8 KB** | **4.8 KB** | **UMD_PROD**\nreact.profiling.min.js | 0.0% | 0.0% | 15.98 KB | 15.98 KB | 5.88 KB | 5.88 KB | UMD_PROFILING\nreact.development.js | +0.9% | +0.6% | 69.02 KB | 69.67 KB | 18 KB | 18.11 KB | NODE_DEV\n**react.production.min.js** | **0.0%** | **0.0%** | **7.5 KB** | **7.5 KB** | **2.9 KB** | **2.9 KB** | **NODE_PROD**\nReact-dev.js | +0.9% | +0.7% | 73.93 KB | 74.62 KB | 18.77 KB | 18.89 KB | FB_WWW_DEV\n**React-prod.js** | **0.0%** | **0.0%** | **17.63 KB** | **17.63 KB** | **4.55 KB** | **4.55 KB** | **FB_WWW_PROD**\nReact-profiling.js | 0.0% | 0.0% | 17.63 KB | 17.63 KB | 4.55 KB | 4.55 KB | FB_WWW_PROFILING\n\n </details>\n \n\nReact: size: 0.0%, gzip: 0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2176e6d935d518946e53b107b8226501d67df9bb\n</p>\n", "I ran a local sync on this version and verified that the internal test the previous PR broke passes now." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18223/builds/13457) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit a4f6cfe86a8dd4e0326fa5933987f5e0f20cd5fc:\n\n|Sandbox| Source |\n|--|--|\n|[elated-curran-nzrtk](https://codesandbox.io/s/elated-curran-nzrtk)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 6a0efddd892d4bf931c089f1ac772a5736dc7edd...a4f6cfe86a8dd4e0326fa5933987f5e0f20cd5fc</p>\n\n\n \n## react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact.development.js | -0.3% | -0.2% | 107.82 KB | 107.52 KB | 25.77 KB | 25.72 KB | UMD_DEV\n**react.production.min.js** | **0.0%** | **0.0%** | **12.45 KB** | **12.45 KB** | **4.8 KB** | **4.8 KB** | **UMD_PROD**\nreact.profiling.min.js | 0.0% | 0.0% | 15.98 KB | 15.98 KB | 5.88 KB | 5.88 KB | UMD_PROFILING\nreact.development.js | -0.4% | -0.2% | 69.3 KB | 69.02 KB | 18.04 KB | 18 KB | NODE_DEV\nReact-dev.js | -0.4% | -0.2% | 74.21 KB | 73.93 KB | 18.82 KB | 18.77 KB | FB_WWW_DEV\n**React-prod.js** | **0.0%** | **0.0%** | **17.63 KB** | **17.63 KB** | **4.55 KB** | **4.55 KB** | **FB_WWW_PROD**\nReact-profiling.js | 0.0% | 0.0% | 17.63 KB | 17.63 KB | 4.55 KB | 4.55 KB | FB_WWW_PROFILING\n\n </details>\n \n\nReact: size: 0.0%, gzip: 0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a4f6cfe86a8dd4e0326fa5933987f5e0f20cd5fc\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 6a0efddd892d4bf931c089f1ac772a5736dc7edd...a4f6cfe86a8dd4e0326fa5933987f5e0f20cd5fc</p>\n\n\n \n## react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact.development.js | -0.3% | -0.2% | 99.93 KB | 99.63 KB | 24.56 KB | 24.51 KB | UMD_DEV\n**react.production.min.js** | **0.0%** | **0.0%** | **11.59 KB** | **11.59 KB** | **4.56 KB** | **4.56 KB** | **UMD_PROD**\nreact.profiling.min.js | 0.0% | 0.0% | 15.13 KB | 15.13 KB | 5.67 KB | 5.67 KB | UMD_PROFILING\nreact.development.js | -0.5% | -0.3% | 61.77 KB | 61.49 KB | 16.84 KB | 16.79 KB | NODE_DEV\nReact-dev.js | -0.4% | -0.2% | 74.88 KB | 74.61 KB | 19 KB | 18.95 KB | FB_WWW_DEV\n**React-prod.js** | **0.0%** | **0.0%** | **17.69 KB** | **17.69 KB** | **4.56 KB** | **4.56 KB** | **FB_WWW_PROD**\nReact-profiling.js | 0.0% | 0.0% | 17.69 KB | 17.69 KB | 4.56 KB | 4.56 KB | FB_WWW_PROFILING\n\n </details>\n \n\nReact: size: 0.0%, gzip: 0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a4f6cfe86a8dd4e0326fa5933987f5e0f20cd5fc\n</p>\n", "@trueadm Could you share what you're doing internally so that we can get this in properly?", "You mean you're setting the `displayName` on the consumer not context type, right? Like `Context.Consumer.displayName = 'Unused'`? Is this even supported by react-devtools?", "Even if it's unsupported, this is a breaking change if not fixed. :-)", "> Even if it's unsupported, this is a breaking change if not fixed. :-)\r\n\r\nSure I can go ahead and add a warning to the setter. I just think this stance locks any object shape once released because someone might set unsupported properties. \r\n\r\nI just need to know what the expected behavior should be.", "Sorry, I meant the context consumer object." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18222/builds/13510) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 49e68a03e7f17382a3042e491dfa1abdfb5c2df1:\n\n|Sandbox| Source |\n|--|--|\n|[lucid-moore-5tcps](https://codesandbox.io/s/lucid-moore-5tcps)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 6a0efddd892d4bf931c089f1ac772a5736dc7edd...49e68a03e7f17382a3042e491dfa1abdfb5c2df1</p>\n\n\n \n## react-test-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactTestRenderer-dev.js | +0.1% | +0.1% | 553.46 KB | 553.88 KB | 116.82 KB | 116.93 KB | FB_WWW_DEV\nreact-test-renderer-shallow.development.js | 0.0% | -0.0% | 38.39 KB | 38.39 KB | 9.29 KB | 9.29 KB | UMD_DEV\n**react-test-renderer-shallow.production.min.js** | **0.0%** | **0.0%** | **12.91 KB** | **12.91 KB** | **3.93 KB** | **3.93 KB** | **UMD_PROD**\nreact-test-renderer.development.js | +0.1% | +0.1% | 552.33 KB | 552.67 KB | 114.97 KB | 115.07 KB | UMD_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **-0.0%** | **71.22 KB** | **71.22 KB** | **21.66 KB** | **21.66 KB** | **UMD_PROD**\nreact-test-renderer.development.js | +0.1% | +0.1% | 526.38 KB | 526.72 KB | 113.66 KB | 113.76 KB | NODE_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **0.0%** | **71.04 KB** | **71.04 KB** | **21.34 KB** | **21.34 KB** | **NODE_PROD**\n\n## react-reconciler\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-reconciler.development.js | +0.1% | +0.1% | 555.93 KB | 556.27 KB | 117.59 KB | 117.7 KB | NODE_DEV\nreact-reconciler-reflection.development.js | 0.0% | 0.0% | 16.24 KB | 16.24 KB | 4.96 KB | 4.96 KB | NODE_DEV\n**react-reconciler-reflection.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **2.8 KB** | **2.8 KB** | **1.2 KB** | **1.2 KB** | **NODE_PROD**\nreact-reconciler-persistent.development.js | +0.1% | +0.1% | 554.58 KB | 554.99 KB | 117.45 KB | 117.56 KB | NODE_DEV\n**react-reconciler-persistent.production.min.js** | **0.0%** | **0.0%** | **73.72 KB** | **73.72 KB** | **21.78 KB** | **21.78 KB** | **NODE_PROD**\n\n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom-server.browser.development.js | +0.1% | +0.1% | 135.19 KB | 135.28 KB | 34.75 KB | 34.78 KB | UMD_DEV\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1.15 KB** | **1.15 KB** | **652 B** | **653 B** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.05 KB** | **20.05 KB** | **7.42 KB** | **7.42 KB** | **UMD_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\nreact-dom.development.js | 0.0% | 0.0% | 884.16 KB | 884.5 KB | 194.84 KB | 194.94 KB | UMD_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **9.99 KB** | **9.99 KB** | **3.36 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **116.01 KB** | **116.01 KB** | **37.17 KB** | **37.17 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 119.54 KB | 119.54 KB | 38.33 KB | 38.33 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | +0.1% | 841.41 KB | 841.74 KB | 192.41 KB | 192.51 KB | NODE_DEV\nreact-dom-server.node.development.js | +0.1% | +0.1% | 129.48 KB | 129.57 KB | 34.58 KB | 34.61 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **116.09 KB** | **116.09 KB** | **36.5 KB** | **36.5 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **0.0%** | **20.38 KB** | **20.38 KB** | **7.52 KB** | **7.53 KB** | **NODE_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 119.77 KB | 119.77 KB | 37.58 KB | 37.58 KB | NODE_PROFILING\nReactDOM-dev.js | 0.0% | 0.0% | 949.32 KB | 949.74 KB | 211.7 KB | 211.8 KB | FB_WWW_DEV\nreact-dom-unstable-fizz.node.development.js | 0.0% | +0.1% | 3.68 KB | 3.68 KB | 1.33 KB | 1.33 KB | NODE_DEV\nReactDOMTesting-dev.js | 0.0% | +0.1% | 899.4 KB | 899.81 KB | 201 KB | 201.16 KB | FB_WWW_DEV\nreact-dom-server.browser.development.js | +0.1% | +0.1% | 128.27 KB | 128.35 KB | 34.33 KB | 34.36 KB | NODE_DEV\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 53.77 KB | 53.77 KB | 14 KB | 14 KB | UMD_DEV\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **19.97 KB** | **19.97 KB** | **7.38 KB** | **7.38 KB** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.2% | 3.34 KB | 3.34 KB | 1.26 KB | 1.26 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.94 KB** | **10.94 KB** | **4.16 KB** | **4.16 KB** | **UMD_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.3%** | **1.17 KB** | **1.17 KB** | **689 B** | **691 B** | **UMD_PROD**\nReactDOMServer-dev.js | +0.1% | +0.1% | 138.16 KB | 138.25 KB | 35.22 KB | 35.25 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 49.55 KB | 49.55 KB | 13.51 KB | 13.51 KB | NODE_DEV\n**ReactDOMServer-prod.js** | **0.0%** | **-0.0%** | **47.49 KB** | **47.49 KB** | **11.05 KB** | **11.05 KB** | **FB_WWW_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.3% | 2.94 KB | 2.94 KB | 1.17 KB | 1.17 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.3%** | **1013 B** | **1013 B** | **600 B** | **602 B** | **NODE_PROD**\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.26 KB** | **10.26 KB** | **3.49 KB** | **3.49 KB** | **UMD_PROD**\n\n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactFabric-dev.js | 0.0% | +0.1% | 614.69 KB | 614.87 KB | 132.86 KB | 132.94 KB | RN_OSS_DEV\nReactNativeRenderer-dev.js | +0.1% | +0.1% | 632.59 KB | 632.92 KB | 137.13 KB | 137.23 KB | RN_OSS_DEV\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.13 KB | 271.13 KB | 47.34 KB | 47.34 KB | RN_OSS_PROFILING\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 49e68a03e7f17382a3042e491dfa1abdfb5c2df1\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 6a0efddd892d4bf931c089f1ac772a5736dc7edd...49e68a03e7f17382a3042e491dfa1abdfb5c2df1</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom.profiling.min.js | 0.0% | 0.0% | 123.84 KB | 123.84 KB | 38.64 KB | 38.64 KB | NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.91 KB | 58.91 KB | 14.71 KB | 14.71 KB | UMD_DEV\nReactDOM-dev.js | 0.0% | 0.0% | 905.76 KB | 906.17 KB | 202.13 KB | 202.22 KB | FB_WWW_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.27 KB** | **10.27 KB** | **3.49 KB** | **3.5 KB** | **UMD_PROD**\nReactDOMServer-dev.js | +0.1% | +0.1% | 137.31 KB | 137.4 KB | 35.08 KB | 35.12 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 53.78 KB | 53.78 KB | 14.01 KB | 14.01 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.96 KB** | **10.96 KB** | **4.17 KB** | **4.17 KB** | **UMD_PROD**\nReactDOMTesting-dev.js | 0.0% | +0.1% | 872.76 KB | 873.17 KB | 195.47 KB | 195.59 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **0.0%** | **0.0%** | **368.74 KB** | **368.74 KB** | **67.46 KB** | **67.46 KB** | **FB_WWW_PROD**\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 49.56 KB | 49.56 KB | 13.52 KB | 13.52 KB | NODE_DEV\nReactDOMTesting-profiling.js | 0.0% | 0.0% | 368.74 KB | 368.74 KB | 67.46 KB | 67.46 KB | FB_WWW_PROFILING\nreact-dom-server.node.development.js | +0.1% | +0.1% | 131 KB | 131.08 KB | 34.81 KB | 34.83 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **0.0%** | **20.83 KB** | **20.83 KB** | **7.61 KB** | **7.61 KB** | **NODE_PROD**\nreact-dom.development.js | 0.0% | 0.0% | 912.84 KB | 913.18 KB | 199.76 KB | 199.86 KB | UMD_DEV\nreact-dom-server.browser.development.js | +0.1% | +0.1% | 136.78 KB | 136.87 KB | 34.96 KB | 34.99 KB | UMD_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **119.89 KB** | **119.89 KB** | **38.28 KB** | **38.28 KB** | **UMD_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.51 KB** | **20.51 KB** | **7.51 KB** | **7.51 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 123.54 KB | 123.54 KB | 39.47 KB | 39.47 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | 0.0% | 868.91 KB | 869.24 KB | 197.31 KB | 197.4 KB | NODE_DEV\nreact-dom-server.browser.development.js | +0.1% | +0.1% | 129.78 KB | 129.87 KB | 34.55 KB | 34.58 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **120.04 KB** | **120.04 KB** | **37.52 KB** | **37.53 KB** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.43 KB** | **20.43 KB** | **7.46 KB** | **7.46 KB** | **NODE_PROD**\n**ReactDOM-prod.js** | **0.0%** | **0.0%** | **376.26 KB** | **376.26 KB** | **68.37 KB** | **68.37 KB** | **FB_WWW_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.87 KB | 55.87 KB | 14.47 KB | 14.47 KB | NODE_DEV\nreact-dom-unstable-fizz.node.development.js | 0.0% | +0.1% | 3.69 KB | 3.69 KB | 1.34 KB | 1.34 KB | NODE_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10 KB** | **10 KB** | **3.37 KB** | **3.38 KB** | **NODE_PROD**\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1.16 KB** | **1.16 KB** | **661 B** | **662 B** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.2% | 3.35 KB | 3.35 KB | 1.27 KB | 1.27 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.3%** | **1.19 KB** | **1.19 KB** | **697 B** | **699 B** | **UMD_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.2% | 2.95 KB | 2.95 KB | 1.18 KB | 1.18 KB | NODE_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.3%** | **1 KB** | **1 KB** | **608 B** | **610 B** | **NODE_PROD**\n\n## react-test-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactTestRenderer-dev.js | +0.1% | +0.1% | 553.47 KB | 553.89 KB | 116.83 KB | 116.94 KB | FB_WWW_DEV\nreact-test-renderer-shallow.development.js | 0.0% | -0.0% | 38.4 KB | 38.4 KB | 9.3 KB | 9.3 KB | UMD_DEV\n**react-test-renderer-shallow.production.min.js** | **0.0%** | **0.0%** | **12.92 KB** | **12.92 KB** | **3.94 KB** | **3.94 KB** | **UMD_PROD**\nreact-test-renderer.development.js | +0.1% | +0.1% | 552.35 KB | 552.69 KB | 114.98 KB | 115.08 KB | UMD_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **-0.0%** | **71.25 KB** | **71.25 KB** | **21.67 KB** | **21.67 KB** | **UMD_PROD**\nreact-test-renderer.development.js | +0.1% | +0.1% | 526.41 KB | 526.74 KB | 113.68 KB | 113.77 KB | NODE_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **0.0%** | **71.06 KB** | **71.06 KB** | **21.36 KB** | **21.36 KB** | **NODE_PROD**\n\n## react-reconciler\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-reconciler-persistent.development.js | +0.1% | +0.1% | 554.59 KB | 555 KB | 117.46 KB | 117.56 KB | NODE_DEV\nreact-reconciler-reflection.development.js | 0.0% | 0.0% | 16.25 KB | 16.25 KB | 4.96 KB | 4.97 KB | NODE_DEV\n**react-reconciler-persistent.production.min.js** | **0.0%** | **0.0%** | **73.73 KB** | **73.73 KB** | **21.78 KB** | **21.78 KB** | **NODE_PROD**\n**react-reconciler-reflection.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **2.81 KB** | **2.81 KB** | **1.21 KB** | **1.21 KB** | **NODE_PROD**\nreact-reconciler.development.js | +0.1% | +0.1% | 576.69 KB | 577.02 KB | 121.48 KB | 121.58 KB | NODE_DEV\n**react-reconciler.production.min.js** | **0.0%** | **0.0%** | **76.48 KB** | **76.48 KB** | **22.44 KB** | **22.44 KB** | **NODE_PROD**\n\n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.15 KB | 271.15 KB | 47.35 KB | 47.35 KB | RN_OSS_PROFILING\nReactFabric-dev.js | 0.0% | +0.1% | 617.34 KB | 617.6 KB | 133.2 KB | 133.28 KB | RN_FB_DEV\nReactNativeRenderer-dev.js | +0.1% | +0.1% | 632.6 KB | 632.93 KB | 137.13 KB | 137.23 KB | RN_OSS_DEV\nReactNativeRenderer-dev.js | +0.1% | +0.1% | 635.23 KB | 635.64 KB | 137.47 KB | 137.58 KB | RN_FB_DEV\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.29 KB | 271.29 KB | 47.4 KB | 47.4 KB | RN_FB_PROFILING\nReactFabric-dev.js | 0.0% | +0.1% | 614.7 KB | 614.88 KB | 132.87 KB | 132.95 KB | RN_OSS_DEV\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: :small_red_triangle:+0.1%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 49e68a03e7f17382a3042e491dfa1abdfb5c2df1\n</p>\n", "FB: The stack of D20282825 explains the reasons behind this change for FB employees.", "A comment definitely, would be extra nice to have a test or lint rule. Otherwise this absolutely will regress." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18221/builds/13440) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 0e4859dce635a9c9e0af3c6dfb23bc6d6a60b45c:\n\n|Sandbox| Source |\n|--|--|\n|[confident-davinci-u4tqf](https://codesandbox.io/s/confident-davinci-u4tqf)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 60b11f6c1be111c14c3607809ccad2b8ea680152...0e4859dce635a9c9e0af3c6dfb23bc6d6a60b45c</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom.profiling.min.js | 0.0% | 0.0% | 123.84 KB | 123.84 KB | 38.64 KB | 38.64 KB | NODE_PROFILING\nReactDOM-dev.js | +0.9% | +0.8% | 897.53 KB | 905.76 KB | 200.61 KB | 202.13 KB | FB_WWW_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **10.27 KB** | **10.27 KB** | **3.49 KB** | **3.5 KB** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | 0.0% | 137.25 KB | 137.31 KB | 35.06 KB | 35.07 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 53.78 KB | 53.78 KB | 14.01 KB | 14.01 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.96 KB** | **10.96 KB** | **4.17 KB** | **4.17 KB** | **UMD_PROD**\n**ReactDOMTesting-prod.js** | **0.0%** | **-0.0%** | **368.74 KB** | **368.74 KB** | **67.46 KB** | **67.46 KB** | **FB_WWW_PROD**\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 49.56 KB | 49.56 KB | 13.52 KB | 13.52 KB | NODE_DEV\nReactDOMTesting-profiling.js | 0.0% | -0.0% | 368.74 KB | 368.74 KB | 67.46 KB | 67.46 KB | FB_WWW_PROFILING\nreact-dom-server.node.development.js | 0.0% | -0.0% | 131 KB | 131 KB | 34.81 KB | 34.81 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **0.0%** | **20.83 KB** | **20.83 KB** | **7.61 KB** | **7.61 KB** | **NODE_PROD**\nreact-dom.development.js | 0.0% | 0.0% | 912.84 KB | 912.84 KB | 199.76 KB | 199.77 KB | UMD_DEV\nReactTestUtils-dev.js | +0.1% | +0.1% | 51.31 KB | 51.37 KB | 13.7 KB | 13.72 KB | FB_WWW_DEV\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.51 KB** | **20.51 KB** | **7.51 KB** | **7.51 KB** | **UMD_PROD**\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 129.78 KB | 129.78 KB | 34.55 KB | 34.55 KB | NODE_DEV\n**ReactDOM-prod.js** | **:small_red_triangle:+1.5%** | **:small_red_triangle:+1.2%** | **370.72 KB** | **376.26 KB** | **67.55 KB** | **68.37 KB** | **FB_WWW_PROD**\nReactDOM-profiling.js | +1.5% | +1.2% | 381.98 KB | 387.52 KB | 69.67 KB | 70.48 KB | FB_WWW_PROFILING\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **1.19 KB** | **1.19 KB** | **698 B** | **699 B** | **UMD_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1 KB** | **1 KB** | **609 B** | **610 B** | **NODE_PROD**\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0e4859dce635a9c9e0af3c6dfb23bc6d6a60b45c\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 60b11f6c1be111c14c3607809ccad2b8ea680152...0e4859dce635a9c9e0af3c6dfb23bc6d6a60b45c</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-profiling.js | +1.5% | +1.3% | 406.37 KB | 412.52 KB | 74.08 KB | 75.04 KB | FB_WWW_PROFILING\nReactTestUtils-dev.js | +0.1% | +0.1% | 51.31 KB | 51.38 KB | 13.7 KB | 13.71 KB | FB_WWW_DEV\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **116.01 KB** | **116.01 KB** | **37.17 KB** | **37.17 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | -0.0% | 119.54 KB | 119.54 KB | 38.33 KB | 38.33 KB | UMD_PROFILING\nReactDOM-dev.js | +1.0% | +1.1% | 939.77 KB | 949.32 KB | 209.49 KB | 211.7 KB | FB_WWW_DEV\n**ReactDOM-prod.js** | **:small_red_triangle:+1.6%** | **:small_red_triangle:+1.3%** | **395.04 KB** | **401.18 KB** | **71.91 KB** | **72.85 KB** | **FB_WWW_PROD**\nreact-dom-unstable-fizz.node.development.js | 0.0% | -0.1% | 3.68 KB | 3.68 KB | 1.33 KB | 1.33 KB | NODE_DEV\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 128.27 KB | 128.27 KB | 34.33 KB | 34.33 KB | NODE_DEV\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 53.77 KB | 53.77 KB | 14 KB | 14 KB | UMD_DEV\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.1% | 3.34 KB | 3.34 KB | 1.26 KB | 1.26 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.94 KB** | **10.94 KB** | **4.16 KB** | **4.16 KB** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | +0.1% | 138.1 KB | 138.16 KB | 35.2 KB | 35.22 KB | FB_WWW_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1013 B** | **1013 B** | **601 B** | **602 B** | **NODE_PROD**\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0e4859dce635a9c9e0af3c6dfb23bc6d6a60b45c\n</p>\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18220/builds/13471) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit db9c751224c728bc0a1c15de71d6a7507df46b7d:\n\n|Sandbox| Source |\n|--|--|\n|[adoring-feather-fde9g](https://codesandbox.io/s/adoring-feather-fde9g)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: fa03206ee4352431198b678c00dca83027e7052d...db9c751224c728bc0a1c15de71d6a7507df46b7d</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom.profiling.min.js | +0.3% | +0.2% | 123.84 KB | 124.16 KB | 38.64 KB | 38.73 KB | NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.91 KB | 58.91 KB | 14.71 KB | 14.71 KB | UMD_DEV\nReactDOM-dev.js | +0.2% | +0.2% | 897.53 KB | 899.21 KB | 200.61 KB | 200.93 KB | FB_WWW_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.27 KB** | **10.27 KB** | **3.49 KB** | **3.5 KB** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | -0.0% | 137.25 KB | 137.25 KB | 35.06 KB | 35.06 KB | FB_WWW_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.96 KB** | **10.96 KB** | **4.17 KB** | **4.17 KB** | **UMD_PROD**\nReactDOMTesting-dev.js | +0.2% | +0.2% | 872.76 KB | 874.43 KB | 195.47 KB | 195.79 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **:small_red_triangle:+0.3%** | **:small_red_triangle:+0.3%** | **368.74 KB** | **369.8 KB** | **67.46 KB** | **67.67 KB** | **FB_WWW_PROD**\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 49.56 KB | 49.56 KB | 13.52 KB | 13.52 KB | NODE_DEV\nReactDOMTesting-profiling.js | +0.3% | +0.3% | 368.74 KB | 369.8 KB | 67.46 KB | 67.67 KB | FB_WWW_PROFILING\nreact-dom-server.node.development.js | 0.0% | 0.0% | 131 KB | 131 KB | 34.81 KB | 34.81 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **0.0%** | **20.83 KB** | **20.83 KB** | **7.61 KB** | **7.61 KB** | **NODE_PROD**\nreact-dom.development.js | +0.2% | +0.2% | 912.84 KB | 914.63 KB | 199.76 KB | 200.08 KB | UMD_DEV\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 136.78 KB | 136.78 KB | 34.96 KB | 34.96 KB | UMD_DEV\n**react-dom.production.min.js** | **:small_red_triangle:+0.3%** | **:small_red_triangle:+0.3%** | **119.89 KB** | **120.21 KB** | **38.28 KB** | **38.4 KB** | **UMD_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.51 KB** | **20.51 KB** | **7.51 KB** | **7.51 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | +0.3% | +0.2% | 123.54 KB | 123.86 KB | 39.47 KB | 39.54 KB | UMD_PROFILING\nreact-dom.development.js | +0.2% | +0.2% | 868.91 KB | 870.6 KB | 197.31 KB | 197.64 KB | NODE_DEV\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 129.78 KB | 129.78 KB | 34.55 KB | 34.55 KB | NODE_DEV\n**react-dom.production.min.js** | **:small_red_triangle:+0.3%** | **:small_red_triangle:+0.2%** | **120.04 KB** | **120.36 KB** | **37.52 KB** | **37.6 KB** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.43 KB** | **20.43 KB** | **7.46 KB** | **7.46 KB** | **NODE_PROD**\n**ReactDOM-prod.js** | **:small_red_triangle:+0.3%** | **:small_red_triangle:+0.3%** | **370.72 KB** | **371.78 KB** | **67.55 KB** | **67.77 KB** | **FB_WWW_PROD**\n**ReactDOMServer-prod.js** | **0.0%** | **0.0%** | **46.78 KB** | **46.78 KB** | **10.87 KB** | **10.87 KB** | **FB_WWW_PROD**\nReactDOM-profiling.js | +0.3% | +0.3% | 381.98 KB | 383.04 KB | 69.67 KB | 69.88 KB | FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.87 KB | 55.87 KB | 14.47 KB | 14.47 KB | NODE_DEV\nreact-dom-unstable-fizz.node.development.js | 0.0% | +0.1% | 3.69 KB | 3.69 KB | 1.34 KB | 1.34 KB | NODE_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10 KB** | **10 KB** | **3.37 KB** | **3.38 KB** | **NODE_PROD**\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1.16 KB** | **1.16 KB** | **662 B** | **663 B** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.2% | 3.35 KB | 3.35 KB | 1.27 KB | 1.27 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.4%** | **1.19 KB** | **1.19 KB** | **697 B** | **700 B** | **UMD_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.2% | 2.95 KB | 2.95 KB | 1.18 KB | 1.18 KB | NODE_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.3%** | **1 KB** | **1 KB** | **609 B** | **611 B** | **NODE_PROD**\n\n## react-art\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-art.development.js | +0.3% | +0.2% | 634.18 KB | 635.96 KB | 133.2 KB | 133.49 KB | UMD_DEV\n**react-art.production.min.js** | **:small_red_triangle:+0.3%** | **:small_red_triangle:+0.3%** | **106.64 KB** | **106.97 KB** | **32.25 KB** | **32.34 KB** | **UMD_PROD**\nreact-art.development.js | +0.3% | +0.3% | 538.39 KB | 540.08 KB | 115.6 KB | 115.91 KB | NODE_DEV\n**react-art.production.min.js** | **:small_red_triangle:+0.4%** | **:small_red_triangle:+0.4%** | **71.62 KB** | **71.94 KB** | **21.44 KB** | **21.53 KB** | **NODE_PROD**\nReactART-dev.js | +0.3% | +0.3% | 541.98 KB | 543.66 KB | 113.71 KB | 114.02 KB | FB_WWW_DEV\n**ReactART-prod.js** | **:small_red_triangle:+0.5%** | **:small_red_triangle:+0.5%** | **226.66 KB** | **227.72 KB** | **38.52 KB** | **38.73 KB** | **FB_WWW_PROD**\n\n## react-reconciler\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-reconciler-reflection.development.js | 0.0% | 0.0% | 16.25 KB | 16.25 KB | 4.97 KB | 4.97 KB | NODE_DEV\n**react-reconciler-persistent.production.min.js** | **0.0%** | **0.0%** | **73.73 KB** | **73.73 KB** | **21.78 KB** | **21.78 KB** | **NODE_PROD**\n**react-reconciler-reflection.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **2.81 KB** | **2.81 KB** | **1.21 KB** | **1.21 KB** | **NODE_PROD**\nreact-reconciler.development.js | +0.3% | +0.3% | 576.69 KB | 578.38 KB | 121.48 KB | 121.79 KB | NODE_DEV\n**react-reconciler.production.min.js** | **:small_red_triangle:+0.4%** | **:small_red_triangle:+0.4%** | **76.48 KB** | **76.8 KB** | **22.44 KB** | **22.54 KB** | **NODE_PROD**\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: :small_red_triangle:+0.1%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against db9c751224c728bc0a1c15de71d6a7507df46b7d\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: fa03206ee4352431198b678c00dca83027e7052d...db9c751224c728bc0a1c15de71d6a7507df46b7d</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-profiling.js | +0.3% | +0.3% | 406.37 KB | 407.43 KB | 74.08 KB | 74.29 KB | FB_WWW_PROFILING\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 135.19 KB | 135.19 KB | 34.75 KB | 34.75 KB | UMD_DEV\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1.15 KB** | **1.15 KB** | **653 B** | **654 B** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.05 KB** | **20.05 KB** | **7.42 KB** | **7.42 KB** | **UMD_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\nreact-dom.development.js | 0.0% | 0.0% | 884.16 KB | 884.16 KB | 194.85 KB | 194.85 KB | UMD_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **9.99 KB** | **9.99 KB** | **3.36 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **116.01 KB** | **116.01 KB** | **37.17 KB** | **37.17 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 119.54 KB | 119.54 KB | 38.33 KB | 38.33 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | 0.0% | 841.41 KB | 841.41 KB | 192.42 KB | 192.42 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **116.09 KB** | **116.09 KB** | **36.5 KB** | **36.5 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **0.0%** | **20.38 KB** | **20.38 KB** | **7.52 KB** | **7.53 KB** | **NODE_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 119.77 KB | 119.77 KB | 37.58 KB | 37.58 KB | NODE_PROFILING\nReactDOM-dev.js | +0.2% | +0.2% | 939.77 KB | 941.45 KB | 209.49 KB | 209.81 KB | FB_WWW_DEV\n**ReactDOM-prod.js** | **:small_red_triangle:+0.3%** | **:small_red_triangle:+0.3%** | **395.04 KB** | **396.1 KB** | **71.91 KB** | **72.11 KB** | **FB_WWW_PROD**\nreact-dom-unstable-fizz.node.development.js | 0.0% | +0.1% | 3.68 KB | 3.68 KB | 1.33 KB | 1.33 KB | NODE_DEV\nReactDOMTesting-dev.js | +0.2% | +0.2% | 899.4 KB | 901.08 KB | 201 KB | 201.32 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **:small_red_triangle:+0.3%** | **:small_red_triangle:+0.3%** | **382.29 KB** | **383.35 KB** | **69.64 KB** | **69.84 KB** | **FB_WWW_PROD**\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 128.27 KB | 128.27 KB | 34.33 KB | 34.33 KB | NODE_DEV\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 53.77 KB | 53.77 KB | 14 KB | 14 KB | UMD_DEV\nReactDOMTesting-profiling.js | +0.3% | +0.3% | 382.29 KB | 383.35 KB | 69.64 KB | 69.84 KB | FB_WWW_PROFILING\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **19.97 KB** | **19.97 KB** | **7.38 KB** | **7.38 KB** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.2% | 3.34 KB | 3.34 KB | 1.26 KB | 1.26 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.94 KB** | **10.94 KB** | **4.16 KB** | **4.16 KB** | **UMD_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.3%** | **1.17 KB** | **1.17 KB** | **689 B** | **691 B** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | 0.0% | 138.1 KB | 138.1 KB | 35.2 KB | 35.2 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 49.55 KB | 49.55 KB | 13.51 KB | 13.51 KB | NODE_DEV\n**ReactDOMServer-prod.js** | **0.0%** | **0.0%** | **47.49 KB** | **47.49 KB** | **11.05 KB** | **11.05 KB** | **FB_WWW_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.2% | 2.94 KB | 2.94 KB | 1.17 KB | 1.17 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.3%** | **1013 B** | **1013 B** | **601 B** | **603 B** | **NODE_PROD**\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.26 KB** | **10.26 KB** | **3.48 KB** | **3.49 KB** | **UMD_PROD**\n\n## react-art\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactART-dev.js | +0.3% | +0.3% | 567.69 KB | 569.37 KB | 118.97 KB | 119.28 KB | FB_WWW_DEV\n**ReactART-prod.js** | **:small_red_triangle:+0.5%** | **:small_red_triangle:+0.5%** | **233.84 KB** | **234.9 KB** | **39.73 KB** | **39.94 KB** | **FB_WWW_PROD**\n**react-art.production.min.js** | **0.0%** | **0.0%** | **104.21 KB** | **104.21 KB** | **31.61 KB** | **31.61 KB** | **UMD_PROD**\n**react-art.production.min.js** | **0.0%** | **0.0%** | **69.25 KB** | **69.25 KB** | **20.79 KB** | **20.79 KB** | **NODE_PROD**\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against db9c751224c728bc0a1c15de71d6a7507df46b7d\n</p>\n", "The changing of `_fn` is same as Lazy. It changes. Even the functions have different call signatures so Flow should catch it. The thing that Flow doesn't have is \"state classes\" so there's no way to transition to a different type while staying in the type system so I have to briefly use \"any\" when changing the state. (It also has implications on threading.)\r\n\r\nThe initialization is unfortunate. There's a lot going on here. We can't throw in child fiber atm because that would bubble to the wrong parent potentially. We would also prevent siblings from warming up. I'm also not happy with the extra tuples created or the \"if thennable\" type check.\r\n\r\nIt took me like a month to get to this point and I'm still not happy with it. :)" ]

[ "could you set the value to undefined/null (or any other non boolean) if needed? It might not be common, but your change would make it impossible to do so, no? \r\n\r\ncc @bvaughn ", "You're always welcome to make a PR to propose a UX change, @shahzeb1. I can't promise it will get merged though. The DevTools editing interface allows you to change between types in a way that a simple toggle wouldn't enable. `undefined` -> `boolean` or `boolean` -> `undefined` is one such example. I would not be open to any change that breaks this ability.", "Good point. Yes a checkbox would just toggle booleans and not be able to set it to `undefined` (unless you change the value of the string, which is already the case).\r\n\r\nThanks for the quick feedback." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18218/builds/13394) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 10adc955ed42d40fe481e7f7a772e2f835df9948:\n\n|Sandbox| Source |\n|--|--|\n|[cocky-merkle-3x4fv](https://codesandbox.io/s/cocky-merkle-3x4fv)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 10adc955ed42d40fe481e7f7a772e2f835df9948\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 10adc955ed42d40fe481e7f7a772e2f835df9948\n</p>\n", "cool, thanks!" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18217/builds/13396) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 01bf1970c67bb0edf5513ad62abd485993cdfa01:\n\n|Sandbox| Source |\n|--|--|\n|[exciting-maxwell-4i44f](https://codesandbox.io/s/exciting-maxwell-4i44f)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 2fe0fbb05ef2c56db760122e995b923528e6ce8f...01bf1970c67bb0edf5513ad62abd485993cdfa01</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-profiling.js | 0.0% | 0.0% | 406.33 KB | 406.37 KB | 74.07 KB | 74.08 KB | FB_WWW_PROFILING\nreact-dom-server.browser.development.js | +0.3% | +0.3% | 134.78 KB | 135.19 KB | 34.64 KB | 34.75 KB | UMD_DEV\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1.15 KB** | **1.15 KB** | **653 B** | **654 B** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **20.03 KB** | **20.05 KB** | **7.41 KB** | **7.42 KB** | **UMD_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\nreact-dom.development.js | 0.0% | +0.1% | 883.74 KB | 884.16 KB | 194.69 KB | 194.85 KB | UMD_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **9.99 KB** | **9.99 KB** | **3.36 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **116 KB** | **116.01 KB** | **37.14 KB** | **37.17 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | -0.0% | 119.53 KB | 119.54 KB | 38.34 KB | 38.33 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | +0.1% | 841.01 KB | 841.41 KB | 192.31 KB | 192.42 KB | NODE_DEV\nreact-dom-server.node.development.js | +0.3% | +0.3% | 129.09 KB | 129.48 KB | 34.47 KB | 34.58 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **116.08 KB** | **116.09 KB** | **36.5 KB** | **36.5 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **20.36 KB** | **20.38 KB** | **7.52 KB** | **7.53 KB** | **NODE_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 119.76 KB | 119.77 KB | 37.58 KB | 37.58 KB | NODE_PROFILING\nReactDOM-dev.js | 0.0% | +0.1% | 939.37 KB | 939.77 KB | 209.37 KB | 209.49 KB | FB_WWW_DEV\n**ReactDOM-prod.js** | **0.0%** | **0.0%** | **395 KB** | **395.04 KB** | **71.89 KB** | **71.91 KB** | **FB_WWW_PROD**\nReactDOMTesting-dev.js | 0.0% | +0.1% | 899 KB | 899.4 KB | 200.88 KB | 201.01 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **0.0%** | **0.0%** | **382.25 KB** | **382.29 KB** | **69.63 KB** | **69.64 KB** | **FB_WWW_PROD**\nreact-dom-server.browser.development.js | +0.3% | +0.3% | 127.87 KB | 128.27 KB | 34.21 KB | 34.33 KB | NODE_DEV\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 53.77 KB | 53.77 KB | 14 KB | 14 KB | UMD_DEV\nReactDOMTesting-profiling.js | 0.0% | 0.0% | 382.25 KB | 382.29 KB | 69.63 KB | 69.64 KB | FB_WWW_PROFILING\n**react-dom-server.browser.production.min.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **19.95 KB** | **19.97 KB** | **7.37 KB** | **7.38 KB** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.1% | 3.34 KB | 3.34 KB | 1.26 KB | 1.26 KB | UMD_DEV\nReactDOMServer-dev.js | +0.3% | +0.3% | 137.7 KB | 138.1 KB | 35.08 KB | 35.2 KB | FB_WWW_DEV\n**ReactDOMServer-prod.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **47.45 KB** | **47.49 KB** | **11.04 KB** | **11.05 KB** | **FB_WWW_PROD**\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1013 B** | **1013 B** | **601 B** | **602 B** | **NODE_PROD**\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **10.26 KB** | **10.26 KB** | **3.49 KB** | **3.49 KB** | **UMD_PROD**\n\n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactFabric-dev.js | +0.1% | +0.1% | 614.29 KB | 614.69 KB | 132.75 KB | 132.86 KB | RN_OSS_DEV\nReactNativeRenderer-dev.js | +0.1% | +0.1% | 632.19 KB | 632.59 KB | 137.02 KB | 137.13 KB | RN_OSS_DEV\n**ReactNativeRenderer-prod.js** | **0.0%** | **0.0%** | **259.75 KB** | **259.8 KB** | **45.19 KB** | **45.2 KB** | **RN_OSS_PROD**\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.09 KB | 271.13 KB | 47.33 KB | 47.34 KB | RN_OSS_PROFILING\n**ReactFabric-prod.js** | **0.0%** | **0.0%** | **251.72 KB** | **251.76 KB** | **43.7 KB** | **43.71 KB** | **RN_OSS_PROD**\nReactFabric-profiling.js | 0.0% | 0.0% | 263.05 KB | 263.1 KB | 45.87 KB | 45.88 KB | RN_OSS_PROFILING\n\n## react-art\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactART-dev.js | +0.1% | +0.1% | 567.29 KB | 567.69 KB | 118.85 KB | 118.97 KB | FB_WWW_DEV\n**ReactART-prod.js** | **0.0%** | **0.0%** | **233.79 KB** | **233.84 KB** | **39.73 KB** | **39.74 KB** | **FB_WWW_PROD**\nreact-art.development.js | +0.1% | +0.1% | 614.59 KB | 615.01 KB | 129.66 KB | 129.78 KB | UMD_DEV\n**react-art.production.min.js** | **0.0%** | **0.0%** | **104.2 KB** | **104.21 KB** | **31.6 KB** | **31.61 KB** | **UMD_PROD**\nreact-art.development.js | +0.1% | +0.1% | 519.57 KB | 519.97 KB | 112.04 KB | 112.16 KB | NODE_DEV\n**react-art.production.min.js** | **0.0%** | **0.0%** | **69.23 KB** | **69.25 KB** | **20.78 KB** | **20.79 KB** | **NODE_PROD**\n\n## react-test-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactTestRenderer-dev.js | +0.1% | +0.1% | 553.06 KB | 553.46 KB | 116.7 KB | 116.82 KB | FB_WWW_DEV\nreact-test-renderer-shallow.development.js | 0.0% | 0.0% | 38.39 KB | 38.39 KB | 9.29 KB | 9.29 KB | UMD_DEV\n**react-test-renderer-shallow.production.min.js** | **0.0%** | **-0.0%** | **12.91 KB** | **12.91 KB** | **3.93 KB** | **3.93 KB** | **UMD_PROD**\nreact-test-renderer.development.js | +0.1% | +0.1% | 551.91 KB | 552.33 KB | 114.86 KB | 114.97 KB | UMD_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **0.0%** | **71.2 KB** | **71.22 KB** | **21.65 KB** | **21.66 KB** | **UMD_PROD**\nreact-test-renderer.development.js | +0.1% | +0.1% | 525.99 KB | 526.38 KB | 113.55 KB | 113.67 KB | NODE_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **0.0%** | **71.02 KB** | **71.04 KB** | **21.34 KB** | **21.34 KB** | **NODE_PROD**\n\n## react-reconciler\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-reconciler.development.js | +0.1% | +0.1% | 555.54 KB | 555.93 KB | 117.48 KB | 117.59 KB | NODE_DEV\nreact-reconciler-reflection.development.js | +0.4% | +0.7% | 16.17 KB | 16.24 KB | 4.93 KB | 4.96 KB | NODE_DEV\n**react-reconciler.production.min.js** | **0.0%** | **0.0%** | **73.69 KB** | **73.71 KB** | **21.76 KB** | **21.77 KB** | **NODE_PROD**\n**react-reconciler-reflection.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **2.8 KB** | **2.8 KB** | **1.2 KB** | **1.2 KB** | **NODE_PROD**\nreact-reconciler-persistent.development.js | +0.1% | +0.1% | 554.18 KB | 554.58 KB | 117.33 KB | 117.45 KB | NODE_DEV\n**react-reconciler-persistent.production.min.js** | **0.0%** | **0.0%** | **73.7 KB** | **73.72 KB** | **21.77 KB** | **21.78 KB** | **NODE_PROD**\n\n </details>\n \n\nReactDOM: size: :small_red_triangle:+0.1%, gzip: :small_red_triangle:+0.1%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 01bf1970c67bb0edf5513ad62abd485993cdfa01\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 2fe0fbb05ef2c56db760122e995b923528e6ce8f...01bf1970c67bb0edf5513ad62abd485993cdfa01</p>\n\n\n \n## react-art\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-art.development.js | +0.1% | +0.1% | 633.76 KB | 634.18 KB | 133.08 KB | 133.2 KB | UMD_DEV\n**react-art.production.min.js** | **0.0%** | **0.0%** | **106.63 KB** | **106.64 KB** | **32.24 KB** | **32.25 KB** | **UMD_PROD**\nreact-art.development.js | +0.1% | +0.1% | 538 KB | 538.39 KB | 115.48 KB | 115.6 KB | NODE_DEV\n**react-art.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **71.6 KB** | **71.62 KB** | **21.43 KB** | **21.44 KB** | **NODE_PROD**\nReactART-dev.js | +0.1% | +0.1% | 541.58 KB | 541.98 KB | 113.58 KB | 113.71 KB | FB_WWW_DEV\n**ReactART-prod.js** | **0.0%** | **0.0%** | **226.62 KB** | **226.66 KB** | **38.51 KB** | **38.52 KB** | **FB_WWW_PROD**\n\n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom.profiling.min.js | 0.0% | 0.0% | 123.82 KB | 123.84 KB | 38.64 KB | 38.64 KB | NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.91 KB | 58.91 KB | 14.71 KB | 14.71 KB | UMD_DEV\nReactDOM-dev.js | 0.0% | +0.1% | 897.13 KB | 897.53 KB | 200.49 KB | 200.61 KB | FB_WWW_DEV\nReactDOMServer-dev.js | +0.3% | +0.3% | 136.85 KB | 137.25 KB | 34.94 KB | 35.06 KB | FB_WWW_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.96 KB** | **10.96 KB** | **4.17 KB** | **4.17 KB** | **UMD_PROD**\nReactDOMTesting-dev.js | 0.0% | +0.1% | 872.36 KB | 872.76 KB | 195.35 KB | 195.47 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **0.0%** | **0.0%** | **368.7 KB** | **368.74 KB** | **67.45 KB** | **67.46 KB** | **FB_WWW_PROD**\nReactDOMTesting-profiling.js | 0.0% | 0.0% | 368.7 KB | 368.74 KB | 67.45 KB | 67.46 KB | FB_WWW_PROFILING\nreact-dom-server.node.development.js | +0.3% | +0.3% | 130.6 KB | 131 KB | 34.69 KB | 34.81 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **20.82 KB** | **20.83 KB** | **7.6 KB** | **7.61 KB** | **NODE_PROD**\nreact-dom.development.js | 0.0% | +0.1% | 912.43 KB | 912.84 KB | 199.6 KB | 199.77 KB | UMD_DEV\nreact-dom-server.browser.development.js | +0.3% | +0.3% | 136.37 KB | 136.78 KB | 34.84 KB | 34.96 KB | UMD_DEV\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **119.87 KB** | **119.89 KB** | **38.29 KB** | **38.28 KB** | **UMD_PROD**\n**react-dom-server.browser.production.min.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **20.49 KB** | **20.51 KB** | **7.5 KB** | **7.51 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | +0.1% | 123.52 KB | 123.54 KB | 39.44 KB | 39.47 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | +0.1% | 868.51 KB | 868.91 KB | 197.21 KB | 197.31 KB | NODE_DEV\nreact-dom-server.browser.development.js | +0.3% | +0.3% | 129.38 KB | 129.78 KB | 34.43 KB | 34.55 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **120.02 KB** | **120.04 KB** | **37.52 KB** | **37.52 KB** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **20.41 KB** | **20.43 KB** | **7.45 KB** | **7.46 KB** | **NODE_PROD**\n**ReactDOM-prod.js** | **0.0%** | **0.0%** | **370.67 KB** | **370.72 KB** | **67.55 KB** | **67.55 KB** | **FB_WWW_PROD**\n**ReactDOMServer-prod.js** | **:small_red_triangle:+0.1%** | **:small_red_triangle:+0.1%** | **46.74 KB** | **46.78 KB** | **10.86 KB** | **10.87 KB** | **FB_WWW_PROD**\nReactDOM-profiling.js | 0.0% | 0.0% | 381.94 KB | 381.98 KB | 69.66 KB | 69.67 KB | FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.87 KB | 55.87 KB | 14.47 KB | 14.47 KB | NODE_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **10 KB** | **10 KB** | **3.37 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1.16 KB** | **1.16 KB** | **661 B** | **662 B** | **NODE_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **1.19 KB** | **1.19 KB** | **698 B** | **699 B** | **UMD_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.1% | 2.95 KB | 2.95 KB | 1.18 KB | 1.18 KB | NODE_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1 KB** | **1 KB** | **609 B** | **610 B** | **NODE_PROD**\n\n## react-test-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactTestRenderer-dev.js | +0.1% | +0.1% | 553.07 KB | 553.47 KB | 116.7 KB | 116.83 KB | FB_WWW_DEV\nreact-test-renderer-shallow.development.js | 0.0% | 0.0% | 38.4 KB | 38.4 KB | 9.3 KB | 9.3 KB | UMD_DEV\n**react-test-renderer-shallow.production.min.js** | **0.0%** | **-0.0%** | **12.92 KB** | **12.92 KB** | **3.94 KB** | **3.94 KB** | **UMD_PROD**\nreact-test-renderer.development.js | +0.1% | +0.1% | 551.94 KB | 552.35 KB | 114.87 KB | 114.98 KB | UMD_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **0.0%** | **71.23 KB** | **71.25 KB** | **21.66 KB** | **21.67 KB** | **UMD_PROD**\nreact-test-renderer.development.js | +0.1% | +0.1% | 526.01 KB | 526.41 KB | 113.56 KB | 113.68 KB | NODE_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **0.0%** | **71.04 KB** | **71.06 KB** | **21.35 KB** | **21.36 KB** | **NODE_PROD**\n\n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \n**ReactNativeRenderer-prod.js** | **0.0%** | **0.0%** | **259.77 KB** | **259.81 KB** | **45.2 KB** | **45.21 KB** | **RN_OSS_PROD**\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.1 KB | 271.15 KB | 47.34 KB | 47.35 KB | RN_OSS_PROFILING\n**ReactFabric-prod.js** | **0.0%** | **0.0%** | **251.73 KB** | **251.77 KB** | **43.71 KB** | **43.72 KB** | **RN_OSS_PROD**\nReactFabric-profiling.js | 0.0% | 0.0% | 263.07 KB | 263.11 KB | 45.88 KB | 45.89 KB | RN_OSS_PROFILING\nReactFabric-dev.js | +0.1% | +0.1% | 616.94 KB | 617.34 KB | 133.08 KB | 133.2 KB | RN_FB_DEV\n**ReactFabric-prod.js** | **0.0%** | **0.0%** | **251.88 KB** | **251.93 KB** | **43.74 KB** | **43.75 KB** | **RN_FB_PROD**\nReactNativeRenderer-dev.js | +0.1% | +0.1% | 632.2 KB | 632.6 KB | 137.03 KB | 137.13 KB | RN_OSS_DEV\nReactFabric-profiling.js | 0.0% | 0.0% | 263.21 KB | 263.26 KB | 45.93 KB | 45.93 KB | RN_FB_PROFILING\nReactNativeRenderer-dev.js | +0.1% | +0.1% | 634.83 KB | 635.23 KB | 137.37 KB | 137.47 KB | RN_FB_DEV\n**ReactNativeRenderer-prod.js** | **0.0%** | **0.0%** | **259.91 KB** | **259.96 KB** | **45.22 KB** | **45.23 KB** | **RN_FB_PROD**\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.24 KB | 271.29 KB | 47.39 KB | 47.4 KB | RN_FB_PROFILING\nReactFabric-dev.js | +0.1% | +0.1% | 614.3 KB | 614.7 KB | 132.75 KB | 132.87 KB | RN_OSS_DEV\n\n## react-reconciler\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-reconciler-persistent.development.js | +0.1% | +0.1% | 554.19 KB | 554.59 KB | 117.33 KB | 117.46 KB | NODE_DEV\nreact-reconciler-reflection.development.js | +0.4% | +0.6% | 16.18 KB | 16.25 KB | 4.93 KB | 4.97 KB | NODE_DEV\n**react-reconciler-persistent.production.min.js** | **0.0%** | **0.0%** | **73.71 KB** | **73.73 KB** | **21.78 KB** | **21.78 KB** | **NODE_PROD**\n**react-reconciler-reflection.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **2.81 KB** | **2.81 KB** | **1.21 KB** | **1.21 KB** | **NODE_PROD**\nreact-reconciler.development.js | +0.1% | +0.1% | 576.29 KB | 576.69 KB | 121.36 KB | 121.48 KB | NODE_DEV\n**react-reconciler.production.min.js** | **0.0%** | **0.0%** | **76.46 KB** | **76.48 KB** | **22.44 KB** | **22.44 KB** | **NODE_PROD**\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 01bf1970c67bb0edf5513ad62abd485993cdfa01\n</p>\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18216/builds/13383) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 029f99a9bc33cc5319823169d330403d0c4aed35:\n\n|Sandbox| Source |\n|--|--|\n|[focused-sky-ov8pr](https://codesandbox.io/s/focused-sky-ov8pr)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 2fe0fbb05ef2c56db760122e995b923528e6ce8f...029f99a9bc33cc5319823169d330403d0c4aed35</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom.profiling.min.js | 0.0% | 0.0% | 123.82 KB | 123.82 KB | 38.64 KB | 38.64 KB | NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js | +0.9% | +0.5% | 58.91 KB | 59.42 KB | 14.71 KB | 14.78 KB | UMD_DEV\nReactDOM-dev.js | +0.1% | 0.0% | 897.13 KB | 897.63 KB | 200.49 KB | 200.58 KB | FB_WWW_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **10.27 KB** | **10.27 KB** | **3.49 KB** | **3.5 KB** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | 0.0% | 136.85 KB | 136.85 KB | 34.94 KB | 34.94 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | +0.7% | +0.4% | 53.78 KB | 54.17 KB | 14.01 KB | 14.07 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.96 KB** | **10.96 KB** | **4.17 KB** | **4.17 KB** | **UMD_PROD**\nReactDOMTesting-dev.js | +0.1% | 0.0% | 872.36 KB | 872.86 KB | 195.35 KB | 195.44 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **0.0%** | **0.0%** | **368.7 KB** | **368.73 KB** | **67.45 KB** | **67.46 KB** | **FB_WWW_PROD**\nreact-dom-test-utils.development.js | +0.7% | +0.5% | 49.56 KB | 49.92 KB | 13.52 KB | 13.59 KB | NODE_DEV\nReactDOMTesting-profiling.js | 0.0% | 0.0% | 368.7 KB | 368.73 KB | 67.45 KB | 67.46 KB | FB_WWW_PROFILING\nreact-dom-server.node.development.js | 0.0% | 0.0% | 130.6 KB | 130.6 KB | 34.69 KB | 34.69 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **0.0%** | **20.82 KB** | **20.82 KB** | **7.6 KB** | **7.6 KB** | **NODE_PROD**\nreact-dom.development.js | 0.0% | 0.0% | 912.43 KB | 912.88 KB | 199.6 KB | 199.7 KB | UMD_DEV\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 136.37 KB | 136.37 KB | 34.84 KB | 34.84 KB | UMD_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **119.87 KB** | **119.87 KB** | **38.29 KB** | **38.29 KB** | **UMD_PROD**\nReactTestUtils-dev.js | +0.9% | +0.4% | 51.31 KB | 51.76 KB | 13.7 KB | 13.76 KB | FB_WWW_DEV\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.49 KB** | **20.49 KB** | **7.5 KB** | **7.5 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 123.52 KB | 123.52 KB | 39.44 KB | 39.45 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | 0.0% | 868.51 KB | 868.93 KB | 197.21 KB | 197.29 KB | NODE_DEV\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 129.38 KB | 129.38 KB | 34.43 KB | 34.43 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **120.02 KB** | **120.02 KB** | **37.52 KB** | **37.52 KB** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.41 KB** | **20.41 KB** | **7.45 KB** | **7.45 KB** | **NODE_PROD**\n**ReactDOM-prod.js** | **0.0%** | **0.0%** | **370.67 KB** | **370.7 KB** | **67.55 KB** | **67.56 KB** | **FB_WWW_PROD**\nReactDOM-profiling.js | 0.0% | 0.0% | 381.94 KB | 381.96 KB | 69.66 KB | 69.67 KB | FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js | +0.9% | +0.6% | 55.87 KB | 56.35 KB | 14.47 KB | 14.56 KB | NODE_DEV\nreact-dom-unstable-fizz.node.development.js | 0.0% | +0.1% | 3.69 KB | 3.69 KB | 1.34 KB | 1.34 KB | NODE_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **10 KB** | **10 KB** | **3.37 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **:small_red_triangle:+0.3%** | **1.16 KB** | **1.16 KB** | **661 B** | **663 B** | **NODE_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **1.19 KB** | **1.19 KB** | **698 B** | **699 B** | **UMD_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.1% | 2.95 KB | 2.95 KB | 1.18 KB | 1.18 KB | NODE_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1 KB** | **1 KB** | **609 B** | **610 B** | **NODE_PROD**\n\n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \n**ReactNativeRenderer-prod.js** | **0.0%** | **0.0%** | **259.77 KB** | **259.79 KB** | **45.2 KB** | **45.2 KB** | **RN_OSS_PROD**\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.1 KB | 271.13 KB | 47.34 KB | 47.35 KB | RN_OSS_PROFILING\n**ReactFabric-prod.js** | **0.0%** | **0.0%** | **251.73 KB** | **251.76 KB** | **43.71 KB** | **43.71 KB** | **RN_OSS_PROD**\nReactFabric-profiling.js | 0.0% | 0.0% | 263.07 KB | 263.09 KB | 45.88 KB | 45.89 KB | RN_OSS_PROFILING\nReactFabric-dev.js | +0.1% | +0.1% | 616.94 KB | 617.56 KB | 133.08 KB | 133.17 KB | RN_FB_DEV\n**ReactFabric-prod.js** | **0.0%** | **0.0%** | **251.88 KB** | **251.91 KB** | **43.74 KB** | **43.75 KB** | **RN_FB_PROD**\nReactNativeRenderer-dev.js | +0.1% | 0.0% | 632.2 KB | 632.82 KB | 137.03 KB | 137.09 KB | RN_OSS_DEV\nReactFabric-profiling.js | 0.0% | 0.0% | 263.21 KB | 263.24 KB | 45.93 KB | 45.93 KB | RN_FB_PROFILING\nReactNativeRenderer-dev.js | +0.1% | 0.0% | 634.83 KB | 635.45 KB | 137.37 KB | 137.43 KB | RN_FB_DEV\n**ReactNativeRenderer-prod.js** | **0.0%** | **0.0%** | **259.91 KB** | **259.94 KB** | **45.22 KB** | **45.23 KB** | **RN_FB_PROD**\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.24 KB | 271.27 KB | 47.39 KB | 47.4 KB | RN_FB_PROFILING\nReactFabric-dev.js | +0.1% | +0.1% | 614.3 KB | 614.92 KB | 132.75 KB | 132.84 KB | RN_OSS_DEV\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 029f99a9bc33cc5319823169d330403d0c4aed35\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 2fe0fbb05ef2c56db760122e995b923528e6ce8f...029f99a9bc33cc5319823169d330403d0c4aed35</p>\n\n\n \n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactFabric-dev.js | +0.1% | +0.1% | 614.29 KB | 614.91 KB | 132.75 KB | 132.83 KB | RN_OSS_DEV\nReactNativeRenderer-dev.js | +0.1% | 0.0% | 632.19 KB | 632.81 KB | 137.02 KB | 137.08 KB | RN_OSS_DEV\n**ReactNativeRenderer-prod.js** | **0.0%** | **0.0%** | **259.75 KB** | **259.78 KB** | **45.19 KB** | **45.19 KB** | **RN_OSS_PROD**\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.09 KB | 271.12 KB | 47.33 KB | 47.34 KB | RN_OSS_PROFILING\n**ReactFabric-prod.js** | **0.0%** | **0.0%** | **251.72 KB** | **251.74 KB** | **43.7 KB** | **43.71 KB** | **RN_OSS_PROD**\nReactFabric-profiling.js | 0.0% | 0.0% | 263.05 KB | 263.08 KB | 45.87 KB | 45.88 KB | RN_OSS_PROFILING\n\n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-profiling.js | 0.0% | 0.0% | 406.33 KB | 406.36 KB | 74.07 KB | 74.08 KB | FB_WWW_PROFILING\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1.15 KB** | **1.15 KB** | **653 B** | **654 B** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **20.03 KB** | **20.03 KB** | **7.41 KB** | **7.41 KB** | **UMD_PROD**\nReactTestUtils-dev.js | +0.9% | +0.4% | 51.31 KB | 51.76 KB | 13.7 KB | 13.75 KB | FB_WWW_DEV\nreact-dom-unstable-native-dependencies.development.js | +0.9% | +0.6% | 55.86 KB | 56.34 KB | 14.46 KB | 14.55 KB | NODE_DEV\nreact-dom.development.js | +0.1% | 0.0% | 883.74 KB | 884.2 KB | 194.69 KB | 194.78 KB | UMD_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **9.99 KB** | **9.99 KB** | **3.36 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **116 KB** | **116 KB** | **37.14 KB** | **37.14 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 119.53 KB | 119.53 KB | 38.34 KB | 38.34 KB | UMD_PROFILING\nreact-dom.development.js | +0.1% | 0.0% | 841.01 KB | 841.44 KB | 192.31 KB | 192.4 KB | NODE_DEV\nreact-dom-server.node.development.js | 0.0% | 0.0% | 129.09 KB | 129.09 KB | 34.47 KB | 34.47 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **0.0%** | **116.08 KB** | **116.08 KB** | **36.5 KB** | **36.5 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **0.0%** | **20.36 KB** | **20.36 KB** | **7.52 KB** | **7.52 KB** | **NODE_PROD**\nreact-dom.profiling.min.js | 0.0% | 0.0% | 119.76 KB | 119.76 KB | 37.58 KB | 37.58 KB | NODE_PROFILING\nReactDOM-dev.js | +0.1% | 0.0% | 939.37 KB | 939.88 KB | 209.37 KB | 209.47 KB | FB_WWW_DEV\n**ReactDOM-prod.js** | **0.0%** | **0.0%** | **395 KB** | **395.02 KB** | **71.89 KB** | **71.9 KB** | **FB_WWW_PROD**\nreact-dom-unstable-fizz.node.development.js | 0.0% | +0.1% | 3.68 KB | 3.68 KB | 1.33 KB | 1.33 KB | NODE_DEV\nReactDOMTesting-dev.js | +0.1% | +0.1% | 899 KB | 899.51 KB | 200.88 KB | 200.99 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **0.0%** | **0.0%** | **382.25 KB** | **382.27 KB** | **69.63 KB** | **69.63 KB** | **FB_WWW_PROD**\nreact-dom-test-utils.development.js | +0.7% | +0.4% | 53.77 KB | 54.15 KB | 14 KB | 14.06 KB | UMD_DEV\nReactDOMTesting-profiling.js | 0.0% | 0.0% | 382.25 KB | 382.27 KB | 69.63 KB | 69.63 KB | FB_WWW_PROFILING\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **19.95 KB** | **19.95 KB** | **7.37 KB** | **7.37 KB** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | +0.1% | 3.34 KB | 3.34 KB | 1.26 KB | 1.26 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.94 KB** | **10.94 KB** | **4.16 KB** | **4.16 KB** | **UMD_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **1.17 KB** | **1.17 KB** | **690 B** | **691 B** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | 0.0% | 137.7 KB | 137.7 KB | 35.08 KB | 35.08 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | +0.7% | +0.5% | 49.55 KB | 49.91 KB | 13.51 KB | 13.58 KB | NODE_DEV\n**ReactDOMServer-prod.js** | **0.0%** | **0.0%** | **47.45 KB** | **47.45 KB** | **11.04 KB** | **11.04 KB** | **FB_WWW_PROD**\n**react-dom-test-utils.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-unstable-native-dependencies.development.js | +0.9% | +0.5% | 58.9 KB | 59.41 KB | 14.7 KB | 14.78 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **:small_red_triangle:+0.2%** | **1013 B** | **1013 B** | **601 B** | **602 B** | **NODE_PROD**\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.26 KB** | **10.26 KB** | **3.49 KB** | **3.49 KB** | **UMD_PROD**\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 029f99a9bc33cc5319823169d330403d0c4aed35\n</p>\n", "> but since we're changing a bunch of things about events anyway, maybe we can sneak it in?\r\n\r\nThis is the wrong intuition and I think we should probably wait. There are a ton of things that we should be doing that we're not doing and we really need to hold the line hard. If we were to introduce breaking changes there are a number of other that would be higher pri than this.\r\n\r\nAny small breaking change adds to the risk that people can't upgrade to the next major. If they can't upgrade to the next major they can't isolate a small subsection of their site. If they can't do that, they won't be able to adopt the next major after that at all.\r\n\r\n*All* the breaking changes in the next major should only be in service of unlocking the ability to pin a subtree to an old version which is the point of the \"modern system\". I'd even go as far as saying we shouldn't enable new warnings in 17.0. Only in a future minor.", "Behind a different flag that we can do it next one would be make sense though.", "I wonder if we can go further and remove the heavy synthetic event system that requires all property names to be hardcoded so we can copy them to a small object that only sets the target and prototype links to the nativeEvent?", "@philipp-spiess This part of Seb's comment probably applies here:\r\n\r\n>There are a ton of things that we should be doing that we're not doing and we really need to hold the line hard. If we were to introduce breaking changes there are a number of other that would be higher pri than this.", "I made a follow up to this PR in https://github.com/facebook/react/pull/18969." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18215/builds/13373) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit e1a0e9154cdfe11e0502f419d4e328dbec9109ef:\n\n|Sandbox| Source |\n|--|--|\n|[gallant-hooks-fjmmn](https://codesandbox.io/s/gallant-hooks-fjmmn)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e1a0e9154cdfe11e0502f419d4e328dbec9109ef\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e1a0e9154cdfe11e0502f419d4e328dbec9109ef\n</p>\n", "To simplify things, I ported the changes from this PR into https://github.com/facebook/react/pull/18201." ]

[ "> There should be some way to do this?\r\n\r\nThere is: `eslint-disable-next-line`", "> There is: `eslint-disable-next-line`\r\n\r\nSure, that's what I'm doing right now. I just wanted to see if there was an official opinion on this!", "Try this Solution:\r\n```\r\nconst getIdsArrayHash = useMemo(()=>ids.join(\"-\"),[ids]);\r\n useEffect(() => {\r\n addLog(`ids array contents changed to ${ids}`);\r\n }, [getIdsArrayHash,ids]);\r\n```", "Silencing the lint is the appropriate solution here. That's essentially the same thing you're asking for — a way to mark some code as \"I know what I'm doing\".'" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18213/builds/13313) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit bceb8c841d749ed209c3fdd0a3f2be939a7278b2:\n\n|Sandbox| Source |\n|--|--|\n|[zealous-franklin-kyiky](https://codesandbox.io/s/zealous-franklin-kyiky)| Configuration |\n", "I'll add a follow up test tomorrow when I'm in the office.", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bceb8c841d749ed209c3fdd0a3f2be939a7278b2\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bceb8c841d749ed209c3fdd0a3f2be939a7278b2\n</p>\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18212/builds/13300) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit be20db2415b2238cb45ae3815449b08144e19a66:\n\n|Sandbox| Source |\n|--|--|\n|[floral-brook-cit2f](https://codesandbox.io/s/floral-brook-cit2f)| Configuration |\n", "\n<!--\n 0 failure: \n 1 warning: Base commit is br...\n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\">Warnings</th>\n </tr>\n </thead>\n <tbody><tr>\n <td>:warning:</td>\n <td>Base commit is broken: 7e94d89f3e78df89d9d133ca8dbef295f1b90e46</td>\n </tr>\n </tbody>\n</table>\n\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against be20db2415b2238cb45ae3815449b08144e19a66\n</p>\n", "\n<!--\n 0 failure: \n 1 warning: Base commit is br...\n \n 1 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\">Warnings</th>\n </tr>\n </thead>\n <tbody><tr>\n <td>:warning:</td>\n <td>Base commit is broken: 7e94d89f3e78df89d9d133ca8dbef295f1b90e46</td>\n </tr>\n </tbody>\n</table>\n\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against be20db2415b2238cb45ae3815449b08144e19a66\n</p>\n", "While this change would be nice for our CI, it seems like a negative for NPM users who actually use the standalone DevTools shell. Hm...", "If the download fails for them, they’d be in the same situation as yarn failing. They’d see the same logs, and devtools wouldn’t start up (and you could detect a failed download in the bin and warn specifically for that)\n\nI’m not super sure myself tbh. ", "This isn’t the right solution, so I’m closing it" ]

[ "@adorearun What makes you think this is a React bug?\r\n\r\nFrom the limited amount of info in the description, I would suggest filing it in the Ant repo.", "Sorry about the confusion , closing it.", "No worries :)" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18210/builds/13367) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit bba107d8ebb7fe46f23126278b3e6e70933edca4:\n\n|Sandbox| Source |\n|--|--|\n|[crazy-fog-dg7np](https://codesandbox.io/s/crazy-fog-dg7np)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 355970aa4b7f96ec487e29083ee8fbc87bc99fdc...bba107d8ebb7fe46f23126278b3e6e70933edca4</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-profiling.js | +0.2% | +0.2% | 405.57 KB | 406.23 KB | 73.92 KB | 74.08 KB | FB_WWW_PROFILING\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 134.59 KB | 134.59 KB | 34.59 KB | 34.59 KB | UMD_DEV\n**react-dom-unstable-fizz.node.production.min.js** | **0.0%** | **-0.5%** | **1.15 KB** | **1.15 KB** | **655 B** | **652 B** | **NODE_PROD**\n**react-dom-server.browser.production.min.js** | **0.0%** | **-0.0%** | **19.99 KB** | **19.99 KB** | **7.39 KB** | **7.39 KB** | **UMD_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\nreact-dom.development.js | 0.0% | 0.0% | 883.42 KB | 883.53 KB | 194.62 KB | 194.65 KB | UMD_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.1%** | **9.99 KB** | **9.99 KB** | **3.37 KB** | **3.36 KB** | **NODE_PROD**\n**react-dom.production.min.js** | **-0.0%** | **-0.0%** | **115.95 KB** | **115.95 KB** | **37.13 KB** | **37.13 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | -0.0% | -0.0% | 119.48 KB | 119.48 KB | 38.34 KB | 38.34 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | 0.0% | 840.7 KB | 840.81 KB | 192.23 KB | 192.27 KB | NODE_DEV\nreact-dom-server.node.development.js | 0.0% | -0.0% | 128.91 KB | 128.91 KB | 34.43 KB | 34.43 KB | NODE_DEV\n**react-dom.production.min.js** | **0.0%** | **-0.0%** | **116.03 KB** | **116.03 KB** | **36.49 KB** | **36.49 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **-0.0%** | **20.31 KB** | **20.31 KB** | **7.51 KB** | **7.51 KB** | **NODE_PROD**\nreact-dom.profiling.min.js | 0.0% | -0.0% | 119.71 KB | 119.71 KB | 37.58 KB | 37.58 KB | NODE_PROFILING\nReactDOM-dev.js | +0.1% | +0.2% | 937.99 KB | 939.17 KB | 208.92 KB | 209.32 KB | FB_WWW_DEV\n**ReactDOM-prod.js** | **:small_red_triangle:+0.2%** | **:small_red_triangle:+0.2%** | **394.24 KB** | **394.89 KB** | **71.74 KB** | **71.9 KB** | **FB_WWW_PROD**\nreact-dom-unstable-fizz.node.development.js | 0.0% | -0.2% | 3.68 KB | 3.68 KB | 1.33 KB | 1.33 KB | NODE_DEV\nReactDOMTesting-dev.js | +0.1% | +0.2% | 897.62 KB | 898.79 KB | 200.44 KB | 200.84 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **:small_red_triangle:+0.2%** | **:small_red_triangle:+0.2%** | **381.49 KB** | **382.14 KB** | **69.48 KB** | **69.63 KB** | **FB_WWW_PROD**\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 127.69 KB | 127.69 KB | 34.17 KB | 34.17 KB | NODE_DEV\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 53.77 KB | 53.77 KB | 14 KB | 14 KB | UMD_DEV\nReactDOMTesting-profiling.js | +0.2% | +0.2% | 381.49 KB | 382.14 KB | 69.48 KB | 69.63 KB | FB_WWW_PROFILING\n**react-dom-server.browser.production.min.js** | **0.0%** | **-0.0%** | **19.9 KB** | **19.9 KB** | **7.36 KB** | **7.36 KB** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.2% | 3.34 KB | 3.34 KB | 1.26 KB | 1.26 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.94 KB** | **10.94 KB** | **4.16 KB** | **4.16 KB** | **UMD_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **-0.1%** | **1.17 KB** | **1.17 KB** | **691 B** | **690 B** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | -0.0% | 137.53 KB | 137.53 KB | 35.04 KB | 35.04 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | 0.0% | -0.0% | 49.55 KB | 49.55 KB | 13.51 KB | 13.51 KB | NODE_DEV\n**ReactDOMServer-prod.js** | **0.0%** | **-0.0%** | **47.39 KB** | **47.39 KB** | **11.03 KB** | **11.03 KB** | **FB_WWW_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.2% | 2.94 KB | 2.94 KB | 1.17 KB | 1.17 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **-0.3%** | **1013 B** | **1013 B** | **603 B** | **601 B** | **NODE_PROD**\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.1%** | **10.26 KB** | **10.26 KB** | **3.49 KB** | **3.49 KB** | **UMD_PROD**\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bba107d8ebb7fe46f23126278b3e6e70933edca4\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bba107d8ebb7fe46f23126278b3e6e70933edca4\n</p>\n" ]

[ "This is expected behaviour for Strict mode in development, it helps to surface any possible bugs https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects", "so can react supply some api to let developer know is this render called by strict-mode, In a sense, it is like a shadow call, but I suggest react should let developer know if developer want to konw.\r\n\r\n> by the way, the useEffect is only been called by one time but useState will been called 2 times in strict mode.\r\n\r\n- for hook\r\n```js\r\nfunction Demo(){\r\n const result = React.useDetectStrictMode()\r\n console.log(`is this render behavior in strict mode `, result);\r\n}\r\n\r\n//if I new a `<Demo />` one time, I will see two line at console\r\n//1 : is this render behavior in strict mode false\r\n//2: is this render behavior in strict mode true\r\n```\r\nfor class\r\n```js\r\nclass Demo extends React.Component{\r\n constructor(props context){\r\n super(props, context);\r\n console.log(`is this render behavior in strict mode `, context.isCallByStrictMode);\r\n }\r\n}\r\n```\r\n\r\nbecause I want to collect and do some stuff in first render period, now in strict mode my code do something wrong......\r\n\r\njust like below\r\n```js\r\nfunction useMyHook(){\r\n const curCursor = getCursor();//aways return a new cursor\r\n const [lockedCursor] = useState(curCursor);\r\n if(curCursor === lockedCursor){\r\n // if true, mean that this hook is called by some component first time\r\n // then I will do something else for this first render period.\r\n // but now in strict mode, a component ins will call this hook fn 2 times even user \r\n // only write one time in the code.\r\n // so it will interfere with my judgment\r\n }\r\n}\r\n```\r\n", "what I really want is that react can give a way to let developer know which one is the **second call** in `double-invoking`, it is very very helpful and important if developer care about it.", "I disagree, and it's pointing out an actual problem with your code. You shouldn't instantiate a new object while rendering with getCursor(). The number of renders is not guaranteed, and could vary based on whether the component suspended, or other factors. \r\n\r\nIt's not clear from your snippet what exactly you're trying to do, but this isn't a bug with React. I'd recommend posting on stack overflow for usage questions. Thanks!", "thank you for your advice, now I know how to handle it." ]

[ "The commit that landed that behaviour (https://github.com/facebook/react/pull/14762) hasn't been released yet. We could probably do a release sometime, but the workaround right now is to copy paste the recommended config. I'll leave this open till we do. ", "I don't want to put anything in `rules`, here is my workaround.\r\n\r\n1. open `node_modules/eslint-plugin-react-hooks/index.js`, override all with the following code:\r\n\r\n```\r\n'use strict';\r\n\r\n// TODO: this doesn't make sense for an ESLint rule.\r\n// We need to fix our build process to not create bundles for \"raw\" packages like this.\r\nif (process.env.NODE_ENV === 'production') {\r\n module.exports = {...require('./cjs/eslint-plugin-react-hooks.production.min.js'),\r\n configs: {\r\n recommended: {\r\n rules: {\r\n \"react-hooks/rules-of-hooks\": \"error\",\r\n \"react-hooks/exhaustive-deps\": \"warn\"\r\n }\r\n }\r\n }};\r\n} else {\r\n module.exports = {...require('./cjs/eslint-plugin-react-hooks.development.js'),\r\n configs: {\r\n recommended: {\r\n rules: {\r\n \"react-hooks/rules-of-hooks\": \"error\",\r\n \"react-hooks/exhaustive-deps\": \"warn\"\r\n }\r\n }\r\n }};\r\n}\r\n```", "This should've gone out in 3.0.0", "Hey Guys, weirdly i'm still having this error right now\r\n\r\n```\r\nmodule.exports = {\r\n env: {\r\n browser: true,\r\n es6: true\r\n },\r\n extends: [\r\n \"plugin:react/recommended\",\r\n \"airbnb\",\r\n \"plugin:react-hooks/recommended\",\r\n \"prettier\"\r\n ],\r\n globals: {\r\n Atomics: \"readonly\",\r\n SharedArrayBuffer: \"readonly\"\r\n },\r\n parserOptions: {\r\n ecmaFeatures: {\r\n jsx: true\r\n },\r\n ecmaVersion: 2018,\r\n sourceType: \"module\"\r\n },\r\n plugins: [\"react\", \"jsx-a11y\", \"import\", \"prettier\"],\r\n rules: {\r\n \"prettier/prettier\": \"error\",\r\n \"react/jsx-filename-extension\": [1, { \"extensions\": [\".js\", \".jsx\"] }],\r\n \"react/require-default-props\": [0],\r\n }\r\n};\r\n```\r\n\r\nThat's my eslintrc, just installed the hooks plugin today\r\n\r\nversion: `\"eslint-plugin-react-hooks\": \"^4.0.1\",`\r\n\r\nAnything I should be aware of?'\r\n\r\nEDIT:\r\n\r\nSorry i just realised that airbnb is using react hooks 2.5", "I'm still getting this error now with `^4.1.0`....\r\n\r\n```javascript\r\nmodule.exports = {\r\n \"env\": {\r\n \"browser\": true,\r\n \"es6\": true,\r\n },\r\n \"extends\": [\r\n \"eslint:recommended\",\r\n \"plugin:@typescript-eslint/eslint-recommended\",\r\n \"plugin:@typescript-eslint/recommended\",\r\n \"plugin:import/errors\",\r\n \"plugin:import/warnings\",\r\n \"plugin:react/recommended\",\r\n \"plugin:react-hooks/recommended\",\r\n ],\r\n \"parser\": \"@typescript-eslint/parser\",\r\n \"plugins\": [\r\n \"react\",\r\n ],\r\n \"rules\": {\r\n \"@typescript-eslint/member-delimiter-style\": [\r\n \"error\", {\r\n multiline: {\r\n delimiter: \"none\",\r\n requireLast: true,\r\n },\r\n singleline: {\r\n delimiter: \"semi\",\r\n requireLast: false,\r\n },\r\n },\r\n ],\r\n },\r\n \"settings\": {\r\n \"import/resolver\": {\r\n \"node\": {\r\n \"extensions\": [\".js\", \".jsx\", \".ts\", \".tsx\"],\r\n },\r\n },\r\n },\r\n}\r\n```\r\n\r\nEdit: works after complete purge of `node_modules` and `package-lock.json`; might have been a conflict with the `eslint-config-react-app@5.2.1` peer dep..." ]

[ "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3468faa212ab0e1d1eb69316b16c2e9c53c10e76\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3468faa212ab0e1d1eb69316b16c2e9c53c10e76\n</p>\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18207/builds/13163) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 3468faa212ab0e1d1eb69316b16c2e9c53c10e76:\n\n|Sandbox| Source |\n|--|--|\n|[hungry-galileo-4hkrd](https://codesandbox.io/s/hungry-galileo-4hkrd)| Configuration |\n", "Thank you!" ]

[ "no matter in native view or web or rn view, all stuck when textfield focus changed, for example when begin edit or end edit", "If you believe this is a bug in React, please open an issue with the information requested in the issue template.\r\n\r\nIf you have a support question, please check our community support resources:\r\nhttps://facebook.github.io/react/community/support.html" ]

[ "DevTools only injects if the document `contentType` is `text/html` (see #17739). This change also required adding some checks for \"'sub' of undefined\" (see #17848).\r\n\r\nUnfortunately the first change was released in v4.4.0 (January 3, 2020) and the second change has not yet been released. So this is a known issue and will be fixed by v4.4.1/v4.5.0 whenever it's released...which should be soon. I guess probably this week.\r\n\r\nSorry for the inconvenience.", "Fixed in v4.5\r\n\r\nhttps://github.com/facebook/react/blob/master/packages/react-devtools/CHANGELOG.md#450-march-3-2020\r\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18204/builds/13011) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 757c6f84341156f1f060811e16e96950cf76c50d:\n\n|Sandbox| Source |\n|--|--|\n|[reverent-glade-5lkq5](https://codesandbox.io/s/reverent-glade-5lkq5)| Configuration |\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18204/builds/13015) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 48ed4cba53656f3e49d74d8375d6ee08f57e5b6a:\n\n|Sandbox| Source |\n|--|--|\n|[kind-moser-18v4v](https://codesandbox.io/s/kind-moser-18v4v)| Configuration |\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18204/builds/13021) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 0c34969c3359b7220084d36fcfc04feaf3d1557c:\n\n|Sandbox| Source |\n|--|--|\n|[loving-chaum-zvfru](https://codesandbox.io/s/loving-chaum-zvfru)| Configuration |\n", "CI failure looks unrelated...\r\n\r\n", "Don’t be certain that it’s unrelated, I saw this recently as a a sign that another task failed. Afk or I’d look for proof. ", "The failure is a 401 being returned from the electron repo in its post-install task :smile: Seems unrelated.", "Oh no lol", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0c34969c3359b7220084d36fcfc04feaf3d1557c\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0c34969c3359b7220084d36fcfc04feaf3d1557c\n</p>\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18203/builds/13004) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 9921ddd8c6543fba245725e44b3aafe375e92029:\n\n|Sandbox| Source |\n|--|--|\n|[polished-pine-nld42](https://codesandbox.io/s/polished-pine-nld42)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9921ddd8c6543fba245725e44b3aafe375e92029\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9921ddd8c6543fba245725e44b3aafe375e92029\n</p>\n", ">i'm unaware of the specific consequences\r\n\r\nIf you're curious — each `accumulate*` function has a `accumulate*Single` version. The difference as I understand is that `accumulate*Single` accepts an event, but `accumulate*` accepts *either* event or an array. Since we're calling it with event alone in those cases, there was no need to call the other version." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18202/builds/12990) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 0dc8bacbfe2db01c2ef165facef189824ab69f7a:\n\n|Sandbox| Source |\n|--|--|\n|[loving-mendel-e2igp](https://codesandbox.io/s/loving-mendel-e2igp)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0dc8bacbfe2db01c2ef165facef189824ab69f7a\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0dc8bacbfe2db01c2ef165facef189824ab69f7a\n</p>\n", "If the Hook is completely empty, surely there's no difference between under-specifying deps or over-specifying them? It's unnecessary in either case. I'm not sure why it would make sense to complain about this case. I'm also not sure why somebody would write an empty Hook.", "@gaearon You are right. There is no need for empty hook. Below are my opinions about writing hooks.\r\n\r\n1. Empty hook is needless but it can be written in that way anyway. Current test cases are also stating about that. \r\n\r\n2. `useMemo` disallows over-specifying dependeicies even when memoizing empty code block. I think it would be better if rules were applied consistently.\r\n```javascript\r\nconst [val, setVal] = useState('')\r\nconst func = useMemo(() => {\r\n}, [val])\r\n ^^^^^ not allowed \r\n```\r\n", ">useMemo disallows over-specifying dependeicies even when memoizing empty code block. I think it would be better if rules were applied consistently.\r\n\r\nThis isn't about it being empty. `useMemo` and `useCallback` disallows over-specifying dependencies in general — which is intentional, because you shouldn't have any reason to do that. Those Hooks bodies are supposed to be pure. Effects are different, because you *might* want to run an effect more often. It's not pure. So we allow over-specifying deps for effects." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18201/builds/12970) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 116d535be2c2c46dbeb586c22f58f07d783bb184:\n\n|Sandbox| Source |\n|--|--|\n|[practical-chandrasekhar-0fr3e](https://codesandbox.io/s/practical-chandrasekhar-0fr3e)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fae3558dd1f52d78d7f729ba56100d18bb6eb10a\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fae3558dd1f52d78d7f729ba56100d18bb6eb10a\n</p>\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18201/builds/13406) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit fae3558dd1f52d78d7f729ba56100d18bb6eb10a:\n\n|Sandbox| Source |\n|--|--|\n|[unruffled-archimedes-dmtp9](https://codesandbox.io/s/unruffled-archimedes-dmtp9)| Configuration |\n" ]

[ "If you think this is valid feature request. I would love to help on this issue, I would need help on guidance though :)", "Hi, we don't plan to add more features to PropTypes. However, this probably does what you want:\r\n\r\n```js\r\nChild.propTypes = {\r\n a: PropTypes.string,\r\n b: PropTypes.string,\r\n ...Parent.propTypes\r\n};\r\n```" ]

[ "You were writing `const Component = props => <BaseComp state={state} setState={setState} {...props} />` in the first example and `createFrame` in the second. So in both examples, a new type of component is generated on every render. This a hint that React should unmount the old component and mount the new one instead of reusing the old one .", "@jddxf So why does avoiding JSX seem to solve the problem?\r\nIn the first example, why does `{Component()}` work when `<Component />` doesn't?\r\nIn the second example, why does `createFrame()(props)` work?", "The non-jsx equivalent of `<Component />` is `React.createElement(Component)` rather than `{Component()}`. Only things passed to `React.createElement` as the first parameter will be regarded as component types by React.", "This should explain what's happening: https://reactjs.org/docs/reconciliation.html#elements-of-different-types\r\n\r\nIn general, *defining* components inside other components (or Hooks) is a mistake. Instead, usually you want to declare them outside.", "Calling it as a function fixes constant re-mounting problem, but produces a lot of these instead:\r\n\r\n\r\n" ]

[ "I dont think this is an issue per se. It's just a matter of how refs work. You can use a callback to achieve your intended outcome.\r\n\r\n[Here is an example from the docs](https://reactjs.org/docs/hooks-faq.html#how-can-i-measure-a-dom-node)\r\n\r\n```\r\nimport React, { useCallback, useRef } from \"react\";\r\nimport AUserList from \"./AUserList\";\r\nimport { connect } from \"react-redux\";\r\n\r\nconst AUsers = props => {\r\n // list = useCallback()\r\n const divTag = React.createRef();\r\n\r\n const [ref, setRef] = useHookWithRefCallback();\r\n\r\n const handleChangeDataList = () => {\r\n console.log(ref); //null\r\n console.log(divTag.current);\r\n ref.current.reloadAUserTable(); //it is error\r\n };\r\n\r\n return (\r\n <>\r\n <div\r\n onClick={handleChangeDataList}\r\n className=\"animated fadeIn\"\r\n ref={divTag}\r\n >\r\n TEST\r\n </div>\r\n <AUserList AUserData_arr={[{ test: 1 }]} ref={setRef} />\r\n </>\r\n );\r\n};\r\n\r\nconst mapDispatchToProps = dispatch => ({\r\n fetchInterests: () => () => {}\r\n});\r\n\r\nconst mapStateToProps = (state, ownProps) => ({\r\n interests: () => {}\r\n});\r\n\r\nexport default connect(\r\n mapStateToProps,\r\n mapDispatchToProps,\r\n null,\r\n { forwardRef: true }\r\n)(AUsers);\r\n```\r\n\r\n```\r\nfunction useHookWithRefCallback() {\r\n const ref = useRef(null);\r\n const setRef = useCallback(node => {\r\n if (ref.current) {\r\n // Make sure to cleanup any events/references added to the last instance\r\n }\r\n\r\n if (node) {\r\n // Check if a node is actually passed. Otherwise node would be null.\r\n // You can now do what you need to, addEventListeners, measure, etc.\r\n }\r\n\r\n // Save a reference to the node\r\n ref.current = node;\r\n }, []);\r\n\r\n return [ref, setRef];\r\n}\r\n```", "Thanks for your reply!\r\nI hope to use this script on my project.\r\nhttps://stackoverflow.com/questions/37949981/call-child-method-from-parent\r\nbut I failed. If you can explain using class components after check this, it will be my great pleasure.\r\nThanks again.\r\n:)", "Hi! We use the issue tracker for bug reports and feature requests.\r\n\r\nIf you have a question, please check our community support resources:\r\nhttps://facebook.github.io/react/community/support.html" ]

[ "I think it's how browser works.\r\nhttps://codesandbox.io/s/gracious-morning-1ikef", "Yeah it seems so, my bad. Thought it was something to do with Reacts SyntheticEvent wrapper but I guess not! For anyone that gets this issue the easiest (though ugly) way to do this seems to be to simply wrap a settimeout to the switching of the button type after the button is clicked (setstate in my case). If there are any other/cleaner approaches please feel free to reopen?" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18196/builds/13177) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 34baecb50a571a8da362a9ae81c7049826b61cc0:\n\n|Sandbox| Source |\n|--|--|\n|[tender-dirac-mkt4x](https://codesandbox.io/s/tender-dirac-mkt4x)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 7e83af17cea784aee93ba555317d871e7c989dca...34baecb50a571a8da362a9ae81c7049826b61cc0</p>\n\n\n \n## react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact.development.js | 0.0% | 0.0% | 99.51 KB | 99.54 KB | 24.48 KB | 24.49 KB | UMD_DEV\nReactTesting-dev.js | n/a | n/a | 0 B | 74.46 KB | 0 B | 18.91 KB | FB_WWW_DEV\n**ReactTesting-prod.js** | **n/a** | **n/a** | **0 B** | **17.71 KB** | **0 B** | **4.57 KB** | **FB_WWW_PROD**\nreact-unstable-testing.development.js | n/a | n/a | 0 B | 99.56 KB | 0 B | 24.5 KB | UMD_DEV\nReactTesting-profiling.js | n/a | n/a | 0 B | 17.71 KB | 0 B | 4.57 KB | FB_WWW_PROFILING\n**react-unstable-testing.production.min.js** | **n/a** | **n/a** | **0 B** | **11.62 KB** | **0 B** | **4.57 KB** | **UMD_PROD**\nreact-unstable-testing.profiling.min.js | n/a | n/a | 0 B | 15.16 KB | 0 B | 5.69 KB | UMD_PROFILING\nreact-unstable-testing.development.js | n/a | n/a | 0 B | 61.43 KB | 0 B | 16.77 KB | NODE_DEV\n**react-unstable-testing.production.min.js** | **n/a** | **n/a** | **0 B** | **6.55 KB** | **0 B** | **2.67 KB** | **NODE_PROD**\nreact.development.js | 0.0% | 0.0% | 61.38 KB | 61.41 KB | 16.75 KB | 16.76 KB | NODE_DEV\n**react.production.min.js** | **-0.5%** | **-0.8%** | **6.54 KB** | **6.5 KB** | **2.66 KB** | **2.64 KB** | **NODE_PROD**\nReact-dev.js | 0.0% | 0.0% | 74.44 KB | 74.46 KB | 18.91 KB | 18.91 KB | FB_WWW_DEV\n**React-prod.js** | **-0.2%** | **-0.6%** | **17.71 KB** | **17.67 KB** | **4.57 KB** | **4.54 KB** | **FB_WWW_PROD**\nReact-profiling.js | -0.2% | -0.6% | 17.71 KB | 17.67 KB | 4.57 KB | 4.54 KB | FB_WWW_PROFILING\n\n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \n**react-dom.production.min.js** | **-0.0%** | **-0.0%** | **115.9 KB** | **115.9 KB** | **36.44 KB** | **36.43 KB** | **NODE_PROD**\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.1% | 3.34 KB | 3.34 KB | 1.26 KB | 1.26 KB | UMD_DEV\nreact-dom.profiling.min.js | -0.0% | -0.0% | 119.58 KB | 119.58 KB | 37.5 KB | 37.49 KB | NODE_PROFILING\nreact-dom-unstable-testing.profiling.min.js | n/a | n/a | 0 B | 120.44 KB | 0 B | 38.78 KB | UMD_PROFILING\nreact-dom-unstable-testing.development.js | n/a | n/a | 0 B | 845.36 KB | 0 B | 193.62 KB | NODE_DEV\n**react-dom-unstable-testing.production.min.js** | **n/a** | **n/a** | **0 B** | **117.03 KB** | **0 B** | **36.92 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **-0.0%** | **20.31 KB** | **20.31 KB** | **7.51 KB** | **7.51 KB** | **NODE_PROD**\nreact-dom-unstable-testing.profiling.min.js | n/a | n/a | 0 B | 120.72 KB | 0 B | 37.99 KB | NODE_PROFILING\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.94 KB** | **10.94 KB** | **4.16 KB** | **4.16 KB** | **UMD_PROD**\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 49.55 KB | 49.55 KB | 13.51 KB | 13.51 KB | NODE_DEV\nreact-dom-unstable-fizz.node.development.js | 0.0% | +0.1% | 3.68 KB | 3.68 KB | 1.33 KB | 1.33 KB | NODE_DEV\nreact-dom.development.js | 0.0% | 0.0% | 882.49 KB | 882.56 KB | 194.45 KB | 194.47 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 134.59 KB | 134.59 KB | 34.59 KB | 34.59 KB | UMD_DEV\n**react-dom.production.min.js** | **-0.0%** | **0.0%** | **115.83 KB** | **115.82 KB** | **37.06 KB** | **37.06 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | -0.0% | -0.0% | 119.35 KB | 119.35 KB | 38.28 KB | 38.28 KB | UMD_PROFILING\nreact-dom.development.js | 0.0% | 0.0% | 839.83 KB | 839.9 KB | 192.08 KB | 192.11 KB | NODE_DEV\nReactDOM-dev.js | 0.0% | 0.0% | 937.2 KB | 937.27 KB | 208.79 KB | 208.82 KB | FB_WWW_DEV\n**ReactDOM-prod.js** | **-0.0%** | **-0.0%** | **394.76 KB** | **394.75 KB** | **71.74 KB** | **71.74 KB** | **FB_WWW_PROD**\n**ReactDOMServer-prod.js** | **0.0%** | **0.0%** | **47.39 KB** | **47.39 KB** | **11.03 KB** | **11.03 KB** | **FB_WWW_PROD**\nReactDOM-profiling.js | -0.0% | -0.0% | 406.05 KB | 406.04 KB | 73.9 KB | 73.89 KB | FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **-0.2%** | **1013 B** | **1013 B** | **602 B** | **601 B** | **NODE_PROD**\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.0%** | **10.26 KB** | **10.26 KB** | **3.49 KB** | **3.49 KB** | **UMD_PROD**\nReactDOMTesting-dev.js | +5.2% | +5.0% | 896.55 KB | 943.15 KB | 200.3 KB | 210.36 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **:small_red_triangle:+4.2%** | **:small_red_triangle:+4.4%** | **381.82 KB** | **397.88 KB** | **69.46 KB** | **72.49 KB** | **FB_WWW_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\nreact-dom-unstable-testing.development.js | n/a | n/a | 0 B | 888.3 KB | 0 B | 195.98 KB | UMD_DEV\nReactDOMTesting-profiling.js | +7.2% | +7.4% | 381.82 KB | 409.17 KB | 69.46 KB | 74.64 KB | FB_WWW_PROFILING\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.0%** | **9.99 KB** | **9.99 KB** | **3.37 KB** | **3.36 KB** | **NODE_PROD**\n**react-dom-unstable-testing.production.min.js** | **n/a** | **n/a** | **0 B** | **116.91 KB** | **0 B** | **37.57 KB** | **UMD_PROD**\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 34baecb50a571a8da362a9ae81c7049826b61cc0\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 4 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 7e83af17cea784aee93ba555317d871e7c989dca...34baecb50a571a8da362a9ae81c7049826b61cc0</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom-unstable-testing.development.js | n/a | n/a | 0 B | 916.98 KB | 0 B | 200.9 KB | UMD_DEV\n**react-dom-unstable-testing.production.min.js** | **n/a** | **n/a** | **0 B** | **120.81 KB** | **0 B** | **38.71 KB** | **UMD_PROD**\nReactDOMTesting-dev.js | +3.5% | +3.4% | 870.96 KB | 901.71 KB | 195.14 KB | 201.82 KB | FB_WWW_DEV\n**react-dom-server.browser.production.min.js** | **0.0%** | **-0.0%** | **20.44 KB** | **20.44 KB** | **7.49 KB** | **7.49 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | -0.0% | -0.0% | 123.67 KB | 123.66 KB | 38.56 KB | 38.56 KB | NODE_PROFILING\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 53.78 KB | 53.78 KB | 14.01 KB | 14.01 KB | UMD_DEV\nReactDOM-dev.js | 0.0% | 0.0% | 895.75 KB | 895.82 KB | 200.25 KB | 200.27 KB | FB_WWW_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.96 KB** | **10.96 KB** | **4.17 KB** | **4.17 KB** | **UMD_PROD**\n**ReactDOM-prod.js** | **-0.0%** | **-0.0%** | **370.91 KB** | **370.9 KB** | **67.53 KB** | **67.53 KB** | **FB_WWW_PROD**\nReactDOM-profiling.js | -0.0% | -0.0% | 382.12 KB | 382.11 KB | 69.66 KB | 69.65 KB | FB_WWW_PROFILING\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 49.56 KB | 49.56 KB | 13.52 KB | 13.52 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\n**react-dom-unstable-fizz.browser.production.min.js** | **0.0%** | **-0.2%** | **1 KB** | **1 KB** | **610 B** | **609 B** | **NODE_PROD**\nreact-dom-server.node.development.js | 0.0% | -0.0% | 130.42 KB | 130.42 KB | 34.65 KB | 34.65 KB | NODE_DEV\nreact-dom-unstable-testing.profiling.min.js | n/a | n/a | 0 B | 124.45 KB | 0 B | 39.89 KB | UMD_PROFILING\n**ReactDOMTesting-prod.js** | **:small_red_triangle:+1.4%** | **:small_red_triangle:+1.3%** | **368.93 KB** | **374.03 KB** | **67.44 KB** | **68.31 KB** | **FB_WWW_PROD**\nreact-dom-unstable-testing.development.js | n/a | n/a | 0 B | 872.86 KB | 0 B | 198.49 KB | NODE_DEV\nReactDOMTesting-profiling.js | +4.4% | +4.4% | 368.93 KB | 385.24 KB | 67.44 KB | 70.39 KB | FB_WWW_PROFILING\nreact-dom-server.browser.development.js | 0.0% | -0.0% | 129.21 KB | 129.21 KB | 34.39 KB | 34.39 KB | NODE_DEV\n**react-dom-unstable-testing.production.min.js** | **n/a** | **n/a** | **0 B** | **121 KB** | **0 B** | **37.94 KB** | **NODE_PROD**\nreact-dom.development.js | 0.0% | 0.0% | 911.17 KB | 911.25 KB | 199.37 KB | 199.4 KB | UMD_DEV\nreact-dom-unstable-testing.profiling.min.js | n/a | n/a | 0 B | 124.8 KB | 0 B | 39.05 KB | NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 58.91 KB | 58.91 KB | 14.7 KB | 14.7 KB | UMD_DEV\n**react-dom.production.min.js** | **-0.0%** | **-0.0%** | **119.72 KB** | **119.72 KB** | **38.22 KB** | **38.22 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | -0.0% | -0.0% | 123.37 KB | 123.36 KB | 39.4 KB | 39.4 KB | UMD_PROFILING\n**ReactDOMServer-prod.js** | **0.0%** | **-0.0%** | **46.68 KB** | **46.68 KB** | **10.84 KB** | **10.84 KB** | **FB_WWW_PROD**\nreact-dom.development.js | 0.0% | 0.0% | 867.33 KB | 867.4 KB | 196.96 KB | 196.99 KB | NODE_DEV\nreact-dom-unstable-native-dependencies.development.js | 0.0% | -0.0% | 55.87 KB | 55.87 KB | 14.47 KB | 14.46 KB | NODE_DEV\nreact-dom-unstable-fizz.node.development.js | 0.0% | +0.1% | 3.69 KB | 3.69 KB | 1.34 KB | 1.34 KB | NODE_DEV\n**react-dom.production.min.js** | **-0.0%** | **-0.0%** | **119.87 KB** | **119.87 KB** | **37.45 KB** | **37.44 KB** | **NODE_PROD**\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **-0.0%** | **10 KB** | **10 KB** | **3.37 KB** | **3.37 KB** | **NODE_PROD**\n\n## react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact.development.js | 0.0% | 0.0% | 107.4 KB | 107.43 KB | 25.69 KB | 25.69 KB | UMD_DEV\n**react.production.min.js** | **0.0%** | **-0.0%** | **12.46 KB** | **12.46 KB** | **4.8 KB** | **4.8 KB** | **UMD_PROD**\nreact-unstable-testing.development.js | n/a | n/a | 0 B | 107.45 KB | 0 B | 25.7 KB | UMD_DEV\n**react-unstable-testing.production.min.js** | **n/a** | **n/a** | **0 B** | **12.47 KB** | **0 B** | **4.81 KB** | **UMD_PROD**\nReactTesting-dev.js | n/a | n/a | 0 B | 73.79 KB | 0 B | 18.73 KB | FB_WWW_DEV\nreact-unstable-testing.profiling.min.js | n/a | n/a | 0 B | 16.01 KB | 0 B | 5.9 KB | UMD_PROFILING\n**ReactTesting-prod.js** | **n/a** | **n/a** | **0 B** | **17.65 KB** | **0 B** | **4.56 KB** | **FB_WWW_PROD**\nreact-unstable-testing.development.js | n/a | n/a | 0 B | 68.95 KB | 0 B | 17.97 KB | NODE_DEV\nReactTesting-profiling.js | n/a | n/a | 0 B | 17.65 KB | 0 B | 4.56 KB | FB_WWW_PROFILING\n**react-unstable-testing.production.min.js** | **n/a** | **n/a** | **0 B** | **7.53 KB** | **0 B** | **2.92 KB** | **NODE_PROD**\nreact.development.js | 0.0% | 0.0% | 68.91 KB | 68.94 KB | 17.96 KB | 17.96 KB | NODE_DEV\n**react.production.min.js** | **-0.4%** | **-0.5%** | **7.51 KB** | **7.48 KB** | **2.91 KB** | **2.89 KB** | **NODE_PROD**\nReact-dev.js | 0.0% | 0.0% | 73.76 KB | 73.79 KB | 18.73 KB | 18.73 KB | FB_WWW_DEV\n**React-prod.js** | **-0.2%** | **-0.6%** | **17.65 KB** | **17.61 KB** | **4.56 KB** | **4.53 KB** | **FB_WWW_PROD**\nReact-profiling.js | -0.2% | -0.6% | 17.65 KB | 17.61 KB | 4.56 KB | 4.53 KB | FB_WWW_PROFILING\n\n </details>\n \n\nReactDOM: size: n/a, gzip: n/a\n\nReact: size: 0.0%, gzip: -0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 34baecb50a571a8da362a9ae81c7049826b61cc0\n</p>\n", "I don’t understand, how would this setup disable warnings? You’d see CI to break badly if that was the case. \n\nThe act one I modified makes it so the fallback behaviour is the same in prod (but only in testing builds). ", "Has this been abandoned? I was a bit confused why I didn't get missing act warnings until I found out that these are only enabled for `jest`. Naively I wanted to propose to check `NODE_ENV`: \r\n```diff\r\n-if ('undefined' !== typeof jest) {\r\n+if (process.env.NODE_ENV === 'test') {\r\n```\r\nwhich is set by `jest` as well (by default) but this [is somewhat controversial](https://github.com/facebook/jest/issues/3370).\r\n\r\nIf you still intend to ship extra testing builds (which I prefer over mocking scheduler) I'd like to help. Seems like this PR \"only\" needs to be updated with `master`?" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18195/builds/12967) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 4cd1e1103b0c4800e037dbd8fd3be46c019b490c:\n\n|Sandbox| Source |\n|--|--|\n|[determined-snowflake-i690y](https://codesandbox.io/s/determined-snowflake-i690y)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 4cd1e1103b0c4800e037dbd8fd3be46c019b490c\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 4cd1e1103b0c4800e037dbd8fd3be46c019b490c\n</p>\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18194/builds/12792) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 8e5abebf038463425612cf99ad1309775412c1e6:\n\n|Sandbox| Source |\n|--|--|\n|[broken-platform-8ij9w](https://codesandbox.io/s/broken-platform-8ij9w)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8e5abebf038463425612cf99ad1309775412c1e6\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8e5abebf038463425612cf99ad1309775412c1e6\n</p>\n", "@necolas I'm going to land this one now as it fixes a high-pri internal issue. If you have any feedback or concerns, I'd be happy to follow up ASAP.", "tyyyyy!!!" ]

[ "Please file this issue at https://github.com/facebook/create-react-app/issues" ]

[ "This is a really sparse issue description :smile: Can you provide some more information on how you're reproducing the error you're seeing?", "Duplicate of #18044 ", "Closing due to lack of response from OP and because it also seems to be a duplicate." ]

[ "This relates to the discussion on #18177 (and #18190).\r\n\r\n### Why does this have anything to do with DevTools?\r\n\r\nDevTools shallowly re-renders components that use hooks in order to build up the map of hook-to-value to show in the selected properties panel. ([Read more about this here if you're interested.](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md#inspecting-hooks))\r\n\r\nWhen it does this re-rendering, it temporarily overrides the React's built-in hooks with [a version that collects this metadata about which hooks (and custom hooks) the component is using](https://github.com/facebook/react/blob/master/packages/react-debug-tools/src/ReactDebugHooks.js). \r\n\r\n1. This re-render is **shallow**. (No children are rendered)\r\n2. The results are not retained or committed (e.g. no DOM update).\r\n3. It does not run any effects callbacks, so no side effects will be run.\r\n4. It does not re-run `useMemo` or `useCallback` functions either (because that would be doing unnecessary \"work\" - since the results are thrown away).\r\n\r\nAs your sandbox shows, the re-render is **detectable** but should not cause any problems, so long as you follow the rules of React (no side effects in render).", "I'm going to close this issue now since I think it's just a question which has now been answered. Let's talk more if there's still concern though!", "While I understand the reasons for this, it can be annoying and lead to false negatives when debugging and testing performance of components.\r\n\r\nJust the other day, I was banging my head against a brick wall, trying to figure out why a component was always being rendered twice, until I figure out that it was devtools doing its thing.\r\n\r\nMy component didn't have any side effects in the render, but I still didn't want to it re-render.\r\n\r\nWould it be possible to somehow indicate that a component has been re-rendered by devtools?", "> Would it be possible to somehow indicate that a component has been re-rendered by devtools?\r\n\r\nIndicate...how?", "lol, no idea 🤷‍♂️\r\n\r\nI was kinda hoping you'd have a magic trick up your sleeve 😜\r\n\r\n... just thinking out loud, sorry", "No worries. It's okay.\r\n\r\nI don't know of a better way of doing this, after putting a good amount of thought into the current approach. There may one though.", "Hi @bvaughn. Thanks for looking into it.\r\n\r\n>As your sandbox shows, the re-render is detectable but should not cause any problems, so long as you follow the rules of React (no side effects in render).\r\n\r\nI understand this. And I'm not trying to detect a _re-render_ here.\r\n\r\nTo me it _seems_ there's an inconsistency between `useMemo` and `useCallback` inside React DevTools.\r\n\r\nI think my initial sandbox had too much code to display what I'm suspicious about.\r\nCould you take a look at this simplified sandbox? https://codesandbox.io/s/usecallback-vs-usememo-simple-child-0wc1r\r\n\r\nBoth `useMemo` and `useCallback` have an empty deps array. Because of this, I would expect none of them to generate a new value during a shallow re-render by React DevTools. But for some reason `useCallback` generates a new value and `useMemo` returns the old value. To me it seems that `useCallback` loses its memoized value.\r\n\r\n\r\n\r\n### I did some debugging of React DevTools ###\r\nI assume the issue is here: https://github.com/facebook/react/blob/master/packages/react-debug-tools/src/ReactDebugHooks.js#L214\r\n`useCallback` always returns the latest `callback` value instead of returning `hook !== null ? hook.memoizedState[0] : callback` as it is done in `useMemo` few lines bellow.\r\n\r\n\r\n\r\nWhat do you think?", "> To me it seems that `useCallback` loses its memoized value.\r\n\r\nIt doesn't *lose* the memoized value. That value is still around for the next *real* render.\r\n\r\nWhile you're right that there's a discrepancy between the debug tools implementation of `useMemo` and `useCallback`, I don't think it actually matters. The value returned for the shallow render could even be an empty/noop function- because nothing will actually call that method. (It won't be passed to any child components.)", "I don't object if you'd like to submit a PR that makes the two hook implementations \"match\" in that sense. I also don't think it's that important either way though :smile:" ]

[ "concent features [demo list](https://codesandbox.io/s/green-tdd-g2mcr)", "Furthermore, I have try the code below:\r\n```js\r\nimport React, { useState, useEffect } from \"react\";\r\n\r\nconst fnWrapper = {setCount:()=>{}};\r\n\r\nexport default function DemoCounter() {\r\n console.log(\"render DemoCounter \" + Date.now());\r\n const [count, setCount] = useState(0);\r\n fnWrapper.setCount = s=>setCount(s);\r\n useEffect(()=>{\r\n console.log('assign setCount in useEffect');\r\n fnWrapper.setCount = s=>setCount(s);\r\n })\r\n\r\n return (\r\n <div style={{ border: \"1px solid blue\", margin: \"8px\" }}>\r\n input_1 <input\r\n value={count}\r\n onChange={e => fnWrapper.setCount(e.currentTarget.value)}\r\n />\r\n change by wrapped setter\r\n <br />\r\n input_2 <input value={count} onChange={e => setCount(e.currentTarget.value)} />\r\n change by hook setter\r\n </div>\r\n );\r\n}\r\n\r\n```\r\nthen I open react-dev-tool and click the dom in tis panel, and then any typing doesn't works in input_1, but if I type some word in input_2, then typing some word in input_1 will trigger re-render, so I don't think this is a perfect way, that's why I write the code `getSetter` in the issue, try to recover the correct setter.", "or can react give some api like `getLatestSetter` to resolve my problem? then I need not to write the code `getSetter` above.\r\n```\r\nimport React, { useState, useEffect } from \"react\";\r\n\r\nconst fnWrapper = {setCount:()=>{}};\r\n\r\nexport default function DemoCounter() {\r\n console.log(\"render DemoCounter \" + Date.now());\r\n const [count, setCount] = useState(0);\r\n\r\n // user can always get the latest setter\r\n fnWrapper.setCount = s=>setCount.getLatestSetter()(s);\r\n\r\n}\r\n```", "@fantasticsoul Please do not continue to open additional issues about this. It's not going to change [the answer](https://github.com/facebook/react/issues/18177#issuecomment-592614239) we keep giving.\r\n\r\nThis now the third time I've said that **side effects belong inside of a `useEffect` callback and not in your render method.** The code you show above **still has a side effect in render**:\r\n```js\r\nimport React, { useState, useEffect } from \"react\";\r\n\r\nconst fnWrapper = {setCount:()=>{}};\r\n\r\nexport default function DemoCounter() {\r\n console.log(\"render DemoCounter \" + Date.now());\r\n const [count, setCount] = useState(0);\r\n\r\n // This is still a side effect in render!\r\n // It is still not allowed!\r\n // Get rid of this line, and leave the one below in `useEffect`.\r\n fnWrapper.setCount = s=>setCount(s);\r\n\r\n useEffect(()=>{\r\n console.log('assign setCount in useEffect');\r\n fnWrapper.setCount = s=>setCount(s);\r\n })\r\n\r\n return (\r\n <div style={{ border: \"1px solid blue\", margin: \"8px\" }}>\r\n input_1 <input\r\n value={count}\r\n onChange={e => fnWrapper.setCount(e.currentTarget.value)}\r\n />\r\n change by wrapped setter\r\n <br />\r\n input_2 <input value={count} onChange={e => setCount(e.currentTarget.value)} />\r\n change by hook setter\r\n </div>\r\n );\r\n}\r\n```\r\n\r\nIf there's still some confusion, that's okay. Let's talk about it on this issue (and not another new issue).", "thank you so much, I've learned many many interesting things, and I finally resolve my problem perfectly with code below:\r\n[online-demo](https://codesandbox.io/s/test-react-dev-tool-bug-kpb1y)\r\n```js\r\n// code in useObj.js\r\nimport * as React from \"react\";\r\n\r\nlet cursor = 1;\r\nlet corsor_ctx_ = {};\r\nlet cursor_setter_ = {};//cache the setter\r\n\r\nfunction inc() {\r\n cursor++;\r\n}\r\n\r\nfunction getU() {\r\n return cursor;\r\n}\r\n\r\nfunction buildCtx(cursor){\r\n return {\r\n cursor,\r\n renderCount: 1,\r\n }\r\n}\r\n\r\nexport default function useObjectState(obj) {\r\n const curCursor = getU();\r\n const [lockedCursor] = React.useState(curCursor);\r\n const [state, setter] = React.useState(obj);\r\n if(!cursor_setter_[lockedCursor]){\r\n cursor_setter_[lockedCursor] = setter;\r\n }\r\n\r\n let ctx;\r\n if (curCursor === lockedCursor) {\r\n ctx = buildCtx(lockedCursor);\r\n inc();\r\n corsor_ctx_[lockedCursor] = ctx;\r\n } else {\r\n ctx = corsor_ctx_[lockedCursor];\r\n if(!ctx) ctx = buildCtx(lockedCursor); \r\n ctx.renderCount++;\r\n }\r\n\r\n ctx.state = state;\r\n ctx.setState = (partialState) => {\r\n const newState = Object.assign({}, state, partialState);\r\n console.log(newState);\r\n cursor_setter_[lockedCursor](newState);\r\n }\r\n\r\n return ctx;\r\n}\r\n```", "I improve my code continually, now its answer is more clear to me:\r\n[online demo](https://codesandbox.io/s/test-react-dev-tool-bug-kpb1y)\r\n```js\r\nimport React, { useState, useRef } from \"react\";\r\n\r\nfunction DemoCounter() {\r\n console.log(\"render DemoCounter \" + Date.now());\r\n const [count, setCount] = useState(0);\r\n const fn = useRef({})\r\n\r\n const onChangeNormal = e => setCount(e.currentTarget.value);\r\n fn.current.setCount = (val, s)=>{\r\n if(s)s(val);\r\n // note this, when call setCount will cause a react-dev-tool 'bug':\r\n // if you open the react-dev-tool and click dom, then line 3 will \r\n // no longer re-render if you type word in its input box.\r\n // but actually it is not a bug\r\n // see https://github.com/facebook/react/blob/master/packages/react-debug-tools/src/ReactDebugHooks.js, \r\n //as a result: the more recent render (by DevTools) causes you to override it \r\n // with the injected no-op value so that future calls don't actually update state\r\n else setCount(val);\r\n };\r\n\r\n const onChangeOk = e => fn.current.setCount(e.currentTarget.value, setCount);\r\n const onChangeNotOk = e => fn.current.setCount(e.currentTarget.value);\r\n\r\n return (\r\n <div style={{ border: \"1px solid blue\", margin: \"8px\" }}>\r\n <h3>\r\n if you open the react-dev-tool and click dom, then line 3\r\n will no longer re-render if you type word in its input box\r\n </h3>\r\n line 1: <input value={count} onChange={onChangeNormal} />\r\n change by onChangeNormal\r\n <br />\r\n line 2: <input value={count} onChange={onChangeOk} />\r\n change by onChangeOk\r\n <br />\r\n line 3: <input value={count} onChange={onChangeNotOk} />\r\n change by onChangeNotOk\r\n </div>\r\n );\r\n}\r\n\r\n\r\nfunction DemoCounterBetter() {\r\n console.log(\"render DemoCounter \" + Date.now());\r\n const [count, setCount] = useState(0);\r\n const setter = useRef({setCount, fn:0})\r\n const firstRenderSetter = setter.current.setCount;\r\n\r\n const onChangeNormal = e => setCount(e.currentTarget.value);\r\n setter.current.setCount = (val)=>{\r\n firstRenderSetter(val);\r\n };\r\n\r\n const onChangeOk = e => setter.current.setCount(e.currentTarget.value);\r\n const onChangeOkAlso = e => setter.current.setCount(e.currentTarget.value);\r\n\r\n return (\r\n <div style={{ border: \"1px solid blue\", margin: \"8px\" }}>\r\n <h3>\r\n better one\r\n </h3>\r\n line 1: <input value={count} onChange={onChangeNormal} />\r\n change by onChangeNormal\r\n <br />\r\n line 2: <input value={count} onChange={onChangeOk} />\r\n change by onChangeOk\r\n <br />\r\n line 3: <input value={count} onChange={onChangeOkAlso} />\r\n change by onChangeOkAlso\r\n </div>\r\n );\r\n}\r\n\r\nexport default function App(){\r\n return (\r\n <>\r\n <DemoCounter />\r\n <hr />\r\n <DemoCounterBetter />\r\n </>\r\n )\r\n}\r\n```\r\nI hope my answer can help more developer to know more about this problem. and thank you for your patience over and over again.", "@fantasticsoul It's super unclear to me why you're doing what you're doing with refs in the example above. Mutating a ref during render **is still a side effect** and has all of the same potential problems as any side effect (although it's an improvement from the earlier example of mutating a value *outside of the function*).\r\n\r\n```js\r\nfunction DemoCounter() {\r\n const [count, setCount] = useState(0);\r\n const fn = useRef({});\r\n\r\n // This event handler looks good 👍\r\n const onChangeNormal = e => setCount(e.currentTarget.value);\r\n\r\n // This is a side effect during render!\r\n // It will cause broken behavior and should be removed!\r\n fn.current.setCount = (val, s) => {\r\n if (s) s(val);\r\n else setCount(val);\r\n };\r\n\r\n // These callbacks should literally just call setCount() directly.\r\n // They is no need to use the fn ref.\r\n // It will cause bugs where there would otherwise be no bugs.\r\n const onChangeOk = e => fn.current.setCount(e.currentTarget.value, setCount);\r\n const onChangeNotOk = e => fn.current.setCount(e.currentTarget.value);\r\n\r\n // ...\r\n}\r\n\r\nfunction DemoCounterBetter() {\r\n const [count, setCount] = useState(0);\r\n const setter = useRef({ setCount, fn: 0 });\r\n\r\n // What is this? Why do you need it?\r\n // Just use setCount directly.\r\n const firstRenderSetter = setter.current.setCount;\r\n\r\n // This event handler looks good 👍\r\n const onChangeNormal = e => setCount(e.currentTarget.value);\r\n\r\n // This is a side effect during render!\r\n // It will cause broken behavior and should be removed!\r\n setter.current.setCount = val => {\r\n firstRenderSetter(val);\r\n };\r\n\r\n // These callbacks should literally just call setCount() directly.\r\n // They is no need to use the fn ref.\r\n // It will cause bugs where there would otherwise be no bugs.\r\n const onChangeOk = e => setter.current.setCount(e.currentTarget.value);\r\n const onChangeOkAlso = e => setter.current.setCount(e.currentTarget.value);\r\n\r\n // ...\r\n}\r\n```" ]

[ "Hi @utkarshkukreti! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nIf you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Freact%20%2318189). Thanks!", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18189/builds/12615) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b7936ad40d8f268b35ea3bd445f2f4c303148f52:\n\n|Sandbox| Source |\n|--|--|\n|[great-hugle-hpefc](https://codesandbox.io/s/great-hugle-hpefc)| Configuration |\n", "Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b7936ad40d8f268b35ea3bd445f2f4c303148f52\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b7936ad40d8f268b35ea3bd445f2f4c303148f52\n</p>\n" ]

[ "This seems like a sass loader or webpack. Issue not a React one?", "It’s not clear from this issue what this has to do with React. By “add-on” do you mean React dev tools? How would the devtools affect your situation? Please describe an exact set of steps, with screenshots, to reproduce this locally. ", "I meant the React Developer Tools add-on for Firefox, its home page link directs you here.\r\n\r\n\r\n\r\n\r\n\r\n", "I still have no idea how React DevTools could be interfering with your browser's source maps. It's just an extension that injects some JavaScript into the active tab for React to interact with. Has nothing to do with actual loading or parsing of resources.\r\n\r\nIf anything, this seems like a browser bug.", "I know it sounds strange, but it does happen, as bizarre as it may be. Toggle the React Developer Tools off and all is good.", "Sounds like a browser bug. The two should have **nothing** to do with each other.", "> Sounds like a browser bug. The two should have **nothing** to do with each other.\r\n\r\nYou are right they should not, but they do. I think that a tool that comes in to do a task on a browsers should consider the browsers they walk in to. Blaming the browser for something the browser was doing fine before the tool was enabled does not make any sense.", "We haven’t heard of this issue from anyone else. There isn’t much we can do from our side, I’d recommend filing an issue at https://bugzilla.mozilla.org/home against Firefox. I’ll leave this open for a while to see if anyone else has any idea. ", "I think we should just close this bug, Sunil. I think @alvaro-escalante (or anyone) should report this to Mozilla. For the time being, I am not aware of anything we are doing (or could do) that should affect how the browser loads or parses source maps.", "@bvaughn Have you tried to reproduce the problem? \r\n\r\nI just don't understand why it should be Firefox's problem, when disabling the add-on it fixes the issue.\r\n\r\nI know it's a very niche problem that involves Firefox, Webpack, Sass source-maps and React Developer Tools, and so I am quite sure that few people have figured out that disabling the add-on fixes the problem. But it is a bug nonetheless.\r\n\r\nMost people that care about source-maps and use Firefox, most likely, have turned to Google Chrome cause there's no problem there, If this is the stance... you might as well not do a version for Firefox.", "Hello there @alvaro-escalante.\r\n\r\nI had some time today to check your issue.\r\n\r\nI can't reproduce the problem with Firefox 73.\r\n\r\nScreen bellow:\r\n<img width=\"1679\" alt=\"Screenshot 2020-03-03 at 14 21 59\" src=\"https://user-images.githubusercontent.com/23095052/75779858-b72f6d80-5d5a-11ea-9367-b19306ea1cf8.png\">\r\n\r\nFor me the latest stable version of Firefox is 73.\r\nI can see that Firefox 74 is currently in **beta** judging by [MDN](https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/74): 👇 \r\n\r\n<img width=\"577\" alt=\"Screenshot 2020-03-03 at 14 26 43\" src=\"https://user-images.githubusercontent.com/23095052/75780142-2311d600-5d5b-11ea-84b9-28585f25a52d.png\">\r\n\r\nAs @bvaughn and @threepointone were saying - we haven't heard of a similar issue before. \r\n\r\nI suggest we close this issue as it seems that it's on Mozilla's side. \r\nIt might be still be worth while to file an issue on https://bugzilla.mozilla.org/home \r\n", "Closing. Happy to reopen if 1. There’s a reproducing case 2. There’s a logged issue with Firefox’ tracker and any suggested action that could isolate this as a react issue. ", "> Hello there @alvaro-escalante.\r\n> \r\n> I had some time today to check your issue.\r\n> \r\n> I can't reproduce the problem with Firefox 73.\r\n> \r\n> Screen bellow:\r\n> <img alt=\"Screenshot 2020-03-03 at 14 21 59\" width=\"1679\" src=\"https://user-images.githubusercontent.com/23095052/75779858-b72f6d80-5d5a-11ea-9367-b19306ea1cf8.png\">\r\n> \r\n> For me the latest stable version of Firefox is 73.\r\n> I can see that Firefox 74 is currently in **beta** judging by [MDN](https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/74): 👇\r\n> \r\n> <img alt=\"Screenshot 2020-03-03 at 14 26 43\" width=\"577\" src=\"https://user-images.githubusercontent.com/23095052/75780142-2311d600-5d5b-11ea-84b9-28585f25a52d.png\">\r\n> \r\n> As @bvaughn and @threepointone were saying - we haven't heard of a similar issue before.\r\n> \r\n> I suggest we close this issue as it seems that it's on Mozilla's side.\r\n> It might be still be worth while to file an issue on https://bugzilla.mozilla.org/home\r\n\r\nHi @hristo-kanchev,\r\n\r\nThanks for trying this out.\r\n\r\nThe reason why it did not replicate is because you used my latest boilerplate repo which has a workaround on `webpack.modules.js` that uses `MiniCssExtractPlugin`. If you comment it out and use the commented loader below, the faster `style-loader`, the problem will indeed occur.\r\n\r\nSo basically you did not follow the **Steps To Reproduce** layout on my first bug comment.\r\n\r\n\r\n\r\n", "> I just don't understand why it should be Firefox's problem, when disabling the add-on it fixes the issue.\r\n\r\n> Most people that care about source-maps and use Firefox, most likely, have turned to Google Chrome cause there's no problem there, If this is the stance... you might as well not do a version for Firefox.\r\n\r\nBrowsers can have bugs that websites (or extensions) trigger. The websites/extensions can work around the bugs in some cases. (If you know of a workaround for this one, other than disabling the extension, let's talk!) But the bugs themselves **should be fixed on the browser side**. Right?\r\n\r\nAn extension like React DevTools **should not be able to break sourcemap parsing for the browser**. It should not be possible, **even if the extension wanted to**. The fact that that's happening, to me, indicates that there's something on the Firefox side that should be fixed.", "Hi @alvaro-escalante\r\n\r\nEven when I enabled the config that was commented out (the one you mentioned), I still wasn't able to replicate this.\r\n\r\n", "> I tried this with all versions of Firefox and no add-ons but the RDT.\r\n\r\nOut of curiosity, I wonder if you would be willing to try with a different add-on (e.g. Redux DevTools, Vue or Preact DevTools) just to provide an additional data point.", "@bvaughn, sure:\r\n\r\nIt turns out that Redux DevTools also triggers it:\r\n\r\nReact Developer tools: ❌\r\nRedux DevTools: ❌\r\nPreact Developers Tools: ✅\r\nVue.js devtools: ✅\r\n\r\n\r\n\r\n\r\n\r\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18187/builds/15115) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 2a9418377c6e3a372ab448fe29f30645a1313198:\n\n|Sandbox| Source |\n|--|--|\n|[dank-tree-ld9ho](https://codesandbox.io/s/dank-tree-ld9ho)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2a9418377c6e3a372ab448fe29f30645a1313198\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2a9418377c6e3a372ab448fe29f30645a1313198\n</p>\n", "Alternatively, I could introduce a breaking change to `react-shallow-renderer` (making it v17.0.0) to only used named exports, and then we tweak `react-test-renderer` to re-export it accordingly (and without interop workarounds).\r\n\r\nSomething like\r\n\r\n```diff\r\n// react-shallow-renderer/src/ReactShallowRenderer.js\r\n- export default ReactShallowRenderer;\r\n+ export { ReactShallowRenderer }; // while still keeping the static `createRenderer` property for backwards compat\r\n+ export const createRenderer = function() {\r\n+ return new ReactShallowRenderer();\r\n+ };\r\n\r\n// packages/react-test-renderer/npm/shallow.js\r\n- module.exports = require('react-shallow-renderer');\r\n+ module.exports = require('react-shallow-renderer').ReactShallowRenderer;\r\n\r\n// packages/react-test-renderer/shallow.js\r\n- export {default} from 'react-shallow-renderer';\r\n+ export {ReactShallowRenderer as default} from 'react-shallow-renderer';\r\n```", "Exposing the class was always weird (and probably an accident given createRenderer exists). Unfortunately that's what the docs already show so it's likely people use it widely.", "> Exposing the class was always weird (and probably an accident given createRenderer exists). Unfortunately that's what the docs already show so it's likely people use it widely.\r\n \r\nYeah I don’t think I should remove the class export. However, given it’s a new package (and it’s unlikely that a lot of people have adopted it already), I’m open to cutting a new major release that uses a named export to export the class. When/if people migrate from `react-test-renderer/shallow` they’d have to update their imports anyway, and in my opinion it’s not that much more work to grab (destructure in CJS) `ReactShallowRenderer`.\r\n\r\n@gaearon has suggested via Twitter DM to remove `module` field (since the ESM story is somewhat unclear atm) which I’m kinda open to doing as well, but I think I slightly prefer switching to named exports. @sebmarkbage do you have any thoughts on this? Removing `module` might mean re-enabling `commonjs` plugin for the shallow renderer (like you’re already doing for ART), but maybe that’s an acceptable trade-off?", "One more solution: follow the approach taken in https://github.com/mridgway/hoist-non-react-statics/pull/86 to ensure the CJS version always exports a `.default` property. This would be a breaking change for CJS but ESM would be unaffected. " ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18186/builds/12602) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 598f445bb60ccd312fa03033cb1cc83b5a79db2c:\n\n|Sandbox| Source |\n|--|--|\n|[crazy-nobel-7tud8](https://codesandbox.io/s/crazy-nobel-7tud8)| Configuration |\n", "@NMinhNguyen I merged yours and rebased mine.", "I actually realised something.. I remember seeing an issue in `hoist-non-react-statics` https://github.com/mridgway/hoist-non-react-statics/issues/52 where it used to be published with `module` field and it broke another dependency that was doing `require('hoist-non-react-statics')` (https://github.com/kentor/react-click-outside/blob/e3e1337/index.js#L3) because webpack automatically favours ESM. I wonder if I should update the forwarding module https://github.com/facebook/react/blob/739f20beda56a28a9212e3478571c866babee118/packages/react-test-renderer/npm/shallow.js#L3 to have a `.default` check? Perhaps there's some CJS setup somewhere that uses webpack (e.g. to serve bundles in the browser via Karma), and it could break. Didn't want to create a separate issue for this (kinda need more time to repro as well), but thought I'd mention it somewhere.", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: c26506a7d20a6eafb84ed43b137ebe3c68df6bcd...598f445bb60ccd312fa03033cb1cc83b5a79db2c</p>\n\n\n \n## jest-react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \njest-react.development.js | -33.8% | -35.3% | 5.95 KB | 3.93 KB | 2.13 KB | 1.38 KB | NODE_DEV\n**jest-react.production.min.js** | **-34.0%** | **-28.5%** | **2.5 KB** | **1.65 KB** | **1.26 KB** | **926 B** | **NODE_PROD**\n\n## react-debug-tools\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-debug-tools.development.js | -9.9% | -12.4% | 20.28 KB | 18.27 KB | 5.85 KB | 5.13 KB | NODE_DEV\n**react-debug-tools.production.min.js** | **-13.7%** | **-15.1%** | **6.24 KB** | **5.38 KB** | **2.45 KB** | **2.08 KB** | **NODE_PROD**\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 7903e43124f095bcce7bd0c8189d996312f60988\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: c26506a7d20a6eafb84ed43b137ebe3c68df6bcd...598f445bb60ccd312fa03033cb1cc83b5a79db2c</p>\n\n\n \n## react-debug-tools\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-debug-tools.development.js | -9.9% | -12.5% | 20.27 KB | 18.26 KB | 5.84 KB | 5.12 KB | NODE_DEV\n**react-debug-tools.production.min.js** | **-13.7%** | **-15.1%** | **6.23 KB** | **5.37 KB** | **2.44 KB** | **2.07 KB** | **NODE_PROD**\n\n## jest-react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \njest-react.development.js | -33.9% | -35.4% | 5.93 KB | 3.92 KB | 2.12 KB | 1.37 KB | NODE_DEV\n**jest-react.production.min.js** | **-34.2%** | **-28.5%** | **2.49 KB** | **1.64 KB** | **1.25 KB** | **918 B** | **NODE_PROD**\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 7903e43124f095bcce7bd0c8189d996312f60988\n</p>\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18185/builds/12597) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit ad810a82f1f1983fc529d3b84808b7883721f856:\n\n|Sandbox| Source |\n|--|--|\n|[floral-framework-y4fxv](https://codesandbox.io/s/floral-framework-y4fxv)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 26aa1987ce823f54ebc90b2538184fefbc16b99a...ad810a82f1f1983fc529d3b84808b7883721f856</p>\n\n\n \n## react-test-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactTestRenderer-dev.js | 0.0% | -0.0% | 552.1 KB | 552.1 KB | 116.54 KB | 116.54 KB | FB_WWW_DEV\nreact-test-renderer-shallow.development.js | -2.9% | -2.1% | 39.53 KB | 38.39 KB | 9.48 KB | 9.29 KB | UMD_DEV\n**react-test-renderer-shallow.production.min.js** | **:small_red_triangle:+0.2%** | **:small_red_triangle:+0.2%** | **12.88 KB** | **12.91 KB** | **3.93 KB** | **3.93 KB** | **UMD_PROD**\nreact-test-renderer.development.js | 0.0% | -0.0% | 550.93 KB | 550.93 KB | 114.74 KB | 114.74 KB | UMD_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **-0.0%** | **71.1 KB** | **71.1 KB** | **21.61 KB** | **21.6 KB** | **UMD_PROD**\nreact-test-renderer.development.js | 0.0% | -0.0% | 525.06 KB | 525.06 KB | 113.39 KB | 113.39 KB | NODE_DEV\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ad810a82f1f1983fc529d3b84808b7883721f856\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 26aa1987ce823f54ebc90b2538184fefbc16b99a...ad810a82f1f1983fc529d3b84808b7883721f856</p>\n\n\n \n## react-test-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactTestRenderer-dev.js | 0.0% | -0.0% | 552.11 KB | 552.11 KB | 116.54 KB | 116.54 KB | FB_WWW_DEV\nreact-test-renderer-shallow.development.js | -2.9% | -2.1% | 39.55 KB | 38.4 KB | 9.49 KB | 9.3 KB | UMD_DEV\n**react-test-renderer-shallow.production.min.js** | **:small_red_triangle:+0.2%** | **:small_red_triangle:+0.2%** | **12.9 KB** | **12.92 KB** | **3.93 KB** | **3.94 KB** | **UMD_PROD**\nreact-test-renderer.development.js | 0.0% | -0.0% | 550.96 KB | 550.96 KB | 114.75 KB | 114.75 KB | UMD_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **-0.0%** | **71.12 KB** | **71.12 KB** | **21.62 KB** | **21.62 KB** | **UMD_PROD**\nreact-test-renderer.development.js | 0.0% | -0.0% | 525.09 KB | 525.09 KB | 113.4 KB | 113.4 KB | NODE_DEV\n**react-test-renderer.production.min.js** | **0.0%** | **-0.0%** | **70.94 KB** | **70.94 KB** | **21.31 KB** | **21.3 KB** | **NODE_PROD**\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ad810a82f1f1983fc529d3b84808b7883721f856\n</p>\n" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18184/builds/12809) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 38cf7f689a35979018a4664d04491181d52e0c63:\n\n|Sandbox| Source |\n|--|--|\n|[infallible-hopper-x2yxd](https://codesandbox.io/s/infallible-hopper-x2yxd)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 38cf7f689a35979018a4664d04491181d52e0c63\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 38cf7f689a35979018a4664d04491181d52e0c63\n</p>\n", "This might not throw but this still seems like it'll yield the wrong results. The assumptions are still wrong about isFiberSuspenseAndTimedOut", "@sebmarkbage What are the correct assumptions? I can adjust accordingly." ]

[ "How would the `registerMutableSourceForHydration` API in #18771 work with libraries that create mutable sources during render (ex. [this](https://codesandbox.io/s/react-redux-usemutablesource-eyxoe) or [this](https://codesandbox.io/s/blissful-babbage-24uu3))?\r\n\r\n(posting here so as not to clutter the PR)", "This API wouldn't support a create-during-render pattern. You'd need to create the source at the module level. Otherwise a mutation might happen between the time when root hydration starts and when a particular component that reads from the source is hydrated.\r\n\r\nI don't see an alternative to this though, without e.g. tightening constraints on \"version\" to be serializable." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18182/builds/12587) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 633107cecc1b909e6da7197f5f8da857b8dbeac8:\n\n|Sandbox| Source |\n|--|--|\n|[serene-wu-jexdy](https://codesandbox.io/s/serene-wu-jexdy)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 4469700bb60ffd62caf112e47bcfa51afdd40e47...633107cecc1b909e6da7197f5f8da857b8dbeac8</p>\n\n\n \n## react-native-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \n**ReactNativeRenderer-prod.js** | **0.0%** | **0.0%** | **260.62 KB** | **260.65 KB** | **45.23 KB** | **45.23 KB** | **RN_OSS_PROD**\nReactNativeRenderer-profiling.js | 0.0% | 0.0% | 271.77 KB | 271.81 KB | 47.36 KB | 47.36 KB | RN_OSS_PROFILING\n**ReactFabric-prod.js** | **0.0%** | **:small_red_triangle:+0.1%** | **252.52 KB** | **252.61 KB** | **43.74 KB** | **43.77 KB** | **RN_OSS_PROD**\nReactFabric-profiling.js | 0.0% | 0.0% | 263.68 KB | 263.77 KB | 45.88 KB | 45.9 KB | RN_OSS_PROFILING\nReactFabric-dev.js | -0.1% | -0.1% | 616.62 KB | 616.05 KB | 133.12 KB | 132.94 KB | RN_FB_DEV\n**ReactFabric-prod.js** | **-0.1%** | **-0.2%** | **253.14 KB** | **252.77 KB** | **43.88 KB** | **43.8 KB** | **RN_FB_PROD**\nReactNativeRenderer-dev.js | 0.0% | 0.0% | 631.25 KB | 631.32 KB | 136.86 KB | 136.87 KB | RN_OSS_DEV\nReactFabric-profiling.js | -0.1% | -0.2% | 264.29 KB | 263.92 KB | 46.02 KB | 45.94 KB | RN_FB_PROFILING\nReactNativeRenderer-dev.js | -0.1% | -0.1% | 634.59 KB | 633.95 KB | 137.39 KB | 137.21 KB | RN_FB_DEV\n**ReactNativeRenderer-prod.js** | **-0.2%** | **-0.2%** | **261.2 KB** | **260.79 KB** | **45.34 KB** | **45.26 KB** | **RN_FB_PROD**\nReactNativeRenderer-profiling.js | -0.1% | -0.2% | 272.35 KB | 271.95 KB | 47.49 KB | 47.41 KB | RN_FB_PROFILING\nReactFabric-dev.js | 0.0% | 0.0% | 613.26 KB | 613.42 KB | 132.58 KB | 132.61 KB | RN_OSS_DEV\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 633107cecc1b909e6da7197f5f8da857b8dbeac8\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 633107cecc1b909e6da7197f5f8da857b8dbeac8\n</p>\n" ]

[ "`scripts/tasks/version-check.js` requires this file, yes. It's used by `scripts/release/utils.js`, which is used by `scripts/release/ci-update-package-versions` so...presumably this PR will fail?", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18181/builds/12581) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit e51d20526554333bf2d4c96f42d4d1f21e46ea9e:\n\n|Sandbox| Source |\n|--|--|\n|[eloquent-kowalevski-2dhw1](https://codesandbox.io/s/eloquent-kowalevski-2dhw1)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e51d20526554333bf2d4c96f42d4d1f21e46ea9e\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e51d20526554333bf2d4c96f42d4d1f21e46ea9e\n</p>\n", "That script doesn't work on master because `/package.json` doesn't have a version. Fixed it." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18180/builds/12574) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit c9ebd395d03075a3f696eb94715026281b1747c5:\n\n|Sandbox| Source |\n|--|--|\n|[cranky-herschel-lq6cy](https://codesandbox.io/s/cranky-herschel-lq6cy)| Configuration |\n", "I'll just take one of our own implementations then. Probably easier than figuring out the banner and saves bytes.", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 4ee592e95a5f78daed575a047d47f74f046940f3...c9ebd395d03075a3f696eb94715026281b1747c5</p>\n\n\n \n## react\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact.development.js | -1.5% | -2.2% | 103.46 KB | 101.88 KB | 25.4 KB | 24.86 KB | UMD_DEV\n**react.production.min.js** | **-4.6%** | **-4.7%** | **12.6 KB** | **12.02 KB** | **4.91 KB** | **4.68 KB** | **UMD_PROD**\nreact.profiling.min.js | -3.6% | -3.7% | 16.14 KB | 15.56 KB | 6.01 KB | 5.79 KB | UMD_PROFILING\n\n </details>\n \n\nReact: size: -4.6%, gzip: -4.7%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c9ebd395d03075a3f696eb94715026281b1747c5\n</p>\n", "\n<!--\n 0 failure: \n 1 warning: Failed to fetch b...\n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\">Warnings</th>\n </tr>\n </thead>\n <tbody><tr>\n <td>:warning:</td>\n <td>Failed to fetch build artifacts for base commit: 4ee592e95a5f78daed575a047d47f74f046940f3</td>\n </tr>\n </tbody>\n</table>\n\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c9ebd395d03075a3f696eb94715026281b1747c5\n</p>\n", "Tested fixtured and ensured that it conditionally picks up the native version." ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18179/builds/12588) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 64dc9a477997983db3d694d3184a24434c6d907b:\n\n|Sandbox| Source |\n|--|--|\n|[blazing-frost-ihcob](https://codesandbox.io/s/blazing-frost-ihcob)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 4ee592e95a5f78daed575a047d47f74f046940f3...64dc9a477997983db3d694d3184a24434c6d907b</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nReactDOM-profiling.js | 0.0% | -0.0% | 405.88 KB | 405.94 KB | 73.87 KB | 73.87 KB | FB_WWW_PROFILING\n**react-dom-server.browser.production.min.js** | **0.0%** | **0.0%** | **19.99 KB** | **19.99 KB** | **7.39 KB** | **7.39 KB** | **UMD_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.86 KB | 55.86 KB | 14.46 KB | 14.46 KB | NODE_DEV\nreact-dom.development.js | +0.1% | 0.0% | 881.76 KB | 882.42 KB | 194.35 KB | 194.42 KB | UMD_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **9.99 KB** | **9.99 KB** | **3.37 KB** | **3.37 KB** | **NODE_PROD**\n**react-dom.production.min.js** | **-0.0%** | **-0.0%** | **115.85 KB** | **115.83 KB** | **37.07 KB** | **37.06 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | -0.0% | -0.0% | 119.38 KB | 119.35 KB | 38.29 KB | 38.29 KB | UMD_PROFILING\nreact-dom.development.js | +0.1% | 0.0% | 839.2 KB | 839.77 KB | 191.97 KB | 192.05 KB | NODE_DEV\nreact-dom-server.node.development.js | 0.0% | 0.0% | 128.85 KB | 128.85 KB | 34.41 KB | 34.41 KB | NODE_DEV\n**react-dom.production.min.js** | **-0.0%** | **0.0%** | **115.93 KB** | **115.9 KB** | **36.44 KB** | **36.44 KB** | **NODE_PROD**\n**react-dom-server.node.production.min.js** | **0.0%** | **0.0%** | **20.31 KB** | **20.31 KB** | **7.51 KB** | **7.51 KB** | **NODE_PROD**\nreact-dom.profiling.min.js | -0.0% | 0.0% | 119.61 KB | 119.58 KB | 37.5 KB | 37.5 KB | NODE_PROFILING\nReactDOM-dev.js | +0.1% | +0.1% | 936.53 KB | 937.05 KB | 208.59 KB | 208.74 KB | FB_WWW_DEV\n**ReactDOM-prod.js** | **0.0%** | **-0.0%** | **394.59 KB** | **394.65 KB** | **71.72 KB** | **71.71 KB** | **FB_WWW_PROD**\nReactDOMTesting-dev.js | +0.1% | +0.1% | 895.88 KB | 896.4 KB | 200.12 KB | 200.25 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **0.0%** | **-0.0%** | **381.65 KB** | **381.71 KB** | **69.44 KB** | **69.44 KB** | **FB_WWW_PROD**\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 127.63 KB | 127.63 KB | 34.15 KB | 34.15 KB | NODE_DEV\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 53.77 KB | 53.77 KB | 14 KB | 14 KB | UMD_DEV\nReactDOMTesting-profiling.js | 0.0% | -0.0% | 381.65 KB | 381.71 KB | 69.44 KB | 69.44 KB | FB_WWW_PROFILING\n**react-dom-test-utils.production.min.js** | **0.0%** | **:small_red_triangle:+0.1%** | **10.94 KB** | **10.94 KB** | **4.16 KB** | **4.16 KB** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | 0.0% | 137.46 KB | 137.46 KB | 35.02 KB | 35.03 KB | FB_WWW_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.79 KB** | **10.79 KB** | **4.09 KB** | **4.09 KB** | **NODE_PROD**\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.9 KB | 58.9 KB | 14.7 KB | 14.7 KB | UMD_DEV\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 64dc9a477997983db3d694d3184a24434c6d907b\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 4ee592e95a5f78daed575a047d47f74f046940f3...64dc9a477997983db3d694d3184a24434c6d907b</p>\n\n\n \n## react-dom\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-dom.profiling.min.js | -0.0% | -0.0% | 123.7 KB | 123.67 KB | 38.57 KB | 38.56 KB | NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 58.91 KB | 58.91 KB | 14.7 KB | 14.7 KB | UMD_DEV\nReactDOM-dev.js | +0.1% | 0.0% | 895.08 KB | 895.6 KB | 200.12 KB | 200.19 KB | FB_WWW_DEV\n**react-dom-unstable-native-dependencies.production.min.js** | **0.0%** | **0.0%** | **10.27 KB** | **10.27 KB** | **3.5 KB** | **3.5 KB** | **UMD_PROD**\nReactDOMServer-dev.js | 0.0% | 0.0% | 136.61 KB | 136.61 KB | 34.88 KB | 34.89 KB | FB_WWW_DEV\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 53.78 KB | 53.78 KB | 14.01 KB | 14.01 KB | UMD_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **0.0%** | **10.96 KB** | **10.96 KB** | **4.17 KB** | **4.17 KB** | **UMD_PROD**\nReactDOMTesting-dev.js | +0.1% | 0.0% | 870.29 KB | 870.81 KB | 195 KB | 195.08 KB | FB_WWW_DEV\n**ReactDOMTesting-prod.js** | **0.0%** | **0.0%** | **368.76 KB** | **368.82 KB** | **67.41 KB** | **67.42 KB** | **FB_WWW_PROD**\nreact-dom-test-utils.development.js | 0.0% | 0.0% | 49.56 KB | 49.56 KB | 13.52 KB | 13.52 KB | NODE_DEV\nReactDOMTesting-profiling.js | 0.0% | 0.0% | 368.76 KB | 368.82 KB | 67.41 KB | 67.42 KB | FB_WWW_PROFILING\nreact-dom-server.node.development.js | 0.0% | 0.0% | 130.36 KB | 130.36 KB | 34.63 KB | 34.63 KB | NODE_DEV\n**react-dom-test-utils.production.min.js** | **0.0%** | **-0.0%** | **10.81 KB** | **10.81 KB** | **4.1 KB** | **4.1 KB** | **NODE_PROD**\nreact-dom.development.js | +0.1% | 0.0% | 910.44 KB | 911.11 KB | 199.28 KB | 199.35 KB | UMD_DEV\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 136.12 KB | 136.12 KB | 34.78 KB | 34.78 KB | UMD_DEV\n**react-dom.production.min.js** | **-0.0%** | **0.0%** | **119.75 KB** | **119.72 KB** | **38.22 KB** | **38.22 KB** | **UMD_PROD**\nreact-dom.profiling.min.js | -0.0% | 0.0% | 123.4 KB | 123.37 KB | 39.39 KB | 39.4 KB | UMD_PROFILING\nreact-dom.development.js | +0.1% | 0.0% | 866.69 KB | 867.27 KB | 196.87 KB | 196.93 KB | NODE_DEV\nreact-dom-server.browser.development.js | 0.0% | 0.0% | 129.14 KB | 129.14 KB | 34.37 KB | 34.37 KB | NODE_DEV\n**react-dom.production.min.js** | **-0.0%** | **0.0%** | **119.9 KB** | **119.87 KB** | **37.45 KB** | **37.45 KB** | **NODE_PROD**\n**ReactDOM-prod.js** | **0.0%** | **0.0%** | **370.74 KB** | **370.8 KB** | **67.5 KB** | **67.51 KB** | **FB_WWW_PROD**\n**ReactDOMServer-prod.js** | **0.0%** | **0.0%** | **46.68 KB** | **46.68 KB** | **10.84 KB** | **10.85 KB** | **FB_WWW_PROD**\nReactDOM-profiling.js | 0.0% | 0.0% | 381.95 KB | 382.01 KB | 69.63 KB | 69.63 KB | FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js | 0.0% | 0.0% | 55.87 KB | 55.87 KB | 14.47 KB | 14.47 KB | NODE_DEV\nreact-dom-unstable-fizz.browser.development.js | 0.0% | -0.1% | 3.35 KB | 3.35 KB | 1.27 KB | 1.27 KB | UMD_DEV\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 64dc9a477997983db3d694d3184a24434c6d907b\n</p>\n" ]

[ "I wish we had added this warning earlier. I'm sorry we didn't. It was an oversight with the introduction of Hooks. I believe this must be caused by newer code that uses Hooks, because there was already the same warning for classes much earlier so any earlier code would've already seen this warning.\r\n\r\nNote that this will likely start hard failing in future versions of React. Intentional or otherwise (we've had a lot of bugs with this pattern). So regardless, you might end up getting stuck on an old version. If it's not possible to fix it, I'd recommend pinning to an older version of React.\r\n\r\nHowever, that said, we want to help you and make it as easy as possible to fix these, including seeing if we can get help from library authors to publish fixed versions.\r\n\r\nIf you expand the little `>` arrow in the Chrome console you should also see an additional Stack trace (in addition to the Component stack in your screen shot). Can you post that too? That should show you the exact callsite that is causing a side-effect in render.", "With me this appears when i use formik \r\n\r\n\r\n", "@sebmarkbage thank you for the response. The stacktrace appearing after clicking > is ridiculous. It contains 200+ items!\r\n\r\nI was going to paste it there or give a link to pastebin but tried a different direction. I walked thru Github issues of some of used libraries and found out that one of suspects is redux-form: https://github.com/redux-form/redux-form/issues/4619. I hope that's the only library which causes the errors and I'm going to wait for a fix before upgrading React. \r\n\r\nBut still, I'd ask to not close the this issue and I propose other developers to mention here libraries which also cause these errors.", "@RodolfoSilva are you sure that it is caused by formik? If yes, can you please create an issue there and post a link to it here? I'm going to create a list of such issues at the beginning of my first message if the list is going to contain more than one item.", "This really needs to be addressed ASAP. It makes upgrading impossible. The error trace is pretty much impossible.", "Hm. I wonder if describing which line to look for in the error message would help.\r\n\r\nIn this case the first line to look for is the line after `dispatchAction`. That should be the thing that calls into React.\r\n\r\n@RodolfoSilva can you post the source of `FormItemInput.js`, if it's something you can share? That seems to be calling dispatch or setState on line 71.", "I think it is imperative that this error message be modified to include exactly which line of code is causing the error. It's almost impossible to pinpoint whether it is local code or library code that's causing the issue. External librairies ~~libraries like react-redux and react-router are most likely the culprit~~ may very well be the culprits yet it is impossible to easily determine that.", "I'm pretty sure that React-Redux is not at fault here, but agreed that the error message and component stack make it kind of hard to know what's actually going on.", "I face the same problem with Redux-form!", "I have the same problem and I'm seeing that the warning is showing the **first time** that i write in my **redux field** or when i **clear all** it", "I have that problem too, this is my component:\r\n\r\n`const [price, setPrice] = useState(0);\r\n\r\nconst updatePrice = (newPrice) => {\r\n setPrice(newPrice)\r\n}\r\n< CardContainer onPriceUpdated={updatePrice} ></ CardContainer >\r\n`\r\n\r\n\r\nSo, in this case my CardContainer component, notify to the parent component when the price is updated and the parent component renders the new prince.\r\nSo i guess React is warning me that i'm trying to update the state of a component using the function of other component.\r\nI'm new in react, so i'm not sure if this is a React pattern or is in fact a bug.\r\n\r\nIf you guys have any suggestion to solve this warning i would appreciate it``", "@l0gicgate \r\n\r\n>I think it is imperative that this error message be modified to include exactly which line of code is causing the error.\r\n\r\nThere are limits to what we can do in JavaScript. But **all the information is in the stack you see in the browser**. All you need to do is to skip the lines that are inside React.\r\n\r\nTo see the JavaScript stack, you need to **click on a small arrow next to the error message**.\r\n\r\nFor example, look at this screenshot from earlier:\r\n\r\n\r\n\r\nI appreciate it's a bit annoying to dig through the stack, but it shouldn't be that hard to skip the first several frames. The very next frame is the source of the problem. In this case, it seems like something inside the Formik library. So you can file an issue with it.", "@martinezwilmer This example is too small to help. Create a sandbox please.", "To the future commenters. I understand seeing a new warning is frustrating. But it points out legitimate issues that **are likely causing bugs in your code**. We would very much appreciate if you could refrain from expressing sarcasm and annoyance.\r\n\r\nIf you can't understand where it's coming from in the stack traces, please post screenshots or create reproducing sandboxes and we'll try to help. Most of these are probably coming from a few libraries, so the most productive thing to do is to reduce these cases and then file issues with those libraries.\r\n\r\nThank you all.", "Hard to find the precise line concerned by the warning here:\r\n\r\n@gaearon do you again have one tip about it ?\r\n\r\n\r\n", "> Hard to find the precise line concerned by the warning here:\r\n\r\nWhat makes it hard? As I noted above it’s the first line that doesn’t say “react” on the right side. In this case, it’s `connectAdvanced` from Redux. Please file an issue in React Redux so that the maintainers have a chance to look at this. ", "As I said upthread, I would be _very_ surprised if whatever's happening here is an issue with React-Redux.\r\n\r\nThat said, I'm also not even sure exactly what triggers this message in the first place. I half-get what the error message is saying, but what kind of app code pattern would actually be an example of that behavior?", "I ran into this recently and the fix was wrapping `setState` handler call sites in `useEffect`, like so: https://github.com/airbnb/lunar/commit/db08613d46ea21089ead3e7b5cfff995f15c69a7#diff-1c3bdd397b1ce5064142488877045306R56 (`onChange` and `onSubmit` use `setState` higher up the chain).\r\n\r\n@martinezwilmer Where is `onPriceUpdated` being called? Maybe try wrapping it in `useEffect`?", "The same issue seems to be happening for [`urql`](https://github.com/FormidableLabs/urql)\r\n\r\nWe are using `use-subscription` + wonka (for streams) to orchestrate our updates, however an update can come in synchronously. [Here](https://codesandbox.io/s/cranky-silence-stthw) we have already fetched the `todos` so if we click the `Open` button the result should just instantly pop up, however this seems to trigger the following error.\r\n\r\n\r\n\r\nIn our case this is intended, we can't just show `fetching: true` for a sync result, that would result in jumpy interfaces.", "This is starting to crop up more and more in third party libraries now: [`urql`](https://github.com/FormidableLabs/urql/issues/600), [Apollo](https://github.com/apollographql/react-apollo/issues/3863).\r\n\r\nI ran into this and for several hours I assumed the problem was in my code. The condensed stacktrace points at my components, and it's not unusual for me to see third party libraries in the expanded stacktrace when I _did_ explicitly trigger an error. From my (albeit limited) research into this particular warning, it seems that most developers are not causing this issue themselves, but rather depending on code that does. Usually it's good practice to assume it isn't a bug upstream but when it is an upstream bug, wasting time tracking down a problem in your code that doesn't exist is rather frustrating. Is there anything React can do to help an average user determine if it was code they wrote, or code they depend upon that caused the issue?\r\n\r\nOne thing I note from the Apollo issue is:\r\n>The warning's stacktrace is showing the component that initialed the changes, not the one that gets re-renderd [sic] by those changes\r\n\r\nIf this is correct, can React give more information here? Perhaps telling us both the initiating component and the components that it caused to be updated?", "Like @hugo , I encountered this when testing [a new Ionic application](https://ionicframework.com/docs/react):\r\n1. `npx ionic start demo sidemenu --type=react`\r\n2. `react-scripts test`\r\n\r\nIndeed, the cause is buried in the middle and bottom of the stack trace.\r\n\r\n```\r\nconsole.error node_modules/react-dom/cjs/react-dom.development.js:88\r\n Warning: Cannot update a component from inside the function body of a different component.\r\n in Route (at App.tsx:37)\r\n in View (created by StackManagerInner)\r\n in ViewTransitionManager (created by StackManagerInner)\r\n in ion-router-outlet (created by IonRouterOutlet)\r\n in IonRouterOutlet (created by ForwardRef(IonRouterOutlet))\r\n in ForwardRef(IonRouterOutlet) (created by StackManagerInner)\r\n in StackManagerInner (created by Context.Consumer)\r\n in Unknown (created by Component)\r\n in Component (created by ForwardRef(IonRouterOutlet))\r\n in ForwardRef(IonRouterOutlet) (at App.tsx:36)\r\n in ion-split-pane (created by IonSplitPane)\r\n in IonSplitPane (created by ForwardRef(IonSplitPane))\r\n in ForwardRef(IonSplitPane) (at App.tsx:34)\r\n in NavManager (created by RouteManager)\r\n in RouteManager (created by Context.Consumer)\r\n in RouteManager (created by IonReactRouter)\r\n in Router (created by BrowserRouter)\r\n in BrowserRouter (created by IonReactRouter)\r\n in IonReactRouter (at App.tsx:33)\r\n in ion-app (created by IonApp)\r\n in IonApp (created by ForwardRef(IonApp))\r\n in ForwardRef(IonApp) (at App.tsx:32)\r\n in App (at App.test.tsx:6)\r\n```\r\n\r\nThis issue was the closest I could find regarding this problem.", "We found a specific pattern that causes this issue with mobx over in https://github.com/mobxjs/mobx-react/issues/846", "@sebmarkbage I can no longer reproduce this problem. We have update some libraries and the problems over.", "@jgoux we seem to face the same problem @Clovis ^^ Spotted", "I started getting this error after the updating react to `react 16.13.0`. The issue is pretty clear since one of my components is updating another after a specific action is done. However, not sure why would this throw a warning. Any suggestion on how to get around this?", "@gaearon thanks for the details on how to debug from the stack, I personally wouldn't have been able to figure out where this error was coming from if you had not given that example. 🙏 ", "Not sure if my issue is related however, I'm attempting to update the state of my form component but whenever I try to add an onChange handler, it keeps giving me this error. Mind you, I'm using react-jsonschema-form and imported the Form component and I'm using it's onChange property to update the state.. ", "For me, this is the pattern that causes the issue.\r\n\r\n\r\n\r\nThere may be a way around this. But the console log did point me straight to line 385\r\n", "I'm new to react but I had code like this: \r\n\r\n```jsx\r\nimport React, { useState } from \"react\";\r\n\r\nfunction Home() {\r\n const [mobileNavOpen, setMobileNavOpen] = useState(false);\r\n return (\r\n <div>\r\n <button\r\n onClick={(): void => setMobileNavOpen(true)}\r\n type=\"button\"\r\n className=\"btn\"\r\n >\r\n X\r\n </button>\r\n {mobileNavOpen && <MobileNav setMobileNavOpen={setMobileNavOpen}/>}\r\n </div>\r\n );\r\n}\r\n\r\nfunction MobileNav() {\r\n return (\r\n <div>\r\n <button\r\n onClick={setMobileNavOpen(false)} //problem here\r\n type=\"button\"\r\n className=\"btn\"\r\n >\r\n X\r\n </button>\r\n </div>\r\n );\r\n}\r\n\r\nexport default Home;\r\n```\r\n\r\nWhich resulted in: ```Cannot update a component from inside the function body of a different component.```\r\n\r\nAll I had to do is add an arrow function to setMobileNavOpen in MobileNav like so:\r\n\r\n```jsx\r\nimport React, { useState } from \"react\";\r\n\r\nfunction Home() {\r\n const [mobileNavOpen, setMobileNavOpen] = useState(false);\r\n return (\r\n <div>\r\n <button\r\n onClick={(): void => setMobileNavOpen(true)}\r\n type=\"button\"\r\n className=\"btn\"\r\n >\r\n X\r\n </button>\r\n {mobileNavOpen && <MobileNav setMobileNavOpen={setMobileNavOpen}/>}\r\n </div>\r\n );\r\n}\r\n\r\nfunction MobileNav() {\r\n return (\r\n <div>\r\n <button\r\n onClick={(): void => setMobileNavOpen(false)} //fixes problem\r\n type=\"button\"\r\n className=\"btn\"\r\n >\r\n X\r\n </button>\r\n </div>\r\n );\r\n}\r\n\r\nexport default Home;\r\n```\r\n\r\nAnd that fixes the problem, hope this helps someone!", "> I'm new to react but I had code like this:\r\n> \r\n> ```js-jsx\r\n> import React, { useState } from \"react\";\r\n> \r\n> function Home() {\r\n> const [mobileNavOpen, setMobileNavOpen] = useState(false);\r\n> return (\r\n> <div>\r\n> <button\r\n> onClick={(): void => setMobileNavOpen(true)}\r\n> type=\"button\"\r\n> className=\"btn\"\r\n> >\r\n> X\r\n> </button>\r\n> {mobileNavOpen && <MobileNav setMobileNavOpen={setMobileNavOpen}/>}\r\n> </div>\r\n> );\r\n> }\r\n> \r\n> function MobileNav() {\r\n> return (\r\n> <div>\r\n> <button\r\n> onClick={setMobileNavOpen(false)} //problem here\r\n> type=\"button\"\r\n> className=\"btn\"\r\n> >\r\n> X\r\n> </button>\r\n> </div>\r\n> );\r\n> }\r\n> \r\n> export default Home;\r\n> ```\r\n> \r\n> Which resulted in: `Cannot update a component from inside the function body of a different component.`\r\n> \r\n> All I had to do is add an arrow function to setMobileNavOpen in MobileNav like so:\r\n> \r\n> ```js-jsx\r\n> import React, { useState } from \"react\";\r\n> \r\n> function Home() {\r\n> const [mobileNavOpen, setMobileNavOpen] = useState(false);\r\n> return (\r\n> <div>\r\n> <button\r\n> onClick={(): void => setMobileNavOpen(true)}\r\n> type=\"button\"\r\n> className=\"btn\"\r\n> >\r\n> X\r\n> </button>\r\n> {mobileNavOpen && <MobileNav setMobileNavOpen={setMobileNavOpen}/>}\r\n> </div>\r\n> );\r\n> }\r\n> \r\n> function MobileNav() {\r\n> return (\r\n> <div>\r\n> <button\r\n> onClick={(): void => setMobileNavOpen(false)} //fixes problem\r\n> type=\"button\"\r\n> className=\"btn\"\r\n> >\r\n> X\r\n> </button>\r\n> </div>\r\n> );\r\n> }\r\n> \r\n> export default Home;\r\n> ```\r\n> \r\n> And that fixes the problem, hope this helps someone!\r\n\r\nYour example is actually one of the early mistakes people make with react. I'm not sure it's exactly the same issue that's being discussed here. Your line here: `onClick={setMobileNavOpen(false)` is calling the function during the button tender, not on click. That's why wrapping it in a arrow function fixes it. " ]

[ "I just assign the latest setter to fnWrapper.setCount in every render period but I don't know why it does's work as I imagine.", "What you're doing in the hook above - setting properties on an external object `fnWrapper` during render, or mutating a ref like `f` during render - is a **side effect** and [**is not safe to do**](https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects). Side effects belong inside of an effect hook like [`useEffect`](https://reactjs.org/docs/hooks-reference.html#useeffect).\r\n\r\n[As I mentioned on the previous issue about this](https://github.com/facebook/react/issues/16519#issuecomment-538059486):\r\n> DevTools shallowly re-renders components that use hooks in order to build up the map of hook-to-value to show in the selected properties panel. ([Read more about this here if you're interested.](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md#inspecting-hooks))\r\n\r\n> When it does this re-rendering, it temporarily overrides the React's built-in hooks with [a version that collects this metadata](https://github.com/facebook/react/blob/master/packages/react-debug-tools/src/ReactDebugHooks.js). In your case, since you're mutating a prototype function every render, the more recent render (by DevTools) causes you to override it with the injected no-op value so that future calls don't actually update state.\r\n\r\n", "@bvaughn documentation clearly says:\r\n\r\n> React guarantees that setState function identity is stable and won’t change on re-renders.\r\n\r\nAnd it seems that Dev Tools break this guarantee\r\n\r\n", "I think that's a misunderstanding of the quoted documentation. That quote means that the `setState` function is stable between renders, so it won't break e.g. `React.pure` memoization and it won't cause e.g. `useMemo` hooks to be invalidated. In other words, the documentation is a comment on the general performance characteristics.\r\n\r\nDevTools shallowly re-renders a component [as mentioned before on this issue and the previous one](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md#inspecting-hooks). It does not run any effects callbacks, so no side effects will be run. It does not re-run `useMemo` or `useCallback` functions, so a temporary change in the dispatch won't impact them.\r\n\r\nIf you're using a non-hooks based memoization (e.g. `memoize-one`) it *would* invalidate it, but I would argue this is okay for a few reasons:\r\n* Using developer tools (whether React DevTools or e.g. browser's built-in profiling tools) typically adds some additional overhead. This is acceptable because the scope is limited and end users won't experience it.\r\n* So long as you don't break the rules of React and have side effects in render, what DevTools does should, at worst, cause a little extra CPU work. It won't be persisted anywhere. (DevTools rendering is shallow, so any temporarily invalidated calculations won't be passed further down the tree.)\r\n\r\nDevTools *could* pass the actual `setState` function during the shallow render, but if the component being rendered called it- it would schedule actual work with React and cause a potentially observable change in application behavior. DevTool's current approach is unobservable to the larger app, **provided you don't have side effects** which would [already be problematic for other reasons, not counting DevTools](https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects).", "Documentation explicitly allows assigning to ref.current for lazy initialisation which makes it possible to observe invalid setState", "> Documentation explicitly allows assigning to ref.current for lazy initialisation which makes it possible to observe invalid setState\r\n\r\nNo, it does not- because the ref will **always** already be assigned in that case. (DevTools will **never** render a component for the first time.)", "Yes, that’s probably the case in practice, but it is never said in the docs that you MUST assign ref value during the first render. In theory it is possible that is for some reason assigned during DevTools render. That would probably require reading some external mutable value, which is not recommended, but people do it all the time", "> but it is never said in the docs that you MUST assign ref value during the first render\r\n\r\nMaybe. The docs only suggest writing to the ref during render for lazy initialization. I would argue that there's no reason to store a stable function like `dispatch`/`setState` in a ref to begin with though.\r\n\r\nReading from an external, mutable value is also an impure/unsafe thing to do. I'm not sure what point you're making when you say that \"people do it all the time\".", "The point is that people (myself included) often break React rules thinking that they know what they are doing. \r\n\r\nSide effects in render is a good example. You are clearly discouraged to do so, but React says that setState is guaranteed to not changed, so you would assume that is ok to do that. Except it is not, and figuring out why can be difficult. The fact that DevTools disable console to hide this render makes it even more confusing. \r\n\r\nAll I’m saying that docs should mention that fact that you might observe alternative setState functions if you break React rules, or something like this.", "> The point is that people (myself included) often break React rules thinking that they know what they are doing.\r\n\r\n**Don't break the rules. They exist for a reason.**\r\n\r\nWe (React team) do spend a lot of time trying to highlight why breaking the rules is bad- (including responding to GitHub issues like this) but it's not realistic for us to highlight **all** of the things can go wrong.\r\n\r\nThe docs are open source. If you think this is a case where the warnings could be improved, please feel free to submit a PR: http://github.com/reactjs/reactjs.org\r\n\r\nI think this discussion has probably ran full course now :smile: I'm going to bow out." ]

[ "Never do this. There is no good reason to do this, but it is very hard to make `exhaustive-deps` support this pattern", "> Never do this. There is no good reason to do this, but it is very hard to make `exhaustive-deps` support this pattern\r\n\r\nThis is good point.\r\nFor effect reusage it would be better to use custom hooks.", "> the code is coupled to the component and is not really reusable \r\n\r\nThis shouldn't be matter. You can have your hook unexported in the same file, with a meaningful name.", "_Sorry for deleting the previous comment, wrong account._\r\n\r\nThe effects weren't meant to be reused, the goal was to name them, in order to avoid having to read the impl to understand what they do.\r\n\r\nI preffered this approach over custom hooks because the code is coupled to the component and is not really reusable.", "> > the code is coupled to the component and is not really reusable\r\n> \r\n> This shouldn't be matter. You can have your hook unexported in the same file, with a meaningful name.\r\n\r\nI guess that could be the solution although it feels weird reading `useFoo()` without it being an app-wide hook.", "Consider this: you often extract some code into components, although it is used only in one place. You do this to make it easier to read and reason about code, not for reuse. The same applies to hooks.", "This is a known bug https://github.com/facebook/react/issues?q=is%3Aopen+is%3Aissue+label%3A%22Component%3A+ESLint+Rules%22\r\n\r\nA fix would be welcome!", "oops I meant https://github.com/facebook/react/issues/16573" ]

[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18165/builds/12485) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 1bcfdefa29a8742325feb5765666036abc4a95b6:\n\n|Sandbox| Source |\n|--|--|\n|[ecstatic-curran-i145q](https://codesandbox.io/s/ecstatic-curran-i145q)| Configuration |\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 739f20beda56a28a9212e3478571c866babee118...1bcfdefa29a8742325feb5765666036abc4a95b6</p>\n\n\n \n## react-flight-dom-webpack\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-flight-dom-webpack-server.browser.development.js | -3.0% | -4.1% | 8.56 KB | 8.31 KB | 2.8 KB | 2.68 KB | NODE_DEV\n**react-flight-dom-webpack-server.browser.production.min.js** | **-1.0%** | **-1.7%** | **2.61 KB** | **2.59 KB** | **1.24 KB** | **1.22 KB** | **NODE_PROD**\nreact-flight-dom-webpack.development.js | -2.6% | -4.0% | 8.78 KB | 8.55 KB | 2.46 KB | 2.36 KB | UMD_DEV\n**react-flight-dom-webpack.production.min.js** | **-0.4%** | **-0.4%** | **2.86 KB** | **2.85 KB** | **1.32 KB** | **1.32 KB** | **UMD_PROD**\nreact-flight-dom-webpack.development.js | -2.9% | -5.1% | 8.05 KB | 7.81 KB | 2.38 KB | 2.26 KB | NODE_DEV\n**react-flight-dom-webpack.production.min.js** | **-0.4%** | **-1.8%** | **2.68 KB** | **2.67 KB** | **1.25 KB** | **1.23 KB** | **NODE_PROD**\nreact-flight-dom-webpack-server.node.development.js | -2.6% | -3.6% | 9.49 KB | 9.25 KB | 3.06 KB | 2.95 KB | NODE_DEV\n**react-flight-dom-webpack-server.node.production.min.js** | **-1.0%** | **-1.9%** | **2.77 KB** | **2.75 KB** | **1.26 KB** | **1.24 KB** | **NODE_PROD**\nreact-flight-dom-webpack-server.browser.development.js | -2.6% | -3.1% | 9.37 KB | 9.13 KB | 2.9 KB | 2.8 KB | UMD_DEV\n**react-flight-dom-webpack-server.browser.production.min.js** | **-0.5%** | **-0.8%** | **2.82 KB** | **2.81 KB** | **1.32 KB** | **1.31 KB** | **UMD_PROD**\n\n## react-noop-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \n**react-noop-renderer-flight-client.production.min.js** | **-4.5%** | **-5.5%** | **537 B** | **513 B** | **398 B** | **376 B** | **NODE_PROD**\nreact-noop-renderer.development.js | +9.0% | +4.8% | 26.87 KB | 29.28 KB | 5.5 KB | 5.76 KB | NODE_DEV\n**react-noop-renderer.production.min.js** | **:small_red_triangle:+11.3%** | **:small_red_triangle:+8.9%** | **10.78 KB** | **12 KB** | **3.28 KB** | **3.57 KB** | **NODE_PROD**\nreact-noop-renderer-server.development.js | -11.8% | -12.6% | 1.81 KB | 1.59 KB | 854 B | 746 B | NODE_DEV\n**react-noop-renderer-server.production.min.js** | **-2.8%** | **-3.9%** | **864 B** | **840 B** | **488 B** | **469 B** | **NODE_PROD**\nreact-noop-renderer-flight-client.development.js | -16.7% | -15.2% | 1.42 KB | 1.18 KB | 723 B | 613 B | NODE_DEV\nreact-noop-renderer-persistent.development.js | +8.9% | +4.8% | 26.92 KB | 29.33 KB | 5.51 KB | 5.77 KB | NODE_DEV\n**react-noop-renderer-persistent.production.min.js** | **:small_red_triangle:+11.3%** | **:small_red_triangle:+8.8%** | **10.8 KB** | **12.02 KB** | **3.29 KB** | **3.58 KB** | **NODE_PROD**\nreact-noop-renderer-flight-server.development.js | -12.3% | -11.6% | 1.98 KB | 1.73 KB | 905 B | 800 B | NODE_DEV\n**react-noop-renderer-flight-server.production.min.js** | **-2.5%** | **-3.3%** | **970 B** | **946 B** | **541 B** | **523 B** | **NODE_PROD**\n\n## react-reconciler\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-reconciler.development.js | -0.1% | -0.2% | 553.49 KB | 553.15 KB | 116.95 KB | 116.76 KB | NODE_DEV\nreact-reconciler-reflection.development.js | 0.0% | -0.1% | 16 KB | 16 KB | 4.89 KB | 4.89 KB | NODE_DEV\n**react-reconciler.production.min.js** | **:small_red_triangle:+0.1%** | **-0.1%** | **73.47 KB** | **73.54 KB** | **21.72 KB** | **21.69 KB** | **NODE_PROD**\n**react-reconciler-reflection.production.min.js** | **0.0%** | **-0.2%** | **2.8 KB** | **2.8 KB** | **1.2 KB** | **1.2 KB** | **NODE_PROD**\nreact-reconciler-persistent.development.js | -0.1% | -0.2% | 552.17 KB | 551.79 KB | 116.81 KB | 116.6 KB | NODE_DEV\n**react-reconciler-persistent.production.min.js** | **:small_red_triangle:+0.1%** | **-0.1%** | **73.48 KB** | **73.55 KB** | **21.73 KB** | **21.7 KB** | **NODE_PROD**\n\n## react-server\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-server.development.js | -7.8% | -10.8% | 3.99 KB | 3.68 KB | 1.38 KB | 1.23 KB | NODE_DEV\n**react-server.production.min.js** | **-6.7%** | **-6.2%** | **1.22 KB** | **1.14 KB** | **675 B** | **633 B** | **NODE_PROD**\nreact-server-flight.development.js | -3.2% | -4.8% | 9.45 KB | 9.15 KB | 2.92 KB | 2.78 KB | NODE_DEV\n**react-server-flight.production.min.js** | **-3.5%** | **-4.4%** | **2.89 KB** | **2.78 KB** | **1.31 KB** | **1.25 KB** | **NODE_PROD**\n\n## react-debug-tools\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-debug-tools.development.js | -1.1% | -1.8% | 20.49 KB | 20.27 KB | 5.95 KB | 5.84 KB | NODE_DEV\n**react-debug-tools.production.min.js** | **-0.5%** | **-1.0%** | **6.26 KB** | **6.23 KB** | **2.46 KB** | **2.44 KB** | **NODE_PROD**\n\n## react-flight\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \n**react-flight.production.min.js** | **-2.3%** | **-2.8%** | **2.5 KB** | **2.45 KB** | **1.18 KB** | **1.15 KB** | **NODE_PROD**\nreact-flight.development.js | -3.9% | -6.1% | 7.45 KB | 7.16 KB | 2.38 KB | 2.23 KB | NODE_DEV\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1bcfdefa29a8742325feb5765666036abc4a95b6\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 739f20beda56a28a9212e3478571c866babee118...1bcfdefa29a8742325feb5765666036abc4a95b6</p>\n\n\n \n## react-flight-dom-webpack\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-flight-dom-webpack-server.node.development.js | -2.6% | -3.5% | 9.5 KB | 9.26 KB | 3.07 KB | 2.96 KB | NODE_DEV\n**react-flight-dom-webpack-server.node.production.min.js** | **-1.0%** | **-1.8%** | **2.79 KB** | **2.76 KB** | **1.27 KB** | **1.25 KB** | **NODE_PROD**\nreact-flight-dom-webpack-server.browser.development.js | -2.6% | -3.1% | 9.38 KB | 9.14 KB | 2.9 KB | 2.81 KB | UMD_DEV\n**react-flight-dom-webpack-server.browser.production.min.js** | **-0.5%** | **-0.8%** | **2.83 KB** | **2.82 KB** | **1.33 KB** | **1.32 KB** | **UMD_PROD**\nreact-flight-dom-webpack-server.browser.development.js | -3.0% | -4.2% | 8.58 KB | 8.32 KB | 2.81 KB | 2.69 KB | NODE_DEV\n**react-flight-dom-webpack-server.browser.production.min.js** | **-1.0%** | **-1.6%** | **2.63 KB** | **2.6 KB** | **1.25 KB** | **1.23 KB** | **NODE_PROD**\nreact-flight-dom-webpack.development.js | -2.6% | -4.0% | 8.79 KB | 8.57 KB | 2.47 KB | 2.37 KB | UMD_DEV\n**react-flight-dom-webpack.production.min.js** | **-0.4%** | **-0.4%** | **2.87 KB** | **2.86 KB** | **1.33 KB** | **1.33 KB** | **UMD_PROD**\nreact-flight-dom-webpack.development.js | -2.9% | -5.1% | 8.06 KB | 7.82 KB | 2.39 KB | 2.26 KB | NODE_DEV\n**react-flight-dom-webpack.production.min.js** | **-0.4%** | **-1.9%** | **2.69 KB** | **2.68 KB** | **1.26 KB** | **1.24 KB** | **NODE_PROD**\n\n## react-noop-renderer\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-noop-renderer-flight-server.development.js | -12.2% | -11.5% | 1.99 KB | 1.75 KB | 915 B | 810 B | NODE_DEV\n**react-noop-renderer-flight-server.production.min.js** | **-2.4%** | **-3.3%** | **983 B** | **959 B** | **551 B** | **533 B** | **NODE_PROD**\nreact-noop-renderer-server.development.js | -11.8% | -12.5% | 1.82 KB | 1.61 KB | 862 B | 754 B | NODE_DEV\n**react-noop-renderer-server.production.min.js** | **-2.7%** | **-3.8%** | **877 B** | **853 B** | **497 B** | **478 B** | **NODE_PROD**\nreact-noop-renderer-persistent.development.js | +8.9% | +4.7% | 26.94 KB | 29.34 KB | 5.52 KB | 5.78 KB | NODE_DEV\n**react-noop-renderer-persistent.production.min.js** | **:small_red_triangle:+11.3%** | **:small_red_triangle:+8.8%** | **10.81 KB** | **12.04 KB** | **3.3 KB** | **3.59 KB** | **NODE_PROD**\nreact-noop-renderer.development.js | +9.0% | +4.8% | 26.88 KB | 29.3 KB | 5.5 KB | 5.77 KB | NODE_DEV\nreact-noop-renderer-flight-client.development.js | -16.5% | -15.0% | 1.43 KB | 1.2 KB | 732 B | 622 B | NODE_DEV\n**react-noop-renderer.production.min.js** | **:small_red_triangle:+11.3%** | **:small_red_triangle:+8.9%** | **10.79 KB** | **12.01 KB** | **3.29 KB** | **3.58 KB** | **NODE_PROD**\n**react-noop-renderer-flight-client.production.min.js** | **-4.4%** | **-5.4%** | **550 B** | **526 B** | **406 B** | **384 B** | **NODE_PROD**\n\n## react-server\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-server.development.js | -7.8% | -10.7% | 4 KB | 3.69 KB | 1.38 KB | 1.24 KB | NODE_DEV\n**react-server.production.min.js** | **-6.6%** | **-6.0%** | **1.23 KB** | **1.15 KB** | **682 B** | **641 B** | **NODE_PROD**\nreact-server-flight.development.js | -3.2% | -4.8% | 9.47 KB | 9.17 KB | 2.93 KB | 2.79 KB | NODE_DEV\n**react-server-flight.production.min.js** | **-2.8%** | **-3.3%** | **2.88 KB** | **2.8 KB** | **1.3 KB** | **1.26 KB** | **NODE_PROD**\n\n## react-reconciler\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-reconciler-persistent.development.js | -0.1% | -0.2% | 552.18 KB | 551.81 KB | 116.82 KB | 116.61 KB | NODE_DEV\nreact-reconciler-reflection.development.js | 0.0% | -0.1% | 16.01 KB | 16.01 KB | 4.9 KB | 4.89 KB | NODE_DEV\n**react-reconciler-persistent.production.min.js** | **:small_red_triangle:+0.1%** | **-0.1%** | **73.5 KB** | **73.56 KB** | **21.73 KB** | **21.71 KB** | **NODE_PROD**\n**react-reconciler-reflection.production.min.js** | **0.0%** | **-0.2%** | **2.81 KB** | **2.81 KB** | **1.21 KB** | **1.21 KB** | **NODE_PROD**\nreact-reconciler.development.js | -0.1% | -0.2% | 574.25 KB | 573.91 KB | 120.84 KB | 120.65 KB | NODE_DEV\n**react-reconciler.production.min.js** | **:small_red_triangle:+0.1%** | **-0.2%** | **76.25 KB** | **76.31 KB** | **22.4 KB** | **22.36 KB** | **NODE_PROD**\n\n## react-flight\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-flight.development.js | -3.9% | -6.0% | 7.46 KB | 7.17 KB | 2.38 KB | 2.24 KB | NODE_DEV\n**react-flight.production.min.js** | **-2.3%** | **-2.8%** | **2.52 KB** | **2.46 KB** | **1.19 KB** | **1.16 KB** | **NODE_PROD**\n\n## react-debug-tools\nFile | Filesize Diff | Gzip Diff | Prev Size | Current Size | Prev Gzip | Current Gzip | ENV\n --- | --- | --- | --- | --- | --- | --- | --- \nreact-debug-tools.development.js | -1.1% | -1.8% | 20.5 KB | 20.28 KB | 5.96 KB | 5.85 KB | NODE_DEV\n**react-debug-tools.production.min.js** | **-0.5%** | **-0.9%** | **6.27 KB** | **6.24 KB** | **2.47 KB** | **2.45 KB** | **NODE_PROD**\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1bcfdefa29a8742325feb5765666036abc4a95b6\n</p>\n" ]