Datasets:

SamSaver
/

react-issues

Dataset card Viewer Files Files and versions Community

Split (1)

train · 10k rows

url stringlengths 56 56	repository_url stringclasses 1 value	labels_url stringlengths 70 70	comments_url stringlengths 65 65	events_url stringlengths 63 63	html_url stringlengths 44 46	id int64 570M 2.28B	node_id stringlengths 18 32	number int64 18.1k 29k	title stringlengths 1 570	user stringlengths 854 1.31k	labels stringclasses 293 values	state stringclasses 2 values	locked bool 2 classes	assignee stringclasses 263 values	assignees stringclasses 287 values	milestone float64	comments sequencelengths 0 30	created_at stringlengths 19 19	updated_at stringlengths 19 19	closed_at stringlengths 19 19 ⌀	author_association stringclasses 4 values	active_lock_reason stringclasses 3 values	draft bool 2 classes	pull_request stringlengths 277 316 ⌀	body stringlengths 1 43.2k ⌀	reactions stringlengths 189 198	timeline_url stringlengths 65 65	performed_via_github_app float64	state_reason stringclasses 3 values	is_pull_request bool 2 classes
https://api.github.com/repos/facebook/react/issues/18335	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18335/labels{/name}	https://api.github.com/repos/facebook/react/issues/18335/comments	https://api.github.com/repos/facebook/react/issues/18335/events	https://github.com/facebook/react/pull/18335	583,639,981	MDExOlB1bGxSZXF1ZXN0MzkwMzYyMTAw	18,335	README.md	{'login': 'YorkLYChang', 'id': 62240855, 'node_id': 'MDQ6VXNlcjYyMjQwODU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/62240855?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/YorkLYChang', 'html_url': 'https://github.com/YorkLYChang', 'followers_url': 'https://api.github.com/users/YorkLYChang/followers', 'following_url': 'https://api.github.com/users/YorkLYChang/following{/other_user}', 'gists_url': 'https://api.github.com/users/YorkLYChang/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/YorkLYChang/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/YorkLYChang/subscriptions', 'organizations_url': 'https://api.github.com/users/YorkLYChang/orgs', 'repos_url': 'https://api.github.com/users/YorkLYChang/repos', 'events_url': 'https://api.github.com/users/YorkLYChang/events{/privacy}', 'received_events_url': 'https://api.github.com/users/YorkLYChang/received_events', 'type': 'User', 'site_admin': False}	[]	closed	false	null	[]	null	[ "Hi @YorkLYChang! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nIf you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Freact%20%2318335). Thanks!", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18335/builds/15332) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit a99c9ebe8799e88676d3184cf381683a33ba86a8:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[fragrant-feather-iq246](https://codesandbox.io/s/fragrant-feather-iq246)\| Configuration \|\n", "> ## Summary\r\n> ## Test Plan\r\n\r\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a99c9ebe8799e88676d3184cf381683a33ba86a8\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a99c9ebe8799e88676d3184cf381683a33ba86a8\n</p>\n" ]	2020-03-18 10:51:47	2020-03-18 10:58:33	2020-03-18 10:55:59	NONE	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18335', 'html_url': 'https://github.com/facebook/react/pull/18335', 'diff_url': 'https://github.com/facebook/react/pull/18335.diff', 'patch_url': 'https://github.com/facebook/react/pull/18335.patch', 'merged_at': None}	<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> ## Test Plan <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->	{'url': 'https://api.github.com/repos/facebook/react/issues/18335/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18335/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18334	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18334/labels{/name}	https://api.github.com/repos/facebook/react/issues/18334/comments	https://api.github.com/repos/facebook/react/issues/18334/events	https://github.com/facebook/react/pull/18334	583,418,437	MDExOlB1bGxSZXF1ZXN0MzkwMTc3NjQ3	18,334	[Flight] Wire up bundler configs	{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18334/builds/15427) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit def1f72bd2c4989e867af9c892a53d959ee855b2:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[quizzical-meitner-g1mti](https://codesandbox.io/s/quizzical-meitner-g1mti)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against def1f72bd2c4989e867af9c892a53d959ee855b2\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against def1f72bd2c4989e867af9c892a53d959ee855b2\n</p>\n" ]	2020-03-18 02:28:55	2020-03-19 15:50:33	2020-03-18 19:18:35	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18334', 'html_url': 'https://github.com/facebook/react/pull/18334', 'diff_url': 'https://github.com/facebook/react/pull/18334.diff', 'patch_url': 'https://github.com/facebook/react/pull/18334.patch', 'merged_at': datetime.datetime(2020, 3, 18, 19, 18, 35)}	This allows different Flight server and clients to have different configs depending on bundler to serialize and resolve modules. I'll use these in a follow up for Blocks.	{'url': 'https://api.github.com/repos/facebook/react/issues/18334/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18334/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18333	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18333/labels{/name}	https://api.github.com/repos/facebook/react/issues/18333/comments	https://api.github.com/repos/facebook/react/issues/18333/events	https://github.com/facebook/react/pull/18333	583,409,382	MDExOlB1bGxSZXF1ZXN0MzkwMTcwNTA1	18,333	Don't use EventListener Fork in Modern WWW Builds	{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18333/builds/15276) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit fdf0b236000ae8919741063e625c49a6c0053612:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[zealous-pond-bwb38](https://codesandbox.io/s/zealous-pond-bwb38)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: aae83a4b9a0cfd75f5d5e7ee776c5e92e55cc2c3...fdf0b236000ae8919741063e625c49a6c0053612</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 136.74 KB \| 136.74 KB \| 34.96 KB \| 34.96 KB \| UMD_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.46 KB \| 126.46 KB \| 39.55 KB \| 39.55 KB \| NODE_PROFILING\nReactDOM-dev.js \| -0.1% \| -0.0% \| 937.82 KB \| 937.35 KB \| 208.61 KB \| 208.52 KB \| FB_WWW_DEV\nReactDOM-prod.js \| -0.2% \| -0.2% \| 384.33 KB \| 383.69 KB \| 69.92 KB \| 69.82 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| -0.2% \| -0.1% \| 401.92 KB \| 401.28 KB \| 72.95 KB \| 72.85 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1 KB \| 1 KB \| 610 B \| 609 B \| NODE_PROD\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 12.27 KB \| 12.27 KB \| 4.56 KB \| 4.56 KB \| UMD_PROD\nReactDOMTesting-dev.js \| -0.1% \| -0.1% \| 892.77 KB \| 892.29 KB \| 199.52 KB \| 199.42 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| -0.2% \| -0.2% \| 377.57 KB \| 376.98 KB \| 69.03 KB \| 68.92 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 54.78 KB \| 54.78 KB \| 15.08 KB \| 15.08 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| -0.2% \| -0.2% \| 377.57 KB \| 376.98 KB \| 69.03 KB \| 68.92 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 129.73 KB \| 129.73 KB \| 34.53 KB \| 34.53 KB \| NODE_DEV\nreact-dom.development.js \| -0.0% \| -0.0% \| 933.83 KB \| 933.76 KB \| 204 KB \| 203.95 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 57.71 KB \| 57.71 KB \| 14.36 KB \| 14.36 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.33 KB \| 122.33 KB \| 39.1 KB \| 39.1 KB \| UMD_PROD\nReactDOMForked-dev.js \| -0.1% \| -0.0% \| 937.82 KB \| 937.35 KB \| 208.61 KB \| 208.52 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 137.51 KB \| 137.51 KB \| 35.13 KB \| 35.13 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.16 KB \| 126.16 KB \| 40.36 KB \| 40.36 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| -0.2% \| -0.2% \| 384.33 KB \| 383.69 KB \| 69.92 KB \| 69.82 KB \| FB_WWW_PROD\nreact-dom.development.js \| -0.0% \| -0.0% \| 888.98 KB \| 888.91 KB \| 201.5 KB \| 201.46 KB \| NODE_DEV\nReactDOMForked-profiling.js \| -0.2% \| -0.1% \| 401.92 KB \| 401.28 KB \| 72.95 KB \| 72.85 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.48 KB \| 122.48 KB \| 38.27 KB \| 38.27 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fdf0b236000ae8919741063e625c49a6c0053612\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: aae83a4b9a0cfd75f5d5e7ee776c5e92e55cc2c3...fdf0b236000ae8919741063e625c49a6c0053612</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 59.3 KB \| 59.3 KB \| 15.68 KB \| 15.68 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| -0.2% \| -0.2% \| 390.99 KB \| 390.24 KB \| 71.19 KB \| 71.05 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 19.88 KB \| 19.88 KB \| 7.37 KB \| 7.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| 0.0% \| 129.44 KB \| 129.44 KB \| 34.56 KB \| 34.56 KB \| NODE_DEV\nReactDOMForked-dev.js \| -0.0% \| -0.0% \| 983.7 KB \| 983.24 KB \| 218.53 KB \| 218.49 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| -0.2% \| -0.2% \| 410.75 KB \| 409.85 KB \| 74.67 KB \| 74.51 KB \| FB_WWW_PROD\nreact-dom.development.js \| -0.0% \| -0.0% \| 903.34 KB \| 903.27 KB \| 198.72 KB \| 198.67 KB \| UMD_DEV\nReactDOMForked-profiling.js \| -0.2% \| -0.2% \| 428.4 KB \| 427.5 KB \| 77.78 KB \| 77.62 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 19.97 KB \| 19.97 KB \| 7.42 KB \| 7.42 KB \| UMD_PROD\nReactDOMTesting-dev.js \| -0.0% \| -0.0% \| 919.42 KB \| 918.96 KB \| 205.03 KB \| 205 KB \| FB_WWW_DEV\nreact-dom.development.js \| -0.0% \| -0.0% \| 859.77 KB \| 859.7 KB \| 196.25 KB \| 196.21 KB \| NODE_DEV\nReactDOMTesting-prod.js \| -0.2% \| -0.2% \| 390.99 KB \| 390.24 KB \| 71.19 KB \| 71.05 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 128.22 KB \| 128.22 KB \| 34.31 KB \| 34.31 KB \| NODE_DEV\nReactDOM-dev.js \| -0.0% \| -0.0% \| 983.7 KB \| 983.24 KB \| 218.53 KB \| 218.49 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 138.36 KB \| 138.36 KB \| 35.27 KB \| 35.27 KB \| FB_WWW_DEV\nReactDOM-prod.js \| -0.2% \| -0.2% \| 410.75 KB \| 409.85 KB \| 74.67 KB \| 74.51 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nReactDOM-profiling.js \| -0.2% \| -0.2% \| 428.4 KB \| 427.5 KB \| 77.78 KB \| 77.62 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1013 B \| 1013 B \| 602 B \| 601 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.48 KB \| UMD_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 54.71 KB \| 54.71 KB \| 14.14 KB \| 14.13 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fdf0b236000ae8919741063e625c49a6c0053612\n</p>\n", "I'm merging this as it feeds into https://github.com/facebook/react/pull/18336. :)" ]	2020-03-18 02:01:22	2020-03-18 13:14:13	2020-03-18 13:13:51	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18333', 'html_url': 'https://github.com/facebook/react/pull/18333', 'diff_url': 'https://github.com/facebook/react/pull/18333.diff', 'patch_url': 'https://github.com/facebook/react/pull/18333.patch', 'merged_at': datetime.datetime(2020, 3, 18, 13, 13, 51)}	If [D20382065](https://our.internmc.facebook.com/intern/diff/D20382065/) successfully rolls out (has some issues still). Then we don't need this fork anymore. We should start by at least removing it from Modern builds. To do this I needed to fix the unsubscribing stuff mentioned in https://github.com/facebook/react/pull/18270#discussion_r394058260. Flare is now used by both the FB fork and without it so we should just compile to one or the other. I do that by always returning an unsubscribe listener and always passing that to a removeEventListener function. The indirections can then be compiled out.	{'url': 'https://api.github.com/repos/facebook/react/issues/18333/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18333/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18332	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18332/labels{/name}	https://api.github.com/repos/facebook/react/issues/18332/comments	https://api.github.com/repos/facebook/react/issues/18332/events	https://github.com/facebook/react/pull/18332	583,371,412	MDExOlB1bGxSZXF1ZXN0MzkwMTM5MjYy	18,332	Refactor React.Children to reduce indirection	{'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'following_url': 'https://api.github.com/users/gaearon/following{/other_user}', 'gists_url': 'https://api.github.com/users/gaearon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gaearon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gaearon/subscriptions', 'organizations_url': 'https://api.github.com/users/gaearon/orgs', 'repos_url': 'https://api.github.com/users/gaearon/repos', 'events_url': 'https://api.github.com/users/gaearon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gaearon/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18332/builds/15266) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 98902bb19ead84aedfb489fce2c840e816fef1e4:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[broken-darkness-3269g](https://codesandbox.io/s/broken-darkness-3269g)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 26666427d6ed5cbc581e65e43608fa1acec3bcf8...98902bb19ead84aedfb489fce2c840e816fef1e4</p>\n\n\n \n## react\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact.development.js \| -2.8% \| -2.2% \| 108.97 KB \| 105.95 KB \| 26.03 KB \| 25.45 KB \| UMD_DEV\nreact.production.min.js \| -3.6% \| -3.1% \| 12.66 KB \| 12.21 KB \| 4.87 KB \| 4.72 KB \| UMD_PROD\nreact.profiling.min.js \| -2.8% \| -2.3% \| 16.2 KB \| 15.75 KB \| 5.95 KB \| 5.81 KB \| UMD_PROFILING\nreact.development.js \| -4.1% \| -3.3% \| 70.39 KB \| 67.52 KB \| 18.27 KB \| 17.67 KB \| NODE_DEV\nreact.production.min.js \| -5.8% \| -4.6% \| 7.73 KB \| 7.28 KB \| 2.97 KB \| 2.84 KB \| NODE_PROD\nReact-dev.js \| -3.8% \| -3.3% \| 75.59 KB \| 72.69 KB \| 19.11 KB \| 18.48 KB \| FB_WWW_DEV\nReact-prod.js \| -8.6% \| -6.2% \| 18.02 KB \| 16.47 KB \| 4.66 KB \| 4.37 KB \| FB_WWW_PROD\nReact-profiling.js \| -8.6% \| -6.2% \| 18.02 KB \| 16.47 KB \| 4.66 KB \| 4.37 KB \| FB_WWW_PROFILING\n\n </details>\n \n\nReact: size: -3.6%, gzip: -3.1%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 98902bb19ead84aedfb489fce2c840e816fef1e4\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 26666427d6ed5cbc581e65e43608fa1acec3bcf8...98902bb19ead84aedfb489fce2c840e816fef1e4</p>\n\n\n \n## react\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact.development.js \| -3.0% \| -2.6% \| 100.31 KB \| 97.29 KB \| 24.65 KB \| 24.01 KB \| UMD_DEV\nreact.production.min.js \| -3.9% \| -3.0% \| 11.59 KB \| 11.15 KB \| 4.56 KB \| 4.42 KB \| UMD_PROD\nreact.profiling.min.js \| -3.0% \| -2.6% \| 15.13 KB \| 14.68 KB \| 5.67 KB \| 5.53 KB \| UMD_PROFILING\nreact.development.js \| -4.6% \| -3.5% \| 62.14 KB \| 59.27 KB \| 16.92 KB \| 16.33 KB \| NODE_DEV\nreact.production.min.js \| -6.8% \| -5.3% \| 6.53 KB \| 6.08 KB \| 2.65 KB \| 2.51 KB \| NODE_PROD\nReact-dev.js \| -3.8% \| -3.2% \| 76.26 KB \| 73.37 KB \| 19.28 KB \| 18.65 KB \| FB_WWW_DEV\nReact-prod.js \| -8.5% \| -6.3% \| 18.08 KB \| 16.53 KB \| 4.67 KB \| 4.37 KB \| FB_WWW_PROD\nReact-profiling.js \| -8.5% \| -6.3% \| 18.08 KB \| 16.53 KB \| 4.67 KB \| 4.37 KB \| FB_WWW_PROFILING\n\n </details>\n \n\nReact: size: -3.9%, gzip: -3.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 98902bb19ead84aedfb489fce2c840e816fef1e4\n</p>\n", "I'm pretty sure I'm right (c)\r\n\r\nI can write a small one-off generative test thing to verify the results match between implementations. #covid #bored", "I know it's subtle though. E.g. people likely depend even on the nested map unwrapping call order. I think I kept all of that but I agree it's worth testing more closely.", "wdyt of just dropping the pooling and closure avoidance but keeping traverseAllChildren with a different callback for map vs forEach vs count? I think that gets you 90% of the code simplification.", "and is nicer in some ways – eg: count doesn't need to make an array.", "I guess that would be better than what we have today, but I'd still prioritize golfing code size over runtime perf of these helpers.", "Worth noting traverse perf was super important when it was shared by the reconciler code. It's not anymore though.", "Let's give it a try. The only discrepancy I found is that `React.Children.forEach(null)` no longer returns `null`. I didn't fix it because there's no logical reason why it should (this seems accidental), and relying on `forEach` return value is extremely unlikely (this is the only case where it's not `undefined`). I couldn't find any internal callsites doing it either.", "https://github.com/facebook/react/pull/18380" ]	2020-03-17 23:59:13	2020-03-24 20:46:37	2020-03-23 22:56:01	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18332', 'html_url': 'https://github.com/facebook/react/pull/18332', 'diff_url': 'https://github.com/facebook/react/pull/18332.diff', 'patch_url': 'https://github.com/facebook/react/pull/18332.patch', 'merged_at': datetime.datetime(2020, 3, 23, 22, 56, 1)}	This has been bugging me for a while. I know we don't plan to change their behavior because it's a legacy pattern anyway (although we don't have an alternative either). But it's a bit awkward to see this indirection in the bundle. It's also very confusing to read. The original code was written assuming this is perf critical and we must avoid closures. I don't think it is. This pattern isn't super common and when you have it, you probably don't want to iterate over thousands of these anyway. In either case, my last implementation has minimal use of closures too. I removed pooling too which is a bit over-engineered for this use case and might actually hurt perf. Unlike with events, it's not observable. I re-implemented count, forEach, and toArray in terms of map. I know they have slightly different semantics so a naïve implementation wouldn't work but I think I got it right (and when I did it wrong, tests failed). The original rationale to implement them separately was to reuse a lower level primitive that doesn't require any extra allocations. But since both `forEach` and `count` have other quirks (like counting holes) I don't expect them to actually be used that much in critical paths anymore. So I think it's okay `count` allocates an array now and later throws it away. Each commit is fairly mechanical. At the end, I have a single recursive function as a core of map, and other functions expressed through map. Instead of a tangled web of indirections. Read individual commits. Although I guess reading the whole thing also works because you can follow it now.	{'url': 'https://api.github.com/repos/facebook/react/issues/18332/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18332/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18331	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18331/labels{/name}	https://api.github.com/repos/facebook/react/issues/18331/comments	https://api.github.com/repos/facebook/react/issues/18331/events	https://github.com/facebook/react/pull/18331	583,365,886	MDExOlB1bGxSZXF1ZXN0MzkwMTM0NjE4	18,331	Fix UMD Builds (ReactSharedInternals)	{'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', 'following_url': 'https://api.github.com/users/lunaruan/following{/other_user}', 'gists_url': 'https://api.github.com/users/lunaruan/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lunaruan/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lunaruan/subscriptions', 'organizations_url': 'https://api.github.com/users/lunaruan/orgs', 'repos_url': 'https://api.github.com/users/lunaruan/repos', 'events_url': 'https://api.github.com/users/lunaruan/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lunaruan/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18331/builds/15271) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 39fbaa70bc5356765c1c5236a5ae2aac1ef85bfe:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[pensive-haslett-ykxl6](https://codesandbox.io/s/pensive-haslett-ykxl6)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 39fbaa70bc5356765c1c5236a5ae2aac1ef85bfe\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 39fbaa70bc5356765c1c5236a5ae2aac1ef85bfe\n</p>\n", ">ReactCurrentBatchConfig.suspense does not exist in legacy renderer for fixturees\r\n\r\nWhy? What's special about fixtures? Are they pulling an old version of React somehow?", "My understanding is that ReactCurrentBatchConfig is exposed on shared internals in all flag configurations. So why would it be undefined?", "(Note this PR doesn't \"fix fixtures\" anymore, it's more like it fixes UMD builds?)", "> Scary stuff. Let's come up with some plan to prevent this in the future? Like maybe a shared flowtype.\r\n\r\nThis makes sense. I'll add it to my to do list to add a `ReactSharedInternals` type :)" ]	2020-03-17 23:42:08	2020-03-18 00:56:22	2020-03-18 00:56:15	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18331', 'html_url': 'https://github.com/facebook/react/pull/18331', 'diff_url': 'https://github.com/facebook/react/pull/18331.diff', 'patch_url': 'https://github.com/facebook/react/pull/18331.patch', 'merged_at': datetime.datetime(2020, 3, 18, 0, 56, 15)}	`ReactCurrentBatchConfig.suspense` does not exist in `ReactSharedInternals.umd`. This PR adds it.	{'url': 'https://api.github.com/repos/facebook/react/issues/18331/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18331/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18330	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18330/labels{/name}	https://api.github.com/repos/facebook/react/issues/18330/comments	https://api.github.com/repos/facebook/react/issues/18330/events	https://github.com/facebook/react/pull/18330	583,300,307	MDExOlB1bGxSZXF1ZXN0MzkwMDc4NzE5	18,330	Don't fire the render phase update warning for class lifecycles	{'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'following_url': 'https://api.github.com/users/gaearon/following{/other_user}', 'gists_url': 'https://api.github.com/users/gaearon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gaearon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gaearon/subscriptions', 'organizations_url': 'https://api.github.com/users/gaearon/orgs', 'repos_url': 'https://api.github.com/users/gaearon/repos', 'events_url': 'https://api.github.com/users/gaearon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gaearon/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18330/builds/15256) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 933157ffd712580ec6ab21b10085d9b096199c26:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[peaceful-mestorf-4ufj8](https://codesandbox.io/s/peaceful-mestorf-4ufj8)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 933157ffd712580ec6ab21b10085d9b096199c26\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 933157ffd712580ec6ab21b10085d9b096199c26\n</p>\n" ]	2020-03-17 21:09:03	2020-03-19 19:15:58	2020-03-18 00:07:15	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18330', 'html_url': 'https://github.com/facebook/react/pull/18330', 'diff_url': 'https://github.com/facebook/react/pull/18330.diff', 'patch_url': 'https://github.com/facebook/react/pull/18330.patch', 'merged_at': datetime.datetime(2020, 3, 18, 0, 7, 14)}	Fixes https://github.com/facebook/react/issues/18178#issuecomment-600132920. In 16.13, we added a new warning: `Cannot update a component from inside a body of a function component`. But as we see from reports like https://github.com/facebook/react/issues/18178#issuecomment-600106450, it fired for updates from inside of class lifecycles too. While arguably these are real issues (they happen in render phase) it's pretty noisy for legacy code. In this PR, I do the following: - Change the wording (`from inside a body of a function component` -> `while rendering`). This more accurately describes when it would fire. - Change the deduping originally added in https://github.com/facebook/react/pull/18316 to be more aggressive. In particular, I suggest to not fire more than one warning per callsite. This is because the actual target components tend to be disconnected and mostly unrelated due to abstractions like Redux. Let's focus on the part that fires the updates. - Limit the warning to function component bodies and class `render` lifecycles. Everything else will get muted. This is consistent with how our existing class "setState from another component's render" warning works. - As a possible follow-up, we could make both of these fire for other render-phase lifecycles like `getDerivedStateFromProps`, `shouldComponentUpdate`, and `constructor`. Maybe in strict mode only. However, we should keep them muted for `componentWill` lifecycles including render phase ones. Here is a table of the changes: <img width="1250" alt="Screenshot 2020-03-17 at 21 10 07" src="https://user-images.githubusercontent.com/810438/76902344-b4249900-6893-11ea-93da-2536f25b6c0e.png"> Red* means new behavior, blue means revert to 16.12 behavior.	{'url': 'https://api.github.com/repos/facebook/react/issues/18330/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18330/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18329	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18329/labels{/name}	https://api.github.com/repos/facebook/react/issues/18329/comments	https://api.github.com/repos/facebook/react/issues/18329/events	https://github.com/facebook/react/pull/18329	583,237,636	MDExOlB1bGxSZXF1ZXN0MzkwMDI1NjMx	18,329	Don't support older isomorphic React with newer renderers	{'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'following_url': 'https://api.github.com/users/gaearon/following{/other_user}', 'gists_url': 'https://api.github.com/users/gaearon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gaearon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gaearon/subscriptions', 'organizations_url': 'https://api.github.com/users/gaearon/orgs', 'repos_url': 'https://api.github.com/users/gaearon/repos', 'events_url': 'https://api.github.com/users/gaearon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gaearon/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 9240918536f38ae50dfd86cae4e60bfc590d04ea...8ecfd8f46fff574b44a67fcd1caf8d0d03b1b5c6</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| -0.1% \| -0.1% \| 427.74 KB \| 427.43 KB \| 77.65 KB \| 77.58 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| -1.4% \| -1.1% \| 12.29 KB \| 12.12 KB \| 4.52 KB \| 4.47 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| -0.9% \| -1.2% \| 58.22 KB \| 57.7 KB \| 14.53 KB \| 14.36 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.3% \| 1013 B \| 1013 B \| 604 B \| 602 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\nReactDOMForked-dev.js \| -0.1% \| -0.1% \| 983.17 KB \| 982.51 KB \| 218.54 KB \| 218.35 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| -0.1% \| -0.1% \| 410.1 KB \| 409.79 KB \| 74.54 KB \| 74.48 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.2% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nreact-dom.development.js \| -0.1% \| -0.1% \| 903.77 KB \| 903.08 KB \| 198.93 KB \| 198.71 KB \| UMD_DEV\nReactDOMForked-profiling.js \| -0.1% \| -0.1% \| 427.74 KB \| 427.43 KB \| 77.65 KB \| 77.58 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| -0.5% \| -0.6% \| 135.83 KB \| 135.15 KB \| 34.97 KB \| 34.75 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.3% \| 1.15 KB \| 1.15 KB \| 655 B \| 653 B \| NODE_PROD\nreact-dom.production.min.js \| -0.2% \| -0.2% \| 118.26 KB \| 118.07 KB \| 37.98 KB \| 37.92 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| -0.9% \| -0.6% \| 20.16 KB \| 19.97 KB \| 7.46 KB \| 7.42 KB \| UMD_PROD\nreact-dom.profiling.min.js \| -0.2% \| -0.1% \| 121.97 KB \| 121.78 KB \| 39.19 KB \| 39.13 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| -0.1% \| -0.1% \| 919.64 KB \| 918.98 KB \| 205.18 KB \| 204.98 KB \| FB_WWW_DEV\nreact-dom.development.js \| -0.1% \| -0.1% \| 860.19 KB \| 859.54 KB \| 196.43 KB \| 196.24 KB \| NODE_DEV\nReactDOMTesting-prod.js \| -0.1% \| -0.1% \| 390.84 KB \| 390.54 KB \| 71.18 KB \| 71.12 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| -0.5% \| -0.6% \| 128.87 KB \| 128.22 KB \| 34.52 KB \| 34.31 KB \| NODE_DEV\nreact-dom.production.min.js \| -0.2% \| -0.2% \| 118.34 KB \| 118.15 KB \| 37.19 KB \| 37.13 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| -0.9% \| -1.1% \| 59.83 KB \| 59.3 KB \| 15.85 KB \| 15.68 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| -0.1% \| -0.1% \| 390.84 KB \| 390.54 KB \| 71.18 KB \| 71.12 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| -1.0% \| -0.7% \| 20.07 KB \| 19.88 KB \| 7.42 KB \| 7.37 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.34 KB \| 3.34 KB \| 1.26 KB \| 1.26 KB \| UMD_DEV\nreact-dom.profiling.min.js \| -0.2% \| -0.2% \| 122.2 KB \| 122.01 KB \| 38.39 KB \| 38.32 KB \| NODE_PROFILING\nreact-dom-test-utils.production.min.js \| -1.4% \| -1.0% \| 12.43 KB \| 12.26 KB \| 4.59 KB \| 4.55 KB \| UMD_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.4% \| 1.17 KB \| 1.17 KB \| 693 B \| 690 B \| UMD_PROD\nReactDOM-dev.js \| -0.1% \| -0.1% \| 983.17 KB \| 982.51 KB \| 218.54 KB \| 218.35 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| -0.5% \| -0.6% \| 139.01 KB \| 138.36 KB \| 35.48 KB \| 35.27 KB \| FB_WWW_DEV\nReactDOM-prod.js \| -0.1% \| -0.1% \| 410.1 KB \| 409.79 KB \| 74.54 KB \| 74.48 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| -0.9% \| -1.0% \| 55.27 KB \| 54.77 KB \| 15.23 KB \| 15.08 KB \| NODE_DEV\nReactDOMServer-prod.js \| -0.6% \| -0.5% \| 47.71 KB \| 47.41 KB \| 11.11 KB \| 11.05 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nReactTestUtils-dev.js \| -0.9% \| -1.0% \| 57.48 KB \| 56.97 KB \| 15.54 KB \| 15.38 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.development.js \| -0.9% \| -1.2% \| 55.21 KB \| 54.71 KB \| 14.3 KB \| 14.14 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| -0.5% \| -0.6% \| 130.09 KB \| 129.44 KB \| 34.77 KB \| 34.56 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| -0.9% \| -0.7% \| 20.48 KB \| 20.29 KB \| 7.57 KB \| 7.52 KB \| NODE_PROD\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| -0.1% \| -0.2% \| 633.79 KB \| 633.11 KB \| 133.58 KB \| 133.37 KB \| UMD_DEV\nreact-art.production.min.js \| -0.2% \| -0.2% \| 106.48 KB \| 106.29 KB \| 32.32 KB \| 32.27 KB \| UMD_PROD\nreact-art.development.js \| -0.1% \| -0.2% \| 537.93 KB \| 537.27 KB \| 115.91 KB \| 115.69 KB \| NODE_DEV\nreact-art.production.min.js \| -0.3% \| -0.2% \| 71.53 KB \| 71.33 KB \| 21.52 KB \| 21.47 KB \| NODE_PROD\nReactART-dev.js \| -0.1% \| -0.2% \| 599.66 KB \| 599.01 KB \| 125.41 KB \| 125.18 KB \| FB_WWW_DEV\nReactART-prod.js \| -0.1% \| -0.2% \| 242.07 KB \| 241.77 KB \| 41.19 KB \| 41.12 KB \| FB_WWW_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer.development.js \| -0.1% \| -0.2% \| 571.27 KB \| 570.59 KB \| 118.79 KB \| 118.57 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| -0.3% \| -0.3% \| 73.5 KB \| 73.31 KB \| 22.39 KB \| 22.33 KB \| UMD_PROD\nreact-test-renderer-shallow.development.js \| 0.0% \| -0.0% \| 38.39 KB \| 38.39 KB \| 9.29 KB \| 9.29 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| -0.0% \| 12.91 KB \| 12.91 KB \| 3.93 KB \| 3.93 KB \| UMD_PROD\nreact-test-renderer.development.js \| -0.1% \| -0.2% \| 544.49 KB \| 543.83 KB \| 117.4 KB \| 117.18 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| -0.3% \| -0.2% \| 73.32 KB \| 73.13 KB \| 22.06 KB \| 22.02 KB \| NODE_PROD\nReactTestRenderer-dev.js \| -0.1% \| -0.2% \| 571.92 KB \| 571.27 KB \| 120.65 KB \| 120.43 KB \| FB_WWW_DEV\n\n## react-cache\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-cache.development.js \| -5.4% \| -5.5% \| 9.29 KB \| 8.78 KB \| 3.15 KB \| 2.97 KB \| NODE_DEV\nreact-cache.production.min.js \| 0.0% \| -0.2% \| 2.13 KB \| 2.13 KB \| 1.09 KB \| 1.09 KB \| NODE_PROD\nreact-cache.development.js \| -5.3% \| -5.5% \| 10.06 KB \| 9.53 KB \| 3.26 KB \| 3.08 KB \| UMD_DEV\nreact-cache.production.min.js \| 0.0% \| -0.2% \| 2.35 KB \| 2.35 KB \| 1.19 KB \| 1.19 KB \| UMD_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| -0.1% \| -0.1% \| 651.87 KB \| 651.22 KB \| 140.99 KB \| 140.79 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| -0.1% \| -0.1% \| 267.61 KB \| 267.3 KB \| 46.51 KB \| 46.45 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| -0.1% \| -0.1% \| 279.41 KB \| 279.1 KB \| 48.77 KB \| 48.71 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| -0.1% \| -0.1% \| 633.73 KB \| 633.08 KB \| 136.63 KB \| 136.44 KB \| RN_OSS_DEV\nReactFabric-prod.js \| -0.1% \| -0.1% \| 259.59 KB \| 259.29 KB \| 45.04 KB \| 44.97 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| -0.1% \| -0.1% \| 271.39 KB \| 271.08 KB \| 47.29 KB \| 47.22 KB \| RN_OSS_PROFILING\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler-reflection.development.js \| -3.1% \| -3.5% \| 16.24 KB \| 15.73 KB \| 4.96 KB \| 4.79 KB \| NODE_DEV\nreact-reconciler-reflection.production.min.js \| -8.1% \| -9.7% \| 2.8 KB \| 2.57 KB \| 1.2 KB \| 1.08 KB \| NODE_PROD\nreact-reconciler.development.js \| -0.1% \| -0.2% \| 575.47 KB \| 574.82 KB \| 121.57 KB \| 121.35 KB \| NODE_DEV\nreact-reconciler.production.min.js \| -0.3% \| -0.1% \| 76.19 KB \| 75.99 KB \| 22.55 KB \| 22.52 KB \| NODE_PROD\n\n## react-interactions\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-interactions-events/focus.development.js \| 0.0% \| -0.1% \| 16.85 KB \| 16.85 KB \| 3.37 KB \| 3.36 KB \| UMD_DEV\nreact-interactions-events/press-legacy.production.min.js \| 0.0% \| -0.1% \| 7.11 KB \| 7.11 KB \| 2.69 KB \| 2.69 KB \| NODE_PROD\nreact-interactions-events/focus.production.min.js \| 0.0% \| -0.1% \| 5.41 KB \| 5.41 KB \| 1.79 KB \| 1.78 KB \| UMD_PROD\nreact-interactions-events/context-menu.development.js \| 0.0% \| -0.4% \| 2.49 KB \| 2.49 KB \| 984 B \| 980 B \| NODE_DEV\nreact-interactions-events/context-menu.production.min.js \| 0.0% \| -0.6% \| 1.2 KB \| 1.2 KB \| 674 B \| 670 B \| NODE_PROD\nreact-interactions-events/hover.development.js \| 0.0% \| -0.2% \| 8.46 KB \| 8.46 KB \| 1.72 KB \| 1.72 KB \| UMD_DEV\nreact-interactions-events/hover.production.min.js \| 0.0% \| -0.2% \| 3.48 KB \| 3.48 KB \| 1.23 KB \| 1.23 KB \| UMD_PROD\nreact-interactions-events/hover.development.js \| 0.0% \| -0.2% \| 7.74 KB \| 7.74 KB \| 1.64 KB \| 1.63 KB \| NODE_DEV\nreact-interactions-events/hover.production.min.js \| 0.0% \| -0.2% \| 3.28 KB \| 3.28 KB \| 1.16 KB \| 1.15 KB \| NODE_PROD\nreact-interactions-events/press-legacy.development.js \| -2.1% \| -3.0% \| 25.32 KB \| 24.79 KB \| 6.21 KB \| 6.02 KB \| UMD_DEV\nreact-interactions-events/press-legacy.production.min.js \| 0.0% \| -0.1% \| 7.31 KB \| 7.31 KB \| 2.76 KB \| 2.76 KB \| UMD_PROD\nreact-interactions-events/press-legacy.development.js \| -2.1% \| -3.0% \| 23.9 KB \| 23.39 KB \| 6.07 KB \| 5.89 KB \| NODE_DEV\nreact-interactions-events/focus.development.js \| 0.0% \| -0.1% \| 15.76 KB \| 15.76 KB \| 3.26 KB \| 3.26 KB \| NODE_DEV\nreact-interactions-events/focus.production.min.js \| 0.0% \| -0.2% \| 5.23 KB \| 5.23 KB \| 1.71 KB \| 1.71 KB \| NODE_PROD\nreact-interactions-events/keyboard.development.js \| 0.0% \| -0.0% \| 6.31 KB \| 6.31 KB \| 2.31 KB \| 2.31 KB \| UMD_DEV\nreact-interactions-events/keyboard.production.min.js \| 0.0% \| -0.1% \| 2.45 KB \| 2.45 KB \| 1.25 KB \| 1.25 KB \| UMD_PROD\nreact-interactions-events/keyboard.development.js \| 0.0% \| -0.0% \| 5.74 KB \| 5.74 KB \| 2.21 KB \| 2.21 KB \| NODE_DEV\nreact-interactions-events/context-menu.development.js \| 0.0% \| -0.2% \| 2.84 KB \| 2.84 KB \| 1.04 KB \| 1.04 KB \| UMD_DEV\nreact-interactions-events/keyboard.production.min.js \| 0.0% \| -0.1% \| 2.26 KB \| 2.26 KB \| 1.18 KB \| 1.18 KB \| NODE_PROD\nreact-interactions-events/context-menu.production.min.js \| 0.0% \| -0.4% \| 1.41 KB \| 1.41 KB \| 750 B \| 747 B \| UMD_PROD\n\n## react-debug-tools\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-debug-tools.production.min.js \| -3.0% \| -2.3% \| 5.81 KB \| 5.64 KB \| 2.2 KB \| 2.15 KB \| NODE_PROD\nreact-debug-tools.development.js \| -2.6% \| -3.1% \| 19.33 KB \| 18.82 KB \| 5.31 KB \| 5.15 KB \| NODE_DEV\n\n## create-subscription\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \ncreate-subscription.development.js \| -7.6% \| -7.7% \| 6.67 KB \| 6.17 KB \| 2.45 KB \| 2.26 KB \| NODE_DEV\ncreate-subscription.production.min.js \| 0.0% \| -0.3% \| 1.93 KB \| 1.93 KB \| 962 B \| 959 B \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.1%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8ecfd8f46fff574b44a67fcd1caf8d0d03b1b5c6\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 9240918536f38ae50dfd86cae4e60bfc590d04ea...8ecfd8f46fff574b44a67fcd1caf8d0d03b1b5c6</p>\n\n\n \n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer.development.js \| -0.1% \| -0.2% \| 571.3 KB \| 570.61 KB \| 118.81 KB \| 118.58 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| -0.3% \| -0.3% \| 73.53 KB \| 73.33 KB \| 22.41 KB \| 22.35 KB \| UMD_PROD\nreact-test-renderer-shallow.development.js \| 0.0% \| -0.0% \| 38.4 KB \| 38.4 KB \| 9.3 KB \| 9.3 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| -0.0% \| 12.92 KB \| 12.92 KB \| 3.94 KB \| 3.94 KB \| UMD_PROD\nreact-test-renderer.development.js \| -0.1% \| -0.2% \| 544.51 KB \| 543.86 KB \| 117.41 KB \| 117.19 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| -0.3% \| -0.2% \| 73.34 KB \| 73.15 KB \| 22.08 KB \| 22.03 KB \| NODE_PROD\nReactTestRenderer-dev.js \| -0.1% \| -0.2% \| 571.93 KB \| 571.28 KB \| 120.66 KB \| 120.44 KB \| FB_WWW_DEV\n\n## react-interactions\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-interactions-events/context-menu.development.js \| 0.0% \| -0.3% \| 2.86 KB \| 2.86 KB \| 1.05 KB \| 1.05 KB \| UMD_DEV\nreact-interactions-events/press-legacy.development.js \| -2.1% \| -3.0% \| 25.33 KB \| 24.8 KB \| 6.21 KB \| 6.03 KB \| UMD_DEV\nreact-interactions-events/context-menu.production.min.js \| 0.0% \| -0.4% \| 1.42 KB \| 1.42 KB \| 758 B \| 755 B \| UMD_PROD\nreact-interactions-events/press-legacy.production.min.js \| 0.0% \| -0.1% \| 7.32 KB \| 7.32 KB \| 2.77 KB \| 2.77 KB \| UMD_PROD\nreact-interactions-events/hover.development.js \| 0.0% \| -0.1% \| 8.47 KB \| 8.47 KB \| 1.73 KB \| 1.73 KB \| UMD_DEV\nreact-interactions-events/hover.production.min.js \| 0.0% \| -0.2% \| 3.49 KB \| 3.49 KB \| 1.24 KB \| 1.24 KB \| UMD_PROD\nreact-interactions-events/hover.development.js \| 0.0% \| -0.2% \| 7.75 KB \| 7.75 KB \| 1.64 KB \| 1.64 KB \| NODE_DEV\nreact-interactions-events/hover.production.min.js \| 0.0% \| -0.2% \| 3.3 KB \| 3.3 KB \| 1.17 KB \| 1.16 KB \| NODE_PROD\nreact-interactions-events/focus.development.js \| 0.0% \| -0.1% \| 16.86 KB \| 16.86 KB \| 3.37 KB \| 3.37 KB \| UMD_DEV\nreact-interactions-events/focus.production.min.js \| 0.0% \| -0.2% \| 5.42 KB \| 5.42 KB \| 1.79 KB \| 1.79 KB \| UMD_PROD\nreact-interactions-events/focus.development.js \| 0.0% \| -0.1% \| 15.77 KB \| 15.77 KB \| 3.27 KB \| 3.27 KB \| NODE_DEV\nreact-interactions-events/focus.production.min.js \| 0.0% \| -0.2% \| 5.24 KB \| 5.24 KB \| 1.72 KB \| 1.71 KB \| NODE_PROD\nreact-interactions-events/context-menu.development.js \| 0.0% \| -0.2% \| 2.5 KB \| 2.5 KB \| 991 B \| 989 B \| NODE_DEV\nreact-interactions-events/press-legacy.development.js \| -2.1% \| -3.0% \| 23.91 KB \| 23.4 KB \| 6.08 KB \| 5.9 KB \| NODE_DEV\nreact-interactions-events/context-menu.production.min.js \| 0.0% \| -0.4% \| 1.22 KB \| 1.22 KB \| 683 B \| 680 B \| NODE_PROD\nreact-interactions-events/press-legacy.production.min.js \| 0.0% \| -0.1% \| 7.12 KB \| 7.12 KB \| 2.7 KB \| 2.7 KB \| NODE_PROD\nreact-interactions-events/keyboard.development.js \| 0.0% \| -0.1% \| 6.33 KB \| 6.33 KB \| 2.32 KB \| 2.31 KB \| UMD_DEV\nreact-interactions-events/keyboard.production.min.js \| 0.0% \| -0.1% \| 2.46 KB \| 2.46 KB \| 1.26 KB \| 1.26 KB \| UMD_PROD\nreact-interactions-events/keyboard.development.js \| 0.0% \| -0.1% \| 5.75 KB \| 5.75 KB \| 2.21 KB \| 2.21 KB \| NODE_DEV\nreact-interactions-events/keyboard.production.min.js \| 0.0% \| -0.1% \| 2.27 KB \| 2.27 KB \| 1.19 KB \| 1.19 KB \| NODE_PROD\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| -0.2% \| -0.1% \| 126.59 KB \| 126.4 KB \| 39.59 KB \| 39.54 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nReactDOM-dev.js \| -0.1% \| -0.1% \| 937.29 KB \| 936.64 KB \| 208.65 KB \| 208.44 KB \| FB_WWW_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.4% \| 1.19 KB \| 1.19 KB \| 701 B \| 698 B \| UMD_PROD\nreact-dom-server.browser.development.js \| -0.5% \| -0.6% \| 137.42 KB \| 136.74 KB \| 35.17 KB \| 34.96 KB \| UMD_DEV\nReactTestUtils-dev.js \| -0.9% \| -1.0% \| 57.48 KB \| 56.97 KB \| 15.54 KB \| 15.38 KB \| FB_WWW_DEV\nreact-dom-server.browser.production.min.js \| -0.9% \| -0.6% \| 20.62 KB \| 20.43 KB \| 7.54 KB \| 7.49 KB \| UMD_PROD\nreact-dom-server.browser.development.js \| -0.5% \| -0.6% \| 130.38 KB \| 129.73 KB \| 34.74 KB \| 34.53 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| -0.9% \| -0.7% \| 20.53 KB \| 20.34 KB \| 7.5 KB \| 7.45 KB \| NODE_PROD\nreact-dom.development.js \| -0.1% \| -0.1% \| 934.26 KB \| 933.57 KB \| 204.2 KB \| 203.99 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| -0.9% \| -1.2% \| 58.24 KB \| 57.71 KB \| 14.54 KB \| 14.37 KB \| UMD_DEV\nreact-dom.production.min.js \| -0.2% \| -0.1% \| 122.46 KB \| 122.27 KB \| 39.15 KB \| 39.1 KB \| UMD_PROD\nReactDOMForked-dev.js \| -0.1% \| -0.1% \| 937.29 KB \| 936.64 KB \| 208.65 KB \| 208.44 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.32 KB \| 10.32 KB \| 3.5 KB \| 3.49 KB \| UMD_PROD\nReactDOMServer-dev.js \| -0.5% \| -0.6% \| 138.16 KB \| 137.51 KB \| 35.34 KB \| 35.13 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| -0.2% \| -0.1% \| 126.29 KB \| 126.1 KB \| 40.39 KB \| 40.35 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| -0.1% \| -0.1% \| 383.67 KB \| 383.37 KB \| 69.81 KB \| 69.75 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| -0.7% \| -0.6% \| 47.01 KB \| 46.7 KB \| 10.93 KB \| 10.87 KB \| FB_WWW_PROD\nreact-dom.development.js \| -0.1% \| -0.1% \| 889.4 KB \| 888.75 KB \| 201.68 KB \| 201.48 KB \| NODE_DEV\nReactDOMForked-profiling.js \| -0.1% \| -0.1% \| 401.26 KB \| 400.95 KB \| 72.84 KB \| 72.78 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| -0.9% \| -1.2% \| 55.23 KB \| 54.72 KB \| 14.31 KB \| 14.14 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.2% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| -0.2% \| -0.1% \| 122.61 KB \| 122.42 KB \| 38.31 KB \| 38.25 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.3% \| 1.16 KB \| 1.16 KB \| 664 B \| 662 B \| NODE_PROD\nReactDOM-prod.js \| -0.1% \| -0.1% \| 383.67 KB \| 383.37 KB \| 69.81 KB \| 69.75 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| -0.1% \| -0.1% \| 401.26 KB \| 400.95 KB \| 72.84 KB \| 72.78 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.3% \| 1 KB \| 1 KB \| 612 B \| 610 B \| NODE_PROD\nreact-dom-test-utils.development.js \| -0.9% \| -1.1% \| 59.84 KB \| 59.32 KB \| 15.86 KB \| 15.69 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| -1.4% \| -1.0% \| 12.44 KB \| 12.27 KB \| 4.6 KB \| 4.56 KB \| UMD_PROD\nReactDOMTesting-dev.js \| -0.1% \| -0.1% \| 892.98 KB \| 892.33 KB \| 199.68 KB \| 199.48 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| -0.1% \| -0.1% \| 377.43 KB \| 377.12 KB \| 69 KB \| 68.94 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| -0.9% \| -1.0% \| 55.29 KB \| 54.78 KB \| 15.24 KB \| 15.08 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| -0.1% \| -0.1% \| 377.43 KB \| 377.12 KB \| 69 KB \| 68.94 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| -0.5% \| -0.6% \| 131.6 KB \| 130.95 KB \| 34.99 KB \| 34.78 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| -1.4% \| -1.1% \| 12.3 KB \| 12.13 KB \| 4.53 KB \| 4.48 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| -0.9% \| -0.7% \| 20.94 KB \| 20.75 KB \| 7.65 KB \| 7.6 KB \| NODE_PROD\n\n## react-cache\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-cache.development.js \| -5.2% \| -5.5% \| 10.07 KB \| 9.54 KB \| 3.27 KB \| 3.09 KB \| UMD_DEV\nreact-cache.production.min.js \| 0.0% \| -0.2% \| 2.36 KB \| 2.36 KB \| 1.2 KB \| 1.2 KB \| UMD_PROD\nreact-cache.development.js \| -5.4% \| -5.5% \| 9.3 KB \| 8.79 KB \| 3.15 KB \| 2.98 KB \| NODE_DEV\nreact-cache.production.min.js \| 0.0% \| -0.3% \| 2.15 KB \| 2.15 KB \| 1.1 KB \| 1.1 KB \| NODE_PROD\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactART-dev.js \| -0.1% \| -0.2% \| 571.59 KB \| 570.94 KB \| 119.75 KB \| 119.54 KB \| FB_WWW_DEV\nReactART-prod.js \| -0.1% \| -0.1% \| 233.22 KB \| 232.92 KB \| 39.8 KB \| 39.75 KB \| FB_WWW_PROD\nreact-art.development.js \| -0.1% \| -0.1% \| 654.76 KB \| 654.08 KB \| 137.27 KB \| 137.07 KB \| UMD_DEV\nreact-art.production.min.js \| -0.2% \| -0.1% \| 109.24 KB \| 109.04 KB \| 33.09 KB \| 33.05 KB \| UMD_PROD\nreact-art.development.js \| -0.1% \| -0.2% \| 558.05 KB \| 557.4 KB \| 119.64 KB \| 119.43 KB \| NODE_DEV\nreact-art.production.min.js \| -0.3% \| -0.2% \| 74.23 KB \| 74.03 KB \| 22.25 KB \| 22.19 KB \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| -0.1% \| -0.1% \| 654.59 KB \| 653.94 KB \| 141.33 KB \| 141.14 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| -0.1% \| -0.1% \| 267.77 KB \| 267.46 KB \| 46.55 KB \| 46.49 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| -0.1% \| -0.1% \| 279.56 KB \| 279.25 KB \| 48.8 KB \| 48.74 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| -0.1% \| -0.1% \| 633.74 KB \| 633.09 KB \| 136.64 KB \| 136.44 KB \| RN_OSS_DEV\nReactFabric-prod.js \| -0.1% \| -0.1% \| 259.6 KB \| 259.3 KB \| 45.05 KB \| 44.98 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| -0.1% \| -0.1% \| 271.4 KB \| 271.1 KB \| 47.29 KB \| 47.23 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| -0.1% \| -0.1% \| 636.46 KB \| 635.81 KB \| 136.97 KB \| 136.77 KB \| RN_FB_DEV\nReactFabric-prod.js \| -0.1% \| -0.1% \| 259.76 KB \| 259.45 KB \| 45.08 KB \| 45.01 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| -0.1% \| -0.1% \| 651.88 KB \| 651.23 KB \| 140.99 KB \| 140.8 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| -0.1% \| -0.1% \| 271.55 KB \| 271.24 KB \| 47.32 KB \| 47.26 KB \| RN_FB_PROFILING\nReactNativeRenderer-prod.js \| -0.1% \| -0.1% \| 267.62 KB \| 267.32 KB \| 46.52 KB \| 46.46 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| -0.1% \| -0.1% \| 279.42 KB \| 279.11 KB \| 48.78 KB \| 48.72 KB \| RN_OSS_PROFILING\n\n## react-debug-tools\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-debug-tools.development.js \| -2.6% \| -3.1% \| 19.34 KB \| 18.84 KB \| 5.32 KB \| 5.16 KB \| NODE_DEV\nreact-debug-tools.production.min.js \| -3.0% \| -2.2% \| 5.82 KB \| 5.65 KB \| 2.21 KB \| 2.16 KB \| NODE_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| -0.1% \| -0.2% \| 597.92 KB \| 597.27 KB \| 125.8 KB \| 125.6 KB \| NODE_DEV\nreact-reconciler-reflection.development.js \| -3.1% \| -3.5% \| 16.25 KB \| 15.74 KB \| 4.97 KB \| 4.79 KB \| NODE_DEV\nreact-reconciler.production.min.js \| -0.2% \| -0.2% \| 79.28 KB \| 79.09 KB \| 23.3 KB \| 23.26 KB \| NODE_PROD\nreact-reconciler-reflection.production.min.js \| -8.1% \| -9.8% \| 2.81 KB \| 2.58 KB \| 1.21 KB \| 1.09 KB \| NODE_PROD\n\n## create-subscription\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \ncreate-subscription.development.js \| -7.6% \| -7.7% \| 6.68 KB \| 6.18 KB \| 2.46 KB \| 2.27 KB \| NODE_DEV\ncreate-subscription.production.min.js \| 0.0% \| -0.3% \| 1.94 KB \| 1.94 KB \| 970 B \| 967 B \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.4%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8ecfd8f46fff574b44a67fcd1caf8d0d03b1b5c6\n</p>\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18329/builds/15246) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 8ecfd8f46fff574b44a67fcd1caf8d0d03b1b5c6:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[vigilant-blackburn-plqoe](https://codesandbox.io/s/vigilant-blackburn-plqoe)\| Configuration \|\n", ">The case that is still tricky is that we support older \"react\" in React Native implicitly.\r\n\r\nHuh?" ]	2020-03-17 19:11:44	2020-03-18 00:15:16	2020-03-17 19:30:11	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18329', 'html_url': 'https://github.com/facebook/react/pull/18329', 'diff_url': 'https://github.com/facebook/react/pull/18329.diff', 'patch_url': 'https://github.com/facebook/react/pull/18329.patch', 'merged_at': datetime.datetime(2020, 3, 17, 19, 30, 11)}	I think we've already determined this is not gonna work as well as we hoped. Let's just stop supporting it. It's not a breaking change for newer versions of the renderers. We're just removing the guarantee implied by the peer version which we broke anyway several times before. My actual goal is to remove the patching junk from the builds (see the end of the diff). Especially now that we're adding JSXRuntime and it's leaking there too.	{'url': 'https://api.github.com/repos/facebook/react/issues/18329/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18329/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18328	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18328/labels{/name}	https://api.github.com/repos/facebook/react/issues/18328/comments	https://api.github.com/repos/facebook/react/issues/18328/events	https://github.com/facebook/react/pull/18328	583,071,019	MDExOlB1bGxSZXF1ZXN0Mzg5ODg1MDU2	18,328	useEvent: Small tweaks and changes	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18328/builds/15221) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit fa318b5dc27ab6f51e9238838acb46cae59f98c9:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[thirsty-architecture-jcz3v](https://codesandbox.io/s/thirsty-architecture-jcz3v)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fa318b5dc27ab6f51e9238838acb46cae59f98c9\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fa318b5dc27ab6f51e9238838acb46cae59f98c9\n</p>\n" ]	2020-03-17 14:52:25	2020-03-17 15:32:30	2020-03-17 15:32:27	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18328', 'html_url': 'https://github.com/facebook/react/pull/18328', 'diff_url': 'https://github.com/facebook/react/pull/18328.diff', 'patch_url': 'https://github.com/facebook/react/pull/18328.patch', 'merged_at': datetime.datetime(2020, 3, 17, 15, 32, 27)}	This PR makes a few adjustments and tweaks to the current `useEvent` logic within the modern event system. Namely: - `useEvent` uses the the browser default for `passive` as per the internal document, rather than `passive` being `true` by default. - Fixed an issue in the error message where there was missing newlines - Added another test to increase coverage when using `useEvent` together with standard `on*` events.	{'url': 'https://api.github.com/repos/facebook/react/issues/18328/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18328/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18327	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18327/labels{/name}	https://api.github.com/repos/facebook/react/issues/18327/comments	https://api.github.com/repos/facebook/react/issues/18327/events	https://github.com/facebook/react/issues/18327	582,620,076	MDU6SXNzdWU1ODI2MjAwNzY=	18,327	DevTools: Information of Hooks called in loop is merged under first hook	{'login': 'urrri', 'id': 1422691, 'node_id': 'MDQ6VXNlcjE0MjI2OTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1422691?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/urrri', 'html_url': 'https://github.com/urrri', 'followers_url': 'https://api.github.com/users/urrri/followers', 'following_url': 'https://api.github.com/users/urrri/following{/other_user}', 'gists_url': 'https://api.github.com/users/urrri/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/urrri/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/urrri/subscriptions', 'organizations_url': 'https://api.github.com/users/urrri/orgs', 'repos_url': 'https://api.github.com/users/urrri/repos', 'events_url': 'https://api.github.com/users/urrri/events{/privacy}', 'received_events_url': 'https://api.github.com/users/urrri/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "This is, unfortunately, the result of running hooks in a loop- which breaks the very first [\"rule of hooks\"](https://reactjs.org/docs/hooks-rules.html#only-call-hooks-at-the-top-level):\r\n> Don’t call Hooks inside loops, conditions, or nested functions.\r\n\r\nDevTools (really the [`react-debug-tools` package](https://github.com/facebook/react/blob/master/packages/react-debug-tools/src/ReactDebugHooks.js)) analyzes hook by [looking at the call stack](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md#inspecting-hooks). Calling a hook from within a loop breaks this approach.\r\n\r\nI realize that you say your users hooks are static, but I don't think we are going to fix what you've pointed out- since calling hooks from within a loop breaks one of the constraints. (And there's not really an alternate design that we could use here that would also support [custom hooks](https://reactjs.org/docs/hooks-custom.html#using-a-custom-hook).)", "Very strange attitude to the problem. \"There is a bug, but we will not fix it, because it is in the area that is not recommended\". The rules are created to prevent mistakes of those who do not understand what is hidden behind these rules. If you understand what you are doing, then the system will work even contrary to the rules. \"But we will not repair the bug. Suffer, if you are too smart.\" A lot of thanks.", "There are rules to using hooks which the React website clearly defines. The code you have shared breaks the very first rule. Because of this, the resulting behavior of DevTools may not be ideal.\r\n\r\nBeyond that, more importantly, because of how [`react-debug-tools` is implemented](https://github.com/facebook/react/blob/master/packages/react-debug-tools/src/ReactDebugHooks.js), there's not really an alternate design that we could use here that would also support [custom hooks](https://reactjs.org/docs/hooks-custom.html#using-a-custom-hook).\r\n\r\nIf you can think of one, please feel free to propose it though.", "I dont know, how it is implemented, but I don't understand what is the difference in call stack when you use\r\n`useHook1(); useHook2(); useHook3();`\r\nand \r\n```\r\nvar hooks = [useHook1; useHook2; useHook3];\r\nfor(var i = 0; i < hooks.length;i++){\r\n var useHook = hooks[i];\r\n useHook();\r\n}\r\n```\r\nEach hook function has it's own name or displayName property to differentiate them.", "> I dont know, how it is implemented\r\n\r\nI've linked to the implementation in both of my previous comments. You're welcome to look.\r\n\r\nI also linked [to this overview of how it works](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md#inspecting-hooks). I'll copy paste it here:\r\n> Hooks present a unique challenge for the DevTools because of the concept of custom hooks. (A custom hook is essentially any function that calls at least one of the built-in hooks. By convention custom hooks also have names that begin with \"use\".)\r\n>\r\n> So how does DevTools identify custom functions called from within third party components? It does this by temporarily overriding React's built-in hooks and shallow rendering the component in question. Whenever one of the (overridden) built-in hooks are called, it parses the call stack to spot potential custom hooks (functions between the component itself and the built-in hook). This approach enables it to build a tree structure describing all of the calls to both the built-in and custom hooks, along with the values passed to those hooks. (If you're interested in learning more about this, here is the source code.)\r\n\r\nCalling hooks in a loop means that the call stack (at least the top frame) is the same for all of the hooks called. Apparently `react-debug-tools` assumes that the location calling them is a \"custom hook\" then.\r\n\r\nIf you'd be interested in digging in, and you can come up with an alternate approach or a fix, please feel free to tag me on a PR." ]	2020-03-16 21:51:49	2020-03-17 22:29:55	2020-03-16 22:46:53	NONE	null	null	null	My library receives from user array of hooks to run. It uses hooks as plugins. Array is statically declared by customer (it is unchangeable during lifetime of component and passed not via props). My code runs these hooks in loop. When I look at Hooks debug info in DevTools, I see that information from the all executed hooks is placed under the first hook name. React version: 16.13.0 ## Steps To Reproduce 1. Create 2 or more different custom hooks (use different system hooks inside to have internal info) 2. Add them into array. 3. Use functional component to call hooks from the array in a loop (any way for/forEach/etc.) 4. Open appropriated information in DevTools 5. Information from all hooks is under the first hook Link to code example: https://codesandbox.io/s/dev-tools-merges-info-of-hooks-in-loop-uv6ew ## The current behavior All debug info is merged under first hook ## The expected behavior Each hook should contains its own debug info no matter it called directly or from loop.	{'url': 'https://api.github.com/repos/facebook/react/issues/18327/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18327/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18326	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18326/labels{/name}	https://api.github.com/repos/facebook/react/issues/18326/comments	https://api.github.com/repos/facebook/react/issues/18326/events	https://github.com/facebook/react/pull/18326	582,562,941	MDExOlB1bGxSZXF1ZXN0Mzg5NDY0NzAx	18,326	Bump minimist from 1.2.0 to 1.2.2	{'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/users/dependabot%5Bbot%5D/followers', 'following_url': 'https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}', 'gists_url': 'https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dependabot%5Bbot%5D/subscriptions', 'organizations_url': 'https://api.github.com/users/dependabot%5Bbot%5D/orgs', 'repos_url': 'https://api.github.com/users/dependabot%5Bbot%5D/repos', 'events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/received_events', 'type': 'Bot', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/react/labels/dependencies', 'name': 'dependencies', 'color': '0366d6', 'default': False, 'description': 'Pull requests that update a dependency file'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18326/builds/15092) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b085b6cda8866ecfc89f0cc8c3c09d168ace13ca:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[cool-dijkstra-wbqdy](https://codesandbox.io/s/cool-dijkstra-wbqdy)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b085b6cda8866ecfc89f0cc8c3c09d168ace13ca\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b085b6cda8866ecfc89f0cc8c3c09d168ace13ca\n</p>\n", "OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.\n\nIf you change your mind, just re-open this PR and I'll resolve any conflicts on it." ]	2020-03-16 19:53:28	2022-10-10 19:10:57	2020-04-01 18:59:42	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18326', 'html_url': 'https://github.com/facebook/react/pull/18326', 'diff_url': 'https://github.com/facebook/react/pull/18326.diff', 'patch_url': 'https://github.com/facebook/react/pull/18326.patch', 'merged_at': None}	Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/substack/minimist/commit/f34df077a6b2bee1344188849a95e66777109e89"><code>f34df07</code></a> 1.2.2</li> <li><a href="https://github.com/substack/minimist/commit/67d3722413448d00a62963d2d30c34656a92d7e2"><code>67d3722</code></a> cleanup</li> <li><a href="https://github.com/substack/minimist/commit/63e7ed05aa4b1889ec2f3b196426db4500cbda94"><code>63e7ed0</code></a> don't assign onto <strong>proto</strong></li> <li><a href="https://github.com/substack/minimist/commit/47acf72c715a630bf9ea013867f47f1dd69dfc54"><code>47acf72</code></a> console.dir -> console.log</li> <li><a href="https://github.com/substack/minimist/commit/0efed0340ec8433638758f7ca0c77cb20a0bfbab"><code>0efed03</code></a> failing test for protocol pollution</li> <li><a href="https://github.com/substack/minimist/commit/29783cdf94cc9a0663bb31f5eb9a4eff9c515bf6"><code>29783cd</code></a> 1.2.1</li> <li><a href="https://github.com/substack/minimist/commit/6be5dae35a32a987bcf4137fcd6c19c5200ee909"><code>6be5dae</code></a> add test</li> <li><a href="https://github.com/substack/minimist/commit/ac3fc796e63b95128fdbdf67ea7fad71bd59aa76"><code>ac3fc79</code></a> fix bad boolean regexp</li> <li><a href="https://github.com/substack/minimist/commit/4cf45a26b9af5f4ddab63107f4007485e576cfd3"><code>4cf45a2</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/substack/minimist/issues/63">#63</a> from lydell/dash-dash-docs-fix</li> <li><a href="https://github.com/substack/minimist/commit/5fa440ef0f7d067e12baa6694570e7ce7b453340"><code>5fa440e</code></a> move the <code>opts['--']</code> example back where it belongs</li> <li>See full diff in <a href="https://github.com/substack/minimist/compare/1.2.0...1.2.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=minimist&package-manager=npm_and_yarn&previous-version=1.2.0&new-version=1.2.2)](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts). </details>	{'url': 'https://api.github.com/repos/facebook/react/issues/18326/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18326/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18325	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18325/labels{/name}	https://api.github.com/repos/facebook/react/issues/18325/comments	https://api.github.com/repos/facebook/react/issues/18325/events	https://github.com/facebook/react/pull/18325	582,562,784	MDExOlB1bGxSZXF1ZXN0Mzg5NDY0NTY2	18,325	Bump minimist from 1.2.0 to 1.2.5 in /fixtures/packaging/browserify/prod	{'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/users/dependabot%5Bbot%5D/followers', 'following_url': 'https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}', 'gists_url': 'https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dependabot%5Bbot%5D/subscriptions', 'organizations_url': 'https://api.github.com/users/dependabot%5Bbot%5D/orgs', 'repos_url': 'https://api.github.com/users/dependabot%5Bbot%5D/repos', 'events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/received_events', 'type': 'Bot', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/react/labels/dependencies', 'name': 'dependencies', 'color': '0366d6', 'default': False, 'description': 'Pull requests that update a dependency file'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18325/builds/15091) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 13bbe5e674bc524d4bf02d9de2eb3361edf22370:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[goofy-ritchie-690cv](https://codesandbox.io/s/goofy-ritchie-690cv)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 13bbe5e674bc524d4bf02d9de2eb3361edf22370\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 13bbe5e674bc524d4bf02d9de2eb3361edf22370\n</p>\n", "OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.\n\nIf you change your mind, just re-open this PR and I'll resolve any conflicts on it." ]	2020-03-16 19:53:07	2022-10-10 19:10:48	2020-04-01 18:59:41	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18325', 'html_url': 'https://github.com/facebook/react/pull/18325', 'diff_url': 'https://github.com/facebook/react/pull/18325.diff', 'patch_url': 'https://github.com/facebook/react/pull/18325.patch', 'merged_at': None}	Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.5. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/substack/minimist/commit/aeb3e27dae0412de5c0494e9563a5f10c82cc7a9"><code>aeb3e27</code></a> 1.2.5</li> <li><a href="https://github.com/substack/minimist/commit/278677b171d956b46613a158c6c486c3ef979b20"><code>278677b</code></a> 1.2.4</li> <li><a href="https://github.com/substack/minimist/commit/4cf1354839cb972e38496d35e12f806eea92c11f"><code>4cf1354</code></a> security notice</li> <li><a href="https://github.com/substack/minimist/commit/1043d212c3caaf871966e710f52cfdf02f9eea4b"><code>1043d21</code></a> additional test for constructor prototype pollution</li> <li><a href="https://github.com/substack/minimist/commit/6457d7440a47f329c12c4a5abfbce211c4235b93"><code>6457d74</code></a> 1.2.3</li> <li><a href="https://github.com/substack/minimist/commit/38a4d1caead72ef99e824bb420a2528eec03d9ab"><code>38a4d1c</code></a> even more aggressive checks for protocol pollution</li> <li><a href="https://github.com/substack/minimist/commit/13c01a5327736903704984b7f65616b8476850cc"><code>13c01a5</code></a> more failing proto pollution tests</li> <li><a href="https://github.com/substack/minimist/commit/f34df077a6b2bee1344188849a95e66777109e89"><code>f34df07</code></a> 1.2.2</li> <li><a href="https://github.com/substack/minimist/commit/67d3722413448d00a62963d2d30c34656a92d7e2"><code>67d3722</code></a> cleanup</li> <li><a href="https://github.com/substack/minimist/commit/63e7ed05aa4b1889ec2f3b196426db4500cbda94"><code>63e7ed0</code></a> don't assign onto <strong>proto</strong></li> <li>Additional commits viewable in <a href="https://github.com/substack/minimist/compare/1.2.0...1.2.5">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=minimist&package-manager=npm_and_yarn&previous-version=1.2.0&new-version=1.2.5)](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts). </details>	{'url': 'https://api.github.com/repos/facebook/react/issues/18325/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18325/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18324	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18324/labels{/name}	https://api.github.com/repos/facebook/react/issues/18324/comments	https://api.github.com/repos/facebook/react/issues/18324/events	https://github.com/facebook/react/pull/18324	582,562,687	MDExOlB1bGxSZXF1ZXN0Mzg5NDY0NDky	18,324	Bump minimist from 1.2.0 to 1.2.2 in /scripts/bench	{'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/users/dependabot%5Bbot%5D/followers', 'following_url': 'https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}', 'gists_url': 'https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dependabot%5Bbot%5D/subscriptions', 'organizations_url': 'https://api.github.com/users/dependabot%5Bbot%5D/orgs', 'repos_url': 'https://api.github.com/users/dependabot%5Bbot%5D/repos', 'events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/received_events', 'type': 'Bot', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/react/labels/dependencies', 'name': 'dependencies', 'color': '0366d6', 'default': False, 'description': 'Pull requests that update a dependency file'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18324/builds/15090) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b78c419d7acbeef76f0f6582526611dd2184c7e1:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[recursing-pond-rlhqj](https://codesandbox.io/s/recursing-pond-rlhqj)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b78c419d7acbeef76f0f6582526611dd2184c7e1\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b78c419d7acbeef76f0f6582526611dd2184c7e1\n</p>\n", "OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.\n\nIf you change your mind, just re-open this PR and I'll resolve any conflicts on it." ]	2020-03-16 19:52:58	2022-10-10 19:11:00	2020-04-01 18:59:41	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18324', 'html_url': 'https://github.com/facebook/react/pull/18324', 'diff_url': 'https://github.com/facebook/react/pull/18324.diff', 'patch_url': 'https://github.com/facebook/react/pull/18324.patch', 'merged_at': None}	Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/substack/minimist/commit/f34df077a6b2bee1344188849a95e66777109e89"><code>f34df07</code></a> 1.2.2</li> <li><a href="https://github.com/substack/minimist/commit/67d3722413448d00a62963d2d30c34656a92d7e2"><code>67d3722</code></a> cleanup</li> <li><a href="https://github.com/substack/minimist/commit/63e7ed05aa4b1889ec2f3b196426db4500cbda94"><code>63e7ed0</code></a> don't assign onto <strong>proto</strong></li> <li><a href="https://github.com/substack/minimist/commit/47acf72c715a630bf9ea013867f47f1dd69dfc54"><code>47acf72</code></a> console.dir -> console.log</li> <li><a href="https://github.com/substack/minimist/commit/0efed0340ec8433638758f7ca0c77cb20a0bfbab"><code>0efed03</code></a> failing test for protocol pollution</li> <li><a href="https://github.com/substack/minimist/commit/29783cdf94cc9a0663bb31f5eb9a4eff9c515bf6"><code>29783cd</code></a> 1.2.1</li> <li><a href="https://github.com/substack/minimist/commit/6be5dae35a32a987bcf4137fcd6c19c5200ee909"><code>6be5dae</code></a> add test</li> <li><a href="https://github.com/substack/minimist/commit/ac3fc796e63b95128fdbdf67ea7fad71bd59aa76"><code>ac3fc79</code></a> fix bad boolean regexp</li> <li><a href="https://github.com/substack/minimist/commit/4cf45a26b9af5f4ddab63107f4007485e576cfd3"><code>4cf45a2</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/substack/minimist/issues/63">#63</a> from lydell/dash-dash-docs-fix</li> <li><a href="https://github.com/substack/minimist/commit/5fa440ef0f7d067e12baa6694570e7ce7b453340"><code>5fa440e</code></a> move the <code>opts['--']</code> example back where it belongs</li> <li>See full diff in <a href="https://github.com/substack/minimist/compare/1.2.0...1.2.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=minimist&package-manager=npm_and_yarn&previous-version=1.2.0&new-version=1.2.2)](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts). </details>	{'url': 'https://api.github.com/repos/facebook/react/issues/18324/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18324/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18323	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18323/labels{/name}	https://api.github.com/repos/facebook/react/issues/18323/comments	https://api.github.com/repos/facebook/react/issues/18323/events	https://github.com/facebook/react/pull/18323	582,562,311	MDExOlB1bGxSZXF1ZXN0Mzg5NDY0MTc2	18,323	Bump minimist from 1.2.0 to 1.2.5 in /fixtures/packaging/browserify/dev	{'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/users/dependabot%5Bbot%5D/followers', 'following_url': 'https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}', 'gists_url': 'https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dependabot%5Bbot%5D/subscriptions', 'organizations_url': 'https://api.github.com/users/dependabot%5Bbot%5D/orgs', 'repos_url': 'https://api.github.com/users/dependabot%5Bbot%5D/repos', 'events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dependabot%5Bbot%5D/received_events', 'type': 'Bot', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/react/labels/dependencies', 'name': 'dependencies', 'color': '0366d6', 'default': False, 'description': 'Pull requests that update a dependency file'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18323/builds/15089) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit bdffcc97d65a2437b59031817625545427a429ed:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[long-dew-rjw6n](https://codesandbox.io/s/long-dew-rjw6n)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bdffcc97d65a2437b59031817625545427a429ed\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bdffcc97d65a2437b59031817625545427a429ed\n</p>\n", "OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`.\n\nIf you change your mind, just re-open this PR and I'll resolve any conflicts on it." ]	2020-03-16 19:52:07	2022-10-10 19:10:47	2020-04-01 18:59:40	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18323', 'html_url': 'https://github.com/facebook/react/pull/18323', 'diff_url': 'https://github.com/facebook/react/pull/18323.diff', 'patch_url': 'https://github.com/facebook/react/pull/18323.patch', 'merged_at': None}	Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.5. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/substack/minimist/commit/aeb3e27dae0412de5c0494e9563a5f10c82cc7a9"><code>aeb3e27</code></a> 1.2.5</li> <li><a href="https://github.com/substack/minimist/commit/278677b171d956b46613a158c6c486c3ef979b20"><code>278677b</code></a> 1.2.4</li> <li><a href="https://github.com/substack/minimist/commit/4cf1354839cb972e38496d35e12f806eea92c11f"><code>4cf1354</code></a> security notice</li> <li><a href="https://github.com/substack/minimist/commit/1043d212c3caaf871966e710f52cfdf02f9eea4b"><code>1043d21</code></a> additional test for constructor prototype pollution</li> <li><a href="https://github.com/substack/minimist/commit/6457d7440a47f329c12c4a5abfbce211c4235b93"><code>6457d74</code></a> 1.2.3</li> <li><a href="https://github.com/substack/minimist/commit/38a4d1caead72ef99e824bb420a2528eec03d9ab"><code>38a4d1c</code></a> even more aggressive checks for protocol pollution</li> <li><a href="https://github.com/substack/minimist/commit/13c01a5327736903704984b7f65616b8476850cc"><code>13c01a5</code></a> more failing proto pollution tests</li> <li><a href="https://github.com/substack/minimist/commit/f34df077a6b2bee1344188849a95e66777109e89"><code>f34df07</code></a> 1.2.2</li> <li><a href="https://github.com/substack/minimist/commit/67d3722413448d00a62963d2d30c34656a92d7e2"><code>67d3722</code></a> cleanup</li> <li><a href="https://github.com/substack/minimist/commit/63e7ed05aa4b1889ec2f3b196426db4500cbda94"><code>63e7ed0</code></a> don't assign onto <strong>proto</strong></li> <li>Additional commits viewable in <a href="https://github.com/substack/minimist/compare/1.2.0...1.2.5">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=minimist&package-manager=npm_and_yarn&previous-version=1.2.0&new-version=1.2.5)](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts). </details>	{'url': 'https://api.github.com/repos/facebook/react/issues/18323/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18323/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18322	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18322/labels{/name}	https://api.github.com/repos/facebook/react/issues/18322/comments	https://api.github.com/repos/facebook/react/issues/18322/events	https://github.com/facebook/react/pull/18322	582,471,582	MDExOlB1bGxSZXF1ZXN0Mzg5Mzg2Njc2	18,322	Moved passive effects flag to be beside execution context	{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18322/builds/15084) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b939c2c04542e05e51fef0d7ab281478ee465c01:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[eloquent-tesla-695jb](https://codesandbox.io/s/eloquent-tesla-695jb)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b939c2c04542e05e51fef0d7ab281478ee465c01\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b939c2c04542e05e51fef0d7ab281478ee465c01\n</p>\n" ]	2020-03-16 17:18:47	2020-03-16 17:27:46	2020-03-16 17:27:43	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18322', 'html_url': 'https://github.com/facebook/react/pull/18322', 'diff_url': 'https://github.com/facebook/react/pull/18322.diff', 'patch_url': 'https://github.com/facebook/react/pull/18322.patch', 'merged_at': datetime.datetime(2020, 3, 16, 17, 27, 43)}	Move the `isFlushingPassiveEffects` flag next to `executionContext` since they both get set/reset together.	{'url': 'https://api.github.com/repos/facebook/react/issues/18322/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18322/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18321	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18321/labels{/name}	https://api.github.com/repos/facebook/react/issues/18321/comments	https://api.github.com/repos/facebook/react/issues/18321/events	https://github.com/facebook/react/issues/18321	582,410,189	MDU6SXNzdWU1ODI0MTAxODk=	18,321	Bug: Hooks acts weirdly with class - state gets reinitialized every time	{'login': 'RocKhalil', 'id': 5897339, 'node_id': 'MDQ6VXNlcjU4OTczMzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5897339?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/RocKhalil', 'html_url': 'https://github.com/RocKhalil', 'followers_url': 'https://api.github.com/users/RocKhalil/followers', 'following_url': 'https://api.github.com/users/RocKhalil/following{/other_user}', 'gists_url': 'https://api.github.com/users/RocKhalil/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/RocKhalil/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/RocKhalil/subscriptions', 'organizations_url': 'https://api.github.com/users/RocKhalil/orgs', 'repos_url': 'https://api.github.com/users/RocKhalil/repos', 'events_url': 'https://api.github.com/users/RocKhalil/events{/privacy}', 'received_events_url': 'https://api.github.com/users/RocKhalil/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "do this:\r\n\r\n```js\r\nconst socketHelper = useMemo(() => new SocketHelper({\r\n broadcastId: 'whatever',\r\n chatMessageReceived: (data) => {\r\n // --------------👇\r\n setMessages(prevMessages => [...prevMessages, data])\r\n }\r\n}, [])\r\n```\r\n\r\nUsing the function version of `setMessages` gives you access to the old value without needing to pass it into the hook via a closure", "https://reactjs.org/docs/hooks-faq.html#what-can-i-do-if-my-effect-dependencies-change-too-often" ]	2020-03-16 15:57:13	2020-03-16 17:08:37	2020-03-16 16:14:25	NONE	null	null	null	React version: 16.12.0 ## Steps To Reproduce I have a helper `class` that handles my `socket.io` connection and adds the list of messages to my state. Here's the class: ``` import socketIOClient from 'socket.io-client' class SocketHelper { constructor(props) { this.broadcastId = props.broadcastId this.chatMessageReceived = props.chatMessageReceived this.socket = socketIOClient(props.socketURL) } start() { this.socket.emit('join', this.broadcastId) this.socket.on('chat-message', this.chatMessageReceived) } sendMessage(message) { this.socket.emit('message', message) } } export default SocketHelper ``` Now, I want to use this class in my `react` class or function; ### in function ``` const [messages, setMessages] = useState([]) const socketHelper = new SocketHelper({ broadcastId: 'whatever', chatMessageReceived: (data) => { setMessages([...messages, data]) } }) socketHelper.start() ``` Every time I receive a `message` from the socket, my `chatMessageReceived` will be triggered by the `messages` will always be an empty array and the new message will be appended to it. I also tried initializing it once via `useEffect( () => { ... }, [] )` and also got the same result ### in class ``` constructor(props){ super(props) this.state = { messages: [] } this.socketHelper = new SocketHelper({ broadcastId: 'whatever', chatMessageReceived: (data) => { this.setState({ messages: [...this.state.messages, data] }) } }) } ``` This will work and my new message will get appended to the old ones # Other comments I tried to simplify the issue as much as possible. I hope this helps.	{'url': 'https://api.github.com/repos/facebook/react/issues/18321/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18321/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18320	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18320/labels{/name}	https://api.github.com/repos/facebook/react/issues/18320/comments	https://api.github.com/repos/facebook/react/issues/18320/events	https://github.com/facebook/react/issues/18320	582,261,195	MDU6SXNzdWU1ODIyNjExOTU=	18,320	Bug: Should function isControlled use !== ?	{'login': 'xsteadybcgo', 'id': 19681921, 'node_id': 'MDQ6VXNlcjE5NjgxOTIx', 'avatar_url': 'https://avatars.githubusercontent.com/u/19681921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/xsteadybcgo', 'html_url': 'https://github.com/xsteadybcgo', 'followers_url': 'https://api.github.com/users/xsteadybcgo/followers', 'following_url': 'https://api.github.com/users/xsteadybcgo/following{/other_user}', 'gists_url': 'https://api.github.com/users/xsteadybcgo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/xsteadybcgo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/xsteadybcgo/subscriptions', 'organizations_url': 'https://api.github.com/users/xsteadybcgo/orgs', 'repos_url': 'https://api.github.com/users/xsteadybcgo/repos', 'events_url': 'https://api.github.com/users/xsteadybcgo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/xsteadybcgo/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "So 2 questions...\r\n\r\n1. What is the return value of `useAsyncCustomHooks()`?\r\n\r\n2. If `useAsyncCustomHooks` is called, it will return a value eventually. But that value will be final right? If that's the case, then the `<input />` is controlled until the asynchronous `useAsyncCustomHooks` function is called. After the result has been returned, there's nothing to change the `currentPosition`, so it will then be uncontrolled.\r\n\r\nThis is interesting, and I want to figure it out. So this will at least get the conversation going.", "> So 2 questions...\r\n> \r\n> 1. What is the return value of `useAsyncCustomHooks()`?\r\n> 2. If `useAsyncCustomHooks` is called, it will return a value eventually. But that value will be final right? If that's the case, then the `<input />` is controlled until the asynchronous `useAsyncCustomHooks` function is called. After the result has been returned, there's nothing to change the `currentPosition`, so it will then be uncontrolled.\r\n> \r\n> This is interesting, and I want to figure it out. So this will at least get the conversation going.\r\n\r\n- In my case, the return value of useAsyncCustomHooks() is a string such as `\"new york city...\"`\r\n\r\n- I want to give one more example to compare the situation! This confused me about what is the controlled component , i thought the component having `ref` property is a uncontrolled component but now I'm getting stuck !!!\r\n\r\nIn the code snippets above, the initial `state` is `undefined`, so function `isControlled` will return `false`( __`undefined != null` will return `false`__ )\r\nAccording to react source code below, the line 143 will be false & line 162 - 164 is true , it will throw the warning!\r\n\r\nhttps://github.com/facebook/react/blob/c601f7a64640290af85c9f0e33c78480656b46bc/packages/react-dom/src/client/ReactDOMFiberInput.js#L142-L174\r\n\r\nThe example below is similar to the above one, but i won't throw any warining!!\r\n```javascript\r\nfunction FC() {\r\n const [state] = useAsyncCustomHooks()\r\n return <input type=\"text\" value={state \|\| \"\"}/>\r\n }\r\n```\r\nthe initial `state` is `\"\"`, so function `isControlled` will return `true`( __`\"\" != null` will return `true`__ )\r\n\r\n🤔️🤔️🤔️\r\n", "I see the issue clearly now. If we used `!==` instead of `!=`, undefined would work just like `\"\"`.\r\n\r\nI'm trying to think of a situation where this couldn't be solved with the solution I provided below. If we can come up with a proper edge case, it might warrant a pull request.", "I've always viewed controlled components as some type of input with \"`write` access to the state\".\r\n\r\nI'm not sure if you've got a workaround yet, but here's what I would do:\r\n\r\n1. Set the initial state to an empty string, since you're expecting a string eventually:\r\n\r\n```\r\nfunction FC() {\r\n const [position, setPosition] = useState(\"\");\r\n // ... \r\n}\r\n```\r\n\r\n2. Wait for the component to mount, then immediately execute your asynchronous function:\r\n\r\n```\r\nfunction FC() {\r\n const [position, setPosition] = useState(\"\");\r\n\r\n useEffect(() => {\r\n async () => {\r\n const response = await useAsyncCustomHook();\r\n setPosition(response);\r\n }\r\n }, [position])\r\n \r\n return <input type=\"text\" value={state} />\r\n}\r\n```\r\n\r\nI'm not a big fan of the whole double nesting syntax, but I ran into a similar issue with the `useEffect` hook a while back, and this was the only solution a senior dev could give me (he wasn't a fan either haha).", "Many applications rely on a value of `undefined` to mean an uncontrolled component. If you want to treat `undefined` to mean a controlled empty box, you can always write something like:\r\n\r\n```js\r\n<input type=\"text\" value={state === undefined ? '' : state} />\r\n```\r\n\r\nHope that helps.", "Thanks for your reminder, I get it " ]	2020-03-16 12:36:01	2020-03-18 02:04:16	2020-03-18 01:49:03	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> React version: 16.20.0 ## Steps To Reproduce 1. inital state is `undefined` , the `useAsyncCustomHooks` will call an async function eg: `navigator.geolocation.getCurrentPosition` 2. the state will changed later <!-- Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Issues without reproduction steps or code examples may be immediately closed as not actionable. --> Link to code example: ```javascript function FC() { const [state] = useAsyncCustomHooks() return <input type="text" value={state}/> } ``` <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior dev tool throws Warning: A component is changing a controlled input of type hidden to be uncontrolled. Input elements should not switch from controlled to uncontrolled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components ## The expected behavior Not throw that warning, the related source code is: https://github.com/facebook/react/blob/c601f7a64640290af85c9f0e33c78480656b46bc/packages/react-dom/src/client/ReactDOMFiberInput.js#L37-L40 why not `!==` but `!=` :blush:	{'url': 'https://api.github.com/repos/facebook/react/issues/18320/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18320/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18319	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18319/labels{/name}	https://api.github.com/repos/facebook/react/issues/18319/comments	https://api.github.com/repos/facebook/react/issues/18319/events	https://github.com/facebook/react/issues/18319	582,126,196	MDU6SXNzdWU1ODIxMjYxOTY=	18,319	Is it a bug in isControlled ?	{'login': 'xsteadybcgo', 'id': 19681921, 'node_id': 'MDQ6VXNlcjE5NjgxOTIx', 'avatar_url': 'https://avatars.githubusercontent.com/u/19681921?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/xsteadybcgo', 'html_url': 'https://github.com/xsteadybcgo', 'followers_url': 'https://api.github.com/users/xsteadybcgo/followers', 'following_url': 'https://api.github.com/users/xsteadybcgo/following{/other_user}', 'gists_url': 'https://api.github.com/users/xsteadybcgo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/xsteadybcgo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/xsteadybcgo/subscriptions', 'organizations_url': 'https://api.github.com/users/xsteadybcgo/orgs', 'repos_url': 'https://api.github.com/users/xsteadybcgo/repos', 'events_url': 'https://api.github.com/users/xsteadybcgo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/xsteadybcgo/received_events', 'type': 'User', 'site_admin': False}	[]	closed	false	null	[]	null	[]	2020-03-16 09:13:09	2020-03-16 11:58:06	2020-03-16 11:58:06	NONE	null	null	null	https://github.com/facebook/react/blob/c601f7a64640290af85c9f0e33c78480656b46bc/packages/react-dom/src/client/ReactDOMFiberInput.js#L37-L40 why not `!==` but `!=` Generally, initial state should not be `undefined`, but if it was and setState changed, the value of `props.value != null` is `true` and the warning will be thrown. Is this a bug? 🤔️	{'url': 'https://api.github.com/repos/facebook/react/issues/18319/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18319/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18318	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18318/labels{/name}	https://api.github.com/repos/facebook/react/issues/18318/comments	https://api.github.com/repos/facebook/react/issues/18318/events	https://github.com/facebook/react/issues/18318	582,089,198	MDU6SXNzdWU1ODIwODkxOTg=	18,318	React.lazy will cause mount life-cycle for the same path in React Router	{'login': 'CarmeloXue', 'id': 24514156, 'node_id': 'MDQ6VXNlcjI0NTE0MTU2', 'avatar_url': 'https://avatars.githubusercontent.com/u/24514156?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/CarmeloXue', 'html_url': 'https://github.com/CarmeloXue', 'followers_url': 'https://api.github.com/users/CarmeloXue/followers', 'following_url': 'https://api.github.com/users/CarmeloXue/following{/other_user}', 'gists_url': 'https://api.github.com/users/CarmeloXue/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/CarmeloXue/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/CarmeloXue/subscriptions', 'organizations_url': 'https://api.github.com/users/CarmeloXue/orgs', 'repos_url': 'https://api.github.com/users/CarmeloXue/repos', 'events_url': 'https://api.github.com/users/CarmeloXue/events{/privacy}', 'received_events_url': 'https://api.github.com/users/CarmeloXue/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "We can't guess without seeing full code. The issue template asked you to fill in an example, but you didn't do this. We'll have to close this, but please feel free to file a new issue after you create a runnable code example." ]	2020-03-16 08:15:01	2020-03-16 20:58:43	2020-03-16 20:58:42	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> I'm using React.lazy to split my code. I just add a `React.lazy(()=>import('path/to/component')) `and `Suspense`. In my component I have a button with a click function to do `history.replace('/my/route?params=CHANGABLE').` I have several clickable tab header to trigger this function with a different CHANGABLE params and render different tab content for corresponding parameter. Without React.lazy, the click will not trigger re-mount of the component. But with react.lazy, each time I click the tab, the component will go trough the mount life-cycle. Is there anything I've done wrong? Anyone can help me? React version:16.8.3 ## Steps To Reproduce 1. 2. <!-- Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Issues without reproduction steps or code examples may be immediately closed as not actionable. --> Link to code example: <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior Component will go though mount life-cycle ## The expected behavior Component will go though update life-cycle	{'url': 'https://api.github.com/repos/facebook/react/issues/18318/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18318/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18317	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18317/labels{/name}	https://api.github.com/repos/facebook/react/issues/18317/comments	https://api.github.com/repos/facebook/react/issues/18317/events	https://github.com/facebook/react/issues/18317	582,068,776	MDU6SXNzdWU1ODIwNjg3NzY=	18,317	my new react project problems	{'login': 'guojin-soft', 'id': 62233145, 'node_id': 'MDQ6VXNlcjYyMjMzMTQ1', 'avatar_url': 'https://avatars.githubusercontent.com/u/62233145?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/guojin-soft', 'html_url': 'https://github.com/guojin-soft', 'followers_url': 'https://api.github.com/users/guojin-soft/followers', 'following_url': 'https://api.github.com/users/guojin-soft/following{/other_user}', 'gists_url': 'https://api.github.com/users/guojin-soft/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/guojin-soft/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/guojin-soft/subscriptions', 'organizations_url': 'https://api.github.com/users/guojin-soft/orgs', 'repos_url': 'https://api.github.com/users/guojin-soft/repos', 'events_url': 'https://api.github.com/users/guojin-soft/events{/privacy}', 'received_events_url': 'https://api.github.com/users/guojin-soft/received_events', 'type': 'User', 'site_admin': False}	[]	closed	false	null	[]	null	[ "Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\n##### Coding Questions\r\n\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.\r\n\r\n[https://stackoverflow.com/questions/tagged/react](https://stackoverflow.com/questions/tagged/react)\r\n\r\n##### Talk to other React developers\r\n\r\nThere are many online forums which are a great place for discussion about best practices and application architecture as well as the future of React.\r\n\r\n[https://reactjs.org/community/support.html](https://reactjs.org/community/support.html#popular-discussion-forums)" ]	2020-03-16 07:35:45	2020-03-16 17:39:27	2020-03-16 17:39:27	NONE	null	null	null	I build a html5 project by used react antd-mobil, HashRouter and demand loadind, however the project is not fluent and very dull when i click the return button. ![1](https://user-images.githubusercontent.com/62233145/76733418-c15e5c80-679b-11ea-8d16-e4b4bebb059a.png) ![2](https://user-images.githubusercontent.com/62233145/76733423-c58a7a00-679b-11ea-928b-4cc1e77d8b90.png)	{'url': 'https://api.github.com/repos/facebook/react/issues/18317/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18317/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18316	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18316/labels{/name}	https://api.github.com/repos/facebook/react/issues/18316/comments	https://api.github.com/repos/facebook/react/issues/18316/events	https://github.com/facebook/react/pull/18316	581,739,236	MDExOlB1bGxSZXF1ZXN0Mzg4NzU5MDE5	18,316	improve error message for cross-functional component updates	{'login': 'JoviDeCroock', 'id': 17125876, 'node_id': 'MDQ6VXNlcjE3MTI1ODc2', 'avatar_url': 'https://avatars.githubusercontent.com/u/17125876?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoviDeCroock', 'html_url': 'https://github.com/JoviDeCroock', 'followers_url': 'https://api.github.com/users/JoviDeCroock/followers', 'following_url': 'https://api.github.com/users/JoviDeCroock/following{/other_user}', 'gists_url': 'https://api.github.com/users/JoviDeCroock/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/JoviDeCroock/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/JoviDeCroock/subscriptions', 'organizations_url': 'https://api.github.com/users/JoviDeCroock/orgs', 'repos_url': 'https://api.github.com/users/JoviDeCroock/repos', 'events_url': 'https://api.github.com/users/JoviDeCroock/events{/privacy}', 'received_events_url': 'https://api.github.com/users/JoviDeCroock/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18316/builds/15081) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit e81ae47ebf7feade0db9c6216b48823d8d399379:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[young-surf-sirwb](https://codesandbox.io/s/young-surf-sirwb)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 730389b9d3865cb6d5c85e94b9b66f96e391718e...e81ae47ebf7feade0db9c6216b48823d8d399379</p>\n\n\n \n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| +0.1% \| +0.1% \| 632.84 KB \| 633.62 KB \| 133.34 KB \| 133.51 KB \| UMD_DEV\nreact-art.production.min.js \| 0.0% \| -0.0% \| 106.5 KB \| 106.5 KB \| 32.33 KB \| 32.33 KB \| UMD_PROD\nreact-art.development.js \| +0.1% \| +0.2% \| 537 KB \| 537.76 KB \| 115.67 KB \| 115.84 KB \| NODE_DEV\nreact-art.production.min.js \| 0.0% \| -0.0% \| 71.54 KB \| 71.54 KB \| 21.53 KB \| 21.53 KB \| NODE_PROD\nReactART-dev.js \| +0.1% \| +0.1% \| 598.65 KB \| 599.48 KB \| 125.16 KB \| 125.34 KB \| FB_WWW_DEV\nReactART-prod.js \| 0.0% \| -0.0% \| 242.14 KB \| 242.14 KB \| 41.21 KB \| 41.21 KB \| FB_WWW_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer.development.js \| +0.1% \| +0.1% \| 570.32 KB \| 571.1 KB \| 118.55 KB \| 118.72 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| 0.0% \| -0.0% \| 73.51 KB \| 73.51 KB \| 22.4 KB \| 22.4 KB \| UMD_PROD\nreact-test-renderer-shallow.development.js \| 0.0% \| 0.0% \| 38.39 KB \| 38.39 KB \| 9.29 KB \| 9.29 KB \| UMD_DEV\nreact-test-renderer.development.js \| +0.1% \| +0.1% \| 543.56 KB \| 544.32 KB \| 117.17 KB \| 117.33 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| 0.0% \| -0.0% \| 73.33 KB \| 73.33 KB \| 22.07 KB \| 22.07 KB \| NODE_PROD\nReactTestRenderer-dev.js \| +0.1% \| +0.2% \| 570.91 KB \| 571.74 KB \| 120.4 KB \| 120.59 KB \| FB_WWW_DEV\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| 0.0% \| -0.0% \| 427.69 KB \| 427.69 KB \| 77.63 KB \| 77.63 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.29 KB \| 12.29 KB \| 4.52 KB \| 4.52 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.22 KB \| 58.22 KB \| 14.53 KB \| 14.53 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1013 B \| 1013 B \| 603 B \| 602 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| +0.1% \| 981.76 KB \| 982.59 KB \| 218.17 KB \| 218.36 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| 0.0% \| -0.0% \| 410.04 KB \| 410.04 KB \| 74.52 KB \| 74.52 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nreact-dom.development.js \| +0.1% \| +0.1% \| 902.41 KB \| 903.19 KB \| 198.57 KB \| 198.75 KB \| UMD_DEV\nReactDOMForked-profiling.js \| 0.0% \| -0.0% \| 427.69 KB \| 427.69 KB \| 77.63 KB \| 77.63 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.83 KB \| 135.83 KB \| 34.97 KB \| 34.97 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.15 KB \| 1.15 KB \| 654 B \| 653 B \| NODE_PROD\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 118.25 KB \| 118.25 KB \| 37.99 KB \| 37.99 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.16 KB \| 20.16 KB \| 7.46 KB \| 7.46 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 121.96 KB \| 121.96 KB \| 39.19 KB \| 39.18 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| +0.1% \| +0.1% \| 918.23 KB \| 919.06 KB \| 204.8 KB \| 204.98 KB \| FB_WWW_DEV\nreact-dom.development.js \| +0.1% \| +0.1% \| 858.87 KB \| 859.63 KB \| 196.07 KB \| 196.25 KB \| NODE_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 128.87 KB \| 128.87 KB \| 34.52 KB \| 34.52 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 118.32 KB \| 118.32 KB \| 37.19 KB \| 37.19 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 59.83 KB \| 59.83 KB \| 15.85 KB \| 15.85 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.07 KB \| 20.07 KB \| 7.42 KB \| 7.42 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 3.34 KB \| 3.34 KB \| 1.26 KB \| 1.26 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.43 KB \| 12.43 KB \| 4.59 KB \| 4.59 KB \| UMD_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.17 KB \| 1.17 KB \| 691 B \| 690 B \| UMD_PROD\nReactDOM-dev.js \| +0.1% \| +0.1% \| 981.76 KB \| 982.59 KB \| 218.17 KB \| 218.36 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 139.01 KB \| 139.01 KB \| 35.48 KB \| 35.48 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| -0.0% \| 410.04 KB \| 410.04 KB \| 74.52 KB \| 74.52 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 55.27 KB \| 55.27 KB \| 15.23 KB \| 15.23 KB \| NODE_DEV\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 47.71 KB \| 47.71 KB \| 11.11 KB \| 11.11 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.21 KB \| 55.21 KB \| 14.3 KB \| 14.3 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 650.45 KB \| 651.29 KB \| 140.6 KB \| 140.79 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| 0.0% \| -0.0% \| 267.56 KB \| 267.56 KB \| 46.51 KB \| 46.51 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| -0.0% \| 279.35 KB \| 279.35 KB \| 48.77 KB \| 48.77 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 632.31 KB \| 633.15 KB \| 136.26 KB \| 136.43 KB \| RN_OSS_DEV\nReactFabric-prod.js \| 0.0% \| -0.0% \| 259.54 KB \| 259.54 KB \| 45.04 KB \| 45.04 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| 0.0% \| -0.0% \| 271.34 KB \| 271.34 KB \| 47.28 KB \| 47.28 KB \| RN_OSS_PROFILING\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler-reflection.development.js \| 0.0% \| -0.0% \| 16.24 KB \| 16.24 KB \| 4.96 KB \| 4.96 KB \| NODE_DEV\nreact-reconciler-reflection.production.min.js \| 0.0% \| -0.1% \| 2.8 KB \| 2.8 KB \| 1.2 KB \| 1.2 KB \| NODE_PROD\nreact-reconciler.development.js \| +0.1% \| +0.2% \| 574.5 KB \| 575.25 KB \| 121.31 KB \| 121.5 KB \| NODE_DEV\nreact-reconciler.production.min.js \| 0.0% \| -0.0% \| 76.2 KB \| 76.2 KB \| 22.56 KB \| 22.55 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e81ae47ebf7feade0db9c6216b48823d8d399379\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 730389b9d3865cb6d5c85e94b9b66f96e391718e...e81ae47ebf7feade0db9c6216b48823d8d399379</p>\n\n\n \n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer.development.js \| +0.1% \| +0.1% \| 570.34 KB \| 571.12 KB \| 118.56 KB \| 118.74 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| 0.0% \| -0.0% \| 73.54 KB \| 73.54 KB \| 22.42 KB \| 22.42 KB \| UMD_PROD\nreact-test-renderer-shallow.development.js \| 0.0% \| 0.0% \| 38.4 KB \| 38.4 KB \| 9.3 KB \| 9.3 KB \| UMD_DEV\nreact-test-renderer.development.js \| +0.1% \| +0.1% \| 543.59 KB \| 544.35 KB \| 117.18 KB \| 117.35 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| 0.0% \| -0.0% \| 73.36 KB \| 73.36 KB \| 22.09 KB \| 22.08 KB \| NODE_PROD\nReactTestRenderer-dev.js \| +0.1% \| +0.2% \| 570.92 KB \| 571.75 KB \| 120.41 KB \| 120.59 KB \| FB_WWW_DEV\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 126.57 KB \| 126.57 KB \| 39.59 KB \| 39.59 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nReactDOM-dev.js \| +0.1% \| +0.1% \| 935.88 KB \| 936.72 KB \| 208.26 KB \| 208.46 KB \| FB_WWW_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.3% \| 1.19 KB \| 1.19 KB \| 700 B \| 698 B \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 137.42 KB \| 137.42 KB \| 35.17 KB \| 35.17 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.62 KB \| 20.62 KB \| 7.54 KB \| 7.54 KB \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 130.38 KB \| 130.38 KB \| 34.74 KB \| 34.74 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nreact-dom.development.js \| +0.1% \| +0.1% \| 932.89 KB \| 933.67 KB \| 203.83 KB \| 204.01 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.24 KB \| 58.24 KB \| 14.54 KB \| 14.54 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 122.45 KB \| 122.45 KB \| 39.14 KB \| 39.14 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| +0.1% \| 935.88 KB \| 936.72 KB \| 208.26 KB \| 208.46 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.32 KB \| 10.32 KB \| 3.5 KB \| 3.49 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.34 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 126.28 KB \| 126.28 KB \| 40.39 KB \| 40.39 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| 0.0% \| -0.0% \| 383.62 KB \| 383.62 KB \| 69.79 KB \| 69.79 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 47.01 KB \| 47.01 KB \| 10.93 KB \| 10.93 KB \| FB_WWW_PROD\nreact-dom.development.js \| +0.1% \| +0.1% \| 888.08 KB \| 888.84 KB \| 201.33 KB \| 201.5 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.23 KB \| 55.23 KB \| 14.31 KB \| 14.31 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 122.59 KB \| 122.59 KB \| 38.31 KB \| 38.3 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.16 KB \| 1.16 KB \| 663 B \| 662 B \| NODE_PROD\nReactDOM-prod.js \| 0.0% \| -0.0% \| 383.62 KB \| 383.62 KB \| 69.79 KB \| 69.79 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1 KB \| 1 KB \| 611 B \| 610 B \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 59.84 KB \| 59.84 KB \| 15.86 KB \| 15.86 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.44 KB \| 12.44 KB \| 4.6 KB \| 4.6 KB \| UMD_PROD\nReactDOMTesting-dev.js \| +0.1% \| +0.1% \| 891.57 KB \| 892.41 KB \| 199.31 KB \| 199.49 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| -0.0% \| 377.38 KB \| 377.38 KB \| 68.99 KB \| 68.99 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 55.29 KB \| 55.29 KB \| 15.24 KB \| 15.24 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| -0.0% \| 377.38 KB \| 377.38 KB \| 68.99 KB \| 68.99 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 131.6 KB \| 131.6 KB \| 34.99 KB \| 34.99 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.3 KB \| 12.3 KB \| 4.53 KB \| 4.53 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.94 KB \| 20.94 KB \| 7.65 KB \| 7.65 KB \| NODE_PROD\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactART-dev.js \| +0.1% \| +0.2% \| 570.57 KB \| 571.41 KB \| 119.49 KB \| 119.68 KB \| FB_WWW_DEV\nReactART-prod.js \| 0.0% \| -0.0% \| 233.29 KB \| 233.29 KB \| 39.82 KB \| 39.82 KB \| FB_WWW_PROD\nreact-art.development.js \| +0.1% \| +0.1% \| 653.81 KB \| 654.58 KB \| 137.02 KB \| 137.2 KB \| UMD_DEV\nreact-art.production.min.js \| 0.0% \| -0.0% \| 109.25 KB \| 109.25 KB \| 33.1 KB \| 33.1 KB \| UMD_PROD\nreact-art.development.js \| +0.1% \| +0.1% \| 557.12 KB \| 557.88 KB \| 119.41 KB \| 119.58 KB \| NODE_DEV\nreact-art.production.min.js \| 0.0% \| -0.0% \| 74.24 KB \| 74.24 KB \| 22.26 KB \| 22.25 KB \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 653.17 KB \| 654.01 KB \| 140.95 KB \| 141.14 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| 0.0% \| -0.0% \| 267.71 KB \| 267.71 KB \| 46.54 KB \| 46.54 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| -0.0% \| 279.51 KB \| 279.51 KB \| 48.8 KB \| 48.8 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 632.32 KB \| 633.16 KB \| 136.27 KB \| 136.44 KB \| RN_OSS_DEV\nReactFabric-prod.js \| 0.0% \| -0.0% \| 259.55 KB \| 259.55 KB \| 45.05 KB \| 45.05 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| 0.0% \| -0.0% \| 271.35 KB \| 271.35 KB \| 47.29 KB \| 47.28 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 635.04 KB \| 635.88 KB \| 136.59 KB \| 136.77 KB \| RN_FB_DEV\nReactFabric-prod.js \| 0.0% \| -0.0% \| 259.7 KB \| 259.7 KB \| 45.08 KB \| 45.08 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 650.46 KB \| 651.3 KB \| 140.61 KB \| 140.8 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| 0.0% \| -0.0% \| 271.5 KB \| 271.5 KB \| 47.31 KB \| 47.31 KB \| RN_FB_PROFILING\nReactNativeRenderer-prod.js \| 0.0% \| -0.0% \| 267.57 KB \| 267.57 KB \| 46.51 KB \| 46.51 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| -0.0% \| 279.37 KB \| 279.37 KB \| 48.78 KB \| 48.78 KB \| RN_OSS_PROFILING\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| +0.1% \| +0.1% \| 596.95 KB \| 597.71 KB \| 125.56 KB \| 125.73 KB \| NODE_DEV\nreact-reconciler-reflection.development.js \| 0.0% \| -0.0% \| 16.25 KB \| 16.25 KB \| 4.97 KB \| 4.96 KB \| NODE_DEV\nreact-reconciler.production.min.js \| 0.0% \| -0.0% \| 79.29 KB \| 79.29 KB \| 23.31 KB \| 23.31 KB \| NODE_PROD\nreact-reconciler-reflection.production.min.js \| 0.0% \| -0.2% \| 2.81 KB \| 2.81 KB \| 1.21 KB \| 1.21 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.3%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e81ae47ebf7feade0db9c6216b48823d8d399379\n</p>\n", "Can we use `workInProgress` which is already available locally rather than read current owner?", "@gaearon Thanks for the advice, I had to guard it for Flow tho" ]	2020-03-15 16:33:04	2020-03-16 17:06:19	2020-03-16 17:05:31	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18316', 'html_url': 'https://github.com/facebook/react/pull/18316', 'diff_url': 'https://github.com/facebook/react/pull/18316.diff', 'patch_url': 'https://github.com/facebook/react/pull/18316.patch', 'merged_at': datetime.datetime(2020, 3, 16, 17, 5, 31)}	## Summary This improves the error message used for "cross-functional component updates"	{'url': 'https://api.github.com/repos/facebook/react/issues/18316/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18316/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18315	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18315/labels{/name}	https://api.github.com/repos/facebook/react/issues/18315/comments	https://api.github.com/repos/facebook/react/issues/18315/events	https://github.com/facebook/react/pull/18315	581,716,370	MDExOlB1bGxSZXF1ZXN0Mzg4NzQwMTk5	18,315	Include component stack to invariants	{'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers', 'following_url': 'https://api.github.com/users/bl00mber/following{/other_user}', 'gists_url': 'https://api.github.com/users/bl00mber/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bl00mber/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bl00mber/subscriptions', 'organizations_url': 'https://api.github.com/users/bl00mber/orgs', 'repos_url': 'https://api.github.com/users/bl00mber/repos', 'events_url': 'https://api.github.com/users/bl00mber/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bl00mber/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18315/builds/14953) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 83c372b4fd44a151f1bc5e50922bfd2165618bdd:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[magical-https-5t23x](https://codesandbox.io/s/magical-https-5t23x)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 730389b9d3865cb6d5c85e94b9b66f96e391718e...83c372b4fd44a151f1bc5e50922bfd2165618bdd</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| 0.0% \| 0.0% \| 427.69 KB \| 427.72 KB \| 77.63 KB \| 77.64 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.1% \| 12.29 KB \| 12.29 KB \| 4.52 KB \| 4.52 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.22 KB \| 58.22 KB \| 14.53 KB \| 14.53 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\nReactDOMForked-dev.js \| 0.0% \| 0.0% \| 981.76 KB \| 982.05 KB \| 218.17 KB \| 218.21 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| 0.0% \| 0.0% \| 410.04 KB \| 410.08 KB \| 74.52 KB \| 74.53 KB \| FB_WWW_PROD\nreact-dom.development.js \| 0.0% \| 0.0% \| 902.41 KB \| 902.61 KB \| 198.57 KB \| 198.59 KB \| UMD_DEV\nReactDOMForked-profiling.js \| 0.0% \| 0.0% \| 427.69 KB \| 427.72 KB \| 77.63 KB \| 77.64 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| +0.2% \| +0.2% \| 135.83 KB \| 136.09 KB \| 34.97 KB \| 35.03 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.25 KB \| 118.27 KB \| 37.99 KB \| 37.99 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 20.16 KB \| 20.16 KB \| 7.46 KB \| 7.47 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 121.96 KB \| 121.98 KB \| 39.19 KB \| 39.19 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| 0.0% \| 0.0% \| 918.23 KB \| 918.53 KB \| 204.8 KB \| 204.84 KB \| FB_WWW_DEV\nreact-dom.development.js \| 0.0% \| 0.0% \| 858.87 KB \| 859.08 KB \| 196.07 KB \| 196.09 KB \| NODE_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 390.79 KB \| 390.82 KB \| 71.17 KB \| 71.18 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| +0.2% \| +0.2% \| 128.87 KB \| 129.12 KB \| 34.52 KB \| 34.58 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.32 KB \| 118.34 KB \| 37.19 KB \| 37.19 KB \| NODE_PROD\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 390.79 KB \| 390.82 KB \| 71.17 KB \| 71.18 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 20.07 KB \| 20.07 KB \| 7.42 KB \| 7.42 KB \| NODE_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 122.18 KB \| 122.2 KB \| 38.37 KB \| 38.38 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 1.17 KB \| 1.17 KB \| 691 B \| 692 B \| UMD_PROD\nReactDOM-dev.js \| 0.0% \| 0.0% \| 981.76 KB \| 982.05 KB \| 218.17 KB \| 218.21 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| +0.2% \| +0.2% \| 139.01 KB \| 139.27 KB \| 35.48 KB \| 35.55 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| 0.0% \| 410.04 KB \| 410.08 KB \| 74.52 KB \| 74.53 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 55.27 KB \| 55.27 KB \| 15.23 KB \| 15.23 KB \| NODE_DEV\nReactDOMServer-prod.js \| 0.0% \| 0.0% \| 47.71 KB \| 47.73 KB \| 11.11 KB \| 11.11 KB \| FB_WWW_PROD\nreact-dom-server.node.development.js \| +0.2% \| +0.2% \| 130.09 KB \| 130.33 KB \| 34.77 KB \| 34.84 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 83c372b4fd44a151f1bc5e50922bfd2165618bdd\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 730389b9d3865cb6d5c85e94b9b66f96e391718e...83c372b4fd44a151f1bc5e50922bfd2165618bdd</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.57 KB \| 126.59 KB \| 39.59 KB \| 39.59 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nReactDOM-dev.js \| 0.0% \| 0.0% \| 935.88 KB \| 936.18 KB \| 208.26 KB \| 208.31 KB \| FB_WWW_DEV\nreact-dom-server.browser.development.js \| +0.2% \| +0.2% \| 137.42 KB \| 137.68 KB \| 35.17 KB \| 35.24 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 20.62 KB \| 20.62 KB \| 7.54 KB \| 7.54 KB \| UMD_PROD\nreact-dom-server.browser.development.js \| +0.2% \| +0.2% \| 130.38 KB \| 130.63 KB \| 34.74 KB \| 34.8 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nreact-dom.development.js \| 0.0% \| 0.0% \| 932.89 KB \| 933.1 KB \| 203.83 KB \| 203.85 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.45 KB \| 122.47 KB \| 39.14 KB \| 39.15 KB \| UMD_PROD\nReactDOMForked-dev.js \| 0.0% \| 0.0% \| 935.88 KB \| 936.18 KB \| 208.26 KB \| 208.31 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| +0.2% \| +0.2% \| 138.16 KB \| 138.42 KB \| 35.34 KB \| 35.41 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.28 KB \| 126.3 KB \| 40.39 KB \| 40.39 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| 0.0% \| 0.0% \| 383.62 KB \| 383.65 KB \| 69.79 KB \| 69.8 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 47.01 KB \| 47.02 KB \| 10.93 KB \| 10.93 KB \| FB_WWW_PROD\nreact-dom.development.js \| 0.0% \| 0.0% \| 888.08 KB \| 888.28 KB \| 201.33 KB \| 201.35 KB \| NODE_DEV\nReactDOMForked-profiling.js \| 0.0% \| 0.0% \| 401.21 KB \| 401.24 KB \| 72.83 KB \| 72.84 KB \| FB_WWW_PROFILING\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.59 KB \| 122.61 KB \| 38.31 KB \| 38.31 KB \| NODE_PROD\nReactDOM-prod.js \| 0.0% \| 0.0% \| 383.62 KB \| 383.65 KB \| 69.79 KB \| 69.8 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| 0.0% \| 0.0% \| 401.21 KB \| 401.24 KB \| 72.83 KB \| 72.84 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 59.84 KB \| 59.84 KB \| 15.86 KB \| 15.86 KB \| UMD_DEV\nReactDOMTesting-dev.js \| 0.0% \| 0.0% \| 891.57 KB \| 891.87 KB \| 199.31 KB \| 199.36 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 377.38 KB \| 377.41 KB \| 68.99 KB \| 69 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 55.29 KB \| 55.29 KB \| 15.24 KB \| 15.24 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 377.38 KB \| 377.41 KB \| 68.99 KB \| 69 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| +0.2% \| +0.2% \| 131.6 KB \| 131.84 KB \| 34.99 KB \| 35.06 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.3 KB \| 12.3 KB \| 4.53 KB \| 4.53 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 20.94 KB \| 20.94 KB \| 7.65 KB \| 7.65 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 83c372b4fd44a151f1bc5e50922bfd2165618bdd\n</p>\n", "I was under the impression that we now tack on a component stack to all errors raised during rendering, in a second message that starts \"The above error occurred in the <XYZ /> component:\". Can you post before and after screenshots of the console?", "@sophiebits Yeah this is most likely not relevant\r\n\r\n![Screenshot from 2020-03-20](https://user-images.githubusercontent.com/16987322/77156692-b3714a00-6ac1-11ea-9b6d-4ae6fe0fa5db.png)\r\n", "It is interesting that in your screenshot the \"The above error\" message appears _before_ the actual error. Perhaps related to #18101.\r\n\r\nHowever, given that the stack trace does show up it probably does make sense to leave the behavior as-is. I'll close the original issue too. Sorry to make you spend time on something that didn't end up getting merged, but thank you for the contribution!" ]	2020-03-15 15:25:24	2020-03-23 17:25:32	2020-03-23 17:25:31	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18315', 'html_url': 'https://github.com/facebook/react/pull/18315', 'diff_url': 'https://github.com/facebook/react/pull/18315.diff', 'patch_url': 'https://github.com/facebook/react/pull/18315.patch', 'merged_at': None}	close #11619	{'url': 'https://api.github.com/repos/facebook/react/issues/18315/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18315/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18314	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18314/labels{/name}	https://api.github.com/repos/facebook/react/issues/18314/comments	https://api.github.com/repos/facebook/react/issues/18314/events	https://github.com/facebook/react/issues/18314	581,677,939	MDU6SXNzdWU1ODE2Nzc5Mzk=	18,314	Bug: React-test-renderer error when updating state in act	{'login': 'ahummel25', 'id': 12643871, 'node_id': 'MDQ6VXNlcjEyNjQzODcx', 'avatar_url': 'https://avatars.githubusercontent.com/u/12643871?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ahummel25', 'html_url': 'https://github.com/ahummel25', 'followers_url': 'https://api.github.com/users/ahummel25/followers', 'following_url': 'https://api.github.com/users/ahummel25/following{/other_user}', 'gists_url': 'https://api.github.com/users/ahummel25/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ahummel25/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ahummel25/subscriptions', 'organizations_url': 'https://api.github.com/users/ahummel25/orgs', 'repos_url': 'https://api.github.com/users/ahummel25/repos', 'events_url': 'https://api.github.com/users/ahummel25/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ahummel25/received_events', 'type': 'User', 'site_admin': False}	[{'id': 710400704, 'node_id': 'MDU6TGFiZWw3MTA0MDA3MDQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Test%20Renderer', 'name': 'Component: Test Renderer', 'color': '006b75', 'default': False, 'description': None} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "👀 ", "Hello there! The issue seems to be that Material is using portals, which is complicated in Test Renderer. We're recommending testing without Test Renderer, which you can learn more about here: https://reactjs.org/docs/testing-recipes.html", "This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!" ]	2020-03-15 13:37:21	2024-04-10 17:03:51	2024-04-10 17:03:51	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> React version: 16.13.0 react-test-renderer version: 16.13.0 ## Steps To Reproduce <!-- Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Issues without reproduction steps or code examples may be immediately closed as not actionable. --> Link to code example: [Here](https://codesandbox.io/s/dazzling-kare-nxtfs) is a reproducible link. <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior It's worth noting this example is using material-ui as a dependency. Regardless, I believe the test should still pass. When updating state in my component, a drawer component opens and closes depending on a boolean value. Code works fine in the browser. When running the above test, it fails with a trace error that includes the below. ``` TypeError: parentInstance.children.indexOf is not a function at appendChild (https://psnrk.csb.app/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:720:39) ``` Here I am drilling down to a child anchor tag to access its `onClick` function. As you'll see in the sandbox example, I am passing it a `mockEvent` because the handler first calls `event.preventDefault`. This does not cause any issues. The error occurs when the `setOpen` hook function gets called. Just wanted to point that out. ``` act(() => { tree.root.children[0].props.children.props.children.props.onClick(mockEvent); }); ``` Same error happens when I try to initiate the `onClose` handler of the `Drawer` component: ``` act(() => { tree.root.children[1].props.onClose(mockEvent); }); ``` ## The expected behavior Test should pass. The state should be properly updated in the `onClick` handler or the `onClose` handler and I should be able to make further assertions after that. If this is not the best way to execute a click event with `react-test-renderer` please let me know. I was looking for examples and it seemed like this was the way to do it.	{'url': 'https://api.github.com/repos/facebook/react/issues/18314/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18314/timeline	null	not_planned	false
https://api.github.com/repos/facebook/react/issues/18313	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18313/labels{/name}	https://api.github.com/repos/facebook/react/issues/18313/comments	https://api.github.com/repos/facebook/react/issues/18313/events	https://github.com/facebook/react/issues/18313	581,478,382	MDU6SXNzdWU1ODE0NzgzODI=	18,313	Footer.js:8 Uncaught TypeError: Cannot read property 'title' of undefined in React-redux	{'login': 'sukanyarudra', 'id': 38715249, 'node_id': 'MDQ6VXNlcjM4NzE1MjQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/38715249?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sukanyarudra', 'html_url': 'https://github.com/sukanyarudra', 'followers_url': 'https://api.github.com/users/sukanyarudra/followers', 'following_url': 'https://api.github.com/users/sukanyarudra/following{/other_user}', 'gists_url': 'https://api.github.com/users/sukanyarudra/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sukanyarudra/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sukanyarudra/subscriptions', 'organizations_url': 'https://api.github.com/users/sukanyarudra/orgs', 'repos_url': 'https://api.github.com/users/sukanyarudra/repos', 'events_url': 'https://api.github.com/users/sukanyarudra/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sukanyarudra/received_events', 'type': 'User', 'site_admin': False}	[]	closed	false	null	[]	null	[ "Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:\r\n\r\n##### Coding Questions\r\n\r\nIf you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.\r\n\r\n[https://stackoverflow.com/questions/tagged/react](https://stackoverflow.com/questions/tagged/react)\r\n\r\n##### Talk to other React developers\r\n\r\nThere are many online forums which are a great place for discussion about best practices and application architecture as well as the future of React.\r\n\r\n[https://reactjs.org/community/support.html](https://reactjs.org/community/support.html#popular-discussion-forums)" ]	2020-03-15 02:51:30	2020-03-16 17:40:00	2020-03-16 17:40:00	NONE	null	null	null	I have passed Json object from home component to Footer component, where I am able to access json object but unable to print the properties in json object Home.js class Home extends React.Component { componentDidMount() { this.props.fetchHome() } render() { return ( <div> <Header home = {this.props.header}></Header> <Footer footer = {this.props.footer}></Footer> </div> ); } } const mapStateToProps = state => { return { header:{ class:state.home.headerClass, logo:state.home.logoHeader }, footer: state.home.footer }; } Footer.js const footer = (props) => { console.log((props.footer)); return <div>footer</div> } export default footer; where I am able to see the props.footer object in the console console.log((props.footer)) but while trying to fetch the properties from footer object getting an error console.log((props.footer.title)); Footer.js:8 Uncaught TypeError: Cannot read property 'title' of undefined	{'url': 'https://api.github.com/repos/facebook/react/issues/18313/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18313/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18312	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18312/labels{/name}	https://api.github.com/repos/facebook/react/issues/18312/comments	https://api.github.com/repos/facebook/react/issues/18312/events	https://github.com/facebook/react/issues/18312	581,311,172	MDU6SXNzdWU1ODEzMTExNzI=	18,312	Bug: react-refresh silently fails if version does not match react version	{'login': 'lilactown', 'id': 2687140, 'node_id': 'MDQ6VXNlcjI2ODcxNDA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2687140?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lilactown', 'html_url': 'https://github.com/lilactown', 'followers_url': 'https://api.github.com/users/lilactown/followers', 'following_url': 'https://api.github.com/users/lilactown/following{/other_user}', 'gists_url': 'https://api.github.com/users/lilactown/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lilactown/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lilactown/subscriptions', 'organizations_url': 'https://api.github.com/users/lilactown/orgs', 'repos_url': 'https://api.github.com/users/lilactown/repos', 'events_url': 'https://api.github.com/users/lilactown/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lilactown/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "It was added with 16.10 (or maybe 16.9). I don’t anticipate this being a problem going forward. ", "I'll verify this with the latest React version soon and re-open if I can reproduce it." ]	2020-03-14 18:09:11	2020-03-25 16:32:23	2020-03-25 16:32:23	NONE	null	null	null	Currently, each `react-refresh` package version requires a specific version of the `react` package (the exact correspondence I'm not sure about). Installing the latest version of `react` (16.3) and an older version of `react-refresh` (e.g. 0.6) causes react-refresh to silently fail; the app will not hot reload, no errors or warnings are shown. This often occurs when working on a project that uses react-refresh, upgrading `react` and forgetting to update `react-refresh`. React version: 16.x ## Steps To Reproduce 1. Install `react@16.13` and `react-refresh@0.6` 2. Try to use react-refresh's hot reloading feature. ## The current behavior Hot reloading silently fails, does nothing. ## The expected behavior A warning either at install time or runtime would alert the user that mismatched versions of react-refresh and react are installed.	{'url': 'https://api.github.com/repos/facebook/react/issues/18312/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18312/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18311	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18311/labels{/name}	https://api.github.com/repos/facebook/react/issues/18311/comments	https://api.github.com/repos/facebook/react/issues/18311/events	https://github.com/facebook/react/issues/18311	581,244,010	MDU6SXNzdWU1ODEyNDQwMTA=	18,311	Bug: set same state trigger when click	{'login': 'shaodahong', 'id': 14831261, 'node_id': 'MDQ6VXNlcjE0ODMxMjYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/14831261?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shaodahong', 'html_url': 'https://github.com/shaodahong', 'followers_url': 'https://api.github.com/users/shaodahong/followers', 'following_url': 'https://api.github.com/users/shaodahong/following{/other_user}', 'gists_url': 'https://api.github.com/users/shaodahong/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/shaodahong/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/shaodahong/subscriptions', 'organizations_url': 'https://api.github.com/users/shaodahong/orgs', 'repos_url': 'https://api.github.com/users/shaodahong/repos', 'events_url': 'https://api.github.com/users/shaodahong/events{/privacy}', 'received_events_url': 'https://api.github.com/users/shaodahong/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "https://reactjs.org/docs/hooks-reference.html#functional-updates\r\n\r\n> If your update function returns the exact same value as the current state, the subsequent rerender will be skipped completely.\r\n\r\nThis is the official description\r\n\r\n", "CodeSandbox uses StrictMode by default in which renders a called twice. You can remove it from the index.js in your codesandbox\r\n\r\n```diff\r\nReactDOM.render(\r\n- <React.StrictMode>\r\n <App />\r\n- </React.StrictMode>,\r\n rootElement\r\n);\r\n```", "> CodeSandbox uses StrictMode by default in which renders a called twice. You can remove it from the index.js in your codesandbox\r\n> \r\n> ```diff\r\n> ReactDOM.render(\r\n> - <React.StrictMode>\r\n> <App />\r\n> - </React.StrictMode>,\r\n> rootElement\r\n> );\r\n> ```\r\n\r\n\r\nNot for this reason", "1) The first click, Fiber `expirationTime` is `noWork`(default), but hook queue state change, so exec `scheduleWork` and update Fiber `expirationTime`(`Sync`)\r\n\r\n2) The second click Fiber `expirationTime` is Sync, so exec `scheduleWork` and reset Fiber `expirationTime`(`noWork`)\r\n\r\n3) The third click Fiber is `noWork` and hook queue state equal, return\r\n\r\nImportant the second click\r\n\r\nno judgment hook state and call directly `scheduleWork`", "See my answer here.\r\nhttps://stackoverflow.com/a/60919619/458193" ]	2020-03-14 15:03:48	2020-03-30 15:22:10	2020-03-30 15:22:10	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> React version: 16.12.0 ## Steps To Reproduce 1. Open chrome console panel 2. Click document 3. View logs <!-- Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Issues without reproduction steps or code examples may be immediately closed as not actionable. --> Link to code example: https://codesandbox.io/s/always-two-renders-861qp ![Kapture 2020-03-14 at 22 59 11](https://user-images.githubusercontent.com/14831261/76684509-79c6bc00-6647-11ea-9db8-e49375d2ec11.gif) <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior whatever click more times, always log two times In my see, if state not change, should not render, I don't know reason if it's related to this https://github.com/facebook/react/issues/16387#issuecomment-521623662 ## The expected behavior always log one time	{'url': 'https://api.github.com/repos/facebook/react/issues/18311/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18311/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18310	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18310/labels{/name}	https://api.github.com/repos/facebook/react/issues/18310/comments	https://api.github.com/repos/facebook/react/issues/18310/events	https://github.com/facebook/react/issues/18310	581,055,231	MDU6SXNzdWU1ODEwNTUyMzE=	18,310	ReactJS [issue on production] - TypeError: (void 0) is not a functionBug	{'login': 'mahendrakulkarni177', 'id': 16331616, 'node_id': 'MDQ6VXNlcjE2MzMxNjE2', 'avatar_url': 'https://avatars.githubusercontent.com/u/16331616?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mahendrakulkarni177', 'html_url': 'https://github.com/mahendrakulkarni177', 'followers_url': 'https://api.github.com/users/mahendrakulkarni177/followers', 'following_url': 'https://api.github.com/users/mahendrakulkarni177/following{/other_user}', 'gists_url': 'https://api.github.com/users/mahendrakulkarni177/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/mahendrakulkarni177/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/mahendrakulkarni177/subscriptions', 'organizations_url': 'https://api.github.com/users/mahendrakulkarni177/orgs', 'repos_url': 'https://api.github.com/users/mahendrakulkarni177/repos', 'events_url': 'https://api.github.com/users/mahendrakulkarni177/events{/privacy}', 'received_events_url': 'https://api.github.com/users/mahendrakulkarni177/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "We need to see a reproducing example. This is too little information, and there are no signs the error is actually coming from React.", "Thanks for your response, @gaearon issue was because of ```office-ui-fabric-react``` version got updated and I was using an older version, the issue got resolve :) \r\nAlso updated React and React-Dom next version." ]	2020-03-14 05:52:17	2020-03-17 05:24:56	2020-03-17 05:24:56	NONE	null	null	null	![image](https://user-images.githubusercontent.com/16331616/76676066-d8f3e480-65e5-11ea-88aa-270dbd274096.png) I'm facing the above error on production build, not even getting the issue reference... your help will really be appreciated, Thanks in advance. Note - on local, it works fine - development mode, but the same code won't work on a production. React js version is - 16.12.0, and webpack version - 4.41.6 Also tried to downgrade the versions still getting the same error	{'url': 'https://api.github.com/repos/facebook/react/issues/18310/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18310/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18309	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18309/labels{/name}	https://api.github.com/repos/facebook/react/issues/18309/comments	https://api.github.com/repos/facebook/react/issues/18309/events	https://github.com/facebook/react/pull/18309	580,944,490	MDExOlB1bGxSZXF1ZXN0Mzg4MDcxOTYx	18,309	Replace passive effect context with boolean	{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18309/builds/14744) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit c2aafa7b49eb74c39e55ab40ac1c4eedbfb6cb2c:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[vigorous-dawn-8sqsr](https://codesandbox.io/s/vigorous-dawn-8sqsr)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c2aafa7b49eb74c39e55ab40ac1c4eedbfb6cb2c\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c2aafa7b49eb74c39e55ab40ac1c4eedbfb6cb2c\n</p>\n" ]	2020-03-14 00:07:00	2020-03-16 17:13:52	2020-03-16 16:56:44	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18309', 'html_url': 'https://github.com/facebook/react/pull/18309', 'diff_url': 'https://github.com/facebook/react/pull/18309.diff', 'patch_url': 'https://github.com/facebook/react/pull/18309.patch', 'merged_at': datetime.datetime(2020, 3, 16, 16, 56, 44)}	Follow up to #18307	{'url': 'https://api.github.com/repos/facebook/react/issues/18309/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18309/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18308	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18308/labels{/name}	https://api.github.com/repos/facebook/react/issues/18308/comments	https://api.github.com/repos/facebook/react/issues/18308/events	https://github.com/facebook/react/pull/18308	580,871,751	MDExOlB1bGxSZXF1ZXN0Mzg4MDA1NzY4	18,308	React Event System: Refactor ElementListenerMap for upgrading	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18308/builds/15226) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 1e68634521c01faa70bd818209eadc1971686110:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[gallant-bush-m8qvg](https://codesandbox.io/s/gallant-bush-m8qvg)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 3a0076e0e8ee0e30f90b11a280539c8b1999fe5b...1e68634521c01faa70bd818209eadc1971686110</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| +0.1% \| 126.59 KB \| 126.65 KB \| 39.59 KB \| 39.61 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.2% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nReactDOM-dev.js \| +0.1% \| +0.1% \| 937.29 KB \| 938.38 KB \| 208.65 KB \| 208.8 KB \| FB_WWW_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.3% \| 1.19 KB \| 1.19 KB \| 698 B \| 700 B \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 137.42 KB \| 137.42 KB \| 35.17 KB \| 35.17 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.62 KB \| 20.62 KB \| 7.54 KB \| 7.54 KB \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 130.38 KB \| 130.38 KB \| 34.74 KB \| 34.74 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nreact-dom.development.js \| 0.0% \| -0.0% \| 934.26 KB \| 934.42 KB \| 204.19 KB \| 204.19 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 58.24 KB \| 58.24 KB \| 14.54 KB \| 14.54 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.46 KB \| 122.52 KB \| 39.15 KB \| 39.15 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| +0.1% \| 937.29 KB \| 938.38 KB \| 208.65 KB \| 208.8 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.32 KB \| 10.32 KB \| 3.5 KB \| 3.5 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.35 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| +0.1% \| 126.29 KB \| 126.35 KB \| 40.39 KB \| 40.41 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 383.67 KB \| 384.63 KB \| 69.81 KB \| 69.98 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| 0.0% \| 47.01 KB \| 47.01 KB \| 10.93 KB \| 10.93 KB \| FB_WWW_PROD\nreact-dom.development.js \| 0.0% \| -0.0% \| 889.4 KB \| 889.54 KB \| 201.67 KB \| 201.67 KB \| NODE_DEV\nReactDOMForked-profiling.js \| +0.2% \| +0.2% \| 401.26 KB \| 402.22 KB \| 72.84 KB \| 73.01 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 55.23 KB \| 55.23 KB \| 14.31 KB \| 14.31 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.2% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 122.61 KB \| 122.67 KB \| 38.31 KB \| 38.33 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| :small_red_triangle:+0.3% \| 1.16 KB \| 1.16 KB \| 662 B \| 664 B \| NODE_PROD\nReactDOM-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 383.67 KB \| 384.63 KB \| 69.81 KB \| 69.98 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| +0.2% \| +0.2% \| 401.26 KB \| 402.22 KB \| 72.84 KB \| 73.01 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.2% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.5% \| 1 KB \| 1 KB \| 609 B \| 612 B \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 59.84 KB \| 59.84 KB \| 15.86 KB \| 15.86 KB \| UMD_DEV\nReactDOMTesting-dev.js \| 0.0% \| 0.0% \| 892.98 KB \| 893.32 KB \| 199.68 KB \| 199.7 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 377.43 KB \| 377.88 KB \| 69 KB \| 69.09 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 55.29 KB \| 55.29 KB \| 15.24 KB \| 15.24 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| +0.1% \| +0.1% \| 377.43 KB \| 377.88 KB \| 69 KB \| 69.09 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| 0.0% \| 131.6 KB \| 131.6 KB \| 34.99 KB \| 34.99 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 12.3 KB \| 12.3 KB \| 4.53 KB \| 4.53 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| 0.0% \| 20.94 KB \| 20.94 KB \| 7.65 KB \| 7.65 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: :small_red_triangle:+0.3%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1e68634521c01faa70bd818209eadc1971686110\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 3a0076e0e8ee0e30f90b11a280539c8b1999fe5b...1e68634521c01faa70bd818209eadc1971686110</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| +0.2% \| +0.3% \| 427.74 KB \| 428.7 KB \| 77.65 KB \| 77.85 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 12.29 KB \| 12.29 KB \| 4.52 KB \| 4.52 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 58.22 KB \| 58.22 KB \| 14.53 KB \| 14.53 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.5% \| 1013 B \| 1013 B \| 601 B \| 604 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| +0.1% \| 983.17 KB \| 984.25 KB \| 218.54 KB \| 218.71 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.3% \| 410.1 KB \| 411.06 KB \| 74.54 KB \| 74.74 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nreact-dom.development.js \| 0.0% \| -0.0% \| 903.77 KB \| 903.94 KB \| 198.93 KB \| 198.92 KB \| UMD_DEV\nReactDOMForked-profiling.js \| +0.2% \| +0.3% \| 427.74 KB \| 428.7 KB \| 77.65 KB \| 77.85 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 135.83 KB \| 135.83 KB \| 34.97 KB \| 34.97 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| :small_red_triangle:+0.3% \| 1.15 KB \| 1.15 KB \| 653 B \| 655 B \| NODE_PROD\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 118.26 KB \| 118.32 KB \| 37.98 KB \| 37.98 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.16 KB \| 20.16 KB \| 7.46 KB \| 7.46 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 121.97 KB \| 122.03 KB \| 39.18 KB \| 39.2 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| 0.0% \| 0.0% \| 919.64 KB \| 919.97 KB \| 205.17 KB \| 205.2 KB \| FB_WWW_DEV\nreact-dom.development.js \| 0.0% \| -0.0% \| 860.19 KB \| 860.34 KB \| 196.43 KB \| 196.42 KB \| NODE_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 390.84 KB \| 391.29 KB \| 71.18 KB \| 71.26 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 128.87 KB \| 128.87 KB \| 34.52 KB \| 34.52 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 118.34 KB \| 118.4 KB \| 37.19 KB \| 37.22 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 59.83 KB \| 59.83 KB \| 15.85 KB \| 15.85 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| +0.1% \| +0.1% \| 390.84 KB \| 391.29 KB \| 71.18 KB \| 71.26 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.07 KB \| 20.07 KB \| 7.42 KB \| 7.42 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.2% \| 3.34 KB \| 3.34 KB \| 1.26 KB \| 1.26 KB \| UMD_DEV\nreact-dom.profiling.min.js \| 0.0% \| +0.1% \| 122.2 KB \| 122.25 KB \| 38.39 KB \| 38.42 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.4% \| 1.17 KB \| 1.17 KB \| 689 B \| 692 B \| UMD_PROD\nReactDOM-dev.js \| +0.1% \| +0.1% \| 983.17 KB \| 984.25 KB \| 218.54 KB \| 218.71 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 139.01 KB \| 139.01 KB \| 35.48 KB \| 35.48 KB \| FB_WWW_DEV\nReactDOM-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.3% \| 410.1 KB \| 411.06 KB \| 74.54 KB \| 74.74 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 55.27 KB \| 55.27 KB \| 15.23 KB \| 15.23 KB \| NODE_DEV\nReactDOMServer-prod.js \| 0.0% \| 0.0% \| 47.71 KB \| 47.71 KB \| 11.11 KB \| 11.11 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.2% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 55.21 KB \| 55.21 KB \| 14.3 KB \| 14.3 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| 0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| 0.0% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: :small_red_triangle:+0.1%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1e68634521c01faa70bd818209eadc1971686110\n</p>\n" ]	2020-03-13 21:41:00	2020-03-18 00:15:56	2020-03-18 00:15:51	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18308', 'html_url': 'https://github.com/facebook/react/pull/18308', 'diff_url': 'https://github.com/facebook/react/pull/18308.diff', 'patch_url': 'https://github.com/facebook/react/pull/18308.patch', 'merged_at': datetime.datetime(2020, 3, 18, 0, 15, 51)}	This PR refactors the `ElementListenerMap` properties of the existing modern event system, React Flare responder system and the legacy event systems. They all use `ElementListenerMap` to register an event type against a container. Unfortunately, they don't have a way of co-ordinating when event listeners should be "upgraded" – which is the process of removing and passive/default listener and adding an active listener. There are three states for event listeners and their `passive` flag. They can be `true`, `false` or `void`. If they are `true`, then the listener is passive. If they are `false` then the listener is active and finally, if they are `void` then we use the browser default and we don't specify an option value for `passive` when creating the listener via `addEventListener`. To wire all this up, we have to unify the value of `ElementListenerMap`, so that it's an object telling us of the last previously used `passive` value. We represent this as `{ passive: void \| boolean, listener: any => void }`. The upgrade order should go from `passive (true) -> default (void) -> active (false)`. Now we have this refactor in place, it makes it possible for the modern event system and the work going into `useEvent` to live together nicely and have a nice optimial system where they can share event listeners together. For Flare, we change the pattern so it uses the new format, but it really doesn't affect the others as Flare will soon be removed, so we keep the `ElementListenerMap` keys different (they have a `_active`/`_passive` suffixes to not clash with the legacy/modern event system listeners).	{'url': 'https://api.github.com/repos/facebook/react/issues/18308/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18308/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18307	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18307/labels{/name}	https://api.github.com/repos/facebook/react/issues/18307/comments	https://api.github.com/repos/facebook/react/issues/18307/events	https://github.com/facebook/react/pull/18307	580,868,249	MDExOlB1bGxSZXF1ZXN0Mzg4MDAyNTQz	18,307	Warn against state updates from useEffect destroy functions	{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18307/builds/14725) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit e1935d1a86c78823b55530bda413a1f8acbeec31:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[long-breeze-fzhcc](https://codesandbox.io/s/long-breeze-fzhcc)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 0705b7282f9c52ce85b6125ebbe32f6a6abf01a4...e1935d1a86c78823b55530bda413a1f8acbeec31</p>\n\n\n \n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer.development.js \| +0.1% \| +0.1% \| 569.8 KB \| 570.34 KB \| 118.48 KB \| 118.56 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| 0.0% \| 0.0% \| 73.53 KB \| 73.54 KB \| 22.41 KB \| 22.42 KB \| UMD_PROD\nreact-test-renderer-shallow.production.min.js \| 0.0% \| -0.0% \| 12.92 KB \| 12.92 KB \| 3.95 KB \| 3.94 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.1% \| +0.1% \| 543.06 KB \| 543.59 KB \| 117.1 KB \| 117.18 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| 0.0% \| 0.0% \| 73.34 KB \| 73.36 KB \| 22.08 KB \| 22.08 KB \| NODE_PROD\nReactTestRenderer-dev.js \| +0.1% \| +0.1% \| 570.31 KB \| 570.92 KB \| 120.33 KB \| 120.4 KB \| FB_WWW_DEV\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.56 KB \| 126.57 KB \| 39.58 KB \| 39.59 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nReactDOM-dev.js \| +0.1% \| 0.0% \| 935.28 KB \| 935.88 KB \| 208.17 KB \| 208.26 KB \| FB_WWW_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.19 KB \| 1.19 KB \| 700 B \| 699 B \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 137.42 KB \| 137.42 KB \| 35.17 KB \| 35.17 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.62 KB \| 20.62 KB \| 7.54 KB \| 7.54 KB \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 130.38 KB \| 130.38 KB \| 34.74 KB \| 34.74 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nreact-dom.development.js \| +0.1% \| 0.0% \| 932.35 KB \| 932.89 KB \| 203.75 KB \| 203.83 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.24 KB \| 58.24 KB \| 14.54 KB \| 14.54 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.43 KB \| 122.45 KB \| 39.14 KB \| 39.14 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| 0.0% \| 935.28 KB \| 935.88 KB \| 208.17 KB \| 208.26 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.34 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.26 KB \| 126.28 KB \| 40.38 KB \| 40.39 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| 0.0% \| 0.0% \| 383.55 KB \| 383.62 KB \| 69.78 KB \| 69.79 KB \| FB_WWW_PROD\nreact-dom.development.js \| +0.1% \| 0.0% \| 887.55 KB \| 888.08 KB \| 201.24 KB \| 201.33 KB \| NODE_DEV\nReactDOMForked-profiling.js \| 0.0% \| 0.0% \| 401.13 KB \| 401.21 KB \| 72.81 KB \| 72.83 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.23 KB \| 55.23 KB \| 14.31 KB \| 14.31 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.58 KB \| 122.59 KB \| 38.3 KB \| 38.3 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nReactDOM-prod.js \| 0.0% \| 0.0% \| 383.55 KB \| 383.62 KB \| 69.78 KB \| 69.79 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| 0.0% \| 0.0% \| 401.13 KB \| 401.21 KB \| 72.81 KB \| 72.83 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1 KB \| 1 KB \| 611 B \| 610 B \| NODE_PROD\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.44 KB \| 12.44 KB \| 4.6 KB \| 4.6 KB \| UMD_PROD\nReactDOMTesting-dev.js \| +0.1% \| 0.0% \| 890.97 KB \| 891.57 KB \| 199.22 KB \| 199.31 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 377.3 KB \| 377.38 KB \| 68.98 KB \| 68.99 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 55.29 KB \| 55.29 KB \| 15.24 KB \| 15.24 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 377.3 KB \| 377.38 KB \| 68.98 KB \| 68.99 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 131.6 KB \| 131.6 KB \| 34.99 KB \| 34.99 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.3 KB \| 12.3 KB \| 4.53 KB \| 4.53 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.94 KB \| 20.94 KB \| 7.65 KB \| 7.65 KB \| NODE_PROD\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactART-dev.js \| +0.1% \| +0.1% \| 569.97 KB \| 570.57 KB \| 119.42 KB \| 119.49 KB \| FB_WWW_DEV\nReactART-prod.js \| 0.0% \| 0.0% \| 233.22 KB \| 233.29 KB \| 39.81 KB \| 39.82 KB \| FB_WWW_PROD\nreact-art.development.js \| +0.1% \| +0.1% \| 653.26 KB \| 653.81 KB \| 136.93 KB \| 137.02 KB \| UMD_DEV\nreact-art.production.min.js \| 0.0% \| 0.0% \| 109.24 KB \| 109.25 KB \| 33.09 KB \| 33.1 KB \| UMD_PROD\nreact-art.development.js \| +0.1% \| +0.1% \| 556.6 KB \| 557.12 KB \| 119.32 KB \| 119.41 KB \| NODE_DEV\nreact-art.production.min.js \| 0.0% \| 0.0% \| 74.23 KB \| 74.24 KB \| 22.25 KB \| 22.25 KB \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 652.57 KB \| 653.17 KB \| 140.86 KB \| 140.95 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| 0.0% \| 0.0% \| 267.64 KB \| 267.71 KB \| 46.53 KB \| 46.54 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| 0.0% \| 279.44 KB \| 279.51 KB \| 48.78 KB \| 48.8 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 631.72 KB \| 632.32 KB \| 136.18 KB \| 136.27 KB \| RN_OSS_DEV\nReactFabric-prod.js \| 0.0% \| 0.0% \| 259.48 KB \| 259.55 KB \| 45.03 KB \| 45.05 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| 0.0% \| 0.0% \| 271.28 KB \| 271.35 KB \| 47.27 KB \| 47.28 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 634.43 KB \| 635.04 KB \| 136.51 KB \| 136.59 KB \| RN_FB_DEV\nReactFabric-prod.js \| 0.0% \| 0.0% \| 259.63 KB \| 259.7 KB \| 45.06 KB \| 45.08 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 649.86 KB \| 650.46 KB \| 140.53 KB \| 140.61 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| 0.0% \| 0.0% \| 271.43 KB \| 271.5 KB \| 47.3 KB \| 47.31 KB \| RN_FB_PROFILING\nReactNativeRenderer-prod.js \| 0.0% \| 0.0% \| 267.5 KB \| 267.57 KB \| 46.5 KB \| 46.51 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| 0.0% \| 279.3 KB \| 279.37 KB \| 48.76 KB \| 48.78 KB \| RN_OSS_PROFILING\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| +0.1% \| +0.1% \| 596.42 KB \| 596.95 KB \| 125.46 KB \| 125.55 KB \| NODE_DEV\nreact-reconciler-reflection.development.js \| 0.0% \| -0.0% \| 16.25 KB \| 16.25 KB \| 4.97 KB \| 4.97 KB \| NODE_DEV\nreact-reconciler.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 79.28 KB \| 79.29 KB \| 23.3 KB \| 23.31 KB \| NODE_PROD\nreact-reconciler-reflection.production.min.js \| 0.0% \| -0.1% \| 2.81 KB \| 2.81 KB \| 1.21 KB \| 1.21 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.1%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e1935d1a86c78823b55530bda413a1f8acbeec31\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 0705b7282f9c52ce85b6125ebbe32f6a6abf01a4...e1935d1a86c78823b55530bda413a1f8acbeec31</p>\n\n\n \n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| +0.1% \| +0.1% \| 632.3 KB \| 632.84 KB \| 133.25 KB \| 133.34 KB \| UMD_DEV\nreact-art.production.min.js \| 0.0% \| 0.0% \| 106.48 KB \| 106.5 KB \| 32.32 KB \| 32.33 KB \| UMD_PROD\nreact-art.development.js \| +0.1% \| +0.1% \| 536.47 KB \| 537 KB \| 115.58 KB \| 115.67 KB \| NODE_DEV\nreact-art.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 71.53 KB \| 71.54 KB \| 21.52 KB \| 21.53 KB \| NODE_PROD\nReactART-dev.js \| +0.1% \| +0.1% \| 598.04 KB \| 598.65 KB \| 125.07 KB \| 125.16 KB \| FB_WWW_DEV\nReactART-prod.js \| 0.0% \| 0.0% \| 242.07 KB \| 242.14 KB \| 41.19 KB \| 41.21 KB \| FB_WWW_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer.development.js \| +0.1% \| +0.1% \| 569.78 KB \| 570.32 KB \| 118.47 KB \| 118.54 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| 0.0% \| 0.0% \| 73.5 KB \| 73.51 KB \| 22.39 KB \| 22.4 KB \| UMD_PROD\nreact-test-renderer-shallow.production.min.js \| 0.0% \| -0.0% \| 12.91 KB \| 12.91 KB \| 3.94 KB \| 3.94 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.1% \| +0.1% \| 543.04 KB \| 543.56 KB \| 117.08 KB \| 117.17 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| 0.0% \| 0.0% \| 73.32 KB \| 73.33 KB \| 22.06 KB \| 22.07 KB \| NODE_PROD\nReactTestRenderer-dev.js \| +0.1% \| +0.1% \| 570.3 KB \| 570.91 KB \| 120.32 KB \| 120.4 KB \| FB_WWW_DEV\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| 0.0% \| 0.0% \| 427.62 KB \| 427.69 KB \| 77.61 KB \| 77.63 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.29 KB \| 12.29 KB \| 4.52 KB \| 4.52 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.22 KB \| 58.22 KB \| 14.53 KB \| 14.53 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1013 B \| 1013 B \| 603 B \| 602 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| 0.0% \| 981.15 KB \| 981.76 KB \| 218.07 KB \| 218.17 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| 0.0% \| 0.0% \| 409.97 KB \| 410.04 KB \| 74.5 KB \| 74.52 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nreact-dom.development.js \| +0.1% \| 0.0% \| 901.87 KB \| 902.41 KB \| 198.48 KB \| 198.57 KB \| UMD_DEV\nReactDOMForked-profiling.js \| 0.0% \| 0.0% \| 427.62 KB \| 427.69 KB \| 77.61 KB \| 77.63 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.83 KB \| 135.83 KB \| 34.97 KB \| 34.97 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 118.23 KB \| 118.25 KB \| 37.97 KB \| 37.99 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.16 KB \| 20.16 KB \| 7.46 KB \| 7.46 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 121.94 KB \| 121.96 KB \| 39.18 KB \| 39.19 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| +0.1% \| 0.0% \| 917.62 KB \| 918.23 KB \| 204.72 KB \| 204.8 KB \| FB_WWW_DEV\nreact-dom.development.js \| +0.1% \| 0.0% \| 858.35 KB \| 858.87 KB \| 195.99 KB \| 196.07 KB \| NODE_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 390.72 KB \| 390.79 KB \| 71.16 KB \| 71.17 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 128.87 KB \| 128.87 KB \| 34.52 KB \| 34.52 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.31 KB \| 118.32 KB \| 37.18 KB \| 37.19 KB \| NODE_PROD\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 390.72 KB \| 390.79 KB \| 71.16 KB \| 71.17 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.07 KB \| 20.07 KB \| 7.42 KB \| 7.42 KB \| NODE_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 122.17 KB \| 122.18 KB \| 38.37 KB \| 38.37 KB \| NODE_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.43 KB \| 12.43 KB \| 4.59 KB \| 4.59 KB \| UMD_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.17 KB \| 1.17 KB \| 692 B \| 691 B \| UMD_PROD\nReactDOM-dev.js \| +0.1% \| 0.0% \| 981.15 KB \| 981.76 KB \| 218.07 KB \| 218.17 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 139.01 KB \| 139.01 KB \| 35.48 KB \| 35.48 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| 0.0% \| 409.97 KB \| 410.04 KB \| 74.5 KB \| 74.52 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.21 KB \| 55.21 KB \| 14.3 KB \| 14.3 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 649.85 KB \| 650.45 KB \| 140.52 KB \| 140.6 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| 0.0% \| 0.0% \| 267.49 KB \| 267.56 KB \| 46.49 KB \| 46.51 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| 0.0% \| 279.28 KB \| 279.35 KB \| 48.75 KB \| 48.77 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 631.71 KB \| 632.31 KB \| 136.17 KB \| 136.26 KB \| RN_OSS_DEV\nReactFabric-prod.js \| 0.0% \| 0.0% \| 259.47 KB \| 259.54 KB \| 45.02 KB \| 45.04 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| 0.0% \| 0.0% \| 271.26 KB \| 271.34 KB \| 47.26 KB \| 47.28 KB \| RN_OSS_PROFILING\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler-reflection.development.js \| 0.0% \| -0.0% \| 16.24 KB \| 16.24 KB \| 4.96 KB \| 4.96 KB \| NODE_DEV\nreact-reconciler-reflection.production.min.js \| 0.0% \| -0.2% \| 2.8 KB \| 2.8 KB \| 1.2 KB \| 1.2 KB \| NODE_PROD\nreact-reconciler.development.js \| +0.1% \| +0.1% \| 573.97 KB \| 574.5 KB \| 121.23 KB \| 121.31 KB \| NODE_DEV\nreact-reconciler.production.min.js \| 0.0% \| 0.0% \| 76.19 KB \| 76.2 KB \| 22.55 KB \| 22.56 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e1935d1a86c78823b55530bda413a1f8acbeec31\n</p>\n" ]	2020-03-13 21:35:33	2020-03-14 00:07:28	2020-03-13 22:33:51	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18307', 'html_url': 'https://github.com/facebook/react/pull/18307', 'diff_url': 'https://github.com/facebook/react/pull/18307.diff', 'patch_url': 'https://github.com/facebook/react/pull/18307.patch', 'merged_at': datetime.datetime(2020, 3, 13, 22, 33, 51)}	Add clearer warning text for the specific case of updating state from within a passive effect's destroy function. Also fixed a broken conditional that was preventing some of these tests from running after the recent test/variant refactor.	{'url': 'https://api.github.com/repos/facebook/react/issues/18307/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18307/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18306	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18306/labels{/name}	https://api.github.com/repos/facebook/react/issues/18306/comments	https://api.github.com/repos/facebook/react/issues/18306/events	https://github.com/facebook/react/pull/18306	580,798,924	MDExOlB1bGxSZXF1ZXN0Mzg3OTQxNDk0	18,306	Warn if stringifying an attribute takes too long	{'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers', 'following_url': 'https://api.github.com/users/bl00mber/following{/other_user}', 'gists_url': 'https://api.github.com/users/bl00mber/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bl00mber/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bl00mber/subscriptions', 'organizations_url': 'https://api.github.com/users/bl00mber/orgs', 'repos_url': 'https://api.github.com/users/bl00mber/repos', 'events_url': 'https://api.github.com/users/bl00mber/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bl00mber/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18306/builds/14716) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 4510330d8893c0ef8d648a7029cfed9c01a1faf8:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[great-hopper-w6s1m](https://codesandbox.io/s/great-hopper-w6s1m)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 73ff8b9094f9061c097d7f58fb4b02a90fa6f107...4510330d8893c0ef8d648a7029cfed9c01a1faf8</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-dev.js \| +0.1% \| +0.1% \| 935.08 KB \| 936 KB \| 208.11 KB \| 208.36 KB \| FB_WWW_DEV\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 130.38 KB \| 130.38 KB \| 34.74 KB \| 34.74 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nreact-dom.development.js \| +0.1% \| +0.1% \| 932.42 KB \| 933.35 KB \| 203.78 KB \| 204.03 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.42 KB \| 122.42 KB \| 39.14 KB \| 39.14 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| +0.1% \| 935.08 KB \| 936 KB \| 208.11 KB \| 208.36 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.32 KB \| 10.32 KB \| 3.5 KB \| 3.49 KB \| UMD_PROD\nReactDOMForked-prod.js \| 0.0% \| -0.0% \| 383.18 KB \| 383.18 KB \| 69.71 KB \| 69.71 KB \| FB_WWW_PROD\nreact-dom.development.js \| +0.1% \| +0.1% \| 887.61 KB \| 888.5 KB \| 201.26 KB \| 201.52 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.57 KB \| 122.57 KB \| 38.3 KB \| 38.3 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nReactDOM-prod.js \| 0.0% \| -0.0% \| 383.18 KB \| 383.18 KB \| 69.71 KB \| 69.71 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nReactDOMTesting-dev.js \| +0.1% \| +0.1% \| 890.99 KB \| 892.01 KB \| 199.23 KB \| 199.5 KB \| FB_WWW_DEV\nreact-dom-server.node.development.js \| 0.0% \| 0.0% \| 131.6 KB \| 131.6 KB \| 34.99 KB \| 34.99 KB \| NODE_DEV\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 4510330d8893c0ef8d648a7029cfed9c01a1faf8\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 73ff8b9094f9061c097d7f58fb4b02a90fa6f107...4510330d8893c0ef8d648a7029cfed9c01a1faf8</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.29 KB \| 12.29 KB \| 4.52 KB \| 4.52 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| +0.1% \| 980.96 KB \| 981.88 KB \| 218.01 KB \| 218.25 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| 0.0% \| -0.0% \| 409.85 KB \| 409.85 KB \| 74.47 KB \| 74.47 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nreact-dom.development.js \| +0.1% \| +0.1% \| 901.93 KB \| 902.86 KB \| 198.51 KB \| 198.77 KB \| UMD_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.83 KB \| 135.83 KB \| 34.97 KB \| 34.97 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.22 KB \| 118.22 KB \| 37.99 KB \| 37.99 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 121.93 KB \| 121.93 KB \| 39.18 KB \| 39.18 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| +0.1% \| +0.1% \| 917.64 KB \| 918.67 KB \| 204.73 KB \| 204.99 KB \| FB_WWW_DEV\nreact-dom.development.js \| +0.1% \| +0.1% \| 858.4 KB \| 859.29 KB \| 196.01 KB \| 196.28 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.3 KB \| 118.3 KB \| 37.18 KB \| 37.18 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 3.34 KB \| 3.34 KB \| 1.26 KB \| 1.26 KB \| UMD_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 122.16 KB \| 122.16 KB \| 38.38 KB \| 38.38 KB \| NODE_PROFILING\nReactDOM-dev.js \| +0.1% \| +0.1% \| 980.96 KB \| 981.88 KB \| 218.01 KB \| 218.25 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| -0.0% \| 409.85 KB \| 409.85 KB \| 74.47 KB \| 74.47 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 55.27 KB \| 55.27 KB \| 15.23 KB \| 15.23 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| 0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| 0.0% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 4510330d8893c0ef8d648a7029cfed9c01a1faf8\n</p>\n", "This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.\n", "up", "This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.\n", "Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!\n" ]	2020-03-13 19:31:40	2020-10-04 06:19:57	2020-10-04 06:19:57	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18306', 'html_url': 'https://github.com/facebook/react/pull/18306', 'diff_url': 'https://github.com/facebook/react/pull/18306.diff', 'patch_url': 'https://github.com/facebook/react/pull/18306.patch', 'merged_at': None}	close #12209	{'url': 'https://api.github.com/repos/facebook/react/issues/18306/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18306/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18305	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18305/labels{/name}	https://api.github.com/repos/facebook/react/issues/18305/comments	https://api.github.com/repos/facebook/react/issues/18305/events	https://github.com/facebook/react/pull/18305	580,747,183	MDExOlB1bGxSZXF1ZXN0Mzg3ODk4MzQw	18,305	Refine event system types + pass through priority	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18305/builds/14705) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 0e15bae2b47407a8dd5bd39f887c3bc60d7044df:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[suspicious-mountain-hiq92](https://codesandbox.io/s/suspicious-mountain-hiq92)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 45d26f6edb9564cb3fe88241b02fb0128850e9f4...0e15bae2b47407a8dd5bd39f887c3bc60d7044df</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| 0.0% \| +0.1% \| 427.52 KB \| 427.62 KB \| 77.57 KB \| 77.61 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 12.29 KB \| 12.29 KB \| 4.52 KB \| 4.52 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.22 KB \| 58.22 KB \| 14.53 KB \| 14.53 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1013 B \| 1013 B \| 602 B \| 601 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.48 KB \| UMD_PROD\nReactDOMForked-dev.js \| 0.0% \| 0.0% \| 980.83 KB \| 981.15 KB \| 217.97 KB \| 218.07 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 409.87 KB \| 409.97 KB \| 74.46 KB \| 74.5 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nreact-dom.development.js \| 0.0% \| 0.0% \| 901.78 KB \| 901.87 KB \| 198.46 KB \| 198.48 KB \| UMD_DEV\nReactDOMForked-profiling.js \| 0.0% \| +0.1% \| 427.52 KB \| 427.62 KB \| 77.57 KB \| 77.61 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.83 KB \| 135.83 KB \| 34.97 KB \| 34.97 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 118.21 KB \| 118.23 KB \| 37.98 KB \| 37.97 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.16 KB \| 20.16 KB \| 7.46 KB \| 7.46 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 121.92 KB \| 121.94 KB \| 39.16 KB \| 39.18 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| 0.0% \| 0.0% \| 917.5 KB \| 917.62 KB \| 204.69 KB \| 204.71 KB \| FB_WWW_DEV\nreact-dom.development.js \| 0.0% \| 0.0% \| 858.26 KB \| 858.35 KB \| 195.97 KB \| 195.98 KB \| NODE_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 390.68 KB \| 390.72 KB \| 71.14 KB \| 71.16 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 128.87 KB \| 128.87 KB \| 34.52 KB \| 34.52 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.29 KB \| 118.31 KB \| 37.17 KB \| 37.18 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 59.83 KB \| 59.83 KB \| 15.85 KB \| 15.85 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 390.68 KB \| 390.72 KB \| 71.14 KB \| 71.16 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.07 KB \| 20.07 KB \| 7.42 KB \| 7.42 KB \| NODE_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 122.14 KB \| 122.17 KB \| 38.36 KB \| 38.37 KB \| NODE_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.43 KB \| 12.43 KB \| 4.59 KB \| 4.59 KB \| UMD_PROD\nReactDOM-dev.js \| 0.0% \| 0.0% \| 980.83 KB \| 981.15 KB \| 217.97 KB \| 218.07 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 139.01 KB \| 139.01 KB \| 35.48 KB \| 35.48 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 409.87 KB \| 409.97 KB \| 74.46 KB \| 74.5 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 55.27 KB \| 55.27 KB \| 15.23 KB \| 15.23 KB \| NODE_DEV\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 47.71 KB \| 47.71 KB \| 11.11 KB \| 11.11 KB \| FB_WWW_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.21 KB \| 55.21 KB \| 14.3 KB \| 14.3 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.1%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0e15bae2b47407a8dd5bd39f887c3bc60d7044df\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 45d26f6edb9564cb3fe88241b02fb0128850e9f4...0e15bae2b47407a8dd5bd39f887c3bc60d7044df</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.54 KB \| 126.56 KB \| 39.57 KB \| 39.58 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nReactDOM-dev.js \| 0.0% \| 0.0% \| 934.94 KB \| 935.28 KB \| 208.08 KB \| 208.17 KB \| FB_WWW_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 137.42 KB \| 137.42 KB \| 35.17 KB \| 35.17 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.62 KB \| 20.62 KB \| 7.54 KB \| 7.54 KB \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 130.38 KB \| 130.38 KB \| 34.74 KB \| 34.74 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nreact-dom.development.js \| 0.0% \| 0.0% \| 932.27 KB \| 932.35 KB \| 203.73 KB \| 203.75 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.24 KB \| 58.24 KB \| 14.54 KB \| 14.54 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.41 KB \| 122.43 KB \| 39.13 KB \| 39.14 KB \| UMD_PROD\nReactDOMForked-dev.js \| 0.0% \| 0.0% \| 934.94 KB \| 935.28 KB \| 208.08 KB \| 208.17 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.32 KB \| 10.32 KB \| 3.5 KB \| 3.49 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.34 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.24 KB \| 126.26 KB \| 40.37 KB \| 40.38 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 383.2 KB \| 383.55 KB \| 69.7 KB \| 69.78 KB \| FB_WWW_PROD\nreact-dom.development.js \| 0.0% \| 0.0% \| 887.47 KB \| 887.55 KB \| 201.22 KB \| 201.23 KB \| NODE_DEV\nReactDOMForked-profiling.js \| +0.1% \| +0.1% \| 400.78 KB \| 401.13 KB \| 72.73 KB \| 72.81 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.23 KB \| 55.23 KB \| 14.31 KB \| 14.3 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.56 KB \| 122.58 KB \| 38.29 KB \| 38.29 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.16 KB \| 1.16 KB \| 662 B \| 661 B \| NODE_PROD\nReactDOM-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 383.2 KB \| 383.55 KB \| 69.7 KB \| 69.78 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| +0.1% \| +0.1% \| 400.78 KB \| 401.13 KB \| 72.73 KB \| 72.81 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1 KB \| 1 KB \| 610 B \| 609 B \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 59.84 KB \| 59.84 KB \| 15.86 KB \| 15.86 KB \| UMD_DEV\nReactDOMTesting-dev.js \| 0.0% \| 0.0% \| 890.85 KB \| 890.97 KB \| 199.2 KB \| 199.22 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 377.02 KB \| 377.3 KB \| 68.92 KB \| 68.98 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 55.29 KB \| 55.29 KB \| 15.24 KB \| 15.24 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| +0.1% \| +0.1% \| 377.02 KB \| 377.3 KB \| 68.92 KB \| 68.98 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 131.6 KB \| 131.6 KB \| 34.99 KB \| 34.99 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.3 KB \| 12.3 KB \| 4.53 KB \| 4.53 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.94 KB \| 20.94 KB \| 7.65 KB \| 7.65 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0e15bae2b47407a8dd5bd39f887c3bc60d7044df\n</p>\n" ]	2020-03-13 17:36:15	2020-03-13 20:26:42	2020-03-13 17:57:18	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18305', 'html_url': 'https://github.com/facebook/react/pull/18305', 'diff_url': 'https://github.com/facebook/react/pull/18305.diff', 'patch_url': 'https://github.com/facebook/react/pull/18305.patch', 'merged_at': datetime.datetime(2020, 3, 13, 17, 57, 18)}	This PR is mostly cosmetic, it renames some functions and allows `priority` to be passed through to `addTrappedEventListener`. I also cleaned up some of the Flow types.	{'url': 'https://api.github.com/repos/facebook/react/issues/18305/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18305/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18304	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18304/labels{/name}	https://api.github.com/repos/facebook/react/issues/18304/comments	https://api.github.com/repos/facebook/react/issues/18304/events	https://github.com/facebook/react/pull/18304	580,636,848	MDExOlB1bGxSZXF1ZXN0Mzg3ODA2Nzk2	18,304	ReactDOM.useEvent: wire to event system to the hook	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18304/builds/15096) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 89d48670d7fc1500acbccf7c7a16c11db48fff0d:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[dark-cdn-2ltz4](https://codesandbox.io/s/dark-cdn-2ltz4)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 0705b7282f9c52ce85b6125ebbe32f6a6abf01a4...89d48670d7fc1500acbccf7c7a16c11db48fff0d</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.56 KB \| 126.59 KB \| 39.58 KB \| 39.59 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nReactDOM-dev.js \| 0.0% \| +0.1% \| 935.28 KB \| 935.69 KB \| 208.17 KB \| 208.3 KB \| FB_WWW_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 130.38 KB \| 130.38 KB \| 34.74 KB \| 34.74 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nreact-dom.development.js \| 0.0% \| +0.1% \| 932.35 KB \| 932.76 KB \| 203.75 KB \| 203.87 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.43 KB \| 122.46 KB \| 39.14 KB \| 39.15 KB \| UMD_PROD\nReactDOMForked-dev.js \| 0.0% \| +0.1% \| 935.28 KB \| 935.69 KB \| 208.17 KB \| 208.3 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10.32 KB \| 10.32 KB \| 3.5 KB \| 3.5 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.35 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.26 KB \| 126.29 KB \| 40.38 KB \| 40.39 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| 0.0% \| 0.0% \| 383.55 KB \| 383.67 KB \| 69.78 KB \| 69.81 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| 0.0% \| 47.01 KB \| 47.01 KB \| 10.93 KB \| 10.93 KB \| FB_WWW_PROD\nreact-dom.development.js \| 0.0% \| +0.1% \| 887.55 KB \| 887.95 KB \| 201.24 KB \| 201.36 KB \| NODE_DEV\nReactDOMForked-profiling.js \| 0.0% \| 0.0% \| 401.13 KB \| 401.26 KB \| 72.81 KB \| 72.84 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.23 KB \| 55.23 KB \| 14.31 KB \| 14.31 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.58 KB \| 122.61 KB \| 38.3 KB \| 38.31 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nReactDOM-prod.js \| 0.0% \| 0.0% \| 383.55 KB \| 383.67 KB \| 69.78 KB \| 69.81 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| 0.0% \| 0.0% \| 401.13 KB \| 401.26 KB \| 72.81 KB \| 72.84 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 59.84 KB \| 59.84 KB \| 15.86 KB \| 15.86 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.44 KB \| 12.44 KB \| 4.6 KB \| 4.6 KB \| UMD_PROD\nReactDOMTesting-dev.js \| 0.0% \| +0.1% \| 890.97 KB \| 891.38 KB \| 199.22 KB \| 199.35 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 377.3 KB \| 377.43 KB \| 68.98 KB \| 69 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 55.29 KB \| 55.29 KB \| 15.24 KB \| 15.24 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 377.3 KB \| 377.43 KB \| 68.98 KB \| 69 KB \| FB_WWW_PROFILING\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 652.57 KB \| 652.99 KB \| 140.86 KB \| 140.99 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| 0.0% \| 0.0% \| 267.64 KB \| 267.77 KB \| 46.53 KB \| 46.55 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| 0.0% \| 279.44 KB \| 279.56 KB \| 48.78 KB \| 48.8 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 631.72 KB \| 632.14 KB \| 136.18 KB \| 136.31 KB \| RN_OSS_DEV\nReactFabric-prod.js \| 0.0% \| 0.0% \| 259.48 KB \| 259.6 KB \| 45.03 KB \| 45.05 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| 0.0% \| +0.1% \| 271.28 KB \| 271.4 KB \| 47.27 KB \| 47.29 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 634.43 KB \| 634.86 KB \| 136.51 KB \| 136.63 KB \| RN_FB_DEV\nReactFabric-prod.js \| 0.0% \| 0.0% \| 259.63 KB \| 259.76 KB \| 45.06 KB \| 45.08 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 649.86 KB \| 650.28 KB \| 140.53 KB \| 140.66 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| 0.0% \| +0.1% \| 271.43 KB \| 271.55 KB \| 47.3 KB \| 47.32 KB \| RN_FB_PROFILING\nReactNativeRenderer-prod.js \| 0.0% \| 0.0% \| 267.5 KB \| 267.62 KB \| 46.5 KB \| 46.52 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| 0.0% \| 279.3 KB \| 279.42 KB \| 48.76 KB \| 48.78 KB \| RN_OSS_PROFILING\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 89d48670d7fc1500acbccf7c7a16c11db48fff0d\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 0705b7282f9c52ce85b6125ebbe32f6a6abf01a4...89d48670d7fc1500acbccf7c7a16c11db48fff0d</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| 0.0% \| +0.1% \| 427.62 KB \| 427.74 KB \| 77.61 KB \| 77.65 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 12.29 KB \| 12.29 KB \| 4.52 KB \| 4.52 KB \| NODE_PROD\nReactDOMForked-dev.js \| 0.0% \| +0.1% \| 981.15 KB \| 981.56 KB \| 218.07 KB \| 218.2 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 409.97 KB \| 410.1 KB \| 74.5 KB \| 74.54 KB \| FB_WWW_PROD\nreact-dom.development.js \| 0.0% \| +0.1% \| 901.87 KB \| 902.27 KB \| 198.48 KB \| 198.6 KB \| UMD_DEV\nReactDOMForked-profiling.js \| 0.0% \| +0.1% \| 427.62 KB \| 427.74 KB \| 77.61 KB \| 77.65 KB \| FB_WWW_PROFILING\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.23 KB \| 118.26 KB \| 37.97 KB \| 37.98 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 121.94 KB \| 121.97 KB \| 39.18 KB \| 39.19 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| 0.0% \| +0.1% \| 917.62 KB \| 918.03 KB \| 204.72 KB \| 204.85 KB \| FB_WWW_DEV\nreact-dom.development.js \| 0.0% \| +0.1% \| 858.35 KB \| 858.74 KB \| 195.99 KB \| 196.11 KB \| NODE_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 390.72 KB \| 390.84 KB \| 71.16 KB \| 71.18 KB \| FB_WWW_PROD\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.31 KB \| 118.34 KB \| 37.18 KB \| 37.19 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 59.83 KB \| 59.83 KB \| 15.85 KB \| 15.85 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 390.72 KB \| 390.84 KB \| 71.16 KB \| 71.18 KB \| FB_WWW_PROFILING\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 122.17 KB \| 122.2 KB \| 38.37 KB \| 38.39 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.17 KB \| 1.17 KB \| 692 B \| 691 B \| UMD_PROD\nReactDOM-dev.js \| 0.0% \| +0.1% \| 981.15 KB \| 981.56 KB \| 218.07 KB \| 218.2 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 409.97 KB \| 410.1 KB \| 74.5 KB \| 74.54 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 55.27 KB \| 55.27 KB \| 15.23 KB \| 15.23 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.1% \| +0.1% \| 649.85 KB \| 650.27 KB \| 140.52 KB \| 140.65 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| 0.0% \| 0.0% \| 267.49 KB \| 267.61 KB \| 46.49 KB \| 46.51 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| 0.0% \| 279.28 KB \| 279.41 KB \| 48.75 KB \| 48.77 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.1% \| +0.1% \| 631.71 KB \| 632.13 KB \| 136.17 KB \| 136.3 KB \| RN_OSS_DEV\nReactFabric-prod.js \| 0.0% \| 0.0% \| 259.47 KB \| 259.59 KB \| 45.02 KB \| 45.04 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| 0.0% \| +0.1% \| 271.26 KB \| 271.39 KB \| 47.26 KB \| 47.29 KB \| RN_OSS_PROFILING\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 89d48670d7fc1500acbccf7c7a16c11db48fff0d\n</p>\n", "@threepointone Thanks for the review. I addressed all your feedback. In terms of using `createRoot`, there is a test that does that, but it shouldn't really affect things. I'll add more tests that use it in a follow up though, probably porting over the non-useEvent tests above in the same file to inside the useEvent block :)" ]	2020-03-13 14:28:13	2020-03-16 21:46:22	2020-03-16 21:46:18	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18304', 'html_url': 'https://github.com/facebook/react/pull/18304', 'diff_url': 'https://github.com/facebook/react/pull/18304.diff', 'patch_url': 'https://github.com/facebook/react/pull/18304.patch', 'merged_at': datetime.datetime(2020, 3, 16, 21, 46, 18)}	This PR wires up the `useEvent` hook to the ReactDOM renderer. This is the first PR that actually allows you to use `useEvent` properly with ReactDOM. This PR only adds support for `Element` target nodes that are managed by React are now supported. `document` and `window` targets are not supported just yet (that will come in another PR). I've also added quite a few tests, with more to come. Lastly, we have to add some additional logic into four places: - During `executeDispatchesInOrder` we need to check the instance does not match the previous instance when validating `stopPropagation` logic. The reason for this is because it's now possible to have more than one listener per instance (compared to on* prop events). - During `beforeRemoveInstance` we need to do some extra cleanup when a node is removed has a `useEvent` listener wired to it. If we don't do this, we'll leak the DOM node in the listener (because the listener is referenced in `mountEventListener`'s Map). - During `accumulateTwoPhaseListeners` we need to also check if the instance has `useEvent` listeners that match the `type` and `capture` flags on the listener. Still TODO: - window target support - document target support - passive/active event listener upgrading (https://github.com/facebook/react/pull/18308) - experimental internal scope support	{'url': 'https://api.github.com/repos/facebook/react/issues/18304/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 2}	https://api.github.com/repos/facebook/react/issues/18304/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18303	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18303/labels{/name}	https://api.github.com/repos/facebook/react/issues/18303/comments	https://api.github.com/repos/facebook/react/issues/18303/events	https://github.com/facebook/react/pull/18303	580,572,313	MDExOlB1bGxSZXF1ZXN0Mzg3NzUzMDg3	18,303	Remove un-used function arg	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18303/builds/14650) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 2cbdb85cdaed46a97b992b21389f12e5792dd8e0:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[goofy-snyder-mq4y3](https://codesandbox.io/s/goofy-snyder-mq4y3)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2cbdb85cdaed46a97b992b21389f12e5792dd8e0\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2cbdb85cdaed46a97b992b21389f12e5792dd8e0\n</p>\n" ]	2020-03-13 12:32:34	2020-03-13 14:16:16	2020-03-13 14:16:12	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18303', 'html_url': 'https://github.com/facebook/react/pull/18303', 'diff_url': 'https://github.com/facebook/react/pull/18303.diff', 'patch_url': 'https://github.com/facebook/react/pull/18303.patch', 'merged_at': datetime.datetime(2020, 3, 13, 14, 16, 12)}	We can remove the function arg as it's never used anywhere anymore (it was added to support the `ResponderPlugin`, but we ended up not going down that route).	{'url': 'https://api.github.com/repos/facebook/react/issues/18303/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18303/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18302	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18302/labels{/name}	https://api.github.com/repos/facebook/react/issues/18302/comments	https://api.github.com/repos/facebook/react/issues/18302/events	https://github.com/facebook/react/pull/18302	580,353,322	MDExOlB1bGxSZXF1ZXN0Mzg3NTc3MjQz	18,302	Revert "Move MS Windows build to CircleCI"	{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "cc: @wittgenst ", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18302/builds/14593) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b7f8ffebb7476a6a9d80dddff54b0ba6d88ea173:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[cranky-hodgkin-znf3q](https://codesandbox.io/s/cranky-hodgkin-znf3q)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b7f8ffebb7476a6a9d80dddff54b0ba6d88ea173\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b7f8ffebb7476a6a9d80dddff54b0ba6d88ea173\n</p>\n" ]	2020-03-13 03:49:20	2022-11-29 22:20:56	2020-03-13 03:57:14	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18302', 'html_url': 'https://github.com/facebook/react/pull/18302', 'diff_url': 'https://github.com/facebook/react/pull/18302.diff', 'patch_url': 'https://github.com/facebook/react/pull/18302.patch', 'merged_at': datetime.datetime(2020, 3, 13, 3, 57, 14)}	I'm reverting this because it slowed our CI times from ~6 minutes to ~23 minutes. That's because it runs the build command without concurrency. I don't remember why the Windows jobs exist. I can see why testing on a Windows machine is useful, but I don't think we should have to build the artifacts on Windows. We could re-use the artifacts from the normal build job. Let's figure it out then re-land.	{'url': 'https://api.github.com/repos/facebook/react/issues/18302/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18302/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18301	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18301/labels{/name}	https://api.github.com/repos/facebook/react/issues/18301/comments	https://api.github.com/repos/facebook/react/issues/18301/events	https://github.com/facebook/react/pull/18301	580,342,373	MDExOlB1bGxSZXF1ZXN0Mzg3NTY4NDM0	18,301	Run ReactElementJSX-test against bundles	{'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'following_url': 'https://api.github.com/users/gaearon/following{/other_user}', 'gists_url': 'https://api.github.com/users/gaearon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gaearon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gaearon/subscriptions', 'organizations_url': 'https://api.github.com/users/gaearon/orgs', 'repos_url': 'https://api.github.com/users/gaearon/repos', 'events_url': 'https://api.github.com/users/gaearon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gaearon/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18301/builds/14591) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit ea3cccde4e5aa86ec14f339b346922ff2b45ddea:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[busy-mahavira-ifszk](https://codesandbox.io/s/busy-mahavira-ifszk)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ea3cccde4e5aa86ec14f339b346922ff2b45ddea\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ea3cccde4e5aa86ec14f339b346922ff2b45ddea\n</p>\n", "It would be nice to have some way to ensure that a test isn’t completely ignored by all runs because we forgot about giving it a variant. ", "Yeah that would be nice. Though this is probably only an issue for existing tests, since it'd be weird to write a test that you never run yourself.\r\n\r\nAlso, if we remove all the hardcoded overrides here: https://github.com/facebook/react/blob/885ed469096d4da7ca038564b323e9b706f5a6d0/packages/shared/forks/ReactFeatureFlags.www-dynamic.js#L25-L32\r\n\r\n...and here: https://github.com/facebook/react/blob/885ed469096d4da7ca038564b323e9b706f5a6d0/scripts/jest/setupTests.www.js#L13-L22\r\n\r\nthen if a flag is shipped to any of our open source or www channels, it will definitely be tested. So I'm not too worried about this.", "Put another way, it's not that big a deal if we neglect to test a configuration that doesn't actually exist in one of our release channels. It's not ideal, because there could be hidden bugs that don't get discovered until we turn the flag on somewhere. But it's more important to test against every possible configuration that actually gets shipped." ]	2020-03-13 03:08:42	2020-03-13 12:07:23	2020-03-13 12:07:22	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18301', 'html_url': 'https://github.com/facebook/react/pull/18301', 'diff_url': 'https://github.com/facebook/react/pull/18301.diff', 'patch_url': 'https://github.com/facebook/react/pull/18301.patch', 'merged_at': datetime.datetime(2020, 3, 13, 12, 7, 22)}	This is an important test. We should run it on bundles, not just source. See https://github.com/facebook/react/pull/18299#discussion_r392007055 for the kind of issue it could catch. I'm removing the internal suffix and moving the only test that actually depends on feature flags by now into its own file. That one stays internal.	{'url': 'https://api.github.com/repos/facebook/react/issues/18301/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18301/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18299	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18299/labels{/name}	https://api.github.com/repos/facebook/react/issues/18299/comments	https://api.github.com/repos/facebook/react/issues/18299/events	https://github.com/facebook/react/pull/18299	580,320,238	MDExOlB1bGxSZXF1ZXN0Mzg3NTUwODUx	18,299	add jsx-runtime and jsx-dev-runtime modules	{'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', 'following_url': 'https://api.github.com/users/lunaruan/following{/other_user}', 'gists_url': 'https://api.github.com/users/lunaruan/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lunaruan/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lunaruan/subscriptions', 'organizations_url': 'https://api.github.com/users/lunaruan/orgs', 'repos_url': 'https://api.github.com/users/lunaruan/repos', 'events_url': 'https://api.github.com/users/lunaruan/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lunaruan/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18299/builds/15248) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit ded98d8c2a6b7825d8c85189eb3b0f90e0d96b0b:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[quirky-tdd-dws4b](https://codesandbox.io/s/quirky-tdd-dws4b)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 26666427d6ed5cbc581e65e43608fa1acec3bcf8...ded98d8c2a6b7825d8c85189eb3b0f90e0d96b0b</p>\n\n\n \n## react\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact.development.js \| -4.9% \| -3.0% \| 108.97 KB \| 103.65 KB \| 26.03 KB \| 25.24 KB \| UMD_DEV\nreact-jsx-runtime.profiling.min.js \| n/a \| n/a \| 0 B \| 943 B \| 0 B \| 592 B \| NODE_PROFILING\nreact.production.min.js \| -3.5% \| -2.6% \| 12.66 KB \| 12.22 KB \| 4.87 KB \| 4.75 KB \| UMD_PROD\nJSXRuntime-dev.js \| n/a \| n/a \| 0 B \| 29.41 KB \| 0 B \| 8.64 KB \| FB_WWW_DEV\nreact-jsx-dev-runtime.development.js \| n/a \| n/a \| 0 B \| 26.33 KB \| 0 B \| 8.08 KB \| NODE_DEV\nreact-jsx-dev-runtime.production.min.js \| n/a \| n/a \| 0 B \| 433 B \| 0 B \| 313 B \| NODE_PROD\nreact-jsx-dev-runtime.profiling.min.js \| n/a \| n/a \| 0 B \| 432 B \| 0 B \| 312 B \| NODE_PROFILING\nJSXDEVRuntime-dev.js \| n/a \| n/a \| 0 B \| 28.82 KB \| 0 B \| 8.46 KB \| FB_WWW_DEV\nJSXDEVRuntime-prod.js \| n/a \| n/a \| 0 B \| 510 B \| 0 B \| 343 B \| FB_WWW_PROD\nreact-jsx-runtime.development.js \| n/a \| n/a \| 0 B \| 26.91 KB \| 0 B \| 8.26 KB \| NODE_DEV\nJSXDEVRuntime-profiling.js \| n/a \| n/a \| 0 B \| 510 B \| 0 B \| 343 B \| FB_WWW_PROFILING\nreact-jsx-runtime.production.min.js \| n/a \| n/a \| 0 B \| 944 B \| 0 B \| 593 B \| NODE_PROD\nreact.profiling.min.js \| -2.7% \| -1.6% \| 16.2 KB \| 15.76 KB \| 5.95 KB \| 5.85 KB \| UMD_PROFILING\nJSXRuntime-prod.js \| n/a \| n/a \| 0 B \| 1.54 KB \| 0 B \| 742 B \| FB_WWW_PROD\nreact.development.js \| -7.2% \| -4.1% \| 70.39 KB \| 65.33 KB \| 18.27 KB \| 17.53 KB \| NODE_DEV\nJSXRuntime-profiling.js \| n/a \| n/a \| 0 B \| 1.54 KB \| 0 B \| 742 B \| FB_WWW_PROFILING\nreact.production.min.js \| -5.9% \| -3.3% \| 7.73 KB \| 7.27 KB \| 2.97 KB \| 2.88 KB \| NODE_PROD\nReact-dev.js \| +17.6% \| +13.0% \| 75.59 KB \| 88.91 KB \| 19.11 KB \| 21.59 KB \| FB_WWW_DEV\nReact-prod.js \| -0.5% \| -1.3% \| 18.02 KB \| 17.92 KB \| 4.66 KB \| 4.6 KB \| FB_WWW_PROD\nReact-profiling.js \| -0.5% \| -1.3% \| 18.02 KB \| 17.92 KB \| 4.66 KB \| 4.6 KB \| FB_WWW_PROFILING\n\n </details>\n \n\nReact: size: -3.5%, gzip: -2.6%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ded98d8c2a6b7825d8c85189eb3b0f90e0d96b0b\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 26666427d6ed5cbc581e65e43608fa1acec3bcf8...ded98d8c2a6b7825d8c85189eb3b0f90e0d96b0b</p>\n\n\n \n## react\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact.development.js \| +0.1% \| +0.1% \| 100.31 KB \| 100.45 KB \| 24.65 KB \| 24.66 KB \| UMD_DEV\nJSXRuntime-profiling.js \| n/a \| n/a \| 0 B \| 1.54 KB \| 0 B \| 742 B \| FB_WWW_PROFILING\nJSXDEVRuntime-dev.js \| n/a \| n/a \| 0 B \| 28.83 KB \| 0 B \| 8.46 KB \| FB_WWW_DEV\nJSXDEVRuntime-prod.js \| n/a \| n/a \| 0 B \| 510 B \| 0 B \| 343 B \| FB_WWW_PROD\nJSXDEVRuntime-profiling.js \| n/a \| n/a \| 0 B \| 510 B \| 0 B \| 343 B \| FB_WWW_PROFILING\nreact-jsx-runtime.development.js \| n/a \| n/a \| 0 B \| 26.9 KB \| 0 B \| 8.25 KB \| NODE_DEV\nreact-jsx-runtime.production.min.js \| n/a \| n/a \| 0 B \| 931 B \| 0 B \| 585 B \| NODE_PROD\nreact-jsx-runtime.profiling.min.js \| n/a \| n/a \| 0 B \| 930 B \| 0 B \| 584 B \| NODE_PROFILING\nJSXRuntime-dev.js \| n/a \| n/a \| 0 B \| 29.41 KB \| 0 B \| 8.64 KB \| FB_WWW_DEV\nJSXRuntime-prod.js \| n/a \| n/a \| 0 B \| 1.54 KB \| 0 B \| 742 B \| FB_WWW_PROD\nreact.development.js \| +0.2% \| +0.1% \| 62.14 KB \| 62.28 KB \| 16.92 KB \| 16.94 KB \| NODE_DEV\nReact-dev.js \| +17.5% \| +12.7% \| 76.26 KB \| 89.58 KB \| 19.28 KB \| 21.73 KB \| FB_WWW_DEV\nReact-prod.js \| -0.5% \| -1.0% \| 18.08 KB \| 17.98 KB \| 4.67 KB \| 4.62 KB \| FB_WWW_PROD\nreact-jsx-dev-runtime.development.js \| n/a \| n/a \| 0 B \| 26.32 KB \| 0 B \| 8.08 KB \| NODE_DEV\nReact-profiling.js \| -0.5% \| -1.0% \| 18.08 KB \| 17.98 KB \| 4.67 KB \| 4.62 KB \| FB_WWW_PROFILING\nreact-jsx-dev-runtime.production.min.js \| n/a \| n/a \| 0 B \| 420 B \| 0 B \| 304 B \| NODE_PROD\nreact-jsx-dev-runtime.profiling.min.js \| n/a \| n/a \| 0 B \| 419 B \| 0 B \| 304 B \| NODE_PROFILING\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ded98d8c2a6b7825d8c85189eb3b0f90e0d96b0b\n</p>\n", "You'll also need to add them to `bundles.js` to actually build the bundles. See similar entry points (e.g. `react-dom/server` and its config) for expiration. Hit me up for any questions!", "Pls rebase :-) I think this should fail now. ", "Hi 👋 I thought this change would land with the next version but I see it's not yet available. Do you have any idea when this will be available? Thanks! 🙇 ", "@midudev Can you clarify why you need it?", "Thanks for the reply. Yes, trying to get working latest babel-preset-react with `automatic` runtime, I'm getting this error:\r\n\r\n`Module not found: Can't resolve 'react/jsx-runtime' in '/Users/midudev/Dev/frontend-fc--web-server/src'`\r\n\r\nI thought it was related to this PR as installing latest `react` version there's no `jsx-runtime` available to import. Maybe am I doing something wrong?", "Right, I just wanted to confirm why you're asking. This indeed hasn't been released in stable yet. You can install `react@experimental` if you want, that one has it.", "I am using the ```0.0.0-experimental-f42431abe``` version of React for testing. I converted a version 17 App and on all the pages I am getting the ```React' must be in scope when using JSX``` error. Meanwhile I already follow the [Introducing the New JSX Transform](https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#removing-unused-react-imports) tutorial to implement it. Is it that the the New JSX Transform is not available in the experimental version? Or is there a way to implement it?" ]	2020-03-13 01:49:28	2021-08-09 04:16:49	2020-03-17 20:22:20	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18299', 'html_url': 'https://github.com/facebook/react/pull/18299', 'diff_url': 'https://github.com/facebook/react/pull/18299.diff', 'patch_url': 'https://github.com/facebook/react/pull/18299.patch', 'merged_at': datetime.datetime(2020, 3, 17, 20, 22, 20)}	This PR adds the `jsx-runtime` and `jsx-dev-runtime` modules for the JSX Babel Plugin. WWW still relies on `jsx/jsxs/jsxDEV` from the `"react"` module, so once we refactor the code to point to the runtime modules we will remove `jsx/jsxs/jsxDEV` from the `"react"` module.	{'url': 'https://api.github.com/repos/facebook/react/issues/18299/reactions', 'total_count': 10, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 5, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 5}	https://api.github.com/repos/facebook/react/issues/18299/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18298	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18298/labels{/name}	https://api.github.com/repos/facebook/react/issues/18298/comments	https://api.github.com/repos/facebook/react/issues/18298/events	https://github.com/facebook/react/pull/18298	580,316,880	MDExOlB1bGxSZXF1ZXN0Mzg3NTQ4MjE5	18,298	feat: flow type completion	{'login': 'izayl', 'id': 10740043, 'node_id': 'MDQ6VXNlcjEwNzQwMDQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/10740043?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/izayl', 'html_url': 'https://github.com/izayl', 'followers_url': 'https://api.github.com/users/izayl/followers', 'following_url': 'https://api.github.com/users/izayl/following{/other_user}', 'gists_url': 'https://api.github.com/users/izayl/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/izayl/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/izayl/subscriptions', 'organizations_url': 'https://api.github.com/users/izayl/orgs', 'repos_url': 'https://api.github.com/users/izayl/repos', 'events_url': 'https://api.github.com/users/izayl/events{/privacy}', 'received_events_url': 'https://api.github.com/users/izayl/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "Hi @izayl! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nIf you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Freact%20%2318298). Thanks!", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18298/builds/14580) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit af4fec643f7aa386c9634001ffcfe7b1ef7114d3:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[vibrant-curie-54xfc](https://codesandbox.io/s/vibrant-curie-54xfc)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against af4fec643f7aa386c9634001ffcfe7b1ef7114d3\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against af4fec643f7aa386c9634001ffcfe7b1ef7114d3\n</p>\n", "Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!", "Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!", "Thanks for the PR, but we often rely on inference in functions that aren't exported. " ]	2020-03-13 01:35:31	2020-03-24 17:59:44	2020-03-24 17:59:44	NONE	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18298', 'html_url': 'https://github.com/facebook/react/pull/18298', 'diff_url': 'https://github.com/facebook/react/pull/18298.diff', 'patch_url': 'https://github.com/facebook/react/pull/18298.patch', 'merged_at': None}	<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Complete the flow type define in `packages/scheduler/src/SchedulerMinHeap.js` <!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> ## Test Plan ``` $ yarn test Test Suites: 246 passed, 246 total Tests: 27 skipped, 6139 passed, 6166 total Snapshots: 161 passed, 161 total Time: 163.461s Ran all test suites. ✨ Done in 167.73s. ``` <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->	{'url': 'https://api.github.com/repos/facebook/react/issues/18298/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18298/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18297	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18297/labels{/name}	https://api.github.com/repos/facebook/react/issues/18297/comments	https://api.github.com/repos/facebook/react/issues/18297/events	https://github.com/facebook/react/pull/18297	580,303,510	MDExOlB1bGxSZXF1ZXN0Mzg3NTM3OTg2	18,297	useMutableSource: bugfix for new getSnapshot with mutation	{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18297/builds/14568) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit e07253bba8d904966649da0882f9d3923776f5b3:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[sad-keller-9ht8j](https://codesandbox.io/s/sad-keller-9ht8j)\| Configuration \|\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18297/builds/17958) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 86da5ce041477efb70aa7b4d70df53f001a985bb:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[compassionate-thompson-v9pst](https://codesandbox.io/s/compassionate-thompson-v9pst)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: a8f2165e83ad09513b0eae239099e6e1f6d149cc...86da5ce041477efb70aa7b4d70df53f001a985bb</p>\n\n\n \n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer.development.js \| +0.4% \| +0.4% \| 560.52 KB \| 562.52 KB \| 116.6 KB \| 117.07 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.5% \| 73.33 KB \| 73.76 KB \| 22.32 KB \| 22.43 KB \| UMD_PROD\nreact-test-renderer-shallow.development.js \| 0.0% \| 0.0% \| 38.63 KB \| 38.63 KB \| 9.4 KB \| 9.4 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.74 KB \| 12.74 KB \| 3.97 KB \| 3.97 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.4% \| +0.4% \| 534.42 KB \| 536.36 KB \| 115.15 KB \| 115.63 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.5% \| 73.16 KB \| 73.59 KB \| 22.02 KB \| 22.12 KB \| NODE_PROD\nReactTestRenderer-dev.js \| +0.4% \| +0.4% \| 568.22 KB \| 570.26 KB \| 119.81 KB \| 120.29 KB \| FB_WWW_DEV\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.47 KB \| 135.47 KB \| 34.7 KB \| 34.7 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.01 KB \| 20.01 KB \| 7.41 KB \| 7.41 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.3% \| +0.2% \| 126.62 KB \| 126.99 KB \| 39.54 KB \| 39.63 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 4.82 KB \| 4.82 KB \| 1.62 KB \| 1.62 KB \| UMD_DEV\nReactDOM-dev.js \| +0.2% \| +0.2% \| 964.32 KB \| 966.36 KB \| 213.76 KB \| 214.23 KB \| FB_WWW_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.2 KB \| 1.2 KB \| 706 B \| 705 B \| UMD_PROD\nReactDOM-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 404.55 KB \| 405.67 KB \| 73.03 KB \| 73.2 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| +0.3% \| +0.2% \| 415.37 KB \| 416.49 KB \| 74.87 KB \| 75.03 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1.02 KB \| 1.02 KB \| 618 B \| 617 B \| NODE_PROD\nReactDOMTesting-dev.js \| +0.2% \| +0.2% \| 918.72 KB \| 920.76 KB \| 204.54 KB \| 205.01 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 390.02 KB \| 391.14 KB \| 70.94 KB \| 71.11 KB \| FB_WWW_PROD\nReactDOMTesting-profiling.js \| +0.3% \| +0.2% \| 390.02 KB \| 391.14 KB \| 70.94 KB \| 71.11 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 19.92 KB \| 19.92 KB \| 7.38 KB \| 7.38 KB \| NODE_PROD\nreact-dom.development.js \| +0.2% \| +0.2% \| 923.67 KB \| 925.67 KB \| 201.49 KB \| 201.94 KB \| UMD_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.3% \| 122.47 KB \| 122.84 KB \| 39.03 KB \| 39.14 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.2% \| +0.2% \| 964.32 KB \| 966.36 KB \| 213.76 KB \| 214.23 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| +0.3% \| +0.2% \| 126.3 KB \| 126.66 KB \| 40.3 KB \| 40.39 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 404.55 KB \| 405.67 KB \| 73.03 KB \| 73.2 KB \| FB_WWW_PROD\nreact-dom.development.js \| +0.2% \| +0.2% \| 879.5 KB \| 881.44 KB \| 199.01 KB \| 199.48 KB \| NODE_DEV\nReactDOMForked-profiling.js \| +0.3% \| +0.2% \| 415.37 KB \| 416.49 KB \| 74.87 KB \| 75.03 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 5.09 KB \| 5.09 KB \| 1.68 KB \| 1.68 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.4% \| 122.64 KB \| 123.01 KB \| 38.25 KB \| 38.4 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 9.75 KB \| 9.75 KB \| 3.26 KB \| 3.25 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.1% \| 1.17 KB \| 1.17 KB \| 667 B \| 666 B \| NODE_PROD\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactART-dev.js \| +0.4% \| +0.4% \| 578.94 KB \| 580.98 KB \| 121.49 KB \| 121.97 KB \| FB_WWW_DEV\nReactART-prod.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.5% \| 239.41 KB \| 240.67 KB \| 40.48 KB \| 40.67 KB \| FB_WWW_PROD\nreact-art.development.js \| +0.3% \| +0.3% \| 643 KB \| 645 KB \| 135.06 KB \| 135.52 KB \| UMD_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.3% \| 108.89 KB \| 109.32 KB \| 32.92 KB \| 33.02 KB \| UMD_PROD\nreact-art.development.js \| +0.4% \| +0.4% \| 547.04 KB \| 548.97 KB \| 117.44 KB \| 117.91 KB \| NODE_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.5% \| 73.88 KB \| 74.31 KB \| 22.11 KB \| 22.22 KB \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.3% \| +0.4% \| 648.8 KB \| 650.84 KB \| 139.14 KB \| 139.63 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.4% \| 269.34 KB \| 270.59 KB \| 46.37 KB \| 46.56 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| +0.4% \| +0.4% \| 281.24 KB \| 282.49 KB \| 48.58 KB \| 48.77 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| +0.3% \| +0.4% \| 628.1 KB \| 630.14 KB \| 134.37 KB \| 134.86 KB \| RN_OSS_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.4% \| 261.17 KB \| 262.43 KB \| 44.84 KB \| 45.03 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.5% \| +0.4% \| 273.08 KB \| 274.33 KB \| 47.06 KB \| 47.25 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.3% \| +0.4% \| 630.52 KB \| 632.56 KB \| 134.68 KB \| 135.18 KB \| RN_FB_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.4% \| 261.33 KB \| 262.58 KB \| 44.87 KB \| 45.06 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| +0.3% \| +0.4% \| 646.39 KB \| 648.43 KB \| 138.81 KB \| 139.3 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| +0.5% \| +0.4% \| 273.23 KB \| 274.48 KB \| 47.09 KB \| 47.28 KB \| RN_FB_PROFILING\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.4% \| 269.19 KB \| 270.44 KB \| 46.34 KB \| 46.53 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.4% \| +0.4% \| 281.1 KB \| 282.35 KB \| 48.55 KB \| 48.74 KB \| RN_OSS_PROFILING\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler-reflection.development.js \| 0.0% \| -0.0% \| 16.13 KB \| 16.13 KB \| 4.88 KB \| 4.88 KB \| NODE_DEV\nreact-reconciler.development.js \| +0.3% \| +0.4% \| 587.4 KB \| 589.34 KB \| 123.77 KB \| 124.24 KB \| NODE_DEV\nreact-reconciler.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.6% \| 79.09 KB \| 79.47 KB \| 23.26 KB \| 23.4 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 86da5ce041477efb70aa7b4d70df53f001a985bb\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: a8f2165e83ad09513b0eae239099e6e1f6d149cc...86da5ce041477efb70aa7b4d70df53f001a985bb</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.3% \| 118.51 KB \| 118.87 KB \| 37.18 KB \| 37.28 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 61.81 KB \| 61.81 KB \| 16.37 KB \| 16.37 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| +0.3% \| +0.2% \| 401.99 KB \| 403.12 KB \| 72.84 KB \| 73 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 19.46 KB \| 19.46 KB \| 7.3 KB \| 7.3 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 4.81 KB \| 4.81 KB \| 1.61 KB \| 1.61 KB \| UMD_DEV\nreact-dom.profiling.min.js \| +0.3% \| +0.2% \| 122.37 KB \| 122.72 KB \| 38.33 KB \| 38.41 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.19 KB \| 1.19 KB \| 698 B \| 697 B \| UMD_PROD\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 128.22 KB \| 128.22 KB \| 34.32 KB \| 34.32 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 19.87 KB \| 19.87 KB \| 7.45 KB \| 7.44 KB \| NODE_PROD\nReactDOMForked-dev.js \| +0.2% \| +0.2% \| 992.2 KB \| 994.24 KB \| 220.14 KB \| 220.61 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 417.61 KB \| 418.73 KB \| 75.05 KB \| 75.21 KB \| FB_WWW_PROD\nreact-dom.development.js \| +0.2% \| +0.2% \| 893.84 KB \| 895.84 KB \| 196.19 KB \| 196.65 KB \| UMD_DEV\nReactDOMForked-profiling.js \| +0.3% \| +0.2% \| 428.49 KB \| 429.61 KB \| 76.93 KB \| 77.1 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.16 KB \| 1.16 KB \| 660 B \| 659 B \| NODE_PROD\nreact-dom.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.3% \| 118.41 KB \| 118.76 KB \| 37.95 KB \| 38.06 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 19.55 KB \| 19.55 KB \| 7.33 KB \| 7.32 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.3% \| +0.4% \| 122.12 KB \| 122.47 KB \| 39.08 KB \| 39.23 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| +0.2% \| +0.2% \| 945.27 KB \| 947.31 KB \| 210.38 KB \| 210.86 KB \| FB_WWW_DEV\nreact-dom.development.js \| +0.2% \| +0.2% \| 850.91 KB \| 852.85 KB \| 193.78 KB \| 194.25 KB \| NODE_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 401.99 KB \| 403.12 KB \| 72.84 KB \| 73 KB \| FB_WWW_PROD\nReactDOM-dev.js \| +0.2% \| +0.2% \| 992.2 KB \| 994.24 KB \| 220.14 KB \| 220.61 KB \| FB_WWW_DEV\nReactDOM-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 417.61 KB \| 418.73 KB \| 75.05 KB \| 75.21 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 57.18 KB \| 57.18 KB \| 15.73 KB \| 15.73 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 4.33 KB \| 4.33 KB \| 1.51 KB \| 1.51 KB \| NODE_DEV\nReactDOM-profiling.js \| +0.3% \| +0.2% \| 428.49 KB \| 429.61 KB \| 76.93 KB \| 77.1 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1 KB \| 1 KB \| 610 B \| 609 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 9.73 KB \| 9.73 KB \| 3.25 KB \| 3.25 KB \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.3% \| +0.4% \| 646.38 KB \| 648.42 KB \| 138.81 KB \| 139.29 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.4% \| 269.18 KB \| 270.43 KB \| 46.33 KB \| 46.53 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.4% \| +0.4% \| 281.08 KB \| 282.34 KB \| 48.54 KB \| 48.73 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.3% \| +0.4% \| 628.09 KB \| 630.13 KB \| 134.37 KB \| 134.86 KB \| RN_OSS_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.4% \| 261.16 KB \| 262.42 KB \| 44.83 KB \| 45.02 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.5% \| +0.4% \| 273.07 KB \| 274.32 KB \| 47.05 KB \| 47.24 KB \| RN_OSS_PROFILING\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| +0.4% \| +0.4% \| 527.56 KB \| 529.5 KB \| 113.7 KB \| 114.16 KB \| NODE_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.4% \| 71.32 KB \| 71.75 KB \| 21.48 KB \| 21.58 KB \| NODE_PROD\nReactART-dev.js \| +0.3% \| +0.4% \| 589.01 KB \| 591.05 KB \| 123.49 KB \| 123.95 KB \| FB_WWW_DEV\nReactART-prod.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.5% \| 247.01 KB \| 248.27 KB \| 41.75 KB \| 41.95 KB \| FB_WWW_PROD\nreact-art.development.js \| +0.3% \| +0.3% \| 622.73 KB \| 624.73 KB \| 131.38 KB \| 131.84 KB \| UMD_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.2% \| 106.28 KB \| 106.71 KB \| 32.26 KB \| 32.32 KB \| UMD_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer-shallow.development.js \| 0.0% \| 0.0% \| 38.62 KB \| 38.62 KB \| 9.39 KB \| 9.39 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.73 KB \| 12.73 KB \| 3.96 KB \| 3.97 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.4% \| +0.4% \| 534.39 KB \| 536.33 KB \| 115.14 KB \| 115.62 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.5% \| 73.13 KB \| 73.56 KB \| 22 KB \| 22.1 KB \| NODE_PROD\nReactTestRenderer-dev.js \| +0.4% \| +0.4% \| 568.21 KB \| 570.25 KB \| 119.8 KB \| 120.28 KB \| FB_WWW_DEV\nreact-test-renderer.development.js \| +0.4% \| +0.4% \| 560.5 KB \| 562.49 KB \| 116.58 KB \| 117.05 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.5% \| 73.3 KB \| 73.73 KB \| 22.31 KB \| 22.41 KB \| UMD_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| +0.3% \| +0.4% \| 565.56 KB \| 567.5 KB \| 119.53 KB \| 119.99 KB \| NODE_DEV\nreact-reconciler.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.5% \| 76.13 KB \| 76.5 KB \| 22.55 KB \| 22.65 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 86da5ce041477efb70aa7b4d70df53f001a985bb\n</p>\n", "I know you've been busy @acdlite, but friendly ping on this :smile:\r\n\r\nDave was talking to me this afternoon about a bug he's seeing with Recoil and I'd like to at least sync this so we can see if the fix helped or not.", "I think this test captures the mount/flicker case we talked about:\r\n```js\r\nit(\"blah\", async () => {\r\n const source = createSource(\"one\");\r\n const mutableSource = createMutableSource(source);\r\n\r\n let committedA = null;\r\n let committedB = null;\r\n\r\n const onRender = () => {\r\n if (committedB !== null) {\r\n expect(committedA).toBe(committedB);\r\n }\r\n };\r\n\r\n function ComponentA() {\r\n const snapshot = useMutableSource(\r\n mutableSource,\r\n defaultGetSnapshot,\r\n defaultSubscribe\r\n );\r\n Scheduler.unstable_yieldValue(`a:${snapshot}`);\r\n React.useEffect(() => {\r\n committedA = snapshot;\r\n }, [snapshot]);\r\n return <div>{`a:${snapshot}`}</div>;\r\n }\r\n function ComponentB() {\r\n const snapshot = useMutableSource(\r\n mutableSource,\r\n defaultGetSnapshot,\r\n defaultSubscribe\r\n );\r\n Scheduler.unstable_yieldValue(`b:${snapshot}`);\r\n React.useEffect(() => {\r\n committedB = snapshot;\r\n }, [snapshot]);\r\n return <div>{`b:${snapshot}`}</div>;\r\n }\r\n\r\n // Mount ComponentA with data version 1\r\n act(() => {\r\n ReactNoop.render(\r\n <React.Profiler id=\"root\" onRender={onRender}>\r\n <ComponentA />\r\n </React.Profiler>,\r\n () => Scheduler.unstable_yieldValue(\"Sync effect\")\r\n );\r\n });\r\n expect(Scheduler).toHaveYielded([\"a:one\", \"Sync effect\"]);\r\n expect(source.listenerCount).toBe(1);\r\n\r\n // Mount ComponentB with version 1 (but don't commit it)\r\n act(() => {\r\n ReactNoop.render(\r\n <React.Profiler id=\"root\" onRender={onRender}>\r\n <ComponentA />\r\n <ComponentB />\r\n </React.Profiler>,\r\n () => Scheduler.unstable_yieldValue(\"Sync effect\")\r\n );\r\n expect(Scheduler).toFlushAndYieldThrough([\"a:one\", \"b:one\", \"Sync effect\"]);\r\n expect(source.listenerCount).toBe(1);\r\n\r\n // Mutate -> schedule update for ComponentA\r\n Scheduler.unstable_runWithPriority(Scheduler.unstable_IdlePriority, () => {\r\n source.value = \"two\";\r\n });\r\n\r\n // Commit ComponentB -> notice the change and schedule an update for ComponentB\r\n expect(Scheduler).toFlushAndYield([\"a:two\", \"b:two\"]);\r\n expect(source.listenerCount).toBe(2);\r\n });\r\n});\r\n\r\n```", "I think the problem with what we talked about - only storing the lowest priority (highest expiration time) pending update - is that we are trying to use a single value for two things:\r\n1. Flush all pending work for a root in certain cases (using `markRootExpiredAtTime`). The lowest priority works well for this.\r\n2. Determine if it's safe to read from a source when we haven't subscribed yet or when `getSnapshot` changes (by comparing the pending time to `renderExpirationTime`). The lowest priority doesn't work for this because it can give us a false positive. (See the currently failing test for an example.)\r\n\r\nTo be clear, I think the tests only happened to work before. I think this was a potential problem then too.\r\n\r\nFor now I'll push the new flicker test, with the fix, but I'm not sure how to work around this second issue.", "For the other types of pending work, we track the range:\r\n\r\nhttps://github.com/facebook/react/blob/58afba06636300fd652924e3033916fc96142e13/packages/react-reconciler/src/ReactFiberRoot.js#L66-L73\r\n\r\nWe can do the same thing here", "> For the other types of pending work, we track the range\r\n\r\nYeah. That's what I ended up thinking too. I'll take a pass at it soon.\r\n\r\nFWIW, I did try doing a naive version of this yesterday (just tracking lowest and highest priority) and it didn't seem sufficient, but I'll take another pass. Got distracted by some other reviews.", "Gah. I had a small, stupid mistake in my first try at the separate expiration times, and it just took me 2 hours of staring at the code to spot it.\r\n", "Ok back to you @acdlite", "> This is flipped.\r\n\r\nAh. Assuming you just mean in this one place (and not everywhere) then I think tracking the \"first\" time may not be necessary. (Same thing as I said with my comment above, but with the labels swapped since I still can't make my brain think of the `expirationTime` with the lowest value as being the \"last\" time.)\r\n\r\nGoing to push this change as a separate commit as well, to make it easier for you to review in isolation: db511f4" ]	2020-03-13 00:48:57	2020-04-03 17:20:21	2020-04-03 17:20:18	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18297', 'html_url': 'https://github.com/facebook/react/pull/18297', 'diff_url': 'https://github.com/facebook/react/pull/18297.diff', 'patch_url': 'https://github.com/facebook/react/pull/18297.patch', 'merged_at': datetime.datetime(2020, 4, 3, 17, 20, 18)}	Pulls in @acdlite's failing tests from #18296. Fixes one, leaves TODO comment for addressing the other two once we have a mechanism to do so. (Currently some temporary tearing is possible between passive effect flushes.)	{'url': 'https://api.github.com/repos/facebook/react/issues/18297/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18297/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18296	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18296/labels{/name}	https://api.github.com/repos/facebook/react/issues/18296/comments	https://api.github.com/repos/facebook/react/issues/18296/events	https://github.com/facebook/react/pull/18296	580,298,975	MDExOlB1bGxSZXF1ZXN0Mzg3NTM0Mjkx	18,296	Failing test case for useMutableSource	{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	{'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18296/builds/15627) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 371c14ec710d2a0f3035dbbf7f03eb057c3bc46e:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[spring-cache-e35ei](https://codesandbox.io/s/spring-cache-e35ei)\| Configuration \|\n", "Nice! Thanks for the test case. I'll fix this in the morning.", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 371c14ec710d2a0f3035dbbf7f03eb057c3bc46e\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 371c14ec710d2a0f3035dbbf7f03eb057c3bc46e\n</p>\n", "Thanks again!\r\n\r\n#18297", "@bvaughn I pushed another test case. Mind taking a look at that, too?\r\n", "On it.", "Also I probably shouldn't have written the description as if this were specific to passive effects, since it applies to a mutation in an interleaved event during render, too.", "I think what the second test case indicates is that we aren't resetting the queue properly here:\r\n\r\n```js\r\nstateHook.baseQueue = null;\r\nsnapshot = readFromUnsubcribedMutableSource(root, source, getSnapshot);\r\nstateHook.memoizedState = stateHook.baseState = snapshot;\r\n```\r\n\r\nThat clears the updates, but what we also need to do is create an entire new `queue` object and re-bind the `setState` method. So that even if there are interleaved updates, they get pushed to the older queue.", "Yeah, I was noticing that.\r\n\r\nThanks for the pointer :smile:", "More concretely:\r\n\r\n```js\r\nconst newQueue = {\r\n pending: null,\r\n dispatch: null,\r\n lastRenderedReducer: basicStateReducer,\r\n lastRenderedState: whatever,\r\n};\r\nnewQueue.dispatch = dispatchAction.bind(currentlyRenderingFiber, newQueue);\r\n\r\n// Now when this becomes current, the previous queue and dispatch method\r\n// are complete discarded, including any interleaving updates that occur.\r\nhook.queue = newQueue;\r\n```", "😆 Yes, thanks...", "From my investigation, the effect that updates the `getSnapshot` ref does run and queue a state update with the correct value- but the earlier one in `handleChange` wins out with the old `getSnapshot` value. So disconnecting the old queue/dispatch function seems reasonable.\r\n\r\nIt doesn't fix this case though, and it also breaks several others 😅so I need to dig some more.", "It's interesting that removing the first hook \"fixes\" the problem above for the second hook.\r\n\r\nI commented out the first hook temporarily (and hard-coded the value of `first`) just to reduce noise in my logs, and the final state of `second` after the new dispatcher and mutation is now correct. The state update in `useEffect` that syncs `getSnapshot` gets applied correctly.", "One noticeable difference is eager state computation. Not sure if it's relevant. It only happens for the first state hook on a given fiber that schedules an update. So if `second` is the only one, its state gets eagerly evaluated during the mutation. If `first` is the first state hook to update, `second` state doesn't get eagerly snapshot.\r\n\r\nUpdate It seems the eager comparison prevents an update from being scheduled on the fiber when the change handler gets called for `second` (because the values are the same). When the `getSnapshot` syncing effect later updates, we schedule another state update. But if the eager comparison doesn't get run, we schedule an update initially - and then another update when the `getSnapshot` syncing effect runs, at a lower expiration time - but that update is ignored when the component re-renders.", "I think I can write a similarly broken test case with just the state hook, but maybe I'm misunderstanding something.\r\n\r\n```js\r\nit(\"repro\", async () => {\r\n let setStateA;\r\n let setStateB;\r\n\r\n function App({ count }) {\r\n const [a, setA] = React.useState(\"initial-a\");\r\n const [b, setB] = React.useState(\"initial-b\");\r\n React.useEffect(() => {\r\n if (count === 1) {\r\n setA(\"cascading-a\");\r\n setB(\"cascading-b\");\r\n }\r\n }, [count]);\r\n setStateA = setA;\r\n setStateB = setB;\r\n return `${a}:${b}`;\r\n }\r\n\r\n const root = ReactNoop.createRoot();\r\n await act(async () => {\r\n root.render(<App count={0} />);\r\n });\r\n\r\n await act(async () => {\r\n root.render(<App count={1} />);\r\n // Render and finish the tree, but yield before passive effects fire.\r\n expect(Scheduler).toFlushUntilNextPaint([]);\r\n // This is at high priority so that it doesn't get batched with default\r\n // priority updates that might fire during the passive effect\r\n ReactNoop.discreteUpdates(() => {\r\n setStateB(\"high-pri-b\");\r\n });\r\n expect(Scheduler).toFlushUntilNextPaint([]);\r\n expect(root.getChildrenAsJSX()).toEqual(\"cascading-a:high-pri-b\");\r\n });\r\n});\r\n```\r\n\r\nRather than a final state of `\"cascading-a:high-pri-b\"`, the above results in a final state of `\"initial-a:high-pri-b\"`.", "The test you wrote is correct. I think the confusion is because there's another paint after that one, at normal priority, that does the cascading updates. Here's that same test with more assertions added:\r\n\r\n```js\r\nit('repro', async () => {\r\n let setStateA;\r\n let setStateB;\r\n\r\n function App({count}) {\r\n const [a, setA] = React.useState('initial-a');\r\n const [b, setB] = React.useState('initial-b');\r\n React.useEffect(() => {\r\n if (count === 1) {\r\n setA('cascading-a');\r\n setB('cascading-b');\r\n }\r\n }, [count]);\r\n setStateA = setA;\r\n setStateB = setB;\r\n return `${a}:${b}`;\r\n }\r\n\r\n const root = ReactNoop.createRoot();\r\n await act(async () => {\r\n root.render(<App count={0} />);\r\n });\r\n\r\n await act(async () => {\r\n root.render(<App count={1} />);\r\n // Render and finish the tree, but yield before passive effects fire.\r\n expect(Scheduler).toFlushUntilNextPaint([]);\r\n expect(root).toMatchRenderedOutput('initial-a:initial-b');\r\n // This is at high priority so that it doesn't get batched with default\r\n // priority updates that might fire during the passive effect\r\n ReactNoop.discreteUpdates(() => {\r\n setStateB('high-pri-b');\r\n });\r\n expect(Scheduler).toFlushUntilNextPaint([]);\r\n // High pri updates have finished, but not the cascading ones,\r\n // which have normal pri\r\n expect(root).toMatchRenderedOutput('initial-a:high-pri-b');\r\n });\r\n // Now the final state has rendered, including the cascading updates\r\n expect(root).toMatchRenderedOutput('cascading-a:cascading-b');\r\n});\r\n```", "I see. Thanks for clarifying.\r\n\r\nI wonder why I'm seeing the update clobber in the way I'm seeing for uMS's internal state hook.", "Okay, looking at this again today.\r\n\r\nDisconnecting dispatch from the update queue works to prevent the old B selector from overriding the new A selector value when A is mutated- but the mutation to A is also missed temporarily (since the subscribe function is still using the previous `getSnapshot` at this point).\r\n\r\nThe effect that updates `getSnapshot` sees the change, and uses the newly bound `dispatchAction` method to schedule the \"missed\" update, but when the component renders- the \"missed\" update is scheduled at an insufficient expiration time, so it's skipped for that update (and tearing happens for A<sub>0</sub> and A<sub>1</sub>).\r\n\r\nI think the `getSnapshot` effect needs to schedule its missed update at a higher priority, to make sure it's included in the next render- that or just replace the intermediate update entirely (but that seems shady).", "Gah I did it again!", "@bvaughn \r\n\r\n> I think the getSnapshot effect needs to schedule its missed update at a higher priority, to make sure it's included in the next render- that or just replace the intermediate update entirely (but that seems shady).\r\n\r\nI think that's the right idea, except it's not only limited to high priority updates. It could be a lower priority update, too. (I pushed another test case to cover that.)\r\n\r\nWhat's tricky is there could be multiple pending mutations at different priorities. None of them should be allowed to commit without also committing the new update.\r\n\r\nWe've been using the word \"entanglement\" to describe this behavior. We don't have a mechanism to do this without de-opting, currently, but I'm planning to add one as part of the `useTransition` improvements. (This is the \"terminal updates\" problem.)\r\n\r\nIn the meantime, I think we should synchronously flush the pending mutation updates. Then we can do the entanglement thing once that exists.\r\n\r\n~~I'll push a commit to show what I mean.~~ Nvm, it's only one line so I'll post here instead:\r\n\r\n```js\r\nimport {markRootExpiredAtTime} from './ReactFiberRoot';\r\nmarkRootExpiredAtTime(root.mutableSourcePendingUpdateTime);\r\n```", "Thanks for the added context, Andrew.\r\n\r\nUsing `markRootExpiredAtTime` means that tests two and three will temporarily tear. (I'm actually not seeing any difference in behavior for the tests whether I use `markRootExpiredAtTime` or not.)\r\n\r\nI've pushed an update to #18297 though.\r\n\r\nEdit I wonder if it's worth considering pushing a layout effect when `getSnapshot` changes, to avoid the temporary tear being visible? This would require some changes to the way the hook is implemented." ]	2020-03-13 00:31:49	2020-04-02 19:42:22	2020-04-02 19:42:22	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18296', 'html_url': 'https://github.com/facebook/react/pull/18296', 'diff_url': 'https://github.com/facebook/react/pull/18296.diff', 'patch_url': 'https://github.com/facebook/react/pull/18296.patch', 'merged_at': None}	Scenario: `getSnapshot` changes during render. The render finishes and commits. But before the passive effects fire, the source is mutated again. The subscription still thinks the old `getSnapshot` is current. I think this means that whenever `getSnapshot` changes, we need to check if there was a mutation since render. Similar to what we do when resubscribing.	{'url': 'https://api.github.com/repos/facebook/react/issues/18296/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1}	https://api.github.com/repos/facebook/react/issues/18296/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18295	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18295/labels{/name}	https://api.github.com/repos/facebook/react/issues/18295/comments	https://api.github.com/repos/facebook/react/issues/18295/events	https://github.com/facebook/react/issues/18295	580,298,638	MDU6SXNzdWU1ODAyOTg2Mzg=	18,295	4563	{'login': 'mertxe78', 'id': 61938403, 'node_id': 'MDQ6VXNlcjYxOTM4NDAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/61938403?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mertxe78', 'html_url': 'https://github.com/mertxe78', 'followers_url': 'https://api.github.com/users/mertxe78/followers', 'following_url': 'https://api.github.com/users/mertxe78/following{/other_user}', 'gists_url': 'https://api.github.com/users/mertxe78/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/mertxe78/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/mertxe78/subscriptions', 'organizations_url': 'https://api.github.com/users/mertxe78/orgs', 'repos_url': 'https://api.github.com/users/mertxe78/repos', 'events_url': 'https://api.github.com/users/mertxe78/events{/privacy}', 'received_events_url': 'https://api.github.com/users/mertxe78/received_events', 'type': 'User', 'site_admin': False}	[]	closed	false	null	[]	null	[]	2020-03-13 00:30:22	2020-03-13 01:05:35	2020-03-13 00:32:18	NONE	null	null	null	null	{'url': 'https://api.github.com/repos/facebook/react/issues/18295/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18295/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18294	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18294/labels{/name}	https://api.github.com/repos/facebook/react/issues/18294/comments	https://api.github.com/repos/facebook/react/issues/18294/events	https://github.com/facebook/react/issues/18294	580,170,614	MDU6SXNzdWU1ODAxNzA2MTQ=	18,294	Bug: renderToString & Inconsistent Behavior Updating State	{'login': 'michaelyuen', 'id': 6335559, 'node_id': 'MDQ6VXNlcjYzMzU1NTk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6335559?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/michaelyuen', 'html_url': 'https://github.com/michaelyuen', 'followers_url': 'https://api.github.com/users/michaelyuen/followers', 'following_url': 'https://api.github.com/users/michaelyuen/following{/other_user}', 'gists_url': 'https://api.github.com/users/michaelyuen/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/michaelyuen/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/michaelyuen/subscriptions', 'organizations_url': 'https://api.github.com/users/michaelyuen/orgs', 'repos_url': 'https://api.github.com/users/michaelyuen/repos', 'events_url': 'https://api.github.com/users/michaelyuen/events{/privacy}', 'received_events_url': 'https://api.github.com/users/michaelyuen/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "_ # ## _ ", ">TLDR: renderToString will re-render a component due to a state change, but only if the state is defined in that component.\r\n\r\nThis is the expected behavior.\r\n\r\n>TLDR: renderToString will re-render a component due to a state change defined in a component and updated in another component.\r\n\r\nThis can't possibly work unless we buffer all HTML, negating the possible benefits of streaming. Cause you won't know that something later might cause a state to update.\r\n\r\nEven if we did support that, it would be slow because we would have to add a lot of machinery to track state updates during a server render. So we won't be doing this.\r\n\r\nWe have a warning since React 16.13 for this. If you update your sandbox, you will see it." ]	2020-03-12 19:29:55	2020-03-30 15:27:02	2020-03-30 15:27:02	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> React version: 16.12.10 ## Overview I do not know if this is a bug or expected behavior; I'm hoping to receive that answer. I've searched docs, issues, etc. and haven't found a clear answer on the behavior expected by `renderToString` in this scenario. ## Steps To Reproduce This is not a fully implemented SSR example. The main thing to focus on is the result of `renderToString`. The pre-existing `render` remains for comparison purposes. 1. Open codesandbox 2. Review console logs <!-- Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Issues without reproduction steps or code examples may be immediately closed as not actionable. --> Link to code example: 1. [React SSR + Context](https://codesandbox.io/s/react-ssr-context-z4tqi) 2. [React SSR + Passed State](https://codesandbox.io/s/react-ssr-passed-state-yocro) <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior TLDR: renderToString will re-render a component due to a state change, but only if the state is defined in that component. In the first example (React SSR + Context), review the `App.js` file and notice there are two sets of state (value and setter), one defined _in_ App (this is important) and one defined in `context.js` and consumed with a custom hook. The code is written to update the state immediately in order to demonstrate what _I think_ is an inconsistency. Reviewing the logged `htmlString`, notice that it logs the "this will be server-rendered" html, but not the "this will NOT be server-rendered". To me, this means App's state change has been processed and re-rendered, but the state in context has not changed or triggered the consumer (App) to re-render. My big question here is why? In the second example (React SSR + Passed State), the setup is quite similar, but takes an even more direct approach by sharing state through props. This was intended to validate the theory that the previously noted observation is related to Context, however, this example demonstrates the same behavior. ## The expected behavior TLDR: renderToString will re-render a component due to a state change defined in a component and updated in another component. Seeing that the html string produced by `renderToString` indicates that the state defined and updated in `App` was processed, I expected the same behavior for the state defined in `TestProvider` and updated in `App`.	{'url': 'https://api.github.com/repos/facebook/react/issues/18294/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18294/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18293	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18293/labels{/name}	https://api.github.com/repos/facebook/react/issues/18293/comments	https://api.github.com/repos/facebook/react/issues/18293/events	https://github.com/facebook/react/pull/18293	580,165,378	MDExOlB1bGxSZXF1ZXN0Mzg3NDI4MTMy	18,293	Add <progress> to DOM fixtures	{'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers', 'following_url': 'https://api.github.com/users/bl00mber/following{/other_user}', 'gists_url': 'https://api.github.com/users/bl00mber/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bl00mber/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bl00mber/subscriptions', 'organizations_url': 'https://api.github.com/users/bl00mber/orgs', 'repos_url': 'https://api.github.com/users/bl00mber/repos', 'events_url': 'https://api.github.com/users/bl00mber/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bl00mber/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 44c383c0b1b09b2a8baa8f613040fabf5fa34a57\n</p>\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18293/builds/17746) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 44c383c0b1b09b2a8baa8f613040fabf5fa34a57:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[awesome-smoke-ljdrt](https://codesandbox.io/s/awesome-smoke-ljdrt)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 44c383c0b1b09b2a8baa8f613040fabf5fa34a57\n</p>\n", "Thanks." ]	2020-03-12 19:18:21	2020-04-03 13:40:01	2020-04-03 13:40:00	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18293', 'html_url': 'https://github.com/facebook/react/pull/18293', 'diff_url': 'https://github.com/facebook/react/pull/18293.diff', 'patch_url': 'https://github.com/facebook/react/pull/18293.patch', 'merged_at': datetime.datetime(2020, 4, 3, 13, 40)}	resolve #13518 ![gif](https://user-images.githubusercontent.com/16987322/76558837-d8612e00-64bf-11ea-9953-2f7b2ee34854.gif)	{'url': 'https://api.github.com/repos/facebook/react/issues/18293/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18293/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18292	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18292/labels{/name}	https://api.github.com/repos/facebook/react/issues/18292/comments	https://api.github.com/repos/facebook/react/issues/18292/events	https://github.com/facebook/react/pull/18292	580,091,796	MDExOlB1bGxSZXF1ZXN0Mzg3MzY3NTky	18,292	ReactDOM.useEvent: Add DOM host event listener logic	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18292/builds/14491) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 9f7a3d07032975755eee55510e4312891143c7af:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[happy-forest-jh84l](https://codesandbox.io/s/happy-forest-jh84l)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: d3ec42020d220777bf589bec36c9cd8300ec9742...a90015f7411e8d9dbbae5d9aa99df2de01869a8f</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| -0.0% \| 0.0% \| 427.55 KB \| 427.5 KB \| 77.54 KB \| 77.58 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| -0.1% \| 0.0% \| 12.3 KB \| 12.29 KB \| 4.52 KB \| 4.52 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 58.22 KB \| 58.22 KB \| 14.53 KB \| 14.53 KB \| UMD_DEV\nReactDOMForked-dev.js \| +0.1% \| +0.1% \| 979.92 KB \| 980.96 KB \| 217.75 KB \| 218.01 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| -0.0% \| 0.0% \| 409.9 KB \| 409.85 KB \| 74.43 KB \| 74.47 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nreact-dom.development.js \| +0.1% \| +0.1% \| 901.13 KB \| 901.93 KB \| 198.28 KB \| 198.51 KB \| UMD_DEV\nReactDOMForked-profiling.js \| -0.0% \| 0.0% \| 427.55 KB \| 427.5 KB \| 77.54 KB \| 77.58 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 135.83 KB \| 135.83 KB \| 34.97 KB \| 34.97 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1.15 KB \| 1.15 KB \| 653 B \| 654 B \| NODE_PROD\nreact-dom.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 118.18 KB \| 118.22 KB \| 37.96 KB \| 37.99 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.16 KB \| 20.16 KB \| 7.46 KB \| 7.46 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 121.89 KB \| 121.93 KB \| 39.17 KB \| 39.18 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| +0.1% \| +0.1% \| 916.84 KB \| 917.64 KB \| 204.53 KB \| 204.73 KB \| FB_WWW_DEV\nreact-dom.development.js \| +0.1% \| +0.1% \| 857.63 KB \| 858.4 KB \| 195.79 KB \| 196.01 KB \| NODE_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 390.34 KB \| 390.66 KB \| 71.1 KB \| 71.14 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 128.87 KB \| 128.87 KB \| 34.52 KB \| 34.52 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.26 KB \| 118.3 KB \| 37.17 KB \| 37.18 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| -0.0% \| 0.0% \| 59.83 KB \| 59.83 KB \| 15.85 KB \| 15.85 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| +0.1% \| +0.1% \| 390.34 KB \| 390.66 KB \| 71.1 KB \| 71.14 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 3.34 KB \| 3.34 KB \| 1.26 KB \| 1.26 KB \| UMD_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 122.12 KB \| 122.16 KB \| 38.36 KB \| 38.38 KB \| NODE_PROFILING\nreact-dom-test-utils.production.min.js \| -0.1% \| -0.0% \| 12.44 KB \| 12.43 KB \| 4.6 KB \| 4.59 KB \| UMD_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 1.17 KB \| 1.17 KB \| 690 B \| 691 B \| UMD_PROD\nReactDOM-dev.js \| +0.1% \| +0.1% \| 979.92 KB \| 980.96 KB \| 217.75 KB \| 218.01 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 139.01 KB \| 139.01 KB \| 35.48 KB \| 35.48 KB \| FB_WWW_DEV\nReactDOM-prod.js \| -0.0% \| 0.0% \| 409.9 KB \| 409.85 KB \| 74.43 KB \| 74.47 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| -0.0% \| 0.0% \| 55.28 KB \| 55.27 KB \| 15.23 KB \| 15.23 KB \| NODE_DEV\nReactDOMServer-prod.js \| 0.0% \| 0.0% \| 47.71 KB \| 47.71 KB \| 11.11 KB \| 11.11 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nReactTestUtils-dev.js \| -0.0% \| -0.0% \| 57.48 KB \| 57.48 KB \| 15.54 KB \| 15.54 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 55.21 KB \| 55.21 KB \| 14.3 KB \| 14.3 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| 0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a90015f7411e8d9dbbae5d9aa99df2de01869a8f\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: d3ec42020d220777bf589bec36c9cd8300ec9742...a90015f7411e8d9dbbae5d9aa99df2de01869a8f</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.51 KB \| 126.55 KB \| 39.57 KB \| 39.59 KB \| NODE_PROFILING\nReactDOM-dev.js \| +0.1% \| +0.1% \| 933.99 KB \| 935.08 KB \| 207.85 KB \| 208.11 KB \| FB_WWW_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 1.19 KB \| 1.19 KB \| 698 B \| 699 B \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 137.42 KB \| 137.42 KB \| 35.17 KB \| 35.17 KB \| UMD_DEV\nReactTestUtils-dev.js \| -0.0% \| -0.0% \| 57.48 KB \| 57.48 KB \| 15.54 KB \| 15.54 KB \| FB_WWW_DEV\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 130.38 KB \| 130.38 KB \| 34.74 KB \| 34.74 KB \| NODE_DEV\nreact-dom.development.js \| +0.1% \| +0.1% \| 931.62 KB \| 932.42 KB \| 203.54 KB \| 203.78 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 58.24 KB \| 58.24 KB \| 14.54 KB \| 14.54 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.38 KB \| 122.42 KB \| 39.13 KB \| 39.14 KB \| UMD_PROD\nReactDOMForked-dev.js \| +0.1% \| +0.1% \| 933.99 KB \| 935.08 KB \| 207.85 KB \| 208.11 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.32 KB \| 10.32 KB \| 3.49 KB \| 3.5 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.34 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.21 KB \| 126.25 KB \| 40.37 KB \| 40.38 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| -0.0% \| 0.0% \| 383.29 KB \| 383.18 KB \| 69.69 KB \| 69.71 KB \| FB_WWW_PROD\nreact-dom.development.js \| +0.1% \| +0.1% \| 886.84 KB \| 887.61 KB \| 201.03 KB \| 201.26 KB \| NODE_DEV\nReactDOMForked-profiling.js \| -0.0% \| 0.0% \| 400.88 KB \| 400.77 KB \| 72.73 KB \| 72.74 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 55.23 KB \| 55.23 KB \| 14.31 KB \| 14.31 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 122.53 KB \| 122.57 KB \| 38.29 KB \| 38.3 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nReactDOM-prod.js \| -0.0% \| 0.0% \| 383.29 KB \| 383.18 KB \| 69.69 KB \| 69.71 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| -0.0% \| 0.0% \| 400.88 KB \| 400.77 KB \| 72.73 KB \| 72.74 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nreact-dom-test-utils.development.js \| -0.0% \| 0.0% \| 59.85 KB \| 59.84 KB \| 15.86 KB \| 15.86 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| -0.1% \| -0.0% \| 12.45 KB \| 12.44 KB \| 4.6 KB \| 4.6 KB \| UMD_PROD\nReactDOMTesting-dev.js \| +0.1% \| +0.1% \| 890.19 KB \| 890.99 KB \| 199.02 KB \| 199.23 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.1% \| 0.0% \| 376.78 KB \| 377.01 KB \| 68.91 KB \| 68.93 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| -0.0% \| 0.0% \| 55.29 KB \| 55.29 KB \| 15.24 KB \| 15.24 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| +0.1% \| 0.0% \| 376.78 KB \| 377.01 KB \| 68.91 KB \| 68.93 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| -0.1% \| -0.0% \| 12.31 KB \| 12.3 KB \| 4.53 KB \| 4.53 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: :small_red_triangle:+0.1%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a90015f7411e8d9dbbae5d9aa99df2de01869a8f\n</p>\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18292/builds/14546) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit a90015f7411e8d9dbbae5d9aa99df2de01869a8f:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[fancy-waterfall-v9t2l](https://codesandbox.io/s/fancy-waterfall-v9t2l)\| Configuration \|\n" ]	2020-03-12 17:19:26	2020-03-17 14:45:25	2020-03-12 22:41:34	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18292', 'html_url': 'https://github.com/facebook/react/pull/18292', 'diff_url': 'https://github.com/facebook/react/pull/18292.diff', 'patch_url': 'https://github.com/facebook/react/pull/18292.patch', 'merged_at': datetime.datetime(2020, 3, 12, 22, 41, 34)}	This PR adds the DOM event listener logic. As the useEvent hook has not yet been wired up to the host config, it's not yet possible to add tests – but those will come in the next PR. I've detailed with comments how each part of the event listener logic works with `useEvent` "listeners", so hopefully it should flow and makes sense for those reviewing. In essense, we have a new internal listeners Set that we attach to DOM target instances. Target instances, are those will be attached via `useEvent`'s `setListener` API. In a follow up PR, we'll use this listeners Set to find any attached listener functions, to know to fire them.	{'url': 'https://api.github.com/repos/facebook/react/issues/18292/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1}	https://api.github.com/repos/facebook/react/issues/18292/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18291	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18291/labels{/name}	https://api.github.com/repos/facebook/react/issues/18291/comments	https://api.github.com/repos/facebook/react/issues/18291/events	https://github.com/facebook/react/pull/18291	580,078,830	MDExOlB1bGxSZXF1ZXN0Mzg3MzU3MzY5	18,291	Remove manual feature flag overrides	{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18291/builds/14489) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 0c4baa5525a8940bc11e59ffde692a1e61da0ef4:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[gifted-bird-sbp5c](https://codesandbox.io/s/gifted-bird-sbp5c)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0c4baa5525a8940bc11e59ffde692a1e61da0ef4\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0c4baa5525a8940bc11e59ffde692a1e61da0ef4\n</p>\n" ]	2020-03-12 16:59:07	2020-03-12 17:17:03	2020-03-12 17:17:03	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18291', 'html_url': 'https://github.com/facebook/react/pull/18291', 'diff_url': 'https://github.com/facebook/react/pull/18291.diff', 'patch_url': 'https://github.com/facebook/react/pull/18291.patch', 'merged_at': datetime.datetime(2020, 3, 12, 17, 17, 3)}	Tests now run against both versions of these flags, using the test-www-variant command. So we can remove the manual overrides.	{'url': 'https://api.github.com/repos/facebook/react/issues/18291/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18291/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18290	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18290/labels{/name}	https://api.github.com/repos/facebook/react/issues/18290/comments	https://api.github.com/repos/facebook/react/issues/18290/events	https://github.com/facebook/react/issues/18290	579,845,048	MDU6SXNzdWU1Nzk4NDUwNDg=	18,290	Bug: IE11 throws error Assignment to read-only properties is not allowed in strict mode	{'login': 'Pinka', 'id': 5305497, 'node_id': 'MDQ6VXNlcjUzMDU0OTc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5305497?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Pinka', 'html_url': 'https://github.com/Pinka', 'followers_url': 'https://api.github.com/users/Pinka/followers', 'following_url': 'https://api.github.com/users/Pinka/following{/other_user}', 'gists_url': 'https://api.github.com/users/Pinka/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Pinka/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Pinka/subscriptions', 'organizations_url': 'https://api.github.com/users/Pinka/orgs', 'repos_url': 'https://api.github.com/users/Pinka/repos', 'events_url': 'https://api.github.com/users/Pinka/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Pinka/received_events', 'type': 'User', 'site_admin': False}	[{'id': 69105383, 'node_id': 'MDU6TGFiZWw2OTEwNTM4Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Browser:%20IE', 'name': 'Browser: IE', 'color': 'c7def8', 'default': False, 'description': None} {'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "Interesting that we didn't see reports about this before.", "@Pinka can you share some more details on what you were doing that triggered this error? If you could share a code sample that reproduces the problem in IE11 that would be very helpful.", "I've same issue, when I click on a button that change the state", "This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "bump; still affected\n\nOn Sat, Jul 25, 2020, 12:06 AM stale[bot] <notifications@github.com> wrote:\n\n> This issue has been automatically marked as stale. If this issue is\n> still affecting you, please leave any comment (for example, \"bump\"), and\n> we'll keep it open. We are sorry that we haven't been able to prioritize it\n> yet. If you have any new additional information, please include it with\n> your comment!\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/facebook/react/issues/18290#issuecomment-663804932>,\n> or unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/AALY5SXY7QDJJ6BYPUQTVLTR5JK25ANCNFSM4LGJHRUA>\n> .\n>\n", "I can confirm, I see the same on 16.13.1.\r\n\r\nAny suggestion?", "We need a full reproducing example.", "This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "bumb", "There hasn't been a reproducing example. The \"bump\" comments are not helpful when this is what was requested." ]	2020-03-12 10:38:37	2021-03-24 18:55:41	2021-03-24 18:55:40	NONE	null	null	null	When working in development mode in IE11 error is thrown in file react-dom.development.js line 185. Error: "Assignment to read-only properties is not allowed in strict mode" window.event is readOnly variable and IE11 is strict about it. ![image](https://user-images.githubusercontent.com/5305497/76511927-8509c400-645c-11ea-89c4-9f38a6e0a778.png) React version: 16.13.0 In production build there is no error as this code block is not included.	{'url': 'https://api.github.com/repos/facebook/react/issues/18290/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18290/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18289	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18289/labels{/name}	https://api.github.com/repos/facebook/react/issues/18289/comments	https://api.github.com/repos/facebook/react/issues/18289/events	https://github.com/facebook/react/pull/18289	579,804,895	MDExOlB1bGxSZXF1ZXN0Mzg3MTMyNDE1	18,289	Address feedback for accumulateTwoPhaseListeners	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18289/builds/14511) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 99813ca9f263531a88349cf22f0062969cb421cc:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[festive-lehmann-5xn48](https://codesandbox.io/s/festive-lehmann-5xn48)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 615df434bbecc357d47ce26e3d6362edec477050...99813ca9f263531a88349cf22f0062969cb421cc</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| -0.3% \| -0.4% \| 428.84 KB \| 427.55 KB \| 77.83 KB \| 77.54 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.83 KB \| 135.83 KB \| 34.97 KB \| 34.97 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.15 KB \| 1.15 KB \| 654 B \| 653 B \| NODE_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.16 KB \| 20.16 KB \| 7.46 KB \| 7.46 KB \| UMD_PROD\nReactTestUtils-dev.js \| +11.2% \| +12.8% \| 51.68 KB \| 57.48 KB \| 13.77 KB \| 15.54 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.development.js \| -1.3% \| -1.2% \| 55.92 KB \| 55.21 KB \| 14.48 KB \| 14.3 KB \| NODE_DEV\nreact-dom.development.js \| -0.3% \| -0.3% \| 903.67 KB \| 901.13 KB \| 198.96 KB \| 198.28 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom.production.min.js \| -0.4% \| -0.4% \| 118.67 KB \| 118.18 KB \| 38.09 KB \| 37.96 KB \| UMD_PROD\nreact-dom.profiling.min.js \| -0.4% \| -0.3% \| 122.38 KB \| 121.89 KB \| 39.29 KB \| 39.17 KB \| UMD_PROFILING\nreact-dom.development.js \| -0.3% \| -0.3% \| 860.04 KB \| 857.63 KB \| 196.46 KB \| 195.79 KB \| NODE_DEV\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\nreact-dom.production.min.js \| -0.4% \| -0.4% \| 118.75 KB \| 118.26 KB \| 37.31 KB \| 37.17 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\nreact-dom.profiling.min.js \| -0.4% \| -0.4% \| 122.61 KB \| 122.12 KB \| 38.51 KB \| 38.36 KB \| NODE_PROFILING\nReactDOM-dev.js \| -0.2% \| -0.3% \| 982.35 KB \| 979.92 KB \| 218.38 KB \| 217.75 KB \| FB_WWW_DEV\nReactDOM-prod.js \| -0.3% \| -0.4% \| 411.19 KB \| 409.9 KB \| 74.72 KB \| 74.43 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nReactDOMTesting-dev.js \| -0.3% \| -0.3% \| 919.27 KB \| 916.84 KB \| 205.1 KB \| 204.53 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| -0.3% \| -0.4% \| 391.63 KB \| 390.34 KB \| 71.38 KB \| 71.1 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 128.87 KB \| 128.87 KB \| 34.52 KB \| 34.52 KB \| NODE_DEV\nreact-dom-test-utils.development.js \| +11.1% \| +13.1% \| 53.84 KB \| 59.83 KB \| 14.01 KB \| 15.85 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| -0.3% \| -0.4% \| 391.63 KB \| 390.34 KB \| 71.38 KB \| 71.1 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.07 KB \| 20.07 KB \| 7.42 KB \| 7.42 KB \| NODE_PROD\nreact-dom-test-utils.production.min.js \| :small_red_triangle:+13.1% \| :small_red_triangle:+10.4% \| 11 KB \| 12.44 KB \| 4.16 KB \| 4.6 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 139.01 KB \| 139.01 KB \| 35.48 KB \| 35.48 KB \| FB_WWW_DEV\nreact-dom-test-utils.development.js \| +11.4% \| +12.7% \| 49.61 KB \| 55.28 KB \| 13.52 KB \| 15.23 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| :small_red_triangle:+13.4% \| :small_red_triangle:+10.4% \| 10.85 KB \| 12.3 KB \| 4.1 KB \| 4.53 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| -1.3% \| -1.2% \| 58.97 KB \| 58.22 KB \| 14.71 KB \| 14.53 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1013 B \| 1013 B \| 602 B \| 603 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.1% \| -0.1% \| 649.46 KB \| 649.85 KB \| 140.64 KB \| 140.52 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 266.95 KB \| 267.49 KB \| 46.45 KB \| 46.49 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.2% \| +0.1% \| 278.75 KB \| 279.28 KB \| 48.71 KB \| 48.75 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.1% \| -0.1% \| 631.32 KB \| 631.71 KB \| 136.28 KB \| 136.17 KB \| RN_OSS_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 258.94 KB \| 259.47 KB \| 44.96 KB \| 45.02 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.2% \| +0.1% \| 270.73 KB \| 271.26 KB \| 47.21 KB \| 47.26 KB \| RN_OSS_PROFILING\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 99813ca9f263531a88349cf22f0062969cb421cc\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 615df434bbecc357d47ce26e3d6362edec477050...99813ca9f263531a88349cf22f0062969cb421cc</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| -0.4% \| -0.3% \| 127 KB \| 126.51 KB \| 39.69 KB \| 39.57 KB \| NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| -1.3% \| -1.2% \| 58.98 KB \| 58.24 KB \| 14.72 KB \| 14.54 KB \| UMD_DEV\nReactDOM-dev.js \| -0.3% \| -0.3% \| 936.42 KB \| 933.99 KB \| 208.49 KB \| 207.85 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.32 KB \| 10.32 KB \| 3.5 KB \| 3.5 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.34 KB \| FB_WWW_DEV\nreact-dom-test-utils.development.js \| +11.1% \| +13.1% \| 53.85 KB \| 59.85 KB \| 14.02 KB \| 15.86 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| :small_red_triangle:+13.1% \| :small_red_triangle:+10.4% \| 11.01 KB \| 12.45 KB \| 4.17 KB \| 4.6 KB \| UMD_PROD\nReactDOMTesting-dev.js \| -0.3% \| -0.3% \| 892.62 KB \| 890.19 KB \| 199.7 KB \| 199.02 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| -0.3% \| -0.4% \| 378.07 KB \| 376.78 KB \| 69.19 KB \| 68.91 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| +11.4% \| +12.7% \| 49.63 KB \| 55.29 KB \| 13.53 KB \| 15.24 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| -0.3% \| -0.4% \| 378.07 KB \| 376.78 KB \| 69.19 KB \| 68.91 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| :small_red_triangle:+13.3% \| :small_red_triangle:+10.4% \| 10.86 KB \| 12.31 KB \| 4.11 KB \| 4.53 KB \| NODE_PROD\nreact-dom.development.js \| -0.3% \| -0.3% \| 934.16 KB \| 931.62 KB \| 204.25 KB \| 203.54 KB \| UMD_DEV\nreact-dom.production.min.js \| -0.4% \| -0.3% \| 122.87 KB \| 122.38 KB \| 39.23 KB \| 39.13 KB \| UMD_PROD\nReactTestUtils-dev.js \| +11.2% \| +12.8% \| 51.68 KB \| 57.48 KB \| 13.78 KB \| 15.54 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| -0.4% \| -0.3% \| 126.7 KB \| 126.21 KB \| 40.49 KB \| 40.37 KB \| UMD_PROFILING\nreact-dom.development.js \| -0.3% \| -0.3% \| 889.25 KB \| 886.84 KB \| 201.71 KB \| 201.03 KB \| NODE_DEV\nreact-dom.production.min.js \| -0.4% \| -0.4% \| 123.02 KB \| 122.53 KB \| 38.42 KB \| 38.29 KB \| NODE_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nReactDOM-prod.js \| -0.3% \| -0.4% \| 384.58 KB \| 383.29 KB \| 69.95 KB \| 69.7 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 47.01 KB \| 47.01 KB \| 10.93 KB \| 10.93 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| -0.3% \| -0.3% \| 402.17 KB \| 400.88 KB \| 72.98 KB \| 72.73 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| -1.3% \| -1.2% \| 55.94 KB \| 55.23 KB \| 14.48 KB \| 14.31 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.16 KB \| 1.16 KB \| 663 B \| 662 B \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1 KB \| 1 KB \| 610 B \| 611 B \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFabric-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 258.95 KB \| 259.48 KB \| 44.97 KB \| 45.03 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.2% \| +0.1% \| 270.75 KB \| 271.28 KB \| 47.21 KB \| 47.27 KB \| RN_OSS_PROFILING\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 266.96 KB \| 267.5 KB \| 46.45 KB \| 46.5 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.2% \| +0.1% \| 278.76 KB \| 279.3 KB \| 48.72 KB \| 48.76 KB \| RN_OSS_PROFILING\nReactNativeRenderer-dev.js \| +0.1% \| -0.1% \| 652.18 KB \| 652.57 KB \| 140.98 KB \| 140.86 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 267.11 KB \| 267.64 KB \| 46.48 KB \| 46.53 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| +0.2% \| +0.1% \| 278.9 KB \| 279.44 KB \| 48.74 KB \| 48.78 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| +0.1% \| -0.1% \| 631.33 KB \| 631.72 KB \| 136.29 KB \| 136.18 KB \| RN_OSS_DEV\nReactFabric-dev.js \| +0.1% \| -0.1% \| 634.04 KB \| 634.43 KB \| 136.61 KB \| 136.51 KB \| RN_FB_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 259.1 KB \| 259.63 KB \| 45 KB \| 45.06 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| +0.1% \| -0.1% \| 649.47 KB \| 649.86 KB \| 140.64 KB \| 140.52 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| +0.2% \| +0.1% \| 270.89 KB \| 271.43 KB \| 47.24 KB \| 47.29 KB \| RN_FB_PROFILING\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 99813ca9f263531a88349cf22f0062969cb421cc\n</p>\n", "> Unfortunately, we can't remove the old propagation code, because it's exported on ReactDOM's internals:\r\n\r\nIf it’s exported for the sake of TestUtils, can you copy it directly into TestUtils?\r\n\r\nSame with Responser plugin. \r\n\r\nThen we won’t have two versions of this code in the main bundle. ", "@gaearon Is that a breaking change?", "Does anything use it outside of TestUtils? Regarding Responder plugin, it depends on how that’s wired up on RNW. Can you find that on GitHub?", "@gaearon Doesn't look like it. @necolas would know more for sure though.", "@gaearon Too reduce risk, I've opted to inline the TestUtils, RN bridge and Responder bits of code they used from `EventPropagators.js` into their respective modules instead. Whilst at it, I also added Flow typing to `EventPropagators.js` to add some peace of mind. :)", "I don't think these changes will impact RNW. Hopefully will be dropping this dependency soon anyway" ]	2020-03-12 09:31:04	2020-03-12 21:48:34	2020-03-12 21:48:30	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18289', 'html_url': 'https://github.com/facebook/react/pull/18289', 'diff_url': 'https://github.com/facebook/react/pull/18289.diff', 'patch_url': 'https://github.com/facebook/react/pull/18289.patch', 'merged_at': datetime.datetime(2020, 3, 12, 21, 48, 30)}	This is a follow up to the feedback @gaearon left on https://github.com/facebook/react/pull/18274. Notably: - moves the `accumulateTwoPhaseListeners` function into its own file. - check length rather than using a boolean variable to determine if the event's `_dispatchListeners` and `_dispatchInstances` should be updated. - Inline `EventPropagators.js` functions that are not used by ReactDOM into the `ResponderPlugin` module, TestUtils and the React Native Bridge module. - Flow type `EventPropagators.js` and remove unused functions	{'url': 'https://api.github.com/repos/facebook/react/issues/18289/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18289/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18288	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18288/labels{/name}	https://api.github.com/repos/facebook/react/issues/18288/comments	https://api.github.com/repos/facebook/react/issues/18288/events	https://github.com/facebook/react/pull/18288	579,748,361	MDExOlB1bGxSZXF1ZXN0Mzg3MDg2MTE2	18,288	Refactor children creation from arguments in ReactElement	{'login': 'suthagar23', 'id': 17599049, 'node_id': 'MDQ6VXNlcjE3NTk5MDQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/17599049?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/suthagar23', 'html_url': 'https://github.com/suthagar23', 'followers_url': 'https://api.github.com/users/suthagar23/followers', 'following_url': 'https://api.github.com/users/suthagar23/following{/other_user}', 'gists_url': 'https://api.github.com/users/suthagar23/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/suthagar23/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/suthagar23/subscriptions', 'organizations_url': 'https://api.github.com/users/suthagar23/orgs', 'repos_url': 'https://api.github.com/users/suthagar23/repos', 'events_url': 'https://api.github.com/users/suthagar23/events{/privacy}', 'received_events_url': 'https://api.github.com/users/suthagar23/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18288/builds/14409) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 46a6a507efc04e7976d738f8cae143bc53ff26ae:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[silly-cherry-vk2sk](https://codesandbox.io/s/silly-cherry-vk2sk)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 46a6a507efc04e7976d738f8cae143bc53ff26ae\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 46a6a507efc04e7976d738f8cae143bc53ff26ae\n</p>\n", "This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.\n", "Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!\n" ]	2020-03-12 07:35:57	2020-07-11 02:16:51	2020-07-11 02:16:51	NONE	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18288', 'html_url': 'https://github.com/facebook/react/pull/18288', 'diff_url': 'https://github.com/facebook/react/pull/18288.diff', 'patch_url': 'https://github.com/facebook/react/pull/18288.patch', 'merged_at': None}	<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Refactor `childArray` creation logic with the `slice` method to improve the performance. resolve #18252	{'url': 'https://api.github.com/repos/facebook/react/issues/18288/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18288/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18287	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18287/labels{/name}	https://api.github.com/repos/facebook/react/issues/18287/comments	https://api.github.com/repos/facebook/react/issues/18287/events	https://github.com/facebook/react/pull/18287	579,679,102	MDExOlB1bGxSZXF1ZXN0Mzg3MDI4OTQ4	18,287	Add KeyboardEvent.code to synthetic event	{'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers', 'following_url': 'https://api.github.com/users/bl00mber/following{/other_user}', 'gists_url': 'https://api.github.com/users/bl00mber/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bl00mber/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bl00mber/subscriptions', 'organizations_url': 'https://api.github.com/users/bl00mber/orgs', 'repos_url': 'https://api.github.com/users/bl00mber/repos', 'events_url': 'https://api.github.com/users/bl00mber/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bl00mber/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18287/builds/18088) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 223785a0e12d5c5fc69817c8efb09737bc8d4669:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[currying-butterfly-g8r6f](https://codesandbox.io/s/currying-butterfly-g8r6f)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 223785a0e12d5c5fc69817c8efb09737bc8d4669\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 223785a0e12d5c5fc69817c8efb09737bc8d4669\n</p>\n" ]	2020-03-12 04:08:26	2020-04-04 13:24:47	2020-04-04 13:24:46	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18287', 'html_url': 'https://github.com/facebook/react/pull/18287', 'diff_url': 'https://github.com/facebook/react/pull/18287.diff', 'patch_url': 'https://github.com/facebook/react/pull/18287.patch', 'merged_at': datetime.datetime(2020, 4, 4, 13, 24, 46)}	resolve #14102	{'url': 'https://api.github.com/repos/facebook/react/issues/18287/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18287/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18286	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18286/labels{/name}	https://api.github.com/repos/facebook/react/issues/18286/comments	https://api.github.com/repos/facebook/react/issues/18286/events	https://github.com/facebook/react/pull/18286	579,638,624	MDExOlB1bGxSZXF1ZXN0Mzg2OTk2NTc3	18,286	Wrap Components and Profiler tabs with box-size style too	{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18286/builds/14390) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit ab81d24145298ee74282b5b41af737b8a28dfa26:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[sad-banach-d6dqg](https://codesandbox.io/s/sad-banach-d6dqg)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ab81d24145298ee74282b5b41af737b8a28dfa26\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ab81d24145298ee74282b5b41af737b8a28dfa26\n</p>\n" ]	2020-03-12 01:39:28	2020-03-12 02:13:06	2020-03-12 02:12:58	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18286', 'html_url': 'https://github.com/facebook/react/pull/18286', 'diff_url': 'https://github.com/facebook/react/pull/18286.diff', 'patch_url': 'https://github.com/facebook/react/pull/18286.patch', 'merged_at': datetime.datetime(2020, 3, 12, 2, 12, 58)}	For the browser extension, these views get rendered into portals and so they don't inherit the box-sizing style from the `.DevTools` wrapper element. This causes views like the Profiler commit selector to subtly break. This regressed with 9cc094a. Resolves #18284 <img width="369" alt="Screen Shot 2020-03-11 at 6 35 52 PM" src="https://user-images.githubusercontent.com/29597/76479008-a076bf80-63c7-11ea-9e2f-4e878d781d32.png">	{'url': 'https://api.github.com/repos/facebook/react/issues/18286/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18286/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18285	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18285/labels{/name}	https://api.github.com/repos/facebook/react/issues/18285/comments	https://api.github.com/repos/facebook/react/issues/18285/events	https://github.com/facebook/react/pull/18285	579,622,944	MDExOlB1bGxSZXF1ZXN0Mzg2OTg0Mjg5	18,285	Set up infra for react-reconciler fork	{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18285/builds/14389) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 95e54aefb261abf4efb166a52b27450cf1debc58:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[icy-fog-jpnyn](https://codesandbox.io/s/icy-fog-jpnyn)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 8b155d261368afb1fe93219278b581a1032ea1d7...95e54aefb261abf4efb166a52b27450cf1debc58</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 10.85 KB \| 10.85 KB \| 4.1 KB \| 4.1 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.97 KB \| 58.97 KB \| 14.71 KB \| 14.71 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1013 B \| 1013 B \| 603 B \| 602 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\nReactDOMForked-dev.js \| n/a \| n/a \| 0 B \| 981.94 KB \| 0 B \| 218.25 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| n/a \| n/a \| 0 B \| 410.57 KB \| 0 B \| 74.68 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nreact-dom.development.js \| 0.0% \| -0.0% \| 903.66 KB \| 903.66 KB \| 198.95 KB \| 198.95 KB \| UMD_DEV\nReactDOMForked-profiling.js \| n/a \| n/a \| 0 B \| 428.22 KB \| 0 B \| 77.79 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.83 KB \| 135.83 KB \| 34.97 KB \| 34.97 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.15 KB \| 1.15 KB \| 654 B \| 653 B \| NODE_PROD\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 118.67 KB \| 118.67 KB \| 38.09 KB \| 38.09 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.16 KB \| 20.16 KB \| 7.46 KB \| 7.46 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 122.38 KB \| 122.38 KB \| 39.29 KB \| 39.29 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| 0.0% \| -0.0% \| 919.25 KB \| 919.25 KB \| 205.13 KB \| 205.13 KB \| FB_WWW_DEV\nreact-dom.development.js \| 0.0% \| -0.0% \| 860.02 KB \| 860.02 KB \| 196.45 KB \| 196.44 KB \| NODE_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 128.87 KB \| 128.87 KB \| 34.52 KB \| 34.52 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 118.75 KB \| 118.75 KB \| 37.31 KB \| 37.3 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 53.84 KB \| 53.84 KB \| 14.01 KB \| 14.01 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.07 KB \| 20.07 KB \| 7.42 KB \| 7.42 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 3.34 KB \| 3.34 KB \| 1.26 KB \| 1.26 KB \| UMD_DEV\nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 122.61 KB \| 122.61 KB \| 38.51 KB \| 38.5 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.17 KB \| 1.17 KB \| 691 B \| 690 B \| UMD_PROD\nReactDOM-dev.js \| 0.0% \| -0.0% \| 981.94 KB \| 981.94 KB \| 218.25 KB \| 218.25 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 139.01 KB \| 139.01 KB \| 35.48 KB \| 35.48 KB \| FB_WWW_DEV\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 49.61 KB \| 49.61 KB \| 13.52 KB \| 13.52 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.92 KB \| 55.92 KB \| 14.48 KB \| 14.47 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.04 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 130.09 KB \| 130.09 KB \| 34.77 KB \| 34.77 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.1%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 95e54aefb261abf4efb166a52b27450cf1debc58\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 8b155d261368afb1fe93219278b581a1032ea1d7...95e54aefb261abf4efb166a52b27450cf1debc58</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 127 KB \| 127 KB \| 39.69 KB \| 39.68 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nReactDOM-dev.js \| 0.0% \| -0.0% \| 936.02 KB \| 936.02 KB \| 208.39 KB \| 208.39 KB \| FB_WWW_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.3% \| 1.19 KB \| 1.19 KB \| 700 B \| 698 B \| UMD_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 137.42 KB \| 137.42 KB \| 35.17 KB \| 35.17 KB \| UMD_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 130.38 KB \| 130.38 KB \| 34.74 KB \| 34.74 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nreact-dom.development.js \| 0.0% \| -0.0% \| 934.14 KB \| 934.14 KB \| 204.24 KB \| 204.24 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.98 KB \| 58.98 KB \| 14.72 KB \| 14.71 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 122.87 KB \| 122.87 KB \| 39.23 KB \| 39.23 KB \| UMD_PROD\nReactDOMForked-dev.js \| n/a \| n/a \| 0 B \| 936.02 KB \| 0 B \| 208.39 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.32 KB \| 10.32 KB \| 3.5 KB \| 3.5 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.34 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 126.7 KB \| 126.7 KB \| 40.49 KB \| 40.49 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| n/a \| n/a \| 0 B \| 383.96 KB \| 0 B \| 69.9 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 47.01 KB \| 47.01 KB \| 10.93 KB \| 10.93 KB \| FB_WWW_PROD\nreact-dom.development.js \| 0.0% \| -0.0% \| 889.23 KB \| 889.23 KB \| 201.69 KB \| 201.69 KB \| NODE_DEV\nReactDOMForked-profiling.js \| n/a \| n/a \| 0 B \| 401.55 KB \| 0 B \| 72.92 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.94 KB \| 55.94 KB \| 14.48 KB \| 14.48 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.2% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 123.02 KB \| 123.02 KB \| 38.43 KB \| 38.42 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.05 KB \| 10.05 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.16 KB \| 1.16 KB \| 663 B \| 662 B \| NODE_PROD\nReactDOM-prod.js \| 0.0% \| -0.0% \| 383.96 KB \| 383.96 KB \| 69.9 KB \| 69.9 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| 0.0% \| -0.0% \| 401.55 KB \| 401.55 KB \| 72.92 KB \| 72.92 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1 KB \| 1 KB \| 611 B \| 610 B \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 53.85 KB \| 53.85 KB \| 14.02 KB \| 14.02 KB \| UMD_DEV\nReactDOMTesting-dev.js \| 0.0% \| -0.0% \| 892.61 KB \| 892.61 KB \| 199.71 KB \| 199.71 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| -0.0% \| 378.01 KB \| 378.01 KB \| 69.19 KB \| 69.19 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 49.63 KB \| 49.63 KB \| 13.53 KB \| 13.53 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| -0.0% \| 378.01 KB \| 378.01 KB \| 69.19 KB \| 69.19 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 131.6 KB \| 131.6 KB \| 34.99 KB \| 34.99 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.94 KB \| 20.94 KB \| 7.65 KB \| 7.65 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.3%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 95e54aefb261abf4efb166a52b27450cf1debc58\n</p>\n", "Github wat", "Must a be a weird bug. PR definitely wasn't merged :D" ]	2020-03-12 00:41:11	2020-03-12 18:38:33	2020-03-12 18:38:32	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18285', 'html_url': 'https://github.com/facebook/react/pull/18285', 'diff_url': 'https://github.com/facebook/react/pull/18285.diff', 'patch_url': 'https://github.com/facebook/react/pull/18285.patch', 'merged_at': datetime.datetime(2020, 3, 12, 18, 38, 32)}	We're planning to land some significant refactors of the reconciler. We want to be able to gradually roll out the new implementation side-by-side with the existing one. So we'll create a short-lived fork of the react-reconciler package. Once the new implementation has stabilized, we'll delete the old implementation and promote the new one. This means, for as long as the fork exists, we'll need to maintain two separate implementations. This sounds painful, but since the forks will still be largely the same, most changes will not require two separate implementations. In practice, you'll implement the change in the old fork and then copy paste it to the new one. This commit only sets up the build and testing infrastructure. It does not actually fork any modules. I'll do that in subsequent PRs. The forked version of the reconciler will be used to build a special version of React DOM. I've called this build ReactDOMForked. It's only built for www; there's no open source version. The new reconciler is disabled by default. It's enabled in the `yarn test-www-variant` command. The reconciler fork isn't really related to the "variant" feature of the www builds, but I'm piggy backing on that concept to avoid having to add yet another testing dimension. --- First commit is a file rename. Second commit includes the changes to infra.	{'url': 'https://api.github.com/repos/facebook/react/issues/18285/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1}	https://api.github.com/repos/facebook/react/issues/18285/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18284	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18284/labels{/name}	https://api.github.com/repos/facebook/react/issues/18284/comments	https://api.github.com/repos/facebook/react/issues/18284/events	https://github.com/facebook/react/issues/18284	579,619,625	MDU6SXNzdWU1Nzk2MTk2MjU=	18,284	Bug: DevTools Profiler doesn't show selected commit	{'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'following_url': 'https://api.github.com/users/gaearon/following{/other_user}', 'gists_url': 'https://api.github.com/users/gaearon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gaearon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gaearon/subscriptions', 'organizations_url': 'https://api.github.com/users/gaearon/orgs', 'repos_url': 'https://api.github.com/users/gaearon/repos', 'events_url': 'https://api.github.com/users/gaearon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gaearon/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"} {'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}]	closed	false	{'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}]	null	[ "This is interesting. The extension seems to have a shorter toolbar height than I would expect, which is clipping the current index. Here's what the test harness/shell looks like:\r\n<img width=\"437\" alt=\"Screen Shot 2020-03-11 at 6 11 50 PM\" src=\"https://user-images.githubusercontent.com/29597/76477848-ce5a0500-63c3-11ea-9c08-fd9baaa2efa2.png\">\r\n", "Looks like something is going wrong with the relative height of the list items in the extension. Works fine in Chrome but it's overflowing in the extension. 😕 ", "Ah, it looks like the `box-sizing` style isn't cascading correctly in the extension.", "I think this probably regressed with 9cc094a, because the extension uses portals to mount (so they don't get mounted underneath of the `.DevTools` class).", "Yay! Fixed.\r\n\r\n<img width=\"369\" alt=\"Screen Shot 2020-03-11 at 6 35 52 PM\" src=\"https://user-images.githubusercontent.com/29597/76478860-33632a00-63c7-11ea-817c-33ff440a1936.png\">\r\n\r\n" ]	2020-03-12 00:28:58	2020-03-12 02:12:58	2020-03-12 02:12:58	COLLABORATOR	null	null	null	I don't see the selection at all. My version is 4.5.0. I think this regressed. <img width="266" alt="Screenshot 2020-03-11 at 23 40 37" src="https://user-images.githubusercontent.com/810438/76475966-6d005900-63f8-11ea-8779-7330eba193ee.png">	{'url': 'https://api.github.com/repos/facebook/react/issues/18284/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18284/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18283	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18283/labels{/name}	https://api.github.com/repos/facebook/react/issues/18283/comments	https://api.github.com/repos/facebook/react/issues/18283/events	https://github.com/facebook/react/issues/18283	579,569,591	MDU6SXNzdWU1Nzk1Njk1OTE=	18,283	Bug: Switching between two different input type elements clobbers their default value	{'login': 'cincospenguinos', 'id': 7362771, 'node_id': 'MDQ6VXNlcjczNjI3NzE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7362771?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cincospenguinos', 'html_url': 'https://github.com/cincospenguinos', 'followers_url': 'https://api.github.com/users/cincospenguinos/followers', 'following_url': 'https://api.github.com/users/cincospenguinos/following{/other_user}', 'gists_url': 'https://api.github.com/users/cincospenguinos/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/cincospenguinos/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/cincospenguinos/subscriptions', 'organizations_url': 'https://api.github.com/users/cincospenguinos/orgs', 'repos_url': 'https://api.github.com/users/cincospenguinos/repos', 'events_url': 'https://api.github.com/users/cincospenguinos/events{/privacy}', 'received_events_url': 'https://api.github.com/users/cincospenguinos/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "It seems to be the default correct behaviour. \r\n\r\nYou can read more about how `defaultValue` works here. <br/>\r\nhttps://reactjs.org/docs/uncontrolled-components.html#default-values\r\n\r\nThe reason it seems to work by adding the key prop is because the component gets re-rendered from scratch and therefore the `defaultValue` \"works\".\r\n\r\nI think what you want to achieve is pretty date display when not in edit mode.\r\nMaybe something like this.\r\n\r\nDemo\r\nhttps://codesandbox.io/s/fervent-khayyam-qk4ic\r\n\r\nPrototype code\r\n```jsx \r\nconst calculateDateDisplay = date => {\r\n if (!date) return \"No date\";\r\n\r\n const d = new Date(date);\r\n const year = new Intl.DateTimeFormat(\"en\", { year: \"numeric\" }).format(d);\r\n const month = new Intl.DateTimeFormat(\"en\", { month: \"short\" }).format(d);\r\n const day = new Intl.DateTimeFormat(\"en\", { day: \"2-digit\" }).format(d);\r\n\r\n return `${day} ${month} ${year}`;\r\n};\r\n\r\nexport default function App() {\r\n const [isEditing, setIsEditing] = React.useState(false);\r\n const [date, setDate] = React.useState(\"2020-01-01\");\r\n const [dateDisplay, setDateDisplay] = React.useState(\"\");\r\n\r\n const onFocus = () => {\r\n setIsEditing(true);\r\n };\r\n\r\n const onBlur = () => {\r\n setIsEditing(false);\r\n };\r\n\r\n React.useLayoutEffect(() => {\r\n setDateDisplay(calculateDateDisplay(date));\r\n }, [date]);\r\n\r\n if (isEditing) {\r\n return (\r\n <input\r\n onChange={event => setDate(event.target.value)}\r\n type=\"date\"\r\n onBlur={onBlur}\r\n value={date}\r\n />\r\n );\r\n }\r\n\r\n return <input type=\"text\" onFocus={onFocus} value={dateDisplay} readOnly />;\r\n}\r\n```", "This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!\n" ]	2020-03-11 22:01:08	2020-06-20 17:04:17	2020-06-20 17:04:17	NONE	null	null	null	React version: 16.8.0 ## Steps To Reproduce 1. Create an app that toggles between rendering a text input and a date input. 2. Set the`defaultValue` of each to some arbitrary input, valid for either one 3. Ensure toggling occurs `onFocus` 4. Observe that the value of the date input is not preserved upon toggle [Here is an example](https://codesandbox.io/s/loving-framework-z2eku) ## The current behavior The date input's value is not preserved ## The expected behavior The date input's value should be preserved ## Workaround We discovered a simple workaround--add a unique `key` property to each input, and the value will be respected.	{'url': 'https://api.github.com/repos/facebook/react/issues/18283/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18283/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18282	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18282/labels{/name}	https://api.github.com/repos/facebook/react/issues/18282/comments	https://api.github.com/repos/facebook/react/issues/18282/events	https://github.com/facebook/react/pull/18282	579,535,727	MDExOlB1bGxSZXF1ZXN0Mzg2OTEyMjM1	18,282	ReactDOM.useEvent: more scaffolding changes	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18282/builds/14366) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 32612f3709479921cb28f1a6df2a3c1d248ca665:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[still-sun-0rkxe](https://codesandbox.io/s/still-sun-0rkxe)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 8b155d261368afb1fe93219278b581a1032ea1d7...32612f3709479921cb28f1a6df2a3c1d248ca665</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| +0.1% \| +0.1% \| 428.22 KB \| 428.84 KB \| 77.79 KB \| 77.83 KB \| FB_WWW_PROFILING\nreact-dom.development.js \| 0.0% \| 0.0% \| 903.66 KB \| 903.67 KB \| 198.95 KB \| 198.96 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 118.67 KB \| 118.67 KB \| 38.09 KB \| 38.09 KB \| UMD_PROD\nreact-dom.development.js \| 0.0% \| 0.0% \| 860.02 KB \| 860.04 KB \| 196.45 KB \| 196.46 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 118.75 KB \| 118.75 KB \| 37.31 KB \| 37.31 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.48 KB \| 20.48 KB \| 7.57 KB \| 7.57 KB \| NODE_PROD\nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 122.61 KB \| 122.61 KB \| 38.51 KB \| 38.51 KB \| NODE_PROFILING\nReactDOM-dev.js \| 0.0% \| +0.1% \| 981.94 KB \| 982.35 KB \| 218.25 KB \| 218.38 KB \| FB_WWW_DEV\nReactDOM-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 410.57 KB \| 411.19 KB \| 74.68 KB \| 74.73 KB \| FB_WWW_PROD\nReactDOMTesting-dev.js \| 0.0% \| -0.0% \| 919.25 KB \| 919.27 KB \| 205.13 KB \| 205.1 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 391.57 KB \| 391.63 KB \| 71.38 KB \| 71.38 KB \| FB_WWW_PROD\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 391.57 KB \| 391.63 KB \| 71.38 KB \| 71.38 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.07 KB \| 20.07 KB \| 7.42 KB \| 7.42 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.34 KB \| 3.34 KB \| 1.26 KB \| 1.26 KB \| UMD_DEV\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 49.61 KB \| 49.61 KB \| 13.52 KB \| 13.52 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10.85 KB \| 10.85 KB \| 4.1 KB \| 4.1 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.31 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 32612f3709479921cb28f1a6df2a3c1d248ca665\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 8b155d261368afb1fe93219278b581a1032ea1d7...32612f3709479921cb28f1a6df2a3c1d248ca665</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| -0.0% \| 127 KB \| 127 KB \| 39.69 KB \| 39.68 KB \| NODE_PROFILING\nReactDOM-dev.js \| 0.0% \| 0.0% \| 936.02 KB \| 936.42 KB \| 208.39 KB \| 208.49 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 138.16 KB \| 138.16 KB \| 35.34 KB \| 35.35 KB \| FB_WWW_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 11.01 KB \| 11.01 KB \| 4.17 KB \| 4.17 KB \| UMD_PROD\nReactDOMTesting-dev.js \| 0.0% \| -0.0% \| 892.61 KB \| 892.62 KB \| 199.71 KB \| 199.7 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| -0.0% \| 378.01 KB \| 378.07 KB \| 69.19 KB \| 69.18 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 49.63 KB \| 49.63 KB \| 13.53 KB \| 13.53 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| -0.0% \| 378.01 KB \| 378.07 KB \| 69.19 KB \| 69.18 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10.86 KB \| 10.86 KB \| 4.11 KB \| 4.11 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.94 KB \| 20.94 KB \| 7.65 KB \| 7.65 KB \| NODE_PROD\nreact-dom.development.js \| 0.0% \| 0.0% \| 934.14 KB \| 934.16 KB \| 204.24 KB \| 204.25 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 122.87 KB \| 122.87 KB \| 39.23 KB \| 39.23 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 126.7 KB \| 126.7 KB \| 40.49 KB \| 40.49 KB \| UMD_PROFILING\nreact-dom.development.js \| 0.0% \| 0.0% \| 889.23 KB \| 889.25 KB \| 201.69 KB \| 201.71 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| -0.0% \| 123.02 KB \| 123.02 KB \| 38.43 KB \| 38.42 KB \| NODE_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.53 KB \| 20.53 KB \| 7.5 KB \| 7.5 KB \| NODE_PROD\nReactDOM-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 383.96 KB \| 384.58 KB \| 69.9 KB \| 69.95 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 47.01 KB \| 47.01 KB \| 10.93 KB \| 10.93 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| +0.2% \| +0.1% \| 401.55 KB \| 402.17 KB \| 72.92 KB \| 72.97 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 32612f3709479921cb28f1a6df2a3c1d248ca665\n</p>\n" ]	2020-03-11 20:45:55	2020-03-12 09:12:12	2020-03-12 09:12:07	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18282', 'html_url': 'https://github.com/facebook/react/pull/18282', 'diff_url': 'https://github.com/facebook/react/pull/18282.diff', 'patch_url': 'https://github.com/facebook/react/pull/18282.patch', 'merged_at': datetime.datetime(2020, 3, 12, 9, 12, 7)}	This PR doesn't really introduce any real changes, other than adding additional scaffolding needed for the `useEvent` API. Notably, there have been quite a few variable renames and Flow type changes, not to mention the only real visible code change to ensure that we're dealing with actual DOM nodes when finding ancestors (more guarding against the case where the target container is not a DOM node, i.e. a future `window` node). Lastly, this adds `validateEventListenerInstance`, which will have tests added in a follow up when the event system is correctly wired up to the hooks (will happen in the next PR). This function only applies warnings and validation against the wrong signature of `useEvent`'s map object being used (`setListener`).	{'url': 'https://api.github.com/repos/facebook/react/issues/18282/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18282/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18281	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18281/labels{/name}	https://api.github.com/repos/facebook/react/issues/18281/comments	https://api.github.com/repos/facebook/react/issues/18281/events	https://github.com/facebook/react/issues/18281	579,522,450	MDU6SXNzdWU1Nzk1MjI0NTA=	18,281	Bug: react-test-renderer createNodeMock does not seem to work with useRef	{'login': 'd-imal', 'id': 130146, 'node_id': 'MDQ6VXNlcjEzMDE0Ng==', 'avatar_url': 'https://avatars.githubusercontent.com/u/130146?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/d-imal', 'html_url': 'https://github.com/d-imal', 'followers_url': 'https://api.github.com/users/d-imal/followers', 'following_url': 'https://api.github.com/users/d-imal/following{/other_user}', 'gists_url': 'https://api.github.com/users/d-imal/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/d-imal/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/d-imal/subscriptions', 'organizations_url': 'https://api.github.com/users/d-imal/orgs', 'repos_url': 'https://api.github.com/users/d-imal/repos', 'events_url': 'https://api.github.com/users/d-imal/events{/privacy}', 'received_events_url': 'https://api.github.com/users/d-imal/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "You need to attach the ref to a component: \r\n```diff\r\n-return <div></div>\r\n+return <div ref={myRef}></div>\r\n```\r\n\r\nBut even then you will not see a different log since the `current` will only be assigned on the next render.\r\n\r\n`createNodeMock` is only used when refs are actually attach not just when calling `createRef` or `useRef`.", "Thanks for the quick response. I think that was actually more of a mistake in my paring down my original component and test into something that's more comprehensible here. I added the ref to the DOM and now I get this in the log:\r\n```\r\n console.log src/components/InfiniteList/InfiniteList.tsx:29\r\n myRef { current: null }\r\n\r\n console.log src/components/InfiniteList/InfiniteList.tsx:36\r\n createNodeMock called\r\n\r\n console.log src/components/InfiniteList/InfiniteList.tsx:29\r\n myRef { current: null }\r\n```\r\n\r\n`current` is still null. It looks like it's doing another render, so shouldn't it be assigned there?", "It's hard to tell based on what you've provided, but in general it isn't recommended to read a ref during a render function. Any code that manipulates or measures DOM nodes should be in useEffect, useLayoutEffect, or similar.\r\n\r\nI'm guessing that will solve your problem. If not, happy to reopen." ]	2020-03-11 20:19:29	2020-03-18 01:52:00	2020-03-18 01:51:59	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> React version: 16.9.0 react-test-renderer version: 16.12.0 ## Steps To Reproduce 1. Create a functional component that uses `useRef` 2. In a test, use `createNodeMock` to mock the ref when you call `renderer.create` 3. Attempt to access `.current` on your ref ``` const MyComponent = (): JSX.Element => { const myRef = React.useRef<HTMLDivElement>(null); console.log('myRef', myRef); return <div></div>; }; export default InfiniteList; const component = renderer.create(<MyComponent />, { createNodeMock() { console.log('createNodeMock called'); return { getBoundingClientRect(): { y: number } { return { y: -1000, }; }, }; }, }); ``` The log output is: ``` console.log src/components/MyComponent/MyComponent.tsx:62 myRef { current: null } console.log src/components/MyComponent/MyComponent.tsx:110 createNodeMock called ``` It's worth noting that this _did_ work within a class component and `createRef`, but stopped when I converted the component to a functional component that uses `useRef`. Link to code example: I was not able to get tests to run on CodeSandbox. <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior The `.current` property on the ref is `null` ## The expected behavior The `.current` property on the ref should be the the mock provided by `createNodeMock`.	{'url': 'https://api.github.com/repos/facebook/react/issues/18281/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18281/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18280	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18280/labels{/name}	https://api.github.com/repos/facebook/react/issues/18280/comments	https://api.github.com/repos/facebook/react/issues/18280/events	https://github.com/facebook/react/pull/18280	579,491,222	MDExOlB1bGxSZXF1ZXN0Mzg2ODc2MDA1	18,280	Flow type ReactDOMComponentTree	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18280/builds/14334) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit e664c5b9bf83bad5b9f9843add845b107158ab05:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[long-platform-kgnqz](https://codesandbox.io/s/long-platform-kgnqz)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e664c5b9bf83bad5b9f9843add845b107158ab05\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e664c5b9bf83bad5b9f9843add845b107158ab05\n</p>\n" ]	2020-03-11 19:22:02	2020-03-11 19:38:27	2020-03-11 19:38:24	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18280', 'html_url': 'https://github.com/facebook/react/pull/18280', 'diff_url': 'https://github.com/facebook/react/pull/18280.diff', 'patch_url': 'https://github.com/facebook/react/pull/18280.patch', 'merged_at': datetime.datetime(2020, 3, 11, 19, 38, 23)}	ReactDOMComponentTree has no Flow types and it really should. This isn't the best implementation (I used `any` to get around the Flow issues for not knowing the internal key properties we add on the DOM nodes), but it's vastly better than what we had before!	{'url': 'https://api.github.com/repos/facebook/react/issues/18280/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18280/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18279	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18279/labels{/name}	https://api.github.com/repos/facebook/react/issues/18279/comments	https://api.github.com/repos/facebook/react/issues/18279/events	https://github.com/facebook/react/issues/18279	579,487,512	MDU6SXNzdWU1Nzk0ODc1MTI=	18,279	Bug: Failed to execute 'createObjectURL' on 'URL': No function was found that matched the signature provided	{'login': 'Yuri-Tiofilo', 'id': 49408968, 'node_id': 'MDQ6VXNlcjQ5NDA4OTY4', 'avatar_url': 'https://avatars.githubusercontent.com/u/49408968?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Yuri-Tiofilo', 'html_url': 'https://github.com/Yuri-Tiofilo', 'followers_url': 'https://api.github.com/users/Yuri-Tiofilo/followers', 'following_url': 'https://api.github.com/users/Yuri-Tiofilo/following{/other_user}', 'gists_url': 'https://api.github.com/users/Yuri-Tiofilo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Yuri-Tiofilo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Yuri-Tiofilo/subscriptions', 'organizations_url': 'https://api.github.com/users/Yuri-Tiofilo/orgs', 'repos_url': 'https://api.github.com/users/Yuri-Tiofilo/repos', 'events_url': 'https://api.github.com/users/Yuri-Tiofilo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Yuri-Tiofilo/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "This isn’t related to React at all, so I’m going to close this issue. I recommend using a community resource like stack overflow. Thanks!" ]	2020-03-11 19:14:47	2020-03-12 11:04:22	2020-03-12 11:04:22	NONE	null	null	null	when using the window command and createObjectURL etsou having this error: TypeError: Failed to execute 'createObjectURL' on 'URL': No function was found that matched the signature provided. the code looks something like this: ```jsx const blobUrl = window. URL.createObjectURL(print); window.open(blobUrl); ``` being print the answer i sell an API, where I search my pdf. But when I use the createObjectURL it of this error. How do I use this in ReactJS?	{'url': 'https://api.github.com/repos/facebook/react/issues/18279/reactions', 'total_count': 1, '+1': 0, '-1': 1, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18279/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18278	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18278/labels{/name}	https://api.github.com/repos/facebook/react/issues/18278/comments	https://api.github.com/repos/facebook/react/issues/18278/events	https://github.com/facebook/react/pull/18278	579,482,368	MDExOlB1bGxSZXF1ZXN0Mzg2ODY4NzA1	18,278	Don't use closures in DevTools injection	{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18278/builds/18930) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 0c43f3ec84d5f25e87dde3e7dc093cfd028c9548:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[aged-wave-01t84](https://codesandbox.io/s/aged-wave-01t84)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 5474a83e258b497584bed9df95de1d554bc53f89...0c43f3ec84d5f25e87dde3e7dc093cfd028c9548</p>\n\n\n \n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| -0.1% \| -0.1% \| 652.97 KB \| 652.51 KB \| 136.99 KB \| 136.9 KB \| UMD_DEV\nreact-art.production.min.js \| -0.0% \| -0.1% \| 109.74 KB \| 109.73 KB \| 33.13 KB \| 33.11 KB \| UMD_PROD\nreact-art.development.js \| -0.1% \| -0.1% \| 556.54 KB \| 556.1 KB \| 119.47 KB \| 119.37 KB \| NODE_DEV\nreact-art.production.min.js \| -0.1% \| -0.0% \| 74.71 KB \| 74.66 KB \| 22.33 KB \| 22.32 KB \| NODE_PROD\nReactART-dev.js \| -0.1% \| -0.1% \| 588.62 KB \| 588.26 KB \| 123.47 KB \| 123.4 KB \| FB_WWW_DEV\nReactART-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 240.77 KB \| 240.79 KB \| 40.65 KB \| 40.69 KB \| FB_WWW_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactTestRenderer-dev.js \| -0.1% \| -0.1% \| 575.72 KB \| 575.36 KB \| 121.41 KB \| 121.33 KB \| FB_WWW_DEV\nreact-test-renderer-shallow.development.js \| 0.0% \| -0.0% \| 38.72 KB \| 38.72 KB \| 9.43 KB \| 9.43 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.74 KB \| 12.74 KB \| 3.97 KB \| 3.97 KB \| UMD_PROD\nreact-test-renderer.development.js \| -0.1% \| -0.1% \| 568.39 KB \| 567.93 KB \| 118.2 KB \| 118.11 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| -0.0% \| -0.1% \| 74.17 KB \| 74.16 KB \| 22.56 KB \| 22.54 KB \| UMD_PROD\nreact-test-renderer.development.js \| -0.1% \| -0.1% \| 541.96 KB \| 541.52 KB \| 116.86 KB \| 116.76 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| -0.1% \| -0.0% \| 74 KB \| 73.96 KB \| 22.25 KB \| 22.25 KB \| NODE_PROD\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 156.59 KB \| 156.59 KB \| 39.58 KB \| 39.58 KB \| UMD_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 23.39 KB \| 23.39 KB \| 8.6 KB \| 8.6 KB \| UMD_PROD\nreact-dom.profiling.min.js \| -0.0% \| -0.0% \| 127.81 KB \| 127.78 KB \| 39.89 KB \| 39.88 KB \| NODE_PROFILING\nReactDOM-dev.js \| -0.0% \| -0.0% \| 979.55 KB \| 979.19 KB \| 217.13 KB \| 217.06 KB \| FB_WWW_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.2 KB \| 1.2 KB \| 706 B \| 705 B \| UMD_PROD\nReactDOM-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 408.56 KB \| 408.63 KB \| 73.9 KB \| 73.95 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| 0.0% \| +0.1% \| 419.38 KB \| 419.47 KB \| 75.75 KB \| 75.79 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 4.43 KB \| 4.43 KB \| 1.54 KB \| 1.55 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1.02 KB \| 1.02 KB \| 618 B \| 617 B \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 75.14 KB \| 75.14 KB \| 20.12 KB \| 20.11 KB \| UMD_DEV\nReactDOMTesting-dev.js \| -0.0% \| -0.0% \| 929.91 KB \| 929.55 KB \| 207.15 KB \| 207.06 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 393.2 KB \| 393.25 KB \| 71.65 KB \| 71.67 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 69.98 KB \| 69.98 KB \| 19.61 KB \| 19.61 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 393.2 KB \| 393.25 KB \| 71.65 KB \| 71.67 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 148.58 KB \| 148.58 KB \| 39.1 KB \| 39.1 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 13.1 KB \| 13.1 KB \| 4.81 KB \| 4.81 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 23.69 KB \| 23.69 KB \| 8.72 KB \| 8.72 KB \| NODE_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 147.36 KB \| 147.36 KB \| 38.84 KB \| 38.84 KB \| NODE_DEV\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 23.28 KB \| 23.28 KB \| 8.57 KB \| 8.56 KB \| NODE_PROD\nreact-dom.development.js \| -0.0% \| -0.1% \| 935.65 KB \| 935.19 KB \| 204.05 KB \| 203.95 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 56.11 KB \| 56.11 KB \| 13.85 KB \| 13.85 KB \| UMD_DEV\nreact-dom.production.min.js \| -0.0% \| -0.1% \| 123.63 KB \| 123.6 KB \| 39.42 KB \| 39.4 KB \| UMD_PROD\nReactDOMForked-dev.js \| -0.0% \| -0.0% \| 979.55 KB \| 979.19 KB \| 217.13 KB \| 217.06 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10 KB \| 10 KB \| 3.36 KB \| 3.36 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 154.48 KB \| 154.48 KB \| 38.97 KB \| 38.97 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| -0.0% \| -0.0% \| 127.47 KB \| 127.45 KB \| 40.63 KB \| 40.62 KB \| UMD_PROFILING\nReactDOMForked-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 408.56 KB \| 408.63 KB \| 73.9 KB \| 73.95 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 52.56 KB \| 52.56 KB \| 12.68 KB \| 12.68 KB \| FB_WWW_PROD\nreact-dom.development.js \| -0.0% \| -0.0% \| 890.89 KB \| 890.46 KB \| 201.58 KB \| 201.48 KB \| NODE_DEV\nReactDOMForked-profiling.js \| 0.0% \| +0.1% \| 419.38 KB \| 419.47 KB \| 75.75 KB \| 75.79 KB \| FB_WWW_PROFILING\nreact-dom.production.min.js \| -0.0% \| -0.0% \| 123.83 KB \| 123.78 KB \| 38.62 KB \| 38.61 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 9.75 KB \| 9.75 KB \| 3.26 KB \| 3.25 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.3% \| 1.17 KB \| 1.17 KB \| 668 B \| 666 B \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 270.91 KB \| 270.93 KB \| 46.57 KB \| 46.6 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| +0.1% \| 282.28 KB \| 282.34 KB \| 48.74 KB \| 48.77 KB \| RN_OSS_PROFILING\nReactFabric-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 262.89 KB \| 262.91 KB \| 45.05 KB \| 45.08 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| 0.0% \| +0.1% \| 274.27 KB \| 274.33 KB \| 47.22 KB \| 47.26 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| -0.1% \| -0.1% \| 639.96 KB \| 639.59 KB \| 136.64 KB \| 136.57 KB \| RN_FB_DEV\nReactFabric-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 263.04 KB \| 263.06 KB \| 45.09 KB \| 45.12 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| -0.1% \| -0.1% \| 653.75 KB \| 653.39 KB \| 140.33 KB \| 140.25 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| 0.0% \| +0.1% \| 274.42 KB \| 274.47 KB \| 47.25 KB \| 47.29 KB \| RN_FB_PROFILING\nReactNativeRenderer-dev.js \| -0.1% \| -0.1% \| 658.24 KB \| 657.88 KB \| 141.08 KB \| 141 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 271.05 KB \| 271.07 KB \| 46.6 KB \| 46.63 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| +0.1% \| 282.42 KB \| 282.48 KB \| 48.77 KB \| 48.8 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| -0.1% \| -0.1% \| 635.46 KB \| 635.1 KB \| 135.9 KB \| 135.82 KB \| RN_OSS_DEV\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler-reflection.development.js \| 0.0% \| -0.0% \| 16.23 KB \| 16.23 KB \| 4.92 KB \| 4.92 KB \| NODE_DEV\nreact-reconciler-reflection.production.min.js \| 0.0% \| -0.2% \| 2.58 KB \| 2.58 KB \| 1.09 KB \| 1.09 KB \| NODE_PROD\nreact-reconciler.development.js \| -0.1% \| -0.1% \| 598.26 KB \| 597.83 KB \| 126.17 KB \| 126.06 KB \| NODE_DEV\nreact-reconciler.production.min.js \| -0.0% \| 0.0% \| 80.08 KB \| 80.07 KB \| 23.56 KB \| 23.57 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0c43f3ec84d5f25e87dde3e7dc093cfd028c9548\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 5474a83e258b497584bed9df95de1d554bc53f89...0c43f3ec84d5f25e87dde3e7dc093cfd028c9548</p>\n\n\n \n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| -0.1% \| -0.1% \| 632.6 KB \| 632.14 KB \| 133.29 KB \| 133.2 KB \| UMD_DEV\nreact-art.production.min.js \| -0.0% \| -0.1% \| 107.13 KB \| 107.12 KB \| 32.46 KB \| 32.44 KB \| UMD_PROD\nreact-art.development.js \| -0.1% \| -0.1% \| 536.98 KB \| 536.54 KB \| 115.72 KB \| 115.64 KB \| NODE_DEV\nreact-art.production.min.js \| -0.1% \| -0.0% \| 72.15 KB \| 72.11 KB \| 21.66 KB \| 21.66 KB \| NODE_PROD\nReactART-dev.js \| -0.1% \| -0.1% \| 598.69 KB \| 598.33 KB \| 125.46 KB \| 125.39 KB \| FB_WWW_DEV\nReactART-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 248.21 KB \| 248.24 KB \| 41.94 KB \| 41.97 KB \| FB_WWW_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer.development.js \| -0.1% \| -0.1% \| 568.36 KB \| 567.9 KB \| 118.18 KB \| 118.09 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| -0.0% \| -0.1% \| 74.15 KB \| 74.13 KB \| 22.54 KB \| 22.52 KB \| UMD_PROD\nreact-test-renderer-shallow.development.js \| 0.0% \| -0.0% \| 38.71 KB \| 38.71 KB \| 9.42 KB \| 9.42 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.73 KB \| 12.73 KB \| 3.96 KB \| 3.97 KB \| UMD_PROD\nreact-test-renderer.development.js \| -0.1% \| -0.1% \| 541.93 KB \| 541.5 KB \| 116.84 KB \| 116.75 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| -0.1% \| -0.0% \| 73.97 KB \| 73.93 KB \| 22.23 KB \| 22.23 KB \| NODE_PROD\nReactTestRenderer-dev.js \| -0.1% \| -0.1% \| 575.71 KB \| 575.35 KB \| 121.4 KB \| 121.33 KB \| FB_WWW_DEV\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| -0.1% \| -0.1% \| 653.74 KB \| 653.38 KB \| 140.32 KB \| 140.24 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 270.89 KB \| 270.91 KB \| 46.56 KB \| 46.59 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| 0.0% \| +0.1% \| 282.27 KB \| 282.33 KB \| 48.73 KB \| 48.76 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| -0.1% \| -0.1% \| 635.45 KB \| 635.09 KB \| 135.9 KB \| 135.82 KB \| RN_OSS_DEV\nReactFabric-prod.js \| 0.0% \| :small_red_triangle:+0.1% \| 262.88 KB \| 262.9 KB \| 45.04 KB \| 45.07 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| 0.0% \| +0.1% \| 274.25 KB \| 274.31 KB \| 47.22 KB \| 47.25 KB \| RN_OSS_PROFILING\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.production.min.js \| -0.0% \| -0.1% \| 119.69 KB \| 119.64 KB \| 37.52 KB \| 37.5 KB \| NODE_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 75.12 KB \| 75.12 KB \| 20.11 KB \| 20.11 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 405.02 KB \| 405.08 KB \| 73.45 KB \| 73.46 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 22.82 KB \| 22.82 KB \| 8.49 KB \| 8.48 KB \| NODE_PROD\nreact-dom.profiling.min.js \| -0.0% \| 0.0% \| 123.54 KB \| 123.51 KB \| 38.66 KB \| 38.67 KB \| NODE_PROFILING\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.3% \| 1.19 KB \| 1.19 KB \| 699 B \| 697 B \| UMD_PROD\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 147.06 KB \| 147.06 KB \| 38.89 KB \| 38.88 KB \| NODE_DEV\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 23.23 KB \| 23.23 KB \| 8.65 KB \| 8.65 KB \| NODE_PROD\nReactDOMForked-dev.js \| -0.0% \| -0.0% \| 1007.43 KB \| 1007.07 KB \| 223.11 KB \| 223.05 KB \| FB_WWW_DEV\nReactDOMForked-prod.js \| 0.0% \| 0.0% \| 421.47 KB \| 421.54 KB \| 75.8 KB \| 75.83 KB \| FB_WWW_PROD\nreact-dom.development.js \| -0.1% \| -0.1% \| 905.73 KB \| 905.27 KB \| 198.78 KB \| 198.67 KB \| UMD_DEV\nReactDOMForked-profiling.js \| 0.0% \| 0.0% \| 432.35 KB \| 432.44 KB \| 77.69 KB \| 77.72 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 155 KB \| 155 KB \| 39.38 KB \| 39.38 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.5% \| 1.16 KB \| 1.16 KB \| 660 B \| 657 B \| NODE_PROD\nreact-dom.production.min.js \| -0.0% \| -0.0% \| 119.55 KB \| 119.52 KB \| 38.25 KB \| 38.24 KB \| UMD_PROD\nreact-dom.profiling.min.js \| -0.0% \| -0.0% \| 123.27 KB \| 123.26 KB \| 39.48 KB \| 39.47 KB \| UMD_PROFILING\nReactDOMTesting-dev.js \| -0.0% \| -0.0% \| 956.46 KB \| 956.1 KB \| 212.77 KB \| 212.7 KB \| FB_WWW_DEV\nreact-dom.development.js \| -0.1% \| -0.0% \| 862.22 KB \| 861.78 KB \| 196.31 KB \| 196.23 KB \| NODE_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 405.02 KB \| 405.08 KB \| 73.45 KB \| 73.46 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 145.85 KB \| 145.85 KB \| 38.63 KB \| 38.63 KB \| NODE_DEV\nReactDOM-dev.js \| -0.0% \| -0.0% \| 1007.43 KB \| 1007.07 KB \| 223.11 KB \| 223.05 KB \| FB_WWW_DEV\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 157.98 KB \| 157.98 KB \| 39.92 KB \| 39.92 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| 0.0% \| 421.47 KB \| 421.54 KB \| 75.8 KB \| 75.83 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 69.97 KB \| 69.97 KB \| 19.6 KB \| 19.6 KB \| NODE_DEV\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 53.29 KB \| 53.29 KB \| 12.84 KB \| 12.84 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| 0.0% \| 0.0% \| 432.35 KB \| 432.44 KB \| 77.69 KB \| 77.72 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 13.09 KB \| 13.09 KB \| 4.8 KB \| 4.8 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 56.1 KB \| 56.1 KB \| 13.84 KB \| 13.84 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.2% \| 1 KB \| 1 KB \| 610 B \| 609 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 9.98 KB \| 9.98 KB \| 3.36 KB \| 3.35 KB \| UMD_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 53.2 KB \| 53.2 KB \| 13.64 KB \| 13.64 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 9.73 KB \| 9.73 KB \| 3.25 KB \| 3.25 KB \| NODE_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| -0.1% \| -0.1% \| 576.34 KB \| 575.91 KB \| 121.91 KB \| 121.79 KB \| NODE_DEV\nreact-reconciler-reflection.development.js \| 0.0% \| -0.0% \| 16.22 KB \| 16.22 KB \| 4.91 KB \| 4.91 KB \| NODE_DEV\nreact-reconciler.production.min.js \| -0.0% \| -0.1% \| 77.12 KB \| 77.1 KB \| 22.86 KB \| 22.85 KB \| NODE_PROD\nreact-reconciler-reflection.production.min.js \| 0.0% \| -0.1% \| 2.57 KB \| 2.57 KB \| 1.08 KB \| 1.08 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0c43f3ec84d5f25e87dde3e7dc093cfd028c9548\n</p>\n", "Looks like fast-refresh is mutating the hook object. :( ", "So, landing this?", "Thanks for this change. FYI - It is also fixing a bug with React Fast refresh which happen when `hook.onScheduleFiberRoot` is defined after React code is excuted. \r\nIn this setup, Fast Refresh will not work properly because it didn't manage to register a root because React didn't called its callback.\r\n\r\nIn our setup, we have 2 bundles - one contains React (loaded first) and a second one containing the Fast Refresh runtime (+ app code). Since Fast refresh runtime is executed after React it wasn't working fully.\r\n\r\nBeside this little quirk Fast Refresh is really great and reliable:+1: " ]	2020-03-11 19:04:29	2020-05-26 15:56:52	2020-04-09 00:57:18	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18278', 'html_url': 'https://github.com/facebook/react/pull/18278', 'diff_url': 'https://github.com/facebook/react/pull/18278.diff', 'patch_url': 'https://github.com/facebook/react/pull/18278.patch', 'merged_at': datetime.datetime(2020, 4, 9, 0, 57, 18)}	Nested closures are tricky. They're not super efficient and when they share scope between multiple closures they're hard for a compiler to optimize. It's also unclear how many versions will be created. By hoisting things out an just make it simple calls the compiler can do a much better job. ## Before ```js "function" === typeof ik && ik(c.stateNode, d); ``` ```js "function" === typeof Qi && Qi(b); ``` ```js var ik = null, Qi = null; function nk(a) { if ("undefined" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) return !1; var b = __REACT_DEVTOOLS_GLOBAL_HOOK__; if (b.isDisabled \|\| !b.supportsFiber) return !0; try { var c = b.inject(a); ik = function(a) { try { b.onCommitFiberRoot(c, a, void 0, 64 === (a.current.effectTag & 64)); } catch (e) {} }; Qi = function(a) { try { b.onCommitFiberUnmount(c, a); } catch (e) {} }; } catch (d) {} return !0; } (function(a) { var b = a.findFiberByHostInstance; return nk( n({}, a, { overrideHookState: null, overrideProps: null, setSuspenseHandler: null, scheduleUpdate: null, currentDispatcherRef: Wa.ReactCurrentDispatcher, findHostInstanceByFiber: function(a) { a = ic(a); return null === a ? null : a.stateNode; }, findFiberByHostInstance: function(a) { return b ? b(a) : null; }, findHostInstancesForRefresh: null, scheduleRefresh: null, scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null }) ); })({ findFiberByHostInstance: uc, bundleType: 0, version: "16.13.0", rendererPackageName: "react-dom" }); ``` ## After ```js if ("function" === typeof ik) try { ik(Qi, c, void 0, 64 === (c.current.effectTag & 64)); } catch (ya) {} ``` ```js if ("function" === typeof Pi) try { Pi(Qi, b); } catch (e) {} ``` ```js var Dk = { findFiberByHostInstance: tc, bundleType: 0, version: "16.13.0", rendererPackageName: "react-dom" }; var Ek = { bundleType: Dk.bundleType, version: Dk.version, rendererPackageName: Dk.rendererPackageName, getInspectorDataForViewTag: Dk.getInspectorDataForViewTag, overrideHookState: null, overrideProps: null, setSuspenseHandler: null, scheduleUpdate: null, currentDispatcherRef: Ya.ReactCurrentDispatcher, findHostInstanceByFiber: function(a) { a = hc(a); return null === a ? null : a.stateNode; }, findFiberByHostInstance: Dk.findFiberByHostInstance \|\| tk, findHostInstancesForRefresh: null, scheduleRefresh: null, scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var Fk = __REACT_DEVTOOLS_GLOBAL_HOOK__; if (!Fk.isDisabled && Fk.supportsFiber) try { (Qi = Fk.inject(Ek)), (ik = Fk.onCommitFiberRoot), (Pi = Fk.onCommitFiberUnmount); } catch (a) {} } ``` Note that it's still sub-optimal because the config object gets created even though it should be able to be inlined by Closure Compiler. We should really switch this per-renderer config object to be a HostConfig the whole thing instead to avoid that. The injected object is also created outside the condition so it's always created even if no devtools is present.	{'url': 'https://api.github.com/repos/facebook/react/issues/18278/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18278/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18277	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18277/labels{/name}	https://api.github.com/repos/facebook/react/issues/18277/comments	https://api.github.com/repos/facebook/react/issues/18277/events	https://github.com/facebook/react/pull/18277	579,431,734	MDExOlB1bGxSZXF1ZXN0Mzg2ODI2NTg3	18,277	Don't use Spread in DevTools Injection	{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18277/builds/14318) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit ee144e13ff83963ca86d233e77a4fe2aa941fe30:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[runtime-hill-n0jsw](https://codesandbox.io/s/runtime-hill-n0jsw)\| Configuration \|\n", "I believe this change should let us compile out the intermediate steps here but there's still something about how this is wired up that confuses the compiler until leave an unnecessary closure in place. I think it's because our use of closures in findHostInstanceByFiber.", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ee144e13ff83963ca86d233e77a4fe2aa941fe30\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ee144e13ff83963ca86d233e77a4fe2aa941fe30\n</p>\n" ]	2020-03-11 17:32:18	2020-03-11 17:58:26	2020-03-11 17:58:26	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18277', 'html_url': 'https://github.com/facebook/react/pull/18277', 'diff_url': 'https://github.com/facebook/react/pull/18277.diff', 'patch_url': 'https://github.com/facebook/react/pull/18277.patch', 'merged_at': datetime.datetime(2020, 3, 11, 17, 58, 26)}	Related to this https://github.com/facebook/react/pull/18233/files#r391135037 We could encourage new arbitrary things to be added to this object through spread but that shares a namespace with our own things which risks us colliding and causing weird behavior. The Flow type defines that this is exact so to enforce that it is indeed exact, we can instead enumerate the values. We really should be doing that everywhere in our internals, like we do with fiber cloning for example, and ideally avoid Object.assign as much as possible even in user facing APIs. In DEV behavior I'm not as strict but this ships in PROD.	{'url': 'https://api.github.com/repos/facebook/react/issues/18277/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18277/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18276	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18276/labels{/name}	https://api.github.com/repos/facebook/react/issues/18276/comments	https://api.github.com/repos/facebook/react/issues/18276/events	https://github.com/facebook/react/issues/18276	579,333,154	MDU6SXNzdWU1NzkzMzMxNTQ=	18,276	Bug: does useState block dom event ?	{'login': 'dinfer', 'id': 11496403, 'node_id': 'MDQ6VXNlcjExNDk2NDAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/11496403?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dinfer', 'html_url': 'https://github.com/dinfer', 'followers_url': 'https://api.github.com/users/dinfer/followers', 'following_url': 'https://api.github.com/users/dinfer/following{/other_user}', 'gists_url': 'https://api.github.com/users/dinfer/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dinfer/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dinfer/subscriptions', 'organizations_url': 'https://api.github.com/users/dinfer/orgs', 'repos_url': 'https://api.github.com/users/dinfer/repos', 'events_url': 'https://api.github.com/users/dinfer/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dinfer/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "> let el = null;\r\n\r\nThis is set to `null` everytime you call `setPos`. You want to use a ref instead: \r\n\r\n```jsx\r\nlet el = React.useRef(null);\r\n...\r\nel.current = e.target\r\n...\r\ne.target === el.currennt\r\n```\r\n\r\n", "Thanks, It's my bad." ]	2020-03-11 15:05:51	2020-03-11 15:28:15	2020-03-11 15:28:15	NONE	null	null	null	React version:16.13.0 ## Steps To Reproduce I created a code pen to reproduce the problem Link to code example: https://codepen.io/dinfer/pen/zYGRdmZ ## The current behavior 1. `useState` api blocks the mouseevent. onMouseMove is just called one time no matter how I move my mouse on the circle element, but when I comment `setPos({ ...p.meta });`, I receive all the events as mouse moves. 2. I cannot see the component in devtools if I use react to create SVG element. does react support handling the SVG elements? ![image](https://user-images.githubusercontent.com/11496403/76431598-c2366d80-63ec-11ea-9abe-7b27a97892d6.png) ## The expected behavior 1. `setPros`, returned by useState API, do not block `onmousemove` event. 2. I can view the svg based component information just like dom based component in the devtools.	{'url': 'https://api.github.com/repos/facebook/react/issues/18276/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18276/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18275	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18275/labels{/name}	https://api.github.com/repos/facebook/react/issues/18275/comments	https://api.github.com/repos/facebook/react/issues/18275/events	https://github.com/facebook/react/issues/18275	579,242,470	MDU6SXNzdWU1NzkyNDI0NzA=	18,275	`npm install` fails on the react repo on PowerPC	{'login': 'sarveshtamba', 'id': 37213716, 'node_id': 'MDQ6VXNlcjM3MjEzNzE2', 'avatar_url': 'https://avatars.githubusercontent.com/u/37213716?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sarveshtamba', 'html_url': 'https://github.com/sarveshtamba', 'followers_url': 'https://api.github.com/users/sarveshtamba/followers', 'following_url': 'https://api.github.com/users/sarveshtamba/following{/other_user}', 'gists_url': 'https://api.github.com/users/sarveshtamba/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sarveshtamba/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sarveshtamba/subscriptions', 'organizations_url': 'https://api.github.com/users/sarveshtamba/orgs', 'repos_url': 'https://api.github.com/users/sarveshtamba/repos', 'events_url': 'https://api.github.com/users/sarveshtamba/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sarveshtamba/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "This repository uses a Yarn lockfile. Installation of dependencies should be done using Yarn, rather than NPM:\r\n\r\n```\r\nyarn install\r\n```", "@bvaughn Used `yarn install` command to build. However the build has dependency on phantomjs.\r\n\r\n```\r\nbash-4.2# yarn install\r\nyarn install v1.22.0\r\ninfo No lockfile found.\r\nwarning npm-shrinkwrap.json found. This will not be updated or respected. See https://yarnpkg.com/en/docs/migrating-from-npm for more information.\r\n[1/5] Validating package.json...\r\n[2/5] Resolving packages...\r\n...\r\n...\r\n...\r\n[3/5] Fetching packages...\r\n[4/5] Linking dependencies...\r\n[5/5] Building fresh packages...\r\n[1/2] ⢀ microtime\r\nerror /home/tester/react/node_modules/phantomjs: Command failed.\r\nExit code: 1\r\nCommand: node install.js\r\nArguments:\r\nDirectory: /home/tester/react/node_modules/phantomjs\r\nOutput:\r\nConsidering PhantomJS found at /home/tester/phantomjs\r\nFound PhantomJS at /home/tester/phantomjs ...verifying\r\nPhantomJS detected, but wrong version 2.1.1 @ /home/tester/phantomjs.\r\nUnexpected platform or architecture: linux/ppc64\r\nIt seems there is no binary available for your platform/architecture\r\nTry to install PhantomJS globally\r\n\r\nbash-4.2# echo $?\r\n1\r\n```\r\nIs it possible to use PhantomJS v2.1.1 for this repo?", "Nothing in the React repo references `phantomjs` (not even in the Yarn lockfile as an indirect dependency).\r\n\r\n```\r\n$ yarn why phantomjs \r\nyarn why v1.17.3\r\n[1/4] 🤔 Why do we have the module \"phantomjs\"...?\r\n[2/4] 🚚 Initialising dependency graph...\r\n[3/4] 🔍 Finding dependency...\r\nerror We couldn't find a match!\r\n✨ Done in 1.25s.\r\n```", "@bvaughn I switched to node v10.19.0 (earlier, I was using node v12.16.1, not sure if this could be the problem) and now the build looks out for `electron`:\r\n```\r\n[4/4] Building fresh packages...\r\n[-/12] ⠂ waiting...\r\n[-/12] ⠂ waiting...\r\n[3/12] ⠂ dtrace-provider\r\n[-/12] ⠂ waiting...\r\nerror /root/react/node_modules/electron: Command failed.\r\nExit code: 1\r\nCommand: node install.js\r\nArguments:\r\nDirectory: /root/react/node_modules/electron\r\nOutput:\r\nDownloading tmp-1026-0-electron-v5.0.9-linux-ppc64.zip\r\nError: GET https://github.com/electron/electron/releases/download/v5.0.9/electron-v5.0.9-linux-ppc64.zip returned 404\r\n/root/react/node_modules/electron/install.js:49\r\n throw err\r\n ^\r\n\r\nError: Failed to find Electron v5.0.9 for linux-ppc64 at https://github.com/electron/electron/releases/download/v5.0.9/electron-v5.0.9-linux-ppc64.zip\r\n at Request.<anonymous> (/root/react/node_modules/nugget/index.js:169:61)\r\n at Request.emit (events.js:198:13)\r\n at Request.onRequestResponse (/root/react/node_modules/request/request.js:1066:10)\r\n at ClientRequest.emit (events.js:198:13)\r\n at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:565:21)\r\n at HTTPParser.parserOnHeadersComplete (_http_common.js:111:17)\r\n at TLSSocket.socketOnData (_http_client.js:451:20)\r\n\r\n\r\n\r\n\r\nbash-4.2# yarn why electron\r\nyarn why v1.22.0\r\n[1/4] Why do we have the module \"electron\"...?\r\n[2/4] Initialising dependency graph...\r\n[3/4] Finding dependency...\r\n[4/4] Calculating file sizes...\r\n=> Found \"electron@5.0.9\"\r\ninfo Reasons this module exists\r\n - \"_project_#react-devtools\" depends on it\r\n - Hoisted from \"_project_#react-devtools#electron\"\r\ninfo Disk size without dependencies: \"4.38MB\"\r\ninfo Disk size with unique dependencies: \"10.94MB\"\r\ninfo Disk size with transitive dependencies: \"112.75MB\"\r\ninfo Number of shared dependencies: 84\r\nDone in 2.32s.\r\nbash-4.2# yarn why phantomjs\r\nyarn why v1.22.0\r\n[1/4] Why do we have the module \"phantomjs\"...?\r\n[2/4] Initialising dependency graph...\r\n[3/4] Finding dependency...\r\nerror We couldn't find a match!\r\nDone in 2.01s.\r\nbash-4.2# node -v\r\nv10.19.0\r\n```", "This looks like a network error:\r\n```\r\nDownloading tmp-1026-0-electron-v5.0.9-linux-ppc64.zip\r\nError: GET https://github.com/electron/electron/releases/download/v5.0.9/electron-v5.0.9-linux-ppc64.zip returned 404\r\n/root/react/node_modules/electron/install.js:49\r\n throw err\r\n ^\r\n```\r\nNothing we can help with. Try again? Maybe GitHub servers were down.", "@bvaughn I checked on the electron release page and found that electron v5.0.9 is not supported for ppc64/PowerPC - https://github.com/electron/electron/releases/tag/v5.0.9\r\n\r\nAny workaround possible?", "I guess you could edit [this `package.json`](https://github.com/facebook/react/blob/355970aa4b7f96ec487e29083ee8fbc87bc99fdc/packages/react-devtools/package.json) to move electron from `dependencies` into an `optionalDependencies` block to avoid the failed download from blocking the install.\r\n\r\nUpdating our build scripts to support older CPU makes like PowerPC isn't a big priority for us at the moment though, sorry. :frown:", "> I guess you could edit [this `package.json`](https://github.com/facebook/react/blob/355970aa4b7f96ec487e29083ee8fbc87bc99fdc/packages/react-devtools/package.json) to move electron from `dependencies` into an `optionalDependencies` block to avoid the failed download from blocking the install.\r\n> \r\n> Updating our build scripts to support older CPU makes like PowerPC isn't a big priority for us at the moment though, sorry. :frown:\r\n\r\nFacing the same electron related 404 download error if I edit [this package.json](https://github.com/facebook/react/blob/355970aa4b7f96ec487e29083ee8fbc87bc99fdc/packages/react-devtools/package.json) to move electron from `dependencies` into an `optionalDependencies`", "@sarveshtamba Just remove the dependency entirely then?\r\n\r\nSorry. I can't really help much here.", "@bvaughn I just removed the dependency entirely and ran yarn && yarn test and looks like it passed successfully. Can you please check below output and confirm so that I can raise a PR for the changes and merge the same in the master? TIA.\r\n```\r\nbash-4.2# git diff\r\ndiff --git a/packages/react-devtools/package.json b/packages/react-devtools/package.json\r\nindex c6839c5..808f6ea 100644\r\n--- a/packages/react-devtools/package.json\r\n+++ b/packages/react-devtools/package.json\r\n@@ -24,7 +24,6 @@\r\n },\r\n \"dependencies\": {\r\n \"cross-spawn\": \"^5.0.1\",\r\n- \"electron\": \"^5.0.0\",\r\n \"ip\": \"^1.1.4\",\r\n \"minimist\": \"^1.2.0\",\r\n \"react-devtools-core\": \"4.5.0\",\r\n\r\nbash-4.2# yarn\r\nyarn install v1.22.0\r\n[1/4] Resolving packages...\r\n[2/4] Fetching packages...\r\ninfo fsevents@1.2.9: The platform \"linux\" is incompatible with this module.\r\ninfo \"fsevents@1.2.9\" is an optional dependency and failed compatibility check. Excluding it from installation.\r\ninfo google-closure-compiler-linux@20200112.0.0: The CPU architecture \"ppc64\" is incompatible with this module.\r\ninfo \"google-closure-compiler-linux@20200112.0.0\" is an optional dependency and failed compatibility check. Excluding it from installation.\r\ninfo google-closure-compiler-osx@20200112.0.0: The platform \"linux\" is incompatible with this module.\r\ninfo \"google-closure-compiler-osx@20200112.0.0\" is an optional dependency and failed compatibility check. Excluding it from installation.\r\ninfo google-closure-compiler-osx@20200112.0.0: The CPU architecture \"ppc64\" is incompatible with this module.\r\ninfo google-closure-compiler-windows@20200112.0.0: The platform \"linux\" is incompatible with this module.\r\ninfo \"google-closure-compiler-windows@20200112.0.0\" is an optional dependency and failed compatibility check. Excluding it from installation.\r\ninfo google-closure-compiler-windows@20200112.0.0: The CPU architecture \"ppc64\" is incompatible with this module.\r\ninfo fsevents@2.1.2: The platform \"linux\" is incompatible with this module.\r\ninfo \"fsevents@2.1.2\" is an optional dependency and failed compatibility check. Excluding it from installation.\r\ninfo fsevents@2.0.7: The platform \"linux\" is incompatible with this module.\r\ninfo \"fsevents@2.0.7\" is an optional dependency and failed compatibility check. Excluding it from installation.\r\n[3/4] Linking dependencies...\r\nwarning \" > eslint-config-fbjs@1.1.1\" has incorrect peer dependency \"babel-eslint@^6.1.2\".\r\nwarning \" > eslint-config-fbjs@1.1.1\" has incorrect peer dependency \"eslint@^3.0.0\".\r\nwarning \" > eslint-config-fbjs@1.1.1\" has incorrect peer dependency \"eslint-plugin-babel@^3.3.0\".\r\nwarning \" > eslint-config-fbjs@1.1.1\" has incorrect peer dependency \"eslint-plugin-react@^5.2.2\".\r\nwarning \" > eslint-plugin-react@6.10.3\" has incorrect peer dependency \"eslint@^2.0.0 \|\| ^3.0.0\".\r\nwarning \" > jest-mock-scheduler@0.1.0\" has incorrect peer dependency \"scheduler@^0.15.0\".\r\nwarning \"workspace-aggregator-3ff9205f-d122-45cb-b735-6a7a71916815 > react-devtools-shared > react-dom-15@15.6.2\" has incorrect peer dependency \"react@^15.6.2\".\r\n[4/4] Building fresh packages...\r\nsuccess Saved lockfile.\r\n$ node node_modules/fbjs-scripts/node/check-dev-engines.js package.json && node ./scripts/flow/createFlowConfigs.js && node ./scripts/yarn/downloadReactIsForPrettyFormat.js\r\nWrote a Flow config to /home/tester/react/scripts/flow/dom/.flowconfig\r\nWrote a Flow config to /home/tester/react/scripts/flow/dom-browser/.flowconfig\r\nWrote a Flow config to /home/tester/react/scripts/flow/native/.flowconfig\r\nWrote a Flow config to /home/tester/react/scripts/flow/fabric/.flowconfig\r\nWrote a Flow config to /home/tester/react/scripts/flow/test/.flowconfig\r\nWrote a Flow config to /home/tester/react/scripts/flow/dom-relay/.flowconfig\r\nWrote a Flow config to /home/tester/react/scripts/flow/custom/.flowconfig\r\nDone in 31.05s.\r\n\r\nbash-4.2# yarn test\r\nyarn run v1.22.0\r\n$ cross-env NODE_ENV=development jest --config ./scripts/jest/config.source.js\r\n PASS packages/react-reconciler/src/__tests__/ReactIncremental-test.internal.js\r\n...\r\n...\r\n...\r\n PASS scripts/babel/__tests__/transform-prevent-infinite-loops-test.js\r\n\r\nTest Suites: 246 passed, 246 total\r\nTests: 27 skipped, 5831 passed, 5858 total\r\nSnapshots: 161 passed, 161 total\r\nTime: 82.895s, estimated 107s\r\nRan all test suites.\r\nDone in 86.59s.\r\nbash-4.2#\r\n```", "We won't be able to merge that change. `electron` is a required dependency for that package.\r\n\r\nI only suggested you remove it so you could get `yarn install` working for your unusual CPU. PowerPC is not something I think we will try to support in this repo.", "@bvaughn any side effects if electron dependency is removed entirely, will it affect any other react component?\r\nAlso the CPU is Linux PowerPC i.e linux based ppc64le architecture." ]	2020-03-11 12:53:27	2020-03-24 06:50:43	2020-03-11 17:14:21	NONE	null	null	null	Facing the following error while running npm install on the react repo v0.10.0 on PowerPC using node v12:- ``` bash-4.2# npm install npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it! npm ERR! code ETARGET npm ERR! notarget No matching version found for esprima-six@0.0.3. npm ERR! notarget In most cases you or one of your dependencies are requesting npm ERR! notarget a package version that doesn't exist. npm ERR! A complete log of this run can be found in: npm ERR! /root/.npm/_logs/2020-03-11T11_59_22_496Z-debug.log ``` I tried using lower node versions, however it does not help much. Any inputs on resolving this would be highly appreciated.	{'url': 'https://api.github.com/repos/facebook/react/issues/18275/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18275/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18274	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18274/labels{/name}	https://api.github.com/repos/facebook/react/issues/18274/comments	https://api.github.com/repos/facebook/react/issues/18274/events	https://github.com/facebook/react/pull/18274	579,218,467	MDExOlB1bGxSZXF1ZXN0Mzg2NjUyMzA1	18,274	ModernEventSystem: refactor accumulateTwoPhaseListeners	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18274/builds/14316) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 062cf72dc3f164e13290ca196dbb459cbe43a1e7:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[gifted-goldwasser-9g04q](https://codesandbox.io/s/gifted-goldwasser-9g04q)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 160505b0ca143fa458926b623a05cf2645ba799a...062cf72dc3f164e13290ca196dbb459cbe43a1e7</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| +0.3% \| +0.4% \| 124.46 KB \| 124.84 KB \| 38.82 KB \| 38.96 KB \| NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| +0.1% \| 0.0% \| 58.91 KB \| 58.98 KB \| 14.71 KB \| 14.71 KB \| UMD_DEV\nReactDOM-dev.js \| +0.2% \| +0.3% \| 920.21 KB \| 921.81 KB \| 204.84 KB \| 205.37 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.1% \| 10.27 KB \| 10.32 KB \| 3.49 KB \| 3.5 KB \| UMD_PROD\nreact-dom-test-utils.development.js \| +0.1% \| +0.1% \| 53.78 KB \| 53.85 KB \| 14.01 KB \| 14.02 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.1% \| 10.96 KB \| 11.01 KB \| 4.17 KB \| 4.17 KB \| UMD_PROD\nReactDOMTesting-dev.js \| +0.2% \| +0.3% \| 876.8 KB \| 878.4 KB \| 196.11 KB \| 196.69 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.3% \| 370.2 KB \| 371.22 KB \| 67.74 KB \| 67.95 KB \| FB_WWW_PROD\nreact-dom-test-utils.development.js \| +0.1% \| +0.1% \| 49.56 KB \| 49.63 KB \| 13.52 KB \| 13.53 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| +0.3% \| +0.3% \| 370.2 KB \| 371.22 KB \| 67.74 KB \| 67.95 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 131.19 KB \| 131.19 KB \| 34.87 KB \| 34.86 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.1% \| 10.81 KB \| 10.86 KB \| 4.1 KB \| 4.11 KB \| NODE_PROD\nreact-dom.development.js \| +0.2% \| +0.3% \| 917.79 KB \| 919.48 KB \| 200.64 KB \| 201.25 KB \| UMD_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.2% \| 120.34 KB \| 120.71 KB \| 38.41 KB \| 38.5 KB \| UMD_PROD\nReactTestUtils-dev.js \| +0.1% \| +0.1% \| 51.61 KB \| 51.68 KB \| 13.77 KB \| 13.78 KB \| FB_WWW_DEV\nreact-dom.profiling.min.js \| +0.3% \| +0.3% \| 124.17 KB \| 124.54 KB \| 39.65 KB \| 39.75 KB \| UMD_PROFILING\nreact-dom.development.js \| +0.2% \| +0.3% \| 873.59 KB \| 875.2 KB \| 198.2 KB \| 198.75 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.3% \| 120.49 KB \| 120.87 KB \| 37.63 KB \| 37.76 KB \| NODE_PROD\nReactDOM-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.3% \| 376.09 KB \| 377.11 KB \| 68.45 KB \| 68.64 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| +0.3% \| +0.3% \| 393.35 KB \| 394.37 KB \| 71.44 KB \| 71.63 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| +0.1% \| +0.1% \| 55.87 KB \| 55.94 KB \| 14.47 KB \| 14.48 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| :small_red_triangle:+0.5% \| 0.0% \| 10 KB \| 10.05 KB \| 3.37 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.19 KB \| 1.19 KB \| 699 B \| 698 B \| UMD_PROD\n\n </details>\n \n\nReactDOM: size: :small_red_triangle:+0.5%, gzip: :small_red_triangle:+0.1%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 062cf72dc3f164e13290ca196dbb459cbe43a1e7\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 160505b0ca143fa458926b623a05cf2645ba799a...062cf72dc3f164e13290ca196dbb459cbe43a1e7</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| +0.2% \| +0.3% \| 420.02 KB \| 421.03 KB \| 76.18 KB \| 76.44 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.4 KB \| 135.4 KB \| 34.82 KB \| 34.82 KB \| UMD_DEV\nReactTestUtils-dev.js \| +0.1% \| +0.1% \| 51.62 KB \| 51.68 KB \| 13.76 KB \| 13.77 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.development.js \| +0.1% \| +0.1% \| 55.86 KB \| 55.92 KB \| 14.46 KB \| 14.47 KB \| NODE_DEV\nreact-dom.development.js \| +0.2% \| +0.3% \| 887.32 KB \| 889.01 KB \| 195.41 KB \| 195.98 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| :small_red_triangle:+0.5% \| 0.0% \| 9.99 KB \| 10.04 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.4% \| 116.14 KB \| 116.52 KB \| 37.18 KB \| 37.33 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.3% \| +0.4% \| 119.85 KB \| 120.23 KB \| 38.47 KB \| 38.62 KB \| UMD_PROFILING\nreact-dom.development.js \| +0.2% \| +0.3% \| 844.4 KB \| 846.01 KB \| 192.97 KB \| 193.52 KB \| NODE_DEV\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 129.68 KB \| 129.68 KB \| 34.64 KB \| 34.64 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.4% \| 116.22 KB \| 116.6 KB \| 36.53 KB \| 36.67 KB \| NODE_PROD\nreact-dom.profiling.min.js \| +0.3% \| +0.3% \| 120.08 KB \| 120.46 KB \| 37.68 KB \| 37.8 KB \| NODE_PROFILING\nReactDOM-dev.js \| +0.2% \| +0.2% \| 966.13 KB \| 967.73 KB \| 214.83 KB \| 215.26 KB \| FB_WWW_DEV\nReactDOM-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.3% \| 402.7 KB \| 403.72 KB \| 73.14 KB \| 73.4 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nReactDOMTesting-dev.js \| +0.2% \| +0.2% \| 903.44 KB \| 905.05 KB \| 201.7 KB \| 202.14 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.3% \| 383.76 KB \| 384.78 KB \| 69.91 KB \| 70.15 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 128.46 KB \| 128.46 KB \| 34.39 KB \| 34.39 KB \| NODE_DEV\nreact-dom-test-utils.development.js \| +0.1% \| +0.1% \| 53.77 KB \| 53.84 KB \| 14 KB \| 14.01 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| +0.3% \| +0.3% \| 383.76 KB \| 384.78 KB \| 69.91 KB \| 70.15 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.1% \| 10.94 KB \| 11 KB \| 4.16 KB \| 4.16 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 138.6 KB \| 138.6 KB \| 35.33 KB \| 35.33 KB \| FB_WWW_DEV\nreact-dom-test-utils.development.js \| +0.1% \| +0.1% \| 49.55 KB \| 49.61 KB \| 13.51 KB \| 13.52 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.2% \| 10.79 KB \| 10.85 KB \| 4.09 KB \| 4.1 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| +0.1% \| 0.0% \| 58.9 KB \| 58.97 KB \| 14.7 KB \| 14.71 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| :small_red_triangle:+0.5% \| 0.0% \| 10.26 KB \| 10.31 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 062cf72dc3f164e13290ca196dbb459cbe43a1e7\n</p>\n", "@philipp-spiess I really want to stop attaching the events, but that's a breaking change and is likely to affect RNW and the Responder plugin. We also need to stop exporting the event system accumulation events. Once we do that, we should save a bunch of bytes.", "<img width=\"311\" alt=\"Screen Shot 2020-03-11 at 10 18 21 AM\" src=\"https://user-images.githubusercontent.com/29597/76444783-acd82980-6381-11ea-8a50-9063142ccb9d.png\">\r\n\r\n🤔", "> <img alt=\"Screen Shot 2020-03-11 at 10 18 21 AM\" width=\"311\" src=\"https://user-images.githubusercontent.com/29597/76444783-acd82980-6381-11ea-8a50-9063142ccb9d.png\">\r\n> \r\n> 🤔\r\n\r\nFixed. I copied the bit in brackets from the last point and forgot to remove the copied text." ]	2020-03-11 12:10:24	2020-03-12 06:34:01	2020-03-11 18:55:02	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18274', 'html_url': 'https://github.com/facebook/react/pull/18274', 'diff_url': 'https://github.com/facebook/react/pull/18274.diff', 'patch_url': 'https://github.com/facebook/react/pull/18274.patch', 'merged_at': datetime.datetime(2020, 3, 11, 18, 55, 2)}	This PR refactors, optimizes and simplifies the logic that we currently have to accumulate two phase event listeners. Previously, we have `accumulateTwoPhaseDispatchesSingle` and `accumulateTwoPhaseDispatches`. The implentation in this PR works by using the notoriously slow `unshift` array operation I often found it difficult to follow how they worked and also notice how they could be further optimized. I've commented the implementation so it should be easier to follow. I also ensured the `SyntheticEvent` object has the fields initialized, to avoid hidden class de-opts, which also allowed me to properly fix the Flow definitions and improve Flow coverage. Once we remove the `Responder` plugin, we can delete a whole lot of legacy code going forward. Furthermore, given the on-going work for the `ReactDOM.useEvent`, it occured to me that we could use a single function that accumulated listeners and later, extend this function to work with `useEvent` listeners too. ## Performance Some might be wondering why I'm using `unshift` vs alternative approaches that avoid using it. I benchmarked several different versions and the realism is that we never really build up that many listeners in real world apps (not enough to really stress `unshift` as being the bottleneck). Here are some perf measurements: - Previous Implementation (before this PR): 0.030ms - 0.355ms - This PR: 0.009ms - 0.116ms - Alternative approach (not using unshift): 0.021ms - 0.133ms	{'url': 'https://api.github.com/repos/facebook/react/issues/18274/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18274/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18273	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18273/labels{/name}	https://api.github.com/repos/facebook/react/issues/18273/comments	https://api.github.com/repos/facebook/react/issues/18273/events	https://github.com/facebook/react/pull/18273	579,022,683	MDExOlB1bGxSZXF1ZXN0Mzg2NDk0NjUw	18,273	[Flight] Encode server rendered host components as array tuples	{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18273/builds/14222) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 47df380eba4b33f9d210461e8141631073f0e583:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[elastic-albattani-lh0md](https://codesandbox.io/s/elastic-albattani-lh0md)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 99d73718636d7930a2abf0030c51c1d7710b13d8...47df380eba4b33f9d210461e8141631073f0e583</p>\n\n\n \n## react-flight-dom-relay\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFlightDOMRelayClient-dev.js \| +38.8% \| +42.1% \| 4.87 KB \| 6.75 KB \| 1.54 KB \| 2.2 KB \| FB_WWW_DEV\nReactFlightDOMRelayClient-prod.js \| :small_red_triangle:+16.6% \| :small_red_triangle:+15.6% \| 2.96 KB \| 3.45 KB \| 1.05 KB \| 1.22 KB \| FB_WWW_PROD\nReactFlightDOMRelayServer-dev.js \| -3.6% \| -4.7% \| 7.93 KB \| 7.64 KB \| 2.38 KB \| 2.27 KB \| FB_WWW_DEV\nReactFlightDOMRelayServer-prod.js \| :small_red_triangle:+0.5% \| -0.4% \| 5.68 KB \| 5.71 KB \| 1.66 KB \| 1.65 KB \| FB_WWW_PROD\n\n## react-flight-dom-webpack\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-flight-dom-webpack-server.node.development.js \| -3.2% \| -4.5% \| 8.83 KB \| 8.54 KB \| 2.73 KB \| 2.61 KB \| NODE_DEV\nreact-flight-dom-webpack-server.node.production.min.js \| -0.6% \| -1.1% \| 2.77 KB \| 2.75 KB \| 1.25 KB \| 1.24 KB \| NODE_PROD\nreact-flight-dom-webpack-server.browser.development.js \| -3.8% \| -4.9% \| 8.64 KB \| 8.31 KB \| 2.57 KB \| 2.45 KB \| UMD_DEV\nreact-flight-dom-webpack-server.browser.production.min.js \| -1.9% \| -0.9% \| 2.83 KB \| 2.78 KB \| 1.32 KB \| 1.31 KB \| UMD_PROD\nreact-flight-dom-webpack-server.browser.development.js \| -3.6% \| -4.7% \| 7.88 KB \| 7.6 KB \| 2.46 KB \| 2.34 KB \| NODE_DEV\nreact-flight-dom-webpack-server.browser.production.min.js \| -0.7% \| -0.9% \| 2.61 KB \| 2.59 KB \| 1.24 KB \| 1.23 KB \| NODE_PROD\nreact-flight-dom-webpack.development.js \| +22.8% \| +26.8% \| 8.76 KB \| 10.75 KB \| 2.39 KB \| 3.03 KB \| UMD_DEV\nreact-flight-dom-webpack.production.min.js \| :small_red_triangle:+6.8% \| :small_red_triangle:+8.7% \| 2.89 KB \| 3.09 KB \| 1.33 KB \| 1.44 KB \| UMD_PROD\nreact-flight-dom-webpack.development.js \| +23.6% \| +28.4% \| 8 KB \| 9.89 KB \| 2.28 KB \| 2.93 KB \| NODE_DEV\nreact-flight-dom-webpack.production.min.js \| :small_red_triangle:+7.4% \| :small_red_triangle:+8.8% \| 2.71 KB \| 2.91 KB \| 1.25 KB \| 1.36 KB \| NODE_PROD\n\n## react-client\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-client-flight.development.js \| +25.6% \| +28.0% \| 7.38 KB \| 9.27 KB \| 2.28 KB \| 2.92 KB \| NODE_DEV\nreact-client-flight.production.min.js \| :small_red_triangle:+8.1% \| :small_red_triangle:+9.3% \| 2.49 KB \| 2.7 KB \| 1.17 KB \| 1.27 KB \| NODE_PROD\n\n## react-server\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-server-flight.development.js \| -7.5% \| -0.5% \| 8.78 KB \| 8.12 KB \| 2.56 KB \| 2.55 KB \| NODE_DEV\nreact-server-flight.production.min.js \| -0.3% \| -0.2% \| 2.84 KB \| 2.83 KB \| 1.28 KB \| 1.28 KB \| NODE_PROD\nreact-server.development.js \| -2.0% \| -1.3% \| 3.69 KB \| 3.62 KB \| 1.24 KB \| 1.22 KB \| NODE_DEV\nreact-server.production.min.js \| 0.0% \| -0.2% \| 1.15 KB \| 1.15 KB \| 644 B \| 643 B \| NODE_PROD\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 47df380eba4b33f9d210461e8141631073f0e583\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 99d73718636d7930a2abf0030c51c1d7710b13d8...47df380eba4b33f9d210461e8141631073f0e583</p>\n\n\n \n## react-flight-dom-relay\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFlightDOMRelayServer-dev.js \| -3.6% \| -4.7% \| 7.93 KB \| 7.64 KB \| 2.38 KB \| 2.27 KB \| FB_WWW_DEV\nReactFlightDOMRelayServer-prod.js \| :small_red_triangle:+0.5% \| -0.4% \| 5.68 KB \| 5.71 KB \| 1.66 KB \| 1.65 KB \| FB_WWW_PROD\nReactFlightDOMRelayClient-dev.js \| +38.8% \| +42.1% \| 4.87 KB \| 6.75 KB \| 1.54 KB \| 2.2 KB \| FB_WWW_DEV\nReactFlightDOMRelayClient-prod.js \| :small_red_triangle:+16.6% \| :small_red_triangle:+15.6% \| 2.96 KB \| 3.45 KB \| 1.05 KB \| 1.22 KB \| FB_WWW_PROD\n\n## react-flight-dom-webpack\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-flight-dom-webpack-server.browser.development.js \| -3.6% \| -4.7% \| 7.87 KB \| 7.59 KB \| 2.45 KB \| 2.34 KB \| NODE_DEV\nreact-flight-dom-webpack-server.browser.production.min.js \| -0.7% \| -1.0% \| 2.6 KB \| 2.58 KB \| 1.23 KB \| 1.22 KB \| NODE_PROD\nreact-flight-dom-webpack.development.js \| +22.8% \| +26.9% \| 8.74 KB \| 10.74 KB \| 2.38 KB \| 3.02 KB \| UMD_DEV\nreact-flight-dom-webpack.production.min.js \| :small_red_triangle:+6.9% \| :small_red_triangle:+8.7% \| 2.88 KB \| 3.08 KB \| 1.32 KB \| 1.43 KB \| UMD_PROD\nreact-flight-dom-webpack.development.js \| +23.6% \| +28.4% \| 7.99 KB \| 9.88 KB \| 2.27 KB \| 2.92 KB \| NODE_DEV\nreact-flight-dom-webpack.production.min.js \| :small_red_triangle:+7.5% \| :small_red_triangle:+9.2% \| 2.7 KB \| 2.9 KB \| 1.24 KB \| 1.35 KB \| NODE_PROD\nreact-flight-dom-webpack-server.node.development.js \| -3.2% \| -4.5% \| 8.81 KB \| 8.53 KB \| 2.72 KB \| 2.6 KB \| NODE_DEV\nreact-flight-dom-webpack-server.node.production.min.js \| -0.6% \| -1.0% \| 2.76 KB \| 2.74 KB \| 1.24 KB \| 1.23 KB \| NODE_PROD\nreact-flight-dom-webpack-server.browser.development.js \| -3.8% \| -4.8% \| 8.63 KB \| 8.3 KB \| 2.56 KB \| 2.44 KB \| UMD_DEV\nreact-flight-dom-webpack-server.browser.production.min.js \| -1.9% \| -0.9% \| 2.82 KB \| 2.76 KB \| 1.32 KB \| 1.3 KB \| UMD_PROD\n\n## react-client\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-client-flight.development.js \| +25.6% \| +28.1% \| 7.37 KB \| 9.26 KB \| 2.27 KB \| 2.91 KB \| NODE_DEV\nreact-client-flight.production.min.js \| :small_red_triangle:+8.1% \| :small_red_triangle:+9.3% \| 2.48 KB \| 2.68 KB \| 1.16 KB \| 1.27 KB \| NODE_PROD\n\n## react-server\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-server-flight.production.min.js \| -0.3% \| 0.0% \| 2.82 KB \| 2.81 KB \| 1.27 KB \| 1.27 KB \| NODE_PROD\nreact-server-flight.development.js \| -7.5% \| -0.6% \| 8.77 KB \| 8.11 KB \| 2.55 KB \| 2.54 KB \| NODE_DEV\nreact-server.development.js \| -2.0% \| -1.3% \| 3.68 KB \| 3.6 KB \| 1.23 KB \| 1.22 KB \| NODE_DEV\nreact-server.production.min.js \| 0.0% \| -0.2% \| 1.14 KB \| 1.14 KB \| 636 B \| 635 B \| NODE_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 47df380eba4b33f9d210461e8141631073f0e583\n</p>\n", "> In a follow up I intend to encode Block Pairs (\"thunks\") as [\"@\", render, data].\r\n\r\n👍 \r\n\r\n> It would be nicer if React's reconciler could just accept these tuples directly. We should consider that as part of the deprecation work around elements.\r\n\r\nWould be cleaner conceptually and also faster - are there any particular concerns or challenges to doing that?", "> Would be cleaner conceptually and also faster - are there any particular concerns or challenges to doing that?\r\n\r\nThere are challenges to changing existing React Elements. Mostly because people read from them using `element.props.foo` or do isArray type checks on various things like traversing down a VDOM tree.\r\n\r\nWe could add these as a new type of element though. It'll mean they break similar traversal mechanisms that check for isArray or iterable etc. But it's plausible." ]	2020-03-11 05:41:12	2020-03-12 13:25:54	2020-03-11 16:48:03	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18273', 'html_url': 'https://github.com/facebook/react/pull/18273', 'diff_url': 'https://github.com/facebook/react/pull/18273.diff', 'patch_url': 'https://github.com/facebook/react/pull/18273.patch', 'merged_at': datetime.datetime(2020, 3, 11, 16, 48, 3)}	This replaces the HTML renderer with instead resolving host elements into arrays tagged with the `react.element` symbol. These turn into proper React Elements on the client. The symbol is encoded as the magical value `"$"`. This has security implications so this special value needs to remain escaped for other strings. We could just encode the element as `{$$typeof: "$", type: type, key: key props: props}` but that's a lot more bytes. So instead I encode it as `["$", type, key, props]` and then convert it back on the client. In a follow up I intend to encode Block Pairs ("thunks") as `["@", render, data]`. It would be nicer if React's reconciler could just accept these tuples directly. We should consider that as part of the deprecation work around elements.	{'url': 'https://api.github.com/repos/facebook/react/issues/18273/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18273/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18272	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18272/labels{/name}	https://api.github.com/repos/facebook/react/issues/18272/comments	https://api.github.com/repos/facebook/react/issues/18272/events	https://github.com/facebook/react/pull/18272	578,741,065	MDExOlB1bGxSZXF1ZXN0Mzg2MjY0OTk4	18,272	Don't warn about unmounted state updates from a passive destroy function	{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18272/builds/14151) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit c1799c33aab7498df7c2feae6c100bec4bacd5fa:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[cool-night-cxl0g](https://codesandbox.io/s/cool-night-cxl0g)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c1799c33aab7498df7c2feae6c100bec4bacd5fa\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c1799c33aab7498df7c2feae6c100bec4bacd5fa\n</p>\n", "Why?", "To be clear, I don't think this is the right change to make- but I haven't gotten much feedback from others on the team yet about their feelings. So I posted this PR in case we end up deciding that the warning should be reverted for now.\r\n\r\nNot really any hurry. Just thought I'd post it while it was top of mind.\r\n\r\nEdit There's an internal discussion thread on \"why\" (and \"why not\" IMO)", "Yeah I also have the instinct that it's not right. I think this would most likely happen if you dispatch a Flux action or something inside the unmount function, which then accidentally fires a `setState` on the component that is unmounting. Which isn't a great pattern, but even still, the fix would be to unsubscribe from the Flux store before dispatching the action.\r\n\r\nCurious to hear from others if there are arguments in favor of suppressing the warning.", "Should we be warning on setState in cleanup in general? Seems a bit annoying to fix when you only \"see\" the unmount one but the fix involves fixing both anyway.", "Yeah, I mentioned this in my internal thread. I actually think we should, because I think there aren't really any good cases for updating state in a cleanup function.", "Closing in favor of #18307." ]	2020-03-10 17:22:00	2020-03-13 21:35:48	2020-03-13 21:35:47	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18272', 'html_url': 'https://github.com/facebook/react/pull/18272', 'diff_url': 'https://github.com/facebook/react/pull/18272.diff', 'patch_url': 'https://github.com/facebook/react/pull/18272.patch', 'merged_at': None}	Suppress new warning introduced by PRs #17925 and #17947.	{'url': 'https://api.github.com/repos/facebook/react/issues/18272/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18272/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18271	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18271/labels{/name}	https://api.github.com/repos/facebook/react/issues/18271/comments	https://api.github.com/repos/facebook/react/issues/18271/events	https://github.com/facebook/react/pull/18271	578,735,768	MDExOlB1bGxSZXF1ZXN0Mzg2MjYwNjYx	18,271	ReactDOM.useEvent: Add more scaffolding for useEvent hook	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18271/builds/14193) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 8244805dde803bd9717f28a332a6d246b68b8359:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[divine-frog-10uqj](https://codesandbox.io/s/divine-frog-10uqj)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: a3bf6688121e69cfb377c25f362000b33d7984cd...8244805dde803bd9717f28a332a6d246b68b8359</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| +0.1% \| +0.1% \| 124.39 KB \| 124.46 KB \| 38.8 KB \| 38.82 KB \| NODE_PROFILING\nReactDOM-dev.js \| +0.1% \| 0.0% \| 918.98 KB \| 920.21 KB \| 204.76 KB \| 204.84 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.27 KB \| 10.27 KB \| 3.5 KB \| 3.5 KB \| UMD_PROD\nReactDOMServer-dev.js \| +0.1% \| +0.1% \| 137.64 KB \| 137.75 KB \| 35.17 KB \| 35.19 KB \| FB_WWW_DEV\nReactDOMTesting-dev.js \| +0.1% \| 0.0% \| 875.57 KB \| 876.8 KB \| 196.02 KB \| 196.11 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 370.03 KB \| 370.2 KB \| 67.71 KB \| 67.74 KB \| FB_WWW_PROD\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 370.03 KB \| 370.2 KB \| 67.71 KB \| 67.74 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| +0.1% \| +0.1% \| 131.08 KB \| 131.19 KB \| 34.83 KB \| 34.87 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 10.81 KB \| 10.81 KB \| 4.1 KB \| 4.1 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.3% \| 20.83 KB \| 20.88 KB \| 7.61 KB \| 7.63 KB \| NODE_PROD\nreact-dom.development.js \| +0.1% \| 0.0% \| 916.47 KB \| 917.79 KB \| 200.56 KB \| 200.64 KB \| UMD_DEV\nreact-dom-server.browser.development.js \| +0.1% \| +0.1% \| 136.87 KB \| 136.99 KB \| 34.99 KB \| 35.02 KB \| UMD_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.1% \| 0.0% \| 120.27 KB \| 120.34 KB \| 38.41 KB \| 38.42 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 20.51 KB \| 20.56 KB \| 7.51 KB \| 7.52 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.1% \| +0.1% \| 124.09 KB \| 124.17 KB \| 39.63 KB \| 39.65 KB \| UMD_PROFILING\nreact-dom.development.js \| +0.1% \| 0.0% \| 872.36 KB \| 873.59 KB \| 198.11 KB \| 198.2 KB \| NODE_DEV\nreact-dom-server.browser.development.js \| +0.1% \| +0.1% \| 129.87 KB \| 129.97 KB \| 34.58 KB \| 34.61 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 120.42 KB \| 120.49 KB \| 37.61 KB \| 37.63 KB \| NODE_PROD\nreact-dom-server.browser.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.3% \| 20.43 KB \| 20.48 KB \| 7.46 KB \| 7.48 KB \| NODE_PROD\nReactDOM-prod.js \| 0.0% \| 0.0% \| 375.92 KB \| 376.09 KB \| 68.43 KB \| 68.45 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.2% \| 46.78 KB \| 46.86 KB \| 10.87 KB \| 10.89 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| 0.0% \| 0.0% \| 393.18 KB \| 393.35 KB \| 71.42 KB \| 71.44 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1.16 KB \| 1.16 KB \| 662 B \| 663 B \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 1.19 KB \| 1.19 KB \| 699 B \| 700 B \| UMD_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1 KB \| 1 KB \| 610 B \| 611 B \| NODE_PROD\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| +0.2% \| +0.1% \| 637.41 KB \| 638.73 KB \| 133.87 KB \| 133.97 KB \| UMD_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 107.01 KB \| 107.09 KB \| 32.35 KB \| 32.37 KB \| UMD_PROD\nreact-art.development.js \| +0.2% \| +0.1% \| 541.46 KB \| 542.69 KB \| 116.29 KB \| 116.38 KB \| NODE_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 71.99 KB \| 72.06 KB \| 21.54 KB \| 21.56 KB \| NODE_PROD\nReactART-dev.js \| +0.2% \| +0.1% \| 554.66 KB \| 555.89 KB \| 116.34 KB \| 116.43 KB \| FB_WWW_DEV\nReactART-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 226.21 KB \| 226.38 KB \| 38.55 KB \| 38.58 KB \| FB_WWW_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer-shallow.development.js \| 0.0% \| -0.0% \| 38.4 KB \| 38.4 KB \| 9.3 KB \| 9.3 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.92 KB \| 12.92 KB \| 3.94 KB \| 3.94 KB \| UMD_PROD\nReactTestRenderer-dev.js \| +0.2% \| +0.1% \| 555.01 KB \| 556.24 KB \| 117.25 KB \| 117.33 KB \| FB_WWW_DEV\nreact-test-renderer.development.js \| +0.2% \| +0.1% \| 553.96 KB \| 555.28 KB \| 115.38 KB \| 115.48 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 71.3 KB \| 71.37 KB \| 21.72 KB \| 21.75 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.2% \| +0.1% \| 527.93 KB \| 529.17 KB \| 114.07 KB \| 114.16 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 71.11 KB \| 71.18 KB \| 21.37 KB \| 21.39 KB \| NODE_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| +0.2% \| +0.1% \| 579.94 KB \| 581.18 KB \| 122.22 KB \| 122.31 KB \| NODE_DEV\nreact-reconciler.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 76.85 KB \| 76.92 KB \| 22.55 KB \| 22.57 KB \| NODE_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFabric-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 251.89 KB \| 252.06 KB \| 43.74 KB \| 43.76 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.1% \| +0.1% \| 263.69 KB \| 263.86 KB \| 46 KB \| 46.03 KB \| RN_OSS_PROFILING\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 259.93 KB \| 260.1 KB \| 45.22 KB \| 45.25 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.1% \| +0.1% \| 271.73 KB \| 271.89 KB \| 47.47 KB \| 47.5 KB \| RN_OSS_PROFILING\nReactNativeRenderer-dev.js \| +0.2% \| +0.1% \| 636.77 KB \| 637.99 KB \| 137.92 KB \| 138 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 260.08 KB \| 260.24 KB \| 45.25 KB \| 45.27 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| +0.1% \| +0.1% \| 271.87 KB \| 272.03 KB \| 47.5 KB \| 47.53 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| +0.2% \| +0.1% \| 616.01 KB \| 617.23 KB \| 133.25 KB \| 133.34 KB \| RN_OSS_DEV\nReactFabric-dev.js \| +0.2% \| +0.1% \| 618.72 KB \| 619.95 KB \| 133.58 KB \| 133.66 KB \| RN_FB_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 252.05 KB \| 252.21 KB \| 43.77 KB \| 43.79 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| +0.2% \| +0.1% \| 634.06 KB \| 635.28 KB \| 137.58 KB \| 137.66 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| +0.1% \| +0.1% \| 263.84 KB \| 264.01 KB \| 46.03 KB \| 46.06 KB \| RN_FB_PROFILING\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8244805dde803bd9717f28a332a6d246b68b8359\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: a3bf6688121e69cfb377c25f362000b33d7984cd...8244805dde803bd9717f28a332a6d246b68b8359</p>\n\n\n \n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.2% \| +0.1% \| 634.04 KB \| 635.27 KB \| 137.58 KB \| 137.66 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 259.92 KB \| 260.08 KB \| 45.21 KB \| 45.24 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.1% \| +0.1% \| 271.71 KB \| 271.88 KB \| 47.47 KB \| 47.49 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.2% \| +0.1% \| 615.99 KB \| 617.22 KB \| 133.24 KB \| 133.33 KB \| RN_OSS_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 251.88 KB \| 252.05 KB \| 43.73 KB \| 43.75 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.1% \| +0.1% \| 263.68 KB \| 263.84 KB \| 45.99 KB \| 46.02 KB \| RN_OSS_PROFILING\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| +0.2% \| +0.1% \| 521.35 KB \| 522.58 KB \| 112.55 KB \| 112.64 KB \| NODE_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 69.29 KB \| 69.36 KB \| 20.8 KB \| 20.82 KB \| NODE_PROD\nReactART-dev.js \| +0.2% \| +0.1% \| 582.73 KB \| 583.96 KB \| 121.96 KB \| 122.07 KB \| FB_WWW_DEV\nReactART-prod.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 235.06 KB \| 235.23 KB \| 39.96 KB \| 39.98 KB \| FB_WWW_PROD\nreact-art.development.js \| +0.2% \| +0.1% \| 616.46 KB \| 617.78 KB \| 130.18 KB \| 130.27 KB \| UMD_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.1% \| 0.0% \| 104.26 KB \| 104.33 KB \| 31.62 KB \| 31.63 KB \| UMD_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer-shallow.development.js \| 0.0% \| -0.0% \| 38.39 KB \| 38.39 KB \| 9.29 KB \| 9.29 KB \| UMD_DEV\nreact-test-renderer.development.js \| +0.2% \| +0.1% \| 527.91 KB \| 529.14 KB \| 114.06 KB \| 114.14 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 71.09 KB \| 71.16 KB \| 21.36 KB \| 21.37 KB \| NODE_PROD\nReactTestRenderer-dev.js \| +0.2% \| +0.1% \| 555 KB \| 556.23 KB \| 117.24 KB \| 117.33 KB \| FB_WWW_DEV\nreact-test-renderer.development.js \| +0.2% \| +0.1% \| 553.93 KB \| 555.25 KB \| 115.37 KB \| 115.47 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 71.28 KB \| 71.35 KB \| 21.71 KB \| 21.73 KB \| UMD_PROD\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| 0.0% \| 0.0% \| 419.84 KB \| 420.02 KB \| 76.16 KB \| 76.18 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| +0.1% \| +0.1% \| 135.28 KB \| 135.4 KB \| 34.79 KB \| 34.82 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1.15 KB \| 1.15 KB \| 653 B \| 654 B \| NODE_PROD\nreact-dom-server.browser.production.min.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.4% \| 20.05 KB \| 20.1 KB \| 7.42 KB \| 7.45 KB \| UMD_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 55.86 KB \| 55.86 KB \| 14.46 KB \| 14.46 KB \| NODE_DEV\nreact-dom.development.js \| +0.1% \| 0.0% \| 886 KB \| 887.32 KB \| 195.32 KB \| 195.41 KB \| UMD_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.1% \| 0.0% \| 116.07 KB \| 116.14 KB \| 37.17 KB \| 37.18 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.1% \| +0.1% \| 119.78 KB \| 119.85 KB \| 38.43 KB \| 38.47 KB \| UMD_PROFILING\nreact-dom.development.js \| +0.1% \| 0.0% \| 843.17 KB \| 844.4 KB \| 192.88 KB \| 192.97 KB \| NODE_DEV\nreact-dom-server.node.development.js \| +0.1% \| +0.1% \| 129.57 KB \| 129.68 KB \| 34.61 KB \| 34.64 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.1% \| 0.0% \| 116.15 KB \| 116.22 KB \| 36.52 KB \| 36.53 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.3% \| 20.38 KB \| 20.43 KB \| 7.53 KB \| 7.55 KB \| NODE_PROD\nreact-dom.profiling.min.js \| +0.1% \| +0.1% \| 120.01 KB \| 120.08 KB \| 37.65 KB \| 37.68 KB \| NODE_PROFILING\nReactDOM-dev.js \| +0.1% \| 0.0% \| 964.9 KB \| 966.13 KB \| 214.75 KB \| 214.83 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| 0.0% \| 402.53 KB \| 402.7 KB \| 73.11 KB \| 73.14 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nReactDOMTesting-dev.js \| +0.1% \| 0.0% \| 902.21 KB \| 903.44 KB \| 201.61 KB \| 201.7 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 383.59 KB \| 383.76 KB \| 69.88 KB \| 69.91 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| +0.1% \| +0.1% \| 128.35 KB \| 128.46 KB \| 34.36 KB \| 34.39 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 383.59 KB \| 383.76 KB \| 69.88 KB \| 69.91 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.3% \| 19.97 KB \| 20.02 KB \| 7.38 KB \| 7.4 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 1.17 KB \| 1.17 KB \| 690 B \| 691 B \| UMD_PROD\nReactDOMServer-dev.js \| +0.1% \| +0.1% \| 138.5 KB \| 138.6 KB \| 35.3 KB \| 35.33 KB \| FB_WWW_DEV\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 49.55 KB \| 49.55 KB \| 13.51 KB \| 13.51 KB \| NODE_DEV\nReactDOMServer-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.2% \| 47.49 KB \| 47.57 KB \| 11.05 KB \| 11.07 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1013 B \| 1013 B \| 602 B \| 603 B \| NODE_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| +0.2% \| +0.1% \| 557.5 KB \| 558.73 KB \| 118.02 KB \| 118.1 KB \| NODE_DEV\nreact-reconciler.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 73.76 KB \| 73.83 KB \| 21.78 KB \| 21.81 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: :small_red_triangle:+0.3%, gzip: :small_red_triangle:+0.4%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8244805dde803bd9717f28a332a6d246b68b8359\n</p>\n", "@trueadm you have added react-dom-16.13.0.tgz. it's a mistake?", "@ecreeth Nicly spotted. Thanks :)" ]	2020-03-10 17:12:51	2020-03-11 14:42:16	2020-03-10 20:31:13	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18271', 'html_url': 'https://github.com/facebook/react/pull/18271', 'diff_url': 'https://github.com/facebook/react/pull/18271.diff', 'patch_url': 'https://github.com/facebook/react/pull/18271.patch', 'merged_at': datetime.datetime(2020, 3, 10, 20, 31, 13)}	This PR is a follow up to https://github.com/facebook/react/pull/18267. Specifically, this adds a bit more of the `useEvent` hook implementation (but most just leaves most the code as TODOs). Furthermore, there's a very simple test that validates that the hook works in terms of returning the same event listener map.	{'url': 'https://api.github.com/repos/facebook/react/issues/18271/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18271/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18270	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18270/labels{/name}	https://api.github.com/repos/facebook/react/issues/18270/comments	https://api.github.com/repos/facebook/react/issues/18270/events	https://github.com/facebook/react/pull/18270	578,672,504	MDExOlB1bGxSZXF1ZXN0Mzg2MjA4NTMz	18,270	Flare: Fix listener upgrade bug	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18270/builds/14149) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit db1f2266282f1fc21ed7e8dbbd678fb44981d18f:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[modest-wing-z8xyw](https://codesandbox.io/s/modest-wing-z8xyw)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 29534252add3b90f7984a0f1c89937ed32d36ceb...db1f2266282f1fc21ed7e8dbbd678fb44981d18f</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 124.38 KB \| 124.39 KB \| 38.8 KB \| 38.8 KB \| NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.91 KB \| 58.91 KB \| 14.71 KB \| 14.71 KB \| UMD_DEV\nReactDOM-dev.js \| 0.0% \| 0.0% \| 911.07 KB \| 911.44 KB \| 203.62 KB \| 203.68 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.27 KB \| 10.27 KB \| 3.5 KB \| 3.5 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 137.64 KB \| 137.64 KB \| 35.16 KB \| 35.17 KB \| FB_WWW_DEV\nReactDOMTesting-dev.js \| 0.0% \| 0.0% \| 875.16 KB \| 875.57 KB \| 195.95 KB \| 196.02 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 369.92 KB \| 370.03 KB \| 67.69 KB \| 67.71 KB \| FB_WWW_PROD\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 369.92 KB \| 370.03 KB \| 67.69 KB \| 67.71 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 131.08 KB \| 131.08 KB \| 34.84 KB \| 34.83 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 10.81 KB \| 10.81 KB \| 4.1 KB \| 4.1 KB \| NODE_PROD\nreact-dom.development.js \| 0.0% \| 0.0% \| 916.32 KB \| 916.47 KB \| 200.5 KB \| 200.56 KB \| UMD_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 136.87 KB \| 136.87 KB \| 34.99 KB \| 34.99 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 120.26 KB \| 120.27 KB \| 38.41 KB \| 38.41 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.51 KB \| 20.51 KB \| 7.51 KB \| 7.51 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 124.08 KB \| 124.09 KB \| 39.62 KB \| 39.63 KB \| UMD_PROFILING\nreact-dom.development.js \| 0.0% \| 0.0% \| 872.21 KB \| 872.36 KB \| 198.06 KB \| 198.11 KB \| NODE_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 129.87 KB \| 129.87 KB \| 34.58 KB \| 34.58 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 120.41 KB \| 120.42 KB \| 37.61 KB \| 37.61 KB \| NODE_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.43 KB \| 20.43 KB \| 7.46 KB \| 7.46 KB \| NODE_PROD\nReactDOM-prod.js \| 0.0% \| 0.0% \| 375.84 KB \| 375.92 KB \| 68.41 KB \| 68.43 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| 0.0% \| 0.0% \| 387.53 KB \| 387.61 KB \| 70.57 KB \| 70.58 KB \| FB_WWW_PROFILING\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10 KB \| 10 KB \| 3.38 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.16 KB \| 1.16 KB \| 664 B \| 663 B \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.1% \| 1.19 KB \| 1.19 KB \| 700 B \| 699 B \| UMD_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.3% \| 1 KB \| 1 KB \| 612 B \| 610 B \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against db1f2266282f1fc21ed7e8dbbd678fb44981d18f\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 29534252add3b90f7984a0f1c89937ed32d36ceb...db1f2266282f1fc21ed7e8dbbd678fb44981d18f</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| 0.0% \| 0.0% \| 414.21 KB \| 414.3 KB \| 75.34 KB \| 75.36 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.28 KB \| 135.28 KB \| 34.79 KB \| 34.78 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| -0.2% \| 1.15 KB \| 1.15 KB \| 655 B \| 654 B \| NODE_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 20.05 KB \| 20.05 KB \| 7.42 KB \| 7.42 KB \| UMD_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 55.86 KB \| 55.86 KB \| 14.46 KB \| 14.46 KB \| NODE_DEV\nreact-dom.development.js \| 0.0% \| 0.0% \| 885.85 KB \| 886 KB \| 195.26 KB \| 195.32 KB \| UMD_DEV\nreact-dom.production.min.js \| 0.0% \| -0.1% \| 116.06 KB \| 116.07 KB \| 37.19 KB \| 37.17 KB \| UMD_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 119.77 KB \| 119.78 KB \| 38.41 KB \| 38.43 KB \| UMD_PROFILING\nreact-dom.development.js \| 0.0% \| 0.0% \| 843.02 KB \| 843.17 KB \| 192.82 KB \| 192.88 KB \| NODE_DEV\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 129.57 KB \| 129.57 KB \| 34.61 KB \| 34.61 KB \| NODE_DEV\nreact-dom.production.min.js \| 0.0% \| 0.0% \| 116.14 KB \| 116.15 KB \| 36.51 KB \| 36.52 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| -0.0% \| 20.38 KB \| 20.38 KB \| 7.53 KB \| 7.53 KB \| NODE_PROD\nreact-dom.profiling.min.js \| 0.0% \| 0.0% \| 120 KB \| 120.01 KB \| 37.64 KB \| 37.64 KB \| NODE_PROFILING\nReactDOM-dev.js \| 0.0% \| 0.0% \| 957 KB \| 957.36 KB \| 213.59 KB \| 213.67 KB \| FB_WWW_DEV\nReactDOM-prod.js \| 0.0% \| 0.0% \| 402.44 KB \| 402.53 KB \| 73.08 KB \| 73.11 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| -0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nReactDOMTesting-dev.js \| 0.0% \| 0.0% \| 901.81 KB \| 902.21 KB \| 201.53 KB \| 201.61 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| 0.0% \| 0.0% \| 383.47 KB \| 383.59 KB \| 69.85 KB \| 69.88 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 128.35 KB \| 128.35 KB \| 34.36 KB \| 34.36 KB \| NODE_DEV\nReactDOMTesting-profiling.js \| 0.0% \| 0.0% \| 383.47 KB \| 383.59 KB \| 69.85 KB \| 69.88 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| -0.0% \| 19.97 KB \| 19.97 KB \| 7.38 KB \| 7.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.1% \| 3.34 KB \| 3.34 KB \| 1.26 KB \| 1.26 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 10.94 KB \| 10.94 KB \| 4.16 KB \| 4.16 KB \| UMD_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.3% \| 1.17 KB \| 1.17 KB \| 692 B \| 690 B \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 138.5 KB \| 138.5 KB \| 35.3 KB \| 35.3 KB \| FB_WWW_DEV\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 49.55 KB \| 49.55 KB \| 13.51 KB \| 13.51 KB \| NODE_DEV\nReactDOMServer-prod.js \| 0.0% \| -0.0% \| 47.49 KB \| 47.49 KB \| 11.05 KB \| 11.05 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| -0.2% \| 2.94 KB \| 2.94 KB \| 1.17 KB \| 1.17 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.9 KB \| 58.9 KB \| 14.7 KB \| 14.7 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| -0.3% \| 1013 B \| 1013 B \| 604 B \| 602 B \| NODE_PROD\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.26 KB \| 10.26 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against db1f2266282f1fc21ed7e8dbbd678fb44981d18f\n</p>\n" ]	2020-03-10 15:38:05	2020-03-18 01:28:32	2020-03-10 17:59:04	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18270', 'html_url': 'https://github.com/facebook/react/pull/18270', 'diff_url': 'https://github.com/facebook/react/pull/18270.diff', 'patch_url': 'https://github.com/facebook/react/pull/18270.patch', 'merged_at': datetime.datetime(2020, 3, 10, 17, 59, 4)}	This fixes a bug that was found internally when attempting to upgrade to an active event listener. We weren't properly removing the passive event listener. Also wired up logic for fb event listeners so we correctly remove those too.	{'url': 'https://api.github.com/repos/facebook/react/issues/18270/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1}	https://api.github.com/repos/facebook/react/issues/18270/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18269	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18269/labels{/name}	https://api.github.com/repos/facebook/react/issues/18269/comments	https://api.github.com/repos/facebook/react/issues/18269/events	https://github.com/facebook/react/issues/18269	578,562,470	MDU6SXNzdWU1Nzg1NjI0NzA=	18,269	set blank_issues-enabled to false in config.yml	{'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'https://api.github.com/users/ghost/following{/other_user}', 'gists_url': 'https://api.github.com/users/ghost/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ghost/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ghost/subscriptions', 'organizations_url': 'https://api.github.com/users/ghost/orgs', 'repos_url': 'https://api.github.com/users/ghost/repos', 'events_url': 'https://api.github.com/users/ghost/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ghost/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "People often submit issues that don't use the standard template, and I don't think we want to lock out every one at the moment. It's alright. Thanks!" ]	2020-03-10 13:01:26	2020-03-10 13:24:29	2020-03-10 13:24:29	NONE	null	null	null	Anyways blank issues will be closed, so why allow them in the first place? Thus, disable Blank Issue option in config.yml https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser	{'url': 'https://api.github.com/repos/facebook/react/issues/18269/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18269/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18268	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18268/labels{/name}	https://api.github.com/repos/facebook/react/issues/18268/comments	https://api.github.com/repos/facebook/react/issues/18268/events	https://github.com/facebook/react/issues/18268	578,554,753	MDU6SXNzdWU1Nzg1NTQ3NTM=	18,268	Bug: hooks are not allowed with asyc	{'login': 'jinhale', 'id': 2700346, 'node_id': 'MDQ6VXNlcjI3MDAzNDY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2700346?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jinhale', 'html_url': 'https://github.com/jinhale', 'followers_url': 'https://api.github.com/users/jinhale/followers', 'following_url': 'https://api.github.com/users/jinhale/following{/other_user}', 'gists_url': 'https://api.github.com/users/jinhale/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jinhale/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jinhale/subscriptions', 'organizations_url': 'https://api.github.com/users/jinhale/orgs', 'repos_url': 'https://api.github.com/users/jinhale/repos', 'events_url': 'https://api.github.com/users/jinhale/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jinhale/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"} {'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "Create issue in React Native repo", "Please make a reproducible example with codesandbox, or a git repo that demonstrates this problem. Thank you!" ]	2020-03-10 12:47:20	2020-03-10 14:02:18	2020-03-10 14:02:18	NONE	null	null	null	Reliably, calling `setDeviceInfo`, will fail if using `await`, but will succeed if the same data is used but without using `await` in an async function. React version: react-native-cli: 2.0.1 react-native: 0.61.4 ## Steps To Reproduce Compare the working and failing code. ``` // working code example: const configuration = { oaaID: 0, sRegistrationTokenId: '', sUniqueHardwareId: DeviceInfo.getUniqueId(), token: '', os: '', }; function readAdminConfiguration() { // const config = await AsyncStorage.getItem('admin-configuration'); // return config ? JSON.parse(config) : getAdminConfiguration(); return {...configuration}; } export default function TechnicalComponent({ isVisible, username, }) { const [deviceInfo, setDeviceInfo] = useState(null); const [isReady, setIsReady] = useState(false); useEffect(() => { if (!isReady) { restoreDeviceInfo(); } }, [isReady]); function restoreDeviceInfo() { try { const info = readAdminConfiguration(); if (info) { setDeviceInfo(info); } } catch (e) { console.log('error: ', e); } finally { setIsReady(true); } } return null; } ``` ``` // failed code example: const configuration = { oaaID: 0, sRegistrationTokenId: '', sUniqueHardwareId: DeviceInfo.getUniqueId(), token: '', os: '', }; async function readAdminConfiguration() { // Yes, I know to stringify objects and await AsyncStorage.setItem. const config = await AsyncStorage.getItem('admin-configuration'); return config ? JSON.parse(config) : {...configuration}; // return getAdminConfiguration(); } export default function TechnicalComponent({ isVisible, username, }) { const [deviceInfo, setDeviceInfo] = useState(null); const [isReady, setIsReady] = useState(false); useEffect(() => { if (!isReady) { restoreDeviceInfo(); } }, [isReady]); async function restoreDeviceInfo() { try { const info = await readAdminConfiguration(); if (info) { setDeviceInfo(info); } } catch (e) { console.log('error: ', e); } finally { setIsReady(true); } } return null; } ``` ## The current behavior Calling `setDeviceInfo` yields the following error: ``` error: [Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. ``` ## The expected behavior Upon calling `setDeviceInfo` the same behavior should be observed in both instances. Using promises should be allowed as well.	{'url': 'https://api.github.com/repos/facebook/react/issues/18268/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18268/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18267	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18267/labels{/name}	https://api.github.com/repos/facebook/react/issues/18267/comments	https://api.github.com/repos/facebook/react/issues/18267/events	https://github.com/facebook/react/pull/18267	578,516,585	MDExOlB1bGxSZXF1ZXN0Mzg2MDgxODE1	18,267	ReactDOM.useEvent add flag and entry point	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18267/builds/14084) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit fb321da597356d75015cf7bbc6928911faee9379:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[blissful-roentgen-05qjc](https://codesandbox.io/s/blissful-roentgen-05qjc)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fb321da597356d75015cf7bbc6928911faee9379\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fb321da597356d75015cf7bbc6928911faee9379\n</p>\n", "@threepointone There's nothing to really test right now. The code in this PR is not used anywhere just yet. In a couple of PRs there will be something that can be tested. :)", "Yeah haha I figured. :shipit: " ]	2020-03-10 11:35:03	2020-03-10 12:18:53	2020-03-10 12:18:50	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18267', 'html_url': 'https://github.com/facebook/react/pull/18267', 'diff_url': 'https://github.com/facebook/react/pull/18267.diff', 'patch_url': 'https://github.com/facebook/react/pull/18267.patch', 'merged_at': datetime.datetime(2020, 3, 10, 12, 18, 50)}	This PR adds the `enableUseEventAPI` flag and the experimental `ReactDOM.useEvent` entry point (but is not exposed in any of our bundles). This PR is just very early scaffolding and doesn't do much more, follow up PRs will add more parts of the `useEvent` API. Please note: This API is intended for internal FB testing only.	{'url': 'https://api.github.com/repos/facebook/react/issues/18267/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18267/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18266	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18266/labels{/name}	https://api.github.com/repos/facebook/react/issues/18266/comments	https://api.github.com/repos/facebook/react/issues/18266/events	https://github.com/facebook/react/pull/18266	578,485,025	MDExOlB1bGxSZXF1ZXN0Mzg2MDU2MTUx	18,266	Fix Flow type for AnyNativeEvent	{'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'following_url': 'https://api.github.com/users/trueadm/following{/other_user}', 'gists_url': 'https://api.github.com/users/trueadm/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/trueadm/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/trueadm/subscriptions', 'organizations_url': 'https://api.github.com/users/trueadm/orgs', 'repos_url': 'https://api.github.com/users/trueadm/repos', 'events_url': 'https://api.github.com/users/trueadm/events{/privacy}', 'received_events_url': 'https://api.github.com/users/trueadm/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18266/builds/14081) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit e271083ac49c7ee3092da5099aa2d4b40323d1e0:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[nervous-pare-yitv5](https://codesandbox.io/s/nervous-pare-yitv5)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e271083ac49c7ee3092da5099aa2d4b40323d1e0\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e271083ac49c7ee3092da5099aa2d4b40323d1e0\n</p>\n" ]	2020-03-10 10:38:31	2020-03-10 10:46:16	2020-03-10 10:46:12	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18266', 'html_url': 'https://github.com/facebook/react/pull/18266', 'diff_url': 'https://github.com/facebook/react/pull/18266.diff', 'patch_url': 'https://github.com/facebook/react/pull/18266.patch', 'merged_at': datetime.datetime(2020, 3, 10, 10, 46, 12)}	I noticed this a while back and came across it today again. This refines `AnyNativeEvent` which incorrectly used `Touch` rather than `TouchEvent` (they are different things entirely).	{'url': 'https://api.github.com/repos/facebook/react/issues/18266/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18266/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18265	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18265/labels{/name}	https://api.github.com/repos/facebook/react/issues/18265/comments	https://api.github.com/repos/facebook/react/issues/18265/events	https://github.com/facebook/react/pull/18265	578,388,183	MDExOlB1bGxSZXF1ZXN0Mzg1OTc3OTY0	18,265	Bugfix: "Captured" updates on legacy queue	{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18265/builds/14317) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 62de1b3b29e7827f99134e6b64a2acee970ed8cf:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[jovial-waterfall-bxv90](https://codesandbox.io/s/jovial-waterfall-bxv90)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: bdc5cc4635f13e5ca43883a9f9587fc9a868c528...62de1b3b29e7827f99134e6b64a2acee970ed8cf</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| +0.4% \| +0.4% \| 124.38 KB \| 124.89 KB \| 38.79 KB \| 38.94 KB \| NODE_PROFILING\nReactDOM-dev.js \| +0.3% \| +0.3% \| 910.99 KB \| 914.16 KB \| 203.61 KB \| 204.29 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.27 KB \| 10.27 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 10.96 KB \| 10.96 KB \| 4.17 KB \| 4.17 KB \| UMD_PROD\nReactDOMTesting-dev.js \| +0.4% \| +0.3% \| 875.09 KB \| 878.25 KB \| 195.94 KB \| 196.63 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.2% \| 369.92 KB \| 371.41 KB \| 67.69 KB \| 67.85 KB \| FB_WWW_PROD\nReactDOMTesting-profiling.js \| +0.4% \| +0.2% \| 369.92 KB \| 371.41 KB \| 67.69 KB \| 67.85 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| -0.0% \| 131.08 KB \| 131.08 KB \| 34.83 KB \| 34.83 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 10.81 KB \| 10.81 KB \| 4.1 KB \| 4.1 KB \| NODE_PROD\nreact-dom.development.js \| +0.4% \| +0.3% \| 916.24 KB \| 919.54 KB \| 200.49 KB \| 201.17 KB \| UMD_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 136.87 KB \| 136.87 KB \| 34.99 KB \| 34.99 KB \| UMD_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.3% \| 120.26 KB \| 120.77 KB \| 38.4 KB \| 38.51 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.4% \| +0.3% \| 124.08 KB \| 124.6 KB \| 39.62 KB \| 39.75 KB \| UMD_PROFILING\nreact-dom.development.js \| +0.4% \| +0.3% \| 872.13 KB \| 875.29 KB \| 198.05 KB \| 198.7 KB \| NODE_DEV\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 129.87 KB \| 129.87 KB \| 34.58 KB \| 34.58 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.2% \| 120.41 KB \| 120.92 KB \| 37.6 KB \| 37.69 KB \| NODE_PROD\nReactDOM-prod.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.2% \| 375.84 KB \| 377.33 KB \| 68.41 KB \| 68.58 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| +0.4% \| +0.2% \| 387.53 KB \| 389.02 KB \| 70.57 KB \| 70.72 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 55.87 KB \| 55.87 KB \| 14.47 KB \| 14.47 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.1% \| 10 KB \| 10 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 2.95 KB \| 2.95 KB \| 1.18 KB \| 1.18 KB \| NODE_DEV\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFabric-prod.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.4% \| 251.89 KB \| 253.38 KB \| 43.74 KB \| 43.89 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.6% \| +0.3% \| 263.69 KB \| 265.18 KB \| 46 KB \| 46.16 KB \| RN_OSS_PROFILING\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.4% \| 259.93 KB \| 261.42 KB \| 45.22 KB \| 45.38 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.5% \| +0.3% \| 271.73 KB \| 273.22 KB \| 47.47 KB \| 47.63 KB \| RN_OSS_PROFILING\nReactNativeRenderer-dev.js \| +0.5% \| +0.5% \| 636.77 KB \| 639.93 KB \| 137.92 KB \| 138.6 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.4% \| 260.08 KB \| 261.56 KB \| 45.25 KB \| 45.41 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| +0.5% \| +0.3% \| 271.87 KB \| 273.36 KB \| 47.5 KB \| 47.66 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| +0.5% \| +0.5% \| 616.01 KB \| 619.17 KB \| 133.25 KB \| 133.92 KB \| RN_OSS_DEV\nReactFabric-dev.js \| +0.5% \| +0.5% \| 618.72 KB \| 621.89 KB \| 133.58 KB \| 134.25 KB \| RN_FB_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.4% \| 252.05 KB \| 253.54 KB \| 43.77 KB \| 43.92 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| +0.5% \| +0.5% \| 634.06 KB \| 637.22 KB \| 137.58 KB \| 138.25 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| +0.6% \| +0.3% \| 263.84 KB \| 265.33 KB \| 46.03 KB \| 46.19 KB \| RN_FB_PROFILING\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| +0.5% \| +0.5% \| 637.41 KB \| 640.71 KB \| 133.87 KB \| 134.55 KB \| UMD_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.5% \| 107.01 KB \| 107.53 KB \| 32.35 KB \| 32.52 KB \| UMD_PROD\nreact-art.development.js \| +0.6% \| +0.6% \| 541.46 KB \| 544.62 KB \| 116.29 KB \| 116.96 KB \| NODE_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.7% \| :small_red_triangle:+0.5% \| 71.99 KB \| 72.51 KB \| 21.54 KB \| 21.65 KB \| NODE_PROD\nReactART-dev.js \| +0.6% \| +0.6% \| 547.12 KB \| 550.29 KB \| 115.23 KB \| 115.9 KB \| FB_WWW_DEV\nReactART-prod.js \| :small_red_triangle:+0.7% \| :small_red_triangle:+0.4% \| 226.21 KB \| 227.7 KB \| 38.55 KB \| 38.7 KB \| FB_WWW_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer-shallow.development.js \| 0.0% \| -0.0% \| 38.4 KB \| 38.4 KB \| 9.3 KB \| 9.3 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.92 KB \| 12.92 KB \| 3.94 KB \| 3.94 KB \| UMD_PROD\nReactTestRenderer-dev.js \| +0.6% \| +0.6% \| 555.01 KB \| 558.18 KB \| 117.25 KB \| 117.93 KB \| FB_WWW_DEV\nreact-test-renderer.development.js \| +0.6% \| +0.6% \| 553.96 KB \| 557.25 KB \| 115.38 KB \| 116.07 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.7% \| :small_red_triangle:+0.5% \| 71.3 KB \| 71.82 KB \| 21.72 KB \| 21.84 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.6% \| +0.6% \| 527.93 KB \| 531.09 KB \| 114.07 KB \| 114.72 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.7% \| :small_red_triangle:+0.5% \| 71.11 KB \| 71.63 KB \| 21.37 KB \| 21.49 KB \| NODE_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| +0.5% \| +0.5% \| 579.94 KB \| 583.1 KB \| 122.22 KB \| 122.89 KB \| NODE_DEV\nreact-reconciler-reflection.development.js \| 0.0% \| -0.0% \| 16.25 KB \| 16.25 KB \| 4.97 KB \| 4.96 KB \| NODE_DEV\nreact-reconciler.production.min.js \| :small_red_triangle:+0.7% \| :small_red_triangle:+0.5% \| 76.85 KB \| 77.37 KB \| 22.55 KB \| 22.67 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: -0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 62de1b3b29e7827f99134e6b64a2acee970ed8cf\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: bdc5cc4635f13e5ca43883a9f9587fc9a868c528...62de1b3b29e7827f99134e6b64a2acee970ed8cf</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| +0.4% \| +0.2% \| 414.21 KB \| 415.7 KB \| 75.34 KB \| 75.5 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 135.28 KB \| 135.28 KB \| 34.78 KB \| 34.78 KB \| UMD_DEV\nreact-dom.development.js \| +0.4% \| +0.3% \| 885.77 KB \| 889.07 KB \| 195.25 KB \| 195.91 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 9.99 KB \| 9.99 KB \| 3.36 KB \| 3.36 KB \| NODE_PROD\nreact-dom.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.4% \| 116.06 KB \| 116.58 KB \| 37.19 KB \| 37.35 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.4% \| +0.4% \| 119.77 KB \| 120.29 KB \| 38.41 KB \| 38.57 KB \| UMD_PROFILING\nreact-dom.development.js \| +0.4% \| +0.3% \| 842.95 KB \| 846.1 KB \| 192.81 KB \| 193.48 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.2% \| 116.14 KB \| 116.65 KB \| 36.51 KB \| 36.6 KB \| NODE_PROD\nreact-dom.profiling.min.js \| +0.4% \| +0.4% \| 120 KB \| 120.51 KB \| 37.64 KB \| 37.78 KB \| NODE_PROFILING\nReactDOM-dev.js \| +0.3% \| +0.3% \| 956.92 KB \| 960.09 KB \| 213.58 KB \| 214.26 KB \| FB_WWW_DEV\nReactDOM-prod.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.2% \| 402.44 KB \| 403.93 KB \| 73.08 KB \| 73.24 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nReactDOMTesting-dev.js \| +0.4% \| +0.3% \| 901.73 KB \| 904.9 KB \| 201.51 KB \| 202.17 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.2% \| 383.47 KB \| 384.95 KB \| 69.85 KB \| 70.01 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| -0.0% \| 128.35 KB \| 128.35 KB \| 34.36 KB \| 34.36 KB \| NODE_DEV\nreact-dom-test-utils.development.js \| 0.0% \| -0.0% \| 53.77 KB \| 53.77 KB \| 14 KB \| 14 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| +0.4% \| +0.2% \| 383.47 KB \| 384.95 KB \| 69.85 KB \| 70.01 KB \| FB_WWW_PROFILING\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 10.94 KB \| 10.94 KB \| 4.16 KB \| 4.16 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| -0.0% \| 138.5 KB \| 138.5 KB \| 35.3 KB \| 35.3 KB \| FB_WWW_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 10.79 KB \| 10.79 KB \| 4.09 KB \| 4.09 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| -0.0% \| 58.9 KB \| 58.9 KB \| 14.7 KB \| 14.7 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| -0.0% \| 10.26 KB \| 10.26 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-dev.js \| +0.5% \| +0.5% \| 634.04 KB \| 637.21 KB \| 137.58 KB \| 138.25 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.4% \| 259.92 KB \| 261.41 KB \| 45.21 KB \| 45.38 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.5% \| +0.3% \| 271.71 KB \| 273.2 KB \| 47.47 KB \| 47.62 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.5% \| +0.5% \| 615.99 KB \| 619.16 KB \| 133.24 KB \| 133.92 KB \| RN_OSS_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.4% \| 251.88 KB \| 253.37 KB \| 43.73 KB \| 43.89 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.6% \| +0.3% \| 263.68 KB \| 265.17 KB \| 45.99 KB \| 46.15 KB \| RN_OSS_PROFILING\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| +0.6% \| +0.6% \| 521.35 KB \| 524.5 KB \| 112.55 KB \| 113.22 KB \| NODE_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.8% \| :small_red_triangle:+0.6% \| 69.29 KB \| 69.82 KB \| 20.8 KB \| 20.93 KB \| NODE_PROD\nReactART-dev.js \| +0.6% \| +0.6% \| 575.2 KB \| 578.36 KB \| 120.83 KB \| 121.5 KB \| FB_WWW_DEV\nReactART-prod.js \| :small_red_triangle:+0.6% \| :small_red_triangle:+0.4% \| 235.06 KB \| 236.55 KB \| 39.96 KB \| 40.14 KB \| FB_WWW_PROD\nreact-art.development.js \| +0.5% \| +0.5% \| 616.46 KB \| 619.75 KB \| 130.18 KB \| 130.87 KB \| UMD_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.5% \| 104.26 KB \| 104.77 KB \| 31.62 KB \| 31.78 KB \| UMD_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-test-renderer-shallow.development.js \| 0.0% \| -0.0% \| 38.39 KB \| 38.39 KB \| 9.29 KB \| 9.29 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.91 KB \| 12.91 KB \| 3.93 KB \| 3.93 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.6% \| +0.6% \| 527.91 KB \| 531.06 KB \| 114.06 KB \| 114.71 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.7% \| :small_red_triangle:+0.5% \| 71.09 KB \| 71.61 KB \| 21.35 KB \| 21.47 KB \| NODE_PROD\nReactTestRenderer-dev.js \| +0.6% \| +0.6% \| 555 KB \| 558.17 KB \| 117.24 KB \| 117.93 KB \| FB_WWW_DEV\nreact-test-renderer.development.js \| +0.6% \| +0.6% \| 553.93 KB \| 557.22 KB \| 115.37 KB \| 116.06 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.7% \| :small_red_triangle:+0.5% \| 71.28 KB \| 71.79 KB \| 21.71 KB \| 21.83 KB \| UMD_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| +0.6% \| +0.6% \| 557.5 KB \| 560.65 KB \| 118.02 KB \| 118.69 KB \| NODE_DEV\nreact-reconciler.production.min.js \| :small_red_triangle:+0.7% \| :small_red_triangle:+0.6% \| 73.76 KB \| 74.28 KB \| 21.78 KB \| 21.91 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 62de1b3b29e7827f99134e6b64a2acee970ed8cf\n</p>\n", "Just FYI I pulled this change into my PR to see if it fixed the two failing tests I added recently (a6d4eed). It fixes [this one](https://github.com/facebook/react/blob/a6d4eed534cbbc480577fd52be19d669af679af4/packages/react-reconciler/src/__tests__/useMutableSource-test.internal.js#L812-L843) 👍 \r\n\r\nIt does not fix [this one](https://github.com/facebook/react/blob/a6d4eed534cbbc480577fd52be19d669af679af4/packages/react-reconciler/src/__tests__/useMutableSource-test.internal.js#L1348-L1404), but the reason for that is expected and I'll leave a note on my other PR." ]	2020-03-10 07:33:09	2020-03-11 18:53:46	2020-03-11 18:53:46	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18265', 'html_url': 'https://github.com/facebook/react/pull/18265', 'diff_url': 'https://github.com/facebook/react/pull/18265.diff', 'patch_url': 'https://github.com/facebook/react/pull/18265.patch', 'merged_at': datetime.datetime(2020, 3, 11, 18, 53, 46)}	I suggest hiding whitespace changes when reviewing This fixes a bug with error boundaries. Error boundaries have a notion of "captured" updates that represent errors that are thrown in its subtree during the render phase. These updates are meant to be dropped if the render is aborted. The bug happens when there's a concurrent update (an update from an interleaved event) in between when the error is thrown and when the error boundary does its second pass. The concurrent update is transferred from the pending queue onto the base queue. Usually, at this point the base queue is the same as the current queue. So when we append the pending updates to the work-in-progress queue, it also appends to the current queue. However, in the case of an error boundary's second pass, the base queue has already forked from the current queue; it includes both the "captured" updates and any concurrent updates. In that case, what we need to do is append separately to both queues. Which we weren't doing. That isn't the full story, though. You would expect that this mistake would manifest as dropping the interleaved updates. But instead what was happening is that the "captured" updates, the ones that are meant to be dropped if the render is aborted, were being added to the current queue. The reason is that the `baseQueue` structure is a circular linked list. The motivation for this was to save memory; instead of separate `first` and `last` pointers, you only need to point to `last`. But this approach does not work with structural sharing. So what was happening is that the captured updates were accidentally being added to the current queue because of the circular link. To fix this, I changed the `baseQueue` from a circular linked list to a singly-linked list so that we can take advantage of structural sharing. The "pending" queue, however, remains a circular list because it doesn't need to be persistent. This bug also affects the root fiber, which uses the same update queue implementation and also acts like an error boundary. It does not affect the hook update queue because they do not have any notion of "captured" updates. So I've left it alone for now. However, when we implement resuming, we will have to account for the same issue.	{'url': 'https://api.github.com/repos/facebook/react/issues/18265/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18265/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18264	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18264/labels{/name}	https://api.github.com/repos/facebook/react/issues/18264/comments	https://api.github.com/repos/facebook/react/issues/18264/events	https://github.com/facebook/react/issues/18264	578,384,470	MDU6SXNzdWU1NzgzODQ0NzA=	18,264	[Dependencies] React uses both array-unique and array-uniq	{'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'https://api.github.com/users/ghost/following{/other_user}', 'gists_url': 'https://api.github.com/users/ghost/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ghost/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ghost/subscriptions', 'organizations_url': 'https://api.github.com/users/ghost/orgs', 'repos_url': 'https://api.github.com/users/ghost/repos', 'events_url': 'https://api.github.com/users/ghost/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ghost/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "I'm not sure what you mean, we don't use either of those? https://github.com/facebook/react/blob/master/package.json", "sorry, in yarn.lock\r\n\r\nhttps://github.com/facebook/react/network/dependencies\r\nlook into `Dependencies defined in yarn.lock` section\r\n\r\n![Screenshot (131)](https://user-images.githubusercontent.com/59839368/76313634-5a542a00-62fb-11ea-919a-e0e099f99342.png)\r\n", "We can’t do much about what our dev dependencies pull in. This isn’t really an issue, but thanks for the concern!" ]	2020-03-10 07:23:39	2020-03-10 12:58:27	2020-03-10 12:58:27	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> React version: 16.13.0 ## Steps To Reproduce 1. See https://github.com/facebook/react/issues/18264#issuecomment-597066824 <!-- Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Issues without reproduction steps or code examples may be immediately closed as not actionable. --> <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior These two packages does the same thing. [array-uniq](https://github.com/sindresorhus/array-uniq) is better as it uses Set, while [array-unique](https://github.com/jonschlinkert/array-unique) is last updated years ago. why two packages doing same thing ## The expected behavior Uses either one	{'url': 'https://api.github.com/repos/facebook/react/issues/18264/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18264/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18263	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18263/labels{/name}	https://api.github.com/repos/facebook/react/issues/18263/comments	https://api.github.com/repos/facebook/react/issues/18263/events	https://github.com/facebook/react/issues/18263	578,383,943	MDU6SXNzdWU1NzgzODM5NDM=	18,263	Discussion : Attribute Behavior Fixture Optimization	{'login': 'taejs', 'id': 41318449, 'node_id': 'MDQ6VXNlcjQxMzE4NDQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/41318449?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/taejs', 'html_url': 'https://github.com/taejs', 'followers_url': 'https://api.github.com/users/taejs/followers', 'following_url': 'https://api.github.com/users/taejs/following{/other_user}', 'gists_url': 'https://api.github.com/users/taejs/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/taejs/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/taejs/subscriptions', 'organizations_url': 'https://api.github.com/users/taejs/orgs', 'repos_url': 'https://api.github.com/users/taejs/repos', 'events_url': 'https://api.github.com/users/taejs/events{/privacy}', 'received_events_url': 'https://api.github.com/users/taejs/received_events', 'type': 'User', 'site_admin': False}	[]	closed	false	null	[]	null	[ "This fixture is for internal usage. If you can make it faster that's cool, but it's not a priority for us." ]	2020-03-10 07:22:15	2020-04-01 23:36:29	2020-04-01 23:36:29	NONE	null	null	null	computer spec Intel(R) Core(TM) i5-9600K CPU @ 3.70GHz Microsoft Windows 10 Pro ## The current behavior Attribute Behavior Fixtures is composed of table element When I scroll it, it's frozen for a long time(few minutes or more) ## The expected behavior In my opinion, we need optimization for this. One of solution is using react-window library.	{'url': 'https://api.github.com/repos/facebook/react/issues/18263/reactions', 'total_count': 2, '+1': 0, '-1': 2, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18263/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18262	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18262/labels{/name}	https://api.github.com/repos/facebook/react/issues/18262/comments	https://api.github.com/repos/facebook/react/issues/18262/events	https://github.com/facebook/react/pull/18262	578,365,711	MDExOlB1bGxSZXF1ZXN0Mzg1OTU5OTA0	18,262	RFC Implementation: Speculative work	{'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18262/builds/24462) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit c1c05293f64e433f806bdfabf6efe3770b4f132f:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[kind-sunset-ggixb](https://codesandbox.io/s/kind-sunset-ggixb)\| Configuration \|\n", "There is no doubt that it's interesting. It's a good way to provide reference value through selector and update accurately in a lazy way.\r\n\r\nBut one thing, I think maybe this is not only applicable to Context, maybe we can also make props cooperate with selector? Or with a similar idea, built-in React.memo, so that components can also render accurately?\r\n\r\nAnd about lazy, can we do it in JSX?\r\nsuch as https://babeljs.io/docs/en/babel-plugin-transform-react-constant-elements", "@yisar at the moment selectors for context only work in function components using the useContext hook. users would be free to incorporate props into the selector without limitation much like they can with reducers in useReducer", "This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.\n", "Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!\n" ]	2020-03-10 06:31:08	2020-08-16 07:23:34	2020-08-16 07:23:34	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18262', 'html_url': 'https://github.com/facebook/react/pull/18262', 'diff_url': 'https://github.com/facebook/react/pull/18262.diff', 'patch_url': 'https://github.com/facebook/react/pull/18262.patch', 'merged_at': None}	## Summary This is a long-lived PR to discuss development of an implementation for https://github.com/reactjs/rfcs/pull/150 The current state is a Proof-of-Concept implementation of speculative work along with context-selectors. There are currently four experiments embedded in this PR. some will be removed soon ## selectors for useContext flag `enableContextSelectors` this replaces `readContext` as the implementation for `useContext` and replaces with a stateful mount and update hook which can track previous values. It is not inherently 'faster' by itself since it does not affect context propagation and therefore the selector has no opportunity to bail out of work but when used with `reifyNextWork` or `speculativeWork` it can help reduce the amount of work done on a render for components that only read a small part of the context value what's next: I plan on reimplementing outside of hooks so any context reader can use a selector and take advantage of more aggressive bailouts ## Context propagation by Reader flag `enableContextReaderPropagation` this feature replaces the tree-walking context propagation for one that tracks direct readers. It is analagous to each reader being a `useReducer` hook and having the `dispatchAction` function held by the Provider. propagation is then mostly just dispatching a new state. It's not literally using this functionality and there are some tricks to make it faster on mount and only do the more complicated tracking in advanced cases when the set of contexts read from changes from render to render. The key benefit here is the growth in work time for propagation is O(readers) instead of O(size of tree) what's next: I plan on moving where we track whether we need advanced mode into the prepare step to solve some uncommon memory leaks I plan on experimenting with a super fast mode where we only activate reader tracking after a provider has a changed value at least once. this would enable passive contexts to add no mount or unmount costs ## Reify Next Work flag `enableReifyNextWork` This is the primary feature of Speculative Work. When this flag is enabled the bailoutOnAlreadyCompleted work will be modified so that before deciding whether to go deeper into the subtree the boundary of the next fibers that have work will be visited with a walking algorithm similar to context propagation. when a fiber with work is found and if that fiber type is supported (FunctionComponent for instance) a semi-eager bailout can run which will determine if that speculative update is now reified? (i.e. an update went from "this might need to an update" to "there is no update" or "there is definitely" an update) If reification happens we've hit a work boundary and move on. once we exhaust the sub-tree up to the next work boudary and return back to our bailout we see if there is still any work to do deeper. the rest of the bailout logic remains unchanged this is superior to speculative mode because the tree walking algo is lighter since we aren't doing the full 'work' logic, and because it is simpler in that we don't have to juggle "are we doing work on current or on work in progress" what's next: explore doing a full render call during reifyNextWork and stashing the result. if work is needed we can use the precomputed workInProgress instead of doing it a second time. this is actually 'safe' because we no none of the intermediate work could have affected the render Also look into how we might support class components ## DEPRECATED Speculative Work Mode flag `enableSpeculativeWork` This was my initial implementation of speculative work and it was good but `reifyNextWork` is better. Essentially if we did a bailoutOnAlreadyCompleted work we would not create workInProgress fibers for children but would instead start work on the current tree. Then if we got somewhere where an update on curren required workInProgress we would reify the ancestor current tree back to the last WIP fiber before we started speculative mode and continue from there. This worked and did offer some performance enhancements in some cases but there are a lot of extra edge cases tracking whether you are in speculative mode or not and how to handle switching between those modes This feature is technically compatible with reifyNextWork but doesn't really offer any additional performance advantages and so it should probably be abandoned What's next: remove from codebase	{'url': 'https://api.github.com/repos/facebook/react/issues/18262/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18262/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18261	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18261/labels{/name}	https://api.github.com/repos/facebook/react/issues/18261/comments	https://api.github.com/repos/facebook/react/issues/18261/events	https://github.com/facebook/react/issues/18261	578,340,060	MDU6SXNzdWU1NzgzNDAwNjA=	18,261	Bug:Erro no teste de repositorio	{'login': 'carlosgustavo', 'id': 53797220, 'node_id': 'MDQ6VXNlcjUzNzk3MjIw', 'avatar_url': 'https://avatars.githubusercontent.com/u/53797220?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/carlosgustavo', 'html_url': 'https://github.com/carlosgustavo', 'followers_url': 'https://api.github.com/users/carlosgustavo/followers', 'following_url': 'https://api.github.com/users/carlosgustavo/following{/other_user}', 'gists_url': 'https://api.github.com/users/carlosgustavo/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/carlosgustavo/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/carlosgustavo/subscriptions', 'organizations_url': 'https://api.github.com/users/carlosgustavo/orgs', 'repos_url': 'https://api.github.com/users/carlosgustavo/repos', 'events_url': 'https://api.github.com/users/carlosgustavo/events{/privacy}', 'received_events_url': 'https://api.github.com/users/carlosgustavo/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "@carlosgustavo It would be better if you add more detail to your bug. Can't help without a proper context of your bug.", "Closing, happy to reopen if there’s more information. " ]	2020-03-10 05:06:24	2020-03-10 16:37:42	2020-03-10 16:37:42	NONE	null	null	null	Erros nos componentes do React.js	{'url': 'https://api.github.com/repos/facebook/react/issues/18261/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18261/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18260	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18260/labels{/name}	https://api.github.com/repos/facebook/react/issues/18260/comments	https://api.github.com/repos/facebook/react/issues/18260/events	https://github.com/facebook/react/pull/18260	578,335,401	MDExOlB1bGxSZXF1ZXN0Mzg1OTM1ODc5	18,260	[Flight] Split Streaming from Relay Implemenation	{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18260/builds/14052) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b9062354cc480296d31871ccd24e8610241ce6b0:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[sad-wing-x276n](https://codesandbox.io/s/sad-wing-x276n)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: bdc5cc4635f13e5ca43883a9f9587fc9a868c528...b9062354cc480296d31871ccd24e8610241ce6b0</p>\n\n\n \n## react-flight-dom-relay\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFlightDOMRelayServer-dev.js \| +1.0% \| -7.2% \| 7.85 KB \| 7.93 KB \| 2.56 KB \| 2.38 KB \| FB_WWW_DEV\nReactFlightDOMRelayServer-prod.js \| :small_red_triangle:+14.6% \| :small_red_triangle:+7.8% \| 4.96 KB \| 5.68 KB \| 1.54 KB \| 1.66 KB \| FB_WWW_PROD\nReactFlightDOMRelayClient-dev.js \| -10.1% \| -11.6% \| 5.41 KB \| 4.87 KB \| 1.75 KB \| 1.54 KB \| FB_WWW_DEV\nReactFlightDOMRelayClient-prod.js \| -26.5% \| -18.2% \| 4.02 KB \| 2.96 KB \| 1.29 KB \| 1.05 KB \| FB_WWW_PROD\n\n## react-flight-dom-webpack\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-flight-dom-webpack-server.browser.development.js \| -5.2% \| -8.7% \| 8.31 KB \| 7.87 KB \| 2.69 KB \| 2.45 KB \| NODE_DEV\nreact-flight-dom-webpack-server.browser.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.8% \| 2.59 KB \| 2.6 KB \| 1.22 KB \| 1.23 KB \| NODE_PROD\nreact-flight-dom-webpack.development.js \| +2.2% \| +0.9% \| 8.55 KB \| 8.74 KB \| 2.36 KB \| 2.38 KB \| UMD_DEV\nreact-flight-dom-webpack.production.min.js \| :small_red_triangle:+1.0% \| -0.2% \| 2.85 KB \| 2.88 KB \| 1.32 KB \| 1.32 KB \| UMD_PROD\nreact-flight-dom-webpack.development.js \| +2.3% \| +0.6% \| 7.81 KB \| 7.99 KB \| 2.26 KB \| 2.27 KB \| NODE_DEV\nreact-flight-dom-webpack.production.min.js \| :small_red_triangle:+1.1% \| :small_red_triangle:+0.2% \| 2.67 KB \| 2.7 KB \| 1.23 KB \| 1.24 KB \| NODE_PROD\nreact-flight-dom-webpack-server.node.development.js \| -4.7% \| -7.9% \| 9.25 KB \| 8.81 KB \| 2.96 KB \| 2.72 KB \| NODE_DEV\nreact-flight-dom-webpack-server.node.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.4% \| 2.75 KB \| 2.76 KB \| 1.24 KB \| 1.24 KB \| NODE_PROD\nreact-flight-dom-webpack-server.browser.development.js \| -5.4% \| -8.7% \| 9.13 KB \| 8.63 KB \| 2.81 KB \| 2.56 KB \| UMD_DEV\nreact-flight-dom-webpack-server.browser.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.6% \| 2.81 KB \| 2.82 KB \| 1.31 KB \| 1.32 KB \| UMD_PROD\n\n## react-server\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-server-flight.production.min.js \| :small_red_triangle:+1.4% \| :small_red_triangle:+1.7% \| 2.78 KB \| 2.82 KB \| 1.25 KB \| 1.27 KB \| NODE_PROD\nreact-server-flight.development.js \| -4.2% \| -8.4% \| 9.15 KB \| 8.77 KB \| 2.79 KB \| 2.55 KB \| NODE_DEV\nreact-server.development.js \| 0.0% \| +0.1% \| 3.68 KB \| 3.68 KB \| 1.23 KB \| 1.23 KB \| NODE_DEV\nreact-server.production.min.js \| 0.0% \| :small_red_triangle:+0.3% \| 1.14 KB \| 1.14 KB \| 634 B \| 636 B \| NODE_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b9062354cc480296d31871ccd24e8610241ce6b0\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: bdc5cc4635f13e5ca43883a9f9587fc9a868c528...b9062354cc480296d31871ccd24e8610241ce6b0</p>\n\n\n \n## react-flight-dom-relay\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFlightDOMRelayClient-dev.js \| -10.1% \| -11.6% \| 5.41 KB \| 4.87 KB \| 1.75 KB \| 1.54 KB \| FB_WWW_DEV\nReactFlightDOMRelayClient-prod.js \| -26.5% \| -18.2% \| 4.02 KB \| 2.96 KB \| 1.29 KB \| 1.05 KB \| FB_WWW_PROD\nReactFlightDOMRelayServer-dev.js \| +1.0% \| -7.2% \| 7.85 KB \| 7.93 KB \| 2.56 KB \| 2.38 KB \| FB_WWW_DEV\nReactFlightDOMRelayServer-prod.js \| :small_red_triangle:+14.6% \| :small_red_triangle:+7.8% \| 4.96 KB \| 5.68 KB \| 1.54 KB \| 1.66 KB \| FB_WWW_PROD\n\n## react-flight-dom-webpack\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-flight-dom-webpack-server.node.development.js \| -4.7% \| -7.9% \| 9.26 KB \| 8.83 KB \| 2.96 KB \| 2.73 KB \| NODE_DEV\nreact-flight-dom-webpack-server.node.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.4% \| 2.76 KB \| 2.77 KB \| 1.25 KB \| 1.25 KB \| NODE_PROD\nreact-flight-dom-webpack-server.browser.development.js \| -5.4% \| -8.6% \| 9.14 KB \| 8.64 KB \| 2.81 KB \| 2.57 KB \| UMD_DEV\nreact-flight-dom-webpack-server.browser.production.min.js \| :small_red_triangle:+0.4% \| :small_red_triangle:+0.6% \| 2.82 KB \| 2.83 KB \| 1.32 KB \| 1.32 KB \| UMD_PROD\nreact-flight-dom-webpack-server.browser.development.js \| -5.2% \| -8.7% \| 8.32 KB \| 7.88 KB \| 2.69 KB \| 2.46 KB \| NODE_DEV\nreact-flight-dom-webpack-server.browser.production.min.js \| :small_red_triangle:+0.5% \| :small_red_triangle:+0.8% \| 2.6 KB \| 2.61 KB \| 1.23 KB \| 1.24 KB \| NODE_PROD\nreact-flight-dom-webpack.development.js \| +2.2% \| +0.9% \| 8.57 KB \| 8.76 KB \| 2.37 KB \| 2.39 KB \| UMD_DEV\nreact-flight-dom-webpack.production.min.js \| :small_red_triangle:+1.0% \| -0.2% \| 2.86 KB \| 2.89 KB \| 1.33 KB \| 1.33 KB \| UMD_PROD\nreact-flight-dom-webpack.development.js \| +2.3% \| +0.6% \| 7.82 KB \| 8 KB \| 2.27 KB \| 2.28 KB \| NODE_DEV\nreact-flight-dom-webpack.production.min.js \| :small_red_triangle:+1.1% \| :small_red_triangle:+0.4% \| 2.68 KB \| 2.71 KB \| 1.24 KB \| 1.25 KB \| NODE_PROD\n\n## react-server\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-server-flight.development.js \| -4.2% \| -8.4% \| 9.17 KB \| 8.78 KB \| 2.79 KB \| 2.56 KB \| NODE_DEV\nreact-server-flight.production.min.js \| :small_red_triangle:+1.4% \| :small_red_triangle:+1.7% \| 2.8 KB \| 2.84 KB \| 1.26 KB \| 1.28 KB \| NODE_PROD\nreact-server.development.js \| 0.0% \| +0.1% \| 3.69 KB \| 3.69 KB \| 1.24 KB \| 1.24 KB \| NODE_DEV\nreact-server.production.min.js \| 0.0% \| :small_red_triangle:+0.3% \| 1.15 KB \| 1.15 KB \| 642 B \| 644 B \| NODE_PROD\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b9062354cc480296d31871ccd24e8610241ce6b0\n</p>\n", "> The API for the server is: \r\n> `function render(model: ReactModel, destination: Destination): void;`\r\n> The first argument is something that can be returned from a Block. I.e. the root model\r\n\r\nTo clarify, this is the result of calling a Block's load function, right? So it's the curried Block Query function plus its arguments.", "> To clarify, this is the result of calling a Block's load function, right? So it's the curried Block Query function plus its arguments.\r\n\r\nYea, that's correct. We still need a name for that. 😂", "> We still need a name for that.\r\n\r\nThunk? ", "Sorry for multiple rounds of questions, but who calls the client methods like `resolveModel`? Is that all orchestrated by Flight?", "@josephsavona No. Relay calls resolveModel and resolveError when it receives that \"chunk\" from the server. So you encode model and error however you want on the server and then parse it on the client and feed it back into Flight.\r\n\r\nID = 0 is special. It's the root and is always emitted first. So you could for example inline that in the response and then stream in the rest.", "Ah got it, so inverse of the server. Cool cool." ]	2020-03-10 04:50:17	2020-03-10 22:08:49	2020-03-10 21:55:05	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18260', 'html_url': 'https://github.com/facebook/react/pull/18260', 'diff_url': 'https://github.com/facebook/react/pull/18260.diff', 'patch_url': 'https://github.com/facebook/react/pull/18260.patch', 'merged_at': datetime.datetime(2020, 3, 10, 21, 55, 5)}	This splits the Flight implementation into a general JSON chunk part and a streaming part. The default implementation goes to a binary/string stream API which varies between Node and W3C streams. The Relay implementation by-passes the serialization and instead gets passed JSON-serializable object chunks. The server configs are layered like this: - ReactFlightServer - ReactFlightServerConfig - ReactFlightServerConfigStream - ReactServerStreamConfig - ReactServerStreamConfigNode - ReactServerStreamConfigBrowser - ReactFlightDOMRelayServerHostConfig The client is a bit simpler. The implementation just imports ReactFlightClient (used by Relay) or ReactFlightClientStream (used by Streams). ## Flight Relay Server Bindings The API for the server is: ``` function render(model: ReactModel, destination: Destination): void; ``` The first argument is something that can be returned from a Block. I.e. the root model. Something JSONable. This will change to require a Block. The second argument is whatever Relay wants to the target to be. This also depends on an external file that we'll have to add to www: `ReactFlightDOMRelayServerIntegration.js`. This will needs to implement the following API: ``` opaque type Destination; function emitModel( destination: Destination, id: number, json: JSONValue, ): void; function emitError( destination: Destination, id: number, message: string, stack: string, ): void; function close(destination: Destination): void; ``` This will be called asynchronously as ReactFlight completes part of the model. Once there's no more to render, it'll call `close()` on the destination. Relay can then serialize these rows as it wants. ## Flight Relay Client Bindings The client API is: ``` function createResponse(): Response; function getModelRoot<T>(response: Response): {model: T}; function resolveModel( response: Response, id: number, json: JSONValue, ): void; function resolveError( response: Response, id: number, message: string, stack: string, ): void; function close(response: Response): void; ``` To use this, you first have to create a "response". You can get a model out of the response which will just have placeholders in it. This particular API will change as I get rid of "proxies". It’ll return a Block instead. The principle is that it can return something even before any data has loaded so you immediately get something that can suspend. The resolveModel and resolveError are called as new rows stream in. `close` should be called when there's no more rows or the connection dies (even if it dies early).	{'url': 'https://api.github.com/repos/facebook/react/issues/18260/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1}	https://api.github.com/repos/facebook/react/issues/18260/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18259	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18259/labels{/name}	https://api.github.com/repos/facebook/react/issues/18259/comments	https://api.github.com/repos/facebook/react/issues/18259/events	https://github.com/facebook/react/issues/18259	578,287,011	MDU6SXNzdWU1NzgyODcwMTE=	18,259	Bug: React Fast Refresh only updates DOM of web pages with a http:// location.protocol	{'login': 'wis', 'id': 9993663, 'node_id': 'MDQ6VXNlcjk5OTM2NjM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9993663?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wis', 'html_url': 'https://github.com/wis', 'followers_url': 'https://api.github.com/users/wis/followers', 'following_url': 'https://api.github.com/users/wis/following{/other_user}', 'gists_url': 'https://api.github.com/users/wis/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/wis/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/wis/subscriptions', 'organizations_url': 'https://api.github.com/users/wis/orgs', 'repos_url': 'https://api.github.com/users/wis/repos', 'events_url': 'https://api.github.com/users/wis/events{/privacy}', 'received_events_url': 'https://api.github.com/users/wis/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "Thanks for the information. To be honest this is quite a complicated setup to reproduce an issue. Any chance you might want to dig into the code yourself to figure out why it's not updating. I'd be happy to give pointers.", "This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!\n" ]	2020-03-10 01:56:57	2020-06-26 04:00:54	2020-06-26 04:00:54	NONE	null	null	null	after quite a bit of debugging of Parcel 2's [`hmr-runtime.js`](https://github.com/wis/parcel/blob/bb8ae0a5d81d8fd31ba8a677a7e69fda2c65ab06/packages/runtimes/hmr/src/loaders/hmr-runtime.js) (from the web page that it gets injected by the bundler and loaded into), I see that the changed modules/components are received and updated but on React's part, it's not updating the DOM, that's why I'm opening this issue here and not in [parcel-bundler/parcel](https://github.com/parcel-bundler/parcel). React version: ```json "dependencies": { "react": "^16.13.0", "react-dom": "^16.13.0" }, ``` ## Steps To Reproduce & Link to code example: to use React Fast Refresh, with web pages that have a `file://`, we'll use Parcel 2's implementation, 1. clone yet to be up-streamed Parcel 2 from [wis/parcel](https://github.com/wis/parcel), which supports watch mode only HMR + React Fast Refresh. you only need to run `yarn install` and that's it, to use its CLI use `./packages/core/parcel/src/bin.js` 2. clone [wis/SWEB-react](https://github.com/wis/SWEB-react) - yarn install - update the path to the CLI in the `bin` script of scripts in package.json with the path to the cloned Parcel repo in step 1. - yarn start 3. open the compiled HTML files in the browser from disk, URL should look like `file:///home/x/dev/SWEB-react/build/pages/options.html` or `chorme-extension://<UUID>/options.html` 4. change a top level Component like `Options`, a full page refresh occurs, which I believe was designed to happen, but try changing a child/nested component like `Componentx`, the DOM doesn't update. ## The current behavior only full page refresh is working for top level components like `Options` and `Popup`, React Fast Refresh works for nested components, e.g `Componentx`, only when the web page is served form with a server (with the `serve` command) and has an `http://` URL scheme, and not when the web page is that's of an opened HTML file from disk with a `file://` URL scheme or of a browser extension with a `moz-extension://` or `chorme-extension://` URL scheme (that's built with the `watch` command), the bundler, Parcel 2, loads the updated modules/components and [clears the console](https://github.com/wis/parcel/blob/bb8ae0a5d81d8fd31ba8a677a7e69fda2c65ab06/packages/runtimes/hmr/src/loaders/hmr-runtime.js#L60) but the components don't get updated. ## The expected behavior the DOM updates after the changed components/modules get updated by the bundler runtime.	{'url': 'https://api.github.com/repos/facebook/react/issues/18259/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18259/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18258	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18258/labels{/name}	https://api.github.com/repos/facebook/react/issues/18258/comments	https://api.github.com/repos/facebook/react/issues/18258/events	https://github.com/facebook/react/issues/18258	578,146,174	MDU6SXNzdWU1NzgxNDYxNzQ=	18,258	Bug: renderToStaticMarkup throw warning about SVG PascalCase and camelCase naming	{'login': 'BiosBoy', 'id': 30953392, 'node_id': 'MDQ6VXNlcjMwOTUzMzky', 'avatar_url': 'https://avatars.githubusercontent.com/u/30953392?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BiosBoy', 'html_url': 'https://github.com/BiosBoy', 'followers_url': 'https://api.github.com/users/BiosBoy/followers', 'following_url': 'https://api.github.com/users/BiosBoy/following{/other_user}', 'gists_url': 'https://api.github.com/users/BiosBoy/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/BiosBoy/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/BiosBoy/subscriptions', 'organizations_url': 'https://api.github.com/users/BiosBoy/orgs', 'repos_url': 'https://api.github.com/users/BiosBoy/repos', 'events_url': 'https://api.github.com/users/BiosBoy/events{/privacy}', 'received_events_url': 'https://api.github.com/users/BiosBoy/received_events', 'type': 'User', 'site_admin': False}	[{'id': 126382236, 'node_id': 'MDU6TGFiZWwxMjYzODIyMzY=', 'url': 'https://api.github.com/repos/facebook/react/labels/SVG', 'name': 'SVG', 'color': 'f7c6c7', 'default': False, 'description': None} {'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "could you make a codesanbox version or a git repo that demonstrates this issue? ", "@threepointone hi! \r\n\r\nHere you go [https://codesandbox.io/s/reactsvgtestapp-sh7b](https://codesandbox.io/s/reactsvgtestapp-sh7bs). \r\n\r\nWell, it works in a bit different way on codesandbox, but the error can be spotted anyway. Just on the page load please open the console directly in the browser (instead integrated one) and reload the page. \r\n\r\nSo you will found the error about inconsistent SVG nodes naming on the first render like on the screenshot below: [https://imgur.com/a/C9MpF3Y](https://imgur.com/a/C9MpF3Y). The funny think on the codesandbox it disappears on the second rerender, which doesn't make a trick inside my project.\r\n\r\nThanks.", "So that console error thrown when we try to insert the `< linearGradient />` or `< feDropShadow />` or so on tag not in the `<svg />` directly, but in inside one of the deepens of its tree nodes. Like:\r\n```\r\n const shadow = (\r\n <feDropShadow {...} />\r\n ) \r\n\r\n const testFilter = (\r\n <filter {...}>\r\n {shadow}\r\n <filter />\r\n )\r\n\r\n document.querySelector('.svg > defs') += renderToStaticMarkup(testFilter) // error in the console!\r\n```", "I had a quick look at this one, and as far as I can tell the error is being thrown because [getIntrinsicNamespace()](https://github.com/facebook/react/blob/0705b7282f9c52ce85b6125ebbe32f6a6abf01a4/packages/react-dom/src/shared/DOMNamespaces.js#L19) tests specifically for an `<svg>` tag at the top level, so an orphaned `<linearGradient>` (or any other camelCase SVG child) is assumed to be in the HTML namespace. Because it's assumed to be in the HTML namespace, it fails the naming convention test for HTML elements, hence the error.\r\n\r\nThe test could be expanded to cover the 32 valid SVG child tags that have camelCase names, which would make `getIntrinsicNamespace` ~653 bytes longer, but that would also result in lowercase SVG children, hyphenated children, and camelCase children all going through slightly different code paths for validation. \r\n\r\nI'm still new around here so I'm not sure what the general policy is on balancing edge cases vs. library size vs. consistency so let me know.", "Any updates yet? :(", "This is currently unsupported. SVG is its own spec with [its own DOM](https://www.w3.org/TR/SVG11/svgdom.html). Lumping its SVG DOM elements with HTML DOM elements is problematic in a number of ways. \r\n\r\nA workaround would be to wrap your element in `<svg>` and then extract it from the output. Hope that helps!", "Hmm, let me check this possibility...", "Going to close this because it's unsupported, but if the workaround works, do please share here :)", "> A workaround would be to wrap your element in <svg> and then extract it from the output. Hope that helps!\r\n\r\nSeems like this is a truly workaround for now. Worked for me!" ]	2020-03-09 19:40:32	2020-11-11 08:33:11	2020-07-22 12:22:24	NONE	null	null	null	React version: 16.12.0 Error: `Warning: <linearGradient /> is using incorrect casing. Use PascalCase for React components, or lowercase for HTML elements.` ## The current behavior Any `SVG`-inside node(`LinearGradient`, `feDropShadow`, etc), that should be in PascalCase/camelCase inside HTML indeed, throw me a warning above through React's `import { renderToStaticMarkup } from 'react-dom/server'` `renderToStaticMarkup` method. I use renderToStaticMarkup to parse and then insert its DOM inside global HTML (don't ask me why :) ) on client-side, not SSR. ## The expected behavior Should not throw any warnings and render SVG-in tags in PascalCase without any efforts and tears in fact. Thanks. P.S. I saw this report, but it seems like it doesn't fix for some reason https://github.com/facebook/react/issues/10415 ...	{'url': 'https://api.github.com/repos/facebook/react/issues/18258/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18258/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18257	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18257/labels{/name}	https://api.github.com/repos/facebook/react/issues/18257/comments	https://api.github.com/repos/facebook/react/issues/18257/events	https://github.com/facebook/react/pull/18257	578,102,674	MDExOlB1bGxSZXF1ZXN0Mzg1NzQ1NDk3	18,257	feat(devtools): Allow editing of context value in Consumer	{'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18257/builds/13986) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 1e301d0b80c69cab603a7738ea8e7577d4719eaf:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[frosty-surf-b44j9](https://codesandbox.io/s/frosty-surf-b44j9)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1e301d0b80c69cab603a7738ea8e7577d4719eaf\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1e301d0b80c69cab603a7738ea8e7577d4719eaf\n</p>\n", "> I think maybe it should offer a \"link\" to jump to the appropriate Provider.\r\n\r\nYep, I was thinking this as well. Happy to abandon this one in favor of a \"jump to provider\" feature combined with #18255\r\n\r\n> Although at that point you might as well just edit the appropriate state?\r\n\r\nYou mean like\r\n\r\n```jsx\r\nfunction App() {\r\n const [state] = React.useState({ color: 2 }); // <--- edit this hook instead?\r\n return <Context.Provider value={value} />\r\n}\r\n```\r\nIt's not always obvious where the value of a provider comes from. Could be a memo or useState or useReducer hook. I think editing the value directly is more straight forward.", "But I do feel like that being able to edit context in the context of the component is still important (useContext) here. Otherwise it's not easy to jump between the component props and the context for that particular component.", "This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.\n", "bump", "This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.\n", "Abandoning. Context.Consumer isn't that important. `useContext` would be more helpful but is more complicate last I looked." ]	2020-03-09 18:23:43	2020-10-04 07:44:32	2020-10-04 07:44:28	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18257', 'html_url': 'https://github.com/facebook/react/pull/18257', 'diff_url': 'https://github.com/facebook/react/pull/18257.diff', 'patch_url': 'https://github.com/facebook/react/pull/18257.patch', 'merged_at': None}	Review on per-commit basis advised ## Summary Allow editing of the context value from a consumer if the value comes from a Provider component. ## Test Plan Verified locally by using react-devtools-shell: `master`: ![devools-context-consumer-master](https://user-images.githubusercontent.com/12292047/76244932-519c1f00-623b-11ea-9b05-f4e2260913a4.gif) `pr`: ![devools-context-consumer-pr](https://user-images.githubusercontent.com/12292047/76244935-52cd4c00-623b-11ea-8e80-9d37f35e2b09.gif)	{'url': 'https://api.github.com/repos/facebook/react/issues/18257/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18257/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18256	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18256/labels{/name}	https://api.github.com/repos/facebook/react/issues/18256/comments	https://api.github.com/repos/facebook/react/issues/18256/events	https://github.com/facebook/react/issues/18256	578,077,772	MDU6SXNzdWU1NzgwNzc3NzI=	18,256	Error: "Cannot read property 'concat' of undefined"	{'login': 'byronanderson', 'id': 378721, 'node_id': 'MDQ6VXNlcjM3ODcyMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/378721?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/byronanderson', 'html_url': 'https://github.com/byronanderson', 'followers_url': 'https://api.github.com/users/byronanderson/followers', 'following_url': 'https://api.github.com/users/byronanderson/following{/other_user}', 'gists_url': 'https://api.github.com/users/byronanderson/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/byronanderson/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/byronanderson/subscriptions', 'organizations_url': 'https://api.github.com/users/byronanderson/orgs', 'repos_url': 'https://api.github.com/users/byronanderson/repos', 'events_url': 'https://api.github.com/users/byronanderson/events{/privacy}', 'received_events_url': 'https://api.github.com/users/byronanderson/received_events', 'type': 'User', 'site_admin': False}	[{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None} {'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None} {'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Needs%20Investigation', 'name': 'Type: Needs Investigation', 'color': '65AA9C', 'default': False, 'description': ''}]	closed	false	{'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}]	null	[ "Any chance this is reproducible, @byronanderson?\r\n\r\n(And if so, any chance you could share steps for us to trigger it?)", "Nope, I had tried at the time, and tried again just now, but it won't happen again w/ the same steps.\r\n\r\nI _can_ say that the CPU was getting hammered by frequent large react rerenders due to the a redux selector returning a new object without proper memoization, if that tells you anything.\r\n\r\nThe only reason I even opened the issue was that the issue template was shown to me w/ the crash, so if this minified stack trace means nothing to you, I won't be offended by closing it.", "The simplest way to fix this is to bind the function, I suggest that you bind the function in the constructor, like so\r\nclass MonthsTable extends Component {\r\n constructor(props, context){\r\n super(props, context);\r\n this.handleChangeOnMonth = this.handleChangeOnMonth.bind(this);\r\n }\r\n handleChangeOnMonth(e){ \r\n this.props.setMonth(e.target.id, e.target.value);\r\n }\r\n render(){\r\n return (<form>\r\n {this.props.months.map((e, i) =>\r\n <input\r\n type='number'\r\n id={i} \r\n key={i} \r\n value={this.props.months[i]}\r\n onChange={this.handleChangeOnMonth} />)}\r\n </form>)\r\n }\r\n}", "I assume this error is in [`CommitTreeBuilder`](https://github.com/facebook/react/blob/master/packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js) because it's the only place in Profiler code that calls `.concat()` that I see:\r\nhttps://github.com/facebook/react/blob/5aa967b69b255ede89c03dda8cd617b61c492cdb/packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js#L240-L241\r\n\r\nIn particular, the problem would happen if `getClonedNode` failed to find a matching node for the parent:\r\nhttps://github.com/facebook/react/blob/5aa967b69b255ede89c03dda8cd617b61c492cdb/packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js#L154-L162\r\n\r\nThis isn't an expected case, so I'm not sure what went wrong here. Being able to repro this woudl be very helpful.", "By the way, yesterday's release (v4.7) fixed several potential Profiler bugs. Maybe it also fixed this one. Were you able to repro this issue before? If so can you try with the latest/current DevTools?", "Sample data set from #19137 that reproduces this bug.\r\n\r\n[profiling-data.06-16-2020.18-42-16.zip](https://github.com/facebook/react/files/4787942/profiling-data.06-16-2020.18-42-16.zip)\r\n\r\nThe more interesting thing is to figure out how the data gets corrupted in the first place though which will require a repro.", "I encountered the same error and I think I have a repro:\r\n\r\n1. Open React Devtools Profiler\r\n2. Select Hide components where type equals suspense \r\n3. Click on Reload and start profiling\r\n4. Click on a commit bar\r\n\r\nDevTools version: 4.8.2-fed4ae024", "@IDrissAitHafid Can you share your repro as a Code Sandbox app with instructions on how to run?", "Okay, I'll see if I can do it!", "@bvaughn can you see if you can reproduce it using this [Code Sandbox app](https://codesandbox.io/s/repro-of-error-cannot-read-property-concat-of-undefined-18256-kdbq9)?\r\n\r\nWhat I did was:\r\n1. export and run this app.\r\n2. Open React Devtools Profiler\r\n3. Select Hide components where type equals suspense\r\n4. Click on Reload and start profiling\r\n5. Click on the second commit bar\r\n", "Nice repro! Thanks" ]	2020-03-09 17:40:03	2020-10-13 17:38:59	2020-10-13 17:38:59	NONE	null	null	null	Describe what you were doing when the bug occurred: 1. I was using the devtools to investigate some performance issues w/ an app I help maintain 2. I had just turned on the "Record why each component rendered while profiling" checkbox 3. I ran a profile while navigating on the underlying page The react profiler tab in the devtools gave this error, I think as I clicked the record icon to stop recording the profile. --------------------------------------------- Please do not remove the text below this line --------------------------------------------- DevTools version: 4.5.0-355970aa4 Call stack: at N (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:160881) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:160015) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:159939) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:159939) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:159939) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:159939) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:159939) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:159939) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:159939) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:159939) Component stack: in ec in div in div in div in So in Unknown in n in Unknown in div in div in rl in Ze in fn in Ga in _s	{'url': 'https://api.github.com/repos/facebook/react/issues/18256/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18256/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18255	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18255/labels{/name}	https://api.github.com/repos/facebook/react/issues/18255/comments	https://api.github.com/repos/facebook/react/issues/18255/events	https://github.com/facebook/react/pull/18255	578,024,739	MDExOlB1bGxSZXF1ZXN0Mzg1NjgxNzg5	18,255	feat(devtools): Allow editing context value in Provider	{'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	{'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}	[{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_url': 'https://api.github.com/users/bvaughn/following{/other_user}', 'gists_url': 'https://api.github.com/users/bvaughn/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bvaughn/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bvaughn/subscriptions', 'organizations_url': 'https://api.github.com/users/bvaughn/orgs', 'repos_url': 'https://api.github.com/users/bvaughn/repos', 'events_url': 'https://api.github.com/users/bvaughn/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bvaughn/received_events', 'type': 'User', 'site_admin': False}]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18255/builds/13967) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b66f1835c5fdda99fd7ab5c8bf5f139e6190f6d4:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[falling-shadow-ifpqp](https://codesandbox.io/s/falling-shadow-ifpqp)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b66f1835c5fdda99fd7ab5c8bf5f139e6190f6d4\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b66f1835c5fdda99fd7ab5c8bf5f139e6190f6d4\n</p>\n", "Can we add some tests for this?", "> Can we add some tests for this?\r\n\r\nI'd love to but it wasn't clear to me where and how. In previous efforts to work on devtools no tests for the frontend were added: https://github.com/facebook/react/pull/18070/files", "This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.\n", "bump", "@rachelnabors brought this to my attention, and I will be happy to review it– after #19774 lands. (I can handle the conflicts in this PR myself if necessary.)", "> (I can handle the conflicts in this PR myself if necessary.)\r\n\r\nDoes it make sense to rebase this PR on your branch at this point? Otherwise I can take care of tending to this PR after #19774 lands if I notice merge conflicts.", "Up to you. I'll likely rebase my branch at least once more after I resolve the last outstanding issue or two. After that, it's up to you if you feel up for handling the merge conflicts or handing them off to me. :smile:", "#19774 was just merged. Would you like to fix the conflict in `SelectedElement` @eps1lon? Or would you like me to? (Happy either way.)", "I'll take a look.", "Looks like the code has completely changed. Would take me a bit longer (over the next week) so if you want to get this in earlier it's probably best if you rebase this PR.", "No worries. I can take a look this afternoon.", "Ah, so to clarify: Editing the context value of a modern context Provider works in master now already.\r\n\r\nEditing the context value of a Consumer works in some cases, but not all:\r\n* You can edit class consumers that use the legacy `contextTypes` API.\r\n* You can edit class consumers that use the more recent `contextType` API.\r\n* You can not edit modern `<Context.Consumer>` values. (This would require changes on the backend to support– we'd want to follow the pattern used for editing function component props and inject a new renderer method, and I don't think that's worth it).\r\n\r\nGoing to close this PR down since it no longer seems to be required. :smile: Thanks!", "> Editing the context value of a modern context Provider works in master now already.\r\n\r\nAwesome, thanks!" ]	2020-03-09 16:15:55	2020-09-21 17:07:21	2020-09-21 16:51:58	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18255', 'html_url': 'https://github.com/facebook/react/pull/18255', 'diff_url': 'https://github.com/facebook/react/pull/18255.diff', 'patch_url': 'https://github.com/facebook/react/pull/18255.patch', 'merged_at': None}	## Summary Allow editing of context values for modern context types. ## Test Plan Verified locally using packages/react-devtools-shell. master: ![devools-context-master](https://user-images.githubusercontent.com/12292047/76234375-f1e94800-6229-11ea-8048-9bbf50c270bc.gif) pr: ![devools-context-pr](https://user-images.githubusercontent.com/12292047/76234391-f4e43880-6229-11ea-8caf-c0cd1463ffe8.gif)	{'url': 'https://api.github.com/repos/facebook/react/issues/18255/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18255/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18254	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18254/labels{/name}	https://api.github.com/repos/facebook/react/issues/18254/comments	https://api.github.com/repos/facebook/react/issues/18254/events	https://github.com/facebook/react/issues/18254	577,988,591	MDU6SXNzdWU1Nzc5ODg1OTE=	18,254	Bug: using hooks inside a named forwardRef callback causes a lint error	{'login': 'hovsater', 'id': 503025, 'node_id': 'MDQ6VXNlcjUwMzAyNQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/503025?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hovsater', 'html_url': 'https://github.com/hovsater', 'followers_url': 'https://api.github.com/users/hovsater/followers', 'following_url': 'https://api.github.com/users/hovsater/following{/other_user}', 'gists_url': 'https://api.github.com/users/hovsater/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hovsater/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hovsater/subscriptions', 'organizations_url': 'https://api.github.com/users/hovsater/orgs', 'repos_url': 'https://api.github.com/users/hovsater/repos', 'events_url': 'https://api.github.com/users/hovsater/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hovsater/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "This is to enforce a convention, and to be clear, that that function is a component definition. This means that it’ll show up in react dev tools with that name, etc. It’ll still work if you don’t capitalise it, but the intent is clearer when it’s visually identifiable as a component. That’s why we enforce it as a lint rule. Hope this clarifies things!", "@threepointone thanks for the quick reply! Appreciate it! 🙂 \r\n\r\nAccording to [previous discussions](https://github.com/facebook/react/pull/12644), the inner function (the callback) isn't a component definition but a render function. @gaearon mention it [here](https://github.com/facebook/react/pull/12644#issuecomment-392798686) for instance.\r\n\r\nAs I understand it the returned value from `forwardRef` is a component though but perhaps it doesn't make a difference in this case?\r\n\r\n", "Would it help if the linter would explain that function components and forwardRef render functions need to have a capitalized name? \r\n\r\nI think you shouldn't call it just a \"render function\" because that might imply (for historic reasons) that you can call it yourself (e.g. inside a loop) which would break if you'd use hooks inside it. But a component might also be misleading because you can't pass it to `createElement`.", "@eps1lon I think that would be a step in the right direction. Right now, it's confusing since `function () {}`, `function renderComponent() {}` and `function RenderComponent() {}` are legal but the linter only allow for the first and last one.\r\n\r\nSo if the linter would say \"The render function to forwardRef must be capitalised or anonymous\" instead of saying that hooks are illegal it's an improvement.", "Up to the core team in the end but I think I'd hope they welcome a PR that refines the error message if this is an immediate argument of `React.forwardRef`. This should cover most cases.", "Yeah, I'd be happy to help out if it's of interest. 🙁 ", "Oh hmm yeah. Lemme think about this some more." ]	2020-03-09 15:24:15	2020-03-10 10:37:09	2020-03-09 22:03:50	NONE	null	null	null	My understanding is that hooks are allowed within the render function passed to `React.forwardRef`. But the Eslint rule, `react-hooks/rules-of-hooks`, is displeased with the following code: ```jsx const Component = forwardRef(function renderComponent(props, ref) { useSomeHook(); return <SomeComponent {...props} ref={ref} />; }); ``` However, removing the name of the callback function or capitalising the first letter, e.g., `RenderComponent `, causes the linter to stay happy. I've also taken a look at https://github.com/facebook/react/issues/17220 where I can see a test that explicitly test for this case marking it as invalid. Why? React version: 16.13.0	{'url': 'https://api.github.com/repos/facebook/react/issues/18254/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18254/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18253	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18253/labels{/name}	https://api.github.com/repos/facebook/react/issues/18253/comments	https://api.github.com/repos/facebook/react/issues/18253/events	https://github.com/facebook/react/issues/18253	577,974,827	MDU6SXNzdWU1Nzc5NzQ4Mjc=	18,253	Bug: useImperativeHandle is kinda broken, and usage with forwardRef becomes really annoying	{'login': 'Sharcoux', 'id': 797545, 'node_id': 'MDQ6VXNlcjc5NzU0NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/797545?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Sharcoux', 'html_url': 'https://github.com/Sharcoux', 'followers_url': 'https://api.github.com/users/Sharcoux/followers', 'following_url': 'https://api.github.com/users/Sharcoux/following{/other_user}', 'gists_url': 'https://api.github.com/users/Sharcoux/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Sharcoux/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Sharcoux/subscriptions', 'organizations_url': 'https://api.github.com/users/Sharcoux/orgs', 'repos_url': 'https://api.github.com/users/Sharcoux/repos', 'events_url': 'https://api.github.com/users/Sharcoux/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Sharcoux/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!\n" ]	2020-03-09 15:04:35	2020-06-14 16:09:34	2020-06-14 16:09:34	NONE	null	null	null	React version: 16.13.0 ## Steps To Reproduce 1. Try to access a child API from a parent by using forwardRef and useImperativeHandle 2. Try to access any DOM property from the child as you would expect from the usage of forwardRef. Link to code example: The issue is explained [here](https://stackoverflow.com/questions/60599895/react-useimperativehandle-and-forwardref-being-set-the-reference-doesnt-seem-t/60600282?noredirect=1#comment107213685_60600282) It can be tested [here](https://codesandbox.io/s/admiring-darkness-o8bm4?fontsize=14&hidenavigation=1&theme=dark) ## The current behavior The issue is the way useImperativeHandle deals with the reference it takes in. You will instantly lose the link with the DOM, making the use of forwardRef totally useless. ## The expected behavior Despite being mentionned [here](https://reactjs.org/docs/hooks-reference.html#useimperativehandle), There is absolutely no reason to justify using a new reference inside the child instead of the ref provided by the parent through forwardRef. Moreover, the current implementation is very unfriendly, as you will need to constantly check if current is defined before calling any of the `handles`. A much better approach would probably be to set the handles on the reference itself. The code could become much easier: ```javascript const Text = React.forwardRef(({ onClick }, ref) => { ref.getLocation = () => { return ref.current && ref.current.getBoundingClientRect() }; return (<button onClick={onClick} ref={ref}>Press Me</button>); }); Text.displayName = "Text"; function App() { const ref = React.createRef(); const [value, setValue] = React.useState(null) return (<div> <Text onClick={() => setValue(ref.getLocation())} ref={ref} /> <div>Value: {JSON.stringify(value)}</div> </div>); } ReactDOM.render(<App />, document.querySelector("#app")) ``` Actually everything would become so easy if you just removed the call to `Object.preventExtension from the `React.createRef` method... See [there](https://jsfiddle.net/01Lrhzj6/).	{'url': 'https://api.github.com/repos/facebook/react/issues/18253/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18253/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18252	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18252/labels{/name}	https://api.github.com/repos/facebook/react/issues/18252/comments	https://api.github.com/repos/facebook/react/issues/18252/events	https://github.com/facebook/react/issues/18252	577,877,956	MDU6SXNzdWU1Nzc4Nzc5NTY=	18,252	Shallow copy of the arguments in createElement can be improved for better performance	{'login': 'suthagar23', 'id': 17599049, 'node_id': 'MDQ6VXNlcjE3NTk5MDQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/17599049?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/suthagar23', 'html_url': 'https://github.com/suthagar23', 'followers_url': 'https://api.github.com/users/suthagar23/followers', 'following_url': 'https://api.github.com/users/suthagar23/following{/other_user}', 'gists_url': 'https://api.github.com/users/suthagar23/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/suthagar23/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/suthagar23/subscriptions', 'organizations_url': 'https://api.github.com/users/suthagar23/orgs', 'repos_url': 'https://api.github.com/users/suthagar23/repos', 'events_url': 'https://api.github.com/users/suthagar23/events{/privacy}', 'received_events_url': 'https://api.github.com/users/suthagar23/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "Please check and let me know if it's required. So I can add a PR for this improvement :-) ", "You probably mean `slice` not `splice`. Code uses `slice` but description uses `splice`.", "Also: [You can't slice `arguments`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments). You'd have allocate an empty array first. At that point it's unclear if this is in fact faster. Your benchmark does not accurately display how this would be implemented.", "Yes @eps1lon , updated the description with `slice`. \r\nAs you mentioned, we can't use the `slice` directly for `arguments`, but we can use `Array.prototype.slice.call(arguments, 3)` or `[].slice.call(arguments, 3)` instead of `arguments.slice(3)`.\r\n\r\nI have updated the benchmarking using the actual implementation.", "I think we'd need more convincing benchmarking for this. Microbenchmarks are [easy to get wrong](https://mrale.ph/blog/2014/12/24/array-length-caching.html). Can you prepare something more substantial, ideally with calls to actual `createElement` inside a compiled React bundle? We have some abandoned benchmarks [here](https://github.com/facebook/react/tree/master/scripts/bench) so maybe you could use that.", "Thanks, @gaearon, Let me work on this and do a benchmarking for this change", "This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!\n" ]	2020-03-09 12:40:19	2020-07-12 07:05:56	2020-07-12 07:05:56	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> In `createElement` method, there are few lines to shallow copy the arguments to `childArray`. - As it has to exclude the first two arguments, we can use `slice(2)` since the current implementation and slice will do the shallow copy of the arguments, and `slice` shows a better performance than doing it with a `for` loop. React version: 16.13.0 ## Steps To Reproduce N/A <!-- Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Issues without reproduction steps or code examples may be immediately closed as not actionable. --> Link to code example: https://github.com/facebook/react/blob/master/packages/react/src/ReactElement.js#L526-L535 <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior 1. Shallow copy the arguments to a newly created array using For Loop. ## The expected behavior we can change it using `arguments.slice(2)` as it does a shallow copy of the rest of the arguments from index 3. Just done a benchmarking for two types of implementation, and seems the slice is better than the For Loop-based implementation, ``` function fnUsingLoop(a,b,c,d,e,f) { childrenLength = arguments.length childArray = Array(childrenLength); for (let i = 0; i < childrenLength; i++) { childArray[i] = arguments[i + 2]; } return childArray; } d1 = performance.now(); for(i=0; i< 100000; i++) { fnUsingLoop(1,'a', () => {}, [1,2], {}, 1); } d2 = performance.now(); console.log("Taken for Loop : ", d2- d1); function fnUsingSlice(a,b,c,d,e,f) { return Array.prototype.slice.call(arguments, 3); } d3 = performance.now(); for(i=0; i< 100000; i++) { fnUsingSlice(1,'a', () => {}, [1,2], {}, 1); } d4 = performance.now(); console.log("Taken for slice : ", d4- d3); ```	{'url': 'https://api.github.com/repos/facebook/react/issues/18252/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18252/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18251	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18251/labels{/name}	https://api.github.com/repos/facebook/react/issues/18251/comments	https://api.github.com/repos/facebook/react/issues/18251/events	https://github.com/facebook/react/issues/18251	577,847,019	MDU6SXNzdWU1Nzc4NDcwMTk=	18,251	Bug(regression): PropTypes.resetWarningCache has no effect in react@next	{'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "importing the cache would defeat the purpose of inlining, which is to have fewer dependencies. Tricky. ", "I'm still not really clear on the value of having fewer dependencies, especially in the case of prop-types, which facebook controls.", "This is a bit unfortunate. But to be honest, we didn't really sign up to respect this setting in React itself. The fact that the `prop-types` module used by React was technically shared is an implementation detail that could easily change, e.g. if we pinned our version.\r\n\r\n>Useful for testing custom propTypes warnings. When a test is watched and modules can't be reset between runs resetWarningCache was useful. Otherwise the test behavior would change between test runs.\r\n\r\nWhile I probably won't convince you, `jest.resetModules()` in `beforeEach` + CommonJS in tests does this too. That's what we've been using. It works pretty well and resets other state you might want to make isolated.\r\n\r\n> I think we can keep inlining the code and only import the cache so that it is shared with the regular prop-types package and PropTypes.resetWarningCache() keeps working.\r\n\r\nThe purpose was to get rid of imports.\r\n\r\n>I'm still not really clear on the value of having fewer dependencies, especially in the case of prop-types, which facebook controls.\r\n\r\nProp-types is a legacy feature. It's not something that is super important to React going forward. We try to keep it working, but it's not a first-class \"React API\". There is no need for us to keep the implementation separate when the contract is so simple and we could just call into the user code from React here.\r\n\r\nOn the other hand, changes related to ESM and just our bundling process is always more complicated when there's dependencies involved. We have so few dependencies that this isn't worth the complexity. It is easier to get rid of them.", "This will break many test suites.\r\n\r\nCould React expose a way to reset the warning cache? `prop-types` could use that rather than its own mechanism.", ">This will break many test suites.\r\n\r\nIf you require `prop-types` in your test, there is no guarantee it would be the same instance as the one used by React. Because we could pin the version. With stricter workflows like Plug'and'Play it wouldn't even be possible to do that. So any tests written this way were essentially relying on internals.\r\n\r\nOne can always call `checkPropTypes` directly if they want to check that something matches a prop type. So it's fixable. Yes, this is unfortunate if someone already relies on this, but React never \"signed up\" to support this API for its own checks, and I think it's fair to say it worked by accident.\r\n\r\n>Could React expose a way to reset the warning cache? \r\n\r\nThis is actually interesting because it exposes another problem with this approach. Even if a library \"resets\" the propTypes cache, that doesn't help for any other React warnings. So it doesn't actually solve the problem for libraries that want to verify that React warnings aren't firing for it. You still need a better solution. Again, `resetModules()` is one way to do it.\r\n\r\nMaybe there could be some centralized cache for deduplication that would work for all warnings. And React could pass it to `prop-types` too. That sounds like a bigger refactoring. Might be worth a separate issue if you have a plan!", "The work point of moving prop-types to a separate package was so React didn’t have to expose it. Will React be exposing it now?\r\n\r\nThe test suites I’m concerned about don’t care about non-propType react warnings.", "Separately, whether it works by accident or not isn’t really relevant; if it works and you break it, you’re breaking people - in a non-major. Regardless of technicality debates wrt semver, that seems like a pretty user-hostile position to take for some kind of vague maintainability benefit for the react team.", "I would also point you to https://www.w3.org/TR/html-design-principles/#priority-of-constituencies, something that’s generally considered a good principle in all software design - namely, that users always matter more than authors.", ">The work point of moving prop-types to a separate package was so React didn’t have to expose it. Will React be exposing it now?\r\n\r\nReact won't be exposing the `PropTypes` validators themselves. At the time, it seemed to make sense to use `checkPropTypes` from the package (since the package needed it anyway as a standalone utility), but I don't think it makes sense now given the contract is already stable.\r\n\r\n> if it works and you break it, you’re breaking people - in a non-major. Regardless of technicality debates wrt semver, that seems like a pretty user-hostile position to take for some kind of vague maintainability benefit for the react team.\r\n\r\nWe have a versioning policy [here](https://reactjs.org/docs/faq-versioning.html#what-counts-as-a-breaking-change) which notes that we don't consider changes to DEV-only behavior like warnings to be breaking. In general case, this is because warnings are how we prepare people for other major changes. I agree this isn't exactly the case that section is meant to cover in spirit, but I hope it explains why we consider this change acceptable.\r\n\r\nIf test suites are written specifically to check React's console output, they will break because we add new warnings, reword warnings to be clearer, sometimes remove them, change deduplication heuristics, fix bugs, and so on. If every behavior change to warnings was considered breaking, we'd be incrementing majors every week, and I doubt the ecosystem would be better for it.\r\n\r\nMy suggestion is to either not write tests that assert on console output, or be prepared that changes to these tests will not follow the same schedule as changes to production behavior. We've reiterated this multiple times so this isn't really a new stance. It's part of how we release React.", "There's a critical difference here - non-propType warnings are about misusing React, and I think it's reasonable to consider this non breaking.\r\n\r\npropType warnings, however, are about misusing a component, and this does not seem to me to be in the same category.", "> If test suites are written specifically to check React's console output\r\n\r\nJust to give a bit more background how we're using this:\r\n\r\nWe're not checking react's console output (or at least we don't mind rewriting tests if those change). However, `Component.propTypes` supports custom prop-types which are officially documented: https://reactjs.org/docs/typechecking-with-proptypes.html#proptypes (`customArrayProp`). We use them for deprecation warnings, apply heuristics to determine if a component is a able to hold a ref, or generally refine a propType further (since prop-types only supports the `or` operator not `and` operator).\r\n\r\nThe ability to test these validators is now severly limited because watchmode doesn't work for them. This means working on them takes much more work (since I have to restart the test every time) which means I'm less like to work on them to improve DX.\r\n\r\nThe dilemma here is that I don't think propTypes is the right choice for these. I would've preferred [React.warn and React.error](https://github.com/facebook/react/pull/16126) but these were also stripped\r\n\r\nWhat makes this stance come across so user-hostile is that this wasn't done to enable something else (fix a bug, add a feature, improve perf). It was only done because you could and is then dismissed with \"just use jest\". Apart from the cost of having to migrate to another test runer, jest is also lacking a critical feature over other runners: it can't run in the browser.\r\n\r\nWould a `React.resetPropTypesWarningCache` work for you? This would ensure that the correct cache is reset (in case React#propTypes and propTypes has a version mismatch.", "Let’s step back for a second. Can you explain in more detail why explicitly calling `checkPropTypes` doesn’t work for you? That should still work with resetting like before. ", "> The dilemma here is that I don't think propTypes is the right choice for these. I would've preferred React.warn and React.error but these were also stripped\r\n\r\n`console.error` is still there. Why don’t you use that? ", "> Can you explain in more detail why explicitly calling checkPropTypes doesn’t work for you?\r\n\r\nI wasn't aware of that method. But apparently it only fires once:\r\n\r\n> PropTypes.checkPropTypes(...) only console.errors a given message once. To reset the error warning cache in tests, call PropTypes.resetWarningCache()\r\n\r\n-- https://github.com/facebook/prop-types#proptypesresetwarningcache\r\n\r\nThis would break our tests in watchmode. We never had a use for resetting modules between tests since the modules under test were stateless (at least the parts we wanted to test). It's also not trivial to do in mocha (requires 3rd party package).\r\n\r\n> console.error is still there. Why don’t you use that?\r\n\r\nIt does not include the component stack on the server nor can we deduplicate the warning by component stack. ", "Previously we were appending a random string to the message for cache busting but that hurt readability. We'll probably go back to that approach and hide it in a custom matcher. I'm just a bit worried that checkPropTypes will also go away in a minor with the same justification. ", "Before you assume malice, please help me understand the issue better.\r\n\r\n>But apparently it only fires once:\r\n\r\n>>PropTypes.checkPropTypes(...) only console.errors a given message once. To reset the error warning cache in tests, call PropTypes.resetWarningCache()\r\n\r\nYes, so you need to call `PropTypes.resetWarningCache()`. We didn't break it.\r\n\r\n*The only change is that `PropTypes.resetWarningCache()` wouldn't reset warnings coming from React.\r\n\r\nIf you call `PropTypes.checkPropTypes()` in your tests, `PropTypes.resetWarningCache()` would reset those just fine.\r\n\r\nCan you please* explain why this doesn't work for you?\r\n\r\n>I'm just a bit worried that checkPropTypes will also go away in a minor with the same justification.\r\n\r\nI'm sorry that you got the impression that we don't care about our users and are going to remove APIs in minors. I don't believe this is what happened here. We didn't remove any API in a minor, and don't intend to.\r\n\r\n`PropTypes` itself is completely separate from React. We don't intend to even touch that package in the future. If you want to help maintain it, you're welcome to become a co-maintainer. If you only use its APIs (e.g. `checkPropTypes` + `resetWarningCache`) everything still works.\r\n\r\nThe only thing we \"removed\" is the ability for `resetWarningCache` to influence what React prints. Because that was never something we signed up for. `resetWarningCache` was added by a third-party contributor to `prop-types` (that wasn't a feature we developed while it was in React), and at no point in time did we say that React would abide by that feature. It happened to work by accident, but even then in limited circumstances (e.g. it would break with version pinning). So we don't consider this a breakage.\r\n\r\nGiven that the alternative (`checkPropTypes` + `resetWarningCache`) exists, has a simpler API, and should continue working indefinitely, can you explain why it doesn't work for you?", "@gaearon because the best way to test propTypes isn't to unit-test an individual custom propType, it's to attempt to render a component, and fail your tests when React issues propType warnings. that, specifically, is the primary benefit of `resetWarningCache` - so that React's propType warnings can be caught, and then reset, so tests in watch mode - or simply, two tests failing with the same propType failure - will all fail deterministically.", "> Can you please explain why this doesn't work for you?\r\n\r\nIf that is indeed the case then it would work for me. I simply assumed that resetWarningCache works the same for .propTypes and checkPropTypes. Let me try checkPropTypes and then I'll update the documentation since I don't think it's obvious. \r\n\r\nIn a perfect world I wouldn't unit test propTypes with resetWarningCache but that isn't that important to me. I'm more interested in a practical compromise than some perfect theoretical approach.", "It technically works for us but we have to mock a couple of internals:\r\n\r\n```js\r\nPropTypes.checkPropTypes(\r\n ButtonBase.Wrapped.propTypes,\r\n { classes: {}, component: Component },\r\n 'prop',\r\n 'ForwardRef(ButtonBase)',\r\n);\r\n```\r\n\r\n1. The component under test still uses higher-order components which means we have to inject props from the HOC manually (here `classes`)\r\n2. Since it is wrapped we have to access the internal component (here ButtonBase.Wrapped) \r\n3. The component name doesn't really matter but it would've been nice to see if what displayName the user gets to see.\r\n\r\nSo this works for us but there are quite a bit of internals we have to mock.\r\n\r\nCould you explain why it wouldn't work for you to expose `resetPropTypesWarningCache` from react?", "> Could you explain why it wouldn't work for you to expose resetPropTypesWarningCache from react?\r\n\r\nIt is a new API. We don’t add new APIs lightly. For the ones we do, we want them to stick around for a long term.\r\n\r\nI don’t know if even calling PropTypes at all is something we want to support in longer term. They are a relatively poor replacement for type checking and have nothing to do with UI. We understand many people care about them, but it’s pretty arbitrary that you would limit runtime type checking to UI alone. Why not all modules? The point of extracting them was in part to make that easier and more natural. So I imagine in distant future React may stop calling them and instead there would be a codemod that turns your components into:\r\n\r\n```js\r\nfunction Button(props) {\r\n checkPropTypes(props, Button.propTypes)\r\n // your code\r\n}\r\n```\r\n\r\nEffectively fully moving them into userland.\r\n\r\nWith a vision like this, it doesn’t make sense to add more propTypes-specific APIs to React itself. ", "> It technically works for us but we have to mock a couple of internals:\r\n\r\nCan you link me to components and tests in question? I’m low key wondering why you want to test prop types at all. They’re already fully declarative so it seems like writing the same code twice. Unlike components, they (usually) don’t contain any logic so the only way to mess them up is to have typos. Which would be caught by a shallow test asserting their presence with given names. As long as your other tests (for UI) don’t trigger warnings, I don’t know what it is that you want to be testing. \r\n\r\nI understand the need to test a custom propType validator but that can be done in isolation easily.", "I think my overall conclusion is that I see some value in being able to reset all warnings, but I struggle to see value in “testing propTypes” because they don’t contain any custom logic. The only kind of test I can imagine being valuable is making sure legit use of your component doesn’t trigger them. But you already get that even if you don’t reset warnings. I agree non-determinism is best avoided in tests, but that logic applies much more importantly to other React warnings that point out real bugs. So if you care about this you either need `resetModules()` or an equivalent. Such as `delete require.cache[...]` might work in Node. If neither of these alternatives suffices then I guess a React RFC for a way to reset all warnings would be in order so we can talk about how that could (or could not) work. But it doesn’t make sense to me to solve this for propTypes alone.", "> function Button(props) {\r\n checkPropTypes(props, Button.propTypes)\r\n // your code\r\n}\r\n\r\nSo like a `React.error`? :wink: \r\n\r\nAnyway this is at least resolved for me personally since we can leverage checkPropTypes. \r\n\r\n> Can you link me to components and tests in question?\r\n\r\nI'll ping you in the PR where we migrate from .propTypes to checkPropTypes since I want to go over these custom propTypes myself just in case they are actually not necessary.", "Deleting the require cache doesn't work in node, unless you delete all of the cached code of your entire graph - because modules cache things at module level.\r\n\r\n`resetModules` only works because jest hijacks node's module system (creating many bugs and inconveniences in the process); it's not reasonable to recommend that universally.\r\n\r\nSeparately, propTypes are better than types for most cases - you can propType an integer, or strings that match a regex, for example, none of which you can do in TS. propTypes and types are complementary, and it's simply false to claim that propTypes are a poor replacement for type checking.", ">Deleting the require cache doesn't work in node, unless you delete all of the cached code of your entire graph - because modules cache things at module level.\r\n\r\nReact compiles to bundles. So deleting `react-dom/cjs/react-dom.development.js` from the cache should be sufficient to reset React warnings if you really want to. Again, I'm not saying it's \"recommended\", but since React doesn't offer a first-class way to reset warnings, that's the best I can offer.\r\n\r\n>Separately, propTypes are better than types for most cases - you can propType an integer, or strings that match a regex, for example, none of which you can do in TS.\r\n\r\nSure. In my experience of looking at tens of thousands of components both in open source and at FB, this powerful capability is rarely used in practice. For the cases where runtime validation specifically is important, manually calling `PropTypes.checkPropTypes()` or a custom equivalent would work well. And it works for non-components too, which seems useful if runtime validation is important for your use cases.\r\n\r\nWhat I'm saying isn't that PropTypes are useless. It's more that most of their use cases have been superseded, and the remaining use cases aren't tied to React so a general solution would make sense.", "> I'll ping you in the PR where we migrate from .propTypes to checkPropTypes since I want to go over these custom propTypes myself just in case they are actually not necessary.\r\n\r\nSee https://github.com/mui-org/material-ui/pull/20451", "@gaearon since every component in every app everywhere does `import React from 'react'`, and that reference is cached in its jsx, deleting React from the module cache is actually entirely ineffective, and would result in two copies of React in the system if you re-imported from react. With the change you're making here, the only solution is \"reset everything and reimport everything on every test\", which i suspect would decimate any speed advantages jest provides.", "Ah right. I forgot this happens in the React bundle rather than ReactDOM. (Where the majority of warnings lives.)" ]	2020-03-09 11:44:17	2020-04-07 17:49:22	2020-04-01 23:43:02	COLLABORATOR	null	null	null	React version: 0.0.0-235a6c4af ## Steps To Reproduce 1. render component with exptected propType warnings 2. see logged errors 3. call `PropTypes.resetWarningCache()` 4. render component with exptected propType warnings 5. no more logged errors Link to code example: ```jsx import React from "react"; import ReactDOM from "react-dom"; import PropTypes from "prop-types"; function Component({ children = "setting default to not crash react" }) { return children; } Component.propTypes = { children: PropTypes.node.isRequired }; const rootElement = document.createElement("div"); ReactDOM.render(<Component />, rootElement); PropTypes.resetWarningCache(); ReactDOM.render(<Component />, rootElement); ``` [Behavior on `0.0.0-235a6c4af`](https://codesandbox.io/s/resetwarningcache1630-y05ug) [Behavior on `16.13.0`](https://codesandbox.io/s/resetwarningcache16130-3g2zl) ## The current behavior Warnings are logged once ## The expected behavior Warnings are logged twice. This was the behavior in 16.13.0 ## Context Useful for testing custom propTypes warnings. When a test is watched and modules can't be reset between runs `resetWarningCache` was useful. Otherwise the test behavior would change between test runs. Pretty sure this is caused by inlining `prop-types` in #18127. I think we can keep inlining the code and only import the cache so that it is shared with the regular `prop-types` package and `PropTypes.resetWarningCache()` keeps working.	{'url': 'https://api.github.com/repos/facebook/react/issues/18251/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18251/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18250	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18250/labels{/name}	https://api.github.com/repos/facebook/react/issues/18250/comments	https://api.github.com/repos/facebook/react/issues/18250/events	https://github.com/facebook/react/issues/18250	577,802,705	MDU6SXNzdWU1Nzc4MDI3MDU=	18,250	Bug: Mixing native and synthetic events causes abnormal behavior	{'login': 'Jiang-Xuan', 'id': 13357301, 'node_id': 'MDQ6VXNlcjEzMzU3MzAx', 'avatar_url': 'https://avatars.githubusercontent.com/u/13357301?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Jiang-Xuan', 'html_url': 'https://github.com/Jiang-Xuan', 'followers_url': 'https://api.github.com/users/Jiang-Xuan/followers', 'following_url': 'https://api.github.com/users/Jiang-Xuan/following{/other_user}', 'gists_url': 'https://api.github.com/users/Jiang-Xuan/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Jiang-Xuan/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Jiang-Xuan/subscriptions', 'organizations_url': 'https://api.github.com/users/Jiang-Xuan/orgs', 'repos_url': 'https://api.github.com/users/Jiang-Xuan/repos', 'events_url': 'https://api.github.com/users/Jiang-Xuan/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Jiang-Xuan/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"} {'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}]	closed	false	null	[]	null	[ "thanks for any response 🍻", "This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n", "Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!\n" ]	2020-03-09 10:27:34	2020-06-14 12:09:35	2020-06-14 12:09:35	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> React version: 16.13.0 ## Steps To Reproduce 1. ![image](https://user-images.githubusercontent.com/13357301/76204226-f2d2a780-6232-11ea-869f-d89366bb5446.png) move mouse from A to B, You can see that the console printed "inner mouseenter" 2. ![image](https://user-images.githubusercontent.com/13357301/76204387-4513c880-6233-11ea-8f2c-cd754cc80bbe.png) move mouse from A to B, nothing <!-- Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Issues without reproduction steps or code examples may be immediately closed as not actionable. --> Link to code example: https://codesandbox.io/s/staging-breeze-z05hz More info: user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36 <!-- Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. --> ## The current behavior not print 'inner mouseenter' ## The expected behavior print 'inner mouseenter'	{'url': 'https://api.github.com/repos/facebook/react/issues/18250/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18250/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18249	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18249/labels{/name}	https://api.github.com/repos/facebook/react/issues/18249/comments	https://api.github.com/repos/facebook/react/issues/18249/events	https://github.com/facebook/react/issues/18249	577,624,679	MDU6SXNzdWU1Nzc2MjQ2Nzk=	18,249	Useeffect asynchronous processing reported a warning	{'login': 'lgf196', 'id': 29600558, 'node_id': 'MDQ6VXNlcjI5NjAwNTU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/29600558?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lgf196', 'html_url': 'https://github.com/lgf196', 'followers_url': 'https://api.github.com/users/lgf196/followers', 'following_url': 'https://api.github.com/users/lgf196/following{/other_user}', 'gists_url': 'https://api.github.com/users/lgf196/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lgf196/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lgf196/subscriptions', 'organizations_url': 'https://api.github.com/users/lgf196/orgs', 'repos_url': 'https://api.github.com/users/lgf196/repos', 'events_url': 'https://api.github.com/users/lgf196/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lgf196/received_events', 'type': 'User', 'site_admin': False}	[{'id': 1983406161, 'node_id': 'MDU6TGFiZWwxOTgzNDA2MTYx', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Expected%20Behavior', 'name': 'Resolution: Expected Behavior', 'color': '8c98d8', 'default': False, 'description': ''}]	closed	false	null	[]	null	[ "Please share a codesandbox link with a reproducible example, it’s unclear from your snippet what the behaviour is. ", "it's likely that your component is unmounting (for whatever reason) before the async call completes. In which case, the warning is correct. ", "https://reactjs.org/docs/hooks-faq.html#is-it-safe-to-omit-functions-from-the-list-of-dependencies). It's possible that the component using this hook unmounts before `fontManage` resolves. You can use a local variable to track that, so you don't end up calling `setGetData` on an unmounted component.\r\n\r\n```js\r\nuseEffect(() => {\r\n // Component is initially mounted...\r\n let mounted = true;\r\n const init = async () => {\r\n let res = await fontManage({ ...pagaTion, tagName });\r\n // Check mounted before calling setGetData\r\n res.code === successCode && mounted && setGetData(res.data);\r\n };\r\n init();\r\n return () => {\r\n // Set mounted to false in the effect's cleanup method\r\n mounted = false;\r\n };\r\n}, [pagaTion, tagName]);\r\n```" ]	2020-03-09 02:42:35	2020-04-13 20:13:51	2020-04-13 20:13:50	NONE	null	null	null	The code is as follows： ```jsx useEffect(() => { init(); }, [pagaTion, tagName]); const init = async () => { let res = await fontManage({ ...pagaTion, tagName }); res.code === successCode && setGetData(res.data); }; ``` The warning message is as follows：`Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function`	{'url': 'https://api.github.com/repos/facebook/react/issues/18249/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18249/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18248	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18248/labels{/name}	https://api.github.com/repos/facebook/react/issues/18248/comments	https://api.github.com/repos/facebook/react/issues/18248/events	https://github.com/facebook/react/pull/18248	577,575,697	MDExOlB1bGxSZXF1ZXN0Mzg1MzIwOTcy	18,248	[DevTools] Add shortcut keys for tab switching	{'login': 'kerolloz', 'id': 36763164, 'node_id': 'MDQ6VXNlcjM2NzYzMTY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/36763164?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kerolloz', 'html_url': 'https://github.com/kerolloz', 'followers_url': 'https://api.github.com/users/kerolloz/followers', 'following_url': 'https://api.github.com/users/kerolloz/following{/other_user}', 'gists_url': 'https://api.github.com/users/kerolloz/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kerolloz/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kerolloz/subscriptions', 'organizations_url': 'https://api.github.com/users/kerolloz/orgs', 'repos_url': 'https://api.github.com/users/kerolloz/repos', 'events_url': 'https://api.github.com/users/kerolloz/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kerolloz/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18248/builds/15425) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 64a3a200b34520bd65b6ea3c4262446ec7d03035:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[silly-wing-qri30](https://codesandbox.io/s/silly-wing-qri30)\| Configuration \|\n", "@bvaughn \r\nwhat do you think, any thoughts? ", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 64a3a200b34520bd65b6ea3c4262446ec7d03035\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 64a3a200b34520bd65b6ea3c4262446ec7d03035\n</p>\n", "@strdr4605\nNo need to reinvent the wheel to implement a simple task. Using a well tested package can save you tons of bugs. It's my opinion, I respect yours, I see what you are saying. ", "@ermanzohre Approving PRs without leaving feedback or comments is not really helpful.", "@bvaughn \r\nI don't get how should I bind to `ownerDocument.defaultView`.\r\nWhat about the following approach so far? except for `window.addEventListener`.\r\n```javascript\r\nuseEffect(() => {\r\n if (showTabBar) {\r\n window.addEventListener('keydown', (e: KeyboardEvent) => {\r\n if ((e.ctrlKey \|\| e.metaKey) && '12'.includes(e.key)) {\r\n const tabNumber = +e.key - 1;\r\n if (tabs[tabNumber].id !== tab) {\r\n console.log('switching');\r\n setTab(tabs[tabNumber].id);\r\n }\r\n }\r\n // e.preventDefault();\r\n // e.stopPropagation();\r\n });\r\n }\r\n}, [showTabBar, tab]);\r\n```\r\nI know it has one problem, it listens to the event multiple times", "> I don't get how should I bind to `ownerDocument.defaultView`.\r\n\r\nDid you check out the commit I linked to? It has an example of doing this.\r\n\r\n`'12'.includes(e.key)` looks like an unusual way of checking for \"1\" or \"2\" :smile:\r\n\r\nMaybe something like this? (Note: I did not test it.)\r\n```js\r\nuseEffect(() => {\r\n // Find ownerWindow from a ref link in commit be9046a\r\n\r\n if (showTabBar) {\r\n ownerWindow.addEventListener(\"keydown\", (event: KeyboardEvent) => {\r\n if (event.ctrlKey \|\| event.metaKey) {\r\n switch (event.key) {\r\n case \"1\":\r\n setTab(tabs[0].id);\r\n event.preventDefault();\r\n event.stopPropagation();\r\n break;\r\n case \"2\":\r\n setTab(tabs[1].id);\r\n event.preventDefault();\r\n event.stopPropagation();\r\n break;\r\n }\r\n }\r\n });\r\n }\r\n\r\n return () => {\r\n // showTabBar should never change, so this cleanup shouldn't be run\r\n // but it's still good practice to add it anyway! :)\r\n ownerWindow.removeEventListener(\"keydown\");\r\n };\r\n}, [showTabBar]);\r\n\r\n```", "Yes I checked the commit, but still not sure how to do it. I tried doing\r\n\r\n```js\r\nconst devtoolsRef = useRef<HTMLElement\|null>(null);\r\n\r\nuseEffect(() => {\r\n const ownerWindow = devtoolsRef.current.ownerDocument.defaultView;\r\n const handleKeyDown = (event: KeyboardEvent) => {\r\n if (event.ctrlKey \|\| event.metaKey) {\r\n // only switch if choosen tab is not the current one\r\n const shouldSwitchTabs = tabs[+event.key - 1].id !== tab;\r\n if (shouldSwitchTabs) {\r\n switch (event.key) {\r\n case '1':\r\n setTab(tabs[0].id);\r\n event.preventDefault();\r\n event.stopPropagation();\r\n break;\r\n case '2':\r\n setTab(tabs[1].id);\r\n event.preventDefault();\r\n event.stopPropagation();\r\n break;\r\n }\r\n }\r\n }\r\n };\r\n if (showTabBar) {\r\n ownerWindow.addEventListener('keydown', handleKeyDown);\r\n }\r\n\r\n return () => {\r\n // showTabBar should never change, so this cleanup shouldn't be run\r\n // but it's still good practice to add it anyway! :)\r\n ownerWindow.removeEventListener('keydown', handleKeyDown);\r\n };\r\n}, [showTabBar, tab, tabs, devtoolsRef]);\r\n\r\n\r\n...\r\n\r\nreturn (\r\n <BridgeContext.Provider value={bridge} ref={devtoolsRef}>\r\n```\r\n\r\nI get `TypeError: devtoolsRef.current is null`. ", "Because you assign the devtoolsRef first with null you should check it in the `useEffect`\r\n\r\nmaybe this will help\r\n\r\n```js\r\nconst devtoolsRef = useRef<HTMLElement\|null>(null);\r\n\r\nuseEffect(() => {\r\n if (!devtoolsRef.current) return;\r\n\r\n ... \r\n\r\n}, [showTabBar, tab, tabs, devtoolsRef]);\r\n\r\n\r\n...\r\n\r\nreturn (\r\n <BridgeContext.Provider value={bridge} ref={devtoolsRef}>\r\n```\r\n\r\nAlso, maybe we can rewrite the switch to:\r\n\r\n```js\r\nif (shouldSwitchTabs) {\r\n const tabIndex = [\"1\", \"2\"].indexOf(event.key);\r\n if (tabIndex > -1) {\r\n setTab(tabs[tabIndex].id);\r\n event.preventDefault();\r\n event.stopPropagation();\r\n }\r\n}\r\n```", "Refs don't really belong in the dependencies array. They aren't React-managed-state/props. Also `tab` really doesn't need to be in there either, nor `setTab` because it's stable :smile:\r\n\r\nI'm not really a fan of unnecessary succinctness in cases like this 😄 I think a good old fashioned switch/case is more readable! 😁 ", "I think `tab` needs to be in the dependencies array because its value changes whenever the tab switches. I tried removing it, and it didn't work, because the value of tab gets changed but it doesn't inside `useEffect`.", "> I'm not really a fan of unnecessary succinctness in cases like this 😄 I think a good old fashioned switch/case is more readable! 😁\r\n\r\nThen it's better to extract \r\n```js\r\nsetTab(tabs[0].id);\r\nevent.preventDefault();\r\nevent.stopPropagation();\r\n```\r\nin another function as it is repetion of code.\r\n\r\n----\r\n\r\nBut I write `switch` statements in 2 cases :sweat_smile::\r\n1. No other way is possible (like `objectWithCases[caseToMatch]`)\r\n2. Pattern matching in ReasonML", "Thank you @strdr4605 \r\nbut `if (!devtoolsRef.current) return;` will not help bind the event ", "> I think `tab` needs to be in the dependencies array because its value changes whenever the tab switches.\r\n\r\nThe current tab does not need to be referenced at all in the effect. If you call `setTab` with the same as the current value, React will just ignore it. That's why the example code I wrote didn't use it.", "> Then it's better to extract\r\n> ...\r\n> in another function as it is repetion of code.\r\n\r\nNo. Repetition is fine in small amounts. The code is not large or complicated. We don't need to write it in as few characters as possible.", "Amazing react ❤️\n\nSo now the only problem I am facing is using `devtoolsRef`\n\n", "@bvaughn \r\nI don't get why some tests have failed\r\nhttps://ci.codesandbox.io/status/facebook/react/pr/18248/builds/15120\r\n![image](https://user-images.githubusercontent.com/36763164/76809353-3315c500-67f3-11ea-96be-85acdf49092a.png)\r\n", "Oh finally! :tada: \r\nThank you @bvaughn for your patience. Such a welcoming and helpful community. :sparkles:\r\nI learned a lot! " ]	2020-03-08 22:18:08	2020-03-18 18:05:42	2020-03-18 18:05:42	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18248', 'html_url': 'https://github.com/facebook/react/pull/18248', 'diff_url': 'https://github.com/facebook/react/pull/18248.diff', 'patch_url': 'https://github.com/facebook/react/pull/18248.patch', 'merged_at': datetime.datetime(2020, 3, 18, 18, 5, 41)}	<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Fixes #18226 ## Test Plan <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. --> ![gif](https://user-images.githubusercontent.com/36763164/76172143-57dabe80-619b-11ea-9d99-0cd284316869.gif)	{'url': 'https://api.github.com/repos/facebook/react/issues/18248/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18248/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18247	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18247/labels{/name}	https://api.github.com/repos/facebook/react/issues/18247/comments	https://api.github.com/repos/facebook/react/issues/18247/events	https://github.com/facebook/react/issues/18247	577,502,974	MDU6SXNzdWU1Nzc1MDI5NzQ=	18,247	Bug: Callback referencing to outdated state when assigned as part of initial state object	{'login': 'Huldoser', 'id': 12258224, 'node_id': 'MDQ6VXNlcjEyMjU4MjI0', 'avatar_url': 'https://avatars.githubusercontent.com/u/12258224?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Huldoser', 'html_url': 'https://github.com/Huldoser', 'followers_url': 'https://api.github.com/users/Huldoser/followers', 'following_url': 'https://api.github.com/users/Huldoser/following{/other_user}', 'gists_url': 'https://api.github.com/users/Huldoser/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Huldoser/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Huldoser/subscriptions', 'organizations_url': 'https://api.github.com/users/Huldoser/orgs', 'repos_url': 'https://api.github.com/users/Huldoser/repos', 'events_url': 'https://api.github.com/users/Huldoser/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Huldoser/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "This isn't a bug. It's a combination of how the `useState` API works (initializing only once) and how [closures](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Closures#:~:text=A%20closure%20is%20the%20combination,scope%20from%20an%20inner%20function.) work in JavaScript.\r\n\r\nI wouldn't suggest putting callbacks into your state- for reasons like this (and also because I think it's probably rarely, if ever, necessary).\r\n\r\nIf, for some reason, it is actually necessary, you could use the function form of updating state:\r\n```js\r\n const increaseCount = () =>\r\n setCountObj(prevState => ({ ...prevState, count: prevState.count + 1 }));\r\n\r\n const [countObj, setCountObj] = React.useState({\r\n count: 0,\r\n onButtonClick: increaseCount\r\n });\r\n```", "@bvaughn In this case I agree that it should be avoided to use callback inside the initial state but its not obvious.\r\n\r\nMaybe we should add eslint warning as it leads to confusing and hard to debug behaviour?", "Maybe! Feel free to submit a PR that adds a warning like that for discussion :smile:" ]	2020-03-08 13:44:01	2020-03-09 16:40:19	2020-03-08 17:10:45	NONE	null	null	null	Callback referencing to outdated state when assigned as part of initial state object. I am not actually sure if this is a bug or intended behavior, and if it is intended I would love to have a lint rule or react warning me about it. React version: 16.13.0 ## Steps To Reproduce ``` import React from "react"; function App() { const increaseCount = () => setCountObj({ ...countObj, count: countObj.count + 1 }); const [countObj, setCountObj] = React.useState({ count: 0, onButtonClick: increaseCount }); return ( <div> <h3>count: {countObj.count}</h3> <button onClick={countObj.onButtonClick}>Click to increase count</button> </div> ); } export default App; ``` Link to code example: [https://codesandbox.io/s/pensive-mendeleev-f25is](https://codesandbox.io/s/pensive-mendeleev-f25is) ## The current behavior This is a simplified use case of an issue I encountered lately. When clicking the button multiple times the count stays at 1, it seems that the callback inside the initial state referencing to outdated state value every time its called ## The expected behavior The state inside the callback should be undefined or referencing to the correct state. ## Solution I solved the issue by removing the callback from the state and creating 'actualState' variable that is a merge between the state with the callback.	{'url': 'https://api.github.com/repos/facebook/react/issues/18247/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18247/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18246	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18246/labels{/name}	https://api.github.com/repos/facebook/react/issues/18246/comments	https://api.github.com/repos/facebook/react/issues/18246/events	https://github.com/facebook/react/issues/18246	577,482,527	MDU6SXNzdWU1Nzc0ODI1Mjc=	18,246	Error: "Cannot read property '2' of undefined"	{'login': 'lmajowka', 'id': 6997189, 'node_id': 'MDQ6VXNlcjY5OTcxODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6997189?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lmajowka', 'html_url': 'https://github.com/lmajowka', 'followers_url': 'https://api.github.com/users/lmajowka/followers', 'following_url': 'https://api.github.com/users/lmajowka/following{/other_user}', 'gists_url': 'https://api.github.com/users/lmajowka/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/lmajowka/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/lmajowka/subscriptions', 'organizations_url': 'https://api.github.com/users/lmajowka/orgs', 'repos_url': 'https://api.github.com/users/lmajowka/repos', 'events_url': 'https://api.github.com/users/lmajowka/events{/privacy}', 'received_events_url': 'https://api.github.com/users/lmajowka/received_events', 'type': 'User', 'site_admin': False}	[]	closed	false	null	[]	null	[ "Without any description or context, this isn't really actionable. I'm going to close it, but I'll re-open it if you fill in the \"Describe what you were doing when the bug occurred\" section." ]	2020-03-08 11:00:40	2020-03-08 17:06:58	2020-03-08 17:06:57	NONE	null	null	null	Describe what you were doing when the bug occurred: 1. 2. 3. --------------------------------------------- Please do not remove the text below this line --------------------------------------------- DevTools version: 4.5.0-355970aa4 Call stack: at N (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:160295) at j (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:160015) at e.getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:162825) at ec (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40:337472) at ti (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:32:58696) at qi (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:32:67715) at Sl (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:32:108833) at jc (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:32:100072) at Oc (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:32:99997) at Tc (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:32:99862) Component stack: in ec in div in div in div in So in Unknown in n in Unknown in div in div in rl in Ze in fn in Ga in _s	{'url': 'https://api.github.com/repos/facebook/react/issues/18246/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18246/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18245	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18245/labels{/name}	https://api.github.com/repos/facebook/react/issues/18245/comments	https://api.github.com/repos/facebook/react/issues/18245/events	https://github.com/facebook/react/pull/18245	577,436,377	MDExOlB1bGxSZXF1ZXN0Mzg1MjE5NjI3	18,245	Refactor unnecessary continue statements	{'login': 'hi-rustin', 'id': 29879298, 'node_id': 'MDQ6VXNlcjI5ODc5Mjk4', 'avatar_url': 'https://avatars.githubusercontent.com/u/29879298?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hi-rustin', 'html_url': 'https://github.com/hi-rustin', 'followers_url': 'https://api.github.com/users/hi-rustin/followers', 'following_url': 'https://api.github.com/users/hi-rustin/following{/other_user}', 'gists_url': 'https://api.github.com/users/hi-rustin/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hi-rustin/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hi-rustin/subscriptions', 'organizations_url': 'https://api.github.com/users/hi-rustin/orgs', 'repos_url': 'https://api.github.com/users/hi-rustin/repos', 'events_url': 'https://api.github.com/users/hi-rustin/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hi-rustin/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18245/builds/13766) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b000f6de7091b9d74a71c3356d79a653960d78f9:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[determined-chaplygin-5hd6g](https://codesandbox.io/s/determined-chaplygin-5hd6g)\| Configuration \|\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18245/builds/13767) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit bc8b189b7280ea63cb0d8e2800a93a2d978d54aa:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[sleepy-taussig-1pfbv](https://codesandbox.io/s/sleepy-taussig-1pfbv)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bc8b189b7280ea63cb0d8e2800a93a2d978d54aa\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bc8b189b7280ea63cb0d8e2800a93a2d978d54aa\n</p>\n" ]	2020-03-08 03:04:52	2020-03-25 13:32:01	2020-03-25 13:32:01	NONE	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18245', 'html_url': 'https://github.com/facebook/react/pull/18245', 'diff_url': 'https://github.com/facebook/react/pull/18245.diff', 'patch_url': 'https://github.com/facebook/react/pull/18245.patch', 'merged_at': None}	Signed-off-by: Rustin-Liu <rustin.liu@gmail.com> <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the motivation for making this change. What existing problem does the pull request solve? --> I found some unnecessary continue statements when I reading the source code. So I refactored it.	{'url': 'https://api.github.com/repos/facebook/react/issues/18245/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18245/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18244	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18244/labels{/name}	https://api.github.com/repos/facebook/react/issues/18244/comments	https://api.github.com/repos/facebook/react/issues/18244/events	https://github.com/facebook/react/issues/18244	577,425,991	MDU6SXNzdWU1Nzc0MjU5OTE=	18,244	Bug: svg viewBox attribute doesn't work	{'login': 'mytecor', 'id': 20505643, 'node_id': 'MDQ6VXNlcjIwNTA1NjQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/20505643?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mytecor', 'html_url': 'https://github.com/mytecor', 'followers_url': 'https://api.github.com/users/mytecor/followers', 'following_url': 'https://api.github.com/users/mytecor/following{/other_user}', 'gists_url': 'https://api.github.com/users/mytecor/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/mytecor/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/mytecor/subscriptions', 'organizations_url': 'https://api.github.com/users/mytecor/orgs', 'repos_url': 'https://api.github.com/users/mytecor/repos', 'events_url': 'https://api.github.com/users/mytecor/events{/privacy}', 'received_events_url': 'https://api.github.com/users/mytecor/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "My God, I'm so stupid)" ]	2020-03-08 01:08:46	2020-03-08 01:13:44	2020-03-08 01:13:44	NONE	null	null	null	React ignores viewBox attribute React version: 16.13.0 Link to code example: https://codesandbox.io/s/react-svg-viewbox-bug-ljfr5	{'url': 'https://api.github.com/repos/facebook/react/issues/18244/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18244/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18243	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18243/labels{/name}	https://api.github.com/repos/facebook/react/issues/18243/comments	https://api.github.com/repos/facebook/react/issues/18243/events	https://github.com/facebook/react/issues/18243	577,277,782	MDU6SXNzdWU1NzcyNzc3ODI=	18,243	Bug: Passing an array as a `useEffect` dependency causes an infinite loop	{'login': 'garyking', 'id': 343940, 'node_id': 'MDQ6VXNlcjM0Mzk0MA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/343940?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/garyking', 'html_url': 'https://github.com/garyking', 'followers_url': 'https://api.github.com/users/garyking/followers', 'following_url': 'https://api.github.com/users/garyking/following{/other_user}', 'gists_url': 'https://api.github.com/users/garyking/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/garyking/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/garyking/subscriptions', 'organizations_url': 'https://api.github.com/users/garyking/orgs', 'repos_url': 'https://api.github.com/users/garyking/repos', 'events_url': 'https://api.github.com/users/garyking/events{/privacy}', 'received_events_url': 'https://api.github.com/users/garyking/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "```javascript\r\nimport React, { useEffect, useState, useRef } from 'react';\r\n\r\nfunction Home({arg}) {\r\n const [value, setValue] = useState(['b']);\r\n\r\n useEffect(() => {\r\n setValue(['c']);\r\n }, [arg]);\r\n\r\n console.log('value', value);\r\n}\r\n\r\nexport default function App() {\r\n let arg = useRef(['a']);\r\n return <Home arg={arg.current}/>\r\n}\r\n```\r\nemmmmm", "@FuzzyFade Yeah, this works! So is this necessary for any non-string values passed to useEffect deps?", "> @FuzzyFade Yeah, this works! So is this necessary for any non-string values passed to useEffect deps?\r\n\r\nI don’t know what your business want to do, but as long as the outer layer of FC is OK. You don’t need to write useRef. This is purely a personal habit.\r\nIf you write according to you, you basically initialize an array object every time, so the arg every time is different, resulting in an infinite loop.\r\n\r\nActually you can also write like this：\r\n```javascript\r\nimport React, { useEffect, useState, useRef } from 'react';\r\n\r\nexport default function Home() {\r\n const [value, setValue] = useState(['b']);\r\n const {current:a} = useRef(['a'])\r\n useEffect(() => {\r\n setValue(['c']);\r\n }, [a])\r\n}\r\n```", "Minimize the direct definition of complex data in FC, otherwise the performance overhead will be large.（So, useRef is good）", "As suggested by @FuzzyFade it is good to use useRef to minimize performance overhead. If you want to run it only once without infinite loop. Below is another way you can achieve it using spread operator:\r\n\r\nimport React, { useEffect, useState } from 'react';\r\n\r\nexport default function Home() {\r\n const args = ['a'];\r\n const [value, setValue] = useState(['b']);\r\n\r\n useEffect(() => {\r\n setValue(['c']);\r\n }, [...args]);\r\n\r\n console.log('value', value);\r\n}", "Thanks for all the suggestions. I like the one from [this comment](https://github.com/facebook/react/issues/18243#issuecomment-596052010) the best, that uses `{ current: ref }`.", "I got around this by adding the stringified version of the array as dependency instead.\r\n\r\n```js\r\nconst a = ['a','b','c'];\r\nuseEffect(() => {...}, [a.toString]);\r\n``` \r\n\r\nThis came in handy when having that dependency inside custom hooks\r\n\r\n```js\r\nconst products = useProducts(['100-01', '100-02']);\r\n\r\nfunction useProducts(skus) {\r\n const [products, setProducts] = useState([]);\r\n useEffect(() => fetch(...).then(setProducts) , [skus.toString()]);\r\n return products;\r\n} \r\n```\r\n\r\nI guess this works because it's an array of strings, however if that would be an array of objects, I probably would then pass a reference as mentioned before." ]	2020-03-07 04:47:54	2022-07-25 08:04:51	2020-03-07 19:34:52	NONE	null	null	null	<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. --> React version: 16.13.0 ## Steps To Reproduce When the following code is run in a React component, it causes an endless loop. Passing an array as a dependency to `useEffect` (in this case, `args`), causes that to happen, but it shouldn't. I've read that I can use `[args.length]` to stop this from happening, but then the ESLint rule `react-hooks/exhaustive-deps` throws an error, so I want to avoid doing it that way. ```js import React, { useEffect, useState } from 'react'; export default function Home() { const args = ['a']; const [value, setValue] = useState(['b']); useEffect(() => { setValue(['c']); }, [args]); console.log('value', value); } ``` Notice in the code above, that I don't even use or modify `args` at all, in the `useEffect` callback. If I change the value of `args` to a string, like `const args = 'a'`, then there is no endless loop. So the problem seems to occur when the dependency is an array. ## The current behavior The page runs in an infinite loop. ## The expected behavior It should only run once.	{'url': 'https://api.github.com/repos/facebook/react/issues/18243/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18243/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18242	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18242/labels{/name}	https://api.github.com/repos/facebook/react/issues/18242/comments	https://api.github.com/repos/facebook/react/issues/18242/events	https://github.com/facebook/react/pull/18242	577,265,464	MDExOlB1bGxSZXF1ZXN0Mzg1MDk0NTE0	18,242	Add Relay Flight Build	{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18242/builds/13691) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit cb97e8ec5c904fb442c08c209bfaf55e1e36c311:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[zealous-pare-85s8p](https://codesandbox.io/s/zealous-pare-85s8p)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 7a1691cdff209249b49a4472ba87b542980a5f71...cb97e8ec5c904fb442c08c209bfaf55e1e36c311</p>\n\n\n \n## react-flight-dom-relay\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFlightDOMRelayServer-dev.js \| n/a \| n/a \| 0 B \| 7.85 KB \| 0 B \| 2.56 KB \| FB_WWW_DEV\nReactFlightDOMRelayServer-prod.js \| n/a \| n/a \| 0 B \| 4.96 KB \| 0 B \| 1.54 KB \| FB_WWW_PROD\nReactFlightDOMRelayClient-dev.js \| n/a \| n/a \| 0 B \| 5.41 KB \| 0 B \| 1.75 KB \| FB_WWW_DEV\nReactFlightDOMRelayClient-prod.js \| n/a \| n/a \| 0 B \| 4.02 KB \| 0 B \| 1.29 KB \| FB_WWW_PROD\n\n## react-client\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-client-flight.development.js \| n/a \| n/a \| 0 B \| 7.17 KB \| 0 B \| 2.24 KB \| NODE_DEV\nreact-client-flight.production.min.js \| n/a \| n/a \| 0 B \| 2.45 KB \| 0 B \| 1.16 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against cb97e8ec5c904fb442c08c209bfaf55e1e36c311\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 7a1691cdff209249b49a4472ba87b542980a5f71...cb97e8ec5c904fb442c08c209bfaf55e1e36c311</p>\n\n\n \n## react-flight-dom-relay\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFlightDOMRelayClient-dev.js \| n/a \| n/a \| 0 B \| 5.41 KB \| 0 B \| 1.75 KB \| FB_WWW_DEV\nReactFlightDOMRelayClient-prod.js \| n/a \| n/a \| 0 B \| 4.02 KB \| 0 B \| 1.29 KB \| FB_WWW_PROD\nReactFlightDOMRelayServer-dev.js \| n/a \| n/a \| 0 B \| 7.85 KB \| 0 B \| 2.56 KB \| FB_WWW_DEV\nReactFlightDOMRelayServer-prod.js \| n/a \| n/a \| 0 B \| 4.96 KB \| 0 B \| 1.54 KB \| FB_WWW_PROD\n\n## react-client\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-client-flight.development.js \| n/a \| n/a \| 0 B \| 7.18 KB \| 0 B \| 2.25 KB \| NODE_DEV\nreact-client-flight.production.min.js \| n/a \| n/a \| 0 B \| 2.46 KB \| 0 B \| 1.16 KB \| NODE_PROD\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against cb97e8ec5c904fb442c08c209bfaf55e1e36c311\n</p>\n", "Thanks!" ]	2020-03-07 02:52:01	2020-03-07 21:08:08	2020-03-07 19:23:31	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18242', 'html_url': 'https://github.com/facebook/react/pull/18242', 'diff_url': 'https://github.com/facebook/react/pull/18242.diff', 'patch_url': 'https://github.com/facebook/react/pull/18242.patch', 'merged_at': datetime.datetime(2020, 3, 7, 19, 23, 31)}	This will be used to host a Flight Server and Flight Client inside Relay. Currently, there's only an FB www build because I'm not sure how we'll want to sync it to the OSS repo yet. Most likely it'll end up being an RN build instead since RN is Relay's source of truth. We'll need another host config option for this configuration so I added `dom-relay` for that. This is currently encoding to a JSON array of strings but I'll refactor to a different format/layering in a follow up. Renamed some flight files while I was at it.	{'url': 'https://api.github.com/repos/facebook/react/issues/18242/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 3, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18242/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18241	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18241/labels{/name}	https://api.github.com/repos/facebook/react/issues/18241/comments	https://api.github.com/repos/facebook/react/issues/18241/events	https://github.com/facebook/react/pull/18241	577,226,441	MDExOlB1bGxSZXF1ZXN0Mzg1MDYzMjE5	18,241	Eager bailouts only for use state	{'login': 'Andarist', 'id': 9800850, 'node_id': 'MDQ6VXNlcjk4MDA4NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9800850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Andarist', 'html_url': 'https://github.com/Andarist', 'followers_url': 'https://api.github.com/users/Andarist/followers', 'following_url': 'https://api.github.com/users/Andarist/following{/other_user}', 'gists_url': 'https://api.github.com/users/Andarist/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Andarist/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Andarist/subscriptions', 'organizations_url': 'https://api.github.com/users/Andarist/orgs', 'repos_url': 'https://api.github.com/users/Andarist/repos', 'events_url': 'https://api.github.com/users/Andarist/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Andarist/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18241/builds/13681) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 897945fb49ed8172f5210303ca3e6a72ae0e0d25:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[sharp-night-0tygf](https://codesandbox.io/s/sharp-night-0tygf)\| Configuration \|\n\|[friendly-dubinsky-c6ut1](https://codesandbox.io/s/friendly-dubinsky-c6ut1)\| PR \|\n\|[sharp-poitras-1x07c](https://codesandbox.io/s/sharp-poitras-1x07c)\| Issue #15198 \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 4027f2a3b82ecc325224f7827fc2c8e71a284279...897945fb49ed8172f5210303ca3e6a72ae0e0d25</p>\n\n\n \n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactDOM-profiling.js \| +0.2% \| +0.1% \| 412.95 KB \| 413.59 KB \| 75.11 KB \| 75.17 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 135.28 KB \| 135.28 KB \| 34.78 KB \| 34.79 KB \| UMD_DEV\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1.15 KB \| 1.15 KB \| 654 B \| 655 B \| NODE_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.05 KB \| 20.05 KB \| 7.42 KB \| 7.42 KB \| UMD_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 55.86 KB \| 55.86 KB \| 14.46 KB \| 14.47 KB \| NODE_DEV\nreact-dom.development.js \| +0.1% \| -0.0% \| 885.67 KB \| 886.7 KB \| 195.23 KB \| 195.14 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 9.99 KB \| 9.99 KB \| 3.37 KB \| 3.37 KB \| NODE_PROD\nreact-dom.production.min.js \| :small_red_triangle:+0.1% \| 0.0% \| 116.01 KB \| 116.18 KB \| 37.17 KB \| 37.17 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.1% \| +0.1% \| 119.72 KB \| 119.89 KB \| 38.39 KB \| 38.42 KB \| UMD_PROFILING\nreact-dom.development.js \| +0.1% \| -0.0% \| 842.84 KB \| 843.82 KB \| 192.79 KB \| 192.73 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.1% \| :small_red_triangle:+0.1% \| 116.09 KB \| 116.26 KB \| 36.5 KB \| 36.53 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| 0.0% \| 20.38 KB \| 20.38 KB \| 7.53 KB \| 7.53 KB \| NODE_PROD\nreact-dom.profiling.min.js \| +0.1% \| +0.1% \| 119.95 KB \| 120.12 KB \| 37.63 KB \| 37.65 KB \| NODE_PROFILING\nReactDOM-dev.js \| +0.1% \| -0.0% \| 950.85 KB \| 951.88 KB \| 212.11 KB \| 212.04 KB \| FB_WWW_DEV\nReactDOM-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 401.18 KB \| 401.82 KB \| 72.85 KB \| 72.92 KB \| FB_WWW_PROD\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.68 KB \| 3.68 KB \| 1.33 KB \| 1.33 KB \| NODE_DEV\nReactDOMTesting-dev.js \| +0.1% \| -0.0% \| 899.95 KB \| 900.99 KB \| 201.19 KB \| 201.13 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 382.29 KB \| 382.93 KB \| 69.64 KB \| 69.7 KB \| FB_WWW_PROD\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 128.35 KB \| 128.35 KB \| 34.36 KB \| 34.36 KB \| NODE_DEV\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 53.77 KB \| 53.77 KB \| 14 KB \| 14 KB \| UMD_DEV\nReactDOMTesting-profiling.js \| +0.2% \| +0.1% \| 382.29 KB \| 382.93 KB \| 69.64 KB \| 69.7 KB \| FB_WWW_PROFILING\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 19.97 KB \| 19.97 KB \| 7.38 KB \| 7.38 KB \| NODE_PROD\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 10.94 KB \| 10.94 KB \| 4.16 KB \| 4.16 KB \| UMD_PROD\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 1.17 KB \| 1.17 KB \| 691 B \| 692 B \| UMD_PROD\nReactDOMServer-prod.js \| 0.0% \| 0.0% \| 47.49 KB \| 47.49 KB \| 11.05 KB \| 11.05 KB \| FB_WWW_PROD\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 10.79 KB \| 10.79 KB \| 4.09 KB \| 4.09 KB \| NODE_PROD\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 58.9 KB \| 58.9 KB \| 14.7 KB \| 14.7 KB \| UMD_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.26 KB \| 10.26 KB \| 3.49 KB \| 3.49 KB \| UMD_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactFabric-dev.js \| +0.1% \| -0.0% \| 615.89 KB \| 616.68 KB \| 133.23 KB \| 133.16 KB \| RN_OSS_DEV\nReactNativeRenderer-dev.js \| +0.2% \| -0.0% \| 633.94 KB \| 634.98 KB \| 137.56 KB \| 137.49 KB \| RN_OSS_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 259.8 KB \| 260.44 KB \| 45.2 KB \| 45.25 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.2% \| +0.1% \| 271.59 KB \| 272.23 KB \| 47.44 KB \| 47.5 KB \| RN_OSS_PROFILING\nReactFabric-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.1% \| 251.76 KB \| 252.4 KB \| 43.71 KB \| 43.77 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.2% \| +0.1% \| 263.56 KB \| 264.2 KB \| 45.98 KB \| 46.04 KB \| RN_OSS_PROFILING\n\n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactART-dev.js \| +0.1% \| -0.1% \| 569.13 KB \| 569.92 KB \| 119.38 KB \| 119.32 KB \| FB_WWW_DEV\nReactART-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.1% \| 233.84 KB \| 234.48 KB \| 39.73 KB \| 39.78 KB \| FB_WWW_PROD\nreact-art.development.js \| +0.1% \| -0.1% \| 616.35 KB \| 617.13 KB \| 130.17 KB \| 130.1 KB \| UMD_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.2% \| 0.0% \| 104.21 KB \| 104.38 KB \| 31.61 KB \| 31.61 KB \| UMD_PROD\nreact-art.development.js \| +0.1% \| -0.1% \| 521.24 KB \| 521.97 KB \| 112.53 KB \| 112.45 KB \| NODE_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.2% \| 69.25 KB \| 69.41 KB \| 20.79 KB \| 20.83 KB \| NODE_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactTestRenderer-dev.js \| +0.2% \| -0.1% \| 554.9 KB \| 555.93 KB \| 117.23 KB \| 117.16 KB \| FB_WWW_DEV\nreact-test-renderer-shallow.development.js \| 0.0% \| 0.0% \| 38.39 KB \| 38.39 KB \| 9.29 KB \| 9.29 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.91 KB \| 12.91 KB \| 3.93 KB \| 3.93 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.2% \| -0.1% \| 553.83 KB \| 554.86 KB \| 115.35 KB \| 115.27 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.2% \| 71.22 KB \| 71.39 KB \| 21.66 KB \| 21.69 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.2% \| -0.1% \| 527.81 KB \| 528.78 KB \| 114.04 KB \| 113.98 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 71.04 KB \| 71.2 KB \| 21.34 KB \| 21.37 KB \| NODE_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler.development.js \| +0.2% \| -0.1% \| 557.39 KB \| 558.37 KB \| 118 KB \| 117.94 KB \| NODE_DEV\nreact-reconciler-reflection.development.js \| 0.0% \| 0.0% \| 16.24 KB \| 16.24 KB \| 4.96 KB \| 4.96 KB \| NODE_DEV\nreact-reconciler.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 73.71 KB \| 73.87 KB \| 21.77 KB \| 21.79 KB \| NODE_PROD\nreact-reconciler-reflection.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 2.8 KB \| 2.8 KB \| 1.2 KB \| 1.2 KB \| NODE_PROD\nreact-reconciler-persistent.development.js \| +0.2% \| -0.1% \| 556.11 KB \| 557.08 KB \| 117.85 KB \| 117.79 KB \| NODE_DEV\nreact-reconciler-persistent.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 73.72 KB \| 73.88 KB \| 21.78 KB \| 21.8 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 897945fb49ed8172f5210303ca3e6a72ae0e0d25\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 3 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 4027f2a3b82ecc325224f7827fc2c8e71a284279...897945fb49ed8172f5210303ca3e6a72ae0e0d25</p>\n\n\n \n## react-art\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-art.development.js \| +0.1% \| -0.1% \| 635.52 KB \| 636.3 KB \| 133.57 KB \| 133.5 KB \| UMD_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.2% \| 0.0% \| 106.64 KB \| 106.81 KB \| 32.25 KB \| 32.26 KB \| UMD_PROD\nreact-art.development.js \| +0.1% \| -0.1% \| 539.67 KB \| 540.4 KB \| 115.97 KB \| 115.89 KB \| NODE_DEV\nreact-art.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 71.62 KB \| 71.79 KB \| 21.44 KB \| 21.47 KB \| NODE_PROD\nReactART-dev.js \| +0.1% \| -0.1% \| 543.41 KB \| 544.2 KB \| 114.11 KB \| 114.04 KB \| FB_WWW_DEV\nReactART-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.1% \| 226.66 KB \| 227.3 KB \| 38.52 KB \| 38.58 KB \| FB_WWW_PROD\n\n## react-native-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactNativeRenderer-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 259.81 KB \| 260.45 KB \| 45.21 KB \| 45.26 KB \| RN_OSS_PROD\nReactNativeRenderer-profiling.js \| +0.2% \| +0.1% \| 271.61 KB \| 272.25 KB \| 47.45 KB \| 47.51 KB \| RN_OSS_PROFILING\nReactFabric-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.1% \| 251.77 KB \| 252.41 KB \| 43.72 KB \| 43.78 KB \| RN_OSS_PROD\nReactFabric-profiling.js \| +0.2% \| +0.1% \| 263.57 KB \| 264.21 KB \| 45.99 KB \| 46.04 KB \| RN_OSS_PROFILING\nReactFabric-dev.js \| +0.1% \| -0.0% \| 618.62 KB \| 619.41 KB \| 133.57 KB \| 133.5 KB \| RN_FB_DEV\nReactFabric-prod.js \| :small_red_triangle:+0.3% \| :small_red_triangle:+0.1% \| 251.93 KB \| 252.57 KB \| 43.75 KB \| 43.81 KB \| RN_FB_PROD\nReactNativeRenderer-dev.js \| +0.2% \| -0.0% \| 633.96 KB \| 634.99 KB \| 137.57 KB \| 137.5 KB \| RN_OSS_DEV\nReactFabric-profiling.js \| +0.2% \| +0.1% \| 263.72 KB \| 264.36 KB \| 46.02 KB \| 46.08 KB \| RN_FB_PROFILING\nReactNativeRenderer-dev.js \| +0.2% \| -0.0% \| 636.67 KB \| 637.7 KB \| 137.91 KB \| 137.85 KB \| RN_FB_DEV\nReactNativeRenderer-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 259.96 KB \| 260.59 KB \| 45.23 KB \| 45.29 KB \| RN_FB_PROD\nReactNativeRenderer-profiling.js \| +0.2% \| +0.1% \| 271.75 KB \| 272.39 KB \| 47.48 KB \| 47.54 KB \| RN_FB_PROFILING\nReactFabric-dev.js \| +0.1% \| -0.0% \| 615.91 KB \| 616.7 KB \| 133.23 KB \| 133.17 KB \| RN_OSS_DEV\n\n## react-dom\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-dom.profiling.min.js \| +0.1% \| +0.1% \| 124.01 KB \| 124.18 KB \| 38.69 KB \| 38.73 KB \| NODE_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 58.91 KB \| 58.91 KB \| 14.71 KB \| 14.71 KB \| UMD_DEV\nReactDOM-dev.js \| +0.1% \| -0.0% \| 907.29 KB \| 908.32 KB \| 202.52 KB \| 202.45 KB \| FB_WWW_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| 0.0% \| 10.27 KB \| 10.27 KB \| 3.5 KB \| 3.5 KB \| UMD_PROD\nReactDOMServer-dev.js \| 0.0% \| 0.0% \| 137.4 KB \| 137.4 KB \| 35.11 KB \| 35.11 KB \| FB_WWW_DEV\nreact-dom-test-utils.development.js \| 0.0% \| 0.0% \| 53.78 KB \| 53.78 KB \| 14.01 KB \| 14.01 KB \| UMD_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| 0.0% \| 10.96 KB \| 10.96 KB \| 4.17 KB \| 4.17 KB \| UMD_PROD\nReactDOMTesting-dev.js \| +0.1% \| -0.0% \| 873.31 KB \| 874.35 KB \| 195.61 KB \| 195.55 KB \| FB_WWW_DEV\nReactDOMTesting-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 368.74 KB \| 369.38 KB \| 67.46 KB \| 67.51 KB \| FB_WWW_PROD\nReactDOMTesting-profiling.js \| +0.2% \| +0.1% \| 368.74 KB \| 369.38 KB \| 67.46 KB \| 67.51 KB \| FB_WWW_PROFILING\nreact-dom-server.node.development.js \| 0.0% \| 0.0% \| 131.08 KB \| 131.08 KB \| 34.83 KB \| 34.84 KB \| NODE_DEV\nreact-dom-test-utils.production.min.js \| 0.0% \| -0.0% \| 10.81 KB \| 10.81 KB \| 4.1 KB \| 4.1 KB \| NODE_PROD\nreact-dom-server.node.production.min.js \| 0.0% \| 0.0% \| 20.83 KB \| 20.83 KB \| 7.61 KB \| 7.61 KB \| NODE_PROD\nreact-dom.development.js \| +0.1% \| -0.0% \| 914.35 KB \| 915.39 KB \| 200.16 KB \| 200.08 KB \| UMD_DEV\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 136.87 KB \| 136.87 KB \| 34.99 KB \| 34.99 KB \| UMD_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.1% \| 0.0% \| 119.89 KB \| 120.05 KB \| 38.28 KB \| 38.3 KB \| UMD_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.51 KB \| 20.51 KB \| 7.51 KB \| 7.51 KB \| UMD_PROD\nreact-dom.profiling.min.js \| +0.1% \| -0.0% \| 123.71 KB \| 123.88 KB \| 39.53 KB \| 39.53 KB \| UMD_PROFILING\nreact-dom.development.js \| +0.1% \| -0.0% \| 870.34 KB \| 871.32 KB \| 197.7 KB \| 197.63 KB \| NODE_DEV\nreact-dom-server.browser.development.js \| 0.0% \| 0.0% \| 129.87 KB \| 129.87 KB \| 34.58 KB \| 34.58 KB \| NODE_DEV\nreact-dom.production.min.js \| :small_red_triangle:+0.1% \| 0.0% \| 120.04 KB \| 120.21 KB \| 37.53 KB \| 37.54 KB \| NODE_PROD\nreact-dom-server.browser.production.min.js \| 0.0% \| 0.0% \| 20.43 KB \| 20.43 KB \| 7.46 KB \| 7.46 KB \| NODE_PROD\nReactDOM-prod.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 376.26 KB \| 376.9 KB \| 68.37 KB \| 68.42 KB \| FB_WWW_PROD\nReactDOMServer-prod.js \| 0.0% \| 0.0% \| 46.78 KB \| 46.78 KB \| 10.87 KB \| 10.87 KB \| FB_WWW_PROD\nReactDOM-profiling.js \| +0.2% \| +0.1% \| 387.95 KB \| 388.59 KB \| 70.54 KB \| 70.6 KB \| FB_WWW_PROFILING\nreact-dom-unstable-native-dependencies.development.js \| 0.0% \| 0.0% \| 55.87 KB \| 55.87 KB \| 14.47 KB \| 14.47 KB \| NODE_DEV\nreact-dom-unstable-fizz.node.development.js \| 0.0% \| +0.1% \| 3.69 KB \| 3.69 KB \| 1.34 KB \| 1.34 KB \| NODE_DEV\nreact-dom-unstable-native-dependencies.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 10 KB \| 10 KB \| 3.37 KB \| 3.38 KB \| NODE_PROD\nreact-dom-unstable-fizz.node.production.min.js \| 0.0% \| :small_red_triangle:+0.2% \| 1.16 KB \| 1.16 KB \| 663 B \| 664 B \| NODE_PROD\nreact-dom-unstable-fizz.browser.development.js \| 0.0% \| +0.1% \| 3.35 KB \| 3.35 KB \| 1.27 KB \| 1.27 KB \| UMD_DEV\nreact-dom-unstable-fizz.browser.production.min.js \| 0.0% \| :small_red_triangle:+0.1% \| 1.19 KB \| 1.19 KB \| 699 B \| 700 B \| UMD_PROD\n\n## react-test-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nReactTestRenderer-dev.js \| +0.2% \| -0.1% \| 554.91 KB \| 555.95 KB \| 117.23 KB \| 117.16 KB \| FB_WWW_DEV\nreact-test-renderer-shallow.development.js \| 0.0% \| 0.0% \| 38.4 KB \| 38.4 KB \| 9.3 KB \| 9.3 KB \| UMD_DEV\nreact-test-renderer-shallow.production.min.js \| 0.0% \| 0.0% \| 12.92 KB \| 12.92 KB \| 3.94 KB \| 3.94 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.2% \| -0.1% \| 553.85 KB \| 554.89 KB \| 115.37 KB \| 115.29 KB \| UMD_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.2% \| 71.25 KB \| 71.41 KB \| 21.67 KB \| 21.7 KB \| UMD_PROD\nreact-test-renderer.development.js \| +0.2% \| -0.1% \| 527.83 KB \| 528.81 KB \| 114.05 KB \| 114 KB \| NODE_DEV\nreact-test-renderer.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 71.06 KB \| 71.23 KB \| 21.36 KB \| 21.38 KB \| NODE_PROD\n\n## react-reconciler\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-reconciler-persistent.development.js \| +0.2% \| -0.1% \| 556.12 KB \| 557.1 KB \| 117.86 KB \| 117.79 KB \| NODE_DEV\nreact-reconciler-reflection.development.js \| 0.0% \| 0.0% \| 16.25 KB \| 16.25 KB \| 4.97 KB \| 4.97 KB \| NODE_DEV\nreact-reconciler-persistent.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 73.73 KB \| 73.9 KB \| 21.78 KB \| 21.81 KB \| NODE_PROD\nreact-reconciler.development.js \| +0.2% \| -0.1% \| 578.15 KB \| 579.12 KB \| 121.89 KB \| 121.81 KB \| NODE_DEV\nreact-reconciler.production.min.js \| :small_red_triangle:+0.2% \| :small_red_triangle:+0.1% \| 76.48 KB \| 76.65 KB \| 22.44 KB \| 22.46 KB \| NODE_PROD\n\n </details>\n \n\nReactDOM: size: 0.0%, gzip: 0.0%\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 897945fb49ed8172f5210303ca3e6a72ae0e0d25\n</p>\n", "So we've been looking at this. It's probably the right thing to do. But it's a scary change. So we'd want it behind a flag. The current implementation in this PR would be hard to put behind a flag. It would also be hard to maintain two versions in one place.\r\n\r\nWe plan to fork the reconciler with a few other breaking and more ambitious changes. So we'll probably fix this as a part of that refactor. Thank you for starting this work though (and for flagging the issue in the first place). It's been really helpful." ]	2020-03-06 23:23:32	2020-04-02 07:47:25	2020-04-01 22:35:48	CONTRIBUTOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18241', 'html_url': 'https://github.com/facebook/react/pull/18241', 'diff_url': 'https://github.com/facebook/react/pull/18241.diff', 'patch_url': 'https://github.com/facebook/react/pull/18241.patch', 'merged_at': None}	## Summary fixes #15088 closes #15198 I've stumbled upon an edge case where bailed out actions were kept in the update queue and could be applied using the newly rendered reducer during future rerender. This can be observed here - https://codesandbox.io/s/silly-paper-22org . Just click the disable button, click the increment button multiple times and click the disable button once again. The counter will jump to the number of times you have clicked on the incrementing button while it really should still show 0. @sebmarkbage has suggested ditching the eager bailout optimization for the useReducer case altogether [here](https://github.com/facebook/react/pull/15198#issuecomment-561364762) and @gaearon has [recently encouraged me](https://github.com/facebook/react/pull/15198#issuecomment-593970984) to just follow this suggestion. @sebmarkbage has also suggested that "We should also forbid suspending in a setState reducer.", but I'm not sure what that means exactly and how it should be approached so any tips regarding that would be highly appreciated. As to the implementation - I've managed to remove the need to store "lastRenderedReducer" at all and also I've decided to only append updates to the queue if the rerender is scheduled. In the current implementation on the master branch, the queue was slightly prone to a minor memory leak because theoretically, it was possible to append bailed out updates until the next rerender and that, theoretically, could never happen. This is not a real-life scenario, but it still seems better to avoid appending to the queue unnecessarily to avoid going through those updates during the next render. ## Test Plan I've run tests, lint & flow dom tasks before sending this as PR.	{'url': 'https://api.github.com/repos/facebook/react/issues/18241/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18241/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18240	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18240/labels{/name}	https://api.github.com/repos/facebook/react/issues/18240/comments	https://api.github.com/repos/facebook/react/issues/18240/events	https://github.com/facebook/react/pull/18240	577,220,345	MDExOlB1bGxSZXF1ZXN0Mzg1MDU4MjAz	18,240	Refactor Host Config Infra (getting rid of .inline*.js)	{'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18240/builds/13678) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit fd4699d18bd5a8007749b37a6f41a8433a95578d:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[heuristic-hertz-hmurl](https://codesandbox.io/s/heuristic-hertz-hmurl)\| Configuration \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fd4699d18bd5a8007749b37a6f41a8433a95578d\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against fd4699d18bd5a8007749b37a6f41a8433a95578d\n</p>\n", "Oh, this also delete react-reconciler/persistent since that's just a flag on host config now." ]	2020-03-06 23:02:04	2020-03-07 00:20:44	2020-03-07 00:20:43	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18240', 'html_url': 'https://github.com/facebook/react/pull/18240', 'diff_url': 'https://github.com/facebook/react/pull/18240.diff', 'patch_url': 'https://github.com/facebook/react/pull/18240.patch', 'merged_at': datetime.datetime(2020, 3, 7, 0, 20, 43)}	I kept forgetting what the various .inline files are supposed to do, and it made it hard to add more combinations. The first thing this does is getting rid of the various renderer depending on the indirection pseudo entry point (inline.dom.js etc). Instead we just deep require the reconciler. We do this for other files anyway and there's nothing really preventing this. Instead, we can just use the entry-point of the actual renderer as the jest hook to initialize the correct host config. The actual react-reconciler/index.js entry point should only represent the public API (currently a function wrapper published to npm). Not used by us. There are no longer any untyped files so we don't need the special inline-typed form. The untyped files caused some uncertainty since once an untyped file gets into the system it leaks the any all over the place. It also wasn't a sufficient approach (I had some hacks to hide DOM). Instead, for Flow, in this approach we explicitly select which paths we want to check for each renderer. The inverse gets ignored. So every path is still covered by some renderer. These ignores are not untyped so if a dependency accidentally tries to reach into something that isn't covered, then that will be an error. Not silently leak "any".	{'url': 'https://api.github.com/repos/facebook/react/issues/18240/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18240/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18239	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18239/labels{/name}	https://api.github.com/repos/facebook/react/issues/18239/comments	https://api.github.com/repos/facebook/react/issues/18239/events	https://github.com/facebook/react/pull/18239	577,117,129	MDExOlB1bGxSZXF1ZXN0Mzg0OTczNTYy	18,239	Hard-code disableModulePatternComponents in tests	{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "\n<!--\n 0 failure: \n 1 warning: Base commit is br...\n \n 1 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\">Warnings</th>\n </tr>\n </thead>\n <tbody><tr>\n <td>:warning:</td>\n <td>Base commit is broken: 562cf013dbd80cade517e25192ee19e958aef55b</td>\n </tr>\n </tbody>\n</table>\n\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b6c6eb27421c1bc9cdd90c26c9a52f83f4aa690d\n</p>\n", "\n<!--\n 0 failure: \n 1 warning: Base commit is br...\n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n<table>\n <thead>\n <tr>\n <th width=\"50\"></th>\n <th width=\"100%\" data-danger-table=\"true\">Warnings</th>\n </tr>\n </thead>\n <tbody><tr>\n <td>:warning:</td>\n <td>Base commit is broken: 562cf013dbd80cade517e25192ee19e958aef55b</td>\n </tr>\n </tbody>\n</table>\n\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b6c6eb27421c1bc9cdd90c26c9a52f83f4aa690d\n</p>\n", "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18239/builds/13640) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit b6c6eb27421c1bc9cdd90c26c9a52f83f4aa690d:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[dank-resonance-e378n](https://codesandbox.io/s/dank-resonance-e378n)\| Configuration \|\n", "Oops sorry. I didn't realize it wouldn't merge.", "That's fine! Two PRs just happened to land around the same time" ]	2020-03-06 19:02:30	2020-03-06 19:19:33	2020-03-06 19:09:37	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18239', 'html_url': 'https://github.com/facebook/react/pull/18239', 'diff_url': 'https://github.com/facebook/react/pull/18239.diff', 'patch_url': 'https://github.com/facebook/react/pull/18239.patch', 'merged_at': datetime.datetime(2020, 3, 6, 19, 9, 37)}	Hard-coding this until tests are fixed, to unblock master.	{'url': 'https://api.github.com/repos/facebook/react/issues/18239/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18239/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18238	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18238/labels{/name}	https://api.github.com/repos/facebook/react/issues/18238/comments	https://api.github.com/repos/facebook/react/issues/18238/events	https://github.com/facebook/react/pull/18238	577,108,637	MDExOlB1bGxSZXF1ZXN0Mzg0OTY2NTgw	18,238	Bugfix: Dropped effects in Legacy Mode Suspense	{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False}	[{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None} {'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}]	closed	false	null	[]	null	[ "This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18238/builds/13635) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commit 3d0cfef932d749c10f347b5d83fed0972dd87902:\n\n\|Sandbox\| Source \|\n\|--\|--\|\n\|[great-visvesvaraya-ej9lk](https://codesandbox.io/s/great-visvesvaraya-ej9lk)\| Configuration \|\n\|[infallible-curran-fgp83](https://codesandbox.io/s/infallible-curran-fgp83)\| PR \|\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 115cd12d9bbb2bff303e52feb1394e3a2cef20ca...3d0cfef932d749c10f347b5d83fed0972dd87902</p>\n\n\n \n## react-noop-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-noop-renderer-flight-client.production.min.js \| 0.0% \| -0.3% \| 513 B \| 513 B \| 379 B \| 378 B \| NODE_PROD\nreact-noop-renderer.development.js \| +2.4% \| +0.5% \| 29.28 KB \| 29.98 KB \| 5.76 KB \| 5.79 KB \| NODE_DEV\nreact-noop-renderer.production.min.js \| :small_red_triangle:+2.7% \| :small_red_triangle:+0.9% \| 12 KB \| 12.33 KB \| 3.57 KB \| 3.61 KB \| NODE_PROD\nreact-noop-renderer-server.development.js \| 0.0% \| -0.3% \| 1.59 KB \| 1.59 KB \| 749 B \| 747 B \| NODE_DEV\nreact-noop-renderer-server.production.min.js \| 0.0% \| -0.4% \| 840 B \| 840 B \| 472 B \| 470 B \| NODE_PROD\nreact-noop-renderer-flight-client.development.js \| 0.0% \| -0.3% \| 1.18 KB \| 1.18 KB \| 616 B \| 614 B \| NODE_DEV\nreact-noop-renderer-persistent.development.js \| +2.0% \| +0.2% \| 29.33 KB \| 29.92 KB \| 5.78 KB \| 5.79 KB \| NODE_DEV\nreact-noop-renderer-persistent.production.min.js \| :small_red_triangle:+2.3% \| :small_red_triangle:+0.6% \| 12.02 KB \| 12.3 KB \| 3.58 KB \| 3.6 KB \| NODE_PROD\nreact-noop-renderer-flight-server.development.js \| 0.0% \| -0.2% \| 1.73 KB \| 1.73 KB \| 803 B \| 801 B \| NODE_DEV\nreact-noop-renderer-flight-server.production.min.js \| 0.0% \| -0.4% \| 946 B \| 946 B \| 526 B \| 524 B \| NODE_PROD\n\n </details>\n \n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3d0cfef932d749c10f347b5d83fed0972dd87902\n</p>\n", "\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 115cd12d9bbb2bff303e52feb1394e3a2cef20ca...3d0cfef932d749c10f347b5d83fed0972dd87902</p>\n\n\n \n## react-noop-renderer\nFile \| Filesize Diff \| Gzip Diff \| Prev Size \| Current Size \| Prev Gzip \| Current Gzip \| ENV\n --- \| --- \| --- \| --- \| --- \| --- \| --- \| --- \nreact-noop-renderer-flight-server.development.js \| 0.0% \| -0.2% \| 1.75 KB \| 1.75 KB \| 813 B \| 811 B \| NODE_DEV\nreact-noop-renderer-flight-server.production.min.js \| 0.0% \| -0.4% \| 959 B \| 959 B \| 536 B \| 534 B \| NODE_PROD\nreact-noop-renderer-server.development.js \| 0.0% \| -0.1% \| 1.61 KB \| 1.61 KB \| 757 B \| 756 B \| NODE_DEV\nreact-noop-renderer-server.production.min.js \| 0.0% \| -0.2% \| 853 B \| 853 B \| 480 B \| 479 B \| NODE_PROD\nreact-noop-renderer-persistent.development.js \| +2.0% \| +0.2% \| 29.34 KB \| 29.93 KB \| 5.78 KB \| 5.8 KB \| NODE_DEV\nreact-noop-renderer-persistent.production.min.js \| :small_red_triangle:+2.3% \| :small_red_triangle:+0.5% \| 12.04 KB \| 12.31 KB \| 3.59 KB \| 3.61 KB \| NODE_PROD\nreact-noop-renderer.development.js \| +2.4% \| +0.5% \| 29.3 KB \| 29.99 KB \| 5.77 KB \| 5.8 KB \| NODE_DEV\nreact-noop-renderer-flight-client.development.js \| 0.0% \| -0.3% \| 1.2 KB \| 1.2 KB \| 625 B \| 623 B \| NODE_DEV\nreact-noop-renderer.production.min.js \| :small_red_triangle:+2.7% \| :small_red_triangle:+0.9% \| 12.01 KB \| 12.34 KB \| 3.58 KB \| 3.61 KB \| NODE_PROD\nreact-noop-renderer-flight-client.production.min.js \| 0.0% \| -0.5% \| 526 B \| 526 B \| 388 B \| 386 B \| NODE_PROD\n\n </details>\n \n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3d0cfef932d749c10f347b5d83fed0972dd87902\n</p>\n" ]	2020-03-06 18:44:05	2020-03-06 19:10:03	2020-03-06 19:10:02	COLLABORATOR	null	false	{'url': 'https://api.github.com/repos/facebook/react/pulls/18238', 'html_url': 'https://github.com/facebook/react/pull/18238', 'diff_url': 'https://github.com/facebook/react/pull/18238.diff', 'patch_url': 'https://github.com/facebook/react/pull/18238.patch', 'merged_at': datetime.datetime(2020, 3, 6, 19, 10, 2)}	In legacy mode, a component that suspends bails out and commit in its previous state. If the component previously had mounted effects, we must transfer those to the work-in-progress so they don't get dropped. Bug report: https://codesandbox.io/s/charming-almeida-k6tdv	{'url': 'https://api.github.com/repos/facebook/react/issues/18238/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18238/timeline	null	null	true
https://api.github.com/repos/facebook/react/issues/18237	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18237/labels{/name}	https://api.github.com/repos/facebook/react/issues/18237/comments	https://api.github.com/repos/facebook/react/issues/18237/events	https://github.com/facebook/react/issues/18237	577,011,997	MDU6SXNzdWU1NzcwMTE5OTc=	18,237	Why not using a loop?	{'login': 'kerolloz', 'id': 36763164, 'node_id': 'MDQ6VXNlcjM2NzYzMTY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/36763164?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kerolloz', 'html_url': 'https://github.com/kerolloz', 'followers_url': 'https://api.github.com/users/kerolloz/followers', 'following_url': 'https://api.github.com/users/kerolloz/following{/other_user}', 'gists_url': 'https://api.github.com/users/kerolloz/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kerolloz/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kerolloz/subscriptions', 'organizations_url': 'https://api.github.com/users/kerolloz/orgs', 'repos_url': 'https://api.github.com/users/kerolloz/repos', 'events_url': 'https://api.github.com/users/kerolloz/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kerolloz/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "This looks like a weird way of writing code.", "> Is there a reason for doing it this way and not using a loop?\r\n\r\nSubjective preference. :smile:\r\n\r\n> should I open a PR and refactor it to use a loop?\r\n\r\nNo. There isn't really any objective benefit for rewriting this section of code.\r\n\r\nThank you for offering though." ]	2020-03-06 15:42:08	2020-03-07 00:26:15	2020-03-07 00:26:05	CONTRIBUTOR	null	null	null	I don't understand why this file is written the way it is https://github.com/facebook/react/blob/4027f2a3b82ecc325224f7827fc2c8e71a284279/packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js#L233-L349 Is there a reason for doing it this way and not using a loop? should I open a PR and refactor it to use a loop?	{'url': 'https://api.github.com/repos/facebook/react/issues/18237/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18237/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18236	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18236/labels{/name}	https://api.github.com/repos/facebook/react/issues/18236/comments	https://api.github.com/repos/facebook/react/issues/18236/events	https://github.com/facebook/react/issues/18236	576,977,224	MDU6SXNzdWU1NzY5NzcyMjQ=	18,236	Bug: React-Devtools not recognizing specific webapp in firefox	{'login': 'joepio', 'id': 2183313, 'node_id': 'MDQ6VXNlcjIxODMzMTM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2183313?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/joepio', 'html_url': 'https://github.com/joepio', 'followers_url': 'https://api.github.com/users/joepio/followers', 'following_url': 'https://api.github.com/users/joepio/following{/other_user}', 'gists_url': 'https://api.github.com/users/joepio/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/joepio/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/joepio/subscriptions', 'organizations_url': 'https://api.github.com/users/joepio/orgs', 'repos_url': 'https://api.github.com/users/joepio/repos', 'events_url': 'https://api.github.com/users/joepio/events{/privacy}', 'received_events_url': 'https://api.github.com/users/joepio/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "Duplicate of: #17997 " ]	2020-03-06 14:45:23	2020-03-06 22:14:29	2020-03-06 22:14:29	NONE	null	null	null	React version: 16.11.0 Firefox: 73.0.1 OS: MacOS 10.15.3 Project: [argu.co](https://argu.co) ## Steps To Reproduce 1. Open [argu.co](https://argu.co) in Firefox 73.01 on a Mac with Devtools installed 2. Open devtools (cmd + opt + i), no react devtools shown Other react pages work fine in Firefox, and argu.co works fine in Chrome, too!	{'url': 'https://api.github.com/repos/facebook/react/issues/18236/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0}	https://api.github.com/repos/facebook/react/issues/18236/timeline	null	completed	false
https://api.github.com/repos/facebook/react/issues/18235	https://api.github.com/repos/facebook/react	https://api.github.com/repos/facebook/react/issues/18235/labels{/name}	https://api.github.com/repos/facebook/react/issues/18235/comments	https://api.github.com/repos/facebook/react/issues/18235/events	https://github.com/facebook/react/issues/18235	576,949,747	MDU6SXNzdWU1NzY5NDk3NDc=	18,235	Bug: [eslint-plugin-react-hooks] - exhaustive-deps autofix not working after 2.4.0	{'login': 'melloc01', 'id': 4994258, 'node_id': 'MDQ6VXNlcjQ5OTQyNTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4994258?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/melloc01', 'html_url': 'https://github.com/melloc01', 'followers_url': 'https://api.github.com/users/melloc01/followers', 'following_url': 'https://api.github.com/users/melloc01/following{/other_user}', 'gists_url': 'https://api.github.com/users/melloc01/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/melloc01/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/melloc01/subscriptions', 'organizations_url': 'https://api.github.com/users/melloc01/orgs', 'repos_url': 'https://api.github.com/users/melloc01/repos', 'events_url': 'https://api.github.com/users/melloc01/events{/privacy}', 'received_events_url': 'https://api.github.com/users/melloc01/received_events', 'type': 'User', 'site_admin': False}	[{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}]	closed	false	null	[]	null	[ "@melloc01 I'm facing exactly the same problem, I had to use eslint CLI to add them automatically.", "I have the same problem. IntelliJ Idea is not showing me autofix options anymore. \r\nBut VS Code is showing the autofix.\r\n\r\npackage.json\r\n```\r\n \"dependencies\": {\r\n \"@zeit/next-sass\": \"^1.0.1\",\r\n \"next\": \"9.3.0\",\r\n \"node-sass\": \"^4.13.1\",\r\n \"react\": \"16.13.0\",\r\n \"react-dates\": \"^21.8.0\",\r\n \"react-dom\": \"16.13.0\",\r\n \"react-redux\": \"^7.2.0\",\r\n \"redux\": \"^4.0.5\"\r\n },\r\n \"devDependencies\": {\r\n \"@types/node\": \"^13.9.0\",\r\n \"@types/react\": \"^16.9.23\",\r\n \"@types/react-dates\": \"^17.1.10\",\r\n \"@types/react-dom\": \"^16.9.5\",\r\n \"@types/react-redux\": \"^7.1.7\",\r\n \"@typescript-eslint/eslint-plugin\": \"^2.23.0\",\r\n \"@typescript-eslint/parser\": \"^2.23.0\",\r\n \"eslint\": \"^6.8.0\",\r\n \"eslint-plugin-react\": \"^7.19.0\",\r\n \"eslint-plugin-react-hooks\": \"^2.5.0\",\r\n \"eslint-plugin-typescript\": \"^0.14.0\",\r\n \"typescript\": \"^3.8.3\",\r\n \"typescript-eslint-parser\": \"^22.0.0\",\r\n \"webpack-filter-warnings-plugin\": \"^1.2.1\"\r\n }\r\n```\r\n\r\n.eslintrc\r\n```\r\n{\r\n \"parser\": \"@typescript-eslint/parser\",\r\n \"plugins\": [\r\n \"@typescript-eslint\",\r\n \"react-hooks\"\r\n ],\r\n \"extends\": [\r\n \"eslint:recommended\",\r\n \"plugin:@typescript-eslint/eslint-recommended\",\r\n \"plugin:@typescript-eslint/recommended\",\r\n \"plugin:react/recommended\"\r\n ],\r\n \"parserOptions\": {\r\n \"ecmaVersion\": 2020,\r\n \"sourceType\": \"module\",\r\n \"jsx\": true\r\n },\r\n \"settings\": {\r\n \"react\": {\r\n \"version\": \"detect\"\r\n }\r\n },\r\n \"rules\": {\r\n \"react-hooks/rules-of-hooks\": \"error\",\r\n \"react-hooks/exhaustive-deps\": \"error\"\r\n }\r\n}\r\n```\r\n\r\n\r\nVS Code:\r\n<img width=\"609\" alt=\"image\" src=\"https://user-images.githubusercontent.com/820946/76535537-56e7ac80-647b-11ea-9bf7-f403e473cabb.png\">\r\n\r\nIntelliJ Idea:\r\n<img width=\"502\" alt=\"image\" src=\"https://user-images.githubusercontent.com/820946/76535618-6ebf3080-647b-11ea-8a36-97dcb78ec919.png\">\r\n", "This is not a bug. We disabled the autofix because it [created issues](https://github.com/facebook/react/issues/16313#issuecomment-586937673) and wasn't consistent with people's expectations for ESLint autofix. Instead, we implemented the same functionality using the ESLint Suggestions API which was added in ESLint 6.7.0. You'll need to wait for your IDE to support it: https://github.com/facebook/react/issues/18099#issuecomment-591647127\r\n\r\nVS Code ESLint plugin already supports it.", "Not sure I am following here, I am using vscode and can now semi-manually fix the issue through the UI (understand that eslint will fill the dep array automatically if I click to fix it as shown in https://github.com/facebook/react/issues/18235#issuecomment-598240282). \r\n\r\nIs there a way for this to be done automatically as part of auto-fixable problems like it used to be?\r\n\r\nI have auto-fix on save enabled and I find it saves me a lot of time compared to clicking the UI to fix the problem. \r\n\r\nAs a side note, I barely ever had problems with the suggested fix before, one may always disable the rule for the line if needed. \r\n", ">Is there a way for this to be done automatically as part of auto-fixable problems like it used to be?\r\n\r\nNo, and intentionally so. This fix changes the behavior — in some cases, potentially introducing infinite loops. It's not safe to apply automatically. You need to read the suggestion and check if it makes sense. (When it doesn't, you usually need to fix other code rather than disable the rule btw.)", ">it saves me a lot of time compared to clicking the UI to fix the problem.\r\n\r\nI think `Cmd+.` expands suggestions in VS Code so you don't have to click. Regardless, this is a UI problem that VS Code can solve, e.g. by adding an easier way to iterate through a list of problems.", "Yes.. I stumbled upon the \"infinite loop\" problem caused by this rule quite a few times.\r\n\r\nWhile it had its issues, we programmers tend to get used to it and use it in our favor - (_Ok! Fill it for me and I'll review it_) - but I agree it should be a suggestion, it is just that we have to work on that muscle memory and get used to the new behavior.\r\n\r\nThanks @gaearon ", "I'm adding autofix back behind an appropriately named option for people who really need it. Note: if your IDE or lint setup actually fixes it automatically, you do not want this. This is only for people who use older IDEs that don't yet support Suggestions and who don't run this as an automatic step.\r\n\r\nhttps://github.com/facebook/react/pull/18437", "Hi @gaearon!\r\n\r\nIn your PR #18437 you write:\r\n\r\n> If you actually apply fix suggestions automatically, you don't want to enable this.\r\n\r\nand in your comment above you write that you are adding autofix back, which confuses me a bit.\r\n\r\n\r\nI'm currently autofixinig my lint errors using\r\n```\r\n\"editor.codeActionsOnSave\": {\r\n \"source.fixAll\": true,\r\n},\r\n```\r\nwhich works wonders for all my lint errors except `react-hooks/exhaustive-deps`.\r\n\r\n\r\nI have `\"eslint-plugin-react-hooks\": \"^3.0.0\"` and latest version of `vscode-eslint`.\r\n\r\nNow, if I want to have autofix for exhausive deps, should I add `enableDangerousAutofixThisMayCauseInfiniteLoops`? And how do I add it?\r\n\r\nI've tried\r\n```\r\n\"rules\": {\r\n ...\r\n \"react-hooks/exhaustive-deps\": [1, { \"enableDangerousAutofixThisMayCauseInfiniteLoops \": true }],\r\n ...\r\n}\r\n```\r\n\r\nBut ESLint just tells me\r\n```\r\nConfiguration for rule \"react-hooks/exhaustive-deps\" is invalid: Value {\"enableDangerousAutofixThisMayCauseInfiniteLoops\":true} should NOT have additional properties.`\r\n```\r\n\r\nI've also tried \r\n```\r\n\"rules\": {\r\n ...\r\n \"react-hooks/exhaustive-deps\": [{ \"enableDangerousAutofixThisMayCauseInfiniteLoops \": true }],\r\n ...\r\n}\r\n```\r\n\r\nBut get\r\n```\r\nConfiguration for rule \"react-hooks/exhaustive-deps\" is invalid: \tSeverity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '{ \"enableDangerousAutofixThisMayCauseInfiniteLoops \": true }').\r\n```", "Maybe we need this PR #18555 by @osdnk to go through first? It's currently blocked.", "ping @gaearon ", "@FrimJo \r\n\r\n>>If you actually apply fix suggestions automatically, you don't want to enable this.\r\n\r\n>and in your comment above you write that you are adding autofix back, which confuses me a bit.\r\n\r\nI am only adding it back behind a scary option because at FB, we have a custom ESLint VS Code extension that:\r\n\r\n1) never applies \"autofix\" on save\r\n2) only supports \"autofix\" as interactive suggestions (and doesn't support Suggestions API yet)\r\n\r\nSo I'm adding this as a workaround, but we only use it because we don't autofix on save.\r\n\r\n", ">I'm currently autofixinig my lint errors using\r\n\r\nAgain, you don't want to \"autofix\" this rule on save. This is a mistake. It will lead to problems. This rule is meant to be applied manually, with careful consideration in each case.\r\n\r\n(The concrete reason this option doesn't work though is because we haven't cut a release with it yet)", "This isn't a mistake worse than typing `while (true) {}` and hitting save.\r\n\r\nWhen we are working with hooks with deps, we write an empty deps array, hit save, check how our code works, and if it causes an infinite loop or something we disable the rule and manually manage the deps.\r\n\r\nWe have an app with 358 components (all using hooks) and we disabled the rule just 3 times. The autofix works almost all the time and when it doesn't work it never causes anything catastrophic.\r\n\r\nIf people are autofixing on commit/push/etc. and debugging for hours, I'd say the problem lies with their DX. The errors should always appear on the IDE and autofixing should always happen on save and not magically with a commit hook or something.\r\n\r\nI understand that this isn't really an autofix since autofixes should not change functionality, but there's no other way to do this as easy as turning on `enableDangerousAutofixThisMayCauseInfiniteLoops` and hitting save.\r\n\r\nIf we didn't have `enableDangerousAutofixThisMayCauseInfiniteLoops` our DX with hooks would be significantly worse, so many many thanks for spending the time bringing this back and please keep supporting it until VSCode provides a way to apply the suggestion on save.", "@FrimJo Just in case if you didn't find why it's not working or for the benefit of others who will try it — there is a SPACE after option name `\"enableDangerousAutofixThisMayCauseInfiniteLoops \"`! If you remove it or remove quotes, everything will work.", "Any update on this?", "@azz0r What exactly are you expecting to be updated? They started using code actions for this fix, if you want an old behavior, enable `enableDangerousAutofixThisMayCauseInfiniteLoops` option in eslint config.", "From Amcsi comment in CRA: \r\n\r\nThey made it so `react-hooks/exhaustive-deps` does not autofix anymore by default.\r\n\r\nTo get autofixing to function add the following rule to your eslint\r\n```\r\n{\r\n ...\r\n \"rules\": {\r\n \"react-hooks/exhaustive-deps\": [\r\n \"warn\",\r\n {\r\n \"enableDangerousAutofixThisMayCauseInfiniteLoops\": true\r\n }\r\n ]\r\n }\r\n },\r\n```\r\n\r\nIt works as well as it ever did!", "I only had infinite loop once through those years and the autofix was off (happened some days ago), I've just accepted the suggestion automatically without questioning as my muscular memory taught me after the autofix was remove lol\r\n\r\nActivated the autofix because the error is easy to spot and to know where it's happening, and it's very rare to happen. For my case, it was a key generator for each render; so I changed from state + 1 to Date.now().", "Sorry to necropost, but one thing that I haven't seen discussed in this thread: the autofix will overwrite any dependencies already in place, so if you have one that isn't used in the effect, but you're using to trigger the effect, you'll lose it. This is kind of a weird example, but:\r\n\r\n```ts\r\nReact.useEffect(() => {\r\n console.log(`networkStatus for ${entity} changed.`);\r\n}, [networkStatus]);\r\n```" ]	2020-03-06 13:59:13	2022-05-05 18:23:10	2020-03-12 15:38:37	NONE	null	null	null	Hi there, after upgrading to the latest version the autofix does not automatically includes the missing deps, is this the expected behavior? I didn't find any release notes of the lib so I couldn't check if that was expected, also, I'd say, if done on purpose, this change should be on a major version, shouldn't it? ## The current behavior 2.4.0 or above Some deps are missing. ![image](https://user-images.githubusercontent.com/4994258/76088672-2ee9dc00-5f97-11ea-988a-8b6bb36c74d0.png) Quick fix shows: ![image](https://user-images.githubusercontent.com/4994258/76088711-42954280-5f97-11ea-990c-5a113b27013b.png) `eslint --fix` shows: ![image](https://user-images.githubusercontent.com/4994258/76088908-99028100-5f97-11ea-81e7-1a9fe4175881.png) But code is not being updated, although if I manually click it add the missing deps. ## Expected behavior, 2.3.0 Noticed it shows another context menu: ![image](https://user-images.githubusercontent.com/4994258/76089526-918fa780-5f98-11ea-9b88-6d88a0550c8c.png) Also it does add the missing deps using the same `eslint --fix` command.	{'url': 'https://api.github.com/repos/facebook/react/issues/18235/reactions', 'total_count': 13, '+1': 10, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 3}	https://api.github.com/repos/facebook/react/issues/18235/timeline	null	completed	false