url
stringlengths 56
56
| repository_url
stringclasses 1
value | labels_url
stringlengths 70
70
| comments_url
stringlengths 65
65
| events_url
stringlengths 63
63
| html_url
stringlengths 44
46
| id
int64 570M
2.28B
| node_id
stringlengths 18
32
| number
int64 18.1k
29k
| title
stringlengths 1
570
| user
stringlengths 854
1.31k
| labels
stringclasses 293
values | state
stringclasses 2
values | locked
bool 2
classes | assignee
stringclasses 263
values | assignees
stringclasses 287
values | milestone
float64 | comments
sequencelengths 0
30
| created_at
stringlengths 19
19
| updated_at
stringlengths 19
19
| closed_at
stringlengths 19
19
⌀ | author_association
stringclasses 4
values | active_lock_reason
stringclasses 3
values | draft
bool 2
classes | pull_request
stringlengths 277
316
⌀ | body
stringlengths 1
43.2k
⌀ | reactions
stringlengths 189
198
| timeline_url
stringlengths 65
65
| performed_via_github_app
float64 | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/29010 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29010/labels{/name} | https://api.github.com/repos/facebook/react/issues/29010/comments | https://api.github.com/repos/facebook/react/issues/29010/events | https://github.com/facebook/react/pull/29010 | 2,282,090,130 | PR_kwDOAJy2Ks5us32C | 29,010 | [Flight Reply] Encode Objects Returned to the Client by Reference | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nThe size diff is too large to display in a single comment. The [CircleCI job](https://circleci.com/gh/facebook/react/853577) contains an artifact called 'sizebot-message.md' with the full message.\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 086e23e7e4c34866a46eb55760b8c80519701a26\n</p>\n"
] | 2024-05-07 01:29:10 | 2024-05-07 01:37:10 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/29010', 'html_url': 'https://github.com/facebook/react/pull/29010', 'diff_url': 'https://github.com/facebook/react/pull/29010.diff', 'patch_url': 'https://github.com/facebook/react/pull/29010.patch', 'merged_at': None} | Stacked on #28997.
We can use the technique of referencing an object by its row + property name path for temporary references - like we do for deduping. That way we don't need to generate an ID for temporary references. Instead, they can just be an opaque marker in the slot and it has the implicit ID of the row + path.
Then we can stash all objects, even the ones that are actually available to read on the server, as temporary references. Without adding anything to the payload since the IDs are implicit. If the same object is returned to the client, it can be referenced by reference instead of serializing it back to the client. This also helps preserve object identity.
We assume that the objects are immutable when they pass the boundary.
I'm not sure if this is worth it but with this mechanism, if you return the `FormData` payload from a `useActionState` it doesn't have to be serialized on the way back to the client. This is a common pattern for having access to the last submission as "default value" to the form fields. However you can still control it by replacing it with another object if you want. In MPA mode, the temporary references are not configured and so it needs to be serialized in that case. That's required anyway for hydration purposes.
I'm not sure if people will actually use this in practice though or if FormData will always be destructured into some other object like with a library that turns it into typed data, and back. If so, the object identity is lost. | {'url': 'https://api.github.com/repos/facebook/react/issues/29010/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29010/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29009 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29009/labels{/name} | https://api.github.com/repos/facebook/react/issues/29009/comments | https://api.github.com/repos/facebook/react/issues/29009/events | https://github.com/facebook/react/pull/29009 | 2,281,861,803 | PR_kwDOAJy2Ks5usHXg | 29,009 | Check if we ever test without consoleManagedByDevToolsDuringStrictMode | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9b1300209eb00a2d6c645fddf6d2729d67d7b10a...0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f/files/facebook-www/ReactDOM-prod.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f/files/facebook-www/ReactDOM-prod.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0f50410c3c5f6b6d094da9e99d39dc9d5a56ed5f\n</p>\n",
"Seems like we don't"
] | 2024-05-06 22:03:35 | 2024-05-06 22:18:51 | 2024-05-06 22:18:47 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/29009', 'html_url': 'https://github.com/facebook/react/pull/29009', 'diff_url': 'https://github.com/facebook/react/pull/29009.diff', 'patch_url': 'https://github.com/facebook/react/pull/29009.patch', 'merged_at': None} | Asking CI if we ever run native-fb feature flags. | {'url': 'https://api.github.com/repos/facebook/react/issues/29009/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29009/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29008 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29008/labels{/name} | https://api.github.com/repos/facebook/react/issues/29008/comments | https://api.github.com/repos/facebook/react/issues/29008/events | https://github.com/facebook/react/pull/29008 | 2,281,803,784 | PR_kwDOAJy2Ks5ur6dO | 29,008 | Stop using Scheduler.log to test double invocations | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9b1300209eb00a2d6c645fddf6d2729d67d7b10a...1d5ee2b1019b924de53461d52dad7bc1f0b01286\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/1d5ee2b1019b924de53461d52dad7bc1f0b01286/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/1d5ee2b1019b924de53461d52dad7bc1f0b01286/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/1d5ee2b1019b924de53461d52dad7bc1f0b01286/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/1d5ee2b1019b924de53461d52dad7bc1f0b01286/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/1d5ee2b1019b924de53461d52dad7bc1f0b01286/files/facebook-www/ReactDOM-prod.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/1d5ee2b1019b924de53461d52dad7bc1f0b01286/files/facebook-www/ReactDOM-prod.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/1d5ee2b1019b924de53461d52dad7bc1f0b01286/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/1d5ee2b1019b924de53461d52dad7bc1f0b01286/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1d5ee2b1019b924de53461d52dad7bc1f0b01286\n</p>\n"
] | 2024-05-06 21:25:08 | 2024-05-06 22:51:47 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/29008', 'html_url': 'https://github.com/facebook/react/pull/29008', 'diff_url': 'https://github.com/facebook/react/pull/29008.diff', 'patch_url': 'https://github.com/facebook/react/pull/29008.patch', 'merged_at': None} | Stack:
1. https://github.com/facebook/react/pull/29006
1. https://github.com/facebook/react/pull/29008 <-- You're here
1. https://github.com/facebook/react/pull/29007
## Summary
In a follow-up, I want to dim console calls for effect invocations due to `StrictMode` just like we do for render-time invocations due to `StrictMode`. This will automatically ignore `Scheduler.log` calls during effect invocations caused by `StrictMode` (just like it does for render-time invocations due to `StrictMode`).
That means we have to use other means of testing double invocations during `StrictMode`. I used the same pattern we used for render-time double invocations: pushing to a log.
Also used the opportunity to reduce the size of some log assertions to make future diffs readable. Git will not be able to correctly identify where a new log lines where added and think they got moved instead.
## How did you test this change?
- [x] Assertions on `log` are still the same in https://github.com/facebook/react/pull/29007
| {'url': 'https://api.github.com/repos/facebook/react/issues/29008/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29008/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29007 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29007/labels{/name} | https://api.github.com/repos/facebook/react/issues/29007/comments | https://api.github.com/repos/facebook/react/issues/29007/events | https://github.com/facebook/react/pull/29007 | 2,281,803,712 | PR_kwDOAJy2Ks5ur6cQ | 29,007 | Dim `console` calls on additional Effect invocations due to `StrictMode` | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9b1300209eb00a2d6c645fddf6d2729d67d7b10a...7b47a56218f9f3937db7a2015482ec48e49edd71\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/7b47a56218f9f3937db7a2015482ec48e49edd71/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.66 kB | 6.66 kB | +0.11% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/7b47a56218f9f3937db7a2015482ec48e49edd71/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/7b47a56218f9f3937db7a2015482ec48e49edd71/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/7b47a56218f9f3937db7a2015482ec48e49edd71/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/7b47a56218f9f3937db7a2015482ec48e49edd71/files/facebook-www/ReactDOM-prod.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/7b47a56218f9f3937db7a2015482ec48e49edd71/files/facebook-www/ReactDOM-prod.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/7b47a56218f9f3937db7a2015482ec48e49edd71/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/7b47a56218f9f3937db7a2015482ec48e49edd71/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 7b47a56218f9f3937db7a2015482ec48e49edd71\n</p>\n"
] | 2024-05-06 21:25:06 | 2024-05-06 22:51:50 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/29007', 'html_url': 'https://github.com/facebook/react/pull/29007', 'diff_url': 'https://github.com/facebook/react/pull/29007.diff', 'patch_url': 'https://github.com/facebook/react/pull/29007.patch', 'merged_at': None} | Stack:
1. https://github.com/facebook/react/pull/29006
1. https://github.com/facebook/react/pull/29008
1. https://github.com/facebook/react/pull/29007 <-- You're here
## Summary
Same as https://github.com/facebook/react/pull/22030 but for double invocations of Effects due to `StrictMode`:
Before/After
 
This means that console calls during the double invocations of Effects due to `StrictMode` can be disabled in React DevTools.
The option has been renamed from "Hide logs during second render in Strict Mode" to "Hide logs during additional invocations in Strict Mode". Not sure if "additional invocations" is clear enough. "additional function calls" is just slightly longer and may be clearer?
This also means that tests using `Scheduler.log` no longer have to assert on the additional invocations (just like `Scheduler.log` during double invocations of render-time functions due to `StrictMode`).
## How did you test this change?
- additional tests like https://github.com/facebook/react/pull/22030 added but for Effects
- extension+build from this branch and console calls during Effects: https://codesandbox.io/p/sandbox/react-devtools-console-calls-during-second-effect-invocation-due-to-strict-mode-6yfd4g
| {'url': 'https://api.github.com/repos/facebook/react/issues/29007/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29007/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29006 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29006/labels{/name} | https://api.github.com/repos/facebook/react/issues/29006/comments | https://api.github.com/repos/facebook/react/issues/29006/events | https://github.com/facebook/react/pull/29006 | 2,281,742,406 | PR_kwDOAJy2Ks5ursqN | 29,006 | Allow specifying timeout in tests via third argument | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9b1300209eb00a2d6c645fddf6d2729d67d7b10a...19900a5ae58be124b3f60e7e8f0e9528ece8094c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/19900a5ae58be124b3f60e7e8f0e9528ece8094c/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/19900a5ae58be124b3f60e7e8f0e9528ece8094c/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/19900a5ae58be124b3f60e7e8f0e9528ece8094c/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/19900a5ae58be124b3f60e7e8f0e9528ece8094c/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.92 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/19900a5ae58be124b3f60e7e8f0e9528ece8094c/files/facebook-www/ReactDOM-prod.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/19900a5ae58be124b3f60e7e8f0e9528ece8094c/files/facebook-www/ReactDOM-prod.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/19900a5ae58be124b3f60e7e8f0e9528ece8094c/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/19900a5ae58be124b3f60e7e8f0e9528ece8094c/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 19900a5ae58be124b3f60e7e8f0e9528ece8094c\n</p>\n"
] | 2024-05-06 20:51:04 | 2024-05-06 20:56:09 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/29006', 'html_url': 'https://github.com/facebook/react/pull/29006', 'diff_url': 'https://github.com/facebook/react/pull/29006.diff', 'patch_url': 'https://github.com/facebook/react/pull/29006.patch', 'merged_at': None} | ## Summary
Enables extending the timeout via `test(name, callback, timeoutMS)` when the test is gated. Extending the timeout is mostly useful with a debugger attached. With the debugger attached, you easily exceed the 5s timeout.
## How did you test this change?
- Added third argument to https://github.com/facebook/react/blob/8d41ed869e0283a661299765c563e462c9e78799/packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js#L816 and was able to debug tests for minutes without Jest aborting during a yield.
| {'url': 'https://api.github.com/repos/facebook/react/issues/29006/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29006/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29005 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29005/labels{/name} | https://api.github.com/repos/facebook/react/issues/29005/comments | https://api.github.com/repos/facebook/react/issues/29005/events | https://github.com/facebook/react/issues/29005 | 2,281,449,515 | I_kwDOAJy2Ks6H_Cgr | 29,005 | [React+19] | {'login': 'hossain666', 'id': 161531032, 'node_id': 'U_kgDOCaDEmA', 'avatar_url': 'https://avatars.githubusercontent.com/u/161531032?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hossain666', 'html_url': 'https://github.com/hossain666', 'followers_url': 'https://api.github.com/users/hossain666/followers', 'following_url': 'https://api.github.com/users/hossain666/following{/other_user}', 'gists_url': 'https://api.github.com/users/hossain666/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hossain666/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hossain666/subscriptions', 'organizations_url': 'https://api.github.com/users/hossain666/orgs', 'repos_url': 'https://api.github.com/users/hossain666/repos', 'events_url': 'https://api.github.com/users/hossain666/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hossain666/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"f1338f8080abd1386454a10bbf93d67bfe37ce85",
"What's the issue?",
"[](https://github.com/mui/mui-x/actions/workflows/issue-cleanup.yml)"
] | 2024-05-06 18:10:07 | 2024-05-06 18:44:23 | 2024-05-06 18:44:23 | NONE | null | null | null | ## Summary
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
--> | {'url': 'https://api.github.com/repos/facebook/react/issues/29005/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29005/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/29004 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29004/labels{/name} | https://api.github.com/repos/facebook/react/issues/29004/comments | https://api.github.com/repos/facebook/react/issues/29004/events | https://github.com/facebook/react/pull/29004 | 2,281,443,200 | PR_kwDOAJy2Ks5uqrQ6 | 29,004 | "TypeError: Cannot read property 'setState' of null" when using React.lazy | {'login': 'yrlmanoharreddy', 'id': 86654781, 'node_id': 'MDQ6VXNlcjg2NjU0Nzgx', 'avatar_url': 'https://avatars.githubusercontent.com/u/86654781?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yrlmanoharreddy', 'html_url': 'https://github.com/yrlmanoharreddy', 'followers_url': 'https://api.github.com/users/yrlmanoharreddy/followers', 'following_url': 'https://api.github.com/users/yrlmanoharreddy/following{/other_user}', 'gists_url': 'https://api.github.com/users/yrlmanoharreddy/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yrlmanoharreddy/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yrlmanoharreddy/subscriptions', 'organizations_url': 'https://api.github.com/users/yrlmanoharreddy/orgs', 'repos_url': 'https://api.github.com/users/yrlmanoharreddy/repos', 'events_url': 'https://api.github.com/users/yrlmanoharreddy/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yrlmanoharreddy/received_events', 'type': 'User', 'site_admin': False} | [] | open | false | null | [] | null | [
"Hi @yrlmanoharreddy! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2329004). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9b1300209eb00a2d6c645fddf6d2729d67d7b10a...70c0f28086d7e70800e394c69e75223193ff427f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.66 kB | 6.66 kB | +0.11% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-www/ReactDOM-prod.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-www/ReactDOM-prod.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable-semver/react/cjs/react.react-server.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable-semver/react/cjs/react.react-server.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+1.11%** | 14.96 kB | 15.13 kB | +0.96% | 4.07 kB | 4.11 kB\n| [oss-stable/react/cjs/react.react-server.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable/react/cjs/react.react-server.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+1.11%** | 14.99 kB | 15.15 kB | +1.00% | 4.10 kB | 4.14 kB\n| [oss-stable-semver/react/cjs/react.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable-semver/react/cjs/react.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.98%** | 16.87 kB | 17.03 kB | +0.87% | 4.39 kB | 4.43 kB\n| [oss-stable/react/cjs/react.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable/react/cjs/react.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.98%** | 16.89 kB | 17.06 kB | +0.91% | 4.42 kB | 4.46 kB\n| [oss-experimental/react/cjs/react.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-experimental/react/cjs/react.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.93%** | 17.91 kB | 18.08 kB | +0.86% | 4.66 kB | 4.70 kB\n| [oss-experimental/react/cjs/react.react-server.production.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-experimental/react/cjs/react.react-server.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.89%** | 18.62 kB | 18.78 kB | +0.79% | 4.96 kB | 5.00 kB\n| [facebook-www/React-prod.modern.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-www/React-prod.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.72%** | 23.10 kB | 23.26 kB | +0.71% | 5.93 kB | 5.97 kB\n| [facebook-www/React-prod.classic.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-www/React-prod.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.72%** | 23.10 kB | 23.27 kB | +0.71% | 5.93 kB | 5.98 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-react-native/react/cjs/React-prod.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.72%** | 23.20 kB | 23.37 kB | +0.62% | 5.97 kB | 6.00 kB\n| [facebook-www/React-profiling.modern.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-www/React-profiling.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.71%** | 23.53 kB | 23.70 kB | +0.68% | 6.01 kB | 6.05 kB\n| [facebook-www/React-profiling.classic.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-www/React-profiling.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.71%** | 23.53 kB | 23.70 kB | +0.67% | 6.01 kB | 6.05 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-react-native/react/cjs/React-profiling.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.70%** | 23.64 kB | 23.80 kB | +0.63% | 6.05 kB | 6.08 kB\n| [oss-stable-semver/react/cjs/react.react-server.development.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable-semver/react/cjs/react.react-server.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.35%** | 69.04 kB | 69.28 kB | +0.36% | 19.30 kB | 19.36 kB\n| [oss-stable/react/cjs/react.react-server.development.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable/react/cjs/react.react-server.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.35%** | 69.07 kB | 69.31 kB | +0.37% | 19.32 kB | 19.39 kB\n| [oss-experimental/react/cjs/react.react-server.development.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-experimental/react/cjs/react.react-server.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.32%** | 74.63 kB | 74.87 kB | +0.32% | 20.91 kB | 20.97 kB\n| [oss-stable-semver/react/cjs/react.development.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable-semver/react/cjs/react.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.26%** | 93.35 kB | 93.59 kB | +0.25% | 25.57 kB | 25.63 kB\n| [oss-stable/react/cjs/react.development.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-stable/react/cjs/react.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.26%** | 93.37 kB | 93.61 kB | +0.25% | 25.60 kB | 25.66 kB\n| [oss-experimental/react/cjs/react.development.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/oss-experimental/react/cjs/react.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.25%** | 94.82 kB | 95.06 kB | +0.23% | 25.95 kB | 26.01 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-react-native/react/cjs/React-dev.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.21%** | 114.70 kB | 114.94 kB | +0.25% | 30.02 kB | 30.10 kB\n| [facebook-www/React-dev.modern.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-www/React-dev.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.21%** | 116.30 kB | 116.54 kB | +0.22% | 30.15 kB | 30.21 kB\n| [facebook-www/React-dev.classic.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/facebook-www/React-dev.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.21%** | 116.79 kB | 117.03 kB | +0.23% | 30.25 kB | 30.32 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/70c0f28086d7e70800e394c69e75223193ff427f/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 70c0f28086d7e70800e394c69e75223193ff427f\n</p>\n"
] | 2024-05-06 18:06:20 | 2024-05-06 18:11:36 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/29004', 'html_url': 'https://github.com/facebook/react/pull/29004', 'diff_url': 'https://github.com/facebook/react/pull/29004.diff', 'patch_url': 'https://github.com/facebook/react/pull/29004.patch', 'merged_at': None} | Title: "TypeError: Cannot read property 'setState' of null" when using React.lazy
Description:
When using React.lazy to lazily load a component, users are reporting a "TypeError: Cannot read property 'setState' of null" error in certain scenarios. This issue seems to occur when a lazily loaded component is unmounted before it finishes loading, leading to a null state and the error.
Expected Behavior:
The lazy component should load without any errors, even if it's unmounted before it finishes loading.
Actual Behavior:
A "TypeError: Cannot read property 'setState' of null" error is thrown in the console, and the lazy component fails to load properly.
Possible Solution:
A potential solution could involve modifying the React.lazy implementation to check if the component instance still exists before attempting to set its state during the loading process.
Please let me know if you need any additional information or have any suggestions for addressing this issue. | {'url': 'https://api.github.com/repos/facebook/react/issues/29004/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29004/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29003 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29003/labels{/name} | https://api.github.com/repos/facebook/react/issues/29003/comments | https://api.github.com/repos/facebook/react/issues/29003/events | https://github.com/facebook/react/pull/29003 | 2,281,111,435 | PR_kwDOAJy2Ks5upjNN | 29,003 | Add FB build for ReactReconcilerConstants | {'login': 'jackpope', 'id': 8965173, 'node_id': 'MDQ6VXNlcjg5NjUxNzM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8965173?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackpope', 'html_url': 'https://github.com/jackpope', 'followers_url': 'https://api.github.com/users/jackpope/followers', 'following_url': 'https://api.github.com/users/jackpope/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackpope/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackpope/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackpope/subscriptions', 'organizations_url': 'https://api.github.com/users/jackpope/orgs', 'repos_url': 'https://api.github.com/users/jackpope/repos', 'events_url': 'https://api.github.com/users/jackpope/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackpope/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46abd7b1deb42d23b65480432609a2f8c5014cde...947111a6828446417154031d4ceb64884834e62a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactDOM-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactDOM-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [facebook-www/ReactReconcilerConstants-dev.classic.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactReconcilerConstants-dev.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+∞%** | 0.00 kB | 1.29 kB | +∞% | 0.00 kB | 0.51 kB\n| [facebook-www/ReactReconcilerConstants-dev.modern.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactReconcilerConstants-dev.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+∞%** | 0.00 kB | 1.29 kB | +∞% | 0.00 kB | 0.51 kB\n| [facebook-www/ReactReconcilerConstants-prod.classic.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactReconcilerConstants-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+∞%** | 0.00 kB | 0.54 kB | +∞% | 0.00 kB | 0.32 kB\n| [facebook-www/ReactReconcilerConstants-prod.modern.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactReconcilerConstants-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+∞%** | 0.00 kB | 0.54 kB | +∞% | 0.00 kB | 0.32 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-www/ReactReconcilerConstants-dev.classic.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactReconcilerConstants-dev.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+∞%** | 0.00 kB | 1.29 kB | +∞% | 0.00 kB | 0.51 kB\n| [facebook-www/ReactReconcilerConstants-dev.modern.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactReconcilerConstants-dev.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+∞%** | 0.00 kB | 1.29 kB | +∞% | 0.00 kB | 0.51 kB\n| [facebook-www/ReactReconcilerConstants-prod.classic.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactReconcilerConstants-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+∞%** | 0.00 kB | 0.54 kB | +∞% | 0.00 kB | 0.32 kB\n| [facebook-www/ReactReconcilerConstants-prod.modern.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/facebook-www/ReactReconcilerConstants-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+∞%** | 0.00 kB | 0.54 kB | +∞% | 0.00 kB | 0.32 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/947111a6828446417154031d4ceb64884834e62a/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 947111a6828446417154031d4ceb64884834e62a\n</p>\n"
] | 2024-05-06 15:11:51 | 2024-05-06 15:32:46 | 2024-05-06 15:32:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/29003', 'html_url': 'https://github.com/facebook/react/pull/29003', 'diff_url': 'https://github.com/facebook/react/pull/29003.diff', 'patch_url': 'https://github.com/facebook/react/pull/29003.patch', 'merged_at': datetime.datetime(2024, 5, 6, 15, 32, 43)} | In order to integrate the `react-reconciler` build created in #28880 with third party libraries, we need to have matching `react-reconciler/constants` to go with it.
| {'url': 'https://api.github.com/repos/facebook/react/issues/29003/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29003/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29002 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29002/labels{/name} | https://api.github.com/repos/facebook/react/issues/29002/comments | https://api.github.com/repos/facebook/react/issues/29002/events | https://github.com/facebook/react/pull/29002 | 2,280,977,406 | PR_kwDOAJy2Ks5upGOr | 29,002 | Update getComments.js | {'login': 'AnuragKacham', 'id': 56756993, 'node_id': 'MDQ6VXNlcjU2NzU2OTkz', 'avatar_url': 'https://avatars.githubusercontent.com/u/56756993?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AnuragKacham', 'html_url': 'https://github.com/AnuragKacham', 'followers_url': 'https://api.github.com/users/AnuragKacham/followers', 'following_url': 'https://api.github.com/users/AnuragKacham/following{/other_user}', 'gists_url': 'https://api.github.com/users/AnuragKacham/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/AnuragKacham/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/AnuragKacham/subscriptions', 'organizations_url': 'https://api.github.com/users/AnuragKacham/orgs', 'repos_url': 'https://api.github.com/users/AnuragKacham/repos', 'events_url': 'https://api.github.com/users/AnuragKacham/events{/privacy}', 'received_events_url': 'https://api.github.com/users/AnuragKacham/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @AnuragKacham! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2329002). Thanks!",
"Please review the changes mentioned.\r\n\r\nAdded two scenarios:\r\n\r\n1. Commented starting on the line 20:\r\n\r\nCreated a map of comments by line number. It then uses this map to find the comments on the line before the node at the given path. This should be more efficient than the original function if the number of comments is large and they are not sorted by line number. However, it does require additional memory to store the map.\r\n\r\n2. Lines 41 - 47 and commented 48 - 52:\r\n\r\nWe store the line number of the first comment we find that is on the line before the node. We then continue to add comments to the comments array until we find a comment that is not on this line.\r\n\r\nThis optimization reduces the number of iterations in the second while loop, but it doesn't change the overall time complexity of the function. The time complexity is still O(n), where n is the number of comments. This is because in the worst case, we still have to iterate through all the comments.",
"Thanks for the PR, but we generally don't take PRs that make small refactors. They very rarely help and usually tend to introduce subtle bugs. Since this only runs for tests, we don't need a micro optimization. ",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46abd7b1deb42d23b65480432609a2f8c5014cde...075c19f301738769f6ee74a86ad4f8f8ee00138c\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/075c19f301738769f6ee74a86ad4f8f8ee00138c/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/075c19f301738769f6ee74a86ad4f8f8ee00138c/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/075c19f301738769f6ee74a86ad4f8f8ee00138c/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/075c19f301738769f6ee74a86ad4f8f8ee00138c/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/075c19f301738769f6ee74a86ad4f8f8ee00138c/files/facebook-www/ReactDOM-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/075c19f301738769f6ee74a86ad4f8f8ee00138c/files/facebook-www/ReactDOM-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/075c19f301738769f6ee74a86ad4f8f8ee00138c/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/075c19f301738769f6ee74a86ad4f8f8ee00138c/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 075c19f301738769f6ee74a86ad4f8f8ee00138c\n</p>\n"
] | 2024-05-06 14:11:24 | 2024-05-06 14:16:48 | 2024-05-06 14:15:46 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/29002', 'html_url': 'https://github.com/facebook/react/pull/29002', 'diff_url': 'https://github.com/facebook/react/pull/29002.diff', 'patch_url': 'https://github.com/facebook/react/pull/29002.patch', 'merged_at': None} | Added two scenarios:
1. Commented starting on the line 20:
Created a map of comments by line number. It then uses this map to find the comments on the line before the node at the given path. This should be more efficient than the original function if the number of comments is large and they are not sorted by line number. However, it does require additional memory to store the map.
2. Lines 41 - 47 and commented 48 - 52:
We store the line number of the first comment we find that is on the line before the node. We then continue to add comments to the comments array until we find a comment that is not on this line.
This optimization reduces the number of iterations in the second while loop, but it doesn't change the overall time complexity of the function. The time complexity is still O(n), where n is the number of comments. This is because in the worst case, we still have to iterate through all the comments.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
Ans: One of the problems was that the search was not being stopped even after finding the comment that is not on the line before the node. So, the number of iterations had to be reduced.
Another one is a commented block, which is an implementation using mapping through keys as line numbers and values as array of comments. This method would make the search O(1), but the comments would have to be stored first, so, a global storage solution could make this happen, if possible, or the current method can be used, which is linear.
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
The code has been run, and it was perfect. The thing with comments was good, but the response time definitely varied a bit.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/29002/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29002/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29001 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29001/labels{/name} | https://api.github.com/repos/facebook/react/issues/29001/comments | https://api.github.com/repos/facebook/react/issues/29001/events | https://github.com/facebook/react/pull/29001 | 2,280,500,457 | PR_kwDOAJy2Ks5unfqb | 29,001 | [Flight] Test deduplication with streaming server components | {'login': 'unstubbable', 'id': 761683, 'node_id': 'MDQ6VXNlcjc2MTY4Mw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/761683?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/unstubbable', 'html_url': 'https://github.com/unstubbable', 'followers_url': 'https://api.github.com/users/unstubbable/followers', 'following_url': 'https://api.github.com/users/unstubbable/following{/other_user}', 'gists_url': 'https://api.github.com/users/unstubbable/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/unstubbable/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/unstubbable/subscriptions', 'organizations_url': 'https://api.github.com/users/unstubbable/orgs', 'repos_url': 'https://api.github.com/users/unstubbable/repos', 'events_url': 'https://api.github.com/users/unstubbable/events{/privacy}', 'received_events_url': 'https://api.github.com/users/unstubbable/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46abd7b1deb42d23b65480432609a2f8c5014cde...5ec7df7364b74205d2e9bec78751463c3cf84579\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/facebook-www/ReactDOM-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/facebook-www/ReactDOM-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.85%** | 29.03 kB | 29.27 kB | +1.57% | 6.56 kB | 6.67 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.85%** | 29.03 kB | 29.27 kB | +1.57% | 6.56 kB | 6.67 kB\n| [oss-stable-semver/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.81%** | 30.52 kB | 30.77 kB | +1.40% | 6.51 kB | 6.60 kB\n| [oss-stable/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.81%** | 30.52 kB | 30.77 kB | +1.40% | 6.51 kB | 6.60 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.80%** | 30.57 kB | 30.82 kB | +1.53% | 6.94 kB | 7.05 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.80%** | 30.57 kB | 30.82 kB | +1.53% | 6.94 kB | 7.05 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.80%** | 30.91 kB | 31.15 kB | +1.48% | 7.02 kB | 7.12 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.80%** | 30.91 kB | 31.15 kB | +1.48% | 7.02 kB | 7.12 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.74%** | 33.22 kB | 33.46 kB | +1.38% | 7.56 kB | 7.66 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.74%** | 33.22 kB | 33.46 kB | +1.38% | 7.56 kB | 7.66 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.71%** | 34.47 kB | 34.71 kB | +1.34% | 7.83 kB | 7.93 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.71%** | 34.47 kB | 34.71 kB | +1.34% | 7.83 kB | 7.93 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.71%** | 34.47 kB | 34.71 kB | +1.30% | 7.84 kB | 7.94 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.71%** | 34.47 kB | 34.71 kB | +1.30% | 7.84 kB | 7.94 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.70%** | 35.15 kB | 35.39 kB | +1.27% | 8.01 kB | 8.11 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.70%** | 35.15 kB | 35.39 kB | +1.27% | 8.01 kB | 8.11 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.70%** | 35.16 kB | 35.40 kB | +1.31% | 8.00 kB | 8.10 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.70%** | 35.16 kB | 35.40 kB | +1.31% | 8.00 kB | 8.10 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.68%** | 36.38 kB | 36.63 kB | +1.18% | 8.21 kB | 8.31 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.68%** | 36.38 kB | 36.63 kB | +1.18% | 8.21 kB | 8.31 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.68%** | 36.39 kB | 36.64 kB | +1.22% | 8.20 kB | 8.30 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.68%** | 36.39 kB | 36.64 kB | +1.22% | 8.20 kB | 8.30 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.54%** | 42.72 kB | 42.95 kB | +1.21% | 8.86 kB | 8.97 kB\n| [oss-experimental/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.53%** | 56.03 kB | 56.33 kB | +0.31% | 11.14 kB | 11.18 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.52%** | 44.26 kB | 44.49 kB | +1.14% | 9.23 kB | 9.33 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.52%** | 44.59 kB | 44.83 kB | +1.14% | 9.31 kB | 9.42 kB\n| [oss-experimental/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.52%** | 45.39 kB | 45.63 kB | +1.03% | 8.80 kB | 8.89 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.49%** | 47.10 kB | 47.33 kB | +1.06% | 9.89 kB | 10.00 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.48%** | 48.35 kB | 48.58 kB | +1.05% | 10.17 kB | 10.27 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.48%** | 48.35 kB | 48.59 kB | +1.01% | 10.17 kB | 10.27 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.47%** | 49.03 kB | 49.26 kB | +1.11% | 10.34 kB | 10.45 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.47%** | 49.04 kB | 49.27 kB | +1.14% | 10.32 kB | 10.44 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.46%** | 50.07 kB | 50.30 kB | +0.94% | 10.54 kB | 10.64 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.46%** | 50.08 kB | 50.31 kB | +0.97% | 10.52 kB | 10.63 kB\n| [oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.46%** | 46.38 kB | 46.60 kB | +0.75% | 10.78 kB | 10.87 kB\n| [oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.46%** | 46.38 kB | 46.60 kB | +0.75% | 10.78 kB | 10.87 kB\n| [oss-stable-semver/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 62.77 kB | 62.97 kB | +0.48% | 15.16 kB | 15.23 kB\n| [oss-stable/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 62.77 kB | 62.97 kB | +0.48% | 15.16 kB | 15.23 kB\n| [oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 62.78 kB | 62.98 kB | +0.50% | 14.87 kB | 14.94 kB\n| [oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 62.78 kB | 62.98 kB | +0.50% | 14.87 kB | 14.94 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 63.02 kB | 63.22 kB | +0.49% | 14.93 kB | 15.01 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 63.02 kB | 63.22 kB | +0.49% | 14.93 kB | 15.01 kB\n| [oss-stable-semver/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 41.69 kB | 41.83 kB | +0.26% | 9.11 kB | 9.13 kB\n| [oss-stable/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 41.69 kB | 41.83 kB | +0.26% | 9.11 kB | 9.13 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.31%** | 66.27 kB | 66.47 kB | +0.47% | 15.90 kB | 15.97 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.31%** | 66.27 kB | 66.47 kB | +0.47% | 15.90 kB | 15.97 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.30%** | 66.78 kB | 66.98 kB | +0.46% | 16.07 kB | 16.14 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.30%** | 66.78 kB | 66.98 kB | +0.46% | 16.07 kB | 16.14 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 83.70 kB | 83.94 kB | +0.25% | 17.26 kB | 17.30 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 69.55 kB | 69.75 kB | +0.50% | 15.05 kB | 15.13 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 70.70 kB | 70.90 kB | +0.44% | 16.97 kB | 17.04 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 70.70 kB | 70.90 kB | +0.44% | 16.97 kB | 17.04 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 85.69 kB | 85.93 kB | +0.23% | 17.38 kB | 17.42 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 86.57 kB | 86.82 kB | +0.34% | 17.63 kB | 17.69 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 86.77 kB | 87.02 kB | +0.25% | 17.62 kB | 17.66 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 87.30 kB | 87.55 kB | +0.35% | 17.77 kB | 17.83 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 72.48 kB | 72.68 kB | +0.42% | 17.53 kB | 17.60 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 72.48 kB | 72.68 kB | +0.42% | 17.53 kB | 17.60 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 72.51 kB | 72.72 kB | +0.41% | 17.55 kB | 17.63 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 72.51 kB | 72.72 kB | +0.41% | 17.55 kB | 17.63 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 88.50 kB | 88.75 kB | +0.21% | 18.01 kB | 18.05 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 89.46 kB | 89.71 kB | +0.24% | 18.22 kB | 18.27 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 73.91 kB | 74.12 kB | +0.39% | 17.90 kB | 17.97 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 73.91 kB | 74.12 kB | +0.39% | 17.90 kB | 17.97 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 89.60 kB | 89.85 kB | +0.21% | 18.24 kB | 18.27 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 73.94 kB | 74.14 kB | +0.41% | 17.94 kB | 18.01 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 73.94 kB | 74.14 kB | +0.41% | 17.94 kB | 18.01 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 90.55 kB | 90.79 kB | +0.25% | 18.45 kB | 18.49 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 74.98 kB | 75.19 kB | +0.39% | 18.11 kB | 18.18 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 74.98 kB | 75.19 kB | +0.39% | 18.11 kB | 18.18 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 75.01 kB | 75.21 kB | +0.40% | 18.15 kB | 18.22 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 75.01 kB | 75.21 kB | +0.40% | 18.15 kB | 18.22 kB\n| [oss-experimental/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.22%** | 86.34 kB | 86.53 kB | +0.34% | 19.53 kB | 19.60 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.22%** | 86.35 kB | 86.54 kB | +0.42% | 19.24 kB | 19.32 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.22%** | 86.59 kB | 86.78 kB | +0.42% | 19.31 kB | 19.39 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.21%** | 89.84 kB | 90.03 kB | +0.39% | 20.27 kB | 20.35 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.21%** | 90.35 kB | 90.54 kB | +0.39% | 20.44 kB | 20.52 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.20%** | 94.26 kB | 94.46 kB | +0.34% | 21.34 kB | 21.41 kB\n| [oss-stable-semver/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable-semver/react-server/cjs/react-server-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 87.25 kB | 87.04 kB | = | 20.29 kB | 20.25 kB\n| [oss-stable/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/oss-stable/react-server/cjs/react-server-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 87.25 kB | 87.04 kB | = | 20.29 kB | 20.25 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/5ec7df7364b74205d2e9bec78751463c3cf84579/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 5ec7df7364b74205d2e9bec78751463c3cf84579\n</p>\n",
"I have a TODO to fix dedupe in ReadableStream/AsyncIterable so I first thought it was about that but this is just recursive promises.",
"> I have a TODO to fix dedupe in ReadableStream/AsyncIterable so I first thought it was about that but this is just recursive promises.\r\n\r\nYes this is about recursive promises, combined with using the same element as suspense `fallback` and `children` at the end of this promise chain.",
"Well, it is expected that the fallback and the children of a Suspense boundary cannot share state. They are two separate slots so they are two separate components.\r\n\r\nThis becomes important for example with resuspending when the state in both of them can exist at the same time. The fallback is shown but the state of the children is preserved while it's suspended and can be shown again.\r\n\r\nIt also doesn't really make conceptual sense to render the same thing on both slots. It would always be suspended at the same time. They'd at least need different props. In this case the extra wrapper Row is actually supposed to clear the state too. We don't in the case of Server Components as a pragmatic way to avoid the overhead/leak of wrapper.\r\n\r\nHowever, this is not the only problem with this approach. For example, by creating nested Suspense boundaries you can't reorder the items in the list and have them preserve state since they're not siblings but nested components that should really have keys which would clear the state on reorders.\r\n\r\nThat's why the correct model for this will be AsyncIterable + SuspenseList. In fact, this was why SuspenseList was built in the first place.",
"Thanks for providing the suspense context, that makes sense.\r\n\r\nI do see how AsyncIterable + SuspenseList will be useful for streamable UI that’s appended to. For the kind of streamable UI that’s updated instead, it will probably feel like misusing SuspenseList for that (e.g. only showing the last value)."
] | 2024-05-06 10:04:07 | 2024-05-06 20:31:09 | 2024-05-06 20:31:08 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/29001', 'html_url': 'https://github.com/facebook/react/pull/29001', 'diff_url': 'https://github.com/facebook/react/pull/29001.diff', 'patch_url': 'https://github.com/facebook/react/pull/29001.patch', 'merged_at': None} | _Stacked on top of #28996, because initially I thought that the deduplication by property path would make this test succeed._
I think the [test](https://github.com/facebook/react/pull/29001/commits/5ec7df7364b74205d2e9bec78751463c3cf84579) might be useful for verifying a fix that can unblock the reconciliation issue in the AI SDK (see https://github.com/vercel/ai/issues/1257, or https://github.com/vercel/ai/pull/1210#issuecomment-2020760351, for reference), whether this can be incorporated into #28996, or tackled separately.
The flight payload for the test shows that deduplication via property path is not applied in this scenario:
```
1:"$Sreact.suspense"
0:["$","$1",null,{"fallback":["$","p",null,{"children":"loading"}],"children":"$L2"}]
3:I["0",[],"*"]
2:["$","$1",null,{"fallback":["$","$L3",null,{"initialState":0}],"children":"$L4"}]
4:["$","$L3",null,{"initialState":0}]
```
I would still need to investigate whether this is an expected limitation by the Flight Server (i.e. reference by path can only work within the same model root, and not across chunks), or whether this is actually supposed to be supported. After all, the path does include the task ID, and in fact, the Flight Client can resolve `4:"$2:props:fallback"`. But even then, this still leads to a re-mount. So maybe it's also a limitation of Fiber? | {'url': 'https://api.github.com/repos/facebook/react/issues/29001/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29001/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/29000 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/29000/labels{/name} | https://api.github.com/repos/facebook/react/issues/29000/comments | https://api.github.com/repos/facebook/react/issues/29000/events | https://github.com/facebook/react/issues/29000 | 2,280,258,676 | I_kwDOAJy2Ks6H6fx0 | 29,000 | Bug: unexpected Warning: `ReactDOMTestUtils.act` is deprecated in favor of `React.act`. | {'login': 'salier1', 'id': 90126412, 'node_id': 'MDQ6VXNlcjkwMTI2NDEy', 'avatar_url': 'https://avatars.githubusercontent.com/u/90126412?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/salier1', 'html_url': 'https://github.com/salier1', 'followers_url': 'https://api.github.com/users/salier1/followers', 'following_url': 'https://api.github.com/users/salier1/following{/other_user}', 'gists_url': 'https://api.github.com/users/salier1/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/salier1/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/salier1/subscriptions', 'organizations_url': 'https://api.github.com/users/salier1/orgs', 'repos_url': 'https://api.github.com/users/salier1/repos', 'events_url': 'https://api.github.com/users/salier1/events{/privacy}', 'received_events_url': 'https://api.github.com/users/salier1/received_events', 'type': 'User', 'site_admin': False} | [{'id': 1168115654, 'node_id': 'MDU6TGFiZWwxMTY4MTE1NjU0', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Support%20Redirect', 'name': 'Resolution: Support Redirect', 'color': '106099', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"You should bump the installed version of `@testing-library/react` to at least `15.0.6` to get rid of the deprecation warning."
] | 2024-05-06 07:44:02 | 2024-05-06 12:46:41 | 2024-05-06 12:46:35 | NONE | null | null | null | I didn't use `act` in `react-dom/test-utils` but I got the following warning :
Warning: `ReactDOMTestUtils.act` is deprecated in favor of `React.act`. Import `act` from `react` instead of `react-dom/test-utils`. See https://react.dev/warnings/react-dom-test-utils for more info.
React version:18.3.1
## Steps To Reproduce
1.run `npx create-react-app test --template typescript`
2.run `cd test`
3.run `npm run test`
4.press `a`
<img width="935" alt="image" src="https://github.com/facebook/react/assets/90126412/be7dc826-3ac3-4717-9bc7-61a04091c70d">
| {'url': 'https://api.github.com/repos/facebook/react/issues/29000/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/29000/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28999 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28999/labels{/name} | https://api.github.com/repos/facebook/react/issues/28999/comments | https://api.github.com/repos/facebook/react/issues/28999/events | https://github.com/facebook/react/issues/28999 | 2,279,928,863 | I_kwDOAJy2Ks6H5PQf | 28,999 | After react devtools version 5.0, when you click Open in editor, you cannot jump to the line of the file corresponding to vscode | {'login': 'zhouhaizhou', 'id': 24632656, 'node_id': 'MDQ6VXNlcjI0NjMyNjU2', 'avatar_url': 'https://avatars.githubusercontent.com/u/24632656?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhouhaizhou', 'html_url': 'https://github.com/zhouhaizhou', 'followers_url': 'https://api.github.com/users/zhouhaizhou/followers', 'following_url': 'https://api.github.com/users/zhouhaizhou/following{/other_user}', 'gists_url': 'https://api.github.com/users/zhouhaizhou/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/zhouhaizhou/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/zhouhaizhou/subscriptions', 'organizations_url': 'https://api.github.com/users/zhouhaizhou/orgs', 'repos_url': 'https://api.github.com/users/zhouhaizhou/repos', 'events_url': 'https://api.github.com/users/zhouhaizhou/events{/privacy}', 'received_events_url': 'https://api.github.com/users/zhouhaizhou/received_events', 'type': 'User', 'site_admin': False} | [] | open | false | null | [] | null | [] | 2024-05-06 03:06:31 | 2024-05-06 03:06:31 | null | NONE | null | null | null | 
| {'url': 'https://api.github.com/repos/facebook/react/issues/28999/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28999/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28998 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28998/labels{/name} | https://api.github.com/repos/facebook/react/issues/28998/comments | https://api.github.com/repos/facebook/react/issues/28998/events | https://github.com/facebook/react/issues/28998 | 2,279,923,581 | I_kwDOAJy2Ks6H5N99 | 28,998 | react devtools版本5.0之后，点击Open in editor时，不能跳转到vscode对应文件的行 | {'login': 'zhouhaizhou', 'id': 24632656, 'node_id': 'MDQ6VXNlcjI0NjMyNjU2', 'avatar_url': 'https://avatars.githubusercontent.com/u/24632656?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhouhaizhou', 'html_url': 'https://github.com/zhouhaizhou', 'followers_url': 'https://api.github.com/users/zhouhaizhou/followers', 'following_url': 'https://api.github.com/users/zhouhaizhou/following{/other_user}', 'gists_url': 'https://api.github.com/users/zhouhaizhou/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/zhouhaizhou/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/zhouhaizhou/subscriptions', 'organizations_url': 'https://api.github.com/users/zhouhaizhou/orgs', 'repos_url': 'https://api.github.com/users/zhouhaizhou/repos', 'events_url': 'https://api.github.com/users/zhouhaizhou/events{/privacy}', 'received_events_url': 'https://api.github.com/users/zhouhaizhou/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"english version at #28999"
] | 2024-05-06 02:59:27 | 2024-05-07 00:33:21 | 2024-05-07 00:33:21 | NONE | null | null | null | 
| {'url': 'https://api.github.com/repos/facebook/react/issues/28998/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28998/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28997 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28997/labels{/name} | https://api.github.com/repos/facebook/react/issues/28997/comments | https://api.github.com/repos/facebook/react/issues/28997/events | https://github.com/facebook/react/pull/28997 | 2,279,901,444 | PR_kwDOAJy2Ks5uldmj | 28,997 | [Flight Reply] Dedupe Objects and Support Cyclic References | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46abd7b1deb42d23b65480432609a2f8c5014cde...dd30d43b3e2600ec12243b860b0b44aa2e936cb0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/facebook-www/ReactDOM-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/facebook-www/ReactDOM-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+3.09%** | 46.38 kB | 47.82 kB | +3.96% | 10.78 kB | 11.21 kB\n| [oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+3.09%** | 46.38 kB | 47.82 kB | +3.96% | 10.78 kB | 11.21 kB\n| [oss-stable-semver/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.26%** | 62.77 kB | 64.19 kB | +2.82% | 15.16 kB | 15.59 kB\n| [oss-stable/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.26%** | 62.77 kB | 64.19 kB | +2.82% | 15.16 kB | 15.59 kB\n| [oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.26%** | 62.78 kB | 64.20 kB | +2.90% | 14.87 kB | 15.30 kB\n| [oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.26%** | 62.78 kB | 64.20 kB | +2.90% | 14.87 kB | 15.30 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.25%** | 63.02 kB | 64.44 kB | +2.89% | 14.93 kB | 15.37 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.25%** | 63.02 kB | 64.44 kB | +2.89% | 14.93 kB | 15.37 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.14%** | 66.27 kB | 67.69 kB | +2.71% | 15.90 kB | 16.33 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.14%** | 66.27 kB | 67.69 kB | +2.71% | 15.90 kB | 16.33 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.13%** | 66.78 kB | 68.20 kB | +2.70% | 16.07 kB | 16.50 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.13%** | 66.78 kB | 68.20 kB | +2.70% | 16.07 kB | 16.50 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.04%** | 69.55 kB | 70.97 kB | +2.80% | 15.05 kB | 15.47 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.01%** | 70.70 kB | 72.12 kB | +2.48% | 16.97 kB | 17.39 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.01%** | 70.70 kB | 72.12 kB | +2.48% | 16.97 kB | 17.39 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+3.09%** | 46.38 kB | 47.82 kB | +3.96% | 10.78 kB | 11.21 kB\n| [oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+3.09%** | 46.38 kB | 47.82 kB | +3.96% | 10.78 kB | 11.21 kB\n| [oss-stable-semver/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.26%** | 62.77 kB | 64.19 kB | +2.82% | 15.16 kB | 15.59 kB\n| [oss-stable/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.26%** | 62.77 kB | 64.19 kB | +2.82% | 15.16 kB | 15.59 kB\n| [oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.26%** | 62.78 kB | 64.20 kB | +2.90% | 14.87 kB | 15.30 kB\n| [oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.26%** | 62.78 kB | 64.20 kB | +2.90% | 14.87 kB | 15.30 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.25%** | 63.02 kB | 64.44 kB | +2.89% | 14.93 kB | 15.37 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.25%** | 63.02 kB | 64.44 kB | +2.89% | 14.93 kB | 15.37 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.14%** | 66.27 kB | 67.69 kB | +2.71% | 15.90 kB | 16.33 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.14%** | 66.27 kB | 67.69 kB | +2.71% | 15.90 kB | 16.33 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.13%** | 66.78 kB | 68.20 kB | +2.70% | 16.07 kB | 16.50 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.13%** | 66.78 kB | 68.20 kB | +2.70% | 16.07 kB | 16.50 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.04%** | 69.55 kB | 70.97 kB | +2.80% | 15.05 kB | 15.47 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.01%** | 70.70 kB | 72.12 kB | +2.48% | 16.97 kB | 17.39 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+2.01%** | 70.70 kB | 72.12 kB | +2.48% | 16.97 kB | 17.39 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.96%** | 72.48 kB | 73.90 kB | +2.45% | 17.53 kB | 17.96 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.96%** | 72.48 kB | 73.90 kB | +2.45% | 17.53 kB | 17.96 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.96%** | 72.51 kB | 73.93 kB | +2.44% | 17.55 kB | 17.98 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.96%** | 72.51 kB | 73.93 kB | +2.44% | 17.55 kB | 17.98 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.92%** | 73.91 kB | 75.33 kB | +2.42% | 17.90 kB | 18.33 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.92%** | 73.91 kB | 75.33 kB | +2.42% | 17.90 kB | 18.33 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.92%** | 73.94 kB | 75.36 kB | +2.45% | 17.94 kB | 18.38 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.92%** | 73.94 kB | 75.36 kB | +2.45% | 17.94 kB | 18.38 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.89%** | 74.98 kB | 76.40 kB | +2.41% | 18.11 kB | 18.54 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.89%** | 74.98 kB | 76.40 kB | +2.41% | 18.11 kB | 18.54 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.89%** | 75.01 kB | 76.43 kB | +2.41% | 18.15 kB | 18.59 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.89%** | 75.01 kB | 76.43 kB | +2.41% | 18.15 kB | 18.59 kB\n| [oss-stable-semver/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.79%** | 30.52 kB | 31.07 kB | +3.61% | 6.51 kB | 6.74 kB\n| [oss-stable/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.79%** | 30.52 kB | 31.07 kB | +3.61% | 6.51 kB | 6.74 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.74%** | 29.03 kB | 29.53 kB | +3.85% | 6.56 kB | 6.82 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.74%** | 29.03 kB | 29.53 kB | +3.85% | 6.56 kB | 6.82 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.65%** | 30.57 kB | 31.08 kB | +3.69% | 6.94 kB | 7.20 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.65%** | 30.57 kB | 31.08 kB | +3.69% | 6.94 kB | 7.20 kB\n| [oss-experimental/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.63%** | 86.34 kB | 87.75 kB | +2.15% | 19.53 kB | 19.95 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.63%** | 30.91 kB | 31.41 kB | +3.63% | 7.02 kB | 7.27 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.63%** | 30.91 kB | 31.41 kB | +3.63% | 7.02 kB | 7.27 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.63%** | 86.35 kB | 87.75 kB | +2.20% | 19.24 kB | 19.67 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.63%** | 86.59 kB | 87.99 kB | +2.19% | 19.31 kB | 19.73 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.59%** | 62.45 kB | 63.45 kB | +1.74% | 13.97 kB | 14.21 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.59%** | 62.45 kB | 63.45 kB | +1.74% | 13.97 kB | 14.21 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.57%** | 89.84 kB | 91.24 kB | +2.11% | 20.27 kB | 20.70 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.56%** | 90.35 kB | 91.75 kB | +2.09% | 20.44 kB | 20.87 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.53%** | 63.67 kB | 64.64 kB | +1.69% | 13.99 kB | 14.22 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.53%** | 63.67 kB | 64.64 kB | +1.69% | 13.99 kB | 14.22 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.52%** | 33.22 kB | 33.72 kB | +3.26% | 7.56 kB | 7.80 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.52%** | 33.22 kB | 33.72 kB | +3.26% | 7.56 kB | 7.80 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.51%** | 64.46 kB | 65.43 kB | +1.60% | 14.23 kB | 14.45 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.51%** | 64.46 kB | 65.43 kB | +1.60% | 14.23 kB | 14.45 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.50%** | 64.75 kB | 65.72 kB | +1.62% | 14.21 kB | 14.44 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.50%** | 64.75 kB | 65.72 kB | +1.62% | 14.21 kB | 14.44 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.50%** | 83.70 kB | 84.95 kB | +1.64% | 17.26 kB | 17.54 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.49%** | 94.26 kB | 95.67 kB | +2.00% | 21.34 kB | 21.76 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.49%** | 65.20 kB | 66.17 kB | +1.60% | 14.36 kB | 14.59 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.49%** | 65.20 kB | 66.17 kB | +1.60% | 14.36 kB | 14.59 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.47%** | 67.26 kB | 68.25 kB | +1.64% | 14.70 kB | 14.94 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.47%** | 67.26 kB | 68.25 kB | +1.64% | 14.70 kB | 14.94 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.47%** | 96.05 kB | 97.46 kB | +1.95% | 21.91 kB | 22.33 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.47%** | 96.08 kB | 97.49 kB | +1.95% | 21.93 kB | 22.36 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.46%** | 34.47 kB | 34.97 kB | +3.09% | 7.83 kB | 8.07 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.46%** | 34.47 kB | 34.97 kB | +3.09% | 7.83 kB | 8.07 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.46%** | 34.47 kB | 34.97 kB | +3.05% | 7.84 kB | 8.07 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.46%** | 34.47 kB | 34.97 kB | +3.05% | 7.84 kB | 8.07 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.46%** | 85.69 kB | 86.94 kB | +1.63% | 17.38 kB | 17.67 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.45%** | 68.22 kB | 69.21 kB | +1.64% | 14.91 kB | 15.15 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.45%** | 68.22 kB | 69.21 kB | +1.64% | 14.91 kB | 15.15 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.45%** | 68.35 kB | 69.35 kB | +1.64% | 14.91 kB | 15.16 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.45%** | 68.35 kB | 69.35 kB | +1.64% | 14.91 kB | 15.16 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.45%** | 86.57 kB | 87.82 kB | +1.65% | 17.63 kB | 17.92 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.44%** | 97.48 kB | 98.89 kB | +1.94% | 22.28 kB | 22.71 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.44%** | 97.51 kB | 98.92 kB | +1.94% | 22.32 kB | 22.75 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.44%** | 86.77 kB | 88.02 kB | +1.60% | 17.62 kB | 17.90 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 87.30 kB | 88.56 kB | +1.66% | 17.77 kB | 18.07 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 35.15 kB | 35.65 kB | +3.03% | 8.01 kB | 8.25 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 35.15 kB | 35.65 kB | +3.03% | 8.01 kB | 8.25 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 35.16 kB | 35.66 kB | +3.06% | 8.00 kB | 8.24 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 35.16 kB | 35.66 kB | +3.06% | 8.00 kB | 8.24 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 69.30 kB | 70.29 kB | +1.62% | 15.13 kB | 15.38 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 69.30 kB | 70.29 kB | +1.62% | 15.13 kB | 15.38 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 98.55 kB | 99.96 kB | +1.91% | 22.48 kB | 22.91 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.43%** | 98.58 kB | 99.99 kB | +1.91% | 22.52 kB | 22.95 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.41%** | 88.50 kB | 89.75 kB | +1.52% | 18.01 kB | 18.28 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.40%** | 89.46 kB | 90.71 kB | +1.49% | 18.22 kB | 18.49 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.40%** | 89.60 kB | 90.85 kB | +1.44% | 18.24 kB | 18.50 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.39%** | 36.38 kB | 36.89 kB | +2.91% | 8.21 kB | 8.45 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.39%** | 36.38 kB | 36.89 kB | +2.91% | 8.21 kB | 8.45 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.38%** | 36.39 kB | 36.90 kB | +2.96% | 8.20 kB | 8.44 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.38%** | 36.39 kB | 36.90 kB | +2.96% | 8.20 kB | 8.44 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.38%** | 90.55 kB | 91.80 kB | +1.48% | 18.45 kB | 18.72 kB\n| [oss-experimental/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+1.00%** | 45.39 kB | 45.85 kB | +2.59% | 8.80 kB | 9.03 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.97%** | 42.72 kB | 43.13 kB | +2.80% | 8.86 kB | 9.11 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.93%** | 44.26 kB | 44.67 kB | +2.66% | 9.23 kB | 9.47 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.93%** | 44.59 kB | 45.01 kB | +2.65% | 9.31 kB | 9.56 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.88%** | 47.10 kB | 47.51 kB | +2.49% | 9.89 kB | 10.14 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.85%** | 48.35 kB | 48.77 kB | +2.45% | 10.17 kB | 10.42 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.85%** | 48.35 kB | 48.77 kB | +2.42% | 10.17 kB | 10.42 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.84%** | 49.03 kB | 49.44 kB | +2.41% | 10.34 kB | 10.58 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.84%** | 49.04 kB | 49.46 kB | +2.46% | 10.32 kB | 10.58 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.82%** | 50.07 kB | 50.48 kB | +2.22% | 10.54 kB | 10.77 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.82%** | 50.08 kB | 50.49 kB | +2.27% | 10.52 kB | 10.76 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.69%** | 124.31 kB | 125.16 kB | +0.75% | 28.75 kB | 28.97 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.69%** | 124.31 kB | 125.16 kB | +0.75% | 28.75 kB | 28.97 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.66%** | 127.05 kB | 127.89 kB | +0.66% | 29.29 kB | 29.49 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.66%** | 127.05 kB | 127.89 kB | +0.66% | 29.29 kB | 29.49 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.66%** | 130.47 kB | 131.33 kB | +0.68% | 29.75 kB | 29.96 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.66%** | 130.47 kB | 131.33 kB | +0.68% | 29.75 kB | 29.96 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.65%** | 128.30 kB | 129.14 kB | +0.64% | 29.58 kB | 29.77 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.65%** | 128.30 kB | 129.14 kB | +0.64% | 29.58 kB | 29.77 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.65%** | 129.50 kB | 130.34 kB | +0.61% | 29.96 kB | 30.14 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.65%** | 129.50 kB | 130.34 kB | +0.61% | 29.96 kB | 30.14 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.64%** | 132.76 kB | 133.62 kB | +0.67% | 30.33 kB | 30.54 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.64%** | 132.76 kB | 133.62 kB | +0.67% | 30.33 kB | 30.54 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.64%** | 130.23 kB | 131.07 kB | +0.62% | 30.08 kB | 30.26 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.64%** | 130.23 kB | 131.07 kB | +0.62% | 30.08 kB | 30.26 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.64%** | 133.11 kB | 133.97 kB | +0.64% | 30.56 kB | 30.75 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.64%** | 133.11 kB | 133.97 kB | +0.64% | 30.56 kB | 30.75 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.63%** | 135.40 kB | 136.25 kB | +0.61% | 31.17 kB | 31.36 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.63%** | 135.40 kB | 136.25 kB | +0.61% | 31.17 kB | 31.36 kB\n| [oss-experimental/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.53%** | 56.03 kB | 56.33 kB | +0.31% | 11.14 kB | 11.18 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.50%** | 162.65 kB | 163.47 kB | +0.34% | 35.68 kB | 35.80 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.49%** | 166.29 kB | 167.11 kB | +0.32% | 36.33 kB | 36.44 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.49%** | 168.22 kB | 169.04 kB | +0.32% | 36.85 kB | 36.97 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.49%** | 168.74 kB | 169.56 kB | +0.32% | 37.00 kB | 37.12 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.49%** | 168.81 kB | 169.63 kB | +0.39% | 36.66 kB | 36.80 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.48%** | 170.15 kB | 170.97 kB | +0.32% | 37.37 kB | 37.49 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.48%** | 171.10 kB | 171.92 kB | +0.34% | 37.28 kB | 37.40 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.48%** | 171.45 kB | 172.27 kB | +0.33% | 37.49 kB | 37.62 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.47%** | 173.74 kB | 174.56 kB | +0.32% | 38.11 kB | 38.24 kB\n| [oss-stable-semver/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 41.69 kB | 41.83 kB | +0.26% | 9.11 kB | 9.13 kB\n| [oss-stable/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 41.69 kB | 41.83 kB | +0.26% | 9.11 kB | 9.13 kB\n| [oss-stable-semver/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable-semver/react-server/cjs/react-server-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 87.25 kB | 87.04 kB | = | 20.29 kB | 20.25 kB\n| [oss-stable/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/oss-stable/react-server/cjs/react-server-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 87.25 kB | 87.04 kB | = | 20.29 kB | 20.25 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/dd30d43b3e2600ec12243b860b0b44aa2e936cb0/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against dd30d43b3e2600ec12243b860b0b44aa2e936cb0\n</p>\n"
] | 2024-05-06 02:26:18 | 2024-05-06 02:30:13 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28997', 'html_url': 'https://github.com/facebook/react/pull/28997', 'diff_url': 'https://github.com/facebook/react/pull/28997.diff', 'patch_url': 'https://github.com/facebook/react/pull/28997.patch', 'merged_at': None} | Stacked on #28988.
Uses the same technique as in #28996 to encode references to already emitted objects. This now means that Reply can support cyclic objects too for parity.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28997/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28997/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28996 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28996/labels{/name} | https://api.github.com/repos/facebook/react/issues/28996/comments | https://api.github.com/repos/facebook/react/issues/28996/events | https://github.com/facebook/react/pull/28996 | 2,279,856,062 | PR_kwDOAJy2Ks5ulTyj | 28,996 | [Flight] Encode references to existing objects by property path | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46abd7b1deb42d23b65480432609a2f8c5014cde...01fe345fb87a55f072e10a15ed5d8189f71b8025\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/facebook-www/ReactDOM-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/facebook-www/ReactDOM-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.85%** | 29.03 kB | 29.27 kB | +1.57% | 6.56 kB | 6.67 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.85%** | 29.03 kB | 29.27 kB | +1.57% | 6.56 kB | 6.67 kB\n| [oss-stable-semver/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.81%** | 30.52 kB | 30.77 kB | +1.40% | 6.51 kB | 6.60 kB\n| [oss-stable/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.81%** | 30.52 kB | 30.77 kB | +1.40% | 6.51 kB | 6.60 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.80%** | 30.57 kB | 30.82 kB | +1.53% | 6.94 kB | 7.05 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.80%** | 30.57 kB | 30.82 kB | +1.53% | 6.94 kB | 7.05 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.80%** | 30.91 kB | 31.15 kB | +1.48% | 7.02 kB | 7.12 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.80%** | 30.91 kB | 31.15 kB | +1.48% | 7.02 kB | 7.12 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.74%** | 33.22 kB | 33.46 kB | +1.38% | 7.56 kB | 7.66 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.74%** | 33.22 kB | 33.46 kB | +1.38% | 7.56 kB | 7.66 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.71%** | 34.47 kB | 34.71 kB | +1.34% | 7.83 kB | 7.93 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.71%** | 34.47 kB | 34.71 kB | +1.34% | 7.83 kB | 7.93 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.71%** | 34.47 kB | 34.71 kB | +1.30% | 7.84 kB | 7.94 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.71%** | 34.47 kB | 34.71 kB | +1.30% | 7.84 kB | 7.94 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.70%** | 35.15 kB | 35.39 kB | +1.27% | 8.01 kB | 8.11 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.70%** | 35.15 kB | 35.39 kB | +1.27% | 8.01 kB | 8.11 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.70%** | 35.16 kB | 35.40 kB | +1.31% | 8.00 kB | 8.10 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.70%** | 35.16 kB | 35.40 kB | +1.31% | 8.00 kB | 8.10 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.68%** | 36.38 kB | 36.63 kB | +1.18% | 8.21 kB | 8.31 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.68%** | 36.38 kB | 36.63 kB | +1.18% | 8.21 kB | 8.31 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.68%** | 36.39 kB | 36.64 kB | +1.22% | 8.20 kB | 8.30 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.68%** | 36.39 kB | 36.64 kB | +1.22% | 8.20 kB | 8.30 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.54%** | 42.72 kB | 42.95 kB | +1.21% | 8.86 kB | 8.97 kB\n| [oss-experimental/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.53%** | 56.03 kB | 56.33 kB | +0.31% | 11.14 kB | 11.18 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.52%** | 44.26 kB | 44.49 kB | +1.14% | 9.23 kB | 9.33 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.52%** | 44.59 kB | 44.83 kB | +1.14% | 9.31 kB | 9.42 kB\n| [oss-experimental/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-client/cjs/react-client-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.52%** | 45.39 kB | 45.63 kB | +1.03% | 8.80 kB | 8.89 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.49%** | 47.10 kB | 47.33 kB | +1.06% | 9.89 kB | 10.00 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.48%** | 48.35 kB | 48.58 kB | +1.05% | 10.17 kB | 10.27 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.48%** | 48.35 kB | 48.59 kB | +1.01% | 10.17 kB | 10.27 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.47%** | 49.03 kB | 49.26 kB | +1.11% | 10.34 kB | 10.45 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.47%** | 49.04 kB | 49.27 kB | +1.14% | 10.32 kB | 10.44 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.46%** | 50.07 kB | 50.30 kB | +0.94% | 10.54 kB | 10.64 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.46%** | 50.08 kB | 50.31 kB | +0.97% | 10.52 kB | 10.63 kB\n| [oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.46%** | 46.38 kB | 46.60 kB | +0.75% | 10.78 kB | 10.87 kB\n| [oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.46%** | 46.38 kB | 46.60 kB | +0.75% | 10.78 kB | 10.87 kB\n| [oss-stable-semver/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 62.77 kB | 62.97 kB | +0.48% | 15.16 kB | 15.23 kB\n| [oss-stable/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 62.77 kB | 62.97 kB | +0.48% | 15.16 kB | 15.23 kB\n| [oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 62.78 kB | 62.98 kB | +0.50% | 14.87 kB | 14.94 kB\n| [oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 62.78 kB | 62.98 kB | +0.50% | 14.87 kB | 14.94 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 63.02 kB | 63.22 kB | +0.49% | 14.93 kB | 15.01 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 63.02 kB | 63.22 kB | +0.49% | 14.93 kB | 15.01 kB\n| [oss-stable-semver/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 41.69 kB | 41.83 kB | +0.26% | 9.11 kB | 9.13 kB\n| [oss-stable/react-server/cjs/react-server-flight.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server/cjs/react-server-flight.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.32%** | 41.69 kB | 41.83 kB | +0.26% | 9.11 kB | 9.13 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.31%** | 66.27 kB | 66.47 kB | +0.47% | 15.90 kB | 15.97 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.31%** | 66.27 kB | 66.47 kB | +0.47% | 15.90 kB | 15.97 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.30%** | 66.78 kB | 66.98 kB | +0.46% | 16.07 kB | 16.14 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.30%** | 66.78 kB | 66.98 kB | +0.46% | 16.07 kB | 16.14 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 83.70 kB | 83.94 kB | +0.25% | 17.26 kB | 17.30 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 69.55 kB | 69.75 kB | +0.50% | 15.05 kB | 15.13 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 70.70 kB | 70.90 kB | +0.44% | 16.97 kB | 17.04 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 70.70 kB | 70.90 kB | +0.44% | 16.97 kB | 17.04 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.29%** | 85.69 kB | 85.93 kB | +0.23% | 17.38 kB | 17.42 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 86.57 kB | 86.82 kB | +0.34% | 17.63 kB | 17.69 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 86.77 kB | 87.02 kB | +0.25% | 17.62 kB | 17.66 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 87.30 kB | 87.55 kB | +0.35% | 17.77 kB | 17.83 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 72.48 kB | 72.68 kB | +0.42% | 17.53 kB | 17.60 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 72.48 kB | 72.68 kB | +0.42% | 17.53 kB | 17.60 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 72.51 kB | 72.72 kB | +0.41% | 17.55 kB | 17.63 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 72.51 kB | 72.72 kB | +0.41% | 17.55 kB | 17.63 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.28%** | 88.50 kB | 88.75 kB | +0.21% | 18.01 kB | 18.05 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 89.46 kB | 89.71 kB | +0.24% | 18.22 kB | 18.27 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 73.91 kB | 74.12 kB | +0.39% | 17.90 kB | 17.97 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 73.91 kB | 74.12 kB | +0.39% | 17.90 kB | 17.97 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 89.60 kB | 89.85 kB | +0.21% | 18.24 kB | 18.27 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 73.94 kB | 74.14 kB | +0.41% | 17.94 kB | 18.01 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 73.94 kB | 74.14 kB | +0.41% | 17.94 kB | 18.01 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 90.55 kB | 90.79 kB | +0.25% | 18.45 kB | 18.49 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 74.98 kB | 75.19 kB | +0.39% | 18.11 kB | 18.18 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 74.98 kB | 75.19 kB | +0.39% | 18.11 kB | 18.18 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 75.01 kB | 75.21 kB | +0.40% | 18.15 kB | 18.22 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.27%** | 75.01 kB | 75.21 kB | +0.40% | 18.15 kB | 18.22 kB\n| [oss-experimental/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-client/cjs/react-client-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.22%** | 86.34 kB | 86.53 kB | +0.34% | 19.53 kB | 19.60 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.22%** | 86.35 kB | 86.54 kB | +0.42% | 19.24 kB | 19.32 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.22%** | 86.59 kB | 86.78 kB | +0.42% | 19.31 kB | 19.39 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.21%** | 89.84 kB | 90.03 kB | +0.39% | 20.27 kB | 20.35 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.21%** | 90.35 kB | 90.54 kB | +0.39% | 20.44 kB | 20.52 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.20%** | 94.26 kB | 94.46 kB | +0.34% | 21.34 kB | 21.41 kB\n| [oss-stable-semver/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable-semver/react-server/cjs/react-server-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 87.25 kB | 87.04 kB | = | 20.29 kB | 20.25 kB\n| [oss-stable/react-server/cjs/react-server-flight.development.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/oss-stable/react-server/cjs/react-server-flight.development.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 87.25 kB | 87.04 kB | = | 20.29 kB | 20.25 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/01fe345fb87a55f072e10a15ed5d8189f71b8025/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 01fe345fb87a55f072e10a15ed5d8189f71b8025\n</p>\n"
] | 2024-05-06 01:27:54 | 2024-05-06 14:43:27 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28996', 'html_url': 'https://github.com/facebook/react/pull/28996', 'diff_url': 'https://github.com/facebook/react/pull/28996.diff', 'patch_url': 'https://github.com/facebook/react/pull/28996.patch', 'merged_at': None} | Instead of forcing an object to be outlined to be able to refer to it later we can refer to it by the property path inside another parent object.
E.g. this encodes such a reference as `'$123:props:children:foo:bar'`.
That way we don't have to preemptively outline object and we can dedupe after the first time we've found it.
There's no cost on the client if it's not used because we're not storing any additional information preemptively.
This works mainly because we only have simple JSON objects from the root reference. Complex objects like Map, FormData etc. are stored as their entries array in the look up and not the complex object. Other complex objects like TypedArrays or imports don't have deeply nested objects in them that can be referenced.
This solves the problem that we only dedupe after the third instance. This dedupes at the second instance. It also solves the problem where all nested objects inside deduped instances also are outlined.
The property paths can get pretty large. This is why a test on payload size increased. We could potentially outline the reference itself at the first dupe. That way we get a shorter ID to refer to in the third instance. | {'url': 'https://api.github.com/repos/facebook/react/issues/28996/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28996/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28994 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28994/labels{/name} | https://api.github.com/repos/facebook/react/issues/28994/comments | https://api.github.com/repos/facebook/react/issues/28994/events | https://github.com/facebook/react/issues/28994 | 2,279,580,943 | I_kwDOAJy2Ks6H36UP | 28,994 | [React 19] Issue with server action "use server" and exported error (Maybe NextJS) | {'login': 'ScreamZ', 'id': 6640835, 'node_id': 'MDQ6VXNlcjY2NDA4MzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6640835?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ScreamZ', 'html_url': 'https://github.com/ScreamZ', 'followers_url': 'https://api.github.com/users/ScreamZ/followers', 'following_url': 'https://api.github.com/users/ScreamZ/following{/other_user}', 'gists_url': 'https://api.github.com/users/ScreamZ/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ScreamZ/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ScreamZ/subscriptions', 'organizations_url': 'https://api.github.com/users/ScreamZ/orgs', 'repos_url': 'https://api.github.com/users/ScreamZ/repos', 'events_url': 'https://api.github.com/users/ScreamZ/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ScreamZ/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [] | 2024-05-05 15:17:41 | 2024-05-05 15:18:19 | null | NONE | null | null | null | Hi,
Not sure if this is related to NextJS or React.
exporting an enum from a server action in a file with `"use server"` results in
```
Error: A "use server" file can only export async functions, found object.
```
Ok, perfect.
Now just add a `use client` to your page. No more error.
In my example I try to print `Object.values(ContactFormTopics)` which gives me an empty array. This is error-prone, maybe we need a way to detect such use case
https://codesandbox.io/p/devbox/old-voice-mt3592?file=%2Fapp%2Fpage.tsx | {'url': 'https://api.github.com/repos/facebook/react/issues/28994/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28994/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28993 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28993/labels{/name} | https://api.github.com/repos/facebook/react/issues/28993/comments | https://api.github.com/repos/facebook/react/issues/28993/events | https://github.com/facebook/react/pull/28993 | 2,279,024,241 | PR_kwDOAJy2Ks5uix5j | 28,993 | refactored shebangs | {'login': 'MarcoKrooss', 'id': 64379347, 'node_id': 'MDQ6VXNlcjY0Mzc5MzQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/64379347?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MarcoKrooss', 'html_url': 'https://github.com/MarcoKrooss', 'followers_url': 'https://api.github.com/users/MarcoKrooss/followers', 'following_url': 'https://api.github.com/users/MarcoKrooss/following{/other_user}', 'gists_url': 'https://api.github.com/users/MarcoKrooss/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/MarcoKrooss/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/MarcoKrooss/subscriptions', 'organizations_url': 'https://api.github.com/users/MarcoKrooss/orgs', 'repos_url': 'https://api.github.com/users/MarcoKrooss/repos', 'events_url': 'https://api.github.com/users/MarcoKrooss/events{/privacy}', 'received_events_url': 'https://api.github.com/users/MarcoKrooss/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @MarcoKrooss! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328993). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46abd7b1deb42d23b65480432609a2f8c5014cde...4db593f4c8c3f80d96f0426458844f2010f7df75\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/4db593f4c8c3f80d96f0426458844f2010f7df75/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/4db593f4c8c3f80d96f0426458844f2010f7df75/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/4db593f4c8c3f80d96f0426458844f2010f7df75/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/4db593f4c8c3f80d96f0426458844f2010f7df75/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/4db593f4c8c3f80d96f0426458844f2010f7df75/files/facebook-www/ReactDOM-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/4db593f4c8c3f80d96f0426458844f2010f7df75/files/facebook-www/ReactDOM-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/4db593f4c8c3f80d96f0426458844f2010f7df75/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/4db593f4c8c3f80d96f0426458844f2010f7df75/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 4db593f4c8c3f80d96f0426458844f2010f7df75\n</p>\n"
] | 2024-05-04 14:32:12 | 2024-05-04 14:36:48 | 2024-05-04 14:33:10 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28993', 'html_url': 'https://github.com/facebook/react/pull/28993', 'diff_url': 'https://github.com/facebook/react/pull/28993.diff', 'patch_url': 'https://github.com/facebook/react/pull/28993.patch', 'merged_at': None} | ## Summary
I am new to a lot of this so I tried something new.
I changed the shebangs of 4 files in total.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28993/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28993/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28992 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28992/labels{/name} | https://api.github.com/repos/facebook/react/issues/28992/comments | https://api.github.com/repos/facebook/react/issues/28992/events | https://github.com/facebook/react/issues/28992 | 2,279,013,863 | I_kwDOAJy2Ks6H1v3n | 28,992 | [React 19] prop-types removal alternative / console component trace | {'login': 'oliviertassinari', 'id': 3165635, 'node_id': 'MDQ6VXNlcjMxNjU2MzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3165635?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/oliviertassinari', 'html_url': 'https://github.com/oliviertassinari', 'followers_url': 'https://api.github.com/users/oliviertassinari/followers', 'following_url': 'https://api.github.com/users/oliviertassinari/following{/other_user}', 'gists_url': 'https://api.github.com/users/oliviertassinari/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/oliviertassinari/subscriptions', 'organizations_url': 'https://api.github.com/users/oliviertassinari/orgs', 'repos_url': 'https://api.github.com/users/oliviertassinari/repos', 'events_url': 'https://api.github.com/users/oliviertassinari/events{/privacy}', 'received_events_url': 'https://api.github.com/users/oliviertassinari/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [] | 2024-05-04 14:09:01 | 2024-05-06 18:05:02 | null | CONTRIBUTOR | null | null | null | ## Summary
The state of `.propTypes` is a bit unclear. I see:
1. https://react.dev/blog/2024/04/25/react-19 doesn't mention their deprecation but https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops does. Should the two pages by synced?
2. https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops says:
<img width="455" alt="image" src="https://github.com/facebook/react/assets/3165635/1da94ce8-583d-4c34-bf5c-d358b1bb057f">
But it looks inaccurate, I would expect it says that `React.PropTypes` were deprecated from the source linked.
<img width="854" alt="SCR-20240504-buph" src="https://github.com/facebook/react/assets/3165635/eeac92b4-b210-43ec-87d1-6cb3c01a2a70">
[Source](https://legacy.reactjs.org/blog/2017/04/07/react-v15.5.0.html#react)
3. The migration guides encourage to migrate to "TypeScript or another type-checking solution", but TypeScript has a limited type coverage. For instance, it doesn't support integers. We rely on this e.g.
```jsx
Autocomplete.propTypes = {
/**
* The maximum number of tags that will be visible when not focused.
* Set `-1` to disable the limit.
* @default -1
*/
limitTags: integerPropType,
```
https://github.com/mui/material-ui/blob/2827bacf567fc95ef147d543316ffe688896db90/packages/mui-material/src/Autocomplete/Autocomplete.js#L985-L990
So to replace this, it seems that the closest alternative is to do something like this:
```jsx
function DemoComponent(props) {
if (process.env.NODE_ENV !== "production") {
if (typeof props.bar !== "string") {
console.error(
`Warning: Failed prop type: Invalid prop \`bar\` of type \`number\` supplied to \`DemoComponent\`, expected \`string\`.`
);
}
}
return null;
}
```
Unfortunately, it's missing the component trace.
Before: https://codesandbox.io/p/sandbox/mystifying-mcclintock-mf7r5m?file=%2Fsrc%2FDemo.js%3A16%2C1
<img width="538" alt="SCR-20240504-oepf" src="https://github.com/facebook/react/assets/3165635/64408083-e139-4eb5-a8b9-3e9430f69c03">
After: https://codesandbox.io/p/sandbox/agitated-orla-8kj8rh?file=%2Fsrc%2Findex.js
<img width="705" alt="SCR-20240504-oehu" src="https://github.com/facebook/react/assets/3165635/9ce5468a-af80-46e9-825d-e2aace61d2bb">
It seems much harder to figure out where console logs come from. So while https://react.dev/blog/2024/04/25/react-19#diffs-for-hydration-errors is a great step forward, this one feels like a step backward. Is there an alternative to it?
There is a function in https://github.com/facebook/prop-types/blob/1c9c6311c1fb8778bffc7a1ca70c273ee8a8654d/checkPropTypes.js#L20 but it doesn't log the component trace either. | {'url': 'https://api.github.com/repos/facebook/react/issues/28992/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28992/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28991 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28991/labels{/name} | https://api.github.com/repos/facebook/react/issues/28991/comments | https://api.github.com/repos/facebook/react/issues/28991/events | https://github.com/facebook/react/pull/28991 | 2,278,839,088 | PR_kwDOAJy2Ks5uiMip | 28,991 | Sanitize key in Developer Tools display | {'login': 'tarunkishore2303', 'id': 53224551, 'node_id': 'MDQ6VXNlcjUzMjI0NTUx', 'avatar_url': 'https://avatars.githubusercontent.com/u/53224551?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tarunkishore2303', 'html_url': 'https://github.com/tarunkishore2303', 'followers_url': 'https://api.github.com/users/tarunkishore2303/followers', 'following_url': 'https://api.github.com/users/tarunkishore2303/following{/other_user}', 'gists_url': 'https://api.github.com/users/tarunkishore2303/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/tarunkishore2303/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/tarunkishore2303/subscriptions', 'organizations_url': 'https://api.github.com/users/tarunkishore2303/orgs', 'repos_url': 'https://api.github.com/users/tarunkishore2303/repos', 'events_url': 'https://api.github.com/users/tarunkishore2303/events{/privacy}', 'received_events_url': 'https://api.github.com/users/tarunkishore2303/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | open | false | {'login': 'hoxyq', 'id': 28902667.0, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_url': 'https://api.github.com/users/hoxyq/following{/other_user}', 'gists_url': 'https://api.github.com/users/hoxyq/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hoxyq/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hoxyq/subscriptions', 'organizations_url': 'https://api.github.com/users/hoxyq/orgs', 'repos_url': 'https://api.github.com/users/hoxyq/repos', 'events_url': 'https://api.github.com/users/hoxyq/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hoxyq/received_events', 'type': 'User', 'site_admin': False} | [{'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_url': 'https://api.github.com/users/hoxyq/following{/other_user}', 'gists_url': 'https://api.github.com/users/hoxyq/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hoxyq/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hoxyq/subscriptions', 'organizations_url': 'https://api.github.com/users/hoxyq/orgs', 'repos_url': 'https://api.github.com/users/hoxyq/repos', 'events_url': 'https://api.github.com/users/hoxyq/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hoxyq/received_events', 'type': 'User', 'site_admin': False}] | null | [
"Hi @tarunkishore2303! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328991). Thanks!",
"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!",
"Not sure devtools should just modify and display something different. That seems like it could easily be confusing - especially when that small difference is the cause of some sort of bug and need debugging.\r\n\r\nNot sure if this is a common issue as I don't work on devtools, maybe it could display invisible characters such as newline escape codes like JSON, i.e. `\\n`?\r\n\r\n@hoxyq "
] | 2024-05-04 08:25:32 | 2024-05-06 15:48:39 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28991', 'html_url': 'https://github.com/facebook/react/pull/28991', 'diff_url': 'https://github.com/facebook/react/pull/28991.diff', 'patch_url': 'https://github.com/facebook/react/pull/28991.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
Added an utility function to sanitize the string before displaying it in tree
Finishes #28984
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
Added test cases for the utility function that has been created.
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28991/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28991/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28990 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28990/labels{/name} | https://api.github.com/repos/facebook/react/issues/28990/comments | https://api.github.com/repos/facebook/react/issues/28990/events | https://github.com/facebook/react/pull/28990 | 2,278,727,579 | PR_kwDOAJy2Ks5uh2BV | 28,990 | Setup Wave 2 of Feature Flags for React Native | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'following_url': 'https://api.github.com/users/yungsters/following{/other_user}', 'gists_url': 'https://api.github.com/users/yungsters/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yungsters/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yungsters/subscriptions', 'organizations_url': 'https://api.github.com/users/yungsters/orgs', 'repos_url': 'https://api.github.com/users/yungsters/repos', 'events_url': 'https://api.github.com/users/yungsters/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yungsters/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 46abd7b1deb42d23b65480432609a2f8c5014cde...997a160d23e6a26d9e3e337a89772a4206bc113b\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.92 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-www/ReactDOM-prod.classic.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-www/ReactDOM-prod.modern.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [facebook-react-native/react/cjs/JSXRuntime-prod.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/JSXRuntime-prod.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+40.58%** | 2.98 kB | 4.19 kB | +18.53% | 1.27 kB | 1.50 kB\n| [facebook-react-native/react/cjs/JSXRuntime-profiling.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/JSXRuntime-profiling.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+40.58%** | 2.98 kB | 4.19 kB | +18.53% | 1.27 kB | 1.50 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/React-prod.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+9.22%** | 21.25 kB | 23.20 kB | +6.42% | 5.61 kB | 5.97 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/React-profiling.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+9.03%** | 21.68 kB | 23.64 kB | +6.33% | 5.69 kB | 6.05 kB\n| [facebook-react-native/react/cjs/JSXDEVRuntime-dev.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/JSXDEVRuntime-dev.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+8.96%** | 47.31 kB | 51.55 kB | +7.70% | 13.64 kB | 14.69 kB\n| [facebook-react-native/react/cjs/JSXRuntime-dev.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/JSXRuntime-dev.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+8.73%** | 48.54 kB | 52.78 kB | +7.45% | 14.01 kB | 15.05 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/React-dev.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+4.35%** | 109.92 kB | 114.70 kB | +3.77% | 28.93 kB | 30.02 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-react-native/react/cjs/JSXRuntime-prod.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/JSXRuntime-prod.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+40.58%** | 2.98 kB | 4.19 kB | +18.53% | 1.27 kB | 1.50 kB\n| [facebook-react-native/react/cjs/JSXRuntime-profiling.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/JSXRuntime-profiling.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+40.58%** | 2.98 kB | 4.19 kB | +18.53% | 1.27 kB | 1.50 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/React-prod.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+9.22%** | 21.25 kB | 23.20 kB | +6.42% | 5.61 kB | 5.97 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/React-profiling.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+9.03%** | 21.68 kB | 23.64 kB | +6.33% | 5.69 kB | 6.05 kB\n| [facebook-react-native/react/cjs/JSXDEVRuntime-dev.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/JSXDEVRuntime-dev.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+8.96%** | 47.31 kB | 51.55 kB | +7.70% | 13.64 kB | 14.69 kB\n| [facebook-react-native/react/cjs/JSXRuntime-dev.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/JSXRuntime-dev.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+8.73%** | 48.54 kB | 52.78 kB | +7.45% | 14.01 kB | 15.05 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/facebook-react-native/react/cjs/React-dev.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+4.35%** | 109.92 kB | 114.70 kB | +3.77% | 28.93 kB | 30.02 kB\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/react-native/implementations/ReactFabric-prod.fb.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.36%** | 364.86 kB | 366.17 kB | +0.59% | 63.75 kB | 64.13 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.35%** | 372.20 kB | 373.51 kB | +0.56% | 65.06 kB | 65.42 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.33%** | 392.16 kB | 393.46 kB | +0.55% | 67.98 kB | 68.35 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **+0.33%** | 399.44 kB | 400.74 kB | +0.54% | 69.35 kB | 69.73 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/997a160d23e6a26d9e3e337a89772a4206bc113b/files/__test_utils__/ReactAllWarnings.js?compare=46abd7b1deb42d23b65480432609a2f8c5014cde) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 997a160d23e6a26d9e3e337a89772a4206bc113b\n</p>\n"
] | 2024-05-04 04:34:42 | 2024-05-06 17:30:46 | 2024-05-06 17:30:40 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28990', 'html_url': 'https://github.com/facebook/react/pull/28990', 'diff_url': 'https://github.com/facebook/react/pull/28990.diff', 'patch_url': 'https://github.com/facebook/react/pull/28990.patch', 'merged_at': datetime.datetime(2024, 5, 6, 17, 30, 40)} | ## Summary
Sets up dynamic feature flags for `disableStringRefs`, `enableFastJSX`, and `enableRefAsProp` in React Native (at Meta).
## How did you test this change?
```
$ yarn test
$ yarn flow fabric
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28990/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28990/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28989 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28989/labels{/name} | https://api.github.com/repos/facebook/react/issues/28989/comments | https://api.github.com/repos/facebook/react/issues/28989/events | https://github.com/facebook/react/pull/28989 | 2,278,435,672 | PR_kwDOAJy2Ks5ug3iT | 28,989 | Update `compiled-rn` destination paths to `vendor/react` | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'following_url': 'https://api.github.com/users/yungsters/following{/other_user}', 'gists_url': 'https://api.github.com/users/yungsters/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yungsters/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yungsters/subscriptions', 'organizations_url': 'https://api.github.com/users/yungsters/orgs', 'repos_url': 'https://api.github.com/users/yungsters/repos', 'events_url': 'https://api.github.com/users/yungsters/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yungsters/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 5fcfd71638401958d437e74f8cf384c4c1ba4665...25c795d75e6aeeee306e8fad8842d3a5fb47440e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/25c795d75e6aeeee306e8fad8842d3a5fb47440e/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=5fcfd71638401958d437e74f8cf384c4c1ba4665) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/25c795d75e6aeeee306e8fad8842d3a5fb47440e/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=5fcfd71638401958d437e74f8cf384c4c1ba4665) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/25c795d75e6aeeee306e8fad8842d3a5fb47440e/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=5fcfd71638401958d437e74f8cf384c4c1ba4665) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/25c795d75e6aeeee306e8fad8842d3a5fb47440e/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=5fcfd71638401958d437e74f8cf384c4c1ba4665) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/25c795d75e6aeeee306e8fad8842d3a5fb47440e/files/facebook-www/ReactDOM-prod.classic.js?compare=5fcfd71638401958d437e74f8cf384c4c1ba4665) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/25c795d75e6aeeee306e8fad8842d3a5fb47440e/files/facebook-www/ReactDOM-prod.modern.js?compare=5fcfd71638401958d437e74f8cf384c4c1ba4665) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/25c795d75e6aeeee306e8fad8842d3a5fb47440e/files/__test_utils__/ReactAllWarnings.js?compare=5fcfd71638401958d437e74f8cf384c4c1ba4665) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/25c795d75e6aeeee306e8fad8842d3a5fb47440e/files/__test_utils__/ReactAllWarnings.js?compare=5fcfd71638401958d437e74f8cf384c4c1ba4665) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 25c795d75e6aeeee306e8fad8842d3a5fb47440e\n</p>\n"
] | 2024-05-03 21:15:49 | 2024-05-03 22:46:47 | 2024-05-03 22:46:44 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28989', 'html_url': 'https://github.com/facebook/react/pull/28989', 'diff_url': 'https://github.com/facebook/react/pull/28989.diff', 'patch_url': 'https://github.com/facebook/react/pull/28989.patch', 'merged_at': datetime.datetime(2024, 5, 3, 22, 46, 43)} | I'm changing the destination paths in fbsource from `vendor/*` to `vendor/react/*`. | {'url': 'https://api.github.com/repos/facebook/react/issues/28989/reactions', 'total_count': 3, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28989/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28988 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28988/labels{/name} | https://api.github.com/repos/facebook/react/issues/28988/comments | https://api.github.com/repos/facebook/react/issues/28988/events | https://github.com/facebook/react/pull/28988 | 2,278,248,022 | PR_kwDOAJy2Ks5ugQLx | 28,988 | [Flight Reply] Resolve outlined models async in Reply just like in Flight Client | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f...90a7f4d5fc697997254bdd3c1340e6c446f38cba\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/facebook-www/ReactDOM-prod.classic.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/facebook-www/ReactDOM-prod.modern.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/__test_utils__/ReactAllWarnings.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.52%** | 77.68 kB | 78.08 kB | +0.56% | 16.16 kB | 16.25 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.51%** | 79.17 kB | 79.57 kB | +0.51% | 16.24 kB | 16.32 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.50%** | 80.05 kB | 80.46 kB | +0.50% | 16.48 kB | 16.56 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.50%** | 80.25 kB | 80.66 kB | +0.52% | 16.46 kB | 16.55 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.50%** | 80.79 kB | 81.19 kB | +0.49% | 16.62 kB | 16.71 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.50%** | 62.37 kB | 62.68 kB | +0.56% | 13.95 kB | 14.03 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.50%** | 62.37 kB | 62.68 kB | +0.56% | 13.95 kB | 14.03 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.49%** | 63.59 kB | 63.90 kB | +0.55% | 13.97 kB | 14.05 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.49%** | 63.59 kB | 63.90 kB | +0.55% | 13.97 kB | 14.05 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.49%** | 82.48 kB | 82.88 kB | +0.49% | 16.93 kB | 17.01 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 64.38 kB | 64.69 kB | +0.53% | 14.21 kB | 14.29 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 64.38 kB | 64.69 kB | +0.53% | 14.21 kB | 14.29 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 83.44 kB | 83.84 kB | +0.48% | 17.14 kB | 17.22 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 83.58 kB | 83.98 kB | +0.49% | 17.14 kB | 17.22 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 64.67 kB | 64.98 kB | +0.49% | 14.19 kB | 14.26 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 64.67 kB | 64.98 kB | +0.49% | 14.19 kB | 14.26 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 65.12 kB | 65.43 kB | +0.52% | 14.35 kB | 14.42 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 65.12 kB | 65.43 kB | +0.52% | 14.35 kB | 14.42 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.48%** | 84.53 kB | 84.93 kB | +0.46% | 17.37 kB | 17.45 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.46%** | 67.17 kB | 67.49 kB | +0.52% | 14.68 kB | 14.76 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.46%** | 67.17 kB | 67.49 kB | +0.52% | 14.68 kB | 14.76 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.46%** | 68.13 kB | 68.45 kB | +0.53% | 14.89 kB | 14.97 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.46%** | 68.13 kB | 68.45 kB | +0.53% | 14.89 kB | 14.97 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.46%** | 68.27 kB | 68.58 kB | +0.53% | 14.89 kB | 14.97 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.46%** | 68.27 kB | 68.58 kB | +0.53% | 14.89 kB | 14.97 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.45%** | 69.22 kB | 69.53 kB | +0.56% | 15.11 kB | 15.20 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.45%** | 69.22 kB | 69.53 kB | +0.56% | 15.11 kB | 15.20 kB\n| [oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.41%** | 123.86 kB | 124.37 kB | +0.45% | 28.64 kB | 28.76 kB\n| [oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.41%** | 123.86 kB | 124.37 kB | +0.45% | 28.64 kB | 28.76 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.40%** | 126.78 kB | 127.28 kB | +0.43% | 29.22 kB | 29.35 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.40%** | 126.78 kB | 127.28 kB | +0.43% | 29.22 kB | 29.35 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.39%** | 127.67 kB | 128.17 kB | +0.41% | 29.46 kB | 29.58 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.39%** | 127.67 kB | 128.17 kB | +0.41% | 29.46 kB | 29.58 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.39%** | 129.22 kB | 129.73 kB | +0.39% | 29.89 kB | 30.01 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.39%** | 129.22 kB | 129.73 kB | +0.39% | 29.89 kB | 30.01 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.39%** | 129.60 kB | 130.10 kB | +0.41% | 29.95 kB | 30.07 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.39%** | 129.60 kB | 130.10 kB | +0.41% | 29.95 kB | 30.07 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.39%** | 130.03 kB | 130.53 kB | +0.42% | 29.64 kB | 29.76 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.39%** | 130.03 kB | 130.53 kB | +0.42% | 29.64 kB | 29.76 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.38%** | 132.32 kB | 132.82 kB | +0.43% | 30.22 kB | 30.35 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.38%** | 132.32 kB | 132.82 kB | +0.43% | 30.22 kB | 30.35 kB\n| [oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.38%** | 132.67 kB | 133.17 kB | +0.41% | 30.44 kB | 30.57 kB\n| [oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.38%** | 132.67 kB | 133.17 kB | +0.41% | 30.44 kB | 30.57 kB\n| [oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.37%** | 134.95 kB | 135.45 kB | +0.39% | 31.06 kB | 31.18 kB\n| [oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.37%** | 134.95 kB | 135.45 kB | +0.39% | 31.06 kB | 31.18 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.30%** | 153.75 kB | 154.21 kB | +0.30% | 33.96 kB | 34.07 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.30%** | 156.46 kB | 156.92 kB | +0.31% | 34.50 kB | 34.60 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.29%** | 158.03 kB | 158.49 kB | +0.31% | 34.97 kB | 35.07 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.29%** | 158.91 kB | 159.37 kB | +0.31% | 35.17 kB | 35.27 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.29%** | 159.91 kB | 160.37 kB | +0.31% | 34.98 kB | 35.09 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.29%** | 159.96 kB | 160.42 kB | +0.29% | 35.47 kB | 35.57 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.29%** | 162.20 kB | 162.66 kB | +0.29% | 35.57 kB | 35.67 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.29%** | 162.55 kB | 163.01 kB | +0.28% | 35.80 kB | 35.90 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **+0.28%** | 164.83 kB | 165.30 kB | +0.28% | 36.40 kB | 36.50 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/90a7f4d5fc697997254bdd3c1340e6c446f38cba/files/__test_utils__/ReactAllWarnings.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 90a7f4d5fc697997254bdd3c1340e6c446f38cba\n</p>\n"
] | 2024-05-03 18:56:36 | 2024-05-06 21:27:46 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28988', 'html_url': 'https://github.com/facebook/react/pull/28988', 'diff_url': 'https://github.com/facebook/react/pull/28988.diff', 'patch_url': 'https://github.com/facebook/react/pull/28988.patch', 'merged_at': None} | This is the same change as #28780 but for the Flight Reply receiver.
While it's not possible to create an "async module" reference in this case - resolving a server reference can still be async if loading it requires loading chunks like in a new server instance.
Since extracting a typed array from a Blob is async, that's also a case where a dependency can be async.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28988/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28988/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28987 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28987/labels{/name} | https://api.github.com/repos/facebook/react/issues/28987/comments | https://api.github.com/repos/facebook/react/issues/28987/events | https://github.com/facebook/react/pull/28987 | 2,278,241,463 | PR_kwDOAJy2Ks5ugOxY | 28,987 | [Fizz] Fallback to client replaying actions if we're trying to serialize a Blob | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f...8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 6.66 kB | 6.66 kB | +0.11% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0/files/facebook-www/ReactDOM-prod.classic.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0/files/facebook-www/ReactDOM-prod.modern.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0/files/__test_utils__/ReactAllWarnings.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0/files/__test_utils__/ReactAllWarnings.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8dc0498e76125cb200b9f7b0c7e7a869ee9fc9b0\n</p>\n"
] | 2024-05-03 18:51:21 | 2024-05-06 21:25:04 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28987', 'html_url': 'https://github.com/facebook/react/pull/28987', 'diff_url': 'https://github.com/facebook/react/pull/28987.diff', 'patch_url': 'https://github.com/facebook/react/pull/28987.patch', 'merged_at': None} | This follows the same principle as in #28611.
We cannot serialize Blobs of a form data into HTML because you can't initialize a file input to some value. However the serialization of state in an Action can contain blobs. In this case we do error but outside the try/catch that recovers to error to client replaying instead of MPA mode. This errors earlier to ensure that this works.
Testing this is a bit annoying because JSDOM doesn't have any of the Blob methods but the Blob needs to be compatible with FormData and the FormData needs to be compatible with `<form>` nodes in these tests. So I polyfilled those in JSDOM with some hacks.
A possible future enhancement would be to encode these blobs in a base64 mode instead and have some way to receive them on the server. It's just a matter of layering this. I think the RSC layer's `FORM_DATA` implementation can pass some flag to encode as base64 and then have decodeAction include some way to parse them. That way this case would work in MPA mode too. | {'url': 'https://api.github.com/repos/facebook/react/issues/28987/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28987/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28986 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28986/labels{/name} | https://api.github.com/repos/facebook/react/issues/28986/comments | https://api.github.com/repos/facebook/react/issues/28986/events | https://github.com/facebook/react/pull/28986 | 2,278,231,442 | PR_kwDOAJy2Ks5ugMnb | 28,986 | [Flight Reply] Encode binary streams as a single collapsed Blob | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers', 'following_url': 'https://api.github.com/users/sebmarkbage/following{/other_user}', 'gists_url': 'https://api.github.com/users/sebmarkbage/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/sebmarkbage/subscriptions', 'organizations_url': 'https://api.github.com/users/sebmarkbage/orgs', 'repos_url': 'https://api.github.com/users/sebmarkbage/repos', 'events_url': 'https://api.github.com/users/sebmarkbage/events{/privacy}', 'received_events_url': 'https://api.github.com/users/sebmarkbage/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: ec9400dc41715bb6ff0392d6320c33627fa7e2ba...f6b75aab81d05f007e654e76eafb40de0f5bd1c9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/facebook-www/ReactDOM-prod.classic.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/facebook-www/ReactDOM-prod.modern.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/__test_utils__/ReactAllWarnings.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.77%** | 42.72 kB | 43.47 kB | +0.70% | 8.86 kB | 8.92 kB\n| [oss-experimental/react-client/cjs/react-client-flight.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-client/cjs/react-client-flight.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.76%** | 45.39 kB | 46.19 kB | +0.66% | 8.80 kB | 8.86 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.70%** | 44.26 kB | 45.01 kB | +0.65% | 9.23 kB | 9.29 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.69%** | 44.59 kB | 45.35 kB | +0.64% | 9.31 kB | 9.37 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.60%** | 47.10 kB | 47.86 kB | +0.66% | 9.89 kB | 9.96 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.56%** | 48.35 kB | 49.11 kB | +0.71% | 10.17 kB | 10.24 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.56%** | 48.35 kB | 49.11 kB | +0.73% | 10.17 kB | 10.25 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.54%** | 49.03 kB | 49.79 kB | +0.73% | 10.34 kB | 10.41 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.54%** | 49.04 kB | 49.80 kB | +0.73% | 10.32 kB | 10.40 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.51%** | 50.07 kB | 50.82 kB | +0.65% | 10.54 kB | 10.61 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.51%** | 50.08 kB | 50.83 kB | +0.67% | 10.52 kB | 10.59 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+1.23%** | 69.55 kB | 70.40 kB | = | 15.05 kB | 15.01 kB\n| [oss-experimental/react-client/cjs/react-client-flight.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-client/cjs/react-client-flight.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.99%** | 86.34 kB | 87.19 kB | = | 19.53 kB | 19.50 kB\n| [oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.99%** | 86.35 kB | 87.20 kB | = | 19.24 kB | 19.20 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.98%** | 86.59 kB | 87.44 kB | = | 19.31 kB | 19.27 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.95%** | 89.84 kB | 90.69 kB | = | 20.27 kB | 20.24 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.94%** | 90.35 kB | 91.20 kB | = | 20.44 kB | 20.40 kB\n| [oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.90%** | 94.26 kB | 95.12 kB | = | 21.34 kB | 21.30 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.89%** | 96.05 kB | 96.90 kB | = | 21.91 kB | 21.87 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.89%** | 96.08 kB | 96.93 kB | = | 21.93 kB | 21.90 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.87%** | 97.48 kB | 98.33 kB | = | 22.28 kB | 22.24 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.87%** | 97.51 kB | 98.36 kB | = | 22.32 kB | 22.28 kB\n| [oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.86%** | 98.55 kB | 99.40 kB | = | 22.48 kB | 22.44 kB\n| [oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **+0.86%** | 98.58 kB | 99.43 kB | = | 22.52 kB | 22.49 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f6b75aab81d05f007e654e76eafb40de0f5bd1c9/files/__test_utils__/ReactAllWarnings.js?compare=ec9400dc41715bb6ff0392d6320c33627fa7e2ba) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against f6b75aab81d05f007e654e76eafb40de0f5bd1c9\n</p>\n"
] | 2024-05-03 18:43:32 | 2024-05-06 21:23:20 | null | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28986', 'html_url': 'https://github.com/facebook/react/pull/28986', 'diff_url': 'https://github.com/facebook/react/pull/28986.diff', 'patch_url': 'https://github.com/facebook/react/pull/28986.patch', 'merged_at': None} | Based on #28893.
For other streams we encode each chunk as a separate form field which is a bit bloated. Especially for binary chunks since they also have an indirection. We need some way to encode the chunks as separate anyway. This way the streaming using busboy actually allows each chunk to stream in over the network one at a time.
For binary streams the actual chunking is not important. The chunks can be split and recombined in whatever size chunk makes sense.
Since we buffer the entire content anyway we can combine the chunks to be consecutive. This PR does that with binary streams and also combine them into a single Blob. That way there's no extra overhead when passing through a binary stream.
Ideally, we'd be able to just use the stream from that one Blob but Node.js doesn't return byob streams from Blob. Additionally, we don't actually stream the content of Blobs due to the layering with busboy atm. We could do that for binary streams in particular by replacing the File layering with a stream and resolving each chunk as it comes in. That could be a follow up.
If we stop buffering in the future, this set up still allows us to split them and send other form fields in between while blocked since the protocol is still the same. | {'url': 'https://api.github.com/repos/facebook/react/issues/28986/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28986/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28985 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28985/labels{/name} | https://api.github.com/repos/facebook/react/issues/28985/comments | https://api.github.com/repos/facebook/react/issues/28985/events | https://github.com/facebook/react/issues/28985 | 2,278,085,535 | I_kwDOAJy2Ks6HyNOf | 28,985 | [React 19] | {'login': 'goelharsh', 'id': 100512619, 'node_id': 'U_kgDOBf2zaw', 'avatar_url': 'https://avatars.githubusercontent.com/u/100512619?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/goelharsh', 'html_url': 'https://github.com/goelharsh', 'followers_url': 'https://api.github.com/users/goelharsh/followers', 'following_url': 'https://api.github.com/users/goelharsh/following{/other_user}', 'gists_url': 'https://api.github.com/users/goelharsh/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/goelharsh/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/goelharsh/subscriptions', 'organizations_url': 'https://api.github.com/users/goelharsh/orgs', 'repos_url': 'https://api.github.com/users/goelharsh/repos', 'events_url': 'https://api.github.com/users/goelharsh/events{/privacy}', 'received_events_url': 'https://api.github.com/users/goelharsh/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [] | 2024-05-03 17:03:20 | 2024-05-03 17:03:20 | null | NONE | null | null | null | 1. Congested File Issue: Whenever we download the react package using yarn or node then there are a lot of file that get downloaded everytime and thereby making difficult for beginners to understand the code written inside the "src" file.
If you can remove those packages, it will be helpful, also if you people provide an option that while the user want those files or not then it will be well and better.
2. Optimization Issue while re-rendering the root web-page.
Everytime we reload the webpage the React.strictmode() runs twice and thereby reducing performance of web applications.
If you can remove the dev dependency, that is already been installed while downloading the web-pack. | {'url': 'https://api.github.com/repos/facebook/react/issues/28985/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28985/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28984 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28984/labels{/name} | https://api.github.com/repos/facebook/react/issues/28984/comments | https://api.github.com/repos/facebook/react/issues/28984/events | https://github.com/facebook/react/issues/28984 | 2,277,827,445 | I_kwDOAJy2Ks6HxON1 | 28,984 | [DevTools Bug]: Newline in component key string will look odd in component tree | {'login': 'JannikGM', 'id': 72194488, 'node_id': 'MDQ6VXNlcjcyMTk0NDg4', 'avatar_url': 'https://avatars.githubusercontent.com/u/72194488?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JannikGM', 'html_url': 'https://github.com/JannikGM', 'followers_url': 'https://api.github.com/users/JannikGM/followers', 'following_url': 'https://api.github.com/users/JannikGM/following{/other_user}', 'gists_url': 'https://api.github.com/users/JannikGM/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/JannikGM/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/JannikGM/subscriptions', 'organizations_url': 'https://api.github.com/users/JannikGM/orgs', 'repos_url': 'https://api.github.com/users/JannikGM/repos', 'events_url': 'https://api.github.com/users/JannikGM/events{/privacy}', 'received_events_url': 'https://api.github.com/users/JannikGM/received_events', 'type': 'User', 'site_admin': False} | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | open | false | {'login': 'JannikGM', 'id': 72194488.0, 'node_id': 'MDQ6VXNlcjcyMTk0NDg4', 'avatar_url': 'https://avatars.githubusercontent.com/u/72194488?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JannikGM', 'html_url': 'https://github.com/JannikGM', 'followers_url': 'https://api.github.com/users/JannikGM/followers', 'following_url': 'https://api.github.com/users/JannikGM/following{/other_user}', 'gists_url': 'https://api.github.com/users/JannikGM/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/JannikGM/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/JannikGM/subscriptions', 'organizations_url': 'https://api.github.com/users/JannikGM/orgs', 'repos_url': 'https://api.github.com/users/JannikGM/repos', 'events_url': 'https://api.github.com/users/JannikGM/events{/privacy}', 'received_events_url': 'https://api.github.com/users/JannikGM/received_events', 'type': 'User', 'site_admin': False} | [{'login': 'JannikGM', 'id': 72194488, 'node_id': 'MDQ6VXNlcjcyMTk0NDg4', 'avatar_url': 'https://avatars.githubusercontent.com/u/72194488?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JannikGM', 'html_url': 'https://github.com/JannikGM', 'followers_url': 'https://api.github.com/users/JannikGM/followers', 'following_url': 'https://api.github.com/users/JannikGM/following{/other_user}', 'gists_url': 'https://api.github.com/users/JannikGM/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/JannikGM/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/JannikGM/subscriptions', 'organizations_url': 'https://api.github.com/users/JannikGM/orgs', 'repos_url': 'https://api.github.com/users/JannikGM/repos', 'events_url': 'https://api.github.com/users/JannikGM/events{/privacy}', 'received_events_url': 'https://api.github.com/users/JannikGM/received_events', 'type': 'User', 'site_admin': False}] | null | [
"@JannikGM: We're sorry you've seen this error. ❤️\n\nIt looks like you forgot to specify a valid URL. (This means that we will not be able to reproduce the problem you're reporting.)\n\nPlease help us by providing a link to a CodeSandbox (https://codesandbox.io/s/new), a repository on GitHub, or a minimal code example that reproduces the problem. (Screenshots or videos can also be helpful if they help provide context on how to repro the bug.)\n\nHere are some tips for providing a minimal example: https://stackoverflow.com/help/mcve\n\nIssues without repros are automatically closed but we will re-open if you update with repro info.",
"Looks like a good first-time issue for React DevTools: `key` should be sanitized before displaying in component tree"
] | 2024-05-03 14:42:42 | 2024-05-03 14:45:49 | null | NONE | null | null | null | ### Website or app
/
### Repro steps
Create an element with a key like `Foo\n\n\n\nBar\n\n\n\nBaz` and it will occupy multiple lines in the component tab.
```
<div className='App'>
<h1 key="0-hello\nworld\nfoo\nbar\nbaz">Hello React.</h1>
<h1 key="1-hello\nworld\nfoo\nbar\nbaz">Hello React.</h1>
</div>
```
Here's a screenshot:
<img width="658" alt="react-devtools-bug" src="https://github.com/facebook/react/assets/72194488/5fed3830-e4dd-48f7-ab73-b0e30ed70b44">
Background: I've worked on a syntax-highlighter which adds a <span> for each section of text that's colored differently.
As key, I use the index of the element, it's format name and the actual content of the element.
The content can contain whitespaces or blank lines. It can also be very long strings.
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_ | {'url': 'https://api.github.com/repos/facebook/react/issues/28984/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28984/timeline | null | reopened | false |
https://api.github.com/repos/facebook/react/issues/28983 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28983/labels{/name} | https://api.github.com/repos/facebook/react/issues/28983/comments | https://api.github.com/repos/facebook/react/issues/28983/events | https://github.com/facebook/react/pull/28983 | 2,277,744,928 | PR_kwDOAJy2Ks5ueiVU | 28,983 | Update CNAME in gh-pages | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"Nice, I wouldn't find this for the life of me lol"
] | 2024-05-03 13:59:51 | 2024-05-03 18:06:01 | 2024-05-03 14:05:51 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28983', 'html_url': 'https://github.com/facebook/react/pull/28983', 'diff_url': 'https://github.com/facebook/react/pull/28983.diff', 'patch_url': 'https://github.com/facebook/react/pull/28983.patch', 'merged_at': datetime.datetime(2024, 5, 3, 14, 5, 51)} | Fixes #28968 | {'url': 'https://api.github.com/repos/facebook/react/issues/28983/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28983/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28982 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28982/labels{/name} | https://api.github.com/repos/facebook/react/issues/28982/comments | https://api.github.com/repos/facebook/react/issues/28982/events | https://github.com/facebook/react/pull/28982 | 2,277,633,881 | PR_kwDOAJy2Ks5ueKgM | 28,982 | fix[react-devtools]: add backwards compat with legacy element type symbol | {'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_url': 'https://api.github.com/users/hoxyq/following{/other_user}', 'gists_url': 'https://api.github.com/users/hoxyq/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hoxyq/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hoxyq/subscriptions', 'organizations_url': 'https://api.github.com/users/hoxyq/orgs', 'repos_url': 'https://api.github.com/users/hoxyq/repos', 'events_url': 'https://api.github.com/users/hoxyq/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hoxyq/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [] | 2024-05-03 13:00:00 | 2024-05-03 13:00:12 | null | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28982', 'html_url': 'https://github.com/facebook/react/pull/28982', 'diff_url': 'https://github.com/facebook/react/pull/28982.diff', 'patch_url': 'https://github.com/facebook/react/pull/28982.patch', 'merged_at': None} | Follow-up to https://github.com/facebook/react/pull/28813.
RDT is using `typeOf` from `react-is` to determine the element display name, I've forked an implementation of this method, but will be using legacy element symbol. | {'url': 'https://api.github.com/repos/facebook/react/issues/28982/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28982/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28981 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28981/labels{/name} | https://api.github.com/repos/facebook/react/issues/28981/comments | https://api.github.com/repos/facebook/react/issues/28981/events | https://github.com/facebook/react/issues/28981 | 2,276,959,293 | I_kwDOAJy2Ks6Ht6Q9 | 28,981 | Bug: When setState is called with the same value as before, memory goes up | {'login': 'arturcarvalho', 'id': 2487710, 'node_id': 'MDQ6VXNlcjI0ODc3MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2487710?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/arturcarvalho', 'html_url': 'https://github.com/arturcarvalho', 'followers_url': 'https://api.github.com/users/arturcarvalho/followers', 'following_url': 'https://api.github.com/users/arturcarvalho/following{/other_user}', 'gists_url': 'https://api.github.com/users/arturcarvalho/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/arturcarvalho/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/arturcarvalho/subscriptions', 'organizations_url': 'https://api.github.com/users/arturcarvalho/orgs', 'repos_url': 'https://api.github.com/users/arturcarvalho/repos', 'events_url': 'https://api.github.com/users/arturcarvalho/events{/privacy}', 'received_events_url': 'https://api.github.com/users/arturcarvalho/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-05-03 05:34:07 | 2024-05-03 05:34:07 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
The issue seems to be, when I change a state variable with `setState`, and if I do `setState(x)` and `x` is the same as the current state variable inside a `useInterval` hook, the memory starts to grow. I'm using `usehooks-ts` but I also tried with other hooks (Dan Abramov's hook and Josh Comeau's hook)
This is the code causing the issue:
```ts
const [charge, setCharge] = useState<number>(0);
function updateRemainingCharge() {
setCharge((prev) => {
const sameValue = maybeTrue(0.99999);
return sameValue ? prev : prev + 1;
});
}
useInterval(updateRemainingCharge, 5);
const [charge, setCharge] = useState<number>(0);
```
But if I do:
```ts
const maybeTrue = (odds: number) => Math.random() < odds;
const toSym = (num: number) => Symbol(num);
const fromSym = (sym: Symbol) => Number(sym.description);
const [charge, setCharge] = useState<Symbol>(Symbol(0));
function updateRemainingCharge() {
setCharge((prev) => {
const sameValue = maybeTrue(0.99999);
const num = fromSym(prev);
return sameValue ? toSym(num) : toSym(num + 1);
});
}
useInterval(updateRemainingCharge, 5);
```
it doesn't leak. I'm aware I can fix it by stopping the interval, but that seems like an optimization and in my original code the delay was slow, so there was not even a need for immediate optimization.
React version: 18.2.66
## Steps To Reproduce
1. Go to https://ovp-two.vercel.app/
2. on chrome start to track memory, check the memory going up while the number doesn't change
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
https://github.com/arturcarvalho/op
Link to deployed code: https://ovp-two.vercel.app/
I don't know how to debug memory leaks on codesandbox, it seems to hide them.
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
Memory goes up when `setState(x)` where `x` is the same as current `x` on state variable.
## The expected behavior
Memory **not** go up when `setState(x)` where `x` is the same as current `x` on state variable.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28981/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28981/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28980 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28980/labels{/name} | https://api.github.com/repos/facebook/react/issues/28980/comments | https://api.github.com/repos/facebook/react/issues/28980/events | https://github.com/facebook/react/pull/28980 | 2,276,643,193 | PR_kwDOAJy2Ks5ua062 | 28,980 | Regression test for props object equality in React 19 | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0...28017592f5b5b909f573bb99906db8302fc4db3e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/28017592f5b5b909f573bb99906db8302fc4db3e/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/28017592f5b5b909f573bb99906db8302fc4db3e/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/28017592f5b5b909f573bb99906db8302fc4db3e/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/28017592f5b5b909f573bb99906db8302fc4db3e/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/28017592f5b5b909f573bb99906db8302fc4db3e/files/facebook-www/ReactDOM-prod.classic.js?compare=1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/28017592f5b5b909f573bb99906db8302fc4db3e/files/facebook-www/ReactDOM-prod.modern.js?compare=1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/28017592f5b5b909f573bb99906db8302fc4db3e/files/__test_utils__/ReactAllWarnings.js?compare=1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/28017592f5b5b909f573bb99906db8302fc4db3e/files/__test_utils__/ReactAllWarnings.js?compare=1d618a9cf36948dbf94aa6a6f2eb9e6a64b52eb0) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 28017592f5b5b909f573bb99906db8302fc4db3e\n</p>\n"
] | 2024-05-02 23:05:23 | 2024-05-03 16:23:50 | null | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28980', 'html_url': 'https://github.com/facebook/react/pull/28980', 'diff_url': 'https://github.com/facebook/react/pull/28980.diff', 'patch_url': 'https://github.com/facebook/react/pull/28980.patch', 'merged_at': None} | Regression test for props object equality in React 19
Without `enableRefAsProp`, `props` passed to lifecycle methods would be equal. This was broken with the `enableRefAsProp` flag that's supposed to ship with React 19.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28980/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28980/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28979 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28979/labels{/name} | https://api.github.com/repos/facebook/react/issues/28979/comments | https://api.github.com/repos/facebook/react/issues/28979/events | https://github.com/facebook/react/pull/28979 | 2,276,001,013 | PR_kwDOAJy2Ks5uYm0Y | 28,979 | Bundle config: Rename `global` to `hasteFileName` in bundle config | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f...25e6d44453d97d6ed6355ee77b087c93c03e46dc\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/25e6d44453d97d6ed6355ee77b087c93c03e46dc/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 6.66 kB | 6.66 kB | +0.11% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/25e6d44453d97d6ed6355ee77b087c93c03e46dc/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/25e6d44453d97d6ed6355ee77b087c93c03e46dc/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/25e6d44453d97d6ed6355ee77b087c93c03e46dc/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.92 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/25e6d44453d97d6ed6355ee77b087c93c03e46dc/files/facebook-www/ReactDOM-prod.classic.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/25e6d44453d97d6ed6355ee77b087c93c03e46dc/files/facebook-www/ReactDOM-prod.modern.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/25e6d44453d97d6ed6355ee77b087c93c03e46dc/files/__test_utils__/ReactAllWarnings.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/25e6d44453d97d6ed6355ee77b087c93c03e46dc/files/__test_utils__/ReactAllWarnings.js?compare=0a0a3af75a740d0920ebf7f4affaf8d1ce8c107f) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 25e6d44453d97d6ed6355ee77b087c93c03e46dc\n</p>\n"
] | 2024-05-02 16:46:25 | 2024-05-03 18:13:44 | null | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28979', 'html_url': 'https://github.com/facebook/react/pull/28979', 'diff_url': 'https://github.com/facebook/react/pull/28979.diff', 'patch_url': 'https://github.com/facebook/react/pull/28979.patch', 'merged_at': None} | Bundle config: Rename `global` to `hasteFileName` in bundle config
The whole bundle config is pretty confusing to me, I took a look and here's a few things that could be simplified.
This config is now only used for determining the file name for "haste" style bundles for FB and RN builds.
In the past it was also used for UMD builds that we no longer build.
Also removes a bunch of parameters to wrappers that were completely unused.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28979/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28979/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28978 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28978/labels{/name} | https://api.github.com/repos/facebook/react/issues/28978/comments | https://api.github.com/repos/facebook/react/issues/28978/events | https://github.com/facebook/react/pull/28978 | 2,276,000,988 | PR_kwDOAJy2Ks5uYm0B | 28,978 | Bundle config: inline internal hook wrapper | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 73bcdfbae57545aa8f88ecdf67426275610b5573...63faec5717bc11001c800f6cc998c868d2ea77b6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/facebook-www/ReactDOM-prod.classic.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/facebook-www/ReactDOM-prod.modern.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.85 kB | 5.72 kB | = | 1.88 kB | 1.86 kB\n| [oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.85 kB | 5.72 kB | = | 1.88 kB | 1.86 kB\n| [oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.85 kB | 5.72 kB | = | 1.88 kB | 1.86 kB\n| [oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.80 kB | 5.67 kB | = | 1.86 kB | 1.84 kB\n| [oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.80 kB | 5.67 kB | = | 1.86 kB | 1.84 kB\n| [oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.80 kB | 5.67 kB | = | 1.86 kB | 1.84 kB\n| [oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 2.77 kB | 2.64 kB | = | 1.25 kB | 1.23 kB\n| [oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 2.77 kB | 2.64 kB | = | 1.25 kB | 1.23 kB\n| [oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 2.77 kB | 2.64 kB | = | 1.25 kB | 1.23 kB\n| [oss-experimental/use-subscription/cjs/use-subscription.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-subscription/cjs/use-subscription.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 1.51 kB | 1.38 kB | = | 0.66 kB | 0.64 kB\n| [oss-stable-semver/use-subscription/cjs/use-subscription.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-subscription/cjs/use-subscription.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 1.51 kB | 1.38 kB | = | 0.66 kB | 0.64 kB\n| [oss-stable/use-subscription/cjs/use-subscription.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-subscription/cjs/use-subscription.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 1.51 kB | 1.38 kB | = | 0.66 kB | 0.64 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/__test_utils__/ReactAllWarnings.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/react-dom/cjs/react-dom.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 24.50 kB | 24.37 kB | = | 6.26 kB | 6.25 kB\n| [oss-stable/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/react-dom/cjs/react-dom.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 24.49 kB | 24.36 kB | = | 6.26 kB | 6.24 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/react-dom/cjs/react-dom.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 24.46 kB | 24.33 kB | = | 6.23 kB | 6.22 kB\n| [facebook-www/Scheduler-dev.classic.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/facebook-www/Scheduler-dev.classic.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 22.71 kB | 22.58 kB | = | 5.92 kB | 5.90 kB\n| [facebook-www/Scheduler-dev.modern.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/facebook-www/Scheduler-dev.modern.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 22.71 kB | 22.58 kB | = | 5.92 kB | 5.90 kB\n| [facebook-react-native/scheduler/cjs/Scheduler-dev.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/facebook-react-native/scheduler/cjs/Scheduler-dev.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 17.21 kB | 17.09 kB | = | 4.86 kB | 4.84 kB\n| [oss-experimental/scheduler/cjs/scheduler.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/scheduler/cjs/scheduler.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 17.19 kB | 17.06 kB | = | 4.83 kB | 4.81 kB\n| [oss-stable-semver/scheduler/cjs/scheduler.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/scheduler/cjs/scheduler.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 17.19 kB | 17.06 kB | = | 4.83 kB | 4.81 kB\n| [oss-stable/scheduler/cjs/scheduler.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/scheduler/cjs/scheduler.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 17.19 kB | 17.06 kB | = | 4.83 kB | 4.81 kB\n| [oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 8.39 kB | 8.26 kB | = | 3.18 kB | 3.16 kB\n| [oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 8.39 kB | 8.26 kB | = | 3.18 kB | 3.16 kB\n| [oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 8.39 kB | 8.26 kB | = | 3.18 kB | 3.16 kB\n| [oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 7.80 kB | 7.67 kB | = | 3.08 kB | 3.06 kB\n| [oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 7.80 kB | 7.67 kB | = | 3.08 kB | 3.06 kB\n| [oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 7.80 kB | 7.67 kB | = | 3.08 kB | 3.06 kB\n| [oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.85 kB | 5.72 kB | = | 1.88 kB | 1.86 kB\n| [oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.85 kB | 5.72 kB | = | 1.88 kB | 1.86 kB\n| [oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.85 kB | 5.72 kB | = | 1.88 kB | 1.86 kB\n| [oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.80 kB | 5.67 kB | = | 1.86 kB | 1.84 kB\n| [oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.80 kB | 5.67 kB | = | 1.86 kB | 1.84 kB\n| [oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 5.80 kB | 5.67 kB | = | 1.86 kB | 1.84 kB\n| [oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 2.77 kB | 2.64 kB | = | 1.25 kB | 1.23 kB\n| [oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 2.77 kB | 2.64 kB | = | 1.25 kB | 1.23 kB\n| [oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 2.77 kB | 2.64 kB | = | 1.25 kB | 1.23 kB\n| [oss-experimental/use-subscription/cjs/use-subscription.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-experimental/use-subscription/cjs/use-subscription.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 1.51 kB | 1.38 kB | = | 0.66 kB | 0.64 kB\n| [oss-stable-semver/use-subscription/cjs/use-subscription.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable-semver/use-subscription/cjs/use-subscription.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 1.51 kB | 1.38 kB | = | 0.66 kB | 0.64 kB\n| [oss-stable/use-subscription/cjs/use-subscription.development.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/oss-stable/use-subscription/cjs/use-subscription.development.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **=** | 1.51 kB | 1.38 kB | = | 0.66 kB | 0.64 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/63faec5717bc11001c800f6cc998c868d2ea77b6/files/__test_utils__/ReactAllWarnings.js?compare=73bcdfbae57545aa8f88ecdf67426275610b5573) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 63faec5717bc11001c800f6cc998c868d2ea77b6\n</p>\n"
] | 2024-05-02 16:46:24 | 2024-05-03 18:08:13 | 2024-05-03 18:08:10 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28978', 'html_url': 'https://github.com/facebook/react/pull/28978', 'diff_url': 'https://github.com/facebook/react/pull/28978.diff', 'patch_url': 'https://github.com/facebook/react/pull/28978.patch', 'merged_at': datetime.datetime(2024, 5, 3, 18, 8, 10)} | Bundle config: inline internal hook wrapper
Instead of reading this wrapper from 2 files for "start" and "end" and then string modifying the templates, just inline them like the other wrappers in this file.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/28978).
* #28979
* __->__ #28978 | {'url': 'https://api.github.com/repos/facebook/react/issues/28978/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28978/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28977 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28977/labels{/name} | https://api.github.com/repos/facebook/react/issues/28977/comments | https://api.github.com/repos/facebook/react/issues/28977/events | https://github.com/facebook/react/pull/28977 | 2,275,763,692 | PR_kwDOAJy2Ks5uXydL | 28,977 | Enable Wave 1 of Feature Flags for React Native | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'following_url': 'https://api.github.com/users/yungsters/following{/other_user}', 'gists_url': 'https://api.github.com/users/yungsters/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yungsters/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yungsters/subscriptions', 'organizations_url': 'https://api.github.com/users/yungsters/orgs', 'repos_url': 'https://api.github.com/users/yungsters/repos', 'events_url': 'https://api.github.com/users/yungsters/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yungsters/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4508873393058e86bed308b56e49ec883ece59d1...b1e113a74711fb21769c9f51a46db3e28d1d2f0e\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-www/ReactDOM-prod.classic.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-www/ReactDOM-prod.modern.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [facebook-react-native/react/cjs/JSXRuntime-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/JSXRuntime-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 49.75 kB | 48.54 kB | = | 14.18 kB | 14.00 kB\n| [facebook-react-native/react/cjs/JSXDEVRuntime-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/JSXDEVRuntime-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 48.52 kB | 47.31 kB | = | 13.82 kB | 13.64 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/React-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 113.16 kB | 110.05 kB | = | 29.43 kB | 28.96 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/React-profiling.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 22.37 kB | 21.68 kB | = | 5.83 kB | 5.69 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/React-prod.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 21.93 kB | 21.25 kB | = | 5.75 kB | 5.61 kB\n| [facebook-react-native/react-is/cjs/ReactIs-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-is/cjs/ReactIs-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 7.19 kB | 6.37 kB | = | 1.96 kB | 1.75 kB\n| [facebook-react-native/react-is/cjs/ReactIs-prod.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-is/cjs/ReactIs-prod.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 5.18 kB | 4.53 kB | = | 1.25 kB | 1.13 kB\n| [facebook-react-native/react-is/cjs/ReactIs-profiling.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-is/cjs/ReactIs-profiling.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 5.18 kB | 4.53 kB | = | 1.25 kB | 1.13 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+1.42%** | 838.34 kB | 850.21 kB | +1.82% | 180.53 kB | 183.82 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+1.37%** | 313.80 kB | 318.11 kB | +1.64% | 55.19 kB | 56.09 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+1.30%** | 338.26 kB | 342.67 kB | +1.59% | 58.71 kB | 59.64 kB\n| [react-native/implementations/ReactNativeRenderer-dev.fb.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/react-native/implementations/ReactNativeRenderer-dev.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 966.13 kB | 962.71 kB | = | 209.44 kB | 208.98 kB\n| [react-native/implementations/ReactFabric-dev.fb.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/react-native/implementations/ReactFabric-dev.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 953.20 kB | 949.78 kB | = | 205.71 kB | 205.23 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 401.07 kB | 398.17 kB | = | 69.62 kB | 69.20 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 393.71 kB | 390.81 kB | = | 68.28 kB | 67.83 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 373.83 kB | 370.93 kB | = | 65.39 kB | 64.91 kB\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/react-native/implementations/ReactFabric-prod.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 366.41 kB | 363.51 kB | = | 64.05 kB | 63.61 kB\n| [facebook-react-native/react/cjs/JSXRuntime-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/JSXRuntime-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 49.75 kB | 48.54 kB | = | 14.18 kB | 14.00 kB\n| [facebook-react-native/react/cjs/JSXDEVRuntime-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/JSXDEVRuntime-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 48.52 kB | 47.31 kB | = | 13.82 kB | 13.64 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/React-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 113.16 kB | 110.05 kB | = | 29.43 kB | 28.96 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/React-profiling.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 22.37 kB | 21.68 kB | = | 5.83 kB | 5.69 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react/cjs/React-prod.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 21.93 kB | 21.25 kB | = | 5.75 kB | 5.61 kB\n| [facebook-react-native/react-is/cjs/ReactIs-dev.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-is/cjs/ReactIs-dev.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 7.19 kB | 6.37 kB | = | 1.96 kB | 1.75 kB\n| [facebook-react-native/react-is/cjs/ReactIs-prod.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-is/cjs/ReactIs-prod.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 5.18 kB | 4.53 kB | = | 1.25 kB | 1.13 kB\n| [facebook-react-native/react-is/cjs/ReactIs-profiling.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/facebook-react-native/react-is/cjs/ReactIs-profiling.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 5.18 kB | 4.53 kB | = | 1.25 kB | 1.13 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b1e113a74711fb21769c9f51a46db3e28d1d2f0e/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b1e113a74711fb21769c9f51a46db3e28d1d2f0e\n</p>\n"
] | 2024-05-02 14:59:44 | 2024-05-04 04:28:46 | 2024-05-03 03:01:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28977', 'html_url': 'https://github.com/facebook/react/pull/28977', 'diff_url': 'https://github.com/facebook/react/pull/28977.diff', 'patch_url': 'https://github.com/facebook/react/pull/28977.patch', 'merged_at': datetime.datetime(2024, 5, 3, 3, 1, 30)} | ## Summary
We are ready to enable the following feature flags in React Native:
* `enableAsyncActions`
* `enableComponentStackLocations`
* `enableRenderableContext`
* `useModernStrictMode`
This will only affect Meta for now. The open source feature flags are already set to `__TODO_NEXT_RN_MAJOR__`.
## How did you test this change?
```
$ yarn test
$ yarn flow fabric
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28977/reactions', 'total_count': 3, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28977/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28976 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28976/labels{/name} | https://api.github.com/repos/facebook/react/issues/28976/comments | https://api.github.com/repos/facebook/react/issues/28976/events | https://github.com/facebook/react/pull/28976 | 2,275,684,368 | PR_kwDOAJy2Ks5uXhCx | 28,976 | Devtools: Fix build-for-devtools | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c44e9d1557ac076546811e2a56fcf8f2144ce6f5...061894594384738baf578ccfd50539e0a3152ae4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/061894594384738baf578ccfd50539e0a3152ae4/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=c44e9d1557ac076546811e2a56fcf8f2144ce6f5) | **=** | 6.66 kB | 6.66 kB | +0.11% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/061894594384738baf578ccfd50539e0a3152ae4/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=c44e9d1557ac076546811e2a56fcf8f2144ce6f5) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/061894594384738baf578ccfd50539e0a3152ae4/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=c44e9d1557ac076546811e2a56fcf8f2144ce6f5) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/061894594384738baf578ccfd50539e0a3152ae4/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=c44e9d1557ac076546811e2a56fcf8f2144ce6f5) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/061894594384738baf578ccfd50539e0a3152ae4/files/facebook-www/ReactDOM-prod.classic.js?compare=c44e9d1557ac076546811e2a56fcf8f2144ce6f5) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/061894594384738baf578ccfd50539e0a3152ae4/files/facebook-www/ReactDOM-prod.modern.js?compare=c44e9d1557ac076546811e2a56fcf8f2144ce6f5) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/061894594384738baf578ccfd50539e0a3152ae4/files/__test_utils__/ReactAllWarnings.js?compare=c44e9d1557ac076546811e2a56fcf8f2144ce6f5) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/061894594384738baf578ccfd50539e0a3152ae4/files/__test_utils__/ReactAllWarnings.js?compare=c44e9d1557ac076546811e2a56fcf8f2144ce6f5) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 061894594384738baf578ccfd50539e0a3152ae4\n</p>\n"
] | 2024-05-02 14:27:20 | 2024-05-02 19:59:01 | 2024-05-02 19:58:51 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28976', 'html_url': 'https://github.com/facebook/react/pull/28976', 'diff_url': 'https://github.com/facebook/react/pull/28976.diff', 'patch_url': 'https://github.com/facebook/react/pull/28976.patch', 'merged_at': datetime.datetime(2024, 5, 2, 19, 58, 51)} | Stack:
1. https://github.com/facebook/react/pull/28975
1. https://github.com/facebook/react/pull/28976 <--- You're here
1. https://github.com/facebook/react/pull/28974
## Summary
Some devtools code imports from `shared/` this could result in `shared/FeatureFlags` becoming part of the module graph as it did with https://github.com/facebook/react/issues/28813. Without this fix, we'd have a bare `__EXPERIMENTAL__` identifier that would result in `react_devtools_backend_compact.js:3724 Uncaught ReferenceError: __EXPERIMENTAL__ is not defined` in the final build.
We already hardcoded `__EXPERIMENTAL__: true` in the frontend Webpack config so I'm doing the same for the backend.
## How did you test this change?
- [x] Use `react-devtools-chrome-extension.zip` from this branch and no longer observe `ReferenceError` when inspecting a React app
| {'url': 'https://api.github.com/repos/facebook/react/issues/28976/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28976/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28975 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28975/labels{/name} | https://api.github.com/repos/facebook/react/issues/28975/comments | https://api.github.com/repos/facebook/react/issues/28975/events | https://github.com/facebook/react/pull/28975 | 2,275,675,150 | PR_kwDOAJy2Ks5uXfBj | 28,975 | Devtools: Streamline getting extension from branch | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4508873393058e86bed308b56e49ec883ece59d1...ba75d2d5c9e30585d8bcadee9e99b37d2a0ca5c4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/ba75d2d5c9e30585d8bcadee9e99b37d2a0ca5c4/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/ba75d2d5c9e30585d8bcadee9e99b37d2a0ca5c4/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/ba75d2d5c9e30585d8bcadee9e99b37d2a0ca5c4/files/facebook-www/ReactDOM-prod.classic.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/ba75d2d5c9e30585d8bcadee9e99b37d2a0ca5c4/files/facebook-www/ReactDOM-prod.modern.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ba75d2d5c9e30585d8bcadee9e99b37d2a0ca5c4/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ba75d2d5c9e30585d8bcadee9e99b37d2a0ca5c4/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ba75d2d5c9e30585d8bcadee9e99b37d2a0ca5c4\n</p>\n"
] | 2024-05-02 14:23:04 | 2024-05-02 19:47:19 | 2024-05-02 19:47:18 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28975', 'html_url': 'https://github.com/facebook/react/pull/28975', 'diff_url': 'https://github.com/facebook/react/pull/28975.diff', 'patch_url': 'https://github.com/facebook/react/pull/28975.patch', 'merged_at': datetime.datetime(2024, 5, 2, 19, 47, 18)} | Stack:
1. https://github.com/facebook/react/pull/28975 <--- You're here
1. https://github.com/facebook/react/pull/28976
1. https://github.com/facebook/react/pull/28974
## Summary
For manual e2e testing, I oftentimes just need the extension for the browser I'm using. So I'm adding separate artifacts just for Chrome and Firefox extension instead of a single tarball with both. Avoids one unpack step and is also easier for external people to grab a nightly build of the extension.
## How did you test this change?
- [x] Download `react-devtools-chrome-extension.zip` from [`build_devtools_and_process_artifacts ` artifacts](https://app.circleci.com/pipelines/github/facebook/react/52772/workflows/c57fae57-bee3-4b8d-8f2a-fe31464f8922/jobs/850793/artifacts):
| {'url': 'https://api.github.com/repos/facebook/react/issues/28975/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28975/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28974 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28974/labels{/name} | https://api.github.com/repos/facebook/react/issues/28974/comments | https://api.github.com/repos/facebook/react/issues/28974/events | https://github.com/facebook/react/pull/28974 | 2,275,568,659 | PR_kwDOAJy2Ks5uXHf_ | 28,974 | DevTools: Fix inspecting components with multiple reads of the same Context in React 17 | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 14f71db6b6f1668e61b29d376889ad298def4c6e...b4d571c5f03077dc3690b8528de4b285d76a78ed\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **=** | 492.61 kB | 492.61 kB | = | 87.88 kB | 87.88 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **=** | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/facebook-www/ReactDOM-prod.classic.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/facebook-www/ReactDOM-prod.modern.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/__test_utils__/ReactAllWarnings.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **+0.34%** | 36.41 kB | 36.54 kB | +0.72% | 8.66 kB | 8.72 kB\n| [oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **+0.34%** | 36.41 kB | 36.54 kB | +0.72% | 8.66 kB | 8.72 kB\n| [oss-stable/react-debug-tools/cjs/react-debug-tools.development.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/oss-stable/react-debug-tools/cjs/react-debug-tools.development.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **+0.34%** | 36.41 kB | 36.54 kB | +0.72% | 8.66 kB | 8.72 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/b4d571c5f03077dc3690b8528de4b285d76a78ed/files/__test_utils__/ReactAllWarnings.js?compare=14f71db6b6f1668e61b29d376889ad298def4c6e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against b4d571c5f03077dc3690b8528de4b285d76a78ed\n</p>\n"
] | 2024-05-02 13:38:28 | 2024-05-02 20:08:43 | 2024-05-02 20:08:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28974', 'html_url': 'https://github.com/facebook/react/pull/28974', 'diff_url': 'https://github.com/facebook/react/pull/28974.diff', 'patch_url': 'https://github.com/facebook/react/pull/28974.patch', 'merged_at': datetime.datetime(2024, 5, 2, 20, 8, 41)} | Stack:
1. https://github.com/facebook/react/pull/28975
1. https://github.com/facebook/react/pull/28976
1. https://github.com/facebook/react/pull/28974 <--- You're here
## Summary
Closes https://github.com/facebook/react/issues/28960
In https://github.com/facebook/react/pull/28467, we started reading context values by advancing a cursor in the context dependency list. However, in React 17, multiple reads of the same context are only tracked as a single dependency so we don't know if we should advance or not. Keep in mind that the passed `context` should be ignored in later versions of React where the real context object may not be available (e.g. in `useFormStatus`).
So for React 17 and below we just completely fallback to the old approach of reading the current value from the context object. In those versions `useFormStatus` doesn't exist.
## How did you test this change?
- [x] react-debug-tools tests
- [x] Backwards compat with 16.8: https://codesandbox.io/p/sandbox/serverless-snowflake-ttrp8v
- [x] Backwards compat with 17.0: https://codesandbox.io/p/sandbox/17-0-react-devtools-context-inspection-forked-rslrsq
- [x] Backwards compat with 18.0: https://codesandbox.io/p/sandbox/18-0-react-devtools-context-inspection-p8ntzj
- [x] Compat with Beta: https://codesandbox.io/p/sandbox/canary-react-devtools-context-inspection-9y5gkc | {'url': 'https://api.github.com/repos/facebook/react/issues/28974/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28974/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28973 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28973/labels{/name} | https://api.github.com/repos/facebook/react/issues/28973/comments | https://api.github.com/repos/facebook/react/issues/28973/events | https://github.com/facebook/react/pull/28973 | 2,275,556,939 | PR_kwDOAJy2Ks5uXE8M | 28,973 | [DevTools] Expose "view source" options to Fusebox integration | {'login': 'motiz88', 'id': 2246565, 'node_id': 'MDQ6VXNlcjIyNDY1NjU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2246565?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/motiz88', 'html_url': 'https://github.com/motiz88', 'followers_url': 'https://api.github.com/users/motiz88/followers', 'following_url': 'https://api.github.com/users/motiz88/following{/other_user}', 'gists_url': 'https://api.github.com/users/motiz88/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/motiz88/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/motiz88/subscriptions', 'organizations_url': 'https://api.github.com/users/motiz88/orgs', 'repos_url': 'https://api.github.com/users/motiz88/repos', 'events_url': 'https://api.github.com/users/motiz88/events{/privacy}', 'received_events_url': 'https://api.github.com/users/motiz88/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [] | 2024-05-02 13:33:05 | 2024-05-03 21:23:25 | null | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28973', 'html_url': 'https://github.com/facebook/react/pull/28973', 'diff_url': 'https://github.com/facebook/react/pull/28973.diff', 'patch_url': 'https://github.com/facebook/react/pull/28973.patch', 'merged_at': None} | NOTE: Stacked on https://github.com/facebook/react/pull/28970 and https://github.com/facebook/react/pull/28972 - please only review the last commit.
## Summary
Exposes the APIs needed by React Native DevTools (Fusebox) to implement the "view element source" and "view attribute source" features.
## How did you test this change?
1. `yarn build` in `react-devtools-fusebox`
2. Copy artifacts to rn-chrome-devtools-frontend
3. Write some additional glue code to implement `viewElementSourceFunction` in our CDT fork.
4. Test the feature manually.
https://github.com/facebook/react/assets/2246565/12667018-100a-4b3f-957a-06c07f2af41a
| {'url': 'https://api.github.com/repos/facebook/react/issues/28973/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28973/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28972 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28972/labels{/name} | https://api.github.com/repos/facebook/react/issues/28972/comments | https://api.github.com/repos/facebook/react/issues/28972/events | https://github.com/facebook/react/pull/28972 | 2,275,549,969 | PR_kwDOAJy2Ks5uXDZ8 | 28,972 | [DevTools] Enable inspected element context menu in Fusebox | {'login': 'motiz88', 'id': 2246565, 'node_id': 'MDQ6VXNlcjIyNDY1NjU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2246565?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/motiz88', 'html_url': 'https://github.com/motiz88', 'followers_url': 'https://api.github.com/users/motiz88/followers', 'following_url': 'https://api.github.com/users/motiz88/following{/other_user}', 'gists_url': 'https://api.github.com/users/motiz88/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/motiz88/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/motiz88/subscriptions', 'organizations_url': 'https://api.github.com/users/motiz88/orgs', 'repos_url': 'https://api.github.com/users/motiz88/repos', 'events_url': 'https://api.github.com/users/motiz88/events{/privacy}', 'received_events_url': 'https://api.github.com/users/motiz88/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2024-05-02 13:29:54 | 2024-05-03 16:33:22 | 2024-05-03 16:33:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28972', 'html_url': 'https://github.com/facebook/react/pull/28972', 'diff_url': 'https://github.com/facebook/react/pull/28972.diff', 'patch_url': 'https://github.com/facebook/react/pull/28972.patch', 'merged_at': datetime.datetime(2024, 5, 3, 16, 33, 21)} | ## Summary
Enables the inspected element context menu in React Native DevTools (Fusebox).
## How did you test this change?
1. `yarn build` in `react-devtools-fusebox`
2. Copy artifacts to rn-chrome-devtools-frontend
3. Manually test the context menu
https://github.com/facebook/react/assets/2246565/b35cc20f-8d67-43b0-b863-7731e10fffac
NOTE: The serialised values sometimes expose React internals (e.g. Hook data structures instead of just the values), but that seems to be a problem equally on web, so I'm going for native<->web parity here. | {'url': 'https://api.github.com/repos/facebook/react/issues/28972/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28972/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28971 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28971/labels{/name} | https://api.github.com/repos/facebook/react/issues/28971/comments | https://api.github.com/repos/facebook/react/issues/28971/events | https://github.com/facebook/react/issues/28971 | 2,275,497,760 | I_kwDOAJy2Ks6HoVcg | 28,971 | Publish React on JSR | {'login': 'vanillajonathan', 'id': 10222521, 'node_id': 'MDQ6VXNlcjEwMjIyNTIx', 'avatar_url': 'https://avatars.githubusercontent.com/u/10222521?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vanillajonathan', 'html_url': 'https://github.com/vanillajonathan', 'followers_url': 'https://api.github.com/users/vanillajonathan/followers', 'following_url': 'https://api.github.com/users/vanillajonathan/following{/other_user}', 'gists_url': 'https://api.github.com/users/vanillajonathan/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/vanillajonathan/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/vanillajonathan/subscriptions', 'organizations_url': 'https://api.github.com/users/vanillajonathan/orgs', 'repos_url': 'https://api.github.com/users/vanillajonathan/repos', 'events_url': 'https://api.github.com/users/vanillajonathan/events{/privacy}', 'received_events_url': 'https://api.github.com/users/vanillajonathan/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-05-02 13:05:53 | 2024-05-02 13:06:01 | null | NONE | null | null | null | Publish React on [JSR](https://jsr.io/). | {'url': 'https://api.github.com/repos/facebook/react/issues/28971/reactions', 'total_count': 1, '+1': 0, '-1': 1, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28971/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28970 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28970/labels{/name} | https://api.github.com/repos/facebook/react/issues/28970/comments | https://api.github.com/repos/facebook/react/issues/28970/events | https://github.com/facebook/react/pull/28970 | 2,275,408,267 | PR_kwDOAJy2Ks5uWkD5 | 28,970 | [DevTools] Check in `frontend.d.ts` for react-devtools-fusebox, include in build output | {'login': 'motiz88', 'id': 2246565, 'node_id': 'MDQ6VXNlcjIyNDY1NjU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2246565?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/motiz88', 'html_url': 'https://github.com/motiz88', 'followers_url': 'https://api.github.com/users/motiz88/followers', 'following_url': 'https://api.github.com/users/motiz88/following{/other_user}', 'gists_url': 'https://api.github.com/users/motiz88/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/motiz88/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/motiz88/subscriptions', 'organizations_url': 'https://api.github.com/users/motiz88/orgs', 'repos_url': 'https://api.github.com/users/motiz88/repos', 'events_url': 'https://api.github.com/users/motiz88/events{/privacy}', 'received_events_url': 'https://api.github.com/users/motiz88/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2024-05-02 12:23:18 | 2024-05-03 16:32:47 | 2024-05-03 16:32:41 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28970', 'html_url': 'https://github.com/facebook/react/pull/28970', 'diff_url': 'https://github.com/facebook/react/pull/28970.diff', 'patch_url': 'https://github.com/facebook/react/pull/28970.patch', 'merged_at': datetime.datetime(2024, 5, 3, 16, 32, 41)} | ## Summary
The `react-devtools-fusebox` private package is used in the React Native DevTools (Fusebox) frontend by checking build artifacts into RN's [fork]([`facebookexperimental/rn-chrome-devtools-frontend`](https://github.com/facebookexperimental/rn-chrome-devtools-frontend)) of the Chrome DevTools (CDT) repo - see https://github.com/facebookexperimental/rn-chrome-devtools-frontend/pull/22.
Currently, the CDT fork also includes a [manually written TypeScript definition file](https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/1d5f8d5209ac49de97aec16732169d47bf525474/front_end/third_party/react-devtools/package/frontend.d.ts) which describes `react-devtools-fusebox`'s API. This PR moves that file into the React repo, next to the implementation of `react-devtools-fusebox`, so we can update it atomically with changes to the package.
As this is the first bit of TypeScript in this repo, the PR adds minimal support for formatting `.d.ts` files with Prettier. It also opts out `react-devtools-fusebox/dist/` from linting/formatting as a drive-by fix.
For now, we'll just maintain the `.d.ts` file manually, but we could consider leveraging [`flow-api-translator`](https://www.npmjs.com/package/flow-api-translator) to auto-generate it in the future.
## How did you test this change?
Build `react-devtools-fusebox`, observe that `dist/frontend.d.ts` exists.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28970/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28970/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28969 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28969/labels{/name} | https://api.github.com/repos/facebook/react/issues/28969/comments | https://api.github.com/repos/facebook/react/issues/28969/events | https://github.com/facebook/react/pull/28969 | 2,275,333,213 | PR_kwDOAJy2Ks5uWTlD | 28,969 | Introduce a faster version of the addProperties function | {'login': 'dmytrorykun', 'id': 14206200, 'node_id': 'MDQ6VXNlcjE0MjA2MjAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/14206200?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dmytrorykun', 'html_url': 'https://github.com/dmytrorykun', 'followers_url': 'https://api.github.com/users/dmytrorykun/followers', 'following_url': 'https://api.github.com/users/dmytrorykun/following{/other_user}', 'gists_url': 'https://api.github.com/users/dmytrorykun/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/dmytrorykun/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/dmytrorykun/subscriptions', 'organizations_url': 'https://api.github.com/users/dmytrorykun/orgs', 'repos_url': 'https://api.github.com/users/dmytrorykun/repos', 'events_url': 'https://api.github.com/users/dmytrorykun/events{/privacy}', 'received_events_url': 'https://api.github.com/users/dmytrorykun/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4508873393058e86bed308b56e49ec883ece59d1...ab21f135d5963b30cdf53ce5666af4035eb8cb32\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/facebook-www/ReactDOM-prod.classic.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/facebook-www/ReactDOM-prod.modern.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/react-native/implementations/ReactFabric-prod.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+0.37%** | 366.41 kB | 367.77 kB | +0.23% | 64.05 kB | 64.20 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+0.34%** | 393.71 kB | 395.06 kB | +0.21% | 68.28 kB | 68.42 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+0.34%** | 373.83 kB | 375.10 kB | +0.17% | 65.39 kB | 65.50 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+0.32%** | 401.07 kB | 402.35 kB | +0.22% | 69.62 kB | 69.77 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/ab21f135d5963b30cdf53ce5666af4035eb8cb32/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ab21f135d5963b30cdf53ce5666af4035eb8cb32\n</p>\n"
] | 2024-05-02 11:42:56 | 2024-05-03 07:14:30 | 2024-05-02 16:10:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28969', 'html_url': 'https://github.com/facebook/react/pull/28969', 'diff_url': 'https://github.com/facebook/react/pull/28969.diff', 'patch_url': 'https://github.com/facebook/react/pull/28969.patch', 'merged_at': datetime.datetime(2024, 5, 2, 16, 10, 13)} | ## Summary
This PR introduces a faster version of the `addProperties` function. This new function is basically the `diffProperties` with `prevProps` set to `null`, propagated constants, and all the unreachable code paths collapsed.
## How did you test this change?
I've tested this change with [the benchmark app](https://github.com/react-native-community/RNNewArchitectureApp/tree/new-architecture-benchmarks) and got ~4.4% improvement in the view creation time. | {'url': 'https://api.github.com/repos/facebook/react/issues/28969/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28969/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28968 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28968/labels{/name} | https://api.github.com/repos/facebook/react/issues/28968/comments | https://api.github.com/repos/facebook/react/issues/28968/events | https://github.com/facebook/react/issues/28968 | 2,274,819,548 | I_kwDOAJy2Ks6Hlv3c | 28,968 | Update react GitHub page CNAME record | {'login': 'includerajat', 'id': 78809406, 'node_id': 'MDQ6VXNlcjc4ODA5NDA2', 'avatar_url': 'https://avatars.githubusercontent.com/u/78809406?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/includerajat', 'html_url': 'https://github.com/includerajat', 'followers_url': 'https://api.github.com/users/includerajat/followers', 'following_url': 'https://api.github.com/users/includerajat/following{/other_user}', 'gists_url': 'https://api.github.com/users/includerajat/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/includerajat/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/includerajat/subscriptions', 'organizations_url': 'https://api.github.com/users/includerajat/orgs', 'repos_url': 'https://api.github.com/users/includerajat/repos', 'events_url': 'https://api.github.com/users/includerajat/events{/privacy}', 'received_events_url': 'https://api.github.com/users/includerajat/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Thanks for pointing this out",
"Thanks @kassens, I thought I would get an opportunity to merge the code :((\r\nIs it good to raise a pull request together when we raise any issue, and we know the fix of that issue?"
] | 2024-05-02 07:32:05 | 2024-05-03 16:36:54 | 2024-05-03 14:05:53 | NONE | null | null | null | React GitHub page (https://facebook.github.io/react) (`gh-pages` branch) currently pointing to [reactjs.org](https://reactjs.org) and then it redirects to https://react.dev/.
So many redirects, can we update the content of `CNAME` file with `react.dev`, if it ok to do, then I am very happy to do the same and I'll contribution in real open source project. | {'url': 'https://api.github.com/repos/facebook/react/issues/28968/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28968/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28967 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28967/labels{/name} | https://api.github.com/repos/facebook/react/issues/28967/comments | https://api.github.com/repos/facebook/react/issues/28967/events | https://github.com/facebook/react/issues/28967 | 2,274,788,686 | I_kwDOAJy2Ks6HloVO | 28,967 | spam | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'https://api.github.com/users/ghost/following{/other_user}', 'gists_url': 'https://api.github.com/users/ghost/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ghost/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ghost/subscriptions', 'organizations_url': 'https://api.github.com/users/ghost/orgs', 'repos_url': 'https://api.github.com/users/ghost/repos', 'events_url': 'https://api.github.com/users/ghost/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ghost/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2024-05-02 07:12:59 | 2024-05-05 15:46:20 | 2024-05-02 08:20:05 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/28967/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28967/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28966 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28966/labels{/name} | https://api.github.com/repos/facebook/react/issues/28966/comments | https://api.github.com/repos/facebook/react/issues/28966/events | https://github.com/facebook/react/pull/28966 | 2,274,539,291 | PR_kwDOAJy2Ks5uTlRv | 28,966 | [Tooling] Update critical artifact list | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4508873393058e86bed308b56e49ec883ece59d1...c4cb74792a131f7e45fd0f98d0e1762f3c3266e1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/c4cb74792a131f7e45fd0f98d0e1762f3c3266e1/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/c4cb74792a131f7e45fd0f98d0e1762f3c3266e1/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 492.50 kB | 492.50 kB | = | 87.87 kB | 87.86 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/c4cb74792a131f7e45fd0f98d0e1762f3c3266e1/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/c4cb74792a131f7e45fd0f98d0e1762f3c3266e1/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 498.74 kB | 498.74 kB | = | 88.91 kB | 88.91 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/c4cb74792a131f7e45fd0f98d0e1762f3c3266e1/files/facebook-www/ReactDOM-prod.classic.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/c4cb74792a131f7e45fd0f98d0e1762f3c3266e1/files/facebook-www/ReactDOM-prod.modern.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/c4cb74792a131f7e45fd0f98d0e1762f3c3266e1/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/c4cb74792a131f7e45fd0f98d0e1762f3c3266e1/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against c4cb74792a131f7e45fd0f98d0e1762f3c3266e1\n</p>\n"
] | 2024-05-02 03:53:17 | 2024-05-02 14:39:13 | 2024-05-02 14:39:10 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28966', 'html_url': 'https://github.com/facebook/react/pull/28966', 'diff_url': 'https://github.com/facebook/react/pull/28966.diff', 'patch_url': 'https://github.com/facebook/react/pull/28966.patch', 'merged_at': datetime.datetime(2024, 5, 2, 14, 39, 10)} | When a React PR is opened CI will report large size changes. But for critical packages like react-dom it reports always. In React 19 we moved the build for react-dom the client reconciler from react-dom to react-dom/client
This change adds react-dom-client artifacts for stable and oss channels since that is originally what was being tracked. But since react-dom/client always imports react-dom I left the original react-dom packages as critical as well. They are small but it would be good to keep an eye on them
| {'url': 'https://api.github.com/repos/facebook/react/issues/28966/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28966/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28965 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28965/labels{/name} | https://api.github.com/repos/facebook/react/issues/28965/comments | https://api.github.com/repos/facebook/react/issues/28965/events | https://github.com/facebook/react/pull/28965 | 2,274,349,106 | PR_kwDOAJy2Ks5uS9P7 | 28,965 | [Fiber] render boundary in fallback if it contains a new stylesheet during sync update | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4508873393058e86bed308b56e49ec883ece59d1...da0b480525a561fcec62cdf7950bd5c3303f6e9f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/da0b480525a561fcec62cdf7950bd5c3303f6e9f/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/da0b480525a561fcec62cdf7950bd5c3303f6e9f/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/da0b480525a561fcec62cdf7950bd5c3303f6e9f/files/facebook-www/ReactDOM-prod.classic.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+0.06%** | 591.11 kB | 591.45 kB | +0.04% | 103.94 kB | 103.98 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/da0b480525a561fcec62cdf7950bd5c3303f6e9f/files/facebook-www/ReactDOM-prod.modern.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **+0.05%** | 567.33 kB | 567.59 kB | +0.05% | 100.34 kB | 100.39 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/da0b480525a561fcec62cdf7950bd5c3303f6e9f/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/da0b480525a561fcec62cdf7950bd5c3303f6e9f/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against da0b480525a561fcec62cdf7950bd5c3303f6e9f\n</p>\n"
] | 2024-05-01 23:34:26 | 2024-05-01 23:52:07 | null | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28965', 'html_url': 'https://github.com/facebook/react/pull/28965', 'diff_url': 'https://github.com/facebook/react/pull/28965.diff', 'patch_url': 'https://github.com/facebook/react/pull/28965.patch', 'merged_at': None} | When we implemented Suspensey CSS we had a heuristic that if the update was sync we would ignore the loading states of any new stylesheets and just do the commit. But for a stylesheet capability to be useful it needs to reliably prevent FOUC and since the stylesheet api is opt-in through precedence we don't have to maintain backaward compat (old stylesheets do not block commit but then nobody really renders them because of FOUC anyway)
This update modifies the logic to put a boundary back into fallback if a sync update would lead to a stylesheet commiting before it loaded.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28965/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28965/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28964 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28964/labels{/name} | https://api.github.com/repos/facebook/react/issues/28964/comments | https://api.github.com/repos/facebook/react/issues/28964/events | https://github.com/facebook/react/pull/28964 | 2,274,162,980 | PR_kwDOAJy2Ks5uSUvK | 28,964 | Set enableUseMemoCacheHook to true everywhere | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 9b1300209eb00a2d6c645fddf6d2729d67d7b10a...e8fa812f34e4c97ef3becb2bce0498f72211d5ee\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.29%** | 492.61 kB | 494.06 kB | +0.38% | 87.88 kB | 88.21 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [oss-experimental/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-experimental/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 498.86 kB | 498.86 kB | = | 88.92 kB | 88.93 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/facebook-www/ReactDOM-prod.classic.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/facebook-www/ReactDOM-prod.modern.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **=** | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.51%** | 800.90 kB | 804.99 kB | +0.56% | 174.52 kB | 175.50 kB\n| [oss-stable/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-test-renderer/cjs/react-test-renderer.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.51%** | 800.93 kB | 805.02 kB | +0.56% | 174.55 kB | 175.53 kB\n| [oss-stable-semver/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-art/cjs/react-art.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.50%** | 812.25 kB | 816.34 kB | +0.55% | 176.13 kB | 177.09 kB\n| [oss-stable/react-art/cjs/react-art.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-art/cjs/react-art.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.50%** | 812.28 kB | 816.37 kB | +0.54% | 176.15 kB | 177.11 kB\n| [oss-stable-semver/react-art/cjs/react-art.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-art/cjs/react-art.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.50%** | 289.02 kB | 290.47 kB | +0.60% | 49.86 kB | 50.16 kB\n| [oss-stable/react-art/cjs/react-art.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-art/cjs/react-art.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.50%** | 289.07 kB | 290.52 kB | +0.59% | 49.89 kB | 50.18 kB\n| [oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.49%** | 296.84 kB | 298.29 kB | +0.57% | 52.70 kB | 53.00 kB\n| [oss-stable/react-test-renderer/cjs/react-test-renderer.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-test-renderer/cjs/react-test-renderer.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.49%** | 296.89 kB | 298.34 kB | +0.57% | 52.73 kB | 53.03 kB\n| [react-native/implementations/ReactFabric-dev.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/react-native/implementations/ReactFabric-dev.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.48%** | 855.12 kB | 859.21 kB | +0.55% | 185.31 kB | 186.33 kB\n| [react-native/implementations/ReactNativeRenderer-dev.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/react-native/implementations/ReactNativeRenderer-dev.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.47%** | 868.30 kB | 872.39 kB | +0.53% | 189.11 kB | 190.12 kB\n| [oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.45%** | 915.14 kB | 919.22 kB | +0.50% | 196.71 kB | 197.70 kB\n| [oss-stable/react-reconciler/cjs/react-reconciler.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-reconciler/cjs/react-reconciler.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.45%** | 915.16 kB | 919.25 kB | +0.50% | 196.74 kB | 197.73 kB\n| [oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.41%** | 373.58 kB | 375.11 kB | +0.50% | 61.28 kB | 61.59 kB\n| [oss-stable/react-reconciler/cjs/react-reconciler.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-reconciler/cjs/react-reconciler.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.41%** | 373.60 kB | 375.14 kB | +0.51% | 61.30 kB | 61.61 kB\n| [oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.38%** | 401.78 kB | 403.31 kB | +0.45% | 65.22 kB | 65.51 kB\n| [oss-stable/react-reconciler/cjs/react-reconciler.profiling.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-reconciler/cjs/react-reconciler.profiling.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.38%** | 401.80 kB | 403.34 kB | +0.45% | 65.24 kB | 65.54 kB\n| [react-native/implementations/ReactFabric-prod.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/react-native/implementations/ReactFabric-prod.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.33%** | 309.25 kB | 310.26 kB | +0.48% | 54.08 kB | 54.34 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-client.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-dom/cjs/react-dom-client.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.32%** | 1,281.81 kB | 1,285.90 kB | +0.34% | 284.94 kB | 285.90 kB\n| [oss-stable/react-dom/cjs/react-dom-client.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-dom/cjs/react-dom-client.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.32%** | 1,281.83 kB | 1,285.92 kB | +0.34% | 284.97 kB | 285.93 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.31%** | 1,300.49 kB | 1,304.57 kB | +0.34% | 288.30 kB | 289.27 kB\n| [oss-stable/react-dom/cjs/react-dom-profiling.development.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-dom/cjs/react-dom-profiling.development.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.31%** | 1,300.51 kB | 1,304.60 kB | +0.34% | 288.33 kB | 289.31 kB\n| [react-native/implementations/ReactNativeRenderer-prod.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/react-native/implementations/ReactNativeRenderer-prod.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.31%** | 318.48 kB | 319.47 kB | +0.45% | 55.70 kB | 55.94 kB\n| [react-native/implementations/ReactFabric-profiling.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/react-native/implementations/ReactFabric-profiling.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.30%** | 336.31 kB | 337.32 kB | +0.44% | 58.26 kB | 58.52 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.29%** | 492.54 kB | 493.99 kB | +0.37% | 87.86 kB | 88.19 kB\n| [oss-stable/react-dom/cjs/react-dom-client.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-dom/cjs/react-dom-client.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.29%** | 492.61 kB | 494.06 kB | +0.38% | 87.88 kB | 88.21 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/react-native/implementations/ReactNativeRenderer-profiling.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.29%** | 345.46 kB | 346.45 kB | +0.40% | 59.96 kB | 60.19 kB\n| [oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.28%** | 525.41 kB | 526.86 kB | +0.33% | 92.98 kB | 93.29 kB\n| [oss-stable/react-dom/cjs/react-dom-profiling.profiling.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-dom/cjs/react-dom-profiling.profiling.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.28%** | 525.48 kB | 526.93 kB | +0.33% | 93.01 kB | 93.31 kB\n| [oss-stable-semver/react-server/cjs/react-server.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable-semver/react-server/cjs/react-server.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.23%** | 105.21 kB | 105.46 kB | +0.37% | 19.29 kB | 19.36 kB\n| [oss-stable/react-server/cjs/react-server.production.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/oss-stable/react-server/cjs/react-server.production.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **+0.23%** | 105.21 kB | 105.46 kB | +0.37% | 19.29 kB | 19.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/e8fa812f34e4c97ef3becb2bce0498f72211d5ee/files/__test_utils__/ReactAllWarnings.js?compare=9b1300209eb00a2d6c645fddf6d2729d67d7b10a) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against e8fa812f34e4c97ef3becb2bce0498f72211d5ee\n</p>\n"
] | 2024-05-01 20:41:42 | 2024-05-06 18:20:11 | 2024-05-06 18:20:08 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28964', 'html_url': 'https://github.com/facebook/react/pull/28964', 'diff_url': 'https://github.com/facebook/react/pull/28964.diff', 'patch_url': 'https://github.com/facebook/react/pull/28964.patch', 'merged_at': datetime.datetime(2024, 5, 6, 18, 20, 8)} | Set enableUseMemoCacheHook to true everywhere
Any reason we should have this disabled anywhere? I think we're set on the API?
| {'url': 'https://api.github.com/repos/facebook/react/issues/28964/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28964/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28963 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28963/labels{/name} | https://api.github.com/repos/facebook/react/issues/28963/comments | https://api.github.com/repos/facebook/react/issues/28963/events | https://github.com/facebook/react/pull/28963 | 2,273,730,188 | PR_kwDOAJy2Ks5uQ1iz | 28,963 | Stop committing resources to an external repo | {'login': 'bigfootjon', 'id': 6403568, 'node_id': 'MDQ6VXNlcjY0MDM1Njg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6403568?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bigfootjon', 'html_url': 'https://github.com/bigfootjon', 'followers_url': 'https://api.github.com/users/bigfootjon/followers', 'following_url': 'https://api.github.com/users/bigfootjon/following{/other_user}', 'gists_url': 'https://api.github.com/users/bigfootjon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bigfootjon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bigfootjon/subscriptions', 'organizations_url': 'https://api.github.com/users/bigfootjon/orgs', 'repos_url': 'https://api.github.com/users/bigfootjon/repos', 'events_url': 'https://api.github.com/users/bigfootjon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bigfootjon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4508873393058e86bed308b56e49ec883ece59d1...2053fe74de12dd88059d946df4a7aa24350555a2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/2053fe74de12dd88059d946df4a7aa24350555a2/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/2053fe74de12dd88059d946df4a7aa24350555a2/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/2053fe74de12dd88059d946df4a7aa24350555a2/files/facebook-www/ReactDOM-prod.classic.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/2053fe74de12dd88059d946df4a7aa24350555a2/files/facebook-www/ReactDOM-prod.modern.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2053fe74de12dd88059d946df4a7aa24350555a2/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2053fe74de12dd88059d946df4a7aa24350555a2/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2053fe74de12dd88059d946df4a7aa24350555a2\n</p>\n"
] | 2024-05-01 15:50:12 | 2024-05-03 18:01:57 | 2024-05-03 18:01:53 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28963', 'html_url': 'https://github.com/facebook/react/pull/28963', 'diff_url': 'https://github.com/facebook/react/pull/28963.diff', 'patch_url': 'https://github.com/facebook/react/pull/28963.patch', 'merged_at': datetime.datetime(2024, 5, 3, 18, 1, 53)} | This has been integrated into this repo (`builds/facebook-fbsource`) so we no longer need the extra repo | {'url': 'https://api.github.com/repos/facebook/react/issues/28963/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28963/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28962 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28962/labels{/name} | https://api.github.com/repos/facebook/react/issues/28962/comments | https://api.github.com/repos/facebook/react/issues/28962/events | https://github.com/facebook/react/pull/28962 | 2,273,532,351 | PR_kwDOAJy2Ks5uQKbh | 28,962 | [react-dom][18.3.1] Add `bun` export to `react-dom`. | {'login': 'AldoMX', 'id': 476531, 'node_id': 'MDQ6VXNlcjQ3NjUzMQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/476531?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AldoMX', 'html_url': 'https://github.com/AldoMX', 'followers_url': 'https://api.github.com/users/AldoMX/followers', 'following_url': 'https://api.github.com/users/AldoMX/following{/other_user}', 'gists_url': 'https://api.github.com/users/AldoMX/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/AldoMX/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/AldoMX/subscriptions', 'organizations_url': 'https://api.github.com/users/AldoMX/orgs', 'repos_url': 'https://api.github.com/users/AldoMX/repos', 'events_url': 'https://api.github.com/users/AldoMX/events{/privacy}', 'received_events_url': 'https://api.github.com/users/AldoMX/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Thanks for the suggestion however we released 18.3 to add additional warnings to help with upgrading to 19 and don't plan to include any changes to functionality or packaging from what was supported in 18.2.\r\n\r\nYou can always directly import the specific runtime you want to load with a specifier like `require(\"react-dom/server.browser\")` so you should be able to load the desired version when using bun with some effort.\r\n\r\nReact 19 adds bun conditions so this should already be resolved when that version is released",
"I'd still ask to reconsider, considering v18 is still the latest stable version, and we're months away from v19 stable.\r\n\r\n---\r\n\r\nI'm leaving my TypeScript notes as reference to anyone who reaches this dead-end:\r\n\r\nUpdate imports:\r\n\r\n```typescript\r\n// from\r\nimport { renderToReadableStream } from 'react-dom/server';\r\n\r\n// to\r\nimport { renderToReadableStream } from 'react-dom/server.browser';\r\n```\r\n\r\nAdd to your global definition file (ex. `global.d.ts`):\r\n\r\n```typescript\r\ndeclare module 'react-dom/server.browser' {\r\n import * as ReactDOMServer from 'react-dom/server';\r\n export = ReactDOMServer;\r\n}\r\n```"
] | 2024-05-01 13:40:24 | 2024-05-03 14:05:04 | 2024-05-01 20:52:21 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28962', 'html_url': 'https://github.com/facebook/react/pull/28962', 'diff_url': 'https://github.com/facebook/react/pull/28962.diff', 'patch_url': 'https://github.com/facebook/react/pull/28962.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
When you try to `bun run` a project that uses `renderToReadableStream` from `react-dom`, you get the following error:
```
1 | (function (entry, fetcher)
^
SyntaxError: Export named 'renderToReadableStream' not found in module '/path/to/node_modules/react-dom/server.node.js'.
1 | (function (entry, fetcher)
^
SyntaxError: Export named 'renderToReadableStream' not found in module '/path/to/node_modules/react-dom/server.node.js'.
```
In #28941 it was reported that adding a `"bun": "./server.browser.js",` export to the `package.json` fixes the issue.
## How did you test this change?
Screenshot with a run before and after the fix:
| {'url': 'https://api.github.com/repos/facebook/react/issues/28962/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28962/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28961 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28961/labels{/name} | https://api.github.com/repos/facebook/react/issues/28961/comments | https://api.github.com/repos/facebook/react/issues/28961/events | https://github.com/facebook/react/issues/28961 | 2,273,507,859 | I_kwDOAJy2Ks6HgvoT | 28,961 | `react-server-dom-webpack/node-register` not finding directives in IIFEs | {'login': 'jackyef', 'id': 7252454, 'node_id': 'MDQ6VXNlcjcyNTI0NTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7252454?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jackyef', 'html_url': 'https://github.com/jackyef', 'followers_url': 'https://api.github.com/users/jackyef/followers', 'following_url': 'https://api.github.com/users/jackyef/following{/other_user}', 'gists_url': 'https://api.github.com/users/jackyef/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/jackyef/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/jackyef/subscriptions', 'organizations_url': 'https://api.github.com/users/jackyef/orgs', 'repos_url': 'https://api.github.com/users/jackyef/repos', 'events_url': 'https://api.github.com/users/jackyef/events{/privacy}', 'received_events_url': 'https://api.github.com/users/jackyef/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | {'login': 'gnoff', 'id': 2716369.0, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False} | [{'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False}] | null | [] | 2024-05-01 13:28:42 | 2024-05-01 20:37:14 | null | NONE | null | null | null | ## Summary
`react-server-dom-webpack/node-register` doesn't find `use client` directive in IIFEs.
Consider the following code
<details><summary>code</summary>
```js
(() => {
"use strict";
"use client";
var __create = Object.create;
var __defProp = Object.defineProperty;
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
var __getOwnPropNames = Object.getOwnPropertyNames;
var __getProtoOf = Object.getPrototypeOf;
var __hasOwnProp = Object.prototype.hasOwnProperty;
var __name = (target, value) => __defProp(target, "name", {
value,
configurable: true
});
var __export = (target, all) => {
for (var name in all) __defProp(target, name, {
get: all[name],
enumerable: true
});
};
var __copyProps = (to, from, except, desc) => {
if (from && typeof from === "object" || typeof from === "function") {
for (let key of __getOwnPropNames(from)) if (!__hasOwnProp.call(to, key) && key !== except) __defProp(to, key, {
get: () => from[key],
enumerable: !(desc = __getOwnPropDesc(from, key)) || desc.enumerable
});
}
return to;
};
var __toESM = (mod, isNodeMode, target) => (target = mod != null ? __create(__getProtoOf(mod)) : {}, __copyProps(isNodeMode || !mod || !mod.__esModule ? __defProp(target, "default", {
value: mod,
enumerable: true
}) : target, mod));
var __toCommonJS = mod => __copyProps(__defProp({}, "__esModule", {
value: true
}), mod);
var Counter_client_exports = {};
__export(Counter_client_exports, {
Counter: () => Counter
});
module.exports = __toCommonJS(Counter_client_exports);
var import_jsx_dev_runtime = require("react/jsx-dev-runtime");
var React = __toESM(require("react"));
console.log("Counter.client.tsx", React.useState);
function Counter() {
const [count, setCount] = React.useState(0);
return (0, import_jsx_dev_runtime.jsxDEV)("div", {
children: [(0, import_jsx_dev_runtime.jsxDEV)("h1", {
children: "Counter"
}, void 0, false, {
fileName: "/Users/jackyef/Personal/Projects/beract/src/app/Counter.client.tsx",
lineNumber: 17,
columnNumber: 7
}, this), (0, import_jsx_dev_runtime.jsxDEV)("p", {
children: ["Count: ", count]
}, void 0, true, {
fileName: "/Users/jackyef/Personal/Projects/beract/src/app/Counter.client.tsx",
lineNumber: 18,
columnNumber: 7
}, this), (0, import_jsx_dev_runtime.jsxDEV)("button", {
onClick: () => setCount(c => c + 1),
children: "Increment"
}, void 0, false, {
fileName: "/Users/jackyef/Personal/Projects/beract/src/app/Counter.client.tsx",
lineNumber: 19,
columnNumber: 7
}, this)]
}, void 0, true, {
fileName: "/Users/jackyef/Personal/Projects/beract/src/app/Counter.client.tsx",
lineNumber: 16,
columnNumber: 5
}, this);
}
__name(Counter, "Counter");
})();
```
</details>
[This loop](https://github.com/facebook/react/blob/4508873393058e86bed308b56e49ec883ece59d1/packages/react-server-dom-webpack/src/ReactFlightWebpackNodeRegister.js#L53-L64) will not find the `use client` directive because it isn't searching deep enough.
Is this an expected behavior?
For what it's worth, I am not yet using Webpack to do compilation here, I am using [`tsx watch`](https://github.com/privatenumber/tsx) for fast setup.
```
"react": "19.0.0-canary-e3ebcd54b-20240405",
"react-dom": "19.0.0-canary-e3ebcd54b-20240405",
"react-server-dom-webpack": "19.0.0-canary-e3ebcd54b-20240405",
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28961/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28961/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28960 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28960/labels{/name} | https://api.github.com/repos/facebook/react/issues/28960/comments | https://api.github.com/repos/facebook/react/issues/28960/events | https://github.com/facebook/react/issues/28960 | 2,272,370,089 | I_kwDOAJy2Ks6HcZ2p | 28,960 | [DevTools Bug]: React 17 error while trying to inspect hooks "Context reads do not line up with context dependencies." | {'login': 'gdeedlerthryv', 'id': 122398572, 'node_id': 'U_kgDOB0unbA', 'avatar_url': 'https://avatars.githubusercontent.com/u/122398572?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gdeedlerthryv', 'html_url': 'https://github.com/gdeedlerthryv', 'followers_url': 'https://api.github.com/users/gdeedlerthryv/followers', 'following_url': 'https://api.github.com/users/gdeedlerthryv/following{/other_user}', 'gists_url': 'https://api.github.com/users/gdeedlerthryv/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gdeedlerthryv/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gdeedlerthryv/subscriptions', 'organizations_url': 'https://api.github.com/users/gdeedlerthryv/orgs', 'repos_url': 'https://api.github.com/users/gdeedlerthryv/repos', 'events_url': 'https://api.github.com/users/gdeedlerthryv/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gdeedlerthryv/received_events', 'type': 'User', 'site_admin': False} | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | {'login': 'eps1lon', 'id': 12292047.0, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False}] | null | [
"Same...\r\n\r\n\r\n",
"Thank you for the report! The underlying cause is calling `useContext` multiple times in the same component with the same context.\r\n\r\nThis is only a bug with React DevTools using React 17 and below. React 18 and above work fine. Should be fixed once https://github.com/facebook/react/pull/28974 is released. \r\n\r\nIn the meantime, you can install the unpacked extension from the branch when working with React 17 and below. Download https://output.circle-artifacts.com/output/job/03edee00-b0d2-48a2-b4b9-7e190c1ac521/artifacts/0/build/devtools/chrome-extension.zip, unpack it, go to chrome://extensions/, enable developer mode, click on \"load unpacked extension\" and select the unpacked `chrome-extension` (and make sure to disable any previously installed React Developer Tools extension).",
"Thank you!",
"Thank you so much!"
] | 2024-04-30 20:09:34 | 2024-05-03 08:53:40 | 2024-05-02 20:08:42 | NONE | null | null | null | ### Website or app
https://github.com/gdeedlerthryv/react-dev-tools-test/
### Repro steps
1. Inspect TestApp component
2. Get error
```
backendManager.js:117 React DevTools encountered an error while trying to inspect hooks. This is most likely caused by an error in current inspected component: "TestApp".
The error thrown in the component is:
Error: Context reads do not line up with context dependencies. This is a bug in React Debug Tools.
at H (react-debug-tools.production.min.js:14:310)
at Proxy.useContext (react-debug-tools.production.min.js:18:40)
at Object.useContext (chunk-GGTEBMAR.js?v=b51a6ac3:1125:29)
at useLocation (chunk-PFB6EJD6.js?v=b51a6ac3:3382:16)
at TestApp (main.jsx:13:20)
at R (react-debug-tools.production.min.js:32:287)
at exports.inspectHooksOfFiber (react-debug-tools.production.min.js:35:150)
at inspectElementRaw (renderer.js:3379:36)
at Object.inspectElement (renderer.js:3716:38)
at agent.js:420:18
```
Issue was introduced by DevTools 5.1.0 release, I think [this PR is the culprit.](https://github.com/facebook/react/pull/28467) I built the 5.0.2 extension and the error did not occur:
I wasn't able to repro the issue without external libraries, but someone who knows better probably could.
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_ | {'url': 'https://api.github.com/repos/facebook/react/issues/28960/reactions', 'total_count': 9, '+1': 9, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28960/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28959 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28959/labels{/name} | https://api.github.com/repos/facebook/react/issues/28959/comments | https://api.github.com/repos/facebook/react/issues/28959/events | https://github.com/facebook/react/pull/28959 | 2,272,299,162 | PR_kwDOAJy2Ks5uL8sr | 28,959 | typo: fix typos in codes.json | {'login': 'Gabefire', 'id': 33893811, 'node_id': 'MDQ6VXNlcjMzODkzODEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/33893811?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Gabefire', 'html_url': 'https://github.com/Gabefire', 'followers_url': 'https://api.github.com/users/Gabefire/followers', 'following_url': 'https://api.github.com/users/Gabefire/following{/other_user}', 'gists_url': 'https://api.github.com/users/Gabefire/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Gabefire/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Gabefire/subscriptions', 'organizations_url': 'https://api.github.com/users/Gabefire/orgs', 'repos_url': 'https://api.github.com/users/Gabefire/repos', 'events_url': 'https://api.github.com/users/Gabefire/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Gabefire/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @Gabefire! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328959). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4508873393058e86bed308b56e49ec883ece59d1...9653b4ddd09db3eeb8b84b510f89b6c4cc48ec83\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/9653b4ddd09db3eeb8b84b510f89b6c4cc48ec83/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/9653b4ddd09db3eeb8b84b510f89b6c4cc48ec83/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/9653b4ddd09db3eeb8b84b510f89b6c4cc48ec83/files/facebook-www/ReactDOM-prod.classic.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/9653b4ddd09db3eeb8b84b510f89b6c4cc48ec83/files/facebook-www/ReactDOM-prod.modern.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9653b4ddd09db3eeb8b84b510f89b6c4cc48ec83/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9653b4ddd09db3eeb8b84b510f89b6c4cc48ec83/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9653b4ddd09db3eeb8b84b510f89b6c4cc48ec83\n</p>\n",
"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!",
"Thanks for submitting this! A couple thing though:\r\n- These error messages are auto-generated from the code, so to fix them, you'd need to update the code. \r\n- Most of these are no longer in use and not shown to users\r\n- The one that is in use, already has a second error code with the typo fixed\r\n\r\nSo I don't think we need/want to merge this, but thanks for taking the time!"
] | 2024-04-30 19:24:21 | 2024-05-01 15:49:25 | 2024-05-01 15:49:24 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28959', 'html_url': 'https://github.com/facebook/react/pull/28959', 'diff_url': 'https://github.com/facebook/react/pull/28959.diff', 'patch_url': 'https://github.com/facebook/react/pull/28959.patch', 'merged_at': None} | ## Summary
Noticed a few typos in error code mapping adding a PR to clean it up a little bit
| {'url': 'https://api.github.com/repos/facebook/react/issues/28959/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28959/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28958 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28958/labels{/name} | https://api.github.com/repos/facebook/react/issues/28958/comments | https://api.github.com/repos/facebook/react/issues/28958/events | https://github.com/facebook/react/pull/28958 | 2,271,651,406 | PR_kwDOAJy2Ks5uJ1oZ | 28,958 | Float: Stringify `crossorigin="anonymous"` | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d779eba4b375134f373b7dfb9ea98d01c84bc48e...d5bdae711eaa0f55e61e120a1e625381f7e5dce2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.78%** | 6.66 kB | 6.71 kB | +0.77% | 1.82 kB | 1.84 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.78%** | 6.67 kB | 6.72 kB | +0.77% | 1.83 kB | 1.84 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/facebook-www/ReactDOM-prod.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 591.11 kB | 591.16 kB | +0.01% | 103.94 kB | 103.95 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/facebook-www/ReactDOM-prod.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 567.33 kB | 567.39 kB | +0.02% | 100.34 kB | 100.36 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/__test_utils__/ReactAllWarnings.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-dom/cjs/react-dom.react-server.production.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-experimental/react-dom/cjs/react-dom.react-server.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.07%** | 4.84 kB | 4.89 kB | +1.29% | 1.24 kB | 1.26 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.07%** | 4.84 kB | 4.89 kB | +1.29% | 1.24 kB | 1.26 kB\n| [oss-stable/react-dom/cjs/react-dom.react-server.production.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable/react-dom/cjs/react-dom.react-server.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.07%** | 4.84 kB | 4.89 kB | +1.29% | 1.24 kB | 1.26 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable-semver/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.78%** | 6.64 kB | 6.69 kB | +0.83% | 1.80 kB | 1.81 kB\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.78%** | 6.66 kB | 6.71 kB | +0.77% | 1.82 kB | 1.84 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.78%** | 6.67 kB | 6.72 kB | +0.77% | 1.83 kB | 1.84 kB\n| [oss-experimental/react-dom/cjs/react-dom.react-server.development.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-experimental/react-dom/cjs/react-dom.react-server.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.30%** | 16.55 kB | 16.60 kB | +0.30% | 3.61 kB | 3.62 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.react-server.development.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable-semver/react-dom/cjs/react-dom.react-server.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.30%** | 16.55 kB | 16.60 kB | +0.30% | 3.61 kB | 3.62 kB\n| [oss-stable/react-dom/cjs/react-dom.react-server.development.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable/react-dom/cjs/react-dom.react-server.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.30%** | 16.55 kB | 16.60 kB | +0.30% | 3.61 kB | 3.62 kB\n| [oss-stable-semver/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable-semver/react-dom/cjs/react-dom.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.20%** | 24.46 kB | 24.51 kB | +0.18% | 6.23 kB | 6.24 kB\n| [oss-stable/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-stable/react-dom/cjs/react-dom.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.20%** | 24.49 kB | 24.54 kB | +0.19% | 6.26 kB | 6.27 kB\n| [oss-experimental/react-dom/cjs/react-dom.development.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/oss-experimental/react-dom/cjs/react-dom.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.20%** | 24.50 kB | 24.55 kB | +0.19% | 6.26 kB | 6.27 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d5bdae711eaa0f55e61e120a1e625381f7e5dce2/files/__test_utils__/ReactAllWarnings.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against d5bdae711eaa0f55e61e120a1e625381f7e5dce2\n</p>\n",
"The spec doesn't show it clearly but the invalid value state is also anonymous so conceptually I've been thinking about crossorigin as just a tri-value. missing, \"\", and \"use-credentials\" to map to no cors, anon cors, and credentials\r\n\r\nThe other reason to use empty string aggressively is that it's just shorter. Are you concerned that folks will look at the tag and think something is wrong? or that the spec might change in the future and make this optimization semantically breaking? (I doubt they could do the latter given the hesitance to break the web so I feel pretty confident we can leave this be)",
"> The other reason to use empty string aggressively is that it's just shorter. Are you concerned that folks will look at the tag and think something is wrong? \r\n\r\nI did 😅 Mainly because I got confused by the spec (empty value and `crossorigin` meaning the same thing) but also because it differs from how we SSR `<img crossOrigin=\"whatever\" />`.\r\n\r\nI wouldn't have filed this if I understood that the empty value is the same as `crossorigin=\"anonymous\"`. But now that it's open, and in the light of how difficult it is to land new attribute (values) in React, I'm wondering if we should optimize for bytes saved or future compatibility (i.e. don't normalize the string value at all and stringify it as-is). In the end, people can still opt for bytes saved by passing `crossOrigin: ''`, no?",
"Well, the thing that is different here is you aren't rendering the preload link yourself. This tag is owned by the react runtime so we're not really altering a user value. I suppose you could argue that `ReactDOM.preload(..., { crossOrigin: \"anonymous\" })` is a user value but even still I think you are saying you want anonymous CORS mode not that you want a specific tag with a specific attribute.\r\n\r\nSo I don't think we need to extrapolate too much that we're different if you render <img crossOrigin=\"anonymous\"> you get one serialization but the preload link doesn't match",
"Yeah makes sense"
] | 2024-04-30 14:34:34 | 2024-05-03 08:16:45 | 2024-05-03 08:16:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28958', 'html_url': 'https://github.com/facebook/react/pull/28958', 'diff_url': 'https://github.com/facebook/react/pull/28958.diff', 'patch_url': 'https://github.com/facebook/react/pull/28958.patch', 'merged_at': None} | ## Summary
`<img crossOrigin="anonymous" />` now creates the corresponding `<link rel="preload" />` tag preserving `crossOrigin` since [`anonymous` is a valid value for `crossOrigin`](https://html.spec.whatwg.org/multipage/urls-and-fetching.html#cors-settings-attributes).
It doesn't change production behavior since it results in the same state. Mainly to just reduce confusion but then `crossOrigin="some-non-existing-value"` would also result in `crossorigin=""` so maybe that's fine?
## How did you test this change?
Added test for `<img crossOrigin="anonymous" />`. Other tests were also updated so I'm curious if ignoring `anonymous` is intended for `preconnect`.
I also added a test showing how `crossOrigin` doesn't factor into keying. Mostly to show the difference between how Float and `next/legacy/image` differs with regard to preloading. `next/legacy/image` currently adds a `<link rel="preload" />` matching `crossOrigin` of the **last** `<img />` with the same key whereas Float uses `crossOrigin` from the **first** image.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28958/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28958/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28957 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28957/labels{/name} | https://api.github.com/repos/facebook/react/issues/28957/comments | https://api.github.com/repos/facebook/react/issues/28957/events | https://github.com/facebook/react/pull/28957 | 2,271,461,026 | PR_kwDOAJy2Ks5uJOGD | 28,957 | Introduce `forceSyncUpdate` to class component | {'login': 'zhantx', 'id': 14803931, 'node_id': 'MDQ6VXNlcjE0ODAzOTMx', 'avatar_url': 'https://avatars.githubusercontent.com/u/14803931?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zhantx', 'html_url': 'https://github.com/zhantx', 'followers_url': 'https://api.github.com/users/zhantx/followers', 'following_url': 'https://api.github.com/users/zhantx/following{/other_user}', 'gists_url': 'https://api.github.com/users/zhantx/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/zhantx/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/zhantx/subscriptions', 'organizations_url': 'https://api.github.com/users/zhantx/orgs', 'repos_url': 'https://api.github.com/users/zhantx/repos', 'events_url': 'https://api.github.com/users/zhantx/events{/privacy}', 'received_events_url': 'https://api.github.com/users/zhantx/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d779eba4b375134f373b7dfb9ea98d01c84bc48e...cec73c1e1c80db28b9be5655ab4bf4f7c6b00610\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-www/ReactDOM-prod.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.07%** | 591.11 kB | 591.50 kB | +0.02% | 103.94 kB | 103.96 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-www/ReactDOM-prod.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.07%** | 567.33 kB | 567.73 kB | +0.03% | 100.34 kB | 100.37 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/__test_utils__/ReactAllWarnings.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable-semver/react/cjs/react.development.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/oss-stable-semver/react/cjs/react.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.66%** | 93.48 kB | 95.03 kB | +0.36% | 25.60 kB | 25.69 kB\n| [oss-stable/react/cjs/react.development.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/oss-stable/react/cjs/react.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.66%** | 93.50 kB | 95.05 kB | +0.37% | 25.63 kB | 25.72 kB\n| [oss-experimental/react/cjs/react.development.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/oss-experimental/react/cjs/react.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.63%** | 95.17 kB | 96.72 kB | +0.40% | 26.01 kB | 26.11 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-react-native/react/cjs/React-dev.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.37%** | 113.13 kB | 114.68 kB | +0.35% | 29.43 kB | 29.53 kB\n| [facebook-www/React-dev.modern.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-www/React-dev.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.33%** | 116.14 kB | 117.69 kB | +0.34% | 30.11 kB | 30.21 kB\n| [facebook-www/React-dev.classic.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-www/React-dev.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.33%** | 116.63 kB | 118.18 kB | +0.34% | 30.22 kB | 30.32 kB\n| [oss-stable-semver/react/cjs/react.production.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/oss-stable-semver/react/cjs/react.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.07%** | 16.87 kB | 17.05 kB | +0.48% | 4.39 kB | 4.41 kB\n| [oss-stable/react/cjs/react.production.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/oss-stable/react/cjs/react.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.07%** | 16.89 kB | 17.07 kB | +0.43% | 4.42 kB | 4.44 kB\n| [oss-experimental/react/cjs/react.production.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/oss-experimental/react/cjs/react.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+1.00%** | 18.01 kB | 18.20 kB | +0.41% | 4.68 kB | 4.70 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-react-native/react/cjs/React-prod.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.83%** | 21.88 kB | 22.06 kB | +0.30% | 5.74 kB | 5.75 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-react-native/react/cjs/React-profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.81%** | 22.32 kB | 22.50 kB | +0.33% | 5.81 kB | 5.83 kB\n| [facebook-www/React-prod.modern.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-www/React-prod.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.80%** | 22.68 kB | 22.86 kB | +0.39% | 5.84 kB | 5.86 kB\n| [facebook-www/React-prod.classic.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-www/React-prod.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.80%** | 22.68 kB | 22.86 kB | +0.38% | 5.84 kB | 5.86 kB\n| [facebook-www/React-profiling.modern.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-www/React-profiling.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.78%** | 23.12 kB | 23.30 kB | +0.39% | 5.92 kB | 5.94 kB\n| [facebook-www/React-profiling.classic.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/facebook-www/React-profiling.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.78%** | 23.12 kB | 23.30 kB | +0.37% | 5.92 kB | 5.94 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/cec73c1e1c80db28b9be5655ab4bf4f7c6b00610/files/__test_utils__/ReactAllWarnings.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against cec73c1e1c80db28b9be5655ab4bf4f7c6b00610\n</p>\n"
] | 2024-04-30 13:18:38 | 2024-04-30 13:36:59 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28957', 'html_url': 'https://github.com/facebook/react/pull/28957', 'diff_url': 'https://github.com/facebook/react/pull/28957.diff', 'patch_url': 'https://github.com/facebook/react/pull/28957.patch', 'merged_at': None} | ## Summary
As described in issue [#28897](https://github.com/facebook/react/issues/28897), there is currently no reliable API for a class component to be updated in SyncLane. This API is desired when a class component is subscribed to an external store, e.g. mobx.
Function component can achieve this reliably by using `useSyncExternalStore`. However, class component may be updated at an arbitrary time.
## How did you test this change?
No implement at the moment
| {'url': 'https://api.github.com/repos/facebook/react/issues/28957/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28957/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28956 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28956/labels{/name} | https://api.github.com/repos/facebook/react/issues/28956/comments | https://api.github.com/repos/facebook/react/issues/28956/events | https://github.com/facebook/react/issues/28956 | 2,271,032,331 | I_kwDOAJy2Ks6HXTQL | 28,956 | [React 19] react-reconciler README is missing scheduler and form hooks | {'login': 'CodyJasonBennett', 'id': 23324155, 'node_id': 'MDQ6VXNlcjIzMzI0MTU1', 'avatar_url': 'https://avatars.githubusercontent.com/u/23324155?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/CodyJasonBennett', 'html_url': 'https://github.com/CodyJasonBennett', 'followers_url': 'https://api.github.com/users/CodyJasonBennett/followers', 'following_url': 'https://api.github.com/users/CodyJasonBennett/following{/other_user}', 'gists_url': 'https://api.github.com/users/CodyJasonBennett/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/CodyJasonBennett/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/CodyJasonBennett/subscriptions', 'organizations_url': 'https://api.github.com/users/CodyJasonBennett/orgs', 'repos_url': 'https://api.github.com/users/CodyJasonBennett/repos', 'events_url': 'https://api.github.com/users/CodyJasonBennett/events{/privacy}', 'received_events_url': 'https://api.github.com/users/CodyJasonBennett/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [] | 2024-04-30 09:58:51 | 2024-04-30 09:58:51 | null | NONE | null | null | null | ## Summary
I've been working on updating the types for react-reconciler, and found methods are still missing from its README after recent updates. These are detailed in https://github.com/pmndrs/react-three-fiber/pull/3242 based on implementation, but they are as follows:
- `NotPendingTransition` #26722
- `setCurrentUpdatePriority`, `getCurrentUpdatePriority`, `resolveUpdatePriority` #28751
- `resetFormInstance` #28804
- `requestPostPaintCallback` #25105
- `shouldAttemptEagerTransition` #26025
I can open a PR for updating the README specifically, but I haven't looked deeper to see if there was anything else missing in the repo. | {'url': 'https://api.github.com/repos/facebook/react/issues/28956/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28956/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28955 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28955/labels{/name} | https://api.github.com/repos/facebook/react/issues/28955/comments | https://api.github.com/repos/facebook/react/issues/28955/events | https://github.com/facebook/react/pull/28955 | 2,270,393,224 | PR_kwDOAJy2Ks5uFjqc | 28,955 | [react-native] Add unit test to ReactNativeAttributePayload | {'login': 'javache', 'id': 5676, 'node_id': 'MDQ6VXNlcjU2NzY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5676?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/javache', 'html_url': 'https://github.com/javache', 'followers_url': 'https://api.github.com/users/javache/followers', 'following_url': 'https://api.github.com/users/javache/following{/other_user}', 'gists_url': 'https://api.github.com/users/javache/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/javache/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/javache/subscriptions', 'organizations_url': 'https://api.github.com/users/javache/orgs', 'repos_url': 'https://api.github.com/users/javache/repos', 'events_url': 'https://api.github.com/users/javache/events{/privacy}', 'received_events_url': 'https://api.github.com/users/javache/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 190cc990e01e5131a6b26f1a3212444cebd794e2...25732914f53a793c2bdcb84a97877c4c73efae16\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/25732914f53a793c2bdcb84a97877c4c73efae16/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/25732914f53a793c2bdcb84a97877c4c73efae16/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/25732914f53a793c2bdcb84a97877c4c73efae16/files/facebook-www/ReactDOM-prod.classic.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/25732914f53a793c2bdcb84a97877c4c73efae16/files/facebook-www/ReactDOM-prod.modern.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/25732914f53a793c2bdcb84a97877c4c73efae16/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/25732914f53a793c2bdcb84a97877c4c73efae16/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 25732914f53a793c2bdcb84a97877c4c73efae16\n</p>\n"
] | 2024-04-30 02:48:32 | 2024-04-30 02:57:53 | 2024-04-30 02:57:32 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28955', 'html_url': 'https://github.com/facebook/react/pull/28955', 'diff_url': 'https://github.com/facebook/react/pull/28955.diff', 'patch_url': 'https://github.com/facebook/react/pull/28955.patch', 'merged_at': datetime.datetime(2024, 4, 30, 2, 57, 32)} | ## Summary
I'm looking at cleaning up some unnecessary manual property flattening in React Native and wanted to verify this behaviour is working as expected, where properties from nested objects will always overwrite properties from the base object.
## How did you test this change?
Unit tests | {'url': 'https://api.github.com/repos/facebook/react/issues/28955/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28955/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28954 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28954/labels{/name} | https://api.github.com/repos/facebook/react/issues/28954/comments | https://api.github.com/repos/facebook/react/issues/28954/events | https://github.com/facebook/react/pull/28954 | 2,269,549,022 | PR_kwDOAJy2Ks5uCoho | 28,954 | Move useMemoCache hook to react/compiler-runtime | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d779eba4b375134f373b7dfb9ea98d01c84bc48e...10b2ec7c99e8f63a4d5cd14eb9712a402f860d16\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-www/ReactDOM-prod.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-www/ReactDOM-prod.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [oss-experimental/react/cjs/react-compiler-runtime.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/cjs/react-compiler-runtime.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 2.60 kB | +∞% | 0.00 kB | 1.31 kB\n| [oss-experimental/react/cjs/react-compiler-runtime.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/cjs/react-compiler-runtime.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-experimental/react/cjs/react-compiler-runtime.profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/cjs/react-compiler-runtime.profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-experimental/react/compiler-runtime.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/compiler-runtime.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.41 kB | +∞% | 0.00 kB | 0.27 kB\n| [oss-stable-semver/react/cjs/react-compiler-runtime.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react/cjs/react-compiler-runtime.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 2.60 kB | +∞% | 0.00 kB | 1.31 kB\n| [oss-stable-semver/react/cjs/react-compiler-runtime.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react/cjs/react-compiler-runtime.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-stable-semver/react/cjs/react-compiler-runtime.profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react/cjs/react-compiler-runtime.profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-stable-semver/react/compiler-runtime.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react/compiler-runtime.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.41 kB | +∞% | 0.00 kB | 0.27 kB\n| [oss-stable/react/cjs/react-compiler-runtime.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react/cjs/react-compiler-runtime.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 2.60 kB | +∞% | 0.00 kB | 1.31 kB\n| [oss-stable/react/cjs/react-compiler-runtime.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react/cjs/react-compiler-runtime.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-stable/react/cjs/react-compiler-runtime.profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react/cjs/react-compiler-runtime.profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-stable/react/compiler-runtime.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react/compiler-runtime.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.41 kB | +∞% | 0.00 kB | 0.27 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/__test_utils__/ReactAllWarnings.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react/cjs/react-compiler-runtime.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/cjs/react-compiler-runtime.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 2.60 kB | +∞% | 0.00 kB | 1.31 kB\n| [oss-experimental/react/cjs/react-compiler-runtime.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/cjs/react-compiler-runtime.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-experimental/react/cjs/react-compiler-runtime.profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/cjs/react-compiler-runtime.profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-experimental/react/compiler-runtime.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/compiler-runtime.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.41 kB | +∞% | 0.00 kB | 0.27 kB\n| [oss-stable-semver/react/cjs/react-compiler-runtime.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react/cjs/react-compiler-runtime.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 2.60 kB | +∞% | 0.00 kB | 1.31 kB\n| [oss-stable-semver/react/cjs/react-compiler-runtime.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react/cjs/react-compiler-runtime.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-stable-semver/react/cjs/react-compiler-runtime.profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react/cjs/react-compiler-runtime.profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-stable-semver/react/compiler-runtime.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react/compiler-runtime.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.41 kB | +∞% | 0.00 kB | 0.27 kB\n| [oss-stable/react/cjs/react-compiler-runtime.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react/cjs/react-compiler-runtime.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 2.60 kB | +∞% | 0.00 kB | 1.31 kB\n| [oss-stable/react/cjs/react-compiler-runtime.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react/cjs/react-compiler-runtime.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-stable/react/cjs/react-compiler-runtime.profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react/cjs/react-compiler-runtime.profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.46 kB | +∞% | 0.00 kB | 0.33 kB\n| [oss-stable/react/compiler-runtime.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react/compiler-runtime.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+∞%** | 0.00 kB | 0.41 kB | +∞% | 0.00 kB | 0.27 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-react-native/react/cjs/React-prod.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.23%** | 21.88 kB | 21.93 kB | +0.21% | 5.74 kB | 5.75 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-react-native/react/cjs/React-profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.23%** | 22.32 kB | 22.37 kB | +0.21% | 5.81 kB | 5.83 kB\n| [facebook-www/React-prod.modern.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-www/React-prod.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.22%** | 22.68 kB | 22.73 kB | +0.33% | 5.84 kB | 5.86 kB\n| [facebook-www/React-prod.classic.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-www/React-prod.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.22%** | 22.68 kB | 22.73 kB | +0.31% | 5.84 kB | 5.86 kB\n| [facebook-www/React-profiling.modern.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-www/React-profiling.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.22%** | 23.12 kB | 23.17 kB | +0.29% | 5.92 kB | 5.93 kB\n| [facebook-www/React-profiling.classic.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-www/React-profiling.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.22%** | 23.12 kB | 23.17 kB | +0.29% | 5.92 kB | 5.94 kB\n| [facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **+0.20%** | 337.57 kB | 338.26 kB | +0.15% | 58.62 kB | 58.71 kB\n| [react-native/implementations/ReactFabric-profiling.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/react-native/implementations/ReactFabric-profiling.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 337.01 kB | 336.31 kB | = | 58.35 kB | 58.26 kB\n| [react-native/implementations/ReactFabric-prod.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/react-native/implementations/ReactFabric-prod.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 309.96 kB | 309.25 kB | = | 54.16 kB | 54.08 kB\n| [oss-experimental/react/cjs/react.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/cjs/react.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 95.17 kB | 94.95 kB | = | 26.01 kB | 25.98 kB\n| [oss-stable/react-test-renderer/cjs/react-test-renderer.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react-test-renderer/cjs/react-test-renderer.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 298.34 kB | 296.89 kB | = | 53.03 kB | 52.73 kB\n| [oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 298.29 kB | 296.84 kB | = | 53.00 kB | 52.70 kB\n| [oss-stable/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable/react-test-renderer/cjs/react-test-renderer.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 805.02 kB | 800.93 kB | = | 175.53 kB | 174.55 kB\n| [oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 804.99 kB | 800.90 kB | = | 175.50 kB | 174.52 kB\n| [oss-experimental/react/cjs/react.production.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/oss-experimental/react/cjs/react.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 18.01 kB | 17.91 kB | = | 4.68 kB | 4.66 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/10b2ec7c99e8f63a4d5cd14eb9712a402f860d16/files/__test_utils__/ReactAllWarnings.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 10b2ec7c99e8f63a4d5cd14eb9712a402f860d16\n</p>\n"
] | 2024-04-29 17:16:03 | 2024-04-30 16:00:22 | 2024-04-30 16:00:22 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28954', 'html_url': 'https://github.com/facebook/react/pull/28954', 'diff_url': 'https://github.com/facebook/react/pull/28954.diff', 'patch_url': 'https://github.com/facebook/react/pull/28954.patch', 'merged_at': datetime.datetime(2024, 4, 30, 16, 0, 22)} | Move useMemoCache hook to react/compiler-runtime
For Meta-internal purposes, we keep the export on `react` itself to reduce churn.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28954/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 2, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28954/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28953 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28953/labels{/name} | https://api.github.com/repos/facebook/react/issues/28953/comments | https://api.github.com/repos/facebook/react/issues/28953/events | https://github.com/facebook/react/pull/28953 | 2,269,478,816 | PR_kwDOAJy2Ks5uCZIH | 28,953 | fix(deps): Grouped dependencies updates by Dependabot | {'login': 'Zaid-maker', 'id': 53424436, 'node_id': 'MDQ6VXNlcjUzNDI0NDM2', 'avatar_url': 'https://avatars.githubusercontent.com/u/53424436?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Zaid-maker', 'html_url': 'https://github.com/Zaid-maker', 'followers_url': 'https://api.github.com/users/Zaid-maker/followers', 'following_url': 'https://api.github.com/users/Zaid-maker/following{/other_user}', 'gists_url': 'https://api.github.com/users/Zaid-maker/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Zaid-maker/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Zaid-maker/subscriptions', 'organizations_url': 'https://api.github.com/users/Zaid-maker/orgs', 'repos_url': 'https://api.github.com/users/Zaid-maker/repos', 'events_url': 'https://api.github.com/users/Zaid-maker/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Zaid-maker/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [] | 2024-04-29 16:35:31 | 2024-05-04 08:51:10 | 2024-04-30 04:38:09 | NONE | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28953', 'html_url': 'https://github.com/facebook/react/pull/28953', 'diff_url': 'https://github.com/facebook/react/pull/28953.diff', 'patch_url': 'https://github.com/facebook/react/pull/28953.patch', 'merged_at': None} | ## Summary
## How did you test this change?
| {'url': 'https://api.github.com/repos/facebook/react/issues/28953/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28953/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28952 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28952/labels{/name} | https://api.github.com/repos/facebook/react/issues/28952/comments | https://api.github.com/repos/facebook/react/issues/28952/events | https://github.com/facebook/react/pull/28952 | 2,269,221,283 | PR_kwDOAJy2Ks5uBgUt | 28,952 | move from `importAssertions` to `importAttributes` | {'login': 'kentcdodds', 'id': 1500684, 'node_id': 'MDQ6VXNlcjE1MDA2ODQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1500684?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kentcdodds', 'html_url': 'https://github.com/kentcdodds', 'followers_url': 'https://api.github.com/users/kentcdodds/followers', 'following_url': 'https://api.github.com/users/kentcdodds/following{/other_user}', 'gists_url': 'https://api.github.com/users/kentcdodds/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kentcdodds/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kentcdodds/subscriptions', 'organizations_url': 'https://api.github.com/users/kentcdodds/orgs', 'repos_url': 'https://api.github.com/users/kentcdodds/repos', 'events_url': 'https://api.github.com/users/kentcdodds/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kentcdodds/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 190cc990e01e5131a6b26f1a3212444cebd794e2...8c68a19de0554fb0754c1c1e38e52d346b19d109\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8c68a19de0554fb0754c1c1e38e52d346b19d109/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8c68a19de0554fb0754c1c1e38e52d346b19d109/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/8c68a19de0554fb0754c1c1e38e52d346b19d109/files/facebook-www/ReactDOM-prod.classic.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/8c68a19de0554fb0754c1c1e38e52d346b19d109/files/facebook-www/ReactDOM-prod.modern.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8c68a19de0554fb0754c1c1e38e52d346b19d109/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8c68a19de0554fb0754c1c1e38e52d346b19d109/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8c68a19de0554fb0754c1c1e38e52d346b19d109\n</p>\n"
] | 2024-04-29 14:36:48 | 2024-04-29 14:41:52 | null | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28952', 'html_url': 'https://github.com/facebook/react/pull/28952', 'diff_url': 'https://github.com/facebook/react/pull/28952.diff', 'patch_url': 'https://github.com/facebook/react/pull/28952.patch', 'merged_at': None} | ## Summary
This is to account for the change in the proposal: https://github.com/tc39/proposal-import-attributes
Without this, you'll get the following warning on recent versions of node:
```
(node:39166) ExperimentalWarning: Use `importAttributes` instead of `importAssertions`
```
## How did you test this change?
Did a find/replace and ran the tests. I also use the `react-server-dom-esm` node loader in a workshop with Node v20.10.0 and this change removed the warning while preserving the functionality. I did not test the other packages. | {'url': 'https://api.github.com/repos/facebook/react/issues/28952/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28952/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28951 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28951/labels{/name} | https://api.github.com/repos/facebook/react/issues/28951/comments | https://api.github.com/repos/facebook/react/issues/28951/events | https://github.com/facebook/react/pull/28951 | 2,269,141,128 | PR_kwDOAJy2Ks5uBOwo | 28,951 | Test StrictEffects in react-dom | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 190cc990e01e5131a6b26f1a3212444cebd794e2...acd5fcc12b1ca30df6f863343e8e2ccf16581eb2\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/acd5fcc12b1ca30df6f863343e8e2ccf16581eb2/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/acd5fcc12b1ca30df6f863343e8e2ccf16581eb2/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/acd5fcc12b1ca30df6f863343e8e2ccf16581eb2/files/facebook-www/ReactDOM-prod.classic.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/acd5fcc12b1ca30df6f863343e8e2ccf16581eb2/files/facebook-www/ReactDOM-prod.modern.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/acd5fcc12b1ca30df6f863343e8e2ccf16581eb2/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/acd5fcc12b1ca30df6f863343e8e2ccf16581eb2/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against acd5fcc12b1ca30df6f863343e8e2ccf16581eb2\n</p>\n"
] | 2024-04-29 14:03:11 | 2024-04-29 16:50:52 | null | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28951', 'html_url': 'https://github.com/facebook/react/pull/28951', 'diff_url': 'https://github.com/facebook/react/pull/28951.diff', 'patch_url': 'https://github.com/facebook/react/pull/28951.patch', 'merged_at': None} | Working in render but broken in `hydrateRoot`. | {'url': 'https://api.github.com/repos/facebook/react/issues/28951/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28951/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28950 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28950/labels{/name} | https://api.github.com/repos/facebook/react/issues/28950/comments | https://api.github.com/repos/facebook/react/issues/28950/events | https://github.com/facebook/react/pull/28950 | 2,268,746,154 | PR_kwDOAJy2Ks5t_20Y | 28,950 | Update config.yml | {'login': 'qnkarthika', 'id': 134907181, 'node_id': 'U_kgDOCAqFLQ', 'avatar_url': 'https://avatars.githubusercontent.com/u/134907181?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/qnkarthika', 'html_url': 'https://github.com/qnkarthika', 'followers_url': 'https://api.github.com/users/qnkarthika/followers', 'following_url': 'https://api.github.com/users/qnkarthika/following{/other_user}', 'gists_url': 'https://api.github.com/users/qnkarthika/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/qnkarthika/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/qnkarthika/subscriptions', 'organizations_url': 'https://api.github.com/users/qnkarthika/orgs', 'repos_url': 'https://api.github.com/users/qnkarthika/repos', 'events_url': 'https://api.github.com/users/qnkarthika/events{/privacy}', 'received_events_url': 'https://api.github.com/users/qnkarthika/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @qnkarthika! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328950). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 190cc990e01e5131a6b26f1a3212444cebd794e2...2f89e30af28aed4ec818d31a417b56ab1fd2fc2f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/2f89e30af28aed4ec818d31a417b56ab1fd2fc2f/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/2f89e30af28aed4ec818d31a417b56ab1fd2fc2f/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/2f89e30af28aed4ec818d31a417b56ab1fd2fc2f/files/facebook-www/ReactDOM-prod.classic.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/2f89e30af28aed4ec818d31a417b56ab1fd2fc2f/files/facebook-www/ReactDOM-prod.modern.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2f89e30af28aed4ec818d31a417b56ab1fd2fc2f/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2f89e30af28aed4ec818d31a417b56ab1fd2fc2f/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2f89e30af28aed4ec818d31a417b56ab1fd2fc2f\n</p>\n",
"Since these are all subjective nits that don't seem to alter or clarify the original meaning, I'm going to close. But thanks for your suggestions."
] | 2024-04-29 11:11:57 | 2024-04-29 11:40:32 | 2024-04-29 11:40:31 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28950', 'html_url': 'https://github.com/facebook/react/pull/28950', 'diff_url': 'https://github.com/facebook/react/pull/28950.diff', 'patch_url': 'https://github.com/facebook/react/pull/28950.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28950/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28950/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28949 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28949/labels{/name} | https://api.github.com/repos/facebook/react/issues/28949/comments | https://api.github.com/repos/facebook/react/issues/28949/events | https://github.com/facebook/react/pull/28949 | 2,268,643,251 | PR_kwDOAJy2Ks5t_gDC | 28,949 | Gaurav added a message | {'login': 'Gaurav282828', 'id': 69344344, 'node_id': 'MDQ6VXNlcjY5MzQ0MzQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/69344344?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Gaurav282828', 'html_url': 'https://github.com/Gaurav282828', 'followers_url': 'https://api.github.com/users/Gaurav282828/followers', 'following_url': 'https://api.github.com/users/Gaurav282828/following{/other_user}', 'gists_url': 'https://api.github.com/users/Gaurav282828/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Gaurav282828/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Gaurav282828/subscriptions', 'organizations_url': 'https://api.github.com/users/Gaurav282828/orgs', 'repos_url': 'https://api.github.com/users/Gaurav282828/repos', 'events_url': 'https://api.github.com/users/Gaurav282828/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Gaurav282828/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @Gaurav282828! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328949). Thanks!",
"m",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 190cc990e01e5131a6b26f1a3212444cebd794e2...f276c664303fe8f6a2de0190b5e586d66e0f4ff1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/f276c664303fe8f6a2de0190b5e586d66e0f4ff1/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/f276c664303fe8f6a2de0190b5e586d66e0f4ff1/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/f276c664303fe8f6a2de0190b5e586d66e0f4ff1/files/facebook-www/ReactDOM-prod.classic.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/f276c664303fe8f6a2de0190b5e586d66e0f4ff1/files/facebook-www/ReactDOM-prod.modern.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f276c664303fe8f6a2de0190b5e586d66e0f4ff1/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f276c664303fe8f6a2de0190b5e586d66e0f4ff1/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against f276c664303fe8f6a2de0190b5e586d66e0f4ff1\n</p>\n",
"@gnoff @acdlite please take a look at these Spam PR's",
"Great to see you trying to get into open source.\r\n\r\nPlease experiment with markdown (e.g. https://dillinger.io/) or pull requests (see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request for further documentation) on a personal repository. Opening Pull Requests or issues creates notifications for maintainers and everyone watching this repository."
] | 2024-04-29 10:17:03 | 2024-04-29 10:55:18 | 2024-04-29 10:55:17 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28949', 'html_url': 'https://github.com/facebook/react/pull/28949', 'diff_url': 'https://github.com/facebook/react/pull/28949.diff', 'patch_url': 'https://github.com/facebook/react/pull/28949.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28949/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28949/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28948 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28948/labels{/name} | https://api.github.com/repos/facebook/react/issues/28948/comments | https://api.github.com/repos/facebook/react/issues/28948/events | https://github.com/facebook/react/issues/28948 | 2,268,546,163 | I_kwDOAJy2Ks6HN0Rz | 28,948 | Bug: Warning: React does not recognize the `fetchPriority` prop on a DOM element [React 18.3.1] | {'login': 'martabitbrain', 'id': 101552430, 'node_id': 'U_kgDOBg2RLg', 'avatar_url': 'https://avatars.githubusercontent.com/u/101552430?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/martabitbrain', 'html_url': 'https://github.com/martabitbrain', 'followers_url': 'https://api.github.com/users/martabitbrain/followers', 'following_url': 'https://api.github.com/users/martabitbrain/following{/other_user}', 'gists_url': 'https://api.github.com/users/martabitbrain/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/martabitbrain/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/martabitbrain/subscriptions', 'organizations_url': 'https://api.github.com/users/martabitbrain/orgs', 'repos_url': 'https://api.github.com/users/martabitbrain/repos', 'events_url': 'https://api.github.com/users/martabitbrain/events{/privacy}', 'received_events_url': 'https://api.github.com/users/martabitbrain/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Duplicate of https://github.com/facebook/react/issues/27233. Fixed in Canary release channel and once React 19 becomes stable.",
"Sorry, I didn't notice."
] | 2024-04-29 09:28:14 | 2024-04-29 10:05:21 | 2024-04-29 09:52:29 | NONE | null | null | null | React version: 18.3.1
This bug may be related to #28946 .
## Steps To Reproduce
1. Create an image tag with `fetchPriority="high"` attribute (camelCase)
2. Create an image tag with `fetchpriority="high"` attribute (lowercase)
Link to code example: https://codesandbox.io/p/sandbox/quiet-haze-5hkscx
## The current behavior
**Output**: (fetchpriority attribute looks ok!)
```
<img fetchpriority="high" src="https://dummyimage.com/200x64/b000b0/fff&text=fetchPriority">
<img fetchpriority="high" src="https://dummyimage.com/200x64/00b075/fff&text=fetchpriority">
```
**Warning**:
```
Warning: React does not recognize the `fetchPriority` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `fetchpriority` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
```
## The expected behavior
The same output, but no warning.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28948/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28948/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28947 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28947/labels{/name} | https://api.github.com/repos/facebook/react/issues/28947/comments | https://api.github.com/repos/facebook/react/issues/28947/events | https://github.com/facebook/react/issues/28947 | 2,268,439,668 | I_kwDOAJy2Ks6HNaR0 | 28,947 | Bug: Uncaught TypeError: Cannot read properties of null (reading 'useMemo') [React 18.3.1] | {'login': 'owenn2106', 'id': 75826315, 'node_id': 'MDQ6VXNlcjc1ODI2MzE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/75826315?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/owenn2106', 'html_url': 'https://github.com/owenn2106', 'followers_url': 'https://api.github.com/users/owenn2106/followers', 'following_url': 'https://api.github.com/users/owenn2106/following{/other_user}', 'gists_url': 'https://api.github.com/users/owenn2106/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/owenn2106/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/owenn2106/subscriptions', 'organizations_url': 'https://api.github.com/users/owenn2106/orgs', 'repos_url': 'https://api.github.com/users/owenn2106/repos', 'events_url': 'https://api.github.com/users/owenn2106/events{/privacy}', 'received_events_url': 'https://api.github.com/users/owenn2106/received_events', 'type': 'User', 'site_admin': False} | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This looks like you might be missing to update `react-dom` to the matching 18.3.1 as the error message suggests.",
"Yeah @owenn2106 did you update your `react-dom` version as well?",
"I have a similar error, but with `useState`:\r\n\r\n> TypeError: Cannot read properties of null (reading 'useState')\r\n\r\nI updated `react-dom` to `18.3.1`. I use Next.js version `14.2.3`.\r\n\r\nStack trace:\r\n```\r\nUncaught TypeError: Cannot read properties of null (reading 'useState')\r\n at useState (file://...\\node_modules\\react\\cjs\\react.development.js:1622:21)\r\n at App (file://...\\.next\\server\\chunks\\ssr\\[project]__3a561a._.js:7163:86)\r\n at renderWithHooks (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5658:16)\r\n at renderIndeterminateComponent (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5731:15)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5946:7)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderContextProvider (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5920:3)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6017:11)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderIndeterminateComponent (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5785:7)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5946:7)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderIndeterminateComponent (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5785:7)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5946:7)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderNode (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6259:12)\r\n at renderChildrenArray (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6211:7)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6141:7)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5971:9)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderNode (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6259:12)\r\n at renderChildrenArray (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6211:7)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6141:7)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5971:9)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderContextProvider (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5920:3)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6017:11)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderContextProvider (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5920:3)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6017:11)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderIndeterminateComponent (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5785:7)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5946:7)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderContextProvider (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5920:3)\r\n at renderElement (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6017:11)\r\n at renderNodeDestructiveImpl (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6104:11)\r\n at renderNodeDestructive (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:6076:14)\r\n at renderContextProvider (file://...\\node_modules\\react-dom\\cjs\\react-dom-server.browser.development.js:5920:3)\r\n```",
"@kassens @rickhanlonii Yeap, my react-dom is updated to `18.3.1` as well",
"Turns out we are having this issue because we have multiple copies of React. My team has a monorepo, which has a shared folder and these shared folder has a dependency of React 18. Package json looks like:\r\n```json\r\n \"peerDependencies\": {\r\n \"@types/react\": \"^17 || ^18\",\r\n \"react\": \"^17 || ^18\",\r\n \"react-dom\": \"^17 || ^18\"\r\n },\r\n```\r\n\r\nSo we had to just change the peer dependencies to `18.3` for it to work.\r\n```json\r\n \"peerDependencies\": {\r\n \"@types/react\": \"^17 || ^18.3.0\",\r\n \"react\": \"^17 || ^18.3.0\",\r\n \"react-dom\": \"^17 || ^18.3.0\"\r\n },\r\n ```",
"Since the error message already contains this as the first recommendation, I don't think there's more we can do, unfortunately :("
] | 2024-04-29 08:35:27 | 2024-04-30 13:52:41 | 2024-04-30 13:52:41 | NONE | null | null | null | I have upgraded to React `18.3.1`, previously from `18.2.0`. After upgrading, my app won't start. At first it's due to `useMemo` in `<PortalProvider />` which is a component from `blueprintjs`. When I open the file, it looks something like:
```js
import * as React from "react";
const PortalProvider = (...) => {
const data = React.useMemo(...)
}
```
From the error message, here I'm assuming `React` is null, but I'm not sure why. This was working fine before with `18.2.0`. I tried removing this `<PortalProvider />` component, but I get another error in `<Provider />` from `react-redux`, but this time instead of `useMemo`, it errors out with `useContext`. All I did was upgrade the React version nothing else. Am I missing something? I would like to upgrade to `18.3.1` to prepare for React 19.
React version: `18.3.1`
Blueprintjs version: `5.10.2`
Redux version: `4.2.1`
React-redux version `8.1.3`
My `src/index.tsx`:
```tsx
import { useEffect } from "react";
import {
createRoutesFromChildren,
matchRoutes,
useLocation,
useNavigationType,
} from "react-router-dom";
import { Classes, PortalProvider } from "@blueprintjs/core";
import { createRoot } from "react-dom/client";
import * as Sentry from "@sentry/react";
import "style/index.scss";
import Router from "./router";
import store from "redux/store";
import { Provider } from "react-redux";
import { APP_VERSION } from "utils/constants";
import * as serviceWorker from "./serviceWorker";
Sentry.init({
dsn: "...",
integrations: [
Sentry.reactRouterV6BrowserTracingIntegration({
useEffect: useEffect,
useLocation,
useNavigationType,
createRoutesFromChildren,
matchRoutes,
}),
Sentry.replayIntegration(),
],
enabled: process.env.NODE_ENV !== "development",
release: APP_VERSION.toString(),
// Set tracesSampleRate to 1.0 to capture 100%
// of transactions for performance monitoring.
// We recommend adjusting this value in production
tracesSampleRate: 1.0,
});
// <React.StrictMode> removed because of blueprint https://github.com/palantir/blueprint/issues/3979
const container = document.getElementById("root");
if (!container) throw new Error("Element with id 'root' not found.");
container.classList.add(Classes.DARK);
const root = createRoot(container);
root.render(
<PortalProvider portalClassName={Classes.DARK}>
<Provider store={store}>
<Router />
</Provider>
</PortalProvider>
);
// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
// Learn more about service workers: https://bit.ly/CRA-PWA
serviceWorker.unregister();
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28947/reactions', 'total_count': 5, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28947/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28946 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28946/labels{/name} | https://api.github.com/repos/facebook/react/issues/28946/comments | https://api.github.com/repos/facebook/react/issues/28946/events | https://github.com/facebook/react/issues/28946 | 2,268,244,498 | I_kwDOAJy2Ks6HMqoS | 28,946 | [React 19] React warns about "fetchpriority" props | {'login': 'ascorbic', 'id': 213306, 'node_id': 'MDQ6VXNlcjIxMzMwNg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/213306?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ascorbic', 'html_url': 'https://github.com/ascorbic', 'followers_url': 'https://api.github.com/users/ascorbic/followers', 'following_url': 'https://api.github.com/users/ascorbic/following{/other_user}', 'gists_url': 'https://api.github.com/users/ascorbic/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/ascorbic/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/ascorbic/subscriptions', 'organizations_url': 'https://api.github.com/users/ascorbic/orgs', 'repos_url': 'https://api.github.com/users/ascorbic/repos', 'events_url': 'https://api.github.com/users/ascorbic/events{/privacy}', 'received_events_url': 'https://api.github.com/users/ascorbic/received_events', 'type': 'User', 'site_admin': False} | [{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20DOM', 'name': 'Component: DOM', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [
"In the repro, the `fetchpriority` attribute is set for both cases. The warning targets different casings now. Is there some other behavior that changed?",
"Both should work correctly, with no warnings. `fetchpriority` works in 18.2.0. Adding support for `fetchPriority` shouldn't have broken the previously-supported casing, but seems to have done so.",
"With broken you mean the warning that changed or is there some other, end-user observable behavior that broke?",
"I mean the warning. It warns when previously it didn't complain. I think this would count as a breaking change. It renders fine in both cases, so the warning isn't needed.",
"It doesn't count as a breaking change, since we don't consider DEV warnings as breaking changes in our development policy: https://react.dev/community/versioning-policy#what-counts-as-a-breaking-change\r\n\r\nBut we should probably make this a deprecation warning instead of the current text since it implies it doesn't work. Something like:\r\n\r\n> Warning In React 19,`fetchpriority` has been renamed to `fetchPriority`. We will remove support `fetchpriority` in a future version. Please check the render method of `<Foo>`.\r\n\r\nWhat do you think @eps1lon?",
"_Are_ you planning to remove support? I'm not clear on the policy there: is the plan to only support DOM properties and not HTML attributes?",
"Mabye the \"invalid\" wording is a bit strong. We should just say it's renamed as @rickhanlonii suggests. But removing support would be a novel thing to do. We haven't done that for any other prop.",
"Is there any reason to not treat them as extra variants that are both supported (like Preact does), and not warn about either? One is the HTML attribute and the other is the DOM property and they both work.",
"It can get confusing with regards to object spreading and handling both casings. We'd have to add additional runtime logic to reconcile all casing variants. \r\n\r\nTypechecking would also have to support both casings and would no longer flag if you specify both properties.",
"I wish there was a way to feature-detect for it though. A warning is fine for end users, but those of us building libraries will need to support both. Granted, there probably aren't many libraries that need to set that particular prop (and with https://github.com/vercel/next.js/pull/65235 and https://github.com/ascorbic/unpic-img/pull/644 those are probably most covered), but checking for the existence of `use` isn't a great solution."
] | 2024-04-29 06:40:14 | 2024-05-02 06:23:22 | null | CONTRIBUTOR | null | null | null | ## Summary
In 18.2.0, React allowed the `fetchpriority` prop in all lower case, but did not accept camelized `fetchPriority`. Support for the camelized version was added in #25927, but it seems to have broken the lowercased version. This means there is no variant that works in both 18.2 and 18.3 canary/19 beta.
Repro: https://codesandbox.io/p/sandbox/nameless-bird-wvv84h
In 18.2.0 `fetchPriority` generates a warning but `fetchpriority` works without warning
In 18.3.0-canary and later, `fetchPriority` works but `fetchpriority` generates a warning. | {'url': 'https://api.github.com/repos/facebook/react/issues/28946/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28946/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28945 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28945/labels{/name} | https://api.github.com/repos/facebook/react/issues/28945/comments | https://api.github.com/repos/facebook/react/issues/28945/events | https://github.com/facebook/react/pull/28945 | 2,268,102,591 | PR_kwDOAJy2Ks5t9ph0 | 28,945 | pranav added a message | {'login': 'PranavBobade', 'id': 66084057, 'node_id': 'MDQ6VXNlcjY2MDg0MDU3', 'avatar_url': 'https://avatars.githubusercontent.com/u/66084057?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/PranavBobade', 'html_url': 'https://github.com/PranavBobade', 'followers_url': 'https://api.github.com/users/PranavBobade/followers', 'following_url': 'https://api.github.com/users/PranavBobade/following{/other_user}', 'gists_url': 'https://api.github.com/users/PranavBobade/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/PranavBobade/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/PranavBobade/subscriptions', 'organizations_url': 'https://api.github.com/users/PranavBobade/orgs', 'repos_url': 'https://api.github.com/users/PranavBobade/repos', 'events_url': 'https://api.github.com/users/PranavBobade/events{/privacy}', 'received_events_url': 'https://api.github.com/users/PranavBobade/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @PranavBobade! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328945). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 190cc990e01e5131a6b26f1a3212444cebd794e2...d640fcd7d56a5158193f7f5caddc01be4453e9c0\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/d640fcd7d56a5158193f7f5caddc01be4453e9c0/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/d640fcd7d56a5158193f7f5caddc01be4453e9c0/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/d640fcd7d56a5158193f7f5caddc01be4453e9c0/files/facebook-www/ReactDOM-prod.classic.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/d640fcd7d56a5158193f7f5caddc01be4453e9c0/files/facebook-www/ReactDOM-prod.modern.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d640fcd7d56a5158193f7f5caddc01be4453e9c0/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/d640fcd7d56a5158193f7f5caddc01be4453e9c0/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against d640fcd7d56a5158193f7f5caddc01be4453e9c0\n</p>\n",
"These Indians are so scummy dude, why they are polluting open source 🤢"
] | 2024-04-29 04:35:14 | 2024-04-30 02:54:30 | 2024-04-30 02:54:29 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28945', 'html_url': 'https://github.com/facebook/react/pull/28945', 'diff_url': 'https://github.com/facebook/react/pull/28945.diff', 'patch_url': 'https://github.com/facebook/react/pull/28945.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28945/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28945/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28944 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28944/labels{/name} | https://api.github.com/repos/facebook/react/issues/28944/comments | https://api.github.com/repos/facebook/react/issues/28944/events | https://github.com/facebook/react/pull/28944 | 2,268,050,587 | PR_kwDOAJy2Ks5t9eJL | 28,944 | chore: export cjs/umd as v17 | {'login': 'vctqs1', 'id': 30227910, 'node_id': 'MDQ6VXNlcjMwMjI3OTEw', 'avatar_url': 'https://avatars.githubusercontent.com/u/30227910?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vctqs1', 'html_url': 'https://github.com/vctqs1', 'followers_url': 'https://api.github.com/users/vctqs1/followers', 'following_url': 'https://api.github.com/users/vctqs1/following{/other_user}', 'gists_url': 'https://api.github.com/users/vctqs1/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/vctqs1/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/vctqs1/subscriptions', 'organizations_url': 'https://api.github.com/users/vctqs1/orgs', 'repos_url': 'https://api.github.com/users/vctqs1/repos', 'events_url': 'https://api.github.com/users/vctqs1/events{/privacy}', 'received_events_url': 'https://api.github.com/users/vctqs1/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4508873393058e86bed308b56e49ec883ece59d1...3fe5c4b8fb564dd1c1bb69af2206af218ce7efb3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/3fe5c4b8fb564dd1c1bb69af2206af218ce7efb3/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/3fe5c4b8fb564dd1c1bb69af2206af218ce7efb3/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/3fe5c4b8fb564dd1c1bb69af2206af218ce7efb3/files/facebook-www/ReactDOM-prod.classic.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/3fe5c4b8fb564dd1c1bb69af2206af218ce7efb3/files/facebook-www/ReactDOM-prod.modern.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/3fe5c4b8fb564dd1c1bb69af2206af218ce7efb3/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/3fe5c4b8fb564dd1c1bb69af2206af218ce7efb3/files/__test_utils__/ReactAllWarnings.js?compare=4508873393058e86bed308b56e49ec883ece59d1) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3fe5c4b8fb564dd1c1bb69af2206af218ce7efb3\n</p>\n"
] | 2024-04-29 03:31:29 | 2024-05-01 03:04:33 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28944', 'html_url': 'https://github.com/facebook/react/pull/28944', 'diff_url': 'https://github.com/facebook/react/pull/28944.diff', 'patch_url': 'https://github.com/facebook/react/pull/28944.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
Resolve: https://github.com/facebook/react/issues/28371
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28944/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28944/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28943 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28943/labels{/name} | https://api.github.com/repos/facebook/react/issues/28943/comments | https://api.github.com/repos/facebook/react/issues/28943/events | https://github.com/facebook/react/issues/28943 | 2,267,622,177 | I_kwDOAJy2Ks6HKSsh | 28,943 | Bug: Spurious warnings in react dev runtime about using "key" property in spread object | {'login': 'EricMCornelius', 'id': 748917, 'node_id': 'MDQ6VXNlcjc0ODkxNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/748917?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/EricMCornelius', 'html_url': 'https://github.com/EricMCornelius', 'followers_url': 'https://api.github.com/users/EricMCornelius/followers', 'following_url': 'https://api.github.com/users/EricMCornelius/following{/other_user}', 'gists_url': 'https://api.github.com/users/EricMCornelius/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/EricMCornelius/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/EricMCornelius/subscriptions', 'organizations_url': 'https://api.github.com/users/EricMCornelius/orgs', 'repos_url': 'https://api.github.com/users/EricMCornelius/repos', 'events_url': 'https://api.github.com/users/EricMCornelius/events{/privacy}', 'received_events_url': 'https://api.github.com/users/EricMCornelius/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-04-28 15:01:02 | 2024-04-29 05:41:07 | null | NONE | null | null | null | This warning: https://github.com/facebook/react/blame/190cc990e01e5131a6b26f1a3212444cebd794e2/packages/react/src/jsx/ReactJSXElement.js#L530
Is triggering any time a rest-spread operator passes a key in an array.
That means even intentional and valid situations like:
```javascript
import {createRoot} from 'react-dom/client';
const component_props = [{
key: 'my id',
style: {
color: 'red'
},
children: 'test'
}, {
key: 'my second id',
style: {
color: 'green'
},
children: 'test2'
}];
const ComponentArray = props => component_props.map(p => <div {...p}/>);
const root = document.getElementById('root');
const vdom = createRoot(root);
vdom.render(<ComponentArray/>);
```
Are generating a heap of warnings when running in dev mode.
I understand the intention to try to avoid unintentional overwriting of a separate supplied key, but is the intention honestly to say you can no longer supply keys externally whatsoever?
React version: 18.2.0
## Steps To Reproduce
Run the sample above.
## The current behavior
Generates the following warning in development mode:
```
react_jsx-dev-runtime.js:92 Warning: A props object containing a "key" prop is being spread into JSX:
let props = {key: someKey, style: ..., children: ...};
<div {...props} />
React keys must be passed directly to JSX without using spread:
let props = {style: ..., children: ...};
<div key={someKey} {...props} />
at ComponentArray
```
## The expected behavior
No warning should be generated - there is no other JSX key property being passed that might cause a collision here. | {'url': 'https://api.github.com/repos/facebook/react/issues/28943/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28943/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28942 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28942/labels{/name} | https://api.github.com/repos/facebook/react/issues/28942/comments | https://api.github.com/repos/facebook/react/issues/28942/events | https://github.com/facebook/react/pull/28942 | 2,267,330,774 | PR_kwDOAJy2Ks5t7GNm | 28,942 | [Fix] Simplify pendingState type in useActionState | {'login': 'yongsk0066', 'id': 46309806, 'node_id': 'MDQ6VXNlcjQ2MzA5ODA2', 'avatar_url': 'https://avatars.githubusercontent.com/u/46309806?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yongsk0066', 'html_url': 'https://github.com/yongsk0066', 'followers_url': 'https://api.github.com/users/yongsk0066/followers', 'following_url': 'https://api.github.com/users/yongsk0066/following{/other_user}', 'gists_url': 'https://api.github.com/users/yongsk0066/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yongsk0066/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yongsk0066/subscriptions', 'organizations_url': 'https://api.github.com/users/yongsk0066/orgs', 'repos_url': 'https://api.github.com/users/yongsk0066/repos', 'events_url': 'https://api.github.com/users/yongsk0066/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yongsk0066/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"Hi @yongsk0066! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328942). Thanks!",
"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 190cc990e01e5131a6b26f1a3212444cebd794e2...9da7559be4f33fdcdff6579cdc3b375da2bac5c6\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/9da7559be4f33fdcdff6579cdc3b375da2bac5c6/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/9da7559be4f33fdcdff6579cdc3b375da2bac5c6/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/9da7559be4f33fdcdff6579cdc3b375da2bac5c6/files/facebook-www/ReactDOM-prod.classic.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/9da7559be4f33fdcdff6579cdc3b375da2bac5c6/files/facebook-www/ReactDOM-prod.modern.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9da7559be4f33fdcdff6579cdc3b375da2bac5c6/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/9da7559be4f33fdcdff6579cdc3b375da2bac5c6/files/__test_utils__/ReactAllWarnings.js?compare=190cc990e01e5131a6b26f1a3212444cebd794e2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 9da7559be4f33fdcdff6579cdc3b375da2bac5c6\n</p>\n"
] | 2024-04-28 04:18:33 | 2024-04-29 09:41:32 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28942', 'html_url': 'https://github.com/facebook/react/pull/28942', 'diff_url': 'https://github.com/facebook/react/pull/28942.diff', 'patch_url': 'https://github.com/facebook/react/pull/28942.patch', 'merged_at': None} | ## Summary
This pull request simplifies the type definition of `pendingState` in the `useActionState` hook by changing it from `Thenable<boolean> | boolean` to just `boolean`.
The current implementation of `useActionState` defines the type of `pendingState` as `Thenable<boolean> | boolean.` However, upon closer inspection of the code, it appears that `pendingState` is always set to a boolean value, either directly or via the `setPendingState` function, which only accepts a boolean argument.
```ts
pendingStateHook = mountStateImpl((false: Thenable<boolean> | boolean));
const setPendingState: boolean => void = (dispatchOptimisticSetState.bind(
null,
currentlyRenderingFiber,
false,
((pendingStateHook.queue: any): UpdateQueue<
S | Awaited<S>,
S | Awaited<S>,
>),
): any);
```
In the `dispatchActionState` function, `setPendingState `is always called with a boolean value:
```ts
setPendingState(true);
```
Therefore, defining `pendingState` as `Thenable<boolean> | boolean` seems unnecessary, as it's never actually set to a thenable value. This pull request proposes to simplify the type to `boolean`, which more accurately reflects how `pendingState` is used in practice.
This change improves code clarity and maintainability by removing the potentially confusing `Thenable` type when it's not needed. It also aligns the type definition with the actual usage of `pendingState` throughout the `useActionState` implementation.
### Comparison with `useTransition`
While the code for pendingState in useActionState appears to have been developed with reference to the useTransition hook, it's important to note that these are two different cases that require different handling.
In useTransition, `isPending` can actually hold a thenable value, as evidenced by this code:
```ts
function updateTransition(): [
boolean,
(callback: () => void, options?: StartTransitionOptions) => void,
] {
const [booleanOrThenable] = updateState(false);
const hook = updateWorkInProgressHook();
const start = hook.memoizedState;
const isPending =
typeof booleanOrThenable === 'boolean'
? booleanOrThenable
: // This will suspend until the async action scope has finished.
useThenable(booleanOrThenable);
return [isPending, start];
}
```
Here, `booleanOrThenable` is the result of `updateState(false)`, and its type is `Thenable<boolean> | boolean`. The value of `isPending` depends on the type of `booleanOrThenable`:
- If `booleanOrThenable` is a boolean,`isPending` directly uses that value.
- If `booleanOrThenable` is a thenable object, `isPending` is assigned the result of processing the thenable with `useThenable`.
Therefore, in `useTransition`, the `Thenable<boolean> | boolean` type is appropriate for `isPending`, as it can hold a thenable value.
In contrast, `pendingState` in `useActionState` is always used as a boolean value, so we can simplify its type to `boolean`.
## How did you test this change?
To verify that this change doesn't introduce any regressions, I ran the existing test suite with `yarn test`. All tests passed without any issues, indicating that the updated type definition does not break any existing functionality. | {'url': 'https://api.github.com/repos/facebook/react/issues/28942/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28942/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28941 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28941/labels{/name} | https://api.github.com/repos/facebook/react/issues/28941/comments | https://api.github.com/repos/facebook/react/issues/28941/events | https://github.com/facebook/react/issues/28941 | 2,267,306,465 | I_kwDOAJy2Ks6HJFnh | 28,941 | Bug [React-DOM]: Missing "bun" export field in package.json | {'login': 'Guibi1', 'id': 36936511, 'node_id': 'MDQ6VXNlcjM2OTM2NTEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/36936511?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Guibi1', 'html_url': 'https://github.com/Guibi1', 'followers_url': 'https://api.github.com/users/Guibi1/followers', 'following_url': 'https://api.github.com/users/Guibi1/following{/other_user}', 'gists_url': 'https://api.github.com/users/Guibi1/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Guibi1/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Guibi1/subscriptions', 'organizations_url': 'https://api.github.com/users/Guibi1/orgs', 'repos_url': 'https://api.github.com/users/Guibi1/repos', 'events_url': 'https://api.github.com/users/Guibi1/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Guibi1/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The issue is fixed in react-dom v19, and taking a closer look they created new configuration files for bun:\r\nhttps://github.com/facebook/react/blob/main/packages/react-dom/package.json#L63\r\n\r\nI'm not sure how willing would be the team to merge my PR with your suggested fix for v18, but let's wish for the best 🤞:\r\nhttps://github.com/facebook/react/pull/28962",
"Oh nice I'll upgrade to `react-dom@next` then. I _would_ be useful to merge your PR, just for compatibility.",
"@Guibi1 for React 18 you can always just import the right version yourself if you know you are using bun. `import ... from \"react-dom/server.browser\"`\r\n\r\nI don't think we'll do another 18 release with this but React 19 should support it. If bun also supported running with custom conditions you could potentially customize the resolution that way but I don't think it supports that right now"
] | 2024-04-28 02:44:30 | 2024-05-01 20:50:18 | 2024-05-01 20:50:18 | NONE | null | null | null | In the exports field of the `react-dom`'s package.json, there is no "bun" field. Bun defaults to the "default" field for compatibility. However, the `./server.node.js` file doesn't export `renderToReadableStream()`, while Bun supports Web Streams out of the box.
See: [The Bun doc on Module resolution](https://bun.sh/docs/runtime/modules#importing-packages)
This issue is similar to #26906, but Bun always supported Web Streams so there is no backwards compatibility issues.
React version: 18.3.1
## Steps To Reproduce
1. Install `react-dom`.
2. Import `renderToReadableStream()`
3. Run the file using Bun
4. Notice that the error is something like this: `SyntaxError: Export named 'renderToReadableStream' not found in module '~/??/node_modules/react-dom/server.node.js'.`, which clearly shows that Bun uses the default export.
Link to code example:
I am not sure how to use Bun on the browser.
## The current behavior
Bun uses the default export. (aka server.node.js)
## The expected behavior
Bun uses a custom "bun" export. (aka server.browser.js)
I have tested the following change locally and it completely fixes this issue:
 | {'url': 'https://api.github.com/repos/facebook/react/issues/28941/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28941/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28940 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28940/labels{/name} | https://api.github.com/repos/facebook/react/issues/28940/comments | https://api.github.com/repos/facebook/react/issues/28940/events | https://github.com/facebook/react/pull/28940 | 2,267,162,928 | PR_kwDOAJy2Ks5t6kFt | 28,940 | feat(hyperlink): added a hyperlink to Node in README.md file | {'login': 'itzzjb', 'id': 95894819, 'node_id': 'U_kgDOBbc9Iw', 'avatar_url': 'https://avatars.githubusercontent.com/u/95894819?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/itzzjb', 'html_url': 'https://github.com/itzzjb', 'followers_url': 'https://api.github.com/users/itzzjb/followers', 'following_url': 'https://api.github.com/users/itzzjb/following{/other_user}', 'gists_url': 'https://api.github.com/users/itzzjb/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/itzzjb/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/itzzjb/subscriptions', 'organizations_url': 'https://api.github.com/users/itzzjb/orgs', 'repos_url': 'https://api.github.com/users/itzzjb/repos', 'events_url': 'https://api.github.com/users/itzzjb/events{/privacy}', 'received_events_url': 'https://api.github.com/users/itzzjb/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"Hi @itzzjb! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328940). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4ddff7355f696ec693c5ce2bda4e7707020c3510...384eb6cf254408de4df34657ccba49bab0ba4f92\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/384eb6cf254408de4df34657ccba49bab0ba4f92/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/384eb6cf254408de4df34657ccba49bab0ba4f92/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/384eb6cf254408de4df34657ccba49bab0ba4f92/files/facebook-www/ReactDOM-prod.classic.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/384eb6cf254408de4df34657ccba49bab0ba4f92/files/facebook-www/ReactDOM-prod.modern.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/384eb6cf254408de4df34657ccba49bab0ba4f92/files/__test_utils__/ReactAllWarnings.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/384eb6cf254408de4df34657ccba49bab0ba4f92/files/__test_utils__/ReactAllWarnings.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 384eb6cf254408de4df34657ccba49bab0ba4f92\n</p>\n",
"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!"
] | 2024-04-27 19:52:11 | 2024-04-28 02:36:52 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28940', 'html_url': 'https://github.com/facebook/react/pull/28940', 'diff_url': 'https://github.com/facebook/react/pull/28940.diff', 'patch_url': 'https://github.com/facebook/react/pull/28940.patch', 'merged_at': None} | As a fellow beginner to React, I didn't even know React runs on top of Node when I started.
So, some beginners might get confused about what is Node and how to find details about it or how to download it.
So, I thought to add a hyperlink to Node replacing the word Node in the README.md file. I think this might be a valuable contribution.
- Januda | {'url': 'https://api.github.com/repos/facebook/react/issues/28940/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28940/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28939 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28939/labels{/name} | https://api.github.com/repos/facebook/react/issues/28939/comments | https://api.github.com/repos/facebook/react/issues/28939/events | https://github.com/facebook/react/pull/28939 | 2,267,161,855 | PR_kwDOAJy2Ks5t6j4T | 28,939 | Import correct prod version of jsx-dev-runtime for react-server | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 8090457c77573f3916df136d582d5f44040da043...4055024078426ae8780c98fb5313a04f29418793\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=8090457c77573f3916df136d582d5f44040da043) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=8090457c77573f3916df136d582d5f44040da043) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/facebook-www/ReactDOM-prod.classic.js?compare=8090457c77573f3916df136d582d5f44040da043) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/facebook-www/ReactDOM-prod.modern.js?compare=8090457c77573f3916df136d582d5f44040da043) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/__test_utils__/ReactAllWarnings.js?compare=8090457c77573f3916df136d582d5f44040da043) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/oss-experimental/react/jsx-dev-runtime.react-server.js?compare=8090457c77573f3916df136d582d5f44040da043) | **=** | 0.25 kB | 0.24 kB | = | 0.16 kB | 0.16 kB\n| [oss-stable-semver/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/oss-stable-semver/react/jsx-dev-runtime.react-server.js?compare=8090457c77573f3916df136d582d5f44040da043) | **=** | 0.25 kB | 0.24 kB | = | 0.16 kB | 0.16 kB\n| [oss-stable/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/oss-stable/react/jsx-dev-runtime.react-server.js?compare=8090457c77573f3916df136d582d5f44040da043) | **=** | 0.25 kB | 0.24 kB | = | 0.16 kB | 0.16 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/4055024078426ae8780c98fb5313a04f29418793/files/__test_utils__/ReactAllWarnings.js?compare=8090457c77573f3916df136d582d5f44040da043) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 4055024078426ae8780c98fb5313a04f29418793\n</p>\n"
] | 2024-04-27 19:48:46 | 2024-04-27 20:25:28 | 2024-04-27 20:25:26 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28939', 'html_url': 'https://github.com/facebook/react/pull/28939', 'diff_url': 'https://github.com/facebook/react/pull/28939.diff', 'patch_url': 'https://github.com/facebook/react/pull/28939.patch', 'merged_at': datetime.datetime(2024, 4, 27, 20, 25, 26)} | Follow-up to https://github.com/facebook/react/pull/28921/ | {'url': 'https://api.github.com/repos/facebook/react/issues/28939/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28939/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28938 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28938/labels{/name} | https://api.github.com/repos/facebook/react/issues/28938/comments | https://api.github.com/repos/facebook/react/issues/28938/events | https://github.com/facebook/react/issues/28938 | 2,267,070,212 | I_kwDOAJy2Ks6HIL8E | 28,938 | [React 19] Support scoped custom element registries (i.e, react with Custom Elements being rendered in a shadow root) | {'login': 'michaelwarren1106', 'id': 8377369, 'node_id': 'MDQ6VXNlcjgzNzczNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8377369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/michaelwarren1106', 'html_url': 'https://github.com/michaelwarren1106', 'followers_url': 'https://api.github.com/users/michaelwarren1106/followers', 'following_url': 'https://api.github.com/users/michaelwarren1106/following{/other_user}', 'gists_url': 'https://api.github.com/users/michaelwarren1106/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/michaelwarren1106/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/michaelwarren1106/subscriptions', 'organizations_url': 'https://api.github.com/users/michaelwarren1106/orgs', 'repos_url': 'https://api.github.com/users/michaelwarren1106/repos', 'events_url': 'https://api.github.com/users/michaelwarren1106/events{/privacy}', 'received_events_url': 'https://api.github.com/users/michaelwarren1106/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [
"Correct me if I'm wrong, but your current suggestion wouldn't fully handle all cases. The main assumption you've made is that React's root is created inside the shadow-root, which is not always desirable. More often than not, I want a single React root, so that I can share context between shadow-roots.\n\nOne way to fix this would be by treating `createPortal()` similarly to `createRoot()` and `hydrateRoot()`. In all cases, React should automatically use `getRootNode(el).createElement()`.\n\nThis should probably be done before React 19 ships as stable, otherwise we might have to wait several years because of behavioral differences/risks with making this change in a minor release."
] | 2024-04-27 15:49:45 | 2024-05-03 12:28:49 | null | NONE | null | null | null | ## Summary
**This is not an issue, but a (hopefully small) feature request/enhancement to the Custom Element support coming in React 19.**
The Custom Element support in React 19 is awesome! But even once React 19 lands, there will still be one challenge that Custom Element component library maintainers face. There is no way to inform React to use a scoped custom element registry when creating elements.
### Scoped Custom Element Registries
[Proppsal](https://github.com/WICG/webcomponents/blob/gh-pages/proposals/Scoped-Custom-Element-Registries.md)
The above proposal implements a new `CustomElementRegistry()` api where Custom Element authors can register custom elements to a registry that is not the global registry. An implementation of scoped custom element registries is in [Chrome Canary](https://chromestatus.com/feature/5090435261792256) under a flag at the moment, and the Web Components Community Group is working to see them implemented in all browsers.
There are also several polyfills that add this behavior to browsers in the meantime. Here is the one I use:
[Polyfill](https://github.com/webcomponents/polyfills/tree/master/packages/scoped-custom-element-registry)
### Use case: Micro-frontend application
Micro-frontend application architectures are very common. This pattern is where a host application will use module federation (webpack, vite etc) to dynamically fetch JS modules containing separate "remote applications" that the host app then assembles into a single seamless application for the user. The architecture is popular because it enables autonomy of releases between remote applications.
For Custom Elements though, the problem is that with only the single global Custom Element registry in browsers, remotes can't scope their Custom Elements efectively and so there can be version conflicts when remote applications depend on different version of the same custom element. Whichever version gets registered first "wins" and the other remotes break.
Scoped element registries solve this. If a remote application is rendered inside a shadow root (custom element, or just a div with an attached shadow root) then all Custom Element definitions in that remote can be pulled from a scoped registry instead of the global one. Bye bye version conflicts! Every remote gets its own version of the Custom Elements it uses.
### Feature Request
If the remote application uses a framework like React where `document.createElement` is used. In order to create a scoped Custom Element using the scoped definition in the custom registry, `shadowRoot.createElement()` is the mechanism.
React (and other frameworks also) have no way to be informed that they are being rendered inside a shadow root with a scoped registry attached. And therefore have no mechanism to switch from `document.createElement` to `shadowRoot.createElement`. React can already render inside a shadow root just fine. React's root can be an element inside a shadow root with no issues. This feature is about detecting whether or not React's render root has a parent element that is a shadow root and switching to `shadowRoot.createElement()` accordingly.
I hope this is enough detail to describe the ask. I would think that this might not be a huge feature or change to existing React fundamentals, but I'm not an expert on what the exact implementation approach should be. I'm just familiar with the current problem landscape and our workarounds that we use to get around it being cumbersome.
[This comment](https://github.com/WICG/webcomponents/issues/1043#issuecomment-1883480452) in a thread about the topic has a rough idea of what the implementation might look like.
I would think that with an implementation similar to the above, `document.createElement()` would be used in applications where there aren't any scoped element registry polyfills, or where the feature hasn't yet landed natively in browsers, so there may be low risk to a check for "is the root node in a shadow root".
| {'url': 'https://api.github.com/repos/facebook/react/issues/28938/reactions', 'total_count': 11, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 5, 'rocket': 3, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/28938/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28937 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28937/labels{/name} | https://api.github.com/repos/facebook/react/issues/28937/comments | https://api.github.com/repos/facebook/react/issues/28937/events | https://github.com/facebook/react/pull/28937 | 2,267,055,459 | PR_kwDOAJy2Ks5t6OL6 | 28,937 | Fixed it: Update CODE_OF_CONDUCT.md | {'login': 'bimsonz', 'id': 6716652, 'node_id': 'MDQ6VXNlcjY3MTY2NTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6716652?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bimsonz', 'html_url': 'https://github.com/bimsonz', 'followers_url': 'https://api.github.com/users/bimsonz/followers', 'following_url': 'https://api.github.com/users/bimsonz/following{/other_user}', 'gists_url': 'https://api.github.com/users/bimsonz/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/bimsonz/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/bimsonz/subscriptions', 'organizations_url': 'https://api.github.com/users/bimsonz/orgs', 'repos_url': 'https://api.github.com/users/bimsonz/repos', 'events_url': 'https://api.github.com/users/bimsonz/events{/privacy}', 'received_events_url': 'https://api.github.com/users/bimsonz/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @bimsonz! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328937). Thanks!",
"All great rules to live your life by\r\n\r\nAlso did you just _steal_ this idea from sqlite?",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4ddff7355f696ec693c5ce2bda4e7707020c3510...2e449e0cf9667d6cb71d714727c2b93cd62e81d5\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/2e449e0cf9667d6cb71d714727c2b93cd62e81d5/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/2e449e0cf9667d6cb71d714727c2b93cd62e81d5/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/2e449e0cf9667d6cb71d714727c2b93cd62e81d5/files/facebook-www/ReactDOM-prod.classic.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/2e449e0cf9667d6cb71d714727c2b93cd62e81d5/files/facebook-www/ReactDOM-prod.modern.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2e449e0cf9667d6cb71d714727c2b93cd62e81d5/files/__test_utils__/ReactAllWarnings.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/2e449e0cf9667d6cb71d714727c2b93cd62e81d5/files/__test_utils__/ReactAllWarnings.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 2e449e0cf9667d6cb71d714727c2b93cd62e81d5\n</p>\n",
"@ThePrimeagen fixed it",
"Cute but you'd need to upstream this to the contributor covenant since we use that"
] | 2024-04-27 15:09:09 | 2024-04-27 15:52:54 | 2024-04-27 15:52:54 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28937', 'html_url': 'https://github.com/facebook/react/pull/28937', 'diff_url': 'https://github.com/facebook/react/pull/28937.diff', 'patch_url': 'https://github.com/facebook/react/pull/28937.patch', 'merged_at': None} | Blame @ThePrimeagen
| {'url': 'https://api.github.com/repos/facebook/react/issues/28937/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28937/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28936 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28936/labels{/name} | https://api.github.com/repos/facebook/react/issues/28936/comments | https://api.github.com/repos/facebook/react/issues/28936/events | https://github.com/facebook/react/pull/28936 | 2,267,052,318 | PR_kwDOAJy2Ks5t6NlC | 28,936 | feat(badge): Add JSDelivr badge | {'login': 'Zaid-maker', 'id': 53424436, 'node_id': 'MDQ6VXNlcjUzNDI0NDM2', 'avatar_url': 'https://avatars.githubusercontent.com/u/53424436?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Zaid-maker', 'html_url': 'https://github.com/Zaid-maker', 'followers_url': 'https://api.github.com/users/Zaid-maker/followers', 'following_url': 'https://api.github.com/users/Zaid-maker/following{/other_user}', 'gists_url': 'https://api.github.com/users/Zaid-maker/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Zaid-maker/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Zaid-maker/subscriptions', 'organizations_url': 'https://api.github.com/users/Zaid-maker/orgs', 'repos_url': 'https://api.github.com/users/Zaid-maker/repos', 'events_url': 'https://api.github.com/users/Zaid-maker/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Zaid-maker/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: d779eba4b375134f373b7dfb9ea98d01c84bc48e...f8cc2e067e0154334fcd7dc7ac2b008de92ce35a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/f8cc2e067e0154334fcd7dc7ac2b008de92ce35a/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/f8cc2e067e0154334fcd7dc7ac2b008de92ce35a/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/f8cc2e067e0154334fcd7dc7ac2b008de92ce35a/files/facebook-www/ReactDOM-prod.classic.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/f8cc2e067e0154334fcd7dc7ac2b008de92ce35a/files/facebook-www/ReactDOM-prod.modern.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f8cc2e067e0154334fcd7dc7ac2b008de92ce35a/files/__test_utils__/ReactAllWarnings.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f8cc2e067e0154334fcd7dc7ac2b008de92ce35a/files/__test_utils__/ReactAllWarnings.js?compare=d779eba4b375134f373b7dfb9ea98d01c84bc48e) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against f8cc2e067e0154334fcd7dc7ac2b008de92ce35a\n</p>\n",
"Please merge this ",
"Thanks but we're not accepting new badges."
] | 2024-04-27 15:00:55 | 2024-05-01 16:09:53 | 2024-05-01 15:42:40 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28936', 'html_url': 'https://github.com/facebook/react/pull/28936', 'diff_url': 'https://github.com/facebook/react/pull/28936.diff', 'patch_url': 'https://github.com/facebook/react/pull/28936.patch', 'merged_at': None} | ## Summary
Adds a Jsdelivr badge which shows how much downloads React has in Month through [jsdelivr](https://www.jsdelivr.com/package/npm/react) CDN
| {'url': 'https://api.github.com/repos/facebook/react/issues/28936/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28936/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28935 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28935/labels{/name} | https://api.github.com/repos/facebook/react/issues/28935/comments | https://api.github.com/repos/facebook/react/issues/28935/events | https://github.com/facebook/react/issues/28935 | 2,267,023,515 | I_kwDOAJy2Ks6HIAib | 28,935 | [React 19] Eslint React JSDoc support | {'login': 'eduardocque', 'id': 35545218, 'node_id': 'MDQ6VXNlcjM1NTQ1MjE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/35545218?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eduardocque', 'html_url': 'https://github.com/eduardocque', 'followers_url': 'https://api.github.com/users/eduardocque/followers', 'following_url': 'https://api.github.com/users/eduardocque/following{/other_user}', 'gists_url': 'https://api.github.com/users/eduardocque/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eduardocque/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eduardocque/subscriptions', 'organizations_url': 'https://api.github.com/users/eduardocque/orgs', 'repos_url': 'https://api.github.com/users/eduardocque/repos', 'events_url': 'https://api.github.com/users/eduardocque/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eduardocque/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"Unfortunately, type checking is a very complex task and out of the capabilities that a eslint plugin can provide (you need to look across files to start, which as far as I know isn't supported by ESLint).\r\n\r\nFor static type checking TypeScript (and Flow) are the supported ways."
] | 2024-04-27 13:44:55 | 2024-04-29 14:19:08 | 2024-04-29 14:19:07 | NONE | null | null | null | ## Summary
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
based on react 19 documentation `prop-types` is gone, so for JS users the only way to manage it is using JSDoc, can be possible to support jsdoc prop-type validation in eslint-plugin-react ?
Example
```js
/**
* @param {{
* content?: string,
* requiredParameter: string // required parameter if not can be with "?"
* }} props
* @returns {React.ReactElement}
*/
const ChildElement = props => {
const { content = '' } = props;
return <div>{content}</div>;
};
/** @returns {React.ReactElement} */
const ParentElement = () => {
return <ChildElement content="Hello World" wrongParameter="test" />;
};
```
in this example
* wrongParameter should be marked as error due that is not in ChildElement JSDocs
* whole component should mark an error due that requiredParameter that exists in the JSDoc is not defined from the parent element
the intention of this request if to give some ways in javascrit to work without involve typescript to maange types and props | {'url': 'https://api.github.com/repos/facebook/react/issues/28935/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28935/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28934 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28934/labels{/name} | https://api.github.com/repos/facebook/react/issues/28934/comments | https://api.github.com/repos/facebook/react/issues/28934/events | https://github.com/facebook/react/pull/28934 | 2,266,856,463 | PR_kwDOAJy2Ks5t5o0s | 28,934 | fix(hydrateRoot): to check and add validations for type check of arguments in hydrateRoot while development | {'login': 'Shubhdeep12', 'id': 43654389, 'node_id': 'MDQ6VXNlcjQzNjU0Mzg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/43654389?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Shubhdeep12', 'html_url': 'https://github.com/Shubhdeep12', 'followers_url': 'https://api.github.com/users/Shubhdeep12/followers', 'following_url': 'https://api.github.com/users/Shubhdeep12/following{/other_user}', 'gists_url': 'https://api.github.com/users/Shubhdeep12/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Shubhdeep12/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Shubhdeep12/subscriptions', 'organizations_url': 'https://api.github.com/users/Shubhdeep12/orgs', 'repos_url': 'https://api.github.com/users/Shubhdeep12/repos', 'events_url': 'https://api.github.com/users/Shubhdeep12/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Shubhdeep12/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4ddff7355f696ec693c5ce2bda4e7707020c3510...1700b455d116dc8b298851d8acae13913dccb905\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/1700b455d116dc8b298851d8acae13913dccb905/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/1700b455d116dc8b298851d8acae13913dccb905/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/1700b455d116dc8b298851d8acae13913dccb905/files/facebook-www/ReactDOM-prod.classic.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/1700b455d116dc8b298851d8acae13913dccb905/files/facebook-www/ReactDOM-prod.modern.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/1700b455d116dc8b298851d8acae13913dccb905/files/__test_utils__/ReactAllWarnings.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/1700b455d116dc8b298851d8acae13913dccb905/files/__test_utils__/ReactAllWarnings.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 1700b455d116dc8b298851d8acae13913dccb905\n</p>\n"
] | 2024-04-27 05:54:33 | 2024-04-27 05:59:41 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28934', 'html_url': 'https://github.com/facebook/react/pull/28934', 'diff_url': 'https://github.com/facebook/react/pull/28934.diff', 'patch_url': 'https://github.com/facebook/react/pull/28934.patch', 'merged_at': None} |
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
fixes: #28792
Added a validation and type check for arguments of hydrateRoot
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28934/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28934/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28933 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28933/labels{/name} | https://api.github.com/repos/facebook/react/issues/28933/comments | https://api.github.com/repos/facebook/react/issues/28933/events | https://github.com/facebook/react/issues/28933 | 2,266,446,889 | I_kwDOAJy2Ks6HFzwp | 28,933 | [React 19] | {'login': '1372594487', 'id': 66430889, 'node_id': 'MDQ6VXNlcjY2NDMwODg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/66430889?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/1372594487', 'html_url': 'https://github.com/1372594487', 'followers_url': 'https://api.github.com/users/1372594487/followers', 'following_url': 'https://api.github.com/users/1372594487/following{/other_user}', 'gists_url': 'https://api.github.com/users/1372594487/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/1372594487/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/1372594487/subscriptions', 'organizations_url': 'https://api.github.com/users/1372594487/orgs', 'repos_url': 'https://api.github.com/users/1372594487/repos', 'events_url': 'https://api.github.com/users/1372594487/events{/privacy}', 'received_events_url': 'https://api.github.com/users/1372594487/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"build"
] | 2024-04-26 20:18:05 | 2024-04-26 20:31:05 | 2024-04-26 20:31:05 | NONE | null | null | null | ## Summary
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28933/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28933/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28932 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28932/labels{/name} | https://api.github.com/repos/facebook/react/issues/28932/comments | https://api.github.com/repos/facebook/react/issues/28932/events | https://github.com/facebook/react/pull/28932 | 2,266,417,763 | PR_kwDOAJy2Ks5t4IFs | 28,932 | Add changelog for 18.3.1 | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 95e610da13e50c2cb92e003dd7dbfa4a8262bdd2...feb7e7980b825fb54ba5cdf11a2b4cc7aad50bb3\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/feb7e7980b825fb54ba5cdf11a2b4cc7aad50bb3/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/feb7e7980b825fb54ba5cdf11a2b4cc7aad50bb3/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/feb7e7980b825fb54ba5cdf11a2b4cc7aad50bb3/files/facebook-www/ReactDOM-prod.classic.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/feb7e7980b825fb54ba5cdf11a2b4cc7aad50bb3/files/facebook-www/ReactDOM-prod.modern.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/feb7e7980b825fb54ba5cdf11a2b4cc7aad50bb3/files/__test_utils__/ReactAllWarnings.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/feb7e7980b825fb54ba5cdf11a2b4cc7aad50bb3/files/__test_utils__/ReactAllWarnings.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against feb7e7980b825fb54ba5cdf11a2b4cc7aad50bb3\n</p>\n"
] | 2024-04-26 19:52:45 | 2024-04-26 20:03:57 | 2024-04-26 20:03:03 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28932', 'html_url': 'https://github.com/facebook/react/pull/28932', 'diff_url': 'https://github.com/facebook/react/pull/28932.diff', 'patch_url': 'https://github.com/facebook/react/pull/28932.patch', 'merged_at': datetime.datetime(2024, 4, 26, 20, 3, 3)} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/28932/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28932/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28931 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28931/labels{/name} | https://api.github.com/repos/facebook/react/issues/28931/comments | https://api.github.com/repos/facebook/react/issues/28931/events | https://github.com/facebook/react/issues/28931 | 2,266,304,064 | I_kwDOAJy2Ks6HFQ5A | 28,931 | E-Commerce | {'login': 'donnadonwhite', 'id': 128304336, 'node_id': 'U_kgDOB6XE0A', 'avatar_url': 'https://avatars.githubusercontent.com/u/128304336?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/donnadonwhite', 'html_url': 'https://github.com/donnadonwhite', 'followers_url': 'https://api.github.com/users/donnadonwhite/followers', 'following_url': 'https://api.github.com/users/donnadonwhite/following{/other_user}', 'gists_url': 'https://api.github.com/users/donnadonwhite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/donnadonwhite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/donnadonwhite/subscriptions', 'organizations_url': 'https://api.github.com/users/donnadonwhite/orgs', 'repos_url': 'https://api.github.com/users/donnadonwhite/repos', 'events_url': 'https://api.github.com/users/donnadonwhite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/donnadonwhite/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"what the"
] | 2024-04-26 18:29:47 | 2024-04-26 19:26:53 | 2024-04-26 19:26:53 | NONE | null | null | null | 1) Unique features of e-commerce are ubiquity, customization, interactivity, and global reaching [how plagiarism checker work](https://plagiarismsearch.com/how-plagiarism-checker-work.html). Other features include social technology, personalization, universal standards, information density, and richness. All these aspects have contributed to the modern marketing and selling approaches that help identify and influence target audiences with the purpose of selling them products and services.
2) The first problem is easy access to content and infrastructure. The second one is the lack of regulation in security, privacy, and consumer rights protection. Intellectual property rights and international trade regulation are important issues due to the global nature of e-commerce.
3) An elevator pitch is a presentation that lasts for not more than three minutes, during which an entrepreneur has to convince investors to invest their money in one’s business. The key elements are an introduction, the background of the idea, market opportunity, revenue metrics, funding, and exit strategy.
4) Business model disruption has four stages. The first one implies that the disruption creates new products, usually of low quality and price, but disruptors also look for new financial resources for business. During the second stage, the products, that have been created during the first one, are improved to become valuable and attract customers from the incumbents’ market. The business process of selling a new product becomes important during the third stage. The ending, or the fourth stage, comes when incumbents lose a market share or move to another market. Thus, finding new customers is another option for incumbents to survive.
5) Web page data is located on the host’s Web server, but in order to be delivered to the Internet, it has to move through the host company’s network. The next process is data distribution from the ISP’s network to smaller ones. Then, the ISP that serves my network, receives data. Finally, the access point allows the Web page data to be downloaded directly and wirelessly to my tablet.
6) The World Wide Web was born in 1989 thanks to Berners-Lee. He was the creator of HTML language and he gave the Internet to civilians. Andreessen created a Mosaic web browser with simple graphics and a user interface. The first commercial browser appeared in 1994, a year after the era of the commercial civilian Internet had begun.
7) The Internet and the Web have offered easy and convenient access to the product, information, and feedback about it. In other words, they created the concept of online shopping. The numerous features of the Internet support e-commerce. These are text, voice, and video communication tools, search engines, streaming media, and social networks. The first three features have improved communication between customers and businesses, while search engine provides information and feedback that help customers decide what to buy. Finally, streaming and social media is a convenient platform for advertising and marketing.
8) The process of developing an e-commerce presence for a typical start-up Web site over a one-year period implies such phases, activities, and milestones. The first phase is planning, and it includes such important activities as foreseeing e-commerce presence and staff employment, while the milestone is a mission statement. The second phase is the website development stage, filled with such activities as designing a website, gathering content, and finding a hosting; the milestone here is a website plan. The third phase is called web implementation, so its activities presuppose the development of keywords, search engine optimization, and searching for possible sponsors, while a well-developed functioning website is a milestone. The next phase is creating a media plan, but to design it, the project needs such activities as the recognition of appropriate social media platforms and the production of content that suits them; consequently, a milestone here is a social media plan. Social media implementation is the fifth phase, during which the project has to develop its presence on the most popular social networks. Therefore, a milestone for this phase implies a properly working social media presence. The activities of a mobile plan, which is the sixth phase, include developing this plan and examining a website for smartphones. Consequently, a mobile media plan is a milestone for this phase.
9) E-commerce merchant server software provides online catalogs, shopping carts, and online credit cards. Their aim is to make online shopping easy and enjoyable. The functionalities are the adherence to business and technological standards, multicultural capability, the ability to connect to the existing business model, and an advanced reporting system.
10) An e-commerce business will be successful if its design has eight factors. Informational factor helps users find more information about products. The navigation and work with the website must be easy. Additional navigation also is a vital factor for e-commerce success so that customers can scroll a website according to their preference in techniques. The process of making a purchase must be easy, and the site should be available from different browsers. The seventh factor is graphics since the customer should have the option to control the sounds and visual animation if they disrupt one’s buying experience. Finally, legible text helps in achieving success for e-commerce business since customers must be able to read clearly from the site.
11) The Internet of Things (IoT) is the technology that connects any device that has sensors to the Internet. The IoT is applicable to any devices nowadays, from cars or houses to clothes, watches, and so on. The first security issue of the IoT is its interoperability. Others are security and privacy since the devices are personalized but vulnerable to patches.
12) Secure Sockets Layer/Transport Layer Security is the protocol for data encryption, and server and client authentication that allows users to identify a server and securely connect to it. A secure negotiated session is a client-server session that contains encrypted information such as content, the content of forms, the URL of needed documents, and cookies. During this session, the system uses the session key. A session key is a one-time-used encryption that allows a new device to apply for a secure session. VPN enables remote users to access internal networks securely via the Internet, using authentication and encryption.
13) The term Big Data describes data sets that have been received from various sources. Its amount is so big that no technology can store and analyze it in time. Marketers want to receive relevant feedback from the audience about their purchasing behavior or products. This data would help in fixing the business process immediately and improve issues in marketing products and services.
14) The Internet made companies and customers closer since they directly interact online, which allows them to discuss their preferences, feedback, and needs. Therefore, the first three main impacts of the Internet on marketing are personalization, participative marketing, and improved peer-to-peer communication between companies and buyers. The fourth impact is a communal one.
15) CRM is a storage of all interactions between a client and a firm. Its functions are being familiar with a customer profile, storing information about contacts, and making contacts and a profile available for all employees of the firm.
16) Location-based mobile marketing uses personal navigation, reviews of visited places, finder of friends in the crowd, and tracker services to find children or points of interest.
17) Marketers like local mobile marketing since companies can interact with the domestic target market. The local population is interested in purchasing products from local companies. Therefore, market players want to use this opportunity.
18) The five-step process includes an accurate description of facts, a determination of the conflict and involved values, and the definition of stakeholders. The last two processes are finding the options to take and identifying possible consequences. The best principle is to imagine oneself in someone else’s place since this helps evaluate the fairness of a decision. Applying the collective utilitarian principle is another option, and the action in this situation is taken to benefit more people.
19) The purpose of intellectual property law is to provide a balance between the public interest of the distribution of intellectual property and the private interest of creators to save a monopoly for tangible and intangible products, generated in the human mind. Types of intellectual property protection are trademark law, patent, and copyright.
20) Online retailers face difficulties since the pioneers of this industry dealt with a small number of users and the shipping price for large-sized items was high. They also charged low prices for their products and services, but they did not work on a business strategy. After 2015, when customers started to prefer online shopping to offline and fees decreased, the earnings started to grow constantly and surpass the profits of offline market competitors. Online retailers understood that consumers valued convenience more than rice.
21) Online career services are so well suited to the Web as they have reduced total hiring time and provided efficient services for an employer and a candidate. Thus, online career services can pre-screen a person before an interview, which will allow them to avoid a meeting with unqualified candidates since such situations often arise in internal referral programs.
22) The three basic revenue models for digital content delivery are subscription, a la carte subscription, and advertising-supported. In the subscription model, a customer receives all content from the resource they have chosen. A la carte subscription is a form of subscription, but the user pays for the content they use. Advertising-supported revenue model provides content for free, but the company receives revenue from advertising. Such a model means that the quality of content is low, but it is still entertaining.
23) Pure digital news sites do not spend money for printing their content on paper, and they can easily convert to more efficient business processes. Such sites offer user-generated content and employ innovation to generate news quickly. Traditional print newspapers have quality journalism, they are reliable, and they spread accurate information.
24) Social networks are used as a marketing tool, advertisement, and branding resource. Communication between a customer and companies has become direct since every user can post feedback about the product and a firm can see it and respond. Businesses care about their online reputation as they check comments from consumers all the time. Therefore, they are afraid of public pressure in case of a failure to meet customers’ needs or to improve products and services.
25) Online auctions have four major types. The English auction implies that a seller sells a single item, the process has a time limit, and multiple buyers participate in bidding. The Dutch auction helps sell numerous identical items. During the Name Your Own Price auction, buyers tell the price and sellers bid. Usually, such auctions sell vacation packages, airline tickets, or hotel reservations. Finally, penny auction is an event, where participants pay for bidding on the site beforehand, and the fee varies from 50 cents to a dollar. The main difference between this and other auction types that even if a participant does not purchase anything, they still pay for participation and bidding.
| {'url': 'https://api.github.com/repos/facebook/react/issues/28931/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28931/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28930 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28930/labels{/name} | https://api.github.com/repos/facebook/react/issues/28930/comments | https://api.github.com/repos/facebook/react/issues/28930/events | https://github.com/facebook/react/pull/28930 | 2,266,267,409 | PR_kwDOAJy2Ks5t3m-0 | 28,930 | Configure JSX Feature Flags as Dynamic (React Native @ Meta) | {'login': 'yungsters', 'id': 55161, 'node_id': 'MDQ6VXNlcjU1MTYx', 'avatar_url': 'https://avatars.githubusercontent.com/u/55161?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yungsters', 'html_url': 'https://github.com/yungsters', 'followers_url': 'https://api.github.com/users/yungsters/followers', 'following_url': 'https://api.github.com/users/yungsters/following{/other_user}', 'gists_url': 'https://api.github.com/users/yungsters/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/yungsters/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/yungsters/subscriptions', 'organizations_url': 'https://api.github.com/users/yungsters/orgs', 'repos_url': 'https://api.github.com/users/yungsters/repos', 'events_url': 'https://api.github.com/users/yungsters/events{/privacy}', 'received_events_url': 'https://api.github.com/users/yungsters/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 95e610da13e50c2cb92e003dd7dbfa4a8262bdd2...f69bd7c28c8f699fffd2a946ec6114ad0c753c4f\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-www/ReactDOM-prod.classic.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-www/ReactDOM-prod.modern.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [facebook-react-native/react/cjs/JSXRuntime-prod.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/JSXRuntime-prod.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+31.32%** | 2.98 kB | 3.92 kB | +13.64% | 1.27 kB | 1.44 kB\n| [facebook-react-native/react/cjs/JSXRuntime-profiling.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/JSXRuntime-profiling.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+31.32%** | 2.98 kB | 3.92 kB | +13.64% | 1.27 kB | 1.44 kB\n| [facebook-react-native/react/cjs/JSXDEVRuntime-dev.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/JSXDEVRuntime-dev.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+8.22%** | 48.52 kB | 52.51 kB | +7.19% | 13.82 kB | 14.81 kB\n| [facebook-react-native/react/cjs/JSXRuntime-dev.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/JSXRuntime-dev.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+8.01%** | 49.75 kB | 53.74 kB | +6.97% | 14.18 kB | 15.17 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/React-prod.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+7.48%** | 21.88 kB | 23.52 kB | +4.80% | 5.74 kB | 6.01 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/React-profiling.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+7.34%** | 22.32 kB | 23.95 kB | +4.71% | 5.81 kB | 6.09 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/React-dev.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+4.00%** | 113.13 kB | 117.66 kB | +3.37% | 29.43 kB | 30.42 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/__test_utils__/ReactAllWarnings.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-react-native/react/cjs/JSXRuntime-prod.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/JSXRuntime-prod.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+31.32%** | 2.98 kB | 3.92 kB | +13.64% | 1.27 kB | 1.44 kB\n| [facebook-react-native/react/cjs/JSXRuntime-profiling.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/JSXRuntime-profiling.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+31.32%** | 2.98 kB | 3.92 kB | +13.64% | 1.27 kB | 1.44 kB\n| [facebook-react-native/react/cjs/JSXDEVRuntime-dev.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/JSXDEVRuntime-dev.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+8.22%** | 48.52 kB | 52.51 kB | +7.19% | 13.82 kB | 14.81 kB\n| [facebook-react-native/react/cjs/JSXRuntime-dev.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/JSXRuntime-dev.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+8.01%** | 49.75 kB | 53.74 kB | +6.97% | 14.18 kB | 15.17 kB\n| [facebook-react-native/react/cjs/React-prod.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/React-prod.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+7.48%** | 21.88 kB | 23.52 kB | +4.80% | 5.74 kB | 6.01 kB\n| [facebook-react-native/react/cjs/React-profiling.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/React-profiling.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+7.34%** | 22.32 kB | 23.95 kB | +4.71% | 5.81 kB | 6.09 kB\n| [facebook-react-native/react/cjs/React-dev.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/facebook-react-native/react/cjs/React-dev.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+4.00%** | 113.13 kB | 117.66 kB | +3.37% | 29.43 kB | 30.42 kB\n| [react-native/implementations/ReactFabric-prod.fb.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/react-native/implementations/ReactFabric-prod.fb.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+0.36%** | 366.41 kB | 367.72 kB | +0.56% | 64.05 kB | 64.41 kB\n| [react-native/implementations/ReactNativeRenderer-prod.fb.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/react-native/implementations/ReactNativeRenderer-prod.fb.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+0.35%** | 373.83 kB | 375.14 kB | +0.57% | 65.39 kB | 65.77 kB\n| [react-native/implementations/ReactFabric-profiling.fb.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/react-native/implementations/ReactFabric-profiling.fb.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+0.33%** | 393.71 kB | 395.01 kB | +0.54% | 68.28 kB | 68.65 kB\n| [react-native/implementations/ReactNativeRenderer-profiling.fb.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/react-native/implementations/ReactNativeRenderer-profiling.fb.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **+0.32%** | 401.07 kB | 402.38 kB | +0.54% | 69.62 kB | 69.99 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/f69bd7c28c8f699fffd2a946ec6114ad0c753c4f/files/__test_utils__/ReactAllWarnings.js?compare=95e610da13e50c2cb92e003dd7dbfa4a8262bdd2) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against f69bd7c28c8f699fffd2a946ec6114ad0c753c4f\n</p>\n"
] | 2024-04-26 18:03:41 | 2024-05-02 00:49:54 | 2024-05-02 00:49:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28930', 'html_url': 'https://github.com/facebook/react/pull/28930', 'diff_url': 'https://github.com/facebook/react/pull/28930.diff', 'patch_url': 'https://github.com/facebook/react/pull/28930.patch', 'merged_at': None} | ## Summary
We are almost ready to experiment with enabling `enableRefAsProp` and `disableStringRefs` in React Native at Meta. My plan is to enable and validate both at the same time, in order to minimize the time that we introduce these dynamic checks in the hot code path of JSX.
## How did you test this change?
```
$ yarn test
$ yarn flow fabric
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28930/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28930/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28929 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28929/labels{/name} | https://api.github.com/repos/facebook/react/issues/28929/comments | https://api.github.com/repos/facebook/react/issues/28929/events | https://github.com/facebook/react/pull/28929 | 2,266,135,604 | PR_kwDOAJy2Ks5t3Jpr | 28,929 | Add changelog for 18.3 | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c4083616a232028588a2cbaa9ba8992481d1deb7...8c49c91b6dde4fe119e50dcedd5d0f2651e0ebde\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8c49c91b6dde4fe119e50dcedd5d0f2651e0ebde/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/8c49c91b6dde4fe119e50dcedd5d0f2651e0ebde/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/8c49c91b6dde4fe119e50dcedd5d0f2651e0ebde/files/facebook-www/ReactDOM-prod.classic.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/8c49c91b6dde4fe119e50dcedd5d0f2651e0ebde/files/facebook-www/ReactDOM-prod.modern.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8c49c91b6dde4fe119e50dcedd5d0f2651e0ebde/files/__test_utils__/ReactAllWarnings.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/8c49c91b6dde4fe119e50dcedd5d0f2651e0ebde/files/__test_utils__/ReactAllWarnings.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 8c49c91b6dde4fe119e50dcedd5d0f2651e0ebde\n</p>\n",
"The tag and the release still missing on the Release Tab",
"The feeling when you missed adding an entry stating that you've added a missing changelog to a changelog and now you gotta release 18.3.2 adding changelog 💀",
"18.3.1 and 18.3.0 tags + releases published: https://github.com/facebook/react/releases"
] | 2024-04-26 16:36:39 | 2024-04-26 20:06:39 | 2024-04-26 16:45:08 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28929', 'html_url': 'https://github.com/facebook/react/pull/28929', 'diff_url': 'https://github.com/facebook/react/pull/28929.diff', 'patch_url': 'https://github.com/facebook/react/pull/28929.patch', 'merged_at': datetime.datetime(2024, 4, 26, 16, 45, 8)} | Fixes https://github.com/facebook/react/issues/28924 | {'url': 'https://api.github.com/repos/facebook/react/issues/28929/reactions', 'total_count': 4, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 4, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28929/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28928 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28928/labels{/name} | https://api.github.com/repos/facebook/react/issues/28928/comments | https://api.github.com/repos/facebook/react/issues/28928/events | https://github.com/facebook/react/issues/28928 | 2,266,127,634 | I_kwDOAJy2Ks6HEl0S | 28,928 | [React 19] react-test-renderer deprecation | {'login': 'iammerrick', 'id': 109635, 'node_id': 'MDQ6VXNlcjEwOTYzNQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/109635?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/iammerrick', 'html_url': 'https://github.com/iammerrick', 'followers_url': 'https://api.github.com/users/iammerrick/followers', 'following_url': 'https://api.github.com/users/iammerrick/following{/other_user}', 'gists_url': 'https://api.github.com/users/iammerrick/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/iammerrick/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/iammerrick/subscriptions', 'organizations_url': 'https://api.github.com/users/iammerrick/orgs', 'repos_url': 'https://api.github.com/users/iammerrick/repos', 'events_url': 'https://api.github.com/users/iammerrick/events{/privacy}', 'received_events_url': 'https://api.github.com/users/iammerrick/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [
"You probably get more reliable results by rendering to HTML with the method you want (server-side rendering, client-side rendering, streaming etc). That HTML can be passed to [`jsdom`](https://github.com/jsdom/jsdom) and then you also get a more robust query syntax *and* validation that your meta, title etc tags are valid.",
"Consider rendering React components to HTML using `react-dom/server`, making `react-test-renderer` obsolete. Then, parse the HTML with libraries like `cheerio`. Remove semantic data such as titles, metas, descriptions, etc. This change retains your ability to index semantic data while accepting depreciation."
] | 2024-04-26 16:31:00 | 2024-04-27 12:23:09 | null | CONTRIBUTOR | null | null | null | ## Summary
Today our team relies on react-test-renderer to render a JSON tree which is subsequently used for search indexing. By rendering to JSON we have a structure we can use to extract semantic data like `title`, `meta`, `description`, etc. To do something similar without `react-test-renderer` we'd have to render to HTML, and then use an HTML parser to parse and extract semantic data.
I realize that this is an "off label" use of React Test Renderer but I was hoping there would be an alternative to with `react-test-renderer`'s deprecation.
```tsx
ReactTestRenderer.create(reactElement).toJSON();
``` | {'url': 'https://api.github.com/repos/facebook/react/issues/28928/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28928/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28927 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28927/labels{/name} | https://api.github.com/repos/facebook/react/issues/28927/comments | https://api.github.com/repos/facebook/react/issues/28927/events | https://github.com/facebook/react/pull/28927 | 2,266,045,728 | PR_kwDOAJy2Ks5t2180 | 28,927 | [Not for merge] 18.3.1 Release | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [] | 2024-04-26 15:40:00 | 2024-04-26 16:52:55 | 2024-04-26 16:52:54 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28927', 'html_url': 'https://github.com/facebook/react/pull/28927', 'diff_url': 'https://github.com/facebook/react/pull/28927.diff', 'patch_url': 'https://github.com/facebook/react/pull/28927.patch', 'merged_at': None} | Includes:
- https://github.com/facebook/react/pull/28916 | {'url': 'https://api.github.com/repos/facebook/react/issues/28927/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28927/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28926 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28926/labels{/name} | https://api.github.com/repos/facebook/react/issues/28926/comments | https://api.github.com/repos/facebook/react/issues/28926/events | https://github.com/facebook/react/issues/28926 | 2,265,962,706 | I_kwDOAJy2Ks6HD9jS | 28,926 | [React 19] Removal of `ReactDOM.findDOMNode` | {'login': 'migueloller', 'id': 5677929, 'node_id': 'MDQ6VXNlcjU2Nzc5Mjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5677929?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/migueloller', 'html_url': 'https://github.com/migueloller', 'followers_url': 'https://api.github.com/users/migueloller/followers', 'following_url': 'https://api.github.com/users/migueloller/following{/other_user}', 'gists_url': 'https://api.github.com/users/migueloller/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/migueloller/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/migueloller/subscriptions', 'organizations_url': 'https://api.github.com/users/migueloller/orgs', 'repos_url': 'https://api.github.com/users/migueloller/repos', 'events_url': 'https://api.github.com/users/migueloller/events{/privacy}', 'received_events_url': 'https://api.github.com/users/migueloller/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [
"Prior discussion: https://github.com/facebook/react/issues/14357\r\n\r\n",
"> Prior discussion: #14357\r\n\r\nThanks for pointing out that discussion @eps1lon. It seems that the visual building case is a common use case. That being said, that issue seems to be quite old and there's not a ton of activity from the React team on that. Do you have any insight on ways to move forward?\r\n\r\nI like the idea proposed there about extracting `findDOMNode` to a separate package, like was done with prop types, so that it's not in `react-dom` but library maintainers can still leverage it if refs don't cut it."
] | 2024-04-26 14:55:48 | 2024-04-26 17:12:28 | null | NONE | null | null | null | ## Summary
React 19 removes the deprecated `ReactDOM.findDOMNode` utility. While this utility was an escape hatch and refs are the recommended way to access the DOM, in certain cases, `findDOMNode` was the only solution using a React API. Let me explain.
I maintain `@makeswift/runtime`, hosted at https://github.com/makeswift/makeswift, which is the SDK for [Makeswift](https://www.makeswift.com/), a visual editor for Next.js and React. Users of Makeswift can register React components with Makeswift so that they're available to drop in the Makeswift builder. We leverage `findDOMNode` so that we can find registered component's DOM nodes when users don't use `forwardRef` (or in React 19, handle the `ref` prop).
Here's how we use `findDOMNode`: https://github.com/makeswift/makeswift/blob/58f425cf522c23af4a71b2f07a7625b252c59a5e/packages/runtime/src/runtimes/react/find-dom-node.tsx
While we could force users to use `forwardRef`, a very important product philosophy of Makeswift is that we meet developers where they're at. We don't want them to have to make _any_ changes to their components. Their components shouldn't know about Makeswift, and if they weren't forwarding a ref then introducing Makeswift shouldn't make them do so.
In the same vein, we also don't want to alter the DOM in any way, so alternatives like using a `div` with `display: contents` are a no-go for us.
Ideally, we'd be able to use refs with a `React.Fragment`, but that API doesn't exist yet. This leaves us with the alternative of requiring users to forward refs in their components or reaching for React internals, like React DevTools does to associate a DOM node with rendered components. We'd like to avoid using internals but without `findDOMNode`, that might be what we have to do since we'd rather do that than force users to have to forward refs.
Would love to hear thoughts and guidance on what the expectation is for library maintainers to do for this use case that can't be handled with refs. Is the suggested approach to use React internals like React DevTools does? Or perhaps support for refs in `React.Fragment` is on the way?
Thanks!
| {'url': 'https://api.github.com/repos/facebook/react/issues/28926/reactions', 'total_count': 5, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28926/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28925 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28925/labels{/name} | https://api.github.com/repos/facebook/react/issues/28925/comments | https://api.github.com/repos/facebook/react/issues/28925/events | https://github.com/facebook/react/pull/28925 | 2,265,952,409 | PR_kwDOAJy2Ks5t2hZ- | 28,925 | Update Changelog for 18.3.0 | {'login': 'Zaid-maker', 'id': 53424436, 'node_id': 'MDQ6VXNlcjUzNDI0NDM2', 'avatar_url': 'https://avatars.githubusercontent.com/u/53424436?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Zaid-maker', 'html_url': 'https://github.com/Zaid-maker', 'followers_url': 'https://api.github.com/users/Zaid-maker/followers', 'following_url': 'https://api.github.com/users/Zaid-maker/following{/other_user}', 'gists_url': 'https://api.github.com/users/Zaid-maker/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Zaid-maker/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Zaid-maker/subscriptions', 'organizations_url': 'https://api.github.com/users/Zaid-maker/orgs', 'repos_url': 'https://api.github.com/users/Zaid-maker/repos', 'events_url': 'https://api.github.com/users/Zaid-maker/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Zaid-maker/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Fixed by https://github.com/facebook/react/pull/28929/files",
"> Fixed by https://github.com/facebook/react/pull/28929/files\r\n\r\nAlright"
] | 2024-04-26 14:50:11 | 2024-04-26 17:21:40 | 2024-04-26 16:44:49 | NONE | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/28925', 'html_url': 'https://github.com/facebook/react/pull/28925', 'diff_url': 'https://github.com/facebook/react/pull/28925.diff', 'patch_url': 'https://github.com/facebook/react/pull/28925.patch', 'merged_at': None} | ## Summary
Boilerplate changelog for the new release that can be update by the team because i don't have idea what they need to add, doing this because i see no one has done it yet so why not!!
## How did you test this change?
| {'url': 'https://api.github.com/repos/facebook/react/issues/28925/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28925/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28924 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28924/labels{/name} | https://api.github.com/repos/facebook/react/issues/28924/comments | https://api.github.com/repos/facebook/react/issues/28924/events | https://github.com/facebook/react/issues/28924 | 2,265,949,367 | I_kwDOAJy2Ks6HD6S3 | 28,924 | Changelog for 18.3 is missing | {'login': 'renchap', 'id': 42070, 'node_id': 'MDQ6VXNlcjQyMDcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/42070?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/renchap', 'html_url': 'https://github.com/renchap', 'followers_url': 'https://api.github.com/users/renchap/followers', 'following_url': 'https://api.github.com/users/renchap/following{/other_user}', 'gists_url': 'https://api.github.com/users/renchap/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/renchap/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/renchap/subscriptions', 'organizations_url': 'https://api.github.com/users/renchap/orgs', 'repos_url': 'https://api.github.com/users/renchap/repos', 'events_url': 'https://api.github.com/users/renchap/events{/privacy}', 'received_events_url': 'https://api.github.com/users/renchap/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Was also looking to understand the impact of this minor update :D "
] | 2024-04-26 14:48:35 | 2024-04-26 16:45:09 | 2024-04-26 16:45:09 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.3
## Steps To Reproduce
1. Check the Releases section on this repo, the `CHANGELOG.md` file, or click on "Release notes" at the end of the second note on this blog post: https://react.dev/blog/2024/04/25/react-19-upgrade-guide
## The current behavior
There is no changelog for the 18.3 release
## The expected behavior
There should be a changelog | {'url': 'https://api.github.com/repos/facebook/react/issues/28924/reactions', 'total_count': 7, '+1': 5, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/28924/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28923 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28923/labels{/name} | https://api.github.com/repos/facebook/react/issues/28923/comments | https://api.github.com/repos/facebook/react/issues/28923/events | https://github.com/facebook/react/issues/28923 | 2,265,682,821 | I_kwDOAJy2Ks6HC5OF | 28,923 | [React 19] useTransition()'s pending state does not go back to false (revision 94eed63c49-20240425) | {'login': 'alexeyraspopov', 'id': 858295, 'node_id': 'MDQ6VXNlcjg1ODI5NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/858295?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alexeyraspopov', 'html_url': 'https://github.com/alexeyraspopov', 'followers_url': 'https://api.github.com/users/alexeyraspopov/followers', 'following_url': 'https://api.github.com/users/alexeyraspopov/following{/other_user}', 'gists_url': 'https://api.github.com/users/alexeyraspopov/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/alexeyraspopov/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/alexeyraspopov/subscriptions', 'organizations_url': 'https://api.github.com/users/alexeyraspopov/orgs', 'repos_url': 'https://api.github.com/users/alexeyraspopov/repos', 'events_url': 'https://api.github.com/users/alexeyraspopov/events{/privacy}', 'received_events_url': 'https://api.github.com/users/alexeyraspopov/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [
"Does this reproduce in dev and prod?",
"@eps1lon I made production build via `npx vite build` and the behavior remains the same.",
"Maybe not a good idea to pass an async value directly or either through a function into state as this behaviour is synchronous. this could result to state inconsistency and also concurrency issues. looking at the delayed function passed into state."
] | 2024-04-26 12:28:58 | 2024-04-26 18:00:42 | null | CONTRIBUTOR | null | null | null | ## Summary
I am excited to start using React v19 as it has so many features and QoL improvements I've been waiting for!
There is a bug (new bug comparing to v18.2.0) that I found while reproducing https://github.com/facebook/react/issues/26814. When using `useTransition()` with `use()`, `pending` flag of transition correctly becomes `true` in the beginning, but doesn't go back to `false` after transition is complete, which means any pending state artifacts in the UI remain visible.
Repository for reproducing: https://github.com/alexeyraspopov/react-beta-bugs.
Basic code (since the repo contains more than just this bug):
```ts
function SimpleAsyncFlow() {
// this state holds instance of a promise that resolves after a second
// the same `delayed()` function is used to trigger state update inside SimpleControlledDisplay
let [value, setValue] = useState(() => delayed(Math.random()));
return (
<Suspense fallback={<p>Loading</p>}>
<SimpleControlledDisplay promise={value} onChange={setValue} />
</Suspense>
);
}
function SimpleControlledDisplay({
promise,
onChange,
}: {
promise: Promise<number>;
onChange: (value: Promise<number>) => void;
}) {
let value = use(promise);
let [pending, startTransition] = useTransition();
let click = () => {
// this will trigger state update in the parent with the new 1 second promise
// that suppose to suspend this component, so transition should prevent it
startTransition(() => {
onChange(delayed(Math.random()));
});
};
return (
<div>
<button onClick={click}>Refresh</button>
{/* as UI "pending" state I update text style to become half transparent */}
<p style={{ opacity: pending ? 0.5 : 1 }}>{value}</p>
</div>
);
}
function delayed<T>(value: T) {
return new Promise<T>((resolve) => setTimeout(resolve, 1000, value));
}
```
Additionally here's the video reproduction, using the code from the repo I mentioned:
https://github.com/facebook/react/assets/858295/47fc5678-6c99-48f7-a55d-8b48b9bcee35
| {'url': 'https://api.github.com/repos/facebook/react/issues/28923/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28923/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28922 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28922/labels{/name} | https://api.github.com/repos/facebook/react/issues/28922/comments | https://api.github.com/repos/facebook/react/issues/28922/events | https://github.com/facebook/react/issues/28922 | 2,265,572,302 | I_kwDOAJy2Ks6HCePO | 28,922 | Bug: | {'login': 'LaveshChaudhari', 'id': 167971651, 'node_id': 'U_kgDOCgMLQw', 'avatar_url': 'https://avatars.githubusercontent.com/u/167971651?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/LaveshChaudhari', 'html_url': 'https://github.com/LaveshChaudhari', 'followers_url': 'https://api.github.com/users/LaveshChaudhari/followers', 'following_url': 'https://api.github.com/users/LaveshChaudhari/following{/other_user}', 'gists_url': 'https://api.github.com/users/LaveshChaudhari/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/LaveshChaudhari/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/LaveshChaudhari/subscriptions', 'organizations_url': 'https://api.github.com/users/LaveshChaudhari/orgs', 'repos_url': 'https://api.github.com/users/LaveshChaudhari/repos', 'events_url': 'https://api.github.com/users/LaveshChaudhari/events{/privacy}', 'received_events_url': 'https://api.github.com/users/LaveshChaudhari/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2024-04-26 11:20:26 | 2024-04-26 12:29:05 | 2024-04-26 12:29:05 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
## The expected behavior
| {'url': 'https://api.github.com/repos/facebook/react/issues/28922/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28922/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/28921 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28921/labels{/name} | https://api.github.com/repos/facebook/react/issues/28921/comments | https://api.github.com/repos/facebook/react/issues/28921/events | https://github.com/facebook/react/pull/28921 | 2,265,175,693 | PR_kwDOAJy2Ks5tz2q4 | 28,921 | fix: add `react-server` condition for `react/jsx-dev-runtime` | {'login': 'himself65', 'id': 14026360, 'node_id': 'MDQ6VXNlcjE0MDI2MzYw', 'avatar_url': 'https://avatars.githubusercontent.com/u/14026360?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/himself65', 'html_url': 'https://github.com/himself65', 'followers_url': 'https://api.github.com/users/himself65/followers', 'following_url': 'https://api.github.com/users/himself65/following{/other_user}', 'gists_url': 'https://api.github.com/users/himself65/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/himself65/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/himself65/subscriptions', 'organizations_url': 'https://api.github.com/users/himself65/orgs', 'repos_url': 'https://api.github.com/users/himself65/repos', 'events_url': 'https://api.github.com/users/himself65/events{/privacy}', 'received_events_url': 'https://api.github.com/users/himself65/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: 4ddff7355f696ec693c5ce2bda4e7707020c3510...faf1bc67f535615c5be3e6788594ccd6473924c1\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/facebook-www/ReactDOM-prod.classic.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/facebook-www/ReactDOM-prod.modern.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.development.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.development.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 43.05 kB | +∞% | 0.00 kB | 12.99 kB\n| [oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.production.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 1.32 kB | +∞% | 0.00 kB | 0.68 kB\n| [oss-experimental/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-experimental/react/jsx-dev-runtime.react-server.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 0.25 kB | +∞% | 0.00 kB | 0.16 kB\n| [oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.development.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.development.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 43.05 kB | +∞% | 0.00 kB | 12.99 kB\n| [oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.production.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 1.32 kB | +∞% | 0.00 kB | 0.68 kB\n| [oss-stable-semver/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable-semver/react/jsx-dev-runtime.react-server.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 0.25 kB | +∞% | 0.00 kB | 0.16 kB\n| [oss-stable/react/cjs/react-jsx-dev-runtime.react-server.development.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable/react/cjs/react-jsx-dev-runtime.react-server.development.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 43.05 kB | +∞% | 0.00 kB | 12.99 kB\n| [oss-stable/react/cjs/react-jsx-dev-runtime.react-server.production.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable/react/cjs/react-jsx-dev-runtime.react-server.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 1.32 kB | +∞% | 0.00 kB | 0.68 kB\n| [oss-stable/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable/react/jsx-dev-runtime.react-server.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 0.25 kB | +∞% | 0.00 kB | 0.16 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/__test_utils__/ReactAllWarnings.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.development.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.development.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 43.05 kB | +∞% | 0.00 kB | 12.99 kB\n| [oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.production.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 1.32 kB | +∞% | 0.00 kB | 0.68 kB\n| [oss-experimental/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-experimental/react/jsx-dev-runtime.react-server.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 0.25 kB | +∞% | 0.00 kB | 0.16 kB\n| [oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.development.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.development.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 43.05 kB | +∞% | 0.00 kB | 12.99 kB\n| [oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.production.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 1.32 kB | +∞% | 0.00 kB | 0.68 kB\n| [oss-stable-semver/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable-semver/react/jsx-dev-runtime.react-server.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 0.25 kB | +∞% | 0.00 kB | 0.16 kB\n| [oss-stable/react/cjs/react-jsx-dev-runtime.react-server.development.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable/react/cjs/react-jsx-dev-runtime.react-server.development.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 43.05 kB | +∞% | 0.00 kB | 12.99 kB\n| [oss-stable/react/cjs/react-jsx-dev-runtime.react-server.production.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable/react/cjs/react-jsx-dev-runtime.react-server.production.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 1.32 kB | +∞% | 0.00 kB | 0.68 kB\n| [oss-stable/react/jsx-dev-runtime.react-server.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/oss-stable/react/jsx-dev-runtime.react-server.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **+∞%** | 0.00 kB | 0.25 kB | +∞% | 0.00 kB | 0.16 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/faf1bc67f535615c5be3e6788594ccd6473924c1/files/__test_utils__/ReactAllWarnings.js?compare=4ddff7355f696ec693c5ce2bda4e7707020c3510) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against faf1bc67f535615c5be3e6788594ccd6473924c1\n</p>\n"
] | 2024-04-26 07:49:06 | 2024-04-27 20:18:34 | 2024-04-27 19:45:52 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28921', 'html_url': 'https://github.com/facebook/react/pull/28921', 'diff_url': 'https://github.com/facebook/react/pull/28921.diff', 'patch_url': 'https://github.com/facebook/react/pull/28921.patch', 'merged_at': datetime.datetime(2024, 4, 27, 19, 45, 52)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
Add `react-server` condition for `react/jsx-dev-runtime` to ensure they use the same internal in one node thread.
In Waku RSC, we have a node worker under the `react-server` condition and use vite to parse the react component. in development mode, the jsx-dev was linked to `React.__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE`, which does not exist on the server side. So react@beta cause a runtime error and blocks waku from upgrading react version(https://github.com/dai-shi/waku/pull/671).
```shell
Cannot process SSR Error: TypeError: Cannot read properties of undefined (reading 'A')
at file:///home/runner/work/waku/waku/packages/waku/dist/lib/renderers/dev-worker-api.js:132:60
at Worker.<anonymous> (file:///home/runner/work/waku/waku/packages/waku/dist/lib/renderers/dev-worker-api.js:34:52)
at Worker.emit (node:events:526:35)
at MessagePort.<anonymous> (node:internal/worker:263:53)
at [nodejs.internal.kHybridDispatch] (node:internal/event_target:807:20)
at exports.emitMessage (node:internal/per_context/messageport:23:28)
```
Related: https://github.com/facebook/react/pull/28217
/cc @dai-shi
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
Copy and paste into waku repo node_modules; not sure how to test React.
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28921/reactions', 'total_count': 5, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 2, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28921/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28920 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28920/labels{/name} | https://api.github.com/repos/facebook/react/issues/28920/comments | https://api.github.com/repos/facebook/react/issues/28920/events | https://github.com/facebook/react/pull/28920 | 2,265,175,551 | PR_kwDOAJy2Ks5tz2o- | 28,920 | Update made | {'login': 'Ramsey00007', 'id': 167698731, 'node_id': 'U_kgDOCf7hKw', 'avatar_url': 'https://avatars.githubusercontent.com/u/167698731?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Ramsey00007', 'html_url': 'https://github.com/Ramsey00007', 'followers_url': 'https://api.github.com/users/Ramsey00007/followers', 'following_url': 'https://api.github.com/users/Ramsey00007/following{/other_user}', 'gists_url': 'https://api.github.com/users/Ramsey00007/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Ramsey00007/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Ramsey00007/subscriptions', 'organizations_url': 'https://api.github.com/users/Ramsey00007/orgs', 'repos_url': 'https://api.github.com/users/Ramsey00007/repos', 'events_url': 'https://api.github.com/users/Ramsey00007/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Ramsey00007/received_events', 'type': 'User', 'site_admin': False} | [] | closed | false | null | [] | null | [
"Hi @Ramsey00007! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328920). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c4083616a232028588a2cbaa9ba8992481d1deb7...a40b391e3a23066b362ae65da2c7a0543f19dcd9\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/a40b391e3a23066b362ae65da2c7a0543f19dcd9/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/a40b391e3a23066b362ae65da2c7a0543f19dcd9/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/a40b391e3a23066b362ae65da2c7a0543f19dcd9/files/facebook-www/ReactDOM-prod.classic.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/a40b391e3a23066b362ae65da2c7a0543f19dcd9/files/facebook-www/ReactDOM-prod.modern.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/a40b391e3a23066b362ae65da2c7a0543f19dcd9/files/__test_utils__/ReactAllWarnings.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/a40b391e3a23066b362ae65da2c7a0543f19dcd9/files/__test_utils__/ReactAllWarnings.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against a40b391e3a23066b362ae65da2c7a0543f19dcd9\n</p>\n",
"Another Spam PR"
] | 2024-04-26 07:49:00 | 2024-04-26 08:21:13 | 2024-04-26 08:21:13 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28920', 'html_url': 'https://github.com/facebook/react/pull/28920', 'diff_url': 'https://github.com/facebook/react/pull/28920.diff', 'patch_url': 'https://github.com/facebook/react/pull/28920.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| {'url': 'https://api.github.com/repos/facebook/react/issues/28920/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28920/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28919 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28919/labels{/name} | https://api.github.com/repos/facebook/react/issues/28919/comments | https://api.github.com/repos/facebook/react/issues/28919/events | https://github.com/facebook/react/pull/28919 | 2,264,948,146 | PR_kwDOAJy2Ks5tzGF4 | 28,919 | [react-dom] Provide a way to silence devtools recommendation | {'login': 'rtpg', 'id': 1408472, 'node_id': 'MDQ6VXNlcjE0MDg0NzI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1408472?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rtpg', 'html_url': 'https://github.com/rtpg', 'followers_url': 'https://api.github.com/users/rtpg/followers', 'following_url': 'https://api.github.com/users/rtpg/following{/other_user}', 'gists_url': 'https://api.github.com/users/rtpg/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rtpg/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rtpg/subscriptions', 'organizations_url': 'https://api.github.com/users/rtpg/orgs', 'repos_url': 'https://api.github.com/users/rtpg/repos', 'events_url': 'https://api.github.com/users/rtpg/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rtpg/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | open | false | null | [] | null | [
"Hi @rtpg! \n\nThank you for your pull request and welcome to our community. \n\n# Action Required\n\nIn order to merge **any pull request** (code, docs, etc.), we **require** contributors to sign our **Contributor License Agreement**, and we don't seem to have one on file for you.\n\n# Process\n\nIn order for us to review and merge your suggested changes, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.\n\nOnce the CLA is signed, our tooling will perform checks and validations. Afterwards, the **pull request will be tagged** with `CLA signed`. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.\n\nIf you have received this in error or have any questions, please contact us at [cla@meta.com](mailto:cla@meta.com?subject=CLA%20for%20facebook%2Freact%20%2328919). Thanks!",
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: c4083616a232028588a2cbaa9ba8992481d1deb7...6797b3666f30b09e3964eac152e36bb377ef8c83\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/6797b3666f30b09e3964eac152e36bb377ef8c83/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 6.66 kB | 6.66 kB | +0.11% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/6797b3666f30b09e3964eac152e36bb377ef8c83/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/6797b3666f30b09e3964eac152e36bb377ef8c83/files/facebook-www/ReactDOM-prod.classic.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 591.11 kB | 591.11 kB | = | 103.94 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/6797b3666f30b09e3964eac152e36bb377ef8c83/files/facebook-www/ReactDOM-prod.modern.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **=** | 567.33 kB | 567.33 kB | = | 100.34 kB | 100.34 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/6797b3666f30b09e3964eac152e36bb377ef8c83/files/__test_utils__/ReactAllWarnings.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/6797b3666f30b09e3964eac152e36bb377ef8c83/files/__test_utils__/ReactAllWarnings.js?compare=c4083616a232028588a2cbaa9ba8992481d1deb7) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 6797b3666f30b09e3964eac152e36bb377ef8c83\n</p>\n",
"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!"
] | 2024-04-26 04:39:32 | 2024-04-27 23:21:07 | null | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28919', 'html_url': 'https://github.com/facebook/react/pull/28919', 'diff_url': 'https://github.com/facebook/react/pull/28919.diff', 'patch_url': 'https://github.com/facebook/react/pull/28919.patch', 'merged_at': None} | If you hit this console message and search for how to turn it off, many people recommend hacky ways to do so that also end up breaking the extension if you actually want to use it later on.
This provides a way to turn off just the message, without trying to trick injectIntoDevTools into thinking something's happened.
[This SO answer](https://stackoverflow.com/a/48324794) is a good example of a "wrong answer" to disabling this logging warning:
```
window.__REACT_DEVTOOLS_GLOBAL_HOOK__ = { isDisabled: true };
```
This [disables the integration entirely](https://github.com/facebook/react/blob/c4083616a232028588a2cbaa9ba8992481d1deb7/packages/react-reconciler/src/ReactFiberDevToolsHook.js#L60) instead of simply removing the warning if it's not installed. A project might want to simply not have the log show up for its own reasons.
I'm sending this up, if it's OK in principle the best thing would be to include 2 lines in some docs so that it can be the first result of a web search for people looking to disable it.
As to why I want to disable this: I run some tests without minified react. In the CI environment I do not need the devtools installed. I would like to avoid having to write some special-cased code to hack-away a removal of this message.
related issues: #12041 | {'url': 'https://api.github.com/repos/facebook/react/issues/28919/reactions', 'total_count': 3, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28919/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28918 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28918/labels{/name} | https://api.github.com/repos/facebook/react/issues/28918/comments | https://api.github.com/repos/facebook/react/issues/28918/events | https://github.com/facebook/react/issues/28918 | 2,264,853,009 | I_kwDOAJy2Ks6G_uoR | 28,918 | Bug: Source not displayed in DevTools | {'login': 'Bibek1604', 'id': 145880788, 'node_id': 'U_kgDOCLH21A', 'avatar_url': 'https://avatars.githubusercontent.com/u/145880788?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Bibek1604', 'html_url': 'https://github.com/Bibek1604', 'followers_url': 'https://api.github.com/users/Bibek1604/followers', 'following_url': 'https://api.github.com/users/Bibek1604/following{/other_user}', 'gists_url': 'https://api.github.com/users/Bibek1604/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/Bibek1604/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/Bibek1604/subscriptions', 'organizations_url': 'https://api.github.com/users/Bibek1604/orgs', 'repos_url': 'https://api.github.com/users/Bibek1604/repos', 'events_url': 'https://api.github.com/users/Bibek1604/events{/privacy}', 'received_events_url': 'https://api.github.com/users/Bibek1604/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | {'login': 'hoxyq', 'id': 28902667.0, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_url': 'https://api.github.com/users/hoxyq/following{/other_user}', 'gists_url': 'https://api.github.com/users/hoxyq/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hoxyq/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hoxyq/subscriptions', 'organizations_url': 'https://api.github.com/users/hoxyq/orgs', 'repos_url': 'https://api.github.com/users/hoxyq/repos', 'events_url': 'https://api.github.com/users/hoxyq/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hoxyq/received_events', 'type': 'User', 'site_admin': False} | [{'login': 'hoxyq', 'id': 28902667, 'node_id': 'MDQ6VXNlcjI4OTAyNjY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28902667?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hoxyq', 'html_url': 'https://github.com/hoxyq', 'followers_url': 'https://api.github.com/users/hoxyq/followers', 'following_url': 'https://api.github.com/users/hoxyq/following{/other_user}', 'gists_url': 'https://api.github.com/users/hoxyq/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/hoxyq/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/hoxyq/subscriptions', 'organizations_url': 'https://api.github.com/users/hoxyq/orgs', 'repos_url': 'https://api.github.com/users/hoxyq/repos', 'events_url': 'https://api.github.com/users/hoxyq/events{/privacy}', 'received_events_url': 'https://api.github.com/users/hoxyq/received_events', 'type': 'User', 'site_admin': False}] | null | [
"cc @hoxyq ",
"same issue 🥺",
"Duplicate of https://github.com/facebook/react/issues/28544#issuecomment-1991591646, please see the comment."
] | 2024-04-26 02:46:04 | 2024-05-02 18:27:59 | 2024-05-02 18:27:59 | NONE | null | null | null | 
if I select any component is should show source of that component but it is showing it in bundle I need source of that component
I have attached the SS check last line ,what can i do to get source, not in bundle source | {'url': 'https://api.github.com/repos/facebook/react/issues/28918/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 2, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28918/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28917 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28917/labels{/name} | https://api.github.com/repos/facebook/react/issues/28917/comments | https://api.github.com/repos/facebook/react/issues/28917/events | https://github.com/facebook/react/issues/28917 | 2,264,663,693 | I_kwDOAJy2Ks6G_AaN | 28,917 | Bug: "React Developer Tools" Chrome Extension unable to profile page rendering | {'login': 'SomervilleTom', 'id': 64976799, 'node_id': 'MDQ6VXNlcjY0OTc2Nzk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/64976799?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SomervilleTom', 'html_url': 'https://github.com/SomervilleTom', 'followers_url': 'https://api.github.com/users/SomervilleTom/followers', 'following_url': 'https://api.github.com/users/SomervilleTom/following{/other_user}', 'gists_url': 'https://api.github.com/users/SomervilleTom/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/SomervilleTom/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/SomervilleTom/subscriptions', 'organizations_url': 'https://api.github.com/users/SomervilleTom/orgs', 'repos_url': 'https://api.github.com/users/SomervilleTom/repos', 'events_url': 'https://api.github.com/users/SomervilleTom/events{/privacy}', 'received_events_url': 'https://api.github.com/users/SomervilleTom/received_events', 'type': 'User', 'site_admin': False} | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [] | 2024-04-25 23:40:47 | 2024-04-25 23:40:47 | null | NONE | null | null | null | I'm unable to profile the rendering of a page in a Chrome browser launched from Visual Studio Code ("VSC"). I think I'm using the most recent stable versions of Chrome and the "React Developer Tools" extension.
I'm attaching screenshots to help explain the behavior I'm seeing.
The page I'm rendering takes less than a second to render in "production" mode (created by "yarn build") and more than 90 seconds to render when launched from VSC. I want to profile the development version in hopes of finding a workaround to whatever is causing this 100x slowdown.
Here is what I'm seeing:
1. Wait until the page renders ("Rendered page")
2. Open Profiler tab in Chrome Developer Tools ("Initial Profiler tab")
3. Click the "record" button ("Profiling in progress")
4. Enter "CNTRL r" to cause a reload. The developer tools is stuck on the "Sources" tab and flashes uncontrollably, apparently as source files are loaded ("Flashing while re-rendering").
5. Wait until the page renders. Note the console errors at the bottom ("Stable after re-rendering completes, two console complaints")
6. Attempt to open the "Profiler" tab -- it now says "Profiling not supported" ("Profiler tab now says "Profiling not supported"")
I note that the complaint in the final screenshot references a very old version of React (16.5+). Its embedded link goes to an old and stale React documentation page.
React version: "^18.2.0"
React DeveloperTools version: b566064da on 4/15/2024
Screenshots follow:
**Rendered page**
**Initial Profiler tab**
**Profiling in progress**
**Flashing while re-rendering**
**Stable after re-rendering completes, two console complaints"
**Profiler tab now says "Profiling not supported"**
## Steps To Reproduce
See above
Link to code example:
Too hard to create, see screenshots above
## The current behavior
See screenshots above
## The expected behavior
I expect to see a profile report
| {'url': 'https://api.github.com/repos/facebook/react/issues/28917/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28917/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28916 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28916/labels{/name} | https://api.github.com/repos/facebook/react/issues/28916/comments | https://api.github.com/repos/facebook/react/issues/28916/events | https://github.com/facebook/react/pull/28916 | 2,264,624,089 | PR_kwDOAJy2Ks5tyAxz | 28,916 | Export `React.act` from 18.3 | {'login': 'rickhanlonii', 'id': 2440089, 'node_id': 'MDQ6VXNlcjI0NDAwODk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2440089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickhanlonii', 'html_url': 'https://github.com/rickhanlonii', 'followers_url': 'https://api.github.com/users/rickhanlonii/followers', 'following_url': 'https://api.github.com/users/rickhanlonii/following{/other_user}', 'gists_url': 'https://api.github.com/users/rickhanlonii/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rickhanlonii/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rickhanlonii/subscriptions', 'organizations_url': 'https://api.github.com/users/rickhanlonii/orgs', 'repos_url': 'https://api.github.com/users/rickhanlonii/repos', 'events_url': 'https://api.github.com/users/rickhanlonii/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rickhanlonii/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"Cherry-picked into https://github.com/facebook/react/pull/28927"
] | 2024-04-25 22:52:07 | 2024-04-26 15:59:47 | 2024-04-26 15:59:47 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28916', 'html_url': 'https://github.com/facebook/react/pull/28916', 'diff_url': 'https://github.com/facebook/react/pull/28916.diff', 'patch_url': 'https://github.com/facebook/react/pull/28916.patch', 'merged_at': None} | **Base branch 18.3**
In 18.3 we warn to use `React.act` but we only export `React.unstable_act`.
Fixes https://github.com/facebook/react/issues/28915 | {'url': 'https://api.github.com/repos/facebook/react/issues/28916/reactions', 'total_count': 11, '+1': 8, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 3, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28916/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28915 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28915/labels{/name} | https://api.github.com/repos/facebook/react/issues/28915/comments | https://api.github.com/repos/facebook/react/issues/28915/events | https://github.com/facebook/react/issues/28915 | 2,264,592,422 | I_kwDOAJy2Ks6G-vAm | 28,915 | Bug: React 18.3 warning says to import `act` from `react`, only `unstable_act` exists | {'login': 'rexxars', 'id': 48200, 'node_id': 'MDQ6VXNlcjQ4MjAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/48200?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rexxars', 'html_url': 'https://github.com/rexxars', 'followers_url': 'https://api.github.com/users/rexxars/followers', 'following_url': 'https://api.github.com/users/rexxars/following{/other_user}', 'gists_url': 'https://api.github.com/users/rexxars/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/rexxars/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/rexxars/subscriptions', 'organizations_url': 'https://api.github.com/users/rexxars/orgs', 'repos_url': 'https://api.github.com/users/rexxars/repos', 'events_url': 'https://api.github.com/users/rexxars/events{/privacy}', 'received_events_url': 'https://api.github.com/users/rexxars/received_events', 'type': 'User', 'site_admin': False} | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}] | closed | false | {'login': 'acdlite', 'id': 3624098.0, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False} | [{'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False}] | null | [
"Also encountered this. Worth noting that the recommended `@testing-library/react` package will emit this too as a result of what's reported here.\r\n\r\nThey attempt to use what is requested by `react`, but fallback to the deprecated usage due to `act` being undefined on `react` itself\r\n\r\n```js\r\nimport * as React from 'react'\r\nimport * as DeprecatedReactTestUtils from 'react-dom/test-utils'\r\n\r\nconst reactAct = typeof React.act === 'function' ? React.act : DeprecatedReactTestUtils.act\r\n```\r\n[source](https://github.com/testing-library/react-testing-library/blob/main/src/act-compat.js#L1C1-L5C77)",
"Nice catch, will fix in https://github.com/facebook/react/pull/28916",
"Fixed in 18.3.1, thanks for reporting!"
] | 2024-04-25 22:21:44 | 2024-04-26 17:02:23 | 2024-04-26 17:02:11 | CONTRIBUTOR | null | null | null | In the newly released 18.3.0 release, if you try to use the `act` function from `react-dom/test-utils`, you will get the following warning:
> Import `act` from `react` instead of `react-dom/test-utils`
However, the 18.3.0 release only ships `unstable_act`, not `act`. The react 19 beta seems to have renamed to `act`.
I feel the warning should either tell you to import from `unstable_act`, _or_ the `act` export should actually exist, even if aliased to `unstable_act` internally
React version: 18.3.0
## Steps To Reproduce
1. On react + react-dom@18.3.0, import and use `act` from `react-dom/test-utils`.
2. See warning
3. Try to import `act` from react@18.3.0
Link to code example: [https://codesandbox.io/p/sandbox/intelligent-chandrasekhar-p9xk7h](https://codesandbox.io/p/sandbox/intelligent-chandrasekhar-p9xk7h?file=%2Fsrc%2Ftest.js%3A6%2C1&layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522clvfsslh200063b6joqedrppd%2522%252C%2522sizes%2522%253A%255B100%252C0%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522clvfsslh200023b6jmbhhjfwu%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522clvfsslh200033b6jhy11k8p6%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522clvfsslh200053b6jdt7slm5u%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B50%252C50%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522clvfsslh200023b6jmbhhjfwu%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clvfsslh200013b6j2ebpwwn7%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fsrc%252Findex.js%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%252C%257B%2522id%2522%253A%2522clvfst1ny003t3b6janff2rkm%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A5%252C%2522startColumn%2522%253A18%252C%2522endLineNumber%2522%253A5%252C%2522endColumn%2522%253A18%257D%255D%252C%2522filepath%2522%253A%2522%252Fpackage.json%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%252C%257B%2522id%2522%253A%2522clvfszp0000023b6ijbh4phsw%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A6%252C%2522startColumn%2522%253A1%252C%2522endLineNumber%2522%253A6%252C%2522endColumn%2522%253A1%257D%255D%252C%2522filepath%2522%253A%2522%252Fsrc%252Ftest.js%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%255D%252C%2522id%2522%253A%2522clvfsslh200023b6jmbhhjfwu%2522%252C%2522activeTabId%2522%253A%2522clvfszp0000023b6ijbh4phsw%2522%257D%252C%2522clvfsslh200053b6jdt7slm5u%2522%253A%257B%2522id%2522%253A%2522clvfsslh200053b6jdt7slm5u%2522%252C%2522activeTabId%2522%253A%2522clvfsxdrw00fk3b6iv08mk34s%2522%252C%2522tabs%2522%253A%255B%257B%2522type%2522%253A%2522UNASSIGNED_PORT%2522%252C%2522port%2522%253A0%252C%2522id%2522%253A%2522clvfsxdrw00fk3b6iv08mk34s%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522path%2522%253A%2522%252F%2522%257D%255D%257D%252C%2522clvfsslh200033b6jhy11k8p6%2522%253A%257B%2522tabs%2522%253A%255B%255D%252C%2522id%2522%253A%2522clvfsslh200033b6jhy11k8p6%2522%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Afalse%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A15%257D)
## The current behavior
`act` does not exist, warning tells you to use it
## The expected behavior
`act` exists, warning tells you to use it _OR_ warning tells you to use `unstable_act` | {'url': 'https://api.github.com/repos/facebook/react/issues/28915/reactions', 'total_count': 15, '+1': 15, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28915/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/28914 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28914/labels{/name} | https://api.github.com/repos/facebook/react/issues/28914/comments | https://api.github.com/repos/facebook/react/issues/28914/events | https://github.com/facebook/react/issues/28914 | 2,264,508,793 | I_kwDOAJy2Ks6G-al5 | 28,914 | [React 19] Async transitions race condition handling | {'login': 'tom-sherman', 'id': 9257001, 'node_id': 'MDQ6VXNlcjkyNTcwMDE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9257001?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tom-sherman', 'html_url': 'https://github.com/tom-sherman', 'followers_url': 'https://api.github.com/users/tom-sherman/followers', 'following_url': 'https://api.github.com/users/tom-sherman/following{/other_user}', 'gists_url': 'https://api.github.com/users/tom-sherman/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/tom-sherman/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/tom-sherman/subscriptions', 'organizations_url': 'https://api.github.com/users/tom-sherman/orgs', 'repos_url': 'https://api.github.com/users/tom-sherman/repos', 'events_url': 'https://api.github.com/users/tom-sherman/events{/privacy}', 'received_events_url': 'https://api.github.com/users/tom-sherman/received_events', 'type': 'User', 'site_admin': False} | [{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | open | false | null | [] | null | [] | 2024-04-25 21:15:01 | 2024-04-25 21:25:10 | null | NONE | null | null | null | ## Summary
Repro: https://stackblitz.com/edit/vitejs-vite-ymbqrc?file=src%2FApp.tsx
How do we handle async transitions that resolve out of order? In the above reproduction the search for "a" can resolve after "ab", leading to the input containing "ab" but the results pertaining to "a". In other words, the most recent transition isn't the one that wins.
In other discussions it's [been mentioned](https://twitter.com/acdlite/status/1768780638767788501) that this is caused by React losing the context that the setState happens inside a transition as it happens after `await`. But I'm not sure how to work around this today | {'url': 'https://api.github.com/repos/facebook/react/issues/28914/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28914/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/28912 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28912/labels{/name} | https://api.github.com/repos/facebook/react/issues/28912/comments | https://api.github.com/repos/facebook/react/issues/28912/events | https://github.com/facebook/react/pull/28912 | 2,264,133,439 | PR_kwDOAJy2Ks5twVXJ | 28,912 | (Land #28798) Move Current Owner (and Cache) to an Async Dispatcher | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_url': 'https://api.github.com/users/gnoff/following{/other_user}', 'gists_url': 'https://api.github.com/users/gnoff/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/gnoff/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/gnoff/subscriptions', 'organizations_url': 'https://api.github.com/users/gnoff/orgs', 'repos_url': 'https://api.github.com/users/gnoff/repos', 'events_url': 'https://api.github.com/users/gnoff/events{/privacy}', 'received_events_url': 'https://api.github.com/users/gnoff/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: f8a8eac86bac406724f327325f804e65e594dd68...76716212bbdf6cf29dc0ad6f83424ee84c313d08\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-www/ReactDOM-prod.classic.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 591.09 kB | 591.11 kB | = | 103.93 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-www/ReactDOM-prod.modern.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 567.32 kB | 567.33 kB | +0.01% | 100.33 kB | 100.34 kB\n| [facebook-react-native/react/cjs/JSXRuntime-prod.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-react-native/react/cjs/JSXRuntime-prod.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.30%** | 2.86 kB | 2.98 kB | +3.43% | 1.23 kB | 1.27 kB\n| [facebook-react-native/react/cjs/JSXRuntime-profiling.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-react-native/react/cjs/JSXRuntime-profiling.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.30%** | 2.86 kB | 2.98 kB | +3.43% | 1.23 kB | 1.27 kB\n| [oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.18%** | 1.17 kB | 1.22 kB | +2.58% | 0.58 kB | 0.60 kB\n| [oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.18%** | 1.17 kB | 1.22 kB | +2.58% | 0.58 kB | 0.60 kB\n| [oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.18%** | 1.17 kB | 1.22 kB | +2.58% | 0.58 kB | 0.60 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/__test_utils__/ReactAllWarnings.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [facebook-react-native/react/cjs/JSXRuntime-prod.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-react-native/react/cjs/JSXRuntime-prod.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.30%** | 2.86 kB | 2.98 kB | +3.43% | 1.23 kB | 1.27 kB\n| [facebook-react-native/react/cjs/JSXRuntime-profiling.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-react-native/react/cjs/JSXRuntime-profiling.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.30%** | 2.86 kB | 2.98 kB | +3.43% | 1.23 kB | 1.27 kB\n| [oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react-suspense-test-utils/cjs/react-suspense-test-utils.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.18%** | 1.17 kB | 1.22 kB | +2.58% | 0.58 kB | 0.60 kB\n| [oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react-suspense-test-utils/cjs/react-suspense-test-utils.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.18%** | 1.17 kB | 1.22 kB | +2.58% | 0.58 kB | 0.60 kB\n| [oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react-suspense-test-utils/cjs/react-suspense-test-utils.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+4.18%** | 1.17 kB | 1.22 kB | +2.58% | 0.58 kB | 0.60 kB\n| [oss-experimental/react/cjs/react-jsx-dev-runtime.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react/cjs/react-jsx-dev-runtime.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.31%** | 41.28 kB | 41.41 kB | +0.35% | 12.47 kB | 12.52 kB\n| [oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.31%** | 41.28 kB | 41.41 kB | +0.35% | 12.47 kB | 12.52 kB\n| [oss-stable/react/cjs/react-jsx-dev-runtime.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react/cjs/react-jsx-dev-runtime.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.31%** | 41.28 kB | 41.41 kB | +0.35% | 12.47 kB | 12.52 kB\n| [oss-experimental/react/cjs/react-jsx-runtime.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react/cjs/react-jsx-runtime.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.30%** | 42.51 kB | 42.64 kB | +0.33% | 12.82 kB | 12.86 kB\n| [oss-stable-semver/react/cjs/react-jsx-runtime.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react/cjs/react-jsx-runtime.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.30%** | 42.51 kB | 42.64 kB | +0.33% | 12.82 kB | 12.86 kB\n| [oss-stable/react/cjs/react-jsx-runtime.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react/cjs/react-jsx-runtime.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.30%** | 42.51 kB | 42.64 kB | +0.33% | 12.82 kB | 12.86 kB\n| [oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.25%** | 42.94 kB | 43.05 kB | +0.32% | 12.94 kB | 12.99 kB\n| [oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.25%** | 42.94 kB | 43.05 kB | +0.32% | 12.94 kB | 12.99 kB\n| [oss-stable/react/cjs/react-jsx-runtime.react-server.development.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react/cjs/react-jsx-runtime.react-server.development.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **+0.25%** | 42.94 kB | 43.05 kB | +0.32% | 12.94 kB | 12.99 kB\n| [oss-experimental/react/cjs/react.react-server.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react/cjs/react.react-server.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 18.70 kB | 18.62 kB | = | 4.97 kB | 4.96 kB\n| [oss-experimental/react/cjs/react.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react/cjs/react.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 18.09 kB | 18.01 kB | = | 4.69 kB | 4.68 kB\n| [oss-stable/react/cjs/react.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react/cjs/react.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 16.97 kB | 16.89 kB | = | 4.43 kB | 4.42 kB\n| [oss-stable-semver/react/cjs/react.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react/cjs/react.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 16.95 kB | 16.87 kB | = | 4.41 kB | 4.39 kB\n| [oss-stable/react/cjs/react.react-server.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react/cjs/react.react-server.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 15.07 kB | 14.99 kB | = | 4.11 kB | 4.10 kB\n| [oss-stable-semver/react/cjs/react.react-server.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react/cjs/react.react-server.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 15.04 kB | 14.96 kB | = | 4.08 kB | 4.07 kB\n| [facebook-www/React-profiling.classic.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-www/React-profiling.classic.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 23.29 kB | 23.12 kB | = | 5.93 kB | 5.92 kB\n| [facebook-www/React-profiling.modern.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-www/React-profiling.modern.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 23.29 kB | 23.12 kB | = | 5.93 kB | 5.92 kB\n| [facebook-www/React-prod.classic.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-www/React-prod.classic.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 22.86 kB | 22.68 kB | = | 5.85 kB | 5.84 kB\n| [facebook-www/React-prod.modern.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/facebook-www/React-prod.modern.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 22.86 kB | 22.68 kB | = | 5.85 kB | 5.84 kB\n| [oss-experimental/react/cjs/react-jsx-runtime.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react/cjs/react-jsx-runtime.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 0.99 kB | 0.98 kB | = | 0.51 kB | 0.50 kB\n| [oss-stable-semver/react/cjs/react-jsx-runtime.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react/cjs/react-jsx-runtime.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 0.99 kB | 0.98 kB | = | 0.51 kB | 0.50 kB\n| [oss-stable/react/cjs/react-jsx-runtime.production.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react/cjs/react-jsx-runtime.production.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 0.99 kB | 0.98 kB | = | 0.51 kB | 0.50 kB\n| [oss-experimental/react/cjs/react-jsx-runtime.profiling.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-experimental/react/cjs/react-jsx-runtime.profiling.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 0.99 kB | 0.98 kB | = | 0.51 kB | 0.50 kB\n| [oss-stable-semver/react/cjs/react-jsx-runtime.profiling.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable-semver/react/cjs/react-jsx-runtime.profiling.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 0.99 kB | 0.98 kB | = | 0.51 kB | 0.50 kB\n| [oss-stable/react/cjs/react-jsx-runtime.profiling.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/oss-stable/react/cjs/react-jsx-runtime.profiling.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **=** | 0.99 kB | 0.98 kB | = | 0.51 kB | 0.50 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/76716212bbdf6cf29dc0ad6f83424ee84c313d08/files/__test_utils__/ReactAllWarnings.js?compare=f8a8eac86bac406724f327325f804e65e594dd68) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 76716212bbdf6cf29dc0ad6f83424ee84c313d08\n</p>\n"
] | 2024-04-25 17:32:03 | 2024-04-25 17:40:46 | 2024-04-25 17:40:40 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28912', 'html_url': 'https://github.com/facebook/react/pull/28912', 'diff_url': 'https://github.com/facebook/react/pull/28912.diff', 'patch_url': 'https://github.com/facebook/react/pull/28912.patch', 'merged_at': datetime.datetime(2024, 4, 25, 17, 40, 40)} | Rebasing and landing https://github.com/facebook/react/pull/28798
This PR was approved already but held back to give time for the sync. Rebased and landing here without pushing to seb's remote to avoid possibility of lost updates | {'url': 'https://api.github.com/repos/facebook/react/issues/28912/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28912/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28911 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28911/labels{/name} | https://api.github.com/repos/facebook/react/issues/28911/comments | https://api.github.com/repos/facebook/react/issues/28911/events | https://github.com/facebook/react/pull/28911 | 2,263,992,906 | PR_kwDOAJy2Ks5tv2Sd | 28,911 | Go back to shared refs instance object | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'following_url': 'https://api.github.com/users/acdlite/following{/other_user}', 'gists_url': 'https://api.github.com/users/acdlite/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/acdlite/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/acdlite/subscriptions', 'organizations_url': 'https://api.github.com/users/acdlite/orgs', 'repos_url': 'https://api.github.com/users/acdlite/repos', 'events_url': 'https://api.github.com/users/acdlite/events{/privacy}', 'received_events_url': 'https://api.github.com/users/acdlite/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}
{'id': 6688277426, 'node_id': 'LA_kwDOAJy2Ks8AAAABjqcDsg', 'url': 'https://api.github.com/repos/facebook/react/labels/React%2019', 'name': 'React 19', 'color': '263258', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cf5ab8b8b2c92523aba0b982fb403add053a9110...3727294140fb5eb3bba342d968ebadac37466c1a\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/facebook-www/ReactDOM-prod.classic.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 591.14 kB | 591.14 kB | = | 103.91 kB | 103.91 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/facebook-www/ReactDOM-prod.modern.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 567.36 kB | 567.36 kB | = | 100.30 kB | 100.30 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/__test_utils__/ReactAllWarnings.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable-semver/react/cjs/react.production.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/oss-stable-semver/react/cjs/react.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **+0.22%** | 16.91 kB | 16.95 kB | +0.27% | 4.39 kB | 4.41 kB\n| [oss-stable/react/cjs/react.production.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/oss-stable/react/cjs/react.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **+0.22%** | 16.93 kB | 16.97 kB | +0.32% | 4.42 kB | 4.44 kB\n| [oss-experimental/react/cjs/react.production.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/oss-experimental/react/cjs/react.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **+0.21%** | 18.06 kB | 18.09 kB | +0.32% | 4.68 kB | 4.70 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/3727294140fb5eb3bba342d968ebadac37466c1a/files/__test_utils__/ReactAllWarnings.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3727294140fb5eb3bba342d968ebadac37466c1a\n</p>\n"
] | 2024-04-25 16:15:06 | 2024-04-25 17:03:22 | 2024-04-25 17:03:22 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28911', 'html_url': 'https://github.com/facebook/react/pull/28911', 'diff_url': 'https://github.com/facebook/react/pull/28911.diff', 'patch_url': 'https://github.com/facebook/react/pull/28911.patch', 'merged_at': datetime.datetime(2024, 4, 25, 17, 3, 21)} | It turns out we already made refs writable in #25696, which has been in canary for over a year. The approach in that PR also has the benefit of being slightly more perf sensitive because it still uses a shared object until the fiber is mounted. So let's just go back to that. | {'url': 'https://api.github.com/repos/facebook/react/issues/28911/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28911/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28910 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28910/labels{/name} | https://api.github.com/repos/facebook/react/issues/28910/comments | https://api.github.com/repos/facebook/react/issues/28910/events | https://github.com/facebook/react/pull/28910 | 2,263,839,367 | PR_kwDOAJy2Ks5tvUbl | 28,910 | Support ref cleanup function for imperative handle refs | {'login': 'kassens', 'id': 11849, 'node_id': 'MDQ6VXNlcjExODQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/11849?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kassens', 'html_url': 'https://github.com/kassens', 'followers_url': 'https://api.github.com/users/kassens/followers', 'following_url': 'https://api.github.com/users/kassens/following{/other_user}', 'gists_url': 'https://api.github.com/users/kassens/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/kassens/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/kassens/subscriptions', 'organizations_url': 'https://api.github.com/users/kassens/orgs', 'repos_url': 'https://api.github.com/users/kassens/repos', 'events_url': 'https://api.github.com/users/kassens/events{/privacy}', 'received_events_url': 'https://api.github.com/users/kassens/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cf5ab8b8b2c92523aba0b982fb403add053a9110...964ca88aa55f4a0089fc6a259e0ea67728d53f6d\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/964ca88aa55f4a0089fc6a259e0ea67728d53f6d/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/964ca88aa55f4a0089fc6a259e0ea67728d53f6d/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/964ca88aa55f4a0089fc6a259e0ea67728d53f6d/files/facebook-www/ReactDOM-prod.classic.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 591.14 kB | 591.19 kB | +0.03% | 103.91 kB | 103.94 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/964ca88aa55f4a0089fc6a259e0ea67728d53f6d/files/facebook-www/ReactDOM-prod.modern.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 567.36 kB | 567.41 kB | +0.03% | 100.30 kB | 100.33 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/964ca88aa55f4a0089fc6a259e0ea67728d53f6d/files/__test_utils__/ReactAllWarnings.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/964ca88aa55f4a0089fc6a259e0ea67728d53f6d/files/__test_utils__/ReactAllWarnings.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 964ca88aa55f4a0089fc6a259e0ea67728d53f6d\n</p>\n",
"should these double-invoke in StrictMode too then? would it be worth adding a test for an imperative ref in the StrictMode tests? https://github.com/facebook/react/blob/main/packages/react-reconciler/src/__tests__/StrictEffectsModeDefaults-test.internal.js#L411\r\n\r\nmaybe \"DOM refs\" isn't the best terminology for me to use in https://github.com/reactjs/react.dev/pull/6777 – it doesn't seem like that encompasses imperative handle refs clearly",
"@noahlemen Additional StrictMode test would be nice. It \"just\" works already: https://codesandbox.io/p/sandbox/ref-cleanups-forked-ccp74m?file=%2Fsrc%2Findex.js%3A35%2C46"
] | 2024-04-25 15:02:46 | 2024-04-25 17:03:06 | 2024-04-25 16:51:41 | MEMBER | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28910', 'html_url': 'https://github.com/facebook/react/pull/28910', 'diff_url': 'https://github.com/facebook/react/pull/28910.diff', 'patch_url': 'https://github.com/facebook/react/pull/28910.patch', 'merged_at': datetime.datetime(2024, 4, 25, 16, 51, 41)} | Support ref cleanup function for imperative handle refs
| {'url': 'https://api.github.com/repos/facebook/react/issues/28910/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28910/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/28909 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/28909/labels{/name} | https://api.github.com/repos/facebook/react/issues/28909/comments | https://api.github.com/repos/facebook/react/issues/28909/events | https://github.com/facebook/react/pull/28909 | 2,263,787,728 | PR_kwDOAJy2Ks5tvI31 | 28,909 | Reconciler: Change `commitUpdate` signature to account for unused `updatePayload` parameter | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'following_url': 'https://api.github.com/users/eps1lon/following{/other_user}', 'gists_url': 'https://api.github.com/users/eps1lon/gists{/gist_id}', 'starred_url': 'https://api.github.com/users/eps1lon/starred{/owner}{/repo}', 'subscriptions_url': 'https://api.github.com/users/eps1lon/subscriptions', 'organizations_url': 'https://api.github.com/users/eps1lon/orgs', 'repos_url': 'https://api.github.com/users/eps1lon/repos', 'events_url': 'https://api.github.com/users/eps1lon/events{/privacy}', 'received_events_url': 'https://api.github.com/users/eps1lon/received_events', 'type': 'User', 'site_admin': False} | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 1 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\n\nComparing: cf5ab8b8b2c92523aba0b982fb403add053a9110...34fd6896f783fef17534e94b0b66cff3a4efebb4\n\n## Critical size changes\n\nIncludes critical production bundles, as well as any change greater than 2%:\n\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-stable/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/oss-stable/react-dom/cjs/react-dom.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB\n| [oss-experimental/react-dom/cjs/react-dom.production.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/oss-experimental/react-dom/cjs/react-dom.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 6.67 kB | 6.67 kB | +0.11% | 1.83 kB | 1.83 kB\n| [facebook-www/ReactDOM-prod.classic.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/facebook-www/ReactDOM-prod.classic.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 591.14 kB | 591.05 kB | = | 103.91 kB | 103.90 kB\n| [facebook-www/ReactDOM-prod.modern.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/facebook-www/ReactDOM-prod.modern.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 567.36 kB | 567.27 kB | = | 100.30 kB | 100.30 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/__test_utils__/ReactAllWarnings.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n\n## Significant size changes\n\nIncludes any change greater than 0.2%:\n\n\n<details>\n<summary>Expand to show</summary>\n\n | Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |\n | ---- | --- | ---- | ------- | -------- | --------- | ------------ |\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 35.17 kB | 35.08 kB | = | 6.58 kB | 6.57 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 35.17 kB | 35.08 kB | = | 6.58 kB | 6.57 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 35.17 kB | 35.08 kB | = | 6.58 kB | 6.57 kB\n| [oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 35.04 kB | 34.95 kB | = | 6.56 kB | 6.55 kB\n| [oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 35.04 kB | 34.95 kB | = | 6.56 kB | 6.55 kB\n| [oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **=** | 35.04 kB | 34.95 kB | = | 6.56 kB | 6.55 kB\n| [__test_utils__/ReactAllWarnings.js](https://react-builds.vercel.app/commits/34fd6896f783fef17534e94b0b66cff3a4efebb4/files/__test_utils__/ReactAllWarnings.js?compare=cf5ab8b8b2c92523aba0b982fb403add053a9110) | **Deleted** | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB\n</details>\n\n\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 34fd6896f783fef17534e94b0b66cff3a4efebb4\n</p>\n"
] | 2024-04-25 14:45:32 | 2024-04-25 17:14:35 | 2024-04-25 17:14:07 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/28909', 'html_url': 'https://github.com/facebook/react/pull/28909', 'diff_url': 'https://github.com/facebook/react/pull/28909.diff', 'patch_url': 'https://github.com/facebook/react/pull/28909.patch', 'merged_at': datetime.datetime(2024, 4, 25, 17, 14, 7)} | `diffInCommitPhase` is shipped (https://github.com/facebook/react/pull/27409) so we don't need to pass along `updatePayload` which is always `null`. `react-three-fiber` was bailing out if this payload was `null` and therefore never committed any update.
By changing the signature the breakage becomes more obvious. The docs already document the proposed signature: https://github.com/facebook/react/blob/main/packages/react-reconciler/README.md#commitupdateinstance-type-prevprops-nextprops-internalhandle | {'url': 'https://api.github.com/repos/facebook/react/issues/28909/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/28909/timeline | null | null | true |