issue_id
int64
2.03k
426k
title
stringlengths
9
251
body
stringlengths
1
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
unknown
report_datetime
unknown
updated_file
stringlengths
2
187
file_content
stringlengths
0
368k
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
org.eclipse.jdt.ui/ui
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
refactoring/org/eclipse/jdt/internal/ui/refactoring/TextEditChangeElement.java
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
org.eclipse.jdt.ui/ui
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
refactoring/org/eclipse/jdt/internal/ui/refactoring/actions/SurroundWithTryCatchAction.java
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaHierarchyPerspectiveFactory.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui; import org.eclipse.debug.ui.IDebugUIConstants; import org.eclipse.ui.IFolderLayout; import org.eclipse.ui.IPageLayout; import org.eclipse.ui.IPerspectiveFactory; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.ui.JavaUI; public class JavaHierarchyPerspectiveFactory implements IPerspectiveFactory { /** * Constructs a new Java hierarchy layout engine. */ public JavaHierarchyPerspectiveFactory() { super(); } public void createInitialLayout(IPageLayout layout) { String editorArea = layout.getEditorArea(); IFolderLayout folder= layout.createFolder("left", IPageLayout.LEFT, (float)0.25, editorArea); //$NON-NLS-1$ folder.addView(JavaUI.ID_TYPE_HIERARCHY); layout.addActionSet(IDebugUIConstants.DEBUG_ACTION_SET); layout.addActionSet(JavaUI.ID_ACTION_SET); // views - java layout.addShowViewShortcut(JavaUI.ID_PACKAGES); layout.addShowViewShortcut(JavaUI.ID_TYPE_HIERARCHY); layout.addShowViewShortcut(SearchUI.SEARCH_RESULT_VIEW_ID); // views - debugging layout.addShowViewShortcut(IDebugUIConstants.ID_PROCESS_VIEW); layout.addShowViewShortcut(IDebugUIConstants.ID_CONSOLE_VIEW); // views - standard workbench layout.addShowViewShortcut(IPageLayout.ID_OUTLINE); layout.addShowViewShortcut(IPageLayout.ID_TASK_LIST); layout.addShowViewShortcut(IPageLayout.ID_RES_NAV); } }
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPerspectiveFactory.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui; import org.eclipse.ui.IFolderLayout; import org.eclipse.ui.IPageLayout; import org.eclipse.ui.IPerspectiveFactory; import org.eclipse.search.ui.SearchUI; import org.eclipse.debug.ui.IDebugUIConstants; import org.eclipse.jdt.ui.JavaUI; public class JavaPerspectiveFactory implements IPerspectiveFactory { /** * Constructs a new Default layout engine. */ public JavaPerspectiveFactory() { super(); } public void createInitialLayout(IPageLayout layout) { String editorArea = layout.getEditorArea(); IFolderLayout folder= layout.createFolder("left", IPageLayout.LEFT, (float)0.25, editorArea); //$NON-NLS-1$ folder.addView(JavaUI.ID_PACKAGES); folder.addView(JavaUI.ID_TYPE_HIERARCHY); folder.addPlaceholder(IPageLayout.ID_RES_NAV); IFolderLayout outputfolder= layout.createFolder("bottom", IPageLayout.BOTTOM, (float)0.75, editorArea); //$NON-NLS-1$ outputfolder.addView(IPageLayout.ID_TASK_LIST); outputfolder.addView(SearchUI.SEARCH_RESULT_VIEW_ID); outputfolder.addView(IDebugUIConstants.ID_CONSOLE_VIEW); layout.addView(IPageLayout.ID_OUTLINE, IPageLayout.RIGHT, (float)0.75, editorArea); layout.addActionSet(IDebugUIConstants.LAUNCH_ACTION_SET); layout.addActionSet(JavaUI.ID_ACTION_SET); layout.addActionSet(IUIConstants.ID_REFACTORING_ACTION_SET); // views - java layout.addShowViewShortcut(JavaUI.ID_PACKAGES); layout.addShowViewShortcut(JavaUI.ID_TYPE_HIERARCHY); layout.addShowViewShortcut(SearchUI.SEARCH_RESULT_VIEW_ID); // views - debugging layout.addShowViewShortcut(IDebugUIConstants.ID_PROCESS_VIEW); layout.addShowViewShortcut(IDebugUIConstants.ID_CONSOLE_VIEW); // views - standard workbench layout.addShowViewShortcut(IPageLayout.ID_OUTLINE); layout.addShowViewShortcut(IPageLayout.ID_TASK_LIST); layout.addShowViewShortcut(IPageLayout.ID_RES_NAV); // new actions - Java project creation wizard layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewPackageCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewClassCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewInterfaceCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewSourceFolderCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.jdt.ui.wizards.NewSnippetFileCreationWizard"); //$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.ui.wizards.new.folder");//$NON-NLS-1$ layout.addNewWizardShortcut("org.eclipse.ui.wizards.new.file");//$NON-NLS-1$ } }
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dnd/ResourceTransferDragAdapter.java
/* * (c) Copyright 2001 MyCorporation. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dnd; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSourceAdapter; import org.eclipse.swt.dnd.DragSourceEvent; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.ui.part.ResourceTransfer; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaStatusConstants; import org.eclipse.jdt.internal.ui.util.SWTUtil; /** * A drag adapter that transfers the current selection as </code> * IResource</code>. Only those elements in the selection are part * of the transfer which can be converted into an <code>IResource * </code>. */ public class ResourceTransferDragAdapter extends DragSourceAdapter implements TransferDragSourceListener { private ISelectionProvider fProvider; private static final List EMPTY_LIST= new ArrayList(0); /** * Creates a new ResourceTransferDragAdapter for the given selection * provider. * * @param provider the selection provider to access the viewer's selection */ public ResourceTransferDragAdapter(ISelectionProvider provider) { fProvider= provider; Assert.isNotNull(fProvider); } public Transfer getTransfer() { return ResourceTransfer.getInstance(); } public void dragStart(DragSourceEvent event) { event.doit= convertSelection().size() > 0; } public void dragSetData(DragSourceEvent event) { List resources= convertSelection(); event.data= (IResource[]) resources.toArray(new IResource[resources.size()]); } public void dragFinished(DragSourceEvent event) { if (!event.doit) return; if (event.detail == DND.DROP_MOVE) { handleFinishedDropMove(event); } } private List convertSelection() { ISelection s= fProvider.getSelection(); if (!(s instanceof IStructuredSelection)) return EMPTY_LIST; IStructuredSelection selection= (IStructuredSelection)s; List result= new ArrayList(selection.size()); for (Iterator iter= selection.iterator(); iter.hasNext();) { Object element= iter.next(); if (element instanceof IAdaptable) { IAdaptable adaptable= (IAdaptable)element; IResource resource= (IResource)adaptable.getAdapter(IResource.class); if (resource != null) result.add(resource); } } return result; } private void handleFinishedDropMove(DragSourceEvent event) { MultiStatus status= new MultiStatus( JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, "DND: cannot delete resources", null); List resources= convertSelection(); for (Iterator iter= resources.iterator(); iter.hasNext();) { IResource resource= (IResource) iter.next(); try { resource.delete(true, null); } catch (CoreException e) { status.add(e.getStatus()); } } if (status.getChildren().length > 0) { Shell parent= SWTUtil.getShell(event.widget); ErrorDialog error= new ErrorDialog(parent, "Moving Resources via DND", "Cannot delete the following file(s)", status, IStatus.ERROR); error.open(); } } }
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/ContainerCheckedTreeViewer.java
/* * (c) Copyright 2001 MyCorporation. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.viewsupport; import java.util.ArrayList; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Item; import org.eclipse.swt.widgets.Tree; import org.eclipse.swt.widgets.TreeItem; import org.eclipse.swt.widgets.Widget; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTreeViewer; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.ITreeViewerListener; import org.eclipse.jface.viewers.TreeExpansionEvent; /** * CheckboxTreeViewer with special behaviour of the checked / gray state on * container (non-leaf) nodes: * The grayed state is used to visualize the checked state of its children. * Containers are checked and non-gary if all contained leafs are checked. The * container is grayed if some but not all leafs are checked. */ public class ContainerCheckedTreeViewer extends CheckboxTreeViewer { /** * Constructor for ContainerCheckedTreeViewer. * @see CheckboxTreeViewer#CheckboxTreeViewer(Composite) */ public ContainerCheckedTreeViewer(Composite parent) { super(parent); initViewer(); } /** * Constructor for ContainerCheckedTreeViewer. * @see CheckboxTreeViewer#CheckboxTreeViewer(Composite,int) */ public ContainerCheckedTreeViewer(Composite parent, int style) { super(parent, style); initViewer(); } /** * Constructor for ContainerCheckedTreeViewer. * @see CheckboxTreeViewer#CheckboxTreeViewer(Tree) */ public ContainerCheckedTreeViewer(Tree tree) { super(tree); initViewer(); } private void initViewer() { setUseHashlookup(true); addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { doCheckStateChanged(event.getElement()); } }); addTreeListener(new ITreeViewerListener() { public void treeCollapsed(TreeExpansionEvent event) { } public void treeExpanded(TreeExpansionEvent event) { Widget item= findItem(event.getElement()); if (item instanceof TreeItem) { initializeItem((TreeItem) item); } } }); } protected void doCheckStateChanged(Object element) { Widget item= findItem(element); if (item instanceof TreeItem) { TreeItem treeItem= (TreeItem) item; treeItem.setGrayed(false); updateChildrenItems(treeItem); updateParentItems(treeItem.getParentItem()); } } /** * The item has expanded. Updates the checked state of its children. */ private void initializeItem(TreeItem item) { if (item.getChecked() && !item.getGrayed()) { updateChildrenItems((TreeItem) item); } } /** * Updates the check state of all created children */ private void updateChildrenItems(TreeItem parent) { Item[] children= getChildren(parent); boolean state= parent.getChecked(); for (int i= 0; i < children.length; i++) { TreeItem curr= (TreeItem) children[i]; if (curr.getData() != null && ((curr.getChecked() != state) || curr.getGrayed())) { curr.setChecked(state); curr.setGrayed(false); updateChildrenItems(curr); } } } /** * Updates the check / gray state of all parent items */ private void updateParentItems(TreeItem item) { if (item != null) { Item[] children= getChildren(item); boolean containsChecked= false; boolean containsUnchecked= false; for (int i= 0; i < children.length; i++) { TreeItem curr= (TreeItem) children[i]; containsChecked |= curr.getChecked(); containsUnchecked |= (!curr.getChecked() || curr.getGrayed()); } item.setChecked(containsChecked); item.setGrayed(containsChecked && containsUnchecked); updateParentItems(item.getParentItem()); } } /* * @see ICheckable#setChecked(Object, boolean) */ public boolean setChecked(Object element, boolean state) { if (super.setChecked(element, state)) { doCheckStateChanged(element); return true; } return false; } /* * @see CheckboxTreeViewer#setCheckedElements(Object[]) */ public void setCheckedElements(Object[] elements) { super.setCheckedElements(elements); for (int i= 0; i < elements.length; i++) { doCheckStateChanged(elements[i]); } } /* * @see AbstractTreeViewer#setExpanded(Item, boolean) */ protected void setExpanded(Item item, boolean expand) { super.setExpanded(item, expand); if (expand && item instanceof TreeItem) { initializeItem((TreeItem) item); } } /* * @see CheckboxTreeViewer#getCheckedElements() */ public Object[] getCheckedElements() { Object[] checked= super.getCheckedElements(); // add all items that are children of a checked node but not created yet ArrayList result= new ArrayList(); for (int i= 0; i < checked.length; i++) { Object curr= checked[i]; result.add(curr); Widget item= findItem(curr); if (item != null) { Item[] children= getChildren(item); // check if contains the dummy node if (children.length == 1 && children[0].getData() == null) { // not yet created collectChildren(curr, result); } } } return result.toArray(); } private void collectChildren(Object element, ArrayList result) { Object[] filteredChildren= getFilteredChildren(element); for (int i= 0; i < filteredChildren.length; i++) { Object curr= filteredChildren[i]; result.add(curr); collectChildren(curr, result); } } }
7,127
Bug 7127 'refactor' menu missing from the type hierarchy perspective
the 'refactor' menu is missing from the type hierarchy perspective
resolved fixed
0c1b5e6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T15:20:36Z"
"2001-12-20T12:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/JavaUI.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.ui; import java.util.ArrayList; import java.util.Arrays; import java.util.Iterator; import java.util.List; import java.util.Set; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IProject; import org.eclipse.jface.operation.IRunnableContext; import org.eclipse.jface.util.Assert; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.PartInitException; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.SharedImages; import org.eclipse.jdt.internal.ui.dialogs.AbstractElementListSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.MainTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.MultiMainTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.MultiTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.TypeSelectionDialog; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; /** * Central access point for the Java UI plug-in (id <code>"org.eclipse.jdt.ui"</code>). * This class provides static methods for: * <ul> * <li> creating various kinds of selection dialogs to present a collection * of Java elements to the user and let them make a selection.</li> * <li> opening a Java editor on a compilation unit.</li> * </ul> * <p> * This class provides static methods and fields only; it is not intended to be * instantiated or subclassed by clients. * </p> */ public final class JavaUI { private static ISharedImages fgSharedImages= null; private JavaUI() { // prevent instantiation of JavaUI. } /** * The id of the Java plugin (value <code>"org.eclipse.jdt.ui"</code>). */ public static final String ID_PLUGIN= "org.eclipse.jdt.ui"; //$NON-NLS-1$ /** * The id of the Java perspective * (value <code>"org.eclipse.jdt.ui.JavaPerspective"</code>). */ public static final String ID_PERSPECTIVE= "org.eclipse.jdt.ui.JavaPerspective"; //$NON-NLS-1$ /** * The id of the Java hierarchy perspective * (value <code>"org.eclipse.jdt.ui.JavaHierarchyPerspective"</code>). */ public static final String ID_HIERARCHYPERSPECTIVE= "org.eclipse.jdt.ui.JavaHierarchyPerspective"; //$NON-NLS-1$ /** * The id of the Java action set * (value <code>"org.eclipse.jdt.ui.JavaActionSet"</code>). */ public static final String ID_ACTION_SET= "org.eclipse.jdt.ui.JavaActionSet"; //$NON-NLS-1$ /** * The editor part id of the editor that presents Java compilation units * (value <code>"org.eclipse.jdt.ui.CompilationUnitEditor"</code>). */ public static final String ID_CU_EDITOR= "org.eclipse.jdt.ui.CompilationUnitEditor"; //$NON-NLS-1$ /** * The editor part id of the editor that presents Java binary class files * (value <code>"org.eclipse.jdt.ui.ClassFileEditor"</code>). */ public static final String ID_CF_EDITOR= "org.eclipse.jdt.ui.ClassFileEditor"; //$NON-NLS-1$ /** * The editor part id of the code snippet editor * (value <code>"org.eclipse.jdt.ui.SnippetEditor"</code>). */ public static final String ID_SNIPPET_EDITOR= "org.eclipse.jdt.ui.SnippetEditor"; //$NON-NLS-1$ /** * The view part id of the Packages view * (value <code>"org.eclipse.jdt.ui.PackageExplorer"</code>). * <p> * When this id is used to access * a view part with <code>IWorkbenchPage.findView</code> or * <code>showView</code>, the returned <code>IViewPart</code> * can be safely cast to an <code>IPackagesViewPart</code>. * </p> * * @see IPackagesViewPart * @see org.eclipse.ui.IWorkbenchPage#findView * @see org.eclipse.ui.IWorkbenchPage#showView */ public static final String ID_PACKAGES= "org.eclipse.jdt.ui.PackageExplorer"; //$NON-NLS-1$ /** * The view part id of the type hierarchy part. * (value <code>"org.eclipse.jdt.ui.TypeHierarchy"</code>). * <p> * When this id is used to access * a view part with <code>IWorkbenchPage.findView</code> or * <code>showView</code>, the returned <code>IViewPart</code> * can be safely cast to an <code>ITypeHierarchyViewPart</code>. * </p> * * @see ITypeHierarchyViewPart * @see org.eclipse.ui.IWorkbenchPage#findView * @see org.eclipse.ui.IWorkbenchPage#showView */ public static final String ID_TYPE_HIERARCHY= "org.eclipse.jdt.ui.TypeHierarchy"; //$NON-NLS-1$ /** * The class org.eclipse.debug.core.model.IProcess allows attaching * String properties to processes. The Java UI contributes a property * page for IProcess that will show the contents of the property * with this key. * The intent of this property is to show the command line a process * was launched with. * @deprecated */ public final static String ATTR_CMDLINE= JavaPlugin.getPluginId()+".launcher.cmdLine"; //$NON-NLS-1$ /** * Returns the shared images for the Java UI. * * @return the shared images manager */ public static ISharedImages getSharedImages() { if (fgSharedImages == null) fgSharedImages= new SharedImages(); return fgSharedImages; } /** * Creates a selection dialog that lists all packages of the given Java project. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IPackageFragment</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param project the Java project * @param style flags defining the style of the dialog; the valid flags are: * <code>IJavaElementSearchConstants.CONSIDER_BINARIES</code>, indicating that * packages from binary package fragment roots should be included in addition * to those from source package fragment roots; * <code>IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS</code>, indicating that * packages from required projects should be included as well. * @param filter the filter * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createPackageDialog(Shell parent, IJavaProject project, int style, String filter) throws JavaModelException { Assert.isTrue((style | IJavaElementSearchConstants.CONSIDER_BINARIES | IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS) == (IJavaElementSearchConstants.CONSIDER_BINARIES | IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS)); IPackageFragmentRoot[] roots= null; if ((style & IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS) != 0) { roots= project.getAllPackageFragmentRoots(); } else { roots= project.getPackageFragmentRoots(); } List consideredRoots= null; if ((style & IJavaElementSearchConstants.CONSIDER_BINARIES) != 0) { consideredRoots= Arrays.asList(roots); } else { consideredRoots= new ArrayList(roots.length); for (int i= 0; i < roots.length; i++) { IPackageFragmentRoot root= roots[i]; if (root.getKind() != IPackageFragmentRoot.K_BINARY) consideredRoots.add(root); } } int flags= JavaElementLabelProvider.SHOW_DEFAULT; if (consideredRoots.size() > 1) flags= flags | JavaElementLabelProvider.SHOW_ROOT; List packages= new ArrayList(); Iterator iter= consideredRoots.iterator(); while(iter.hasNext()) { IPackageFragmentRoot root= (IPackageFragmentRoot)iter.next(); packages.addAll(Arrays.asList(root.getChildren())); } ElementListSelectionDialog dialog= new ElementListSelectionDialog(parent, new JavaElementLabelProvider(flags)); dialog.setIgnoreCase(false); dialog.setElements(packages.toArray()); // XXX inefficient dialog.setFilter(filter); return dialog; } /** * @see createPackageDialog(Shell,IJavaProject,int,String) */ public static SelectionDialog createPackageDialog(Shell parent, IJavaProject project, int style) throws JavaModelException { return createPackageDialog(parent, project, style, "A"); //$NON-NLS-1$ } /** * Creates a selection dialog that lists all packages under the given package * fragment root. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IPackageFragment</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param root the package fragment root * @param filter the filter * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createPackageDialog(Shell parent, IPackageFragmentRoot root, String filter) throws JavaModelException { ElementListSelectionDialog dialog= new ElementListSelectionDialog(parent, new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT)); dialog.setIgnoreCase(false); dialog.setElements(root.getChildren()); dialog.setFilter(filter); return dialog; } /** * @see createPackageDialog(Shell,IPackageFragmentRoot) */ public static SelectionDialog createPackageDialog(Shell parent, IPackageFragmentRoot root) throws JavaModelException { return createPackageDialog(parent, root, "A"); //$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given scope. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param scope the scope that limits which types are included * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_CLASSES</code>, * <code>CONSIDER_INTERFACES</code>, or their bitwise OR * (equivalent to <code>CONSIDER_TYPES</code>) * @param multipleSelection <code>true</code> if multiple selection is allowed * @param filter the filter * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection, String filter) throws JavaModelException { Assert.isTrue((style | IJavaElementSearchConstants.CONSIDER_TYPES) == IJavaElementSearchConstants.CONSIDER_TYPES); if (multipleSelection) { MultiTypeSelectionDialog dialog= new MultiTypeSelectionDialog(parent, context, scope, style); dialog.setFilter(filter); return dialog; } else { TypeSelectionDialog dialog= new TypeSelectionDialog(parent, context, scope, style); dialog.setFilter(filter); return dialog; } } /** * @see createTypeDialog(Shell,IRunnableContext,IJavaSearchScope,int,boolean,String) */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection) throws JavaModelException { return createTypeDialog(parent, context, scope, style, multipleSelection, "A");//$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given scope containing * a standard <code>main</code> method. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * <p> * [Issue: IJavaSearchScope is not currently part of the Java core API.] * </p> * <p> * [Issue: SelectionDialogs must be parented. shell must not be null.] * </p> * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param scope the scope that limits which types are included * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_BINARIES</code>, * <code>CONSIDER_EXTERNAL_JARS</code>, or their bitwise OR, or <code>0</code> * @param multipleSelection <code>true</code> if multiple selection is allowed * @param filter the filter * @return a new selection dialog */ public static SelectionDialog createMainTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection, String filter) { AbstractElementListSelectionDialog dialog= null; if (multipleSelection) { dialog= new MultiMainTypeSelectionDialog(parent, context, scope, style); } else { dialog= new MainTypeSelectionDialog(parent, context, scope, style); } dialog.setFilter(filter); return dialog; } /** * @see createMainTypeDialog(Shell,IRunnableContext,IJavaSearchScope,int,boolean,String) */ public static SelectionDialog createMainTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection) { return createMainTypeDialog(parent, context, scope, style, multipleSelection, "A");//$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given project. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param project the Java project * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_CLASSES</code>, * <code>CONSIDER_INTERFACES</code>, or their bitwise OR * (equivalent to <code>CONSIDER_TYPES</code>) * @param multipleSelection <code>true</code> if multiple selection is allowed * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IProject project, int style, boolean multipleSelection) throws JavaModelException { IJavaSearchScope scope= SearchEngine.createJavaSearchScope(new IJavaProject[] { JavaCore.create(project) }); return createTypeDialog(parent, context, scope, style, multipleSelection); } /** * Opens a Java editor on the given Java compilation unit of class file. * If there already is an open Java editor for the given element, it is returned. * <p> * [Issue: Explain semantics of opening an editor on a class file.] * </p> * <p> * [Issue: Explain under which conditions it returns null, throws JavaModelException, * or throws JavaModelException. * ] * </p> * * @param element the input element; either a compilation unit * (<code>ICompilationUnit</code>) or a class file (</code>IClassFile</code>) * @return the editor, or </code>null</code> if wrong element type or opening failed * @exception PartInitException if the editor could not be initialized * @exception JavaModelException if this element does not exist or if an * exception occurs while accessing its underlying resource */ public static IEditorPart openInEditor(IJavaElement element) throws JavaModelException, PartInitException { return EditorUtility.openInEditor(element); } /** * Reveals the source range of the given source reference element in the * given editor. No checking is done if the editor displays a compilation unit or * class file that contains the given source reference. * <p> * [Issue: Explain what is meant by that last sentence.] * </p> * <p> * [Issue: Explain what happens if the source reference is from some other * compilation unit, editor is not open, etc.] * </p> * * @param part the editor displaying the compilation unit or class file * @param element the source reference element defining the source range to be revealed * * @deprecated use <code>revealInEditor(IEditorPart, IJavaElement)</code> instead */ public static void revealInEditor(IEditorPart part, ISourceReference element) { if (element instanceof IJavaElement) revealInEditor(part, (IJavaElement) element); } /** * Reveals the given java element in the given editor. No checking is done if the * editor displays a compilation unit or class file that contains the given element. * If the element is not contained, nothing happens. * @param part the editor displaying a compilation unit or class file * @param element the element to be revealed */ public static void revealInEditor(IEditorPart part, IJavaElement element) { EditorUtility.revealInEditor(part, element); } /** * Returns the working copy manager for the Java UI plug-in. * * @return the working copy manager for the Java UI plug-in */ public static IWorkingCopyManager getWorkingCopyManager() { return JavaPlugin.getDefault().getWorkingCopyManager(); } }
3,963
Bug 3963 Clean up the [Issues] in javadoc (1GF9P7T)
Search for Issues in our plug-ins and clean up. This was found for JDT: org.eclipse.jdt.ui.wizards.NewJavaProjectWizardPage * [Issue: It is slightly unfortunate to make appeal to a preference in an API * method but not expose that preference as API. * ] public void setDefaultClassPath(IClasspathEntry[] entries, boolean appendDefaultJRE) { ==> There's a setter but no getter. This is a designed. Remove the Issue comment. org.eclipse.jdt.ui.JavaUI * [Issue: SelectionDialogs must be parented. shell must not be null.] * @param parent the parent shell of the dialog to be created public static SelectionDialog createMainTypeDialog(Shell parent, IRunnableContext cont... ==> This is a designed: we want to allow unparented dialogs. Remove the Issue comment. * [Issue: Explain semantics of opening an editor on a class file.] * </p> * <p> * [Issue: Explain under which conditions it returns null, throws JavaModelException, * or throws JavaModelException. * ] * </p> * @param element the input element; either a compilation unit * (<code>ICompilationUnit</code>) or a class file (</code>IClassFile</code>) * @return the editor, or </code>null</code> if wrong element type or opening failed * @exception PartInitException if the editor could not be initialized * @exception JavaModelException if this element does not exist or if an * exception occurs while accessing its underlying resource */ public static IEditorPart openInEditor(IJavaElement element) throws JavaModelException, PartInitException { ==> Better explanation would be good. * Reveals the source range of the given source reference element in the * given editor. No checking is done if the editor displays a compilation unit or * class file that contains the given source reference. * <p> * [Issue: Explain what is meant by that last sentence.] * </p> * <p> * [Issue: Explain what happens if the source reference is from some other * compilation unit, editor is not open, etc.] * </p> public static void revealInEditor(IEditorPart part, ISourceReference element) { ==> Better explanation would be good. PackageViewer // defensive code. Multithread issue? if (item.isDisposed()) ==> Would write: // guard for thread safety --- or --- remove the ? NOTES:
resolved fixed
c5b5154
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T16:42:37Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/JavaUI.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.ui; import java.util.ArrayList; import java.util.Arrays; import java.util.Iterator; import java.util.List; import java.util.Set; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IProject; import org.eclipse.jface.operation.IRunnableContext; import org.eclipse.jface.util.Assert; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.PartInitException; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.SharedImages; import org.eclipse.jdt.internal.ui.dialogs.AbstractElementListSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.MainTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.MultiMainTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.MultiTypeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.TypeSelectionDialog; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; /** * Central access point for the Java UI plug-in (id <code>"org.eclipse.jdt.ui"</code>). * This class provides static methods for: * <ul> * <li> creating various kinds of selection dialogs to present a collection * of Java elements to the user and let them make a selection.</li> * <li> opening a Java editor on a compilation unit.</li> * </ul> * <p> * This class provides static methods and fields only; it is not intended to be * instantiated or subclassed by clients. * </p> */ public final class JavaUI { private static ISharedImages fgSharedImages= null; private JavaUI() { // prevent instantiation of JavaUI. } /** * The id of the Java plugin (value <code>"org.eclipse.jdt.ui"</code>). */ public static final String ID_PLUGIN= "org.eclipse.jdt.ui"; //$NON-NLS-1$ /** * The id of the Java perspective * (value <code>"org.eclipse.jdt.ui.JavaPerspective"</code>). */ public static final String ID_PERSPECTIVE= "org.eclipse.jdt.ui.JavaPerspective"; //$NON-NLS-1$ /** * The id of the Java hierarchy perspective * (value <code>"org.eclipse.jdt.ui.JavaHierarchyPerspective"</code>). */ public static final String ID_HIERARCHYPERSPECTIVE= "org.eclipse.jdt.ui.JavaHierarchyPerspective"; //$NON-NLS-1$ /** * The id of the Java action set * (value <code>"org.eclipse.jdt.ui.JavaActionSet"</code>). */ public static final String ID_ACTION_SET= "org.eclipse.jdt.ui.JavaActionSet"; //$NON-NLS-1$ /** * The id of the Java Element Creation action set. */ public static final String ID_ELEMENT_CREATION_ACTION_SET= "org.eclipse.jdt.ui.JavaElementCreationActionSet"; //$NON-NLS-1$ /** * The editor part id of the editor that presents Java compilation units * (value <code>"org.eclipse.jdt.ui.CompilationUnitEditor"</code>). */ public static final String ID_CU_EDITOR= "org.eclipse.jdt.ui.CompilationUnitEditor"; //$NON-NLS-1$ /** * The editor part id of the editor that presents Java binary class files * (value <code>"org.eclipse.jdt.ui.ClassFileEditor"</code>). */ public static final String ID_CF_EDITOR= "org.eclipse.jdt.ui.ClassFileEditor"; //$NON-NLS-1$ /** * The editor part id of the code snippet editor * (value <code>"org.eclipse.jdt.ui.SnippetEditor"</code>). */ public static final String ID_SNIPPET_EDITOR= "org.eclipse.jdt.ui.SnippetEditor"; //$NON-NLS-1$ /** * The view part id of the Packages view * (value <code>"org.eclipse.jdt.ui.PackageExplorer"</code>). * <p> * When this id is used to access * a view part with <code>IWorkbenchPage.findView</code> or * <code>showView</code>, the returned <code>IViewPart</code> * can be safely cast to an <code>IPackagesViewPart</code>. * </p> * * @see IPackagesViewPart * @see org.eclipse.ui.IWorkbenchPage#findView * @see org.eclipse.ui.IWorkbenchPage#showView */ public static final String ID_PACKAGES= "org.eclipse.jdt.ui.PackageExplorer"; //$NON-NLS-1$ /** * The view part id of the type hierarchy part. * (value <code>"org.eclipse.jdt.ui.TypeHierarchy"</code>). * <p> * When this id is used to access * a view part with <code>IWorkbenchPage.findView</code> or * <code>showView</code>, the returned <code>IViewPart</code> * can be safely cast to an <code>ITypeHierarchyViewPart</code>. * </p> * * @see ITypeHierarchyViewPart * @see org.eclipse.ui.IWorkbenchPage#findView * @see org.eclipse.ui.IWorkbenchPage#showView */ public static final String ID_TYPE_HIERARCHY= "org.eclipse.jdt.ui.TypeHierarchy"; //$NON-NLS-1$ /** * The class org.eclipse.debug.core.model.IProcess allows attaching * String properties to processes. The Java UI contributes a property * page for IProcess that will show the contents of the property * with this key. * The intent of this property is to show the command line a process * was launched with. * @deprecated */ public final static String ATTR_CMDLINE= JavaPlugin.getPluginId()+".launcher.cmdLine"; //$NON-NLS-1$ /** * Returns the shared images for the Java UI. * * @return the shared images manager */ public static ISharedImages getSharedImages() { if (fgSharedImages == null) fgSharedImages= new SharedImages(); return fgSharedImages; } /** * Creates a selection dialog that lists all packages of the given Java project. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IPackageFragment</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param project the Java project * @param style flags defining the style of the dialog; the valid flags are: * <code>IJavaElementSearchConstants.CONSIDER_BINARIES</code>, indicating that * packages from binary package fragment roots should be included in addition * to those from source package fragment roots; * <code>IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS</code>, indicating that * packages from required projects should be included as well. * @param filter the filter * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createPackageDialog(Shell parent, IJavaProject project, int style, String filter) throws JavaModelException { Assert.isTrue((style | IJavaElementSearchConstants.CONSIDER_BINARIES | IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS) == (IJavaElementSearchConstants.CONSIDER_BINARIES | IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS)); IPackageFragmentRoot[] roots= null; if ((style & IJavaElementSearchConstants.CONSIDER_REQUIRED_PROJECTS) != 0) { roots= project.getAllPackageFragmentRoots(); } else { roots= project.getPackageFragmentRoots(); } List consideredRoots= null; if ((style & IJavaElementSearchConstants.CONSIDER_BINARIES) != 0) { consideredRoots= Arrays.asList(roots); } else { consideredRoots= new ArrayList(roots.length); for (int i= 0; i < roots.length; i++) { IPackageFragmentRoot root= roots[i]; if (root.getKind() != IPackageFragmentRoot.K_BINARY) consideredRoots.add(root); } } int flags= JavaElementLabelProvider.SHOW_DEFAULT; if (consideredRoots.size() > 1) flags= flags | JavaElementLabelProvider.SHOW_ROOT; List packages= new ArrayList(); Iterator iter= consideredRoots.iterator(); while(iter.hasNext()) { IPackageFragmentRoot root= (IPackageFragmentRoot)iter.next(); packages.addAll(Arrays.asList(root.getChildren())); } ElementListSelectionDialog dialog= new ElementListSelectionDialog(parent, new JavaElementLabelProvider(flags)); dialog.setIgnoreCase(false); dialog.setElements(packages.toArray()); // XXX inefficient dialog.setFilter(filter); return dialog; } /** * @see createPackageDialog(Shell,IJavaProject,int,String) */ public static SelectionDialog createPackageDialog(Shell parent, IJavaProject project, int style) throws JavaModelException { return createPackageDialog(parent, project, style, "A"); //$NON-NLS-1$ } /** * Creates a selection dialog that lists all packages under the given package * fragment root. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IPackageFragment</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param root the package fragment root * @param filter the filter * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createPackageDialog(Shell parent, IPackageFragmentRoot root, String filter) throws JavaModelException { ElementListSelectionDialog dialog= new ElementListSelectionDialog(parent, new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT)); dialog.setIgnoreCase(false); dialog.setElements(root.getChildren()); dialog.setFilter(filter); return dialog; } /** * @see createPackageDialog(Shell,IPackageFragmentRoot) */ public static SelectionDialog createPackageDialog(Shell parent, IPackageFragmentRoot root) throws JavaModelException { return createPackageDialog(parent, root, "A"); //$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given scope. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param scope the scope that limits which types are included * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_CLASSES</code>, * <code>CONSIDER_INTERFACES</code>, or their bitwise OR * (equivalent to <code>CONSIDER_TYPES</code>) * @param multipleSelection <code>true</code> if multiple selection is allowed * @param filter the filter * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection, String filter) throws JavaModelException { Assert.isTrue((style | IJavaElementSearchConstants.CONSIDER_TYPES) == IJavaElementSearchConstants.CONSIDER_TYPES); if (multipleSelection) { MultiTypeSelectionDialog dialog= new MultiTypeSelectionDialog(parent, context, scope, style); dialog.setFilter(filter); return dialog; } else { TypeSelectionDialog dialog= new TypeSelectionDialog(parent, context, scope, style); dialog.setFilter(filter); return dialog; } } /** * @see createTypeDialog(Shell,IRunnableContext,IJavaSearchScope,int,boolean,String) */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection) throws JavaModelException { return createTypeDialog(parent, context, scope, style, multipleSelection, "A");//$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given scope containing * a standard <code>main</code> method. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * <p> * [Issue: IJavaSearchScope is not currently part of the Java core API.] * </p> * <p> * [Issue: SelectionDialogs must be parented. shell must not be null.] * </p> * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param scope the scope that limits which types are included * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_BINARIES</code>, * <code>CONSIDER_EXTERNAL_JARS</code>, or their bitwise OR, or <code>0</code> * @param multipleSelection <code>true</code> if multiple selection is allowed * @param filter the filter * @return a new selection dialog */ public static SelectionDialog createMainTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection, String filter) { AbstractElementListSelectionDialog dialog= null; if (multipleSelection) { dialog= new MultiMainTypeSelectionDialog(parent, context, scope, style); } else { dialog= new MainTypeSelectionDialog(parent, context, scope, style); } dialog.setFilter(filter); return dialog; } /** * @see createMainTypeDialog(Shell,IRunnableContext,IJavaSearchScope,int,boolean,String) */ public static SelectionDialog createMainTypeDialog(Shell parent, IRunnableContext context, IJavaSearchScope scope, int style, boolean multipleSelection) { return createMainTypeDialog(parent, context, scope, style, multipleSelection, "A");//$NON-NLS-1$ } /** * Creates a selection dialog that lists all types in the given project. * The caller is responsible for opening the dialog with <code>Window.open</code>, * and subsequently extracting the selected packages (of type * <code>IType</code>) via <code>SelectionDialog.getResult</code>. * * @param parent the parent shell of the dialog to be created * @param context the runnable context used to show progress when the dialog * is being populated * @param project the Java project * @param style flags defining the style of the dialog; the only valid values are * <code>IJavaElementSearchConstants.CONSIDER_CLASSES</code>, * <code>CONSIDER_INTERFACES</code>, or their bitwise OR * (equivalent to <code>CONSIDER_TYPES</code>) * @param multipleSelection <code>true</code> if multiple selection is allowed * @return a new selection dialog * @exception JavaModelException if the selection dialog could not be opened */ public static SelectionDialog createTypeDialog(Shell parent, IRunnableContext context, IProject project, int style, boolean multipleSelection) throws JavaModelException { IJavaSearchScope scope= SearchEngine.createJavaSearchScope(new IJavaProject[] { JavaCore.create(project) }); return createTypeDialog(parent, context, scope, style, multipleSelection); } /** * Opens a Java editor on the given Java compilation unit of class file. * If there already is an open Java editor for the given element, it is returned. * <p> * [Issue: Explain semantics of opening an editor on a class file.] * </p> * <p> * [Issue: Explain under which conditions it returns null, throws JavaModelException, * or throws JavaModelException. * ] * </p> * * @param element the input element; either a compilation unit * (<code>ICompilationUnit</code>) or a class file (</code>IClassFile</code>) * @return the editor, or </code>null</code> if wrong element type or opening failed * @exception PartInitException if the editor could not be initialized * @exception JavaModelException if this element does not exist or if an * exception occurs while accessing its underlying resource */ public static IEditorPart openInEditor(IJavaElement element) throws JavaModelException, PartInitException { return EditorUtility.openInEditor(element); } /** * Reveals the source range of the given source reference element in the * given editor. No checking is done if the editor displays a compilation unit or * class file that contains the given source reference. * <p> * [Issue: Explain what is meant by that last sentence.] * </p> * <p> * [Issue: Explain what happens if the source reference is from some other * compilation unit, editor is not open, etc.] * </p> * * @param part the editor displaying the compilation unit or class file * @param element the source reference element defining the source range to be revealed * * @deprecated use <code>revealInEditor(IEditorPart, IJavaElement)</code> instead */ public static void revealInEditor(IEditorPart part, ISourceReference element) { if (element instanceof IJavaElement) revealInEditor(part, (IJavaElement) element); } /** * Reveals the given java element in the given editor. No checking is done if the * editor displays a compilation unit or class file that contains the given element. * If the element is not contained, nothing happens. * @param part the editor displaying a compilation unit or class file * @param element the element to be revealed */ public static void revealInEditor(IEditorPart part, IJavaElement element) { EditorUtility.revealInEditor(part, element); } /** * Returns the working copy manager for the Java UI plug-in. * * @return the working copy manager for the Java UI plug-in */ public static IWorkingCopyManager getWorkingCopyManager() { return JavaPlugin.getDefault().getWorkingCopyManager(); } }
7,469
Bug 7469 Preferences -> Java -> Templates
The template body editor window at the bottom part of a Templates preferences page should contain both vertical and horizontal scroll bars.
resolved fixed
b728519
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-16T17:13:56Z"
"2002-01-11T09:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/TemplatePreferencePage.java
package org.eclipse.jdt.internal.ui.preferences; import java.io.File; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.FileDialog; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableColumn; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTableViewer; import org.eclipse.jface.viewers.ColumnWeightData; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TableLayout; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.text.template.Template; import org.eclipse.jdt.internal.ui.text.template.TemplateContentProvider; import org.eclipse.jdt.internal.ui.text.template.TemplateContext; import org.eclipse.jdt.internal.ui.text.template.TemplateLabelProvider; import org.eclipse.jdt.internal.ui.text.template.TemplateMessages; import org.eclipse.jdt.internal.ui.text.template.TemplateSet; import org.eclipse.jdt.internal.ui.text.template.Templates; import org.eclipse.jdt.internal.ui.util.SWTUtil; public class TemplatePreferencePage extends PreferencePage implements IWorkbenchPreferencePage { // preference store keys private static final String PREF_FORMAT_TEMPLATES= JavaUI.ID_PLUGIN + ".template.format"; //$NON-NLS-1$ private Templates fTemplates; private CheckboxTableViewer fTableViewer; private Button fAddButton; private Button fEditButton; private Button fImportButton; private Button fExportButton; private Button fExportAllButton; private Button fRemoveButton; private Button fEnableAllButton; private Button fDisableAllButton; private SourceViewer fPatternViewer; private Button fFormatButton; public TemplatePreferencePage() { super(); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(TemplateMessages.getString("TemplatePreferencePage.message")); //$NON-NLS-1$ fTemplates= Templates.getInstance(); } /** * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite ancestor) { Composite parent= new Composite(ancestor, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; parent.setLayout(layout); Table table= new Table(parent, SWT.CHECK | SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION); GridData data= new GridData(GridData.FILL_BOTH); data.widthHint= convertWidthInCharsToPixels(80); data.heightHint= convertHeightInCharsToPixels(10); table.setLayoutData(data); table.setHeaderVisible(true); table.setLinesVisible(true); TableLayout tableLayout= new TableLayout(); table.setLayout(tableLayout); TableColumn column1= new TableColumn(table, SWT.NONE); column1.setText(TemplateMessages.getString("TemplatePreferencePage.column.name")); //$NON-NLS-1$ TableColumn column2= new TableColumn(table, SWT.NONE); column2.setText(TemplateMessages.getString("TemplatePreferencePage.column.context")); //$NON-NLS-1$ TableColumn column3= new TableColumn(table, SWT.NONE); column3.setText(TemplateMessages.getString("TemplatePreferencePage.column.description")); //$NON-NLS-1$ tableLayout.addColumnData(new ColumnWeightData(30)); tableLayout.addColumnData(new ColumnWeightData(20)); tableLayout.addColumnData(new ColumnWeightData(70)); fTableViewer= new CheckboxTableViewer(table); fTableViewer.setLabelProvider(new TemplateLabelProvider()); fTableViewer.setContentProvider(new TemplateContentProvider()); fTableViewer.setSorter(new ViewerSorter() { public int compare(Viewer viewer, Object object1, Object object2) { if ((object1 instanceof Template) && (object2 instanceof Template)) { Template left= (Template) object1; Template right= (Template) object2; int result= left.getName().compareToIgnoreCase(right.getName()); if (result != 0) return result; return left.getDescription().compareToIgnoreCase(right.getDescription()); } return super.compare(viewer, object1, object2); } public boolean isSorterProperty(Object element, String property) { return true; } }); fTableViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent e) { edit(); } }); fTableViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent e) { selectionChanged1(); } }); fTableViewer.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { Template template= (Template) event.getElement(); template.setEnabled(event.getChecked()); } }); Composite buttons= new Composite(parent, SWT.NULL); buttons.setLayoutData(new GridData(GridData.VERTICAL_ALIGN_BEGINNING)); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; buttons.setLayout(layout); fAddButton= new Button(buttons, SWT.PUSH); fAddButton.setLayoutData(getButtonGridData(fAddButton)); fAddButton.setText(TemplateMessages.getString("TemplatePreferencePage.new")); //$NON-NLS-1$ fAddButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { add(); } }); fEditButton= new Button(buttons, SWT.PUSH); fEditButton.setLayoutData(getButtonGridData(fEditButton)); fEditButton.setText(TemplateMessages.getString("TemplatePreferencePage.edit")); //$NON-NLS-1$ fEditButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { edit(); } }); fRemoveButton= new Button(buttons, SWT.PUSH); fRemoveButton.setLayoutData(getButtonGridData(fRemoveButton)); fRemoveButton.setText(TemplateMessages.getString("TemplatePreferencePage.remove")); //$NON-NLS-1$ fRemoveButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { remove(); } }); createSpacer(buttons); fImportButton= new Button(buttons, SWT.PUSH); fImportButton.setLayoutData(getButtonGridData(fImportButton)); fImportButton.setText(TemplateMessages.getString("TemplatePreferencePage.import")); //$NON-NLS-1$ fImportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { import_(); } }); fExportButton= new Button(buttons, SWT.PUSH); fExportButton.setLayoutData(getButtonGridData(fExportButton)); fExportButton.setText(TemplateMessages.getString("TemplatePreferencePage.export")); //$NON-NLS-1$ fExportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { export(); } }); fExportAllButton= new Button(buttons, SWT.PUSH); fExportAllButton.setLayoutData(getButtonGridData(fExportAllButton)); fExportAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.export.all")); //$NON-NLS-1$ fExportAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { exportAll(); } }); createSpacer(buttons); fEnableAllButton= new Button(buttons, SWT.PUSH); fEnableAllButton.setLayoutData(getButtonGridData(fEnableAllButton)); fEnableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.enable.all")); //$NON-NLS-1$ fEnableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(true); } }); fDisableAllButton= new Button(buttons, SWT.PUSH); fDisableAllButton.setLayoutData(getButtonGridData(fDisableAllButton)); fDisableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.disable.all")); //$NON-NLS-1$ fDisableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(false); } }); fPatternViewer= createViewer(parent); createSpacer(parent); fFormatButton= new Button(parent, SWT.CHECK); fFormatButton.setText(TemplateMessages.getString("TemplatePreferencePage.use.code.formatter")); //$NON-NLS-1$ fTableViewer.setInput(fTemplates); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getBoolean(PREF_FORMAT_TEMPLATES)); updateButtons(); WorkbenchHelp.setHelp(parent, new DialogPageContextComputer(this, IJavaHelpContextIds.TEMPLATE_PREFERENCE_PAGE)); return parent; } private Template[] getEnabledTemplates() { Template[] templates= fTemplates.getTemplates(); List list= new ArrayList(templates.length); for (int i= 0; i != templates.length; i++) if (templates[i].isEnabled()) list.add(templates[i]); return (Template[]) list.toArray(new Template[list.size()]); } private SourceViewer createViewer(Composite parent) { SourceViewer viewer= new SourceViewer(parent, null, SWT.BORDER /*| SWT.V_SCROLL | SWT.H_SCROLL*/); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); viewer.configure(new JavaSourceViewerConfiguration(tools, null)); viewer.setEditable(false); viewer.setDocument(new Document()); Font font= JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT); viewer.getTextWidget().setFont(font); Control control= viewer.getControl(); GridData data= new GridData(GridData.FILL_BOTH); data.heightHint= convertHeightInCharsToPixels(5); control.setLayoutData(data); return viewer; } public void createSpacer(Composite parent) { Label spacer= new Label(parent, SWT.NONE); GridData data= new GridData(); data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; data.heightHint= 4; spacer.setLayoutData(data); } private static GridData getButtonGridData(Button button) { GridData data= new GridData(GridData.FILL_HORIZONTAL); data.widthHint= SWTUtil.getButtonWidthHint(button); data.heightHint= SWTUtil.getButtonHeigthHint(button); return data; } private void selectionChanged1() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); if (selection.size() == 1) { Template template= (Template) selection.getFirstElement(); fPatternViewer.getTextWidget().setText(template.getPattern()); } else { fPatternViewer.getTextWidget().setText(""); //$NON-NLS-1$ } updateButtons(); } private void updateButtons() { int selectionCount= ((IStructuredSelection) fTableViewer.getSelection()).size(); int itemCount= fTableViewer.getTable().getItemCount(); fEditButton.setEnabled(selectionCount == 1); fExportButton.setEnabled(selectionCount > 0); fRemoveButton.setEnabled(selectionCount > 0 && selectionCount <= itemCount); fEnableAllButton.setEnabled(itemCount > 0); fDisableAllButton.setEnabled(itemCount > 0); } private void add() { Template template= new Template(); template.setContext(TemplateContext.JAVA); //$NON-NLS-1$ EditTemplateDialog dialog= new EditTemplateDialog(getShell(), template, false); if (dialog.open() == dialog.OK) { fTemplates.add(template); fTableViewer.refresh(); fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void edit() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] objects= selection.toArray(); if ((objects == null) || (objects.length != 1)) return; Template template= (Template) selection.getFirstElement(); edit(template); } private void edit(Template template) { EditTemplateDialog dialog= new EditTemplateDialog(getShell(), template, true); if (dialog.open() == dialog.OK) { fTableViewer.refresh(template); fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void import_() { FileDialog dialog= new FileDialog(getShell()); dialog.setText(TemplateMessages.getString("TemplatePreferencePage.import.title")); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.import.extension")}); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; try { fTemplates.addFromFile(new File(path)); fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } } private void exportAll() { export(fTemplates); } private void export() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] templates= selection.toArray(); TemplateSet templateSet= new TemplateSet(); for (int i= 0; i != templates.length; i++) templateSet.add((Template) templates[i]); export(templateSet); } private void export(TemplateSet templateSet) { FileDialog dialog= new FileDialog(getShell(), SWT.SAVE); dialog.setText(TemplateMessages.getFormattedString("TemplatePreferencePage.export.title", new Integer(templateSet.getTemplates().length))); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.export.extension")}); //$NON-NLS-1$ dialog.setFileName(TemplateMessages.getString("TemplatePreferencePage.export.filename")); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; try { templateSet.saveToFile(new File(path)); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } } private void remove() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Iterator elements= selection.iterator(); while (elements.hasNext()) { Template template= (Template) elements.next(); fTemplates.remove(template); } fTableViewer.refresh(); } private void enableAll(boolean enable) { Template[] templates= fTemplates.getTemplates(); for (int i= 0; i != templates.length; i++) templates[i].setEnabled(enable); fTableViewer.setAllChecked(enable); } /* * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) {} /* * @see Control#setVisible(boolean) */ public void setVisible(boolean visible) { super.setVisible(visible); if (visible) setTitle(TemplateMessages.getString("TemplatePreferencePage.title")); //$NON-NLS-1$ } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getDefaultBoolean(PREF_FORMAT_TEMPLATES)); try { fTemplates.restoreDefaults(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } // refresh fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } /* * @see PreferencePage#performOk() */ public boolean performOk() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); prefs.setValue(PREF_FORMAT_TEMPLATES, fFormatButton.getSelection()); try { fTemplates.save(); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } return super.performOk(); } /* * @see PreferencePage#performCancel() */ public boolean performCancel() { try { fTemplates.reset(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } return super.performCancel(); } /** * Initializes the default values of this page in the preference bundle. * Will be called on startup of the JavaPlugin */ public static void initDefaults(IPreferenceStore prefs) { prefs.setDefault(PREF_FORMAT_TEMPLATES, true); } public static boolean useCodeFormatter() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); return prefs.getBoolean(PREF_FORMAT_TEMPLATES); } private void openReadErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.read.title"), //$NON-NLS-1$ e.getMessage(), e.getStatus()); } private void openWriteErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.write.title"), //$NON-NLS-1$ e.getMessage(), e.getStatus()); } }
7,600
Bug 7600 Exception in TemplateCollector
Java Model Exception: Java Model Status [Invalid path: /A.java.] Stack trace: java/lang/Throwable.<init>()V java/lang/Throwable.<init>(Ljava/lang/String;)V org/eclipse/core/runtime/CoreException.<init> (Lorg/eclipse/core/runtime/IStatus;)V org/eclipse/jdt/core/JavaModelException.<init> (Lorg/eclipse/jdt/core/IJavaModelStatus;)V org/eclipse/jdt/internal/core/JavaProject.findElement (Lorg/eclipse/core/runtime/IPath;)Lorg/eclipse/jdt/core/IJavaElement; org/eclipse/jdt/internal/corext/util/JavaModelUtil.findType (Lorg/eclipse/jdt/core/IJavaProject;Ljava/lang/String;) Lorg/eclipse/jdt/core/IType; org/eclipse/jdt/internal/ui/text/template/TemplateCollector.isSubclassOf (Ljava/lang/String;Ljava/lang/String;)Z org/eclipse/jdt/internal/ui/text/template/TemplateCollector.findLocalCollections ()[Lorg/eclipse/jdt/internal/ui/text/template/TemplateCollector$LocalVariable; org/eclipse/jdt/internal/ui/text/template/TemplateCollector.evaluate (Ljava/lang/String;)Ljava/lang/String; org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.guessVariableNames() V org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.getDocument(I) Lorg/eclipse/jface/text/IDocument; org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.evaluate() Ljava/lang/String; org/eclipse/jdt/internal/ui/text/template/TemplateProposal.getAdditionalProposal Info()Ljava/lang/String; org/eclipse/jface/text/contentassist/AdditionalInfoController.computeInformation ()V org/eclipse/jface/text/AbstractInformationControlManager.showInformation()V org/eclipse/jface/text/contentassist/AdditionalInfoController$1.run()V org/eclipse/swt/widgets/RunnableLock.run()V org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z org/eclipse/swt/widgets/Display.runAsyncMessages()Z org/eclipse/swt/widgets/Display.readAndDispatch()Z org/eclipse/jface/window/Window.runEventLoop(Lorg/eclipse/swt/widgets/Shell;) V org/eclipse/jface/window/Window.open()I org/eclipse/jface/dialogs/MessageDialog.openError (Lorg/eclipse/swt/widgets/Shell;Ljava/lang/String;Ljava/lang/String;)V org/eclipse/jdt/internal/ui/text/template/TemplateCollector.openErrorDialog (Lorg/eclipse/swt/widgets/Shell;Ljava/lang/Exception;)V org/eclipse/jdt/internal/ui/text/template/TemplateCollector.evaluate (Ljava/lang/String;)Ljava/lang/String; org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.guessVariableNames() V org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.getDocument(I) Lorg/eclipse/jface/text/IDocument; org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.evaluate() Ljava/lang/String; org/eclipse/jdt/internal/ui/text/template/TemplateProposal.getAdditionalProposal Info()Ljava/lang/String; org/eclipse/jface/text/contentassist/AdditionalInfoController.computeInformation ()V org/eclipse/jface/text/AbstractInformationControlManager.showInformation()V org/eclipse/jface/text/contentassist/AdditionalInfoController$1.run()V org/eclipse/swt/widgets/RunnableLock.run()V org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z org/eclipse/swt/widgets/Display.runAsyncMessages()Z org/eclipse/swt/widgets/Display.readAndDispatch()Z org/eclipse/ui/internal/Workbench.runEventLoop()V org/eclipse/ui/internal/Workbench.run(Ljava/lang/Object;)Ljava/lang/Object; org/eclipse/core/internal/boot/InternalBootLoader.run (Ljava/lang/String;Ljava/net/URL;Ljava/lang/String;[Ljava/lang/String;) Ljava/lang/Object; org/eclipse/core/boot/BootLoader.run (Ljava/lang/String;Ljava/net/URL;Ljava/lang/String;[Ljava/lang/String;) Ljava/lang/Object; SlimLauncher.main([Ljava/lang/String;)V 4 org.eclipse.jdt.core 979 Invalid path: /A.java. Log: Tue Jan 15 14:58:19 CET 2002 4 org.eclipse.core.runtime 0 Unhandled exception caught in event loop. org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException) Stack trace: java/lang/Throwable.<init>()V java/lang/Throwable.<init>(Ljava/lang/String;)V org/eclipse/swt/SWTException.<init>(ILjava/lang/String;)V org/eclipse/swt/SWTException.<init>(I)V org/eclipse/swt/SWT.error(ILjava/lang/Throwable;)V org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z org/eclipse/swt/widgets/Display.runAsyncMessages()Z org/eclipse/swt/widgets/Display.readAndDispatch()Z org/eclipse/jface/window/Window.runEventLoop(Lorg/eclipse/swt/widgets/Shell;) V org/eclipse/jface/window/Window.open()I org/eclipse/jface/dialogs/MessageDialog.openError (Lorg/eclipse/swt/widgets/Shell;Ljava/lang/String;Ljava/lang/String;)V org/eclipse/jdt/internal/ui/text/template/TemplateCollector.openErrorDialog (Lorg/eclipse/swt/widgets/Shell;Ljava/lang/Exception;)V org/eclipse/jdt/internal/ui/text/template/TemplateCollector.evaluate (Ljava/lang/String;)Ljava/lang/String; org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.guessVariableNames() V org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.getDocument(I) Lorg/eclipse/jface/text/IDocument; org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.evaluate() Ljava/lang/String; org/eclipse/jdt/internal/ui/text/template/TemplateProposal.getAdditionalProposal Info()Ljava/lang/String; org/eclipse/jface/text/contentassist/AdditionalInfoController.computeInformation ()V org/eclipse/jface/text/AbstractInformationControlManager.showInformation()V org/eclipse/jface/text/contentassist/AdditionalInfoController$1.run()V org/eclipse/swt/widgets/RunnableLock.run()V org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z org/eclipse/swt/widgets/Display.runAsyncMessages()Z org/eclipse/swt/widgets/Display.readAndDispatch()Z org/eclipse/ui/internal/Workbench.runEventLoop()V org/eclipse/ui/internal/Workbench.run(Ljava/lang/Object;)Ljava/lang/Object; org/eclipse/core/internal/boot/InternalBootLoader.run (Ljava/lang/String;Ljava/net/URL;Ljava/lang/String;[Ljava/lang/String;) Ljava/lang/Object; org/eclipse/core/boot/BootLoader.run (Ljava/lang/String;Ljava/net/URL;Ljava/lang/String;[Ljava/lang/String;) Ljava/lang/Object; SlimLauncher.main([Ljava/lang/String;)V Log: Tue Jan 15 14:58:19 CET 2002 4 org.eclipse.core.runtime 0 Failed to execute runnable (java.lang.NullPointerException) org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException) Stack trace: java/lang/Throwable.<init>()V java/lang/Throwable.<init>(Ljava/lang/String;)V org/eclipse/swt/SWTException.<init>(ILjava/lang/String;)V org/eclipse/swt/SWTException.<init>(I)V org/eclipse/swt/SWT.error(ILjava/lang/Throwable;)V org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z org/eclipse/swt/widgets/Display.runAsyncMessages()Z org/eclipse/swt/widgets/Display.readAndDispatch()Z org/eclipse/jface/window/Window.runEventLoop(Lorg/eclipse/swt/widgets/Shell;) V org/eclipse/jface/window/Window.open()I org/eclipse/jface/dialogs/MessageDialog.openError (Lorg/eclipse/swt/widgets/Shell;Ljava/lang/String;Ljava/lang/String;)V org/eclipse/jdt/internal/ui/text/template/TemplateCollector.openErrorDialog (Lorg/eclipse/swt/widgets/Shell;Ljava/lang/Exception;)V org/eclipse/jdt/internal/ui/text/template/TemplateCollector.evaluate (Ljava/lang/String;)Ljava/lang/String; org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.guessVariableNames() V org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.getDocument(I) Lorg/eclipse/jface/text/IDocument; org/eclipse/jdt/internal/ui/text/template/TemplateEvaluator.evaluate() Ljava/lang/String; org/eclipse/jdt/internal/ui/text/template/TemplateProposal.getAdditionalProposal Info()Ljava/lang/String; org/eclipse/jface/text/contentassist/AdditionalInfoController.computeInformation ()V org/eclipse/jface/text/AbstractInformationControlManager.showInformation()V org/eclipse/jface/text/contentassist/AdditionalInfoController$1.run()V org/eclipse/swt/widgets/RunnableLock.run()V org/eclipse/swt/widgets/Synchronizer.runAsyncMessages()Z org/eclipse/swt/widgets/Display.runAsyncMessages()Z org/eclipse/swt/widgets/Display.readAndDispatch()Z org/eclipse/ui/internal/Workbench.runEventLoop()V org/eclipse/ui/internal/Workbench.run(Ljava/lang/Object;)Ljava/lang/Object; org/eclipse/core/internal/boot/InternalBootLoader.run (Ljava/lang/String;Ljava/net/URL;Ljava/lang/String;[Ljava/lang/String;) Ljava/lang/Object; org/eclipse/core/boot/BootLoader.run (Ljava/lang/String;Ljava/net/URL;Ljava/lang/String;[Ljava/lang/String;) Ljava/lang/Object; SlimLauncher.main([Ljava/lang/String;)V
verified fixed
8ce960e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-17T11:09:24Z"
"2002-01-15T13:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateCollector.java
package org.eclipse.jdt.internal.ui.text.template; import java.text.DateFormat; import java.util.Date; import java.util.Iterator; import java.util.Vector; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IMarker; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jdt.core.ICompletionRequestor; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.core.Assert; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; public class TemplateCollector implements ICompletionRequestor { // general private static final String FILE= "file"; //$NON-NLS-1$ private static final String LINE= "line"; //$NON-NLS-1$ private static final String DATE= "date"; //$NON-NLS-1$ private static final String TIME= "time"; //$NON-NLS-1$ private static final String USER= "user"; //$NON-NLS-1$ // arrays private static final String ARRAY= "array"; //$NON-NLS-1$ private static final String ARRAY_TYPE= "array_type"; //$NON-NLS-1$ private static final String ARRAY_ELEMENT= "array_element"; //$NON-NLS-1$ private static final String INDEX= "index"; //$NON-NLS-1$ // collections private static final String COLLECTION= "collection"; //$NON-NLS-1$ private static final String ITERATOR= "iterator"; //$NON-NLS-1$ // methods private static final String RETURN_TYPE= "return_type"; //$NON-NLS-1$ private static final String ARGUMENTS= "arguments"; //$NON-NLS-1$ private static final String[][] fgVariables = { {FILE, TemplateMessages.getString("TemplateCollector.variable.description.file")}, // {LINE, TemplateMessages.getString("TemplateCollector.variable.description.line")}, {DATE, TemplateMessages.getString("TemplateCollector.variable.description.date")}, {TIME, TemplateMessages.getString("TemplateCollector.variable.description.time")}, {USER, TemplateMessages.getString("TemplateCollector.variable.description.user")}, {ARRAY, TemplateMessages.getString("TemplateCollector.variable.description.array")}, {ARRAY_TYPE, TemplateMessages.getString("TemplateCollector.variable.description.array.type")}, {ARRAY_ELEMENT, TemplateMessages.getString("TemplateCollector.variable.description.array.element")}, {INDEX, TemplateMessages.getString("TemplateCollector.variable.description.index")}, {COLLECTION, TemplateMessages.getString("TemplateCollector.variable.description.collector")}, {ITERATOR, TemplateMessages.getString("TemplateCollector.variable.description.iterator")}, {RETURN_TYPE, TemplateMessages.getString("TemplateCollector.variable.description.return.type")}, {ARGUMENTS, TemplateMessages.getString("TemplateCollector.variable.description.arguments")} }; private static class LocalVariable { String name; String typePackageName; String typeName; LocalVariable(String name, String typePackageName, String typeName) { this.name= name; this.typePackageName= typePackageName; this.typeName= typeName; } } private ICompilationUnit fUnit; private Vector fClasses; private Vector fFields; private Vector fInterfaces; private Vector fKeywords; private Vector fLabels; private Vector fLocalVariables; private Vector fMethods; private Vector fMethodDeclarations; private Vector fModifiers; private Vector fPackages; private Vector fTypes; private Vector fVariableNames; private boolean fError; public TemplateCollector(ICompilationUnit unit) { Assert.isNotNull(unit); reset(unit); } public void reset(ICompilationUnit unit) { Assert.isNotNull(unit); fUnit= unit; fClasses= new Vector(); fFields= new Vector(); fInterfaces= new Vector(); fKeywords= new Vector(); fLabels= new Vector(); fLocalVariables= new Vector(); fMethods= new Vector(); fMethodDeclarations= new Vector(); fModifiers= new Vector(); fPackages= new Vector(); fTypes= new Vector(); fVariableNames= new Vector(); fError= false; } /* * @see ICompletionRequestor#acceptClass(char[], char[], char[], int, int, int) */ public void acceptClass( char[] packageName, char[] className, char[] completionName, int modifiers, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptError(IMarker) */ public void acceptError(IMarker marker) { fError= true; } /* * @see ICompletionRequestor#acceptField(char[], char[], char[], char[], char[], char[], int, int, int) */ public void acceptField( char[] declaringTypePackageName, char[] declaringTypeName, char[] name, char[] typePackageName, char[] typeName, char[] completionName, int modifiers, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptInterface(char[], char[], char[], int, int, int) */ public void acceptInterface( char[] packageName, char[] interfaceName, char[] completionName, int modifiers, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptKeyword(char[], int, int) */ public void acceptKeyword( char[] keywordName, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptLabel(char[], int, int) */ public void acceptLabel( char[] labelName, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptLocalVariable(char[], char[], char[], int, int, int) */ public void acceptLocalVariable(char[] name, char[] typePackageName, char[] typeName, int modifiers, int completionStart, int completionEnd) { fLocalVariables.add(new LocalVariable( new String(name), new String(typePackageName), new String(typeName))); } /* * @see ICompletionRequestor#acceptMethod(char[], char[], char[], char[][], char[][], char[][], char[], char[], char[], int, int, int) */ public void acceptMethod( char[] declaringTypePackageName, char[] declaringTypeName, char[] selector, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypePackageName, char[] returnTypeName, char[] completionName, int modifiers, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptMethodDeclaration(char[], char[], char[], char[][], char[][], char[][], char[], char[], char[], int, int, int) */ public void acceptMethodDeclaration( char[] declaringTypePackageName, char[] declaringTypeName, char[] selector, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypePackageName, char[] returnTypeName, char[] completionName, int modifiers, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptModifier(char[], int, int) */ public void acceptModifier( char[] modifierName, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptPackage(char[], char[], int, int) */ public void acceptPackage( char[] packageName, char[] completionName, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptType(char[], char[], char[], int, int) */ public void acceptType( char[] packageName, char[] typeName, char[] completionName, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptVariableName(char[], char[], char[], char[], int, int) */ public void acceptVariableName( char[] typePackageName, char[] typeName, char[] name, char[] completionName, int completionStart, int completionEnd) { } /* * @see ICompletionRequestor#acceptAnonymousType(char[], char[], char[][], char[][], char[][], char[], int, int, int) */ public void acceptAnonymousType(char[] superTypePackageName, char[] superTypeName, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] completionName, int modifiers, int completionStart, int completionEnd) { } // --- /** * Tests if the code completion process produced errors. */ public boolean hasErrors() { return fError; } /** * Evaluate a variable. Returns <code>null</code> for unrecognized * variables or ambiguous matches. */ public String evaluate(String variable) { try { // guess array if (variable.equals(ARRAY)) { LocalVariable[] localArrays= findLocalArrays(); if (localArrays.length > 0) return localArrays[localArrays.length - 1].name; // guess array base type } else if (variable.equals(ARRAY_TYPE)) { LocalVariable[] localArrays= findLocalArrays(); if (localArrays.length > 0) { String typeName= localArrays[localArrays.length - 1].typeName; return typeName.substring(0, typeName.indexOf('[')); } // guess array element } else if (variable.equals(ARRAY_ELEMENT)) { LocalVariable[] localArrays= findLocalArrays(); if (localArrays.length > 0) { String typeName= localArrays[localArrays.length - 1].typeName; String baseTypeName= typeName.substring(0, typeName.indexOf('[')); String variableName= typeToVariable(baseTypeName); if (!existsLocalName(variableName)) return variableName; } // guess collections } else if (variable.equals(COLLECTION)) { LocalVariable[] localCollections= findLocalCollections(); if (localCollections.length > 0) return localCollections[localCollections.length - 1].name; // find non colliding index } else if (variable.equals(INDEX)) { String[] proposals= {"i", "j", "k"}; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ for (int i= 0; i != proposals.length; i++) { String proposal = proposals[i]; if (!existsLocalName(proposal)) return proposal; } // find non colliding iterator } else if (variable.equals(ITERATOR)) { String[] proposals= {"iter"}; //$NON-NLS-1$ for (int i= 0; i != proposals.length; i++) { String proposal = proposals[i]; if (!existsLocalName(proposal)) return proposal; } } else if (variable.equals(RETURN_TYPE)) { return "void"; //$NON-NLS-1$ } else if (variable.equals(ARGUMENTS)) { return ""; //$NON-NLS-1$ } else if (variable.equals(FILE)) { if (fUnit != null) return fUnit.getElementName(); // } else if (variable.equals(LINE)) { // try { // int line= document.getLineOfOffset(offset) + 1; // return Integer.toString(line); // // } catch (BadLocationException e) { // JavaPlugin.log(e); // openErrorDialog(null, e); // } } else if (variable.equals(DATE)) { return DateFormat.getDateInstance().format(new Date()); } else if (variable.equals(TIME)) { return DateFormat.getTimeInstance().format(new Date()); } else if (variable.equals(USER)) { return System.getProperty("user.name"); } } catch (JavaModelException e) { JavaPlugin.log(e); openErrorDialog(null, e); } return null; } private boolean existsLocalName(String name) { for (Iterator iterator = fLocalVariables.iterator(); iterator.hasNext();) { LocalVariable localVariable = (LocalVariable) iterator.next(); if (localVariable.name.equals(name)) return true; } return false; } private LocalVariable[] findLocalArrays() { Vector vector= new Vector(); for (Iterator iterator= fLocalVariables.iterator(); iterator.hasNext();) { LocalVariable localVariable= (LocalVariable) iterator.next(); if (isArray(localVariable.typeName)) vector.add(localVariable); } return (LocalVariable[]) vector.toArray(new LocalVariable[vector.size()]); } private LocalVariable[] findLocalCollections() throws JavaModelException { Vector vector= new Vector(); for (Iterator iterator= fLocalVariables.iterator(); iterator.hasNext();) { LocalVariable localVariable= (LocalVariable) iterator.next(); String typeName= qualify(localVariable.typeName); if (typeName == null) continue; if (isSubclassOf(typeName, "java.util.Collection")) //$NON-NLS-1$ vector.add(localVariable); } return (LocalVariable[]) vector.toArray(new LocalVariable[vector.size()]); } private LocalVariable[] findLocalIntegers() { Vector vector= new Vector(); for (Iterator iterator= fLocalVariables.iterator(); iterator.hasNext();) { LocalVariable localVariable= (LocalVariable) iterator.next(); if (localVariable.typeName.equals("int")) //$NON-NLS-1$ vector.add(localVariable); } return (LocalVariable[]) vector.toArray(new LocalVariable[vector.size()]); } private LocalVariable[] findLocalIterator() throws JavaModelException { Vector vector= new Vector(); for (Iterator iterator= fLocalVariables.iterator(); iterator.hasNext();) { LocalVariable localVariable= (LocalVariable) iterator.next(); String typeName= qualify(localVariable.typeName); if (typeName == null) continue; if (isSubclassOf(typeName, "java.util.Iterator")) //$NON-NLS-1$ vector.add(localVariable); } return (LocalVariable[]) vector.toArray(new LocalVariable[vector.size()]); } private static boolean isArray(String type) { return type.endsWith("[]"); //$NON-NLS-1$ } // returns fully qualified name if successful private String qualify(String typeName) throws JavaModelException { IType[] types= fUnit.getTypes(); if (types.length == 0) return null; String[][] resolvedTypeNames= types[0].resolveType(typeName); if (resolvedTypeNames == null) return null; return resolvedTypeNames[0][0] + '.' + resolvedTypeNames[0][1]; } // type names must be fully qualified private boolean isSubclassOf(String typeName0, String typeName1) throws JavaModelException { if (typeName0.equals(typeName1)) return true; IJavaProject project= fUnit.getJavaProject(); IType type0= JavaModelUtil.findType(project, typeName0); IType type1= JavaModelUtil.findType(project, typeName1); ITypeHierarchy hierarchy= type0.newSupertypeHierarchy(null); IType[] superTypes= hierarchy.getAllSupertypes(type0); for (int i= 0; i < superTypes.length; i++) if (superTypes[i].equals(type1)) return true; return false; } private static String typeToVariable(String string) { Assert.isTrue(string.length() > 0); char first= string.charAt(0); // base type if (Character.isLowerCase(first)) return "value"; //$NON-NLS-1$ // class or interface return Character.toLowerCase(first) + string.substring(1); } private static void openErrorDialog(Shell shell, Exception e) { MessageDialog.openError(shell, TemplateMessages.getString("TemplateCollector.error.title"), e.getMessage()); //$NON-NLS-1$ } /** * Returns all variables with special meaning. * The size of the second dimension is two. The first value is the * name of the variable, the second value is its description. */ public static String[][] getVariables() { return fgVariables; } }
3,487
Bug 3487 Smoke 20: Rendering of methods different in Class Hierarchy / Outliner (1FZOKGK)
MA (8/14/00 6:09:15 PM) 1. open java.lang object form rt.jar with correct source annotation 2. activate static methods in the class hierrachy viewer 3. the hierarhcy viewer renders a method <clinit>, which is not shown in the outliner MA (8/14/00 6:09:20 PM) I think, static initializers should be rendered which a human readable name, also in source files NOTES: KUM (8/15/00 6:11:17 PM) <clinit> are compiler generated initializers. They are different from the initializer code which can be placed directly into the source of a class such as class X { { // initializer per instance } static { // class initializer } } Such initializers show up in the outline and in the method view. <clinit> shouldn't show up in the type viewer's method list. EG (8/31/00 8:00:37 PM) agreed, synthetic initializers should be hidden MA (11/7/00 6:05:24 PM) filtered out in TypeHierarchy > 25 AK (11/16/00 4:30:18 PM) not fixed initializers show up only in the outliner now (so it's changed since KUM wrote the comment above) EG (12/5/00 1:05:46 PM) consider once we are on new SEF DM (1/29/01 12:34:40 PM) Verified --> not fixed The problem is now also in the Ouline view and the problem is even worse in my opinion because the default constructor is now rendered as if it would be real (i.e. explicitly defined in the class). Test Case: java.applet.Applet.class ==> synthetic members should be shown but recognizable as such. MINOR PROBLEM - NOT FOR WEDNESDAY MA (20.08.2001 17:23:13) Initializers were not rendered in the type hierarchy. added in 200 Can't see constructors in outline for class files.
verified fixed
0d5f538
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-17T18:43:51Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/MethodsViewerFilter.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.IField; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; /** * Filter for the methods viewer. * Changing a filter property does not trigger a refiltering of the viewer */ public class MethodsViewerFilter extends ViewerFilter { public static final int FILTER_NONPUBLIC= 1; public static final int FILTER_STATIC= 2; public static final int FILTER_FIELDS= 4; private int fFilterProperties; /** * Modifies filter and add a property to filter for */ public final void addFilter(int filter) { fFilterProperties |= filter; } /** * Modifies filter and remove a property to filter for */ public final void removeFilter(int filter) { fFilterProperties &= (-1 ^ filter); } /** * Tests if a property is filtered */ public final boolean hasFilter(int filter) { return (fFilterProperties & filter) != 0; } /* * @see ViewerFilter@isFilterProperty */ public boolean isFilterProperty(Object element, Object property) { return false; } /* * @see ViewerFilter@select */ public boolean select(Viewer viewer, Object parentElement, Object element) { try { if (hasFilter(FILTER_FIELDS) && element instanceof IField) { return false; } if (element instanceof IMember) { IMember member= (IMember)element; int flags= member.getFlags(); if (hasFilter(FILTER_STATIC) && (Flags.isStatic(flags) || "<clinit>".equals(member.getElementName()))) { return false; } if (hasFilter(FILTER_NONPUBLIC) && !Flags.isPublic(flags) && !isMemberInInterface(member)) { return false; } } } catch (JavaModelException e) { // ignore } return true; } private boolean isMemberInInterface(IMember member) throws JavaModelException { IType parent= member.getDeclaringType(); return parent != null && parent.isInterface(); } }
7,653
Bug 7653 Outline doesn't sort overloaded methods
When you set the Outline view to sort by name (the A-Z button) it does not consider the methods' arguments when sorting them. #1 - create the following class in Eclipse: public class OutlineTest { public void foo(int x) {} public void foo(float x) {} public void foo(long x) {} public void foo(double x) {} public void bar() {} } #2 - open an Outline view on the class #3 - by default (unsorted) it shows foo(int x) foo(float x) foo(long x) foo(double x) bar() #3 - if you choose the 'A-Z' button, the outline re-sorts to bar() foo(int x) foo(float x) foo(long x) foo(double x) I had expected it to consider the arguments for overloaded functions and to sort like: bar() foo(double x) foo(float x) foo(int x) foo(long x) (I just noticed that the Packages view seems to use the same ordering as the Outline, so this bug is not restricted to the Outline.) (I'm pretty sure that VisualAge for Java takes the arguments into account when sorting overloaded functions.) (Tested against 20011219 build)
verified fixed
efbeea0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-17T19:18:01Z"
"2002-01-15T21:26:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/MethodsViewer.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import java.util.ArrayList; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Menu; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.Table; import org.eclipse.jface.action.IMenuListener; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.action.ToolBarManager; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.IMemento; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchPartSite; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.actions.GenerateGroup; import org.eclipse.jdt.internal.ui.actions.OpenJavaElementAction; import org.eclipse.jdt.internal.ui.search.JavaSearchGroup; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.SelectionUtil; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.viewsupport.MarkerErrorTickProvider; import org.eclipse.jdt.internal.ui.viewsupport.ProblemTableViewer; /** * Method viewer shows a list of methods of a input type. * Offers filter actions. * No dependency to the type hierarchy view */ public class MethodsViewer extends ProblemTableViewer { /** * Sorter that uses the unmodified labelprovider (No declaring class names) */ private static class MethodsViewerSorter extends JavaElementSorter { public MethodsViewerSorter() { } public int compare(Viewer viewer, Object e1, Object e2) { int cat1 = category(e1); int cat2 = category(e2); if (cat1 != cat2) return cat1 - cat2; // cat1 == cat2 String name1= JavaElementLabels.getElementLabel((IJavaElement) e1, JavaElementLabels.ALL_DEFAULT); String name2= JavaElementLabels.getElementLabel((IJavaElement) e2, JavaElementLabels.ALL_DEFAULT); return getCollator().compare(name1, name2); } } private static final String TAG_HIDEFIELDS= "hidefields"; //$NON-NLS-1$ private static final String TAG_HIDESTATIC= "hidestatic"; //$NON-NLS-1$ private static final String TAG_HIDENONPUBLIC= "hidenonpublic"; //$NON-NLS-1$ private static final String TAG_SHOWINHERITED= "showinherited"; //$NON-NLS-1$ private static final String TAG_VERTICAL_SCROLL= "mv_vertical_scroll"; //$NON-NLS-1$ private MethodsViewerFilterAction[] fFilterActions; private MethodsViewerFilter fFilter; private OpenJavaElementAction fOpen; private ShowInheritedMembersAction fShowInheritedMembersAction; private ContextMenuGroup[] fStandardGroups; public MethodsViewer(Composite parent, IWorkbenchPart part) { super(new Table(parent, SWT.MULTI)); JavaElementLabelProvider lprovider= new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT); lprovider.setErrorTickManager(new MarkerErrorTickProvider()); MethodsContentProvider contentProvider= new MethodsContentProvider(); setLabelProvider(lprovider); setContentProvider(contentProvider); fOpen= new OpenJavaElementAction(this); addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent event) { fOpen.run(); } }); fFilter= new MethodsViewerFilter(); // fields String title= TypeHierarchyMessages.getString("MethodsViewer.hide_fields.label"); //$NON-NLS-1$ String helpContext= IJavaHelpContextIds.FILTER_FIELDS_ACTION; MethodsViewerFilterAction hideFields= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_FIELDS, helpContext, false); hideFields.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.description")); //$NON-NLS-1$ hideFields.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.tooltip.checked")); //$NON-NLS-1$ hideFields.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_fields.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideFields, "fields_co.gif"); //$NON-NLS-1$ // static title= TypeHierarchyMessages.getString("MethodsViewer.hide_static.label"); //$NON-NLS-1$ helpContext= IJavaHelpContextIds.FILTER_STATIC_ACTION; MethodsViewerFilterAction hideStatic= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_STATIC, helpContext, false); hideStatic.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_static.description")); //$NON-NLS-1$ hideStatic.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_static.tooltip.checked")); //$NON-NLS-1$ hideStatic.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_static.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideStatic, "static_co.gif"); //$NON-NLS-1$ // non-public title= TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.label"); //$NON-NLS-1$ helpContext= IJavaHelpContextIds.FILTER_PUBLIC_ACTION; MethodsViewerFilterAction hideNonPublic= new MethodsViewerFilterAction(this, title, MethodsViewerFilter.FILTER_NONPUBLIC, helpContext, false); hideNonPublic.setDescription(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.description")); //$NON-NLS-1$ hideNonPublic.setToolTipChecked(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.tooltip.checked")); //$NON-NLS-1$ hideNonPublic.setToolTipUnchecked(TypeHierarchyMessages.getString("MethodsViewer.hide_nonpublic.tooltip.unchecked")); //$NON-NLS-1$ JavaPluginImages.setLocalImageDescriptors(hideNonPublic, "public_co.gif"); //$NON-NLS-1$ // order corresponds to order in toolbar fFilterActions= new MethodsViewerFilterAction[] { hideFields, hideStatic, hideNonPublic }; addFilter(fFilter); fShowInheritedMembersAction= new ShowInheritedMembersAction(this, false); showInheritedMethods(false); fStandardGroups= new ContextMenuGroup[] { new JavaSearchGroup(), new GenerateGroup() }; setSorter(new MethodsViewerSorter()); } /** * Show inherited methods */ public void showInheritedMethods(boolean on) { MethodsContentProvider cprovider= (MethodsContentProvider) getContentProvider(); try { getTable().setRedraw(false); cprovider.showInheritedMethods(on); fShowInheritedMembersAction.setChecked(on); JavaElementLabelProvider lprovider= (JavaElementLabelProvider) getLabelProvider(); if (on) { lprovider.turnOn(JavaElementLabelProvider.SHOW_POST_QUALIFIED); } else { lprovider.turnOff(JavaElementLabelProvider.SHOW_POST_QUALIFIED); } refresh(); } catch (JavaModelException e) { ExceptionHandler.handle(e, getControl().getShell(), TypeHierarchyMessages.getString("MethodsViewer.toggle.error.title"), TypeHierarchyMessages.getString("MethodsViewer.toggle.error.message")); //$NON-NLS-2$ //$NON-NLS-1$ } finally { getTable().setRedraw(true); } } /* * @see Viewer#inputChanged(Object, Object) */ protected void inputChanged(Object input, Object oldInput) { super.inputChanged(input, oldInput); } /** * Returns <code>true</code> if inherited methods are shown. */ public boolean isShowInheritedMethods() { return ((MethodsContentProvider) getContentProvider()).isShowInheritedMethods(); } /** * Filters the method list */ public void setMemberFilter(int filterProperty, boolean set) { if (set) { fFilter.addFilter(filterProperty); } else { fFilter.removeFilter(filterProperty); } for (int i= 0; i < fFilterActions.length; i++) { if (fFilterActions[i].getFilterProperty() == filterProperty) { fFilterActions[i].setChecked(set); } } refresh(); } /** * Returns <code>true</code> if the given filter is set. */ public boolean hasMemberFilter(int filterProperty) { return fFilter.hasFilter(filterProperty); } /** * Saves the state of the filter actions */ public void saveState(IMemento memento) { memento.putString(TAG_HIDEFIELDS, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_FIELDS))); memento.putString(TAG_HIDESTATIC, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_STATIC))); memento.putString(TAG_HIDENONPUBLIC, String.valueOf(hasMemberFilter(MethodsViewerFilter.FILTER_NONPUBLIC))); memento.putString(TAG_SHOWINHERITED, String.valueOf(isShowInheritedMethods())); ScrollBar bar= getTable().getVerticalBar(); int position= bar != null ? bar.getSelection() : 0; memento.putString(TAG_VERTICAL_SCROLL, String.valueOf(position)); } /** * Restores the state of the filter actions */ public void restoreState(IMemento memento) { boolean set= Boolean.valueOf(memento.getString(TAG_HIDEFIELDS)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_FIELDS, set); set= Boolean.valueOf(memento.getString(TAG_HIDESTATIC)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_STATIC, set); set= Boolean.valueOf(memento.getString(TAG_HIDENONPUBLIC)).booleanValue(); setMemberFilter(MethodsViewerFilter.FILTER_NONPUBLIC, set); set= Boolean.valueOf(memento.getString(TAG_SHOWINHERITED)).booleanValue(); showInheritedMethods(set); ScrollBar bar= getTable().getVerticalBar(); if (bar != null) { Integer vScroll= memento.getInteger(TAG_VERTICAL_SCROLL); if (vScroll != null) { bar.setSelection(vScroll.intValue()); } } } /** * Attaches a contextmenu listener to the table */ public void initContextMenu(IMenuListener menuListener, String popupId, IWorkbenchPartSite viewSite) { MenuManager menuMgr= new MenuManager(); menuMgr.setRemoveAllWhenShown(true); menuMgr.addMenuListener(menuListener); Menu menu= menuMgr.createContextMenu(getTable()); getTable().setMenu(menu); viewSite.registerContextMenu(popupId, menuMgr, this); } /** * Fills up the context menu with items for the method viewer * Should be called by the creator of the context menu */ public void contributeToContextMenu(IMenuManager menu) { if (fOpen.canActionBeAdded()) { menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, fOpen); } ContextMenuGroup.add(menu, fStandardGroups, this); } /** * Fills up the tool bar with items for the method viewer * Should be called by the creator of the tool bar */ public void contributeToToolBar(ToolBarManager tbm) { tbm.add(fShowInheritedMembersAction); tbm.add(new Separator()); tbm.add(fFilterActions[0]); // fields tbm.add(fFilterActions[1]); // static tbm.add(fFilterActions[2]); // public } /* * @see StructuredViewer#handleInvalidSelection(ISelection, ISelection) */ protected void handleInvalidSelection(ISelection invalidSelection, ISelection newSelection) { // on change of input, try to keep selected methods stable by selecting a method with the same // signature: See #5466 List oldSelections= SelectionUtil.toList(invalidSelection); List newSelections= SelectionUtil.toList(newSelection); if (!oldSelections.isEmpty()) { ArrayList newSelectionElements= new ArrayList(newSelections); try { Object[] currElements= getFilteredChildren(getInput()); for (int i= 0; i < oldSelections.size(); i++) { Object curr= oldSelections.get(i); if (curr instanceof IMethod && !newSelections.contains(curr)) { IMethod method= (IMethod) curr; if (method.exists()) { IMethod similar= findSimilarMethod(method, currElements); if (similar != null) { newSelectionElements.add(similar); } } } } newSelection= new StructuredSelection(newSelectionElements); } catch (JavaModelException e) { JavaPlugin.log(e); } } setSelection(newSelection); updateSelection(newSelection); } private IMethod findSimilarMethod(IMethod meth, Object[] elements) throws JavaModelException { String name= meth.getElementName(); String[] paramTypes= meth.getParameterTypes(); boolean isConstructor= meth.isConstructor(); for (int i= 0; i < elements.length; i++) { Object curr= elements[i]; if (curr instanceof IMethod && JavaModelUtil.isSameMethodSignature(name, paramTypes, isConstructor, (IMethod) curr)) { return (IMethod) curr; } } return null; } }
7,653
Bug 7653 Outline doesn't sort overloaded methods
When you set the Outline view to sort by name (the A-Z button) it does not consider the methods' arguments when sorting them. #1 - create the following class in Eclipse: public class OutlineTest { public void foo(int x) {} public void foo(float x) {} public void foo(long x) {} public void foo(double x) {} public void bar() {} } #2 - open an Outline view on the class #3 - by default (unsorted) it shows foo(int x) foo(float x) foo(long x) foo(double x) bar() #3 - if you choose the 'A-Z' button, the outline re-sorts to bar() foo(int x) foo(float x) foo(long x) foo(double x) I had expected it to consider the arguments for overloaded functions and to sort like: bar() foo(double x) foo(float x) foo(int x) foo(long x) (I just noticed that the Packages view seems to use the same ordering as the Outline, so this bug is not restricted to the Outline.) (I'm pretty sure that VisualAge for Java takes the arguments into account when sorting overloaded functions.) (Tested against 20011219 build)
verified fixed
efbeea0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-17T19:18:01Z"
"2002-01-15T21:26:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementSorter.java
package org.eclipse.jdt.internal.ui.viewsupport; import java.text.Collator; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IStorage; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IField; import org.eclipse.jdt.core.IInitializer; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; /** * Sorts Java elements: * Package fragment roots are sorted as ordered in the classpath. */ public class JavaElementSorter extends ViewerSorter { private static final int PACKAGE_DECL= 1; private static final int IMPORT_CONTAINER= 2; private static final int TYPES= 3; private static final int CONSTRUCTORS= 4; private static final int STATIC_INIT= 5; private static final int STATIC_METHODS= 6; private static final int INIT= 7; private static final int METHODS= 8; private static final int STATIC_FIELDS= 9; private static final int FIELDS= 10; private static final int JAVAELEMENTS= 11; private static final int PACKAGEFRAGMENTROOTS= 12; private static final int PACKAGEFRAGMENT= 13; private static final int JAVAPROJECTS= 14; private static final int RESOURCEPACKAGES= 15; private static final int RESOURCEFOLDERS= 16; private static final int RESOURCES= 17; private static final int STORAGE= 18; private static final int OTHERS= 20; private IClasspathEntry[] fClassPath; /* * @see ViewerSorter#sort */ public void sort(Viewer v, Object[] property) { fClassPath= null; try { super.sort(v, property); } finally { fClassPath= null; } } /* * @see ViewerSorter#isSorterProperty */ public boolean isSorterProperty(Object element, Object property) { return true; } /* * @see ViewerSorter#category */ public int category(Object element) { if (element instanceof IJavaElement) { try { IJavaElement je= (IJavaElement) element; switch (je.getElementType()) { case IJavaElement.METHOD: { IMethod method= (IMethod) je; if (method.isConstructor()) return CONSTRUCTORS; int flags= method.getFlags(); return Flags.isStatic(flags) ? STATIC_METHODS : METHODS; } case IJavaElement.FIELD: { int flags= ((IField) je).getFlags(); return Flags.isStatic(flags) ? STATIC_FIELDS : FIELDS; } case IJavaElement.INITIALIZER: { int flags= ((IInitializer) je).getFlags(); return Flags.isStatic(flags) ? STATIC_INIT : INIT; } case IJavaElement.TYPE: return TYPES; case IJavaElement.PACKAGE_DECLARATION: return PACKAGE_DECL; case IJavaElement.IMPORT_CONTAINER: return IMPORT_CONTAINER; case IJavaElement.PACKAGE_FRAGMENT: IPackageFragment pack= (IPackageFragment) je; if (!pack.hasChildren() && pack.getNonJavaResources().length > 0) { return RESOURCEPACKAGES; } if (pack.getParent().getUnderlyingResource() instanceof IProject) { return PACKAGEFRAGMENTROOTS; } return PACKAGEFRAGMENT; case IJavaElement.PACKAGE_FRAGMENT_ROOT: return PACKAGEFRAGMENTROOTS; case IJavaElement.JAVA_PROJECT: return JAVAPROJECTS; } } catch (JavaModelException x) { JavaPlugin.log(x); } return JAVAELEMENTS; } else if (element instanceof IFile) { return RESOURCES; } else if (element instanceof IContainer) { return RESOURCEFOLDERS; } else if (element instanceof IStorage) { return STORAGE; } return OTHERS; } /* * @see ViewerSorter#compare */ public int compare(Viewer viewer, Object e1, Object e2) { int cat1= category(e1); int cat2= category(e2); if (cat1 != cat2) return cat1 - cat2; Collator collator= getCollator(); switch (cat1) { case OTHERS: // unknown element type return 0; case PACKAGEFRAGMENTROOTS: int p1= getClassPathIndex(JavaModelUtil.getPackageFragmentRoot((IJavaElement)e1)); int p2= getClassPathIndex(JavaModelUtil.getPackageFragmentRoot((IJavaElement)e2)); if (p1 == p2) { return collator.compare(((IJavaElement)e1).getElementName(), ((IJavaElement)e2).getElementName()); } return p1 - p2; case STORAGE: return collator.compare(((IStorage)e1).getName(), ((IStorage)e2).getName()); case RESOURCES: case RESOURCEFOLDERS: return collator.compare(((IResource)e1).getName(), ((IResource)e2).getName()); default: return collator.compare(((IJavaElement)e1).getElementName(), ((IJavaElement)e2).getElementName()); } } private int getClassPathIndex(IPackageFragmentRoot root) { try { if (fClassPath == null) fClassPath= root.getJavaProject().getResolvedClasspath(true); } catch (JavaModelException e) { return Integer.MAX_VALUE; } for (int i= 0; i < fClassPath.length; i++) { if (fClassPath[i].getPath().equals(root.getPath())) return i; } return Integer.MAX_VALUE; } };
4,074
Bug 4074 Add Import does not add to right group (1GI182E)
1. Ensure that at least "java" and "org.eclipse.swt" are defined in the import order pref page 2. Ensure SWT is on the build path of the test project 3. Add a new class with the following source: ------------------------------------------ import java.util.List; import org.eclipse.swt.SWT; public class AddImportBug { Set } ------------------------------------------ 4. Select Set 5. Add Import ==> The import is added to the org.eclipse group (before SWT) BTW: Organize import adds it to the right group NOTES: MA (27.08.2001 12:24:06) Need to change the separator placeholder structure. The information that the entry was matched to an other entry is lost.
verified fixed
971e3c5
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T09:53:28Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/core
4,074
Bug 4074 Add Import does not add to right group (1GI182E)
1. Ensure that at least "java" and "org.eclipse.swt" are defined in the import order pref page 2. Ensure SWT is on the build path of the test project 3. Add a new class with the following source: ------------------------------------------ import java.util.List; import org.eclipse.swt.SWT; public class AddImportBug { Set } ------------------------------------------ 4. Select Set 5. Add Import ==> The import is added to the org.eclipse group (before SWT) BTW: Organize import adds it to the right group NOTES: MA (27.08.2001 12:24:06) Need to change the separator placeholder structure. The information that the entry was matched to an other entry is lost.
verified fixed
971e3c5
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T09:53:28Z"
"2001-10-11T03:13:20Z"
extension/org/eclipse/jdt/internal/corext/codemanipulation/ImportsStructure.java
4,074
Bug 4074 Add Import does not add to right group (1GI182E)
1. Ensure that at least "java" and "org.eclipse.swt" are defined in the import order pref page 2. Ensure SWT is on the build path of the test project 3. Add a new class with the following source: ------------------------------------------ import java.util.List; import org.eclipse.swt.SWT; public class AddImportBug { Set } ------------------------------------------ 4. Select Set 5. Add Import ==> The import is added to the org.eclipse group (before SWT) BTW: Organize import adds it to the right group NOTES: MA (27.08.2001 12:24:06) Need to change the separator placeholder structure. The information that the entry was matched to an other entry is lost.
verified fixed
971e3c5
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T09:53:28Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/AnonymousTypeCompletionProposal.java
package org.eclipse.jdt.internal.ui.text.java; import org.eclipse.core.runtime.CoreException; import org.eclipse.swt.graphics.Image; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.util.Assert; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.codemanipulation.CodeGenerationSettings; import org.eclipse.jdt.internal.corext.codemanipulation.ImportsStructure; import org.eclipse.jdt.internal.corext.codemanipulation.StubUtility; import org.eclipse.jdt.internal.corext.textmanipulation.TextUtil; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.actions.OverrideMethodQuery; import org.eclipse.jdt.internal.ui.preferences.CodeFormatterPreferencePage; import org.eclipse.jdt.internal.ui.preferences.ImportOrganizePreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; public class AnonymousTypeCompletionProposal extends JavaCompletionProposal { private IType fDeclaringType; private ICompilationUnit fCompilationUnit; private ImportsStructure fImportStructure; public AnonymousTypeCompletionProposal(ICompilationUnit cu, int start, int length, String constructorCompletion, String displayName, String declaringTypeName) { super(constructorCompletion, start, length, null, displayName); Assert.isNotNull(cu); Assert.isNotNull(declaringTypeName); fCompilationUnit= cu; fDeclaringType= getDeclaringType(cu.getJavaProject(), declaringTypeName); setImage(getImageForType(fDeclaringType)); setCursorPosition(constructorCompletion.indexOf('(') + 1); } private Image getImageForType(IType type) { String imageName= JavaPluginImages.IMG_OBJS_CLASS; // default if (type != null) { try { if (type.isInterface()) { imageName= JavaPluginImages.IMG_OBJS_INTERFACE; } } catch (JavaModelException e) { JavaPlugin.log(e); } } return JavaPluginImages.get(imageName); } private IType getDeclaringType(IJavaProject project, String typeName) { try { return JavaModelUtil.findType(project, typeName); } catch (JavaModelException e) { JavaPlugin.log(e); } return null; } /* * @see JavaCompletionProposal#applyImports(IDocument) */ protected void applyImports(IDocument document) { if (fImportStructure != null) { try { fImportStructure.create(false, null); } catch (CoreException e) { JavaPlugin.log(e); } } } /* * @see ICompletionProposalExtension#apply(IDocument, char) */ public void apply(IDocument document, char trigger, int offset) { try { String[] prefOrder= ImportOrganizePreferencePage.getImportOrderPreference(); int threshold= ImportOrganizePreferencePage.getImportNumberThreshold(); fImportStructure= new ImportsStructure(fCompilationUnit, prefOrder, threshold, true); String replacementString= getReplacementString(); // construct replacement text StringBuffer buf= new StringBuffer(); buf.append(replacementString); if (!replacementString.endsWith(")")) { buf.append(')'); } buf.append(" {\n"); if (!createStubs(buf, fImportStructure)) { return; } buf.append("}"); // use the code formatter String lineDelim= StubUtility.getLineDelimiterFor(document); int tabWidth= CodeFormatterPreferencePage.getTabSize(); IRegion region= document.getLineInformationOfOffset(getReplacementOffset()); int indent= TextUtil.getIndent(document.get(region.getOffset(), region.getLength()), tabWidth); String replacement= StubUtility.codeFormat(buf.toString(), indent, lineDelim); replacement= TextUtil.removeLeadingWhiteSpaces(replacement); setReplacementString(replacement); } catch (BadLocationException e) { JavaPlugin.log(e); } catch (JavaModelException e) { JavaPlugin.log(e); } super.apply(document, trigger, offset); } private boolean createStubs(StringBuffer buf, ImportsStructure imports) throws JavaModelException { if (fDeclaringType == null) { return true; } CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); ITypeHierarchy hierarchy= fDeclaringType.newSupertypeHierarchy(null); OverrideMethodQuery selectionQuery= fDeclaringType.isClass() ? new OverrideMethodQuery(JavaPlugin.getActiveWorkbenchShell(), true) : null; String[] unimplemented= StubUtility.evalUnimplementedMethods(fDeclaringType, hierarchy, true, settings, selectionQuery, imports); if (unimplemented != null) { for (int i= 0; i < unimplemented.length; i++) { buf.append(unimplemented[i]); buf.append('\n'); } return true; } return false; } }
7,914
Bug 7914 Cannot copy a Java project in the packages view
There is no way to copy a Java project in the packages view. You can copy a project in the Navigator. This is a functional gap.
verified fixed
270c706
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T12:15:46Z"
"2002-01-19T22:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/CopyAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.reorg; import java.util.List; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jdt.internal.corext.refactoring.reorg.CopyRefactoring; import org.eclipse.jdt.internal.corext.refactoring.reorg.ReorgRefactoring; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; public class CopyAction extends ReorgDestinationAction { public CopyAction(StructuredSelectionProvider provider) { super(ReorgMessages.getString("copyAction.label"), provider); //$NON-NLS-1$ setDescription(ReorgMessages.getString("copyAction.description")); //$NON-NLS-1$ } public CopyAction(String name, StructuredSelectionProvider provider) { super(name, provider); } ReorgRefactoring createRefactoring(List elements){ return new CopyRefactoring(elements); } String getActionName() { return ReorgMessages.getString("copyAction.name"); //$NON-NLS-1$ } String getDestinationDialogMessage() { return ReorgMessages.getString("copyAction.destination.label"); //$NON-NLS-1$ } }
7,914
Bug 7914 Cannot copy a Java project in the packages view
There is no way to copy a Java project in the packages view. You can copy a project in the Navigator. This is a functional gap.
verified fixed
270c706
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T12:15:46Z"
"2002-01-19T22:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/JdtDeleteResourceAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.reorg; import java.text.MessageFormat; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.core.resources.IProject; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.refactoring.Assert; import org.eclipse.jdt.internal.corext.refactoring.reorg.DeleteRefactoring; import org.eclipse.jdt.internal.corext.refactoring.reorg.ReorgUtils; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIException; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.ui.actions.DeleteResourceAction; import org.eclipse.swt.widgets.Shell; import org.eclipse.jdt.internal.corext.refactoring.reorg.*; /** * Action for deleting elements in a delete target. */ class JdtDeleteResourceAction extends ReorgAction { private boolean fDeleteProjectContent; public JdtDeleteResourceAction(ISelectionProvider provider) { super(ReorgMessages.getString("deleteAction.label"), provider); //$NON-NLS-1$ setDescription(ReorgMessages.getString("deleteAction.description")); //$NON-NLS-1$ } /** * The user has invoked this action */ public void run() { if (hasOnlyProjects()){ deleteProjects(); return; } DeleteRefactoring refactoring= new DeleteRefactoring(getStructuredSelection().toList()); fDeleteProjectContent= false; if (!confirmDelete()) return; if (hasReadOnlyResources() && !isOkToDeleteReadOnly()) return; refactoring.setDeleteProjectContents(fDeleteProjectContent); try{ MultiStatus status= ReorgAction.perform(refactoring); if (!status.isOK()) { JavaUIException t= new JavaUIException(status); ExceptionHandler.handle(t, "Delete", "Unexpected exception. See log for details."); } } catch (JavaModelException e){ ExceptionHandler.handle(e, "Delete", "Unexpected exception. See log for details."); return; } } private boolean hasOnlyProjects(){ return (! getStructuredSelection().isEmpty() && getStructuredSelection().size() == getProjects().size()); } private void deleteProjects(){ DeleteResourceAction action= new DeleteResourceAction(JavaPlugin.getActiveWorkbenchShell()); action.selectionChanged(getStructuredSelection()); action.run(); } private static boolean isOkToDeleteReadOnly(){ String msg= ReorgMessages.getString("deleteAction.confirmReadOnly"); //$NON-NLS-1$ String title= ReorgMessages.getString("deleteAction.checkDeletion"); //$NON-NLS-1$ return MessageDialog.openQuestion( JavaPlugin.getActiveWorkbenchShell(), title, msg); } private boolean hasReadOnlyResources(){ for (Iterator iter= getStructuredSelection().iterator(); iter.hasNext();){ if (ReorgUtils.shouldConfirmReadOnly(iter.next())) return true; } return false; } /* non java-doc * @see IRefactoringAction#canOperateOn(IStructuredSelection) */ public boolean canOperateOn(IStructuredSelection selection) { return ReorgAction.canActivate(new DeleteRefactoring(selection.toList())); } private boolean confirmDelete() { Assert.isTrue(getProjects().isEmpty()); String title= ReorgMessages.getString("deleteAction.confirm.title"); //$NON-NLS-1$ String label= ReorgMessages.getString("deleteAction.confirm.message"); //$NON-NLS-1$ Shell parent= JavaPlugin.getActiveWorkbenchShell(); return MessageDialog.openConfirm(parent, title, label); } private List getProjects() { List result= new ArrayList(getStructuredSelection().size()); for(Iterator iter= getStructuredSelection().iterator(); iter.hasNext(); ) { Object element= iter.next(); if (element instanceof IJavaProject) { try { result.add(((IJavaProject)element).getUnderlyingResource()); } catch (JavaModelException e) { if (!e.isDoesNotExist()) { //do not show error dialogs in a loop JavaPlugin.log(e); } } } } return result; } }
7,914
Bug 7914 Cannot copy a Java project in the packages view
There is no way to copy a Java project in the packages view. You can copy a project in the Navigator. This is a functional gap.
verified fixed
270c706
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T12:15:46Z"
"2002-01-19T22:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/MoveAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.reorg; import java.lang.reflect.InvocationTargetException; import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Set; import org.eclipse.core.runtime.CoreException; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.ui.texteditor.IDocumentProvider; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaElementContentProvider; import org.eclipse.jdt.internal.corext.refactoring.Assert; import org.eclipse.jdt.internal.corext.refactoring.base.IChange; import org.eclipse.jdt.internal.corext.refactoring.base.Refactoring; import org.eclipse.jdt.internal.corext.refactoring.reorg.MoveRefactoring; import org.eclipse.jdt.internal.corext.refactoring.reorg.ReorgRefactoring; import org.eclipse.jdt.internal.corext.refactoring.reorg.ReorgUtils; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; import org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation; import org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard; import org.eclipse.jdt.internal.ui.refactoring.RefactoringWizardDialog; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; public class MoveAction extends ReorgDestinationAction { private boolean fShowPreview= false; public MoveAction(String name, StructuredSelectionProvider provider) { super(name, provider); setDescription(ReorgMessages.getString("moveAction.description")); //$NON-NLS-1$ } public MoveAction(StructuredSelectionProvider provider) { super(ReorgMessages.getString("moveAction.label"), provider); //$NON-NLS-1$ } /* non java-doc * see @ReorgDestinationAction#isOkToProceed */ String getActionName() { return ReorgMessages.getString("moveAction.name"); //$NON-NLS-1$ } /* non java-doc * see @ReorgDestinationAction#getDestinationDialogMessage */ String getDestinationDialogMessage() { return ReorgMessages.getString("moveAction.destination.label"); //$NON-NLS-1$ } /* non java-doc * see @ReorgDestinationAction#createRefactoring */ ReorgRefactoring createRefactoring(List elements){ return new MoveRefactoring(elements, JavaPreferencesSettings.getCodeGenerationSettings()); } ElementTreeSelectionDialog createDestinationSelectionDialog(Shell parent, ILabelProvider labelProvider, JavaElementContentProvider cp, ReorgRefactoring refactoring){ return new MoveDestinationDialog(parent, labelProvider, cp, (MoveRefactoring)refactoring); } /* non java-doc * see @ReorgDestinationAction#isOkToProceed */ protected boolean isOkToProceed(ReorgRefactoring refactoring) throws JavaModelException{ return (isOkToMoveReadOnly(refactoring)); } /* * @see ReorgDestinationAction#getExcluded(ReorgRefactoring) */ Set getExcluded(ReorgRefactoring refactoring) throws JavaModelException{ Set elements= refactoring.getElementsThatExistInTarget(); Set result= new HashSet(); for (Iterator iter= elements.iterator(); iter.hasNext(); ){ Object o= iter.next(); int action= askIfOverwrite(ReorgUtils.getName(o)); if (action == IDialogConstants.CANCEL_ID) return null; if (action == IDialogConstants.YES_TO_ALL_ID) return new HashSet(0); //nothing excluded if (action == IDialogConstants.NO_ID) result.add(o); } return result; } private static int askIfOverwrite(String elementName){ Shell shell= JavaPlugin.getActiveWorkbenchShell().getShell(); String title= "Move"; String question= "Element '" + elementName + "' already exists. Would you like to overwrite?"; String[] labels= new String[] {IDialogConstants.YES_LABEL, IDialogConstants.YES_TO_ALL_LABEL, IDialogConstants.NO_LABEL, IDialogConstants.CANCEL_LABEL }; final MessageDialog dialog = new MessageDialog(shell, title, null, question, MessageDialog.QUESTION, labels, 0); shell.getDisplay().syncExec(new Runnable() { public void run() { dialog.open(); } }); int result = dialog.getReturnCode(); if (result == 0) return IDialogConstants.YES_ID; if (result == 1) return IDialogConstants.YES_TO_ALL_ID; if (result == 2) return IDialogConstants.NO_ID; return IDialogConstants.CANCEL_ID; } protected void setShowPreview(boolean showPreview) { fShowPreview = showPreview; } private static boolean isOkToMoveReadOnly(ReorgRefactoring refactoring){ if (! hasReadOnlyElements(refactoring)) return true; return MessageDialog.openQuestion( JavaPlugin.getActiveWorkbenchShell(), ReorgMessages.getString("moveAction.checkMove"), //$NON-NLS-1$ ReorgMessages.getString("moveAction.error.readOnly")); //$NON-NLS-1$ } private static boolean hasReadOnlyElements(ReorgRefactoring refactoring){ for (Iterator iter= refactoring.getElementsToReorg().iterator(); iter.hasNext(); ){ if (ReorgUtils.shouldConfirmReadOnly(iter.next())) return true; } return false; } /* non java-doc * @see ReorgDestinationAction#doReorg(ReorgRefactoring) */ void doReorg(ReorgRefactoring refactoring) throws JavaModelException{ if (!fShowPreview){ super.doReorg(refactoring); return; } //XX incorrect help RefactoringWizard wizard= new RefactoringWizard(refactoring, "Move", IJavaHelpContextIds.MOVE_CU_ERROR_WIZARD_PAGE); new RefactoringWizardDialog(JavaPlugin.getActiveWorkbenchShell(), wizard).open(); } //--- static inner classes private class MoveDestinationDialog extends ElementTreeSelectionDialog { private static final int PREVIEW_ID= IDialogConstants.CLIENT_ID + 1; private MoveRefactoring fRefactoring; private Button fCheckbox; private Button fPreview; MoveDestinationDialog(Shell parent, ILabelProvider labelProvider, ITreeContentProvider contentProvider, MoveRefactoring refactoring){ super(parent, labelProvider, contentProvider); fRefactoring= refactoring; fShowPreview= false;//from outter instance } protected Control createDialogArea(Composite parent) { Composite result= (Composite)super.createDialogArea(parent); fCheckbox= new Button(result, SWT.CHECK); fCheckbox.setText("Update references to the moved element(s)."); fCheckbox.setEnabled(canUpdateReferences()); fCheckbox.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { updatePreviewButton(); fRefactoring.setUpdateReferences(fCheckbox.getEnabled() && fCheckbox.getSelection()); } }); fCheckbox.setSelection(canUpdateReferences()); return result; } protected void createButtonsForButtonBar(Composite parent) { super.createButtonsForButtonBar(parent); fPreview= createButton(parent, PREVIEW_ID, "Preview", false); } protected void updateOKStatus() { super.updateOKStatus(); try{ fRefactoring.setDestination(getFirstResult()); fCheckbox.setEnabled(getOkButton().getEnabled() && canUpdateReferences()); updatePreviewButton(); } catch (JavaModelException e){ ExceptionHandler.handle(e, "Move", "Unexpected exception occurred. See log for details."); } } protected void buttonPressed(int buttonId) { fShowPreview= (buttonId == PREVIEW_ID); super.buttonPressed(buttonId); if (buttonId == PREVIEW_ID) close(); } private void updatePreviewButton(){ fPreview.setEnabled(fCheckbox.getEnabled() && fCheckbox.getSelection()); } private boolean canUpdateReferences(){ try{ return fRefactoring.canUpdateReferences(); } catch (JavaModelException e){ return false; } } } }
7,914
Bug 7914 Cannot copy a Java project in the packages view
There is no way to copy a Java project in the packages view. You can copy a project in the Navigator. This is a functional gap.
verified fixed
270c706
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T12:15:46Z"
"2002-01-19T22:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/ReorgAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.reorg; import java.lang.reflect.InvocationTargetException; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.refactoring.base.ChangeContext; import org.eclipse.jdt.internal.corext.refactoring.base.Refactoring; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation; import org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringAction; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; /** * Base class for actions related to reorganizing resources */ public abstract class ReorgAction extends RefactoringAction { public ReorgAction(String name, StructuredSelectionProvider p) { super(name, p); } public ReorgAction(String name, ISelectionProvider p) { super(name, p); } static boolean canActivate(Refactoring ref){ try { return ref.checkActivation(new NullProgressMonitor()).isOK(); } catch (JavaModelException e) { ExceptionHandler.handle(e, "Exception", "Unexpected exception. See log for details."); return false; } } static MultiStatus perform(Refactoring ref) throws JavaModelException{ PerformChangeOperation op= new PerformChangeOperation(new CreateChangeOperation(ref, CreateChangeOperation.CHECK_NONE)); ReorgExceptionHandler handler= new ReorgExceptionHandler(); op.setChangeContext(new ChangeContext(handler)); try { //cannot fork - must run in the ui thread new ProgressMonitorDialog(JavaPlugin.getActiveWorkbenchShell()).run(false, true, op); } catch (InvocationTargetException e) { Throwable target= e.getTargetException(); if (target instanceof CoreException) handler.getStatus().merge(((CoreException) target).getStatus()); JavaPlugin.log(e); //fall thru } catch (InterruptedException e) { //fall thru } return handler.getStatus(); } }
7,914
Bug 7914 Cannot copy a Java project in the packages view
There is no way to copy a Java project in the packages view. You can copy a project in the Navigator. This is a functional gap.
verified fixed
270c706
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T12:15:46Z"
"2002-01-19T22:40:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/ReorgDestinationAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.reorg; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Arrays; import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Set; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.core.runtime.Path; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.dialogs.ListSelectionDialog; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaElementContentProvider; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.corext.refactoring.Assert; import org.eclipse.jdt.internal.corext.refactoring.reorg.ReorgRefactoring; import org.eclipse.jdt.internal.corext.refactoring.reorg.ReorgUtils; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIException; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ISelectionValidator; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.packageview.PackageFilter; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.viewsupport.ListContentProvider; abstract class ReorgDestinationAction extends ReorgAction { public ReorgDestinationAction(String name, ISelectionProvider provider) { super(name, provider); } public ReorgDestinationAction(String name, StructuredSelectionProvider provider) { super(name, provider); } public void run() { List elements= getStructuredSelection().toList(); if (!ensureSaved(elements, getActionName())) return; ReorgRefactoring refactoring= createRefactoring(elements); setUnsavedFileList(refactoring, elements); Object destination= selectDestination(refactoring); if (destination == null) return; try{ String duplicate= getDuplicatedElementName(elements); if (duplicate != null){ String message= "Two or more elements named " + duplicate + " are selected."; MessageDialog.openInformation(JavaPlugin.getActiveWorkbenchShell().getShell(), "Duplicate Element Name", message); return; } refactoring.setDestination(destination); Set excluded= getExcluded(refactoring); if (excluded == null) //canceled return; if (excluded.size() == elements.size()) return; refactoring.setExcludedElements(excluded); if (! isOkToProceed(refactoring)) return; doReorg(refactoring); } catch (JavaModelException e){ ExceptionHandler.handle(e, "Exception", "Unexpected exception occurred. See log for details."); } } /** * returns null if no 2 elements have the same name */ private static String getDuplicatedElementName(List elements){ String[] names= getElementNames(elements); if (names.length == 0) return null; Arrays.sort(names); String last= names[0]; for (int i= 1; i < names.length; i++){ //non standard loop if (last.equals(names[i])) return last; last= names[i]; } return null; } abstract String getActionName(); abstract String getDestinationDialogMessage(); abstract ReorgRefactoring createRefactoring(List elements); //hook to override //returns null iff canceled Set getExcluded(ReorgRefactoring refactoring) throws JavaModelException{ return new HashSet(0); } //hook to override protected boolean isOkToProceed(ReorgRefactoring refactoring) throws JavaModelException{ return true; } void doReorg(ReorgRefactoring refactoring) throws JavaModelException{ MultiStatus status= perform(refactoring); if (status.isOK()) return; ExceptionHandler.handle(new JavaUIException(status), ReorgMessages.getString("copyAction.exception.title"), //$NON-NLS-1$ ReorgMessages.getString("copyAction.exception.label")); //$NON-NLS-1$ } private static boolean ensureSaved(List elements, String actionName) { List unsavedEditors= new ArrayList(); List unsavedElements= new ArrayList(); collectUnsavedEditors(elements, unsavedEditors, unsavedElements); if (unsavedEditors.isEmpty()) return true; ListSelectionDialog dialog = createUnsavedEditorDialog(unsavedElements); if (dialog.open() != dialog.OK) return false; IRunnableWithProgress r= createSaveEditorOperation(dialog.getResult(), elements, unsavedEditors); try { new ProgressMonitorDialog(JavaPlugin.getActiveWorkbenchShell()).run(false, false, r); } catch (InvocationTargetException e) { ExceptionHandler.handle(e, actionName, ReorgMessages.getString("ReorgAction.exception.saving")); //$NON-NLS-1$ return false; } catch (InterruptedException e) { } return true; } private static void setUnsavedFileList(ReorgRefactoring refactoring, List elements){ List unsavedEditors= new ArrayList(0); collectUnsavedEditors(elements, unsavedEditors, new ArrayList(0)); refactoring.setUnsavedFiles(getFiles(unsavedEditors)); } private static IFile[] getFiles(List editorParts){ List result= new ArrayList(editorParts.size()); for (Iterator iter= editorParts.iterator(); iter.hasNext(); ){ IEditorPart each= (IEditorPart)iter.next(); IEditorInput input= each.getEditorInput(); if (input instanceof IFileEditorInput) result.add(((IFileEditorInput)input).getFile()); } return (IFile[]) result.toArray(new IFile[result.size()]); } private static IRunnableWithProgress createSaveEditorOperation(final Object[] elementsToSave, final List elements, final List unsavedEditors) { return new IRunnableWithProgress() { public void run(IProgressMonitor pm) { pm.beginTask(ReorgMessages.getString("ReorgAction.task.saving"), elementsToSave.length); //$NON-NLS-1$ for (int i= 0; i < elementsToSave.length; i++) { IEditorPart editor= (IEditorPart)unsavedEditors.get(elements.indexOf(elementsToSave[i])); editor.doSave(new SubProgressMonitor(pm, 1)); } pm.done(); } }; } private static ListSelectionDialog createUnsavedEditorDialog(List unsavedElements) { int labelFlags= JavaElementLabelProvider.SHOW_DEFAULT | JavaElementLabelProvider.SHOW_POST_QUALIFIED; Shell parent= JavaPlugin.getActiveWorkbenchShell(); String msg= ReorgMessages.getString("ReorgAction.checkSaveTargets"); //$NON-NLS-1$ ListSelectionDialog dialog= new ListSelectionDialog(parent, unsavedElements, new ListContentProvider(), new JavaElementLabelProvider(labelFlags), msg); dialog.setInitialSelections(unsavedElements.toArray()); return dialog; } private static void collectUnsavedEditors(List elements, List unsavedEditors, List unsavedElements) { IEditorPart[] editors= JavaPlugin.getDirtyEditors(); for (int i= 0; i < editors.length; i++) { for (Iterator iter= elements.iterator(); iter.hasNext(); ){ Object element= iter.next(); if (EditorUtility.isEditorInput(element, editors[i])) { unsavedEditors.add(editors[i]); unsavedElements.add(element); } } } } private static String[] getElementNames(List elements){ String[] result= new String[elements.size()]; int i= 0; for (Iterator iter= elements.iterator(); iter.hasNext(); ){ result[i]= ReorgUtils.getName(iter.next()); i++; } return result; } //overriden by d'n'd - must be protected protected Object selectDestination(ReorgRefactoring refactoring) { JavaElementContentProvider cp= new JavaElementContentProvider() { public boolean hasChildren(Object element) { // prevent the + from being shown in front of packages return !(element instanceof IPackageFragment) && super.hasChildren(element); } }; ElementTreeSelectionDialog dialog= createDestinationSelectionDialog(JavaPlugin.getActiveWorkbenchShell(), new DestinationRenderer(JavaElementLabelProvider.SHOW_SMALL_ICONS ), cp, refactoring); dialog.setTitle(getActionName()); dialog.setValidator(new ReorgSelectionValidator(refactoring)); dialog.addFilter(new ContainerFilter(refactoring)); dialog.setSorter(new JavaElementSorter()); dialog.setMessage(getDestinationDialogMessage()); dialog.setSize(60, 18); dialog.setInput(JavaCore.create(ResourcesPlugin.getWorkspace().getRoot())); dialog.setInitialSelection(computeCommonParent(refactoring.getElementsToReorg())); if (dialog.open() != dialog.CANCEL) return dialog.getFirstResult(); return null; } ElementTreeSelectionDialog createDestinationSelectionDialog(Shell parent, ILabelProvider labelProvider, JavaElementContentProvider cp, ReorgRefactoring refactoring){ return new ElementTreeSelectionDialog(parent, labelProvider, cp); } private static Object computeCommonParent(List elements){ if (elements.isEmpty()) return null; Object parent= elements.get(0); for (Iterator iter= elements.iterator(); iter.hasNext(); ){ parent= computeCommonParent(parent, iter.next()); } IResource parentRes= getResource(parent); IJavaElement parentElement= JavaCore.create(parentRes); if (parentElement != null) return parentElement; return getResource(parent); } private static Object computeCommonParent(Object e1, Object e2){ IResource r1= getResource(e1); IResource r2= getResource(e2); if (r1 == null && r2 == null) return null; if (r1 == null) return r2.getParent(); if (r2 == null) return r1.getParent(); if (r1.equals(r2)) return r1.getParent(); if (r1.getFullPath().isPrefixOf(r2.getFullPath())) return r1; if (r2.getFullPath().isPrefixOf(r1.getFullPath())) return r2; IPath p1= r1.getParent().getFullPath(); IPath p2= r2.getParent().getFullPath(); IPath commonPath= new Path(""); int segCount= Math.min(p1.segmentCount(), p2.segmentCount()); for (int i= 0; i < segCount; i++){ if (p1.segment(i).equals(p2.segment(i))) commonPath= commonPath.append(p1.segment(i)); else break; } return ResourcesPlugin.getWorkspace().getRoot().findMember(commonPath); } private static IResource getResource(Object o) { try{ if (o instanceof IResource) return (IResource)o; else if (o instanceof IJavaElement) return ((IJavaElement)o).getCorrespondingResource(); else return null; } catch (JavaModelException e){ JavaPlugin.log(e); return null; } } /* non java-doc * @see IRefactoringAction#canOperateOn(IStructuredSelection) */ public boolean canOperateOn(IStructuredSelection selection) { return canActivate(createRefactoring(selection.toList())); } //----- private static class ContainerFilter extends PackageFilter { private ReorgRefactoring fRefactoring; ContainerFilter(ReorgRefactoring refactoring) { Assert.isNotNull(refactoring); fRefactoring= refactoring; } public boolean select(Viewer viewer, Object parent, Object o) { if (fRefactoring.getElementsToReorg().contains(o)) return false; return fRefactoring.canBeAncestor(o); } } //----- private static class DestinationRenderer extends JavaElementLabelProvider { public DestinationRenderer(int flags) { super(flags); } public String getText(Object element) { try { if (element instanceof IPackageFragmentRoot) { IPackageFragmentRoot root= (IPackageFragmentRoot)element; if (root.getUnderlyingResource() instanceof IProject) return ReorgMessages.getString("DestinationRenderer.packages"); //$NON-NLS-1$ } } catch (JavaModelException e) { ExceptionHandler.handle(e, "Exception", "Unexpected exception occurred. See log for details."); } return super.getText(element); } } //------ private static class ReorgSelectionValidator implements ISelectionValidator { private ReorgRefactoring fRefactoring; public ReorgSelectionValidator(ReorgRefactoring refactoring) { Assert.isNotNull(refactoring); fRefactoring= refactoring; } public IStatus validate(Object[] selection) { if (selection.length != 1) return new StatusInfo(IStatus.ERROR, ""); try{ if (fRefactoring.isValidDestination(selection[0])) return new StatusInfo(); return new StatusInfo(IStatus.ERROR, ""); } catch (JavaModelException e){ ExceptionHandler.handle(e, "Exception", "Unexpected exception occurred. See log for details."); return new StatusInfo(IStatus.ERROR, ""); } } } }
6,146
Bug 6146 Java Editor Preference Page is missing most of the mnemonics
summary says it all.
resolved fixed
0322ef0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T12:20:26Z"
"2001-11-21T08:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaEditorPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.HashMap; import java.util.Iterator; import java.util.Map; import org.eclipse.swt.SWT; import org.eclipse.swt.events.ModifyEvent; import org.eclipse.swt.events.ModifyListener; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.List; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Text; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IDocumentPartitioner; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.util.IPropertyChangeListener; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.texteditor.AbstractTextEditor; import org.eclipse.ui.texteditor.WorkbenchChainedTextFontFieldEditor; import org.eclipse.jdt.ui.text.IJavaColorConstants; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; /* * The page for setting the editor options. */ public class JavaEditorPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { public final OverlayPreferenceStore.OverlayKey[] fKeys= new OverlayPreferenceStore.OverlayKey[] { new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_KEYWORD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_KEYWORD + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_STRING), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_STRING + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVA_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVA_DEFAULT + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_KEYWORD), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_KEYWORD + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_TAG), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_TAG + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_LINK), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_LINK + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, IJavaColorConstants.JAVADOC_DEFAULT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, IJavaColorConstants.JAVADOC_DEFAULT + "_bold"), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, CompilationUnitEditor.MATCHING_BRACKETS_COLOR), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, CompilationUnitEditor.MATCHING_BRACKETS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.AUTOACTIVATION), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, ContentAssistPreference.AUTOACTIVATION_DELAY), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.AUTOINSERT), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PROPOSALS_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PROPOSALS_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PARAMETERS_BACKGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.PARAMETERS_FOREGROUND), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.SHOW_VISIBLE_PROPOSALS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.ORDER_PROPOSALS), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.CASE_SENSITIVITY), new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, ContentAssistPreference.ADD_IMPORT) }; private final String[][] fListModel= new String[][] { { "Multi-line comment", IJavaColorConstants.JAVA_MULTI_LINE_COMMENT }, { "Single-line comment", IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT }, { "Keywords", IJavaColorConstants.JAVA_KEYWORD }, { "Strings", IJavaColorConstants.JAVA_STRING }, { "Others", IJavaColorConstants.JAVA_DEFAULT }, { "JavaDoc keywords", IJavaColorConstants.JAVADOC_KEYWORD }, { "JavaDoc HTML tags", IJavaColorConstants.JAVADOC_TAG }, { "JavaDoc links", IJavaColorConstants.JAVADOC_LINK }, {"JavaDoc others", IJavaColorConstants.JAVADOC_DEFAULT } }; private OverlayPreferenceStore fOverlayStore; private JavaTextTools fJavaTextTools; private Map fColorButtons= new HashMap(); private SelectionListener fColorButtonListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { } public void widgetSelected(SelectionEvent e) { ColorEditor editor= (ColorEditor) e.widget.getData(); PreferenceConverter.setValue(fOverlayStore, (String) fColorButtons.get(editor), editor.getColorValue()); } }; private Map fCheckBoxes= new HashMap(); private SelectionListener fCheckBoxListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { } public void widgetSelected(SelectionEvent e) { Button button= (Button) e.widget; fOverlayStore.setValue((String) fCheckBoxes.get(button), button.getSelection()); } }; private Map fTextFields= new HashMap(); private ModifyListener fTextFieldListener= new ModifyListener() { public void modifyText(ModifyEvent e) { Text text= (Text) e.widget; fOverlayStore.setValue((String) fTextFields.get(text), text.getText()); } }; private WorkbenchChainedTextFontFieldEditor fFontEditor; private List fList; private ColorEditor fColorEditor; private Button fBoldCheckBox; private SourceViewer fPreviewViewer; public JavaEditorPreferencePage() { setDescription(JavaUIMessages.getString("JavaEditorPreferencePage.description")); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); fOverlayStore= new OverlayPreferenceStore(getPreferenceStore(), fKeys); } public static void initDefaults(IPreferenceStore store) { Color color; Display display= Display.getDefault(); store.setDefault(CompilationUnitEditor.MATCHING_BRACKETS, true); color= display.getSystemColor(SWT.COLOR_GRAY); PreferenceConverter.setDefault(store, CompilationUnitEditor.MATCHING_BRACKETS_COLOR, color.getRGB()); WorkbenchChainedTextFontFieldEditor.startPropagate(store, JFaceResources.TEXT_FONT); color= display.getSystemColor(SWT.COLOR_LIST_FOREGROUND); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND, color.getRGB()); color= display.getSystemColor(SWT.COLOR_LIST_BACKGROUND); PreferenceConverter.setDefault(store, AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND, color.getRGB()); store.setDefault(JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH, 4); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_MULTI_LINE_COMMENT, new RGB(63, 127, 95)); store.setDefault(IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + "_bold", false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT, new RGB(63, 127, 95)); store.setDefault(IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + "_bold", false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_KEYWORD, new RGB(127, 0, 85)); store.setDefault(IJavaColorConstants.JAVA_KEYWORD + "_bold", true); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_STRING, new RGB(42, 0, 255)); store.setDefault(IJavaColorConstants.JAVA_STRING + "_bold", false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVA_DEFAULT, new RGB(0, 0, 0)); store.setDefault(IJavaColorConstants.JAVA_DEFAULT + "_bold", false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_KEYWORD, new RGB(127, 159, 191)); store.setDefault(IJavaColorConstants.JAVADOC_KEYWORD + "_bold", true); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_TAG, new RGB(127, 127, 159)); store.setDefault(IJavaColorConstants.JAVADOC_TAG + "_bold", false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_LINK, new RGB(63, 63, 191)); store.setDefault(IJavaColorConstants.JAVADOC_LINK + "_bold", false); PreferenceConverter.setDefault(store, IJavaColorConstants.JAVADOC_DEFAULT, new RGB(63, 95, 191)); store.setDefault(IJavaColorConstants.JAVADOC_DEFAULT + "_bold", false); store.setDefault(ContentAssistPreference.AUTOACTIVATION, true); store.setDefault(ContentAssistPreference.AUTOACTIVATION_DELAY, 500); store.setDefault(ContentAssistPreference.AUTOINSERT, false); PreferenceConverter.setDefault(store, ContentAssistPreference.PROPOSALS_BACKGROUND, new RGB(254, 241, 233)); PreferenceConverter.setDefault(store, ContentAssistPreference.PROPOSALS_FOREGROUND, new RGB(0, 0, 0)); PreferenceConverter.setDefault(store, ContentAssistPreference.PARAMETERS_BACKGROUND, new RGB(254, 241, 233)); PreferenceConverter.setDefault(store, ContentAssistPreference.PARAMETERS_FOREGROUND, new RGB(0, 0, 0)); store.setDefault(ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA, ".,"); store.setDefault(ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC, "@"); store.setDefault(ContentAssistPreference.SHOW_VISIBLE_PROPOSALS, false); store.setDefault(ContentAssistPreference.CASE_SENSITIVITY, false); store.setDefault(ContentAssistPreference.ORDER_PROPOSALS, false); store.setDefault(ContentAssistPreference.ADD_IMPORT, true); } /* * @see IWorkbenchPreferencePage#init() */ public void init(IWorkbench workbench) { } /* * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { super.createControl(parent); WorkbenchHelp.setHelp(getControl(), new DialogPageContextComputer(this, IJavaHelpContextIds.JAVA_EDITOR_PREFERENCE_PAGE)); } private void handleListSelection() { int i= fList.getSelectionIndex(); String key= fListModel[i][1]; RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); fColorEditor.setColorValue(rgb); fBoldCheckBox.setSelection(fOverlayStore.getBoolean(key + "_bold")); } private Control createColorPage(Composite parent) { Composite colorComposite= new Composite(parent, SWT.NULL); colorComposite.setLayout(new GridLayout()); Label label= new Label(colorComposite, SWT.LEFT); label.setText("Colors"); label.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); Composite editorComposite= new Composite(colorComposite, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; editorComposite.setLayout(layout); GridData gd= new GridData(GridData.FILL_BOTH); editorComposite.setLayoutData(gd); fList= new List(editorComposite, SWT.SINGLE | SWT.V_SCROLL); gd= new GridData(GridData.FILL_BOTH); gd.heightHint= convertHeightInCharsToPixels(5); fList.setLayoutData(gd); Composite stylesComposite= new Composite(editorComposite, SWT.NULL); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 2; stylesComposite.setLayout(layout); stylesComposite.setLayoutData(new GridData(GridData.FILL_BOTH)); label= new Label(stylesComposite, SWT.LEFT); label.setText("Foreground:"); gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; label.setLayoutData(gd); fColorEditor= new ColorEditor(stylesComposite); Button colorButton= fColorEditor.getButton(); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; colorButton.setLayoutData(gd); label= new Label(stylesComposite, SWT.LEFT); label.setText("Bold:"); gd= new GridData(); gd.horizontalAlignment= GridData.BEGINNING; label.setLayoutData(gd); fBoldCheckBox= new Button(stylesComposite, SWT.CHECK); gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalAlignment= GridData.BEGINNING; fBoldCheckBox.setLayoutData(gd); label= new Label(colorComposite, SWT.LEFT); label.setText("Preview"); label.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); Control previewer= createPreviewer(colorComposite); gd= new GridData(GridData.FILL_BOTH); gd.widthHint= convertWidthInCharsToPixels(80); gd.heightHint= convertHeightInCharsToPixels(15); previewer.setLayoutData(gd); fList.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { handleListSelection(); } }); colorButton.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fList.getSelectionIndex(); String key= fListModel[i][1]; PreferenceConverter.setValue(fOverlayStore, key, fColorEditor.getColorValue()); } }); fBoldCheckBox.addSelectionListener(new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) { // do nothing } public void widgetSelected(SelectionEvent e) { int i= fList.getSelectionIndex(); String key= fListModel[i][1]; fOverlayStore.setValue(key + "_bold", fBoldCheckBox.getSelection()); } }); return colorComposite; } private Control createPreviewer(Composite parent) { fJavaTextTools= new JavaTextTools(fOverlayStore); fPreviewViewer= new SourceViewer(parent, null, SWT.V_SCROLL | SWT.H_SCROLL); fPreviewViewer.configure(new JavaSourceViewerConfiguration(fJavaTextTools, null)); fPreviewViewer.getTextWidget().setFont(JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT)); fPreviewViewer.setEditable(false); String content= loadPreviewContentFromFile("ColorSettingPreviewCode.txt"); IDocument document= new Document(content); IDocumentPartitioner partitioner= fJavaTextTools.createDocumentPartitioner(); partitioner.connect(document); document.setDocumentPartitioner(partitioner); fPreviewViewer.setDocument(document); fOverlayStore.addPropertyChangeListener(new IPropertyChangeListener() { public void propertyChange(PropertyChangeEvent event) { fPreviewViewer.invalidateTextPresentation(); } }); return fPreviewViewer.getControl(); } private Control createBehaviorPage(Composite parent) { Composite behaviorComposite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; behaviorComposite.setLayout(layout); String label= "Highlight matching brackets"; addCheckBox(behaviorComposite, label, CompilationUnitEditor.MATCHING_BRACKETS, 0); label= "Matching brackets highlight color:"; addColorButton(behaviorComposite, label, CompilationUnitEditor.MATCHING_BRACKETS_COLOR, 0); label= "Text font:"; addTextFontEditor(behaviorComposite, label, AbstractTextEditor.PREFERENCE_FONT); label= "&Displayed tab width:"; addTextField(behaviorComposite, label, JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH, 2, 0); return behaviorComposite; } private Control createContentAssistPage(Composite parent) { Composite contentAssistComposite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 2; contentAssistComposite.setLayout(layout); String label= "Insert &single proposals automatically"; addCheckBox(contentAssistComposite, label, ContentAssistPreference.AUTOINSERT, 0); label= "Show only proposals visible in the invocation &context"; addCheckBox(contentAssistComposite, label, ContentAssistPreference.SHOW_VISIBLE_PROPOSALS, 0); // label= "Show only proposals with &matching cases"; // addCheckBox(contentAssistComposite, label, ContentAssistPreference.CASE_SENSITIVITY, 0); label= "Present proposals in &alphabetical order"; addCheckBox(contentAssistComposite, label, ContentAssistPreference.ORDER_PROPOSALS, 0); label= "&Enable auto activation"; addCheckBox(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION, 0); label= "Automatically add &import instead of qualified name"; addCheckBox(contentAssistComposite, label, ContentAssistPreference.ADD_IMPORT, 0); label= "Auto activation &delay:"; addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_DELAY, 4, 0); label= "Auto activation &triggers for Java:"; addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA, 25, 0); label= "Auto activation tri&ggers for JavaDoc:"; addTextField(contentAssistComposite, label, ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC, 25, 0); label= "&Background for completion proposals:"; addColorButton(contentAssistComposite, label, ContentAssistPreference.PROPOSALS_BACKGROUND, 0); label= "&Foreground for completion proposals:"; addColorButton(contentAssistComposite, label, ContentAssistPreference.PROPOSALS_FOREGROUND, 0); label= "B&ackground for method parameters:"; addColorButton(contentAssistComposite, label, ContentAssistPreference.PARAMETERS_BACKGROUND, 0); label= "F&oreground for method parameters:"; addColorButton(contentAssistComposite, label, ContentAssistPreference.PARAMETERS_FOREGROUND, 0); return contentAssistComposite; } /* * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { fOverlayStore.load(); fOverlayStore.start(); TabFolder folder= new TabFolder(parent, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); TabItem item= new TabItem(folder, SWT.NONE); item.setText("&General"); item.setImage(JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CFILE)); item.setControl(createBehaviorPage(folder)); item= new TabItem(folder, SWT.NONE); item.setText("&Colors"); item.setImage(JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CFILE)); item.setControl(createColorPage(folder)); item= new TabItem(folder, SWT.NONE); item.setText("Code &Assist"); item.setImage(JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CFILE)); item.setControl(createContentAssistPage(folder)); initialize(); return folder; } private void initialize() { fFontEditor.setPreferenceStore(getPreferenceStore()); fFontEditor.setPreferencePage(this); fFontEditor.load(); initializeFields(); for (int i= 0; i < fListModel.length; i++) fList.add(fListModel[i][0]); fList.getDisplay().asyncExec(new Runnable() { public void run() { fList.select(0); handleListSelection(); } }); } private void initializeFields() { Iterator e= fColorButtons.keySet().iterator(); while (e.hasNext()) { ColorEditor c= (ColorEditor) e.next(); String key= (String) fColorButtons.get(c); RGB rgb= PreferenceConverter.getColor(fOverlayStore, key); c.setColorValue(rgb); } e= fCheckBoxes.keySet().iterator(); while (e.hasNext()) { Button b= (Button) e.next(); String key= (String) fCheckBoxes.get(b); b.setSelection(fOverlayStore.getBoolean(key)); } e= fTextFields.keySet().iterator(); while (e.hasNext()) { Text t= (Text) e.next(); String key= (String) fTextFields.get(t); t.setText(fOverlayStore.getString(key)); } } /* * @see PreferencePage#performOk() */ public boolean performOk() { fFontEditor.store(); fOverlayStore.propagate(); return true; } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fFontEditor.loadDefault(); fOverlayStore.loadDefaults(); initializeFields(); handleListSelection(); super.performDefaults(); fPreviewViewer.invalidateTextPresentation(); } /* * @see DialogPage#dispose() */ public void dispose() { if (fJavaTextTools != null) { fJavaTextTools= null; } fFontEditor.setPreferencePage(null); fFontEditor.setPreferenceStore(null); if (fOverlayStore != null) { fOverlayStore.stop(); fOverlayStore= null; } super.dispose(); } private void addColorButton(Composite parent, String label, String key, int indentation) { Label labelControl= new Label(parent, SWT.NONE); labelControl.setText(label); GridData gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalIndent= indentation; labelControl.setLayoutData(gd); ColorEditor editor= new ColorEditor(parent); Button button= editor.getButton(); button.setData(editor); gd= new GridData(); gd.horizontalAlignment= GridData.END; button.setLayoutData(gd); button.addSelectionListener(fColorButtonListener); fColorButtons.put(editor, key); } private void addCheckBox(Composite parent, String label, String key, int indentation) { Button checkBox= new Button(parent, SWT.CHECK); checkBox.setText(label); GridData gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalIndent= indentation; gd.horizontalSpan= 2; checkBox.setLayoutData(gd); checkBox.addSelectionListener(fCheckBoxListener); fCheckBoxes.put(checkBox, key); } private void addTextField(Composite parent, String label, String key, int textLimit, int indentation) { Label labelControl= new Label(parent, SWT.NONE); labelControl.setText(label); GridData gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalIndent= indentation; labelControl.setLayoutData(gd); Text textControl= new Text(parent, SWT.BORDER | SWT.SINGLE); gd= new GridData(GridData.FILL_HORIZONTAL); gd.widthHint= convertWidthInCharsToPixels(textLimit + 1); gd.horizontalAlignment= GridData.END; textControl.setLayoutData(gd); textControl.setTextLimit(textLimit); textControl.addModifyListener(fTextFieldListener); fTextFields.put(textControl, key); } private void addTextFontEditor(Composite parent, String label, String key) { Composite editorComposite= new Composite(parent, SWT.NULL); GridLayout layout= new GridLayout(); layout.numColumns= 3; editorComposite.setLayout(layout); fFontEditor= new WorkbenchChainedTextFontFieldEditor(key, label, editorComposite); GridData gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalSpan= 2; editorComposite.setLayoutData(gd); } private String loadPreviewContentFromFile(String filename) { String line; String separator= System.getProperty("line.separator"); //$NON-NLS-1$ StringBuffer buffer= new StringBuffer(512); BufferedReader reader= null; try { reader= new BufferedReader(new InputStreamReader(getClass().getResourceAsStream(filename))); while ((line= reader.readLine()) != null) { buffer.append(line); buffer.append(separator); } } catch (IOException io) { JavaPlugin.log(io); } finally { if (reader != null) { try { reader.close(); } catch (IOException e) {} } } return buffer.toString(); } }
7,947
Bug 7947 JDIDebugModel still using types for breakpoints
This should be changed to just check on a type name. The current implementation is doing an equality check on a type and a type name.
verified fixed
efe3021
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-21T19:01:27Z"
"2002-01-21T16:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/BreakpointRulerAction.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.debug.core.DebugException; import org.eclipse.debug.core.DebugPlugin; import org.eclipse.debug.core.IBreakpointManager; import org.eclipse.debug.core.model.IBreakpoint; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.debug.core.IJavaBreakpoint; import org.eclipse.jdt.debug.core.IJavaLineBreakpoint; import org.eclipse.jdt.debug.core.JDIDebugModel; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.swt.widgets.Shell; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel; import org.eclipse.ui.texteditor.ITextEditor; import org.eclipse.ui.texteditor.MarkerRulerAction; /** * */ public class BreakpointRulerAction extends MarkerRulerAction { public BreakpointRulerAction(IVerticalRuler ruler, ITextEditor editor) { super(JavaEditorMessages.getResourceBundle(), "ManageBreakpoints.", ruler, editor, IBreakpoint.BREAKPOINT_MARKER, false); //$NON-NLS-1$ } /** * Checks whether the element the breakpoint refers to is shown in this editor */ protected boolean breakpointElementInEditor(IBreakpointManager manager, IMarker marker) { return true; } /** * @see MarkerRulerAction#getMarkers */ protected List getMarkers() { List breakpoints= new ArrayList(); IResource resource= getResource(); IDocument document= getDocument(); AbstractMarkerAnnotationModel model= getAnnotationModel(); if (model != null) { try { IMarker[] markers= null; if (resource instanceof IFile) markers= resource.findMarkers(IBreakpoint.BREAKPOINT_MARKER, true, IResource.DEPTH_INFINITE); else { IWorkspaceRoot root= JavaPlugin.getWorkspace().getRoot(); //fix for: 1GEUMGZ markers= root.findMarkers(IBreakpoint.BREAKPOINT_MARKER, true, IResource.DEPTH_INFINITE); } if (markers != null) { IBreakpointManager breakpointManager= DebugPlugin.getDefault().getBreakpointManager(); for (int i= 0; i < markers.length; i++) { IBreakpoint breakpoint= breakpointManager.getBreakpoint(markers[i]); if (breakpoint != null && breakpointManager.isRegistered(breakpoint) && breakpointElementInEditor(breakpointManager, markers[i]) && includesRulerLine(model.getMarkerPosition(markers[i]), document)) breakpoints.add(markers[i]); } } } catch (CoreException x) { JavaPlugin.logErrorStatus(JavaEditorMessages.getString("ManageBreakpoints.error.retrieving.message"), x.getStatus()); //$NON-NLS-1$ } } return breakpoints; } /** * @see MarkerRulerAction#addMarker */ protected void addMarker() { IEditorInput editorInput= getTextEditor().getEditorInput(); IDocument document= getDocument(); int rulerLine= getVerticalRuler().getLineOfLastMouseButtonActivity(); try { BreakpointLocationVerifier bv = new BreakpointLocationVerifier(); int lineNumber = bv.getValidBreakpointLocation(document, rulerLine); if (lineNumber > 0) { IRegion line= document.getLineInformation(lineNumber - 1); IType type = null; if (editorInput instanceof IClassFileEditorInput) { IClassFileEditorInput input= (IClassFileEditorInput) editorInput; type = input.getClassFile().getType(); } else if (editorInput instanceof IFileEditorInput) { IFileEditorInput input= (IFileEditorInput) editorInput; ICompilationUnit cu = (ICompilationUnit) JavaCore.create(input.getFile()); IJavaElement e = cu.getElementAt(line.getOffset()); if (e instanceof IType) type = (IType)e; else if (e != null && e instanceof IMember) { type = ((IMember)e).getDeclaringType(); } } if (type != null) { if (!JDIDebugModel.lineBreakpointExists(type, lineNumber)) { Map attributes = new HashMap(10); JavaCore.addJavaElementMarkerAttributes(attributes, type); attributes.put("org.eclipse.jdt.debug.ui.JAVA_ELEMENT_HANDLE_ID", type.getHandleIdentifier()); IJavaLineBreakpoint bp = JDIDebugModel.createLineBreakpoint(getBreakpointResource(type), type.getFullyQualifiedName(), lineNumber, line.getOffset(), line.getOffset() + line.getLength(), 0, true, attributes); } } } } catch (DebugException e) { Shell shell= getTextEditor().getSite().getShell(); ErrorDialog.openError(shell, JavaEditorMessages.getString("ManageBreakpoints.error.adding.title1"), JavaEditorMessages.getString("ManageBreakpoints.error.adding.message1"), e.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } catch (CoreException e) { Shell shell= getTextEditor().getSite().getShell(); ErrorDialog.openError(shell, JavaEditorMessages.getString("ManageBreakpoints.error.adding.title2"), JavaEditorMessages.getString("ManageBreakpoints.error.adding.message2"), e.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } catch (BadLocationException e) { Shell shell= getTextEditor().getSite().getShell(); ErrorDialog.openError(shell, JavaEditorMessages.getString("ManageBreakpoints.error.adding.title3"), JavaEditorMessages.getString("ManageBreakpoints.error.adding.message3"), null); //$NON-NLS-2$ //$NON-NLS-1$ } } /** * @see MarkerRulerAction#removeMarkers */ protected void removeMarkers(List markers) { IBreakpointManager breakpointManager= DebugPlugin.getDefault().getBreakpointManager(); try { Iterator e= markers.iterator(); while (e.hasNext()) { IBreakpoint breakpoint= breakpointManager.getBreakpoint((IMarker) e.next()); breakpointManager.removeBreakpoint(breakpoint, true); } } catch (CoreException e) { Shell shell= getTextEditor().getSite().getShell(); ErrorDialog.openError(shell, JavaEditorMessages.getString("ManageBreakpoints.error.removing.title1"), JavaEditorMessages.getString("ManageBreakpoints.error.removing.message1"), e.getStatus()); //$NON-NLS-2$ //$NON-NLS-1$ } } /** * Returns the resource on which a breakpoint marker should * be created for the given member. The resource returned is the * associated file, or project in the case of a class file in * a jar. * * @param member member in which a breakpoint is being created * @return resource the resource on which a breakpoint marker * should be created * @exception CoreException if an exception occurrs accessing the * underlying resource or Java model elements */ public IResource getBreakpointResource(IMember member) throws CoreException { IResource res = member.getUnderlyingResource(); if (res == null) { res = member.getJavaProject().getProject(); } return res; } }
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/A.java
class A { public void foo() { /* comment */ int i= 0; } }
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/locals_in/A_test564.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/locals_out/A_test564.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/return_in/A_test722.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/return_in/A_test723.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/return_out/A_test722.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/return_out/A_test723.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui.tests.refactoring/test
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
cases/org/eclipse/jdt/ui/tests/refactoring/ExtractMethodTests.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui/core
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/ExtractMethodAnalyzer.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui/core
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowAnalyzer.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui/core
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/flow/FlowInfo.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui/core
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/flow/InOutFlowAnalyzer.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui/core
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/util/GenericVisitor.java
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
org.eclipse.jdt.ui/core
7,892
Bug 7892 extract method: incorrect on nested loops (compile errors)
public class A{ void f(){ for (int i = 0; i < 10; i++) { /*[*/for (int j = 0; j < 10; j++) { }/*]*/ } } } the new method is: protected int dd() { /*[*/for (int j = 0; j < 10; j++) { } return j; } which results in a compile error
verified fixed
03bf976
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T11:24:23Z"
"2002-01-18T18:53:20Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/util/NewStatementAnalyzer.java
7,873
Bug 7873 Bogus error messages
1. Create a Project Test with a folder "COM". 2. Create a Project Test2 with a folder "com". 3. Select "COM" from Step 1, copy it to Test2. You get an error dialog: An error occurred while copying resources. Reason: Status <==== bogus, what does "Status" mean? 4. Same thing happens if you try to a folder with the same name AND the error dialog has the incorrect action information (the dialog is titled "Copy" instead of "Move" and its error message says error "copying", not "moving").
verified fixed
86083cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T12:49:52Z"
"2002-01-17T23:26:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/ReorgDestinationAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.reorg; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Arrays; import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Set; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.core.runtime.Path; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.Action; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.dialogs.ListSelectionDialog; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaElementContentProvider; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.corext.refactoring.Assert; import org.eclipse.jdt.internal.corext.refactoring.reorg.ReorgRefactoring; import org.eclipse.jdt.internal.corext.refactoring.reorg.ReorgUtils; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIException; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ISelectionValidator; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.packageview.PackageFilter; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementSorter; import org.eclipse.jdt.internal.ui.viewsupport.ListContentProvider; abstract class ReorgDestinationAction extends ReorgAction { public ReorgDestinationAction(String name, ISelectionProvider provider) { super(name, provider); } public ReorgDestinationAction(String name, StructuredSelectionProvider provider) { super(name, provider); } /* * @see Action#run() */ public void run() { List elements= getStructuredSelection().toList(); if (!ensureSaved(elements, getActionName())) return; ReorgRefactoring refactoring= createRefactoring(elements); setUnsavedFileList(refactoring, elements); Object destination= selectDestination(refactoring); if (destination == null) return; try{ String duplicate= getDuplicatedElementName(elements); if (duplicate != null){ String message= "Two or more elements named " + duplicate + " are selected."; MessageDialog.openInformation(JavaPlugin.getActiveWorkbenchShell().getShell(), "Duplicate Element Name", message); return; } refactoring.setDestination(destination); Set excluded= getExcluded(refactoring); if (excluded == null) //canceled return; if (excluded.size() == elements.size()) return; refactoring.setExcludedElements(excluded); if (! isOkToProceed(refactoring)) return; doReorg(refactoring); } catch (JavaModelException e){ ExceptionHandler.handle(e, "Exception", "Unexpected exception occurred. See log for details."); } } /** * returns null if no 2 elements have the same name */ private static String getDuplicatedElementName(List elements){ String[] names= getElementNames(elements); if (names.length == 0) return null; Arrays.sort(names); String last= names[0]; for (int i= 1; i < names.length; i++){ //non standard loop if (last.equals(names[i])) return last; last= names[i]; } return null; } abstract String getActionName(); abstract String getDestinationDialogMessage(); abstract ReorgRefactoring createRefactoring(List elements); //hook to override //returns null iff canceled Set getExcluded(ReorgRefactoring refactoring) throws JavaModelException{ return new HashSet(0); } //hook to override protected boolean isOkToProceed(ReorgRefactoring refactoring) throws JavaModelException{ return true; } void doReorg(ReorgRefactoring refactoring) throws JavaModelException{ MultiStatus status= perform(refactoring); if (status.isOK()) return; ExceptionHandler.handle(new JavaUIException(status), ReorgMessages.getString("copyAction.exception.title"), //$NON-NLS-1$ ReorgMessages.getString("copyAction.exception.label")); //$NON-NLS-1$ } private static boolean ensureSaved(List elements, String actionName) { List unsavedEditors= new ArrayList(); List unsavedElements= new ArrayList(); collectUnsavedEditors(elements, unsavedEditors, unsavedElements); if (unsavedEditors.isEmpty()) return true; ListSelectionDialog dialog = createUnsavedEditorDialog(unsavedElements); if (dialog.open() != dialog.OK) return false; IRunnableWithProgress r= createSaveEditorOperation(dialog.getResult(), elements, unsavedEditors); try { new ProgressMonitorDialog(JavaPlugin.getActiveWorkbenchShell()).run(false, false, r); } catch (InvocationTargetException e) { ExceptionHandler.handle(e, actionName, ReorgMessages.getString("ReorgAction.exception.saving")); //$NON-NLS-1$ return false; } catch (InterruptedException e) { } return true; } private static void setUnsavedFileList(ReorgRefactoring refactoring, List elements){ List unsavedEditors= new ArrayList(0); collectUnsavedEditors(elements, unsavedEditors, new ArrayList(0)); refactoring.setUnsavedFiles(getFiles(unsavedEditors)); } private static IFile[] getFiles(List editorParts){ List result= new ArrayList(editorParts.size()); for (Iterator iter= editorParts.iterator(); iter.hasNext(); ){ IEditorPart each= (IEditorPart)iter.next(); IEditorInput input= each.getEditorInput(); if (input instanceof IFileEditorInput) result.add(((IFileEditorInput)input).getFile()); } return (IFile[]) result.toArray(new IFile[result.size()]); } private static IRunnableWithProgress createSaveEditorOperation(final Object[] elementsToSave, final List elements, final List unsavedEditors) { return new IRunnableWithProgress() { public void run(IProgressMonitor pm) { pm.beginTask(ReorgMessages.getString("ReorgAction.task.saving"), elementsToSave.length); //$NON-NLS-1$ for (int i= 0; i < elementsToSave.length; i++) { IEditorPart editor= (IEditorPart)unsavedEditors.get(elements.indexOf(elementsToSave[i])); editor.doSave(new SubProgressMonitor(pm, 1)); } pm.done(); } }; } private static ListSelectionDialog createUnsavedEditorDialog(List unsavedElements) { int labelFlags= JavaElementLabelProvider.SHOW_DEFAULT | JavaElementLabelProvider.SHOW_POST_QUALIFIED; Shell parent= JavaPlugin.getActiveWorkbenchShell(); String msg= ReorgMessages.getString("ReorgAction.checkSaveTargets"); //$NON-NLS-1$ ListSelectionDialog dialog= new ListSelectionDialog(parent, unsavedElements, new ListContentProvider(), new JavaElementLabelProvider(labelFlags), msg); dialog.setInitialSelections(unsavedElements.toArray()); return dialog; } private static void collectUnsavedEditors(List elements, List unsavedEditors, List unsavedElements) { IEditorPart[] editors= JavaPlugin.getDirtyEditors(); for (int i= 0; i < editors.length; i++) { for (Iterator iter= elements.iterator(); iter.hasNext(); ){ Object element= iter.next(); if (EditorUtility.isEditorInput(element, editors[i])) { unsavedEditors.add(editors[i]); unsavedElements.add(element); } } } } private static String[] getElementNames(List elements){ String[] result= new String[elements.size()]; int i= 0; for (Iterator iter= elements.iterator(); iter.hasNext(); ){ result[i]= ReorgUtils.getName(iter.next()); i++; } return result; } //overriden by d'n'd - must be protected protected Object selectDestination(ReorgRefactoring refactoring) { JavaElementContentProvider cp= new JavaElementContentProvider() { public boolean hasChildren(Object element) { // prevent the + from being shown in front of packages return !(element instanceof IPackageFragment) && super.hasChildren(element); } }; ElementTreeSelectionDialog dialog= createDestinationSelectionDialog(JavaPlugin.getActiveWorkbenchShell(), new DestinationRenderer(JavaElementLabelProvider.SHOW_SMALL_ICONS ), cp, refactoring); dialog.setTitle(getActionName()); dialog.setValidator(new ReorgSelectionValidator(refactoring)); dialog.addFilter(new ContainerFilter(refactoring)); dialog.setSorter(new JavaElementSorter()); dialog.setMessage(getDestinationDialogMessage()); dialog.setSize(60, 18); dialog.setInput(JavaCore.create(ResourcesPlugin.getWorkspace().getRoot())); dialog.setInitialSelection(computeCommonParent(refactoring.getElementsToReorg())); if (dialog.open() != dialog.CANCEL) return dialog.getFirstResult(); return null; } ElementTreeSelectionDialog createDestinationSelectionDialog(Shell parent, ILabelProvider labelProvider, JavaElementContentProvider cp, ReorgRefactoring refactoring){ return new ElementTreeSelectionDialog(parent, labelProvider, cp); } private static Object computeCommonParent(List elements){ if (elements.isEmpty()) return null; Object parent= elements.get(0); for (Iterator iter= elements.iterator(); iter.hasNext(); ){ parent= computeCommonParent(parent, iter.next()); } IResource parentRes= getResource(parent); IJavaElement parentElement= JavaCore.create(parentRes); if (parentElement != null) return parentElement; return getResource(parent); } private static Object computeCommonParent(Object e1, Object e2){ IResource r1= getResource(e1); IResource r2= getResource(e2); if (r1 == null && r2 == null) return null; if (r1 == null) return r2.getParent(); if (r2 == null) return r1.getParent(); if (r1.equals(r2)) return r1.getParent(); if (r1.getFullPath().isPrefixOf(r2.getFullPath())) return r1; if (r2.getFullPath().isPrefixOf(r1.getFullPath())) return r2; IPath p1= r1.getParent().getFullPath(); IPath p2= r2.getParent().getFullPath(); IPath commonPath= new Path(""); int segCount= Math.min(p1.segmentCount(), p2.segmentCount()); for (int i= 0; i < segCount; i++){ if (p1.segment(i).equals(p2.segment(i))) commonPath= commonPath.append(p1.segment(i)); else break; } return ResourcesPlugin.getWorkspace().getRoot().findMember(commonPath); } private static IResource getResource(Object o) { try{ if (o instanceof IResource) return (IResource)o; else if (o instanceof IJavaElement) return ((IJavaElement)o).getCorrespondingResource(); else return null; } catch (JavaModelException e){ JavaPlugin.log(e); return null; } } /* non java-doc * @see IRefactoringAction#canOperateOn(IStructuredSelection) */ public boolean canOperateOn(IStructuredSelection selection) { return canActivate(createRefactoring(selection.toList())); } //----- private static class ContainerFilter extends PackageFilter { private ReorgRefactoring fRefactoring; ContainerFilter(ReorgRefactoring refactoring) { Assert.isNotNull(refactoring); fRefactoring= refactoring; } public boolean select(Viewer viewer, Object parent, Object o) { if (fRefactoring.getElementsToReorg().contains(o)) return false; return fRefactoring.canBeAncestor(o); } } //----- private static class DestinationRenderer extends JavaElementLabelProvider { public DestinationRenderer(int flags) { super(flags); } public String getText(Object element) { try { if (element instanceof IPackageFragmentRoot) { IPackageFragmentRoot root= (IPackageFragmentRoot)element; if (root.getUnderlyingResource() instanceof IProject) return ReorgMessages.getString("DestinationRenderer.packages"); //$NON-NLS-1$ } } catch (JavaModelException e) { ExceptionHandler.handle(e, "Exception", "Unexpected exception occurred. See log for details."); } return super.getText(element); } } //------ private static class ReorgSelectionValidator implements ISelectionValidator { private ReorgRefactoring fRefactoring; public ReorgSelectionValidator(ReorgRefactoring refactoring) { Assert.isNotNull(refactoring); fRefactoring= refactoring; } public IStatus validate(Object[] selection) { if (selection.length != 1) return new StatusInfo(IStatus.ERROR, ""); try{ if (fRefactoring.isValidDestination(selection[0])) return new StatusInfo(); return new StatusInfo(IStatus.ERROR, ""); } catch (JavaModelException e){ ExceptionHandler.handle(e, "Exception", "Unexpected exception occurred. See log for details."); return new StatusInfo(IStatus.ERROR, ""); } } } }
7,873
Bug 7873 Bogus error messages
1. Create a Project Test with a folder "COM". 2. Create a Project Test2 with a folder "com". 3. Select "COM" from Step 1, copy it to Test2. You get an error dialog: An error occurred while copying resources. Reason: Status <==== bogus, what does "Status" mean? 4. Same thing happens if you try to a folder with the same name AND the error dialog has the incorrect action information (the dialog is titled "Copy" instead of "Move" and its error message says error "copying", not "moving").
verified fixed
86083cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T12:49:52Z"
"2002-01-17T23:26:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/ReorgExceptionHandler.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.reorg; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.jdt.internal.corext.refactoring.base.ChangeContext; import org.eclipse.jdt.internal.corext.refactoring.base.IChange; import org.eclipse.jdt.internal.corext.refactoring.base.IChangeExceptionHandler; import org.eclipse.jdt.internal.ui.JavaPlugin; /** * Class used to handle exceptions occurring during reorg actions. */ class ReorgExceptionHandler implements IChangeExceptionHandler{ private MultiStatus fStatus; ReorgExceptionHandler() { String id = JavaPlugin.getDefault().getDescriptor().getUniqueIdentifier(); fStatus = new MultiStatus(id, IStatus.OK, "Status", null); } public void handle(ChangeContext context, IChange change, Exception e) { if (e instanceof RuntimeException) throw (RuntimeException) e; if (e instanceof CoreException) fStatus.merge(((CoreException) e).getStatus()); } MultiStatus getStatus(){ return fStatus; } }
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/A.java
class A { public void foo() { /* comment */ { int i= 0; i--; i++; } } }
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/test
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
cases/org/eclipse/jdt/ui/tests/refactoring/AbstractSelectionTestCase.java
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/test
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
cases/org/eclipse/jdt/ui/tests/refactoring/AllTests.java
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/core/TextBufferTest.java
/* * (c) Copyright 2001 MyCorporation. * All Rights Reserved. */ package org.eclipse.jdt.ui.tests.core; import junit.framework.Test; import junit.framework.TestCase; import junit.framework.TestSuite; import org.eclipse.jdt.internal.corext.textmanipulation.MoveTextEdit; import org.eclipse.jdt.internal.corext.textmanipulation.SimpleTextEdit; import org.eclipse.jdt.internal.corext.textmanipulation.SwapTextEdit; import org.eclipse.jdt.internal.corext.textmanipulation.TextBuffer; import org.eclipse.jdt.internal.corext.textmanipulation.TextBufferEditor; import org.eclipse.jdt.internal.corext.textmanipulation.TextRange; import org.eclipse.jdt.internal.corext.textmanipulation.UndoMemento; import org.eclipse.jdt.testplugin.TestPluginLauncher; public class TextBufferTest extends TestCase { private static final Class THIS= TextBufferTest.class; private TextBuffer fBuffer; private TextBufferEditor fEditor; public TextBufferTest(String name) { super(name); } public static void main(String[] args) { TestPluginLauncher.run(TestPluginLauncher.getLocationFromProperties(), THIS, args); } public static Test suite() { TestSuite result= new TestSuite(THIS); if (false) { // For hot code replace when debugging test cases result.addTestSuite(THIS); result.addTestSuite(THIS); result.addTestSuite(THIS); result.addTestSuite(THIS); result.addTestSuite(THIS); result.addTestSuite(THIS); } return result; } protected void setUp() throws Exception { fBuffer= TextBuffer.create("0123456789"); fEditor= new TextBufferEditor(fBuffer); } protected void tearDown() throws Exception { fEditor= null; } public void testOverlap1() throws Exception { // [ [ ] ] fEditor.add(SimpleTextEdit.createReplace(0, 2, "01")); fEditor.add(SimpleTextEdit.createReplace(1, 2, "12")); assertTrue(!fEditor.canPerformEdits()); } public void testOverlap2() throws Exception { // [[ ] ] fEditor.add(SimpleTextEdit.createReplace(0, 2, "01")); fEditor.add(SimpleTextEdit.createReplace(0, 1, "0")); assertTrue(!fEditor.canPerformEdits()); } public void testOverlap3() throws Exception { // [ [ ]] fEditor.add(SimpleTextEdit.createReplace(0, 2, "01")); fEditor.add(SimpleTextEdit.createReplace(1, 1, "1")); assertTrue(!fEditor.canPerformEdits()); } public void testOverlap4() throws Exception { // [ [ ] ] fEditor.add(SimpleTextEdit.createReplace(0, 3, "012")); fEditor.add(SimpleTextEdit.createReplace(1, 1, "1")); assertTrue(!fEditor.canPerformEdits()); } public void testOverlap5() throws Exception { // [ [] ] fEditor.add(SimpleTextEdit.createReplace(0, 3, "012")); fEditor.add(SimpleTextEdit.createInsert(1, "xx")); assertTrue(!fEditor.canPerformEdits()); } public void testOverlap6() throws Exception { // [ [] ] fEditor.add(SimpleTextEdit.createReplace(0, 3, "012")); fEditor.add(SimpleTextEdit.createInsert(2, "xx")); assertTrue(!fEditor.canPerformEdits()); } public void testOverlap7() throws Exception { boolean catched= false; try { new MoveTextEdit(2,5,3); } catch (Exception e) { catched= true; } assertTrue(catched); } public void testOverlap8() throws Exception { boolean catched= false; try { new MoveTextEdit(2,5,6); } catch (Exception e) { catched= true; } assertTrue(catched); } public void testOverlap9() throws Exception { MoveTextEdit e1= new MoveTextEdit(3, 1, 7); MoveTextEdit e2= new MoveTextEdit(2, 3, 8); fEditor.add(e1); fEditor.add(e2); assertTrue(!fEditor.canPerformEdits()); } public void testInsert1() throws Exception { // [][ ] SimpleTextEdit e1= SimpleTextEdit.createInsert(2, "yy"); SimpleTextEdit e2= SimpleTextEdit.createReplace(2, 3, "3456"); fEditor.add(e1); fEditor.add(e2); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTextRange(), 2, 2); assert(e2.getTextRange(), 4, 4); assertEquals("Buffer content", "01yy345656789", fBuffer.getContent()); doUndo(undo); assert(e1.getTextRange(), 2, 0); assert(e2.getTextRange(), 2, 3); } public void testInsert2() throws Exception { // [][] SimpleTextEdit e1= SimpleTextEdit.createInsert(2, "yy"); SimpleTextEdit e2= SimpleTextEdit.createInsert(2, "xx"); fEditor.add(e1); fEditor.add(e2); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTextRange(), 2, 2); assert(e2.getTextRange(), 4, 2); assertEquals("Buffer content", "01yyxx23456789", fBuffer.getContent()); doUndo(undo); assert(e1.getTextRange(), 2, 0); assert(e2.getTextRange(), 2, 0); } public void testInsert3() throws Exception { // [ ][][ ] SimpleTextEdit e1= SimpleTextEdit.createReplace(0, 2, "011"); SimpleTextEdit e2= SimpleTextEdit.createInsert(2, "xx"); SimpleTextEdit e3= SimpleTextEdit.createReplace(2, 2, "2"); fEditor.add(e1); fEditor.add(e2); fEditor.add(e3); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTextRange(), 0, 3); assert(e2.getTextRange(), 3, 2); assert(e3.getTextRange(), 5, 1); assertEquals("Buffer content", "011xx2456789", fBuffer.getContent()); doUndo(undo); assert(e1.getTextRange(), 0, 2); assert(e2.getTextRange(), 2, 0); assert(e3.getTextRange(), 2, 2); } public void testInsert4() throws Exception { SimpleTextEdit e1= SimpleTextEdit.createInsert(0, "xx"); fEditor.add(e1); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer length", 12, fBuffer.getLength()); assert(e1.getTextRange(), 0, 2); assertEquals("Buffer content", "xx0123456789", fBuffer.getContent()); doUndo(undo); assert(e1.getTextRange(), 0, 0); } public void testInsert5() throws Exception { SimpleTextEdit e1= SimpleTextEdit.createInsert(10, "xx"); fEditor.add(e1); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer length", 12, fBuffer.getLength()); assert(e1.getTextRange(), 10, 2); assertEquals("Buffer content", "0123456789xx", fBuffer.getContent()); doUndo(undo); assert(e1.getTextRange(), 10, 0); } public void testDelete1() throws Exception { SimpleTextEdit e1= SimpleTextEdit.createDelete(3, 1); fEditor.add(e1); assertTrue("Can perform edits", fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTextRange(), 3, 0); assertEquals("Buffer content", "012456789", fBuffer.getContent()); doUndo(undo); assert(e1.getTextRange(), 3, 1); } public void testDelete2() throws Exception { SimpleTextEdit e1= SimpleTextEdit.createDelete(4, 1); SimpleTextEdit e2= SimpleTextEdit.createDelete(3, 1); SimpleTextEdit e3= SimpleTextEdit.createDelete(5, 1); fEditor.add(e1); fEditor.add(e2); fEditor.add(e3); assertTrue("Can perform edits", fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTextRange(), 3, 0); assert(e2.getTextRange(), 3, 0); assert(e3.getTextRange(), 3, 0); assertEquals("Buffer content", "0126789", fBuffer.getContent()); doUndo(undo); assert(e1.getTextRange(), 4, 1); assert(e2.getTextRange(), 3, 1); assert(e3.getTextRange(), 5, 1); } public void testDelete3() throws Exception { SimpleTextEdit e1= SimpleTextEdit.createInsert(3, "x"); SimpleTextEdit e2= SimpleTextEdit.createDelete(3, 1); fEditor.add(e1); fEditor.add(e2); assertTrue("Can perform edits", fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTextRange(), 3, 1); assert(e2.getTextRange(), 4, 0); assertEquals("Buffer content", "012x456789", fBuffer.getContent()); doUndo(undo); assert(e1.getTextRange(), 3, 0); assert(e2.getTextRange(), 3, 1); } public void testMove1() throws Exception { MoveTextEdit e1= new MoveTextEdit(2, 2, 5); fEditor.add(e1); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "0142356789", fBuffer.getContent()); assert(e1.getTargetRange(), 3, 2); assert(e1.getSourceRange(), 2, 0); doUndo(undo); assert(e1.getSourceRange(), 2, 2); assert(e1.getTargetRange(), 5, 0); } public void testMove2() throws Exception { MoveTextEdit e1= new MoveTextEdit(5, 2, 2); fEditor.add(e1); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "0156234789", fBuffer.getContent()); assert(e1.getTargetRange(), 2, 2); assert(e1.getSourceRange(), 7, 0); doUndo(undo); assert(e1.getSourceRange(), 5, 2); assert(e1.getTargetRange(), 2, 0); } public void testMove3() throws Exception { MoveTextEdit e1= new MoveTextEdit(2, 2, 7); SimpleTextEdit e2= SimpleTextEdit.createReplace(4, 1, "x"); fEditor.add(e1); fEditor.add(e2); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "01x5623789", fBuffer.getContent()); assert(e1.getTargetRange(), 5, 2); assert(e1.getSourceRange(), 2, 0); assert(e2.getTextRange(), 2, 1); doUndo(undo); assert(e1.getSourceRange(), 2, 2); assert(e1.getTargetRange(), 7, 0); assert(e2.getTextRange(), 4, 1); } public void testMove4() throws Exception { MoveTextEdit e1= new MoveTextEdit(7, 2, 2); SimpleTextEdit e2= SimpleTextEdit.createReplace(5, 1, "x"); fEditor.add(e2); fEditor.add(e1); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "0178234x69", fBuffer.getContent()); assert(e1.getTargetRange(), 2, 2); assert(e1.getSourceRange(), 9, 0); assert(e2.getTextRange(), 7, 1); doUndo(undo); assert(e1.getSourceRange(), 7, 2); assert(e1.getTargetRange(), 2, 0); assert(e2.getTextRange(), 5, 1); } public void testMove5() throws Exception { // Move onto itself MoveTextEdit e1= new MoveTextEdit(2, 1, 3); SimpleTextEdit e2= SimpleTextEdit.createReplace(2,1,"x"); fEditor.add(e1); fEditor.add(e2); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTargetRange(), 2, 1); assert(e1.getSourceRange(), 3, 0); assert(e2.getTextRange(), 2, 1); assertEquals("Buffer content", "01x3456789", fBuffer.getContent()); doUndo(undo); assert(e1.getSourceRange(), 2, 1); assert(e1.getTargetRange(), 3, 0); assert(e2.getTextRange(), 2, 1); } public void testMove6() throws Exception { // Move onto itself MoveTextEdit e1= new MoveTextEdit(2, 1, 2); SimpleTextEdit e2= SimpleTextEdit.createReplace(2,1,"x"); fEditor.add(e1); fEditor.add(e2); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTargetRange(), 2, 1); assert(e1.getSourceRange(), 3, 0); // This gets normalized since a move from [2,1] -> 2 == [2,1] -> 3 assert(e2.getTextRange(), 2, 1); assertEquals("Buffer content", "01x3456789", fBuffer.getContent()); doUndo(undo); assert(e1.getSourceRange(), 2, 1); assert(e1.getTargetRange(), 3, 0); assert(e2.getTextRange(), 2, 1); } public void testMove7() throws Exception { MoveTextEdit e1= new MoveTextEdit(2, 3, 7); SimpleTextEdit e2= SimpleTextEdit.createReplace(3, 1, "x"); fEditor.add(e1); fEditor.add(e2); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "01562x4789", fBuffer.getContent()); assert(e1.getTargetRange(), 4, 3); assert(e1.getSourceRange(), 2, 0); assert(e2.getTextRange(), 5, 1); doUndo(undo); assert(e1.getSourceRange(), 2, 3); assert(e1.getTargetRange(), 7, 0); assert(e2.getTextRange(), 3, 1); } public void testMove8() throws Exception { MoveTextEdit e1= new MoveTextEdit(5, 3, 1); SimpleTextEdit e2= SimpleTextEdit.createReplace(6, 1, "x"); fEditor.add(e2); fEditor.add(e1); assertTrue(fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "05x7123489", fBuffer.getContent()); assert(e1.getTargetRange(), 1, 3); assert(e1.getSourceRange(), 8, 0); assert(e2.getTextRange(), 2, 1); doUndo(undo); assert(e1.getSourceRange(), 5, 3); assert(e1.getTargetRange(), 1, 0); assert(e2.getTextRange(), 6, 1); } public void testMove9() throws Exception { MoveTextEdit e1= new MoveTextEdit(1, 1, 3); MoveTextEdit e2= new MoveTextEdit(1, 3, 5); fEditor.add(e1); fEditor.add(e2); assertTrue("Can perform edits", fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assert(e1.getTargetRange(), 3, 1); assert(e1.getSourceRange(), 2, 0); assert(e2.getTargetRange(), 2, 3); assert(e2.getSourceRange(), 1, 0); assertEquals("Buffer content", "0421356789", fBuffer.getContent()); doUndo(undo); assert(e1.getSourceRange(), 1, 1); assert(e1.getTargetRange(), 3, 0); assert(e2.getSourceRange(), 1, 3); assert(e2.getTargetRange(), 5, 0); } public void testMove10() throws Exception { MoveTextEdit e1= new MoveTextEdit(2, 2, 8); MoveTextEdit e2= new MoveTextEdit(5, 2, 1); fEditor.add(e1); fEditor.add(e2); assertTrue("Can perform edits", fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "0561472389", fBuffer.getContent()); doUndo(undo); } public void testSwap1() throws Exception { SwapTextEdit e1= new SwapTextEdit(1, 1, 3, 1); fEditor.add(e1); assertTrue("Can perform edits", fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "0321456789", fBuffer.getContent()); doUndo(undo); } public void testSwap2() throws Exception { SwapTextEdit e1= new SwapTextEdit(1, 1, 3, 1); SwapTextEdit e2= new SwapTextEdit(5, 1, 7, 1); fEditor.add(e1); fEditor.add(e2); assertTrue("Can perform edits", fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "0321476589", fBuffer.getContent()); doUndo(undo); } public void testSwap3() throws Exception { SwapTextEdit e1= new SwapTextEdit(1, 1, 3, 1); SwapTextEdit e2= new SwapTextEdit(5, 1, 7, 1); SwapTextEdit e3= new SwapTextEdit(1, 3, 5, 3); fEditor.add(e1); fEditor.add(e2); fEditor.add(e3); assertTrue("Can perform edits", fEditor.canPerformEdits()); UndoMemento undo= fEditor.performEdits(null); assertEquals("Buffer content", "0765432189", fBuffer.getContent()); doUndo(undo); } private void doUndo(UndoMemento undo) throws Exception { fEditor.add(undo); fEditor.performEdits(null); assertBufferContent(); } private void assert(TextRange r, int offset, int length) { assertEquals("Offset", offset, r.getOffset()); assertEquals("Length", length, r.getLength()); } private void assertBufferContent() { assertEquals("Buffer content restored", "0123456789", fBuffer.getContent()); } }
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
org.eclipse.jdt.ui/core
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
extension/org/eclipse/jdt/internal/corext/textmanipulation/TextEditNode.java
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
org.eclipse.jdt.ui/core
7,985
Bug 7985 extract method: cannot extract (entire) try/catch block
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} } cannot extract the selected fragment
verified fixed
b4bbfa8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T14:23:50Z"
"2002-01-22T11:46:40Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/util/NewSelectionAnalyzer.java
7,966
Bug 7966 Class Creation Dialog generates syntax error
Build 20020115 If you create a class that will require import statements due to the interfaces it implements or the class it extends they will be created within the comment for the class. Here is an example of the comment of the generated class /* import org.eclipse.core.resources.IResourceChangeListener; import org.eclipse.jface.viewers.ITreeContentProvider; * (c) Copyright 2001 MyCorporation. * All Rights Reserved. */ Steps 1) Select the class creation dialog 2) Enter a class name 3) Choose an interface to have it inherit from 4) Hit OK - you will get an error from Eclipse 5) The class will be created - look at its definition
verified fixed
5071337
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T16:48:23Z"
"2002-01-21T21:53:20Z"
org.eclipse.jdt.ui/core
7,966
Bug 7966 Class Creation Dialog generates syntax error
Build 20020115 If you create a class that will require import statements due to the interfaces it implements or the class it extends they will be created within the comment for the class. Here is an example of the comment of the generated class /* import org.eclipse.core.resources.IResourceChangeListener; import org.eclipse.jface.viewers.ITreeContentProvider; * (c) Copyright 2001 MyCorporation. * All Rights Reserved. */ Steps 1) Select the class creation dialog 2) Enter a class name 3) Choose an interface to have it inherit from 4) Hit OK - you will get an error from Eclipse 5) The class will be created - look at its definition
verified fixed
5071337
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T16:48:23Z"
"2002-01-21T21:53:20Z"
extension/org/eclipse/jdt/internal/corext/codemanipulation/StubUtility.java
7,966
Bug 7966 Class Creation Dialog generates syntax error
Build 20020115 If you create a class that will require import statements due to the interfaces it implements or the class it extends they will be created within the comment for the class. Here is an example of the comment of the generated class /* import org.eclipse.core.resources.IResourceChangeListener; import org.eclipse.jface.viewers.ITreeContentProvider; * (c) Copyright 2001 MyCorporation. * All Rights Reserved. */ Steps 1) Select the class creation dialog 2) Enter a class name 3) Choose an interface to have it inherit from 4) Hit OK - you will get an error from Eclipse 5) The class will be created - look at its definition
verified fixed
5071337
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T16:48:23Z"
"2002-01-21T21:53:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.IBuffer; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.Signature; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.ui.IJavaElementSearchConstants; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.compiler.env.IConstants; import org.eclipse.jdt.internal.corext.codemanipulation.CodeGenerationSettings; import org.eclipse.jdt.internal.corext.codemanipulation.IImportsStructure; import org.eclipse.jdt.internal.corext.codemanipulation.ImportsStructure; import org.eclipse.jdt.internal.corext.codemanipulation.StubUtility; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.dialogs.TypeSelectionDialog; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.preferences.CodeGenerationPreferencePage; import org.eclipse.jdt.internal.ui.preferences.ImportOrganizePreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; import org.eclipse.jdt.internal.ui.text.template.Template; import org.eclipse.jdt.internal.ui.text.template.Templates; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IListAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IStringButtonAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.ListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogFieldGroup; import org.eclipse.jdt.internal.ui.wizards.dialogfields.Separator; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonStatusDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringDialogField; import org.eclipse.jdt.internal.ui.wizards.swt.MGridData; import org.eclipse.jdt.internal.ui.wizards.swt.MGridLayout; /** * <code>TypePage</code> contains controls and validation routines for a 'New Type WizardPage' * Implementors decide which components to add and to enable. Implementors can also * customize the validation code. * <code>TypePage</code> is intended to serve as base class of all wizards that create types. * Applets, Servlets, Classes, Interfaces... * See <code>NewClassCreationWizardPage</code> or <code>NewInterfaceCreationWizardPage</code> for an * example usage of TypePage. */ public abstract class TypePage extends ContainerPage { private final static String PAGE_NAME= "TypePage"; //$NON-NLS-1$ protected final static String PACKAGE= PAGE_NAME + ".package"; //$NON-NLS-1$ protected final static String ENCLOSING= PAGE_NAME + ".enclosing"; //$NON-NLS-1$ protected final static String ENCLOSINGSELECTION= ENCLOSING + ".selection"; //$NON-NLS-1$ protected final static String TYPENAME= PAGE_NAME + ".typename"; //$NON-NLS-1$ protected final static String SUPER= PAGE_NAME + ".superclass"; //$NON-NLS-1$ protected final static String INTERFACES= PAGE_NAME + ".interfaces"; //$NON-NLS-1$ protected final static String MODIFIERS= PAGE_NAME + ".modifiers"; //$NON-NLS-1$ protected final static String METHODS= PAGE_NAME + ".methods"; //$NON-NLS-1$ private class InterfacesListLabelProvider extends LabelProvider { private Image fInterfaceImage; public InterfacesListLabelProvider() { super(); fInterfaceImage= JavaPluginImages.get(JavaPluginImages.IMG_OBJS_INTERFACE); } public Image getImage(Object element) { return fInterfaceImage; } } private StringButtonStatusDialogField fPackageDialogField; private SelectionButtonDialogField fEnclosingTypeSelection; private StringButtonDialogField fEnclosingTypeDialogField; private boolean fCanModifyPackage; private boolean fCanModifyEnclosingType; private IPackageFragment fCurrPackage; private IType fCurrEnclosingType; private StringDialogField fTypeNameDialogField; private StringButtonDialogField fSuperClassDialogField; private ListDialogField fSuperInterfacesDialogField; private IType fSuperClass; private SelectionButtonDialogFieldGroup fAccMdfButtons; private SelectionButtonDialogFieldGroup fOtherMdfButtons; private IType fCreatedType; protected IStatus fEnclosingTypeStatus; protected IStatus fPackageStatus; protected IStatus fTypeNameStatus; protected IStatus fSuperClassStatus; protected IStatus fModifierStatus; protected IStatus fSuperInterfacesStatus; private boolean fIsClass; private int fStaticMdfIndex; private final int PUBLIC_INDEX= 0, DEFAULT_INDEX= 1, PRIVATE_INDEX= 2, PROTECTED_INDEX= 3; private final int ABSTRACT_INDEX= 0, FINAL_INDEX= 1; public TypePage(boolean isClass, String pageName, IWorkspaceRoot root) { super(pageName, root); fCreatedType= null; fIsClass= isClass; TypeFieldsAdapter adapter= new TypeFieldsAdapter(); fPackageDialogField= new StringButtonStatusDialogField(adapter); fPackageDialogField.setDialogFieldListener(adapter); fPackageDialogField.setLabelText(NewWizardMessages.getString("TypePage.package.label")); //$NON-NLS-1$ fPackageDialogField.setButtonLabel(NewWizardMessages.getString("TypePage.package.button")); //$NON-NLS-1$ fPackageDialogField.setStatusWidthHint(NewWizardMessages.getString("TypePage.default")); //$NON-NLS-1$ fEnclosingTypeSelection= new SelectionButtonDialogField(SWT.CHECK); fEnclosingTypeSelection.setDialogFieldListener(adapter); fEnclosingTypeSelection.setLabelText(NewWizardMessages.getString("TypePage.enclosing.selection.label")); //$NON-NLS-1$ fEnclosingTypeDialogField= new StringButtonDialogField(adapter); fEnclosingTypeDialogField.setDialogFieldListener(adapter); fEnclosingTypeDialogField.setButtonLabel(NewWizardMessages.getString("TypePage.enclosing.button")); //$NON-NLS-1$ fTypeNameDialogField= new StringDialogField(); fTypeNameDialogField.setDialogFieldListener(adapter); fTypeNameDialogField.setLabelText(NewWizardMessages.getString("TypePage.typename.label")); //$NON-NLS-1$ fSuperClassDialogField= new StringButtonDialogField(adapter); fSuperClassDialogField.setDialogFieldListener(adapter); fSuperClassDialogField.setLabelText(NewWizardMessages.getString("TypePage.superclass.label")); //$NON-NLS-1$ fSuperClassDialogField.setButtonLabel(NewWizardMessages.getString("TypePage.superclass.button")); //$NON-NLS-1$ String[] addButtons= new String[] { /* 0 */ NewWizardMessages.getString("TypePage.interfaces.add"), //$NON-NLS-1$ /* 1 */ null, /* 2 */ NewWizardMessages.getString("TypePage.interfaces.remove") //$NON-NLS-1$ }; fSuperInterfacesDialogField= new ListDialogField(adapter, addButtons, new InterfacesListLabelProvider()); fSuperInterfacesDialogField.setDialogFieldListener(adapter); String interfaceLabel= fIsClass ? NewWizardMessages.getString("TypePage.interfaces.class.label") : NewWizardMessages.getString("TypePage.interfaces.ifc.label"); //$NON-NLS-1$ //$NON-NLS-2$ fSuperInterfacesDialogField.setLabelText(interfaceLabel); fSuperInterfacesDialogField.setRemoveButtonIndex(2); String[] buttonNames1= new String[] { /* 0 == PUBLIC_INDEX */ NewWizardMessages.getString("TypePage.modifiers.public"), //$NON-NLS-1$ /* 1 == DEFAULT_INDEX */ NewWizardMessages.getString("TypePage.modifiers.default"), //$NON-NLS-1$ /* 2 == PRIVATE_INDEX */ NewWizardMessages.getString("TypePage.modifiers.private"), //$NON-NLS-1$ /* 3 == PROTECTED_INDEX*/ NewWizardMessages.getString("TypePage.modifiers.protected") //$NON-NLS-1$ }; fAccMdfButtons= new SelectionButtonDialogFieldGroup(SWT.RADIO, buttonNames1, 4); fAccMdfButtons.setDialogFieldListener(adapter); fAccMdfButtons.setLabelText(NewWizardMessages.getString("TypePage.modifiers.acc.label")); //$NON-NLS-1$ fAccMdfButtons.setSelection(0, true); String[] buttonNames2; if (fIsClass) { buttonNames2= new String[] { /* 0 == ABSTRACT_INDEX */ NewWizardMessages.getString("TypePage.modifiers.abstract"), //$NON-NLS-1$ /* 1 == FINAL_INDEX */ NewWizardMessages.getString("TypePage.modifiers.final"), //$NON-NLS-1$ /* 2 */ NewWizardMessages.getString("TypePage.modifiers.static") //$NON-NLS-1$ }; fStaticMdfIndex= 2; // index of the static checkbox is 2 } else { buttonNames2= new String[] { NewWizardMessages.getString("TypePage.modifiers.static") //$NON-NLS-1$ }; fStaticMdfIndex= 0; // index of the static checkbox is 0 } fOtherMdfButtons= new SelectionButtonDialogFieldGroup(SWT.CHECK, buttonNames2, 4); fOtherMdfButtons.setDialogFieldListener(adapter); fAccMdfButtons.enableSelectionButton(PRIVATE_INDEX, false); fAccMdfButtons.enableSelectionButton(PROTECTED_INDEX, false); fOtherMdfButtons.enableSelectionButton(fStaticMdfIndex, false); fPackageStatus= new StatusInfo(); fEnclosingTypeStatus= new StatusInfo(); fCanModifyPackage= true; fCanModifyEnclosingType= true; updateEnableState(); fTypeNameStatus= new StatusInfo(); fSuperClassStatus= new StatusInfo(); fSuperInterfacesStatus= new StatusInfo(); fModifierStatus= new StatusInfo(); } /** * Initializes all fields provided by the type page with a given * Java element as selection. * @param elem The initial selection of this page or null if no * selection was available */ protected void initTypePage(IJavaElement elem) { String initSuperclass= "java.lang.Object"; //$NON-NLS-1$ ArrayList initSuperinterfaces= new ArrayList(5); IPackageFragment pack= null; IType enclosingType= null; if (elem != null) { // evaluate the enclosing type pack= (IPackageFragment) JavaModelUtil.findElementOfKind(elem, IJavaElement.PACKAGE_FRAGMENT); IType typeInCU= (IType) JavaModelUtil.findElementOfKind(elem, IJavaElement.TYPE); if (typeInCU != null) { if (typeInCU.getCompilationUnit() != null) { enclosingType= typeInCU; } } else { ICompilationUnit cu= (ICompilationUnit) JavaModelUtil.findElementOfKind(elem, IJavaElement.COMPILATION_UNIT); if (cu != null) { enclosingType= JavaModelUtil.findPrimaryType(cu); } } try { IType type= null; if (elem.getElementType() == IJavaElement.TYPE) { type= (IType)elem; if (type.exists()) { String superName= JavaModelUtil.getFullyQualifiedName(type); if (type.isInterface()) { initSuperinterfaces.add(superName); } else { initSuperclass= superName; } } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); // ignore this exception now } } setPackageFragment(pack, true); setEnclosingType(enclosingType, true); setEnclosingTypeSelection(false, true); setTypeName("", true); //$NON-NLS-1$ setSuperClass(initSuperclass, true); setSuperInterfaces(initSuperinterfaces, true); } // -------- UI Creation --------- /** * Creates a separator line. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createSeparator(Composite composite, int nColumns) { (new Separator(SWT.SEPARATOR | SWT.HORIZONTAL)).doFillIntoGrid(composite, nColumns, convertHeightInCharsToPixels(1)); } /** * Creates the controls for the package name field. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createPackageControls(Composite composite, int nColumns) { fPackageDialogField.doFillIntoGrid(composite, 4); LayoutUtil.setWidthHint(fPackageDialogField.getTextControl(null), getMaxFieldWidth()); } /** * Creates the controls for the enclosing type name field. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createEnclosingTypeControls(Composite composite, int nColumns) { // #6891 Composite tabGroup= new Composite(composite, SWT.NONE); MGridLayout layout= new MGridLayout(); layout.marginWidth= 0; layout.marginHeight= 0; tabGroup.setLayout(layout); fEnclosingTypeSelection.doFillIntoGrid(tabGroup, 1); Control c= fEnclosingTypeDialogField.getTextControl(composite); MGridData gd= new MGridData(MGridData.FILL_HORIZONTAL); gd.widthHint= getMaxFieldWidth(); gd.horizontalSpan= 2; c.setLayoutData(gd); c= fEnclosingTypeDialogField.getChangeControl(composite); c.setLayoutData(new MGridData(MGridData.HORIZONTAL_ALIGN_FILL)); } /** * Creates the controls for the type name field. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createTypeNameControls(Composite composite, int nColumns) { fTypeNameDialogField.doFillIntoGrid(composite, nColumns - 1); DialogField.createEmptySpace(composite); LayoutUtil.setWidthHint(fTypeNameDialogField.getTextControl(null), getMaxFieldWidth()); } /** * Creates the controls for the modifiers radio/ceckbox buttons. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createModifierControls(Composite composite, int nColumns) { LayoutUtil.setHorizontalSpan(fAccMdfButtons.getLabelControl(composite), 1); Control control= fAccMdfButtons.getSelectionButtonsGroup(composite); MGridData gd= new MGridData(MGridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= nColumns - 2; control.setLayoutData(gd); DialogField.createEmptySpace(composite); DialogField.createEmptySpace(composite); control= fOtherMdfButtons.getSelectionButtonsGroup(composite); gd= new MGridData(MGridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= nColumns - 2; control.setLayoutData(gd); DialogField.createEmptySpace(composite); } /** * Creates the controls for the superclass name field. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createSuperClassControls(Composite composite, int nColumns) { fSuperClassDialogField.doFillIntoGrid(composite, nColumns); LayoutUtil.setWidthHint(fSuperClassDialogField.getTextControl(null), getMaxFieldWidth()); } /** * Creates the controls for the superclass name field. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createSuperInterfacesControls(Composite composite, int nColumns) { fSuperInterfacesDialogField.doFillIntoGrid(composite, nColumns); MGridData gd= (MGridData)fSuperInterfacesDialogField.getListControl(null).getLayoutData(); if (fIsClass) { gd.heightHint= convertHeightInCharsToPixels(3); } else { gd.heightHint= convertHeightInCharsToPixels(6); } gd.grabExcessVerticalSpace= false; gd.widthHint= getMaxFieldWidth(); } /** * Sets the focus on the container if empty, elso on type name. */ protected void setFocus() { fTypeNameDialogField.setFocus(); } // -------- TypeFieldsAdapter -------- private class TypeFieldsAdapter implements IStringButtonAdapter, IDialogFieldListener, IListAdapter { // -------- IStringButtonAdapter public void changeControlPressed(DialogField field) { typePageChangeControlPressed(field); } // -------- IListAdapter public void customButtonPressed(DialogField field, int index) { typePageCustomButtonPressed(field, index); } public void selectionChanged(DialogField field) {} // -------- IDialogFieldListener public void dialogFieldChanged(DialogField field) { typePageDialogFieldChanged(field); } } private void typePageChangeControlPressed(DialogField field) { if (field == fPackageDialogField) { IPackageFragment pack= choosePackage(); if (pack != null) { fPackageDialogField.setText(pack.getElementName()); } } else if (field == fEnclosingTypeDialogField) { IType type= chooseEnclosingType(); if (type != null) { fEnclosingTypeDialogField.setText(JavaModelUtil.getFullyQualifiedName(type)); } } else if (field == fSuperClassDialogField) { IType type= chooseSuperType(); if (type != null) { fSuperClassDialogField.setText(JavaModelUtil.getFullyQualifiedName(type)); } } } private void typePageCustomButtonPressed(DialogField field, int index) { if (field == fSuperInterfacesDialogField) { chooseSuperInterfaces(); } } /* * A field on the type has changed. The fields' status and all dependend * status are updated. */ private void typePageDialogFieldChanged(DialogField field) { String fieldName= null; if (field == fPackageDialogField) { fPackageStatus= packageChanged(); updatePackageStatusLabel(); fTypeNameStatus= typeNameChanged(); fSuperClassStatus= superClassChanged(); fieldName= PACKAGE; } else if (field == fEnclosingTypeDialogField) { fEnclosingTypeStatus= enclosingTypeChanged(); fTypeNameStatus= typeNameChanged(); fSuperClassStatus= superClassChanged(); fieldName= ENCLOSING; } else if (field == fEnclosingTypeSelection) { updateEnableState(); boolean isEnclosedType= isEnclosingTypeSelected(); if (!isEnclosedType) { if (fAccMdfButtons.isSelected(PRIVATE_INDEX) || fAccMdfButtons.isSelected(PROTECTED_INDEX)) { fAccMdfButtons.setSelection(PRIVATE_INDEX, false); fAccMdfButtons.setSelection(PROTECTED_INDEX, false); fAccMdfButtons.setSelection(PUBLIC_INDEX, true); } if (fOtherMdfButtons.isSelected(fStaticMdfIndex)) { fOtherMdfButtons.setSelection(fStaticMdfIndex, false); } } fAccMdfButtons.enableSelectionButton(PRIVATE_INDEX, isEnclosedType && fIsClass); fAccMdfButtons.enableSelectionButton(PROTECTED_INDEX, isEnclosedType && fIsClass); fOtherMdfButtons.enableSelectionButton(fStaticMdfIndex, isEnclosedType); fTypeNameStatus= typeNameChanged(); fSuperClassStatus= superClassChanged(); fieldName= ENCLOSINGSELECTION; } else if (field == fTypeNameDialogField) { fTypeNameStatus= typeNameChanged(); fieldName= TYPENAME; } else if (field == fSuperClassDialogField) { fSuperClassStatus= superClassChanged(); fieldName= SUPER; } else if (field == fSuperInterfacesDialogField) { fSuperInterfacesStatus= superInterfacesChanged(); fieldName= INTERFACES; } else if (field == fOtherMdfButtons) { fModifierStatus= modifiersChanged(); fieldName= MODIFIERS; } else { fieldName= METHODS; } // tell all others handleFieldChanged(fieldName); } // -------- update message ---------------- /** * Called whenever a content of a field has changed. * Implementors of TypePage can hook in. * @see ContainerPage#handleFieldChanged */ protected void handleFieldChanged(String fieldName) { super.handleFieldChanged(fieldName); if (fieldName == CONTAINER) { fPackageStatus= packageChanged(); fEnclosingTypeStatus= enclosingTypeChanged(); fTypeNameStatus= typeNameChanged(); fSuperClassStatus= superClassChanged(); fSuperInterfacesStatus= superInterfacesChanged(); } } // ---- set / get ---------------- /** * Gets the text of package field. */ public String getPackageText() { return fPackageDialogField.getText(); } /** * Gets the text of enclosing type field. */ public String getEnclosingTypeText() { return fEnclosingTypeDialogField.getText(); } /** * Returns the package fragment corresponding to the current input. * @return Returns <code>null</code> if the input could not be resolved. */ public IPackageFragment getPackageFragment() { if (!isEnclosingTypeSelected()) { return fCurrPackage; } else { if (fCurrEnclosingType != null) { return fCurrEnclosingType.getPackageFragment(); } } return null; } /** * Sets the package fragment. * This will update model and the text of the control. * @param canBeModified Selects if the package fragment can be changed by the user */ public void setPackageFragment(IPackageFragment pack, boolean canBeModified) { fCurrPackage= pack; fCanModifyPackage= canBeModified; String str= (pack == null) ? "" : pack.getElementName(); //$NON-NLS-1$ fPackageDialogField.setText(str); updateEnableState(); } /** * Returns the encloding type corresponding to the current input. * @return Returns <code>null</code> if enclosing type is not selected or the input could not * be resolved. */ public IType getEnclosingType() { if (isEnclosingTypeSelected()) { return fCurrEnclosingType; } return null; } /** * Sets the package fragment. * This will update model and the text of the control. * @param canBeModified Selects if the enclosing type can be changed by the user */ public void setEnclosingType(IType type, boolean canBeModified) { fCurrEnclosingType= type; fCanModifyEnclosingType= canBeModified; String str= (type == null) ? "" : JavaModelUtil.getFullyQualifiedName(type); //$NON-NLS-1$ fEnclosingTypeDialogField.setText(str); updateEnableState(); } /** * Returns <code>true</code> if the enclosing type selection check box is enabled. */ public boolean isEnclosingTypeSelected() { return fEnclosingTypeSelection.isSelected(); } /** * Sets the enclosing type selection checkbox. * @param canBeModified Selects if the enclosing type selection can be changed by the user */ public void setEnclosingTypeSelection(boolean isSelected, boolean canBeModified) { fEnclosingTypeSelection.setSelection(isSelected); fEnclosingTypeSelection.setEnabled(canBeModified); updateEnableState(); } /** * Gets the type name. */ public String getTypeName() { return fTypeNameDialogField.getText(); } /** * Sets the type name. * @param canBeModified Selects if the type name can be changed by the user */ public void setTypeName(String name, boolean canBeModified) { fTypeNameDialogField.setText(name); fTypeNameDialogField.setEnabled(canBeModified); } /** * Gets the selected modifiers. * @see Flags */ public int getModifiers() { int mdf= 0; if (fAccMdfButtons.isSelected(PUBLIC_INDEX)) { mdf+= IConstants.AccPublic; } else if (fAccMdfButtons.isSelected(PRIVATE_INDEX)) { mdf+= IConstants.AccPrivate; } else if (fAccMdfButtons.isSelected(PROTECTED_INDEX)) { mdf+= IConstants.AccProtected; } if (fOtherMdfButtons.isSelected(ABSTRACT_INDEX) && (fStaticMdfIndex != 0)) { mdf+= IConstants.AccAbstract; } if (fOtherMdfButtons.isSelected(FINAL_INDEX)) { mdf+= IConstants.AccFinal; } if (fOtherMdfButtons.isSelected(fStaticMdfIndex)) { mdf+= IConstants.AccStatic; } return mdf; } /** * Sets the modifiers. * @param canBeModified Selects if the modifiers can be changed by the user * @see IConstants */ public void setModifiers(int modifiers, boolean canBeModified) { if (Flags.isPublic(modifiers)) { fAccMdfButtons.setSelection(PUBLIC_INDEX, true); } else if (Flags.isPrivate(modifiers)) { fAccMdfButtons.setSelection(PRIVATE_INDEX, true); } else if (Flags.isProtected(modifiers)) { fAccMdfButtons.setSelection(PROTECTED_INDEX, true); } else { fAccMdfButtons.setSelection(DEFAULT_INDEX, true); } if (Flags.isAbstract(modifiers)) { fOtherMdfButtons.setSelection(ABSTRACT_INDEX, true); } if (Flags.isFinal(modifiers)) { fOtherMdfButtons.setSelection(FINAL_INDEX, true); } if (Flags.isStatic(modifiers)) { fOtherMdfButtons.setSelection(fStaticMdfIndex, true); } fAccMdfButtons.setEnabled(canBeModified); fOtherMdfButtons.setEnabled(canBeModified); } /** * Gets the content of the super class text field. */ public String getSuperClass() { return fSuperClassDialogField.getText(); } /** * Sets the super class name. * @param canBeModified Selects if the super class can be changed by the user */ public void setSuperClass(String name, boolean canBeModified) { fSuperClassDialogField.setText(name); fSuperClassDialogField.setEnabled(canBeModified); } /** * Gets the currently chosen super interfaces. * @return returns a list of String */ public List getSuperInterfaces() { return fSuperInterfacesDialogField.getElements(); } /** * Sets the super interfaces. * @param interfacesNames a list of String */ public void setSuperInterfaces(List interfacesNames, boolean canBeModified) { fSuperInterfacesDialogField.setElements(interfacesNames); fSuperInterfacesDialogField.setEnabled(canBeModified); } // ----------- validation ---------- /** * Called when the package field has changed. * The method validates the package name and returns the status of the validation * This also updates the package fragment model. * Can be extended to add more validation */ protected IStatus packageChanged() { StatusInfo status= new StatusInfo(); fPackageDialogField.enableButton(getPackageFragmentRoot() != null); String packName= getPackageText(); if (packName.length() > 0) { IStatus val= JavaConventions.validatePackageName(packName); if (val.getSeverity() == IStatus.ERROR) { status.setError(NewWizardMessages.getFormattedString("TypePage.error.InvalidPackageName", val.getMessage())); //$NON-NLS-1$ return status; } else if (val.getSeverity() == IStatus.WARNING) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.DiscouragedPackageName", val.getMessage())); //$NON-NLS-1$ // continue } } IPackageFragmentRoot root= getPackageFragmentRoot(); if (root != null) { IPackageFragment pack= root.getPackageFragment(packName); try { IPath rootPath= root.getPath(); IPath outputPath= root.getJavaProject().getOutputLocation(); if (rootPath.isPrefixOf(outputPath) && !rootPath.equals(outputPath)) { // if the bin folder is inside of our root, dont allow to name a package // like the bin folder IPath packagePath= pack.getUnderlyingResource().getFullPath(); if (outputPath.isPrefixOf(packagePath)) { status.setError(NewWizardMessages.getString("TypePage.error.ClashOutputLocation")); //$NON-NLS-1$ return status; } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); // let pass } fCurrPackage= pack; } else { status.setError(""); //$NON-NLS-1$ } return status; } /* * Updates the 'default' label next to the package field. */ private void updatePackageStatusLabel() { String packName= fPackageDialogField.getText(); if (packName.length() == 0) { fPackageDialogField.setStatus(NewWizardMessages.getString("TypePage.default")); //$NON-NLS-1$ } else { fPackageDialogField.setStatus(""); //$NON-NLS-1$ } } /* * Updates the enable state of buttons related to the enclosing type selection checkbox. */ private void updateEnableState() { boolean enclosing= isEnclosingTypeSelected(); fPackageDialogField.setEnabled(fCanModifyPackage && !enclosing); fEnclosingTypeDialogField.setEnabled(fCanModifyEnclosingType && enclosing); } /** * Called when the enclosing type name has changed. * The method validates the enclosing type and returns the status of the validation * This also updates the enclosing type model. * Can be extended to add more validation */ protected IStatus enclosingTypeChanged() { StatusInfo status= new StatusInfo(); fCurrEnclosingType= null; IPackageFragmentRoot root= getPackageFragmentRoot(); fEnclosingTypeDialogField.enableButton(root != null); if (root == null) { status.setError(""); //$NON-NLS-1$ return status; } String enclName= getEnclosingTypeText(); if (enclName.length() == 0) { status.setError(NewWizardMessages.getString("TypePage.error.EnclosingTypeEnterName")); //$NON-NLS-1$ return status; } try { IType type= JavaModelUtil.findType(root.getJavaProject(), enclName); if (type == null) { status.setError(NewWizardMessages.getString("TypePage.error.EnclosingTypeNotExists")); //$NON-NLS-1$ return status; } if (type.getCompilationUnit() == null) { status.setError(NewWizardMessages.getString("TypePage.error.EnclosingNotInCU")); //$NON-NLS-1$ return status; } fCurrEnclosingType= type; return status; } catch (JavaModelException e) { status.setError(NewWizardMessages.getString("TypePage.error.EnclosingTypeNotExists")); //$NON-NLS-1$ JavaPlugin.log(e.getStatus()); return status; } } /** * Called when the type name has changed. * The method validates the type name and returns the status of the validation. * Can be extended to add more validation */ protected IStatus typeNameChanged() { StatusInfo status= new StatusInfo(); String typeName= getTypeName(); // must not be empty if (typeName.length() == 0) { status.setError(NewWizardMessages.getString("TypePage.error.EnterTypeName")); //$NON-NLS-1$ return status; } if (typeName.indexOf('.') != -1) { status.setError(NewWizardMessages.getString("TypePage.error.QualifiedName")); //$NON-NLS-1$ return status; } IStatus val= JavaConventions.validateJavaTypeName(typeName); if (val.getSeverity() == IStatus.ERROR) { status.setError(NewWizardMessages.getFormattedString("TypePage.error.InvalidTypeName", val.getMessage())); //$NON-NLS-1$ return status; } else if (val.getSeverity() == IStatus.WARNING) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.TypeNameDiscouraged", val.getMessage())); //$NON-NLS-1$ // continue checking } // must not exist if (!isEnclosingTypeSelected()) { IPackageFragment pack= getPackageFragment(); if (pack != null) { ICompilationUnit cu= pack.getCompilationUnit(typeName + ".java"); //$NON-NLS-1$ if (cu.exists()) { status.setError(NewWizardMessages.getString("TypePage.error.TypeNameExists")); //$NON-NLS-1$ return status; } } } else { IType type= getEnclosingType(); if (type != null) { IType member= type.getType(typeName); if (member.exists()) { status.setError(NewWizardMessages.getString("TypePage.error.TypeNameExists")); //$NON-NLS-1$ return status; } } } return status; } /** * Called when the superclass name has changed. * The method validates the superclass name and returns the status of the validation. * Can be extended to add more validation */ protected IStatus superClassChanged() { StatusInfo status= new StatusInfo(); IPackageFragmentRoot root= getPackageFragmentRoot(); fSuperClassDialogField.enableButton(root != null); fSuperClass= null; String sclassName= getSuperClass(); if (sclassName.length() == 0) { // accept the empty field (stands for java.lang.Object) return status; } IStatus val= JavaConventions.validateJavaTypeName(sclassName); if (!val.isOK()) { status.setError(NewWizardMessages.getString("TypePage.error.InvalidSuperClassName")); //$NON-NLS-1$ return status; } if (root != null) { try { IType type= resolveSuperTypeName(root.getJavaProject(), sclassName); if (type == null) { status.setWarning(NewWizardMessages.getString("TypePage.warning.SuperClassNotExists")); //$NON-NLS-1$ return status; } else { if (type.isInterface()) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.SuperClassIsNotClass", sclassName)); //$NON-NLS-1$ return status; } int flags= type.getFlags(); if (Flags.isFinal(flags)) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.SuperClassIsFinal", sclassName)); //$NON-NLS-1$ return status; } else if (!JavaModelUtil.isVisible(type, getPackageFragment())) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.SuperClassIsNotVisible", sclassName)); //$NON-NLS-1$ return status; } } fSuperClass= type; } catch (JavaModelException e) { status.setError(NewWizardMessages.getString("TypePage.error.InvalidSuperClassName")); //$NON-NLS-1$ JavaPlugin.log(e.getStatus()); } } else { status.setError(""); //$NON-NLS-1$ } return status; } private IType resolveSuperTypeName(IJavaProject jproject, String sclassName) throws JavaModelException { IType type= null; if (isEnclosingTypeSelected()) { // search in the context of the enclosing type IType enclosingType= getEnclosingType(); if (enclosingType != null) { String[][] res= enclosingType.resolveType(sclassName); if (res != null && res.length > 0) { type= JavaModelUtil.findType(jproject, res[0][0], res[0][1]); } } } else { IPackageFragment currPack= getPackageFragment(); if (type == null && currPack != null) { String packName= currPack.getElementName(); // search in own package if (!currPack.isDefaultPackage()) { type= JavaModelUtil.findType(jproject, packName, sclassName); } // search in java.lang if (type == null && !"java.lang".equals(packName)) { //$NON-NLS-1$ type= JavaModelUtil.findType(jproject, "java.lang", sclassName); //$NON-NLS-1$ } } // search fully qualified if (type == null) { type= JavaModelUtil.findType(jproject, sclassName); } } return type; } /** * Called when the list of super interface has changed. * The method validates the superinterfaces and returns the status of the validation. * Can be extended to add more validation. */ protected IStatus superInterfacesChanged() { StatusInfo status= new StatusInfo(); IPackageFragmentRoot root= getPackageFragmentRoot(); fSuperInterfacesDialogField.enableButton(0, root != null); if (root != null) { List elements= fSuperInterfacesDialogField.getElements(); int nElements= elements.size(); for (int i= 0; i < nElements; i++) { String intfname= (String)elements.get(i); try { IType type= JavaModelUtil.findType(root.getJavaProject(), intfname); if (type == null) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.InterfaceNotExists", intfname)); //$NON-NLS-1$ return status; } else { if (type.isClass()) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.InterfaceIsNotInterface", intfname)); //$NON-NLS-1$ return status; } if (!JavaModelUtil.isVisible(type, getPackageFragment())) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.InterfaceIsNotVisible", intfname)); //$NON-NLS-1$ return status; } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); // let pass, checking is an extra } } } return status; } /** * Called when the modifiers have changed. * The method validates the modifiers and returns the status of the validation. * Can be extended to add more validation. */ protected IStatus modifiersChanged() { StatusInfo status= new StatusInfo(); int modifiers= getModifiers(); if (Flags.isFinal(modifiers) && Flags.isAbstract(modifiers)) { status.setError(NewWizardMessages.getString("TypePage.error.ModifiersFinalAndAbstract")); //$NON-NLS-1$ } return status; } // selection dialogs private IPackageFragment choosePackage() { IPackageFragmentRoot froot= getPackageFragmentRoot(); IJavaElement[] packages= null; try { if (froot != null) { packages= froot.getChildren(); } } catch (JavaModelException e) { JavaPlugin.log(e); } if (packages == null) { packages= new IJavaElement[0]; } ElementListSelectionDialog dialog= new ElementListSelectionDialog(getShell(), new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT)); dialog.setIgnoreCase(false); dialog.setTitle(NewWizardMessages.getString("TypePage.ChoosePackageDialog.title")); //$NON-NLS-1$ dialog.setMessage(NewWizardMessages.getString("TypePage.ChoosePackageDialog.description")); //$NON-NLS-1$ dialog.setEmptyListMessage(NewWizardMessages.getString("TypePage.ChoosePackageDialog.empty")); //$NON-NLS-1$ dialog.setElements(packages); if (fCurrPackage != null) { dialog.setInitialSelections(new Object[] { fCurrPackage }); } if (dialog.open() == dialog.OK) { return (IPackageFragment) dialog.getFirstResult(); } return null; } private IType chooseEnclosingType() { IPackageFragmentRoot root= getPackageFragmentRoot(); if (root == null) { return null; } // the search scop only contains source folders ArrayList elementsInScope= new ArrayList(); try { IPackageFragmentRoot[] pfrs= root.getJavaProject().getPackageFragmentRoots(); for (int i= 0; i < pfrs.length; i++) { if (pfrs[i].getKind() == IPackageFragmentRoot.K_SOURCE) { elementsInScope.add(pfrs[i]); } } } catch (JavaModelException e) { JavaPlugin.log(e); } IJavaElement[] elements= (IJavaElement[]) elementsInScope.toArray(new IJavaElement[elementsInScope.size()]); IJavaSearchScope scope= SearchEngine.createJavaSearchScope(elements); TypeSelectionDialog dialog= new TypeSelectionDialog(getShell(), getWizard().getContainer(), scope, IJavaElementSearchConstants.CONSIDER_TYPES); dialog.setTitle(NewWizardMessages.getString("TypePage.ChooseEnclosingTypeDialog.title")); //$NON-NLS-1$ dialog.setMessage(NewWizardMessages.getString("TypePage.ChooseEnclosingTypeDialog.description")); //$NON-NLS-1$ if (fCurrEnclosingType != null) { dialog.setInitialSelections(new Object[] { fCurrEnclosingType }); dialog.setFilter(fCurrEnclosingType.getElementName().substring(0, 1)); } if (dialog.open() == dialog.OK) { return (IType) dialog.getFirstResult(); } return null; } private IType chooseSuperType() { IPackageFragmentRoot root= getPackageFragmentRoot(); if (root == null) { return null; } IJavaElement[] elements= new IJavaElement[] { root.getJavaProject() }; IJavaSearchScope scope= SearchEngine.createJavaSearchScope(elements); TypeSelectionDialog dialog= new TypeSelectionDialog(getShell(), getWizard().getContainer(), scope, IJavaElementSearchConstants.CONSIDER_CLASSES); dialog.setTitle(NewWizardMessages.getString("TypePage.SuperClassDialog.title")); //$NON-NLS-1$ dialog.setMessage(NewWizardMessages.getString("TypePage.SuperClassDialog.message")); //$NON-NLS-1$ if (fSuperClass != null) { dialog.setFilter(fSuperClass.getElementName()); } if (dialog.open() == dialog.OK) { return (IType) dialog.getFirstResult(); } return null; } private void chooseSuperInterfaces() { IPackageFragmentRoot root= getPackageFragmentRoot(); if (root == null) { return; } IJavaProject project= root.getJavaProject(); SuperInterfaceSelectionDialog dialog= new SuperInterfaceSelectionDialog(getShell(), getWizard().getContainer(), fSuperInterfacesDialogField, project); dialog.setTitle(NewWizardMessages.getString("TypePage.InterfacesDialog.title")); //$NON-NLS-1$ dialog.setMessage(NewWizardMessages.getString("TypePage.InterfacesDialog.message")); //$NON-NLS-1$ dialog.open(); return; } // ---- creation ---------------- /** * Creates a type using the current field values. */ public void createType(IProgressMonitor monitor) throws CoreException, InterruptedException { monitor.beginTask(NewWizardMessages.getString("TypePage.operationdesc"), 10); //$NON-NLS-1$ IPackageFragmentRoot root= getPackageFragmentRoot(); IPackageFragment pack= getPackageFragment(); if (pack == null) { pack= root.getPackageFragment(""); //$NON-NLS-1$ } if (!pack.exists()) { String packName= pack.getElementName(); pack= root.createPackageFragment(packName, true, null); } monitor.worked(1); String clName= fTypeNameDialogField.getText(); boolean isInnerClass= isEnclosingTypeSelected(); IType createdType; ImportsStructure imports; int indent= 0; String[] prefOrder= ImportOrganizePreferencePage.getImportOrderPreference(); int threshold= ImportOrganizePreferencePage.getImportNumberThreshold(); String lineDelimiter= null; if (!isInnerClass) { ICompilationUnit parentCU= pack.getCompilationUnit(clName + ".java"); //$NON-NLS-1$ imports= new ImportsStructure(parentCU, prefOrder, threshold, false); lineDelimiter= StubUtility.getLineDelimiterUsed(parentCU); String content= createTypeBody(imports, lineDelimiter); createdType= parentCU.createType(content, null, false, new SubProgressMonitor(monitor, 5)); String fileComment= getFileComment(); if (fileComment != null) { parentCU.getBuffer().replace(0, 0, fileComment + lineDelimiter); } } else { IType enclosingType= getEnclosingType(); // if we are working on a enclosed type that is open in an editor, // then replace the enclosing type with its working copy IType workingCopy= (IType) EditorUtility.getWorkingCopy(enclosingType); if (workingCopy != null) { enclosingType= workingCopy; } ICompilationUnit parentCU= enclosingType.getCompilationUnit(); imports= new ImportsStructure(parentCU, prefOrder, threshold, true); lineDelimiter= StubUtility.getLineDelimiterUsed(enclosingType); String content= createTypeBody(imports, lineDelimiter); IJavaElement[] elems= enclosingType.getChildren(); IJavaElement sibling= elems.length > 0 ? elems[0] : null; createdType= enclosingType.createType(content, sibling, false, new SubProgressMonitor(monitor, 1)); indent= StubUtility.getIndentUsed(enclosingType) + 1; } // add imports for superclass/interfaces, so the type can be parsed correctly imports.create(!isInnerClass, new SubProgressMonitor(monitor, 1)); String[] methods= evalMethods(createdType, imports, new SubProgressMonitor(monitor, 1)); if (methods.length > 0) { for (int i= 0; i < methods.length; i++) { createdType.createMethod(methods[i], null, false, null); } // add imports imports.create(!isInnerClass, null); } monitor.worked(1); ICompilationUnit cu= createdType.getCompilationUnit(); ISourceRange range; if (isInnerClass) { synchronized(cu) { cu.reconcile(); } range= createdType.getSourceRange(); } else { range= cu.getSourceRange(); } IBuffer buf= cu.getBuffer(); String originalContent= buf.getText(range.getOffset(), range.getLength()); String formattedContent= StubUtility.codeFormat(originalContent, indent, lineDelimiter); buf.replace(range.getOffset(), range.getLength(), formattedContent); if (!isInnerClass) { buf.save(new SubProgressMonitor(monitor, 1), false); } else { monitor.worked(1); } fCreatedType= createdType; monitor.done(); } /** * Returns the created type. Only valid after createType has been invoked */ public IType getCreatedType() { return fCreatedType; } // ---- construct cu body---------------- private void writeSuperClass(StringBuffer buf, IImportsStructure imports) { String typename= getSuperClass(); if (fIsClass && typename.length() > 0 && !"java.lang.Object".equals(typename)) { //$NON-NLS-1$ buf.append(" extends "); //$NON-NLS-1$ buf.append(Signature.getSimpleName(typename)); if (fSuperClass != null) { imports.addImport(JavaModelUtil.getFullyQualifiedName(fSuperClass)); } else { imports.addImport(typename); } } } private void writeSuperInterfaces(StringBuffer buf, IImportsStructure imports) { List interfaces= getSuperInterfaces(); int last= interfaces.size() - 1; if (last >= 0) { if (fIsClass) { buf.append(" implements "); //$NON-NLS-1$ } else { buf.append(" extends "); //$NON-NLS-1$ } for (int i= 0; i <= last; i++) { String typename= (String) interfaces.get(i); imports.addImport(typename); buf.append(Signature.getSimpleName(typename)); if (i < last) { buf.append(", "); //$NON-NLS-1$ } } } } /* * Called from createType to construct the source for this type */ private String createTypeBody(IImportsStructure imports, String lineDelimiter) { StringBuffer buf= new StringBuffer(); String typeComment= getTypeComment(); if (typeComment != null) { buf.append(typeComment); buf.append(lineDelimiter); } int modifiers= getModifiers(); buf.append(Flags.toString(modifiers)); if (modifiers != 0) { buf.append(' '); } buf.append(fIsClass ? "class " : "interface "); //$NON-NLS-2$ //$NON-NLS-1$ buf.append(getTypeName()); writeSuperClass(buf, imports); writeSuperInterfaces(buf, imports); buf.append(" {"); //$NON-NLS-1$ buf.append(lineDelimiter); buf.append(lineDelimiter); buf.append('}'); buf.append(lineDelimiter); return buf.toString(); } /** * Called from createType to allow adding methods for the newly created type * Returns array of sources of the methods that have to be added * @param parent The type where the methods will be added to */ protected String[] evalMethods(IType parent, IImportsStructure imports, IProgressMonitor monitor) throws CoreException { return new String[0]; } /** * Called from createType to get a file comment. By default the content of template * 'filecomment' is taken. * Returns source or null, if no file comment should be added */ protected String getFileComment() { if (CodeGenerationPreferencePage.doFileComments()) { return getTemplate("filecomment"); } return null; } /** * Called from createType to get a type comment. * Returns source or null, if no type comment should be added */ protected String getTypeComment() { if (CodeGenerationPreferencePage.doCreateComments()) { return getTemplate("typecomment"); } return null; } protected String getTemplate(String name) { Template[] templates= Templates.getInstance().getTemplates(); for (int i= 0; i < templates.length; i++) { if (name.equals(templates[i].getName())) { return templates[i].getPattern(); } } return null; } /** * Creates the bodies of all unimplemented methods or/and all constructors * Can be used by implementors of TypePage to add method stub checkboxes */ protected String[] constructInheritedMethods(IType type, boolean doConstructors, boolean doUnimplementedMethods, IImportsStructure imports, IProgressMonitor monitor) throws CoreException { List newMethods= new ArrayList(); ITypeHierarchy hierarchy= type.newSupertypeHierarchy(monitor); CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); if (doConstructors) { IType superclass= hierarchy.getSuperclass(type); if (superclass != null) { String[] constructors= StubUtility.evalConstructors(type, superclass, settings, imports); if (constructors != null) { for (int i= 0; i < constructors.length; i++) { newMethods.add(constructors[i]); } } } } if (doUnimplementedMethods) { String[] unimplemented= StubUtility.evalUnimplementedMethods(type, hierarchy, false, settings, null, imports); if (unimplemented != null) { for (int i= 0; i < unimplemented.length; i++) { newMethods.add(unimplemented[i]); } } } return (String[]) newMethods.toArray(new String[newMethods.size()]); } // ---- creation ---------------- /** * @see NewElementWizardPage#getRunnable */ public IRunnableWithProgress getRunnable() { return new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException { try { if (monitor == null) { monitor= new NullProgressMonitor(); } createType(monitor); } catch (CoreException e) { throw new InvocationTargetException(e); } } }; } }
7,834
Bug 7834 Methods-override dialog should present methods sorted (abc..)
Imagine a class extending JPanel. I want to override setBackgroundColor(Color c). I don't know where in the class-hierarchy the method is declared, so i've to search more or less to all entries in the tree, eye-scanning setBa.. . It's not so easy, as there are quite a few methods. So it would be nice to sort the method names in alphabeticall order, and really great would be a method searching. Could the code assist used for that?
verified fixed
66fae4e
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-22T16:54:46Z"
"2002-01-17T15:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OverrideMethodQuery.java
package org.eclipse.jdt.internal.ui.actions; import java.util.ArrayList; import java.util.HashSet; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.corext.codemanipulation.IOverrideMethodQuery; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.CheckedTreeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ISelectionValidator; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; public class OverrideMethodQuery implements IOverrideMethodQuery { private static class OverrideMethodContentProvider implements ITreeContentProvider { private Object[] fTypes; private IMethod[] fMethods; private final Object[] fEmpty= new Object[0]; /** * Constructor for OverrideMethodContentProvider. */ public OverrideMethodContentProvider(IMethod[] methods, Object[] types) { fMethods= methods; fTypes= types; } /* * @see ITreeContentProvider#getChildren(Object) */ public Object[] getChildren(Object parentElement) { if (parentElement instanceof IType) { ArrayList result= new ArrayList(fMethods.length); for (int i= 0; i < fMethods.length; i++) { if (fMethods[i].getDeclaringType().equals(parentElement)) { result.add(fMethods[i]); } } return result.toArray(); } return fEmpty; } /* * @see ITreeContentProvider#getParent(Object) */ public Object getParent(Object element) { if (element instanceof IMethod) { return ((IMethod)element).getDeclaringType(); } return null; } /* * @see ITreeContentProvider#hasChildren(Object) */ public boolean hasChildren(Object element) { return getChildren(element).length > 0; } /* * @see IStructuredContentProvider#getElements(Object) */ public Object[] getElements(Object inputElement) { return fTypes; } /* * @see IContentProvider#dispose() */ public void dispose() { } /* * @see IContentProvider#inputChanged(Viewer, Object, Object) */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } } private static class OverrideMethodSorter extends ViewerSorter { private IType[] fAllTypes; public OverrideMethodSorter(ITypeHierarchy typeHierarchy) { IType curr= typeHierarchy.getType(); IType[] superTypes= typeHierarchy.getAllSupertypes(curr); fAllTypes= new IType[superTypes.length + 1]; fAllTypes[0]= curr; System.arraycopy(superTypes, 0, fAllTypes, 1, superTypes.length); } /* * @see ViewerSorter#compare(Viewer, Object, Object) */ public int compare(Viewer viewer, Object e1, Object e2) { if (e1 instanceof IType && e2 instanceof IType) { if (e1.equals(e2)) { return 0; } for (int i= 0; i < fAllTypes.length; i++) { IType curr= fAllTypes[i]; if (curr.equals(e1)) { return -1; } if (curr.equals(e2)) { return 1; } } } return 0; } } private class OverrideMethodValidator implements ISelectionValidator { /* * @see ISelectionValidator#validate(Object[]) */ public IStatus validate(Object[] selection) { int count= 0; for (int i= 0; i < selection.length; i++) { if (selection[i] instanceof IMethod) { count++; } } if (count == 0 && !fEmptySelectionAllowed) { return new StatusInfo(IStatus.ERROR, ""); } String message; if (count == 1) { message= JavaUIMessages.getFormattedString("OverrideMethodQuery.selectioninfo.one", String.valueOf(count)); } else { message= JavaUIMessages.getFormattedString("OverrideMethodQuery.selectioninfo.more", String.valueOf(count)); } return new StatusInfo(IStatus.INFO, message); } } private boolean fEmptySelectionAllowed; private Shell fShell; public OverrideMethodQuery(Shell shell, boolean emptySelectionAllowed) { fShell= shell; fEmptySelectionAllowed= emptySelectionAllowed; } /* * @see IOverrideMethodQuery#select(IMethod[], IMethod[], ITypeHierarchy) */ public IMethod[] select(IMethod[] methods, IMethod[] defaultSelected, ITypeHierarchy typeHierarchy) { HashSet types= new HashSet(methods.length); for (int i= 0; i < methods.length; i++) { types.add(methods[i].getDeclaringType()); } Object[] typesArrays= types.toArray(); ViewerSorter sorter= new OverrideMethodSorter(typeHierarchy); sorter.sort(null, typesArrays); HashSet expanded= new HashSet(defaultSelected.length); for (int i= 0; i < defaultSelected.length; i++) { expanded.add(defaultSelected[i].getDeclaringType()); } if (expanded.isEmpty() && typesArrays.length > 0) { expanded.add(typesArrays[0]); } ILabelProvider lprovider= new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT); ITreeContentProvider cprovider= new OverrideMethodContentProvider(methods, typesArrays); CheckedTreeSelectionDialog dialog= new CheckedTreeSelectionDialog(fShell, lprovider, cprovider); dialog.setValidator(new OverrideMethodValidator()); dialog.setTitle(JavaUIMessages.getString("OverrideMethodQuery.dialog.title")); dialog.setMessage(JavaUIMessages.getString("OverrideMethodQuery.dialog.description")); dialog.setInitialSelections(defaultSelected); dialog.setExpandedElements(expanded.toArray()); dialog.setContainerMode(true); dialog.setSize(60, 25); dialog.setInput(this); // input does not matter if (dialog.open() == dialog.OK) { Object[] checkedElements= dialog.getResult(); ArrayList result= new ArrayList(checkedElements.length); for (int i= 0; i < checkedElements.length; i++) { Object curr= checkedElements[i]; if (curr instanceof IMethod) { result.add(curr); } } return (IMethod[]) result.toArray(new IMethod[result.size()]); } return null; } }
8,023
Bug 8023 coreexception when draging packages to its own parent
1. drag a package ot its parent project, say 'Yes' to replace 4 org.eclipse.jdt.core 966 Core exception: Problems encountered while moving resources. org.eclipse.core.internal.resources.ResourceException: Problems encountered while moving resources. at org.eclipse.core.internal.resources.Workspace.move (Workspace.java:1020) at org.eclipse.jdt.internal.core.JavaModelOperation.moveResources (JavaModelOperation.java:439) at org.eclipse.jdt.internal.core.CopyResourceElementsOperation.processPackageFragme ntResource(CopyResourceElementsOperation.java:325) at org.eclipse.jdt.internal.core.CopyResourceElementsOperation.processElement (CopyResourceElementsOperation.java:269) at org.eclipse.jdt.internal.core.MultiOperation.processElements (MultiOperation.java:181) at org.eclipse.jdt.internal.core.CopyResourceElementsOperation.processElements (CopyResourceElementsOperation.java:283) at org.eclipse.jdt.internal.core.MultiOperation.executeOperation (MultiOperation.java:85) at org.eclipse.jdt.internal.core.JavaModelOperation.execute (JavaModelOperation.java:268) at org.eclipse.jdt.internal.core.JavaModelOperation.run (JavaModelOperation.java:476) at org.eclipse.core.internal.resources.Workspace.run (Workspace.java:1232) at org.eclipse.jdt.internal.core.JavaModelManager.runOperation (JavaModelManager.java:1133) at org.eclipse.jdt.internal.core.JavaElement.runOperation (JavaElement.java:526) at org.eclipse.jdt.internal.core.JavaModel.runOperation (JavaModel.java:486) at org.eclipse.jdt.internal.core.JavaModel.move(JavaModel.java:451) at org.eclipse.jdt.internal.core.PackageFragment.move (PackageFragment.java:264) at org.eclipse.jdt.internal.corext.refactoring.changes.MovePackageChange.doPerform (MovePackageChange.java:28) at org.eclipse.jdt.internal.corext.refactoring.changes.PackageReorgChange.perform (PackageReorgChange.java:40) at org.eclipse.jdt.internal.corext.refactoring.CompositeChange.createUndoList (CompositeChange.java:119) at org.eclipse.jdt.internal.corext.refactoring.CompositeChange.perform (CompositeChange.java:144) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation$1.execute (PerformChangeOperation.java:146) at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run (WorkspaceModifyOperation.java:64) at org.eclipse.core.internal.resources.Workspace.run (Workspace.java:1232) at org.eclipse.ui.actions.WorkspaceModifyOperation.run (WorkspaceModifyOperation.java:78) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation.executeChange (PerformChangeOperation.java:151) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation.run (PerformChangeOperation.java:125) at org.eclipse.jface.operation.ModalContext.runInCurrentThread (ModalContext.java:296) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:249) at org.eclipse.jface.dialogs.ProgressMonitorDialog.run (ProgressMonitorDialog.java:335) at org.eclipse.jdt.internal.ui.reorg.ReorgAction.perform (ReorgAction.java:82) at org.eclipse.jdt.internal.ui.reorg.ReorgDestinationAction.doReorg (ReorgDestinationAction.java:147) at org.eclipse.jdt.internal.ui.reorg.MoveAction.doReorg (MoveAction.java:195) at org.eclipse.jdt.internal.ui.reorg.ReorgDestinationAction.run (ReorgDestinationAction.java:108) at org.eclipse.jdt.internal.ui.reorg.MoveAction.run(MoveAction.java:186) at org.eclipse.jdt.internal.ui.packageview.SelectionTransferDropAdapter.handleDropM ove(SelectionTransferDropAdapter.java:153) at org.eclipse.jdt.internal.ui.packageview.SelectionTransferDropAdapter.drop (SelectionTransferDropAdapter.java:109) at org.eclipse.jdt.internal.ui.dnd.JdtViewerDropAdapter.drop (JdtViewerDropAdapter.java:107) at org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter.drop (DelegatingDropAdapter.java:73) at org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:59) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.dnd.DropTarget.notifyListeners(DropTarget.java:514) at org.eclipse.swt.dnd.DropTarget.Drop(DropTarget.java:452) at org.eclipse.swt.dnd.DropTarget.access$7(DropTarget.java:380) at org.eclipse.swt.dnd.DropTarget$4.method6(DropTarget.java:180) at org.eclipse.swt.internal.ole.win32.COMObject.callback6 (COMObject.java:109) at org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native Method) at org.eclipse.swt.dnd.DragSource.drag(DragSource.java:248) at org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:229) at org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:119) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Tree.WM_LBUTTONDOWN(Tree.java:1504) at org.eclipse.swt.widgets.Control.windowProc(Control.java(Compiled Code)) at org.eclipse.swt.widgets.Display.windowProc(Display.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method) at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
6710402
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-23T18:00:02Z"
"2002-01-22T17:20:00Z"
org.eclipse.jdt.ui/core
8,023
Bug 8023 coreexception when draging packages to its own parent
1. drag a package ot its parent project, say 'Yes' to replace 4 org.eclipse.jdt.core 966 Core exception: Problems encountered while moving resources. org.eclipse.core.internal.resources.ResourceException: Problems encountered while moving resources. at org.eclipse.core.internal.resources.Workspace.move (Workspace.java:1020) at org.eclipse.jdt.internal.core.JavaModelOperation.moveResources (JavaModelOperation.java:439) at org.eclipse.jdt.internal.core.CopyResourceElementsOperation.processPackageFragme ntResource(CopyResourceElementsOperation.java:325) at org.eclipse.jdt.internal.core.CopyResourceElementsOperation.processElement (CopyResourceElementsOperation.java:269) at org.eclipse.jdt.internal.core.MultiOperation.processElements (MultiOperation.java:181) at org.eclipse.jdt.internal.core.CopyResourceElementsOperation.processElements (CopyResourceElementsOperation.java:283) at org.eclipse.jdt.internal.core.MultiOperation.executeOperation (MultiOperation.java:85) at org.eclipse.jdt.internal.core.JavaModelOperation.execute (JavaModelOperation.java:268) at org.eclipse.jdt.internal.core.JavaModelOperation.run (JavaModelOperation.java:476) at org.eclipse.core.internal.resources.Workspace.run (Workspace.java:1232) at org.eclipse.jdt.internal.core.JavaModelManager.runOperation (JavaModelManager.java:1133) at org.eclipse.jdt.internal.core.JavaElement.runOperation (JavaElement.java:526) at org.eclipse.jdt.internal.core.JavaModel.runOperation (JavaModel.java:486) at org.eclipse.jdt.internal.core.JavaModel.move(JavaModel.java:451) at org.eclipse.jdt.internal.core.PackageFragment.move (PackageFragment.java:264) at org.eclipse.jdt.internal.corext.refactoring.changes.MovePackageChange.doPerform (MovePackageChange.java:28) at org.eclipse.jdt.internal.corext.refactoring.changes.PackageReorgChange.perform (PackageReorgChange.java:40) at org.eclipse.jdt.internal.corext.refactoring.CompositeChange.createUndoList (CompositeChange.java:119) at org.eclipse.jdt.internal.corext.refactoring.CompositeChange.perform (CompositeChange.java:144) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation$1.execute (PerformChangeOperation.java:146) at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run (WorkspaceModifyOperation.java:64) at org.eclipse.core.internal.resources.Workspace.run (Workspace.java:1232) at org.eclipse.ui.actions.WorkspaceModifyOperation.run (WorkspaceModifyOperation.java:78) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation.executeChange (PerformChangeOperation.java:151) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation.run (PerformChangeOperation.java:125) at org.eclipse.jface.operation.ModalContext.runInCurrentThread (ModalContext.java:296) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:249) at org.eclipse.jface.dialogs.ProgressMonitorDialog.run (ProgressMonitorDialog.java:335) at org.eclipse.jdt.internal.ui.reorg.ReorgAction.perform (ReorgAction.java:82) at org.eclipse.jdt.internal.ui.reorg.ReorgDestinationAction.doReorg (ReorgDestinationAction.java:147) at org.eclipse.jdt.internal.ui.reorg.MoveAction.doReorg (MoveAction.java:195) at org.eclipse.jdt.internal.ui.reorg.ReorgDestinationAction.run (ReorgDestinationAction.java:108) at org.eclipse.jdt.internal.ui.reorg.MoveAction.run(MoveAction.java:186) at org.eclipse.jdt.internal.ui.packageview.SelectionTransferDropAdapter.handleDropM ove(SelectionTransferDropAdapter.java:153) at org.eclipse.jdt.internal.ui.packageview.SelectionTransferDropAdapter.drop (SelectionTransferDropAdapter.java:109) at org.eclipse.jdt.internal.ui.dnd.JdtViewerDropAdapter.drop (JdtViewerDropAdapter.java:107) at org.eclipse.jdt.internal.ui.dnd.DelegatingDropAdapter.drop (DelegatingDropAdapter.java:73) at org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:59) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.dnd.DropTarget.notifyListeners(DropTarget.java:514) at org.eclipse.swt.dnd.DropTarget.Drop(DropTarget.java:452) at org.eclipse.swt.dnd.DropTarget.access$7(DropTarget.java:380) at org.eclipse.swt.dnd.DropTarget$4.method6(DropTarget.java:180) at org.eclipse.swt.internal.ole.win32.COMObject.callback6 (COMObject.java:109) at org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native Method) at org.eclipse.swt.dnd.DragSource.drag(DragSource.java:248) at org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:229) at org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:119) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Tree.WM_LBUTTONDOWN(Tree.java:1504) at org.eclipse.swt.widgets.Control.windowProc(Control.java(Compiled Code)) at org.eclipse.swt.widgets.Display.windowProc(Display.java(Compiled Code)) at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method) at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
6710402
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-23T18:00:02Z"
"2002-01-22T17:20:00Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/reorg/ReorgRefactoring.java
8,280
Bug 8280 Package view back/forward/up arrow hover help
Start up Eclipse with some existing Java Projects in the workspace. Select a package in one of these projects. Right-click and select Go Into. Hover over the Back arrow. Notice that a very tall tool-tip (full screen height) text appears, the first line being "Back to Java Model" and the remaining lines being package names (?). Immediately after being displayed, the tool-tip text disappears. The text will flash into and out of existance consitently until the pointer leaves the button's frame. The same behaviour can occur when hovering over the Up arrow or the Forward arrow when these lead to the workspace root.
verified fixed
6b99f94
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T10:59:22Z"
"2002-01-23T21:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/packageview/PackageExplorerLabelProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.packageview; import org.eclipse.core.resources.IStorage; import org.eclipse.swt.graphics.Image; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.jdt.internal.ui.preferences.WorkInProgressPreferencePage; import org.eclipse.jdt.internal.ui.viewsupport.ErrorTickImageProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.StorageLabelProvider; /** * Standard label provider for Java elements used by the PackageExplorerPart * Use this class when you want to present the Java elements in a viewer. * <p> * The implementation also handles non-Java elements by forwarding the requests to an * internal <code>WorkbenchLabelProvider</code>. * </p> * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @see org.eclipse.ui.model.WorkbenchLabelProvider */ class PackageExplorerLabelProvider extends LabelProvider { private JavaElementImageProvider fImageLabelProvider; private StorageLabelProvider fStorageLabelProvider; private int fImageFlags; private int fTextFlags; /** * Create new JavaElementLabelProvider for the PackageExplorerPart */ public PackageExplorerLabelProvider() { fStorageLabelProvider= new StorageLabelProvider(); fImageLabelProvider= new ErrorTickImageProvider(); fImageFlags= JavaElementImageProvider.OVERLAY_ICONS | JavaElementImageProvider.SMALL_ICONS; fTextFlags= JavaElementLabels.ROOT_VARIABLE | JavaElementLabels.M_PARAMETER_TYPES; if (WorkInProgressPreferencePage.isCompressingPkgNameInPackagesView()) fTextFlags |= JavaElementLabels.P_COMPRESSED; } void setCompressingPkgNameInPackagesView(boolean state) { if (state) fTextFlags |= JavaElementLabels.P_COMPRESSED; else fTextFlags &= ~JavaElementLabels.P_COMPRESSED; } /* (non-Javadoc) * @see ILabelProvider#getImage */ public Image getImage(Object element) { Image result= fImageLabelProvider.getImageLabel(element, fImageFlags); if (result != null) { return result; } if (element instanceof IStorage) return fStorageLabelProvider.getImage(element); return super.getImage(element); } /* (non-Javadoc) * @see ILabelProvider#getText */ public String getText(Object element) { String text= JavaElementLabels.getTextLabel(element, fTextFlags); if (text.length() > 0) { return text; } if (element instanceof IStorage) return fStorageLabelProvider.getText(element); return super.getText(element); } /* (non-Javadoc) * * @see IBaseLabelProvider#dispose */ public void dispose() { fStorageLabelProvider.dispose(); fImageLabelProvider.dispose(); } }
8,280
Bug 8280 Package view back/forward/up arrow hover help
Start up Eclipse with some existing Java Projects in the workspace. Select a package in one of these projects. Right-click and select Go Into. Hover over the Back arrow. Notice that a very tall tool-tip (full screen height) text appears, the first line being "Back to Java Model" and the remaining lines being package names (?). Immediately after being displayed, the tool-tip text disappears. The text will flash into and out of existance consitently until the pointer leaves the button's frame. The same behaviour can occur when hovering over the Up arrow or the Forward arrow when these lead to the workspace root.
verified fixed
6b99f94
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T10:59:22Z"
"2002-01-23T21:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaUILabelProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.viewsupport; import org.eclipse.core.resources.IStorage; import org.eclipse.swt.graphics.Image; import org.eclipse.jface.viewers.LabelProvider; public class JavaUILabelProvider extends LabelProvider { private JavaElementImageProvider fImageLabelProvider; private StorageLabelProvider fStorageLabelProvider; private int fImageFlags; private int fTextFlags; /** * Creates a new label provider with default flags. */ public JavaUILabelProvider() { this(JavaElementLabels.M_PARAMETER_TYPES, JavaElementImageProvider.OVERLAY_ICONS); } public JavaUILabelProvider(int textFlags, int imageFlags, JavaElementImageProvider imageLabelProvider) { fImageLabelProvider= imageLabelProvider; fStorageLabelProvider= new StorageLabelProvider(); fImageFlags= imageFlags; fTextFlags= textFlags; } public JavaUILabelProvider(int textFlags, int imageFlags) { this(textFlags, imageFlags, new JavaElementImageProvider()); } public JavaUILabelProvider(JavaElementImageProvider imageLabelProvider) { this(JavaElementLabels.M_PARAMETER_TYPES, JavaElementImageProvider.OVERLAY_ICONS, imageLabelProvider); } /** * Sets the text flags to use */ public void setTextFlags(int flags) { fTextFlags= flags; } /** * Sets the text flags to use */ public void setImageFlags(int flags) { fImageFlags= flags; } /* (non-Javadoc) * @see ILabelProvider#getImage */ public Image getImage(Object element) { Image result= fImageLabelProvider.getImageLabel(element, fImageFlags); if (result != null) { return result; } if (element instanceof IStorage) return fStorageLabelProvider.getImage(element); return super.getImage(element); } /* (non-Javadoc) * @see ILabelProvider#getText */ public String getText(Object element) { String text= JavaElementLabels.getTextLabel(element, fTextFlags); if (text.length() > 0) { return text; } if (element instanceof IStorage) return fStorageLabelProvider.getText(element); return super.getText(element); } /* (non-Javadoc) * * @see IBaseLabelProvider#dispose */ public void dispose() { fStorageLabelProvider.dispose(); fImageLabelProvider.dispose(); } }
8,280
Bug 8280 Package view back/forward/up arrow hover help
Start up Eclipse with some existing Java Projects in the workspace. Select a package in one of these projects. Right-click and select Go Into. Hover over the Back arrow. Notice that a very tall tool-tip (full screen height) text appears, the first line being "Back to Java Model" and the remaining lines being package names (?). Immediately after being displayed, the tool-tip text disappears. The text will flash into and out of existance consitently until the pointer leaves the button's frame. The same behaviour can occur when hovering over the Up arrow or the Forward arrow when these lead to the workspace root.
verified fixed
6b99f94
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T10:59:22Z"
"2002-01-23T21:06:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/JavaElementLabelProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.ui; import org.eclipse.core.resources.IStorage; import org.eclipse.swt.graphics.Image; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.StorageLabelProvider; /** * Standard label provider for Java elements. * Use this class when you want to present the Java elements in a viewer. * <p> * The implementation also handles non-Java elements by forwarding the requests to an * internal <code>WorkbenchLabelProvider</code>. * </p> * <p> * This class may be instantiated; it is not intended to be subclassed. * </p> * * @see org.eclipse.ui.model.WorkbenchLabelProvider */ public class JavaElementLabelProvider extends LabelProvider { /** * Flag (bit mask) indicating that methods labels include the method return type. (prepended) */ public final static int SHOW_RETURN_TYPE= 0x001; /** * Flag (bit mask) indicating that method label include method parameter types. */ public final static int SHOW_PARAMETERS= 0x002; /** * Flag (bit mask) indicating that the label of a member should include the container. * For example, include the name of the type enclosing a field. * @deprecated Use SHOW_QUALIFIED or SHOW_ROOT instead */ public final static int SHOW_CONTAINER= 0x004; /** * Flag (bit mask) indicating that the label of a type should be fully qualified. * For example, include the fully qualified name of the type enclosing a type. * @deprecated Use SHOW_QUALIFIED instead */ public final static int SHOW_CONTAINER_QUALIFICATION= 0x008; /** * Flag (bit mask) indicating that the label should include overlay icons * for element type and modifiers. */ public final static int SHOW_OVERLAY_ICONS= 0x010; /** * Flag (bit mask) indicating thata field label should include the declared type. */ public final static int SHOW_TYPE= 0x020; /** * Flag (bit mask) indicating that the label should include the name of the * package fragment root (appended). */ public final static int SHOW_ROOT= 0x040; /** * Flag (bit mask) indicating that the label qualification of a type should * be shown after the name. * @deprecated SHOW_POST_QUALIFIED instead */ public final static int SHOW_POSTIFIX_QUALIFICATION= 0x080; /** * Flag (bit mask) indicating that the label should show the icons with no space * reserved for overlays. */ public final static int SHOW_SMALL_ICONS= 0x100; /** * Flag (bit mask) indicating that the packagefragment roots from variables should * be rendered with the variable in the name */ public final static int SHOW_VARIABLE= 0x200; /** * Flag (bit mask) indicating that Complation Units, Class Files, Types, Declarations and Members * should be rendered qualified. * Examples: java.lang.String, java.util.Vector.size() */ public final static int SHOW_QUALIFIED= 0x400; /** * Flag (bit mask) indicating that Complation Units, Class Files, Types, Declarations and Members * should be rendered qualified. The qualifcation is appended * Examples: String - java.lang, size() - java.util.Vector */ public final static int SHOW_POST_QUALIFIED= 0x800; /** * Constant (value <code>0</code>) indicating that the label should show * the basic images only. */ public final static int SHOW_BASICS= 0x000; /** * Constant indicating the default label rendering. * Currently the default is equivalent to * <code>SHOW_PARAMETERS | SHOW_OVERLAY_ICONS</code>. */ public final static int SHOW_DEFAULT= new Integer(SHOW_PARAMETERS | SHOW_OVERLAY_ICONS).intValue(); private JavaElementImageProvider fImageLabelProvider; private StorageLabelProvider fStorageLabelProvider; private int fFlags; private int fImageFlags; private int fTextFlags; /** * Creates a new label provider with <code>SHOW_DEFAULT</code> flag. * * @see #SHOW_DEFAULT * @since 2.0 */ public JavaElementLabelProvider() { this(SHOW_DEFAULT); } /** * Creates a new label provider. * * @param flags the initial options; a bitwise OR of <code>SHOW_* </code> constants */ public JavaElementLabelProvider(int flags) { fImageLabelProvider= new JavaElementImageProvider(); fStorageLabelProvider= new StorageLabelProvider(); fFlags= flags; updateImageProviderFlags(); updateTextProviderFlags(); } private boolean getFlag( int flag) { return (fFlags & flag) != 0; } /** * Turns on the rendering options specified in the given flags. * * @param flags the options; a bitwise OR of <code>SHOW_* </code> constants */ public void turnOn(int flags) { fFlags |= flags; updateImageProviderFlags(); updateTextProviderFlags(); } /** * Turns off the rendering options specified in the given flags. * * @param flags the initial options; a bitwise OR of <code>SHOW_* </code> constants */ public void turnOff(int flags) { fFlags &= (~flags); updateImageProviderFlags(); updateTextProviderFlags(); } private void updateImageProviderFlags() { fImageFlags= 0; if (getFlag(SHOW_OVERLAY_ICONS)) { fImageFlags |= JavaElementImageProvider.OVERLAY_ICONS; } if (getFlag(SHOW_SMALL_ICONS)) { fImageFlags |= JavaElementImageProvider.SMALL_ICONS; } } private void updateTextProviderFlags() { fTextFlags= 0; if (getFlag(SHOW_RETURN_TYPE)) { fTextFlags |= JavaElementLabels.M_PRE_RETURNTYPE; } if (getFlag(SHOW_PARAMETERS)) { fTextFlags |= JavaElementLabels.M_PARAMETER_TYPES; } if (getFlag(SHOW_CONTAINER)) { fTextFlags |= JavaElementLabels.P_POST_QUALIFIED | JavaElementLabels.T_POST_QUALIFIED | JavaElementLabels.CF_POST_QUALIFIED | JavaElementLabels.CU_POST_QUALIFIED | JavaElementLabels.M_POST_QUALIFIED | JavaElementLabels.F_POST_QUALIFIED; } if (getFlag(SHOW_POSTIFIX_QUALIFICATION)) { fTextFlags |= (JavaElementLabels.T_POST_QUALIFIED | JavaElementLabels.CF_POST_QUALIFIED | JavaElementLabels.CU_POST_QUALIFIED); } else if (getFlag(SHOW_CONTAINER_QUALIFICATION)) { fTextFlags |=(JavaElementLabels.T_FULLY_QUALIFIED | JavaElementLabels.CF_QUALIFIED | JavaElementLabels.CU_QUALIFIED); } if (getFlag(SHOW_TYPE)) { fTextFlags |= JavaElementLabels.F_APP_TYPE_SIGNATURE; } if (getFlag(SHOW_ROOT)) { fTextFlags |= JavaElementLabels.APPEND_ROOT_PATH; } if (getFlag(SHOW_VARIABLE)) { fTextFlags |= JavaElementLabels.ROOT_VARIABLE; } if (getFlag(SHOW_QUALIFIED)) { fTextFlags |= (JavaElementLabels.F_FULLY_QUALIFIED | JavaElementLabels.M_FULLY_QUALIFIED | JavaElementLabels.I_FULLY_QUALIFIED | JavaElementLabels.T_FULLY_QUALIFIED | JavaElementLabels.D_QUALIFIED | JavaElementLabels.CF_QUALIFIED | JavaElementLabels.CU_QUALIFIED); } if (getFlag(SHOW_POST_QUALIFIED)) { fTextFlags |= (JavaElementLabels.F_POST_QUALIFIED | JavaElementLabels.M_POST_QUALIFIED | JavaElementLabels.I_POST_QUALIFIED | JavaElementLabels.T_POST_QUALIFIED | JavaElementLabels.D_POST_QUALIFIED | JavaElementLabels.CF_POST_QUALIFIED | JavaElementLabels.CU_POST_QUALIFIED); } } /* (non-Javadoc) * @see ILabelProvider#getImage */ public Image getImage(Object element) { Image result= fImageLabelProvider.getImageLabel(element, fImageFlags); if (result != null) { return result; } if (element instanceof IStorage) return fStorageLabelProvider.getImage(element); return super.getImage(element); } /* (non-Javadoc) * @see ILabelProvider#getText */ public String getText(Object element) { String text= JavaElementLabels.getTextLabel(element, fTextFlags); if (text.length() > 0) { return text; } if (element instanceof IStorage) return fStorageLabelProvider.getText(element); return super.getText(element); } /* (non-Javadoc) * * @see IBaseLabelProvider#dispose */ public void dispose() { fStorageLabelProvider.dispose(); fImageLabelProvider.dispose(); } }
8,085
Bug 8085 template pref page: exception while importing incorrect file
i tried to import this: <?xml version="1.0" encoding="UTF-8"?> <templatfes><template context="javadoc" description="author name" enabled="true" name="@author">@author ${user}</template></templates> which has an error i got an error dialog and this: 4 org.eclipse.jdt.ui 1 Internal Error org.eclipse.jdt.internal.ui.JavaUIException[2]: org.xml.sax.SAXParseException: The element type "templatfes" must be terminated by the matching end- tag "</templatfes>". at org.apache.xerces.framework.XMLParser.reportError (XMLParser.java:1196) at org.apache.xerces.framework.XMLDocumentScanner.reportFatalXMLError (XMLDocumentScanner.java:579) at org.apache.xerces.framework.XMLDocumentScanner$ContentDispatcher.dispatch (XMLDocumentScanner.java(Compiled Code)) at org.apache.xerces.framework.XMLDocumentScanner$ContentDispatcher.dispatch (XMLDocumentScanner.java(Compiled Code)) at org.apache.xerces.framework.XMLDocumentScanner.parseSome (XMLDocumentScanner.java(Compiled Code)) at org.apache.xerces.framework.XMLParser.parse(XMLParser.java:1081) at org.apache.xerces.jaxp.DocumentBuilderImpl.parse (DocumentBuilderImpl.java:195) at org.eclipse.jdt.internal.ui.text.template.TemplateSet.addFromStream (TemplateSet.java:103) at org.eclipse.jdt.internal.ui.text.template.TemplateSet.addFromFile (TemplateSet.java:83) at org.eclipse.jdt.internal.ui.preferences.TemplatePreferencePage.import_ (TemplatePreferencePage.java:389) at org.eclipse.jdt.internal.ui.preferences.TemplatePreferencePage.access$4 (TemplatePreferencePage.java:379) at org.eclipse.jdt.internal.ui.preferences.TemplatePreferencePage$8.handleEvent (TemplatePreferencePage.java:212) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.ui.internal.OpenPreferencesAction.run (OpenPreferencesAction.java:47) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362)
verified fixed
c333a9d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T11:05:15Z"
"2002-01-23T12:46:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/TemplatePreferencePage.java
package org.eclipse.jdt.internal.ui.preferences; import java.io.File; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Font; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Event; import org.eclipse.swt.widgets.FileDialog; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Listener; import org.eclipse.swt.widgets.Table; import org.eclipse.swt.widgets.TableColumn; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.resource.JFaceResources; import org.eclipse.jface.text.Document; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTableViewer; import org.eclipse.jface.viewers.ColumnWeightData; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.TableLayout; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.text.template.Template; import org.eclipse.jdt.internal.ui.text.template.TemplateContentProvider; import org.eclipse.jdt.internal.ui.text.template.TemplateContext; import org.eclipse.jdt.internal.ui.text.template.TemplateLabelProvider; import org.eclipse.jdt.internal.ui.text.template.TemplateMessages; import org.eclipse.jdt.internal.ui.text.template.TemplateSet; import org.eclipse.jdt.internal.ui.text.template.Templates; import org.eclipse.jdt.internal.ui.util.SWTUtil; public class TemplatePreferencePage extends PreferencePage implements IWorkbenchPreferencePage { // preference store keys private static final String PREF_FORMAT_TEMPLATES= JavaUI.ID_PLUGIN + ".template.format"; //$NON-NLS-1$ private Templates fTemplates; private CheckboxTableViewer fTableViewer; private Button fAddButton; private Button fEditButton; private Button fImportButton; private Button fExportButton; private Button fExportAllButton; private Button fRemoveButton; private Button fEnableAllButton; private Button fDisableAllButton; private SourceViewer fPatternViewer; private Button fFormatButton; public TemplatePreferencePage() { super(); setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(TemplateMessages.getString("TemplatePreferencePage.message")); //$NON-NLS-1$ fTemplates= Templates.getInstance(); } /** * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite ancestor) { Composite parent= new Composite(ancestor, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.marginHeight= 0; layout.marginWidth= 0; parent.setLayout(layout); Table table= new Table(parent, SWT.CHECK | SWT.BORDER | SWT.MULTI | SWT.FULL_SELECTION); GridData data= new GridData(GridData.FILL_BOTH); data.widthHint= convertWidthInCharsToPixels(80); data.heightHint= convertHeightInCharsToPixels(10); table.setLayoutData(data); table.setHeaderVisible(true); table.setLinesVisible(true); TableLayout tableLayout= new TableLayout(); table.setLayout(tableLayout); TableColumn column1= new TableColumn(table, SWT.NONE); column1.setText(TemplateMessages.getString("TemplatePreferencePage.column.name")); //$NON-NLS-1$ TableColumn column2= new TableColumn(table, SWT.NONE); column2.setText(TemplateMessages.getString("TemplatePreferencePage.column.context")); //$NON-NLS-1$ TableColumn column3= new TableColumn(table, SWT.NONE); column3.setText(TemplateMessages.getString("TemplatePreferencePage.column.description")); //$NON-NLS-1$ tableLayout.addColumnData(new ColumnWeightData(30)); tableLayout.addColumnData(new ColumnWeightData(20)); tableLayout.addColumnData(new ColumnWeightData(70)); fTableViewer= new CheckboxTableViewer(table); fTableViewer.setLabelProvider(new TemplateLabelProvider()); fTableViewer.setContentProvider(new TemplateContentProvider()); fTableViewer.setSorter(new ViewerSorter() { public int compare(Viewer viewer, Object object1, Object object2) { if ((object1 instanceof Template) && (object2 instanceof Template)) { Template left= (Template) object1; Template right= (Template) object2; int result= left.getName().compareToIgnoreCase(right.getName()); if (result != 0) return result; return left.getDescription().compareToIgnoreCase(right.getDescription()); } return super.compare(viewer, object1, object2); } public boolean isSorterProperty(Object element, String property) { return true; } }); fTableViewer.addDoubleClickListener(new IDoubleClickListener() { public void doubleClick(DoubleClickEvent e) { edit(); } }); fTableViewer.addSelectionChangedListener(new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent e) { selectionChanged1(); } }); fTableViewer.addCheckStateListener(new ICheckStateListener() { public void checkStateChanged(CheckStateChangedEvent event) { Template template= (Template) event.getElement(); template.setEnabled(event.getChecked()); } }); Composite buttons= new Composite(parent, SWT.NULL); buttons.setLayoutData(new GridData(GridData.VERTICAL_ALIGN_BEGINNING)); layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; buttons.setLayout(layout); fAddButton= new Button(buttons, SWT.PUSH); fAddButton.setLayoutData(getButtonGridData(fAddButton)); fAddButton.setText(TemplateMessages.getString("TemplatePreferencePage.new")); //$NON-NLS-1$ fAddButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { add(); } }); fEditButton= new Button(buttons, SWT.PUSH); fEditButton.setLayoutData(getButtonGridData(fEditButton)); fEditButton.setText(TemplateMessages.getString("TemplatePreferencePage.edit")); //$NON-NLS-1$ fEditButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { edit(); } }); fRemoveButton= new Button(buttons, SWT.PUSH); fRemoveButton.setLayoutData(getButtonGridData(fRemoveButton)); fRemoveButton.setText(TemplateMessages.getString("TemplatePreferencePage.remove")); //$NON-NLS-1$ fRemoveButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { remove(); } }); createSpacer(buttons); fImportButton= new Button(buttons, SWT.PUSH); fImportButton.setLayoutData(getButtonGridData(fImportButton)); fImportButton.setText(TemplateMessages.getString("TemplatePreferencePage.import")); //$NON-NLS-1$ fImportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { import_(); } }); fExportButton= new Button(buttons, SWT.PUSH); fExportButton.setLayoutData(getButtonGridData(fExportButton)); fExportButton.setText(TemplateMessages.getString("TemplatePreferencePage.export")); //$NON-NLS-1$ fExportButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { export(); } }); fExportAllButton= new Button(buttons, SWT.PUSH); fExportAllButton.setLayoutData(getButtonGridData(fExportAllButton)); fExportAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.export.all")); //$NON-NLS-1$ fExportAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { exportAll(); } }); createSpacer(buttons); fEnableAllButton= new Button(buttons, SWT.PUSH); fEnableAllButton.setLayoutData(getButtonGridData(fEnableAllButton)); fEnableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.enable.all")); //$NON-NLS-1$ fEnableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(true); } }); fDisableAllButton= new Button(buttons, SWT.PUSH); fDisableAllButton.setLayoutData(getButtonGridData(fDisableAllButton)); fDisableAllButton.setText(TemplateMessages.getString("TemplatePreferencePage.disable.all")); //$NON-NLS-1$ fDisableAllButton.addListener(SWT.Selection, new Listener() { public void handleEvent(Event e) { enableAll(false); } }); fPatternViewer= createViewer(parent); createSpacer(parent); fFormatButton= new Button(parent, SWT.CHECK); fFormatButton.setText(TemplateMessages.getString("TemplatePreferencePage.use.code.formatter")); //$NON-NLS-1$ fTableViewer.setInput(fTemplates); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getBoolean(PREF_FORMAT_TEMPLATES)); updateButtons(); WorkbenchHelp.setHelp(parent, new DialogPageContextComputer(this, IJavaHelpContextIds.TEMPLATE_PREFERENCE_PAGE)); return parent; } private Template[] getEnabledTemplates() { Template[] templates= fTemplates.getTemplates(); List list= new ArrayList(templates.length); for (int i= 0; i != templates.length; i++) if (templates[i].isEnabled()) list.add(templates[i]); return (Template[]) list.toArray(new Template[list.size()]); } private SourceViewer createViewer(Composite parent) { SourceViewer viewer= new SourceViewer(parent, null, SWT.BORDER | SWT.V_SCROLL | SWT.H_SCROLL); JavaTextTools tools= JavaPlugin.getDefault().getJavaTextTools(); viewer.configure(new JavaSourceViewerConfiguration(tools, null)); viewer.setEditable(false); viewer.setDocument(new Document()); Font font= JFaceResources.getFontRegistry().get(JFaceResources.TEXT_FONT); viewer.getTextWidget().setFont(font); Control control= viewer.getControl(); GridData data= new GridData(GridData.FILL_BOTH); data.heightHint= convertHeightInCharsToPixels(5); control.setLayoutData(data); return viewer; } public void createSpacer(Composite parent) { Label spacer= new Label(parent, SWT.NONE); GridData data= new GridData(); data.horizontalAlignment= GridData.FILL; data.verticalAlignment= GridData.BEGINNING; data.heightHint= 4; spacer.setLayoutData(data); } private static GridData getButtonGridData(Button button) { GridData data= new GridData(GridData.FILL_HORIZONTAL); data.widthHint= SWTUtil.getButtonWidthHint(button); data.heightHint= SWTUtil.getButtonHeigthHint(button); return data; } private void selectionChanged1() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); if (selection.size() == 1) { Template template= (Template) selection.getFirstElement(); fPatternViewer.getTextWidget().setText(template.getPattern()); } else { fPatternViewer.getTextWidget().setText(""); //$NON-NLS-1$ } updateButtons(); } private void updateButtons() { int selectionCount= ((IStructuredSelection) fTableViewer.getSelection()).size(); int itemCount= fTableViewer.getTable().getItemCount(); fEditButton.setEnabled(selectionCount == 1); fExportButton.setEnabled(selectionCount > 0); fRemoveButton.setEnabled(selectionCount > 0 && selectionCount <= itemCount); fEnableAllButton.setEnabled(itemCount > 0); fDisableAllButton.setEnabled(itemCount > 0); } private void add() { Template template= new Template(); template.setContext(TemplateContext.JAVA); //$NON-NLS-1$ EditTemplateDialog dialog= new EditTemplateDialog(getShell(), template, false); if (dialog.open() == dialog.OK) { fTemplates.add(template); fTableViewer.refresh(); fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void edit() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] objects= selection.toArray(); if ((objects == null) || (objects.length != 1)) return; Template template= (Template) selection.getFirstElement(); edit(template); } private void edit(Template template) { EditTemplateDialog dialog= new EditTemplateDialog(getShell(), template, true); if (dialog.open() == dialog.OK) { fTableViewer.refresh(template); fTableViewer.setChecked(template, template.isEnabled()); fTableViewer.setSelection(new StructuredSelection(template)); } } private void import_() { FileDialog dialog= new FileDialog(getShell()); dialog.setText(TemplateMessages.getString("TemplatePreferencePage.import.title")); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.import.extension")}); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; try { fTemplates.addFromFile(new File(path)); fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } } private void exportAll() { export(fTemplates); } private void export() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Object[] templates= selection.toArray(); TemplateSet templateSet= new TemplateSet(); for (int i= 0; i != templates.length; i++) templateSet.add((Template) templates[i]); export(templateSet); } private void export(TemplateSet templateSet) { FileDialog dialog= new FileDialog(getShell(), SWT.SAVE); dialog.setText(TemplateMessages.getFormattedString("TemplatePreferencePage.export.title", new Integer(templateSet.getTemplates().length))); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] {TemplateMessages.getString("TemplatePreferencePage.export.extension")}); //$NON-NLS-1$ dialog.setFileName(TemplateMessages.getString("TemplatePreferencePage.export.filename")); //$NON-NLS-1$ String path= dialog.open(); if (path == null) return; try { templateSet.saveToFile(new File(path)); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } } private void remove() { IStructuredSelection selection= (IStructuredSelection) fTableViewer.getSelection(); Iterator elements= selection.iterator(); while (elements.hasNext()) { Template template= (Template) elements.next(); fTemplates.remove(template); } fTableViewer.refresh(); } private void enableAll(boolean enable) { Template[] templates= fTemplates.getTemplates(); for (int i= 0; i != templates.length; i++) templates[i].setEnabled(enable); fTableViewer.setAllChecked(enable); } /* * @see IWorkbenchPreferencePage#init(IWorkbench) */ public void init(IWorkbench workbench) {} /* * @see Control#setVisible(boolean) */ public void setVisible(boolean visible) { super.setVisible(visible); if (visible) setTitle(TemplateMessages.getString("TemplatePreferencePage.title")); //$NON-NLS-1$ } /* * @see PreferencePage#performDefaults() */ protected void performDefaults() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); fFormatButton.setSelection(prefs.getDefaultBoolean(PREF_FORMAT_TEMPLATES)); try { fTemplates.restoreDefaults(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } // refresh fTableViewer.refresh(); fTableViewer.setAllChecked(false); fTableViewer.setCheckedElements(getEnabledTemplates()); } /* * @see PreferencePage#performOk() */ public boolean performOk() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); prefs.setValue(PREF_FORMAT_TEMPLATES, fFormatButton.getSelection()); try { fTemplates.save(); } catch (CoreException e) { JavaPlugin.log(e); openWriteErrorDialog(e); } return super.performOk(); } /* * @see PreferencePage#performCancel() */ public boolean performCancel() { try { fTemplates.reset(); } catch (CoreException e) { JavaPlugin.log(e); openReadErrorDialog(e); } return super.performCancel(); } /** * Initializes the default values of this page in the preference bundle. * Will be called on startup of the JavaPlugin */ public static void initDefaults(IPreferenceStore prefs) { prefs.setDefault(PREF_FORMAT_TEMPLATES, true); } public static boolean useCodeFormatter() { IPreferenceStore prefs= JavaPlugin.getDefault().getPreferenceStore(); return prefs.getBoolean(PREF_FORMAT_TEMPLATES); } private void openReadErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.read.title"), //$NON-NLS-1$ e.getMessage(), e.getStatus()); } private void openWriteErrorDialog(CoreException e) { ErrorDialog.openError(getShell(), TemplateMessages.getString("TemplatePreferencePage.error.write.title"), //$NON-NLS-1$ e.getMessage(), e.getStatus()); } }
8,085
Bug 8085 template pref page: exception while importing incorrect file
i tried to import this: <?xml version="1.0" encoding="UTF-8"?> <templatfes><template context="javadoc" description="author name" enabled="true" name="@author">@author ${user}</template></templates> which has an error i got an error dialog and this: 4 org.eclipse.jdt.ui 1 Internal Error org.eclipse.jdt.internal.ui.JavaUIException[2]: org.xml.sax.SAXParseException: The element type "templatfes" must be terminated by the matching end- tag "</templatfes>". at org.apache.xerces.framework.XMLParser.reportError (XMLParser.java:1196) at org.apache.xerces.framework.XMLDocumentScanner.reportFatalXMLError (XMLDocumentScanner.java:579) at org.apache.xerces.framework.XMLDocumentScanner$ContentDispatcher.dispatch (XMLDocumentScanner.java(Compiled Code)) at org.apache.xerces.framework.XMLDocumentScanner$ContentDispatcher.dispatch (XMLDocumentScanner.java(Compiled Code)) at org.apache.xerces.framework.XMLDocumentScanner.parseSome (XMLDocumentScanner.java(Compiled Code)) at org.apache.xerces.framework.XMLParser.parse(XMLParser.java:1081) at org.apache.xerces.jaxp.DocumentBuilderImpl.parse (DocumentBuilderImpl.java:195) at org.eclipse.jdt.internal.ui.text.template.TemplateSet.addFromStream (TemplateSet.java:103) at org.eclipse.jdt.internal.ui.text.template.TemplateSet.addFromFile (TemplateSet.java:83) at org.eclipse.jdt.internal.ui.preferences.TemplatePreferencePage.import_ (TemplatePreferencePage.java:389) at org.eclipse.jdt.internal.ui.preferences.TemplatePreferencePage.access$4 (TemplatePreferencePage.java:379) at org.eclipse.jdt.internal.ui.preferences.TemplatePreferencePage$8.handleEvent (TemplatePreferencePage.java:212) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.ui.internal.OpenPreferencesAction.run (OpenPreferencesAction.java:47) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362)
verified fixed
c333a9d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T11:05:15Z"
"2002-01-23T12:46:40Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateSet.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.text.template; import java.io.File; import java.io.FileInputStream; import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; import java.util.ArrayList; import java.util.Arrays; import java.util.Comparator; import java.util.Iterator; import java.util.List; import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.parsers.ParserConfigurationException; import org.apache.xml.serialize.OutputFormat; import org.apache.xml.serialize.Serializer; import org.apache.xml.serialize.SerializerFactory; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IStatus; import org.w3c.dom.Attr; import org.w3c.dom.Document; import org.w3c.dom.NamedNodeMap; import org.w3c.dom.Node; import org.w3c.dom.NodeList; import org.w3c.dom.Text; import org.xml.sax.InputSource; import org.xml.sax.SAXException; import org.eclipse.jdt.internal.ui.JavaStatusConstants; import org.eclipse.jdt.internal.ui.JavaUIErrorStatus; import org.eclipse.jdt.internal.ui.JavaUIException; /** * <code>TemplateSet</code> manages a collection of templates and makes them * persistent. */ public class TemplateSet { private static class TemplateComparator implements Comparator { public int compare(Object arg0, Object arg1) { if (arg0 == arg1) return 0; if (arg0 == null) return -1; Template template0= (Template) arg0; Template template1= (Template) arg1; return template0.getName().compareTo(template1.getName()); } } private static final String TEMPLATE_TAG= "template"; //$NON-NLS-1$ private static final String NAME_ATTRIBUTE= "name"; //$NON-NLS-1$ private static final String DESCRIPTION_ATTRIBUTE= "description"; //$NON-NLS-1$ private static final String CONTEXT_ATTRIBUTE= "context"; //$NON-NLS-1$ private static final String ENABLED_ATTRIBUTE= "enabled"; //$NON-NLS-1$ private List fTemplates= new ArrayList(); private Comparator fTemplateComparator= new TemplateComparator(); private Template[] fSortedTemplates= new Template[0]; /** * Convenience method for reading templates from a file. * * @see addFromStream(InputStream) */ public void addFromFile(File file) throws CoreException { InputStream stream= null; try { stream= new FileInputStream(file); addFromStream(stream); } catch (IOException e) { throwReadException(e); } finally { try { if (stream != null) stream.close(); } catch (IOException e) {} } } /** * Reads templates from a XML stream and adds them to the template set. */ public void addFromStream(InputStream stream) throws CoreException { try { DocumentBuilderFactory factory= DocumentBuilderFactory.newInstance(); DocumentBuilder parser= factory.newDocumentBuilder(); Document document= parser.parse(new InputSource(stream)); NodeList elements= document.getElementsByTagName(TEMPLATE_TAG); int count= elements.getLength(); for (int i= 0; i != count; i++) { Node node= elements.item(i); NamedNodeMap attributes= node.getAttributes(); if (attributes == null) continue; String name= attributes.getNamedItem(NAME_ATTRIBUTE).getNodeValue(); String description= attributes.getNamedItem(DESCRIPTION_ATTRIBUTE).getNodeValue(); String context= attributes.getNamedItem(CONTEXT_ATTRIBUTE).getNodeValue(); Node enabledNode= attributes.getNamedItem(ENABLED_ATTRIBUTE); boolean enabled= (enabledNode == null) || (enabledNode.getNodeValue().equals("true")); //$NON-NLS-1$ StringBuffer buffer= new StringBuffer(); NodeList children= node.getChildNodes(); for (int j= 0; j != children.getLength(); j++) { String value= children.item(j).getNodeValue(); if (value != null) buffer.append(value); } String pattern= buffer.toString().trim(); Template template= new Template(name, description, context, pattern); template.setEnabled(enabled); add(template); } sort(); } catch (ParserConfigurationException e) { throwReadException(e); } catch (IOException e) { throwReadException(e); } catch (SAXException e) { throwReadException(e); } } /** * Convenience method for saving to a file. * * @see saveToStream(OutputStream) */ public void saveToFile(File file) throws CoreException { OutputStream stream= null; try { stream= new FileOutputStream(file); saveToStream(stream); } catch (IOException e) { throwWriteException(e); } finally { try { if (stream != null) stream.close(); } catch (IOException e) {} } } /** * Saves the template set as XML. */ public void saveToStream(OutputStream stream) throws CoreException { try { DocumentBuilderFactory factory= DocumentBuilderFactory.newInstance(); DocumentBuilder builder= factory.newDocumentBuilder(); Document document= builder.newDocument(); Node root= document.createElement("templates"); // $NON-NLS-1$ //$NON-NLS-1$ document.appendChild(root); for (int i= 0; i != fTemplates.size(); i++) { Template template= (Template) fTemplates.get(i); Node node= document.createElement("template"); // $NON-NLS-1$ //$NON-NLS-1$ root.appendChild(node); NamedNodeMap attributes= node.getAttributes(); Attr name= document.createAttribute(NAME_ATTRIBUTE); name.setValue(template.getName()); attributes.setNamedItem(name); Attr description= document.createAttribute(DESCRIPTION_ATTRIBUTE); description.setValue(template.getDescription()); attributes.setNamedItem(description); Attr context= document.createAttribute(CONTEXT_ATTRIBUTE); context.setValue(template.getContext()); attributes.setNamedItem(context); Attr enabled= document.createAttribute(ENABLED_ATTRIBUTE); enabled.setValue(template.isEnabled() ? "true" : "false"); //$NON-NLS-1$ //$NON-NLS-2$ attributes.setNamedItem(enabled); Text pattern= document.createTextNode(template.getPattern()); node.appendChild(pattern); } OutputFormat format = new OutputFormat(); format.setPreserveSpace(true); Serializer serializer = SerializerFactory.getSerializerFactory("xml").makeSerializer(stream, format); //$NON-NLS-1$ serializer.asDOMSerializer().serialize(document); } catch (ParserConfigurationException e) { throwWriteException(e); } catch (IOException e) { throwWriteException(e); } } private static void throwReadException(Throwable t) throws CoreException { IStatus status= new JavaUIErrorStatus(JavaStatusConstants.TEMPLATE_IO_EXCEPTION, TemplateMessages.getString("TemplateSet.error.read"), t); //$NON-NLS-1$ throw new JavaUIException(status); } private static void throwWriteException(Throwable t) throws CoreException { IStatus status= new JavaUIErrorStatus(JavaStatusConstants.TEMPLATE_IO_EXCEPTION, TemplateMessages.getString("TemplateSet.error.write"), t); //$NON-NLS-1$ throw new JavaUIException(status); } /** * Adds a template to the set. */ public void add(Template template) { if (exists(template)) return; // ignore duplicate fTemplates.add(template); sort(); } private boolean exists(Template template) { for (Iterator iterator = fTemplates.iterator(); iterator.hasNext();) { Template anotherTemplate = (Template) iterator.next(); if (template.equals(anotherTemplate)) return true; } return false; } /** * Removes a template to the set. */ public void remove(Template template) { fTemplates.remove(template); sort(); } /** * Empties the set. */ public void clear() { fTemplates.clear(); sort(); } /** * Returns all templates. */ public Template[] getTemplates() { return (Template[]) fTemplates.toArray(new Template[fTemplates.size()]); } /** * Returns templates matching a prefix. */ public Template[] getMatchingTemplates(TemplateContext context) { String prefix= context.getKey(); String type= context.getType(); List results= new ArrayList(fSortedTemplates.length); for (int i= 0; i != fSortedTemplates.length; i++) { Template template= fSortedTemplates[i]; if (template.matches(prefix, type)) results.add(template); } return (Template[]) results.toArray(new Template[results.size()]); } private void sort() { fSortedTemplates= (Template[]) fTemplates.toArray(new Template[fTemplates.size()]); Arrays.sort(fSortedTemplates, fTemplateComparator); } }
8,129
Bug 8129 NPE in Extract Local Variable
20122: 1. junit.swingui.ProgressBar: line 45, select ' value*(getBounds().width-1)' (note the leading space!) -> java.lang.NullPointerException at org.eclipse.jdt.internal.corext.refactoring.code.ExtractTempRefactoring.getSelec tedMethodNode(ExtractTempRefactoring.java:387) at org.eclipse.jdt.internal.corext.refactoring.code.ExtractTempRefactoring.checkSel ection(ExtractTempRefactoring.java:123) at org.eclipse.jdt.internal.corext.refactoring.code.ExtractTempRefactoring.checkAct ivation(ExtractTempRefactoring.java:113) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:79) at org.eclipse.jdt.internal.ui.refactoring.actions.TextSelectionBasedRefactoringAct ion.run(TextSelectionBasedRefactoringAction.java:28) at org.eclipse.jdt.internal.ui.refactoring.actions.TextSelectionAction.run (TextSelectionAction.java:80) at org.eclipse.ui.internal.PluginAction.runWithEvent (PluginAction.java:204) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
2a28b2d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T12:28:16Z"
"2002-01-23T15:33:20Z"
org.eclipse.jdt.ui/core
8,129
Bug 8129 NPE in Extract Local Variable
20122: 1. junit.swingui.ProgressBar: line 45, select ' value*(getBounds().width-1)' (note the leading space!) -> java.lang.NullPointerException at org.eclipse.jdt.internal.corext.refactoring.code.ExtractTempRefactoring.getSelec tedMethodNode(ExtractTempRefactoring.java:387) at org.eclipse.jdt.internal.corext.refactoring.code.ExtractTempRefactoring.checkSel ection(ExtractTempRefactoring.java:123) at org.eclipse.jdt.internal.corext.refactoring.code.ExtractTempRefactoring.checkAct ivation(ExtractTempRefactoring.java:113) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:79) at org.eclipse.jdt.internal.ui.refactoring.actions.TextSelectionBasedRefactoringAct ion.run(TextSelectionBasedRefactoringAction.java:28) at org.eclipse.jdt.internal.ui.refactoring.actions.TextSelectionAction.run (TextSelectionAction.java:80) at org.eclipse.ui.internal.PluginAction.runWithEvent (PluginAction.java:204) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java:361) at org.eclipse.jface.action.ActionContributionItem.access$0 (ActionContributionItem.java:352) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java:47) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
2a28b2d
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T12:28:16Z"
"2002-01-23T15:33:20Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/code/ExtractTempRefactoring.java
3,658
Bug 3658 JDT change listener efficiency issue (1GEMN5F)
ClassFileMarkerAnnotationModel.visit is very much less than optimal if fMarkerResource is set. It traverses the entire delta only looking for a particular resource! I don't understand when fMarkerResource is set and when it is not but in the case I saw, it was set to be a particular project resource which was not even in the list of resources which changed in the large delta I was processing. The net result of this was that the listener traversed the entire delta (~1500 resources) checking at each node to see if the node was equal to fMarkerResource. Since the listener knows that it is only interested in that one resource, it should just take the delta and look in it to see if the resource in question is there. The current IResourceDelta api is not optimal for doing this but it certainly can be done and would be very much more efficient than the current approach. We will look at adding the required API but this late in the game I would not hope for too much. NOTES: JBL (6/1/2001 11:47:09 AM) ClassFileMarkerAnnotationModel is JUI. Moving to ITPJUI. KUM (8/6/2001 4:41:57 PM) Sent mail to JMA regarding expected core support.
resolved fixed
f938ef0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:12:45Z"
"2001-10-11T03:13:20Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileMarkerAnnotationModel.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IMarkerDelta; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IResourceChangeEvent; import org.eclipse.core.resources.IResourceChangeListener; import org.eclipse.core.resources.IResourceDelta; import org.eclipse.core.resources.IResourceDeltaVisitor; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.CoreException; import org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.JavaCore; /** * */ public class ClassFileMarkerAnnotationModel extends AbstractMarkerAnnotationModel implements IResourceChangeListener, IResourceDeltaVisitor { protected IClassFile fClassFile; protected IWorkspace fWorkspace; protected IResource fMarkerResource; protected boolean fChangesApplied; public ClassFileMarkerAnnotationModel(IResource markerResource) { super(); fMarkerResource= markerResource; fWorkspace= fMarkerResource.getWorkspace(); } public void setClassFile(IClassFile classFile) { fClassFile= classFile; } /** * @see AbstractMarkerAnnotationModel#isAcceptable */ protected boolean isAcceptable(IMarker marker) { try { return JavaCore.getJavaCore().isReferencedBy(fClassFile, marker); } catch (CoreException x) { handleCoreException(x, JavaEditorMessages.getString("ClassFileMarkerAnnotationModel.error.isAcceptable")); //$NON-NLS-1$ return false; } } protected boolean isAffected(IMarkerDelta markerDelta) { try { return JavaCore.getJavaCore().isReferencedBy(fClassFile, markerDelta); } catch (CoreException x) { handleCoreException(x, JavaEditorMessages.getString("ClassFileMarkerAnnotationModel.error.isAffected")); //$NON-NLS-1$ return false; } } /** * @see AbstractMarkerAnnotationModel#createMarkerAnnotation(IMarker) */ protected MarkerAnnotation createMarkerAnnotation(IMarker marker) { return new JavaMarkerAnnotation(marker); } /** * @see AbstractMarkerAnnotationModel#listenToMarkerChanges(boolean) */ protected void listenToMarkerChanges(boolean listen) { if (listen) fWorkspace.addResourceChangeListener(this); else fWorkspace.removeResourceChangeListener(this); } /** * @see AbstractMarkerAnnotationModel#deleteMarkers(IMarker[]) */ protected void deleteMarkers(IMarker[] markers) throws CoreException { // empty as class files are read only } /** * @see AbstractMarkerAnnotationModel#retrieveMarkers() */ protected IMarker[] retrieveMarkers() throws CoreException { return fMarkerResource.findMarkers(IMarker.MARKER, true, IResource.DEPTH_INFINITE); } /** * @see IResourceDeltaVisitor#visit */ public boolean visit(IResourceDelta delta) throws CoreException { if (delta != null) { if (fMarkerResource != null && !fMarkerResource.equals(delta.getResource())) return true; IMarkerDelta[] markerDeltas= delta.getMarkerDeltas(); for (int i= 0; i < markerDeltas.length; i++) { if (isAffected(markerDeltas[i])) { IMarker marker= markerDeltas[i].getMarker(); switch (markerDeltas[i].getKind()) { case IResourceDelta.ADDED : addMarkerAnnotation(marker); fChangesApplied= true; break; case IResourceDelta.REMOVED : removeMarkerAnnotation(marker); fChangesApplied= true; break; case IResourceDelta.CHANGED: modifyMarkerAnnotation(marker); fChangesApplied= true; break; } } } return (fMarkerResource == null); } return false; } /** * @see IResourceChangeListener#resourceChanged */ public void resourceChanged(IResourceChangeEvent e) { IResourceDelta delta= e.getDelta(); try { if (delta != null) { fChangesApplied= false; delta.accept(this); if (fChangesApplied) fireModelChanged(); } } catch (CoreException x) { handleCoreException(x, JavaEditorMessages.getString("ClassFileMarkerAnnotationModel.error.resourceChanged")); //$NON-NLS-1$ } } }
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/core
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
extension/org/eclipse/jdt/internal/corext/codemanipulation/ImportEdit.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/core
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
extension/org/eclipse/jdt/internal/corext/textmanipulation/SimpleTextEdit.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/core
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
extension/org/eclipse/jdt/internal/corext/textmanipulation/TextEdit.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/core
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
extension/org/eclipse/jdt/internal/corext/textmanipulation/TextRange.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/core
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/reorg/DeleteSourceReferenceEdit.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/core
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
refactoring/org/eclipse/jdt/internal/corext/refactoring/reorg/MoveCuUpdateCreator.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/ui
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
refactoring/org/eclipse/jdt/internal/ui/refactoring/ChangeElementContentProvider.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/ui
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
refactoring/org/eclipse/jdt/internal/ui/refactoring/ComparePreviewer.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/ui
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
refactoring/org/eclipse/jdt/internal/ui/refactoring/PreviewWizardPage.java
8,221
Bug 8221 NPE in refactoring preview page (Pull up)
1. select TestCase.setUp and invoke 'Pull Up' 2. In the delete tree check all elements, press next 3. Open the 'VectorTest.java' tree and select the node 'Delete....' -> 4 org.eclipse.core.runtime 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.ui.refactoring.ComparePreviewer$CompareInput.<init> (ComparePreviewer.java:42) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getCompareInput (PreviewWizardPage.java:211) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.getPreviewer (PreviewWizardPage.java:254) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.showPreview (PreviewWizardPage.java:374) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage.access$1 (PreviewWizardPage.java:372) at org.eclipse.jdt.internal.ui.refactoring.PreviewWizardPage$2.selectionChanged (PreviewWizardPage.java:363) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java (Compiled Code)) at org.eclipse.jface.viewers.StructuredViewer.updateSelection (StructuredViewer.java:999) at org.eclipse.jface.viewers.StructuredViewer.handleSelect (StructuredViewer.java:466) at org.eclipse.jface.viewers.CheckboxTreeViewer.handleSelect (CheckboxTreeViewer.java:233) at org.eclipse.jface.viewers.AbstractTreeViewer$1.widgetSelected (AbstractTreeViewer.java:624) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringStarter.activate (RefactoringStarter.java:83) at org.eclipse.jdt.internal.ui.refactoring.actions.OpenRefactoringWizardAction.run (OpenRefactoringWizardAction.java:65) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.UIMain.main(UIMain.java:52)
verified fixed
c2780ff
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T16:15:40Z"
"2002-01-23T18:20:00Z"
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/PasteInCompilationUnitEdit.java
package org.eclipse.jdt.internal.ui.reorg; import org.eclipse.core.runtime.CoreException; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IPackageDeclaration; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.textmanipulation.SimpleTextEdit; import org.eclipse.jdt.internal.corext.textmanipulation.TextBufferEditor; import org.eclipse.jdt.internal.corext.textmanipulation.TextEdit; import org.eclipse.jdt.internal.corext.textmanipulation.TextRange; import org.eclipse.jdt.internal.corext.refactoring.Assert; class PasteInCompilationUnitEdit extends SimpleTextEdit { private String fSource; private int fType; private ICompilationUnit fCu; protected PasteInCompilationUnitEdit(String source, int type, ICompilationUnit cu) { Assert.isNotNull(source); fSource= source; Assert.isTrue(type == IJavaElement.PACKAGE_DECLARATION || type == IJavaElement.IMPORT_CONTAINER || type == IJavaElement.IMPORT_DECLARATION || type == IJavaElement.TYPE); fType= type; Assert.isTrue(cu.exists()); fCu= cu; } /* * @see TextEdit#copy() */ public TextEdit copy() { return new PasteInCompilationUnitEdit(fSource, fType, fCu); } /* non Java-doc * @see TextEdit#connect */ public void connect(TextBufferEditor editor) throws CoreException { setText(fSource); setTextRange(new TextRange(computeOffset(), 0)); } private int computeOffset() throws JavaModelException{ switch(fType){ case IJavaElement.PACKAGE_DECLARATION: return computeOffsetForPackageDeclaration(); case IJavaElement.IMPORT_CONTAINER: return computeOffsetForImportContainer(); case IJavaElement.IMPORT_DECLARATION: return computeOffsetForImportContainer();// i think it's the same case IJavaElement.TYPE: return computeOffsetForType(); default: Assert.isTrue(false); return -1; //to make the compiler happy } } private int computeOffsetForPackageDeclaration() throws JavaModelException{ //insert before the first one or at the top if none IPackageDeclaration[] declarations= fCu.getPackageDeclarations(); if (declarations.length == 0) return 0; return declarations[0].getSourceRange().getOffset(); } private int computeOffsetForImportContainer() throws JavaModelException{ //try prepending the existing one IImportContainer container= fCu.getImportContainer(); if (container.exists()) return container.getSourceRange().getOffset(); //try putting after the package declaration IPackageDeclaration[] declarations= fCu.getPackageDeclarations(); if (declarations.length != 0) return declarations[declarations.length - 1].getSourceRange().getOffset() + declarations[declarations.length - 1].getSourceRange().getLength(); //put at the beginning return 0; } private int computeOffsetForType() throws JavaModelException{ //try prepending to existing types IType[] types= fCu.getTypes(); if (types.length != 0) return types[0].getSourceRange().getOffset(); //put at the end return fCu.getSourceRange().getLength(); } }
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/A.java
public class A{ String f(int y, int z, boolean ff){ /*[*/try{ } catch (Exception e){ }/*]*/ return null; } void f(){} }
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/X.java
import java.io.*; public class X { void foo(final int out){ new Object(){ void bar(){ /*START*/System.out.println(out)/*END*/; } }; } }
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/validSelection_in/A_test360.java
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/validSelection_in/A_test361.java
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/validSelection_in/A_test362.java
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/validSelection_in/A_test363.java
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/validSelection_out/A_test360.java
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/validSelection_out/A_test361.java
4,914
Bug 4914 can't extract class expression
class B{ Object m(){ return /*[*/B.class/*]*/; } } cannot extract the selected fragment
verified fixed
3688645
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
"2002-01-24T18:51:39Z"
"2001-10-12T09:46:40Z"
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/validSelection_out/A_test362.java