issue_owner_repo
sequencelengths 2
2
| issue_body
stringlengths 0
261k
β | issue_title
stringlengths 1
953
| issue_comments_url
stringlengths 56
81
| issue_comments_count
int64 0
726
| issue_created_at
timestamp[ns] | issue_updated_at
unknown | issue_html_url
stringlengths 37
62
| issue_github_id
int64 285M
2.37B
| issue_number
int64 1
168k
| msg
stringlengths 159
261k
| n_tokens
int64 159
261k
| __index_level_0__
int64 38
208k
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
[
"Exiv2",
"exiv2"
] | There is a buffer overflow in exiv2 in file types.cpp.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.6 LTS
Release: 16.04
Codename: xenial
gcc: 5.4.0
The compile command is:
cmake ./ ;make
To reproduce the issue, run:
./exiv2 input
Here is the trace reported by asan:
#0 0x7faff55ba631 (/usr/lib/x86_64-linux-gnu/libasan.so.2+0xa0631)
#1 0x7faff55bf5e3 in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/usr/lib/x86_64-linux-gnu/libasan.so.2+0xa55e3)
#2 0x7faff5537425 (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x1d425)
#3 0x7faff55bd865 (/usr/lib/x86_64-linux-gnu/libasan.so.2+0xa3865)
#4 0x7faff553cb4d (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x22b4d)
#5 0x7faff55b367e in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x9967e)
#6 0x7faff0f63d25 in Exiv2::DataBuf::DataBuf(long) /home/heqing/playground/exiv2-0.27.1-Source-a/src/types.cpp:141
#7 0x7faff0dc8995 in Exiv2::RafImage::readMetadata() /home/heqing/playground/exiv2-0.27.1-Source-a/src/rafimage.cpp:300
#8 0x77b36d in Action::Print::printSummary() /home/heqing/playground/exiv2-0.27.1-Source-a/src/actions.cpp:286
#9 0x79935f in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/heqing/playground/exiv2-0.27.1-Source-a/src/actions.cpp:246
#10 0x410f18 in main /home/heqing/playground/exiv2-0.27.1-Source-a/src/exiv2.cpp:169
#11 0x7fafecfe282f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#12 0x41abb8 in _start (/home/heqing/playground/exiv2-0.27.1-Source-a/build/bin/exiv2+0x41abb8)
The reason is that DataBuf in types.cpp does not check the malloced buffer is a null pointer or not yet directly use memcpy to write the buffer.
The attachment is the poc input.
[poc_input2.zip](https://github.com/Exiv2/exiv2/files/3485483/poc_input2.zip)
| Buffer overflow caused by exhaustive memory usage | https://api.github.com/repos/Exiv2/exiv2/issues/980/comments | 4 | 2019-08-09T08:46:00 | "2021-07-23T12:12:29Z" | https://github.com/Exiv2/exiv2/issues/980 | 478,871,751 | 980 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Buffer overflow caused by exhaustive memory usage
Issue date:
--- start body ---
There is a buffer overflow in exiv2 in file types.cpp.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.6 LTS
Release: 16.04
Codename: xenial
gcc: 5.4.0
The compile command is:
cmake ./ ;make
To reproduce the issue, run:
./exiv2 input
Here is the trace reported by asan:
#0 0x7faff55ba631 (/usr/lib/x86_64-linux-gnu/libasan.so.2+0xa0631)
#1 0x7faff55bf5e3 in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/usr/lib/x86_64-linux-gnu/libasan.so.2+0xa55e3)
#2 0x7faff5537425 (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x1d425)
#3 0x7faff55bd865 (/usr/lib/x86_64-linux-gnu/libasan.so.2+0xa3865)
#4 0x7faff553cb4d (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x22b4d)
#5 0x7faff55b367e in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x9967e)
#6 0x7faff0f63d25 in Exiv2::DataBuf::DataBuf(long) /home/heqing/playground/exiv2-0.27.1-Source-a/src/types.cpp:141
#7 0x7faff0dc8995 in Exiv2::RafImage::readMetadata() /home/heqing/playground/exiv2-0.27.1-Source-a/src/rafimage.cpp:300
#8 0x77b36d in Action::Print::printSummary() /home/heqing/playground/exiv2-0.27.1-Source-a/src/actions.cpp:286
#9 0x79935f in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/heqing/playground/exiv2-0.27.1-Source-a/src/actions.cpp:246
#10 0x410f18 in main /home/heqing/playground/exiv2-0.27.1-Source-a/src/exiv2.cpp:169
#11 0x7fafecfe282f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#12 0x41abb8 in _start (/home/heqing/playground/exiv2-0.27.1-Source-a/build/bin/exiv2+0x41abb8)
The reason is that DataBuf in types.cpp does not check the malloced buffer is a null pointer or not yet directly use memcpy to write the buffer.
The attachment is the poc input.
[poc_input2.zip](https://github.com/Exiv2/exiv2/files/3485483/poc_input2.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,273 | 207,809 |
[
"Exiv2",
"exiv2"
] | There are is a segmentation fault happened in exiv2 correlated to getUShort.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.6 LTS
Release: 16.04
Codename: xenial
gcc: 5.4.0
The compile command is:
cmake ./ ;make
To reproduce the issue, run:
./exiv2 input
Here is the trace reported by asan:
=================================================================
==170768==ERROR: AddressSanitizer: SEGV on unknown address 0x7fc5ab442080 (pc 0x7fc4b2978cd0 bp 0x0fffddc18c2e sp 0x7ffeee0c6140 T0)
#0 0x7fc4b2978ccf in unsigned short Exiv2::getUShort<unsigned char const*>(Exiv2::Slice<unsigned char const*> const&, Exiv2::ByteOrder) /home/heqing/playground/exiv2-0.27.1-Source-a/include/exiv2/types.hpp:300
#1 0x7fc4b2978ccf in Exiv2::getUShort(unsigned char const*, Exiv2::ByteOrder) /home/heqing/playground/exiv2-0.27.1-Source-a/src/types.cpp:280
#2 0x7fc4b30a1637 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) /home/heqing/playground/exiv2-0.27.1-Source-a/src/crwimage_int.cpp:286
#3 0x7fc4b1ce6fb7 in Exiv2::CrwParser::decode(Exiv2::CrwImage*, unsigned char const*, unsigned int) /home/heqing/playground/exiv2-0.27.1-Source-a/src/crwimage.cpp:150
#4 0x7fc4b1cf4475 in Exiv2::CrwImage::readMetadata() /home/heqing/playground/exiv2-0.27.1-Source-a/src/crwimage.cpp:107
#5 0x77b36d in Action::Print::printSummary() /home/heqing/playground/exiv2-0.27.1-Source-a/src/actions.cpp:286
#6 0x79935f in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/heqing/playground/exiv2-0.27.1-Source-a/src/actions.cpp:246
#7 0x410f18 in main /home/heqing/playground/exiv2-0.27.1-Source-a/src/exiv2.cpp:169
#8 0x7fc4ae9ee82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#9 0x41abb8 in _start (/home/heqing/playground/exiv2-0.27.1-Source-a/build/bin/exiv2+0x41abb8)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/heqing/playground/exiv2-0.27.1-Source-a/include/exiv2/types.hpp:300 unsigned short Exiv2::getUShort<unsigned char const*>(Exiv2::Slice<unsigned char const*> const&, Exiv2::ByteOrder)
==170768==ABORTING
The original program output is segmentation fault.
The attachment is the poc input.
[poc_input.zip](https://github.com/Exiv2/exiv2/files/3485450/poc_input.zip)
| Segmentation fault in exiv2 | https://api.github.com/repos/Exiv2/exiv2/issues/979/comments | 5 | 2019-08-09T08:37:12 | "2021-07-23T12:07:32Z" | https://github.com/Exiv2/exiv2/issues/979 | 478,867,947 | 979 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Segmentation fault in exiv2
Issue date:
--- start body ---
There are is a segmentation fault happened in exiv2 correlated to getUShort.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.6 LTS
Release: 16.04
Codename: xenial
gcc: 5.4.0
The compile command is:
cmake ./ ;make
To reproduce the issue, run:
./exiv2 input
Here is the trace reported by asan:
=================================================================
==170768==ERROR: AddressSanitizer: SEGV on unknown address 0x7fc5ab442080 (pc 0x7fc4b2978cd0 bp 0x0fffddc18c2e sp 0x7ffeee0c6140 T0)
#0 0x7fc4b2978ccf in unsigned short Exiv2::getUShort<unsigned char const*>(Exiv2::Slice<unsigned char const*> const&, Exiv2::ByteOrder) /home/heqing/playground/exiv2-0.27.1-Source-a/include/exiv2/types.hpp:300
#1 0x7fc4b2978ccf in Exiv2::getUShort(unsigned char const*, Exiv2::ByteOrder) /home/heqing/playground/exiv2-0.27.1-Source-a/src/types.cpp:280
#2 0x7fc4b30a1637 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) /home/heqing/playground/exiv2-0.27.1-Source-a/src/crwimage_int.cpp:286
#3 0x7fc4b1ce6fb7 in Exiv2::CrwParser::decode(Exiv2::CrwImage*, unsigned char const*, unsigned int) /home/heqing/playground/exiv2-0.27.1-Source-a/src/crwimage.cpp:150
#4 0x7fc4b1cf4475 in Exiv2::CrwImage::readMetadata() /home/heqing/playground/exiv2-0.27.1-Source-a/src/crwimage.cpp:107
#5 0x77b36d in Action::Print::printSummary() /home/heqing/playground/exiv2-0.27.1-Source-a/src/actions.cpp:286
#6 0x79935f in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/heqing/playground/exiv2-0.27.1-Source-a/src/actions.cpp:246
#7 0x410f18 in main /home/heqing/playground/exiv2-0.27.1-Source-a/src/exiv2.cpp:169
#8 0x7fc4ae9ee82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#9 0x41abb8 in _start (/home/heqing/playground/exiv2-0.27.1-Source-a/build/bin/exiv2+0x41abb8)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/heqing/playground/exiv2-0.27.1-Source-a/include/exiv2/types.hpp:300 unsigned short Exiv2::getUShort<unsigned char const*>(Exiv2::Slice<unsigned char const*> const&, Exiv2::ByteOrder)
==170768==ABORTING
The original program output is segmentation fault.
The attachment is the poc input.
[poc_input.zip](https://github.com/Exiv2/exiv2/files/3485450/poc_input.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,616 | 207,810 |
[
"Exiv2",
"exiv2"
] | As part of one of my projects, a fork of the Sourcforge vvvP project which seems almost dormant, I need to use exiv2lib to display images.
I am using an updated version MSVC 2017, Community edition, wxWidgets 3.0.1 all statically linked - except for zlib1.dll.
The original code was compiled with the DLL version of exiv2 0.27.1. But I was getting memory leaks - as reported both by my own MSVC code and Visual Leak Detector (VLD).
Unfortunately, neither was able to give me details as to where exactly the memory was allocated, though I was pretty sure it was somewhere in the exiv2lib code from running test which did not invoke exiv2lib - though that meant I could not display the images. Therefore I downloaded the latest exiv2 0.27.2 code and compiled a static 32-bit debug version of exiv2lib.
(Kudos to the developers because, by following the instructions, it all compiled without a hitch.)
After some fiddling to reverse my patches necessary for the 0.27.1 version to avoid using the boost libraries, I got my forked project to compile, link and run.
As before, I was getting a lot of memory leaks if I displayed any one of the images, but by instrumenting the exiv2lib source files with my memory detection code (from MSVC) quickly identified the issue: the places identified directly were all within XMP::Initialize(), though this function seemed to be called in a very round about way (as part of other initializations, I presume/guess).
A review of the exiv2lib documentation and exvi2 samples shows lots of use of the XMP SDK, but as far as I can tell, none of them definitely and directly initialized the XMP SDK code - and I cannot find any references to any cleanup for the SDK.
After compiling a debug version of exifprint (as a test & with VLD installed and an #include "vld.h" line at the top of exifprint.cpp), handing it a test image from https://en.wikipedia.org/wiki/File:An_exif_test_image_-_for_test_use_(not_article_space)_use_only.jpg and setting a breakpoint at XMPMeta::Initialize() in XMPMeta.cpp, it ended up at this initialization point.
At exit, however, VLD printed out a long list of leaked memory allocations - some of which included information about where the memory was allocated.
Setting another breakpoint at XMPMeta::Terminate() - also in XMPMeta.cpp - showed that this cleanup routine was never called on exit.
For now, I will have to live with this issue, but I would dearly see it resolved.
If I missed anything about where the cleanup might happen, or if I can provide further details, please let me know | Memory leak issue with exifprint 0.27.2 | https://api.github.com/repos/Exiv2/exiv2/issues/976/comments | 15 | 2019-07-31T00:07:07 | "2019-10-07T14:37:11Z" | https://github.com/Exiv2/exiv2/issues/976 | 474,875,037 | 976 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Memory leak issue with exifprint 0.27.2
Issue date:
--- start body ---
As part of one of my projects, a fork of the Sourcforge vvvP project which seems almost dormant, I need to use exiv2lib to display images.
I am using an updated version MSVC 2017, Community edition, wxWidgets 3.0.1 all statically linked - except for zlib1.dll.
The original code was compiled with the DLL version of exiv2 0.27.1. But I was getting memory leaks - as reported both by my own MSVC code and Visual Leak Detector (VLD).
Unfortunately, neither was able to give me details as to where exactly the memory was allocated, though I was pretty sure it was somewhere in the exiv2lib code from running test which did not invoke exiv2lib - though that meant I could not display the images. Therefore I downloaded the latest exiv2 0.27.2 code and compiled a static 32-bit debug version of exiv2lib.
(Kudos to the developers because, by following the instructions, it all compiled without a hitch.)
After some fiddling to reverse my patches necessary for the 0.27.1 version to avoid using the boost libraries, I got my forked project to compile, link and run.
As before, I was getting a lot of memory leaks if I displayed any one of the images, but by instrumenting the exiv2lib source files with my memory detection code (from MSVC) quickly identified the issue: the places identified directly were all within XMP::Initialize(), though this function seemed to be called in a very round about way (as part of other initializations, I presume/guess).
A review of the exiv2lib documentation and exvi2 samples shows lots of use of the XMP SDK, but as far as I can tell, none of them definitely and directly initialized the XMP SDK code - and I cannot find any references to any cleanup for the SDK.
After compiling a debug version of exifprint (as a test & with VLD installed and an #include "vld.h" line at the top of exifprint.cpp), handing it a test image from https://en.wikipedia.org/wiki/File:An_exif_test_image_-_for_test_use_(not_article_space)_use_only.jpg and setting a breakpoint at XMPMeta::Initialize() in XMPMeta.cpp, it ended up at this initialization point.
At exit, however, VLD printed out a long list of leaked memory allocations - some of which included information about where the memory was allocated.
Setting another breakpoint at XMPMeta::Terminate() - also in XMPMeta.cpp - showed that this cleanup routine was never called on exit.
For now, I will have to live with this issue, but I would dearly see it resolved.
If I missed anything about where the cleanup might happen, or if I can provide further details, please let me know
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,778 | 207,811 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
It appears that libexiv in popular distros get outdated too fast. My lens is in version 0.27, but not in 0.25, which is provided by Ubuntu. I tried to build the latest version and use it with the installed version of darktable but failed. It would be good to move such things out so it would be trivial to update the database.
**To Reproduce**
Steps to reproduce the behaviour:
1. Install for example 19.04, and you will still get an out-of-date lens db
**Expected behavior**
A simple file that can be stored in /usr/local/shared, that contains all required information for lens correction.
**Desktop (please complete the following information):**
- OS: Debian, Mint, RedHat, Ubuntu (ie distros with slow upgrades, probably not Arch, and Gentoo)
- Compiler & Version: NA
- Compilation mode and/or compiler flags: NA
| Consider moving lens db to a separate module, for easier updating | https://api.github.com/repos/Exiv2/exiv2/issues/970/comments | 3 | 2019-07-28T06:23:26 | "2019-07-28T20:59:19Z" | https://github.com/Exiv2/exiv2/issues/970 | 473,710,686 | 970 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Consider moving lens db to a separate module, for easier updating
Issue date:
--- start body ---
**Describe the bug**
It appears that libexiv in popular distros get outdated too fast. My lens is in version 0.27, but not in 0.25, which is provided by Ubuntu. I tried to build the latest version and use it with the installed version of darktable but failed. It would be good to move such things out so it would be trivial to update the database.
**To Reproduce**
Steps to reproduce the behaviour:
1. Install for example 19.04, and you will still get an out-of-date lens db
**Expected behavior**
A simple file that can be stored in /usr/local/shared, that contains all required information for lens correction.
**Desktop (please complete the following information):**
- OS: Debian, Mint, RedHat, Ubuntu (ie distros with slow upgrades, probably not Arch, and Gentoo)
- Compiler & Version: NA
- Compilation mode and/or compiler flags: NA
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,085 | 207,812 |
[
"Exiv2",
"exiv2"
] | I was working on the phone with a user in Little Rock, Arkansas. He doesn't have libintl.dylib on his machine. The MacOS-X bundle would not run because he doesn't have /usr/local/lib/libintl.dylib I made a private build on 0.27.1 for him with EXIV2_ENABLE_NLS=Off and sent it to him and that was fine.
Later in our discussion, I got him to build from source. The build failed while building the exiv2 command-line application complaining about libintl.dylib being missing.
I haven't understood what libintl does. I don't even know how/why it's on my machine.
It's not on Linux. I think it's built into the C Library.
https://stackoverflow.com/questions/11370684/what-is-libintl-h-and-where-can-i-get-it
I'd like to take two actions from this:
1) Ensure that public packages never use libraries from /usr/local/lib
I've done this on the build server for expat and zlib.
Build MacOSX packages with EXIV2_ENABLE_NLS=Off
2) Discover what's really wrong with the detection of libintl.
The code in `cmake/findDependencies.cmake` is:
```
if (EXIV2_ENABLE_NLS)
find_package(Intl REQUIRED)
endif( )
```
I removed libintl.dylib and libintl.a from my machine from /usr/local, /opt (macports installed that) and /sw (brew installed that). Now pgk-config and uname are broken! CMake still reports:
```
-- Native language support: YES
```
Confused?
@piponazo Please don't spend time on this. Let me do the detective work to really understand what is going on here. | Build fails on MacOS-X when /usr/local/lib/libintl.dylib is missing | https://api.github.com/repos/Exiv2/exiv2/issues/966/comments | 8 | 2019-07-20T22:24:00 | "2019-07-28T08:00:13Z" | https://github.com/Exiv2/exiv2/issues/966 | 470,720,056 | 966 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Build fails on MacOS-X when /usr/local/lib/libintl.dylib is missing
Issue date:
--- start body ---
I was working on the phone with a user in Little Rock, Arkansas. He doesn't have libintl.dylib on his machine. The MacOS-X bundle would not run because he doesn't have /usr/local/lib/libintl.dylib I made a private build on 0.27.1 for him with EXIV2_ENABLE_NLS=Off and sent it to him and that was fine.
Later in our discussion, I got him to build from source. The build failed while building the exiv2 command-line application complaining about libintl.dylib being missing.
I haven't understood what libintl does. I don't even know how/why it's on my machine.
It's not on Linux. I think it's built into the C Library.
https://stackoverflow.com/questions/11370684/what-is-libintl-h-and-where-can-i-get-it
I'd like to take two actions from this:
1) Ensure that public packages never use libraries from /usr/local/lib
I've done this on the build server for expat and zlib.
Build MacOSX packages with EXIV2_ENABLE_NLS=Off
2) Discover what's really wrong with the detection of libintl.
The code in `cmake/findDependencies.cmake` is:
```
if (EXIV2_ENABLE_NLS)
find_package(Intl REQUIRED)
endif( )
```
I removed libintl.dylib and libintl.a from my machine from /usr/local, /opt (macports installed that) and /sw (brew installed that). Now pgk-config and uname are broken! CMake still reports:
```
-- Native language support: YES
```
Confused?
@piponazo Please don't spend time on this. Let me do the detective work to really understand what is going on here.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,746 | 207,813 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
I found a buffer overflow bugs in exiv2/src/webpimage.cpp:837 due to integer overflow.
**To Reproduce**
Steps to reproduce the behaviour:
exiv2/build/bin/exiv2 exiv2_getHeaderOffset.poc
**Expected behavior**
In Exiv2::WebPImage::getHeaderOffset, integer overflow occurs when data_size is less than header_size, and it will cause buffer overflow in '&data[i]'.
```
#0 0x00007ffff784ce88 in Exiv2::WebPImage::getHeaderOffset (this=<optimized out>, data=0x71a2e0 "\300\\\310\366\377\177", data_size=0x0, header_size=0x4, header=<optimized out>) at /data/Exiv2_AFL/exiv2/src/webpimage.cpp:837
#1 Exiv2::WebPImage::decodeChunks (this=<optimized out>, filesize=<optimized out>) at /data/Exiv2_AFL/exiv2/src/webpimage.cpp:632
#2 0x00007ffff784b2e0 in Exiv2::WebPImage::readMetadata (this=0x719820) at /data/Exiv2_AFL/exiv2/src/webpimage.cpp:508
#3 0x000000000049d59d in Action::Print::printSummary (this=0x71a950) at /data/Exiv2_AFL/exiv2/src/actions.cpp:260
#4 0x000000000049cf30 in Action::Print::run (this=0x71a950, Python Exception <class 'gdb.error'> There is no member named _M_dataplus.:
path=) at /data/Exiv2_AFL/exiv2/src/actions.cpp:215
#5 0x00000000004094e6 in main (argc=<optimized out>, argc@entry=0x2, argv=<optimized out>, argv@entry=0x7fffffffe6c8) at /data/Exiv2_AFL/exiv2/src/exiv2.cpp:77
#6 0x00007ffff68bbb97 in __libc_start_main (main=0x408b30 <main(int, char* const*)>, argc=0x2, argv=0x7fffffffe6c8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe6b8) at ../csu/libc-start.c:310
#7 0x0000000000408a6a in _start ()
0x7ffff784ce77 <Exiv2::WebPImage::decodeChunks(long)+4279>: mov rcx,QWORD PTR [rsp+0x8]
0x7ffff784ce7c <Exiv2::WebPImage::decodeChunks(long)+4284>: mov rdx,QWORD PTR [rsp]
0x7ffff784ce80 <Exiv2::WebPImage::decodeChunks(long)+4288>: lea rsp,[rsp+0x98]
=> 0x7ffff784ce88 <Exiv2::WebPImage::decodeChunks(long)+4296>: cmp DWORD PTR [rcx+rsi*1],0xe1ff01ff
0x7ffff784ce8f <Exiv2::WebPImage::decodeChunks(long)+4303>: je 0x7ffff784d858 <Exiv2::WebPImage::decodeChunks(long)+6808>
0x7ffff784ce95 <Exiv2::WebPImage::decodeChunks(long)+4309>: nop DWORD PTR [rax]
0x7ffff784ce98 <Exiv2::WebPImage::decodeChunks(long)+4312>: lea rsp,[rsp-0x98]
0x7ffff784cea0 <Exiv2::WebPImage::decodeChunks(long)+4320>: mov QWORD PTR [rsp],rdx
RCX: 0x71a2e0
RSI: 0xdd1d
```
The poc is here:
Just do 'exiv2/build/bin/exiv2 exiv2_getHeaderOffset.poc'
[exiv2_getHeaderOffset.poc.zip](https://github.com/Exiv2/exiv2/files/3390730/exiv2_getHeaderOffset.poc.zip)
| buffer overflow in exiv2/src/webpimage.cpp | https://api.github.com/repos/Exiv2/exiv2/issues/960/comments | 4 | 2019-07-15T02:53:48 | "2019-10-28T11:28:20Z" | https://github.com/Exiv2/exiv2/issues/960 | 467,920,688 | 960 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : buffer overflow in exiv2/src/webpimage.cpp
Issue date:
--- start body ---
**Describe the bug**
I found a buffer overflow bugs in exiv2/src/webpimage.cpp:837 due to integer overflow.
**To Reproduce**
Steps to reproduce the behaviour:
exiv2/build/bin/exiv2 exiv2_getHeaderOffset.poc
**Expected behavior**
In Exiv2::WebPImage::getHeaderOffset, integer overflow occurs when data_size is less than header_size, and it will cause buffer overflow in '&data[i]'.
```
#0 0x00007ffff784ce88 in Exiv2::WebPImage::getHeaderOffset (this=<optimized out>, data=0x71a2e0 "\300\\\310\366\377\177", data_size=0x0, header_size=0x4, header=<optimized out>) at /data/Exiv2_AFL/exiv2/src/webpimage.cpp:837
#1 Exiv2::WebPImage::decodeChunks (this=<optimized out>, filesize=<optimized out>) at /data/Exiv2_AFL/exiv2/src/webpimage.cpp:632
#2 0x00007ffff784b2e0 in Exiv2::WebPImage::readMetadata (this=0x719820) at /data/Exiv2_AFL/exiv2/src/webpimage.cpp:508
#3 0x000000000049d59d in Action::Print::printSummary (this=0x71a950) at /data/Exiv2_AFL/exiv2/src/actions.cpp:260
#4 0x000000000049cf30 in Action::Print::run (this=0x71a950, Python Exception <class 'gdb.error'> There is no member named _M_dataplus.:
path=) at /data/Exiv2_AFL/exiv2/src/actions.cpp:215
#5 0x00000000004094e6 in main (argc=<optimized out>, argc@entry=0x2, argv=<optimized out>, argv@entry=0x7fffffffe6c8) at /data/Exiv2_AFL/exiv2/src/exiv2.cpp:77
#6 0x00007ffff68bbb97 in __libc_start_main (main=0x408b30 <main(int, char* const*)>, argc=0x2, argv=0x7fffffffe6c8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe6b8) at ../csu/libc-start.c:310
#7 0x0000000000408a6a in _start ()
0x7ffff784ce77 <Exiv2::WebPImage::decodeChunks(long)+4279>: mov rcx,QWORD PTR [rsp+0x8]
0x7ffff784ce7c <Exiv2::WebPImage::decodeChunks(long)+4284>: mov rdx,QWORD PTR [rsp]
0x7ffff784ce80 <Exiv2::WebPImage::decodeChunks(long)+4288>: lea rsp,[rsp+0x98]
=> 0x7ffff784ce88 <Exiv2::WebPImage::decodeChunks(long)+4296>: cmp DWORD PTR [rcx+rsi*1],0xe1ff01ff
0x7ffff784ce8f <Exiv2::WebPImage::decodeChunks(long)+4303>: je 0x7ffff784d858 <Exiv2::WebPImage::decodeChunks(long)+6808>
0x7ffff784ce95 <Exiv2::WebPImage::decodeChunks(long)+4309>: nop DWORD PTR [rax]
0x7ffff784ce98 <Exiv2::WebPImage::decodeChunks(long)+4312>: lea rsp,[rsp-0x98]
0x7ffff784cea0 <Exiv2::WebPImage::decodeChunks(long)+4320>: mov QWORD PTR [rsp],rdx
RCX: 0x71a2e0
RSI: 0xdd1d
```
The poc is here:
Just do 'exiv2/build/bin/exiv2 exiv2_getHeaderOffset.poc'
[exiv2_getHeaderOffset.poc.zip](https://github.com/Exiv2/exiv2/files/3390730/exiv2_getHeaderOffset.poc.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,941 | 207,814 |
[
"Exiv2",
"exiv2"
] | https://github.com/Exiv2/exiv2/pull/833#issuecomment-511202324 | Use #!/usr/bin/env bash in test/build scripts | https://api.github.com/repos/Exiv2/exiv2/issues/958/comments | 0 | 2019-07-14T17:34:33 | "2019-10-08T12:06:32Z" | https://github.com/Exiv2/exiv2/issues/958 | 467,865,519 | 958 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Use #!/usr/bin/env bash in test/build scripts
Issue date:
--- start body ---
https://github.com/Exiv2/exiv2/pull/833#issuecomment-511202324
--- end body ---
comments :
--- start comments ---
--- end comments --- | 268 | 207,815 |
[
"Exiv2",
"exiv2"
] | Take ideas from here:
https://git.libssh.org/projects/libssh.git/tree/CompilerChecks.cmake | Add compiler flags which could be interesting in terms of software security | https://api.github.com/repos/Exiv2/exiv2/issues/956/comments | 4 | 2019-07-12T13:35:59 | "2023-11-04T16:32:14Z" | https://github.com/Exiv2/exiv2/issues/956 | 467,417,966 | 956 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add compiler flags which could be interesting in terms of software security
Issue date:
--- start body ---
Take ideas from here:
https://git.libssh.org/projects/libssh.git/tree/CompilerChecks.cmake
--- end body ---
comments :
--- start comments ---
--- end comments --- | 329 | 207,816 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
in my research , a heap overflow found in Exiv2::MrwImage::readMetadata() /home/tim/exiv2-asan/src/mrwimage.cpp:131.
**To Reproduce**
exiv2 -pv $poc
[poc1.zip](https://github.com/Exiv2/exiv2/files/3385271/poc1.zip)
**Expected behavior**
```
asan output
rASAN:DEADLYSIGNAL
=================================================================
==45838==ERROR: AddressSanitizer: SEGV on unknown address 0x6030ededef5d (pc 0x7f7971f0157e bp 0x7fffb45f5a30 sp 0x7fffb45f5198 T0)
==45838==The signal is caused by a READ memory access.
#0 0x7f7971f0157d (/lib/x86_64-linux-gnu/libc.so.6+0xbb57d)
#1 0x7f79734236ce (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x796ce)
#2 0x7f79729be723 in memcpy /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
#3 0x7f79729be723 in Exiv2::MemIo::read(unsigned char*, unsigned long) /home/tim/exiv2-asan/src/basicio.cpp:1354
#4 0x7f7972aff426 in Exiv2::MrwImage::readMetadata() /home/tim/exiv2-asan/src/mrwimage.cpp:131
#5 0x7f7972b09a9c in Exiv2::PgfImage::readMetadata() /home/tim/exiv2-asan/src/pgfimage.cpp:153
#6 0x55ab241e8644 in Action::Print::printSummary() /home/tim/exiv2-asan/src/actions.cpp:260
#7 0x55ab241ed304 in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/tim/exiv2-asan/src/actions.cpp:215
#8 0x55ab24165692 in main /home/tim/exiv2-asan/src/exiv2.cpp:77
#9 0x7f7971e67b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#10 0x55ab24166359 in _start (/home/tim/exiv2-asan/build/bin/exiv2+0x18359)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libc.so.6+0xbb57d)
==45838==ABORTING
gdb output
gdb-peda$ r /home/tim/poc1
Starting program: /home/tim/fuzz/exiv2/exiv2 /home/tim/poc1
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Program received signal SIGSEGV, Segmentation fault.
[----------------------------------registers-----------------------------------]
RAX: 0x7fffffffdf60 --> 0xedededededededed
RBX: 0xffffffff12121221
RCX: 0xedededededededed
RDX: 0x8
RSI: 0x55564368c1dd
RDI: 0x7fffffffdf60 --> 0xedededededededed
RBP: 0x8
RSP: 0x7fffffffdec8 --> 0x7ffff79796bf (<Exiv2::MemIo::read(unsigned char*, unsigned long)+63>: mov rax,QWORD PTR [r13+0x10])
RIP: 0x7ffff70d1b53 (<__memmove_avx_unaligned_erms+131>: mov rcx,QWORD PTR [rsi+rdx*1-0x8])
R8 : 0x5555557ad3a0 --> 0x7ffff7db10d0 (:MemIo+16>: 0x00007ffff7974450)
R9 : 0x0
R10: 0xa ('\n')
R11: 0x7ffff79fa3d0 (<Exiv2::getULong(unsigned char const*, Exiv2::ByteOrder)>: mov eax,DWORD PTR [rdi])
R12: 0x8
R13: 0x5555557ad3a0 --> 0x7ffff7db10d0 (:MemIo+16>: 0x00007ffff7974450)
R14: 0x7fffffffdf61 --> 0xededededededed
R15: 0x7ffff7db1438 (:IoCloser>: 0x0000000000000000)
EFLAGS: 0x10246 (carry PARITY adjust ZERO sign trap INTERRUPT direction overflow)
[-------------------------------------code-------------------------------------]
0x7ffff70d1b48 <__memmove_avx_unaligned_erms+120>: vmovdqu XMMWORD PTR [rdi],xmm0
0x7ffff70d1b4c <__memmove_avx_unaligned_erms+124>: vmovdqu XMMWORD PTR [rdi+rdx*1-0x10],xmm1
0x7ffff70d1b52 <__memmove_avx_unaligned_erms+130>: ret
=> 0x7ffff70d1b53 <__memmove_avx_unaligned_erms+131>: mov rcx,QWORD PTR [rsi+rdx*1-0x8]
0x7ffff70d1b58 <__memmove_avx_unaligned_erms+136>: mov rsi,QWORD PTR [rsi]
0x7ffff70d1b5b <__memmove_avx_unaligned_erms+139>: mov QWORD PTR [rdi+rdx*1-0x8],rcx
0x7ffff70d1b60 <__memmove_avx_unaligned_erms+144>: mov QWORD PTR [rdi],rsi
0x7ffff70d1b63 <__memmove_avx_unaligned_erms+147>: ret
[------------------------------------stack-------------------------------------]
0000| 0x7fffffffdec8 --> 0x7ffff79796bf (<Exiv2::MemIo::read(unsigned char*, unsigned long)+63>: mov rax,QWORD PTR [r13+0x10])
0008| 0x7fffffffded0 --> 0x7ffff7db1438 (:IoCloser>: 0x0000000000000000)
0016| 0x7fffffffded8 --> 0x5555557aca60 --> 0x7ffff7db22f8 (:MrwImage+16>: 0x00007ffff79d4f90)
0024| 0x7fffffffdee0 --> 0xededee05
0032| 0x7fffffffdee8 --> 0x7fffffffdf60 --> 0xedededededededed
0040| 0x7fffffffdef0 --> 0xf7ffffff
0048| 0x7fffffffdef8 --> 0x7ffff79d471b (<Exiv2::MrwImage::readMetadata()+603>: mov rdi,QWORD PTR [rbx+0x8])
0056| 0x7fffffffdf00 --> 0x7ffff7db1448 (:IoCloser+16>: 0x00007ffff7988490)
[------------------------------------------------------------------------------]
Legend: code, data, rodata, value
Stopped reason: SIGSEGV
__memmove_avx_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:299
299 ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S: No such file or directory.
gdb-peda$ bt
#0 __memmove_avx_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:299
#1 0x00007ffff79796bf in memcpy (__len=<optimized out>, __src=<optimized out>, __dest=<optimized out>) at /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
#2 Exiv2::MemIo::read (this=0x5555557ad3a0, buf=<optimized out>, rcount=0x8) at /home/tim/exiv2/src/basicio.cpp:1354
#3 0x00007ffff79d471b in Exiv2::MrwImage::readMetadata (this=0x5555557aca60) at /home/tim/exiv2/src/mrwimage.cpp:131
#4 0x00007ffff79d7d82 in Exiv2::PgfImage::readMetadata (this=0x5555557ac920) at /home/tim/exiv2/src/pgfimage.cpp:153
#5 0x000055555557f40d in Action::Print::printSummary (this=0x5555557ada50) at /home/tim/exiv2/src/actions.cpp:260
#6 0x00005555555808c5 in Action::Print::run (this=0x5555557ada50, path="/home/tim/poc1") at /home/tim/exiv2/src/actions.cpp:215
#7 0x000055555555e304 in main (argc=argc@entry=0x2, argv=argv@entry=0x7fffffffe578) at /home/tim/exiv2/src/exiv2.cpp:77
#8 0x00007ffff6f64b97 in __libc_start_main (main=0x55555555e100 <main(int, char* const*)>, argc=0x2, argv=0x7fffffffe578, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe568) at ../csu/libc-start.c:310
#9 0x000055555555e6da in _start ()
gdb-peda$ vmmap
Start End Perm Name
0x0000555555554000 0x0000555555597000 r-xp /home/tim/fuzz/exiv2/exiv2
0x0000555555796000 0x0000555555798000 r--p /home/tim/fuzz/exiv2/exiv2
0x0000555555798000 0x0000555555799000 rw-p /home/tim/fuzz/exiv2/exiv2
0x0000555555799000 0x00005555557ba000 rw-p [heap]
0x00007ffff5b67000 0x00007ffff6536000 r--p /usr/lib/locale/locale-archive
0x00007ffff6536000 0x00007ffff66d3000 r-xp /lib/x86_64-linux-gnu/libm-2.27.so
0x00007ffff66d3000 0x00007ffff68d2000 ---p /lib/x86_64-linux-gnu/libm-2.27.so
0x00007ffff68d2000 0x00007ffff68d3000 r--p /lib/x86_64-linux-gnu/libm-2.27.so
0x00007ffff68d3000 0x00007ffff68d4000 rw-p /lib/x86_64-linux-gnu/libm-2.27.so
0x00007ffff68d4000 0x00007ffff68ee000 r-xp /lib/x86_64-linux-gnu/libpthread-2.27.so
0x00007ffff68ee000 0x00007ffff6aed000 ---p /lib/x86_64-linux-gnu/libpthread-2.27.so
0x00007ffff6aed000 0x00007ffff6aee000 r--p /lib/x86_64-linux-gnu/libpthread-2.27.so
0x00007ffff6aee000 0x00007ffff6aef000 rw-p /lib/x86_64-linux-gnu/libpthread-2.27.so
0x00007ffff6aef000 0x00007ffff6af3000 rw-p mapped
0x00007ffff6af3000 0x00007ffff6b22000 r-xp /lib/x86_64-linux-gnu/libexpat.so.1.6.7
0x00007ffff6b22000 0x00007ffff6d22000 ---p /lib/x86_64-linux-gnu/libexpat.so.1.6.7
0x00007ffff6d22000 0x00007ffff6d24000 r--p /lib/x86_64-linux-gnu/libexpat.so.1.6.7
0x00007ffff6d24000 0x00007ffff6d25000 rw-p /lib/x86_64-linux-gnu/libexpat.so.1.6.7
0x00007ffff6d25000 0x00007ffff6d41000 r-xp /usr/local/lib/libz.so.1.2.11
0x00007ffff6d41000 0x00007ffff6f41000 ---p /usr/local/lib/libz.so.1.2.11
0x00007ffff6f41000 0x00007ffff6f42000 r--p /usr/local/lib/libz.so.1.2.11
0x00007ffff6f42000 0x00007ffff6f43000 rw-p /usr/local/lib/libz.so.1.2.11
0x00007ffff6f43000 0x00007ffff712a000 r-xp /lib/x86_64-linux-gnu/libc-2.27.so
0x00007ffff712a000 0x00007ffff732a000 ---p /lib/x86_64-linux-gnu/libc-2.27.so
0x00007ffff732a000 0x00007ffff732e000 r--p /lib/x86_64-linux-gnu/libc-2.27.so
0x00007ffff732e000 0x00007ffff7330000 rw-p /lib/x86_64-linux-gnu/libc-2.27.so
0x00007ffff7330000 0x00007ffff7334000 rw-p mapped
0x00007ffff7334000 0x00007ffff734b000 r-xp /lib/x86_64-linux-gnu/libgcc_s.so.1
0x00007ffff734b000 0x00007ffff754a000 ---p /lib/x86_64-linux-gnu/libgcc_s.so.1
0x00007ffff754a000 0x00007ffff754b000 r--p /lib/x86_64-linux-gnu/libgcc_s.so.1
0x00007ffff754b000 0x00007ffff754c000 rw-p /lib/x86_64-linux-gnu/libgcc_s.so.1
0x00007ffff754c000 0x00007ffff76c5000 r-xp /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
0x00007ffff76c5000 0x00007ffff78c5000 ---p /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
0x00007ffff78c5000 0x00007ffff78cf000 r--p /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
0x00007ffff78cf000 0x00007ffff78d1000 rw-p /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
0x00007ffff78d1000 0x00007ffff78d5000 rw-p mapped
0x00007ffff78d5000 0x00007ffff7b86000 r-xp /home/tim/exiv2/build/lib/libexiv2.so.0.27.99.0
0x00007ffff7b86000 0x00007ffff7d85000 ---p /home/tim/exiv2/build/lib/libexiv2.so.0.27.99.0
0x00007ffff7d85000 0x00007ffff7db7000 r--p /home/tim/exiv2/build/lib/libexiv2.so.0.27.99.0
0x00007ffff7db7000 0x00007ffff7dba000 rw-p /home/tim/exiv2/build/lib/libexiv2.so.0.27.99.0
0x00007ffff7dba000 0x00007ffff7dd5000 rw-p mapped
0x00007ffff7dd5000 0x00007ffff7dfc000 r-xp /lib/x86_64-linux-gnu/ld-2.27.so
0x00007ffff7fda000 0x00007ffff7fe0000 rw-p mapped
0x00007ffff7ff5000 0x00007ffff7ff7000 rw-p mapped
0x00007ffff7ff7000 0x00007ffff7ffa000 r--p [vvar]
0x00007ffff7ffa000 0x00007ffff7ffc000 r-xp [vdso]
0x00007ffff7ffc000 0x00007ffff7ffd000 r--p /lib/x86_64-linux-gnu/ld-2.27.so
0x00007ffff7ffd000 0x00007ffff7ffe000 rw-p /lib/x86_64-linux-gnu/ld-2.27.so
0x00007ffff7ffe000 0x00007ffff7fff000 rw-p mapped
0x00007ffffffde000 0x00007ffffffff000 rw-p [stack]
0xffffffffff600000 0xffffffffff601000 r-xp [vsyscall]
```
**Desktop (please complete the following information):**
- ubuntu18
- gcc 7.4.0
- -fsanitize=address -g
| heap-buffer-overflow in Exiv2::MrwImage::readMetadata() | https://api.github.com/repos/Exiv2/exiv2/issues/954/comments | 4 | 2019-07-12T06:36:56 | "2019-07-22T09:36:16Z" | https://github.com/Exiv2/exiv2/issues/954 | 467,246,598 | 954 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : heap-buffer-overflow in Exiv2::MrwImage::readMetadata()
Issue date:
--- start body ---
**Describe the bug**
in my research , a heap overflow found in Exiv2::MrwImage::readMetadata() /home/tim/exiv2-asan/src/mrwimage.cpp:131.
**To Reproduce**
exiv2 -pv $poc
[poc1.zip](https://github.com/Exiv2/exiv2/files/3385271/poc1.zip)
**Expected behavior**
```
asan output
rASAN:DEADLYSIGNAL
=================================================================
==45838==ERROR: AddressSanitizer: SEGV on unknown address 0x6030ededef5d (pc 0x7f7971f0157e bp 0x7fffb45f5a30 sp 0x7fffb45f5198 T0)
==45838==The signal is caused by a READ memory access.
#0 0x7f7971f0157d (/lib/x86_64-linux-gnu/libc.so.6+0xbb57d)
#1 0x7f79734236ce (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x796ce)
#2 0x7f79729be723 in memcpy /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
#3 0x7f79729be723 in Exiv2::MemIo::read(unsigned char*, unsigned long) /home/tim/exiv2-asan/src/basicio.cpp:1354
#4 0x7f7972aff426 in Exiv2::MrwImage::readMetadata() /home/tim/exiv2-asan/src/mrwimage.cpp:131
#5 0x7f7972b09a9c in Exiv2::PgfImage::readMetadata() /home/tim/exiv2-asan/src/pgfimage.cpp:153
#6 0x55ab241e8644 in Action::Print::printSummary() /home/tim/exiv2-asan/src/actions.cpp:260
#7 0x55ab241ed304 in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/tim/exiv2-asan/src/actions.cpp:215
#8 0x55ab24165692 in main /home/tim/exiv2-asan/src/exiv2.cpp:77
#9 0x7f7971e67b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#10 0x55ab24166359 in _start (/home/tim/exiv2-asan/build/bin/exiv2+0x18359)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libc.so.6+0xbb57d)
==45838==ABORTING
gdb output
gdb-peda$ r /home/tim/poc1
Starting program: /home/tim/fuzz/exiv2/exiv2 /home/tim/poc1
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Program received signal SIGSEGV, Segmentation fault.
[----------------------------------registers-----------------------------------]
RAX: 0x7fffffffdf60 --> 0xedededededededed
RBX: 0xffffffff12121221
RCX: 0xedededededededed
RDX: 0x8
RSI: 0x55564368c1dd
RDI: 0x7fffffffdf60 --> 0xedededededededed
RBP: 0x8
RSP: 0x7fffffffdec8 --> 0x7ffff79796bf (<Exiv2::MemIo::read(unsigned char*, unsigned long)+63>: mov rax,QWORD PTR [r13+0x10])
RIP: 0x7ffff70d1b53 (<__memmove_avx_unaligned_erms+131>: mov rcx,QWORD PTR [rsi+rdx*1-0x8])
R8 : 0x5555557ad3a0 --> 0x7ffff7db10d0 (:MemIo+16>: 0x00007ffff7974450)
R9 : 0x0
R10: 0xa ('\n')
R11: 0x7ffff79fa3d0 (<Exiv2::getULong(unsigned char const*, Exiv2::ByteOrder)>: mov eax,DWORD PTR [rdi])
R12: 0x8
R13: 0x5555557ad3a0 --> 0x7ffff7db10d0 (:MemIo+16>: 0x00007ffff7974450)
R14: 0x7fffffffdf61 --> 0xededededededed
R15: 0x7ffff7db1438 (:IoCloser>: 0x0000000000000000)
EFLAGS: 0x10246 (carry PARITY adjust ZERO sign trap INTERRUPT direction overflow)
[-------------------------------------code-------------------------------------]
0x7ffff70d1b48 <__memmove_avx_unaligned_erms+120>: vmovdqu XMMWORD PTR [rdi],xmm0
0x7ffff70d1b4c <__memmove_avx_unaligned_erms+124>: vmovdqu XMMWORD PTR [rdi+rdx*1-0x10],xmm1
0x7ffff70d1b52 <__memmove_avx_unaligned_erms+130>: ret
=> 0x7ffff70d1b53 <__memmove_avx_unaligned_erms+131>: mov rcx,QWORD PTR [rsi+rdx*1-0x8]
0x7ffff70d1b58 <__memmove_avx_unaligned_erms+136>: mov rsi,QWORD PTR [rsi]
0x7ffff70d1b5b <__memmove_avx_unaligned_erms+139>: mov QWORD PTR [rdi+rdx*1-0x8],rcx
0x7ffff70d1b60 <__memmove_avx_unaligned_erms+144>: mov QWORD PTR [rdi],rsi
0x7ffff70d1b63 <__memmove_avx_unaligned_erms+147>: ret
[------------------------------------stack-------------------------------------]
0000| 0x7fffffffdec8 --> 0x7ffff79796bf (<Exiv2::MemIo::read(unsigned char*, unsigned long)+63>: mov rax,QWORD PTR [r13+0x10])
0008| 0x7fffffffded0 --> 0x7ffff7db1438 (:IoCloser>: 0x0000000000000000)
0016| 0x7fffffffded8 --> 0x5555557aca60 --> 0x7ffff7db22f8 (:MrwImage+16>: 0x00007ffff79d4f90)
0024| 0x7fffffffdee0 --> 0xededee05
0032| 0x7fffffffdee8 --> 0x7fffffffdf60 --> 0xedededededededed
0040| 0x7fffffffdef0 --> 0xf7ffffff
0048| 0x7fffffffdef8 --> 0x7ffff79d471b (<Exiv2::MrwImage::readMetadata()+603>: mov rdi,QWORD PTR [rbx+0x8])
0056| 0x7fffffffdf00 --> 0x7ffff7db1448 (:IoCloser+16>: 0x00007ffff7988490)
[------------------------------------------------------------------------------]
Legend: code, data, rodata, value
Stopped reason: SIGSEGV
__memmove_avx_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:299
299 ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S: No such file or directory.
gdb-peda$ bt
#0 __memmove_avx_unaligned_erms () at ../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:299
#1 0x00007ffff79796bf in memcpy (__len=<optimized out>, __src=<optimized out>, __dest=<optimized out>) at /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
#2 Exiv2::MemIo::read (this=0x5555557ad3a0, buf=<optimized out>, rcount=0x8) at /home/tim/exiv2/src/basicio.cpp:1354
#3 0x00007ffff79d471b in Exiv2::MrwImage::readMetadata (this=0x5555557aca60) at /home/tim/exiv2/src/mrwimage.cpp:131
#4 0x00007ffff79d7d82 in Exiv2::PgfImage::readMetadata (this=0x5555557ac920) at /home/tim/exiv2/src/pgfimage.cpp:153
#5 0x000055555557f40d in Action::Print::printSummary (this=0x5555557ada50) at /home/tim/exiv2/src/actions.cpp:260
#6 0x00005555555808c5 in Action::Print::run (this=0x5555557ada50, path="/home/tim/poc1") at /home/tim/exiv2/src/actions.cpp:215
#7 0x000055555555e304 in main (argc=argc@entry=0x2, argv=argv@entry=0x7fffffffe578) at /home/tim/exiv2/src/exiv2.cpp:77
#8 0x00007ffff6f64b97 in __libc_start_main (main=0x55555555e100 <main(int, char* const*)>, argc=0x2, argv=0x7fffffffe578, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe568) at ../csu/libc-start.c:310
#9 0x000055555555e6da in _start ()
gdb-peda$ vmmap
Start End Perm Name
0x0000555555554000 0x0000555555597000 r-xp /home/tim/fuzz/exiv2/exiv2
0x0000555555796000 0x0000555555798000 r--p /home/tim/fuzz/exiv2/exiv2
0x0000555555798000 0x0000555555799000 rw-p /home/tim/fuzz/exiv2/exiv2
0x0000555555799000 0x00005555557ba000 rw-p [heap]
0x00007ffff5b67000 0x00007ffff6536000 r--p /usr/lib/locale/locale-archive
0x00007ffff6536000 0x00007ffff66d3000 r-xp /lib/x86_64-linux-gnu/libm-2.27.so
0x00007ffff66d3000 0x00007ffff68d2000 ---p /lib/x86_64-linux-gnu/libm-2.27.so
0x00007ffff68d2000 0x00007ffff68d3000 r--p /lib/x86_64-linux-gnu/libm-2.27.so
0x00007ffff68d3000 0x00007ffff68d4000 rw-p /lib/x86_64-linux-gnu/libm-2.27.so
0x00007ffff68d4000 0x00007ffff68ee000 r-xp /lib/x86_64-linux-gnu/libpthread-2.27.so
0x00007ffff68ee000 0x00007ffff6aed000 ---p /lib/x86_64-linux-gnu/libpthread-2.27.so
0x00007ffff6aed000 0x00007ffff6aee000 r--p /lib/x86_64-linux-gnu/libpthread-2.27.so
0x00007ffff6aee000 0x00007ffff6aef000 rw-p /lib/x86_64-linux-gnu/libpthread-2.27.so
0x00007ffff6aef000 0x00007ffff6af3000 rw-p mapped
0x00007ffff6af3000 0x00007ffff6b22000 r-xp /lib/x86_64-linux-gnu/libexpat.so.1.6.7
0x00007ffff6b22000 0x00007ffff6d22000 ---p /lib/x86_64-linux-gnu/libexpat.so.1.6.7
0x00007ffff6d22000 0x00007ffff6d24000 r--p /lib/x86_64-linux-gnu/libexpat.so.1.6.7
0x00007ffff6d24000 0x00007ffff6d25000 rw-p /lib/x86_64-linux-gnu/libexpat.so.1.6.7
0x00007ffff6d25000 0x00007ffff6d41000 r-xp /usr/local/lib/libz.so.1.2.11
0x00007ffff6d41000 0x00007ffff6f41000 ---p /usr/local/lib/libz.so.1.2.11
0x00007ffff6f41000 0x00007ffff6f42000 r--p /usr/local/lib/libz.so.1.2.11
0x00007ffff6f42000 0x00007ffff6f43000 rw-p /usr/local/lib/libz.so.1.2.11
0x00007ffff6f43000 0x00007ffff712a000 r-xp /lib/x86_64-linux-gnu/libc-2.27.so
0x00007ffff712a000 0x00007ffff732a000 ---p /lib/x86_64-linux-gnu/libc-2.27.so
0x00007ffff732a000 0x00007ffff732e000 r--p /lib/x86_64-linux-gnu/libc-2.27.so
0x00007ffff732e000 0x00007ffff7330000 rw-p /lib/x86_64-linux-gnu/libc-2.27.so
0x00007ffff7330000 0x00007ffff7334000 rw-p mapped
0x00007ffff7334000 0x00007ffff734b000 r-xp /lib/x86_64-linux-gnu/libgcc_s.so.1
0x00007ffff734b000 0x00007ffff754a000 ---p /lib/x86_64-linux-gnu/libgcc_s.so.1
0x00007ffff754a000 0x00007ffff754b000 r--p /lib/x86_64-linux-gnu/libgcc_s.so.1
0x00007ffff754b000 0x00007ffff754c000 rw-p /lib/x86_64-linux-gnu/libgcc_s.so.1
0x00007ffff754c000 0x00007ffff76c5000 r-xp /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
0x00007ffff76c5000 0x00007ffff78c5000 ---p /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
0x00007ffff78c5000 0x00007ffff78cf000 r--p /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
0x00007ffff78cf000 0x00007ffff78d1000 rw-p /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
0x00007ffff78d1000 0x00007ffff78d5000 rw-p mapped
0x00007ffff78d5000 0x00007ffff7b86000 r-xp /home/tim/exiv2/build/lib/libexiv2.so.0.27.99.0
0x00007ffff7b86000 0x00007ffff7d85000 ---p /home/tim/exiv2/build/lib/libexiv2.so.0.27.99.0
0x00007ffff7d85000 0x00007ffff7db7000 r--p /home/tim/exiv2/build/lib/libexiv2.so.0.27.99.0
0x00007ffff7db7000 0x00007ffff7dba000 rw-p /home/tim/exiv2/build/lib/libexiv2.so.0.27.99.0
0x00007ffff7dba000 0x00007ffff7dd5000 rw-p mapped
0x00007ffff7dd5000 0x00007ffff7dfc000 r-xp /lib/x86_64-linux-gnu/ld-2.27.so
0x00007ffff7fda000 0x00007ffff7fe0000 rw-p mapped
0x00007ffff7ff5000 0x00007ffff7ff7000 rw-p mapped
0x00007ffff7ff7000 0x00007ffff7ffa000 r--p [vvar]
0x00007ffff7ffa000 0x00007ffff7ffc000 r-xp [vdso]
0x00007ffff7ffc000 0x00007ffff7ffd000 r--p /lib/x86_64-linux-gnu/ld-2.27.so
0x00007ffff7ffd000 0x00007ffff7ffe000 rw-p /lib/x86_64-linux-gnu/ld-2.27.so
0x00007ffff7ffe000 0x00007ffff7fff000 rw-p mapped
0x00007ffffffde000 0x00007ffffffff000 rw-p [stack]
0xffffffffff600000 0xffffffffff601000 r-xp [vsyscall]
```
**Desktop (please complete the following information):**
- ubuntu18
- gcc 7.4.0
- -fsanitize=address -g
--- end body ---
comments :
--- start comments ---
--- end comments --- | 10,284 | 207,817 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
in my research , a heap overflow found in Exiv2::readChunk(Exiv2::DataBuf&, Exiv2::BasicIo&) /src/pngimage.cpp:410.
**To Reproduce**
exiv2 -pv $poc
[poc.zip](https://github.com/Exiv2/exiv2/files/3384823/poc.zip)
**Expected behavior**
```
=================================================================
==6866==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030000001b0 at pc 0x7f6fac214733 bp 0x7ffdf4470950 sp 0x7ffdf44700f8
READ of size 8 at 0x6030000001b0 thread T0
#0 0x7f6fac214732 (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
#1 0x7f6fab7af723 in memcpy /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
#2 0x7f6fab7af723 in Exiv2::MemIo::read(unsigned char*, unsigned long) /home/tim/exiv2-asan/src/basicio.cpp:1354
#3 0x7f6faba0b142 in Exiv2::readChunk(Exiv2::DataBuf&, Exiv2::BasicIo&) /home/tim/exiv2-asan/src/pngimage.cpp:410
#4 0x7f6faba182f9 in Exiv2::PngImage::readMetadata() /home/tim/exiv2-asan/src/pngimage.cpp:438
#5 0x7f6fab8faa9c in Exiv2::PgfImage::readMetadata() /home/tim/exiv2-asan/src/pgfimage.cpp:153
#6 0x559495100458 in Action::Print::printList() /home/tim/exiv2-asan/src/actions.cpp:483
#7 0x55949510629d in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/tim/exiv2-asan/src/actions.cpp:218
#8 0x55949507e692 in main /home/tim/exiv2-asan/src/exiv2.cpp:77
#9 0x7f6faac58b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#10 0x55949507f359 in _start (/home/tim/exiv2-asan/build/bin/exiv2+0x18359)
0x6030000001b0 is located 2 bytes to the right of 30-byte region [0x603000000190,0x6030000001ae)
allocated by thread T0 here:
#0 0x7f6fac27b618 in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe0618)
#1 0x7f6fab97f0e3 in Exiv2::DataBuf::DataBuf(unsigned long) /home/tim/exiv2-asan/src/types.cpp:144
SUMMARY: AddressSanitizer: heap-buffer-overflow (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
Shadow bytes around the buggy address:
0x0c067fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c067fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c067fff8000: fa fa fd fd fd fd fa fa 00 00 00 06 fa fa fd fd
0x0c067fff8010: fd fd fa fa fd fd fd fd fa fa fd fd fd fd fa fa
0x0c067fff8020: fd fd fd fd fa fa 00 00 00 00 fa fa 00 00 00 fa
=>0x0c067fff8030: fa fa 00 00 00 06[fa]fa 00 00 00 fa fa fa fa fa
0x0c067fff8040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8070: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8080: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==6866==ABORTING
```
**Desktop (please complete the following information):**
- ubuntu18
- gcc 7.4.0
- -fsanitize=address -g
| AddressSanitizer: heap-buffer-overflow in PngImage::readMetadata() pngimage.cpp:438 | https://api.github.com/repos/Exiv2/exiv2/issues/953/comments | 8 | 2019-07-12T03:07:03 | "2019-07-22T09:21:12Z" | https://github.com/Exiv2/exiv2/issues/953 | 467,198,124 | 953 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : AddressSanitizer: heap-buffer-overflow in PngImage::readMetadata() pngimage.cpp:438
Issue date:
--- start body ---
**Describe the bug**
in my research , a heap overflow found in Exiv2::readChunk(Exiv2::DataBuf&, Exiv2::BasicIo&) /src/pngimage.cpp:410.
**To Reproduce**
exiv2 -pv $poc
[poc.zip](https://github.com/Exiv2/exiv2/files/3384823/poc.zip)
**Expected behavior**
```
=================================================================
==6866==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030000001b0 at pc 0x7f6fac214733 bp 0x7ffdf4470950 sp 0x7ffdf44700f8
READ of size 8 at 0x6030000001b0 thread T0
#0 0x7f6fac214732 (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
#1 0x7f6fab7af723 in memcpy /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
#2 0x7f6fab7af723 in Exiv2::MemIo::read(unsigned char*, unsigned long) /home/tim/exiv2-asan/src/basicio.cpp:1354
#3 0x7f6faba0b142 in Exiv2::readChunk(Exiv2::DataBuf&, Exiv2::BasicIo&) /home/tim/exiv2-asan/src/pngimage.cpp:410
#4 0x7f6faba182f9 in Exiv2::PngImage::readMetadata() /home/tim/exiv2-asan/src/pngimage.cpp:438
#5 0x7f6fab8faa9c in Exiv2::PgfImage::readMetadata() /home/tim/exiv2-asan/src/pgfimage.cpp:153
#6 0x559495100458 in Action::Print::printList() /home/tim/exiv2-asan/src/actions.cpp:483
#7 0x55949510629d in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/tim/exiv2-asan/src/actions.cpp:218
#8 0x55949507e692 in main /home/tim/exiv2-asan/src/exiv2.cpp:77
#9 0x7f6faac58b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#10 0x55949507f359 in _start (/home/tim/exiv2-asan/build/bin/exiv2+0x18359)
0x6030000001b0 is located 2 bytes to the right of 30-byte region [0x603000000190,0x6030000001ae)
allocated by thread T0 here:
#0 0x7f6fac27b618 in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe0618)
#1 0x7f6fab97f0e3 in Exiv2::DataBuf::DataBuf(unsigned long) /home/tim/exiv2-asan/src/types.cpp:144
SUMMARY: AddressSanitizer: heap-buffer-overflow (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
Shadow bytes around the buggy address:
0x0c067fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c067fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c067fff8000: fa fa fd fd fd fd fa fa 00 00 00 06 fa fa fd fd
0x0c067fff8010: fd fd fa fa fd fd fd fd fa fa fd fd fd fd fa fa
0x0c067fff8020: fd fd fd fd fa fa 00 00 00 00 fa fa 00 00 00 fa
=>0x0c067fff8030: fa fa 00 00 00 06[fa]fa 00 00 00 fa fa fa fa fa
0x0c067fff8040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8070: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8080: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==6866==ABORTING
```
**Desktop (please complete the following information):**
- ubuntu18
- gcc 7.4.0
- -fsanitize=address -g
--- end body ---
comments :
--- start comments ---
--- end comments --- | 3,872 | 207,818 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
in my research , a heap overflow found in RafImage::readMetadata rafimage.cpp:296.
**To Reproduce**
exiv2 -pv $poc
[exiv2poc.zip](https://github.com/Exiv2/exiv2/files/3384707/exiv2poc.zip)
**Expected behavior**
```
root@ubuntu:~/fuzz/exiv2# /home/tim/exiv2-asan/build/bin/exiv2 /home/tim/fuzz/exiv2/out/master/queue/id:000174,src:000124,op:ext_AO,pos:24,+cov
=================================================================
==108944==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030000001b4 at pc 0x7f55a6829733 bp 0x7ffeff406e20 sp 0x7ffeff4065c8
READ of size 4 at 0x6030000001b4 thread T0
#0 0x7f55a6829732 (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
#1 0x7f55a5dc4723 in memcpy /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
#2 0x7f55a5dc4723 in Exiv2::MemIo::read(unsigned char*, unsigned long) /home/tim/exiv2-asan/src/basicio.cpp:1354
#3 0x7f55a5f65c98 in Exiv2::RafImage::readMetadata() /home/tim/exiv2-asan/src/rafimage.cpp:296
#4 0x7f55a5f0fa9c in Exiv2::PgfImage::readMetadata() /home/tim/exiv2-asan/src/pgfimage.cpp:153
#5 0x5636c0fbc644 in Action::Print::printSummary() /home/tim/exiv2-asan/src/actions.cpp:260
#6 0x5636c0fc1304 in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/tim/exiv2-asan/src/actions.cpp:215
#7 0x5636c0f39692 in main /home/tim/exiv2-asan/src/exiv2.cpp:77
#8 0x7f55a526db96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#9 0x5636c0f3a359 in _start (/home/tim/exiv2-asan/build/bin/exiv2+0x18359)
0x6030000001b4 is located 12 bytes to the right of 24-byte region [0x603000000190,0x6030000001a8)
allocated by thread T0 here:
#0 0x7f55a6890458 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe0458)
#1 0x7f55a5eb05e9 in Exiv2::ImageFactory::open(unsigned char const*, unsigned long) /home/tim/exiv2-asan/src/image.cpp:902
SUMMARY: AddressSanitizer: heap-buffer-overflow (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
Shadow bytes around the buggy address:
0x0c067fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c067fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c067fff8000: fa fa fd fd fd fd fa fa 00 00 00 06 fa fa fd fd
0x0c067fff8010: fd fa fa fa fd fd fd fd fa fa fd fd fd fd fa fa
0x0c067fff8020: 00 00 00 00 fa fa 00 00 00 fa fa fa 00 00 00 06
=>0x0c067fff8030: fa fa 00 00 00 fa[fa]fa fa fa fa fa fa fa fa fa
0x0c067fff8040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8070: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8080: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==108944==ABORTING
```
**Desktop (please complete the following information):**
- ubuntu18
- gcc 7.4.0
- -fsanitize=address -g
| AddressSanitizer: heap-buffer-overflow in RafImage::readMetadata | https://api.github.com/repos/Exiv2/exiv2/issues/952/comments | 4 | 2019-07-12T02:22:41 | "2019-07-29T16:51:35Z" | https://github.com/Exiv2/exiv2/issues/952 | 467,188,161 | 952 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : AddressSanitizer: heap-buffer-overflow in RafImage::readMetadata
Issue date:
--- start body ---
**Describe the bug**
in my research , a heap overflow found in RafImage::readMetadata rafimage.cpp:296.
**To Reproduce**
exiv2 -pv $poc
[exiv2poc.zip](https://github.com/Exiv2/exiv2/files/3384707/exiv2poc.zip)
**Expected behavior**
```
root@ubuntu:~/fuzz/exiv2# /home/tim/exiv2-asan/build/bin/exiv2 /home/tim/fuzz/exiv2/out/master/queue/id:000174,src:000124,op:ext_AO,pos:24,+cov
=================================================================
==108944==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030000001b4 at pc 0x7f55a6829733 bp 0x7ffeff406e20 sp 0x7ffeff4065c8
READ of size 4 at 0x6030000001b4 thread T0
#0 0x7f55a6829732 (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
#1 0x7f55a5dc4723 in memcpy /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34
#2 0x7f55a5dc4723 in Exiv2::MemIo::read(unsigned char*, unsigned long) /home/tim/exiv2-asan/src/basicio.cpp:1354
#3 0x7f55a5f65c98 in Exiv2::RafImage::readMetadata() /home/tim/exiv2-asan/src/rafimage.cpp:296
#4 0x7f55a5f0fa9c in Exiv2::PgfImage::readMetadata() /home/tim/exiv2-asan/src/pgfimage.cpp:153
#5 0x5636c0fbc644 in Action::Print::printSummary() /home/tim/exiv2-asan/src/actions.cpp:260
#6 0x5636c0fc1304 in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/tim/exiv2-asan/src/actions.cpp:215
#7 0x5636c0f39692 in main /home/tim/exiv2-asan/src/exiv2.cpp:77
#8 0x7f55a526db96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
#9 0x5636c0f3a359 in _start (/home/tim/exiv2-asan/build/bin/exiv2+0x18359)
0x6030000001b4 is located 12 bytes to the right of 24-byte region [0x603000000190,0x6030000001a8)
allocated by thread T0 here:
#0 0x7f55a6890458 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe0458)
#1 0x7f55a5eb05e9 in Exiv2::ImageFactory::open(unsigned char const*, unsigned long) /home/tim/exiv2-asan/src/image.cpp:902
SUMMARY: AddressSanitizer: heap-buffer-overflow (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x79732)
Shadow bytes around the buggy address:
0x0c067fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c067fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c067fff8000: fa fa fd fd fd fd fa fa 00 00 00 06 fa fa fd fd
0x0c067fff8010: fd fa fa fa fd fd fd fd fa fa fd fd fd fd fa fa
0x0c067fff8020: 00 00 00 00 fa fa 00 00 00 fa fa fa 00 00 00 06
=>0x0c067fff8030: fa fa 00 00 00 fa[fa]fa fa fa fa fa fa fa fa fa
0x0c067fff8040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8070: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff8080: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==108944==ABORTING
```
**Desktop (please complete the following information):**
- ubuntu18
- gcc 7.4.0
- -fsanitize=address -g
--- end body ---
comments :
--- start comments ---
--- end comments --- | 3,881 | 207,819 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-20099
There is an infinite loop in Exiv2::Jp2Image::encodeJp2Header of jp2image.cpp in Exiv2 0.27-RC3. A crafted input will lead to a remote denial of service attack.
This has been reported in #590 , but @piponazo ignored due to not `cp CVE-2018-20099 CVE-2018-20099.exv`
This CVE has not been fixed on current commit `1de8e734`
**To Reproduce**
Steps to reproduce the behaviour:
1. download the [POC file](https://github.com/TeamSeri0us/pocs/raw/master/exiv2/20181206/jp2image-infiniteloop-poc-5)
2. Provide exact command to reproduce the issue
```
wget https://github.com/TeamSeri0us/pocs/raw/master/exiv2/20181206/jp2image-infiniteloop-poc-5
mv jp2image-infiniteloop-poc-5 CVE-2018-20099
cp CVE-2018-20099 CVE-2018-20099.exv
./exiv2 insert CVE-2018-20099
```
**Expected behavior**
infinite loop
**Desktop (please complete the following information):**
- OS: Ubuntu 16.04
- Compiler & Version gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.11)
- Compilation mode and/or compiler flags: using afl-gcc and ASAN
**Additional context**
press `Ctrl+Break` to let gdb break
```
root@66b85dd83778:/d/cvepoc/exiv2# gdb /d/p/latest/1.exiv2
GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.5) 7.11.1
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /d/p/latest/1.exiv2...done.
(gdb) r insert CVE-2018-20099
Starting program: /d/p/latest/1.exiv2 insert CVE-2018-20099
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
^C
Program received signal SIGINT, Interrupt.
0x00007ffff64e4820 in Exiv2::getLong (buf=0x7fffffffb534 "olr\001", byteOrder=<optimized out>) at /d/p/latest/exiv2/src/types.cpp:339
339 | (byte)buf[2] << 8 | (byte)buf[3];
(gdb) bt
#0 0x00007ffff64e4820 in Exiv2::getLong (buf=0x7fffffffb534 "olr\001", byteOrder=<optimized out>) at /d/p/latest/exiv2/src/types.cpp:339
#1 0x00000ffffffff6a6 in ?? ()
#2 0x000000006f6c7201 in ?? ()
#3 0x0000000000000000 in ?? ()
(gdb) list
334 return (byte)buf[3] << 24 | (byte)buf[2] << 16
335 | (byte)buf[1] << 8 | (byte)buf[0];
336 }
337 else {
338 return (byte)buf[0] << 24 | (byte)buf[1] << 16
339 | (byte)buf[2] << 8 | (byte)buf[3];
340 }
341 }
342
343 Rational getRational(const byte* buf, ByteOrder byteOrder)
(gdb) finish
Run till exit from #0 0x00007ffff64e4820 in Exiv2::getLong (buf=0x7fffffffb534 "olr\001", byteOrder=<optimized out>) at /d/p/latest/exiv2/src/types.cpp:339
^C
Program received signal SIGINT, Interrupt.
0x00007ffff6ef65ed in __asan_memcpy () from /usr/lib/x86_64-linux-gnu/libasan.so.2
(gdb) bt
#0 0x00007ffff6ef65ed in __asan_memcpy () from /usr/lib/x86_64-linux-gnu/libasan.so.2
#1 0x00007ffff63f51a1 in Exiv2::Jp2Image::encodeJp2Header (this=this@entry=0x61200000bd40, boxBuf=..., outBuf=...) at /d/p/latest/exiv2/src/jp2image.cpp:678
#2 0x00007ffff63f752f in Exiv2::Jp2Image::doWriteMetadata (this=this@entry=0x61200000bd40, outIo=...) at /d/p/latest/exiv2/src/jp2image.cpp:789
#3 0x00007ffff6403c0b in Exiv2::Jp2Image::writeMetadata (this=0x61200000bd40) at /d/p/latest/exiv2/src/jp2image.cpp:612
#4 0x00000000004c8776 in (anonymous namespace)::metacopy (source="./CVE-2018-20099.exv", tgt="CVE-2018-20099", targetType=targetType@entry=Exiv2::ImageType::none, preserve=preserve@entry=true) at /d/p/latest/exiv2/src/actions.cpp:2021
#5 0x00000000004ccd00 in Action::Insert::run (this=<optimized out>, path="CVE-2018-20099") at /d/p/latest/exiv2/src/actions.cpp:1163
#6 0x000000000040980c in main (argc=<optimized out>, argv=<optimized out>) at /d/p/latest/exiv2/src/exiv2.cpp:77
``` | CVE-2018-20099 infinite loop in Exiv2::Jp2Image::encodeJp2Header of jp2image.cpp | https://api.github.com/repos/Exiv2/exiv2/issues/950/comments | 4 | 2019-07-10T11:48:32 | "2021-08-26T17:05:42Z" | https://github.com/Exiv2/exiv2/issues/950 | 466,263,063 | 950 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : CVE-2018-20099 infinite loop in Exiv2::Jp2Image::encodeJp2Header of jp2image.cpp
Issue date:
--- start body ---
**Describe the bug**
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-20099
There is an infinite loop in Exiv2::Jp2Image::encodeJp2Header of jp2image.cpp in Exiv2 0.27-RC3. A crafted input will lead to a remote denial of service attack.
This has been reported in #590 , but @piponazo ignored due to not `cp CVE-2018-20099 CVE-2018-20099.exv`
This CVE has not been fixed on current commit `1de8e734`
**To Reproduce**
Steps to reproduce the behaviour:
1. download the [POC file](https://github.com/TeamSeri0us/pocs/raw/master/exiv2/20181206/jp2image-infiniteloop-poc-5)
2. Provide exact command to reproduce the issue
```
wget https://github.com/TeamSeri0us/pocs/raw/master/exiv2/20181206/jp2image-infiniteloop-poc-5
mv jp2image-infiniteloop-poc-5 CVE-2018-20099
cp CVE-2018-20099 CVE-2018-20099.exv
./exiv2 insert CVE-2018-20099
```
**Expected behavior**
infinite loop
**Desktop (please complete the following information):**
- OS: Ubuntu 16.04
- Compiler & Version gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.11)
- Compilation mode and/or compiler flags: using afl-gcc and ASAN
**Additional context**
press `Ctrl+Break` to let gdb break
```
root@66b85dd83778:/d/cvepoc/exiv2# gdb /d/p/latest/1.exiv2
GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.5) 7.11.1
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /d/p/latest/1.exiv2...done.
(gdb) r insert CVE-2018-20099
Starting program: /d/p/latest/1.exiv2 insert CVE-2018-20099
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
^C
Program received signal SIGINT, Interrupt.
0x00007ffff64e4820 in Exiv2::getLong (buf=0x7fffffffb534 "olr\001", byteOrder=<optimized out>) at /d/p/latest/exiv2/src/types.cpp:339
339 | (byte)buf[2] << 8 | (byte)buf[3];
(gdb) bt
#0 0x00007ffff64e4820 in Exiv2::getLong (buf=0x7fffffffb534 "olr\001", byteOrder=<optimized out>) at /d/p/latest/exiv2/src/types.cpp:339
#1 0x00000ffffffff6a6 in ?? ()
#2 0x000000006f6c7201 in ?? ()
#3 0x0000000000000000 in ?? ()
(gdb) list
334 return (byte)buf[3] << 24 | (byte)buf[2] << 16
335 | (byte)buf[1] << 8 | (byte)buf[0];
336 }
337 else {
338 return (byte)buf[0] << 24 | (byte)buf[1] << 16
339 | (byte)buf[2] << 8 | (byte)buf[3];
340 }
341 }
342
343 Rational getRational(const byte* buf, ByteOrder byteOrder)
(gdb) finish
Run till exit from #0 0x00007ffff64e4820 in Exiv2::getLong (buf=0x7fffffffb534 "olr\001", byteOrder=<optimized out>) at /d/p/latest/exiv2/src/types.cpp:339
^C
Program received signal SIGINT, Interrupt.
0x00007ffff6ef65ed in __asan_memcpy () from /usr/lib/x86_64-linux-gnu/libasan.so.2
(gdb) bt
#0 0x00007ffff6ef65ed in __asan_memcpy () from /usr/lib/x86_64-linux-gnu/libasan.so.2
#1 0x00007ffff63f51a1 in Exiv2::Jp2Image::encodeJp2Header (this=this@entry=0x61200000bd40, boxBuf=..., outBuf=...) at /d/p/latest/exiv2/src/jp2image.cpp:678
#2 0x00007ffff63f752f in Exiv2::Jp2Image::doWriteMetadata (this=this@entry=0x61200000bd40, outIo=...) at /d/p/latest/exiv2/src/jp2image.cpp:789
#3 0x00007ffff6403c0b in Exiv2::Jp2Image::writeMetadata (this=0x61200000bd40) at /d/p/latest/exiv2/src/jp2image.cpp:612
#4 0x00000000004c8776 in (anonymous namespace)::metacopy (source="./CVE-2018-20099.exv", tgt="CVE-2018-20099", targetType=targetType@entry=Exiv2::ImageType::none, preserve=preserve@entry=true) at /d/p/latest/exiv2/src/actions.cpp:2021
#5 0x00000000004ccd00 in Action::Insert::run (this=<optimized out>, path="CVE-2018-20099") at /d/p/latest/exiv2/src/actions.cpp:1163
#6 0x000000000040980c in main (argc=<optimized out>, argv=<optimized out>) at /d/p/latest/exiv2/src/exiv2.cpp:77
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,774 | 207,820 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
GNOME Photos crashes at launch because one of its dependency, gexiv2, calls an Exiv2 function which throws an exception.
**To Reproduce**
The example program posted at https://github.com/Exiv2/exiv2/issues/644#issuecomment-452472029 is probably the most simple way to reproduce the problem. It seems to come from [`gexiv2_metadata_register_xmp_namespace` function of gexiv2](https://gitlab.gnome.org/GNOME/gexiv2/blob/gexiv2-0.12.0/gexiv2/gexiv2-metadata-xmp.cpp#L402) and it is where GNOME Photos crashes.
**Expected behavior**
No crash should happen because the exception is caught.
**Desktop:**
- Exiv2 0.27.1
- FreeBSD 12.0
- Clang 6.0.1
**Additional context**
I am not sure if I understand the problem correctly, so I just post all of my findings here. This probably makes the issue description longer than it needs, but I hope the information will be helpful for you to understand the problem if you aren't going to test Exiv2 on FreeBSD.
This is what I saw when running GNOME Photos. It just crashes without printing any message.
```
$ gnome-photos
Abort trap (core dumped)
$ gdb gnome-photos gnome-photos.core
...
Core was generated by `gnome-photos'.
Program terminated with signal SIGABRT, Aborted.
(gdb) bt
#0 thr_kill () at thr_kill.S:3
#1 0x0000000801b68844 in __raise (s=6) at /usr/src/lib/libc/gen/raise.c:52
#2 0x0000000801adb079 in abort () at /usr/src/lib/libc/stdlib/abort.c:67
#3 0x00000008023d98ba in report_failure (err=<optimized out>, thrown_exception=0x80aefcc08) at /usr/src/contrib/libcxxrt/exception.cc:719
#4 0x000000080224fc01 in Exiv2::XmpProperties::nsInfoUnsafe (prefix="gnome") at /home/lantw44/gnome/source/exiv2/src/properties.cpp:2659
#5 0x000000080224fafb in Exiv2::XmpProperties::ns (prefix="gnome") at /home/lantw44/gnome/source/exiv2/src/properties.cpp:2586
#6 0x00000008004fcad2 in gexiv2_metadata_register_xmp_namespace (name=0x209d5a "http://www.gnome.org/xmp", prefix=0x20d1d6 "gnome") at ../../source/gexiv2/gexiv2/gexiv2-metadata-xmp.cpp:407
#7 0x000000000028168b in photos_application_create_window (self=0x8043381f0) at photos-application.c:813
#8 0x000000000027ff22 in photos_application_activate (application=<optimized out>) at photos-application.c:2436
#9 0x000000080172738d in _g_closure_invoke_va (closure=0x8009ff8e0, return_value=0x0, instance=0x8043381f0, args=<optimized out>, n_params=0, param_types=0x0) at ../../source/glib/gobject/gclosure.c:873
#10 0x000000080173b23b in g_signal_emit_valist (instance=0x8043381f0, signal_id=<optimized out>, detail=0, var_args=0x7fffffffd430) at ../../source/glib/gobject/gsignal.c:3306
#11 0x000000080173bba4 in g_signal_emit (instance=0x188ea, signal_id=6, detail=0) at ../../source/glib/gobject/gsignal.c:3453
#12 0x000000000027ffd8 in photos_application_command_line (application=0x8043381f0, command_line=0x8076e3340) at photos-application.c:2468
#13 0x000000080163dcfc in _g_cclosure_marshal_INT__OBJECTv (closure=0x8009ff920, return_value=0x7fffffffd550, instance=0x8043381f0, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>,
param_types=0x80033e0e8) at ../../source/glib/gio/gmarshal-internal.c:845
#14 0x000000080172738d in _g_closure_invoke_va (closure=0x8009ff920, return_value=0x7fffffffd550, instance=0x8043381f0, args=<optimized out>, n_params=1, param_types=0x80033e0e8)
at ../../source/glib/gobject/gclosure.c:873
#15 0x000000080173b23b in g_signal_emit_valist (instance=0x8043381f0, signal_id=<optimized out>, detail=0, var_args=0x7fffffffd740) at ../../source/glib/gobject/gsignal.c:3306
#16 0x000000080173bba4 in g_signal_emit (instance=0x188ea, signal_id=6, detail=0) at ../../source/glib/gobject/gsignal.c:3453
#17 0x000000080168fb17 in g_application_call_command_line (application=0x8043381f0, arguments=<optimized out>, options=<optimized out>, exit_status=0x7fffffffd814) at ../../source/glib/gio/gapplication.c:1076
#18 0x00000008016911cb in g_application_real_local_command_line (application=0x8043381f0, arguments=<optimized out>, exit_status=0x7fffffffd814) at ../../source/glib/gio/gapplication.c:1130
#19 0x000000080168f8b5 in g_application_run (application=0x8043381f0, argc=1, argv=0x7fffffffd8f8) at ../../source/glib/gio/gapplication.c:2523
#20 0x00000000002da87a in main (argc=1, argv=0x7fffffffd8f8) at photos-main.c:61
```
I quickly found a way to avoid the crash based on commit 04c9b181cc2c7741fcb134ccc43f2bafc1f86f19.
```diff
diff --git a/cmake/mainSetup.cmake b/cmake/mainSetup.cmake
index a4d983d4..1de6324c 100644
--- a/cmake/mainSetup.cmake
+++ b/cmake/mainSetup.cmake
@@ -13,7 +13,9 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
-if (NOT CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+if (NOT ((CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang") OR
+ (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
+ CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")))
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(CMAKE_VISIBILITY_INLINES_HIDDEN 1)
endif()
```
But this isn't a solution. It is just a workaround because it effectively disables visibility control.
In src/properties.cpp, function `XmpProperties::nsInfoUnsafe`:
```cpp
const XmpNsInfo* XmpProperties::nsInfoUnsafe(const std::string& prefix)
{
const XmpNsInfo::Prefix pf(prefix);
const XmpNsInfo* xn = lookupNsRegistryUnsafe(pf);
if (!xn) xn = find(xmpNsInfo, pf);
if (!xn) throw Error(kerNoNamespaceInfoForXmpPrefix, prefix);
return xn;
}
```
It was the `throw` line that crashed the program. By using GDB, I found the execution of `throw` began at an internal function [`__cxa_throw` defined in /usr/src/contrib/libcxxrt/exception.cc](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l782). It then called [`throw_exception` defined in the same file](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l759) to continue the process.
```cpp
static void throw_exception(__cxa_exception *ex)
{
// [snip]
_Unwind_Reason_Code err = _Unwind_RaiseException(&ex->unwindHeader);
// The _Unwind_RaiseException() function should not return, it should
// unwind the stack past this function. If it does return, then something
// has gone wrong.
report_failure(err, ex);
}
```
This was where `report_failure` in the crash dump came from. GDB told me `err` was `_URC_END_OF_STACK`, which suggested that libunwind couldn't find the function catching the exception.
There is an environment variable called `LIBUNWIND_PRINT_UNWINDING` which can be used to debug libunwind. In a working build, it successfully found the function catching the exception was `gexiv2_metadata_register_xmp_namespace`:
```
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): pc=0x802466416, start_ip=0x802466370, func=__cxa_throw, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): pc=0x8022cff61, start_ip=0x8022cfed0, func=_ZN5Exiv213XmpProperties12nsInfoUnsafeERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE, lsda=0x8020824e4, personality=0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): calling personality function 0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): pc=0x8022cfe5b, start_ip=0x8022cfde0, func=_ZN5Exiv213XmpProperties2nsERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE, lsda=0x802082470, personality=0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): calling personality function 0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): pc=0x8004fcad2, start_ip=0x8004fca80, func=gexiv2_metadata_register_xmp_namespace, lsda=0x8004e2d98, personality=0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): calling personality function 0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): _URC_HANDLER_FOUND
```
In a broken build, it couldn't find the function. The function `gexiv2_metadata_register_xmp_namespace` existed in the call stack, but it seemed to ignore it.
```
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x8023d9416, start_ip=0x8023d9370, func=__cxa_throw, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80224fc01, start_ip=0x80224fb70, func=_ZN5Exiv213XmpProperties12nsInfoUnsafeERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE, lsda=0x8020824e4, personality=0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): calling personality function 0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80224fafb, start_ip=0x80224fa80, func=_ZN5Exiv213XmpProperties2nsERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE, lsda=0x802082470, personality=0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): calling personality function 0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x8004fcad2, start_ip=0x8004fca80, func=gexiv2_metadata_register_xmp_namespace, lsda=0x8004e2d98, personality=0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): calling personality function 0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x28168b, start_ip=0x281640, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x27ff22, start_ip=0x27fef0, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80172738d, start_ip=0x8017272c0, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80173b23b, start_ip=0x80173aec0, func=g_signal_emit_valist, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80173bba4, start_ip=0x80173bb30, func=g_signal_emit, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x27ffd8, start_ip=0x27ff70, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80163dcfc, start_ip=0x80163dc70, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80172738d, start_ip=0x8017272c0, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80173b23b, start_ip=0x80173aec0, func=g_signal_emit_valist, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80173bba4, start_ip=0x80173bb30, func=g_signal_emit, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80168fb17, start_ip=0x80168faa0, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x8016911cb, start_ip=0x801691080, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80168f8b5, start_ip=0x80168f790, func=g_application_run, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x2da87a, start_ip=0x2da820, func=main, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x27f11b, start_ip=0x27f000, func=_start, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): unw_step() reached bottom => _URC_END_OF_STACK
````
Therefore, I followed the execution of `_Unwind_RaiseException` in order to find why the visibility control broke it. [`_Unwind_RaiseException` is defined in /usr/src/contrib/llvm/projects/libunwind/src/UnwindLevel1.c](https://svnweb.freebsd.org/base/releng/12.0/contrib/llvm/projects/libunwind/src/UnwindLevel1.c?view=markup#l340). It then called [`unwind_phase1` defined in the same file](https://svnweb.freebsd.org/base/releng/12.0/contrib/llvm/projects/libunwind/src/UnwindLevel1.c?view=markup#l35) to search the stack.
```cpp
// If there is a personality routine, ask it if it will want to stop at
// this frame.
if (frameInfo.handler != 0) {
__personality_routine p =
(__personality_routine)(long)(frameInfo.handler);
_LIBUNWIND_TRACE_UNWINDING(
"unwind_phase1(ex_ojb=%p): calling personality function %p",
(void *)exception_object, (void *)(uintptr_t)p);
_Unwind_Reason_Code personalityResult =
(*p)(1, _UA_SEARCH_PHASE, exception_object->exception_class,
exception_object, (struct _Unwind_Context *)(cursor));
switch (personalityResult) {
case _URC_HANDLER_FOUND:
// [snip]
case _URC_CONTINUE_UNWIND:
// [snip]
}
```
The key is the value of `personalityResult` here. In a working build, `_URC_HANDLER_FOUND` stopped the search. In a broken build, it was always `_URC_CONTINUE_UNWIND` until it reached the end of the stack. `personalityResult` was the return value of function pointer `p`, and `p` was [`__gxx_personality_v0` defined in /usr/src/contrib/libcxxrt/exception.cc](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l1071).
It turned out `_URC_HANDLER_FOUND` was returned from here in a working build:
```cpp
handler_type found_handler = check_action_record(context, &lsda,
action.action_record, realEx, &selector, ex->adjustedPtr);
// If there's no action record, we've only found a cleanup, so keep
// searching for something real
if (found_handler == handler_catch)
{
// Cache the results for the phase 2 unwind, if we found a handler
// and this is not a foreign exception.
if (ex)
{
saveLandingPad(context, exceptionObject, ex, selector, action.landing_pad);
ex->languageSpecificData = reinterpret_cast<const char*>(lsda_addr);
ex->actionRecord = reinterpret_cast<const char*>(action.action_record);
// ex->adjustedPtr is set when finding the action record.
}
return _URC_HANDLER_FOUND;
}
```
[`check_action_record` is defined in the same file](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l971):
```cpp
// We only check handler types for C++ exceptions - foreign exceptions
// are only allowed for cleanups and catchalls.
if (filter > 0)
{
std::type_info *handler_type = get_type_info_entry(context, lsda, filter);
if (check_type_signature(ex, handler_type, adjustedPtr))
{
*selector = filter;
return handler_catch;
}
}
```
`handler_type` was `typeinfo for Exiv2::BasicError<char>` in both working and broken build. The difference was the return value of [`check_type_signature`](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l923). In a working build, it returned `true`. In a broken build, it returned `false`.
```cpp
static bool check_type_signature(__cxa_exception *ex,
const std::type_info *type,
void *&adjustedPtr)
{
// [snip]
// If the types are the same, no casting is needed.
if (*type == *ex_type)
{
adjustedPtr = exception_ptr;
return true; // <- It should return from here.
}
if (type->__do_catch(ex_type, &exception_ptr, 1))
{
adjustedPtr = exception_ptr;
return true;
}
return false; // <- But a broken build returned from here.
}
```
The result suggested it was the visibility problem of `typeinfo for Exiv2::BasicError<char>` that caused the crash. In a broken build, `typeinfo for Exiv2::BasicError<char>` couldn't be found in the output of `nm -DC`. In a working build, it was there and it was marked as `V`, a weak object.
Finally, I got a working build with this patch:
```diff
diff --git a/include/exiv2/error.hpp b/include/exiv2/error.hpp
index 42a0959c..bd74c449 100644
--- a/include/exiv2/error.hpp
+++ b/include/exiv2/error.hpp
@@ -260,7 +260,7 @@ namespace Exiv2 {
provided to print errors to a stream.
*/
template<typename charT>
- class BasicError : public AnyError {
+ class EXIV2API BasicError : public AnyError {
public:
//! @name Creators
//@{
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 34087004..df041890 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -145,7 +145,7 @@ endif()
set_target_properties( exiv2lib_int PROPERTIES
POSITION_INDEPENDENT_CODE ON
- COMPILE_DEFINITIONS exiv2lib_STATIC
+# COMPILE_DEFINITIONS exiv2lib_STATIC
)
```
Both changes are required for `typeinfo for Exiv2::BasicError<char>` to be exported. If I only modified `include/exiv2/error.hpp`, files belonging to `exiv2lib_int` will hide it because `EXIV2API` expands to nothing when `exiv2lib_STATIC` is defined.
It can be found by using `readelf -aW` on `.o` files and searching for `_ZTIN5Exiv210BasicErrorIcEE`, the mangled name of `typeinfo for Exiv2::BasicError<char>`. In src/CMakeFiles/exiv2.dir and src/CMakeFiles/exiv2lib.dir, they are 'WEAK DEFAULT', which is fine. However, in src/CMakeFiles/exiv2lib_int.dir, they are 'WEAK HIDDEN'. The result is that the symbol became 'LOCAL HIDDEN' in the linked shared library, preventing it from being used from other libraries or programs. If `exiv2lib_STATIC` is removed, all objects have 'WEAK DEFAULT', so the linked shared library also has 'WEAK DEFAULT'.
Here is the difference of dynamic symbols between the current upstream version and the version using the above patch.
```diff
--- broken 2019-07-06 01:43:00.523185000 +0800
+++ working 2019-07-06 12:20:05.783945000 +0800
@@ -1542,6 +1542,7 @@
V construction vtable for std::__1::basic_ostream<char, std::__1::char_traits<char> >-in-std::__1::basic_ofstream<char, std::__1::char_traits<char> >
V construction vtable for std::__1::basic_ostream<char, std::__1::char_traits<char> >-in-std::__1::basic_ostringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V construction vtable for std::__1::basic_ostream<char, std::__1::char_traits<char> >-in-std::__1::basic_stringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
+V typeinfo for Exiv2::BasicError<char>
V typeinfo for Exiv2::HttpIo
V typeinfo for Exiv2::IoCloser
V typeinfo for std::__1::basic_filebuf<char, std::__1::char_traits<char> >
@@ -1550,6 +1551,7 @@
V typeinfo for std::__1::basic_ostringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V typeinfo for std::__1::basic_stringbuf<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V typeinfo for std::__1::basic_stringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
+V typeinfo name for Exiv2::BasicError<char>
V typeinfo name for Exiv2::HttpIo
V typeinfo name for Exiv2::IoCloser
V typeinfo name for std::__1::basic_filebuf<char, std::__1::char_traits<char> >
@@ -1558,6 +1560,7 @@
V typeinfo name for std::__1::basic_ostringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V typeinfo name for std::__1::basic_stringbuf<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V typeinfo name for std::__1::basic_stringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
+V vtable for Exiv2::BasicError<char>
V vtable for Exiv2::HttpIo
V vtable for Exiv2::IoCloser
V vtable for std::__1::basic_filebuf<char, std::__1::char_traits<char> >
@@ -1572,5 +1575,44 @@
V VTT for std::__1::basic_stringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
w __cxa_finalize
w _Jv_RegisterClasses
+W Exiv2::BasicError<char>::~BasicError()
+W Exiv2::BasicError<char>::~BasicError()
+W Exiv2::BasicError<char>::BasicError(Exiv2::ErrorCode)
+W Exiv2::BasicError<char>::BasicError<char [10]>(Exiv2::ErrorCode, char const (&) [10])
+W Exiv2::BasicError<char>::BasicError<char [109]>(Exiv2::ErrorCode, char const (&) [109])
+W Exiv2::BasicError<char>::BasicError<char [11]>(Exiv2::ErrorCode, char const (&) [11])
+W Exiv2::BasicError<char>::BasicError<char [13]>(Exiv2::ErrorCode, char const (&) [13])
+W Exiv2::BasicError<char>::BasicError<char [14], char [10]>(Exiv2::ErrorCode, char const (&) [14], char const (&) [10])
+W Exiv2::BasicError<char>::BasicError<char [14], char [4]>(Exiv2::ErrorCode, char const (&) [14], char const (&) [4])
+W Exiv2::BasicError<char>::BasicError<char [14], char [5]>(Exiv2::ErrorCode, char const (&) [14], char const (&) [5])
+W Exiv2::BasicError<char>::BasicError<char [15]>(Exiv2::ErrorCode, char const (&) [15])
+W Exiv2::BasicError<char>::BasicError<char [21]>(Exiv2::ErrorCode, char const (&) [21])
+W Exiv2::BasicError<char>::BasicError<char [24]>(Exiv2::ErrorCode, char const (&) [24])
+W Exiv2::BasicError<char>::BasicError<char [26]>(Exiv2::ErrorCode, char const (&) [26])
+W Exiv2::BasicError<char>::BasicError<char [37]>(Exiv2::ErrorCode, char const (&) [37])
+W Exiv2::BasicError<char>::BasicError<char [4]>(Exiv2::ErrorCode, char const (&) [4])
+W Exiv2::BasicError<char>::BasicError<char [5]>(Exiv2::ErrorCode, char const (&) [5])
+W Exiv2::BasicError<char>::BasicError<char [53]>(Exiv2::ErrorCode, char const (&) [53])
+W Exiv2::BasicError<char>::BasicError<char [7], int>(Exiv2::ErrorCode, char const (&) [7], int const&)
+W Exiv2::BasicError<char>::BasicError<char [7], long>(Exiv2::ErrorCode, char const (&) [7], long const&)
+W Exiv2::BasicError<char>::BasicError<char const*>(Exiv2::ErrorCode, char const* const&)
+W Exiv2::BasicError<char>::BasicError<char*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [7]>(Exiv2::ErrorCode, char* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [7])
+W Exiv2::BasicError<char>::BasicError<char*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [8]>(Exiv2::ErrorCode, char* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [8])
+W Exiv2::BasicError<char>::BasicError<char*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [9]>(Exiv2::ErrorCode, char* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [9])
+W Exiv2::BasicError<char>::BasicError<int>(Exiv2::ErrorCode, int const&)
+W Exiv2::BasicError<char>::BasicError<long, char const*>(Exiv2::ErrorCode, long const&, char const* const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [3], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [3], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [4], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [4], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char const*>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const* const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [13]>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [13])
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [5]>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [5])
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [7]>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [7])
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, unsigned long>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long const&)
+W Exiv2::BasicError<char>::code() const
+W Exiv2::BasicError<char>::what() const
W Exiv2::Xmpdatum& Exiv2::Xmpdatum::operator=<char [30]>(char const (&) [30])
W Exiv2::Xmpdatum& Exiv2::Xmpdatum::operator=<int>(int const&)
```
Do you think it is OK to export `BasicError`? I think the use of `exiv2lib_STATIC` here may be incorrect because `exiv2lib_int` gets linked into a shared library, but it isn't a library which is intended to be linked staticlly into other programs. | Throwing an exception crashes a program on FreeBSD because typeinfo for BasicError<char> isn't exported | https://api.github.com/repos/Exiv2/exiv2/issues/947/comments | 17 | 2019-07-06T07:43:31 | "2019-07-18T12:26:08Z" | https://github.com/Exiv2/exiv2/issues/947 | 464,828,696 | 947 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Throwing an exception crashes a program on FreeBSD because typeinfo for BasicError<char> isn't exported
Issue date:
--- start body ---
**Describe the bug**
GNOME Photos crashes at launch because one of its dependency, gexiv2, calls an Exiv2 function which throws an exception.
**To Reproduce**
The example program posted at https://github.com/Exiv2/exiv2/issues/644#issuecomment-452472029 is probably the most simple way to reproduce the problem. It seems to come from [`gexiv2_metadata_register_xmp_namespace` function of gexiv2](https://gitlab.gnome.org/GNOME/gexiv2/blob/gexiv2-0.12.0/gexiv2/gexiv2-metadata-xmp.cpp#L402) and it is where GNOME Photos crashes.
**Expected behavior**
No crash should happen because the exception is caught.
**Desktop:**
- Exiv2 0.27.1
- FreeBSD 12.0
- Clang 6.0.1
**Additional context**
I am not sure if I understand the problem correctly, so I just post all of my findings here. This probably makes the issue description longer than it needs, but I hope the information will be helpful for you to understand the problem if you aren't going to test Exiv2 on FreeBSD.
This is what I saw when running GNOME Photos. It just crashes without printing any message.
```
$ gnome-photos
Abort trap (core dumped)
$ gdb gnome-photos gnome-photos.core
...
Core was generated by `gnome-photos'.
Program terminated with signal SIGABRT, Aborted.
(gdb) bt
#0 thr_kill () at thr_kill.S:3
#1 0x0000000801b68844 in __raise (s=6) at /usr/src/lib/libc/gen/raise.c:52
#2 0x0000000801adb079 in abort () at /usr/src/lib/libc/stdlib/abort.c:67
#3 0x00000008023d98ba in report_failure (err=<optimized out>, thrown_exception=0x80aefcc08) at /usr/src/contrib/libcxxrt/exception.cc:719
#4 0x000000080224fc01 in Exiv2::XmpProperties::nsInfoUnsafe (prefix="gnome") at /home/lantw44/gnome/source/exiv2/src/properties.cpp:2659
#5 0x000000080224fafb in Exiv2::XmpProperties::ns (prefix="gnome") at /home/lantw44/gnome/source/exiv2/src/properties.cpp:2586
#6 0x00000008004fcad2 in gexiv2_metadata_register_xmp_namespace (name=0x209d5a "http://www.gnome.org/xmp", prefix=0x20d1d6 "gnome") at ../../source/gexiv2/gexiv2/gexiv2-metadata-xmp.cpp:407
#7 0x000000000028168b in photos_application_create_window (self=0x8043381f0) at photos-application.c:813
#8 0x000000000027ff22 in photos_application_activate (application=<optimized out>) at photos-application.c:2436
#9 0x000000080172738d in _g_closure_invoke_va (closure=0x8009ff8e0, return_value=0x0, instance=0x8043381f0, args=<optimized out>, n_params=0, param_types=0x0) at ../../source/glib/gobject/gclosure.c:873
#10 0x000000080173b23b in g_signal_emit_valist (instance=0x8043381f0, signal_id=<optimized out>, detail=0, var_args=0x7fffffffd430) at ../../source/glib/gobject/gsignal.c:3306
#11 0x000000080173bba4 in g_signal_emit (instance=0x188ea, signal_id=6, detail=0) at ../../source/glib/gobject/gsignal.c:3453
#12 0x000000000027ffd8 in photos_application_command_line (application=0x8043381f0, command_line=0x8076e3340) at photos-application.c:2468
#13 0x000000080163dcfc in _g_cclosure_marshal_INT__OBJECTv (closure=0x8009ff920, return_value=0x7fffffffd550, instance=0x8043381f0, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>,
param_types=0x80033e0e8) at ../../source/glib/gio/gmarshal-internal.c:845
#14 0x000000080172738d in _g_closure_invoke_va (closure=0x8009ff920, return_value=0x7fffffffd550, instance=0x8043381f0, args=<optimized out>, n_params=1, param_types=0x80033e0e8)
at ../../source/glib/gobject/gclosure.c:873
#15 0x000000080173b23b in g_signal_emit_valist (instance=0x8043381f0, signal_id=<optimized out>, detail=0, var_args=0x7fffffffd740) at ../../source/glib/gobject/gsignal.c:3306
#16 0x000000080173bba4 in g_signal_emit (instance=0x188ea, signal_id=6, detail=0) at ../../source/glib/gobject/gsignal.c:3453
#17 0x000000080168fb17 in g_application_call_command_line (application=0x8043381f0, arguments=<optimized out>, options=<optimized out>, exit_status=0x7fffffffd814) at ../../source/glib/gio/gapplication.c:1076
#18 0x00000008016911cb in g_application_real_local_command_line (application=0x8043381f0, arguments=<optimized out>, exit_status=0x7fffffffd814) at ../../source/glib/gio/gapplication.c:1130
#19 0x000000080168f8b5 in g_application_run (application=0x8043381f0, argc=1, argv=0x7fffffffd8f8) at ../../source/glib/gio/gapplication.c:2523
#20 0x00000000002da87a in main (argc=1, argv=0x7fffffffd8f8) at photos-main.c:61
```
I quickly found a way to avoid the crash based on commit 04c9b181cc2c7741fcb134ccc43f2bafc1f86f19.
```diff
diff --git a/cmake/mainSetup.cmake b/cmake/mainSetup.cmake
index a4d983d4..1de6324c 100644
--- a/cmake/mainSetup.cmake
+++ b/cmake/mainSetup.cmake
@@ -13,7 +13,9 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
-if (NOT CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+if (NOT ((CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang") OR
+ (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
+ CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")))
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(CMAKE_VISIBILITY_INLINES_HIDDEN 1)
endif()
```
But this isn't a solution. It is just a workaround because it effectively disables visibility control.
In src/properties.cpp, function `XmpProperties::nsInfoUnsafe`:
```cpp
const XmpNsInfo* XmpProperties::nsInfoUnsafe(const std::string& prefix)
{
const XmpNsInfo::Prefix pf(prefix);
const XmpNsInfo* xn = lookupNsRegistryUnsafe(pf);
if (!xn) xn = find(xmpNsInfo, pf);
if (!xn) throw Error(kerNoNamespaceInfoForXmpPrefix, prefix);
return xn;
}
```
It was the `throw` line that crashed the program. By using GDB, I found the execution of `throw` began at an internal function [`__cxa_throw` defined in /usr/src/contrib/libcxxrt/exception.cc](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l782). It then called [`throw_exception` defined in the same file](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l759) to continue the process.
```cpp
static void throw_exception(__cxa_exception *ex)
{
// [snip]
_Unwind_Reason_Code err = _Unwind_RaiseException(&ex->unwindHeader);
// The _Unwind_RaiseException() function should not return, it should
// unwind the stack past this function. If it does return, then something
// has gone wrong.
report_failure(err, ex);
}
```
This was where `report_failure` in the crash dump came from. GDB told me `err` was `_URC_END_OF_STACK`, which suggested that libunwind couldn't find the function catching the exception.
There is an environment variable called `LIBUNWIND_PRINT_UNWINDING` which can be used to debug libunwind. In a working build, it successfully found the function catching the exception was `gexiv2_metadata_register_xmp_namespace`:
```
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): pc=0x802466416, start_ip=0x802466370, func=__cxa_throw, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): pc=0x8022cff61, start_ip=0x8022cfed0, func=_ZN5Exiv213XmpProperties12nsInfoUnsafeERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE, lsda=0x8020824e4, personality=0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): calling personality function 0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): pc=0x8022cfe5b, start_ip=0x8022cfde0, func=_ZN5Exiv213XmpProperties2nsERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE, lsda=0x802082470, personality=0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): calling personality function 0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): pc=0x8004fcad2, start_ip=0x8004fca80, func=gexiv2_metadata_register_xmp_namespace, lsda=0x8004e2d98, personality=0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): calling personality function 0x802466a60
libunwind: unwind_phase1(ex_ojb=0x80b08fa60): _URC_HANDLER_FOUND
```
In a broken build, it couldn't find the function. The function `gexiv2_metadata_register_xmp_namespace` existed in the call stack, but it seemed to ignore it.
```
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x8023d9416, start_ip=0x8023d9370, func=__cxa_throw, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80224fc01, start_ip=0x80224fb70, func=_ZN5Exiv213XmpProperties12nsInfoUnsafeERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE, lsda=0x8020824e4, personality=0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): calling personality function 0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80224fafb, start_ip=0x80224fa80, func=_ZN5Exiv213XmpProperties2nsERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE, lsda=0x802082470, personality=0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): calling personality function 0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x8004fcad2, start_ip=0x8004fca80, func=gexiv2_metadata_register_xmp_namespace, lsda=0x8004e2d98, personality=0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): calling personality function 0x8023d9a60
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): _URC_CONTINUE_UNWIND
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x28168b, start_ip=0x281640, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x27ff22, start_ip=0x27fef0, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80172738d, start_ip=0x8017272c0, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80173b23b, start_ip=0x80173aec0, func=g_signal_emit_valist, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80173bba4, start_ip=0x80173bb30, func=g_signal_emit, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x27ffd8, start_ip=0x27ff70, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80163dcfc, start_ip=0x80163dc70, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80172738d, start_ip=0x8017272c0, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80173b23b, start_ip=0x80173aec0, func=g_signal_emit_valist, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80173bba4, start_ip=0x80173bb30, func=g_signal_emit, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80168fb17, start_ip=0x80168faa0, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x8016911cb, start_ip=0x801691080, func=.anonymous., lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x80168f8b5, start_ip=0x80168f790, func=g_application_run, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x2da87a, start_ip=0x2da820, func=main, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): pc=0x27f11b, start_ip=0x27f000, func=_start, lsda=0x0, personality=0x0
libunwind: unwind_phase1(ex_ojb=0x80bb5ce60): unw_step() reached bottom => _URC_END_OF_STACK
````
Therefore, I followed the execution of `_Unwind_RaiseException` in order to find why the visibility control broke it. [`_Unwind_RaiseException` is defined in /usr/src/contrib/llvm/projects/libunwind/src/UnwindLevel1.c](https://svnweb.freebsd.org/base/releng/12.0/contrib/llvm/projects/libunwind/src/UnwindLevel1.c?view=markup#l340). It then called [`unwind_phase1` defined in the same file](https://svnweb.freebsd.org/base/releng/12.0/contrib/llvm/projects/libunwind/src/UnwindLevel1.c?view=markup#l35) to search the stack.
```cpp
// If there is a personality routine, ask it if it will want to stop at
// this frame.
if (frameInfo.handler != 0) {
__personality_routine p =
(__personality_routine)(long)(frameInfo.handler);
_LIBUNWIND_TRACE_UNWINDING(
"unwind_phase1(ex_ojb=%p): calling personality function %p",
(void *)exception_object, (void *)(uintptr_t)p);
_Unwind_Reason_Code personalityResult =
(*p)(1, _UA_SEARCH_PHASE, exception_object->exception_class,
exception_object, (struct _Unwind_Context *)(cursor));
switch (personalityResult) {
case _URC_HANDLER_FOUND:
// [snip]
case _URC_CONTINUE_UNWIND:
// [snip]
}
```
The key is the value of `personalityResult` here. In a working build, `_URC_HANDLER_FOUND` stopped the search. In a broken build, it was always `_URC_CONTINUE_UNWIND` until it reached the end of the stack. `personalityResult` was the return value of function pointer `p`, and `p` was [`__gxx_personality_v0` defined in /usr/src/contrib/libcxxrt/exception.cc](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l1071).
It turned out `_URC_HANDLER_FOUND` was returned from here in a working build:
```cpp
handler_type found_handler = check_action_record(context, &lsda,
action.action_record, realEx, &selector, ex->adjustedPtr);
// If there's no action record, we've only found a cleanup, so keep
// searching for something real
if (found_handler == handler_catch)
{
// Cache the results for the phase 2 unwind, if we found a handler
// and this is not a foreign exception.
if (ex)
{
saveLandingPad(context, exceptionObject, ex, selector, action.landing_pad);
ex->languageSpecificData = reinterpret_cast<const char*>(lsda_addr);
ex->actionRecord = reinterpret_cast<const char*>(action.action_record);
// ex->adjustedPtr is set when finding the action record.
}
return _URC_HANDLER_FOUND;
}
```
[`check_action_record` is defined in the same file](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l971):
```cpp
// We only check handler types for C++ exceptions - foreign exceptions
// are only allowed for cleanups and catchalls.
if (filter > 0)
{
std::type_info *handler_type = get_type_info_entry(context, lsda, filter);
if (check_type_signature(ex, handler_type, adjustedPtr))
{
*selector = filter;
return handler_catch;
}
}
```
`handler_type` was `typeinfo for Exiv2::BasicError<char>` in both working and broken build. The difference was the return value of [`check_type_signature`](https://svnweb.freebsd.org/base/releng/12.0/contrib/libcxxrt/exception.cc?view=markup#l923). In a working build, it returned `true`. In a broken build, it returned `false`.
```cpp
static bool check_type_signature(__cxa_exception *ex,
const std::type_info *type,
void *&adjustedPtr)
{
// [snip]
// If the types are the same, no casting is needed.
if (*type == *ex_type)
{
adjustedPtr = exception_ptr;
return true; // <- It should return from here.
}
if (type->__do_catch(ex_type, &exception_ptr, 1))
{
adjustedPtr = exception_ptr;
return true;
}
return false; // <- But a broken build returned from here.
}
```
The result suggested it was the visibility problem of `typeinfo for Exiv2::BasicError<char>` that caused the crash. In a broken build, `typeinfo for Exiv2::BasicError<char>` couldn't be found in the output of `nm -DC`. In a working build, it was there and it was marked as `V`, a weak object.
Finally, I got a working build with this patch:
```diff
diff --git a/include/exiv2/error.hpp b/include/exiv2/error.hpp
index 42a0959c..bd74c449 100644
--- a/include/exiv2/error.hpp
+++ b/include/exiv2/error.hpp
@@ -260,7 +260,7 @@ namespace Exiv2 {
provided to print errors to a stream.
*/
template<typename charT>
- class BasicError : public AnyError {
+ class EXIV2API BasicError : public AnyError {
public:
//! @name Creators
//@{
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 34087004..df041890 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -145,7 +145,7 @@ endif()
set_target_properties( exiv2lib_int PROPERTIES
POSITION_INDEPENDENT_CODE ON
- COMPILE_DEFINITIONS exiv2lib_STATIC
+# COMPILE_DEFINITIONS exiv2lib_STATIC
)
```
Both changes are required for `typeinfo for Exiv2::BasicError<char>` to be exported. If I only modified `include/exiv2/error.hpp`, files belonging to `exiv2lib_int` will hide it because `EXIV2API` expands to nothing when `exiv2lib_STATIC` is defined.
It can be found by using `readelf -aW` on `.o` files and searching for `_ZTIN5Exiv210BasicErrorIcEE`, the mangled name of `typeinfo for Exiv2::BasicError<char>`. In src/CMakeFiles/exiv2.dir and src/CMakeFiles/exiv2lib.dir, they are 'WEAK DEFAULT', which is fine. However, in src/CMakeFiles/exiv2lib_int.dir, they are 'WEAK HIDDEN'. The result is that the symbol became 'LOCAL HIDDEN' in the linked shared library, preventing it from being used from other libraries or programs. If `exiv2lib_STATIC` is removed, all objects have 'WEAK DEFAULT', so the linked shared library also has 'WEAK DEFAULT'.
Here is the difference of dynamic symbols between the current upstream version and the version using the above patch.
```diff
--- broken 2019-07-06 01:43:00.523185000 +0800
+++ working 2019-07-06 12:20:05.783945000 +0800
@@ -1542,6 +1542,7 @@
V construction vtable for std::__1::basic_ostream<char, std::__1::char_traits<char> >-in-std::__1::basic_ofstream<char, std::__1::char_traits<char> >
V construction vtable for std::__1::basic_ostream<char, std::__1::char_traits<char> >-in-std::__1::basic_ostringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V construction vtable for std::__1::basic_ostream<char, std::__1::char_traits<char> >-in-std::__1::basic_stringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
+V typeinfo for Exiv2::BasicError<char>
V typeinfo for Exiv2::HttpIo
V typeinfo for Exiv2::IoCloser
V typeinfo for std::__1::basic_filebuf<char, std::__1::char_traits<char> >
@@ -1550,6 +1551,7 @@
V typeinfo for std::__1::basic_ostringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V typeinfo for std::__1::basic_stringbuf<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V typeinfo for std::__1::basic_stringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
+V typeinfo name for Exiv2::BasicError<char>
V typeinfo name for Exiv2::HttpIo
V typeinfo name for Exiv2::IoCloser
V typeinfo name for std::__1::basic_filebuf<char, std::__1::char_traits<char> >
@@ -1558,6 +1560,7 @@
V typeinfo name for std::__1::basic_ostringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V typeinfo name for std::__1::basic_stringbuf<char, std::__1::char_traits<char>, std::__1::allocator<char> >
V typeinfo name for std::__1::basic_stringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
+V vtable for Exiv2::BasicError<char>
V vtable for Exiv2::HttpIo
V vtable for Exiv2::IoCloser
V vtable for std::__1::basic_filebuf<char, std::__1::char_traits<char> >
@@ -1572,5 +1575,44 @@
V VTT for std::__1::basic_stringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >
w __cxa_finalize
w _Jv_RegisterClasses
+W Exiv2::BasicError<char>::~BasicError()
+W Exiv2::BasicError<char>::~BasicError()
+W Exiv2::BasicError<char>::BasicError(Exiv2::ErrorCode)
+W Exiv2::BasicError<char>::BasicError<char [10]>(Exiv2::ErrorCode, char const (&) [10])
+W Exiv2::BasicError<char>::BasicError<char [109]>(Exiv2::ErrorCode, char const (&) [109])
+W Exiv2::BasicError<char>::BasicError<char [11]>(Exiv2::ErrorCode, char const (&) [11])
+W Exiv2::BasicError<char>::BasicError<char [13]>(Exiv2::ErrorCode, char const (&) [13])
+W Exiv2::BasicError<char>::BasicError<char [14], char [10]>(Exiv2::ErrorCode, char const (&) [14], char const (&) [10])
+W Exiv2::BasicError<char>::BasicError<char [14], char [4]>(Exiv2::ErrorCode, char const (&) [14], char const (&) [4])
+W Exiv2::BasicError<char>::BasicError<char [14], char [5]>(Exiv2::ErrorCode, char const (&) [14], char const (&) [5])
+W Exiv2::BasicError<char>::BasicError<char [15]>(Exiv2::ErrorCode, char const (&) [15])
+W Exiv2::BasicError<char>::BasicError<char [21]>(Exiv2::ErrorCode, char const (&) [21])
+W Exiv2::BasicError<char>::BasicError<char [24]>(Exiv2::ErrorCode, char const (&) [24])
+W Exiv2::BasicError<char>::BasicError<char [26]>(Exiv2::ErrorCode, char const (&) [26])
+W Exiv2::BasicError<char>::BasicError<char [37]>(Exiv2::ErrorCode, char const (&) [37])
+W Exiv2::BasicError<char>::BasicError<char [4]>(Exiv2::ErrorCode, char const (&) [4])
+W Exiv2::BasicError<char>::BasicError<char [5]>(Exiv2::ErrorCode, char const (&) [5])
+W Exiv2::BasicError<char>::BasicError<char [53]>(Exiv2::ErrorCode, char const (&) [53])
+W Exiv2::BasicError<char>::BasicError<char [7], int>(Exiv2::ErrorCode, char const (&) [7], int const&)
+W Exiv2::BasicError<char>::BasicError<char [7], long>(Exiv2::ErrorCode, char const (&) [7], long const&)
+W Exiv2::BasicError<char>::BasicError<char const*>(Exiv2::ErrorCode, char const* const&)
+W Exiv2::BasicError<char>::BasicError<char*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [7]>(Exiv2::ErrorCode, char* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [7])
+W Exiv2::BasicError<char>::BasicError<char*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [8]>(Exiv2::ErrorCode, char* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [8])
+W Exiv2::BasicError<char>::BasicError<char*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [9]>(Exiv2::ErrorCode, char* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [9])
+W Exiv2::BasicError<char>::BasicError<int>(Exiv2::ErrorCode, int const&)
+W Exiv2::BasicError<char>::BasicError<long, char const*>(Exiv2::ErrorCode, long const&, char const* const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [3], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [3], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [4], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [4], std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char const*>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const* const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [13]>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [13])
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [5]>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [5])
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, char [7]>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const (&) [7])
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
+W Exiv2::BasicError<char>::BasicError<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, unsigned long>(Exiv2::ErrorCode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long const&)
+W Exiv2::BasicError<char>::code() const
+W Exiv2::BasicError<char>::what() const
W Exiv2::Xmpdatum& Exiv2::Xmpdatum::operator=<char [30]>(char const (&) [30])
W Exiv2::Xmpdatum& Exiv2::Xmpdatum::operator=<int>(int const&)
```
Do you think it is OK to export `BasicError`? I think the use of `exiv2lib_STATIC` here may be incorrect because `exiv2lib_int` gets linked into a shared library, but it isn't a library which is intended to be linked staticlly into other programs.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 28,291 | 207,821 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Looks like the whole space is called Sony2Fp which seems to stand for FocusPosistion.
Exif.Sony2Fp.AmbientTemperature SByte 1 18
Exif.Sony2Fp.FocusMode Byte 1 0
Exif.Sony2Fp.AFAreaMode Byte 1 255
Exif.Sony2Fp.FocusPosition2 Byte 1 235
Shouldn't this be just Exif.Sony2.*? | Why is Exif.Sony2Fp not just called Sony2? | https://api.github.com/repos/Exiv2/exiv2/issues/942/comments | 4 | 2019-07-01T11:43:32 | "2019-07-11T11:34:41Z" | https://github.com/Exiv2/exiv2/issues/942 | 462,666,991 | 942 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Why is Exif.Sony2Fp not just called Sony2?
Issue date:
--- start body ---
**Describe the bug**
Looks like the whole space is called Sony2Fp which seems to stand for FocusPosistion.
Exif.Sony2Fp.AmbientTemperature SByte 1 18
Exif.Sony2Fp.FocusMode Byte 1 0
Exif.Sony2Fp.AFAreaMode Byte 1 255
Exif.Sony2Fp.FocusPosition2 Byte 1 235
Shouldn't this be just Exif.Sony2.*?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 613 | 207,822 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Nominally, a test failure.
Practically, potentially a much worse issue.
**To Reproduce**
Steps to reproduce the behaviour:
1. Run the exiv2 testsuite on a non-x86 computer.
**Expected behavior**
test_run (bugfixes.github.test_CVE_2018_12265.AdditionOverflowInLoaderExifJpeg) ... OK
**Actual behaviour**
test_run (bugfixes.github.test_CVE_2018_12265.AdditionOverflowInLoaderExifJpeg) ... FAIL
**Desktop (please complete the following information):**
- OS: AdΓ©lie Linux 1.0-BETA3
- Compiler & Version: GCC 8.3.0
- Compilation mode and/or compiler flags:
- ppc64: `-O2 -ggdb -mcpu=970 -mtune=power9 -maltivec -mlong-double-64 -fno-inline-small-functions`
- ppc: `-O2 -ggdb -mcpu=G3 -fno-omit-frame-pointer -mfpu=dp_full`
- aarch64: `-O2 -ggdb -mtune=cortex-a53`
**Additional context**
```
======================================================================
FAIL: test_run (bugfixes.github.test_CVE_2018_12265.AdditionOverflowInLoaderExifJpeg)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/tests/system_tests.py", line 632, in test_run
self.compare_stderr(i, command, processed_stderr, stderr)
File "/usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/tests/system_tests.py", line 755, in compare_stderr
msg="Standard error does not match"
File "/usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/tests/system_tests.py", line 726, in _compare_output
expected, got, msg=msg
AssertionError: 'Erro[431 chars]uncating the entry\n' != 'Erro[431 chars]uncating the entry\nUncaught exception: Overflow in addition\n'
Error: Upper boundary of data for directory Image, entry 0x00fe is out of bounds: Offset = 0x0000002a, size = 64, exceeds buffer size by 22 Bytes; truncating the entry
Warning: Directory Image, entry 0x0201: Strip 0 is outside of the data area; ignored.
Warning: Directory Image, entry 0x0201: Strip 7 is outside of the data area; ignored.
Error: Offset of directory Thumbnail, entry 0x0201 is out of bounds: Offset = 0x00000000; truncating the entry
+ Uncaught exception: Overflow in addition
```
Setting a breakpoint in the ctor of LoaderExifJpeg shows the following output:
on x86 (i586):
```
Breakpoint 1, (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=0, image=..., id=24, this=0xf7ca6ae0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
549 if (Safe::add(offset_, size_) > static_cast<uint32_t>(image_.io().size()))
(gdb) bt
#0 (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=0, image=..., id=24, this=0xf7ca6ae0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
#1 (anonymous namespace)::createLoaderExifJpeg (id=24, image=..., parIdx=0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:557
#2 0xf7d980e6 in (anonymous namespace)::Loader::create (id=24, image=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:389
#3 0xf7d99ad8 in Exiv2::PreviewManager::getPreviewProperties (this=<optimized out>, this@entry=0xffffd3b4) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:1148
#4 0x565731e0 in Action::Extract::writePreviews (this=0xf7ffde30) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1134
#5 0x5657b43f in Action::Extract::run (this=0xf7ffde30, path=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1051
#6 0x5655e52f in main (argc=3, argv=0xffffd5e4) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/exiv2.cpp:169
```
on ppc:
```
Breakpoint 1, (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=16750280, image=..., id=-8804, this=0xf7ff91b0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
549 if (Safe::add(offset_, size_) > static_cast<uint32_t>(image_.io().size()))
(gdb) bt
#0 (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=16750280, image=..., id=-8804, this=0xf7ff91b0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
#1 (anonymous namespace)::createLoaderExifJpeg (id=id@entry=24, image=..., parIdx=parIdx@entry=0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:557
#2 0xf7d07c30 in (anonymous namespace)::Loader::create (id=id@entry=24, image=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:389
#3 0xf7d096c0 in Exiv2::PreviewManager::getPreviewProperties (this=this@entry=0xffffdf54) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:1148
#4 0x0041ac74 in Action::Extract::writePreviews (this=this@entry=0xf7ffe4d0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1134
#5 0x004223e0 in Action::Extract::run (this=0xf7ffe4d0, path=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1051
#6 0x00406b7c in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/exiv2.cpp:169
```
on aarch64:
```
Breakpoint 1, (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=-1210642848, image=..., id=-4200, this=0xaaaaaaae7460) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
549 if (Safe::add(offset_, size_) > static_cast<uint32_t>(image_.io().size()))
(gdb) bt
#0 (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=-1210642848, image=..., id=-4200, this=0xaaaaaaae7460) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
#1 (anonymous namespace)::createLoaderExifJpeg (id=id@entry=24, image=..., parIdx=parIdx@entry=0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:557
#2 0x0000ffffb7d72470 in (anonymous namespace)::Loader::create (id=id@entry=24, image=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:389
#3 0x0000ffffb7d73c78 in Exiv2::PreviewManager::getPreviewProperties (this=this@entry=0xfffffffff1f8) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:1148
#4 0x0000aaaaaaac3dec in Action::Extract::writePreviews (this=this@entry=0xffffb7acdf60) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1134
#5 0x0000aaaaaaacaee8 in Action::Extract::run (this=0xffffb7acdf60, path=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1051
#6 0x0000aaaaaaab1bd0 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/exiv2.cpp:169
```
Note the really weird parIdx and id in the not-x86 runs. | Test from #365 reveals more issues in LoaderExifJpeg | https://api.github.com/repos/Exiv2/exiv2/issues/933/comments | 14 | 2019-06-26T04:59:18 | "2022-09-26T16:10:14Z" | https://github.com/Exiv2/exiv2/issues/933 | 460,760,865 | 933 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Test from #365 reveals more issues in LoaderExifJpeg
Issue date:
--- start body ---
**Describe the bug**
Nominally, a test failure.
Practically, potentially a much worse issue.
**To Reproduce**
Steps to reproduce the behaviour:
1. Run the exiv2 testsuite on a non-x86 computer.
**Expected behavior**
test_run (bugfixes.github.test_CVE_2018_12265.AdditionOverflowInLoaderExifJpeg) ... OK
**Actual behaviour**
test_run (bugfixes.github.test_CVE_2018_12265.AdditionOverflowInLoaderExifJpeg) ... FAIL
**Desktop (please complete the following information):**
- OS: AdΓ©lie Linux 1.0-BETA3
- Compiler & Version: GCC 8.3.0
- Compilation mode and/or compiler flags:
- ppc64: `-O2 -ggdb -mcpu=970 -mtune=power9 -maltivec -mlong-double-64 -fno-inline-small-functions`
- ppc: `-O2 -ggdb -mcpu=G3 -fno-omit-frame-pointer -mfpu=dp_full`
- aarch64: `-O2 -ggdb -mtune=cortex-a53`
**Additional context**
```
======================================================================
FAIL: test_run (bugfixes.github.test_CVE_2018_12265.AdditionOverflowInLoaderExifJpeg)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/tests/system_tests.py", line 632, in test_run
self.compare_stderr(i, command, processed_stderr, stderr)
File "/usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/tests/system_tests.py", line 755, in compare_stderr
msg="Standard error does not match"
File "/usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/tests/system_tests.py", line 726, in _compare_output
expected, got, msg=msg
AssertionError: 'Erro[431 chars]uncating the entry\n' != 'Erro[431 chars]uncating the entry\nUncaught exception: Overflow in addition\n'
Error: Upper boundary of data for directory Image, entry 0x00fe is out of bounds: Offset = 0x0000002a, size = 64, exceeds buffer size by 22 Bytes; truncating the entry
Warning: Directory Image, entry 0x0201: Strip 0 is outside of the data area; ignored.
Warning: Directory Image, entry 0x0201: Strip 7 is outside of the data area; ignored.
Error: Offset of directory Thumbnail, entry 0x0201 is out of bounds: Offset = 0x00000000; truncating the entry
+ Uncaught exception: Overflow in addition
```
Setting a breakpoint in the ctor of LoaderExifJpeg shows the following output:
on x86 (i586):
```
Breakpoint 1, (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=0, image=..., id=24, this=0xf7ca6ae0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
549 if (Safe::add(offset_, size_) > static_cast<uint32_t>(image_.io().size()))
(gdb) bt
#0 (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=0, image=..., id=24, this=0xf7ca6ae0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
#1 (anonymous namespace)::createLoaderExifJpeg (id=24, image=..., parIdx=0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:557
#2 0xf7d980e6 in (anonymous namespace)::Loader::create (id=24, image=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:389
#3 0xf7d99ad8 in Exiv2::PreviewManager::getPreviewProperties (this=<optimized out>, this@entry=0xffffd3b4) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:1148
#4 0x565731e0 in Action::Extract::writePreviews (this=0xf7ffde30) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1134
#5 0x5657b43f in Action::Extract::run (this=0xf7ffde30, path=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1051
#6 0x5655e52f in main (argc=3, argv=0xffffd5e4) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/exiv2.cpp:169
```
on ppc:
```
Breakpoint 1, (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=16750280, image=..., id=-8804, this=0xf7ff91b0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
549 if (Safe::add(offset_, size_) > static_cast<uint32_t>(image_.io().size()))
(gdb) bt
#0 (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=16750280, image=..., id=-8804, this=0xf7ff91b0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
#1 (anonymous namespace)::createLoaderExifJpeg (id=id@entry=24, image=..., parIdx=parIdx@entry=0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:557
#2 0xf7d07c30 in (anonymous namespace)::Loader::create (id=id@entry=24, image=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:389
#3 0xf7d096c0 in Exiv2::PreviewManager::getPreviewProperties (this=this@entry=0xffffdf54) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:1148
#4 0x0041ac74 in Action::Extract::writePreviews (this=this@entry=0xf7ffe4d0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1134
#5 0x004223e0 in Action::Extract::run (this=0xf7ffe4d0, path=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1051
#6 0x00406b7c in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/exiv2.cpp:169
```
on aarch64:
```
Breakpoint 1, (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=-1210642848, image=..., id=-4200, this=0xaaaaaaae7460) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
549 if (Safe::add(offset_, size_) > static_cast<uint32_t>(image_.io().size()))
(gdb) bt
#0 (anonymous namespace)::LoaderExifJpeg::LoaderExifJpeg (parIdx=-1210642848, image=..., id=-4200, this=0xaaaaaaae7460) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:549
#1 (anonymous namespace)::createLoaderExifJpeg (id=id@entry=24, image=..., parIdx=parIdx@entry=0) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:557
#2 0x0000ffffb7d72470 in (anonymous namespace)::Loader::create (id=id@entry=24, image=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:389
#3 0x0000ffffb7d73c78 in Exiv2::PreviewManager::getPreviewProperties (this=this@entry=0xfffffffff1f8) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/preview.cpp:1148
#4 0x0000aaaaaaac3dec in Action::Extract::writePreviews (this=this@entry=0xffffb7acdf60) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1134
#5 0x0000aaaaaaacaee8 in Action::Extract::run (this=0xffffb7acdf60, path=...) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/actions.cpp:1051
#6 0x0000aaaaaaab1bd0 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/packages/user/exiv2/src/exiv2-0.27.1-Source/src/exiv2.cpp:169
```
Note the really weird parIdx and id in the not-x86 runs.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 6,999 | 207,823 |
[
"Exiv2",
"exiv2"
] | I just wanted to let you know that version 2.32 of the Exif specification was released last month. This version adds a few new tags that should be supported by Exiv2:
https://web.archive.org/web/20190624045241if_/http://www.cipa.jp:80/std/documents/e/DC-008-Translation-2019-E.pdf
I checked the Exiv2 code base to see what version is currently supported, but I couldn't find any of the new tags from Exif 2.31 (July 2016) or Exif 2.3 (April 2010) either. I hope I am missing something. There were a number of useful tags added in these versions as well. | Add support for Exif 2.32 | https://api.github.com/repos/Exiv2/exiv2/issues/929/comments | 7 | 2019-06-25T11:19:24 | "2020-11-21T12:51:34Z" | https://github.com/Exiv2/exiv2/issues/929 | 460,363,932 | 929 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add support for Exif 2.32
Issue date:
--- start body ---
I just wanted to let you know that version 2.32 of the Exif specification was released last month. This version adds a few new tags that should be supported by Exiv2:
https://web.archive.org/web/20190624045241if_/http://www.cipa.jp:80/std/documents/e/DC-008-Translation-2019-E.pdf
I checked the Exiv2 code base to see what version is currently supported, but I couldn't find any of the new tags from Exif 2.31 (July 2016) or Exif 2.3 (April 2010) either. I hope I am missing something. There were a number of useful tags added in these versions as well.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 748 | 207,824 |
[
"Exiv2",
"exiv2"
] | I have a kind request about the exiv2 sources. I see that debug builds use the define `DEBUG` to print more verbose output messages. These messages are directly written to `std::cout` or `std::cerr`.
This behavior is quite common and there is really nothing wrong with it. However I would slightly prefer more control over the messages, because when I use exiv2 debug builds, they tend to be quite verbose on stdout/stderr.
Would it be acceptable to change the logging behavior? I could think to either add a new define like `EXIV2_DEBUG_MESSAGES` that users can separately control independent of `DEBUG`. Or to leave the messages to be printed only when `DEBUG` is defined, but print via exiv2's existing logging mechanism from `error.hpp` so users can control the verbosity at runtime.
Does any of this sound reasonable? If you find it not worthwhile, please feel free to close this kind request. | Please change the behaviour of debug stdout/stderr output. | https://api.github.com/repos/Exiv2/exiv2/issues/926/comments | 11 | 2019-06-24T07:58:16 | "2019-07-08T19:16:21Z" | https://github.com/Exiv2/exiv2/issues/926 | 459,745,635 | 926 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Please change the behaviour of debug stdout/stderr output.
Issue date:
--- start body ---
I have a kind request about the exiv2 sources. I see that debug builds use the define `DEBUG` to print more verbose output messages. These messages are directly written to `std::cout` or `std::cerr`.
This behavior is quite common and there is really nothing wrong with it. However I would slightly prefer more control over the messages, because when I use exiv2 debug builds, they tend to be quite verbose on stdout/stderr.
Would it be acceptable to change the logging behavior? I could think to either add a new define like `EXIV2_DEBUG_MESSAGES` that users can separately control independent of `DEBUG`. Or to leave the messages to be printed only when `DEBUG` is defined, but print via exiv2's existing logging mechanism from `error.hpp` so users can control the verbosity at runtime.
Does any of this sound reasonable? If you find it not worthwhile, please feel free to close this kind request.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,126 | 207,825 |
[
"Exiv2",
"exiv2"
] | When I wrote README.md for v0.27, I had never succeeded in cross-compiling for MinGW from Linux. I believe this is now working and Dan has a CI job.
I hope to refresh my brain about this and get it documented for v0.27.2. For sure for v0.27.3 | Update README.md to explain cross-compiling | https://api.github.com/repos/Exiv2/exiv2/issues/922/comments | 15 | 2019-06-22T17:25:29 | "2020-04-10T10:33:47Z" | https://github.com/Exiv2/exiv2/issues/922 | 459,494,460 | 922 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Update README.md to explain cross-compiling
Issue date:
--- start body ---
When I wrote README.md for v0.27, I had never succeeded in cross-compiling for MinGW from Linux. I believe this is now working and Dan has a CI job.
I hope to refresh my brain about this and get it documented for v0.27.2. For sure for v0.27.3
--- end body ---
comments :
--- start comments ---
--- end comments --- | 451 | 207,826 |
[
"Exiv2",
"exiv2"
] | In following up on the XMP SDK version issue, I am trying to print out all of the data from a test file which contains a UTF-8 string.
The file happens to be a PNG without Exif data - because it is a PNG test file and Exiv2 simply exits when I try to print out all of the metadata with: exiv2 -pa test.png
The test file is attached
Am I using exiv2 all wrong? or what else am I misunderstanding? | Exiv2 usage | https://api.github.com/repos/Exiv2/exiv2/issues/920/comments | 7 | 2019-06-20T17:02:21 | "2019-06-20T21:11:29Z" | https://github.com/Exiv2/exiv2/issues/920 | 458,770,105 | 920 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Exiv2 usage
Issue date:
--- start body ---
In following up on the XMP SDK version issue, I am trying to print out all of the data from a test file which contains a UTF-8 string.
The file happens to be a PNG without Exif data - because it is a PNG test file and Exiv2 simply exits when I try to print out all of the metadata with: exiv2 -pa test.png
The test file is attached
Am I using exiv2 all wrong? or what else am I misunderstanding?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 687 | 207,827 |
[
"Exiv2",
"exiv2"
] | As I am very unfamiliar with Conan and its process, I am unsure of how to even phrase my question.
After downloading & compiling the Widows 32-bit version, I see that the XMP SDK version I have as part of the exiv2 is 4.4.0 while the most recent version I have directly from the Adobe 5.6.0 & 5.7.0 for Core/File versions.
Is this an issue with Conan, Exiv2 or ..... ?? | XMP SDK version | https://api.github.com/repos/Exiv2/exiv2/issues/919/comments | 2 | 2019-06-19T18:07:56 | "2019-06-20T16:19:56Z" | https://github.com/Exiv2/exiv2/issues/919 | 458,150,493 | 919 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : XMP SDK version
Issue date:
--- start body ---
As I am very unfamiliar with Conan and its process, I am unsure of how to even phrase my question.
After downloading & compiling the Widows 32-bit version, I see that the XMP SDK version I have as part of the exiv2 is 4.4.0 while the most recent version I have directly from the Adobe 5.6.0 & 5.7.0 for Core/File versions.
Is this an issue with Conan, Exiv2 or ..... ??
--- end body ---
comments :
--- start comments ---
--- end comments --- | 547 | 207,828 |
[
"Exiv2",
"exiv2"
] | When I try to compile a debug version - only have tried 32-bit version - using the code recommended by MS to detect memory leaks,
I get a very strange error which I traced to the fact that the class class EXIV2API DataBuf{} defines a function void free(); at line #243 in types.hpp
The error shows up as:
> 1>d:\pkg\c++\msvc2017\exiv2-master-0.27.1\exiv2\include\exiv2\types.hpp(243): warning C4003: not enough arguments for function-like macro invocation 'free'
> 1>d:\pkg\c++\msvc2017\exiv2-master-0.27.1\exiv2\include\exiv2\types.hpp(243): error C2059: syntax error: ','
Renaming the function to free_() wherever it is used. clears up the issue
- types.hpp line 243
- types.cpp line 183 void DataBuf::free_()
- pngimage.cpp lines 107, 114, 137 & 140
- image.cpp line 637 | Under Windows MSVC class EXIV2API DataBuf contains a free() function | https://api.github.com/repos/Exiv2/exiv2/issues/918/comments | 13 | 2019-06-19T17:51:51 | "2019-08-01T16:32:47Z" | https://github.com/Exiv2/exiv2/issues/918 | 458,143,979 | 918 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Under Windows MSVC class EXIV2API DataBuf contains a free() function
Issue date:
--- start body ---
When I try to compile a debug version - only have tried 32-bit version - using the code recommended by MS to detect memory leaks,
I get a very strange error which I traced to the fact that the class class EXIV2API DataBuf{} defines a function void free(); at line #243 in types.hpp
The error shows up as:
> 1>d:\pkg\c++\msvc2017\exiv2-master-0.27.1\exiv2\include\exiv2\types.hpp(243): warning C4003: not enough arguments for function-like macro invocation 'free'
> 1>d:\pkg\c++\msvc2017\exiv2-master-0.27.1\exiv2\include\exiv2\types.hpp(243): error C2059: syntax error: ','
Renaming the function to free_() wherever it is used. clears up the issue
- types.hpp line 243
- types.cpp line 183 void DataBuf::free_()
- pngimage.cpp lines 107, 114, 137 & 140
- image.cpp line 637
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,030 | 207,829 |
[
"Exiv2",
"exiv2"
] | I just wanted to have a look at the most recent RC for packaging but was unable to check it out in my local repo. `git fetch upstream` (where upstream is my local alias for github.com/Exiv2/exiv) does not download the tag `v0.27.2-RC1`. Explicitly fetching that results in
```
$ git fetch upstream v0.27.2-RC1
From https://github.com/Exiv2/exiv2
* tag v0.27.2-RC1 -> FETCH_HEAD
```
However the tag is still not listed by `git tag` and can't be checked out. Neither is the commit ba3bb9ae0f27b62149815371238bad9d115faaa1 available. Looking at the commit log of the tag (https://github.com/Exiv2/exiv2/commits/v0.27.2-RC1) shows that it diverged from the `0.27-maintenance` branch (https://github.com/Exiv2/exiv2/commits/0.27-maintenance). That in itself is not good in my opinion, as it just makes the history harder to follow, but it shouldn't be a reason why the tag can't be checked out.
Could someone please check whether they are able to check tag `v0.27.2-RC1` out.
And I do request for release tags to happen in a branch, not any "free" commit. I would just do it directly in the `0.27-maintenance` branch or then split off a release branch for 0.27.2 (but that seems a bit too much for a simple point release). | Unable to checkout v0.27.2-RC1 | https://api.github.com/repos/Exiv2/exiv2/issues/915/comments | 7 | 2019-06-17T11:43:50 | "2019-06-18T09:13:50Z" | https://github.com/Exiv2/exiv2/issues/915 | 456,889,308 | 915 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Unable to checkout v0.27.2-RC1
Issue date:
--- start body ---
I just wanted to have a look at the most recent RC for packaging but was unable to check it out in my local repo. `git fetch upstream` (where upstream is my local alias for github.com/Exiv2/exiv) does not download the tag `v0.27.2-RC1`. Explicitly fetching that results in
```
$ git fetch upstream v0.27.2-RC1
From https://github.com/Exiv2/exiv2
* tag v0.27.2-RC1 -> FETCH_HEAD
```
However the tag is still not listed by `git tag` and can't be checked out. Neither is the commit ba3bb9ae0f27b62149815371238bad9d115faaa1 available. Looking at the commit log of the tag (https://github.com/Exiv2/exiv2/commits/v0.27.2-RC1) shows that it diverged from the `0.27-maintenance` branch (https://github.com/Exiv2/exiv2/commits/0.27-maintenance). That in itself is not good in my opinion, as it just makes the history harder to follow, but it shouldn't be a reason why the tag can't be checked out.
Could someone please check whether they are able to check tag `v0.27.2-RC1` out.
And I do request for release tags to happen in a branch, not any "free" commit. I would just do it directly in the `0.27-maintenance` branch or then split off a release branch for 0.27.2 (but that seems a bit too much for a simple point release).
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,442 | 207,830 |
[
"Exiv2",
"exiv2"
] | In trying to use/test some of the utilities, I can't seem to find any man pages. Even --help does not seem to help for at least exifcomment.
| exifcomment & other utilities man pages?? | https://api.github.com/repos/Exiv2/exiv2/issues/912/comments | 16 | 2019-06-14T17:15:52 | "2019-08-30T08:32:09Z" | https://github.com/Exiv2/exiv2/issues/912 | 456,352,440 | 912 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : exifcomment & other utilities man pages??
Issue date:
--- start body ---
In trying to use/test some of the utilities, I can't seem to find any man pages. Even --help does not seem to help for at least exifcomment.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 344 | 207,831 |
[
"Exiv2",
"exiv2"
] | Libre Graphics Meeting is a conference on Graphics Open Source Developers. Typically 100 Engineers spend a long week-end (Thursday -> Sunday) to attend presentations, workshops, meet each other, relax and drink beer. It's wonderful to spend time together and get to know each other.
When I attended for one day in 2016, I met folks from Darktable, Gimp and other projects that use Exiv2.
This global event has been held on several continents since its inception about 2000. Recent conferences were held in the spring (April or May)
2016 London, UK (I attended for one day)
2017 Rio, Brazil (I gave a presentation remotely)
2018 Seville, Spain
2019 SaarbrΓΌcken, Germany @cryptomilk gave a 5 minute presentation about Exiv2.
2020 Rennes, France
Let's have a Team Exiv2 meeting next year in Rennes. The organisers take care to manage cost by holding the conference in a university and student accomodation. However, as Exiv2 has no revenue, we'll have to travel and pay our own expenses. Your boss (in my case Alison) may be sympathetic and allow you to submit an expense claim.
@boardhead Perhaps the University will consider this worthy of their support. I think your attendance would deserve an invitation to give a "key-note" on one day of the conference.
I would like to run an "Exiv2 Architecture" Workshop and we could spend half a day discussing the internals of Exiv2. How does the TiffParser actually work? Let me explain and I hope you won't fall asleep.
I'll update this issue as I learn more about the arrangements. Who's interested in attending? | Let's go to LGM 2020 in Rennes, France | https://api.github.com/repos/Exiv2/exiv2/issues/911/comments | 10 | 2019-06-14T16:08:45 | "2021-03-14T13:52:57Z" | https://github.com/Exiv2/exiv2/issues/911 | 456,324,970 | 911 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Let's go to LGM 2020 in Rennes, France
Issue date:
--- start body ---
Libre Graphics Meeting is a conference on Graphics Open Source Developers. Typically 100 Engineers spend a long week-end (Thursday -> Sunday) to attend presentations, workshops, meet each other, relax and drink beer. It's wonderful to spend time together and get to know each other.
When I attended for one day in 2016, I met folks from Darktable, Gimp and other projects that use Exiv2.
This global event has been held on several continents since its inception about 2000. Recent conferences were held in the spring (April or May)
2016 London, UK (I attended for one day)
2017 Rio, Brazil (I gave a presentation remotely)
2018 Seville, Spain
2019 SaarbrΓΌcken, Germany @cryptomilk gave a 5 minute presentation about Exiv2.
2020 Rennes, France
Let's have a Team Exiv2 meeting next year in Rennes. The organisers take care to manage cost by holding the conference in a university and student accomodation. However, as Exiv2 has no revenue, we'll have to travel and pay our own expenses. Your boss (in my case Alison) may be sympathetic and allow you to submit an expense claim.
@boardhead Perhaps the University will consider this worthy of their support. I think your attendance would deserve an invitation to give a "key-note" on one day of the conference.
I would like to run an "Exiv2 Architecture" Workshop and we could spend half a day discussing the internals of Exiv2. How does the TiffParser actually work? Let me explain and I hope you won't fall asleep.
I'll update this issue as I learn more about the arrangements. Who's interested in attending?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,791 | 207,832 |
[
"Exiv2",
"exiv2"
] | When RemoteIo::getb is called for a byte at the very end of a block, it will populate the wrong block, and then read a byte from before the start of the "data" array. The fix is to remove the "+ 1" from the "expectedBlock" calculation.
`size_t expectedBlock = (p_->idx_ + 1)/p_->blockSize_;` | out-of-bounds array access in RemoteIo::getb | https://api.github.com/repos/Exiv2/exiv2/issues/910/comments | 3 | 2019-06-14T14:17:56 | "2019-10-09T06:49:53Z" | https://github.com/Exiv2/exiv2/issues/910 | 456,273,107 | 910 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : out-of-bounds array access in RemoteIo::getb
Issue date:
--- start body ---
When RemoteIo::getb is called for a byte at the very end of a block, it will populate the wrong block, and then read a byte from before the start of the "data" array. The fix is to remove the "+ 1" from the "expectedBlock" calculation.
`size_t expectedBlock = (p_->idx_ + 1)/p_->blockSize_;`
--- end body ---
comments :
--- start comments ---
--- end comments --- | 500 | 207,833 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
When exporting a jpeg image from a raw file in the darktable program, the program calls `obj->writeMetadata();` A part file is saved in the directory along with the programs output. Generating the following error:
```
caught exiv2 exception 'Size of XMP JPEG segment is larger than 65535 bytes'
```
**To Reproduce**
Steps to reproduce the behaviour:
Create an image to export in darktable that uses many instances of the spot removal tool, generating many masks; Export that file to jpeg.
**Expected behavior**
A single jpeg file should be saved.
**Desktop (please complete the following information):**
- OS: debian 9.9
- Compiler & Version gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)
- Compilation mode and/or compiler flags: 0.25-3.1+deb9u1 package
**Additional context**
Originating raw file is a canon tif from canon 1Ds.
| libexiv2 saves a part file when attempting to export data that conforms with the multi-segment xmp standard. | https://api.github.com/repos/Exiv2/exiv2/issues/908/comments | 5 | 2019-06-13T08:55:02 | "2019-06-13T22:15:34Z" | https://github.com/Exiv2/exiv2/issues/908 | 455,616,298 | 908 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : libexiv2 saves a part file when attempting to export data that conforms with the multi-segment xmp standard.
Issue date:
--- start body ---
**Describe the bug**
When exporting a jpeg image from a raw file in the darktable program, the program calls `obj->writeMetadata();` A part file is saved in the directory along with the programs output. Generating the following error:
```
caught exiv2 exception 'Size of XMP JPEG segment is larger than 65535 bytes'
```
**To Reproduce**
Steps to reproduce the behaviour:
Create an image to export in darktable that uses many instances of the spot removal tool, generating many masks; Export that file to jpeg.
**Expected behavior**
A single jpeg file should be saved.
**Desktop (please complete the following information):**
- OS: debian 9.9
- Compiler & Version gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)
- Compilation mode and/or compiler flags: 0.25-3.1+deb9u1 package
**Additional context**
Originating raw file is a canon tif from canon 1Ds.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,152 | 207,834 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
I have been investigating a bug in darktable when using my canon 1Ds camera, the thumbnails for the cameras tiff format are auto extracted from the files by exiv2. The Images that are returned have a colour matrix problem, the highlights are out of gamut and apear to be overflowing into totaly different colour ranges; I suspect an issue with the word size.
**To Reproduce**
The same result can be reproduced by running exiv2 from the command line on a cannon native tif that contains the cameras raw data, using the -ep flags to extract a thumbnail.
exiv2 -ep <target>
The resulting image contains the colour artefact.
**Expected behaviour**
I expected to obtain a preview image with the correct colours.
**Desktop (please complete the following information):**
- OS: debian 9.8
- Compiler & Version: gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)
- Compilation mode and/or compiler flags: dpkg 0.25-3.1+deb9u1
**Additional context**
The canon file contains a small tiff as a preview image, this displays correctly if I browse the files using the gnome desktop or open them with eye of gnome, a preview tiff is displayed correctly.
If I open the extracted preview with gimp it throws a warning that the file is in 16bit format that is not supported by gimp.
I have converted one of the generated previews in to a jpeg to display here.
Thank you for your consideration.
Iain Hill
| Canon 1Ds thumbnail colour corrupted. | https://api.github.com/repos/Exiv2/exiv2/issues/904/comments | 15 | 2019-06-10T12:14:49 | "2021-04-18T10:17:50Z" | https://github.com/Exiv2/exiv2/issues/904 | 454,140,872 | 904 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Canon 1Ds thumbnail colour corrupted.
Issue date:
--- start body ---
**Describe the bug**
I have been investigating a bug in darktable when using my canon 1Ds camera, the thumbnails for the cameras tiff format are auto extracted from the files by exiv2. The Images that are returned have a colour matrix problem, the highlights are out of gamut and apear to be overflowing into totaly different colour ranges; I suspect an issue with the word size.
**To Reproduce**
The same result can be reproduced by running exiv2 from the command line on a cannon native tif that contains the cameras raw data, using the -ep flags to extract a thumbnail.
exiv2 -ep <target>
The resulting image contains the colour artefact.
**Expected behaviour**
I expected to obtain a preview image with the correct colours.
**Desktop (please complete the following information):**
- OS: debian 9.8
- Compiler & Version: gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)
- Compilation mode and/or compiler flags: dpkg 0.25-3.1+deb9u1
**Additional context**
The canon file contains a small tiff as a preview image, this displays correctly if I browse the files using the gnome desktop or open them with eye of gnome, a preview tiff is displayed correctly.
If I open the extracted preview with gimp it throws a warning that the file is in 16bit format that is not supported by gimp.
I have converted one of the generated previews in to a jpeg to display here.
Thank you for your consideration.
Iain Hill
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,771 | 207,835 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
$ exiv2 -vVg debug and $ exiv2 -vVg dll are not working correctly.
**To Reproduce**
Steps to reproduce the behaviour:
```
$ exiv2 -vVg debug
exiv2 0.27.2.99
debug=1
$ bin/exiv2 -vVg dll
exiv2 0.27.2.99
dll=0
```
**Expected behavior**
```
$ exiv2 -vVg debug
exiv2 0.27.2.99
debug=0
$ bin/exiv2 -vVg dll
exiv2 0.27.2.99
dll=1
```
**Desktop (please complete the following information):**
All platforms
**Additional context**
There are two different causes:
1) debug=0
The code to set this is in src/version.cpp which expects `NDEBUG` to be set (or absent)
```
#ifdef NDEBUG
int debug=0;
#else
int debug=1;
#endif
```
CMake reports:
```
-- Extra:
-- Debug: -g3 -gstrict-dwarf -O0
-- Release: -O3 -DNDEBUG
-- RelWithDebInfo: -O2 -g -DNDEBUG
-- MinSizeRel: -Os -DNDEBUG
```
I have built with `$ cmake .. -DEXTRA_COMPILE_FLAGS=On` with the same result.
2) dll=0
The code to set this is in src/version.cpp which expects `DLL_EXPORT ` to be set (or absent)
```
#if defined(DLL_EXPORT)
int dll=1;
#else
int dll=0;
#endif
```
The pre-processor symbol `DLL_EXPORT` is a relic of autotools/msvc and no longer defined. I believe the fix is to add the following to cmake/config.h.cmake:
```
#cmakedefine BUILD_SHARED_LIBS
```
The code in src/version.cpp becomes:
```
#if defined(BUILD_SHARED_LIBS)
int dll=1;
#else
int dll=0;
#endif
```
**Another comment**
I don't know what the CMake option `-DEXTRA_COMPILE_FLAGS=On` is expected to do. I would like to document this in README.md.
| $ exiv2 -vVg debug and $ exiv2 -vVg dll are not working correctly. | https://api.github.com/repos/Exiv2/exiv2/issues/903/comments | 0 | 2019-06-10T10:13:02 | "2019-06-22T10:08:06Z" | https://github.com/Exiv2/exiv2/issues/903 | 454,096,879 | 903 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : $ exiv2 -vVg debug and $ exiv2 -vVg dll are not working correctly.
Issue date:
--- start body ---
**Describe the bug**
$ exiv2 -vVg debug and $ exiv2 -vVg dll are not working correctly.
**To Reproduce**
Steps to reproduce the behaviour:
```
$ exiv2 -vVg debug
exiv2 0.27.2.99
debug=1
$ bin/exiv2 -vVg dll
exiv2 0.27.2.99
dll=0
```
**Expected behavior**
```
$ exiv2 -vVg debug
exiv2 0.27.2.99
debug=0
$ bin/exiv2 -vVg dll
exiv2 0.27.2.99
dll=1
```
**Desktop (please complete the following information):**
All platforms
**Additional context**
There are two different causes:
1) debug=0
The code to set this is in src/version.cpp which expects `NDEBUG` to be set (or absent)
```
#ifdef NDEBUG
int debug=0;
#else
int debug=1;
#endif
```
CMake reports:
```
-- Extra:
-- Debug: -g3 -gstrict-dwarf -O0
-- Release: -O3 -DNDEBUG
-- RelWithDebInfo: -O2 -g -DNDEBUG
-- MinSizeRel: -Os -DNDEBUG
```
I have built with `$ cmake .. -DEXTRA_COMPILE_FLAGS=On` with the same result.
2) dll=0
The code to set this is in src/version.cpp which expects `DLL_EXPORT ` to be set (or absent)
```
#if defined(DLL_EXPORT)
int dll=1;
#else
int dll=0;
#endif
```
The pre-processor symbol `DLL_EXPORT` is a relic of autotools/msvc and no longer defined. I believe the fix is to add the following to cmake/config.h.cmake:
```
#cmakedefine BUILD_SHARED_LIBS
```
The code in src/version.cpp becomes:
```
#if defined(BUILD_SHARED_LIBS)
int dll=1;
#else
int dll=0;
#endif
```
**Another comment**
I don't know what the CMake option `-DEXTRA_COMPILE_FLAGS=On` is expected to do. I would like to document this in README.md.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,861 | 207,836 |
[
"Exiv2",
"exiv2"
] | This is work-in-progress and unlikely to be completed as no user has requested this. Having put in effort, I don't want this lost for all time. I'll target this for v0.27.3.
#### Status
Builds and passes the python test suite.
Does not pass the bash test suite because the Solaris version of diff is different from other platforms.
I haven't looked at cmake/packaging.cmake
#### Fix
It's likely that building coreutils from source and installing /usr/local/bin/diff will fix this.
#### Changes
```
diff --git a/README.md b/README.md
index 309331cd..2eb93b93 100644
--- a/README.md
+++ b/README.md
@@ -832,13 +832,13 @@ cmd
### Unix
-Exiv2 can be built on many Unix and Linux distros. We actively support the Unix Distributions NetBSD and FreeBSD.
+Exiv2 can be built on many Unix and Linux distros. We actively support the Unix Distributions NetBSD, FreeBSD and Solaris-11. On those plaforms, I built and installed exiv2 using "Pure CMake" and did not require conan.
-I am willing to support Exiv2 on commercial Unix distributions such as Solaris, AIX, HP-UX and OSF/1 provided you provide with an ssh account on your platform. I will require super-user privileges to install software.
+I am willing to support Exiv2 on other commercial Unix distributions such as AIX, HP-UX and OSF/1 if you provide with an ssh account on your platform. I will require super-user privileges to install software.
#### NetBSD
-You can build exiv2 from source using the methods described for linux. I built and installed exiv2 using "Pure CMake" and didn't require conan.
+You can build exiv2 from source using the methods described for linux.
You will want to use the package manager `pkgsrc` to build/install:
1. gcc (currently GCC 5.5.0)
@@ -856,8 +856,17 @@ It's important to ensure that `LD_LIBRARY_PATH` includes `/usr/local/lib` and `/
FreeBSD uses pkg as the package manager. You should install the dependency expat. libz is already installed. As with NetBSD, you should use pkg to install python3, cmake, bash, sudo, gettext and gcc. The default GCC compiler is currently 8.3.0.
+#### Solaris
+
+I use the Open Source version of Solaris-11 available from Oracle and installed the dependencies as follows:
+
+
+```bash
+$ sudo pkg install gcc cmake git gnome/gettext
+```
+
[TOC](#TOC)
Robin Mills
-Revised: 2019-05-11
\ No newline at end of file
+Revised: 2019-06-08
\ No newline at end of file
diff --git a/cmake/config.h.cmake b/cmake/config.h.cmake
index b5652cc8..f710e0bf 100644
--- a/cmake/config.h.cmake
+++ b/cmake/config.h.cmake
@@ -106,4 +106,8 @@
// Definition to enable conversion of UCS2 encoded Windows tags to UTF-8.
#cmakedefine EXV_HAVE_PRINTUCS2
+// Defined if you are building shared library
+#cmakedefine BUILD_SHARED_LIBS
+
+
#endif /* !_EXV_CONF_H_ */
diff --git a/samples/exiv2json.cpp b/samples/exiv2json.cpp
index a33a383b..e8aed1a5 100644
--- a/samples/exiv2json.cpp
+++ b/samples/exiv2json.cpp
@@ -286,10 +286,10 @@ int main(int argc, char* const argv[])
Jzon::Object root;
if ( option == 'f' ) { // only report filesystem when requested
- const char* FS="FS";
+ const char* FS1="FS";
Jzon::Object fs ;
- root.Add(FS,fs) ;
- fileSystemPush(path,root.Get(FS));
+ root.Add(FS1,fs) ;
+ fileSystemPush(path,root.Get(FS1));
}
if ( option == 'a' || option == 'e' ) {
diff --git a/samples/geotag.cpp b/samples/geotag.cpp
index f6dbe0b0..db04610d 100644
--- a/samples/geotag.cpp
+++ b/samples/geotag.cpp
@@ -223,13 +223,13 @@ std::string Position::toExifTimeStamp(std::string& t)
const char* arg = t.c_str();
int HH = 0 ;
int mm = 0 ;
- int SS = 0 ;
+ int SS1 = 0 ;
if ( strstr(arg,":") || strstr(arg,"-") ) {
int YY,MM,DD ;
char a,b,c,d,e ;
- sscanf(arg,"%d%c%d%c%d%c%d%c%d%c%d",&YY,&a,&MM,&b,&DD,&c,&HH,&d,&mm,&e,&SS);
+ sscanf(arg,"%d%c%d%c%d%c%d%c%d%c%d",&YY,&a,&MM,&b,&DD,&c,&HH,&d,&mm,&e,&SS1);
}
- sprintf(result,"%d/1 %d/1 %d/1",HH,mm,SS);
+ sprintf(result,"%d/1 %d/1 %d/1",HH,mm,SS1);
return std::string(result);
}
@@ -406,15 +406,15 @@ time_t parseTime(const char* arg,bool bAdjust)
// <time>2012-07-14T17:33:16Z</time>
if ( strstr(arg,":") || strstr(arg,"-") ) {
- int YY,MM,DD,HH,mm,SS ;
+ int YY,MM,DD,HH,mm,SS1 ;
char a,b,c,d,e ;
- sscanf(arg,"%d%c%d%c%d%c%d%c%d%c%d",&YY,&a,&MM,&b,&DD,&c,&HH,&d,&mm,&e,&SS);
+ sscanf(arg,"%d%c%d%c%d%c%d%c%d%c%d",&YY,&a,&MM,&b,&DD,&c,&HH,&d,&mm,&e,&SS1);
struct tm T;
memset(&T,0,sizeof(T));
T.tm_min = mm ;
T.tm_hour = HH ;
- T.tm_sec = SS ;
+ T.tm_sec = SS1 ;
if ( bAdjust ) T.tm_sec -= Position::Adjust();
T.tm_year = YY -1900 ;
T.tm_mon = MM -1 ;
@@ -441,7 +441,7 @@ int timeZoneAdjust()
struct tm lcopy = *localtime(&now);
time_t gmt = timegm(&lcopy) ; // timegm modifies lcopy
offset = (int) ( ((long signed int) gmt) - ((long signed int) now) ) ;
-#elif defined(OS_SOLARIS)
+#elif defined(OS_SOLARIS) || defined(__sun__)
struct tm local = *localtime(&now) ;
time_t local_tt = (int) mktime(&local);
time_t time_gmt = (int) mktime(gmtime(&now));
diff --git a/src/futils.cpp b/src/futils.cpp
index b4c76234..abfb9723 100644
--- a/src/futils.cpp
+++ b/src/futils.cpp
@@ -24,6 +24,7 @@
#include "futils.hpp"
#include "datasets.hpp"
#include "enforce.hpp"
+#include "image_int.hpp"
// + standard includes
#include <sys/types.h>
@@ -492,6 +493,15 @@ namespace Exiv2 {
// release resources
if ( procs ) procstat_freeprocs(procstat, procs);
if ( procstat ) procstat_close(procstat);
+ #elif defined(__sun__)
+ // https://stackoverflow.com/questions/47472762/on-solaris-how-to-get-the-full-path-of-executable-of-running-process-programatic const char* proc = Internal::stringFormat("/proc/%d/path/a.out",getpid()).c_str();
+ const char* proc = Internal::stringFormat("/proc/%d/path/a.out",getpid()).c_str();
+ char path[500];
+ ssize_t l = readlink (proc,path,sizeof(path)-1);
+ if (l>0) {
+ path[l]=0;
+ ret = path;
+ }
#elif defined(__unix__)
// http://stackoverflow.com/questions/606041/how-do-i-get-the-path-of-a-process-in-unix-linux
char path[500];
diff --git a/src/version.cpp b/src/version.cpp
index 274ca3d6..4e67267c 100644
--- a/src/version.cpp
+++ b/src/version.cpp
@@ -29,6 +29,7 @@
#include "version.hpp"
#include "makernote_int.hpp"
#include "futils.hpp"
+#include "image_int.hpp"
// Adobe XMP Toolkit
#ifdef EXV_HAVE_XMP_TOOLKIT
@@ -199,7 +200,23 @@ static Exiv2::StringVector getLoadedLibraries()
if ( files ) procstat_freefiles(procstat, files);
if ( procs ) procstat_freeprocs(procstat, procs);
if ( procstat ) procstat_close (procstat);
-
+#elif defined(__sun__)
+ // https://www.oracle.com/technetwork/server-storage/solaris10/solaris-linux-app-139382.html
+ const int pid = getpid();
+ const char* tmp = Exiv2::Internal::stringFormat("/tmp/%d",pid).c_str();
+ const char* cmd = Exiv2::Internal::stringFormat("pmap %d > %s",pid,tmp).c_str();
+ system (cmd);
+ std::ifstream maps(tmp,std::ifstream::in);
+ std::string string ;
+ while ( std::getline(maps,string) ) {
+ std::size_t pos = string.find_last_of(' ');
+ if ( pos != std::string::npos ) {
+ std::string path = string.substr(pos+1);
+ if ( path[0] != '-' ) {
+ pushPath(path,libs,paths);
+ }
+ }
+ }
#elif defined(__unix__)
// read file /proc/self/maps which has a list of files in memory
std::ifstream maps("/proc/self/maps",std::ifstream::in);
@@ -218,13 +235,13 @@ static Exiv2::StringVector getLoadedLibraries()
void Exiv2::dumpLibraryInfo(std::ostream& os,const exv_grep_keys_t& keys)
{
int bits = 8*sizeof(void*);
-#ifdef NDEBUG
- int debug=0;
-#else
+#ifdef DEBUG
int debug=1;
+#else
+ int debug=0;
#endif
-#if defined(DLL_EXPORT)
+#if defined(BUILD_SHARED_LIBS)
int dll=1;
#else
int dll=0;
@@ -264,7 +281,7 @@ void Exiv2::dumpLibraryInfo(std::ostream& os,const exv_grep_keys_t& keys)
"unknown" ;
#endif
-#if defined(__SUNPRO_CC) || defined (__SUNPRO_C)
+#if defined(__SUNPRO_CC) || defined (__SUNPRO_C) || defined(__sun__)
#define __oracle__
#endif
@@ -293,6 +310,8 @@ void Exiv2::dumpLibraryInfo(std::ostream& os,const exv_grep_keys_t& keys)
"netbsd";
#elif defined(__FreeBSD__)
"freebsd";
+#elif defined(__oracle__) || defined(OS_SOLARIS) || defined(__sun__)
+ "solaris";
#elif defined(__linux__)
"linux";
#else
``` | Support for Solaris 11.4 | https://api.github.com/repos/Exiv2/exiv2/issues/902/comments | 10 | 2019-06-09T18:57:50 | "2020-04-16T12:58:44Z" | https://github.com/Exiv2/exiv2/issues/902 | 453,927,670 | 902 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Support for Solaris 11.4
Issue date:
--- start body ---
This is work-in-progress and unlikely to be completed as no user has requested this. Having put in effort, I don't want this lost for all time. I'll target this for v0.27.3.
#### Status
Builds and passes the python test suite.
Does not pass the bash test suite because the Solaris version of diff is different from other platforms.
I haven't looked at cmake/packaging.cmake
#### Fix
It's likely that building coreutils from source and installing /usr/local/bin/diff will fix this.
#### Changes
```
diff --git a/README.md b/README.md
index 309331cd..2eb93b93 100644
--- a/README.md
+++ b/README.md
@@ -832,13 +832,13 @@ cmd
### Unix
-Exiv2 can be built on many Unix and Linux distros. We actively support the Unix Distributions NetBSD and FreeBSD.
+Exiv2 can be built on many Unix and Linux distros. We actively support the Unix Distributions NetBSD, FreeBSD and Solaris-11. On those plaforms, I built and installed exiv2 using "Pure CMake" and did not require conan.
-I am willing to support Exiv2 on commercial Unix distributions such as Solaris, AIX, HP-UX and OSF/1 provided you provide with an ssh account on your platform. I will require super-user privileges to install software.
+I am willing to support Exiv2 on other commercial Unix distributions such as AIX, HP-UX and OSF/1 if you provide with an ssh account on your platform. I will require super-user privileges to install software.
#### NetBSD
-You can build exiv2 from source using the methods described for linux. I built and installed exiv2 using "Pure CMake" and didn't require conan.
+You can build exiv2 from source using the methods described for linux.
You will want to use the package manager `pkgsrc` to build/install:
1. gcc (currently GCC 5.5.0)
@@ -856,8 +856,17 @@ It's important to ensure that `LD_LIBRARY_PATH` includes `/usr/local/lib` and `/
FreeBSD uses pkg as the package manager. You should install the dependency expat. libz is already installed. As with NetBSD, you should use pkg to install python3, cmake, bash, sudo, gettext and gcc. The default GCC compiler is currently 8.3.0.
+#### Solaris
+
+I use the Open Source version of Solaris-11 available from Oracle and installed the dependencies as follows:
+
+
+```bash
+$ sudo pkg install gcc cmake git gnome/gettext
+```
+
[TOC](#TOC)
Robin Mills
-Revised: 2019-05-11
\ No newline at end of file
+Revised: 2019-06-08
\ No newline at end of file
diff --git a/cmake/config.h.cmake b/cmake/config.h.cmake
index b5652cc8..f710e0bf 100644
--- a/cmake/config.h.cmake
+++ b/cmake/config.h.cmake
@@ -106,4 +106,8 @@
// Definition to enable conversion of UCS2 encoded Windows tags to UTF-8.
#cmakedefine EXV_HAVE_PRINTUCS2
+// Defined if you are building shared library
+#cmakedefine BUILD_SHARED_LIBS
+
+
#endif /* !_EXV_CONF_H_ */
diff --git a/samples/exiv2json.cpp b/samples/exiv2json.cpp
index a33a383b..e8aed1a5 100644
--- a/samples/exiv2json.cpp
+++ b/samples/exiv2json.cpp
@@ -286,10 +286,10 @@ int main(int argc, char* const argv[])
Jzon::Object root;
if ( option == 'f' ) { // only report filesystem when requested
- const char* FS="FS";
+ const char* FS1="FS";
Jzon::Object fs ;
- root.Add(FS,fs) ;
- fileSystemPush(path,root.Get(FS));
+ root.Add(FS1,fs) ;
+ fileSystemPush(path,root.Get(FS1));
}
if ( option == 'a' || option == 'e' ) {
diff --git a/samples/geotag.cpp b/samples/geotag.cpp
index f6dbe0b0..db04610d 100644
--- a/samples/geotag.cpp
+++ b/samples/geotag.cpp
@@ -223,13 +223,13 @@ std::string Position::toExifTimeStamp(std::string& t)
const char* arg = t.c_str();
int HH = 0 ;
int mm = 0 ;
- int SS = 0 ;
+ int SS1 = 0 ;
if ( strstr(arg,":") || strstr(arg,"-") ) {
int YY,MM,DD ;
char a,b,c,d,e ;
- sscanf(arg,"%d%c%d%c%d%c%d%c%d%c%d",&YY,&a,&MM,&b,&DD,&c,&HH,&d,&mm,&e,&SS);
+ sscanf(arg,"%d%c%d%c%d%c%d%c%d%c%d",&YY,&a,&MM,&b,&DD,&c,&HH,&d,&mm,&e,&SS1);
}
- sprintf(result,"%d/1 %d/1 %d/1",HH,mm,SS);
+ sprintf(result,"%d/1 %d/1 %d/1",HH,mm,SS1);
return std::string(result);
}
@@ -406,15 +406,15 @@ time_t parseTime(const char* arg,bool bAdjust)
// <time>2012-07-14T17:33:16Z</time>
if ( strstr(arg,":") || strstr(arg,"-") ) {
- int YY,MM,DD,HH,mm,SS ;
+ int YY,MM,DD,HH,mm,SS1 ;
char a,b,c,d,e ;
- sscanf(arg,"%d%c%d%c%d%c%d%c%d%c%d",&YY,&a,&MM,&b,&DD,&c,&HH,&d,&mm,&e,&SS);
+ sscanf(arg,"%d%c%d%c%d%c%d%c%d%c%d",&YY,&a,&MM,&b,&DD,&c,&HH,&d,&mm,&e,&SS1);
struct tm T;
memset(&T,0,sizeof(T));
T.tm_min = mm ;
T.tm_hour = HH ;
- T.tm_sec = SS ;
+ T.tm_sec = SS1 ;
if ( bAdjust ) T.tm_sec -= Position::Adjust();
T.tm_year = YY -1900 ;
T.tm_mon = MM -1 ;
@@ -441,7 +441,7 @@ int timeZoneAdjust()
struct tm lcopy = *localtime(&now);
time_t gmt = timegm(&lcopy) ; // timegm modifies lcopy
offset = (int) ( ((long signed int) gmt) - ((long signed int) now) ) ;
-#elif defined(OS_SOLARIS)
+#elif defined(OS_SOLARIS) || defined(__sun__)
struct tm local = *localtime(&now) ;
time_t local_tt = (int) mktime(&local);
time_t time_gmt = (int) mktime(gmtime(&now));
diff --git a/src/futils.cpp b/src/futils.cpp
index b4c76234..abfb9723 100644
--- a/src/futils.cpp
+++ b/src/futils.cpp
@@ -24,6 +24,7 @@
#include "futils.hpp"
#include "datasets.hpp"
#include "enforce.hpp"
+#include "image_int.hpp"
// + standard includes
#include <sys/types.h>
@@ -492,6 +493,15 @@ namespace Exiv2 {
// release resources
if ( procs ) procstat_freeprocs(procstat, procs);
if ( procstat ) procstat_close(procstat);
+ #elif defined(__sun__)
+ // https://stackoverflow.com/questions/47472762/on-solaris-how-to-get-the-full-path-of-executable-of-running-process-programatic const char* proc = Internal::stringFormat("/proc/%d/path/a.out",getpid()).c_str();
+ const char* proc = Internal::stringFormat("/proc/%d/path/a.out",getpid()).c_str();
+ char path[500];
+ ssize_t l = readlink (proc,path,sizeof(path)-1);
+ if (l>0) {
+ path[l]=0;
+ ret = path;
+ }
#elif defined(__unix__)
// http://stackoverflow.com/questions/606041/how-do-i-get-the-path-of-a-process-in-unix-linux
char path[500];
diff --git a/src/version.cpp b/src/version.cpp
index 274ca3d6..4e67267c 100644
--- a/src/version.cpp
+++ b/src/version.cpp
@@ -29,6 +29,7 @@
#include "version.hpp"
#include "makernote_int.hpp"
#include "futils.hpp"
+#include "image_int.hpp"
// Adobe XMP Toolkit
#ifdef EXV_HAVE_XMP_TOOLKIT
@@ -199,7 +200,23 @@ static Exiv2::StringVector getLoadedLibraries()
if ( files ) procstat_freefiles(procstat, files);
if ( procs ) procstat_freeprocs(procstat, procs);
if ( procstat ) procstat_close (procstat);
-
+#elif defined(__sun__)
+ // https://www.oracle.com/technetwork/server-storage/solaris10/solaris-linux-app-139382.html
+ const int pid = getpid();
+ const char* tmp = Exiv2::Internal::stringFormat("/tmp/%d",pid).c_str();
+ const char* cmd = Exiv2::Internal::stringFormat("pmap %d > %s",pid,tmp).c_str();
+ system (cmd);
+ std::ifstream maps(tmp,std::ifstream::in);
+ std::string string ;
+ while ( std::getline(maps,string) ) {
+ std::size_t pos = string.find_last_of(' ');
+ if ( pos != std::string::npos ) {
+ std::string path = string.substr(pos+1);
+ if ( path[0] != '-' ) {
+ pushPath(path,libs,paths);
+ }
+ }
+ }
#elif defined(__unix__)
// read file /proc/self/maps which has a list of files in memory
std::ifstream maps("/proc/self/maps",std::ifstream::in);
@@ -218,13 +235,13 @@ static Exiv2::StringVector getLoadedLibraries()
void Exiv2::dumpLibraryInfo(std::ostream& os,const exv_grep_keys_t& keys)
{
int bits = 8*sizeof(void*);
-#ifdef NDEBUG
- int debug=0;
-#else
+#ifdef DEBUG
int debug=1;
+#else
+ int debug=0;
#endif
-#if defined(DLL_EXPORT)
+#if defined(BUILD_SHARED_LIBS)
int dll=1;
#else
int dll=0;
@@ -264,7 +281,7 @@ void Exiv2::dumpLibraryInfo(std::ostream& os,const exv_grep_keys_t& keys)
"unknown" ;
#endif
-#if defined(__SUNPRO_CC) || defined (__SUNPRO_C)
+#if defined(__SUNPRO_CC) || defined (__SUNPRO_C) || defined(__sun__)
#define __oracle__
#endif
@@ -293,6 +310,8 @@ void Exiv2::dumpLibraryInfo(std::ostream& os,const exv_grep_keys_t& keys)
"netbsd";
#elif defined(__FreeBSD__)
"freebsd";
+#elif defined(__oracle__) || defined(OS_SOLARIS) || defined(__sun__)
+ "solaris";
#elif defined(__linux__)
"linux";
#else
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 9,359 | 207,837 |
[
"Exiv2",
"exiv2"
] | After some time off, I was coming back to try and use libexiv under Windows and I see that much has changed.
Is this the proper place to get help with sorting out the process of building the libs in this environment? Assuming so:
I have tried to follow the instructions for windows from https://github.com/Exiv2/exiv2/blob/master/README-CONAN.md#1-1, but am stuck when I try to run my first conan build.
It seems I have an installed version of Python 3.7.1 and have succeeded in installing conan - version1.16.0, but that is as far as I have gotten.
The next step from the instructions are
cd $EXIV2_ROOT
but, this obviously fails, because I have not defined EXIV2_ROOT and have no clue what it should be | Building exiv2 libraries under Win 10 with MSVC 2017 | https://api.github.com/repos/Exiv2/exiv2/issues/901/comments | 23 | 2019-06-09T01:45:01 | "2020-05-13T09:54:17Z" | https://github.com/Exiv2/exiv2/issues/901 | 453,852,549 | 901 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Building exiv2 libraries under Win 10 with MSVC 2017
Issue date:
--- start body ---
After some time off, I was coming back to try and use libexiv under Windows and I see that much has changed.
Is this the proper place to get help with sorting out the process of building the libs in this environment? Assuming so:
I have tried to follow the instructions for windows from https://github.com/Exiv2/exiv2/blob/master/README-CONAN.md#1-1, but am stuck when I try to run my first conan build.
It seems I have an installed version of Python 3.7.1 and have succeeded in installing conan - version1.16.0, but that is as far as I have gotten.
The next step from the instructions are
cd $EXIV2_ROOT
but, this obviously fails, because I have not defined EXIV2_ROOT and have no clue what it should be
--- end body ---
comments :
--- start comments ---
--- end comments --- | 924 | 207,838 |
[
"Exiv2",
"exiv2"
] | We should enable git LFS or create an additional repository with git LFS enabled to store large test files, like the one mentioned in #810.
Any objections, suggestions, comments? | Enable git LFS | https://api.github.com/repos/Exiv2/exiv2/issues/896/comments | 2 | 2019-06-03T22:57:29 | "2023-11-04T16:32:18Z" | https://github.com/Exiv2/exiv2/issues/896 | 451,724,711 | 896 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Enable git LFS
Issue date:
--- start body ---
We should enable git LFS or create an additional repository with git LFS enabled to store large test files, like the one mentioned in #810.
Any objections, suggestions, comments?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 356 | 207,839 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
When using exiv2 0.27.1, and renaming a file, the format string is now treated as a filename and ignored, also a temporal file remains in the directory, and new ICC Profile error messages appear.
**To Reproduce**
```
exiv2 mv -F -t -r '%Y%m%d' PHOTO.JPG
Exiv2 exception in rename action for file -F:
Not a valid ICC Profile
Exiv2 exception in rename action for file -t:
Not a valid ICC Profile
Exiv2 exception in rename action for file -r:
Not a valid ICC Profile
%Y%m%d: Failed to open the file
exiv2: File `./20190529_171831.JPG' exists. [O]verwrite, [r]ename or [s]kip? O
```
(In this example, the file was previously renamed to the default format string, even when a new string is used, as in the example)
Also, files with names like `1559227727.exiv2_temp` are kept in the directory after finishing. Didn't happened before.
**Expected behavior**
The format string should be accepted and in the example, renamed to `20190529.JPG`
**Desktop (please complete the following information):**
- OS: Arch Linux
Using prepackaged file from https://www.archlinux.org/packages/extra/x86_64/exiv2/
**Additional context**
Noticed after a script I use when connecting the camera failed to produce the expected results. The script used the parameters as above.
| 'exiv2 mv -r' not accepting format | https://api.github.com/repos/Exiv2/exiv2/issues/895/comments | 5 | 2019-05-30T15:07:53 | "2019-06-06T12:06:02Z" | https://github.com/Exiv2/exiv2/issues/895 | 450,355,119 | 895 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : 'exiv2 mv -r' not accepting format
Issue date:
--- start body ---
**Describe the bug**
When using exiv2 0.27.1, and renaming a file, the format string is now treated as a filename and ignored, also a temporal file remains in the directory, and new ICC Profile error messages appear.
**To Reproduce**
```
exiv2 mv -F -t -r '%Y%m%d' PHOTO.JPG
Exiv2 exception in rename action for file -F:
Not a valid ICC Profile
Exiv2 exception in rename action for file -t:
Not a valid ICC Profile
Exiv2 exception in rename action for file -r:
Not a valid ICC Profile
%Y%m%d: Failed to open the file
exiv2: File `./20190529_171831.JPG' exists. [O]verwrite, [r]ename or [s]kip? O
```
(In this example, the file was previously renamed to the default format string, even when a new string is used, as in the example)
Also, files with names like `1559227727.exiv2_temp` are kept in the directory after finishing. Didn't happened before.
**Expected behavior**
The format string should be accepted and in the example, renamed to `20190529.JPG`
**Desktop (please complete the following information):**
- OS: Arch Linux
Using prepackaged file from https://www.archlinux.org/packages/extra/x86_64/exiv2/
**Additional context**
Noticed after a script I use when connecting the camera failed to produce the expected results. The script used the parameters as above.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,506 | 207,840 |
[
"Exiv2",
"exiv2"
] | I'm the maintainer of the Python-3 binding of exiv2.
The version 0.27 of exiv2 had introduced an issue into the binding with the error codes.
Then I've changed my code like this:
#if EXIV2_MAJOR_VERSION >= 1 || (EXIV2_MAJOR_VERSION == 0 && EXIV2_MINOR_VERSION >= 27)
#define HAVE_EXIV2_ERROR_CODE
#endif
#ifdef HAVE_EXIV2_ERROR_CODE
// version >= 0.27
#define CHECK_METADATA_READ \
if (!_dataRead) throw Exiv2::Error(Exiv2::kerErrorMessage, "metadata not read");
#else
// version < 0.27
#define CHECK_METADATA_READ \
if (!_dataRead) throw Exiv2::Error(METADATA_NOT_READ);
#endif
That's solved the problem. (compiled on Linux with g++ and on OS X with clang)
But today, on OS X with the latest exiv2-0.27.2 the compilation failed with:
src/exiv2wrapper.cpp:150:12 error: no type named 'Error' in namespace 'Exiv2'
Exiv2::Error error = Exiv2::Error(Exiv2::kerSuccess);
~~~~~~~^
Is there a new change in 0.27.0 ?
| error: no type named 'Error' in namespace 'Exiv2' | https://api.github.com/repos/Exiv2/exiv2/issues/893/comments | 5 | 2019-05-27T10:23:29 | "2019-05-28T09:42:08Z" | https://github.com/Exiv2/exiv2/issues/893 | 448,780,530 | 893 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : error: no type named 'Error' in namespace 'Exiv2'
Issue date:
--- start body ---
I'm the maintainer of the Python-3 binding of exiv2.
The version 0.27 of exiv2 had introduced an issue into the binding with the error codes.
Then I've changed my code like this:
#if EXIV2_MAJOR_VERSION >= 1 || (EXIV2_MAJOR_VERSION == 0 && EXIV2_MINOR_VERSION >= 27)
#define HAVE_EXIV2_ERROR_CODE
#endif
#ifdef HAVE_EXIV2_ERROR_CODE
// version >= 0.27
#define CHECK_METADATA_READ \
if (!_dataRead) throw Exiv2::Error(Exiv2::kerErrorMessage, "metadata not read");
#else
// version < 0.27
#define CHECK_METADATA_READ \
if (!_dataRead) throw Exiv2::Error(METADATA_NOT_READ);
#endif
That's solved the problem. (compiled on Linux with g++ and on OS X with clang)
But today, on OS X with the latest exiv2-0.27.2 the compilation failed with:
src/exiv2wrapper.cpp:150:12 error: no type named 'Error' in namespace 'Exiv2'
Exiv2::Error error = Exiv2::Error(Exiv2::kerSuccess);
~~~~~~~^
Is there a new change in 0.27.0 ?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,166 | 207,841 |
[
"Exiv2",
"exiv2"
] | @nehaljwani shared something about ABI/API compatibility of different releases of Exiv2. I think it was this: https://abi-laboratory.pro/index.php?view=timeline&l=exiv2
In the past, I have not worried about API/ABI compatibility. Every release of Exiv2 (v0.24, v0.25 etc) has similar and slightly different APIs. They have a different set of headers and different library filenames. This is βopen-sourceβ, and users are expected to recompile applications for different versions of Exiv2.
However, with βthe dotsβ we have a different scenario. In February, I had an email conversation with Dan Bricklin (Yes, the guy who invented Lotus-1-2-3) and he wanted to use Exiv2 for one of his projects. He had several conditions and one was βhe could replace DLLs in an existing applicationβ. Dan had a couple of features he wanted us to add to Exiv2 and we didnβt shake hands on a deal. I couldnβt undertake the necessary work and I canβt ask any member of Team Exiv2 to deliver anything to Danβs schedule. We didnβt discuss money.
On 2019-05-23, I built Exiv2 0.27.0 and ran the test suite on MacOS-X. Then I build Exiv2 0.27.2.99 (0.27 maintenance development for v0.27.2). I successfully ran the 0.27 test suite using the 0.27.2.99 .dylib. Very good. Very pleased that this is working OK. I didnβt try on other platforms such as Windows or Linux.
Iβve written a 1 line command to extract the API from the library:
$ nm -g --demangle libexiv2.0.27.0.dylib | grep ' T ' | cut -d' ' -f 3- | sort > ~/temp/27.0.txt
This is a 4606 line file. (4610 lines for 0.27.2.99). So small changes in the API. Nothing that seems to be a disaster. I would like folks to be able to replace 0.27 DLLs for existing applications without recompiling anything.
Here's the diff. I'll see if this can be reduced. The remaining differences will be documented in the release notes for v0.27.2
I've invited Nehal to get involved in this effort and it fits well with tasks he has been assigned at work. So, Nehal will be the expert on API/ABI compatibility for "the dots".
I don't see any reason to be concerned about API/ABI compatibility for v0.28.
```
689 rmills@rmillsmbp:/Applications/Xcode.app $ diff ~/temp/27.0.txt ~/temp/27.2.txt
774c774
< Exiv2::Internal::LensIdFct const* Exiv2::find<Exiv2::Internal::LensIdFct const, long, 46>(Exiv2::Internal::LensIdFct const (&) [46], long const&)
---
> Exiv2::Internal::LensIdFct const* Exiv2::find<Exiv2::Internal::LensIdFct const, long, 49>(Exiv2::Internal::LensIdFct const (&) [49], long const&)
1088c1088
< Exiv2::Internal::TagDetails const* Exiv2::find<Exiv2::Internal::TagDetails const, Exiv2::Internal::LensTypeAndFocalLengthAndMaxAperture, 352>(Exiv2::Internal::TagDetails const (&) [352], Exiv2::Internal::LensTypeAndFocalLengthAndMaxAperture const&)
---
> Exiv2::Internal::TagDetails const* Exiv2::find<Exiv2::Internal::TagDetails const, Exiv2::Internal::LensTypeAndFocalLengthAndMaxAperture, 360>(Exiv2::Internal::TagDetails const (&) [360], Exiv2::Internal::LensTypeAndFocalLengthAndMaxAperture const&)
1109d1108
< Exiv2::Internal::TagDetails const* Exiv2::find<Exiv2::Internal::TagDetails const, long, 352>(Exiv2::Internal::TagDetails const (&) [352], long const&)
1110a1110
> Exiv2::Internal::TagDetails const* Exiv2::find<Exiv2::Internal::TagDetails const, long, 360>(Exiv2::Internal::TagDetails const (&) [360], long const&)
2403c2403
< Exiv2::WebPImage::decodeChunks(unsigned long long)
---
> Exiv2::WebPImage::decodeChunks(long)
2728a2729
> Exiv2::readChunk(Exiv2::DataBuf&, Exiv2::BasicIo&)
3233a3235
> _exvGettext(char const*)
3235a3238
> bool Safe::Internal::builtin_add_overflow<long>(long, long, long&)
3272a3276
> long Safe::add<long>(long, long)
3977c3981
< std::__1::basic_ostream<char, std::__1::char_traits<char> >& Exiv2::Internal::printTag<352, Exiv2::Internal::canonCsLensType>(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, Exiv2::Value const&, Exiv2::ExifData const*)
---
> std::__1::basic_ostream<char, std::__1::char_traits<char> >& Exiv2::Internal::printTag<360, Exiv2::Internal::canonCsLensType>(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, Exiv2::Value const&, Exiv2::ExifData const*)
690 rmills@rmillsmbp:/Applications/Xcode.app $
```
I will investigate the differences and they will be eliminated or justified in releasenotes/releasenotes.txt
| API Compatibility v0.27 vs v0.27 "dots" | https://api.github.com/repos/Exiv2/exiv2/issues/890/comments | 12 | 2019-05-25T09:51:03 | "2021-03-12T18:36:56Z" | https://github.com/Exiv2/exiv2/issues/890 | 448,446,780 | 890 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : API Compatibility v0.27 vs v0.27 "dots"
Issue date:
--- start body ---
@nehaljwani shared something about ABI/API compatibility of different releases of Exiv2. I think it was this: https://abi-laboratory.pro/index.php?view=timeline&l=exiv2
In the past, I have not worried about API/ABI compatibility. Every release of Exiv2 (v0.24, v0.25 etc) has similar and slightly different APIs. They have a different set of headers and different library filenames. This is βopen-sourceβ, and users are expected to recompile applications for different versions of Exiv2.
However, with βthe dotsβ we have a different scenario. In February, I had an email conversation with Dan Bricklin (Yes, the guy who invented Lotus-1-2-3) and he wanted to use Exiv2 for one of his projects. He had several conditions and one was βhe could replace DLLs in an existing applicationβ. Dan had a couple of features he wanted us to add to Exiv2 and we didnβt shake hands on a deal. I couldnβt undertake the necessary work and I canβt ask any member of Team Exiv2 to deliver anything to Danβs schedule. We didnβt discuss money.
On 2019-05-23, I built Exiv2 0.27.0 and ran the test suite on MacOS-X. Then I build Exiv2 0.27.2.99 (0.27 maintenance development for v0.27.2). I successfully ran the 0.27 test suite using the 0.27.2.99 .dylib. Very good. Very pleased that this is working OK. I didnβt try on other platforms such as Windows or Linux.
Iβve written a 1 line command to extract the API from the library:
$ nm -g --demangle libexiv2.0.27.0.dylib | grep ' T ' | cut -d' ' -f 3- | sort > ~/temp/27.0.txt
This is a 4606 line file. (4610 lines for 0.27.2.99). So small changes in the API. Nothing that seems to be a disaster. I would like folks to be able to replace 0.27 DLLs for existing applications without recompiling anything.
Here's the diff. I'll see if this can be reduced. The remaining differences will be documented in the release notes for v0.27.2
I've invited Nehal to get involved in this effort and it fits well with tasks he has been assigned at work. So, Nehal will be the expert on API/ABI compatibility for "the dots".
I don't see any reason to be concerned about API/ABI compatibility for v0.28.
```
689 rmills@rmillsmbp:/Applications/Xcode.app $ diff ~/temp/27.0.txt ~/temp/27.2.txt
774c774
< Exiv2::Internal::LensIdFct const* Exiv2::find<Exiv2::Internal::LensIdFct const, long, 46>(Exiv2::Internal::LensIdFct const (&) [46], long const&)
---
> Exiv2::Internal::LensIdFct const* Exiv2::find<Exiv2::Internal::LensIdFct const, long, 49>(Exiv2::Internal::LensIdFct const (&) [49], long const&)
1088c1088
< Exiv2::Internal::TagDetails const* Exiv2::find<Exiv2::Internal::TagDetails const, Exiv2::Internal::LensTypeAndFocalLengthAndMaxAperture, 352>(Exiv2::Internal::TagDetails const (&) [352], Exiv2::Internal::LensTypeAndFocalLengthAndMaxAperture const&)
---
> Exiv2::Internal::TagDetails const* Exiv2::find<Exiv2::Internal::TagDetails const, Exiv2::Internal::LensTypeAndFocalLengthAndMaxAperture, 360>(Exiv2::Internal::TagDetails const (&) [360], Exiv2::Internal::LensTypeAndFocalLengthAndMaxAperture const&)
1109d1108
< Exiv2::Internal::TagDetails const* Exiv2::find<Exiv2::Internal::TagDetails const, long, 352>(Exiv2::Internal::TagDetails const (&) [352], long const&)
1110a1110
> Exiv2::Internal::TagDetails const* Exiv2::find<Exiv2::Internal::TagDetails const, long, 360>(Exiv2::Internal::TagDetails const (&) [360], long const&)
2403c2403
< Exiv2::WebPImage::decodeChunks(unsigned long long)
---
> Exiv2::WebPImage::decodeChunks(long)
2728a2729
> Exiv2::readChunk(Exiv2::DataBuf&, Exiv2::BasicIo&)
3233a3235
> _exvGettext(char const*)
3235a3238
> bool Safe::Internal::builtin_add_overflow<long>(long, long, long&)
3272a3276
> long Safe::add<long>(long, long)
3977c3981
< std::__1::basic_ostream<char, std::__1::char_traits<char> >& Exiv2::Internal::printTag<352, Exiv2::Internal::canonCsLensType>(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, Exiv2::Value const&, Exiv2::ExifData const*)
---
> std::__1::basic_ostream<char, std::__1::char_traits<char> >& Exiv2::Internal::printTag<360, Exiv2::Internal::canonCsLensType>(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, Exiv2::Value const&, Exiv2::ExifData const*)
690 rmills@rmillsmbp:/Applications/Xcode.app $
```
I will investigate the differences and they will be eliminated or justified in releasenotes/releasenotes.txt
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,618 | 207,842 |
[
"Exiv2",
"exiv2"
] | Sorry to do this via an issue...
I just noticed by my CI failing that master introduced an API change (long -> size_t). Do you provide a way to get notified about this by some kind of mailinglist etc? If not, consider this a feature request for providing this or something similar | Announcement platform for API changes | https://api.github.com/repos/Exiv2/exiv2/issues/883/comments | 9 | 2019-05-19T10:55:23 | "2019-05-20T11:31:57Z" | https://github.com/Exiv2/exiv2/issues/883 | 445,806,034 | 883 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Announcement platform for API changes
Issue date:
--- start body ---
Sorry to do this via an issue...
I just noticed by my CI failing that master introduced an API change (long -> size_t). Do you provide a way to get notified about this by some kind of mailinglist etc? If not, consider this a feature request for providing this or something similar
--- end body ---
comments :
--- start comments ---
--- end comments --- | 481 | 207,843 |
[
"Exiv2",
"exiv2"
] | I'm using exiv2 version 0.27.1 on Linux and Windows,
and this bug occurs on both OS
The bug concerns the bad interpretation of the tags FileNumber and DirectoryNumber (and maybe others) in NEF Files of my Nikon D90, but there is not in NEF files of my Nikon D7500.
If I take the values from NikonD90, and I divide them by 256, I get the correct values.
Is it possible that it depends on the different byteorder?
**MM in D90** (wrong interpretation)
**II in D7500** (good interpretation)
| Nikon D90 - wrong FileNumber and DirectoryNumber | https://api.github.com/repos/Exiv2/exiv2/issues/880/comments | 8 | 2019-05-17T18:23:19 | "2019-05-20T13:02:10Z" | https://github.com/Exiv2/exiv2/issues/880 | 445,563,042 | 880 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Nikon D90 - wrong FileNumber and DirectoryNumber
Issue date:
--- start body ---
I'm using exiv2 version 0.27.1 on Linux and Windows,
and this bug occurs on both OS
The bug concerns the bad interpretation of the tags FileNumber and DirectoryNumber (and maybe others) in NEF Files of my Nikon D90, but there is not in NEF files of my Nikon D7500.
If I take the values from NikonD90, and I divide them by 256, I get the correct values.
Is it possible that it depends on the different byteorder?
**MM in D90** (wrong interpretation)
**II in D7500** (good interpretation)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 710 | 207,844 |
[
"Exiv2",
"exiv2"
] | This is embarrassing. I failed to spot this when I was fixing #845. The call to `atol` at [pngchunk_int.cpp:670](https://github.com/Exiv2/exiv2/blob/1c1436e94eb5d5390f93ccf82b5cc72da70f5631/src/pngchunk_int.cpp#L670) can read off the end of the buffer, because there is no guarantee that the string is `'\0'` terminated.
Reproducible on the 0.27-maintenance branch ([1c1436e](https://github.com/Exiv2/exiv2/commit/1c1436e94eb5d5390f93ccf82b5cc72da70f5631)):
```
exiv2 issue_869_poc.png
```
Note: the PoC does not make `exiv2` crash. So you need to set a breakpoint at [pngchunk_int.cpp:670](https://github.com/Exiv2/exiv2/blob/1c1436e94eb5d5390f93ccf82b5cc72da70f5631/src/pngchunk_int.cpp#L670) to see the out-of-bounds read happen. | Out of bounds read in PngChunk::readRawProfile() | https://api.github.com/repos/Exiv2/exiv2/issues/869/comments | 0 | 2019-05-16T11:58:05 | "2019-05-17T15:00:33Z" | https://github.com/Exiv2/exiv2/issues/869 | 444,914,064 | 869 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Out of bounds read in PngChunk::readRawProfile()
Issue date:
--- start body ---
This is embarrassing. I failed to spot this when I was fixing #845. The call to `atol` at [pngchunk_int.cpp:670](https://github.com/Exiv2/exiv2/blob/1c1436e94eb5d5390f93ccf82b5cc72da70f5631/src/pngchunk_int.cpp#L670) can read off the end of the buffer, because there is no guarantee that the string is `'\0'` terminated.
Reproducible on the 0.27-maintenance branch ([1c1436e](https://github.com/Exiv2/exiv2/commit/1c1436e94eb5d5390f93ccf82b5cc72da70f5631)):
```
exiv2 issue_869_poc.png
```
Note: the PoC does not make `exiv2` crash. So you need to set a breakpoint at [pngchunk_int.cpp:670](https://github.com/Exiv2/exiv2/blob/1c1436e94eb5d5390f93ccf82b5cc72da70f5631/src/pngchunk_int.cpp#L670) to see the out-of-bounds read happen.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,073 | 207,845 |
[
"Exiv2",
"exiv2"
] | There's an out-of-bounds read at [iptc.cpp:465](https://github.com/Exiv2/exiv2/blob/1c1436e94eb5d5390f93ccf82b5cc72da70f5631/src/iptc.cpp#L465). `sizeOfSize <= 4` it can only read a few bytes beyond the end of the buffer.
Reproducible on the 0.27-maintenance branch ([1c1436e](https://github.com/Exiv2/exiv2/commit/1c1436e94eb5d5390f93ccf82b5cc72da70f5631)):
```
exiv2 issue_867_poc.jpg
```
Note: the PoC does not make `exiv2` crash. So you need to set a breakpoint at [iptc.cpp:465](https://github.com/Exiv2/exiv2/blob/1c1436e94eb5d5390f93ccf82b5cc72da70f5631/src/iptc.cpp#L465) to see the out-of-bounds read happen. | Out of bounds read in IptcParser::decode() | https://api.github.com/repos/Exiv2/exiv2/issues/867/comments | 0 | 2019-05-16T10:01:39 | "2019-05-17T05:09:37Z" | https://github.com/Exiv2/exiv2/issues/867 | 444,865,170 | 867 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Out of bounds read in IptcParser::decode()
Issue date:
--- start body ---
There's an out-of-bounds read at [iptc.cpp:465](https://github.com/Exiv2/exiv2/blob/1c1436e94eb5d5390f93ccf82b5cc72da70f5631/src/iptc.cpp#L465). `sizeOfSize <= 4` it can only read a few bytes beyond the end of the buffer.
Reproducible on the 0.27-maintenance branch ([1c1436e](https://github.com/Exiv2/exiv2/commit/1c1436e94eb5d5390f93ccf82b5cc72da70f5631)):
```
exiv2 issue_867_poc.jpg
```
Note: the PoC does not make `exiv2` crash. So you need to set a breakpoint at [iptc.cpp:465](https://github.com/Exiv2/exiv2/blob/1c1436e94eb5d5390f93ccf82b5cc72da70f5631/src/iptc.cpp#L465) to see the out-of-bounds read happen.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 952 | 207,846 |
[
"Exiv2",
"exiv2"
] | There is no bounds check on the size of `jpg_img_len` at [rafimage.cpp:300](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/src/rafimage.cpp#L300), leading to an out-of-memory exception.
Reproducible on the 0.27-maintenance branch ([c0ecc2a](https://github.com/Exiv2/exiv2/commit/c0ecc2ae36f34462be98623deb85ba1747ae2175)):
```
exiv2 issue_857_poc.jpg
``` | Out of memory error due to unchecked allocation size in RafImage::readMetadata() | https://api.github.com/repos/Exiv2/exiv2/issues/857/comments | 0 | 2019-05-14T14:16:54 | "2019-05-16T13:39:27Z" | https://github.com/Exiv2/exiv2/issues/857 | 443,941,851 | 857 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Out of memory error due to unchecked allocation size in RafImage::readMetadata()
Issue date:
--- start body ---
There is no bounds check on the size of `jpg_img_len` at [rafimage.cpp:300](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/src/rafimage.cpp#L300), leading to an out-of-memory exception.
Reproducible on the 0.27-maintenance branch ([c0ecc2a](https://github.com/Exiv2/exiv2/commit/c0ecc2ae36f34462be98623deb85ba1747ae2175)):
```
exiv2 issue_857_poc.jpg
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 754 | 207,847 |
[
"Exiv2",
"exiv2"
] | There are several out-of-memory errors in [PsdImage::readResourceBlock()](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/src/psdimage.cpp#L242) because there was is no bounds check of `resourceSize` in [PsdImage::readMetadata()](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/src/psdimage.cpp#L226).
Reproducible on the 0.27-maintenance branch ([c0ecc2a](https://github.com/Exiv2/exiv2/commit/c0ecc2ae36f34462be98623deb85ba1747ae2175)):
```
exiv2 issue_855_poc.jpg
``` | Out of memory error due to unchecked allocation size in PsdImage::readMetadata() | https://api.github.com/repos/Exiv2/exiv2/issues/855/comments | 0 | 2019-05-14T12:14:06 | "2019-05-16T09:39:22Z" | https://github.com/Exiv2/exiv2/issues/855 | 443,880,396 | 855 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Out of memory error due to unchecked allocation size in PsdImage::readMetadata()
Issue date:
--- start body ---
There are several out-of-memory errors in [PsdImage::readResourceBlock()](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/src/psdimage.cpp#L242) because there was is no bounds check of `resourceSize` in [PsdImage::readMetadata()](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/src/psdimage.cpp#L226).
Reproducible on the 0.27-maintenance branch ([c0ecc2a](https://github.com/Exiv2/exiv2/commit/c0ecc2ae36f34462be98623deb85ba1747ae2175)):
```
exiv2 issue_855_poc.jpg
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 898 | 207,848 |
[
"Exiv2",
"exiv2"
] | There is an out-of-memory error at [jpgimage.cpp:484](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/src/jpgimage.cpp#L484) because there is no bounds check on the value of `s`.
Reproducible on the 0.27-maintenance branch ([c0ecc2a](https://github.com/Exiv2/exiv2/commit/c0ecc2ae36f34462be98623deb85ba1747ae2175)):
```
exiv2 issue_853_poc.jpg
``` | Out of memory error due to unchecked allocation size in JpegBase::readMetadata() | https://api.github.com/repos/Exiv2/exiv2/issues/853/comments | 0 | 2019-05-14T10:25:45 | "2019-05-16T07:41:56Z" | https://github.com/Exiv2/exiv2/issues/853 | 443,834,748 | 853 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Out of memory error due to unchecked allocation size in JpegBase::readMetadata()
Issue date:
--- start body ---
There is an out-of-memory error at [jpgimage.cpp:484](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/src/jpgimage.cpp#L484) because there is no bounds check on the value of `s`.
Reproducible on the 0.27-maintenance branch ([c0ecc2a](https://github.com/Exiv2/exiv2/commit/c0ecc2ae36f34462be98623deb85ba1747ae2175)):
```
exiv2 issue_853_poc.jpg
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 746 | 207,849 |
[
"Exiv2",
"exiv2"
] | There is a denial of service bug in the loop at [XMPUtils.cpp:245](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/xmpsdk/src/XMPUtils.cpp#L245) because `time->day` can be very large. This loop adjusts out-of-bounds days by subtracting one month at a time. Since the type of `time->day` is `long`, this can take a very long time.
Reproducible on the 0.27-maintenance branch ([c0ecc2a](https://github.com/Exiv2/exiv2/commit/c0ecc2ae36f34462be98623deb85ba1747ae2175)):
```
exiv2 issue_851_poc.jpg
``` | Denial of service in XMPUtils AdjustTimeOverflow() | https://api.github.com/repos/Exiv2/exiv2/issues/851/comments | 5 | 2019-05-14T09:27:14 | "2019-05-18T11:44:57Z" | https://github.com/Exiv2/exiv2/issues/851 | 443,807,078 | 851 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Denial of service in XMPUtils AdjustTimeOverflow()
Issue date:
--- start body ---
There is a denial of service bug in the loop at [XMPUtils.cpp:245](https://github.com/Exiv2/exiv2/blob/c0ecc2ae36f34462be98623deb85ba1747ae2175/xmpsdk/src/XMPUtils.cpp#L245) because `time->day` can be very large. This loop adjusts out-of-bounds days by subtracting one month at a time. Since the type of `time->day` is `long`, this can take a very long time.
Reproducible on the 0.27-maintenance branch ([c0ecc2a](https://github.com/Exiv2/exiv2/commit/c0ecc2ae36f34462be98623deb85ba1747ae2175)):
```
exiv2 issue_851_poc.jpg
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 867 | 207,850 |
[
"Exiv2",
"exiv2"
] | Unchecked allocation size can cause a `std::bad_alloc` exception at [pgfimage.cpp:140](https://github.com/Exiv2/exiv2/blob/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b/src/pgfimage.cpp#L140).
Reproducible on the 0.27-maintenance branch ([f4a37c6](https://github.com/Exiv2/exiv2/commit/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b)):
```
exiv2 issue_847_poc.png
``` | Out of memory error due to unchecked allocation size in PgfImage::readMetadata() | https://api.github.com/repos/Exiv2/exiv2/issues/847/comments | 0 | 2019-05-13T15:40:02 | "2019-05-15T11:10:47Z" | https://github.com/Exiv2/exiv2/issues/847 | 443,469,030 | 847 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Out of memory error due to unchecked allocation size in PgfImage::readMetadata()
Issue date:
--- start body ---
Unchecked allocation size can cause a `std::bad_alloc` exception at [pgfimage.cpp:140](https://github.com/Exiv2/exiv2/blob/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b/src/pgfimage.cpp#L140).
Reproducible on the 0.27-maintenance branch ([f4a37c6](https://github.com/Exiv2/exiv2/commit/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b)):
```
exiv2 issue_847_poc.png
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 726 | 207,851 |
[
"Exiv2",
"exiv2"
] | The attached file causes a `std::bad_alloc` exception in `exiv2`.
The bug is that there is no bounds check on the value of `length` at [pngchunk_int.cpp:669](https://github.com/Exiv2/exiv2/blob/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b/src/pngchunk_int.cpp#L669).
Reproducible on the 0.27-maintenance branch ([f4a37c6](https://github.com/Exiv2/exiv2/commit/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b)):
```
exiv2 issue_845_poc.png
```
| Out of memory error due to unchecked allocation size in PngChunk::parseChunkContent() | https://api.github.com/repos/Exiv2/exiv2/issues/845/comments | 2 | 2019-05-13T13:42:43 | "2019-07-01T09:04:40Z" | https://github.com/Exiv2/exiv2/issues/845 | 443,405,977 | 845 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Out of memory error due to unchecked allocation size in PngChunk::parseChunkContent()
Issue date:
--- start body ---
The attached file causes a `std::bad_alloc` exception in `exiv2`.
The bug is that there is no bounds check on the value of `length` at [pngchunk_int.cpp:669](https://github.com/Exiv2/exiv2/blob/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b/src/pngchunk_int.cpp#L669).
Reproducible on the 0.27-maintenance branch ([f4a37c6](https://github.com/Exiv2/exiv2/commit/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b)):
```
exiv2 issue_845_poc.png
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 811 | 207,852 |
[
"Exiv2",
"exiv2"
] | The problem is that the calculation of `o+2` can overflow at [crwimage_int.cpp:284](https://github.com/Exiv2/exiv2/blob/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b/src/crwimage_int.cpp#L284).
Reproducible on the 0.27-maintenance branch ([f4a37c6](https://github.com/Exiv2/exiv2/commit/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b)):
```
exiv2 issue_843_poc.jpg
``` | Integer overflow causes out-of-bounds read in CiffDirectory::readDirectory() | https://api.github.com/repos/Exiv2/exiv2/issues/843/comments | 2 | 2019-05-13T12:58:33 | "2019-07-01T09:02:45Z" | https://github.com/Exiv2/exiv2/issues/843 | 443,384,339 | 843 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Integer overflow causes out-of-bounds read in CiffDirectory::readDirectory()
Issue date:
--- start body ---
The problem is that the calculation of `o+2` can overflow at [crwimage_int.cpp:284](https://github.com/Exiv2/exiv2/blob/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b/src/crwimage_int.cpp#L284).
Reproducible on the 0.27-maintenance branch ([f4a37c6](https://github.com/Exiv2/exiv2/commit/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b)):
```
exiv2 issue_843_poc.jpg
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 723 | 207,853 |
[
"Exiv2",
"exiv2"
] | The attached file causes an assertion failure in `exiv2`.
Reproducible on the 0.27-maintenance branch ([f4a37c6](https://github.com/Exiv2/exiv2/commit/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b)):
```
exiv2 issue_841_poc.jpg
``` | Invalid data location in CRW image causes exiv2 to crash | https://api.github.com/repos/Exiv2/exiv2/issues/841/comments | 3 | 2019-05-13T11:53:23 | "2019-07-01T09:05:47Z" | https://github.com/Exiv2/exiv2/issues/841 | 443,356,775 | 841 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Invalid data location in CRW image causes exiv2 to crash
Issue date:
--- start body ---
The attached file causes an assertion failure in `exiv2`.
Reproducible on the 0.27-maintenance branch ([f4a37c6](https://github.com/Exiv2/exiv2/commit/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b)):
```
exiv2 issue_841_poc.jpg
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 572 | 207,854 |
[
"Exiv2",
"exiv2"
] | This bug was found by AFL. The value of `size_` has not been checked before [this line of code](https://github.com/Exiv2/exiv2/blob/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b/src/preview.cpp#L809), leading to a large allocation. This can cause `exiv2` to crash with an out-of-memory error if less than 4GB RAM is available.
Reproducible on the 0.27-maintenance branch (f4a37c6):
```
exiv2 issue_839_poc.jpg
``` | Out of memory error due to unchecked allocation size in LoaderTiff::getData() | https://api.github.com/repos/Exiv2/exiv2/issues/839/comments | 0 | 2019-05-13T11:02:37 | "2019-05-15T07:28:40Z" | https://github.com/Exiv2/exiv2/issues/839 | 443,336,660 | 839 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Out of memory error due to unchecked allocation size in LoaderTiff::getData()
Issue date:
--- start body ---
This bug was found by AFL. The value of `size_` has not been checked before [this line of code](https://github.com/Exiv2/exiv2/blob/f4a37c63f2f890c16ff7192fc89a75a7c34ae82b/src/preview.cpp#L809), leading to a large allocation. This can cause `exiv2` to crash with an out-of-memory error if less than 4GB RAM is available.
Reproducible on the 0.27-maintenance branch (f4a37c6):
```
exiv2 issue_839_poc.jpg
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 775 | 207,855 |
[
"Exiv2",
"exiv2"
] | We can move getLoadedLibraries() to src/futils.cpp and add it to the API. Then remove a load of include files from src/version.cpp. You'll need to move static bool pushPaths() to src/futils.cpp (as a static/helper function that's not in the API). | Move getLoadedLibraries to src/futils.cpp | https://api.github.com/repos/Exiv2/exiv2/issues/836/comments | 1 | 2019-05-12T18:19:32 | "2019-05-17T16:06:56Z" | https://github.com/Exiv2/exiv2/issues/836 | 443,132,184 | 836 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Move getLoadedLibraries to src/futils.cpp
Issue date:
--- start body ---
We can move getLoadedLibraries() to src/futils.cpp and add it to the API. Then remove a load of include files from src/version.cpp. You'll need to move static bool pushPaths() to src/futils.cpp (as a static/helper function that's not in the API).
--- end body ---
comments :
--- start comments ---
--- end comments --- | 448 | 207,856 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
An issue was discovered in Exiv2 0.27.1. There is reading beyond buffer at tEXtToDataBuf in the file pngimage.cpp. This can be triggered by a crafted file. It allows an attacker to cause Denial of Service (Segmentation fault) or possibly have unspecified other impact.
**To Reproduce**
Steps to reproduce the behaviour:
1. Provide image with which you observed the issue
2. Provide exact command to reproduce the issue
./exiv2 -pR poc
**Expected behavior**
Print picture information correctly without generating Segmentation fault
**Desktop (please complete the following information):**
- OS: Ubuntu18.04 64_bit
- Compiler & Version [gcc 7.3.0 ; g++ 7.3.0]
- Compilation mode and/or compiler flags
cmake -DCMAKE_INSTALL_PREFIX=BuildPath -DCMAKE_BUILD_TYPE=Debug
**Additional context**
function named tEXtToDataBuf is called in pgnimage.cpp:329.
but argument (dataOffset-name_l) value is evalued to 0xFFFFFFFF,so that read beyond buffer in pgnimage.cpp:329.
The POC is here:
[id^%000000,sig^%11,src^%000163,op^%flip1,pos^%1129.zip](https://github.com/Exiv2/exiv2/files/3146651/id.000000.sig.11.src.000163.op.flip1.pos.1129.zip)
| Segmentation fault in pngimage.cpp:329. | https://api.github.com/repos/Exiv2/exiv2/issues/828/comments | 2 | 2019-05-06T06:22:34 | "2023-08-24T12:18:28Z" | https://github.com/Exiv2/exiv2/issues/828 | 440,554,840 | 828 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Segmentation fault in pngimage.cpp:329.
Issue date:
--- start body ---
**Describe the bug**
An issue was discovered in Exiv2 0.27.1. There is reading beyond buffer at tEXtToDataBuf in the file pngimage.cpp. This can be triggered by a crafted file. It allows an attacker to cause Denial of Service (Segmentation fault) or possibly have unspecified other impact.
**To Reproduce**
Steps to reproduce the behaviour:
1. Provide image with which you observed the issue
2. Provide exact command to reproduce the issue
./exiv2 -pR poc
**Expected behavior**
Print picture information correctly without generating Segmentation fault
**Desktop (please complete the following information):**
- OS: Ubuntu18.04 64_bit
- Compiler & Version [gcc 7.3.0 ; g++ 7.3.0]
- Compilation mode and/or compiler flags
cmake -DCMAKE_INSTALL_PREFIX=BuildPath -DCMAKE_BUILD_TYPE=Debug
**Additional context**
function named tEXtToDataBuf is called in pgnimage.cpp:329.
but argument (dataOffset-name_l) value is evalued to 0xFFFFFFFF,so that read beyond buffer in pgnimage.cpp:329.
The POC is here:
[id^%000000,sig^%11,src^%000163,op^%flip1,pos^%1129.zip](https://github.com/Exiv2/exiv2/files/3146651/id.000000.sig.11.src.000163.op.flip1.pos.1129.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,729 | 207,857 |
[
"Exiv2",
"exiv2"
] | This is derived from a discussion about #818
| Support build/test of Exiv2 on NetBSD | https://api.github.com/repos/Exiv2/exiv2/issues/823/comments | 7 | 2019-05-05T07:37:11 | "2019-05-17T19:18:50Z" | https://github.com/Exiv2/exiv2/issues/823 | 440,412,992 | 823 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Support build/test of Exiv2 on NetBSD
Issue date:
--- start body ---
This is derived from a discussion about #818
--- end body ---
comments :
--- start comments ---
--- end comments --- | 244 | 207,858 |
[
"Exiv2",
"exiv2"
] | In version 0.25, -g produced this desired output:
```
$ exiv2 -g '.*' foo.jpg
Exif.Image.Make Ascii 18 NIKON CORPORATION
Exif.Image.Model Ascii 11 NIKON D750
Exif.Image.Orientation Short 1 top, left
Exif.Image.XResolution Rational 1 300
Exif.Image.YResolution Rational 1 300
Exif.Image.ResolutionUnit Short 1 inch
```
in version 0.26 this no longer works:
```
$ exiv2 -g '.*' foo.jpg
File name : foo.jpg
File size : 194825 Bytes
MIME type : image/jpeg
Image size : 800 x 600
Camera make : NIKON CORPORATION
Camera model : NIKON D750
Image timestamp : 2019:04:27 14:56:34
```
I didn't find any bug report for this and can't test if it is fixed in 0.27.x, because compilation fails for me (NetBSD 8.0/amd64, GCC 5.5.0) with
```
[ 26%] Building CXX object src/CMakeFiles/exiv2lib.dir/convert.cpp.o
/home/joern/exiv/head/exiv2/src/convert.cpp: In function 'bool {anonymous}::convertStringCharsetIconv(std::string&, const char*, const char*)':
/home/joern/exiv/head/exiv2/src/convert.cpp:1530:44: error: invalid conversion from 'char**' to 'const char**' [-fpermissive]
&outbytesleft);
^
In file included from /home/joern/exiv/head/exiv2/src/convert.cpp:56:0:
/usr/include/iconv.h:46:8: note: initializing argument 2 of 'size_t iconv(iconv_t, const char**, size_t*, char**, size_t*)'
size_t iconv(iconv_t, const char ** __restrict,
^
gmake[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:102: src/CMakeFiles/exiv2lib.dir/convert.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:362: src/CMakeFiles/exiv2lib.dir/all] Error 2
gmake: *** [Makefile:130: all] Error 2
```
NetBSD bundles it own libiconv. I could easily install GNU libiconv 1.14, but I have no idea how to tell CMake to use it. | regression of '-g' between 0.25 and 0.26 | https://api.github.com/repos/Exiv2/exiv2/issues/818/comments | 8 | 2019-05-03T07:25:35 | "2019-05-11T18:03:33Z" | https://github.com/Exiv2/exiv2/issues/818 | 439,920,730 | 818 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : regression of '-g' between 0.25 and 0.26
Issue date:
--- start body ---
In version 0.25, -g produced this desired output:
```
$ exiv2 -g '.*' foo.jpg
Exif.Image.Make Ascii 18 NIKON CORPORATION
Exif.Image.Model Ascii 11 NIKON D750
Exif.Image.Orientation Short 1 top, left
Exif.Image.XResolution Rational 1 300
Exif.Image.YResolution Rational 1 300
Exif.Image.ResolutionUnit Short 1 inch
```
in version 0.26 this no longer works:
```
$ exiv2 -g '.*' foo.jpg
File name : foo.jpg
File size : 194825 Bytes
MIME type : image/jpeg
Image size : 800 x 600
Camera make : NIKON CORPORATION
Camera model : NIKON D750
Image timestamp : 2019:04:27 14:56:34
```
I didn't find any bug report for this and can't test if it is fixed in 0.27.x, because compilation fails for me (NetBSD 8.0/amd64, GCC 5.5.0) with
```
[ 26%] Building CXX object src/CMakeFiles/exiv2lib.dir/convert.cpp.o
/home/joern/exiv/head/exiv2/src/convert.cpp: In function 'bool {anonymous}::convertStringCharsetIconv(std::string&, const char*, const char*)':
/home/joern/exiv/head/exiv2/src/convert.cpp:1530:44: error: invalid conversion from 'char**' to 'const char**' [-fpermissive]
&outbytesleft);
^
In file included from /home/joern/exiv/head/exiv2/src/convert.cpp:56:0:
/usr/include/iconv.h:46:8: note: initializing argument 2 of 'size_t iconv(iconv_t, const char**, size_t*, char**, size_t*)'
size_t iconv(iconv_t, const char ** __restrict,
^
gmake[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:102: src/CMakeFiles/exiv2lib.dir/convert.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:362: src/CMakeFiles/exiv2lib.dir/all] Error 2
gmake: *** [Makefile:130: all] Error 2
```
NetBSD bundles it own libiconv. I could easily install GNU libiconv 1.14, but I have no idea how to tell CMake to use it.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,227 | 207,859 |
[
"Exiv2",
"exiv2"
] | Hey,
i built successfully exiv 0.27.1 with the given conan step-by-step guide.
Also got some examples working in Visual Studio 2017.
Then I tried to build static libraries, also following the given instructions:
- Changed BUILD_SHARED_LIBS=Off in CMakeLists.txt and
- compiler.runtime=MT in the conan profile.
Afterwards I repeated the previous guide. After the last step I get 29 Warnings.
Something like βLNK4098 defaultlib βLIBCMT conflicts with use of other libsββ¦β
(see the attached screenshot).
Then when I try to build my previous test application I get the following linker errors βLNK2001 unresolved external symbol ...β:
`LNK2001 unresolved external symbol compress \exiv2.lib(pngimage.obj)`
`LNK2001 unresolved external symbol uncompress \exiv2.lib(pngimage.obj)`
`LNK2001 unresolved external symbol uncompress \exiv2.lib(pngchunk_int.obj)`
`LNK2001 unresolved external symbol crc32 \exiv2.lib(pngimage.obj)`
`LNK2001 unresolved external symbol crc32 \exiv2.lib(pngchunk_int.obj)`
`LNK2001 unresolved external symbol compress2 \exiv2.lib(pngchunk_int.obj)`
`LNK2001 unresolved external symbol libiconv_open \exiv2.lib(convert.obj)`
`LNK2001 unresolved external symbol libiconv \exiv2.lib(convert.obj)`
`LNK2001 unresolved external symbol libiconv_close \exiv2.lib(convert.obj)`
`LNK2001 unresolved external symbol XML_ParserCreateNS \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetElementHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetCharacterDataHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetProcessingInstructionHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetCommentHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetCdataSectionHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetStartDoctypeDeclHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetNamespaceDeclHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetUserData \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_Parse \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_StopParser \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_ParserFree \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK1120 19 unresolved externals \x64\Release\Exiv2Test.exe`
What kind of small detail I missed?
| Exiv2 0.27.1 in msvc 2017 static build | https://api.github.com/repos/Exiv2/exiv2/issues/814/comments | 10 | 2019-04-30T09:28:06 | "2019-05-01T08:16:52Z" | https://github.com/Exiv2/exiv2/issues/814 | 438,681,548 | 814 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Exiv2 0.27.1 in msvc 2017 static build
Issue date:
--- start body ---
Hey,
i built successfully exiv 0.27.1 with the given conan step-by-step guide.
Also got some examples working in Visual Studio 2017.
Then I tried to build static libraries, also following the given instructions:
- Changed BUILD_SHARED_LIBS=Off in CMakeLists.txt and
- compiler.runtime=MT in the conan profile.
Afterwards I repeated the previous guide. After the last step I get 29 Warnings.
Something like βLNK4098 defaultlib βLIBCMT conflicts with use of other libsββ¦β
(see the attached screenshot).
Then when I try to build my previous test application I get the following linker errors βLNK2001 unresolved external symbol ...β:
`LNK2001 unresolved external symbol compress \exiv2.lib(pngimage.obj)`
`LNK2001 unresolved external symbol uncompress \exiv2.lib(pngimage.obj)`
`LNK2001 unresolved external symbol uncompress \exiv2.lib(pngchunk_int.obj)`
`LNK2001 unresolved external symbol crc32 \exiv2.lib(pngimage.obj)`
`LNK2001 unresolved external symbol crc32 \exiv2.lib(pngchunk_int.obj)`
`LNK2001 unresolved external symbol compress2 \exiv2.lib(pngchunk_int.obj)`
`LNK2001 unresolved external symbol libiconv_open \exiv2.lib(convert.obj)`
`LNK2001 unresolved external symbol libiconv \exiv2.lib(convert.obj)`
`LNK2001 unresolved external symbol libiconv_close \exiv2.lib(convert.obj)`
`LNK2001 unresolved external symbol XML_ParserCreateNS \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetElementHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetCharacterDataHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetProcessingInstructionHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetCommentHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetCdataSectionHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetStartDoctypeDeclHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetNamespaceDeclHandler \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_SetUserData \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_Parse \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_StopParser \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK2001 unresolved external symbol XML_ParserFree \exiv2-xmp.lib(ExpatAdapter.obj)`
`LNK1120 19 unresolved externals \x64\Release\Exiv2Test.exe`
What kind of small detail I missed?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,879 | 207,860 |
[
"Exiv2",
"exiv2"
] | Hi,
Sigma 14-24mm f/2.8 DG HSM Art Nikon is not properly detected yet. Here is info about this lens:
* Sigma 14-24mm f/2.8 DG HSM Art Nikon
* exiv2 -pt DSC_2525.JPG | grep -ai lens
Exif.Nikon3.LensType Byte 1 D G
Exif.Nikon3.Lens Rational 4 14-24mm F2.8
Exif.Nikon3.LensFStops Undefined 4 6
Exif.NikonLd3.LensIDNumber Byte 1 193
Exif.NikonLd3.LensFStops Byte 1 F6.0
* https://www.sigmaphoto.com/14-24mm-f2-8-dg-hsm-a
*
Let me know if I can help you by including more information.
| Sigma 14-24mm f/2.8 DG HSM Art Nikon | https://api.github.com/repos/Exiv2/exiv2/issues/811/comments | 3 | 2019-04-28T18:07:24 | "2019-04-30T11:06:18Z" | https://github.com/Exiv2/exiv2/issues/811 | 438,083,607 | 811 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Sigma 14-24mm f/2.8 DG HSM Art Nikon
Issue date:
--- start body ---
Hi,
Sigma 14-24mm f/2.8 DG HSM Art Nikon is not properly detected yet. Here is info about this lens:
* Sigma 14-24mm f/2.8 DG HSM Art Nikon
* exiv2 -pt DSC_2525.JPG | grep -ai lens
Exif.Nikon3.LensType Byte 1 D G
Exif.Nikon3.Lens Rational 4 14-24mm F2.8
Exif.Nikon3.LensFStops Undefined 4 6
Exif.NikonLd3.LensIDNumber Byte 1 193
Exif.NikonLd3.LensFStops Byte 1 F6.0
* https://www.sigmaphoto.com/14-24mm-f2-8-dg-hsm-a
*
Let me know if I can help you by including more information.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 956 | 207,861 |
[
"Exiv2",
"exiv2"
] | In #802 we have some builds failing because I stared using GMock there but it is not installed in some of the Gitlab distributions. | Install GMock in the Gitlab jobs missing it | https://api.github.com/repos/Exiv2/exiv2/issues/803/comments | 0 | 2019-04-27T13:07:35 | "2019-04-29T13:17:40Z" | https://github.com/Exiv2/exiv2/issues/803 | 437,941,857 | 803 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Install GMock in the Gitlab jobs missing it
Issue date:
--- start body ---
In #802 we have some builds failing because I stared using GMock there but it is not installed in some of the Gitlab distributions.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 336 | 207,862 |
[
"Exiv2",
"exiv2"
] | After we merged #796 , some tests started to fail in the CentOS build. @D4N sensed that this could happen and he might have some intuition of why this situation has happened.
Update after investigation:
The problem comes from the fact that CentOS has a very old very of GCC in which regex is not available:
```
--> Processing Dependency: gcc = 4.8.5-36.el7_6.1 for package: gcc-c++-4.8.5-36.el7_6.1.x86_64
```
See this [link](https://stackoverflow.com/a/12665408/1977218) for more info.
Possible approaches to deal with this situation:
- Upgrade CentOS on the CI ? I am not sure if were are using the latest version or not.
- Remove CentOS from the Gitlab pipelines, since the GCC version it contains it is not fully C++11 compatible. | CentOS build failing after merging #796 | https://api.github.com/repos/Exiv2/exiv2/issues/800/comments | 10 | 2019-04-27T11:54:47 | "2019-10-13T21:09:50Z" | https://github.com/Exiv2/exiv2/issues/800 | 437,935,969 | 800 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : CentOS build failing after merging #796
Issue date:
--- start body ---
After we merged #796 , some tests started to fail in the CentOS build. @D4N sensed that this could happen and he might have some intuition of why this situation has happened.
Update after investigation:
The problem comes from the fact that CentOS has a very old very of GCC in which regex is not available:
```
--> Processing Dependency: gcc = 4.8.5-36.el7_6.1 for package: gcc-c++-4.8.5-36.el7_6.1.x86_64
```
See this [link](https://stackoverflow.com/a/12665408/1977218) for more info.
Possible approaches to deal with this situation:
- Upgrade CentOS on the CI ? I am not sure if were are using the latest version or not.
- Remove CentOS from the Gitlab pipelines, since the GCC version it contains it is not fully C++11 compatible.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 952 | 207,863 |
[
"Exiv2",
"exiv2"
] | https://github.com/Exiv2/exiv2/commit/aae88060ca85a483cd7fe791ba116c04d96c0bf9 | Install CMake/consume files in DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/exiv2/ | https://api.github.com/repos/Exiv2/exiv2/issues/798/comments | 0 | 2019-04-27T10:08:57 | "2019-04-27T12:10:37Z" | https://github.com/Exiv2/exiv2/issues/798 | 437,928,213 | 798 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Install CMake/consume files in DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/exiv2/
Issue date:
--- start body ---
https://github.com/Exiv2/exiv2/commit/aae88060ca85a483cd7fe791ba116c04d96c0bf9
--- end body ---
comments :
--- start comments ---
--- end comments --- | 318 | 207,864 |
[
"Exiv2",
"exiv2"
] | There is a null pointer deference bug at [http.cpp:364](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/http.cpp#L364). If the http server sends back a reply that does not contain a space character, then `strchr` will return `NULL`, leading to a null pointer dereference in `atoi`.
To reproduce the bug (tested on master: [55dfdb9](https://github.com/Exiv2/exiv2/commit/55dfdb9ab007d6e6d1d06240048690eaac23b305)) open two terminals. In the first terminal, start a fake webserver using [response1.txt](https://github.com/Exiv2/exiv2/files/3113957/response1.txt):
```
cat response1.txt | sudo nc -l -p 80
```
In the second terminal, try to connect to the fake webserver:
```
exiv2 http://127.0.0.1/test.jpg
```
There are several other calls to `strcat` and `strstr` in the same [block of code](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/http.cpp#L339-L396). I have not written PoCs for them, but the calls to `strchr` on lines [351](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/http.cpp#L351) and [362](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/http.cpp#L362) also look vulnerable to me. | null pointer dereference in http.cpp | https://api.github.com/repos/Exiv2/exiv2/issues/793/comments | 4 | 2019-04-24T20:14:50 | "2019-07-01T09:07:49Z" | https://github.com/Exiv2/exiv2/issues/793 | 436,886,165 | 793 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : null pointer dereference in http.cpp
Issue date:
--- start body ---
There is a null pointer deference bug at [http.cpp:364](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/http.cpp#L364). If the http server sends back a reply that does not contain a space character, then `strchr` will return `NULL`, leading to a null pointer dereference in `atoi`.
To reproduce the bug (tested on master: [55dfdb9](https://github.com/Exiv2/exiv2/commit/55dfdb9ab007d6e6d1d06240048690eaac23b305)) open two terminals. In the first terminal, start a fake webserver using [response1.txt](https://github.com/Exiv2/exiv2/files/3113957/response1.txt):
```
cat response1.txt | sudo nc -l -p 80
```
In the second terminal, try to connect to the fake webserver:
```
exiv2 http://127.0.0.1/test.jpg
```
There are several other calls to `strcat` and `strstr` in the same [block of code](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/http.cpp#L339-L396). I have not written PoCs for them, but the calls to `strchr` on lines [351](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/http.cpp#L351) and [362](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/http.cpp#L362) also look vulnerable to me.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,448 | 207,865 |
[
"Exiv2",
"exiv2"
] | i ma working on writing metadata to a tiff image as xmp file.
I use the following code:
//Writing Metadata into image
Exiv2::Image::AutoPtr image = Exiv2::ImageFactory::open(filename.toStdString());
assert(image.get()!=0);
image->setExifData(exifData);
image->writeMetadata();
but i am getting a error saying AutoPtr not a member og Exiv2::Image | writing metadata | https://api.github.com/repos/Exiv2/exiv2/issues/792/comments | 3 | 2019-04-24T19:27:27 | "2021-05-17T05:54:58Z" | https://github.com/Exiv2/exiv2/issues/792 | 436,867,669 | 792 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : writing metadata
Issue date:
--- start body ---
i ma working on writing metadata to a tiff image as xmp file.
I use the following code:
//Writing Metadata into image
Exiv2::Image::AutoPtr image = Exiv2::ImageFactory::open(filename.toStdString());
assert(image.get()!=0);
image->setExifData(exifData);
image->writeMetadata();
but i am getting a error saying AutoPtr not a member og Exiv2::Image
--- end body ---
comments :
--- start comments ---
--- end comments --- | 548 | 207,866 |
[
"Exiv2",
"exiv2"
] | There is a bug at [webpimage.cpp:515](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/webpimage.cpp#L515). If `filesize < io_->tell()` then the subtraction overflows and the bounds check on `size` is ineffective.
There is an additional problem in this function, which is that the error conditions are not checked after the calls to `io_->read`. Calls to `io_->read` should always be followed by calls to `io_->error()` and `io_->eof()`, to make sure that the buffer was read successfully. This means that the code does not notice that the file size is much smaller than the value of `size` would suggest. This has enabled me to write a PoC which causes exiv2 to run for almost a minute, scanning 4GB of uninitialized memory.
Here is the PoC, which I have tested on master ([55dfdb9](https://github.com/Exiv2/exiv2/commit/55dfdb9ab007d6e6d1d06240048690eaac23b305)):
. You can run the PoC like this to see the long-running behavior:
```
$ time exiv2 poc1.jpg
File name : poc1.jpg
File size : 28 Bytes
MIME type : image/webp
Image size : 0 x 0
poc1.jpg: No Exif data found in the file
real 0m52.738s
user 0m50.621s
sys 0m2.108s
```
Or if you use `ulimit` to lower the maximum allocation size to less than 4GB then exiv2 will crash:
```
$ ulimit -v 4000000
$ exiv2 poc1.jpg
Uncaught exception: std::bad_alloc
``` | Integer overflow, leading to very large allocation in WebPImage::decodeChunks() | https://api.github.com/repos/Exiv2/exiv2/issues/791/comments | 1 | 2019-04-24T16:03:00 | "2019-07-01T09:03:36Z" | https://github.com/Exiv2/exiv2/issues/791 | 436,781,784 | 791 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Integer overflow, leading to very large allocation in WebPImage::decodeChunks()
Issue date:
--- start body ---
There is a bug at [webpimage.cpp:515](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/webpimage.cpp#L515). If `filesize < io_->tell()` then the subtraction overflows and the bounds check on `size` is ineffective.
There is an additional problem in this function, which is that the error conditions are not checked after the calls to `io_->read`. Calls to `io_->read` should always be followed by calls to `io_->error()` and `io_->eof()`, to make sure that the buffer was read successfully. This means that the code does not notice that the file size is much smaller than the value of `size` would suggest. This has enabled me to write a PoC which causes exiv2 to run for almost a minute, scanning 4GB of uninitialized memory.
Here is the PoC, which I have tested on master ([55dfdb9](https://github.com/Exiv2/exiv2/commit/55dfdb9ab007d6e6d1d06240048690eaac23b305)):
. You can run the PoC like this to see the long-running behavior:
```
$ time exiv2 poc1.jpg
File name : poc1.jpg
File size : 28 Bytes
MIME type : image/webp
Image size : 0 x 0
poc1.jpg: No Exif data found in the file
real 0m52.738s
user 0m50.621s
sys 0m2.108s
```
Or if you use `ulimit` to lower the maximum allocation size to less than 4GB then exiv2 will crash:
```
$ ulimit -v 4000000
$ exiv2 poc1.jpg
Uncaught exception: std::bad_alloc
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,757 | 207,867 |
[
"Exiv2",
"exiv2"
] | This issue is closely related to #789, but the consequences of this bug are different. The calculation of `chunkLength - iccOffset` at [pngimage.cpp:472](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/pngimage.cpp#L472) can have a negative integer overflow which leads to an 8GB memory allocation in `zlibToDataBuf`. Also, the zlib decompression is run on uninitialized memory beyond the end of the buffer, so there is a potential info leak vulnerability here.
Here is the PoC, which I have tested on master ([55dfdb9](https://github.com/Exiv2/exiv2/commit/55dfdb9ab007d6e6d1d06240048690eaac23b305)): . The simplest way to see the bug is to use `ulimit` to reduce the amount of available memory to less than 8GB:
```
$ ulimit -v 8000000
$ exiv2 poc2.png
Uncaught exception: std::bad_alloc
``` | Integer overflow, leading to very large allocation in PngImage::readMetadata() | https://api.github.com/repos/Exiv2/exiv2/issues/790/comments | 1 | 2019-04-24T15:39:42 | "2019-07-01T09:01:35Z" | https://github.com/Exiv2/exiv2/issues/790 | 436,769,374 | 790 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Integer overflow, leading to very large allocation in PngImage::readMetadata()
Issue date:
--- start body ---
This issue is closely related to #789, but the consequences of this bug are different. The calculation of `chunkLength - iccOffset` at [pngimage.cpp:472](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/pngimage.cpp#L472) can have a negative integer overflow which leads to an 8GB memory allocation in `zlibToDataBuf`. Also, the zlib decompression is run on uninitialized memory beyond the end of the buffer, so there is a potential info leak vulnerability here.
Here is the PoC, which I have tested on master ([55dfdb9](https://github.com/Exiv2/exiv2/commit/55dfdb9ab007d6e6d1d06240048690eaac23b305)): . The simplest way to see the bug is to use `ulimit` to reduce the amount of available memory to less than 8GB:
```
$ ulimit -v 8000000
$ exiv2 poc2.png
Uncaught exception: std::bad_alloc
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,185 | 207,868 |
[
"Exiv2",
"exiv2"
] | There is a bug at [pngimage.cpp:469](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/pngimage.cpp#L469). If `iccOffset == 0`, which happens if `chunkLength == 0`, then Exiv2 crashes with a SIGSEGV.
Here is the PoC, which I have tested on master ([55dfdb9](https://github.com/Exiv2/exiv2/commit/55dfdb9ab007d6e6d1d06240048690eaac23b305)): . You can run the PoC like this:
```
$ exiv2 poc1.png
Segmentation fault (core dumped)
``` | SIGSEGV in PngImage::readMetadata() | https://api.github.com/repos/Exiv2/exiv2/issues/789/comments | 2 | 2019-04-24T15:24:45 | "2019-07-01T08:58:12Z" | https://github.com/Exiv2/exiv2/issues/789 | 436,761,517 | 789 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : SIGSEGV in PngImage::readMetadata()
Issue date:
--- start body ---
There is a bug at [pngimage.cpp:469](https://github.com/Exiv2/exiv2/blob/55dfdb9ab007d6e6d1d06240048690eaac23b305/src/pngimage.cpp#L469). If `iccOffset == 0`, which happens if `chunkLength == 0`, then Exiv2 crashes with a SIGSEGV.
Here is the PoC, which I have tested on master ([55dfdb9](https://github.com/Exiv2/exiv2/commit/55dfdb9ab007d6e6d1d06240048690eaac23b305)): . You can run the PoC like this:
```
$ exiv2 poc1.png
Segmentation fault (core dumped)
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 774 | 207,869 |
[
"Exiv2",
"exiv2"
] | Can you please provide the pre-compiled library for visual studio 2015 x86. Its kinda difficult to build it using cmake for x86. | msvs 2015 x86 build | https://api.github.com/repos/Exiv2/exiv2/issues/787/comments | 12 | 2019-04-22T21:19:55 | "2019-04-23T21:30:05Z" | https://github.com/Exiv2/exiv2/issues/787 | 435,897,248 | 787 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : msvs 2015 x86 build
Issue date:
--- start body ---
Can you please provide the pre-compiled library for visual studio 2015 x86. Its kinda difficult to build it using cmake for x86.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 308 | 207,870 |
[
"Exiv2",
"exiv2"
] | After building the most current version of exiv from source, I am running into issues using exiv in vs2017.
I am able to build the library with both debug and release DLLs. However attempting to use exiv with visual studio in release mode is causing an access violation reading error.
```
#include <iostream>
#include <cassert>
#include <string>
#include <stdexcept>
#include <exiv2/exiv2.hpp>
using std::string;
using std::cerr;
int main() {
try
{
const std::string imagepath = "capture4.png";
auto image = Exiv2::ImageFactory::open(imagepath);
//assert(image.get() != 0);
}
catch (const std::exception& e)
{
cerr << "Error: " << e.what() << '\n';
}
catch (...)
{
cerr << "Error, unknown exception caught.\n";
}
}
```
The same code works fine in debug mode. In release mode, the image path string appears to be getting mangled when viewing through the debugger. Visual studio is reporting an "Error reading characters of string" I am also using c++ 17.
| access violation vs 2017 msvc | https://api.github.com/repos/Exiv2/exiv2/issues/783/comments | 5 | 2019-04-18T22:14:26 | "2019-05-20T10:40:51Z" | https://github.com/Exiv2/exiv2/issues/783 | 434,980,187 | 783 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : access violation vs 2017 msvc
Issue date:
--- start body ---
After building the most current version of exiv from source, I am running into issues using exiv in vs2017.
I am able to build the library with both debug and release DLLs. However attempting to use exiv with visual studio in release mode is causing an access violation reading error.
```
#include <iostream>
#include <cassert>
#include <string>
#include <stdexcept>
#include <exiv2/exiv2.hpp>
using std::string;
using std::cerr;
int main() {
try
{
const std::string imagepath = "capture4.png";
auto image = Exiv2::ImageFactory::open(imagepath);
//assert(image.get() != 0);
}
catch (const std::exception& e)
{
cerr << "Error: " << e.what() << '\n';
}
catch (...)
{
cerr << "Error, unknown exception caught.\n";
}
}
```
The same code works fine in debug mode. In release mode, the image path string appears to be getting mangled when viewing through the debugger. Visual studio is reporting an "Error reading characters of string" I am also using c++ 17.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,261 | 207,871 |
[
"Exiv2",
"exiv2"
] | ```
[ 24%] Built target exiv2lib_int
Scanning dependencies of target exiv2lib
[ 24%] Building CXX object src/CMakeFiles/exiv2lib.dir/basicio.cpp.o
In file included from /c/msys64/usr/lib/gcc/x86_64-pc-msys/7.3.0/include/c++/bits/stl_algo.h:59:0,
from /c/msys64/usr/lib/gcc/x86_64-pc-msys/7.3.0/include/c++/algorithm:62,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/include/exiv2/types.hpp:42,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/include/exiv2/value.hpp:36,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/include/exiv2/metadatum.hpp:38,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/include/exiv2/datasets.hpp:33,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/src/basicio.cpp:26:
/c/msys64/usr/lib/gcc/x86_64-pc-msys/7.3.0/include/c++/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
#include_next <stdlib.h>
^~~~~~~~~~
compilation terminated.
make[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:63: src/CMakeFiles/exiv2lib.dir/basicio.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:283: src/CMakeFiles/exiv2lib.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
508 MSYS64:rmills@rmillsmm-w7:~/temp/foo/exiv2-0.27.1-Source/build $
```
This is caused by the PATH being incorrectly set.
```
WRONG: /c/msys64/usr/bin:/c/msys64/usr/local/bin
WORKS: /usr/local/bin/:/usr/bin:/mingw64/bin:/bin:/usr/sbin:/sbin
```
My fix is to modify msys64.bat (as documented in README.md)
```
@echo off
setlocal
set "PS1=\! MSYS64:\u@\h:\w \$ "
set PATH="/usr/local/bin/:/usr/bin:/mingw64/bin:/bin:/usr/sbin:/sbin"
set "HOME=c:\msys64\home\%USERNAME%"
if NOT EXIST %HOME% mkdir %HOME%
cd %HOME%
c:\msys64\usr\bin\bash.exe -norc
```
**_Analysis_**
This is a puzzle as the file `/usr/include/stdlib.h` is available. CMake generates the compiler command:
```
..... -isystem /usr/include .....
```
Manually changing fixes this:
```
..... -I/usr/include .....
```
I do not understood why modifying the PATH results in the correct code being generated.
| MinGW exiv2-0.27-Source fails with stdlib.h: No such file or directory | https://api.github.com/repos/Exiv2/exiv2/issues/781/comments | 0 | 2019-04-18T06:27:54 | "2019-04-27T10:46:37Z" | https://github.com/Exiv2/exiv2/issues/781 | 434,609,933 | 781 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : MinGW exiv2-0.27-Source fails with stdlib.h: No such file or directory
Issue date:
--- start body ---
```
[ 24%] Built target exiv2lib_int
Scanning dependencies of target exiv2lib
[ 24%] Building CXX object src/CMakeFiles/exiv2lib.dir/basicio.cpp.o
In file included from /c/msys64/usr/lib/gcc/x86_64-pc-msys/7.3.0/include/c++/bits/stl_algo.h:59:0,
from /c/msys64/usr/lib/gcc/x86_64-pc-msys/7.3.0/include/c++/algorithm:62,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/include/exiv2/types.hpp:42,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/include/exiv2/value.hpp:36,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/include/exiv2/metadatum.hpp:38,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/include/exiv2/datasets.hpp:33,
from /c/msys64/home/rmills/temp/foo/exiv2-0.27.1-Source/src/basicio.cpp:26:
/c/msys64/usr/lib/gcc/x86_64-pc-msys/7.3.0/include/c++/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
#include_next <stdlib.h>
^~~~~~~~~~
compilation terminated.
make[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:63: src/CMakeFiles/exiv2lib.dir/basicio.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:283: src/CMakeFiles/exiv2lib.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
508 MSYS64:rmills@rmillsmm-w7:~/temp/foo/exiv2-0.27.1-Source/build $
```
This is caused by the PATH being incorrectly set.
```
WRONG: /c/msys64/usr/bin:/c/msys64/usr/local/bin
WORKS: /usr/local/bin/:/usr/bin:/mingw64/bin:/bin:/usr/sbin:/sbin
```
My fix is to modify msys64.bat (as documented in README.md)
```
@echo off
setlocal
set "PS1=\! MSYS64:\u@\h:\w \$ "
set PATH="/usr/local/bin/:/usr/bin:/mingw64/bin:/bin:/usr/sbin:/sbin"
set "HOME=c:\msys64\home\%USERNAME%"
if NOT EXIST %HOME% mkdir %HOME%
cd %HOME%
c:\msys64\usr\bin\bash.exe -norc
```
**_Analysis_**
This is a puzzle as the file `/usr/include/stdlib.h` is available. CMake generates the compiler command:
```
..... -isystem /usr/include .....
```
Manually changing fixes this:
```
..... -I/usr/include .....
```
I do not understood why modifying the PATH results in the correct code being generated.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,417 | 207,872 |
[
"Exiv2",
"exiv2"
] | I've tested this with exiv2 v0.27.1 and everything builds and passed the test suite.
Steps:
1) Update conan to 1.14.3 (and pip request to be updated)
2) Update to CMake 3.14.2
3) Create a new profile (in ~/.conan/profiles)
**_Caution:_** When I upgraded conan, I had to manually:
```
copy/y %USERPROFILE%\.conan\settings.yml.new %USERPROFILE%\.conan\settings.yml
```
For me: `%USERPROFILE% == C:\Users\rmills`
I had one curiosity that deserves attention. The python3 interpreter on the path, must be called python3(.exe) as python.exe is not sufficient. If tests are run by msys64 python3 almost every test will fail. I fixed this as follows: `cd c:\Python37 && copy/y python.exe python3.exe`
```
C:\Users\rmills\.conan\profiles>cat msvc2019Release64
[build_requires]
[settings]
arch=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=16
os=Windows
arch_build=x86_64
os_build=Windows
[options]
[env]
C:\Users\rmills\.conan\profiles>conan --version
Conan version 1.14.3
C:\Users\rmills\.conan\profiles>cmake --version
cmake version 3.14.2
CMake suite maintained and supported by Kitware (kitware.com/cmake).
C:\Users\rmills\.conan\profiles>
```
The output of the command `$ exiv2 -vV --grep version` reports the incorrect version of the Microsoft CL Compiler as follows:
```
410 MSYS64:rmills@rmillsmbp-w7:/c/temp/exiv2-0.27.1-Source/build $ bin/exiv2 -vV --grep version
exiv2 0.27.1
version=13.20 (2017/x64)
411 MSYS64:rmills@rmillsmbp-w7:/c/temp/exiv2-0.27.1-Source/build $
```
This is because Microsoft have changed their version numbering of CL with 2017 and 2019 in which _MSC_VER is 1910 and 1920 respectively. I'll submit a code change to src/version.cpp to report (2019/x64)
I intend to support Visual Studio 2015, 2017, 2019 and will withdraw support for earlier editions. I'm only withdrawing support, the code will probably build successfully with 2008, 2010, 2012 and 2013.
I will update README-CONAN.md appropriately for v0.27.1 | Support for Visual Studio 2019 using Conan and CMake. | https://api.github.com/repos/Exiv2/exiv2/issues/780/comments | 0 | 2019-04-16T13:41:52 | "2019-04-27T10:53:12Z" | https://github.com/Exiv2/exiv2/issues/780 | 433,787,043 | 780 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Support for Visual Studio 2019 using Conan and CMake.
Issue date:
--- start body ---
I've tested this with exiv2 v0.27.1 and everything builds and passed the test suite.
Steps:
1) Update conan to 1.14.3 (and pip request to be updated)
2) Update to CMake 3.14.2
3) Create a new profile (in ~/.conan/profiles)
**_Caution:_** When I upgraded conan, I had to manually:
```
copy/y %USERPROFILE%\.conan\settings.yml.new %USERPROFILE%\.conan\settings.yml
```
For me: `%USERPROFILE% == C:\Users\rmills`
I had one curiosity that deserves attention. The python3 interpreter on the path, must be called python3(.exe) as python.exe is not sufficient. If tests are run by msys64 python3 almost every test will fail. I fixed this as follows: `cd c:\Python37 && copy/y python.exe python3.exe`
```
C:\Users\rmills\.conan\profiles>cat msvc2019Release64
[build_requires]
[settings]
arch=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=16
os=Windows
arch_build=x86_64
os_build=Windows
[options]
[env]
C:\Users\rmills\.conan\profiles>conan --version
Conan version 1.14.3
C:\Users\rmills\.conan\profiles>cmake --version
cmake version 3.14.2
CMake suite maintained and supported by Kitware (kitware.com/cmake).
C:\Users\rmills\.conan\profiles>
```
The output of the command `$ exiv2 -vV --grep version` reports the incorrect version of the Microsoft CL Compiler as follows:
```
410 MSYS64:rmills@rmillsmbp-w7:/c/temp/exiv2-0.27.1-Source/build $ bin/exiv2 -vV --grep version
exiv2 0.27.1
version=13.20 (2017/x64)
411 MSYS64:rmills@rmillsmbp-w7:/c/temp/exiv2-0.27.1-Source/build $
```
This is because Microsoft have changed their version numbering of CL with 2017 and 2019 in which _MSC_VER is 1910 and 1920 respectively. I'll submit a code change to src/version.cpp to report (2019/x64)
I intend to support Visual Studio 2015, 2017, 2019 and will withdraw support for earlier editions. I'm only withdrawing support, the code will probably build successfully with 2008, 2010, 2012 and 2013.
I will update README-CONAN.md appropriately for v0.27.1
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,261 | 207,873 |
[
"Exiv2",
"exiv2"
] | Hi,
I am trying to install exiv2 with `vcpkg install exiv2:x64-windows --head`. Unfortunately, the build fails with an error:
`Error: Building package exiv2:x64-windows failed with: BUILD_FAILED`
Installing via normal install worked flawlessly. I was wondering if there is something I missed.
The latest release does not include the fix for c++11 where `auto_ptr` got renamed to `unique_ptr` and since I am using c++17 where `auto_ptr` was finally removed v0.27 does not work for me.
However, using conan to build after I have manually cloned the repo will work so it must have to do something with the usage of vcpkg + exiv2 I guess.
I would really appreciate any help because I would like to use vcpkg instead of doing it manually.
Here is the full error:
```
D:\$USER\Documents\git\vcpkg>vcpkg install exiv2:x64-windows --head
The following packages will be built and installed:
exiv2[core]:x64-windows (from HEAD)
Starting package 1/1: exiv2:x64-windows
Building package exiv2[core]:x64-windows from HEAD...
-- Purging cached D:/$USER/Documents/git/vcpkg/downloads/Exiv2-exiv2-master.tar.gz to fetch latest (use --no-downloads to suppress)
-- Downloading https://api.github.com/repos/Exiv2/exiv2/git/refs/heads/master...
-- Skipping hash check for D:/$USER/Documents/git/vcpkg/downloads/temp/Exiv2-exiv2-master.tar.gz.version.
-- Downloading https://github.com/Exiv2/exiv2/archive/master.tar.gz...
-- Skipping hash check for D:/$USER/Documents/git/vcpkg/downloads/temp/Exiv2-exiv2-master.tar.gz.
-- Extracting source D:/$USER/Documents/git/vcpkg/downloads/Exiv2-exiv2-master.tar.gz
-- Applying patch iconv.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Using source at D:/$USER/Documents/git/vcpkg/buildtrees/exiv2/src/head/master-a5eaf86002
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:45 (message):
'D:/$USER/Documents/git/vcpkg/packages/exiv2_x64-windows/debug/share/exiv2/cmake'
does not exist.
Call Stack (most recent call first):
ports/exiv2/portfile.cmake:32 (vcpkg_fixup_cmake_targets)
scripts/ports.cmake:71 (include)
Error: Building package exiv2:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: exiv2:x64-windows
Vcpkg version: 2018.11.23-nohash-external
Additionally, attach any relevant sections from the log files above.
``` | installing exiv2 from head with vcpkg | https://api.github.com/repos/Exiv2/exiv2/issues/777/comments | 4 | 2019-04-09T13:46:52 | "2019-04-10T10:29:37Z" | https://github.com/Exiv2/exiv2/issues/777 | 430,977,564 | 777 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : installing exiv2 from head with vcpkg
Issue date:
--- start body ---
Hi,
I am trying to install exiv2 with `vcpkg install exiv2:x64-windows --head`. Unfortunately, the build fails with an error:
`Error: Building package exiv2:x64-windows failed with: BUILD_FAILED`
Installing via normal install worked flawlessly. I was wondering if there is something I missed.
The latest release does not include the fix for c++11 where `auto_ptr` got renamed to `unique_ptr` and since I am using c++17 where `auto_ptr` was finally removed v0.27 does not work for me.
However, using conan to build after I have manually cloned the repo will work so it must have to do something with the usage of vcpkg + exiv2 I guess.
I would really appreciate any help because I would like to use vcpkg instead of doing it manually.
Here is the full error:
```
D:\$USER\Documents\git\vcpkg>vcpkg install exiv2:x64-windows --head
The following packages will be built and installed:
exiv2[core]:x64-windows (from HEAD)
Starting package 1/1: exiv2:x64-windows
Building package exiv2[core]:x64-windows from HEAD...
-- Purging cached D:/$USER/Documents/git/vcpkg/downloads/Exiv2-exiv2-master.tar.gz to fetch latest (use --no-downloads to suppress)
-- Downloading https://api.github.com/repos/Exiv2/exiv2/git/refs/heads/master...
-- Skipping hash check for D:/$USER/Documents/git/vcpkg/downloads/temp/Exiv2-exiv2-master.tar.gz.version.
-- Downloading https://github.com/Exiv2/exiv2/archive/master.tar.gz...
-- Skipping hash check for D:/$USER/Documents/git/vcpkg/downloads/temp/Exiv2-exiv2-master.tar.gz.
-- Extracting source D:/$USER/Documents/git/vcpkg/downloads/Exiv2-exiv2-master.tar.gz
-- Applying patch iconv.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Using source at D:/$USER/Documents/git/vcpkg/buildtrees/exiv2/src/head/master-a5eaf86002
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:45 (message):
'D:/$USER/Documents/git/vcpkg/packages/exiv2_x64-windows/debug/share/exiv2/cmake'
does not exist.
Call Stack (most recent call first):
ports/exiv2/portfile.cmake:32 (vcpkg_fixup_cmake_targets)
scripts/ports.cmake:71 (include)
Error: Building package exiv2:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: exiv2:x64-windows
Vcpkg version: 2018.11.23-nohash-external
Additionally, attach any relevant sections from the log files above.
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,803 | 207,874 |
[
"Exiv2",
"exiv2"
] | I try to create some XMP Data with Exiv2 (Version 0.27.0 - Build msvc64 libs), but failing. I created in Visual Studio 2017 an short test, based on the example at http://www.exiv2.org/doc/xmpsample_8cpp-example.html
``` C++
#include "pch.h"
#include <exiv2/exiv2.hpp>
#include <string>
#include <iostream>
int main()
{
try {
Exiv2::XmpData xmpData;
xmpData["Xmp.dc.source"] = "xmpsample.cpp"; // a simple text value
xmpData["Xmp.dc.subject"] = "Palmtree"; // an array item
}
catch (Exiv2::AnyError& e) {
std::cout << "Caught Exiv2 exception '" << e << "'\n";
return -1;
}
}
```
... but this fails with
> Caught Exiv2 exception 'Invalid key '
If I try to add Exiv2::XmpProperties::registerNs("http://purl.org/dc/elements/1.1/", "dc"); the program fails with an
> std::bad alloc
exception at this line
I just don't see what I'm doing wrong here? | Problems creating XMP files | https://api.github.com/repos/Exiv2/exiv2/issues/770/comments | 6 | 2019-04-02T18:36:01 | "2019-04-17T18:32:58Z" | https://github.com/Exiv2/exiv2/issues/770 | 428,380,152 | 770 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Problems creating XMP files
Issue date:
--- start body ---
I try to create some XMP Data with Exiv2 (Version 0.27.0 - Build msvc64 libs), but failing. I created in Visual Studio 2017 an short test, based on the example at http://www.exiv2.org/doc/xmpsample_8cpp-example.html
``` C++
#include "pch.h"
#include <exiv2/exiv2.hpp>
#include <string>
#include <iostream>
int main()
{
try {
Exiv2::XmpData xmpData;
xmpData["Xmp.dc.source"] = "xmpsample.cpp"; // a simple text value
xmpData["Xmp.dc.subject"] = "Palmtree"; // an array item
}
catch (Exiv2::AnyError& e) {
std::cout << "Caught Exiv2 exception '" << e << "'\n";
return -1;
}
}
```
... but this fails with
> Caught Exiv2 exception 'Invalid key '
If I try to add Exiv2::XmpProperties::registerNs("http://purl.org/dc/elements/1.1/", "dc"); the program fails with an
> std::bad alloc
exception at this line
I just don't see what I'm doing wrong here?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,156 | 207,875 |
[
"Exiv2",
"exiv2"
] | Hello, I have only one feature request and that is to improve the default output of meta information
The default should look like following:
TagDescription [TagName] : value [valueWhichCanBeSet]
basically to offer human readable tags and descriptions with the actual tags and their "raw" values
I would also provide an example but I did not use this tool properly yet to be able to provide it, because I don't have time now to somehow guess the correct formats (raw values) for any tags
Sorry for not being completely clear, I hope it will be understood.
If this is somehow configurable/achievable I'm really sorry for bothering you.
Tool seems to be pretty cool. | Default cmd output formatting | https://api.github.com/repos/Exiv2/exiv2/issues/767/comments | 4 | 2019-04-01T19:27:26 | "2019-04-16T20:13:22Z" | https://github.com/Exiv2/exiv2/issues/767 | 427,872,533 | 767 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Default cmd output formatting
Issue date:
--- start body ---
Hello, I have only one feature request and that is to improve the default output of meta information
The default should look like following:
TagDescription [TagName] : value [valueWhichCanBeSet]
basically to offer human readable tags and descriptions with the actual tags and their "raw" values
I would also provide an example but I did not use this tool properly yet to be able to provide it, because I don't have time now to somehow guess the correct formats (raw values) for any tags
Sorry for not being completely clear, I hope it will be understood.
If this is somehow configurable/achievable I'm really sorry for bothering you.
Tool seems to be pretty cool.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 870 | 207,876 |
[
"Exiv2",
"exiv2"
] | According to https://discuss.pixls.us/t/exiv2-v0-27-1-rc1-is-ready/11963 a new RC was bundled and released - please tag the corresponding commit as well. And if possible please change the policy to use a fourth `.x` element for RCs, all versioning systems I know consider e.g. `0.27.1.1` (RC1 in your scheme) as newer than `0.27.1` (final release). It looks like you already do that for git tags (e.g. `v0.27.0-RC1`), but not for bundles.
As always, thanks everyone for your hard work! | Tag/Release 0.27.1 RC1 in git | https://api.github.com/repos/Exiv2/exiv2/issues/766/comments | 15 | 2019-04-01T08:18:47 | "2019-04-04T09:44:03Z" | https://github.com/Exiv2/exiv2/issues/766 | 427,570,800 | 766 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Tag/Release 0.27.1 RC1 in git
Issue date:
--- start body ---
According to https://discuss.pixls.us/t/exiv2-v0-27-1-rc1-is-ready/11963 a new RC was bundled and released - please tag the corresponding commit as well. And if possible please change the policy to use a fourth `.x` element for RCs, all versioning systems I know consider e.g. `0.27.1.1` (RC1 in your scheme) as newer than `0.27.1` (final release). It looks like you already do that for git tags (e.g. `v0.27.0-RC1`), but not for bundles.
As always, thanks everyone for your hard work!
--- end body ---
comments :
--- start comments ---
--- end comments --- | 678 | 207,877 |
[
"Exiv2",
"exiv2"
] | The following are cosmetic. However, it's probably a small effort to hide these distractions.
1) On Cygwin and MinGW:
```
[----------] 3 tests from strError
[ RUN ] strError.returnSuccessAfterClosingFile
/home/rmills/gnu/github/exiv2/buildserver/unitTests/test_futils.cpp:31: Failure
Expected: expectedString
Which is: "Success (errno = 0)"
To be equal to: strError().c_str()
Which is: "No error (errno = 0)"
[ FAILED ] strError.returnSuccessAfterClosingFile (2 ms)
[ RUN ] strError.returnNoSuchFileOrDirectoryWhenTryingToOpenNonExistingFile
[ OK ] strError.returnNoSuchFileOrDirectoryWhenTryingToOpenNonExistingFile (0 ms)
[ RUN ] strError.doNotRecognizeUnknownError
[ OK ] strError.doNotRecognizeUnknownError (0 ms)
[----------] 3 tests from strError (2 ms total)
```
I'm not sure of the origin of strings 'Success' or 'No Error', however we can evade this by only report `if error != 0`.
2) On all platforms, we're getting date/time warnings, from tests which correctly warn as follows:
```Warning: Unsupported time format```
For example (on Linux)
```
[----------] 9 tests from ADateValue
[ RUN ] ADateValue.isDefaultConstructed
[ OK ] ADateValue.isDefaultConstructed (0 ms)
...
[ RUN ] ADateValue.doNotReadFromByteBufferWithoutExpectedSize
Warning: Unsupported date format
....
```
The flag `--quiet` on the exiv2 command-line program will suppress warnings and we should consider using that on those tests. | False Negatives in Unit Tests | https://api.github.com/repos/Exiv2/exiv2/issues/763/comments | 4 | 2019-03-29T09:01:28 | "2019-05-17T16:16:15Z" | https://github.com/Exiv2/exiv2/issues/763 | 426,883,950 | 763 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : False Negatives in Unit Tests
Issue date:
--- start body ---
The following are cosmetic. However, it's probably a small effort to hide these distractions.
1) On Cygwin and MinGW:
```
[----------] 3 tests from strError
[ RUN ] strError.returnSuccessAfterClosingFile
/home/rmills/gnu/github/exiv2/buildserver/unitTests/test_futils.cpp:31: Failure
Expected: expectedString
Which is: "Success (errno = 0)"
To be equal to: strError().c_str()
Which is: "No error (errno = 0)"
[ FAILED ] strError.returnSuccessAfterClosingFile (2 ms)
[ RUN ] strError.returnNoSuchFileOrDirectoryWhenTryingToOpenNonExistingFile
[ OK ] strError.returnNoSuchFileOrDirectoryWhenTryingToOpenNonExistingFile (0 ms)
[ RUN ] strError.doNotRecognizeUnknownError
[ OK ] strError.doNotRecognizeUnknownError (0 ms)
[----------] 3 tests from strError (2 ms total)
```
I'm not sure of the origin of strings 'Success' or 'No Error', however we can evade this by only report `if error != 0`.
2) On all platforms, we're getting date/time warnings, from tests which correctly warn as follows:
```Warning: Unsupported time format```
For example (on Linux)
```
[----------] 9 tests from ADateValue
[ RUN ] ADateValue.isDefaultConstructed
[ OK ] ADateValue.isDefaultConstructed (0 ms)
...
[ RUN ] ADateValue.doNotReadFromByteBufferWithoutExpectedSize
Warning: Unsupported date format
....
```
The flag `--quiet` on the exiv2 command-line program will suppress warnings and we should consider using that on those tests.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,704 | 207,878 |
[
"Exiv2",
"exiv2"
] | I tried with the latest MinGW version binary:
```
$ exiv2.exe -V |& head -1
exiv2 0.27.0
$ exiv2.exe test5p.pdf
Exiv2 exception in print action for file test5p.pdf:
test5p.pdf: The file contains data of an unknown image type
```
That file will be found via ImageMagick forum:
https://imagemagick.org/discourse-server/viewtopic.php?f=3&t=35171#p164630
They say the file is created by Microsoft Word. | Failed to read specific pdf file with error "unknown image type" | https://api.github.com/repos/Exiv2/exiv2/issues/762/comments | 2 | 2019-03-28T01:41:10 | "2019-03-28T11:58:18Z" | https://github.com/Exiv2/exiv2/issues/762 | 426,255,028 | 762 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Failed to read specific pdf file with error "unknown image type"
Issue date:
--- start body ---
I tried with the latest MinGW version binary:
```
$ exiv2.exe -V |& head -1
exiv2 0.27.0
$ exiv2.exe test5p.pdf
Exiv2 exception in print action for file test5p.pdf:
test5p.pdf: The file contains data of an unknown image type
```
That file will be found via ImageMagick forum:
https://imagemagick.org/discourse-server/viewtopic.php?f=3&t=35171#p164630
They say the file is created by Microsoft Word.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 641 | 207,879 |
[
"Exiv2",
"exiv2"
] | I'm unable to get this work on 0.27-maintenance. Clearly the cmake support files have moved from share to lib. That's easy to change.
However, the code fails to compile for me and reports:
```
632 rmills@rmillsmm:~/gnu/github/exiv2/0.27-maintenance/exifprint $ make
Scanning dependencies of target exifprint
[ 50%] Building CXX object CMakeFiles/exifprint.dir/Users/rmills/gnu/github/exiv2/0.27-maintenance/samples/exifprint.cpp.o
/Users/rmills/gnu/github/exiv2/0.27-maintenance/samples/exifprint.cpp:5:10: fatal error: 'exiv2/exiv2.hpp' file not found
#include <exiv2/exiv2.hpp>
```
-----------------------------
The instructions in README.md are (and I'm sure they worked with 0.27).
When exiv2 is installed, the files required to consume Exiv2 are installed in ${CMAKE_INSTALL_PREFIX}/lib/exiv2/cmake/
You can build samples/exifprint.cpp as follows:
```
$ cd <exiv2dir>
$ mkdir exifprint
$ cd exifprint
$ *** EDIT CMakeLists.txt ***
$ cat CMakeLists.txt
cmake_minimum_required(VERSION 3.8)
project(exifprint VERSION 0.0.1 LANGUAGES CXX)
set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_EXTENSIONS OFF)
find_package(exiv2 REQUIRED CONFIG NAMES exiv2) # search ${CMAKE_INSTALL_PREFIX}/lib/exiv2/cmake/
add_executable(exifprint ../samples/exifprint.cpp) # compile this
target_link_libraries(exifprint exiv2) # link exiv2
$ cmake . # generate the makefile
$ make # build the code
$ ./exifprint # test your executable
Usage: ./exifprint [ file | --version || --version-test ]
$
```
| Consuming Exiv2 with CMake | https://api.github.com/repos/Exiv2/exiv2/issues/761/comments | 2 | 2019-03-26T20:09:06 | "2019-03-26T23:00:09Z" | https://github.com/Exiv2/exiv2/issues/761 | 425,624,859 | 761 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Consuming Exiv2 with CMake
Issue date:
--- start body ---
I'm unable to get this work on 0.27-maintenance. Clearly the cmake support files have moved from share to lib. That's easy to change.
However, the code fails to compile for me and reports:
```
632 rmills@rmillsmm:~/gnu/github/exiv2/0.27-maintenance/exifprint $ make
Scanning dependencies of target exifprint
[ 50%] Building CXX object CMakeFiles/exifprint.dir/Users/rmills/gnu/github/exiv2/0.27-maintenance/samples/exifprint.cpp.o
/Users/rmills/gnu/github/exiv2/0.27-maintenance/samples/exifprint.cpp:5:10: fatal error: 'exiv2/exiv2.hpp' file not found
#include <exiv2/exiv2.hpp>
```
-----------------------------
The instructions in README.md are (and I'm sure they worked with 0.27).
When exiv2 is installed, the files required to consume Exiv2 are installed in ${CMAKE_INSTALL_PREFIX}/lib/exiv2/cmake/
You can build samples/exifprint.cpp as follows:
```
$ cd <exiv2dir>
$ mkdir exifprint
$ cd exifprint
$ *** EDIT CMakeLists.txt ***
$ cat CMakeLists.txt
cmake_minimum_required(VERSION 3.8)
project(exifprint VERSION 0.0.1 LANGUAGES CXX)
set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_EXTENSIONS OFF)
find_package(exiv2 REQUIRED CONFIG NAMES exiv2) # search ${CMAKE_INSTALL_PREFIX}/lib/exiv2/cmake/
add_executable(exifprint ../samples/exifprint.cpp) # compile this
target_link_libraries(exifprint exiv2) # link exiv2
$ cmake . # generate the makefile
$ make # build the code
$ ./exifprint # test your executable
Usage: ./exifprint [ file | --version || --version-test ]
$
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,850 | 207,880 |
[
"Exiv2",
"exiv2"
] | POC:
[segment_poc.zip](https://github.com/Exiv2/exiv2/files/3006103/segment_poc.zip)
gdb --args ./exiv2 -pt ~/segment_poc
Program received signal SIGSEGV, Segmentation fault.
0xb7c649d6 in Exiv2::IptcParser::decode (iptcData=..., pData=<optimized out>, size=<optimized out>) at /home/rookie/exiv2-master/src/iptc.cpp:453
453 if (*pRead++ != marker_) continue;
(gdb) bt
#0 0xb7c649d6 in Exiv2::IptcParser::decode (iptcData=..., pData=<optimized out>, size=<optimized out>) at /home/rookie/exiv2-master/src/iptc.cpp:453
#1 0xb7e49838 in Exiv2::Internal::TiffDecoder::decodeIptc (this=<optimized out>, object=0x0) at /home/rookie/exiv2-master/src/tiffvisitor_int.cpp:428
#2 0xb7e46726 in decodeTiffEntry (this=<optimized out>, object=<optimized out>) at /home/rookie/exiv2-master/src/tiffvisitor_int.cpp:476
#3 Exiv2::Internal::TiffDecoder::visitEntry (this=<optimized out>, object=<optimized out>) at /home/rookie/exiv2-master/src/tiffvisitor_int.cpp:312
#4 0xb7e28e2a in Exiv2::Internal::TiffEntry::doAccept (this=0x80cbf00, visitor=...) at /home/rookie/exiv2-master/src/tiffcomposite_int.cpp:895
#5 0xb7e2907a in operator* (this=<optimized out>, visitor=..., this=<optimized out>) at /home/rookie/exiv2-master/src/tiffcomposite_int.cpp:890
#6 Exiv2::Internal::TiffDirectory::doAccept (this=<optimized out>, visitor=...) at /home/rookie/exiv2-master/src/tiffcomposite_int.cpp:918
#7 0xb7e28dae in Exiv2::Internal::TiffComponent::accept (this=0x80cbd40, visitor=...) at /home/rookie/exiv2-master/src/tiffcomposite_int.cpp:890
#8 0xb7e35f69 in Exiv2::Internal::TiffParserWorker::decode (exifData=..., iptcData=..., xmpData=..., pData=<optimized out>, size=<optimized out>, root=<optimized out>, findDecoderFct=<optimized out>, pHeader=<optimized out>)
at /home/rookie/exiv2-master/src/tiffimage_int.cpp:1562
#9 0xb7cf54be in Exiv2::TiffImage::readMetadata (this=<optimized out>) at /home/rookie/exiv2-master/src/tiffimage.cpp:187
#10 0x0807e002 in Action::Print::printList (this=0x80cbb28) at /home/rookie/exiv2-master/src/actions.cpp:523
#11 0x08070c67 in Action::Print::run (this=0x80cbb28, path="/home/rookie/segment_poc") at /home/rookie/exiv2-master/src/actions.cpp:248
#12 0x0804dd9b in main (argc=<optimized out>, argv=<optimized out>) at /home/rookie/exiv2-master/src/exiv2.cpp:172
| one invalid memory access in decode function in iptc.cpp | https://api.github.com/repos/Exiv2/exiv2/issues/760/comments | 2 | 2019-03-26T01:30:40 | "2019-04-10T08:20:03Z" | https://github.com/Exiv2/exiv2/issues/760 | 425,185,549 | 760 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : one invalid memory access in decode function in iptc.cpp
Issue date:
--- start body ---
POC:
[segment_poc.zip](https://github.com/Exiv2/exiv2/files/3006103/segment_poc.zip)
gdb --args ./exiv2 -pt ~/segment_poc
Program received signal SIGSEGV, Segmentation fault.
0xb7c649d6 in Exiv2::IptcParser::decode (iptcData=..., pData=<optimized out>, size=<optimized out>) at /home/rookie/exiv2-master/src/iptc.cpp:453
453 if (*pRead++ != marker_) continue;
(gdb) bt
#0 0xb7c649d6 in Exiv2::IptcParser::decode (iptcData=..., pData=<optimized out>, size=<optimized out>) at /home/rookie/exiv2-master/src/iptc.cpp:453
#1 0xb7e49838 in Exiv2::Internal::TiffDecoder::decodeIptc (this=<optimized out>, object=0x0) at /home/rookie/exiv2-master/src/tiffvisitor_int.cpp:428
#2 0xb7e46726 in decodeTiffEntry (this=<optimized out>, object=<optimized out>) at /home/rookie/exiv2-master/src/tiffvisitor_int.cpp:476
#3 Exiv2::Internal::TiffDecoder::visitEntry (this=<optimized out>, object=<optimized out>) at /home/rookie/exiv2-master/src/tiffvisitor_int.cpp:312
#4 0xb7e28e2a in Exiv2::Internal::TiffEntry::doAccept (this=0x80cbf00, visitor=...) at /home/rookie/exiv2-master/src/tiffcomposite_int.cpp:895
#5 0xb7e2907a in operator* (this=<optimized out>, visitor=..., this=<optimized out>) at /home/rookie/exiv2-master/src/tiffcomposite_int.cpp:890
#6 Exiv2::Internal::TiffDirectory::doAccept (this=<optimized out>, visitor=...) at /home/rookie/exiv2-master/src/tiffcomposite_int.cpp:918
#7 0xb7e28dae in Exiv2::Internal::TiffComponent::accept (this=0x80cbd40, visitor=...) at /home/rookie/exiv2-master/src/tiffcomposite_int.cpp:890
#8 0xb7e35f69 in Exiv2::Internal::TiffParserWorker::decode (exifData=..., iptcData=..., xmpData=..., pData=<optimized out>, size=<optimized out>, root=<optimized out>, findDecoderFct=<optimized out>, pHeader=<optimized out>)
at /home/rookie/exiv2-master/src/tiffimage_int.cpp:1562
#9 0xb7cf54be in Exiv2::TiffImage::readMetadata (this=<optimized out>) at /home/rookie/exiv2-master/src/tiffimage.cpp:187
#10 0x0807e002 in Action::Print::printList (this=0x80cbb28) at /home/rookie/exiv2-master/src/actions.cpp:523
#11 0x08070c67 in Action::Print::run (this=0x80cbb28, path="/home/rookie/segment_poc") at /home/rookie/exiv2-master/src/actions.cpp:248
#12 0x0804dd9b in main (argc=<optimized out>, argv=<optimized out>) at /home/rookie/exiv2-master/src/exiv2.cpp:172
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,555 | 207,881 |
[
"Exiv2",
"exiv2"
] | POC:
[fpe_poc.zip](https://github.com/Exiv2/exiv2/files/3006099/fpe_poc.zip)
gdb --args ./exiv2 -pt ~/fpe_poc
Program received signal SIGFPE, Arithmetic exception.
0xb7e0c1a2 in Exiv2::Internal::printLong (os=..., value=...) at /home/rookie/exiv2-master/src/tags_int.cpp:2197
2197 if (r.second != 0) return os << static_cast<long>(r.first) / r.second;
(gdb) bt
#0 0xb7e0c1a2 in Exiv2::Internal::printLong (os=..., value=...) at /home/rookie/exiv2-master/src/tags_int.cpp:2197
#1 0xb7c18f93 in Exiv2::Exifdatum::write (this=0x80d5878, os=..., pMetadata=<optimized out>) at /home/rookie/exiv2-master/src/exif.cpp:227
#2 0xb7c92723 in Exiv2::Metadatum::print (this=<optimized out>, pMetadata=0x80cbcb0) at /home/rookie/exiv2-master/src/metadatum.cpp:74
#3 0x080831ec in Action::Print::printMetadatum (this=<optimized out>, md=..., pImage=<optimized out>) at /home/rookie/exiv2-master/src/actions.cpp:745
#4 0x0807ff5c in Action::Print::printMetadata (this=<optimized out>, image=<optimized out>) at /home/rookie/exiv2-master/src/actions.cpp:542
#5 0x0807e113 in Action::Print::printList (this=0x80cbb20) at /home/rookie/exiv2-master/src/actions.cpp:531
#6 0x08070c67 in Action::Print::run (this=0x80cbb20, path="/home/rookie/fpe_poc") at /home/rookie/exiv2-master/src/actions.cpp:248
#7 0x0804dd9b in main (argc=<optimized out>, argv=<optimized out>) at /home/rookie/exiv2-master/src/exiv2.cpp:172
| float point exception in printLong function in tags_int.cpp | https://api.github.com/repos/Exiv2/exiv2/issues/759/comments | 1 | 2019-03-26T01:26:12 | "2019-07-25T15:22:56Z" | https://github.com/Exiv2/exiv2/issues/759 | 425,184,651 | 759 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : float point exception in printLong function in tags_int.cpp
Issue date:
--- start body ---
POC:
[fpe_poc.zip](https://github.com/Exiv2/exiv2/files/3006099/fpe_poc.zip)
gdb --args ./exiv2 -pt ~/fpe_poc
Program received signal SIGFPE, Arithmetic exception.
0xb7e0c1a2 in Exiv2::Internal::printLong (os=..., value=...) at /home/rookie/exiv2-master/src/tags_int.cpp:2197
2197 if (r.second != 0) return os << static_cast<long>(r.first) / r.second;
(gdb) bt
#0 0xb7e0c1a2 in Exiv2::Internal::printLong (os=..., value=...) at /home/rookie/exiv2-master/src/tags_int.cpp:2197
#1 0xb7c18f93 in Exiv2::Exifdatum::write (this=0x80d5878, os=..., pMetadata=<optimized out>) at /home/rookie/exiv2-master/src/exif.cpp:227
#2 0xb7c92723 in Exiv2::Metadatum::print (this=<optimized out>, pMetadata=0x80cbcb0) at /home/rookie/exiv2-master/src/metadatum.cpp:74
#3 0x080831ec in Action::Print::printMetadatum (this=<optimized out>, md=..., pImage=<optimized out>) at /home/rookie/exiv2-master/src/actions.cpp:745
#4 0x0807ff5c in Action::Print::printMetadata (this=<optimized out>, image=<optimized out>) at /home/rookie/exiv2-master/src/actions.cpp:542
#5 0x0807e113 in Action::Print::printList (this=0x80cbb20) at /home/rookie/exiv2-master/src/actions.cpp:531
#6 0x08070c67 in Action::Print::run (this=0x80cbb20, path="/home/rookie/fpe_poc") at /home/rookie/exiv2-master/src/actions.cpp:248
#7 0x0804dd9b in main (argc=<optimized out>, argv=<optimized out>) at /home/rookie/exiv2-master/src/exiv2.cpp:172
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,650 | 207,882 |
[
"Exiv2",
"exiv2"
] | POC:
[poc.zip](https://github.com/Exiv2/exiv2/files/3001421/poc.zip)
There exists one global-buffer-overread in Exiv2::Internal::Nikon1MakerNote::print0x0088 in nikonmn_int.cpp in exiv2 0.27.99.0 which could result in information leak.
```
$ exiv2 -pt $poc
==27589==ERROR: AddressSanitizer: global-buffer-overflow on address 0xb7699d34 at pc 0xb6efa9f3 bp 0xbfc07508 sp 0xbfc07500
READ of size 4 at 0xb7699d34 thread T0
#0 0xb6efa9f2 in Exiv2::Internal::Nikon1MakerNote::print0x0088(std::ostream&, Exiv2::Value const&, Exiv2::ExifData const*) /home/rookie/asan/exiv2-master/src/nikonmn_int.cpp:374
#1 0xb6677efc in Exiv2::Exifdatum::write(std::ostream&, Exiv2::ExifData const*) const /home/rookie/asan/exiv2-master/src/exif.cpp:227
#2 0xb68d6c1c in Exiv2::Metadatum::print(Exiv2::ExifData const*) const /home/rookie/asan/exiv2-master/src/metadatum.cpp:74
#3 0x82150ef in Action::Print::printMetadatum(Exiv2::Metadatum const&, Exiv2::Image const*) /home/rookie/asan/exiv2-master/src/actions.cpp:745
#4 0x8206d2d in Action::Print::printMetadata(Exiv2::Image const*) /home/rookie/asan/exiv2-master/src/actions.cpp:542
#5 0x81fabf1 in Action::Print::printList() /home/rookie/asan/exiv2-master/src/actions.cpp:531
#6 0x81a6225 in Action::Print::run(std::string const&) /home/rookie/asan/exiv2-master/src/actions.cpp:248
#7 0x80d3aa5 in main /home/rookie/asan/exiv2-master/src/exiv2.cpp:172
#8 0xb600aaf2 (/lib/i386-linux-gnu/libc.so.6+0x19af2)
#9 0x80d1af4 in _start (/home/rookie/asan/exiv2-master/build/bin/exiv2+0x80d1af4)
0xb7699d34 is located 44 bytes to the left of global variable 'Exiv2::Internal::nikonFlashControlMode' from '/home/rookie/asan/exiv2-master/src/nikonmn_int.cpp' (0xb7699d60) of size 108
0xb7699d34 is located 76 bytes to the right of global variable 'Exiv2::Internal::nikonFlashGNDistance' from '/home/rookie/asan/exiv2-master/src/nikonmn_int.cpp' (0xb7699b20) of size 456
SUMMARY: AddressSanitizer: global-buffer-overflow /home/rookie/asan/exiv2-master/src/nikonmn_int.cpp:374 Exiv2::Internal::Nikon1MakerNote::print0x0088(std::ostream&, Exiv2::Value const&, Exiv2::ExifData const*)
Shadow bytes around the buggy address:
0x36ed3350: 00 00 00 00 00 00 00 00 00 00 00 00 00 f9 f9 f9
0x36ed3360: f9 f9 f9 f9 00 00 00 00 00 00 00 00 00 00 00 00
0x36ed3370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x36ed3380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x36ed3390: 00 00 00 00 00 00 00 00 00 00 00 00 00 f9 f9 f9
=>0x36ed33a0: f9 f9 f9 f9 f9 f9[f9]f9 f9 f9 f9 f9 00 00 00 00
0x36ed33b0: 00 00 00 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 f9
0x36ed33c0: 00 00 00 00 04 f9 f9 f9 f9 f9 f9 f9 00 00 00 00
0x36ed33d0: 00 00 00 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 f9
0x36ed33e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x36ed33f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Heap right redzone: fb
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack partial redzone: f4
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
ASan internal: fe
==27589==ABORTING
``` | one global-buffer-overread in Exiv2::Internal::Nikon1MakerNote::print0x0088 in nikonmn_int.cpp | https://api.github.com/repos/Exiv2/exiv2/issues/756/comments | 2 | 2019-03-25T03:52:31 | "2019-03-29T12:35:23Z" | https://github.com/Exiv2/exiv2/issues/756 | 424,712,263 | 756 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : one global-buffer-overread in Exiv2::Internal::Nikon1MakerNote::print0x0088 in nikonmn_int.cpp
Issue date:
--- start body ---
POC:
[poc.zip](https://github.com/Exiv2/exiv2/files/3001421/poc.zip)
There exists one global-buffer-overread in Exiv2::Internal::Nikon1MakerNote::print0x0088 in nikonmn_int.cpp in exiv2 0.27.99.0 which could result in information leak.
```
$ exiv2 -pt $poc
==27589==ERROR: AddressSanitizer: global-buffer-overflow on address 0xb7699d34 at pc 0xb6efa9f3 bp 0xbfc07508 sp 0xbfc07500
READ of size 4 at 0xb7699d34 thread T0
#0 0xb6efa9f2 in Exiv2::Internal::Nikon1MakerNote::print0x0088(std::ostream&, Exiv2::Value const&, Exiv2::ExifData const*) /home/rookie/asan/exiv2-master/src/nikonmn_int.cpp:374
#1 0xb6677efc in Exiv2::Exifdatum::write(std::ostream&, Exiv2::ExifData const*) const /home/rookie/asan/exiv2-master/src/exif.cpp:227
#2 0xb68d6c1c in Exiv2::Metadatum::print(Exiv2::ExifData const*) const /home/rookie/asan/exiv2-master/src/metadatum.cpp:74
#3 0x82150ef in Action::Print::printMetadatum(Exiv2::Metadatum const&, Exiv2::Image const*) /home/rookie/asan/exiv2-master/src/actions.cpp:745
#4 0x8206d2d in Action::Print::printMetadata(Exiv2::Image const*) /home/rookie/asan/exiv2-master/src/actions.cpp:542
#5 0x81fabf1 in Action::Print::printList() /home/rookie/asan/exiv2-master/src/actions.cpp:531
#6 0x81a6225 in Action::Print::run(std::string const&) /home/rookie/asan/exiv2-master/src/actions.cpp:248
#7 0x80d3aa5 in main /home/rookie/asan/exiv2-master/src/exiv2.cpp:172
#8 0xb600aaf2 (/lib/i386-linux-gnu/libc.so.6+0x19af2)
#9 0x80d1af4 in _start (/home/rookie/asan/exiv2-master/build/bin/exiv2+0x80d1af4)
0xb7699d34 is located 44 bytes to the left of global variable 'Exiv2::Internal::nikonFlashControlMode' from '/home/rookie/asan/exiv2-master/src/nikonmn_int.cpp' (0xb7699d60) of size 108
0xb7699d34 is located 76 bytes to the right of global variable 'Exiv2::Internal::nikonFlashGNDistance' from '/home/rookie/asan/exiv2-master/src/nikonmn_int.cpp' (0xb7699b20) of size 456
SUMMARY: AddressSanitizer: global-buffer-overflow /home/rookie/asan/exiv2-master/src/nikonmn_int.cpp:374 Exiv2::Internal::Nikon1MakerNote::print0x0088(std::ostream&, Exiv2::Value const&, Exiv2::ExifData const*)
Shadow bytes around the buggy address:
0x36ed3350: 00 00 00 00 00 00 00 00 00 00 00 00 00 f9 f9 f9
0x36ed3360: f9 f9 f9 f9 00 00 00 00 00 00 00 00 00 00 00 00
0x36ed3370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x36ed3380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x36ed3390: 00 00 00 00 00 00 00 00 00 00 00 00 00 f9 f9 f9
=>0x36ed33a0: f9 f9 f9 f9 f9 f9[f9]f9 f9 f9 f9 f9 00 00 00 00
0x36ed33b0: 00 00 00 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 f9
0x36ed33c0: 00 00 00 00 04 f9 f9 f9 f9 f9 f9 f9 00 00 00 00
0x36ed33d0: 00 00 00 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 f9
0x36ed33e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x36ed33f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Heap right redzone: fb
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack partial redzone: f4
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
ASan internal: fe
==27589==ABORTING
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 3,708 | 207,883 |
[
"Exiv2",
"exiv2"
] | Exiv2 reports wrong image width and height for Fuji Raf files. Looking at the code, this is because it returns "Exif.Photo.PixelXDimension"/"Exif.Photo.PixelYDimension" for width/height, which is obtained from the embedded JPEG, which is not the size of the raw image. | Wrong image size reported for Fuji raf | https://api.github.com/repos/Exiv2/exiv2/issues/755/comments | 2 | 2019-03-24T15:56:04 | "2019-07-28T21:06:35Z" | https://github.com/Exiv2/exiv2/issues/755 | 424,628,410 | 755 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Wrong image size reported for Fuji raf
Issue date:
--- start body ---
Exiv2 reports wrong image width and height for Fuji Raf files. Looking at the code, this is because it returns "Exif.Photo.PixelXDimension"/"Exif.Photo.PixelYDimension" for width/height, which is obtained from the embedded JPEG, which is not the size of the raw image.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 467 | 207,884 |
[
"Exiv2",
"exiv2"
] | Hi,
I have installed the current master version and face a regression of my Samyang 14mm lens. It now is wrongly identified as a 10mm lens. I am aware of the ~/.exiv2 file that can be used to tune the lens but I decided to file this bugreport because it is a regression as it is working fine in version .25.
----------------
Correct information:
dave@matebook:~$ /usr/bin/exiv2 --version
exiv2 0.25 001900 (64 bit build)
dave@matebook:~$ /usr/bin/exiv2 -pa --grep LensIDNumber ~/Schreibtisch/106ND750/DSC_4754.NEF
Exif.NikonLd3.LensIDNumber Byte 1 Samyang AE 14mm f/2.8 ED AS IF UMC
----------------
Incorrect information:
dave@matebook:~$ exiv2 --version
exiv2 0.27.99.0
dave@matebook:~$ exiv2 -pa --grep LensIDNumber ~/Schreibtisch/106ND750/DSC_4754.NEF
Exif.NikonLd3.LensIDNumber Byte 1 Samyang 10mm f/2.8 ED AS NCS CS
For completeness I have added this information:
dave@matebook:~$ exiv2 -pv --grep focal/i --grep lens/i --grep mcu/i ~/Schreibtisch/106ND750/DSC_4754.NEF
0x920a Photo FocalLength Rational 1 140/10
0x0083 Nikon3 LensType Byte 1 2
0x0084 Nikon3 Lens Rational 4 140/10 140/10 28/10 14/10
0x008b Nikon3 LensFStops Undefined 4 72 1 12 0
0x000b NikonLd3 FocalLength Byte 1 36
0x000c NikonLd3 LensIDNumber Byte 1 74
0x000d NikonLd3 LensFStops Byte 1 72
0x000e NikonLd3 MinFocalLength Byte 1 36
0x000f NikonLd3 MaxFocalLength Byte 1 36
0x0010 NikonLd3 MaxApertureAtMinFocal Byte 1 36
0x0011 NikonLd3 MaxApertureAtMaxFocal Byte 1 12
0x0012 NikonLd3 MCUVersion Byte 1 77
0xa405 Photo FocalLengthIn35mmFilm Short 1 14
I can also send a caps-on, complete black image soon if you need it.
Kind regards
Dave
| Regression in detected lens | https://api.github.com/repos/Exiv2/exiv2/issues/754/comments | 14 | 2019-03-24T13:12:21 | "2019-05-23T09:26:48Z" | https://github.com/Exiv2/exiv2/issues/754 | 424,611,509 | 754 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Regression in detected lens
Issue date:
--- start body ---
Hi,
I have installed the current master version and face a regression of my Samyang 14mm lens. It now is wrongly identified as a 10mm lens. I am aware of the ~/.exiv2 file that can be used to tune the lens but I decided to file this bugreport because it is a regression as it is working fine in version .25.
----------------
Correct information:
dave@matebook:~$ /usr/bin/exiv2 --version
exiv2 0.25 001900 (64 bit build)
dave@matebook:~$ /usr/bin/exiv2 -pa --grep LensIDNumber ~/Schreibtisch/106ND750/DSC_4754.NEF
Exif.NikonLd3.LensIDNumber Byte 1 Samyang AE 14mm f/2.8 ED AS IF UMC
----------------
Incorrect information:
dave@matebook:~$ exiv2 --version
exiv2 0.27.99.0
dave@matebook:~$ exiv2 -pa --grep LensIDNumber ~/Schreibtisch/106ND750/DSC_4754.NEF
Exif.NikonLd3.LensIDNumber Byte 1 Samyang 10mm f/2.8 ED AS NCS CS
For completeness I have added this information:
dave@matebook:~$ exiv2 -pv --grep focal/i --grep lens/i --grep mcu/i ~/Schreibtisch/106ND750/DSC_4754.NEF
0x920a Photo FocalLength Rational 1 140/10
0x0083 Nikon3 LensType Byte 1 2
0x0084 Nikon3 Lens Rational 4 140/10 140/10 28/10 14/10
0x008b Nikon3 LensFStops Undefined 4 72 1 12 0
0x000b NikonLd3 FocalLength Byte 1 36
0x000c NikonLd3 LensIDNumber Byte 1 74
0x000d NikonLd3 LensFStops Byte 1 72
0x000e NikonLd3 MinFocalLength Byte 1 36
0x000f NikonLd3 MaxFocalLength Byte 1 36
0x0010 NikonLd3 MaxApertureAtMinFocal Byte 1 36
0x0011 NikonLd3 MaxApertureAtMaxFocal Byte 1 12
0x0012 NikonLd3 MCUVersion Byte 1 77
0xa405 Photo FocalLengthIn35mmFilm Short 1 14
I can also send a caps-on, complete black image soon if you need it.
Kind regards
Dave
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,346 | 207,885 |
[
"Exiv2",
"exiv2"
] | The cmake support files have been moved by #625.
Documentation abut those files (ReadMe.txt, README.md and README-CONAN.md) need review and possibly fixed.
| Review/fix documentation concerning CMake support files. | https://api.github.com/repos/Exiv2/exiv2/issues/745/comments | 2 | 2019-03-15T16:44:32 | "2019-04-12T08:48:11Z" | https://github.com/Exiv2/exiv2/issues/745 | 421,609,771 | 745 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Review/fix documentation concerning CMake support files.
Issue date:
--- start body ---
The cmake support files have been moved by #625.
Documentation abut those files (ReadMe.txt, README.md and README-CONAN.md) need review and possibly fixed.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 375 | 207,886 |
[
"Exiv2",
"exiv2"
] | There's an issue in `Jp2Image::printStructure()` causing an exception when we dump the header structure. This was reported in #740 and @D4N requested that it be logged separately.
```
$ for i in test/data/*.jp2 ; do exiv2 -pS $i; done
STRUCTURE OF JPEG2000 FILE: test/data/Reagan.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 45 | jp2h |
40 | 22 | sub:ihdr | Uncaught exception: Invalid slice bounds specified
STRUCTURE OF JPEG2000 FILE: test/data/Reagan2.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 3185 | jp2h |
40 | 22 | sub:ihdr | Uncaught exception: Invalid slice bounds specified
STRUCTURE OF JPEG2000 FILE: test/data/relax.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 345 | jp2h |
40 | 22 | sub:ihdr | Uncaught exception: Invalid slice bounds specified
706 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $
```
This appears to be caused by the '30' passed to makeSlice() when there are less than 30 bytes in data.buf_
My fix is:
``` patch
diff --git a/src/jp2image.cpp b/src/jp2image.cpp
index 39a6f58..80d1ec2 100644
--- a/src/jp2image.cpp
+++ b/src/jp2image.cpp
@@ -508,9 +508,11 @@ namespace Exiv2
DataBuf data(subBox.length-sizeof(box));
io_->read(data.pData_,data.size_);
if ( bPrint ) {
+ size_t ssize = data.size_;
+ if ( ssize > 30 ) ssize = 30; // limit the binary data presentation to 30 bytes
out << Internal::stringFormat("%8ld | %8ld | sub:",(size_t)address,(size_t)subBox.length)
<< toAscii(subBox.type)
- <<" | " << Internal::binaryToString(makeSlice(data, 0, 30));
+ <<" | " << Internal::binaryToString(makeSlice(data, 0, ssize));
bLF = true;
}
707 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $
```
With this fix, the output is:
```
.../exiv2/0.27-maintenance $ for i in test/data/*.jp2 ; do cmake-build-debug/bin/exiv2 -pS $i; done
STRUCTURE OF JPEG2000 FILE: test/data/Reagan.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 45 | jp2h |
40 | 22 | sub:ihdr | .............
62 | 15 | sub:colr | ....... | pad: 1 0 0 | iccLength:16
77 | 1342 | uuid | Exif: II*...........................>........
1419 | 942 | uuid | IPTC: ............040621-N-6536T-062.....5...
2361 | 5590 | uuid | XMP : <?xpacket begin="..." id="W5M0MpCehiHzre
7951 | 32658 | jp2c |
STRUCTURE OF JPEG2000 FILE: test/data/Reagan2.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 3185 | jp2h |
40 | 22 | sub:ihdr | .............
62 | 3155 | sub:colr | ......HLino....mntrRGB XYZ .. | pad: 2 0 0 | iccLength:3144
3217 | 0 | jp2c |
STRUCTURE OF JPEG2000 FILE: test/data/relax.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 345 | jp2h |
40 | 22 | sub:ihdr | ...,.........
62 | 289 | sub:colr | ............ ..scnrRGB XYZ .. | pad: 2 0 0 | iccLength:278
351 | 26 | sub:res | ....resc$I..$I....
377 | 0 | jp2c |
708 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $
```
This fault applies to both 'master' and '0.27-maintenance'. | JP2000 -pS (print Structure) throws 'Invalid slice bounds specified' on all jp2 files. | https://api.github.com/repos/Exiv2/exiv2/issues/744/comments | 0 | 2019-03-15T14:12:51 | "2019-04-09T06:29:51Z" | https://github.com/Exiv2/exiv2/issues/744 | 421,538,523 | 744 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : JP2000 -pS (print Structure) throws 'Invalid slice bounds specified' on all jp2 files.
Issue date:
--- start body ---
There's an issue in `Jp2Image::printStructure()` causing an exception when we dump the header structure. This was reported in #740 and @D4N requested that it be logged separately.
```
$ for i in test/data/*.jp2 ; do exiv2 -pS $i; done
STRUCTURE OF JPEG2000 FILE: test/data/Reagan.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 45 | jp2h |
40 | 22 | sub:ihdr | Uncaught exception: Invalid slice bounds specified
STRUCTURE OF JPEG2000 FILE: test/data/Reagan2.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 3185 | jp2h |
40 | 22 | sub:ihdr | Uncaught exception: Invalid slice bounds specified
STRUCTURE OF JPEG2000 FILE: test/data/relax.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 345 | jp2h |
40 | 22 | sub:ihdr | Uncaught exception: Invalid slice bounds specified
706 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $
```
This appears to be caused by the '30' passed to makeSlice() when there are less than 30 bytes in data.buf_
My fix is:
``` patch
diff --git a/src/jp2image.cpp b/src/jp2image.cpp
index 39a6f58..80d1ec2 100644
--- a/src/jp2image.cpp
+++ b/src/jp2image.cpp
@@ -508,9 +508,11 @@ namespace Exiv2
DataBuf data(subBox.length-sizeof(box));
io_->read(data.pData_,data.size_);
if ( bPrint ) {
+ size_t ssize = data.size_;
+ if ( ssize > 30 ) ssize = 30; // limit the binary data presentation to 30 bytes
out << Internal::stringFormat("%8ld | %8ld | sub:",(size_t)address,(size_t)subBox.length)
<< toAscii(subBox.type)
- <<" | " << Internal::binaryToString(makeSlice(data, 0, 30));
+ <<" | " << Internal::binaryToString(makeSlice(data, 0, ssize));
bLF = true;
}
707 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $
```
With this fix, the output is:
```
.../exiv2/0.27-maintenance $ for i in test/data/*.jp2 ; do cmake-build-debug/bin/exiv2 -pS $i; done
STRUCTURE OF JPEG2000 FILE: test/data/Reagan.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 45 | jp2h |
40 | 22 | sub:ihdr | .............
62 | 15 | sub:colr | ....... | pad: 1 0 0 | iccLength:16
77 | 1342 | uuid | Exif: II*...........................>........
1419 | 942 | uuid | IPTC: ............040621-N-6536T-062.....5...
2361 | 5590 | uuid | XMP : <?xpacket begin="..." id="W5M0MpCehiHzre
7951 | 32658 | jp2c |
STRUCTURE OF JPEG2000 FILE: test/data/Reagan2.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 3185 | jp2h |
40 | 22 | sub:ihdr | .............
62 | 3155 | sub:colr | ......HLino....mntrRGB XYZ .. | pad: 2 0 0 | iccLength:3144
3217 | 0 | jp2c |
STRUCTURE OF JPEG2000 FILE: test/data/relax.jp2
address | length | box | data
0 | 12 | jP |
12 | 20 | ftyp |
32 | 345 | jp2h |
40 | 22 | sub:ihdr | ...,.........
62 | 289 | sub:colr | ............ ..scnrRGB XYZ .. | pad: 2 0 0 | iccLength:278
351 | 26 | sub:res | ....resc$I..$I....
377 | 0 | jp2c |
708 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $
```
This fault applies to both 'master' and '0.27-maintenance'.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,274 | 207,887 |
[
"Exiv2",
"exiv2"
] | Hi, I have a Sigma Lens which I do not find supported yet. Though the entry
cat ~/.exiv2
[nikon]
201=Sigma 24-70mm F2,8 DG OS HSM Art
is working fine I hope I can help others to have an automatic support. As described at 3. Contributing Lens Data I shot a small JPG with caps-on that is unmodified and attached to this case.
I would love to make a pr, but I have no idea and did not find any documentation how to create and interprete the data required for fmountlens[].
Btw, these links are dead (from src/nikonmn_int.cpp):
//------------------------------------------------------------------------------
//
//
// Created by Robert Rottmerhusen 2005 - 2018
// http://www.rottmerhusen.com (lens_id@rottmerhusen.com)
//
// For contributor info and more visit my online list:
// http://www.rottmerhusen.com/objektives/lensid/thirdparty.html
Kind regards
Dave | Sigma 24-70mm F2,8 DG OS HSM Art not detected | https://api.github.com/repos/Exiv2/exiv2/issues/743/comments | 7 | 2019-03-14T21:07:52 | "2019-05-21T10:38:49Z" | https://github.com/Exiv2/exiv2/issues/743 | 421,245,054 | 743 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Sigma 24-70mm F2,8 DG OS HSM Art not detected
Issue date:
--- start body ---
Hi, I have a Sigma Lens which I do not find supported yet. Though the entry
cat ~/.exiv2
[nikon]
201=Sigma 24-70mm F2,8 DG OS HSM Art
is working fine I hope I can help others to have an automatic support. As described at 3. Contributing Lens Data I shot a small JPG with caps-on that is unmodified and attached to this case.
I would love to make a pr, but I have no idea and did not find any documentation how to create and interprete the data required for fmountlens[].
Btw, these links are dead (from src/nikonmn_int.cpp):
//------------------------------------------------------------------------------
//
//
// Created by Robert Rottmerhusen 2005 - 2018
// http://www.rottmerhusen.com (lens_id@rottmerhusen.com)
//
// For contributor info and more visit my online list:
// http://www.rottmerhusen.com/objektives/lensid/thirdparty.html
Kind regards
Dave
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,209 | 207,888 |
[
"Exiv2",
"exiv2"
] | Hi there,
An issue was discovered in DataBuf data(subBox.length-sizeof(box)) function in image.cpp, as distributed in master and version 0.27. There is an uncontrolled memory allocation problem, leading to a program crash. I have also confirmed this issue by using addressSanitizer.
Here is the POC file. Please use the β./exiv2 -pX $POCβ to reproduce the bug.
[POC.zip](https://github.com/Exiv2/exiv2/files/2961347/POC.zip)
```
subBox.length = getLong((byte*)&subBox.length, bigEndian);
subBox.type = getLong((byte*)&subBox.type, bigEndian);
// subBox.length makes no sense if it is larger than the rest of the file
if (subBox.length > io_->size() - io_->tell()) {
throw Error(kerCorruptedMetadata);
}
DataBuf data(subBox.length-sizeof(box));
io_->read(data.pData_,data.size_);
```
The ASAN dumps the stack trace as follows:
```
==9819==WARNING: AddressSanitizer failed to allocate 0xffffffffffffffff bytes
=================================================================
==9819==ERROR: AddressSanitizer: unknown-crash on address 0xffffffffffffffff at pc 0x0000004a9325 bp 0x7fffe470cec0 sp 0x7fffe470c670
WRITE of size 18446744073709551615 at 0xffffffffffffffff thread T0
#0 0x4a9324 in __asan_memset (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4a9324)
#1 0x7f3986594f9c in Exiv2::DataBuf::DataBuf(long) /home/wencheng/Documents/FuzzingObject/exiv2/src/types.cpp:141:42
#2 0x7f39864b354c in Exiv2::Jp2Image::printStructure(std::ostream&, Exiv2::PrintStructureOption, int) /home/wencheng/Documents/FuzzingObject/exiv2/src/jp2image.cpp:506:37
#3 0x53fa0d in (anonymous namespace)::printStructure(std::ostream&, Exiv2::PrintStructureOption, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:2368:9
#4 0x5400f2 in Action::setModeAndPrintStructure(Exiv2::PrintStructureOption, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:237:16
#5 0x5400f2 in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:256
#6 0x4f42f5 in main /home/wencheng/Documents/FuzzingObject/exiv2/src/exiv2.cpp:172:23
#7 0x7f3984e1982f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291
#8 0x41f0a8 in _start (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x41f0a8)
==9819==AddressSanitizer CHECK failed: /build/llvm-toolchain-3.8-_PD09B/llvm-toolchain-3.8-3.8/projects/compiler-rt/lib/asan/asan_report.cc:354 "((0 && "Address is not in memory and not in shadow?")) != (0)" (0x0, 0x0)
#0 0x4c87dd in __asan::AsanCheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4c87dd)
#1 0x4cf403 in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4cf403)
#2 0x4c3f9b in __asan::DescribeAddress(unsigned long, unsigned long, char const*) (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4c3f9b)
#3 0x4c4480 in __asan::ReportGenericError(unsigned long, unsigned long, unsigned long, unsigned long, bool, unsigned long, unsigned int, bool) [clone .part.18] (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4c4480)
#4 0x4a9346 in __asan_memset (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4a9346)
#5 0x7f3986594f9c in Exiv2::DataBuf::DataBuf(long) /home/wencheng/Documents/FuzzingObject/exiv2/src/types.cpp:141:42
#6 0x7f39864b354c in Exiv2::Jp2Image::printStructure(std::ostream&, Exiv2::PrintStructureOption, int) /home/wencheng/Documents/FuzzingObject/exiv2/src/jp2image.cpp:506:37
#7 0x53fa0d in (anonymous namespace)::printStructure(std::ostream&, Exiv2::PrintStructureOption, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:2368:9
#8 0x5400f2 in Action::setModeAndPrintStructure(Exiv2::PrintStructureOption, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:237:16
#9 0x5400f2 in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:256
#10 0x4f42f5 in main /home/wencheng/Documents/FuzzingObject/exiv2/src/exiv2.cpp:172:23
#11 0x7f3984e1982f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291
#12 0x41f0a8 in _start (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x41f0a8)
```
| [bug report] Program crash due to uncontrolled memory allocation on function DataBuf data(subBox.length-sizeof(box)) | https://api.github.com/repos/Exiv2/exiv2/issues/742/comments | 3 | 2019-03-13T12:11:16 | "2019-03-31T09:57:54Z" | https://github.com/Exiv2/exiv2/issues/742 | 420,466,480 | 742 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : [bug report] Program crash due to uncontrolled memory allocation on function DataBuf data(subBox.length-sizeof(box))
Issue date:
--- start body ---
Hi there,
An issue was discovered in DataBuf data(subBox.length-sizeof(box)) function in image.cpp, as distributed in master and version 0.27. There is an uncontrolled memory allocation problem, leading to a program crash. I have also confirmed this issue by using addressSanitizer.
Here is the POC file. Please use the β./exiv2 -pX $POCβ to reproduce the bug.
[POC.zip](https://github.com/Exiv2/exiv2/files/2961347/POC.zip)
```
subBox.length = getLong((byte*)&subBox.length, bigEndian);
subBox.type = getLong((byte*)&subBox.type, bigEndian);
// subBox.length makes no sense if it is larger than the rest of the file
if (subBox.length > io_->size() - io_->tell()) {
throw Error(kerCorruptedMetadata);
}
DataBuf data(subBox.length-sizeof(box));
io_->read(data.pData_,data.size_);
```
The ASAN dumps the stack trace as follows:
```
==9819==WARNING: AddressSanitizer failed to allocate 0xffffffffffffffff bytes
=================================================================
==9819==ERROR: AddressSanitizer: unknown-crash on address 0xffffffffffffffff at pc 0x0000004a9325 bp 0x7fffe470cec0 sp 0x7fffe470c670
WRITE of size 18446744073709551615 at 0xffffffffffffffff thread T0
#0 0x4a9324 in __asan_memset (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4a9324)
#1 0x7f3986594f9c in Exiv2::DataBuf::DataBuf(long) /home/wencheng/Documents/FuzzingObject/exiv2/src/types.cpp:141:42
#2 0x7f39864b354c in Exiv2::Jp2Image::printStructure(std::ostream&, Exiv2::PrintStructureOption, int) /home/wencheng/Documents/FuzzingObject/exiv2/src/jp2image.cpp:506:37
#3 0x53fa0d in (anonymous namespace)::printStructure(std::ostream&, Exiv2::PrintStructureOption, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:2368:9
#4 0x5400f2 in Action::setModeAndPrintStructure(Exiv2::PrintStructureOption, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:237:16
#5 0x5400f2 in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:256
#6 0x4f42f5 in main /home/wencheng/Documents/FuzzingObject/exiv2/src/exiv2.cpp:172:23
#7 0x7f3984e1982f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291
#8 0x41f0a8 in _start (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x41f0a8)
==9819==AddressSanitizer CHECK failed: /build/llvm-toolchain-3.8-_PD09B/llvm-toolchain-3.8-3.8/projects/compiler-rt/lib/asan/asan_report.cc:354 "((0 && "Address is not in memory and not in shadow?")) != (0)" (0x0, 0x0)
#0 0x4c87dd in __asan::AsanCheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4c87dd)
#1 0x4cf403 in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4cf403)
#2 0x4c3f9b in __asan::DescribeAddress(unsigned long, unsigned long, char const*) (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4c3f9b)
#3 0x4c4480 in __asan::ReportGenericError(unsigned long, unsigned long, unsigned long, unsigned long, bool, unsigned long, unsigned int, bool) [clone .part.18] (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4c4480)
#4 0x4a9346 in __asan_memset (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x4a9346)
#5 0x7f3986594f9c in Exiv2::DataBuf::DataBuf(long) /home/wencheng/Documents/FuzzingObject/exiv2/src/types.cpp:141:42
#6 0x7f39864b354c in Exiv2::Jp2Image::printStructure(std::ostream&, Exiv2::PrintStructureOption, int) /home/wencheng/Documents/FuzzingObject/exiv2/src/jp2image.cpp:506:37
#7 0x53fa0d in (anonymous namespace)::printStructure(std::ostream&, Exiv2::PrintStructureOption, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:2368:9
#8 0x5400f2 in Action::setModeAndPrintStructure(Exiv2::PrintStructureOption, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:237:16
#9 0x5400f2 in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/wencheng/Documents/FuzzingObject/exiv2/src/actions.cpp:256
#10 0x4f42f5 in main /home/wencheng/Documents/FuzzingObject/exiv2/src/exiv2.cpp:172:23
#11 0x7f3984e1982f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291
#12 0x41f0a8 in _start (/home/wencheng/Documents/FuzzingObject/exiv2/build/bin/exiv2+0x41f0a8)
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 5,266 | 207,889 |
[
"Exiv2",
"exiv2"
] | Hi there,
An issue was discovered in Exiv2::Image::printIFDStructure function in image.cpp, as distributed in master and version 0.27. There is a stack exhaustion problem caused by the in printIFDStructure function making recursive calls to itself.
Here is the POC file. Please use the β./exiv2 -pR $POCβ to reproduce the bug.
[POC.zip](https://github.com/Exiv2/exiv2/files/2960549/POC.zip)
The ASAN dumps the stack trace as follows:
```
ASAN:DEADLYSIGNAL
=================================================================
==621==ERROR: AddressSanitizer: stack-overflow on address 0x7ffcbaecbff8 (pc 0x0000004d6c3f bp 0x0ff43348f15c sp 0x7ffcbaecc000 T0)
#0 0x4d6c3e in __sanitizer::mem_is_zero(char const*, unsigned long) (/exiv2/build/bin/exiv2+0x4d6c3e)
#1 0x4c0f11 in __asan_region_is_poisoned (/exiv2/build/bin/exiv2+0x4c0f11)
#2 0x466332 in printf_common(void*, char const*, __va_list_tag*) (/exiv2/build/bin/exiv2+0x466332)
#3 0x468dbd in __interceptor_vsnprintf (/exiv2/build/bin/exiv2+0x468dbd)
#4 0x7fa19a17fcde in Exiv2::Internal::stringFormat[abi:cxx11](char const*, ...) /exiv2/src/image_int.cpp:48:23
#5 0x7fa199f05fe5 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:415:24
#6 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#7 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#8 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#9 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#10 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#11 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#12 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#13 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#14 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#15 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#16 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#17 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#18 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#19 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#20 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#21 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#22 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#23 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#24 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#25 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#26 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#27 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#28 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#29 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#30 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#31 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#32 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#33 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#34 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#35 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#36 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#37 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#38 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#39 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#40 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#41 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#42 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#43 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#44 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#45 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#46 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#47 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#48 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#49 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#50 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#51 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#52 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#53 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#54 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#55 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#56 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#57 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#58 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#59 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#60 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#61 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#62 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#63 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#64 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#65 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#66 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#67 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#68 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#69 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#70 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#71 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#72 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#73 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#74 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#75 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#76 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#77 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#78 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#79 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#80 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#81 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#82 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#83 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#84 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#85 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#86 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#87 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#88 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#89 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#90 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#91 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#92 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#93 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#94 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#95 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#96 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#97 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#98 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#99 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#100 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#101 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#102 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#103 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#104 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#105 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#106 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#107 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#108 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#109 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#110 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#111 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#112 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#113 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#114 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#115 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#116 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#117 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#118 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#119 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#120 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#121 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#122 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#123 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#124 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#125 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#126 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#127 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#128 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#129 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#130 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#131 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#132 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#133 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#134 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#135 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#136 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#137 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#138 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#139 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#140 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#141 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#142 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#143 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#144 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#145 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#146 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#147 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#148 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#149 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#150 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#151 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#152 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#153 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#154 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#155 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#156 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#157 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#158 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#159 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#160 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#161 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#162 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#163 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#164 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#165 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#166 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#167 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#168 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#169 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#170 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#171 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#172 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#173 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#174 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#175 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#176 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#177 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#178 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#179 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#180 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#181 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#182 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#183 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#184 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#185 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#186 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#187 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#188 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#189 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#190 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#191 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#192 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#193 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#194 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#195 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#196 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#197 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#198 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#199 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#200 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#201 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#202 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#203 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#204 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#205 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#206 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#207 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#208 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#209 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#210 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#211 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#212 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#213 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#214 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#215 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#216 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#217 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#218 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#219 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#220 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#221 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#222 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#223 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#224 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#225 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#226 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#227 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#228 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#229 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#230 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#231 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#232 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#233 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#234 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#235 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#236 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#237 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#238 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#239 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#240 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#241 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#242 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#243 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#244 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#245 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#246 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#247 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#248 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#249 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#250 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#251 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
SUMMARY: AddressSanitizer: stack-overflow (/exiv2/build/bin/exiv2+0x4d6c3e) in __sanitizer::mem_is_zero(char const*, unsigned long)
==621==ABORTING
```
| [bug report] Stack Exhaustion Caused By Exiv2::Image::printIFDStructure function in image.cpp, making Recursive Calls to Itself | https://api.github.com/repos/Exiv2/exiv2/issues/741/comments | 1 | 2019-03-13T08:57:11 | "2019-03-13T09:23:54Z" | https://github.com/Exiv2/exiv2/issues/741 | 420,383,139 | 741 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : [bug report] Stack Exhaustion Caused By Exiv2::Image::printIFDStructure function in image.cpp, making Recursive Calls to Itself
Issue date:
--- start body ---
Hi there,
An issue was discovered in Exiv2::Image::printIFDStructure function in image.cpp, as distributed in master and version 0.27. There is a stack exhaustion problem caused by the in printIFDStructure function making recursive calls to itself.
Here is the POC file. Please use the β./exiv2 -pR $POCβ to reproduce the bug.
[POC.zip](https://github.com/Exiv2/exiv2/files/2960549/POC.zip)
The ASAN dumps the stack trace as follows:
```
ASAN:DEADLYSIGNAL
=================================================================
==621==ERROR: AddressSanitizer: stack-overflow on address 0x7ffcbaecbff8 (pc 0x0000004d6c3f bp 0x0ff43348f15c sp 0x7ffcbaecc000 T0)
#0 0x4d6c3e in __sanitizer::mem_is_zero(char const*, unsigned long) (/exiv2/build/bin/exiv2+0x4d6c3e)
#1 0x4c0f11 in __asan_region_is_poisoned (/exiv2/build/bin/exiv2+0x4c0f11)
#2 0x466332 in printf_common(void*, char const*, __va_list_tag*) (/exiv2/build/bin/exiv2+0x466332)
#3 0x468dbd in __interceptor_vsnprintf (/exiv2/build/bin/exiv2+0x468dbd)
#4 0x7fa19a17fcde in Exiv2::Internal::stringFormat[abi:cxx11](char const*, ...) /exiv2/src/image_int.cpp:48:23
#5 0x7fa199f05fe5 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:415:24
#6 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#7 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#8 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#9 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#10 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#11 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#12 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#13 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#14 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#15 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#16 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#17 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#18 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#19 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#20 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#21 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#22 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#23 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#24 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#25 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#26 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#27 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#28 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#29 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#30 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#31 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#32 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#33 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#34 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#35 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#36 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#37 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#38 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#39 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#40 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#41 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#42 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#43 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#44 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#45 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#46 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#47 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#48 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#49 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#50 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#51 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#52 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#53 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#54 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#55 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#56 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#57 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#58 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#59 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#60 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#61 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#62 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#63 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#64 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#65 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#66 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#67 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#68 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#69 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#70 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#71 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#72 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#73 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#74 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#75 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#76 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#77 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#78 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#79 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#80 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#81 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#82 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#83 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#84 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#85 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#86 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#87 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#88 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#89 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#90 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#91 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#92 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#93 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#94 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#95 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#96 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#97 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#98 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#99 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#100 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#101 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#102 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#103 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#104 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#105 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#106 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#107 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#108 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#109 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#110 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#111 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#112 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#113 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#114 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#115 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#116 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#117 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#118 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#119 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#120 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#121 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#122 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#123 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#124 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#125 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#126 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#127 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#128 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#129 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#130 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#131 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#132 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#133 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#134 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#135 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#136 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#137 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#138 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#139 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#140 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#141 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#142 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#143 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#144 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#145 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#146 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#147 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#148 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#149 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#150 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#151 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#152 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#153 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#154 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#155 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#156 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#157 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#158 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#159 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#160 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#161 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#162 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#163 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#164 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#165 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#166 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#167 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#168 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#169 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#170 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#171 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#172 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#173 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#174 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#175 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#176 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#177 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#178 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#179 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#180 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#181 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#182 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#183 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#184 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#185 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#186 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#187 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#188 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#189 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#190 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#191 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#192 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#193 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#194 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#195 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#196 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#197 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#198 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#199 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#200 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#201 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#202 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#203 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#204 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#205 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#206 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#207 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#208 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#209 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#210 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#211 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#212 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#213 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#214 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#215 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#216 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#217 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#218 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#219 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#220 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#221 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#222 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#223 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#224 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#225 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#226 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#227 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#228 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#229 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#230 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#231 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#232 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#233 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#234 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#235 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#236 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#237 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#238 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#239 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#240 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#241 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#242 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#243 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#244 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#245 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#246 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#247 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#248 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#249 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#250 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
#251 0x7fa199f08468 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::ostream&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) /exiv2/src/image.cpp:446:29
SUMMARY: AddressSanitizer: stack-overflow (/exiv2/build/bin/exiv2+0x4d6c3e) in __sanitizer::mem_is_zero(char const*, unsigned long)
==621==ABORTING
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 45,961 | 207,890 |
[
"Exiv2",
"exiv2"
] | Hi,
I found there is a heap-based buffer overflow in exiv2 0.27.99.0, `Exiv2::Jp2Image::encodeJp2Header(Exiv2::DataBuf const&, Exiv2::DataBuf&)` in `jp2image.cpp:673`, which will lead to DoS or code execution.
Test this [POC](https://drive.google.com/file/d/1EJJKmE8X5q783Fu4UQMwaC_BKsaAgLzf/view?usp=sharing) via
> exiv2 rm /path/to/poc
The ASAN informations is as follows:
### ASAN
```
=================================================================
==28261==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300000ec34 at pc 0x7febe838e935 bp 0x7ffd5b046cc0 sp 0x7ffd5b046468
READ of size 1785737760 at 0x60300000ec34 thread T0
#0 0x7febe838e934 in __asan_memcpy (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x8c934)
#1 0x7febe7eb21a5 in Exiv2::Jp2Image::encodeJp2Header(Exiv2::DataBuf const&, Exiv2::DataBuf&) /home/ubuntu/exiv2/src/jp2image.cpp:673
#2 0x7febe7eb2815 in Exiv2::Jp2Image::doWriteMetadata(Exiv2::BasicIo&) /home/ubuntu/exiv2/src/jp2image.cpp:784
#3 0x7febe7eb1d51 in Exiv2::Jp2Image::writeMetadata() /home/ubuntu/exiv2/src/jp2image.cpp:607
#4 0x469df5 in Action::Erase::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/home/ubuntu/test/debug/exiv2-asan+0x469df5)
#5 0x417c08 in main (/home/ubuntu/test/debug/exiv2-asan+0x417c08)
#6 0x7febe670c82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#7 0x416578 in _start (/home/ubuntu/test/debug/exiv2-asan+0x416578)
0x60300000ec34 is located 0 bytes to the right of 20-byte region [0x60300000ec20,0x60300000ec34)
allocated by thread T0 here:
#0 0x7febe839b6b2 in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x996b2)
#1 0x7febe7edea0c in Exiv2::DataBuf::DataBuf(long) /home/ubuntu/exiv2/src/types.cpp:141
#2 0x7febe7eb26d1 in Exiv2::Jp2Image::doWriteMetadata(Exiv2::BasicIo&) /home/ubuntu/exiv2/src/jp2image.cpp:759
#3 0x7febe7eb1d51 in Exiv2::Jp2Image::writeMetadata() /home/ubuntu/exiv2/src/jp2image.cpp:607
#4 0x469df5 in Action::Erase::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/home/ubuntu/test/debug/exiv2-asan+0x469df5)
#5 0x417c08 in main (/home/ubuntu/test/debug/exiv2-asan+0x417c08)
#6 0x7febe670c82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
SUMMARY: AddressSanitizer: heap-buffer-overflow ??:0 __asan_memcpy
Shadow bytes around the buggy address:
0x0c067fff9d30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff9d40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff9d50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff9d60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff9d70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c067fff9d80: fa fa fa fa 00 00[04]fa fa fa 00 00 00 fa fa fa
0x0c067fff9d90: fd fd fd fa fa fa fd fd fd fa fa fa fd fd fd fa
0x0c067fff9da0: fa fa fd fd fd fa fa fa fd fd fd fa fa fa 00 00
0x0c067fff9db0: 04 fa fa fa 00 00 00 fa fa fa 00 00 00 07 fa fa
0x0c067fff9dc0: 00 00 04 fa fa fa 00 00 00 00 fa fa fd fd fd fa
0x0c067fff9dd0: fa fa fd fd fd fa fa fa fd fd fd fa fa fa fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Heap right redzone: fb
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack partial redzone: f4
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
==28261==ABORTING
```
And the reason seems to be the size of `output.pData_` and `subBox.length` depend on box header of the jp2 image, and exiv2 doesn't do a check before a memcpy.
### e-mail: aobo.wang@chaitin.com
### Discoverer: M4x@Chaitin Security Research Lab
| [bug report] User-controlled heap-based buffer overflow in exiv2 0.27.99.0, Exiv2::Jp2Image::encodeJp2Header(Exiv2::DataBuf const&, Exiv2::DataBuf&) in jp2image.cpp:673 | https://api.github.com/repos/Exiv2/exiv2/issues/739/comments | 2 | 2019-03-10T15:10:06 | "2020-01-30T04:53:31Z" | https://github.com/Exiv2/exiv2/issues/739 | 419,196,153 | 739 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : [bug report] User-controlled heap-based buffer overflow in exiv2 0.27.99.0, Exiv2::Jp2Image::encodeJp2Header(Exiv2::DataBuf const&, Exiv2::DataBuf&) in jp2image.cpp:673
Issue date:
--- start body ---
Hi,
I found there is a heap-based buffer overflow in exiv2 0.27.99.0, `Exiv2::Jp2Image::encodeJp2Header(Exiv2::DataBuf const&, Exiv2::DataBuf&)` in `jp2image.cpp:673`, which will lead to DoS or code execution.
Test this [POC](https://drive.google.com/file/d/1EJJKmE8X5q783Fu4UQMwaC_BKsaAgLzf/view?usp=sharing) via
> exiv2 rm /path/to/poc
The ASAN informations is as follows:
### ASAN
```
=================================================================
==28261==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300000ec34 at pc 0x7febe838e935 bp 0x7ffd5b046cc0 sp 0x7ffd5b046468
READ of size 1785737760 at 0x60300000ec34 thread T0
#0 0x7febe838e934 in __asan_memcpy (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x8c934)
#1 0x7febe7eb21a5 in Exiv2::Jp2Image::encodeJp2Header(Exiv2::DataBuf const&, Exiv2::DataBuf&) /home/ubuntu/exiv2/src/jp2image.cpp:673
#2 0x7febe7eb2815 in Exiv2::Jp2Image::doWriteMetadata(Exiv2::BasicIo&) /home/ubuntu/exiv2/src/jp2image.cpp:784
#3 0x7febe7eb1d51 in Exiv2::Jp2Image::writeMetadata() /home/ubuntu/exiv2/src/jp2image.cpp:607
#4 0x469df5 in Action::Erase::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/home/ubuntu/test/debug/exiv2-asan+0x469df5)
#5 0x417c08 in main (/home/ubuntu/test/debug/exiv2-asan+0x417c08)
#6 0x7febe670c82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
#7 0x416578 in _start (/home/ubuntu/test/debug/exiv2-asan+0x416578)
0x60300000ec34 is located 0 bytes to the right of 20-byte region [0x60300000ec20,0x60300000ec34)
allocated by thread T0 here:
#0 0x7febe839b6b2 in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x996b2)
#1 0x7febe7edea0c in Exiv2::DataBuf::DataBuf(long) /home/ubuntu/exiv2/src/types.cpp:141
#2 0x7febe7eb26d1 in Exiv2::Jp2Image::doWriteMetadata(Exiv2::BasicIo&) /home/ubuntu/exiv2/src/jp2image.cpp:759
#3 0x7febe7eb1d51 in Exiv2::Jp2Image::writeMetadata() /home/ubuntu/exiv2/src/jp2image.cpp:607
#4 0x469df5 in Action::Erase::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (/home/ubuntu/test/debug/exiv2-asan+0x469df5)
#5 0x417c08 in main (/home/ubuntu/test/debug/exiv2-asan+0x417c08)
#6 0x7febe670c82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
SUMMARY: AddressSanitizer: heap-buffer-overflow ??:0 __asan_memcpy
Shadow bytes around the buggy address:
0x0c067fff9d30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff9d40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff9d50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff9d60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c067fff9d70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c067fff9d80: fa fa fa fa 00 00[04]fa fa fa 00 00 00 fa fa fa
0x0c067fff9d90: fd fd fd fa fa fa fd fd fd fa fa fa fd fd fd fa
0x0c067fff9da0: fa fa fd fd fd fa fa fa fd fd fd fa fa fa 00 00
0x0c067fff9db0: 04 fa fa fa 00 00 00 fa fa fa 00 00 00 07 fa fa
0x0c067fff9dc0: 00 00 04 fa fa fa 00 00 00 00 fa fa fd fd fd fa
0x0c067fff9dd0: fa fa fd fd fd fa fa fa fd fd fd fa fa fa fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Heap right redzone: fb
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack partial redzone: f4
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
==28261==ABORTING
```
And the reason seems to be the size of `output.pData_` and `subBox.length` depend on box header of the jp2 image, and exiv2 doesn't do a check before a memcpy.
### e-mail: aobo.wang@chaitin.com
### Discoverer: M4x@Chaitin Security Research Lab
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,485 | 207,891 |
[
"Exiv2",
"exiv2"
] | When building the 0.27.0 source for our service, we try to build once with PIC enabled and another time without it enabled for debug and production builds. The readme mentions setting `BUILD_SHARED_LIBS` to `OFF` to build exiv2lib as static.
However, in [src/CMakeLists.txt](https://github.com/Exiv2/exiv2/blob/master/src/CMakeLists.txt#L131) the flag `POSITION_INDEPENDENT_CODE` is unconditionally set for exiv2lib.
I fixed our build by modifying the source to check the `BUILD_SHARED_LIBS` flag, similar to how it's already done in [xmpsdk/CMakeLists.txt](https://github.com/Exiv2/exiv2/blob/master/xmpsdk/CMakeLists.txt#L54):
```
if (BUILD_SHARED_LIBS)
set_target_properties( exiv2lib_int PROPERTIES
POSITION_INDEPENDENT_CODE ON
COMPILE_DEFINITIONS exiv2lib_STATIC
)
endif()
```
I'm submitting this issue to bring awareness to the problem, in case the change should be made in the source code or if someone else has a similar problem. | CMake unconditionally builds Exiv2 0.27.0 with PIC | https://api.github.com/repos/Exiv2/exiv2/issues/738/comments | 5 | 2019-03-05T17:51:37 | "2019-03-06T14:47:58Z" | https://github.com/Exiv2/exiv2/issues/738 | 417,422,921 | 738 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : CMake unconditionally builds Exiv2 0.27.0 with PIC
Issue date:
--- start body ---
When building the 0.27.0 source for our service, we try to build once with PIC enabled and another time without it enabled for debug and production builds. The readme mentions setting `BUILD_SHARED_LIBS` to `OFF` to build exiv2lib as static.
However, in [src/CMakeLists.txt](https://github.com/Exiv2/exiv2/blob/master/src/CMakeLists.txt#L131) the flag `POSITION_INDEPENDENT_CODE` is unconditionally set for exiv2lib.
I fixed our build by modifying the source to check the `BUILD_SHARED_LIBS` flag, similar to how it's already done in [xmpsdk/CMakeLists.txt](https://github.com/Exiv2/exiv2/blob/master/xmpsdk/CMakeLists.txt#L54):
```
if (BUILD_SHARED_LIBS)
set_target_properties( exiv2lib_int PROPERTIES
POSITION_INDEPENDENT_CODE ON
COMPILE_DEFINITIONS exiv2lib_STATIC
)
endif()
```
I'm submitting this issue to bring awareness to the problem, in case the change should be made in the source code or if someone else has a similar problem.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,191 | 207,892 |
[
"Exiv2",
"exiv2"
] | ```console
$ wget http://www.exiv2.org/
--2019-03-04 09:22:21-- http://www.exiv2.org/
Resolving www.exiv2.org (www.exiv2.org)... failed: Name or service not known.
wget: unable to resolve host address βwww.exiv2.orgβ
``` | www.exiv2.org is gone | https://api.github.com/repos/Exiv2/exiv2/issues/736/comments | 6 | 2019-03-04T08:24:20 | "2019-03-06T11:32:09Z" | https://github.com/Exiv2/exiv2/issues/736 | 416,683,299 | 736 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : www.exiv2.org is gone
Issue date:
--- start body ---
```console
$ wget http://www.exiv2.org/
--2019-03-04 09:22:21-- http://www.exiv2.org/
Resolving www.exiv2.org (www.exiv2.org)... failed: Name or service not known.
wget: unable to resolve host address βwww.exiv2.orgβ
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 408 | 207,893 |
[
"Exiv2",
"exiv2"
] | Recent days,I was working on a project about extract GPS imformation from a photo. But I met a unexpected problem when I start it. The code is:
Unhandled exception at 0x00007FF9CD0EA388 in GUI_GPS.exe: Microsoft C++ exception: Exiv2::BasicError<char> at memory location 0x000000F808CF93E0.
And after some attempt to solve this problem, the exception code turned into:
0x00007FF98AD4B916 (exiv2.dll) (GUI_GPS.exe δΈ)Unhandled exception: 0xC0000005: conflict occured when read 0xFFFFFFFFFFFFFFFF .
What's wrong with my code, please help me.I work on VisualStudio2013 with EXIV2 version 0.27.0, and my code is below:
``` C++
#include <iostream>
#include <exiv2\exiv2.hpp>
using namespace std;
using namespace Exiv2;
void main()
{
//Exception here!
//static unique_ptr<Exiv2::Image> image = ImageFactory::open("DJI_0010.JPG");
//I change it into:
decltype(auto) image = ImageFactory::open("DJI_0010.JPG");
//still exception
if (image.get() == 0)
{
cout << "read file error." << endl;
}
image->readMetadata();
ExifData ed = image->exifData();
if (ed.empty())
{
cout << "ed empty error!" << endl;
}
else
{
cout << ed["Exif.GPSInfo.GPSLatitude"] << endl;
}
}
```
I don't know how to upload a picture, so if you need more imformation, you can contact me. I come from China, and I am a student who is studying for a master's degree.
I eagerly need you help, thank you very much! | Unhandled exception when use Exiv2::ImageFactory::open() | https://api.github.com/repos/Exiv2/exiv2/issues/735/comments | 7 | 2019-03-04T07:56:18 | "2019-05-19T07:41:15Z" | https://github.com/Exiv2/exiv2/issues/735 | 416,674,524 | 735 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Unhandled exception when use Exiv2::ImageFactory::open()
Issue date:
--- start body ---
Recent days,I was working on a project about extract GPS imformation from a photo. But I met a unexpected problem when I start it. The code is:
Unhandled exception at 0x00007FF9CD0EA388 in GUI_GPS.exe: Microsoft C++ exception: Exiv2::BasicError<char> at memory location 0x000000F808CF93E0.
And after some attempt to solve this problem, the exception code turned into:
0x00007FF98AD4B916 (exiv2.dll) (GUI_GPS.exe δΈ)Unhandled exception: 0xC0000005: conflict occured when read 0xFFFFFFFFFFFFFFFF .
What's wrong with my code, please help me.I work on VisualStudio2013 with EXIV2 version 0.27.0, and my code is below:
``` C++
#include <iostream>
#include <exiv2\exiv2.hpp>
using namespace std;
using namespace Exiv2;
void main()
{
//Exception here!
//static unique_ptr<Exiv2::Image> image = ImageFactory::open("DJI_0010.JPG");
//I change it into:
decltype(auto) image = ImageFactory::open("DJI_0010.JPG");
//still exception
if (image.get() == 0)
{
cout << "read file error." << endl;
}
image->readMetadata();
ExifData ed = image->exifData();
if (ed.empty())
{
cout << "ed empty error!" << endl;
}
else
{
cout << ed["Exif.GPSInfo.GPSLatitude"] << endl;
}
}
```
I don't know how to upload a picture, so if you need more imformation, you can contact me. I come from China, and I am a student who is studying for a master's degree.
I eagerly need you help, thank you very much!
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,679 | 207,894 |
[
"Exiv2",
"exiv2"
] | There are some parts of the code relying in `regex.h` which could be modernised to use the regular expressions library available since c++11:
We would need to convert these two files
- `src/exiv2.cpp`
- `src/version.cpp`
And remove any instance of the definition `EXV_HAVE_REGEX_H` | Use c++11 regex | https://api.github.com/repos/Exiv2/exiv2/issues/729/comments | 0 | 2019-03-03T11:00:40 | "2019-04-27T10:42:24Z" | https://github.com/Exiv2/exiv2/issues/729 | 416,502,481 | 729 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Use c++11 regex
Issue date:
--- start body ---
There are some parts of the code relying in `regex.h` which could be modernised to use the regular expressions library available since c++11:
We would need to convert these two files
- `src/exiv2.cpp`
- `src/version.cpp`
And remove any instance of the definition `EXV_HAVE_REGEX_H`
--- end body ---
comments :
--- start comments ---
--- end comments --- | 465 | 207,895 |
[
"Exiv2",
"exiv2"
] | I use a Lens TAMRON 100-400mm F/4.5-6.3 Di VC USD A035.
It is recognized in Darktable as Canon EF 300mm f/2 8L IS II USM and it is wrong.
Information in RAW is correct as Canon Digital Photo Professional software recognizes it as TAMRON 100-400mm F/4.5-6.3 Di VC USD A035. | Darktable2.6:lens Tamron 100-400mm not recognized=>Canon300mm instead | https://api.github.com/repos/Exiv2/exiv2/issues/719/comments | 7 | 2019-02-27T11:03:32 | "2019-02-27T16:25:47Z" | https://github.com/Exiv2/exiv2/issues/719 | 415,067,323 | 719 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Darktable2.6:lens Tamron 100-400mm not recognized=>Canon300mm instead
Issue date:
--- start body ---
I use a Lens TAMRON 100-400mm F/4.5-6.3 Di VC USD A035.
It is recognized in Darktable as Canon EF 300mm f/2 8L IS II USM and it is wrong.
Information in RAW is correct as Canon Digital Photo Professional software recognizes it as TAMRON 100-400mm F/4.5-6.3 Di VC USD A035.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 504 | 207,896 |
[
"Exiv2",
"exiv2"
] | This is probably related to #711 or #712, uncontrolled recursion. It was reported downstream in FreeBSD against KDE's Baloo file indexer as https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234830 , but it can be reproduced with the exiv2 command-line tool from version 0.26. I have not tried 0.27 yet, since that's not packaged (yet) for FreeBSD.
The attached file, tu_logo.tiff, will hang exiv2 (and if you download it, onto a machine with file-indexing enabled, you've got a fair chance of it hanging once it reaches that new file).
Backtrace with gdb while hanging looks like this:
```
#0 io_print (iop=<optimized out>, ptr=<optimized out>, len=<optimized out>,
locale=<optimized out>)
at /mnt/src/freebsd-12/lib/libc/stdio/printfcommon.h:93
#1 __vfprintf (fp=<optimized out>,
locale=0x8008e34e8 <__xlocale_global_locale>,
fmt0=0x8002fd1bf " |%9u |%10u | ", ap=<optimized out>)
at /mnt/src/freebsd-12/lib/libc/stdio/vfprintf.c:497
#2 0x00000008007e0d7f in vsnprintf_l (str=<optimized out>, n=2,
locale=0x8008e34e8 <__xlocale_global_locale>, fmt=<optimized out>,
ap=<optimized out>) at /mnt/src/freebsd-12/lib/libc/stdio/vsnprintf.c:80
#3 vsnprintf (
str=0x800bc3000 "18613369 | 0x011c PlanarConfiguration | SHORT | 1 | 190 | ", n=148,
fmt=0x8002fd1a8 "%8u | %#06x %-25s |%10s |%9u |%10u | ", ap=0x7fffffffdd30)
at /mnt/src/freebsd-12/lib/libc/stdio/vsnprintf.c:89
#4 0x00000008004dcbb6 in Exiv2::Internal::stringFormat(char const*, ...) ()
from /usr/local/lib/libexiv2.so.26
#5 0x00000008004dbce7 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::__1::basic_ostream<char, std::__1::char_traits<char> >&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) () from /usr/local/lib/libexiv2.so.26
#6 0x00000008004dce00 in Exiv2::Image::printTiffStructure(Exiv2::BasicIo&, std::__1::basic_ostream<char, std::__1::char_traits<char> >&, Exiv2::PrintStructureOption, int, unsigned long) () from /usr/local/lib/libexiv2.so.26
#7 0x000000080055c0f6 in Exiv2::TiffImage::readMetadata() ()
from /usr/local/lib/libexiv2.so.26
#8 0x0000000000221b33 in ?? ()
#9 0x000000000022198b in ?? ()
#10 0x0000000000215668 in main ()
```
Here's `tiffdump` output:
```
[adridg@beastie /tmp]$ tiffdump tu_logo.tiff
tu_logo.tiff:
Magic: 0x4d4d <big-endian> Version: 0x2a <ClassicTIFF>
Directory 0: offset 8 (0x8) next 18612227 (0x11c0003)
OldSubFileType (255) SHORT (3) 1<1>
ImageWidth (256) SHORT (3) 1<348>
ImageLength (257) SHORT (3) 1<240>
BitsPerSample (258) SHORT (3) 1<4>
Compression (259) SHORT (3) 1<1>
Photometric (262) SHORT (3) 1<0>
StripOffsets (273) LONG (4) 1<204>
Orientation (274) SHORT (3) 1<1>
SamplesPerPixel (277) SHORT (3) 1<1>
RowsPerStrip (278) LONG (4) 1<240>
StripByteCounts (279) LONG (4) 1<41760>
XResolution (282) RATIONAL (5) 1<300>
YResolution (283) RATIONAL (5) 1<300>
tu_logo.tiff: Error while reading directory count.
```
The file is **somewhat** broken, since the *next* TIFF directory structure is at offset 0x11c0003 which is way past the end of the file. | 0.26: Hang in Exiv2::Image::printIFDStructure | https://api.github.com/repos/Exiv2/exiv2/issues/715/comments | 6 | 2019-02-24T21:26:36 | "2019-07-25T17:31:13Z" | https://github.com/Exiv2/exiv2/issues/715 | 413,870,325 | 715 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : 0.26: Hang in Exiv2::Image::printIFDStructure
Issue date:
--- start body ---
This is probably related to #711 or #712, uncontrolled recursion. It was reported downstream in FreeBSD against KDE's Baloo file indexer as https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234830 , but it can be reproduced with the exiv2 command-line tool from version 0.26. I have not tried 0.27 yet, since that's not packaged (yet) for FreeBSD.
The attached file, tu_logo.tiff, will hang exiv2 (and if you download it, onto a machine with file-indexing enabled, you've got a fair chance of it hanging once it reaches that new file).
Backtrace with gdb while hanging looks like this:
```
#0 io_print (iop=<optimized out>, ptr=<optimized out>, len=<optimized out>,
locale=<optimized out>)
at /mnt/src/freebsd-12/lib/libc/stdio/printfcommon.h:93
#1 __vfprintf (fp=<optimized out>,
locale=0x8008e34e8 <__xlocale_global_locale>,
fmt0=0x8002fd1bf " |%9u |%10u | ", ap=<optimized out>)
at /mnt/src/freebsd-12/lib/libc/stdio/vfprintf.c:497
#2 0x00000008007e0d7f in vsnprintf_l (str=<optimized out>, n=2,
locale=0x8008e34e8 <__xlocale_global_locale>, fmt=<optimized out>,
ap=<optimized out>) at /mnt/src/freebsd-12/lib/libc/stdio/vsnprintf.c:80
#3 vsnprintf (
str=0x800bc3000 "18613369 | 0x011c PlanarConfiguration | SHORT | 1 | 190 | ", n=148,
fmt=0x8002fd1a8 "%8u | %#06x %-25s |%10s |%9u |%10u | ", ap=0x7fffffffdd30)
at /mnt/src/freebsd-12/lib/libc/stdio/vsnprintf.c:89
#4 0x00000008004dcbb6 in Exiv2::Internal::stringFormat(char const*, ...) ()
from /usr/local/lib/libexiv2.so.26
#5 0x00000008004dbce7 in Exiv2::Image::printIFDStructure(Exiv2::BasicIo&, std::__1::basic_ostream<char, std::__1::char_traits<char> >&, Exiv2::PrintStructureOption, unsigned int, bool, char, int) () from /usr/local/lib/libexiv2.so.26
#6 0x00000008004dce00 in Exiv2::Image::printTiffStructure(Exiv2::BasicIo&, std::__1::basic_ostream<char, std::__1::char_traits<char> >&, Exiv2::PrintStructureOption, int, unsigned long) () from /usr/local/lib/libexiv2.so.26
#7 0x000000080055c0f6 in Exiv2::TiffImage::readMetadata() ()
from /usr/local/lib/libexiv2.so.26
#8 0x0000000000221b33 in ?? ()
#9 0x000000000022198b in ?? ()
#10 0x0000000000215668 in main ()
```
Here's `tiffdump` output:
```
[adridg@beastie /tmp]$ tiffdump tu_logo.tiff
tu_logo.tiff:
Magic: 0x4d4d <big-endian> Version: 0x2a <ClassicTIFF>
Directory 0: offset 8 (0x8) next 18612227 (0x11c0003)
OldSubFileType (255) SHORT (3) 1<1>
ImageWidth (256) SHORT (3) 1<348>
ImageLength (257) SHORT (3) 1<240>
BitsPerSample (258) SHORT (3) 1<4>
Compression (259) SHORT (3) 1<1>
Photometric (262) SHORT (3) 1<0>
StripOffsets (273) LONG (4) 1<204>
Orientation (274) SHORT (3) 1<1>
SamplesPerPixel (277) SHORT (3) 1<1>
RowsPerStrip (278) LONG (4) 1<240>
StripByteCounts (279) LONG (4) 1<41760>
XResolution (282) RATIONAL (5) 1<300>
YResolution (283) RATIONAL (5) 1<300>
tu_logo.tiff: Error while reading directory count.
```
The file is **somewhat** broken, since the *next* TIFF directory structure is at offset 0x11c0003 which is way past the end of the file.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 3,339 | 207,897 |
[
"Exiv2",
"exiv2"
] | Exiv2 v0.26 brought support for MinGW/msys1.0/32. The test suite included code to build/link a simple command-line program with qmake. This took a considerable effort which I won't describe now, however I concluded that we should deprecate this in v0.27.
I was encouraged to adopt MinGW/msys2 for v0.27 by _**darktable**_. We successfully build and run the test suite with Exiv2 v0.27 and this is documented in README.md
However, we received the following report in May 2018 that MinGW/Qt wasn't working and I concluded it was to do with C++11 which _at the time_ we expected to deliver with Exiv2 v0.27.0 http://dev.exiv2.org/boards/3/topics/3139?r=3148#message-3148
I have enjoyed an email discussion with a user about this. I'm unable to get MinGW/Qt/Exiv2 v0.27 to compile and/or link. I have _**NOT **_ looked at Qt+Exiv2 on MacOS-X or Linux or MSVC.
When building application with QtCreator (and/or qmake) using Qt 5.12 (64 bit) the error message is:
```
.../exiv2-test/main.cpp:51: undefined reference to `__imp__ZN5Exiv213versionStringB5cxx11Ev'
```
The compiler is looking the c++11 version of `Exiv2::versionString' which isn't in our C++98 library.
So, I've backed up to earlier editions of Qt which build 32 bit and I believe build for C++98. I tried to link our 32 bit build with Qt (5.1) It doesnβt link. The error is similar to the 64 bit errors (concerning versionString etc).
So, I tried to build exiv2 with the toolchain in c:\Qt\Tools\mumble_jumble\bin:
32bits: mumble_jumble=mingw48_32 (Qt 5.1)
64bits: mumble_jumble=mingw73_64 (Qt 5.12.1)
Exiv2 will not compile with the headers provided on the Qt/toolchain.
32bits: canβt remember. Goes crazy.
64bits: error: 'sched_yield() was not declared in this scopeβ
This has something to do with the threads. Exiv2 uses pthreads, and I thought Qt also uses them.
My feeling is that getting this to work will take a lot of effort. There are lots of different versions of Qt (5.1 through 5.12) with different tool-chains. (4.8, 4.9, 7.3).
Because I have hitherto used (and liked) Qt, I would like to see Qt/Exiv2 working together. And, I believe it will work. The challenge is to compile and link the code and don't believe the code requires change. However, last year's diagnosis _**requires C++11**_ may be correct and Exiv2 v0.27 will never work with Qt.
I believe @cgilles cross compiles for MinGW to distribute DigiKam on Windows and may be able to offer suggestions.
To make the v0.27.1 schedule on 2019-03-31, I want to avoid spending more time on Qt (on any platform). I have already spent about 8 hours investigating on behalf of the user who raised this matter. | Exiv2 and Qt | https://api.github.com/repos/Exiv2/exiv2/issues/714/comments | 9 | 2019-02-24T19:23:31 | "2019-03-04T18:45:17Z" | https://github.com/Exiv2/exiv2/issues/714 | 413,857,509 | 714 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Exiv2 and Qt
Issue date:
--- start body ---
Exiv2 v0.26 brought support for MinGW/msys1.0/32. The test suite included code to build/link a simple command-line program with qmake. This took a considerable effort which I won't describe now, however I concluded that we should deprecate this in v0.27.
I was encouraged to adopt MinGW/msys2 for v0.27 by _**darktable**_. We successfully build and run the test suite with Exiv2 v0.27 and this is documented in README.md
However, we received the following report in May 2018 that MinGW/Qt wasn't working and I concluded it was to do with C++11 which _at the time_ we expected to deliver with Exiv2 v0.27.0 http://dev.exiv2.org/boards/3/topics/3139?r=3148#message-3148
I have enjoyed an email discussion with a user about this. I'm unable to get MinGW/Qt/Exiv2 v0.27 to compile and/or link. I have _**NOT **_ looked at Qt+Exiv2 on MacOS-X or Linux or MSVC.
When building application with QtCreator (and/or qmake) using Qt 5.12 (64 bit) the error message is:
```
.../exiv2-test/main.cpp:51: undefined reference to `__imp__ZN5Exiv213versionStringB5cxx11Ev'
```
The compiler is looking the c++11 version of `Exiv2::versionString' which isn't in our C++98 library.
So, I've backed up to earlier editions of Qt which build 32 bit and I believe build for C++98. I tried to link our 32 bit build with Qt (5.1) It doesnβt link. The error is similar to the 64 bit errors (concerning versionString etc).
So, I tried to build exiv2 with the toolchain in c:\Qt\Tools\mumble_jumble\bin:
32bits: mumble_jumble=mingw48_32 (Qt 5.1)
64bits: mumble_jumble=mingw73_64 (Qt 5.12.1)
Exiv2 will not compile with the headers provided on the Qt/toolchain.
32bits: canβt remember. Goes crazy.
64bits: error: 'sched_yield() was not declared in this scopeβ
This has something to do with the threads. Exiv2 uses pthreads, and I thought Qt also uses them.
My feeling is that getting this to work will take a lot of effort. There are lots of different versions of Qt (5.1 through 5.12) with different tool-chains. (4.8, 4.9, 7.3).
Because I have hitherto used (and liked) Qt, I would like to see Qt/Exiv2 working together. And, I believe it will work. The challenge is to compile and link the code and don't believe the code requires change. However, last year's diagnosis _**requires C++11**_ may be correct and Exiv2 v0.27 will never work with Qt.
I believe @cgilles cross compiles for MinGW to distribute DigiKam on Windows and may be able to offer suggestions.
To make the v0.27.1 schedule on 2019-03-31, I want to avoid spending more time on Qt (on any platform). I have already spent about 8 hours investigating on behalf of the user who raised this matter.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,872 | 207,898 |
[
"Exiv2",
"exiv2"
] | **Description** - During our research ,we Observed that an infinite uncontrolled recursion loop, at function `Exiv2::(anonymous namespace)::BigTiffImage::printIFD( `) located in `bigtiffimage.cpp` . It allows an attacker to cause Denial of Service or possibly have unspecified other impact.
**Command** - exiv2 -b -u -k -p R pr $POC
**POC** - [REPRODUCER](https://github.com/SegfaultMasters/covering360/blob/master/Exiv2/h2?raw=true)
**Debug** -
**GDB** -
```
Program received signal SIGINT, Interrupt.
0x00007ffff62276a9 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_append(char const*, unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
[ Legend: Modified register | Code | Heap | Stack | String ]
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ registers ββββ
$rax : 0x0000620001c10a74 β 0xbebebebebe002020
$rbx : 0x00007fffffccfd80 β 0x0000620001c10080 β 0x2020202020202020 (" "?)
$rcx : 0x0
$rdx : 0x2
$rsp : 0x00007fffffccfa80 β 0x00007fffffccfad0 β 0x00007fffffccfeb0 β 0x00007fffffcd0290 β 0x00007fffffcd0670 β 0x00007fffffcd0a50 β 0x00007fffffcd0e30 β 0x00007fffffcd1210
$rbp : 0x9f6
$rsi : 0x00007ffff69f2020 β 0x0000000000000000
$rdi : 0x0000620001c10080 β 0x2020202020202020 (" "?)
$rip : 0x00007ffff62276a9 β <std::__cxx11::basic_string<char,+0> add rsp, 0x8
$r8 : 0x00007fffffccfd90 β 0x0000000000000f00
$r9 : 0x9f4
$r10 : 0x00007fffffccf1e0 β 0x00007ffff6f036b3 β <operator+0> mov r15, rax
$r11 : 0x00007fffffccf1e0 β 0x00007ffff6f036b3 β <operator+0> mov r15, rax
$r12 : 0x00000ffffff99f84 β 0x0000000000000000
$r13 : 0x00007fffffccfc20 β 0x0000000041b58ab3
$r14 : 0x00007ffff69600a0 β 0x006e776f6e6b6e75 ("unknown"?)
$r15 : 0x00007fffffffdb20 β 0x0000000041b58ab3
$eflags: [carry PARITY adjust ZERO sign trap INTERRUPT direction overflow resume virtualx86 identification]
$cs: 0x0033 $ss: 0x002b $ds: 0x0000 $es: 0x0000 $fs: 0x0000 $gs: 0x0000
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ stack ββββ
0x00007fffffccfa80β+0x0000: 0x00007fffffccfad0 β 0x00007fffffccfeb0 β 0x00007fffffcd0290 β 0x00007fffffcd0670 β 0x00007fffffcd0a50 β 0x00007fffffcd0e30 β 0x00007fffffcd1210 β $rsp
0x00007fffffccfa88β+0x0008: 0x00007fffffccfe80 β 0x00007ffff69600a0 β 0x006e776f6e6b6e75 ("unknown"?)
0x00007fffffccfa90β+0x0010: 0x00007fffffccfad0 β 0x00007fffffccfeb0 β 0x00007fffffcd0290 β 0x00007fffffcd0670 β 0x00007fffffcd0a50 β 0x00007fffffcd0e30 β 0x00007fffffcd1210
0x00007fffffccfa98β+0x0018: 0x00007ffff681f34b β <Exiv2::Internal::indent[abi:cxx11](int)+86> jmp 0x7ffff681f326 <Exiv2::Internal::indent[abi:cxx11](int)+49>
0x00007fffffccfaa0β+0x0020: 0x00000825fff99f84 β 0x0000000000000000
0x00007fffffccfaa8β+0x0028: 0x00007fffffccfd80 β 0x0000620001c10080 β 0x2020202020202020
0x00007fffffccfab0β+0x0030: 0x00007ffff69600a0 β 0x006e776f6e6b6e75 ("unknown"?)
0x00007fffffccfab8β+0x0038: 0x7ebffb45ba0eea00
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ code:x86:64 ββββ
0x7ffff622769e <std::__cxx11::basic_string<char,+0> mov rdi, QWORD PTR [rbx]
0x7ffff62276a1 <std::__cxx11::basic_string<char,+0> mov QWORD PTR [rbx+0x8], rbp
0x7ffff62276a5 <std::__cxx11::basic_string<char,+0> mov BYTE PTR [rdi+rbp*1], 0x0
β 0x7ffff62276a9 <std::__cxx11::basic_string<char,+0> add rsp, 0x8
0x7ffff62276ad <std::__cxx11::basic_string<char,+0> mov rax, rbx
0x7ffff62276b0 <std::__cxx11::basic_string<char,+0> pop rbx
0x7ffff62276b1 <std::__cxx11::basic_string<char,+0> pop rbp
0x7ffff62276b2 <std::__cxx11::basic_string<char,+0> ret
0x7ffff62276b3 <std::__cxx11::basic_string<char,+0> nop DWORD PTR [rax+rax*1+0x0]
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ threads ββββ
[#0] Id 1, Name: "exiv2", stopped, reason: SIGINT
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ trace ββββ
[#0] 0x7ffff62276a9 β std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_append(char const*, unsigned long)()
[#1] 0x7ffff681f34b β Exiv2::Internal::indent[abi:cxx11](int)(d=0x825)
[#2] 0x7ffff66eb692 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd20)
[#3] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1f)
[#4] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1e)
[#5] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1d)
[#6] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1c)
[#7] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1b)
[#8] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1a)
[#9] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd19)
``` | Uncontrolled recursion loop in Exiv2::(anonymous namespace)::BigTiffImage::printIFD( ) | https://api.github.com/repos/Exiv2/exiv2/issues/712/comments | 4 | 2019-02-21T11:57:14 | "2020-01-24T16:01:01Z" | https://github.com/Exiv2/exiv2/issues/712 | 412,888,776 | 712 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Uncontrolled recursion loop in Exiv2::(anonymous namespace)::BigTiffImage::printIFD( )
Issue date:
--- start body ---
**Description** - During our research ,we Observed that an infinite uncontrolled recursion loop, at function `Exiv2::(anonymous namespace)::BigTiffImage::printIFD( `) located in `bigtiffimage.cpp` . It allows an attacker to cause Denial of Service or possibly have unspecified other impact.
**Command** - exiv2 -b -u -k -p R pr $POC
**POC** - [REPRODUCER](https://github.com/SegfaultMasters/covering360/blob/master/Exiv2/h2?raw=true)
**Debug** -
**GDB** -
```
Program received signal SIGINT, Interrupt.
0x00007ffff62276a9 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_append(char const*, unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
[ Legend: Modified register | Code | Heap | Stack | String ]
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ registers ββββ
$rax : 0x0000620001c10a74 β 0xbebebebebe002020
$rbx : 0x00007fffffccfd80 β 0x0000620001c10080 β 0x2020202020202020 (" "?)
$rcx : 0x0
$rdx : 0x2
$rsp : 0x00007fffffccfa80 β 0x00007fffffccfad0 β 0x00007fffffccfeb0 β 0x00007fffffcd0290 β 0x00007fffffcd0670 β 0x00007fffffcd0a50 β 0x00007fffffcd0e30 β 0x00007fffffcd1210
$rbp : 0x9f6
$rsi : 0x00007ffff69f2020 β 0x0000000000000000
$rdi : 0x0000620001c10080 β 0x2020202020202020 (" "?)
$rip : 0x00007ffff62276a9 β <std::__cxx11::basic_string<char,+0> add rsp, 0x8
$r8 : 0x00007fffffccfd90 β 0x0000000000000f00
$r9 : 0x9f4
$r10 : 0x00007fffffccf1e0 β 0x00007ffff6f036b3 β <operator+0> mov r15, rax
$r11 : 0x00007fffffccf1e0 β 0x00007ffff6f036b3 β <operator+0> mov r15, rax
$r12 : 0x00000ffffff99f84 β 0x0000000000000000
$r13 : 0x00007fffffccfc20 β 0x0000000041b58ab3
$r14 : 0x00007ffff69600a0 β 0x006e776f6e6b6e75 ("unknown"?)
$r15 : 0x00007fffffffdb20 β 0x0000000041b58ab3
$eflags: [carry PARITY adjust ZERO sign trap INTERRUPT direction overflow resume virtualx86 identification]
$cs: 0x0033 $ss: 0x002b $ds: 0x0000 $es: 0x0000 $fs: 0x0000 $gs: 0x0000
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ stack ββββ
0x00007fffffccfa80β+0x0000: 0x00007fffffccfad0 β 0x00007fffffccfeb0 β 0x00007fffffcd0290 β 0x00007fffffcd0670 β 0x00007fffffcd0a50 β 0x00007fffffcd0e30 β 0x00007fffffcd1210 β $rsp
0x00007fffffccfa88β+0x0008: 0x00007fffffccfe80 β 0x00007ffff69600a0 β 0x006e776f6e6b6e75 ("unknown"?)
0x00007fffffccfa90β+0x0010: 0x00007fffffccfad0 β 0x00007fffffccfeb0 β 0x00007fffffcd0290 β 0x00007fffffcd0670 β 0x00007fffffcd0a50 β 0x00007fffffcd0e30 β 0x00007fffffcd1210
0x00007fffffccfa98β+0x0018: 0x00007ffff681f34b β <Exiv2::Internal::indent[abi:cxx11](int)+86> jmp 0x7ffff681f326 <Exiv2::Internal::indent[abi:cxx11](int)+49>
0x00007fffffccfaa0β+0x0020: 0x00000825fff99f84 β 0x0000000000000000
0x00007fffffccfaa8β+0x0028: 0x00007fffffccfd80 β 0x0000620001c10080 β 0x2020202020202020
0x00007fffffccfab0β+0x0030: 0x00007ffff69600a0 β 0x006e776f6e6b6e75 ("unknown"?)
0x00007fffffccfab8β+0x0038: 0x7ebffb45ba0eea00
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ code:x86:64 ββββ
0x7ffff622769e <std::__cxx11::basic_string<char,+0> mov rdi, QWORD PTR [rbx]
0x7ffff62276a1 <std::__cxx11::basic_string<char,+0> mov QWORD PTR [rbx+0x8], rbp
0x7ffff62276a5 <std::__cxx11::basic_string<char,+0> mov BYTE PTR [rdi+rbp*1], 0x0
β 0x7ffff62276a9 <std::__cxx11::basic_string<char,+0> add rsp, 0x8
0x7ffff62276ad <std::__cxx11::basic_string<char,+0> mov rax, rbx
0x7ffff62276b0 <std::__cxx11::basic_string<char,+0> pop rbx
0x7ffff62276b1 <std::__cxx11::basic_string<char,+0> pop rbp
0x7ffff62276b2 <std::__cxx11::basic_string<char,+0> ret
0x7ffff62276b3 <std::__cxx11::basic_string<char,+0> nop DWORD PTR [rax+rax*1+0x0]
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ threads ββββ
[#0] Id 1, Name: "exiv2", stopped, reason: SIGINT
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ trace ββββ
[#0] 0x7ffff62276a9 β std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_append(char const*, unsigned long)()
[#1] 0x7ffff681f34b β Exiv2::Internal::indent[abi:cxx11](int)(d=0x825)
[#2] 0x7ffff66eb692 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd20)
[#3] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1f)
[#4] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1e)
[#5] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1d)
[#6] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1c)
[#7] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1b)
[#8] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd1a)
[#9] 0x7ffff66ebe88 β Exiv2::(anonymous namespace)::BigTiffImage::printIFD(this=0x61300000de80, out=@0x672ac0, option=Exiv2::kpsRecursive, dir_offset=0x80, depth=0xd19)
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 6,582 | 207,899 |
[
"Exiv2",
"exiv2"
] | **Description** - During our research ,we Observed that an infinite uncontrolled recursion loop, at function Exiv2::Image::printTiffStructure at file image.cpp . It allows an attacker to cause Denial of Service or possibly have unspecified other impact.
**Command** - `exiv2 -b -u -k -p R pr $POC`
**POC** - [REPRODUCER](https://github.com/SegfaultMasters/covering360/blob/master/Exiv2/h1?raw=true)
**Debug** -
**GDB** -
```
84 ../sysdeps/unix/syscall-template.S: No such file or directory.
[ Legend: Modified register | Code | Heap | Stack | String ]
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ registers ββββ
$rax : 0x49
$rbx : 0x4a
$rcx : 0x00007ffff5c172c0 β <__write_nocancel+7> cmp rax, 0xfffffffffffff001
$rdx : 0x4a
$rsp : 0x00007fffffffd338 β 0x00007ffff5b98bff β <_IO_file_write+143> test rax, rax
$rbp : 0x0000619000001480 β "STRUCTURE OF TIFF FILE (II): id:000000,src:000553+[...]"
$rsi : 0x0000619000001480 β "STRUCTURE OF TIFF FILE (II): id:000000,src:000553+[...]"
$rdi : 0x1
$rip : 0x00007ffff5c172c0 β <__write_nocancel+7> cmp rax, 0xfffffffffffff001
$r8 : 0x00007ffff5ee6780 β 0x0000000100000001 β 0x0000000000000000
$r9 : 0x00007ffff7fd1780 β 0x00007ffff7fd1780 β [loop detected]
$r10 : 0x733a706f2c333132 ("213,op:s"?)
$r11 : 0x246
$r12 : 0x4a
$r13 : 0x1
$r14 : 0x00007ffff5ee5620 β 0x00000000fbad2a84 β 0x0000000000000000
$r15 : 0x00007fffffffdb20 β 0x0000000041b58ab3
$eflags: [carry PARITY adjust ZERO sign trap INTERRUPT direction overflow resume virtualx86 identification]
$cs: 0x0033 $ss: 0x002b $ds: 0x0000 $es: 0x0000 $fs: 0x0000 $gs: 0x0000
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ stack ββββ
0x00007fffffffd338β+0x0000: 0x00007ffff5b98bff β <_IO_file_write+143> test rax, rax β $rsp
0x00007fffffffd340β+0x0008: 0x00007ffff5ee5620 β 0x00000000fbad2a84 β 0x0000000000000000
0x00007fffffffd348β+0x0010: 0x000000000000004a ("J"?)
0x00007fffffffd350β+0x0018: 0x0000619000001480 β "STRUCTURE OF TIFF FILE (II): id:000000,src:000553+[...]"
0x00007fffffffd358β+0x0020: 0x00007fffffffd530 β 0x0000000041b58ab3
0x00007fffffffd360β+0x0028: 0x00007fffffffd960 β 0x0000000041b58ab3
0x00007fffffffd368β+0x0030: 0x00007ffff5b9a409 β <_IO_do_write+121> mov r13, rax
0x00007fffffffd370β+0x0038: 0x00007fffffffdb20 β 0x0000000041b58ab3
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ code:x86:64 ββββ
0x7ffff5c172b2 <write+2> mov DWORD PTR [rbp*1+0x10750000], esp
0x7ffff5c172b9 <__write_nocancel+0> mov eax, 0x1
0x7ffff5c172be <__write_nocancel+5> syscall
β 0x7ffff5c172c0 <__write_nocancel+7> cmp rax, 0xfffffffffffff001
0x7ffff5c172c6 <__write_nocancel+13> jae 0x7ffff5c172f9 <write+73>
0x7ffff5c172c8 <__write_nocancel+15> ret
0x7ffff5c172c9 <write+25> sub rsp, 0x8
0x7ffff5c172cd <write+29> call 0x7ffff5c350d0 <__libc_enable_asynccancel>
0x7ffff5c172d2 <write+34> mov QWORD PTR [rsp], rax
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ threads ββββ
[#0] Id 1, Name: "exiv2", stopped, reason: SIGINT
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ trace ββββ
[#0] 0x7ffff5c172c0 β __write_nocancel()
[#1] 0x7ffff5b98bff β _IO_new_file_write(f=0x7ffff5ee5620 <_IO_2_1_stdout_>, data=0x619000001480, n=0x4a)
[#2] 0x7ffff5b9a409 β new_do_write(to_do=0x4a, data=0x619000001480 "STRUCTURE OF TIFF FILE (II): id:000000,src:000553+000213,op:splice,rep:64\n", '\276' <repeats 950 times>, fp=0x7ffff5ee5620 <_IO_2_1_stdout_>)
[#3] 0x7ffff5b9a409 β _IO_new_do_write(fp=0x7ffff5ee5620 <_IO_2_1_stdout_>, data=0x619000001480 "STRUCTURE OF TIFF FILE (II): $POC\n", '\276' <repeats 950 times>, to_do=0x4a)
[#4] 0x7ffff5b9a81b β _IO_new_file_overflow(f=0x7ffff5ee5620 <_IO_2_1_stdout_>, ch=0xa)
[#5] 0x7ffff5b96533 β __GI__IO_putc(c=<optimized out>, fp=0x7ffff5ee5620 <_IO_2_1_stdout_>)
[#6] 0x7ffff6214a4a β std::ostream::put(char)()
[#7] 0x7ffff6214c3f β std::basic_ostream<char, std::char_traits<char> >& std::endl<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&)()
[#8] 0x7ffff673df1e β Exiv2::Image::printIFDStructure(this=0x61200000bec0, io=@0x60300000ecb0, out=@0x672ac0, option=Exiv2::kpsRecursive, start=0xff, bSwap=0x0, c=0x49, depth=0x0)
[#9] 0x7ffff673fe2a β Exiv2::Image::printTiffStructure(this=0x61200000bec0, io=@0x60300000ecb0, out=@0x672ac0, option=Exiv2::kpsRecursive, depth=0xffffffff, offset=0x0)
``` | uncontrolled recursion loop in Exiv2::Image::printTiffStructure() | https://api.github.com/repos/Exiv2/exiv2/issues/711/comments | 2 | 2019-02-21T11:50:59 | "2019-02-28T16:31:44Z" | https://github.com/Exiv2/exiv2/issues/711 | 412,886,432 | 711 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : uncontrolled recursion loop in Exiv2::Image::printTiffStructure()
Issue date:
--- start body ---
**Description** - During our research ,we Observed that an infinite uncontrolled recursion loop, at function Exiv2::Image::printTiffStructure at file image.cpp . It allows an attacker to cause Denial of Service or possibly have unspecified other impact.
**Command** - `exiv2 -b -u -k -p R pr $POC`
**POC** - [REPRODUCER](https://github.com/SegfaultMasters/covering360/blob/master/Exiv2/h1?raw=true)
**Debug** -
**GDB** -
```
84 ../sysdeps/unix/syscall-template.S: No such file or directory.
[ Legend: Modified register | Code | Heap | Stack | String ]
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ registers ββββ
$rax : 0x49
$rbx : 0x4a
$rcx : 0x00007ffff5c172c0 β <__write_nocancel+7> cmp rax, 0xfffffffffffff001
$rdx : 0x4a
$rsp : 0x00007fffffffd338 β 0x00007ffff5b98bff β <_IO_file_write+143> test rax, rax
$rbp : 0x0000619000001480 β "STRUCTURE OF TIFF FILE (II): id:000000,src:000553+[...]"
$rsi : 0x0000619000001480 β "STRUCTURE OF TIFF FILE (II): id:000000,src:000553+[...]"
$rdi : 0x1
$rip : 0x00007ffff5c172c0 β <__write_nocancel+7> cmp rax, 0xfffffffffffff001
$r8 : 0x00007ffff5ee6780 β 0x0000000100000001 β 0x0000000000000000
$r9 : 0x00007ffff7fd1780 β 0x00007ffff7fd1780 β [loop detected]
$r10 : 0x733a706f2c333132 ("213,op:s"?)
$r11 : 0x246
$r12 : 0x4a
$r13 : 0x1
$r14 : 0x00007ffff5ee5620 β 0x00000000fbad2a84 β 0x0000000000000000
$r15 : 0x00007fffffffdb20 β 0x0000000041b58ab3
$eflags: [carry PARITY adjust ZERO sign trap INTERRUPT direction overflow resume virtualx86 identification]
$cs: 0x0033 $ss: 0x002b $ds: 0x0000 $es: 0x0000 $fs: 0x0000 $gs: 0x0000
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ stack ββββ
0x00007fffffffd338β+0x0000: 0x00007ffff5b98bff β <_IO_file_write+143> test rax, rax β $rsp
0x00007fffffffd340β+0x0008: 0x00007ffff5ee5620 β 0x00000000fbad2a84 β 0x0000000000000000
0x00007fffffffd348β+0x0010: 0x000000000000004a ("J"?)
0x00007fffffffd350β+0x0018: 0x0000619000001480 β "STRUCTURE OF TIFF FILE (II): id:000000,src:000553+[...]"
0x00007fffffffd358β+0x0020: 0x00007fffffffd530 β 0x0000000041b58ab3
0x00007fffffffd360β+0x0028: 0x00007fffffffd960 β 0x0000000041b58ab3
0x00007fffffffd368β+0x0030: 0x00007ffff5b9a409 β <_IO_do_write+121> mov r13, rax
0x00007fffffffd370β+0x0038: 0x00007fffffffdb20 β 0x0000000041b58ab3
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ code:x86:64 ββββ
0x7ffff5c172b2 <write+2> mov DWORD PTR [rbp*1+0x10750000], esp
0x7ffff5c172b9 <__write_nocancel+0> mov eax, 0x1
0x7ffff5c172be <__write_nocancel+5> syscall
β 0x7ffff5c172c0 <__write_nocancel+7> cmp rax, 0xfffffffffffff001
0x7ffff5c172c6 <__write_nocancel+13> jae 0x7ffff5c172f9 <write+73>
0x7ffff5c172c8 <__write_nocancel+15> ret
0x7ffff5c172c9 <write+25> sub rsp, 0x8
0x7ffff5c172cd <write+29> call 0x7ffff5c350d0 <__libc_enable_asynccancel>
0x7ffff5c172d2 <write+34> mov QWORD PTR [rsp], rax
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ threads ββββ
[#0] Id 1, Name: "exiv2", stopped, reason: SIGINT
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ trace ββββ
[#0] 0x7ffff5c172c0 β __write_nocancel()
[#1] 0x7ffff5b98bff β _IO_new_file_write(f=0x7ffff5ee5620 <_IO_2_1_stdout_>, data=0x619000001480, n=0x4a)
[#2] 0x7ffff5b9a409 β new_do_write(to_do=0x4a, data=0x619000001480 "STRUCTURE OF TIFF FILE (II): id:000000,src:000553+000213,op:splice,rep:64\n", '\276' <repeats 950 times>, fp=0x7ffff5ee5620 <_IO_2_1_stdout_>)
[#3] 0x7ffff5b9a409 β _IO_new_do_write(fp=0x7ffff5ee5620 <_IO_2_1_stdout_>, data=0x619000001480 "STRUCTURE OF TIFF FILE (II): $POC\n", '\276' <repeats 950 times>, to_do=0x4a)
[#4] 0x7ffff5b9a81b β _IO_new_file_overflow(f=0x7ffff5ee5620 <_IO_2_1_stdout_>, ch=0xa)
[#5] 0x7ffff5b96533 β __GI__IO_putc(c=<optimized out>, fp=0x7ffff5ee5620 <_IO_2_1_stdout_>)
[#6] 0x7ffff6214a4a β std::ostream::put(char)()
[#7] 0x7ffff6214c3f β std::basic_ostream<char, std::char_traits<char> >& std::endl<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&)()
[#8] 0x7ffff673df1e β Exiv2::Image::printIFDStructure(this=0x61200000bec0, io=@0x60300000ecb0, out=@0x672ac0, option=Exiv2::kpsRecursive, start=0xff, bSwap=0x0, c=0x49, depth=0x0)
[#9] 0x7ffff673fe2a β Exiv2::Image::printTiffStructure(this=0x61200000bec0, io=@0x60300000ecb0, out=@0x672ac0, option=Exiv2::kpsRecursive, depth=0xffffffff, offset=0x0)
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 5,536 | 207,900 |
[
"Exiv2",
"exiv2"
] | JPEG files that come from digital cameras often have an additional higher resolution preview image.
I'm testing some Sony A73 and Fuji X-H1 files, and ExifTool tells me there is a PreviewImage like this:
$ exiftool DSC00507.JPG | grep Prev
Preview Image Size : 1616x1080
Preview Image : (Binary data 1050996 bytes, use -b option to extract)
This is a larger preview image in addition to the thumbnail. It'd be great if we can retrieve this preview image from various manufacturers.
Please see forum discussion:
http://dev.exiv2.org/boards/3/topics/3341?r=3371#message-3371 | Extract PreviewImage from JPEG (not thumbnail) | https://api.github.com/repos/Exiv2/exiv2/issues/710/comments | 3 | 2019-02-20T03:33:10 | "2021-05-09T13:58:42Z" | https://github.com/Exiv2/exiv2/issues/710 | 412,228,742 | 710 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Extract PreviewImage from JPEG (not thumbnail)
Issue date:
--- start body ---
JPEG files that come from digital cameras often have an additional higher resolution preview image.
I'm testing some Sony A73 and Fuji X-H1 files, and ExifTool tells me there is a PreviewImage like this:
$ exiftool DSC00507.JPG | grep Prev
Preview Image Size : 1616x1080
Preview Image : (Binary data 1050996 bytes, use -b option to extract)
This is a larger preview image in addition to the thumbnail. It'd be great if we can retrieve this preview image from various manufacturers.
Please see forum discussion:
http://dev.exiv2.org/boards/3/topics/3341?r=3371#message-3371
--- end body ---
comments :
--- start comments ---
--- end comments --- | 794 | 207,901 |
[
"Exiv2",
"exiv2"
] | Hi team,
Is it possible to add support to the the said lens?
```
$> **exiv2 -pt 20190208-112238.ARW | grep -ai lens**
Exif.Sony2.LensID Long 1 Manual lens
Exif.Photo.LensSpecification Rational 4 280/10 750/10 28/10 28/10
Exif.Photo.LensModel Ascii 19 E 28-75mm F2.8-2.8
```
Attached is the zip file containing the output of `exiv2 -ex 20190208-112238.ARW`
[20190208-112238.exv.zip](https://github.com/Exiv2/exiv2/files/2845634/20190208-112238.exv.zip)
Manufacture's [webpage for the lens](http://www.tamron-usa.com/product/lenses/a036.html)
Please let me know if you need anything else.
Thanks and regards,
| Support for Tamron 28-75mm F/2.8 Di III RXD A036 (Sony E Mount) | https://api.github.com/repos/Exiv2/exiv2/issues/693/comments | 6 | 2019-02-08T15:20:10 | "2019-02-13T03:38:23Z" | https://github.com/Exiv2/exiv2/issues/693 | 408,197,067 | 693 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Support for Tamron 28-75mm F/2.8 Di III RXD A036 (Sony E Mount)
Issue date:
--- start body ---
Hi team,
Is it possible to add support to the the said lens?
```
$> **exiv2 -pt 20190208-112238.ARW | grep -ai lens**
Exif.Sony2.LensID Long 1 Manual lens
Exif.Photo.LensSpecification Rational 4 280/10 750/10 28/10 28/10
Exif.Photo.LensModel Ascii 19 E 28-75mm F2.8-2.8
```
Attached is the zip file containing the output of `exiv2 -ex 20190208-112238.ARW`
[20190208-112238.exv.zip](https://github.com/Exiv2/exiv2/files/2845634/20190208-112238.exv.zip)
Manufacture's [webpage for the lens](http://www.tamron-usa.com/product/lenses/a036.html)
Please let me know if you need anything else.
Thanks and regards,
--- end body ---
comments :
--- start comments ---
--- end comments --- | 938 | 207,902 |
[
"Exiv2",
"exiv2"
] | I'm running macOS 10.14.2 (Mojave) and I have `gettext 0.19.8.1` installed via Homebrew. I can't use the `exiv2` provided by Homebrew for various reasons, so I'm trying to build `exiv2 0.27.0` with `CMake 3.12.3`. I run the following configuration command so that CMake can find `gettext`:
```Shell
cmake -DCMAKE_PREFIX_PATH=/usr/local/opt/gettext/ ..
```
CMake configuration works fine, but when I go to build, I get the following error:
```Shell
Scanning dependencies of target exiv2lib_int
[ 12%] Building CXX object src/CMakeFiles/exiv2lib_int.dir/canonmn_int.cpp.o
In file included from /Users/seth/source/exiv2/src/canonmn_int.cpp:34:
/Users/seth/source/exiv2/src/i18n.h:33:11: fatal error: 'libintl.h' file not found
# include <libintl.h>
^~~~~~~~~~~
1 error generated.
make[2]: *** [src/CMakeFiles/exiv2lib_int.dir/canonmn_int.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/exiv2lib_int.dir/all] Error 2
make: *** [all] Error 2
```
To get `exiv2lib` to build, I had to add:
```Diff
if( EXIV2_ENABLE_NLS )
target_link_libraries(exiv2lib PRIVATE ${Intl_LIBRARIES})
target_include_directories(exiv2lib PRIVATE ${Intl_INCLUDE_DIRS})
+ target_include_directories(exiv2lib_int PRIVATE ${Intl_INCLUDE_DIRS})
# Definition needed for translations
target_compile_definitions(exiv2lib PUBLIC EXV_LOCALEDIR="/../${CMAKE_INSTALL_LOCALEDIR}")
endif()
```
and to get the `exiv2` cli to build, I had to modify:
```Diff
if( EXIV2_ENABLE_NLS )
target_link_libraries(exiv2 PRIVATE ${Intl_LIBRARIES})
- target_include_directories(exiv2lib PRIVATE ${Intl_INCLUDE_DIRS})
+ target_include_directories(exiv2 PRIVATE ${Intl_INCLUDE_DIRS})
endif()
if (USING_CONAN AND WIN32 AND EXISTS ${PROJECT_BINARY_DIR}/conanDlls)
```
[This patch to the 0.27 tag](https://github.com/Exiv2/exiv2/files/2837751/macos-missing-libintl-fix.txt) contains the two lines of code I had to change in order to get the build to work.
I'm not sure why I'm seeing this issue when others aren't. For instance, I don't see that the Homebrew formula is doing anything special to account for this. If this is actually a bug and not user error, let me know and I can open pull request off of the master branch. | gettext include issue on macOS | https://api.github.com/repos/Exiv2/exiv2/issues/684/comments | 6 | 2019-02-06T18:53:05 | "2019-02-08T15:48:28Z" | https://github.com/Exiv2/exiv2/issues/684 | 407,380,158 | 684 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : gettext include issue on macOS
Issue date:
--- start body ---
I'm running macOS 10.14.2 (Mojave) and I have `gettext 0.19.8.1` installed via Homebrew. I can't use the `exiv2` provided by Homebrew for various reasons, so I'm trying to build `exiv2 0.27.0` with `CMake 3.12.3`. I run the following configuration command so that CMake can find `gettext`:
```Shell
cmake -DCMAKE_PREFIX_PATH=/usr/local/opt/gettext/ ..
```
CMake configuration works fine, but when I go to build, I get the following error:
```Shell
Scanning dependencies of target exiv2lib_int
[ 12%] Building CXX object src/CMakeFiles/exiv2lib_int.dir/canonmn_int.cpp.o
In file included from /Users/seth/source/exiv2/src/canonmn_int.cpp:34:
/Users/seth/source/exiv2/src/i18n.h:33:11: fatal error: 'libintl.h' file not found
# include <libintl.h>
^~~~~~~~~~~
1 error generated.
make[2]: *** [src/CMakeFiles/exiv2lib_int.dir/canonmn_int.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/exiv2lib_int.dir/all] Error 2
make: *** [all] Error 2
```
To get `exiv2lib` to build, I had to add:
```Diff
if( EXIV2_ENABLE_NLS )
target_link_libraries(exiv2lib PRIVATE ${Intl_LIBRARIES})
target_include_directories(exiv2lib PRIVATE ${Intl_INCLUDE_DIRS})
+ target_include_directories(exiv2lib_int PRIVATE ${Intl_INCLUDE_DIRS})
# Definition needed for translations
target_compile_definitions(exiv2lib PUBLIC EXV_LOCALEDIR="/../${CMAKE_INSTALL_LOCALEDIR}")
endif()
```
and to get the `exiv2` cli to build, I had to modify:
```Diff
if( EXIV2_ENABLE_NLS )
target_link_libraries(exiv2 PRIVATE ${Intl_LIBRARIES})
- target_include_directories(exiv2lib PRIVATE ${Intl_INCLUDE_DIRS})
+ target_include_directories(exiv2 PRIVATE ${Intl_INCLUDE_DIRS})
endif()
if (USING_CONAN AND WIN32 AND EXISTS ${PROJECT_BINARY_DIR}/conanDlls)
```
[This patch to the 0.27 tag](https://github.com/Exiv2/exiv2/files/2837751/macos-missing-libintl-fix.txt) contains the two lines of code I had to change in order to get the build to work.
I'm not sure why I'm seeing this issue when others aren't. For instance, I don't see that the Homebrew formula is doing anything special to account for this. If this is actually a bug and not user error, let me know and I can open pull request off of the master branch.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,471 | 207,903 |
[
"Exiv2",
"exiv2"
] | For complex structured tags like "LensSpecification" or "MakeNote", where we know that the value is expected to be a list of values (rational, byte, integer, etc...), is there a way to read the data into appropriate container, instead of reading the data into a string and then parsing?
Thanks,
Mikayel
| Reading complex structured tags | https://api.github.com/repos/Exiv2/exiv2/issues/681/comments | 6 | 2019-02-04T13:54:45 | "2020-09-04T19:04:19Z" | https://github.com/Exiv2/exiv2/issues/681 | 406,339,990 | 681 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Reading complex structured tags
Issue date:
--- start body ---
For complex structured tags like "LensSpecification" or "MakeNote", where we know that the value is expected to be a list of values (rational, byte, integer, etc...), is there a way to read the data into appropriate container, instead of reading the data into a string and then parsing?
Thanks,
Mikayel
--- end body ---
comments :
--- start comments ---
--- end comments --- | 500 | 207,904 |
[
"Exiv2",
"exiv2"
] | Would it be too much to ask if Windows binaries of 0.27 were compiled with `EXV_UNICODE_PATH` enabled?
Does it somehow break expectations for library users?
It's a bit of a pain that none of the `exiv2.exe` binaries (msvc, mingw, cygwin) seem to support Unicode filenames out of the box. | Windows binaries with Unicode paths | https://api.github.com/repos/Exiv2/exiv2/issues/679/comments | 10 | 2019-02-03T00:48:48 | "2021-04-13T11:26:13Z" | https://github.com/Exiv2/exiv2/issues/679 | 406,039,232 | 679 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Windows binaries with Unicode paths
Issue date:
--- start body ---
Would it be too much to ask if Windows binaries of 0.27 were compiled with `EXV_UNICODE_PATH` enabled?
Does it somehow break expectations for library users?
It's a bit of a pain that none of the `exiv2.exe` binaries (msvc, mingw, cygwin) seem to support Unicode filenames out of the box.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 489 | 207,905 |
[
"Exiv2",
"exiv2"
] | Apply #617 to master, but instead of deprecating the code, delete it. | Remove relics from master | https://api.github.com/repos/Exiv2/exiv2/issues/675/comments | 3 | 2019-02-01T12:00:35 | "2019-02-25T06:02:05Z" | https://github.com/Exiv2/exiv2/issues/675 | 405,672,412 | 675 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Remove relics from master
Issue date:
--- start body ---
Apply #617 to master, but instead of deprecating the code, delete it.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 255 | 207,906 |
[
"Exiv2",
"exiv2"
] | I don't know if the lens firmware update or my 5D Mark 4 is reporting this lens incorrectly but it started some time ago that the lens is not being recognized automatically anymore. When checking the ID the output is the following:
0x0016 CanonCs LensType Short 1 368
So I assumed adding:
[canon]
368=Sigma 50mm f/1.4 DG HSM | A
or
[canon]
368 = Sigma 50mm f/1.4 DG HSM [A]
to the .exiv2 file would change that but all I get is still LensType 368. Is there something I am doing wrong? | Does not recognize Sigma 50mm F1.4 DG HSM | Art 014 | https://api.github.com/repos/Exiv2/exiv2/issues/671/comments | 2 | 2019-01-29T13:55:26 | "2019-01-29T17:17:08Z" | https://github.com/Exiv2/exiv2/issues/671 | 404,302,281 | 671 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Does not recognize Sigma 50mm F1.4 DG HSM | Art 014
Issue date:
--- start body ---
I don't know if the lens firmware update or my 5D Mark 4 is reporting this lens incorrectly but it started some time ago that the lens is not being recognized automatically anymore. When checking the ID the output is the following:
0x0016 CanonCs LensType Short 1 368
So I assumed adding:
[canon]
368=Sigma 50mm f/1.4 DG HSM | A
or
[canon]
368 = Sigma 50mm f/1.4 DG HSM [A]
to the .exiv2 file would change that but all I get is still LensType 368. Is there something I am doing wrong?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 745 | 207,907 |
[
"Exiv2",
"exiv2"
] | We are currently backporting a lot of stuff to the 0.27 branch, and doing that manually is tedious. I propose that we automate this process. One possible service is https://mergify.io/.
While mergify's main selling point is to automatically merge pull requests, once they fit a certain set of rules (e.g. two approvals, CI passes, moon is in the right phase, etc.), it can also backport pull requests that get a certain label.
See: https://doc.mergify.io/examples.html#using-labels-to-backport-pull-requests and https://doc.mergify.io/actions.html#backport
And while we are at it, we could also consider using mergify for other stuff, like automatically deleting the branch from which a pull request came. | [proposal] Use mergify.io for backporting | https://api.github.com/repos/Exiv2/exiv2/issues/669/comments | 3 | 2019-01-27T09:55:24 | "2019-02-04T09:05:13Z" | https://github.com/Exiv2/exiv2/issues/669 | 403,533,792 | 669 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : [proposal] Use mergify.io for backporting
Issue date:
--- start body ---
We are currently backporting a lot of stuff to the 0.27 branch, and doing that manually is tedious. I propose that we automate this process. One possible service is https://mergify.io/.
While mergify's main selling point is to automatically merge pull requests, once they fit a certain set of rules (e.g. two approvals, CI passes, moon is in the right phase, etc.), it can also backport pull requests that get a certain label.
See: https://doc.mergify.io/examples.html#using-labels-to-backport-pull-requests and https://doc.mergify.io/actions.html#backport
And while we are at it, we could also consider using mergify for other stuff, like automatically deleting the branch from which a pull request came.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 918 | 207,908 |