issue_owner_repo
sequencelengths 2
2
| issue_body
stringlengths 0
261k
⌀ | issue_title
stringlengths 1
953
| issue_comments_url
stringlengths 56
81
| issue_comments_count
int64 0
726
| issue_created_at
timestamp[ns] | issue_updated_at
unknown | issue_html_url
stringlengths 37
62
| issue_github_id
int64 285M
2.37B
| issue_number
int64 1
168k
| msg
stringlengths 159
261k
| n_tokens
int64 159
261k
| __index_level_0__
int64 38
208k
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
[
"Exiv2",
"exiv2"
] | Hi there,
I'm using the simple script:
`#!/bin/bash
echo "The first argument is the path to directory with images"
echo "Second argument is the value of Xmp.Camera.GPSXYAccuracy"
DIR_PATH=$1
VALUE=$2
echo $DIR_PATH
echo $VALUE
for I in $(ls $DIR_PATH); do
echo $I
exiv2 -M "reg Camera http://ns.Camera.me/" -M "add Xmp.Camera.GPSXYAccuracy XmpText $VALUE" $DIR_PATH/$I
done
`
for adding value to XMP.Camera.GPSXYAccuracy tag.
It works very well with JPG and TIFF files but doesn't work with BigTIFF files. I searched about this issue on different BigTIFF's documentation but didn't find any explanation.
Please, help me to solve this issue or just to find an authoritative body that says that BigTIFF doesn't support adding/editing such an XMP tag.
Thanks,
Andriy
| Adding XMP tag to BigTIFF file | https://api.github.com/repos/Exiv2/exiv2/issues/1259/comments | 5 | 2020-08-07T12:53:49 | "2020-09-28T09:10:52Z" | https://github.com/Exiv2/exiv2/issues/1259 | 674,996,187 | 1,259 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Adding XMP tag to BigTIFF file
Issue date:
--- start body ---
Hi there,
I'm using the simple script:
`#!/bin/bash
echo "The first argument is the path to directory with images"
echo "Second argument is the value of Xmp.Camera.GPSXYAccuracy"
DIR_PATH=$1
VALUE=$2
echo $DIR_PATH
echo $VALUE
for I in $(ls $DIR_PATH); do
echo $I
exiv2 -M "reg Camera http://ns.Camera.me/" -M "add Xmp.Camera.GPSXYAccuracy XmpText $VALUE" $DIR_PATH/$I
done
`
for adding value to XMP.Camera.GPSXYAccuracy tag.
It works very well with JPG and TIFF files but doesn't work with BigTIFF files. I searched about this issue on different BigTIFF's documentation but didn't find any explanation.
Please, help me to solve this issue or just to find an authoritative body that says that BigTIFF doesn't support adding/editing such an XMP tag.
Thanks,
Andriy
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,002 | 207,709 |
[
"Exiv2",
"exiv2"
] | One of the highlights of Exiv2 v0.27.3 is "Improved charset handling in UserComment". I scrolled through the change list, but did not find details to this item.
What I observed: in previous version toString returned the value including the leading "charset=...", whereas print() returned it without. Now in both cases I get the leading "charset=...".
Is this changed behaviour the improved handling or did something else change?
From my point of view the previous behaviour was the better one. print() returned a value, which is good for users which just want to see the value, whereas toString() gives the additional information about charset for users interested in charset.
| Improved charset handling in UserComment: what does it mean? | https://api.github.com/repos/Exiv2/exiv2/issues/1258/comments | 34 | 2020-08-03T13:38:05 | "2020-11-13T11:40:26Z" | https://github.com/Exiv2/exiv2/issues/1258 | 672,082,797 | 1,258 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Improved charset handling in UserComment: what does it mean?
Issue date:
--- start body ---
One of the highlights of Exiv2 v0.27.3 is "Improved charset handling in UserComment". I scrolled through the change list, but did not find details to this item.
What I observed: in previous version toString returned the value including the leading "charset=...", whereas print() returned it without. Now in both cases I get the leading "charset=...".
Is this changed behaviour the improved handling or did something else change?
From my point of view the previous behaviour was the better one. print() returned a value, which is good for users which just want to see the value, whereas toString() gives the additional information about charset for users interested in charset.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 904 | 207,710 |
[
"Exiv2",
"exiv2"
] | **Is your feature request related to a problem? Please describe.**
I am using the library exiv2 in an own program for Windows. I would like to have the exiv2.ini stored in %APPDATA% instead of the program's folder. Also I want to enable the user to specify the location, e.g. if he is using also exiv2 as commandline tool, he may configure my program to use the exiv2.ini stored in the commandline tool's folder (instead of having two files).
**Describe the solution you'd like**
My idea is to modify makernote_in.cpp. A new method allows to store the path of exiv2.ini in a variable. getExiv2ConfigPath checks first, if that variable is set. If it is not set, it returns the path in the same way as now.
| Allow to set configuration path holding exiv2.ini | https://api.github.com/repos/Exiv2/exiv2/issues/1256/comments | 3 | 2020-08-01T09:14:39 | "2020-08-01T15:24:52Z" | https://github.com/Exiv2/exiv2/issues/1256 | 670,690,516 | 1,256 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Allow to set configuration path holding exiv2.ini
Issue date:
--- start body ---
**Is your feature request related to a problem? Please describe.**
I am using the library exiv2 in an own program for Windows. I would like to have the exiv2.ini stored in %APPDATA% instead of the program's folder. Also I want to enable the user to specify the location, e.g. if he is using also exiv2 as commandline tool, he may configure my program to use the exiv2.ini stored in the commandline tool's folder (instead of having two files).
**Describe the solution you'd like**
My idea is to modify makernote_in.cpp. A new method allows to store the path of exiv2.ini in a variable. getExiv2ConfigPath checks first, if that variable is set. If it is not set, it returns the path in the same way as now.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 921 | 207,711 |
[
"Exiv2",
"exiv2"
] | **Is your feature request related to a problem? Please describe.**
Microsoft have been developing a cross-platform package manager called vcpkg. vcpkg is an open-source project and provides support for:
1. Visual Studio and GCC on Windows
2. GCC on macOS and linux.
I was very pleased to discover that Exiv2 v0.27.3 is already supported.
**Describe the solution you'd like**
I would like to know something about the performance on vcpkg and add a section to README.md. For Exiv2 v0.27.4, I intend to continue to recommend conan+CMake for Visual Studio builds and CMake for all other platforms.
**Describe alternatives you've considered**
I have successfully built Visual Studio 2019 + Exiv2/DLL and exiv2.exe. https://github.com/Exiv2/exiv2/issues/1250#issuecomment-663360908
**Additional context**
No comment.
| Investigate vcpkg support for Exiv2 | https://api.github.com/repos/Exiv2/exiv2/issues/1255/comments | 5 | 2020-07-26T16:44:43 | "2021-04-12T20:14:50Z" | https://github.com/Exiv2/exiv2/issues/1255 | 665,817,084 | 1,255 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Investigate vcpkg support for Exiv2
Issue date:
--- start body ---
**Is your feature request related to a problem? Please describe.**
Microsoft have been developing a cross-platform package manager called vcpkg. vcpkg is an open-source project and provides support for:
1. Visual Studio and GCC on Windows
2. GCC on macOS and linux.
I was very pleased to discover that Exiv2 v0.27.3 is already supported.
**Describe the solution you'd like**
I would like to know something about the performance on vcpkg and add a section to README.md. For Exiv2 v0.27.4, I intend to continue to recommend conan+CMake for Visual Studio builds and CMake for all other platforms.
**Describe alternatives you've considered**
I have successfully built Visual Studio 2019 + Exiv2/DLL and exiv2.exe. https://github.com/Exiv2/exiv2/issues/1250#issuecomment-663360908
**Additional context**
No comment.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,031 | 207,712 |
[
"Exiv2",
"exiv2"
] | Per https://exiv2.org/tags-xmp-iptcExt.html and the associated IPTC Extension specifications, the value type of LocationShown and LocationCreated is a LocationDetails bag. The resulting Xmp section would look something like:
```
<Iptc4xmpExt:LocationCreated>
<rdf:Bag>
<rdf:li rd:parseType=“Resource”>
<Iptc4xmpExt:Sublocation/>
<Iptc4xmpExt:City>Paris</Iptc4xmpExt:City>
<Iptc4xmpExt:ProvinceState/>
<Iptc4xmpExt:CountryName>France</Iptc4xmpExt:CountryName>
<Iptc4xmpExt:CountryCode/>
<Iptc4xmpExt:WorldRegion/>
</rdf:li>
</rdf:Bag>
<Iptc4xmpExt:LocationCreated>
```
I haven't been able to find anything in the docs that would allow keys to be nested within a Bag like this.
If there is a way, I would be grateful if somebody would be able to share it with me.
| Method to write LocationShown and LocationCreated in IPTC Extension schema | https://api.github.com/repos/Exiv2/exiv2/issues/1254/comments | 20 | 2020-07-22T20:43:01 | "2020-07-23T15:46:27Z" | https://github.com/Exiv2/exiv2/issues/1254 | 664,037,622 | 1,254 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Method to write LocationShown and LocationCreated in IPTC Extension schema
Issue date:
--- start body ---
Per https://exiv2.org/tags-xmp-iptcExt.html and the associated IPTC Extension specifications, the value type of LocationShown and LocationCreated is a LocationDetails bag. The resulting Xmp section would look something like:
```
<Iptc4xmpExt:LocationCreated>
<rdf:Bag>
<rdf:li rd:parseType=“Resource”>
<Iptc4xmpExt:Sublocation/>
<Iptc4xmpExt:City>Paris</Iptc4xmpExt:City>
<Iptc4xmpExt:ProvinceState/>
<Iptc4xmpExt:CountryName>France</Iptc4xmpExt:CountryName>
<Iptc4xmpExt:CountryCode/>
<Iptc4xmpExt:WorldRegion/>
</rdf:li>
</rdf:Bag>
<Iptc4xmpExt:LocationCreated>
```
I haven't been able to find anything in the docs that would allow keys to be nested within a Bag like this.
If there is a way, I would be grateful if somebody would be able to share it with me.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,067 | 207,713 |
[
"Exiv2",
"exiv2"
] |
**Describe the bug**
The issue which I raised a year ago initially as part of this problem is unfortunately still present inf 0.27.3
The initial issues was the use of the function name free() as a public member of DataBuf in types.hpp
> /*!
> @brief Free the internal buffer and reset the size to 0.
> */
> void free();
Steps to reproduce the behaviour:
Compile 0.27.3 for windows static linking under MSVC and use the static library in a project.
_
> 8>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\include\exiv2\types.hpp(242,14): warning C4003: not enough arguments for function-like macro invocation 'free' (compiling source file wxIcRemovLocDlg.cpp)
> 8>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\include\exiv2\types.hpp(242,14): error C2059: syntax error: ',' (compiling source file wxIcRemovLocDlg.cpp)
> 9>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\include\exiv2\types.hpp(242,14): warning C4003: not enough arguments for function-like macro invocation 'free' (compiling source file wxIcOptionsUpdateUi.cpp)
> 9>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\include\exiv2\types.hpp(242,14): error C2059: syntax error: ',' (compiling source file wxIcOptionsUpdateUi.cpp)
_
Branch: `0.27-maintenance`)
**Expected behavior**
User defined libraries are generally not expected/allowed to name publicly accessible functions with names corresponding/conflicting to those of the basic C libraries - in this case Exiv2 defines
void free()
void alloc(size_t size)
This causes conflicts with use of this function within regular code in my app.
**Desktop (please complete the following information):**
- OS: Windows 10 64-bit
- Compiler & Version MSVC 2019
- Compilation mode and/or compiler flags 32-bit static linking of Exiv2 lib
When I opened issue #976 - almost exactly a year ago - the discussion quickly ended up diverted towards issues of library initialization & clean up which also existed at the time.
Because I had already 'fixed my 'fork', the original free() issue did not resurface and became lost, hence #976 was closed because the initialization/cleanup issue was resolved.
Now that I updated my code from Github, it surfaced again
For now, I can rename the function to free_() (as before) and recompile, though that is not a very satisfactory option.
Since both of these functions are used liberally throughout the exiv2 code, I could not make them 'private' to DataBuf, though I tried.
A more permanent solution might be to rename the functions in a way which would not cause conflicts with the standard C library (even C++ has a free() ) or perhaps these ought to be bracketed with some name space constraints within the exiv2 code.
If there is a generic solution I can apply to my code, I am open to advice and/or suggestions. | Issue #976 needs to be revisited/reopened | https://api.github.com/repos/Exiv2/exiv2/issues/1251/comments | 4 | 2020-07-18T01:36:57 | "2020-07-18T17:12:29Z" | https://github.com/Exiv2/exiv2/issues/1251 | 659,805,037 | 1,251 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Issue #976 needs to be revisited/reopened
Issue date:
--- start body ---
**Describe the bug**
The issue which I raised a year ago initially as part of this problem is unfortunately still present inf 0.27.3
The initial issues was the use of the function name free() as a public member of DataBuf in types.hpp
> /*!
> @brief Free the internal buffer and reset the size to 0.
> */
> void free();
Steps to reproduce the behaviour:
Compile 0.27.3 for windows static linking under MSVC and use the static library in a project.
_
> 8>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\include\exiv2\types.hpp(242,14): warning C4003: not enough arguments for function-like macro invocation 'free' (compiling source file wxIcRemovLocDlg.cpp)
> 8>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\include\exiv2\types.hpp(242,14): error C2059: syntax error: ',' (compiling source file wxIcRemovLocDlg.cpp)
> 9>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\include\exiv2\types.hpp(242,14): warning C4003: not enough arguments for function-like macro invocation 'free' (compiling source file wxIcOptionsUpdateUi.cpp)
> 9>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\include\exiv2\types.hpp(242,14): error C2059: syntax error: ',' (compiling source file wxIcOptionsUpdateUi.cpp)
_
Branch: `0.27-maintenance`)
**Expected behavior**
User defined libraries are generally not expected/allowed to name publicly accessible functions with names corresponding/conflicting to those of the basic C libraries - in this case Exiv2 defines
void free()
void alloc(size_t size)
This causes conflicts with use of this function within regular code in my app.
**Desktop (please complete the following information):**
- OS: Windows 10 64-bit
- Compiler & Version MSVC 2019
- Compilation mode and/or compiler flags 32-bit static linking of Exiv2 lib
When I opened issue #976 - almost exactly a year ago - the discussion quickly ended up diverted towards issues of library initialization & clean up which also existed at the time.
Because I had already 'fixed my 'fork', the original free() issue did not resurface and became lost, hence #976 was closed because the initialization/cleanup issue was resolved.
Now that I updated my code from Github, it surfaced again
For now, I can rename the function to free_() (as before) and recompile, though that is not a very satisfactory option.
Since both of these functions are used liberally throughout the exiv2 code, I could not make them 'private' to DataBuf, though I tried.
A more permanent solution might be to rename the functions in a way which would not cause conflicts with the standard C library (even C++ has a free() ) or perhaps these ought to be bracketed with some name space constraints within the exiv2 code.
If there is a generic solution I can apply to my code, I am open to advice and/or suggestions.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,987 | 207,714 |
[
"Exiv2",
"exiv2"
] | Compiling the code form a newly cloned version from Github, (expected/intended to be 0.27-maintenance) under MSVC 2019 for a 32-bit version of Exiv2:
In convert.cpp the line
EXV_ICONV_CONST char* inptr = const_cast<char*>(str.c_str());
the line shown, causes the error:
_1>convert.cpp
1>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\src\convert.cpp(1527,25): error C2664: 'size_t libiconv(libiconv_t,const char **,size_t *,char **,size_t *)': cannot convert argument 2 from 'char **' to 'const char **'
1>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\src\convert.cpp(1528,31): message : Conversion loses qualifiers
1>C:\gnuwin32\include\iconv.h(92,37): message : see declaration of 'libiconv'_
This error causes most of the other sub-projects to also fail.
Replacing EXV_ICONV_CONST with a plain 'const' allow this file to compile cleanly as well as all of the rest.
The sln file was created following the instructions for Windows MSVC compile https://github.com/Exiv2/exiv2/blob/master/README-CONAN.md
At this stage I have no idea about the version of libiconv, but the entire setup was presumably vetted by the conan install & update process.
Searching for the string "EXV_ICONV_CONST" does not show any instance except the line giving the error, implying that for the current setup it is not defined
**Desktop (please complete the following information):**
- OS: Windows 10, 64-bit
- Compiler & Version MSVC 2019
- Compilation mode and/or compiler flags
| Windows MSVC 2019 EXV_ICONV_CONST undefined | https://api.github.com/repos/Exiv2/exiv2/issues/1250/comments | 42 | 2020-07-17T23:25:02 | "2020-07-26T19:25:24Z" | https://github.com/Exiv2/exiv2/issues/1250 | 659,730,564 | 1,250 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Windows MSVC 2019 EXV_ICONV_CONST undefined
Issue date:
--- start body ---
Compiling the code form a newly cloned version from Github, (expected/intended to be 0.27-maintenance) under MSVC 2019 for a 32-bit version of Exiv2:
In convert.cpp the line
EXV_ICONV_CONST char* inptr = const_cast<char*>(str.c_str());
the line shown, causes the error:
_1>convert.cpp
1>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\src\convert.cpp(1527,25): error C2664: 'size_t libiconv(libiconv_t,const char **,size_t *,char **,size_t *)': cannot convert argument 2 from 'char **' to 'const char **'
1>D:\pkg\C++\MSVC2019\exiv2Git\exiv2\src\convert.cpp(1528,31): message : Conversion loses qualifiers
1>C:\gnuwin32\include\iconv.h(92,37): message : see declaration of 'libiconv'_
This error causes most of the other sub-projects to also fail.
Replacing EXV_ICONV_CONST with a plain 'const' allow this file to compile cleanly as well as all of the rest.
The sln file was created following the instructions for Windows MSVC compile https://github.com/Exiv2/exiv2/blob/master/README-CONAN.md
At this stage I have no idea about the version of libiconv, but the entire setup was presumably vetted by the conan install & update process.
Searching for the string "EXV_ICONV_CONST" does not show any instance except the line giving the error, implying that for the current setup it is not defined
**Desktop (please complete the following information):**
- OS: Windows 10, 64-bit
- Compiler & Version MSVC 2019
- Compilation mode and/or compiler flags
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,677 | 207,715 |
[
"Exiv2",
"exiv2"
] | Hello!
I did not find the image size limit for Exiv2 in the documentation.
According to the definition of class `Exiv2::ImageFactory`:
```cpp
static Image::AutoPtr open(const byte* data, long size);
```
Exiv2 uses a `long` variable to store the size of the image. So it can only open the image less than 2G?
I tested it with the following images:
```batch
D:\>dir test*
2020/07/15 17:30 1,063,763,522 test_0.99G.jpg
2020/07/15 16:06 1,091,823,634 test_1.01G.jpg
2020/07/15 17:42 2,133,024,614 test_1.98G.jpg
2020/07/15 17:43 2,233,024,614 test_2.07G.jpg
```
Test reading images:
```batch
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe test_0.99G.jpg
File name : test_0.99G.jpg
File size : 1063763522 Bytes
MIME type : image/jpeg
Image size : 55000 x 55186
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe test_1.01G.jpg
File name : test_1.01G.jpg
File size : 1091823634 Bytes
MIME type : image/jpeg
Image size : 56000 x 56189
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe test_1.98G.jpg
File name : test_1.98G.jpg
File size : 2133024614 Bytes
MIME type : image/jpeg
Image size : 61328 x 61535
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe test_2.07G.jpg
test_2.07G.jpg: Failed to open the file
```
Test modifying images:
```batch
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe -M"set Exif.Image.Rating 5" test_0.99G.jpg
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe -M"set Exif.Image.Rating 5" test_1.01G.jpg
Exiv2 exception in modify action for file test_1.01G.jpg:
Memory allocation failed
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe -M"set Exif.Image.Rating 5" test_1.98G.jpg
Exiv2 exception in modify action for file test_1.98G.jpg:
Memory allocation failed
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe -M"set Exif.Image.Rating 5" test_2.07G.jpg
test_2.07G.jpg: Failed to open the file
```
It looks like Exiv2 can only read the image less than 2G and modify the image less than 1G.
Is that right?
| What is the maximum size of an image that Exiv2 can handle? | https://api.github.com/repos/Exiv2/exiv2/issues/1248/comments | 25 | 2020-07-15T11:23:59 | "2020-07-18T09:44:20Z" | https://github.com/Exiv2/exiv2/issues/1248 | 657,274,360 | 1,248 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : What is the maximum size of an image that Exiv2 can handle?
Issue date:
--- start body ---
Hello!
I did not find the image size limit for Exiv2 in the documentation.
According to the definition of class `Exiv2::ImageFactory`:
```cpp
static Image::AutoPtr open(const byte* data, long size);
```
Exiv2 uses a `long` variable to store the size of the image. So it can only open the image less than 2G?
I tested it with the following images:
```batch
D:\>dir test*
2020/07/15 17:30 1,063,763,522 test_0.99G.jpg
2020/07/15 16:06 1,091,823,634 test_1.01G.jpg
2020/07/15 17:42 2,133,024,614 test_1.98G.jpg
2020/07/15 17:43 2,233,024,614 test_2.07G.jpg
```
Test reading images:
```batch
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe test_0.99G.jpg
File name : test_0.99G.jpg
File size : 1063763522 Bytes
MIME type : image/jpeg
Image size : 55000 x 55186
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe test_1.01G.jpg
File name : test_1.01G.jpg
File size : 1091823634 Bytes
MIME type : image/jpeg
Image size : 56000 x 56189
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe test_1.98G.jpg
File name : test_1.98G.jpg
File size : 2133024614 Bytes
MIME type : image/jpeg
Image size : 61328 x 61535
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe test_2.07G.jpg
test_2.07G.jpg: Failed to open the file
```
Test modifying images:
```batch
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe -M"set Exif.Image.Rating 5" test_0.99G.jpg
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe -M"set Exif.Image.Rating 5" test_1.01G.jpg
Exiv2 exception in modify action for file test_1.01G.jpg:
Memory allocation failed
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe -M"set Exif.Image.Rating 5" test_1.98G.jpg
Exiv2 exception in modify action for file test_1.98G.jpg:
Memory allocation failed
D:\>exiv2-0.27.2-2017msvc64\bin\exiv2.exe -M"set Exif.Image.Rating 5" test_2.07G.jpg
test_2.07G.jpg: Failed to open the file
```
It looks like Exiv2 can only read the image less than 2G and modify the image less than 1G.
Is that right?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,247 | 207,716 |
[
"Exiv2",
"exiv2"
] | I get these NikonLd3 values for my "AF-S NIKKOR 500mm f/5.6E PF ED VR" (see https://imaging.nikon.com/lineup/lens/f-mount/singlefocal/Telephoto/af-s_500mmf_56e_pf_ed_vr/index.htm). It would be great if it could be added to the lens database.
```
Exif.NikonLd3.Version Undefined 4 2.04
Exif.NikonLd3.ExitPupilPosition Byte 1 113.8 mm
Exif.NikonLd3.AFAperture Byte 1 F5.8
Exif.NikonLd3.FocusPosition Byte 1 34
Exif.NikonLd3.FocusDistance Byte 1 23.71 m
Exif.NikonLd3.FocalLength Byte 1 508.0 mm
Exif.NikonLd3.LensIDNumber Byte 1 173
Exif.NikonLd3.LensFStops Byte 1 F5.0
Exif.NikonLd3.MinFocalLength Byte 1 508.0 mm
Exif.NikonLd3.MaxFocalLength Byte 1 508.0 mm
Exif.NikonLd3.MaxApertureAtMinFocal Byte 1 F5.7
Exif.NikonLd3.MaxApertureAtMaxFocal Byte 1 F5.7
Exif.NikonLd3.MCUVersion Byte 1 216
Exif.NikonLd3.EffectiveMaxAperture Byte 1 F5.7
``` | please add "AF-S NIKKOR 500mm f/5.6E PF ED VR" | https://api.github.com/repos/Exiv2/exiv2/issues/1247/comments | 2 | 2020-07-14T22:13:21 | "2020-07-15T16:53:30Z" | https://github.com/Exiv2/exiv2/issues/1247 | 656,930,165 | 1,247 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : please add "AF-S NIKKOR 500mm f/5.6E PF ED VR"
Issue date:
--- start body ---
I get these NikonLd3 values for my "AF-S NIKKOR 500mm f/5.6E PF ED VR" (see https://imaging.nikon.com/lineup/lens/f-mount/singlefocal/Telephoto/af-s_500mmf_56e_pf_ed_vr/index.htm). It would be great if it could be added to the lens database.
```
Exif.NikonLd3.Version Undefined 4 2.04
Exif.NikonLd3.ExitPupilPosition Byte 1 113.8 mm
Exif.NikonLd3.AFAperture Byte 1 F5.8
Exif.NikonLd3.FocusPosition Byte 1 34
Exif.NikonLd3.FocusDistance Byte 1 23.71 m
Exif.NikonLd3.FocalLength Byte 1 508.0 mm
Exif.NikonLd3.LensIDNumber Byte 1 173
Exif.NikonLd3.LensFStops Byte 1 F5.0
Exif.NikonLd3.MinFocalLength Byte 1 508.0 mm
Exif.NikonLd3.MaxFocalLength Byte 1 508.0 mm
Exif.NikonLd3.MaxApertureAtMinFocal Byte 1 F5.7
Exif.NikonLd3.MaxApertureAtMaxFocal Byte 1 F5.7
Exif.NikonLd3.MCUVersion Byte 1 216
Exif.NikonLd3.EffectiveMaxAperture Byte 1 F5.7
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,401 | 207,717 |
[
"Exiv2",
"exiv2"
] | Dear Exiv2 Team,
Would it be possible to add support for the GettyImages: GettyImagesGIFT field: Personality ?
Thanks,
Consti | Getty Images Personality Support Feature Request | https://api.github.com/repos/Exiv2/exiv2/issues/1246/comments | 5 | 2020-07-13T11:55:32 | "2020-07-15T20:47:57Z" | https://github.com/Exiv2/exiv2/issues/1246 | 655,791,398 | 1,246 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Getty Images Personality Support Feature Request
Issue date:
--- start body ---
Dear Exiv2 Team,
Would it be possible to add support for the GettyImages: GettyImagesGIFT field: Personality ?
Thanks,
Consti
--- end body ---
comments :
--- start comments ---
--- end comments --- | 342 | 207,718 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Building using GCC 10 on PPC/PPC64 fails with:
`cc1plus: error: '-fcf-protection=full' is not supported for this target
`
**To Reproduce**
Steps to reproduce the behaviour:
1. Try building on PPC platforms.
**Expected behavior**
exiv2 should build.
**Desktop (please complete the following information):**
- OS: FreeBSD
- Compiler & Version GCC 10.1
- Compilation mode and/or compiler flags
Default flags.
**Additional context**
https://github.com/Exiv2/exiv2/commit/1ea63ccb345a4498b41cb8842622ba7ecc9fd484 fixed build on arm, ppc needs the same. | exiv2 0.27.3 fails to build on PPC | https://api.github.com/repos/Exiv2/exiv2/issues/1244/comments | 12 | 2020-07-09T09:57:39 | "2020-09-04T18:38:23Z" | https://github.com/Exiv2/exiv2/issues/1244 | 653,930,538 | 1,244 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : exiv2 0.27.3 fails to build on PPC
Issue date:
--- start body ---
**Describe the bug**
Building using GCC 10 on PPC/PPC64 fails with:
`cc1plus: error: '-fcf-protection=full' is not supported for this target
`
**To Reproduce**
Steps to reproduce the behaviour:
1. Try building on PPC platforms.
**Expected behavior**
exiv2 should build.
**Desktop (please complete the following information):**
- OS: FreeBSD
- Compiler & Version GCC 10.1
- Compilation mode and/or compiler flags
Default flags.
**Additional context**
https://github.com/Exiv2/exiv2/commit/1ea63ccb345a4498b41cb8842622ba7ecc9fd484 fixed build on arm, ppc needs the same.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 791 | 207,719 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Build fails:
```
clang: error: unknown argument: '-fstack-protector-strong'
```
[Here is a full build log](https://build.macports.org/builders/ports-10.9_x86_64-builder/builds/122447/steps/install-port/logs/stdio)
**To Reproduce**
Build exiv2 0.27.3 on OS X 10.9 with Apple clang from Xcode
**Expected behavior**
successful build
**Desktop (please complete the following information):**
- OS: OS X 10.9
- Compiler & Version: Apple clang 6.0.0.6000057 (from Xcode 6.2)
- Compilation mode and/or compiler flags: n/a
**Additional context**
The problem is the code in your cmake/compilerFlags.cmake which says:
```
if( (COMPILER_IS_GCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 5.0) # Not in GCC 4.8
OR (COMPILER_IS_CLANG AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 3.7) # Not in Clang 3.4.2
)
add_compile_options(-fstack-protector-strong)
endif()
```
Apple clang and open source clang use different version numbering schemes. So even if this flag is supported in open source clang 3.7 and later, the version number of Apple clang in which it was added is a different number. I don't know what that number is specifically, but for comparison, it [built fine on OS X 10.10 with Apple clang 7.0.2.7000181](https://build.macports.org/builders/ports-10.10_x86_64-builder/builds/118954/steps/install-port/logs/stdio) (from Xcode 7.2.1). So it may be that support for this flag was added in Apple clang 7.
But as you see, using compiler version numbers to infer availability of features is brittle. It would be better to actually test the compiler to see whether it supports a flag. | clang: error: unknown argument: '-fstack-protector-strong' | https://api.github.com/repos/Exiv2/exiv2/issues/1243/comments | 16 | 2020-07-09T00:33:35 | "2020-09-04T16:07:54Z" | https://github.com/Exiv2/exiv2/issues/1243 | 653,678,152 | 1,243 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : clang: error: unknown argument: '-fstack-protector-strong'
Issue date:
--- start body ---
**Describe the bug**
Build fails:
```
clang: error: unknown argument: '-fstack-protector-strong'
```
[Here is a full build log](https://build.macports.org/builders/ports-10.9_x86_64-builder/builds/122447/steps/install-port/logs/stdio)
**To Reproduce**
Build exiv2 0.27.3 on OS X 10.9 with Apple clang from Xcode
**Expected behavior**
successful build
**Desktop (please complete the following information):**
- OS: OS X 10.9
- Compiler & Version: Apple clang 6.0.0.6000057 (from Xcode 6.2)
- Compilation mode and/or compiler flags: n/a
**Additional context**
The problem is the code in your cmake/compilerFlags.cmake which says:
```
if( (COMPILER_IS_GCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 5.0) # Not in GCC 4.8
OR (COMPILER_IS_CLANG AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 3.7) # Not in Clang 3.4.2
)
add_compile_options(-fstack-protector-strong)
endif()
```
Apple clang and open source clang use different version numbering schemes. So even if this flag is supported in open source clang 3.7 and later, the version number of Apple clang in which it was added is a different number. I don't know what that number is specifically, but for comparison, it [built fine on OS X 10.10 with Apple clang 7.0.2.7000181](https://build.macports.org/builders/ports-10.10_x86_64-builder/builds/118954/steps/install-port/logs/stdio) (from Xcode 7.2.1). So it may be that support for this flag was added in Apple clang 7.
But as you see, using compiler version numbers to infer availability of features is brittle. It would be better to actually test the compiler to see whether it supports a flag.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,884 | 207,720 |
[
"Exiv2",
"exiv2"
] | Hi,
Thanks a lot for developing exiv2!
I've got a feature request: some cameras can produce depth-data. Can you maybe add code to let one get & add this kind of data?
Regards | depth | https://api.github.com/repos/Exiv2/exiv2/issues/1242/comments | 8 | 2020-07-08T12:23:57 | "2020-07-08T18:30:03Z" | https://github.com/Exiv2/exiv2/issues/1242 | 653,254,340 | 1,242 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : depth
Issue date:
--- start body ---
Hi,
Thanks a lot for developing exiv2!
I've got a feature request: some cameras can produce depth-data. Can you maybe add code to let one get & add this kind of data?
Regards
--- end body ---
comments :
--- start comments ---
--- end comments --- | 351 | 207,721 |
[
"Exiv2",
"exiv2"
] | Hello Exiv2 team!
The main menu of the website displays two different links to access the API documentation:
- a direct link to the API documentation page (which works)
- an API drop-down list that does not work (the link always returns to the open page)
Note that:
- API dropdown appears in every page
- API direct link appears in the following webpages:
- Getting started
- Download
- What's New
- Metadata
- Makernote
- Manual
and disappears in :
- Examples
- API
I think this mistake sows doubt.
Regards, | Website: API documentation link | https://api.github.com/repos/Exiv2/exiv2/issues/1241/comments | 4 | 2020-07-07T00:39:11 | "2020-07-08T18:11:59Z" | https://github.com/Exiv2/exiv2/issues/1241 | 651,902,562 | 1,241 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Website: API documentation link
Issue date:
--- start body ---
Hello Exiv2 team!
The main menu of the website displays two different links to access the API documentation:
- a direct link to the API documentation page (which works)
- an API drop-down list that does not work (the link always returns to the open page)
Note that:
- API dropdown appears in every page
- API direct link appears in the following webpages:
- Getting started
- Download
- What's New
- Metadata
- Makernote
- Manual
and disappears in :
- Examples
- API
I think this mistake sows doubt.
Regards,
--- end body ---
comments :
--- start comments ---
--- end comments --- | 743 | 207,722 |
[
"Exiv2",
"exiv2"
] | Hello,
I would like to report a small mistake: under Linux, the Exiv2::versionString() function of Exiv2 v0.27.3 returns wrong information: "0.27.2".
Thanks to the whole development team.
Regards, | Exiv2 v0.27.3: versionString() function return 0.27.2 | https://api.github.com/repos/Exiv2/exiv2/issues/1240/comments | 3 | 2020-07-06T23:55:49 | "2020-07-07T22:01:31Z" | https://github.com/Exiv2/exiv2/issues/1240 | 651,888,128 | 1,240 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Exiv2 v0.27.3: versionString() function return 0.27.2
Issue date:
--- start body ---
Hello,
I would like to report a small mistake: under Linux, the Exiv2::versionString() function of Exiv2 v0.27.3 returns wrong information: "0.27.2".
Thanks to the whole development team.
Regards,
--- end body ---
comments :
--- start comments ---
--- end comments --- | 417 | 207,723 |
[
"Exiv2",
"exiv2"
] | Hello, i am using Exiv2 in a C++ project, and am having some issues persisting the icc profile, i am copying metadata from one image to a new one as explained in the example on the website, however i lose the icc color profile. Now i found the function to set the color profile and check if it is defined.
```
if (!writeImg->iccProfileDefined()) {
std::cerr << "No embedded iccProfile: " << std::endl;
} else {
if (readImg->iccProfile()->size_ != 0) {
std::cout << (const char*)writeImg->iccProfile()->pData_ << writeImg->iccProfile()->size_ << endl;
writeImg->setIccProfile(*writeImg->iccProfile());
}
}
```
The code runs just fine, and it doesn't complain about the iccProfile, however the output tool when checked with exiftool shows me that iccProfile is not present.
Am i doing something wrong in how i use these functions ? | ICC Profiles in Jpeg 2000 | https://api.github.com/repos/Exiv2/exiv2/issues/1236/comments | 40 | 2020-06-11T15:13:00 | "2020-07-08T14:20:05Z" | https://github.com/Exiv2/exiv2/issues/1236 | 637,098,165 | 1,236 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : ICC Profiles in Jpeg 2000
Issue date:
--- start body ---
Hello, i am using Exiv2 in a C++ project, and am having some issues persisting the icc profile, i am copying metadata from one image to a new one as explained in the example on the website, however i lose the icc color profile. Now i found the function to set the color profile and check if it is defined.
```
if (!writeImg->iccProfileDefined()) {
std::cerr << "No embedded iccProfile: " << std::endl;
} else {
if (readImg->iccProfile()->size_ != 0) {
std::cout << (const char*)writeImg->iccProfile()->pData_ << writeImg->iccProfile()->size_ << endl;
writeImg->setIccProfile(*writeImg->iccProfile());
}
}
```
The code runs just fine, and it doesn't complain about the iccProfile, however the output tool when checked with exiftool shows me that iccProfile is not present.
Am i doing something wrong in how i use these functions ?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,096 | 207,724 |
[
"Exiv2",
"exiv2"
] | I'm developing a Qt 5.7 application on Linux Debian 9 and which uses Exiv2 0.27.2. When I run the `cmake` command to generate the makefile, I get the following error(s):
_CMake Error at src/CMakeLists.txt:30 (add_library):
Target "simphoniz-api" links to target "Iconv::Iconv" but the target was
not found. Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?_
When I successfully compiled Exiv2 as a static library, I get the following messages:
_-- The CXX compiler identification is GNU 6.3.0
-- The C compiler identification is GNU 6.3.0
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Performing Test Iconv_IS_BUILT_IN
-- Performing Test Iconv_IS_BUILT_IN - Success
-- Found Iconv: /usr/lib/x86_64-linux-gnu/libc.so
-- ICONV_INCLUDE_DIR :
-- ICONV_LIBRARIES : /usr/lib/x86_64-linux-gnu/libc.so
-- Looking for gmtime_r
-- Looking for gmtime_r - found
-- Looking for mmap
-- Looking for mmap - found
-- Looking for munmap
-- Looking for munmap - found
-- Looking for strerror_r
-- Looking for strerror_r - found
-- Performing Test EXV_STRERROR_R_CHAR_P
-- Performing Test EXV_STRERROR_R_CHAR_P - Success
-- Looking for C++ include memory.h
-- Looking for C++ include memory.h - found
-- Looking for C++ include process.h
-- Looking for C++ include process.h - not found
-- Looking for C++ include stdbool.h
-- Looking for C++ include stdbool.h - found
-- Looking for C++ include stdint.h
-- Looking for C++ include stdint.h - found
-- Looking for C++ include strings.h
-- Looking for C++ include strings.h - found
-- Looking for C++ include sys/stat.h
-- Looking for C++ include sys/stat.h - found
-- Looking for C++ include sys/types.h
-- Looking for C++ include sys/types.h - found
-- Looking for C++ include inttypes.h
-- Looking for C++ include inttypes.h - found
-- Looking for C++ include unistd.h
-- Looking for C++ include unistd.h - found
-- Looking for C++ include sys/mman.h
-- Looking for C++ include sys/mman.h - found
-- Looking for C++ include regex.h
-- Looking for C++ include regex.h - found
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Install prefix: /home/erwan/git/simphoniz/external/build/external
...
-- Compiler info: GNU (/usr/bin/c++) ; version: 6.3.0
-- Building shared library: NO
-- Building PNG support: NO
-- XMP metadata support: NO
-- Native language support: NO
-- Conversion of Windows XP tags: YES
-- Nikon lens database: YES
-- Building video support: NO
-- Building webready support: NO
-- Building exiv2 command: YES
-- Building samples: NO
-- Building PO files: NO
-- Building unit tests: NO
-- Building doc: NO
-- Building with coverage flags: NO
-- Using ccache: NO_
It seems that the problem comes from the libiconv library but I don't see why... Please, can you tell me what can be wrong with my configuration ? Thank you very much for your help. | 'cmake' command fails when Exiv2 built as static | https://api.github.com/repos/Exiv2/exiv2/issues/1230/comments | 12 | 2020-06-06T23:18:05 | "2023-07-05T21:14:16Z" | https://github.com/Exiv2/exiv2/issues/1230 | 632,805,342 | 1,230 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : 'cmake' command fails when Exiv2 built as static
Issue date:
--- start body ---
I'm developing a Qt 5.7 application on Linux Debian 9 and which uses Exiv2 0.27.2. When I run the `cmake` command to generate the makefile, I get the following error(s):
_CMake Error at src/CMakeLists.txt:30 (add_library):
Target "simphoniz-api" links to target "Iconv::Iconv" but the target was
not found. Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?_
When I successfully compiled Exiv2 as a static library, I get the following messages:
_-- The CXX compiler identification is GNU 6.3.0
-- The C compiler identification is GNU 6.3.0
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Performing Test Iconv_IS_BUILT_IN
-- Performing Test Iconv_IS_BUILT_IN - Success
-- Found Iconv: /usr/lib/x86_64-linux-gnu/libc.so
-- ICONV_INCLUDE_DIR :
-- ICONV_LIBRARIES : /usr/lib/x86_64-linux-gnu/libc.so
-- Looking for gmtime_r
-- Looking for gmtime_r - found
-- Looking for mmap
-- Looking for mmap - found
-- Looking for munmap
-- Looking for munmap - found
-- Looking for strerror_r
-- Looking for strerror_r - found
-- Performing Test EXV_STRERROR_R_CHAR_P
-- Performing Test EXV_STRERROR_R_CHAR_P - Success
-- Looking for C++ include memory.h
-- Looking for C++ include memory.h - found
-- Looking for C++ include process.h
-- Looking for C++ include process.h - not found
-- Looking for C++ include stdbool.h
-- Looking for C++ include stdbool.h - found
-- Looking for C++ include stdint.h
-- Looking for C++ include stdint.h - found
-- Looking for C++ include strings.h
-- Looking for C++ include strings.h - found
-- Looking for C++ include sys/stat.h
-- Looking for C++ include sys/stat.h - found
-- Looking for C++ include sys/types.h
-- Looking for C++ include sys/types.h - found
-- Looking for C++ include inttypes.h
-- Looking for C++ include inttypes.h - found
-- Looking for C++ include unistd.h
-- Looking for C++ include unistd.h - found
-- Looking for C++ include sys/mman.h
-- Looking for C++ include sys/mman.h - found
-- Looking for C++ include regex.h
-- Looking for C++ include regex.h - found
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Install prefix: /home/erwan/git/simphoniz/external/build/external
...
-- Compiler info: GNU (/usr/bin/c++) ; version: 6.3.0
-- Building shared library: NO
-- Building PNG support: NO
-- XMP metadata support: NO
-- Native language support: NO
-- Conversion of Windows XP tags: YES
-- Nikon lens database: YES
-- Building video support: NO
-- Building webready support: NO
-- Building exiv2 command: YES
-- Building samples: NO
-- Building PO files: NO
-- Building unit tests: NO
-- Building doc: NO
-- Building with coverage flags: NO
-- Using ccache: NO_
It seems that the problem comes from the libiconv library but I don't see why... Please, can you tell me what can be wrong with my configuration ? Thank you very much for your help.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,455 | 207,725 |
[
"Exiv2",
"exiv2"
] | **Is your feature request related to a problem? Please describe.**
Exiv2 does not support ISOBMFF format, therefore doesn't support AVIF, HEIF, CR3 and possibly other filetypes using this format
**Describe the solution you'd like**
Ideally - ISOBMFF format support, at least reading data from it :)
**Describe alternatives you've considered**
ExifTool and couple other open source projects already support ISOBMFF based files, however exiv2 still doesn't.
**Additional context**
Iam fully aware of #1066 - I asked my legal counsel and gethered much needed advice. According to all info I managed to gather, there's no legal issue in creating and using a tool capable of reading data and metadata stored in ISOBMFF containers. Worth noting is the fact that JPEG2000 IS an ISOBMFF based and support for it is present in the library without any issue.
Aditionally, already existing libraries like libavif, libheif, libraw and others already work with ISOBMFF files without legal problems.
The ONLY problematic issue would be not reading but decrypting encrypted (not encoded) data or using proprietary code, which I am sure is not the issue here. | Add support for ISOBMFF Files (AVIF, HEIF, CR3) | https://api.github.com/repos/Exiv2/exiv2/issues/1229/comments | 70 | 2020-06-05T10:26:44 | "2021-04-14T01:02:32Z" | https://github.com/Exiv2/exiv2/issues/1229 | 631,484,908 | 1,229 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add support for ISOBMFF Files (AVIF, HEIF, CR3)
Issue date:
--- start body ---
**Is your feature request related to a problem? Please describe.**
Exiv2 does not support ISOBMFF format, therefore doesn't support AVIF, HEIF, CR3 and possibly other filetypes using this format
**Describe the solution you'd like**
Ideally - ISOBMFF format support, at least reading data from it :)
**Describe alternatives you've considered**
ExifTool and couple other open source projects already support ISOBMFF based files, however exiv2 still doesn't.
**Additional context**
Iam fully aware of #1066 - I asked my legal counsel and gethered much needed advice. According to all info I managed to gather, there's no legal issue in creating and using a tool capable of reading data and metadata stored in ISOBMFF containers. Worth noting is the fact that JPEG2000 IS an ISOBMFF based and support for it is present in the library without any issue.
Aditionally, already existing libraries like libavif, libheif, libraw and others already work with ISOBMFF files without legal problems.
The ONLY problematic issue would be not reading but decrypting encrypted (not encoded) data or using proprietary code, which I am sure is not the issue here.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,370 | 207,726 |
[
"Exiv2",
"exiv2"
] | Hi, I spotted 4 undefined behaviors while fuzzing with UBSan+ASan:
Error type : 5.73884e+21 is outside the range of representable values of type 'long'
Error location : src/types.cpp:782:50
Testcase : ubsan2
Error type : 5.73884e+21 is outside the range of representable values of type 'int'
Error location : src/types.cpp:793:50
Testcase : ubsan2
Error type : 3.29343e+43 is outside the range of representable values of type 'long'
Error location : src/tags_int.cpp:2203:43
Testcase : ubsan2
Error type : -1.00692e+128 is outside the range of representable values of type 'long'
Error location : include/exiv2/value.hpp:1648:34
Testcase : ubsan1
I attach a zip files with the testcases, I'm using the read-metadata.cpp harness in the repo.
[ubsan_violations.zip](https://github.com/Exiv2/exiv2/files/4728421/ubsan_violations.zip)
| UBSan violations | https://api.github.com/repos/Exiv2/exiv2/issues/1228/comments | 4 | 2020-06-04T07:56:14 | "2022-01-31T11:20:17Z" | https://github.com/Exiv2/exiv2/issues/1228 | 630,597,174 | 1,228 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : UBSan violations
Issue date:
--- start body ---
Hi, I spotted 4 undefined behaviors while fuzzing with UBSan+ASan:
Error type : 5.73884e+21 is outside the range of representable values of type 'long'
Error location : src/types.cpp:782:50
Testcase : ubsan2
Error type : 5.73884e+21 is outside the range of representable values of type 'int'
Error location : src/types.cpp:793:50
Testcase : ubsan2
Error type : 3.29343e+43 is outside the range of representable values of type 'long'
Error location : src/tags_int.cpp:2203:43
Testcase : ubsan2
Error type : -1.00692e+128 is outside the range of representable values of type 'long'
Error location : include/exiv2/value.hpp:1648:34
Testcase : ubsan1
I attach a zip files with the testcases, I'm using the read-metadata.cpp harness in the repo.
[ubsan_violations.zip](https://github.com/Exiv2/exiv2/files/4728421/ubsan_violations.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,069 | 207,727 |
[
"Exiv2",
"exiv2"
] | I've documented conan/MinGW and conan/Cygwin as "unsupported" however, it's desirable to get this working. I do not believe there's much wrong.
On both MinGW and Cygwin, `conan install ..` dies when building expat from Expat/2.2.6@pix4d/stable. I believe Expat 2.2.9 is available. Perhaps all that needed is to get Expat from bin crafters instead of pix4d.
One other comment about this. I'd like to put something in README.md about choosing a particular version of a library. The only way I know is to modify conanfile.py. Is that correct, or is there a conan command-line option to override the values in conanfile.py?
```
178 CYGWIN rmills@rmillsmm-w10:/cygdrive/c/temp $ conan --version
Conan version 1.25.2
179 CYGWIN rmills@rmillsmm-w10:/cygdrive/c/temp $ mkdir -p ~/.conan/profiles
180 CYGWIN rmills@rmillsmm-w10:/cygdrive/c/temp $ cp /cygdrive/c/msys64/home/rmills/.conan/profiles/default ~/.conan/profiles/
181 CYGWIN rmills@rmillsmm-w10:/cygdrive/c/temp $ cd ~/gnu/github/exiv2/0.27-maintenance/
182 CYGWIN rmills@rmillsmm-w10:~/gnu/github/exiv2/0.27-maintenance $ rm -rf build ; mkdir build ; cd build
183 CYGWIN rmills@rmillsmm-w10:~/gnu/github/exiv2/0.27-maintenance/build $ conan install .. --build missing
WARN: Remotes registry file missing, creating default one in /home/rmills/.conan/remotes.json
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=7.4
os=Windows
os_build=Windows
[options]
[build_requires]
[env]
zlib/1.2.11@conan/stable: Not found in local cache, looking in remotes...
zlib/1.2.11@conan/stable: Trying with 'conan-center'...
Downloading conanmanifest.txt completed [0.29k]
Downloading conanfile.py completed [8.74k]
Downloading conan_export.tgz completed [0.75k]
Decompressing conan_export.tgz completed [0.00k]
zlib/1.2.11@conan/stable: Downloaded recipe revision 0
gtest/1.8.1@bincrafters/stable: Not found in local cache, looking in remotes...
gtest/1.8.1@bincrafters/stable: Trying with 'conan-center'...
Downloading conanmanifest.txt completed [0.35k]
Downloading conanfile.py completed [4.04k]
Downloading conan_export.tgz completed [0.74k]
Decompressing conan_export.tgz completed [0.00k]
gtest/1.8.1@bincrafters/stable: Downloaded recipe revision 0
Expat/2.2.6@pix4d/stable: Not found in local cache, looking in remotes...
Expat/2.2.6@pix4d/stable: Trying with 'conan-center'...
Downloading conanmanifest.txt completed [0.06k]
Downloading conanfile.py completed [2.32k]
Expat/2.2.6@pix4d/stable: Downloaded recipe revision 0
conanfile.py: Installing package
Requirements
Expat/2.2.6@pix4d/stable from 'conan-center' - Downloaded
gtest/1.8.1@bincrafters/stable from 'conan-center' - Downloaded
zlib/1.2.11@conan/stable from 'conan-center' - Downloaded
Packages
Expat/2.2.6@pix4d/stable:0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec - Build
gtest/1.8.1@bincrafters/stable:1c2aa22f809d15d8acc6ccaf40aeace3ce6b2fb9 - Build
zlib/1.2.11@conan/stable:dde8c9806fd70dcbba38b475531e2020efa1e6c0 - Build
Installing (downloading, building) binaries...
Expat/2.2.6@pix4d/stable: Configuring sources in /home/rmills/.conan/data/Expat/2.2.6/pix4d/stable/source
Cloning into 'libexpat'...
Note: switching to '39e487da353b20bb3a724311d179ba0fddffc65b'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
Expat/2.2.6@pix4d/stable: Copying sources to build folder
Expat/2.2.6@pix4d/stable: Building your package in /home/rmills/.conan/data/Expat/2.2.6/pix4d/stable/build/0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec
Expat/2.2.6@pix4d/stable: Generator cmake created conanbuildinfo.cmake
Expat/2.2.6@pix4d/stable: Calling build()
CMake Error: Could not create named generator MinGW Makefiles
Generators
* Unix Makefiles = Generates standard UNIX makefiles.
Ninja = Generates build.ninja files.
CodeBlocks - Ninja = Generates CodeBlocks project files.
CodeBlocks - Unix Makefiles = Generates CodeBlocks project files.
CodeLite - Ninja = Generates CodeLite project files.
CodeLite - Unix Makefiles = Generates CodeLite project files.
Sublime Text 2 - Ninja = Generates Sublime Text 2 project files.
Sublime Text 2 - Unix Makefiles
= Generates Sublime Text 2 project files.
Kate - Ninja = Generates Kate project files.
Kate - Unix Makefiles = Generates Kate project files.
Eclipse CDT4 - Ninja = Generates Eclipse CDT 4.0 project files.
Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.
Expat/2.2.6@pix4d/stable:
Expat/2.2.6@pix4d/stable: ERROR: Package '0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec' build failed
Expat/2.2.6@pix4d/stable: WARN: Build folder /home/rmills/.conan/data/Expat/2.2.6/pix4d/stable/build/0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec
ERROR: Expat/2.2.6@pix4d/stable: Error in build() method, line 45
cmake.configure(source_dir="../libexpat/expat", build_dir="build", defs=cmake_args)
ConanException: Error 1 while executing cd 'build' && cmake -G "MinGW Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="7.4" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/rmills/.conan/data/Expat/2.2.6/pix4d/stable/package/0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -Wno-dev -DBUILD_doc="OFF" -DBUILD_examples="OFF" -DBUILD_shared="False" -DBUILD_tests="OFF" -DBUILD_tools="OFF" -DCMAKE_POSITION_INDEPENDENT_CODE="ON" -DCMAKE_DEBUG_POSTFIX="" -DMSVC_USE_STATIC_CRT="False" '../libexpat/expat'
184 CYGWIN rmills@rmillsmm-w10:~/gnu/github/exiv2/0.27-maintenance/build $
```
| Build with conan on MinGW and Cygwin | https://api.github.com/repos/Exiv2/exiv2/issues/1224/comments | 4 | 2020-05-30T17:19:20 | "2021-04-11T17:44:54Z" | https://github.com/Exiv2/exiv2/issues/1224 | 627,778,074 | 1,224 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Build with conan on MinGW and Cygwin
Issue date:
--- start body ---
I've documented conan/MinGW and conan/Cygwin as "unsupported" however, it's desirable to get this working. I do not believe there's much wrong.
On both MinGW and Cygwin, `conan install ..` dies when building expat from Expat/2.2.6@pix4d/stable. I believe Expat 2.2.9 is available. Perhaps all that needed is to get Expat from bin crafters instead of pix4d.
One other comment about this. I'd like to put something in README.md about choosing a particular version of a library. The only way I know is to modify conanfile.py. Is that correct, or is there a conan command-line option to override the values in conanfile.py?
```
178 CYGWIN rmills@rmillsmm-w10:/cygdrive/c/temp $ conan --version
Conan version 1.25.2
179 CYGWIN rmills@rmillsmm-w10:/cygdrive/c/temp $ mkdir -p ~/.conan/profiles
180 CYGWIN rmills@rmillsmm-w10:/cygdrive/c/temp $ cp /cygdrive/c/msys64/home/rmills/.conan/profiles/default ~/.conan/profiles/
181 CYGWIN rmills@rmillsmm-w10:/cygdrive/c/temp $ cd ~/gnu/github/exiv2/0.27-maintenance/
182 CYGWIN rmills@rmillsmm-w10:~/gnu/github/exiv2/0.27-maintenance $ rm -rf build ; mkdir build ; cd build
183 CYGWIN rmills@rmillsmm-w10:~/gnu/github/exiv2/0.27-maintenance/build $ conan install .. --build missing
WARN: Remotes registry file missing, creating default one in /home/rmills/.conan/remotes.json
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=7.4
os=Windows
os_build=Windows
[options]
[build_requires]
[env]
zlib/1.2.11@conan/stable: Not found in local cache, looking in remotes...
zlib/1.2.11@conan/stable: Trying with 'conan-center'...
Downloading conanmanifest.txt completed [0.29k]
Downloading conanfile.py completed [8.74k]
Downloading conan_export.tgz completed [0.75k]
Decompressing conan_export.tgz completed [0.00k]
zlib/1.2.11@conan/stable: Downloaded recipe revision 0
gtest/1.8.1@bincrafters/stable: Not found in local cache, looking in remotes...
gtest/1.8.1@bincrafters/stable: Trying with 'conan-center'...
Downloading conanmanifest.txt completed [0.35k]
Downloading conanfile.py completed [4.04k]
Downloading conan_export.tgz completed [0.74k]
Decompressing conan_export.tgz completed [0.00k]
gtest/1.8.1@bincrafters/stable: Downloaded recipe revision 0
Expat/2.2.6@pix4d/stable: Not found in local cache, looking in remotes...
Expat/2.2.6@pix4d/stable: Trying with 'conan-center'...
Downloading conanmanifest.txt completed [0.06k]
Downloading conanfile.py completed [2.32k]
Expat/2.2.6@pix4d/stable: Downloaded recipe revision 0
conanfile.py: Installing package
Requirements
Expat/2.2.6@pix4d/stable from 'conan-center' - Downloaded
gtest/1.8.1@bincrafters/stable from 'conan-center' - Downloaded
zlib/1.2.11@conan/stable from 'conan-center' - Downloaded
Packages
Expat/2.2.6@pix4d/stable:0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec - Build
gtest/1.8.1@bincrafters/stable:1c2aa22f809d15d8acc6ccaf40aeace3ce6b2fb9 - Build
zlib/1.2.11@conan/stable:dde8c9806fd70dcbba38b475531e2020efa1e6c0 - Build
Installing (downloading, building) binaries...
Expat/2.2.6@pix4d/stable: Configuring sources in /home/rmills/.conan/data/Expat/2.2.6/pix4d/stable/source
Cloning into 'libexpat'...
Note: switching to '39e487da353b20bb3a724311d179ba0fddffc65b'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
Expat/2.2.6@pix4d/stable: Copying sources to build folder
Expat/2.2.6@pix4d/stable: Building your package in /home/rmills/.conan/data/Expat/2.2.6/pix4d/stable/build/0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec
Expat/2.2.6@pix4d/stable: Generator cmake created conanbuildinfo.cmake
Expat/2.2.6@pix4d/stable: Calling build()
CMake Error: Could not create named generator MinGW Makefiles
Generators
* Unix Makefiles = Generates standard UNIX makefiles.
Ninja = Generates build.ninja files.
CodeBlocks - Ninja = Generates CodeBlocks project files.
CodeBlocks - Unix Makefiles = Generates CodeBlocks project files.
CodeLite - Ninja = Generates CodeLite project files.
CodeLite - Unix Makefiles = Generates CodeLite project files.
Sublime Text 2 - Ninja = Generates Sublime Text 2 project files.
Sublime Text 2 - Unix Makefiles
= Generates Sublime Text 2 project files.
Kate - Ninja = Generates Kate project files.
Kate - Unix Makefiles = Generates Kate project files.
Eclipse CDT4 - Ninja = Generates Eclipse CDT 4.0 project files.
Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.
Expat/2.2.6@pix4d/stable:
Expat/2.2.6@pix4d/stable: ERROR: Package '0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec' build failed
Expat/2.2.6@pix4d/stable: WARN: Build folder /home/rmills/.conan/data/Expat/2.2.6/pix4d/stable/build/0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec
ERROR: Expat/2.2.6@pix4d/stable: Error in build() method, line 45
cmake.configure(source_dir="../libexpat/expat", build_dir="build", defs=cmake_args)
ConanException: Error 1 while executing cd 'build' && cmake -G "MinGW Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="7.4" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/rmills/.conan/data/Expat/2.2.6/pix4d/stable/package/0e4a4a07e6e14395689cb75f8c4aa10d823ef6ec" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -Wno-dev -DBUILD_doc="OFF" -DBUILD_examples="OFF" -DBUILD_shared="False" -DBUILD_tests="OFF" -DBUILD_tools="OFF" -DCMAKE_POSITION_INDEPENDENT_CODE="ON" -DCMAKE_DEBUG_POSTFIX="" -DMSVC_USE_STATIC_CRT="False" '../libexpat/expat'
184 CYGWIN rmills@rmillsmm-w10:~/gnu/github/exiv2/0.27-maintenance/build $
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 6,818 | 207,728 |
[
"Exiv2",
"exiv2"
] | Version : commit 356f8627371e10cb8719eba3c45789e67420b10a
OS : Fedora Linux
How to reproduce:
build exiv2 binary with MemorySanitizer, run following command:
`exiv2 ./use-of-uninitialized-value-RegisterNamespace.tiff `
```
==3642951==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7fb8b831729e in XMPMeta::RegisterNamespace(char const*, char const*) /home/henices/tests/exiv2/xmpsdk/src/XMPMeta.cpp:1042:7
#1 0x7fb8b84151ae in StartNamespaceDeclHandler(void*, char const*, char const*) /home/henices/tests/exiv2/xmpsdk/src/ExpatAdapter.cpp:263:2
#2 0x7fb8b6e1c4e1 (/lib64/libexpat.so.1+0x54e1)
#3 0x7fb8b6e1f424 (/lib64/libexpat.so.1+0x8424)
#4 0x7fb8b6e22752 (/lib64/libexpat.so.1+0xb752)
#5 0x7fb8b6e2376f (/lib64/libexpat.so.1+0xc76f)
#6 0x7fb8b6e20c42 (/lib64/libexpat.so.1+0x9c42)
#7 0x7fb8b6e2210d (/lib64/libexpat.so.1+0xb10d)
#8 0x7fb8b6e25e7f in XML_ParseBuffer (/lib64/libexpat.so.1+0xee7f)
#9 0x7fb8b841a2ab in ExpatAdapter::ParseBuffer(void const*, unsigned long, bool) /home/henices/tests/exiv2/xmpsdk/src/ExpatAdapter.cpp:135:11
#10 0x7fb8b82d3919 in ProcessUTF8Portion(XMLParserAdapter*, unsigned char const*, unsigned long, bool) /home/henices/tests/exiv2/xmpsdk/src/XMPMeta-Parse.cpp:1053:39
#11 0x7fb8b82cdff5 in XMPMeta::ParseFromBuffer(char const*, unsigned long, unsigned long) /home/henices/tests/exiv2/xmpsdk/src/XMPMeta-Parse.cpp:1224:23
#12 0x7fb8b81d4d6e in WXMPMeta_ParseFromBuffer_1 /home/henices/tests/exiv2/xmpsdk/src/WXMPMeta.cpp:1274:9
#13 0x7fb8b7c1f5b8 in TXMPMeta<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >::ParseFromBuffer(char const*, unsigned long, unsigned long) /home/henices/tests/exiv2/xmpsdk/include/client-glue/TXMPMeta.incl_cpp:903:2
#14 0x7fb8b7c1edac in TXMPMeta<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >::TXMPMeta(char const*, unsigned long) /home/henices/tests/exiv2/xmpsdk/include/client-glue/TXMPMeta.incl_cpp:169:9
#15 0x7fb8b7c0b730 in Exiv2::XmpParser::decode(Exiv2::XmpData&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /home/henices/tests/exiv2/src/xmp.cpp:606:18
#16 0x7fb8b80c74d0 in Exiv2::Internal::TiffDecoder::decodeXmp(Exiv2::Internal::TiffEntryBase const*) /home/henices/tests/exiv2/src/tiffvisitor_int.cpp:406:17
#17 0x7fb8b80c353e in Exiv2::Internal::TiffDecoder::decodeTiffEntry(Exiv2::Internal::TiffEntryBase const*) /home/henices/tests/exiv2/src/tiffvisitor_int.cpp:550:13
#18 0x7fb8b80c2cd4 in Exiv2::Internal::TiffDecoder::visitEntry(Exiv2::Internal::TiffEntry*) /home/henices/tests/exiv2/src/tiffvisitor_int.cpp:314:9
#19 0x7fb8b7f9bceb in Exiv2::Internal::TiffEntry::doAccept(Exiv2::Internal::TiffVisitor&) /home/henices/tests/exiv2/src/tiffcomposite_int.cpp:895:17
#20 0x7fb8b7f9b9d6 in Exiv2::Internal::TiffComponent::accept(Exiv2::Internal::TiffVisitor&) /home/henices/tests/exiv2/src/tiffcomposite_int.cpp:890:50
#21 0x7fb8b7f9cfe9 in Exiv2::Internal::TiffDirectory::doAccept(Exiv2::Internal::TiffVisitor&) /home/henices/tests/exiv2/src/tiffcomposite_int.cpp:918:19
#22 0x7fb8b7f9b9d6 in Exiv2::Internal::TiffComponent::accept(Exiv2::Internal::TiffVisitor&) /home/henices/tests/exiv2/src/tiffcomposite_int.cpp:890:50
#23 0x7fb8b8048eec in Exiv2::Internal::TiffParserWorker::decode(Exiv2::ExifData&, Exiv2::IptcData&, Exiv2::XmpData&, unsigned char const*, unsigned long, unsigned int, void (Exiv2::Internal::TiffDecoder::* (*)(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned int, Exiv2::Internal::IfdId))(Exiv2::Internal::TiffEntryBase const*), Exiv2::Internal::TiffHeaderBase*) /home/henices/tests/exiv2/src/tiffimage_int.cpp:1622:22
#24 0x7fb8b7a6ccf4 in Exiv2::TiffParser::decode(Exiv2::ExifData&, Exiv2::IptcData&, Exiv2::XmpData&, unsigned char const*, unsigned long) /home/henices/tests/exiv2/src/tiffimage.cpp:260:16
#25 0x7fb8b7a6a9fd in Exiv2::TiffImage::readMetadata() /home/henices/tests/exiv2/src/tiffimage.cpp:187:24
#26 0x699d46 in Action::Print::printSummary() /home/henices/tests/exiv2/src/actions.cpp:260:16
#27 0x698d48 in Action::Print::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /home/henices/tests/exiv2/src/actions.cpp:215:62
#28 0x4a0c5a in main /home/henices/tests/exiv2/src/exiv2.cpp:80:29
#29 0x7fb8b6e861a2 in __libc_start_main (/lib64/libc.so.6+0x271a2)
#30 0x42369d in _start (/home/henices/tests/exiv2/build_msan/bin/exiv2+0x42369d)
Uninitialized value was created by a heap allocation
#0 0x44fa0d in malloc /tmp/llvm-project/compiler-rt/lib/msan/msan_interceptors.cpp:901:3
#1 0x7fb8b6e1c71f (/lib64/libexpat.so.1+0x571f)
SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/henices/tests/exiv2/xmpsdk/src/XMPMeta.cpp:1042:7 in XMPMeta::RegisterNamespace(char const*, char const*)
Exiting
```
Please download testcase in https://github.com/henices/pocs/raw/master/use-of-uninitialized-value-RegisterNamespace.tiff
Thanks.
| use-of-uninitialized-value in XMPMeta::RegisterNamespace | https://api.github.com/repos/Exiv2/exiv2/issues/1223/comments | 35 | 2020-05-29T08:04:47 | "2020-06-04T06:46:36Z" | https://github.com/Exiv2/exiv2/issues/1223 | 627,081,541 | 1,223 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : use-of-uninitialized-value in XMPMeta::RegisterNamespace
Issue date:
--- start body ---
Version : commit 356f8627371e10cb8719eba3c45789e67420b10a
OS : Fedora Linux
How to reproduce:
build exiv2 binary with MemorySanitizer, run following command:
`exiv2 ./use-of-uninitialized-value-RegisterNamespace.tiff `
```
==3642951==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7fb8b831729e in XMPMeta::RegisterNamespace(char const*, char const*) /home/henices/tests/exiv2/xmpsdk/src/XMPMeta.cpp:1042:7
#1 0x7fb8b84151ae in StartNamespaceDeclHandler(void*, char const*, char const*) /home/henices/tests/exiv2/xmpsdk/src/ExpatAdapter.cpp:263:2
#2 0x7fb8b6e1c4e1 (/lib64/libexpat.so.1+0x54e1)
#3 0x7fb8b6e1f424 (/lib64/libexpat.so.1+0x8424)
#4 0x7fb8b6e22752 (/lib64/libexpat.so.1+0xb752)
#5 0x7fb8b6e2376f (/lib64/libexpat.so.1+0xc76f)
#6 0x7fb8b6e20c42 (/lib64/libexpat.so.1+0x9c42)
#7 0x7fb8b6e2210d (/lib64/libexpat.so.1+0xb10d)
#8 0x7fb8b6e25e7f in XML_ParseBuffer (/lib64/libexpat.so.1+0xee7f)
#9 0x7fb8b841a2ab in ExpatAdapter::ParseBuffer(void const*, unsigned long, bool) /home/henices/tests/exiv2/xmpsdk/src/ExpatAdapter.cpp:135:11
#10 0x7fb8b82d3919 in ProcessUTF8Portion(XMLParserAdapter*, unsigned char const*, unsigned long, bool) /home/henices/tests/exiv2/xmpsdk/src/XMPMeta-Parse.cpp:1053:39
#11 0x7fb8b82cdff5 in XMPMeta::ParseFromBuffer(char const*, unsigned long, unsigned long) /home/henices/tests/exiv2/xmpsdk/src/XMPMeta-Parse.cpp:1224:23
#12 0x7fb8b81d4d6e in WXMPMeta_ParseFromBuffer_1 /home/henices/tests/exiv2/xmpsdk/src/WXMPMeta.cpp:1274:9
#13 0x7fb8b7c1f5b8 in TXMPMeta<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >::ParseFromBuffer(char const*, unsigned long, unsigned long) /home/henices/tests/exiv2/xmpsdk/include/client-glue/TXMPMeta.incl_cpp:903:2
#14 0x7fb8b7c1edac in TXMPMeta<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >::TXMPMeta(char const*, unsigned long) /home/henices/tests/exiv2/xmpsdk/include/client-glue/TXMPMeta.incl_cpp:169:9
#15 0x7fb8b7c0b730 in Exiv2::XmpParser::decode(Exiv2::XmpData&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /home/henices/tests/exiv2/src/xmp.cpp:606:18
#16 0x7fb8b80c74d0 in Exiv2::Internal::TiffDecoder::decodeXmp(Exiv2::Internal::TiffEntryBase const*) /home/henices/tests/exiv2/src/tiffvisitor_int.cpp:406:17
#17 0x7fb8b80c353e in Exiv2::Internal::TiffDecoder::decodeTiffEntry(Exiv2::Internal::TiffEntryBase const*) /home/henices/tests/exiv2/src/tiffvisitor_int.cpp:550:13
#18 0x7fb8b80c2cd4 in Exiv2::Internal::TiffDecoder::visitEntry(Exiv2::Internal::TiffEntry*) /home/henices/tests/exiv2/src/tiffvisitor_int.cpp:314:9
#19 0x7fb8b7f9bceb in Exiv2::Internal::TiffEntry::doAccept(Exiv2::Internal::TiffVisitor&) /home/henices/tests/exiv2/src/tiffcomposite_int.cpp:895:17
#20 0x7fb8b7f9b9d6 in Exiv2::Internal::TiffComponent::accept(Exiv2::Internal::TiffVisitor&) /home/henices/tests/exiv2/src/tiffcomposite_int.cpp:890:50
#21 0x7fb8b7f9cfe9 in Exiv2::Internal::TiffDirectory::doAccept(Exiv2::Internal::TiffVisitor&) /home/henices/tests/exiv2/src/tiffcomposite_int.cpp:918:19
#22 0x7fb8b7f9b9d6 in Exiv2::Internal::TiffComponent::accept(Exiv2::Internal::TiffVisitor&) /home/henices/tests/exiv2/src/tiffcomposite_int.cpp:890:50
#23 0x7fb8b8048eec in Exiv2::Internal::TiffParserWorker::decode(Exiv2::ExifData&, Exiv2::IptcData&, Exiv2::XmpData&, unsigned char const*, unsigned long, unsigned int, void (Exiv2::Internal::TiffDecoder::* (*)(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned int, Exiv2::Internal::IfdId))(Exiv2::Internal::TiffEntryBase const*), Exiv2::Internal::TiffHeaderBase*) /home/henices/tests/exiv2/src/tiffimage_int.cpp:1622:22
#24 0x7fb8b7a6ccf4 in Exiv2::TiffParser::decode(Exiv2::ExifData&, Exiv2::IptcData&, Exiv2::XmpData&, unsigned char const*, unsigned long) /home/henices/tests/exiv2/src/tiffimage.cpp:260:16
#25 0x7fb8b7a6a9fd in Exiv2::TiffImage::readMetadata() /home/henices/tests/exiv2/src/tiffimage.cpp:187:24
#26 0x699d46 in Action::Print::printSummary() /home/henices/tests/exiv2/src/actions.cpp:260:16
#27 0x698d48 in Action::Print::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /home/henices/tests/exiv2/src/actions.cpp:215:62
#28 0x4a0c5a in main /home/henices/tests/exiv2/src/exiv2.cpp:80:29
#29 0x7fb8b6e861a2 in __libc_start_main (/lib64/libc.so.6+0x271a2)
#30 0x42369d in _start (/home/henices/tests/exiv2/build_msan/bin/exiv2+0x42369d)
Uninitialized value was created by a heap allocation
#0 0x44fa0d in malloc /tmp/llvm-project/compiler-rt/lib/msan/msan_interceptors.cpp:901:3
#1 0x7fb8b6e1c71f (/lib64/libexpat.so.1+0x571f)
SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/henices/tests/exiv2/xmpsdk/src/XMPMeta.cpp:1042:7 in XMPMeta::RegisterNamespace(char const*, char const*)
Exiting
```
Please download testcase in https://github.com/henices/pocs/raw/master/use-of-uninitialized-value-RegisterNamespace.tiff
Thanks.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 5,429 | 207,729 |
[
"Exiv2",
"exiv2"
] | **On any platform _(except MinGW)_:**
```
...test $ cp data/exiv2-canon-powershot-s40.crw test.crw
...test $ exiv2 -g Original test.crw
Exif.Photo.DateTimeOriginal Ascii 20 2005:04:23 17:54:36
...test $ exiv2 -M'set Exif.Photo.DateTimeOriginal 2020:05:25 13:39:00' test.crw
...test $ exiv2 -g Original test.crw
Exif.Photo.DateTimeOriginal Ascii 20 2020:05:25 13:39:00
$
```
**On MinGW:**
```
...test $ cp data/exiv2-canon-powershot-s40.crw test.crw
...test $ exiv2 -g Original test.crw
Exif.Photo.DateTimeOriginal Ascii 20 2005:04:23 17:54:36
...test $ exiv2 -M'set Exif.Photo.DateTimeOriginal 2020:05:25 13:39:00' test.crw
...test $ exiv2 -g Original test.crw
Exif.Photo.DateTimeOriginal Ascii 20 2106:02:07 06:28:15
$
```
**Discussion**
I've discovered this with the test harness on the final build before Exiv2 v0.27.3 RC2.
I cannot fix this for v0.27.3 because I don't know anything about the CRW format, so this requires considerable work to understand and fix.
**Workaround**
I'm going to modify test/crw-test.sh to omit this part of the test. When this gets fixed in src/crwimage.cpp, we should restore the test.
| CRW set DateTimeOriginal not working correctly on MinGW | https://api.github.com/repos/Exiv2/exiv2/issues/1219/comments | 5 | 2020-05-25T13:06:12 | "2020-05-26T10:44:48Z" | https://github.com/Exiv2/exiv2/issues/1219 | 624,288,993 | 1,219 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : CRW set DateTimeOriginal not working correctly on MinGW
Issue date:
--- start body ---
**On any platform _(except MinGW)_:**
```
...test $ cp data/exiv2-canon-powershot-s40.crw test.crw
...test $ exiv2 -g Original test.crw
Exif.Photo.DateTimeOriginal Ascii 20 2005:04:23 17:54:36
...test $ exiv2 -M'set Exif.Photo.DateTimeOriginal 2020:05:25 13:39:00' test.crw
...test $ exiv2 -g Original test.crw
Exif.Photo.DateTimeOriginal Ascii 20 2020:05:25 13:39:00
$
```
**On MinGW:**
```
...test $ cp data/exiv2-canon-powershot-s40.crw test.crw
...test $ exiv2 -g Original test.crw
Exif.Photo.DateTimeOriginal Ascii 20 2005:04:23 17:54:36
...test $ exiv2 -M'set Exif.Photo.DateTimeOriginal 2020:05:25 13:39:00' test.crw
...test $ exiv2 -g Original test.crw
Exif.Photo.DateTimeOriginal Ascii 20 2106:02:07 06:28:15
$
```
**Discussion**
I've discovered this with the test harness on the final build before Exiv2 v0.27.3 RC2.
I cannot fix this for v0.27.3 because I don't know anything about the CRW format, so this requires considerable work to understand and fix.
**Workaround**
I'm going to modify test/crw-test.sh to omit this part of the test. When this gets fixed in src/crwimage.cpp, we should restore the test.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,476 | 207,730 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
CMakeLists from exiv2 does not check if `uninstall` target exists before adding it. This causes conflict in multiple-subdirectory project if any other target has already added same target.
**Expected behavior**
Use proper CMake code
```
if (NOT TARGET uninstall)
# only now add the target
endif()
```
**Desktop (please complete the following information):**
reproducible on any OS
| CMake does not check for duplicates before adding uninstall target | https://api.github.com/repos/Exiv2/exiv2/issues/1217/comments | 7 | 2020-05-22T20:29:11 | "2023-11-04T16:31:17Z" | https://github.com/Exiv2/exiv2/issues/1217 | 623,460,689 | 1,217 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : CMake does not check for duplicates before adding uninstall target
Issue date:
--- start body ---
**Describe the bug**
CMakeLists from exiv2 does not check if `uninstall` target exists before adding it. This causes conflict in multiple-subdirectory project if any other target has already added same target.
**Expected behavior**
Use proper CMake code
```
if (NOT TARGET uninstall)
# only now add the target
endif()
```
**Desktop (please complete the following information):**
reproducible on any OS
--- end body ---
comments :
--- start comments ---
--- end comments --- | 646 | 207,731 |
[
"Exiv2",
"exiv2"
] | **Proposal**
Rewrite the bash scripts in python. The purpose of this proposal is to remove bash from the test suite.
**Design**
The bash scripts are structured. They have a common core in functions.source which we can easily convert to a Python module.
So, `copyFiles a b` becomes `ET.copyFiles('a','b')`
`runTest exiv2 -pa $filename` becomes `ET.runTest("exiv2 -pa %s" % filename)`
ET.runTest() executes a command and returns an array of strings (line-by-line output).
We collect the lines as the test proceeds:
```
r=[]
r=r+ET.runTest("...........")
# And at the end we compare r to test/data/geotag-test.out
ET.reportTest("geotag-test",r)
```
To avoid piping data via grep, cut and other linux utilities, we implement them in python. So:
```
ET.cut(del,field,array-of-strings) returns an array of shorter string
ET.grep("pattern",array-of-strings) returns a shorter array of strings
```
When we test the output with `ET.report()`, when the test fails we write the file tmp/test.out and the output can be inspected with your favourite diff utility.
**Benefits**
1 Cross Platform.
2 Simpler design than tests/system_tests.py.
3 Can be introduced as time permits.
4 No documentation changes!
5 We know the test is identical because we do not touch data/test.out.
6 Eliminate line-ending issues.
7 Eliminate diff, dos2unix, tr, pipes and other unix hackery.
8 Binary output support.
**Effort**
The new scripts can be developed one at a time without breaking anything.
When a test is converted, we replace the code in `foo-test.sh` with `python3 foo-test.py`
The existing scripts can be easily converted to python. We have 25 scripts with 1424 lines of code (average 56 lines/script). This is a one-week job.
**Example**
Here's geotag-test.sh
```
#!/usr/bin/env bash
# Test driver for geotag
source ./functions.source
( cd "$testdir"
printf "geotag" >&3
jpg=FurnaceCreekInn.jpg
gpx=FurnaceCreekInn.gpx
copyTestFiles $jpg $gpx
echo --- show GPSInfo tags ---
runTest exiv2 -pa --grep GPSInfo $jpg
tags=$(runTest exiv2 -Pk --grep GPSInfo $jpg | tr -d '\r') # MSVC puts out cr-lf lines
echo --- deleting the GPSInfo tags
for tag in $tags; do runTest exiv2 -M"del $tag" $jpg; done
runTest exiv2 -pa --grep GPS $jpg
echo --- run geotag ---
runTest geotag -ascii -tz -8:00 $jpg $gpx | cut -d' ' -f 2-
echo --- show GPSInfo tags ---
runTest exiv2 -pa --grep GPSInfo $jpg
) 3>&1 > $results 2>&1
printf "\n"
# ----------------------------------------------------------------------
# Evaluate results
cat $results | tr -d $'\r' > $results-stripped
mv $results-stripped $results
reportTest $results $good
# That's all Folks!
##
```
In python, it'll look something like this:
```
#!/usr/bin/env python3
# Test driver for geotag
import exiv2Test as ET;
r=[]
jpg="FurnaceCreekInn.jpg"
gpx="FurnaceCreekInn.gpx"
t= "geotag-test"
print(t)
r=r+ ET. copyTestFiles(jpg,gpx)
r=r+ ET. echo("--- show GPSInfo tags ---")
r=r+ ET. runTest("exiv2 -pa --grep GPSInfo %s" % jpg)
tags=ET. runTest("exiv2 -Pk --grep GPSInfo %s" % jpg)
r=r+ ET. echo("--- deleting the GPSInfo tags")
for tag in tags:
r=r+ ET. runTest("exiv2 -M'del %s' %s" % (tag,jpg)
r=r+ ET. runTest("exiv2 -pa --grep GPS %s" % jpg)
r=r+ ET. echo("--- run geotag ---")
r=r+ ET. cut(' ',2,ET.runTest("geotag -ascii -tz -8:00 %s %s" % jpg gpx))
r=r+ ET. echo('--- show GPSInfo tags ---')
r=r+ ET. runTest("exiv2 -pa --grep GPSInfo %s" % jpg)
ET.reportTest(r,t)
# That's all Folks!
##
```
| Rewrite the bash scripts in python | https://api.github.com/repos/Exiv2/exiv2/issues/1215/comments | 38 | 2020-05-21T14:50:15 | "2021-03-17T07:35:54Z" | https://github.com/Exiv2/exiv2/issues/1215 | 622,554,443 | 1,215 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Rewrite the bash scripts in python
Issue date:
--- start body ---
**Proposal**
Rewrite the bash scripts in python. The purpose of this proposal is to remove bash from the test suite.
**Design**
The bash scripts are structured. They have a common core in functions.source which we can easily convert to a Python module.
So, `copyFiles a b` becomes `ET.copyFiles('a','b')`
`runTest exiv2 -pa $filename` becomes `ET.runTest("exiv2 -pa %s" % filename)`
ET.runTest() executes a command and returns an array of strings (line-by-line output).
We collect the lines as the test proceeds:
```
r=[]
r=r+ET.runTest("...........")
# And at the end we compare r to test/data/geotag-test.out
ET.reportTest("geotag-test",r)
```
To avoid piping data via grep, cut and other linux utilities, we implement them in python. So:
```
ET.cut(del,field,array-of-strings) returns an array of shorter string
ET.grep("pattern",array-of-strings) returns a shorter array of strings
```
When we test the output with `ET.report()`, when the test fails we write the file tmp/test.out and the output can be inspected with your favourite diff utility.
**Benefits**
1 Cross Platform.
2 Simpler design than tests/system_tests.py.
3 Can be introduced as time permits.
4 No documentation changes!
5 We know the test is identical because we do not touch data/test.out.
6 Eliminate line-ending issues.
7 Eliminate diff, dos2unix, tr, pipes and other unix hackery.
8 Binary output support.
**Effort**
The new scripts can be developed one at a time without breaking anything.
When a test is converted, we replace the code in `foo-test.sh` with `python3 foo-test.py`
The existing scripts can be easily converted to python. We have 25 scripts with 1424 lines of code (average 56 lines/script). This is a one-week job.
**Example**
Here's geotag-test.sh
```
#!/usr/bin/env bash
# Test driver for geotag
source ./functions.source
( cd "$testdir"
printf "geotag" >&3
jpg=FurnaceCreekInn.jpg
gpx=FurnaceCreekInn.gpx
copyTestFiles $jpg $gpx
echo --- show GPSInfo tags ---
runTest exiv2 -pa --grep GPSInfo $jpg
tags=$(runTest exiv2 -Pk --grep GPSInfo $jpg | tr -d '\r') # MSVC puts out cr-lf lines
echo --- deleting the GPSInfo tags
for tag in $tags; do runTest exiv2 -M"del $tag" $jpg; done
runTest exiv2 -pa --grep GPS $jpg
echo --- run geotag ---
runTest geotag -ascii -tz -8:00 $jpg $gpx | cut -d' ' -f 2-
echo --- show GPSInfo tags ---
runTest exiv2 -pa --grep GPSInfo $jpg
) 3>&1 > $results 2>&1
printf "\n"
# ----------------------------------------------------------------------
# Evaluate results
cat $results | tr -d $'\r' > $results-stripped
mv $results-stripped $results
reportTest $results $good
# That's all Folks!
##
```
In python, it'll look something like this:
```
#!/usr/bin/env python3
# Test driver for geotag
import exiv2Test as ET;
r=[]
jpg="FurnaceCreekInn.jpg"
gpx="FurnaceCreekInn.gpx"
t= "geotag-test"
print(t)
r=r+ ET. copyTestFiles(jpg,gpx)
r=r+ ET. echo("--- show GPSInfo tags ---")
r=r+ ET. runTest("exiv2 -pa --grep GPSInfo %s" % jpg)
tags=ET. runTest("exiv2 -Pk --grep GPSInfo %s" % jpg)
r=r+ ET. echo("--- deleting the GPSInfo tags")
for tag in tags:
r=r+ ET. runTest("exiv2 -M'del %s' %s" % (tag,jpg)
r=r+ ET. runTest("exiv2 -pa --grep GPS %s" % jpg)
r=r+ ET. echo("--- run geotag ---")
r=r+ ET. cut(' ',2,ET.runTest("geotag -ascii -tz -8:00 %s %s" % jpg gpx))
r=r+ ET. echo('--- show GPSInfo tags ---')
r=r+ ET. runTest("exiv2 -pa --grep GPSInfo %s" % jpg)
ET.reportTest(r,t)
# That's all Folks!
##
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,105 | 207,732 |
[
"Exiv2",
"exiv2"
] | See #547 and #1210 | Fix #547 in 'master' | https://api.github.com/repos/Exiv2/exiv2/issues/1212/comments | 1 | 2020-05-20T09:00:53 | "2021-04-13T14:18:02Z" | https://github.com/Exiv2/exiv2/issues/1212 | 621,589,117 | 1,212 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Fix #547 in 'master'
Issue date:
--- start body ---
See #547 and #1210
--- end body ---
comments :
--- start comments ---
--- end comments --- | 199 | 207,733 |
[
"Exiv2",
"exiv2"
] | Hi all,
Here is a one-liner patch to support the Sigma Art 85 mm F1.8 F mount lens. The lens number is taken from Sigma's lens catalouge: https://www.sigma-global.com/en/download/lenses/brochures-manuals/
[sigma-art-85mm_f1-4-nikon-f.patch.gz](https://github.com/Exiv2/exiv2/files/4644505/sigma-art-85mm_f1-4-nikon-f.patch.gz)
[_85D6176.exv.gz](https://github.com/Exiv2/exiv2/files/4644508/_85D6176.exv.gz)
| Sigma Art 85 mm F1.4 Nikon F mount support | https://api.github.com/repos/Exiv2/exiv2/issues/1208/comments | 7 | 2020-05-18T14:04:10 | "2020-05-18T19:55:52Z" | https://github.com/Exiv2/exiv2/issues/1208 | 620,237,246 | 1,208 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Sigma Art 85 mm F1.4 Nikon F mount support
Issue date:
--- start body ---
Hi all,
Here is a one-liner patch to support the Sigma Art 85 mm F1.8 F mount lens. The lens number is taken from Sigma's lens catalouge: https://www.sigma-global.com/en/download/lenses/brochures-manuals/
[sigma-art-85mm_f1-4-nikon-f.patch.gz](https://github.com/Exiv2/exiv2/files/4644505/sigma-art-85mm_f1-4-nikon-f.patch.gz)
[_85D6176.exv.gz](https://github.com/Exiv2/exiv2/files/4644508/_85D6176.exv.gz)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 620 | 207,734 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
` const Exiv2::XmpPropertyInfo *pl = Exiv2::XmpProperties::propertyList(prefix);`
returns a valid pointer for all kinds of prefix (dc, xmp, ...) except for "lr" for which the pointer is NULL;
However it doesn't throw any exception (for "1r" I get an exception :)).
**Expected behavior**
Get the list of tags related to "lr":
- hierarchicalSubject
- privateRTKInfo
**Desktop (please complete the following information):**
- OS: Debian 10
- in the context of dt 3.x.x
- libexiv2-14/stable 0.25-4 amd64
- libexiv2-dev/stable 0.25-4 amd64
- libgexiv2-2/stable 0.10.9-1 amd64
| Exiv2::XmpProperties::propertyList() doesn't recognize "lr" prefix | https://api.github.com/repos/Exiv2/exiv2/issues/1206/comments | 24 | 2020-05-10T14:27:06 | "2020-09-08T15:39:44Z" | https://github.com/Exiv2/exiv2/issues/1206 | 615,402,927 | 1,206 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Exiv2::XmpProperties::propertyList() doesn't recognize "lr" prefix
Issue date:
--- start body ---
**Describe the bug**
` const Exiv2::XmpPropertyInfo *pl = Exiv2::XmpProperties::propertyList(prefix);`
returns a valid pointer for all kinds of prefix (dc, xmp, ...) except for "lr" for which the pointer is NULL;
However it doesn't throw any exception (for "1r" I get an exception :)).
**Expected behavior**
Get the list of tags related to "lr":
- hierarchicalSubject
- privateRTKInfo
**Desktop (please complete the following information):**
- OS: Debian 10
- in the context of dt 3.x.x
- libexiv2-14/stable 0.25-4 amd64
- libexiv2-dev/stable 0.25-4 amd64
- libgexiv2-2/stable 0.10.9-1 amd64
--- end body ---
comments :
--- start comments ---
--- end comments --- | 850 | 207,735 |
[
"Exiv2",
"exiv2"
] | I use exiv2 to tag multiple images in batch. When the tags contain special characters, after running the batch, the special characters in the tags are not saved correctly.
The batch command for 2 sample images;
exiv2 -M"set Iptc.Application2.Caption String \"F-OJSE Airbus A330-202 510 AirCalin - Air Calédonie International\"" D:\Temp\20B0004.jpg
exiv2 -M"set Iptc.Application2.Caption String \"PR-RDD Gulfstream G550 5280 Yamandu Empreendimentos e Participações SA\"" D:\Temp\20B0037.jpg
I have used a workaround as below but this is now also causing issues.
exiv2 -M"set Iptc.Application2.Caption String \"F-OJSE Airbus A330-202 510 AirCalin - Air Cal\u00E9donie International\"" D:\Temp\20B0004.jpg
exiv2 -M"set Iptc.Application2.Caption String \"PR-RDD Gulfstream G550 5280 Yamandu Empreendimentos e Participa\u00E7\u00F5es SA\"" D:\Temp\20B0037.jpg
Using exiftool, I can specify the character set as Latin as in below, and this allows the special character to be correctly written and subsequently displayed:
exiftool -charset latin
There is mention in the EXIV2 documentation about "-n" but I cannot seem to locate any samples of this or how to incorporate this encoding in the above command lines.
If someone is able to assist then it will be greatly appreciated.
| IPTC tags with special characters such as ø, ç, õ, etc... | https://api.github.com/repos/Exiv2/exiv2/issues/1203/comments | 4 | 2020-05-09T02:40:33 | "2020-05-10T07:01:38Z" | https://github.com/Exiv2/exiv2/issues/1203 | 615,073,572 | 1,203 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : IPTC tags with special characters such as ø, ç, õ, etc...
Issue date:
--- start body ---
I use exiv2 to tag multiple images in batch. When the tags contain special characters, after running the batch, the special characters in the tags are not saved correctly.
The batch command for 2 sample images;
exiv2 -M"set Iptc.Application2.Caption String \"F-OJSE Airbus A330-202 510 AirCalin - Air Calédonie International\"" D:\Temp\20B0004.jpg
exiv2 -M"set Iptc.Application2.Caption String \"PR-RDD Gulfstream G550 5280 Yamandu Empreendimentos e Participações SA\"" D:\Temp\20B0037.jpg
I have used a workaround as below but this is now also causing issues.
exiv2 -M"set Iptc.Application2.Caption String \"F-OJSE Airbus A330-202 510 AirCalin - Air Cal\u00E9donie International\"" D:\Temp\20B0004.jpg
exiv2 -M"set Iptc.Application2.Caption String \"PR-RDD Gulfstream G550 5280 Yamandu Empreendimentos e Participa\u00E7\u00F5es SA\"" D:\Temp\20B0037.jpg
Using exiftool, I can specify the character set as Latin as in below, and this allows the special character to be correctly written and subsequently displayed:
exiftool -charset latin
There is mention in the EXIV2 documentation about "-n" but I cannot seem to locate any samples of this or how to incorporate this encoding in the above command lines.
If someone is able to assist then it will be greatly appreciated.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,581 | 207,736 |
[
"Exiv2",
"exiv2"
] | This is not really a but. But I could not find a better place, and was said to report it to exiv2 developers.
I am using darktable, which happens to use exiv2 to read exif data.
Tamron SP 70-200 f2.8 Di VC USD (G1) lens is not recognized with canon cameras, at least not with my canon 80D and under Windows 10 64bits.
Lens is identified as "255" lens.
But the lens is listed in lensfun database.
After some research I have been able to config exiv2 to get it working configuring exiv2.ini
under C:\Users\USERNAME\exiv2.ini
This is the entry I created to get it working
[canon]
255=Tamron SP 70-200mm f/2.8 Di VC USD A009
This is the thread where we discussed about the solution
https://discuss.pixls.us/t/my-tamron-lens-is-not-automatically-detected/17939
I suppose that the 255 code is not linked to this lens under canon or something like that.
I report it in case it can be added to the exiv2 lens database for other users in future versions.
If it can be included in next update it would be great, if not, may be it helps other windows users of darktable with this lens. | Tamron SP 70-200mm f/2.8 Di VC USD A009 not correctly identified with lens #255 | https://api.github.com/repos/Exiv2/exiv2/issues/1202/comments | 9 | 2020-05-08T18:30:47 | "2020-05-09T13:21:22Z" | https://github.com/Exiv2/exiv2/issues/1202 | 614,908,555 | 1,202 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Tamron SP 70-200mm f/2.8 Di VC USD A009 not correctly identified with lens #255
Issue date:
--- start body ---
This is not really a but. But I could not find a better place, and was said to report it to exiv2 developers.
I am using darktable, which happens to use exiv2 to read exif data.
Tamron SP 70-200 f2.8 Di VC USD (G1) lens is not recognized with canon cameras, at least not with my canon 80D and under Windows 10 64bits.
Lens is identified as "255" lens.
But the lens is listed in lensfun database.
After some research I have been able to config exiv2 to get it working configuring exiv2.ini
under C:\Users\USERNAME\exiv2.ini
This is the entry I created to get it working
[canon]
255=Tamron SP 70-200mm f/2.8 Di VC USD A009
This is the thread where we discussed about the solution
https://discuss.pixls.us/t/my-tamron-lens-is-not-automatically-detected/17939
I suppose that the 255 code is not linked to this lens under canon or something like that.
I report it in case it can be added to the exiv2 lens database for other users in future versions.
If it can be included in next update it would be great, if not, may be it helps other windows users of darktable with this lens.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,341 | 207,737 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
There is an error in some of the Appveyor jobs when downloading the libcurl dependencies with conan.
```
WARN: libcurl/7.69.1: requirement zlib/1.2.11 overridden by your conanfile to zlib/1.2.11@conan/stable
ERROR: Error loading conanfile at 'c:\Users\appveyor\conanCache\nasm\2.14\_\_\export\conanfile.py': Unable to load conanfile in c:\Users\appveyor\conanCache\nasm\2.14\_\_\export\conanfile.py
File "c:\Users\appveyor\conanCache\nasm\2.14\_\_\export\conanfile.py", line 48
SyntaxError: Non-ASCII character '\xe2' in file c:\Users\appveyor\conanCache\nasm\2.14\_\_\export\conanfile.py on line 48, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
```
**To Reproduce**
Just check some of the Appveyor jobs for the Visual Studio 2013 Images.
**Expected behavior**
Builds should bring the dependencies correctly with conan.
**Desktop (please complete the following information):**
- OS: Windows
- Compiler & Version MSVC 2013
**Additional context**
We could try to download a different version of libcurl, or play with the options of the recipe to determine what's happening. Rarely, the builds are passing for VS 2015 & 2017.
| Fix AppVeyor builds on 0.27-maintenance | https://api.github.com/repos/Exiv2/exiv2/issues/1200/comments | 5 | 2020-05-05T06:06:49 | "2020-05-08T11:15:57Z" | https://github.com/Exiv2/exiv2/issues/1200 | 612,361,032 | 1,200 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Fix AppVeyor builds on 0.27-maintenance
Issue date:
--- start body ---
**Describe the bug**
There is an error in some of the Appveyor jobs when downloading the libcurl dependencies with conan.
```
WARN: libcurl/7.69.1: requirement zlib/1.2.11 overridden by your conanfile to zlib/1.2.11@conan/stable
ERROR: Error loading conanfile at 'c:\Users\appveyor\conanCache\nasm\2.14\_\_\export\conanfile.py': Unable to load conanfile in c:\Users\appveyor\conanCache\nasm\2.14\_\_\export\conanfile.py
File "c:\Users\appveyor\conanCache\nasm\2.14\_\_\export\conanfile.py", line 48
SyntaxError: Non-ASCII character '\xe2' in file c:\Users\appveyor\conanCache\nasm\2.14\_\_\export\conanfile.py on line 48, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
```
**To Reproduce**
Just check some of the Appveyor jobs for the Visual Studio 2013 Images.
**Expected behavior**
Builds should bring the dependencies correctly with conan.
**Desktop (please complete the following information):**
- OS: Windows
- Compiler & Version MSVC 2013
**Additional context**
We could try to download a different version of libcurl, or play with the options of the recipe to determine what's happening. Rarely, the builds are passing for VS 2015 & 2017.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,412 | 207,738 |
[
"Exiv2",
"exiv2"
] | **Describe the solution you'd like**
with current firmware the identification of the lens changed to older firmware, so my request for an update
% exiv2 --version
exiv2 0.27.2
**before (sigma firmware 1.03):**
% exiv2 -pa --grep lens/i ~/Pictures/Import_20200430/20200430-IMG_8228.CR2
Exif.CanonCs.LensType Short 1 Sigma 35mm f/1.4 DG HSM
Exif.CanonCs.Lens Short 3 35.0 mm
Exif.Canon.LensModel Ascii 74 35mm
Exif.Photo.LensSpecification Rational 4 35/1 35/1 0/1 0/1
Exif.Photo.LensModel Ascii 5 35mm
Exif.Photo.LensSerialNumber Ascii 11 0000000000
**after (sigma firmware 2.01):**
% exiv2 -pa --grep lens/i ~/Pictures/Import_20200430_0004/20200430-IMG_7825.JPG
Exif.CanonCs.LensType Short 1 Sigma 18-35mm f/1.8 DC HSM | A
Exif.CanonCs.Lens Short 3 35.0 mm
Exif.Photo.LensSpecification Rational 4 35/1 35/1 0/1 0/1
Exif.Photo.LensModel Ascii 27 35mm F1.4 DG HSM | Art 012
Exif.Photo.LensSerialNumber Ascii 11 0000000000
attached the jpg after update:
| Update request: Sigma 35mm F1.4 DG HSM ART Canon Mount | https://api.github.com/repos/Exiv2/exiv2/issues/1192/comments | 2 | 2020-04-30T17:25:57 | "2020-04-30T18:32:41Z" | https://github.com/Exiv2/exiv2/issues/1192 | 610,256,168 | 1,192 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Update request: Sigma 35mm F1.4 DG HSM ART Canon Mount
Issue date:
--- start body ---
**Describe the solution you'd like**
with current firmware the identification of the lens changed to older firmware, so my request for an update
% exiv2 --version
exiv2 0.27.2
**before (sigma firmware 1.03):**
% exiv2 -pa --grep lens/i ~/Pictures/Import_20200430/20200430-IMG_8228.CR2
Exif.CanonCs.LensType Short 1 Sigma 35mm f/1.4 DG HSM
Exif.CanonCs.Lens Short 3 35.0 mm
Exif.Canon.LensModel Ascii 74 35mm
Exif.Photo.LensSpecification Rational 4 35/1 35/1 0/1 0/1
Exif.Photo.LensModel Ascii 5 35mm
Exif.Photo.LensSerialNumber Ascii 11 0000000000
**after (sigma firmware 2.01):**
% exiv2 -pa --grep lens/i ~/Pictures/Import_20200430_0004/20200430-IMG_7825.JPG
Exif.CanonCs.LensType Short 1 Sigma 18-35mm f/1.8 DC HSM | A
Exif.CanonCs.Lens Short 3 35.0 mm
Exif.Photo.LensSpecification Rational 4 35/1 35/1 0/1 0/1
Exif.Photo.LensModel Ascii 27 35mm F1.4 DG HSM | Art 012
Exif.Photo.LensSerialNumber Ascii 11 0000000000
attached the jpg after update:
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,628 | 207,739 |
[
"Exiv2",
"exiv2"
] | Exiv2 v0.27.3. RC2 is available from: https://exiv2.org
Thank you to Phil, Sridhar, Luis, Kevin, and Andreas S for working with me on the release. As always, thanks to my wife Alison and our cat Lizzie for their support.
Highlights of Exiv2 v0.27.3
* Bug and security fixes
* UNIX suppport
* Support for building with C++11 and C++14
* Revised build and test environments
* Revised documentation
* Improved charset handling in UserComment
* Other improvements
Release notes: https://github.com/Exiv2/exiv2/issues/1018#issuecomment-604539346"
**The future of Exiv2**
What happens to Exiv2 in future is a matter for the community. I returned from retirement to deal with Exiv2 v0.27.3 as progress on v0.28 is glacial.
I am writing a book called Image Metadata <i>and</i> Exiv2 Architecture.
https://clanmills.com/exiv2/book/
I would like to give a talk at LGM in Rennes in May 2021 and run an afternoon work-shop to talk about the book. I will be 70 in January and will retire after LGM 2021.
I hope the Community at LGM will discuss the future of Exiv2.
| Exiv2 v0.27.3 | _Schedule_ |
|:-- |:-- |
| RC1 | **2020-04-30** |
| RC2 | **2020-05-31** |
| GM | **2020-06-30** |
The GM release be posted on https://exiv2.org
I’d like to thank Phil, Sridhar, Luis, Kevin and Andreas S for working with me on this release. As always, I want to thank my wife Alison and our cat Lizzie for their support.
| | **URL** |
|:-- |:-- |
| _Release notes_ | https://github.com/Exiv2/exiv2/issues/1018#issuecomment-604539346 |
| _Remaining work_ | https://github.com/Exiv2/exiv2/milestone/5 |
I hope that Exiv2 v0.28 will be ready in 2021. Future **dot** v0.27.4 if necessary.
| Exiv2 v0.27.3 Available | https://api.github.com/repos/Exiv2/exiv2/issues/1186/comments | 6 | 2020-04-27T16:44:28 | "2020-08-07T06:52:08Z" | https://github.com/Exiv2/exiv2/issues/1186 | 607,694,650 | 1,186 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Exiv2 v0.27.3 Available
Issue date:
--- start body ---
Exiv2 v0.27.3. RC2 is available from: https://exiv2.org
Thank you to Phil, Sridhar, Luis, Kevin, and Andreas S for working with me on the release. As always, thanks to my wife Alison and our cat Lizzie for their support.
Highlights of Exiv2 v0.27.3
* Bug and security fixes
* UNIX suppport
* Support for building with C++11 and C++14
* Revised build and test environments
* Revised documentation
* Improved charset handling in UserComment
* Other improvements
Release notes: https://github.com/Exiv2/exiv2/issues/1018#issuecomment-604539346"
**The future of Exiv2**
What happens to Exiv2 in future is a matter for the community. I returned from retirement to deal with Exiv2 v0.27.3 as progress on v0.28 is glacial.
I am writing a book called Image Metadata <i>and</i> Exiv2 Architecture.
https://clanmills.com/exiv2/book/
I would like to give a talk at LGM in Rennes in May 2021 and run an afternoon work-shop to talk about the book. I will be 70 in January and will retire after LGM 2021.
I hope the Community at LGM will discuss the future of Exiv2.
| Exiv2 v0.27.3 | _Schedule_ |
|:-- |:-- |
| RC1 | **2020-04-30** |
| RC2 | **2020-05-31** |
| GM | **2020-06-30** |
The GM release be posted on https://exiv2.org
I’d like to thank Phil, Sridhar, Luis, Kevin and Andreas S for working with me on this release. As always, I want to thank my wife Alison and our cat Lizzie for their support.
| | **URL** |
|:-- |:-- |
| _Release notes_ | https://github.com/Exiv2/exiv2/issues/1018#issuecomment-604539346 |
| _Remaining work_ | https://github.com/Exiv2/exiv2/milestone/5 |
I hope that Exiv2 v0.28 will be ready in 2021. Future **dot** v0.27.4 if necessary.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,907 | 207,740 |
[
"Exiv2",
"exiv2"
] | Hello, Exiv2 team!
My respect to Robin for coming out of retirement to carry this project forward 👏
I'm curious if there is a way to do the opposite of the `-t` option.
That is, setting the EXIF creation date based on the file creation date.
It's totally OK if not, just checking I didn't miss it.
| Is there an opposite of `-t` ? | https://api.github.com/repos/Exiv2/exiv2/issues/1182/comments | 1 | 2020-04-25T01:00:14 | "2020-04-25T08:01:34Z" | https://github.com/Exiv2/exiv2/issues/1182 | 606,655,896 | 1,182 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Is there an opposite of `-t` ?
Issue date:
--- start body ---
Hello, Exiv2 team!
My respect to Robin for coming out of retirement to carry this project forward 👏
I'm curious if there is a way to do the opposite of the `-t` option.
That is, setting the EXIF creation date based on the file creation date.
It's totally OK if not, just checking I didn't miss it.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 500 | 207,741 |
[
"Exiv2",
"exiv2"
] | First of all, thanks to all the devs for the epic piece of software!
I've got images shot with an old android phone (galaxy gio). Running those through the `-t` option I get `Failed to parse timestamp` error message.
Here is datetime data from a sample file:
```
$ exiv2 -Pkt 2012-12-22\ 12.37.28.jpg | grep -i datetime
Exif.Image.DateTime 2012-12-22 10:37:28
Exif.Photo.DateTimeOriginal 2012-12-22 10:37:28
Exif.Photo.DateTimeDigitized 2012-12-22 10:37:28
```
So the problem with failed parser are dashes as date separators. Please, consider allowing dash as date separator in `src/actions.cpp :: str2Tm()`.
Here is how I patched it locally (it is exiv2-0.23 in ubuntu 14.04; git master does the same processing though)
```patch
Index: exiv2-0.23/src/actions.cpp
===================================================================
--- exiv2-0.23.orig/src/actions.cpp 2012-03-22 17:19:35.000000000 +0200
+++ exiv2-0.23/src/actions.cpp 2020-04-24 16:55:31.210712814 +0300
@@ -1762,7 +1762,7 @@
{
if (timeStr.length() == 0 || timeStr[0] == ' ') return 1;
if (timeStr.length() < 19) return 2;
- if ( timeStr[4] != ':' || timeStr[7] != ':' || timeStr[10] != ' '
+ if ( timeStr[4] != ':' && timeStr[4] != '-' || timeStr[7] != ':' && timeStr[7] != '-' || timeStr[10] != ' '
|| timeStr[13] != ':' || timeStr[16] != ':') return 3;
if (0 == tm) return 4;
std::memset(tm, 0x0, sizeof(struct tm));
``` | Dash as date separator (0.27->master) | https://api.github.com/repos/Exiv2/exiv2/issues/1180/comments | 7 | 2020-04-24T14:39:18 | "2020-04-30T05:47:54Z" | https://github.com/Exiv2/exiv2/issues/1180 | 606,363,286 | 1,180 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Dash as date separator (0.27->master)
Issue date:
--- start body ---
First of all, thanks to all the devs for the epic piece of software!
I've got images shot with an old android phone (galaxy gio). Running those through the `-t` option I get `Failed to parse timestamp` error message.
Here is datetime data from a sample file:
```
$ exiv2 -Pkt 2012-12-22\ 12.37.28.jpg | grep -i datetime
Exif.Image.DateTime 2012-12-22 10:37:28
Exif.Photo.DateTimeOriginal 2012-12-22 10:37:28
Exif.Photo.DateTimeDigitized 2012-12-22 10:37:28
```
So the problem with failed parser are dashes as date separators. Please, consider allowing dash as date separator in `src/actions.cpp :: str2Tm()`.
Here is how I patched it locally (it is exiv2-0.23 in ubuntu 14.04; git master does the same processing though)
```patch
Index: exiv2-0.23/src/actions.cpp
===================================================================
--- exiv2-0.23.orig/src/actions.cpp 2012-03-22 17:19:35.000000000 +0200
+++ exiv2-0.23/src/actions.cpp 2020-04-24 16:55:31.210712814 +0300
@@ -1762,7 +1762,7 @@
{
if (timeStr.length() == 0 || timeStr[0] == ' ') return 1;
if (timeStr.length() < 19) return 2;
- if ( timeStr[4] != ':' || timeStr[7] != ':' || timeStr[10] != ' '
+ if ( timeStr[4] != ':' && timeStr[4] != '-' || timeStr[7] != ':' && timeStr[7] != '-' || timeStr[10] != ' '
|| timeStr[13] != ':' || timeStr[16] != ':') return 3;
if (0 == tm) return 4;
std::memset(tm, 0x0, sizeof(struct tm));
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,764 | 207,742 |
[
"Exiv2",
"exiv2"
] | The following tests are not run on Unix builds (NetBSD, SunOS, FreeBSD). From test/Makefile:
```
TESTS2 = exifdata-test.sh \
exiv2-test.sh \
imagetest.sh \
iotest.sh \
iptctest.sh \
preview-test.sh \
tiff-test.sh \
write-test.sh \
xmpparser-test.sh
```
I'll investigate an make an assessment.
| Test | Comment |
|:-- |:-- |
| exifdata-test.sh | |
| exiv2-test.sh | |
| imagetest.sh | |
| iotest.sh | |
| iptctest.sh | |
| preview-test.sh | |
| tiff-test.sh | |
| write-test.sh | |
| xmpparser-test.sh | |
| Unix Test Failures for v0.27.3 | https://api.github.com/repos/Exiv2/exiv2/issues/1165/comments | 2 | 2020-04-18T09:22:29 | "2020-05-12T11:45:10Z" | https://github.com/Exiv2/exiv2/issues/1165 | 602,417,961 | 1,165 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Unix Test Failures for v0.27.3
Issue date:
--- start body ---
The following tests are not run on Unix builds (NetBSD, SunOS, FreeBSD). From test/Makefile:
```
TESTS2 = exifdata-test.sh \
exiv2-test.sh \
imagetest.sh \
iotest.sh \
iptctest.sh \
preview-test.sh \
tiff-test.sh \
write-test.sh \
xmpparser-test.sh
```
I'll investigate an make an assessment.
| Test | Comment |
|:-- |:-- |
| exifdata-test.sh | |
| exiv2-test.sh | |
| imagetest.sh | |
| iotest.sh | |
| iptctest.sh | |
| preview-test.sh | |
| tiff-test.sh | |
| write-test.sh | |
| xmpparser-test.sh | |
--- end body ---
comments :
--- start comments ---
--- end comments --- | 859 | 207,743 |
[
"Exiv2",
"exiv2"
] | | Test | Platforms |
|:--- |:--- |
| strError.returnSuccessAfterClosingFile | FreeBSD<br>NetBSD<br>MinGW<br>CYGWIN<br>SunOS |
| strError.doNotRecognizeUnknownError | FreeBSD<br>NetBSD<br>SunOS |
```
./exiv2-0.27.3.1-NetBSD64/logs/build.txt:[ FAILED ] strError.returnSuccessAfterClosingFile
./exiv2-0.27.3.1-NetBSD64/logs/build.txt:[ FAILED ] strError.doNotRecognizeUnknownError
./exiv2-0.27.3.1-MinGW64/logs/build.txt:[ FAILED ] strError.returnSuccessAfterClosingFile
./exiv2-0.27.3.1-CYGWIN64/logs/build.txt:[ FAILED ] strError.returnSuccessAfterClosingFile
./exiv2-0.27.3.1-SunOS64/logs/build.txt:[ FAILED ] strError.returnSuccessAfterClosingFile
./exiv2-0.27.3.1-SunOS64/logs/build.txt:[ FAILED ] strError.doNotRecognizeUnknownError
``` | Unit Test Failures for v0.27.3 | https://api.github.com/repos/Exiv2/exiv2/issues/1164/comments | 0 | 2020-04-18T09:04:04 | "2020-04-20T13:07:43Z" | https://github.com/Exiv2/exiv2/issues/1164 | 602,414,985 | 1,164 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Unit Test Failures for v0.27.3
Issue date:
--- start body ---
| Test | Platforms |
|:--- |:--- |
| strError.returnSuccessAfterClosingFile | FreeBSD<br>NetBSD<br>MinGW<br>CYGWIN<br>SunOS |
| strError.doNotRecognizeUnknownError | FreeBSD<br>NetBSD<br>SunOS |
```
./exiv2-0.27.3.1-NetBSD64/logs/build.txt:[ FAILED ] strError.returnSuccessAfterClosingFile
./exiv2-0.27.3.1-NetBSD64/logs/build.txt:[ FAILED ] strError.doNotRecognizeUnknownError
./exiv2-0.27.3.1-MinGW64/logs/build.txt:[ FAILED ] strError.returnSuccessAfterClosingFile
./exiv2-0.27.3.1-CYGWIN64/logs/build.txt:[ FAILED ] strError.returnSuccessAfterClosingFile
./exiv2-0.27.3.1-SunOS64/logs/build.txt:[ FAILED ] strError.returnSuccessAfterClosingFile
./exiv2-0.27.3.1-SunOS64/logs/build.txt:[ FAILED ] strError.doNotRecognizeUnknownError
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 956 | 207,744 |
[
"Exiv2",
"exiv2"
] | Googletest 1.10.0 requires C++11:
```
In file included from /usr/include/c++/9/type_traits:35,
from /usr/include/gtest/gtest.h:59,
from /home/abuild/rpmbuild/BUILD/exiv2-0.27.2/unitTests/gtestwrapper.h:10,
from /home/abuild/rpmbuild/BUILD/exiv2-0.27.2/unitTests/mainTestRunner.cpp:1:
/usr/include/c++/9/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
32 | #error This file requires compiler and library support \
```
Changing the `CMAKE_CXX_STANDARD` from 98 to 11 allows to also build the test suite.
As far as I can see, this has no effect on the ABI, the only drawback of the change are a lot of auto_ptr deprecation warnings, iff the corresponding warning is enabled. | exiv2 0.27.x / C++98 incompatible with current googletest | https://api.github.com/repos/Exiv2/exiv2/issues/1163/comments | 17 | 2020-04-17T11:22:16 | "2020-04-30T16:37:01Z" | https://github.com/Exiv2/exiv2/issues/1163 | 601,902,728 | 1,163 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : exiv2 0.27.x / C++98 incompatible with current googletest
Issue date:
--- start body ---
Googletest 1.10.0 requires C++11:
```
In file included from /usr/include/c++/9/type_traits:35,
from /usr/include/gtest/gtest.h:59,
from /home/abuild/rpmbuild/BUILD/exiv2-0.27.2/unitTests/gtestwrapper.h:10,
from /home/abuild/rpmbuild/BUILD/exiv2-0.27.2/unitTests/mainTestRunner.cpp:1:
/usr/include/c++/9/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
32 | #error This file requires compiler and library support \
```
Changing the `CMAKE_CXX_STANDARD` from 98 to 11 allows to also build the test suite.
As far as I can see, this has no effect on the ABI, the only drawback of the change are a lot of auto_ptr deprecation warnings, iff the corresponding warning is enabled.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,118 | 207,745 |
[
"Exiv2",
"exiv2"
] | I've run the test suite on Exiv2 v0.27.2 and replaced the dynamic libraries with the 0.27.3.9 versions.
| Platform | 0.27.3 library | 0.27.2 library |
|:-- |:--- |:-- |
| macOS | 5,515,824 libexiv2.0.27.3.9.dylib | 5,269,532 libexiv2.0.27.2.dylib |
| linux | 4,770,184 libexiv2.so.0.27.3.9 | 4,598,328 libexiv2.so.0.27.2 |
| Cygwin | 5,886,262 cygexiv2-27.dll | 5,536,628 cygexiv2-27.dll |
| MSYS | 5,888,692 msys-exiv2-27.dll | 5,535,525 msys-exiv2-27.dll |
| msvc | 5,196,288 exiv2.dll | 5,157,376 exiv2.dll |
**Success**
Suite ran without crashing and with no notable exceptions being reported on all tested platforms. There are of course differences in the output of the test suite as the bugs have been fixed. For example the reporting of GPSLongitude has been changed in 0.27.3.
#890 https://github.com/Exiv2/exiv2/issues/890#issuecomment-613611192 | API Compatibility v0.27.2 vs v0.27.3 | https://api.github.com/repos/Exiv2/exiv2/issues/1160/comments | 0 | 2020-04-14T20:06:45 | "2020-04-14T22:03:09Z" | https://github.com/Exiv2/exiv2/issues/1160 | 599,827,085 | 1,160 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : API Compatibility v0.27.2 vs v0.27.3
Issue date:
--- start body ---
I've run the test suite on Exiv2 v0.27.2 and replaced the dynamic libraries with the 0.27.3.9 versions.
| Platform | 0.27.3 library | 0.27.2 library |
|:-- |:--- |:-- |
| macOS | 5,515,824 libexiv2.0.27.3.9.dylib | 5,269,532 libexiv2.0.27.2.dylib |
| linux | 4,770,184 libexiv2.so.0.27.3.9 | 4,598,328 libexiv2.so.0.27.2 |
| Cygwin | 5,886,262 cygexiv2-27.dll | 5,536,628 cygexiv2-27.dll |
| MSYS | 5,888,692 msys-exiv2-27.dll | 5,535,525 msys-exiv2-27.dll |
| msvc | 5,196,288 exiv2.dll | 5,157,376 exiv2.dll |
**Success**
Suite ran without crashing and with no notable exceptions being reported on all tested platforms. There are of course differences in the output of the test suite as the bugs have been fixed. For example the reporting of GPSLongitude has been changed in 0.27.3.
#890 https://github.com/Exiv2/exiv2/issues/890#issuecomment-613611192
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,095 | 207,746 |
[
"Exiv2",
"exiv2"
] | There's something wrong in samples/CMakeLists.txt with this.
723 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance/samples $ grep pathtest CMakeLists.txt
add_executable( pathtest path-test.cpp ../src/utils.cpp ../src/getopt.cpp)
list(APPEND APPLICATIONS pathtest)
set_target_properties( pathtest PROPERTIES OUTPUT_NAME path-test )
target_include_directories(pathtest PRIVATE ${CMAKE_SOURCE_DIR}/src) # To find utils.hpp
install( TARGETS metacopy pathtest exiv2json RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
This is remarkable. The program 'path-test' is included in the test suite. I've discovered with PR #1157
It's correctly documented in README-SAMPLES.md It isn't mentioned in `releasenotes.txt` or `platform/ReadMe.txt`.
| The sample program path-test(.exe) is being built as pathtest(.exe) | https://api.github.com/repos/Exiv2/exiv2/issues/1158/comments | 1 | 2020-04-13T23:10:21 | "2020-04-14T08:12:38Z" | https://github.com/Exiv2/exiv2/issues/1158 | 599,188,470 | 1,158 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : The sample program path-test(.exe) is being built as pathtest(.exe)
Issue date:
--- start body ---
There's something wrong in samples/CMakeLists.txt with this.
723 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance/samples $ grep pathtest CMakeLists.txt
add_executable( pathtest path-test.cpp ../src/utils.cpp ../src/getopt.cpp)
list(APPEND APPLICATIONS pathtest)
set_target_properties( pathtest PROPERTIES OUTPUT_NAME path-test )
target_include_directories(pathtest PRIVATE ${CMAKE_SOURCE_DIR}/src) # To find utils.hpp
install( TARGETS metacopy pathtest exiv2json RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
This is remarkable. The program 'path-test' is included in the test suite. I've discovered with PR #1157
It's correctly documented in README-SAMPLES.md It isn't mentioned in `releasenotes.txt` or `platform/ReadMe.txt`.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 992 | 207,747 |
[
"Exiv2",
"exiv2"
] | **Is your feature request related to a problem? Please describe.**
If I use my Tamron 17-50mm on my Nikon D7500, darktable does not recognize this lens but instead displays it as "124"
**Describe the solution you'd like**
Add this lens to database. Use this jpeg as a sample.
Note, I used a white image instead of a black one because my camera compresses it much nicer: black was all noise and added up to 5MB.
**Describe alternatives you've considered**
I now select another Tamron 17-50mm by hand.
| Add support for Tamron AF 17-50mm 1:2.8 [IF] A16 LD XR DiII SP for F-Mount | https://api.github.com/repos/Exiv2/exiv2/issues/1155/comments | 5 | 2020-04-13T19:24:17 | "2020-04-14T20:01:16Z" | https://github.com/Exiv2/exiv2/issues/1155 | 599,083,160 | 1,155 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add support for Tamron AF 17-50mm 1:2.8 [IF] A16 LD XR DiII SP for F-Mount
Issue date:
--- start body ---
**Is your feature request related to a problem? Please describe.**
If I use my Tamron 17-50mm on my Nikon D7500, darktable does not recognize this lens but instead displays it as "124"
**Describe the solution you'd like**
Add this lens to database. Use this jpeg as a sample.
Note, I used a white image instead of a black one because my camera compresses it much nicer: black was all noise and added up to 5MB.
**Describe alternatives you've considered**
I now select another Tamron 17-50mm by hand.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 865 | 207,748 |
[
"Exiv2",
"exiv2"
] | See #882 | v0.27 Reduce system calls in FileIo::eof() (master->0.27) | https://api.github.com/repos/Exiv2/exiv2/issues/1154/comments | 1 | 2020-04-11T08:41:45 | "2020-04-30T05:56:29Z" | https://github.com/Exiv2/exiv2/issues/1154 | 598,221,585 | 1,154 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : v0.27 Reduce system calls in FileIo::eof() (master->0.27)
Issue date:
--- start body ---
See #882
--- end body ---
comments :
--- start comments ---
--- end comments --- | 226 | 207,749 |
[
"Exiv2",
"exiv2"
] | This is discussed in #1146.
https://github.com/Exiv2/exiv2/issues/1146#issuecomment-611447010
I think it's being caused by incorrect detection of the platform. On MSYS/native build:
```
$ exiv2 -vVg platform
platform=msys
```
On the cross platform build:
```
$ exiv2 -vVg platform
platform=mingw
```
When both build for the same `platform`, this issue will probably go away.
| Python test suite has errors on MSYS2 when cross compiled from Fedora | https://api.github.com/repos/Exiv2/exiv2/issues/1151/comments | 3 | 2020-04-09T16:52:33 | "2020-04-10T08:45:14Z" | https://github.com/Exiv2/exiv2/issues/1151 | 597,418,115 | 1,151 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Python test suite has errors on MSYS2 when cross compiled from Fedora
Issue date:
--- start body ---
This is discussed in #1146.
https://github.com/Exiv2/exiv2/issues/1146#issuecomment-611447010
I think it's being caused by incorrect detection of the platform. On MSYS/native build:
```
$ exiv2 -vVg platform
platform=msys
```
On the cross platform build:
```
$ exiv2 -vVg platform
platform=mingw
```
When both build for the same `platform`, this issue will probably go away.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 623 | 207,750 |
[
"Exiv2",
"exiv2"
] | macOS 1015.4
exiv2 0.27.2
As title. if so, could you give me some advice or hints?
thanks | Question: is it possible to read, modify, add "TIFFTAG_PHOTOSHOP" "8BIM" in TIFF file? | https://api.github.com/repos/Exiv2/exiv2/issues/1147/comments | 10 | 2020-04-08T06:46:54 | "2020-04-09T11:41:01Z" | https://github.com/Exiv2/exiv2/issues/1147 | 596,347,889 | 1,147 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Question: is it possible to read, modify, add "TIFFTAG_PHOTOSHOP" "8BIM" in TIFF file?
Issue date:
--- start body ---
macOS 1015.4
exiv2 0.27.2
As title. if so, could you give me some advice or hints?
thanks
--- end body ---
comments :
--- start comments ---
--- end comments --- | 342 | 207,751 |
[
"Exiv2",
"exiv2"
] | The new python test suite is failing on MSYS2 when cross compiled on Fedora and running on Windows. This is caused by line-ending mismatches.
This is discussed here: https://github.com/Exiv2/exiv2/issues/922#issuecomment-610275806
I believe it's possible to modify the sample programs to output LF by calling `setmode()` and putting stdout into binary mode. https://stackoverflow.com/questions/5813301/how-c-output-lf-to-stdout-without-being-changed-to-cr-lf
Modifying the code in all our sample programs is a brutal approach when the alternative is to modify the python test suite. The bash test suite is executing correctly as it performs executes `diff` with `diffargs="--strip-trailing-cr"`
I used unix2dos to modify all the python files and was surprised when that fix was not successful. | Forgive line-ending mismatches in the python test suite. | https://api.github.com/repos/Exiv2/exiv2/issues/1146/comments | 4 | 2020-04-07T09:51:05 | "2020-04-09T21:54:00Z" | https://github.com/Exiv2/exiv2/issues/1146 | 595,740,206 | 1,146 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Forgive line-ending mismatches in the python test suite.
Issue date:
--- start body ---
The new python test suite is failing on MSYS2 when cross compiled on Fedora and running on Windows. This is caused by line-ending mismatches.
This is discussed here: https://github.com/Exiv2/exiv2/issues/922#issuecomment-610275806
I believe it's possible to modify the sample programs to output LF by calling `setmode()` and putting stdout into binary mode. https://stackoverflow.com/questions/5813301/how-c-output-lf-to-stdout-without-being-changed-to-cr-lf
Modifying the code in all our sample programs is a brutal approach when the alternative is to modify the python test suite. The bash test suite is executing correctly as it performs executes `diff` with `diffargs="--strip-trailing-cr"`
I used unix2dos to modify all the python files and was surprised when that fix was not successful.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,025 | 207,752 |
[
"Exiv2",
"exiv2"
] | These are documented in `releasenotes/platform/ReadMe.txt` as follows:
```
700 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $ find releasenotes -name ReadMe.txt | xargs grep locale
releasenotes/MinGW/ReadMe.txt:share/locale/ localisation files
releasenotes/Unix/ReadMe.txt:share/locale/ localisation files
releasenotes/Linux/ReadMe.txt:share/locale/ localisation files
releasenotes/Darwin/ReadMe.txt:share/locale/ localisation files
releasenotes/CYGWIN/ReadMe.txt:share/locale/ localisation files
701 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $
```
They are missing in the Exiv2 0.27.2 release bundles.
They are **correctly** not mentioned for platform `msvc` on which localization is not supported. | share/locale directory missing in build bundles | https://api.github.com/repos/Exiv2/exiv2/issues/1132/comments | 1 | 2020-03-31T10:49:45 | "2020-03-31T14:18:57Z" | https://github.com/Exiv2/exiv2/issues/1132 | 591,000,496 | 1,132 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : share/locale directory missing in build bundles
Issue date:
--- start body ---
These are documented in `releasenotes/platform/ReadMe.txt` as follows:
```
700 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $ find releasenotes -name ReadMe.txt | xargs grep locale
releasenotes/MinGW/ReadMe.txt:share/locale/ localisation files
releasenotes/Unix/ReadMe.txt:share/locale/ localisation files
releasenotes/Linux/ReadMe.txt:share/locale/ localisation files
releasenotes/Darwin/ReadMe.txt:share/locale/ localisation files
releasenotes/CYGWIN/ReadMe.txt:share/locale/ localisation files
701 rmills@rmillsmbp:~/gnu/github/exiv2/0.27-maintenance $
```
They are missing in the Exiv2 0.27.2 release bundles.
They are **correctly** not mentioned for platform `msvc` on which localization is not supported.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,100 | 207,753 |
[
"Exiv2",
"exiv2"
] | @cryptomilk has given every encouragement for us to take ownership of our process to handle CVE/security matters. Here's the process for libssh:
https://www.libssh.org/development/security-process/
Here is an email about this from @cryptomilk:
```
One of the issues is that you don't have a documented security process. If
someone opens a public bug with an assigned CVE then something is wrong. I'm
sorry but it is also the fault of exiv2. You don't have a define security
process.
Feel free to copy:
https://www.libssh.org/development/security-process/
If someone opens a bug and you're unsure if it is a security bug or about the
impact, please don't hesitate to ask Red Hat Product Security to help with the
evaluation. The mail address is in the link above.
You should define what is a security issue and what is just a normal bug,
don't let others dictate it. If someone open a bug publicly with a CVE it is
bad practice, point them to the security process.
Low impact bugs don't have to be fixed right away. If someone tells you
otherwise, RH Product Security can help you if you add them to the bug.
Important, only add individuals to security bugs, never mailinglists.
Let me know if I can help with anything regarding security processes.
```
| Define the Security Process for Exiv2 v027-maintenance | https://api.github.com/repos/Exiv2/exiv2/issues/1122/comments | 2 | 2020-03-29T11:51:02 | "2020-10-28T07:22:31Z" | https://github.com/Exiv2/exiv2/issues/1122 | 589,774,499 | 1,122 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Define the Security Process for Exiv2 v027-maintenance
Issue date:
--- start body ---
@cryptomilk has given every encouragement for us to take ownership of our process to handle CVE/security matters. Here's the process for libssh:
https://www.libssh.org/development/security-process/
Here is an email about this from @cryptomilk:
```
One of the issues is that you don't have a documented security process. If
someone opens a public bug with an assigned CVE then something is wrong. I'm
sorry but it is also the fault of exiv2. You don't have a define security
process.
Feel free to copy:
https://www.libssh.org/development/security-process/
If someone opens a bug and you're unsure if it is a security bug or about the
impact, please don't hesitate to ask Red Hat Product Security to help with the
evaluation. The mail address is in the link above.
You should define what is a security issue and what is just a normal bug,
don't let others dictate it. If someone open a bug publicly with a CVE it is
bad practice, point them to the security process.
Low impact bugs don't have to be fixed right away. If someone tells you
otherwise, RH Product Security can help you if you add them to the bug.
Important, only add individuals to security bugs, never mailinglists.
Let me know if I can help with anything regarding security processes.
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,521 | 207,754 |
[
"Exiv2",
"exiv2"
] | Please consider adding Sridhar's github handle as the codeowner for contrib/msvc into a CODEOWNERS file (see https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners). | Add CODEOWNERS (0.27->master) | https://api.github.com/repos/Exiv2/exiv2/issues/1121/comments | 1 | 2020-03-29T10:21:50 | "2020-04-27T09:34:52Z" | https://github.com/Exiv2/exiv2/issues/1121 | 589,760,780 | 1,121 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add CODEOWNERS (0.27->master)
Issue date:
--- start body ---
Please consider adding Sridhar's github handle as the codeowner for contrib/msvc into a CODEOWNERS file (see https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners).
--- end body ---
comments :
--- start comments ---
--- end comments --- | 396 | 207,755 |
[
"Exiv2",
"exiv2"
] | macOS 10.15.3
exiv2-0.27.2
I combine 7 gray(8bit) tiff files into one `source.tiff`(cmyk + 3 alpha channels).
is it possible change `source.tiff`'s 3 alpha channes to spot channels and naming each title.
It looks like `destination.tiff`.
if so, could you give me some advance, hints or examples.
thanks
|source.tiff|using exiv2 library |destination.tiff|
| ------------- |:---:|---|
|cmyk + 3 alpha channels | |cmyk + 3 spot channels|
|c.tiff| |c.tiff|
|m.tiff| |m.tiff|
|y.tiff| -----> |y.tiff|
|k.tiff| |k.tiff|
|a1.tiff (alpha)| |a1.tiff (spot name: my_spot2)|
|a2.tiff (alpha)| |a2.tiff (spot name: my_spot3)|
|a3.tiff (alpha)| |a3.tiff (spot name: my_spot4)|
| Question: about alpha channels in TIFF? | https://api.github.com/repos/Exiv2/exiv2/issues/1109/comments | 8 | 2020-03-23T13:36:21 | "2020-03-28T09:21:54Z" | https://github.com/Exiv2/exiv2/issues/1109 | 586,214,237 | 1,109 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Question: about alpha channels in TIFF?
Issue date:
--- start body ---
macOS 10.15.3
exiv2-0.27.2
I combine 7 gray(8bit) tiff files into one `source.tiff`(cmyk + 3 alpha channels).
is it possible change `source.tiff`'s 3 alpha channes to spot channels and naming each title.
It looks like `destination.tiff`.
if so, could you give me some advance, hints or examples.
thanks
|source.tiff|using exiv2 library |destination.tiff|
| ------------- |:---:|---|
|cmyk + 3 alpha channels | |cmyk + 3 spot channels|
|c.tiff| |c.tiff|
|m.tiff| |m.tiff|
|y.tiff| -----> |y.tiff|
|k.tiff| |k.tiff|
|a1.tiff (alpha)| |a1.tiff (spot name: my_spot2)|
|a2.tiff (alpha)| |a2.tiff (spot name: my_spot3)|
|a3.tiff (alpha)| |a3.tiff (spot name: my_spot4)|
--- end body ---
comments :
--- start comments ---
--- end comments --- | 888 | 207,756 |
[
"Exiv2",
"exiv2"
] | macOS 10.15
I try to build as static library and link to specific static libraries(/opt/libz.a, /opt/libexpat.a, libiconv.a)
Coud I build it with static dependence libraries?
It looks like always link to system libraries(even I set PKG_CONFIG_PATH)
```
CFLAGS="-I/opt/zlib-1.2.11/include -I/opt/expat-2.2.9/include -I/opt/libiconv-1.16/include" \
LDFLAGS="-L/opt/zlib-1.2.11/lib -L/expat-2.2.9/lib -L/opt/libiconv-1.16/lib" \
cmake .. \
-DIconv_INCLUDE_DIR=/opt/libiconv-1.16/include \
-DIconv_LIBRARY=/opt/libiconv-1.16/lib \
-DCMAKE_INSTALL_PREFIX:PATH=/opt/exiv2-0.27.2 \
-DCMAKE_BUILD_TYPE=Release \
-DBUILD_SHARED_LIBS=OFF
``` | Build as static library issue | https://api.github.com/repos/Exiv2/exiv2/issues/1108/comments | 4 | 2020-03-23T01:42:09 | "2020-03-23T14:00:12Z" | https://github.com/Exiv2/exiv2/issues/1108 | 585,870,748 | 1,108 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Build as static library issue
Issue date:
--- start body ---
macOS 10.15
I try to build as static library and link to specific static libraries(/opt/libz.a, /opt/libexpat.a, libiconv.a)
Coud I build it with static dependence libraries?
It looks like always link to system libraries(even I set PKG_CONFIG_PATH)
```
CFLAGS="-I/opt/zlib-1.2.11/include -I/opt/expat-2.2.9/include -I/opt/libiconv-1.16/include" \
LDFLAGS="-L/opt/zlib-1.2.11/lib -L/expat-2.2.9/lib -L/opt/libiconv-1.16/lib" \
cmake .. \
-DIconv_INCLUDE_DIR=/opt/libiconv-1.16/include \
-DIconv_LIBRARY=/opt/libiconv-1.16/lib \
-DCMAKE_INSTALL_PREFIX:PATH=/opt/exiv2-0.27.2 \
-DCMAKE_BUILD_TYPE=Release \
-DBUILD_SHARED_LIBS=OFF
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 840 | 207,757 |
[
"Exiv2",
"exiv2"
] | Context:
see https://discuss.pixls.us/t/art-v1-0-is-out/16103/155
"the official exiv2 version in Mingw seems broken, or at least miscompiled. it seems libexiv2.dll doesn’t properly raise exceptions on error. if I compile it myself, everything works"
The tag 0.27.2 builds ok on Mingw64 even if I get warnings.
As it is rather old, I tried to build 0.27.-maintenance branch commit hash 5360d82c4a64df8d6af21aa212ebe270e13eceb3, hoping to benefit from last updates in metadata decoding.
Unfortunately I get errors.
cmake step:
```
-- The CXX compiler identification is GNU 9.2.0
-- The C compiler identification is GNU 9.2.0
-- Check for working CXX compiler: C:/msys64/mingw64/bin/g++.exe
-- Check for working CXX compiler: C:/msys64/mingw64/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe
-- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found ZLIB: C:/msys64/mingw64/lib/libz.dll.a (found version "1.2.11")
-- Found EXPAT: C:/msys64/mingw64/lib/libexpat.dll.a (found version "2.2.9")
-- Found Iconv: C:/msys64/mingw64/lib/libiconv.dll.a
-- ICONV_INCLUDE_DIR : C:/msys64/mingw64/include
-- ICONV_LIBRARIES : C:/msys64/mingw64/lib/libiconv.dll.a
-- Looking for gmtime_r
-- Looking for gmtime_r - not found
-- Looking for mmap
-- Looking for mmap - not found
-- Looking for munmap
-- Looking for munmap - not found
-- Looking for strerror_r
-- Looking for strerror_r - not found
-- Performing Test EXV_STRERROR_R_CHAR_P
-- Performing Test EXV_STRERROR_R_CHAR_P - Failed
-- Looking for C++ include memory.h
-- Looking for C++ include memory.h - found
-- Looking for C++ include process.h
-- Looking for C++ include process.h - found
-- Looking for C++ include stdbool.h
-- Looking for C++ include stdbool.h - found
-- Looking for C++ include stdint.h
-- Looking for C++ include stdint.h - found
-- Looking for C++ include strings.h
-- Looking for C++ include strings.h - found
-- Looking for C++ include sys/stat.h
-- Looking for C++ include sys/stat.h - found
-- Looking for C++ include sys/types.h
-- Looking for C++ include sys/types.h - found
-- Looking for C++ include inttypes.h
-- Looking for C++ include inttypes.h - found
-- Looking for C++ include unistd.h
-- Looking for C++ include unistd.h - found
-- Looking for C++ include sys/mman.h
-- Looking for C++ include sys/mman.h - not found
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Install prefix: D:/PROGRAMMES/exiv2source/install64
-- ------------------------------------------------------------------
-- CMake Generator: MSYS Makefiles
-- CMAKE_BUILD_TYPE: Release
-- Compiler info: GNU (C:/msys64/mingw64/bin/g++.exe) ; version: 9.2.0
-- --- Compiler flags ---
-- General:
-Wp,-D_GLIBCXX_ASSERTIONS
-Wp,-D_FORTIFY_SOURCE=2
-Wall
-Wcast-align
-Wpointer-arith
-Wformat-security
-Wmissing-format-attribute
-Woverloaded-virtual
-W
-- Extra:
-- Debug: -g3 -gstrict-dwarf -O0
-- Release: -O3 -DNDEBUG
-- RelWithDebInfo: -O2 -g -DNDEBUG
-- MinSizeRel: -Os -DNDEBUG
-- --- Linker flags ---
-- General:
-- Debug:
-- Release:
-- RelWithDebInfo:
-- MinSizeRel:
--
-- Compiler Options
-- Warnings as errors: NO
-- Use extra compiler warning flags: NO
--
-- ------------------------------------------------------------------
-- Building shared library: YES
-- Building PNG support: YES
-- XMP metadata support: YES
-- Native language support: NO
-- Conversion of Windows XP tags: YES
-- Nikon lens database: YES
-- Building video support: NO
-- Building webready support: NO
-- Dynamic runtime override: YES
-- Unicode paths (wstring): NO
-- Building exiv2 command: YES
-- Building samples: YES
-- Building PO files: NO
-- Building unit tests: NO
-- Building doc: NO
-- Building with coverage flags: NO
-- Using ccache: NO
-- ------------------------------------------------------------------
-- WARNING: Deprecated features: EPS, Video, Ssh
-- ------------------------------------------------------------------
-- Configuring done
-- Generating done
CMake Warning:
Manually-specified variables were not used by the project:
WITH_MYFILE_MMAP
```
Errors:
```
[ 48%] Linking CXX shared library ../bin/libexiv2.dll
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(iptc.cpp.obj):iptc.cpp:(.text+0x20f1): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(jpgimage.cpp.obj):jpgimage.cpp:(.text+0x2c1b): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(jpgimage.cpp.obj):jpgimage.cpp:(.text+0x3df6): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(value.cpp.obj):value.cpp:(.text+0x5a1): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(value.cpp.obj):value.cpp:(.text+0x28c1): undefined reference to `__memcpy_chk'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(localtime.c.obj):localtime.c:(.text+0xa2e): undefined reference to `__memcpy_chk'
collect2.exe: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:692 : bin/libexiv2.dll] Erreur 1
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
make[1]: *** [CMakeFiles/Makefile2:281 : src/CMakeFiles/exiv2lib.dir/all] Erreur 2
make[1] : on quitte le répertoire « /d/programmes/exiv2source/build »
make: *** [Makefile:130 : all] Erreur 2
make[1] : on entre dans le répertoire « /d/programmes/exiv2source/build »
make[2] : on entre dans le répertoire « /d/programmes/exiv2source/build »
make[2] : on entre dans le répertoire « /d/programmes/exiv2source/build »
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
[ 10%] Built target exiv2-xmp
[ 24%] Built target exiv2lib_int
make[2] : on entre dans le répertoire « /d/programmes/exiv2source/build »
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
make[2] : on entre dans le répertoire « /d/programmes/exiv2source/build »
[ 25%] Linking CXX shared library ../bin/libexiv2.dll
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(iptc.cpp.obj):iptc.cpp:(.text+0x20f1): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(jpgimage.cpp.obj):jpgimage.cpp:(.text+0x2c1b): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(jpgimage.cpp.obj):jpgimage.cpp:(.text+0x3df6): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(value.cpp.obj):value.cpp:(.text+0x5a1): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(value.cpp.obj):value.cpp:(.text+0x28c1): undefined reference to `__memcpy_chk'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(localtime.c.obj):localtime.c:(.text+0xa2e): undefined reference to `__memcpy_chk'
collect2.exe: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:692 : bin/libexiv2.dll] Erreur 1
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
make[1]: *** [CMakeFiles/Makefile2:281 : src/CMakeFiles/exiv2lib.dir/all] Erreur 2
make[1] : on quitte le répertoire « /d/programmes/exiv2source/build »
make: *** [Makefile:130 : all] Erreur 2
```
Master branch cannot be built either due to other errors, but I understand that API change compared to 0.27 so it is not a concern now.
| Building exiv2 0.27.xxx on MSYS2 | https://api.github.com/repos/Exiv2/exiv2/issues/1102/comments | 17 | 2020-02-15T11:17:37 | "2020-05-06T08:53:29Z" | https://github.com/Exiv2/exiv2/issues/1102 | 565,734,282 | 1,102 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Building exiv2 0.27.xxx on MSYS2
Issue date:
--- start body ---
Context:
see https://discuss.pixls.us/t/art-v1-0-is-out/16103/155
"the official exiv2 version in Mingw seems broken, or at least miscompiled. it seems libexiv2.dll doesn’t properly raise exceptions on error. if I compile it myself, everything works"
The tag 0.27.2 builds ok on Mingw64 even if I get warnings.
As it is rather old, I tried to build 0.27.-maintenance branch commit hash 5360d82c4a64df8d6af21aa212ebe270e13eceb3, hoping to benefit from last updates in metadata decoding.
Unfortunately I get errors.
cmake step:
```
-- The CXX compiler identification is GNU 9.2.0
-- The C compiler identification is GNU 9.2.0
-- Check for working CXX compiler: C:/msys64/mingw64/bin/g++.exe
-- Check for working CXX compiler: C:/msys64/mingw64/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe
-- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found ZLIB: C:/msys64/mingw64/lib/libz.dll.a (found version "1.2.11")
-- Found EXPAT: C:/msys64/mingw64/lib/libexpat.dll.a (found version "2.2.9")
-- Found Iconv: C:/msys64/mingw64/lib/libiconv.dll.a
-- ICONV_INCLUDE_DIR : C:/msys64/mingw64/include
-- ICONV_LIBRARIES : C:/msys64/mingw64/lib/libiconv.dll.a
-- Looking for gmtime_r
-- Looking for gmtime_r - not found
-- Looking for mmap
-- Looking for mmap - not found
-- Looking for munmap
-- Looking for munmap - not found
-- Looking for strerror_r
-- Looking for strerror_r - not found
-- Performing Test EXV_STRERROR_R_CHAR_P
-- Performing Test EXV_STRERROR_R_CHAR_P - Failed
-- Looking for C++ include memory.h
-- Looking for C++ include memory.h - found
-- Looking for C++ include process.h
-- Looking for C++ include process.h - found
-- Looking for C++ include stdbool.h
-- Looking for C++ include stdbool.h - found
-- Looking for C++ include stdint.h
-- Looking for C++ include stdint.h - found
-- Looking for C++ include strings.h
-- Looking for C++ include strings.h - found
-- Looking for C++ include sys/stat.h
-- Looking for C++ include sys/stat.h - found
-- Looking for C++ include sys/types.h
-- Looking for C++ include sys/types.h - found
-- Looking for C++ include inttypes.h
-- Looking for C++ include inttypes.h - found
-- Looking for C++ include unistd.h
-- Looking for C++ include unistd.h - found
-- Looking for C++ include sys/mman.h
-- Looking for C++ include sys/mman.h - not found
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Install prefix: D:/PROGRAMMES/exiv2source/install64
-- ------------------------------------------------------------------
-- CMake Generator: MSYS Makefiles
-- CMAKE_BUILD_TYPE: Release
-- Compiler info: GNU (C:/msys64/mingw64/bin/g++.exe) ; version: 9.2.0
-- --- Compiler flags ---
-- General:
-Wp,-D_GLIBCXX_ASSERTIONS
-Wp,-D_FORTIFY_SOURCE=2
-Wall
-Wcast-align
-Wpointer-arith
-Wformat-security
-Wmissing-format-attribute
-Woverloaded-virtual
-W
-- Extra:
-- Debug: -g3 -gstrict-dwarf -O0
-- Release: -O3 -DNDEBUG
-- RelWithDebInfo: -O2 -g -DNDEBUG
-- MinSizeRel: -Os -DNDEBUG
-- --- Linker flags ---
-- General:
-- Debug:
-- Release:
-- RelWithDebInfo:
-- MinSizeRel:
--
-- Compiler Options
-- Warnings as errors: NO
-- Use extra compiler warning flags: NO
--
-- ------------------------------------------------------------------
-- Building shared library: YES
-- Building PNG support: YES
-- XMP metadata support: YES
-- Native language support: NO
-- Conversion of Windows XP tags: YES
-- Nikon lens database: YES
-- Building video support: NO
-- Building webready support: NO
-- Dynamic runtime override: YES
-- Unicode paths (wstring): NO
-- Building exiv2 command: YES
-- Building samples: YES
-- Building PO files: NO
-- Building unit tests: NO
-- Building doc: NO
-- Building with coverage flags: NO
-- Using ccache: NO
-- ------------------------------------------------------------------
-- WARNING: Deprecated features: EPS, Video, Ssh
-- ------------------------------------------------------------------
-- Configuring done
-- Generating done
CMake Warning:
Manually-specified variables were not used by the project:
WITH_MYFILE_MMAP
```
Errors:
```
[ 48%] Linking CXX shared library ../bin/libexiv2.dll
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(iptc.cpp.obj):iptc.cpp:(.text+0x20f1): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(jpgimage.cpp.obj):jpgimage.cpp:(.text+0x2c1b): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(jpgimage.cpp.obj):jpgimage.cpp:(.text+0x3df6): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(value.cpp.obj):value.cpp:(.text+0x5a1): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(value.cpp.obj):value.cpp:(.text+0x28c1): undefined reference to `__memcpy_chk'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(localtime.c.obj):localtime.c:(.text+0xa2e): undefined reference to `__memcpy_chk'
collect2.exe: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:692 : bin/libexiv2.dll] Erreur 1
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
make[1]: *** [CMakeFiles/Makefile2:281 : src/CMakeFiles/exiv2lib.dir/all] Erreur 2
make[1] : on quitte le répertoire « /d/programmes/exiv2source/build »
make: *** [Makefile:130 : all] Erreur 2
make[1] : on entre dans le répertoire « /d/programmes/exiv2source/build »
make[2] : on entre dans le répertoire « /d/programmes/exiv2source/build »
make[2] : on entre dans le répertoire « /d/programmes/exiv2source/build »
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
[ 10%] Built target exiv2-xmp
[ 24%] Built target exiv2lib_int
make[2] : on entre dans le répertoire « /d/programmes/exiv2source/build »
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
make[2] : on entre dans le répertoire « /d/programmes/exiv2source/build »
[ 25%] Linking CXX shared library ../bin/libexiv2.dll
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(iptc.cpp.obj):iptc.cpp:(.text+0x20f1): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(jpgimage.cpp.obj):jpgimage.cpp:(.text+0x2c1b): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(jpgimage.cpp.obj):jpgimage.cpp:(.text+0x3df6): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(value.cpp.obj):value.cpp:(.text+0x5a1): undefined reference to `__chk_fail'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(value.cpp.obj):value.cpp:(.text+0x28c1): undefined reference to `__memcpy_chk'
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/exiv2lib.dir/objects.a(localtime.c.obj):localtime.c:(.text+0xa2e): undefined reference to `__memcpy_chk'
collect2.exe: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/exiv2lib.dir/build.make:692 : bin/libexiv2.dll] Erreur 1
make[2] : on quitte le répertoire « /d/programmes/exiv2source/build »
make[1]: *** [CMakeFiles/Makefile2:281 : src/CMakeFiles/exiv2lib.dir/all] Erreur 2
make[1] : on quitte le répertoire « /d/programmes/exiv2source/build »
make: *** [Makefile:130 : all] Erreur 2
```
Master branch cannot be built either due to other errors, but I understand that API change compared to 0.27 so it is not a concern now.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 9,607 | 207,758 |
[
"Exiv2",
"exiv2"
] | I try to integrate the exiv2 prebuilt binary from website (MINGW64 shared binaries) into a Qt project. So I unpacked the archive added the BIN directory to my Systems PATH and added it to my ``.pro``-file like this:
```
QT += core gui widgets multimedia sql
TARGET = RawImageDisplayer
TEMPLATE = app
SOURCES += main.cpp \
MainWindow.cpp \
EmbeddedImage.cpp \
exif.cpp \
imagepreview.cpp
HEADERS += MainWindow.h \
EmbeddedImage.h \
exif.h \
imagepreview.h
LIBS += $$quote(D:/_Projekte/ProductionLibraries/exiv2-0.27.2-MinGW64/lib/libexiv2.dll.a)
INCLUDEPATH += $$quote(D:/_Projekte/ProductionLibraries/exiv2-0.27.2-MinGW64/include)
```
When I then try to build my app I get the following error:
```
release/MainWindow.o:MainWindow.cpp:(.text+0x29c): undefined reference to `__imp__ZN5Exiv212ImageFactory4openERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEb'
collect2.exe: error: ld returned 1 exit status
mingw32-make[1]: *** [Makefile.Release:85: release/RawImageDisplayer.exe] Error 1
```
What do I do wrong? I've read that exiv2 is built with c++98, probably something todo with that?
**Desktop (please complete the following information):**
- Windows 10 Pro 64-bit
- Qt 5.12.7 LTS (mingw)
- MinGW 7.3 64-bit version (which was installed with Qt)
- ``gcc version 7.3.0 (x86_64-posix-seh-rev0, Built by MinGW-W64 project)`` | Cannot link exiv2 prebuilt binaries in Qt project | https://api.github.com/repos/Exiv2/exiv2/issues/1101/comments | 47 | 2020-02-14T13:58:28 | "2020-05-19T20:16:09Z" | https://github.com/Exiv2/exiv2/issues/1101 | 565,342,505 | 1,101 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Cannot link exiv2 prebuilt binaries in Qt project
Issue date:
--- start body ---
I try to integrate the exiv2 prebuilt binary from website (MINGW64 shared binaries) into a Qt project. So I unpacked the archive added the BIN directory to my Systems PATH and added it to my ``.pro``-file like this:
```
QT += core gui widgets multimedia sql
TARGET = RawImageDisplayer
TEMPLATE = app
SOURCES += main.cpp \
MainWindow.cpp \
EmbeddedImage.cpp \
exif.cpp \
imagepreview.cpp
HEADERS += MainWindow.h \
EmbeddedImage.h \
exif.h \
imagepreview.h
LIBS += $$quote(D:/_Projekte/ProductionLibraries/exiv2-0.27.2-MinGW64/lib/libexiv2.dll.a)
INCLUDEPATH += $$quote(D:/_Projekte/ProductionLibraries/exiv2-0.27.2-MinGW64/include)
```
When I then try to build my app I get the following error:
```
release/MainWindow.o:MainWindow.cpp:(.text+0x29c): undefined reference to `__imp__ZN5Exiv212ImageFactory4openERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEb'
collect2.exe: error: ld returned 1 exit status
mingw32-make[1]: *** [Makefile.Release:85: release/RawImageDisplayer.exe] Error 1
```
What do I do wrong? I've read that exiv2 is built with c++98, probably something todo with that?
**Desktop (please complete the following information):**
- Windows 10 Pro 64-bit
- Qt 5.12.7 LTS (mingw)
- MinGW 7.3 64-bit version (which was installed with Qt)
- ``gcc version 7.3.0 (x86_64-posix-seh-rev0, Built by MinGW-W64 project)``
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,680 | 207,759 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Another crash found along with #1097 with fuzzing
exiv2 got aborted with the following report:
```
terminate called after throwing an instance of 'std::out_of_range'
what(): basic_string::substr: __pos (which is 18446744073709551615) > this->size() (which is 0)
Aborted (core dumped)
```
**To Reproduce**
./exiv2 -m [exiv2_mo_crash_1.txt](https://github.com/Exiv2/exiv2/files/4185793/exiv2_mo_crash_1.txt) mo [f1.txt](https://github.com/Exiv2/exiv2/files/4185806/f1.txt)
(Just download first exiv2_mo_crash_1.txt file. It seems the second f1.txt file does not matter.)
**Desktop (please complete the following information):**
Ubuntu 16.04, clang 4.0.0
**Additional context**
It seems `parseLine` is passing an empty string to `registerNs` at `exiv2.cpp:1477`
stack trace of the crash execution:
```
#0 0x00007ffff6f0f428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1 0x00007ffff6f1102a in __GI_abort () at abort.c:89
#2 0x00007ffff754984d in __gnu_cxx::__verbose_terminate_handler() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3 0x00007ffff75476b6 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4 0x00007ffff7547701 in std::terminate() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5 0x00007ffff7547919 in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6 0x00007ffff75703f7 in std::__throw_out_of_range_fmt(char const*, ...) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#7 0x00007ffff75dbcf8 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::substr(unsigned long, unsigned long) const ()
from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8 0x00007ffff799c496 in Exiv2::XmpProperties::registerNs (ns="", prefix="Exiff\262.LfkInfo.GPSDa")
at /home/cheong/subjects/exiv2-0.27.2-Source/src/properties.cpp:2508
#9 0x00000000004199b2 in (anonymous namespace)::parseLine (modifyCmd=..., line="reg Exiff\262.LfkInfo.GPSDa \"", num=1)
at /home/cheong/subjects/exiv2-0.27.2-Source/src/exiv2.cpp:1477
#10 0x0000000000418a21 in (anonymous namespace)::parseCmdFiles (modifyCmds=std::vector of length 0, capacity 0,
cmdFiles=std::vector of length 1, capacity 1 = {...}) at /home/cheong/subjects/exiv2-0.27.2-Source/src/exiv2.cpp:1303
#11 0x00000000004175ce in Params::getopt (this=0x65a790, argc=5, Argv=0x7fffffffe328) at /home/cheong/subjects/exiv2-0.27.2-Source/src/exiv2.cpp:1087
#12 0x0000000000412c16 in main (argc=5, argv=0x7fffffffe328) at /home/cheong/subjects/exiv2-0.27.2-Source/src/exiv2.cpp:139
```
Thanks | exiv2 aborts with registerNs | https://api.github.com/repos/Exiv2/exiv2/issues/1099/comments | 2 | 2020-02-11T13:19:41 | "2020-03-28T12:47:28Z" | https://github.com/Exiv2/exiv2/issues/1099 | 563,201,587 | 1,099 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : exiv2 aborts with registerNs
Issue date:
--- start body ---
**Describe the bug**
Another crash found along with #1097 with fuzzing
exiv2 got aborted with the following report:
```
terminate called after throwing an instance of 'std::out_of_range'
what(): basic_string::substr: __pos (which is 18446744073709551615) > this->size() (which is 0)
Aborted (core dumped)
```
**To Reproduce**
./exiv2 -m [exiv2_mo_crash_1.txt](https://github.com/Exiv2/exiv2/files/4185793/exiv2_mo_crash_1.txt) mo [f1.txt](https://github.com/Exiv2/exiv2/files/4185806/f1.txt)
(Just download first exiv2_mo_crash_1.txt file. It seems the second f1.txt file does not matter.)
**Desktop (please complete the following information):**
Ubuntu 16.04, clang 4.0.0
**Additional context**
It seems `parseLine` is passing an empty string to `registerNs` at `exiv2.cpp:1477`
stack trace of the crash execution:
```
#0 0x00007ffff6f0f428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1 0x00007ffff6f1102a in __GI_abort () at abort.c:89
#2 0x00007ffff754984d in __gnu_cxx::__verbose_terminate_handler() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3 0x00007ffff75476b6 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4 0x00007ffff7547701 in std::terminate() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5 0x00007ffff7547919 in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6 0x00007ffff75703f7 in std::__throw_out_of_range_fmt(char const*, ...) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#7 0x00007ffff75dbcf8 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::substr(unsigned long, unsigned long) const ()
from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8 0x00007ffff799c496 in Exiv2::XmpProperties::registerNs (ns="", prefix="Exiff\262.LfkInfo.GPSDa")
at /home/cheong/subjects/exiv2-0.27.2-Source/src/properties.cpp:2508
#9 0x00000000004199b2 in (anonymous namespace)::parseLine (modifyCmd=..., line="reg Exiff\262.LfkInfo.GPSDa \"", num=1)
at /home/cheong/subjects/exiv2-0.27.2-Source/src/exiv2.cpp:1477
#10 0x0000000000418a21 in (anonymous namespace)::parseCmdFiles (modifyCmds=std::vector of length 0, capacity 0,
cmdFiles=std::vector of length 1, capacity 1 = {...}) at /home/cheong/subjects/exiv2-0.27.2-Source/src/exiv2.cpp:1303
#11 0x00000000004175ce in Params::getopt (this=0x65a790, argc=5, Argv=0x7fffffffe328) at /home/cheong/subjects/exiv2-0.27.2-Source/src/exiv2.cpp:1087
#12 0x0000000000412c16 in main (argc=5, argv=0x7fffffffe328) at /home/cheong/subjects/exiv2-0.27.2-Source/src/exiv2.cpp:139
```
Thanks
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,782 | 207,760 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Hi, we are currently working on fuzzing to automatically generate test cases, and we found a crash of exiv2 with pr flag.
**To Reproduce**
Running following command lead to crash:
`./exiv2 pr <attatched file>`
[exiv2_pr_crash.txt](https://github.com/Exiv2/exiv2/files/4184184/exiv2_pr_crash.txt)
I used 0.27.2 release version of exiv2.
**Desktop (please complete the following information):**
Ubuntu 16.04, clang 4.0.0
**Additional context**
This is call stack of the crashed execution:
```
#0 0x0000555555db5bd9 in Exiv2::Slice<unsigned char const*>::Slice(unsigned char const*, unsigned long, unsigned long) ()
#1 0x0000555555de05d3 in Exiv2::Slice<unsigned char const*> Exiv2::makeSliceUntil<unsigned char const>(unsigned char const*, unsigned long) ()
#2 0x0000555555877a84 in Exiv2::getUShort(unsigned char const*, Exiv2::ByteOrder) ()
#3 0x0000555555a4707c in Exiv2::Internal::CiffComponent::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#4 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#5 0x0000555555a4d879 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) ()
#6 0x0000555555a4b796 in Exiv2::Internal::CiffDirectory::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#7 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#8 0x0000555555a4d879 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) ()
#9 0x0000555555a4b796 in Exiv2::Internal::CiffDirectory::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#10 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
...
#87306 0x0000555555a4b796 in Exiv2::Internal::CiffDirectory::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#87307 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#87308 0x0000555555a4d879 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) ()
#87309 0x0000555555a4b796 in Exiv2::Internal::CiffDirectory::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#87310 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#87311 0x0000555555a4d879 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) ()
#87312 0x0000555555a646d6 in Exiv2::Internal::CiffHeader::read(unsigned char const*, unsigned int) ()
#87313 0x00005555559dd417 in Exiv2::CrwParser::decode(Exiv2::CrwImage*, unsigned char const*, unsigned int) ()
#87314 0x00005555559d95d1 in Exiv2::CrwImage::readMetadata() ()
#87315 0x0000555555646c65 in Action::Print::printSummary() ()
#87316 0x000055555564600d in Action::Print::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ()
#87317 0x000055555562660b in main ()
```
Thanks. | Segfault of exiv2 with pr flag | https://api.github.com/repos/Exiv2/exiv2/issues/1097/comments | 4 | 2020-02-11T05:22:10 | "2020-03-27T16:32:33Z" | https://github.com/Exiv2/exiv2/issues/1097 | 562,984,583 | 1,097 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Segfault of exiv2 with pr flag
Issue date:
--- start body ---
**Describe the bug**
Hi, we are currently working on fuzzing to automatically generate test cases, and we found a crash of exiv2 with pr flag.
**To Reproduce**
Running following command lead to crash:
`./exiv2 pr <attatched file>`
[exiv2_pr_crash.txt](https://github.com/Exiv2/exiv2/files/4184184/exiv2_pr_crash.txt)
I used 0.27.2 release version of exiv2.
**Desktop (please complete the following information):**
Ubuntu 16.04, clang 4.0.0
**Additional context**
This is call stack of the crashed execution:
```
#0 0x0000555555db5bd9 in Exiv2::Slice<unsigned char const*>::Slice(unsigned char const*, unsigned long, unsigned long) ()
#1 0x0000555555de05d3 in Exiv2::Slice<unsigned char const*> Exiv2::makeSliceUntil<unsigned char const>(unsigned char const*, unsigned long) ()
#2 0x0000555555877a84 in Exiv2::getUShort(unsigned char const*, Exiv2::ByteOrder) ()
#3 0x0000555555a4707c in Exiv2::Internal::CiffComponent::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#4 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#5 0x0000555555a4d879 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) ()
#6 0x0000555555a4b796 in Exiv2::Internal::CiffDirectory::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#7 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#8 0x0000555555a4d879 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) ()
#9 0x0000555555a4b796 in Exiv2::Internal::CiffDirectory::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#10 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
...
#87306 0x0000555555a4b796 in Exiv2::Internal::CiffDirectory::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#87307 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#87308 0x0000555555a4d879 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) ()
#87309 0x0000555555a4b796 in Exiv2::Internal::CiffDirectory::doRead(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#87310 0x0000555555a4e449 in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) ()
#87311 0x0000555555a4d879 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) ()
#87312 0x0000555555a646d6 in Exiv2::Internal::CiffHeader::read(unsigned char const*, unsigned int) ()
#87313 0x00005555559dd417 in Exiv2::CrwParser::decode(Exiv2::CrwImage*, unsigned char const*, unsigned int) ()
#87314 0x00005555559d95d1 in Exiv2::CrwImage::readMetadata() ()
#87315 0x0000555555646c65 in Action::Print::printSummary() ()
#87316 0x000055555564600d in Action::Print::run(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ()
#87317 0x000055555562660b in main ()
```
Thanks.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 3,525 | 207,761 |
[
"Exiv2",
"exiv2"
] | This is a lens included in a few built-in cameras, including the [Leica D-Lux](https://www.dpreview.com/articles/9078374619/leica-introduces-d-lux-24-75mm-equiv-compact-with-four-thirds-sensor#specs) and Panasonic Lumix LX-100II. | Lens request: Leica DC Vario-Summilux 10.9–34 mm f/1.7–2.8 ASPH | https://api.github.com/repos/Exiv2/exiv2/issues/1096/comments | 10 | 2020-02-05T07:26:14 | "2020-03-03T19:29:27Z" | https://github.com/Exiv2/exiv2/issues/1096 | 560,188,599 | 1,096 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Lens request: Leica DC Vario-Summilux 10.9–34 mm f/1.7–2.8 ASPH
Issue date:
--- start body ---
This is a lens included in a few built-in cameras, including the [Leica D-Lux](https://www.dpreview.com/articles/9078374619/leica-introduces-d-lux-24-75mm-equiv-compact-with-four-thirds-sensor#specs) and Panasonic Lumix LX-100II.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 453 | 207,762 |
[
"Exiv2",
"exiv2"
] | Hello!
It's not a bug, it's just missing information about Irix150mm, Irix11mm lenses in photos taken with Pentax. I suggest the following patch to add this information:
[Pentax-Irix.patch.zip](https://github.com/Exiv2/exiv2/files/4060622/Pentax-Irix.patch.zip)
| Irix lens names in Pentax | https://api.github.com/repos/Exiv2/exiv2/issues/1084/comments | 3 | 2020-01-14T18:02:18 | "2021-04-13T09:54:31Z" | https://github.com/Exiv2/exiv2/issues/1084 | 549,729,145 | 1,084 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Irix lens names in Pentax
Issue date:
--- start body ---
Hello!
It's not a bug, it's just missing information about Irix150mm, Irix11mm lenses in photos taken with Pentax. I suggest the following patch to add this information:
[Pentax-Irix.patch.zip](https://github.com/Exiv2/exiv2/files/4060622/Pentax-Irix.patch.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 455 | 207,763 |
[
"Exiv2",
"exiv2"
] | I have downloaded the exiv2-0.27.2-Source.tar.gz.
I have extracted it in the same directory i.e, home/dir/Downloads/
Now following the instructions from the github page
**Build, Install, Use Exiv2 on a UNIX-like system**
`cd $EXIV_ROOT
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release
cmake --build .
make tests
sudo make install`
I Have to install the exiv2 for the osm/merkaartor. Please help
| Having problem in installing exiv2 in ubuntu 18.04lts | https://api.github.com/repos/Exiv2/exiv2/issues/1083/comments | 10 | 2020-01-14T05:38:20 | "2020-03-30T15:30:46Z" | https://github.com/Exiv2/exiv2/issues/1083 | 549,344,817 | 1,083 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Having problem in installing exiv2 in ubuntu 18.04lts
Issue date:
--- start body ---
I have downloaded the exiv2-0.27.2-Source.tar.gz.
I have extracted it in the same directory i.e, home/dir/Downloads/
Now following the instructions from the github page
**Build, Install, Use Exiv2 on a UNIX-like system**
`cd $EXIV_ROOT
mkdir build && cd build
cmake .. -DCMAKE_BUILD_TYPE=Release
cmake --build .
make tests
sudo make install`
I Have to install the exiv2 for the osm/merkaartor. Please help
--- end body ---
comments :
--- start comments ---
--- end comments --- | 782 | 207,764 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Building exiv2 0.27.1 fails when debug mode is enabled. This problem was [reported to MacPorts here](https://trac.macports.org/ticket/59932); a full build log is attached there.
**To Reproduce**
Steps to reproduce the behaviour:
Configure exiv2 with `-DDEBUG` in CFLAGS, CXXFLAGS; make as usual.
**Expected behavior**
Successful build.
**Desktop (please complete the following information):**
- OS: macOS but that should be immaterial
- Compiler & Version: AppleClang 10.0.0.10001044 in this case but that should be immaterial
- Compilation mode and/or compiler flags: `-DDEBUG`
**Additional context**
The error encountered is:
```
src/pngimage.cpp:348:42: error: no matching function for call to 'binaryToString'
std::cerr << Exiv2::Internal::binaryToString(parsedBuf.pData_, parsedBuf.size_>50?50:parsedBuf.size_,0) << std::endl;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/image_int.hpp:125:36: note: candidate function template not viable: requires single argument 'sl', but 3 arguments were provided
inline binaryToStringHelper<T> binaryToString(const Slice<T> sl) throw()
^
1 error generated.
```
This appears genuinely to be because `Exiv2::Internal::binaryToString` is being invoked with 3 parameters from pngimage.cpp when it is only defined with a single parameter in image_int.hpp.
I think the problem was caused by fec6535ae8a4299ea7f51606e45d3ea54b8e3194 which reimplemented `binaryToString` using slices, but neglected to make the necessary corresponding changes to this one call from pngimage.cpp. It is protected by an `#if DEBUG` preprocessor block which may explain how it was overlooked. | Build fails in debug mode | https://api.github.com/repos/Exiv2/exiv2/issues/1082/comments | 6 | 2020-01-11T05:52:43 | "2020-04-06T07:13:02Z" | https://github.com/Exiv2/exiv2/issues/1082 | 548,386,222 | 1,082 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Build fails in debug mode
Issue date:
--- start body ---
**Describe the bug**
Building exiv2 0.27.1 fails when debug mode is enabled. This problem was [reported to MacPorts here](https://trac.macports.org/ticket/59932); a full build log is attached there.
**To Reproduce**
Steps to reproduce the behaviour:
Configure exiv2 with `-DDEBUG` in CFLAGS, CXXFLAGS; make as usual.
**Expected behavior**
Successful build.
**Desktop (please complete the following information):**
- OS: macOS but that should be immaterial
- Compiler & Version: AppleClang 10.0.0.10001044 in this case but that should be immaterial
- Compilation mode and/or compiler flags: `-DDEBUG`
**Additional context**
The error encountered is:
```
src/pngimage.cpp:348:42: error: no matching function for call to 'binaryToString'
std::cerr << Exiv2::Internal::binaryToString(parsedBuf.pData_, parsedBuf.size_>50?50:parsedBuf.size_,0) << std::endl;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/image_int.hpp:125:36: note: candidate function template not viable: requires single argument 'sl', but 3 arguments were provided
inline binaryToStringHelper<T> binaryToString(const Slice<T> sl) throw()
^
1 error generated.
```
This appears genuinely to be because `Exiv2::Internal::binaryToString` is being invoked with 3 parameters from pngimage.cpp when it is only defined with a single parameter in image_int.hpp.
I think the problem was caused by fec6535ae8a4299ea7f51606e45d3ea54b8e3194 which reimplemented `binaryToString` using slices, but neglected to make the necessary corresponding changes to this one call from pngimage.cpp. It is protected by an `#if DEBUG` preprocessor block which may explain how it was overlooked.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,955 | 207,765 |
[
"Exiv2",
"exiv2"
] | I want to change the orientation tag of the original JPEGs of my old Olympus camera without orientation sensor and leave the rest as it is. But exiv2 will also shorten the MakerNote Tag, I don't know if this is related to the warnings.
I'm not sure if this is a bug or intended behavior. In case it is intended and it somehow fixes the files to be standard conform, I miss a option to not do that.
```
$ exiv2 -M"set Exif.Image.Orientation Short 8" -k exif.JPG
Warning: Directory OlympusCs, entry 0x0101: Strip 0 is outside of the data area; ignored.
Warning: Directory OlympusCs, entry 0x0101: Strip 0 is outside of the data area; ignored.
$ diff <(exiv2 -pa orig.JPG) <(exiv2 -pa exif.JPG)
Warning: Directory OlympusCs, entry 0x0101: Strip 0 is outside of the data area; ignored.
Warning: Directory OlympusCs, entry 0x0101: Strip 0 is outside of the data area; ignored.
4c4
< Exif.Image.Orientation Short 1 top, left
---
> Exif.Image.Orientation Short 1 left, bottom
26c26
< Exif.Photo.MakerNote Undefined 11388 (Binary value suppressed)
---
> Exif.Photo.MakerNote Undefined 9270 (Binary value suppressed)
``` | Changing Tag shortens MakerNote on Olympus JPEG | https://api.github.com/repos/Exiv2/exiv2/issues/1081/comments | 19 | 2020-01-07T13:21:16 | "2023-11-04T16:31:21Z" | https://github.com/Exiv2/exiv2/issues/1081 | 546,279,732 | 1,081 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Changing Tag shortens MakerNote on Olympus JPEG
Issue date:
--- start body ---
I want to change the orientation tag of the original JPEGs of my old Olympus camera without orientation sensor and leave the rest as it is. But exiv2 will also shorten the MakerNote Tag, I don't know if this is related to the warnings.
I'm not sure if this is a bug or intended behavior. In case it is intended and it somehow fixes the files to be standard conform, I miss a option to not do that.
```
$ exiv2 -M"set Exif.Image.Orientation Short 8" -k exif.JPG
Warning: Directory OlympusCs, entry 0x0101: Strip 0 is outside of the data area; ignored.
Warning: Directory OlympusCs, entry 0x0101: Strip 0 is outside of the data area; ignored.
$ diff <(exiv2 -pa orig.JPG) <(exiv2 -pa exif.JPG)
Warning: Directory OlympusCs, entry 0x0101: Strip 0 is outside of the data area; ignored.
Warning: Directory OlympusCs, entry 0x0101: Strip 0 is outside of the data area; ignored.
4c4
< Exif.Image.Orientation Short 1 top, left
---
> Exif.Image.Orientation Short 1 left, bottom
26c26
< Exif.Photo.MakerNote Undefined 11388 (Binary value suppressed)
---
> Exif.Photo.MakerNote Undefined 9270 (Binary value suppressed)
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,451 | 207,766 |
[
"Exiv2",
"exiv2"
] | Hi,
I'm building Exiv2 as an external library for my project. I'm using CMake and the ExternalProject module for that purpose. Everything works fine but I'd like to disable the warning/error messages that appear in the console window. I know I've to define a special macro (SUPPRESS_WARNINGS) at compile time but I'm having a hard time finding how to do so. Can someone tell me a solution for this problem ? Here's the CMake script I use to compile the library:
set(EXIV2_PREFIX exiv2)
set(EXIV2_URL "${CMAKE_SOURCE_DIR}/exiv2/exiv2-0.27.2-Source.tar.gz")
set(EXIV2_URL_MD5 8c39c39dc8141bb158e8e9d663bcbf21)
ExternalProject_Add(
${EXIV2_PREFIX}
PREFIX ${EXIV2_PREFIX}
#-- Download step -------
URL ${EXIV2_URL}
URL_MD5 ${EXIV2_URL_MD5}
#-- Configure step ------
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
-DEXIV2_ENABLE_XMP=OFF
-DEXIV2_ENABLE_PNG=OFF
-DEXIV2_BUILD_SAMPLES=OFF
-DEXIV2_BUILD_EXIV2_COMMAND=OFF
#-- Logging options -----
LOG_DOWNLOAD 1
LOG_BUILD 1)
Thank you very much for your help.
| Silent warnings when building as an external dependency | https://api.github.com/repos/Exiv2/exiv2/issues/1080/comments | 5 | 2020-01-01T14:58:58 | "2020-01-03T20:37:04Z" | https://github.com/Exiv2/exiv2/issues/1080 | 544,366,781 | 1,080 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Silent warnings when building as an external dependency
Issue date:
--- start body ---
Hi,
I'm building Exiv2 as an external library for my project. I'm using CMake and the ExternalProject module for that purpose. Everything works fine but I'd like to disable the warning/error messages that appear in the console window. I know I've to define a special macro (SUPPRESS_WARNINGS) at compile time but I'm having a hard time finding how to do so. Can someone tell me a solution for this problem ? Here's the CMake script I use to compile the library:
set(EXIV2_PREFIX exiv2)
set(EXIV2_URL "${CMAKE_SOURCE_DIR}/exiv2/exiv2-0.27.2-Source.tar.gz")
set(EXIV2_URL_MD5 8c39c39dc8141bb158e8e9d663bcbf21)
ExternalProject_Add(
${EXIV2_PREFIX}
PREFIX ${EXIV2_PREFIX}
#-- Download step -------
URL ${EXIV2_URL}
URL_MD5 ${EXIV2_URL_MD5}
#-- Configure step ------
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
-DEXIV2_ENABLE_XMP=OFF
-DEXIV2_ENABLE_PNG=OFF
-DEXIV2_BUILD_SAMPLES=OFF
-DEXIV2_BUILD_EXIV2_COMMAND=OFF
#-- Logging options -----
LOG_DOWNLOAD 1
LOG_BUILD 1)
Thank you very much for your help.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,414 | 207,767 |
[
"Exiv2",
"exiv2"
] | I'd like to add the newly released Tokina atx-i 11-16mm F2.8 CF (Nikon):
```
exiv2 -pa --grep lens/i DSC_0476.JPG
Exif.Nikon3.LensType Byte 1 D G
Exif.Nikon3.Lens Rational 4 11-16mm F2.8
Exif.Nikon3.LensFStops Undefined 4 6
Exif.NikonLd3.LensIDNumber Byte 1 128
Exif.NikonLd3.LensFStops Byte 1 F6.0
```
Sample image:
| Add lens Tokina atx-i 11-16mm F2.8 CF (Nikon) | https://api.github.com/repos/Exiv2/exiv2/issues/1078/comments | 0 | 2019-12-27T16:47:17 | "2020-01-14T23:47:17Z" | https://github.com/Exiv2/exiv2/issues/1078 | 542,930,565 | 1,078 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add lens Tokina atx-i 11-16mm F2.8 CF (Nikon)
Issue date:
--- start body ---
I'd like to add the newly released Tokina atx-i 11-16mm F2.8 CF (Nikon):
```
exiv2 -pa --grep lens/i DSC_0476.JPG
Exif.Nikon3.LensType Byte 1 D G
Exif.Nikon3.Lens Rational 4 11-16mm F2.8
Exif.Nikon3.LensFStops Undefined 4 6
Exif.NikonLd3.LensIDNumber Byte 1 128
Exif.NikonLd3.LensFStops Byte 1 F6.0
```
Sample image:
--- end body ---
comments :
--- start comments ---
--- end comments --- | 902 | 207,768 |
[
"Exiv2",
"exiv2"
] | Hello,
In the array: canonCsLensType of the file canonmn_int.cpp, please could you add these 2 lenses:
{ 231, "Sigma 12-24mm f/4 DG HSM | A" }
{ 495, "Sigma 24-70mm f/2.8 DG OS HSM | A" }
For the number 495, there is already one canon lens with same focal and aperture so not possible to differentiate with actual code.
{ 495, "Canon EF 24-70mm f/2.8L II USM" }
It is nevertheless possible to differentiate by using the tag: 0x0095, "LensModel" of CanonMakerNote which is:
"12-24mm F4 DG HSM | Art 016"
"24-70mm F2.8 DG OS HSM | Art 017"
Maybe it would be a good idea when the match has 2 possible solutions to use this tag.
Either by finding exactly the same substring "24-70mm F2.8 DG OS HSM | Art 017" to differentiate with the canon lens or using the distinctive "Art" which has a high probability to be specific to sigma lenses.
I can provide images if needed.
Kind regards,
Fabien
| Update of 2 sigmas lenses on Canon body AND way to differentiate lenses with same ID | https://api.github.com/repos/Exiv2/exiv2/issues/1076/comments | 4 | 2019-12-11T20:22:04 | "2020-04-07T07:48:03Z" | https://github.com/Exiv2/exiv2/issues/1076 | 536,593,979 | 1,076 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Update of 2 sigmas lenses on Canon body AND way to differentiate lenses with same ID
Issue date:
--- start body ---
Hello,
In the array: canonCsLensType of the file canonmn_int.cpp, please could you add these 2 lenses:
{ 231, "Sigma 12-24mm f/4 DG HSM | A" }
{ 495, "Sigma 24-70mm f/2.8 DG OS HSM | A" }
For the number 495, there is already one canon lens with same focal and aperture so not possible to differentiate with actual code.
{ 495, "Canon EF 24-70mm f/2.8L II USM" }
It is nevertheless possible to differentiate by using the tag: 0x0095, "LensModel" of CanonMakerNote which is:
"12-24mm F4 DG HSM | Art 016"
"24-70mm F2.8 DG OS HSM | Art 017"
Maybe it would be a good idea when the match has 2 possible solutions to use this tag.
Either by finding exactly the same substring "24-70mm F2.8 DG OS HSM | Art 017" to differentiate with the canon lens or using the distinctive "Art" which has a high probability to be specific to sigma lenses.
I can provide images if needed.
Kind regards,
Fabien
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,263 | 207,769 |
[
"Exiv2",
"exiv2"
] | In #1015 we decided to remove from master a test which was added in `0.27-maintenance`to check the output of the taglist sample application. Such sample application was extended to be able to check whether exiv2 is able to recognise certain tags and we decided to add a python test to analyse the output of it. However, when adding support for new tags, taglist's output change and therefore the test fail with non understandable errors.
The objective of this issue is to reconsider the testing strategy with some of the approaches discussed in #1015. Another possible outcome of this issue would be to just decide to not add such test. | Reconsider taglist testing strategy | https://api.github.com/repos/Exiv2/exiv2/issues/1075/comments | 1 | 2019-12-10T17:44:30 | "2020-03-25T14:17:38Z" | https://github.com/Exiv2/exiv2/issues/1075 | 535,885,174 | 1,075 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Reconsider taglist testing strategy
Issue date:
--- start body ---
In #1015 we decided to remove from master a test which was added in `0.27-maintenance`to check the output of the taglist sample application. Such sample application was extended to be able to check whether exiv2 is able to recognise certain tags and we decided to add a python test to analyse the output of it. However, when adding support for new tags, taglist's output change and therefore the test fail with non understandable errors.
The objective of this issue is to reconsider the testing strategy with some of the approaches discussed in #1015. Another possible outcome of this issue would be to just decide to not add such test.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 836 | 207,770 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
How are the builds supports to be installed? There is no description in the README about it.
**To Reproduce**
read the README / download the builds from https://www.exiv2.org/download.html
**Expected behavior**
Clear description of what to do with the builds
**Desktop (please complete the following information):**
- Ubuntu LTS
**Additional context**
-
| How are the builds supports to be installed? | https://api.github.com/repos/Exiv2/exiv2/issues/1074/comments | 2 | 2019-12-10T14:03:46 | "2019-12-10T15:42:31Z" | https://github.com/Exiv2/exiv2/issues/1074 | 535,750,754 | 1,074 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : How are the builds supports to be installed?
Issue date:
--- start body ---
**Describe the bug**
How are the builds supports to be installed? There is no description in the README about it.
**To Reproduce**
read the README / download the builds from https://www.exiv2.org/download.html
**Expected behavior**
Clear description of what to do with the builds
**Desktop (please complete the following information):**
- Ubuntu LTS
**Additional context**
-
--- end body ---
comments :
--- start comments ---
--- end comments --- | 599 | 207,771 |
[
"Exiv2",
"exiv2"
] | Please fix conflict and add lens.
$ exiv2 -pt IMG_4600.JPG | grep -ai lens
Exif.CanonCs.LensType Short 1 Canon EF 35mm f/1.4L II USM
Exif.CanonCs.Lens Short 3 85.0 mm
Exif.Canon.LensModel Ascii 74 TAMRON SP 85mm F/1.8 Di VC USD F016
Exif.Photo.LensSpecification Rational 4 85/1 85/1 0/1 0/1
Exif.Photo.LensModel Ascii 36 TAMRON SP 85mm F/1.8 Di VC USD F016
Exif.Photo.LensSerialNumber Ascii 11 0000000000
| Add lens Tamron SP 85mm F/1.8 Di VC USD (Canon) | https://api.github.com/repos/Exiv2/exiv2/issues/1072/comments | 5 | 2019-12-07T13:39:58 | "2020-04-07T07:46:36Z" | https://github.com/Exiv2/exiv2/issues/1072 | 534,403,237 | 1,072 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add lens Tamron SP 85mm F/1.8 Di VC USD (Canon)
Issue date:
--- start body ---
Please fix conflict and add lens.
$ exiv2 -pt IMG_4600.JPG | grep -ai lens
Exif.CanonCs.LensType Short 1 Canon EF 35mm f/1.4L II USM
Exif.CanonCs.Lens Short 3 85.0 mm
Exif.Canon.LensModel Ascii 74 TAMRON SP 85mm F/1.8 Di VC USD F016
Exif.Photo.LensSpecification Rational 4 85/1 85/1 0/1 0/1
Exif.Photo.LensModel Ascii 36 TAMRON SP 85mm F/1.8 Di VC USD F016
Exif.Photo.LensSerialNumber Ascii 11 0000000000
--- end body ---
comments :
--- start comments ---
--- end comments --- | 907 | 207,772 |
[
"Exiv2",
"exiv2"
] | I don't have camera Nikon. I found a jpeg from Nikon on the web.
$ exiv2 -pt DSC_0495.JPG | grep -ai lens
Exif.Nikon3.LensType Byte 1 D G
Exif.Nikon3.Lens Rational 4 35mm F1.4
Exif.Nikon3.LensFStops Undefined 4 7
Exif.NikonLd3.LensIDNumber Byte 1 200
Exif.NikonLd3.LensFStops Byte 1 F7.0
| Add lens Tamron SP 35mm f/1.4 Di USD (Nikon) | https://api.github.com/repos/Exiv2/exiv2/issues/1069/comments | 1 | 2019-11-25T00:07:04 | "2020-04-07T07:50:39Z" | https://github.com/Exiv2/exiv2/issues/1069 | 527,781,278 | 1,069 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add lens Tamron SP 35mm f/1.4 Di USD (Nikon)
Issue date:
--- start body ---
I don't have camera Nikon. I found a jpeg from Nikon on the web.
$ exiv2 -pt DSC_0495.JPG | grep -ai lens
Exif.Nikon3.LensType Byte 1 D G
Exif.Nikon3.Lens Rational 4 35mm F1.4
Exif.Nikon3.LensFStops Undefined 4 7
Exif.NikonLd3.LensIDNumber Byte 1 200
Exif.NikonLd3.LensFStops Byte 1 F7.0
--- end body ---
comments :
--- start comments ---
--- end comments --- | 767 | 207,773 |
[
"Exiv2",
"exiv2"
] | Although we already have an option in CMake which add the needed compiler flags in GCC and CLANG to produce coverage information (this is used by the tools we employ in the PRs to generate coverage reports) it would be nice to also add some targets in the CMake configuration to generate local coverage reports.
This would be useful for exploring not exercised paths in the code while testing either some legacy code or new features.
Some ideas of how this could be achieved can be found on the web:
https://codeist.zone/2018/03/16/code-coverage-with-gcov-and-cmake/
http://www.stablecoder.ca/2018/01/15/code-coverage.html | CMake: add targets to generate local coverage reports | https://api.github.com/repos/Exiv2/exiv2/issues/1068/comments | 10 | 2019-11-23T12:29:02 | "2021-04-14T07:48:03Z" | https://github.com/Exiv2/exiv2/issues/1068 | 527,551,653 | 1,068 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : CMake: add targets to generate local coverage reports
Issue date:
--- start body ---
Although we already have an option in CMake which add the needed compiler flags in GCC and CLANG to produce coverage information (this is used by the tools we employ in the PRs to generate coverage reports) it would be nice to also add some targets in the CMake configuration to generate local coverage reports.
This would be useful for exploring not exercised paths in the code while testing either some legacy code or new features.
Some ideas of how this could be achieved can be found on the web:
https://codeist.zone/2018/03/16/code-coverage-with-gcov-and-cmake/
http://www.stablecoder.ca/2018/01/15/code-coverage.html
--- end body ---
comments :
--- start comments ---
--- end comments --- | 845 | 207,774 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Hello!
I've started to add support for the AVIF file format [2] in darktable using libavif [1]. I've worked with the maintainer so that it works nicely with cmake.
However I'm not able to load the image file in darktable, because exiv2 is not able to read the exif data and then fails. You can find my darktable code here [3].
If you need help or want to do some pair programming, let me know. It isn't hard to just read the exif data blob.
[1] https://github.com/AOMediaCodec/av1-avif
[2] https://github.com/AOMediaCodec/libavif/
[3] https://github.com/cryptomilk/darktable/tree/master-avif | Add support for ISOBMFF Files (AVIF, HEIF, CR3) | https://api.github.com/repos/Exiv2/exiv2/issues/1066/comments | 30 | 2019-11-23T09:37:23 | "2024-01-08T08:57:00Z" | https://github.com/Exiv2/exiv2/issues/1066 | 527,534,947 | 1,066 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add support for ISOBMFF Files (AVIF, HEIF, CR3)
Issue date:
--- start body ---
**Describe the bug**
Hello!
I've started to add support for the AVIF file format [2] in darktable using libavif [1]. I've worked with the maintainer so that it works nicely with cmake.
However I'm not able to load the image file in darktable, because exiv2 is not able to read the exif data and then fails. You can find my darktable code here [3].
If you need help or want to do some pair programming, let me know. It isn't hard to just read the exif data blob.
[1] https://github.com/AOMediaCodec/av1-avif
[2] https://github.com/AOMediaCodec/libavif/
[3] https://github.com/cryptomilk/darktable/tree/master-avif
--- end body ---
comments :
--- start comments ---
--- end comments --- | 837 | 207,775 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
when use `Exiv2::Uri::Parse(url)` to parse url, if use malformed url, it will crash.
It's a very low security level crash, you can decide to fix it or not.
**To Reproduce**
edit `samples/conntest.cpp` as follow, then compile latest commit exiv2
```c++
// ***************************************************************** -*- C++ -*-
// con-test.cpp
// Tester application for testing the http/https/ftp/ssh/sftp connection
#include <exiv2/exiv2.hpp>
#ifdef EXV_USE_CURL
#include <curl/curl.h>
#endif
#include <iostream>
#include <cstdlib>
void httpcon(const std::string& url, bool useHttp1_0 = false) {
Exiv2::Dictionary response;
Exiv2::Dictionary request;
std::string errors;
Exiv2::Uri uri = Exiv2::Uri::Parse(url);
Exiv2::Uri::Decode(uri);
request["server"] = uri.Host;
request["page"] = uri.Path;
request["port"] = uri.Port;
if (!useHttp1_0) request["version"] = "1.1";
// int serverCode = Exiv2::http(request,response,errors);
// if (serverCode < 0 || serverCode >= 400 || errors.compare("") != 0) {
// throw Exiv2::Error(Exiv2::kerTiffDirectoryTooLarge, "Server", serverCode);
// }
}
#ifdef EXV_USE_CURL
void curlcon(const std::string& url, bool useHttp1_0 = false) {
CURL* curl = curl_easy_init();
if(!curl) {
throw Exiv2::Error(Exiv2::kerErrorMessage, "Uable to init libcurl.");
}
// get the timeout value
std::string timeoutStr = Exiv2::getEnv(Exiv2::envTIMEOUT);
long timeout = atol(timeoutStr.c_str());
if (timeout == 0) {
throw Exiv2::Error(Exiv2::kerErrorMessage, "Timeout Environmental Variable must be a positive integer.");
}
std::string response;
curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, Exiv2::curlWriter);
curl_easy_setopt(curl, CURLOPT_WRITEDATA, &response);
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);
curl_easy_setopt(curl, CURLOPT_CONNECTTIMEOUT, timeout);
//curl_easy_setopt(curl, CURLOPT_VERBOSE, 1); // debug
if (useHttp1_0) curl_easy_setopt(curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_0);
else curl_easy_setopt(curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
/* Perform the request, res will get the return code */
CURLcode res = curl_easy_perform(curl);
if(res != CURLE_OK) { // error happends
throw Exiv2::Error(Exiv2::kerErrorMessage, curl_easy_strerror(res));
}
// get return code
long returnCode;
curl_easy_getinfo (curl, CURLINFO_RESPONSE_CODE, &returnCode); // get code
curl_easy_cleanup(curl);
if (returnCode >= 400 || returnCode < 0) {
throw Exiv2::Error(Exiv2::kerTiffDirectoryTooLarge, "Server", returnCode);
}
}
#endif
static bool ReadFileToString(const char *filename, std::string *buffer) {
FILE *f = fopen(filename, "rb");
if (f == NULL) {
return false;
}
fseek(f, 0, SEEK_END);
const long size = ftell(f);
fseek(f, 0, SEEK_SET);
bool success = true;
char *tmp = (char *)malloc(size);
if (tmp == NULL) {
success = false;
}
if (success) {
success = (fread(tmp, 1, size, f) == size);
}
if (success) {
buffer->assign(tmp, size);
}
free(tmp);
fclose(f);
return success;
}
int main(int argc,const char** argv)
{
Exiv2::XmpParser::initialize();
::atexit(Exiv2::XmpParser::terminate);
if (argc < 2) {
std::cout << "Usage: " << argv[0] << " url {-http1_0}" << std::endl;
return 1;
}
std::string file_data;
if (!ReadFileToString(argv[1], &file_data))
{
printf("read file failed!\n");
return 1;
}
std::string url(file_data);
Exiv2::Protocol prot = Exiv2::fileProtocol(url);
bool useHttp1_0 = false;
for ( int a = 1 ; a < argc ; a++ ) {
std::string arg(argv[a]);
if (arg == "-http1_0") useHttp1_0 = true;
}
bool isOk = false;
try {
#ifdef EXV_USE_CURL
if (prot == Exiv2::pHttp || prot == Exiv2::pHttps || prot == Exiv2::pFtp) {
curlcon(url, useHttp1_0);
isOk = true;
}
#endif
if (!isOk && prot == Exiv2::pHttp) {
httpcon(url, useHttp1_0);
isOk = true;
}
} catch (const Exiv2::AnyError& e) {
std::cout << "Error: '" << e << "'" << std::endl;
return -1;
}
if (!isOk) std::cout << "The protocol is unsupported." << std::endl;
else std::cout << "OK." << std::endl;
return 0;
}
// That's all Folks!
```
**Expected behavior**
Crash
```
➜ build git:(master) ✗ gdb bin/conntest
pwndbg: loaded 170 commands. Type pwndbg [filter] for a list.
pwndbg: created $rebase, $ida gdb functions (can be used with print/break)
Reading symbols from bin/conntest...done.
pwndbg> r ./crashes/024b8d41af3621fe50cf5c840bad9bd3
Starting program: /home/exiv2/build/bin/conntest ./crashes/024b8d41af3621fe50cf5c840bad9bd3
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
file_name: ./crashes/024b8d41af3621fe50cf5c840bad9bd3
terminate called after throwing an instance of 'std::length_error'
what(): basic_string::_M_create
Program received signal SIGABRT, Aborted.
0x00007ffff6750428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
54 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
LEGEND: STACK | HEAP | CODE | DATA | RWX | RODATA
─────────────────────────────────────────────────────[ REGISTERS ]─────────────────────────────────────────────────────
RAX 0x0
RBX 0x61c768 ◂— 'basic_string::_M_create'
RCX 0xffffffffffffffff
RDX 0x6
RDI 0x84d2
RSI 0x84d2
R8 0x7ffff6ae1770 (_IO_stdfile_2_lock) ◂— 0x0
R9 0x7ffff7fe8740 ◂— 0x7ffff7fe8740
R10 0x8
R11 0x206
R12 0x622570 ◂— 0x0
R13 0x7fffffffe0b0 —▸ 0x7fffffffe0c0 ◂— 0x0
R14 0x6224b1 ◂— 0xe92e20ff7f00003f /* '?' */
R15 0x7fffffffe130 —▸ 0x7fffffffe140 ◂— 0x3038 /* '80' */
RBP 0x7ffff6ae0700 (stderr) —▸ 0x7ffff6ae0540 (_IO_2_1_stderr_) ◂— 0xfbad2887
RSP 0x7fffffffdd68 —▸ 0x7ffff675202a (abort+362) ◂— mov rdx, qword ptr fs:[0x10]
RIP 0x7ffff6750428 (raise+56) ◂— cmp rax, -0x1000 /* 'H=' */
──────────────────────────────────────────────────────[ DISASM ]───────────────────────────────────────────────────────
► 0x7ffff6750428 <raise+56> cmp rax, -0x1000
0x7ffff675042e <raise+62> ja raise+96 <0x7ffff6750450>
0x7ffff6750430 <raise+64> ret
0x7ffff6750432 <raise+66> nop word ptr [rax + rax]
0x7ffff6750438 <raise+72> test ecx, ecx
0x7ffff675043a <raise+74> jg raise+43 <0x7ffff675041b>
↓
0x7ffff675041b <raise+43> movsxd rdx, edi
0x7ffff675041e <raise+46> mov eax, 0xea
0x7ffff6750423 <raise+51> movsxd rdi, ecx
0x7ffff6750426 <raise+54> syscall
► 0x7ffff6750428 <raise+56> cmp rax, -0x1000
───────────────────────────────────────────────────────[ STACK ]───────────────────────────────────────────────────────
00:0000│ rsp 0x7fffffffdd68 —▸ 0x7ffff675202a (abort+362) ◂— mov rdx, qword ptr fs:[0x10]
01:0008│ 0x7fffffffdd70 ◂— 0x20 /* ' ' */
02:0010│ 0x7fffffffdd78 ◂— 0x0
... ↓
─────────────────────────────────────────────────────[ BACKTRACE ]─────────────────────────────────────────────────────
► f 0 7ffff6750428 raise+56
f 1 7ffff675202a abort+362
f 2 7ffff709384d __gnu_cxx::__verbose_terminate_handler()+365
f 3 7ffff70916b6
f 4 7ffff7091701
f 5 7ffff7091919
f 6 7ffff70ba26f
f 7 7ffff7123099
f 8 7ffff76f4438
f 9 7ffff76f4438
f 10 7ffff76f4438
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Program received signal SIGABRT
pwndbg> bt
#0 0x00007ffff6750428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1 0x00007ffff675202a in __GI_abort () at abort.c:89
#2 0x00007ffff709384d in __gnu_cxx::__verbose_terminate_handler() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3 0x00007ffff70916b6 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4 0x00007ffff7091701 in std::terminate() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5 0x00007ffff7091919 in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6 0x00007ffff70ba26f in std::__throw_length_error(char const*) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#7 0x00007ffff7123099 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_create(unsigned long&, unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8 0x00007ffff76f4438 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<__gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > (this=<optimized out>, __beg=..., __end=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.tcc:223
#9 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct_aux<__gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > (this=<optimized out>, __beg=..., __end=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.h:195
#10 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<__gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > (this=<optimized out>, __beg=..., __end=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.h:214
#11 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string<__gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, void> (__beg=..., __end=..., this=<optimized out>, __a=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.h:537
#12 Exiv2::Uri::Parse (uri=...) at /home/exiv2/src/futils.cpp:465
Python Exception <class 'gdb.error'> There is no member named _M_dataplus.:
#13 0x0000000000401f46 in httpcon (url=, useHttp1_0=false) at /home/exiv2/samples/conntest.cpp:19
#14 0x00000000004043f5 in main (argc=<optimized out>, argc@entry=2, argv=argv@entry=0x7fffffffe378) at /home/exiv2/samples/conntest.cpp:141
#15 0x00007ffff673b830 in __libc_start_main (main=0x403590 <main(int, char const**)>, argc=2, argv=0x7fffffffe378, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe368) at ../csu/libc-start.c:291
#16 0x0000000000401d99 in _start ()
```
**Desktop (please complete the following information):**
- OS: Linux
- Compiler: clang-6
- Compile with debug mode
**Additional context**
It's not a important issue, if you do not decide to fix it, you can ignore it.
| exiv2 parse url crash | https://api.github.com/repos/Exiv2/exiv2/issues/1065/comments | 1 | 2019-11-22T07:22:36 | "2020-01-24T15:58:16Z" | https://github.com/Exiv2/exiv2/issues/1065 | 527,032,125 | 1,065 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : exiv2 parse url crash
Issue date:
--- start body ---
**Describe the bug**
when use `Exiv2::Uri::Parse(url)` to parse url, if use malformed url, it will crash.
It's a very low security level crash, you can decide to fix it or not.
**To Reproduce**
edit `samples/conntest.cpp` as follow, then compile latest commit exiv2
```c++
// ***************************************************************** -*- C++ -*-
// con-test.cpp
// Tester application for testing the http/https/ftp/ssh/sftp connection
#include <exiv2/exiv2.hpp>
#ifdef EXV_USE_CURL
#include <curl/curl.h>
#endif
#include <iostream>
#include <cstdlib>
void httpcon(const std::string& url, bool useHttp1_0 = false) {
Exiv2::Dictionary response;
Exiv2::Dictionary request;
std::string errors;
Exiv2::Uri uri = Exiv2::Uri::Parse(url);
Exiv2::Uri::Decode(uri);
request["server"] = uri.Host;
request["page"] = uri.Path;
request["port"] = uri.Port;
if (!useHttp1_0) request["version"] = "1.1";
// int serverCode = Exiv2::http(request,response,errors);
// if (serverCode < 0 || serverCode >= 400 || errors.compare("") != 0) {
// throw Exiv2::Error(Exiv2::kerTiffDirectoryTooLarge, "Server", serverCode);
// }
}
#ifdef EXV_USE_CURL
void curlcon(const std::string& url, bool useHttp1_0 = false) {
CURL* curl = curl_easy_init();
if(!curl) {
throw Exiv2::Error(Exiv2::kerErrorMessage, "Uable to init libcurl.");
}
// get the timeout value
std::string timeoutStr = Exiv2::getEnv(Exiv2::envTIMEOUT);
long timeout = atol(timeoutStr.c_str());
if (timeout == 0) {
throw Exiv2::Error(Exiv2::kerErrorMessage, "Timeout Environmental Variable must be a positive integer.");
}
std::string response;
curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, Exiv2::curlWriter);
curl_easy_setopt(curl, CURLOPT_WRITEDATA, &response);
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);
curl_easy_setopt(curl, CURLOPT_CONNECTTIMEOUT, timeout);
//curl_easy_setopt(curl, CURLOPT_VERBOSE, 1); // debug
if (useHttp1_0) curl_easy_setopt(curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_0);
else curl_easy_setopt(curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
/* Perform the request, res will get the return code */
CURLcode res = curl_easy_perform(curl);
if(res != CURLE_OK) { // error happends
throw Exiv2::Error(Exiv2::kerErrorMessage, curl_easy_strerror(res));
}
// get return code
long returnCode;
curl_easy_getinfo (curl, CURLINFO_RESPONSE_CODE, &returnCode); // get code
curl_easy_cleanup(curl);
if (returnCode >= 400 || returnCode < 0) {
throw Exiv2::Error(Exiv2::kerTiffDirectoryTooLarge, "Server", returnCode);
}
}
#endif
static bool ReadFileToString(const char *filename, std::string *buffer) {
FILE *f = fopen(filename, "rb");
if (f == NULL) {
return false;
}
fseek(f, 0, SEEK_END);
const long size = ftell(f);
fseek(f, 0, SEEK_SET);
bool success = true;
char *tmp = (char *)malloc(size);
if (tmp == NULL) {
success = false;
}
if (success) {
success = (fread(tmp, 1, size, f) == size);
}
if (success) {
buffer->assign(tmp, size);
}
free(tmp);
fclose(f);
return success;
}
int main(int argc,const char** argv)
{
Exiv2::XmpParser::initialize();
::atexit(Exiv2::XmpParser::terminate);
if (argc < 2) {
std::cout << "Usage: " << argv[0] << " url {-http1_0}" << std::endl;
return 1;
}
std::string file_data;
if (!ReadFileToString(argv[1], &file_data))
{
printf("read file failed!\n");
return 1;
}
std::string url(file_data);
Exiv2::Protocol prot = Exiv2::fileProtocol(url);
bool useHttp1_0 = false;
for ( int a = 1 ; a < argc ; a++ ) {
std::string arg(argv[a]);
if (arg == "-http1_0") useHttp1_0 = true;
}
bool isOk = false;
try {
#ifdef EXV_USE_CURL
if (prot == Exiv2::pHttp || prot == Exiv2::pHttps || prot == Exiv2::pFtp) {
curlcon(url, useHttp1_0);
isOk = true;
}
#endif
if (!isOk && prot == Exiv2::pHttp) {
httpcon(url, useHttp1_0);
isOk = true;
}
} catch (const Exiv2::AnyError& e) {
std::cout << "Error: '" << e << "'" << std::endl;
return -1;
}
if (!isOk) std::cout << "The protocol is unsupported." << std::endl;
else std::cout << "OK." << std::endl;
return 0;
}
// That's all Folks!
```
**Expected behavior**
Crash
```
➜ build git:(master) ✗ gdb bin/conntest
pwndbg: loaded 170 commands. Type pwndbg [filter] for a list.
pwndbg: created $rebase, $ida gdb functions (can be used with print/break)
Reading symbols from bin/conntest...done.
pwndbg> r ./crashes/024b8d41af3621fe50cf5c840bad9bd3
Starting program: /home/exiv2/build/bin/conntest ./crashes/024b8d41af3621fe50cf5c840bad9bd3
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
file_name: ./crashes/024b8d41af3621fe50cf5c840bad9bd3
terminate called after throwing an instance of 'std::length_error'
what(): basic_string::_M_create
Program received signal SIGABRT, Aborted.
0x00007ffff6750428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
54 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
LEGEND: STACK | HEAP | CODE | DATA | RWX | RODATA
─────────────────────────────────────────────────────[ REGISTERS ]─────────────────────────────────────────────────────
RAX 0x0
RBX 0x61c768 ◂— 'basic_string::_M_create'
RCX 0xffffffffffffffff
RDX 0x6
RDI 0x84d2
RSI 0x84d2
R8 0x7ffff6ae1770 (_IO_stdfile_2_lock) ◂— 0x0
R9 0x7ffff7fe8740 ◂— 0x7ffff7fe8740
R10 0x8
R11 0x206
R12 0x622570 ◂— 0x0
R13 0x7fffffffe0b0 —▸ 0x7fffffffe0c0 ◂— 0x0
R14 0x6224b1 ◂— 0xe92e20ff7f00003f /* '?' */
R15 0x7fffffffe130 —▸ 0x7fffffffe140 ◂— 0x3038 /* '80' */
RBP 0x7ffff6ae0700 (stderr) —▸ 0x7ffff6ae0540 (_IO_2_1_stderr_) ◂— 0xfbad2887
RSP 0x7fffffffdd68 —▸ 0x7ffff675202a (abort+362) ◂— mov rdx, qword ptr fs:[0x10]
RIP 0x7ffff6750428 (raise+56) ◂— cmp rax, -0x1000 /* 'H=' */
──────────────────────────────────────────────────────[ DISASM ]───────────────────────────────────────────────────────
► 0x7ffff6750428 <raise+56> cmp rax, -0x1000
0x7ffff675042e <raise+62> ja raise+96 <0x7ffff6750450>
0x7ffff6750430 <raise+64> ret
0x7ffff6750432 <raise+66> nop word ptr [rax + rax]
0x7ffff6750438 <raise+72> test ecx, ecx
0x7ffff675043a <raise+74> jg raise+43 <0x7ffff675041b>
↓
0x7ffff675041b <raise+43> movsxd rdx, edi
0x7ffff675041e <raise+46> mov eax, 0xea
0x7ffff6750423 <raise+51> movsxd rdi, ecx
0x7ffff6750426 <raise+54> syscall
► 0x7ffff6750428 <raise+56> cmp rax, -0x1000
───────────────────────────────────────────────────────[ STACK ]───────────────────────────────────────────────────────
00:0000│ rsp 0x7fffffffdd68 —▸ 0x7ffff675202a (abort+362) ◂— mov rdx, qword ptr fs:[0x10]
01:0008│ 0x7fffffffdd70 ◂— 0x20 /* ' ' */
02:0010│ 0x7fffffffdd78 ◂— 0x0
... ↓
─────────────────────────────────────────────────────[ BACKTRACE ]─────────────────────────────────────────────────────
► f 0 7ffff6750428 raise+56
f 1 7ffff675202a abort+362
f 2 7ffff709384d __gnu_cxx::__verbose_terminate_handler()+365
f 3 7ffff70916b6
f 4 7ffff7091701
f 5 7ffff7091919
f 6 7ffff70ba26f
f 7 7ffff7123099
f 8 7ffff76f4438
f 9 7ffff76f4438
f 10 7ffff76f4438
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Program received signal SIGABRT
pwndbg> bt
#0 0x00007ffff6750428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1 0x00007ffff675202a in __GI_abort () at abort.c:89
#2 0x00007ffff709384d in __gnu_cxx::__verbose_terminate_handler() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3 0x00007ffff70916b6 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4 0x00007ffff7091701 in std::terminate() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5 0x00007ffff7091919 in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6 0x00007ffff70ba26f in std::__throw_length_error(char const*) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#7 0x00007ffff7123099 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_create(unsigned long&, unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8 0x00007ffff76f4438 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<__gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > (this=<optimized out>, __beg=..., __end=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.tcc:223
#9 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct_aux<__gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > (this=<optimized out>, __beg=..., __end=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.h:195
#10 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<__gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > (this=<optimized out>, __beg=..., __end=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.h:214
#11 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string<__gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, void> (__beg=..., __end=..., this=<optimized out>, __a=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.h:537
#12 Exiv2::Uri::Parse (uri=...) at /home/exiv2/src/futils.cpp:465
Python Exception <class 'gdb.error'> There is no member named _M_dataplus.:
#13 0x0000000000401f46 in httpcon (url=, useHttp1_0=false) at /home/exiv2/samples/conntest.cpp:19
#14 0x00000000004043f5 in main (argc=<optimized out>, argc@entry=2, argv=argv@entry=0x7fffffffe378) at /home/exiv2/samples/conntest.cpp:141
#15 0x00007ffff673b830 in __libc_start_main (main=0x403590 <main(int, char const**)>, argc=2, argv=0x7fffffffe378, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe368) at ../csu/libc-start.c:291
#16 0x0000000000401d99 in _start ()
```
**Desktop (please complete the following information):**
- OS: Linux
- Compiler: clang-6
- Compile with debug mode
**Additional context**
It's not a important issue, if you do not decide to fix it, you can ignore it.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 11,620 | 207,776 |
[
"Exiv2",
"exiv2"
] | $ exiv2 -pt IMG_3493.JPG | grep -ai lens
Exif.CanonCs.LensType Short 1 (117)
Exif.CanonCs.Lens Short 3 35.0 mm
Exif.Canon.LensModel Ascii 74 TAMRON SP 35mm F/1.4 Di USD F045
Exif.Photo.LensSpecification Rational 4 35/1 35/1 0/1 0/1
Exif.Photo.LensModel Ascii 33 TAMRON SP 35mm F/1.4 Di USD F045
Exif.Photo.LensSerialNumber Ascii 11 0000000000
 | Add lens Tamron SP 35mm f/1.4 Di USD (Canon) | https://api.github.com/repos/Exiv2/exiv2/issues/1064/comments | 6 | 2019-11-19T14:55:38 | "2020-04-07T07:45:59Z" | https://github.com/Exiv2/exiv2/issues/1064 | 525,061,106 | 1,064 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add lens Tamron SP 35mm f/1.4 Di USD (Canon)
Issue date:
--- start body ---
$ exiv2 -pt IMG_3493.JPG | grep -ai lens
Exif.CanonCs.LensType Short 1 (117)
Exif.CanonCs.Lens Short 3 35.0 mm
Exif.Canon.LensModel Ascii 74 TAMRON SP 35mm F/1.4 Di USD F045
Exif.Photo.LensSpecification Rational 4 35/1 35/1 0/1 0/1
Exif.Photo.LensModel Ascii 33 TAMRON SP 35mm F/1.4 Di USD F045
Exif.Photo.LensSerialNumber Ascii 11 0000000000
--- end body ---
comments :
--- start comments ---
--- end comments --- | 839 | 207,777 |
[
"Exiv2",
"exiv2"
] | I tried building UWP version and compilation works fine, but it's impossible to link the library due to use of forbidden APIs:
```
src\basicio.cpp(332,33): error C2039: 'GetModuleHandleA': is not a member of '`global namespace''
src\basicio.cpp(332,49): error C3861: 'GetModuleHandleA': identifier not found
src\basicio.cpp(496,21): error C3861: 'CreateFileMapping': identifier not found
src\basicio.cpp(508,20): error C3861: 'MapViewOfFile': identifier not found
src\basicio.cpp(773,37): error C2039: 'GetModuleHandleA': is not a member of '`global namespace''
src\basicio.cpp(773,53): error C3861: 'GetModuleHandleA': identifier not found
src\futils.cpp(479,31): error C2679: binary '=': no operator found which takes a right-hand operand of type 'TCHAR [260]' (or there is no acceptable conversion)
src\version.cpp(171,10): error C3861: 'EnumProcessModules': identifier not found
loadlibrary.obj : error LNK2019: unresolved external symbol GetModuleHandle referenced in function _Expat_LoadLibrary
loadlibrary.obj : error LNK2019: unresolved external symbol LoadLibrary referenced in function _Expat_LoadLibrary
```
UWP restricts access to some APIs in name of portability.
Naïve approach could be providing empty implementations for some of those, e.g.:
```diff
diff --git a/src/makernote_int.cpp b/src/makernote_int.cpp
index 20cd7629..043daabc 100644
--- a/src/makernote_int.cpp
+++ b/src/makernote_int.cpp
@@ -95,12 +95,15 @@ namespace Exiv2 {
{
std::string homedir;
std::string inifile;
-#if defined(_MSC_VER) || defined(__MINGW__)
+#if (defined(_MSC_VER) || defined(__MINGW__))
+ // In UWP you can't access files directly. Just skip the config.
+ #if !(defined(WINAPI_FAMILY) && (WINAPI_FAMILY != WINAPI_FAMILY_DESKTOP_APP))
char path[MAX_PATH];
if (SUCCEEDED(SHGetFolderPathA(NULL, CSIDL_PROFILE, NULL, 0, path))) {
homedir = std::string(path);
inifile = "exiv2.ini" ;
}
+ #endif
#else
struct passwd* pw = getpwuid(getuid());
homedir = std::string(pw?pw->pw_dir:"");
```
Proper implementation of file access in UWP is… odd. https://docs.microsoft.com/en-us/windows/uwp/files/quickstart-reading-and-writing-files
I don't fully understand why exiv2 implements things like `mmap` (`CreateFileMapping`), dynamic loading of `kernel32.dll` in an unused function: https://github.com/Exiv2/exiv2/blob/7a652acedb77505c5708aec58d6c3c61101eee4a/src/basicio.cpp#L335 and others, so I will leave addressing this to someone else. | UWP builds not possible due to use of forbidden APIs | https://api.github.com/repos/Exiv2/exiv2/issues/1063/comments | 4 | 2019-11-18T23:06:45 | "2021-04-11T17:47:24Z" | https://github.com/Exiv2/exiv2/issues/1063 | 524,672,765 | 1,063 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : UWP builds not possible due to use of forbidden APIs
Issue date:
--- start body ---
I tried building UWP version and compilation works fine, but it's impossible to link the library due to use of forbidden APIs:
```
src\basicio.cpp(332,33): error C2039: 'GetModuleHandleA': is not a member of '`global namespace''
src\basicio.cpp(332,49): error C3861: 'GetModuleHandleA': identifier not found
src\basicio.cpp(496,21): error C3861: 'CreateFileMapping': identifier not found
src\basicio.cpp(508,20): error C3861: 'MapViewOfFile': identifier not found
src\basicio.cpp(773,37): error C2039: 'GetModuleHandleA': is not a member of '`global namespace''
src\basicio.cpp(773,53): error C3861: 'GetModuleHandleA': identifier not found
src\futils.cpp(479,31): error C2679: binary '=': no operator found which takes a right-hand operand of type 'TCHAR [260]' (or there is no acceptable conversion)
src\version.cpp(171,10): error C3861: 'EnumProcessModules': identifier not found
loadlibrary.obj : error LNK2019: unresolved external symbol GetModuleHandle referenced in function _Expat_LoadLibrary
loadlibrary.obj : error LNK2019: unresolved external symbol LoadLibrary referenced in function _Expat_LoadLibrary
```
UWP restricts access to some APIs in name of portability.
Naïve approach could be providing empty implementations for some of those, e.g.:
```diff
diff --git a/src/makernote_int.cpp b/src/makernote_int.cpp
index 20cd7629..043daabc 100644
--- a/src/makernote_int.cpp
+++ b/src/makernote_int.cpp
@@ -95,12 +95,15 @@ namespace Exiv2 {
{
std::string homedir;
std::string inifile;
-#if defined(_MSC_VER) || defined(__MINGW__)
+#if (defined(_MSC_VER) || defined(__MINGW__))
+ // In UWP you can't access files directly. Just skip the config.
+ #if !(defined(WINAPI_FAMILY) && (WINAPI_FAMILY != WINAPI_FAMILY_DESKTOP_APP))
char path[MAX_PATH];
if (SUCCEEDED(SHGetFolderPathA(NULL, CSIDL_PROFILE, NULL, 0, path))) {
homedir = std::string(path);
inifile = "exiv2.ini" ;
}
+ #endif
#else
struct passwd* pw = getpwuid(getuid());
homedir = std::string(pw?pw->pw_dir:"");
```
Proper implementation of file access in UWP is… odd. https://docs.microsoft.com/en-us/windows/uwp/files/quickstart-reading-and-writing-files
I don't fully understand why exiv2 implements things like `mmap` (`CreateFileMapping`), dynamic loading of `kernel32.dll` in an unused function: https://github.com/Exiv2/exiv2/blob/7a652acedb77505c5708aec58d6c3c61101eee4a/src/basicio.cpp#L335 and others, so I will leave addressing this to someone else.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,840 | 207,778 |
[
"Exiv2",
"exiv2"
] | As discussed in #1016 the new `boxes_check` function introduced looks a little arbitrary and it would be good to check what the JPEG2000 specification exactly says about it. | Investigate JPG2000 check_boxes | https://api.github.com/repos/Exiv2/exiv2/issues/1062/comments | 6 | 2019-11-18T18:23:02 | "2023-11-04T16:31:52Z" | https://github.com/Exiv2/exiv2/issues/1062 | 524,537,485 | 1,062 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Investigate JPG2000 check_boxes
Issue date:
--- start body ---
As discussed in #1016 the new `boxes_check` function introduced looks a little arbitrary and it would be good to check what the JPEG2000 specification exactly says about it.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 366 | 207,779 |
[
"Exiv2",
"exiv2"
] | In #1059 we added a missing windows dependency on `shell32` due to the usage of the windows function `SHGetFolderPathA()`.
According to this documentation, the function is deprecated and it should be replaced with a new mechanism.
https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderpatha | Replace deprecated SHGetFolderPathA | https://api.github.com/repos/Exiv2/exiv2/issues/1060/comments | 6 | 2019-11-18T16:18:43 | "2024-01-29T04:52:50Z" | https://github.com/Exiv2/exiv2/issues/1060 | 524,470,981 | 1,060 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Replace deprecated SHGetFolderPathA
Issue date:
--- start body ---
In #1059 we added a missing windows dependency on `shell32` due to the usage of the windows function `SHGetFolderPathA()`.
According to this documentation, the function is deprecated and it should be replaced with a new mechanism.
https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderpatha
--- end body ---
comments :
--- start comments ---
--- end comments --- | 528 | 207,780 |
[
"Exiv2",
"exiv2"
] | write fail code
exifData["Exif.Image.XPAuthor"] = "SAHARA";
exifData["Exif.Image.XPTitle"] = " sssssssssssssss";
exifData["Exif.Image.XPComment"] = "dddddddddddddd";
exifData["Exif.Image.XPSubject"] = "fffffffffffffff";
write success code
exifData["Exif.Image.Model"] = "Test 1"; // AsciiValue
exifData["Exif.Image.Make"] = "conan" ; // AsciiValue
exifData["Exif.Photo.UserComment"]= "charset=Ascii ssssssssss";
| Writing XPAuthor and other Windows Tags | https://api.github.com/repos/Exiv2/exiv2/issues/1056/comments | 1 | 2019-11-08T10:01:43 | "2020-03-22T11:12:39Z" | https://github.com/Exiv2/exiv2/issues/1056 | 519,921,850 | 1,056 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Writing XPAuthor and other Windows Tags
Issue date:
--- start body ---
write fail code
exifData["Exif.Image.XPAuthor"] = "SAHARA";
exifData["Exif.Image.XPTitle"] = " sssssssssssssss";
exifData["Exif.Image.XPComment"] = "dddddddddddddd";
exifData["Exif.Image.XPSubject"] = "fffffffffffffff";
write success code
exifData["Exif.Image.Model"] = "Test 1"; // AsciiValue
exifData["Exif.Image.Make"] = "conan" ; // AsciiValue
exifData["Exif.Photo.UserComment"]= "charset=Ascii ssssssssss";
--- end body ---
comments :
--- start comments ---
--- end comments --- | 643 | 207,781 |
[
"Exiv2",
"exiv2"
] | Exiv2 version 0.25 doesn't read the correct camera data from the Huawei P30 Pro dng file. No problem reading data from the jpg file.
ISO value is correct, but aperture and exposure are set to zero.
Camera data from the Huawei P20 Pro dng file is correct.
The zip file contains a dng file from a Huawei P30 Pro.
Thank you,
Don
[IMG_20191007_114345.zip](https://github.com/Exiv2/exiv2/files/3813349/IMG_20191007_114345.zip)
| Problem with Huawei P30 Pro camera data from dng file | https://api.github.com/repos/Exiv2/exiv2/issues/1054/comments | 7 | 2019-11-06T08:43:42 | "2020-11-11T10:58:45Z" | https://github.com/Exiv2/exiv2/issues/1054 | 518,322,511 | 1,054 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Problem with Huawei P30 Pro camera data from dng file
Issue date:
--- start body ---
Exiv2 version 0.25 doesn't read the correct camera data from the Huawei P30 Pro dng file. No problem reading data from the jpg file.
ISO value is correct, but aperture and exposure are set to zero.
Camera data from the Huawei P20 Pro dng file is correct.
The zip file contains a dng file from a Huawei P30 Pro.
Thank you,
Don
[IMG_20191007_114345.zip](https://github.com/Exiv2/exiv2/files/3813349/IMG_20191007_114345.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 657 | 207,782 |
[
"Exiv2",
"exiv2"
] | Hello,
The EXIF tag **GPSProcessingMethod** is not decoded by exiv2.
It is the tag **0x001B**.
Example:
```
exiv2 -g GPSPr image.jpg
Exif.GPSInfo.GPSProcessingMethod Undefined 14 65 83 67 73 73 0 0 0 71 80 83 0 0 0
```
The binary data is ASCII. In the example, 65 83 67 73 73 0 0 0 71 80 83 0 0 0 -> ASCII GPS
It is well decoded by exiftool. See https://sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html | Add "translated" support (-pt) for GPSProcessingMethod and GPSAreaInformation | https://api.github.com/repos/Exiv2/exiv2/issues/1046/comments | 23 | 2019-10-19T09:35:32 | "2020-03-25T20:37:48Z" | https://github.com/Exiv2/exiv2/issues/1046 | 509,424,263 | 1,046 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add "translated" support (-pt) for GPSProcessingMethod and GPSAreaInformation
Issue date:
--- start body ---
Hello,
The EXIF tag **GPSProcessingMethod** is not decoded by exiv2.
It is the tag **0x001B**.
Example:
```
exiv2 -g GPSPr image.jpg
Exif.GPSInfo.GPSProcessingMethod Undefined 14 65 83 67 73 73 0 0 0 71 80 83 0 0 0
```
The binary data is ASCII. In the example, 65 83 67 73 73 0 0 0 71 80 83 0 0 0 -> ASCII GPS
It is well decoded by exiftool. See https://sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html
--- end body ---
comments :
--- start comments ---
--- end comments --- | 672 | 207,783 |
[
"Exiv2",
"exiv2"
] | We are currently adding a bunch of additional compiler flags to detect issues. However, we are setting these globally via `set(CMAKE_CXX_FLAGS ...)`, which isn't too great. Instead we should add the flags only to our targets via [target_compile_options](https://cmake.org/cmake/help/latest/command/target_compile_options.html). This would be beneficial as we could enable `-fsanitize=fuzzer` only for the fuzzing targets in `fuzz/`. | Stop setting CMAKE_CXX_FLAGS globaly | https://api.github.com/repos/Exiv2/exiv2/issues/1039/comments | 1 | 2019-10-12T09:19:09 | "2021-04-12T17:42:25Z" | https://github.com/Exiv2/exiv2/issues/1039 | 506,160,077 | 1,039 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Stop setting CMAKE_CXX_FLAGS globaly
Issue date:
--- start body ---
We are currently adding a bunch of additional compiler flags to detect issues. However, we are setting these globally via `set(CMAKE_CXX_FLAGS ...)`, which isn't too great. Instead we should add the flags only to our targets via [target_compile_options](https://cmake.org/cmake/help/latest/command/target_compile_options.html). This would be beneficial as we could enable `-fsanitize=fuzzer` only for the fuzzing targets in `fuzz/`.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 629 | 207,784 |
[
"Exiv2",
"exiv2"
] | Are you interested in contributing but don't know where to start? Ask here, in `#exiv2-chat` on matrix.org or on the discussion mailing list: https://lists.sr.ht/~d4n/exiv2-discussion.
Is the documentation about contributions lacking? Are you missing information? Please create new issues for that, so that we can fix them. | Do you want to contribute? | https://api.github.com/repos/Exiv2/exiv2/issues/1038/comments | 1 | 2019-10-12T09:06:14 | "2021-04-12T17:03:27Z" | https://github.com/Exiv2/exiv2/issues/1038 | 506,158,595 | 1,038 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Do you want to contribute?
Issue date:
--- start body ---
Are you interested in contributing but don't know where to start? Ask here, in `#exiv2-chat` on matrix.org or on the discussion mailing list: https://lists.sr.ht/~d4n/exiv2-discussion.
Is the documentation about contributions lacking? Are you missing information? Please create new issues for that, so that we can fix them.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 513 | 207,785 |
[
"Exiv2",
"exiv2"
] | See: https://github.com/Exiv2/exiv2/pull/1025#issuecomment-540532771 | Forward port #1025 to the master branch | https://api.github.com/repos/Exiv2/exiv2/issues/1037/comments | 0 | 2019-10-11T22:48:34 | "2019-11-19T08:47:07Z" | https://github.com/Exiv2/exiv2/issues/1037 | 506,087,301 | 1,037 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Forward port #1025 to the master branch
Issue date:
--- start body ---
See: https://github.com/Exiv2/exiv2/pull/1025#issuecomment-540532771
--- end body ---
comments :
--- start comments ---
--- end comments --- | 268 | 207,786 |
[
"Exiv2",
"exiv2"
] | In https://github.com/Exiv2/exiv2/issues/1018#issuecomment-540062579 @ognarb suggested to integrate exiv2 into the KDE ecosystem. This would give us access to KDE's resources and potentially additional contributors. @phako suggested the same, but for freedesktop.org.
We should list potential pros and cons here and carefully evaluate the options. Also, what is the opinion of our API consumers? | Integrate exiv2 into the KDE or GNOME ecosystem? | https://api.github.com/repos/Exiv2/exiv2/issues/1036/comments | 13 | 2019-10-11T22:24:43 | "2021-04-12T11:00:08Z" | https://github.com/Exiv2/exiv2/issues/1036 | 506,081,735 | 1,036 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Integrate exiv2 into the KDE or GNOME ecosystem?
Issue date:
--- start body ---
In https://github.com/Exiv2/exiv2/issues/1018#issuecomment-540062579 @ognarb suggested to integrate exiv2 into the KDE ecosystem. This would give us access to KDE's resources and potentially additional contributors. @phako suggested the same, but for freedesktop.org.
We should list potential pros and cons here and carefully evaluate the options. Also, what is the opinion of our API consumers?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 607 | 207,787 |
[
"Exiv2",
"exiv2"
] | _Originally posted by @cryptomilk in https://github.com/Exiv2/exiv2/issues/1018#issuecomment-539850488_
For fuzzing and also security related fixes it is important to have the process documented. You can use: https://www.libssh.org/development/security-process/
Write down which versions you support and communicate that. Example: https://wiki.samba.org/index.php/Samba_Release_Planning
This way you can always point people to your processes. The smaller the team the less versions you should have in maintenance mode.
I hope that helps. | Define a security process | https://api.github.com/repos/Exiv2/exiv2/issues/1035/comments | 2 | 2019-10-11T22:15:47 | "2021-04-12T10:45:10Z" | https://github.com/Exiv2/exiv2/issues/1035 | 506,079,653 | 1,035 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Define a security process
Issue date:
--- start body ---
_Originally posted by @cryptomilk in https://github.com/Exiv2/exiv2/issues/1018#issuecomment-539850488_
For fuzzing and also security related fixes it is important to have the process documented. You can use: https://www.libssh.org/development/security-process/
Write down which versions you support and communicate that. Example: https://wiki.samba.org/index.php/Samba_Release_Planning
This way you can always point people to your processes. The smaller the team the less versions you should have in maintenance mode.
I hope that helps.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 735 | 207,788 |
[
"Exiv2",
"exiv2"
] | In #1007 we merged a change proposed by @clanmills which were validated by a test application which is not part of our code base (see [comment](https://github.com/Exiv2/exiv2/issues/910#issuecomment-535542824)).
The idea would be to add a test for `RemoteIo::getb()` (either a unit or system test) to validate that code. | Add test for RemoteIo::getb() | https://api.github.com/repos/Exiv2/exiv2/issues/1029/comments | 2 | 2019-10-09T06:00:47 | "2020-05-18T19:26:44Z" | https://github.com/Exiv2/exiv2/issues/1029 | 504,433,804 | 1,029 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add test for RemoteIo::getb()
Issue date:
--- start body ---
In #1007 we merged a change proposed by @clanmills which were validated by a test application which is not part of our code base (see [comment](https://github.com/Exiv2/exiv2/issues/910#issuecomment-535542824)).
The idea would be to add a test for `RemoteIo::getb()` (either a unit or system test) to validate that code.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 514 | 207,789 |
[
"Exiv2",
"exiv2"
] | From https://github.com/Exiv2/exiv2/pull/1020#issuecomment-538798087:
> Not super-happy about the location. looks odd to me, but I am not sure that the base read() should decide this, and the readDirectory() cannot decide it.
Yes, the location doesn't feel right to me either to be honest.
I am currently suspecting that the bug is in `CiffComponent::doRead`:
``` C++
void CiffComponent::doRead(const byte* pData,
uint32_t size,
uint32_t start,
ByteOrder byteOrder)
{
if (size < 10) throw Error(kerNotACrwImage);
tag_ = getUShort(pData + start, byteOrder);
DataLocId dl = dataLocation();
assert(dl == directoryData || dl == valueData);
if (dl == valueData) {
size_ = getULong(pData + start + 2, byteOrder);
offset_ = getULong(pData + start + 6, byteOrder);
}
if ( size_ > size || offset_ > size ) throw Error(kerOffsetOutOfRange); // #889
if (dl == directoryData) {
// snip
}
pData_ = pData + offset_;
#ifdef EXIV2_DEBUG_MESSAGES
// snip
#endif
} // CiffComponent::doRead
```
The malformed file hits the `dl == valueData` branch and extracts the following values:
```
size_ = 5608
offset_ = 6978
```
but the actual size of the buffer `pData` is given in `size` (10052) which is less then `size_ + offset_`. Unfortunately, the check in the line after the if doesn't find this case…
So from my current (very tired) point of view, it would be the easiest to just set `size_ = size - offset();` below the line where `pData_` is set. But when we start doing that, then we might as well remove the throw in the line with the comment `// #889`… I'll try to take another look at this tomorrow.
_Originally posted by @D4N in https://github.com/Exiv2/exiv2/pull/1020#issuecomment-538798087_
Another option would be to rewrite this whole thing using the slices API: instead of buffers pass slices into the functions and let them do the right thing (TM). | Rewrite sanity checks for the CiffComponent size & offset | https://api.github.com/repos/Exiv2/exiv2/issues/1026/comments | 2 | 2019-10-07T21:29:48 | "2023-11-04T16:32:02Z" | https://github.com/Exiv2/exiv2/issues/1026 | 503,701,189 | 1,026 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Rewrite sanity checks for the CiffComponent size & offset
Issue date:
--- start body ---
From https://github.com/Exiv2/exiv2/pull/1020#issuecomment-538798087:
> Not super-happy about the location. looks odd to me, but I am not sure that the base read() should decide this, and the readDirectory() cannot decide it.
Yes, the location doesn't feel right to me either to be honest.
I am currently suspecting that the bug is in `CiffComponent::doRead`:
``` C++
void CiffComponent::doRead(const byte* pData,
uint32_t size,
uint32_t start,
ByteOrder byteOrder)
{
if (size < 10) throw Error(kerNotACrwImage);
tag_ = getUShort(pData + start, byteOrder);
DataLocId dl = dataLocation();
assert(dl == directoryData || dl == valueData);
if (dl == valueData) {
size_ = getULong(pData + start + 2, byteOrder);
offset_ = getULong(pData + start + 6, byteOrder);
}
if ( size_ > size || offset_ > size ) throw Error(kerOffsetOutOfRange); // #889
if (dl == directoryData) {
// snip
}
pData_ = pData + offset_;
#ifdef EXIV2_DEBUG_MESSAGES
// snip
#endif
} // CiffComponent::doRead
```
The malformed file hits the `dl == valueData` branch and extracts the following values:
```
size_ = 5608
offset_ = 6978
```
but the actual size of the buffer `pData` is given in `size` (10052) which is less then `size_ + offset_`. Unfortunately, the check in the line after the if doesn't find this case…
So from my current (very tired) point of view, it would be the easiest to just set `size_ = size - offset();` below the line where `pData_` is set. But when we start doing that, then we might as well remove the throw in the line with the comment `// #889`… I'll try to take another look at this tomorrow.
_Originally posted by @D4N in https://github.com/Exiv2/exiv2/pull/1020#issuecomment-538798087_
Another option would be to rewrite this whole thing using the slices API: instead of buffers pass slices into the functions and let them do the right thing (TM).
--- end body ---
comments :
--- start comments ---
--- end comments --- | 2,355 | 207,790 |
[
"Exiv2",
"exiv2"
] | As it was discussed in #977 , the idea would be to add in `master` a RAII class named `Exiv2::Library` (or better name) which would take care of allocating/freeing library resources in a RAII fashion. At least we should have there the calls to the `XmpParser::initialize()` and `XmpParser::terminate` in case the XMP support is enabled. | Add RAII Exiv2::Library to init/free resources | https://api.github.com/repos/Exiv2/exiv2/issues/1022/comments | 1 | 2019-10-06T19:08:29 | "2023-11-04T16:32:06Z" | https://github.com/Exiv2/exiv2/issues/1022 | 503,145,504 | 1,022 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add RAII Exiv2::Library to init/free resources
Issue date:
--- start body ---
As it was discussed in #977 , the idea would be to add in `master` a RAII class named `Exiv2::Library` (or better name) which would take care of allocating/freeing library resources in a RAII fashion. At least we should have there the calls to the `XmpParser::initialize()` and `XmpParser::terminate` in case the XMP support is enabled.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 544 | 207,791 |
[
"Exiv2",
"exiv2"
] | We found vulnerability in exiv2 binary and exiv2 is complied with clang enabling ASAN.
**Machine Setup**
```
Machine : Ubuntu 16.04.3 LTS
gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.11)
Commit : 401e658
exiv2 : 0.27.99.0
Command : exiv2 -pv $POC
```
**ASAN Output**
```
fuzzer@fuzzer:~/victim/exiv2/build/bin$ ./exiv2 -pv POC
=================================================================
==16699==ERROR: AddressSanitizer: unknown-crash on address 0x7f9a857b7143 at pc 0x7f9a84dcc1db bp 0x7ffcb8c7b650 sp 0x7ffcb8c7b648
READ of size 1 at 0x7f9a857b7143 thread T0
#0 0x7f9a84dcc1da in Exiv2::getULong(unsigned char const*, Exiv2::ByteOrder) /home/fuzzer/victim/exiv2/src/types.cpp:289:28
#1 0x7f9a84ebd4c4 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) /home/fuzzer/victim/exiv2/src/crwimage_int.cpp:285:22
#2 0x7f9a84ebd84e in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) /home/fuzzer/victim/exiv2/src/crwimage_int.cpp:231:9
#3 0x7f9a84ebd84e in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) /home/fuzzer/victim/exiv2/src/crwimage_int.cpp:305
#4 0x7f9a84c5c29d in Exiv2::CrwParser::decode(Exiv2::CrwImage*, unsigned char const*, unsigned int) /home/fuzzer/victim/exiv2/src/crwimage.cpp:150:9
#5 0x7f9a84c5afa0 in Exiv2::CrwImage::readMetadata() /home/fuzzer/victim/exiv2/src/crwimage.cpp:107:9
#6 0x589421 in Action::Print::printList() /home/fuzzer/victim/exiv2/src/actions.cpp:483:9
#7 0x57c1df in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/fuzzer/victim/exiv2/src/actions.cpp:218:26
#8 0x4f4c5f in main /home/fuzzer/victim/exiv2/src/exiv2.cpp:77:23
#9 0x7f9a836be82f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291
#10 0x41ff38 in _start (/home/fuzzer/victim/exiv2/build/bin/exiv2+0x41ff38)
AddressSanitizer can not describe address in more detail (wild memory access suspected).
SUMMARY: AddressSanitizer: unknown-crash /home/fuzzer/victim/exiv2/src/types.cpp:289:28 in Exiv2::getULong(unsigned char const*, Exiv2::ByteOrder)
Shadow bytes around the buggy address:
0x0ff3d0aeedd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0ff3d0aeede0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0ff3d0aeedf0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0ff3d0aeee00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee10: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
=>0x0ff3d0aeee20: fe fe fe fe fe fe fe fe[fe]fe fe fe fe fe fe fe
0x0ff3d0aeee30: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee40: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee50: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee60: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee70: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Heap right redzone: fb
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack partial redzone: f4
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==16699==ABORTING
fuzzer@fuzzer:~/victim/exiv2/build/bin$
``` | Overflow in exiv2 | https://api.github.com/repos/Exiv2/exiv2/issues/1019/comments | 4 | 2019-10-06T09:21:25 | "2019-10-07T22:13:16Z" | https://github.com/Exiv2/exiv2/issues/1019 | 503,074,622 | 1,019 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Overflow in exiv2
Issue date:
--- start body ---
We found vulnerability in exiv2 binary and exiv2 is complied with clang enabling ASAN.
**Machine Setup**
```
Machine : Ubuntu 16.04.3 LTS
gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.11)
Commit : 401e658
exiv2 : 0.27.99.0
Command : exiv2 -pv $POC
```
**ASAN Output**
```
fuzzer@fuzzer:~/victim/exiv2/build/bin$ ./exiv2 -pv POC
=================================================================
==16699==ERROR: AddressSanitizer: unknown-crash on address 0x7f9a857b7143 at pc 0x7f9a84dcc1db bp 0x7ffcb8c7b650 sp 0x7ffcb8c7b648
READ of size 1 at 0x7f9a857b7143 thread T0
#0 0x7f9a84dcc1da in Exiv2::getULong(unsigned char const*, Exiv2::ByteOrder) /home/fuzzer/victim/exiv2/src/types.cpp:289:28
#1 0x7f9a84ebd4c4 in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) /home/fuzzer/victim/exiv2/src/crwimage_int.cpp:285:22
#2 0x7f9a84ebd84e in Exiv2::Internal::CiffComponent::read(unsigned char const*, unsigned int, unsigned int, Exiv2::ByteOrder) /home/fuzzer/victim/exiv2/src/crwimage_int.cpp:231:9
#3 0x7f9a84ebd84e in Exiv2::Internal::CiffDirectory::readDirectory(unsigned char const*, unsigned int, Exiv2::ByteOrder) /home/fuzzer/victim/exiv2/src/crwimage_int.cpp:305
#4 0x7f9a84c5c29d in Exiv2::CrwParser::decode(Exiv2::CrwImage*, unsigned char const*, unsigned int) /home/fuzzer/victim/exiv2/src/crwimage.cpp:150:9
#5 0x7f9a84c5afa0 in Exiv2::CrwImage::readMetadata() /home/fuzzer/victim/exiv2/src/crwimage.cpp:107:9
#6 0x589421 in Action::Print::printList() /home/fuzzer/victim/exiv2/src/actions.cpp:483:9
#7 0x57c1df in Action::Print::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/fuzzer/victim/exiv2/src/actions.cpp:218:26
#8 0x4f4c5f in main /home/fuzzer/victim/exiv2/src/exiv2.cpp:77:23
#9 0x7f9a836be82f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291
#10 0x41ff38 in _start (/home/fuzzer/victim/exiv2/build/bin/exiv2+0x41ff38)
AddressSanitizer can not describe address in more detail (wild memory access suspected).
SUMMARY: AddressSanitizer: unknown-crash /home/fuzzer/victim/exiv2/src/types.cpp:289:28 in Exiv2::getULong(unsigned char const*, Exiv2::ByteOrder)
Shadow bytes around the buggy address:
0x0ff3d0aeedd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0ff3d0aeede0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0ff3d0aeedf0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0ff3d0aeee00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee10: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
=>0x0ff3d0aeee20: fe fe fe fe fe fe fe fe[fe]fe fe fe fe fe fe fe
0x0ff3d0aeee30: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee40: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee50: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee60: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
0x0ff3d0aeee70: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Heap right redzone: fb
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack partial redzone: f4
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==16699==ABORTING
fuzzer@fuzzer:~/victim/exiv2/build/bin$
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,016 | 207,792 |
[
"Exiv2",
"exiv2"
] | Recently our main contributor Robin (@clanmills) decided to retire from the project effective immediately. We don't have to fool ourselves: Robin has been the driving force behind this project for roughly a decade now and invested a truly **insane** amount of time and effort into it. No one of the currently active contributors has either the time or the expertise to match him. This leaves us in a tough spot: how can we keep this project alive and going?
### Current state
- me and @piponazo are unfortunately currently rather busy in our offline lives and cannot invest a lot of time into exiv2. I was unable to keep up with all the bug reports & pull requests, which (as expected) resulted in a lot of frustration from the other contributors.
- no one of the current contributors has the expertise and endurance matching that of @clanmills
- without @clanmills we are badly understaffed (more than before) to even perform basic maintenance
- the exiv2 webpage is run by Robin, as is the Jenkins build server which produces the release binaries
### Short term steps
I propose the following to steps in the short term (until the end of 2019):
- Move the project into (hard) maintenance mode: i.e. no new features, just bugfixes.
- Ensure that we can produce a 0.27.3 release by the end of 2019: create releases on our current CI without Jenkins. A prerequisite for that is that we can build exiv2 in a reproducible fashion (which is possible, openSUSE is already doing that with one patch).
- Move the exiv2 webpage to github or gitlab pages.
- Migrate all existing svn repositories that are still out there to git under the Exiv2 org
### Long term steps
I see the following options:
- We find new contributors. Imho unfortunately rather unlikely, as the past showed. We can try to raise awareness about exiv2, but unfortunately I don't really know how to make this project appealing to new contributors.
- We find a corporate sponsor, who will sponsor at least some development time. Due to the removal of the (imho) legally questionable commercial licenses, our usage of the GPL2+ and our place in a rather non-existent commercial market (Linux Desktop application dependency), we're in a pretty rough spot for this. We might try our luck with one of the big enterprise Linux vendors (RedHat, SUSE, Canonical, etc.), provided that we are in their enterprise support package.
- We rewrite the whole thing? I know this sounds crazy (and probably is), but imho exiv2 shows its age and developers like to work on the new hot stuff™ and not maintain an old application. So we might attract a few people if we decide to rewrite in a new language using new features, etc. **But**, this is going to alienate our current API consumers and it will take **years** before we achieve feature parity (if we even ever manage to do that). So not sure how realistic this is, probably not much.
- Drastically reduce the scope of Exiv2 to match only what our API consumers require (cc @cgilles @phako)?
- ???
### What can we do to improve our processes?
The past showed that our current contribution process became rather complicated, which already drove away contributors. This is **bad**.
How can we improve for one time contributors?
- Offer patch submission via email? (WIP via sr.ht: https://git.sr.ht/~d4n/exiv2)
- Don't require strict code review from early contributors, but instead fix contributed code ourselves to reach the desired quality standard.
How can we improve the process for long term contributors?
- Pull requests don't get reviewed and cannot be merged :disappointed:. => We could specify a ~2 week grace period for a review, where the PR author should send a weekly review reminder. If the PR author is a "proven contributor", then they can exercise their right to merge an unreviewed PR, provided that the CI is green.
- CI is flaky and breaks, only one person can fix it (@D4N for GitLab, @piponazo for Appveyor). If the person is busy, PRs are red and cannot be merged :disappointed:. => We could move the tests to github actions, so that everyone has access to them and can fix the issues.
- PR reviews are merciless and annoying because a lot of minor stuff gets flagged. I am the culprit in this case. If this is a stop gap for many, then I will stop reviewing PRs in detail and instead amend them to fix issues that I find need fixing (provided I have time).
How can we attract more people to contribute?
- *Your idea here*
Any further ideas/comments/suggestions? | Exiv2 RoadMap | https://api.github.com/repos/Exiv2/exiv2/issues/1018/comments | 48 | 2019-10-05T15:55:36 | "2023-11-04T16:32:10Z" | https://github.com/Exiv2/exiv2/issues/1018 | 502,980,354 | 1,018 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Exiv2 RoadMap
Issue date:
--- start body ---
Recently our main contributor Robin (@clanmills) decided to retire from the project effective immediately. We don't have to fool ourselves: Robin has been the driving force behind this project for roughly a decade now and invested a truly **insane** amount of time and effort into it. No one of the currently active contributors has either the time or the expertise to match him. This leaves us in a tough spot: how can we keep this project alive and going?
### Current state
- me and @piponazo are unfortunately currently rather busy in our offline lives and cannot invest a lot of time into exiv2. I was unable to keep up with all the bug reports & pull requests, which (as expected) resulted in a lot of frustration from the other contributors.
- no one of the current contributors has the expertise and endurance matching that of @clanmills
- without @clanmills we are badly understaffed (more than before) to even perform basic maintenance
- the exiv2 webpage is run by Robin, as is the Jenkins build server which produces the release binaries
### Short term steps
I propose the following to steps in the short term (until the end of 2019):
- Move the project into (hard) maintenance mode: i.e. no new features, just bugfixes.
- Ensure that we can produce a 0.27.3 release by the end of 2019: create releases on our current CI without Jenkins. A prerequisite for that is that we can build exiv2 in a reproducible fashion (which is possible, openSUSE is already doing that with one patch).
- Move the exiv2 webpage to github or gitlab pages.
- Migrate all existing svn repositories that are still out there to git under the Exiv2 org
### Long term steps
I see the following options:
- We find new contributors. Imho unfortunately rather unlikely, as the past showed. We can try to raise awareness about exiv2, but unfortunately I don't really know how to make this project appealing to new contributors.
- We find a corporate sponsor, who will sponsor at least some development time. Due to the removal of the (imho) legally questionable commercial licenses, our usage of the GPL2+ and our place in a rather non-existent commercial market (Linux Desktop application dependency), we're in a pretty rough spot for this. We might try our luck with one of the big enterprise Linux vendors (RedHat, SUSE, Canonical, etc.), provided that we are in their enterprise support package.
- We rewrite the whole thing? I know this sounds crazy (and probably is), but imho exiv2 shows its age and developers like to work on the new hot stuff™ and not maintain an old application. So we might attract a few people if we decide to rewrite in a new language using new features, etc. **But**, this is going to alienate our current API consumers and it will take **years** before we achieve feature parity (if we even ever manage to do that). So not sure how realistic this is, probably not much.
- Drastically reduce the scope of Exiv2 to match only what our API consumers require (cc @cgilles @phako)?
- ???
### What can we do to improve our processes?
The past showed that our current contribution process became rather complicated, which already drove away contributors. This is **bad**.
How can we improve for one time contributors?
- Offer patch submission via email? (WIP via sr.ht: https://git.sr.ht/~d4n/exiv2)
- Don't require strict code review from early contributors, but instead fix contributed code ourselves to reach the desired quality standard.
How can we improve the process for long term contributors?
- Pull requests don't get reviewed and cannot be merged :disappointed:. => We could specify a ~2 week grace period for a review, where the PR author should send a weekly review reminder. If the PR author is a "proven contributor", then they can exercise their right to merge an unreviewed PR, provided that the CI is green.
- CI is flaky and breaks, only one person can fix it (@D4N for GitLab, @piponazo for Appveyor). If the person is busy, PRs are red and cannot be merged :disappointed:. => We could move the tests to github actions, so that everyone has access to them and can fix the issues.
- PR reviews are merciless and annoying because a lot of minor stuff gets flagged. I am the culprit in this case. If this is a stop gap for many, then I will stop reviewing PRs in detail and instead amend them to fix issues that I find need fixing (provided I have time).
How can we attract more people to contribute?
- *Your idea here*
Any further ideas/comments/suggestions?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,709 | 207,793 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
I have some pictures using two lenses I had some years back and they seems to be still missing from the exiv2. I used the following `.exiv2`:
```
[nikon]
164=AF-S Nikkor 70-200mm f/2.8E FL ED VR
170=AF-S Nikkor 24-70mm f/2.8E ED VR
```
**To Reproduce**
Steps to reproduce the behaviour:
1. Run exiv2 on the existing photos
2. Lenses are not detected
The metadata from pictures:
```
$ exiv2 -pv --grep Lens DSC_0003.JPG
0x0083 Nikon3 LensType Byte 1 78
0x0084 Nikon3 Lens Rational 4 240/10 700/10 28/10 28/10
0x008b Nikon3 LensFStops Undefined 4 72 1 12 0
0x000c NikonLd3 LensIDNumber Byte 1 170
0x000d NikonLd3 LensFStops Byte 1 72
```
and
```
$ exiv2 -pv --grep Lens DSC_0170.NEF
0x0083 Nikon3 LensType Byte 1 78
0x0084 Nikon3 Lens Rational 4 240/10 700/10 28/10 28/10
0x008b Nikon3 LensFStops Undefined 4 72 1 12 0
0x000c NikonLd3 LensIDNumber Byte 1 170
0x000d NikonLd3 LensFStops Byte 1 72
```
**Expected behavior**
The lens should be detected.
**Desktop (please complete the following information):**
- OS: Linux
- Compiler & Version [Gcc 7.3, Clang-6, MSVC 2017]
- Compilation mode and/or compiler flags
**Additional context**
I would be able to contribute the code, but it is not particularly clear to me how and what all values I am supposed to use in the `src/nikonmn_int.cpp` to get the correct behavior. So either point me how I should do or feel free to add the data. I can also provide images if necessary. | Two Nikon lenses still not detected | https://api.github.com/repos/Exiv2/exiv2/issues/1014/comments | 10 | 2019-10-01T19:21:19 | "2019-10-12T15:57:51Z" | https://github.com/Exiv2/exiv2/issues/1014 | 501,095,693 | 1,014 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Two Nikon lenses still not detected
Issue date:
--- start body ---
**Describe the bug**
I have some pictures using two lenses I had some years back and they seems to be still missing from the exiv2. I used the following `.exiv2`:
```
[nikon]
164=AF-S Nikkor 70-200mm f/2.8E FL ED VR
170=AF-S Nikkor 24-70mm f/2.8E ED VR
```
**To Reproduce**
Steps to reproduce the behaviour:
1. Run exiv2 on the existing photos
2. Lenses are not detected
The metadata from pictures:
```
$ exiv2 -pv --grep Lens DSC_0003.JPG
0x0083 Nikon3 LensType Byte 1 78
0x0084 Nikon3 Lens Rational 4 240/10 700/10 28/10 28/10
0x008b Nikon3 LensFStops Undefined 4 72 1 12 0
0x000c NikonLd3 LensIDNumber Byte 1 170
0x000d NikonLd3 LensFStops Byte 1 72
```
and
```
$ exiv2 -pv --grep Lens DSC_0170.NEF
0x0083 Nikon3 LensType Byte 1 78
0x0084 Nikon3 Lens Rational 4 240/10 700/10 28/10 28/10
0x008b Nikon3 LensFStops Undefined 4 72 1 12 0
0x000c NikonLd3 LensIDNumber Byte 1 170
0x000d NikonLd3 LensFStops Byte 1 72
```
**Expected behavior**
The lens should be detected.
**Desktop (please complete the following information):**
- OS: Linux
- Compiler & Version [Gcc 7.3, Clang-6, MSVC 2017]
- Compilation mode and/or compiler flags
**Additional context**
I would be able to contribute the code, but it is not particularly clear to me how and what all values I am supposed to use in the `src/nikonmn_int.cpp` to get the correct behavior. So either point me how I should do or feel free to add the data. I can also provide images if necessary.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,982 | 207,794 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
An input file can result in an infinite loop and hang, with high CPU consumption. Remote attackers could leverage this vulnerability to cause a denial of service via a crafted file.
**To Reproduce**
Steps to reproduce the behaviour:
excute 'build/bin/exiv2 Jp2Image_readMetadata_loop.poc'
**Expected behavior**
An infinite loop and hang, with high CPU consumption
**Additional context**
The poc is here
[Jp2Image_readMetadata_loop.poc.zip](https://github.com/Exiv2/exiv2/files/3670911/Jp2Image_readMetadata_loop.poc.zip)
The code:
> io_->seek(restore,BasicIo::beg);
> io_->seek(subBox.length, Exiv2::BasicIo::cur);
leads to an infinite loop.
| An infinite loop and hang in Exiv2::Jp2Image::readMetadata() | https://api.github.com/repos/Exiv2/exiv2/issues/1011/comments | 3 | 2019-09-30T12:02:01 | "2020-03-29T11:43:49Z" | https://github.com/Exiv2/exiv2/issues/1011 | 500,231,156 | 1,011 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : An infinite loop and hang in Exiv2::Jp2Image::readMetadata()
Issue date:
--- start body ---
**Describe the bug**
An input file can result in an infinite loop and hang, with high CPU consumption. Remote attackers could leverage this vulnerability to cause a denial of service via a crafted file.
**To Reproduce**
Steps to reproduce the behaviour:
excute 'build/bin/exiv2 Jp2Image_readMetadata_loop.poc'
**Expected behavior**
An infinite loop and hang, with high CPU consumption
**Additional context**
The poc is here
[Jp2Image_readMetadata_loop.poc.zip](https://github.com/Exiv2/exiv2/files/3670911/Jp2Image_readMetadata_loop.poc.zip)
The code:
> io_->seek(restore,BasicIo::beg);
> io_->seek(subBox.length, Exiv2::BasicIo::cur);
leads to an infinite loop.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,028 | 207,795 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Add support for Sony 0x2010 tag
This has been reported by email from @sridharb1
Shridar said _"The same code when run against your test file (test/data/exiv2-pr906.exv) outputs values for the tags that I defined"_
I attach his patch and test image.
[sonyChanges.txt](https://github.com/Exiv2/exiv2/files/3662730/sonyChanges.txt)
There are several 2010 tags:
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag20101
Tag2010a Tag2010b Tag2010c Tag2010d Tag2010e Tag2010f Tag2010g Tag2010h Tag2010i
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010a
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010b
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010c
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010d
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010e
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010f
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010g
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010h
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag20101i
I've allocated this to milestone v0.27.3, however it's likely to be deferred for v0.27.4 (scheduled for 2019-12-31).
| Sony 0x2010 tag support | https://api.github.com/repos/Exiv2/exiv2/issues/1008/comments | 32 | 2019-09-27T12:38:26 | "2020-03-29T17:05:23Z" | https://github.com/Exiv2/exiv2/issues/1008 | 499,421,611 | 1,008 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Sony 0x2010 tag support
Issue date:
--- start body ---
**Describe the bug**
Add support for Sony 0x2010 tag
This has been reported by email from @sridharb1
Shridar said _"The same code when run against your test file (test/data/exiv2-pr906.exv) outputs values for the tags that I defined"_
I attach his patch and test image.
[sonyChanges.txt](https://github.com/Exiv2/exiv2/files/3662730/sonyChanges.txt)
There are several 2010 tags:
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag20101
Tag2010a Tag2010b Tag2010c Tag2010d Tag2010e Tag2010f Tag2010g Tag2010h Tag2010i
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010a
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010b
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010c
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010d
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010e
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010f
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010g
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag2010h
https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Sony.html#Tag20101i
I've allocated this to milestone v0.27.3, however it's likely to be deferred for v0.27.4 (scheduled for 2019-12-31).
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,612 | 207,796 |
[
"Exiv2",
"exiv2"
] | I am attaching a patch against canonmn_int.cpp that brings exiv2 to almost the latest exiftool Canon.pm (possibly to a couple of weeks ago). Apart from the name differences, there are some space differences in the lens section because the alignment of the numbers 1-999 have only 5 characters before the "," and numbers greater than them have 6 characters before the ",". I standardized on 6 characters before the ",".
With this, you get only 6 failures in the test suite whose output can easily be updated, as opposed 96 differences between exiv2 and exiftool. The advantage with using the patched version is that it is easier to catch up to exiftool afterwards because the comparison would result only in additions (theoretically).
Please note that there are 6 differences that crop up in the test tool whose output need updates to these changed lens names.
[canonmn_int.cpp.patch.zip](https://github.com/Exiv2/exiv2/files/3635564/canonmn_int.cpp.patch.zip)
| Catchup with the latest Canon tags from exiftool | https://api.github.com/repos/Exiv2/exiv2/issues/1004/comments | 26 | 2019-09-20T11:02:37 | "2020-04-13T22:56:24Z" | https://github.com/Exiv2/exiv2/issues/1004 | 496,288,970 | 1,004 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Catchup with the latest Canon tags from exiftool
Issue date:
--- start body ---
I am attaching a patch against canonmn_int.cpp that brings exiv2 to almost the latest exiftool Canon.pm (possibly to a couple of weeks ago). Apart from the name differences, there are some space differences in the lens section because the alignment of the numbers 1-999 have only 5 characters before the "," and numbers greater than them have 6 characters before the ",". I standardized on 6 characters before the ",".
With this, you get only 6 failures in the test suite whose output can easily be updated, as opposed 96 differences between exiv2 and exiftool. The advantage with using the patched version is that it is easier to catch up to exiftool afterwards because the comparison would result only in additions (theoretically).
Please note that there are 6 differences that crop up in the test tool whose output need updates to these changed lens names.
[canonmn_int.cpp.patch.zip](https://github.com/Exiv2/exiv2/files/3635564/canonmn_int.cpp.patch.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,179 | 207,797 |
[
"Exiv2",
"exiv2"
] | exiv2-0.27.2 does not decode the data of the IPTC tag 0x005a correctly
For an image which contains the tag, the output from Exiv2 is
0x005a Envelope Iptc.Envelope.CharacterSet CharacterSet Character Set %G <<<<<< should be translated to UTF-8
I am attaching an image which shows the output, but there was a discussion some time ago @ https://dev.exiv2.org/boards/3/topics/1288 where Robin showed the output from one of his images
C:\Users\rmills\Desktop>exiv2 -pi robin.jpg
Iptc.Envelope.ModelVersion Short 1 4
Iptc.Envelope.CharacterSet String 3 ←%G
In my case the output was from a command line such as:
D:\>D:\pkg\C++\MSVC2017\exiv2-master-0.27.2\exiv2-0.27.2-Source\build32ReleaseStatic\bin\exiv2.exe -PIXxgklnt D:\wxIctest\Media\headst\indi\PerdueAnnElizabeth-GraveMarker-FAG-62151533_132727369452.jpg
Running under Windows 10,
With some searching, I have been able to track down the following bits and pieces
The output comes from code in Exiv2 code actions.cpp somewhere between line #662 & 758 or there about
The above output was taken from a UTF-8 enabled Win 10 DOS console window; without the UTF-8 facility the string %G does not show.
Initially I found the issue in my test app, which is able to handle UTF-8 strings.
It seems this is a rather obscure part of the standards, but I have been able to find a reference in the ISO/IEC 10646 standard of 2017/12 on page 19
obtainable from: https://standards.iso.org/ittf/PubliclyAvailableStandards/c069119_ISO_IEC_10646_2017.zip
_12.2 Identification of a UCS encoding scheme
When the escape sequences from ISO/IEC 2022 are used, the identification of a UCS encoding scheme (see
Clause 10) specified by this International Standard shall be by a designation sequence chosen from the following
list:
ESC 02/05 02/15 04/09
UTF-8 encoding form; UTF-8 encoding scheme
ESC 02/05 02/15 04/12
UTF-16 encoding form; UTF-16BE encoding scheme
ESC 02/05 02/15 04/06
UTF-32 encoding form; UTF-32BE encoding scheme
NOTE – The following designation sequences: ESC 02/05 02/15 04/00, ESC 02/05 02/15 04/01, ESC 02/05 02/15 04/03, ESC 02/05
02/15 04/04, ESC 02/05 02/15 04/07, ESC 02/05 02/15 04/08, ESC 02/05 02/15 04/10, ESC 02/05 02/15 04/11 used in previous
versions of this standard to identify implementation levels 1 and 2 are deprecated. The remaining designation sequences correspond
to the former level 3 which is now the only supported content definition for code unit sequences.
ESC 02/05 04/07
UTF-8 encoding form; UTF-8 encoding scheme
If such an escape sequence appears within a code unit sequence conforming to ISO/IEC 2022, it shall consist
only of the sequences of bit combinations as shown above.
If such an escape sequence appears within a code unit sequence conforming to this International Standard, it
shall be padded in accordance with Clause 11 when the identified encoding form is either UTF-16 or UTF-32.
No padding is necessary when the identified encoding form is UTF-8. See also 12.5._
There are references to this 'conversion/translation in convert.cpp at about line 1174, though in my limited testing this code was not accessed.
Still, I am not at all familiar with the workings of the Exiv2 code that deep in the bowels of the libraries and so I have shelved this issue at my end for now. FWIW, Exiftool does identify this 'code' correctly.
In the image I am attaching, there is no text which would require knowledge of the character set, but some other images in the same series definitely contain UTF-8 encoded strings, so that knowing the character set becomes important.
AFAIK, all this data was added by XnViewMP, which seems to stick with this character set by default, I would expect that there will be images about with different character sets, though I have not come across any others.
| Iptc.Envelope.CharacterSet not reported correctly | https://api.github.com/repos/Exiv2/exiv2/issues/1003/comments | 11 | 2019-09-19T18:28:53 | "2019-10-01T18:32:23Z" | https://github.com/Exiv2/exiv2/issues/1003 | 495,959,348 | 1,003 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Iptc.Envelope.CharacterSet not reported correctly
Issue date:
--- start body ---
exiv2-0.27.2 does not decode the data of the IPTC tag 0x005a correctly
For an image which contains the tag, the output from Exiv2 is
0x005a Envelope Iptc.Envelope.CharacterSet CharacterSet Character Set %G <<<<<< should be translated to UTF-8
I am attaching an image which shows the output, but there was a discussion some time ago @ https://dev.exiv2.org/boards/3/topics/1288 where Robin showed the output from one of his images
C:\Users\rmills\Desktop>exiv2 -pi robin.jpg
Iptc.Envelope.ModelVersion Short 1 4
Iptc.Envelope.CharacterSet String 3 ←%G
In my case the output was from a command line such as:
D:\>D:\pkg\C++\MSVC2017\exiv2-master-0.27.2\exiv2-0.27.2-Source\build32ReleaseStatic\bin\exiv2.exe -PIXxgklnt D:\wxIctest\Media\headst\indi\PerdueAnnElizabeth-GraveMarker-FAG-62151533_132727369452.jpg
Running under Windows 10,
With some searching, I have been able to track down the following bits and pieces
The output comes from code in Exiv2 code actions.cpp somewhere between line #662 & 758 or there about
The above output was taken from a UTF-8 enabled Win 10 DOS console window; without the UTF-8 facility the string %G does not show.
Initially I found the issue in my test app, which is able to handle UTF-8 strings.
It seems this is a rather obscure part of the standards, but I have been able to find a reference in the ISO/IEC 10646 standard of 2017/12 on page 19
obtainable from: https://standards.iso.org/ittf/PubliclyAvailableStandards/c069119_ISO_IEC_10646_2017.zip
_12.2 Identification of a UCS encoding scheme
When the escape sequences from ISO/IEC 2022 are used, the identification of a UCS encoding scheme (see
Clause 10) specified by this International Standard shall be by a designation sequence chosen from the following
list:
ESC 02/05 02/15 04/09
UTF-8 encoding form; UTF-8 encoding scheme
ESC 02/05 02/15 04/12
UTF-16 encoding form; UTF-16BE encoding scheme
ESC 02/05 02/15 04/06
UTF-32 encoding form; UTF-32BE encoding scheme
NOTE – The following designation sequences: ESC 02/05 02/15 04/00, ESC 02/05 02/15 04/01, ESC 02/05 02/15 04/03, ESC 02/05
02/15 04/04, ESC 02/05 02/15 04/07, ESC 02/05 02/15 04/08, ESC 02/05 02/15 04/10, ESC 02/05 02/15 04/11 used in previous
versions of this standard to identify implementation levels 1 and 2 are deprecated. The remaining designation sequences correspond
to the former level 3 which is now the only supported content definition for code unit sequences.
ESC 02/05 04/07
UTF-8 encoding form; UTF-8 encoding scheme
If such an escape sequence appears within a code unit sequence conforming to ISO/IEC 2022, it shall consist
only of the sequences of bit combinations as shown above.
If such an escape sequence appears within a code unit sequence conforming to this International Standard, it
shall be padded in accordance with Clause 11 when the identified encoding form is either UTF-16 or UTF-32.
No padding is necessary when the identified encoding form is UTF-8. See also 12.5._
There are references to this 'conversion/translation in convert.cpp at about line 1174, though in my limited testing this code was not accessed.
Still, I am not at all familiar with the workings of the Exiv2 code that deep in the bowels of the libraries and so I have shelved this issue at my end for now. FWIW, Exiftool does identify this 'code' correctly.
In the image I am attaching, there is no text which would require knowledge of the character set, but some other images in the same series definitely contain UTF-8 encoded strings, so that knowing the character set becomes important.
AFAIK, all this data was added by XnViewMP, which seems to stick with this character set by default, I would expect that there will be images about with different character sets, though I have not come across any others.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,314 | 207,798 |
[
"Exiv2",
"exiv2"
] | #981 adds recognition for Canon AutoFocus Metadata. The tag "Exif.Canon.AFPrimaryPoint" records points that should be ignored by the AutoFocus.
The name AFPrimaryPoint was chosen to align with ExifTool Documentation. https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html
Suggestions (from @derselbst) for alternative names are "AFPointsDisabled" and "AFPointsUnusable" If we agree on a change of tag name, this will be released in Exiv2 v0.27.4. I don't want to delay Exiv2 v0.27.3 while this is discussed.
@boardhead Can you give us your opinion about this, please?
Here are Tom's notes about Canon AutoFocus Metadata. https://github.com/Exiv2/exiv2/issues/981#issuecomment-524564157 | Rename tag Exif.Canon.AFPrimaryPoint | https://api.github.com/repos/Exiv2/exiv2/issues/1001/comments | 6 | 2019-09-17T16:17:44 | "2020-03-28T15:19:18Z" | https://github.com/Exiv2/exiv2/issues/1001 | 494,722,121 | 1,001 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Rename tag Exif.Canon.AFPrimaryPoint
Issue date:
--- start body ---
#981 adds recognition for Canon AutoFocus Metadata. The tag "Exif.Canon.AFPrimaryPoint" records points that should be ignored by the AutoFocus.
The name AFPrimaryPoint was chosen to align with ExifTool Documentation. https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html
Suggestions (from @derselbst) for alternative names are "AFPointsDisabled" and "AFPointsUnusable" If we agree on a change of tag name, this will be released in Exiv2 v0.27.4. I don't want to delay Exiv2 v0.27.3 while this is discussed.
@boardhead Can you give us your opinion about this, please?
Here are Tom's notes about Canon AutoFocus Metadata. https://github.com/Exiv2/exiv2/issues/981#issuecomment-524564157
--- end body ---
comments :
--- start comments ---
--- end comments --- | 906 | 207,799 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
Building samples sometimes does not add include/ and include/exiv2 to system search path.
I've been having trouble with this. Having investigated and written this report, I can't reproduce this. So I expect you'll mark it "not reproducible". I'll record this for the moment.
When you change include/exiv2 files (such as include/exiv2.hpp), you have to build/install exiv2 for the change to be known to sample applications.
The reason is because the project include/ and include/exiv2 are not on the system path when we build samples.
**To Reproduce**
Add something to an include file such as include/exiv2/exiv2.hpp. For example:
```
#define my_cout std::cout
```
And add a reference to samples/exifprint.cpp
```
my_cout << "hello world\n"
```
The command `$ make exifprint` will fail to compile
**Expected behavior**
Compile will succeed.
**Desktop (please complete the following information):**
All platforms.
**Additional context**
I believe the fix is (target_include_directories code from src/CMakeLists.txt)
```
--- a/samples/CMakeLists.txt
+++ b/samples/CMakeLists.txt
@@ -42,6 +42,8 @@ foreach(entry ${SAMPLES})
list(APPEND APPLICATIONS ${target})
add_test( ${target}_test ${target} )
target_include_directories(${target} PRIVATE ${CMAKE_SOURCE_DIR}/src) # To find unused.h
+ # Use include/ and include/exiv2 to build samples (to find exiv2/exiv2.hpp and descendants)
+ target_include_directories(${target} PRIVATE ${PROJECT_SOURCE_DIR}/include ${PROJECT_SOURCE_DIR}/include/exiv2)
install( TARGETS ${target} RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
endforeach()
``` | Building samples sometimes does not add include/ and include/exiv2 to system search path | https://api.github.com/repos/Exiv2/exiv2/issues/1000/comments | 0 | 2019-09-16T08:21:06 | "2019-09-16T08:26:48Z" | https://github.com/Exiv2/exiv2/issues/1000 | 493,908,351 | 1,000 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Building samples sometimes does not add include/ and include/exiv2 to system search path
Issue date:
--- start body ---
**Describe the bug**
Building samples sometimes does not add include/ and include/exiv2 to system search path.
I've been having trouble with this. Having investigated and written this report, I can't reproduce this. So I expect you'll mark it "not reproducible". I'll record this for the moment.
When you change include/exiv2 files (such as include/exiv2.hpp), you have to build/install exiv2 for the change to be known to sample applications.
The reason is because the project include/ and include/exiv2 are not on the system path when we build samples.
**To Reproduce**
Add something to an include file such as include/exiv2/exiv2.hpp. For example:
```
#define my_cout std::cout
```
And add a reference to samples/exifprint.cpp
```
my_cout << "hello world\n"
```
The command `$ make exifprint` will fail to compile
**Expected behavior**
Compile will succeed.
**Desktop (please complete the following information):**
All platforms.
**Additional context**
I believe the fix is (target_include_directories code from src/CMakeLists.txt)
```
--- a/samples/CMakeLists.txt
+++ b/samples/CMakeLists.txt
@@ -42,6 +42,8 @@ foreach(entry ${SAMPLES})
list(APPEND APPLICATIONS ${target})
add_test( ${target}_test ${target} )
target_include_directories(${target} PRIVATE ${CMAKE_SOURCE_DIR}/src) # To find unused.h
+ # Use include/ and include/exiv2 to build samples (to find exiv2/exiv2.hpp and descendants)
+ target_include_directories(${target} PRIVATE ${PROJECT_SOURCE_DIR}/include ${PROJECT_SOURCE_DIR}/include/exiv2)
install( TARGETS ${target} RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
endforeach()
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,934 | 207,800 |
[
"Exiv2",
"exiv2"
] | Please add an entry for the "Sigma 17-70mm F2.8-4 DC Macro HSM Contemporary" lens to the minoltamn_int.cpp file. Yes, I know there is already an entry for the "Sigma 17-70mm F2.8-4 DC Macro HSM" but these are different lenses. For instance the elements/groups count is different. Also, lensfun has a different set of corrections for each lens.
Unfortunately, both lenses use id 128 :( This probably means the [exiv file](https://dev.exiv2.org/projects/exiv2/wiki/Lens_Recognition_in_Exiv2_v026_(and_later)/) needs to be used.
| Add lens support for Sigma 17-70mm F2.8-4 Contemporary | https://api.github.com/repos/Exiv2/exiv2/issues/998/comments | 7 | 2019-09-11T09:12:26 | "2019-09-12T06:53:13Z" | https://github.com/Exiv2/exiv2/issues/998 | 492,112,626 | 998 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Add lens support for Sigma 17-70mm F2.8-4 Contemporary
Issue date:
--- start body ---
Please add an entry for the "Sigma 17-70mm F2.8-4 DC Macro HSM Contemporary" lens to the minoltamn_int.cpp file. Yes, I know there is already an entry for the "Sigma 17-70mm F2.8-4 DC Macro HSM" but these are different lenses. For instance the elements/groups count is different. Also, lensfun has a different set of corrections for each lens.
Unfortunately, both lenses use id 128 :( This probably means the [exiv file](https://dev.exiv2.org/projects/exiv2/wiki/Lens_Recognition_in_Exiv2_v026_(and_later)/) needs to be used.
--- end body ---
comments :
--- start comments ---
--- end comments --- | 746 | 207,801 |
[
"Exiv2",
"exiv2"
] | <pre>[ 48%] <font color="#4E9A06"><b>Linking CXX executable ../bin/unit_tests</b></font>
cd /home/tkloczko/rpmbuild/BUILD/exiv2-0.27.2/unitTests && /usr/bin/cmake -E cmake_link_script CMakeFiles/unit_tests.dir/link.txt --verbose=1
/usr/bin/g++ -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto -Wall -Wcast-align -Wpointer-arith -Wformat-security -Wmissing-format-attribute -Woverloaded-virtual -W -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto -fuse-linker-plugin -rdynamic CMakeFiles/unit_tests.dir/mainTestRunner.cpp.o CMakeFiles/unit_tests.dir/test_basicio.cpp.o CMakeFiles/unit_tests.dir/test_types.cpp.o CMakeFiles/unit_tests.dir/test_tiffheader.cpp.o CMakeFiles/unit_tests.dir/test_futils.cpp.o CMakeFiles/unit_tests.dir/test_enforce.cpp.o CMakeFiles/unit_tests.dir/test_safe_op.cpp.o CMakeFiles/unit_tests.dir/test_XmpKey.cpp.o CMakeFiles/unit_tests.dir/test_DateValue.cpp.o CMakeFiles/unit_tests.dir/test_TimeValue.cpp.o CMakeFiles/unit_tests.dir/test_cr2header_int.cpp.o CMakeFiles/unit_tests.dir/test_helper_functions.cpp.o CMakeFiles/unit_tests.dir/test_slice.cpp.o CMakeFiles/unit_tests.dir/test_image_int.cpp.o CMakeFiles/unit_tests.dir/__/src/basicio.cpp.o CMakeFiles/unit_tests.dir/__/src/bigtiffimage.cpp.o CMakeFiles/unit_tests.dir/__/src/bmpimage.cpp.o CMakeFiles/unit_tests.dir/__/src/convert.cpp.o CMakeFiles/unit_tests.dir/__/src/cr2image.cpp.o CMakeFiles/unit_tests.dir/__/src/crwimage.cpp.o CMakeFiles/unit_tests.dir/__/src/datasets.cpp.o CMakeFiles/unit_tests.dir/__/src/easyaccess.cpp.o CMakeFiles/unit_tests.dir/__/src/epsimage.cpp.o CMakeFiles/unit_tests.dir/__/src/error.cpp.o CMakeFiles/unit_tests.dir/__/src/exif.cpp.o CMakeFiles/unit_tests.dir/__/src/futils.cpp.o CMakeFiles/unit_tests.dir/__/src/gifimage.cpp.o CMakeFiles/unit_tests.dir/__/src/http.cpp.o CMakeFiles/unit_tests.dir/__/src/image.cpp.o CMakeFiles/unit_tests.dir/__/src/ini.cpp.o CMakeFiles/unit_tests.dir/__/src/iptc.cpp.o CMakeFiles/unit_tests.dir/__/src/jp2image.cpp.o CMakeFiles/unit_tests.dir/__/src/jpgimage.cpp.o CMakeFiles/unit_tests.dir/__/src/metadatum.cpp.o CMakeFiles/unit_tests.dir/__/src/mrwimage.cpp.o CMakeFiles/unit_tests.dir/__/src/orfimage.cpp.o CMakeFiles/unit_tests.dir/__/src/pgfimage.cpp.o CMakeFiles/unit_tests.dir/__/src/preview.cpp.o CMakeFiles/unit_tests.dir/__/src/properties.cpp.o CMakeFiles/unit_tests.dir/__/src/psdimage.cpp.o CMakeFiles/unit_tests.dir/__/src/rafimage.cpp.o CMakeFiles/unit_tests.dir/__/src/rw2image.cpp.o CMakeFiles/unit_tests.dir/__/src/tags.cpp.o CMakeFiles/unit_tests.dir/__/src/tgaimage.cpp.o CMakeFiles/unit_tests.dir/__/src/tiffimage.cpp.o CMakeFiles/unit_tests.dir/__/src/types.cpp.o CMakeFiles/unit_tests.dir/__/src/value.cpp.o CMakeFiles/unit_tests.dir/__/src/version.cpp.o CMakeFiles/unit_tests.dir/__/src/webpimage.cpp.o CMakeFiles/unit_tests.dir/__/src/xmp.cpp.o CMakeFiles/unit_tests.dir/__/src/xmpsidecar.cpp.o CMakeFiles/unit_tests.dir/__/src/pngimage.cpp.o CMakeFiles/unit_tests.dir/__/src/asfvideo.cpp.o CMakeFiles/unit_tests.dir/__/src/matroskavideo.cpp.o CMakeFiles/unit_tests.dir/__/src/quicktimevideo.cpp.o CMakeFiles/unit_tests.dir/__/src/riffvideo.cpp.o CMakeFiles/unit_tests.dir/__/src/utilsvideo.cpp.o CMakeFiles/unit_tests.dir/__/src/canonmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/casiomn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/cr2header_int.cpp.o CMakeFiles/unit_tests.dir/__/src/crwimage_int.cpp.o CMakeFiles/unit_tests.dir/__/src/fujimn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/helper_functions.cpp.o CMakeFiles/unit_tests.dir/__/src/image_int.cpp.o CMakeFiles/unit_tests.dir/__/src/makernote_int.cpp.o CMakeFiles/unit_tests.dir/__/src/minoltamn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/nikonmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/olympusmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/orfimage_int.cpp.o CMakeFiles/unit_tests.dir/__/src/panasonicmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/pentaxmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/rw2image_int.cpp.o CMakeFiles/unit_tests.dir/__/src/samsungmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/sigmamn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/sonymn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/tags_int.cpp.o CMakeFiles/unit_tests.dir/__/src/tiffcomposite_int.cpp.o CMakeFiles/unit_tests.dir/__/src/tiffimage_int.cpp.o CMakeFiles/unit_tests.dir/__/src/tiffvisitor_int.cpp.o CMakeFiles/unit_tests.dir/__/src/pngchunk_int.cpp.o -o ../bin/unit_tests ../lib/libexiv2-xmp.a /usr/lib64/libcurl.so /usr/lib64/libz.so /usr/lib64/libgtest.so /usr/lib64/libgtest_main.so /usr/lib64/libz.so /usr/lib64/libexpat.so /usr/lib64/libgtest.so /usr/lib64/libgtest_main.so -lpthread -lc
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans16.ltrans.o:(.data.rel.ro+0x10): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans16.ltrans.o:(.data.rel.ro+0x28): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans19.ltrans.o:(.data.rel.ro+0x10): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans19.ltrans.o:(.data.rel.ro+0x28): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans19.ltrans.o:(.data.rel.ro+0x40): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans19.ltrans.o:(.data.rel.ro+0x58): more undefined references to `typeinfo for testing::Test' follow
collect2: error: ld returned 1 exit status
make[2]: *** [unitTests/CMakeFiles/unit_tests.dir/build.make:1282: bin/unit_tests] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/exiv2-0.27.2'
make[1]: *** [CMakeFiles/Makefile2:350: unitTests/CMakeFiles/unit_tests.dir/all] Error 2
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/exiv2-0.27.2'
make: *** [Makefile:133: all] Error 2
</pre> | 0.27.2: test suite build fails | https://api.github.com/repos/Exiv2/exiv2/issues/997/comments | 9 | 2019-09-07T11:17:34 | "2021-04-13T12:40:03Z" | https://github.com/Exiv2/exiv2/issues/997 | 490,624,075 | 997 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : 0.27.2: test suite build fails
Issue date:
--- start body ---
<pre>[ 48%] <font color="#4E9A06"><b>Linking CXX executable ../bin/unit_tests</b></font>
cd /home/tkloczko/rpmbuild/BUILD/exiv2-0.27.2/unitTests && /usr/bin/cmake -E cmake_link_script CMakeFiles/unit_tests.dir/link.txt --verbose=1
/usr/bin/g++ -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto -Wall -Wcast-align -Wpointer-arith -Wformat-security -Wmissing-format-attribute -Woverloaded-virtual -W -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto -fuse-linker-plugin -rdynamic CMakeFiles/unit_tests.dir/mainTestRunner.cpp.o CMakeFiles/unit_tests.dir/test_basicio.cpp.o CMakeFiles/unit_tests.dir/test_types.cpp.o CMakeFiles/unit_tests.dir/test_tiffheader.cpp.o CMakeFiles/unit_tests.dir/test_futils.cpp.o CMakeFiles/unit_tests.dir/test_enforce.cpp.o CMakeFiles/unit_tests.dir/test_safe_op.cpp.o CMakeFiles/unit_tests.dir/test_XmpKey.cpp.o CMakeFiles/unit_tests.dir/test_DateValue.cpp.o CMakeFiles/unit_tests.dir/test_TimeValue.cpp.o CMakeFiles/unit_tests.dir/test_cr2header_int.cpp.o CMakeFiles/unit_tests.dir/test_helper_functions.cpp.o CMakeFiles/unit_tests.dir/test_slice.cpp.o CMakeFiles/unit_tests.dir/test_image_int.cpp.o CMakeFiles/unit_tests.dir/__/src/basicio.cpp.o CMakeFiles/unit_tests.dir/__/src/bigtiffimage.cpp.o CMakeFiles/unit_tests.dir/__/src/bmpimage.cpp.o CMakeFiles/unit_tests.dir/__/src/convert.cpp.o CMakeFiles/unit_tests.dir/__/src/cr2image.cpp.o CMakeFiles/unit_tests.dir/__/src/crwimage.cpp.o CMakeFiles/unit_tests.dir/__/src/datasets.cpp.o CMakeFiles/unit_tests.dir/__/src/easyaccess.cpp.o CMakeFiles/unit_tests.dir/__/src/epsimage.cpp.o CMakeFiles/unit_tests.dir/__/src/error.cpp.o CMakeFiles/unit_tests.dir/__/src/exif.cpp.o CMakeFiles/unit_tests.dir/__/src/futils.cpp.o CMakeFiles/unit_tests.dir/__/src/gifimage.cpp.o CMakeFiles/unit_tests.dir/__/src/http.cpp.o CMakeFiles/unit_tests.dir/__/src/image.cpp.o CMakeFiles/unit_tests.dir/__/src/ini.cpp.o CMakeFiles/unit_tests.dir/__/src/iptc.cpp.o CMakeFiles/unit_tests.dir/__/src/jp2image.cpp.o CMakeFiles/unit_tests.dir/__/src/jpgimage.cpp.o CMakeFiles/unit_tests.dir/__/src/metadatum.cpp.o CMakeFiles/unit_tests.dir/__/src/mrwimage.cpp.o CMakeFiles/unit_tests.dir/__/src/orfimage.cpp.o CMakeFiles/unit_tests.dir/__/src/pgfimage.cpp.o CMakeFiles/unit_tests.dir/__/src/preview.cpp.o CMakeFiles/unit_tests.dir/__/src/properties.cpp.o CMakeFiles/unit_tests.dir/__/src/psdimage.cpp.o CMakeFiles/unit_tests.dir/__/src/rafimage.cpp.o CMakeFiles/unit_tests.dir/__/src/rw2image.cpp.o CMakeFiles/unit_tests.dir/__/src/tags.cpp.o CMakeFiles/unit_tests.dir/__/src/tgaimage.cpp.o CMakeFiles/unit_tests.dir/__/src/tiffimage.cpp.o CMakeFiles/unit_tests.dir/__/src/types.cpp.o CMakeFiles/unit_tests.dir/__/src/value.cpp.o CMakeFiles/unit_tests.dir/__/src/version.cpp.o CMakeFiles/unit_tests.dir/__/src/webpimage.cpp.o CMakeFiles/unit_tests.dir/__/src/xmp.cpp.o CMakeFiles/unit_tests.dir/__/src/xmpsidecar.cpp.o CMakeFiles/unit_tests.dir/__/src/pngimage.cpp.o CMakeFiles/unit_tests.dir/__/src/asfvideo.cpp.o CMakeFiles/unit_tests.dir/__/src/matroskavideo.cpp.o CMakeFiles/unit_tests.dir/__/src/quicktimevideo.cpp.o CMakeFiles/unit_tests.dir/__/src/riffvideo.cpp.o CMakeFiles/unit_tests.dir/__/src/utilsvideo.cpp.o CMakeFiles/unit_tests.dir/__/src/canonmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/casiomn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/cr2header_int.cpp.o CMakeFiles/unit_tests.dir/__/src/crwimage_int.cpp.o CMakeFiles/unit_tests.dir/__/src/fujimn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/helper_functions.cpp.o CMakeFiles/unit_tests.dir/__/src/image_int.cpp.o CMakeFiles/unit_tests.dir/__/src/makernote_int.cpp.o CMakeFiles/unit_tests.dir/__/src/minoltamn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/nikonmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/olympusmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/orfimage_int.cpp.o CMakeFiles/unit_tests.dir/__/src/panasonicmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/pentaxmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/rw2image_int.cpp.o CMakeFiles/unit_tests.dir/__/src/samsungmn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/sigmamn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/sonymn_int.cpp.o CMakeFiles/unit_tests.dir/__/src/tags_int.cpp.o CMakeFiles/unit_tests.dir/__/src/tiffcomposite_int.cpp.o CMakeFiles/unit_tests.dir/__/src/tiffimage_int.cpp.o CMakeFiles/unit_tests.dir/__/src/tiffvisitor_int.cpp.o CMakeFiles/unit_tests.dir/__/src/pngchunk_int.cpp.o -o ../bin/unit_tests ../lib/libexiv2-xmp.a /usr/lib64/libcurl.so /usr/lib64/libz.so /usr/lib64/libgtest.so /usr/lib64/libgtest_main.so /usr/lib64/libz.so /usr/lib64/libexpat.so /usr/lib64/libgtest.so /usr/lib64/libgtest_main.so -lpthread -lc
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans16.ltrans.o:(.data.rel.ro+0x10): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans16.ltrans.o:(.data.rel.ro+0x28): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans19.ltrans.o:(.data.rel.ro+0x10): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans19.ltrans.o:(.data.rel.ro+0x28): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans19.ltrans.o:(.data.rel.ro+0x40): undefined reference to `typeinfo for testing::Test'
/usr/bin/ld: /tmp/unit_tests.UeJpy3.ltrans19.ltrans.o:(.data.rel.ro+0x58): more undefined references to `typeinfo for testing::Test' follow
collect2: error: ld returned 1 exit status
make[2]: *** [unitTests/CMakeFiles/unit_tests.dir/build.make:1282: bin/unit_tests] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/exiv2-0.27.2'
make[1]: *** [CMakeFiles/Makefile2:350: unitTests/CMakeFiles/unit_tests.dir/all] Error 2
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/exiv2-0.27.2'
make: *** [Makefile:133: all] Error 2
</pre>
--- end body ---
comments :
--- start comments ---
--- end comments --- | 6,395 | 207,802 |
[
"Exiv2",
"exiv2"
] | Hi
I have a simple PNG file and I'd like to get the orientation metadata of it on an UNIX system.
With exiv2, doesn't work
```
$ exiv2 index.png
...
index.png: No Exif data found in the file
```
With identify, doesn't work
```
$ identify -verbose index.png | grep Orientation
Orientation: Undefined
```
With exiftool, works
```
$ exiftool index.png | grep Orientation
Orientation : Rotate 270 CW
```
Not sure if it is a bug, but isn't exiv2 supposed to give mo the metadata the same way as exiftool does?
If it's not a bug, why is it so?
**Bug description**
exiv2 doesn't show metadata
**To Reproduce**
Steps to reproduce the behaviour:
1. Build exiv2 from source as described [here](https://github.com/Exiv2/exiv2#21-build-install-use-exiv2-on-a-unix-like-system)
2. Test exiv2 and exiftool on an image with non-horizontal orientation
**Expected behavior**
exiv2 should show metadata, in my case I wanted orientation
**Desktop**
- OS: Linux
- Compiler & Version: gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.11)
- Compilation mode and/or compiler flags: as described in your README
**Additional context**
- I use exiftool 10.10
- The default for `EXIV2_ENABLE_PNG` is `On` | exiv2 doesn't show metadata | https://api.github.com/repos/Exiv2/exiv2/issues/996/comments | 3 | 2019-09-06T09:18:09 | "2019-09-06T11:03:23Z" | https://github.com/Exiv2/exiv2/issues/996 | 490,220,858 | 996 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : exiv2 doesn't show metadata
Issue date:
--- start body ---
Hi
I have a simple PNG file and I'd like to get the orientation metadata of it on an UNIX system.
With exiv2, doesn't work
```
$ exiv2 index.png
...
index.png: No Exif data found in the file
```
With identify, doesn't work
```
$ identify -verbose index.png | grep Orientation
Orientation: Undefined
```
With exiftool, works
```
$ exiftool index.png | grep Orientation
Orientation : Rotate 270 CW
```
Not sure if it is a bug, but isn't exiv2 supposed to give mo the metadata the same way as exiftool does?
If it's not a bug, why is it so?
**Bug description**
exiv2 doesn't show metadata
**To Reproduce**
Steps to reproduce the behaviour:
1. Build exiv2 from source as described [here](https://github.com/Exiv2/exiv2#21-build-install-use-exiv2-on-a-unix-like-system)
2. Test exiv2 and exiftool on an image with non-horizontal orientation
**Expected behavior**
exiv2 should show metadata, in my case I wanted orientation
**Desktop**
- OS: Linux
- Compiler & Version: gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.11)
- Compilation mode and/or compiler flags: as described in your README
**Additional context**
- I use exiftool 10.10
- The default for `EXIV2_ENABLE_PNG` is `On`
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,453 | 207,803 |
[
"Exiv2",
"exiv2"
] | Here are three sample files from a Pentax K-500:
IMGP9815.JPG: Sigma Zoom 28-88mm MACRO 1:3.5-5.6; exiv2 identifies it as "Tamron 35-90mm F4 AF"
IMGP9816.JPG: Tokina AF 100-300mm 1:5.6-6.7; exiv2 identifies it as "Cosina AF 100-300mm F5.6-6.7". This may be correct; the Tokina may be a re-branded Cosina, but I don't know how to check.
IMGP9816.JPG: smc Pentax-DA 50mm f1.8; exiv2 correctly identifies it
| Pentax lens samples | https://api.github.com/repos/Exiv2/exiv2/issues/995/comments | 2 | 2019-09-03T22:47:30 | "2019-09-06T09:29:33Z" | https://github.com/Exiv2/exiv2/issues/995 | 488,858,525 | 995 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Pentax lens samples
Issue date:
--- start body ---
Here are three sample files from a Pentax K-500:
IMGP9815.JPG: Sigma Zoom 28-88mm MACRO 1:3.5-5.6; exiv2 identifies it as "Tamron 35-90mm F4 AF"
IMGP9816.JPG: Tokina AF 100-300mm 1:5.6-6.7; exiv2 identifies it as "Cosina AF 100-300mm F5.6-6.7". This may be correct; the Tokina may be a re-branded Cosina, but I don't know how to check.
IMGP9816.JPG: smc Pentax-DA 50mm f1.8; exiv2 correctly identifies it
--- end body ---
comments :
--- start comments ---
--- end comments --- | 945 | 207,804 |
[
"Exiv2",
"exiv2"
] | In trying to port an existing and no longer actively maintained project, I have run into an issue where my fork, based on the existing code tries to read data for a tag "Exif.MinoltaCsNew.ISOSpeed".
Presumably, the code I am working with was initially meant for & compiled against an earlier version of Exiv2lib and now that it is linked with 0.2.72 it throws exceptions. Or perhaps the exceptions were simply ignored.
When Exiv2 0.2.72 throws the exception, the current code skips testing for any other tags for the given image file - not what I want or need.
Looking through the current Exiv2 code, I cannot find this string and hence I get the exception - no real problem in that ... except I would expect that possibly at some time in past versions it was valid and no longer is. (some perusal of the release notes shows that potentially this change might date back to changes from 0.20 to 0.21)
Naturally, I will have to update these no-longer supported tags, but I would like to try and make the current code give a better response for such cases where built-in assumptions about libraries not under my direct control are modified and result in unexpected results and behaviour.
Hence my question: is there a way to check whether any tags I might be wanting to read are actually 'valid' or will I have to rely on simply verifying that the exiv2lib to be linked in is of a specific version and/or handle all exceptions for each tag I want to read?
Any recommendations or pointer much appreciated :-)
| Is there a way to query whether a given tag is supported by Exiv2? | https://api.github.com/repos/Exiv2/exiv2/issues/987/comments | 6 | 2019-08-20T20:36:53 | "2019-12-11T08:13:11Z" | https://github.com/Exiv2/exiv2/issues/987 | 483,070,127 | 987 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Is there a way to query whether a given tag is supported by Exiv2?
Issue date:
--- start body ---
In trying to port an existing and no longer actively maintained project, I have run into an issue where my fork, based on the existing code tries to read data for a tag "Exif.MinoltaCsNew.ISOSpeed".
Presumably, the code I am working with was initially meant for & compiled against an earlier version of Exiv2lib and now that it is linked with 0.2.72 it throws exceptions. Or perhaps the exceptions were simply ignored.
When Exiv2 0.2.72 throws the exception, the current code skips testing for any other tags for the given image file - not what I want or need.
Looking through the current Exiv2 code, I cannot find this string and hence I get the exception - no real problem in that ... except I would expect that possibly at some time in past versions it was valid and no longer is. (some perusal of the release notes shows that potentially this change might date back to changes from 0.20 to 0.21)
Naturally, I will have to update these no-longer supported tags, but I would like to try and make the current code give a better response for such cases where built-in assumptions about libraries not under my direct control are modified and result in unexpected results and behaviour.
Hence my question: is there a way to check whether any tags I might be wanting to read are actually 'valid' or will I have to rely on simply verifying that the exiv2lib to be linked in is of a specific version and/or handle all exceptions for each tag I want to read?
Any recommendations or pointer much appreciated :-)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 1,743 | 207,805 |
[
"Exiv2",
"exiv2"
] | The Affinity Photo (AFPHOTO) format, while proprietary, contains an embedded preview that many applications are able to use when displaying a thumbnail for a file.
With Adobe's move to subscription, a lot of people have been jumping ship to applications like Affinity Photo which offer similar functionality for a reasonable price.
Sample file for testing is attached.
[RedTrillium_01.zip](https://github.com/Exiv2/exiv2/files/3512455/RedTrillium_01.zip)
| Enhancement: Add support for embedded thumbnails in AFPHOTO (Affinity Photo) files | https://api.github.com/repos/Exiv2/exiv2/issues/986/comments | 2 | 2019-08-17T21:32:59 | "2019-08-18T10:09:58Z" | https://github.com/Exiv2/exiv2/issues/986 | 481,928,232 | 986 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Enhancement: Add support for embedded thumbnails in AFPHOTO (Affinity Photo) files
Issue date:
--- start body ---
The Affinity Photo (AFPHOTO) format, while proprietary, contains an embedded preview that many applications are able to use when displaying a thumbnail for a file.
With Adobe's move to subscription, a lot of people have been jumping ship to applications like Affinity Photo which offer similar functionality for a reasonable price.
Sample file for testing is attached.
[RedTrillium_01.zip](https://github.com/Exiv2/exiv2/files/3512455/RedTrillium_01.zip)
--- end body ---
comments :
--- start comments ---
--- end comments --- | 709 | 207,806 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
`exiv2json` may crash due to NULL-pointer read.
**To Reproduce**
Steps to reproduce the behaviour:
1. run `exiv2json $f` where `exiv2json` is compiled with AddressSanitizer.
2. the program crashes with the backtrace like:
```
AddressSanitizer:DEADLYSIGNAL
=================================================================
==25518==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x00000042a51b bp 0x7fffffffaae0 sp 0x7fffffffaa80 T0)
==25518==The signal is caused by a READ memory access.
==25518==Hint: address points to the zero page.
#0 0x42a51a in __asan::asan_delete(void*, unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType) (/home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/bin/exiv2json+0x42a51a)
#1 0x517a72 in operator delete(void*) (/home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/bin/exiv2json+0x517a72)
#2 0x7ffff73b6232 in std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::~pair() /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_pair.h:193:56
#3 0x7ffff73b6208 in void __gnu_cxx::new_allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::destroy<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >(std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >*) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/ext/new_allocator.h:140:28
#4 0x7ffff73b61a7 in void std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > >::destroy<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >(std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >*) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/alloc_traits.h:487:8
#5 0x7ffff73b610b in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::_M_destroy_node(std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >*) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_tree.h:650:2
#6 0x7ffff73b60ae in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::_M_drop_node(std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >*) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_tree.h:658:2
#7 0x7ffff75d4377 in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::_M_erase_aux(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_tree.h:2477:7
#8 0x7ffff77eaafa in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::erase[abi:cxx11](std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_tree.h:1125:2
#9 0x7ffff77d0270 in std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::erase[abi:cxx11](std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_map.h:1031:21
#10 0x7ffff77c95bf in XMPMeta::DeleteNamespace(char const*) /home/hongxu/FOT/exiv2-all/exiv2-asan/xmpsdk/src/XMPMeta.cpp:1134:28
#11 0x7ffff7753c82 in WXMPMeta_DeleteNamespace_1 /home/hongxu/FOT/exiv2-all/exiv2-asan/xmpsdk/src/WXMPMeta.cpp:285:3
#12 0x7ffff75bac98 in TXMPMeta<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::DeleteNamespace(char const*) /home/hongxu/FOT/exiv2-all/exiv2-asan/xmpsdk/include/client-glue/TXMPMeta.incl_cpp:280:2
#13 0x7ffff75af496 in Exiv2::XmpParser::registerNs(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/hongxu/FOT/exiv2-all/exiv2-asan/src/xmp.cpp:559:13
#14 0x7ffff750ebb5 in Exiv2::XmpProperties::registeredNamespaces(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&) /home/hongxu/FOT/exiv2-all/exiv2-asan/src/properties.cpp:2663:14
#15 0x520c02 in main /home/hongxu/FOT/exiv2-all/exiv2-asan/samples/exiv2json.cpp:328:17
#16 0x7ffff5b71b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
#17 0x41e8b9 in _start (/home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/bin/exiv2json+0x41e8b9)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/bin/exiv2json+0x42a51a) in __asan::asan_delete(void*, unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType)
==25518==ABORTING
```
Other POCs and error messages are available [here](https://github.com/ntu-sec/pocs/tree/master/exiv2/1b2e2f40/crashes).
**Expected behavior**
Exit with non-zero.
**Desktop (please complete the following information):**
- OS: Ubuntu 18.04.2 LTS
- Compiler & Version: Clang-6
- Compilation mode and/or compiler flags: "-fsanitize=address"
**Additional context**
- POC files are corrupted "Progressive Graphics image data".
```
$ `ldd ./exiv2json`
linux-vdso.so.1 (0x00007ffff7ffa000)
libexiv2.so.27 => /home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/lib/libexiv2.so.27 (0x00007ffff70c8000)
libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007ffff6eab000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007ffff6b22000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007ffff6784000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007ffff6565000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007ffff635d000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007ffff6159000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007ffff5f41000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007ffff5b50000)
libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 (0x00007ffff591e000)
/lib64/ld-linux-x86-64.so.2 (0x00007ffff7dd5000)
``` | AddressSanitizer: NULL-pointer READ at XMPMeta.cpp:1134 | https://api.github.com/repos/Exiv2/exiv2/issues/984/comments | 7 | 2019-08-15T04:16:37 | "2020-03-29T15:14:19Z" | https://github.com/Exiv2/exiv2/issues/984 | 480,986,744 | 984 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : AddressSanitizer: NULL-pointer READ at XMPMeta.cpp:1134
Issue date:
--- start body ---
**Describe the bug**
`exiv2json` may crash due to NULL-pointer read.
**To Reproduce**
Steps to reproduce the behaviour:
1. run `exiv2json $f` where `exiv2json` is compiled with AddressSanitizer.
2. the program crashes with the backtrace like:
```
AddressSanitizer:DEADLYSIGNAL
=================================================================
==25518==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x00000042a51b bp 0x7fffffffaae0 sp 0x7fffffffaa80 T0)
==25518==The signal is caused by a READ memory access.
==25518==Hint: address points to the zero page.
#0 0x42a51a in __asan::asan_delete(void*, unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType) (/home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/bin/exiv2json+0x42a51a)
#1 0x517a72 in operator delete(void*) (/home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/bin/exiv2json+0x517a72)
#2 0x7ffff73b6232 in std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::~pair() /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_pair.h:193:56
#3 0x7ffff73b6208 in void __gnu_cxx::new_allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::destroy<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >(std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >*) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/ext/new_allocator.h:140:28
#4 0x7ffff73b61a7 in void std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > >::destroy<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >(std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >*) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/alloc_traits.h:487:8
#5 0x7ffff73b610b in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::_M_destroy_node(std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >*) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_tree.h:650:2
#6 0x7ffff73b60ae in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::_M_drop_node(std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >*) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_tree.h:658:2
#7 0x7ffff75d4377 in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::_M_erase_aux(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_tree.h:2477:7
#8 0x7ffff77eaafa in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::erase[abi:cxx11](std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_tree.h:1125:2
#9 0x7ffff77d0270 in std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::erase[abi:cxx11](std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_map.h:1031:21
#10 0x7ffff77c95bf in XMPMeta::DeleteNamespace(char const*) /home/hongxu/FOT/exiv2-all/exiv2-asan/xmpsdk/src/XMPMeta.cpp:1134:28
#11 0x7ffff7753c82 in WXMPMeta_DeleteNamespace_1 /home/hongxu/FOT/exiv2-all/exiv2-asan/xmpsdk/src/WXMPMeta.cpp:285:3
#12 0x7ffff75bac98 in TXMPMeta<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::DeleteNamespace(char const*) /home/hongxu/FOT/exiv2-all/exiv2-asan/xmpsdk/include/client-glue/TXMPMeta.incl_cpp:280:2
#13 0x7ffff75af496 in Exiv2::XmpParser::registerNs(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/hongxu/FOT/exiv2-all/exiv2-asan/src/xmp.cpp:559:13
#14 0x7ffff750ebb5 in Exiv2::XmpProperties::registeredNamespaces(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&) /home/hongxu/FOT/exiv2-all/exiv2-asan/src/properties.cpp:2663:14
#15 0x520c02 in main /home/hongxu/FOT/exiv2-all/exiv2-asan/samples/exiv2json.cpp:328:17
#16 0x7ffff5b71b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
#17 0x41e8b9 in _start (/home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/bin/exiv2json+0x41e8b9)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/bin/exiv2json+0x42a51a) in __asan::asan_delete(void*, unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType)
==25518==ABORTING
```
Other POCs and error messages are available [here](https://github.com/ntu-sec/pocs/tree/master/exiv2/1b2e2f40/crashes).
**Expected behavior**
Exit with non-zero.
**Desktop (please complete the following information):**
- OS: Ubuntu 18.04.2 LTS
- Compiler & Version: Clang-6
- Compilation mode and/or compiler flags: "-fsanitize=address"
**Additional context**
- POC files are corrupted "Progressive Graphics image data".
```
$ `ldd ./exiv2json`
linux-vdso.so.1 (0x00007ffff7ffa000)
libexiv2.so.27 => /home/hongxu/FOT/exiv2-all/exiv2-asan/BUILD/lib/libexiv2.so.27 (0x00007ffff70c8000)
libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007ffff6eab000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007ffff6b22000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007ffff6784000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007ffff6565000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007ffff635d000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007ffff6159000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007ffff5f41000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007ffff5b50000)
libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 (0x00007ffff591e000)
/lib64/ld-linux-x86-64.so.2 (0x00007ffff7dd5000)
```
--- end body ---
comments :
--- start comments ---
--- end comments --- | 11,724 | 207,807 |
[
"Exiv2",
"exiv2"
] | **Describe the bug**
`Exif.Canon.AFInfo` is misinterpreted as `unsigned short`. It should be `signed short` though. From my understanding this applies to both [AFInfo](https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html#AFInfo) and [AFInfo2](https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html#AFInfo2), because the AF coordinates originate from the image center (0,0), thus some of them will be negative.
**To Reproduce**
Steps to reproduce the behaviour:
1. Provide image with which you observed the issue:
2. Executing `exiv2 -PEkycv 62878860-3c552580-bd2a-11e9-94c0-cd4617d1af80.JPG` yields
```
Exif.Canon.AFInfo Short 273 546 2 63 61 6720 4480 6720 4480 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 0 0 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 0 0 65200 64790 64435 64099 63764 336 0 65200 64099 63764 1772 1437 1101 746 336 0 1437 1101 746 336 0 65200 64790 64435 336 0 65200 64790 64435 64099 63764 1772 64790 64435 64099 63764 1772 1437 1101 746 63764 1772 1437 1101 746 336 0 65200 1101 746 336 0 65200 64790 64435 64099 336 0 65200 1772 1437 0 0 547 625 625 625 625 821 821 821 308 308 625 625 625 625 547 547 308 308 308 274 274 274 308 308 0 0 0 0 0 0 0 308 65228 65228 65228 65228 0 0 0 0 64911 65228 65228 65228 65228 65262 65262 65262 64911 64911 64989 64989 64989 64911 64911 64911 64715 64715 64715 64911 64911 0 0 0 512 0 0 0 512 0 0 0 0 0 0 65535
```
with insanely high numbers > 60000 . They should be negative.
**Expected behavior**
Exiftool reports it correctly:
`exiftool -a -u -g1 62878860-3c552580-bd2a-11e9-94c0-cd4617d1af80.JPG`
```
AF Info Size : 546
AF Area Mode : Single-point AF
Num AF Points : 63
Valid AF Points : 61
Canon Image Width : 6720
Canon Image Height : 4480
AF Image Width : 6720
AF Image Height : 4480
AF Area Widths : 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 0 0
AF Area Heights : 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 0 0
AF Area X Positions : -336 -746 -1101 -1437 -1772 336 0 -336 -1437 -1772 1772 1437 1101 746 336 0 1437 1101 746 336 0 -336 -746 -1101 336 0 -336 -746 -1101 -1437 -1772 1772 -746 -1101 -1437 -1772 1772 1437 1101 746 -1772 1772 1437 1101 746 336 0 -336 1101 746 336 0 -336 -746 -1101 -1437 336 0 -336 1772 1437 0 0
AF Area Y Positions : 547 625 625 625 625 821 821 821 308 308 625 625 625 625 547 547 308 308 308 274 274 274 308 308 0 0 0 0 0 0 0 308 -308 -308 -308 -308 0 0 0 0 -625 -308 -308 -308 -308 -274 -274 -274 -625 -625 -547 -547 -547 -625 -625 -625 -821 -821 -821 -625 -625 0 0
```
**Desktop:**
- `Linux 4.12.14-lp151.28.10-default x86_64`
**Additional context**
BTW: Exiftool also reports which focus point(s) was/were used:
```
AF Points In Focus : 25
AF Points Selected : 25
```
I cannot find this information in exiv2. Am I missing smth.?
| Canon AFInfo seems misinterpreted | https://api.github.com/repos/Exiv2/exiv2/issues/981/comments | 26 | 2019-08-12T16:19:40 | "2019-09-15T07:45:55Z" | https://github.com/Exiv2/exiv2/issues/981 | 479,734,683 | 981 | This is a GitHub Issue
repo:exiv2
owner:Exiv2
Title : Canon AFInfo seems misinterpreted
Issue date:
--- start body ---
**Describe the bug**
`Exif.Canon.AFInfo` is misinterpreted as `unsigned short`. It should be `signed short` though. From my understanding this applies to both [AFInfo](https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html#AFInfo) and [AFInfo2](https://sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html#AFInfo2), because the AF coordinates originate from the image center (0,0), thus some of them will be negative.
**To Reproduce**
Steps to reproduce the behaviour:
1. Provide image with which you observed the issue:
2. Executing `exiv2 -PEkycv 62878860-3c552580-bd2a-11e9-94c0-cd4617d1af80.JPG` yields
```
Exif.Canon.AFInfo Short 273 546 2 63 61 6720 4480 6720 4480 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 0 0 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 0 0 65200 64790 64435 64099 63764 336 0 65200 64099 63764 1772 1437 1101 746 336 0 1437 1101 746 336 0 65200 64790 64435 336 0 65200 64790 64435 64099 63764 1772 64790 64435 64099 63764 1772 1437 1101 746 63764 1772 1437 1101 746 336 0 65200 1101 746 336 0 65200 64790 64435 64099 336 0 65200 1772 1437 0 0 547 625 625 625 625 821 821 821 308 308 625 625 625 625 547 547 308 308 308 274 274 274 308 308 0 0 0 0 0 0 0 308 65228 65228 65228 65228 0 0 0 0 64911 65228 65228 65228 65228 65262 65262 65262 64911 64911 64989 64989 64989 64911 64911 64911 64715 64715 64715 64911 64911 0 0 0 512 0 0 0 512 0 0 0 0 0 0 65535
```
with insanely high numbers > 60000 . They should be negative.
**Expected behavior**
Exiftool reports it correctly:
`exiftool -a -u -g1 62878860-3c552580-bd2a-11e9-94c0-cd4617d1af80.JPG`
```
AF Info Size : 546
AF Area Mode : Single-point AF
Num AF Points : 63
Valid AF Points : 61
Canon Image Width : 6720
Canon Image Height : 4480
AF Image Width : 6720
AF Image Height : 4480
AF Area Widths : 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 0 0
AF Area Heights : 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 218 0 0
AF Area X Positions : -336 -746 -1101 -1437 -1772 336 0 -336 -1437 -1772 1772 1437 1101 746 336 0 1437 1101 746 336 0 -336 -746 -1101 336 0 -336 -746 -1101 -1437 -1772 1772 -746 -1101 -1437 -1772 1772 1437 1101 746 -1772 1772 1437 1101 746 336 0 -336 1101 746 336 0 -336 -746 -1101 -1437 336 0 -336 1772 1437 0 0
AF Area Y Positions : 547 625 625 625 625 821 821 821 308 308 625 625 625 625 547 547 308 308 308 274 274 274 308 308 0 0 0 0 0 0 0 308 -308 -308 -308 -308 0 0 0 0 -625 -308 -308 -308 -308 -274 -274 -274 -625 -625 -547 -547 -547 -625 -625 -625 -821 -821 -821 -625 -625 0 0
```
**Desktop:**
- `Linux 4.12.14-lp151.28.10-default x86_64`
**Additional context**
BTW: Exiftool also reports which focus point(s) was/were used:
```
AF Points In Focus : 25
AF Points Selected : 25
```
I cannot find this information in exiv2. Am I missing smth.?
--- end body ---
comments :
--- start comments ---
--- end comments --- | 4,137 | 207,808 |