input stringlengths 1 18.7k | output stringlengths 1 18.7k |
|---|---|
I’m not sure if the UI is parsing the value incorrectly or if Admin isn’t able to interpret the passed value correctly.
| :disappointed: I'm actually not able to reproduce the error now - it could be that the 500 was related to some other internal blip (although I did check that I was able to launch other workflows at that time). I'm now able to get it running using the more intuitive syntax `[["str1", "str2"], ["str3", "str4"]]`
|
:disappointed: I'm actually not able to reproduce the error now - it could be that the 500 was related to some other internal blip (although I did check that I was able to launch other workflows at that time). I'm now able to get it running using the more intuitive syntax `[["str1", "str2"], ["str3", "str4"]]`
| Okay, that’s actually better! That’s how I would like the syntax to work in the UI :sweat_smile:
But it would be nice to know what the 500 was all about if we can find a way to reproduce it.
|
Ketan Umare: (1) would be override the default cpu/mem workflow wide right? task overrides in the code would still apply?
| no 1. is per task override for a workflow
|
no 1. is per task override for a workflow
| oh interesting!
|
Has anyone encountered the following?
```AttributeError: Assignment not allowed to repeated field "command" in protocol message object.```
While running:
```pyflyte -c ... serialize \
--in-container-config-path ... \
--local-source-root ... \
--image ... \
--in-container-virtualenv-root ... | Ya you can paste it in flytekit or general
|
Ya you can paste it in flytekit or general
| thanks
|
Hey Can someone from the team heck the article above
| Thank you for sending us your work, Sanjiv Anand. I’m sorry to say that we won’t be able to publish it, but we’d like to help you improve it so that you can try again in the future!
It seems like your piece might be too friendly — the language is very casual and doesn’t have a professional tone. It also feels like it’... |
Thank you for sending us your work, Sanjiv Anand. I’m sorry to say that we won’t be able to publish it, but we’d like to help you improve it so that you can try again in the future!
It seems like your piece might be too friendly — the language is very casual and doesn’t have a professional tone. It also feels like it’... | OK sure
|
Hello guys, I was going through the <https://github.com/flyteorg/flytekit/pull/1032#issuecomment-1145256332|related PR> that was attached with the TypeTransformer plugin for `tf.tensor` issue. I'd a doubt, what does it mean when it was said that _"The plugin could specify an unpinned `torch` as a dependency"._ I have t... | Hi, cryptic! To use the Flyte PyTorch type, PyTorch needs to be installed beforehand. If not, the plugin wouldn’t work. That discussion was about having a standalone plugins vs. having it in the core library. Since it’s now a part of the core library, you needn’t worry about it.
|
Hi, cryptic! To use the Flyte PyTorch type, PyTorch needs to be installed beforehand. If not, the plugin wouldn’t work. That discussion was about having a standalone plugins vs. having it in the core library. Since it’s now a part of the core library, you needn’t worry about it.
| Thanks for clarifying. I guess `tensorflow` too is a part of the core library now? I've not checked it manually
|
Thanks for clarifying. I guess `tensorflow` too is a part of the core library now? I've not checked it manually
| No, it isn’t. I’ve created some issues to add support for TensorFlow: <https://github.com/flyteorg/flyte/issues/2917> (see the flytekit section).
|
No, it isn’t. I’ve created some issues to add support for TensorFlow: <https://github.com/flyteorg/flyte/issues/2917> (see the flytekit section).
| Yeah, my bad. So as a general rule, if someone wants to write a plugin, would it be good to include the required libraries first in the core library?
|
Yeah, my bad. So as a general rule, if someone wants to write a plugin, would it be good to include the required libraries first in the core library?
| This plugin is in the core library, but not all of them are. Also, we haven’t included the dependencies in the core library. If you install the dependency, this plugin gets activated. In the PyTorch type case, it’s the `torch` library.
|
I’m trying to add a tutorial <https://github.com/flyteorg/flyte/issues/2676|https://github.com/flyteorg/flyte/issues/2676> to the Flyte docs but where does this need to go ? I don’t see any tutorials rst files here <https://github.com/flyteorg/flyte/tree/master/rsts|https://github.com/flyteorg/flyte/tree/master/rsts>
| Ryan Nazareth, it needs to go here: <https://github.com/flyteorg/flytesnacks/tree/master/cookbook/case_studies>.
|
_I've filled the swag form of UnionML of Hacktoberfest, will I receive any confirmation mail?_
The form which I filled: <https://tally.so/r/nWO7qQ>
| Hey, thanks! I’m not sure if I’ve the bandwidth to send emails, but we’ll try!
|
Hey, thanks! I’m not sure if I’ve the bandwidth to send emails, but we’ll try!
| Okay!
So will I directly receive my swags at doorstep?
Samhita Alla
|
Okay!
So will I directly receive my swags at doorstep?
Samhita Alla
| Yes!
|
Yes!
| Okay!
|
Hi, I am a newbie to this Flyte Project, I can contribute for Flyte in documentation.
| Thank you! You can find all the hacktoberfest-labeled issues <https://github.com/flyteorg/flyte/issues/2917|here>.
|
Hello Flyte team, Ive updated and added a few PRs
<https://github.com/flyteorg/flytekit/pull/1240>
<https://github.com/flyteorg/flytekit/pull/1230>
and had an initial go at adding an NLP tutorial but not sure why some of the tests are failing <https://github.com/flyteorg/flytesnacks/pull/911/files>
also silly question... | Thank you, Ryan Nazareth! Will review the PRs shortly.
You need to manually update the requirements the first time. We do have a bot that creates PRs to update the requirements.txt file in case a new library version is released.
|
Thank you, Ryan Nazareth! Will review the PRs shortly.
You need to manually update the requirements the first time. We do have a bot that creates PRs to update the requirements.txt file in case a new library version is released.
| It would be great to get <https://github.com/flyteorg/flytekit/pull/1240|1240> expedited as there are a number of other Tensorflow and Keras related issues for Hacktoberfest and this PR will make some of the others a bit easier by providing a working example.
|
It would be great to get <https://github.com/flyteorg/flytekit/pull/1240|1240> expedited as there are a number of other Tensorflow and Keras related issues for Hacktoberfest and this PR will make some of the others a bit easier by providing a working example.
| ah, Ive just noticed a number of other tensorflow active PRs - ive tried to mimic the changes to the requirements to avoid conflicts with those PRs - also there is this thread regarding some issues re: `profobuf` conflict when compiling the `<http://dev-requirements.in|dev-requirements.in>` as discussed in this thread... |
Wanted to know that this issue <https://github.com/flyteorg/flyte/issues/2908> is for this repo <https://github.com/flyteorg/flyteconsole> right?
| right
|
Also Niels Bantilan, regarding <https://github.com/flyteorg/flytekit/pull/1240>, are there any use cases you could think of?
| not sure I understand the question… I assumed `.tfrecord` is a TF-specific file format that we wanted to support out-of-the-box?
|
not sure I understand the question… I assumed `.tfrecord` is a TF-specific file format that we wanted to support out-of-the-box?
| This PR adds a `tf.Train.Example` type and it internally stores the data in a tfrecord file for serialization. I’ve been wondering why someone might use `tf.Train.Example` as a data type.
|
This PR adds a `tf.Train.Example` type and it internally stores the data in a tfrecord file for serialization. I’ve been wondering why someone might use `tf.Train.Example` as a data type.
| Samhita Alla This is the pattern tf docs <https://www.tensorflow.org/tutorials/load_data/tfrecord> suggest for serialising to `.tfrecord` unless i misunderstood the requirements of the original issue. The main use case(s) seems to be for image data and training on TPUs (see next comment in thread).
The alternative i gu... |
Samhita Alla This is the pattern tf docs <https://www.tensorflow.org/tutorials/load_data/tfrecord> suggest for serialising to `.tfrecord` unless i misunderstood the requirements of the original issue. The main use case(s) seems to be for image data and training on TPUs (see next comment in thread).
The alternative i gu... | Ryan Nazareth, makes sense. I have a couple of suggestions:
• There’s no `tf.data` <-> tfrecord conversion available. We may need to add support for `tf.data.Dataset` as well.
• IMO, this Flyte type should only perform conversion from `tf.Train.Example`/`tf.data` to tfrecord file (like <https://github.com/flyteo... |
Ryan Nazareth, makes sense. I have a couple of suggestions:
• There’s no `tf.data` <-> tfrecord conversion available. We may need to add support for `tf.data.Dataset` as well.
• IMO, this Flyte type should only perform conversion from `tf.Train.Example`/`tf.data` to tfrecord file (like <https://github.com/flyteo... | Samhita Alla sure i can make the change and add support for `tf.data`.
Also, regarding your second point, Im assuming in that case i should create a new flytefile type `TfRecordFile=FlyteFile[typing.TypeVar('tfrecord')]` which would then be returned as `TfRecordFile(path=lv.scalar.blob.uri)`in `def to_python_value(s... |
Samhita Alla sure i can make the change and add support for `tf.data`.
Also, regarding your second point, Im assuming in that case i should create a new flytefile type `TfRecordFile=FlyteFile[typing.TypeVar('tfrecord')]` which would then be returned as `TfRecordFile(path=lv.scalar.blob.uri)`in `def to_python_value(s... | So after discussing with Eduardo Apolinario and thinking about this a little more, I think we still need to discuss the core question of:
how do people actually use `tf.train.Example`, `TFRecord`s and `tf.data.Dataset` in real life, and how do we create reasonable i/o and serialization/deserialization boundaries betwe... |
So after discussing with Eduardo Apolinario and thinking about this a little more, I think we still need to discuss the core question of:
how do people actually use `tf.train.Example`, `TFRecord`s and `tf.data.Dataset` in real life, and how do we create reasonable i/o and serialization/deserialization boundaries betwe... | Thanks, Niels Bantilan! Added a suggestion.
|
Thanks, Niels Bantilan! Added a suggestion.
| Related to this discussion, I've been thinking about how to add support for `tf.data.Dataset` to Flyte (and whether it's even a good idea) and created this feature request issue: <https://github.com/flyteorg/flyte/issues/3038>
|
I am trying to run the script in my flytesnacks PR <https://github.com/flyteorg/flytesnacks/pull/911> on a flyte demo cluster to check out the flytedeck plot but i am getting an error - seems like the kubernetes pods are not responding ? (see screenshot below)
ive created the demo cluster as per the instructions in the... | :slightly_smiling_face:
thank you for posting back
|
:slightly_smiling_face:
thank you for posting back
| Actually, there is another issue now
I am trying to start a new cluster pulling this image that i pushed to docker hub registry <https://hub.docker.com/r/ryankarlos/flyte-nlp>
so based on commands in docs <https://docs.flyte.org/projects/flytectl/en/latest/gen/flytectl_demo_start.html> ive run the command below :
```f... |
Actually, there is another issue now
I am trying to start a new cluster pulling this image that i pushed to docker hub registry <https://hub.docker.com/r/ryankarlos/flyte-nlp>
so based on commands in docs <https://docs.flyte.org/projects/flytectl/en/latest/gen/flytectl_demo_start.html> ive run the command below :
```f... | Ryan Nazareth, your image should be given to the `pyflyte run` command. I presume your image uses the Dockerfile that’s present in the PR.
```flytectl demo start
pyflyte run --remote --image <your-image> <workflow.py> <workflow_name>```
|
Hey team!!
I wanted my blog to be reviewed.
Here is the link: <https://dev.to/srini047/what-is-data-orchestration-4kfb-temp-slug-7953970?preview=44f2a4a274977f9272ea655b1c6839766e9d423bd8ae68c54d7223fba32443a0094b8e7455b66550cb1c5ad94e5d3eab3465b770d3b6de80b2574723|https://dev.to/srini047/what-is-data-orchestration-4k... | Hi, Sriniketh J! Thanks for writing the blog post. I’m sorry to say that we won’t be considering it. cause it isn’t about Flyte but instead is about all the tools that make data orchestration possible. We only accept deep dives into Flyte, data and ML orchestration.
|
Hi, Sriniketh J! Thanks for writing the blog post. I’m sorry to say that we won’t be considering it. cause it isn’t about Flyte but instead is about all the tools that make data orchestration possible. We only accept deep dives into Flyte, data and ML orchestration.
| What if I modify it specific to Flyte with its use cases? Will that be acceptable?
|
What if I modify it specific to Flyte with its use cases? Will that be acceptable?
| Yeah, depending on the quality of the post.
|
Yeah, depending on the quality of the post.
| Okay :+1:
|
Eduardo Apolinario Kevin Su, can <https://github.com/flyteorg/flytekit/pull/1236> be merged? Also Eduardo, do you think `typing.TypeVar` needs to be replaced with `typing.Annotated` in FlyteFile even if it isn’t throwing any mypy errors?
| I don't believe we should go ahead with this change.
Simply replacing mentions to typevar with raw strings is going to start showing up as errors in mypy.
|
I don't believe we should go ahead with this change.
Simply replacing mentions to typevar with raw strings is going to start showing up as errors in mypy.
| Eduardo Apolinario <https://github.com/flyteorg/flytekit/pull/1236#pullrequestreview-1157386700>
|
Eduardo Apolinario <https://github.com/flyteorg/flytekit/pull/1236#pullrequestreview-1157386700>
| left a comment in the PR
|
left a comment in the PR
| Kevin Su <https://github.com/flyteorg/flytekit/pull/1236#issuecomment-1293017084>
|
One of the tests on GA is failing due to pytest not being recognized as a command on Windows build (Python 3.7 -spark2)
(<https://github.com/flyteorg/flytekit/actions/runs/3326738618/jobs/5511139310#step:6:12>)
| If you scroll up, the previous action (install dependencies) is failing to install `ipython==8.5.0`
it looks like ipython 8+ dropped support for python 3.7
Can you use python 3.7 to regenerate the requirements (instead of python 3.8: <https://github.com/flyteorg/flytekit/pull/1243/files#diff-43470c4f399e798afc682f0bf6c... |
If you scroll up, the previous action (install dependencies) is failing to install `ipython==8.5.0`
it looks like ipython 8+ dropped support for python 3.7
Can you use python 3.7 to regenerate the requirements (instead of python 3.8: <https://github.com/flyteorg/flytekit/pull/1243/files#diff-43470c4f399e798afc682f0bf6c... | Eduardo Apolinario Okay but I've rest of the tests failing due to the previous discussion we'd in here (<https://flyte-org.slack.com/archives/CREL4QVAQ/p1666541751922589>) Why exactly is it happening for me?
Is it because my serialized file is not present in the local path?
|
Eduardo Apolinario Okay but I've rest of the tests failing due to the previous discussion we'd in here (<https://flyte-org.slack.com/archives/CREL4QVAQ/p1666541751922589>) Why exactly is it happening for me?
Is it because my serialized file is not present in the local path?
| The comment I <https://github.com/flyteorg/flytekit/pull/1243/files#r1005951705|left> still applies. The call to `put_data` should take a path to the file you wrote, but right now it's pointing to the newly created directory.
|
The comment I <https://github.com/flyteorg/flytekit/pull/1243/files#r1005951705|left> still applies. The call to `put_data` should take a path to the file you wrote, but right now it's pointing to the newly created directory.
| Okay, but I've made the changes left in the comment in my local repo, but still I get the same error with my tests
|
Okay, but I've made the changes left in the comment in my local repo, but still I get the same error with my tests
| what error are you seeing after that change? Also, can you push the change to the PR?
|
what error are you seeing after that change? Also, can you push the change to the PR?
| Sure I'll be doing it now, just in few minutes
I don't think, I've to re-run the setup as we did pip in "-e" mode
Also I didn't quite understand the linting error : <https://github.com/flyteorg/flytekit/actions/runs/3326738618/jobs/5511140308#step:6:359>
Is the error code 1 at line 43 of Makefile related to file permis... |
Sure I'll be doing it now, just in few minutes
I don't think, I've to re-run the setup as we did pip in "-e" mode
Also I didn't quite understand the linting error : <https://github.com/flyteorg/flytekit/actions/runs/3326738618/jobs/5511140308#step:6:359>
Is the error code 1 at line 43 of Makefile related to file permis... | you can repro this locally by running `make lint`
(or by running `pre-commit run --all-files`)
|
you can repro this locally by running `make lint`
(or by running `pre-commit run --all-files`)
| `tf.io.write_file` doesn't support paths, so I did a `os.chdir(str(local_path))` , but that didn't work out Eduardo Apolinario
|
`tf.io.write_file` doesn't support paths, so I did a `os.chdir(str(local_path))` , but that didn't work out Eduardo Apolinario
| how are you invoking `tf.io.write_file` with a path? What error do you see if you pass a path?
|
how are you invoking `tf.io.write_file` with a path? What error do you see if you pass a path?
| I mean it only accepts a filename, so my idea is to change to the directory (local_path) and then do tf.io.write_file to save the file
|
I mean it only accepts a filename, so my idea is to change to the directory (local_path) and then do tf.io.write_file to save the file
| oh, I see. What I was suggesting was to change that code to:
```- filename = "tensor_data"
+ filename = os.path.join(local_path, "tensor_data")
tf.io.write_file(filename, tf.io.serialize_tensor(python_val))
remote_path = ctx.file_access.get_random_remote_path(local_path)
- ctx.fi... |
oh, I see. What I was suggesting was to change that code to:
```- filename = "tensor_data"
+ filename = os.path.join(local_path, "tensor_data")
tf.io.write_file(filename, tf.io.serialize_tensor(python_val))
remote_path = ctx.file_access.get_random_remote_path(local_path)
- ctx.fi... | Let me quickly test that
It's throwing a file not found error
|
Let me quickly test that
It's throwing a file not found error
| which file?
|
which file?
| the line in tests `lv = <http://tf.to|tf.to>_literal(ctx, _python_val_, type(_python_val_), lt)` raises the error
```tests/flytekit/unit/extras/tensorflow/test_transformations.py:56:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
flytekit/extras/tensorflow/tensor/tensor_... |
the line in tests `lv = <http://tf.to|tf.to>_literal(ctx, _python_val_, type(_python_val_), lt)` raises the error
```tests/flytekit/unit/extras/tensorflow/test_transformations.py:56:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
flytekit/extras/tensorflow/tensor/tensor_... | did you apply the two changes I mentioned in <https://flyte-org.slack.com/archives/C043P7NDKL6/p1666850864912679?thread_ts=1666848642.919639&cid=C043P7NDKL6> ?
the `- / +` at the beginning of each row are from git diff
|
did you apply the two changes I mentioned in <https://flyte-org.slack.com/archives/C043P7NDKL6/p1666850864912679?thread_ts=1666848642.919639&cid=C043P7NDKL6> ?
the `- / +` at the beginning of each row are from git diff
| yes I did make the changes
I don't understand why the file is not being created
and coming to the make lint failure, these are the errors on my local repo
```# Exclude setup.py to fix error: Duplicate module named "setup"
mypy plugins --exclude setup.py || true
flytekit-kf-mpi is not a valid Python package name
pre-com... |
yes I did make the changes
I don't understand why the file is not being created
and coming to the make lint failure, these are the errors on my local repo
```# Exclude setup.py to fix error: Duplicate module named "setup"
mypy plugins --exclude setup.py || true
flytekit-kf-mpi is not a valid Python package name
pre-com... | Can you say more? Why would you want to load from existing path? What if your task returns multiple objects of the tf type?
|
Can you say more? Why would you want to load from existing path? What if your task returns multiple objects of the tf type?
| Eduardo Apolinario I did something like this in `to_literal` of my tensor.py
```global local_file_path
local_file_path = os.path.join(local_path, "tensor_data")
tf.io.write_file(local_file_path, tf.io.serialize_tensor(python_val))
remote_path = ctx.file_access.get_random_remote_path(local_file_... |
Eduardo Apolinario I did something like this in `to_literal` of my tensor.py
```global local_file_path
local_file_path = os.path.join(local_path, "tensor_data")
tf.io.write_file(local_file_path, tf.io.serialize_tensor(python_val))
remote_path = ctx.file_access.get_random_remote_path(local_file_... | I see, but why do you need this?
|
I see, but why do you need this?
| I was getting an error as local_file_path was getting set to some new random path in to_python function, so I made it global in the previous function to keep it Eduardo Apolinario
|
I was getting an error as local_file_path was getting set to some new random path in to_python function, so I made it global in the previous function to keep it Eduardo Apolinario
| cryptic, you have to keep in mind that usually those pairs of functions `to_literal / to_python_value` are run in separate containers, so it doesn't make sense to use global variables to store state.
What error are you seeing in your test?
Also, keep in mind that we have several examples of type transformers that do so... |
cryptic, you have to keep in mind that usually those pairs of functions `to_literal / to_python_value` are run in separate containers, so it doesn't make sense to use global variables to store state.
What error are you seeing in your test?
Also, keep in mind that we have several examples of type transformers that do so... | Eduardo Apolinario Wouldn't a call to random_local_path again in `to_python_value` pick a new random path? The error that I see is it is trying to load from a new random path in `to_python_value` function and not from the one that was created by `to_literal`
as an example I created my serialized object in suppose say `... |
@FlyteCoreTeam
Having another issue when running one of the tasks for the nlp PR. <https://github.com/flyteorg/flytesnacks/pull/911> on demo cluster with custom built image
I am getting this error for some of the downstream tasks which take the serialised flytefile (`.model`) as input:
`Pod failed. No message receiv... | Error 137 usually means OOM. Can you bump the resources in that task?
|
Error 137 usually means OOM. Can you bump the resources in that task?
| Eduardo Apolinario thanks a lot, that fixed it ! i bumped the resource mem from 200 to 600Mi :+1:
|
Eduardo Apolinario thanks a lot, that fixed it ! i bumped the resource mem from 200 to 600Mi :+1:
| I wonder if we can collect these kinds of errors, would be great if we can figure out how to make these k8s-level errors a little more actionable, like suggesting to bump resources of the task.
|
Eduardo Apolinario Would it be a proper way to serialize tensors using pickle?
| I don’t think so. Is there no serialization technique proposed by TensorFlow?
|
I don’t think so. Is there no serialization technique proposed by TensorFlow?
| Yes there is but there is an issue here
`to_python_value()` present in the TypeTransformer generally has only three arguments, but when using `tf.io.parse_tensor` I've to additionally pass `python_val` but most of the invocations in various files present in flytekit pass only three arguments, so this is giving me a Typ... |
Yes there is but there is an issue here
`to_python_value()` present in the TypeTransformer generally has only three arguments, but when using `tf.io.parse_tensor` I've to additionally pass `python_val` but most of the invocations in various files present in flytekit pass only three arguments, so this is giving me a Typ... | Can you share with me your PR?
|
Can you share with me your PR?
| This is slightly older (<https://github.com/flyteorg/flytekit/blob/be865e5a97dc8f8095bd78ca3a73acb3ec5121b0/flytekit/extras/tensorflow/tensor/tensor_transformer.py|https://github.com/flyteorg/flytekit/blob/be865e5a97dc8f8095bd78ca3a73acb3ec5121b0/flytekit/extras/tensorflow/tensor/tensor_transformer.py>)
I've have made ... |
This is slightly older (<https://github.com/flyteorg/flytekit/blob/be865e5a97dc8f8095bd78ca3a73acb3ec5121b0/flytekit/extras/tensorflow/tensor/tensor_transformer.py|https://github.com/flyteorg/flytekit/blob/be865e5a97dc8f8095bd78ca3a73acb3ec5121b0/flytekit/extras/tensorflow/tensor/tensor_transformer.py>)
I've have made ... | Let me see.
I’ve a few suggestions; let me get back to you in an hour.
|
Let me see.
I’ve a few suggestions; let me get back to you in an hour.
| the out_type is a mandatory argument for `tf.io.parse_tensor`
Samhita Alla There seems to be no other way of doing this
|
the out_type is a mandatory argument for `tf.io.parse_tensor`
Samhita Alla There seems to be no other way of doing this
| 1. `filename` should be `local_path` in `to_literal`
2. `tf.io.read_file("tensor_data", name = None)` should be `tf.io.read_file(local_path)`
3. `pathlib.Path(local_path).parent.mkdir(parents=True, exist_ok=True)` isn’t required because `tf.io.write_file` will always creae a directory recursively.
4. tf.io.parse_tensor... |
Samhita Alla I have one last question, how do I fix lint errors on `make lint` ? I'm sorry but I'm not quite sure about it (<https://github.com/flyteorg/flytekit/actions/runs/3326738618/jobs/5511140308#step:6:360>)
| Can you `pre-commit install` in your flytekit repo locally? That should automatically warn you about lint errors during the commit.
|
Can you `pre-commit install` in your flytekit repo locally? That should automatically warn you about lint errors during the commit.
| It's little weird as I get the shellcheck result as failed on my local repo, but they completed successfully on GA
|
It's little weird as I get the shellcheck result as failed on my local repo, but they completed successfully on GA
| Oh. So are you still seeing the error?
|
Oh. So are you still seeing the error?
| ``` def test_to_python_value_and_literal(transformer, python_type, format, python_val):
ctx = context_manager.FlyteContext.current_context()
tf = transformer
lt = tf.get_literal_type(python_type)
lv = tf.to_literal(ctx, python_val, type(python_val), lt) # type: ignore
> ass... |
``` def test_to_python_value_and_literal(transformer, python_type, format, python_val):
ctx = context_manager.FlyteContext.current_context()
tf = transformer
lt = tf.get_literal_type(python_type)
lv = tf.to_literal(ctx, python_val, type(python_val), lt) # type: ignore
> ass... | Can you share with me your pytest args?
Not this, the function. The whole function.
|
Can you share with me your pytest args?
Not this, the function. The whole function.
| you mean the `test_to_python_value_and_literal`?
|
you mean the `test_to_python_value_and_literal`?
| Yes.
|
Yes.
| ```a = tf.constant([[1.0, 2.0, 3.0], [4.0, 5.0, 6.0]])
b = tf.constant([[1.0, 2.0], [3.0, 4.0], [5.0, 6.0]])
result_tensor = tf.matmul(a, b)
@pytest.mark.parametrize(
"transformer,python_type,format,python_val",
[
(
TensorFlowTensorTransformer(),
tf.Tensor,
TensorFl... |
```a = tf.constant([[1.0, 2.0, 3.0], [4.0, 5.0, 6.0]])
b = tf.constant([[1.0, 2.0], [3.0, 4.0], [5.0, 6.0]])
result_tensor = tf.matmul(a, b)
@pytest.mark.parametrize(
"transformer,python_type,format,python_val",
[
(
TensorFlowTensorTransformer(),
tf.Tensor,
TensorFl... | What’s your `to_literal`?
|
What’s your `to_literal`?
| ```def to_literal(
self,
ctx: FlyteContext,
python_val: tf.Tensor,
python_type: Type[tf.Tensor],
expected: LiteralType,
) -> Literal:
meta = BlobMetadata(
type=_core_types.BlobType(
format=self.TENSORFLOW_FORMAT,
dimensio... |
```def to_literal(
self,
ctx: FlyteContext,
python_val: tf.Tensor,
python_type: Type[tf.Tensor],
expected: LiteralType,
) -> Literal:
meta = BlobMetadata(
type=_core_types.BlobType(
format=self.TENSORFLOW_FORMAT,
dimensio... | It’s a LiteralCollection, right? So you’ll need to change your test. Your test is for Blob.
|
It’s a LiteralCollection, right? So you’ll need to change your test. Your test is for Blob.
| Oops, let me change
|
Samhita Alla I'm done pushing the mentioned changes except for linting issues. I was unable to sign off properly because I messed up my pre-commit hooks, will GA run?
Eduardo Apolinario Can my GA builds be run if the DCO check failed? I've to fix my git before rebasing my commits
| yes, it can. could you share the link of the pr?
|
yes, it can. could you share the link of the pr?
| Kevin Su, <https://github.com/flyteorg/flytekit/pull/1243> is the PR. I approved the tests.
|
Kevin Su, <https://github.com/flyteorg/flytekit/pull/1243> is the PR. I approved the tests.
| Kevin Su I've given a go at fixing my linting errors, can the GA builds be re-run?
Eduardo Apolinario Please approve my tests, i've fixed linting errors
Ketan Umare Can you please approve my tests?
I've messed up my previous PR, while trying to fix an unexpected dep issue with flyteidl, i've opened a fresh one #1269 (<... |
Kevin Su I've given a go at fixing my linting errors, can the GA builds be re-run?
Eduardo Apolinario Please approve my tests, i've fixed linting errors
Ketan Umare Can you please approve my tests?
I've messed up my previous PR, while trying to fix an unexpected dep issue with flyteidl, i've opened a fresh one #1269 (<... | cryptic, I’ll review your changes. Give me some time.
|
Just checking if this channel will still be open after Hacktoberfest ends on Monday ? I may have PRs outstanding beyond that date, so may still have queries
| yes
we will keep it open through november?
and we will help you get all the prs through
thank you for all the amazing work Ryan Nazareth
|
yes
we will keep it open through november?
and we will help you get all the prs through
thank you for all the amazing work Ryan Nazareth
| Thanks - thats great ! No worries, its been fun and Ive learnt a lot. You have a very helpful team as well !
|
Eduardo Apolinario Yee Kevin Su Is it possible to use `LiteralCollection` with multiple literal types? If so, how should the `get_literal_type` method be defined since `collection_type` can only accept a single `LiteralType`? See <https://github.com/flyteorg/flytekit/pull/1269/files> PR for reference.
| It is possible but not recommend- the underlying type system allows multi variate lists, but it has been clamped down as static type assertions are not possible
Also don’t know a usecase
|
It is possible but not recommend- the underlying type system allows multi variate lists, but it has been clamped down as static type assertions are not possible
Also don’t know a usecase
| I want to return two literals — a blob and a string — from the `to_literal` method. What’s the preferred way to implement this?
|
I want to return two literals — a blob and a string — from the `to_literal` method. What’s the preferred way to implement this?
| Why?
|
Why?
| Blob contains a serialized tensor and string is the datatype of the tensor.
|
Blob contains a serialized tensor and string is the datatype of the tensor.
| Why do t you add the te sir type in metadata
Like we do in json schema
Or in format?
Happy to discuss
|
Why do t you add the te sir type in metadata
Like we do in json schema
Or in format?
Happy to discuss
| Um, format makes sense but it usually pertains to the file type, right? But I guess it’s okay to send the dtype of the tensor.
Cool. Thanks Ketan! I’ll make the required change.
|
Um, format makes sense but it usually pertains to the file type, right? But I guess it’s okay to send the dtype of the tensor.
Cool. Thanks Ketan! I’ll make the required change.
| When I'm trying to apply the changes you'd suggested me, I'm facing few errors
```@pytest.mark.parametrize(
"transformer, python_val",
[
(TensorFlowTensorTransformer(), result_tensor),
],
)
def test_get_literal_type(transformer, python_val):
tf = transformer
... |
When I'm trying to apply the changes you'd suggested me, I'm facing few errors
```@pytest.mark.parametrize(
"transformer, python_val",
[
(TensorFlowTensorTransformer(), result_tensor),
],
)
def test_get_literal_type(transformer, python_val):
tf = transformer
... | Have you modified the test to reflect the dtype?
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.