Datasets:

tarunabraham1986

/

github-issues

like 0

https://api.github.com/repos/huggingface/datasets/issues/6739

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6739/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6739/comments

https://api.github.com/repos/huggingface/datasets/issues/6739/events

https://github.com/huggingface/datasets/pull/6739

PR_kwDODunzps5p-Bwe

Transpose images with EXIF Orientation tag

closed

CONTRIBUTOR

Closes https://github.com/huggingface/datasets/issues/6252

https://api.github.com/repos/huggingface/datasets/issues/6739/timeline

https://api.github.com/repos/huggingface/datasets/issues/6738

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6738/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6738/comments

https://api.github.com/repos/huggingface/datasets/issues/6738/events

https://github.com/huggingface/datasets/issues/6738

I_kwDODunzps6CrSno

Dict feature is non-nullable while nested dict feature is

closed

CONTRIBUTOR

When i try to create a `Dataset` object with None values inside a dict column, like this: ```python from datasets import Dataset, Features, Value Dataset.from_dict( { "dict": [{"a": 0, "b": 0}, None], }, features=Features( {"dict": {"a": Value("int16"), "b": Value("int16")}} ) ) ``` i get `ValueError: Got None but expected a dictionary instead`. At the same time, having None in _nested_ dict feature works, for example, this doesn't throw any errors: ```python from datasets import Dataset, Features, Value, Sequence dataset = Dataset.from_dict( { "list_dict": [[{"a": 0, "b": 0}], None], "sequence_dict": [[{"a": 0, "b": 0}], None], }, features=Features({ "list_dict": [{"a": Value("int16"), "b": Value("int16")}], "sequence_dict": Sequence({"a": Value("int16"), "b": Value("int16")}), }) ) ``` Other types of features also seem to be nullable (but I haven't checked all of them). Version of `datasets` is the latest atm (2.18.0) Is this an expected behavior or a bug?

https://api.github.com/repos/huggingface/datasets/issues/6738/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6737

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6737/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6737/comments

https://api.github.com/repos/huggingface/datasets/issues/6737/events

https://github.com/huggingface/datasets/issues/6737

I_kwDODunzps6Ci8aZ

Invalid pattern: '**' can only be an entire path component

open

NONE

### Describe the bug ValueError: Invalid pattern: '**' can only be an entire path component when loading any dataset ### Steps to reproduce the bug import datasets ds = datasets.load_dataset("TokenBender/code_instructions_122k_alpaca_style") ### Expected behavior loading the dataset successfully ### Environment info - `datasets` version: 2.18.0 - Platform: Windows-10-10.0.22631-SP0 - Python version: 3.11.7 - `huggingface_hub` version: 0.20.3 - PyArrow version: 15.0.0 - Pandas version: 2.2.1 - `fsspec` version: 2023.12.2

https://api.github.com/repos/huggingface/datasets/issues/6737/timeline

https://api.github.com/repos/huggingface/datasets/issues/6736

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6736/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6736/comments

https://api.github.com/repos/huggingface/datasets/issues/6736/events

https://github.com/huggingface/datasets/issues/6736

I_kwDODunzps6Ci4Qu

Mosaic Streaming (MDS) Support

open

NONE

### Feature request I'm a huge fan of the current HF Datasets `webdataset` integration (especially the built-in streaming support). However, I'd love to upload some robotics and multimodal datasets I've processed for use with [Mosaic Streaming](https://docs.mosaicml.com/projects/streaming/en/stable/), specifically their [MDS Format](https://docs.mosaicml.com/projects/streaming/en/stable/fundamentals/dataset_format.html#mds). Because the shard files have similar semantics to WebDataset, I'm hoping that adding such support won't be too much trouble? ### Motivation One of the downsides with WebDataset is a lack of out-of-the-box determinism (especially for large-scale training and reproducibility), easy job resumption, and the ability to quickly debug / visualize individual examples. Mosaic Streaming provides a [great interface for this out of the box](https://docs.mosaicml.com/projects/streaming/en/stable/#key-features), so I'd love to see it supported in HF Datasets. ### Your contribution Happy to help test things / provide example data. Can potentially submit a PR if maintainers could point me to the necessary WebDataset logic / steps for adding a new streaming format!

https://api.github.com/repos/huggingface/datasets/issues/6736/timeline

https://api.github.com/repos/huggingface/datasets/issues/6735

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6735/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6735/comments

https://api.github.com/repos/huggingface/datasets/issues/6735/events

https://github.com/huggingface/datasets/pull/6735

PR_kwDODunzps5px84g

Add `mode` parameter to `Image` feature

closed

CONTRIBUTOR

Fix https://github.com/huggingface/datasets/issues/6675

https://api.github.com/repos/huggingface/datasets/issues/6735/timeline

https://api.github.com/repos/huggingface/datasets/issues/6734

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6734/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6734/comments

https://api.github.com/repos/huggingface/datasets/issues/6734/events

https://github.com/huggingface/datasets/issues/6734

I_kwDODunzps6CZNbm

Tokenization slows towards end of dataset

open

NONE

### Describe the bug Mapped tokenization slows down substantially towards end of dataset. train set started off very slow, caught up to 20k then tapered off til the end. what's particularly strange is that the tokenization crashed a few times before due to errors with invalid tokens somewhere or corrupted downloads, and the speed ups/downs consistently happened the same times ```bash Running tokenizer on dataset (num_proc=48): 0%| | 847000/881416735 [12:18<252:45:45, 967.72 examples/s] Running tokenizer on dataset (num_proc=48): 0%| | 848000/881416735 [12:19<224:16:10, 1090.66 examples/s] Running tokenizer on dataset (num_proc=48): 10%|▉ | 84964000/881416735 [3:48:00<11:21:34, 19476.01 examples/s] Running tokenizer on dataset (num_proc=48): 10%|▉ | 84967000/881416735 [3:48:00<12:04:01, 18333.79 examples/s] Running tokenizer on dataset (num_proc=48): 61%|██████ | 538631977/881416735 [13:46:40<27:50:04, 3420.84 examples/s] Running tokenizer on dataset (num_proc=48): 61%|██████ | 538632977/881416735 [13:46:40<23:48:20, 3999.77 examples/s] Running tokenizer on dataset (num_proc=48): 100%|█████████▉| 881365886/881416735 [38:30:19<04:34, 185.10 examples/s] Running tokenizer on dataset (num_proc=48): 100%|█████████▉| 881366886/881416735 [38:30:25<04:36, 180.57 examples/s] ``` and validation set as well ```bash Running tokenizer on dataset (num_proc=48): 90%|████████▉ | 41544000/46390354 [28:44<02:37, 30798.76 examples/s] Running tokenizer on dataset (num_proc=48): 90%|████████▉ | 41550000/46390354 [28:44<02:08, 37698.08 examples/s] Running tokenizer on dataset (num_proc=48): 96%|█████████▋| 44747422/46390354 [2:15:48<12:22:44, 36.87 examples/s] Running tokenizer on dataset (num_proc=48): 96%|█████████▋| 44747422/46390354 [2:16:00<12:22:44, 36.87 examples/s] ``` ### Steps to reproduce the bug using the following kwargs ```python with accelerator.main_process_first(): lm_datasets = tokenized_datasets.map( group_texts, batched=True, num_proc=48 load_from_cache_file=True, desc=f"Grouping texts in chunks of {block_size}", ) ``` running through slurm script ```bash #SBATCH --partition=gpu-nvidia-a100 #SBATCH --nodes=1 #SBATCH --ntasks=1 #SBATCH --gpus-per-task=8 #SBATCH --cpus-per-task=96 ``` using this dataset https://huggingface.co/datasets/togethercomputer/RedPajama-Data-1T ### Expected behavior Constant speed throughout ### Environment info - `datasets` version: 2.15.0 - Platform: Linux-5.15.0-1049-aws-x86_64-with-glibc2.10 - Python version: 3.8.18 - `huggingface_hub` version: 0.19.4 - PyArrow version: 14.0.1 - Pandas version: 2.0.3 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6734/timeline

https://api.github.com/repos/huggingface/datasets/issues/6733

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6733/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6733/comments

https://api.github.com/repos/huggingface/datasets/issues/6733/events

https://github.com/huggingface/datasets/issues/6733

I_kwDODunzps6CWBlM

EmptyDatasetError when loading dataset downloaded with HuggingFace cli

open

NONE

### Describe the bug I am using a cluster that does not have access to the internet when given a job. I tried downloading the dataset using the huggingface-cli command and then loading it with load_dataset but I get an error: ```raise EmptyDatasetError(f"The directory at {base_path} doesn't contain any data files") from None``` The dataset I'm using is "lmsys/chatbot_arena_conversations". The folder structure is - README.md - data - train-00000-of-00001-cced8514c7ed782a.parquet ### Steps to reproduce the bug 1. Download dataset using HuggingFace CLI: ```huggingface-cli download lmsys/chatbot_arena_conversations --local-dir ./lmsys/chatbot_arena_conversations``` 2. In Python ``` from datasets import load_dataset load_dataset("lmsys/chatbot_arena_conversations") ``` ### Expected behavior Should return a Dataset Dict in the form of ``` DatasetDict({ train: Dataset({ features: [...], num_rows: 33,000 }) }) ``` ### Environment info Python 3.11.5 Datasets 2.18.0 Transformers 4.38.2 Pytorch 2.2.0 Pyarrow 15.0.1 Rocky Linux release 8.9 (Green Obsidian)

https://api.github.com/repos/huggingface/datasets/issues/6733/timeline

https://api.github.com/repos/huggingface/datasets/issues/6731

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6731/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6731/comments

https://api.github.com/repos/huggingface/datasets/issues/6731/events

https://github.com/huggingface/datasets/issues/6731

I_kwDODunzps6CG5EB

Unexpected behavior when using load_dataset with streaming=True in a for loop

closed

NONE

### Describe the bug ### My Code ``` from datasets import load_dataset res=[] for i in [0,1]: di=load_dataset( "json", data_files='path_to.json', split='train', streaming=True, ).map(lambda x: {"source": i}) res.append(di) for e in res[0]: print(e) ``` ### Unexpected Behavior Data in `res[0]` has `source=1`. However the expected value is 0. ### FYI I further switch `streaming` to `False`. And the output value is as expected (0). So there may exist bugs in setting `streaming=True` in a for loop. ### Environment Python 3.8.0 datasets==2.18.0 transformers==4.28.1 ### Steps to reproduce the bug 1. Create a Json file with any content. 2. Run the provided code. 3. Switch `streaming` to `False` and run again to see the expected behavior. ### Expected behavior The expected behavior is the data are mapped with its corresponding value in the for loop. ### Environment info Python 3.8.0 datasets==2.18.0 transformers==4.28.1 Ubuntu 20.04

https://api.github.com/repos/huggingface/datasets/issues/6731/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6730

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6730/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6730/comments

https://api.github.com/repos/huggingface/datasets/issues/6730/events

https://github.com/huggingface/datasets/pull/6730

PR_kwDODunzps5pZDsB

Deprecate Pandas builder

closed

CONTRIBUTOR

The Pandas packaged builder is undocumented and relies on `pickle` to read the data, making it **unsafe**. Moreover, I haven't seen a single instance of this builder being used (not even using the GH/Hub search), so we should deprecate it.

https://api.github.com/repos/huggingface/datasets/issues/6730/timeline

https://api.github.com/repos/huggingface/datasets/issues/6729

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6729/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6729/comments

https://api.github.com/repos/huggingface/datasets/issues/6729/events

https://github.com/huggingface/datasets/issues/6729

I_kwDODunzps6B88dn

Support zipfiles that span multiple disks?

open

CONTRIBUTOR

See https://huggingface.co/datasets/PhilEO-community/PhilEO-downstream The dataset viewer gives the following error: ``` Error code: ConfigNamesError Exception: BadZipFile Message: zipfiles that span multiple disks are not supported Traceback: Traceback (most recent call last): File "/src/services/worker/src/worker/job_runners/dataset/config_names.py", line 67, in compute_config_names_response get_dataset_config_names( File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/inspect.py", line 347, in get_dataset_config_names dataset_module = dataset_module_factory( File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 1871, in dataset_module_factory raise e1 from None File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 1846, in dataset_module_factory return HubDatasetModuleFactoryWithoutScript( File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 1240, in get_module module_name, default_builder_kwargs = infer_module_for_data_files( File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 584, in infer_module_for_data_files split_modules = { File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 585, in <dictcomp> split: infer_module_for_data_files_list(data_files_list, download_config=download_config) File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 526, in infer_module_for_data_files_list return infer_module_for_data_files_list_in_archives(data_files_list, download_config=download_config) File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 554, in infer_module_for_data_files_list_in_archives for f in xglob(extracted, recursive=True, download_config=download_config)[ File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/download/streaming_download_manager.py", line 576, in xglob fs, *_ = fsspec.get_fs_token_paths(urlpath, storage_options=storage_options) File "/src/services/worker/.venv/lib/python3.9/site-packages/fsspec/core.py", line 622, in get_fs_token_paths fs = filesystem(protocol, **inkwargs) File "/src/services/worker/.venv/lib/python3.9/site-packages/fsspec/registry.py", line 290, in filesystem return cls(**storage_options) File "/src/services/worker/.venv/lib/python3.9/site-packages/fsspec/spec.py", line 79, in __call__ obj = super().__call__(*args, **kwargs) File "/src/services/worker/.venv/lib/python3.9/site-packages/fsspec/implementations/zip.py", line 57, in __init__ self.zip = zipfile.ZipFile( File "/usr/local/lib/python3.9/zipfile.py", line 1266, in __init__ self._RealGetContents() File "/usr/local/lib/python3.9/zipfile.py", line 1329, in _RealGetContents endrec = _EndRecData(fp) File "/usr/local/lib/python3.9/zipfile.py", line 286, in _EndRecData return _EndRecData64(fpin, -sizeEndCentDir, endrec) File "/usr/local/lib/python3.9/zipfile.py", line 232, in _EndRecData64 raise BadZipFile("zipfiles that span multiple disks are not supported") zipfile.BadZipFile: zipfiles that span multiple disks are not supported ``` The files (https://huggingface.co/datasets/PhilEO-community/PhilEO-downstream/tree/main/data) are: <img width="629" alt="Capture d’écran 2024-03-11 à 22 07 30" src="https://github.com/huggingface/datasets/assets/1676121/0bb15a51-d54f-4d73-8572-e427ea644b36">

https://api.github.com/repos/huggingface/datasets/issues/6729/timeline

https://api.github.com/repos/huggingface/datasets/issues/6728

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6728/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6728/comments

https://api.github.com/repos/huggingface/datasets/issues/6728/events

https://github.com/huggingface/datasets/issues/6728

I_kwDODunzps6B2uek

Issue Downloading Certain Datasets After Setting Custom `HF_ENDPOINT`

closed

NONE

### Describe the bug This bug is triggered under the following conditions: - datasets repo ids without organization names trigger errors, such as `bookcorpus`, `gsm8k`, `wikipedia`, rather than in the form of `A/B`. - If `HF_ENDPOINT` is set and the hostname is not in the form of `(hub-ci.)?huggingface.co`. - This issue occurs with `datasets>2.15.0` or `huggingface-hub>0.19.4`. For example, using the latest versions: `datasets==2.18.0` and `huggingface-hub==0.21.4`, ### Steps to reproduce the bug the issue can be reproduced with the following code: 1. install specific datasets and huggingface_hub. ```bash pip install datasets==2.18.0 pip install huggingface_hub==0.21.4 ``` 2. execute python code. ```Python import os os.environ['HF_ENDPOINT'] = 'https://hf-mirror.com' from datasets import load_dataset bookcorpus = load_dataset('bookcorpus', split='train') ``` console output: ``` Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/padeoe/.local/lib/python3.10/site-packages/datasets/load.py", line 2556, in load_dataset builder_instance = load_dataset_builder( File "/home/padeoe/.local/lib/python3.10/site-packages/datasets/load.py", line 2228, in load_dataset_builder dataset_module = dataset_module_factory( File "/home/padeoe/.local/lib/python3.10/site-packages/datasets/load.py", line 1879, in dataset_module_factory raise e1 from None File "/home/padeoe/.local/lib/python3.10/site-packages/datasets/load.py", line 1830, in dataset_module_factory with fs.open(f"datasets/{path}/{filename}", "r", encoding="utf-8") as f: File "/home/padeoe/.local/lib/python3.10/site-packages/fsspec/spec.py", line 1295, in open self.open( File "/home/padeoe/.local/lib/python3.10/site-packages/fsspec/spec.py", line 1307, in open f = self._open( File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/hf_file_system.py", line 228, in _open return HfFileSystemFile(self, path, mode=mode, revision=revision, block_size=block_size, **kwargs) File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/hf_file_system.py", line 615, in __init__ self.resolved_path = fs.resolve_path(path, revision=revision) File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/hf_file_system.py", line 180, in resolve_path repo_and_revision_exist, err = self._repo_and_revision_exist(repo_type, repo_id, revision) File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/hf_file_system.py", line 117, in _repo_and_revision_exist self._api.repo_info(repo_id, revision=revision, repo_type=repo_type) File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 118, in _inner_fn return fn(*args, **kwargs) File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/hf_api.py", line 2413, in repo_info return method( File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 118, in _inner_fn return fn(*args, **kwargs) File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/hf_api.py", line 2286, in dataset_info hf_raise_for_status(r) File "/home/padeoe/.local/lib/python3.10/site-packages/huggingface_hub/utils/_errors.py", line 362, in hf_raise_for_status raise HfHubHTTPError(str(e), response=response) from e huggingface_hub.utils._errors.HfHubHTTPError: 401 Client Error: Unauthorized for url: https://hf-mirror.com/api/datasets/bookcorpus/bookcorpus.py (Request ID: Root=1-65ee8659-5ab10eec5960c63e71f2bb58;b00bdbea-fd6e-4a74-8fe0-bc4682ae090e) ``` ### Expected behavior The dataset was downloaded correctly without any errors. ### Environment info datasets==2.18.0 huggingface-hub==0.21.4

https://api.github.com/repos/huggingface/datasets/issues/6728/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6727

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6727/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6727/comments

https://api.github.com/repos/huggingface/datasets/issues/6727/events

https://github.com/huggingface/datasets/pull/6727

PR_kwDODunzps5pLJyE

Using a registry instead of calling globals for fetching feature types

closed

CONTRIBUTOR

Hello, When working with bio-data, each feature often has metadata associated with it (e.g. species, lineage, snp position, etc). To store this, I like to use the feature classes with the added `metadata` attribute. However, when saving or loading with custom features, you get an error since that class doesn't exist in the global namespace in `datasets.features.features`. Take for example, ```python from dataclasses import dataclass, field from datasets import Dataset from datasets.features.features import Value, Features @dataclass class FeatureA(Value): metadata: dict = field(default=dict) _type: str = field(default="FeatureA", init=False, repr=False) @dataclass class FeatureB(Value): metadata: dict = field(default_factory=dict) _type: str = field(default="FeatureB", init=False, repr=False) test_data = { "a": [1, 2, 3], "b": [4, 5, 6], } test_data = Dataset.from_dict( test_data, features=Features({ "a": FeatureA("int32", metadata={"species": "lactobacillus acetotolerans"}), "b": FeatureB("int32", metadata={"species": "lactobacillus iners"}), }) ) # returns an error since FeatureA and FeatureB are not in the global namespace test_data.save_to_disk('./test_data') ``` Saving the dataset (0/1 shards): 0%| | 0/3 [00:00<?, ? examples/s] --------------------------------------------------------------------------- KeyError Traceback (most recent call last) Cell In[2], line 28 19 test_data = Dataset.from_dict( 20 test_data, 21 features=Features({ (...) 24 }) 25 ) 27 # returns an error since FeatureA and FeatureB are not in the global namespace ---> 28 test_data.save_to_disk('./test_data') ... File ~\Documents\datasets\src\datasets\features\features.py:1361, in generate_from_dict(obj) 1359 return {key: generate_from_dict(value) for key, value in obj.items()} 1360 obj = dict(obj) -> 1361 class_type = globals()[obj.pop("_type")] 1363 if class_type == Sequence: 1364 return Sequence(feature=generate_from_dict(obj["feature"]), length=obj.get("length", -1)) KeyError: 'FeatureA' We can avoid this by having a registry (like formatters) and doing ```python from datasets.features.features import register_feature register_feature(FeatureA, "FeatureA") register_feature(FeatureB, "FeatureB") test_data.save_to_disk('./test_data') ``` Saving the dataset (1/1 shards): 100%|------| 3/3 [00:00<00:00, 211.13 examples/s] and loading from disk returns with all metadata information ```python from datasets import load_from_disk test_data = load_from_disk('./test_data') test_data.features ``` {'a': FeatureA(dtype='int32', id=None, metadata={'species': 'lactobacillus acetotolerans'}), 'b': FeatureB(dtype='int32', id=None, metadata={'species': 'lactobacillus iners'})}

https://api.github.com/repos/huggingface/datasets/issues/6727/timeline

https://api.github.com/repos/huggingface/datasets/issues/6726

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6726/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6726/comments

https://api.github.com/repos/huggingface/datasets/issues/6726/events

https://github.com/huggingface/datasets/issues/6726

I_kwDODunzps6Bw94Q

Profiling for HF Filesystem shows there are easy performance gains to be made

open

NONE

### Describe the bug # Let's make it faster First, an evidence...  Figure 1: CProfile for loading 3 files from cerebras/SlimPajama-627B train split, and 3 files from test split using streaming=True. X axis is 1106 seconds long. See? It's pretty slow. What is resolve pattern doing? ``` resolve_pattern called with **/train/** and hf://datasets/cerebras/SlimPajama-627B@2d0accdd58c5d5511943ca1f5ff0e3eb5e293543 resolve_pattern took 20.815081119537354 seconds ``` Makes sense. How to improve it? ## Bigger project, biggest payoff Databricks (and consequently, spark) store a compressed manifest file of the files contained in the remote filesystem. Then, you download one tiny file, decompress it, and all the operations are local instead of this shenanigans. It seems pretty straightforward to make dataset uploads compute a manifest and upload it alongside their data. This would make resolution time so fast that nobody would ever think about it again. It also means you either need to have the uploader compute it _every time_, or have a hook that computes it. ## Smaller project, immediate payoff: Be diligent in avoiding deepcopy Revise the _ls_tree method to avoid deepcopy: ``` def _ls_tree( self, path: str, recursive: bool = False, refresh: bool = False, revision: Optional[str] = None, expand_info: bool = True, ): ..... omitted ..... for path_info in tree: if isinstance(path_info, RepoFile): cache_path_info = { "name": root_path + "/" + path_info.path, "size": path_info.size, "type": "file", "blob_id": path_info.blob_id, "lfs": path_info.lfs, "last_commit": path_info.last_commit, "security": path_info.security, } else: cache_path_info = { "name": root_path + "/" + path_info.path, "size": 0, "type": "directory", "tree_id": path_info.tree_id, "last_commit": path_info.last_commit, } parent_path = self._parent(cache_path_info["name"]) self.dircache.setdefault(parent_path, []).append(cache_path_info) out.append(cache_path_info) return copy.deepcopy(out) # copy to not let users modify the dircache ``` Observe this deepcopy at the end. It is making a copy of a very simple data structure. We do not need to copy. We can simply generate the data structure twice instead. It will be much faster. ``` def _ls_tree( self, path: str, recursive: bool = False, refresh: bool = False, revision: Optional[str] = None, expand_info: bool = True, ): ..... omitted ..... def make_cache_path_info(path_info): if isinstance(path_info, RepoFile): return { "name": root_path + "/" + path_info.path, "size": path_info.size, "type": "file", "blob_id": path_info.blob_id, "lfs": path_info.lfs, "last_commit": path_info.last_commit, "security": path_info.security, } else: return { "name": root_path + "/" + path_info.path, "size": 0, "type": "directory", "tree_id": path_info.tree_id, "last_commit": path_info.last_commit, } for path_info in tree: cache_path_info = make_cache_path_info(path_info) out_cache_path_info = make_cache_path_info(path_info) # copy to not let users modify the dircache parent_path = self._parent(cache_path_info["name"]) self.dircache.setdefault(parent_path, []).append(cache_path_info) out.append(out_cache_path_info) return out ``` Note there is no longer a deepcopy in this method. We have replaced it with generating the output twice. This is substantially faster. For me, the entire resolution went from 1100s to 360s. ## Medium project, medium payoff After the above change, we have this profile:  Figure 2: x-axis is 355 seconds. Note that globbing and _ls_tree deep copy is gone. No surprise there. It's much faster now, but we still spend ~187seconds in get_fs_token_paths. Well get_fs_token_paths is part of fsspec. We don't need to fix that because we can trust their developers to write high performance code. Probably the caller has misconfigured something. Let's take a look at the storage_options being provided to the filesystem that is constructed during this call. Ah yes, streaming_download_manager::_prepare_single_hop_path_and_storage_options. We know streaming download manager is not compatible with async right now, but we really need this specific part of the code to be async. We're spending so much time checking isDir on the remote filesystem, it's a huge waste. We can make the call easily 20-30x faster by using async, removing this performance bottleneck almost entirely (and reducing the total time of this part of the code to <30s. There is no reason to block async isDir calls for streaming. I'm not going to mess w/ this one myself; I didn't write the streaming impl, and I don't know how it works, but I know the isDir check can be async. ### Steps to reproduce the bug ``` with cProfile.Profile() as pr: pr.enable() # Begin Data if not os.path.exists(data_cache_dir): os.makedirs(data_cache_dir, exist_ok=True) training_dataset = load_dataset(training_dataset_name, split=training_split, cache_dir=data_cache_dir, streaming=True).take(training_slice) eval_dataset = load_dataset(eval_dataset_name, split=eval_split, cache_dir=data_cache_dir, streaming=True).take(eval_slice) # End Data pr.disable() pr.create_stats() if not os.path.exists(profiling_path): os.makedirs(profiling_path, exist_ok=True) pr.dump_stats(os.path.join(profiling_path, "cprofile.prof")) ``` run this code for "cerebras/SlimPajama-627B" and whatever other params ### Expected behavior Something better. ### Environment info - `datasets` version: 2.18.0 - Platform: Linux-5.15.146.1-microsoft-standard-WSL2-x86_64-with-glibc2.35 - Python version: 3.10.13 - `huggingface_hub` version: 0.21.3 - PyArrow version: 15.0.0 - Pandas version: 2.2.1 - `fsspec` version: 2024.2.0

https://api.github.com/repos/huggingface/datasets/issues/6726/timeline

https://api.github.com/repos/huggingface/datasets/issues/6725

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6725/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6725/comments

https://api.github.com/repos/huggingface/datasets/issues/6725/events

https://github.com/huggingface/datasets/issues/6725

I_kwDODunzps6Bq-pq

Request for a comparison of huggingface datasets compared with other data format especially webdataset

open

NONE

### Feature request Request for a comparison of huggingface datasets compared with other data format especially webdataset ### Motivation I see huggingface datasets uses Apache Arrow as its backend, it seems to be great, but I'm curious about how it is good compared with other dataset format, like webdataset, what's the pros/cons of them. ### Your contribution More information

https://api.github.com/repos/huggingface/datasets/issues/6725/timeline

https://api.github.com/repos/huggingface/datasets/issues/6724

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6724/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6724/comments

https://api.github.com/repos/huggingface/datasets/issues/6724/events

https://github.com/huggingface/datasets/issues/6724

I_kwDODunzps6Bmq8T

Dataset with loading script does not work in renamed repos

open

CONTRIBUTOR

### Describe the bug My data repository was first called `BramVanroy/hplt-mono-v1-2` but I then renamed to use underscores instead of dashes. However, it seems that `datasets` retrieves the old repo name when it checks whether the repo contains data loading scripts in this line. https://github.com/huggingface/datasets/blob/6fb6c834f008996c994b0a86c3808d0a33d44525/src/datasets/load.py#L1845 When I print `filename` it returns `hplt-mono-v1-2.py` but the files in the repo are of course `['.gitattributes', 'README.md', 'hplt_mono_v1_2.py']`. So the `filename` is the original reponame instead of the renamed one. I am not sure if this is a caching issue or not or how I can resolve it. ### Steps to reproduce the bug ``` from datasets import load_dataset ds = load_dataset( "BramVanroy/hplt-mono-v1-2", "ky", trust_remote_code=True ) ``` ### Expected behavior That the most recent repo name is used when `filename` is generated. ### Environment info - `datasets` version: 2.16.1 - Platform: Linux-5.14.0-284.25.1.el9_2.x86_64-x86_64-with-glibc2.34 - Python version: 3.10.13 - `huggingface_hub` version: 0.20.2 - PyArrow version: 14.0.1 - Pandas version: 2.1.3 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6724/timeline

https://api.github.com/repos/huggingface/datasets/issues/6723

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6723/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6723/comments

https://api.github.com/repos/huggingface/datasets/issues/6723/events

https://github.com/huggingface/datasets/pull/6723

PR_kwDODunzps5o_fPU

get_dataset_default_config_name docstring

closed

MEMBER

fix https://github.com/huggingface/datasets/pull/6722

https://api.github.com/repos/huggingface/datasets/issues/6723/timeline

https://api.github.com/repos/huggingface/datasets/issues/6722

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6722/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6722/comments

https://api.github.com/repos/huggingface/datasets/issues/6722/events

https://github.com/huggingface/datasets/pull/6722

PR_kwDODunzps5o_ch0

Add details in docstring

closed

CONTRIBUTOR

see https://github.com/huggingface/datasets-server/pull/2554#discussion_r1516516867

https://api.github.com/repos/huggingface/datasets/issues/6722/timeline

https://api.github.com/repos/huggingface/datasets/issues/6721

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6721/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6721/comments

https://api.github.com/repos/huggingface/datasets/issues/6721/events

https://github.com/huggingface/datasets/issues/6721

I_kwDODunzps6Bk5DC

Hi,do you know how to load the dataset from local file now?

open

NONE

Hi, if I want to load the dataset from local file, then how to specify the configuration name? _Originally posted by @WHU-gentle in https://github.com/huggingface/datasets/issues/2976#issuecomment-1333455222_

https://api.github.com/repos/huggingface/datasets/issues/6721/timeline

https://api.github.com/repos/huggingface/datasets/issues/6720

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6720/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6720/comments

https://api.github.com/repos/huggingface/datasets/issues/6720/events

https://github.com/huggingface/datasets/issues/6720

I_kwDODunzps6Bjo6D

TypeError: 'str' object is not callable

closed

CONTRIBUTOR

### Describe the bug I am trying to get the HPLT datasets on the hub. Downloading/re-uploading would be too time- and resource consuming so I wrote [a dataset loader script](https://huggingface.co/datasets/BramVanroy/hplt_mono_v1_2/blob/main/hplt_mono_v1_2.py). I think I am very close but for some reason I always get the error below. It happens during the clean-up phase where the directory cannot be removed because it is not empty. My only guess would be that this may have to do with zstandard ``` Traceback (most recent call last): File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 1744, in _prepare_split_single writer.write(example, key) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/arrow_writer.py", line 492, in write self.write_examples_on_file() File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/arrow_writer.py", line 434, in write_examples_on_file if self.schema File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/arrow_writer.py", line 409, in schema else (pa.schema(self._features.type) if self._features is not None else None) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1643, in type return get_nested_type(self) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1209, in get_nested_type {key: get_nested_type(schema[key]) for key in schema} File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1209, in <dictcomp> {key: get_nested_type(schema[key]) for key in schema} File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1221, in get_nested_type value_type = get_nested_type(schema.feature) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1228, in get_nested_type return schema() TypeError: 'str' object is not callable During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 1753, in _prepare_split_single num_examples, num_bytes = writer.finalize() File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/arrow_writer.py", line 588, in finalize self.write_examples_on_file() File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/arrow_writer.py", line 434, in write_examples_on_file if self.schema File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/arrow_writer.py", line 409, in schema else (pa.schema(self._features.type) if self._features is not None else None) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1643, in type return get_nested_type(self) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1209, in get_nested_type {key: get_nested_type(schema[key]) for key in schema} File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1209, in <dictcomp> {key: get_nested_type(schema[key]) for key in schema} File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1221, in get_nested_type value_type = get_nested_type(schema.feature) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/features/features.py", line 1228, in get_nested_type return schema() TypeError: 'str' object is not callable The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 959, in incomplete_dir yield tmp_dir File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 1005, in download_and_prepare self._download_and_prepare( File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 1767, in _download_and_prepare super()._download_and_prepare( File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 1100, in _download_and_prepare self._prepare_split(split_generator, **prepare_split_kwargs) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 1605, in _prepare_split for job_id, done, content in self._prepare_split_single( File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 1762, in _prepare_split_single raise DatasetGenerationError("An error occurred while generating the dataset") from e datasets.exceptions.DatasetGenerationError: An error occurred while generating the dataset During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/pricie/vanroy/.config/JetBrains/PyCharm2023.3/scratches/scratch_5.py", line 4, in <module> ds = load_dataset( File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/load.py", line 2549, in load_dataset builder_instance.download_and_prepare( File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 985, in download_and_prepare with incomplete_dir(self._output_dir) as tmp_output_dir: File "/home/pricie/vanroy/.pyenv/versions/3.10.13/lib/python3.10/contextlib.py", line 153, in __exit__ self.gen.throw(typ, value, traceback) File "/home/local/vanroy/dutch-instruction-datasets/.venv/lib/python3.10/site-packages/datasets/builder.py", line 966, in incomplete_dir shutil.rmtree(tmp_dir) File "/home/pricie/vanroy/.pyenv/versions/3.10.13/lib/python3.10/shutil.py", line 731, in rmtree onerror(os.rmdir, path, sys.exc_info()) File "/home/pricie/vanroy/.pyenv/versions/3.10.13/lib/python3.10/shutil.py", line 729, in rmtree os.rmdir(path) OSError: [Errno 39] Directory not empty: '/home/pricie/vanroy/.cache/huggingface/datasets/BramVanroy___hplt_mono_v1_2/ky/1.2.0/7ab138629fe7e9e29fe93ce63d809d5ef9d963273b829f61ab538e012dc9cc47.incomplete' ``` Interestingly, though, this directory _does_ appear to be empty: ```shell > cd /home/pricie/vanroy/.cache/huggingface/datasets/BramVanroy___hplt_mono_v1_2/ky/1.2.0/7ab138629fe7e9e29fe93ce63d809d5ef9d963273b829f61ab538e012dc9cc47.incomplete > ls -lah total 0 drwxr-xr-x. 1 vanroy vanroy 0 Mar 7 12:01 . drwxr-xr-x. 1 vanroy vanroy 304 Mar 7 11:52 .. > cd .. > ls 7ab138629fe7e9e29fe93ce63d809d5ef9d963273b829f61ab538e012dc9cc47_builder.lock 7ab138629fe7e9e29fe93ce63d809d5ef9d963273b829f61ab538e012dc9cc47.incomplete ``` ### Steps to reproduce the bug ```python from datasets import load_dataset ds = load_dataset( "BramVanroy/hplt_mono_v1_2", "ky", trust_remote_code=True ) ``` ### Expected behavior No error. ### Environment info - `datasets` version: 2.16.1 - Platform: Linux-5.14.0-284.25.1.el9_2.x86_64-x86_64-with-glibc2.34 - Python version: 3.10.13 - `huggingface_hub` version: 0.20.2 - PyArrow version: 14.0.1 - Pandas version: 2.1.3 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6720/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6719

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6719/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6719/comments

https://api.github.com/repos/huggingface/datasets/issues/6719/events

https://github.com/huggingface/datasets/issues/6719

I_kwDODunzps6BUUA_

Is there any way to solve hanging of IterableDataset using split by node + filtering during inference

open

NONE

### Describe the bug I am using an iterable dataset in a multi-node setup, trying to do training/inference while filtering the data on the fly. I usually do not use `split_dataset_by_node` but it is very slow using the IterableDatasetShard in `accelerate` and `transformers`. When I filter after applying `split_dataset_by_node`, it results in shards that are not equal sizes due to unequal samples filtered from each one. The distributed process hangs when trying to accomplish this. Is there any way to resolve this or is it impossible to implement? ### Steps to reproduce the bug Here is a toy example of what I am trying to do that reproduces the behavior ``` # torchrun --nproc-per-node 2 file.py import os import pandas as pd import torch from accelerate import Accelerator from datasets import Features, Value, load_dataset from datasets.distributed import split_dataset_by_node from torch.utils.data import DataLoader accelerator = Accelerator(device_placement=True, dispatch_batches=False) if accelerator.is_main_process: if not os.path.exists("scratch_data"): os.mkdir("scratch_data") n_shards = 4 for i in range(n_shards): df = pd.DataFrame({"id": list(range(10 * i, 10 * (i + 1)))}) df.to_parquet(f"scratch_data/shard_{i}.parquet") world_size = accelerator.num_processes local_rank = accelerator.process_index def collate_fn(examples): input_ids = [] for example in examples: input_ids.append(example["id"]) return torch.LongTensor(input_ids) dataset = load_dataset( "parquet", data_dir="scratch_data", split="train", streaming=True ) dataset = ( split_dataset_by_node(dataset, rank=local_rank, world_size=world_size) .filter(lambda x: x["id"] < 35) .shuffle(seed=42, buffer_size=100) ) batch_size = 2 train_dataloader = DataLoader( dataset, batch_size=batch_size, collate_fn=collate_fn, num_workers=2 ) for x in train_dataloader: x = x.to(accelerator.device) print({"rank": local_rank, "id": x}) y = accelerator.gather_for_metrics(x) if accelerator.is_main_process: print("gathered", y) ``` ### Expected behavior Is there any way to continue training/inference on the GPUs that have remaining data left without waiting for the others? Is it impossible to filter when ### Environment info - `datasets` version: 2.18.0 - Platform: Linux-5.10.209-198.812.amzn2.x86_64-x86_64-with-glibc2.31 - Python version: 3.10.13 - `huggingface_hub` version: 0.21.3 - PyArrow version: 15.0.0 - Pandas version: 2.2.1 - `fsspec` version: 2023.6.0

https://api.github.com/repos/huggingface/datasets/issues/6719/timeline

https://api.github.com/repos/huggingface/datasets/issues/6718

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6718/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6718/comments

https://api.github.com/repos/huggingface/datasets/issues/6718/events

https://github.com/huggingface/datasets/pull/6718

PR_kwDODunzps5ouwwE

Fix concurrent script loading with force_redownload

closed

MEMBER

I added `lock_importable_file` in `get_dataset_builder_class` and `extend_dataset_builder_for_streaming` to fix the issue, and I also added a test cc @clefourrier

https://api.github.com/repos/huggingface/datasets/issues/6718/timeline

https://api.github.com/repos/huggingface/datasets/issues/6717

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6717/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6717/comments

https://api.github.com/repos/huggingface/datasets/issues/6717/events

https://github.com/huggingface/datasets/issues/6717

I_kwDODunzps6BRCOg

`remove_columns` method used with a streaming enable dataset mode produces a LibsndfileError on multichannel audio

open

NONE

### Describe the bug When loading a HF dataset in streaming mode and removing some columns, it is impossible to load a sample if the audio contains more than one channel. I have the impression that the time axis and channels are swapped or concatenated. ### Steps to reproduce the bug Minimal error code: ```python from datasets import load_dataset dataset_name = "zinc75/Vibravox_dummy" config_name = "BWE_Larynx_microphone" # if we use "ASR_Larynx_microphone" subset which is a monochannel audio, no error is thrown. dataset = load_dataset( path=dataset_name, name=config_name, split="train", streaming=True ) dataset = dataset.remove_columns(["sensor_id"]) # dataset = dataset.map(lambda x:x, remove_columns=["sensor_id"]) # The commented version does not produce an error, but loses the dataset features. sample = next(iter(dataset)) ``` Error: ``` Traceback (most recent call last): File "/home/julien/Bureau/github/vibravox/tmp.py", line 15, in <module> sample = next(iter(dataset)) ^^^^^^^^^^^^^^^^^^^ File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/datasets/iterable_dataset.py", line 1392, in __iter__ example = _apply_feature_types_on_example( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/datasets/iterable_dataset.py", line 1080, in _apply_feature_types_on_example encoded_example = features.encode_example(example) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/datasets/features/features.py", line 1889, in encode_example return encode_nested_example(self, example) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/datasets/features/features.py", line 1244, in encode_nested_example {k: encode_nested_example(schema[k], obj.get(k), level=level + 1) for k in schema} File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/datasets/features/features.py", line 1244, in <dictcomp> {k: encode_nested_example(schema[k], obj.get(k), level=level + 1) for k in schema} ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/datasets/features/features.py", line 1300, in encode_nested_example return schema.encode_example(obj) if obj is not None else None ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/datasets/features/audio.py", line 98, in encode_example sf.write(buffer, value["array"], value["sampling_rate"], format="wav") File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/soundfile.py", line 343, in write with SoundFile(file, 'w', samplerate, channels, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/soundfile.py", line 658, in __init__ self._file = self._open(file, mode_int, closefd) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/julien/.pyenv/versions/vibravox/lib/python3.11/site-packages/soundfile.py", line 1216, in _open raise LibsndfileError(err, prefix="Error opening {0!r}: ".format(self.name)) soundfile.LibsndfileError: Error opening <_io.BytesIO object at 0x7fd795d24680>: Format not recognised. Process finished with exit code 1 ``` ### Expected behavior I would expect this code to run without error. ### Environment info - `datasets` version: 2.18.0 - Platform: Linux-6.5.0-21-generic-x86_64-with-glibc2.35 - Python version: 3.11.0 - `huggingface_hub` version: 0.21.3 - PyArrow version: 15.0.0 - Pandas version: 2.2.1 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6717/timeline

https://api.github.com/repos/huggingface/datasets/issues/6716

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6716/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6716/comments

https://api.github.com/repos/huggingface/datasets/issues/6716/events

https://github.com/huggingface/datasets/issues/6716

I_kwDODunzps6BQ9X-

Non-deterministic `Dataset.builder_name` value

closed

NONE

### Describe the bug I'm not sure if this is a bug, but `print(ds.builder_name)` in the following code sometimes prints out `rotten_tomatoes` instead of `parquet`: ```python import datasets for _ in range(100): ds = datasets.load_dataset("rotten_tomatoes", split="train") print(ds.builder_name) # prints out "rotten_tomatoes" sometimes instead of "parquet" ``` Output: ``` ... parquet parquet parquet rotten_tomatoes parquet parquet parquet ... ``` Here's a reproduction using GitHub Actions: https://github.com/mlflow/mlflow/actions/runs/8153247984/job/22284263613?pr=11329#step:12:241 One of our tests is flaky because `builder_name` is not deterministic. ### Steps to reproduce the bug 1. Run the code above. ### Expected behavior Always prints out `parquet`? ### Environment info ``` Copy-and-paste the text below in your GitHub issue. - `datasets` version: 2.18.0 - Platform: Linux-6.5.0-1015-azure-x86_64-with-glibc2.34 - Python version: 3.8.18 - `huggingface_hub` version: 0.21.3 - PyArrow version: 15.0.0 - Pandas version: 2.0.3 - `fsspec` version: 2024.2.0 ```

https://api.github.com/repos/huggingface/datasets/issues/6716/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6715

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6715/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6715/comments

https://api.github.com/repos/huggingface/datasets/issues/6715/events

https://github.com/huggingface/datasets/pull/6715

PR_kwDODunzps5oo36i

Fix sliced ConcatenationTable pickling with mixed schemas vertically

closed

MEMBER

A sliced + pickled ConcatenationTable could end up with a different schema than the original schema, if the slice only contains blocks with only a subset of the columns. This can lead to issues when saving datasets from a concatenation of datasets with mixed schemas Reported in https://discuss.huggingface.co/t/datasetdict-save-to-disk-with-num-proc-1-seems-to-hang-with-error/75595

https://api.github.com/repos/huggingface/datasets/issues/6715/timeline

https://api.github.com/repos/huggingface/datasets/issues/6714

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6714/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6714/comments

https://api.github.com/repos/huggingface/datasets/issues/6714/events

https://github.com/huggingface/datasets/pull/6714

PR_kwDODunzps5ooQd2

Expand no-code dataset info with datasets-server info

closed

CONTRIBUTOR

E.g., to have info about a dataset's number of examples for more informative TQDM bars.

https://api.github.com/repos/huggingface/datasets/issues/6714/timeline

https://api.github.com/repos/huggingface/datasets/issues/6713

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6713/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6713/comments

https://api.github.com/repos/huggingface/datasets/issues/6713/events

https://github.com/huggingface/datasets/pull/6713

PR_kwDODunzps5olmqh

Bump huggingface-hub lower version to 0.21.2

closed

MEMBER

This should fix the version compatibility issue when using `huggingface_hub` < 0.21.2 and latest fsspec (>=2023.12.0). See my comment: https://github.com/huggingface/datasets/pull/6687#issuecomment-1976493336 >> EDIT: the fix has been released in `huggingface_hub` 0.21.2 - I removed my commits that were using `huggingface_hub@main` > >Please note that people using `huggingface_hub` < 0.21.2 and latest `fsspec` will have issues when using `datasets`: >- https://github.com/huggingface/lighteval/actions/runs/8139147047/job/22241658122?pr=86 >- https://github.com/huggingface/lighteval/pull/84 CC: @clefourrier

https://api.github.com/repos/huggingface/datasets/issues/6713/timeline

https://api.github.com/repos/huggingface/datasets/issues/6712

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6712/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6712/comments

https://api.github.com/repos/huggingface/datasets/issues/6712/events

https://github.com/huggingface/datasets/pull/6712

PR_kwDODunzps5ok4VF

fix CastError pickling

closed

MEMBER

reported in https://discuss.huggingface.co/t/datasetdict-save-to-disk-with-num-proc-1-seems-to-hang-with-error/75595

https://api.github.com/repos/huggingface/datasets/issues/6712/timeline

https://api.github.com/repos/huggingface/datasets/issues/6711

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6711/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6711/comments

https://api.github.com/repos/huggingface/datasets/issues/6711/events

https://github.com/huggingface/datasets/pull/6711

PR_kwDODunzps5ohM1a

3x Faster Text Preprocessing

open

NONE

I was preparing some datasets for AI training and noticed that `datasets` by HuggingFace uses the conventional `open` mechanism to read the file and split it into chunks. I thought it can be significantly accelerated, and [started with a benchmark](https://gist.github.com/ashvardanian/55c2052e9f78b05b8d614aa90cb12347): ```sh $ pip install --upgrade --force-reinstall datasets $ python benchmark_huggingface_datasets.py xlsum.csv Generating train split: 1004598 examples [00:47, 21116.16 examples/s] Time taken to load the dataset: 48.66838526725769 seconds Time taken to chunk the dataset into parts of size 10000: 0.11466407775878906 seconds Total time taken: 48.78304934501648 seconds ``` For benchmarks I've used a [large CSV file with mixed UTF-8 content](https://github.com/ashvardanian/StringZilla/blob/main/CONTRIBUTING.md#benchmarking-datasets), most common in modern large-scale pre-training pipelines. I've later patched the `datasets` library to use `stringzilla`, which resulted in significantly lower memory consumption and in 2.9x throughput improvement on the AWS `r7iz` instances. That's using slow SSDs mounted over the network. Performance on local SSDs on something like a DGX-H100 should be even higher: ```sh $ pip install -e . $ python benchmark_huggingface_datasets.py xlsum.csv Generating train split: 1004598 examples [00:15, 64529.90 examples/s] Time taken to load the dataset: 16.45028805732727 seconds Time taken to chunk the dataset into parts of size 10000: 0.1291060447692871 seconds Total time taken: 16.579394102096558 seconds ``` I've already [pushed the patches to my fork](https://github.com/ashvardanian/datasets/tree/faster-text-parsers), and would love to contribute them to the upstream repository. --- All the tests pass, but they leave a couple of important questions open. The default Python `open(..., newline=None)` uses universal newlines, where `\n`, `\r`, and `\r\n` are all converted to `\n` on the fly. I am not sure if its a good idea for a general purpose dataset preparation pipeline? I can simulate the same behavior (which I don't yet do) for `"line"` splitter. Adjusting it for `"paragraph"`-splitter would be harder. Should we stick exactly to the old Pythonic behavior or stay closer to how C and other programming languages do that?

https://api.github.com/repos/huggingface/datasets/issues/6711/timeline

https://api.github.com/repos/huggingface/datasets/issues/6710

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6710/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6710/comments

https://api.github.com/repos/huggingface/datasets/issues/6710/events

https://github.com/huggingface/datasets/pull/6710

PR_kwDODunzps5oe4ov

Persist IterableDataset epoch in workers

open

MEMBER

Use shared memory for the IterableDataset epoch. This way calling `ds.set_epoch()` in the main process will update the epoch in the DataLoader workers as well. This is useful especially because the epoch is used to compute the `effective_seed` used for shuffling. I used torch's shared memory in case users want to send dataset copies without shared memory using pickle. I also find it easier to use than using `multiprocessing.shared_memory` than requires unlinking only in the main process, or `mp.Value` that is not picklable. close https://github.com/huggingface/datasets/issues/6673 cc @rwightman

https://api.github.com/repos/huggingface/datasets/issues/6710/timeline

https://api.github.com/repos/huggingface/datasets/issues/6709

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6709/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6709/comments

https://api.github.com/repos/huggingface/datasets/issues/6709/events

https://github.com/huggingface/datasets/pull/6709

PR_kwDODunzps5oc2Fg

set dev version

closed

MEMBER

https://api.github.com/repos/huggingface/datasets/issues/6709/timeline

https://api.github.com/repos/huggingface/datasets/issues/6708

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6708/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6708/comments

https://api.github.com/repos/huggingface/datasets/issues/6708/events

https://github.com/huggingface/datasets/pull/6708

PR_kwDODunzps5oczmi

Release: 2.18.0

closed

MEMBER

https://api.github.com/repos/huggingface/datasets/issues/6708/timeline

https://api.github.com/repos/huggingface/datasets/issues/6707

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6707/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6707/comments

https://api.github.com/repos/huggingface/datasets/issues/6707/events

https://github.com/huggingface/datasets/pull/6707

PR_kwDODunzps5obkhA

Silence ruff deprecation messages

closed

CONTRIBUTOR

https://api.github.com/repos/huggingface/datasets/issues/6707/timeline

https://api.github.com/repos/huggingface/datasets/issues/6706

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6706/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6706/comments

https://api.github.com/repos/huggingface/datasets/issues/6706/events

https://github.com/huggingface/datasets/pull/6706

PR_kwDODunzps5obgt-

Update ruff

closed

MEMBER

https://api.github.com/repos/huggingface/datasets/issues/6706/timeline

https://api.github.com/repos/huggingface/datasets/issues/6705

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6705/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6705/comments

https://api.github.com/repos/huggingface/datasets/issues/6705/events

https://github.com/huggingface/datasets/pull/6705

PR_kwDODunzps5obdbY

Fix data_files when passing data_dir

closed

MEMBER

This code should not return empty data files ```python from datasets import load_dataset_builder revision = "3d406e70bc21c3ca92a9a229b4c6fc3ed88279fd" b = load_dataset_builder("bigcode/the-stack-v2-dedup", data_dir="data/Dockerfile", revision=revision) print(b.config.data_files) ``` Previously it would return no data files because it would apply the YAML `data_files: data/**/train-*` pattern to this directory cc @anton-l

https://api.github.com/repos/huggingface/datasets/issues/6705/timeline

https://api.github.com/repos/huggingface/datasets/issues/6704

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6704/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6704/comments

https://api.github.com/repos/huggingface/datasets/issues/6704/events

https://github.com/huggingface/datasets/pull/6704

PR_kwDODunzps5obZyj

Improve default patterns resolution

closed

CONTRIBUTOR

Separate the default patterns that match directories from the ones matching files and ensure directories are checked first (reverts the change from https://github.com/huggingface/datasets/pull/6244, which merged these patterns). Also, ensure that the glob patterns do not overlap to avoid duplicates in the result. Additionally, replace `get_fs_token_paths` with `url_to_fs` to avoid [unnecessary glob calls](https://github.com/fsspec/filesystem_spec/blob/14dce8ca78f7aa509a20edb263bff83a7760c24d/fsspec/core.py#L655-L656). fix https://github.com/huggingface/datasets/issues/6259 fix https://github.com/huggingface/datasets/issues/6272

https://api.github.com/repos/huggingface/datasets/issues/6704/timeline

https://api.github.com/repos/huggingface/datasets/issues/6703

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6703/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6703/comments

https://api.github.com/repos/huggingface/datasets/issues/6703/events

https://github.com/huggingface/datasets/issues/6703

I_kwDODunzps6A8JWe

Unable to load dataset that was saved with `save_to_disk`

closed

NONE

### Describe the bug I get the following error message: You are trying to load a dataset that was saved using `save_to_disk`. Please use `load_from_disk` instead. ### Steps to reproduce the bug 1. Save a dataset with `save_to_disk` 2. Try to load it with `load_datasets` ### Expected behavior I am able to load the dataset again with `load_datasets` which most packages uses over `load_from_disk`. I want to have a workaround that allows me to create the same indexing that `push_to_hub` creates for you before using `save_to_disk` - how can that be achieved? ### Environment info datasets 2.17.1, python 3.10

https://api.github.com/repos/huggingface/datasets/issues/6703/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6702

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6702/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6702/comments

https://api.github.com/repos/huggingface/datasets/issues/6702/events

https://github.com/huggingface/datasets/issues/6702

I_kwDODunzps6A3JA0

Push samples to dataset on hub without having the dataset locally

closed

NONE

### Feature request Say I have the following code: ``` from datasets import Dataset import pandas as pd new_data = { "column_1": ["value1", "value2"], "column_2": ["value3", "value4"], } df_new = pd.DataFrame(new_data) dataset_new = Dataset.from_pandas(df_new) # add these samples to a remote dataset ``` It would be great to have a way to push dataset_new to a remote dataset that respects the same schema. This way one would not have to do the following: ``` from datasets import load_dataset dataset = load_dataset('username/dataset_name', use_auth_token='your_hf_token_here') updated_dataset = dataset['train'].concatenate(dataset_new) updated_dataset.push_to_hub('username/dataset_name', use_auth_token='your_hf_token_here') ``` ### Motivation No need to download the dataset. ### Your contribution Maybe this feature already exists, didnt see it though. I do not have the expertise to do this.

https://api.github.com/repos/huggingface/datasets/issues/6702/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6701

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6701/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6701/comments

https://api.github.com/repos/huggingface/datasets/issues/6701/events

https://github.com/huggingface/datasets/pull/6701

PR_kwDODunzps5oTfO_

Base parquet batch_size on parquet row group size

closed

MEMBER

This allows to stream datasets like [Major-TOM/Core-S2L2A](https://huggingface.co/datasets/Major-TOM/Core-S2L2A) which have row groups with few rows (one row is ~10MB). Previously the cold start would take a lot of time and OOM because it would download many row groups before yielding the first example. I tried on OpenOrca and imagenet-hard and it does't affect overall throughput. Even if the overall throughput doesn't change for datasets like imagenet-hard with big rows, note that it does create shorter and more frequent pauses to download the next row group. Though I find it fine because previously the pauses were less frequent but very long (downloading multiple row groups at a time)

https://api.github.com/repos/huggingface/datasets/issues/6701/timeline

https://api.github.com/repos/huggingface/datasets/issues/6700

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6700/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6700/comments

https://api.github.com/repos/huggingface/datasets/issues/6700/events

https://github.com/huggingface/datasets/issues/6700

I_kwDODunzps6ArcH-

remove_columns is not in-place but the doc shows it is in-place

closed

NONE

### Describe the bug The doc of `datasets` v2.17.0/v2.17.1 shows that `remove_columns` is in-place. [link](https://huggingface.co/docs/datasets/v2.17.1/en/package_reference/main_classes#datasets.DatasetDict.remove_columns) In the text classification example of transformers v4.38.1, the columns are not removed. https://github.com/huggingface/transformers/blob/a0857740c0e6127485c11476650314df3accc2b6/examples/pytorch/text-classification/run_classification.py#L421 ### Steps to reproduce the bug https://github.com/huggingface/transformers/blob/a0857740c0e6127485c11476650314df3accc2b6/examples/pytorch/text-classification/run_classification.py#L421 ### Expected behavior Actually remove the columns. ### Environment info 1. datasets v2.17.0 2. transformers v4.38.1

https://api.github.com/repos/huggingface/datasets/issues/6700/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6699

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6699/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6699/comments

https://api.github.com/repos/huggingface/datasets/issues/6699/events

https://github.com/huggingface/datasets/issues/6699

I_kwDODunzps6AosqV

`Dataset` unexpected changed dict data and may cause error

open

NONE

### Describe the bug Will unexpected get keys with `None` value in the parsed json dict. ### Steps to reproduce the bug ```jsonl test.jsonl {"id": 0, "indexs": {"-1": [0, 10]}} {"id": 1, "indexs": {"-1": [0, 10]}} ``` ```python dataset = Dataset.from_json('.test.jsonl') print(dataset[0]) ``` Result: ``` {'id': 0, 'indexs': {'-1': [...], '-2': None, '-3': None, '-4': None, '-5': None, '-6': None, '-7': None, '-8': None, '-9': None, ...}} ``` Those keys with `None` value will unexpected appear in the dict. ### Expected behavior Result should be ``` {'id': 0, 'indexs': {'-1': [0, 10]}} ``` ### Environment info - `datasets` version: 2.16.1 - Platform: Linux-6.5.0-14-generic-x86_64-with-glibc2.35 - Python version: 3.11.6 - `huggingface_hub` version: 0.20.2 - PyArrow version: 14.0.2 - Pandas version: 2.1.4 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6699/timeline

https://api.github.com/repos/huggingface/datasets/issues/6698

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6698/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6698/comments

https://api.github.com/repos/huggingface/datasets/issues/6698/events

https://github.com/huggingface/datasets/pull/6698

PR_kwDODunzps5oG6Xt

Faster `xlistdir`

closed

CONTRIBUTOR

Pass `detail=False` to the `fsspec` `listdir` to avoid unnecessarily fetching expensive metadata about the paths.

https://api.github.com/repos/huggingface/datasets/issues/6698/timeline

https://api.github.com/repos/huggingface/datasets/issues/6697

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6697/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6697/comments

https://api.github.com/repos/huggingface/datasets/issues/6697/events

https://github.com/huggingface/datasets/issues/6697

I_kwDODunzps6Alh_w

Unable to Load Dataset in Kaggle

closed

NONE

### Describe the bug Having installed the latest versions of transformers==4.38.1 and datasets==2.17.1 Unable to load the dataset in a kaggle notebook. Get this Error: ``` --------------------------------------------------------------------------- ValueError Traceback (most recent call last) Cell In[8], line 3 1 from datasets import load_dataset ----> 3 dataset = load_dataset("llm-blender/mix-instruct") File /opt/conda/lib/python3.10/site-packages/datasets/load.py:1664, in load_dataset(path, name, data_dir, data_files, split, cache_dir, features, download_config, download_mode, ignore_verifications, keep_in_memory, save_infos, revision, use_auth_token, task, streaming, **config_kwargs) 1661 ignore_verifications = ignore_verifications or save_infos 1663 # Create a dataset builder -> 1664 builder_instance = load_dataset_builder( 1665 path=path, 1666 name=name, 1667 data_dir=data_dir, 1668 data_files=data_files, 1669 cache_dir=cache_dir, 1670 features=features, 1671 download_config=download_config, 1672 download_mode=download_mode, 1673 revision=revision, 1674 use_auth_token=use_auth_token, 1675 **config_kwargs, 1676 ) 1678 # Return iterable dataset in case of streaming 1679 if streaming: File /opt/conda/lib/python3.10/site-packages/datasets/load.py:1490, in load_dataset_builder(path, name, data_dir, data_files, cache_dir, features, download_config, download_mode, revision, use_auth_token, **config_kwargs) 1488 download_config = download_config.copy() if download_config else DownloadConfig() 1489 download_config.use_auth_token = use_auth_token -> 1490 dataset_module = dataset_module_factory( 1491 path, 1492 revision=revision, 1493 download_config=download_config, 1494 download_mode=download_mode, 1495 data_dir=data_dir, 1496 data_files=data_files, 1497 ) 1499 # Get dataset builder class from the processing script 1500 builder_cls = import_main_class(dataset_module.module_path) File /opt/conda/lib/python3.10/site-packages/datasets/load.py:1242, in dataset_module_factory(path, revision, download_config, download_mode, force_local_path, dynamic_modules_path, data_dir, data_files, **download_kwargs) 1237 if isinstance(e1, FileNotFoundError): 1238 raise FileNotFoundError( 1239 f"Couldn't find a dataset script at {relative_to_absolute_path(combined_path)} or any data file in the same directory. " 1240 f"Couldn't find '{path}' on the Hugging Face Hub either: {type(e1).__name__}: {e1}" 1241 ) from None -> 1242 raise e1 from None 1243 else: 1244 raise FileNotFoundError( 1245 f"Couldn't find a dataset script at {relative_to_absolute_path(combined_path)} or any data file in the same directory." 1246 ) File /opt/conda/lib/python3.10/site-packages/datasets/load.py:1230, in dataset_module_factory(path, revision, download_config, download_mode, force_local_path, dynamic_modules_path, data_dir, data_files, **download_kwargs) 1215 return HubDatasetModuleFactoryWithScript( 1216 path, 1217 revision=revision, (...) 1220 dynamic_modules_path=dynamic_modules_path, 1221 ).get_module() 1222 else: 1223 return HubDatasetModuleFactoryWithoutScript( 1224 path, 1225 revision=revision, 1226 data_dir=data_dir, 1227 data_files=data_files, 1228 download_config=download_config, 1229 download_mode=download_mode, -> 1230 ).get_module() 1231 except Exception as e1: # noqa: all the attempts failed, before raising the error we should check if the module is already cached. 1232 try: File /opt/conda/lib/python3.10/site-packages/datasets/load.py:846, in HubDatasetModuleFactoryWithoutScript.get_module(self) 836 token = self.download_config.use_auth_token 837 hfh_dataset_info = HfApi(config.HF_ENDPOINT).dataset_info( 838 self.name, 839 revision=self.revision, 840 token=token, 841 timeout=100.0, 842 ) 843 patterns = ( 844 sanitize_patterns(self.data_files) 845 if self.data_files is not None --> 846 else get_patterns_in_dataset_repository(hfh_dataset_info) 847 ) 848 data_files = DataFilesDict.from_hf_repo( 849 patterns, 850 dataset_info=hfh_dataset_info, 851 allowed_extensions=ALL_ALLOWED_EXTENSIONS, 852 ) 853 infered_module_names = { 854 key: infer_module_for_data_files(data_files_list, use_auth_token=self.download_config.use_auth_token) 855 for key, data_files_list in data_files.items() 856 } File /opt/conda/lib/python3.10/site-packages/datasets/data_files.py:471, in get_patterns_in_dataset_repository(dataset_info) 469 resolver = partial(_resolve_single_pattern_in_dataset_repository, dataset_info) 470 try: --> 471 return _get_data_files_patterns(resolver) 472 except FileNotFoundError: 473 raise FileNotFoundError( 474 f"The dataset repository at '{dataset_info.id}' doesn't contain any data file." 475 ) from None File /opt/conda/lib/python3.10/site-packages/datasets/data_files.py:99, in _get_data_files_patterns(pattern_resolver) 97 try: 98 for pattern in patterns: ---> 99 data_files = pattern_resolver(pattern) 100 if len(data_files) > 0: 101 non_empty_splits.append(split) File /opt/conda/lib/python3.10/site-packages/datasets/data_files.py:303, in _resolve_single_pattern_in_dataset_repository(dataset_info, pattern, allowed_extensions) 301 data_files_ignore = FILES_TO_IGNORE 302 fs = HfFileSystem(repo_info=dataset_info) --> 303 glob_iter = [PurePath(filepath) for filepath in fs.glob(PurePath(pattern).as_posix()) if fs.isfile(filepath)] 304 matched_paths = [ 305 filepath 306 for filepath in glob_iter 307 if filepath.name not in data_files_ignore and not filepath.name.startswith(".") 308 ] 309 if allowed_extensions is not None: File /opt/conda/lib/python3.10/site-packages/fsspec/spec.py:606, in AbstractFileSystem.glob(self, path, maxdepth, **kwargs) 602 depth = None 604 allpaths = self.find(root, maxdepth=depth, withdirs=True, detail=True, **kwargs) --> 606 pattern = glob_translate(path + ("/" if ends_with_sep else "")) 607 pattern = re.compile(pattern) 609 out = { 610 p: info 611 for p, info in sorted(allpaths.items()) (...) 618 ) 619 } File /opt/conda/lib/python3.10/site-packages/fsspec/utils.py:734, in glob_translate(pat) 732 continue 733 elif "**" in part: --> 734 raise ValueError( 735 "Invalid pattern: '**' can only be an entire path component" 736 ) 737 if part: 738 results.extend(_translate(part, f"{not_sep}*", not_sep)) ValueError: Invalid pattern: '**' can only be an entire path component ``` ``` After loading this dataset ### Steps to reproduce the bug ``` from datasets import load_dataset dataset = load_dataset("llm-blender/mix-instruct") ``` ### Expected behavior The dataset should load with desired split. ### Environment info - `datasets` version: 2.17.1 - Platform: Linux-5.15.133+-x86_64-with-glibc2.31 - Python version: 3.10.13 - `huggingface_hub` version: 0.20.3 - PyArrow version: 15.0.0 - Pandas version: 2.2.0 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6697/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6696

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6696/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6696/comments

https://api.github.com/repos/huggingface/datasets/issues/6696/events

https://github.com/huggingface/datasets/pull/6696

PR_kwDODunzps5n6ipH

Make JSON builder support an array of strings

closed

MEMBER

Support JSON file with an array of strings. Fix #6695.

https://api.github.com/repos/huggingface/datasets/issues/6696/timeline

https://api.github.com/repos/huggingface/datasets/issues/6695

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6695/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6695/comments

https://api.github.com/repos/huggingface/datasets/issues/6695/events

https://github.com/huggingface/datasets/issues/6695

I_kwDODunzps6AZJV1

Support JSON file with an array of strings

closed

MEMBER

Support loading a dataset from a JSON file with an array of strings. See: https://huggingface.co/datasets/CausalLM/Refined-Anime-Text/discussions/1

https://api.github.com/repos/huggingface/datasets/issues/6695/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6694

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6694/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6694/comments

https://api.github.com/repos/huggingface/datasets/issues/6694/events

https://github.com/huggingface/datasets/pull/6694

PR_kwDODunzps5n23Jz

__add__ for Dataset, IterableDataset

open

NONE

It's too cumbersome to write this command every time we perform a dataset merging operation. ```pythonfrom datasets import concatenate_datasets``` We have added a simple `__add__` magic method to each class using `concatenate_datasets.` ```python from datasets import load_dataset bookcorpus = load_dataset("bookcorpus", split="train") wiki = load_dataset("wikimedia/wikipedia", "20231101.ab", split="train") wiki = wiki.remove_columns([col for col in wiki.column_names if col != "text"]) # only keep the 'text' column bookcorpus + wiki #Dataset({ # features: ['text'], # num_rows: 74004228 #}) #Dataset({ # features: ['text'], # num_rows: 6152 #}) #Dataset({ # features: ['text'], # num_rows: 74010380 #}) ```

https://api.github.com/repos/huggingface/datasets/issues/6694/timeline

https://api.github.com/repos/huggingface/datasets/issues/6693

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6693/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6693/comments

https://api.github.com/repos/huggingface/datasets/issues/6693/events

https://github.com/huggingface/datasets/pull/6693

PR_kwDODunzps5n2ObO

Update the print message for chunked_dataset in process.mdx

closed

CONTRIBUTOR

Update documentation to align with `Dataset.__repr__` change after #423

https://api.github.com/repos/huggingface/datasets/issues/6693/timeline

https://api.github.com/repos/huggingface/datasets/issues/6692

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6692/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6692/comments

https://api.github.com/repos/huggingface/datasets/issues/6692/events

https://github.com/huggingface/datasets/pull/6692

PR_kwDODunzps5n0XN1

Enhancement: Enable loading TSV files in load_dataset()

closed

NONE

Fix #6691

https://api.github.com/repos/huggingface/datasets/issues/6692/timeline

https://api.github.com/repos/huggingface/datasets/issues/6691

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6691/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6691/comments

https://api.github.com/repos/huggingface/datasets/issues/6691/events

https://github.com/huggingface/datasets/issues/6691

I_kwDODunzps6ARvWZ

load_dataset() does not support tsv

closed

NONE

### Feature request the load_dataset() for local functions support file types like csv, json etc but not of type tsv (tab separated values). ### Motivation cant easily load files of type tsv, have to convert them to another type like csv then load ### Your contribution Can try by raising a PR with a little help, currently went through the code but didn't fully understand

https://api.github.com/repos/huggingface/datasets/issues/6691/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6690

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6690/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6690/comments

https://api.github.com/repos/huggingface/datasets/issues/6690/events

https://github.com/huggingface/datasets/issues/6690

I_kwDODunzps6AMprB

Add function to convert a script-dataset to Parquet

closed

MEMBER

Add function to convert a script-dataset to Parquet and push it to the Hub, analogously to the Space: "Convert a Hugging Face dataset to Parquet"

https://api.github.com/repos/huggingface/datasets/issues/6690/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6689

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6689/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6689/comments

https://api.github.com/repos/huggingface/datasets/issues/6689/events

https://github.com/huggingface/datasets/issues/6689

I_kwDODunzps6AIAFb

.load_dataset() method defaults to zstandard

closed

NONE

### Describe the bug Regardless of what method I use, datasets defaults to zstandard for unpacking my datasets. This is poor behavior, because not only is zstandard not a dependency in the huggingface package (and therefore, your dataset loading will be interrupted while it asks you to install the package), but it happens on datasets that are uploaded in json format too, meaning the dataset loader will attempt to convert the data to a zstandard compatible format, and THEN try to unpackage it. My 4tb drive runs out of room when using zstandard on slimpajama. It loads fine on 1.5tb when using json, however I lack the understanding of the "magic numbers" system used to select the unpackaging algorithm, so I can't push a change myself. Commenting out this line, in "/datasets/utils/extract.py" fixes the issue, and causes SlimPajama to properly extract using rational amounts of storage, however it completely disables zstandard, which is probably undesirable behavior. Someone with an understanding of the "magic numbers" system should probably take a pass over this issue. ``` class Extractor: # Put zip file to the last, b/c it is possible wrongly detected as zip (I guess it means: as tar or gzip) extractors: Dict[str, Type[BaseExtractor]] = { "tar": TarExtractor, "gzip": GzipExtractor, "zip": ZipExtractor, "xz": XzExtractor, #"zstd": ZstdExtractor, # This line needs to go, in order for datasets to work w/o non-dependent packages "rar": RarExtractor, "bz2": Bzip2Extractor, "7z": SevenZipExtractor, # <Added version="2.4.0"/> "lz4": Lz4Extractor, # <Added version="2.4.0"/> } ``` ### Steps to reproduce the bug ''' from datasaets import load_dataset load_dataset(path="/cerebras/SlimPajama-627B") ''' This alone should trigger the error on any system that does not have zstandard pip installed. ### Expected behavior This repository (which is encoded in json format, not zstandard) should check whether zstandard is installed before defaulting to it. Additionally, using zstandard should not use more than 3x the required space that other extraction mechanisms use. ### Environment info - `datasets` version: 2.17.1 - Platform: Linux-6.5.0-18-generic-x86_64-with-glibc2.35 - Python version: 3.12.0 - `huggingface_hub` version: 0.20.3 - PyArrow version: 15.0.0 - Pandas version: 2.2.0 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6689/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6688

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6688/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6688/comments

https://api.github.com/repos/huggingface/datasets/issues/6688/events

https://github.com/huggingface/datasets/issues/6688

I_kwDODunzps6AES9D

Tensor type (e.g. from `return_tensors`) ignored in map

open

NONE

### Describe the bug I don't know if it is a bug or an expected behavior, but the tensor type seems to be ignored after applying map. For example, mapping over to tokenize text with a transformers' tokenizer always returns lists and it ignore the `return_tensors` argument. If this is an expected behaviour (e.g., for caching/Arrow compatibility/etc.) it should be clearly documented. For example, current documentation (see [here](https://huggingface.co/docs/datasets/v2.17.1/en/nlp_process#map)) clearly state to "set `return_tensors="np"` when you tokenize your text" to have Numpy arrays. ### Steps to reproduce the bug ```py # %%% import datasets import numpy as np import tensorflow as tf import torch from transformers import AutoTokenizer # %% ds = datasets.load_dataset("cnn_dailymail", "1.0.0", split="train[:1%]") tokenizer = AutoTokenizer.from_pretrained("bert-base-cased") #%% for return_tensors in [None, "np", "pt", "tf", "jax"]: print(f"********** no map, return_tensors={return_tensors} **********") _ds = tokenizer(ds["article"], return_tensors=return_tensors, truncation=True, padding=True) print('Type <input_ids>:', type(_ds["input_ids"])) # %% for return_tensors in [None, "np", "pt", "tf", "jax"]: print(f"********** map, return_tensors={return_tensors} **********") _ds = ds.map( lambda examples: tokenizer(examples["article"], return_tensors=return_tensors, truncation=True, padding=True), batched=True, remove_columns=["article"], ) print('Type <input_ids>:', type(_ds[0]["input_ids"])) ``` ### Expected behavior The output from the script above. I would expect the second half to be the same. ``` ********** no map, return_tensors=None ********** Type <input_ids>: <class 'list'> ********** no map, return_tensors=np ********** Type <input_ids>: <class 'numpy.ndarray'> ********** no map, return_tensors=pt ********** Type <input_ids>: <class 'torch.Tensor'> ********** no map, return_tensors=tf ********** Type <input_ids>: <class 'tensorflow.python.framework.ops.EagerTensor'> ********** no map, return_tensors=jax ********** Type <input_ids>: <class 'jaxlib.xla_extension.ArrayImpl'> ********** map, return_tensors=None ********** Type <input_ids>: <class 'list'> ********** map, return_tensors=np ********** Type <input_ids>: <class 'list'> ********** map, return_tensors=pt ********** Type <input_ids>: <class 'list'> ********** map, return_tensors=tf ********** Type <input_ids>: <class 'list'> ********** map, return_tensors=jax ********** Type <input_ids>: <class 'list'> ``` ### Environment info - `datasets` version: 2.17.1 - Platform: Redacted (linux) - Python version: 3.10.12 - `huggingface_hub` version: 0.20.3 - PyArrow version: 15.0.0 - Pandas version: 2.1.3 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6688/timeline

https://api.github.com/repos/huggingface/datasets/issues/6687

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6687/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6687/comments

https://api.github.com/repos/huggingface/datasets/issues/6687/events

https://github.com/huggingface/datasets/pull/6687

PR_kwDODunzps5nnqBB

fsspec: support fsspec>=2023.12.0 glob changes

closed

CONTRIBUTOR

- adds support for the `fs.glob` changes introduced in `fsspec==2023.12.0` and unpins the current upper bound Should close #6644 Should close #6645 The `test_data_files` glob/pattern tests pass for me in: - `fsspec==2023.10.0` (the pinned max version in datasets `main`) - `fsspec==2023.12.0` (#6644) - `fsspec==2024.2.0` (#6645)

https://api.github.com/repos/huggingface/datasets/issues/6687/timeline

https://api.github.com/repos/huggingface/datasets/issues/6686

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6686/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6686/comments

https://api.github.com/repos/huggingface/datasets/issues/6686/events

https://github.com/huggingface/datasets/issues/6686

I_kwDODunzps6ABMCf

Question: Is there any way for uploading a large image dataset?

open

NONE

I am uploading an image dataset like this: ``` dataset = load_dataset( "json", data_files={"train": "data/custom_dataset/train.json", "validation": "data/custom_dataset/val.json"}, ) dataset = dataset.cast_column("images", Sequence(Image())) dataset.push_to_hub("StanfordAIMI/custom_dataset", max_shard_size="1GB") ``` where it takes a long time in the `Map` process. Do you think I can use multi-processing to map all the image data to the memory first? For the `Map()` function, I can set `num_proc`. But for `push_to_hub` and `cast_column`, I can not find it. Thanks in advance! Best,

https://api.github.com/repos/huggingface/datasets/issues/6686/timeline

https://api.github.com/repos/huggingface/datasets/issues/6685

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6685/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6685/comments

https://api.github.com/repos/huggingface/datasets/issues/6685/events

https://github.com/huggingface/datasets/pull/6685

PR_kwDODunzps5ndZQa

Updated Quickstart Notebook link

closed

CONTRIBUTOR

Fixed Quickstart Notebook Link in the [Overview notebook](https://github.com/huggingface/datasets/blob/main/notebooks/Overview.ipynb)

https://api.github.com/repos/huggingface/datasets/issues/6685/timeline

https://api.github.com/repos/huggingface/datasets/issues/6684

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6684/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6684/comments

https://api.github.com/repos/huggingface/datasets/issues/6684/events

https://github.com/huggingface/datasets/pull/6684

PR_kwDODunzps5nYUIf

Improve error message for gated datasets on load

closed

MEMBER

Internal Slack discussion: https://huggingface.slack.com/archives/C02V51Q3800/p1708424971135029

https://api.github.com/repos/huggingface/datasets/issues/6684/timeline

https://api.github.com/repos/huggingface/datasets/issues/6683

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6683/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6683/comments

https://api.github.com/repos/huggingface/datasets/issues/6683/events

https://github.com/huggingface/datasets/pull/6683

PR_kwDODunzps5nTxGu

Fix imagefolder dataset url

closed

CONTRIBUTOR

https://api.github.com/repos/huggingface/datasets/issues/6683/timeline

https://api.github.com/repos/huggingface/datasets/issues/6682

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6682/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6682/comments

https://api.github.com/repos/huggingface/datasets/issues/6682/events

https://github.com/huggingface/datasets/pull/6682

PR_kwDODunzps5nRME6

Update GitHub Actions to Node 20

closed

MEMBER

Update GitHub Actions to Node 20. Fix #6679.

https://api.github.com/repos/huggingface/datasets/issues/6682/timeline

https://api.github.com/repos/huggingface/datasets/issues/6681

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6681/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6681/comments

https://api.github.com/repos/huggingface/datasets/issues/6681/events

https://github.com/huggingface/datasets/pull/6681

PR_kwDODunzps5nRItQ

Update release instructions

closed

MEMBER

Update release instructions.

https://api.github.com/repos/huggingface/datasets/issues/6681/timeline

https://api.github.com/repos/huggingface/datasets/issues/6680

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6680/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6680/comments

https://api.github.com/repos/huggingface/datasets/issues/6680/events

https://github.com/huggingface/datasets/pull/6680

PR_kwDODunzps5nRHcz

Set dev version

closed

MEMBER

https://api.github.com/repos/huggingface/datasets/issues/6680/timeline

https://api.github.com/repos/huggingface/datasets/issues/6679

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6679/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6679/comments

https://api.github.com/repos/huggingface/datasets/issues/6679/events

https://github.com/huggingface/datasets/issues/6679

I_kwDODunzps5_q5-9

Node.js 16 GitHub Actions are deprecated

closed

MEMBER

`Node.js` 16 GitHub Actions are deprecated. See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ We should update them to Node 20. See warnings in our CI, e.g.: https://github.com/huggingface/datasets/actions/runs/7957295009?pr=6678 > Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

https://api.github.com/repos/huggingface/datasets/issues/6679/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6678

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6678/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6678/comments

https://api.github.com/repos/huggingface/datasets/issues/6678/events

https://github.com/huggingface/datasets/pull/6678

PR_kwDODunzps5nQ2ZO

Release: 2.17.1

closed

MEMBER

https://api.github.com/repos/huggingface/datasets/issues/6678/timeline

https://api.github.com/repos/huggingface/datasets/issues/6677

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6677/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6677/comments

https://api.github.com/repos/huggingface/datasets/issues/6677/events

https://github.com/huggingface/datasets/pull/6677

PR_kwDODunzps5nOmo_

Pass through information about location of cache directory.

closed

CONTRIBUTOR

If cache directory is set, information is not passed through. Pass download config in as an arg too.

https://api.github.com/repos/huggingface/datasets/issues/6677/timeline

https://api.github.com/repos/huggingface/datasets/issues/6676

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6676/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6676/comments

https://api.github.com/repos/huggingface/datasets/issues/6676/events

https://github.com/huggingface/datasets/issues/6676

I_kwDODunzps5_l7Sr

Can't Read List of JSON Files Properly

open

NONE

### Describe the bug Trying to read a bunch of JSON files into Dataset class but default approach doesn't work. I don't get why it works when I read it one by one but not when I pass as a list :man_shrugging: The code fails with ``` ArrowInvalid: JSON parse error: Invalid value. in row 0 UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 0: invalid start byte DatasetGenerationError: An error occurred while generating the dataset ``` ### Steps to reproduce the bug This doesn't work ``` from datasets import Dataset # dir contains 100 json files. Dataset.from_json("/PUT SOME PATH HERE/*") ``` This works: ``` from datasets import concatenate_datasets ls_ds = [] for file in list_of_json_files: ls_ds.append(Dataset.from_json(file)) ds = concatenate_datasets(ls_ds) ``` ### Expected behavior I expect this to read json files properly as error is not clear ### Environment info - `datasets` version: 2.17.0 - Platform: Linux-6.5.0-15-generic-x86_64-with-glibc2.35 - Python version: 3.10.13 - `huggingface_hub` version: 0.20.2 - PyArrow version: 15.0.0 - Pandas version: 2.2.0 - `fsspec` version: 2023.10.0

https://api.github.com/repos/huggingface/datasets/issues/6676/timeline

https://api.github.com/repos/huggingface/datasets/issues/6675

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6675/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6675/comments

https://api.github.com/repos/huggingface/datasets/issues/6675/events

https://github.com/huggingface/datasets/issues/6675

I_kwDODunzps5_iFI9

Allow image model (color conversion) to be specified as part of datasets Image() decode

closed

NONE

### Feature request Typical torchvision / torch Datasets in image applications apply color conversion in the Dataset portion of the code as part of image decode, separately from the image transform stack. This is true for PIL.Image where convert is usually called in dataset, for native torchvision https://pytorch.org/vision/main/generated/torchvision.io.decode_jpeg.html, and similarly in tensorflow.data pipelines decode_jpeg or https://www.tensorflow.org/api_docs/python/tf/io/decode_and_crop_jpeg have a channels arg that allows controlling the image mode in the decode step. datasets currently requires this pattern (from [examples](https://huggingface.co/docs/datasets/main/en/image_process)): ``` from torchvision.transforms import Compose, ColorJitter, ToTensor jitter = Compose( [ ColorJitter(brightness=0.25, contrast=0.25, saturation=0.25, hue=0.7), ToTensor(), ] ) def transforms(examples): examples["pixel_values"] = [jitter(image.convert("RGB")) for image in examples["image"]] return examples ``` ### Motivation It would be nice to be able to handle `image.convert("RGB")` (or other modes) in the decode step, before applying torchvision transforms, this would reduce differences in code when handling pipelines that can handle torchvision, webdatset, or hf datasets with fewer code differences and without needing to handle image mode argument passing in two different stages of the pipelines... ### Your contribution Can do a PR with guidance on how mode should be passed / set on the dataset.

https://api.github.com/repos/huggingface/datasets/issues/6675/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6674

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6674/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6674/comments

https://api.github.com/repos/huggingface/datasets/issues/6674/events

https://github.com/huggingface/datasets/issues/6674

I_kwDODunzps5_h6M4

Depprcated Overview.ipynb Link to new Quickstart Notebook invalid

closed

CONTRIBUTOR

### Describe the bug For the dreprecated notebook found [here](https://github.com/huggingface/datasets/blob/main/notebooks/Overview.ipynb). The link to the new notebook is broken. ### Steps to reproduce the bug Click the [Quickstart notebook](https://github.com/huggingface/notebooks/blob/main/datasets_doc/quickstart.ipynb) link in the notebook. ### Expected behavior I believe is it suposed to link [here](https://github.com/huggingface/notebooks/blob/main/datasets_doc/en/quickstart.ipynb). That is mentioned in the readme. ### Environment info Colab

https://api.github.com/repos/huggingface/datasets/issues/6674/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6673

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6673/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6673/comments

https://api.github.com/repos/huggingface/datasets/issues/6673/events

https://github.com/huggingface/datasets/issues/6673

I_kwDODunzps5_hocL

IterableDataset `set_epoch` is ignored when DataLoader `persistent_workers=True`

open

NONE

### Describe the bug When persistent workers are enabled, the epoch that's set via the IterableDataset instance held by the training process is ignored by the workers as they are disconnected across processes. PyTorch samplers for non-iterable datasets have a mechanism to sync this, datasets.IterableDataset does not. In my own use of IterableDatasets I usually track the epoch count which crosses process boundaries in a multiprocessing.Value ### Steps to reproduce the bug Use a streaming dataset (Iterable) w/ the recommended pattern below and `persistent_workers=True` in the torch DataLoader. ``` for epoch in range(epochs): shuffled_dataset.set_epoch(epoch) for example in shuffled_dataset: ... ``` ### Expected behavior When the canonical bit of code above is used with `num_workers > 0` and `persistent_workers=True`, the epoch set via `set_epoch()` is propagated to the IterableDataset instances in the worker processes ### Environment info N/A

https://api.github.com/repos/huggingface/datasets/issues/6673/timeline

https://api.github.com/repos/huggingface/datasets/issues/6672

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6672/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6672/comments

https://api.github.com/repos/huggingface/datasets/issues/6672/events

https://github.com/huggingface/datasets/pull/6672

PR_kwDODunzps5nGAlw

Remove deprecated verbose parameter from CSV builder

closed

MEMBER

Remove deprecated `verbose` parameter from CSV builder. Note that the `verbose` parameter is deprecated since pandas 2.2.0. See: - https://github.com/pandas-dev/pandas/pull/56556 - https://github.com/pandas-dev/pandas/pull/57450 Fix #6671.

https://api.github.com/repos/huggingface/datasets/issues/6672/timeline

https://api.github.com/repos/huggingface/datasets/issues/6671

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6671/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6671/comments

https://api.github.com/repos/huggingface/datasets/issues/6671/events

https://github.com/huggingface/datasets/issues/6671

I_kwDODunzps5_emW-

CSV builder raises deprecation warning on verbose parameter

closed

MEMBER

CSV builder raises a deprecation warning on `verbose` parameter: ``` FutureWarning: The 'verbose' keyword in pd.read_csv is deprecated and will be removed in a future version. ``` See: - https://github.com/pandas-dev/pandas/pull/56556 - https://github.com/pandas-dev/pandas/pull/57450

https://api.github.com/repos/huggingface/datasets/issues/6671/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6670

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6670/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6670/comments

https://api.github.com/repos/huggingface/datasets/issues/6670/events

https://github.com/huggingface/datasets/issues/6670

I_kwDODunzps5_dPte

ValueError

closed

NONE

### Describe the bug ValueError Traceback (most recent call last) [<ipython-input-11-9b99bc80ec23>](https://localhost:8080/#) in <cell line: 11>() 9 import numpy as np 10 import matplotlib.pyplot as plt ---> 11 from datasets import DatasetDict, Dataset 12 from transformers import AutoTokenizer, AutoModelForSequenceClassification 13 from transformers import Trainer, TrainingArguments 5 frames [/usr/local/lib/python3.10/dist-packages/datasets/__init__.py](https://localhost:8080/#) in <module> 16 __version__ = "2.17.0" 17 ---> 18 from .arrow_dataset import Dataset 19 from .arrow_reader import ReadInstruction 20 from .builder import ArrowBasedBuilder, BeamBasedBuilder, BuilderConfig, DatasetBuilder, GeneratorBasedBuilder [/usr/local/lib/python3.10/dist-packages/datasets/arrow_dataset.py](https://localhost:8080/#) in <module> 65 66 from . import config ---> 67 from .arrow_reader import ArrowReader 68 from .arrow_writer import ArrowWriter, OptimizedTypedSequence 69 from .data_files import sanitize_patterns [/usr/local/lib/python3.10/dist-packages/datasets/arrow_reader.py](https://localhost:8080/#) in <module> 27 28 import pyarrow as pa ---> 29 import pyarrow.parquet as pq 30 from tqdm.contrib.concurrent import thread_map 31 [/usr/local/lib/python3.10/dist-packages/pyarrow/parquet/__init__.py](https://localhost:8080/#) in <module> 18 # flake8: noqa 19 ---> 20 from .core import * [/usr/local/lib/python3.10/dist-packages/pyarrow/parquet/core.py](https://localhost:8080/#) in <module> 34 import pyarrow as pa 35 import pyarrow.lib as lib ---> 36 import pyarrow._parquet as _parquet 37 38 from pyarrow._parquet import (ParquetReader, Statistics, # noqa /usr/local/lib/python3.10/dist-packages/pyarrow/_parquet.pyx in init pyarrow._parquet() ValueError: pyarrow.lib.IpcWriteOptions size changed, may indicate binary incompatibility. Expected 88 from C header, got 72 from PyObject ### Steps to reproduce the bug ValueError: pyarrow.lib.IpcWriteOptions size changed, may indicate binary incompatibility. Expected 88 from C header, got 72 from PyObject ### Expected behavior Resolve the binary incompatibility ### Environment info Google Colab Note book

https://api.github.com/repos/huggingface/datasets/issues/6670/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6669

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6669/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6669/comments

https://api.github.com/repos/huggingface/datasets/issues/6669/events

https://github.com/huggingface/datasets/issues/6669

I_kwDODunzps5_dDbm

attribute error when writing trainer.train()

closed

NONE

### Describe the bug AttributeError Traceback (most recent call last) Cell In[39], line 2 1 # Start the training process ----> 2 trainer.train() File /opt/conda/lib/python3.10/site-packages/transformers/trainer.py:1539, in Trainer.train(self, resume_from_checkpoint, trial, ignore_keys_for_eval, **kwargs) 1537 hf_hub_utils.enable_progress_bars() 1538 else: -> 1539 return inner_training_loop( 1540 args=args, 1541 resume_from_checkpoint=resume_from_checkpoint, 1542 trial=trial, 1543 ignore_keys_for_eval=ignore_keys_for_eval, 1544 ) File /opt/conda/lib/python3.10/site-packages/transformers/trainer.py:1836, in Trainer._inner_training_loop(self, batch_size, args, resume_from_checkpoint, trial, ignore_keys_for_eval) 1833 rng_to_sync = True 1835 step = -1 -> 1836 for step, inputs in enumerate(epoch_iterator): 1837 total_batched_samples += 1 1839 if self.args.include_num_input_tokens_seen: File /opt/conda/lib/python3.10/site-packages/accelerate/data_loader.py:451, in DataLoaderShard.__iter__(self) 449 # We iterate one batch ahead to check when we are at the end 450 try: --> 451 current_batch = next(dataloader_iter) 452 except StopIteration: 453 yield File /opt/conda/lib/python3.10/site-packages/torch/utils/data/dataloader.py:630, in _BaseDataLoaderIter.__next__(self) 627 if self._sampler_iter is None: 628 # TODO([https://github.com/pytorch/pytorch/issues/76750)](https://github.com/pytorch/pytorch/issues/76750)%3C/span%3E) 629 self._reset() # type: ignore[call-arg] --> 630 data = self._next_data() 631 self._num_yielded += 1 632 if self._dataset_kind == _DatasetKind.Iterable and \ 633 self._IterableDataset_len_called is not None and \ 634 self._num_yielded > self._IterableDataset_len_called: File /opt/conda/lib/python3.10/site-packages/torch/utils/data/dataloader.py:674, in _SingleProcessDataLoaderIter._next_data(self) 672 def _next_data(self): 673 index = self._next_index() # may raise StopIteration --> 674 data = self._dataset_fetcher.fetch(index) # may raise StopIteration 675 if self._pin_memory: 676 data = _utils.pin_memory.pin_memory(data, self._pin_memory_device) File /opt/conda/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py:51, in _MapDatasetFetcher.fetch(self, possibly_batched_index) 49 data = self.dataset.__getitems__(possibly_batched_index) 50 else: ---> 51 data = [self.dataset[idx] for idx in possibly_batched_index] 52 else: 53 data = self.dataset[possibly_batched_index] File /opt/conda/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py:51, in <listcomp>(.0) 49 data = self.dataset.__getitems__(possibly_batched_index) 50 else: ---> 51 data = [self.dataset[idx] for idx in possibly_batched_index] 52 else: 53 data = self.dataset[possibly_batched_index] File /opt/conda/lib/python3.10/site-packages/datasets/arrow_dataset.py:1764, in Dataset.__getitem__(self, key) 1762 def __getitem__(self, key): # noqa: F811 1763 """Can be used to index columns (by string names) or rows (by integer index or iterable of indices or bools).""" -> 1764 return self._getitem( 1765 key, 1766 ) File /opt/conda/lib/python3.10/site-packages/datasets/arrow_dataset.py:1749, in Dataset._getitem(self, key, decoded, **kwargs) 1747 formatter = get_formatter(format_type, features=self.features, decoded=decoded, **format_kwargs) 1748 pa_subtable = query_table(self._data, key, indices=self._indices if self._indices is not None else None) -> 1749 formatted_output = format_table( 1750 pa_subtable, key, formatter=formatter, format_columns=format_columns, output_all_columns=output_all_columns 1751 ) 1752 return formatted_output File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:540, in format_table(table, key, formatter, format_columns, output_all_columns) 538 else: 539 pa_table_to_format = pa_table.drop(col for col in pa_table.column_names if col not in format_columns) --> 540 formatted_output = formatter(pa_table_to_format, query_type=query_type) 541 if output_all_columns: 542 if isinstance(formatted_output, MutableMapping): File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:281, in Formatter.__call__(self, pa_table, query_type) 279 def __call__(self, pa_table: pa.Table, query_type: str) -> Union[RowFormat, ColumnFormat, BatchFormat]: 280 if query_type == "row": --> 281 return self.format_row(pa_table) 282 elif query_type == "column": 283 return self.format_column(pa_table) File /opt/conda/lib/python3.10/site-packages/datasets/formatting/torch_formatter.py:57, in TorchFormatter.format_row(self, pa_table) 56 def format_row(self, pa_table: pa.Table) -> dict: ---> 57 row = self.numpy_arrow_extractor().extract_row(pa_table) 58 return self.recursive_tensorize(row) File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:154, in NumpyArrowExtractor.extract_row(self, pa_table) 153 def extract_row(self, pa_table: pa.Table) -> dict: --> 154 return _unnest(self.extract_batch(pa_table)) File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:160, in NumpyArrowExtractor.extract_batch(self, pa_table) 159 def extract_batch(self, pa_table: pa.Table) -> dict: --> 160 return {col: self._arrow_array_to_numpy(pa_table[col]) for col in pa_table.column_names} File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:160, in <dictcomp>(.0) 159 def extract_batch(self, pa_table: pa.Table) -> dict: --> 160 return {col: self._arrow_array_to_numpy(pa_table[col]) for col in pa_table.column_names} File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:196, in NumpyArrowExtractor._arrow_array_to_numpy(self, pa_array) 194 array: List = pa_array.to_numpy(zero_copy_only=zero_copy_only).tolist() 195 if len(array) > 0: --> 196 if any( 197 (isinstance(x, np.ndarray) and (x.dtype == np.object or x.shape != array[0].shape)) 198 or (isinstance(x, float) and np.isnan(x)) 199 for x in array 200 ): 201 return np.array(array, copy=False, **{**self.np_array_kwargs, "dtype": np.object}) 202 return np.array(array, copy=False, **self.np_array_kwargs) File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:197, in <genexpr>(.0) 194 array: List = pa_array.to_numpy(zero_copy_only=zero_copy_only).tolist() 195 if len(array) > 0: 196 if any( --> 197 (isinstance(x, np.ndarray) and (x.dtype == np.object or x.shape != array[0].shape)) 198 or (isinstance(x, float) and np.isnan(x)) 199 for x in array 200 ): 201 return np.array(array, copy=False, **{**self.np_array_kwargs, "dtype": np.object}) 202 return np.array(array, copy=False, **self.np_array_kwargs) File /opt/conda/lib/python3.10/site-packages/numpy/__init__.py:324, in __getattr__(attr) 319 warnings.warn( 320 f"In the future `np.{attr}` will be defined as the " 321 "corresponding NumPy scalar.", FutureWarning, stacklevel=2) 323 if attr in __former_attrs__: --> 324 raise AttributeError(__former_attrs__[attr]) 326 if attr == 'testing': 327 import numpy.testing as testing AttributeError: module 'numpy' has no attribute 'object'. `np.object` was a deprecated alias for the builtin `object`. To avoid this error in existing code, use `object` by itself. Doing this will not modify any behavior and is safe. The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecationsAttributeError Traceback (most recent call last) Cell In[39], line 2 1 # Start the training process ----> 2 trainer.train() File /opt/conda/lib/python3.10/site-packages/transformers/trainer.py:1539, in Trainer.train(self, resume_from_checkpoint, trial, ignore_keys_for_eval, **kwargs) 1537 hf_hub_utils.enable_progress_bars() 1538 else: -> 1539 return inner_training_loop( 1540 args=args, 1541 resume_from_checkpoint=resume_from_checkpoint, 1542 trial=trial, 1543 ignore_keys_for_eval=ignore_keys_for_eval, 1544 ) File /opt/conda/lib/python3.10/site-packages/transformers/trainer.py:1836, in Trainer._inner_training_loop(self, batch_size, args, resume_from_checkpoint, trial, ignore_keys_for_eval) 1833 rng_to_sync = True 1835 step = -1 -> 1836 for step, inputs in enumerate(epoch_iterator): 1837 total_batched_samples += 1 1839 if self.args.include_num_input_tokens_seen: File /opt/conda/lib/python3.10/site-packages/accelerate/data_loader.py:451, in DataLoaderShard.__iter__(self) 449 # We iterate one batch ahead to check when we are at the end 450 try: --> 451 current_batch = next(dataloader_iter) 452 except StopIteration: 453 yield File /opt/conda/lib/python3.10/site-packages/torch/utils/data/dataloader.py:630, in _BaseDataLoaderIter.__next__(self) 627 if self._sampler_iter is None: 628 # TODO([https://github.com/pytorch/pytorch/issues/76750)](https://github.com/pytorch/pytorch/issues/76750)%3C/span%3E) 629 self._reset() # type: ignore[call-arg] --> 630 data = self._next_data() 631 self._num_yielded += 1 632 if self._dataset_kind == _DatasetKind.Iterable and \ 633 self._IterableDataset_len_called is not None and \ 634 self._num_yielded > self._IterableDataset_len_called: File /opt/conda/lib/python3.10/site-packages/torch/utils/data/dataloader.py:674, in _SingleProcessDataLoaderIter._next_data(self) 672 def _next_data(self): 673 index = self._next_index() # may raise StopIteration --> 674 data = self._dataset_fetcher.fetch(index) # may raise StopIteration 675 if self._pin_memory: 676 data = _utils.pin_memory.pin_memory(data, self._pin_memory_device) File /opt/conda/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py:51, in _MapDatasetFetcher.fetch(self, possibly_batched_index) 49 data = self.dataset.__getitems__(possibly_batched_index) 50 else: ---> 51 data = [self.dataset[idx] for idx in possibly_batched_index] 52 else: 53 data = self.dataset[possibly_batched_index] File /opt/conda/lib/python3.10/site-packages/torch/utils/data/_utils/fetch.py:51, in <listcomp>(.0) 49 data = self.dataset.__getitems__(possibly_batched_index) 50 else: ---> 51 data = [self.dataset[idx] for idx in possibly_batched_index] 52 else: 53 data = self.dataset[possibly_batched_index] File /opt/conda/lib/python3.10/site-packages/datasets/arrow_dataset.py:1764, in Dataset.__getitem__(self, key) 1762 def __getitem__(self, key): # noqa: F811 1763 """Can be used to index columns (by string names) or rows (by integer index or iterable of indices or bools).""" -> 1764 return self._getitem( 1765 key, 1766 ) File /opt/conda/lib/python3.10/site-packages/datasets/arrow_dataset.py:1749, in Dataset._getitem(self, key, decoded, **kwargs) 1747 formatter = get_formatter(format_type, features=self.features, decoded=decoded, **format_kwargs) 1748 pa_subtable = query_table(self._data, key, indices=self._indices if self._indices is not None else None) -> 1749 formatted_output = format_table( 1750 pa_subtable, key, formatter=formatter, format_columns=format_columns, output_all_columns=output_all_columns 1751 ) 1752 return formatted_output File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:540, in format_table(table, key, formatter, format_columns, output_all_columns) 538 else: 539 pa_table_to_format = pa_table.drop(col for col in pa_table.column_names if col not in format_columns) --> 540 formatted_output = formatter(pa_table_to_format, query_type=query_type) 541 if output_all_columns: 542 if isinstance(formatted_output, MutableMapping): File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:281, in Formatter.__call__(self, pa_table, query_type) 279 def __call__(self, pa_table: pa.Table, query_type: str) -> Union[RowFormat, ColumnFormat, BatchFormat]: 280 if query_type == "row": --> 281 return self.format_row(pa_table) 282 elif query_type == "column": 283 return self.format_column(pa_table) File /opt/conda/lib/python3.10/site-packages/datasets/formatting/torch_formatter.py:57, in TorchFormatter.format_row(self, pa_table) 56 def format_row(self, pa_table: pa.Table) -> dict: ---> 57 row = self.numpy_arrow_extractor().extract_row(pa_table) 58 return self.recursive_tensorize(row) File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:154, in NumpyArrowExtractor.extract_row(self, pa_table) 153 def extract_row(self, pa_table: pa.Table) -> dict: --> 154 return _unnest(self.extract_batch(pa_table)) File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:160, in NumpyArrowExtractor.extract_batch(self, pa_table) 159 def extract_batch(self, pa_table: pa.Table) -> dict: --> 160 return {col: self._arrow_array_to_numpy(pa_table[col]) for col in pa_table.column_names} File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:160, in <dictcomp>(.0) 159 def extract_batch(self, pa_table: pa.Table) -> dict: --> 160 return {col: self._arrow_array_to_numpy(pa_table[col]) for col in pa_table.column_names} File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:196, in NumpyArrowExtractor._arrow_array_to_numpy(self, pa_array) 194 array: List = pa_array.to_numpy(zero_copy_only=zero_copy_only).tolist() 195 if len(array) > 0: --> 196 if any( 197 (isinstance(x, np.ndarray) and (x.dtype == np.object or x.shape != array[0].shape)) 198 or (isinstance(x, float) and np.isnan(x)) 199 for x in array 200 ): 201 return np.array(array, copy=False, **{**self.np_array_kwargs, "dtype": np.object}) 202 return np.array(array, copy=False, **self.np_array_kwargs) File /opt/conda/lib/python3.10/site-packages/datasets/formatting/formatting.py:197, in <genexpr>(.0) 194 array: List = pa_array.to_numpy(zero_copy_only=zero_copy_only).tolist() 195 if len(array) > 0: 196 if any( --> 197 (isinstance(x, np.ndarray) and (x.dtype == np.object or x.shape != array[0].shape)) 198 or (isinstance(x, float) and np.isnan(x)) 199 for x in array 200 ): 201 return np.array(array, copy=False, **{**self.np_array_kwargs, "dtype": np.object}) 202 return np.array(array, copy=False, **self.np_array_kwargs) File /opt/conda/lib/python3.10/site-packages/numpy/__init__.py:324, in __getattr__(attr) 319 warnings.warn( 320 f"In the future `np.{attr}` will be defined as the " 321 "corresponding NumPy scalar.", FutureWarning, stacklevel=2) 323 if attr in __former_attrs__: --> 324 raise AttributeError(__former_attrs__[attr]) 326 if attr == 'testing': 327 import numpy.testing as testing AttributeError: module 'numpy' has no attribute 'object'. `np.object` was a deprecated alias for the builtin `object`. To avoid this error in existing code, use `object` by itself. Doing this will not modify any behavior and is safe. The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations Please help me to resolve the above error ### Steps to reproduce the bug Please resolve the issue of deprecated function np.object to object in the numpy ### Expected behavior np.object should be written as object only ### Environment info kaggle notebook

https://api.github.com/repos/huggingface/datasets/issues/6669/timeline

completed

https://api.github.com/repos/huggingface/datasets/issues/6668

https://api.github.com/repos/huggingface/datasets

https://api.github.com/repos/huggingface/datasets/issues/6668/labels{/name}

https://api.github.com/repos/huggingface/datasets/issues/6668/comments

https://api.github.com/repos/huggingface/datasets/issues/6668/events

https://github.com/huggingface/datasets/issues/6668

I_kwDODunzps5_bSdf

Chapter 6 - Issue Loading `cnn_dailymail` dataset

open