id
int64 599M
3.29B
| url
stringlengths 58
61
| html_url
stringlengths 46
51
| number
int64 1
7.72k
| title
stringlengths 1
290
| state
stringclasses 2
values | comments
int64 0
70
| created_at
timestamp[s]date 2020-04-14 10:18:02
2025-08-05 09:28:51
| updated_at
timestamp[s]date 2020-04-27 16:04:17
2025-08-05 11:39:56
| closed_at
timestamp[s]date 2020-04-14 12:01:40
2025-08-01 05:15:45
⌀ | user_login
stringlengths 3
26
| labels
listlengths 0
4
| body
stringlengths 0
228k
⌀ | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
668,037,965
|
https://api.github.com/repos/huggingface/datasets/issues/455
|
https://github.com/huggingface/datasets/pull/455
| 455
|
Add bleurt
|
closed
| 4
| 2020-07-29T18:08:32
| 2020-07-31T13:56:14
| 2020-07-31T13:56:14
|
yjernite
|
[] |
This PR adds the BLEURT metric to the library.
The BLEURT `Metric` downloads a TF checkpoint corresponding to its `config_name` at creation (in the `_info` function). Default is set to `bleurt-base-128`.
Note that the default in the original package is `bleurt-tiny-128`, but they throw a warning and recommend using `bleurt-base-128` instead. I think it's safer to have our users have a functioning metric when they call the default behavior, we'll address discrepancies in the issues/discussions if it comes up.
In addition to the BLEURT file, `load.py` was changed so we can ask users to pip install the required packages from git when they have a `setup.py` but are not on PyPL
cc @ankparikh @tsellam
| true
|
668,011,577
|
https://api.github.com/repos/huggingface/datasets/issues/454
|
https://github.com/huggingface/datasets/pull/454
| 454
|
Create SECURITY.md
|
closed
| 0
| 2020-07-29T17:23:34
| 2020-07-29T21:45:52
| 2020-07-29T21:45:52
|
ChenZehong13
|
[] | true
|
|
667,728,247
|
https://api.github.com/repos/huggingface/datasets/issues/453
|
https://github.com/huggingface/datasets/pull/453
| 453
|
add builder tests
|
closed
| 0
| 2020-07-29T10:22:07
| 2020-07-29T11:14:06
| 2020-07-29T11:14:05
|
lhoestq
|
[] |
I added `as_dataset` and `download_and_prepare` to the tests
| true
|
667,498,295
|
https://api.github.com/repos/huggingface/datasets/issues/452
|
https://github.com/huggingface/datasets/pull/452
| 452
|
Guardian authorship dataset
|
closed
| 6
| 2020-07-29T02:23:57
| 2020-08-20T15:09:57
| 2020-08-20T15:07:56
|
malikaltakrori
|
[] |
A new dataset: Guardian news articles for authorship attribution
**tests passed:**
python nlp-cli dummy_data datasets/guardian_authorship --save_infos --all_configs
RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_guardian_authorship
**Tests failed:**
Real data: RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_guardian_authorship
output: __init__() missing 3 required positional arguments: 'train_folder', 'valid_folder', and 'tes...'
Remarks: This is the init function of my class. I am not sure why it passes in both my tests and with nlp-cli, but fails here. By the way, I ran this command with another 2 datasets and they failed:
* _glue - OSError: Cannot find data file.
*_newsgroup - FileNotFoundError: Local file datasets/newsgroup/dummy/18828_comp.graphics/3.0.0/dummy_data.zip doesn't exist
Thank you for letting us contribute to such a huge and important library!
EDIT:
I was able to fix the dummy_data issue. This dataset has around 14 configurations. I was testing with only 2, but their versions were not in a sequence, they were V1.0.0 and V.12.0.0. It seems that the testing code generates testes for all the versions from 0 to MAX, and was testing for versions (and dummy_data.zip files) that do not exist. I fixed that by changing the versions to 1 and 2.
| true
|
667,210,468
|
https://api.github.com/repos/huggingface/datasets/issues/451
|
https://github.com/huggingface/datasets/pull/451
| 451
|
Fix csv/json/txt cache dir
|
closed
| 4
| 2020-07-28T16:30:51
| 2020-07-29T13:57:23
| 2020-07-29T13:57:22
|
lhoestq
|
[] |
The cache dir for csv/json/txt datasets was always the same. This is an issue because it should be different depending on the data files provided by the user.
To fix that, I added a line that use the hash of the data files provided by the user to define the cache dir.
This should fix #444
| true
|
667,074,120
|
https://api.github.com/repos/huggingface/datasets/issues/450
|
https://github.com/huggingface/datasets/pull/450
| 450
|
add sogou_news
|
closed
| 0
| 2020-07-28T13:29:10
| 2020-07-29T13:30:18
| 2020-07-29T13:30:17
|
mariamabarham
|
[] |
This PR adds the sogou news dataset
#353
| true
|
666,898,923
|
https://api.github.com/repos/huggingface/datasets/issues/449
|
https://github.com/huggingface/datasets/pull/449
| 449
|
add reuters21578 dataset
|
closed
| 3
| 2020-07-28T08:58:12
| 2023-09-24T09:49:28
| 2020-08-03T11:10:31
|
mariamabarham
|
[] |
This PR adds the `Reuters_21578` dataset https://kdd.ics.uci.edu/databases/reuters21578/reuters21578.html
#353
The datasets is a lit of `.sgm` files which are a bit different from xml file indeed `xml.etree` couldn't be used to read files. I consider them as text file (to avoid using external library) and read line by line (maybe there is a better way to do, happy to get your opinion on it)
In the Readme file 3 ways to split the dataset are given.:
- The Modified Lewis ("ModLewis") Split: train, test and unused-set
- The Modified Apte ("ModApte") Split : train, test and unused-set
- The Modified Hayes ("ModHayes") Split: train and test
Here I consider the last one as the readme file highlight that this split provides the ability to compare results with those of the 2 first splits.
| true
|
666,893,443
|
https://api.github.com/repos/huggingface/datasets/issues/448
|
https://github.com/huggingface/datasets/pull/448
| 448
|
add aws load metric test
|
closed
| 3
| 2020-07-28T08:50:22
| 2020-07-28T15:02:27
| 2020-07-28T15:02:27
|
idoh
|
[] |
Following issue #445
Added a test to recognize import errors of all metrics
| true
|
666,842,115
|
https://api.github.com/repos/huggingface/datasets/issues/447
|
https://github.com/huggingface/datasets/pull/447
| 447
|
[BugFix] fix wrong import of DEFAULT_TOKENIZER
|
closed
| 0
| 2020-07-28T07:41:10
| 2020-07-28T12:58:01
| 2020-07-28T12:52:05
|
idoh
|
[] |
Fixed the path to `DEFAULT_TOKENIZER`
#445
| true
|
666,837,351
|
https://api.github.com/repos/huggingface/datasets/issues/446
|
https://github.com/huggingface/datasets/pull/446
| 446
|
[BugFix] fix wrong import of DEFAULT_TOKENIZER
|
closed
| 0
| 2020-07-28T07:32:47
| 2020-07-28T07:34:46
| 2020-07-28T07:33:59
|
idoh
|
[] |
Fixed the path to `DEFAULT_TOKENIZER`
#445
| true
|
666,836,658
|
https://api.github.com/repos/huggingface/datasets/issues/445
|
https://github.com/huggingface/datasets/issues/445
| 445
|
DEFAULT_TOKENIZER import error in sacrebleu
|
closed
| 1
| 2020-07-28T07:31:30
| 2020-07-28T12:58:56
| 2020-07-28T12:58:56
|
idoh
|
[] |
Latest Version 0.3.0
When loading the metric "sacrebleu" there is an import error due to the wrong path
| false
|
666,280,842
|
https://api.github.com/repos/huggingface/datasets/issues/444
|
https://github.com/huggingface/datasets/issues/444
| 444
|
Keep loading old file even I specify a new file in load_dataset
|
closed
| 2
| 2020-07-27T13:08:06
| 2020-07-29T13:57:22
| 2020-07-29T13:57:22
|
joshhu
|
[
"dataset bug"
] |
I used load a file called 'a.csv' by
```
dataset = load_dataset('csv', data_file='./a.csv')
```
And after a while, I tried to load another csv called 'b.csv'
```
dataset = load_dataset('csv', data_file='./b.csv')
```
However, the new dataset seems to remain the old 'a.csv' and not loading new csv file.
Even worse, after I load a.csv, the load_dataset function keeps loading the 'a.csv' afterward.
Is this a cache problem?
| false
|
666,246,716
|
https://api.github.com/repos/huggingface/datasets/issues/443
|
https://github.com/huggingface/datasets/issues/443
| 443
|
Cannot unpickle saved .pt dataset with torch.save()/load()
|
closed
| 1
| 2020-07-27T12:13:37
| 2020-07-27T13:05:11
| 2020-07-27T13:05:11
|
vegarab
|
[] |
Saving a formatted torch dataset to file using `torch.save()`. Loading the same file fails during unpickling:
```python
>>> import torch
>>> import nlp
>>> squad = nlp.load_dataset("squad.py", split="train")
>>> squad
Dataset(features: {'source_text': Value(dtype='string', id=None), 'target_text': Value(dtype='string', id=None)}, num_rows: 87599)
>>> squad = squad.map(create_features, batched=True)
>>> squad.set_format(type="torch", columns=["source_ids", "target_ids", "attention_mask"])
>>> torch.save(squad, "squad.pt")
>>> squad_pt = torch.load("squad.pt")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/vegarab/.conda/envs/torch/lib/python3.7/site-packages/torch/serialization.py", line 593, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/home/vegarab/.conda/envs/torch/lib/python3.7/site-packages/torch/serialization.py", line 773, in _legacy_load
result = unpickler.load()
File "/home/vegarab/.conda/envs/torch/lib/python3.7/site-packages/nlp/splits.py", line 493, in __setitem__
raise ValueError("Cannot add elem. Use .add() instead.")
ValueError: Cannot add elem. Use .add() instead.
```
where `create_features` is a function that tokenizes the data using `batch_encode_plus` and returns a Dict with `input_ids`, `target_ids` and `attention_mask`.
```python
def create_features(batch):
source_text_encoding = tokenizer.batch_encode_plus(
batch["source_text"],
max_length=max_source_length,
pad_to_max_length=True,
truncation=True)
target_text_encoding = tokenizer.batch_encode_plus(
batch["target_text"],
max_length=max_target_length,
pad_to_max_length=True,
truncation=True)
features = {
"source_ids": source_text_encoding["input_ids"],
"target_ids": target_text_encoding["input_ids"],
"attention_mask": source_text_encoding["attention_mask"]
}
return features
```
I found a similar issue in [issue 5267 in the huggingface/transformers repo](https://github.com/huggingface/transformers/issues/5267) which was solved by downgrading to `nlp==0.2.0`. That did not solve this problem, however.
| false
|
666,201,810
|
https://api.github.com/repos/huggingface/datasets/issues/442
|
https://github.com/huggingface/datasets/issues/442
| 442
|
[Suggestion] Glue Diagnostic Data with Labels
|
open
| 0
| 2020-07-27T10:59:58
| 2020-08-24T15:13:20
| null |
ggbetz
|
[
"Dataset discussion"
] |
Hello! First of all, thanks for setting up this useful project!
I've just realised you provide the the [Glue Diagnostics Data](https://huggingface.co/nlp/viewer/?dataset=glue&config=ax) without labels, indicating in the `GlueConfig` that you've only a test set.
Yet, the data with labels is available, too (see also [here](https://gluebenchmark.com/diagnostics#introduction)):
https://www.dropbox.com/s/ju7d95ifb072q9f/diagnostic-full.tsv?dl=1
Have you considered incorporating it?
| false
|
666,148,413
|
https://api.github.com/repos/huggingface/datasets/issues/441
|
https://github.com/huggingface/datasets/pull/441
| 441
|
Add features parameter in load dataset
|
closed
| 2
| 2020-07-27T09:50:01
| 2020-07-30T12:51:17
| 2020-07-30T12:51:16
|
lhoestq
|
[] |
Added `features` argument in `nlp.load_dataset`.
If they don't match the data type, it raises a `ValueError`.
It's a draft PR because #440 needs to be merged first.
| true
|
666,116,823
|
https://api.github.com/repos/huggingface/datasets/issues/440
|
https://github.com/huggingface/datasets/pull/440
| 440
|
Fix user specified features in map
|
closed
| 0
| 2020-07-27T09:04:26
| 2020-07-28T09:25:23
| 2020-07-28T09:25:22
|
lhoestq
|
[] |
`.map` didn't keep the user specified features because of an issue in the writer.
The writer used to overwrite the user specified features with inferred features.
I also added tests to make sure it doesn't happen again.
| true
|
665,964,673
|
https://api.github.com/repos/huggingface/datasets/issues/439
|
https://github.com/huggingface/datasets/issues/439
| 439
|
Issues: Adding a FAISS or Elastic Search index to a Dataset
|
closed
| 5
| 2020-07-27T04:25:17
| 2020-10-28T01:46:24
| 2020-10-28T01:46:24
|
nsankar
|
[] |
It seems the DPRContextEncoder, DPRContextEncoderTokenizer cited[ in this documentation](https://huggingface.co/nlp/faiss_and_ea.html) is not implemented ? It didnot work with the standard nlp installation . Also, I couldn't find or use it with the latest nlp install from github in Colab. Is there any dependency on the latest PyArrow 1.0.0 ? Is it yet to be made generally available ?
| false
|
665,865,490
|
https://api.github.com/repos/huggingface/datasets/issues/438
|
https://github.com/huggingface/datasets/issues/438
| 438
|
New Datasets: IWSLT15+, ITTB
|
open
| 2
| 2020-07-26T21:43:04
| 2020-08-24T15:12:15
| null |
sshleifer
|
[
"dataset request"
] |
**Links:**
[iwslt](https://pytorchnlp.readthedocs.io/en/latest/_modules/torchnlp/datasets/iwslt.html)
Don't know if that link is up to date.
[ittb](http://www.cfilt.iitb.ac.in/iitb_parallel/)
**Motivation**: replicate mbart finetuning results (table below)
For future readers, we already have the following language pairs in the wmt namespaces:
```
wmt14: ['cs-en', 'de-en', 'fr-en', 'hi-en', 'ru-en']
wmt15: ['cs-en', 'de-en', 'fi-en', 'fr-en', 'ru-en']
wmt16: ['cs-en', 'de-en', 'fi-en', 'ro-en', 'ru-en', 'tr-en']
wmt17: ['cs-en', 'de-en', 'fi-en', 'lv-en', 'ru-en', 'tr-en', 'zh-en']
wmt18: ['cs-en', 'de-en', 'et-en', 'fi-en', 'kk-en', 'ru-en', 'tr-en', 'zh-en']
wmt19: ['cs-en', 'de-en', 'fi-en', 'gu-en', 'kk-en', 'lt-en', 'ru-en', 'zh-en', 'fr-de']
```
| false
|
665,597,176
|
https://api.github.com/repos/huggingface/datasets/issues/437
|
https://github.com/huggingface/datasets/pull/437
| 437
|
Fix XTREME PAN-X loading
|
closed
| 4
| 2020-07-25T14:44:57
| 2020-07-30T08:28:15
| 2020-07-30T08:28:15
|
lvwerra
|
[] |
Hi 🤗
In response to the discussion in #425 @lewtun and I made some fixes to the repo. In the original XTREME implementation the PAN-X dataset for named entity recognition loaded each word/tag pair as a single row and the sentence relation was lost. With the fix each row contains the list of all words in a single sentence and their NER tags. This is also in agreement with the [NER example](https://github.com/huggingface/transformers/tree/master/examples/token-classification) in the transformers repo.
With the fix the output of the dataset should look as follows:
```python
>>> dataset = load_dataset("xtreme", "PAN-X.en", data_dir='./data')
>>> dataset['train'][0]
{'words': ['R.H.', 'Saunders', '(', 'St.', 'Lawrence', 'River', ')', '(', '968', 'MW', ')'],
'ner_tags': ['B-ORG', 'I-ORG', 'O', 'B-ORG', 'I-ORG', 'I-ORG', 'O', 'O', 'O', 'O', 'O'],
'langs': ['en', 'en', 'en', 'en', 'en', 'en', 'en', 'en', 'en', 'en', 'en']}
```
| true
|
665,582,167
|
https://api.github.com/repos/huggingface/datasets/issues/436
|
https://github.com/huggingface/datasets/issues/436
| 436
|
Google Colab - load_dataset - PyArrow exception
|
closed
| 9
| 2020-07-25T13:05:20
| 2020-08-20T08:08:18
| 2020-08-20T08:08:18
|
nsankar
|
[] |
With latest PyArrow 1.0.0 installed, I get the following exception . Restarting colab has the same issue
ImportWarning: To use `nlp`, the module `pyarrow>=0.16.0` is required, and the current version of `pyarrow` doesn't match this condition. If you are running this in a Google Colab, you should probably just restart the runtime to use the right version of `pyarrow`.
The error goes only when I install version 0.16.0
i.e. !pip install pyarrow==0.16.0
| false
|
665,507,141
|
https://api.github.com/repos/huggingface/datasets/issues/435
|
https://github.com/huggingface/datasets/issues/435
| 435
|
ImportWarning for pyarrow 1.0.0
|
closed
| 4
| 2020-07-25T03:44:39
| 2020-09-08T17:57:15
| 2020-08-03T16:37:32
|
HanGuo97
|
[] |
The following PR raised ImportWarning at `pyarrow ==1.0.0` https://github.com/huggingface/nlp/pull/265/files
| false
|
665,477,638
|
https://api.github.com/repos/huggingface/datasets/issues/434
|
https://github.com/huggingface/datasets/pull/434
| 434
|
Fixed check for pyarrow
|
closed
| 1
| 2020-07-25T00:16:53
| 2020-07-25T06:36:34
| 2020-07-25T06:36:34
|
nadahlberg
|
[] |
Fix check for pyarrow in __init__.py. Previously would raise an error for pyarrow >= 1.0.0
| true
|
665,311,025
|
https://api.github.com/repos/huggingface/datasets/issues/433
|
https://github.com/huggingface/datasets/issues/433
| 433
|
How to reuse functionality of a (generic) dataset?
|
closed
| 4
| 2020-07-24T17:27:37
| 2022-10-04T17:59:34
| 2022-10-04T17:59:33
|
ArneBinder
|
[] |
I have written a generic dataset for corpora created with the Brat annotation tool ([specification](https://brat.nlplab.org/standoff.html), [dataset code](https://github.com/ArneBinder/nlp/blob/brat/datasets/brat/brat.py)). Now I wonder how to use that to create specific dataset instances. What's the recommended way to reuse formats and loading functionality for datasets with a common format?
In my case, it took a bit of time to create the Brat dataset and I think others would appreciate to not have to think about that again. Also, I assume there are other formats (e.g. conll) that are widely used, so having this would really ease dataset onboarding and adoption of the library.
| false
|
665,234,340
|
https://api.github.com/repos/huggingface/datasets/issues/432
|
https://github.com/huggingface/datasets/pull/432
| 432
|
Fix handling of config files while loading datasets from multiple processes
|
closed
| 4
| 2020-07-24T15:10:57
| 2020-08-01T17:11:42
| 2020-07-30T08:25:28
|
orsharir
|
[] |
When loading shards on several processes, each process upon loading the dataset will overwrite dataset_infos.json in <package path>/datasets/<dataset name>/<hash>/dataset_infos.json. It does so every time, even when the target file already exists and is identical. Because multiple processes rewrite the same file in parallel, it creates a race condition when a process tries to load the file, often resulting in a JSON decoding exception because the file is only partially written.
This pull requests partially address this by comparing if the files are already identical before copying over the downloaded copy to the cached destination. There's still a race condition, but now it's less likely to occur if some basic precautions are taken by the library user, e.g., download all datasets to cache before spawning multiple processes.
| true
|
665,044,416
|
https://api.github.com/repos/huggingface/datasets/issues/431
|
https://github.com/huggingface/datasets/pull/431
| 431
|
Specify split post processing + Add post processing resources downloading
|
closed
| 4
| 2020-07-24T09:29:19
| 2020-07-31T09:05:04
| 2020-07-31T09:05:03
|
lhoestq
|
[] |
Previously if you tried to do
```python
from nlp import load_dataset
wiki = load_dataset("wiki_dpr", "psgs_w100_with_nq_embeddings", split="train[:100]", with_index=True)
```
Then you'd get an error `Index size should match Dataset size...`
This was because it was trying to use the full index (21M elements).
To fix that I made it so post processing resources can be named according to the split.
I'm going to add tests on post processing too.
Note that the CI will fail as I added a new argument in `_post_processing_resources`: the AWS version of wiki_dpr fails, and there's also an error telling that it is not synced (it'll be synced once it's merged):
```
=========================== short test summary info ============================
FAILED tests/test_dataset_common.py::AWSDatasetTest::test_load_dataset_wiki_dpr
FAILED tests/test_hf_gcp.py::TestDatasetSynced::test_script_synced_with_s3_wiki_dpr
```
EDIT: I did a change to ignore the script hash to locate the arrow files on GCS, so I removed the sync test. It was there just because of the hash logic for files on GCS
| true
|
664,583,837
|
https://api.github.com/repos/huggingface/datasets/issues/430
|
https://github.com/huggingface/datasets/pull/430
| 430
|
add DatasetDict
|
closed
| 4
| 2020-07-23T15:43:49
| 2020-08-04T01:01:53
| 2020-07-29T09:06:22
|
lhoestq
|
[] |
## Add DatasetDict
### Overview
When you call `load_dataset` it can return a dictionary of datasets if there are several splits (train/test for example).
If you wanted to apply dataset transforms you had to iterate over each split and apply the transform.
Instead of returning a dict, it now returns a `nlp.DatasetDict` object which inherits from dict and contains the same data as before, except that now users can call dataset transforms directly from the output, and they'll be applied on each split.
Before:
```python
from nlp import load_dataset
squad = load_dataset("squad")
print(squad.keys())
# dict_keys(['train', 'validation'])
squad = {
split_name: dataset.map(my_func) for split_name, dataset in squad.items()
}
print(squad.keys())
# dict_keys(['train', 'validation'])
```
Now:
```python
from nlp import load_dataset
squad = load_dataset("squad")
print(squad.keys())
# dict_keys(['train', 'validation'])
squad = squad.map(my_func)
print(squad.keys())
# dict_keys(['train', 'validation'])
```
### Dataset transforms
`nlp.DatasetDict` implements the following dataset transforms:
- map
- filter
- sort
- shuffle
### Arguments
The arguments of the methods are the same except for split-specific arguments like `cache_file_name`.
For such arguments, the expected input is a dictionary `{split_name: argument_value}`
It concerns:
- `cache_file_name` in map, filter, sort, shuffle
- `seed` and `generator` in shuffle
| true
|
664,412,137
|
https://api.github.com/repos/huggingface/datasets/issues/429
|
https://github.com/huggingface/datasets/pull/429
| 429
|
mlsum
|
closed
| 6
| 2020-07-23T11:52:39
| 2020-07-31T11:46:20
| 2020-07-31T11:46:20
|
RachelKer
|
[] |
Hello,
The tests for the load_real_data fail, as there is no default language subset to download it looks for a file that does not exist. This bug does not happen when using the load_dataset function, as it asks you to specify a language if you do not, so I submit this PR anyway. The dataset is avalaible on : https://gitlab.lip6.fr/scialom/mlsum_data
| true
|
664,367,086
|
https://api.github.com/repos/huggingface/datasets/issues/428
|
https://github.com/huggingface/datasets/pull/428
| 428
|
fix concatenate_datasets
|
closed
| 0
| 2020-07-23T10:30:59
| 2020-07-23T10:35:00
| 2020-07-23T10:34:58
|
lhoestq
|
[] |
`concatenate_datatsets` used to test that the different`nlp.Dataset.schema` match, but this attribute was removed in #423
| true
|
664,341,623
|
https://api.github.com/repos/huggingface/datasets/issues/427
|
https://github.com/huggingface/datasets/pull/427
| 427
|
Allow sequence features for beam + add processed Natural Questions
|
closed
| 0
| 2020-07-23T09:52:41
| 2020-07-23T13:09:30
| 2020-07-23T13:09:29
|
lhoestq
|
[] |
## Allow Sequence features for Beam Datasets + add Natural Questions
### The issue
The steps of beam datasets processing is the following:
- download the source files and send them in a remote storage (gcs)
- process the files using a beam runner (dataflow)
- save output in remote storage (gcs)
- convert output to arrow in remote storage (gcs)
However it wasn't possible to process `natural_questions` because apache beam's processing outputs parquet files, and it's not yet possible to read parquet files with list features.
### The proposed solution
To allow sequence features for beam I added a workaround that serializes the values using `json.dumps`, so that we end up with strings instead of the original features. Then when the arrow file is created, the serialized objects are transformed back to normal with `json.loads`. Not sure if there's a better way to do it.
### Natural Questions
I was able to process NQ with it, and so I added the json infos file in this PR too.
The processed arrow files are also stored in gcs.
It allows you to load NQ with
```python
from nlp import load_dataset
nq = load_dataset("natural_questions") # download the 90GB arrow files from gcs and return the dataset
```
### Tests
I added a test case to make sure it works as expected.
Note that the CI will fail because I am updating `natural_questions.py`: it's not synced with the script on S3. It will be synced as soon as this PR is merged.
```
=========================== short test summary info ============================
FAILED tests/test_hf_gcp.py::TestDatasetOnHfGcp::test_script_synced_with_s3_natural_questions/default
```
| true
|
664,203,897
|
https://api.github.com/repos/huggingface/datasets/issues/426
|
https://github.com/huggingface/datasets/issues/426
| 426
|
[FEATURE REQUEST] Multiprocessing with for dataset.map, dataset.filter
|
closed
| 6
| 2020-07-23T05:00:41
| 2021-03-12T09:34:12
| 2020-09-07T14:48:04
|
timothyjlaurent
|
[
"enhancement"
] |
It would be nice to be able to speed up `dataset.map` or `dataset.filter`. Perhaps this is as easy as sharding the dataset sending each shard to a process/thread/dask pool and using the new `nlp.concatenate_dataset()` function to join them all together?
| false
|
664,029,848
|
https://api.github.com/repos/huggingface/datasets/issues/425
|
https://github.com/huggingface/datasets/issues/425
| 425
|
Correct data structure for PAN-X task in XTREME dataset?
|
closed
| 7
| 2020-07-22T20:29:20
| 2020-08-02T13:30:34
| 2020-08-02T13:30:34
|
lewtun
|
[] |
Hi 🤗 team!
## Description of the problem
Thanks to the fix from #416 I am now able to load the NER task in the XTREME dataset as follows:
```python
from nlp import load_dataset
# AmazonPhotos.zip is located in data/
dataset = load_dataset("xtreme", "PAN-X.en", data_dir='./data')
dataset_train = dataset['train']
```
However, I am not sure that `load_dataset()` is returning the correct data structure for NER.
Currently, every row in `dataset_train` is of the form
```python
{'word': str, 'ner_tag': str, 'lang': str}
```
but I think we actually want something like
```python
{'words': List[str], 'ner_tags': List[str], 'langs': List[str]}
```
so that each row corresponds to a _sequence_ of words associated with each example. With the current data structure I do not think it is possible to transform `dataset_train` into a form suitable for training because we do not know the boundaries between examples.
Indeed, [this line](https://github.com/google-research/xtreme/blob/522434d1aece34131d997a97ce7e9242a51a688a/third_party/utils_tag.py#L58) in the XTREME repo, processes the texts as lists of sentences, tags, and languages.
## Proposed solution
Replace
```python
with open(filepath) as f:
data = csv.reader(f, delimiter="\t", quoting=csv.QUOTE_NONE)
for id_, row in enumerate(data):
if row:
lang, word = row[0].split(":")[0], row[0].split(":")[1]
tag = row[1]
yield id_, {"word": word, "ner_tag": tag, "lang": lang}
```
from [these lines](https://github.com/huggingface/nlp/blob/ce7d3a1d630b78fe27188d1706f3ea980e8eec43/datasets/xtreme/xtreme.py#L881-L887) of the `_generate_examples()` function with something like
```python
guid_index = 1
with open(filepath, encoding="utf-8") as f:
words = []
ner_tags = []
langs = []
for line in f:
if line.startswith("-DOCSTART-") or line == "" or line == "\n":
if words:
yield guid_index, {"words": words, "ner_tags": ner_tags, "langs": langs}
guid_index += 1
words = []
ner_tags = []
else:
# pan-x data is tab separated
splits = line.split("\t")
# strip out en: prefix
langs.append(splits[0][:2])
words.append(splits[0][3:])
if len(splits) > 1:
labels.append(splits[-1].replace("\n", ""))
else:
# examples have no label in test set
labels.append("O")
```
If you agree, me or @lvwerra would be happy to implement this and create a PR.
| false
|
663,858,552
|
https://api.github.com/repos/huggingface/datasets/issues/424
|
https://github.com/huggingface/datasets/pull/424
| 424
|
Web of science
|
closed
| 0
| 2020-07-22T15:38:31
| 2020-07-23T14:27:58
| 2020-07-23T14:27:56
|
mariamabarham
|
[] |
this PR adds the WebofScience dataset
#353
| true
|
663,079,359
|
https://api.github.com/repos/huggingface/datasets/issues/423
|
https://github.com/huggingface/datasets/pull/423
| 423
|
Change features vs schema logic
|
closed
| 2
| 2020-07-21T14:52:47
| 2020-07-25T09:08:34
| 2020-07-23T10:15:17
|
lhoestq
|
[] |
## New logic for `nlp.Features` in datasets
Previously, it was confusing to have `features` and pyarrow's `schema` in `nlp.Dataset`.
However `features` is supposed to be the front-facing object to define the different fields of a dataset, while `schema` is only used to write arrow files.
Changes:
- Remove `schema` field in `nlp.Dataset`
- Make `features` the source of truth to read/write examples
- `features` can no longer be `None` in `nlp.Dataset`
- Update `features` after each dataset transform such as `nlp.Dataset.map`
Todo: change the tests to take these changes into account
| true
|
663,028,497
|
https://api.github.com/repos/huggingface/datasets/issues/422
|
https://github.com/huggingface/datasets/pull/422
| 422
|
- Corrected encoding for IMDB.
|
closed
| 0
| 2020-07-21T13:46:59
| 2020-07-22T16:02:53
| 2020-07-22T16:02:53
|
ghazi-f
|
[] |
The preparation phase (after the download phase) crashed on windows because of charmap encoding not being able to decode certain characters. This change suggested in Issue #347 fixes it for the IMDB dataset.
| true
|
662,213,864
|
https://api.github.com/repos/huggingface/datasets/issues/421
|
https://github.com/huggingface/datasets/pull/421
| 421
|
Style change
|
closed
| 3
| 2020-07-20T20:08:29
| 2020-07-22T16:08:40
| 2020-07-22T16:08:39
|
lordtt13
|
[] |
make quality and make style ran on scripts
| true
|
662,029,782
|
https://api.github.com/repos/huggingface/datasets/issues/420
|
https://github.com/huggingface/datasets/pull/420
| 420
|
Better handle nested features
|
closed
| 0
| 2020-07-20T16:44:13
| 2020-07-21T08:20:49
| 2020-07-21T08:09:52
|
lhoestq
|
[] |
Changes:
- added arrow schema to features conversion (it's going to be useful to fix #342 )
- make flatten handle deep features (useful for tfrecords conversion in #339 )
- add tests for flatten and features conversions
- the reader now returns the kwargs to instantiate a Dataset (fix circular dependencies)
| true
|
661,974,747
|
https://api.github.com/repos/huggingface/datasets/issues/419
|
https://github.com/huggingface/datasets/pull/419
| 419
|
EmoContext dataset add
|
closed
| 0
| 2020-07-20T15:48:45
| 2020-07-24T08:22:01
| 2020-07-24T08:22:00
|
lordtt13
|
[] |
EmoContext Dataset add
Signed-off-by: lordtt13 <thakurtanmay72@yahoo.com>
| true
|
661,914,873
|
https://api.github.com/repos/huggingface/datasets/issues/418
|
https://github.com/huggingface/datasets/issues/418
| 418
|
Addition of google drive links to dl_manager
|
closed
| 3
| 2020-07-20T14:52:02
| 2020-07-20T15:39:32
| 2020-07-20T15:39:32
|
lordtt13
|
[] |
Hello there, I followed the template to create a download script of my own, which works fine for me, although I had to shun the dl_manager because it was downloading nothing from the drive links and instead use gdown.
This is the script for me:
```python
class EmoConfig(nlp.BuilderConfig):
"""BuilderConfig for SQUAD."""
def __init__(self, **kwargs):
"""BuilderConfig for EmoContext.
Args:
**kwargs: keyword arguments forwarded to super.
"""
super(EmoConfig, self).__init__(**kwargs)
_TEST_URL = "https://drive.google.com/file/d/1Hn5ytHSSoGOC4sjm3wYy0Dh0oY_oXBbb/view?usp=sharing"
_TRAIN_URL = "https://drive.google.com/file/d/12Uz59TYg_NtxOy7SXraYeXPMRT7oaO7X/view?usp=sharing"
class EmoDataset(nlp.GeneratorBasedBuilder):
""" SemEval-2019 Task 3: EmoContext Contextual Emotion Detection in Text. Version 1.0.0 """
VERSION = nlp.Version("1.0.0")
force = False
def _info(self):
return nlp.DatasetInfo(
description=_DESCRIPTION,
features=nlp.Features(
{
"text": nlp.Value("string"),
"label": nlp.features.ClassLabel(names=["others", "happy", "sad", "angry"]),
}
),
supervised_keys=None,
homepage="https://www.aclweb.org/anthology/S19-2005/",
citation=_CITATION,
)
def _get_drive_url(self, url):
base_url = 'https://drive.google.com/uc?id='
split_url = url.split('/')
return base_url + split_url[5]
def _split_generators(self, dl_manager):
"""Returns SplitGenerators."""
if(not os.path.exists("emo-train.json") or self.force):
gdown.download(self._get_drive_url(_TRAIN_URL), "emo-train.json", quiet = True)
if(not os.path.exists("emo-test.json") or self.force):
gdown.download(self._get_drive_url(_TEST_URL), "emo-test.json", quiet = True)
return [
nlp.SplitGenerator(
name=nlp.Split.TRAIN,
gen_kwargs={
"filepath": "emo-train.json",
"split": "train",
},
),
nlp.SplitGenerator(
name=nlp.Split.TEST,
gen_kwargs={"filepath": "emo-test.json", "split": "test"},
),
]
def _generate_examples(self, filepath, split):
""" Yields examples. """
with open(filepath, 'rb') as f:
data = json.load(f)
for id_, text, label in zip(data["text"].keys(), data["text"].values(), data["Label"].values()):
yield id_, {
"text": text,
"label": label,
}
```
Can someone help me in adding gdrive links to be used with default dl_manager or adding gdown as another dl_manager, because I'd like to add this dataset to nlp's official database.
| false
|
661,804,054
|
https://api.github.com/repos/huggingface/datasets/issues/417
|
https://github.com/huggingface/datasets/pull/417
| 417
|
Fix docstrins multiple metrics instances
|
closed
| 0
| 2020-07-20T13:08:59
| 2020-07-22T09:51:00
| 2020-07-22T09:50:59
|
lhoestq
|
[] |
We change the docstrings of `nlp.Metric.compute`, `nlp.Metric.add` and `nlp.Metric.add_batch` depending on which metric is instantiated. However we had issues when instantiating multiple metrics (docstrings were duplicated).
This should fix #304
| true
|
661,635,393
|
https://api.github.com/repos/huggingface/datasets/issues/416
|
https://github.com/huggingface/datasets/pull/416
| 416
|
Fix xtreme panx directory
|
closed
| 1
| 2020-07-20T10:09:17
| 2020-07-21T08:15:46
| 2020-07-21T08:15:44
|
lhoestq
|
[] |
Fix #412
| true
|
660,687,076
|
https://api.github.com/repos/huggingface/datasets/issues/415
|
https://github.com/huggingface/datasets/issues/415
| 415
|
Something is wrong with WMT 19 kk-en dataset
|
open
| 0
| 2020-07-19T08:18:51
| 2020-07-20T09:54:26
| null |
ChenghaoMou
|
[
"dataset bug"
] |
The translation in the `train` set does not look right:
```
>>>import nlp
>>>from nlp import load_dataset
>>>dataset = load_dataset('wmt19', 'kk-en')
>>>dataset["train"]["translation"][0]
{'kk': 'Trumpian Uncertainty', 'en': 'Трамптық белгісіздік'}
>>>dataset["validation"]["translation"][0]
{'kk': 'Ақша-несие саясатының сценарийін қайта жазсақ', 'en': 'Rewriting the Monetary-Policy Script'}
```
| false
|
660,654,013
|
https://api.github.com/repos/huggingface/datasets/issues/414
|
https://github.com/huggingface/datasets/issues/414
| 414
|
from_dict delete?
|
closed
| 2
| 2020-07-19T07:08:36
| 2020-07-21T02:21:17
| 2020-07-21T02:21:17
|
hackerxiaobai
|
[] |
AttributeError: type object 'Dataset' has no attribute 'from_dict'
| false
|
660,063,655
|
https://api.github.com/repos/huggingface/datasets/issues/413
|
https://github.com/huggingface/datasets/issues/413
| 413
|
Is there a way to download only NQ dev?
|
closed
| 3
| 2020-07-18T10:28:23
| 2022-02-11T09:50:21
| 2022-02-11T09:50:21
|
tholor
|
[] |
Maybe I missed that in the docs, but is there a way to only download the dev set of natural questions (~1 GB)?
As we want to benchmark QA models on different datasets, I would like to avoid downloading the 41GB of training data.
I tried
```
dataset = nlp.load_dataset('natural_questions', split="validation", beam_runner="DirectRunner")
```
But this still triggered a big download of presumably the whole dataset. Is there any way of doing this or are splits / slicing options only available after downloading?
Thanks!
| false
|
660,047,139
|
https://api.github.com/repos/huggingface/datasets/issues/412
|
https://github.com/huggingface/datasets/issues/412
| 412
|
Unable to load XTREME dataset from disk
|
closed
| 3
| 2020-07-18T09:55:00
| 2020-07-21T08:15:44
| 2020-07-21T08:15:44
|
lewtun
|
[] |
Hi 🤗 team!
## Description of the problem
Following the [docs](https://huggingface.co/nlp/loading_datasets.html?highlight=xtreme#manually-downloading-files) I'm trying to load the `PAN-X.fr` dataset from the [XTREME](https://github.com/google-research/xtreme) benchmark.
I have manually downloaded the `AmazonPhotos.zip` file from [here](https://www.amazon.com/clouddrive/share/d3KGCRCIYwhKJF0H3eWA26hjg2ZCRhjpEQtDL70FSBN?_encoding=UTF8&%2AVersion%2A=1&%2Aentries%2A=0&mgh=1) and am running into a `FileNotFoundError` when I point to the location of the dataset.
As far as I can tell, the problem is that `AmazonPhotos.zip` decompresses to `panx_dataset` and `load_dataset()` is not looking in the correct path:
```
# path where load_dataset is looking for fr.tar.gz
/root/.cache/huggingface/datasets/9b8c4f1578e45cb2539332c79738beb3b54afbcd842b079cabfd79e3ed6704f6/
# path where it actually exists
/root/.cache/huggingface/datasets/9b8c4f1578e45cb2539332c79738beb3b54afbcd842b079cabfd79e3ed6704f6/panx_dataset/
```
## Steps to reproduce the problem
1. Manually download the XTREME benchmark from [here](https://www.amazon.com/clouddrive/share/d3KGCRCIYwhKJF0H3eWA26hjg2ZCRhjpEQtDL70FSBN?_encoding=UTF8&%2AVersion%2A=1&%2Aentries%2A=0&mgh=1)
2. Run the following code snippet
```python
from nlp import load_dataset
# AmazonPhotos.zip is in the root of the folder
dataset = load_dataset("xtreme", "PAN-X.fr", data_dir='./')
```
3. Here is the stack trace
```
---------------------------------------------------------------------------
FileNotFoundError Traceback (most recent call last)
<ipython-input-4-26786bb5fa93> in <module>
----> 1 dataset = load_dataset("xtreme", "PAN-X.fr", data_dir='./')
/usr/local/lib/python3.6/dist-packages/nlp/load.py in load_dataset(path, name, version, data_dir, data_files, split, cache_dir, download_config, download_mode, ignore_verifications, save_infos, **config_kwargs)
522 download_mode=download_mode,
523 ignore_verifications=ignore_verifications,
--> 524 save_infos=save_infos,
525 )
526
/usr/local/lib/python3.6/dist-packages/nlp/builder.py in download_and_prepare(self, download_config, download_mode, ignore_verifications, save_infos, try_from_hf_gcs, dl_manager, **download_and_prepare_kwargs)
430 verify_infos = not save_infos and not ignore_verifications
431 self._download_and_prepare(
--> 432 dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs
433 )
434 # Sync info
/usr/local/lib/python3.6/dist-packages/nlp/builder.py in _download_and_prepare(self, dl_manager, verify_infos, **prepare_split_kwargs)
464 split_dict = SplitDict(dataset_name=self.name)
465 split_generators_kwargs = self._make_split_generators_kwargs(prepare_split_kwargs)
--> 466 split_generators = self._split_generators(dl_manager, **split_generators_kwargs)
467 # Checksums verification
468 if verify_infos:
/usr/local/lib/python3.6/dist-packages/nlp/datasets/xtreme/b8c2ed3583a7a7ac60b503576dfed3271ac86757628897e945bd329c43b8a746/xtreme.py in _split_generators(self, dl_manager)
725 panx_dl_dir = dl_manager.extract(panx_path)
726 lang = self.config.name.split(".")[1]
--> 727 lang_folder = dl_manager.extract(os.path.join(panx_dl_dir, lang + ".tar.gz"))
728 return [
729 nlp.SplitGenerator(
/usr/local/lib/python3.6/dist-packages/nlp/utils/download_manager.py in extract(self, path_or_paths)
196 """
197 return map_nested(
--> 198 lambda path: cached_path(path, extract_compressed_file=True, force_extract=False), path_or_paths,
199 )
200
/usr/local/lib/python3.6/dist-packages/nlp/utils/py_utils.py in map_nested(function, data_struct, dict_only, map_tuple)
170 return tuple(mapped)
171 # Singleton
--> 172 return function(data_struct)
173
174
/usr/local/lib/python3.6/dist-packages/nlp/utils/download_manager.py in <lambda>(path)
196 """
197 return map_nested(
--> 198 lambda path: cached_path(path, extract_compressed_file=True, force_extract=False), path_or_paths,
199 )
200
/usr/local/lib/python3.6/dist-packages/nlp/utils/file_utils.py in cached_path(url_or_filename, download_config, **download_kwargs)
203 elif urlparse(url_or_filename).scheme == "":
204 # File, but it doesn't exist.
--> 205 raise FileNotFoundError("Local file {} doesn't exist".format(url_or_filename))
206 else:
207 # Something unknown
FileNotFoundError: Local file /root/.cache/huggingface/datasets/9b8c4f1578e45cb2539332c79738beb3b54afbcd842b079cabfd79e3ed6704f6/fr.tar.gz doesn't exist
```
## OS and hardware
```
- `nlp` version: 0.3.0
- Platform: Linux-4.15.0-72-generic-x86_64-with-Ubuntu-18.04-bionic
- Python version: 3.6.9
- PyTorch version (GPU?): 1.4.0 (True)
- Tensorflow version (GPU?): 2.1.0 (True)
- Using GPU in script?: <fill in>
- Using distributed or parallel set-up in script?: <fill in>
```
| false
|
659,393,398
|
https://api.github.com/repos/huggingface/datasets/issues/411
|
https://github.com/huggingface/datasets/pull/411
| 411
|
Sbf
|
closed
| 0
| 2020-07-17T16:19:45
| 2020-07-21T09:13:46
| 2020-07-21T09:13:45
|
mariamabarham
|
[] |
This PR adds the Social Bias Frames Dataset (ACL 2020) .
dataset homepage: https://homes.cs.washington.edu/~msap/social-bias-frames/
| true
|
659,242,871
|
https://api.github.com/repos/huggingface/datasets/issues/410
|
https://github.com/huggingface/datasets/pull/410
| 410
|
20newsgroup
|
closed
| 0
| 2020-07-17T13:07:57
| 2020-07-20T07:05:29
| 2020-07-20T07:05:28
|
mariamabarham
|
[] |
Add 20Newsgroup dataset.
#353
| true
|
659,128,611
|
https://api.github.com/repos/huggingface/datasets/issues/409
|
https://github.com/huggingface/datasets/issues/409
| 409
|
train_test_split error: 'dict' object has no attribute 'deepcopy'
|
closed
| 2
| 2020-07-17T10:36:28
| 2020-07-21T14:34:52
| 2020-07-21T14:34:52
|
morganmcg1
|
[] |
`train_test_split` is giving me an error when I try and call it:
`'dict' object has no attribute 'deepcopy'`
## To reproduce
```
dataset = load_dataset('glue', 'mrpc', split='train')
dataset = dataset.train_test_split(test_size=0.2)
```
## Full Stacktrace
```
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
<ipython-input-12-feb740dbec9a> in <module>
1 dataset = load_dataset('glue', 'mrpc', split='train')
----> 2 dataset = dataset.train_test_split(test_size=0.2)
~/anaconda3/envs/fastai2_me/lib/python3.7/site-packages/nlp/arrow_dataset.py in train_test_split(self, test_size, train_size, shuffle, seed, generator, keep_in_memory, load_from_cache_file, train_cache_file_name, test_cache_file_name, writer_batch_size)
1032 "writer_batch_size": writer_batch_size,
1033 }
-> 1034 train_kwargs = cache_kwargs.deepcopy()
1035 train_kwargs["split"] = "train"
1036 test_kwargs = cache_kwargs.deepcopy()
AttributeError: 'dict' object has no attribute 'deepcopy'
```
| false
|
659,064,144
|
https://api.github.com/repos/huggingface/datasets/issues/408
|
https://github.com/huggingface/datasets/pull/408
| 408
|
Add tests datasets gcp
|
closed
| 0
| 2020-07-17T09:23:27
| 2020-07-17T09:26:57
| 2020-07-17T09:26:56
|
lhoestq
|
[] |
Some datasets are available on our google cloud storage in arrow format, so that the users don't need to process the data.
These tests make sure that they're always available. It also makes sure that their scripts are in sync between S3 and the repo.
This should avoid future issues like #407
| true
|
658,672,736
|
https://api.github.com/repos/huggingface/datasets/issues/407
|
https://github.com/huggingface/datasets/issues/407
| 407
|
MissingBeamOptions for Wikipedia 20200501.en
|
closed
| 4
| 2020-07-16T23:48:03
| 2021-01-12T11:41:16
| 2020-07-17T14:24:28
|
mitchellgordon95
|
[] |
There may or may not be a regression for the pre-processed Wikipedia dataset. This was working fine 10 commits ago (without having Apache Beam available):
```
nlp.load_dataset('wikipedia', "20200501.en", split='train')
```
And now, having pulled master, I get:
```
Downloading and preparing dataset wikipedia/20200501.en (download: 16.99 GiB, generated: 17.07 GiB, total: 34.06 GiB) to /home/hltcoe/mgordon/.cache/huggingface/datasets/wikipedia/20200501.en/1.0.0/76b0b2747b679bb0ee7a1621e50e5a6378477add0c662668a324a5bc07d516dd...
Traceback (most recent call last):
File "scripts/download.py", line 11, in <module>
fire.Fire(download_pretrain)
File "/home/hltcoe/mgordon/.conda/envs/huggingface/lib/python3.6/site-packages/fire/core.py", line 138, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/home/hltcoe/mgordon/.conda/envs/huggingface/lib/python3.6/site-packages/fire/core.py", line 468, in _Fire
target=component.__name__)
File "/home/hltcoe/mgordon/.conda/envs/huggingface/lib/python3.6/site-packages/fire/core.py", line 672, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "scripts/download.py", line 6, in download_pretrain
nlp.load_dataset('wikipedia', "20200501.en", split='train')
File "/exp/mgordon/nlp/src/nlp/load.py", line 534, in load_dataset
save_infos=save_infos,
File "/exp/mgordon/nlp/src/nlp/builder.py", line 460, in download_and_prepare
dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs
File "/exp/mgordon/nlp/src/nlp/builder.py", line 870, in _download_and_prepare
"\n\t`{}`".format(usage_example)
nlp.builder.MissingBeamOptions: Trying to generate a dataset using Apache Beam, yet no Beam Runner or PipelineOptions() has been provided in `load_dataset` or in the builder arguments. For big datasets it has to run on large-scale data processing tools like Dataflow, S
park, etc. More information about Apache Beam runners at https://beam.apache.org/documentation/runners/capability-matrix/
If you really want to run it locally because you feel like the Dataset is small enough, you can use the local beam runner called `DirectRunner` (you may run out of memory).
Example of usage:
`load_dataset('wikipedia', '20200501.en', beam_runner='DirectRunner')`
```
| false
|
658,581,764
|
https://api.github.com/repos/huggingface/datasets/issues/406
|
https://github.com/huggingface/datasets/issues/406
| 406
|
Faster Shuffling?
|
closed
| 7
| 2020-07-16T21:21:53
| 2023-08-16T09:52:39
| 2020-09-07T14:45:25
|
mitchellgordon95
|
[] |
Consider shuffling bookcorpus:
```
dataset = nlp.load_dataset('bookcorpus', split='train')
dataset.shuffle()
```
According to tqdm, this will take around 2.5 hours on my machine to complete (even with the faster version of select from #405). I've also tried with `keep_in_memory=True` and `writer_batch_size=1000`.
But I can also just write the lines to a text file:
```
batch_size = 100000
with open('tmp.txt', 'w+') as out_f:
for i in tqdm(range(0, len(dataset), batch_size)):
batch = dataset[i:i+batch_size]['text']
print("\n".join(batch), file=out_f)
```
Which completes in a couple minutes, followed by `shuf tmp.txt > tmp2.txt` which completes in under a minute. And finally,
```
dataset = nlp.load_dataset('text', data_files='tmp2.txt')
```
Which completes in under 10 minutes. I read up on Apache Arrow this morning, and it seems like the columnar data format is not especially well-suited to shuffling rows, since moving items around requires a lot of book-keeping.
Is shuffle inherently slow, or am I just using it wrong? And if it is slow, would it make sense to try converting the data to a row-based format on disk and then shuffling? (Instead of calling select with a random permutation, as is currently done.)
| false
|
658,580,192
|
https://api.github.com/repos/huggingface/datasets/issues/405
|
https://github.com/huggingface/datasets/pull/405
| 405
|
Make select() faster by batching reads
|
closed
| 0
| 2020-07-16T21:19:45
| 2020-07-17T17:05:44
| 2020-07-17T16:51:26
|
mitchellgordon95
|
[] |
Here's a benchmark:
```
dataset = nlp.load_dataset('bookcorpus', split='train')
start = time.time()
dataset.select(np.arange(1000), reader_batch_size=1, load_from_cache_file=False)
end = time.time()
print(f'{end - start}')
start = time.time()
dataset.select(np.arange(1000), reader_batch_size=1000, load_from_cache_file=False)
end = time.time()
print(f'{end - start}')
```
Without batching, select takes around 1.27 seconds. With batching, it takes around 0.01 seconds. The slowness was upsetting me because dataset.shuffle() was supposed to take ~27 hours for bookcorpus. Now with the fix it takes ~2.5 hours (which still is pretty slow, but I'll open a separate issue for that).
| true
|
658,400,987
|
https://api.github.com/repos/huggingface/datasets/issues/404
|
https://github.com/huggingface/datasets/pull/404
| 404
|
Add seed in metrics
|
closed
| 0
| 2020-07-16T17:27:05
| 2020-07-20T10:12:35
| 2020-07-20T10:12:34
|
lhoestq
|
[] |
With #361 we noticed that some metrics were not deterministic.
In this PR I allow the user to specify numpy's seed when instantiating a metric with `load_metric`.
The seed is set only when `compute` is called, and reset afterwards.
Moreover when calling `compute` with the same metric instance (i.e. same experiment_id), the metric will always return the same results given the same inputs. This is the case even if the seed is was not specified by the user, as the previous seed is going to be reused.
However, instantiating twice a metric (two different experiments) without specifying a seed can create different results.
| true
|
658,325,756
|
https://api.github.com/repos/huggingface/datasets/issues/403
|
https://github.com/huggingface/datasets/pull/403
| 403
|
return python objects instead of arrays by default
|
closed
| 0
| 2020-07-16T15:51:52
| 2020-07-17T11:37:01
| 2020-07-17T11:37:00
|
lhoestq
|
[] |
We were using to_pandas() to convert from arrow types, however it returns numpy arrays instead of python lists.
I fixed it by using to_pydict/to_pylist instead.
Fix #387
It was mentioned in https://github.com/huggingface/transformers/issues/5729
| true
|
658,001,288
|
https://api.github.com/repos/huggingface/datasets/issues/402
|
https://github.com/huggingface/datasets/pull/402
| 402
|
Search qa
|
closed
| 0
| 2020-07-16T09:00:10
| 2020-07-16T14:27:00
| 2020-07-16T14:26:59
|
mariamabarham
|
[] |
add SearchQA dataset
#336
| true
|
657,996,252
|
https://api.github.com/repos/huggingface/datasets/issues/401
|
https://github.com/huggingface/datasets/pull/401
| 401
|
add web_questions
|
closed
| 3
| 2020-07-16T08:54:59
| 2020-08-06T06:16:20
| 2020-08-06T06:16:19
|
mariamabarham
|
[] |
add Web Question dataset
#336
Maybe @patrickvonplaten you can help with the dummy_data structure? it still broken
| true
|
657,975,600
|
https://api.github.com/repos/huggingface/datasets/issues/400
|
https://github.com/huggingface/datasets/pull/400
| 400
|
Web questions
|
closed
| 0
| 2020-07-16T08:28:29
| 2020-07-16T08:50:51
| 2020-07-16T08:42:54
|
mariamabarham
|
[] |
add the WebQuestion dataset
#336
| true
|
657,841,433
|
https://api.github.com/repos/huggingface/datasets/issues/399
|
https://github.com/huggingface/datasets/pull/399
| 399
|
Spelling mistake
|
closed
| 1
| 2020-07-16T04:37:58
| 2020-07-16T06:49:48
| 2020-07-16T06:49:37
|
BlancRay
|
[] |
In "Formatting the dataset" part, "The two toehr modifications..." should be "The two other modifications..." ,the word "other" wrong spelled as "toehr".
| true
|
657,511,962
|
https://api.github.com/repos/huggingface/datasets/issues/398
|
https://github.com/huggingface/datasets/pull/398
| 398
|
Add inline links
|
closed
| 2
| 2020-07-15T17:04:04
| 2020-07-22T10:14:22
| 2020-07-22T10:14:22
|
bharatr21
|
[] |
Add inline links to `Contributing.md`
| true
|
657,510,856
|
https://api.github.com/repos/huggingface/datasets/issues/397
|
https://github.com/huggingface/datasets/pull/397
| 397
|
Add contiguous sharding
|
closed
| 0
| 2020-07-15T17:02:58
| 2020-07-17T16:59:31
| 2020-07-17T16:59:31
|
jarednielsen
|
[] |
This makes dset.shard() play nice with nlp.concatenate_datasets(). When I originally wrote the shard() method, I was thinking about a distributed training scenario, but https://github.com/huggingface/nlp/pull/389 also uses it for splitting the dataset for distributed preprocessing.
Usage:
```
nlp.concatenate_datasets([dset.shard(n, i, contiguous=True) for i in range(n)])
```
| true
|
657,477,952
|
https://api.github.com/repos/huggingface/datasets/issues/396
|
https://github.com/huggingface/datasets/pull/396
| 396
|
Fix memory issue when doing select
|
closed
| 0
| 2020-07-15T16:15:04
| 2020-07-16T08:07:32
| 2020-07-16T08:07:31
|
lhoestq
|
[] |
We were passing the `nlp.Dataset` object to get the hash for the new dataset's file name.
Fix #395
| true
|
657,454,983
|
https://api.github.com/repos/huggingface/datasets/issues/395
|
https://github.com/huggingface/datasets/issues/395
| 395
|
Memory issue when doing select
|
closed
| 1
| 2020-07-15T15:43:38
| 2020-07-16T08:07:31
| 2020-07-16T08:07:31
|
lhoestq
|
[] |
As noticed in #389, the following code loads the entire wikipedia in memory.
```python
import nlp
w = nlp.load_dataset("wikipedia", "20200501.en", split="train")
w.select([0])
```
This is caused by [this line](https://github.com/huggingface/nlp/blob/master/src/nlp/arrow_dataset.py#L626) for some reason, that tries to serialize the function with all the wikipedia data with it.
It's not the case with `.map` or `.filter`.
However functions that are based on `.select` like `.shuffle`, `.shard`, `.train_test_split`, `.sort` are affected.
| false
|
657,425,548
|
https://api.github.com/repos/huggingface/datasets/issues/394
|
https://github.com/huggingface/datasets/pull/394
| 394
|
Remove remaining nested dict
|
closed
| 0
| 2020-07-15T15:05:52
| 2020-07-16T07:39:52
| 2020-07-16T07:39:51
|
mariamabarham
|
[] |
This PR deletes the remaining unnecessary nested dict
#378
| true
|
657,330,911
|
https://api.github.com/repos/huggingface/datasets/issues/393
|
https://github.com/huggingface/datasets/pull/393
| 393
|
Fix extracted files directory for the DownloadManager
|
closed
| 0
| 2020-07-15T12:59:55
| 2020-07-17T17:02:16
| 2020-07-17T17:02:14
|
lhoestq
|
[] |
The cache dir was often cluttered by extracted files because of the download manager.
For downloaded files, we are using the `downloads` directory to make things easier to navigate, but extracted files were still placed at the root of the cache directory. To fix that I changed the directory for extracted files to cache_dir/downloads/extracted.
| true
|
657,313,738
|
https://api.github.com/repos/huggingface/datasets/issues/392
|
https://github.com/huggingface/datasets/pull/392
| 392
|
Style change detection
|
closed
| 0
| 2020-07-15T12:32:14
| 2020-07-21T13:18:36
| 2020-07-17T17:13:23
|
ghomasHudson
|
[] |
Another [PAN task](https://pan.webis.de/clef20/pan20-web/style-change-detection.html). This time about identifying when the style/author changes in documents.
- There's the possibility of adding the [PAN19](https://zenodo.org/record/3577602) and PAN18 style change detection tasks too (these are datasets whose labels are a subset of PAN20's). These would probably make more sense as separate datasets (like wmt is now)
- I've converted the integer 0,1 values to a boolean
- Using manually downloaded data again. This might be changed at some point following the discussion in https://github.com/huggingface/nlp/pull/349.
| true
|
656,956,384
|
https://api.github.com/repos/huggingface/datasets/issues/390
|
https://github.com/huggingface/datasets/pull/390
| 390
|
Concatenate datasets
|
closed
| 6
| 2020-07-14T23:24:37
| 2020-07-22T09:49:58
| 2020-07-22T09:49:58
|
jarednielsen
|
[] |
I'm constructing the "WikiBooks" dataset, which is a concatenation of Wikipedia & BookCorpus. So I implemented the `Dataset.from_concat()` method, which concatenates two datasets with the same schema.
This would also be useful if someone wants to pretrain on a large generic dataset + their own custom dataset. Not in love with the method name, so would love to hear suggestions.
Usage:
```python
from nlp import Dataset, load_dataset
data1, data2 = {"id": [0, 1, 2]}, {"id": [3, 4, 5]}
dset1, dset2 = Dataset.from_dict(data1), Dataset.from_dict(data2)
dset_concat = Dataset.from_concat([dset1, dset2])
print(dset_concat)
# Dataset(schema: {'id': 'int64'}, num_rows: 6)
```
| true
|
656,921,768
|
https://api.github.com/repos/huggingface/datasets/issues/389
|
https://github.com/huggingface/datasets/pull/389
| 389
|
Fix pickling of SplitDict
|
closed
| 11
| 2020-07-14T21:53:39
| 2020-08-04T14:38:10
| 2020-08-04T14:38:10
|
mitchellgordon95
|
[] |
It would be nice to pickle and unpickle Datasets, as done in [this tutorial](https://github.com/patil-suraj/exploring-T5/blob/master/T5_on_TPU.ipynb). Example:
```
wiki = nlp.load_dataset('wikipedia', split='train')
def sentencize(examples):
...
wiki = wiki.map(sentencize, batched=True)
torch.save(wiki, 'sentencized_wiki_dataset.pt')
```
However, upon unpickling the dataset via torch.load(...), this error is raised:
```
ValueError("Cannot add elem. Use .add() instead.")
```
On line [492 of splits.py](https://github.com/huggingface/nlp/blob/master/src/nlp/splits.py#L492). This is because SplitDict subclasses dict, and pickle treats [dicts specially](https://github.com/huggingface/nlp/blob/master/src/nlp/splits.py#L492). Pickle expects access to `dict.__setitem__`, but this is disallowed by the class.
The workaround is to provide an explicit interface for pickle to call when pickling and unpickling, thereby avoiding the use of `__setitem__`.
Testing:
- Manually pickled and unpickled a modified wikipedia dataset.
- Ran `make style`
I would be happy to run any other tests, but I couldn't find any in the contributing guidelines.
| true
|
656,707,497
|
https://api.github.com/repos/huggingface/datasets/issues/388
|
https://github.com/huggingface/datasets/issues/388
| 388
|
🐛 [Dataset] Cannot download wmt14, wmt15 and wmt17
|
closed
| 5
| 2020-07-14T15:36:41
| 2022-10-04T18:01:28
| 2022-10-04T18:01:28
|
SamuelCahyawijaya
|
[
"dataset bug"
] |
1. I try downloading `wmt14`, `wmt15`, `wmt17`, `wmt19` with the following code:
```
nlp.load_dataset('wmt14','de-en')
nlp.load_dataset('wmt15','de-en')
nlp.load_dataset('wmt17','de-en')
nlp.load_dataset('wmt19','de-en')
```
The code runs but the download speed is **extremely slow**, the same behaviour is not observed on `wmt16` and `wmt18`
2. When trying to download `wmt17 zh-en`, I got the following error:
> ConnectionError: Couldn't reach https://storage.googleapis.com/tfdataset-data/downloadataset/uncorpus/UNv1.0.en-zh.tar.gz
| false
|
656,361,357
|
https://api.github.com/repos/huggingface/datasets/issues/387
|
https://github.com/huggingface/datasets/issues/387
| 387
|
Conversion through to_pandas output numpy arrays for lists instead of python objects
|
closed
| 1
| 2020-07-14T06:24:01
| 2020-07-17T11:37:00
| 2020-07-17T11:37:00
|
thomwolf
|
[] |
In a related question, the conversion through to_pandas output numpy arrays for the lists instead of python objects.
Here is an example:
```python
>>> dataset._data.slice(key, 1).to_pandas().to_dict("list")
{'sentence1': ['Amrozi accused his brother , whom he called " the witness " , of deliberately distorting his evidence .'], 'sentence2': ['Referring to him as only " the witness " , Amrozi accused his brother of deliberately distorting his evidence .'], 'label': [1], 'idx': [0], 'input_ids': [array([ 101, 7277, 2180, 5303, 4806, 1117, 1711, 117, 2292,
1119, 1270, 107, 1103, 7737, 107, 117, 1104, 9938,
4267, 12223, 21811, 1117, 2554, 119, 102])], 'token_type_ids': [array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0])], 'attention_mask': [array([1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
1, 1, 1])]}
>>> type(dataset._data.slice(key, 1).to_pandas().to_dict("list")['input_ids'][0])
<class 'numpy.ndarray'>
>>> dataset._data.slice(key, 1).to_pydict()
{'sentence1': ['Amrozi accused his brother , whom he called " the witness " , of deliberately distorting his evidence .'], 'sentence2': ['Referring to him as only " the witness " , Amrozi accused his brother of deliberately distorting his evidence .'], 'label': [1], 'idx': [0], 'input_ids': [[101, 7277, 2180, 5303, 4806, 1117, 1711, 117, 2292, 1119, 1270, 107, 1103, 7737, 107, 117, 1104, 9938, 4267, 12223, 21811, 1117, 2554, 119, 102]], 'token_type_ids': [[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]], 'attention_mask': [[1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]]}
```
| false
|
655,839,067
|
https://api.github.com/repos/huggingface/datasets/issues/386
|
https://github.com/huggingface/datasets/pull/386
| 386
|
Update dataset loading and features - Add TREC dataset
|
closed
| 1
| 2020-07-13T13:10:18
| 2020-07-16T08:17:58
| 2020-07-16T08:17:58
|
thomwolf
|
[] |
This PR:
- add a template for a new dataset script
- update the caching structure so that the path to the cached data files is also a function of the dataset loading script hash. This way when you update a loading script the data will be automatically updated instead of falling back to the previous version (which is usually a outdated). This makes it in particular easier to iterate when writing a new dataset loading script.
- fix a bug in the `ClassLabel` feature and make it more flexible so that its methods `str2int` and `int2str` can also accept list, numpy arrays and PyTorch/TensorFlow tensors.
- add the TREC-6 dataset
| true
|
655,663,997
|
https://api.github.com/repos/huggingface/datasets/issues/385
|
https://github.com/huggingface/datasets/pull/385
| 385
|
Remove unnecessary nested dict
|
closed
| 5
| 2020-07-13T08:46:23
| 2020-07-15T11:27:38
| 2020-07-15T10:03:53
|
mariamabarham
|
[] |
This PR is removing unnecessary nested dictionary used in some datasets. For now the following datasets are updated:
- MLQA
- RACE
Will be adding more if necessary.
#378
| true
|
655,291,201
|
https://api.github.com/repos/huggingface/datasets/issues/383
|
https://github.com/huggingface/datasets/pull/383
| 383
|
Adding the Linguistic Code-switching Evaluation (LinCE) benchmark
|
closed
| 5
| 2020-07-11T22:35:20
| 2020-07-16T16:19:46
| 2020-07-16T16:19:46
|
gaguilar
|
[] |
Hi,
First of all, this library is really cool! Thanks for putting all of this together!
This PR contains the [Linguistic Code-switching Evaluation (LinCE) benchmark](https://ritual.uh.edu/lince). As described in the official website (FAQ):
> 1. Why do we need LinCE?
>LinCE brings 10 code-switching datasets together for 4 tasks and 4 language pairs with 5 leaderboards in a single evaluation platform. We examined each dataset and fixed major issues on the partitions (or even define official partitions) with a comprehensive stratification method (see our paper for more details).
>Besides, we believe that online benchmarks like LinCE bring steady research progress and allow to compare state-of-the-art models at the pace of the progress in NLP. We expect to benefit greatly the code-switching community with this benchmark.
The data comes from social media and here's the summary table of tasks per language pair:
| Language Pairs | LID | POS | NER | SA |
|----------------------------------------|-----|-----|-----|----|
| Spanish-English | ✅ | ✅ | ✅ | ✅ |
| Hindi-English | ✅ | ✅ | ✅ | |
| Modern Standard Arabic-Egyptian Arabic | ✅ | | ✅ | |
| Nepali-English | ✅ | | | |
The tasks are as follows:
* LID: token-level language identification
* POS: part-of-speech tagging
* NER: named entity recognition
* SA: sentiment analysis
With the exception of MSA-EA, the rest of the datasets contain token-level LID labels.
## Usage
For Spanish-English LID, we can load the data as follows:
```
import nlp
data = nlp.load_dataset('./datasets/lince/lince.py', 'lid_spaeng')
for split in data:
print(data[split])
```
Here's the output:
```
Dataset(schema: {'idx': 'int32', 'tokens': 'list<item: string>', 'lid': 'list<item: string>'}, num_rows: 21030)
Dataset(schema: {'idx': 'int32', 'tokens': 'list<item: string>', 'lid': 'list<item: string>'}, num_rows: 3332)
Dataset(schema: {'idx': 'int32', 'tokens': 'list<item: string>', 'lid': 'list<item: string>'}, num_rows: 8289)
```
Here's the list of shortcut names for every dataset available in LinCE:
* `lid_spaeng`
* `lid_hineng`
* `lid_nepeng`
* `lid_msaea`
* `pos_spaeng`
* `pos_hineng`
* `ner_spaeng`
* `ner_hineng`
* `ner_msaea`
* `sa_spaeng`
All the numbers match with Table 3 in the LinCE [paper](https://www.aclweb.org/anthology/2020.lrec-1.223.pdf). Also, note that the MSA-EA datasets use the Persian script while the other datasets use the Roman script.
## Features
Here is how the features look in the case of language identification (LID) tasks:
| LID Feature | Type | Description |
|----------------------|---------------|-------------------------------------------|
| `idx` | `int` | Dataset index of current sentence |
| `tokens` | `list<str>` | List of tokens (string) of a sentence |
| `lid` | `list<str>` | List of LID labels (string) of a sentence |
For part-of-speech (POS) tagging:
| POS Feature | Type | Description |
|----------------------|---------------|-------------------------------------------|
| `idx` | `int` | Dataset index of current sentence |
| `tokens` | `list<str>` | List of tokens (string) of a sentence |
| `lid` | `list<str>` | List of LID labels (string) of a sentence |
| `pos` | `list<str>` | List of POS tags (string) of a sentence |
For named entity recognition (NER):
| NER Feature | Type | Description |
|----------------------|---------------|-------------------------------------------|
| `idx` | `int` | Dataset index of current sentence |
| `tokens` | `list<str>` | List of tokens (string) of a sentence |
| `lid` | `list<str>` | List of LID labels (string) of a sentence |
| `ner` | `list<str>` | List of NER labels (string) of a sentence |
**NOTE**: the MSA-EA NER dataset does not contain the `lid` feature.
For sentiment analysis (SA):
| SA Feature | Type | Description |
|---------------------|-------------|-------------------------------------------|
| `idx` | `int` | Dataset index of current sentence |
| `tokens` | `list<str>` | List of tokens (string) of a sentence |
| `lid` | `list<str>` | List of LID labels (string) of a sentence |
| `sa` | `str` | Sentiment label (string) of a sentence |
| true
|
655,290,482
|
https://api.github.com/repos/huggingface/datasets/issues/382
|
https://github.com/huggingface/datasets/issues/382
| 382
|
1080
|
closed
| 0
| 2020-07-11T22:29:07
| 2020-07-11T22:49:38
| 2020-07-11T22:49:38
|
saq194
|
[] | false
|
|
655,277,119
|
https://api.github.com/repos/huggingface/datasets/issues/381
|
https://github.com/huggingface/datasets/issues/381
| 381
|
NLp
|
closed
| 0
| 2020-07-11T20:50:14
| 2020-07-11T20:50:39
| 2020-07-11T20:50:39
|
Spartanthor
|
[] | false
|
|
655,226,316
|
https://api.github.com/repos/huggingface/datasets/issues/378
|
https://github.com/huggingface/datasets/issues/378
| 378
|
[dataset] Structure of MLQA seems unecessary nested
|
closed
| 2
| 2020-07-11T15:16:08
| 2020-07-15T16:17:20
| 2020-07-15T16:17:20
|
thomwolf
|
[] |
The features of the MLQA dataset comprise several nested dictionaries with a single element inside (for `questions` and `ids`): https://github.com/huggingface/nlp/blob/master/datasets/mlqa/mlqa.py#L90-L97
Should we keep this @mariamabarham @patrickvonplaten? Was this added for compatibility with tfds?
```python
features=nlp.Features(
{
"context": nlp.Value("string"),
"questions": nlp.features.Sequence({"question": nlp.Value("string")}),
"answers": nlp.features.Sequence(
{"text": nlp.Value("string"), "answer_start": nlp.Value("int32"),}
),
"ids": nlp.features.Sequence({"idx": nlp.Value("string")})
```
| false
|
655,215,790
|
https://api.github.com/repos/huggingface/datasets/issues/377
|
https://github.com/huggingface/datasets/issues/377
| 377
|
Iyy!!!
|
closed
| 0
| 2020-07-11T14:11:07
| 2020-07-11T14:30:51
| 2020-07-11T14:30:51
|
ajinomoh
|
[] | false
|
|
655,047,826
|
https://api.github.com/repos/huggingface/datasets/issues/376
|
https://github.com/huggingface/datasets/issues/376
| 376
|
to_pandas conversion doesn't always work
|
closed
| 2
| 2020-07-10T21:33:31
| 2022-10-04T18:05:39
| 2022-10-04T18:05:39
|
thomwolf
|
[] |
For some complex nested types, the conversion from Arrow to python dict through pandas doesn't seem to be possible.
Here is an example using the official SQUAD v2 JSON file.
This example was found while investigating #373.
```python
>>> squad = load_dataset('json', data_files={nlp.Split.TRAIN: ["./train-v2.0.json"]}, download_mode=nlp.GenerateMode.FORCE_REDOWNLOAD, version="1.0.0", field='data')
>>> squad['train']
Dataset(schema: {'title': 'string', 'paragraphs': 'list<item: struct<qas: list<item: struct<question: string, id: string, answers: list<item: struct<text: string, answer_start: int64>>, is_impossible: bool, plausible_answers: list<item: struct<text: string, answer_start: int64>>>>, context: string>>'}, num_rows: 442)
>>> squad['train'][0]
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/thomwolf/Documents/GitHub/datasets/src/nlp/arrow_dataset.py", line 589, in __getitem__
format_kwargs=self._format_kwargs,
File "/Users/thomwolf/Documents/GitHub/datasets/src/nlp/arrow_dataset.py", line 529, in _getitem
outputs = self._unnest(self._data.slice(key, 1).to_pandas().to_dict("list"))
File "pyarrow/array.pxi", line 559, in pyarrow.lib._PandasConvertible.to_pandas
File "pyarrow/table.pxi", line 1367, in pyarrow.lib.Table._to_pandas
File "/Users/thomwolf/miniconda2/envs/datasets/lib/python3.7/site-packages/pyarrow/pandas_compat.py", line 766, in table_to_blockmanager
blocks = _table_to_blocks(options, table, categories, ext_columns_dtypes)
File "/Users/thomwolf/miniconda2/envs/datasets/lib/python3.7/site-packages/pyarrow/pandas_compat.py", line 1101, in _table_to_blocks
list(extension_columns.keys()))
File "pyarrow/table.pxi", line 881, in pyarrow.lib.table_to_blocks
File "pyarrow/error.pxi", line 105, in pyarrow.lib.check_status
pyarrow.lib.ArrowNotImplementedError: Not implemented type for Arrow list to pandas: struct<qas: list<item: struct<question: string, id: string, answers: list<item: struct<text: string, answer_start: int64>>, is_impossible: bool, plausible_answers: list<item: struct<text: string, answer_start: int64>>>>, context: string>
```
cc @lhoestq would we have a way to detect this from the schema maybe?
Here is the schema for this pretty complex JSON:
```python
>>> squad['train'].schema
title: string
paragraphs: list<item: struct<qas: list<item: struct<question: string, id: string, answers: list<item: struct<text: string, answer_start: int64>>, is_impossible: bool, plausible_answers: list<item: struct<text: string, answer_start: int64>>>>, context: string>>
child 0, item: struct<qas: list<item: struct<question: string, id: string, answers: list<item: struct<text: string, answer_start: int64>>, is_impossible: bool, plausible_answers: list<item: struct<text: string, answer_start: int64>>>>, context: string>
child 0, qas: list<item: struct<question: string, id: string, answers: list<item: struct<text: string, answer_start: int64>>, is_impossible: bool, plausible_answers: list<item: struct<text: string, answer_start: int64>>>>
child 0, item: struct<question: string, id: string, answers: list<item: struct<text: string, answer_start: int64>>, is_impossible: bool, plausible_answers: list<item: struct<text: string, answer_start: int64>>>
child 0, question: string
child 1, id: string
child 2, answers: list<item: struct<text: string, answer_start: int64>>
child 0, item: struct<text: string, answer_start: int64>
child 0, text: string
child 1, answer_start: int64
child 3, is_impossible: bool
child 4, plausible_answers: list<item: struct<text: string, answer_start: int64>>
child 0, item: struct<text: string, answer_start: int64>
child 0, text: string
child 1, answer_start: int64
child 1, context: string
```
| false
|
655,023,307
|
https://api.github.com/repos/huggingface/datasets/issues/375
|
https://github.com/huggingface/datasets/issues/375
| 375
|
TypeError when computing bertscore
|
closed
| 2
| 2020-07-10T20:37:44
| 2022-06-01T15:15:59
| 2022-06-01T15:15:59
|
willywsm1013
|
[] |
Hi,
I installed nlp 0.3.0 via pip, and my python version is 3.7.
When I tried to compute bertscore with the code:
```
import nlp
bertscore = nlp.load_metric('bertscore')
# load hyps and refs
...
print (bertscore.compute(hyps, refs, lang='en'))
```
I got the following error.
```
Traceback (most recent call last):
File "bert_score_evaluate.py", line 16, in <module>
print (bertscore.compute(hyps, refs, lang='en'))
File "/home/willywsm/anaconda3/envs/torcher/lib/python3.7/site-packages/nlp/metric.py", line 200, in compute
output = self._compute(predictions=predictions, references=references, **metrics_kwargs)
File "/home/willywsm/anaconda3/envs/torcher/lib/python3.7/site-packages/nlp/metrics/bertscore/fb176889831bf0ce995ed197edc94b2e9a83f647a869bb8c9477dbb2d04d0f08/bertscore.py", line 105, in _compute
hashcode = bert_score.utils.get_hash(model_type, num_layers, idf, rescale_with_baseline)
TypeError: get_hash() takes 3 positional arguments but 4 were given
```
It seems like there is something wrong with get_hash() function?
| false
|
654,895,066
|
https://api.github.com/repos/huggingface/datasets/issues/374
|
https://github.com/huggingface/datasets/pull/374
| 374
|
Add dataset post processing for faiss indexes
|
closed
| 2
| 2020-07-10T16:25:59
| 2020-07-13T13:44:03
| 2020-07-13T13:44:01
|
lhoestq
|
[] |
# Post processing of datasets for faiss indexes
Now that we can have datasets with embeddings (see `wiki_pr` for example), we can allow users to load the dataset + get the Faiss index that comes with it to do nearest neighbors queries.
## Implementation proposition
- Faiss indexes have to be added to the `nlp.Dataset` object, and therefore it's in a different scope that what are doing the `_split_generators` and `_generate_examples` methods of `nlp.DatasetBuilder`. Therefore I added a new method for post processing of the `nlp.Dataset` object called `_post_process` (name could change)
- The role of `_post_process` is to apply dataset transforms (filter/map etc.) or indexing functions (add_faiss_index) to modify/enrich the `nlp.Dataset` object. It is not part of the `download_and_prepare` process (that is focused on arrow files creation) so the post processing is run inside the `as_dataset` method.
- `_post_process` can generate new files (cached files from dataset transforms or serialized faiss indexes) and their names are defined by `_post_processing_resources`
- as we know what are the post processing resources, we can download them automatically from google storage instead of computing them if they're available (as we do for arrow files)
I'd happy to discuss these choices !
## The `wiki_dpr` index
It takes 1h20 and ~7GB of memory to compute. The final index is 1.42GB and takes ~1.5GB of memory.
This is pretty cool given that a naive flat index would take 170GB of memory to store the 21M vectors of dim 768.
I couldn't use directly the Faiss `index_factory` as I needed to set the metric to inner product.
## Example of usage
```python
import nlp
dset = nlp.load_dataset(
"wiki_dpr",
"psgs_w100_with_nq_embeddings",
split="train",
with_index=True
)
print(len(dset), dset.list_indexes()) # (21015300, ['embeddings'])
```
(it also works with the dataset configuration without the embeddings because I added the index file in google storage for this one too)
## Demo
You can also check a demo on google colab that shows how to use it with the DPRQuestionEncoder from transformers:
https://colab.research.google.com/drive/1FakNU8W5EPMcWff7iP1H6REg3XSS0YLp?usp=sharing
| true
|
654,845,133
|
https://api.github.com/repos/huggingface/datasets/issues/373
|
https://github.com/huggingface/datasets/issues/373
| 373
|
Segmentation fault when loading local JSON dataset as of #372
|
closed
| 11
| 2020-07-10T15:04:25
| 2022-10-04T18:05:47
| 2022-10-04T18:05:47
|
vegarab
|
[] |
The last issue was closed (#369) once the #372 update was merged. However, I'm still not able to load a SQuAD formatted JSON file. Instead of the previously recorded pyarrow error, I now get a segmentation fault.
```
dataset = nlp.load_dataset('json', data_files={nlp.Split.TRAIN: ["./datasets/train-v2.0.json"]}, field='data')
```
causes
```
Using custom data configuration default
Downloading and preparing dataset json/default (download: Unknown size, generated: Unknown size, total: Unknown size) to /home/XXX/.cache/huggingface/datasets/json/default/0.0.0...
0 tables [00:00, ? tables/s]Segmentation fault (core dumped)
```
where `./datasets/train-v2.0.json` is downloaded directly from https://rajpurkar.github.io/SQuAD-explorer/.
This is consistent with other SQuAD-formatted JSON files.
When attempting to load the dataset again, I get the following:
```
Using custom data configuration default
Traceback (most recent call last):
File "dataloader.py", line 6, in <module>
'json', data_files={nlp.Split.TRAIN: ["./datasets/train-v2.0.json"]}, field='data')
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/nlp/load.py", line 524, in load_dataset
save_infos=save_infos,
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/nlp/builder.py", line 382, in download_and_prepare
with incomplete_dir(self._cache_dir) as tmp_data_dir:
File "/home/XXX/.conda/envs/torch/lib/python3.7/contextlib.py", line 112, in __enter__
return next(self.gen)
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/nlp/builder.py", line 368, in incomplete_dir
os.makedirs(tmp_dir)
File "/home/XXX/.conda/envs/torch/lib/python3.7/os.py", line 223, in makedirs
mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/home/XXX/.cache/huggingface/datasets/json/default/0.0.0.incomplete'
```
(Not sure if you wanted this in the previous issue #369 or not as it was closed.)
| false
|
654,774,420
|
https://api.github.com/repos/huggingface/datasets/issues/372
|
https://github.com/huggingface/datasets/pull/372
| 372
|
Make the json script more flexible
|
closed
| 0
| 2020-07-10T13:15:15
| 2020-07-10T14:52:07
| 2020-07-10T14:52:06
|
thomwolf
|
[] |
Fix https://github.com/huggingface/nlp/issues/359
Fix https://github.com/huggingface/nlp/issues/369
JSON script now can accept JSON files containing a single dict with the records as a list in one attribute to the dict (previously it only accepted JSON files containing records as rows of dicts in the file).
In this case, you should indicate using `field=XXX` the name of the field in the JSON structure which contains the records you want to load. The records can be a dict of lists or a list of dicts.
E.g. to load the SQuAD dataset JSON (without using the `squad` specific dataset loading script), in which the data rows are in the `data` field of the JSON dict, you can do:
```python
from nlp import load_dataset
dataset = load_dataset('json', data_files='/PATH/TO/JSON', field='data')
```
| true
|
654,668,242
|
https://api.github.com/repos/huggingface/datasets/issues/371
|
https://github.com/huggingface/datasets/pull/371
| 371
|
Fix cached file path for metrics with different config names
|
closed
| 1
| 2020-07-10T10:02:24
| 2020-07-10T13:45:22
| 2020-07-10T13:45:20
|
lhoestq
|
[] |
The config name was not taken into account to build the cached file path.
It should fix #368
| true
|
654,304,193
|
https://api.github.com/repos/huggingface/datasets/issues/370
|
https://github.com/huggingface/datasets/pull/370
| 370
|
Allow indexing Dataset via np.ndarray
|
closed
| 1
| 2020-07-09T19:43:15
| 2020-07-10T14:05:44
| 2020-07-10T14:05:43
|
jarednielsen
|
[] | true
|
|
654,186,890
|
https://api.github.com/repos/huggingface/datasets/issues/369
|
https://github.com/huggingface/datasets/issues/369
| 369
|
can't load local dataset: pyarrow.lib.ArrowInvalid: straddling object straddles two block boundaries
|
closed
| 2
| 2020-07-09T16:16:53
| 2020-12-15T23:07:22
| 2020-07-10T14:52:06
|
vegarab
|
[
"dataset bug"
] |
Trying to load a local SQuAD-formatted dataset (from a JSON file, about 60MB):
```
dataset = nlp.load_dataset(path='json', data_files={nlp.Split.TRAIN: ["./path/to/file.json"]})
```
causes
```
Traceback (most recent call last):
File "dataloader.py", line 9, in <module>
["./path/to/file.json"]})
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/nlp/load.py", line 524, in load_dataset
save_infos=save_infos,
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/nlp/builder.py", line 432, in download_and_prepare
dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/nlp/builder.py", line 483, in _download_and_prepare
self._prepare_split(split_generator, **prepare_split_kwargs)
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/nlp/builder.py", line 719, in _prepare_split
for key, table in utils.tqdm(generator, unit=" tables", leave=False):
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/tqdm/std.py", line 1129, in __iter__
for obj in iterable:
File "/home/XXX/.conda/envs/torch/lib/python3.7/site-packages/nlp/datasets/json/88c1bc5c68489f7eda549ed05a5a738527c613b3e7a4ee3524d9d233353a949b/json.py", line 53, in _generate_tables
file, read_options=self.config.pa_read_options, parse_options=self.config.pa_parse_options,
File "pyarrow/_json.pyx", line 191, in pyarrow._json.read_json
File "pyarrow/error.pxi", line 85, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: straddling object straddles two block boundaries (try to increase block size?)
```
I haven't been able to find any reports of this specific pyarrow error here or elsewhere.
| false
|
654,087,251
|
https://api.github.com/repos/huggingface/datasets/issues/368
|
https://github.com/huggingface/datasets/issues/368
| 368
|
load_metric can't acquire lock anymore
|
closed
| 1
| 2020-07-09T14:04:09
| 2020-07-10T13:45:20
| 2020-07-10T13:45:20
|
ydshieh
|
[] |
I can't load metric (glue) anymore after an error in a previous run. I even removed the whole cache folder `/home/XXX/.cache/huggingface/`, and the issue persisted. What are the steps to fix this?
Traceback (most recent call last):
File "/home/XXX/miniconda3/envs/ML-DL-py-3.7/lib/python3.7/site-packages/nlp/metric.py", line 101, in __init__
self.filelock.acquire(timeout=1)
File "/home/XXX/miniconda3/envs/ML-DL-py-3.7/lib/python3.7/site-packages/filelock.py", line 278, in acquire
raise Timeout(self._lock_file)
filelock.Timeout: The file lock '/home/XXX/.cache/huggingface/metrics/glue/1.0.0/1-glue-0.arrow.lock' could not be acquired.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "examples_huggingface_nlp.py", line 268, in <module>
main()
File "examples_huggingface_nlp.py", line 242, in main
dataset, metric = get_dataset_metric(glue_task)
File "examples_huggingface_nlp.py", line 77, in get_dataset_metric
metric = nlp.load_metric('glue', glue_config, experiment_id=1)
File "/home/XXX/miniconda3/envs/ML-DL-py-3.7/lib/python3.7/site-packages/nlp/load.py", line 440, in load_metric
**metric_init_kwargs,
File "/home/XXX/miniconda3/envs/ML-DL-py-3.7/lib/python3.7/site-packages/nlp/metric.py", line 104, in __init__
"Cannot acquire lock, caching file might be used by another process, "
ValueError: Cannot acquire lock, caching file might be used by another process, you should setup a unique 'experiment_id' for this run.
I0709 15:54:41.008838 139854118430464 filelock.py:318] Lock 139852058030936 released on /home/XXX/.cache/huggingface/metrics/glue/1.0.0/1-glue-0.arrow.lock
| false
|
654,012,984
|
https://api.github.com/repos/huggingface/datasets/issues/367
|
https://github.com/huggingface/datasets/pull/367
| 367
|
Update Xtreme to add PAWS-X es
|
closed
| 0
| 2020-07-09T12:14:37
| 2020-07-09T12:37:11
| 2020-07-09T12:37:10
|
mariamabarham
|
[] |
This PR adds the `PAWS-X.es` in the Xtreme dataset #362
| true
|
653,954,896
|
https://api.github.com/repos/huggingface/datasets/issues/366
|
https://github.com/huggingface/datasets/pull/366
| 366
|
Add quora dataset
|
closed
| 2
| 2020-07-09T10:34:22
| 2020-07-13T17:35:21
| 2020-07-13T17:35:21
|
ghomasHudson
|
[] |
Added the [Quora question pairs dataset](https://www.quora.com/q/quoradata/First-Quora-Dataset-Release-Question-Pairs).
Implementation Notes:
- I used the original version provided on the quora website. There's also a [Kaggle competition](https://www.kaggle.com/c/quora-question-pairs) which has a nice train/test split but I can't find an easy way to download it.
- I've made the questions into a list:
```python
{
"questions": [
{"id":0, "text": "Is this an example question?"},
{"id":1, "text": "Is this a sample question?"},
],
...
}
```
rather than:
```python
{
"question1": "Is this an example question?",
"question2": "Is this a sample question?"
"qid0": 0
"qid1": 1
...
}
```
Not sure if this was the right call.
- Can't find a good citation for this dataset
| true
|
653,845,964
|
https://api.github.com/repos/huggingface/datasets/issues/365
|
https://github.com/huggingface/datasets/issues/365
| 365
|
How to augment data ?
|
closed
| 6
| 2020-07-09T07:52:37
| 2020-07-10T09:12:07
| 2020-07-10T08:22:15
|
astariul
|
[] |
Is there any clean way to augment data ?
For now my work-around is to use batched map, like this :
```python
def aug(samples):
# Simply copy the existing data to have x2 amount of data
for k, v in samples.items():
samples[k].extend(v)
return samples
dataset = dataset.map(aug, batched=True)
```
| false
|
653,821,597
|
https://api.github.com/repos/huggingface/datasets/issues/364
|
https://github.com/huggingface/datasets/pull/364
| 364
|
add MS MARCO dataset
|
closed
| 7
| 2020-07-09T07:11:19
| 2020-08-06T06:15:49
| 2020-08-06T06:15:48
|
mariamabarham
|
[] |
This PR adds the MS MARCO dataset as requested in this issue #336. MS mARCO has multiple task including:
- Passage and Document Retrieval
- Keyphrase Extraction
- QA and NLG
This PR only adds the 2 versions of the QA and NLG task dataset which was realeased with the original paper here https://arxiv.org/pdf/1611.09268.pdf
Tests are failing because of the dummy data. I tried to fix it without success. Can you please have a look at it? @patrickvonplaten , @lhoestq
| true
|
653,821,172
|
https://api.github.com/repos/huggingface/datasets/issues/363
|
https://github.com/huggingface/datasets/pull/363
| 363
|
Adding support for generic multi dimensional tensors and auxillary image data for multimodal datasets
|
closed
| 23
| 2020-07-09T07:10:30
| 2020-08-24T09:59:35
| 2020-08-24T09:59:35
|
eltoto1219
|
[] |
nlp/features.py:
The main factory class is MultiArray, every single time this class is called, a corresponding pyarrow extension array and type class is generated (and added to the list of globals for future use) for a given root data type and set of dimensions/shape. I provide examples on working with this in datasets/lxmert_pretraining_beta/test_multi_array.py
src/nlp/arrow_writer.py
I had to add a method for writing batches that include extension array types because despite having a unique class for each multidimensional array shape, pyarrow is unable to write any other "array-like" data class to a batch object unless it is of the type pyarrow.ExtensionType. The problem in this is that when writing multiple batches, the order of the schema and data to be written get mixed up (where the pyarrow datatype in the schema only refers to as ExtensionAray, but each ExtensionArray subclass has a different shape) ... possibly I am missing something here and would be grateful if anyone else could take a look!
datasets/lxmert_pretraining_beta/lxmert_pretraining_beta.py & datasets/lxmert_pretraining_beta/to_arrow_data.py:
I have begun adding the data from the original LXMERT paper (https://arxiv.org/abs/1908.07490) hosted here: (https://github.com/airsplay/lxmert). The reason I am not pulling from the source of truth for each individual dataset is because it seems that there will also need to be functionality to aggregate multimodal datasets to create a pre-training corpus (:sleepy: ).
For now, this is just being used to test and run edge-cases for the MultiArray feature, so ive labeled it as "beta_pretraining"!
(still working on the pretraining, just wanted to push out the new functionality sooner than later)
| true
|
653,766,245
|
https://api.github.com/repos/huggingface/datasets/issues/362
|
https://github.com/huggingface/datasets/issues/362
| 362
|
[dateset subset missing] xtreme paws-x
|
closed
| 1
| 2020-07-09T05:04:54
| 2020-07-09T12:38:42
| 2020-07-09T12:38:42
|
cosmeowpawlitan
|
[] |
I tried nlp.load_dataset('xtreme', 'PAWS-X.es') but get the value error
It turns out that the subset for Spanish is missing
https://github.com/google-research-datasets/paws/tree/master/pawsx
| false
|
653,757,376
|
https://api.github.com/repos/huggingface/datasets/issues/361
|
https://github.com/huggingface/datasets/issues/361
| 361
|
🐛 [Metrics] ROUGE is non-deterministic
|
closed
| 8
| 2020-07-09T04:39:37
| 2022-09-09T15:20:55
| 2020-07-20T23:48:37
|
astariul
|
[] |
If I run the ROUGE metric 2 times, with same predictions / references, the scores are slightly different.
Refer to [this Colab notebook](https://colab.research.google.com/drive/1wRssNXgb9ldcp4ulwj-hMJn0ywhDOiDy?usp=sharing) for reproducing the problem.
Example of F-score for ROUGE-1, ROUGE-2, ROUGE-L in 2 differents run :
> ['0.3350', '0.1470', '0.2329']
['0.3358', '0.1451', '0.2332']
---
Why ROUGE is not deterministic ?
| false
|
653,687,176
|
https://api.github.com/repos/huggingface/datasets/issues/360
|
https://github.com/huggingface/datasets/issues/360
| 360
|
[Feature request] Add dataset.ragged_map() function for many-to-many transformations
|
closed
| 2
| 2020-07-09T01:04:43
| 2020-07-09T19:31:51
| 2020-07-09T19:31:51
|
jarednielsen
|
[] |
`dataset.map()` enables one-to-one transformations. Input one example and output one example. This is helpful for tokenizing and cleaning individual lines.
`dataset.filter()` enables one-to-(one-or-none) transformations. Input one example and output either zero/one example. This is helpful for removing portions from the dataset.
However, some dataset transformations are many-to-many. Consider constructing BERT training examples from a dataset of sentences, where you map `["a", "b", "c"] -> ["a[SEP]b", "a[SEP]c", "b[SEP]c", "c[SEP]b", ...]`
I propose a more general `ragged_map()` method that takes in a batch of examples of length `N` and return a batch of examples `M`. This is different from the `map(batched=True)` method, which takes examples of length `N` and returns a batch of length `N`, processing individual examples in parallel. I don't have a clear vision of how this would be implemented efficiently and lazily, but would love to hear the community's feedback on this.
My specific use case is creating an end-to-end ELECTRA data pipeline. I would like to take the raw WikiText data and generate training examples from this using the `ragged_map()` method, then export to TFRecords and train quickly. This would be a reproducible pipeline with no bash scripts. Currently I'm relying on scripts like https://github.com/google-research/electra/blob/master/build_pretraining_dataset.py, which are less general.
| false
|
653,656,279
|
https://api.github.com/repos/huggingface/datasets/issues/359
|
https://github.com/huggingface/datasets/issues/359
| 359
|
ArrowBasedBuilder _prepare_split parse_schema breaks on nested structures
|
closed
| 4
| 2020-07-08T23:24:05
| 2020-07-10T14:52:06
| 2020-07-10T14:52:06
|
timothyjlaurent
|
[] |
I tried using the Json dataloader to load some JSON lines files. but get an exception in the parse_schema function.
```
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
<ipython-input-23-9aecfbee53bd> in <module>
55 from nlp import load_dataset
56
---> 57 ds = load_dataset("../text2struct/model/dataset_builder.py", data_files=rel_datafiles)
58
59
~/.virtualenvs/inv-text2struct/lib/python3.6/site-packages/nlp/load.py in load_dataset(path, name, version, data_dir, data_files, split, cache_dir, download_config, download_mode, ignore_verifications, save_infos, **config_kwargs)
522 download_mode=download_mode,
523 ignore_verifications=ignore_verifications,
--> 524 save_infos=save_infos,
525 )
526
~/.virtualenvs/inv-text2struct/lib/python3.6/site-packages/nlp/builder.py in download_and_prepare(self, download_config, download_mode, ignore_verifications, save_infos, try_from_hf_gcs, dl_manager, **download_and_prepare_kwargs)
430 verify_infos = not save_infos and not ignore_verifications
431 self._download_and_prepare(
--> 432 dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs
433 )
434 # Sync info
~/.virtualenvs/inv-text2struct/lib/python3.6/site-packages/nlp/builder.py in _download_and_prepare(self, dl_manager, verify_infos, **prepare_split_kwargs)
481 try:
482 # Prepare split will record examples associated to the split
--> 483 self._prepare_split(split_generator, **prepare_split_kwargs)
484 except OSError:
485 raise OSError("Cannot find data file. " + (self.manual_download_instructions or ""))
~/.virtualenvs/inv-text2struct/lib/python3.6/site-packages/nlp/builder.py in _prepare_split(self, split_generator)
736 schema_dict[field.name] = Value(str(field.type))
737
--> 738 parse_schema(writer.schema, features)
739 self.info.features = Features(features)
740
~/.virtualenvs/inv-text2struct/lib/python3.6/site-packages/nlp/builder.py in parse_schema(schema, schema_dict)
734 parse_schema(field.type.value_type, schema_dict[field.name])
735 else:
--> 736 schema_dict[field.name] = Value(str(field.type))
737
738 parse_schema(writer.schema, features)
<string> in __init__(self, dtype, id, _type)
~/.virtualenvs/inv-text2struct/lib/python3.6/site-packages/nlp/features.py in __post_init__(self)
55
56 def __post_init__(self):
---> 57 self.pa_type = string_to_arrow(self.dtype)
58
59 def __call__(self):
~/.virtualenvs/inv-text2struct/lib/python3.6/site-packages/nlp/features.py in string_to_arrow(type_str)
32 if str(type_str + "_") not in pa.__dict__:
33 raise ValueError(
---> 34 f"Neither {type_str} nor {type_str + '_'} seems to be a pyarrow data type. "
35 f"Please make sure to use a correct data type, see: "
36 f"https://arrow.apache.org/docs/python/api/datatypes.html#factory-functions"
ValueError: Neither list<item: string> nor list<item: string>_ seems to be a pyarrow data type. Please make sure to use a correct data type, see: https://arrow.apache.org/docs/python/api/datatypes.html#factory-functions
```
If I create the dataset imperatively, using a pyarrow table, the dataset is created correctly. If I override the `_prepare_split` method to avoid calling the validate schema, the dataset can load as well.
| false
|
653,645,121
|
https://api.github.com/repos/huggingface/datasets/issues/358
|
https://github.com/huggingface/datasets/pull/358
| 358
|
Starting to add some real doc
|
closed
| 1
| 2020-07-08T22:53:03
| 2020-07-14T09:58:17
| 2020-07-14T09:58:15
|
thomwolf
|
[] |
Adding a lot of documentation for:
- load a dataset
- explore the dataset object
- process data with the dataset
- add a new dataset script
- share a dataset script
- full package reference
This version of the doc can be explored here: https://2219-250213286-gh.circle-artifacts.com/0/docs/_build/html/index.html
Also:
- fix a bug in `train_test_split`
- update the `csv` script
- add a verbose argument to the dataset processing methods
Still missing:
- doc for the metrics
- how to directly upload a community provided dataset with the CLI
- clean up more docstrings
- add the `features` argument to `load_dataset` (should be another PR)
| true
|
653,642,292
|
https://api.github.com/repos/huggingface/datasets/issues/357
|
https://github.com/huggingface/datasets/pull/357
| 357
|
Add hashes to cnn_dailymail
|
closed
| 2
| 2020-07-08T22:45:21
| 2020-07-13T14:16:38
| 2020-07-13T14:16:38
|
jbragg
|
[] |
The URL hashes are helpful for comparing results from other sources.
| true
|
653,537,388
|
https://api.github.com/repos/huggingface/datasets/issues/356
|
https://github.com/huggingface/datasets/pull/356
| 356
|
Add text dataset
|
closed
| 0
| 2020-07-08T19:21:53
| 2020-07-10T14:19:03
| 2020-07-10T14:19:03
|
jarednielsen
|
[] |
Usage:
```python
from nlp import load_dataset
dset = load_dataset("text", data_files="/path/to/file.txt")["train"]
```
I created a dummy_data.zip which contains three files: `train.txt`, `test.txt`, `dev.txt`. Each of these contains two lines. It passes
```bash
RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_text
```
but I would like a second set of eyes to ensure I did it right.
| true
|
653,451,013
|
https://api.github.com/repos/huggingface/datasets/issues/355
|
https://github.com/huggingface/datasets/issues/355
| 355
|
can't load SNLI dataset
|
closed
| 3
| 2020-07-08T16:54:14
| 2020-07-18T05:15:57
| 2020-07-15T07:59:01
|
jxmorris12
|
[] |
`nlp` seems to load `snli` from some URL based on nlp.stanford.edu. This subdomain is frequently down -- including right now, when I'd like to load `snli` in a Colab notebook, but can't.
Is there a plan to move these datasets to huggingface servers for a more stable solution?
Btw, here's the stack trace:
```
File "/content/nlp/src/nlp/builder.py", line 432, in download_and_prepare
dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs
File "/content/nlp/src/nlp/builder.py", line 466, in _download_and_prepare
split_generators = self._split_generators(dl_manager, **split_generators_kwargs)
File "/content/nlp/src/nlp/datasets/snli/e417f6f2e16254938d977a17ed32f3998f5b23e4fcab0f6eb1d28784f23ea60d/snli.py", line 76, in _split_generators
dl_dir = dl_manager.download_and_extract(_DATA_URL)
File "/content/nlp/src/nlp/utils/download_manager.py", line 217, in download_and_extract
return self.extract(self.download(url_or_urls))
File "/content/nlp/src/nlp/utils/download_manager.py", line 156, in download
lambda url: cached_path(url, download_config=self._download_config,), url_or_urls,
File "/content/nlp/src/nlp/utils/py_utils.py", line 190, in map_nested
return function(data_struct)
File "/content/nlp/src/nlp/utils/download_manager.py", line 156, in <lambda>
lambda url: cached_path(url, download_config=self._download_config,), url_or_urls,
File "/content/nlp/src/nlp/utils/file_utils.py", line 198, in cached_path
local_files_only=download_config.local_files_only,
File "/content/nlp/src/nlp/utils/file_utils.py", line 356, in get_from_cache
raise ConnectionError("Couldn't reach {}".format(url))
ConnectionError: Couldn't reach https://nlp.stanford.edu/projects/snli/snli_1.0.zip
```
| false
|
653,357,617
|
https://api.github.com/repos/huggingface/datasets/issues/354
|
https://github.com/huggingface/datasets/pull/354
| 354
|
More faiss control
|
closed
| 1
| 2020-07-08T14:45:20
| 2020-07-09T09:54:54
| 2020-07-09T09:54:51
|
lhoestq
|
[] |
Allow users to specify a faiss index they created themselves, as sometimes indexes can be composite for examples
| true
|
653,250,611
|
https://api.github.com/repos/huggingface/datasets/issues/353
|
https://github.com/huggingface/datasets/issues/353
| 353
|
[Dataset requests] New datasets for Text Classification
|
open
| 12
| 2020-07-08T12:17:58
| 2025-04-05T09:28:15
| null |
thomwolf
|
[
"help wanted",
"dataset request"
] |
We are missing a few datasets for Text Classification which is an important field.
Namely, it would be really nice to add:
- [x] TREC-6 dataset (see here for instance: https://pytorchnlp.readthedocs.io/en/latest/source/torchnlp.datasets.html#torchnlp.datasets.trec_dataset) **[done]**
- #386
- [x] Yelp-5
- #1315
- [x] Movie review (Movie Review (MR) dataset [156]) **[done (same as rotten_tomatoes)]**
- [x] SST (Stanford Sentiment Treebank) **[include in glue]**
- #1934
- [ ] Multi-Perspective Question Answering (MPQA) dataset **[require authentication (indeed manual download)]**
- [x] Amazon. This is a popular corpus of product reviews collected from the Amazon website [159]. It contains labels for both binary classification and multi-class (5-class) classification
- #791
- #1389
- [x] 20 Newsgroups. The 20 Newsgroups dataset **[done]**
- #410
- [x] Sogou News dataset **[done]**
- #450
- [x] Reuters news. The Reuters-21578 dataset [165] **[done]**
- #471
- [x] DBpedia. The DBpedia dataset [170]
- #1116
- [ ] Ohsumed. The Ohsumed collection [171] is a subset of the MEDLINE database
- [ ] EUR-Lex. The EUR-Lex dataset
- [x] WOS. The Web Of Science (WOS) dataset **[done]**
- #424
- [ ] PubMed. PubMed [173]
- [x] TREC-QA: TREC-6 + TREC-50
- See above: TREC-6 dataset
- [x] Quora. The Quora dataset [180]
- #366
All these datasets are cited in https://arxiv.org/abs/2004.03705
| false
|
653,128,883
|
https://api.github.com/repos/huggingface/datasets/issues/352
|
https://github.com/huggingface/datasets/pull/352
| 352
|
🐛[BugFix]fix seqeval
|
closed
| 7
| 2020-07-08T09:12:12
| 2020-07-16T08:26:46
| 2020-07-16T08:26:46
|
AlongWY
|
[] |
Fix seqeval process labels such as 'B', 'B-ARGM-LOC'
| true
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.