language
stringclasses 1
value | owner
stringlengths 2
15
| repo
stringlengths 2
21
| sha
stringlengths 45
45
| message
stringlengths 7
36.3k
| path
stringlengths 1
199
| patch
stringlengths 15
102k
| is_multipart
bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | ce44b6ab241c85ab6e7454af6c9ad2ed86485406.json | Resolve some eslint warnings | packages/ember-template-compiler/lib/plugins/assert-against-attrs.ts | @@ -55,7 +55,7 @@ export default function assertAgainstAttrs(env: EmberASTPluginEnvironment): ASTP
PathExpression(node: AST.PathExpression): AST.Node | void {
if (isAttrs(node, stack[stack.length - 1])) {
- let path = b.path(node.original.substr(6)) as AST.PathExpression;
+ let path = b.path(node.original.substr(6));
assert(
`Using {{attrs}} to reference named arguments is not supported. {{attrs.${ | true |
Other | emberjs | ember.js | 6a9954389a4461ffc7da992fdb5eac1ffd1fa8ac.json | Avoid an 'as any' cast | packages/@ember/-internals/routing/lib/ext/controller.ts | @@ -244,8 +244,13 @@ ControllerMixin.reopen({
replaceRoute(...args: string[]) {
deprecateTransitionMethods('controller', 'replaceRoute');
// target may be either another controller or a router
- let target = get(this, 'target') as any;
- let method = target.replaceRoute || target.replaceWith;
+ let target = get(this, 'target');
+
+ // SAFETY: We can't actually assert that this is a full Controller or Router since some tests
+ // mock out an object that only has the single method. Since this is deprecated, I think it's
+ // ok to be a little less than proper here.
+ let method = (target as Controller).replaceRoute ?? (target as Router).replaceWith;
+
return method.apply(target, prefixRouteNameArg(this, args));
},
}); | true |
Other | emberjs | ember.js | 6a9954389a4461ffc7da992fdb5eac1ffd1fa8ac.json | Avoid an 'as any' cast | packages/@ember/controller/index.d.ts | @@ -7,6 +7,7 @@ export default class Controller {
set<T>(key: string, value: T): void;
setProperties(props: { [key: string]: any }): void;
transitionToRoute(...args: unknown[]): unknown;
+ replaceRoute(...args: unknown[]): unknown;
_qpDelegate: unknown;
}
| true |
Other | emberjs | ember.js | 575892ba8623ca24f67ee3024070ac4f7f704abf.json | Resolve comment that no longer applies | packages/@ember/-internals/routing/lib/services/router.ts | @@ -337,9 +337,6 @@ export default class RouterService extends Service {
// *do not* account for this being `undefined`.
routeName as string,
models,
- // UNSAFE: downstream consumers treat this as `QueryParam`, which the
- // type system here *correctly* reports as incorrect, because it may be
- // just an empty object.
queryParams,
true /* fromRouterService */
); | false |
Other | emberjs | ember.js | 0ff7e435dc2028940ff1c9b0e7fd6129624407f2.json | Resolve failing tests | packages/@ember/-internals/routing/lib/ext/controller.ts | @@ -2,7 +2,6 @@ import { get } from '@ember/-internals/metal';
import { getOwner } from '@ember/-internals/owner';
import Controller from '@ember/controller';
import ControllerMixin from '@ember/controller/lib/controller_mixin';
-import { assert } from '@ember/debug';
import { Router } from '../..';
import { deprecateTransitionMethods, prefixRouteNameArg } from '../utils';
@@ -173,8 +172,12 @@ ControllerMixin.reopen({
// target may be either another controller or a router
let target = get(this, 'target');
- assert('controller or router', target instanceof Controller || target instanceof Router);
- let method = target instanceof Controller ? target.transitionToRoute : target.transitionTo;
+
+ // SAFETY: We can't actually assert that this is a full Controller or Router since some tests
+ // mock out an object that only has the single method. Since this is deprecated, I think it's
+ // ok to be a little less than proper here.
+ let method = (target as Controller).transitionToRoute ?? (target as Router).transitionTo;
+
return method.apply(target, prefixRouteNameArg(this, args));
},
| true |
Other | emberjs | ember.js | 0ff7e435dc2028940ff1c9b0e7fd6129624407f2.json | Resolve failing tests | packages/@ember/-internals/routing/tests/system/route_test.js | @@ -3,7 +3,6 @@ import { runDestroy, buildOwner, moduleFor, AbstractTestCase } from 'internal-te
import Service, { service } from '@ember/service';
import { Object as EmberObject } from '@ember/-internals/runtime';
import EmberRoute from '../../lib/system/route';
-import { defineProperty } from '../../../metal';
import ObjectProxy from '@ember/-internals/runtime/lib/system/object_proxy';
let route, routeOne, routeTwo, lookupHash;
@@ -55,9 +54,6 @@ moduleFor(
let owner = buildOwner(ownerOptions);
setOwner(route, owner);
- // Override the computed property by redefining it
- defineProperty(route, '_qp', null, null);
-
assert.equal(route.model({ post_id: 1 }), post);
assert.equal(route.findModel('post', 1), post, '#findModel returns the correct post');
| true |
Other | emberjs | ember.js | ffcdb9fc8256da573ee8ba17eae3e6f747ded2a4.json | Fix failing lints | packages/@ember/-internals/routing/lib/system/route.ts | @@ -56,6 +56,11 @@ export type QueryParamMeta = {
};
};
+type RouteTransitionState = TransitionState<Route> & {
+ fullQueryParams?: Record<string, unknown>;
+ queryParamsFor?: Record<string, Record<string, unknown>>;
+};
+
export const ROUTE_CONNECTIONS = new WeakMap();
const RENDER = (symbol('render') as unknown) as string;
@@ -2121,7 +2126,7 @@ type PartialRenderOptions = Partial<
Pick<RenderOptions, 'into' | 'outlet' | 'controller' | 'model'>
>;
-export function getFullQueryParams(router: EmberRouter, state: TransitionState<Route>) {
+export function getFullQueryParams(router: EmberRouter, state: RouteTransitionState) {
if (state.fullQueryParams) {
return state.fullQueryParams;
}
@@ -2144,7 +2149,7 @@ export function getFullQueryParams(router: EmberRouter, state: TransitionState<R
return fullQueryParamsState;
}
-function getQueryParamsFor(route: Route, state: TransitionState<Route>) {
+function getQueryParamsFor(route: Route, state: RouteTransitionState) {
state.queryParamsFor = state.queryParamsFor || {};
let name = route.fullRouteName;
| true |
Other | emberjs | ember.js | ffcdb9fc8256da573ee8ba17eae3e6f747ded2a4.json | Fix failing lints | packages/@ember/object/type-tests/computed/expand-properties.test.ts | @@ -1,5 +1,6 @@
import { expandProperties } from '@ember/object/computed';
+// eslint-disable-next-line no-console
expandProperties('{foo}.bar.{baz}', (arg: string) => console.log(arg));
// @ts-expect-error a callback is required | true |
Other | emberjs | ember.js | ffcdb9fc8256da573ee8ba17eae3e6f747ded2a4.json | Fix failing lints | packages/@ember/object/type-tests/evented/on.test.ts | @@ -4,6 +4,7 @@ import { expectTypeOf } from 'expect-type';
class Job {
logCompleted = on('completed', function () {
+ // eslint-disable-next-line no-console
console.log('Job completed!');
});
} | true |
Other | emberjs | ember.js | ffcdb9fc8256da573ee8ba17eae3e6f747ded2a4.json | Fix failing lints | packages/@ember/object/type-tests/events/index.test.ts | @@ -5,10 +5,12 @@ import { on } from '@ember/object/evented';
class Job extends EmberObject {
logStartOrUpdate = on('started', 'updated', () => {
+ // eslint-disable-next-line no-console
console.log('Job updated!');
});
logCompleted = on('completed', () => {
+ // eslint-disable-next-line no-console
console.log('Job completed!');
});
} | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/compat/dependent-key-compat.test.ts | @@ -5,8 +5,8 @@ expectTypeOf(dependentKeyCompat).toMatchTypeOf<PropertyDecorator>();
// Example (without irrelevant details) from https://api.emberjs.com/ember/3.18/functions/@ember%2Fobject%2Fcompat/dependentKeyCompat
class Person {
- firstName!: string;
- lastName!: string;
+ declare firstName: string;
+ declare lastName: string;
@dependentKeyCompat
get fullName() { | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed.test.ts | @@ -1,4 +1,7 @@
import { computed } from '@ember/object';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(computed('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
declare firstName: string; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/alias.test.ts | @@ -1,4 +1,7 @@
import { alias } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(alias('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@alias('foo') alias: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/and.test.ts | @@ -1,4 +1,7 @@
import { and } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(and('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@and('foo') and: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/bool.test.ts | @@ -1,5 +1,9 @@
import { bool } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(bool('foo')).toEqualTypeOf<PropertyDecorator>();
+
class Foo {
@bool('foo') declare bool: boolean;
| true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/collect.test.ts | @@ -1,5 +1,9 @@
import { collect } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(collect('foo')).toEqualTypeOf<PropertyDecorator>();
+
class Foo {
@collect('foo') declare collect: unknown[];
@collect('foo', 'bar', 'baz') declare collect2: unknown[]; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/deprecating-alias.test.ts | @@ -1,5 +1,16 @@
import { deprecatingAlias } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(
+ deprecatingAlias('foo', {
+ id: 'test',
+ until: '4.0.0',
+ for: 'testing',
+ since: { enabled: '3.0.0' },
+ })
+).toEqualTypeOf<PropertyDecorator>();
+
class Foo {
@deprecatingAlias('foo', {
id: 'test', | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/empty.test.ts | @@ -1,4 +1,7 @@
import { empty } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(empty('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@empty('foo') declare empty: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/equal.test.ts | @@ -1,4 +1,7 @@
import { equal } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(equal('foo', 'bar')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@equal('foo', 'bar') declare equal: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/filter-by.test.ts | @@ -1,4 +1,7 @@
import { filterBy } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(filterBy('foo', 'key')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@filterBy('foo', 'key', 'value') | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/filter.test.ts | @@ -1,4 +1,7 @@
import { filter } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(filter('foo', (item: unknown) => Boolean(item))).toEqualTypeOf<PropertyDecorator>();
class Foo {
@filter('foo', (item: unknown) => Boolean(item)) | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/gt.test.ts | @@ -1,4 +1,7 @@
import { gt } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(gt('foo', 10)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@gt('foo', 10) declare gt: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/gte.test.ts | @@ -1,4 +1,7 @@
import { gte } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(gte('foo', 10)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@gte('foo', 10) declare gte: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/intersect.test.ts | @@ -1,4 +1,7 @@
import { intersect } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(intersect('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@intersect('foo') declare intersect: unknown[]; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/lt.test.ts | @@ -1,4 +1,7 @@
import { lt } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(lt('foo', 10)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@lt('foo', 10) declare lt: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/lte.test.ts | @@ -1,4 +1,7 @@
import { lte } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(lte('foo', 10)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@lte('foo', 10) declare lte: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/map-by.test.ts | @@ -1,4 +1,7 @@
import { mapBy } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(mapBy('foo', 'key')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@mapBy('foo', 'key') | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/map.test.ts | @@ -1,4 +1,7 @@
import { map } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(map('foo', (item: unknown) => Boolean(item))).toEqualTypeOf<PropertyDecorator>();
class Foo {
@map('foo', (item: unknown) => Boolean(item)) | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/match.test.ts | @@ -1,4 +1,7 @@
import { match } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(match('foo', /^foo$/)).toEqualTypeOf<PropertyDecorator>();
class Foo {
@match('foo', /^foo$/) declare match: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/max.test.ts | @@ -1,4 +1,7 @@
import { max } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(max('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@max('foo') max: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/min.test.ts | @@ -1,4 +1,7 @@
import { min } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(min('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@min('foo') min: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/none.test.ts | @@ -1,4 +1,7 @@
import { none } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(none('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@none('foo') none: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/not-empty.test.ts | @@ -1,4 +1,7 @@
import { notEmpty } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(notEmpty('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@notEmpty('foo') notEmpty: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/not.test.ts | @@ -1,4 +1,7 @@
import { not } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(not('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@not('foo') not: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/one-way.test.ts | @@ -1,4 +1,7 @@
import { oneWay } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(oneWay('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@oneWay('foo') oneWay: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/or.test.ts | @@ -1,4 +1,7 @@
import { or } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(or('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@or('foo') or: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/read-only.test.ts | @@ -1,4 +1,7 @@
import { readOnly } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(readOnly('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@readOnly('foo') readOnly: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/reads.test.ts | @@ -1,4 +1,7 @@
import { reads } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(reads('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@reads('foo') reads: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/set-diff.test.ts | @@ -1,4 +1,7 @@
import { setDiff } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(setDiff('foo', 'bar')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@setDiff('foo', 'bar') declare setDiff: boolean; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/sort.test.ts | @@ -1,4 +1,7 @@
import { sort } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(sort('foo', 'bar')).toEqualTypeOf<PropertyDecorator>();
class Foo {
// With sortKey | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/sum.test.ts | @@ -1,4 +1,7 @@
import { sum } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(sum('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@sum('foo') sum: unknown; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/union.test.ts | @@ -1,4 +1,7 @@
import { union } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(union('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@union('foo') declare union: unknown[]; | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/uniq-by.test.ts | @@ -1,4 +1,7 @@
import { uniqBy } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(uniqBy('foo', 'bar')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@uniqBy('foo', 'key') | true |
Other | emberjs | ember.js | 0f952599c132a1f01b38559594648c8373d69f4f.json | Improve some type tests | packages/@ember/object/type-tests/computed/uniq.test.ts | @@ -1,4 +1,7 @@
import { uniq } from '@ember/object/computed';
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(uniq('foo')).toEqualTypeOf<PropertyDecorator>();
class Foo {
@uniq('foo') declare uniq: unknown[]; | true |
Other | emberjs | ember.js | 32eb0fde8d40c80438e601cb56be620ef1cf53f2.json | Improve return type of getProperties | packages/@ember/-internals/metal/lib/decorator.ts | @@ -19,7 +19,7 @@ export type ElementDescriptor = [
descriptor: DecoratorPropertyDescriptor
];
-export function isElementDescriptor(args: any[]): args is ElementDescriptor {
+export function isElementDescriptor(args: unknown[]): args is ElementDescriptor {
let [maybeTarget, maybeKey, maybeDesc] = args;
return ( | true |
Other | emberjs | ember.js | 32eb0fde8d40c80438e601cb56be620ef1cf53f2.json | Improve return type of getProperties | packages/@ember/-internals/metal/lib/get_properties.ts | @@ -31,13 +31,10 @@ import { get } from './property_get';
@return {Object}
@public
*/
-function getProperties<L extends string[]>(obj: object, list: L): { [Key in L[number]]: unknown };
-function getProperties<L extends string[]>(
- obj: object,
- ...list: L
-): { [Key in L[number]]: unknown };
-function getProperties(obj: object, keys?: string[]): object {
- let ret = {};
+function getProperties<L extends string[]>(obj: object, list: L): Record<L[number], unknown>;
+function getProperties<L extends string[]>(obj: object, ...list: L): Record<L[number], unknown>;
+function getProperties<L extends string[]>(obj: object, keys?: L): Record<L[number], unknown> {
+ let ret = {} as Record<L[number], unknown>;
let propertyNames = arguments;
let i = 1;
| true |
Other | emberjs | ember.js | 9354e508ee6fb0a8c2e881aab81dd4ab2e676861.json | Simplify computed types | packages/@ember/-internals/metal/lib/computed.ts | @@ -37,36 +37,30 @@ import {
PROPERTY_DID_CHANGE,
} from './property_events';
-export type ComputedPropertyGetterFunction<T> = (this: any, key: string) => T;
-export type ComputedPropertySetterFunction<T> = (
+export type ComputedPropertyGetterFunction = (this: any, key: string) => unknown;
+export type ComputedPropertySetterFunction = (
this: any,
key: string,
- newVal: T,
- oldVal: T | undefined
-) => T;
+ newVal: unknown,
+ oldVal: unknown
+) => unknown;
-export interface ComputedPropertyGetterObj<T> {
- get(this: any, key: string): T;
+export interface ComputedPropertyGetterObj {
+ get(this: any, key: string): unknown;
}
-export interface ComputedPropertySetterObj<T> {
- set(this: any, key: string, value: T): T;
+export interface ComputedPropertySetterObj {
+ set(this: any, key: string, value: unknown): unknown;
}
-export type ComputedPropertyObj<Get, Set> =
- | ComputedPropertyGetterObj<Get>
- | ComputedPropertySetterObj<Set>
- | (ComputedPropertyGetterObj<Get> & ComputedPropertySetterObj<Set>);
-
-export type ComputedPropertyGetter<T> =
- | ComputedPropertyGetterFunction<T>
- | ComputedPropertyGetterObj<T>;
-export type ComputedPropertySetter<T> =
- | ComputedPropertySetterFunction<T>
- | ComputedPropertySetterObj<T>;
-
-export type ComputedPropertyCallback<Get, Set = Get> =
- | ComputedPropertyGetterFunction<Get>
- | ComputedPropertyObj<Get, Set>;
+export type ComputedPropertyObj =
+ | ComputedPropertyGetterObj
+ | ComputedPropertySetterObj
+ | (ComputedPropertyGetterObj & ComputedPropertySetterObj);
+
+export type ComputedPropertyGetter = ComputedPropertyGetterFunction | ComputedPropertyGetterObj;
+export type ComputedPropertySetter = ComputedPropertySetterFunction | ComputedPropertySetterObj;
+
+export type ComputedPropertyCallback = ComputedPropertyGetterFunction | ComputedPropertyObj;
/**
@module @ember/object
@@ -271,14 +265,14 @@ function noop(): void {}
@class ComputedProperty
@public
*/
-export class ComputedProperty<Get, Set = Get> extends ComputedDescriptor {
+export class ComputedProperty extends ComputedDescriptor {
_readOnly = false;
protected _hasConfig = false;
- _getter?: ComputedPropertyGetterFunction<Get> = undefined;
- _setter?: ComputedPropertySetterFunction<Set> = undefined;
+ _getter?: ComputedPropertyGetterFunction = undefined;
+ _setter?: ComputedPropertySetterFunction = undefined;
- constructor(args: Array<string | ComputedPropertyCallback<Get, Set>>) {
+ constructor(args: Array<string | ComputedPropertyCallback>) {
super();
let maybeConfig = args[args.length - 1];
@@ -298,8 +292,7 @@ export class ComputedProperty<Get, Set = Get> extends ComputedDescriptor {
this._getter = config;
} else {
- const objectConfig = config as ComputedPropertyGetterObj<Get> &
- ComputedPropertySetterObj<Set>;
+ const objectConfig = config as ComputedPropertyGetterObj & ComputedPropertySetterObj;
assert(
'computed expects a function or an object as last argument.',
typeof objectConfig === 'object' && !Array.isArray(objectConfig)
@@ -354,7 +347,7 @@ export class ComputedProperty<Get, Set = Get> extends ComputedDescriptor {
let { get, set } = propertyDesc!;
if (get !== undefined) {
- this._getter = get as ComputedPropertyGetterFunction<Get>;
+ this._getter = get as ComputedPropertyGetterFunction;
}
if (set !== undefined) {
@@ -393,7 +386,7 @@ export class ComputedProperty<Get, Set = Get> extends ComputedDescriptor {
this._dependentKeys = args;
}
- get(obj: object, keyName: string): any {
+ get(obj: object, keyName: string): unknown {
let meta = metaFor(obj);
let tagMeta = tagMetaFor(obj);
@@ -445,7 +438,7 @@ export class ComputedProperty<Get, Set = Get> extends ComputedDescriptor {
return ret;
}
- set(obj: object, keyName: string, value: any): any {
+ set(obj: object, keyName: string, value: unknown): unknown {
if (this._readOnly) {
this._throwReadOnlyError(obj, keyName);
}
@@ -516,9 +509,9 @@ export class ComputedProperty<Get, Set = Get> extends ComputedDescriptor {
throw new EmberError(`Cannot set read-only property "${keyName}" on object: ${inspect(obj)}`);
}
- _set(obj: object, keyName: string, value: Set, meta: Meta): any {
+ _set(obj: object, keyName: string, value: unknown, meta: Meta): unknown {
let hadCachedValue = meta.revisionFor(keyName) !== undefined;
- let cachedValue = meta.valueFor(keyName) as Set;
+ let cachedValue = meta.valueFor(keyName);
let ret;
let { _setter } = this;
@@ -554,8 +547,8 @@ export class ComputedProperty<Get, Set = Get> extends ComputedDescriptor {
}
}
-class AutoComputedProperty<Get, Set = Get> extends ComputedProperty<Get, Set> {
- get(obj: object, keyName: string): any {
+class AutoComputedProperty extends ComputedProperty {
+ get(obj: object, keyName: string): unknown {
let meta = metaFor(obj);
let tagMeta = tagMetaFor(obj);
@@ -600,12 +593,10 @@ class AutoComputedProperty<Get, Set = Get> extends ComputedProperty<Get, Set> {
}
}
-export type ComputedDecorator<Get, Set = Get> = Decorator &
- PropertyDecorator &
- ComputedDecoratorImpl<Get, Set>;
+export type ComputedDecorator = Decorator & PropertyDecorator & ComputedDecoratorImpl;
// TODO: This class can be svelted once `meta` has been deprecated
-class ComputedDecoratorImpl<Get, Set = Get> extends Function {
+class ComputedDecoratorImpl extends Function {
/**
Call on a computed property to set it into read-only mode. When in this
mode the computed property will throw an error when set.
@@ -647,7 +638,7 @@ class ComputedDecoratorImpl<Get, Set = Get> extends Function {
@public
*/
readOnly(this: Decorator) {
- let desc = descriptorForDecorator(this) as ComputedProperty<Get, Set>;
+ let desc = descriptorForDecorator(this) as ComputedProperty;
assert(
'Computed properties that define a setter using the new syntax cannot be read-only',
!(desc._setter && (desc._setter as unknown) !== (desc._getter as unknown))
@@ -702,8 +693,8 @@ class ComputedDecoratorImpl<Get, Set = Get> extends Function {
@chainable
@public
*/
- meta(this: Decorator, meta?: any): any {
- let prop = descriptorForDecorator(this) as ComputedProperty<Get, Set>;
+ meta(this: Decorator, meta?: unknown): unknown {
+ let prop = descriptorForDecorator(this) as ComputedProperty;
if (arguments.length === 0) {
return prop._meta || {};
@@ -717,20 +708,17 @@ class ComputedDecoratorImpl<Get, Set = Get> extends Function {
// addons such as ember-macro-helpers that use it.
/** @internal */
get _getter() {
- return (descriptorForDecorator(this) as ComputedProperty<Get, Set>)._getter;
+ return (descriptorForDecorator(this) as ComputedProperty)._getter;
}
// TODO: Refactor this, this is an internal API only
/** @internal */
set enumerable(value: boolean) {
- (descriptorForDecorator(this) as ComputedProperty<Get, Set>).enumerable = value;
+ (descriptorForDecorator(this) as ComputedProperty).enumerable = value;
}
}
-type ComputedDecoratorKeysAndConfig<Get, Set = Get> = [
- ...keys: string[],
- config: ComputedPropertyCallback<Get, Set>
-];
+type ComputedDecoratorKeysAndConfig = [...keys: string[], config: ComputedPropertyCallback];
/**
This helper returns a new property descriptor that wraps the passed
@@ -880,18 +868,14 @@ export function computed(
descriptor: DecoratorPropertyDescriptor
): DecoratorPropertyDescriptor;
// @computed with keys only
-export function computed<Get, Set = Get>(...dependentKeys: string[]): ComputedDecorator<Get, Set>;
+export function computed(...dependentKeys: string[]): ComputedDecorator;
// @computed with keys and config
-export function computed<Get, Set = Get>(
- ...args: ComputedDecoratorKeysAndConfig<Get, Set>
-): ComputedDecorator<Get, Set>;
+export function computed(...args: ComputedDecoratorKeysAndConfig): ComputedDecorator;
// @computed with config only
-export function computed<Get, Set = Get>(
- callback: ComputedPropertyCallback<Get, Set>
-): ComputedDecorator<Get, Set>;
-export function computed<Get, Set = Get>(
- ...args: ElementDescriptor | string[] | ComputedDecoratorKeysAndConfig<Get, Set>
-): ComputedDecorator<Get, Set> | DecoratorPropertyDescriptor {
+export function computed(callback: ComputedPropertyCallback): ComputedDecorator;
+export function computed(
+ ...args: ElementDescriptor | string[] | ComputedDecoratorKeysAndConfig
+): ComputedDecorator | DecoratorPropertyDescriptor {
assert(
`@computed can only be used directly as a native decorator. If you're using tracked in classic classes, add parenthesis to call it like a function: computed()`,
!(isElementDescriptor(args.slice(0, 3)) && args.length === 5 && (args[4] as unknown) === true)
@@ -901,24 +885,24 @@ export function computed<Get, Set = Get>(
let decorator = makeComputedDecorator(
new ComputedProperty([]),
ComputedDecoratorImpl
- ) as ComputedDecorator<Get, Set>;
+ ) as ComputedDecorator;
return decorator(args[0], args[1], args[2]);
}
return makeComputedDecorator(
- new ComputedProperty(args as (string | ComputedPropertyObj<Get, Set>)[]),
+ new ComputedProperty(args as (string | ComputedPropertyObj)[]),
ComputedDecoratorImpl
- ) as ComputedDecorator<Get, Set>;
+ ) as ComputedDecorator;
}
-export function autoComputed<Get, Set = Get>(
- ...config: [ComputedPropertyObj<Get, Set>]
-): ComputedDecorator<Get, Set> | DecoratorPropertyDescriptor {
+export function autoComputed(
+ ...config: [ComputedPropertyObj]
+): ComputedDecorator | DecoratorPropertyDescriptor {
return makeComputedDecorator(
new AutoComputedProperty(config),
ComputedDecoratorImpl
- ) as ComputedDecorator<Get, Set>;
+ ) as ComputedDecorator;
}
/** | true |
Other | emberjs | ember.js | 9354e508ee6fb0a8c2e881aab81dd4ab2e676861.json | Simplify computed types | packages/@ember/-internals/metal/lib/mixin.ts | @@ -68,12 +68,12 @@ function concatenatedMixinProperties(
return concats;
}
-function giveDecoratorSuper<Get, Set>(
+function giveDecoratorSuper(
key: string,
- decorator: ComputedDecorator<Get, Set>,
- property: ComputedProperty<Get, Set> | true,
+ decorator: ComputedDecorator,
+ property: ComputedProperty | true,
descs: { [key: string]: any }
-): ComputedDecorator<Get, Set> {
+): ComputedDecorator {
if (property === true) {
return decorator;
}
@@ -87,7 +87,7 @@ function giveDecoratorSuper<Get, Set>(
let superDesc = descs[key];
// Check to see if the super property is a decorator first, if so load its descriptor
- let superProperty: ComputedProperty<Get, Set> | true | undefined =
+ let superProperty: ComputedProperty | true | undefined =
typeof superDesc === 'function' ? descriptorForDecorator(superDesc) : superDesc;
if (superProperty === undefined || superProperty === true) {
@@ -100,14 +100,14 @@ function giveDecoratorSuper<Get, Set>(
return decorator;
}
- let get = wrap(originalGetter, superGetter) as ComputedPropertyGetter<Get>;
+ let get = wrap(originalGetter, superGetter) as ComputedPropertyGetter;
let set;
let originalSetter = property._setter;
let superSetter = superProperty._setter;
if (superSetter !== undefined) {
if (originalSetter !== undefined) {
- set = wrap(originalSetter, superSetter) as ComputedPropertySetter<Set>;
+ set = wrap(originalSetter, superSetter) as ComputedPropertySetter;
} else {
// If the super property has a setter, we default to using it no matter what.
// This is clearly very broken and weird, but it's what was here so we have
@@ -131,14 +131,14 @@ function giveDecoratorSuper<Get, Set>(
{
get,
set,
- } as ComputedPropertyObj<Get, Set>,
+ } as ComputedPropertyObj,
]);
newProperty._readOnly = property._readOnly;
newProperty._meta = property._meta;
newProperty.enumerable = property.enumerable;
- return makeComputedDecorator(newProperty, ComputedProperty) as ComputedDecorator<Get, Set>;
+ return makeComputedDecorator(newProperty, ComputedProperty) as ComputedDecorator;
}
return decorator;
@@ -282,7 +282,7 @@ function mergeMixins(
}
}
-function mergeProps<Get, Set>(
+function mergeProps(
meta: Meta,
props: { [key: string]: unknown },
descs: { [key: string]: unknown },
@@ -336,8 +336,8 @@ function mergeProps<Get, Set>(
// Wrap descriptor function to implement _super() if needed
descs[key] = giveDecoratorSuper(
key,
- value as ComputedDecorator<Get, Set>,
- desc as ComputedProperty<Get, Set>,
+ value as ComputedDecorator,
+ desc as ComputedProperty,
descs
);
values[key] = undefined; | true |
Other | emberjs | ember.js | 76789a81888695ff03efa0c335d7abc7469194b8.json | Fix lint error | packages/@ember/object/type-tests/ember-object.test.ts | @@ -99,7 +99,6 @@ Person.reopen({ fullName: 6 });
// NOTE: This is marked as @internal and will not be publicly available
Person.reopenClass({ fullName: 6 });
-
class MyComponent extends EmberObject {
foo = 'bar';
| false |
Other | emberjs | ember.js | c2814c0eff10ecb0060aa726fea80595e248d4b0.json | Use internal version of alias and expandProperties | packages/@ember/object/computed.d.ts | @@ -1,6 +1,6 @@
import { DeprecationOptions } from '@ember/debug';
-export function alias(dependentKey: string): PropertyDecorator;
+export { alias, expandProperties } from '@ember/-internals/metal';
export function and(dependentKey: string, ...additionalDependentKeys: string[]): PropertyDecorator;
@@ -20,8 +20,6 @@ export function empty(dependentKey: string): PropertyDecorator;
export function equal(dependentKey: string, value: any): PropertyDecorator;
-export function expandProperties(pattern: string, callback: (expanded: string) => void): void;
-
export function filter(
dependentKey: string,
callback: (value: unknown, index: number, array: unknown[]) => boolean | false |
Other | emberjs | ember.js | 4c9a7da54e6187df7abf98b3f6a75ddd63b563a4.json | Improve JS type handling | tsconfig.json | @@ -21,7 +21,9 @@
"newLine": "LF",
"noEmit": true,
- "allowJs": false,
+
+ "allowJs": true,
+ "checkJs": false,
"paths": {
"@glimmer/*": ["../node_modules/@glimmer/*"], | false |
Other | emberjs | ember.js | eeb2fe25bf4d91abbb5555787594a57066a06cdd.json | Remove extra exports | packages/@ember/-internals/runtime/index.d.ts | @@ -5,15 +5,6 @@ import Evented from './types/evented';
export const TargetActionSupport: any;
export function isArray(arr: any): boolean;
-export const ControllerMixin: any;
-
-export function deprecatingAlias(
- name: string,
- opts: {
- id: string;
- until: string;
- }
-): any;
// The public version doesn't export some deprecated methods.
// However, these are still used internally. Returning `any` is | false |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/component-addon/index.js | @@ -4,9 +4,8 @@ const path = require('path');
const stringUtil = require('ember-cli-string-utils');
const getPathOption = require('ember-cli-get-component-path-option');
const normalizeEntityName = require('ember-cli-normalize-entity-name');
-const useEditionDetector = require('../edition-detector');
-module.exports = useEditionDetector({
+module.exports = {
description: 'Generates a component.',
fileMapTokens: function () {
@@ -73,4 +72,4 @@ module.exports = useEditionDetector({
path: getPathOption(options),
};
},
-});
+}; | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/component-addon/native-files/__root__/__path__/__name__.js | @@ -1 +0,0 @@
-export { default } from '<%= modulePath %>';
\ No newline at end of file | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/component-class-addon/index.js | @@ -4,9 +4,8 @@ const path = require('path');
const stringUtil = require('ember-cli-string-utils');
const getPathOption = require('ember-cli-get-component-path-option');
const normalizeEntityName = require('ember-cli-normalize-entity-name');
-const useEditionDetector = require('../edition-detector');
-module.exports = useEditionDetector({
+module.exports = {
description: 'Generates a component class.',
fileMapTokens: function () {
@@ -51,4 +50,4 @@ module.exports = useEditionDetector({
path: getPathOption(options),
};
},
-});
+}; | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/component-class-addon/native-files/__root__/__path__/__name__.js | @@ -1 +0,0 @@
-export { default } from '<%= modulePath %>';
\ No newline at end of file | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/controller/files/__root__/__path__/__name__.js | @@ -1,4 +1,4 @@
import Controller from '@ember/controller';
-export default Controller.extend({
-});
+export default class <%= classifiedModuleName %>Controller extends Controller {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/controller/index.js | @@ -1,10 +1,8 @@
'use strict';
-const useEditionDetector = require('../edition-detector');
-
-module.exports = useEditionDetector({
+module.exports = {
description: 'Generates a controller.',
normalizeEntityName: function (entityName) {
return entityName.replace(/\.js$/, ''); //Prevent generation of ".js.js" files
},
-});
+}; | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/controller/native-files/__root__/__path__/__name__.js | @@ -1,4 +0,0 @@
-import Controller from '@ember/controller';
-
-export default class <%= classifiedModuleName %>Controller extends Controller {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/route/files/__root__/__path__/__name__.js | @@ -1,11 +1,11 @@
import Route from '@ember/routing/route';
-export default Route.extend({<% if (hasDynamicSegment) {%>
+export default class <%= classifiedModuleName %>Route extends Route {<% if (hasDynamicSegment) {%>
model(params) {
/**
* This route was generated with a dynamic segment. Implement data loading
* based on that dynamic segment here in the model hook.
*/
return params;
- },<%}%>
-});
+ }<%}%>
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/route/index.js | @@ -5,9 +5,8 @@ const path = require('path');
const chalk = require('chalk');
const stringUtil = require('ember-cli-string-utils');
const EmberRouterGenerator = require('ember-router-generator');
-const useEditionDetector = require('../edition-detector');
-module.exports = useEditionDetector({
+module.exports = {
description: 'Generates a route and a template, and registers the route with the router.',
availableOptions: [
@@ -122,7 +121,7 @@ module.exports = useEditionDetector({
normalizeEntityName: function (entityName) {
return entityName.replace(/\.js$/, ''); //Prevent generation of ".js.js" files
},
-});
+};
function updateRouter(action, options) {
let entity = options.entity; | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/route/native-files/__root__/__path__/__name__.js | @@ -1,11 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class <%= classifiedModuleName %>Route extends Route {<% if (hasDynamicSegment) {%>
- model(params) {
- /**
- * This route was generated with a dynamic segment. Implement data loading
- * based on that dynamic segment here in the model hook.
- */
- return params;
- }<%}%>
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/route/native-files/__root__/__templatepath__/__templatename__.hbs | @@ -1,2 +0,0 @@
-<% if (addTitle) {%>{{page-title "<%= routeName %>"}}
-<%}%>{{outlet}}
\ No newline at end of file | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/service/files/__root__/__path__/__name__.js | @@ -1,4 +1,4 @@
import Service from '@ember/service';
-export default Service.extend({
-});
+export default class <%= classifiedModuleName %>Service extends Service {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/service/index.js | @@ -1,10 +1,8 @@
'use strict';
-const useEditionDetector = require('../edition-detector');
-
-module.exports = useEditionDetector({
+module.exports = {
description: 'Generates a service.',
normalizeEntityName: function (entityName) {
return entityName.replace(/\.js$/, ''); //Prevent generation of ".js.js" files
},
-});
+}; | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | blueprints/service/native-files/__root__/__path__/__name__.js | @@ -1,4 +0,0 @@
-import Service from '@ember/service';
-
-export default class <%= classifiedModuleName %>Service extends Service {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/component-class-addon-test.js | @@ -4,11 +4,13 @@ const blueprintHelpers = require('ember-cli-blueprint-test-helpers/helpers');
const setupTestHooks = blueprintHelpers.setupTestHooks;
const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
-
+const setupTestEnvironment = require('../helpers/setup-test-environment');
const chai = require('ember-cli-blueprint-test-helpers/chai');
const expect = chai.expect;
+const enableOctane = setupTestEnvironment.enableOctane;
describe('Blueprint: component-class-addon', function () {
+ enableOctane();
setupTestHooks(this);
describe('in addon', function () { | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/component-class-test.js | @@ -188,23 +188,23 @@ describe('Blueprint: component-class', function () {
it('component-class foo --pod', function () {
return emberGenerateDestroy(['component-class', 'foo', '--pod'], (_file) => {
expect(_file('app/pods/components/foo/component.js')).to.equal(
- fixture('component/native-component.js')
+ fixture('component/component.js')
);
});
});
it('component-class x-foo --pod', function () {
return emberGenerateDestroy(['component-class', 'x-foo', '--pod'], (_file) => {
expect(_file('app/pods/components/x-foo/component.js')).to.equal(
- fixture('component/native-component-dash.js')
+ fixture('component/component-dash.js')
);
});
});
it('component-class foo/x-foo --pod', function () {
return emberGenerateDestroy(['component-class', 'foo/x-foo', '--pod'], (_file) => {
expect(_file('app/pods/components/foo/x-foo/component.js')).to.equal(
- fixture('component/native-component-nested.js')
+ fixture('component/component-nested.js')
);
});
});
@@ -214,7 +214,7 @@ describe('Blueprint: component-class', function () {
['component-class', 'x-foo', '--pod', '--path', 'foo'],
(_file) => {
expect(_file('app/pods/foo/x-foo/component.js')).to.equal(
- fixture('component/native-component-dash.js')
+ fixture('component/component-dash.js')
);
}
);
@@ -225,7 +225,7 @@ describe('Blueprint: component-class', function () {
['component-class', 'foo/x-foo', '--pod', '--path', 'bar'],
(_file) => {
expect(_file('app/pods/bar/foo/x-foo/component.js')).to.equal(
- fixture('component/native-component-nested.js')
+ fixture('component/component-nested.js')
);
}
);
@@ -236,7 +236,7 @@ describe('Blueprint: component-class', function () {
['component-class', 'x-foo', '--pod', '--path', 'bar/foo'],
(_file) => {
expect(_file('app/pods/bar/foo/x-foo/component.js')).to.equal(
- fixture('component/native-component-dash.js')
+ fixture('component/component-dash.js')
);
}
);
@@ -247,7 +247,7 @@ describe('Blueprint: component-class', function () {
['component-class', 'foo/x-foo', '--pod', '--path', 'bar/baz'],
(_file) => {
expect(_file('app/pods/bar/baz/foo/x-foo/component.js')).to.equal(
- fixture('component/native-component-nested.js')
+ fixture('component/component-nested.js')
);
}
);
@@ -256,7 +256,7 @@ describe('Blueprint: component-class', function () {
it('component-class x-foo --pod -no-path', function () {
return emberGenerateDestroy(['component-class', 'x-foo', '--pod', '-no-path'], (_file) => {
expect(_file('app/pods/x-foo/component.js')).to.equal(
- fixture('component/native-component-dash.js')
+ fixture('component/component-dash.js')
);
});
});
@@ -266,7 +266,7 @@ describe('Blueprint: component-class', function () {
['component-class', 'foo/x-foo', '--pod', '-no-path'],
(_file) => {
expect(_file('app/pods/foo/x-foo/component.js')).to.equal(
- fixture('component/native-component-nested.js')
+ fixture('component/component-nested.js')
);
}
); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/controller-test.js | @@ -35,9 +35,7 @@ describe('Blueprint: controller', function () {
it('controller foo', function () {
return emberGenerateDestroy(['controller', 'foo'], (_file) => {
- expect(_file('app/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
- );
+ expect(_file('app/controllers/foo.js')).to.equal(fixture('controller/controller.js'));
expect(_file('tests/unit/controllers/foo-test.js')).to.equal(
fixture('controller-test/default.js')
@@ -50,9 +48,7 @@ describe('Blueprint: controller', function () {
expect(_file('app/controllers/foo.js.js')).to.not.exist;
expect(_file('tests/unit/controllers/foo.js-test.js')).to.not.exist;
- expect(_file('app/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
- );
+ expect(_file('app/controllers/foo.js')).to.equal(fixture('controller/controller.js'));
expect(_file('tests/unit/controllers/foo-test.js')).to.equal(
fixture('controller-test/default.js')
@@ -63,7 +59,7 @@ describe('Blueprint: controller', function () {
it('controller foo/bar', function () {
return emberGenerateDestroy(['controller', 'foo/bar'], (_file) => {
expect(_file('app/controllers/foo/bar.js')).to.equal(
- fixture('controller/native-controller-nested.js')
+ fixture('controller/controller-nested.js')
);
expect(_file('tests/unit/controllers/foo/bar-test.js')).to.equal(
@@ -80,9 +76,7 @@ describe('Blueprint: controller', function () {
it('controller foo --pod podModulePrefix', function () {
return emberGenerateDestroy(['controller', 'foo', '--pod'], (_file) => {
- expect(_file('app/pods/foo/controller.js')).to.equal(
- fixture('controller/native-controller.js')
- );
+ expect(_file('app/pods/foo/controller.js')).to.equal(fixture('controller/controller.js'));
expect(_file('tests/unit/pods/foo/controller-test.js')).to.equal(
fixture('controller-test/default.js')
@@ -92,9 +86,7 @@ describe('Blueprint: controller', function () {
it('controller foo.js --pod podModulePrefix', function () {
return emberGenerateDestroy(['controller', 'foo.js', '--pod'], (_file) => {
- expect(_file('app/pods/foo/controller.js')).to.equal(
- fixture('controller/native-controller.js')
- );
+ expect(_file('app/pods/foo/controller.js')).to.equal(fixture('controller/controller.js'));
expect(_file('tests/unit/pods/foo/controller-test.js')).to.equal(
fixture('controller-test/default.js')
@@ -120,9 +112,7 @@ describe('Blueprint: controller', function () {
it('controller foo', function () {
return emberGenerateDestroy(['controller', 'foo'], (_file) => {
- expect(_file('addon/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
- );
+ expect(_file('addon/controllers/foo.js')).to.equal(fixture('controller/controller.js'));
expect(_file('app/controllers/foo.js')).to.contain(
"export { default } from 'my-addon/controllers/foo';"
@@ -140,9 +130,7 @@ describe('Blueprint: controller', function () {
expect(_file('app/controllers/foo.js.js')).to.not.exist;
expect(_file('tests/unit/controllers/foo.js-test.js')).to.not.exist;
- expect(_file('addon/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
- );
+ expect(_file('addon/controllers/foo.js')).to.equal(fixture('controller/controller.js'));
expect(_file('app/controllers/foo.js')).to.contain(
"export { default } from 'my-addon/controllers/foo';"
@@ -157,7 +145,7 @@ describe('Blueprint: controller', function () {
it('controller foo/bar', function () {
return emberGenerateDestroy(['controller', 'foo/bar'], (_file) => {
expect(_file('addon/controllers/foo/bar.js')).to.equal(
- fixture('controller/native-controller-nested.js')
+ fixture('controller/controller-nested.js')
);
expect(_file('app/controllers/foo/bar.js')).to.contain(
@@ -173,7 +161,7 @@ describe('Blueprint: controller', function () {
it('controller foo --dummy', function () {
return emberGenerateDestroy(['controller', 'foo', '--dummy'], (_file) => {
expect(_file('tests/dummy/app/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
+ fixture('controller/controller.js')
);
expect(_file('app/controllers/foo-test.js')).to.not.exist;
@@ -187,7 +175,7 @@ describe('Blueprint: controller', function () {
expect(_file('tests/dummy/app/controllers/foo.js.js')).to.not.exist;
expect(_file('tests/dummy/app/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
+ fixture('controller/controller.js')
);
expect(_file('app/controllers/foo-test.js')).to.not.exist;
@@ -199,7 +187,7 @@ describe('Blueprint: controller', function () {
it('controller foo/bar --dummy', function () {
return emberGenerateDestroy(['controller', 'foo/bar', '--dummy'], (_file) => {
expect(_file('tests/dummy/app/controllers/foo/bar.js')).to.equal(
- fixture('controller/native-controller-nested.js')
+ fixture('controller/controller-nested.js')
);
expect(_file('app/controllers/foo/bar.js')).to.not.exist;
@@ -225,7 +213,7 @@ describe('Blueprint: controller', function () {
it('controller foo --in-repo-addon=my-addon', function () {
return emberGenerateDestroy(['controller', 'foo', '--in-repo-addon=my-addon'], (_file) => {
expect(_file('lib/my-addon/addon/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
+ fixture('controller/controller.js')
);
expect(_file('lib/my-addon/app/controllers/foo.js')).to.contain(
@@ -245,7 +233,7 @@ describe('Blueprint: controller', function () {
expect(_file('tests/unit/controllers/foo.js-test.js')).to.not.exist;
expect(_file('lib/my-addon/addon/controllers/foo.js')).to.equal(
- fixture('controller/native-controller.js')
+ fixture('controller/controller.js')
);
expect(_file('lib/my-addon/app/controllers/foo.js')).to.contain(
@@ -263,7 +251,7 @@ describe('Blueprint: controller', function () {
['controller', 'foo/bar', '--in-repo-addon=my-addon'],
(_file) => {
expect(_file('lib/my-addon/addon/controllers/foo/bar.js')).to.equal(
- fixture('controller/native-controller-nested.js')
+ fixture('controller/controller-nested.js')
);
expect(_file('lib/my-addon/app/controllers/foo/bar.js')).to.contain( | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/route-test.js | @@ -40,7 +40,7 @@ describe('Blueprint: route', function () {
it('route foo', function () {
return emberGenerateDestroy(['route', 'foo'], (_file) => {
- expect(_file('app/routes/foo.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('app/routes/foo.js')).to.equal(fixture('route/route.js'));
expect(_file('app/templates/foo.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -58,7 +58,7 @@ describe('Blueprint: route', function () {
expect(_file('app/templates/foo.js.hbs')).to.not.exist;
expect(_file('tests/unit/routes/foo.js-test.js')).to.not.exist;
- expect(_file('app/routes/foo.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('app/routes/foo.js')).to.equal(fixture('route/route.js'));
expect(_file('app/templates/foo.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -84,9 +84,7 @@ describe('Blueprint: route', function () {
it('route foo --path=:foo_id/show', function () {
return emberGenerateDestroy(['route', 'foo', '--path=:foo_id/show'], (_file) => {
- expect(_file('app/routes/foo.js')).to.equal(
- fixture('route/native-route-with-dynamic-segment.js')
- );
+ expect(_file('app/routes/foo.js')).to.equal(fixture('route/route-with-dynamic-segment.js'));
expect(_file('app/templates/foo.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -105,7 +103,7 @@ describe('Blueprint: route', function () {
it('route parent/child --reset-namespace', function () {
return emberGenerateDestroy(['route', 'parent/child', '--reset-namespace'], (_file) => {
- expect(_file('app/routes/child.js')).to.equal(fixture('route/native-route-child.js'));
+ expect(_file('app/routes/child.js')).to.equal(fixture('route/route-child.js'));
expect(_file('app/templates/child.hbs')).to.equal('{{page-title "Child"}}\n{{outlet}}');
@@ -125,7 +123,7 @@ describe('Blueprint: route', function () {
return emberGenerateDestroy(
['route', 'parent/child', '--reset-namespace', '--pod'],
(_file) => {
- expect(_file('app/child/route.js')).to.equal(fixture('route/native-route-child.js'));
+ expect(_file('app/child/route.js')).to.equal(fixture('route/route-child.js'));
expect(_file('app/child/template.hbs')).to.equal('{{page-title "Child"}}\n{{outlet}}');
@@ -171,7 +169,7 @@ describe('Blueprint: route', function () {
it('route foo --pod', function () {
return emberGenerateDestroy(['route', 'foo', '--pod'], (_file) => {
- expect(_file('app/foo/route.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('app/foo/route.js')).to.equal(fixture('route/route.js'));
expect(_file('app/foo/template.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -189,7 +187,7 @@ describe('Blueprint: route', function () {
expect(_file('app/foo.js/template.hbs')).to.not.exist;
expect(_file('tests/unit/foo.js/route-test.js')).to.not.exist;
- expect(_file('app/foo/route.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('app/foo/route.js')).to.equal(fixture('route/route.js'));
expect(_file('app/foo/template.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -246,7 +244,7 @@ describe('Blueprint: route', function () {
it('route foo --pod', function () {
return emberGenerateDestroy(['route', 'foo', '--pod'], (_file) => {
- expect(_file('app/pods/foo/route.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('app/pods/foo/route.js')).to.equal(fixture('route/route.js'));
expect(_file('app/pods/foo/template.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -266,7 +264,7 @@ describe('Blueprint: route', function () {
expect(_file('app/pods/foo.js/template.hbs')).to.not.exist;
expect(_file('tests/unit/pods/foo.js/route-test.js')).to.not.exist;
- expect(_file('app/pods/foo/route.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('app/pods/foo/route.js')).to.equal(fixture('route/route.js'));
expect(_file('app/pods/foo/template.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -300,7 +298,7 @@ describe('Blueprint: route', function () {
it('route foo', function () {
return emberGenerateDestroy(['route', 'foo'], (_file) => {
- expect(_file('addon/routes/foo.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('addon/routes/foo.js')).to.equal(fixture('route/route.js'));
expect(_file('addon/templates/foo.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -328,7 +326,7 @@ describe('Blueprint: route', function () {
expect(_file('app/templates/foo.js.js')).to.not.exist;
expect(_file('tests/unit/routes/foo.js-test.js')).to.not.exist;
- expect(_file('addon/routes/foo.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('addon/routes/foo.js')).to.equal(fixture('route/route.js'));
expect(_file('addon/templates/foo.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -351,7 +349,7 @@ describe('Blueprint: route', function () {
it('route foo/bar', function () {
return emberGenerateDestroy(['route', 'foo/bar'], (_file) => {
- expect(_file('addon/routes/foo/bar.js')).to.equal(fixture('route/native-route-nested.js'));
+ expect(_file('addon/routes/foo/bar.js')).to.equal(fixture('route/route-nested.js'));
expect(_file('addon/templates/foo/bar.hbs')).to.equal('{{page-title "Bar"}}\n{{outlet}}');
@@ -375,7 +373,7 @@ describe('Blueprint: route', function () {
it('route foo --dummy', function () {
return emberGenerateDestroy(['route', 'foo', '--dummy'], (_file) => {
- expect(_file('tests/dummy/app/routes/foo.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('tests/dummy/app/routes/foo.js')).to.equal(fixture('route/route.js'));
expect(_file('tests/dummy/app/templates/foo.hbs')).to.equal(
'{{page-title "Foo"}}\n{{outlet}}'
@@ -396,7 +394,7 @@ describe('Blueprint: route', function () {
expect(_file('tests/dummy/app/routes/foo.js.js')).to.not.exist;
expect(_file('tests/dummy/app/templates/foo.js.hbs')).to.not.exist;
- expect(_file('tests/dummy/app/routes/foo.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('tests/dummy/app/routes/foo.js')).to.equal(fixture('route/route.js'));
expect(_file('tests/dummy/app/templates/foo.hbs')).to.equal(
'{{page-title "Foo"}}\n{{outlet}}'
@@ -416,7 +414,7 @@ describe('Blueprint: route', function () {
it('route foo/bar --dummy', function () {
return emberGenerateDestroy(['route', 'foo/bar', '--dummy'], (_file) => {
expect(_file('tests/dummy/app/routes/foo/bar.js')).to.equal(
- fixture('route/native-route-nested.js')
+ fixture('route/route-nested.js')
);
expect(_file('tests/dummy/app/templates/foo/bar.hbs')).to.equal(
@@ -437,7 +435,7 @@ describe('Blueprint: route', function () {
it('route foo --pod', function () {
return emberGenerateDestroy(['route', 'foo', '--pod'], (_file) => {
- expect(_file('addon/foo/route.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('addon/foo/route.js')).to.equal(fixture('route/route.js'));
expect(_file('addon/foo/template.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -461,7 +459,7 @@ describe('Blueprint: route', function () {
expect(_file('app/foo.js/template.js')).to.not.exist;
expect(_file('tests/unit/foo.js/route-test.js')).to.not.exist;
- expect(_file('addon/foo/route.js')).to.equal(fixture('route/native-route.js'));
+ expect(_file('addon/foo/route.js')).to.equal(fixture('route/route.js'));
expect(_file('addon/foo/template.hbs')).to.equal('{{page-title "Foo"}}\n{{outlet}}');
@@ -494,9 +492,7 @@ describe('Blueprint: route', function () {
it('route foo --in-repo-addon=my-addon', function () {
return emberGenerateDestroy(['route', 'foo', '--in-repo-addon=my-addon'], (_file) => {
- expect(_file('lib/my-addon/addon/routes/foo.js')).to.equal(
- fixture('route/native-route.js')
- );
+ expect(_file('lib/my-addon/addon/routes/foo.js')).to.equal(fixture('route/route.js'));
expect(_file('lib/my-addon/addon/templates/foo.hbs')).to.equal(
'{{page-title "Foo"}}\n{{outlet}}'
@@ -522,9 +518,7 @@ describe('Blueprint: route', function () {
expect(_file('lib/my-addon/app/templates/foo.js.js')).to.not.exist;
expect(_file('tests/unit/routes/foo.js-test.js')).to.not.exist;
- expect(_file('lib/my-addon/addon/routes/foo.js')).to.equal(
- fixture('route/native-route.js')
- );
+ expect(_file('lib/my-addon/addon/routes/foo.js')).to.equal(fixture('route/route.js'));
expect(_file('lib/my-addon/addon/templates/foo.hbs')).to.equal(
'{{page-title "Foo"}}\n{{outlet}}'
@@ -545,7 +539,7 @@ describe('Blueprint: route', function () {
it('route foo/bar --in-repo-addon=my-addon', function () {
return emberGenerateDestroy(['route', 'foo/bar', '--in-repo-addon=my-addon'], (_file) => {
expect(_file('lib/my-addon/addon/routes/foo/bar.js')).to.equal(
- fixture('route/native-route-nested.js')
+ fixture('route/route-nested.js')
);
expect(_file('lib/my-addon/addon/templates/foo/bar.hbs')).to.equal( | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/blueprints/service-test.js | @@ -35,7 +35,7 @@ describe('Blueprint: service', function () {
it('service foo', function () {
return emberGenerateDestroy(['service', 'foo'], (_file) => {
- expect(_file('app/services/foo.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('app/services/foo.js')).to.equal(fixture('service/service.js'));
expect(_file('tests/unit/services/foo-test.js')).to.equal(
fixture('service-test/default.js')
@@ -48,7 +48,7 @@ describe('Blueprint: service', function () {
expect(_file('app/services/foo.js.js')).to.not.exist;
expect(_file('tests/unit/services/foo.js-test.js')).to.not.exist;
- expect(_file('app/services/foo.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('app/services/foo.js')).to.equal(fixture('service/service.js'));
expect(_file('tests/unit/services/foo-test.js')).to.equal(
fixture('service-test/default.js')
@@ -58,9 +58,7 @@ describe('Blueprint: service', function () {
it('service foo/bar', function () {
return emberGenerateDestroy(['service', 'foo/bar'], (_file) => {
- expect(_file('app/services/foo/bar.js')).to.equal(
- fixture('service/native-service-nested.js')
- );
+ expect(_file('app/services/foo/bar.js')).to.equal(fixture('service/service-nested.js'));
expect(_file('tests/unit/services/foo/bar-test.js')).to.equal(
fixture('service-test/default-nested.js')
@@ -70,7 +68,7 @@ describe('Blueprint: service', function () {
it('service foo --pod', function () {
return emberGenerateDestroy(['service', 'foo', '--pod'], (_file) => {
- expect(_file('app/foo/service.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('app/foo/service.js')).to.equal(fixture('service/service.js'));
expect(_file('tests/unit/foo/service-test.js')).to.equal(
fixture('service-test/default.js')
@@ -83,7 +81,7 @@ describe('Blueprint: service', function () {
expect(_file('app/foo.js/service.js')).to.not.exist;
expect(_file('tests/unit/foo.js/service-test.js')).to.not.exist;
- expect(_file('app/foo/service.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('app/foo/service.js')).to.equal(fixture('service/service.js'));
expect(_file('tests/unit/foo/service-test.js')).to.equal(
fixture('service-test/default.js')
@@ -93,9 +91,7 @@ describe('Blueprint: service', function () {
it('service foo/bar --pod', function () {
return emberGenerateDestroy(['service', 'foo/bar', '--pod'], (_file) => {
- expect(_file('app/foo/bar/service.js')).to.equal(
- fixture('service/native-service-nested.js')
- );
+ expect(_file('app/foo/bar/service.js')).to.equal(fixture('service/service-nested.js'));
expect(_file('tests/unit/foo/bar/service-test.js')).to.equal(
fixture('service-test/default-nested.js')
@@ -112,7 +108,7 @@ describe('Blueprint: service', function () {
it('service foo --pod', function () {
return emberGenerateDestroy(['service', 'foo', '--pod'], (_file) => {
- expect(_file('app/pods/foo/service.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('app/pods/foo/service.js')).to.equal(fixture('service/service.js'));
expect(_file('tests/unit/pods/foo/service-test.js')).to.equal(
fixture('service-test/default.js')
@@ -125,7 +121,7 @@ describe('Blueprint: service', function () {
expect(_file('app/pods/foo.js/service.js')).to.not.exist;
expect(_file('tests/unit/pods/foo.js/service-test.js')).to.not.exist;
- expect(_file('app/pods/foo/service.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('app/pods/foo/service.js')).to.equal(fixture('service/service.js'));
expect(_file('tests/unit/pods/foo/service-test.js')).to.equal(
fixture('service-test/default.js')
@@ -136,7 +132,7 @@ describe('Blueprint: service', function () {
it('service foo/bar --pod', function () {
return emberGenerateDestroy(['service', 'foo/bar', '--pod'], (_file) => {
expect(_file('app/pods/foo/bar/service.js')).to.equal(
- fixture('service/native-service-nested.js')
+ fixture('service/service-nested.js')
);
expect(_file('tests/unit/pods/foo/bar/service-test.js')).to.equal(
@@ -163,7 +159,7 @@ describe('Blueprint: service', function () {
it('service foo', function () {
return emberGenerateDestroy(['service', 'foo'], (_file) => {
- expect(_file('addon/services/foo.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('addon/services/foo.js')).to.equal(fixture('service/service.js'));
expect(_file('app/services/foo.js')).to.contain(
"export { default } from 'my-addon/services/foo';"
@@ -181,7 +177,7 @@ describe('Blueprint: service', function () {
expect(_file('app/services/foo.js.js')).to.not.exist;
expect(_file('tests/unit/services/foo.js-test.js')).to.not.exist;
- expect(_file('addon/services/foo.js')).to.equal(fixture('service/native-service.js'));
+ expect(_file('addon/services/foo.js')).to.equal(fixture('service/service.js'));
expect(_file('app/services/foo.js')).to.contain(
"export { default } from 'my-addon/services/foo';"
@@ -195,9 +191,7 @@ describe('Blueprint: service', function () {
it('service foo/bar', function () {
return emberGenerateDestroy(['service', 'foo/bar'], (_file) => {
- expect(_file('addon/services/foo/bar.js')).to.equal(
- fixture('service/native-service-nested.js')
- );
+ expect(_file('addon/services/foo/bar.js')).to.equal(fixture('service/service-nested.js'));
expect(_file('app/services/foo/bar.js')).to.contain(
"export { default } from 'my-addon/services/foo/bar';"
@@ -212,7 +206,7 @@ describe('Blueprint: service', function () {
it('service foo/bar --dummy', function () {
return emberGenerateDestroy(['service', 'foo/bar', '--dummy'], (_file) => {
expect(_file('tests/dummy/app/services/foo/bar.js')).to.equal(
- fixture('service/native-service-nested.js')
+ fixture('service/service-nested.js')
);
expect(_file('addon/services/foo/bar.js')).to.not.exist;
});
@@ -223,7 +217,7 @@ describe('Blueprint: service', function () {
expect(_file('tests/dummy/app/services/foo/bar.js.js')).to.not.exist;
expect(_file('tests/dummy/app/services/foo/bar.js')).to.equal(
- fixture('service/native-service-nested.js')
+ fixture('service/service-nested.js')
);
expect(_file('addon/services/foo/bar.js')).to.not.exist;
});
@@ -246,9 +240,7 @@ describe('Blueprint: service', function () {
it('service foo --in-repo-addon=my-addon', function () {
return emberGenerateDestroy(['service', 'foo', '--in-repo-addon=my-addon'], (_file) => {
- expect(_file('lib/my-addon/addon/services/foo.js')).to.equal(
- fixture('service/native-service.js')
- );
+ expect(_file('lib/my-addon/addon/services/foo.js')).to.equal(fixture('service/service.js'));
expect(_file('lib/my-addon/app/services/foo.js')).to.contain(
"export { default } from 'my-addon/services/foo';"
@@ -266,9 +258,7 @@ describe('Blueprint: service', function () {
expect(_file('lib/my-addon/app/services/foo.js.js')).to.not.exist;
expect(_file('tests/unit/services/foo.js-test.js')).to.not.exist;
- expect(_file('lib/my-addon/addon/services/foo.js')).to.equal(
- fixture('service/native-service.js')
- );
+ expect(_file('lib/my-addon/addon/services/foo.js')).to.equal(fixture('service/service.js'));
expect(_file('lib/my-addon/app/services/foo.js')).to.contain(
"export { default } from 'my-addon/services/foo';"
@@ -283,7 +273,7 @@ describe('Blueprint: service', function () {
it('service foo/bar --in-repo-addon=my-addon', function () {
return emberGenerateDestroy(['service', 'foo/bar', '--in-repo-addon=my-addon'], (_file) => {
expect(_file('lib/my-addon/addon/services/foo/bar.js')).to.equal(
- fixture('service/native-service-nested.js')
+ fixture('service/service-nested.js')
);
expect(_file('lib/my-addon/app/services/foo/bar.js')).to.contain( | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon-dash-pod.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from './template';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon-dash.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from '../templates/components/x-foo';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon-nested-pod.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from './template';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon-nested.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from '../../templates/components/foo/x-foo';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-addon.js | @@ -1,6 +0,0 @@
-import Component from '@ember/component';
-import layout from '../templates/components/foo';
-
-export default Component.extend({
- layout
-}); | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-dash.js | @@ -1,4 +1,4 @@
-import Component from '@ember/component';
+import Component from '@glimmer/component';
-export default Component.extend({
-});
+export default class XFooComponent extends Component {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component-nested.js | @@ -1,4 +1,4 @@
-import Component from '@ember/component';
+import Component from '@glimmer/component';
-export default Component.extend({
-});
+export default class FooXFooComponent extends Component {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/component.js | @@ -1,4 +1,4 @@
-import Component from '@ember/component';
+import Component from '@glimmer/component';
-export default Component.extend({
-});
+export default class FooComponent extends Component {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/native-component-dash.js | @@ -1,4 +0,0 @@
-import Component from '@glimmer/component';
-
-export default class XFooComponent extends Component {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/native-component-nested.js | @@ -1,4 +0,0 @@
-import Component from '@glimmer/component';
-
-export default class FooXFooComponent extends Component {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/component/native-component.js | @@ -1,4 +0,0 @@
-import Component from '@glimmer/component';
-
-export default class FooComponent extends Component {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/controller/controller-nested.js | @@ -1,4 +1,4 @@
import Controller from '@ember/controller';
-export default Controller.extend({
-});
+export default class FooBarController extends Controller {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/controller/controller.js | @@ -1,4 +1,4 @@
import Controller from '@ember/controller';
-export default Controller.extend({
-});
+export default class FooController extends Controller {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/controller/native-controller-nested.js | @@ -1,4 +0,0 @@
-import Controller from '@ember/controller';
-
-export default class FooBarController extends Controller {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/controller/native-controller.js | @@ -1,4 +0,0 @@
-import Controller from '@ember/controller';
-
-export default class FooController extends Controller {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/native-route-child.js | @@ -1,4 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class ParentChildRoute extends Route {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/native-route-nested.js | @@ -1,4 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class FooBarRoute extends Route {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/native-route-with-dynamic-segment.js | @@ -1,11 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class FooRoute extends Route {
- model(params) {
- /**
- * This route was generated with a dynamic segment. Implement data loading
- * based on that dynamic segment here in the model hook.
- */
- return params;
- }
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/native-route.js | @@ -1,4 +0,0 @@
-import Route from '@ember/routing/route';
-
-export default class FooRoute extends Route {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/route-child.js | @@ -1,4 +1,4 @@
import Route from '@ember/routing/route';
-export default Route.extend({
-});
+export default class ParentChildRoute extends Route {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/route-nested.js | @@ -1,4 +1,4 @@
import Route from '@ember/routing/route';
-export default Route.extend({
-});
+export default class FooBarRoute extends Route {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/route-with-dynamic-segment.js | @@ -1,11 +1,11 @@
import Route from '@ember/routing/route';
-export default Route.extend({
+export default class FooRoute extends Route {
model(params) {
/**
* This route was generated with a dynamic segment. Implement data loading
* based on that dynamic segment here in the model hook.
*/
return params;
- },
-});
+ }
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/route/route.js | @@ -1,4 +1,4 @@
import Route from '@ember/routing/route';
-export default Route.extend({
-});
+export default class FooRoute extends Route {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/service/native-service-nested.js | @@ -1,4 +0,0 @@
-import Service from '@ember/service';
-
-export default class FooBarService extends Service {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/service/native-service.js | @@ -1,4 +0,0 @@
-import Service from '@ember/service';
-
-export default class FooService extends Service {
-} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/service/service-nested.js | @@ -1,4 +1,4 @@
import Service from '@ember/service';
-export default Service.extend({
-});
+export default class FooBarService extends Service {
+} | true |
Other | emberjs | ember.js | 4602942180f5834435318255816f3bd4e5764a36.json | remove pre-octane blueprints and fixtures
typo | node-tests/fixtures/service/service.js | @@ -1,4 +1,4 @@
import Service from '@ember/service';
-export default Service.extend({
-});
+export default class FooService extends Service {
+} | true |
Other | emberjs | ember.js | 5ea53d595877c49aad18c8a6ca68d23b1ea226f5.json | Add v4.2.0-beta.1 to CHANGELOG
(cherry picked from commit 3b4b36d97235dddda882e014a0727fb5a41195a8) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.2.0-beta.1 (December 28, 2021)
+
+- [#19878](https://github.com/emberjs/ember.js/pull/19772) [BUGFIX] Allow class-based helpers to work in strict-mode.
+
### v4.1.0 (December 28, 2021)
- [#19772](https://github.com/emberjs/ember.js/pull/19772) / [#19826](https://github.com/emberjs/ember.js/pull/19826) [FEATURE] Add a `@cached` decorator per [RFC #0566](https://github.com/emberjs/rfcs/blob/af64915b5ecde010fce09309a47ee6d2447588d0/text/0566-memo-decorator.md). | false |
Other | emberjs | ember.js | b50b0f8ea1ff14963d765b761048e6077c0df2d5.json | Add documentation for `setComponentManager` | packages/@ember/-internals/glimmer/lib/utils/managers.ts | @@ -6,6 +6,17 @@ import {
setComponentManager as glimmerSetComponentManager,
} from '@glimmer/manager';
+/**
+ Associate a class with a component manager (an object that is responsible for
+ coordinating the lifecycle events that occurs when invoking, rendering and
+ re-rendering a component).
+
+ @method setComponentManager
+ @param {Function} factory a function to create the owner for an object
+ @param {Object} obj the object to associate with the componetn manager
+ @return {Object} the same object passed in
+ @public
+ */
export function setComponentManager(
manager: (owner: Owner) => ComponentManager<unknown>,
obj: object | false |