language
stringclasses 1
value | owner
stringlengths 2
15
| repo
stringlengths 2
21
| sha
stringlengths 45
45
| message
stringlengths 7
36.3k
| path
stringlengths 1
199
| patch
stringlengths 15
102k
| is_multipart
bool 2
classes |
|---|---|---|---|---|---|---|---|
Other
|
emberjs
|
ember.js
|
49d5291600a0b6d70ff9913e10ff9f2f23e2eb7b.json
|
Update Glimmer VM
Updates the VM to the latest version, which includes a number of major
changes:
- Refactors the resolver to not cache values, as this is unnecessary
- Refactors the resolver to return helper/modifier definitions directly
- Refactors the resolver to return ResolvedComponentDefinitions
- Updates various component definitions
- Removes custom helper, modifier, and component managers
- Updates built-in helpers to be based on objects with associated
helpers/helper managers.
|
packages/ember/index.js
|
@@ -103,22 +103,18 @@ import {
Checkbox,
Component,
setComponentManager,
- capabilities,
escapeExpression,
getTemplates,
Helper,
helper,
- helperCapabilities,
htmlSafe,
- invokeHelper,
isHTMLSafe,
LinkComponent,
setTemplates,
template,
TextField,
TextArea,
isSerializationFirstNode,
- modifierCapabilities,
} from '@ember/-internals/glimmer';
// eslint-disable-next-line import/no-unresolved
import VERSION from './version';
@@ -136,14 +132,17 @@ import Engine from '@ember/engine';
import EngineInstance from '@ember/engine/instance';
import { assign, merge } from '@ember/polyfills';
import { LOGGER, EMBER_EXTEND_PROTOTYPES, JQUERY_INTEGRATION } from '@ember/deprecated-features';
-import templateOnlyComponent from '@ember/component/template-only';
+import { templateOnlyComponent, invokeHelper } from '@glimmer/runtime';
import {
+ componentCapabilities,
+ modifierCapabilities,
+ helperCapabilities,
setModifierManager,
setComponentTemplate,
getComponentTemplate,
setHelperManager,
-} from '@glimmer/runtime';
+} from '@glimmer/manager';
import {
assertDestroyablesDestroyed,
@@ -590,7 +589,7 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) {
Ember.TextSupport = views.TextSupport;
}
Ember._setComponentManager = setComponentManager;
-Ember._componentManagerCapabilities = capabilities;
+Ember._componentManagerCapabilities = componentCapabilities;
Ember._setModifierManager = setModifierManager;
Ember._modifierManagerCapabilities = modifierCapabilities;
| true |
Other
|
emberjs
|
ember.js
|
49d5291600a0b6d70ff9913e10ff9f2f23e2eb7b.json
|
Update Glimmer VM
Updates the VM to the latest version, which includes a number of major
changes:
- Refactors the resolver to not cache values, as this is unnecessary
- Refactors the resolver to return helper/modifier definitions directly
- Refactors the resolver to return ResolvedComponentDefinitions
- Updates various component definitions
- Removes custom helper, modifier, and component managers
- Updates built-in helpers to be based on objects with associated
helpers/helper managers.
|
packages/ember/tests/reexports_test.js
|
@@ -220,7 +220,7 @@ let allExports = [
['platform.defineProperty', null, { value: true }],
['platform.hasPropertyAccessors', null, { value: true }],
['defineProperty', '@ember/-internals/metal'],
- ['destroy', '@glimmer/runtime', 'destroy'],
+ ['destroy', '@glimmer/destroyable', 'destroy'],
['libraries', '@ember/-internals/metal'],
['getProperties', '@ember/-internals/metal'],
['setProperties', '@ember/-internals/metal'],
@@ -263,19 +263,17 @@ let allExports = [
['Handlebars.Utils.escapeExpression', '@ember/-internals/glimmer', 'escapeExpression'],
['String.htmlSafe', '@ember/-internals/glimmer', 'htmlSafe'],
['_setComponentManager', '@ember/-internals/glimmer', 'setComponentManager'],
- ['_componentManagerCapabilities', '@ember/-internals/glimmer', 'capabilities'],
- ['_setComponentTemplate', '@ember/-internals/glimmer', 'setComponentTemplate'],
- ['_getComponentTemplate', '@ember/-internals/glimmer', 'getComponentTemplate'],
- ['_templateOnlyComponent', '@ember/component/template-only', 'default'],
+ ['_componentManagerCapabilities', '@glimmer/manager', 'componentCapabilities'],
+ ['_setComponentTemplate', '@glimmer/manager', 'setComponentTemplate'],
+ ['_getComponentTemplate', '@glimmer/manager', 'getComponentTemplate'],
+ ['_templateOnlyComponent', '@glimmer/runtime', 'templateOnlyComponent'],
EMBER_GLIMMER_HELPER_MANAGER
- ? ['_setHelperManager', '@glimmer/runtime', 'setHelperManager']
+ ? ['_setHelperManager', '@glimmer/manager', 'setHelperManager']
: null,
EMBER_GLIMMER_HELPER_MANAGER
- ? ['_helperManagerCapabilities', '@ember/-internals/glimmer', 'helperCapabilities']
- : null,
- EMBER_GLIMMER_INVOKE_HELPER
- ? ['_invokeHelper', '@ember/-internals/glimmer', 'invokeHelper']
+ ? ['_helperManagerCapabilities', '@glimmer/manager', 'helperCapabilities']
: null,
+ EMBER_GLIMMER_INVOKE_HELPER ? ['_invokeHelper', '@glimmer/runtime', 'invokeHelper'] : null,
['_captureRenderTree', '@ember/debug', 'captureRenderTree'],
// @ember/-internals/runtime
| true |
Other
|
emberjs
|
ember.js
|
49d5291600a0b6d70ff9913e10ff9f2f23e2eb7b.json
|
Update Glimmer VM
Updates the VM to the latest version, which includes a number of major
changes:
- Refactors the resolver to not cache values, as this is unnecessary
- Refactors the resolver to return helper/modifier definitions directly
- Refactors the resolver to return ResolvedComponentDefinitions
- Updates various component definitions
- Removes custom helper, modifier, and component managers
- Updates built-in helpers to be based on objects with associated
helpers/helper managers.
|
yarn.lock
|
@@ -1657,154 +1657,187 @@
minimatch "^3.0.4"
strip-json-comments "^3.1.1"
-"@glimmer/compiler@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.67.0.tgz#fed033c725b73be7fa4f5200fe15616758bc6ca4"
- integrity sha512-CCw31F1XYGm73iy2lrsowV9yr+aXAGauLaNWrO5N+ciEfFyIu21OZ8+/H79bYdJLisJILeCBKvy0hsYpmvCzHw==
- dependencies:
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/syntax" "0.67.0"
- "@glimmer/util" "0.67.0"
- "@glimmer/wire-format" "0.67.0"
+"@glimmer/compiler@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.68.0.tgz#4ed5fd40a94dcf6fa89326a8008569d458db0b4b"
+ integrity sha512-cJMX5VvDyWEhT+YtfgZr84+G0BVWf41FQ0I1txw2bFiy1XA0Ny8CtFNTbHAQFplNluMYkfehDQc6cKab6VDKOw==
+ dependencies:
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/syntax" "0.68.0"
+ "@glimmer/util" "0.68.0"
+ "@glimmer/wire-format" "0.68.0"
"@simple-dom/interface" "^1.4.0"
-"@glimmer/encoder@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/encoder/-/encoder-0.67.0.tgz#e7d8dff4a70734126ae47b5f923198253efbde2d"
- integrity sha512-ryEDTyenOpuuiOc1mwQNPKE9rAVTZ/RNtVhhNJPSq/3q6aHL5/6/wHUUkHaZOZbG0T9EG0V0nCqPPCqZhq3IwQ==
+"@glimmer/destroyable@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/destroyable/-/destroyable-0.68.0.tgz#43a0342cf85e1b24b4dd868b658a4e6a32983795"
+ integrity sha512-Ac5AS+m6uRvPL55fmlUxAvtYD1AsggNyweyq/cR+/VzOuKSXj9xXIRABfwPsYu+Rr854aNICSy96T8IeO1FveA==
dependencies:
"@glimmer/env" "0.1.7"
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/vm" "0.67.0"
+ "@glimmer/global-context" "0.68.0"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/util" "0.68.0"
+
+"@glimmer/encoder@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/encoder/-/encoder-0.68.0.tgz#7ec098c0927750d12afb9c279e67c1ce5a8b872e"
+ integrity sha512-8Omzpco9XfYZaGkrHuXS/g88zNGBMbvIjKU363zo7um7RQv2roWoRB8kQxSQlKZbJSGK8BCaPR7TneK0O9ZNjQ==
+ dependencies:
+ "@glimmer/env" "0.1.7"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/vm" "0.68.0"
"@glimmer/env@0.1.7", "@glimmer/env@^0.1.7":
version "0.1.7"
resolved "https://registry.yarnpkg.com/@glimmer/env/-/env-0.1.7.tgz#fd2d2b55a9029c6b37a6c935e8c8871ae70dfa07"
integrity sha1-/S0rVakCnGs3psk16MiHGucN+gc=
-"@glimmer/global-context@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/global-context/-/global-context-0.67.0.tgz#041103738b6ec503d929684e342942023351b123"
- integrity sha512-eeMwi+lQK8GbK2m/+HJSQaGKJogGEqJEZn8hGxHbG7zvHXA7TBQ5+c4vR2QXNWTMrOI7qDzCX9XnF3tlaxQPjQ==
+"@glimmer/global-context@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/global-context/-/global-context-0.68.0.tgz#92fe8a2b641b02bec682b670eb3d2a24d683e490"
+ integrity sha512-qaYUOP2PF9JmOXiAULzR/5J0py0YNsBVx0wFbPhbhAfrY5LTmVx5Aunbhbc6tHNY8IjgoW4v1k0GpG86YZ+4Mw==
dependencies:
"@glimmer/env" "^0.1.7"
-"@glimmer/interfaces@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.67.0.tgz#fc68db956028f0ab9c655a53bb882d54fd34c24b"
- integrity sha512-1yNs8kt8k4tzA6r9lO3ScX4zR6Jg9ymRqIFvDtam1twNoRQBFHNwfpTqPU4X5mq/4tOcgtWA8FNv5/jBIOaOew==
+"@glimmer/interfaces@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.68.0.tgz#451e12d9b74cfd0778fbf6ae0374323b726d7a79"
+ integrity sha512-GvR8ke9XZK0qupJmHcUHVzy6Y5gLsBIzi0h769xoA6l6VrtRCQJC1GF95KNj1z3jlhVCUw3OLnqVFantCEONaQ==
dependencies:
"@simple-dom/interface" "^1.4.0"
-"@glimmer/low-level@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/low-level/-/low-level-0.67.0.tgz#d70383ed93f63feb1710f03ad8b09dff83b1f08a"
- integrity sha512-rgBNMz9iTaIrJJ1TUyOoiWzQv3CH7TxYuApSMrZ6tlXh7QpZ7Wfsnd44M+zLaJB7VAmRG4QfLwDee+I9OfTyeQ==
+"@glimmer/low-level@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/low-level/-/low-level-0.68.0.tgz#c19c8330232dc01fc4de57d233e9240e961d5ee8"
+ integrity sha512-u/+VqcFbAVJd506KEEwmJ8u0yHSsTfSoiklpGEk+FdyE5vKCvnNo+7onEB6GlizofL7kzq+yLBiR0mqz/Q4evA==
-"@glimmer/node@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.67.0.tgz#7a34e3d215721f425e48007f656528c52c008341"
- integrity sha512-bkfyuEkbanKdUfIdDi/1Pj/Swbg4Q0G0T7JvbTMN0L2tbj3NJSQNiBOPeN4FL2OZlRCt0ylGdWBKmeOgvyo2lQ==
+"@glimmer/manager@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/manager/-/manager-0.68.0.tgz#abea96d30a67cc6a7f8ace97470e9292e6ef2a82"
+ integrity sha512-/dAY8DzfvY+CdNnTaVFuUZf8BvIyLzbrf8jncdp6B5jG7bWsCM7Y+uzvC1sIj22QUoT6qrQe5+h2FlsELzKMAg==
dependencies:
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/runtime" "0.67.0"
- "@glimmer/util" "0.67.0"
+ "@glimmer/destroyable" "0.68.0"
+ "@glimmer/env" "0.1.7"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/reference" "0.68.0"
+ "@glimmer/util" "0.68.0"
+ "@glimmer/validator" "0.68.0"
+
+"@glimmer/node@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.68.0.tgz#693d0a079e9525991118b926dff6eab009fe7e21"
+ integrity sha512-r/Z5ppsEJb/RVHAJCqp6nX3KybSr4x4VLTunTDgQQA8pXGPaGeIaGrkEU1rAOAXwbtOA1Ak6MLll/BGaAP3bRA==
+ dependencies:
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/runtime" "0.68.0"
+ "@glimmer/util" "0.68.0"
"@simple-dom/document" "^1.4.0"
"@simple-dom/interface" "^1.4.0"
-"@glimmer/opcode-compiler@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/opcode-compiler/-/opcode-compiler-0.67.0.tgz#0d855ab06a8936bf1fcf4683f7b157e7b7fe4087"
- integrity sha512-mlLMa5N/uLEc13NU9AAUJjG4IU/5GZb0pXzYQY2Y37hCpGqsJLyoVcyuEseSlSGbyd9tkOrIl3mIZvxcE7IClg==
+"@glimmer/opcode-compiler@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/opcode-compiler/-/opcode-compiler-0.68.0.tgz#1bc523bbb8451bcdc5b46cf71d53dc6a5ec36bd4"
+ integrity sha512-c9O7+xJqWfzLVBxQwZNHwsUV5oOLUh2K7FcInjjn+gbzW7qBkl4mBwJ3VcAMd1rv/USbLyvd+DcSdpbS4H1ZAw==
+ dependencies:
+ "@glimmer/encoder" "0.68.0"
+ "@glimmer/env" "0.1.7"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/reference" "0.68.0"
+ "@glimmer/util" "0.68.0"
+ "@glimmer/vm" "0.68.0"
+ "@glimmer/wire-format" "0.68.0"
+
+"@glimmer/owner@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/owner/-/owner-0.68.0.tgz#7168e327e70584c6c95935b7d4b8ed8a3ea7347d"
+ integrity sha512-KeETHPBqmSjzyLVNyMP4XPzOcYOUAdb70IdRxaRNjDOveHP++MgrIxAiQ/danlqI2HzHg9Eb8CqlsyY/j3cH/A==
dependencies:
- "@glimmer/encoder" "0.67.0"
+ "@glimmer/util" "0.68.0"
+
+"@glimmer/program@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/program/-/program-0.68.0.tgz#0bf3d81db277eacd9d1e1e92262486b2837ef0ba"
+ integrity sha512-p/2CH4R+qEq2qLSKIH1gsCo0yHt5cLdj4Wtsg74GzBdrRjYxRcwRCOF7kkHOTovuqiBGvkSzc+g+Rzp8rs9ueQ==
+ dependencies:
+ "@glimmer/encoder" "0.68.0"
"@glimmer/env" "0.1.7"
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/program" "0.67.0"
- "@glimmer/reference" "0.67.0"
- "@glimmer/util" "0.67.0"
- "@glimmer/vm" "0.67.0"
- "@glimmer/wire-format" "0.67.0"
-
-"@glimmer/program@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/program/-/program-0.67.0.tgz#1f36062df5cc6718334fe4d88bb7ae50f44f8ce4"
- integrity sha512-fdZSl+eabrj/kXO5el1xt8HNuLRRUDUN3Yu4qWLScm8qGw+b4iZIiajQCFNTXzn0mz6lvNW0XyQ6a76URLmk9A==
- dependencies:
- "@glimmer/encoder" "0.67.0"
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/util" "0.67.0"
-
-"@glimmer/reference@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.67.0.tgz#2983167fcb90e5f7a24e00a5eb13c50bf266cf3d"
- integrity sha512-Qopa+sNhIvAZ4lb4hlAUPrPx7h19yOLlfqho3zgwTJoEQAyhUqalqeH5lr+xIC4r2uV6yCcLd3C27BLYxN342Q==
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/manager" "0.68.0"
+ "@glimmer/opcode-compiler" "0.68.0"
+ "@glimmer/util" "0.68.0"
+
+"@glimmer/reference@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.68.0.tgz#91e85cd881b0d9ee7e108879cd56e1ec374f9b59"
+ integrity sha512-b66jSLLitKvt0d7yi/+5M6XE+vWrorwsjYk3eCTE+cdMEG/T8n0d2j3P2TRL7opSnn8Pjj4o5ZZc4tOPyw7Sug==
dependencies:
"@glimmer/env" "^0.1.7"
- "@glimmer/global-context" "0.67.0"
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/util" "0.67.0"
- "@glimmer/validator" "0.67.0"
+ "@glimmer/global-context" "0.68.0"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/util" "0.68.0"
+ "@glimmer/validator" "0.68.0"
-"@glimmer/runtime@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.67.0.tgz#188ad893e1fade94879d6814ddd5b953eba1a2f8"
- integrity sha512-xslPdm+OIC57xQ3fUdIPM2wj/sG1OtoIWLq0C2gJw6cR1wQ5zSi6Az79AD5oUQdeiUzEr5BfTaEgsvXHhoHs+w==
+"@glimmer/runtime@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.68.0.tgz#965209a95b81ac9fcae907bfa995108f294decb4"
+ integrity sha512-/D029QjHfTkh+op5GNj46/dFJfyh/HvXeDTKRnjslDuRUrtOS9986/TmRISf8xWRfYQaVvDutF/xAK/KKIIm3A==
dependencies:
+ "@glimmer/destroyable" "0.68.0"
"@glimmer/env" "0.1.7"
- "@glimmer/global-context" "0.67.0"
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/low-level" "0.67.0"
- "@glimmer/program" "0.67.0"
- "@glimmer/reference" "0.67.0"
- "@glimmer/util" "0.67.0"
- "@glimmer/validator" "0.67.0"
- "@glimmer/vm" "0.67.0"
- "@glimmer/wire-format" "0.67.0"
+ "@glimmer/global-context" "0.68.0"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/low-level" "0.68.0"
+ "@glimmer/owner" "0.68.0"
+ "@glimmer/program" "0.68.0"
+ "@glimmer/reference" "0.68.0"
+ "@glimmer/util" "0.68.0"
+ "@glimmer/validator" "0.68.0"
+ "@glimmer/vm" "0.68.0"
+ "@glimmer/wire-format" "0.68.0"
"@simple-dom/interface" "^1.4.0"
-"@glimmer/syntax@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.67.0.tgz#2aaa5ba451671ee869285463b9711dbec1c843e2"
- integrity sha512-9eRjAF3oD0RyWzptincQT/ucWxxgMhYrhumizxCJDGWTpk8GCpAMoKjEK2D1eryVEaF3KknGS9ba3/oakGkpzg==
+"@glimmer/syntax@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.68.0.tgz#8dc25dbe8332ecc288ed5e02c721b19fc1e856e4"
+ integrity sha512-nidrNS1xf/cTQsoRyCj1VeCHGj4/dgRBBd3fbIig5KumOx7W5UQF4/cXJi24hA0/vvd0MEUMqo2DPpCMsPV7PQ==
dependencies:
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/util" "0.67.0"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/util" "0.68.0"
"@handlebars/parser" "^1.1.0"
simple-html-tokenizer "^0.5.10"
-"@glimmer/util@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.67.0.tgz#7f19320826e926a2fe80abb44512f9898f6df6d8"
- integrity sha512-iDio1mKJgdtvo9GT/d4QL/pvUzAxQOM7m/3fAY3pX2CAa25jwEwpUh7fNN+F3iEFkJWiDJusSPY/K3RPMfAoXg==
+"@glimmer/util@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.68.0.tgz#16fec2fb54a9cda6ceef8c3cbc2c47346704cefc"
+ integrity sha512-YUIcItWFkHilVwllZnkJggoBm7xDvN+VyMgcPk4jsmUlMrt3zy0C9XGgmDmnPqJ1Bl0gMCf5JUf59RByw8TNHQ==
dependencies:
"@glimmer/env" "0.1.7"
- "@glimmer/interfaces" "0.67.0"
+ "@glimmer/interfaces" "0.68.0"
"@simple-dom/interface" "^1.4.0"
-"@glimmer/validator@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/validator/-/validator-0.67.0.tgz#9d50db47152786c4e7d4304a73c498c53afc7886"
- integrity sha512-PQsTPU1N0erGtWVoHwkQ9N/jMb3iMoclyaBe3rVbxs6RSjYeafaxAqwN8rJ+Gd+OWQscD4tjPPguTW/iGQVlYQ==
+"@glimmer/validator@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/validator/-/validator-0.68.0.tgz#a9cab4a3eb6fdc432002e97d51fc07ec9fb144f4"
+ integrity sha512-KtDOCN1LxJW4/GRfhXZsHNsg3V0xHFklVhcXBdNjM/3mQDs5MIyaWJ+HduyLrFPC9I25/vjyH1zryBrD4+taiQ==
dependencies:
"@glimmer/env" "^0.1.7"
- "@glimmer/global-context" "0.67.0"
+ "@glimmer/global-context" "0.68.0"
-"@glimmer/vm@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/vm/-/vm-0.67.0.tgz#c31d7a2ea70ddd0da30fd5ce624311baef173942"
- integrity sha512-tqAxnPKwSAFYW1y4vpTSnsRR/F3sJ3GSMx2lzgc5YaWElYI9JcPBIM0sobqnoheca7wABLTWdFZXbnW9N0n0TQ==
+"@glimmer/vm@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/vm/-/vm-0.68.0.tgz#190da75b1ba7a717276976a0aceebf76cccc73c5"
+ integrity sha512-URAwgRiL2koR8OgWjDynYAvmefdqBo8oWbskWtazYivs+IJ341i8CA/YGo7L1XZcaXJY+lrdEZzhOmaLTMlAZA==
dependencies:
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/util" "0.67.0"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/util" "0.68.0"
-"@glimmer/wire-format@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.67.0.tgz#a29eda6fac008509a2aa312209dc128611834ef5"
- integrity sha512-YbRASQFsyKmVWgFF8SeAdoFSbrN9Zq8cfCvIjsx6JiiIelCgQ5fUtU8qZ9ww++5AYK6tQtVhkqM6DXyVMRVRjg==
+"@glimmer/wire-format@0.68.0":
+ version "0.68.0"
+ resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.68.0.tgz#456753d7d7f88a59287d6d0b68a348625c933bb1"
+ integrity sha512-Tb2oiJTw3qB91oV98xP0g5fu75u+A6lf46wCAPGXdfDRhK4qAteypeCy5wz6+1pFucPP1Mn3nZ9OUVGnnQOPTQ==
dependencies:
- "@glimmer/interfaces" "0.67.0"
- "@glimmer/util" "0.67.0"
+ "@glimmer/interfaces" "0.68.0"
+ "@glimmer/util" "0.68.0"
"@handlebars/parser@^1.1.0":
version "1.1.0"
| true |
Other
|
emberjs
|
ember.js
|
1ae3f13e5be1dc949045e7061b924fc0fa3ec47a.json
|
Add v3.24.0-beta.2 to CHANGELOG
(cherry picked from commit 46d27a0194009d39eb22b4f62e7033b8498bdef0)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.24.0-beta.2 (November 24, 2020)
+
+- [#19282](https://github.com/emberjs/ember.js/pull/19282) [BUGFIX] Issue deprecations (instead of assertions) for tracked mutation in constructor during rendering
+
### v3.24.0-beta.1 (November 16, 2020)
- [#19224](https://github.com/emberjs/ember.js/pull/19224) [FEATURE] Add `{{page-title}}` helper to route template blueprints to implement [RFC #0654](https://github.com/emberjs/rfcs/blob/master/text/0645-add-ember-page-title-addon.md).
| false |
Other
|
emberjs
|
ember.js
|
f1f7342774b7e4ba2ccc4266f8e4bfcc2120af88.json
|
Add v3.23.1 to CHANGELOG.md.
(cherry picked from commit 2a89d9a1a6692f4c58545810cd355e2f866b3284)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.23.1 (November 23, 2020)
+
+- [#19282](https://github.com/emberjs/ember.js/pull/19282) [BUGFIX] Issue deprecations (instead of assertions) for tracked mutation in constructor during rendering
+
### v3.24.0-beta.1 (November 16, 2020)
- [#19224](https://github.com/emberjs/ember.js/pull/19224) [FEATURE] Add `{{page-title}}` helper to route template blueprints to implement [RFC #0654](https://github.com/emberjs/rfcs/blob/master/text/0645-add-ember-page-title-addon.md).
| false |
Other
|
emberjs
|
ember.js
|
1393ab777d0a2511228b4e9a1eeee066288483db.json
|
Fix docs coverage
|
packages/@ember/-internals/views/lib/system/event_dispatcher.js
|
@@ -252,7 +252,7 @@ export default EmberObject.extend({
@param event the name of the event in the browser
*/
setupHandlerForBrowserEvent(event) {
- this._setupHandler(this._sanitizedRootElement, event, this.finalEventNameMapping[event]);
+ this.setupHandler(this._sanitizedRootElement, event, this.finalEventNameMapping[event]);
},
/**
@@ -263,7 +263,7 @@ export default EmberObject.extend({
@param eventName
*/
setupHandlerForEmberEvent(eventName) {
- this._setupHandler(
+ this.setupHandler(
this._sanitizedRootElement,
this._reverseEventNameMapping[eventName],
eventName
@@ -279,12 +279,12 @@ export default EmberObject.extend({
bubble to each successive parent view until it reaches the top.
@private
- @method _setupHandler
+ @method setupHandler
@param {Element} rootElement
@param {String} event the name of the event in the browser
@param {String} eventName the name of the method to call on the view
*/
- _setupHandler(rootElement, event, eventName) {
+ setupHandler(rootElement, event, eventName) {
if (eventName === null || !this.lazyEvents.has(event)) {
return; // nothing to do
}
| true |
Other
|
emberjs
|
ember.js
|
1393ab777d0a2511228b4e9a1eeee066288483db.json
|
Fix docs coverage
|
tests/docs/expected.js
|
@@ -528,6 +528,8 @@ module.exports = {
'setupController',
'setupForTesting',
'setupHandler',
+ 'setupHandlerForBrowserEvent',
+ 'setupHandlerForEmberEvent',
'setupRegistry',
'shiftObject',
'shouldRender',
| true |
Other
|
emberjs
|
ember.js
|
5f0621c9381c3e3c67aca4ae3bc430f8d9ab2492.json
|
Fix EventDispatcher test
|
packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js
|
@@ -1,7 +1,7 @@
import { RenderingTestCase, moduleFor, runTask } from 'internal-test-helpers';
import { Component } from '../utils/helpers';
-import { getCurrentRunLoop, run } from '@ember/runloop';
+import { getCurrentRunLoop } from '@ember/runloop';
import {
subscribe as instrumentationSubscribe,
reset as instrumentationReset,
@@ -420,12 +420,15 @@ moduleFor(
constructor() {
super(...arguments);
- let dispatcher = this.owner.lookup('event_dispatcher:main');
- run(dispatcher, 'destroy');
- this.owner.__container__.reset('event_dispatcher:main');
this.dispatcher = this.owner.lookup('event_dispatcher:main');
}
+ getBootOptions() {
+ return {
+ skipEventDispatcher: true,
+ };
+ }
+
['@test additional events can be specified'](assert) {
this.dispatcher.setup({ myevent: 'myEvent' });
| true |
Other
|
emberjs
|
ember.js
|
5f0621c9381c3e3c67aca4ae3bc430f8d9ab2492.json
|
Fix EventDispatcher test
|
packages/internal-test-helpers/lib/test-cases/rendering.js
|
@@ -31,7 +31,10 @@ export default class RenderingTestCase extends AbstractTestCase {
this.element = document.querySelector('#qunit-fixture');
this.component = null;
- if (!bootOptions || bootOptions.isInteractive !== false) {
+ if (
+ !bootOptions ||
+ (bootOptions.isInteractive !== false && bootOptions.skipEventDispatcher !== true)
+ ) {
owner.lookup('event_dispatcher:main').setup(this.getCustomDispatcherEvents(), this.element);
}
}
| true |
Other
|
emberjs
|
ember.js
|
b2f89ef997458ddbfee55ea6bc2465fc96c61608.json
|
Fix event handling of built-in components
|
packages/@ember/-internals/glimmer/lib/components/link-to.ts
|
@@ -13,6 +13,7 @@ import { inject as injectService } from '@ember/service';
import { DEBUG } from '@glimmer/env';
import EmberComponent, { HAS_BLOCK } from '../component';
import layout from '../templates/link-to';
+import { getOwner } from '@ember/-internals/owner';
/**
The `LinkTo` component renders a link to the supplied `routeName` passing an optionally
@@ -500,6 +501,11 @@ const LinkComponent = EmberComponent.extend({
// Map desired event name to invoke function
let { eventName } = this;
this.on(eventName, this, this._invoke);
+
+ // As our EventDispatcher adds event listeners lazily, and does not recognize the dynamic event pattern here,
+ // we must tell it explicitly that we need to listen to `eventName` events
+ let eventDispatcher = getOwner(this).lookup('event_dispatcher:main') as any;
+ eventDispatcher.setupHandler(eventName);
},
_routing: injectService('-routing'),
| true |
Other
|
emberjs
|
ember.js
|
b2f89ef997458ddbfee55ea6bc2465fc96c61608.json
|
Fix event handling of built-in components
|
packages/@ember/-internals/glimmer/lib/modifiers/action.ts
|
@@ -215,7 +215,7 @@ export default class ActionModifierManager
get setupEventHandler(): (eventName: string) => void {
if (this._setupEventHandler === undefined) {
let dispatcher = this.owner.lookup('event_dispatcher:main') as any; // @todo
- this._setupEventHandler = (eventName) => dispatcher['setupHandler'](eventName);
+ this._setupEventHandler = (eventName) => dispatcher.setupHandler(eventName);
}
return this._setupEventHandler;
| true |
Other
|
emberjs
|
ember.js
|
b2f89ef997458ddbfee55ea6bc2465fc96c61608.json
|
Fix event handling of built-in components
|
packages/@ember/-internals/views/lib/mixins/text_support.js
|
@@ -136,13 +136,6 @@ export default Mixin.create(TargetActionSupport, {
disabled: false,
maxlength: null,
- init() {
- this._super(...arguments);
- this.on('paste', this, this._elementValueDidChange);
- this.on('cut', this, this._elementValueDidChange);
- this.on('input', this, this._elementValueDidChange);
- },
-
/**
Whether the `keyUp` event that triggers an `action` to be sent continues
propagating to other views.
@@ -178,6 +171,18 @@ export default Mixin.create(TargetActionSupport, {
this._elementValueDidChange(event);
},
+ paste(event) {
+ this._elementValueDidChange(event);
+ },
+
+ cut(event) {
+ this._elementValueDidChange(event);
+ },
+
+ input(event) {
+ this._elementValueDidChange(event);
+ },
+
/**
Allows you to specify a controller action to invoke when either the `enter`
key is pressed or, in the case of the field being a textarea, when a newline
| true |
Other
|
emberjs
|
ember.js
|
b2f89ef997458ddbfee55ea6bc2465fc96c61608.json
|
Fix event handling of built-in components
|
packages/@ember/-internals/views/lib/system/event_dispatcher.js
|
@@ -250,10 +250,10 @@ export default EmberObject.extend({
@private
@method setupHandler
- @param {Element} rootElement
@param {String} event the name of the event in the browser
@param {String} eventName the name of the method to call on the view
- */
+ @param {Element} rootElement
+ */
setupHandler(
event,
eventName = this._finalEventNameMapping[event],
| true |
Other
|
emberjs
|
ember.js
|
793fdddaaec8fe24ee9dafcf2ebda7a56d75b479.json
|
Add v3.24.0-beta.1 to CHANGELOG
(cherry picked from commit a39707f0a35a288426fa9dcaaf5d86d06e8f576e)
|
CHANGELOG.md
|
@@ -1,5 +1,22 @@
# Ember Changelog
+### v3.24.0-beta.1 (November 16, 2020)
+
+- [#19224](https://github.com/emberjs/ember.js/pull/19224) [FEATURE] Add `{{page-title}}` helper to route template blueprints to implement [RFC #0654](https://github.com/emberjs/rfcs/blob/master/text/0645-add-ember-page-title-addon.md).
+- [#19133](https://github.com/emberjs/ember.js/pull/19133) [FEATURE / DEPRECATION] Add new options to `deprecate()` for `for` and `since` and deprecate using `deprecate()` without those options per the [Deprecation Staging RFC](https://github.com/emberjs/rfcs/blob/master/text/0649-deprecation-staging.md).
+- [#19211](https://github.com/emberjs/ember.js/pull/19211) [DEPRECATION] Deprecate `Ember.String.loc` and `{{loc}}` per the [Deprecate Ember String RFC](https://github.com/emberjs/rfcs/blob/master/text/0236-deprecation-ember-string.md).
+- [#19234](https://github.com/emberjs/ember.js/pull/19234) [DEPRECATION] Deprecate String Prototype extensions per the [Deprecate Ember String RFC](https://github.com/emberjs/rfcs/blob/master/text/0236-deprecation-ember-string.md).
+- [#19254](https://github.com/emberjs/ember.js/pull/19254) [DEPRECATION] Deprecate tryInvoke to implement the [Deprecate `tryInvoke` RFC](https://github.com/emberjs/rfcs/blob/master/text/0673-deprecate-tryinvoke.md).
+- [#19080](https://github.com/emberjs/ember.js/pull/19080) [BUGFIX] Lazily setup the router in non-application tests
+- [#19253](https://github.com/emberjs/ember.js/pull/19253) [BUGFIX] Correct return of getComponentTemplate from null to undefined to align with original RFC (#481)
+- [#19223](https://github.com/emberjs/ember.js/pull/19223) [BUGFIX] `<LinkTo>` should link within the engine when used inside one
+- [#19196](https://github.com/emberjs/ember.js/pull/19196) [CLEANUP] Remove EMBER_GLIMMER_IN_ELEMENT feature flag
+- [#19204](https://github.com/emberjs/ember.js/pull/19204) [CLEANUP] Remove EMBER_CACHE_API feature flag
+- [#19206](https://github.com/emberjs/ember.js/pull/19206) [CLEANUP] Remove EMBER_ROUTING_MODEL_ARG feature flag
+- [#19229](https://github.com/emberjs/ember.js/pull/19229) [CLEANUP] Remove the EMBER_GLIMMER_SET_COMPONENT_TEMPLATE feature flag
+- [#19238](https://github.com/emberjs/ember.js/pull/19238) [CLEANUP] Removes the `expandLocalLookup` API
+- [#19258](https://github.com/emberjs/ember.js/pull/19258) / [#19261](https://github.com/emberjs/ember.js/pull/19261) / [#19267](https://github.com/emberjs/ember.js/pull/19267) Update rendering engine to 0.65.0
+
### v3.23.0 (November 16, 2020)
- [#19160](https://github.com/emberjs/ember.js/pull/19160) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements the helper manager feature specified in the [Helper Managers RFC](https://github.com/emberjs/rfcs/blob/master/text/0625-helper-managers.md).
| false |
Other
|
emberjs
|
ember.js
|
b30895b58ce33aa751333825718f1b5f9eb7709a.json
|
Add v3.23.0 to CHANGELOG
(cherry picked from commit 21447b22453c5f6366e81d455f0b1c27aef087ca)
|
CHANGELOG.md
|
@@ -1,32 +1,20 @@
# Ember Changelog
-### v3.23.0-beta.5 (November 9, 2020)
-
-- [#19249](https://github.com/emberjs/ember.js/pull/19249) [BUGFIX] Fix bugs in query params with intermediate transitions
-
-### v3.23.0-beta.4 (November 2, 2020)
-
-- [#19142](https://github.com/emberjs/ember.js/pull/19142) [BUGFIX] Fix App booting before DOM ready without jQuery
-- [#19198](https://github.com/emberjs/ember.js/pull/19198) / [#19232](https://github.com/emberjs/ember.js/pull/19232) [BUGFIX] Restores the shadowed property set behavior
-
-### v3.23.0-beta.3 (October 26, 2020)
-
-- [#19199](https://github.com/emberjs/ember.js/pull/19199) [BUGFIX] Fix Ember Inspector to not be in a broken state after render errors
-- [#19221](https://github.com/emberjs/ember.js/pull/19221) [BUGFIX] Ensure fn and (mut) work with falsy values
-
-### v3.23.0-beta.2 (October 19, 2020)
-
-- [#19193](https://github.com/emberjs/ember.js/pull/19193) [BUGFIX] Ensure user lifecycle hooks are untracked
-- [#19213](https://github.com/emberjs/ember.js/pull/19213) [BUGFIX] Update rendering engine to improve error ergonomics.
-
-### v3.23.0-beta.1 (October 5, 2020)
+### v3.23.0 (November 16, 2020)
- [#19160](https://github.com/emberjs/ember.js/pull/19160) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements the helper manager feature specified in the [Helper Managers RFC](https://github.com/emberjs/rfcs/blob/master/text/0625-helper-managers.md).
- [#19171](https://github.com/emberjs/ember.js/pull/19171) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements `invokeHelper` from the [JavaScript Helper Invocation API RFC](https://github.com/emberjs/rfcs/blob/master/text/0626-invoke-helper.md).
- [#19148](https://github.com/emberjs/ember.js/pull/19148) / [#19119](https://github.com/emberjs/ember.js/pull/19119) Update rendering engine to `@glimmer/*` 0.62.1
- [#19122](https://github.com/emberjs/ember.js/pull/19122) [BUGFIX] Prevents dynamic invocations of string values when referenced directly in angle brackets
- [#19136](https://github.com/emberjs/ember.js/pull/19136) [BUGFIX] Update router microlib to improve Transition related debugging
- [#19173](https://github.com/emberjs/ember.js/pull/19173) [BUGFIX] Enforce usage of `capabilities` generation.
+- [#19236](https://github.com/emberjs/ember.js/pull/19236) [BUGFIX] Only serialize query params once on activeTransition
+- [#19250](https://github.com/emberjs/ember.js/pull/19250) [BUGFIX] Prevents infinite rerenders when errors occur during render
+- [#19249](https://github.com/emberjs/ember.js/pull/19249) [BUGFIX] Fix bugs in query params with intermediate transitions
+- [#19142](https://github.com/emberjs/ember.js/pull/19142) [BUGFIX] Fix App booting before DOM ready without jQuery
+- [#19198](https://github.com/emberjs/ember.js/pull/19198) / [#19232](https://github.com/emberjs/ember.js/pull/19232) [BUGFIX] Restores the shadowed property set behavior
+- [#19221](https://github.com/emberjs/ember.js/pull/19221) [BUGFIX] Ensure fn and (mut) work with falsy values
+- [#19213](https://github.com/emberjs/ember.js/pull/19213) [BUGFIX] Update rendering engine to improve error ergonomics.
### v3.22.1 (November 10, 2020)
| false |
Other
|
emberjs
|
ember.js
|
f2104f2d2a092cfdb95317f1f6745dcc498f1334.json
|
Add v3.22.1 to CHANGELOG.md.
(cherry picked from commit 566424788b313efb8f4a63e182b461a013db8e05)
|
CHANGELOG.md
|
@@ -28,6 +28,13 @@
- [#19136](https://github.com/emberjs/ember.js/pull/19136) [BUGFIX] Update router microlib to improve Transition related debugging
- [#19173](https://github.com/emberjs/ember.js/pull/19173) [BUGFIX] Enforce usage of `capabilities` generation.
+### v3.22.1 (November 10, 2020)
+
+- [#19193](https://github.com/emberjs/ember.js/pull/19193) [BUGFIX] Ensure `@ember/component` user lifecycle hooks are untracked
+- [#19197](https://github.com/emberjs/ember.js/pull/19197) [BUGFIX] Restore the shadowed property set behavior
+- [#19199](https://github.com/emberjs/ember.js/pull/19199) [BUGFIX] Cleans up the DebugRenderTree more thoroughly on errors
+- [#19249](https://github.com/emberjs/ember.js/pull/19249) [BUGFIX] Fix issues with query params during intermediate transitions
+
### v3.22.0 (October 5, 2020)
- [#19062](https://github.com/emberjs/ember.js/pull/19062) / [#19068](https://github.com/emberjs/ember.js/pull/19068) [FEATURE] Add @ember/destroyable feature from the [Destroyables RFC](https://github.com/emberjs/rfcs/blob/master/text/0580-destroyables.md).
| false |
Other
|
emberjs
|
ember.js
|
4c9499d836122c4277cee48327e971fd3ace0c77.json
|
Add v3.20.6 to CHANGELOG.md.
|
CHANGELOG.md
|
@@ -58,6 +58,14 @@
- [#19087](https://github.com/emberjs/ember.js/pull/19087) [BUGFIX] Generated initializer tests no longer causes a deprecation warning
- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
+### v3.20.6 (November 11, 2020)
+
+- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters
+- [#19158](https://github.com/emberjs/ember.js/pull/19158) [BUGFIX] `RouterService#isActive()` now consumes `currentURL` to 3.20
+- [#19164](https://github.com/emberjs/ember.js/pull/19164) [BUGFIX] Entangles custom EmberArray implementations when accessed
+- [#19172](https://github.com/emberjs/ember.js/pull/19172) / [#19197](https://github.com/emberjs/ember.js/pull/19197) [BUGFIX] Ensures that tracked properties initialize property
+- [#19178](https://github.com/emberjs/ember.js/pull/19178) [BUGFIX] Allow computeds to have cycles in their deps
+
### v3.20.5 (August 28, 2020)
- [#19106](https://github.com/emberjs/ember.js/pull/19106) [BUGFIX] Ensure `destroy` methods on `CoreObject` are invoked.
| false |
Other
|
emberjs
|
ember.js
|
70fffeaa6320cc84455a1367fd1c84f89d30151b.json
|
Add v3.23.0-beta.5 to CHANGELOG
(cherry picked from commit f757e5722048843b6f37a48514aec9eddbf27f79)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.23.0-beta.5 (November 9, 2020)
+
+- [#19249](https://github.com/emberjs/ember.js/pull/19249) [BUGFIX] Fix bugs in query params with intermediate transitions
+
### v3.23.0-beta.4 (November 2, 2020)
- [#19142](https://github.com/emberjs/ember.js/pull/19142) [BUGFIX] Fix App booting before DOM ready without jQuery
| false |
Other
|
emberjs
|
ember.js
|
ec49e0eee542791ca6916a71096988acab9c2ec0.json
|
Add v3.23.0-beta.4 to CHANGELOG
(cherry picked from commit 09ecf1cd3be31b0320e400d7172de0f13352d027)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.23.0-beta.4 (November 2, 2020)
+
+- [#19142](https://github.com/emberjs/ember.js/pull/19142) [BUGFIX] Fix App booting before DOM ready without jQuery
+- [#19198](https://github.com/emberjs/ember.js/pull/19198) / [#19232](https://github.com/emberjs/ember.js/pull/19232) [BUGFIX] Restores the shadowed property set behavior
+
### v3.23.0-beta.3 (October 26, 2020)
- [#19199](https://github.com/emberjs/ember.js/pull/19199) [BUGFIX] Fix Ember Inspector to not be in a broken state after render errors
| false |
Other
|
emberjs
|
ember.js
|
05e278a573a07f40177f75a5ab3daa41ea738d44.json
|
Add v3.23.0-beta.3 to CHANGELOG
(cherry picked from commit a8aff10265bcfdbc1dafbe4d01669d8e5107328e)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.23.0-beta.3 (October 26, 2020)
+
+- [#19199](https://github.com/emberjs/ember.js/pull/19199) [BUGFIX] Fix Ember Inspector to not be in a broken state after render errors
+- [#19221](https://github.com/emberjs/ember.js/pull/19221) [BUGFIX] Ensure fn and (mut) work with falsy values
+
### v3.23.0-beta.2 (October 19, 2020)
- [#19193](https://github.com/emberjs/ember.js/pull/19193) [BUGFIX] Ensure user lifecycle hooks are untracked
| false |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/@ember/-internals/glimmer/lib/modifiers/on.ts
|
@@ -69,7 +69,7 @@ export class OnModifierState {
this.args = args;
}
- updateFromArgs() {
+ updateFromArgs(): void {
let { args } = this;
let { once, passive, capture }: AddEventListenerOptions = reifyNamed(args.named);
@@ -321,15 +321,15 @@ export default class OnModifierManager implements ModifierManager<OnModifierStat
this.owner = owner;
}
- getDebugName() {
+ getDebugName(): string {
return 'on';
}
- get counters() {
+ get counters(): {adds: number, removes: number} {
return { adds, removes };
}
- create(element: SimpleElement | Element, _state: unknown, args: VMArguments) {
+ create(element: SimpleElement | Element, _state: unknown, args: VMArguments): OnModifierState | null {
if (!this.isInteractive) {
return null;
}
@@ -347,7 +347,7 @@ export default class OnModifierManager implements ModifierManager<OnModifierStat
return state.tag;
}
- install(state: OnModifierState | null) {
+ install(state: OnModifierState | null): void {
if (state === null) {
return;
}
@@ -363,7 +363,7 @@ export default class OnModifierManager implements ModifierManager<OnModifierStat
state.shouldUpdate = false;
}
- update(state: OnModifierState | null) {
+ update(state: OnModifierState | null): void {
if (state === null) {
return;
}
@@ -386,7 +386,7 @@ export default class OnModifierManager implements ModifierManager<OnModifierStat
state.shouldUpdate = false;
}
- getDestroyable(state: OnModifierState | null) {
+ getDestroyable(state: OnModifierState | null): OnModifierState | null {
return state;
}
}
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/@ember/-internals/glimmer/lib/template_registry.ts
|
@@ -7,11 +7,11 @@ interface TemplatesRegistry {
}
let TEMPLATES: TemplatesRegistry = {};
-export function setTemplates(templates: TemplatesRegistry) {
+export function setTemplates(templates: TemplatesRegistry): void {
TEMPLATES = templates;
}
-export function getTemplates() {
+export function getTemplates(): TemplatesRegistry {
return TEMPLATES;
}
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/@ember/-internals/glimmer/lib/utils/curly-component-state-bucket.ts
|
@@ -60,7 +60,7 @@ export default class ComponentStateBucket {
registerDestructor(this, () => this.component.destroy());
}
- willDestroy() {
+ willDestroy(): void {
let { component, environment } = this;
if (environment.isInteractive) {
@@ -80,7 +80,7 @@ export default class ComponentStateBucket {
component.renderer.unregister(component);
}
- finalize() {
+ finalize(): void {
let { finalizer } = this;
finalizer();
this.finalizer = NOOP;
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/@ember/-internals/utils/lib/super.ts
|
@@ -54,16 +54,16 @@ function createObserverListenerMetaFor(fn: Function) {
return meta;
}
-export function observerListenerMetaFor(fn: Function) {
+export function observerListenerMetaFor(fn: Function): ObserverListenerMeta | undefined {
return OBSERVERS_LISTENERS_MAP.get(fn);
}
-export function setObservers(func: Function, observers: { paths: string[]; sync: boolean }) {
+export function setObservers(func: Function, observers: { paths: string[]; sync: boolean }): void {
let meta = createObserverListenerMetaFor(func);
meta.observers = observers;
}
-export function setListeners(func: Function, listeners: string[]) {
+export function setListeners(func: Function, listeners: string[]): void {
let meta = createObserverListenerMetaFor(func);
meta.listeners = listeners;
}
@@ -82,7 +82,7 @@ const IS_WRAPPED_FUNCTION_SET = new WeakSet();
@param {Function} superFunc The super function.
@return {Function} wrapped function.
*/
-export function wrap(func: Function, superFunc: Function) {
+export function wrap(func: Function, superFunc: Function): Function {
if (!hasSuper(func)) {
return func;
}
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/@ember/-internals/views/lib/system/utils.ts
|
@@ -9,14 +9,14 @@ import { Dict, Option } from '@glimmer/interfaces';
@module ember
*/
-export function isSimpleClick(event: MouseEvent) {
+export function isSimpleClick(event: MouseEvent): boolean {
let modifier = event.shiftKey || event.metaKey || event.altKey || event.ctrlKey;
let secondaryClick = event.which > 1; // IE9 may return undefined
return !modifier && !secondaryClick;
}
-export function constructStyleDeprecationMessage(affectedStyle: string) {
+export function constructStyleDeprecationMessage(affectedStyle: string): string {
return (
'' +
'Binding style attributes may introduce cross-site scripting vulnerabilities; ' +
@@ -116,7 +116,7 @@ const CHILD_VIEW_IDS: WeakMap<View, Set<string>> = new WeakMap();
@method getChildViews
@param {Ember.View} view
*/
-export function getChildViews(view: View) {
+export function getChildViews(view: View): View[] {
let owner = getOwner(view);
let registry = owner.lookup<Dict<View>>('-view-registry:main')!;
return collectChildViews(view, registry);
@@ -227,12 +227,12 @@ export const elMatches: typeof Element.prototype.matches | undefined =
Element.prototype['webkitMatchesSelector']
: undefined;
-export function matches(el: Element, selector: string) {
+export function matches(el: Element, selector: string): boolean {
assert('cannot call `matches` in fastboot mode', elMatches !== undefined);
return elMatches!.call(el, selector);
}
-export function contains(a: Node, b: Node) {
+export function contains(a: Node, b: Node): boolean {
if (a.contains !== undefined) {
return a.contains(b);
}
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/ember-template-compiler/lib/system/compile-options.ts
|
@@ -76,7 +76,7 @@ function wrapLegacyPluginIfNeeded(_plugin: PluginFunc | LegacyPluginClass): Plug
return plugin as PluginFunc;
}
-export function registerPlugin(type: string, _plugin: PluginFunc | LegacyPluginClass) {
+export function registerPlugin(type: string, _plugin: PluginFunc | LegacyPluginClass): void {
if (type !== 'ast') {
throw new Error(
`Attempting to register ${_plugin} as "${type}" which is not a valid Glimmer plugin type.`
@@ -95,7 +95,7 @@ export function registerPlugin(type: string, _plugin: PluginFunc | LegacyPluginC
USER_PLUGINS = [plugin, ...USER_PLUGINS];
}
-export function unregisterPlugin(type: string, PluginClass: PluginFunc | LegacyPluginClass) {
+export function unregisterPlugin(type: string, PluginClass: PluginFunc | LegacyPluginClass): void {
if (type !== 'ast') {
throw new Error(
`Attempting to unregister ${PluginClass} as "${type}" which is not a valid Glimmer plugin type.`
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/ember-template-compiler/tests/utils/transform-test-case.ts
|
@@ -5,7 +5,7 @@ import { AbstractTestCase } from 'internal-test-helpers';
import { compileOptions } from '../../index';
export default class extends AbstractTestCase {
- assertTransformed(before: string, after: string) {
+ assertTransformed(before: string, after: string): void {
this.assert.deepEqual(deloc(ast(before)), deloc(ast(after)));
}
}
@@ -31,7 +31,9 @@ function ast(template: string): AST.Program {
moduleName: '-top-level',
});
- options.plugins!.ast!.push(extractProgram);
+ if (options.plugins.ast) {
+ options.plugins.ast.push(extractProgram);
+ }
precompile(template, options as any);
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/internal-test-helpers/lib/ember-dev/assertion.ts
|
@@ -30,7 +30,7 @@ const BREAK = {};
In particular, this prevents `Ember.assert` from throw errors that would
disrupt the control flow.
*/
-export function setupAssertionHelpers(hooks: NestedHooks, env: DebugEnv) {
+export function setupAssertionHelpers(hooks: NestedHooks, env: DebugEnv): void {
let originalAssertFunc = env.getDebugFunction('assert');
hooks.beforeEach(function (assert) {
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/internal-test-helpers/lib/ember-dev/containers.ts
|
@@ -2,7 +2,7 @@ import { Container } from '@ember/-internals/container';
const { _leakTracking: containerLeakTracking } = Container;
-export function setupContainersCheck(hooks: NestedHooks) {
+export function setupContainersCheck(hooks: NestedHooks): void {
hooks.afterEach(function () {
if (containerLeakTracking === undefined) return;
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/internal-test-helpers/lib/ember-dev/debug.ts
|
@@ -12,21 +12,21 @@ class DebugAssert {
this.tracker = null;
}
- inject() {}
+ inject(): void {}
- restore() {
+ restore(): void {
this.reset();
}
- reset() {
+ reset(): void {
if (this.tracker) {
this.tracker.restoreMethod();
}
this.tracker = null;
}
- assert() {
+ assert(): void {
if (this.tracker) {
this.tracker.assert();
}
@@ -38,7 +38,7 @@ class DebugAssert {
func: (() => any) | undefined,
callback: (tracker: MethodCallTracker) => void,
async = false
- ) {
+ ): void {
let originalTracker: MethodCallTracker | null = null;
// When helpers are passed a callback, they get a new tracker context
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/internal-test-helpers/lib/ember-dev/deprecation.ts
|
@@ -21,7 +21,7 @@ declare global {
}
}
-export function setupDeprecationHelpers(hooks: NestedHooks, env: DebugEnv) {
+export function setupDeprecationHelpers(hooks: NestedHooks, env: DebugEnv): void {
let assertion = new DeprecationAssert(env);
hooks.beforeEach(function () {
@@ -40,7 +40,7 @@ class DeprecationAssert extends DebugAssert {
super('deprecate', env);
}
- inject() {
+ inject(): void {
// Expects no deprecation to happen within a function, or if no function is
// passed, from the time of calling until the end of the test.
//
@@ -127,7 +127,7 @@ class DeprecationAssert extends DebugAssert {
window.ignoreDeprecation = ignoreDeprecation;
}
- restore() {
+ restore(): void {
super.restore();
window.expectDeprecation = null;
window.expectDeprecationAsync = null;
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/internal-test-helpers/lib/ember-dev/method-call-tracker.ts
|
@@ -24,7 +24,7 @@ export default class MethodCallTracker {
this._originalMethod = undefined;
}
- stubMethod() {
+ stubMethod(): void {
if (this._originalMethod) {
// Method is already stubbed
return;
@@ -42,32 +42,32 @@ export default class MethodCallTracker {
});
}
- restoreMethod() {
+ restoreMethod(): void {
if (this._originalMethod) {
this._env.setDebugFunction(this._methodName, this._originalMethod);
}
}
- expectCall(message: Message, options?: OptionList) {
+ expectCall(message: Message, options?: OptionList): void {
this.stubMethod();
this._expectedMessages.push(message || /.*/);
this._expectedOptionLists.push(options);
}
- expectNoCalls() {
+ expectNoCalls(): void {
this.stubMethod();
this._isExpectingNoCalls = true;
}
- isExpectingNoCalls() {
+ isExpectingNoCalls(): boolean {
return this._isExpectingNoCalls;
}
- isExpectingCalls() {
+ isExpectingCalls(): boolean | number {
return !this._isExpectingNoCalls && this._expectedMessages.length;
}
- assert() {
+ assert(): void {
let { assert } = QUnit.config.current;
let methodName = this._methodName;
let isExpectingNoCalls = this._isExpectingNoCalls;
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/internal-test-helpers/lib/ember-dev/namespaces.ts
|
@@ -1,7 +1,7 @@
import { NAMESPACES, NAMESPACES_BY_ID } from '@ember/-internals/metal';
import { run } from '@ember/runloop';
-export function setupNamespacesCheck(hooks: NestedHooks) {
+export function setupNamespacesCheck(hooks: NestedHooks): void {
hooks.afterEach(function () {
let { assert } = QUnit.config.current;
| true |
Other
|
emberjs
|
ember.js
|
a492ffedd7db6b641fd7e8e10fb9483d619995f7.json
|
fix linter warnings in 14 files
|
packages/internal-test-helpers/lib/ember-dev/observers.ts
|
@@ -1,7 +1,7 @@
import { ASYNC_OBSERVERS, SYNC_OBSERVERS } from '@ember/-internals/metal';
import { run } from '@ember/runloop';
-export function setupObserversCheck(hooks: NestedHooks) {
+export function setupObserversCheck(hooks: NestedHooks): void {
hooks.afterEach(function () {
let { assert } = QUnit.config.current;
| true |
Other
|
emberjs
|
ember.js
|
29b096bdceb31a6afabb9955e4f67a10b4e7e621.json
|
fix linitng warnings in run.ts file
|
packages/internal-test-helpers/lib/run.ts
|
@@ -9,29 +9,29 @@ import {
import { Promise } from 'rsvp';
-export function runAppend(view: any) {
+export function runAppend(view: any): void {
run(view, 'appendTo', document.getElementById('qunit-fixture'));
}
-export function runDestroy(toDestroy: any) {
+export function runDestroy(toDestroy: any): void {
if (toDestroy) {
run(toDestroy, 'destroy');
}
}
-export function runTask(callback: Function) {
+export function runTask(callback: Function): Function {
return run(callback);
}
export function runTaskNext(): Promise<void> {
- return new Promise((resolve) => {
+ return new Promise((resolve: Function) => {
return next(resolve);
});
}
// TODO: Find a better name 😎
export function runLoopSettled(event?: any): Promise<void> {
- return new Promise(function (resolve) {
+ return new Promise(function (resolve: Function) {
// Every 5ms, poll for the async thing to have finished
let watcher = setInterval(() => {
// If there are scheduled timers or we are inside of a run loop, keep polling
| false |
Other
|
emberjs
|
ember.js
|
3a866f974b6605db8a9a2b32355a7388de6ed536.json
|
Add v3.23.0-beta.2 to CHANGELOG
(cherry picked from commit 4bfc97e683e623174263471e71e9ddf9b8a739b8)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.23.0-beta.2 (October 19, 2020)
+
+- [#19193](https://github.com/emberjs/ember.js/pull/19193) [BUGFIX] Ensure user lifecycle hooks are untracked
+- [#19213](https://github.com/emberjs/ember.js/pull/19213) [BUGFIX] Update rendering engine to improve error ergonomics.
+
### v3.23.0-beta.1 (October 5, 2020)
- [#19160](https://github.com/emberjs/ember.js/pull/19160) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements the helper manager feature specified in the [Helper Managers RFC](https://github.com/emberjs/rfcs/blob/master/text/0625-helper-managers.md).
| false |
Other
|
emberjs
|
ember.js
|
fb1f3e665cd9690784b8112434cc44e1ffd71b71.json
|
add constants to test-framework-detector
|
blueprints/test-framework-detector.js
|
@@ -11,37 +11,40 @@ module.exports = function (blueprint) {
blueprint.filesPath = function () {
let type;
+ const qunitRfcVersion = 'qunit-rfc-232';
+ const mochaRfcVersion = 'mocha-rfc-232';
+ const mochaVersion = 'mocha-0.12';
let dependencies = this.project.dependencies();
if ('ember-qunit' in dependencies) {
- type = 'qunit-rfc-232';
+ type = qunitRfcVersion;
} else if ('ember-cli-qunit' in dependencies) {
let checker = new VersionChecker(this.project);
if (
- fs.existsSync(this.path + '/qunit-rfc-232-files') &&
+ fs.existsSync(`${this.path}/${qunitRfcVersion}-files`) &&
checker.for('ember-cli-qunit', 'npm').gte('4.2.0')
) {
- type = 'qunit-rfc-232';
+ type = qunitRfcVersion;
} else {
type = 'qunit';
}
} else if ('ember-mocha' in dependencies) {
let checker = new VersionChecker(this.project);
if (
- fs.existsSync(this.path + '/mocha-rfc-232-files') &&
+ fs.existsSync(`${this.path}/${mochaRfcVersion}-files`) &&
checker.for('ember-mocha', 'npm').gte('0.14.0')
) {
- type = 'mocha-rfc-232';
+ type = mochaRfcVersion;
} else {
- type = 'mocha-0.12';
+ type = mochaVersion;
}
} else if ('ember-cli-mocha' in dependencies) {
let checker = new VersionChecker(this.project);
if (
- fs.existsSync(this.path + '/mocha-0.12-files') &&
+ fs.existsSync(`${this.path}/${mochaVersion}-files`) &&
checker.for('ember-cli-mocha', 'npm').gte('0.12.0')
) {
- type = 'mocha-0.12';
+ type = mochaVersion;
} else {
type = 'mocha';
}
| false |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/@ember/-internals/glimmer/tests/integration/application/engine-test.js
|
@@ -551,12 +551,7 @@ moduleFor(
},
})
);
- this.register(
- 'template:application_error',
- compile(
- 'Error! {{@model.message}}'
- )
- );
+ this.register('template:application_error', compile('Error! {{@model.message}}'));
this.register(
'route:post',
Route.extend({
@@ -595,12 +590,7 @@ moduleFor(
},
})
);
- this.register(
- 'template:error',
- compile(
- 'Error! {{@model.message}}'
- )
- );
+ this.register('template:error', compile('Error! {{@model.message}}'));
this.register(
'route:post',
Route.extend({
@@ -639,12 +629,7 @@ moduleFor(
},
})
);
- this.register(
- 'template:post_error',
- compile(
- 'Error! {{@model.message}}'
- )
- );
+ this.register('template:post_error', compile('Error! {{@model.message}}'));
this.register(
'route:post',
Route.extend({
@@ -683,12 +668,7 @@ moduleFor(
},
})
);
- this.register(
- 'template:post.error',
- compile(
- 'Error! {{@model.message}}'
- )
- );
+ this.register('template:post.error', compile('Error! {{@model.message}}'));
this.register(
'route:post.comments',
Route.extend({
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js
|
@@ -194,9 +194,7 @@ moduleFor(
`);
}
- async ['@test interior mutations on the model with tracked properties'](
- assert
- ) {
+ async ['@test interior mutations on the model with tracked properties'](assert) {
class Model {
@tracked color;
@@ -317,9 +315,7 @@ moduleFor(
`);
}
- async ['@test exterior mutations on the model with tracked properties'](
- assert
- ) {
+ async ['@test exterior mutations on the model with tracked properties'](assert) {
this.router.map(function () {
this.route('color', { path: '/:color' });
});
@@ -712,9 +708,7 @@ moduleFor(
});
}
- async ['@test it emits a useful backtracking re-render assertion message'](
- assert
- ) {
+ async ['@test it emits a useful backtracking re-render assertion message'](assert) {
this.router.map(function () {
this.route('routeWithError');
});
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-angle-test.js
|
@@ -916,9 +916,7 @@ moduleFor(
});
}
- async [`@test The <LinkTo /> component moves into the named route with context`](
- assert
- ) {
+ async [`@test The <LinkTo /> component moves into the named route with context`](assert) {
this.router.map(function () {
this.route('about');
this.route('item', { path: '/item/:id' });
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-curly-test.js
|
@@ -916,9 +916,7 @@ moduleFor(
});
}
- async [`@test The {{link-to}} component moves into the named route with context`](
- assert
- ) {
+ async [`@test The {{link-to}} component moves into the named route with context`](assert) {
this.router.map(function () {
this.route('about');
this.route('item', { path: '/item/:id' });
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/@ember/-internals/glimmer/tests/integration/mount-test.js
|
@@ -322,12 +322,9 @@ moduleFor(
this._super(...arguments);
this.register(
'template:application',
- compile(
- '<h2>Param Engine: {{@model.foo}}</h2>',
- {
- moduleName: 'my-app/templates/application.hbs',
- }
- )
+ compile('<h2>Param Engine: {{@model.foo}}</h2>', {
+ moduleName: 'my-app/templates/application.hbs',
+ })
);
},
})
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/ember/tests/homepage_example_test.js
|
@@ -7,10 +7,7 @@ import { moduleFor, ApplicationTestCase } from 'internal-test-helpers';
moduleFor(
'The example renders correctly',
class extends ApplicationTestCase {
-
- async ['@test Render index template into application outlet'](
- assert
- ) {
+ async ['@test Render index template into application outlet'](assert) {
this.addTemplate('application', '{{outlet}}');
this.addTemplate(
'index',
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/ember/tests/routing/model_loading_test.js
|
@@ -397,9 +397,7 @@ moduleFor(
});
}
- [`@test The Specials Page getting its model by deserializing the params hash`](
- assert
- ) {
+ [`@test The Specials Page getting its model by deserializing the params hash`](assert) {
this.router.map(function () {
this.route('home', { path: '/' });
this.route('special', { path: '/specials/:menu_item_id' });
@@ -446,9 +444,7 @@ moduleFor(
});
}
- ['@test Moving from one page to another triggers the correct callbacks'](
- assert
- ) {
+ ['@test Moving from one page to another triggers the correct callbacks'](assert) {
assert.expect(3);
this.router.map(function () {
@@ -481,9 +477,7 @@ moduleFor(
});
}
- ['@test Nested callbacks are not exited when moving to siblings'](
- assert
- ) {
+ ['@test Nested callbacks are not exited when moving to siblings'](assert) {
let rootSetup = 0;
let rootRender = 0;
let rootModel = 0;
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/ember/tests/routing/router_service_test/transitionTo_test.js
|
@@ -158,9 +158,7 @@ moduleFor(
});
}
- async ['@test RouterService#transitionTo with dynamic segment'](
- assert
- ) {
+ async ['@test RouterService#transitionTo with dynamic segment'](assert) {
assert.expect(3);
let componentInstance;
@@ -196,9 +194,7 @@ moduleFor(
this.assertText('much dynamicism');
}
- async ['@test RouterService#transitionTo with dynamic segment and model hook'](
- assert
- ) {
+ async ['@test RouterService#transitionTo with dynamic segment and model hook'](assert) {
assert.expect(3);
let componentInstance;
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/ember/tests/routing/substates_test.js
|
@@ -676,9 +676,7 @@ moduleFor(
return promise;
}
- async ['@test Default error event moves into nested route'](
- assert
- ) {
+ async ['@test Default error event moves into nested route'](assert) {
await this.visit('/');
this.addTemplate('grandma.error', 'ERROR: {{@model.msg}}');
| true |
Other
|
emberjs
|
ember.js
|
02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json
|
Fix linting issues
|
packages/ember/tests/routing/template_rendering_test.js
|
@@ -204,9 +204,7 @@ moduleFor(
assert.equal(this.$('p').text(), 'YES I AM HOME', 'The homepage template was rendered');
}
- async [`@test Model passed via renderTemplate model is set as controller's model`](
- assert
- ) {
+ async [`@test Model passed via renderTemplate model is set as controller's model`](assert) {
this.addTemplate(
'bio',
'<p>Model: {{@model.name}}</p><p>Controller: {{this.model.name}}</p>'
@@ -550,9 +548,7 @@ moduleFor(
});
}
- async ["@test The template is not re-rendered when the route's model changes"](
- assert
- ) {
+ async ["@test The template is not re-rendered when the route's model changes"](assert) {
this.router.map(function () {
this.route('page', { path: '/page/:name' });
});
| true |
Other
|
emberjs
|
ember.js
|
c4e1cd1e572ae4efb1296ef664c6462b71ab2089.json
|
Remove use of deprecated set-env github action API
See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
|
.github/workflows/cron.yml
|
@@ -30,7 +30,7 @@ jobs:
git add cron.txt
git commit -m "Cron $(date +%Y-%m-%d) for ${{matrix.branch}}"
export SHA=`git rev-parse HEAD`
- echo "::set-env name=SHA::$SHA"
+ echo "SHA=$SHA" >> $GITHUB_ENV
- name: Push branch to trigger Build workflow
# This must use a personal access token because of a Github Actions
| false |
Other
|
emberjs
|
ember.js
|
009b51abde39bd1cb76d8ebd8ad0d2fe524d27b7.json
|
use constructor instead of init
|
packages/@ember/-internals/routing/lib/services/router.ts
|
@@ -1,4 +1,4 @@
-import { getOwner } from '@ember/-internals/owner';
+import { getOwner, Owner } from '@ember/-internals/owner';
import { Evented } from '@ember/-internals/runtime';
import { symbol } from '@ember/-internals/utils';
import { assert } from '@ember/debug';
@@ -77,10 +77,10 @@ export default class RouterService extends Service {
return (this[ROUTER] = router);
}
- init() {
- super.init(...arguments);
+ constructor(owner: Owner) {
+ super(owner);
- const router = getOwner(this).lookup('router:main') as EmberRouter;
+ const router = owner.lookup('router:main') as EmberRouter;
router.on('routeWillChange', (transition: Transition) => {
if (DEBUG) {
| false |
Other
|
emberjs
|
ember.js
|
56a1da5b3b56ed84f6de2193a4fb0c01c0c7d4f2.json
|
CHORE: combine two test cases into one
Since `jQuery.isReady = false;` is set before each test case.
|
packages/@ember/application/tests/readiness_test.js
|
@@ -96,6 +96,7 @@ moduleFor(
run(() => {
application = Application.create({ router: false });
application.deferReadiness();
+ assert.equal(readyWasCalled, 0, "ready wasn't called yet");
});
assert.equal(readyWasCalled, 0, "ready wasn't called yet");
@@ -110,28 +111,6 @@ moduleFor(
});
assert.equal(readyWasCalled, 1, 'ready was called now all readiness deferrals are advanced');
- }
-
- ["@test Application's ready event can be deferred by other components (jQuery.isReady === false)"](
- assert
- ) {
- jQuery.isReady = false;
-
- run(() => {
- application = Application.create({ router: false });
- application.deferReadiness();
- assert.equal(readyWasCalled, 0, "ready wasn't called yet");
- });
-
- domReady();
-
- assert.equal(readyWasCalled, 0, "ready wasn't called yet");
-
- run(() => {
- application.advanceReadiness();
- });
-
- assert.equal(readyWasCalled, 1, 'ready was called now all readiness deferrals are advanced');
expectAssertion(() => {
application.deferReadiness();
| false |
Other
|
emberjs
|
ember.js
|
c79a57ae3732d461aba234b2bd78d9fb4e90f862.json
|
Add v3.23.0-beta.1 to CHANGELOG
(cherry picked from commit dd71cbb7d8b895979e93cdcb3ac1cba3ddc3bab3)
|
CHANGELOG.md
|
@@ -1,5 +1,14 @@
# Ember Changelog
+### v3.23.0-beta.1 (October 5, 2020)
+
+- [#19160](https://github.com/emberjs/ember.js/pull/19160) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements the helper manager feature specified in the [Helper Managers RFC](https://github.com/emberjs/rfcs/blob/master/text/0625-helper-managers.md).
+- [#19171](https://github.com/emberjs/ember.js/pull/19171) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements `invokeHelper` from the [JavaScript Helper Invocation API RFC](https://github.com/emberjs/rfcs/blob/master/text/0626-invoke-helper.md).
+- [#19148](https://github.com/emberjs/ember.js/pull/19148) / [#19119](https://github.com/emberjs/ember.js/pull/19119) Update rendering engine to `@glimmer/*` 0.62.1
+- [#19122](https://github.com/emberjs/ember.js/pull/19122) [BUGFIX] Prevents dynamic invocations of string values when referenced directly in angle brackets
+- [#19136](https://github.com/emberjs/ember.js/pull/19136) [BUGFIX] Update router microlib to improve Transition related debugging
+- [#19173](https://github.com/emberjs/ember.js/pull/19173) [BUGFIX] Enforce usage of `capabilities` generation.
+
### v3.22.0 (October 5, 2020)
- [#19062](https://github.com/emberjs/ember.js/pull/19062) / [#19068](https://github.com/emberjs/ember.js/pull/19068) [FEATURE] Add @ember/destroyable feature from the [Destroyables RFC](https://github.com/emberjs/rfcs/blob/master/text/0580-destroyables.md).
| false |
Other
|
emberjs
|
ember.js
|
e2a6babc5fcca17f58343997854c558b5b5f1dd5.json
|
Add v3.22.0 to CHANGELOG
(cherry picked from commit 388d5c381a48c409ace0ac38f4dd35109fe8f0a2)
|
CHANGELOG.md
|
@@ -1,31 +1,14 @@
# Ember Changelog
-### v3.22.0-beta.5 (September 30, 2020)
-
-- [#19172](https://github.com/emberjs/ember.js/pull/19172) [BUGFIX] Ensures that tracked properties initialize property
-
-### v3.22.0-beta.4 (September 30, 2020)
-
-- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters
-- [#19094](https://github.com/emberjs/ember.js/pull/19094) [BUGFIX] Fix RouterService#isActive() to work with tracking
-- [#19163](https://github.com/emberjs/ember.js/pull/19163) [BUGFIX] Use args proxy for modifier managers.
-- [#19164](https://github.com/emberjs/ember.js/pull/19164) [BUGFIX] Entangles custom EmberArray implementations when accessed with `Ember.get`
-- [#19170](https://github.com/emberjs/ember.js/pull/19170) [BUGFIX] Make modifier manager 3.22 accept the resolved value directly.
-
-### v3.22.0-beta.3 (September 09, 2020)
-
-- [#19124](https://github.com/emberjs/ember.js/pull/19124) Fix rendering engine usage within a `fastboot` sandbox
-
-### v3.22.0-beta.2 (August 31, 2020)
-
-- [#19106](https://github.com/emberjs/ember.js/pull/19106) [BUGFIX] Ensure `destroy` methods on `CoreObject` are invoked.
-- [#19111](https://github.com/emberjs/ember.js/pull/19111) [BUGFIX] Fixes `ArrayProxy` length reactivity.
-
-### v3.22.0-beta.1 (August 24, 2020)
+### v3.22.0 (October 5, 2020)
- [#19062](https://github.com/emberjs/ember.js/pull/19062) / [#19068](https://github.com/emberjs/ember.js/pull/19068) [FEATURE] Add @ember/destroyable feature from the [Destroyables RFC](https://github.com/emberjs/rfcs/blob/master/text/0580-destroyables.md).
- [#18984](https://github.com/emberjs/ember.js/pull/18984) / [#19067](https://github.com/emberjs/ember.js/pull/19067) [FEATURE] Add low-level Cache API per [Autotracking Memoization RFC](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md)
- [#19086](https://github.com/emberjs/ember.js/pull/19086) [FEATURE] Pass transition object to activate/deactivate hooks and events
+- [#19094](https://github.com/emberjs/ember.js/pull/19094) [BUGFIX] Fix RouterService#isActive() to work with tracking
+- [#19163](https://github.com/emberjs/ember.js/pull/19163) [BUGFIX] Use args proxy for modifier managers.
+- [#19170](https://github.com/emberjs/ember.js/pull/19170) [BUGFIX] Make modifier manager 3.22 accept the resolved value directly.
+- [#19124](https://github.com/emberjs/ember.js/pull/19124) [BUGFIX] Fix rendering engine usage within a `fastboot` sandbox
### v3.21.3 (September 30, 2020)
| false |
Other
|
emberjs
|
ember.js
|
5becf8846a00a1be254cb777c31258f5f8b86c54.json
|
Keep browserstack key in plaintext
It turns out this was intentional. The key has no privileged access to anything in our case, and it needs to be in plaintext if we want to run browserstack against PRs.
|
.github/workflows/ci.yml
|
@@ -88,7 +88,9 @@ jobs:
- name: test:browserstack
env:
BROWSERSTACK_USERNAME: emberjscoreteam1
- BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
+ # This is in plaintext on purpose. It has no privileged access to anything (this is a free
+ # account) and it allows us to run browserstack tests against PRs.
+ BROWSERSTACK_ACCESS_KEY: o5LNEdygq1SP4L9kst4s
run: yarn test:browserstack
production-test:
| false |
Other
|
emberjs
|
ember.js
|
9a0d9a73ca82faea20ee18950c0b07cd4b71e859.json
|
Apply suggestions from code review
Co-authored-by: Jonathan Haines <jonno.haines@gmail.com>
|
.eslintrc.js
|
@@ -47,9 +47,9 @@ module.exports = {
rules: {
'@typescript-eslint/ban-ts-comment': 'warn',
- '@typescript-eslint/ban-types': 'warn',
- '@typescript-eslint/no-empty-function': 'warn',
- '@typescript-eslint/no-this-alias': 'warn',
+ '@typescript-eslint/ban-types': 'off',
+ '@typescript-eslint/no-empty-function': 'off',
+ '@typescript-eslint/no-this-alias': 'off',
'@typescript-eslint/no-var-requires': 'warn',
// TODO: Enable and fix these rules
| false |
Other
|
emberjs
|
ember.js
|
7fd407c2f80feb14d24a22ec762521bad563a746.json
|
Add v3.22.0-beta.5 to CHANGELOG
(cherry picked from commit ae3c065f7c3416f6c497b2a5b5d9e6dd4d549662)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.22.0-beta.5 (September 30, 2020)
+
+- [#19172](https://github.com/emberjs/ember.js/pull/19172) [BUGFIX] Ensures that tracked properties initialize property
+
### v3.22.0-beta.4 (September 30, 2020)
- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters
| false |
Other
|
emberjs
|
ember.js
|
984c9adaa2e863fd2f8dd919600f364e84c6a9a4.json
|
Add v3.22.0-beta.4 to CHANGELOG
(cherry picked from commit 3010b89abd5fd15e65414b1654222498eb6607bf)
|
CHANGELOG.md
|
@@ -1,5 +1,13 @@
# Ember Changelog
+### v3.22.0-beta.4 (September 30, 2020)
+
+- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters
+- [#19094](https://github.com/emberjs/ember.js/pull/19094) [BUGFIX] Fix RouterService#isActive() to work with tracking
+- [#19163](https://github.com/emberjs/ember.js/pull/19163) [BUGFIX] Use args proxy for modifier managers.
+- [#19164](https://github.com/emberjs/ember.js/pull/19164) [BUGFIX] Entangles custom EmberArray implementations when accessed with `Ember.get`
+- [#19170](https://github.com/emberjs/ember.js/pull/19170) [BUGFIX] Make modifier manager 3.22 accept the resolved value directly.
+
### v3.22.0-beta.3 (September 09, 2020)
- [#19124](https://github.com/emberjs/ember.js/pull/19124) Fix rendering engine usage within a `fastboot` sandbox
| false |
Other
|
emberjs
|
ember.js
|
389486714360f972eb44638c6874791d442c4216.json
|
Add v3.21.3 to CHANGELOG.md.
|
CHANGELOG.md
|
@@ -15,6 +15,10 @@
- [#18984](https://github.com/emberjs/ember.js/pull/18984) / [#19067](https://github.com/emberjs/ember.js/pull/19067) [FEATURE] Add low-level Cache API per [Autotracking Memoization RFC](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md)
- [#19086](https://github.com/emberjs/ember.js/pull/19086) [FEATURE] Pass transition object to activate/deactivate hooks and events
+### v3.21.3 (September 30, 2020)
+
+- [#19172](https://github.com/emberjs/ember.js/pull/19172) [BUGFIX] Ensures that tracked properties initialize property
+
### v3.21.2 (September 30, 2020)
- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters
| false |
Other
|
emberjs
|
ember.js
|
f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json
|
Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager).
|
packages/@ember/-internals/glimmer/lib/component-managers/custom.ts
|
@@ -19,6 +19,7 @@ import { EmberVMEnvironment } from '../environment';
import RuntimeResolver from '../resolver';
import { OwnedTemplate } from '../template';
import { argsProxyFor } from '../utils/args-proxy';
+import { buildCapabilities, InternalCapabilities } from '../utils/managers';
import AbstractComponentManager from './abstract';
const CAPABILITIES = {
@@ -49,6 +50,12 @@ export interface OptionalCapabilities {
};
}
+export interface Capabilities extends InternalCapabilities {
+ asyncLifeCycleCallbacks: boolean;
+ destructor: boolean;
+ updateHook: boolean;
+}
+
export function capabilities<Version extends keyof OptionalCapabilities>(
managerAPI: Version,
options: OptionalCapabilities[Version] = {}
@@ -64,11 +71,11 @@ export function capabilities<Version extends keyof OptionalCapabilities>(
updateHook = Boolean((options as OptionalCapabilities['3.13']).updateHook);
}
- return {
+ return buildCapabilities({
asyncLifeCycleCallbacks: Boolean(options.asyncLifecycleCallbacks),
destructor: Boolean(options.destructor),
updateHook,
- };
+ }) as Capabilities;
}
export interface DefinitionState<ComponentInstance> {
@@ -77,21 +84,9 @@ export interface DefinitionState<ComponentInstance> {
template: OwnedTemplate;
}
-export interface Capabilities {
- asyncLifeCycleCallbacks: boolean;
- destructor: boolean;
- updateHook: boolean;
-}
-
-// TODO: export ICapturedArgumentsValue from glimmer and replace this
-export interface Args {
- named: Dict<unknown>;
- positional: unknown[];
-}
-
export interface ManagerDelegate<ComponentInstance> {
capabilities: Capabilities;
- createComponent(factory: unknown, args: Args): ComponentInstance;
+ createComponent(factory: unknown, args: Arguments): ComponentInstance;
getContext(instance: ComponentInstance): unknown;
}
@@ -114,7 +109,7 @@ export function hasUpdateHook<ComponentInstance>(
export interface ManagerDelegateWithUpdateHook<ComponentInstance>
extends ManagerDelegate<ComponentInstance> {
- updateComponent(instance: ComponentInstance, args: Args): void;
+ updateComponent(instance: ComponentInstance, args: Arguments): void;
}
export function hasAsyncUpdateHook<ComponentInstance>(
| true |
Other
|
emberjs
|
ember.js
|
f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json
|
Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager).
|
packages/@ember/-internals/glimmer/lib/helpers/custom.ts
|
@@ -3,10 +3,11 @@ import { DEBUG } from '@glimmer/env';
import { Arguments, Helper as GlimmerHelper } from '@glimmer/interfaces';
import { createComputeRef, UNDEFINED_REFERENCE } from '@glimmer/reference';
import { argsProxyFor } from '../utils/args-proxy';
+import { buildCapabilities, InternalCapabilities } from '../utils/managers';
export type HelperDefinition = object;
-export interface HelperCapabilities {
+export interface HelperCapabilities extends InternalCapabilities {
hasValue: boolean;
hasDestroyable: boolean;
hasScheduledEffect: boolean;
@@ -29,11 +30,11 @@ export function helperCapabilities(
!options.hasScheduledEffect
);
- return {
+ return buildCapabilities({
hasValue: Boolean(options.hasValue),
hasDestroyable: Boolean(options.hasDestroyable),
hasScheduledEffect: Boolean(options.hasScheduledEffect),
- };
+ });
}
export interface HelperManager<HelperStateBucket = unknown> {
| true |
Other
|
emberjs
|
ember.js
|
f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json
|
Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager).
|
packages/@ember/-internals/glimmer/lib/modifiers/custom.ts
|
@@ -6,6 +6,7 @@ import { registerDestructor, reifyArgs } from '@glimmer/runtime';
import { createUpdatableTag, untrack, UpdatableTag } from '@glimmer/validator';
import { SimpleElement } from '@simple-dom/interface';
import { argsProxyFor } from '../utils/args-proxy';
+import { buildCapabilities, InternalCapabilities } from '../utils/managers';
export interface CustomModifierDefinitionState<ModifierInstance> {
ModifierClass: Factory<ModifierInstance>;
@@ -25,7 +26,7 @@ export interface OptionalCapabilities {
};
}
-export interface Capabilities {
+export interface Capabilities extends InternalCapabilities {
disableAutoTracking: boolean;
useArgsProxy: boolean;
passFactoryToCreate: boolean;
@@ -40,11 +41,11 @@ export function capabilities<Version extends keyof OptionalCapabilities>(
managerAPI === '3.13' || managerAPI === '3.22'
);
- return {
+ return buildCapabilities({
disableAutoTracking: Boolean(optionalFeatures.disableAutoTracking),
useArgsProxy: managerAPI === '3.13' ? false : true,
passFactoryToCreate: managerAPI === '3.13',
- };
+ }) as Capabilities;
}
export class CustomModifierDefinition<ModifierInstance> {
@@ -124,11 +125,6 @@ class InteractiveCustomModifierManager<ModifierInstance>
let { delegate, ModifierClass } = definition;
let capturedArgs = vmArgs.capture();
- assert(
- 'Custom modifier managers must define their capabilities using the capabilities() helper function',
- typeof delegate.capabilities === 'object' && delegate.capabilities !== null
- );
-
let { useArgsProxy, passFactoryToCreate } = delegate.capabilities;
let args = useArgsProxy ? argsProxyFor(capturedArgs, 'modifier') : reifyArgs(capturedArgs);
| true |
Other
|
emberjs
|
ember.js
|
f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json
|
Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager).
|
packages/@ember/-internals/glimmer/lib/utils/managers.ts
|
@@ -1,8 +1,10 @@
import { Owner } from '@ember/-internals/owner';
-import { deprecate } from '@ember/debug';
+import { assert, deprecate } from '@ember/debug';
import { COMPONENT_MANAGER_STRING_LOOKUP } from '@ember/deprecated-features';
+import { DEBUG } from '@glimmer/env';
+import { _WeakSet } from '@glimmer/util';
import { ManagerDelegate as ComponentManagerDelegate } from '../component-managers/custom';
-import InternalComponentManager from '../component-managers/internal';
+import InternalComponentManager, { isInternalManager } from '../component-managers/internal';
import { HelperManager } from '../helpers/custom';
import { ModifierManagerDelegate } from '../modifiers/custom';
@@ -17,6 +19,8 @@ const COMPONENT_MANAGERS = new WeakMap<
ManagerFactory<ComponentManagerDelegate<unknown> | InternalComponentManager>
>();
+const FROM_CAPABILITIES = DEBUG ? new _WeakSet() : undefined;
+
const MODIFIER_MANAGERS = new WeakMap<object, ManagerFactory<ModifierManagerDelegate<unknown>>>();
const HELPER_MANAGERS = new WeakMap<object, ManagerFactory<HelperManager<unknown>>>();
@@ -71,6 +75,7 @@ function getManagerInstanceForOwner<D extends ManagerDelegate>(
if (instance === undefined) {
instance = factory(owner);
+
managers.set(factory, instance!);
}
@@ -94,7 +99,15 @@ export function getModifierManager(
const factory = getManager(MODIFIER_MANAGERS, definition);
if (factory !== undefined) {
- return getManagerInstanceForOwner(owner, factory);
+ let manager = getManagerInstanceForOwner(owner, factory);
+ assert(
+ `Custom modifier managers must have a \`capabilities\` property that is the result of calling the \`capabilities('3.13' | '3.22')\` (imported via \`import { capabilities } from '@ember/modifier';\`). Received: \`${JSON.stringify(
+ manager.capabilities
+ )}\` for: \`${manager}\``,
+ FROM_CAPABILITIES!.has(manager.capabilities)
+ );
+
+ return manager;
}
return undefined;
@@ -114,7 +127,16 @@ export function getHelperManager(
const factory = getManager(HELPER_MANAGERS, definition);
if (factory !== undefined) {
- return getManagerInstanceForOwner(owner, factory);
+ let manager = getManagerInstanceForOwner(owner, factory);
+
+ assert(
+ `Custom helper managers must have a \`capabilities\` property that is the result of calling the \`capabilities('3.23')\` (imported via \`import { capabilities } from '@ember/helper';\`). Received: \`${JSON.stringify(
+ manager.capabilities
+ )}\` for: \`${manager}\``,
+ FROM_CAPABILITIES!.has(manager.capabilities)
+ );
+
+ return manager;
}
return undefined;
@@ -161,8 +183,32 @@ export function getComponentManager(
);
if (factory !== undefined) {
- return getManagerInstanceForOwner(owner, factory);
+ let manager = getManagerInstanceForOwner(owner, factory);
+
+ assert(
+ `Custom component managers must have a \`capabilities\` property that is the result of calling the \`capabilities('3.4' | '3.13')\` (imported via \`import { capabilities } from '@ember/component';\`). Received: \`${JSON.stringify(
+ (manager as ComponentManagerDelegate<unknown>).capabilities
+ )}\` for: \`${manager}\``,
+ isInternalManager(manager) || FROM_CAPABILITIES!.has(manager.capabilities)
+ );
+
+ return manager;
}
return undefined;
}
+
+declare const INTERNAL_CAPABILITIES: unique symbol;
+
+export interface InternalCapabilities {
+ [INTERNAL_CAPABILITIES]: true;
+}
+
+export function buildCapabilities<T extends object>(capabilities: T): T & InternalCapabilities {
+ if (DEBUG) {
+ FROM_CAPABILITIES!.add(capabilities);
+ Object.freeze(capabilities);
+ }
+
+ return capabilities as T & InternalCapabilities;
+}
| true |
Other
|
emberjs
|
ember.js
|
f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json
|
Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager).
|
packages/@ember/-internals/glimmer/tests/integration/custom-component-manager-test.js
|
@@ -522,6 +522,62 @@ moduleFor(
this.assertHTML(`<p>hello max</p>`);
assert.verifySteps(['updateComponent', 'didUpdateComponent']);
}
+
+ '@test capabilities helper function must be used to generate capabilities'(assert) {
+ let ComponentClass = setComponentManager(
+ () => {
+ return EmberObject.create({
+ capabilities: {
+ asyncLifecycleCallbacks: true,
+ destructor: true,
+ update: false,
+ },
+
+ createComponent(factory, args) {
+ assert.step('createComponent');
+ return factory.create({ args });
+ },
+
+ updateComponent(component, args) {
+ assert.step('updateComponent');
+ set(component, 'args', args);
+ },
+
+ destroyComponent(component) {
+ assert.step('destroyComponent');
+ component.destroy();
+ },
+
+ getContext(component) {
+ assert.step('getContext');
+ return component;
+ },
+
+ didCreateComponent() {
+ assert.step('didCreateComponent');
+ },
+
+ didUpdateComponent() {
+ assert.step('didUpdateComponent');
+ },
+ });
+ },
+ EmberObject.extend({
+ greeting: 'hello',
+ })
+ );
+
+ this.registerComponent('foo-bar', {
+ template: `<p>{{greeting}} {{@name}}</p>`,
+ ComponentClass,
+ });
+
+ expectAssertion(() => {
+ this.render('{{foo-bar name=name}}', { name: 'world' });
+ }, /Custom component managers must have a `capabilities` property that is the result of calling the `capabilities\('3.4' \| '3.13'\)` \(imported via `import \{ capabilities \} from '@ember\/component';`\). /);
+
+ assert.verifySteps([]);
+ }
}
);
@@ -774,5 +830,61 @@ moduleFor(
runTask(() => this.context.set('value', 'bar'));
assert.verifySteps([]);
}
+
+ '@test capabilities helper function must be used to generate capabilities'(assert) {
+ let ComponentClass = setComponentManager(
+ () => {
+ return EmberObject.create({
+ capabilities: {
+ asyncLifecycleCallbacks: true,
+ destructor: true,
+ update: false,
+ },
+
+ createComponent(factory, args) {
+ assert.step('createComponent');
+ return factory.create({ args });
+ },
+
+ updateComponent(component, args) {
+ assert.step('updateComponent');
+ set(component, 'args', args);
+ },
+
+ destroyComponent(component) {
+ assert.step('destroyComponent');
+ component.destroy();
+ },
+
+ getContext(component) {
+ assert.step('getContext');
+ return component;
+ },
+
+ didCreateComponent() {
+ assert.step('didCreateComponent');
+ },
+
+ didUpdateComponent() {
+ assert.step('didUpdateComponent');
+ },
+ });
+ },
+ EmberObject.extend({
+ greeting: 'hello',
+ })
+ );
+
+ this.registerComponent('foo-bar', {
+ template: `<p>{{greeting}} {{@name}}</p>`,
+ ComponentClass,
+ });
+
+ expectAssertion(() => {
+ this.render('<FooBar @name={{name}} />', { name: 'world' });
+ }, /Custom component managers must have a `capabilities` property that is the result of calling the `capabilities\('3.4' \| '3.13'\)` \(imported via `import \{ capabilities \} from '@ember\/component';`\). /);
+
+ assert.verifySteps([]);
+ }
}
);
| true |
Other
|
emberjs
|
ember.js
|
f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json
|
Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager).
|
packages/@ember/-internals/glimmer/tests/integration/custom-modifier-manager-test.js
|
@@ -21,7 +21,7 @@ class ModifierManagerTest extends RenderingTestCase {
expectAssertion(() => {
this.render('<h1 {{foo-bar}}>hello world</h1>');
- }, /Custom modifier managers must define their capabilities/);
+ }, /Custom modifier managers must have a `capabilities` property /);
}
'@test can register a custom element modifier and render it'(assert) {
@@ -266,6 +266,41 @@ class ModifierManagerTest extends RenderingTestCase {
this.render('<h1 {{foo-bar this.person}}>hello world</h1>', { person: new Person() });
}, expectedMessage);
}
+
+ '@test capabilities helper function must be used to generate capabilities'(assert) {
+ class OverrideCustomModifierManager extends this.CustomModifierManager {
+ capabilities = {
+ disableAutoTracking: false,
+ useArgsProxy: true,
+ passFactoryToCreate: false,
+ };
+ }
+
+ let ModifierClass = setModifierManager(
+ (owner) => {
+ return new OverrideCustomModifierManager(owner);
+ },
+ EmberObject.extend({
+ didInsertElement() {
+ assert.step('didInsertElement');
+ },
+ didUpdate() {
+ assert.step('didUpdate');
+ },
+ willDestroyElement() {
+ assert.step('willDestroyElement');
+ },
+ })
+ );
+
+ this.registerModifier('foo-bar', ModifierClass.extend());
+
+ expectAssertion(() => {
+ this.render('<h1 {{foo-bar}}>hello world</h1>');
+ }, /Custom modifier managers must have a `capabilities` property that is the result of calling the `capabilities\('3.13' \| '3.22'\)` \(imported via `import \{ capabilities \} from '@ember\/modifier';`\). /);
+
+ assert.verifySteps([]);
+ }
}
moduleFor(
| true |
Other
|
emberjs
|
ember.js
|
f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json
|
Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager).
|
packages/@ember/-internals/glimmer/tests/integration/helpers/helper-manager-test.js
|
@@ -289,6 +289,34 @@ if (EMBER_GLIMMER_HELPER_MANAGER) {
this.assertText('hello');
}
+
+ '@test capabilities helper function must be used to generate capabilities'(assert) {
+ class OverrideTestHelperManager extends TestHelperManager {
+ capabilities = {
+ hasValue: true,
+ hasDestroyable: true,
+ hasScheduledEffect: false,
+ };
+ }
+
+ class TestHelper {}
+
+ setHelperManager((owner) => new OverrideTestHelperManager(owner), TestHelper);
+ this.registerCustomHelper(
+ 'hello',
+ class extends TestHelper {
+ value() {
+ return 'hello';
+ }
+ }
+ );
+
+ expectAssertion(() => {
+ this.render('{{hello}}');
+ }, /Custom helper managers must have a `capabilities` property that is the result of calling the `capabilities\('3.23'\)` \(imported via `import \{ capabilities \} from '@ember\/helper';`\). /);
+
+ assert.verifySteps([]);
+ }
}
);
}
| true |
Other
|
emberjs
|
ember.js
|
15217a3ab36a35c8b26361c3155a30efe4a0f8ae.json
|
Add v3.21.2 to CHANGELOG.md.
|
CHANGELOG.md
|
@@ -15,6 +15,11 @@
- [#18984](https://github.com/emberjs/ember.js/pull/18984) / [#19067](https://github.com/emberjs/ember.js/pull/19067) [FEATURE] Add low-level Cache API per [Autotracking Memoization RFC](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md)
- [#19086](https://github.com/emberjs/ember.js/pull/19086) [FEATURE] Pass transition object to activate/deactivate hooks and events
+### v3.21.2 (September 30, 2020)
+
+- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters
+- [#19164](https://github.com/emberjs/ember.js/pull/19164) [BUGFIX] Entangles custom EmberArray implementations when accessed with `Ember.get`
+
### v3.21.1 (August 28, 2020)
- [#19106](https://github.com/emberjs/ember.js/pull/19106) [BUGFIX] Ensure `destroy` methods on `CoreObject` are invoked.
| false |
Other
|
emberjs
|
ember.js
|
26ef075c85688d26b1b12921bb4b5d4073507d83.json
|
Update TypeScript to v4.0.0
|
.eslintrc.js
|
@@ -68,6 +68,7 @@ module.exports = {
'no-dupe-class-members': 'off',
'no-unused-vars': 'off',
'no-undef': 'off',
+ 'no-redeclare': 'off',
'import/export': 'off',
'import/named': 'off',
| true |
Other
|
emberjs
|
ember.js
|
26ef075c85688d26b1b12921bb4b5d4073507d83.json
|
Update TypeScript to v4.0.0
|
package.json
|
@@ -87,7 +87,7 @@
"@simple-dom/document": "^1.4.0",
"@types/qunit": "^2.9.1",
"@types/rsvp": "^4.0.3",
- "@typescript-eslint/parser": "^2.33.0",
+ "@typescript-eslint/parser": "^4.3.0",
"auto-dist-tag": "^1.0.0",
"aws-sdk": "^2.686.0",
"babel-eslint": "^10.1.0",
@@ -101,7 +101,7 @@
"broccoli-rollup": "^2.1.1",
"broccoli-source": "^3.0.0",
"broccoli-string-replace": "^0.1.2",
- "broccoli-typescript-compiler": "^5.0.0",
+ "broccoli-typescript-compiler": "^7.0.0",
"broccoli-uglify-sourcemap": "^3.2.0",
"common-tags": "^1.8.0",
"core-js": "^2.6.5",
| true |
Other
|
emberjs
|
ember.js
|
26ef075c85688d26b1b12921bb4b5d4073507d83.json
|
Update TypeScript to v4.0.0
|
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
|
@@ -1530,20 +1530,20 @@ if (ENV._DEBUG_RENDER_TREE) {
nodeBounds(node: Node): CapturedBounds {
return {
- parentElement: (expect(
+ parentElement: ((expect(
node.parentNode,
'BUG: detached node'
- ) as SimpleNode) as SimpleElement,
- firstNode: node as SimpleNode,
- lastNode: node as SimpleNode,
+ ) as unknown) as SimpleNode) as SimpleElement,
+ firstNode: (node as unknown) as SimpleNode,
+ lastNode: (node as unknown) as SimpleNode,
};
}
elementBounds(element: Element): CapturedBounds {
return {
- parentElement: element as SimpleElement,
- firstNode: element.firstChild! as SimpleNode,
- lastNode: element.lastChild! as SimpleNode,
+ parentElement: (element as unknown) as SimpleElement,
+ firstNode: (element.firstChild! as unknown) as SimpleNode,
+ lastNode: (element.lastChild! as unknown) as SimpleNode,
};
}
| true |
Other
|
emberjs
|
ember.js
|
26ef075c85688d26b1b12921bb4b5d4073507d83.json
|
Update TypeScript to v4.0.0
|
packages/@ember/-internals/views/lib/system/utils.ts
|
@@ -171,8 +171,8 @@ export function getViewRange(view: View): Range {
let bounds = getViewBounds(view);
let range = document.createRange();
- range.setStartBefore(bounds.firstNode as Node);
- range.setEndAfter(bounds.lastNode as Node);
+ range.setStartBefore((bounds.firstNode as unknown) as Node);
+ range.setEndAfter((bounds.lastNode as unknown) as Node);
return range;
}
| true |
Other
|
emberjs
|
ember.js
|
26ef075c85688d26b1b12921bb4b5d4073507d83.json
|
Update TypeScript to v4.0.0
|
yarn.lock
|
@@ -1060,6 +1060,27 @@
"@glimmer/interfaces" "^0.61.2"
"@glimmer/util" "^0.61.2"
+"@nodelib/fs.scandir@2.1.3":
+ version "2.1.3"
+ resolved "https://registry.yarnpkg.com/@nodelib/fs.scandir/-/fs.scandir-2.1.3.tgz#3a582bdb53804c6ba6d146579c46e52130cf4a3b"
+ integrity sha512-eGmwYQn3gxo4r7jdQnkrrN6bY478C3P+a/y72IJukF8LjB6ZHeB3c+Ehacj3sYeSmUXGlnA67/PmbM9CVwL7Dw==
+ dependencies:
+ "@nodelib/fs.stat" "2.0.3"
+ run-parallel "^1.1.9"
+
+"@nodelib/fs.stat@2.0.3", "@nodelib/fs.stat@^2.0.2":
+ version "2.0.3"
+ resolved "https://registry.yarnpkg.com/@nodelib/fs.stat/-/fs.stat-2.0.3.tgz#34dc5f4cabbc720f4e60f75a747e7ecd6c175bd3"
+ integrity sha512-bQBFruR2TAwoevBEd/NWMoAAtNGzTRgdrqnYCc7dhzfoNvqPzLyqlEQnzZ3kVnNrSp25iyxE00/3h2fqGAGArA==
+
+"@nodelib/fs.walk@^1.2.3":
+ version "1.2.4"
+ resolved "https://registry.yarnpkg.com/@nodelib/fs.walk/-/fs.walk-1.2.4.tgz#011b9202a70a6366e436ca5c065844528ab04976"
+ integrity sha512-1V9XOY4rDW0rehzbrcqAmHnz8e7SKvX27gh8Gt2WgB0+pdzdiLV83p72kZPU+jvMbS1qU5mauP2iOvO8rhmurQ==
+ dependencies:
+ "@nodelib/fs.scandir" "2.1.3"
+ fastq "^1.6.0"
+
"@simple-dom/document@^1.4.0":
version "1.4.0"
resolved "https://registry.yarnpkg.com/@simple-dom/document/-/document-1.4.0.tgz#af60855f957f284d436983798ef1006cca1a1678"
@@ -1108,11 +1129,6 @@
resolved "https://registry.yarnpkg.com/@types/color-name/-/color-name-1.1.1.tgz#1c1261bbeaa10a8055bbc5d8ab84b7b2afc846a0"
integrity sha512-rr+OQyAjxze7GgWrSaJwydHStIhHq2lvY3BOC2Mj7KnzI7XK0Uw1TOOdI9lDoajEbSWLiYgoo4f1R51erQfhPQ==
-"@types/eslint-visitor-keys@^1.0.0":
- version "1.0.0"
- resolved "https://registry.yarnpkg.com/@types/eslint-visitor-keys/-/eslint-visitor-keys-1.0.0.tgz#1ee30d79544ca84d68d4b3cdb0af4f205663dd2d"
- integrity sha512-OCutwjDZ4aFS6PB1UZ988C4YgwlBHJd6wCeQqaLdmadZ/7e+w79+hbMUFC1QXDNCmdyoRfAFdm0RypzwR+Qpag==
-
"@types/estree@*", "@types/estree@0.0.38":
version "0.0.38"
resolved "https://registry.yarnpkg.com/@types/estree/-/estree-0.0.38.tgz#c1be40aa933723c608820a99a373a16d215a1ca2"
@@ -1139,11 +1155,6 @@
"@types/minimatch" "*"
"@types/node" "*"
-"@types/json-schema@^7.0.3":
- version "7.0.3"
- resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.3.tgz#bdfd69d61e464dcc81b25159c270d75a73c1a636"
- integrity sha512-Il2DtDVRGDcqjDtE+rF8iqg1CArehSK84HZJCT7AMITlyXRBpuPhqGLDQMowraqqu1coEaimg4ZOqggt6L6L+A==
-
"@types/minimatch@*", "@types/minimatch@^3.0.3":
version "3.0.3"
resolved "https://registry.yarnpkg.com/@types/minimatch/-/minimatch-3.0.3.tgz#3dca0e3f33b200fc7d1139c0cd96c1268cadfd9d"
@@ -1196,39 +1207,51 @@
dependencies:
"@types/node" "*"
-"@typescript-eslint/experimental-utils@2.33.0":
- version "2.33.0"
- resolved "https://registry.yarnpkg.com/@typescript-eslint/experimental-utils/-/experimental-utils-2.33.0.tgz#000f1e5f344fbea1323dc91cc174805d75f99a03"
- integrity sha512-qzPM2AuxtMrRq78LwyZa8Qn6gcY8obkIrBs1ehqmQADwkYzTE1Pb4y2W+U3rE/iFkSWcWHG2LS6MJfj6SmHApg==
+"@typescript-eslint/parser@^4.3.0":
+ version "4.3.0"
+ resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-4.3.0.tgz#684fc0be6551a2bfcb253991eec3c786a8c063a3"
+ integrity sha512-JyfRnd72qRuUwItDZ00JNowsSlpQGeKfl9jxwO0FHK1qQ7FbYdoy5S7P+5wh1ISkT2QyAvr2pc9dAemDxzt75g==
dependencies:
- "@types/json-schema" "^7.0.3"
- "@typescript-eslint/typescript-estree" "2.33.0"
- eslint-scope "^5.0.0"
- eslint-utils "^2.0.0"
+ "@typescript-eslint/scope-manager" "4.3.0"
+ "@typescript-eslint/types" "4.3.0"
+ "@typescript-eslint/typescript-estree" "4.3.0"
+ debug "^4.1.1"
-"@typescript-eslint/parser@^2.33.0":
- version "2.33.0"
- resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-2.33.0.tgz#395c0ef229ebef883608f8632a34f0acf02b9bdd"
- integrity sha512-AUtmwUUhJoH6yrtxZMHbRUEMsC2G6z5NSxg9KsROOGqNXasM71I8P2NihtumlWTUCRld70vqIZ6Pm4E5PAziEA==
+"@typescript-eslint/scope-manager@4.3.0":
+ version "4.3.0"
+ resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-4.3.0.tgz#c743227e087545968080d2362cfb1273842cb6a7"
+ integrity sha512-cTeyP5SCNE8QBRfc+Lgh4Xpzje46kNUhXYfc3pQWmJif92sjrFuHT9hH4rtOkDTo/si9Klw53yIr+djqGZS1ig==
dependencies:
- "@types/eslint-visitor-keys" "^1.0.0"
- "@typescript-eslint/experimental-utils" "2.33.0"
- "@typescript-eslint/typescript-estree" "2.33.0"
- eslint-visitor-keys "^1.1.0"
+ "@typescript-eslint/types" "4.3.0"
+ "@typescript-eslint/visitor-keys" "4.3.0"
-"@typescript-eslint/typescript-estree@2.33.0":
- version "2.33.0"
- resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-2.33.0.tgz#33504c050ccafd38f397a645d4e9534d2eccbb5c"
- integrity sha512-d8rY6/yUxb0+mEwTShCQF2zYQdLlqihukNfG9IUlLYz5y1CH6G/9XYbrxQLq3Z14RNvkCC6oe+OcFlyUpwUbkg==
+"@typescript-eslint/types@4.3.0":
+ version "4.3.0"
+ resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-4.3.0.tgz#1f0b2d5e140543e2614f06d48fb3ae95193c6ddf"
+ integrity sha512-Cx9TpRvlRjOppGsU6Y6KcJnUDOelja2NNCX6AZwtVHRzaJkdytJWMuYiqi8mS35MRNA3cJSwDzXePfmhU6TANw==
+
+"@typescript-eslint/typescript-estree@4.3.0":
+ version "4.3.0"
+ resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-4.3.0.tgz#0edc1068e6b2e4c7fdc54d61e329fce76241cee8"
+ integrity sha512-ZAI7xjkl+oFdLV/COEz2tAbQbR3XfgqHEGy0rlUXzfGQic6EBCR4s2+WS3cmTPG69aaZckEucBoTxW9PhzHxxw==
dependencies:
+ "@typescript-eslint/types" "4.3.0"
+ "@typescript-eslint/visitor-keys" "4.3.0"
debug "^4.1.1"
- eslint-visitor-keys "^1.1.0"
- glob "^7.1.6"
+ globby "^11.0.1"
is-glob "^4.0.1"
lodash "^4.17.15"
semver "^7.3.2"
tsutils "^3.17.1"
+"@typescript-eslint/visitor-keys@4.3.0":
+ version "4.3.0"
+ resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-4.3.0.tgz#0e5ab0a09552903edeae205982e8521e17635ae0"
+ integrity sha512-xZxkuR7XLM6RhvLkgv9yYlTcBHnTULzfnw4i6+z2TGBLy9yljAypQaZl9c3zFvy7PNI7fYWyvKYtohyF8au3cw==
+ dependencies:
+ "@typescript-eslint/types" "4.3.0"
+ eslint-visitor-keys "^2.0.0"
+
abbrev@1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/abbrev/-/abbrev-1.1.1.tgz#f8f2c887ad10bf67f634f005b6987fed3179aac8"
@@ -1462,6 +1485,11 @@ array-to-sentence@^1.1.0:
resolved "https://registry.yarnpkg.com/array-to-sentence/-/array-to-sentence-1.1.0.tgz#c804956dafa53232495b205a9452753a258d39fc"
integrity sha1-yASVba+lMjJJWyBalFJ1OiWNOfw=
+array-union@^2.1.0:
+ version "2.1.0"
+ resolved "https://registry.yarnpkg.com/array-union/-/array-union-2.1.0.tgz#b798420adbeb1de828d84acd8a2e23d3efe85e8d"
+ integrity sha512-HGyxoOTYUyCM6stUe6EJgnd4EoewAI7zMdfqO+kGjnlZmBDz/cR5pf8r/cR4Wq60sL/p0IkcjUEEPwS3GFrIyw==
+
array-unique@^0.3.2:
version "0.3.2"
resolved "https://registry.yarnpkg.com/array-unique/-/array-unique-0.3.2.tgz#a894b75d4bc4f6cd679ef3244a9fd8f46ae2d428"
@@ -1918,7 +1946,7 @@ braces@^2.3.1:
split-string "^3.0.2"
to-regex "^3.0.1"
-braces@~3.0.2:
+braces@^3.0.1, braces@~3.0.2:
version "3.0.2"
resolved "https://registry.yarnpkg.com/braces/-/braces-3.0.2.tgz#3454e1a462ee8d599e236df336cd9ea4f8afe107"
integrity sha512-b8um+L1RzM3WDSzvhm6gIz1yfTbBt6YTlcEKAvsmqCZZFw46z626lVj9j1yEPW33H5H+lBQpZMP1k8l+78Ha0A==
@@ -2095,6 +2123,22 @@ broccoli-funnel@^2.0.0, broccoli-funnel@^2.0.1, broccoli-funnel@^2.0.2:
symlink-or-copy "^1.0.0"
walk-sync "^0.3.1"
+broccoli-funnel@^3.0.3:
+ version "3.0.3"
+ resolved "https://registry.yarnpkg.com/broccoli-funnel/-/broccoli-funnel-3.0.3.tgz#26fd42632471f67a91f4770d1987118087219937"
+ integrity sha512-LPzZ91BwStoHZXdXHQAJeYORl189OrRKM5NdIi86SDU9wZ4s/3lV1PRFOiobDT/jKM10voM7CDzfvicHbCYxAQ==
+ dependencies:
+ array-equal "^1.0.0"
+ blank-object "^1.0.1"
+ broccoli-plugin "^4.0.1"
+ debug "^4.1.1"
+ fast-ordered-set "^1.0.0"
+ fs-tree-diff "^2.0.1"
+ heimdalljs "^0.2.0"
+ minimatch "^3.0.0"
+ path-posix "^1.0.0"
+ walk-sync "^2.0.2"
+
broccoli-kitchen-sink-helpers@^0.2.5:
version "0.2.9"
resolved "https://registry.yarnpkg.com/broccoli-kitchen-sink-helpers/-/broccoli-kitchen-sink-helpers-0.2.9.tgz#a5e0986ed8d76fb5984b68c3f0450d3a96e36ecc"
@@ -2133,7 +2177,7 @@ broccoli-merge-trees@^3.0.1, broccoli-merge-trees@^3.0.2:
broccoli-plugin "^1.3.0"
merge-trees "^2.0.0"
-broccoli-merge-trees@^4.1.0, broccoli-merge-trees@^4.2.0:
+broccoli-merge-trees@^4.2.0:
version "4.2.0"
resolved "https://registry.yarnpkg.com/broccoli-merge-trees/-/broccoli-merge-trees-4.2.0.tgz#692d3c163ecea08c5714a9434d664e628919f47c"
integrity sha512-nTrQe5AQtCrW4enLRvbD/vTLHqyW2tz+vsLXQe4IEaUhepuMGVKJJr+I8n34Vu6fPjmPLwTjzNC8izMIDMtHPw==
@@ -2333,19 +2377,19 @@ broccoli-string-replace@^0.1.2:
broccoli-persistent-filter "^1.1.5"
minimatch "^3.0.3"
-broccoli-typescript-compiler@^5.0.0:
- version "5.0.0"
- resolved "https://registry.yarnpkg.com/broccoli-typescript-compiler/-/broccoli-typescript-compiler-5.0.0.tgz#c56e6383e5c57efb2ce6852aa3f8154e92c689ed"
- integrity sha512-pUd+VYyD5Afy4mYWnrGbEt+DmuqUDh4mFAP5tOaDz0y/rwlbEN3OvXrhSMcXhTDq2cDSiHqsfQO304nSYFT0Nw==
+broccoli-typescript-compiler@^7.0.0:
+ version "7.0.0"
+ resolved "https://registry.yarnpkg.com/broccoli-typescript-compiler/-/broccoli-typescript-compiler-7.0.0.tgz#a7792ceb8db2ddb3d57e91e429750b4ce9568626"
+ integrity sha512-9BSZc9tVdm3SEbR7uyMQ6XqYMQWkdCvp2dPlZYnENEqbUToCIVOJuOZ24nrenR6N4eTZPnY3R99DkgyoxmRp5A==
dependencies:
- broccoli-funnel "^2.0.2"
- broccoli-merge-trees "^4.1.0"
+ broccoli-funnel "^3.0.3"
+ broccoli-merge-trees "^4.2.0"
broccoli-plugin "^4.0.1"
fs-tree-diff "^2.0.1"
heimdalljs "0.3.3"
md5-hex "^3.0.1"
- typescript "~3.7.5"
- walk-sync "^2.0.2"
+ typescript "~4.0.3"
+ walk-sync "^2.1.0"
broccoli-uglify-sourcemap@^3.2.0:
version "3.2.0"
@@ -3281,6 +3325,13 @@ diff@^4.0.1:
resolved "https://registry.yarnpkg.com/diff/-/diff-4.0.1.tgz#0c667cb467ebbb5cea7f14f135cc2dba7780a8ff"
integrity sha512-s2+XdvhPCOF01LRQBC8hf4vhbVmI2CGS5aZnxLJlT5FtdhPCDFq80q++zK2KlrVorVDdL5BOGZ/VfLrVtYNF+Q==
+dir-glob@^3.0.1:
+ version "3.0.1"
+ resolved "https://registry.yarnpkg.com/dir-glob/-/dir-glob-3.0.1.tgz#56dbf73d992a4a93ba1584f4534063fd2e41717f"
+ integrity sha512-WkrWp9GR4KXfKGYzOLmTuGVi1UWFfws377n9cc55/tb6DuqyF6pcQ5AbiHEshaDpY9v6oaSr2XCDidGmMwdzIA==
+ dependencies:
+ path-type "^4.0.0"
+
doctrine@1.5.0:
version "1.5.0"
resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-1.5.0.tgz#379dce730f6166f76cefa4e6707a159b02c5a6fa"
@@ -3957,6 +4008,11 @@ eslint-visitor-keys@^1.0.0, eslint-visitor-keys@^1.1.0:
resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-1.1.0.tgz#e2a82cea84ff246ad6fb57f9bde5b46621459ec2"
integrity sha512-8y9YjtM1JBJU/A9Kc+SbaOV4y29sSWckBwMHa+FGtVj5gN/sbnKDf6xJUl+8g7FAij9LVaP8C24DUiH/f/2Z9A==
+eslint-visitor-keys@^2.0.0:
+ version "2.0.0"
+ resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-2.0.0.tgz#21fdc8fbcd9c795cc0321f0563702095751511a8"
+ integrity sha512-QudtT6av5WXels9WjIM7qz1XD1cWGvX4gGXvp/zBn9nXG02D0utdU3Em2m/QjTnrsk6bBjmCygl3rmj118msQQ==
+
eslint@^6.8.0:
version "6.8.0"
resolved "https://registry.yarnpkg.com/eslint/-/eslint-6.8.0.tgz#62262d6729739f9275723824302fb227c8c93ffb"
@@ -4253,6 +4309,18 @@ fast-diff@^1.1.2:
resolved "https://registry.yarnpkg.com/fast-diff/-/fast-diff-1.2.0.tgz#73ee11982d86caaf7959828d519cfe927fac5f03"
integrity sha512-xJuoT5+L99XlZ8twedaRf6Ax2TgQVxvgZOYoPKqZufmJib0tL2tegPBOZb1pVNgIhlqDlA0eO0c3wBvQcmzx4w==
+fast-glob@^3.1.1:
+ version "3.2.4"
+ resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.2.4.tgz#d20aefbf99579383e7f3cc66529158c9b98554d3"
+ integrity sha512-kr/Oo6PX51265qeuCYsyGypiO5uJFgBS0jksyG7FUeCyQzNwYnzrNIMR1NXfkZXsMYXYLRAHgISHBz8gQcxKHQ==
+ dependencies:
+ "@nodelib/fs.stat" "^2.0.2"
+ "@nodelib/fs.walk" "^1.2.3"
+ glob-parent "^5.1.0"
+ merge2 "^1.3.0"
+ micromatch "^4.0.2"
+ picomatch "^2.2.1"
+
fast-json-stable-stringify@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/fast-json-stable-stringify/-/fast-json-stable-stringify-2.0.0.tgz#d5142c0caee6b1189f87d3a76111064f86c8bbf2"
@@ -4298,6 +4366,13 @@ fast-sourcemap-concat@^2.1.0:
source-map-url "^0.3.0"
sourcemap-validator "^1.1.0"
+fastq@^1.6.0:
+ version "1.8.0"
+ resolved "https://registry.yarnpkg.com/fastq/-/fastq-1.8.0.tgz#550e1f9f59bbc65fe185cb6a9b4d95357107f481"
+ integrity sha512-SMIZoZdLh/fgofivvIkmknUXyPnvxRE3DhtZ5Me3Mrsk5gyPL42F0xr51TdRXskBxHfMp+07bcYzfsYEsSQA9Q==
+ dependencies:
+ reusify "^1.0.4"
+
faye-websocket@~0.10.0:
version "0.10.0"
resolved "https://registry.yarnpkg.com/faye-websocket/-/faye-websocket-0.10.0.tgz#4e492f8d04dfb6f89003507f6edbf2d501e7c6f4"
@@ -4781,7 +4856,7 @@ github@^0.2.3:
dependencies:
mime "^1.2.11"
-glob-parent@^5.0.0, glob-parent@~5.1.0:
+glob-parent@^5.0.0, glob-parent@^5.1.0, glob-parent@~5.1.0:
version "5.1.1"
resolved "https://registry.yarnpkg.com/glob-parent/-/glob-parent-5.1.1.tgz#b6c1ef417c4e5663ea498f1c45afac6916bbc229"
integrity sha512-FnI+VGOpnlGHWZxthPGR+QhR78fuiK0sNLkHQv+bL9fQi57lNNdquIbna/WrfROrolq8GK5Ek6BiMwqL/voRYQ==
@@ -4860,6 +4935,18 @@ globals@^9.18.0:
resolved "https://registry.yarnpkg.com/globals/-/globals-9.18.0.tgz#aa3896b3e69b487f17e31ed2143d69a8e30c2d8a"
integrity sha512-S0nG3CLEQiY/ILxqtztTWH/3iRRdyBLw6KMDxnKMchrtbj2OFmehVh0WUCfW3DUrIgx/qFrJPICrq4Z4sTR9UQ==
+globby@^11.0.1:
+ version "11.0.1"
+ resolved "https://registry.yarnpkg.com/globby/-/globby-11.0.1.tgz#9a2bf107a068f3ffeabc49ad702c79ede8cfd357"
+ integrity sha512-iH9RmgwCmUJHi2z5o2l3eTtGBtXek1OYlHrbcxOYugyHLmAsZrPj43OtHThd62Buh/Vv6VyCBD2bdyWcGNQqoQ==
+ dependencies:
+ array-union "^2.1.0"
+ dir-glob "^3.0.1"
+ fast-glob "^3.1.1"
+ ignore "^5.1.4"
+ merge2 "^1.3.0"
+ slash "^3.0.0"
+
got@^8.0.1, got@^8.3.1:
version "8.3.2"
resolved "https://registry.yarnpkg.com/got/-/got-8.3.2.tgz#1d23f64390e97f776cac52e5b936e5f514d2e937"
@@ -5196,6 +5283,11 @@ ignore@^5.1.1:
resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.1.4.tgz#84b7b3dbe64552b6ef0eca99f6743dbec6d97adf"
integrity sha512-MzbUSahkTW1u7JpKKjY7LCARd1fU5W2rLdxlM4kdkayuCwZImjkpluF9CM1aLewYJguPDqewLam18Y6AU69A8A==
+ignore@^5.1.4:
+ version "5.1.8"
+ resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.1.8.tgz#f150a8b50a34289b33e22f5889abd4d8016f0e57"
+ integrity sha512-BMpfD7PpiETpBl/A6S498BaIJ6Y/ABT93ETbby2fP00v4EbvPBXWEoaR1UBPKs3iR53pJY7EtZk5KACI57i1Uw==
+
import-fresh@^3.0.0:
version "3.0.0"
resolved "https://registry.yarnpkg.com/import-fresh/-/import-fresh-3.0.0.tgz#a3d897f420cab0e671236897f75bc14b4885c390"
@@ -6503,6 +6595,11 @@ merge-trees@^2.0.0:
fs-updater "^1.0.4"
heimdalljs "^0.2.5"
+merge2@^1.3.0:
+ version "1.4.1"
+ resolved "https://registry.yarnpkg.com/merge2/-/merge2-1.4.1.tgz#4368892f885e907455a6fd7dc55c0c9d404990ae"
+ integrity sha512-8q7VEgMJW4J8tcfVPy8g09NcQwZdbwFEqhe/WZkoIzjn/3TGDwtOCYtXGxA3O8tPzpczCCDgv+P2P5y00ZJOOg==
+
methods@~1.1.2:
version "1.1.2"
resolved "https://registry.yarnpkg.com/methods/-/methods-1.1.2.tgz#5529a4d67654134edcc5266656835b0f851afcee"
@@ -6527,6 +6624,14 @@ micromatch@^3.0.4, micromatch@^3.1.10, micromatch@^3.1.4:
snapdragon "^0.8.1"
to-regex "^3.0.2"
+micromatch@^4.0.2:
+ version "4.0.2"
+ resolved "https://registry.yarnpkg.com/micromatch/-/micromatch-4.0.2.tgz#4fcb0999bf9fbc2fcbdd212f6d629b9a56c39259"
+ integrity sha512-y7FpHSbMUMoyPbYUSzO6PaZ6FyRnQOpHuKwbo1G+Knck95XVU4QAiKdGEnj5wwoS7PlOgthX/09u5iFJ+aYf5Q==
+ dependencies:
+ braces "^3.0.1"
+ picomatch "^2.0.5"
+
mime-db@1.44.0:
version "1.44.0"
resolved "https://registry.yarnpkg.com/mime-db/-/mime-db-1.44.0.tgz#fa11c5eb0aca1334b4233cb4d52f10c5a6272f92"
@@ -7247,6 +7352,11 @@ path-type@^3.0.0:
dependencies:
pify "^3.0.0"
+path-type@^4.0.0:
+ version "4.0.0"
+ resolved "https://registry.yarnpkg.com/path-type/-/path-type-4.0.0.tgz#84ed01c0a7ba380afe09d90a8c180dcd9d03043b"
+ integrity sha512-gDKb8aZMDeD/tZWs9P6+q0J9Mwkdl6xMV8TjnGP3qJVJ06bdMgkbBlLU8IdfOsIsFz2BW1rNVT3XuNEl8zPAvw==
+
pathval@^1.0.0:
version "1.1.0"
resolved "https://registry.yarnpkg.com/pathval/-/pathval-1.1.0.tgz#b942e6d4bde653005ef6b71361def8727d0645e0"
@@ -7269,6 +7379,11 @@ picomatch@^2.0.4:
resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.2.1.tgz#21bac888b6ed8601f831ce7816e335bc779f0a4a"
integrity sha512-ISBaA8xQNmwELC7eOjqFKMESB2VIqt4PPDD0nsS95b/9dZXvVKOlz9keMSnoGGKcOHXfTvDD6WMaRoSc9UuhRA==
+picomatch@^2.0.5, picomatch@^2.2.1:
+ version "2.2.2"
+ resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.2.2.tgz#21f333e9b6b8eaff02468f5146ea406d345f4dad"
+ integrity sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg==
+
pify@^2.0.0:
version "2.3.0"
resolved "https://registry.yarnpkg.com/pify/-/pify-2.3.0.tgz#ed141a6ac043a849ea588498e7dca8b15330e90c"
@@ -7908,6 +8023,11 @@ ret@~0.1.10:
resolved "https://registry.yarnpkg.com/ret/-/ret-0.1.15.tgz#b8a4825d5bdb1fc3f6f53c2bc33f81388681c7bc"
integrity sha512-TTlYpa+OL+vMMNG24xSlQGEJ3B/RzEfUlLct7b5G/ytav+wPrplCpVMFuwzXbkecJrb6IYo1iFb0S9v37754mg==
+reusify@^1.0.4:
+ version "1.0.4"
+ resolved "https://registry.yarnpkg.com/reusify/-/reusify-1.0.4.tgz#90da382b1e126efc02146e90845a88db12925d76"
+ integrity sha512-U9nH88a3fc/ekCF1l0/UP1IosiuIjyTh7hBvXVMHYgVcfGvt897Xguj2UOLDeI5BG2m7/uwyaLVT6fbtCwTyzw==
+
rimraf@2.6.3, rimraf@~2.6.2:
version "2.6.3"
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.3.tgz#b2d104fe0d8fb27cf9e0a1cda8262dd3833c6cab"
@@ -8027,6 +8147,11 @@ run-async@^2.4.0:
dependencies:
is-promise "^2.1.0"
+run-parallel@^1.1.9:
+ version "1.1.9"
+ resolved "https://registry.yarnpkg.com/run-parallel/-/run-parallel-1.1.9.tgz#c9dd3a7cf9f4b2c4b6244e173a6ed866e61dd679"
+ integrity sha512-DEqnSRTDw/Tc3FXf49zedI638Z9onwUotBMiUFKmrO2sdFKIbXamXGQ3Axd4qgphxKB4kw/qP1w5kTxnfU1B9Q==
+
rxjs@^6.4.0:
version "6.4.0"
resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.4.0.tgz#f3bb0fe7bda7fb69deac0c16f17b50b0b8790504"
@@ -8229,6 +8354,11 @@ simple-html-tokenizer@^0.5.9:
resolved "https://registry.yarnpkg.com/simple-html-tokenizer/-/simple-html-tokenizer-0.5.9.tgz#1a83fe97f5a3e39b335fddf71cfe9b0263b581c2"
integrity sha512-w/3FEDN94r4JQ9WoYrIr8RqDIPZdyNkdpbK9glFady1CAEyD97XWCv8HFetQO21w81e7h7Nh59iYTyG1mUJftg==
+slash@^3.0.0:
+ version "3.0.0"
+ resolved "https://registry.yarnpkg.com/slash/-/slash-3.0.0.tgz#6539be870c165adbd5240220dbe361f1bc4d4634"
+ integrity sha512-g9Q1haeby36OSStwb4ntCGGGaKsaVSjQ68fBxoQcutl5fS1vuY18H3wSt3jFyFtrkx+Kz0V1G85A4MyAdDMi2Q==
+
slice-ansi@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/slice-ansi/-/slice-ansi-2.1.0.tgz#cacd7693461a637a5788d92a7dd4fba068e81636"
@@ -9096,10 +9226,10 @@ type-is@~1.6.17, type-is@~1.6.18:
media-typer "0.3.0"
mime-types "~2.1.24"
-typescript@~3.7.5:
- version "3.7.5"
- resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.5.tgz#0692e21f65fd4108b9330238aac11dd2e177a1ae"
- integrity sha512-/P5lkRXkWHNAbcJIiHPfRoKqyd7bsyCma1hZNUGfn20qm64T6ZBlrzprymeu918H+mB/0rIg2gGK/BXkhhYgBw==
+typescript@~4.0.3:
+ version "4.0.3"
+ resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.0.3.tgz#153bbd468ef07725c1df9c77e8b453f8d36abba5"
+ integrity sha512-tEu6DGxGgRJPb/mVPIZ48e69xCn2yRmCgYmDugAVwmJ6o+0u1RI18eO7E7WBTLYLaEVVOhwQmcdhQHweux/WPg==
uc.micro@^1.0.0, uc.micro@^1.0.1, uc.micro@^1.0.5:
version "1.0.6"
@@ -9366,6 +9496,16 @@ walk-sync@^2.0.2:
ensure-posix-path "^1.1.0"
matcher-collection "^2.0.0"
+walk-sync@^2.1.0:
+ version "2.2.0"
+ resolved "https://registry.yarnpkg.com/walk-sync/-/walk-sync-2.2.0.tgz#80786b0657fcc8c0e1c0b1a042a09eae2966387a"
+ integrity sha512-IC8sL7aB4/ZgFcGI2T1LczZeFWZ06b3zoHH7jBPyHxOtIIz1jppWHjjEXkOFvFojBVAK9pV7g47xOZ4LW3QLfg==
+ dependencies:
+ "@types/minimatch" "^3.0.3"
+ ensure-posix-path "^1.1.0"
+ matcher-collection "^2.0.0"
+ minimatch "^3.0.4"
+
walker@~1.0.5:
version "1.0.7"
resolved "https://registry.yarnpkg.com/walker/-/walker-1.0.7.tgz#2f7f9b8fd10d677262b18a884e28d19618e028fb"
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
lib/index.js
|
@@ -250,8 +250,8 @@ module.exports = {
if (
!isProduction &&
- (PRE_BUILT_TARGETS.every(target => targets.includes(target)) &&
- targets.length === PRE_BUILT_TARGETS.length)
+ PRE_BUILT_TARGETS.every(target => targets.includes(target)) &&
+ targets.length === PRE_BUILT_TARGETS.length
) {
ember = new Funnel(tree, {
destDir: 'ember',
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/acceptance-test-test.js
|
@@ -75,7 +75,10 @@ describe('Blueprint: acceptance-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/component-test-test.js
|
@@ -166,7 +166,10 @@ describe('Blueprint: component-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/controller-test-test.js
|
@@ -126,7 +126,10 @@ describe('Blueprint: controller-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/helper-test-test.js
|
@@ -126,7 +126,10 @@ describe('Blueprint: helper-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/initializer-test-test.js
|
@@ -75,7 +75,10 @@ describe('Blueprint: initializer-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/instance-initializer-test-test.js
|
@@ -75,7 +75,10 @@ describe('Blueprint: instance-initializer-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/mixin-test-test.js
|
@@ -69,7 +69,10 @@ describe('Blueprint: mixin-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/route-test-test.js
|
@@ -88,7 +88,10 @@ describe('Blueprint: route-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/service-test-test.js
|
@@ -92,7 +92,10 @@ describe('Blueprint: service-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
node-tests/blueprints/util-test-test.js
|
@@ -73,7 +73,10 @@ describe('Blueprint: util-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
generateFakePackageManifest('ember-mocha', '0.14.0');
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
|
@@ -1502,7 +1502,7 @@ if (ENV._DEBUG_RENDER_TREE) {
): ExpectedRenderNode;
outlet(node: ExpectedRenderNode & { type: 'engine' | 'route-template' }): ExpectedRenderNode;
outlet(
- nodeOrName: string | ExpectedRenderNode & { type: 'engine' | 'route-template' },
+ nodeOrName: string | (ExpectedRenderNode & { type: 'engine' | 'route-template' }),
node?: ExpectedRenderNode & { type: 'engine' | 'route-template' }
): ExpectedRenderNode {
let name: string;
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/glimmer/tests/integration/application/helper-registration-test.js
|
@@ -58,9 +58,15 @@ moduleFor(
`<div id='wrapper'>{{omg}}|{{yorp 'boo'}}|{{yorp 'ya'}}</div>`
);
- this.application.register('helper:omg', helper(() => 'OMG'));
+ this.application.register(
+ 'helper:omg',
+ helper(() => 'OMG')
+ );
- this.application.register('helper:yorp', helper(([value]) => value));
+ this.application.register(
+ 'helper:yorp',
+ helper(([value]) => value)
+ );
return this.visit('/').then(() => {
assert.equal(
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/glimmer/tests/integration/components/append-test.js
|
@@ -140,7 +140,10 @@ class AbstractAppendTest extends RenderingTestCase {
assert.deepEqual(
hooks,
- [['x-parent', 'init'], ['x-parent', 'on(init)']],
+ [
+ ['x-parent', 'init'],
+ ['x-parent', 'on(init)'],
+ ],
'creation of x-parent'
);
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/glimmer/tests/integration/components/life-cycle-test.js
|
@@ -1077,7 +1077,11 @@ class LifeCycleHooksTest extends RenderingTestCase {
this.assertRegisteredViews('intial render');
let initialHooks = () => {
- let ret = [['an-item', 'init'], ['an-item', 'on(init)'], ['an-item', 'didReceiveAttrs']];
+ let ret = [
+ ['an-item', 'init'],
+ ['an-item', 'on(init)'],
+ ['an-item', 'didReceiveAttrs'],
+ ];
if (this.isInteractive) {
ret.push(['an-item', 'willRender'], ['an-item', 'willInsertElement']);
}
@@ -1259,7 +1263,10 @@ class LifeCycleHooksTest extends RenderingTestCase {
['nested-item', 'willDestroy'],
],
- nonInteractive: [['no-items', 'willDestroy'], ['nested-item', 'willDestroy']],
+ nonInteractive: [
+ ['no-items', 'willDestroy'],
+ ['nested-item', 'willDestroy'],
+ ],
});
this.assertRegisteredViews('after destroy');
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/glimmer/tests/integration/mount-test.js
|
@@ -121,7 +121,9 @@ moduleFor(
this.engineRegistrations['template:application'] = compile(
'hi {{person.name}} [{{component-with-backtracking-set person=person}}]',
- { moduleName: 'my-app/templates/application.hbs' }
+ {
+ moduleName: 'my-app/templates/application.hbs',
+ }
);
this.engineRegistrations['controller:application'] = Controller.extend({
person: {
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/glimmer/tests/integration/syntax/each-test.js
|
@@ -890,7 +890,10 @@ class EachTest extends AbstractEachTest {
[`@test an outer {{#each}}'s scoped variable does not clobber an inner {{#each}}'s property if they share the same name - Issue #1315`]() {
let content = this.createList(['X', 'Y']);
- let options = this.createList([{ label: 'One', value: 1 }, { label: 'Two', value: 2 }]);
+ let options = this.createList([
+ { label: 'One', value: 1 },
+ { label: 'Two', value: 2 },
+ ]);
this.render(
strip`
@@ -923,7 +926,10 @@ class EachTest extends AbstractEachTest {
set(
this.context,
'options',
- this.createList([{ label: 'One', value: 1 }, { label: 'Two', value: 2 }]).list
+ this.createList([
+ { label: 'One', value: 1 },
+ { label: 'Two', value: 2 },
+ ]).list
);
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/meta/lib/meta.ts
|
@@ -744,7 +744,7 @@ function indexOfListener(
for (let i = listeners.length - 1; i >= 0; i--) {
let listener = listeners[i];
- if (listener.event === event && (listener.target === target && listener.method === method)) {
+ if (listener.event === event && listener.target === target && listener.method === method) {
return i;
}
}
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/metal/lib/decorator.ts
|
@@ -2,7 +2,7 @@ import { Meta, meta as metaFor, peekMeta } from '@ember/-internals/meta';
import { assert } from '@ember/debug';
import { _WeakSet as WeakSet } from '@glimmer/util';
-export type DecoratorPropertyDescriptor = PropertyDescriptor & { initializer?: any } | undefined;
+export type DecoratorPropertyDescriptor = (PropertyDescriptor & { initializer?: any }) | undefined;
export type Decorator = (
target: object,
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/metal/tests/accessors/get_test.js
|
@@ -110,7 +110,10 @@ moduleFor(
assert.equal(get({ foo: func }, 'foo.bar'), 'awesome');
assert.equal(get({ foo: func }, 'foo.bar.length'), 7);
assert.equal(get({}, 'foo.bar.length'), undefined);
- assert.equal(get(function() {}, 'foo.bar.length'), undefined);
+ assert.equal(
+ get(function() {}, 'foo.bar.length'),
+ undefined
+ );
assert.equal(get('', 'foo.bar.length'), undefined);
assert.equal(get({ foo: destroyedObj }, 'foo.bar'), undefined);
}
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/metal/tests/computed_test.js
|
@@ -183,22 +183,38 @@ moduleFor(
['@test defining a computed property with a dependent key more than one level deep beyond @each is not supported']() {
expectNoWarning(() => {
obj = {};
- defineProperty(obj, 'someProp', computed('todos', () => {}));
+ defineProperty(
+ obj,
+ 'someProp',
+ computed('todos', () => {})
+ );
});
expectNoWarning(() => {
obj = {};
- defineProperty(obj, 'someProp', computed('todos.@each.owner', () => {}));
+ defineProperty(
+ obj,
+ 'someProp',
+ computed('todos.@each.owner', () => {})
+ );
});
expectWarning(() => {
obj = {};
- defineProperty(obj, 'someProp', computed('todos.@each.owner.name', () => {}));
+ defineProperty(
+ obj,
+ 'someProp',
+ computed('todos.@each.owner.name', () => {})
+ );
}, /You used the key "todos\.@each\.owner\.name" which is invalid\. /);
expectWarning(() => {
obj = {};
- defineProperty(obj, 'someProp', computed('todos.@each.owner.@each.name', () => {}));
+ defineProperty(
+ obj,
+ 'someProp',
+ computed('todos.@each.owner.@each.name', () => {})
+ );
}, /You used the key "todos\.@each\.owner\.@each\.name" which is invalid\. /);
let expected = new RegExp(
@@ -220,7 +236,11 @@ moduleFor(
obj = {
todos: [],
};
- defineProperty(obj, 'someProp', computed('todos.@each.owner.name', () => {}));
+ defineProperty(
+ obj,
+ 'someProp',
+ computed('todos.@each.owner.name', () => {})
+ );
get(obj, 'someProp');
}, expected);
@@ -703,7 +723,11 @@ moduleFor(
['@test chained dependent keys should evaluate computed properties lazily'](assert) {
defineProperty(obj.foo.bar, 'b', computed(func));
- defineProperty(obj.foo, 'c', computed('bar.b', function() {}));
+ defineProperty(
+ obj.foo,
+ 'c',
+ computed('bar.b', function() {})
+ );
assert.equal(count, 0, 'b should not run');
}
}
@@ -806,7 +830,11 @@ moduleFor(
class extends ComputedTestCase {
['@test adding a computed property should show up in key iteration'](assert) {
obj = {};
- defineProperty(obj, 'foo', computed(function() {}));
+ defineProperty(
+ obj,
+ 'foo',
+ computed(function() {})
+ );
let found = [];
for (let key in obj) {
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/routing/lib/system/router.ts
|
@@ -1438,11 +1438,13 @@ function calculatePostTransitionState(
// If the routeInfo is not resolved, we serialize the context into params
if (!routeInfo.isResolved) {
- params[routeInfo.name] = routeInfo.serialize(routeInfo.context as
- | {
- [key: string]: unknown;
- }
- | undefined);
+ params[routeInfo.name] = routeInfo.serialize(
+ routeInfo.context as
+ | {
+ [key: string]: unknown;
+ }
+ | undefined
+ );
} else {
params[routeInfo.name] = routeInfo.params;
}
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/runtime/tests/array/sortBy-test.js
|
@@ -12,7 +12,10 @@ class SortByTests extends AbstractTestCase {
}
'@test supports multiple propertyNames'() {
- let obj = this.newObject([{ a: 1, b: 2 }, { a: 1, b: 1 }]);
+ let obj = this.newObject([
+ { a: 1, b: 2 },
+ { a: 1, b: 1 },
+ ]);
let sorted = obj.sortBy('a', 'b');
this.assert.equal(get(sorted[0], 'b'), 1);
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/runtime/tests/array/uniqBy-test.js
|
@@ -8,7 +8,10 @@ class UniqByTests extends AbstractTestCase {
{ id: 2, value: 'two' },
{ id: 1, value: 'one' },
]);
- this.assert.deepEqual(numbers.uniqBy('id'), [{ id: 1, value: 'one' }, { id: 2, value: 'two' }]);
+ this.assert.deepEqual(numbers.uniqBy('id'), [
+ { id: 1, value: 'one' },
+ { id: 2, value: 'two' },
+ ]);
}
'@test supports function as key'() {
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/runtime/tests/legacy_1x/mixins/observable/observable_test.js
|
@@ -430,9 +430,7 @@ moduleFor(
assert.equal(
object.set(key, values[1]),
values[1],
- `Try #3: object.set(${key}, ${
- values[1]
- }) should not run function since it is setting same value as before`
+ `Try #3: object.set(${key}, ${values[1]}) should not run function since it is setting same value as before`
);
});
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/runtime/tests/mixins/promise_proxy_test.js
|
@@ -56,7 +56,10 @@ moduleFor(
let didFulfillCount = 0;
let didRejectCount = 0;
- proxy.then(() => didFulfillCount++, () => didRejectCount++);
+ proxy.then(
+ () => didFulfillCount++,
+ () => didRejectCount++
+ );
assert.equal(get(proxy, 'content'), undefined, 'expects the proxy to have no content');
assert.equal(get(proxy, 'reason'), undefined, 'expects the proxy to have no reason');
@@ -162,7 +165,10 @@ moduleFor(
let didFulfillCount = 0;
let didRejectCount = 0;
- proxy.then(() => didFulfillCount++, () => didRejectCount++);
+ proxy.then(
+ () => didFulfillCount++,
+ () => didRejectCount++
+ );
assert.equal(get(proxy, 'content'), undefined, 'expects the proxy to have no content');
assert.equal(get(proxy, 'reason'), undefined, 'expects the proxy to have no reason');
@@ -262,7 +268,10 @@ moduleFor(
let didFulfillCount = 0;
let didRejectCount = 0;
- proxy.then(() => didFulfillCount++, () => didRejectCount++);
+ proxy.then(
+ () => didFulfillCount++,
+ () => didRejectCount++
+ );
assert.equal(get(proxy, 'content'), undefined, 'expects the proxy to have no content');
assert.equal(get(proxy, 'reason'), undefined, 'expects the proxy to have no reason');
@@ -497,7 +506,10 @@ moduleFor(
promise: deferred.promise,
});
- proxy.then(() => {}, () => {});
+ proxy.then(
+ () => {},
+ () => {}
+ );
run(proxy, 'destroy');
@@ -516,7 +528,10 @@ moduleFor(
promise: deferred.promise,
});
- proxy.then(() => {}, () => {});
+ proxy.then(
+ () => {},
+ () => {}
+ );
run(proxy, 'destroy');
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/utils/tests/checkHasSuper_test.js
|
@@ -10,7 +10,10 @@ if (isChrome || isFirefox) {
'checkHasSuper',
class extends TestCase {
['@test does not super wrap needlessly [GH #12462]'](assert) {
- assert.notOk(checkHasSuper(function() {}), 'empty function does not have super');
+ assert.notOk(
+ checkHasSuper(function() {}),
+ 'empty function does not have super'
+ );
}
}
);
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/-internals/utils/tests/get-debug-name-test.js
|
@@ -10,10 +10,16 @@ if (DEBUG) {
class Person {}
assert.equal(getDebugName({}), '(unknown object)');
- assert.equal(getDebugName(() => {}), '(unknown function)');
+ assert.equal(
+ getDebugName(() => {}),
+ '(unknown function)'
+ );
assert.equal(getDebugName(Person), 'Person');
assert.equal(getDebugName(new Person()), 'Person');
- assert.equal(getDebugName(function foo() {}), 'foo');
+ assert.equal(
+ getDebugName(function foo() {}),
+ 'foo'
+ );
assert.equal(
getDebugName({
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/object/tests/computed/reduce_computed_macros_test.js
|
@@ -639,7 +639,10 @@ moduleFor(
}
);
-[['uniq', uniq], ['union', union]].forEach(tuple => {
+[
+ ['uniq', uniq],
+ ['union', union],
+].forEach(tuple => {
let [name, macro] = tuple;
moduleFor(
@@ -745,7 +748,11 @@ moduleFor(
list: null,
uniqueById: uniqBy('list', 'id'),
}).create({
- list: emberA([{ id: 1, value: 'one' }, { id: 2, value: 'two' }, { id: 1, value: 'one' }]),
+ list: emberA([
+ { id: 1, value: 'one' },
+ { id: 2, value: 'two' },
+ { id: 1, value: 'one' },
+ ]),
});
}
@@ -759,7 +766,10 @@ moduleFor(
}, /Cannot set read-only property "uniqueById" on object:/);
}
['@test does not include duplicates'](assert) {
- assert.deepEqual(obj.get('uniqueById'), [{ id: 1, value: 'one' }, { id: 2, value: 'two' }]);
+ assert.deepEqual(obj.get('uniqueById'), [
+ { id: 1, value: 'one' },
+ { id: 2, value: 'two' },
+ ]);
}
['@test it does not share state among instances'](assert) {
@@ -784,15 +794,23 @@ moduleFor(
assert.deepEqual(
obj.get('uniqueById'),
- [{ id: 1, value: 'one' }, { id: 2, value: 'two' }, { id: 3, value: 'three' }],
+ [
+ { id: 1, value: 'one' },
+ { id: 2, value: 'two' },
+ { id: 3, value: 'three' },
+ ],
'The list includes three'
);
obj.get('list').pushObject({ id: 3, value: 'three' });
assert.deepEqual(
obj.get('uniqueById'),
- [{ id: 1, value: 'one' }, { id: 2, value: 'two' }, { id: 3, value: 'three' }],
+ [
+ { id: 1, value: 'one' },
+ { id: 2, value: 'two' },
+ { id: 3, value: 'three' },
+ ],
'The list does not include a duplicate three'
);
}
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/@ember/runloop/tests/run_test.js
|
@@ -15,7 +15,11 @@ moduleFor(
},
};
- assert.equal(run(() => 'FOO'), 'FOO', 'pass function only');
+ assert.equal(
+ run(() => 'FOO'),
+ 'FOO',
+ 'pass function only'
+ );
assert.deepEqual(run(obj, obj.foo), ['BAR', 'FOO'], 'pass obj and obj.method');
assert.deepEqual(run(obj, 'foo'), ['BAR', 'FOO'], 'pass obj and "method"');
assert.deepEqual(
| true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.