sha
stringlengths
40
40
author
stringlengths
1
63
committer
stringlengths
1
41
message
stringlengths
1
65.5k
subject
stringlengths
1
5.64k
subject_length
float64
1
5.64k
is_chore
bool
2 classes
is_bot
bool
2 classes
subject_word_count
float64
1
806
verb_object_spacy
bool
2 classes
verb_object_stanza
bool
2 classes
fits_requirements
bool
2 classes
owner
stringlengths
2
15
repo
stringlengths
2
21
__index_level_0__
int64
0
85k
501e0a6f313890ad3c07940d0f3958133c8fc4b4
dependabot[bot]
GitHub
Bump testem from 3.8.0 to 3.9.0 Bumps [testem](https://github.com/testem/testem) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/testem/testem/releases) - [Commits](https://github.com/testem/testem/compare/v3.8.0...v3.9.0) --- updated-dependencies: - dependency-name: testem dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
bump testem from 3.8.0 to 3.9.0
31
true
true
6
true
true
false
emberjs
ember.js
200
aace2833f40697e84a839c73c51f3db950fbd391
Chris Krycho
GitHub
Merge pull request #20240 from geneukum/clarify-filter-callback-docs [DOC] clarify `filter` computed callback method behavior
merge pull request from geneukum/clarify-filter-callback-docs
62
true
false
5
true
false
false
emberjs
ember.js
201
e89debcb8b329e3d9e20bcf8e3cc4f9f4db75afe
Chris Krycho
GitHub
Further clarify `filter` CP behavior
further clarify `filter` cp behavior
36
false
false
5
false
false
false
emberjs
ember.js
202
1b78bd7f1aa0939eaffaec0d6e4b8dba6c4a99de
Chris Krycho
GitHub
Merge pull request #20239 from geneukum/add-in-element-helper-example-in-docs [DOC] add `in-element` example for `insertBefore` usage
merge pull request from geneukum/add-in-element-helper-example-in-docs
71
true
false
5
true
false
false
emberjs
ember.js
203
149e8903a4a425189ea860cc9d7f114545113373
Chris Krycho
GitHub
Markdown formatting for in-element arg example
markdown formatting for in-element arg example
46
false
false
6
false
false
false
emberjs
ember.js
204
3496b36c5bd4e2abbcb01b7e5db18469bf2f6b55
Chris Krycho
GitHub
Merge pull request #20243 from geneukum/cleanup-input-doc-broken-links [DOC] remove Input references to TextField/Checkbox
merge pull request from geneukum/cleanup-input-doc-broken-links
64
true
false
5
true
false
false
emberjs
ember.js
205
20fb409abaecb36e12eb512f9264995e7d9e32dd
Chris Krycho
GitHub
Merge pull request #20244 from emberjs/getComponentTemplate-types [BUGFIX release] expose getComponentTemplate type
merge pull request from emberjs/getcomponenttemplate-types
59
true
false
5
true
false
false
emberjs
ember.js
206
7f7d8fdb69f7a482e21a593b033b2ba426d21a4b
Chad Hietala
Chad Hietala
[BUGFIX release] expose getComponentTemplate type
[bugfix release] expose getcomponenttemplate type
49
false
false
5
false
false
false
emberjs
ember.js
207
acf71b0db2614517bb5adc8816356ce7946e5713
Chris Krycho
GitHub
Merge pull request #20242 from geneukum/fix-event-dispatcher-link [DOC] fix EventDispatcher extends broken link
merge pull request from geneukum/fix-event-dispatcher-link
59
true
false
5
true
false
false
emberjs
ember.js
208
e23e2eb6d6538f44a3768acd9ac8e6d5817f9ce7
Geordan Neukum
Geordan Neukum
[DOC] remove Input references to TextField/Checkbox Right now, the Input documentation reference that the component extends TextField and Checkbox under the hood. This has not been true since `Commit: 5d24ae74`. As such, let's back out this part of the documentation as it could potentially be confusing (and it contains broken links). Fixes #20170.
[doc] remove input references to textfield/checkbox
51
false
false
6
false
false
false
emberjs
ember.js
209
88d43a57ae3fbfb2a94ec5b2524009f11e123091
Geordan Neukum
Geordan Neukum
DOC: fix EventDispatcher extends broken link Right now, the EventDispatcher docs attempt to link against Ember.Object as the class being extended. This results in a broken link in the generated docs. Let's instead reference this as `EmberObject` instead so that the link works as expected. Fixes #20241.
fix eventdispatcher extends broken link
39
false
false
5
false
false
false
emberjs
ember.js
210
2a1388753392f616718642d554119dc3ab7a8841
Geordan Neukum
Geordan Neukum
[DOC] clarify `filter` computed callback method behavior Right now, the filter function's API docs mention a callback, but do not clarify how the callback function filters down the array. Let's explicitly specify that truthy values will keep the array element, and that anything else will not. This should make the usage a little bit more clear. Fixes #19559.
[doc] clarify `filter` computed callback method behavior
56
false
false
7
false
false
false
emberjs
ember.js
211
269fc6c236e7ac289d7337978124dfec617597c5
Geordan Neukum
Geordan Neukum
[DOC] add `in-element` example for `insertBefore` usage The documentation available for the `in-element` helper mentions that there is an optional named argument, insertBefore, but it does not feature a code sample that uses it. Let's add a code sample which does use it to help developers using the API docs. Fixes #19911.
[doc] add `in-element` example for `insertbefore` usage
56
false
false
7
false
false
false
emberjs
ember.js
212
91a7136be685ac382c88b4e60ec4407129d130bc
Chris Krycho
GitHub
Merge pull request #20237 from emberjs/dependabot/npm_and_yarn/ember-cli-4.8.0 Bump ember-cli from 4.2.0 to 4.8.0
merge pull request from emberjs/dependabot/npm_and_yarn/ember-cli-4.8.0
72
true
false
5
true
false
false
emberjs
ember.js
213
29131271ba229f46a919c5d36b4889aff11449a7
dependabot[bot]
GitHub
Bump ember-cli from 4.2.0 to 4.8.0 Bumps [ember-cli](https://github.com/ember-cli/ember-cli) from 4.2.0 to 4.8.0. - [Release notes](https://github.com/ember-cli/ember-cli/releases) - [Changelog](https://github.com/ember-cli/ember-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/ember-cli/ember-cli/compare/v4.2.0...v4.8.0) --- updated-dependencies: - dependency-name: ember-cli dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
bump ember-cli from 4.2.0 to 4.8.0
34
true
true
6
true
true
false
emberjs
ember.js
214
0dc79fd474c12e9e4906737da6fbeca0e1bafc2c
Chris Krycho
GitHub
Merge pull request #20238 from emberjs/node-14 [BUGFIX beta] Update Node.js versions to match support policy
merge pull request from emberjs/node-14
40
true
false
5
true
false
false
emberjs
ember.js
215
1176ed1bf9885e96560591abf92df01417317503
Chris Krycho
GitHub
Merge pull request #20233 from tben/patch-1 [BUGFIX] Include package name in deprecation error message
merge pull request from tben/patch-1
37
true
false
5
true
false
false
emberjs
ember.js
216
f2f0e3ce79e7dfef856e1a05d64f983c99e3a6bc
Chris Krycho
GitHub
Merge pull request #20216 from emberjs/dependabot/github_actions/actions/checkout-3 Bump actions/checkout from 2 to 3
merge pull request from emberjs/dependabot/github_actions/actions/checkout-3
77
true
false
5
true
false
false
emberjs
ember.js
217
66b3ec3b583e38332b3a5a77f6e484f3badccbb1
Chris Krycho
Chris Krycho
[BUGFIX beta] Update Node.js versions to match support policy Ember CLI dropped support for Node 12 in 4.6.0.
[bugfix beta] update node.js versions to match support policy
61
false
false
9
false
false
false
emberjs
ember.js
218
4e5cffe0fce87e05d5b7e4a9d24c2d31d4d6095e
Chris Krycho
Chris Krycho
Merge branch 'master' into patch-1
merge branch 'master' into patch-1
34
true
false
5
false
true
false
emberjs
ember.js
219
862bbe8eeb43ce208b2f84a8951172556861f878
Chris Krycho
GitHub
Merge pull request #20145 from emberjs/dependabot/npm_and_yarn/terser-5.14.2 Bump terser from 5.10.0 to 5.14.2
merge pull request from emberjs/dependabot/npm_and_yarn/terser-5.14.2
70
true
false
5
true
false
false
emberjs
ember.js
220
22a25a83556cdfabf4830bfb35080799d6d76590
Chris Krycho
GitHub
Merge pull request #20148 from emberjs/dependabot/npm_and_yarn/eslint-plugin-import-2.26.0 Bump eslint-plugin-import from 2.25.4 to 2.26.0
merge pull request from emberjs/dependabot/npm_and_yarn/eslint-plugin-import-2.26.0
84
true
false
5
true
false
false
emberjs
ember.js
221
12c82f69f15fcd43ab51f8f0efceed32bc7f250f
Chris Krycho
GitHub
Merge pull request #20229 from rvrvrv/docs-fix-changelog-typos docs: Fix typos in CHANGELOG.md
merge pull request from rvrvrv/docs-fix-changelog-typos
56
true
false
5
true
false
false
emberjs
ember.js
222
1091c2140f326280a1748a2fe7cd44da0bf0de1e
Chris Krycho
GitHub
Merge pull request #20226 from r-52/r/use-console-log-directly [CLEANUP] use `console.debug` directly
merge pull request from r-52/r/use-console-log-directly
56
true
false
5
true
false
false
emberjs
ember.js
223
609b4a6600c8d3ec36bb98cea7cad8f0b53fb136
dependabot[bot]
GitHub
Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
bump actions/checkout from 2 to 3
33
true
true
6
true
true
false
emberjs
ember.js
224
847d3bafa3c7116d51be4292b7c61917a347a4fe
Chris Krycho
GitHub
Merge pull request #20220 from emberjs/dependabot/github_actions/volta-cli/action-4 Bump volta-cli/action from 1 to 4
merge pull request from emberjs/dependabot/github_actions/volta-cli/action-4
77
true
false
5
true
false
false
emberjs
ember.js
225
e691310dd181d634844f895e8c47e921b3fa75f1
Chris Krycho
GitHub
Merge pull request #20214 from emberjs/dependabot/npm_and_yarn/typescript-eslint/parser-5.38.1 Bump @typescript-eslint/parser from 5.38.0 to 5.38.1
merge pull request from emberjs/dependabot/npm_and_yarn/typescript-eslint/parser-5.38.1
88
true
false
5
true
false
false
emberjs
ember.js
226
0bcbd67146a5ffca3c7a913b2c83d45a563b332e
Chris Krycho
GitHub
Merge pull request #20215 from emberjs/dependabot/npm_and_yarn/broccoli-babel-transpiler-7.8.1 Bump broccoli-babel-transpiler from 7.8.0 to 7.8.1
merge pull request from emberjs/dependabot/npm_and_yarn/broccoli-babel-transpiler-7.8.1
88
true
false
5
true
false
false
emberjs
ember.js
227
77a27301fa34da1f4fd7dfeed0f7c219d96cb24b
Chris Krycho
Chris Krycho
Merge branch 'master' into r/use-console-log-directly
merge branch 'master' into r/use-console-log-directly
53
true
false
5
false
true
false
emberjs
ember.js
228
ccb5d4090e88a66daf08de0cf0fbaadcb1aae64f
Chris Krycho
GitHub
Merge pull request #20175 from wagenet/root-ember-ts Convert packages/ember to TS
merge pull request from wagenet/root-ember-ts
46
true
false
5
true
false
false
emberjs
ember.js
229
9cf853d619cf8072e61388713dbe498c623690cf
Chris Krycho
Chris Krycho
Revert to defineProperty for get/set on Ember namespace While we might be able to make the change over to using native getters and setters in a future PR, we want this change to be exactly and only a type conversion, exactly preserving the previous behavior. Switching back to using `Object.defineProperty()` for the getters and setters defined on the `Ember` namespace preserves the previous behavior, which our tests correctly caught for us!
revert to defineproperty for get/set on ember namespace
55
false
false
8
false
false
false
emberjs
ember.js
230
8bddebebc2df55625b1d1fe92332de3d2885752c
Peter Wagenet
Chris Krycho
Convert packages/ember to TS
convert packages/ember to ts
28
false
false
4
true
true
true
emberjs
ember.js
231
805d3f14f2c1499ac3b04ae7d2fb4725484ee212
Chris Krycho
GitHub
Merge pull request #20235 from emberjs/fix-ts-next [BUGFIX beta] update `@types/node` for TS 4.9 issue
merge pull request from emberjs/fix-ts-next
44
true
false
5
true
false
false
emberjs
ember.js
232
768983b0ddabe8e79144d3c6175eff2cc12ee466
Chris Krycho
Chris Krycho
[BUGFIX beta] update `@types/node` for TS 4.9 issue Note that this also bumps to TS 4.8.4 with some small bug fixes. That particular bump is not user-facing, however.
[bugfix beta] update `@types/node` for ts 4.9 issue
51
false
false
8
false
false
false
emberjs
ember.js
233
d61d713c055be1cc2c9c916c46d83af75f9af1ab
Katie Gengler
Katie Gengler
Add v4.9.0-beta.2 to CHANGELOG (cherry picked from commit 5c79b3f6d2352fa3ca2ae585e7c1b9662f754d29)
add v4.9.0-beta.2 to changelog
30
false
false
4
true
true
true
emberjs
ember.js
234
fdbd78031fd98da373af0623fe9c448cf5709550
Ben Tidy
GitHub
Remove fallback to ember
remove fallback to ember
24
false
false
4
true
true
true
emberjs
ember.js
235
811fd074c82943b8bb33455ada15e58f034f8736
Ben Tidy
GitHub
Include package name in deprecation function So this slightly changes the deprecation message to allow for package (namespace) to be included in the error message. This make it so that the message "will be removed in ember (package version)" is replaced with "will be removed in (package name) (package version)". This was change was proposed because of this usage: https://github.com/adopted-ember-addons/ember-metrics/blob/f604272de70e44ac731c711cfad5eae8792ee3ca/addon/metrics-adapters/google-tag-manager.js#L50 and this issue: https://github.com/adopted-ember-addons/ember-metrics/issues/453
include package name in deprecation function
44
false
false
6
false
false
false
emberjs
ember.js
236
d9240d5f7b7ce95e4742682b936d20d07475599d
Rich Vallone
Rich Vallone
Fix typos
fix typos
9
false
false
2
true
true
false
emberjs
ember.js
237
7d9095f38911d30aebb0e67ceec13e4a9818088b
Chris Krycho
GitHub
Merge pull request #20228 from emberjs/fix-controller-type-preview [BUGFIX release] Remove type export for ControllerMixin
merge pull request from emberjs/fix-controller-type-preview
60
true
false
5
true
false
false
emberjs
ember.js
238
f17400e938759b1065d53ae2bc9dd124608666b0
Chris Krycho
Chris Krycho
[BUGFIX release] Remove type export for ControllerMixin This type does not exist to be imported from the location it existed at in the definitions, and so the types could auto-suggest an import which would produce a runtime error. Remove it to prevent users from being misled this way. See also: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/62784
[bugfix release] remove type export for controllermixin
55
false
false
7
false
false
false
emberjs
ember.js
239
17a871866b6132d0fd81536828d697573fc762c0
Chris Krycho
GitHub
Merge pull request #20227 from emberjs/bugfix-ts-4.9 [BUGFIX release] Fix unsafe internal cast for NativeArray
merge pull request from emberjs/bugfix-ts-4.9
46
true
false
5
true
false
false
emberjs
ember.js
240
04d3a8816c4640964165d6a1d639ad40da70cffb
Chris Krycho
Chris Krycho
[BUGFIX release] Fix unsafe internal casts for TS 4.9 - For casting to `NativeArray` from `T[] & EmberArray<unknown>`: we do not have enough information to be able to tell TypeScript that the cast is safe here (and likely never will). TS 4.9 seems to handle the intersection type more robustly, though it is not yet documented. Here we make the cast from `T[] & EmberArray<T>` to `NativeArray<T>` even *more* explicitly unsafe via an `as unknown` intermediary cast. - For handling a proxy getter: TS' intersection of the `this` type for the `get()` method on a proxy receiver object used in `CoreObject` now flags up that the type of `this` may *not* be exactly `CoreObject`. Using `typeof this` in that intersection instead allows TS to see that the trap is safe.
[bugfix release] fix unsafe internal casts for ts 4.9
53
false
false
9
false
false
false
emberjs
ember.js
241
c617784ac866d00c9886207e9efb3799720a7ee7
Katie Gengler
Katie Gengler
Post-release version bump
post-release version bump
25
false
false
3
false
false
false
emberjs
ember.js
242
53affff6b3c8af459442034bcddac09e135a33fb
Katie Gengler
Katie Gengler
Add v4.9.0-beta.1 to CHANGELOG (cherry picked from commit 1211052b2aa89ac90009f9b626e542754c9a383a)
add v4.9.0-beta.1 to changelog
30
false
false
4
true
true
true
emberjs
ember.js
243
449c9a5cf0264d304805c00ac9937e88bd438111
Katie Gengler
Katie Gengler
Add v4.8.0 to CHANGELOG (cherry picked from commit 9021de5a7c49d2556ccbe5f671c1b90a57da4cf1)
add v4.8.0 to changelog
23
false
false
4
true
true
true
emberjs
ember.js
244
a6f73ac809cce4659f8d2d76bb0081995f53022a
Roman
Roman
[CLEANUP] use `console.debug` directly Right now `console.info` is called without a fallback to `console.log`. On the other hand `console.log` had a fallback to `console.log` - it looks like (based on caniuse) that all major browsers support the different `console.*` methods. This commit follows the same pattern like `console.info`.
[cleanup] use `console.debug` directly
38
false
false
4
false
false
false
emberjs
ember.js
245
1ea72b1cd37d80b45f97f05ef228dfeb13405370
Chris Krycho
Chris Krycho
Add v4.4.3 to CHANGELOG (cherry picked from commit fd0f7cbeea607084ae1b29201e1bec56db0c7d5c)
add v4.4.3 to changelog
23
false
false
4
true
true
true
emberjs
ember.js
246
908329efd8d45829e960b38740cd95d6493bf732
Chris Krycho
Chris Krycho
Add v4.7.1 to CHANGELOG (cherry picked from commit 9113e22b1c820b8ae149293782cd1d5d5ea63a67)
add v4.7.1 to changelog
23
false
false
4
true
true
true
emberjs
ember.js
247
474ef5adce1e9e83ffddc58eae16879f135d95bc
Chris Krycho
GitHub
Merge pull request #20218 from bertdeblock/update-extend-prototypes-type Remove `Function` and `String` from `EXTEND_PROTOTYPES` type
merge pull request from bertdeblock/update-extend-prototypes-type
66
true
false
5
true
false
false
emberjs
ember.js
248
96bb3ea1dd6edb1a148413ff4b3ae71c93f6aff5
Bert De Block
Bert De Block
Remove `Function` and `String` from `EXTEND_PROTOTYPES` type
remove `function` and `string` from `extend_prototypes` type
60
false
false
7
true
true
false
emberjs
ember.js
249
75ce611ad73bec1cb2ff33126b941550ab2e71d1
dependabot[bot]
GitHub
Bump volta-cli/action from 1 to 4 Bumps [volta-cli/action](https://github.com/volta-cli/action) from 1 to 4. - [Release notes](https://github.com/volta-cli/action/releases) - [Changelog](https://github.com/volta-cli/action/blob/master/CHANGELOG.md) - [Commits](https://github.com/volta-cli/action/compare/v1...v4) --- updated-dependencies: - dependency-name: volta-cli/action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
bump volta-cli/action from 1 to 4
33
true
true
6
false
false
false
emberjs
ember.js
250
d79543c2f9aeb4e94dc6783927eefb63e00c1c47
Matthew Beale
GitHub
Merge pull request #20124 from geneukum/update-ember-deprecate-docs
merge pull request from geneukum/update-ember-deprecate-docs
61
true
false
5
true
false
false
emberjs
ember.js
251
81c10c76d5f074d9113a921e1117c290bda21fe9
Katie Gengler
Katie Gengler
Add v4.8.0-beta.5 to CHANGELOG (cherry picked from commit 6cd18e4f675bab791ccc0b22e68b48be34e13c2e)
add v4.8.0-beta.5 to changelog
30
false
false
4
true
true
true
emberjs
ember.js
252
b930a4c8179fe62c1330371235317e89100a3ff2
Matthew Beale
GitHub
Merge pull request #20200 from antonovkrez/patch-1
merge pull request from antonovkrez/patch-1
44
true
false
5
true
false
false
emberjs
ember.js
253
454a8f0005136294f4a466903b1095c702d4031a
Geordan Neukum
Matthew Beale
[DOC] describe ember deprecation system Let's add a brief description of the ember deprecation system to the `deprecate` API docs. This should give developers a little bit more insight into how deprecations work in the ember ecosystem.
[doc] describe ember deprecation system
39
false
false
5
false
false
false
emberjs
ember.js
254
86d2a46ff0e3f7588bca8c0645d5109184e0f1ec
Geordan Neukum
Matthew Beale
[DOC] add example usage of `deprecate`
[doc] add example usage of `deprecate`
38
false
false
6
false
false
false
emberjs
ember.js
255
839e1a71f16857f7a7e23d98b22cc02a0e6922e8
Matthew Beale
GitHub
Merge pull request #20146 from SolPier/updating-cached-decorator-documentation
merge pull request from solpier/updating-cached-decorator-documentation
72
true
false
5
true
false
false
emberjs
ember.js
256
66d27290767ab9eebdd869f0aeab1efa0e143d1e
Matthew Beale
GitHub
Merge pull request #20138 from nicolechung/docs_add_yield_examples
merge pull request from nicolechung/docs_add_yield_examples
60
true
false
5
true
false
false
emberjs
ember.js
257
5c65cb5bbf862419cccdc39ebab62ef7ad7d7d30
dependabot[bot]
GitHub
Bump broccoli-babel-transpiler from 7.8.0 to 7.8.1 Bumps [broccoli-babel-transpiler](https://github.com/babel/broccoli-babel-transpiler) from 7.8.0 to 7.8.1. - [Release notes](https://github.com/babel/broccoli-babel-transpiler/releases) - [Changelog](https://github.com/babel/broccoli-babel-transpiler/blob/v7.8.1/CHANGELOG.md) - [Commits](https://github.com/babel/broccoli-babel-transpiler/compare/v7.8.0...v7.8.1) --- updated-dependencies: - dependency-name: broccoli-babel-transpiler dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
bump broccoli-babel-transpiler from 7.8.0 to 7.8.1
50
true
true
6
true
true
false
emberjs
ember.js
258
0aa5177ffc6585dc4c8872da2f5ae6fdad86c1ca
dependabot[bot]
GitHub
Bump @typescript-eslint/parser from 5.38.0 to 5.38.1 Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.38.0 to 5.38.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.38.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
bump @typescript-eslint/parser from 5.38.0 to 5.38.1
52
true
true
6
false
true
false
emberjs
ember.js
259
59067cad7f860de23b000d7365e863032fdb6068
Chris Krycho
GitHub
Merge pull request #20189 from pablonajera/pablonajera/reformat-evented-for-ts [DOC] moving comment docs to interface methods – `Evented`
merge pull request from pablonajera/pablonajera/reformat-evented-for-ts
72
true
false
5
true
false
false
emberjs
ember.js
260
b7adcdaba649ac98509015a5c5d8a651c2646ddd
Chris Krycho
GitHub
Merge pull request #20212 from emberjs/beta-types-routing [BUGFIX beta] remove wrong exports from preview routing types
merge pull request from emberjs/beta-types-routing
51
true
false
5
true
false
false
emberjs
ember.js
261
cf010f759fe3369dfcdf5d75a762fda7c178a9da
Chris Krycho
Chris Krycho
[BUGFIX beta] remove wrong exports from preview routing types These exports appeared in the DefinitelyTyped definitions for a very long time, and were missed when migrating them for the preview. This change aligns the type exports with the actual public API.
[bugfix beta] remove wrong exports from preview routing types
61
false
false
9
false
false
false
emberjs
ember.js
262
323dae073d00c87ee3f48c115499b7e2c15e402e
Pablo Najera
Pablo Najera
adding comment annotations back
adding comment annotations back
31
false
false
4
false
false
false
emberjs
ember.js
263
4b3af509e8b0226b35375ee366b7915363b61494
Chris Krycho
GitHub
Merge pull request #20204 from emberjs/add-ts-semver-ci
merge pull request from emberjs/add-ts-semver-ci
49
true
false
5
true
false
false
emberjs
ember.js
264
87417ab4cc458cecf870e45f47b10d8a06ade668
Chris Krycho
Chris Krycho
Update to latest @types/node for TS 4.9 fixes
update to latest @types/node for ts 4.9 fixes
45
false
false
8
false
false
false
emberjs
ember.js
265
9921e72527239e0261094258dd69ae1d1a9ad269
Chris Krycho
Chris Krycho
Fix internal issues caught by TS 4.9 TS 4.9 understands the `in` operator and catches two issues for us which earlier versions did not: 1. We were checking `name in model` in `Route#serialize` without checking that `model` there is an object. Given that a route's model is *not* guaranteed to be an object, this was a runtime error waiting to happen. `'a' in 2` will produce `TypeError: 2 is not an Object.' 2. We were checking for `Symbol.iterator in Array` in an internal `iterate()` utility in the `@ember/debug/data-adapter` package. This check is *always* true when targeting ES6 or newer for arrays, which would *appear* to makie the `else` branch a no-op on all supported browsers. Unfortunately, at least some consumers of this API implement a narrower contract for iterables (presumably due to legacy needs to interop with IE11 in Ember < 4.x). In those cases, we really have an iterable, *not* an array.
fix internal issues caught by ts 4.9
36
false
false
7
true
true
true
emberjs
ember.js
266
5bb493428c332c29a62969ffd6b55cb9567889ad
Chris Krycho
Chris Krycho
[FEATURE] Test all supported TS versions in CI As part of implementing RFC 0800, introduce support for testing all supported versions of TypeScript against our types. For the moment, the only additional supported version is the TypeScript nightly (`next`) build. When we get to publishing stable types, the current version will be the first version we support, and we will add new versions to the matrix over time in line with the "rolling window" support policy. Additionally, *remove* type checking from the `lint` scripts and create a new set of `type-check` scripts instead. This is pragmatic, not philosophical: we treat it differently from the "lints" here in that we need to be able to run it repeatedly against different versions, whereas the lints are all one-and-done.
[feature] test all supported ts versions in ci
46
false
false
8
false
false
false
emberjs
ember.js
267
3ec17789315fec24f63de0e0ab3177feb8906d83
Katie Gengler
Katie Gengler
Add v4.8.0-beta.4 to CHANGELOG (cherry picked from commit 4ca204d9618ad3f3603908cb6caba917f8369908)
add v4.8.0-beta.4 to changelog
30
false
false
4
true
true
true
emberjs
ember.js
268
ffbed6094581eab9a4645563a6da09b0834e1a8c
Peter Wagenet
GitHub
Merge pull request #20127 from patricklx/patch-2 [bug] TypeWatcher invoking itself during onChange
merge pull request from patricklx/patch-2
42
true
false
5
true
false
false
emberjs
ember.js
269
1e35fce99ef801de3f0eaedde5d663f991838df0
Chris Krycho
GitHub
Merge pull request #20199 from shibulijack/docs-array [DOC] Format API docs for Typescript - @ember/array
merge pull request from shibulijack/docs-array
47
true
false
5
true
false
false
emberjs
ember.js
270
90be30986cc91dd280cd47d2e6a96e49c8d68c16
slijack
slijack
Fixed bug
fixed bug
9
false
false
2
false
false
false
emberjs
ember.js
271
c63a1f61c9e31d2e67855c2d886f4eedb9d0f3c3
Ivan Antonov
GitHub
Update license.js
update license.js
17
false
false
2
false
false
false
emberjs
ember.js
272
68fce234e51b3d0d6d9241a96833dfeb81303734
Ivan Antonov
GitHub
Update LICENSE
update license
14
false
false
2
true
false
false
emberjs
ember.js
273
7b608439d28bd9d3e8843cbc4ba71f8a5380429f
Chris Krycho
GitHub
Merge pull request #20206 from emberjs/dependabot/npm_and_yarn/mout-1.2.4 Bump mout from 1.2.3 to 1.2.4
merge pull request from emberjs/dependabot/npm_and_yarn/mout-1.2.4
67
true
false
5
true
false
false
emberjs
ember.js
274
f0918b48d4012205c761e52fdb29375f470dc9a7
Chris Krycho
GitHub
Merge pull request #20192 from TechieQian/qianwan/promise-proxy-mixin-doc-ts [DOC] Reformatting Ember API docs for Typescript - proxy-mixin-interface
merge pull request from techieqian/qianwan/promise-proxy-mixin-doc-ts
70
true
false
5
true
false
false
emberjs
ember.js
275
6d6cc5dead76f47ae8cf3bbb162941219b241d45
Chris Krycho
GitHub
Merge pull request #20202 from jalexakos/patch-1 [DOC] Reformat API docs for Typescript - @ember/controller
merge pull request from jalexakos/patch-1
42
true
false
5
true
false
false
emberjs
ember.js
276
943201ff97c00079e46a7f5a4a7f1dbd66c97c3f
Chris Krycho
GitHub
Merge pull request #20191 from 52052100/layang/reformat-evented-for-ts [DOC] Reformatting Ember API docs for Typescript - `@ember/object/observable`
merge pull request from 52052100/layang/reformat-evented-for-ts
64
true
false
5
true
false
false
emberjs
ember.js
277
0a942cdc7165f114a87b4dc23cf9034dd29f8355
slijack
slijack
Added missing doc annotations
added missing doc annotations
29
false
false
4
false
false
false
emberjs
ember.js
278
af7163df5db9bc56e88aad4cc7ec42e5aa96d214
slijack
slijack
Added doc annotations
added doc annotations
21
false
false
3
false
false
false
emberjs
ember.js
279
a7951deedb0b46cf4670ca241a021eb4670fec05
Josh Alexakos
GitHub
Re-add tags
re-add tags
11
false
false
2
false
false
false
emberjs
ember.js
280
73016e3798fa089512089e28b97b45d4d67a19e1
layang
layang
add annotations to comment
add annotations to comment
26
false
false
4
true
true
true
emberjs
ember.js
281
4a113ef1f56e4dc579bc5ae2b940025f40490e2b
Qian Wan
Qian Wan
address comments
address comments
16
false
false
2
false
true
false
emberjs
ember.js
282
4ac8f4b9f4f57c2ecb36c359cda8605355c24e29
layang
layang
Update observable.ts
update observable.ts
20
false
false
2
false
false
false
emberjs
ember.js
283
32e05802ee1e0ee4abbb78dcf9c3eee29c4657de
Chris Krycho
GitHub
Merge pull request #20203 from emberjs/ts-4.8 [FEATURE] Update to Ember 4.8
merge pull request from emberjs/ts-4.8
39
true
false
5
true
false
false
emberjs
ember.js
284
2271945de3f27b8bc63982e1e3724be3b182e44b
dependabot[bot]
GitHub
Bump mout from 1.2.3 to 1.2.4 Bumps [mout](https://github.com/mout/mout) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/mout/mout/releases) - [Changelog](https://github.com/mout/mout/blob/master/CHANGELOG.md) - [Commits](https://github.com/mout/mout/compare/v1.2.3...v1.2.4) --- updated-dependencies: - dependency-name: mout dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
bump mout from 1.2.3 to 1.2.4
29
true
true
6
true
true
false
emberjs
ember.js
285
0b4f5340975084133494623bb1b8a6506ddf6dde
Chris Krycho
Chris Krycho
[FEATURE] Add support for Ember 4.8 We were previously using 4.6. We'll aim to keep this up to date going forward. Here, update the dependency and then address two safety issues it caught on either 4.7 or 4.8 but did not back on 4.6.
[feature] add support for ember 4.8
35
false
false
6
false
false
false
emberjs
ember.js
286
cadee1350ec7d7bb071d246cc1e3b0436ff39f4b
Chris Krycho
GitHub
Merge pull request #20205 from emberjs/fix-ts-lint-errors [INTERNAL] fix TS linting issues
merge pull request from emberjs/fix-ts-lint-errors
51
true
false
5
true
false
false
emberjs
ember.js
287
ef3926a60ffb14690e79902f26d984c49ffab709
Josh Alexakos
GitHub
Fix missing tags lint error
fix missing tags lint error
27
false
false
5
true
true
true
emberjs
ember.js
288
55d01f50dd012f819541151f16537c6eaa28dc2d
Chris Krycho
Chris Krycho
[INTERNAL] fix TS linting issues - Update to latest `typescript-eslint` parser and plugin. - Fix a couple newly-identified lint issues. I also have *some* hopes that this will fix the issues with linting we have seen on CI (which I suspect are just a bad cache).
[internal] fix ts linting issues
32
false
false
5
false
false
false
emberjs
ember.js
289
0d3399046e01635a07eb9c1dd6091750fca5765b
Josh Alexakos
GitHub
[DOC] Reformat API docs for Typescript - @ember/controller ## Summary Addressing Issue: [20172](https://github.com/emberjs/ember.js/issues/20172) ## Details - Moved documentation for public APIs from `Mixin.create()` to the `ControllerMixin` interface - Removed all unnecessary JSDocs tags (comments with `@` preceding them) - Left private methods and properties documentation untouched
[doc] reformat api docs for typescript - @ember/controller
58
false
false
8
false
false
false
emberjs
ember.js
290
50e340a8963c4eab80c1d79d1236e63cabbd2485
Chris Krycho
GitHub
Merge pull request #20201 from emberjs/fix-routing-type [BUGFIX beta]: fix type definition for `Route`
merge pull request from emberjs/fix-routing-type
49
true
false
5
true
false
false
emberjs
ember.js
291
a6d6831e242eb410a2d924735746119ccd25c95c
patricklx
patricklx
fix TypeWatcher invoking itself during onChange
fix typewatcher invoking itself during onchange
47
false
false
6
true
true
true
emberjs
ember.js
292
5f8e4211fb5eb558e8d00024bc4d72f8413b8b07
Chris Krycho
Chris Krycho
[BUGFIX beta]: fix type definition for `Route` This was the only remaining use of `.extend()` to apply the associated mixin, and the types were longer working correctly since `.extend()` no longer creates new types.
fix type definition for `route`
31
false
false
5
false
true
false
emberjs
ember.js
293
369b0ed950b80a1302973efad60591da7b6ef71a
Qian Wan
Qian Wan
modify docs
modify docs
11
false
false
2
false
true
false
emberjs
ember.js
294
46774eba9a2e8956dd7227cdbd08aad96fe74b26
Katie Gengler
Katie Gengler
Add v4.8.0-beta.3 to CHANGELOG (cherry picked from commit 975b69e3de1bc8f8f6ad2c5096438c35c712f8ff)
add v4.8.0-beta.3 to changelog
30
false
false
4
true
true
true
emberjs
ember.js
295
98e7aaf12362914f7ad2e57d299db399ef118fc4
Ivan Antonov
GitHub
Update license.js
update license.js
17
false
false
2
false
false
false
emberjs
ember.js
296
2513dd14afc0472d3e129a0b78d676bec9584a1d
Ivan Antonov
GitHub
Update LICENSE
update license
14
false
false
2
true
false
false
emberjs
ember.js
297
2290078615a70a22013bc4780b4239bb92e1b534
Ivan Antonov
GitHub
fix license year
fix license year
16
false
false
3
true
true
true
emberjs
ember.js
298
668d80210ebfad034a0f9b27c12c2ee4ae389ab6
slijack
slijack
Update proxy.ts
update proxy.ts
15
false
false
2
true
false
false
emberjs
ember.js
299