content
stringlengths 240
2.34M
|
|---|
<issue_start><issue_comment>Title: Messages should support simple markdown
username_0: It should be possible to add markdown to messages.
There isn't a implementation for proper multi-line messages atm. so this could be a limited markdown, a subset.
I'm thinking the following should be included:
- *Italics*
- **Bold**
- `Code block`
- ~~Strikethrough~~
The markdown should be parsed from the message before rendering. This can be done similar to emojify and linkify parts of the message rendering.
<issue_comment>username_1: Inline code would also be super nice `like this` |
<issue_start><issue_comment>Title: MovieClip vs Graphic
username_0: implement differentiation between this with looping = true / false
<issue_comment>username_0: Rather than Graphics/MovieClips looping or not looping, they both loop. Graphics rather only loop or play for the number of frames available in the parent timeline. Where MovieClips will loop based on their own timeline.
<issue_comment>username_0: After discussing with @kundugoutam there is no need to differentiate.<issue_closed> |
<issue_start><issue_comment>Title: Improve documentation for prepare-information-files
username_0: I've had a frustrating morning with qiita documentation, and wanted to see how I can help.
[Prepare information files on website](https://qiita.ucsd.edu/static/doc/html/tutorials/prepare-information-files.html)
[Prepare information files source on github](https://github.com/biocore/qiita/blob/master/qiita_pet/support_files/doc/source/tutorials/prepare-information-files.rst)
This page describes the requirements of `sample information file` and `prep information file` but raises more questions than it answers.
- How does these files differ in purpose?
- How does these files differ in contents? (Could they be identical or include identical columns? Is it better to increase or decrease redundancy between these file?)
- How do these files relate to the [qiita philosophy](https://qiita.ucsd.edu/static/doc/html/qiita-philosophy/index.html)?
I'm getting the sense that the distinction between these is super intuitive to the developers, but less clear to novice users like me. I'm interesting in contributing to documentation so that this system is clear to everyone.
Thanks!
<issue_comment>username_1: Thank you for writing and letting us know. Did you take a look at https://qiita.ucsd.edu/static/doc/html/faq.html?
BTW any suggestions will be greatly appreciated.
<issue_comment>username_0: The FAQ page is very helpful. Thank you Antonio.
With fresh eyes this afternoon, I have a better understanding of how these two templates fit into the qiita philosophy. I'll describe the system as best I understand it in a PR and I would appreciate any guidance you have to give.
Thank you!
<issue_comment>username_1: That will be great, thanks! Again, any suggestions to make things clearer are welcome.
<issue_comment>username_0: Should I refer to the biological metadata file as `sample information file` or `sample template` or 'metadata'?
(Consistent, unambiguous wording is important, especially for beginners. The old qiime docs calls these `metadata` and `mapping` file. Was there a reason for introducing two new terms for the same files, because 😱 )
<issue_comment>username_1: Good catch and the 3 names are from historical reasons and we know there are some left over occurrences.
Let's start with the most confusing, template vs. information file. The name template comes from the old DB and basically it became a thing to call your information files, even as they are not templates anymore cause they have all the information we need. Thus, a couple of months ago we decided to move to information files, which is actually correct. We will really appreciate all corrections in the documentation about this.
Now, the template or mapping file, AKA the QIIME mapping file, it's a combination of the sample and one preparation information file. The idea of Qiita, as you can see from the documentation is that you have 1 sample but multiple preps. Thus, expanding that idea.
Again, thanks for the help.
<issue_comment>username_0: Thanks for the info. I understand now why qiita specifically separates 'sample info' and 'prep information' files and why a clean break from the 'metadata / mapping' confusion is needed. Now I'm finally grasping this data structure, I think I can actually help describe it.
As of now, ['Sample information file'](https://github.com/biocore/qiita/search?utf8=%E2%9C%93&q=%22sample+information+file%22&type=Code) is only used on the FAQ and Prepare information files page. This wording on other doc pages, on the live site, and in the variable names selves all use ['Sample template'](https://github.com/biocore/qiita/search?utf8=%E2%9C%93&q=%22sample+template%22&type=Code). So what's the correct nomenclature going forward?
<issue_comment>username_1: _Sample information file_ is the correct name and what we want to have everywhere in the documentation/descriptions/etc. As you can imagine there are a lot of places in the code, which in general is hidden from users, were we still use the _sample template_ name and changing it will be a heroic task as it will require changing the code and have a (set of) patch(es) to change them in the database.
<issue_comment>username_1: This issue is related to: https://github.com/biocore/qiita/issues/1785
<issue_comment>username_0: Right, right. Updating all the backend code is overkill and probably not worth it, but fixing the public facing stuff is important. I'll start the conversion over to 'Sample information file' with the documentation pages.
Thanks!
<issue_comment>username_0: The [Qiita phyilosophy](https://qiita.ucsd.edu/static/doc/html/qiita-philosophy/index.html) should heavily emphisize the distinction between Samples and Preps. We could add this to the graphic and add a section under 'A Study' to emphasize the one-to-many relationship between them.
Who has the source that made that graphic? I could updated it.
<issue_comment>username_1: Seems like I never added it to the repo (logos folder), I'll send it to you via email.
<issue_comment>username_0: The old [prepare-templates.html page](https://qiita.ucsd.edu/static/doc/html/tutorials/prepare-templates.html) should mention that 'templates' have been depreciated in favor of 'information files' and redirect to [the new prepare-information-files.html page](https://qiita.ucsd.edu/static/doc/html/tutorials/prepare-information-files.html).
That old templates page is no longer on github, so I'm not sure how to submit a PR for this...
<issue_comment>username_1: Interesting, the reason the old one exists is because we don't delete the old builds. I think the best will be to create a new one with the old name and add that info. Thanks!
<issue_comment>username_0: Do successful builds on github push to qiita.ucsd.edu? I'm used to them pushing to gh-pages, so I assumed no automation.
I'll try making a `prepare-templates.rst` file now and see if I can overwrite the old page...
Thanks Antonio. You have been both helpful and supportive here.
<issue_comment>username_1: No, the documentation is built when we (re)start (update) the system. Just FYI, we are planning a restart for this weekend.
<issue_comment>username_0: Very cool. Thanks for telling me more about this system. So, if I understand correctly: my PRs get built automatically and you can review and merge them. Every so often, you take the newest stable build and launch it to the live site?
<issue_comment>username_1: That's correct.
<issue_comment>username_0: Thanks for all the feedback Antonio. I appreciate all your help here.
Now that this page is almost fixed, what about the rest of the sit?. 'Template' is still the common term on the site itself and on the [Getting started page](https://github.com/biocore/qiita/blob/master/qiita_pet/support_files/doc/source/tutorials/getting-started.rst). What's a good way to move forward?
<issue_comment>username_1: I guess we will need to change all the documentation 😐. Also, we just changed the GUI and those updates are not reflected 😢. We will really appreciate help with this ...
<issue_comment>username_0: Haha right. This is a great 'tech minimal' way I am help out. Your team has done a very good job using modern technologies, so this may be pretty possible (not a lot of rendered images to update, for example).
Maybe you could create a new issue for this and make an overview task list? Then could start a mammoth PR.
<issue_comment>username_1: Thank you for your help with this!! This is super important but we have to manage new features vs. documentation, and ~~must~~ some times we get behind. Added https://github.com/biocore/qiita/issues/1828, where I think we have a comprehensive list but will be worth a second check.
<issue_comment>username_0: Oh I've been there on my own projects. One this one, I can help keep the ball rolling on documentation. Once this PR get's resolved, I'll close this issue, and focus on work on #1828.
Thanks Antonio.
<issue_comment>username_1: No, thank you! 😉 . BTW: [see](https://github.com/biocore/qiita/blob/master/CONTRIBUTING.md#the-qiita-development-rules) and you can automatically close issues once the PR is merge if you add to one of your commits something like `fix #issue-number`.
<issue_comment>username_0: Yeah, I alway remember to do that when submitting the PR, not when committing the changes. I'll try that next time.<issue_closed>
<issue_comment>username_0: Closing in favor of #1828 |
<issue_start><issue_comment>Title: Fix nuspecs
username_0: Fix <i>Microsoft.Orleans.Templates.Grains</i> and <i>Microsoft.Orleans.Templates.Interfaces</i> nuspecs to import targets and props to the target project.
Fix <i>Microsoft.Orleans.Client</i> and <i>Microsoft.Orleans.Server</i> nuspecs to copy configuration files to the root of target project |
<issue_start><issue_comment>Title: 3D scatter plot and axis label from chart format
username_0: The chart format allows to specify axis with unit, label, min and max value.
Would be nice that the 3D scatter plot support those informations.
Testcase: http://visualizer.epfl.ch/tiny/HvPPmmTwqcA7qPI0L0lu ([Original URL](http://visualizer.epfl.ch/c/home/index.html))<issue_closed> |
<issue_start><issue_comment>Title: Support GPU
username_0: Does this library support GPU (like cuda)? I use your library in my project but performane is quite low, not realtime with video HD (1280x720, 12fps). Thanks!
<issue_comment>username_1: Hi @username_0, unfortunately the bgslibrary library does not support GPU yet =/
But it will be a nice feature for a future version...I'm always open for everyone that wants to propose new contributions or new features. I have a lot of improvements that I would like to do in the bgslibrary, but currently my doctoral research takes me a lot of time... =/ |
<issue_start><issue_comment>Title: add optimization of priority functions section for multi-scheduler proposal
username_0:
<issue_comment>username_0: @username_1 updated.
<issue_comment>username_0: @username_1 Done.
<issue_comment>username_0: @username_1 Done, PTAL.
<issue_comment>username_1: LGTM
<issue_comment>username_1: (removing LGTM)
actually, sorry, one more thing to fix: it should say "conflict on the Kubelet" not "conflict in the optimistic concurrency control" (in Kubernetes, in the current implementation, we don't detect scheduling conflicts until the Kubelet.... I keep confusing Omega and Kubernetes) Sorry for telling you the wrong thing.
I promise that's the last thing to fix!
<issue_comment>username_0: @username_1
It doesn't matter, don't mind. fixed.
<issue_comment>username_1: LGTM
<issue_comment>username_2: ref #18414
Just found this. This seems to be a potential option. I'm cross referencing related work. Hope no one minds :) |
<issue_start><issue_comment>Title: [BugReport] Attempt to read from field 'boolean com.jecelyin.android.file_explorer.FileListPagerFragment$ScanFilesTask.isRoot' on a null object reference
username_0: Memory: 260 MB / 903 MB
LogCat Error:
Tag: JecLog
Msg: parse line error: /system/dalvikvm32: No such file or directory
Stacktrace:
java.lang.NumberFormatException: Invalid long: "file"
at java.lang.Long.invalidLong(Long.java:124)
at java.lang.Long.parse(Long.java:363)
at java.lang.Long.parseLong(Long.java:353)
at java.lang.Long.parseLong(Long.java:321)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:213)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:279)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:279)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.getRealPath(RootUtils.java:116)
at com.username_1.android.file_explorer.io.RootFile.getAbsolutePath(RootFile.java:88)
at com.username_1.android.file_explorer.io.RootFile.listFiles(RootFile.java:110)
at com.username_1.android.file_explorer.FileListPagerFragment$ScanFilesTask.onRun(FileListPagerFragment.java:299)
at com.username_1.android.file_explorer.FileListPagerFragment$ScanFilesTask.onRun(FileListPagerFragment.java:275)
at com.username_1.common.task.JecAsyncTask.doInBackground(JecAsyncTask.java:40)
at android.os.AsyncTask$2.call(AsyncTask.java:295)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)
Tag: JecLog
Msg: parse line error: /system/grep: No such file or directory
Stacktrace:
java.lang.NumberFormatException: Invalid long: "file"
at java.lang.Long.invalidLong(Long.java:124)
at java.lang.Long.parse(Long.java:363)
at java.lang.Long.parseLong(Long.java:353)
at java.lang.Long.parseLong(Long.java:321)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:213)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:279)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:279)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.getRealPath(RootUtils.java:116)
at com.username_1.android.file_explorer.io.RootFile.getAbsolutePath(RootFile.java:88)
at com.username_1.android.file_explorer.io.RootFile.listFiles(RootFile.java:110)
at com.username_1.android.file_explorer.FileListPagerFragment$ScanFilesTask.onRun(FileListPagerFragment.java:299)
at com.username_1.android.file_explorer.FileListPagerFragment$ScanFilesTask.onRun(FileListPagerFragment.java:275)
at com.username_1.common.task.JecAsyncTask.doInBackground(JecAsyncTask.java:40)
at android.os.AsyncTask$2.call(AsyncTask.java:295)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)
Tag: JecLog
Msg: parse line error: /system/logpersist.start: No such file or directory
Stacktrace:
java.lang.NumberFormatException: Invalid long: "file"
at java.lang.Long.invalidLong(Long.java:124)
at java.lang.Long.parse(Long.java:363)
at java.lang.Long.parseLong(Long.java:353)
at java.lang.Long.parseLong(Long.java:321)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:213)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:279)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.lsParser(RootUtils.java:279)
at com.username_1.android.file_explorer.util.RootUtils.listFileInfo(RootUtils.java:168)
at com.username_1.android.file_explorer.util.RootUtils.getRealPath(RootUtils.java:116)
at com.username_1.android.file_explorer.io.RootFile.getAbsolutePath(RootFile.java:88)
at com.username_1.android.file_explorer.io.RootFile.listFiles(RootFile.java:110)
at com.username_1.android.file_explorer.FileListPagerFragment$ScanFilesTask.onRun(FileListPagerFragment.java:299)
at com.username_1.android.file_explorer.FileListPagerFragment$ScanFilesTask.onRun(FileListPagerFragment.java:275)
at com.username_1.common.task.JecAsyncTask.doInBackground(JecAsyncTask.java:40)
at android.os.AsyncTask$2.call(AsyncTask.java:295)
[Truncated]
Model: Andromax A16C3H
Thread: main-1
CrashReporter Key: AA4794BC-44F8-C015-C749-3B4D6920E49CF36A7FF8
Start Date: Sun Nov 13 09:42:35 GMT+07:00 2016
Date: Sun Nov 13 09:44:49 GMT+07:00 2016
java.lang.NullPointerException: Attempt to read from field 'boolean com.username_1.android.file_explorer.FileListPagerFragment$ScanFilesTask.isRoot' on a null object reference
at com.username_1.android.file_explorer.FileListPagerFragment$ScanFilesTask.access$700(FileListPagerFragment.java:275)
at com.username_1.android.file_explorer.FileListPagerFragment$6.onCompleted(FileListPagerFragment.java:201)
at com.username_1.common.task.JecAsyncTask.onComplete(JecAsyncTask.java:63)
at com.username_1.common.task.JecAsyncTask.onPostExecute(JecAsyncTask.java:52)
at android.os.AsyncTask.finish(AsyncTask.java:651)
at android.os.AsyncTask.-wrap1(AsyncTask.java)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:668)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5461)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)<issue_closed> |
<issue_start><issue_comment>Title: [WFCORE-1357] Drop javax.sql.api artifact in anticipation of using th…
username_0: …e JDK javax.transaction.xa package
<issue_comment>username_0: It looks like ```org.wildfly.build.util.ModuleParser#parseResources()``` isn't consuming the content of the ```<artifact>``` element, which probably causes all the deps to get messed up.
<issue_comment>username_0: Depends on https://github.com/wildfly/wildfly-core/pull/1414
<issue_comment>username_0: Retest this please
<issue_comment>username_1: retest this please
<issue_comment>username_1: retest this please
<issue_comment>username_1: retest this please
<issue_comment>username_1: retest this please
<issue_comment>username_1: retest this please
<issue_comment>username_1: this actually passed |
<issue_start><issue_comment>Title: Program crash
username_0: After running for a while, it will crash. I check the source code but can't find the reason. Here is the log info:
```
panic: not reached
goroutine 859142 [running]:
panic(0x83f320, 0xc4211353a0)
/go-root/src/runtime/panic.go:500 +0x1a1
github.com/miekg/dns.(*response).Write(0xc420065480, 0xc421078300, 0x25, 0x26, 0x0, 0x0, 0x7f7cc19c9000)
/my-project-path/src/.vendor/src/github.com/miekg/dns/server.go:702 +0x325
github.com/miekg/dns.(*response).WriteMsg(0xc420065480, 0xc421949200, 0x1, 0xc420d0baa0)
/my-project-path/src/.vendor/src/github.com/miekg/dns/server.go:677 +0x9c
github.com/miekg/dns.HandleFailed(0xade740, 0xc420065480, 0xc42035f0e0)
/my-project-path/src/.vendor/src/github.com/miekg/dns/server.go:92 +0x8b
main.(*DNSHandler).do(0xc420129380, 0x8d5330, 0x3, 0xade740, 0xc420065480, 0xc42035f0e0)
/my-project-path/src/handler.go:223 +0x11db
created by main.(*DNSHandler).DoTCP
/my-project-path/src/handler.go:267 +0x72
```
My go version : go version go1.7.4 linux/amd64.
<issue_comment>username_1: Hi username_0, I pretty sure I know what cause that error to happen. It is something I fixed for the normal reply, but for HandledFailed function bypass my fixed. This is a case that happens when a TCP connection comes in and later get interrupted causing the writer to go nil. I can work on fixed for this.
<issue_comment>username_2: Should be fixed by #21<issue_closed> |
<issue_start><issue_comment>Title: "Got new bearer token" no longer logs distinct tokens
username_0: https://github.com/zooniverse/panoptes-javascript-client/blob/e7115da90a84089e115b571bb70956d35a0df351/lib/oauth.js#L232
The start of all bearer tokens is going to be the same for all. Better slice from the end.
<issue_comment>username_1: `String.slice()` does slice from the end with a negative index - [link](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/String/slice#Using_slice()_with_negative_indexes)<issue_closed> |
<issue_start><issue_comment>Title: A question about converting the inputs
username_0: Thanks for the library first.
My question is, I have a input data which is
[torch.LongTensor of size 30x100]
and I want to convert it into a Table consists of 30 sub-tables,
and each sub-table has 100 sub-sub tables : DoubleTensor of Size 1
Then I can put them into a LSTM
is it possible to be implemented using modules like nn.SplitTables(1) ?
I tried:
mlp = nn.Sequential()
mlp:add(nn.SplitTable(1))
mlp:add(nn.Sequencer(nn.SplitTable(1)))
But What i got is not DoubleTensor of Size 1. What can i do?
<issue_comment>username_1: @username_0
Try adding a dimension :
```lua
require 'rnn'
input = torch.LongTensor(30,100)
mlp = nn.Sequential()
mlp:add(nn.View(30,100,1))
mlp:add(nn.SplitTable(1))
mlp:add(nn.Sequencer(nn.SplitTable(1)))
print(mlp:forward(input))
```<issue_closed>
<issue_comment>username_0: Thanks very much for the quick reply, but its still LongTensors and they can not be put into a nn.LSTM, right? |
<issue_start><issue_comment>Title: don't crash on bad cookie header
username_0: For a cookie header like "Cookie: foo" cowboy would just crash when calling cowboy_req:cookie/3.
```
17:56:54.312 [error] Ranch listener needle_http_listener terminated in needle_notes_h:forbidden/2 with reason: no case clause matching {error,badarg} in cowboy_req:cookie/3 line 429
17:56:54.314 [error] Error in process <0.1211.0> on node needle@eli with exit value:
{[{reason,{case_clause,{error,badarg}}},{mfa,{needle_notes_h,forbidden,2}},{stacktrace,[{cowboy_req,cookie,3,[{file,"_build/default/lib/cowboy/src/cowboy_req.erl"},{line,429}]},{needle_rest,check_authenticated,3,[{file,"/Users/zeank/src/JPCatholic/needle/_build/dev/lib/needle/src/needle_rest.erl"},{line,36}]},{cowboy_rest,call,3,[{file,"/Users/zeank/src/JPCatholic/needle/_build/default/lib/cowboy/src/cowboy_rest.erl"},{line,976}]},{cowboy_rest,expect,6,[{file,"/Users/zeank/src/JPCatholic/needle/_build/default/lib/cowboy/src/cowboy_rest.erl"},{line,960}]},{cowboy_protocol,execute,4,[{file,"/Users/zeank/src/JPCatholic/needle/_build/default/lib/cowboy/src/cowboy_protocol.erl"},{line,442}]}]},{req,[{socket,#Port<0.119171>},{transport,ranch_tcp},{connection,keepalive},{pid,<0.1211.0>},{method,<<"GET">>},{version,'HTTP/1.1'},{peer,{{127,0,0,1},49319}},{host,<<"localhost">>},{host_info,undefined},{port,8080},{path,<<"/classes/123/sessions/1232/notes">>},{path_info,undefined},{qs,<<>>},{qs_vals,undefined},{bindings,[{session,<<"1232">>},{class,<<"123">>}]},{headers,[{<<"host">>,<<"localhost:8080">>},{<<"user-agent">>,<<"curl/7.43.0">>},{<<"accept">>,<<"*/*">>},{<<"cookie">>,<<"foo">>}]},{p_headers,[]},{cookies,undefined},{meta,[]},{body_state,waiting},{buffer,<<>>},{multipart,undefined},{resp_compress,false},{resp_state,waiting},{resp_headers,[{<<"access-control-allow-credentials">>,<<"true">>},{<<"access-control-allow-origin">>,<<"*">>}]},{resp_body,<<>>},{onresponse,undefined}]},{state,#{}}],[{cowboy_rest,expect,6,[{file,"/Users/zeank/src/JPCatholic/needle/_build/default/lib/cowboy/src/cowboy_rest.erl"},{line,960}]},{cowboy_protocol,execute,4,[{file,"/Users/zeank/src/JPCatholic/needle/_build/default/lib/cowboy/src/cowboy_protocol.erl"},{line,442}]}]}
```
<issue_comment>username_1: Thanks.
<issue_comment>username_1: Wondering what would send "Cookie: foo" and if we really want to silently ignore any bad cookie value?
I think it would make more sense to crash and let the developer catch exceptions if needed, rather than silently drop it, unless a popular software is generating these cookie strings (like we do for empty cookie values).
<issue_comment>username_0: My initial concern was that it is hard to debug and understand what's going on when all you've got is that crash in your logs. That someone might have sent a bad cookie header. In my case I knew why because I was doing the request manually. But then I thought of a system in production.
<issue_comment>username_0: That said, maybe just having that reported issue around is already helpful enough?
<issue_comment>username_1: In Cowboy 2 this function is renamed into "parse_cookie" and its name and docs will imply that parsing is done and an exception will be thrown on error. But for 1.0 it's indeed confusing. Let's keep it open for now and see what happens. Thanks!
<issue_comment>username_0: Ah, nice! :)
>
<issue_comment>username_1: Won't merge for 1.1, too much uncertainty, I need to investigate more thoroughly than time allows. Thanks!
<issue_comment>username_1: Cowboy 1.x is old. Closing, thanks! |
<issue_start><issue_comment>Title: Background isn't blurred anymore from version 2.3
username_0: The background isn't blurred anymore. I've done some debugging and this bug was introduced at a741fea488a5c5a3500996b9500bc4f0645930b8 - Showing loader above keyboard.
Steps:
1. The progress window is created and makeKeyAndVisible (see `addProgressWindow`)
2. The `blurredScreenShot` method is called on the key windows , which now is the progress window, and the snapshot done by `- (BOOL)drawViewHierarchyInRect:afterScreenUpdates:` is empty.
<issue_comment>username_1: Hello @username_0!
Thanks for noticing this nasty bug 👍
It's now fixed. Until version 2.4 is released with this fix included, you can have it through CocoaPods by doing:
```ruby
pod 'KVNProgress', :git => 'https://github.com/AssistoLab/KVNProgress.git', :commit => '302514b'
```<issue_closed>
<issue_comment>username_1: Fix available in version **2.3.1**.
You can use it via `pod 'KVNProgress'` ✨
<issue_comment>username_2: I am still experiencing the same issue with 2.3.1. |
<issue_start><issue_comment>Title: App does not update the state of the 'mark all complete' checkbox
username_0: The 'mark all complete' checkbox should be cleared if the all the todo items are checked then the user un-checks an item. i.e. the UI state should remain consistent.
This affects the following:
- [ ] spine
- [x] angularjs-perf
- [x] kendo
See the following test failure:
$ mocha allTests.js -R list --framework=spine
․ TodoMVC - spine (1/1) No Todos should hide #main and #footer: 215ms
․ TodoMVC - spine (1/1) New Todo should allow me to add todo items: 553ms
․ TodoMVC - spine (1/1) New Todo should clear text input field when an item is added: 287ms
․ TodoMVC - spine (1/1) New Todo should trim text input: 321ms
․ TodoMVC - spine (1/1) New Todo should show #main and #footer when items added: 405ms
․ TodoMVC - spine (1/1) Mark all as completed should allow me to mark all items as completed: 933ms
․ TodoMVC - spine (1/1) Mark all as completed should allow me to clear the completion state of all items: 1025ms
1) TodoMVC - spine (1/1) Mark all as completed complete all checkbox should update state when items are completed / cleared
․ TodoMVC - spine (1/1) Item should allow me to mark items as complete: 868ms
․ TodoMVC - spine (1/1) Item should allow me to un-mark items as complete: 826ms
․ TodoMVC - spine (1/1) Item should allow me to edit an item: 1098ms
․ TodoMVC - spine (1/1) Item should show the remove button on hover: 10ms
․ TodoMVC - spine (1/1) Editing should hide other controls when editing: 715ms
․ TodoMVC - spine (1/1) Editing should save edits on enter: 1079ms
․ TodoMVC - spine (1/1) Editing should save edits on blur: 1168ms
․ TodoMVC - spine (1/1) Editing should trim entered text: 1131ms
․ TodoMVC - spine (1/1) Editing should remove the item if an empty text string was entered: 1013ms
2) TodoMVC - spine (1/1) Editing should cancel edits on escape
․ TodoMVC - spine (1/1) Counter should display the current number of todo items: 426ms
․ TodoMVC - spine (1/1) Clear completed button should display the number of completed items: 870ms
․ TodoMVC - spine (1/1) Clear completed button should remove completed items when clicked: 844ms
․ TodoMVC - spine (1/1) Clear completed button should be hidden when there are no items that are completed: 867ms
․ TodoMVC - spine (1/1) Persistence should persist its data: 2652ms
․ TodoMVC - spine (1/1) Routing should allow me to display active items: 861ms
․ TodoMVC - spine (1/1) Routing should allow me to display completed items: 815ms
․ TodoMVC - spine (1/1) Routing should allow me to display all items: 1134ms
․ TodoMVC - spine (1/1) Routing should highlight the currently applied filter: 961ms
25 passing (1m)
2 failing
<issue_comment>username_1: @username_0 This bug still affects angularjs-perf. http://todomvc.com/examples/angularjs-perf/
<issue_comment>username_0: Thanks @username_1 you're right, angularjs-perf does have some odd behaviour in this area.<issue_closed>
<issue_comment>username_2: @dmethvin A+ like a champ killed this one |
<issue_start><issue_comment>Title: `undefined method`, vagrant 1.8.6
username_0: Getting an `undefined method` error when using vagrant 1.8.6. I had a new developer join the team this week and she discovered it first. Then I upgraded from 1.8.5 to 1.8.6 and I hit the same error.
Any ideas where this is coming from?
Using CentOS7, Drupal 7, native shares...
this is my config.yml: https://gist.github.com/username_0/d22d6f9ebfd62f8df9f6263613d893a1
```
==> drupalvm: Mounting shared folders...
drupalvm: /vagrant => /Users/cmorris/projects/ul-drupalvm
drupalvm: /var/www/drupalvm => /Users/cmorris/Sites/ul
==> drupalvm: Forcing shutdown of VM...
==> drupalvm: Destroying VM and associated drives...
/opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/guests/linux/cap/mount_virtualbox_shared_folder.rb:64:in `mount_virtualbox_shared_folder': undefined method `+' for nil:NilClass (NoMethodError)
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/capability_host.rb:111:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/capability_host.rb:111:in `capability'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/guest.rb:43:in `capability'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/synced_folder.rb:51:in `block in enable'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/synced_folder.rb:35:in `each'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/synced_folder.rb:35:in `enable'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/synced_folders.rb:93:in `block in call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/synced_folders.rb:90:in `each'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/synced_folders.rb:90:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /Users/cmorris/.vagrant.d/gems/gems/vagrant-bindfs-0.4.9/lib/vagrant-bindfs/bind.rb:14:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/synced_folder_cleanup.rb:28:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/synced_folders/nfs/action_cleanup.rb:25:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/action/prepare_nfs_valid_ids.rb:12:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/handle_forwarded_port_collisions.rb:49:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/action/prepare_forwarded_port_collision_params.rb:30:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/env_set.rb:19:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/provision.rb:80:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /Users/cmorris/.vagrant.d/gems/gems/vagrant-bindfs-0.4.9/lib/vagrant-bindfs/bind.rb:14:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/action/clear_forwarded_ports.rb:15:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/action/set_name.rb:50:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/action/clean_machine_folder.rb:17:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/action/check_accessible.rb:18:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builder.rb:116:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `block in run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/util/busy.rb:19:in `busy'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/call.rb:53:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builder.rb:116:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `block in run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/util/busy.rb:19:in `busy'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/call.rb:53:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builder.rb:116:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `block in run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/util/busy.rb:19:in `busy'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/call.rb:53:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/box_check_outdated.rb:78:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/config_validate.rb:25:in `call'
[Truncated]
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builder.rb:116:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `block in run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/util/busy.rb:19:in `busy'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builtin/call.rb:53:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/plugins/providers/virtualbox/action/check_virtualbox.rb:17:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/warden.rb:34:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/builder.rb:116:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `block in run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/util/busy.rb:19:in `busy'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/action/runner.rb:66:in `run'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/machine.rb:225:in `action_raw'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/machine.rb:200:in `block in action'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/environment.rb:567:in `lock'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/machine.rb:186:in `call'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/machine.rb:186:in `action'
from /opt/vagrant/embedded/gems/gems/vagrant-1.8.6/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run'
```
<issue_comment>username_1: This sounds like it is an upstream issue with Vagrant (issue queue: https://github.com/mitchellh/vagrant/issues). I haven't updated to 1.8.6 yet, but will soon, and I'll see if I get the same error.
<issue_comment>username_2: Think it might be the blank "type:"?
1.8.6 has been OK so far here.
<issue_comment>username_1: @username_2 - That could be it; @username_0 how do you have your shares/synced directories defined in config.yml?
<issue_comment>username_0: I was just reading over the documentation and noticed this same potential issue and changed it to `""`, but still getting the same result. Tried a few different settings changes too, like using ubuntu, version of Drupal, etc. But still keep getting the error every time I use native. `nfs` is a no go for me, so I can't check that. But... I did just try the `rsync` method and that didn't crash out. So, maybe just a bug with native shares? Thanks.
<issue_comment>username_3: I ran into this problem yesterday after upgrading Vagrant & VirtualBox.
Could you please detail which ruby version you use, and how it was implemented on the system (even if it's the default setup). I use RVM and switching ruby versions fixed it for me.
<issue_comment>username_4: Same issue here, Windows 10, Vagrant 1.8.6, VirtualBox 5.0.28
My fileshare type is NFS
Tried updating Ruby from 2.2 to latest 2.3.1p112 (2016-04-26 revision 54768) [x64-mingw32
Downgraded vagrant back to 1.8.5 and its working
<issue_comment>username_5: I have the same issue. Any possible solution other than downgrading?
<issue_comment>username_1: Right now, use either `"nfs"`, `"rsync"`, or `"smb"`. I haven't had time to debug why the empty string is causing the error with Vagrant 1.8.6 :(
<issue_comment>username_6: nfs isn't available on non-enterprise Windows
rsync is one-way only and didn't work for me
smb requires login/password
life is hell :(
<issue_comment>username_1: I'm fairly certain we could figure out a syntax fix for this that's not too difficult, it just hasn't been as high priority as keeping everything else running (latest Vagrant/VirtualBox updates threw a bunch of curveballs, and I'm still catching up there). If someone knows a little Ruby, it's probably a little syntax issue or something like double vs single quotes, who knows.
<issue_comment>username_7: To use virtualbox native shares you can also set `type: "virtualbox"`.
<issue_comment>username_7: I'm pretty sure this is the cause https://github.com/mitchellh/vagrant/pull/7720/files#diff-97d643b35101562477f4b556a379415fR64.
We should revert https://github.com/username_1/drupal-vm/commit/5904e8e64af46a763b3585b96dae5792914a4414.
<issue_comment>username_7: TL;DR;
Vagrant 1.8.4 caused an issue when `mount_options` was an empty array. In 1.8.3 the option was passed to a shell command as an argument wrapped in quotes. As of 1.8.4 the quotes were removed thus causing an invalid shell syntax, ala `mount -o something-else` rather than `mount -o '' something-else`. We fixed this by using `nil` instead of `[]`.
As of 1.8.6 they changed the logic again and now `nil` is the problem.
```rb
mount_options = options.fetch(:mount_options, []) # evaluates to mount_options = nil
mount_options += ["uid=#{mount_uid}", "gid=#{mount_gid}"]
```
<issue_comment>username_7: Could you test if the PR above works?
<issue_comment>username_1: @username_5 / @username_6 / @username_4 / @username_3 / @username_0 - Can you test the above PR? It looks to me like it should fix the issue, just want to confirm before merging. Then I'll be happy to tag a new bugfix release for Drupal VM so people can feel more comfy upgrading Vagrant too :)
<issue_comment>username_6: @username_1 it works. Tested with empty values.
<issue_comment>username_5: That indeed fixed this problem, but then the installer dies on the firewall ("Could not find the requested service \'firewall'\:"). Ansible failed to complete successfully. @username_6 did you not have this issue?
<issue_comment>username_6: @username_5 no, machine just started without issues.
<issue_comment>username_1: @username_5 - That was related to https://github.com/username_1/ansible-role-firewall/issues/17 (separate issue). Thanks for confirming the shared folder fix, I'll merge it and tag a bugfix release!<issue_closed>
<issue_comment>username_0: Just want to chime in to share that changing `nil` to `[]` in the `Vagrantfile` worked for me too. Thanks.
Also, how did I remove the "question" label - I don't remember doing that. 🤔
<issue_comment>username_1: @username_0 - That seems to be a GitHub issue... I removed the label, but it credited the change to you (the issue author). Go figure!
<issue_comment>username_8: Just to write, this fixed it for me too, thanks! |
<issue_start><issue_comment>Title: Themability of font-related properties?
username_0: I don't quite understand why, but font-related properties (eg. ```font-family```, ```font-size```, ```line-height``` etc.) seem to be the only ones that are not themable once this partial is imported. There are more than likely plenty of scenarios (my own being one of them, as it just so happens :smile: ), wherein a user may prefer a different font-size or a different (although likely still monospaced) font-family.
Was there a reason for their exclusion?
<issue_comment>username_0: @alexgorbatchev Any thoughts? |
<issue_start><issue_comment>Title: Upgrade to Elm 0.18
username_0: Still working on verifying I've got all changes. I didn't use elm-format/elm-ugprade because it would change indentation on all files.
<issue_comment>username_0: I leave the versioning up to you.
<issue_comment>username_0: I also had to upgrade to the latest version of elm-test. I took the test runner code directly from elm-test. Here's the output.
```Success! Compiled 0 modules.
Successfully generated program.js
CreateTests currentOffsets: (300,360)
DurationTests currentOffsets: (300,360)
TEST RUN PASSED
Passed: 236
Failed: 0
Exit code: 0```
<issue_comment>username_1: This has been published.
@username_0 did you write the Runner.Log and Runner.String classes your self ?
Seems to be they make life simpler ;), shame they arn't built in.
<issue_comment>username_0: No, I borrowed them from elm test examples. |
<issue_start><issue_comment>Title: Add incremental sync support for patients.
username_0:
<issue_comment>username_1: No comments on the code. It looks good to me.
Two things:
* How can I test it?
* Are you going to write tests for it?
<issue_comment>username_0: Thanks Leonardo!
- Test it by spinning up a local server built from the equivalent branch and running the standard client tests against the local server
- I'm not going to write tests for it yet; for now, all the other tests depend on sync working so we should see widespread failure if it doesn't :) Longer term, I'd like to refactor the sync code and enough of the network stack to be able to unit-test sync instead of relying upon testing with the integration tests. But that's quite a bit of work, and probably beyond the scope of this sprint. |
<issue_start><issue_comment>Title: Error when building with XCode 7.3
username_0: When building with Xcode 7.3 I get the following error after I add the plugin to a project:
```
**/Plugins/cordova-plugin-ace/WebView.mm:48:11: error: cannot initialize an exception object of type
'<pseudo-object type>' with an rvalue of type 'NSString *'
throw error.description;
```
- cordova-ios 3.9.2 or cordova-ios 4.1.1
- cordova-plugin-ace 0.0.14
<issue_comment>username_1: Same, unable to run example due to this error.
<issue_comment>username_2: Thanks for your report and your patience! This is now fixed.<issue_closed> |
<issue_start><issue_comment>Title: [Don't Merge][introspection] Remove some intro checks on watch
username_0: For some reason introspection tests failed randomly on some selectors
and classes that according to headers are available on watchOS and
are actually usable I used some types on the intents framework watch sample
<issue_comment>username_0: @spouliot woohoo it seems jenkins approves 😄 will fix and merge once C9 is rebased, don't want to make more noise for you |
<issue_start><issue_comment>Title: book publication internal version
username_0: I may be interested to retrieve the current git version or an internal version of the book in the javascript book.
One workflow I'm thinking of is to permit inline notes.
In order to keep them, I consider using local storage.
By the way, as the book may evolve, the notes may be wrongly associated later to some content.
One way to resolve this would be to associate a book with one version number. (may be semver also ?!)
and produce some kind of migration tool to export the notes if needed.
<issue_comment>username_0: I just discover that the templating variables could serve as this feature.
You could | should close this issue. |
<issue_start><issue_comment>Title: Enable landscape mode in Flutter Gallery (iOS)
username_0: Already enabled on Android.
<issue_comment>username_0: @chinmaygarde
<issue_comment>username_0: According to @username_1 this is relatively recent (for particular definitions of 'relatively' and 'recent'). I didn't take a look at the commit history to see where it happened.
<issue_comment>username_0: Looks like this broke the iOS buildbot. Build:
https://build.chromium.org/p/client.flutter/builders/Mac/builds/2898
<issue_comment>username_1: The gallery has always "supported" landscape. It's just that many things are buggy in landscape mode. But the time has come where we can't really hide behind turning it off any more and we just need to deal with it. |
<issue_start><issue_comment>Title: Ionic 2
username_0: ```
_____
Please specify your environment
Plugin version:
- [ ] released version: _____
- [x] repository master
Toolchain:
- [x] Cordova cli
- [ ] Phonegap cli
- [ ] Phonegap cloud
- [x] Ionic
- [ ] Other: _____
Platforms affected:
- [x] Android
- [x] iOS/macOS
- [ ] LocalStorage fallback for browser and blackberry
- [ ] Windows and Windows Phone 8.1 and later
- [ ] Windows Phone 8 and earlier (deprecated)
What the scope of your problem:
- [x] General functionality (store/fetch/remove/clearAll)
- [ ] Suites
- [ ] Cloud synchronization and events
- [ ] Preferences pane generation and display
**Environment :**
Cordova CLI: 6.3.1
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.37
Ionic App Lib Version: 2.0.0-beta.20
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.4.7
Xcode version: Xcode 8.0 Build version 8A218a
<issue_comment>username_1: Actually, Ionic is based on cordova and if you have followed cordova rules (wait for `deviceready`, then use anything) everything should be fine.
Seems like I need to add explicit test especially for Ionic.
<issue_comment>username_0: Would be very helpful !
<issue_comment>username_0: Its working well with 0.99.2 with :
```
declare var plugins: any; //typescript declaration for Ionic 2
plugins.appPreferences.store(...)
```
But not with 0.99.3 |
<issue_start><issue_comment>Title: Merge master into post-dev15
username_0: This is an automatically generated pull request from master into post-dev15.
@dotnet/roslyn-infrastructure:
``` bash
git remote add username_0-roslyn "https://github.com/username_0/roslyn.git"
git fetch username_0-roslyn
git fetch upstream
git checkout merge-master-into-post-dev15-20170103-225301
git reset --hard upstream/post-dev15
git merge upstream/master
# Fix merge conflicts
git commit
git push username_0-roslyn merge-master-into-post-dev15-20170103-225301 --force
```
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.
<issue_comment>username_0: @dotnet-bot test vsi please |
<issue_start><issue_comment>Title: Failure on cmake test "TestEndianess"
username_0: I've built llvm (including clang) and have run the emscripten tutorials but this is my first attempt to use emscripten on an existing project.
My project uses CMake and tests for endianess using /usr/share/cmake-2.8/Modules/TestEndianess.c.in
Natively, cmake works when I'm using the gcc toolchain, but when I switch to
emconfigure.py cmake
then I get a failure on the endianess test. I provide some context leading up to it in case it is important.
Performing Test SEMUN_DEFINED
Performing Test SEMUN_DEFINED - Failed
Performing Test SEMOP_NO_REFERENCE
Performing Test SEMOP_NO_REFERENCE - Failed
Performing Test SEMCTL_NO_REFERENCE
Performing Test SEMCTL_NO_REFERENCE - Failed
Performing Test DEF_IOS_OK
Performing Test DEF_IOS_OK - Failed
Performing Test OSTREAM_FORM_OK
Performing Test OSTREAM_FORM_OK - Failed
Check if the system is big endian
Searching 16 bit integer
Check size of unsigned short
Check size of unsigned short - failed
Check size of unsigned int
Check size of unsigned int - failed
Check size of unsigned long
Check size of unsigned long - failed
CMake Error at /usr/share/cmake-2.8/Modules/TestBigEndian.cmake:44 (MESSAGE):
no suitable type found
Call Stack (most recent call first):
CMakeLists.txt:637 (TEST_BIG_ENDIAN)
Should I be looking for an issue with LLVM or an issue with emscripten? In either case, any suggestions will be appreciated!
<issue_comment>username_1: Just for people who might come here from googling solution for TestBigEndian issue.
For a newer version of emscripten, there is a cmake/Modules to fix the issue, all you have to do is adding folling line to your CMakeLists.txt:
```
# It will work when using docker image trzeci/emscripten:sdk-tag-1.38.16-64bit
set(CMAKE_MODULE_PATH "${CMAKE_MODULE_PATH};/emsdk_portable/sdk/cmake/Modules")
```
This will fix the issue without hard code anything. |
<issue_start><issue_comment>Title: Add number of processors as a make variable
username_0: It would be nice if Bazel could compute the number of cores it is configured to use and make that available as a make variable. I have a number of Makefile based genrules which make use of make's `-j`, but the optimal value of `-j` varies from host to host. In particular, a high value of `-j` can massively slow build times by unnecessarily paging to swap. Querying the number of processors in a cross platform way is rather involved, and/or requires Python as a dependency.
<issue_comment>username_1: To clarify, you have BUILD files with genrules that call `make -j whatever`?
<issue_comment>username_0: Exactly.
<issue_comment>username_1: On the one hand, we're trying to help people convert their builds to Bazel (which adding # cores would do). On the other hand, we probably don't want people to use number of cores in Bazel-executed build rules (that's something Bazel should figure out for the user), so I'm reluctant to add a feature for it (because it encourages bad rule construction for things that aren't shelling out to other build systems).
That said, we have a couple of proposals circulating about exposing environment variables to Bazel and adding ./configure-like functionality, so one or both of those things might help with this in the next couple of months.
<issue_comment>username_0: If it makes any difference, it would be just as useful (if not more useful) if Bazel could pass along its own notion of the number of processors available. It needn't correspond to the actual number of physical processors, such as when `--local_resources` has been specified.
<issue_comment>username_1: That is probably more do-able.
<issue_comment>username_2: @gregestren Is this something that you would consider implementing or close this issue?
<issue_comment>username_3: Just stumbled upon this bug by chance.
How does passing `-j N` to `make` from within a rule behave though? Bazel itself may already be using N jobs so telling `make` to use N as well will result in machine overload -- and I don't think there is a way you can control that unless your make-based build is in the critical path of every single target.
Worse: if your target happens to be built remotely, the number of local processors has no relation to the processors available remotely, so passing this information to the rule would be wrong.
If you are constructing a command line to run make, you can query the number of processors yourself and make whatever decisions you need there. Mind you, this would work fine in the remote execution case because the whole command line would run remotely and would discover the right number of remote processors.
So: I don't think Bazel should expose this as a built-in variable because it seems to address a corner case, and it seems to do so incorrectly.
The real answer here, I think, is: if we add first-class support for external build systems behind predefined rules, this would be handled transparently and you wouldn't have to worry about it.
<issue_comment>username_4: сс @irengrig |
<issue_start><issue_comment>Title: Convert two dashes to em dash
username_0: Because I care too much about punctuation... Would be really cool to have two adjacent dashes (--) convert to an em dash (—) in the composer. I don't know if other mail clients do it, but it's standard behavior in Slack, Medium, Microsoft Word, etc.
<issue_comment>username_1: On OS X, this is mostly handled at the OS layer with text substitution rules — implementation would need to mindful of interactions with system-wide rules (OS or e.g. TextExpander). |
<issue_start><issue_comment>Title: Stricter undef checks
username_0: Say you have code that looks like this:
```javascript
var foo = function() {
var b;
b = 3;
return 7;
};
foo();
```
In theory, this could warn because you're defining and allocating a value for `b`, but not ever using it; it's wasteful. (For example, the above is not a valid Go program; you get the message "`b` is declared and not used"). Basically, you need to use it on the right side of an equals sign, or in a function call.
This may not be a case for `jshint`, if it's too advanced of a hint check, or Javascript doesn't provide a reliable environment for dealing with these. If that's the case, are there other tools that can warn about issues like this?
<issue_comment>username_1: this doesn't seem totally unreasonable, since `unused` will catch this if the variable is initialized during declaration.
<issue_comment>username_0: Could also in theory flag
```javascript
var b;
b = 2;
b = 3;
```
since the first assignment is wasteful
<issue_comment>username_1: We could translate the source code into a static simulation of the programme, and warn people whenever licm or constant folding or dead code removal will make code pointless --- but vms already eliminate dead code and perform licm and constant folding anyways, and almost certainly do a better job of it than we could.
Let's keep it simple and deal with one thing at a time, which is in this case linting variables which are stored but never loaded
<issue_comment>username_2: related/duplicate: #2277 #2259 #2166 #1994<issue_closed>
<issue_comment>username_2: Duplicate of #1994 which has pr |
<issue_start><issue_comment>Title: Hosted Gallery - layout fix
username_0: ## What does this change?
Use some `min-height` media queries to properly align & size the title and standfirst text on the first slide across different breakpoints.
## What is the value of this and can you measure success?
The gallery images scale in terms of both height and width of the page in order to maintain their aspect ratio, so sizing text according to page width only doesn't make sense, and causes weird layout bugs.
## Does this affect other platforms - Amp, Apps, etc?
No
## Screenshots
All taken at 'wide' breakpoint (bug appears on letterbox-shaped screen), but using mobile/tablet sizing/margins where appropriate.
Before:
After:
Before:
After:
 |
<issue_start><issue_comment>Title: NullPointerException in Samsung Galaxy Note 4 - Android 5.0.1
username_0: Hi,
I have recurrent NullPointerExceptions with the following stack trace using Samsung Galaxy Note 4 with Android 5.0.1 using version 2.1.3 of android-beacon-library. There was not problem before the update to version 5.0.1.
java.lang.NullPointerException: Attempt to invoke interface method 'boolean android.bluetooth.IBluetooth.isOffloadedFilteringSupported()' on a null object reference
at android.bluetooth.BluetoothAdapter.isOffloadedFilteringSupported(BluetoothAdapter.java:1231)
at android.bluetooth.le.BluetoothLeScanner.isSettingsConfigAllowedForScan(BluetoothLeScanner.java:402)
at android.bluetooth.le.BluetoothLeScanner.startScan(BluetoothLeScanner.java:126)
at android.bluetooth.le.BluetoothLeScanner.startScan(BluetoothLeScanner.java:102)
at org.altbeacon.beacon.service.scanner.CycledLeScannerForLollipop.boolean deferScanIfNeeded()()
at org.altbeacon.beacon.service.scanner.CycledLeScanner.org.altbeacon.beacon.service.scanner.CycledLeScanner createScanner(android.content.Context,long,long,boolean,org.altbeacon.beacon.service.scanner.CycledLeScanCallback,com.useaurea.bluetooth.BluetoothCrashResolver)()
void setScanPeriods(long,long,boolean)
void start()
void scanLeDevice(java.lang.Boolean)
at org.altbeacon.beacon.service.scanner.CycledLeScanner.void finishScanCycle()()
at org.altbeacon.beacon.service.scanner.CycledLeScanner.void scheduleScanCycleStop()()
at org.altbeacon.beacon.service.scanner.CycledLeScanner$1.void run()()
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:5944)
at java.lang.reflect.Method.invoke(Method.java)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)
<issue_comment>username_1: This is related to an issue in #107 which was fixed in 2.1.2, but if you are experiencing this in a later release there must be a different root cause.
The null pointer happens because the BluetoothAdapter is null when trying to start scanning. The funny thing is that an earlier check found it to not be null.
Is there any circumstance around when this happens? Is it only when bluetooth is turned off? Or does it happen all the time?
<issue_comment>username_0: It should be something related to Samsung's implementation of Bluetooth related classes or in Android 5.0.1 source code. Since BluetoothAdapter#getDefaultAdapter() docs states "return the default local adapter, or null if Bluetooth is not supported on this hardware platform.", BluetoothAdapter should never be null for Samsung Galaxy Note 4.
One option would be to always call:
BluetoothManager bluetoothManager = (BluetoothManager)this.mContext.getApplicationContext().getSystemService("bluetooth");
this.mBluetoothAdapter = bluetoothManager.getAdapter();
And don't keep a mBluetoothAdapter field in Lollipop scanner classes. But it would be just a guess.
<issue_comment>username_0: I have a Service that implements BeaconConsumer and runs in background "forever". We only saw this bug in Samsung Galaxy Note 4, it's a beta tester's phone that we don't have access. Unfortunately we don't have a Samsung Galaxy Note 4 or any Samsung with Android 5.0.1 to test that also.
It happened three times in a 2 day interval only in Samsung Galaxy Note 4 .
<issue_comment>username_1: So it is an intermittent problem?
<issue_comment>username_0: Yes.
<issue_comment>username_1: @username_0, can you please test this snapshot release to see if it solves the problem on your device? I do not have a device that can reproduce this problem for testing.
https://github.com/AltBeacon/android-beacon-library/releases/tag/fix-gn4-npe-1
<issue_comment>username_0: Ok, I will give a feedback if the bug happens again. I was just wondering
that I keep my service running all the time regardless of bluetooth state.
Would it prevent the bug I check for bluetooth state and start/stop
BeaconManager?
Thanks!
--
Att, Marcelo Benites<issue_closed>
<issue_comment>username_1: Fix attempted per https://github.com/AltBeacon/android-beacon-library/pull/200
Since I cannot reproduce please reopen if this does not resolve the problem. |
<issue_start><issue_comment>Title: RequestLimitExceeded error when creating lambda functions inside VPC
username_0: This is a Bug Report
## Description
* What went wrong?
I have around 40 lambda functions in my serverless file. When I do `serverless deploy` without a VPC configuration, it deploys fine.
However, when I add a VPC configuration like this:
```
vpc:
securityGroupIds:
- ***
subnetIds:
- ***
```
I have a few of the functions create and then the CF deployment fails because of the following error:
```
Serverless Error ---------------------------------------
An error occurred while provisioning your stack: MyLambdaFunction
- Your request has been throttled by EC2, please make
sure you have enough API rate limit. EC2 Error Code:
RequestLimitExceeded. EC2 Error Message: Request limit
exceeded..
Get Support --------------------------------------------
Docs: docs.serverless.com
Bugs: github.com/serverless/serverless/issues
Your Environment Information -----------------------------
OS: darwin
Node Version: 7.6.0
Serverless Version: 1.8.0
```
After filing an AWS support request, this error appears because there is a hard limit on the create function. This can be solved in one of two ways:
- Split the serverless.yaml file into smaller pieces.
- Add the `DependsOn` parameter to each lambda function.
Personally I like the 2nd option because I won't need to modify my existing `serverless.yaml` file. However, I could not find anything in the Serverless documentation or the Github issues list that indicates there is an optional `DependsOn` property for lambda functions, so that I can delay the creation of a lambda function until another one has finished creating.
If this exists, can you let me know how it works? If it does not exist, is there is a package or a feature proposal for this?
Thanks so much!
<issue_comment>username_0: @username_1 What would be your recommendation for avoiding this error, for now?
<issue_comment>username_1: Hey @username_0 you could use the `resources` section to overwrite the generated CloudFormation code and extend the Lambda code: https://serverless.com/framework/docs/providers/aws/guide/resources#aws-cloudformation-resource-reference
Other than that you could ask AWS to increase your limits.
<issue_comment>username_0: @username_1 it worked! For other interested parties, this is what I did:
```
service: myservice
provider:
type: aws
...
functions:
myExampleFunction:
handler: ...
my-other-example-function:
handler: ...
resources:
Resources:
# notice how the string is always PascalCase, and the resource is appended with "LambdaFunction"
MyExampleFunctionLambdaFunction:
Type: AWS::Lambda::Function
DependsOn: MyOtherExampleFunctionLambdaFunction
```<issue_closed>
<issue_comment>username_1: Great to hear that @username_0 🎉
Thanks for sharing your config!
<issue_comment>username_2: Why was this closed? The "solution" above is at best a work-around.
<issue_comment>username_3: Setting my createNatGateway to 2 in the serverless.yaml's vpcConfig section (I'm using us-west-2 region, for which there's 4 availability zones (2a, 2b, 2c and 2d) as of this date) and adding in zones:
```
zones:
- us-west-2a
- us-west-2b
```
allowed me to deploy successfully. I am interested if anyone has used bwinant's plugin and could report back - might be interesting to see if there's much timing difference when setting it to 2, as that would cut the number significantly. Cheers -
<issue_comment>username_4: @username_3 Sorry to bring this up again, but this hit us hard. We have >100 functions. What exactly is the name of the limit that I should be requesting?
<issue_comment>username_5: It's been a while since you asked @username_4 - did you find out what the limit was called that you needed to increase?
<issue_comment>username_5: @hvaughan3 - thanks for letting me know. For the time being, I'm using the serverless-dependson-plugin which allows configuration of how many parallel batches can run. It's set to three for now and seems to be behaving.
<issue_comment>username_4: @username_5 Read the *Non-mutating actions* row in [API throttling limits](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/throttling.html#throttling-limits-rate-based), they don't even bother listing all of the actions there. I am imagining 100+ of those methods.
My team is subscribing to paid support plans, their response at least nailed down to some undocumented internal limits under the above calls, which is not meant to be raised in normal circumstances. Further responses from them are vague, I guess they are not supposed to tell how those internal limits works.
<issue_comment>username_5: @username_4 Thanks for getting back to me. Yeah, frustratingly opaque. We're getting around it with some chaining using dependsOn which slows things down but it's manageable right now. Thanks again |
<issue_start><issue_comment>Title: Add missing environments for new Shopware(5.2) Plugin System
username_0: Hi all,
to use this in the new shopware plugin system, i added some new paths to the ShopwareInstaller class.
Greetings,
Lukas
<issue_comment>username_1: Hi,
thanks for PR. Update the tests, please.
<issue_comment>username_0: Hi @username_1,
i have added the missing tests. I hope it is enough. |
<issue_start><issue_comment>Title: Fix broken hash link in Registry doc
username_0: While going through the Registry doc, I found a broken hash link which might be caused by a bug in `ex_doc`. Specifically, when a closing back tick is followed by a close parenthesis, the latter becomes part of the link. Instead of working around the problem, I decided to remove the parentheses altogether to avoid any ambiguity.
<issue_comment>username_1: this was supposed to be fixed in Earmark (the Markdown engine), but apparently the bug is back.
<issue_comment>username_2: Thank you @username_0, congratulations on becoming the 500th contributor :tada: |
<issue_start><issue_comment>Title: Test, formatting fixes for new JS challenges
username_0: <!-- freeCodeCamp Pull Request Template -->
<!-- IMPORTANT Please review https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/CONTRIBUTING.md for detailed contributing guidelines -->
<!-- Help with PRs can be found at https://gitter.im/FreeCodeCamp/Contributors -->
<!-- Make sure that your PR is not a duplicate -->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] Your pull request targets the `staging` branch of freeCodeCamp.
- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)
- [x] You have only one commit (if not, [squash](http://forum.freecodecamp.com/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).
- [x] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes.
#### Type of Change
<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->
- [x] Small bug fix (non-breaking change which fixes an issue)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask in the Help Contributors room linked above. We're here to help! -->
- [x] Tested changes locally.
- [x] Closes currently open issue (replace XXXX with an issue no):
Closes #12727
Closes #12728
#### Description
<!-- Describe your changes in detail -->
- General formatting fixes for last 4 challenges that were recently added to the Basic JavaScript section (`code`, `dfn`, and `blockquote` tags applied where needed, titles capitalized)
- Fixes the order of the challenges so the two `parseInt` ones are together, followed by the two `conditional operator` ones (probably why the diff looks odd)
- Fixes the isNaN test in `Use the parseInt Function` challenge, adds tests to check that `parseInt()` was used
<issue_comment>username_0: Thanks @Greenheart - I'll make these changes 👍
<issue_comment>username_0: Alright, my branch is updated. I deleted the right associative line because the links I saw (Wiki article and MDN on the ternary operator) were either dense/unclear or didn't explain it. Also, the new regex tests are pretty flexible, just in case someone decides to be a contrarian and write something like `return a !== b ? false : true;`... |
<issue_start><issue_comment>Title: Pull ThreadSleep into CoreRunnable
username_0: Update `ThreadSleep` to use the condition variable in `CoreRunnable`, rather than the state block in `BasicThread`. Also update the documentation on this method to reflect the method's actual behavior.
<issue_comment>username_1: Unit tests pass (i.e. the two tests that use ThreadSleep(), WaitRunsDownAllPackets and EmptyPoolIssuance) still pass when I run them 1000x.
Merging. |
<issue_start><issue_comment>Title: debian/changelog last entry contains version 1.6.5
username_0: I've cloned repo, switched to tag 1.6.8, built deb-package and was surprised to see 1.6.5 in package name :)
<issue_comment>username_1: Our build system uses `dch` to update version of package.
С наилучшими пожеланиями, Евгений.
<issue_comment>username_0: Ok, but how that correlates with outdated changelog-file in debian folder?<issue_closed>
<issue_comment>username_2: Changelog has been fixed.
I plan to upload new packages to the mainstream debian repository soon. |
<issue_start><issue_comment>Title: Stattype may be guessed to be 'key' incorrectly
username_0: Stattype guessing in guess.py first searches for a key, where a key is defined as the first column for which there are no None or NaN values and len(col) = len(unique values in col).
In tables that don't begin with a rowid column, the key identification method seems very likely to mis-classify a column with a bunch of unique floats as a key.
I think that could be improved by also checking if the values have non-zero decimal places (e.g. 3.23, -0.34), which would probably indicate they aren't keys even if they're all unique.
@username_1
<issue_comment>username_1: This might not be solved for
```%mml GUESS SCHEMA FOR foo```
https://probcomp-1.csail.mit.edu:9090/notebooks/casarsa_notebooks/krns_analysis_test_run.ipynb
<issue_comment>username_2: @username_1 this is a genuine bug, not an installation issue.
@username_0 There are two issues causing the bug -- one introduced by Fix #475, which is being masked by a bug in `guesser_wrapper`. Can you please look into this? The test case is in this notebook:
http://probcomp-1.csail.mit.edu:8888/notebooks/krns_fmri_analysis_BUG_REPRODUCE.ipynb
You can copy the `.csv` file into your own development environment and explore further.<issue_closed>
<issue_comment>username_0: Fixed in b643c1d0422eb027eb41baa45118a45b60c627bb
<issue_comment>username_2: It seems that, after b643c1d that `keyable_p([1, 2.13])` returns True, even though the existence of a float should ensure that the column is not keyable. Reopening for further exploration.
<issue_comment>username_2: Stattype guessing in guess.py first searches for a key, where a key is defined as the first column for which there are no None or NaN values and len(col) = len(unique values in col).
In tables that don't begin with a rowid column, the key identification method seems very likely to mis-classify a column with a bunch of unique floats as a key.
I think that could be improved by also checking if the values have non-zero decimal places (e.g. 3.23, -0.34), which would probably indicate they aren't keys even if they're all unique.
@username_1<issue_closed> |
<issue_start><issue_comment>Title: launch-config should allow me reference any command
username_0: I wanna write an extension that is a set of commands for asking for user input, like *input text*, *make selection* etc. Then I want to use commands from that extension in our launch.config - my ultimate goal is support `mocha -g "test name"` from within VS Code.
I have modified our [launch.json](https://github.com/Microsoft/vscode/blob/master/.vscode/launch.json#L13) so
```
"args": [
"--timeout",
"999999",
"-g",
"${command.inputs.text}"
]
```
and an extension that contributes a `inputs.text` command and that activates on that command
```
// extension.js
vscode.commands.registerCommand('inputs.text', function () { ... });
// package.json
"activationEvents": [
"onCommand:inputs.text"
]
```
This doesn't work and it requires me to also define a debugger which I believe is unnecessary complicated.
<issue_comment>username_1: I agree that this step of defining `variables` inside debuggers feels like an extra step and we could just allow to run an arbitrary command. Doing this debug adapters would not have to specify interactive variables and other extensions could use this feature more easily - Joh's use case.
@username_2 let us know what you think. I might be missing something here<issue_closed>
<issue_comment>username_2: @username_1 yes, making commands directly available as variables makes sense and we should support this (and we should continue to support the 'variables' contribution).
What I don't like is the resulting syntax. If the command ID follows the common practice to use '.' as separators then using the 'command.' prefix makes things a bit unwieldy:
```typescript
"program": "${command.extension.node-debug.pickProcess}"
```
Here the 'variables' contribution helped because it allowed to introduce a short (but scoped) alias:
```typescript
"program": "${command.pickProcess}"
```
The reasoning behind the intermediate 'variables' contribution point was twofold:
- we wanted to decouple a dynamic variable (e.g. 'PickProcess') from its implementation (today a command is defined in an extension; in the future maybe it will become a builtin process picker).
- we wanted to introduce a scope for a dynamic variable: the variable is only available in launch configurations of the debug type for which the variable is defined.
Today the first reason is no longer valid: since dynamic variables use the `${command.variable}` syntax, the implementation detail 'command based' is already apparent when using a variable. So replacing a command based implementation by something builtin, would require a major stretch...
<issue_comment>username_2: I wanna write an extension that is a set of commands for asking for user input, like *input text*, *make selection* etc. Then I want to use commands from that extension in our launch.config - my ultimate goal is support `mocha -g "test name"` from within VS Code.
I have modified our [launch.json](https://github.com/Microsoft/vscode/blob/master/.vscode/launch.json#L13) so
```
"args": [
"--timeout",
"999999",
"-g",
"${command.inputs.text}"
]
```
and an extension that contributes a `inputs.text` command and that activates on that command
```
// extension.js
vscode.commands.registerCommand('inputs.text', function () { ... });
// package.json
"activationEvents": [
"onCommand:inputs.text"
]
```
This doesn't work and it requires me to also define a debugger which I believe is unnecessary complicated.
<issue_comment>username_3: Related question: is it currently supported to use the command variable syntax in the 'args' or 'env' parameters of a launch configuration (at the top-level, not in the configurationAttributes)? I tried it yesterday and it didn't seem to work, the debug adapter got the argument but it was the command syntax string and not the resolved value.
This would be a huge benefit in my case as the alternative is to write a bunch of extra code in my TypeScript-based debug adapter bridge just to read the request that contains the properties defined in my launch config (since the command syntax seems to work there).
<issue_comment>username_2: @username_3 variable substitution should work everywhere. If it doesn't it is a bug.
/cc @username_1
<issue_comment>username_3: That's great news. Here's what I've done so you can verify whether I've made a mistake somewhere or if it's a bug:
Registering and using the command variable in `package.json`:
```
"debuggers": [
{
"type": "PowerShell",
"enableBreakpointsFor": {
"languageIds": [
"powershell"
]
},
"variables": {
"GetSessionPath": "PowerShell.GetSessionPath"
},
"program": "./out/debugAdapter.js",
"args": [
"${command.GetSessionPath}"
],
"runtime": "node",
"configurationAttributes": {
```
Registering the command:
```
vscode.commands.registerCommand('PowerShell.GetSessionPath', () => { return this.getDebugAdapterArgs() })
```
And here's what I see in the `process.argv` of my debug adapter:
```
C:\Program Files (x86)\Microsoft VS Code Insiders\Code - Insiders.exe,c:/dev/vscode-powershell/out/debugAdapter.js,${command.GetSessionPath}
```
<issue_comment>username_3: Also, I never see my command get invoked when I start my debugger. I've got a breakpoint set in my extension code where I register the command and it never gets hit.
Strangely, I don't see the command get invoked even when I use it in a configuration attribute:
```
"configurationAttributes": {
"launch": {
"required": [
"program"
],
"properties": {
"debugAdapterArgs": {
"type": "string",
"description": "Arguments that are sent by the extension to the debug adapter. Not a user setting.",
"default": "${command.GetSessionPath}"
},
```
<issue_comment>username_2: @username_3 are you expecting variable substitution to take place in the package.json? That won't work. You can use variables in the `configurationAttributes` contribution but their substitution is delayed until the user starts the launch config.
<issue_comment>username_2: @username_3 and make sure that the extension gets activated when the command is executed, so add all commands to the `activationEvents` section in your package.json:
```json
"activationEvents": [
"onCommand:extension.pickNodeProcess",
"onCommand:extension.node-debug.provideInitialConfigurations"
],
```
<issue_comment>username_2: @username_3 and make sure that all those package.json contributions are only registered if you run your **extension**. Just editing package.json and then running the debug adapter isn't enough. You'll have to run (or better debug) the extension and from the new VS Code window you can start the launch config.
<issue_comment>username_3: I'm expecting the variable substitution to happen for my debug adapter's `args` field when the user starts the PowerShell debugger. Does this mean that variable substitution doesn't happen outside of the `configurationAttributes` section for debugger contributions? I'm trying to avoid using configuration attributes for this because it will require me to read the content of messages coming from the debug client before I pass them on via TCP to my real debug adapter which runs in another process.
My extension is already activated at this point (but I am aware that I'll need the activation event in case the user somehow starts the debugger if it's not activated yet).
<issue_comment>username_3: Yep, I am debugging my extension using a new instance of VS Code with `--extensionDevelopmentPath` set.
<issue_comment>username_2: Variable substitution only takes place for all attribute values of a selected launch configuration when a new debug session is started.
I don't understand what you mean by "doesn't happen outside of the configurationAttributes section" since variable substitution does not even take place "inside" the configurationAttributes section.
Yes, you can use variables inside the "configurationAttributes" contribution but these variables are not interpreted when the initial launch configuration is created. There are just literally copied.
Substitution occurs when the launch config is started.
<issue_comment>username_3: Yes, I intend for this substitution to occur when the launch config starts, I'm not concerned with launch config creation time because I need the debug adapter's arguments to be populated using a command at the moment when the debugger gets launched.
Maybe it would help to say step-by-step what I expect to happen:
1. User creates a launch config or has an existing launch config for the PowerShell debugger
2. User starts the VS Code debugger with their PowerShell launch configuration
3. VS Code uses the debugger contribution in the PowerShell extension to determine which program it should launch and **resolves one of the adapter's command line arguments using an extension command**
4. VS Code launches the debug adapter process and passes the specified process arguments **including the one that was resolved at launch time using an extension command**
5. The PowerShell debug adapter starts up, reads the command line arguments and uses them to configure itself before the debug client starts sending messages
I apologize for the lack of clarity in my questions, thanks a lot for helping me with this!
<issue_comment>username_2: No variable substitution occurs in your step 3 because "the adapter's command line arguments" are not part of a launch config (and variable substitution only occurs for launch configs).
In your initial question I assumed that you were referring to the 'args' or 'env' parameters of a launch configuration (which are passed to the 'launch' request of the debug adapter). But actually you were asking about 'args' passed to the debug adapter itself (and 'env' is not even supported here).
We do not support variable substitution for arguments that are passed to the debug adapter (and we probably never will). But we are considering to open up the whole process of launching a debug adapter by moving it to the extension (optionally). With this you could write extension code that launches the debug adapter and can pass whatever arguments it needs.
<issue_comment>username_3: Thanks for the clarification! I would love it if you allowed extension code to launch the debug adapter process, that would enable a few things I've been hoping to accomplish. For now I'll just find another way to do what I need to do.
<issue_comment>username_2: @username_3 please see https://github.com/Microsoft/vscode/issues/13833<issue_closed>
<issue_comment>username_1: This is now supported, created https://github.com/Microsoft/vscode-docs/issues/689 to update the docs
<issue_comment>username_2: I've created https://github.com/Microsoft/vscode/issues/16064 with a proposal for better command variable syntax.
<issue_comment>username_2: @username_1 since #16064 did not made it into the November milestone, I suggest that we do not announce this feature in the November release.
<issue_comment>username_4: @username_2 I'm writing a extension to provide debug configurations.
as mentioned at docs `"initialConfigurations": "extension.eggjs.provideInitialConfigurations"`
my question is how to link a command to `configurationSnippets`?
had try `"configurationSnippets": ["${command.extension.eggjs.provideConfigurationSnippets}"]` and `"configurationSnippets": "extension.eggjs.provideConfigurationSnippets"` without luck.
<issue_comment>username_4: @username_2 any suggest? |
<issue_start><issue_comment>Title: Publish library at Packagist
username_0: Hello, @elevateweb
It would be really good to have this great library at Packagist (https://packagist.org/), so PHP developers will be able to install it via Composer dependency manager. Publishing is very simple (see https://packagist.org/) - it wouldn't take more than half an hour to do that.
Thanks, Yevhen. |
<issue_start><issue_comment>Title: [FR] Move selected apps from rasa to scoop
username_0: Per [deevus's comment](https://github.com/username_1/scoop/commit/c496fa2cdd6c47f87cc7b5bfe951573851a60a8b#commitcomment-21081646), here's a list of open source<sup><a href="#*">*</a></sup> CLI apps that I'm willing to PR from [username_0/scoops](https://github.com/username_0/scoops), in the main scoop bucket:
|Name|Version|Description|License|
|----|-------|-----------|-------|
|[cdrtools](https://sourceforge.net/projects/tumagcc/ "https://sourceforge.net/projects/tumagcc/")|[3.01](https://sourceforge.net/projects/tumagcc/ "https://sourceforge.net/projects/tumagcc/")|Burn and read CDs, DVDs, and Blu-ray discs|[CDDL-1.0](https://opensource.org/licenses/CDDL-1.0 "https://opensource.org/licenses/CDDL-1.0")/[GPL-2.0](https://opensource.org/licenses/GPL-2.0 "https://opensource.org/licenses/GPL-2.0")/[LGPL-2.1](https://opensource.org/licenses/LGPL-2.1 "https://opensource.org/licenses/LGPL-2.1")|
|[handbrake_cli](https://handbrake.fr/ "https://handbrake.fr/")|[1.0.3](https://handbrake.fr/downloads2.php "https://handbrake.fr/downloads2.php")|Convert videos with CLI program|[GPL-2.0](https://opensource.org/licenses/GPL-2.0 "https://opensource.org/licenses/GPL-2.0")|
|[infounzip](http://www.info-zip.org/ "http://www.info-zip.org/")|[6.00](http://www.info-zip.org/ "http://www.info-zip.org/")|Unzip compression utility|[Link](http://www.info-zip.org/pub/infozip/license.html "http://www.info-zip.org/pub/infozip/license.html")|
|[infozip](http://www.info-zip.org/ "http://www.info-zip.org/")|[3.0](http://www.info-zip.org/ "http://www.info-zip.org/")|Zip compression utilities|[Link](http://www.info-zip.org/pub/infozip/license.html "http://www.info-zip.org/pub/infozip/license.html")|
|[metastore](https://github.com/username_0/metastore "https://github.com/username_0/metastore")|[95d4e2d](https://github.com/username_0/metastore/releases/latest "https://github.com/username_0/metastore/releases/latest")|Store and restore metadata from a filesystem|[GPL-2.0](https://opensource.org/licenses/GPL-2.0 "https://opensource.org/licenses/GPL-2.0")|
|[nc](https://eternallybored.org/misc/netcat/ "https://eternallybored.org/misc/netcat/") (aka netcat)|[1.12](https://eternallybored.org/misc/netcat/ "https://eternallybored.org/misc/netcat/")|Read and write from/to network connections|[GPL-2.0](https://opensource.org/licenses/GPL-2.0 "https://opensource.org/licenses/GPL-2.0")|
|[openssl10x](http://slproweb.com/products/Win32OpenSSL.html "http://slproweb.com/products/Win32OpenSSL.html")|[1.0.2k](http://slproweb.com/products/Win32OpenSSL.html "http://slproweb.com/products/Win32OpenSSL.html")|TLS/SSL toolkit (1.0.x branch)|[Link](https://www.openssl.org/source/license.html "https://www.openssl.org/source/license.html")|
|[pciutils](https://eternallybored.org/misc/pciutils/ "https://eternallybored.org/misc/pciutils/")|[3.4.0](https://eternallybored.org/misc/pciutils/ "https://eternallybored.org/misc/pciutils/")|Inspect and manipulate configuration of PCI devices|[GPL-2.0](https://opensource.org/licenses/GPL-2.0 "https://opensource.org/licenses/GPL-2.0")|
|[poppler](http://blog.alivate.com.au/poppler-windows/ "http://blog.alivate.com.au/poppler-windows/")|[0.51](http://blog.alivate.com.au/poppler-windows/ "http://blog.alivate.com.au/poppler-windows/")|PDF rendering library|[GPL-3.0](https://opensource.org/licenses/GPL-3.0 "https://opensource.org/licenses/GPL-3.0")|
|[smartmontools](https://www.smartmontools.org/ "https://www.smartmontools.org/")|[6.5-1](https://sourceforge.net/projects/smartmontools/files/smartmontools/ "https://sourceforge.net/projects/smartmontools/files/smartmontools/")|Read SMART data from disks|[GPL-2.0](https://opensource.org/licenses/GPL-2.0 "https://opensource.org/licenses/GPL-2.0")|
|[sslscan](https://github.com/rbsec/sslscan "https://github.com/rbsec/sslscan")|[1.11.0](https://github.com/rbsec/sslscan "https://github.com/rbsec/sslscan")|Discover supported cipher suites for SSL/TLS enabled services|[GPL-3.0](https://opensource.org/licenses/GPL-3.0 "https://opensource.org/licenses/GPL-3.0")|
|[tesseract](https://github.com/UB-Mannheim/tesseract/wiki "https://github.com/UB-Mannheim/tesseract/wiki")|[3.05.00](https://github.com/UB-Mannheim/tesseract/wiki "https://github.com/UB-Mannheim/tesseract/wiki")|OCR engine developed by Google|[Apache-2.0](https://opensource.org/licenses/Apache-2.0 "https://opensource.org/licenses/Apache-2.0")|
|[tesseract_experimental](https://github.com/UB-Mannheim/tesseract/wiki "https://github.com/UB-Mannheim/tesseract/wiki")|[4.00.00](https://github.com/UB-Mannheim/tesseract/wiki "https://github.com/UB-Mannheim/tesseract/wiki")|OCR engine developed by Google|[Apache-2.0](https://opensource.org/licenses/Apache-2.0 "https://opensource.org/licenses/Apache-2.0")|
|[tidy](http://www.html-tidy.org/ "http://www.html-tidy.org/")|[5.2.0](http://www.html-tidy.org/ "http://www.html-tidy.org/")|Tidy HTML and XML files|[Link](http://www.html-tidy.org/documentation/#license "http://www.html-tidy.org/documentation/#license")|
|[unrar](http://www.rarlab.com/ "http://www.rarlab.com/")|[5.40](http://www.rarlab.com/download.htm "http://www.rarlab.com/download.htm")|Uncompress RAR files|[Freeware](https://en.wikipedia.org/wiki/Freeware "https://en.wikipedia.org/wiki/Freeware")|
|[wkhtmltopdf](http://wkhtmltopdf.org/ "http://wkhtmltopdf.org/")|[0.12.4](http://wkhtmltopdf.org/downloads.html "http://wkhtmltopdf.org/downloads.html")|Render HTML into PDF|[LGPL-3.0](https://opensource.org/licenses/LGPL-3.0 "https://opensource.org/licenses/LGPL-3.0")|
|[x264-10bit](https://www.videolan.org/developers/x264.html "https://www.videolan.org/developers/x264.html")|[17.01.30](https://www.videolan.org/developers/x264.html "https://www.videolan.org/developers/x264.html")|H.264/MPEG-4 AVC video encoder (10 bit)|[GPL-2.0](https://opensource.org/licenses/GPL-2.0 "https://opensource.org/licenses/GPL-2.0")|
|[x264-8bit](https://www.videolan.org/developers/x264.html "https://www.videolan.org/developers/x264.html")|[17.01.30](https://www.videolan.org/developers/x264.html "https://www.videolan.org/developers/x264.html")|H.264/MPEG-4 AVC video encoder (8 bit)|[GPL-2.0](https://opensource.org/licenses/GPL-2.0 "https://opensource.org/licenses/GPL-2.0")|
|[xmlstarlet](http://xmlstar.sourceforge.net/ "http://xmlstar.sourceforge.net/")|[1.6.1](https://sourceforge.net/projects/xmlstar/files/ "https://sourceforge.net/projects/xmlstar/files/")|Transform, query, validate, and edit XML files|[MIT](https://opensource.org/licenses/MIT "https://opensource.org/licenses/MIT")|
I would suggest we rename infozip to zip, and infounzip to unzip.
Also, I think renaming x264-8bit to simply x264 makes sense.
Thoughts? Did I miss anything else that should be included?
<a name="*"/><sup>*</sup> `unrar` provides its source code, but is on licensed by an OSI approved license.
<issue_comment>username_1: That would be great if you can add these!
Using the longer names (infozip, infounzip, netcat etc) would make it clearer which programs these are, and they will still be searchable under the shorter names of the executables they provide (zip, unzip, nc etc).
Would openssl10x would belong in the [versions bucket](https://github.com/scoopinstaller/versions/) as openssl10?
<issue_comment>username_0: I would prefer infozip/unzip replace the current zip/unzip as it's the same software, but directly from the source, without any msys.dll dependencies. Also, infozip has both 32- and 64-bit versions, which zip doesn't.
Yes, nc should be renamed netcat.
Yes, openssl10x should live in versions.
PR coming soon....
<issue_comment>username_1: Ah okay, I assumed the Mingw zip/unzip were different. Sounds good.<issue_closed> |
<issue_start><issue_comment>Title: Move macpaw-gemini into cask-versions (1.5.17,1461238766)
username_0: - [x] Checked there aren’t open [pull requests](https://github.com/caskroom/homebrew-versions/pulls) for the same cask.
- [x] Checked there aren’t closed [issues](https://github.com/caskroom/homebrew-versions/issues) where that cask was already refused.
- [x] Checked the cask follows the requirements of [acceptable casks](https://github.com/caskroom/homebrew-versions#acceptable-casks).
- [x] When naming the cask, followed the [token reference](https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/token_reference.md).
- [x] Commit message includes cask’s name.
- [x] `brew cask audit --download {{cask_file}}` is error-free.
- [x] `brew cask style --fix {{cask_file}}` left no offenses.
- [x] `brew cask install {{cask_file}}` worked successfully.
- [x] `brew cask uninstall {{cask_file}}` worked successfully.
<issue_comment>username_1: This should be called `gemini-classic` now
Homepage is http://macpaw.com/gemini-classic
<issue_comment>username_0: OK - I've renamed it - and updated the home page, but I left the url/appcast stanzas the same, because that is where they actually are downloaded from. https://dl.devmate.com/com.macpaw.site.GeminiClassic/GeminiClassic.dmg is just a shortcut to whatever the "latest" version is. |
<issue_start><issue_comment>Title: Exclude folders
username_0: Is ther a way to exclude folders from the tags generation on a project?
<issue_comment>username_1: You can add a `gtags.conf` file in the project root and add the exclude folders in `common::skip=`.
Refer to https://github.com/namhyung/global/blob/master/gtags.conf |
<issue_start><issue_comment>Title: View Statistics page DKs
username_0: Error Message:
```
--- !ruby/exception:ActiveRecord::RecordNotFound
message: Couldn't find User with 'id'=XXX
```
Stack Trace:
```
/opt/autolab3/build/autolab-src/app/controllers/assessment/grading.rb:589:in `find_user'
/opt/autolab3/build/autolab-src/app/controllers/assessment/grading.rb:592:in `map'
/opt/autolab3/build/autolab-src/app/controllers/assessment/grading.rb:592:in `stats_for_grader'
/opt/autolab3/build/autolab-src/app/controllers/assessment/grading.rb:346:in `statistics'
```<issue_closed> |
<issue_start><issue_comment>Title: Markdown h2 scope is messed up
username_0: - VSCode Version: Code - Insiders 1.9.0-insider (3af0e9d6b79145011a7be3970c1d4b83d69b0443, 2017-01-27T10:36:54.755Z)
- OS Version: Linux x64 4.8.0-34-generic
- Extensions:
|Extension|Author|Version|
|---|---|---|
|EditorConfig|EditorConfig|0.3.4|
|lorem-ipsum|username_0|1.0.0|
|theme-glacier|username_0|0.0.10|
|theme-material-neutral|bernardodsanderson|0.9.0|
|vscode-svgviewer|cssho|1.3.0|
|python|donjayamanne|0.5.6|
|tslint|eg2|0.8.1|
|git-project-manager|felipecaputo|1.0.1|
|vsc-travis-ci-status|felixrieseberg|1.0.5|
|md-navigate|jrieken|0.0.1|
|vscode-scss|mrmlnc|0.6.0|
|csharp|ms-vscode|1.6.2|
|seti-icons|qinjia|0.1.3|
|java|redhat|0.0.9|
|annotator|ryu1kn|0.10.1|
---
Might apply to other scopes too:
I don't think it's meant to be like this :smile:<issue_closed> |
<issue_start><issue_comment>Title: Doesn't work with Ember.js
username_0: Although this may not be a concern for you library, I was hoping for some insight into the problem. Basically, Ember.js takes control of it's view objects in a way that prevents bootstrap-select from working.
See my question on stackoverflow: http://stackoverflow.com/questions/16566700/integrating-bootstrap-select-to-work-with-ember
And JSFiddle: http://jsfiddle.net/TheWorkerAnt/8d2Me/1/
Cheers
<issue_comment>username_1: Guys, have you look at [ember-cli-select-picker](https://www.npmjs.com/package/ember-cli-select-picker)? It might be what you are looking for.
<issue_comment>username_1: I think integration with ember should not be a direct dependency of bootstrap-select, rather a separate project.<issue_closed>
<issue_comment>username_2: I never familiarized myself with Ember, but it seems like, at least with version 1.13.13, bootstrap-select is working. https://plnkr.co/edit/YSOoGrRcffaLqSFy |
<issue_start><issue_comment>Title: [FIXED JENKINS-17290] Corrected sort order of tables
username_0: It seems that the sort is for sorting ascending order, thus a "desecnding" order should be sorter.reverse()
<issue_comment>username_1: Could you merge with upstream `master` please, to trigger a new PR build? There was some problem with the last build but it has since been deleted so I cannot tell if it is significant or not.
<issue_comment>username_2: better rebase to get single commit :)
<issue_comment>username_3: Closing this PR (merged to the core in #1708) |
<issue_start><issue_comment>Title: simple substep implemenation
username_0: Greetings impress.js overlords:
I have made an unobtrusive and clean attempt at providing the basics of a substep feature.
My implementation follows the syntax and behavior modeled by regular steps:
- denote a substep by adding the css class 'substep' to elements in a step
- init will prepare the substeps with the additional css class 'future'
- next/prev will check within the current step for potential substeps
- navigation through substeps will set 'present', 'active', and 'past' - just like steps
- the only variation is substeps remain 'active' when past
- backward navigation removes 'past/active', restores 'future' as needed
- I've included substep events, following a similar model as regular steps
Because the only presentation-side change is CSS classes, there would be no effect on existing presentations. A new presentation would have to implement substep specific css to utilize the feature. This is outlined in the comments of the example html and css.
I thought it was best to create a separate example, rather than tinker with the existing index.html, as it seems like someone who wants substeps will find the html and figure it out from there.
Substeps are not included as a separate API feature. I felt this was the right thing because it didn't seem necessary to directly navigate to a substep. I also didn't think deep linking a substep made sense, and the sytax for that would have gotten weird, anyway. It did make sense to hook into next/prev. If you're adding substeps, you probably wouldn't want prev/next to skip them, even if you're moving via the API.
I felt an expected default behavior was to have substeps remain active, but that's easily changed. This could also be easily toggled with a 'data-' property.
The TL;DR notes on my commit are:
- a couple of helper functions for finding and handling substeps
- a small if/else check in next/prev to decide if a substep is available
- a separate example html page with it's own CSS.
I know substeps are 'powerpointish', and thus subject to controversy. They also may not meet the impress.js philosophy. My coding style might not be exactly in-line with the main repo. If the philosophical issue can be overcome, I'm happy to revise my code as needed to be acceptable. Just let me know.
Thanks for considering my contribution!
-- Aaron (aka tehfoo)
<issue_comment>username_1: Hi @username_0 , in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.
To give a little bit of context, recently [a decision was made in the project](https://github.com/impress/impress.js/issues/435#issuecomment-177602861) to make the development more active and the first task is to clear up older PRs like this one to see if [the OP](http://netforbeginners.about.com/od/internetlanguage/f/What-Is-OP.htm) is still interested in keep it going.
By the way, this one seems duplicate of #214 and #264.
<issue_comment>username_2: This looks like pretty much the same thing as #264, just with slightly different naming choices. I think it's a good approach in general, and I don't care which one is merged.
<issue_comment>username_1: Closing due to the lack of feedback from the OP. If you want to work in the PR again, feel free to comment here to open up the discussion again.
Also, this PR was opened in the dev branch, as from the CONTRIBUTING.md file, it should be opened against the [master branch instead](https://github.com/impress/impress.js/blob/d13428ec226bcb5f6cb918b854507fde1856d042/CONTRIBUTING.md#pull-requests). |
<issue_start><issue_comment>Title: Animation on ArcProgress
username_0: Please help me, how can i Animate ArcProgress?? i'll appreciate if you can explain with detailed discription
<issue_comment>username_1: see the example module, just use setProgress<issue_closed>
<issue_comment>username_0: Try out your suggestion but its not working, maybe you don't have a full understanding of what i'm saying... when user get to the activity, i want the ArcProgress animate from 0% to whatever percentage assign in the code. that's just the simple behavior i want to implement, is this possible? if yes... how>?
<issue_comment>username_1: you can just start a timer or thread to update progress value, this lib does not provide animation feature. |
<issue_start><issue_comment>Title: Replace sleep with wait_still_screen
username_0: sleep occasionally not working on following test:
https://openqa.suse.de/tests/412689/modules/consoletest_finish/steps/5
replace sleep as wait_still_screen.
sleep 30 at line 52 not replaced which i don't understand why it needs 30s.
<issue_comment>username_1: can you show a local verification test run?
<issue_comment>username_0: no ppc64 worker locally, i will verify it on x86 worker
<issue_comment>username_1: sure, it's ok if you just show me that it still works as before at least ;-)
<issue_comment>username_0: verified with following results:
http://147.2.207.208/tests/1294/modules/consoletest_finish/steps/6
http://147.2.207.208/tests/1296/modules/consoletest_finish/steps/6
please ignore other failed steps with slow IO and unstable network:) |
<issue_start><issue_comment>Title: World Age
username_0: On version:
```julia
julia> versioninfo()
Julia Version 0.6.0-pre.alpha.220
Commit 89609cf* (2017-03-22 20:10 UTC)
Platform Info:
OS: macOS (x86_64-apple-darwin16.4.0)
CPU: Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
WORD_SIZE: 64
BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)
LAPACK: libopenblas64_
LIBM: libopenlibm
LLVM: libLLVM-3.9.1 (ORCJIT, haswell)
```
with master Interact and IJulia, I get a world age issue in IJulia:
```julia
using Interact
x = collect(linspace(-1,1,101))
f = sin.(10exp.(x));
@manipulate for i = 1:10
i
end
5
KERNEL EXCEPTION
MethodError: no method matching (::##1#4)(::IJulia.Msg)
The applicable method may be too new: running in world age 21603, while current world is 21678.
Closest candidates are:
#1(::Any) at /Users/Mikael/.julia/v0.6/Interact/src/IJulia/setup.jl:56 (method too new to be called from this world context.)
Stacktrace:
[1] comm_msg(::ZMQ.Socket, ::IJulia.Msg) at /Users/Mikael/.julia/v0.6/IJulia/src/comm_manager.jl:135
[2] eventloop(::ZMQ.Socket) at /Users/Mikael/.julia/v0.6/IJulia/src/eventloop.jl:8
[3] (::IJulia.##9#12)() at ./task.jl:335
KERNEL EXCEPTION
MethodError: no method matching (::##1#4)(::IJulia.Msg)
The applicable method may be too new: running in world age 21603, while current world is 21678.
Closest candidates are:
#1(::Any) at /Users/Mikael/.julia/v0.6/Interact/src/IJulia/setup.jl:56 (method too new to be called from this world context.)
Stacktrace:
[1] comm_msg(::ZMQ.Socket, ::IJulia.Msg) at /Users/Mikael/.julia/v0.6/IJulia/src/comm_manager.jl:135
[2] eventloop(::ZMQ.Socket) at /Users/Mikael/.julia/v0.6/IJulia/src/eventloop.jl:8
[3] (::IJulia.##9#12)() at ./task.jl:335
KERNEL EXCEPTION
MethodError: no method matching (::##1#4)(::IJulia.Msg)
The applicable method may be too new: running in world age 21603, while current world is 21678.
Closest candidates are:
#1(::Any) at /Users/Mikael/.julia/v0.6/Interact/src/IJulia/setup.jl:56 (method too new to be called from this world context.)
Stacktrace:
[1] comm_msg(::ZMQ.Socket, ::IJulia.Msg) at /Users/Mikael/.julia/v0.6/IJulia/src/comm_manager.jl:135
[2] eventloop(::ZMQ.Socket) at /Users/Mikael/.julia/v0.6/IJulia/src/eventloop.jl:8
[3] (::IJulia.##9#12)() at ./task.jl:335
```
This is too cryptic for me to figure out; I'm not even sure if it's an Interact or IJulia issue.
<issue_comment>username_1: Hi, yeah a fix for this is coming soon, we're waiting on something in Base (more info here https://github.com/JuliaGizmos/Interact.jl/pull/158#issuecomment-281254446 if you're curious)
In the meantime I think you should be able to workaround this with the following changes:
Change [this line in IJulia](https://github.com/JuliaLang/IJulia.jl/blob/master/src/eventloop.jl#L8) to `eval(Expr(:call, handlers[msg.header["msg_type"]], socket, msg))`, and [this line in Reactive](https://github.com/JuliaGizmos/Reactive.jl/blob/master/src/core.jl#L162) to `isrequired(a) && eval(Expr(:call, a.f, a.recipient.value, timestep))`
Let me know how it goes.
<issue_comment>username_1: Actually looking at the error you might also have to change [this line](https://github.com/JuliaLang/IJulia.jl/blob/master/src/comm_manager.jl#L135) to
```
eval(Expr(:call, comm.on_msg, msg))
```
<issue_comment>username_0: Thanks, the fix works! I only use Interact with plotting for demos, and it appears to have gotten a lot slower since July (on 0.4 then, 0.6 now). Any reason you can think of?
<issue_comment>username_1: Doing what exactly? moving sliders to update plots? Which plotting lib?
I've noticed the throttle on the number of updates for each move of the slider is working "better" as in the plot updates fewer times when you move the slider, but sometimes this makes things less smooth
<issue_comment>username_1: Glad it works btw :)
<issue_comment>username_2: Probably fixed in https://github.com/JuliaLang/julia/pull/20820 (worth testing).
<issue_comment>username_2: Or perhaps not. See https://github.com/JuliaLang/julia/issues/21141.
<issue_comment>username_3: Yeah, still getting world age errors first time after precompilation.. but they seem to be gone after a restart... Still not tested very well from my side, though
<issue_comment>username_4: Any news on this? I just ran into this with Julia v0.6.0:
```
MethodError: no method matching (::##13#14{Interact.Options{:SelectionSlider,Float64}})(::IJulia.Msg)
The applicable method may be too new: running in world age [...]
```
<issue_comment>username_4: Restart didn't help, in my case.
<issue_comment>username_1: You might need to update IJulia
<issue_comment>username_1: Oh I think you need to `Pkg.checkout("IJulia")`, let me know how that goes. Prob need to get IJulia to tag a new release.
<issue_comment>username_1: @stevengj if you get a chance to tag an IJulia release that would be great! Interact doesn't work on julia 0.6 without the `invokelatest` changes.
<issue_comment>username_5: I've tagged it. @username_1 @username_2 many thanks to you fine folks for taking care of this <3
<issue_comment>username_6: Can confirm that Interact works on the release of 0.6 with IJulia master (tag waiting to be merged:
https://github.com/JuliaLang/METADATA.jl/pull/9891). Thanks to all!
<issue_comment>username_1: Cheers, have fun at juliacon everyone!
<issue_comment>username_4: Works for me too now - thanks a lot, @username_1 and @username_5!<issue_closed> |
<issue_start><issue_comment>Title: Remove redundant code related to SpecialistDocumentEdition#extra_fields
username_0: I came across this while trying to work out whether the `SpecialistDocumentEdition#extra_fields` field was being used. Although this PR is not as complete as I would like, I thought it was worth capturing my investigations so far. Feel free to close this PR if you think it needs to be more complete before it gets merged.
### Remove redundant DocumentMetadataDecorator
As far as I can see all this class' sub-classes were removed in the giant ["Remove specialist document models" commit][1]. I can't see any usage of this class or any of its methods and all the tests still pass.
### Remove usages of SpecialistDocumentEdition#extra_fields
It looks as if the means to edit this field via the UI was removed in the giant ["Remove specialist document models" commit][1]. As far as I can tell this field was only ever needed for documents which are now published via the Specialist Publisher app. I believe we could also remove the field itself. However, this is complicated by:
a) There are some instances of `SpecialistDocumentEdition` in the local data store which have the `extra_fields` attribute set. At first glance it looks as if these might all be orphans and in any case relate to content items which are now published via the Specialist Publisher app.
b) There are some existing migrations which rely on this field.
I have not removed the field nor addressed those issues in this pull request.
[1]: https://github.com/alphagov/manuals-publisher/commit/3162f0e72fd53bfd1cf87f5661bb198ff785940e
<issue_comment>username_1: Needs a rebase but then we can merge. |
<issue_start><issue_comment>Title: Update gulp-imagemin to 3.0.2
username_0: ## Changes
- Update gulp-imagemin to 3.0.2.
- Re-generate shrinkwrap.
## Testing
- `rm -rf ./node_modules/ && npm install && gulp build` should pass.
## Review
- @username_1
- @username_2
- @virginiacc
## Notes
- 3.x includes compressor settings that we're not currently using, though I'm unsure if we should be --> https://github.com/sindresorhus/gulp-imagemin/releases/tag/v3.0.0
<issue_comment>username_1: 👍
<issue_comment>username_2: 👍 |
<issue_start><issue_comment>Title: Add support for CSV in personality insights
username_0: We need to add support to get a profile as csv
Probably something like:
```js
service.profile({csv: true, text: ''}, callback);
service.profile({csv: true, contentItems: [...]}).pipe(fs.createWriteStream('./profile.csv'));
```<issue_closed>
<issue_comment>username_1: Done w/ tests and an example. I also cleaned up the integration tests a bit and then published it as `v1.0.0-beta.2` |
<issue_start><issue_comment>Title: Latest jitsi screen sharing not working
username_0: I'm Using latest jitisi maven repo and latest react native version when i click screenshare app request permission if i give yes then my camera will go off automatically (that works expected ) but my mobile screen not get shared there is anything that i need to from my side? @username_1 please help me regard this
<issue_comment>username_1: Can you reproduce it with the Jitsi Meet app?
<issue_comment>username_0: https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-android-sdk
followed the steps in hand book and use example code to run in same page
<issue_comment>username_0: @username_1 please check this
<issue_comment>username_0: @username_1 ples check this
<issue_comment>username_0: any Updates @username_1
<issue_comment>username_0: Sorry don't mind, im on clue less
I'm really need you help 😢 |
<issue_start><issue_comment>Title: Editable with AJAX
username_0: HI !
I have a problem. I need to load editable-widget, using AJAX.
```
//controller
public function actionItem(){
return $this->renderAjax('_item');
}
```
```
// views/main.php
<div id = "cloneDiv">
<?=Yii::$app->controller->renderPartial('_item')?>
</div>
<input type="button" value="Click" onclick="a()">
<script>
function a(){
$.post('item', function(data){
$("#cloneDiv").html(data);
});
}
</script>
```
```
// views/_item.php
<?
$widgetParams = [
'type'=>'primary',
'size'=>'md',
'editableValueOptions'=>['class'=>'text-success']
];
echo \kartik\editable\Editable::widget(
array_merge($widgetParams, [
'id'=>'asdf',
'name' => 'asd',
'inputType'=>\kartik\editable\Editable::INPUT_TEXT,
])
);
```
When I click to the button, editable-widget loads to '#cloneDiv', but widget doesn't work..
I tried to use renderAjax, renderPartial in my Action - nothing results.
<issue_comment>username_1: I have the same problem. Any solutions?
<issue_comment>username_0: This problem is solved by PJAX :) You can see the solution in the internet or (if you don't want use pjax) you can see the file 'editable-pjax.js', which is contained to the plugin
<issue_comment>username_1: Can you show your pjax code? I load modal with AJAX, in this modal i want to use editable. But it don`t work of course. I try to manual call $('#selector').editable(), but it not work to.
thank you for reply. Now will see 'editable-pjax.js'
<issue_comment>username_0: Somethink like that (it is my example):
```
//index.php
\yii\bootstrap\Modal::begin([
'id'=>'objectModal',
'header' => "<h2>".$modalHeader."</h2>",
]);
?>
<div class="object-form">
<div id="formContent">
<?
yii\widgets\Pjax::begin(['id' => 'pjax-container', 'enablePushState' => false]);?>
<?=$this->render('_view', ['model'=>$model, 'form'=>$form]);
yii\widgets\Pjax::end();
?>
</div>
</div>
<?php
\yii\bootstrap\Modal::end();
<?= \yii\helpers\Html::button(
'create',
['value' => \yii\helpers\Url::to(['create']),
'id' => 'modalButton'
]) ?>
<script>
$('#modalButton').click(function (){
$('#objectModal').modal('show');
$.pjax.reload('#pjax-container');
});
</script>
```
```
//_view.php
<?
$widgetParams = [
'model'=>$model,
'type'=>'primary',
'size'=>'md',
'editableValueOptions'=>['class'=>'text-success']
];
echo \kartik\editable\Editable::widget(
array_merge($widgetParams, [
'attribute' => 'name',
'inputType'=>\kartik\editable\Editable::INPUT_TEXT,
'pjaxContainerId'=>'pjax-container',
])
);
?>
```
But it will not work, if you don't initial editable-widget before.
```
index.php
<?php
echo \kartik\editable\Editable::widget(
array_merge($widgetParams, [
'name' => 'hidden',
'inputType'=>\kartik\editable\Editable::INPUT_TEXT,
'containerOptions'=>['style'=>'display:none'],
'pjaxContainerId'=>'none'
])
);
// ...............
?>
```
<issue_comment>username_1: thanks. This will help me<issue_closed> |
<issue_start><issue_comment>Title: Update StructureMap to 3.1.5.154
username_0: Various bugs in StructureMap have been fixed.
From the release notes:
"Fixes for open generics convention resolution, child containers and policies,
naming conflicts between setters and ctor arguments"
Link: https://github.com/structuremap/structuremap/issues?q=is%3Aissue+milestone%3A3.1.5+is%3Aclosed
Took extra care to include the project files so that a commit like 05d8c2c74f4d6e0f24405e83e17b1afff7c18dfd is not needed.
<issue_comment>username_1: Thanks :ok_hand: |
<issue_start><issue_comment>Title: Audio only comes out of right speaker.
username_0: This may be related to issue #8, but if you use headphones you can tell audio only works on one ear.
<issue_comment>username_1: This is definitely an issue that I'm experiencing as well. Doesn't seem to relate to the source being mono or stereo. Or even the source format. This needs more research. Maybe an issue with the position of the audio.
<issue_comment>username_1: This should be fixed as of 16288c2.<issue_closed>
<issue_comment>username_0: Did you update the demos? Because they still have this problem.
<issue_comment>username_1: I didn't update the demos. |
<issue_start><issue_comment>Title: App freeze when start
username_0: ### Required Information
- Mode (Mock/Sandbox/Live): Sandbox
- PayPal iOS SDK Version: 2.15.1
- iOS Version and Device (iOS 8.x, iOS 9.3 on an iPhone 6s, etc.): iPhone 6s iOS 10
- PayPal-Debug-ID(s) (from any logs):
### Issue Description
Hello!
When I call this (in didFinishLaunchingWithOptions)
[PayPalMobile initializeWithClientIdsForEnvironments:@{
PayPalEnvironmentProduction : @"my key",
PayPalEnvironmentSandbox : @"my key"
}];
App freeze 5 seconds
<issue_comment>username_1: @username_0 It isn't normal. I don't have an exact iPhone 6s but on a couple of different phones with iOS 10, the sample apps don't exhibit this behavior. Does the sample app in this repository also show this?
<issue_comment>username_0: I cannot show here sample app with my secret keys. In the simulator I have the same problem.
But when I remove this method all work good.
<issue_comment>username_0: I download simple project from this repo and it has the same problem.
Run app, and 3-5 seconds app freeze
<issue_comment>username_0: Can somebody help me?
<issue_comment>username_0: Why is dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0)... is not normal?
<issue_comment>username_1: The `dispatch_async` solution should be ok as long as you guarantee that the `initializeWithClientIdsForEnvironments` call returns before you call any other PayPal method.
As far as why it is slow on your system, I'm not sure and haven't been able to reproduce on a couple of different devices using the sample in this repository.
<issue_comment>username_0: Hmm... It's very strange. Now all work good. In all devices my app and sample app from this repo.
<issue_comment>username_1: I'm not too sure but if the issue re-occurs, please leave a comment and anything else you discover if possible. Thanks.<issue_closed> |
<issue_start><issue_comment>Title: NPM registry update fails
username_0: I'm running the latest version of Brackets.
I've also tried to reinstall the extension.
In both cases I get this
<issue_comment>username_0: Just saw the thread on issue #46, closing.<issue_closed> |
<issue_start><issue_comment>Title: wait for same/parent queries
username_0: Could ember data wait for queries that are related?
For example i do a a query to */books* and a query to */books/15*.
Now ember data would wait for the first query to finish and check if book-15 is available. If not, it fires the second query.
Sometimes it can also happen that same queries are called at the same time. Ember data could only send one query and wait on one promise and not multiple.<issue_closed>
<issue_comment>username_1: This seems possible, but i think would add lots of complexity to the code and not sure how a good public api would look like to enable/disable. It would not be too hardy to implement a simple version, so I am happy to help create an addon for this, but not have it in core. Apologies for the late reply ;( |
<issue_start><issue_comment>Title: @ngtools/webpack plugin error: Unexpected token {
username_0: C:\Development\templates\Angular\AG2\src\AG2.Web\node_modules\@ngtools\webpack\src\plugin.js:270
const { line, character } = diagnostic.file.getLineAndCharacterOfPosition(diagnostic.start);
^
SyntaxError: Unexpected token {
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:404:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object.<anonymous> (C:\Development\templates\Angular\AG2\src\AG2.Web\node_modules\@ngtools\webpack\src\index.js:6:10)
at Module._compile (module.js:397:26)
at Object.Module._extensions..js (module.js:404:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object.<anonymous> (C:\Development\templates\Angular\AG2\src\AG2.Web\config\webpack.common.js:5:22)
at Module._compile (module.js:397:26)
```
<issue_comment>username_1: What version of node?
<issue_comment>username_0: @username_1 node v6.10.0
<issue_comment>username_2: I faced the same problem too on Node 4 and 5.
https://travis-ci.org/username_2/angular-onsenui2-webpack2/builds/210068755
<issue_comment>username_0: v 6.10.0
```
the webpack task give me the error from my main post but down below the error there is this:
```
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Web\\External\\Node.exe" "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Web\\External\\node_modules\\npm\\bin\\npm-cli.js" "run" "webpack:dev-host" "--color=always"
npm ERR! node v5.4.1
npm ERR! npm v3.3.4
npm ERR! code ELIFECYCLE
npm ERR! ag2@1.0.0 webpack:dev-host: `webpack-dev-server --inline --progress --port 8081`
npm ERR! Exit status 1
```
Which means that the task is using different version of node.I never noticed before nor I have any idea how it got there and why. Any help? I am using Visual Studio 2017 for development. not sure if it's related perhaps?
Cheers
<issue_comment>username_0: v 6.10.0
```
the webpack task give me the error from my main post but down below the error there is this:
```
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Web\\External\\Node.exe" "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Web\\External\\node_modules\\npm\\bin\\npm-cli.js" "run" "webpack:dev-host" "--color=always"
npm ERR! node v5.4.1
npm ERR! npm v3.3.4
npm ERR! code ELIFECYCLE
npm ERR! ag2@1.0.0 webpack:dev-host: `webpack-dev-server --inline --progress --port 8081`
npm ERR! Exit status 1
```
Which means that the task is using different version of node.I never noticed before nor I have any idea how it got there and why. Any help? I am using Visual Studio 2017 for development. not sure if it's related perhaps?
Cheers
<issue_comment>username_0: v 6.10.0
```
the webpack task give me the error from my main post but down below the error there is this:
```
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Web\\External\\Node.exe" "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\Web\\External\\node_modules\\npm\\bin\\npm-cli.js" "run" "webpack:dev-host" "--color=always"
npm ERR! node v5.4.1
npm ERR! npm v3.3.4
npm ERR! code ELIFECYCLE
npm ERR! ag2@1.0.0 webpack:dev-host: `webpack-dev-server --inline --progress --port 8081`
npm ERR! Exit status 1
```
Since I'm using Visual Studio the solution was to tell the VS to use the latest node in Tools -> Options -> Projects and Solutions -> External Web Tools. Adding the path to nodejs install folder solved the problem. Hope it will help anyone else facing this problem.
Cheers<issue_closed> |
<issue_start><issue_comment>Title: 🛑 Andreas Iten is down
username_0: In [`bbc55d3`](https://github.com/username_0/upptime/commit/bbc55d3d071f20935664ed931d1e87b4baea04a1
), Andreas Iten (https://www.andreasiten.ch) was **down**:
- HTTP code: 0
- Response time: 0 ms
<issue_comment>username_0: **Resolved:** Andreas Iten is back up in [`933cd1d`](https://github.com/username_0/upptime/commit/933cd1dc2b88839dd958b0ade4524e19e28344db
).<issue_closed> |
<issue_start><issue_comment>Title: Make authentication parameters optional
username_0: TheTVDb allows to pass in only the API key if you don't need to deal
with the account route. Modified the login method to take this into
account.
<issue_comment>username_1: Okay, thanks but this PR cannot be merged. I have fixed it in release 1.0.4. |
<issue_start><issue_comment>Title: ts mutex deadlock under sidekiq.
username_0: Ruby version: 2.3.1
Thinking-sphinx: 3.3.0
Sidekiq version: 4.2.10
rails: 5.0.0, 5.0.2
I have models, which have ts indices.
The sidekick run [attached worker](https://github.com/username_1/thinking-sphinx/files/886540/run_search_doubles_worker.rb.txt) as several jobs at the same time.
And all they are blocked on updating the record, which calls thinking-sphinx.
As you can see in [attached trace](https://github.com/username_1/thinking-sphinx/files/886555/trace.txt) for one of the jobs, ActiveRecord update_attribute call thinking-sphinx callback, which try get indices configuration.
[thinking_sphinx/configuration.rb#L78](https://github.com/username_1/thinking-sphinx/blob/develop/lib/thinking_sphinx/configuration.rb#L78)
I have no idea, how to use Sidekiq with thinking-sphinx simultaneously.
As I understand, thinking-sphinx configuration block inside mutex protect take a relatively much time, but why all threads got deadlock?
For test I commented @@mutex.synchronize, and get success update.
This issue is affected only sidekiq worker, manual call this worker from console works well.
<issue_comment>username_1: I'm really not sure why this deadlock is happening… I'd expect the first run would preload indices, and then everything else would be allowed to run after that.
Can you try adding the following to an initialiser - which will preload the indices fully when the app boots, and hopefully that'll avoid the deadlocks when the jobs are being processed by Sidekiq.
```
unless Rails.env.development?
ThinkingSphinx::Configuration.instance.preload_indices
end
```<issue_closed>
<issue_comment>username_0: Thank you for your help.
With preload_indices job now works as expected. |
<issue_start><issue_comment>Title: Support for xibs and row height
username_0: Support for Row height, default is 44.
Support for Xibs. A Custom class is required when specifying a xib.
Examples provided.
<issue_comment>username_1: Awesome work! In the future, I think breaking out the xib work and the cell height work into separate PRs would be helpful around discussing the changes.
Gave some feedback, but would love if someone else gave this a second set of :eyes: too!
<issue_comment>username_0: Done :)
<issue_comment>username_0: Updated
<issue_comment>username_2: Hi! I left a few comments but otherwise this looks good. Thanks for the PR. :smile_cat:
<issue_comment>username_0: Updated
<issue_comment>username_0: I fixed the where clause mistake.
I don't know I did not noticed it earlier :confounded:
<issue_comment>username_2: Thanks for fixing! Alright I promise one more thing, then :green_apple: so we can merge. :dancers:
<issue_comment>username_0: Done :smile:
<issue_comment>username_2: Merged! Thanks again. 🎉 |
<issue_start><issue_comment>Title: Elastic
username_0: I'm on [overhaul](https://github.com/opserver/Opserver/tree/overhaul) branch commit [837711d](https://github.com/opserver/Opserver/commit/837711d2cab0a6c0d5f8fb548272375d8129e9a5) and I'm getting a NullReference exception on [line 8](https://github.com/opserver/Opserver/blob/overhaul/Opserver/Views/Elastic/Shards.Table.cshtml#L8) in `Shards.Table.cshtml`
I've got three Elastic clusters configured and those work great on `master`. This issue is more of a heads up in case you broke something.
Full stacktrace:
`at ASP._Page_Views_Elastic_Shards_Table_cshtml.Execute() in D:\Opserver\Opserver\Views\Elastic\Shards.Table.cshtml:line 8
at System.Web.WebPages.WebPageBase.ExecutePageHierarchy()
at System.Web.Mvc.WebViewPage.ExecutePageHierarchy()
at System.Web.WebPages.WebPageBase.ExecutePageHierarchy(WebPageContext pageContext, TextWriter writer, WebPageRenderingBase startPage)
at System.Web.Mvc.RazorView.RenderView(ViewContext viewContext, TextWriter writer, Object instance)
at System.Web.Mvc.BuildManagerCompiledView.Render(ViewContext viewContext, TextWriter writer)
at StackExchange.Profiling.Mvc.WrappedView.Render(ViewContext viewContext, TextWriter writer)
at System.Web.Mvc.HtmlHelper.RenderPartialInternal(String partialViewName, ViewDataDictionary viewData, Object model, TextWriter writer, ViewEngineCollection viewEngineCollection)
at System.Web.Mvc.Html.PartialExtensions.Partial(HtmlHelper htmlHelper, String partialViewName, Object model, ViewDataDictionary viewData)
at System.Web.Mvc.Html.PartialExtensions.Partial(HtmlHelper htmlHelper, String partialViewName, Object model)
at ASP._Page_Views_Elastic_AllClusters_cshtml.Execute() in D:\Opserver\Opserver\Views\Elastic\AllClusters.cshtml:line 185
at System.Web.WebPages.WebPageBase.ExecutePageHierarchy()
at System.Web.Mvc.WebViewPage.ExecutePageHierarchy()
at System.Web.WebPages.StartPage.RunPage()
at System.Web.WebPages.StartPage.ExecutePageHierarchy()
at System.Web.WebPages.StartPage.RunPage()
at System.Web.WebPages.StartPage.ExecutePageHierarchy()
at System.Web.WebPages.WebPageBase.ExecutePageHierarchy(WebPageContext pageContext, TextWriter writer, WebPageRenderingBase startPage)
at System.Web.Mvc.RazorView.RenderView(ViewContext viewContext, TextWriter writer, Object instance)
at System.Web.Mvc.BuildManagerCompiledView.Render(ViewContext viewContext, TextWriter writer)
at StackExchange.Profiling.Mvc.WrappedView.Render(ViewContext viewContext, TextWriter writer)
at System.Web.Mvc.ViewResultBase.ExecuteResult(ControllerContext context)
at System.Web.Mvc.ControllerActionInvoker.InvokeActionResult(ControllerContext controllerContext, ActionResult actionResult)
at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList`1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult)
at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList`1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult)`
<issue_comment>username_1: Hmmm, I can't readily repro this - not sure how you'd get here with a null cluster. Can you give me some more details here - are there red/yellow cluster statuses? Do any other screens throw? What exact URL are you at?
<issue_comment>username_0: Closing this because I can't reproduce that myself.
One of the clusters was down for sure and no connection could be made. I was debugging other stuff so there were several tabs open and it's possible that one of them might requested something while app was not initialized yet, although I have no idea how shards table could be requested in main screens.<issue_closed>
<issue_comment>username_0: So yesterday I got this once again. I was in main Elastic dashboard and one of the nodes was down. I did restart it and during the time when it was getting up I got the error again.
@username_1 I will try to investigate this once I get some free time to setup elastic locally and debug the behavior. I might reopen this once I get some real info.
<issue_comment>username_1: I'm on [overhaul](https://github.com/opserver/Opserver/tree/overhaul) branch commit [837711d](https://github.com/opserver/Opserver/commit/837711d2cab0a6c0d5f8fb548272375d8129e9a5) and I'm getting a NullReference exception on [line 8](https://github.com/opserver/Opserver/blob/overhaul/Opserver/Views/Elastic/Shards.Table.cshtml#L8) in `Shards.Table.cshtml`
I've got three Elastic clusters configured and those work great on `master`. This issue is more of a heads up in case you broke something.
Full stacktrace:
`at ASP._Page_Views_Elastic_Shards_Table_cshtml.Execute() in D:\Opserver\Opserver\Views\Elastic\Shards.Table.cshtml:line 8
at System.Web.WebPages.WebPageBase.ExecutePageHierarchy()
at System.Web.Mvc.WebViewPage.ExecutePageHierarchy()
at System.Web.WebPages.WebPageBase.ExecutePageHierarchy(WebPageContext pageContext, TextWriter writer, WebPageRenderingBase startPage)
at System.Web.Mvc.RazorView.RenderView(ViewContext viewContext, TextWriter writer, Object instance)
at System.Web.Mvc.BuildManagerCompiledView.Render(ViewContext viewContext, TextWriter writer)
at StackExchange.Profiling.Mvc.WrappedView.Render(ViewContext viewContext, TextWriter writer)
at System.Web.Mvc.HtmlHelper.RenderPartialInternal(String partialViewName, ViewDataDictionary viewData, Object model, TextWriter writer, ViewEngineCollection viewEngineCollection)
at System.Web.Mvc.Html.PartialExtensions.Partial(HtmlHelper htmlHelper, String partialViewName, Object model, ViewDataDictionary viewData)
at System.Web.Mvc.Html.PartialExtensions.Partial(HtmlHelper htmlHelper, String partialViewName, Object model)
at ASP._Page_Views_Elastic_AllClusters_cshtml.Execute() in D:\Opserver\Opserver\Views\Elastic\AllClusters.cshtml:line 185
at System.Web.WebPages.WebPageBase.ExecutePageHierarchy()
at System.Web.Mvc.WebViewPage.ExecutePageHierarchy()
at System.Web.WebPages.StartPage.RunPage()
at System.Web.WebPages.StartPage.ExecutePageHierarchy()
at System.Web.WebPages.StartPage.RunPage()
at System.Web.WebPages.StartPage.ExecutePageHierarchy()
at System.Web.WebPages.WebPageBase.ExecutePageHierarchy(WebPageContext pageContext, TextWriter writer, WebPageRenderingBase startPage)
at System.Web.Mvc.RazorView.RenderView(ViewContext viewContext, TextWriter writer, Object instance)
at System.Web.Mvc.BuildManagerCompiledView.Render(ViewContext viewContext, TextWriter writer)
at StackExchange.Profiling.Mvc.WrappedView.Render(ViewContext viewContext, TextWriter writer)
at System.Web.Mvc.ViewResultBase.ExecuteResult(ControllerContext context)
at System.Web.Mvc.ControllerActionInvoker.InvokeActionResult(ControllerContext controllerContext, ActionResult actionResult)
at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult)
at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilterRecursive(IList1 filters, Int32 filterIndex, ResultExecutingContext preContext, ControllerContext controllerContext, ActionResult actionResult)`
<issue_comment>username_1: @username_0 re-opening now since it's obviously a thing, must be a race on the polls - I'll take another look today.
<issue_comment>username_0: No rush, it is not critical.<issue_closed>
<issue_comment>username_1: @username_0 this was a case of me being stupid, fixed above!
<issue_comment>username_0: I can confirm that it's working now. |
<issue_start><issue_comment>Title: Empty changeset is still executed, fails.
username_0: When an update is done with an empty changeset (all options None), it still tries to execute the query (which fails, at least with postgres), maybe that should be prevented earlier?
<issue_comment>username_1: This should have been fixed in 0.9. Can you provide a script to reproduce?<issue_closed>
<issue_comment>username_2: I just tried it and got
```
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: QueryBuilderError(StringError("There are no changes to save. This query cannot be built"))', /checkout/src/libcore/result.rs:860:4
```
I think this can be closed as we can't detect that there are no changes earlier than that.
@username_0 Feel free to reopen if you think I'm wrong
<issue_comment>username_1: Just to clarify on why it is important that this is an error case, while inserting an empty vector is not:
When you insert 0 rows, we always know exactly how to replicate the behavior that would have otherwise occurred (`execute` returns `Ok(0)`, `get_results` returns `Ok(Vec::new())`, and `get_result` returns `Err(NotFound)`). That is not the case with a changeset with no changes.
In the absolute simplest case we'd need to do the equivalent `SELECT` statement to figure out what to return, but even that is insufficient. We'd also need to vary our behavior based on whether the changeset given was attempting to use upsert. Even with all of that, the triggers executed could potentially change the outcome as well.
<issue_comment>username_3: #[macro_use] extern crate diesel;
#[macro_use] extern crate diesel_codegen;
extern crate dotenv;
use diesel::prelude::*;
use diesel::mysql::MysqlConnection;
use dotenv::dotenv;
use std::env;
use schema::numbers;
pub fn establish_connection() -> MysqlConnection {
dotenv().ok();
let database_url = env::var("DATABASE_URL")
.expect("DATABASE_URL must be set");
MysqlConnection::establish(&database_url)
.expect(&format!("Error connecting to {}", database_url))
}
mod schema {
infer_schema!("dotenv:DATABASE_URL");
}
#[derive(Debug, Queryable)]
struct Number {
id: i32,
number: i32
}
#[derive(Insertable)]
#[table_name="numbers"]
pub struct NewNumber {
number: i32
}
#[derive(AsChangeset)]
#[table_name="numbers"]
pub struct ChangeNumber {
number: Option<i32>
}
fn main() {
let connection = establish_connection();
let results = numbers::table.limit(5).load::<Number>(&connection).expect("error");
println!("{:?}", results);
let n = NewNumber { number: 1 };
diesel::insert(&n).into(numbers::table).execute(&connection).expect("errr");
let change = ChangeNumber { number: None };
diesel::update(numbers::table.find(1)).set(&change).execute(&connection).unwrap();
}
This code ends up with the same error but for `mysql`. |
<issue_start><issue_comment>Title: Minimap display error
username_0: Minimap overview region has wrong height in pixels. It should not be computed, it should be `height: 100%`.
Minimap progressCc canvas is misaligned. It should have `position: absolute` style applied.
Screenshot showing current state:
Screenshot after changes to style attribute:
<issue_comment>username_1: Seems to be related to #373. I'm not sure if it's the same bug.
<issue_comment>username_1: Could you maybe make a pull request with your changes? The styles are applied in the file `drawer.canvas.css`.
<issue_comment>username_0: In my application I've just made a quick fix by binding to `ready` callback this function (coffeescript):
```
fixWaveSurferMinimap: ->
$(@minimap.overviewRegion).css('height', '100%')
$(@minimap.progressCc.canvas).css('position', 'absolute')
```
where `@minimap` is the instance returned by `@wavesurfer.initMinimap` function.
But this morning I've had some time to analyse wavesurfer's code and overview region height is `wavesurfer.minimap.js` in line 81, I think. As for progressCc.canvas it is `drawer.canvas.js`, line 43 (that's where position absolute should be applied).<issue_closed>
<issue_comment>username_1: Should be OK now.
<issue_comment>username_0: Still not fixed. I've just updated wavesurfer js files in my project and disabled setting styles on `ready` event - nothing has changed:
Minimap progress waveform is still lower than it should be.
Overview still has calculated height instead of 100% (and the calculated value is lower by 2px than it should be in my case).
Also after updating wavesurfer js files my fix with setting `position: absolute` to `@minimap.progressCc.canvas` is not working anymore (minimap progress is not visible at all after setting that style).
<issue_comment>username_2: Minimap overview region has wrong height in pixels. It should not be computed, it should be `height: 100%`.
Minimap progressCc canvas is misaligned. It should have `position: absolute` style applied.
Screenshot showing current state:
Screenshot after changes to style attributes:
<issue_comment>username_2: @username_0 any better with the latest version?
<issue_comment>username_3: This bug is still there.<issue_closed>
<issue_comment>username_4: This has already been fixed, |
<issue_start><issue_comment>Title: Hard to contribute to apm develop'd repos
username_0: What's the story for actually contributing to a 3rd party package installed via `apm develop`? It just clones from the repo url, but doesn't make a fork. This works for us, but not those without commit bit. Could it fork and clone?
We should at least have some docs on how we think they should do it (fork, then change the origin after apm develop?)
http://discuss.atom.io/t/submitting-a-pull-request/2306
<issue_comment>username_1: apm link now works on Windows.
I'd recommend the following process for using apm dev;
1. `apm dev packagename`
2. Do your work, commit locally to a branch
So far, so easy and no new steps. Now if you want to contribute back to the package;
1. Fork the original repo on github.com
2. `git remote set-url origin <your-fork-url>`
3. `git push`
4. Create PR on github.com<issue_closed> |
<issue_start><issue_comment>Title: git-flow release checkout and pull
username_0: This might be a stupid question, a release is very similar to a feature branch, why can one publish a release and then can't pull using git-flow commands like you can in a feature branch? Or does it just need implementing?
Thanks.
<issue_comment>username_1: Usually I do just:
```
$ git checkout release/v1.0
Branch release/v1.0 set up to track remote branch release/v1.0 from origin by rebasing.
Switched to a new branch 'release/v1.0'
```
But it will be convinient to have separate git-flow command to pull **unfinished** release branch. |
<issue_start><issue_comment>Title: Cursor invisible after drag-n-drop in Firefox
username_0: 1. Load http://prosemirror.net/
2. Drag logo into the ProseMirror editor example
3. Click somewhere in the editor
4. Type "foo"
Expected: Cursor should appear after step 3, and "foo" should be inserted
Actual: Cursor never appears, but "foo" is still inserted at the proper location
Appears to be a [bug with Firefox's contenteditable implementation](https://stackoverflow.com/questions/10890103/firefox-cursor-invisible-becomes-visible-when-clicking-anything-else) (there are several on bugzilla regarding the cursor). I haven't dug into it too much yet, but clicking elsewhere (eg, the "A toolkit..." title) and then clicking back into the editor will show the cursor again.
<issue_comment>username_1: There's not a whole lot we can do about browsers being terrible, especially when its effect isn't actually observable in JavaScript. If you want to help, investigating whether other contentEditable-based editors are affected and seeing if they have a working workaround would be a good approach.
<issue_comment>username_0: Yeah, I meant to mention I was going to look into this later. (There's a good chance I'll be opening several issues over the next week or so... I'm going to try to follow up on them myself if you aren't able to get to them.)
The workaround mentioned in the linked stackoverflow thread mentions focusing a generated `<a>` and then setting the focus back to the `[contenteditable]` element. I'll try playing around with this next week sometime. (I'll also be opening a bug on bugzilla if I can't find an existing one for the exact issue.)
<issue_comment>username_2: I have a similar issue in Firefox I think due to having stored marks and thus a cursor wrapper.
<issue_comment>username_1: Can this be reproduced in a demo? Does force-resetting the DOM selection after drop help?
<issue_comment>username_2: @username_0 gave steps for prosemirror.net, but I cannot reproduce the issue with those steps in my FF56. As for my incarnation of the issue: It is reproducible with a rather [simple modification](https://github.com/ProseMirror/website/commit/repro583) to the basic demo. You need to have a `background-color` and a stored mark. It's probably what [this person on Stackoverflow](https://stackoverflow.com/questions/43802829/firefox-content-editable-cursor-invisible-before-node-with-background-color) ran into.
<issue_comment>username_1: Okay, so then drag-and-drop isn't actually involved. Opening a new issue #712
<issue_comment>username_3: Here is a [glitch](https://glitch.com/edit/#!/luxuriant-storm) that reproduces the issue after a drag.
(mostly unmodified Dinosaur demo).
As indicated, these seem to be separate issues. This one might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=800050 though I did not get the workaround mentioned in the last post to work.
<issue_comment>username_4: https://sticky-ferret.glitch.me
<issue_comment>username_5: You can resolve this by having a hidden input somewhere and then after you are done handling the drop event, you move the native selection into that hidden input and then move it back to inside of PM. It forces a sort of soft reset where Firefox will fix itself. You can use a selection bookmark to restore the selection and you will need to all restore storedMarks and then call view.focus. If you do that though, the cursor should come back.
We use this "cursor parking" technique in a few spots to get around weird native issues where the browser breaks something on prevented events or the browser ignores your prevent defaults (like the touchbar with Safari).
<issue_comment>username_5: Just to note, you do need a set timeout between moving the focus and restoring the selection.
<issue_comment>username_5: Posted in the discussion forum with an example https://discuss.prosemirror.net/t/cursor-parking-a-tool-to-help-handle-native-browser-issues/2107
<issue_comment>username_1: Does this still happen for anyone with current Firefox versions?
<issue_comment>username_6: I still have a similar problem on Firefox 84. When I have 2 prosemirror instances on the same page. If I try to switch from one PM to the other without clicking first on the background of the window, the carret is not displayed, though the focus is set correctly and typing works as expected. |
<issue_start><issue_comment>Title: Incorrect count in 'creating a readable stream' section
username_0: When I run [readable stream example](https://github.com/substack/stream-handbook/blame/c4e328bcb57f689002bc5d68f62a45b12ca1274d/readme.markdown#L256-L276) I get the result
```
abcdefghijklmnopqrstuvwxyz
_read() called 25 times
```
Which is incorrect as this string is 26 characters long. And the code, indeed, is incorrect as after `a` is pushed `c = 97` and so it thinks that `_read` was called `0` times.
However, it works 'correctly' with `head`. I suppose the `-1` correction in the code was added to incorrectly fix the (for some other reason I don't understand) wrong count when piping to `head`. So the fix is as easy as adding `+1` when showing `_read` called count but it then breaks `| head -c5`.
I've found this error by adding:
```js
process.on('SIGINT', function () {
process.exit();
});
```
One more interesting thing. Replacing `_read` with:
```js
rs._read = function () {
if (c >= 'z'.charCodeAt(0)) return rs.push(null);
setTimeout(function () {
var x = String.fromCharCode(++c);
console.error('pushing: ' + x);
rs.push(x);
}, 100);
};
```
Outputs:
```
node /tmp/test.js | head -c5
pushing: a
pushing: b
pushing: c
pushing: d
pushing: e
abcdepushing: f
_read() called 5 times
```
Please note the additional `pushing: f`.
<issue_comment>username_0: My understanding right now is that this code is trying to push into the pipe. It pushes 5 characters and `head` reads them and quits. Then it tries to push 6th character and it gets an error (and quits because of `SIGPIPE` (or in this case stdout error which is `EPIPE`)).
So with this explanation issue #69 looks very similar. |
<issue_start><issue_comment>Title: Moved the alias storage mechanism over to boltDB`
username_0: Got bored and rolled the alias storage system over to boldDB. Needed something to help me sleep. This allows for transactional updates to aliases without the racyness of blowing away a file and restoring it.
Feel free to take it or leave it, no worries.
<issue_comment>username_1: Also, another question - is the intention to keep the `~/.config/go-wol/aliases` entity as the db object? Or should we just make the whole `go-wol` directory (now) into the DB? Thoughts?
<issue_comment>username_1: I am just going to merge this, too eager :p
Thanks for all the awesome work and advise @username_0
<issue_comment>username_1: @username_0 - check out the latest commit in master. I made a few stylistic changes + a couple of small re-factorings. Could you take a look when you have some time and let me know if this looks good to you?
<issue_comment>username_0: Will do. Thanks
<issue_comment>username_0: they all seem pretty straight forward and help to clean the code up.
Inlining the gob.NewEncoder(buff).Encode(&thingy) is a nice touch.
On Fri, Feb 20, 2015 at 11:17 AM, K. Watts <username_0@gmail.com> wrote:
> Will do. Thanks
> |
<issue_start><issue_comment>Title: Release Branch Mapping
username_0: Currently, graph rules can only be created for master branch. To expand the support for other branches, some mapping is required for each package.
<issue_comment>username_1: graph for 'ovirt-engine-jrs-branding' has no 'release' specific branch (needs mapping)<issue_closed> |
<issue_start><issue_comment>Title: feature request: bottom navigation
username_0: * **Do you want to request a *feature* or report a *bug*?**
Request a feature + implement the feature: **bottom navigation**.
* **What is the current behavior?**
Doesn't exist.
* **What is the expected behavior?**
Hopefully, it will exist? :smile:
* **What is the motivation / use case for changing the behavior?**
I need to build a bottom based navigation for something I'm working on, so I figured I might as well build it and contribute it to material2
The component I'm referring to is https://www.google.com/design/spec/components/bottom-navigation.html#bottom-navigation-usage
Is there any appetite for this component in the library?
<issue_comment>username_1: Can you do this with just the toolbar and some flex layouts? Here's a quick example:
https://github.com/username_1/ng2-md-bottom-nav-bar
<issue_comment>username_0: @username_2 I've started work on this, basically just boilerplate at this point for the component itself and the demo app. Is it beneficial to create a PR before it's ready (so others can see that it's being worked on) or does that complicate the process?
<issue_comment>username_2: The first step is to create a design doc (you can find example design docs linked in the README). Once we've approved the approach, generally the next step is a WIP pull request.<issue_closed>
<issue_comment>username_3: Going to track this via #408. If anyone plans on working on this, the first step is to comment on that PR stating your **intent to implement**, along with how you plan to approach it. The next step is to write a design document for the team to review (following our [template](https://docs.google.com/document/d/1kpQStAn9L-NX_1bGz_4fXNeZgerWC0mUJHun72bF240/preview)). You can see the [directory of existing design docs on our wiki](https://github.com/angular/material2/wiki/Design-doc-directory). |
<issue_start><issue_comment>Title: Quoine: API Authentication fails for AccountInfoDemo
username_0: Hello all,
I'm trying to run the demo from xchange-examples...quoine.account.AccountInfoDemo.java
I've added my ID and SECRET to empty placeholders in QuoineExamplesUtils.java class
however I get an 401 API Authentication failed error back.
My lines in QuoineExamplesUtils look similar (keys changed) to this:
```
exSpec.getExchangeSpecificParameters().put(QuoineExchange.KEY_USER_ID, "11512");
exSpec.getExchangeSpecificParameters().put(QuoineExchange.KEY_USER_SECRET, "bQ9weVcbel576E2122SOzjKJZg3c0KW2zd4pq5GTVjT0pwv6A+Omp/MeuVpDoD25YfaehCx/xd0SknZt1==");
```
The above are the keys I got from the (enabled) api settings page in my quoine account.
Is there something I do wrong or is the code/api currently somewhat broken?
Thanks in advance and below the full exception I get:
```
Exception in thread "main" org.knowm.xchange.exceptions.ExchangeException: API Authentication failed
at org.knowm.xchange.quoine.service.polling.QuoineAccountServiceRaw.getQuoineAccountInfo(QuoineAccountServiceRaw.java:30)
at org.knowm.xchange.quoine.service.polling.QuoineAccountService.getAccountInfo(QuoineAccountService.java:44)
at org.knowm.xchange.examples.quoine.account.AccountInfoDemo.generic(AccountInfoDemo.java:30)
at org.knowm.xchange.examples.quoine.account.AccountInfoDemo.main(AccountInfoDemo.java:24)
Caused by: si.mazi.rescu.HttpStatusIOException: HTTP status code was not OK: 401
at si.mazi.rescu.ResponseReader.read(ResponseReader.java:104)
at si.mazi.rescu.RestInvocationHandler.mapInvocationResult(RestInvocationHandler.java:169)
at si.mazi.rescu.RestInvocationHandler.receiveAndMap(RestInvocationHandler.java:157)
at si.mazi.rescu.RestInvocationHandler.invoke(RestInvocationHandler.java:120)
at com.sun.proxy.$Proxy12.getAccountInfo(Unknown Source)
at org.knowm.xchange.quoine.service.polling.QuoineAccountServiceRaw.getQuoineAccountInfo(QuoineAccountServiceRaw.java:28)
```
<issue_comment>username_1: Looks like Quoine changed their authentication to use [JWT](https://jwt.io/)<issue_closed>
<issue_comment>username_1: @username_0 do you want to test again? Quoine has been updated to the latest version. I'm closing this for now.
<issue_comment>username_2: @username_0 did you resolve this? I'm getting a 401 from some endpoints but not others. |
<issue_start><issue_comment>Title: Try to deflake integration test (#382)
username_0: Plus a couple of other small fixes.
<issue_comment>username_1: Are we sure that the unused port issue is the one that's actually causing the failures?
I've occasionally seen this behavior when servers are not shutdown cleanly.
`server.Stop()` leaves clients hanging. Prefer `server.GracefulStop()`
`kill ` might also leave some ports hanging in intermediate states.
<issue_comment>username_2: Many thanks for doing this, btw! |
<issue_start><issue_comment>Title: Single Sign On using Parse.com
username_0: Is it possible to have something like a Disqus SSOm, wherein once i am signed in in my Parse application (Javascript only) then i automatically get signed on to hypothes.is
<issue_comment>username_1: @username_0 My understanding is that we don't have any form of single-sign on support at the moment but it is an important task on our roadmap.
<issue_comment>username_2: This is hypothesis/vision#118<issue_closed>
<issue_comment>username_3: Closed in favor of hypothesis/vision#118. |
<issue_start><issue_comment>Title: support user-defined aux directory
username_0: Problem is in rapclust, reading from output of salmon (0.6) or salfish, assume 'aux/' is name of auxiliary directory, but it is parameter the user can modify. If user runs with non-standard option, name will be different.
salmon 0.7 has different default aux directory name.
<issue_comment>username_1: This should be resolved by @keyavi's pull request #11.<issue_closed> |
<issue_start><issue_comment>Title: Introduce pymssql hook
username_0: Honor dependency on `_mssql` module
<issue_comment>username_1: Thanks for the pull-request and sorry for not answering earlier.
Please add a licence header to the file as you can see in the other hook files.
The commit message should be "Add hook for mssql.".
When updating a pull-request, you can simply (force) push the updated branch to github again. This will automatically update the pull-request (which follows the branch, not the commit). So you do not need to close the pull-request and open a new one. This also has the benefit that the discussion history is kept.
<issue_comment>username_1: Merged manually in 026bf39f9ff449db4a827e05183000cac9641923
<issue_comment>username_2: **_Please add a license header to the file as you can see in the other hook files.
The commit message should be "Hooks: Add hook for mssql."._**
I met the same issue as Charles. Would you mind tell us how to add the license header to hook file? |
<issue_start><issue_comment>Title: How to upgrade to Vagrant 1.9.1 from any older version on Ubuntu 16.04
username_0: Steps:
Note: First remove the older version of vagrant.
1.Download the vagrant version form this link:
https://releases.hashicorp.com/vagrant/1.9.1/\
2. sudo dpkg -i /path/to/deb/file<issue_closed>
<issue_comment>username_2: Does this process remove the files or VMs of old version?
<issue_comment>username_3: - These are the steps to remove existing vagrant installation:
1. sudo apt-get remove --auto-remove vagrant
2. rm -r ~/.vagrant.d
_NOTE: Above steps does not remove machines available under workingdir/.vagrant/ folder_
- These are the steps to install vagrant 2.0.2:
1. wget https://releases.hashicorp.com/vagrant/2.0.2/vagrant_2.0.2_x86_64.deb
2. sudo dpkg -i vagrant_2.0.2_x86_64.deb
3. vagrant version
<issue_comment>username_4: These are the steps to remove existing vagrant installation:
```
1. sudo apt-get remove --auto-remove vagrant
2. rm -r ~/.vagrant.d
```
These are the steps to install vagrant 2.0.3:
```
1. wget https://releases.hashicorp.com/vagrant/2.0.3/vagrant_2.0.3_x86_64.deb
2. sudo dpkg -i vagrant_2.0.3_x86_64.deb
3. vagrant version
```
**Ref Link :** https://www.vagrantup.com/downloads.html
<issue_comment>username_5: These are the steps to remove existing vagrant installation:
1. sudo apt-get remove --auto-remove vagrant
2. rm -r ~/.vagrant.d
These are the steps to install vagrant X.X.X:
1.Download your version here : https://releases.hashicorp.com/vagrant/
or `wget https://releases.hashicorp.com/vagrant/X.X.X/vagrant_X.X.X_x86_64.deb`
2. sudo dpkg -i vagrant_X.X.X_x86_64.deb
3. vagrant version
Ref Link : https://releases.hashicorp.com/vagrant/ |
<issue_start><issue_comment>Title: DEPENDENT: API: Expose bitcoinconsensus_verify_header() in libconsensus
username_0: To extend libconsensus' functionality, I propose to add ```bitcoinconsensus_verify_header()``` the partial checks ```CheckBlockHeader()``` and ```ContextualCheckBlockHeader``` could be exposed as well.
Unlike VerifyScript, VerifyBlockHeader depends on the nodes storage, as it requires data from the blockchain previous to the header being verified. How to exactly interface that data with VerifyBlockHeader can be a delicate matter and it should be of course open to discussion. Here there's just one proposal.
The offending dependency is CBlockIndex in chain.o, specially CBlockIndex::pprev which is a pointer to another object. All the other dependencies unacceptable for libconsensus have been removed first, to make things easier for someone who wants to propose to solve that final problem in some other way.
Dependencies:
-Consensus preparations #5669
-Chainparams: Refactor: Decouple IsSuperMajority from Params() #5968
-Consensus: Decouple ContextualCheckBlockHeader from checkpoints #5975
-Consensus: Turn CBlockIndex::GetMedianTimePast into independent function #6009
<issue_comment>username_0: Needed rebase
<issue_comment>username_0: I realized this is mostly unreadable until something similar to #6048 is merged.
I will close this for now but I will still maintain the list of dependencies. |
<issue_start><issue_comment>Title: Add problem difficulty level to the problems (Crowd-source or add a classfier)
username_0:
<issue_comment>username_1: In the case of codechef, difficulty can be directly added for the practice problems page
For contest submissions, we can search for the problem code in practice section pages.
<issue_comment>username_0: Hey @username_1 ,
Adding difficulty by going to the problem page is something that is not desired for StopStalk. We have the submissions for each problem of users and the accuracy of those submissions is pretty decent measure of assigning difficulty level to the problem. (Undesirable because of extra and unnecessary network requests).
<issue_comment>username_0: <issue_closed> |
<issue_start><issue_comment>Title: Fix ‘null’ output if command doesn’t return
username_0: - This prevents commands from printing ‘null’ in JSON output
- But still keeps ‘[]’, ‘{}’, and ‘false’ as valid JSON results
Closes https://github.com/Azure/azure-cli/issues/1908
<issue_comment>username_0: @tjprescott Can you take a quick look? |
<issue_start><issue_comment>Title: No impl of Ord for RefCell<T> or Cell<T> when T: Ord
username_0: Title says it all. I am working on it right now. Do I need to create an RFC or can I just send a PR?
<issue_comment>username_1: The implementation for RefCell is not super workable since it would have to either panic or return nonsensical results if the cell is borrowed mutably at the time. An impl for Cell seems like it should be fine though.
<issue_comment>username_2: What's the problem with panicking? That's what `borrow()` does anyway if there's an outstanding mutable borrow. Given that this is single-threaded, it would be a program error anyway.
<issue_comment>username_3: @username_1 there is an impl of `PartialEq` for `RefCell<T: PartialEq>`, so `PartialOrd`/`Ord` should behave the same way anyway.
<issue_comment>username_4: Fixed by #33306.<issue_closed> |
<issue_start><issue_comment>Title: buildUrl does not resolve relative links
username_0: The SwaggerUI.buildUrl function does not resolves relative links such as `../swagger.json` or `./swagger.json`.
swagger-ui version: 2.2.3 (master)
<issue_comment>username_1: You mean you're passing a relative link to it? I don't know that really makes sense<issue_closed>
<issue_comment>username_0: I wanted to use a relative link, assuming it would be resolved relative to the URL of the document from which Swagger UI is invoked.
A relative link is better in my case to avoid hard coding the hostname in the URL for dev/testing/prod environments.
I wrote a workaround by building the absolute spec URL before passing it to SwaggerUI. The code is not online anymore as my company collapsed. |
<issue_start><issue_comment>Title: unexpected behaviour when repeatedly calling Geometry3D.addFromGeometry3D()
username_0: #### Rajawali Version or Branch
master
#### Device and Android Version
SM-T230N
#### Summary
When repeatedly calling `Geometry3D.addFromGeometry3D()` a `java.nio.BufferOverflowException` is thrown. Only possible to run into this issue after fix for #1760 was implemented.
#### Steps to Reproduce
```
protected void initScene() {
getCurrentScene().setBackgroundColor(Color.BLUE);
try {
Geometry3D geometry;
Material yellow = new Material();
yellow.setColor(Color.YELLOW);
float[] vertices = new float[] {
-0.5f, 0.5f, 0,
-0.5f,-0.5f, 0,
0.5f,-0.5f, 0,
0.5f, 0.5f, 0,
};
float[] normals = null;
float[] textureCoords = null;
float[] colors = null;
int[] indices = new int[] {
0,1,2,
0,2,3,
};
boolean createVBOs = false;
geometry = new Geometry3D();
geometry.setData(vertices, normals, textureCoords, colors, indices, createVBOs);
Object3D obj = new Object3D();
obj.isContainer(false);
obj.getGeometry().addFromGeometry3D(new Vector3(-1,-1,-1), geometry, createVBOs);
obj.getGeometry().addFromGeometry3D(new Vector3( 0, 0, 0), geometry, createVBOs);
obj.getGeometry().addFromGeometry3D(new Vector3( 1, 1, 1), geometry, createVBOs);
obj.getGeometry().createBuffers();
obj.setMaterial(yellow);
getCurrentScene().addChild(obj);
getCurrentCamera().setLookAt(obj.getPosition());
} catch (Exception e) {
e.printStackTrace();
}
}
```
#### Trace or Log Output
```
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: java.nio.BufferOverflowException
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at java.nio.Buffer.checkPutBounds(Buffer.java:189)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at java.nio.DirectByteBuffer.put(DirectByteBuffer.java:326)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at java.nio.ByteBufferAsFloatBuffer.put(ByteBufferAsFloatBuffer.java:160)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at java.nio.FloatBuffer.put(FloatBuffer.java:385)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at org.rajawali3d.Geometry3D.setTextureCoords(Geometry3D.java:836)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at org.rajawali3d.Geometry3D.addFromGeometry3D(Geometry3D.java:329)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at com.example.geometryfail.GeometryActivity$GeometryRenderer.initScene(GeometryActivity.java:367)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at org.rajawali3d.renderer.Renderer.onRenderSurfaceSizeChanged(Renderer.java:345)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at org.rajawali3d.view.SurfaceView$RendererDelegate.onSurfaceChanged(SurfaceView.java:230)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1520)
09-07 16:23:12.395 31969-31999/com.example.geometryfail W/System.err: at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1248)
```
<issue_comment>username_1: Fixed via #1767<issue_closed> |
<issue_start><issue_comment>Title: bug fix installing redis
username_0: when jumpscale uses cuisine to install
redis on start up , it tries to overwrite
the binary already in use to run jumpscale
causing an error , this is avoided by the
--no-clobber option which if exits will not replace
<issue_comment>username_1: Did you test this fix with the docker builder ?
<issue_comment>username_0: yes, testing now
<issue_comment>username_1: Let me know how the tests goes please |
<issue_start><issue_comment>Title: issue in 'Passing URL from config file to test file'
username_0: Hi there,
I've created a config file (config.js) where I defined an API URL which I want to use in test file (*_test_spec.js) during test run. BUT it's not fetching the URL value from config file and showing it as "undefined". Can you please suggest what is the issue here?
**config.js:**
```
var frisby = require('../lib/frisby');
var URL = 'https://something-something.com/';
```
**dummy_test_spec.js:**
```
var frisby = require('../lib/frisby');
var config = require('./config.js');
frisby.create('dummy test')
.get(URL+'/abc/')
.expectStatus(200)
.toss();
```
Appreciate your help.
Thanks
<issue_comment>username_0: I've figured it out and it's working.
Instead of using config.js, I'm using config.json file to have more control on formatting and config data. Here is the sample:
*config.json*
```
{
"api_url" : "https://something-something.com/",
"auth_token" : "ACB21340112308XYZ"
}
```
*dummy_test_spec.js*
```
var frisby = require('../lib/frisby');
var config = require('./config.json');
frisby.create('dummy test')
.get(config.api_url+'/abc/')
.expectStatus(200)
.toss();
```<issue_closed> |
<issue_start><issue_comment>Title: Add documentation for the ``dist_no`` field on the ``Cvr2CampaignDisclosureCd`` database model
username_0: ## Your mission
Add documentation for the ``dist_no`` field on the ``Cvr2CampaignDisclosureCd`` database model.
## Here's how
**Step 1**: Claim this ticket by leaving a comment below. Tell everyone you're ON IT!
**Step 2**: Open up the file that contains this model. It should be in <a href="https://github.com/california-civic-data-coalition/django-calaccess-raw-data/blob/master/calaccess_raw/models/campaign.py">calaccess_raw.models.campaign.py</a>.
**Step 3**: Hit the little pencil button in the upper-right corner of the code box to begin editing the file.
**Step 4**: Find this model and field in the file. (Clicking into the box and searching with CTRL-F can help you here.) Once you find it, we expect the field to lack the ``help_text`` field typically used in Django to explain what a field contains.
```python
effect_dt = fields.DateField(
null=True,
db_column="EFFECT_DT"
)
```
**Step 5**: In a separate tab, open up the <a href="Quilmes">official state documentation</a> and find the page that defines all the fields in this model.
**Step 6**: Find the row in that table's definition table that spells out what this field contains. If it lacks documentation. Note that in the ticket and close it now.
**Step 7**: Return to the GitHub tab.
**Step 8**: Add the state's label explaining what's in the field, to our field definition by inserting it a ``help_text`` argument. That should look something like this:
```python
effect_dt = fields.DateField(
null=True,
db_column="EFFECT_DT",
# Add a help_text argument like the one here, but put your string in instead.
help_text="The other values in record were effective as of this date"
)
```
**Step 9**: Scroll down below the code box and describe the change you've made in the commit message. Press the button below.
**Step 10**: Review your changes and create a pull request submitting them to the core team for inclusion.
That's it! Mission accomplished!<issue_closed> |
<issue_start><issue_comment>Title: Allow creating multiple compositions per map
username_0: Right now when you change the map selected, you switch to editing the composition you've already created for that map. It's only when you've never made a composition for that map that you get an empty form. We should allow creating multiple compositions per map. So a user needs to be able to switch between the compositions they've created for the selected map, and they also need to be able to say "create a brand new, empty composition for this map."
I'm thinking an additional select menu, perhaps in the black header area right below the composition name field, is how we can support this. It can have options for each composition you have for that map, and the bottom option can be "Add a new composition."
When you switch maps, the composition that should be loaded automatically should be the last one you edited for that map. I think this is already the case right now. We just need to hook up also specifying a particular composition ID so you can swap between them via the new menu.
See https://trello.com/c/GNyojHlC/10-feature-to-save-multiple-team-comps-per-map-e-g-plan-a-plan-b for early planning of this feature.<issue_closed> |
<issue_start><issue_comment>Title: NPE in 4.5.0
username_0: # Version
4.5.0
# Exception
## Message
was in the process of typing `use Ecto.Schema`
## Stacktrace
```
java.lang.NullPointerException
at org.elixir_lang.psi.scope.call_definition_clause.Variants.getLookupElementCollection(Variants.java:144)
at org.elixir_lang.psi.scope.call_definition_clause.Variants.lookupElementList(Variants.java:42)
at org.elixir_lang.reference.Callable.getVariants(Callable.java:583)
at com.intellij.codeInsight.completion.CompletionData.completeReference(CompletionData.java:292)
at com.intellij.codeInsight.completion.CompletionVariant.addReferenceCompletions(CompletionVariant.java:164)
at com.intellij.codeInsight.completion.CompletionData.completeReference(CompletionData.java:97)
at com.intellij.codeInsight.completion.LegacyCompletionContributor.a(LegacyCompletionContributor.java:71)
at com.intellij.codeInsight.completion.LegacyCompletionContributor.a(LegacyCompletionContributor.java:124)
at com.intellij.codeInsight.completion.LegacyCompletionContributor.processReferences(LegacyCompletionContributor.java:107)
at com.intellij.codeInsight.completion.LegacyCompletionContributor.completeReference(LegacyCompletionContributor.java:69)
at com.intellij.codeInsight.completion.LegacyCompletionContributor.fillCompletionVariants(LegacyCompletionContributor.java:52)
at com.intellij.codeInsight.completion.CompletionService.getVariantsFromContributors(CompletionService.java:81)
at com.intellij.codeInsight.completion.CompletionResultSet.runRemainingContributors(CompletionResultSet.java:132)
at com.intellij.codeInsight.completion.CompletionResultSet.runRemainingContributors(CompletionResultSet.java:125)
at com.intellij.codeInsight.template.impl.LiveTemplateCompletionContributor$2.addCompletions(LiveTemplateCompletionContributor.java:90)
at com.intellij.codeInsight.completion.CompletionProvider.addCompletionVariants(CompletionProvider.java:36)
at com.intellij.codeInsight.completion.CompletionContributor.fillCompletionVariants(CompletionContributor.java:155)
at com.intellij.codeInsight.completion.CompletionService.getVariantsFromContributors(CompletionService.java:81)
at com.intellij.codeInsight.completion.CompletionService.performCompletion(CompletionService.java:110)
at com.intellij.codeInsight.completion.CompletionProgressIndicator.a(CompletionProgressIndicator.java:776)
at com.intellij.codeInsight.completion.CompletionProgressIndicator.access$500(CompletionProgressIndicator.java:90)
at com.intellij.codeInsight.completion.CompletionProgressIndicator$1CalculateItems.run(CompletionProgressIndicator.java:758)
at com.intellij.codeInsight.completion.AsyncCompletion.a(CompletionThreading.java:87)
at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:848)
at com.intellij.codeInsight.completion.AsyncCompletion.b(CompletionThreading.java:84)
at com.intellij.openapi.progress.impl.CoreProgressManager$3.run(CoreProgressManager.java:170)
at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:494)
at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:443)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:54)
at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:155)
at com.intellij.codeInsight.completion.AsyncCompletion.a(CompletionThreading.java:82)
at com.intellij.openapi.application.impl.ApplicationImpl$2.run(ApplicationImpl.java:307)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
```
<issue_comment>username_1: Duplicate of #453, which was fixed in #454. You're the second person to report it, so I think I'll have to release 4.6.0 before all the function stuff is done so this stops affecting people on the Canary. (Plus its been over 2 months since the last release) Should be out later this week.<issue_closed>
<issue_comment>username_0: <3
btw the completion is amazing :) |
<issue_start><issue_comment>Title: Files doesn't appear on hubic web interfaces
username_0: Hi,
Everything seems to work perfectly but I don't see anything on the Hubic interfaces, folders included. Any idea?
<issue_comment>username_1: Do you upload files with hubicfuse into the folder called "default" (which exists from the start)?
<issue_comment>username_0: No, a root folder directly, I've just understood my error when I have see this default folder both on the server and hubic webinterface.
Thanks @username_1 :+1:<issue_closed> |
<issue_start><issue_comment>Title: add Kundan Singh
username_0: Be Awesome!
<issue_comment>username_1: Welcome :)!
<issue_comment>username_2: Welcome! :)
Would be cool if you could ask some questions on the other AMAs in the list (not my AMA). Especially the ones closer to the bottom of the list. I think AMAs are a great opportunity to learn from each other. Asking a question is also a good way to encourage receiving one ;)
For inspiration of what to ask, you could take a look at the questions in some other AMAs, like:
https://github.com/passy/ama/issues?q=
https://github.com/sebmck/ama/issues?q=
https://github.com/wesbos/ama/issues?q= |
<issue_start><issue_comment>Title: Bug: HTML Zooms on Touch Devices
username_0: I modified the example from [the documentation](http://photoswipe.com/documentation/custom-html-in-slides.html)
The only thing I've added is jQuery and these lines:
```
$(document).on('click', 'a', function(e) {
e.preventDefault()
});
```
On touch devices ( and Chrome DevTools with "touch emulator" turned on ) when the link is clicked that slide is then zoomed. Is there a way to disable the zoom in HTML on touch devices ?
Demo: http://codepen.io/username_0/pen/dXRKNm
<issue_comment>username_1: I have te same problem with my jAlbum PhotoSwipe skin, see this example: http://andrewolff.jalbum.net/Reestdal_PS/#&gid=1&pid=4 If you click the Play button in the upper right corner or select one of the share links in the menu, you see on an iPad that the image is zoomde after the action is finished. You don't see this effect on a PC.
I hope a solution will become available! |
<issue_start><issue_comment>Title: one-liner to support yaml comments
username_0: :bowtie:
<issue_comment>username_0: Related to https://github.com/imdone/imdone-core/issues/40
<issue_comment>username_1: Just released in imdone-atom 1.3.31. Didn't merge this because I had to do it in the "current" branch. The master branch has changes I haven't tested with the current release of imdone-atom. |
<issue_start><issue_comment>Title: Maven artifact published
username_0: It would be nice to have this on Central, because building it or manually moving jars is tedious.
<issue_comment>username_1: it's unavailable(
```An error occurred.
Sorry, the page you are looking for is currently unavailable.
Please try again later.
If you are the system administrator of this resource then you should check the error log for details.
Faithfully yours, nginx.
```
can you upload in central repositiory? |
<issue_start><issue_comment>Title: [Performance] Consider multiple inputNodes
username_0: The following pattern is quite common:
```js
outputFile = concat(merge(manyTrees));
```
some real examples:
* https://github.com/emberjs/emberjs-build/blob/master/lib/concatenate-es6-modules.js#L77
* https://github.com/emberjs/emberjs-build/blob/fa7b8c0b063384f2155159b96dc363f9dd27cf95/lib/build-cjs-tree.js#L13
* https://github.com/emberjs/emberjs-build/blob/fa7b8c0b063384f2155159b96dc363f9dd27cf95/lib/get-build-runtime-tree.js#L51
* https://github.com/emberjs/emberjs-build/blob/fa7b8c0b063384f2155159b96dc363f9dd27cf95/lib/get-build-template-compiler-tree.js#L47
ember.js build slow trees:
```js
Build successful - 825ms.
Slowest Trees | Total
----------------------------------------------+---------------------
ConcatWithMaps | 130ms
BroccoliMergeTrees | 85ms
BroccoliMergeTrees | 74ms
BroccoliMergeTrees | 58ms
BroccoliMergeTrees | 44ms
Slowest Trees (cumulative) | Total (avg)
----------------------------------------------+---------------------
BroccoliMergeTrees (34) | 433ms (12 ms)
ConcatWithMaps (8) | 175ms (21 ms)
Babel (19) | 77ms (4 ms)
```
Now obviously mergeTrees can be made much faster
1. short term: https://github.com/hjdivad/broccoli-merge-trees/tree/merge-using-fs-tree-diff (persistentOutput + patch based management)
2. long term, mergeTree merely mutating some internal state object in broccoli.
But even given the work that can be done to improve mergeTrees, it appears that maybe the missing piece is `concat` not handling multiple inputNodes.
–––
I would like to propose concat learning a simple right to left merge, given higher precedents to files in the right most inputNodes.
```js
var outputFile = concat([lowest, middle, highest]);
```
<issue_comment>username_1: :+1:
<issue_comment>username_2: This sounds good to me.
<issue_comment>username_0: I think I once again prefer this being handle by a more aggressive cross plugin broccoli level optimization. Closing for now, I may revisit.<issue_closed> |
<issue_start><issue_comment>Title: FIX: App crashes when password is null or tags are retrieved from parcel FIXES #25
username_0: - Check for null password and navigate to PasswordActivity if true. When app permissions are
revoked manually, the password in the memory is lost and the app crashes.
- Pass note to NoteContent.FromString. Tags are passed to NoteContent instead of note that cause
the tags to be null when read from parcel.
<issue_comment>username_1: LGTM. Thanks for fixing this!
Just an advice for next PR. You don't have to make new PR for each update. If you do, `git push --force` the PR will automatically update itself. So for example. for this issue you created 3 PRs, you could have just force pushed each time and the original PR would have updated itself. Me or @akshatgoel can help you out with that in future if you like.
@akshatgoel : Can you please take a look as well, make the build and do a quick-run? I currently don't have Android environment setup and it can take a while otherwise. If everything looks good from your end too, its all good for merge.
<issue_comment>username_0: Great. Thanks for the advice. |