data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | Expose a few low-level helper routings for setting up vfio_pci_device
structs. These routines will be used in a subsequent commit to assert
that VFIO_GROUP_GET_DEVICE_FD fails under certain conditions.
Signed-off-by: David Matlack <dmatlack@google.com>
---
.../lib/include/libvfio/vfio_pci_device.h | 5 +++
.../s... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 29 Jan 2026 21:25:07 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | Verify that opening a VFIO device through its cdev file and via
VFIO_GROUP_GET_DEVICE_FD both fail with -EBUSY if the device was
preserved across a Live Update. When a device file is preserve across a
Live Update, the file must be retrieved from /dev/liveupdate, not from
VFIO directly.
Signed-off-by: David Matlack <dm... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 29 Jan 2026 21:25:08 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | Add a long-running DMA memcpy operation to
vfio_pci_liveupdate_kexec_test so that the device attempts to perform
DMAs continuously during the Live Update.
At this point iommufd preservation is not supported and bus mastering is
not kept enabled on the device during across the kexec, so most of these
DMAs will be dropp... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 29 Jan 2026 21:25:09 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | From: Vipin Sharma <vipinsh@google.com>
Add a selftest to exercise preserving a vfio-pci device across a Live
Update. For now the test is extremely simple and just verifies that the
device file can be preserved and retrieved. In the future this test will
be extended to verify more parts about device preservation as th... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 29 Jan 2026 21:25:05 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | Hi David,
On Thu, 29 Jan 2026 21:24:57 +0000
David Matlack <dmatlack@google.com> wrote:
Just wondering what happened to skipping the bus master clearing. I
understand this version does not preserve the device itself yet; I’m
just curious whether there were specific difficulties that led to
dropping the earlier patch ... | {
"author": "Jacob Pan <jacob.pan@linux.microsoft.com>",
"date": "Thu, 29 Jan 2026 14:21:58 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-01-29 02:21 PM, Jacob Pan wrote:
Hi Jacob,
There's several places where bus master gets cleared that we need to
eventually eliminate to fully preserve the device.
1. vfio_pci_liveupdate_freeze() clears it during shutdown when it
restores vdev->pci_saved_state.
2. pci_device_shutdown() clears it during... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 29 Jan 2026 22:33:13 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | Hi David,
On Thu, 29 Jan 2026 22:33:13 +0000
David Matlack <dmatlack@google.com> wrote:
I was just asking about (3) and trying to understand the asymmetric
handling compared to reset. I don’t have a strong preference since this
is temporary—thanks for the explanation.
I’ve been testing my noiommu cdev patches on to... | {
"author": "Jacob Pan <jacob.pan@linux.microsoft.com>",
"date": "Thu, 29 Jan 2026 16:31:50 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | 在 2026/1/29 13:24, David Matlack 写道:
Can the above 2 functions support the virtual devices? For example,
bonding, veth, iSWAP and RXE.
These virtual devices do not have BDF. As such, I am not sure if your
patches take these virtual devices in to account.
Thanks a lot.
Zhu Yanjun
--
Best Regards,
Yanjun.Zhu | {
"author": "Zhu Yanjun <yanjun.zhu@linux.dev>",
"date": "Sat, 31 Jan 2026 22:38:18 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Sat, Jan 31, 2026 at 10:38 PM Zhu Yanjun <yanjun.zhu@linux.dev> wrote:
No this patch series only supports PCI devices, since those are the
only devices so far we've needed to support.
I am not familiar with any of the devices that you mentioned. If they
are virtual then does that mean it's all just software? In th... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Mon, 2 Feb 2026 10:14:56 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2/2/26 10:14 AM, David Matlack wrote:
Bonding, veth, rxe, and siw can be used in KVM environments.
Although these are software-only virtual devices with no associated
hardware,
they may maintain state that is observable by userspace.
As a result, Live Update should preserve their state across the update.
Zhu Y... | {
"author": "\"Yanjun.Zhu\" <yanjun.zhu@linux.dev>",
"date": "Tue, 3 Feb 2026 16:10:04 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 1/29/26 1:24 PM, David Matlack wrote:
813 int liveupdate_register_file_handler(struct liveupdate_file_handler *fh)
814 {
815 struct liveupdate_file_handler *fh_iter;
816 int err;
817
818 if (!liveupdate_enabled())
819 return -EOPNOTSUPP;
In the function liveupdate_register_f... | {
"author": "\"Yanjun.Zhu\" <yanjun.zhu@linux.dev>",
"date": "Fri, 6 Feb 2026 14:37:45 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-06 02:37 PM, Yanjun.Zhu wrote:
Yeah that is a bit odd. I see that memfd_luo_init() just checks for
-EOPNOTSUPP. We can do the same thing here. | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Fri, 6 Feb 2026 23:14:46 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Tue, Feb 3, 2026 at 4:10 PM Yanjun.Zhu <yanjun.zhu@linux.dev> wrote:
Sorry for taking so long to get back to you.
Userspace should serialize the state of those devices out of the
kernel, persist it in memory or on disk across Live Update, and then
recreate it after Live Update.
This is why, for example, KVM does ... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Fri, 20 Feb 2026 11:03:18 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:49PM +0000, David Matlack wrote:
nit: Preserve and Unpreserve can only be done from outgoing kernel, maybe
remove the "outgoing" from the function name.
This will not work for SRIOV as new devices will be registered when
sriov is enabled and the max will increase. As we are not handling ... | {
"author": "Samiullah Khawaja <skhawaja@google.com>",
"date": "Mon, 23 Feb 2026 22:04:51 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:52PM +0000, David Matlack wrote:
Reviewed-by: Samiullah Khawaja <skhawaja@google.com> | {
"author": "Samiullah Khawaja <skhawaja@google.com>",
"date": "Mon, 23 Feb 2026 22:29:03 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Mon, Feb 23, 2026 at 2:04 PM Samiullah Khawaja <skhawaja@google.com> wrote:
That's reasonable, I can make that change in v3.
That's right. Since this series does not support VFs
(pci_liveupdate_outgoing_preserve(VF) will return -EINVAL), I dropped
the logic from v1 that included the maximum possible number of VF... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Mon, 23 Feb 2026 15:08:19 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:53PM +0000, David Matlack wrote:
Reviewed-by: Samiullah Khawaja <skhawaja@google.com> | {
"author": "Samiullah Khawaja <skhawaja@google.com>",
"date": "Mon, 23 Feb 2026 23:27:35 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Mon, Feb 23, 2026 at 03:08:19PM -0800, David Matlack wrote:
I should have added it earlier, but the same applies to the
pci_liveupdate_incoming_finish() as it can only be done with incoming
kernel. Maybe we can remove incoming from it also for consistency? | {
"author": "Samiullah Khawaja <skhawaja@google.com>",
"date": "Mon, 23 Feb 2026 23:43:42 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Mon, Feb 23, 2026 at 3:43 PM Samiullah Khawaja <skhawaja@google.com> wrote:
Yeah I can make that change as well.
I was erring on the side of being overly explicity with the
incoming/outgoing terminology, but I agree it's unnecessary in these
APIs. | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Mon, 23 Feb 2026 16:00:56 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:48PM +0000, David Matlack wrote:
Reviewed-by: Pranjal Shrivastava <praan@google.com> | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Tue, 24 Feb 2026 08:26:08 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:49PM +0000, David Matlack wrote:
Nit: Should these be 2026 now?
I'm wondering how (or if) this handles hot-plugged devices?
max_nr_devices is calculated based on for_each_pci_dev at the time of
the first preservation.. what happens if a device is hotplugged after
the first device is pre... | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Tue, 24 Feb 2026 09:17:48 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:50PM +0000, David Matlack wrote:
Following the comment on Patch 2 regarding propagating errors, the check
if (pci_liveupdate_incoming_nr_devices()) should be made explicit to
distinguish between "Preservation Active" and "Retrieval Failed".
Looks like we over-ride the pci=assign-busses... | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Tue, 24 Feb 2026 09:36:03 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Fri, Feb 06, 2026 at 11:14:46PM +0000, David Matlack wrote:
If we move to checking the return value for -EOPNOTSUPP, we should
ensure the pattern is consistent for the upcoming PCI registration in
Patch 7 as well. With this addressed:
Reviewed-by: Pranjal Shrivastava <praan@google.com>
Thanks,
Praan | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Tue, 24 Feb 2026 09:58:55 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:48PM +0000, David Matlack wrote:
Reviewed-by: Samiullah Khawaja <skhawaja@google.com> | {
"author": "Samiullah Khawaja <skhawaja@google.com>",
"date": "Tue, 24 Feb 2026 17:08:11 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Tue, Feb 24, 2026 at 1:18 AM Pranjal Shrivastava <praan@google.com> wrote:
Yes! Thanks for catching that.
Yes, it's possible to run out space to preserve devices if devices are
hot-plugged and then preserved. But I think it's better to defer
handling such a use-case exists (unless you see an obvious simple
soluti... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Tue, 24 Feb 2026 09:33:28 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Tue, Feb 24, 2026 at 1:36 AM Pranjal Shrivastava <praan@google.com> wrote:
As mentioned in the previous patch, the errors mean "no incoming
devices" rather than "retrieval failed".
Good call, I'll add a log message and update kernel-parameters.txt in v3. | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Tue, 24 Feb 2026 09:36:50 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:52PM +0000, David Matlack wrote:
I see the 'Eventually both of these should be dropped' comment,
which acknowledges that a reset is a v1 crutch. However, I wanted to
clarify the fallback strategy here.
If vdev->reset_works is false, we skip the reset but still jump into the
new kernel. F... | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Tue, 24 Feb 2026 18:37:58 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Tue, Feb 24, 2026 at 09:33:28AM -0800, David Matlack wrote:
Ack. If we aren't supporting preservation for hot-plug at this point.
Let's mention that somewhere? Maybe just a little comment or the kdoc?
I agree, the snippet was just an example. What I'm trying to say here
is, what if the retval is -ENOMEM / -ENODAT... | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Tue, 24 Feb 2026 19:02:56 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Tue, Feb 24, 2026 at 07:02:56PM +0000, Pranjal Shrivastava wrote:
The flb_retrive_one seems to call:
err = flb->ops->retrieve(&args);
which could be anything honestly.. since the luo_core doesn't scream
about it, maybe the caller should?
Thanks,
Praan | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Tue, 24 Feb 2026 19:05:41 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Tue, Feb 24, 2026 at 10:38 AM Pranjal Shrivastava <praan@google.com> wrote:
That situation is already possible today. Simply use a VFIO device
that does not support reset, close it, and then kexec into a new
kernel. vfio_pci_core_disable() (which runs when the last reference to
the VFIO device file is dropped) als... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Tue, 24 Feb 2026 11:16:55 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:53PM +0000, David Matlack wrote:
The use of anon_inode_getfile_fmode() is clever! The abstraction is
clean as well.
Reviewed-by: Pranjal Shrivastava <praan@google.com>
Thanks!
Praan | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Tue, 24 Feb 2026 19:19:30 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:54PM +0000, David Matlack wrote:
Nit: We might need to handle the retval here if we remove the
liveupdate_enabled() check above (as discussed in patch 2).
same here.
Reviewed-by: Pranjal Shrivastava <praan@google.com>
Thanks,
Praan | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Wed, 25 Feb 2026 07:55:51 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:55PM +0000, David Matlack wrote:
Reviewed-by: Pranjal Shrivastava <praan@google.com>
Thanks,
Praan | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Wed, 25 Feb 2026 08:03:18 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:56PM +0000, David Matlack wrote:
Since we set this to NULL in the success path of vfio_pci_core_enable()
I'm wondering if a failure in vfio_pci_core_enable could cause a
resource leak? Because vfio_pci_liveupdate_can_finish() returns false
as long as that pointer is valid, a single device... | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Wed, 25 Feb 2026 08:38:02 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, 29 Jan 2026 21:24:51 +0000
David Matlack <dmatlack@google.com> wrote:
...
liveupdate_register_file_handler() "pins" vfio-pci with a
try_module_get(). Since this is done in our module_init function and
unregister occurs in our module_exit function, rather than relative
to any actual device binding or usage, th... | {
"author": "Alex Williamson <alex@shazbot.org>",
"date": "Wed, 25 Feb 2026 14:33:28 -0700",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Wed, Feb 25, 2026 at 02:33:28PM -0700, Alex Williamson wrote:
Hmm... IIUC the concern here is about liveupdate policy if the user
wants to unload a module which was previously marked for preservation?
AFAICT, In such a case, the user is expected to close the LUO session FD,
which "unpreserves" the FD. Finally, wh... | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Wed, 25 Feb 2026 22:06:18 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Wed, Feb 25, 2026 at 10:06:18PM +0000, Pranjal Shrivastava wrote:
Ohh wait, You're right, Alex. I just realized the __exit won't even be
reached because of the internal pin. The current implementation creates
a catch-22 where the module pins itself during init and can't reach the
unregister call in exit. I believe... | {
"author": "Pranjal Shrivastava <praan@google.com>",
"date": "Wed, 25 Feb 2026 22:29:41 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, 29 Jan 2026 21:24:52 +0000
David Matlack <dmatlack@google.com> wrote:
Why can't we use vfio_device_cdev_opened() here and avoid all the new
exposure in public headers?
struct vfio_device *device = vfio_device_from_file(file);
... | {
"author": "Alex Williamson <alex@shazbot.org>",
"date": "Wed, 25 Feb 2026 15:41:24 -0700",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:49PM +0000, David Matlack wrote:
I'd probably describe this in the "outgoing ... incoming" order since
that's the order of operation.
In what sense is this "global"? I assume it doesn't mean global
scope; does it mean something that persists across the kexec?
IIUC this is basically a... | {
"author": "Bjorn Helgaas <helgaas@kernel.org>",
"date": "Wed, 25 Feb 2026 16:46:51 -0600",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, Jan 29, 2026 at 09:24:50PM +0000, David Matlack wrote:
I think changing bus numbers would break DMA regardless of whether an
IOMMU is involved. Completions carrying the data for DMA reads are
routed back to the Requester ID of the read. | {
"author": "Bjorn Helgaas <helgaas@kernel.org>",
"date": "Wed, 25 Feb 2026 16:47:46 -0600",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Wed, Feb 25, 2026 at 2:29 PM Pranjal Shrivastava <praan@google.com> wrote:
If we don't do try_module_get during registration, the registered file
handler can go away on module unload while LUO is using the handler
during FD preservation. This makes it racy. Maybe register/unregister
need to move outside the module_... | {
"author": "Samiullah Khawaja <skhawaja@google.com>",
"date": "Wed, 25 Feb 2026 14:50:47 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-25 02:33 PM, Alex Williamson wrote:
Good point. So a better approach that would allow vfio-pci to be
unloaded would be to register the file handler when the number of
devices bound to vfio-pci goes from 0->1 and then unregister on 1->0. | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Wed, 25 Feb 2026 23:15:43 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-25 04:47 PM, Bjorn Helgaas wrote:
Ahh, makes sense. I'll clarify the commit message in the next version. | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Wed, 25 Feb 2026 23:20:10 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-25 03:41 PM, Alex Williamson wrote:
I thought I explored using vfio_device_cdev_opened() but I can't
remember now why I went with df->group. Maybe there wasn't a good
reason. I'll switch to vfio_device_cdev_opened() in the next version.
Will do.
I can change this to a try-lock and return an error if ta... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Wed, 25 Feb 2026 23:41:04 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Wed, Feb 25, 2026 at 3:15 PM David Matlack <dmatlack@google.com> wrote:
Yeah maybe a kref that gets inc/dec in probe/remove. I have a similar
problem with iommufd preservation, but I think I can handle it based
on the number of iommufd open.
I am wondering whether this file handler registration kref stuff can
be m... | {
"author": "Samiullah Khawaja <skhawaja@google.com>",
"date": "Wed, 25 Feb 2026 15:54:47 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-25 04:46 PM, Bjorn Helgaas wrote:
Will do.
Global in the sense that there is only one struct pci_ser in the system.
There is no global variable for it though. It is created
pci_flb_preserve() when the first device is preserved (and destroyed
after the last device is unpreserved/cancelled).
So it's lifecy... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 26 Feb 2026 00:28:28 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Tue, Feb 24, 2026 at 11:56 PM Pranjal Shrivastava <praan@google.com> wrote:
I think you mean for the below call to pci_liveupdate_register_fh(),
but yes agreed :). | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Wed, 25 Feb 2026 16:45:52 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Wed, Feb 25, 2026 at 12:38 AM Pranjal Shrivastava <praan@google.com> wrote:
LIVEUPDATE_SESSION_FINISH will also perpetually fail if userspace
never calls ioctl(VFIO_DEVICE_BIND_IOMMUFD) (which is what triggers
vfio_pci_core_enable()). Or if that ioctl fails before it gets to
vfio_pci_core_enable().
It's not a gre... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Wed, 25 Feb 2026 16:51:47 -0800",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Wed, Feb 25, 2026 at 11:20:10PM +0000, David Matlack wrote:
More broadly you can't shouldn't the fabric topology while Memory
Enable is active.
Renumbering or readdressing the fabric requires disabling and flushing
any memory transactions.
is expected to hitlesslly continue performing memory operations.
That may... | {
"author": "Jason Gunthorpe <jgg@nvidia.com>",
"date": "Thu, 26 Feb 2026 10:40:57 -0400",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, 29 Jan 2026 21:24:53 +0000
David Matlack <dmatlack@google.com> wrote:
I really dislike that we're exporting the underscore variant, which
implies it's an internal function that the caller should understand the
constraints, without outlining any constraints.
I'm not sure what a good alternative is. We can dr... | {
"author": "Alex Williamson <alex@shazbot.org>",
"date": "Thu, 26 Feb 2026 15:52:22 -0700",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, 29 Jan 2026 21:24:54 +0000
David Matlack <dmatlack@google.com> wrote:
Why do we get to ignore the return value here?
This is propagation of a poor API choice in liveupdate, the unregister
should return void, it shouldn't be allowed to fail, IMO. Thanks,
Alex | {
"author": "Alex Williamson <alex@shazbot.org>",
"date": "Thu, 26 Feb 2026 16:03:53 -0700",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, 29 Jan 2026 21:24:55 +0000
David Matlack <dmatlack@google.com> wrote:
Is this an EPERM issue then?
Why does this need to be in the public header versus
drivers/vfio/vfio.h? | {
"author": "Alex Williamson <alex@shazbot.org>",
"date": "Thu, 26 Feb 2026 16:15:12 -0700",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-26 04:15 PM, Alex Williamson wrote:
I was thinking EBUSY in the sense that the device is only temporarily
inaccesible through this interface due it being in a preserved state as
part of a Live Update. Once the preserved device file is retreived and
closed, the device can be accessed again through
VFIO_GROU... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 26 Feb 2026 23:27:47 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-26 04:03 PM, Alex Williamson wrote:
Ugh, we do not. This is a bug, thanks for catching.
Ack. I'll make pci_liveupdate_unregister_fh() unable to fail and follow
up with the maintainers of LUO about liveupdate_unregister_flb(). | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 26 Feb 2026 23:31:43 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-26 03:52 PM, Alex Williamson wrote:
Ack. Due to the bug you pointed out below, I think the changes in this
file will look fairly different in the next version. But no matter what
I'll avoid exporting a underscore variant without outlining the
constraints.
Yes indeed. In that case I think we need to call
... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Thu, 26 Feb 2026 23:40:41 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, 26 Feb 2026 23:27:47 +0000
David Matlack <dmatlack@google.com> wrote:
Ok, fair explanation. Thanks,
Alex | {
"author": "Alex Williamson <alex@shazbot.org>",
"date": "Thu, 26 Feb 2026 16:42:36 -0700",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Thu, 29 Jan 2026 21:24:57 +0000
David Matlack <dmatlack@google.com> wrote:
This could maybe be incrementally cleaner in a
int vfio_pci_core_probe_reset(struct vfio_pci_core_device *vdev)
helper.
Isn't this a problem too? In the first kernel we store the initial,
post reset state of the device, now we're storing... | {
"author": "Alex Williamson <alex@shazbot.org>",
"date": "Thu, 26 Feb 2026 17:00:30 -0700",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On 2026-02-26 05:00 PM, Alex Williamson wrote:
Will do.
The previous kernel resets the device and restores it back to its
post reset state in vfio_pci_liveupdate_freeze() before handing off
control to the next kernel. So my intention here is that VFIO will
receive the device in that state, allowing it to call
pci_s... | {
"author": "David Matlack <dmatlack@google.com>",
"date": "Fri, 27 Feb 2026 00:51:18 +0000",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | This series can be found on GitHub:
https://github.com/dmatlack/linux/tree/liveupdate/vfio/cdev/v2
This series adds the base support to preserve a VFIO device file across
a Live Update. "Base support" means that this allows userspace to
safely preserve a VFIO device file with LIVEUPDATE_SESSION_PRESERVE_FD
and retr... | null | null | null | [PATCH v2 00/22] vfio/pci: Base Live Update support for VFIO device files | On Fri, 27 Feb 2026 00:51:18 +0000
David Matlack <dmatlack@google.com> wrote:
I appreciate reviewing this in smaller chunks, but how does userspace
know whether the kernel contains a stub implementation of liveupdate or
behaves according to the end goal?
Also, didn't we violate our own contract in this patch by addi... | {
"author": "Alex Williamson <alex@shazbot.org>",
"date": "Fri, 27 Feb 2026 08:46:58 -0700",
"is_openbsd": false,
"thread_id": "20260227084658.3767d801@shazbot.org.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Ahead of introducing I2C-adapter-specific printk() helpers, preemptively
avoid a conflict with the upcoming i2c_dbg() and rename the local macro
in the saa7134 driver to saa7134_i2c_dbg().
Suggested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:30 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Add a set of i2c-specific printk helpers that wrap their device-level
counterparts and hide the dereferencing of struct device embedded in
struct i2c_adapter. This is done in order to allow moving this struct
device out of struct i2c_adapter into memory managed by i2c core.
Signed-off-by: Bartosz Golaszewski <bartosz.... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:31 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Acked-by: Chen-Yu Tsai <wens@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-sun6i-p2wi.c |... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:32 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-mlxbf.c | 19 +++++++++----------
1 file changed, 9 ins... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:33 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-isch.c | 32 ++++++++++++++++----------------
1 file ch... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:34 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-scmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 d... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:36 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-ali1535.c | 20 ++++++++++----------
1 file changed, 10... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:35 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-ali15x3.c | 20 ++++++++++----------
1 file changed, 10... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:37 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-powermac.c | 26 +++++++++++++-------------
1 file chan... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:38 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-owl.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:39 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-nforce2.c | 14 +++++++-------
1 file changed, 7 insert... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:40 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-amd756.c | 24 ++++++++++++------------
1 file changed,... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:41 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Convert all instances of using device printk helpers with struct device
embedded in struct i2c_adapter to the new i2c-specific macros that hide
that dereference.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-piix4.c | 8 ++++----
1 file changed, 4 insertions(+), ... | {
"author": "Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>",
"date": "Mon, 23 Feb 2026 09:59:42 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | On Mon, Feb 23, 2026 at 09:59:29AM +0100, Bartosz Golaszewski wrote:
I applied the series to for-current but squashed the user conversions
into patch 1. Changes are trivial enough and I don't want the pull
request to look excessive, so it can go in smoothly. Hope you are fine
with it. | {
"author": "Wolfram Sang <wsa+renesas@sang-engineering.com>",
"date": "Thu, 26 Feb 2026 21:21:35 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | On Thu, 26 Feb 2026 21:21:35 +0100, Wolfram Sang
<wsa+renesas@sang-engineering.com> said:
Sure, do you still want me to send these changes in separate patches for
review?
Bart | {
"author": "Bartosz Golaszewski <brgl@kernel.org>",
"date": "Fri, 27 Feb 2026 00:38:23 -0800",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | On Mon, Feb 23, 2026 at 09:59:29AM +0100, Bartosz Golaszewski wrote:
Again, this is not the way to do this. You don't need to wrap every
access to struct device in random subsystem specific helpers to address
the lifetime issues. You're just creating a big mess here for no good
reason.
I asked you to show where you t... | {
"author": "Johan Hovold <johan@kernel.org>",
"date": "Fri, 27 Feb 2026 09:58:27 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | Johan,
I did think again and do not see a way how the life cycle problems can
be solved while drivers happily access the device struct of the adapter.
Whatever the solution to the core problem is (revocable, custom SRCU,
something else), I still think this step is needed in any case. If I am
wrong with this opinion, ... | {
"author": "Wolfram Sang <wsa+renesas@sang-engineering.com>",
"date": "Fri, 27 Feb 2026 10:08:34 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | On Fri, Feb 27, 2026 at 10:08:34AM +0100, Wolfram Sang wrote:
There's nothing special about the struct device. What matters is that
drivers don't free memory that's still in use by the core.
It's not even about revocable or SRCU, that's just an implementation
detail.
It seems all that is needed is to decouple the ... | {
"author": "Johan Hovold <johan@kernel.org>",
"date": "Fri, 27 Feb 2026 11:05:25 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | On Fri, Feb 27, 2026 at 11:06 AM Johan Hovold <johan@kernel.org> wrote:
I feel like we've discussed it already under v1 or elsewhere.
This is a weird pattern you sometimes see where a driver allocates
something and passes the ownership to the subsystem. This often
causes confusion among driver authors, who logically... | {
"author": "Bartosz Golaszewski <brgl@kernel.org>",
"date": "Fri, 27 Feb 2026 16:42:09 +0100",
"is_openbsd": false,
"thread_id": "CAMRc=MfcvD1nJy=zpoCkSkJq6WjyXQxFUZ4QE6vyCS+XFCn5AA@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | This reverts commit 1366cd228b0c67b60a2c0c26ef37fe9f7cfedb7f.
The fwnode_usb_role_switch_get() returns NULL only if no connection is
found, returns ERR_PTR(-EPROBE_DEFER) if connection is found but deferred
probe is needed, or a valid pointer of usb_role_switch.
When switching from NULL check to IS_ERR_OR_NULL(), usb... | null | null | null | [PATCH] Revert "tcpm: allow looking for role_sw device in the main node" | Hi,
Le 24/02/2026 à 12:01, Xu Yang a écrit :
I believe a plain revert isn't the right solution here, as we'll get to
the same point as we were before 1366cd228b0c, where some devices
stopped working properly with newer kernels.
It might be worth saving the error and restoring it after the call to
usb_role_switch... | {
"author": "Arnaud Ferraris <arnaud.ferraris@collabora.com>",
"date": "Tue, 24 Feb 2026 12:33:33 +0100",
"is_openbsd": false,
"thread_id": "073cbeb3-04a8-4b26-a7b6-ef0b7654c34c@collabora.com.mbox.gz"
} |
lkml_critique | lkml | This reverts commit 1366cd228b0c67b60a2c0c26ef37fe9f7cfedb7f.
The fwnode_usb_role_switch_get() returns NULL only if no connection is
found, returns ERR_PTR(-EPROBE_DEFER) if connection is found but deferred
probe is needed, or a valid pointer of usb_role_switch.
When switching from NULL check to IS_ERR_OR_NULL(), usb... | null | null | null | [PATCH] Revert "tcpm: allow looking for role_sw device in the main node" | Hi Arnaud,
On Tue, Feb 24, 2026 at 12:33:33PM +0100, Arnaud Ferraris wrote:
I don't think 1366cd228b0c fix the real root problem because the description
should be wrong in the commit message. If -EPROBE_DEFER is returned by
fwnode_usb_role_switch_get(), the ports node should be in connector node
instead of tcpc node.... | {
"author": "Xu Yang <xu.yang_2@nxp.com>",
"date": "Wed, 25 Feb 2026 10:57:47 +0800",
"is_openbsd": false,
"thread_id": "073cbeb3-04a8-4b26-a7b6-ef0b7654c34c@collabora.com.mbox.gz"
} |
lkml_critique | lkml | This reverts commit 1366cd228b0c67b60a2c0c26ef37fe9f7cfedb7f.
The fwnode_usb_role_switch_get() returns NULL only if no connection is
found, returns ERR_PTR(-EPROBE_DEFER) if connection is found but deferred
probe is needed, or a valid pointer of usb_role_switch.
When switching from NULL check to IS_ERR_OR_NULL(), usb... | null | null | null | [PATCH] Revert "tcpm: allow looking for role_sw device in the main node" | Hi Xu,
Le 25/02/2026 à 03:57, Xu Yang a écrit :
Sure, I'll come up with more details asap, either tomorrow or early next
week.
Best regards,
Arnaud | {
"author": "Arnaud Ferraris <arnaud.ferraris@collabora.com>",
"date": "Fri, 27 Feb 2026 16:45:30 +0100",
"is_openbsd": false,
"thread_id": "073cbeb3-04a8-4b26-a7b6-ef0b7654c34c@collabora.com.mbox.gz"
} |
lkml_critique | lkml | There are some clocks where the rounding is managed by the hardware, and
the determine_rate() clk ops is just a noop that simply returns 0. Based
on discussions with Stephen at Linux Plumbers Conference, he suggested
adding a flag for this particular case. So let's add a new flag, and
update the clk core so that the de... | null | null | null | [PATCH 00/13] clk: add new flag CLK_ROUNDING_FW_MANAGED | Hi Biju,
On Fri, Feb 27, 2026 at 03:23:19PM +0000, Biju Das wrote:
OK. So how do you all want to proceed here?
Do you want to fill out the determine rate in this driver? If so, we can
just drop this particular patch from this series.
Since the PLL is capable of any frequency, do you want to keep the empty
determine... | {
"author": "Brian Masney <bmasney@redhat.com>",
"date": "Fri, 27 Feb 2026 10:48:15 -0500",
"is_openbsd": false,
"thread_id": "aaG8v-y9UqsgOZxy@redhat.com.mbox.gz"
} |
lkml_critique | lkml | Qualcomm kaanapali platform have a newer generation of video IP iris4.
The hardware have evolved mostly with respect to higher number of power
domains as well as multiple clock sources.
Considering iris as a client driver, it adds the handling for multiple
stream ids from VPU via iommu-map.
This series is depend o... | null | null | null | [PATCH v2 0/7] media: iris: add support for kaanapali platform | On 27/02/2026 15:11, Vikash Garodia wrote:
How many copies do you want of this? Data definition never goes to
headers. That's standard C rules.
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 16:48:31 +0100",
"is_openbsd": false,
"thread_id": "20257f68-04cf-40fa-9f0b-bd798e62b7eb@kernel.org.mbox.gz"
} |
lkml_critique | lkml | Qualcomm kaanapali platform have a newer generation of video IP iris4.
The hardware have evolved mostly with respect to higher number of power
domains as well as multiple clock sources.
Considering iris as a client driver, it adds the handling for multiple
stream ids from VPU via iommu-map.
This series is depend o... | null | null | null | [PATCH v2 0/7] media: iris: add support for kaanapali platform | On 27/02/2026 15:11, Vikash Garodia wrote:
Apply this patch and build it. Does it build?
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 16:49:52 +0100",
"is_openbsd": false,
"thread_id": "20257f68-04cf-40fa-9f0b-bd798e62b7eb@kernel.org.mbox.gz"
} |
lkml_critique | lkml | Qualcomm kaanapali platform have a newer generation of video IP iris4.
The hardware have evolved mostly with respect to higher number of power
domains as well as multiple clock sources.
Considering iris as a client driver, it adds the handling for multiple
stream ids from VPU via iommu-map.
This series is depend o... | null | null | null | [PATCH v2 0/7] media: iris: add support for kaanapali platform | On 27/02/2026 15:11, Vikash Garodia wrote:
I cannot really parse above.
You don't need definitions.
Drop description, pointless. How does it help anyhow in writing DTS?
This solves nothing from the discussions we had. I re-iterated multiple
times, plus there were internal threads doing the same, that you need to... | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 16:50:30 +0100",
"is_openbsd": false,
"thread_id": "20257f68-04cf-40fa-9f0b-bd798e62b7eb@kernel.org.mbox.gz"
} |
lkml_critique | lkml | Fix checkpatch.pl warnings by adding comments to mutex and spinlocks,
and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greyb... | null | null | null | [PATCH 1/2] staging: greybus: uart: fix style issues | Replace the deprecated IDR API with the more modern XArray API.
This simplifies the code and improves efficiency.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/sta... | {
"author": "Shubham Chakraborty <chakrabortyshubham66@gmail.com>",
"date": "Thu, 26 Feb 2026 00:08:36 +0530",
"is_openbsd": false,
"thread_id": "20260227154839.7866-1-chakrabortyshubham66@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Fix checkpatch.pl warnings by adding comments to mutex and spinlocks,
and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greyb... | null | null | null | [PATCH 1/2] staging: greybus: uart: fix style issues | On Thu, Feb 26, 2026 at 12:08:35AM +0530, Shubham Chakraborty wrote:
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and ov... | {
"author": "Greg Kroah-Hartman <gregkh@linuxfoundation.org>",
"date": "Wed, 25 Feb 2026 10:43:12 -0800",
"is_openbsd": false,
"thread_id": "20260227154839.7866-1-chakrabortyshubham66@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Fix checkpatch.pl warnings by adding comments to mutex and spinlocks,
and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greyb... | null | null | null | [PATCH 1/2] staging: greybus: uart: fix style issues | On Thu, Feb 26, 2026 at 12:08:36AM +0530, Shubham Chakraborty wrote:
This really isn't needed, sorry, it doesn't improve any "efficiency" and
I think I've rejected this change in the past as well.
It's just a simple minor number, an idr is just fine for it.
thanks,
greg k-h | {
"author": "Greg Kroah-Hartman <gregkh@linuxfoundation.org>",
"date": "Wed, 25 Feb 2026 10:47:42 -0800",
"is_openbsd": false,
"thread_id": "20260227154839.7866-1-chakrabortyshubham66@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Fix checkpatch.pl warnings by adding comments to mutex and spinlocks,
and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greyb... | null | null | null | [PATCH 1/2] staging: greybus: uart: fix style issues | On Thu, Feb 26, 2026 at 12:08:35AM +0530, Shubham Chakraborty wrote:
This is really vague, but I wouldn't say it was accurate.
Also really vague. What does "operations" mean in this context?
But word "write" is correct at least.
This comment is doesn't really add any value.
regards,
dan carpenter | {
"author": "Dan Carpenter <dan.carpenter@linaro.org>",
"date": "Thu, 26 Feb 2026 10:59:19 +0300",
"is_openbsd": false,
"thread_id": "20260227154839.7866-1-chakrabortyshubham66@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Fix checkpatch.pl warnings by adding comments to mutex and spinlocks,
and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greyb... | null | null | null | [PATCH 1/2] staging: greybus: uart: fix style issues | Hi Dan,
Thanks for the review.
You're right, the comments are too vague and don't add much value.
I'll review what the locks actually protect and resend with more
specific documentation, or drop the patch if it doesn't improve clarity.
Thanks,
Shubham | {
"author": "Shubham Chakraborty <chakrabortyshubham66@gmail.com>",
"date": "Thu, 26 Feb 2026 23:28:11 +0530",
"is_openbsd": false,
"thread_id": "20260227154839.7866-1-chakrabortyshubham66@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Fix checkpatch.pl warnings by adding comments to mutex and spinlocks,
and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greyb... | null | null | null | [PATCH 1/2] staging: greybus: uart: fix style issues | Replace vague lock comments with specific descriptions of
what data each lock protects:
- read_lock: protects iocount and oldcount
- write_lock: protects write_fifo and credits
- mutex: protects disconnected state
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c |... | {
"author": "Shubham Chakraborty <chakrabortyshubham66@gmail.com>",
"date": "Fri, 27 Feb 2026 12:22:20 +0530",
"is_openbsd": false,
"thread_id": "20260227154839.7866-1-chakrabortyshubham66@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Fix checkpatch.pl warnings by adding comments to mutex and spinlocks,
and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greyb... | null | null | null | [PATCH 1/2] staging: greybus: uart: fix style issues | On Fri, Feb 27, 2026 at 12:22:20PM +0530, Shubham Chakraborty wrote:
When you're writing a v2 patch, you should first start from a fresh
kernel tree. This v2 assumes that we applied the v1 patch.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
To be honest, I'm likely never going to be hap... | {
"author": "Dan Carpenter <dan.carpenter@linaro.org>",
"date": "Fri, 27 Feb 2026 12:03:02 +0300",
"is_openbsd": false,
"thread_id": "20260227154839.7866-1-chakrabortyshubham66@gmail.com.mbox.gz"
} |
lkml_critique | lkml | Fix checkpatch.pl warnings by adding comments to mutex and spinlocks,
and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greyb... | null | null | null | [PATCH 1/2] staging: greybus: uart: fix style issues | Thanks for the detailed feedback. I'll do a proper audit of the
locking and the disconnect sequence before sending v3 from a fresh tree.
Regards,
Shubham Chakraborty | {
"author": "Shubham Chakraborty <chakrabortyshubham66@gmail.com>",
"date": "Fri, 27 Feb 2026 21:18:39 +0530",
"is_openbsd": false,
"thread_id": "20260227154839.7866-1-chakrabortyshubham66@gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | vntb_epf_peer_db_set() raises an MSI interrupt to notify the RC side of
a doorbell event. pci_epc_raise_irq(..., PCI_IRQ_MSI, interrupt_num)
takes a 1-based MSI interrupt number.
The ntb_hw_epf driver reserves MSI #1 for link events, so doorbells
would naturally start at MSI #2 (doorbell bit 0 -> MSI #2). However,
pci... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:46 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | ndev->db_count includes an unused doorbell slot due to the legacy extra
offset in the peer doorbell path. db_valid_mask must cover only the real
doorbell bits and exclude the unused slot.
Set db_valid_mask to BIT_ULL(db_count - 1) - 1.
Fixes: 812ce2f8d14e ("NTB: Add support for EPF PCI Non-Transparent Bridge")
Signed... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:52 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | The NTB .peer_db_set() callback may be invoked from atomic context.
pci-epf-vntb currently calls pci_epc_raise_irq() directly, but
pci_epc_raise_irq() may sleep (it takes epc->lock).
Avoid sleeping in atomic context by coalescing doorbell bits into an
atomic64 pending mask and raising MSIs from a work item. Limit the
... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:47 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | ntb_epf_peer_db_set() uses ffs(db_bits) to select a doorbell to ring.
ffs() returns a 1-based bit index (bit 0 -> 1).
Entry 0 is reserved for link events, so doorbell bit 0 must map to entry
1. However, since the initial commit 812ce2f8d14e ("NTB: Add support for
EPF PCI Non-Transparent Bridge"), the implementation ha... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:51 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | ntb_db_event() expects the vector number to be relative to the first
doorbell vector starting at 0.
pci-epf-vntb reserves vector 0 for link events and uses higher vector
indices for doorbells. By passing the raw slot index to ntb_db_event(),
it effectively assumes that doorbell 0 maps to vector 1.
However, because th... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:48 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | ntb_db_event() expects the vector number to be relative to the first
doorbell vector starting at 0.
Vector 0 is reserved for link events in the EPF driver, so doorbells
start at vector 1. However, both supported peers (ntb_hw_epf with
pci-epf-ntb, and pci-epf-vntb) have historically skipped vector 1 and
started doorbe... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:53 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | In pci-epf-vntb, db_count represents the total number of doorbell slots
exposed to the peer, including:
- slot #0 reserved for link events, and
- slot #1 historically unused (kept for compatibility).
Only the remaining slots correspond to actual doorbell bits. The current
db_valid_mask() exposes all slots as valid... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:49 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.