hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
315bdd644b306a7bac0d6a331784d855135b44af
|
diff --git a/packages/razzle/config/babel-loader/razzle-babel-loader.js b/packages/razzle/config/babel-loader/razzle-babel-loader.js
index <HASH>..<HASH> 100644
--- a/packages/razzle/config/babel-loader/razzle-babel-loader.js
+++ b/packages/razzle/config/babel-loader/razzle-babel-loader.js
@@ -232,7 +232,7 @@ module.exports = babelLoader.custom(function(babel) {
if (razzleContext.modifyBabelPreset) {
presetOptions = razzleContext.modifyBabelPreset(
merge(razzleContext.configContext, {
- options: { pluginOptions, presetOptions }
+ options: { presetOptions }
})
);
}
|
fix(razzle): fix modifyBabelPreset
|
jaredpalmer_razzle
|
train
|
js
|
73bd8a1c21daf14bc22abbfd1fb1354c2d000389
|
diff --git a/test/variadic.js b/test/variadic.js
index <HASH>..<HASH> 100644
--- a/test/variadic.js
+++ b/test/variadic.js
@@ -2,7 +2,8 @@
var assert = require('assert')
, ref = require('ref')
, ffi = require('../')
- , sprintfPtr = require('./build/Release/ffi_tests').sprintf
+ , bindings = require('bindings')({ module_root: __dirname, bindings: 'ffi_tests' })
+ , sprintfPtr = bindings.sprintf
describe('variadic arguments', function () {
|
test: use "bindings" to load the bindings for the variadic tests
|
node-ffi-napi_node-ffi-napi
|
train
|
js
|
851ffa860d1e73d23555745f41dd04971c3f4af7
|
diff --git a/geth/wrapper.py b/geth/wrapper.py
index <HASH>..<HASH> 100644
--- a/geth/wrapper.py
+++ b/geth/wrapper.py
@@ -145,6 +145,8 @@ def construct_popen_command(data_dir=None,
suffix_kwargs=None,
shh=None,
allow_insecure_unlock=None,
+ tx_pool_global_slots=None,
+ tx_pool_price_limit=None,
cache=None):
if geth_executable is None:
geth_executable = get_geth_binary_path()
@@ -249,6 +251,12 @@ def construct_popen_command(data_dir=None,
if allow_insecure_unlock:
builder.append('--allow-insecure-unlock')
+ if tx_pool_global_slots is not None:
+ builder.extend(('--txpool.globalslots', tx_pool_global_slots))
+
+ if tx_pool_price_limit is not None:
+ builder.extend(('--txpool.pricelimit', tx_pool_price_limit))
+
if cache:
builder.extend(('--cache', cache))
|
feat: tx pool args (#<I>)
* feat: tx pool args
* fix: single quotes
|
ethereum_py-geth
|
train
|
py
|
b071b66b453f55de7e6ec278fc2b48cf94343431
|
diff --git a/protractor-shared.js b/protractor-shared.js
index <HASH>..<HASH> 100644
--- a/protractor-shared.js
+++ b/protractor-shared.js
@@ -72,7 +72,10 @@ var BROWSER_CAPS = {
ChromeDesktop: {
browserName: 'chrome',
chromeOptions: mergeInto(CHROME_OPTIONS, {
- 'mobileEmulation': CHROME_MOBILE_EMULATION
+ // TODO(tbosch): when we are using mobile emulation on
+ // chrome 44.0 beta, clicks are no more working.
+ // see https://github.com/angular/angular/issues/2309
+ // 'mobileEmulation': CHROME_MOBILE_EMULATION
}),
loggingPrefs: {
performance: 'ALL',
|
fix(tests): disable mobile emulation so benchmarks run on current chrome
Workaround for #<I>
|
angular_angular
|
train
|
js
|
c79fbb2a3bebc94e524c163c2b18fd11216cf8a5
|
diff --git a/packages/collector/test/tracing/protocols/http/server/test.js b/packages/collector/test/tracing/protocols/http/server/test.js
index <HASH>..<HASH> 100644
--- a/packages/collector/test/tracing/protocols/http/server/test.js
+++ b/packages/collector/test/tracing/protocols/http/server/test.js
@@ -433,7 +433,7 @@ function registerTests(useHttps, useHttp2CompatApi) {
fail('Expected the HTTP call to time out.');
})
.catch(err => {
- if (err.error && err.error.code === 'ESOCKETTIMEDOUT') {
+ if (err.error && (err.error.code === 'ESOCKETTIMEDOUT' || err.error.code === 'ETIMEDOUT')) {
// We actually expect the request to time out. But we still want to verify that an entry span has been created
// for it.
return retry(() =>
|
test(tracing): fix flaky test
Actually, both error codes can occur in a timeout situation.
|
instana_nodejs-sensor
|
train
|
js
|
215740157bb85837e0f2c4bc9a7ce373b4bf1eb1
|
diff --git a/src/client/actions/GuildDelete.js b/src/client/actions/GuildDelete.js
index <HASH>..<HASH> 100644
--- a/src/client/actions/GuildDelete.js
+++ b/src/client/actions/GuildDelete.js
@@ -18,7 +18,7 @@ class GuildDeleteAction extends Action {
if (channel.type === 'text') channel.stopTyping(true);
}
- if (guild.available && data.unavailable) {
+ if (data.unavailable) {
// Guild is unavailable
guild.available = false;
|
fix: always emit guildUnavailable when a guild becomes unavailable (#<I>)
|
discordjs_discord.js
|
train
|
js
|
11c0c6432a8d15b9918f6e03e74e7e94337a3b5f
|
diff --git a/packages/site/build/webpack.config.babel.js b/packages/site/build/webpack.config.babel.js
index <HASH>..<HASH> 100644
--- a/packages/site/build/webpack.config.babel.js
+++ b/packages/site/build/webpack.config.babel.js
@@ -111,7 +111,8 @@ module.exports = {
},
plugins,
devServer: {
- port: 1337
+ port: 1337,
+ historyApiFallback: true
},
resolveLoader: {
alias: {
|
refactor(site): handle pushstate better
|
pluralsight_design-system
|
train
|
js
|
0362916a63b923bfb304f05677ed9f5c67403d2b
|
diff --git a/src/plugins/notify/index.js b/src/plugins/notify/index.js
index <HASH>..<HASH> 100644
--- a/src/plugins/notify/index.js
+++ b/src/plugins/notify/index.js
@@ -255,6 +255,11 @@ class Notify {
};
}
}
+ this.PopstateEvent = () => {
+ this.close();
+ };
+
+ window.addEventListener('popstate', this.PopstateEvent);
}
trigger(event, ...data) {
@@ -277,6 +282,8 @@ class Notify {
this.trigger('$close');
+ window.removeEventListener('popstate', this.PopstateEvent);
+
utils.removeClass($body, notifyShowCls);
$body.addEventListener('transitionend', (event) => {
|
fix(Notify): add popstate event handler
Closes #<I>
|
heyui_heyui
|
train
|
js
|
43479fe9310a2319e2f18567acf76566ffefc2b9
|
diff --git a/config/webpack/webpack-base.js b/config/webpack/webpack-base.js
index <HASH>..<HASH> 100644
--- a/config/webpack/webpack-base.js
+++ b/config/webpack/webpack-base.js
@@ -10,6 +10,10 @@ module.exports = {
entry: {
dicomParser: './index.js'
},
+ externals: {
+ 'zlib': 'zlib'
+ },
+ node: false,
target: 'web',
output: {
filename: '[name].js',
diff --git a/src/parseDicom.js b/src/parseDicom.js
index <HASH>..<HASH> 100644
--- a/src/parseDicom.js
+++ b/src/parseDicom.js
@@ -47,7 +47,7 @@ export default function parseDicom (byteArray, options) {
function getDataSetByteStream (transferSyntax, position) {
// Detect whether we are inside a browser or Node.js
- const isNode = (typeof window === 'undefined');
+ const isNode = (Object.prototype.toString.call(typeof process !== 'undefined' ? process : 0) === '[object process]');
if (transferSyntax === '1.2.840.10008.1.2.1.99') {
// if an infalter callback is registered, use it
|
fix: Remove Node browser polyfill libraries from the build (#<I>). Also updated node check to be based off process so it properly detects within web workers. (#<I>)
|
cornerstonejs_dicomParser
|
train
|
js,js
|
da20a38fae8462e6fd1eeac3457c27276092aed4
|
diff --git a/src/trumbowyg.js b/src/trumbowyg.js
index <HASH>..<HASH> 100644
--- a/src/trumbowyg.js
+++ b/src/trumbowyg.js
@@ -337,11 +337,18 @@ jQuery.trumbowyg = {
pasteHandlers: [],
imgDblClickHandler: function () {
- var $img = $(this);
+ var $img = $(this),
+ src = $img.attr('src'),
+ base64 = '(Base64)';
+
+ if (src.indexOf('data:image') === 0) {
+ src = base64;
+ }
+
t.openModalInsert(t.lang.insertImage, {
url: {
label: 'URL',
- value: $img.attr('src'),
+ value: src,
required: true
},
alt: {
@@ -349,10 +356,15 @@ jQuery.trumbowyg = {
value: $img.attr('alt')
}
}, function (v) {
- return $img.attr({
- src: v.url,
+ if (v.src !== base64) {
+ $img.attr({
+ src: v.src
+ });
+ }
+ $img.attr({
alt: v.alt
});
+ return true;
});
return false;
},
|
fix: avoid crash on base<I> image edit on double click
|
Alex-D_Trumbowyg
|
train
|
js
|
96c4ea8cf2208343ceab9fbb167f9e7a30f9b948
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100755
--- a/index.js
+++ b/index.js
@@ -71,6 +71,7 @@ function copyFiles(args, config, callback) {
next();
});
}))
+ .on('error', callback)
.pipe(through(function (pathName, _, next) {
fs.stat(pathName, function (err, pathStat) {
if (err) {
@@ -108,6 +109,7 @@ function copyFiles(args, config, callback) {
})
});
}))
+ .on('error', callback)
.pipe(through(function (pathName, _, next) {
var outName = path.join(outDir, dealWith(pathName, opts));
fs.createReadStream(pathName)
|
fix(stream): proper error handling (#<I>)
if mkdirp raises an error, e.g trying to create a folder inside a read-only target, the error does not get propagated properly to the consumer and the client app dies without any chance to catch it.
Added it for the first glob pipe as well, although not sure how this might be possible to fail (tried by throwing error manually from within code)
|
calvinmetcalf_copyfiles
|
train
|
js
|
073b3ac1df7d21b5d842f090ecec5303b772b8a8
|
diff --git a/src/Marketing/Services/MarketingService.php b/src/Marketing/Services/MarketingService.php
index <HASH>..<HASH> 100644
--- a/src/Marketing/Services/MarketingService.php
+++ b/src/Marketing/Services/MarketingService.php
@@ -488,14 +488,14 @@ class MarketingService extends \DTS\eBaySDK\Marketing\Services\MarketingBaseServ
]
],
'CreateReportTask' => [
- 'method' => 'GET',
+ 'method' => 'POST',
'resource' => 'ad_report_task',
'responseClass' => '\DTS\eBaySDK\Marketing\Types\CreateReportTasktRestResponse',
'params' => [
]
],
'DeleteSpecificReportTask' => [
- 'method' => 'GET',
+ 'method' => 'DELETE',
'resource' => 'ad_report_task/{report_task_id}',
'responseClass' => '\DTS\eBaySDK\Marketing\Types\DeleteSpecificReportTaskRestResponse',
'params' => [
|
fix: use correct http method for new marketing operations
|
davidtsadler_ebay-sdk-php
|
train
|
php
|
6db63ef61947bd9fb6221e82ac214550abfb8035
|
diff --git a/middlewares/animate.js b/middlewares/animate.js
index <HASH>..<HASH> 100644
--- a/middlewares/animate.js
+++ b/middlewares/animate.js
@@ -35,7 +35,7 @@ function animate (elem) {
elem.$attribute('leave-animation', leaveAttribute)
elem.$attribute('move-animation', moveAttribute)
- queueCheck()
+ Promise.resolve().then(queueCheck)
elem.$cleanup(queueCheck)
}
animate.$name = 'animate'
|
fix(animate): defer premature queue checks as microtasks
|
nx-js_framework
|
train
|
js
|
0d29f59e4edb891cdb73071b8df0b17b4e67ffb8
|
diff --git a/packages/cerebral-forms/src/chains/changeField.js b/packages/cerebral-forms/src/chains/changeField.js
index <HASH>..<HASH> 100644
--- a/packages/cerebral-forms/src/chains/changeField.js
+++ b/packages/cerebral-forms/src/chains/changeField.js
@@ -1,8 +1,7 @@
+import {set, state, input} from 'cerebral/operators'
import validateField from '../factories/validateField'
export default [
- function updateValue ({input, state}) {
- state.set(`${input.field}.value`, input.value)
- },
+ set(state`${input`field`}.value`, input`value`),
validateField()
]
|
refactor(forms): switch to tagged template based operators
|
cerebral_cerebral
|
train
|
js
|
db56c9d01a66e26087ae2e14d7a739ccffaa81f0
|
diff --git a/static/lib/composer.js b/static/lib/composer.js
index <HASH>..<HASH> 100644
--- a/static/lib/composer.js
+++ b/static/lib/composer.js
@@ -643,6 +643,7 @@ define('composer', [
// Restore composer on error
composer.load(post_uuid);
+ textareaEl.prop('readonly', false);
return app.alertError(err.message);
}
|
fix: composer textarea stays readonly even after error returned
|
NodeBB_nodebb-plugin-composer-default
|
train
|
js
|
e4df86f4d3d39d6fca2f9e353a1e74b0bba9650a
|
diff --git a/utils_test.go b/utils_test.go
index <HASH>..<HASH> 100644
--- a/utils_test.go
+++ b/utils_test.go
@@ -28,7 +28,7 @@ digraph fsm {
"intermediate";
"open";
}`
- normalizedGot := strings.Replace(got, "\n", "", -1)
+ normalizedGot := strings.ReplaceAll(got, "\n", "")
normalizedWanted := strings.ReplaceAll(wanted, "\n", "")
if normalizedGot != normalizedWanted {
t.Errorf("build graphivz graph failed. \nwanted \n%s\nand got \n%s\n", wanted, got)
@@ -58,7 +58,7 @@ graph fsm
intermediate -->|part-close| closed
open -->|close| closed
`
- normalizedGot := strings.Replace(got, "\n", "", -1)
+ normalizedGot := strings.ReplaceAll(got, "\n", "")
normalizedWanted := strings.ReplaceAll(wanted, "\n", "")
if normalizedGot != normalizedWanted {
t.Errorf("build mermaid graph failed. \nwanted \n%s\nand got \n%s\n", wanted, got)
|
fix: replaces forgotten ReplaceAll (#<I>)
|
looplab_fsm
|
train
|
go
|
4290c43b41fc4a0dc59a16bd41a6198e7a9cdd09
|
diff --git a/packages/taro/src/create-page.js b/packages/taro/src/create-page.js
index <HASH>..<HASH> 100644
--- a/packages/taro/src/create-page.js
+++ b/packages/taro/src/create-page.js
@@ -97,9 +97,9 @@ function initPage (weappPageConf, page) {
return recurrenceComponent(weappPageConf, page)
}
-function componentActivate (component, key) {
+function componentTrigger (component, key) {
Object.getOwnPropertyNames(component.$$components || {}).forEach(name => {
- componentActivate(component.$$components[name], key)
+ componentTrigger(component.$$components[name], key)
})
component[key] && typeof component[key] === 'function' && component[key]()
}
@@ -114,13 +114,13 @@ function createPage (PageClass) {
page.$router = {
params: options
}
- componentActivate(page, 'componentWillMount')
+ componentTrigger(page, 'componentWillMount')
},
onReady () {
- componentActivate(page, 'componentDidMount')
+ componentTrigger(page, 'componentDidMount')
},
onUnload () {
- componentActivate(page, 'componentDidUnmount')
+ componentTrigger(page, 'componentDidUnmount')
},
_setData (data, cb, isRoot) {
this.stateList.push({
|
fix(tarojs): method rename
|
NervJS_taro
|
train
|
js
|
01847a802598483f7d22754140671a8b97c3c533
|
diff --git a/src/date-picker/BasePicker.js b/src/date-picker/BasePicker.js
index <HASH>..<HASH> 100644
--- a/src/date-picker/BasePicker.js
+++ b/src/date-picker/BasePicker.js
@@ -127,10 +127,7 @@ export default class BasePicker extends Component {
onChange && onChange(date, this.parseDate(date));
}
createPickerPanel() {
- return this.pickerPanel(
- this.state,
- Object.assign({}, { ...this.props })
- );
+ return this.pickerPanel(this.state);
}
render() {
const { className, style,
diff --git a/src/date-picker/TimePickerSpinner.js b/src/date-picker/TimePickerSpinner.js
index <HASH>..<HASH> 100644
--- a/src/date-picker/TimePickerSpinner.js
+++ b/src/date-picker/TimePickerSpinner.js
@@ -73,7 +73,6 @@ export default class TimeSpinner extends Component {
render() {
const { prefixCls } = this.props;
const { several } = this.state;
-
return (
<div
ref={(elm) => {
|
fix(TimePicker): drop-dawn list is selected by default.
|
uiwjs_uiw
|
train
|
js,js
|
7651dff2a0388ce250e46ec61fd0b1db6f1b4f69
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -42,7 +42,7 @@ module.exports = class Smart extends Promise {
catch () {
// need at least 2
if (arguments.length < 2) {
- return super.then.call(this, null, ...arguments)
+ return super.then.bind(this, null).apply(this, arguments)
}
let args = Array.from(arguments)
|
fix(node4): workaround for node v4
|
ahmadnassri_smart-promise
|
train
|
js
|
cf7cf86f2854f9d7ade0c7bf0ab1c24fdbe3ab6f
|
diff --git a/packages/build-tools/utils/manifest.deprecated.js b/packages/build-tools/utils/manifest.deprecated.js
index <HASH>..<HASH> 100644
--- a/packages/build-tools/utils/manifest.deprecated.js
+++ b/packages/build-tools/utils/manifest.deprecated.js
@@ -65,4 +65,4 @@ async function aggregateBoltDependencies(data) {
module.exports = {
aggregateBoltDependencies,
flattenDeep,
-};
\ No newline at end of file
+};
|
chore: fix linting issue
|
bolt-design-system_bolt
|
train
|
js
|
f48f8cd105a3444b01cd4e84b67419570a0526e9
|
diff --git a/src/js/components/CheckBox/stories/Indeterminate.js b/src/js/components/CheckBox/stories/Indeterminate.js
index <HASH>..<HASH> 100644
--- a/src/js/components/CheckBox/stories/Indeterminate.js
+++ b/src/js/components/CheckBox/stories/Indeterminate.js
@@ -48,6 +48,6 @@ const IndeterminateCheckBox = () => {
);
};
-storiesOf('CheckBox', module).add('Interminate', () => (
+storiesOf('CheckBox', module).add('Indeterminate', () => (
<IndeterminateCheckBox />
));
|
docs: fix indeterminate typo in Indeterminate story (#<I>)
|
grommet_grommet
|
train
|
js
|
25e31e5f2690610d9e5a3e61e1bf3acf9afae749
|
diff --git a/packages/@uppy/provider-views/src/index.js b/packages/@uppy/provider-views/src/index.js
index <HASH>..<HASH> 100644
--- a/packages/@uppy/provider-views/src/index.js
+++ b/packages/@uppy/provider-views/src/index.js
@@ -81,6 +81,7 @@ module.exports = class ProviderView {
}
_updateFilesAndFolders (res, files, folders) {
+ this.nextPagePath = res.nextPagePath
res.items.forEach((item) => {
if (item.isFolder) {
folders.push(item)
@@ -128,7 +129,6 @@ module.exports = class ProviderView {
}
this.username = this.username ? this.username : res.username
- this.nextPagePath = res.nextPagePath
this._updateFilesAndFolders(res, files, folders)
this.plugin.setPluginState({ directories: updatedDirectories })
},
@@ -463,7 +463,7 @@ module.exports = class ProviderView {
handleScroll (e) {
const scrollPos = e.target.scrollHeight - (e.target.scrollTop + e.target.offsetHeight)
- const path = this.nextPagePath ? this.nextPagePath : null
+ const path = this.nextPagePath || null
if (scrollPos < 50 && path && !this._isHandlingScroll) {
this.provider.list(path)
|
fix: update instagram nextPagePath after every fetch
|
transloadit_uppy
|
train
|
js
|
934116eaade8805ee35e9e065455a1bb76939255
|
diff --git a/app/lib/app-extension/Extension.js b/app/lib/app-extension/Extension.js
index <HASH>..<HASH> 100644
--- a/app/lib/app-extension/Extension.js
+++ b/app/lib/app-extension/Extension.js
@@ -125,7 +125,7 @@ module.exports = class Extension {
isInstalled () {
try {
- require.resolve(this.packageName, {
+ require.resolve(this.packageName + '/src/index', {
paths: [ appPaths.appDir ]
})
}
|
refactor(app): check AE install status by accessing index file directly (#<I>)
This avoids to use "main" field of package.json for AE purposes, allowing devs to use it for their needs
|
quasarframework_quasar
|
train
|
js
|
0d725106f664c89485b60aee42628accf6dcd2b6
|
diff --git a/src/Utils/Message.php b/src/Utils/Message.php
index <HASH>..<HASH> 100644
--- a/src/Utils/Message.php
+++ b/src/Utils/Message.php
@@ -84,7 +84,7 @@ class Message
*
* @param mixed $message
*
- * @return \ArkEcosystem\Crypto\Message
+ * @return \ArkEcosystem\Crypto\Utils\Message
*/
public static function new($message): self
{
|
fix: return type of the new method (#<I>)
|
ArkEcosystem_php-crypto
|
train
|
php
|
474ac65ce83abe74487c042d049670bbeb16b316
|
diff --git a/lib/mongo_client.js b/lib/mongo_client.js
index <HASH>..<HASH> 100644
--- a/lib/mongo_client.js
+++ b/lib/mongo_client.js
@@ -82,7 +82,12 @@ var validOptionNames = [
'user',
'password',
'authMechanism',
- 'compression'
+ 'compression',
+ 'fsync',
+ 'readPreferenceTags',
+ 'numberOfRetries',
+ 'autoReconnect',
+ 'auto_reconnect'
];
var ignoreOptionNames = ['native_parser'];
@@ -610,13 +615,11 @@ function createServer(self, options, callback) {
// Set default options
var servers = translateOptions(options);
- console.log(servers[0].s.clonedOptions);
- console.log(servers[0].s.options);
-
// Propegate the events to the client
var collectedEvents = collectEvents(self, servers[0]);
+
// Connect to topology
- servers[0].connect(options, function(err, topology) {
+ servers[0].connect(function(err, topology) {
if (err) return callback(err);
// Clear out all the collected event listeners
clearAllEvents(servers[0]);
|
fix(mongo-client): options should not be passed to `connect`
Passing `options` to the `connect` object for parsed topologies
in `createServer` effectively overrides the options that were
originally passed into the client.
NODE-<I>
|
mongodb_node-mongodb-native
|
train
|
js
|
14ff94da34d5ce911ef588f019d5a9d386bd534a
|
diff --git a/packages/@vue/cli-plugin-babel/codemods/usePluginPreset.js b/packages/@vue/cli-plugin-babel/codemods/usePluginPreset.js
index <HASH>..<HASH> 100644
--- a/packages/@vue/cli-plugin-babel/codemods/usePluginPreset.js
+++ b/packages/@vue/cli-plugin-babel/codemods/usePluginPreset.js
@@ -37,5 +37,5 @@ module.exports = function (fileInfo, api) {
node.value = { cooked: '@vue/cli-plugin-babel/preset', raw: '@vue/cli-plugin-babel/preset' }
})
- return root.toSource()
+ return root.toSource({ lineTerminator: '\n' })
}
|
fix: force lines to be ended with lf, fix windows tests
|
vuejs_vue-cli
|
train
|
js
|
102a3a5e9e1c8b0caec748ec115049544174893d
|
diff --git a/lib/workers/repository/updates/generate.js b/lib/workers/repository/updates/generate.js
index <HASH>..<HASH> 100644
--- a/lib/workers/repository/updates/generate.js
+++ b/lib/workers/repository/updates/generate.js
@@ -180,6 +180,11 @@ function generateBranchConfig(branchUpgrades) {
config.hasTypes = true;
} else {
config.upgrades.sort((a, b) => {
+ // istanbul ignore if
+ if (a.fileReplacePosition && b.fileReplacePosition) {
+ // This is because we need to replace from the bottom of the file up
+ return a.fileReplacePosition > b.fileReplacePosition ? -1 : 1;
+ }
if (a.depName < b.depName) return -1;
if (a.depName > b.depName) return 1;
return 0;
|
fix(maven): sort updates to same file from bottom up
|
renovatebot_renovate
|
train
|
js
|
3ca84399d6d3f7a4396ea841297d4155dffe8fb5
|
diff --git a/lib/workers/pr/index.js b/lib/workers/pr/index.js
index <HASH>..<HASH> 100644
--- a/lib/workers/pr/index.js
+++ b/lib/workers/pr/index.js
@@ -120,8 +120,8 @@ async function ensurePr(prConfig) {
depName: upgrade.depName,
fromVersion: upgrade.fromVersion,
toVersion: upgrade.toVersion,
- repositoryUrl: config.repositoryUrl,
- releases: config.releases,
+ repositoryUrl: upgrade.repositoryUrl,
+ releases: upgrade.releases,
});
if (logJSON) {
|
fix(changelog): use upgrade for lookups
|
renovatebot_renovate
|
train
|
js
|
da90f46d762f9662036e56676e24ab44571d63b3
|
diff --git a/lib/adapters/object.js b/lib/adapters/object.js
index <HASH>..<HASH> 100644
--- a/lib/adapters/object.js
+++ b/lib/adapters/object.js
@@ -243,8 +243,8 @@ var Graph = function (_AncientGraph) {
key: '_generateLink',
value: function _generateLink(document) {
var link = {};
- for (var f in document) {
- if (this.fields[f]) {
+ for (var f in this.fields) {
+ if (document.hasOwnProperty(this.fields[f])) {
link[f] = document[this.fields[f]];
}
}
diff --git a/src/lib/adapters/object.js b/src/lib/adapters/object.js
index <HASH>..<HASH> 100644
--- a/src/lib/adapters/object.js
+++ b/src/lib/adapters/object.js
@@ -190,8 +190,8 @@ export class Graph extends AncientGraph {
*/
_generateLink(document) {
var link = {};
- for (var f in document) {
- if (this.fields[f]) {
+ for (var f in this.fields) {
+ if (document.hasOwnProperty(this.fields[f])) {
link[f] = document[this.fields[f]];
}
}
|
fix(adapter): Fix document to link generation.
|
AncientSouls_Graph
|
train
|
js,js
|
5d63f5ec92cb966862cb873c048672906c820e68
|
diff --git a/packages/xod-espruino/webpack/base.js b/packages/xod-espruino/webpack/base.js
index <HASH>..<HASH> 100644
--- a/packages/xod-espruino/webpack/base.js
+++ b/packages/xod-espruino/webpack/base.js
@@ -20,6 +20,7 @@ module.exports = {
],
resolve: {
modulesDirectories: [
+ 'node_modules',
pkgpath('node_modules'),
pkgpath('node_modules/xod-core/node_modules'),
],
|
fix(xod-espruino): quick fix for webpack config (cant find isarray package in tests)
|
xodio_xod
|
train
|
js
|
5a5a916438d5b6daeb30271a54bdb276ebb3c4bd
|
diff --git a/gulpfile.js b/gulpfile.js
index <HASH>..<HASH> 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -1,17 +1,21 @@
-var fs = require('fs')
-var exec = require('child_process').exec
-var gulp = require('gulp')
-var bump = require('gulp-bump')
+const f = require('util').format
+const fs = require('fs')
+const exec = require('child_process').exec
+const gulp = require('gulp')
+const bump = require('gulp-bump')
// Basic usage:
// Will patch the version
-gulp.task('bump', function () {
+gulp.task('bump', () => {
gulp.src('./package.json')
.pipe(bump())
.pipe(gulp.dest('./'))
})
-gulp.task('tag', function () {
- var version = JSON.parse(fs.readFileSync('./package.json', 'utf8')).version
- exec('git tag ' + version + ' && git push --tags', err => err)
+gulp.task('tag', () => {
+ const version = JSON.parse(fs.readFileSync('./package.json', 'utf8')).version
+ exec(
+ f(`git tag '%s' && git push --tags`, version),
+ err => console.log(err ? err : f('version "%s" published successfully.', version))
+ )
})
|
refactor: gulpfile.js for log result
|
futurist_replace-css-url
|
train
|
js
|
d5594325409b49b021bfa7bbce83b936f18eb5a4
|
diff --git a/src/decoder.js b/src/decoder.js
index <HASH>..<HASH> 100644
--- a/src/decoder.js
+++ b/src/decoder.js
@@ -88,7 +88,7 @@ var decode = function(bytes, mask, names) {
}, {});
}
-if (module) {
+if (typeof module === 'object' && typeof module.exports !== 'undefined') {
module.exports = {
unixtime: unixtime,
uint8: uint8,
|
fix: work in non-require env
|
thesolarnomad_lora-serialization
|
train
|
js
|
186263faa673cd1947823d7ad9af35efaa989f13
|
diff --git a/lib/core/topologies/mongos.js b/lib/core/topologies/mongos.js
index <HASH>..<HASH> 100644
--- a/lib/core/topologies/mongos.js
+++ b/lib/core/topologies/mongos.js
@@ -612,7 +612,7 @@ function reconnectProxies(self, proxies, callback) {
})
);
- destroyServer(_server);
+ destroyServer(_server, { force: true });
removeProxyFrom(self.disconnectedProxies, _server);
// Relay the server description change
|
fix(mongos): force close servers during reconnect flow
|
mongodb_node-mongodb-native
|
train
|
js
|
3ff1f1a66b8b9990102e87d864b525f56d3b64b5
|
diff --git a/lib/plugins/index.js b/lib/plugins/index.js
index <HASH>..<HASH> 100644
--- a/lib/plugins/index.js
+++ b/lib/plugins/index.js
@@ -315,7 +315,6 @@ function loadPlugins(plugins, callback) {
}
function getRulesFromPlugins(type, req, res, plugins, callback) {
- type = type;
loadPlugins(plugins, function(ports) {
ports = ports.map(function(port, i) {
var _port = port && port[type + 'Port'];
|
refactor: Refine lib/plugins/index.js
|
avwo_whistle
|
train
|
js
|
6a2d9c3b28fb7f1e3ca1b68d2e146ac5a19150f0
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -2,11 +2,14 @@ import querystring from 'querystring'
import 'isomorphic-fetch' // eslint-disable-line import/no-unassigned-import
import { required, checkStatus, parseJSON } from './helpers'
+const { localStorge } = window
+const TOKEN_KEY_NAME = 'syncano_client_token'
+
function SyncanoClient(instanceName = required('instanceName'), options = {}) {
client.instanceName = instanceName
client.baseUrl = options.baseUrl || `https://${instanceName}.syncano.space/`
client.loginMethod = options.loginMethod
- client.token = options.token
+ client.token = options.token || localStorge.getItem(TOKEN_KEY_NAME)
let defaults = {
'Content-Type': 'application/json'
@@ -72,6 +75,12 @@ client.logout = function () {
client.setToken = function (token) {
this.token = token
+
+ if (token) {
+ localStorge.setItem(TOKEN_KEY_NAME, token)
+ } else {
+ localStorge.removeItem(TOKEN_KEY_NAME)
+ }
}
client.get = function (endpoint = required('endpoint'), body = {}, options = {}) {
|
feat(client): save token in localstorage
|
Syncano_syncano-client-js
|
train
|
js
|
fe8965efa284b20c241ef3117a50965abee66708
|
diff --git a/lib/renderer/chrome-api.js b/lib/renderer/chrome-api.js
index <HASH>..<HASH> 100644
--- a/lib/renderer/chrome-api.js
+++ b/lib/renderer/chrome-api.js
@@ -43,12 +43,12 @@ class Port {
disconnect () {
if (this.disconnected) return
- ipcRenderer._sendInternalToAll(this.tabId, `CHROME_PORT_DISCONNECT_${this.portId}`)
+ ipcRenderer.sendToAll(this.tabId, `CHROME_PORT_DISCONNECT_${this.portId}`)
this._onDisconnect()
}
postMessage (message) {
- ipcRenderer._sendInternalToAll(this.tabId, `CHROME_PORT_POSTMESSAGE_${this.portId}`, message)
+ ipcRenderer.sendToAll(this.tabId, `CHROME_PORT_POSTMESSAGE_${this.portId}`, message)
}
_onDisconnect () {
|
fix: use sendToAll method correctly in chrome-api (#<I>)
|
electron_electron
|
train
|
js
|
a4607b97bfc2016e6feced5c04eb8259504b2efe
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -219,7 +219,7 @@ if (!PLATFORM.global.System || !PLATFORM.global.System.import) {
};
DefaultLoader.prototype.map = function(id, source) {
- System.map[id] = source;
+ System.config({ map: { [id]: source } });
};
DefaultLoader.prototype.normalizeSync = function(moduleId, relativeTo) {
|
fix(DefaultLoader): use config API for map
This changes makes the loader compatible with SystemJS <I>-rc<I>
|
aurelia_loader-default
|
train
|
js
|
4731cc3ab5bdde50e451506e3b5781142aeddbeb
|
diff --git a/test/__init__.py b/test/__init__.py
index <HASH>..<HASH> 100644
--- a/test/__init__.py
+++ b/test/__init__.py
@@ -38,4 +38,4 @@ class Runner(DiscoverRunner):
def suite_result(self, suite, result, **kwargs):
write_results(result)
- super(Runner, self).suite_result(suite, result, **kwargs)
+ return super(Runner, self).suite_result(suite, result, **kwargs)
|
test: fix detection of test failures in custom test runner
That missing `return` was causing the test process to return 0 even when
some tests failed.
|
Linaro_squad
|
train
|
py
|
a4aa5efba357d8aa4de5cbb433401c18c26dafb9
|
diff --git a/lib/https/index.js b/lib/https/index.js
index <HASH>..<HASH> 100644
--- a/lib/https/index.js
+++ b/lib/https/index.js
@@ -928,7 +928,11 @@ module.exports = function(socket, next, isWebPort) {
}
if (useSNI) {
useSNI = false;
- useNoSNIServer();
+ try {
+ useNoSNIServer();
+ } catch (e) {
+ next(chunk);
+ }
} else {
next(chunk);
}
|
refactor: catch possible exceptions
|
avwo_whistle
|
train
|
js
|
8da11c7c8e4262a4502383c8256b0d78b5f6808c
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -21,8 +21,8 @@ module.exports = function (allowWrapper) {
return;
}
- // skip stdio
- if (isStdIO(h)) {
+ // skip stdio and pipe between worker and master
+ if (isStdIO(h) || isWorkerPipe(h)) {
return;
}
@@ -101,6 +101,12 @@ function isStdIO (obj) {
return false;
}
+function isWorkerPipe (obj) {
+ if (obj.constructor.name === 'Pipe' && process.channel === obj) {
+ return true;
+ }
+}
+
function wrapCallbackFirst (mod, name) {
var orig = mod[name];
|
fix: Ignore pipe between worker and master
This is a node's internal object which needs not to be exposed
|
keymetrics_event-loop-inspector
|
train
|
js
|
c070d424eb6224b50b24d4621e1bdbf5b3c31307
|
diff --git a/.adiorc.js b/.adiorc.js
index <HASH>..<HASH> 100644
--- a/.adiorc.js
+++ b/.adiorc.js
@@ -34,7 +34,8 @@ module.exports = {
ignore: {
src: ["path", "os", "fs", "util", "events", "crypto", "aws-sdk"],
dependencies: ["@babel/runtime"],
- devDependencies: true
+ devDependencies: true,
+ peerDependencies: true
},
ignoreDirs: ["node_modules/", "dist/", "build/"],
packages: [
|
refactor: ignore all peer dependencies in adio
|
Webiny_webiny-js
|
train
|
js
|
6ad13472aff5470b112f22bbb7fa2b63afab32cc
|
diff --git a/test/instrumentation/modules/pg/pg.js b/test/instrumentation/modules/pg/pg.js
index <HASH>..<HASH> 100644
--- a/test/instrumentation/modules/pg/pg.js
+++ b/test/instrumentation/modules/pg/pg.js
@@ -99,7 +99,7 @@ factories.forEach(function (f) {
setTimeout(function () {
trans.end()
agent._instrumentation._queue._flush()
- }, 100)
+ }, 150)
})
})
})
|
test: increase chance that Travis CI tests pass
|
opbeat_opbeat-node
|
train
|
js
|
f6cdb188bde964342c297352771382f860b83ce8
|
diff --git a/packages/metascraper-media-provider/src/get-media/provider/generic.js b/packages/metascraper-media-provider/src/get-media/provider/generic.js
index <HASH>..<HASH> 100644
--- a/packages/metascraper-media-provider/src/get-media/provider/generic.js
+++ b/packages/metascraper-media-provider/src/get-media/provider/generic.js
@@ -39,10 +39,10 @@ module.exports = ({ tunnel, onError, userAgent, cacheDir }) => {
try {
data = await getInfo(url, flags)
} catch (rawError) {
- const err = youtubedlError({ rawError, url, flags })
- debug('getInfo:err', err.message)
- onError(err, url)
- if (err.unsupportedUrl) return data
+ const error = youtubedlError({ rawError, url, flags })
+ debug('getInfo:error', error.message)
+ onError(error, url)
+ if (error.unsupportedUrl) return data
if (!tunnel) return data
retry.incr()
}
|
refactor: rename err into error
|
microlinkhq_metascraper
|
train
|
js
|
f6424fe87f5e5136a6282b846cd461eb6122c494
|
diff --git a/themes/perun/perun/disco-tpl.php b/themes/perun/perun/disco-tpl.php
index <HASH>..<HASH> 100644
--- a/themes/perun/perun/disco-tpl.php
+++ b/themes/perun/perun/disco-tpl.php
@@ -58,7 +58,7 @@ if ($this->isAddInstitutionApp()) {
$this->data['header'] = $this->t('{perun:disco:header}');
if ($displaySpName && !empty($spName)) {
- $this->data['header'] .= ' ' . $this->t('{perun:disco:header_display_service}') . ' ' . $spName;
+ $this->data['header'] .= ' ' . $this->t('{perun:disco:header_display_service}') . ' <i>' . $spName . '</i>';
}
}
|
refactor: 💡 Display SP name in italics
|
CESNET_perun-simplesamlphp-module
|
train
|
php
|
65cbcb2f73d89459a9cae5dc9b083be8f07eabae
|
diff --git a/docs/dgeni-package/services/tsParser/getExportDocType.js b/docs/dgeni-package/services/tsParser/getExportDocType.js
index <HASH>..<HASH> 100644
--- a/docs/dgeni-package/services/tsParser/getExportDocType.js
+++ b/docs/dgeni-package/services/tsParser/getExportDocType.js
@@ -1,6 +1,6 @@
var ts = require('typescript');
-module.exports = function getExportDocType() {
+module.exports = function getExportDocType(log) {
return function(symbol) {
if(symbol.flags & ts.SymbolFlags.FunctionScopedVariable) {
|
chore(doc-gen): ensure `log` is injected into `getExportDocType`
See #<I>
|
angular_angular
|
train
|
js
|
cdbb40af062810a95afe81dee7e912f63fdbfa02
|
diff --git a/src/Leevel/Encryption/Encryption.php b/src/Leevel/Encryption/Encryption.php
index <HASH>..<HASH> 100644
--- a/src/Leevel/Encryption/Encryption.php
+++ b/src/Leevel/Encryption/Encryption.php
@@ -39,28 +39,28 @@ class Encryption implements IEncryption
*
* @var string
*/
- protected $key;
+ protected string $key;
/**
* openssl 加密解密算法.
*
* @var string
*/
- protected $cipher;
+ protected string $cipher;
/**
* 安全 RSA 私钥.
*
* @var string
*/
- protected $rsaPrivate;
+ protected ?string $rsaPrivate;
/**
* 安全 RSA 公钥.
*
* @var string
*/
- protected $rsaPublic;
+ protected ?string $rsaPublic;
/**
* 构造函数.
|
refactor(encryption): php<I> changes for encryption
|
hunzhiwange_framework
|
train
|
php
|
a627e8c61e43ec1bf01f3fb899cbde99340874c4
|
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index <HASH>..<HASH> 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -1,6 +1,8 @@
ENV['RACK_ENV'] ||= 'test'
require 'simplecov'
-SimpleCov.start
+SimpleCov.start do
+ add_filter 'spec/'
+end
require 'coveralls'
Coveralls.wear!
require 'rack/test'
|
test(coverage): fix coverage by removing spec/ from the count
|
squareteam_yodatra
|
train
|
rb
|
9ae80acde59d9d149ee5e4e2097f209eac6f834f
|
diff --git a/src/core/util/perf.js b/src/core/util/perf.js
index <HASH>..<HASH> 100644
--- a/src/core/util/perf.js
+++ b/src/core/util/perf.js
@@ -18,7 +18,7 @@ if (process.env.NODE_ENV !== 'production') {
perf.measure(name, startTag, endTag)
perf.clearMarks(startTag)
perf.clearMarks(endTag)
- perf.clearMeasures(name)
+ // perf.clearMeasures(name)
}
}
}
|
feat: expose performance measures
ref #<I>
|
kaola-fed_megalo
|
train
|
js
|
cadacfded632e87b636ff0b620cc05edad184a88
|
diff --git a/simpl/middleware/cors.py b/simpl/middleware/cors.py
index <HASH>..<HASH> 100644
--- a/simpl/middleware/cors.py
+++ b/simpl/middleware/cors.py
@@ -41,7 +41,7 @@ class CORSMiddleware(object): # pylint: disable=R0903
"""Responds to CORS requests."""
- default_methods = ('GET', 'OPTIONS', 'POST', 'PUT', 'HEAD')
+ default_methods = ('GET', 'OPTIONS', 'POST', 'PUT', 'HEAD', 'DELETE')
default_headers = (
'Accept',
'Connection',
|
feat(cors): add DELETE as a valid, default method
|
rackerlabs_simpl
|
train
|
py
|
385452469a9aac44b686f05515c613738629ee43
|
diff --git a/resources/views/partials/header.blade.php b/resources/views/partials/header.blade.php
index <HASH>..<HASH> 100644
--- a/resources/views/partials/header.blade.php
+++ b/resources/views/partials/header.blade.php
@@ -4,7 +4,7 @@
</a>
@if (has_nav_menu('primary_navigation'))
- <nav class="nav-primary" aria-label="{{wp_get_nav_menu_name('primary_navigation')}}">
+ <nav class="nav-primary" aria-label="{{ wp_get_nav_menu_name('primary_navigation') }}">
{!! wp_nav_menu(['theme_location' => 'primary_navigation', 'menu_class' => 'nav', 'echo' => false]) !!}
</nav>
@endif
|
chore(views): nitpick blade syntax
|
roots_sage
|
train
|
php
|
b69025ebd0cd2544d3cdb84f46f6fc177421cf1d
|
diff --git a/lib/swig.js b/lib/swig.js
index <HASH>..<HASH> 100644
--- a/lib/swig.js
+++ b/lib/swig.js
@@ -603,7 +603,7 @@ exports.Swig = function (opts) {
context = getLocals(options);
contextLength = utils.keys(context).length;
- pre = this.precompile(source, options);
+ pre = self.precompile(source, options);
function compiled(locals) {
var lcls;
|
fix: 'this.precompile' BUG in swig.compile
|
Thunf_swiger
|
train
|
js
|
bdbb066d729aa0b507cada7fadab6553daf7c9b6
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -81,6 +81,7 @@ function format(f, args, opts) {
str += '%'
lastPos = i + 2
i++
+ a--
break
}
++a
diff --git a/test/index.js b/test/index.js
index <HASH>..<HASH> 100644
--- a/test/index.js
+++ b/test/index.js
@@ -98,3 +98,4 @@ assert.equal(format('foo %j', [circularObject]), 'foo "[Circular]"')
assert.equal(format('%%', ['foo']), '%')
assert.equal(format('foo %%', ['foo']), 'foo %')
+assert.equal(format('foo %% %s', ['bar']), 'foo % bar')
|
fix: percent escape eats argument
|
davidmarkclements_quick-format-unescaped
|
train
|
js,js
|
29b4cef6afb6c67ae831d4f42a4db3c19bc500ee
|
diff --git a/test/wsfed.tests.js b/test/wsfed.tests.js
index <HASH>..<HASH> 100644
--- a/test/wsfed.tests.js
+++ b/test/wsfed.tests.js
@@ -204,7 +204,7 @@ describe('wsfed', function () {
});
describe('using custom profile mapper', function() {
- describe('when NameIdentifier is found', function() {
+ describe('when NameIdentifier and NameIdentifierFormat have been configured', function() {
const fakeNameIdentifier = 'fakeNameIdentifier';
const fakeNameIdentifierFormat = 'fakeNameIdentifierFormat';
|
chore: giving test description a better name
|
auth0_node-wsfed
|
train
|
js
|
3ed6966fd522441eb2c1e21be6b0d0b55c32638d
|
diff --git a/src/Exscript/Connection.py b/src/Exscript/Connection.py
index <HASH>..<HASH> 100644
--- a/src/Exscript/Connection.py
+++ b/src/Exscript/Connection.py
@@ -229,6 +229,34 @@ class Connection(object):
self._untrack_accounts()
return account
+ def authenticate(self, account = None, flush = True, lock = True):
+ """
+ Like protocols.Transport.authenticate(), but makes sure to
+ lock/release the account while it is used.
+ If an account is not given, one is acquired from the account
+ manager.
+ Returns the account that was used to log in.
+
+ @type account: Account
+ @param account: The account to use for logging in.
+ @type flush: bool
+ @param flush: Whether to flush the last prompt from the buffer.
+ @type lock: bool
+ @param lock: Whether to lock the account while logging in.
+ @rtype: Account
+ @return: The account that was used to log in.
+ """
+ account = self._acquire_account(account, lock)
+ self._track_account(account)
+
+ try:
+ self.transport.authenticate(account, flush = flush)
+ finally:
+ if lock:
+ self._release_account(account)
+ self._untrack_accounts()
+ return account
+
def protocol_authenticate(self, account = None, lock = True):
"""
Like protocols.Transport.protocol_authenticate(), but makes sure to
|
fix: protect accounts passed to Connection.authenticate() with locking.
|
knipknap_exscript
|
train
|
py
|
b4a23e2bcf82b57bad09bde00848a7bd81ae7208
|
diff --git a/httprunner/v3/runner.py b/httprunner/v3/runner.py
index <HASH>..<HASH> 100644
--- a/httprunner/v3/runner.py
+++ b/httprunner/v3/runner.py
@@ -28,7 +28,7 @@ class TestCaseRunner(object):
self.config.variables.update(variables)
return self
- def run_step(self, step: TestStep):
+ def __run_step(self, step: TestStep):
logger.info(f"run step: {step.name}")
# parse
@@ -75,7 +75,7 @@ class TestCaseRunner(object):
# parse variables
step.variables = parse_variables_mapping(step.variables, self.config.functions)
# run step
- extract_mapping = self.run_step(step)
+ extract_mapping = self.__run_step(step)
# save extracted variables to session variables
session_variables.update(extract_mapping)
# save request & response meta data
|
refactor: make run_step as private method
|
HttpRunner_HttpRunner
|
train
|
py
|
881199a2575531a3a5417131eb9fa06c11aad8b9
|
diff --git a/lib/webpack/createBaseConfig.js b/lib/webpack/createBaseConfig.js
index <HASH>..<HASH> 100644
--- a/lib/webpack/createBaseConfig.js
+++ b/lib/webpack/createBaseConfig.js
@@ -212,6 +212,7 @@ module.exports = function createBaseConfig ({
}
createCSSRule('css', /\.css$/)
+ createCSSRule('postcss', /\.p(ost)?css$/)
createCSSRule('scss', /\.scss$/, 'sass-loader', siteConfig.scss)
createCSSRule('sass', /\.sass$/, 'sass-loader', Object.assign({ indentedSyntax: true }, siteConfig.sass))
createCSSRule('less', /\.less$/, 'less-loader', siteConfig.less)
|
feat: support style lang postcss (close: #<I>)
|
vuejs_vuepress
|
train
|
js
|
83034fc987072bc3761d264e94ea50db7921e841
|
diff --git a/packages/mangojuice-core/src/classes/Process.js b/packages/mangojuice-core/src/classes/Process.js
index <HASH>..<HASH> 100644
--- a/packages/mangojuice-core/src/classes/Process.js
+++ b/packages/mangojuice-core/src/classes/Process.js
@@ -729,7 +729,7 @@ extend(Process.prototype, {
for (let taskId in this.tasks) {
for (let execId in this.tasks[taskId]) {
const execution = this.tasks[taskId][execId].execution;
- if (execution) {
+ if (is.promise(execution)) {
promises.push(execution);
}
}
@@ -740,7 +740,7 @@ extend(Process.prototype, {
if (proc) {
const childFinished = proc.finished();
if (childFinished !== EMPTY_FINISHED) {
- promises.push(proc.finished());
+ promises.push(childFinished);
}
}
});
|
fix(core): do not call finished two times for child process
|
mangojuicejs_mangojuice
|
train
|
js
|
2db9444ecd6406a16460c896dee9207370ee9511
|
diff --git a/packages/node_modules/@webex/plugin-meetings/test/unit/spec/meeting/index.js b/packages/node_modules/@webex/plugin-meetings/test/unit/spec/meeting/index.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@webex/plugin-meetings/test/unit/spec/meeting/index.js
+++ b/packages/node_modules/@webex/plugin-meetings/test/unit/spec/meeting/index.js
@@ -715,11 +715,6 @@ describe('plugin-meetings', () => {
assert.exists(meeting.setMeetingQuality);
});
- it('should set mediaProperty with the proper level', () => meeting.setMeetingQuality(CONSTANTS.QUALITY_LEVELS.LOW).then(() => {
- assert.equal(meeting.mediaProperties.localQualityLevel, CONSTANTS.QUALITY_LEVELS.LOW);
- assert.equal(meeting.mediaProperties.remoteQualityLevel, CONSTANTS.QUALITY_LEVELS.LOW);
- }));
-
it('should call setRemoteQualityLevel', () => meeting.setMeetingQuality(CONSTANTS.QUALITY_LEVELS.LOW).then(() => {
assert.calledOnce(meeting.setRemoteQualityLevel);
}));
|
chore(plugin-meetings): test meetingQuality flow
|
webex_spark-js-sdk
|
train
|
js
|
b89527b3d0993c312b276ba0b90ac59f9e8259aa
|
diff --git a/packages/ast/test/traverse.js b/packages/ast/test/traverse.js
index <HASH>..<HASH> 100644
--- a/packages/ast/test/traverse.js
+++ b/packages/ast/test/traverse.js
@@ -21,6 +21,32 @@ describe("AST traverse", () => {
assert.isTrue(called, "Module visitor has not been called");
});
+ it("should be called once per node", () => {
+ const node = t.module("test", []);
+ let nb = 0;
+
+ traverse(node, {
+ Module() {
+ nb++;
+ }
+ });
+
+ assert.equal(nb, 1);
+ });
+
+ it("should call the special Node visitor", () => {
+ const node = t.module("test", []);
+ let called = false;
+
+ traverse(node, {
+ Node() {
+ called = true;
+ }
+ });
+
+ assert.isTrue(called, "Module visitor has not been called");
+ });
+
describe("parent path", () => {
it("should retain the parent path", () => {
const root = t.module("test", [t.func(null, [], [], [])]);
|
feat(ast): add few traverse tests
|
xtuc_webassemblyjs
|
train
|
js
|
1691251fefc8703ddc25c5e27aa3ad8c89af0677
|
diff --git a/engine/src/main/java/org/camunda/bpm/engine/impl/util/ReflectUtil.java b/engine/src/main/java/org/camunda/bpm/engine/impl/util/ReflectUtil.java
index <HASH>..<HASH> 100644
--- a/engine/src/main/java/org/camunda/bpm/engine/impl/util/ReflectUtil.java
+++ b/engine/src/main/java/org/camunda/bpm/engine/impl/util/ReflectUtil.java
@@ -148,7 +148,6 @@ public abstract class ReflectUtil {
*/
public static URI urlToURI(URL url) {
try {
- //return new URI(url.getProtocol(), url.getAuthority(), url.getPath(), url.getQuery(), null);
return new URI(url.getProtocol(), url.getPath(), null);
} catch (URISyntaxException e) {
throw new ProcessEngineException("couldn't convert URL to URI " + url, e);
|
fix(engine): remove commented line
related to #CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
java
|
fa8e3cf5c603809d0f3b66b4bb1954c13d36f6b8
|
diff --git a/src/Ufo/Widgets/WidgetsArrayStorage.php b/src/Ufo/Widgets/WidgetsArrayStorage.php
index <HASH>..<HASH> 100644
--- a/src/Ufo/Widgets/WidgetsArrayStorage.php
+++ b/src/Ufo/Widgets/WidgetsArrayStorage.php
@@ -28,7 +28,7 @@ class WidgetsArrayStorage extends WidgetsStorage
{
if (array_key_exists($section->path, $this->storage)) {
if (array_key_exists('', $this->storage)) {
- return array_merge($this->storage[''], $this->storage[$section->path]);
+ return array_merge_recursive($this->storage[''], $this->storage[$section->path]);
} else {
return $this->storage[$section->path];
}
|
fix: merging widgets for current and all pages
|
enikeishik_ufoframework
|
train
|
php
|
2be6609a54a73f93c3343162267b257c1fdddfb6
|
diff --git a/tests/documentation.py b/tests/documentation.py
index <HASH>..<HASH> 100644
--- a/tests/documentation.py
+++ b/tests/documentation.py
@@ -9,6 +9,7 @@
from __future__ import absolute_import, print_function
import os
+import sys
import sphinx
import unittest
@@ -21,12 +22,18 @@ class TestDocumentation(TestCase):
docdir = os.path.join(self.topdir, 'docs')
os.chdir(docdir)
htmldir = self.tempdir
+ # Add a fix for https://bitbucket.org/birkenfeld/sphinx/issue/1611
+ # where sphinx.main() ignores arguments passed to it and instead uses
+ # sys.argv.
+ args = ['sphinx', '-b', 'html', '-nW', '.', htmldir]
+ saved_argv, sys.argv = sys.argv, args
# sphinx.main() changed behavior in version 1.2.3 and it now calls
# exit() with the return code rather than returning it.
try:
ret = sphinx.main(['sphinx', '-b', 'html', '-nW', '.', htmldir])
except SystemExit as e:
ret = e.code
+ sys.argv = saved_argv
self.assertEqual(ret, 0)
|
docs: workaround for sphinx bug #<I>
|
geertj_gruvi
|
train
|
py
|
0b25ab8b8fd4aa4228d31e147bc759f1eebffb87
|
diff --git a/src/main/org/bson/BasicBSONCallback.java b/src/main/org/bson/BasicBSONCallback.java
index <HASH>..<HASH> 100644
--- a/src/main/org/bson/BasicBSONCallback.java
+++ b/src/main/org/bson/BasicBSONCallback.java
@@ -13,6 +13,10 @@ public class BasicBSONCallback implements BSONCallback {
reset();
}
+ public BSONObject create(){
+ return new BasicBSONObject();
+ }
+
public BSONCallback createBSONCallback(){
return new BasicBSONCallback();
}
|
fix: inadvertently removed method
|
mongodb_mongo-java-driver
|
train
|
java
|
89370fd5c3ccd7dc5a1f45aaa0d4b0d969873b10
|
diff --git a/test/test_host.go b/test/test_host.go
index <HASH>..<HASH> 100644
--- a/test/test_host.go
+++ b/test/test_host.go
@@ -51,13 +51,14 @@ func (s *HostSuite) TestAddFailingJob(t *c.C) {
t.Assert(err, c.IsNil)
defer stream.Close()
- // add a job with a non existent artifact
+ // add a job with a non existent partition
job := &host.Job{
ID: jobID,
ImageArtifact: &host.Artifact{
Type: host.ArtifactTypeDocker,
URI: "http://example.com?name=foo&id=bar",
},
+ Partition: "nonexistent",
}
t.Assert(h.AddJob(job), c.IsNil)
@@ -83,7 +84,7 @@ loop:
t.Assert(actual[1].Event, c.Equals, host.JobEventError)
jobErr := actual[1].Job.Error
t.Assert(jobErr, c.NotNil)
- t.Assert(*jobErr, c.Equals, "registry: repo not found")
+ t.Assert(*jobErr, c.Equals, `host: invalid job partition "nonexistent"`)
}
func (s *HostSuite) TestAttachNonExistentJob(t *c.C) {
|
test: Trigger a more reliable error in TestAddFailingJob
We were previously relying on the artifact pull from example.com to
return a <I>, thus generating a "repo not found" error, but example.com
recently starting returning a <I> instead. We probably shouldn't be
relying on the reliability of example.com :)
|
flynn_flynn
|
train
|
go
|
dc39438551f3cefa3d0d3851a5c4921c874c6f9e
|
diff --git a/node-tests/unit/tasks/setup-webview-test.js b/node-tests/unit/tasks/setup-webview-test.js
index <HASH>..<HASH> 100644
--- a/node-tests/unit/tasks/setup-webview-test.js
+++ b/node-tests/unit/tasks/setup-webview-test.js
@@ -77,4 +77,23 @@ describe('Setup Webview Task', function() {
setupTask.run();
td.verify(rawDouble('add', 'cordova-plugin-wkwebview-engine', isAnything));
});
+
+ describe('invalid platform/webview combinations', function() {
+ it('warns ios users if crosswalk=true', function() {
+ setupTask.crosswalk = true;
+ let warnDouble = td.replace(setupTask, 'warnPlatform');
+
+ setupTask.run();
+ td.verify(warnDouble('ios', 'crosswalk=true'));
+ });
+
+ it('warns android users if uiwebview=true', function() {
+ setupTask.platform = 'android';
+ setupTask.uiwebview = true;
+ let warnDouble = td.replace(setupTask, 'warnPlatform');
+
+ setupTask.run();
+ td.verify(warnDouble('android', 'uiwebview=true'));
+ });
+ });
});
|
test(webviews): assert warning for wrong platform/view combinations
|
isleofcode_ember-cordova
|
train
|
js
|
8cb56d009d40287f12b9d1eac31194c69077b067
|
diff --git a/src/components/props/watchExpressions.js b/src/components/props/watchExpressions.js
index <HASH>..<HASH> 100644
--- a/src/components/props/watchExpressions.js
+++ b/src/components/props/watchExpressions.js
@@ -50,6 +50,7 @@ function notify (setter, inQuirkMode) {
* @param options.depth 'reference'|'value'|'collection'
* @param options.quirk 'reference'|'value'|'collection'
* @param scope Object
+ * @param type String 'props'|'attrs'
*/
export default function watchExpressions (dataExprsMap, reactiveData, options, scope, type) {
let expressions
|
docs(watchExpressions): add new param type
|
ngVue_ngVue
|
train
|
js
|
34b9daf6f09e5de63acae0b6feaed2f0917eaaa3
|
diff --git a/packages/node_modules/@webex/plugin-meetings/src/constants.js b/packages/node_modules/@webex/plugin-meetings/src/constants.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@webex/plugin-meetings/src/constants.js
+++ b/packages/node_modules/@webex/plugin-meetings/src/constants.js
@@ -187,7 +187,7 @@ export const ICE_FAIL_TIMEOUT = 3000;
export const RETRY_TIMEOUT = 3000;
export const ROAP_SEQ_PRE = -1;
-export const PC_BAIL_TIMEOUT = 20000;
+export const PC_BAIL_TIMEOUT = 8000;
// ******************** REGEX **********************
// Please alphabetize
|
fix(plugin-meetings): decrease the timer for meeting connect failure
|
webex_spark-js-sdk
|
train
|
js
|
c7e12abcf56a90645277c9726462f3aefbcfcd5e
|
diff --git a/webapps/ui/common/scripts/module/services/is-file-upload-supported.js b/webapps/ui/common/scripts/module/services/is-file-upload-supported.js
index <HASH>..<HASH> 100644
--- a/webapps/ui/common/scripts/module/services/is-file-upload-supported.js
+++ b/webapps/ui/common/scripts/module/services/is-file-upload-supported.js
@@ -1,6 +1,6 @@
module.exports = ['$window', function($window) {
return function() {
- const {FileReader} = $window;
+ var FileReader = $window.FileReader;
return typeof FileReader === 'function' && typeof FileReader.prototype.readAsText === 'function';
};
|
chore: use es5 ;) in isFileUploadSupported service
related to CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
js
|
c353d92a3cf29ead53c744d7ad264576a2d5aa5a
|
diff --git a/connection/pool.js b/connection/pool.js
index <HASH>..<HASH> 100644
--- a/connection/pool.js
+++ b/connection/pool.js
@@ -287,7 +287,6 @@ function connectionFailureHandler(self, event) {
// Flush all work Items on this connection
while (this.workItems.length > 0) {
var workItem = this.workItems.shift();
- // if(workItem.cb) workItem.cb(err);
if (workItem.cb) workItem.cb(err);
}
diff --git a/wireprotocol/2_6_support.js b/wireprotocol/2_6_support.js
index <HASH>..<HASH> 100644
--- a/wireprotocol/2_6_support.js
+++ b/wireprotocol/2_6_support.js
@@ -106,8 +106,6 @@ WireProtocol.prototype.killCursor = function(bson, ns, cursorState, pool, callba
} catch (err) {
callback(err, null);
}
-
- return;
}
// Callback
|
fix(wire-protocol): <I> killCursor should not way for reply
NODE-<I>
|
mongodb_node-mongodb-native
|
train
|
js,js
|
dc3a6451bd8fa08e8c38223cb73995ebd8189bb1
|
diff --git a/src/db/clients/index.js b/src/db/clients/index.js
index <HASH>..<HASH> 100644
--- a/src/db/clients/index.js
+++ b/src/db/clients/index.js
@@ -12,6 +12,9 @@ export const CLIENTS = [
key: 'mysql',
name: 'MySQL',
defaultPort: 3306,
+ disabledFeatures: [
+ 'server:schema',
+ ],
},
{
key: 'postgresql',
@@ -33,6 +36,7 @@ export const CLIENTS = [
'server:socketPath',
'server:user',
'server:password',
+ 'server:schema',
'scriptCreateTable',
],
},
|
feat: add schema to disabledFeatures list (#<I>)
|
falcon-client_falcon-core
|
train
|
js
|
a8a1c161a681f99570d9bb52b5e5243708af7619
|
diff --git a/views/cypress/utils/selectors.js b/views/cypress/utils/selectors.js
index <HASH>..<HASH> 100755
--- a/views/cypress/utils/selectors.js
+++ b/views/cypress/utils/selectors.js
@@ -4,6 +4,6 @@ export default {
moveConfirmSelector: 'button[data-control="ok"]',
assetForm: 'form[action="/taoMediaManager/MediaManager/editInstance"]',
assetClassForm: 'form[action="/taoMediaManager/MediaManager/editClassLabel"]',
- deleteConfirm: '[data-control="delete"]',
+ deleteConfirm: 'button[data-control="ok"]',
root: '[data-uri="http://www.tao.lu/Ontologies/TAOMedia.rdf#Media"]'
};
|
chore: Small fix on xpath button
|
oat-sa_extension-tao-mediamanager
|
train
|
js
|
55a7a5cd33e97f9a8370083dcb041c5552f10ac9
|
diff --git a/test/server_timeout.test.js b/test/server_timeout.test.js
index <HASH>..<HASH> 100644
--- a/test/server_timeout.test.js
+++ b/test/server_timeout.test.js
@@ -7,6 +7,7 @@ const Agent = require('..');
describe('test/server_timeout.test.js', () => {
let port;
let server;
+ let timer;
before(done => {
server = http.createServer((req, res) => {
if (server.keepAliveTimeout) {
@@ -24,6 +25,10 @@ describe('test/server_timeout.test.js', () => {
});
});
+ after(() => {
+ clearInterval(timer);
+ });
+
it('should handle Keep-Alive header and not throw reset error', done => {
const keepaliveAgent = new Agent({
keepAlive: true,
@@ -67,7 +72,7 @@ describe('test/server_timeout.test.js', () => {
req.end();
}
- setInterval(request, server.keepAliveTimeout);
+ timer = setInterval(request, server.keepAliveTimeout);
request();
});
});
|
test: stop timer after test end
|
node-modules_agentkeepalive
|
train
|
js
|
666987bf52127a454c8db9d8218d3d283f0118d0
|
diff --git a/algoliasearch/types_rule.go b/algoliasearch/types_rule.go
index <HASH>..<HASH> 100644
--- a/algoliasearch/types_rule.go
+++ b/algoliasearch/types_rule.go
@@ -1,10 +1,11 @@
package algoliasearch
type Rule struct {
- ObjectID string `json:"objectID,omitempty"`
- Condition RuleCondition `json:"condition"`
- Consequence RuleConsequence `json:"consequence"`
- Description string `json:"description,omitempty"`
+ ObjectID string `json:"objectID,omitempty"`
+ Condition RuleCondition `json:"condition"`
+ Consequence RuleConsequence `json:"consequence"`
+ Description string `json:"description,omitempty"`
+ HighlightResult Map `json:"_highlightResult,omitempty"`
}
// RuleCondition is the part of an Algolia Rule which describes the condition
|
fix: Add missing _highlightResult field for Query Rules answers
|
algolia_algoliasearch-client-go
|
train
|
go
|
6784bd63910b7b70edd2b065bbae0c7651c89a73
|
diff --git a/core/lib/stats2.js b/core/lib/stats2.js
index <HASH>..<HASH> 100644
--- a/core/lib/stats2.js
+++ b/core/lib/stats2.js
@@ -209,7 +209,7 @@ Stats.prototype.histogram = function(name, n) {
return this.summary(name, n);
};
-Stats.prototype.counter = function(name, value) {
+Stats.prototype.counter = function(name, value = 1) {
if (!this._counters[name]) {
this._counters[name] = 0;
}
|
feat(stats): Default to adding one in counter()
|
artilleryio_artillery
|
train
|
js
|
8b1dc585b30350283ede4247d36beecebc9fc16d
|
diff --git a/core/lib/engine_http.js b/core/lib/engine_http.js
index <HASH>..<HASH> 100644
--- a/core/lib/engine_http.js
+++ b/core/lib/engine_http.js
@@ -594,7 +594,6 @@ HttpEngine.prototype._handleResponse = function(url, res, ee, context, maybeCall
}
HttpEngine.prototype.setInitialContext = function(initialContext) {
- let self = this;
initialContext._successCount = 0;
initialContext._jar = new tough.CookieJar();
@@ -605,10 +604,10 @@ HttpEngine.prototype.setInitialContext = function(initialContext) {
initialContext._enableCookieJar = true;
}
- if (self.config.http && typeof self.config.http.pool !== 'undefined') {
+ if (this.config.http && typeof this.config.http.pool !== 'undefined') {
// Reuse common agents (created in the engine instance constructor)
- initialContext._httpAgent = self._httpAgent;
- initialContext._httpsAgent = self._httpsAgent;
+ initialContext._httpAgent = this._httpAgent;
+ initialContext._httpsAgent = this._httpsAgent;
} else {
// Create agents just for this VU
const agentOpts = Object.assign(DEFAULT_AGENT_OPTIONS, {
|
refactor(http): remove unnecessary reassignment of this
|
artilleryio_artillery
|
train
|
js
|
2d8e26c24c360148083cacb3468a58c99320198a
|
diff --git a/src/structures/Guild.js b/src/structures/Guild.js
index <HASH>..<HASH> 100644
--- a/src/structures/Guild.js
+++ b/src/structures/Guild.js
@@ -114,8 +114,18 @@ class Guild extends Base {
this.large = Boolean('large' in data ? data.large : this.large);
/**
- * An array of guild features
- * @type {string[]}
+ * An array of enabled guild features, here are the possible values:
+ * * INVITE_SPLASH
+ * * MORE_EMOJI
+ * * VERIFIED
+ * * VIP_REGIONS
+ * * VANITY_URL
+ * @typedef {string} Features
+ */
+
+ /**
+ * An array of guild features partnered guilds have enabled
+ * @type {Features[]}
*/
this.features = data.features;
|
docs: add Guild#features type (#<I>)
* docs: add Guild#features type
* fixed spacing
* make it a list, and add MORE_EMOJI
|
discordjs_discord.js
|
train
|
js
|
bb19385ea41d4d1b6c18da479fee2e8fce5e9398
|
diff --git a/persistence.js b/persistence.js
index <HASH>..<HASH> 100644
--- a/persistence.js
+++ b/persistence.js
@@ -236,7 +236,7 @@ MongoPersistence.prototype.createRetainedStreamCombi = function (patterns) {
for (let i = 0; i < patterns.length; i++) {
instance.matcher.add(patterns[i], true)
- regex.push(escape(patterns[i]).replace(/(#|\\\+).*$/, ''))
+ regex.push(escape(patterns[i]).replace(/(\/*#|\\\+).*$/, ''))
}
regex = regex.join('|')
|
fix: Regex match empty level #<I> (#<I>)
* fix: Regex match empty level #<I>
* fix when wildecard is #
|
mcollina_aedes-persistence-mongodb
|
train
|
js
|
ff0d859a8d4607a32a12946ce26285ac02521fd3
|
diff --git a/lib/chromedriver.js b/lib/chromedriver.js
index <HASH>..<HASH> 100644
--- a/lib/chromedriver.js
+++ b/lib/chromedriver.js
@@ -26,6 +26,7 @@ const MIN_CD_VERSION_WITH_W3C_SUPPORT = 75;
const DEFAULT_PORT = 9515;
const CHROMEDRIVER_CHROME_MAPPING = {
// Chromedriver version: minimum Chrome version
+ '80.0.3987.106': '80.0.3987.106',
'79.0.3945.36': '79.0.3945.36',
'78.0.3904.70': '78.0.3904.70',
'77.0.3865.40': '77.0.3865.40',
|
feat: update to CD <I> (#<I>)
|
appium_appium-chromedriver
|
train
|
js
|
d8ccc7d77bdc11f9e29b31752af4a18dad10b016
|
diff --git a/packages/bonde-admin-canary/src/components/Link/ButtonLink.js b/packages/bonde-admin-canary/src/components/Link/ButtonLink.js
index <HASH>..<HASH> 100644
--- a/packages/bonde-admin-canary/src/components/Link/ButtonLink.js
+++ b/packages/bonde-admin-canary/src/components/Link/ButtonLink.js
@@ -1,11 +1,21 @@
import React from 'react'
import { Link } from 'react-router-dom'
import { Button } from 'bonde-styleguide'
+import PropTypes from 'prop-types'
-export default ({ to, title, children, align }) => (
+const ButtonLink = ({ to, title, children, align }) => (
<Link to={to} title={title}>
<Button flat align={align || 'left'} padding='0'>
{children}
</Button>
</Link>
)
+
+ButtonLink.propTypes = {
+ to: PropTypes.string,
+ title: PropTypes.string,
+ children: PropTypes.node,
+ align: PropTypes.string
+}
+
+export default ButtonLink
|
chore(admin-canary): lints components/Link
|
nossas_bonde-client
|
train
|
js
|
6a33af661978f79c78db72afd1614515b78c4a60
|
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100644
--- a/setup.py
+++ b/setup.py
@@ -37,10 +37,10 @@ setup(
"Programming Language :: Python :: 2",
"Programming Language :: Python :: 2.7",
"Programming Language :: Python :: 3",
- "Programming Language :: Python :: 3.3",
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
+ "Programming Language :: Python :: 3.7",
"Development Status :: 5 - Production/Stable",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
|
chore: update python versions in setup.py
|
altaurog_pgcopy
|
train
|
py
|
3f9daa8cc5a10817309108282efa6d49c63d5820
|
diff --git a/webapps/ui/common/scripts/util/pagination-utils.js b/webapps/ui/common/scripts/util/pagination-utils.js
index <HASH>..<HASH> 100644
--- a/webapps/ui/common/scripts/util/pagination-utils.js
+++ b/webapps/ui/common/scripts/util/pagination-utils.js
@@ -31,6 +31,18 @@ function initializePaginationInController($scope, search, updateCallback) {
updateCallback(newValue, oldValue);
});
+ $scope.$on('$locationChangeSuccess', function() {
+ var currentPage = getCurrentPageFromSearch(search);
+
+ if (pages.current !== currentPage) {
+ var oldPages = angular.extend({}, pages);
+
+ pages.current = currentPage;
+
+ updateCallback(pages, oldPages);
+ }
+ });
+
return pages;
}
|
fix(utils): add support for url in pagination util
related to CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
js
|
47e891445efe351974002e8c447217dcfe447926
|
diff --git a/src/main/java/com/bugsnag/delivery/SyncHttpDelivery.java b/src/main/java/com/bugsnag/delivery/SyncHttpDelivery.java
index <HASH>..<HASH> 100644
--- a/src/main/java/com/bugsnag/delivery/SyncHttpDelivery.java
+++ b/src/main/java/com/bugsnag/delivery/SyncHttpDelivery.java
@@ -9,6 +9,7 @@ import org.slf4j.LoggerFactory;
import java.io.IOException;
import java.io.OutputStream;
import java.net.HttpURLConnection;
+import java.net.MalformedURLException;
import java.net.Proxy;
import java.net.URL;
import java.net.UnknownHostException;
@@ -81,6 +82,9 @@ public class SyncHttpDelivery implements HttpDelivery {
logger.warn(
"Error not reported to Bugsnag - got non-200 response code: {}", status);
}
+ } catch (MalformedURLException ex) {
+ logger.warn("Error not reported to Bugsnag - malformed URL."
+ + " Have you set both endpoints correctly?", ex);
} catch (SerializationException ex) {
logger.warn("Error not reported to Bugsnag - exception when serializing payload", ex);
} catch (UnknownHostException ex) {
|
feat: disable sending of sessions if endpoint is not set
|
bugsnag_bugsnag-java
|
train
|
java
|
3c0046437a2d43900888cd65c7d6f3dd9786629d
|
diff --git a/ui/src/components/stepper/QStep.js b/ui/src/components/stepper/QStep.js
index <HASH>..<HASH> 100644
--- a/ui/src/components/stepper/QStep.js
+++ b/ui/src/components/stepper/QStep.js
@@ -70,7 +70,7 @@ export default createComponent({
const isActive = computed(() => $stepper.value.modelValue === props.name)
const scrollEvent = computed(() => (
- ($q.platform.is.ios !== true && $q.platform.is.safari !== true)
+ ($q.platform.is.ios !== true && $q.platform.is.chrome === true)
|| isActive.value !== true
|| $stepper.value.vertical !== true
? {}
|
fix(QStepper): prevent dot line to create scrollable panels - firefox #<I>, #<I> (#<I>)
#<I>, #<I>
|
quasarframework_quasar
|
train
|
js
|
8aaa736bf24b657aa002d714bfe793ea3add1bde
|
diff --git a/lib/logger.js b/lib/logger.js
index <HASH>..<HASH> 100644
--- a/lib/logger.js
+++ b/lib/logger.js
@@ -289,7 +289,7 @@ var proto = {
trace: function trace(msg) {
var args;
if (this.isEnabledFor(LEVELS.TRACE)) {
- var obj = new Error();
+ var obj = {};
Error.captureStackTrace(obj, trace);
obj[STACK_SYMBOL] = true;
diff --git a/test/logger.js b/test/logger.js
index <HASH>..<HASH> 100644
--- a/test/logger.js
+++ b/test/logger.js
@@ -280,6 +280,7 @@ module.exports = {
assert.equal(record.level, Logger.TRACE);
assert.equal(record.message, "intrusion");
assert(record.stack);
+ assert(!record.exception);
a.trace();
var record = spyA.getLastArgs()[0];
|
fix: logger.trace() should not set record.exception
|
seanmonstar_intel
|
train
|
js,js
|
5b8c21e1cede001c60b3e68dad34f79f77603626
|
diff --git a/src/org/nutz/mvc/upload/Uploads.java b/src/org/nutz/mvc/upload/Uploads.java
index <HASH>..<HASH> 100644
--- a/src/org/nutz/mvc/upload/Uploads.java
+++ b/src/org/nutz/mvc/upload/Uploads.java
@@ -67,7 +67,10 @@ public abstract class Uploads {
* 请求对象
*/
public static void removeInfo(HttpServletRequest req) {
- req.removeAttribute(UploadInfo.SESSION_NAME);
+ HttpSession sess = req.getSession(false);
+ if (null != sess) {
+ sess.removeAttribute(UploadInfo.SESSION_NAME);
+ }
}
}
|
fix:UploadInfo should remove from session not from request
|
nutzam_nutz
|
train
|
java
|
e8798c4dd4d0f52bbc88a858545389260cf9c941
|
diff --git a/test/support/configs.js b/test/support/configs.js
index <HASH>..<HASH> 100644
--- a/test/support/configs.js
+++ b/test/support/configs.js
@@ -118,4 +118,4 @@ module.exports.merged = {
},
target2 : passedin.task2.target2
}
-}
\ No newline at end of file
+};
\ No newline at end of file
|
chore: jshint complains about missing ;
|
creynders_load-grunt-configs
|
train
|
js
|
4e9848948a9fab30a538080081d8f61d0d7bba76
|
diff --git a/jupytext/cli.py b/jupytext/cli.py
index <HASH>..<HASH> 100644
--- a/jupytext/cli.py
+++ b/jupytext/cli.py
@@ -416,7 +416,7 @@ def jupytext(args=None):
for pattern in args.notebooks:
if "*" in pattern or "?" in pattern:
# Exclude the .jupytext.py configuration file
- notebooks.extend(glob.glob(pattern))
+ notebooks.extend(glob.glob(pattern, recursive=True))
else:
notebooks.append(pattern)
|
feat: add recursive glob option (#<I>)
Sure that will be useful! Thank you @b4nst
|
mwouts_jupytext
|
train
|
py
|
e3ac302ecb861958c372cff13a699090d79dfa9e
|
diff --git a/cmd/open.go b/cmd/open.go
index <HASH>..<HASH> 100644
--- a/cmd/open.go
+++ b/cmd/open.go
@@ -6,12 +6,37 @@
package cmd
-import "github.com/tsuru/tsuru/exec"
+import (
+ "fmt"
+ "strings"
+ "golang.org/x/sys/unix"
+ "github.com/tsuru/tsuru/exec"
+)
+
+func isWSL() bool {
+ var u unix.Utsname
+ err := unix.Uname(&u)
+ if err != nil {
+ fmt.Println(err)
+ return false
+ }
+ release := strings.ToLower(string(u.Release[:]))
+ return strings.Contains(release, "microsoft")
+}
func open(url string) error {
+
+ cmd := "xdg-open"
+ args := []string{url}
+
+ if(isWSL()){
+ cmd = "powershell.exe"
+ args = []string{"-c", "start", url}
+ }
+
opts := exec.ExecuteOptions{
- Cmd: "xdg-open",
- Args: []string{url},
+ Cmd: cmd,
+ Args: args,
}
return executor().Execute(opts)
}
|
feat: Adding WSL2 oauth support
|
tsuru_tsuru
|
train
|
go
|
95e04984fc58c75b7c6dd1ceeab5aa0baf63cc18
|
diff --git a/allauth/socialaccount/fields.py b/allauth/socialaccount/fields.py
index <HASH>..<HASH> 100644
--- a/allauth/socialaccount/fields.py
+++ b/allauth/socialaccount/fields.py
@@ -58,10 +58,3 @@ class JSONField(models.TextField):
def value_from_object(self, obj):
"""Return value dumped to string."""
return self.get_prep_value(self._get_val_from_obj(obj))
-
-
-try:
- from south.modelsinspector import add_introspection_rules
- add_introspection_rules([], ["^allauth\.socialaccount\.fields\.JSONField"])
-except:
- pass
diff --git a/allauth/socialaccount/migrations/__init__.py b/allauth/socialaccount/migrations/__init__.py
index <HASH>..<HASH> 100644
--- a/allauth/socialaccount/migrations/__init__.py
+++ b/allauth/socialaccount/migrations/__init__.py
@@ -1,5 +0,0 @@
-try:
- from django.db import migrations # noqa
-except ImportError:
- from django.core.exceptions import ImproperlyConfigured
- raise ImproperlyConfigured('Please upgrade to south >= 1.0')
|
chore: Remove obsolete references to south (#<I>)
|
pennersr_django-allauth
|
train
|
py,py
|
c3ae56565bbe05c9809c5ad1192fcfc3ae717114
|
diff --git a/util/errors/errors.go b/util/errors/errors.go
index <HASH>..<HASH> 100644
--- a/util/errors/errors.go
+++ b/util/errors/errors.go
@@ -16,6 +16,13 @@ import (
argoerrs "github.com/argoproj/argo-workflows/v3/errors"
)
+func IgnoreContainerNotFoundErr(err error) error {
+ if err != nil && strings.Contains(err.Error(), "container not found") {
+ return nil
+ }
+ return err
+}
+
func IsTransientErr(err error) bool {
if err == nil {
return false
diff --git a/workflow/controller/controller.go b/workflow/controller/controller.go
index <HASH>..<HASH> 100644
--- a/workflow/controller/controller.go
+++ b/workflow/controller/controller.go
@@ -552,7 +552,7 @@ func (wfc *WorkflowController) signalContainers(namespace string, podName string
if c.State.Terminated != nil {
continue
}
- if err := signal.SignalContainer(wfc.restConfig, pod, c.Name, sig); err != nil {
+ if err := signal.SignalContainer(wfc.restConfig, pod, c.Name, sig); errorsutil.IgnoreContainerNotFoundErr(err) != nil {
return 0, err
}
}
|
fix: Do not log container not found (#<I>)
|
argoproj_argo
|
train
|
go,go
|
2eaeaf3130c307fee052c845be8d585512e46dce
|
diff --git a/parler/tests/test_forms.py b/parler/tests/test_forms.py
index <HASH>..<HASH> 100644
--- a/parler/tests/test_forms.py
+++ b/parler/tests/test_forms.py
@@ -158,7 +158,7 @@ class FormTests(AppTestCase):
r1 = RegularModel.objects.create(original_field='r1')
a = ForeignKeyTranslationModel.objects.create(translated_foreign=r1, shared='EN')
- # same way as TranslatableAdmin.get_object() inicializing translation, when user swich to new translation language
+ # same way as TranslatableAdmin.get_object() inicializing translation, when user switch to new translation language
a.set_current_language('fr', initialize=True)
# inicialize form
|
docs: Fix simple typo, swich -> switch
There is a small typo in parler/tests/test_forms.py.
Should read `switch` rather than `swich`.
|
django-parler_django-parler
|
train
|
py
|
1c973330c68e0c653a19f4408a373741107eb0e3
|
diff --git a/src/core/services/theming/theming.js b/src/core/services/theming/theming.js
index <HASH>..<HASH> 100644
--- a/src/core/services/theming/theming.js
+++ b/src/core/services/theming/theming.js
@@ -439,6 +439,10 @@ function generateThemes($injector) {
THEME_COLOR_TYPES.forEach(function(colorType) {
styleString += parseRules(theme, colorType, rulesByType[colorType] + '');
});
+ if (theme.colors.primary.name == theme.colors.accent.name) {
+ console.warn("$mdThemingProvider: Using the same palette for primary and" +
+ "accent. This violates the material design spec.");
+ }
});
// Insert our newly minted styles into the DOM
|
feat(theming): warn for same palette as primary and accent
closes #<I>
|
angular_material
|
train
|
js
|
f7a785011f54ed98b6c479e8973b8ea4efd78620
|
diff --git a/tests/test_doitlive.py b/tests/test_doitlive.py
index <HASH>..<HASH> 100644
--- a/tests/test_doitlive.py
+++ b/tests/test_doitlive.py
@@ -146,7 +146,7 @@ class TestPlayer:
def test_unalias(self, runner):
user_input = random_string(len("foo"))
result = run_session(runner, "unalias.session", user_input)
- # nonzero exit code becuase 'foo' is no longer aliased
+ # nonzero exit code because 'foo' is no longer aliased
assert result.exit_code != 0
assert "foobarbazquux" not in result.output
|
docs: fix simple typo, becuase -> because (#<I>)
There is a small typo in tests/test_doitlive.py.
Should read `because` rather than `becuase`.
|
sloria_doitlive
|
train
|
py
|
1d76e3395f835a7ba45eabb690058fb2a691e413
|
diff --git a/perf/perf_test.go b/perf/perf_test.go
index <HASH>..<HASH> 100644
--- a/perf/perf_test.go
+++ b/perf/perf_test.go
@@ -43,7 +43,7 @@ func TestExponent(t *testing.T) {
{"-2", time.Millisecond},
{"-3", 500 * time.Microsecond},
{"-3", 100 * time.Microsecond},
- {"-4", 50 * time.Microsecond},
+ {"-4", 10 * time.Microsecond},
} {
tr := NewTimer()
time.Sleep(c.d)
|
perf: Make it easier to hit the <<I>μs bucket in the test
|
anacrolix_missinggo
|
train
|
go
|
abdcceda98c94821551fac0522b70c7a92f7fa59
|
diff --git a/packages/site/pages/roadmap.js b/packages/site/pages/roadmap.js
index <HASH>..<HASH> 100644
--- a/packages/site/pages/roadmap.js
+++ b/packages/site/pages/roadmap.js
@@ -25,6 +25,10 @@ const work = {
],
next: [
{
+ title: 'Icon Packs Discovery',
+ tags: ['Resources']
+ },
+ {
title: 'Sketch Libraries',
tags: ['Resources']
},
|
refactor(site): icon packs to roadmap
|
pluralsight_design-system
|
train
|
js
|
c29e173e0c1a0e3b98ac84b051c6db0750ad2ba2
|
diff --git a/src/carousel/Carousel.js b/src/carousel/Carousel.js
index <HASH>..<HASH> 100644
--- a/src/carousel/Carousel.js
+++ b/src/carousel/Carousel.js
@@ -401,7 +401,7 @@ export default class Carousel extends Component {
_getScrollOffset (event) {
const { vertical } = this.props;
return (event && event.nativeEvent && event.nativeEvent.contentOffset &&
- event.nativeEvent.contentOffset[vertical ? 'y' : 'x']) || 0;
+ Math.round(event.nativeEvent.contentOffset[vertical ? 'y' : 'x'])) || 0;
}
_getContainerInnerMargin (opposite = false) {
|
fix(Carousel): prevent loop and callback issue on android because scroll offset's value is not an integer
|
archriss_react-native-snap-carousel
|
train
|
js
|
c646eda87d8a08573fe29051b4d38b8d924badb3
|
diff --git a/src/Ufo/Core/Debug.php b/src/Ufo/Core/Debug.php
index <HASH>..<HASH> 100644
--- a/src/Ufo/Core/Debug.php
+++ b/src/Ufo/Core/Debug.php
@@ -139,14 +139,14 @@ class Debug implements DebugInterface
}
/**
- * Вывод информации о переменной.
+ * Show variable debug info.
* @param mixed $var
* @param bool $dump = true
* @param bool $exit = true
* @param bool $float = false
* @return void
*/
- public static function varDump($var, bool $dump = true, bool $exit = true, bool $float = false): void
+ public static function vd($var, bool $dump = true, bool $exit = true, bool $float = false): void
{
// @codeCoverageIgnoreStart
if ($exit) {
@@ -175,12 +175,4 @@ class Debug implements DebugInterface
}
// @codeCoverageIgnoreEnd
}
-
- /**
- * @see varDump
- */
- public static function vd($var, bool $dump = true, bool $exit = true, bool $float = false): void
- {
- self::varDump($var, $dump, $exit, $float);
- }
}
|
chore: replaced unused method instead to its alias
|
enikeishik_ufoframework
|
train
|
php
|
be6e8a3e1239417d49611acf5e01a42690c1ebdc
|
diff --git a/src/location-transformer.js b/src/location-transformer.js
index <HASH>..<HASH> 100644
--- a/src/location-transformer.js
+++ b/src/location-transformer.js
@@ -4,7 +4,7 @@ import { find } from './utils.js'
import calculateWeeklyLevels from './weekly-levels-calculator'
// centralized for whenever we implement #16
-const somethingIsWrong = () => undefined
+const somethingIsWrong = () => {}
const isVersion = (date, version) => {
const momentDate = moment().isoWeekYear(date.year).isoWeek(date.week).isoWeekday(1).startOf('day')
|
refactor: use more idiomatic version of noop
|
fielded_angular-nav-thresholds
|
train
|
js
|
f2c4274002aeea64f6547a99872749192d7803e1
|
diff --git a/application/libraries/Seeder.php b/application/libraries/Seeder.php
index <HASH>..<HASH> 100644
--- a/application/libraries/Seeder.php
+++ b/application/libraries/Seeder.php
@@ -14,6 +14,7 @@ class Seeder
protected $db;
protected $dbforge;
protected $seedPath;
+ protected $depends = [];
public function __construct()
{
@@ -29,7 +30,7 @@ class Seeder
*
* @param string $seeder Seeder classname
*/
- public function call($seeder)
+ public function call($seeder, $call_depends = true)
{
if ($this->seedPath === null)
{
@@ -37,6 +38,9 @@ class Seeder
}
$obj = $this->loadSeeder($seeder);
+ if ($call_depends === true && $obj instanceof Seeder) {
+ $obj->callDepends($this->seedPath);
+ }
$obj->run();
}
@@ -55,6 +59,24 @@ class Seeder
}
/**
+ * Call depend seeder list
+ *
+ * @param string $seedPath
+ */
+ public function callDepends($seedPath)
+ {
+ foreach ($this->depends as $path => $seeders) {
+ $this->seedPath = $seedPath;
+ if (is_string($path)) {
+ $this->setPath($path);
+ }
+
+ $this->callDepend($seeders);
+ }
+ $this->setPath($seedPath);
+ }
+
+ /**
* Call depend seeder
*
* @param string|array $seederName
|
feat: add call depends seeder list method
|
kenjis_ci-phpunit-test
|
train
|
php
|
fc3d7cd7a93534d76840418467f303d4b301fbcd
|
diff --git a/src/platforms/web/runtime/modules/dom-props.js b/src/platforms/web/runtime/modules/dom-props.js
index <HASH>..<HASH> 100644
--- a/src/platforms/web/runtime/modules/dom-props.js
+++ b/src/platforms/web/runtime/modules/dom-props.js
@@ -63,7 +63,11 @@ function shouldUpdateValue (
function isDirty (elm: acceptValueElm, checkVal: string): boolean {
// return true when textbox (.number and .trim) loses focus and its value is
// not equal to the updated value
- return document.activeElement !== elm && elm.value !== checkVal
+ let notInFocus = true
+ // #6157
+ // work around IE bug when accessing document.activeElement in an iframe
+ try { notInFocus = document.activeElement !== elm } catch (e) {}
+ return notInFocus && elm.value !== checkVal
}
function isInputChanged (elm: any, newVal: string): boolean {
|
fix: work around IE/Edge bug when accessing document.activeElement from iframe
close #<I>
|
IOriens_wxml-transpiler
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.