Datasets:

bug-localization

/

apache_bugs

like 0

Bug 44558 cite attempted address when throwing "Cannot assign requested address"

SEVERE: Error starting endpoint java.net.BindException: Cannot assign requested address:2217 at org.apache.tomcat.util.net.JIoEndpoint.init(JIoEndpoint.java:501) at org.apache.tomcat.util.net.JIoEndpoint.start(JIoEndpoint.java:515) at org.apache.coyote.http11.Http11Protocol.start(Http11Protocol.java:203) at org.apache.catalina.connector.Connector.start(Connector.java:1131) at org.apache.catalina.core.StandardService.start(StandardService.java:531) at org.apache.catalina.core.StandardServer.start(StandardServer.java:710) at org.apache.catalina.startup.Catalina.start(Catalina.java:578) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) saying which address a bind was attempted for would accelerate the error resolution quite a bit!

resolved fixed

7bd915c

["java/org/apache/tomcat/util/net/JIoEndpoint.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 44562 HEAD requests cannot go through request dispatch include.

resolved fixed

288b2ae

["java/javax/servlet/http/HttpServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 44337 Dir listing crashes if no readme-file present

DefaultServlet docu 6.0 says about attibute readmeFile: If a directory listing is presented, a readme file *may* also be presented with the listing. This file is inserted ..... This was true for 5.5.x. 6.0.14 crashes if the file is absent in the listed directory. javax.servlet.ServletException: Error opening readme resource at org.apache.catalina.servlets.DefaultServlet.getReadme(DefaultServlet.java:1418) This new behaviour blocks the listing of big directory trees managed by others, where the work-around is nor feasible. Work around 1: readme file in *every* subdir, empty (length=0) if none wanted (and subsequent changes in the used XSL-Transformers) Work around 2: Change "may" to "must" in docu. Repair: fix DefaultServlet From web.xml: <servlet> <servlet-name>default</servlet-name> <servlet-class>org.apache.catalina.servlets.DefaultServlet</servlet-class> <init-param> <param-name>listings</param-name> <param-value>true</param-value> </init-param> <init-param> <param-name>globalXsltFile</param-name> <param-value>D:\www\serv-intra\meva-dir-li.xsl</param-value> </init-param> <init-param> <param-name>readmeFile</param-name> <param-value>readme.htm</param-value> </init-param> <load-on-startup>1</load-on-startup> </servlet>

resolved fixed

8a3b14b

["java/org/apache/catalina/servlets/DefaultServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43701 Error while starting tomcat

this is my NIO Connector configuration in server.xml <Connector acceptCount="100" enableLookups="false" port="80" protocol="org.apache.coyote.http11.Http11NioProtocol" acceptorThreadCount="2" socket.bufferPool="-1" connectionTimeout="60000" maxKeepAliveRequests="-1" maxThreads="200" minSpareThreads="25" redirectPort="8443" /> when I am starting my tomcat it is giving following error in the console several time SEVERE: java.lang.NullPointerException at org.apache.tomcat.util.net.NioEndpoint.setSocketOptions(NioEndpoint.java:985) at org.apache.tomcat.util.net.NioEndpoint$Acceptor.run(NioEndpoint.java:1169) at java.lang.Thread.run(Thread.java:595)

resolved fixed

bf6ce6f

["java/org/apache/tomcat/util/net/NioEndpoint.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 44282 WebappClassLoader.findClass calls getClassLoader without privileges

When logging is in TRACE mode or lower, org.apache.catalina.loader.WebappClassLoader.findClass(String) calls getClassLoader() without a privileged block. With security enabled, this will cause a SecurityException if the RuntimePermission to getClassLoader is not granted.

resolved fixed

948598d

["java/org/apache/catalina/loader/WebappClassLoader.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 44268 Multiple registrations of same ServletContextListener class not possible

When I register the same class implementing ServletContextListener twice or more its' contextInitialized methods only gets called once. The servlet specifications (2.4 and 2.5) say the conforming container has to call the listeners in the same order they are registered in the deployment descriptor. The case that one listener class is registered twice is not mentioned explicitly in the specification, though. Example: <listener> <listener-class>test.ServletContextListener1</listener-class> </listener> <listener> <listener-class>test.ServletContextListener2</listener-class> </listener> <listener> <listener-class>test.ServletContextListener1</listener-class> </listener> test.ServletContextListener1 and test.ServletContextListener2 get called, but test.ServletContextListener1 does not get called again. Apache Tomcat 5.5.25 has the same bug.

resolved fixed

cdff09f

["java/org/apache/catalina/core/StandardContext.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 44223 Tomcat ignores the "javax.net.ssl.trustStoreType" system property

Set up a SSL Connector with a keystore in JKS format: <Connector ... SSLEnabled="true" keystoreFile="tomcat.keystore" keystoreType="JKS"> Let's say you need a custom truststore (e.g. for authenticating self-signed client certificates), and that this truststore is also needed by some of your webapps, not only Tomcat. The natural thing to do then is to configure this truststore globally for the whole JVM, not in server.xml. Let's also assume this truststore is in a different format (e.g. PKCS#12). So before starting Tomcat, you do this: export JAVA_OPTS="-Djavax.net.ssl.trustStore=trusted.keystore - Djavax.net.ssl.trustStoreType=PKCS12" Well, it doesn't work. If you look at tomcat/logs/catalina.out, you will see a keystore-related exception. Upon further debugging, you will discover the problem is that Tomcat is trying to open the truststore as if it were in JKS format, even though it is clearly specified as type PKCS12 in JAVA_OPTS above.

resolved fixed

f9e41b8

["java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43468 HTMLManagerServlet NullPointerException listing context

Obtained the following NullPointerException, stack trace below java.lang.NullPointerException org.apache.catalina.manager.HTMLManagerServlet.list(HTMLManagerServlet.java:437) org.apache.catalina.manager.HTMLManagerServlet.doGet(HTMLManagerServlet.java:136) Code is: args[11] = new Integer(context.getManager().getMaxInactiveInterval()/60); Seemingly the getManager() is returning null.

resolved fixed

e14afee

["java/org/apache/catalina/manager/HTMLManagerServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 11117 Coyote connector does not correctly deal with large PUT when using chunked transfer encoding

I've built a small test servlet (included below) that shows this behaviour. If I upload data to tomcat (configured to use the HTTP/1.1 Coyote connector) using a chunked transfer-encoding on a PUT, then the result (i.e. what I read using the servlet's request.getInputStream() is corrupted. This _only_ happens on large PUTs (it happens every time I tried it (about 10) on a large PUT - I was testing with something around 700 kB, and another thing of about 1 MB, but does NOT always corrupt it in the same way. I did not see any corruption on small files (~50 kB and smaller), though I didn't test this extensively. The total length of the data read is exactly correct (712080 bytes in my first test). At the first point of corruption in the file, a chunk header appears in the output ("\r\n1000\r\n") followed by correct data from about 700 bytes later on, then a second copy (in the correct place, I think) of the corrupt data (i.e. correct data, followed by the chunk header, followed by some data repeated, the second instance of which is in the correct place - so the first instance is being produced _instead_ of the correct data for that point in the input). Test servlet follows: import java.io.*; import javax.servlet.*; import javax.servlet.http.*; public class Test extends HttpServlet { public void doPut(HttpServletRequest req, HttpServletResponse res) throws ServletException, IOException { FileOutputStream fos = new FileOutputStream("/tmp/servlet-out"); InputStream is = req.getInputStream(); byte buf[] = new byte[2000]; int ret; while((ret = is.read(buf)) > 0) { fos.write(buf, 0, ret); } fos.close(); is.close(); PrintWriter pw = res.getWriter(); pw.println("Done"); pw.flush(); pw.close(); } }

resolved fixed

1cc6641

["java/org/apache/coyote/http11/filters/ChunkedInputFilter.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43743 Cannot jspc precompile jsps with nested .tag files

myjsp.jsp: HELLO <tag1/> tag1.tag: <tag2> tag2.tag: WORLD Crashes (null pointer) while trying to load tag2.class, called by TagFileProcessor.loadTagFile. Very Initial analysis:- TagFileProcessor.loadTagFile creates wrapper, but ctxt.getTagFileJarUrl (tagFilePath) returns null for nested .tag. Thus in JspCompilationContext.Compile JspCCtx.isPackagedFile == false, so outDated test is wrong So tag2.tag not compiled, thus class cannot be loaded. But problem also appears if tags not packaged in a .jar, so there is more going on. Work around is to create dummy.jsp that calls the .tags in leaf first order so .class files are created.

resolved fixed

98b8ba2

["java/org/apache/jasper/compiler/Parser.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43758 java.lang.NullPointerException from org.apache.jasper.compiler.ServletWriter.printMultiLn() on validation of JSPX with empty <jsp:scriptlet> element

resolved fixed

61ce1a3

["java/org/apache/jasper/compiler/Node.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43868 MBeanServer invoke issue

Impossible to invoke "removeRole" or other MBean methods and "setAttribute" by MBeanServer cause of the same bug in ManagedBean.java at both lines 545 (getSetter method) and 604 (getInvoke method): object = this; Must be replace by: object = bean; Fortunately getGetter method is correct.

resolved fixed

ccadbbc

["java/org/apache/tomcat/util/modeler/ManagedBean.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43285 Missing EL Coercion causes argument type mismatch

I'll attach a sample web application reproducing the error. Note that this error only occurs when using Tomcat 6.0.x (i.e. it works with Jetty as it uses Sun's EL RI). Moreover it doesn't matter which JSF implementation you're using to reproduce the error (I just wanted to mention that as it's definitely no bug in MyFaces even though the following stack trace shows a FacesException). The exception stack trace: javax.faces.FacesException: Exception while calling broadcast on component : {Component-Path : [Class: javax.faces.component.UIViewRoot,ViewId: /home.jsp][ Class: javax.faces.component.html.HtmlForm,Id: j_id_jsp_923754602_1][Class: javax.faces.component.html.HtmlCommandButton,Id: j_id_jsp_923754602_3]} at javax.faces.component.UIComponentBase.broadcast(UIComponentBase.java:494) at javax.faces.component.UICommand.broadcast(UICommand.java:105) at javax.faces.component.UIViewRoot._broadcastForPhase(UIViewRoot.java:292) at javax.faces.component.UIViewRoot.process(UIViewRoot.java:209) at javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:117) at org.apache.myfaces.lifecycle.InvokeApplicationExecutor.execute(InvokeApplicationExecutor.java:32) at org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:95) at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:70) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:144) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:263) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:584) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447) at java.lang.Thread.run(Thread.java:619) Caused by: org.apache.jasper.el.JspELException: /home.jsp(12,3) '#{numberBean.number}' java.lang.IllegalArgumentException: argument type mismatch at org.apache.jasper.el.JspValueExpression.setValue(JspValueExpression.java:94) at org.apache.myfaces.event.SetPropertyActionListener.processAction(SetPropertyActionListener.java:72) at javax.faces.event.ActionEvent.processListener(ActionEvent.java:48) at javax.faces.component.UIComponentBase.broadcast(UIComponentBase.java:489) ... 20 more Caused by: java.lang.IllegalArgumentException: argument type mismatch at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at javax.el.BeanELResolver.setValue(BeanELResolver.java:108) at javax.el.CompositeELResolver.setValue(CompositeELResolver.java:68) at org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver.access$501(FacesCompositeELResolver.java:46) at org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver$6.invoke(FacesCompositeELResolver.java:132) at org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver.invoke(FacesCompositeELResolver.java:148) at org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver.setValue(FacesCompositeELResolver.java:128) at org.apache.el.parser.AstValue.setValue(AstValue.java:114) at org.apache.el.ValueExpressionImpl.setValue(ValueExpressionImpl.java:249) at org.apache.jasper.el.JspValueExpression.setValue(JspValueExpression.java:85) ... 23 more

resolved fixed

c5bcc98

["java/org/apache/el/parser/AstValue.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42503 ServletContext.getResourceAsStream returns stale data

Under certain conditions, the resource cache implementation used by the servlet/JSP engine (in org.apache.naming.resource) does not detect that a file in its cache has been modified and therefore returns the previous contents of the file. This happens only * when the file contents are modified but the file length doesn't change * until the time the first change in the file is detected after server startup To reproduce the problem, put the attached test.jsp and test.txt into the ROOT web app and then do the following. (I used Tomcat 6's trunk for the test) % cat test.txt abcd % telnet . 9080 Trying 0.0.0.0... Connected to .. Escape character is '^]'. GET /test.jsp HTTP/1.0 HTTP/1.1 200 OK Server: Apache-Coyote/1.1 Set-Cookie: JSESSIONID=706D6FE8B06687509D42E79DBEE266EF; Path=/ Content-Type: text/html Content-Length: 26 Date: Wed, 23 May 2007 23:03:05 GMT Connection: close File contents=[ abcd ] Connection to . closed by foreign host. % cat test.txt (change the contents but not the size) efgh % telnet . 9080 Trying 0.0.0.0... Connected to .. Escape character is '^]'. GET /test.jsp HTTP/1.0 HTTP/1.1 200 OK Server: Apache-Coyote/1.1 Set-Cookie: JSESSIONID=2B144247B747F54184114FA82869DE14; Path=/ Content-Type: text/html Content-Length: 26 Date: Wed, 23 May 2007 23:04:24 GMT Connection: close File contents=[ abcd ]

resolved fixed

2441155

["java/org/apache/naming/resources/FileDirContext.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43914 HTTP spec violation when generating HTTP redirects for folders without trailing slash

resolved fixed

e452200

["java/org/apache/catalina/connector/CoyoteAdapter.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43909 EL EvaluationContext wrapper hides locale

org.apache.el.lang.EvaluationContext doesn't pass locale to the wrapped ELContext as does org.apache.jasper.el.ELContextWrapper. This prohibits using of the locale for it's original purpose.

resolved fixed

fdb170e

["java/org/apache/el/lang/EvaluationContext.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43944 org.apache.el.lang.ELArithmetic.coerce throws MissingResourceException for key el.convert

The class org.apache.el.lang.ELArithmetic has the following code snippet: throw new IllegalArgumentException(MessageFactory.get("el.convert", obj, objType)); But the key "el.convert" doesn't exist in "org.apache.el.Messages". As a result, I'm receiving the exception: java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key el.convert at java.util.ResourceBundle.getObject(ResourceBundle.java:325) at java.util.ResourceBundle.getString(ResourceBundle.java:285) at org.apache.el.util.MessageFactory.getArray(MessageFactory.java:67) at org.apache.el.util.MessageFactory.get(MessageFactory.java:47) at org.apache.el.lang.ELArithmetic.coerce(ELArithmetic.java:367) at org.apache.el.lang.ELArithmetic.add(ELArithmetic.java:238) at org.apache.el.parser.AstPlus.getValue(AstPlus.java:24) at org.apache.el.ValueExpressionImpl.getValue (ValueExpressionImpl.java:186)

resolved fixed

c228054

["java/org/apache/el/lang/ELArithmetic.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 44088 Cannot expire session via html manager webapp

The html manager webapp done not work correctly when clicking the expire sessions button. The idle param is missing from the form. The following html shows this bug... <form method="POST" action="/manager/html/expire?path=/"> <small> &nbsp;<input type="submit" value="Expire sessions">&nbsp;with idle &ge;&nbsp;<input type="text" name="expire" size="5" value="30">&nbsp;minutes&nbsp; </small> </form> The name of the text input should be idle.

resolved fixed

df2b1e6

["java/org/apache/catalina/manager/HTMLManagerServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 44084 JAASRealm useContextClassLoader has problems

The useContextClassLoader config option doesn't work right. - it is ignored when setting userClassNames and roleClassNames - it's respected when the LoginContext is created, but that is insufficient, because all the needed classes are not necessarily loaded until loginContext.login() is called Patch to follow. With it I'm able to keep everything related to the JAASRealm in my webapp.

resolved fixed

46721e4

["java/org/apache/catalina/realm/JAASRealm.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43236 Response.setCharacterEncoding() fails after Response.getWriter() and Response.reset()

The class org.apache.catalina.connector.Response resets the internal hold coyoteResponse and outputBuffer during reset(): public void reset() { if (included) return; // Ignore any call from an included servlet coyoteResponse.reset(); outputBuffer.reset(); } but if anyone has already set the characterEncoding (e.g. to UTF-8) and already got the writer, than all following invocations of request.setCharacterEncoding() will do nothing, because the internal save flag for usingWriter is not reseted. This is very annoying, because the coyoteResponse.reset(), resets the characterEncoding to iso8859-1. So I have no change to change/reset the charaterEncoding to UTF-8. I'll think if you reset the response, you should also reset the usingWriter flag or add another special flag, that works with this circumstances.

resolved fixed

71bd193

["java/org/apache/catalina/connector/Response.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43241 ServletContext.getResourceAsStream() does not follow API specs for Path

resolved fixed

8f91433

["java/org/apache/catalina/core/ApplicationContext.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43611 autodeployment with unpackWARs="true" does not work, when a context for that war file exists in server.xml

if a context for the war file exists in server.xml, the manager uploads the new .war file, but does not expand it, if the necessary directory does not exist, and if the directory exists, it is not overwritten, so you see the old application. see server.xml <Host name="xxx" appBase="webapps" unpackWARs="true"> <Context path="/yyy"> ... if I don't have a context for yyy in server.xml, autodeploy works as expected. Even if you say, remove context from the manager application, it is always there in the application view, you can't remove it. And finally, it never cleans up the work directory for the application yyy, which I guess, is just a subsequent error of the above behaviour.

resolved fixed

ffbbe88

["java/org/apache/catalina/manager/HTMLManagerServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43622 compression / minCompressionSize attribute not properly implemented

2 of the compression related attributes for the http connector are: compression = on | off | force | <integer val> The documentation states that integer val will be implemented as: compression="on" and minCompressionSize = <integer val> minCompressionSize = <integer val> (The documentation for 5.5.12 doesnt mention this at all, but read this in the server.xml) The problem is that the documenation gives the impression that only setting compression="some integer val" is sufficient, however the way the code is written, the value of "minCompressionSize" always overrides the value specified in the "compression" field. Even if minCompressionSize isnt set, it will still get the default value of 2048 and override whatever value was there in the "compression" field. I looked at the implementation of the http11 connector and found the following code that might be the culprit: In org.apache.coyote.http11.Http11BaseProtocol.Http11ConnectionHandler.init processor.setCompression( proto.compression ); processor.setCompressionMinSize( proto.compressionMinSize); since the "setCompressionMinSize" is called after compressionMinSize, its value will override the value read from compression atttribute. I have looked at the code for Tomcat 6.0 also, and the problems appears to still be present.

resolved fixed

d1d0619

["java/org/apache/coyote/http11/Http11AprProtocol.java", "java/org/apache/coyote/http11/Http11NioProtocol.java", "java/org/apache/coyote/http11/Http11Protocol.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43757 Improper parsing of response.sendRedirect() in JSP source

Tomcat is throwing a java.lang.illegalStateException due to an attempted response.sendRedirect() after the time for such matters has come and gone... But, this appears to be a symptom of bad .jsp parsing at runtime. ========================== org.apache.jasper.JasperException: Exception in JSP: /buslog.jsp:42 39: // if (session.getAttribute("isAuth") == null) { 40: // session.setAttribute("messageToUser","Authentication failed."); 41: // you.shouldNotParseThis(); 42: // response.sendRedirect("./index.jsp"); 43: // } 44: 45: // if (session.getAttribute("isAuth") != null) { ============================== These lines are commented out in the source, and should not conceivably cause a runtime error. Changing "response.sendRedirect(...)" to "response.sendAbendOMG(...)" suppresses the error. I am willing to provide the complete source if necessary. Build and execution environments are NetBeans 5.5.1 with bundled Tomcat 5.5.17.

resolved fixed

eb87635

["java/org/apache/jasper/compiler/ErrorDispatcher.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43706 Fix a litmus warning for WebdavServlet

resolved fixed

324387d

["java/org/apache/catalina/servlets/WebdavServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43887 StandardWrapper.registerJMX() doesn't log exceptions correctly

I was getting some rather unhelpful error messages when trying to deploy a web.xml that included illegal servlet names. I tracked them down to this part of /org/apache/catalina/core/StandardWrapper.java: } catch( Exception ex ) { log.info("Error registering servlet with jmx " + this); } This should probably be changed to: log.info("Error registering servlet with jmx " + ex); Same thing for the catch block ten lines below this one. I first noticed this in 5.5.23, but this code is still present in 6.0 trunk.

resolved fixed

9314e5b

["java/org/apache/catalina/core/StandardWrapper.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43893 WebdavServlet returns incorrect values for the "href" property when it is mapped with / url prefix, instead of /*

resolved wontfix

3c61f9b

["java/org/apache/catalina/servlets/WebdavServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43479 APR sendfile thread leaks memory

The APR sendfile thread leaks memory by adding SendfileData objects to its HashMap and failing to remove them.

resolved fixed

16464d6

["java/org/apache/tomcat/util/net/AprEndpoint.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43453 ClassCastException at org.apache.catalina.core.StandardContext.findStatusPage(int)

StandardContext.java reads public String findStatusPage(int status) { return ((String) statusPages.get(new Integer(status))); } This is wrong and it should be public String findStatusPage(int status) { return ((ErrorPage) statusPages.get(new Integer(status))).getLocation(); } Regards, lg

resolved fixed

73b5e41

["java/org/apache/catalina/core/StandardContext.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43435 AbstractReplicatedMap.memberDisappeared is executed more than the necessity.

resolved fixed

5aed2f5

["java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43356 keystoreFile parameter, when specified as relative, is not treated relative to $CATALINA_BASE or catalina.base property for NioEndPoint

resolved fixed

28da141

["java/org/apache/coyote/http11/Http11NioProtocol.java", "java/org/apache/tomcat/util/net/NioEndpoint.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 30949 After Failed Include, Request and Response not Unwrapped

In org.apache.catalina.core.ApplicationDispatcher.doInclude(ServletRequest request, ServletResponse response), after invoke() is called to perform the include, the request and response objects are normally unwrapped. However, if a ServletException or IOException is thrown, the unwrapping does not take place. This leads to problems in environments in which cross context includes are being performed. For example, 1. Web App A performs an include to a Servlet in Web App B 2. The Servlet in Web App B throws a ServletException 3. Web App A catches the ServletException and attempts to forward to an error jsp. Step 3 above will fail due to the fact that the request has not been unwrapped. The active request will contain the ServletContext of web app B and the jsp file will not be found.

resolved fixed

4dd22a5

["java/org/apache/catalina/core/ApplicationDispatcher.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 43216 ACTIVITY_CHECK does not work correctly when Tomcat is restarted

resolved fixed

9c37a01

["java/org/apache/catalina/session/StandardManager.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42944 plus sign in url-pattern in servlet-mapping does not work

Hi all, I had servlet-mappings that contain plus signs (they were created by JspC), e.g.: <servlet-mapping> <servlet-name>org.apache.jsp.suchergebnis_005fbu_002bbb_jsp</servlet-name> <url-pattern>/suchergebnis_bu+bb.jsp</url-pattern> </servlet-mapping> This mapping does not work (the referred class is present)! When I change the original file names of the JSPs such that the plus signs are replaced by a minus signs the following mapping results: <servlet-mapping> <servlet-name>org.apache.jsp.suchergebnis_005fbu_002dbb_jsp</servlet-name> <url-pattern>/suchergebnis_bu-bb.jsp</url-pattern> </servlet-mapping> Now the mapping works. Therefore I assume that there is a bug in handling servlet mappings with plus signs in their url pattern.

resolved fixed

44e36ea

["java/org/apache/catalina/util/RequestUtil.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 39212 a bug in example code DummyCart.java

resolved fixed

8aa247e

["webapps/examples/WEB-INF/classes/sessions/DummyCart.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42753 Race condition when using available() or reading in CometProcessor.event()

Tomcat version: 6.0.13 (no 6.0.13 available in the version field) When trying to process data in CometProcessor.event() either during the BEGIN event or during the READ event, it is impossible to guarantee that all data has been read before returning (since new data may arrive between the last statement before the return, and the return statement itself). However, the CoyoteProcessor does this check: } else if (!error && read && request.getAvailable()) { // If this was a read and not all bytes have been read, or if no data // was read from the connector, then it is an error error = true; log.error(sm.getString("coyoteAdapter.read")); } causing a severe error and the Comet request to break when this race condition manifests itself. I am using the following code according to the aio.html description to read data in my comet event handler: while (request.getInputStream().available() > 0) { // read some data } // ***** NO MORE DATA AVAILABLE return; And I am experiencing the error as described in certain conditions (rapid arrival of fragmented data): SEVERE: The servlet did not read all available bytes during the processing of the read event

resolved fixed

a6ea14d

["java/org/apache/catalina/core/ApplicationFilterFactory.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41722 role-link tag in web.xml can not be omitted.

The application with follwing web.xml can not be deployed. --- <servlet> <servlet-name>sample</servlet-name> <servlet-class>sample.TheServlet</servlet-class> <security-role-ref> <role-name>users</role-name> </security-role-ref> </servlet> <servlet-mapping> .... </servlet-mapping> <security-role> <role-name>users</role-name> </security-role> --- "java.lang.IllegalArgumentException: Can't convert argument: null" occurred. The Specification says: --- The security-role-ref element declares the security role reference in a components or in a deployment components code. It consists of an optional description, the security role name used in the code(role-name), and an optional link to a security role(role-link). --- <role-link> is optional.

resolved fixed

ba25bfb

["java/org/apache/catalina/deploy/SecurityRoleRef.java", "java/org/apache/catalina/startup/WebRuleSet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42314 Jasper output no details with compilation error in specific case.

Jasper output no details when Jasper cannot find mappings between generated servlet code (with mistakes) and former JSP. One example JSP is the following. (The imported class in the JSP is not found.) --- <%@ page import = "not.exist.class" %> ---

resolved fixed

6c6ad83

["java/org/apache/jasper/compiler/JavacErrorDetail.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42547 Same env-entry (web.xml) and ResourceLink (context) names causes NPE

Having the following in web.xml: <env-entry> <env-entry-name>testIt</env-entry-name> <env-entry-type>java.lang.String</env-entry-type> <env-entry-value>test</env-entry-value> </env-entry> and the following in your context descriptor: <ResourceLink name="testIt" global="testIt" type="java.lang.String"/> causes an NPE on context load. java.lang.NullPointerException at org.apache.catalina.deploy.NamingResources.addEnvironment(NamingResources.java:188) This assumes you have an entry for 'testIt' in the <GlobalNamingResources> section of server.xml to link to. This worked in 5.5.20. No longer works in 5.5.23.

resolved fixed

53add24

["java/org/apache/catalina/deploy/NamingResources.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42643 Duplicate JSP function mapper variables

When we deploy ~20 or so web apps at a time, we invariably end up with an app or two on each server that has compilation errors due to code generated like this: static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_0; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_1; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_2; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_3; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_4; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_5; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_6; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_7; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_0; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_1; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_2; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_3; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_4; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_5; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_6; static private org.apache.jasper.runtime.ProtectedFunctionMapper _jspx_fnmap_7; This looks like it might be as simple as unsynchronized access to the static 'currFunc' in ELFunctionMapper, but I'm far from an expert on this code and unfortunately lack the time to become one. :) This only appears to happen when we mass-deploy apps, and we can resolve it by deleting the generated .java file and manually restarting the affected app.

resolved fixed

5b65cf4

["java/org/apache/jasper/compiler/ELFunctionMapper.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42497 304 response should consistently include ETag header

resolved fixed

0114b2d

["java/org/apache/catalina/servlets/DefaultServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42559 ErrorReportValve does not provide an error report

rev 535915 changed the behavior of ErrorReportValve in tomcat6 to not produce an error report when response.sendError() is called. For example, using this code in a servlet's service() does not produce an error report: response.sendError(HttpServletResponse.SC_GONE, "error occurred"); The underlying cause is that the valve's check for response.isCommitted() was replaced with response.isAppCommitted(). The latter returns true, which causes the Valve's invoke() method to immediately return instead of producing the report.

resolved fixed

71eccb3

["java/org/apache/catalina/valves/ErrorReportValve.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 39875 RealmBase#init() needs cleanup

resolved fixed

0ea4c7c

["java/org/apache/catalina/realm/RealmBase.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42438 Duplicate JSP temp variable declaration when jsp:attribute used in conjunction with custom tags

resolved fixed

5e188bc

["java/org/apache/jasper/compiler/Node.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42459 Tomcat Web Application Manager table error

html table -> tr wrong formating when stop (not last) in Tomcat Web Application Manager.

resolved fixed

33c9949

["java/org/apache/catalina/manager/HTMLManagerServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42444 Potential NullPointerException in org.apache.catalina.valves.AccessLogValve

resolved fixed

776736f

["java/org/apache/catalina/valves/AccessLogValve.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42361 POST content type incorrect for multipart forms after login

When using a form with a custom encoding (e.g. "multipart/form-data"), the content type is not restored after a redirect to a login page (auth-method = FORM). To reproduce: - A page that POSTs using multipart/form-data encoding (or anything other than application/x-www-form-urlencoded) to a result page that is protected by a login page (auth-method=FORM) is invoked. - Even though the multipart POST data exists (verified by reading input stream of request from result page) the content type of the request is always "application/x-www-form-urlencoded". - This only happens when redirected to the login page first. It does not happen if already logged in.

resolved fixed

637acc5

["java/org/apache/catalina/authenticator/FormAuthenticator.java", "java/org/apache/catalina/authenticator/SavedRequest.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42309 Request: support for NIO in Embedded Tomcat

in org.apache.catalina.startup.Embedded there is no direct API to create an NIO connector. This would be very helpful for all applications which use tomcat in embedded mode and require the CometProcessor.

resolved fixed

9546005

["java/org/apache/catalina/startup/Embedded.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42308 with APR bytessent bytesreceived performance data is not collected

with APR bytes received and bytes sent are always 0.

resolved fixed

4a04722

["java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/coyote/http11/Http11AprProtocol.java", "java/org/apache/coyote/http11/Http11NioProcessor.java", "java/org/apache/coyote/http11/InternalNioInputBuffer.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42202 if you install tomcat in a directory with spaces it ignores TLD files inside jar files

if you install tomcat or a web application in a directory with spaces in the name, for example "C:\Program Files\vds\tomcat" for tomcat or "C:\Program Files\vds\console" for a web application. the TLD files that are inside the META-INF directory of the jar files will not be loaded. the problem is is the file treatment inside the TldConfig class ... I have attached a patch with the correction. this bug is found in Tomcat 6 too

resolved fixed

f9ddaba

["java/org/apache/catalina/startup/TldConfig.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42071 If a JSP throws an UnavailableException twice, an IllegalStateException occurs.

If a JSP throws an UnavailableException twice, an IllegalStateException occurs. first access: JSP throws UnavailableException. second access: If the JSP throws an UnavailableException again then an IllegalStateException occurs and Tomcat returns status code:500 to the client. The problem is not that the IllegalStateException occurs. The problem is that the JSP can be called even though it cannot be used.

resolved fixed

508f513

["java/org/apache/jasper/servlet/JspServletWrapper.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42039 Tomcat doesn't output the stack trace of UnavailableException.

When UnavailableException is thrown from the Servlet:init, Tomcat doesn't output the stack trace of UnavailableException. The cause of problem is lost. Tomcat should output the stack trace at the "invoke" method of StandardWrapperValue.

resolved fixed

c3d2ce4

["java/org/apache/catalina/core/StandardWrapperValve.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42119 request.getCharacterEncoding misparses charset=UTF-8; xyz=3

(This bug is also present in Coyote source 6.0.10.) If there is an HTTP header Content-Type: text/abc; charset=UTF-8; xyz=3 request.getCharacterEncoding() returns "UTF-8; xyz=3" but Tomcat 4.1.24 returns "UTF-8". In Tomcat 4.1.24, request.getCharacterEncoding uses parseCharacterEncoding defined in jakarta-tomcat-4.1.24-src/catalina/src/share/org/apache/catalina/util/RequestUtil.java and it correctly handles the case of other Content-Type parameters. In Tomcat 5.5.23, however, request.getCharacterEncoding uses getCharsetFromContentType defined in from apache-tomcat-5.5.23-src/connectors/util/java/org/apache/tomcat/util/http/ContentType.java which does not search for a possible terminating semicolon in the charset, thus erroneously including additional characters in the charset. The code in 5.5.23 has a comment begins // Basically return everything after ";charset=" Please consider using the code from 4.1.24 This problem showed up when Content-Type was multipart/mixed and a client specified a charset parameter to Content-Type; however, it will occur in any Content-Type where charset is specified and is not the last parameter.

resolved fixed

4cf171a

["java/org/apache/tomcat/util/http/ContentType.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42085 java.util.Logging duplicated since 5.5.23. 5.5.20 is OK

We use the followwing logging.properties in our WebApplication: ----------%<--------------------%<---------------- handlers = 1tivoli.java.util.logging.FileHandler, 2product.java.util.logging.FileHandler # Handlers for the root logger .handlers = 1tivoli.java.util.logging.FileHandler, 2product.java.util.logging.FileHandler 1tivoli.java.util.logging.FileHandler.level = INFO 1tivoli.java.util.logging.FileHandler.pattern = /var/log/product/tivoli%g.log # limit Output to 1MB 1tivoli.java.util.logging.FileHandler.limit=1048576 # Limit rotation to 10 Logs ... 1tivoli.java.util.logging.FileHandler.count=10 1tivoli.java.util.logging.FileHandler.append=true 1tivoli.java.util.logging.FileHandler.formatter=de.customer.product.tivoli.TivoliFormatter 2product.java.util.logging.FileHandler.level = FINEST 2product.java.util.logging.FileHandler.pattern = /var/log/product/product%g.log # limit Output to 1MB 2product.java.util.logging.FileHandler.limit=1048576 # Limit rotation to 5 Logs ... 2product.java.util.logging.FileHandler.count=5 2product.java.util.logging.FileHandler.append=true 2product.java.util.logging.FileHandler.formatter=java.util.logging.SimpleFormatter ----------%<--------------------%<---------------- When using apache-tomcat-5.5.23 every Line in the Logfiles is duplicated. Debugging I found that the TivoliFormatter is actually created twice. And the root-logger has actually 4 Handlers and not two as intended. This does not allow us an upgrade beyond 5.5.20. Found on Linux64Bit and Windows-XP, both with JDK 1.5_R11

resolved fixed

fa2b746

["java/org/apache/juli/ClassLoaderLogManager.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 42072 The call of the jspDestroy method violates it about the Java Servlet Specification 2.4, SRV.2.3.2.1.

When a JSP is accessed for a second time, the jspDestroy method is called even if a ServletException is thrown from the init method of the class that extends HttpJspPage. This violates the Java Servlet Specification 2.4, SRV.2.3.2.1.

resolved fixed

3d27771

["java/org/apache/jasper/servlet/JspServletWrapper.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41289 Error when deploying XML Configuration file URL

I tried to deploy a webapp using a context.xml file under manager webapp and received this error: java.io.FileNotFoundException: /opt/apache-tomcat-6.0.2/conf/Catalina/localhost/mywebapp3.xml (No such file or directory) at java.io.FileOutputStream.open(Native Method) at java.io.FileOutputStream.<init>(FileOutputStream.java:179) at java.io.FileOutputStream.<init>(FileOutputStream.java:131) at org.apache.catalina.manager.ManagerServlet.copyInternal(ManagerServlet.java:1570) at org.apache.catalina.manager.ManagerServlet.copy(ManagerServlet.java:1530) at org.apache.catalina.manager.ManagerServlet.deploy(ManagerServlet.java:803) at org.apache.catalina.manager.HTMLManagerServlet.deployInternal(HTMLManagerServlet.java:249) at org.apache.catalina.manager.HTMLManagerServlet.doGet(HTMLManagerServlet.java:96) at javax.servlet.http.HttpServlet.service(HttpServlet.java:690) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:228) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:525) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:212) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:818) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:624) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:445) at java.lang.Thread.run(Thread.java:613) I did checked and noticed apache-tomcat-6.0.2/conf/Catalina directory no longer exists in version 6. Did something changed?

resolved fixed

d721522

["java/org/apache/catalina/manager/ManagerServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41703 Variable assigned with it's own value.

resolved fixed

2049b78

["java/org/apache/catalina/ha/authenticator/SingleSignOnMessage.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41682 ClassCastException with BackupManager + debug logging

(Still happening in 6.0.9, though that isn't an option in Bugzilla) If I use the BackupManager for session replication AND turn on debug logging, I get this exception when I try to invalidate the session: java.lang.ClassCastException: org.apache.catalina.ha.session.BackupManager cannot be cast to org.apache.catalina.ha.session.DeltaManager at org.apache.catalina.ha.session.DeltaSession.expire(DeltaSession.java:361) at org.apache.catalina.ha.session.DeltaSession.expire(DeltaSession.java:352) at org.apache.catalina.session.StandardSession.expire(StandardSession.java:660) at org.apache.catalina.session.StandardSession.invalidate(StandardSession.java:1112) at org.apache.catalina.session.StandardSessionFacade.invalidate(StandardSessionFacade.java:150) The bug is easy to find in the source. If debug logging is enabled, it tries to cast manager to DeltaManager without an instanceof, even though it is doing an instanceof immediately after: public void expire(boolean notify, boolean notifyCluster) { String expiredId = getIdInternal(); super.expire(notify); if (notifyCluster) { if (log.isDebugEnabled()) log.debug(sm.getString("deltaSession.notifying", ((DeltaManager)manager).getName(), new Boolean(isPrimarySession()), expiredId)); if ( manager instanceof DeltaManager ) { ( (DeltaManager) manager).sessionExpired(expiredId); } } }

resolved fixed

12d912d

["java/org/apache/catalina/ha/session/DeltaSession.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41166 Unable to start ReplicatedContext

I try to test the Cluster function. I got a problem: something like following apears in the $CATALINA_HOME/logs/catalina.out SEVERE: Unable to start ReplicatedContext java.lang.ClassCastException: org.apache.naming.resources.ProxyDirContext cannot be cast to java.io.Serializable at org.apache.catalina.tribes.tipis.AbstractReplicatedMap$MapEntry.setValue (AbstractReplicatedMap.java:1060) I didn't change any file in $CATALINA_HOME except server.xml, the any thing I changed in server.xml is uncomment the line: <Cluster className="org.apache.catalina.ha.tcp.SimpleTcpCluster"/>. and I add a context configuration file test.xml to $CATALINA_HOME/conf/Catalina/localhost with the flolling content [Aray@BONC-01 conf]$ cat Catalina/localhost/test.xml <Context className="org.apache.catalina.ha.context.ReplicatedContext" path="/test" docBase="/var/www/ClusterTest" debug="0" privileged="true" reloadable="true" > the web.xml file in /var/www/ClusterTest has no <distributable/> element I am worrying about I can't explain the problem clearly with my poor English. So I paste the stepes I do as following: [Aray@BONC-01 apache-tomcat-6.0.2]$ which java /usr/java/jdk1.6.0/bin/java [Aray@BONC-01 apache-tomcat-6.0.2]$ java -version java version "1.6.0-rc" Java(TM) SE Runtime Environment (build 1.6.0-rc-b104) Java HotSpot(TM) Client VM (build 1.6.0-rc-b104, mixed mode, sharing) [Aray@BONC-01 apache-tomcat-6.0.2]$ echo $JAVA_HOME /usr/java/jdk1.6.0 [Aray@BONC-01 apache-tomcat-6.0.2]$ echo $CLASSPATH [Aray@BONC-01 apache-tomcat-6.0.2]$ uname -a Linux BONC-01 2.6.9-34.EL #1 Wed Mar 8 00:07:35 CST 2006 i686 i686 i386 GNU/Linux [root@BONC-01 local]# cat /etc/redhat-release CentOS release 4.3 (Final) [Aray@BONC-01 apache-tomcat-6.0.2]$ cd conf [Aray@BONC-01 conf]$ cat server.xml <!-- Note: A "Server" is not itself a "Container", so you may not define subcomponents such as "Valves" at this level. Documentation at /docs/config/server.html --> <Server port="8005" shutdown="SHUTDOWN"> <!--APR library loader. Documentation at /docs/apr.html --> <Listener className="org.apache.catalina.core.AprLifecycleListener" SSLEngine="on" /> <!--Initialize Jasper prior to webapps are loaded. Documentation at /docs/jasper-howto.html --> <Listener className="org.apache.catalina.core.JasperListener" /> <!-- JMX Support for the Tomcat server. Documentation at /docs/non- existent.html --> <Listener className="org.apache.catalina.mbeans.ServerLifecycleListener" /> <Listener className="org.apache.catalina.mbeans.GlobalResourcesLifecycleListener" /> <!-- Global JNDI resources Documentation at /docs/jndi-resources-howto.html --> <GlobalNamingResources> <!-- Editable user database that can also be used by UserDatabaseRealm to authenticate users --> <Resource name="UserDatabase" auth="Container" type="org.apache.catalina.UserDatabase" description="User database that can be updated and saved" factory="org.apache.catalina.users.MemoryUserDatabaseFactory" pathname="conf/tomcat-users.xml" /> </GlobalNamingResources> <!-- A "Service" is a collection of one or more "Connectors" that share a single "Container" Note: A "Service" is not itself a "Container", so you may not define subcomponents such as "Valves" at this level. Documentation at /docs/config/service.html --> <Service name="Catalina"> <!-- A "Connector" represents an endpoint by which requests are received and responses are returned. Documentation at : Java HTTP Connector: /docs/config/http.html (blocking & non-blocking) Java AJP Connector: /docs/config/ajp.html APR (HTTP/AJP) Connector: /docs/apr.html Define a non-SSL HTTP/1.1 Connector on port 8080 --> <Connector port="8080" protocol="HTTP/1.1" maxThreads="150" connectionTimeout="20000" redirectPort="8443" /> <!-- Define a SSL HTTP/1.1 Connector on port 8443 This connector uses the JSSE configuration, when using APR, the connector should be using the OpenSSL style configuration described in the APR documentation --> <!-- <Connector port="8443" protocol="HTTP/1.1" maxThreads="150" scheme="https" secure="true" clientAuth="false" sslProtocol="TLS" /> --> <!-- Define an AJP 1.3 Connector on port 8009 --> <Connector port="8009" protocol="AJP/1.3" redirectPort="8443" /> <!-- An Engine represents the entry point (within Catalina) that processes every request. The Engine implementation for Tomcat stand alone analyzes the HTTP headers included with the request, and passes them on to the appropriate Host (virtual host). Documentation at /docs/config/engine.html --> <!-- You should set jvmRoute to support load-balancing via AJP ie : <Engine name="Standalone" defaultHost="localhost" jvmRoute="jvm1"> --> <Engine name="Catalina" defaultHost="localhost"> <!--For clustering, please take a look at documentation at: /docs/cluster-howto.html (simple how to) /docs/config/cluster.html (reference documentation) --> <Cluster className="org.apache.catalina.ha.tcp.SimpleTcpCluster"/> <!-- The request dumper valve dumps useful debugging information about the request and response data received and sent by Tomcat. Documentation at: /docs/config/valve.html --> <!-- <Valve className="org.apache.catalina.valves.RequestDumperValve"/> --> <!-- This Realm uses the UserDatabase configured in the global JNDI resources under the key "UserDatabase". Any edits that are performed against this UserDatabase are immediately available for use by the Realm. --> <Realm className="org.apache.catalina.realm.UserDatabaseRealm" resourceName="UserDatabase"/> <!-- Define the default virtual host Note: XML Schema validation will not work with Xerces 2.2. --> <Host name="localhost" appBase="webapps" unpackWARs="true" autoDeploy="true" xmlValidation="false" xmlNamespaceAware="false"> <!-- SingleSignOn valve, share authentication between web applications Documentation at: /docs/config/valve.html --> <!-- <Valve className="org.apache.catalina.authenticator.SingleSignOn" /> --> <!-- Access log processes all example. Documentation at: /docs/config/valve.html --> <!-- <Valve className="org.apache.catalina.valves.FastCommonAccessLogValve" directory="logs" prefix="localhost_access_log." suffix=".txt" pattern="common" resolveHosts="false"/> --> </Host> </Engine> </Service> </Server> [Aray@BONC-01 conf]$ mkdir Catalina [Aray@BONC-01 conf]$ ln -s /usr/local/tomcatConf/localhost/ Catalina/localhost [Aray@BONC-01 conf]$ cat Catalina/localhost/test.xml <Context className="org.apache.catalina.ha.context.ReplicatedContext" path="/test" docBase="/var/www/ClusterTest" debug="0" privileged="true" reloadable="true" > </Context> [Aray@BONC-01 conf]$ cd .. [Aray@BONC-01 apache-tomcat-6.0.2]$ ls bin conf lib LICENSE logs NOTICE RELEASE-NOTES RUNNING.txt temp webapps work [Aray@BONC-01 apache-tomcat-6.0.2]$ rm logs/* [Aray@BONC-01 apache-tomcat-6.0.2]$ bin/catalina.sh version Using CATALINA_BASE: /home/Aray/download/apache-tomcat-6.0.2 Using CATALINA_HOME: /home/Aray/download/apache-tomcat-6.0.2 Using CATALINA_TMPDIR: /home/Aray/download/apache-tomcat-6.0.2/temp Using JRE_HOME: /usr/java/jdk1.6.0 Server version: Apache Tomcat/6.0.2 Server built: Nov 16 2006 12:31:06 Server number: 6.0.2.0 OS Name: Linux OS Version: 2.6.9-34.EL Architecture: i386 JVM Version: 1.6.0-rc-b104 JVM Vendor: Sun Microsystems Inc. [Aray@BONC-01 apache-tomcat-6.0.2]$ bin/startup.sh Using CATALINA_BASE: /home/Aray/download/apache-tomcat-6.0.2 Using CATALINA_HOME: /home/Aray/download/apache-tomcat-6.0.2 Using CATALINA_TMPDIR: /home/Aray/download/apache-tomcat-6.0.2/temp Using JRE_HOME: /usr/java/jdk1.6.0 [Aray@BONC-01 apache-tomcat-6.0.2]$ cat logs/catalina.out INFO: Initializing Coyote HTTP/1.1 on http-8080 Dec 13, 2006 4:07:39 PM org.apache.catalina.startup.Catalina load INFO: Initialization processed in 2532 ms Dec 13, 2006 4:07:40 PM org.apache.catalina.core.StandardService start INFO: Starting service Catalina Dec 13, 2006 4:07:40 PM org.apache.catalina.core.StandardEngine start INFO: Starting Servlet Engine: Apache Tomcat/6.0.2 Dec 13, 2006 4:07:40 PM org.apache.catalina.ha.tcp.SimpleTcpCluster start INFO: Cluster is about to start Dec 13, 2006 4:07:40 PM org.apache.catalina.tribes.transport.ReceiverBase bind INFO: Receiver Server Socket bound to:/127.0.0.1:4000 Dec 13, 2006 4:07:40 PM org.apache.catalina.tribes.membership.McastServiceImpl setupSocket INFO: Setting cluster mcast soTimeout to 500 Dec 13, 2006 4:07:40 PM org.apache.catalina.tribes.membership.McastServiceImpl waitForMembers INFO: Sleeping for 1000 milliseconds to establish cluster membership, start level:4 Dec 13, 2006 4:07:41 PM org.apache.catalina.tribes.membership.McastServiceImpl waitForMembers INFO: Done sleeping, membership established, start level:4 Dec 13, 2006 4:07:41 PM org.apache.catalina.tribes.membership.McastServiceImpl waitForMembers INFO: Sleeping for 1000 milliseconds to establish cluster membership, start level:8 Dec 13, 2006 4:07:42 PM org.apache.catalina.tribes.membership.McastServiceImpl waitForMembers INFO: Done sleeping, membership established, start level:8 Dec 13, 2006 4:07:42 PM org.apache.catalina.core.StandardHost start INFO: XML validation disabled Dec 13, 2006 4:07:42 PM org.apache.catalina.tribes.tipis.AbstractReplicatedMap init INFO: Initializing AbstractReplicatedMap with context name:/test Dec 13, 2006 4:07:43 PM org.apache.catalina.ha.context.ReplicatedContext start SEVERE: Unable to start ReplicatedContext java.lang.ClassCastException: org.apache.naming.resources.ProxyDirContext cannot be cast to java.io.Serializable at org.apache.catalina.tribes.tipis.AbstractReplicatedMap$MapEntry.setValue (AbstractReplicatedMap.java:1060) at org.apache.catalina.tribes.tipis.AbstractReplicatedMap$MapEntry.<init> (AbstractReplicatedMap.java:1005) at org.apache.catalina.tribes.tipis.AbstractReplicatedMap.put (AbstractReplicatedMap.java:859) at org.apache.catalina.core.ApplicationContext.setAttribute (ApplicationContext.java:756) at org.apache.catalina.core.ApplicationContextFacade.setAttribute (ApplicationContextFacade.java:334) at org.apache.catalina.core.StandardContext.start (StandardContext.java:4296) at org.apache.catalina.ha.context.ReplicatedContext.start (ReplicatedContext.java:55) at org.apache.catalina.core.ContainerBase.addChildInternal (ContainerBase.java:760) at org.apache.catalina.core.ContainerBase.addChild (ContainerBase.java:740) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:525) at org.apache.catalina.startup.HostConfig.deployDescriptor (HostConfig.java:626) at org.apache.catalina.startup.HostConfig.deployDescriptors (HostConfig.java:553) at org.apache.catalina.startup.HostConfig.deployApps (HostConfig.java:488) at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1138) at org.apache.catalina.startup.HostConfig.lifecycleEvent (HostConfig.java:311) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent (LifecycleSupport.java:120) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1022) at org.apache.catalina.core.StandardHost.start(StandardHost.java:719) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1014) at org.apache.catalina.core.StandardEngine.start (StandardEngine.java:443) at org.apache.catalina.core.StandardService.start (StandardService.java:451) at org.apache.catalina.core.StandardServer.start (StandardServer.java:710) at org.apache.catalina.startup.Catalina.start(Catalina.java:552) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:288) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:413) Dec 13, 2006 4:07:43 PM org.apache.catalina.core.ContainerBase addChildInternal SEVERE: ContainerBase.addChild: start: LifecycleException: Failed to start ReplicatedContext: java.lang.ClassCastException: org.apache.naming.resources.ProxyDirContext cannot be cast to java.io.Serializable at org.apache.catalina.ha.context.ReplicatedContext.start (ReplicatedContext.java:58)

resolved fixed

4f96d21

["java/org/apache/catalina/core/ApplicationContext.java", "java/org/apache/catalina/ha/context/ReplicatedContext.java", "java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41675 Add a debug statement when some necessary header information is missing

Reference: org.apache.coyote.http11.Http11Processor.java It would be helpful for developers to get informed when some required header information is missing. eg when headers.getValue("host"); returns null and http11 is true. Couldn't you add a log.debug statement that informs the user about missing header-fields? (For example in Http11Processor.java:1391)

resolved fixed

7fd4fa8

["java/org/apache/coyote/http11/Http11Processor.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40150 Incorrect User/Role classnames are silently ignored.

org.apache.catalina.realm.JAASRealm does not verify any of the class names that are set through setRoleClassNames() and setUserClassNames(). If an incorrect class name (e.g. a typo) is configured in context.xml, this is unnoticed by JAASRealm. The result is that during authentication, when the subject's principals are checked against the configured class names, the principals are not recognised, and therefore not added to the subject. The fact an incorrect configured class name is currently not detected and logged makes it very hard to find the source of the problem. It can be easily fixed by checking the class names in the two methods mentioned above. The class must exist, and it must implement java.security.Principal, which is currently not enforced/checked by the code.

resolved fixed

400d684

["java/org/apache/catalina/realm/JAASRealm.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41790 JDTCompiler::getContents does not close the reader

In the class org.apache.jasper.compiler.JDTCompiler: ------------------------------------------------------------------------- public char[] getContents() { char[] result = null; try { InputStreamReader isReader = new InputStreamReader(new FileInputStream(sourceFile), ctxt.getOptions().getJavaEncoding()); Reader reader = new BufferedReader(isReader); if (reader != null) { char[] chars = new char[8192]; StringBuffer buf = new StringBuffer(); int count; while ((count = reader.read(chars, 0, chars.length)) > 0) { buf.append(chars, 0, count); } result = new char[buf.length()]; buf.getChars(0, result.length, result, 0); } } catch (IOException e) { log.error("Compilation error", e); } return result; } ------------------------------------------------------------------------- the variable "reader" is not closed after use it. if I update jsp files frequently, it will exhaust the system file handler. "too many files" errors will come. I test it on Redhat linux, the same problem will occured in tomcat 5 and tomcat 6.

resolved fixed

455b6f8

["java/org/apache/jasper/compiler/JDTCompiler.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41752 Wrong message on exception in MemoryRealm

When Digester read tomcat-user.xml file and exception is throw, then is created new LifecycleException. As first parameter of this Exception is message string. This string is hardcoded to "memoryRealm.readXml", so I thing that log message will be wrong too! I think that there must be used StringManager. actual implementation: Digester digester = getDigester(); try { synchronized (digester) { digester.push(this); digester.parse(file); } } catch (Exception e) { throw new LifecycleException("memoryRealm.readXml", e); } finally { digester.reset(); } fixed: Digester digester = getDigester(); try { synchronized (digester) { digester.push(this); digester.parse(file); } } catch (Exception e) { throw new LifecycleException(sm.getString("memoryRealm.readXml"), e); } finally { digester.reset(); }

resolved fixed

e33b67a

["java/org/apache/catalina/realm/MemoryRealm.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41666 If-Unmodified-Since failure

The If-Unmodified-Since header doesn't work enoughly. failed case: The If-Unmodified-Since header value: 1000000(milliseconds) The lastModified value of target resource: 1001000(milliseconds) In this case, the response's status code should be SC_PRECONDITION_FAILED, but the result is not so. caused by: In DefaultServlet#checkIfUnmodifiedSince: if ( lastModified > (headerValue + 1000)) { I think it should be: if ( lastModified >= (headerValue + 1000)) {

resolved fixed

9ac3428

["java/org/apache/catalina/servlets/DefaultServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41739 The servlet with the value 0 in <load-on-startup> tag must be loaded at first.

Servlet 2.4 specification says: --- If the value is a positive integer or 0, the container must load and initialize the servlet as the application is deployed. The container must guarantee that servlets marked with lower integers are loaded before servlets marked with higher integers. --- I think the servlet with value 0 in <load-on-startup> tag must be loaded at the first. However, Tomcat loads the servlet at the last.

resolved fixed

01d38a5

["java/org/apache/catalina/core/StandardContext.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41608 The log level is different at same messages.

I suggest a little message improvement. The log level is different at same messages. The message "Servlet.service() for servlet {0} threw exception" is output in eight places, but the message level is not same. --org.apache.catalina.core.ApplicationDispatcher#invoke ... wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException", wrapper.getName()), e); ... wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException", wrapper.getName()), e); ... wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException", wrapper.getName()), rootCause); ... wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException", wrapper.getName()), e); --org.apache.catalina.core.StandardWrapperValve#invoke container.getLogger().warn(sm.getString("standardWrapper.serviceException", wrapper.getName()), e); ... container.getLogger().warn(sm.getString("standardWrapper.serviceException", wrapper.getName()), e); ... container.getLogger().error(sm.getString("standardWrapper.serviceException", wrapper.getName()), rootCause); ... container.getLogger().error(sm.getString("standardWrapper.serviceException", wrapper.getName()), e); Are there any reasons for using getLogger().warn()? I think it would be better that all of them use getLogger().error(...).

resolved fixed

8ba8334

["java/org/apache/catalina/core/StandardWrapperValve.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41578 Avoid SimplePool.get/put synchronization in JspFactoryImpl

Only 1 instance of the JspFactory object (JspFactoryImpl) is created. Consequently there is a single SimplePool of PageContext objects for all JSP requests and so every JSP request must synchronize on the lock inside SimplePool when getting and releasing a PageContext instance. Moreover, the pool has a fixed capacity and after that, the code in JspFactoryImpl will first acquire the lock to see if there are any free objects in the pool, failing which a new PageContext object is created. Instead of a single process-wide pool, a per thread pool of PageContext objects can be used by JspFactoryImpl.

resolved fixed

4612c8a

["java/org/apache/jasper/runtime/JspFactoryImpl.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41558 Unnecessary synchronization caused by JspFactory.getDefaultFactory while servicing JSPs

Tomcat version: 6.0.x trunk Every generated JSP has try { _jspxFactory = JspFactory.getDefaultFactory(); response.setContentType("text/html"); in its _jspService method. The use of JspFactory.getDefaultFactory during request processing should be avoided as it is a *static synchronized* method. I have a diff that addresses this and will attach it to this bug.

resolved fixed

1a8c492

["java/org/apache/jasper/compiler/Generator.java", "java/org/apache/jasper/compiler/JspRuntimeContext.java", "java/org/apache/jasper/runtime/HttpJspBase.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41521 filter-mapping doesn't support * for servlet-name

SRV 6.2.5 of the servlet 2.5 spec introduces support for '*' as the servlet-name in a filter-mapping. TC6 does not currently support that value as specified. I will attach a patch shortly.

resolved fixed

8b0d130

["java/org/apache/catalina/core/ApplicationFilterFactory.java", "java/org/apache/catalina/deploy/FilterMap.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41466 NIO Connector: IllegalArgumentException: You can only write using the application write buffer provided by the handler

Trying to use NIO connector instead of APR connector using Tomcat6 HEAD, I get an IllegalArgumentException while in a call to sendAck. Looking at InternalNioOutputBuffer.sendAck(), it uses ByteBuffer.wrap() to create a new ByteBuffer and uses this ByteBuffer in a call to writeToSocket. There is a check in SecureNioChannel.write() that the ByteBuffer is the one stored in the Commenting the line 372 in SecureNioChannel.java fixes the problem. //if ( src != bufHandler.getWriteBuffer() ) throw new IllegalArgumentException("You can only write using the application write buffer provided by the handler."); But I guess that the check is here for a valid reason, and a better fix would very likely consist in fixing the sendAck or in adding an "or" condition to the test for the case of sendAck(). GRAVE: Cannot find message associated with key standardWrapper.acknowledgeException java.lang.IllegalArgumentException: You can only write using the application write buffer provided by the handler. at org.apache.tomcat.util.net.SecureNioChannel.write(SecureNioChannel.java:372) at org.apache.tomcat.util.net.NioSelectorPool.write(NioSelectorPool.java:111) at org.apache.coyote.http11.InternalNioOutputBuffer.writeToSocket(InternalNioOutputBuffer.java:434) at org.apache.coyote.http11.InternalNioOutputBuffer.sendAck(InternalNioOutputBuffer.java:418) at org.apache.coyote.http11.Http11NioProcessor.action(Http11NioProcessor.java:1028) at org.apache.coyote.Response.action(Response.java:183) at org.apache.coyote.Response.acknowledge(Response.java:310) at org.apache.catalina.connector.Response.sendAcknowledgement(Response.java:1154) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:169) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:212) at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:888) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:624) at org.apache.tomcat.util.net.NioEndpoint$Worker.run(NioEndpoint.java:1467) at java.lang.Thread.run(Thread.java:595)

resolved fixed

fce171f

["java/org/apache/tomcat/util/net/NioSelectorPool.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 39572 fixes to use CompressionFilter in WebSphere app server

There are a couple of small bugs in the compression filter classes that are triggered by using the filter in WebSphere 5.1 or 6. Here are patches. - CompressionResponseStream should not compress the output stream if the response has been committed (because then it cannot write the Content-Encoding: gzip header, and the browser displays the compressed output as-is) - CompressionServletResponseWrapper causes a NullPointerException if you flush before writing anything

resolved fixed

f06d41f

["webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilterTestServlet.java", "webapps/examples/WEB-INF/classes/compressionFilters/CompressionResponseStream.java", "webapps/examples/WEB-INF/classes/compressionFilters/CompressionServletResponseWrapper.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41265 JspServlet's checkInterval parameter cannot be set to 0 implicitly

conf\web.xml's JspServlet init parameters include 'checkInterval', whose value is explained as follows: If development is false and checkInterval is greater than zero, background compilations are enabled. If I add the following parameters one would think the background compilations would be disabled (the value is not greater than zero). <init-param> <param-name>checkInterval</param-name> <param-value>0</param-value> </init-param> <init-param> <param-name>development</param-name> <param-value>false</param-value> </init-param> However, the value is changed to 300 and the following warning is outputted: Dec 30, 2006 7:13:57 PM org.apache.jasper.EmbeddedServletOptions <init> WARNING: Warning: Invalid value for the initParam checkInterval. Will use the default value of "300" seconds According to the comment in web.xml "0" was a valid value. Either the comment or the validity check is wrong. Or my understanding of them.

resolved fixed

39fe247

["java/org/apache/jasper/EmbeddedServletOptions.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40524 request.getAuthType() returns different string from HttpServletRequest.CLIENT_CERT_AUTH

using inspect: request.getAuthType() (java.lang.String) CLIENT-CERT HttpServletRequest.CLIENT_CERT_AUTH (java.lang.String) CLIENT_CERT api says they should be the same object (== should work)

resolved fixed

dc33554

["java/org/apache/catalina/authenticator/Constants.java", "java/org/apache/catalina/authenticator/SSLAuthenticator.java", "java/org/apache/catalina/authenticator/SingleSignOn.java", "java/org/apache/catalina/authenticator/SingleSignOnEntry.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41217 SingleSignOn Cookie does not honor https access: Login Information Disclosure

When using the SingleSignOn Valve (org.apache.catalina.authenticator.SingleSignOn) via https the Cookie JSESSIONIDSSO is transmitted without the "secure" attribute, resulting in it being transmitted to any content that is - by purpose or error - requested via http from the same server. As the content of the SSO-Cookie is confidential (it will lead to automatically logged in sessions in other contexts - https or non-https) this should never happen. Sorry to have no patch. I've not installed the complete source distribution in my development environment, but it seems the points to change are org.apache.catalina.authenticator.AuthenticatorBase.register(...), the code of interest being (from 5.5.30 source distribution) Cookie cookie = new Cookie(Constants.SINGLE_SIGN_ON_COOKIE, ssoId); cookie.setMaxAge(-1); cookie.setPath("/"); hres.addCookie(cookie); As hres is an org.apache.catalina.HttpRequest, and I've looked through the code to find org.apache.catalina.Request.setSecure() but no ...isSecure() (though this is mentioned in the Javadoc for ...setSecure()) I suppose there needs to be another change to provide isSecure on Request or HttpRequest, but this is difficult to tell only from the editor. If isSecure() was there, there'd be a cookie.setSecure(hres.isSecure()) missing in the statements above...

resolved fixed

11b9c92

["java/org/apache/catalina/authenticator/AuthenticatorBase.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41327 Jasper does'nt display the full path of the file in a 404 Not found error page

resolved fixed

3a6225a

["java/org/apache/jasper/servlet/JspServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40820 Default JSP factory not initialized early enough

With the latest TC6 code, I'm seeing a problem that did not exist on earlier TC6 drivers. Sorry that I can't put a finger on when this problem arose. I looked into relevant source files (like JspRuntimeContext) but haven't found the source of the problem. Here's the issue (a testcase will be attached). The app is very simple: it installs ServletContextListener for the purpose of adding a custom ELResolver. It accomplishes this via: public void contextInitialized(ServletContextEvent evt) { ServletContext context = evt.getServletContext(); JspApplicationContext jspContext = JspFactory.getDefaultFactory().getJspApplicationContext(context); jspContext.addELResolver(new ChipsELResolver()); } The problem is that JspFactory.getDefaultFactory() is returning null; see below. Oct 4, 2006 5:32:18 PM org.apache.catalina.core.AprLifecycleListener lifecycleEv ent INFO: The Apache Tomcat Native library which allows optimal performance in produ ction environments was not found on the java.library.path: C:\javaFor6.0BuildJDK 15\java\jre\bin;.;C:\javaFor6.0BuildJDK15\java\bin;c:\mantis2.1\mantis\bin;C:\se tupIBASE;C:\Perl\bin\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;c: \Python22;C:\Program Files\PC-Doctor for Windows\services;c:\cvsnt-2.0.4;c:\ecli pse;w:\;w:\bin;C:\Program Files\QuickTime\QTSystem\;C:\Diskeeper\;C:\CMVC\exe;C: \CMVC\exe\bin;;C:\CMVCDC50;C:\CMVCDC50;C:\CMVCDC50; Oct 4, 2006 5:32:18 PM org.apache.coyote.http11.Http11Protocol init INFO: Initializing Coyote HTTP/1.1 on http-8080 Oct 4, 2006 5:32:19 PM org.apache.catalina.startup.Catalina load INFO: Initialization processed in 1234 ms Oct 4, 2006 5:32:19 PM org.apache.catalina.core.StandardService start INFO: Starting service Catalina Oct 4, 2006 5:32:19 PM org.apache.catalina.core.StandardEngine start INFO: Starting Servlet Engine: Apache Tomcat/6.0.0-dev Oct 4, 2006 5:32:19 PM org.apache.catalina.core.StandardHost start INFO: XML validation disabled Oct 4, 2006 5:32:19 PM org.apache.catalina.startup.HostConfig deployWAR INFO: Deploying web application archive ELResolverTest.war ChipsListener.contextInitialized evt= javax.servlet.ServletContextEvent[source= org.apache.catalina.core.ApplicationContextFacade@3fbe3fbe] ChipsListener.contextInitialized context= org.apache.catalina.core.ApplicationC ontextFacade@3fbe3fbe ChipsListener.contextInitialized JspFactory.getDefaultFactory()= null Oct 4, 2006 5:32:20 PM org.apache.catalina.core.StandardContext start SEVERE: Error listenerStart Oct 4, 2006 5:32:20 PM org.apache.catalina.core.StandardContext start SEVERE: Context [/ELResolverTest] startup failed due to previous errors Oct 4, 2006 5:32:21 PM org.apache.coyote.http11.Http11Protocol start INFO: Starting Coyote HTTP/1.1 on http-8080 Oct 4, 2006 5:32:21 PM org.apache.jk.common.ChannelSocket init INFO: JK: ajp13 listening on /0.0.0.0:8009 Oct 4, 2006 5:32:21 PM org.apache.jk.server.JkMain start INFO: Jk running ID=0 time=0/63 config=null Oct 4, 2006 5:32:21 PM org.apache.catalina.startup.Catalina start INFO: Server startup in 2657 ms This is easily reproducible when you deploy the ELResolverTest.war *before* the server has started (I assume JspFactory.setDefaultFactory() hasn't been invoked at the time the listeners are being installed). If you deploy the WAR *after* the server starts, the problem does not manifest and the app works --- until you stop and restart the server.

resolved fixed

a1b1bed

["java/org/apache/catalina/core/JasperListener.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41074 Output of tag "jsp:plugin" is not conform to XHTML.

The jsp comiler outputs all tag required for an object in upper case letters. To be conform with XHTML lower case is required, but all tags are hard coded in the generator.

resolved fixed

5f9c18d

["java/org/apache/jasper/compiler/Generator.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40585 org.apache.juli.FileHandler does not allow programmatic creation using parametrized constructor

If org.apache.juli.FileHandler is created programmatically with parametrized constructor public FileHandler(String directory, String prefix, String suffix) , FileHandler ignores custom constructor parameters, creates log handler with default configuration and writes log file to "${catalina_home}/bin/logs" with the name "juli.YYYY-MM-DD.log" (YYYY, MM and DD are substituted with actual year, month and date) It looks like the problem is in the fact parametrized constructor calls default constructor. Default constructor in turn performs handler configuration from LogManager properties and creates a log file based on this default configuration. This makes custom constructor parameters effectively ignored.

resolved fixed

c6b3f71

["java/org/apache/juli/FileHandler.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41089 JspFactoryImpl has SPEC_VERSION = "2.0"

org.apache.jasper.runtime.JspFactoryImpl has private static final String SPEC_VERSION = "2.0"; Should be: private static final String SPEC_VERSION = "2.1";

resolved fixed

514256e

["java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java", "java/org/apache/jasper/compiler/PageDataImpl.java", "java/org/apache/jasper/compiler/Validator.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41057 Tomcat leaks memory on every request

resolved fixed

de5c3b7

["java/org/apache/tomcat/util/buf/StringCache.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 41008 POST request ignores command line parameters

example: <form method="POST" action="test.exe?test1"><input type="hidden" value="test2"><input type="submit"></form> this code does invoke the test.exe without passing the test1 command line parameter the example works in apache httpd and ms iis fix: CGIServlet.java if (!"GET".equals(req.getMethod()) && !"POST".equals(req.getMethod()) && !"HEAD".equals(req.getMethod())) return;

resolved fixed

b70962f

["java/org/apache/catalina/servlets/CGIServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40901 listings page does not escape XML characters

On Solaris you can have a file or directory name called "<b>xxx" or "<i>yyy". Using Tomcat's listings feature, you get a directory listing with the file name in bold or italics. I am not familiar with Javascript or cross-site scripting security problems, but I believe Tomcat escapes XML characters like ">" and "<" to prevent client browsers to interpret HTML codes that are not intended to be interpreted as such for the default error page. I think the same should be done for listings, or a warning should be added to the documentation not to use it if you have no control over the file/directory names you list.

resolved fixed

cb2c655

["java/org/apache/catalina/servlets/DefaultServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40929 Misleading comments in StandardClassLoader

Sometime during the Tomcat 5 development, the StandardClassLoader in org.apache.catalina.loader package was stripped down, and is now just a URLClassLoader. I work with code that extends the StandardClassLoader (we use the automatic reloading of jar files), and during an upgrade from tomcat 4 to tomcat 5.5 found difficultly trying to figure out what had happened to the code. I ended up having to install SVN and do a svn log to figure out why the code was removed. When the code was stripped down, the comments in the java file (and therefore in the javadoc api) remained identical, so the javadoc api for the class is very misleading. For instance, the comments say that the class implements Reloader, when it in fact does not. The class comments should be updated to reflect the state of the code. I can't see this as being very high priority, but it would likely be an easy to fix for people whom are in the code regularly, and it would make the javadoc much more readable for people that extend the StandardClassLoader for their own purposes.

resolved fixed

6009702

["java/org/apache/catalina/loader/StandardClassLoader.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40860 Tomcat loses request parameters

resolved fixed

e713e77

["java/org/apache/catalina/connector/Request.java", "java/org/apache/tomcat/util/http/Parameters.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 37509 ClassLoaderLogManager remove '\n' at the end of logging.properties values

The method ClassLoaderLogManager.replace(String) that is in charge of replacing system properties at the begining of the property also modify the end of the property due to a call to trim. This implies that Logger/Handler/Formatter that relies on properties endding with some spases (including '\n') will have a different behaviour with JDK LogManger and tomcat ClassLoaderLogManager a modified verstion of this method could be: protected String replace(String str) { // start modification // String result = str.trim(); // commented out int len = str.length(); int st = 0; while ((st < len) && (str.charAt(st) <= ' ')) { st++; } String result = (st > 0) ? str.substring(st) : str; // end modification if (result.startsWith("${")) { int pos = result.indexOf('}'); if (pos != -1) { String propName = result.substring(2, pos); String replacement = System.getProperty(propName); if (replacement != null) { result = replacement + result.substring(pos + 1); } } } return result; }

resolved fixed

a6d6962

["java/org/apache/juli/ClassLoaderLogManager.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40844 JDBCRealm.getPassword throws NullPointerException

JDBCRealm.getPassword throws NullPointerException I'm using tomcat 5.5.20 with postgresql-8.1-407.jdbc3.jar and postgresql-8.1.4 on Ubuntu Dapper. Authenticating two users simultaneously with HTTP DIGEST causes sometimes the following errors and a 401 Unauthorized reply: 30.10.2006 14:24:54 org.apache.catalina.realm.JDBCRealm getPassword SEVERE: Exception performing authentication org.postgresql.util.PSQLException: ERROR: invalid message format at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:1525) at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1309) at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:188) at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:452) at org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:354) at org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:258) at org.apache.catalina.realm.JDBCRealm.getPassword(JDBCRealm.java:546) at org.apache.catalina.realm.RealmBase.getDigest(RealmBase.java:1156) at org.apache.catalina.realm.RealmBase.authenticate(RealmBase.java:365) at org.apache.catalina.authenticator.DigestAuthenticator.findPrincipal(DigestAuthenticator.java:282) at org.apache.catalina.authenticator.DigestAuthenticator.authenticate(DigestAuthenticator.java:175) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869) at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664) at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) at java.lang.Thread.run(Thread.java:595) 30.10.2006 14:24:54 org.apache.catalina.connector.CoyoteAdapter service SEVERE: An exception or error occurred in the container during the request processing java.lang.NullPointerException at org.apache.catalina.realm.JDBCRealm.getPassword(JDBCRealm.java:568) at org.apache.catalina.realm.JDBCRealm.getPrincipal(JDBCRealm.java:594) at org.apache.catalina.realm.RealmBase.authenticate(RealmBase.java:398) at org.apache.catalina.authenticator.DigestAuthenticator.findPrincipal(DigestAuthenticator.java:282) at org.apache.catalina.authenticator.DigestAuthenticator.authenticate(DigestAuthenticator.java:175) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869) at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664) at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) at java.lang.Thread.run(Thread.java:595)

resolved fixed

be9d523

["java/org/apache/catalina/realm/JDBCRealm.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40913 JasperException raised against valid attribute

In org.apache.jasper.compiler.Validator.checkXmlAttributes(), the validation for deferred values and methods is raising an exception when an rtexprvalue attribute is legitimate. ------Stacktrace------ org.apache.jasper.JasperException: org.apache.jasper.JasperException: /index.jsp(83,0) According to TLD or attribute directive in tag file, attribute items does not accept any expressions org.apache.jasper.servlet.JspServletWrapper.handleJspException (JspServletWrapper.java:565) org.apache.jasper.servlet.JspServletWrapper.service (JspServletWrapper.java:354) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:320) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:266) javax.servlet.http.HttpServlet.service(HttpServlet.java:803) ------relevant code in checkXmlAttributes()------ if (!deferred && (tldAttrs[j].isDeferredMethod() || tldAttrs [j].isDeferredValue())) { // Only deferred expressions are allowed for this attribute err.jspError(n, "jsp.error.attribute.custom.non_rt_with_expr", tldAttrs[j].getName()); } ------testcase------ <c:forEach var="k" items="${colors}"> <li><font color="${k}">This line is ${k}</font>. </c:forEach> The TLD for JSTL 1.2 says items can be an rtexprvalue and also a deferred- value. So the above usage is correct. Attaching a testcase WAR. ------summary------ I don't think this code is really necessary; at least, it needs to be relaxed to allow tai.canBeRequestTime() values.

resolved fixed

f7ca96d

["java/org/apache/jasper/compiler/Validator.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 34956 Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2

Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2 SRV.8.2 Using a Request Dispatcher "To use a request dispatcher, a servlet calls either the include method or forward method of the RequestDispatcher interface. The parameters to these methods can be either the request and response arguments that were passed in via the service method of the Servlet interface, or instances of subclasses of the request and response wrapper classes that have been introduced for version 2.3 of the specification. In the latter case, the wrapper instances must wrap the request or response objects that the container passed into the service method. The Container Provider must ensure that the dispatch of the request to a target servlet occurs in the same thread of the same VM as the original request" Justification: ============== The absense of this enforcement leads to software beeing developed not following the specification. The software cannot be deployed later on a container which conforms to the above paragraph and hence must be changed before deployment. This somehow contradicts the idea of having a standards based infrastructure.

resolved fixed

22d1ad7

["java/org/apache/catalina/core/ApplicationDispatcher.java", "java/org/apache/catalina/core/ApplicationFilterChain.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40817 servlet-cgi throws index out of bounds exception on certain cgi

First, servlets-cgi.jar needs to exist and the servlet must be mapped: for example: <servlet-mapping> <servlet-name>cgi</servlet-name> <url-pattern>*.pl</url-pattern> </servlet-mapping> Test perl cgi script: #!/usr/bin/perl print "Content-type: text/plain", "\n\n"; print "Hello world, from Perl\n"; One perl script is placed in www-root ("/test.pl") and the other in any subfolder ("/test/test.pl" or "/cgi-bin/test.pl", etc.) The cgi script in the subfolder will run fine. The cgi script in the www-root will generate an exception: java.lang.StringIndexOutOfBoundsException: String index out of range: -1 java.lang.String.substring(String.java:1768) java.lang.String.substring(String.java:1735) org.apache.catalina.servlets.CGIServlet$CGIEnvironment.findCGI(CGIServlet.java:948) org.apache.catalina.servlets.CGIServlet$CGIEnvironment.setCGIEnvironment(CGIServlet.java:1015) org.apache.catalina.servlets.CGIServlet$CGIEnvironment.<init>(CGIServlet.java:766) org.apache.catalina.servlets.CGIServlet.doGet(CGIServlet.java:584) javax.servlet.http.HttpServlet.service(HttpServlet.java:689) javax.servlet.http.HttpServlet.service(HttpServlet.java:802) The problem is this line (line 948 in CGIServlet.java): cginame = currentLocation.getParent().substring(webAppRootDir.length())+ File.separator + name; The problem is that webAppRootDir is 1 char longer than currentLocation.getParent() because webAppRootDir ends with a File.separator (in this case, a "/"). And removing the extra File.separator from webAppRootDir will result in a different String related exception elsewhere. And here's a fix that works: cginame = (currentLocation.getParent() + File.separator).substring(webAppRootDir.length()) + name; (If necessary, the fix can be made more adaptive by checking to see if it really does have a File.separator at the end and if not...add it...otherwise, let it be, etc.) (on a side note, I have one more bug to fix; the ENV_VAR "SCRIPT_FILENAME" isn't defined as it should be [required for PHP4/5] but I'll submit a different bug/fix for that.)

resolved fixed

6d274b4

["java/org/apache/catalina/servlets/CGIServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 37458 Datarace on org.apache.catalina.loader.WebappClassLoader

In findClassInternal, it is possible that entry.manifest is set to null by another thread right before calling definePackage(packageName, entry.manifest, entry.codeBase).

resolved fixed

79631bb

["java/org/apache/catalina/loader/WebappClassLoader.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40723 Wrong and misleading documentation in JDBCAccessLogValve

In the class JDBCAccessLogValve is an example for an table to hold access log values. In this table is a column ts which is defined as not null. This will only work on MySQL, because this value is never written by the Valve and other databases will complain about a column which is not filled with a value.

resolved fixed

9cb5aff

["java/org/apache/catalina/valves/JDBCAccessLogValve.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40771 Can't read POST data from within a filter or valve

I was attempting to create a Filter or Valve that could be placed in front of an Axis web service that would handle security according to the WS-Security specification. That turned out to be a rabbit trail, but I did find and fix a bug that I discovered along the way. I ran into problems reading POST data (the web service request) from the org.apache.catalina.connector.Request object exposed in the Filter/Valve interfaces. This is a chunk of code in a prototype Valve that didn't work: private ByteChunk getPOSTBody(Request request) throws IOException { ByteChunk retval = new ByteChunk(request.getContentLength()); ByteChunk body = new ByteChunk(request.getContentLength()); int bytesRead; do { bytesRead = request.getCoyoteRequest().doRead(body); retval.append(body); } while (bytesRead >= 0) ; //puts the data back into the pipe. request.getCoyoteRequest().action (ActionCode.ACTION_REQ_SET_BODY_REPLAY, retval); return retval; } This code works as designed, however the problem occurs later on when Axis attempted to parse the web service request. I don't remember the exact Axis error, but I was able to track the problem down to a bug in the org.apache.coyote.http11.filters.SavedRequestInputFilter class. The doRead method was not properly implemented to return a -1 when appropriate. Here is my modified version of the doRead method: public int doRead(ByteChunk chunk, org.apache.coyote.Request request) throws IOException { int writeLength = 0; if (chunk.getLimit() > 0 && chunk.getLimit() < input.getLength()) { writeLength = chunk.getLimit(); } else { writeLength = input.getLength(); } if(input.getOffset()>= input.getEnd()) return -1; input.substract(chunk.getBuffer(), 0, writeLength); chunk.setOffset(0); chunk.setEnd(writeLength); return writeLength; } This bug won't show up unless someone tries to use a filter/valve to do something with web services. That's not too likely because that's what we have SOAPHandlers for.

resolved fixed

17eecdb

["java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 39724 Bug on StandardPipeline.removeValve(Valve valve) for T5.5.16+

I run into this problem with T5 when tring to add/remove/add a valve to the standard engine. -For what I understand an empty pipeline has: basic = StandardEngineValve (For example); first = null; -If you add a valve you will get basic = StandardEngineValve first = myValve (with myValve.next = StandardEngineValve) -If you remove the valve you will get basic =StandardEngineValve first = StandardEngineValve Note that StandardEngineValve is in first too here. -If I try to add a new valve given the actual code in addValve the valve will not be added because (see the **) current = basic and current.getNext() = null; addValve(Valve valve) { // Add this Valve to the set associated with this Pipeline if (first == null) { first = valve; valve.setNext(basic); } else { Valve current = first; while (current != null) { ** if (current.getNext() == basic) { current.setNext(valve); valve.setNext(basic); break; } current = current.getNext(); } } }

resolved fixed

b18c29e

["java/org/apache/catalina/core/StandardPipeline.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 29727 JNDI env-entry not reload when context reloaded

If environment entries are changed in web.xml, and the application context is restarted, the values in the JNDI context are the old values. If the environment entries are changed via the Tomcat 'admin' interface, then the values provided to the context are correct. The following code is can be used to check the environment: try { InitialContext ic = new InitialContext(); NamingEnumeration enum = ic.listBindings("java:comp/env"); while (enum.hasMore()) { Binding binding = (Binding) enum.next(); jndi.setProperty(binding.getName(), "" + binding.getObject()); System.out.println("jndi setting: " + binding.getName() + "=" + binding.getObject()); } } catch (NamingException e) { System.err.println("unable to read JNDI settings, " + e); } The web.xml fragment looks as follows: <env-entry> <env-entry-name>DatabaseURL</env-entry-name> <env-entry-value>jdbc:hsqldb:hsql://localhost</env-entry-value> <env-entry-type>java.lang.String</env-entry-type> </env-entry>

resolved fixed

1a5e6e7

["java/org/apache/catalina/deploy/NamingResources.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40625 CGIServlet eats root cause

The code below doesn't make sense: <snip> catch (IOException e){ log ("Caught exception " + e); throw new IOException (e.toString()); } </snip> It should be "throw e;". IMHO, It seems no need to log this exception here, so the cache block can be removed.

resolved fixed

bbb8fe1

["java/org/apache/catalina/servlets/CGIServlet.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 40518 The message key "requestListenerValve.requestInit" has not be referred to correctly.

The bug is: An illegal message is output to the log when the listener application that implements ServletRequestListener interface throws RuntimeException from the requestInitialized method or the requestDestroyed method. message: "Cannot find message associated with key requestListenerValve.requestInit" cause: The key exists in the properties file "org.apache.catalina.valves.LocalStrings.properties", but the logic refers other properties file "org.apache.catalina.core.LocalStrings.properties"

resolved fixed

fda223a

["java/org/apache/catalina/core/StandardContextValve.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 34399 Undeploying fails when context defined in server.xml & server fails to stop

Steps to reproduce: 1. autodeploy a web application by defining its context in server.xml 2. start the Tomcat server 3. use the Tomcat Manager to undeploy the application You will get the "OK - Undeployed application at context path /WebApplication" message, but the application will NOT be undeployed, it will be only stopped. If you try to stop the server after that, it will fail! I have used the shared installation (CATALINA_BASE dir), but I guess this won't work for standalone Tomcat isntallation either.

resolved fixed

9dd8a23

["java/org/apache/catalina/manager/HTMLManagerServlet.java", "java/org/apache/catalina/manager/ManagerServlet.java", "java/org/apache/catalina/startup/HostConfig.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 34509 tag names that are xml:Name but not java identifier are not accepted

According to the JSP 2.0 specification, custom tag prefix and name should be of the type XML:Name. However, for Tomcat 5.5.8, if the name is not a legal java identifier, then a compilation error occurs. For instance, Tomcat won't accept Da~te`T#ag as a legal name for the Tag.

resolved fixed

823101d

["java/org/apache/jasper/compiler/Generator.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 33356 Incorrect parsing of tag attributes

I get a org.apache.jasper.JasperException: with the error: "The function string must be used with a prefix when a default namespace is not specified" when trying to compile the following within a JSP page: <foo:set var="bar" value="this $ is a { silly string ("/> "foo" is our own tablib, it seems that Jasper seems to think that the string provided to the value attribute contains some JSP/EL which it does not. If I change the page to be: <c:set var="bar" value="this $ is a { silly string ("/> Then I do not get this error. However I need to use my own taglib. In the foo.tld file, the "value" attribute of "set" has rtexprvalue=true. If I set this to false then the problem goes away. However I noticed that c.tld in standard.jar also has rtexprvalue=true for the "value" attribute of "set". Why the difference in behaviour ? We also wish to have rtexprvalue=true.

resolved fixed

b55e9c2

["java/org/apache/jasper/compiler/ELParser.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java

Bug 31804 setParent() is not called on nested tags in a tag file (.tagx)

resolved fixed

2d6d717

["java/org/apache/jasper/compiler/Generator.java"]

Tomcat

https://github.com/apache/tomcat

apache/tomcat

java