issue_id
int64 2.03k
426k
| title
stringlengths 9
251
| body
stringlengths 1
32.8k
⌀ | status
stringclasses 6
values | after_fix_sha
stringlengths 7
7
| updated_files
stringlengths 29
34.1k
| project_name
stringclasses 6
values | repo_url
stringclasses 6
values | repo_name
stringclasses 6
values | language
stringclasses 1
value | issue_url
null | before_fix_sha
null | pull_url
null | commit_datetime
unknown | report_datetime
unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
49,376 | Bug 49376 Minor corrections to info properties. | The static info properties appear to contain legacy packages. | resolved fixed | e119b5b | ["java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java", "java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java", "java/org/apache/catalina/ha/session/ClusterSessionListener.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-06-06T21:31:20Z" | "2010-06-03T10:13:20Z" |
48,971 | Bug 48971 memory leak protection : stopping TimeThreads should be optional and disabled by default | null | resolved fixed | ac8a5ba | ["java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/loader/WebappClassLoader.java", "java/org/apache/catalina/loader/WebappLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-06-01T16:59:14Z" | "2010-03-24T03:06:40Z" |
49,360 | Bug 49360 Context class reload fails for PersistentManager | On context class reload tomcat fails with LifecycleException: An invalid Lifecycle transition was attempted ([before_start]) for component [org.apache.catalina.session.PersistentManager[/xxx]] in state [DESTROYED] | resolved fixed | ac22dd8 | ["java/org/apache/catalina/ha/session/BackupManager.java", "java/org/apache/catalina/ha/session/DeltaManager.java", "java/org/apache/catalina/session/PersistentManagerBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-31T16:57:45Z" | "2010-05-29T21:53:20Z" |
49,340 | Bug 49340 Webapp unavailable after deploy then stop then start | Occurs with tomcat 7.0 RC3 but not with 6.0.26 Using the manager/html : - deploy a war - test one of its page, it should be deployed properly - stop the webapp - start the webapp - test one of its page : FAILURE : tomcat returns a 404. Notes : - if using "reload" instead of stop/start it's OK, but it does not fix the unavailability - if the webapp is present when tomcat is started, then the stop/start works normally - The work around is to undeploy the webapp and redeploy it. | resolved fixed | 0f669e3 | ["java/org/apache/catalina/connector/MapperListener.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-28T20:08:02Z" | "2010-05-25T20:40:00Z" |
49,299 | Bug 49299 Servlet 3.0 ch.7.1.1 says that custom cookie name affects URL rewriting | null | resolved fixed | 9369636 | ["java/org/apache/catalina/Globals.java", "java/org/apache/catalina/connector/CoyoteAdapter.java", "java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/connector/Response.java", "java/org/apache/catalina/core/ApplicationSessionCookieConfig.java", "java/org/apache/catalina/realm/RealmBase.java", "test/org/apache/catalina/connector/TestCoyoteAdaptor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-16T21:47:26Z" | "2010-05-15T21:46:40Z" |
49,290 | Bug 49290 Using a JarScanner with scanAllDirectories=true causes Tomcat 7 not to start | null | resolved fixed | a7b96d0 | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-15T22:52:18Z" | "2010-05-14T15:13:20Z" |
49,221 | Bug 49221 javax.servlet.http.Cookie.setDomain uses default charset | javax.servlet.http.Cookie.setDomain(String pattern) has the following code: domain = pattern.toLowerCase(); The result of this depends on the default Locale; it would be safer to use a fixed locale, e.g. Local.ENGLISH. | resolved fixed | 05810ee | ["java/javax/servlet/http/Cookie.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-12T10:31:04Z" | "2010-04-29T14:06:40Z" |
49,224 | Bug 49224 NullPointerException in PooledConnection when username or password are null | I'm using jdbc-pool (version 1.0.8.5) to connect to a DataSource requiring no authentication. Unless I explicitly set the username and password in the PoolProperties object to empty String (as opposed to leaving them null), a NullPointerException is thrown on lines 215 or 216 of PooledConnection.connectUsingDriver(). | resolved fixed | 4fff6c0 | ["modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-12T10:29:06Z" | "2010-04-29T14:06:40Z" |
49,226 | Bug 49226 toLowerCase()/toUpperCase() may not work OK in all Locales | null | resolved fixed | 5ad9ecd | ["java/org/apache/catalina/core/ApplicationPart.java", "java/org/apache/catalina/core/StandardEngine.java", "java/org/apache/catalina/core/StandardHost.java", "java/org/apache/catalina/deploy/FilterMap.java", "java/org/apache/catalina/manager/HTMLManagerServlet.java", "java/org/apache/catalina/manager/util/SessionUtils.java", "java/org/apache/catalina/servlets/CGIServlet.java", "java/org/apache/catalina/servlets/WebdavServlet.java", "java/org/apache/catalina/ssi/ResponseIncludeWrapper.java", "java/org/apache/catalina/ssi/SSIMediator.java", "java/org/apache/catalina/ssi/SSIProcessor.java", "java/org/apache/catalina/ssi/SSIServlet.java", "java/org/apache/catalina/ssi/SSIServletExternalResolver.java", "java/org/apache/catalina/startup/ClassLoaderFactory.java", "java/org/apache/catalina/startup/ContextConfig.java", "java/org/apache/catalina/startup/HostConfig.java", "java/org/apache/catalina/util/ExtensionValidator.java", "java/org/apache/catalina/util/MIME2Java.java", "java/org/apache/tomcat/util/buf/MessageBytes.java", "java/org/apache/tomcat/util/http/AcceptLanguage.java", "java/org/apache/tomcat/util/http/fileupload/FileItemHeadersImpl.java", "java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java", "java/org/apache/tomcat/util/http/fileupload/ParameterParser.java", "java/org/apache/tomcat/util/http/fileupload/ServletFileUpload.java", "java/org/apache/tomcat/util/modeler/OperationInfo.java", "java/org/apache/tomcat/util/net/URL.java", "java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java", "webapps/examples/WEB-INF/classes/examples/ShowSource.java", "webapps/examples/WEB-INF/classes/jsp2/examples/el/Functions.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-11T20:05:15Z" | "2010-04-29T16:53:20Z" |
49,227 | Bug 49227 toLowerCase()/toUpperCase() may not work OK in all Locales | null | resolved fixed | 09abffb | ["java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/coyote/http11/Http11NioProcessor.java", "java/org/apache/coyote/http11/Http11Processor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-11T19:51:45Z" | "2010-04-29T16:53:20Z" |
49,228 | Bug 49228 toLowerCase()/toUpperCase() may not work OK in all Locales | null | resolved fixed | a954806 | ["java/org/apache/jasper/compiler/Validator.java", "java/org/apache/jasper/tagplugins/jstl/Util.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-11T15:53:10Z" | "2010-04-29T16:53:20Z" |
49,235 | Bug 49235 ServletContainerInitializer onStartup(Set<Class<?>> classSet is not expect class | null | resolved fixed | 4a581aa | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-11T15:48:36Z" | "2010-04-30T06:46:40Z" |
49,240 | Bug 49240 Error thrown during detection of ServletContainerInitializer's | ContextConfig.checkHandlesTypes() throws a NoClassDefFoundError, which isn't caught, when the class being analysed is initialised if the class, or a class that it references(?), is not present in the classpath. E.g. When a mysql connector/j jar (v5.x) is scanned, an attempt to load the following class occurs: com.mchange.v2.c3p0.QueryConnectionTester java.lang.NoClassDefFoundError: com/mchange/v2/c3p0/QueryConnectionTester at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:698) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) at java.net.URLClassLoader.access$000(URLClassLoader.java:56) at java.net.URLClassLoader$1.run(URLClassLoader.java:195) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:188) at java.lang.ClassLoader.loadClass(ClassLoader.java:315) at java.lang.ClassLoader.loadClass(ClassLoader.java:250) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:398) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:247) Also Class.forName is used here, referencing the WebappClassLoader, instead of calling WebappClassLoader.loadClass() directly. | resolved fixed | f24ed2d | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-11T09:46:42Z" | "2010-05-01T10:33:20Z" |
49,269 | Bug 49269 Shouldn't see maxIdle > maxActive message with default props | In PoolProperties, the default value for maxIdle is Integer.MAX_VALUE and the default for maxActive is 100. This results in a warning message being logged and the value for maxIdle set to match maxActive on lines 393/394 of ConnectionPool. The default for maxIdle should match that of maxActive. | resolved fixed | 27a3909 | ["modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolProperties.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-11T08:01:52Z" | "2010-05-10T19:33:20Z" |
49,241 | Bug 49241 DataSourceFactory.parsePoolProperties() doesn't look for "suspectTimeout" | If you call the DataSourceFactory.parsePoolProperties() method, passing in a Properties object with the "suspectTimeout" property set, that key/value pair is never passed on to the PoolProperties.setSuspectTimeout() method. | resolved fixed | b75b021 | ["modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-03T19:12:48Z" | "2010-05-02T00:26:40Z" |
49,092 | Bug 49092 util.IntrospectionUtils.PATH_SEPARATOR should be final | The field org.apache.tomcat.util.IntrospectionUtils.PATH_SEPARATOR should be final. | resolved fixed | 616bd68 | ["test/org/apache/catalina/tribes/demos/IntrospectionUtils.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-05-01T15:20:31Z" | "2010-04-12T02:40:00Z" |
49,207 | Bug 49207 Filter name not set when dynamically added | When dynamically adding a Filter the name is not set when calling the method "addMappingForUrlPatterns" in ApplicationFilterRegistration.java. java.lang.IllegalArgumentException: Filter mapping specifies an unknown filter name null at org.apache.catalina.core.StandardContext.validateFilterMap(StandardContext.java:2650) at org.apache.catalina.core.StandardContext.addFilterMapBefore(StandardContext.java:2622) at org.apache.catalina.core.ApplicationFilterRegistration.addMappingForUrlPatterns(ApplicationFilterRegistration.java:102) at org.pidster.tomcat.test7.dyn.TestDynamicsListener.contextInitialized(TestDynamicsListener.java:105) | resolved fixed | 3396917 | ["java/org/apache/catalina/core/ApplicationFilterRegistration.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-28T16:21:32Z" | "2010-04-28T10:20:00Z" |
49,184 | Bug 49184 Index out of bounds exception thrown when dynamically adding Filter | When dynamically adding a filter to a context an exception is thrown. java.lang.ArrayIndexOutOfBoundsException at java.lang.System.arraycopy(Native Method) at org.apache.catalina.core.StandardContext.addFilterMapBefore(StandardContext.java:2629) at org.apache.catalina.core.ApplicationFilterRegistration.addMappingForServletNames(ApplicationFilterRegistration.java:75) | resolved fixed | 3f4a241 | ["java/org/apache/catalina/core/StandardContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-26T09:17:46Z" | "2010-04-25T12:53:20Z" |
48,689 | Bug 48689 Jar abstraction for Jasper | Jasper can load TLD files through the ServletContext or from a Jar file. To load TLDs from Jar file, an URL to a Jar file must be passed. However, in some environments (e.g. in OSGi) it might not be easy to provide an URL to a jar file. It would be nice to abstract the way Jasper is looking up the embedded TLDs so that different ways of looking up TLDs within Jar files or Bundles or whatever could be used. | resolved fixed | efd418b | ["java/org/apache/jasper/JspCompilationContext.java", "java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java", "java/org/apache/jasper/compiler/JarResource.java", "java/org/apache/jasper/compiler/JarURLResource.java", "java/org/apache/jasper/compiler/JspDocumentParser.java", "java/org/apache/jasper/compiler/Parser.java", "java/org/apache/jasper/compiler/ParserController.java", "java/org/apache/jasper/compiler/TagFileProcessor.java", "java/org/apache/jasper/compiler/TagLibraryInfoImpl.java", "java/org/apache/jasper/compiler/TldLocation.java", "java/org/apache/jasper/compiler/TldLocationsCache.java", "java/org/apache/jasper/servlet/JspServletWrapper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-25T12:56:32Z" | "2010-02-05T17:13:20Z" |
49,140 | Bug 49140 Inefficient use of keySet() iterator in StandardContext.java | null | resolved fixed | b30fc95 | ["java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/core/ApplicationHttpRequest.java", "java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java", "java/org/apache/catalina/ha/session/ClusterSessionListener.java", "java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-23T15:03:28Z" | "2010-04-17T02:06:40Z" |
49,143 | Bug 49143 Possible incorrect lazy initialisations | Incorrect lazy initialization of static field: org.apache.catalina.realm.RealmBase.md5Helper org.apache.catalina.session.StandardSession.sessionContext org.apache.catalina.startup.TldConfig.noTldJars org.apache.catalina.util.ExtensionValidator.containerAvailableExtensions org.apache.tomcat.util.modeler.modules.MbeansDescriptorsDigesterSource.digester fields should probably all be made volatile | resolved fixed | a6092d7 | ["java/org/apache/catalina/realm/RealmBase.java", "java/org/apache/catalina/session/StandardSession.java", "java/org/apache/catalina/startup/TldConfig.java", "java/org/apache/catalina/util/ExtensionValidator.java", "java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsDigesterSource.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-23T14:23:45Z" | "2010-04-17T02:06:40Z" |
49,144 | Bug 49144 Incorrect lazy initialization and update of static fields? | Incorrect lazy initialization and update of static fields: org.apache.catalina.startup.Bootstrap.daemon org.apache.catalina.startup.ContextConfig.contextDigester Findbugs says: This method contains an unsynchronized lazy initialization of a static field. After the field is set, the object stored into that location is further updated or accessed. The setting of the field is visible to other threads as soon as it is set. If the futher accesses in the method that set the field serve to initialize the object, then you have a very serious multithreading bug, unless something else prevents any other thread from accessing the stored object until it is fully initialized. Even if you feel confident that the method is never called by multiple threads, it might be better to not set the static field until the value you are setting it to is fully populated/initialized. | resolved fixed | fd7ed83 | ["java/org/apache/catalina/startup/Bootstrap.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-23T13:59:54Z" | "2010-04-17T02:06:40Z" |
49,164 | Bug 49164 junit test ignores failures in threads | null | resolved fixed | aa758d8 | ["test/org/apache/catalina/tribes/test/interceptors/TestOrderInterceptor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-23T13:48:16Z" | "2010-04-21T17:13:20Z" |
49,171 | Bug 49171 Avoid raw type warning in TagSupport | null | resolved fixed | 8bd4d7a | ["java/javax/servlet/jsp/tagext/TagSupport.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-23T13:43:27Z" | "2010-04-22T09:53:20Z" |
49,170 | Bug 49170 Transmission of duplicated session in DeltaManager#handleGET_ALL_SESSIONS. | null | resolved fixed | f61100d | ["java/org/apache/catalina/ha/session/DeltaManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-22T10:57:55Z" | "2010-04-22T09:53:20Z" |
43,642 | Bug 43642 Add prestartminSpareThreads attribute for Executor | The attached patch adds the boolean attribute prestartminSpareThreads to the Executor element. This allows the admin to prestart minspareThreads for this Executor during the start of Tomcat. The default value is false which is the old behaviour. A documentation patch for executor.xml can be created if there is interest in committing this patch. | resolved fixed | e7fb8fa | ["java/org/apache/catalina/core/StandardThreadExecutor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-21T12:55:19Z" | "2007-10-17T11:20:00Z" |
49,141 | Bug 49141 Impossible cast in naming.factory.SendMailFactory.getObjectInstance | naming.factory.SendMailFactory.getObjectInstance contains an impossible cast from javax.mail.internet.MimeMessage to javax.mail.internet.MimePart [Findbugs] | resolved fixed | 7205c74 | ["java/javax/mail/internet/MimeMessage.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-20T19:49:10Z" | "2010-04-17T02:06:40Z" |
49,151 | Bug 49151 ClassCastException in BackupManager#stopInternal. | In BackupManager#startInternal, When constructor of LazyReplicatedMap throws exception, sessions is not LazyReplicatedMap. Actually, AbstractReplicatedMap#init has the possibility of throwing RuntimeException. In BackupManager#stopInternal ClassCastException is thrown because AbstractReplicatedMap#breakdown is executed regardless of the type of sessions. should be changed as follows to avoid ClassCastException. === skip. if (sessions instanceof LazyReplicatedMap) { LazyReplicatedMap map = (LazyReplicatedMap)sessions; if ( map!=null ) { map.breakdown(); } } skip. === This problem exists in Tomcat7.0 and 6.0. Best Regards. | resolved fixed | fcb9861 | ["java/org/apache/catalina/ha/session/BackupManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-19T10:12:02Z" | "2010-04-19T09:40:00Z" |
49,150 | Bug 49150 All primary sessions are deleted at BackupManager#stopInternal. | BackupManager#stopInternal is as follows. ===== protected synchronized void stopInternal() throws LifecycleException { super.stopInternal(); LazyReplicatedMap map = (LazyReplicatedMap)sessions; if ( map!=null ) { map.breakdown(); } cluster.removeManager(this); } ===== In Tomcat 7.0.0 RC1, super#stopInternal() is called first. In StandardManager#stopInternal() of the super class, The session is stored, and expire all active sessions. Storing session is unnecessary in BackupManager. and When the session expired, the session is deleted from all cluster nodes. As a Result, All primary sessions (of own node has) are deleted from all cluster nodes. For instance, Node1 : sessionA(primary), sessionB(proxy), sessionC(backup) Node2 : sessionA(backup), sessionB(primary), sessionC(proxy) Node3 : sessionA(proxy), sessionB(backup), sessionC(primary) If Node1 is stopped, it becomes the following. Node1 : stopped Node2 : sessionB(primary), sessionC(backup) Node3 : sessionB(backup), sessionC(primary) sessionA is expired. It should be the following. Node1 : stopped Node2 : sessionA(primary), sessionB(primary), sessionC(backup) Node3 : sessionA(backup), sessionB(backup), sessionC(primary) There is no problem in Tomcat6.0.x, because it executes super.stop() after LazyReplicatedMap#breakdown() . I made a patch against trunk. Best Regards. | resolved fixed | 09f4e25 | ["java/org/apache/catalina/ha/session/BackupManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-19T10:07:16Z" | "2010-04-19T06:53:20Z" |
49,129 | Bug 49129 DigestAuthenticator.md5Helper - possible incorrect lazy initialisation | Findbugs says: "This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions, threads are not guaranteed to see a completely initialized object, if the method can be called by multiple threads. You can make the field volatile to correct the problem." | resolved fixed | 867605f | ["java/org/apache/catalina/authenticator/DigestAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T23:13:45Z" | "2010-04-15T00:06:40Z" |
49,118 | Bug 49118 Inefficient use of String concatenation in loop | null | resolved fixed | 95a2eb8 | ["java/javax/servlet/http/HttpServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T22:50:35Z" | "2010-04-14T10:13:20Z" |
49,110 | Bug 49110 runtime.JspFactoryImpl$PageContextPool needs to be static | Findbugs says: Bug: org.apache.jasper.runtime.JspFactoryImpl$PageContextPool needs to be _static_ to avoid a deadly embrace with org.apache.jasper.runtime.JspFactoryImpl.localPool Pattern id: SIC_THREADLOCAL_DEADLY_EMBRACE, type: SIC, category: CORRECTNESS This class is an inner class, but should probably be a static inner class. As it is, there is a serious danger of a deadly embrace between the inner class and the thread local in the outer class. Because the inner class isn't static, it retains a reference to the outer class. If the thread local contains a reference to an instance of the inner class, the inner and outer instance will both be reachable and not eligible for garbage collection. | resolved fixed | b027259 | ["java/org/apache/jasper/runtime/JspFactoryImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T22:47:57Z" | "2010-04-13T00:53:20Z" |
49,109 | Bug 49109 RealmBase.authenticate uses toString on byte array | catalina.realm.RealmBase.authenticate(String username, byte[] credentials) has the following code: return (authenticate(username, credentials.toString())); This looks wrong, as credentials is a byte array. It should probably be: return (authenticate(username, new String(credentials[,charset]))); | resolved fixed | bcf0a01 | ["java/org/apache/catalina/Realm.java", "java/org/apache/catalina/realm/CombinedRealm.java", "java/org/apache/catalina/realm/LockOutRealm.java", "java/org/apache/catalina/realm/RealmBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T22:43:37Z" | "2010-04-13T00:53:20Z" |
49,106 | Bug 49106 Unused imports | null | resolved fixed | f8d3565 | ["java/org/apache/catalina/realm/JNDIRealm.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T22:29:34Z" | "2010-04-12T22:06:40Z" |
49,105 | Bug 49105 Javadoc corrections | null | resolved fixed | ead3997 | ["java/javax/el/ExpressionFactory.java", "java/javax/servlet/HttpConstraintElement.java", "java/javax/servlet/ServletContext.java", "java/org/apache/catalina/Context.java", "java/org/apache/catalina/Host.java", "java/org/apache/catalina/Lifecycle.java", "java/org/apache/catalina/Session.java", "java/org/apache/catalina/authenticator/FormAuthenticator.java", "java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/core/ApplicationSessionCookieConfig.java", "java/org/apache/catalina/core/ContainerBase.java", "java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/session/StandardSession.java", "java/org/apache/catalina/tribes/ChannelListener.java", "java/org/apache/catalina/tribes/group/RpcChannel.java", "java/org/apache/el/parser/AstValue.java", "java/org/apache/jasper/compiler/Node.java", "webapps/examples/WEB-INF/classes/chat/ChatServlet.java", "webapps/examples/WEB-INF/classes/filters/ExampleFilter.java", "webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T22:27:59Z" | "2010-04-12T22:06:40Z" |
49,104 | Bug 49104 Fix up some raw types | null | resolved fixed | 5be4f29 | ["java/org/apache/coyote/ajp/AjpProtocol.java", "java/org/apache/coyote/http11/Http11Protocol.java", "java/org/apache/tomcat/util/net/JIoEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T22:24:17Z" | "2010-04-12T22:06:40Z" |
49,103 | Bug 49103 Missing annotations | null | resolved fixed | 1018cd7 | ["java/org/apache/coyote/http11/Http11NioProtocol.java", "java/org/apache/coyote/http11/Http11Protocol.java", "java/org/apache/tomcat/util/net/AprEndpoint.java", "java/org/apache/tomcat/util/net/NioEndpoint.java", "java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T22:19:33Z" | "2010-04-12T22:06:40Z" |
49,045 | Bug 49045 JMX Enhancement- Provision of MBeanFactory createStandardService | Currently MBeanFactory doesn't have a method for creating a new StandardService MBean. This would become an issue for future enhancements of JMX support in Tomcat. As per discussions with Mark, this enhancement is suggested as a starting point for possible future enhancements in JMX support. | resolved fixed | 32046eb | ["java/org/apache/catalina/mbeans/MBeanFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T12:07:04Z" | "2010-04-04T08:33:20Z" |
49,089 | Bug 49089 ChannelData.USE_SECURE_RANDOM_FOR_UUID public static mutable field | catalina.tribes.io.ChannelData.USE_SECURE_RANDOM_FOR_UUID is a mutable public static field. It's only used by an instance method, so there's no need for it to be static. Probably no need for it to be public either; it could be a private field with a setter - or better a final field set by the constructor. | resolved fixed | cb0b029 | ["java/org/apache/catalina/tribes/io/ChannelData.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T10:14:34Z" | "2010-04-12T02:40:00Z" |
49,116 | Bug 49116 Memory leak by HttpSession. | When session is stored in StandardManager#doUnload method, an invalid session is stored. For instance, If HttpSession#invalidate is executed while executing StandardManager#doUnload, session of "isValid=false" is stored. The session of isValid=false is restored in StandardManager#doLoad, and it registers in session map (sessions). However, no one can invalidate this session. If isValid is false, StandardSession#invalidate() and StandardSession#isValid() can not expire session. They are throws IllegalStateException or return immediately. Consequently, the session of isValid=false is never deleted from the session map(sessions). I made a patch. If session is already invalid, expire session to prevent memory leak. Best Regards. Keiichi. | resolved fixed | bddfc0a | ["java/org/apache/catalina/session/StandardManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-14T08:48:43Z" | "2010-04-14T07:26:40Z" |
49,086 | Bug 49086 Addition of Javadoc for Servlet 3.0 annotations | null | resolved fixed | 6fc4360 | ["java/javax/servlet/annotation/HandlesTypes.java", "java/javax/servlet/annotation/HttpConstraint.java", "java/javax/servlet/annotation/HttpMethodConstraint.java", "java/javax/servlet/annotation/MultipartConfig.java", "java/javax/servlet/annotation/ServletSecurity.java", "java/javax/servlet/annotation/WebFilter.java", "java/javax/servlet/annotation/WebInitParam.java", "java/javax/servlet/annotation/WebListener.java", "java/javax/servlet/annotation/WebServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-12T10:34:09Z" | "2010-04-11T21:06:40Z" |
49,091 | Bug 49091 Util.specialCharactersRepresentation should be private | jasper.tagplugins.jstl.Util.specialCharactersRepresentation is a mutable public static array; it is not used outside the class as far as I can tell and so should be made private | resolved fixed | 1ecfaa9 | ["java/org/apache/jasper/tagplugins/jstl/Util.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-12T09:42:07Z" | "2010-04-12T02:40:00Z" |
49,075 | Bug 49075 protected Class User doesn't check argument roles for null | null | resolved fixed | e59ba8f | ["java/org/apache/catalina/realm/JNDIRealm.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-09T11:16:40Z" | "2010-04-08T20:53:20Z" |
49,018 | Bug 49018 Timeout argument misprocessed when expiring sessions from Tomcat Manager | Steps to reproduce: 1. Login to the Tomcat Manager Application 2. Select a web application that has several sessions that are inactive for more than 2 minutes 3. In the text field next to the "Expire sessions" button print "2" 4. Press "Expire sessions" 5. Sample observed result: OK - Session information for application at context path /myapp Default maximum session inactive interval 30 minutes <1 minutes:16 sessions 1 - <2 minutes:2 sessions 2 - <3 minutes:5 sessions 3 - <4 minutes:1 sessions 4 - <5 minutes:2 sessions 5 - <6 minutes:1 sessions 6 - <7 minutes:2 sessions 9 - <10 minutes:1 sessions 8 minutes:expired 0 sessions Actually some sessions were expired (even if the above message prints "0"). Expected result: All sessions with idle time > 2 minutes had to be expired. The bug is in the following lines of ManagerServlet#sessions(PrintWriter, String, int): Lines 1176-1179 if (idle >= 0 && time >= idle*60) { sessions[i].expire(); idle++; } The patch would be to replace "idle++" with "expired++", because "idle" is the time (in minutes) as submitted from the web form and "expired" is the counter. | resolved fixed | 155e3f8 | ["java/org/apache/catalina/manager/ManagerServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-07T03:24:08Z" | "2010-03-29T19:13:20Z" |
48,648 | Bug 48648 Blank page (dropped connection) when running TC7 with TCnative (APR) | null | resolved fixed | 216352a | ["java/org/apache/tomcat/util/net/AprEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-04T16:26:51Z" | "2010-01-31T23:20:00Z" |
49,014 | Bug 49014 Add RemoteIpFilter test case | null | resolved fixed | d9330a9 | ["test/org/apache/catalina/filters/TestRemoteIpFilter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-04T10:37:17Z" | "2010-03-29T05:20:00Z" |
48,983 | Bug 48983 Enhance RemoteIpValve and RemoteIpFilter logging | null | resolved fixed | 9a42719 | ["java/org/apache/catalina/filters/RemoteIpFilter.java", "java/org/apache/catalina/valves/RemoteIpValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-04-04T10:25:56Z" | "2010-03-25T04:06:40Z" |
48,895 | Bug 48895 WebAppClassLoader.clearThreadLocalMap() concurrency issues | I think that the memory leak protection of WebAppClassLoader.clearReferencesThreadLocals() which detects and clears ThreadLocals that would prevent GC the WebAppClassLoader instance has issues regarding concurrency : - It enumerates Threads and looks into internal structures of the Thread class, but there are no "memory barrier" that would ensure a consistent state of the ThreadLocalMap being examined. So, it is theoretically possible that a ThreadLocal in Thread A was properly cleaned up by the application, but the current thread B (that is undeploying the application) does not see the up to date state because there's no synchronization between those threads. - Much more severe : after detecting such a leak, it invokes java.lang.ThreadLocal.ThreadLocalMap.remove(ThreadLocal) on Thread A's ThreadLocalMap instance but the invocation is done by Thread B (the thread that undeploys the app). The remove() method is not thread safe at all, and nor is the expungeStaleEntries() method which may also be invoked in clearThreadLocalMap(). So, if a webapp is being undeployed while other applications continue to receive a heavy load of requests, this could corrupt the internal structures of the ThreadLocalMap instance ! I propose to keep the detection of leaks as it is, but to make the actual clearing optional (and disabled by default) to avoid encountering big problems in production. Idea to improve the clearing in a safe way : if the thread that is "provoking" the leak is one of tomcat's worker threads, we could mark it as "dirty", and then have a background task that would end such threads (renew those threads in the pool). | resolved fixed | ae6fcf5 | ["java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/loader/WebappClassLoader.java", "java/org/apache/catalina/loader/WebappLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-29T15:01:14Z" | "2010-03-12T02:13:20Z" |
48,717 | Bug 48717 Session listeners not called on cluster node start | null | resolved fixed | 39d3082 | ["java/org/apache/catalina/ha/session/DeltaManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-28T19:34:12Z" | "2010-02-10T00:00:00Z" |
48,662 | Bug 48662 context.xml expansion on deployment improvements | Two parts: 1. Log a warning/info message if Tomcat ignores a bundled context.xml in favour of one in CATALINA_BASE/<engine name>/<host name> 2. Make the extraction/copying of context.xml configurable, probably via a new attribute extractXml on the host | resolved fixed | 83226d9 | ["java/org/apache/catalina/Context.java", "java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/core/StandardHost.java", "java/org/apache/catalina/mbeans/MBeanFactory.java", "java/org/apache/catalina/startup/ContextConfig.java", "java/org/apache/catalina/startup/HostConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-28T11:57:46Z" | "2010-02-03T04:06:40Z" |
48,934 | Bug 48934 Cluster's regression. When replication fails once, replication can be never done again. | null | resolved fixed | fc66705 | ["java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java", "java/org/apache/catalina/tribes/transport/nio/PooledParallelSender.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-18T13:54:27Z" | "2010-03-18T13:46:40Z" |
44,265 | Bug 44265 Improve JspWriterImpl performance with "inline" sub method | As you know, the JspWriterImpl.write method was always invoked in JSP file frequently. But I found its performance is poor because too many sub method were invoked as well. After copying two sub method's code to write method, the performance was improved observably. | resolved fixed | 9113574 | ["java/org/apache/jasper/runtime/JspWriterImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-11T18:32:39Z" | "2008-01-18T07:06:40Z" |
48,760 | Bug 48760 Tomcat breaks in serving large files (>=1.8MB) under high load and high threading. | null | resolved fixed | f1760d8 | ["java/org/apache/naming/resources/FileDirContext.java", "java/org/apache/naming/resources/WARDirContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-09T13:15:15Z" | "2010-02-18T02:26:40Z" |
48,737 | Bug 48737 JspCompilationContext assumes that tagfile with a path starting with META-INF are in jars without checking | null | resolved fixed | 6ac5036 | ["java/org/apache/jasper/JspCompilationContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-09T12:30:37Z" | "2010-02-13T22:26:40Z" |
48,729 | Bug 48729 JNDIRealm.java not parsing roles correctly | null | resolved fixed | 4cf35b8 | ["java/org/apache/catalina/realm/JNDIRealm.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-09T12:14:23Z" | "2010-02-11T23:13:20Z" |
48,661 | Bug 48661 inconsistent error page behavior | There seems to be a bug or at least an inconsistency in how tomcat handles the error page. In Tomcat 6.0.20, if I define my error page like this in web.xml: <error-page> <exception-type>java.lang.Exception</exception-type> <location>/unexpectedErrors.jsp</location> </error-page> Then, if the response has already been committed, Tomcat does this on the system console: Feb 1, 2010 5:59:04 PM org.apache.catalina.core.StandardWrapperValve invoke SEVERE: Servlet.service() for servlet jsp threw exception java.lang.NullPointerException at org.apache.jsp.cpe_jsp._jspService(cpe_jsp.java:693) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at com.eaglecreektech.expedience.provisioning.web.servletFilters.AuthFilter.doFilter(AuthFilter.java:133) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at com.eaglecreektech.expedience.provisioning.web.servletFilters.RequestVolumeFilter.doFilter(RequestVolumeFilter.java:141) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at com.eaglecreektech.expedience.provisioning.web.servletFilters.StartupCheckFilter.doFilter(StartupCheckFilter.java:65) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454) at java.lang.Thread.run(Thread.java:619) Feb 1, 2010 5:59:04 PM org.apache.catalina.core.StandardHostValve custom SEVERE: Exception Processing ErrorPage[exceptionType=java.lang.Exception, location=/unexpectedErrors.jsp] java.lang.IllegalStateException: Cannot reset buffer after response has been committed at org.apache.catalina.connector.Response.resetBuffer(Response.java:691) at org.apache.catalina.core.StandardHostValve.custom(StandardHostValve.java:409) at org.apache.catalina.core.StandardHostValve.throwable(StandardHostValve.java:271) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:142) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454) at java.lang.Thread.run(Thread.java:619) And it doesn't put any error text into the broken page - the page just shows how ever far it got before it encountered the error. This behavior doesn't seem correct - it seems like it should at least behave the same way as it does when the error page is defined in a jsp page: <%@ page errorPage="unexpectedErrors.jsp" %> If the response has already been committed, then it just appends the error page onto the end of the response (not ideal, but nothing else can be done, as far as I know) If the response has not been committed, it clears the buffer and writes the error page (which looks nice and pretty , like it should) I'd suggest that the error handling code for the error page as defined in web.xml should check if the response has been committed, and not try to clear the buffer if it is already committed - just append to the end, the same way that the jsp error handler does. | resolved fixed | 1ec5ca7 | ["java/org/apache/catalina/core/StandardHostValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-03-08T18:58:28Z" | "2010-02-02T19:46:40Z" |
48,582 | Bug 48582 JspServletWrapper.getServletContext() throws NullPointerException | null | resolved fixed | 7301a10 | ["java/org/apache/jasper/servlet/JspServletWrapper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-16T11:07:00Z" | "2010-01-20T17:53:20Z" |
48,580 | Bug 48580 6.0.24: AccessControlException in ProtectedFunctionMapper on first access to certain JSP | null | resolved fixed | 9e55819 | ["java/org/apache/jasper/security/SecurityClassLoad.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-16T09:27:49Z" | "2010-01-20T17:53:20Z" |
48,498 | Bug 48498 6.0.22RC: ArrayIndexOutOfBoundsException from Jasper when compilation error inside a CDATA block | null | resolved fixed | 789ac1e | ["java/org/apache/jasper/compiler/JavacErrorDetail.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-16T00:46:07Z" | "2010-01-06T23:20:00Z" |
48,384 | Bug 48384 globalXsltFile parameter for the DefaultServlet | When overriding the DefaultServlet for a given application, the globalXsltFile path need to be relative to Tomcat root. for example: <init-param> <param-name>globalXsltFile</param-name> <param-value>webapps/quercus/WEB-INF/listing.xsl</param-value> </init-param> it would be nice if the path could be relative to the application context. | resolved fixed | 0e595cf | ["java/org/apache/catalina/servlets/DefaultServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-13T20:12:11Z" | "2009-12-13T21:33:20Z" |
48,371 | Bug 48371 addWebXmlMappings does not place servlet tags correctly | If there is a commented-out <security-constraint> or commented-out <servlet> tag and addWebXmlMappings="true", the JSP's servlet and servlet-mapping tags are placed incorrectly and Tomcat will not start due to "--" being inside a comment. Basically, it seems the web.xml is not parsed correctly when using addWebXmlMappings and you cannot have above tags commented out, or new servlet tags will be placed incorrectly and comment tags not respected. | resolved fixed | 563e315 | ["java/org/apache/jasper/JspC.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-13T18:25:07Z" | "2009-12-11T00:06:40Z" |
48,318 | Bug 48318 WebDAV servlet returns 500 if files not readable | If a directory contains a file that is not readable by the Tomcat process (eg file permissions, dangling symlink) then Tomcat throws a NullPointerException and returns a 500 Internal Server Error to the client. Throwing NPE in these circumstances is certainly wrong. Returning 500 with no further information is unhelpful behavior and should be fixed. Generally, interfaces of this type at least list inaccessible files (Windows Explorer, UNIX ls(1), BSD FTP client, ...) and only return an error when one attempts to access such a file. markt suggests an alternative of simply ignoring inaccessible files but notes that "could cause issues if a user tries to upload a file of that name" and suggests better error reporting. Stack: SEVERE: Servlet.service() for servlet webdav threw exception java.lang.NullPointerException at org.apache.catalina.servlets.WebdavServlet.parseProperties(Unknown Source) at org.apache.catalina.servlets.WebdavServlet.doPropfind(Unknown Source) at org.apache.catalina.servlets.WebdavServlet.service(Unknown Source) at javax.servlet.http.HttpServlet.service(Unknown Source) ... Method parseProperties() is in java/org/apache/catalina/servlets/WebdavServlet.java.org and the NPE happens when cacheEntry.attributes is null (case FIND_BY_PROPERTY in my testing and possibly in other cases too). Following the breadcrumbs via: cacheEntry = resources.lookupCache(path); leads eventually to java/org/apache/naming/resources/FileDirContext.java: public Attributes getAttributes(String name, String[] attrIds) throws NamingException { // Building attribute list File file = file(name); if (file == null) throw new NamingException (sm.getString("resources.notFound", name)); ... protected File file(String name) { File file = new File(base, name); if (file.exists() && file.canRead()) { ... // do useful stuff } else { return null; // ouch } | resolved fixed | da42e44 | ["java/org/apache/catalina/servlets/WebdavServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-12T22:12:48Z" | "2009-12-01T12:20:00Z" |
48,726 | Bug 48726 DeployTask throws OutOfMemoryErrors when deploying large WAR files | null | resolved fixed | 53e0674 | ["java/org/apache/catalina/ant/AbstractCatalinaTask.java", "java/org/apache/catalina/ant/DeployTask.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-10T23:47:11Z" | "2010-02-11T03:46:40Z" |
48,170 | Bug 48170 Unnecessary synchronization by JspFactory.getDefaultFactory contributes to stability problems | I have a soak test at constant load that is initially stable. Within the hour, an ever increasing number of blocked threads develops. The vast majority of threads are in JSP rendering, blocked on JspFactory.getDefaultFactory(). The server eventually crashes. We are running Java 6. Upon code inspection, there appears to be no real reason for synchronizing the getDefaultFactory() and setDefaultFactory() as the setter is called only once upon startup when the sub-class loads. Patching the jar, I tried three other experiments: 1) Removing the synchronized keyword entirely. 2) Locking on an inner static class instead of the JspFactory.class. 3) Using volatile for the static member variable. Both experiments #1 and #3 showed vastly better stability. I was able to double the throughput of the server without seeing increasing number of blocked threads. Experiment #2 yielded the same behavior as the original code. Thus, no other code is synchronizing on JspFactory.class. Rather, there seem to be some sort of contention in the java.lang.Class monitor. Using volatile would preserve the multi-threading semantics while avoiding contributing to the instability issue. | resolved fixed | c09753b | ["java/javax/servlet/jsp/JspFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-08T22:20:55Z" | "2009-11-10T21:53:20Z" |
48,109 | Bug 48109 Improve binaryStream processing in WebappClassLoader#findResourceInternal | null | resolved fixed | dda2cbc | ["java/org/apache/catalina/loader/WebappClassLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-08T22:07:24Z" | "2009-11-03T01:00:00Z" |
48,665 | Bug 48665 RemoteIpValve examples refer to "connector" package | null | resolved fixed | 9905155 | ["java/org/apache/catalina/valves/RemoteIpValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-08T02:06:49Z" | "2010-02-03T09:40:00Z" |
48,643 | Bug 48643 catalina.session.FileStore.save() and load() - close() bugs | The code for the save() method reads: try { fos = new FileOutputStream(file.getAbsolutePath()); oos = new ObjectOutputStream(new BufferedOutputStream(fos)); } catch (IOException e) { if (oos != null) { <== oos can only be null here try { oos.close(); } catch (IOException f) { // Ignore } } throw e; } Presumably the catch statement should try to close fos instead? Similarly for the load() method; at line 280/281 there is the code: } catch (IOException e) { if (ois != null) { However, ois is the last object created by the try clause, so must be null. Probably the code should check and close bis and/or fis. At the end of the load() method, the code says: // Close the input stream if (ois != null) { However, ois cannot be null at that point. Note: these bugs were detected by the Eclipse compiler. | resolved fixed | 6f48cde | ["java/org/apache/catalina/session/FileStore.java", "java/org/apache/catalina/session/StandardManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-07T22:16:40Z" | "2010-01-30T22:20:00Z" |
48,678 | Bug 48678 org.apache.catalina.startup.Catalina incorrectly duplicates super class member | null | resolved fixed | 067e0ba | ["java/org/apache/catalina/startup/Catalina.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-06T21:34:12Z" | "2010-02-04T05:06:40Z" |
48,551 | Bug 48551 StringCache: Use entrySet() rather than keySet() + get() | null | resolved fixed | c85e791 | ["java/org/apache/catalina/deploy/WebXml.java", "java/org/apache/tomcat/util/buf/StringCache.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-02T17:21:23Z" | "2010-01-15T01:46:40Z" |
48,653 | Bug 48653 RemoteIpValve : request.secure and request.scheme are not forced to "false" and "http" if X-Forwarded-Proto=http | null | resolved fixed | 1789bd8 | ["java/org/apache/catalina/valves/RemoteIpValve.java", "test/org/apache/catalina/valves/TestRemoteIpValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-02T13:28:55Z" | "2010-02-01T13:13:20Z" |
48,647 | Bug 48647 RemoteIpFilter : request.secure and request.scheme are not forced to "false" and "http" if X-Forwarded-Proto=http | null | resolved fixed | 7aa1206 | ["java/org/apache/catalina/filters/RemoteIpFilter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-02-02T13:25:42Z" | "2010-01-31T20:33:20Z" |
48,645 | Bug 48645 RequestUtil.URLDecode(byte[] bytes, String enc) | the enc is not used in the implementation public static String URLDecode(byte[] bytes, String enc) { return URLDecode(bytes, null, false); } | resolved fixed | d0f9da2 | ["java/org/apache/catalina/util/RequestUtil.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-01-31T12:48:53Z" | "2010-01-31T09:26:40Z" |
48,516 | Bug 48516 NullPointerException in JNDIRealm | null | resolved fixed | 62d29b6 | ["java/org/apache/catalina/realm/JNDIRealm.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-01-12T22:43:23Z" | "2010-01-11T11:40:00Z" |
48,004 | Bug 48004 setHeader() does not replace the previous value for a "Server" | null | resolved fixed | 13daf69 | ["java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/coyote/http11/Http11NioProcessor.java", "java/org/apache/coyote/http11/Http11Processor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-01-12T21:36:49Z" | "2009-10-15T15:20:00Z" |
48,421 | Bug 48421 JULI webapp logging files will not closed when webapp is stopped,reloaded or undeployed | In Tomcat 6 the JULI logging files which are (can be) declared in webapp/WEB-INF/classes/logging.properties will not closed, when the webapp is reloaded, stopped or even undeployed. The files will at last be closed, when tomcat is shut down or restarted. This is also true for the normally used Handler org.apache.juli.FileHandler, which opens a new File every day and closes the old. On windows this has following effects: A) If the webapp is undeployed the files which are open at this moment are locked and cannot be deleted until tomcat is (someday) stopped or restarted. B) If the webapp is reloaded the file is opened a second time. So the file has two open handles. The next day the FileHandler closes one handle but the file is kept locked through the other handle and cannot be deleted. Every time a webapp is reloaded the associated logfile is opened again (but not closed). This has the consequence that after reloading webapps a few times tomcat must be restarted from time to time. When tomcat is shutdown the unnecessary (and other) open files are closed and will get the shutdown time as modification time. That means any old log files will receive a current modification time, which is irritating. Steps to verify on windows: (for example: undeploy) 1. create in the examples webapp: of tomcat 6.0.20: examples/WEB-INF/classes/logging.properties: handlers = org.apache.juli.FileHandler org.apache.juli.FileHandler.level = FINE org.apache.juli.FileHandler.directory = ${catalina.base}/logs org.apache.juli.FileHandler.prefix = servlet-examples. 2. start tomcat 3. undeploy examples using manager Actual Results: file ${catalina.base}/logs/servlet-examples.<date>.log cannot be deleted (nor at the next day) Expected: file ${catalina.base}/logs/servlet-examples.<date>.log can be deleted very cumbersome Workaround (working for reload): The getHead method of a custom Formatter is extended to track the handlers along with the classloader and webapp. If for a webapp a different (i.e. new) classloader is detected the close method of the handlers assigned to the old classloader is called. So the assigned file is proper closed (and the Formatter.getTail result is appended) I have set severity at minor because tomcat can be used (without webapp logging). But it is a bug because with this logging the same logfile can be useless multiple open (as described above), which should be considered as buggy. | resolved fixed | eeb017a | ["java/org/apache/juli/ClassLoaderLogManager.java", "java/org/apache/juli/logging/LogFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-01-12T19:06:48Z" | "2009-12-20T20:13:20Z" |
48,523 | Bug 48523 Duplicate property keys in various files | There are some properties files with non-unique property keys; normally these should be unique. File: java\org\apache\catalina\realm\LocalStrings.properties Duplicate key: 'jaasRealm.userPrincipalSuccess' jaasRealm.userPrincipalSuccess=Principal "{0}" is a valid user class. We will use this as the user Principal. jaasRealm.userPrincipalSuccess=Subject for username "{0}" returned user Principal "{1}" Duplicate key: 'jaasRealm.userPrincipalFailure' jaasRealm.userPrincipalFailure=No valid user Principal found jaasRealm.userPrincipalFailure=Subject for username "{0}" did not return a valid user Principal File: java\org\apache\catalina\realm\LocalStrings_es.properties Duplicate key: 'jaasRealm.userPrincipalSuccess' jaasRealm.userPrincipalSuccess = El Principal "{0}" es una clase v\u00E1lida de usuario. La vamos a usar como usuario Principal. jaasRealm.userPrincipalSuccess = El asunto para el nombre de usuario "{0}" devolvi\u00F3 usuario Principal "{1}" Duplicate key: 'jaasRealm.userPrincipalFailure' jaasRealm.userPrincipalFailure = No se ha hallado usuario Principal jaasRealm.userPrincipalFailure = El asunto para el nombre de usuario "{0}" no devolvi\u00F3 un usuario Principal v\u00E1lido File: java\org\apache\catalina\startup\LocalStrings.properties Duplicate key: 'contextConfig.jndiUrl' contextConfig.jndiUrl=The connection created for URL [{0}] was not a DirContextURLConnection contextConfig.jndiUrl=Unable to process JNDI URL [{0}] for annotations Duplicate key: 'webXml.mergeConflictFilter' webXml.mergeConflictFilter=The Servlet [{0}] was defined inconsistently in multiple fragments including fragment with name [{1}] located at [{2}] webXml.mergeConflictFilter=The Filter [{0}] was defined inconsistently in multiple fragments including fragment with name [{1}] located at [{2}] File: java\org\apache\jasper\resources\LocalStrings.properties Duplicate key: 'jsp.error.page.invalid.buffer' jsp.error.page.invalid.buffer=Page directive: invalid value for buffer jsp.error.page.invalid.buffer=Page directive: invalid buffer size Duplicate key: 'jsp.error.xml.invalidHighSurrogate' jsp.error.xml.invalidHighSurrogate = High surrogate bits in UTF-8 sequence must not exceed 0x10 but found 0x{0}. jsp.error.xml.invalidHighSurrogate = High surrogate bits in UTF-8 sequence must not exceed 0x10 but found 0x{0}. File: java\org\apache\jasper\resources\LocalStrings_es.properties Duplicate key: 'jsp.error.page.invalid.buffer' jsp.error.page.invalid.buffer = Directiva Page\: valor incorrecto para b\u00FAfer jsp.error.page.invalid.buffer = Directiva Page\: valor incorrecto para buffer Duplicate key: 'jsp.error.xml.invalidHighSurrogate' jsp.error.xml.invalidHighSurrogate = Los bits de surrogaci\u00F3n alta en secuencai UTF-8 no deben de exceder 0x10 pero se hall\u00F3 0x{0}. jsp.error.xml.invalidHighSurrogate = Surrogaci\u00F3n Alta de bits en secuencia UTF-8 no debe de exceder 0x10, pero se hall\u00F3 0x{0}. File: java\org\apache\jasper\resources\LocalStrings_ja.properties Duplicate key: 'jsp.error.page.invalid.buffer' jsp.error.page.invalid.buffer=page\u6307\u793a\u5b50: buffer\u5c5e\u6027\u306e\u5024\u304c\u7121\u52b9\u3067\u3059 jsp.error.page.invalid.buffer=page\u6307\u793a\u5b50: \u7121\u52b9\u306a\u30d0\u30c3\u30d5\u30a1\u30b5\u30a4\u30ba\u3067\u3059 Duplicate key: 'jsp.error.xml.invalidHighSurrogate' jsp.error.xml.invalidHighSurrogate = UTF-8\u30b7\u30fc\u30b1\u30f3\u30b9\u306e\u30cf\u30a4\u30b5\u30ed\u30b2\u30fc\u30c8\u30d3\u30c3\u30c8\u306f0x10\u3092\u8d8a\u3048\u3066\u306f\u3044\u3051\u307e\u305b\u3093\u304c\u30010x{0}\u304c\u898b\u3064\u304b\u308a\u307e\u3057\u305f jsp.error.xml.invalidHighSurrogate = UTF-8\u30b7\u30fc\u30b1\u30f3\u30b9\u306e\u30cf\u30a4\u30b5\u30ed\u30b2\u30fc\u30c8\u30d3\u30c3\u30c8\u306f0x10\u3092\u8d8a\u3048\u3066\u306f\u3044\u3051\u307e\u305b\u3093\u304c\u30010x{0}\u304c\u898b\u3064\u304b\u308a\u307e\u3057\u305f File: java\org\apache\tomcat\util\net\res\LocalStrings.properties Duplicate key: 'endpoint.poll.fail' endpoint.poll.fail=Socket [{0}] poll event: [{1}] {2} endpoint.poll.fail=Critical poller failure (restarting poller): [{0}] {1} File: java\org\apache\tomcat\util\net\res\LocalStrings_es.properties Duplicate key: 'endpoint.poll.fail' endpoint.poll.fail = Conector [{0}] evento de encuesta\: [{1}] {2} endpoint.poll.fail = Fallo cr\u00EDtico de encuestador (reiniciando encuestador)\: [{0}] {1} File: java\org\apache\tomcat\util\net\res\LocalStrings.properties Duplicate key: 'endpoint.poll.fail' endpoint.poll.fail=Socket [{0}] poll event: [{1}] {2} endpoint.poll.fail=Critical poller failure (restarting poller): [{0}] {1} File: java\org\apache\tomcat\util\net\res\LocalStrings_es.properties Duplicate key: 'endpoint.poll.fail' endpoint.poll.fail = Conector [{0}] evento de encuesta\: [{1}] {2} endpoint.poll.fail = Fallo cr\u00EDtico de encuestador (reiniciando encuestador)\: [{0}] {1} | resolved fixed | f2eea0c | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-01-12T11:09:18Z" | "2010-01-11T17:13:20Z" |
48,517 | Bug 48517 @SuppressWarnings("unchecked") - document and reduce scope | null | resolved fixed | 4df1957 | ["java/javax/el/BeanELResolver.java", "java/javax/el/ELContext.java", "java/javax/el/ResourceBundleELResolver.java", "java/org/apache/catalina/loader/WebappClassLoader.java", "java/org/apache/el/lang/ELSupport.java", "java/org/apache/el/lang/EvaluationContext.java", "java/org/apache/el/parser/AstIdentifier.java", "java/org/apache/el/parser/AstValue.java", "java/org/apache/el/parser/SimpleNode.java", "java/org/apache/naming/resources/VirtualDirContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-01-12T10:31:03Z" | "2010-01-11T11:40:00Z" |
48,112 | Bug 48112 Closing curly brace in literal string incorrectly treated as expression terminator. | On tomcat 6.0.20 something like the following line in a JSP causes a exception: <c:out value="${fn:trim('{world}')}"/> After removing the closing curly brace from the literal ('{world}' -> '{world') the JSP works. This behaviour seems specific to 6.0.20, as on 6.0.18 and 6.0.16 the line above works fine. Example of exception: ===================== org.apache.jasper.JasperException: An exception occurred processing JSP page /test.jsp at line 11 8: <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> 9: </head> 10: <body> 11: <c:out value="${fn:trim('{world}')}"/> 12: </body> 13: </html> Stacktrace: org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:505) org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:416) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) root cause javax.el.ELException: Error Parsing: ${fn:trim('{world} org.apache.el.lang.ExpressionBuilder.createNodeInternal(ExpressionBuilder.java:125) org.apache.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:150) org.apache.el.lang.ExpressionBuilder.createValueExpression(ExpressionBuilder.java:194) org.apache.el.ExpressionFactoryImpl.createValueExpression(ExpressionFactoryImpl.java:68) org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:934) org.apache.jsp.test_jsp._jspx_meth_c_005fout_005f0(test_jsp.java:98) org.apache.jsp.test_jsp._jspService(test_jsp.java:72) org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) root cause org.apache.el.parser.ParseException: Encountered " <ILLEGAL_CHARACTER> "\' "" at line 1, column 11. Was expecting one of: <INTEGER_LITERAL> ... <FLOATING_POINT_LITERAL> ... <STRING_LITERAL> ... "true" ... "false" ... "null" ... "(" ... ")" ... "!" ... "not" ... "empty" ... "-" ... <IDENTIFIER> ... org.apache.el.parser.ELParser.generateParseException(ELParser.java:2142) org.apache.el.parser.ELParser.jj_consume_token(ELParser.java:2024) org.apache.el.parser.ELParser.Function(ELParser.java:1207) org.apache.el.parser.ELParser.NonLiteral(ELParser.java:1114) org.apache.el.parser.ELParser.ValuePrefix(ELParser.java:1016) org.apache.el.parser.ELParser.Value(ELParser.java:965) org.apache.el.parser.ELParser.Unary(ELParser.java:947) org.apache.el.parser.ELParser.Multiplication(ELParser.java:711) org.apache.el.parser.ELParser.Math(ELParser.java:631) org.apache.el.parser.ELParser.Compare(ELParser.java:443) org.apache.el.parser.ELParser.Equality(ELParser.java:337) org.apache.el.parser.ELParser.And(ELParser.java:281) org.apache.el.parser.ELParser.Or(ELParser.java:225) org.apache.el.parser.ELParser.Choice(ELParser.java:182) org.apache.el.parser.ELParser.Expression(ELParser.java:174) org.apache.el.parser.ELParser.DynamicExpression(ELParser.java:146) org.apache.el.parser.ELParser.CompositeExpression(ELParser.java:43) org.apache.el.lang.ExpressionBuilder.createNodeInternal(ExpressionBuilder.java:93) org.apache.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:150) org.apache.el.lang.ExpressionBuilder.createValueExpression(ExpressionBuilder.java:194) org.apache.el.ExpressionFactoryImpl.createValueExpression(ExpressionFactoryImpl.java:68) org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:934) org.apache.jsp.test_jsp._jspx_meth_c_005fout_005f0(test_jsp.java:98) org.apache.jsp.test_jsp._jspService(test_jsp.java:72) org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) | resolved fixed | 11810fb | ["test/org/apache/el/TestELEvaluation.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-01-06T18:51:24Z" | "2009-11-03T12:06:40Z" |
48,424 | Bug 48424 Keep same logic for creating the objectnames for connector mbeans | Currently, for connector MBeans, they are registered and unregistered by Connector classes themselves. But in the ServerLifecycle and MBeanUtils, there are also codes for unregistering the connector MBeans. Suppose it is used for double check ? The question is that the codes for creating connector object name are not same, in the MBeanUtils, it always assume that address property is of String type, sometimes that a ClassCastException would be thrown. | resolved fixed | da5f249 | ["java/org/apache/catalina/connector/Connector.java", "java/org/apache/catalina/mbeans/MBeanUtils.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2010-01-05T19:53:38Z" | "2009-12-21T04:33:20Z" |
48,006 | Bug 48006 Implement the header X-Powered-By suggested by the servlet specification | null | resolved fixed | 3d309a5 | ["java/org/apache/catalina/connector/CoyoteAdapter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-31T10:46:24Z" | "2009-10-15T15:20:00Z" |
43,819 | Bug 43819 Support latest JSR245 proposal to make EL "self-contained" | null | resolved fixed | 9a2ae02 | ["java/javax/el/ExpressionFactory.java", "java/org/apache/jasper/compiler/JspUtil.java", "java/org/apache/jasper/compiler/PageInfo.java", "java/org/apache/jasper/compiler/Validator.java", "java/org/apache/jasper/runtime/JspApplicationContextImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-30T22:20:30Z" | "2007-11-08T19:26:40Z" |
48,345 | Bug 48345 Session does time-out shorter than setting in web.xml when PersistentManager is used. | I am encountering the problem that Session does time-out shorter than setting in web.xml. This is a simple scenario where the problem occurs. I am using PersistentManager by the following configuration. <Context> <Manager className="org.apache.catalina.session.PersistentManager" maxIdleSwap="120"> <Store className="org.apache.catalina.session.FileStore"/> </Manager> </Context> I am setting the session-timeout at five minutes. <session-config> <session-timeout>5</session-timeout> </session-config> [scenario] 1. Create Session. 2. 120 seconds pass. Session does swapOut. 3. In addition, 120 seconds pass. Get Session. Session does swapIn and access time of session in the memory is updated. 4. In addition, 90 seconds pass. Get Session. Because the access time of the session has been updated in (3), The session should be able to be acquired. However, the session can not be acquired. This cause is StoreBase#processExpires invoked between (3) and (4). StoreBase#processExpire deletes the session saved in Store. StoreBase#processExpires is as follows. =====StoreBase#processExpires===== public void processExpires() { ... for (int i = 0; i < keys.length; i++) { try { StandardSession session = (StandardSession) load(keys[i]); if (session == null) { continue; } if (session.isValid()) { continue; } ... if ( ( (PersistentManagerBase) manager).isLoaded( keys[i] )) { // recycle old backup session session.recycle(); } else { // expire swapped out session session.expire(); } remove(session.getIdInternal()); } catch (Exception e) { ... } } } ====== The session saved in Store is loaded, and StandardSession#isValid() is executed. StandardSession#expire(true) is invoked for the session that passes session time-out in "StandardSession#isValid()". StandardSession#expire(true) invokes Manager#remove(Session). As a result, the session is deleted from the session map. In a word, session in memory is deleted by invalidating old session in Store. As a result, session does time-out shorter than setting in web.xml I made a patch against trunk. Best regards. | resolved fixed | d939925 | ["java/org/apache/catalina/session/StoreBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-30T11:30:01Z" | "2009-12-07T07:13:20Z" |
48,454 | Bug 48454 "Bad file descriptor"-IOException in CGIServlet for some programs | null | resolved fixed | ae6c3c4 | ["java/org/apache/catalina/servlets/CGIServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-30T10:45:34Z" | "2009-12-29T07:00:00Z" |
48,443 | Bug 48443 when the context path is empty,tomcat will startup with a FileNotFoundException | null | resolved fixed | ff22e4a | ["java/org/apache/naming/resources/DirContextURLConnection.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-30T09:24:17Z" | "2009-12-25T03:00:00Z" |
48,399 | Bug 48399 Lock fields should be final | null | resolved fixed | e1d1476 | ["java/org/apache/catalina/ha/session/DeltaSession.java", "java/org/apache/catalina/tribes/group/interceptors/OrderInterceptor.java", "modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/MultiLockFairBlockingQueue.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-20T03:46:02Z" | "2009-12-17T00:33:20Z" |
47,930 | Bug 47930 PersistentManager (using filestore) can return different session objects linked to the same session ID, when Tomcat is restarted | null | resolved fixed | d9f2c99 | ["java/org/apache/catalina/session/PersistentManagerBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-18T18:42:09Z" | "2009-10-02T02:20:00Z" |
48,387 | Bug 48387 Make RemoteIpFilter parameters consistent with RemoteIpValve | null | resolved fixed | 803d64d | ["java/org/apache/catalina/filters/RemoteIpFilter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-14T21:18:34Z" | "2009-12-14T14:13:20Z" |
47,744 | Bug 47744 Memory leak when using SSL + Java security manager | null | resolved fixed | 51d5511 | ["java/org/apache/tomcat/util/net/jsse/JSSESupport.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-14T14:53:00Z" | "2009-08-26T15:20:00Z" |
47,537 | Bug 47537 Empty response when forward to login page fails | When tomcat receives a POST request on a session that has timedout, it will forward to the form based login page (form-login-page). If this forward fails for some reason (an error in the login page for instance), tomcat will return an empty HTTP response, without any error code. The tomcat log says "Unexpected error forwarding to login page" and contains the detailed stacktrace, but i would expect the error to show up in the browser as well (at least a 500 status) | resolved fixed | 88b5d4b | ["java/org/apache/catalina/authenticator/FormAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-11T13:12:57Z" | "2009-07-15T15:00:00Z" |
48,373 | Bug 48373 Can not get clients from TomcatBayeux | When call the getClients method,there will be a Exception: java.lang.ArrayStoreException: java.util.HashMap$Entry maybe this method should be: public List<Client> getClients() { return java.util.Arrays.asList(clients.values().toArray(new Client[0])); } instead of this: public List<Client> getClients() { return java.util.Arrays.asList(clients.entrySet().toArray(new Client[0])); } | resolved fixed | b09d817 | ["modules/bayeux/java/org/apache/tomcat/bayeux/TomcatBayeux.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-11T12:17:27Z" | "2009-12-11T05:40:00Z" |
48,370 | Bug 48370 PublishRequest.java can not be compiled | There is a log used in org.apache.tomcat.bayeux.request.PublishRequest,but it was not be defined,so the class can not be complied successfully,there should be something like this? private static final Log log = LogFactory.getLog(PublishRequest.class); | resolved fixed | 9be399f | ["modules/bayeux/java/org/apache/tomcat/bayeux/request/PublishRequest.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-11T12:14:05Z" | "2009-12-10T21:20:00Z" |
48,324 | Bug 48324 Javadoc fixes for connector.Request.java | null | resolved fixed | 549a5d5 | ["java/org/apache/catalina/connector/Request.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-10T16:59:29Z" | "2009-12-01T20:40:00Z" |
47,502 | Bug 47502 clustering fails on serializing javax.security.auth.subject | Clustering fails on serializing javax.security.auth.subject. See stack below. I looked a little into the Tomcat code. In ./java/org/apache/catalina/connector/Request.java on line 1752 Tomcat puts the 'javax.security.auth.subject' on the session if you use a securitymanager. This is the MemoryUser in my case I think. I must use the securitymanager because I use RMI. Is there a solution possible by making the MemoryUser serializable or by not putting it in the session as an attribute. Mark Thomas <markt_at_apache_dot_org> suggested a note on the session at the Tomcat user-mailinglist. I've never seen notes on sessions. The MemoryUser comes from the security-constraint in my web.xml. Jul 8, 2009 5:53:52 PM org.apache.catalina.ha.session.DeltaSession writeObject SEVERE: Cannot serialize session attribute javax.security.auth.subject for session 9C533E0EB4A79ED5B206B8F5A5DB09AD java.io.NotSerializableException: org.apache.catalina.users.MemoryUser at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1156) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:326) at java.util.LinkedList.writeObject(LinkedList.java:943) at sun.reflect.GeneratedMethodAccessor216.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:945) at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1461) at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1392) at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150) at java.io.ObjectOutputStream.access$300(ObjectOutputStream.java:143) at java.io.ObjectOutputStream$PutFieldImpl.writeFields(ObjectOutputStream.java:1668) at java.io.ObjectOutputStream.writeFields(ObjectOutputStream.java:454) at javax.security.auth.Subject$SecureSet.writeObject(Subject.java:1281) at sun.reflect.GeneratedMethodAccessor215.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:945) at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1461) at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1392) at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150) at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1509) at java.io.ObjectOutputStream.defaultWriteObject(ObjectOutputStream.java:416) at java.util.Collections$SynchronizedCollection.writeObject(Collections.java:1602) at sun.reflect.GeneratedMethodAccessor214.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:945) at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1461) at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1392) at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150) at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1509) at java.io.ObjectOutputStream.defaultWriteObject(ObjectOutputStream.java:416) at javax.security.auth.Subject.writeObject(Subject.java:919) at sun.reflect.GeneratedMethodAccessor213.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:945) at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1461) at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1392) at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:326) at org.apache.catalina.ha.session.DeltaSession.writeObject(DeltaSession.java:714) at org.apache.catalina.ha.session.DeltaSession.writeObjectData(DeltaSession.java:475) at org.apache.catalina.ha.session.DeltaSession.writeObjectData(DeltaSession.java:472) at org.apache.catalina.ha.session.DeltaManager.serializeSessions(DeltaManager.java:733) at org.apache.catalina.ha.session.DeltaManager.sendSessions(DeltaManager.java:1513) at org.apache.catalina.ha.session.DeltaManager.handleGET_ALL_SESSIONS(DeltaManager.java:1479) at org.apache.catalina.ha.session.DeltaManager.messageReceived(DeltaManager.java:1310) at org.apache.catalina.ha.session.DeltaManager.messageDataReceived(DeltaManager.java:1093) at org.apache.catalina.ha.session.ClusterSessionListener.messageReceived(ClusterSessionListener.java:87) at org.apache.catalina.ha.tcp.SimpleTcpCluster.messageReceived(SimpleTcpCluster.java:901) at org.apache.catalina.ha.tcp.SimpleTcpCluster.messageReceived(SimpleTcpCluster.java:882) at org.apache.catalina.tribes.group.GroupChannel.messageReceived(GroupChannel.java:269) at org.apache.catalina.tribes.group.ChannelInterceptorBase.messageReceived(ChannelInterceptorBase.java:79) at org.apache.catalina.tribes.group.ChannelInterceptorBase.messageReceived(ChannelInterceptorBase.java:79) at org.apache.catalina.tribes.group.interceptors.TcpFailureDetector.messageReceived(TcpFailureDetector.java:110) at org.apache.catalina.tribes.group.ChannelInterceptorBase.messageReceived(ChannelInterceptorBase.java:79) at org.apache.catalina.tribes.group.ChannelCoordinator.messageReceived(ChannelCoordinator.java:241) at org.apache.catalina.tribes.transport.ReceiverBase.messageDataReceived(ReceiverBase.java:225) at org.apache.catalina.tribes.transport.nio.NioReplicationTask.drainChannel(NioReplicationTask.java:188) at org.apache.catalina.tribes.transport.nio.NioReplicationTask.run(NioReplicationTask.java:91) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) | resolved fixed | 806200c | ["java/org/apache/catalina/ha/session/DeltaSession.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-02T00:31:33Z" | "2009-07-09T09:00:00Z" |
48,296 | Bug 48296 Generics fixes | null | resolved fixed | ed40c2c | ["java/org/apache/catalina/ant/jmx/JMXAccessorTask.java", "java/org/apache/catalina/tribes/membership/Membership.java", "java/org/apache/naming/resources/DirContextURLConnection.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-12-01T23:21:41Z" | "2009-11-28T12:06:40Z" |
47,342 | Bug 47342 ReplicatedContext#start throws NullPointerException. | null | resolved fixed | 9afe6ce | ["java/org/apache/catalina/ha/context/ReplicatedContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-27T22:23:40Z" | "2009-06-10T07:46:40Z" |
48,289 | Bug 48289 ElSupport - Javadoc and generics fixes | null | resolved fixed | b8599a3 | ["java/org/apache/el/lang/ELSupport.java", "test/org/apache/el/TestELEvaluation.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-27T18:20:12Z" | "2009-11-25T20:13:20Z" |
48,288 | Bug 48288 Patch to fix generics in javax.el package helpers | null | resolved fixed | 2ac1900 | ["java/org/apache/el/lang/EvaluationContext.java", "java/org/apache/jasper/el/ELContextWrapper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-27T18:14:19Z" | "2009-11-25T20:13:20Z" |
48,287 | Bug 48287 ApplicationContextFacade - generics fixes | null | resolved fixed | ce8d1c5 | ["java/org/apache/catalina/core/ApplicationContextFacade.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-27T18:11:34Z" | "2009-11-25T20:13:20Z" |
48,285 | Bug 48285 ApplicationFilterFactory.matchDispatcher() fails to check ASYNC | catalina.core.ApplicationFilterFactory.matchDispatcher(FilterMap filterMap, DispatcherType type) fails to check for type == ASYNC The extra case ought to be added (but I don't know what it should contain, so cannot provide a patch) | resolved fixed | f0a0aec | ["java/org/apache/catalina/core/ApplicationFilterFactory.java", "java/org/apache/catalina/deploy/FilterMap.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-27T18:01:12Z" | "2009-11-25T14:40:00Z" |
48,282 | Bug 48282 Possible NPE in org.apache.tomcat.util.modeler.Registry | null | resolved fixed | 56897be | ["java/org/apache/tomcat/util/modeler/Registry.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-27T17:17:12Z" | "2009-11-25T11:53:20Z" |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.