issue_id
int64 2.03k
426k
| title
stringlengths 9
251
| body
stringlengths 1
32.8k
⌀ | status
stringclasses 6
values | after_fix_sha
stringlengths 7
7
| updated_files
stringlengths 29
34.1k
| project_name
stringclasses 6
values | repo_url
stringclasses 6
values | repo_name
stringclasses 6
values | language
stringclasses 1
value | issue_url
null | before_fix_sha
null | pull_url
null | commit_datetime
unknown | report_datetime
unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
53,654 | Bug 53654 JSP file is always recompiled for using file based TLD URL | Now, in Jasper codes, it only supports jar URL and relative URL, that may be enough for common web applications. While, it is possible that the third-party uses other protocol URL, like file: protocol based URL. So, the JSP files will be always recompiled for each access for the target page. The codes are located in Compiler.isOutDated() method. Is it possible to provide more generic handlering for the URL ? | resolved fixed | 1efc23d | ["java/org/apache/jasper/compiler/Compiler.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-15T16:01:19Z" | "2012-08-05T18:06:40Z" |
53,624 | Bug 53624 sendRedirect doesn't work after a dispatch through the AsyncContext | null | resolved fixed | e37b01e | ["java/org/apache/catalina/core/ApplicationDispatcher.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-14T22:14:39Z" | "2012-07-30T23:13:20Z" |
53,701 | Bug 53701 Javadoc fixes | null | resolved fixed | 2a3b42d | ["java/javax/servlet/ServletInputStream.java", "java/javax/servlet/ServletOutputStream.java", "java/javax/servlet/jsp/JspException.java", "java/org/apache/catalina/Executor.java", "java/org/apache/catalina/Manager.java", "java/org/apache/catalina/tribes/ErrorHandler.java", "java/org/apache/naming/SelectorContext.java", "java/org/apache/tomcat/util/http/fileupload/FileItem.java", "webapps/examples/WEB-INF/classes/compressionFilters/CompressionResponseStream.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-14T18:14:42Z" | "2012-08-12T16:46:40Z" |
53,700 | Bug 53700 InternalNioOutputBuffer unused (debug?) code | The class InternalNioOutputBuffer includes the field: int total = 0; This is currently defined at line 227, which is between the Javadoc and method body to which the Javadoc applies, i.e. private synchronized int writeToSocket. This invalidates the method Javadoc. The field is used to keep a running total of bytes written by the method; however the field is not actually referenced - the System.out.println statement is commented out. The field and associated code shcould probably be deleted. If the field is to be kept, it should be private, and it should probably be changed to long, and of course should be moved so it does not invalidate the method Javadoc. | resolved fixed | a2ca744 | ["java/org/apache/coyote/http11/InternalNioOutputBuffer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-14T18:00:44Z" | "2012-08-12T14:00:00Z" |
53,574 | Bug 53574 metadata-complete="true" and servlet defined as jsp not working | We have a servlet defined as <servlet> <servlet-name>VersionInfoServlet</servlet-name> <jsp-file>/WEB-INF/svnrevision.jsp</jsp-file> </servlet> and mapped as <servlet-mapping> <servlet-name>VersionInfoServlet</servlet-name> <url-pattern>/svnrevision</url-pattern> </servlet-mapping> It worked fine. Then we changed metadata-complete to "true", and from now on we receive INFO: Marking servlet VersionInfoServlet as unavailable lip 20, 2012 11:05:36 AM org.apache.catalina.core.StandardWrapperValve invoke SEVERE: Allocate exception for servlet VersionInfoServlet javax.servlet.ServletException: No servlet class has been specified for servlet VersionInfoServlet at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1130) at org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:857) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:136) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) at org.apache.coyote.ajp.AjpNioProcessor.process(AjpNioProcessor.java:184) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:585) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) | resolved fixed | f9b0182 | ["java/org/apache/catalina/startup/ContextConfig.java", "test/org/apache/catalina/startup/TestContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-11T18:54:53Z" | "2012-07-20T13:13:20Z" |
53,545 | Bug 53545 jsp:forward action to static resources causes IllegalStateException when inside classic custom tag | null | resolved fixed | 5a6b27b | ["java/org/apache/jasper/runtime/PageContextImpl.java", "test/org/apache/jasper/runtime/TestPageContextImpl.java", "test/org/apache/tomcat/unittest/tags/Bug53545.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-11T09:43:19Z" | "2012-07-13T11:46:40Z" |
53,541 | Bug 53541 Bug in virtual webapp feature. Custom tags badly supported. Error is "org.apache.jasper.JasperException: The absolute uri: http://java.sun.com/jsp/jstl/core cannot be resolved in either web.xml or the jar files deployed with this application | null | resolved fixed | 432bd0f | ["java/org/apache/naming/resources/VirtualDirContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-10T19:41:27Z" | "2012-07-12T21:53:20Z" |
53,481 | Bug 53481 Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonorCipherOrder | null | resolved fixed | 82e5dce | ["java/org/apache/coyote/http11/Http11AprProtocol.java", "java/org/apache/tomcat/util/net/AprEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-09T16:17:01Z" | "2012-06-28T19:00:00Z" |
53,641 | Bug 53641 Wrong websocket's subprotocol implementation | According to RFC6455 Section 4.3. the handling of subprotocol requests is not correct. It must be checked for "Sec-WebSocket-Protocol" instead of "Sec-WebSocket-Protocol-Client" in WebSocketServlet class. | resolved fixed | af45441 | ["java/org/apache/catalina/websocket/WebSocketServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-07T21:51:30Z" | "2012-08-02T17:53:20Z" |
53,607 | Bug 53607 No message set for PING: TcpPingInterceptor fail with NullPointerException in ChannelData.getDataPackageLength() | I added data.setMessage(new XByteBuffer(TCP_PING_DATA, false)); to TcpPingInterceptor send ping message function by: protected void sendPingMessage(Member[] members) { if ( members == null || members.length == 0 ) return; ChannelData data = new ChannelData(true);//generates a unique Id data.setAddress(getLocalMember(false)); data.setTimestamp(System.currentTimeMillis()); data.setOptions(getOptionFlag()); data.setMessage(new XByteBuffer(TCP_PING_DATA, false)); try { super.sendMessage(members, data, null); }catch (ChannelException x) { log.warn("Unable to send TCP ping.",x); } } error also for Tomcat 6 regards fred | resolved fixed | 57b56f2 | ["java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-31T08:21:40Z" | "2012-07-26T22:00:00Z" |
53,606 | Bug 53606 NullPointerException in TcpPingInterceptor | start(int) method initializes failureDetector (resp. staticMembers) only if TcpFailureDetector (resp. StaticMembershipInterceptor) was found in channel interceptors stack. Without TcpFailureDetector (resp. StaticMembershipInterceptor), futur calls to sendPing() will fail because failureDetector (resp. staticMembers) wasn't initialized at least to new WeakReference<StaticMembershipInterceptor>(null). Fix: v1) initializes weak references containers: Replace: WeakReference<TcpFailureDetector> failureDetector = null; WeakReference<StaticMembershipInterceptor> staticMembers = null; for: WeakReference<TcpFailureDetector> failureDetector = new WeakReference<TcpFailureDetector>(); WeakReference<StaticMembershipInterceptor> staticMembers = new WeakReference<StaticMembershipInterceptor>(); v2) checks field before dereferencing it: sendPing becomes: protected void sendPing() { if (failureDetector!=null && failureDetector.get()!=null) { //we have a reference to the failure detector //piggy back on that dude failureDetector.get().checkMembers(true); }else { if (staticOnly && staticMembers!=null && staticMembers.get()!=null) { sendPingMessage(staticMembers.get().getMembers()); } else { sendPingMessage(getMembers()); } } } affect also tomcat 6 regards fred arnoud | resolved fixed | eb9f94e | ["java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-29T21:47:24Z" | "2012-07-26T19:13:20Z" |
53,535 | Bug 53535 Out of memory while performing ContextConfig.webConfig | null | resolved fixed | 7db08d3 | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-29T21:21:08Z" | "2012-07-11T15:20:00Z" |
53,469 | Bug 53469 possible bug in Response.normalize(CharChunk cc) | The Response.normalize(CharChunk cc) introduced in 7.0.28 introduced a bug. See Bug ID 53062 The URL that is being encoded is: ../../resources/org.apache.wicket.markup.html.WicketEventReference/wicket-event.js?w:lm=1340711670 which causes a IllegalArgumentException in this method java.lang.IllegalArgumentException at org.apache.catalina.connector.Response.normalize(Response.java:1799) at org.apache.catalina.connector.Response.toAbsolute(Response.java:1732) at org.apache.catalina.connector.Response.encodeURL(Response.java:1242) at org.apache.catalina.connector.ResponseFacade.encodeURL(ResponseFacade.java:406) at org.apache.wicket.protocol.http.WebResponse.encodeURL(WebResponse.java:149) at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.encode(WebRequestCodingStrategy.java:387) Running the same application in tomcat 7.0.27 and 6.0.18 works without issue | resolved fixed | 9a80d06 | ["java/org/apache/catalina/connector/Response.java", "test/org/apache/catalina/connector/TestResponse.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-29T20:29:20Z" | "2012-06-26T17:00:00Z" |
53,529 | Bug 53529 Call interrupt() after InterruptedException instead interrupted() | In class: org\apache\catalina\tribes\group\GroupChannel.java line 692 org\apache\catalina\tribes\group\interceptors\NonBlockingCoordinator.java line 228 org\apache\catalina\tribes\group\interceptors\TcpPingInterceptor.java line 173 org\apache\catalina\tribes\membership\McastServiceImpl.java line 542 org\apache\juli\AsyncFileHandler.java line 124 line 146 org\apache\tomcat\util\net\AprEndpoint.java line 640 org\apache\tomcat\util\net\NioBlockingSelector.java line 112 line 177 org\apache\tomcat\util\threads\ThreadPoolExecutor.java line 187 Affect 7.0.29 (and previous release) but affect also Tomcat 6. | resolved fixed | 3ea8285 | ["java/org/apache/catalina/tribes/group/GroupChannel.java", "java/org/apache/catalina/tribes/group/interceptors/NonBlockingCoordinator.java", "java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java", "java/org/apache/catalina/tribes/membership/McastServiceImpl.java", "java/org/apache/juli/AsyncFileHandler.java", "java/org/apache/tomcat/util/net/AprEndpoint.java", "java/org/apache/tomcat/util/net/NioBlockingSelector.java", "java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-27T23:12:55Z" | "2012-07-10T14:20:00Z" |
53,526 | Bug 53526 .ConnectionPool.terminateTransaction unsafe == check of Boolean | The method ConnectionPool.terminateTransaction(PooledConnection con) uses == to check the value of a Boolean, viz: if (con.getPoolProperties().getDefaultAutoCommit()==Boolean.FALSE) { This is not 100% safe - if the user sets the property as follows: String value; // e.g. derived from property file ... setDefaultAutoCommit(new Boolean(value)); then the condition will never be true, even if value="false". Although it is better to use Boolean.valueOf(value), which would not have the same problem, the code ought to work regardless. | resolved fixed | eac6366 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-10T14:47:07Z" | "2012-07-10T00:26:40Z" |
53,523 | Bug 53523 rollbackOnReturn/commitOnReturn does not work without defaultAutoCommit=false | Hi, The properties rollbackOnReturn and commitOnReturn, which are critical for cleaning up connections after they are used and returned to the pool, does not work when the defaultAutoCommit property is not set or when it is set to true. The code segment at ConnectionPool class has this, protected boolean terminateTransaction(PooledConnection con) { try { if (con.getPoolProperties().getDefaultAutoCommit()==Boolean.FALSE) { .... The full logic is wrapped in that first if statement, and as I see, that is not correct. Because, the actual default auto commit value when we don't set this property can either be autoCommit true or false, which depends on the database driver. And also, even when we have a default setting provided, the user has the freedom to change the autoCommit flag to either true or false at the beginning when they get the connection from the pool. So we should not be reading the pool properties in this place, but just check the current live connection's autoCommit value and act accordingly. So I suppose the fix should be to simply remove the outer if statement. Cheers, Anjana. | resolved wontfix | f54bb45 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-09T19:39:51Z" | "2012-07-09T16:06:40Z" |
53,513 | Bug 53513 Race condition / out of order operation in session replication at node startup | My configuration: 2 nodes running Tomcat 7.0.26 Using a custom session manager, which extends the DeltaManager My startInternal() method first calls super.startInternal(), then performs a few additional initializations. I reviewed the code of DeltaManager.startInternal(), and it calls getAllClusterSessions() which in turn calls waitForSendAllSessions(), which requires either getStateTransfered() to return true, or a timeout. So by this, I should be able to trust that as the second node starts, the initial sync up of all session data from the first node has completed prior to the startInternal() method exiting (and thus prior to my initializations). This is, however, not the case! I can confirm this by repeatedly logging the value of findSessions().length during my inializations, and see that number going up! There appears to be a race condition between the processing of the message containing the actual session data & the "transfer complete" message. After tracing this through a little further, I see the stateTransfered is set to true in the handleALL_SESSION_TRANSFERCOMPLETE() callback method. And that callback is being called PRIOR to the session data itself even being received! Here is the debug logging output (slightly scrubbed) which shows this out of order messaging: Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager getAllClusterSessions INFO: Manager [wwwtest#], requesting session state from org.apache.catalina.tribes.membership.MemberImpl[...]. This operation will timeout if no session state has been received within 60 seconds. Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager messageReceived FINE: Manager [wwwtest#]: Received SessionMessage of type=(SESSION-STATE-TRANSFERED) from [org.apache.catalina.tribes.membership.MemberImpl[...] Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager handleALL_SESSION_TRANSFERCOMPLETE FINE: Manager [wwwtest#] received from node [[B@6789b939:4,000] session state transfered. Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager messageReceived FINE: Manager [wwwtest#]: Received SessionMessage of type=(ALL-SESSION-DATA) from [org.apache.catalina.tribes.membership.MemberImpl[...] Jul 5, 2012 4:20:41 PM org.apache.catalina.ha.session.DeltaManager handleALL_SESSION_DATA FINE: Manager [wwwtest#]: received session state data | resolved fixed | 4c03dff | ["java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-09T10:43:30Z" | "2012-07-06T02:00:00Z" |
53,498 | Bug 53498 Atomicity violation bugs because of misusing concurrent collections | null | resolved fixed | 4aef8e3 | ["java/org/apache/catalina/core/ApplicationContext.java", "java/org/apache/catalina/ha/context/ReplicatedContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-04T21:03:46Z" | "2012-07-03T01:46:40Z" |
45,995 | Bug 45995 RFE - MIME type extension not case sensitive | Hi, On the dev-tomcat list I described in the topic "Byte Serving and PDFs with the DefaultServlet" an issue that I had with Tomcat to serve PDFs. Analysing the answers I could find that the matter was related to the case of the file extension. Today Tomcat is case sensitive for MIME type extensions. So the solution for me was enter two MIME specifications on the web.xml file. One is for "pdf" and another one for "PDF". This way I would like to ask for and request for enhancement to make Tomcat be able to, due a setup on configuration file, consider or not case for MIME type extensions. Regards, Vitor | resolved fixed | f8e173b | ["java/org/apache/catalina/core/StandardContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-07-02T09:41:23Z" | "2008-10-13T09:26:40Z" |
52,135 | Bug 52135 Global error page is not handled | The new Servlet 3.0 global error page <error-page> <location>/error.jsp</location> </error-page> is not handled in Tomcat 7. On Glassfish 3 for example, it works fine. | resolved fixed | 6213b38 | ["java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/core/StandardHostValve.java", "java/org/apache/catalina/deploy/ErrorPage.java", "test/org/apache/catalina/core/TestStandardHostValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-30T13:06:27Z" | "2011-11-04T18:06:40Z" |
53,467 | Bug 53467 7.0.28 will no longer accept our jsp filenames | null | resolved fixed | 4de4325 | ["java/org/apache/catalina/core/ApplicationContext.java", "test/org/apache/catalina/core/TestApplicationContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-27T18:50:50Z" | "2012-06-26T03:06:40Z" |
53,416 | Bug 53416 Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException | Deploy two different web applications onto Tomcat. Each web application has a resource that: * uses the Use Tomcat JDBC Connection Pool * has an identical name to the other one <Resource name="jdbc/collision" factory="org.apache.tomcat.jdbc.pool.DataSourceFactory" ... /> When starting the server you get a non fatal error in the logs InstanceAlreadyExistsException. Both applications appear to still work OK ERROR org.apache.tomcat.jdbc.pool.DataSource - Unable to register JDBC pool with JMX javax.management.InstanceAlreadyExistsException: tomcat.jdbc:name="jdbc/soscvuk",context=/,type=ConnectionPool,host=localhost,class=org.apache.tomcat.jdbc.pool. DataSource at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:453) ~[na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.internal_addObject(DefaultMBeanServerInterceptor.java:1484) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:963) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:917) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:312) [na:1.6.0_32] at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:482) [na:1.6.0_32] at org.apache.tomcat.jdbc.pool.DataSource.registerJmx(DataSource.java:135) [tomcat-jdbc.jar:na] at org.apache.tomcat.jdbc.pool.DataSource.preRegister(DataSource.java:102) [tomcat-jdbc.jar:na] at org.apache.tomcat.util.modeler.BaseModelMBean.preRegister(BaseModelMBean.java:1132) [tomcat-coyote.jar:7.0.27] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.preRegisterInvoke(DefaultMBeanServerInterceptor.java:1010) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:938) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:917) [na:1.6.0_32] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:312) [na:1.6.0_32] at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:482) [na:1.6.0_32] at org.apache.tomcat.util.modeler.Registry.registerComponent(Registry.java:742) [tomcat-coyote.jar:7.0.27] at org.apache.catalina.core.NamingContextListener.addResource(NamingContextListener.java:1062) [catalina.jar:7.0.27] at org.apache.catalina.core.NamingContextListener.createNamingContext(NamingContextListener.java:671) [catalina.jar:7.0.27] at org.apache.catalina.core.NamingContextListener.lifecycleEvent(NamingContextListener.java:270) [catalina.jar:7.0.27] at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) [catalina.jar:7.0.27] at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) [catalina.jar:7.0.27] at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5161) [catalina.jar:7.0.27] at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) [catalina.jar:7.0.27] at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:895) [catalina.jar:7.0.27] at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:871) [catalina.jar:7.0.27] at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:615) [catalina.jar:7.0.27] at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:649) [catalina.jar:7.0.27] at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1585) [catalina.jar:7.0.27] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) [na:1.6.0_32] at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) [na:1.6.0_32] at java.util.concurrent.FutureTask.run(FutureTask.java:138) [na:1.6.0_32] at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [na:1.6.0_32] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [na:1.6.0_32] at java.lang.Thread.run(Thread.java:662) [na:1.6.0_32] | resolved fixed | ff9a272 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSource.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-27T17:36:05Z" | "2012-06-14T18:53:20Z" |
53,465 | Bug 53465 mapped-name is read when in @Resource, but not when in web.xml | null | resolved fixed | 7ecd402 | ["java/org/apache/catalina/startup/WebRuleSet.java", "test/org/apache/naming/resources/TestNamingContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-26T22:02:04Z" | "2012-06-26T00:20:00Z" |
53,460 | Bug 53460 Use error handling when TooManyActiveSessionsException happens in JSP | null | resolved fixed | 294c52b | ["java/org/apache/jasper/compiler/Generator.java", "java/org/apache/jasper/runtime/JspFactoryImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-26T19:57:07Z" | "2012-06-23T16:46:40Z" |
53,445 | Bug 53445 Support consistent Jmx object naming strategy across managed resources | Tomcat JDBC Pool Versions tested: 7.0.27 & 7.0.28 More of an inquiry. Let me preface by saying we have recently adopted this pool and are very pleased so far. Currently, Jmx managed resources like ConnectionPool and SlowQueryReportJmx are registered under the same domain (i.e. tomcat.jdbc). Some users may want to employ an alternate object naming strategy. With DataSource#createObjectName it is relatively easy to change the ConnectionPool ObjectName (i.e. subclass). However, with SlowQueryReportJmx, due to a static getObjectName method, it requires overriding additional methods which is less desirable. It appears that ConnectionPool has a constant POOL_JMX_TYPE_PREFIX. SlowQueryReportJmx appears to use this but DataSource does not? Is there any reason that the SlowQueryReportJmx#getObjectName method is static? What about registering an object naming strategy with the pool that the various components would use, facilitating consistency? This would mitigate the need to override just to alter the ObjectName. Reference: Spring MBean exporters and their ObjectNamingStrategy interface. Thanks. | resolved fixed | 4e010fc | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSource.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java", "modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestSlowQueryReport.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-26T19:08:27Z" | "2012-06-20T22:06:40Z" |
53,430 | Bug 53430 JVM crash at startup if TC-Native version is too old | null | resolved fixed | 553259c | ["java/org/apache/catalina/connector/Connector.java", "java/org/apache/coyote/AbstractProtocol.java", "java/org/apache/coyote/ProtocolHandler.java", "java/org/apache/coyote/ajp/AjpAprProtocol.java", "java/org/apache/coyote/http11/Http11AprProtocol.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-25T12:53:27Z" | "2012-06-17T13:33:20Z" |
53,421 | Bug 53421 BeanELResolver's inner class BeanProperty throws incorrect message while PropertyNotFound | BeanELResolver's inner class BeanProperty(line: 264) has two methods (write, read) that will throw PropertyNotFoundException. And there current implementation are wrong: throw new PropertyNotFoundException(message(ctx, "propertyNotWritable", new Object[] { type.getName(), descriptor.getName() })); it should use owner.getName() instead of type.getName() because the assembled message will be: Property '[descriptor.getName()]' not readable on type [type.getName()] Here the descriptor.getName() means the property name, type.getName() means the property type's name and the owner.getName() means the property owner - bean's type name. Of course we developer would prefer to receive a message that tells us which bean type doesn't contain such property because this is a PropertyNotFoundException. | resolved fixed | 8a13b39 | ["java/javax/el/BeanELResolver.java", "test/javax/el/TestBeanELResolver.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-23T13:17:06Z" | "2012-06-15T17:06:40Z" |
53,450 | Bug 53450 Deployment of an application with 'ROOT' context hangs forever | Hi, The scenario is the following: - I have running Tomcat 7.0.28 - I deploy an application with 'ROOT' context - The deployment hangs forever. When taking a tread dump, the following is suspicious: "localhost-startStop-2" daemon prio=6 tid=0x0000000006607800 nid=0x2560 waiting on condition [0x0000000009ebf000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00000007d80f0108> (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:158) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:811) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:842) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1178) at java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(ReentrantReadWriteLock.java:807) at org.apache.catalina.core.ContainerBase.removeContainerListener(ContainerBase.java:1071) at org.apache.catalina.core.StandardEngine$AccessLogListener.uninstall(StandardEngine.java:463) at org.apache.catalina.core.StandardEngine$AccessLogListener.containerEvent(StandardEngine.java:505) at org.apache.catalina.core.ContainerBase.fireContainerEvent(ContainerBase.java:1431) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:907) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:875) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:618) at org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1100) at org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1618) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) As you can see - A read lock is acquired at org.apache.catalina.core.ContainerBase.fireContainerEvent(ContainerBase.java:1425) - Then every listener is invoked to process the container event - Then AccessLogListener is invoked org.apache.catalina.core.StandardEngine$AccessLogListener.uninstall(StandardEngine.java:463) - The latter causes a call for a write lock org.apache.catalina.core.ContainerBase.removeContainerListener(ContainerBase.java:1071) - Unfortunately in the ReentrantReadWriteLock it is stated that upgrade from read to write lock is not possible "Reentrancy also allows downgrading from the write lock to a read lock, by acquiring the write lock, then the read lock and then releasing the write lock. However, upgrading from a read lock to the write lock is not possible." Regards Violeta Georgieva | resolved fixed | 91a13d2 | ["java/org/apache/catalina/core/ContainerBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-21T19:55:06Z" | "2012-06-21T23:06:40Z" |
53,406 | Bug 53406 Stack overflow in connector | found against trunk on Jun 18, 2012 SEVERE: java.lang.StackOverflowError at org.apache.catalina.core.StandardContextValve.event(StandardContextValve.java:128) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:204) at org.apache.catalina.core.StandardHostValve.event(StandardHostValve.java:223) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:204) at org.apache.catalina.valves.ValveBase.event(ValveBase.java:204) at org.apache.catalina.core.StandardEngineValve.event(StandardEngineValve.java:110) at org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:209) at org.apache.coyote.http11.Http11NioProcessor.event(Http11NioProcessor.java:124) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:569) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653) at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:730) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:1008) at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:999) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:277) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:596) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) | resolved fixed | ce24a10 | ["java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/coyote/http11/Http11NioProcessor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-13T15:46:30Z" | "2012-06-13T06:46:40Z" |
52,954 | Bug 52954 Allowing for broken android HTTP DIGEST support | null | resolved fixed | bf41254 | ["java/org/apache/catalina/authenticator/DigestAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-12T13:23:53Z" | "2012-03-21T11:40:00Z" |
53,266 | Bug 53266 ServletContainerInitializer will crash catalina if dependcy is not present. | When using a ServletContainerInitializer with a HandlesTypes annotation if any of the classes specified in the HandlesTypes annotation are not available due to a missing jar file catalina will crash with a "java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy". Caused by: java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy at sun.reflect.annotation.AnnotationParser.parseClassArray(AnnotationParser.java:653) at sun.reflect.annotation.AnnotationParser.parseArray(AnnotationParser.java:460) at sun.reflect.annotation.AnnotationParser.parseMemberValue(AnnotationParser.java:286) at sun.reflect.annotation.AnnotationParser.parseAnnotation(AnnotationParser.java:222) at sun.reflect.annotation.AnnotationParser.parseAnnotations2(AnnotationParser.java:69) at sun.reflect.annotation.AnnotationParser.parseAnnotations(AnnotationParser.java:52) at java.lang.Class.initAnnotationsIfNecessary(Class.java:3070) at java.lang.Class.getAnnotation(Class.java:3029) at org.apache.catalina.startup.ContextConfig.processServletContainerInitializers(ContextConfig.java:1546) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1222) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:855) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:345) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5161) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) ... 7 more Line where exception is thrown: "HandlesTypes ht = sci.getClass().getAnnotation(HandlesTypes.class);" | resolved fixed | 37e8c59 | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-11T20:57:26Z" | "2012-05-20T18:53:20Z" |
53,398 | Bug 53398 Incorrect tag on XML response when calling 'manager/status?XML=true' | null | resolved fixed | 2bf1556 | ["java/org/apache/catalina/manager/StatusTransformer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-11T20:09:20Z" | "2012-06-11T21:26:40Z" |
52,955 | Bug 52955 Add a ThreadFactory implementation to the ExecutorService used to deploy applications | null | resolved fixed | d73c07a | ["java/org/apache/catalina/core/ContainerBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-09T13:11:57Z" | "2012-03-21T11:40:00Z" |
53,374 | Bug 53374 DataSourceFactory does not support commitOnReturn property | DataSourceFactory does not support commitOnReturn property. DataSourceFactory.ALL_PROPERTIES and DataSourceFactory.parsePoolProperties() omit commitOnReturn property. | resolved fixed | 0290e57 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-08T13:08:14Z" | "2012-06-07T00:46:40Z" |
53,373 | Bug 53373 Allow whitespace around delimiters in <Context> aliases for readability | null | resolved fixed | cf703d2 | ["java/org/apache/naming/resources/BaseDirContext.java", "test/org/apache/naming/resources/TestNamingContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-06T20:05:05Z" | "2012-06-07T00:46:40Z" |
53,367 | Bug 53367 Database failure may cause pool to hang | during the con.connect(); call in the method protected PooledConnection borrowConnection(long now, PooledConnection con, String username, String password) in ConnectionPool.java There is no counting down the size of the pool. This means, if a connection failure happens here, the pool size remains the same. This means that 'size' will show the pool as full, but in reality the pool is empty | resolved fixed | 1412935 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-06T01:02:41Z" | "2012-06-06T05:20:00Z" |
53,032 | Bug 53032 Ant Jasper task fails to run when using XML namespaces; no output; no errors | null | resolved fixed | 957d33b | ["java/org/apache/jasper/JspC.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-05T22:56:40Z" | "2012-04-04T00:40:00Z" |
53,230 | Bug 53230 Allow custom error mapping when Manager's maxActiveSessions is exceeded | null | resolved fixed | ea77dfb | ["java/org/apache/catalina/session/ManagerBase.java", "java/org/apache/catalina/session/TooManyActiveSessionsException.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-05T21:46:21Z" | "2012-05-14T21:13:20Z" |
53,354 | Bug 53354 <filter-mapping> doesn't find the @WebFilter(filterName) | As it's not possible to specify the invocation order in a @WebFilter, users are forced to explicitly specify <filter-mapping> in web.xml. This works in combination with a @WebFilter(filterName) in Glassfish and JBoss AS as follows: @WebFilter(filterName="filter1") public class Filter1 implements Filter {} @WebFilter(filterName="filter2") public class Filter2 implements Filter {} with <filter-mapping> <filter-name>filter1</filter-name> <url-pattern>/url1/*</url-pattern> </filter-mapping> <filter-mapping> <filter-name>filter2</filter-name> <url-pattern>/url2/*</url-pattern> </filter-mapping> However it fails in Tomcat 7.0.27 with the following confusing exception (the <url-pattern> *is* been set) Caused by: java.lang.IllegalArgumentException: Filter mapping must specify either a <url-pattern> or a <servlet-name> at org.apache.catalina.core.StandardContext.validateFilterMap(StandardContext.java:3009) at org.apache.catalina.core.StandardContext.addFilterMap(StandardContext.java:2968) at org.apache.catalina.deploy.WebXml.configureContext(WebXml.java:1207) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1294) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:855) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:345) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5161) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) ... 7 more | resolved fixed | b82c47e | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-03T21:16:25Z" | "2012-06-04T00:33:20Z" |
53,339 | Bug 53339 ClassNotFoundException when using WebSocketServlet | I'm trying to do a JNDI lookup inside the "onOpen" method of my StreamInbound class, but it gives me the exception below. The code works if I move my JNP JARs to the server lib instead of the webapp lib. The code also works fine from anywhere else, like in the "doGet" method. ERROR http-bio-8080-exec-3 Test javax.naming.NoInitialContextException: Cannot instantiate class: org.jnp.interfaces.NamingContextFactory [Root exception is java.lang.ClassNotFoundException: org.jnp.interfaces.NamingContextFactory] at javax.naming.spi.NamingManager.getInitialContext(NamingManager.java:657) at javax.naming.InitialContext.getDefaultInitCtx(InitialContext.java:288) at javax.naming.InitialContext.init(InitialContext.java:223) at javax.naming.InitialContext.<init>(InitialContext.java:197) at Test$TestStreamInbound.onOpen(Test.java:103) at org.apache.catalina.websocket.StreamInbound.onUpgradeComplete(StreamInbound.java:180) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:579) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:307) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) | resolved fixed | d713894 | ["java/org/apache/catalina/websocket/StreamInbound.java", "test/org/apache/catalina/websocket/TestWebSocket.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-03T18:47:25Z" | "2012-05-31T21:33:20Z" |
53,008 | Bug 53008 New test case for Basic Authenticator | null | resolved fixed | a1c6165 | ["test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-03T16:44:49Z" | "2012-03-30T15:06:40Z" |
53,337 | Bug 53337 IllegalStateException when trying to render a JSP after startAsync | null | resolved fixed | c6b691d | ["java/org/apache/catalina/core/ApplicationDispatcher.java", "test/org/apache/catalina/core/TestAsyncContextImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-03T15:50:50Z" | "2012-05-31T21:33:20Z" |
53,301 | Bug 53301 Servlet init method called twice with embedded Tomcat | When using embedded Tomcat, the servlet init method is called twice by the container. This has been seen with an Apache DirectMemory unit test. I have checked with a normal Tomcat launched by the Tomcat Maven plugin (mvn tomcat7:run) and in this case, the init method is correctly called once. | resolved fixed | 6ce3128 | ["java/org/apache/catalina/startup/Tomcat.java", "test/org/apache/catalina/startup/TestTomcat.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-01T10:16:50Z" | "2012-05-27T00:53:20Z" |
53,285 | Bug 53285 Web app configuration fails when security-role-ref does not contain role-link | null | resolved fixed | ad3b503 | ["java/org/apache/catalina/deploy/ServletDef.java", "java/org/apache/catalina/startup/WebRuleSet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-01T09:40:59Z" | "2012-05-24T09:00:00Z" |
53,342 | Bug 53342 If starting immediately after Tomcat stop fail, BindException will throw. | e.g. When Context#stop throw LifecycleException, the main thread stops, but startStopThreads of Host/Engine will remain for a while. Because, startStopThreads is not a demon thread. As a result, even if a main thread stops, Acceptor Threads of 8080/8009 is not stopped. keepAliveTime for 10 seconds is set up now. === startStopExecutor = new ThreadPoolExecutor( getStartStopThreadsInternal(), getStartStopThreadsInternal(), 10, TimeUnit.SECONDS, startStopQueue); === Therefore, in order to avoid BindException, the waiting for 10 seconds is required. I think that I need to make startStopThreads into a demon thread. Best Regards. | resolved fixed | 84342f5 | ["java/org/apache/catalina/core/ContainerBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-06-01T09:38:31Z" | "2012-06-01T14:13:20Z" |
53,225 | Bug 53225 IllegalStateException "zip file closed" with resource from webfragment jar if JreMemoryLeakPreventionListener is removed | null | resolved fixed | e90cd4b | ["java/org/apache/tomcat/util/scan/FileUrlJar.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-31T09:58:56Z" | "2012-05-13T00:46:40Z" |
53,169 | Bug 53169 [patch] don't do chunking with Connection: close | null | resolved fixed | 280beac | ["java/org/apache/coyote/http11/AbstractHttp11Processor.java", "test/org/apache/coyote/http11/TestAbstractHttp11Processor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-30T14:11:49Z" | "2012-05-01T13:46:40Z" |
53,322 | Bug 53322 Odd decapitalization when inferring JavaBean property from setter name for an injection target | null | resolved fixed | 13100e9 | ["java/org/apache/catalina/core/DefaultInstanceManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-30T01:30:58Z" | "2012-05-30T06:40:00Z" |
53,180 | Bug 53180 DefaultInstanceManager#populateAnnotationsCache - incomplete check is used when validating for a setter method | null | resolved fixed | 39c8e18 | ["java/org/apache/catalina/core/DefaultInstanceManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-29T13:33:40Z" | "2012-05-02T23:06:40Z" |
53,081 | Bug 53081 WebappClassLoader causes java.lang.OutOfMemoryError in findResourceInternal() | null | resolved fixed | 5d12129 | ["java/org/apache/catalina/loader/WebappClassLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-29T13:06:24Z" | "2012-04-14T02:20:00Z" |
53,090 | Bug 53090 Servlet superclass injection targets are ignored | null | resolved fixed | de1f763 | ["java/org/apache/catalina/core/DefaultInstanceManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-28T21:16:29Z" | "2012-04-17T10:53:20Z" |
53,074 | Bug 53074 [websocket] java.net.SocketTimeoutException: Read timed caused by server.xml' connectTimeout | The default connectTimeout value is set to 20000 and cause issue with WebSocket connection java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:129) at org.apache.coyote.http11.upgrade.UpgradeBioProcessor.read(UpgradeBioProcessor.java:75) at org.apache.catalina.websocket.WsFrame.nextFrame(WsFrame.java:213) at org.apache.catalina.websocket.WsInputStream.nextFrame(WsInputStream.java:68) at org.apache.catalina.websocket.StreamInbound.onData(StreamInbound.java:143) at org.apache.coyote.http11.upgrade.UpgradeProcessor.upgradeDispatch(UpgradeProcessor.java:83) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:563) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:307) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) Increasing the value delay the issue (but the timeout should not occurs) | resolved fixed | 098a647 | ["java/org/apache/catalina/websocket/StreamInbound.java", "java/org/apache/coyote/ajp/AjpAprProtocol.java", "java/org/apache/coyote/http11/Http11AprProtocol.java", "java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java", "java/org/apache/coyote/http11/upgrade/UpgradeBioProcessor.java", "java/org/apache/coyote/http11/upgrade/UpgradeInbound.java", "java/org/apache/coyote/http11/upgrade/UpgradeNioProcessor.java", "java/org/apache/tomcat/util/net/AprEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-25T16:39:46Z" | "2012-04-13T18:00:00Z" |
53,254 | Bug 53254 Support for purging connection pool | It is a common function of a connection pool to support "purging" the pool of all current connections and getting all fresh connections. Oracle UCP and Websphere pools are two such examples. It would be great if this pool supported such an operation as well. It would be useful if the operation were exposed through JMX too. | resolved fixed | f170929 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPoolMBean.java", "modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/PoolPurgeTest.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-18T16:28:33Z" | "2012-05-17T21:26:40Z" |
53,067 | Bug 53067 WebSocket implementation issue with wrapped requests | null | resolved fixed | 111dc8e | ["java/org/apache/catalina/websocket/WebSocketServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-12T20:51:24Z" | "2012-04-12T22:33:20Z" |
53,063 | Bug 53063 Inconsistency in documentation regarding Connector's maxConnections property | null | resolved fixed | be365e5 | ["java/org/apache/tomcat/util/net/AbstractEndpoint.java", "java/org/apache/tomcat/util/net/JIoEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-05-10T21:07:22Z" | "2012-04-11T16:00:00Z" |
53,087 | Bug 53087 BackupManager does not replicate session access time. | null | resolved fixed | 48b9153 | ["java/org/apache/catalina/ha/session/DeltaSession.java", "java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java", "java/org/apache/catalina/tribes/tipis/ReplicatedMapEntry.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-04-17T06:06:51Z" | "2012-04-17T10:53:20Z" |
53,056 | Bug 53056 Add APR version number to tcnative version INFO log message | When tcnative starts, it emits information like this to catalina.out: pr 10, 2012 4:54:55 PM org.apache.catalina.core.AprLifecycleListener init INFO: Loaded APR based Apache Tomcat Native library 1.1.23. Apr 10, 2012 4:54:55 PM org.apache.catalina.core.AprLifecycleListener init INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters [false], random [true]. It would be nice if the APR version in use could also be displayed as well as the tcnative version. Maybe the OpenSSL version, too. | resolved fixed | df88ecb | ["java/org/apache/catalina/core/AprLifecycleListener.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-04-10T21:16:01Z" | "2012-04-11T02:06:40Z" |
50,864 | Bug 50864 Reconfigure pool on the fly using JMX | null | resolved fixed | 518662f | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-04-10T16:29:42Z" | "2011-03-03T16:33:20Z" |
52,998 | Bug 52998 Performance issue with ExpressionFactory.newInstance() | null | resolved fixed | 7da5fa9 | ["java/javax/el/ExpressionFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-30T20:10:48Z" | "2012-03-29T00:13:20Z" |
53,001 | Bug 53001 Behaviour of ResourceBundleELResolver | null | resolved fixed | 1aced29 | ["test/javax/el/TestResourceBundleELResolver.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-30T16:31:10Z" | "2012-03-29T14:06:40Z" |
52,974 | Bug 52974 NameNotFoundException is thrown when field/method is annotated with @Resource annotation | null | resolved fixed | 67a926c | ["java/org/apache/catalina/startup/WebAnnotationSet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-27T19:20:10Z" | "2012-03-22T23:46:40Z" |
52,833 | Bug 52833 NPE with 7.0.26 | Upgrading the maven plugin 7.0.26, the goal which runs tomcat with a conf dir (not the embed version) generate the following NPE Log: at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:141) at org.apache.catalina.startup.Catalina.start(Catalina.java:645) at org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:679) at org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:365) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:544) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:197) at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) | resolved fixed | 6a8e480 | ["java/org/apache/catalina/core/StandardServer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-27T18:28:35Z" | "2012-03-06T05:00:00Z" |
52,066 | Bug 52066 ConnectionPool.borrowConnection swallows interrupt state. | In this code snippet starting on line 6.15 of ConnectionPool.java version 7.0.22 try { //retrieve an existing connection con = idle.poll(timetowait, TimeUnit.MILLISECONDS); } catch (InterruptedException ex) { Thread.interrupted();//clear the flag, and bail out SQLException sx = new SQLException("Pool wait interrupted."); sx.initCause(ex); throw sx; } finally { waitcount.decrementAndGet(); } The line marked '//clear the flag, and bail out' is wrong, because after that there is no way for calling code to find out that the thread has been interrupted. The correct behavior should be Thread.currentThread( ).interrupt( ); Here is the excerpt from the Biran Goetz's "Java Concurrency in Practice" chapter 5.4. <!START QUOTATION> For library code there are basically two choices: -- Propagate the InterruptedException. This is often the most sensible policy if you can get away with it -- just propagate the InterruptedException to your caller. This could involve not catching InterruptedException, or catching it and throwing it again after performing some brief activity-specific cleanup. -- Restore the interrupt. Sometimes you cannot throw InterruptedException, for instance when your code is part of a Runnable. In these situations, you must catch InterruptedException and restore the interrupted status by calling interrupt on the current thread, so that code higher up the call stack can see that an interrupt was issued. <!END QUOTATION> In the case of borrowConnection, #1 is not really a choice, as it is running in the confines of JDBC interface. But it can definitely restore the interrupt status of the thread. | resolved fixed | fe16ac2 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-27T17:55:41Z" | "2011-10-20T22:33:20Z" |
52,957 | Bug 52957 ClassCastException while removing Valve | null | resolved fixed | d5cee34 | ["java/org/apache/catalina/core/StandardPipeline.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-22T14:35:02Z" | "2012-03-21T17:13:20Z" |
52,839 | Bug 52839 New unit test for DigestAuthenticator and SingleSignOn | null | resolved fixed | c0f1bb9 | ["test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-20T21:34:06Z" | "2012-03-06T21:40:00Z" |
50,860 | Bug 50860 In case of invalid or empty slqQuery connection are always invalidated without usefull information | The code is (in PooledConnection.java#validate(int validateAction,String sql) ) Statement stmt = null; try { stmt = connection.createStatement(); stmt.execute(query); stmt.close(); this.lastValidated = now; return true; } catch (Exception ignore) { if (log.isDebugEnabled()) log.debug("Unable to validate object:",ignore); if (stmt!=null) try { stmt.close();} catch (Exception ignore2){/*NOOP*/} } return false; So in the case of null or invalid query (connection is always invalidated : seems normal :-) ). But without any usefull message (except if you use debug : but seems complicated in a production env). So IMHO adding a log.warning in case of null query could be usefull. | resolved fixed | e092870 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-20T17:32:47Z" | "2011-03-03T11:00:00Z" |
51,893 | Bug 51893 JMX notification/Exception for empty/exhausted connection pool | Currently, if there is an error getting a connection from the pool, a generic SQLException is thrown. The only way to determine if the problem is a result of the connection pool being exhausted is to catch the SQLException and parse the message (i.e. look for "Pool empty" in ex.getMessage()). Would like to see the following: 1) A subclass of SQLException thrown in the case of an empty pool 2) A JMX notification sent in the case of an empty pool (e.g. [POOL EXHAUSTED]) | resolved fixed | 9d687eb | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-20T16:44:17Z" | "2011-09-26T18:00:00Z" |
51,237 | Bug 51237 SlowQueryReport interceptor does not log anything | null | resolved fixed | 0eb38b8 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-20T14:02:18Z" | "2011-05-21T01:06:40Z" |
52,926 | Bug 52926 NPE in processSocket | We have sporadic issues triggering 502 proxy errors using the NIO connector behind Nginx, caused by dropped connections/end of streams in Tomcat. The Tomcat log shows: SEVERE: Error allocating socket processor java.lang.NullPointerException at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:721) at org.apache.tomcat.util.net.NioEndpoint$Poller.cancelledKey(NioEndpoint.java:1048) at org.apache.tomcat.util.net.NioEndpoint$Poller.timeout(NioEndpoint.java:1392) at org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1174) at java.lang.Thread.run(Thread.java:662) Looking at the code in processSocket I see the line in NioEndpoint(721): attachment.setCometNotify(false); //will get reset upon next reg Attachment is fetched in line 720: KeyAttachment attachment = (KeyAttachment)socket.getAttachment(false); Looking at socket.getAttachement() method I see that this method is indeed capable of returning null, but no null-check for this is done (although it is in multiple other locations, so it seems inconsistent). | resolved fixed | dcb8808 | ["java/org/apache/tomcat/util/net/NioEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-20T11:07:21Z" | "2012-03-16T12:13:20Z" |
52,723 | Bug 52723 An incomplete fix for the resource leak bugs in StandardManager.java | null | resolved wontfix | 9f8c8d6 | ["java/org/apache/catalina/session/StandardManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-09T20:32:50Z" | "2012-02-21T16:00:00Z" |
52,850 | Bug 52850 Various miscellaneous fixes to Tomcat Memory Leak Detection code | Problem Description - ---------------------- Tomcat memory leak detection has the following issues - Most of the detection and fixing code has been tested ONLY on Sun JVMs. A lot of the reflection based code does not work with the IBM JDK. - Tests in tomcat7.source\test\org\apache\catalina\loader do not seem to run successfully and are incomplete for all the protection that Tomcat provides for classloader memory leaks. - For some categories of threadlocal memory leaks the key and value are not displayed correctly in the warning messages; particularly ones dealing with indirect references to threadlocals - org.apache.catalina.loader.WebappClassLoader.loadedByThisOrChild(Object) incorrectly traverses the object classloader hierarchy instead of the current (this) classloader hierarchy Problem Conclusion - -------------------- - After extensive testing with the IBM JDKs, I have cleaned up and sanitized some of the reflection code to stop executors, timers, threads etc on the IBM JDK - Added new tests for detecting threadlocal leaks and thread leaks - Better ThreadLocal leak reporting with corrected loadedByThisOrChild method and addition of expungeStaleEntries method - Make code more resilient in certain leak detection scenarios. | resolved fixed | adbf442 | ["java/org/apache/catalina/loader/WebappClassLoader.java", "test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java", "test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-09T19:08:49Z" | "2012-03-07T19:53:20Z" |
52,776 | Bug 52776 Generator's JspFragment.invoke implementation does not reset ELContext[JspContext.class] | If a developer captures a JspFragment themselves and calls invoke on it, the JspContext.class attribute in the enclosing pageContext's ELContext is set by the generated JspFragment subclass, but not reset to its original value afterwards. Therefore after invoking a JspContext any EL expressions will be searching the wrong jspContext for attribute values. org.apache.jasper.compiler.Generator is responsible for creating the JspFragment subclass to represent the compiled fragment. The generatePostamble() method emits generated code to set the JspContext attribute in the ELContext: out.printil("this.jspContext.getELContext().putContext(javax.servlet.jsp.JspContext.class,this.jspContext);"); However it doesn't later put back the original value. If you are using the <jsp:invoke> tag to invoke the fragment (which is undoubtedly what most people are doing) then the code generated by visit(Node.InvokeAction n) in Generator explicitly restores the EL context: out.printil("jspContext.getELContext().putContext(javax.servlet.jsp.JspContext.class,getJspContext());"); However if you call invoke(Writer) on the JspFragment yourself you don't get that tidy up code. I suggest the resolution is to have the JspFragment.invoke method tidy up after itself. It "puts" the change to the JspContext.class attribute so it should also re"put" it. Then there shouldn't be any need to restore the EL context in the generated <jsp:invoke> code. I have tested this solution successfully. | resolved fixed | faf26da | ["java/org/apache/jasper/compiler/Generator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-09T11:51:42Z" | "2012-02-27T05:20:00Z" |
52,500 | Bug 52500 Improve client certificate authentication | null | resolved fixed | 401c703 | ["java/org/apache/catalina/realm/RealmBase.java", "java/org/apache/catalina/realm/X509SubjectDnRetriever.java", "java/org/apache/catalina/realm/X509UsernameRetriever.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-08T17:22:29Z" | "2012-01-23T17:33:20Z" |
52,719 | Bug 52719 An incomplete fix for the resource leak bug in WebappClassLoader.java | null | resolved fixed | 78c02a7 | ["java/org/apache/catalina/loader/WebappClassLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-07T21:45:27Z" | "2012-02-21T16:00:00Z" |
52,792 | Bug 52792 Incomplete error message when lookup a resource that is not bound in the naming | null | resolved fixed | 7cec4ff | ["java/org/apache/naming/NamingContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-07T21:11:01Z" | "2012-02-29T01:46:40Z" |
52,772 | Bug 52772 JspC : checking uriRoot option validness | In org.apache.jasper.JspC#execute() method, if uriRoot is not null, it scans all jsp files under uriRoot, and then checks if uriRoot is a directory. It should be more desirable to check if uriRoot is a directory or not first and then scanning it. Here are my suggestion. if (uriRoot == null) { throw new JasperException( Localizer.getMessage("jsp.error.jspc.no_uriroot")); } File uriRootF = new File(uriRoot); if (!uriRootF.exists() || !uriRootF.isDirectory()) { throw new JasperException( Localizer.getMessage("jsp.error.jspc.uriroot_not_dir")); } if( context==null ) { initServletContext(); } // No explicit pages, we'll process all .jsp in the webapp if (pages.size() == 0) { scanFiles(uriRootF); } | resolved fixed | 35958df | ["java/org/apache/jasper/JspC.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-07T15:09:07Z" | "2012-02-26T12:40:00Z" |
52,770 | Bug 52770 Potential Bug or Inconsistency in NioBlockingSelector.java | This is Ken Cheung, a Computer Science M.Phil. student. I observed some code clones in Tomcat and found inconsistent code: /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 103 try { 104 if ( att.getWriteLatch()==null || att.getWriteLatch().getCount()==0) att.startWriteLatch(1); 105 poller.add(att,SelectionKey.OP_WRITE,reference); 106 att.awaitWriteLatch(writeTimeout,TimeUnit.MILLISECONDS); 107 }catch (InterruptedException ignore) { 108 Thread.interrupted(); 109 } 110 if ( att.getWriteLatch()!=null && att.getWriteLatch().getCount()> 0) { 111 //we got interrupted, but we haven't received notification from the poller. 112 keycount = 0; 113 }else { 114 //latch countdown has happened 115 keycount = 1; 116 att.resetWriteLatch(); 117 } 118 119 if (writeTimeout > 0 && (keycount == 0)) 120 timedout = (System.currentTimeMillis() - time) >= writeTimeout; /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 164 try { 165 if ( att.getReadLatch()==null || att.getReadLatch().getCount()==0) att.startReadLatch(1); 166 poller.add(att,SelectionKey.OP_READ, reference); 167 if (readTimeout < 0) { 168 att.awaitReadLatch(Long.MAX_VALUE, TimeUnit.MILLISECONDS); 169 } else { 170 att.awaitReadLatch(readTimeout, TimeUnit.MILLISECONDS); 171 } 172 }catch (InterruptedException ignore) { 173 Thread.interrupted(); 174 } 175 if ( att.getReadLatch()!=null && att.getReadLatch().getCount()> 0) { 176 //we got interrupted, but we haven't received notification from the poller. 177 keycount = 0; 178 }else { 179 //latch countdown has happened 180 keycount = 1; 181 att.resetReadLatch(); 182 } 183 if (readTimeout >= 0 && (keycount == 0)) 184 timedout = (System.currentTimeMillis() - time) >= readTimeout; Quick description of the inconsistency Two code snippets are very similar code, but as you see, the first code does not check "if (readTimeout < 0)" while the second code has the checker. We thought it could be a potential bug or inconsistency. Hope this helps. | resolved fixed | 4f75b2d | ["java/org/apache/tomcat/util/net/NioBlockingSelector.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-07T14:34:59Z" | "2012-02-25T20:00:00Z" |
52,767 | Bug 52767 Potential Bug or Inconsistency in JDBCRealm.java and JDBCAccessLogValve.java | This is Ken Cheung, a Computer Science M.Phil. student. I observed some code clones in Tomcat and found inconsistent code: /tomcat/trunk/java/org/apache/catalina/realm/JDBCRealm.java 676 if (driver == null) { 677 try { 678 Class<?> clazz = Class.forName(driverName); 679 driver = (Driver) clazz.newInstance(); 680 } catch (Throwable e) { 681 ExceptionUtils.handleThrowable(e); 682 throw new SQLException(e.getMessage(), e); 683 } 684 } 685 686 // Open a new connection 687 Properties props = new Properties(); 688 if (connectionName != null) 689 props.put("user", connectionName); 690 if (connectionPassword != null) 691 props.put("password", connectionPassword); 692 dbConnection = driver.connect(connectionURL, props); /tomcat/trunk/java/org/apache/catalina/valves/JDBCAccessLogValve.java 566 if (driver == null) { 567 try { 568 Class<?> clazz = Class.forName(driverName); 569 driver = (Driver) clazz.newInstance(); 570 } catch (Throwable e) { 571 ExceptionUtils.handleThrowable(e); 572 throw new SQLException(e.getMessage(), e); 573 } 574 } 575 576 // Open a new connection 577 Properties props = new Properties(); 578 props.put("autoReconnect", "true"); 579 if (connectionName != null) { 580 props.put("user", connectionName); 581 } 582 if (connectionPassword != null) { 583 props.put("password", connectionPassword); 584 } 585 conn = driver.connect(connectionURL, props); Quick description of the inconsistency Two code snippets are very similar code, but as you see, in JDBCRealm.java does not use "props.put("autoReconnect", "true")" while JDBCAccessLogValve.java has. We thought it could be a potential bug or inconsistency. Hope this helps. | resolved fixed | 1f4663d | ["java/org/apache/catalina/valves/JDBCAccessLogValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-07T13:24:45Z" | "2012-02-25T20:00:00Z" |
52,846 | Bug 52846 Programmatic login using UserDatabaseRealm returns 403 error. | IMHO,HttpServletRequest#login does not need to define a <login-config>. NonLoginAuthenticator is used when <login-config> is not specified in HttpServletRequest#login. When UserDatabaseRealm is used, not GenericPrincipal but Memory User is set to a session. In AuthenticatorBase#invoke, principal registered into a session is set to a request. Because MemoryUser is set to a request as principal, RealmBase#hasRole always returns false. As a result, 403 error is returned. | resolved fixed | a01418d | ["java/org/apache/catalina/authenticator/NonLoginAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-07T09:20:48Z" | "2012-03-07T14:20:00Z" |
52,732 | Bug 52732 An incomplete fix for the resource leak bug in ExpressionFactory.java | null | resolved fixed | 6399c83 | ["java/javax/el/ExpressionFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-06T22:56:31Z" | "2012-02-21T16:00:00Z" |
52,731 | Bug 52731 An incomplete fix for the resource leak bug in JDTCompiler.java | null | resolved fixed | 2b1d195 | ["java/org/apache/jasper/compiler/JDTCompiler.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-06T22:39:33Z" | "2012-02-21T16:00:00Z" |
52,729 | Bug 52729 An incomplete fix for the resource leak bug in CometConnectionManagerValve.java | null | resolved fixed | 683d5c1 | ["java/org/apache/catalina/valves/CometConnectionManagerValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-06T21:26:11Z" | "2012-02-21T16:00:00Z" |
52,727 | Bug 52727 An incomplete fix for the resource leak bug in HostConfig.java | null | resolved fixed | 8293a6e | ["java/org/apache/catalina/startup/HostConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-06T21:15:26Z" | "2012-02-21T16:00:00Z" |
52,726 | Bug 52726 An incomplete fix for the resource leak bug in MemoryUserDatabase.java | null | resolved fixed | a30ce07 | ["java/org/apache/catalina/users/MemoryUserDatabase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-06T20:56:10Z" | "2012-02-21T16:00:00Z" |
52,725 | Bug 52725 org.apache.jasper.compiler.JspUtil#getTagHandlerClassName() does not use org.apache.jasper.Constants.TAG_FILE_PACKAGE_NAME | In the class org.apache.jasper.compiler.JspUtil, its method public static String getTagHandlerClassName(String path, String urn, ErrorDispatcher err) throws JasperException { ... } uses the string constants directly like "org.apache.jsp.tag.web.", "org.apache.jsp.tag.meta.". But you know there is TAG_FILE_PACKAGE_NAME field in the class org.apache.jasper.Constants. The code should be adjusted like below : Constants.TAG_FILE_PACKAGE_NAME + ".web" Constants.TAG_FILE_PACKAGE_NAME + ".meta" | resolved fixed | bf0287e | ["java/org/apache/jasper/compiler/JspUtil.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-05T20:20:00Z" | "2012-02-21T16:00:00Z" |
52,724 | Bug 52724 An incomplete fix for the resource leak bugs in Catalina.java | null | resolved fixed | 7c51f61 | ["java/org/apache/catalina/startup/Catalina.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-05T20:10:32Z" | "2012-02-21T16:00:00Z" |
52,804 | Bug 52804 Make PoolProperties implement Cloneable. | It would be very useful to have the PoolProperties class implement the java.lang.Cloneable interface. We have many databases that share the same schema, username, password, configuration etc but differ only in their URL. Implementing a routing datasource based on something like org.springframework.jdbc.datasource.AbstractDataSource can then just clone a PoolProperties object and set the one or two properties that differ in the clone. In a spring project the properties that are common across all the datasources are only supplied once. | resolved fixed | 55baca6 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-03-01T20:15:24Z" | "2012-03-01T22:13:20Z" |
52,760 | Bug 52760 Mime type for javascript incorrect in documentation | null | resolved fixed | 833e6b1 | ["java/org/apache/catalina/filters/ExpiresFilter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-26T13:29:48Z" | "2012-02-24T19:00:00Z" |
52,758 | Bug 52758 Jasper illegally implements org.eclipse.jdt.internal.compiler.env.ICompilationUnit from Eclipse | null | resolved fixed | 2e7f5ab | ["java/org/apache/jasper/compiler/JDTCompiler.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-24T10:04:05Z" | "2012-02-24T10:40:00Z" |
52,671 | Bug 52671 NIO Connector: Exception invoking method readBufSize / writeBufSize in the JMX Proxy Servlet | null | resolved fixed | 3fe64a5 | ["java/org/apache/catalina/mbeans/MBeanDumper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-15T20:58:16Z" | "2012-02-15T15:33:20Z" |
52,669 | Bug 52669 Annotation processing, in WEB-INF/classes, for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scenarios | null | resolved fixed | 34b1a7e | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-15T20:57:36Z" | "2012-02-15T01:40:00Z" |
52,666 | Bug 52666 EL should coerce String to Integer in equals operation | null | resolved fixed | bf9bf39 | ["java/org/apache/el/lang/ELSupport.java", "test/org/apache/el/lang/TestELSupport.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-15T16:26:08Z" | "2012-02-14T17:20:00Z" |
52,607 | Bug 52607 It is not well defined how "Dependencies on extensions" mechanism can be used in Tomcat | null | resolved fixed | 4b6d583 | ["java/org/apache/catalina/core/StandardServer.java", "java/org/apache/catalina/util/ExtensionValidator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-08T21:15:07Z" | "2012-02-06T03:46:40Z" |
52,606 | Bug 52606 FORM authentication POST replay broken for AJP | null | resolved fixed | 6f766be | ["java/org/apache/coyote/ajp/AbstractAjpProcessor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-08T17:12:08Z" | "2012-02-05T22:13:20Z" |
52,591 | Bug 52591 UnsupportedOperationException logged when fetching BasicDataSource 'loginTimeout' | With a BasicDataSource configured (using a <Resource>), simply list the available MBeans and this exception will be emitted to stdout: SEVERE: Error getting attribute Catalina:type=DataSource,context=/context,host=localhost,class=javax.sql.DataSource,name="jdbc/myDataSource" loginTimeout javax.management.RuntimeOperationsException: Exception invoking method loginTimeout at org.apache.tomcat.util.modeler.BaseModelMBean.getAttribute(BaseModelMBean.java:197) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:666) at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:638) at org.apache.catalina.mbeans.MBeanDumper.dumpBeans(MBeanDumper.java:81) at org.apache.catalina.manager.JMXProxyServlet.listBeans(JMXProxyServlet.java:166) at org.apache.catalina.manager.JMXProxyServlet.doGet(JMXProxyServlet.java:121) at javax.servlet.http.HttpServlet.service(HttpServlet.java:621) [...] Caused by: java.lang.UnsupportedOperationException: Not supported by BasicDataSource at org.apache.tomcat.dbcp.dbcp.BasicDataSource.getLoginTimeout(BasicDataSource.java:1083) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) This exception does not cause the request to fail, but definitely puts an ugly stack trace in catalina.out. It might be better to catch UnsupportedOperationException and emit a one-line error message -- one that isn't SEVERE. | resolved fixed | fbf9166 | ["java/org/apache/catalina/mbeans/MBeanDumper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-08T14:33:23Z" | "2012-02-03T20:13:20Z" |
52,586 | Bug 52586 When requests are forwarded, the request attribute javax.servlet.forward.path_info is assigned an incorrect value. | As per the servlet spec, the values for: javax.servlet.forward.request_uri javax.servlet.forward.context javax.servlet.forward.servlet_path javax.servlet.forward.path_info javax.servlet.forward.query_string MUST be set to the values from the very first servlet that serviced the current request. However, it seems that Tomcat is populating path_info with the value of the LAST path_info serviced in the request (i.e. the final servlet that serviced the request). It's possible the other value assignments are afflicted by similar defects, I've not explicitly tested for this. Because of this issue, it's impossible to correctly reconstruct the original request's URI piecemeal by concatenating context+servlet_path+path_info+?+query_string, since path_info will contain the path to another servlet and thus this concatenation will produce a probably invalid URI target. Therefore, creating "click here to retry" links is impossible without workaround code. The critical issue here is the deviation from the servlet spec, which spells out the behavior of those attributes. | resolved fixed | 660513c | ["java/org/apache/catalina/core/StandardHostValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-05T21:54:30Z" | "2012-02-03T00:46:40Z" |
52,577 | Bug 52577 Response output written in filter can be truncated | Due to changes 1229726, 1229727 and 1229728 output written to response in the filter can be truncated up to 8192 bytes. Consider the following scenario: - you have a filter that invoke getWriter() before chain.doFilter(request, responseWrapper) - responseWrapper overrides getWriter() method and returns some buffered writer, not the real one - during execution of chain.doFilter there is a forward Before the forward ApplicationDispather calls resetBuffer on response, which in turn calls reset() on OutputBuffer, which sets gotEnc field to false. This field is initialized in the setConverter() method which is called from response.getWriter(), but since our wrapperResponse overrides getWriter(), OutputBuffer.setConverter() never called and OutputBuffer still has gotEnc = false. Response's close() and flushBuffer() methods call OutputBuffer's flush(), but since gotEnc == false, conv.flushBuffer() is not called: if (gotEnc && conv != null) { conv.flushBuffer(); } A workaround for us is to implement getWriter() method in responseWrapper like this: public Writer getWriter() { Writer originalWriter = originalResponse.getWriter();//save for future processing return ourWriter; } Maybe you should change flushing to something like that: if (conv != null) { conv.flushBuffer(); } because you invoke conv.convert() without any checks in the write*() methods and it seems like conv is never null. | resolved fixed | 2fd117b | ["java/org/apache/catalina/connector/OutputBuffer.java", "java/org/apache/catalina/connector/Response.java", "test/org/apache/catalina/connector/TestOutputBuffer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-05T21:12:42Z" | "2012-02-02T13:40:00Z" |
52,587 | Bug 52587 NPE in authenticator when no realm/resource is defined | When no Realm is available to authenticate against, an NPE is thrown. STR: 1. Start with a stock 7.0.25 and modify server.xml: 2. Comment-out <Resource> in <GlobalNamingResources> 3. Comment-out <Realm> in <Engine> 4. Deploy manager app and try to log in java.lang.NullPointerException org.apache.catalina.realm.RealmBase.authenticate(RealmBase.java:340) org.apache.catalina.authenticator.BasicAuthenticator.authenticate(BasicAuthenticator.java:158) org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:544) org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:987) org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:579) org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1600) java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) java.lang.Thread.run(Thread.java:680) Clearly, this is a pathological setup, but it might be nice to get a decent error message instead of an NPE. | resolved fixed | 49a52cb | ["java/org/apache/catalina/core/StandardEngine.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-02-05T20:12:26Z" | "2012-02-03T00:46:40Z" |
52,444 | Bug 52444 Classloading-based ServletContainerInitializer @HandlesTypes processing can result in long startup times | See 52326 for background, noting particularly the following: "As long as SCI processing involves expensive classloading, larger applications will suffer from long startup times and thus be encouraged to "shut off" this functionality via metadata-complete='true'." This issue, then, is intended to address classloading-based approach to @HandlesTypes processing by replacing it with something faster and generally less problematic. ASM would be one way to get it done. | resolved fixed | f4896de | ["java/org/apache/catalina/startup/ContextConfig.java", "java/org/apache/tomcat/util/bcel/classfile/JavaClass.java", "test/org/apache/catalina/startup/TestContextConfigAnnotation.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-01-30T11:14:06Z" | "2012-01-09T23:00:00Z" |
52,547 | Bug 52547 incorrect byeswritten log after completed async request under http1.0 | null | resolved fixed | f2edc92 | ["java/org/apache/coyote/http11/AbstractOutputBuffer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-01-28T20:28:18Z" | "2012-01-28T00:20:00Z" |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.