Datasets:

akumoth

/

peewee-issues

like 0

{ "login": "josiahlaivins", "id": 55600928, "node_id": "MDQ6VXNlcjU1NjAwOTI4", "avatar_url": "https://avatars.githubusercontent.com/u/55600928?v=4", "gravatar_id": "", "url": "https://api.github.com/users/josiahlaivins", "html_url": "https://github.com/josiahlaivins", "followers_url": "https://api.github.com/users/josiahlaivins/followers", "following_url": "https://api.github.com/users/josiahlaivins/following{/other_user}", "gists_url": "https://api.github.com/users/josiahlaivins/gists{/gist_id}", "starred_url": "https://api.github.com/users/josiahlaivins/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/josiahlaivins/subscriptions", "organizations_url": "https://api.github.com/users/josiahlaivins/orgs", "repos_url": "https://api.github.com/users/josiahlaivins/repos", "events_url": "https://api.github.com/users/josiahlaivins/events{/privacy}", "received_events_url": "https://api.github.com/users/josiahlaivins/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Not really, Peewee does not make an effort to support microsoft tsql.", "@coleifer Thanks for the quick response! I understand that peewee doesnt support tsql. However I am making my own database object to support it. I thought I could just do a similar thing to the SQliteDatabase code. I appreciate any opinions from you on this. I could boil my problem down to the question whether peewee supports this form of operations:\r\n```python\r\noperations={\r\n \"IF NOT EXISTS\": \"IF NOT EXISTS(select * from sysobjects where name='sometable')\"\r\n }\r\n```\r\nWhere there is a select statement with params inside. Unless this is what you mean by `not make an effort to support microsoft tsql.` in that tsql requires the ability to replace simple operations with subqueries?\r\n\r\nIf your response is that the operations field doesnt support something as complex as a subquery, then that helps a lot, I would likely need to do some deeper customization then. Thanks!", "You will want to subclass the `SchemaManager` and override the `_create_table()` method, then instruct your base models to specify your custom SchemaManager implementation. The SchemaManager is where the logic lives for constructing the various DML queries." ]

"2021-05-24T19:39:57"

"2021-05-24T21:56:47"

"2021-05-24T20:59:34"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2418/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Donkere-vader", "id": 34307023, "node_id": "MDQ6VXNlcjM0MzA3MDIz", "avatar_url": "https://avatars.githubusercontent.com/u/34307023?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Donkere-vader", "html_url": "https://github.com/Donkere-vader", "followers_url": "https://api.github.com/users/Donkere-vader/followers", "following_url": "https://api.github.com/users/Donkere-vader/following{/other_user}", "gists_url": "https://api.github.com/users/Donkere-vader/gists{/gist_id}", "starred_url": "https://api.github.com/users/Donkere-vader/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Donkere-vader/subscriptions", "organizations_url": "https://api.github.com/users/Donkere-vader/orgs", "repos_url": "https://api.github.com/users/Donkere-vader/repos", "events_url": "https://api.github.com/users/Donkere-vader/events{/privacy}", "received_events_url": "https://api.github.com/users/Donkere-vader/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You're doing some very strange stuff with so many operator overloads and things, so it's hard to tell what is going on. Specifically, overriding getitem / setitem on model classes should probably be avoided.\r\n\r\nI'd suggest simplifying your code as much as possible to track this down, as I'm quite sure it's not a bug in Peewee but rather in your implementation.", "Oh it was a very very stupid problem.\r\n\r\nThe code for my ``ListItem`` class looked like this:\r\n\r\n```py\r\nclass ListItem(Item):\r\n parent = ForeignKeyField(List, backref=\"items\")\r\n value = CharField\r\n```\r\nNotice the last line, I set value to the class CharField instead of an instance of CharField. I forgot the braces 🤦🏻 .\r\nThanks for your response anyways! \r\n\r\nLine should've been:\r\n```py\r\n value = CharField()\r\n```" ]

"2021-05-21T05:23:12"

"2021-05-21T14:15:06"

"2021-05-21T12:40:58"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2417/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "DimaKalbfleysh", "id": 39565365, "node_id": "MDQ6VXNlcjM5NTY1MzY1", "avatar_url": "https://avatars.githubusercontent.com/u/39565365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DimaKalbfleysh", "html_url": "https://github.com/DimaKalbfleysh", "followers_url": "https://api.github.com/users/DimaKalbfleysh/followers", "following_url": "https://api.github.com/users/DimaKalbfleysh/following{/other_user}", "gists_url": "https://api.github.com/users/DimaKalbfleysh/gists{/gist_id}", "starred_url": "https://api.github.com/users/DimaKalbfleysh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DimaKalbfleysh/subscriptions", "organizations_url": "https://api.github.com/users/DimaKalbfleysh/orgs", "repos_url": "https://api.github.com/users/DimaKalbfleysh/repos", "events_url": "https://api.github.com/users/DimaKalbfleysh/events{/privacy}", "received_events_url": "https://api.github.com/users/DimaKalbfleysh/received_events", "type": "User", "site_admin": false }

[]

[]

[ "There is some simple jsonpath support for the `__getitem__()`-type operations on jsonb fields. Because jsonpath is basically an entire language of its own, I've chosen not to implement some kind of python layer for now.\r\n\r\nYou can call the postgres jsonpath functions quite easily from peewee via `fn.jsonpath_XXX()` and pass in the field instance and the desired path as a string.\r\n\r\n```python\r\nfn.jsonb_path_exists(JsonModel.data, '$.owner_user_id ? (@ == 4843)')\r\n```" ]

"2021-05-20T08:10:31"

"2021-05-20T13:02:53"

"2021-05-20T13:02:09"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2416/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "atanasoff-yordan", "id": 34780301, "node_id": "MDQ6VXNlcjM0NzgwMzAx", "avatar_url": "https://avatars.githubusercontent.com/u/34780301?v=4", "gravatar_id": "", "url": "https://api.github.com/users/atanasoff-yordan", "html_url": "https://github.com/atanasoff-yordan", "followers_url": "https://api.github.com/users/atanasoff-yordan/followers", "following_url": "https://api.github.com/users/atanasoff-yordan/following{/other_user}", "gists_url": "https://api.github.com/users/atanasoff-yordan/gists{/gist_id}", "starred_url": "https://api.github.com/users/atanasoff-yordan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/atanasoff-yordan/subscriptions", "organizations_url": "https://api.github.com/users/atanasoff-yordan/orgs", "repos_url": "https://api.github.com/users/atanasoff-yordan/repos", "events_url": "https://api.github.com/users/atanasoff-yordan/events{/privacy}", "received_events_url": "https://api.github.com/users/atanasoff-yordan/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee will do the right thing and use the alias if you write it this way:\r\n\r\n```python\r\nct = fn.COUNT(Tweet.id).alias('ct')\r\nquery = (User\r\n .select(User.username, ct)\r\n .join(Tweet, JOIN.LEFT_OUTER)\r\n .group_by(User.username)\r\n .order_by(ct))\r\n```\r\n\r\nProduces:\r\n\r\n```sql\r\nSELECT \"t1\".\"username\", COUNT(\"t2\".\"id\") AS \"ct\" \r\nFROM \"user\" AS \"t1\" \r\nLEFT OUTER JOIN \"tweet\" AS \"t2\" ON (\"t2\".\"user_id\" = \"t1\".\"id\") \r\nGROUP BY \"t1\".\"username\" \r\nORDER BY \"ct\"\r\n```" ]

"2021-05-19T11:47:06"

"2021-05-19T12:38:48"

"2021-05-19T12:38:47"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2415/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "xiaoqge", "id": 8544686, "node_id": "MDQ6VXNlcjg1NDQ2ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/8544686?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoqge", "html_url": "https://github.com/xiaoqge", "followers_url": "https://api.github.com/users/xiaoqge/followers", "following_url": "https://api.github.com/users/xiaoqge/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoqge/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoqge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoqge/subscriptions", "organizations_url": "https://api.github.com/users/xiaoqge/orgs", "repos_url": "https://api.github.com/users/xiaoqge/repos", "events_url": "https://api.github.com/users/xiaoqge/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoqge/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee supports multiple IN conditions:\r\n\r\n```python\r\n\r\n# postgres:\r\nin_list = ValuesList([(1, 'u1'), (2, 'u2'), (7, 'u7'), (8, 'u8')])\r\nquery = User.select().where(Tuple(User.id, User.username).in_(in_list))\r\n\r\n\r\n# note sqlite requires additional parentheses:\r\nfrom peewee import EnclosedNodeList\r\nin_list = EnclosedNodeList([in_list])\r\nquery = User.select().where(Tuple(User.id, User.username).in_(in_list))\r\n```", "thank you " ]

"2021-05-19T06:11:12"

"2021-05-20T02:07:21"

"2021-05-19T12:43:53"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2414/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexin", "id": 768281, "node_id": "MDQ6VXNlcjc2ODI4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/768281?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexin", "html_url": "https://github.com/alexin", "followers_url": "https://api.github.com/users/alexin/followers", "following_url": "https://api.github.com/users/alexin/following{/other_user}", "gists_url": "https://api.github.com/users/alexin/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexin/subscriptions", "organizations_url": "https://api.github.com/users/alexin/orgs", "repos_url": "https://api.github.com/users/alexin/repos", "events_url": "https://api.github.com/users/alexin/events{/privacy}", "received_events_url": "https://api.github.com/users/alexin/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You have a trailing comma after your peewee.IntegerField() which is probably the issue.\r\n\r\nThis code works fine:\r\n\r\n```python\r\nclass Product(Model):\r\n reference = IntegerField(column_name='reference', primary_key=True)\r\n class Meta:\r\n database = db\r\n```\r\n\r\nProduces:\r\n\r\n```sql\r\nCREATE TABLE IF NOT EXISTS \"product\" (\"reference\" INTEGER NOT NULL PRIMARY KEY)\r\n```\r\n\r\nPlease debug your code a bit more before opening issues.", "Thank you for pointing that out. I am so used to Java-like languages that I easily missed that comma.\r\nI understand it is dumb mistake and I could have avoided it. In my defense, I am dumbfounded I got no error nor warning, that could have saved me hours of figuring what was happening." ]

"2021-05-13T12:30:41"

"2021-05-13T12:55:44"

"2021-05-13T12:48:30"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2413/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bravegag", "id": 4385408, "node_id": "MDQ6VXNlcjQzODU0MDg=", "avatar_url": "https://avatars.githubusercontent.com/u/4385408?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bravegag", "html_url": "https://github.com/bravegag", "followers_url": "https://api.github.com/users/bravegag/followers", "following_url": "https://api.github.com/users/bravegag/following{/other_user}", "gists_url": "https://api.github.com/users/bravegag/gists{/gist_id}", "starred_url": "https://api.github.com/users/bravegag/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bravegag/subscriptions", "organizations_url": "https://api.github.com/users/bravegag/orgs", "repos_url": "https://api.github.com/users/bravegag/repos", "events_url": "https://api.github.com/users/bravegag/events{/privacy}", "received_events_url": "https://api.github.com/users/bravegag/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I found [this discussion](https://sqlite.org/forum/info/a4dde39b614ec0b2) and the issue is my version of sqlite3 3.29.0 which is lower than 3.35.x from where the RETURNING clause is supported :(.\r\n\r\nIs there another way to accomplish the same use-case without RETURNING?", ">Is there another way to accomplish the same use-case without RETURNING?\r\n\r\nIf you leave off the `returning()` (which is unsupported in sqlite < 3.35) then Peewee will already return you the last insert rowid, which it seems like is all you want anyways. For multi-row inserts there is no equivalent, however." ]

"2021-05-12T22:05:20"

"2021-05-13T00:51:12"

"2021-05-13T00:50:42"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2412/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bravegag", "id": 4385408, "node_id": "MDQ6VXNlcjQzODU0MDg=", "avatar_url": "https://avatars.githubusercontent.com/u/4385408?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bravegag", "html_url": "https://github.com/bravegag", "followers_url": "https://api.github.com/users/bravegag/followers", "following_url": "https://api.github.com/users/bravegag/following{/other_user}", "gists_url": "https://api.github.com/users/bravegag/gists{/gist_id}", "starred_url": "https://api.github.com/users/bravegag/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bravegag/subscriptions", "organizations_url": "https://api.github.com/users/bravegag/orgs", "repos_url": "https://api.github.com/users/bravegag/repos", "events_url": "https://api.github.com/users/bravegag/events{/privacy}", "received_events_url": "https://api.github.com/users/bravegag/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Sqlite is finnicky about parentheses.\r\n\r\nThis should work:\r\n\r\n```python\r\n\r\nvl = ValuesList([('x1', 'y1'), ('x2', 'y2')])\r\n# wrap in extra parentheses for sqlite\r\nvl_p = EnclosedNodeList([vl])\r\n\r\nq = A.select().where(Tuple(A.a1, A.a2).in_(vl_p))\r\n```" ]

"2021-05-12T20:12:59"

"2021-05-12T21:21:30"

"2021-05-12T21:21:30"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2411/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pylipp", "id": 10617122, "node_id": "MDQ6VXNlcjEwNjE3MTIy", "avatar_url": "https://avatars.githubusercontent.com/u/10617122?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pylipp", "html_url": "https://github.com/pylipp", "followers_url": "https://api.github.com/users/pylipp/followers", "following_url": "https://api.github.com/users/pylipp/following{/other_user}", "gists_url": "https://api.github.com/users/pylipp/gists{/gist_id}", "starred_url": "https://api.github.com/users/pylipp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pylipp/subscriptions", "organizations_url": "https://api.github.com/users/pylipp/orgs", "repos_url": "https://api.github.com/users/pylipp/repos", "events_url": "https://api.github.com/users/pylipp/events{/privacy}", "received_events_url": "https://api.github.com/users/pylipp/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2021-05-12T13:21:24"

"2021-05-12T13:52:49"

"2021-05-12T13:52:49"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2410", "html_url": "https://github.com/coleifer/peewee/pull/2410", "diff_url": "https://github.com/coleifer/peewee/pull/2410.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2410.patch", "merged_at": null }

{ "login": "thigg", "id": 7593137, "node_id": "MDQ6VXNlcjc1OTMxMzc=", "avatar_url": "https://avatars.githubusercontent.com/u/7593137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thigg", "html_url": "https://github.com/thigg", "followers_url": "https://api.github.com/users/thigg/followers", "following_url": "https://api.github.com/users/thigg/following{/other_user}", "gists_url": "https://api.github.com/users/thigg/gists{/gist_id}", "starred_url": "https://api.github.com/users/thigg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thigg/subscriptions", "organizations_url": "https://api.github.com/users/thigg/orgs", "repos_url": "https://api.github.com/users/thigg/repos", "events_url": "https://api.github.com/users/thigg/events{/privacy}", "received_events_url": "https://api.github.com/users/thigg/received_events", "type": "User", "site_admin": false }

[]

[]

[ "For reference: \r\n\r\nI solved it with this function:\r\n\r\n```python\r\ndef recreate_table(table: Type[Model], tablename: str):\r\n logger.info(\"copying table %s\", tablename)\r\n table_copy_name = tablename + \"_x\"\r\n col_names = \",\".join(col.name for col in db.get_columns(tablename))\r\n db.execute_sql(\"ALTER TABLE %s RENAME TO %s;\" % (tablename, table_copy_name))\r\n db.create_tables([table])\r\n sql = \"INSERT INTO %s (%s) SELECT %s FROM %s;\" % (tablename, col_names, col_names, table_copy_name)\r\n #todo: check for returned sql errors\r\n db.execute_sql(sql)\r\n logger.info(\"deleting copy of table %s\", tablename)\r\n db.execute_sql(\"DROP TABLE %s_x;\" % tablename)\r\n```\r\nNote that you need the column names because the order might change when recreating the table. (E.g. if you replace a deferred constraint with a direct one)\r\n\r\n(Just has the problem, that the alter table also renames already existing constraints. Thus make sure, that you do not run this on a table, that is already referenced by a constraint, because otherwise the constraint is changed to `<table>_x`)", "I've decided to pass on implementing this for Sqlite, but it is possible, as you suggest.", "Maybe this could be mentioned in the documentation then?" ]

"2021-05-11T20:36:15"

"2021-05-12T12:55:01"

"2021-05-12T12:53:46"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2409/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "smuething", "id": 1837881, "node_id": "MDQ6VXNlcjE4Mzc4ODE=", "avatar_url": "https://avatars.githubusercontent.com/u/1837881?v=4", "gravatar_id": "", "url": "https://api.github.com/users/smuething", "html_url": "https://github.com/smuething", "followers_url": "https://api.github.com/users/smuething/followers", "following_url": "https://api.github.com/users/smuething/following{/other_user}", "gists_url": "https://api.github.com/users/smuething/gists{/gist_id}", "starred_url": "https://api.github.com/users/smuething/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/smuething/subscriptions", "organizations_url": "https://api.github.com/users/smuething/orgs", "repos_url": "https://api.github.com/users/smuething/repos", "events_url": "https://api.github.com/users/smuething/events{/privacy}", "received_events_url": "https://api.github.com/users/smuething/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2021-05-11T15:27:09"

"2021-05-11T19:08:55"

"2021-05-11T19:08:55"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2408/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2408", "html_url": "https://github.com/coleifer/peewee/pull/2408", "diff_url": "https://github.com/coleifer/peewee/pull/2408.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2408.patch", "merged_at": null }

{ "login": "enpaul", "id": 24588726, "node_id": "MDQ6VXNlcjI0NTg4NzI2", "avatar_url": "https://avatars.githubusercontent.com/u/24588726?v=4", "gravatar_id": "", "url": "https://api.github.com/users/enpaul", "html_url": "https://github.com/enpaul", "followers_url": "https://api.github.com/users/enpaul/followers", "following_url": "https://api.github.com/users/enpaul/following{/other_user}", "gists_url": "https://api.github.com/users/enpaul/gists{/gist_id}", "starred_url": "https://api.github.com/users/enpaul/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/enpaul/subscriptions", "organizations_url": "https://api.github.com/users/enpaul/orgs", "repos_url": "https://api.github.com/users/enpaul/repos", "events_url": "https://api.github.com/users/enpaul/events{/privacy}", "received_events_url": "https://api.github.com/users/enpaul/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Ehh, I'm going to pass on this, as I think it could be misleading. This is a mysql-only thing, as far as I know, and the data is still stored as a floating-point (e.g. approximate) value anyways. If you want to specify a precision then you would really want to use the DecimalField (numeric type).\r\n\r\nI'd suggest adding your own subclass of FloatField to your libraries if you want this functionality.", "That makes sense, thanks for taking a look at it! I had thought that this was a mysql+postgres feature, but it looks that you're right and it's only mysql. Thanks again for the great library!" ]

"2021-05-11T01:20:42"

"2021-05-12T20:24:24"

"2021-05-11T12:51:03"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2407/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2407", "html_url": "https://github.com/coleifer/peewee/pull/2407", "diff_url": "https://github.com/coleifer/peewee/pull/2407.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2407.patch", "merged_at": null }

{ "login": "vdksoda", "id": 12879372, "node_id": "MDQ6VXNlcjEyODc5Mzcy", "avatar_url": "https://avatars.githubusercontent.com/u/12879372?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vdksoda", "html_url": "https://github.com/vdksoda", "followers_url": "https://api.github.com/users/vdksoda/followers", "following_url": "https://api.github.com/users/vdksoda/following{/other_user}", "gists_url": "https://api.github.com/users/vdksoda/gists{/gist_id}", "starred_url": "https://api.github.com/users/vdksoda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vdksoda/subscriptions", "organizations_url": "https://api.github.com/users/vdksoda/orgs", "repos_url": "https://api.github.com/users/vdksoda/repos", "events_url": "https://api.github.com/users/vdksoda/events{/privacy}", "received_events_url": "https://api.github.com/users/vdksoda/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You bring up a good point about having this be consistent with other models. I've removed the code which was raising the `KeyError` and updated the docs as well. It should behave the same as regular models now." ]

"2021-05-08T05:55:21"

"2021-05-08T14:48:12"

"2021-05-08T14:47:40"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2406/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "konradkur", "id": 22791650, "node_id": "MDQ6VXNlcjIyNzkxNjUw", "avatar_url": "https://avatars.githubusercontent.com/u/22791650?v=4", "gravatar_id": "", "url": "https://api.github.com/users/konradkur", "html_url": "https://github.com/konradkur", "followers_url": "https://api.github.com/users/konradkur/followers", "following_url": "https://api.github.com/users/konradkur/following{/other_user}", "gists_url": "https://api.github.com/users/konradkur/gists{/gist_id}", "starred_url": "https://api.github.com/users/konradkur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/konradkur/subscriptions", "organizations_url": "https://api.github.com/users/konradkur/orgs", "repos_url": "https://api.github.com/users/konradkur/repos", "events_url": "https://api.github.com/users/konradkur/events{/privacy}", "received_events_url": "https://api.github.com/users/konradkur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Automatic reconnect can be done with the help of the `playhouse.shortcuts.ReconnectMixin`, but you will definitely need to modify the `reconnect_errors` attribute so that it corresponds to Postgres-specific error conditions. The reconnect mixin should not be used with Postgres unless you REALLY know what you are doing. See the source code: https://github.com/coleifer/peewee/blob/master/playhouse/shortcuts.py\r\n\r\nPeewee provides a helper for writing migrations: http://docs.peewee-orm.com/en/latest/peewee/playhouse.html#schema-migrations\r\n\r\nI can't vouch for any of the \"automatic\" migration tools." ]

"2021-05-07T11:35:40"

"2021-05-07T13:22:13"

"2021-05-07T13:22:13"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2405/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "xiaoqge", "id": 8544686, "node_id": "MDQ6VXNlcjg1NDQ2ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/8544686?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoqge", "html_url": "https://github.com/xiaoqge", "followers_url": "https://api.github.com/users/xiaoqge/followers", "following_url": "https://api.github.com/users/xiaoqge/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoqge/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoqge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoqge/subscriptions", "organizations_url": "https://api.github.com/users/xiaoqge/orgs", "repos_url": "https://api.github.com/users/xiaoqge/repos", "events_url": "https://api.github.com/users/xiaoqge/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoqge/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2021-05-07T07:37:21"

"2021-05-07T08:01:43"

"2021-05-07T08:01:43"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2404/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "xiaoqge", "id": 8544686, "node_id": "MDQ6VXNlcjg1NDQ2ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/8544686?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoqge", "html_url": "https://github.com/xiaoqge", "followers_url": "https://api.github.com/users/xiaoqge/followers", "following_url": "https://api.github.com/users/xiaoqge/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoqge/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoqge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoqge/subscriptions", "organizations_url": "https://api.github.com/users/xiaoqge/orgs", "repos_url": "https://api.github.com/users/xiaoqge/repos", "events_url": "https://api.github.com/users/xiaoqge/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoqge/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Ah, I see the problem.\r\n\r\nWhen Postgresql runs into an IntegrityError (the exception that occurs when you violate the unique constraint, e.g.) then you *have* to rollback the transaction. The connection gets into a bad state and no further queries can be run until you rollback. The problem is you have started your Tx before you insert the first row. So when you are forced to rollback, you are rolling back the insert." ]

"2021-05-06T16:15:31"

"2021-05-06T20:25:18"

"2021-05-06T20:24:30"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2403/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "xiaoqge", "id": 8544686, "node_id": "MDQ6VXNlcjg1NDQ2ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/8544686?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoqge", "html_url": "https://github.com/xiaoqge", "followers_url": "https://api.github.com/users/xiaoqge/followers", "following_url": "https://api.github.com/users/xiaoqge/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoqge/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoqge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoqge/subscriptions", "organizations_url": "https://api.github.com/users/xiaoqge/orgs", "repos_url": "https://api.github.com/users/xiaoqge/repos", "events_url": "https://api.github.com/users/xiaoqge/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoqge/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2021-05-06T14:08:51"

"2021-05-06T14:30:36"

"2021-05-06T14:30:35"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2402/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gondolio", "id": 4338344, "node_id": "MDQ6VXNlcjQzMzgzNDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/4338344?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gondolio", "html_url": "https://github.com/gondolio", "followers_url": "https://api.github.com/users/gondolio/followers", "following_url": "https://api.github.com/users/gondolio/following{/other_user}", "gists_url": "https://api.github.com/users/gondolio/gists{/gist_id}", "starred_url": "https://api.github.com/users/gondolio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gondolio/subscriptions", "organizations_url": "https://api.github.com/users/gondolio/orgs", "repos_url": "https://api.github.com/users/gondolio/repos", "events_url": "https://api.github.com/users/gondolio/events{/privacy}", "received_events_url": "https://api.github.com/users/gondolio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not sure what the correct replacement is, but here is the Peewee page in FastAPI:\r\nhttps://fastapi.tiangolo.com/advanced/sql-databases-peewee/", "I'm not familiar with FastAPI, that section was contributed. Since its async I assume that it is, in fact, rather complicated to use Peewee correctly with it. You would want to have a connection-per-async-context presumably, or a pool of conns that each async context can utilize. For normal python this is easy -- we store the db conn in a threadlocal. This also works for gevent, which monkeypatches threadlocal to be green-thread local. For async stuff like FastAPI you're on your own in terms of figuring that out - you can scope your connection to synchronous blocks and that might work -- I suppose that's what the startup/shutdown event implies.", "@coleifer async APIs become more and more popular. specifically FastAPI use is soaring. \r\nAny plans of supporting async apis which does not follow the thread per web request pattern? \r\n\r\nThanks", "There's no accounting for the multiplicity of developers tastes and opinions. My own view is that the pythonic way of doing async in python is to use gevent. Why?\r\n\r\n* No need to change your codebase or litter it with `async ...`, `await`.\r\n* No confusion around coroutines, tasks, futures, loops, etc.\r\n* Works seamlessly with existing frameworks such as Django, Flask, etc.\r\n* Because it handles switching implicitly, you don't need to worry if you forgot to yield somewhere.\r\n* No need to modify or search for special \"async\" versions of popular libraries or clients.\r\n* Works with database drivers as well, like pymysql and psycopg2.\r\n* Uses the familiar threading APIs and provides a \"greenlet\"-local, locks, events, queues, etc.\r\n* Performance\r\n* https://journal.stuffwithstuff.com/2015/02/01/what-color-is-your-function/\r\n\r\nPeewee supports the standard threading model, and by virtue of this, also supports gevent. At present I have no plans to make an async-aware version.", "Thanks for the quick response @coleifer.\r\n\r\nWell thats very unfortunate. ORMs should not force anything about the API tier. no matter how many benefits gevent has, \r\nI have my own constraints and reasons not to use it. either way as I said the python community is moving really fast toward async await, and it's gonna leave peewee behind.\r\n\r\nAs a peewee user who wants to use FastAPI / async await for my API I am currently in a problem.\r\n\r\nI would really appreciate anything looking into this and supporting / making async-aware version for peewee.\r\n\r\n", ">python community is moving really fast\r\n\r\nYes, it is moving fast (and breaking things). It seems that mindset has infected a lot of web-adjacent languages and communities.\r\n\r\nIt's always been my opinion that one should use the right tool for the job. Golang, for example, has a much better concurrency story by default for web development, as well as offering strong typing (something that Python also is flirting with). There are lots of languages out there. Rather than be all things to all people, Peewee plays to Python's strengths as I see them. Namely:\r\n\r\n* Dynamism\r\n* Simplicity, succintness\r\n* Composability\r\n\r\nThere are various 3rd party libraries that provide async stuff for Peewee, but I cannot vouch for any personally. Google will help you find them." ]

"2021-05-04T04:06:13"

"2022-02-09T15:38:31"

"2021-05-04T12:48:01"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2401/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "SamNPowers", "id": 881718, "node_id": "MDQ6VXNlcjg4MTcxOA==", "avatar_url": "https://avatars.githubusercontent.com/u/881718?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SamNPowers", "html_url": "https://github.com/SamNPowers", "followers_url": "https://api.github.com/users/SamNPowers/followers", "following_url": "https://api.github.com/users/SamNPowers/following{/other_user}", "gists_url": "https://api.github.com/users/SamNPowers/gists{/gist_id}", "starred_url": "https://api.github.com/users/SamNPowers/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SamNPowers/subscriptions", "organizations_url": "https://api.github.com/users/SamNPowers/orgs", "repos_url": "https://api.github.com/users/SamNPowers/repos", "events_url": "https://api.github.com/users/SamNPowers/events{/privacy}", "received_events_url": "https://api.github.com/users/SamNPowers/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Unfortunately, besides `.iterator()` the only other thing you might do would be to explicitly `.select()` all columns except for the large one. You could then implement a property/accessor to load the large column on-demand.\r\n\r\n```python\r\n\r\nclass Post(Model):\r\n title = TextField()\r\n _attachment = BlobField(column_name='attachment') # may have large binary data, e.g.\r\n\r\n @property\r\n def attachment(self):\r\n if self._attachment is None:\r\n post = Post.select(Post._attachment).get(Post.id == self.id)\r\n self._attachment = post._attachment\r\n return self_attachment\r\n```", "I do have a property/accessor to load the large column on demand. The problem is unloading it after I'm done with it. \r\n\r\nWould deleting the object and then re-loading all but the large column be the best way forward?", ">The problem is unloading it after I'm done with it.\r\n\r\nYou can use property deleters to free the memory:\r\n\r\n```python\r\n\r\nclass Post(Model):\r\n @property\r\n def attachment(self):\r\n # same as above...\r\n\r\n @attachment.deleter\r\n def attachment(self):\r\n self.__data__.pop('_attachment', None)\r\n\r\np = Post...\r\np.attachment # load from memory or pull from database\r\ndel p.attachment # frees cached data in model instance\r\n```", "Is there an easy way to do this for an entry in a ManyToManyField?\r\n\r\n```\r\nfrom peewee import SqliteDatabase, Model, TextField, BlobField, ManyToManyField\r\n\r\n\r\nclass Post(Model):\r\n title = TextField()\r\n _attachment = BlobField(column_name='attachment') # may have large binary data, e.g.\r\n\r\n @property\r\n def attachment(self):\r\n if self._attachment is None:\r\n post = Post.select(Post._attachment).get(Post.id == self.id)\r\n self._attachment = post._attachment\r\n return self._attachment\r\n\r\n\r\n @attachment.deleter\r\n def attachment(self):\r\n self.__data__.pop('_attachment', None)\r\n\r\n\r\nclass PostCollector(Model):\r\n post_collection = ManyToManyField(Post)\r\n\r\n\r\nif __name__ == \"__main__\":\r\n db = SqliteDatabase(\"test_db\")\r\n PostCollectionRelationship = PostCollector.post_collection.get_through_model()\r\n db.bind([Post, PostCollector, PostCollectionRelationship])\r\n if not Post.table_exists():\r\n db.create_tables([Post, PostCollector, PostCollectionRelationship])\r\n db.connect(reuse_if_open=True)\r\n\r\n post = Post.create(title=\"foo\", _attachment=\"bar\")\r\n fetched_posts = Post.select().limit(1).execute() # Get an entry (saves us from needing to specify id above)\r\n collector = PostCollector.create()\r\n collector.post_collection.add(fetched_posts[0])\r\n\r\n attachment = collector.post_collection[0].attachment\r\n del collector.post_collection[0].attachment\r\n print(collector.post_collection[0]._attachment)\r\n```\r\n\r\nIt seems to work if you're manipulating the Post directly, but if it was accessed via a ManyToManyField, it doesn't seem to hold. (b'bar' prints after execution of the above code, not \"attribute does not exist\" or something like it.)", "Because you're accessing it through the property, which re-fetches it from the db. Your code:\r\n\r\n1. gets the attachment\r\n2. frees the cached attachment data\r\n3. re-fetches it from the db", "Er, I'm sorry, the code has a typo. The last \"attachment\" is supposed to be \"_attachment\". Fixed it. But it still outputs b\"bar\".\r\n\r\nIn this case, the field shouldn't be getting refetched, since it's not going through the accessor. But nevertheless it is still there.", "Oh, I see - every time you index into that `collector.post_collection` (`collector.post_collection[0]`) you're executing a query and getting a new instance from the db.\r\n\r\nIf you pull it into a variable then it will work:\r\n\r\n```python\r\n post = collector.post_collection[0]\r\n print(post.attachment)\r\n del post.attachment\r\n print(post._attachment)\r\n```", "I do need to be able to manipulate (my version of) post_collection in some ways. My goal was to be able to ignore this specific field on posts except when it's necessary. Is it the case that every action (such as fetching a set of random posts) will re-fetch all attachments? Is there a convenient way to tell the ManyToManyField not to re-fetch its entries in this way? (E.g. if I want to use collector.post_collection.order_by(fn.Rand()).limit(5), will this cause all attachments to be re-fetched? Just the set returned? Either is undesirable, for my use case.)\r\n\r\nRelatedly: is there a recommended way to view the amount of RAM a given model is consuming? I've in general been using `from pympler import asizeof`, then using `asizeof.asizeof(obj)`, but neither adding elements to post_collection nor removing attachment from elements are causing changes in size of post_collection or collector (while a reduction is seen for individual posts). As I can't access elements on post_collection directly to check whether attachment is or is not on them again without ensuring the answer is \"yes\", I'm not sure how to debug this.\r\n\r\nMy essential problem is that even with del'ing these large fields off of my objects, my memory consumption has not been reduced as I would expect.", "Also, it would seem a ManyToManyField can't be pop'd off `__data__` the way other fields can (as `__data__` doesn't seem to contain it). What would the analogy be for a ManyToManyField?" ]

"2021-05-03T21:17:27"

"2021-05-07T05:41:04"

"2021-05-03T21:52:00"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2400/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ldconejo", "id": 5453372, "node_id": "MDQ6VXNlcjU0NTMzNzI=", "avatar_url": "https://avatars.githubusercontent.com/u/5453372?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ldconejo", "html_url": "https://github.com/ldconejo", "followers_url": "https://api.github.com/users/ldconejo/followers", "following_url": "https://api.github.com/users/ldconejo/following{/other_user}", "gists_url": "https://api.github.com/users/ldconejo/gists{/gist_id}", "starred_url": "https://api.github.com/users/ldconejo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ldconejo/subscriptions", "organizations_url": "https://api.github.com/users/ldconejo/orgs", "repos_url": "https://api.github.com/users/ldconejo/repos", "events_url": "https://api.github.com/users/ldconejo/events{/privacy}", "received_events_url": "https://api.github.com/users/ldconejo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I don't necessarily agree that this needs to be fixed by Peewee -- presumably you can sanitize or normalize this data." ]

"2021-05-03T17:01:33"

"2021-05-06T15:43:24"

"2021-05-06T15:43:24"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2399/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "nic519", "id": 2610741, "node_id": "MDQ6VXNlcjI2MTA3NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/2610741?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nic519", "html_url": "https://github.com/nic519", "followers_url": "https://api.github.com/users/nic519/followers", "following_url": "https://api.github.com/users/nic519/following{/other_user}", "gists_url": "https://api.github.com/users/nic519/gists{/gist_id}", "starred_url": "https://api.github.com/users/nic519/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nic519/subscriptions", "organizations_url": "https://api.github.com/users/nic519/orgs", "repos_url": "https://api.github.com/users/nic519/repos", "events_url": "https://api.github.com/users/nic519/events{/privacy}", "received_events_url": "https://api.github.com/users/nic519/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You're going to have a hard time, basically.\r\n\r\nYou might create a VIEW or something that unions together all these tables, and just select from that view for read-only queries.\r\n\r\nFor writing you will need to either\r\n\r\n1. change the `table_name` at runtime (`db_table` is deprecated, it has been renamed to `table_name`)\r\n2. create a model-per-table and pick the right one at runtime" ]

"2021-05-02T06:10:29"

"2021-05-02T17:28:19"

"2021-05-02T17:28:19"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2398/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "daveusa31", "id": 81916132, "node_id": "MDQ6VXNlcjgxOTE2MTMy", "avatar_url": "https://avatars.githubusercontent.com/u/81916132?v=4", "gravatar_id": "", "url": "https://api.github.com/users/daveusa31", "html_url": "https://github.com/daveusa31", "followers_url": "https://api.github.com/users/daveusa31/followers", "following_url": "https://api.github.com/users/daveusa31/following{/other_user}", "gists_url": "https://api.github.com/users/daveusa31/gists{/gist_id}", "starred_url": "https://api.github.com/users/daveusa31/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/daveusa31/subscriptions", "organizations_url": "https://api.github.com/users/daveusa31/orgs", "repos_url": "https://api.github.com/users/daveusa31/repos", "events_url": "https://api.github.com/users/daveusa31/events{/privacy}", "received_events_url": "https://api.github.com/users/daveusa31/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You don't even need `.is_true()` honestly, you can just:\r\n\r\n```python\r\n.where(User.is_activated)\r\n```\r\n\r\nOr for false:\r\n\r\n```python\r\n.where(~User.is_activated)\r\n```\r\n\r\nGoing to pass on this change." ]

"2021-04-30T18:46:01"

"2021-04-30T19:04:42"

"2021-04-30T19:04:01"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2397/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2397", "html_url": "https://github.com/coleifer/peewee/pull/2397", "diff_url": "https://github.com/coleifer/peewee/pull/2397.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2397.patch", "merged_at": null }

{ "login": "mkmoisen", "id": 2534631, "node_id": "MDQ6VXNlcjI1MzQ2MzE=", "avatar_url": "https://avatars.githubusercontent.com/u/2534631?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mkmoisen", "html_url": "https://github.com/mkmoisen", "followers_url": "https://api.github.com/users/mkmoisen/followers", "following_url": "https://api.github.com/users/mkmoisen/following{/other_user}", "gists_url": "https://api.github.com/users/mkmoisen/gists{/gist_id}", "starred_url": "https://api.github.com/users/mkmoisen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mkmoisen/subscriptions", "organizations_url": "https://api.github.com/users/mkmoisen/orgs", "repos_url": "https://api.github.com/users/mkmoisen/repos", "events_url": "https://api.github.com/users/mkmoisen/events{/privacy}", "received_events_url": "https://api.github.com/users/mkmoisen/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I dislike identity map and unit of work because they hide too much from the user and require some concept of a \"session\". Are sessions transactions? Connection lifetimes? Are they thread-safe? What kind of error-handling do they provide? Etc.\r\n\r\nI find it easier to think in terms of the abstractions provided by the db itself. A connection, beginning/committing transactions, during which queries are executed. And SQL, which can read row tuples into memory or write new/modified data back to the db.\r\n\r\nSessions, identity maps, unit-of-work all tend to obscure these things rather than simplify them - in my opinion.", "@coleifer Would you be able to comment on the purported benefits of using Identity Map/Unit of Work? \r\n\r\nI agree with you that these tend to just add complexity. However I'm not sure if there is some benefit that I may not be considering.", "The idea of unit-of-work is that the library can do a better job aggregating your queries for you, possibly de-duping things or rolling up small modifications into more efficient operations, as well as other things like dependency-resolution. It goes hand-in-hand with identity-map since maybe you modified some object in several places or there are branches that perform modifications which may or may not be followed.", "Thanks. Do you have an opinion on the Active Record vs Data Mapper argument?\r\n\r\nMy understanding is that those who prefer Data Mapper say that Active Record causes a coupling between business logic and persistence logic, and that this is in general a bad thing. I'm struggling a bit to understand why this is a bad thing, but perhaps I have not worked on any extremely complicated applications where it might be more obvious to understand the benefits.", ">Active Record vs Data Mapper\r\n>...\r\n>extremely complicated applications where it might be more obvious\r\n\r\nI think that's the reasoning. A mapped object may encompass multiple tables and is also more explicit about its relations. As you may be able to infer from Peewee's design, it's not really possible to do \"inheritance\" with multiple tables (Django allows this, but it is a vile hack IMO). Perhaps D/M makes more sense in a statically-typed language, as well.\r\n\r\nConsider also schema changes -- w/activerecord your model class must match the schema. With D/M I suppose you have a little bit more flexibility in being able to \"paper-over\" certain types of discrepancies.\r\n\r\nI prefer active record because I like to think in terms of the row tuples and thus the models as simply being handy containers for manipulating them.", "@coleifer Thank you for the insight." ]

"2021-04-25T21:50:43"

"2021-04-26T15:20:09"

"2021-04-26T00:17:00"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2396/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "xiaoqge", "id": 8544686, "node_id": "MDQ6VXNlcjg1NDQ2ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/8544686?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xiaoqge", "html_url": "https://github.com/xiaoqge", "followers_url": "https://api.github.com/users/xiaoqge/followers", "following_url": "https://api.github.com/users/xiaoqge/following{/other_user}", "gists_url": "https://api.github.com/users/xiaoqge/gists{/gist_id}", "starred_url": "https://api.github.com/users/xiaoqge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xiaoqge/subscriptions", "organizations_url": "https://api.github.com/users/xiaoqge/orgs", "repos_url": "https://api.github.com/users/xiaoqge/repos", "events_url": "https://api.github.com/users/xiaoqge/events{/privacy}", "received_events_url": "https://api.github.com/users/xiaoqge/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I don't know anything about TimescaleDB. Peewee supports anything that speaks the postgres protocol via the psycopg2 driver. If psycopg2 supports it, then its likely supported in peewee." ]

"2021-04-21T04:28:25"

"2021-04-24T17:12:17"

"2021-04-24T17:12:17"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2395/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "surajrav", "id": 8673958, "node_id": "MDQ6VXNlcjg2NzM5NTg=", "avatar_url": "https://avatars.githubusercontent.com/u/8673958?v=4", "gravatar_id": "", "url": "https://api.github.com/users/surajrav", "html_url": "https://github.com/surajrav", "followers_url": "https://api.github.com/users/surajrav/followers", "following_url": "https://api.github.com/users/surajrav/following{/other_user}", "gists_url": "https://api.github.com/users/surajrav/gists{/gist_id}", "starred_url": "https://api.github.com/users/surajrav/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/surajrav/subscriptions", "organizations_url": "https://api.github.com/users/surajrav/orgs", "repos_url": "https://api.github.com/users/surajrav/repos", "events_url": "https://api.github.com/users/surajrav/events{/privacy}", "received_events_url": "https://api.github.com/users/surajrav/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Prefetch is not designed as a replacement for serialization - it is to help reduce queries in certain cases. The complexity of mapping relations back to instances precludes providing different result-types (like dicts or tuples) -- so models are always returned. Any additional processing can then work on the model instances which have efficiently been loaded into memory.\r\n\r\n>But I'm afraid that this means 2 iterations over the desired set and want to know if I can supply this serializing logic via a hook or something.\r\n\r\nI doubt very much this is as much of a problem as you imagine. I'd suggest profiling if you're in doubt." ]

"2021-04-20T08:29:12"

"2021-04-20T13:50:41"

"2021-04-20T13:50:41"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "elya5", "id": 4464481, "node_id": "MDQ6VXNlcjQ0NjQ0ODE=", "avatar_url": "https://avatars.githubusercontent.com/u/4464481?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elya5", "html_url": "https://github.com/elya5", "followers_url": "https://api.github.com/users/elya5/followers", "following_url": "https://api.github.com/users/elya5/following{/other_user}", "gists_url": "https://api.github.com/users/elya5/gists{/gist_id}", "starred_url": "https://api.github.com/users/elya5/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elya5/subscriptions", "organizations_url": "https://api.github.com/users/elya5/orgs", "repos_url": "https://api.github.com/users/elya5/repos", "events_url": "https://api.github.com/users/elya5/events{/privacy}", "received_events_url": "https://api.github.com/users/elya5/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The bulk create API doesn't set the fk value automatically.\r\n\r\nJust wrap it in a transaction and it will be plenty fast." ]

"2021-04-19T09:40:43"

"2021-04-19T12:57:28"

"2021-04-19T12:57:28"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2393/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "TimothyBramlett", "id": 7890441, "node_id": "MDQ6VXNlcjc4OTA0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/7890441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TimothyBramlett", "html_url": "https://github.com/TimothyBramlett", "followers_url": "https://api.github.com/users/TimothyBramlett/followers", "following_url": "https://api.github.com/users/TimothyBramlett/following{/other_user}", "gists_url": "https://api.github.com/users/TimothyBramlett/gists{/gist_id}", "starred_url": "https://api.github.com/users/TimothyBramlett/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TimothyBramlett/subscriptions", "organizations_url": "https://api.github.com/users/TimothyBramlett/orgs", "repos_url": "https://api.github.com/users/TimothyBramlett/repos", "events_url": "https://api.github.com/users/TimothyBramlett/events{/privacy}", "received_events_url": "https://api.github.com/users/TimothyBramlett/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Please post questions to stackoverflow.\r\n\r\n```python\r\nsome_field = ArrayField(CharField, field_kwargs={'max_length': 20}, null=True)\r\n```\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/playhouse.html#ArrayField" ]

"2021-04-19T03:54:39"

"2021-04-19T12:51:12"

"2021-04-19T12:51:12"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2392/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mikemill", "id": 1652125, "node_id": "MDQ6VXNlcjE2NTIxMjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1652125?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikemill", "html_url": "https://github.com/mikemill", "followers_url": "https://api.github.com/users/mikemill/followers", "following_url": "https://api.github.com/users/mikemill/following{/other_user}", "gists_url": "https://api.github.com/users/mikemill/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikemill/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikemill/subscriptions", "organizations_url": "https://api.github.com/users/mikemill/orgs", "repos_url": "https://api.github.com/users/mikemill/repos", "events_url": "https://api.github.com/users/mikemill/events{/privacy}", "received_events_url": "https://api.github.com/users/mikemill/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The patch looks fine, but I have tried to stay away from that particular pandora's box. In the simple case it's straightforward, but it breaks the backref abstraction a bit, and there are just a few too many edge-cases. I prefer to keep it as a naive/simple `Select`.\r\n\r\nIf you really want this in your own app, I've pushed a patch 626b34856eeb842ad27c885f3c1fba95cce78399 that allows you to override the backref accessor class on your foreign-keys - making it hopefully easier to extend and use your own implementation." ]

"2021-04-16T20:40:14"

"2021-04-17T01:45:00"

"2021-04-16T23:43:17"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2391/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2391", "html_url": "https://github.com/coleifer/peewee/pull/2391", "diff_url": "https://github.com/coleifer/peewee/pull/2391.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2391.patch", "merged_at": null }

{ "login": "websterek", "id": 40537787, "node_id": "MDQ6VXNlcjQwNTM3Nzg3", "avatar_url": "https://avatars.githubusercontent.com/u/40537787?v=4", "gravatar_id": "", "url": "https://api.github.com/users/websterek", "html_url": "https://github.com/websterek", "followers_url": "https://api.github.com/users/websterek/followers", "following_url": "https://api.github.com/users/websterek/following{/other_user}", "gists_url": "https://api.github.com/users/websterek/gists{/gist_id}", "starred_url": "https://api.github.com/users/websterek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/websterek/subscriptions", "organizations_url": "https://api.github.com/users/websterek/orgs", "repos_url": "https://api.github.com/users/websterek/repos", "events_url": "https://api.github.com/users/websterek/events{/privacy}", "received_events_url": "https://api.github.com/users/websterek/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The code you've highlighted is setting attributes dynamically onto an object, and this is a fairly fundamental thing to Peewee's operation. Possibly this is being prevented because these attributes correspond with the field instances declared on the model class? At any rate, this seems to be something you should bring up with the author of the python implementation you're attempting to use." ]

"2021-04-13T20:05:23"

"2021-04-13T21:27:42"

"2021-04-13T21:27:42"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2390/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "NeroNekro", "id": 36452325, "node_id": "MDQ6VXNlcjM2NDUyMzI1", "avatar_url": "https://avatars.githubusercontent.com/u/36452325?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NeroNekro", "html_url": "https://github.com/NeroNekro", "followers_url": "https://api.github.com/users/NeroNekro/followers", "following_url": "https://api.github.com/users/NeroNekro/following{/other_user}", "gists_url": "https://api.github.com/users/NeroNekro/gists{/gist_id}", "starred_url": "https://api.github.com/users/NeroNekro/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NeroNekro/subscriptions", "organizations_url": "https://api.github.com/users/NeroNekro/orgs", "repos_url": "https://api.github.com/users/NeroNekro/repos", "events_url": "https://api.github.com/users/NeroNekro/events{/privacy}", "received_events_url": "https://api.github.com/users/NeroNekro/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Sorry, I'm not familiar with fastapi but presumably it's something to do with sharing connections across threads or processes or some other asyncio-related issue." ]

"2021-04-07T13:10:46"

"2021-04-07T13:26:49"

"2021-04-07T13:26:49"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2389/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rokel", "id": 6145874, "node_id": "MDQ6VXNlcjYxNDU4NzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6145874?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rokel", "html_url": "https://github.com/rokel", "followers_url": "https://api.github.com/users/rokel/followers", "following_url": "https://api.github.com/users/rokel/following{/other_user}", "gists_url": "https://api.github.com/users/rokel/gists{/gist_id}", "starred_url": "https://api.github.com/users/rokel/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rokel/subscriptions", "organizations_url": "https://api.github.com/users/rokel/orgs", "repos_url": "https://api.github.com/users/rokel/repos", "events_url": "https://api.github.com/users/rokel/events{/privacy}", "received_events_url": "https://api.github.com/users/rokel/received_events", "type": "User", "site_admin": false }

[]

[]

[ "So first of all: by default peewee stores connection state in a threadlocal. This means each thread has its own connection. Hooks are specific to the connection they are registered on -- peewee takes care of registering them, but just fyi that's how it works.\r\n\r\nSecond of all: sqlite cannot accept writes from multiple threads, and unless you're using WAL mode, readers cannot coexist with a writer.\r\n\r\nThird of all: because of the gil, only one python thread can be running at any given time.\r\n\r\nSo using multiple threads with Sqlite is sometimes a misguided effort unless you have a compelling reason.\r\n\r\nAll that being said, I was able to reproduce a segfault and have a fix ready you can try.", "Thanks for the quick response, and for the additional info. I would like to avoid using threads but it's the concurrency model I've inherited from the service lib I'm using (gRPC), and is largely I/O bound so doesn't suffer too much from the GIL I think. I could segregate it off and add another layer inbetween to serialise db access though, but worried about the boilerplate that might entail. Writes are pretty rare for my application at the moment so I'm hoping I can avoid using WAL; trying to avoid multiple files due to use as an application file format.\r\n\r\nI pulled 5a55993 and built with `pip install --no-cache-dir ---globaloption=build_ext .` but still get the crash with the test script above. Nevertheless I've tested the 'separate `CSqliteExtDatabase` instance & hooks per-thread' approach and that seems viable so far...\r\n\r\n", "Are you able to get a backtrace? I was able to reproduce a segfault using a slightly different approach and resolved the issue (which had to do with attempting to unregister the hook when the underlying sqlite3 pointer was NULL) - and this is the issue that I patched." ]

"2021-04-06T08:40:37"

"2021-04-06T18:41:35"

"2021-04-06T13:35:08"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "scjoiner", "id": 4303855, "node_id": "MDQ6VXNlcjQzMDM4NTU=", "avatar_url": "https://avatars.githubusercontent.com/u/4303855?v=4", "gravatar_id": "", "url": "https://api.github.com/users/scjoiner", "html_url": "https://github.com/scjoiner", "followers_url": "https://api.github.com/users/scjoiner/followers", "following_url": "https://api.github.com/users/scjoiner/following{/other_user}", "gists_url": "https://api.github.com/users/scjoiner/gists{/gist_id}", "starred_url": "https://api.github.com/users/scjoiner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/scjoiner/subscriptions", "organizations_url": "https://api.github.com/users/scjoiner/orgs", "repos_url": "https://api.github.com/users/scjoiner/repos", "events_url": "https://api.github.com/users/scjoiner/events{/privacy}", "received_events_url": "https://api.github.com/users/scjoiner/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Sounds like an issue in your db driver. That error is being propagated up from whatever driver you're using. Presumably you upgraded something else in addition to just peewee. You can diff the last working version with 3.14.4 and see if anything jumps out at you, but it seems unlikely to me." ]

"2021-04-05T14:22:46"

"2021-04-05T21:29:53"

"2021-04-05T21:29:53"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2387/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bronte2k7", "id": 29693866, "node_id": "MDQ6VXNlcjI5NjkzODY2", "avatar_url": "https://avatars.githubusercontent.com/u/29693866?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bronte2k7", "html_url": "https://github.com/bronte2k7", "followers_url": "https://api.github.com/users/bronte2k7/followers", "following_url": "https://api.github.com/users/bronte2k7/following{/other_user}", "gists_url": "https://api.github.com/users/bronte2k7/gists{/gist_id}", "starred_url": "https://api.github.com/users/bronte2k7/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bronte2k7/subscriptions", "organizations_url": "https://api.github.com/users/bronte2k7/orgs", "repos_url": "https://api.github.com/users/bronte2k7/repos", "events_url": "https://api.github.com/users/bronte2k7/events{/privacy}", "received_events_url": "https://api.github.com/users/bronte2k7/received_events", "type": "User", "site_admin": false }

[]

[]

[ "http://docs.peewee-orm.com/en/latest/peewee/playhouse.html#model_to_dict\r\n\r\n>exclude – A list (or set) of field instances which should be excluded from the result dictionary.\r\n\r\nYou need to pass the field instance.", "I do not understand something. Please show me an example. I have already tried it in different ways))) ", "Going forward, please post questions to stackoverflow.\r\n\r\n>example\r\n\r\n```python\r\naccount = model_to_dict(account, exclude=[Account.password])\r\n```", "thank you!" ]

"2021-04-05T09:32:04"

"2022-09-24T13:26:51"

"2021-04-05T23:35:37"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2386/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aiqc", "id": 74990642, "node_id": "MDQ6VXNlcjc0OTkwNjQy", "avatar_url": "https://avatars.githubusercontent.com/u/74990642?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aiqc", "html_url": "https://github.com/aiqc", "followers_url": "https://api.github.com/users/aiqc/followers", "following_url": "https://api.github.com/users/aiqc/following{/other_user}", "gists_url": "https://api.github.com/users/aiqc/gists{/gist_id}", "starred_url": "https://api.github.com/users/aiqc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aiqc/subscriptions", "organizations_url": "https://api.github.com/users/aiqc/orgs", "repos_url": "https://api.github.com/users/aiqc/repos", "events_url": "https://api.github.com/users/aiqc/events{/privacy}", "received_events_url": "https://api.github.com/users/aiqc/received_events", "type": "User", "site_admin": false }

[]

[]

[ "`playhouse.fields`\r\nhttps://github.com/coleifer/peewee/blob/a8938588c00ae7ef94f453b8873820419474b4ce/playhouse/fields.py\r\n\r\n`tests.extra_fields`\r\nhttps://github.com/coleifer/peewee/blob/a8938588c00ae7ef94f453b8873820419474b4ce/playhouse/fields.py\r\n", "You're welcome to package this up as your own extension module, but I try to stay within the stdlib where possible." ]

"2021-04-03T22:20:13"

"2021-04-04T01:13:23"

"2021-04-04T01:13:23"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2385/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Helveg", "id": 28923979, "node_id": "MDQ6VXNlcjI4OTIzOTc5", "avatar_url": "https://avatars.githubusercontent.com/u/28923979?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Helveg", "html_url": "https://github.com/Helveg", "followers_url": "https://api.github.com/users/Helveg/followers", "following_url": "https://api.github.com/users/Helveg/following{/other_user}", "gists_url": "https://api.github.com/users/Helveg/gists{/gist_id}", "starred_url": "https://api.github.com/users/Helveg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Helveg/subscriptions", "organizations_url": "https://api.github.com/users/Helveg/orgs", "repos_url": "https://api.github.com/users/Helveg/repos", "events_url": "https://api.github.com/users/Helveg/events{/privacy}", "received_events_url": "https://api.github.com/users/Helveg/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Eh I'll need to look into this some more - not urgent." ]

"2021-04-03T07:22:47"

"2021-04-03T17:41:35"

"2021-04-03T17:41:35"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2384/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2384", "html_url": "https://github.com/coleifer/peewee/pull/2384", "diff_url": "https://github.com/coleifer/peewee/pull/2384.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2384.patch", "merged_at": null }

{ "login": "Helveg", "id": 28923979, "node_id": "MDQ6VXNlcjI4OTIzOTc5", "avatar_url": "https://avatars.githubusercontent.com/u/28923979?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Helveg", "html_url": "https://github.com/Helveg", "followers_url": "https://api.github.com/users/Helveg/followers", "following_url": "https://api.github.com/users/Helveg/following{/other_user}", "gists_url": "https://api.github.com/users/Helveg/gists{/gist_id}", "starred_url": "https://api.github.com/users/Helveg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Helveg/subscriptions", "organizations_url": "https://api.github.com/users/Helveg/orgs", "repos_url": "https://api.github.com/users/Helveg/repos", "events_url": "https://api.github.com/users/Helveg/events{/privacy}", "received_events_url": "https://api.github.com/users/Helveg/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2021-04-03T07:20:11"

"2021-04-03T17:41:28"

"2021-04-03T17:41:28"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2383/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ilyakamens", "id": 3293811, "node_id": "MDQ6VXNlcjMyOTM4MTE=", "avatar_url": "https://avatars.githubusercontent.com/u/3293811?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ilyakamens", "html_url": "https://github.com/ilyakamens", "followers_url": "https://api.github.com/users/ilyakamens/followers", "following_url": "https://api.github.com/users/ilyakamens/following{/other_user}", "gists_url": "https://api.github.com/users/ilyakamens/gists{/gist_id}", "starred_url": "https://api.github.com/users/ilyakamens/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ilyakamens/subscriptions", "organizations_url": "https://api.github.com/users/ilyakamens/orgs", "repos_url": "https://api.github.com/users/ilyakamens/repos", "events_url": "https://api.github.com/users/ilyakamens/events{/privacy}", "received_events_url": "https://api.github.com/users/ilyakamens/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for the patch, looks good and merged." ]

"2021-04-02T00:50:29"

"2021-04-02T16:27:04"

"2021-04-02T13:51:37"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2382/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2382", "html_url": "https://github.com/coleifer/peewee/pull/2382", "diff_url": "https://github.com/coleifer/peewee/pull/2382.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2382.patch", "merged_at": "2021-04-02T13:51:37" }

{ "login": "leshphonc", "id": 24892968, "node_id": "MDQ6VXNlcjI0ODkyOTY4", "avatar_url": "https://avatars.githubusercontent.com/u/24892968?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leshphonc", "html_url": "https://github.com/leshphonc", "followers_url": "https://api.github.com/users/leshphonc/followers", "following_url": "https://api.github.com/users/leshphonc/following{/other_user}", "gists_url": "https://api.github.com/users/leshphonc/gists{/gist_id}", "starred_url": "https://api.github.com/users/leshphonc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leshphonc/subscriptions", "organizations_url": "https://api.github.com/users/leshphonc/orgs", "repos_url": "https://api.github.com/users/leshphonc/repos", "events_url": "https://api.github.com/users/leshphonc/events{/privacy}", "received_events_url": "https://api.github.com/users/leshphonc/received_events", "type": "User", "site_admin": false }

[]

[]

[ "是我用法的问题吗，请帮帮我", "我本地运行是没问题的，放到服务器上就获取不到count了", "Do not call `.execute()` before count().\r\n\r\nExecute gives you a cursor iterator, not a composable query object.", "```python\r\n\r\n# This gives us a query object.\r\nquery = User.select().where(User.status == 0)\r\n\r\n# Executes a SELECT COUNT(*)\r\ncount = query.count()\r\n\r\n# Not necessary to explicitly call .execute() - as iterating over\r\n# a select query implicitly executes it.\r\nfor user in query:\r\n ...\r\n```" ]

"2021-04-01T09:16:30"

"2021-04-01T13:49:12"

"2021-04-01T12:02:18"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2381/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "imba-tjd", "id": 24759802, "node_id": "MDQ6VXNlcjI0NzU5ODAy", "avatar_url": "https://avatars.githubusercontent.com/u/24759802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/imba-tjd", "html_url": "https://github.com/imba-tjd", "followers_url": "https://api.github.com/users/imba-tjd/followers", "following_url": "https://api.github.com/users/imba-tjd/following{/other_user}", "gists_url": "https://api.github.com/users/imba-tjd/gists{/gist_id}", "starred_url": "https://api.github.com/users/imba-tjd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imba-tjd/subscriptions", "organizations_url": "https://api.github.com/users/imba-tjd/orgs", "repos_url": "https://api.github.com/users/imba-tjd/repos", "events_url": "https://api.github.com/users/imba-tjd/events{/privacy}", "received_events_url": "https://api.github.com/users/imba-tjd/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2021-03-26T12:51:11"

"2021-03-26T13:05:34"

"2021-03-26T13:05:34"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2380/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2380", "html_url": "https://github.com/coleifer/peewee/pull/2380", "diff_url": "https://github.com/coleifer/peewee/pull/2380.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2380.patch", "merged_at": null }

{ "login": "arjd", "id": 20357504, "node_id": "MDQ6VXNlcjIwMzU3NTA0", "avatar_url": "https://avatars.githubusercontent.com/u/20357504?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arjd", "html_url": "https://github.com/arjd", "followers_url": "https://api.github.com/users/arjd/followers", "following_url": "https://api.github.com/users/arjd/following{/other_user}", "gists_url": "https://api.github.com/users/arjd/gists{/gist_id}", "starred_url": "https://api.github.com/users/arjd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arjd/subscriptions", "organizations_url": "https://api.github.com/users/arjd/orgs", "repos_url": "https://api.github.com/users/arjd/repos", "events_url": "https://api.github.com/users/arjd/events{/privacy}", "received_events_url": "https://api.github.com/users/arjd/received_events", "type": "User", "site_admin": false }

[]

[]

[ "What is the intent of such a construction? Using the database as context manager implies you wish to close the database when it exits. Peewee is correctly telling you it cannot close the database because you have explicitly requested a transaction.\r\n\r\nNot a bug, in my opinion." ]

"2021-03-23T22:22:00"

"2021-03-24T13:20:09"

"2021-03-24T13:20:09"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2379/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "0scarius", "id": 7230152, "node_id": "MDQ6VXNlcjcyMzAxNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/7230152?v=4", "gravatar_id": "", "url": "https://api.github.com/users/0scarius", "html_url": "https://github.com/0scarius", "followers_url": "https://api.github.com/users/0scarius/followers", "following_url": "https://api.github.com/users/0scarius/following{/other_user}", "gists_url": "https://api.github.com/users/0scarius/gists{/gist_id}", "starred_url": "https://api.github.com/users/0scarius/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/0scarius/subscriptions", "organizations_url": "https://api.github.com/users/0scarius/orgs", "repos_url": "https://api.github.com/users/0scarius/repos", "events_url": "https://api.github.com/users/0scarius/events{/privacy}", "received_events_url": "https://api.github.com/users/0scarius/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Erroneous... wrong place" ]

"2021-03-22T23:52:17"

"2021-03-23T00:14:25"

"2021-03-23T00:10:42"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2378/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "AndBondStyle", "id": 18560701, "node_id": "MDQ6VXNlcjE4NTYwNzAx", "avatar_url": "https://avatars.githubusercontent.com/u/18560701?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AndBondStyle", "html_url": "https://github.com/AndBondStyle", "followers_url": "https://api.github.com/users/AndBondStyle/followers", "following_url": "https://api.github.com/users/AndBondStyle/following{/other_user}", "gists_url": "https://api.github.com/users/AndBondStyle/gists{/gist_id}", "starred_url": "https://api.github.com/users/AndBondStyle/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AndBondStyle/subscriptions", "organizations_url": "https://api.github.com/users/AndBondStyle/orgs", "repos_url": "https://api.github.com/users/AndBondStyle/repos", "events_url": "https://api.github.com/users/AndBondStyle/events{/privacy}", "received_events_url": "https://api.github.com/users/AndBondStyle/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looks like a regression related to #2328", "Actually scratch that - this is not a regression. There doesn't seem to be a reliable way of differentiating between a model instance you have explicitly chosen *not* to select the foreign-key value and a model instance that is missing a non-null foreign-key. Lazy-load really deals with converting a foreign-key value (e.g. integer id) into a full object.", "That being said, I agree that the error is misplaced and this should just return `None` if lazy-load has been disabled. I've made the patch as you suggested." ]

"2021-03-20T14:41:41"

"2021-03-20T18:29:33"

"2021-03-20T18:29:31"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2377/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "vaniakov", "id": 8692788, "node_id": "MDQ6VXNlcjg2OTI3ODg=", "avatar_url": "https://avatars.githubusercontent.com/u/8692788?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vaniakov", "html_url": "https://github.com/vaniakov", "followers_url": "https://api.github.com/users/vaniakov/followers", "following_url": "https://api.github.com/users/vaniakov/following{/other_user}", "gists_url": "https://api.github.com/users/vaniakov/gists{/gist_id}", "starred_url": "https://api.github.com/users/vaniakov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vaniakov/subscriptions", "organizations_url": "https://api.github.com/users/vaniakov/orgs", "repos_url": "https://api.github.com/users/vaniakov/repos", "events_url": "https://api.github.com/users/vaniakov/events{/privacy}", "received_events_url": "https://api.github.com/users/vaniakov/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for the succinct report and isolating the problematic changeset. No, this was a regression that I didn't foresee. I've patched this and will issue a new release.", "This is fixed and I've tagged a new version 3.14.4, which contains the fix and additional tests.", "@coleifer Thank you for such quick response and fix!" ]

"2021-03-18T16:16:25"

"2021-03-19T15:58:25"

"2021-03-19T15:55:30"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2376/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "NightMachinery", "id": 36224762, "node_id": "MDQ6VXNlcjM2MjI0NzYy", "avatar_url": "https://avatars.githubusercontent.com/u/36224762?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NightMachinery", "html_url": "https://github.com/NightMachinery", "followers_url": "https://api.github.com/users/NightMachinery/followers", "following_url": "https://api.github.com/users/NightMachinery/following{/other_user}", "gists_url": "https://api.github.com/users/NightMachinery/gists{/gist_id}", "starred_url": "https://api.github.com/users/NightMachinery/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NightMachinery/subscriptions", "organizations_url": "https://api.github.com/users/NightMachinery/orgs", "repos_url": "https://api.github.com/users/NightMachinery/repos", "events_url": "https://api.github.com/users/NightMachinery/events{/privacy}", "received_events_url": "https://api.github.com/users/NightMachinery/received_events", "type": "User", "site_admin": false }

[]

[]

[ "No, this is not something that is supported in Peewee.", "@coleifer I just thought about simply setting `model.save = None`. I think this will be enough to prevent me from shooting myself in the foot later ...", "You would also want to lock-down the update, delete, delete_instance, etc, etc, presumably. If you're using sqlite it's possible to set the connection read-only and may be ways to do this with other databases as well. That's what I would look into. Or even adding a read-only user to your db and connecting with that user." ]

"2021-03-17T20:59:30"

"2021-03-18T00:14:21"

"2021-03-17T21:26:39"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2375/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aferrari94", "id": 70535738, "node_id": "MDQ6VXNlcjcwNTM1NzM4", "avatar_url": "https://avatars.githubusercontent.com/u/70535738?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aferrari94", "html_url": "https://github.com/aferrari94", "followers_url": "https://api.github.com/users/aferrari94/followers", "following_url": "https://api.github.com/users/aferrari94/following{/other_user}", "gists_url": "https://api.github.com/users/aferrari94/gists{/gist_id}", "starred_url": "https://api.github.com/users/aferrari94/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aferrari94/subscriptions", "organizations_url": "https://api.github.com/users/aferrari94/orgs", "repos_url": "https://api.github.com/users/aferrari94/repos", "events_url": "https://api.github.com/users/aferrari94/events{/privacy}", "received_events_url": "https://api.github.com/users/aferrari94/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2021-03-17T13:43:18"

"2021-03-17T13:59:54"

"2021-03-17T13:59:54"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2374/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "hrekov", "id": 41489462, "node_id": "MDQ6VXNlcjQxNDg5NDYy", "avatar_url": "https://avatars.githubusercontent.com/u/41489462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hrekov", "html_url": "https://github.com/hrekov", "followers_url": "https://api.github.com/users/hrekov/followers", "following_url": "https://api.github.com/users/hrekov/following{/other_user}", "gists_url": "https://api.github.com/users/hrekov/gists{/gist_id}", "starred_url": "https://api.github.com/users/hrekov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hrekov/subscriptions", "organizations_url": "https://api.github.com/users/hrekov/orgs", "repos_url": "https://api.github.com/users/hrekov/repos", "events_url": "https://api.github.com/users/hrekov/events{/privacy}", "received_events_url": "https://api.github.com/users/hrekov/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The problem is a bad manifestation of a bug that occurs when you have a field named \"model\". I probably need to make Peewee raise an error if this occurs, but this fixes things:\r\n\r\n```python\r\n\r\nclass Car(Model):\r\n model_ = CharField(column_name='model', max_length=50, unique=True)\r\n ...\r\n```", "Thanks. That's worked" ]

"2021-03-15T16:12:25"

"2021-03-15T17:00:57"

"2021-03-15T16:50:52"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2373/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "induane", "id": 2320029, "node_id": "MDQ6VXNlcjIzMjAwMjk=", "avatar_url": "https://avatars.githubusercontent.com/u/2320029?v=4", "gravatar_id": "", "url": "https://api.github.com/users/induane", "html_url": "https://github.com/induane", "followers_url": "https://api.github.com/users/induane/followers", "following_url": "https://api.github.com/users/induane/following{/other_user}", "gists_url": "https://api.github.com/users/induane/gists{/gist_id}", "starred_url": "https://api.github.com/users/induane/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/induane/subscriptions", "organizations_url": "https://api.github.com/users/induane/orgs", "repos_url": "https://api.github.com/users/induane/repos", "events_url": "https://api.github.com/users/induane/events{/privacy}", "received_events_url": "https://api.github.com/users/induane/received_events", "type": "User", "site_admin": false }

[]

[]

[ "There are two ways you might look at doing this:\r\n\r\n1. re-bind the `SqliteDatabase` instance to a different database file\r\n2. re-bind the models to a different `SqliteDatabase` instance\r\n\r\nI'm not aware of any patterns for doing this an arbitrary number of times at run-time, so you'll have to piece it together for yourself a bit.\r\n\r\nProbably the easiest will be #1 since there are fewer moving parts. If you're connecting from multiple threads, because Peewee stores connection state in a thread-local, you'll have to ensure all threads close their connections when you switch database. It seems unlikely you would have connections open across threads, because of sqlite's write locking, but something to watch out for.\r\n\r\nThe only thing that would make me not consider option 1 is if you need to be switching back and forth between databases. In that case you might want to keep the db instances around and rebind the models between them.\r\n\r\nYou can re-initialize the database instance like this (option 1):\r\n\r\n```python\r\n\r\ndb = SqliteDatabase(None) # database is not initialized.\r\n\r\n# db is \"initialized\" - when you call connect() it will use\r\n# /tmp/db1.db\r\ndb.init('/tmp/db1.db')\r\n...\r\n# re-initialize db. if the calling thread has an open connection,\r\n# it is closed. subsequent connections will use /tmp/db2.db.\r\ndb.init('/tmp/db2.db')\r\n```\r\n\r\nRebinding models to a different database instance, as well as general db configuration stuff, is covered in the following links:\r\n\r\n* http://docs.peewee-orm.com/en/latest/peewee/database.html#setting-the-database-at-run-time\r\n* http://docs.peewee-orm.com/en/latest/peewee/database.html#run-time-database-configuration\r\n* http://docs.peewee-orm.com/en/latest/peewee/database.html#testing-peewee-applications - covers re-binding models for testing purposes\r\n\r\nI'm not likely to make any changes in the database apis or connection handling implementation, for what it's worth. ", "Dang you're quick on the response!\r\n\r\nIt has proved fairly tricky to have multiple active document instances and switching the models DB attribute.\r\n\r\nMy first approach was a decorator I applied to all methods in the document class that called db.init(self.file_path) but that was pretty cumbersome and I was able to break it with subprocesses where I was doing large numbers of updates to different documents in parallel (which seemed like a good approach as it was mostly io bound).\r\n\r\nMaybe the right approach is a custom proxy object of some kind that pulls connections from storage on thread local or something. I'll tinker around further." ]

"2021-03-10T17:42:11"

"2021-03-10T18:58:11"

"2021-03-10T18:03:57"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2372/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mouday", "id": 24365682, "node_id": "MDQ6VXNlcjI0MzY1Njgy", "avatar_url": "https://avatars.githubusercontent.com/u/24365682?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mouday", "html_url": "https://github.com/mouday", "followers_url": "https://api.github.com/users/mouday/followers", "following_url": "https://api.github.com/users/mouday/following{/other_user}", "gists_url": "https://api.github.com/users/mouday/gists{/gist_id}", "starred_url": "https://api.github.com/users/mouday/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mouday/subscriptions", "organizations_url": "https://api.github.com/users/mouday/orgs", "repos_url": "https://api.github.com/users/mouday/repos", "events_url": "https://api.github.com/users/mouday/events{/privacy}", "received_events_url": "https://api.github.com/users/mouday/received_events", "type": "User", "site_admin": false }

[]

[]

[ "it's my logic not clean! not a bug. \r\n\r\nthis code is ok.\r\n\r\n```python\r\nrow = (LibProductDataModel\r\n .select()\r\n .where((LibProductDataModel.product == product_or_company)\r\n | (LibProductDataModel.company == product_or_company))\r\n .first())\r\n\r\n```\r\n" ]

"2021-03-10T07:31:35"

"2021-03-10T09:08:32"

"2021-03-10T09:08:32"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2371/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mouday", "id": 24365682, "node_id": "MDQ6VXNlcjI0MzY1Njgy", "avatar_url": "https://avatars.githubusercontent.com/u/24365682?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mouday", "html_url": "https://github.com/mouday", "followers_url": "https://api.github.com/users/mouday/followers", "following_url": "https://api.github.com/users/mouday/following{/other_user}", "gists_url": "https://api.github.com/users/mouday/gists{/gist_id}", "starred_url": "https://api.github.com/users/mouday/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mouday/subscriptions", "organizations_url": "https://api.github.com/users/mouday/orgs", "repos_url": "https://api.github.com/users/mouday/repos", "events_url": "https://api.github.com/users/mouday/events{/privacy}", "received_events_url": "https://api.github.com/users/mouday/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee can log all queries. This is documented:\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/database.html#logging-queries\r\n\r\nIf you want to know the sql only for a particular query you can use the `.sql()` method of the query object.\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/api.html#BaseQuery.sql", "> Peewee can log all queries. This is documented:\r\n> \r\n> http://docs.peewee-orm.com/en/latest/peewee/database.html#logging-queries\r\n> \r\n> If you want to know the sql only for a particular query you can use the `.sql()` method of the query object.\r\n> \r\n> http://docs.peewee-orm.com/en/latest/peewee/api.html#BaseQuery.sql\r\n\r\nI known ， but i want to see execute time and execute sql\r\n\r\nlike\r\n```\r\ntime: 347.00 ms\r\n```", "You can try monkey-patching `Database.execute_sql()` or subclass your database implementation and override the `execute_sql()` method to add timing information.", "> You can try monkey-patching `Database.execute_sql()` or subclass your database implementation and override the `execute_sql()` method to add timing information.\r\n\r\nthank you, i impl code as :\r\n```python\r\n# -*- coding: utf-8 -*-\r\n\r\nimport math\r\nimport time\r\nfrom functools import wraps\r\n\r\nfrom peewee import MySQLDatabase\r\n\r\nimport logging\r\n\r\n\r\nlogger = logging.getLogger('peewee')\r\n\r\ndef timer(func):\r\n @wraps(func)\r\n def wrapper(*args, **kwargs):\r\n start_time = time.time() * 1000\r\n ret = func(*args, **kwargs)\r\n end_time = time.time() * 1000\r\n logger.debug(\"time: %.2f ms\" % math.ceil(end_time - start_time))\r\n return ret\r\n\r\n return wrapper\r\n\r\n\r\nclass CustomMySQLDatabase(MySQLDatabase):\r\n @timer\r\n def execute_sql(self, sql, params=None, commit=SENTINEL):\r\n return super().execute_sql(sql, params, commit)\r\n\r\n\r\n```", "Just a suggestion: you might try using something like this for the start/end timings:\r\n\r\nhttps://docs.python.org/3.9/library/time.html#time.perf_counter", "> Just a suggestion: you might try using something like this for the start/end timings:\r\n> \r\n> https://docs.python.org/3.9/library/time.html#time.perf_counter\r\n\r\nthank you!" ]

"2021-03-10T02:35:56"

"2021-03-10T03:33:48"

"2021-03-10T02:43:26"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2370/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rafal-jaworski", "id": 28957750, "node_id": "MDQ6VXNlcjI4OTU3NzUw", "avatar_url": "https://avatars.githubusercontent.com/u/28957750?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rafal-jaworski", "html_url": "https://github.com/rafal-jaworski", "followers_url": "https://api.github.com/users/rafal-jaworski/followers", "following_url": "https://api.github.com/users/rafal-jaworski/following{/other_user}", "gists_url": "https://api.github.com/users/rafal-jaworski/gists{/gist_id}", "starred_url": "https://api.github.com/users/rafal-jaworski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rafal-jaworski/subscriptions", "organizations_url": "https://api.github.com/users/rafal-jaworski/orgs", "repos_url": "https://api.github.com/users/rafal-jaworski/repos", "events_url": "https://api.github.com/users/rafal-jaworski/events{/privacy}", "received_events_url": "https://api.github.com/users/rafal-jaworski/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I've merged an equivalent patch. Thanks!" ]

"2021-03-05T12:05:56"

"2021-03-05T14:36:49"

"2021-03-05T14:36:49"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2369/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2369", "html_url": "https://github.com/coleifer/peewee/pull/2369", "diff_url": "https://github.com/coleifer/peewee/pull/2369.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2369.patch", "merged_at": null }

{ "login": "rafal-jaworski", "id": 28957750, "node_id": "MDQ6VXNlcjI4OTU3NzUw", "avatar_url": "https://avatars.githubusercontent.com/u/28957750?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rafal-jaworski", "html_url": "https://github.com/rafal-jaworski", "followers_url": "https://api.github.com/users/rafal-jaworski/followers", "following_url": "https://api.github.com/users/rafal-jaworski/following{/other_user}", "gists_url": "https://api.github.com/users/rafal-jaworski/gists{/gist_id}", "starred_url": "https://api.github.com/users/rafal-jaworski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rafal-jaworski/subscriptions", "organizations_url": "https://api.github.com/users/rafal-jaworski/orgs", "repos_url": "https://api.github.com/users/rafal-jaworski/repos", "events_url": "https://api.github.com/users/rafal-jaworski/events{/privacy}", "received_events_url": "https://api.github.com/users/rafal-jaworski/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks, this is fixed now.", "@coleifer Thanks! Could you release a new version with this fix? :)", "3.14.3", "Hey Im still having this issue, and i dont know how to solve it. ", "Works fine for me:\r\n\r\n```python\r\nclass Reg(Model):\r\n key = TextField()\r\n value = IntegerField(null=True)\r\n class Meta:\r\n database = db\r\n\r\ndb.create_tables([Reg])\r\n\r\nl1 = [{'key': 'k1', 'value': None}, {'key': 'k2'}, {'key': 'k3', 'value': 3}]\r\nl2 = [{'key': 'k4'}, {'key': 'k5', 'value': None}, {'key': 'k6', 'value': 6}]\r\n\r\nReg.insert_many(l1, fields=['key', 'value']).execute()\r\nReg.insert_many(l2, fields=['key', 'value']).execute()\r\n\r\nfor r in Reg.select().order_by(Reg.key):\r\n print(r.key, r.value)\r\n# k1 None\r\n# k2 None\r\n# k3 3\r\n# k4 None\r\n# k5 None\r\n# k6 6\r\n```\r\n\r\nIf you don't specify `fields` it will just infer the fields you want from the *first* dict in the list of rows to insert. Alternatively, you can of course provide row tuples.\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/querying.html#bulk-inserts", "You re rigth, the error was mine." ]

"2021-03-05T11:46:39"

"2021-10-28T21:23:55"

"2021-03-05T14:36:35"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2368/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zhuyanxi", "id": 4001245, "node_id": "MDQ6VXNlcjQwMDEyNDU=", "avatar_url": "https://avatars.githubusercontent.com/u/4001245?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhuyanxi", "html_url": "https://github.com/zhuyanxi", "followers_url": "https://api.github.com/users/zhuyanxi/followers", "following_url": "https://api.github.com/users/zhuyanxi/following{/other_user}", "gists_url": "https://api.github.com/users/zhuyanxi/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhuyanxi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhuyanxi/subscriptions", "organizations_url": "https://api.github.com/users/zhuyanxi/orgs", "repos_url": "https://api.github.com/users/zhuyanxi/repos", "events_url": "https://api.github.com/users/zhuyanxi/events{/privacy}", "received_events_url": "https://api.github.com/users/zhuyanxi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "If you had spent your time investigating rather than posting this issue, you would find:\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/database.html#connection-management\r\n\r\nIf you want to reuse a connection, then you should use the connection pool, which is mentioned in the above document and also extensively documented:\r\n\r\n* http://docs.peewee-orm.com/en/latest/peewee/database.html#connection-pooling\r\n* http://docs.peewee-orm.com/en/latest/peewee/playhouse.html#pool" ]

"2021-03-05T11:23:17"

"2021-03-05T14:18:01"

"2021-03-05T14:17:48"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2367/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "the-vindicar", "id": 2130028, "node_id": "MDQ6VXNlcjIxMzAwMjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2130028?v=4", "gravatar_id": "", "url": "https://api.github.com/users/the-vindicar", "html_url": "https://github.com/the-vindicar", "followers_url": "https://api.github.com/users/the-vindicar/followers", "following_url": "https://api.github.com/users/the-vindicar/following{/other_user}", "gists_url": "https://api.github.com/users/the-vindicar/gists{/gist_id}", "starred_url": "https://api.github.com/users/the-vindicar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/the-vindicar/subscriptions", "organizations_url": "https://api.github.com/users/the-vindicar/orgs", "repos_url": "https://api.github.com/users/the-vindicar/repos", "events_url": "https://api.github.com/users/the-vindicar/events{/privacy}", "received_events_url": "https://api.github.com/users/the-vindicar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "In SQL this is natural to return as a tuple, but what you're expressing is represented in Peewee (by default) as a model graph.\r\n\r\nThis hopefully makes it more clear:\r\n\r\n```python\r\n\r\nLiked = Person.alias('liked')\r\n\r\n# Here we are selecting the source person, joining through the Like\r\n# model, and then also selecting the liked person, aliased as \"Liked\".\r\nquery = (Person\r\n .select(Person, Like, Liked)\r\n .join(Like, on=(Like.likes == Person.id))\r\n .join(Liked, on=(Like.liked == Liked.id)))\r\n\r\n# Peewee converts this row-tuple into a graph of the objects\r\n# and relations.\r\nfor person in query:\r\n # To access the \"Liked\"-person's name, we go from the source\r\n # person -> the likes intermediary table -> the liked person instance.\r\n # This does not incur any hidden queries since we selected all the\r\n # data we needed up-front.\r\n print(person.name, person.likes.liked.name)\r\n```\r\n\r\nYou can control the attributes peewee patches the joined instances onto to make it more natural:\r\n\r\n```python\r\n\r\nquery = (Person\r\n .select(Person, Like, Liked)\r\n .join(Like, on=(Like.likes == Person.id), attr='liked')\r\n .join(Liked, on=(Like.liked == Liked.id), attr='person'))\r\n\r\nfor person in query:\r\n print(person.name, person.liked.person.name)\r\n```\r\n\r\nIf you want to skip the whole graph thing, you can use the \".objects()\" method on the query - but you have to alias your columns to avoid name collisions:\r\n\r\n```python\r\nquery = (Person\r\n .select(Person, Liked.name.alias('liked_name'))\r\n .join(Like, on=(Like.likes == Person.id), attr='liked')\r\n .join(Liked, on=(Like.liked == Liked.id), attr='person')\r\n .objects())\r\n\r\nfor person in query:\r\n print(person.name, person.liked_name)\r\n```\r\n\r\nYou may find these documents useful:\r\n\r\n* http://docs.peewee-orm.com/en/latest/peewee/relationships.html#selecting-from-multiple-sources\r\n* http://docs.peewee-orm.com/en/latest/peewee/relationships.html#implementing-many-to-many" ]

"2021-03-04T20:00:32"

"2021-03-05T01:43:33"

"2021-03-05T01:39:56"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2366/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kalyanidz", "id": 56637310, "node_id": "MDQ6VXNlcjU2NjM3MzEw", "avatar_url": "https://avatars.githubusercontent.com/u/56637310?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kalyanidz", "html_url": "https://github.com/kalyanidz", "followers_url": "https://api.github.com/users/kalyanidz/followers", "following_url": "https://api.github.com/users/kalyanidz/following{/other_user}", "gists_url": "https://api.github.com/users/kalyanidz/gists{/gist_id}", "starred_url": "https://api.github.com/users/kalyanidz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kalyanidz/subscriptions", "organizations_url": "https://api.github.com/users/kalyanidz/orgs", "repos_url": "https://api.github.com/users/kalyanidz/repos", "events_url": "https://api.github.com/users/kalyanidz/events{/privacy}", "received_events_url": "https://api.github.com/users/kalyanidz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee uses a connection-per-thread, so you get:\r\n\r\n* connect() -> get conn from pool, or if none free create new one\r\n* use connection for a while\r\n* close() -> return connection back to pool\r\n\r\nCalling `db.close()` will close the connection you've been using in the current thread. You use the exact same API when you're using the connection pool as you would when using a non-pooled peewee database implementation.\r\n\r\nI'm not very familiar with fastapi/uvicorn, but for web applications you will use the same pattern I described above:\r\n\r\n* request comes in, thread starts handling request\r\n* open db connection (db.connect())\r\n* do work\r\n* return response\r\n* close db connection (db.close())\r\n\r\nMost web frameworks have some hooks for before/after request. There is a section on the peewee docs about how to do this with FastAPI:\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/database.html#fastapi", "Thank you so much @coleifer ", "@coleifer \r\nOne more query, even if we are passing database instance in peewee basemodel class, do we still need to call db.connect() before the request?", "You should always call `connect()` at the beginning of the connection lifecycle and `close()` at the end. Why? Read here:\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/database.html#using-autoconnect\r\n\r\nPlease read the documentation.", "> You should always call `connect()` at the beginning of the connection lifecycle and `close()` at the end. Why? Read here:\r\n> \r\n> http://docs.peewee-orm.com/en/latest/peewee/database.html#using-autoconnect\r\n> \r\n> Please read the documentation.\r\n\r\nSure. Thanks again. " ]

"2021-03-04T11:12:13"

"2021-03-07T09:25:05"

"2021-03-04T13:52:46"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2365/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "RickMeasham", "id": 79414, "node_id": "MDQ6VXNlcjc5NDE0", "avatar_url": "https://avatars.githubusercontent.com/u/79414?v=4", "gravatar_id": "", "url": "https://api.github.com/users/RickMeasham", "html_url": "https://github.com/RickMeasham", "followers_url": "https://api.github.com/users/RickMeasham/followers", "following_url": "https://api.github.com/users/RickMeasham/following{/other_user}", "gists_url": "https://api.github.com/users/RickMeasham/gists{/gist_id}", "starred_url": "https://api.github.com/users/RickMeasham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RickMeasham/subscriptions", "organizations_url": "https://api.github.com/users/RickMeasham/orgs", "repos_url": "https://api.github.com/users/RickMeasham/repos", "events_url": "https://api.github.com/users/RickMeasham/events{/privacy}", "received_events_url": "https://api.github.com/users/RickMeasham/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee uses a heuristic on Function objects called with a single field as the argument, where the idea is to use that field's \"python value\" converter to convert the db value into an appropriate python type. As you've found, this is not always what you want.\r\n\r\nTo resolve this for now, you can explicitly tell Peewee not to convert the value by adding `.coerce(False)` after your function invocation:\r\n\r\n```python\r\n\r\nquery = AggregateTest.select(\r\n fn.ARRAY_AGG(AggregateTest.uuid_field).coerce(False).alias('uuid_test'),\r\n fn.ARRAY_AGG(AggregateTest.char_field).coerce(False).alias('char_test'),\r\n fn.ARRAY_AGG(AggregateTest.text_field).coerce(False).alias('text_test'),\r\n fn.ARRAY_AGG(AggregateTest.decimal_field).coerce(False).alias('decimal_test'),\r\n fn.ARRAY_AGG(AggregateTest.integer_field).coerce(False).alias('integer_test'),\r\n)\r\n```\r\n\r\nThis is somewhat covered here:\r\n\r\n* http://docs.peewee-orm.com/en/latest/peewee/api.html#Function\r\n* http://docs.peewee-orm.com/en/latest/peewee/api.html#Function.coerce\r\n\r\nTo get the UUID working you need to register the UUID adapter, which is in psycopg2.extras:\r\n\r\n```python\r\n\r\n# Add at top of file.\r\nfrom psycopg2.extras import register_uuid\r\nregister_uuid()\r\n```\r\n\r\nI've made a small change in Peewee to:\r\n\r\n* blacklist array_agg from using coerce=True by default. This means that Peewee will return the value directly from the cursor without attempting to alter it.\r\n* register the psycopg2 UUID type automatically when peewee is imported\r\n\r\nThose changes should resolve this going forward." ]

"2021-03-03T23:43:05"

"2021-03-04T01:59:18"

"2021-03-04T01:59:18"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2364/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Nixellion", "id": 20309785, "node_id": "MDQ6VXNlcjIwMzA5Nzg1", "avatar_url": "https://avatars.githubusercontent.com/u/20309785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Nixellion", "html_url": "https://github.com/Nixellion", "followers_url": "https://api.github.com/users/Nixellion/followers", "following_url": "https://api.github.com/users/Nixellion/following{/other_user}", "gists_url": "https://api.github.com/users/Nixellion/gists{/gist_id}", "starred_url": "https://api.github.com/users/Nixellion/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Nixellion/subscriptions", "organizations_url": "https://api.github.com/users/Nixellion/orgs", "repos_url": "https://api.github.com/users/Nixellion/repos", "events_url": "https://api.github.com/users/Nixellion/events{/privacy}", "received_events_url": "https://api.github.com/users/Nixellion/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Are you sure cython is installed?\r\nDid you install the python headers? Should be apt install python-dev.\r\nLastly you want sqlite headers. apt install libsqlite3-dev.", "I ran those commands, python3-dev was already installed. Just in case installed python-dev as well.\r\n\r\nran `apt install libsqlite3-dev` as well.\r\n\r\nThen uninstalled and installed peewee again.\r\n\r\nStill nothing.\r\n\r\n```\r\n>>> from playhouse.sqlite_ext import CSqliteExtDatabase\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\nImportError: cannot import name 'CSqliteExtDatabase' from 'playhouse.sqlite_ext' (/usr/local/lib/python3.7/dist-packages/playhouse/sqlite_ext.py)\r\n```", "Oh okay. I had to install `cython` with `apt` not with `pip`. \r\n\r\nAfter that I had to uninstall and install peewee again with `pip3 install peewee --no-cache-dir`, that did run `setup.py` and it took a few seconds unlike usually, I guess it was compiling it.\r\n\r\nNow importing of that module works.\r\n\r\nHow should I approach this on Windows then? Or should I just bite it and work around it somehow and only use it on lin? Currently I just use try-except and import standard SqliteExtDatabase instead of CSqliteExtDatabase and dont run stuff that requires Cython extensions. But it would be nice to be able to quickly test it while developing, sadly I do use Windows for development.", "It's not necessary to install cython with apt but I suppose something weird is going on with your environment.", "That is a clean Debian 10 install. Also tried on WSL and on Ubuntu 20.04. \r\n\r\nUbuntu 20.04 did not require installing cython with `apt` - that's 100%. But I did not pay attention to that on Debian and WSL.\r\n\r\nSo I suppose it was just the missing `libsqlite3-dev`.\r\n\r\nAnyway it would be great if documentation page actually included these dependencies, here for example: http://docs.peewee-orm.com/en/latest/peewee/installation.html\r\n\r\nOr setup.py could print a warning messaging with instructions. \r\n\r\nWhat do you think?\r\n\r\nAnd thanks for you help.\r\n", "This already exists.\r\n\r\n* http://docs.peewee-orm.com/en/latest/peewee/installation.html#optional-dependencies\r\n* http://docs.peewee-orm.com/en/latest/peewee/installation.html#note-on-the-sqlite-extensions\r\n* https://github.com/coleifer/peewee/blob/d9a58399ba3f55199451d6a612473eafb5c58fe6/setup.py#L96-L103", "I don't see any mention of `libsqlite3-dev` on the page, neither `python-dev`. \r\n\r\nAlso for some reason those warnings were not printed in any of the tests I ran on all 4 systems. If I saw them I would probably not even be here.", "Those are debian-specific package names. The docs and the setup.py script both specify the requirements." ]

"2021-03-03T12:44:07"

"2021-03-03T19:09:57"

"2021-03-03T13:02:04"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2363/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mouday", "id": 24365682, "node_id": "MDQ6VXNlcjI0MzY1Njgy", "avatar_url": "https://avatars.githubusercontent.com/u/24365682?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mouday", "html_url": "https://github.com/mouday", "followers_url": "https://api.github.com/users/mouday/followers", "following_url": "https://api.github.com/users/mouday/following{/other_user}", "gists_url": "https://api.github.com/users/mouday/gists{/gist_id}", "starred_url": "https://api.github.com/users/mouday/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mouday/subscriptions", "organizations_url": "https://api.github.com/users/mouday/orgs", "repos_url": "https://api.github.com/users/mouday/repos", "events_url": "https://api.github.com/users/mouday/events{/privacy}", "received_events_url": "https://api.github.com/users/mouday/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The `execute_sql` method is a low level method that talks directly to the db-api cursor. If you want dicts then use the query-builder APIs or the various model query APIs. They are documented\r\n\r\n* http://docs.peewee-orm.com/en/latest/peewee/querying.html#retrieving-row-tuples-dictionaries-namedtuples\r\n* http://docs.peewee-orm.com/en/latest/peewee/query_builder.html", "i know , but, some time, i need execute some complex sql. if I see pymysql config\r\n```python\r\nimport pymysql.cursors\r\n\r\n# Connect to the database\r\nconnection = pymysql.connect(host='localhost',\r\n user='user',\r\n password='passwd',\r\n database='db',\r\n cursorclass=pymysql.cursors.DictCursor)\r\n```\r\n\r\nit support `cursorclass` option, but i try it, got a exception\r\n```\r\n File \"/Users/.pyenv/versions/py370/lib/python3.7/site-packages/peewee.py\", line 2161, in scalar\r\n return row[0] if row and not as_tuple else row\r\nKeyError: 0\r\n```\r\n\r\nif use query builder, i think it belong to simple sql, it sql is long and complex, will become to complex and difficulty to fix code.\r\n\r\nnow, i use `mysql_connector_python` got a dict cursor, so i config two mysql db connection.\r\n\r\nso, i will support execute raw sql, and got dict result. it will be wish.\r\n \r\n", "a good message, i support it, convert cursor result to dict\r\n\r\ndemo\r\n```python\r\n# -*- coding: utf-8 -*-\r\nfrom peewee import MySQLDatabase\r\nfrom typing import List, Dict, Union\r\n\r\n\r\ndef dict_factory(cursor, row):\r\n \"\"\"\r\n convert cursor result to dict\r\n \"\"\"\r\n d = {}\r\n for idx, col in enumerate(cursor.description):\r\n d[col[0]] = row[idx]\r\n return d\r\n\r\n\r\nclass DictMySQLDatabase(MySQLDatabase):\r\n\r\n def _execute(self, sql, params):\r\n return self.execute_sql(sql, params)\r\n\r\n def select(self, sql: str, params=()) -> List:\r\n \"\"\"select many row\"\"\"\r\n cursor = self._execute(sql, params)\r\n lst = []\r\n for row in cursor.fetchall():\r\n dct = dict_factory(cursor, row)\r\n lst.append(dct)\r\n\r\n return lst\r\n\r\n def select_one(self, sql: str, params=()) -> Dict:\r\n \"\"\"select one row\"\"\"\r\n cursor = self._execute(sql=sql, params=params)\r\n row = cursor.fetchone()\r\n return dict_factory(cursor, row)\r\n\r\n def update(self, sql: str, params=()) -> int:\r\n \"\"\"update many row\"\"\"\r\n cursor = self._execute(sql=sql, params=params)\r\n return cursor.rowcount\r\n\r\n def delete(self, sql: str, params=()) -> int:\r\n \"\"\"delete many row\"\"\"\r\n cursor = self._execute(sql=sql, params=params)\r\n return cursor.rowcount\r\n\r\n def insert(self, sql: str, params: Union[list, dict]) -> int:\r\n \"\"\"insert many row\"\"\"\r\n cursor = self._execute(sql=sql, params=params)\r\n return cursor.rowcount\r\n\r\n def insert_one(self, sql: str, params: Union[tuple, dict] = ()) -> int:\r\n \"\"\"insert one row\"\"\"\r\n cursor = self._execute(sql=sql, params=params)\r\n return cursor.lastrowid\r\n\r\n```\r\n\r\ntest\r\n```python\r\n\r\ndb = DictMySQLDatabase(**config)\r\n\r\nrows = db.select('select * from person limit 1')\r\nprint(rows)\r\n[{'id': 1, 'name': 'Tom'}]\r\n```", "now i can use cator impl:\r\n```python\r\npip install cator\r\n```\r\n\r\n```python\r\nfrom cator import DatabaseProxy\r\nfrom peewee import MySQLDatabase\r\n\r\ndb = MySQLDatabase(**config)\r\ndb_proxy = DatabaseProxy(db)\r\n# db_proxy can use select/select_one...\r\n```\r\nabout cator DatabaseProxy object see: https://github.com/mouday/cator" ]

"2021-03-03T09:33:16"

"2021-03-10T03:04:10"

"2021-03-03T13:07:53"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2362/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "RickMeasham", "id": 79414, "node_id": "MDQ6VXNlcjc5NDE0", "avatar_url": "https://avatars.githubusercontent.com/u/79414?v=4", "gravatar_id": "", "url": "https://api.github.com/users/RickMeasham", "html_url": "https://github.com/RickMeasham", "followers_url": "https://api.github.com/users/RickMeasham/followers", "following_url": "https://api.github.com/users/RickMeasham/following{/other_user}", "gists_url": "https://api.github.com/users/RickMeasham/gists{/gist_id}", "starred_url": "https://api.github.com/users/RickMeasham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RickMeasham/subscriptions", "organizations_url": "https://api.github.com/users/RickMeasham/orgs", "repos_url": "https://api.github.com/users/RickMeasham/repos", "events_url": "https://api.github.com/users/RickMeasham/events{/privacy}", "received_events_url": "https://api.github.com/users/RickMeasham/received_events", "type": "User", "site_admin": false }

[]

[]

[ "For this you should probably be explicit about using the database-specific UPSERT. Because this functionality is not necessarily available across all databases, nor does is it implemented in the same way, Peewee doesn't offer a \"shortcut\" which may mask inefficiencies or gotcha's in the underlying implementation.\r\n\r\nCheck the docs for details on how to issue upsert queries: http://docs.peewee-orm.com/en/latest/peewee/querying.html#upsert" ]

"2021-03-01T02:19:24"

"2021-03-01T16:20:10"

"2021-03-01T16:20:10"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2361/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "NightMachinery", "id": 36224762, "node_id": "MDQ6VXNlcjM2MjI0NzYy", "avatar_url": "https://avatars.githubusercontent.com/u/36224762?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NightMachinery", "html_url": "https://github.com/NightMachinery", "followers_url": "https://api.github.com/users/NightMachinery/followers", "following_url": "https://api.github.com/users/NightMachinery/following{/other_user}", "gists_url": "https://api.github.com/users/NightMachinery/gists{/gist_id}", "starred_url": "https://api.github.com/users/NightMachinery/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NightMachinery/subscriptions", "organizations_url": "https://api.github.com/users/NightMachinery/orgs", "repos_url": "https://api.github.com/users/NightMachinery/repos", "events_url": "https://api.github.com/users/NightMachinery/events{/privacy}", "received_events_url": "https://api.github.com/users/NightMachinery/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The only reason you would need to add them to the Peewee model is if you want Peewee to create them whenever you run `database.create_tables([...])` or `MyModel.create_table()`." ]

"2021-02-28T14:44:46"

"2021-02-28T15:14:07"

"2021-02-28T15:14:07"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2360/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "joveice", "id": 14098624, "node_id": "MDQ6VXNlcjE0MDk4NjI0", "avatar_url": "https://avatars.githubusercontent.com/u/14098624?v=4", "gravatar_id": "", "url": "https://api.github.com/users/joveice", "html_url": "https://github.com/joveice", "followers_url": "https://api.github.com/users/joveice/followers", "following_url": "https://api.github.com/users/joveice/following{/other_user}", "gists_url": "https://api.github.com/users/joveice/gists{/gist_id}", "starred_url": "https://api.github.com/users/joveice/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/joveice/subscriptions", "organizations_url": "https://api.github.com/users/joveice/orgs", "repos_url": "https://api.github.com/users/joveice/repos", "events_url": "https://api.github.com/users/joveice/events{/privacy}", "received_events_url": "https://api.github.com/users/joveice/received_events", "type": "User", "site_admin": false }

[]

[]

[ "```\r\ndb = SqliteDatabase(config.get('save_path'))\r\nconn = db.connection()\r\nconn.text_factory = bytes\r\n```\r\nThis works, would this be a valid way?\r\nSorry for the dumb questions, but this is really new to me.", "Sqlite uses UTF8 (or UTF16) for text. It sounds like you have a weird encoding. I don't know the provenance of this database, but if you're using peewee's `TextField` then this is expressly for storing UTF8-encoded unicode text. If you need to store arbitrary binary data you should use the `BlobField`." ]

"2021-02-27T00:02:38"

"2021-02-27T17:57:06"

"2021-02-27T17:57:06"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2359/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "LVerneyPEReN", "id": 58298410, "node_id": "MDQ6VXNlcjU4Mjk4NDEw", "avatar_url": "https://avatars.githubusercontent.com/u/58298410?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LVerneyPEReN", "html_url": "https://github.com/LVerneyPEReN", "followers_url": "https://api.github.com/users/LVerneyPEReN/followers", "following_url": "https://api.github.com/users/LVerneyPEReN/following{/other_user}", "gists_url": "https://api.github.com/users/LVerneyPEReN/gists{/gist_id}", "starred_url": "https://api.github.com/users/LVerneyPEReN/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LVerneyPEReN/subscriptions", "organizations_url": "https://api.github.com/users/LVerneyPEReN/orgs", "repos_url": "https://api.github.com/users/LVerneyPEReN/repos", "events_url": "https://api.github.com/users/LVerneyPEReN/events{/privacy}", "received_events_url": "https://api.github.com/users/LVerneyPEReN/received_events", "type": "User", "site_admin": false }

[]

[]

[ "A lot of people like to use SQLite as a peer for PostgreSQL for local development.\r\nHowever, I think this approach is not always guaranteed to work, and as much as I love SQLite, PostgreSQL has tons of other features to offer.\r\nSo, my question is: if your production code is running with the latter, why are you not simply developing against it? It's easy enough to start a docker container with PostgreSQL locally even on non Linux machines (Mac and Windows ...).", "This kind of namespacing works differently in sqlite than postgres. To utilize the additional layers of nampespaces in sqlite, you need to use separate database files and then load them into your main database via \"attach\". When you attach a database, you specify it's nampespace, which corresponds to the \"schema\" setting on the model metadata.\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/api.html#SqliteDatabase.attach", "You can make a custom metadata class implementation that has a dynamic schema. This should give you an idea of how to go about it:\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/database.html#thread-safety-and-multiple-databases", "Hi @coleifer, thanks for the details, this is perfect for my use case!" ]

"2021-02-26T11:28:00"

"2021-02-26T13:11:34"

"2021-02-26T12:21:06"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2358/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sorokousov", "id": 36851598, "node_id": "MDQ6VXNlcjM2ODUxNTk4", "avatar_url": "https://avatars.githubusercontent.com/u/36851598?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sorokousov", "html_url": "https://github.com/sorokousov", "followers_url": "https://api.github.com/users/sorokousov/followers", "following_url": "https://api.github.com/users/sorokousov/following{/other_user}", "gists_url": "https://api.github.com/users/sorokousov/gists{/gist_id}", "starred_url": "https://api.github.com/users/sorokousov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sorokousov/subscriptions", "organizations_url": "https://api.github.com/users/sorokousov/orgs", "repos_url": "https://api.github.com/users/sorokousov/repos", "events_url": "https://api.github.com/users/sorokousov/events{/privacy}", "received_events_url": "https://api.github.com/users/sorokousov/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You have a trailing comma:\r\n\r\n```python\r\n\r\npth.deck_original = bliat,\r\npth.deck_current = bliat,\r\n```", "Oh, my God, this is my mistake)))\r\nThanks you!!!", "somehow i had the exact same mistake. Thank god this issue exist :)\r\n" ]

"2021-02-25T15:44:14"

"2023-04-24T12:29:12"

"2021-02-25T16:16:24"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2357/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "DanielAndreasen", "id": 4519017, "node_id": "MDQ6VXNlcjQ1MTkwMTc=", "avatar_url": "https://avatars.githubusercontent.com/u/4519017?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DanielAndreasen", "html_url": "https://github.com/DanielAndreasen", "followers_url": "https://api.github.com/users/DanielAndreasen/followers", "following_url": "https://api.github.com/users/DanielAndreasen/following{/other_user}", "gists_url": "https://api.github.com/users/DanielAndreasen/gists{/gist_id}", "starred_url": "https://api.github.com/users/DanielAndreasen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DanielAndreasen/subscriptions", "organizations_url": "https://api.github.com/users/DanielAndreasen/orgs", "repos_url": "https://api.github.com/users/DanielAndreasen/repos", "events_url": "https://api.github.com/users/DanielAndreasen/events{/privacy}", "received_events_url": "https://api.github.com/users/DanielAndreasen/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I have played around a bit with the source code to get this to work, and found a simple solution that seems to work. I add the following `class` to `playhouse.postgres_ext`\r\n\r\n```python\r\nfrom psycopg2._range import NumericRange\r\n\r\n...\r\n\r\nclass NumericRange(Field, NumericRange):\r\n field_type = 'NUMRANGE'\r\n```\r\n\r\nThe column is now created with all the nice functionality from the `Range` class, which [`NumericRange`](https://github.com/psycopg/psycopg2/blob/master/lib/_range.py#L457-L463) inherits from. Would you like me to open a PR with this simple solution?", "I think this is incorrectly implemented. I would think you would rather do something like this:\r\n\r\n```python\r\n\r\nclass NumericRangeField(Field):\r\n field_type = 'NUMRANGE'\r\n\r\n def adapt(self, value):\r\n if value is not None: return NumericRange(value)\r\n```\r\n\r\nThe idea is that the field retains all the regular field methods/apis while exposing a value to the user which represents the range and can be converted to the appropriate sql by the psycopg2 driver.\r\n\r\nAt any rate, I do not intend to be adding support at the present time.", "Alright, thanks for the answer. I guess I can just implement it directly into my models." ]

"2021-02-25T09:56:03"

"2021-02-25T14:37:42"

"2021-02-25T14:09:42"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2356/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "lselker13", "id": 12423842, "node_id": "MDQ6VXNlcjEyNDIzODQy", "avatar_url": "https://avatars.githubusercontent.com/u/12423842?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lselker13", "html_url": "https://github.com/lselker13", "followers_url": "https://api.github.com/users/lselker13/followers", "following_url": "https://api.github.com/users/lselker13/following{/other_user}", "gists_url": "https://api.github.com/users/lselker13/gists{/gist_id}", "starred_url": "https://api.github.com/users/lselker13/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lselker13/subscriptions", "organizations_url": "https://api.github.com/users/lselker13/orgs", "repos_url": "https://api.github.com/users/lselker13/repos", "events_url": "https://api.github.com/users/lselker13/events{/privacy}", "received_events_url": "https://api.github.com/users/lselker13/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The error is raised by the sqlite driver you are using -- I'd suggest checking the error message contained in the exception if you want to do special handling of this exception. For general suggestions on how to handle sqlite's write-locking, these posts may help:\r\n\r\n* https://charlesleifer.com/blog/going-fast-with-sqlite-and-python/\r\n* https://charlesleifer.com/blog/multi-threaded-sqlite-without-the-operationalerrors/\r\n\r\nYou can set a timeout on the database instance which controls the busy-timeout sqlite uses for retrying to acquire the lock:\r\n\r\n* http://docs.peewee-orm.com/en/latest/peewee/api.html#SqliteDatabase\r\n\r\nI'd also suggest you familiarize yourself with how sqlite locking works on the sqlite docs website.\r\n\r\nAlso, in case it wasn't clear, sqlite + peewee already specifies a default 5 second busy timeout (if lock is busy, keep attempting to acquire it) - this is a relative eternity in sqlite terms." ]

"2021-02-24T01:38:03"

"2021-02-24T03:21:22"

"2021-02-24T03:20:01"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2355/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ms-lilibeth", "id": 10104959, "node_id": "MDQ6VXNlcjEwMTA0OTU5", "avatar_url": "https://avatars.githubusercontent.com/u/10104959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ms-lilibeth", "html_url": "https://github.com/ms-lilibeth", "followers_url": "https://api.github.com/users/ms-lilibeth/followers", "following_url": "https://api.github.com/users/ms-lilibeth/following{/other_user}", "gists_url": "https://api.github.com/users/ms-lilibeth/gists{/gist_id}", "starred_url": "https://api.github.com/users/ms-lilibeth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ms-lilibeth/subscriptions", "organizations_url": "https://api.github.com/users/ms-lilibeth/orgs", "repos_url": "https://api.github.com/users/ms-lilibeth/repos", "events_url": "https://api.github.com/users/ms-lilibeth/events{/privacy}", "received_events_url": "https://api.github.com/users/ms-lilibeth/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I've gone ahead and added support for this as the changes required were not extensive, although this is honestly the first time this has come up in 10+ years so I don't know it will be of much general benefit. One gotcha: MySQL doesn't seem to support inlining named check constraints into the field definition, but I'll leave this up to the user to sort out for now (again -- seems unlikely that many people will use it and I've put a note in the docs)." ]

"2021-02-20T16:52:57"

"2021-02-21T02:18:08"

"2021-02-21T02:18:08"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2354/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pierky", "id": 6806218, "node_id": "MDQ6VXNlcjY4MDYyMTg=", "avatar_url": "https://avatars.githubusercontent.com/u/6806218?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pierky", "html_url": "https://github.com/pierky", "followers_url": "https://api.github.com/users/pierky/followers", "following_url": "https://api.github.com/users/pierky/following{/other_user}", "gists_url": "https://api.github.com/users/pierky/gists{/gist_id}", "starred_url": "https://api.github.com/users/pierky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pierky/subscriptions", "organizations_url": "https://api.github.com/users/pierky/orgs", "repos_url": "https://api.github.com/users/pierky/repos", "events_url": "https://api.github.com/users/pierky/events{/privacy}", "received_events_url": "https://api.github.com/users/pierky/received_events", "type": "User", "site_admin": false }

[]

[]

[ ">Not the perfect solution, I know, I'd just like to see if something along this line would be accepted\r\n\r\nI'd suggest putting this into your own subclass of `MySQLDatabase` (or `ReconnectMixin`, whichever you use) as I don't intend to maintain this code or advocate this approach." ]

"2021-02-19T20:48:58"

"2021-02-19T21:53:06"

"2021-02-19T21:53:05"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2353/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2353", "html_url": "https://github.com/coleifer/peewee/pull/2353", "diff_url": "https://github.com/coleifer/peewee/pull/2353.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2353.patch", "merged_at": null }

{ "login": "feixie", "id": 394007, "node_id": "MDQ6VXNlcjM5NDAwNw==", "avatar_url": "https://avatars.githubusercontent.com/u/394007?v=4", "gravatar_id": "", "url": "https://api.github.com/users/feixie", "html_url": "https://github.com/feixie", "followers_url": "https://api.github.com/users/feixie/followers", "following_url": "https://api.github.com/users/feixie/following{/other_user}", "gists_url": "https://api.github.com/users/feixie/gists{/gist_id}", "starred_url": "https://api.github.com/users/feixie/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/feixie/subscriptions", "organizations_url": "https://api.github.com/users/feixie/orgs", "repos_url": "https://api.github.com/users/feixie/repos", "events_url": "https://api.github.com/users/feixie/events{/privacy}", "received_events_url": "https://api.github.com/users/feixie/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The `apply_default()` method is exposed as an operation, just like `add_column()`. Since \"defaults\" specified this way are implemented in Python rather than as a sql default constraint, I've avoided automatically applying them when the field is left nullable (as this implies an UPDATE of every row of the table).\r\n\r\nSo you would:\r\n\r\n```python\r\n\r\nmigrate(\r\n migrator.add_column('my_tbl', 'my_col', field_obj),\r\n migrator.apply_default('my_tbl', 'my_col', field_obj),\r\n)\r\n```" ]

"2021-02-19T18:58:24"

"2021-02-19T22:01:22"

"2021-02-19T22:01:22"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2352/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "zgoda", "id": 141999, "node_id": "MDQ6VXNlcjE0MTk5OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/141999?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zgoda", "html_url": "https://github.com/zgoda", "followers_url": "https://api.github.com/users/zgoda/followers", "following_url": "https://api.github.com/users/zgoda/following{/other_user}", "gists_url": "https://api.github.com/users/zgoda/gists{/gist_id}", "starred_url": "https://api.github.com/users/zgoda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zgoda/subscriptions", "organizations_url": "https://api.github.com/users/zgoda/orgs", "repos_url": "https://api.github.com/users/zgoda/repos", "events_url": "https://api.github.com/users/zgoda/events{/privacy}", "received_events_url": "https://api.github.com/users/zgoda/received_events", "type": "User", "site_admin": false }

[]

[]

[ "If it's a python callable what's peewee supposed to do... iterate every single row and update it? That would not work and would cause performance problems for users because it is unexpected.\r\n\r\nIf you want, you can use a sql function - sqlite lets you add user-defined functions quite easily - and even use them for column defaults. Alternatively, you can set it to some placeholder and then iterate every row if you're so inclined." ]

"2021-02-18T20:39:55"

"2021-02-18T23:13:36"

"2021-02-18T23:13:36"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2351/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "cdcadman", "id": 51368516, "node_id": "MDQ6VXNlcjUxMzY4NTE2", "avatar_url": "https://avatars.githubusercontent.com/u/51368516?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cdcadman", "html_url": "https://github.com/cdcadman", "followers_url": "https://api.github.com/users/cdcadman/followers", "following_url": "https://api.github.com/users/cdcadman/following{/other_user}", "gists_url": "https://api.github.com/users/cdcadman/gists{/gist_id}", "starred_url": "https://api.github.com/users/cdcadman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cdcadman/subscriptions", "organizations_url": "https://api.github.com/users/cdcadman/orgs", "repos_url": "https://api.github.com/users/cdcadman/repos", "events_url": "https://api.github.com/users/cdcadman/events{/privacy}", "received_events_url": "https://api.github.com/users/cdcadman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Glad you got it working." ]

"2021-02-18T12:09:52"

"2021-02-18T15:23:49"

"2021-02-18T15:23:49"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2350/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }

{ "login": "daeeros", "id": 34482855, "node_id": "MDQ6VXNlcjM0NDgyODU1", "avatar_url": "https://avatars.githubusercontent.com/u/34482855?v=4", "gravatar_id": "", "url": "https://api.github.com/users/daeeros", "html_url": "https://github.com/daeeros", "followers_url": "https://api.github.com/users/daeeros/followers", "following_url": "https://api.github.com/users/daeeros/following{/other_user}", "gists_url": "https://api.github.com/users/daeeros/gists{/gist_id}", "starred_url": "https://api.github.com/users/daeeros/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/daeeros/subscriptions", "organizations_url": "https://api.github.com/users/daeeros/orgs", "repos_url": "https://api.github.com/users/daeeros/repos", "events_url": "https://api.github.com/users/daeeros/events{/privacy}", "received_events_url": "https://api.github.com/users/daeeros/received_events", "type": "User", "site_admin": false }

[]

[]

[ "It works fine for me:\r\n\r\n```python\r\n\r\nclass T(Model):\r\n data = BinaryJSONField()\r\n class Meta:\r\n database = db\r\n\r\ndb.drop_tables([T])\r\ndb.create_tables([T])\r\nT.create(data={'k1': 'v1', 'k2': 'v2'})\r\nT.create(data={'k1': 'v3', 'k2': 'v4'})\r\nT.create(data={'k1': 'v5', 'k2': 'v6'})\r\n\r\nquery = T.select().order_by(T.data['k1'].desc())\r\nfor row in query:\r\n print(row.data['k1'])\r\n# prints:\r\n# v5\r\n# v3\r\n# v1\r\n```" ]

"2021-02-14T13:18:54"

"2021-02-14T15:13:34"

"2021-02-14T15:13:34"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2349/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "whisust", "id": 22323709, "node_id": "MDQ6VXNlcjIyMzIzNzA5", "avatar_url": "https://avatars.githubusercontent.com/u/22323709?v=4", "gravatar_id": "", "url": "https://api.github.com/users/whisust", "html_url": "https://github.com/whisust", "followers_url": "https://api.github.com/users/whisust/followers", "following_url": "https://api.github.com/users/whisust/following{/other_user}", "gists_url": "https://api.github.com/users/whisust/gists{/gist_id}", "starred_url": "https://api.github.com/users/whisust/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/whisust/subscriptions", "organizations_url": "https://api.github.com/users/whisust/orgs", "repos_url": "https://api.github.com/users/whisust/repos", "events_url": "https://api.github.com/users/whisust/events{/privacy}", "received_events_url": "https://api.github.com/users/whisust/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I've tried switching the `UUIDField` in a `CharField` for the `course_ids` in the example, and the result of the converter is the following:\r\n\r\n\r\nTypes are ok because, indeed `{something1,something2}` is a valid string, but then\r\n```\r\n> type(new_program.course_ids) == str\r\nTrue\r\n```\r\n\r\nwhen it's suppose to be a List[str]", "This feels like a psycopg2 bug rather than a peewee issue. Why is the value returned by the cursor a string (`'{}'`) and not an empty list? With other data-types psycopg2 tends to handle this correctly - returning us an empty list. But for the `[]UUID` data-type it returns empty arrays as the literal string `'{}'`.\r\n\r\nHere is an example using an array of varchar, which works fine:\r\n\r\n```python\r\nclass T(Model):\r\n id = UUIDField(primary_key=True, default=uuid.uuid4, constraints=[ \r\n SQL('default gen_random_uuid()')])\r\n vals = ArrayField(CharField, null=False, convert_values=True, \r\n default=[], constraints=[SQL('default array[]::character varying[]')]) \r\n\r\nt = T.create()\r\nprint(t.id, t.vals)\r\n\r\nt = T.insert().execute()\r\nprint(t)\r\n\r\nfor row in T.select():\r\n print(row.id, row.vals)\r\n\r\nt = T.insert().returning(T).execute()[0]\r\nprint(t)\r\n```\r\n\r\nAll of the above work fine, and the output from one run is:\r\n\r\n```\r\n9237cac9-6cf3-479a-84c4-62bdd2ef83f2 []\r\n79aa4346-19fa-4db5-8a36-0663ba405fe3\r\n9237cac9-6cf3-479a-84c4-62bdd2ef83f2 []\r\n79aa4346-19fa-4db5-8a36-0663ba405fe3 []\r\n6984a525-e5b6-41cc-a9b9-ec83afcf5c58\r\n```\r\n\r\nAs you noted, changing this to a UUID causes a problem with the empty array:\r\n\r\n```python\r\n # Change \"vals\" to array of UUID.\r\nclass T...\r\n vals = ArrayField(UUIDField, null=False, convert_values=True,\r\n default=[],\r\n constraints=[SQL('default array[]::uuid[]')])\r\n\r\n# These both work:\r\nt = T.create()\r\nt = T.insert().execute()\r\n\r\n# These both fail with the \"ValueError: badly formed hexadecimal UUID string\":\r\nfor row in T.select():\r\n print(row.id, row.vals)\r\n\r\nt = T.insert().returning(T).execute()[0]\r\n```\r\n\r\nI would raise this with the psycopg2 developers. The driver should be returning us that empty list as a standard python list and definitely not as a string. A workaround you can probably use in the meantime is to subclass `ArrayField`:\r\n\r\n```python\r\n\r\nclass SafeArrayField(ArrayField):\r\n def python_value(self, value):\r\n if isinstance(value, str) and value == '{}':\r\n return []\r\n return super(SafeArrayField, self).python_value(value)\r\n```\r\n\r\nWhen using the above implementation, then all the above code works correctly." ]

"2021-02-14T11:01:32"

"2021-02-14T15:38:03"

"2021-02-14T15:38:02"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2348/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alvenhar", "id": 61888606, "node_id": "MDQ6VXNlcjYxODg4NjA2", "avatar_url": "https://avatars.githubusercontent.com/u/61888606?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alvenhar", "html_url": "https://github.com/alvenhar", "followers_url": "https://api.github.com/users/alvenhar/followers", "following_url": "https://api.github.com/users/alvenhar/following{/other_user}", "gists_url": "https://api.github.com/users/alvenhar/gists{/gist_id}", "starred_url": "https://api.github.com/users/alvenhar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alvenhar/subscriptions", "organizations_url": "https://api.github.com/users/alvenhar/orgs", "repos_url": "https://api.github.com/users/alvenhar/repos", "events_url": "https://api.github.com/users/alvenhar/events{/privacy}", "received_events_url": "https://api.github.com/users/alvenhar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for the report. Not going to take any action on this at the moment, but feel free to open a patch to add a section to the docs." ]

"2021-02-11T08:09:33"

"2021-02-11T15:46:08"

"2021-02-11T15:46:08"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2347/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pfw", "id": 92163, "node_id": "MDQ6VXNlcjkyMTYz", "avatar_url": "https://avatars.githubusercontent.com/u/92163?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pfw", "html_url": "https://github.com/pfw", "followers_url": "https://api.github.com/users/pfw/followers", "following_url": "https://api.github.com/users/pfw/following{/other_user}", "gists_url": "https://api.github.com/users/pfw/gists{/gist_id}", "starred_url": "https://api.github.com/users/pfw/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pfw/subscriptions", "organizations_url": "https://api.github.com/users/pfw/orgs", "repos_url": "https://api.github.com/users/pfw/repos", "events_url": "https://api.github.com/users/pfw/events{/privacy}", "received_events_url": "https://api.github.com/users/pfw/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Pretty much. You'll want to use a db-api 2.0 compatible driver, e.g. one of:\r\n\r\nhttps://www.firebirdsql.org/file/documentation/drivers_documentation/python/3.3.0/Python-DB-API-2.0.html\r\n\r\nYou would subclass `Database` and start by implementing the `_connect()` method and go from there. I'm not familiar with Firebird so I am not sure what subtleties you may encounter along the way. The sqlalchemy codebase might provide some helpful hints, as well:\r\n\r\nhttps://github.com/sqlalchemy/sqlalchemy/tree/master/lib/sqlalchemy/dialects/firebird\r\n\r\nSince this is not a bugfix I will close, but feel free to raise any questions you encounter along the way and I'll try to help.", "Good one, thank for the pointers. At the moment it's definitely an experiment but I'll update if we get anywhere with it." ]

"2021-02-11T01:31:15"

"2021-02-11T03:06:43"

"2021-02-11T02:54:46"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2346/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }