author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,966 | 04.04.2022 10:46:16 | 25,200 | 47fbf57a832139af24d3caa485ec531ad33a23b1 | Add option to enable multicast forwarding
Setting this newly added option to "true" will currently be a no-op. Full
support for multicast routing will be added in subsequent CLs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -72,6 +72,7 @@ var ipv4BroadcastAddr = header.IPv4Broadcast.WithPrefix()\nvar _ stack.LinkResolvableNetworkEndpoint = (*endpoint)(nil)\nvar _ stack.ForwardingNetworkEndp... | Go | Apache License 2.0 | google/gvisor | Add option to enable multicast forwarding
Setting this newly added option to "true" will currently be a no-op. Full
support for multicast routing will be added in subsequent CLs.
Updates #7338.
PiperOrigin-RevId: 439356271 |
259,962 | 04.04.2022 13:50:47 | 25,200 | 399199e4b7c89ff9d670e37ed8ae93bbca0defb4 | Call ConfirmReachable only once per batch of packets.
ConfirmReachable does not need to be called on every packet processed
as we process packets in batches. Its more efficient to do so once
for every batch in handleSegmentsLocked. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1142,6 +1142,7 @@ func (e *endpoint) handleReset(s *segment) (ok bool, err tcpip.Error) {\n// +checklocksalias:e.snd.ep.mu=e.mu\nfunc (e *endpoint) handleSegmen... | Go | Apache License 2.0 | google/gvisor | Call ConfirmReachable only once per batch of packets.
ConfirmReachable does not need to be called on every packet processed
as we process packets in batches. Its more efficient to do so once
for every batch in handleSegmentsLocked.
PiperOrigin-RevId: 439402884 |
259,966 | 05.04.2022 12:43:01 | 25,200 | bfd3f716ab34dee81050276369527f1c870821c3 | Remove unnecessary locks from SetMulticastForwarding | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -253,9 +253,6 @@ func (e *endpoint) MulticastForwarding() bool {\n// SetMulticastForwarding implements stack.MulticastForwardingNetworkEndpoint.\nfunc (e *endpoint) SetM... | Go | Apache License 2.0 | google/gvisor | Remove unnecessary locks from SetMulticastForwarding
PiperOrigin-RevId: 439650199 |
259,853 | 06.04.2022 14:18:09 | 25,200 | e8ee6e81252850255cffc982e9867d48207ed659 | Remove unused ring0.RestoreKernelFPState. | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/kernel_amd64.go",
"new_path": "pkg/ring0/kernel_amd64.go",
"diff": "@@ -338,21 +338,3 @@ func SetCPUIDFaulting(on bool) bool {\nfunc ReadCR2() uintptr {\nreturn readCR2()\n}\n-\n-// kernelMXCSR is the value of the mxcsr register in the Sentry.\n-//\n... | Go | Apache License 2.0 | google/gvisor | Remove unused ring0.RestoreKernelFPState.
PiperOrigin-RevId: 439933401 |
259,992 | 07.04.2022 12:01:35 | 25,200 | 90ef5d086970c647d47211236971c78e26725acc | Take direct dependency on Any proto | [
{
"change_type": "MODIFY",
"old_path": "pkg/eventchannel/BUILD",
"new_path": "pkg/eventchannel/BUILD",
"diff": "@@ -6,7 +6,6 @@ go_library(\nname = \"eventchannel\",\nsrcs = [\n\"event.go\",\n- \"event_any.go\",\n\"processor.go\",\n\"rate.go\",\n],\n"
},
{
"change_type": "MODIFY",
"old_p... | Go | Apache License 2.0 | google/gvisor | Take direct dependency on Any proto
PiperOrigin-RevId: 440166317 |
259,985 | 07.04.2022 14:20:05 | 25,200 | 9219adb83cdff5f8dee51ae0e183e62bf5d5e1b8 | cgroupfs: Mkdir should honour file mode. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -163,7 +163,7 @@ type cgroupInode struct {\nvar _ kernel.CgroupImpl = (*cgroupInode)(nil)\n-func (fs *filesystem) newCgroupInode(ctx context.Context, creds *auth... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Mkdir should honour file mode.
PiperOrigin-RevId: 440199111 |
259,975 | 12.04.2022 10:17:08 | 25,200 | b3dc42bace4813d2833d3cabeba3539efe8d6acb | [benchmarks] Add profiles back to buildkite. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -383,7 +383,7 @@ run_benchmark = \\\nbenchmark-platforms: load-benchmarks $(RUNTIME_BIN) ## Runs benchmarks for runc and all platforms.\n@set -xe; for PLATFORM in $$($(RUNTIME_BIN) help platforms); do \\\nexport P... | Go | Apache License 2.0 | google/gvisor | [benchmarks] Add profiles back to buildkite.
PiperOrigin-RevId: 441223389 |
259,853 | 12.04.2022 23:30:43 | 25,200 | edbd20302734797bc3283b6f4b7e1448ee8b691c | kvm: handle errors of updateSystemValues | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm_amd64.go",
"new_path": "pkg/sentry/platform/kvm/kvm_amd64.go",
"diff": "@@ -219,7 +219,9 @@ func (c *cpuidEntries) Set(in cpuid.In, out cpuid.Out) {\n// updateGlobalOnce does global initialization. It has to be called only once.\nfu... | Go | Apache License 2.0 | google/gvisor | kvm: handle errors of updateSystemValues
PiperOrigin-RevId: 441390130 |
260,009 | 13.04.2022 11:13:31 | 25,200 | 717f78b01497c17c9c52bed896b7877089c49bbc | Add additional init checks to ExponentialBucketer. | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -551,6 +551,9 @@ func NewExponentialBucketer(numFiniteBuckets int, width uint64, scale, growth fl\nif numFiniteBuckets < exponentialMinBuckets || numFiniteBuckets > exponentialMaxBuckets {\... | Go | Apache License 2.0 | google/gvisor | Add additional init checks to ExponentialBucketer.
PiperOrigin-RevId: 441529868 |
259,907 | 15.04.2022 15:05:42 | 25,200 | fed9f8ee8e821b2a7b27f2a90462de077e82f9ac | Do not hold transport.Endpoint.mu during mknod in unix bind implementations.
This is consistent with Linux, which calls mknod(), then takes
unix_sock::bindlock and then marks the socket as bound. On error, the mknod is
reverted. See net/unix/af_unix.c:unix_bind_bsd().
This helps break the following lock chain: kernfs.f... | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netlink/socket.go",
"new_path": "pkg/sentry/socket/netlink/socket.go",
"diff": "@@ -138,7 +138,7 @@ func NewSocket(t *kernel.Task, skType linux.SockType, protocol Protocol) (*Socke\n// Bind the endpoint for good measure so we can connect to i... | Go | Apache License 2.0 | google/gvisor | Do not hold transport.Endpoint.mu during mknod in unix bind implementations.
This is consistent with Linux, which calls mknod(), then takes
unix_sock::bindlock and then marks the socket as bound. On error, the mknod is
reverted. See net/unix/af_unix.c:unix_bind_bsd().
This helps break the following lock chain: kernfs... |
259,985 | 18.04.2022 17:25:50 | 25,200 | 5f9bd8a53b208bad3fe3e5cace82c4521dc9c2b3 | cgroupfs: Synchronize access to cpuset controller bitmaps.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/cpuset.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/cpuset.go",
"diff": "@@ -65,6 +65,8 @@ func newCPUSetController(k *kernel.Kernel, fs *filesystem) *cpusetController {\n// Clone implements controller.Clone.\nfunc (c *cpusetControll... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Synchronize access to cpuset controller bitmaps.
Reported-by: syzbot+98719e57f6acbe602b7f@syzkaller.appspotmail.com
PiperOrigin-RevId: 442672867 |
259,909 | 19.04.2022 11:18:32 | 25,200 | e380531bfba0d7c4ad3b4dd50d590cddaaac0c76 | Clean up tcp segment sender functions.
sendRaw is entirely used to just send flags, so change the function to
explicitly send empty segments. The single use case for sending data can
be taken care of in sendSegment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -290,7 +290,7 @@ func (h *handshake) checkAck(s *segment) bool {\n// If the segment acknowledgment is not acceptable, form a reset segment,\n// <SEQ=SEG.ACK><CTL... | Go | Apache License 2.0 | google/gvisor | Clean up tcp segment sender functions.
sendRaw is entirely used to just send flags, so change the function to
explicitly send empty segments. The single use case for sending data can
be taken care of in sendSegment.
PiperOrigin-RevId: 442861994 |
259,985 | 19.04.2022 14:53:25 | 25,200 | f4e537843f49fadaa364ba7f210e68e267f59c3d | Drop MappingIdentity ref outside mm.mappingMu critical section.
Otherwise we get circular locking with various filesystem locks if the
dropped ref is the final ref. Mapping identities are typically file
descriptions on various filesystems, which in turn call mm functions
under the respective filesystem locks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/lifecycle.go",
"new_path": "pkg/sentry/mm/lifecycle.go",
"diff": "@@ -61,6 +61,15 @@ func (mm *MemoryManager) Fork(ctx context.Context) (*MemoryManager, error) {\ndefer mm.AddressSpace().PostFork()\nmm.metadataMu.Lock()\ndefer mm.metadataMu.Unloc... | Go | Apache License 2.0 | google/gvisor | Drop MappingIdentity ref outside mm.mappingMu critical section.
Otherwise we get circular locking with various filesystem locks if the
dropped ref is the final ref. Mapping identities are typically file
descriptions on various filesystems, which in turn call mm functions
under the respective filesystem locks.
PiperOr... |
259,907 | 21.04.2022 11:25:23 | 25,200 | 7bacbb9797dc5bb1c707bfaeef8447d91a27bec9 | Update runtime tests documentation with new versions. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/README.md",
"new_path": "test/runtimes/README.md",
"diff": "@@ -27,23 +27,23 @@ The following `make` targets will run an entire runtime test suite locally.\nNote: java runtime test take 1+ hours with 16 cores.\nLanguage | Version | Running the te... | Go | Apache License 2.0 | google/gvisor | Update runtime tests documentation with new versions.
PiperOrigin-RevId: 443431724 |
259,891 | 21.04.2022 12:30:20 | 25,200 | efb3b7c7e861815271d91821e463d57eba3d59d8 | fix nogo errors from checker SA4006 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/benchmark_test.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/benchmark_test.go",
"diff": "@@ -230,7 +230,6 @@ func BenchmarkVFS2TmpfsStat(b *testing.B) {\nMode: 0644,\n})\nvd.DecRef(ctx)\n- vd = vfs.VirtualDentry{}\nif err != nil {\nb.Fatal... | Go | Apache License 2.0 | google/gvisor | fix nogo errors from checker SA4006
PiperOrigin-RevId: 443448448 |
259,992 | 22.04.2022 09:50:53 | 25,200 | 2a238b23e7c2440110f436619b960ce77cefa04e | Remote checker
Add a generic checker that serializes Points protos to a remote process.
More details here:
Updates | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "examples/seccheck/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"cc_binary\")\n+\n+package(licenses = [\"notice\"])\n+\n+cc_binary(\n+ name = \"server_cc\",\n+ srcs = [\"server.cc\"],\n+ visibility = [\"//:sandbox\"],\n+ deps = [\n+ # any_cc_pro... | Go | Apache License 2.0 | google/gvisor | Remote checker
Add a generic checker that serializes Points protos to a remote process.
More details here: https://docs.google.com/document/d/1RQQKzeFpO-zOoBHZLA-tr5Ed_bvAOLDqgGgKhqUff2A/
Updates #4805
PiperOrigin-RevId: 443690622 |
259,951 | 22.04.2022 10:06:13 | 25,200 | 6d77aa52b8848008e36356124f7af9360b555f17 | Remove unnecessary IsForwardedPacket condition | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/packet_buffer.go",
"new_path": "pkg/tcpip/stack/packet_buffer.go",
"diff": "@@ -176,9 +176,7 @@ func NewPacketBuffer(opts PacketBufferOptions) *PacketBuffer {\nfor _, v := range opts.Data.Views() {\npk.buf.AppendOwned(v)\n}\n- if opts.IsForward... | Go | Apache License 2.0 | google/gvisor | Remove unnecessary IsForwardedPacket condition
PiperOrigin-RevId: 443694489 |
259,962 | 22.04.2022 11:51:07 | 25,200 | 96c9cf74f5eb339f522f0242144f2967be87b5b9 | Return error when handshake fails.
performHandshake should return the last error in case
the handshake fails. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -324,6 +324,12 @@ func (l *listenContext) performHandshake(s *segment, opts header.TCPSynOptions,\nep.Close()\nep.notifyAborted()\nep.drainClosingSegmentQueue()\n+... | Go | Apache License 2.0 | google/gvisor | Return error when handshake fails.
performHandshake should return the last error in case
the handshake fails.
PiperOrigin-RevId: 443721651 |
259,982 | 22.04.2022 13:17:12 | 25,200 | 49ae54c01067e77f1b1cd80e65358bf12a526456 | Fixing memory allocations for tmpfs size.
Fixing partial write memory allocation.
Accounting for memory allocation in hard links.
Adding test cases to check for hard link memory allocation for the same. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -800,25 +800,6 @@ func (fs *filesystem) UnlinkAt(ctx context.Context, rp *vfs.ResolvingPath) error\nif err := vfsObj.PrepareDeleteDentry(mntns, &child.vfsd... | Go | Apache License 2.0 | google/gvisor | Fixing memory allocations for tmpfs size.
Fixing partial write memory allocation.
Accounting for memory allocation in hard links.
Adding test cases to check for hard link memory allocation for the same.
PiperOrigin-RevId: 443742013 |
259,853 | 22.04.2022 15:33:42 | 25,200 | 772e9a4e9b7beac817c402cf05ef0cb9e3957366 | kvm: update a region length when it is extended to the left | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/physical_map.go",
"new_path": "pkg/sentry/platform/kvm/physical_map.go",
"diff": "@@ -115,6 +115,7 @@ func fillAddressSpace() (excludedRegions []region) {\nfor i := range excludedRegions {\nif excludedRegions[i].virtual == addr+current ... | Go | Apache License 2.0 | google/gvisor | kvm: update a region length when it is extended to the left
PiperOrigin-RevId: 443774203 |
259,907 | 26.04.2022 13:08:42 | 25,200 | 68f30cbc5eacf57321dec85811e3be9cf6f28352 | Add test for using two epoll instances to track an FD using EPOLLONESHOT.
The underlying epoll bug was fixed in ("epoll: notify waiters if
ReadEvents adds events"). This adds a regression test for that. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -608,9 +608,11 @@ cc_binary(\n\"//test/util:epoll_util\",\n\"//test/util:eventfd_util\",\n\"//test/util:file_descriptor\",\n+ \"@com_google_absl//absl/synchronization\",\ngtest,\n... | Go | Apache License 2.0 | google/gvisor | Add test for using two epoll instances to track an FD using EPOLLONESHOT.
The underlying epoll bug was fixed in fcd82c8ebf67 ("epoll: notify waiters if
ReadEvents adds events"). This adds a regression test for that.
PiperOrigin-RevId: 444645497 |
259,868 | 26.04.2022 13:33:59 | 25,200 | b5a59f96c8ece5ca47fed43b7fade4bd6d513777 | runsc: Ignore `EROFS` errors when setting up cgroups in `--rootless` mode.
This bypasses cgroup-related errors when running `runsc` in a container with
no permission to create its own cgroups. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -1279,7 +1279,7 @@ func (c *Container) setupCgroupForSubcontainer(conf *config.Config, spec *specs.\nfunc cgroupInstall(conf *config.Config, cg cgroup.Cgroup, res *specs.Lin... | Go | Apache License 2.0 | google/gvisor | runsc: Ignore `EROFS` errors when setting up cgroups in `--rootless` mode.
This bypasses cgroup-related errors when running `runsc` in a container with
no permission to create its own cgroups.
PiperOrigin-RevId: 444652251 |
259,982 | 26.04.2022 16:58:33 | 25,200 | ce91143bdc77ccdebf7aaae9ee8eb4843aa5f880 | Added integration tests for mounting tmpfs with size option enabled. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"diff": "@@ -202,7 +202,7 @@ func (fstype FilesystemType) GetFilesystem(ctx context.Context, vfsObj *vfs.Virt\nvar maxSizeInPages uint64\nif ok {\ndelete(mopts, \"size\")\n- max... | Go | Apache License 2.0 | google/gvisor | Added integration tests for mounting tmpfs with size option enabled.
PiperOrigin-RevId: 444705540 |
259,891 | 27.04.2022 11:22:20 | 25,200 | 7124367b820889d0ac17eaf6fef2f595b6707ab9 | prohibit direct use of sync/atomic (u)int32 functions
Also adds the "// +checkalignedignore" escape hatch for packages to opt out of
checking.
See cl/439349432 for justification (https://github.com/google/gvisor/pull/7376). | [
{
"change_type": "MODIFY",
"old_path": "pkg/atomicbitops/atomicbitops.go",
"new_path": "pkg/atomicbitops/atomicbitops.go",
"diff": "//\n// All read-modify-write operations implemented by this package have\n// acquire-release memory ordering (like sync/atomic).\n+//\n+// +checkalignedignore\npackage ... | Go | Apache License 2.0 | google/gvisor | prohibit direct use of sync/atomic (u)int32 functions
Also adds the "// +checkalignedignore" escape hatch for packages to opt out of
checking.
See cl/439349432 for justification (https://github.com/google/gvisor/pull/7376).
PiperOrigin-RevId: 444918125 |
259,985 | 27.04.2022 14:03:59 | 25,200 | 5afe17a15d04cf16bd569ff9a9ee4699bbed81b8 | cgroupfs: Fix test race with task exit.
The PID controller isn't uncharged synchronously with task exit. The
test checks the PID is released after thread join, which races with
the task being reaped. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/cgroup.cc",
"new_path": "test/syscalls/linux/cgroup.cc",
"diff": "@@ -1214,7 +1214,8 @@ TEST(PIDsCgroup, LimitEnforced) {\nIsPosixErrorOkAndHolds(baseline + 1));\n// Exit the first thread and try create a thread again, which should succeed.... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Fix test race with task exit.
The PID controller isn't uncharged synchronously with task exit. The
test checks the PID is released after thread join, which races with
the task being reaped.
PiperOrigin-RevId: 444960688 |
259,992 | 27.04.2022 15:27:22 | 25,200 | 93185b4eec042019bc9e892326b44e2405162501 | Add container/start Point
Updates | [
{
"change_type": "MODIFY",
"old_path": "examples/seccheck/BUILD",
"new_path": "examples/seccheck/BUILD",
"diff": "@@ -9,6 +9,7 @@ cc_binary(\ndeps = [\n# any_cc_proto placeholder,\n\"//pkg/sentry/seccheck/points:points_cc_proto\",\n+ \"@com_google_absl//absl/cleanup\",\n\"@com_google_absl//absl/stri... | Go | Apache License 2.0 | google/gvisor | Add container/start Point
Updates #4805
PiperOrigin-RevId: 444983390 |
259,985 | 27.04.2022 16:29:04 | 25,200 | 92d84efb1099b60bcbdc79e740be1d24ce37612b | Ignore whitespace changes in seccheck test message. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/checkers/remote/remote_test.go",
"new_path": "pkg/sentry/seccheck/checkers/remote/remote_test.go",
"diff": "@@ -283,8 +283,11 @@ func TestExample(t *testing.T) {\nt.Fatalf(\"ExitNotifyParent: %v\", err)\n}\ncheck := func() error {\n- if got... | Go | Apache License 2.0 | google/gvisor | Ignore whitespace changes in seccheck test message.
PiperOrigin-RevId: 444998438 |
259,891 | 27.04.2022 17:08:28 | 25,200 | 21e95c8a1c7b47df5ba7aa5704662a8e3126047f | make checkaligned error more helpful by printing type name to use | [
{
"change_type": "MODIFY",
"old_path": "tools/checkaligned/checkaligned.go",
"new_path": "tools/checkaligned/checkaligned.go",
"diff": "@@ -35,9 +35,6 @@ var Analyzer = &analysis.Analyzer{\n}\n// blocklist lists prohibited identifiers in the atomic package.\n-//\n-// TODO(b/228378998): We can furthe... | Go | Apache License 2.0 | google/gvisor | make checkaligned error more helpful by printing type name to use
PiperOrigin-RevId: 445007578 |
259,992 | 27.04.2022 18:01:40 | 25,200 | 548d12773965831811b2fe719df0c8c0da4e8a61 | Refactor code to use seccheck.SendToCheckers
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_clone.go",
"new_path": "pkg/sentry/kernel/task_clone.go",
"diff": "@@ -248,7 +248,9 @@ func (t *Task) Clone(args *linux.CloneArgs) (ThreadID, *SyscallControl, error) {\nif seccheck.Global.Enabled(seccheck.PointClone) {\nmask, info := get... | Go | Apache License 2.0 | google/gvisor | Refactor code to use seccheck.SendToCheckers
Updates #4805
PiperOrigin-RevId: 445017536 |
259,966 | 28.04.2022 11:32:12 | 25,200 | 9f41bb6d6279c80907cd843d45f6c7a772f10c1a | Implement remaining multicast routing table operations.
In particular, this change adds support for AddInstalledRoute,
RemoveInstalledRoute, and GetLastUsedTimestamp.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/multicast/BUILD",
"new_path": "pkg/tcpip/network/internal/multicast/BUILD",
"diff": "@@ -9,7 +9,6 @@ go_library(\n],\nvisibility = [\"//visibility:public\"],\ndeps = [\n- \"//pkg/atomicbitops\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/stack... | Go | Apache License 2.0 | google/gvisor | Implement remaining multicast routing table operations.
In particular, this change adds support for AddInstalledRoute,
RemoveInstalledRoute, and GetLastUsedTimestamp.
Updates #7338.
PiperOrigin-RevId: 445205505 |
259,992 | 28.04.2022 12:43:16 | 25,200 | e1c4bbccf9bd27883d3367cbdaad5236fdcb1958 | Add sentry/task_exit point
Updates | [
{
"change_type": "MODIFY",
"old_path": "examples/seccheck/pod_init.json",
"new_path": "examples/seccheck/pod_init.json",
"diff": "},\n{\n\"name\": \"sentry/clone\"\n+ },\n+ {\n+ \"name\": \"sentry/task_exit\"\n}\n],\n\"sinks\": [\n"
},
{
"change_type": "MODIFY",
"old_path": "examples/sec... | Go | Apache License 2.0 | google/gvisor | Add sentry/task_exit point
Updates #4805
PiperOrigin-RevId: 445222912 |
259,966 | 28.04.2022 13:18:28 | 25,200 | ef4a4906936beec151cf92ed41649cd6d1ac8091 | Expire pending multicast packets/routes.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/multicast/route_table.go",
"new_path": "pkg/tcpip/network/internal/multicast/route_table.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"errors\"\n\"fmt\"\n\"sync\"\n+ \"time\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/tc... | Go | Apache License 2.0 | google/gvisor | Expire pending multicast packets/routes.
Updates #7338.
PiperOrigin-RevId: 445231315 |
259,985 | 28.04.2022 13:42:29 | 25,200 | 47b5915a7b31922d83473156f4679a8891ee98e6 | Break Task.mu -> kernfs.Filesystem.mu lock chain when managing cgroups.
This led to circular locking since procfs aquires Task.mu while
holding kernfs.Filesystem.mu. The procfs case is harder to break, as
procfs needs to acquire an mm reference during a filesystem operation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/kernfs.go",
"new_path": "pkg/sentry/fsimpl/kernfs/kernfs.go",
"diff": "// Lock ordering:\n//\n// kernfs.Filesystem.mu\n+// kernel.TaskSet.mu\n+// kernel.Task.mu\n// kernfs.Dentry.dirMu\n// vfs.VirtualFilesystem.mountMu\n// vfs.Dentry.m... | Go | Apache License 2.0 | google/gvisor | Break Task.mu -> kernfs.Filesystem.mu lock chain when managing cgroups.
This led to circular locking since procfs aquires Task.mu while
holding kernfs.Filesystem.mu. The procfs case is harder to break, as
procfs needs to acquire an mm reference during a filesystem operation.
PiperOrigin-RevId: 445237505 |
259,907 | 28.04.2022 18:45:28 | 25,200 | 71764f1b8c3d56bbcdf30e2617a480f8980d6bcd | Generalize lisafs testsuite for external users. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/testsuite/testsuite.go",
"new_path": "pkg/lisafs/testsuite/testsuite.go",
"diff": "@@ -51,15 +51,20 @@ type Tester interface {\n// RunAllLocalFSTests runs all local FS tests as subtests.\nfunc RunAllLocalFSTests(t *testing.T, tester Tester) {\n- ref... | Go | Apache License 2.0 | google/gvisor | Generalize lisafs testsuite for external users.
PiperOrigin-RevId: 445300994 |
259,992 | 29.04.2022 10:29:46 | 25,200 | a1aa00f92298b1ae110a3977d3814e9ca463c072 | Remove TID from task start
This was used to map kernel.Task to goroutines before
kernel.Task.GoroutineID was available. It's not needed anymore. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -1090,9 +1090,7 @@ func (k *Kernel) CreateProcess(args CreateProcessArgs) (*ThreadGroup, ThreadID,\n// StartProcess starts running a process that was created with CreateProces... | Go | Apache License 2.0 | google/gvisor | Remove TID from task start
This was used to map kernel.Task to goroutines before
kernel.Task.GoroutineID was available. It's not needed anymore.
PiperOrigin-RevId: 445452190 |
259,858 | 29.04.2022 16:49:03 | 25,200 | efdf8dd715649b3c47e7c24bafb3cb94bf4de1f8 | Don't push images or the website on tag builds.
Updates | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/release.yaml",
"new_path": ".buildkite/release.yaml",
"diff": "@@ -9,21 +9,21 @@ _templates:\nlimit: 10\n- exit_status: \"*\"\nlimit: 2\n- # This is enforced by the environment hooks on the release agents\n- # as well, only the master branch may be ... | Go | Apache License 2.0 | google/gvisor | Don't push images or the website on tag builds.
Updates #7327
PiperOrigin-RevId: 445535035 |
259,962 | 29.04.2022 17:31:00 | 25,200 | 2d9f1c33297f2803d4eca89ebfeff7cd9ac4138d | Add test to verify zero linger behavior. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"new_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"diff": "@@ -885,6 +885,27 @@ TEST_P(TCPSocketPairTest, SetTCPLingerTimeoutZero) {\nAnyOf(Eq(kMaxTCPLingerTimeout), Eq(kOldMaxTCPLingerTimeout)));\n}\n+T... | Go | Apache License 2.0 | google/gvisor | Add test to verify zero linger behavior.
PiperOrigin-RevId: 445541797 |
259,962 | 29.04.2022 17:31:17 | 25,200 | 19e9ee104a7920342d25705d1bf4de24c4d3faf5 | Bump default gonet.ListenTCP backlog to 4096.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet.go",
"diff": "@@ -64,6 +64,14 @@ func NewTCPListener(s *stack.Stack, wq *waiter.Queue, ep tcpip.Endpoint) *TCPLis\n}\n}\n+// maxListenBacklog is set to be reasonably high for most ... | Go | Apache License 2.0 | google/gvisor | Bump default gonet.ListenTCP backlog to 4096.
Fixes #7379
PiperOrigin-RevId: 445541836 |
259,962 | 29.04.2022 17:37:20 | 25,200 | 2b0646de86b2506c0219433b821956bfa3a0a059 | Move datagram_test to transport_test package.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/datagram_test.go",
"new_path": "pkg/tcpip/transport/datagram_test.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// Package datagram_test has tests shared by datagra... | Go | Apache License 2.0 | google/gvisor | Move datagram_test to transport_test package.
Fixes #7392
PiperOrigin-RevId: 445542709 |
259,992 | 02.05.2022 10:57:49 | 25,200 | 3b269001eba65cb87a731b26fe6dbdf2e9e82000 | Add container/start context fields
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/metadata.go",
"new_path": "pkg/sentry/seccheck/metadata.go",
"diff": "@@ -193,6 +193,7 @@ func init() {\nName: \"env\",\n},\n},\n+ ContextFields: defaultContextFields,\n})\n// Points from the sentry namespace.\n"
},
{
"change_type":... | Go | Apache License 2.0 | google/gvisor | Add container/start context fields
Updates #4805
PiperOrigin-RevId: 445976770 |
259,909 | 02.05.2022 11:38:55 | 25,200 | 32c474d82f653e0d25b77fb07f29f55a769802a0 | Allow multiple FUSE filesystems to share a connection.
Before this change FUSE connections were shared 1:1 with FUSE filesystems, which
is incorrect behavior. A FUSE FD should have a 1:1 relationship with a FUSE
connection, and any number of FUSE filesystems can use the same connection. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/BUILD",
"new_path": "pkg/sentry/fsimpl/fuse/BUILD",
"diff": "@@ -32,6 +32,7 @@ go_library(\n\"connection.go\",\n\"connection_control.go\",\n\"dev.go\",\n+ \"dev_state.go\",\n\"directory.go\",\n\"file.go\",\n\"fusefs.go\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Allow multiple FUSE filesystems to share a connection.
Before this change FUSE connections were shared 1:1 with FUSE filesystems, which
is incorrect behavior. A FUSE FD should have a 1:1 relationship with a FUSE
connection, and any number of FUSE filesystems can use the same connection.
PiperOrigin-RevId: 445988328 |
259,858 | 02.05.2022 12:34:27 | 25,200 | 87180c225b6756edde0b7fb742288233c6c722c4 | Stop clobbering the signed packages.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "tools/make_apt.sh",
"new_path": "tools/make_apt.sh",
"diff": "@@ -92,7 +92,7 @@ keyid=$(\nawk '{print $2;}')\nreadonly keyid\n-# Copy the packages into the root.\n+# Copy the packages into the pool.\nfor pkg in \"$@\"; do\nif ! [[ -f \"${pkg}\" ]]; then\nconti... | Go | Apache License 2.0 | google/gvisor | Stop clobbering the signed packages.
Fixes #5635
PiperOrigin-RevId: 446002436 |
259,898 | 02.05.2022 15:27:07 | 25,200 | 4ee0a226fe86226766ed02e36d69424214ac9def | Remove unnecessary cleanupLocked
handshakeFailed already calls cleanupLocked at the end, there's no need to
cleanup twice the same endpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -2488,7 +2488,6 @@ func (e *endpoint) Shutdown(flags tcpip.ShutdownFlags) tcpip.Error {\n// method because that method is called during a close(2) (and closing... | Go | Apache License 2.0 | google/gvisor | Remove unnecessary cleanupLocked
handshakeFailed already calls cleanupLocked at the end, there's no need to
cleanup twice the same endpoint.
PiperOrigin-RevId: 446043917 |
259,891 | 16.09.2021 17:18:19 | 25,200 | 88b2fc0942ea567768eef5427d1c0630b8a83a9c | hostinet: allow getsockopt(SO_RCVTIMEO) and getsockopt(SO_SNDTIMEO)
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -401,6 +401,8 @@ func (s *socketOpsCommon) GetSockOpt(t *kernel.Task, level int, name int, optVal\noptlen = sizeofInt32\ncase linux.SO_LINGER:\noptlen = unix... | Go | Apache License 2.0 | google/gvisor | hostinet: allow getsockopt(SO_RCVTIMEO) and getsockopt(SO_SNDTIMEO)
Fixes #6603 |
259,907 | 02.05.2022 17:36:40 | 25,200 | ea45573148e0656e5e3412f5a5db9cd823f5a2a0 | Update comments about tmpfs size.
Removed old TODO from VFS1. We will not support this option on VFS1.
Enhanced comments about how tmpfs pages are accounted for by write(2)s. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fs/tmpfs/tmpfs.go",
"diff": "@@ -40,7 +40,7 @@ var fsInfo = fs.Info{\n// of 0. To work around this, claim to have a very large but non-zero size,\n// chosen to ensure that BlockSize * Blocks does not overf... | Go | Apache License 2.0 | google/gvisor | Update comments about tmpfs size.
- Removed old TODO from VFS1. We will not support this option on VFS1.
- Enhanced comments about how tmpfs pages are accounted for by write(2)s.
PiperOrigin-RevId: 446072121 |
260,004 | 03.05.2022 21:15:10 | 25,200 | da0c67b92a733ac4460791be41815ca33a9ceab1 | Use different flags for IPV6_RECVERR and IP_RECVERR | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1447,7 +1447,7 @@ func getSockOptIPv6(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, name\nreturn nil, syserr.ErrInvalidArgument\n}\n- v := prim... | Go | Apache License 2.0 | google/gvisor | Use different flags for IPV6_RECVERR and IP_RECVERR
PiperOrigin-RevId: 446361103 |
259,885 | 04.05.2022 15:20:58 | 25,200 | b86c98c82bb219e9aa68b319a6aa582290a95c8b | Check file permissions before VFS2 overlayfs open. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"new_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"diff": "@@ -782,7 +782,6 @@ func (fs *filesystem) MknodAt(ctx context.Context, rp *vfs.ResolvingPath, opts v\nfunc (fs *filesystem) OpenAt(ctx context.Context, rp... | Go | Apache License 2.0 | google/gvisor | Check file permissions before VFS2 overlayfs open.
PiperOrigin-RevId: 446565359 |
260,004 | 05.05.2022 12:50:29 | 25,200 | bb36c43e97fdece0505d4a7df382af0fc4582b6d | Respect SO_SNDBUF for network datagram endpoints
Previously, SO_SNDBUF was effectively a no-op. The stack should make
sure that only SO_SNDBUF bytes are ever in-flight for any given
socket/endpoint.
Fuchsia Bug: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/packet_buffer.go",
"new_path": "pkg/tcpip/stack/packet_buffer.go",
"diff": "@@ -53,6 +53,10 @@ type PacketBufferOptions struct {\n// IsForwardedPacket identifies that the PacketBuffer being created is for a\n// forwarded packet.\nIsForwardedPac... | Go | Apache License 2.0 | google/gvisor | Respect SO_SNDBUF for network datagram endpoints
Previously, SO_SNDBUF was effectively a no-op. The stack should make
sure that only SO_SNDBUF bytes are ever in-flight for any given
socket/endpoint.
Fuchsia Bug: https://fxbug.dev/99070
PiperOrigin-RevId: 446792223 |
259,992 | 06.05.2022 09:25:54 | 25,200 | a23e60af39011c95150a1184f80d97a599ac92fd | Fire clone point for thread creation
Thread creation tracking is required by Falco.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_clone.go",
"new_path": "pkg/sentry/kernel/task_clone.go",
"diff": "@@ -245,8 +245,8 @@ func (t *Task) Clone(args *linux.CloneArgs) (ThreadID, *SyscallControl, error) {\n// nt that it must receive before its task goroutine starts running.... | Go | Apache License 2.0 | google/gvisor | Fire clone point for thread creation
Thread creation tracking is required by Falco.
Updates #4805
PiperOrigin-RevId: 447003670 |
260,009 | 06.05.2022 12:18:45 | 25,200 | 7574e4f6428591429ef68f6dbbc2534b99af64d0 | Add KVM specific metrics.
This change adds counter and timer metrics useful for analyzing the KVM
platform. | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -417,7 +417,7 @@ func MustCreateNewUint64NanosecondsMetric(name string, sync bool, description st\n// This must be called with the correct number of field values or it will panic.\n//go:nos... | Go | Apache License 2.0 | google/gvisor | Add KVM specific metrics.
This change adds counter and timer metrics useful for analyzing the KVM
platform.
PiperOrigin-RevId: 447043888 |
260,004 | 06.05.2022 12:21:24 | 25,200 | a96653a412058405b541987dd0820c918c88c23d | Only return ErrNoBufferSpace if RECVERR is set
...to match Linux behaviour. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/BUILD",
"new_path": "pkg/tcpip/transport/BUILD",
"diff": "@@ -23,6 +23,7 @@ go_test(\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/link/loopback\",\n\"//pkg/tcpip/network/ipv4\",\n+ \"//pkg/tcpip/network/ipv6\",\n\"//pkg/tcpip/stack\",\n\"//pkg/t... | Go | Apache License 2.0 | google/gvisor | Only return ErrNoBufferSpace if RECVERR is set
...to match Linux behaviour.
PiperOrigin-RevId: 447044373 |
259,909 | 06.05.2022 14:39:41 | 25,200 | 592fc1bb5041f3ffbde54fa3c7132b0d73715223 | Convert fdbased link endpoints to use pkg/buffer instead of VectorizedViews. | [
{
"change_type": "MODIFY",
"old_path": "pkg/buffer/view.go",
"new_path": "pkg/buffer/view.go",
"diff": "@@ -33,6 +33,19 @@ type View struct {\npool pool\n}\n+// NewWithData creates a new view initialized with given data.\n+func NewWithData(b []byte) View {\n+ v := View{\n+ size: int64(len(b)),\n+ }\... | Go | Apache License 2.0 | google/gvisor | Convert fdbased link endpoints to use pkg/buffer instead of VectorizedViews.
PiperOrigin-RevId: 447073885 |
259,992 | 06.05.2022 14:51:20 | 25,200 | 71add3739048a97ec27db0c01fc4e84c0a64f2ac | Move test server into a separate package
It will be used for tests in other packages.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/checkers/remote/BUILD",
"new_path": "pkg/sentry/seccheck/checkers/remote/BUILD",
"diff": "@@ -13,6 +13,7 @@ go_library(\n\"//pkg/fd\",\n\"//pkg/log\",\n\"//pkg/sentry/seccheck\",\n+ \"//pkg/sentry/seccheck/checkers/remote/header\",\n\"//pkg... | Go | Apache License 2.0 | google/gvisor | Move test server into a separate package
It will be used for tests in other packages.
Updates #4805
PiperOrigin-RevId: 447076300 |
259,985 | 06.05.2022 16:04:18 | 25,200 | 409f32743b6e728ceb2c12da7252fa73b8df9131 | cgroupfs: Per cgroups(7), PID/TID 0 refers to the current task. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -363,7 +363,13 @@ func (d *cgroupProcsData) Write(ctx context.Context, fd *vfs.FileDescription, sr\nt := kernel.TaskFromContext(ctx)\ncurrPidns := t.ThreadGroup(... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Per cgroups(7), PID/TID 0 refers to the current task.
PiperOrigin-RevId: 447090229 |
259,992 | 09.05.2022 10:30:54 | 25,200 | b3609b7167a76a11d42dad8d5b0fa77a9fd87974 | Fix race in remote_test.go | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/checkers/remote/remote_test.go",
"new_path": "pkg/sentry/seccheck/checkers/remote/remote_test.go",
"diff": "@@ -21,6 +21,7 @@ import (\n\"os/exec\"\n\"path/filepath\"\n\"strings\"\n+ \"sync\"\n\"testing\"\n\"time\"\n@@ -46,10 +47,28 @@ func... | Go | Apache License 2.0 | google/gvisor | Fix race in remote_test.go
PiperOrigin-RevId: 447505504 |
259,868 | 09.05.2022 19:09:59 | 25,200 | 3c0fe6d08d5f318d14a6e1c355db5aa96feb31d5 | BuildKite: Remove duplicate `jq` from list of packages to install.
It is already listed earlier in the command line.
Ordinarily I wouldn't make a change for something this small, but I'm
going to use this change as a means to dip my toes with the BuildKite
build pipeline. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -10,8 +10,7 @@ function install_pkgs() {\ndone\n}\ninstall_pkgs make linux-libc-dev graphviz jq curl binutils gnupg gnupg-agent \\\n- gcc pkg-config apt-transport-https ca-c... | Go | Apache License 2.0 | google/gvisor | BuildKite: Remove duplicate `jq` from list of packages to install.
It is already listed earlier in the command line.
Ordinarily I wouldn't make a change for something this small, but I'm
going to use this change as a means to dip my toes with the BuildKite
build pipeline.
PiperOrigin-RevId: 447618014 |
259,891 | 10.05.2022 11:57:34 | 25,200 | a514a12c09e52d9962ac2e641dc5f804fc273abf | netstack: reduce allocations
Calls to IPTables.Check* functions were allocating on every single call, even
when IPTables were disabled. Changing from a method pointer to a function
pointer is enough to let the compiler know that nothing escapes and no
allocations are necessary. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -306,11 +306,11 @@ func (it *IPTables) shouldSkipOrPopulateTables(tables []checkTable, pkt *PacketB\nfunc (it *IPTables) CheckPrerouting(pkt *PacketBuffer, addressEP Addressab... | Go | Apache License 2.0 | google/gvisor | netstack: reduce allocations
Calls to IPTables.Check* functions were allocating on every single call, even
when IPTables were disabled. Changing from a method pointer to a function
pointer is enough to let the compiler know that nothing escapes and no
allocations are necessary.
PiperOrigin-RevId: 447792280 |
259,853 | 10.05.2022 13:22:17 | 25,200 | 3aab92297af5c95b866e1be878a0230d5f97a9b6 | Add new locks with the correctness validator
All locks are separated into classes. The validator builds a dependency
graph and checks that it doesn't have cycles. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/sync/locking/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+load(\"//tools/go_generics:defs.bzl\", \"go_template\", \"go_template_instance\")\n+load(\"//pkg/sync/locking:locking.bzl\", \"declare_mutex\", \"declar... | Go | Apache License 2.0 | google/gvisor | Add new locks with the correctness validator
All locks are separated into classes. The validator builds a dependency
graph and checks that it doesn't have cycles.
PiperOrigin-RevId: 447812244 |
259,891 | 10.05.2022 13:24:59 | 25,200 | f0737cc307f6e503cae1fb0063189e6ef8eebdb3 | netstack: use checkescape in iptables hot paths
These functions used to allocate even when iptables were disabled. Prevent that
from happening again.
Update to also use gVisor's sync package, as we were using the standard one. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -273,6 +273,10 @@ type checkTable struct {\n//\n// If IPTables should not be skipped, tables will be updated with the\n// specified table.\n+//\n+// This is called in the hot ... | Go | Apache License 2.0 | google/gvisor | netstack: use checkescape in iptables hot paths
These functions used to allocate even when iptables were disabled. Prevent that
from happening again.
Update to also use gVisor's sync package, as we were using the standard one.
PiperOrigin-RevId: 447812920 |
259,951 | 10.05.2022 13:30:17 | 25,200 | 944b941f9d4196dcd00aa2cce0bc1f087697718c | Allow martian packets on packet socket dgram tests
Before this change, this test fixture expected it to be enabled already
instead of updating the config.
The Teardown method also restore the initial configuration, so that
these tests do not permanently change the config of the machines that
run the tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/packet_socket_dgram.cc",
"new_path": "test/syscalls/linux/packet_socket_dgram.cc",
"diff": "@@ -122,6 +122,9 @@ class CookedPacketTest : public ::testing::TestWithParam<int> {\n// The socket used for both reading and writing.\nint socket_;\... | Go | Apache License 2.0 | google/gvisor | Allow martian packets on packet socket dgram tests
Before this change, this test fixture expected it to be enabled already
instead of updating the config.
The Teardown method also restore the initial configuration, so that
these tests do not permanently change the config of the machines that
run the tests.
PiperOrig... |
259,992 | 10.05.2022 17:06:14 | 25,200 | f62143f31fe5596241a844aead15aefe9db9c816 | Ensure that errors from the shim are properly translated
Golang wrapped errors are lost when they go through gRPC. Every
error returned from `task.TaskService` interface should be
translated using `errdefs.ToGRPC`.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/proc/BUILD",
"new_path": "pkg/shim/proc/BUILD",
"diff": "@@ -23,7 +23,6 @@ go_library(\n\"//pkg/atomicbitops\",\n\"//pkg/cleanup\",\n\"//pkg/shim/runsc\",\n- \"//pkg/shim/utils\",\n\"@com_github_containerd_console//:go_default_library\",\n\"@com_githu... | Go | Apache License 2.0 | google/gvisor | Ensure that errors from the shim are properly translated
Golang wrapped errors are lost when they go through gRPC. Every
error returned from `task.TaskService` interface should be
translated using `errdefs.ToGRPC`.
Fixes #7504
PiperOrigin-RevId: 447863123 |
259,868 | 10.05.2022 17:27:53 | 25,200 | 6af4eedc21c2f4979a16203ce74fa61f007151f1 | runsc: Support `%ID%` substitution in more path flags than just `--debug-log`.
This allows things like CPU profiles to be written out to sandbox-specific
file paths. | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/runsc/utils.go",
"new_path": "pkg/shim/runsc/utils.go",
"diff": "@@ -36,20 +36,52 @@ func putBuf(b *bytes.Buffer) {\nbytesBufferPool.Put(b)\n}\n-// FormatRunscLogPath parses runsc config, and fill in %ID% in the log path.\n-func FormatRunscLogPath(id ... | Go | Apache License 2.0 | google/gvisor | runsc: Support `%ID%` substitution in more path flags than just `--debug-log`.
This allows things like CPU profiles to be written out to sandbox-specific
file paths.
PiperOrigin-RevId: 447867091 |
259,853 | 10.05.2022 22:14:27 | 25,200 | 3f44cd556b7fda0c56b4665959c52afc5e425d88 | sentry/socket: don't release a connected enpoint under the endpoint mutex
It isn't required and can have side effects. For example, the current endpoint
can be in an SCM message that is queued to the connected endpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/connectionless.go",
"new_path": "pkg/sentry/socket/unix/transport/connectionless.go",
"diff": "@@ -59,10 +59,8 @@ func (e *connectionlessEndpoint) isBound() bool {\n// with it.\nfunc (e *connectionlessEndpoint) Close(ctx contex... | Go | Apache License 2.0 | google/gvisor | sentry/socket: don't release a connected enpoint under the endpoint mutex
It isn't required and can have side effects. For example, the current endpoint
can be in an SCM message that is queued to the connected endpoint.
PiperOrigin-RevId: 447906621 |
259,891 | 11.05.2022 11:04:55 | 25,200 | 9bc06340b225f78d98f3955dbd26e451a0ffab74 | Describe what iptables checkescape covers specifically | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -275,8 +275,11 @@ type checkTable struct {\n// specified table.\n//\n// This is called in the hot path even when iptables are disabled, so we ensure\n-// it does not allocate.... | Go | Apache License 2.0 | google/gvisor | Describe what iptables checkescape covers specifically
PiperOrigin-RevId: 448037248 |
259,858 | 11.05.2022 13:49:29 | 25,200 | 74f3befece71bd5fe3262a4309cd859494fcebb1 | Convert pipeline to use common metrics publisher. | [
{
"change_type": "MODIFY",
"old_path": "images/agent/Dockerfile",
"new_path": "images/agent/Dockerfile",
"diff": "@@ -2,11 +2,6 @@ FROM golang:1.15 as build-agent\nRUN git clone --depth=1 --branch=v3.25.0 https://github.com/buildkite/agent\nRUN cd agent && go build -i -o /buildkite-agent .\n-FROM go... | Go | Apache License 2.0 | google/gvisor | Convert pipeline to use common metrics publisher.
PiperOrigin-RevId: 448075984 |
259,982 | 11.05.2022 18:33:34 | 25,200 | a7cad2b092de8430562886ceaa57c14c6eec7763 | Tmpfs with size option enabled bug fix.
Adding test case to check empty size parsing in Linux.
If a value is not passed with size the mount(2) should return EINVAL.
Handling empty size parsing in gVisor. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"diff": "@@ -204,7 +204,7 @@ func (fstype FilesystemType) GetFilesystem(ctx context.Context, vfsObj *vfs.Virt\ndelete(mopts, \"size\")\nmaxSizeInBytes, err := parseSize(maxSizeS... | Go | Apache License 2.0 | google/gvisor | Tmpfs with size option enabled bug fix.
Adding test case to check empty size parsing in Linux.
If a value is not passed with size the mount(2) should return EINVAL.
Handling empty size parsing in gVisor.
PiperOrigin-RevId: 448132149 |
259,858 | 12.05.2022 14:39:03 | 25,200 | 47b001caef9b26d1842bce8c59e5bbc2b96052ed | Set the default queue for the pipeline. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -20,6 +20,9 @@ _templates:\nBENCHMARKS_PROJECT: gvisor-benchmarks\nBENCHMARKS_TABLE: benchmarks\nBENCHMARKS_UPLOAD: true\n+ agents:\n+ arch: \"amd64\"\n+ kvm: \"true\"\nnetstack_tes... | Go | Apache License 2.0 | google/gvisor | Set the default queue for the pipeline.
PiperOrigin-RevId: 448341915 |
259,907 | 12.05.2022 15:46:17 | 25,200 | 14c5686d5058e74a2e31bc1129cb63c92eae8d0c | Add instructions on how to clean up exclude file for runtime tests. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/README.md",
"new_path": "test/runtimes/README.md",
"diff": "@@ -79,6 +79,34 @@ To bump the version of an existing runtime test:\n[exclude](exclude) file for the new version, and they will be skipped in\nfuture runs.\n+### Cleaning up exclude file... | Go | Apache License 2.0 | google/gvisor | Add instructions on how to clean up exclude file for runtime tests.
PiperOrigin-RevId: 448356710 |
259,985 | 12.05.2022 16:05:56 | 25,200 | 7eec8dcf9a0135f9449d6a88763b66b71910acb7 | mm: Protect mm.dumpability with atomic access instead of mm.metadataMu.
Previously, this was a lock order violation, as mm.metadataMutex ->
mm.mappingRWMutex -> kernel.taskSetRWMutex is required when forking
the task image, and ptrace aquired kernel.taskSetRWMutex ->
mm.metadataMutex to check dumpability.
Ptrace doesn'... | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/lifecycle.go",
"new_path": "pkg/sentry/mm/lifecycle.go",
"diff": "@@ -36,7 +36,7 @@ func NewMemoryManager(p platform.Platform, mfp pgalloc.MemoryFileProvider, sleep\nprivateRefs: &privateRefs{},\nusers: atomicbitops.FromInt32(1),\nauxv: arch.Auxv... | Go | Apache License 2.0 | google/gvisor | mm: Protect mm.dumpability with atomic access instead of mm.metadataMu.
Previously, this was a lock order violation, as mm.metadataMutex ->
mm.mappingRWMutex -> kernel.taskSetRWMutex is required when forking
the task image, and ptrace aquired kernel.taskSetRWMutex ->
mm.metadataMutex to check dumpability.
Ptrace does... |
259,966 | 12.05.2022 16:06:53 | 25,200 | e916e4fde31b035f7776449073a7532ec352e9e9 | Remove the MonotonicTime.Nanoseconds() accessor.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/multicast/example_test.go",
"new_path": "pkg/tcpip/network/internal/multicast/example_test.go",
"diff": "@@ -103,7 +103,7 @@ func Example() {\npanic(fmt.Sprintf(\"table.GetLastUsedTimestamp(%#v) = (_, false)\", routeKey))\n}\n- fmt.P... | Go | Apache License 2.0 | google/gvisor | Remove the MonotonicTime.Nanoseconds() accessor.
Updates #7338.
PiperOrigin-RevId: 448360987 |
259,985 | 12.05.2022 16:09:27 | 25,200 | 700014c960df86707bd8ddb907eeaf210b31e208 | cgroupfs: Allow explicit "/" as initial cgroup. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"diff": "@@ -364,10 +364,14 @@ func (fs *filesystem) prepareInitialCgroup(ctx context.Context, vfsObj *vfs.Virt\n}\nctx.Debugf(\"cgroupfs.FilesystemType.GetFilesyste... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Allow explicit "/" as initial cgroup.
PiperOrigin-RevId: 448361452 |
260,009 | 12.05.2022 18:09:34 | 25,200 | db16575cb5fd54e1d910412c1d0a7c2492450fc1 | KVM machine.Get(): Use up vCPU pool before scanning for available ones.
Previously, we created vCPUs on demand, and so taking an unused vCPU from the
pool was expensive. Now, we pre-create all vCPUs at the start, so it makes
sense to use them all to reduce contention. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -476,29 +476,29 @@ func (m *machine) Get() *vCPU {\n}\nfor {\n- // Scan for an available vCPU.\n- for origTID, c := range m.vCPUsByTID {\n- if c.state.CompareAnd... | Go | Apache License 2.0 | google/gvisor | KVM machine.Get(): Use up vCPU pool before scanning for available ones.
Previously, we created vCPUs on demand, and so taking an unused vCPU from the
pool was expensive. Now, we pre-create all vCPUs at the start, so it makes
sense to use them all to reduce contention.
PiperOrigin-RevId: 448382485 |
259,853 | 12.05.2022 18:09:36 | 25,200 | d44862f6725c585792e4181b74c74bc82a9d5886 | sentry/socket: use lockdep mutexes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/BUILD",
"new_path": "pkg/sentry/socket/unix/transport/BUILD",
"diff": "@@ -3,6 +3,39 @@ load(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\npackage(licenses = [\"notice\"])\n+go_template_instance(\n+ name = \"queu... | Go | Apache License 2.0 | google/gvisor | sentry/socket: use lockdep mutexes
PiperOrigin-RevId: 448382489 |
259,966 | 13.05.2022 09:11:22 | 25,200 | add538a44f15b449f24f262cdd85844c2b26d6e2 | Run multicast cleanup routine only when needed.
Aside from saving resources, this is also a workaround for the case where
timers are bound after the netstack is initialized.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/multicast/route_table.go",
"new_path": "pkg/tcpip/network/internal/multicast/route_table.go",
"diff": "@@ -52,12 +52,14 @@ type RouteTable struct {\npendingMu sync.RWMutex\n// +checklocks:pendingMu\npendingRoutes map[RouteKey]Pending... | Go | Apache License 2.0 | google/gvisor | Run multicast cleanup routine only when needed.
Aside from saving resources, this is also a workaround for the case where
timers are bound after the netstack is initialized.
Updates #7338.
PiperOrigin-RevId: 448509194 |
259,992 | 13.05.2022 12:22:46 | 25,200 | fa2a88887d23ca5cb385e26ecad2b97448ed81ab | Deprecate --vfs2 flag and always enable by default
Also remove VFS1 dimension from runsc unit tests.
Updates
Startblock:
after 2022-05-30 | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs_test.go",
"new_path": "runsc/boot/fs_test.go",
"diff": "@@ -243,7 +243,7 @@ func TestGetMountAccessType(t *testing.T) {\nt.Fatalf(\"newPodMountHints failed: %v\", err)\n}\nmounter := containerMounter{hints: podHints}\n- conf := &config.Config{Fil... | Go | Apache License 2.0 | google/gvisor | Deprecate --vfs2 flag and always enable by default
Also remove VFS1 dimension from runsc unit tests.
Updates #1624
Startblock:
after 2022-05-30
PiperOrigin-RevId: 448552271 |
259,992 | 13.05.2022 12:23:44 | 25,200 | e189fb68860820c1903dc12fe3c7670d9ceacde2 | Add version handshake before communication is stablished
Details on how it works is in wire.Handshake.
Updates | [
{
"change_type": "MODIFY",
"old_path": "examples/seccheck/server.cc",
"new_path": "examples/seccheck/server.cc",
"diff": "#include \"absl/cleanup/cleanup.h\"\n#include \"absl/strings/string_view.h\"\n+#include \"pkg/sentry/seccheck/points/common.pb.h\"\n#include \"pkg/sentry/seccheck/points/containe... | Go | Apache License 2.0 | google/gvisor | Add version handshake before communication is stablished
Details on how it works is in wire.Handshake.
Updates #4805
PiperOrigin-RevId: 448552448 |
260,004 | 13.05.2022 13:51:56 | 25,200 | ae508f406429537e77252fcc7336460a7a653a87 | Track packets dropped by full device TX queue
QDisc/LinkEndpoint may drop packets if the device's send/transmit queue
is full.
BUG: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -88,6 +88,7 @@ var Metrics = tcpip.Stats{\nPackets: mustCreateMetric(\"/netstack/nic/tx/packets\", \"Number of packets transmitted.\"),\nBytes: mustCreat... | Go | Apache License 2.0 | google/gvisor | Track packets dropped by full device TX queue
QDisc/LinkEndpoint may drop packets if the device's send/transmit queue
is full.
BUG: https://fxbug.dev/98974
PiperOrigin-RevId: 448570489 |
260,009 | 13.05.2022 14:22:01 | 25,200 | 3b83c30622c043d57a393b26018ad6a41b924684 | Fix regression in KVM due to metric in machine.Get().
Replaced timer metric with counter, which seems to give similar performance to
removing the metric outright. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -124,11 +124,10 @@ var (\nmmapCallCounter = metric.MustCreateNewUint64Metric(\n\"/kvm/mmap_calls\", false, \"The number of times seccompMmapSyscall has been call... | Go | Apache License 2.0 | google/gvisor | Fix regression in KVM due to metric in machine.Get().
Replaced timer metric with counter, which seems to give similar performance to
removing the metric outright.
PiperOrigin-RevId: 448576866 |
260,000 | 16.05.2022 12:37:21 | 25,200 | ba4d6451635181d96a424d9a2644db4dba17084c | Add debug.SetTraceback for runsc-gofer
The -traceback flag sets the Debug.SetTraceback for runsc-sandbox.
We need this for gofer too. Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"fmt\"\n\"os\"\n\"path/filepath\"\n+ \"runtime/debug\"\n\"strings\"\n\"github.com/google/subcommands\"\n@@ -99,6 +100,9 @@ func (g *Gofer) Execute(_ context.Context, f... | Go | Apache License 2.0 | google/gvisor | Add debug.SetTraceback for runsc-gofer
The -traceback flag sets the Debug.SetTraceback for runsc-sandbox.
We need this for gofer too. Fixes #7583 |
259,853 | 16.05.2022 15:09:21 | 25,200 | 58e9ba2724a7b8e07cdd4d2915119ee11d02f830 | buildkite: don't run docker tests on COS
On COS, buildkite agents are running inside docker containers and so
we can't modify a docker config and restart a docker daemon. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -39,6 +39,9 @@ fi\n# Clear existing profiles.\nsudo rm -rf /tmp/profile\n+# Allow to read dmesg for all users. It is required for the syslog test.\n+sudo sysctl -w kernel.dm... | Go | Apache License 2.0 | google/gvisor | buildkite: don't run docker tests on COS
On COS, buildkite agents are running inside docker containers and so
we can't modify a docker config and restart a docker daemon.
PiperOrigin-RevId: 449063929 |
259,853 | 16.05.2022 20:12:56 | 25,200 | 251f2c0561bd91db414658c37db8b25afa7cfc40 | mm: use lockdep mutexes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/BUILD",
"new_path": "pkg/sentry/mm/BUILD",
"diff": "load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\nload(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\n+load(\"//pkg/sync/locking:locking.bzl\", \"declare_mutex\", \"declare_... | Go | Apache License 2.0 | google/gvisor | mm: use lockdep mutexes
PiperOrigin-RevId: 449117356 |
259,853 | 17.05.2022 22:48:10 | 25,200 | 2ed45d09645283d358d393b05661df72e6b0de50 | buildkite: run "Release tests" on amd64
This test fails on arm64:
ERROR: vdso/BUILD:12:8: Executing genrule //vdso:vdso failed: (Exit 1):
bash failed: error executing command /bin/bash -c ...
Use --sandbox_debug to see verbose messages from the sandbox
gcc: error: unrecognized command line option '-m64'
Target //runsc:... | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -111,6 +111,8 @@ steps:\n- make BAZEL_OPTIONS=--config=x86_64 artifacts/x86_64\n- make BAZEL_OPTIONS=--config=aarch64 artifacts/aarch64\n- make release\n+ agents:\n+ arch: \"amd64\"... | Go | Apache License 2.0 | google/gvisor | buildkite: run "Release tests" on amd64
This test fails on arm64:
ERROR: vdso/BUILD:12:8: Executing genrule //vdso:vdso failed: (Exit 1):
bash failed: error executing command /bin/bash -c ...
Use --sandbox_debug to see verbose messages from the sandbox
gcc: error: unrecognized command line option '-m64'
Target //runs... |
259,907 | 18.05.2022 00:52:48 | 25,200 | bda5ce7977bd88379ba59291e2a9ef04a98ce239 | Simplify codebase.
Ran gofmt -w -s ./ | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid_test.go",
"new_path": "pkg/cpuid/cpuid_test.go",
"diff": "@@ -18,7 +18,7 @@ import \"testing\"\nfunc TestFeatureFromString(t *testing.T) {\n// Check that known features do match.\n- for feature, _ := range allFeatures {\n+ for feature := range ... | Go | Apache License 2.0 | google/gvisor | Simplify codebase.
Ran gofmt -w -s ./
PiperOrigin-RevId: 449415155 |
259,966 | 18.05.2022 08:27:50 | 25,200 | 98f5323163c41328aea6845a516d560bbfa8065b | Use testutil.MustParse4/6 instead of net.ParseIP in tcpip test utils.
Also dedupe the RemoteIPv4Addr.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tests/utils/BUILD",
"new_path": "pkg/tcpip/tests/utils/BUILD",
"diff": "@@ -4,6 +4,7 @@ package(licenses = [\"notice\"])\ngo_library(\nname = \"utils\",\n+ testonly = True,\nsrcs = [\"utils.go\"],\nvisibility = [\"//pkg/tcpip/tests:__subpackages__\"]... | Go | Apache License 2.0 | google/gvisor | Use testutil.MustParse4/6 instead of net.ParseIP in tcpip test utils.
Also dedupe the RemoteIPv4Addr.
Updates #7338.
PiperOrigin-RevId: 449488567 |
259,992 | 18.05.2022 10:38:10 | 25,200 | 59b059b59556c55a23a4a60f81724646a49ac402 | Update containerd to v1.4.12
Closes | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -719,8 +719,8 @@ go_repository(\nname = \"com_github_containerd_containerd\",\nbuild_file_proto_mode = \"disable\",\nimportpath = \"github.com/containerd/containerd\",\n- sum = \"h1:K2U/F4jGAMBqeUssfgJRbFuomLcS2... | Go | Apache License 2.0 | google/gvisor | Update containerd to v1.4.12
Closes #6232
PiperOrigin-RevId: 449518615 |
259,975 | 18.05.2022 11:48:26 | 25,200 | 671bd7b0f8971d77309fef5143cf2f92b696e52b | Don't clobber /etc/docker/config.json on debian updates. | [
{
"change_type": "MODIFY",
"old_path": "debian/postinst.sh",
"new_path": "debian/postinst.sh",
"diff": "@@ -20,7 +20,7 @@ fi\n# Update docker configuration.\nif [ -f /etc/docker/daemon.json ]; then\n- runsc install\n+ runsc install --clobber=false\nif systemctl is-active -q docker; then\nsystemctl r... | Go | Apache License 2.0 | google/gvisor | Don't clobber /etc/docker/config.json on debian updates.
PiperOrigin-RevId: 449537553 |
259,858 | 18.05.2022 13:55:29 | 25,200 | b50636d376ec74287dfe35c25783d887d7682a06 | Add rsync to required packages. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -10,7 +10,8 @@ function install_pkgs() {\ndone\n}\ninstall_pkgs make linux-libc-dev graphviz jq curl binutils gnupg gnupg-agent \\\n- gcc pkg-config apt-transport-https ca-c... | Go | Apache License 2.0 | google/gvisor | Add rsync to required packages.
PiperOrigin-RevId: 449569318 |
259,868 | 18.05.2022 14:11:00 | 25,200 | 4dcac904e1e491c0a701d4908a003f3b17e93b69 | Add `all_benchmarks` fileset containing all benchmark binaries. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/linux/BUILD",
"new_path": "test/perf/linux/BUILD",
"diff": "@@ -5,6 +5,12 @@ package(\nlicenses = [\"notice\"],\n)\n+filegroup(\n+ name = \"all_benchmarks\",\n+ testonly = 1,\n+ data = [\":%s\" % f[:-3] for f in glob([\"*_benchmark.cc\"])],\n+)\n+\nc... | Go | Apache License 2.0 | google/gvisor | Add `all_benchmarks` fileset containing all benchmark binaries.
PiperOrigin-RevId: 449573479 |
259,868 | 18.05.2022 15:11:55 | 25,200 | c9f8b165cfc5d2fdd56af488dfd1844d869de740 | Cache each thread group's TID within their own namespace.
This avoids requiring a lock in `ThreadGroup.ID`, which in turn breaks the
following lock cycle:
`kernel.taskSetRWMutex` -> `kernel.taskMutex` -> `mm.metadataMutex`
> `mm.mappingRWMutex` -> `kernel.taskSetRWMutex`
(Also, less locking within `createVMALocked` is ... | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_exit.go",
"new_path": "pkg/sentry/kernel/task_exit.go",
"diff": "@@ -692,6 +692,7 @@ func (t *Task) exitNotifyLocked(fromPtraceDetach bool) {\n// is via a call to release_task()).\nt.tg.leader.exitNotifyLocked(false)\n} else if tc == 0 {... | Go | Apache License 2.0 | google/gvisor | Cache each thread group's TID within their own namespace.
This avoids requiring a lock in `ThreadGroup.ID`, which in turn breaks the
following lock cycle:
`kernel.taskSetRWMutex` -> `kernel.taskMutex` -> `mm.metadataMutex`
-> `mm.mappingRWMutex` -> `kernel.taskSetRWMutex`
(Also, less locking within `createVMALocked` ... |
259,992 | 19.05.2022 09:12:33 | 25,200 | 62dcc6f5b0c94b075111b02f6dc39555879bd6e5 | Add `--force` flag to `trace create` command
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/config.go",
"new_path": "pkg/sentry/seccheck/config.go",
"diff": "@@ -68,13 +68,20 @@ type SinkConfig struct {\n}\n// Create reads the session configuration and applies it to the system.\n-func Create(conf *SessionConfig) error {\n+func Cre... | Go | Apache License 2.0 | google/gvisor | Add `--force` flag to `trace create` command
Updates #4805
PiperOrigin-RevId: 449759478 |
259,907 | 19.05.2022 10:45:16 | 25,200 | cf039a68d8b6b5370506e576d3b5671457d802b6 | Add trace procfs command.
`runsc trace procfs` should dump a lot of relevant procfs information about
all the processes in the container. Falco will consume this.
For now the only procfs entry that the procfs dump returns is /proc/[pid]/exe.
Will incrementally add support for the remaining in separate changes.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -121,6 +121,7 @@ go_library(\n\"//runsc/boot/filter\",\n\"//runsc/boot/platforms\",\n\"//runsc/boot/pprof\",\n+ \"//runsc/boot/procfs\",\n\"//runsc/config\",\n\"//runsc/specutils\",\n\"//runsc/spec... | Go | Apache License 2.0 | google/gvisor | Add trace procfs command.
`runsc trace procfs` should dump a lot of relevant procfs information about
all the processes in the container. Falco will consume this.
For now the only procfs entry that the procfs dump returns is /proc/[pid]/exe.
Will incrementally add support for the remaining in separate changes.
Updat... |
259,907 | 19.05.2022 11:27:56 | 25,200 | 6fdeba8d7840f110ee36ef877ed6384674349868 | Add support for /prod/[pid]/cmdline and /proc/[pid]/environ to trace procfs.
This change exports some logic in fsimpl/proc so that runsc/boot can use it.
Added tests for these fields.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/task.go",
"new_path": "pkg/sentry/fsimpl/proc/task.go",
"diff": "@@ -54,10 +54,10 @@ func (fs *filesystem) newTaskInode(ctx context.Context, task *kernel.Task, pidns\ncontents := map[string]kernfs.Inode{\n\"auxv\": fs.newTaskOwnedInode(c... | Go | Apache License 2.0 | google/gvisor | Add support for /prod/[pid]/cmdline and /proc/[pid]/environ to trace procfs.
This change exports some logic in fsimpl/proc so that runsc/boot can use it.
Added tests for these fields.
Updates #4805
PiperOrigin-RevId: 449794552 |
259,868 | 19.05.2022 11:44:41 | 25,200 | 7db613ab1cd66fe63c60d18127bdc8c47b5643c6 | BuildKite: Always do a clean checkout of the repository. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -38,6 +38,9 @@ _templates:\n./pkg/tcpip/transport/tcp\n./pkg/tcpip/transport/udp\n./pkg/waiter\n+env:\n+ # Force a clean checkout every time to avoid reuse of files between runs.\n+... | Go | Apache License 2.0 | google/gvisor | BuildKite: Always do a clean checkout of the repository.
PiperOrigin-RevId: 449798496 |
259,853 | 19.05.2022 12:05:08 | 25,200 | 4d4b2b99c88bb6c97a7917d7682ec710eb537e99 | tmpfs: use lockdep mutexes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/BUILD",
"new_path": "pkg/sentry/fsimpl/tmpfs/BUILD",
"diff": "load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\nload(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\n+load(\"//pkg/sync/locking:locking.bzl\", \"declare... | Go | Apache License 2.0 | google/gvisor | tmpfs: use lockdep mutexes
PiperOrigin-RevId: 449803147 |
259,907 | 19.05.2022 12:15:08 | 25,200 | ec422a66093e09d2884e3d504a453196a2af5403 | Add support for /proc/[pid]/cwd to trace procfs.
Added test for this field.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/procfs/BUILD",
"new_path": "runsc/boot/procfs/BUILD",
"diff": "@@ -12,5 +12,6 @@ go_library(\n\"//pkg/sentry/fsimpl/proc\",\n\"//pkg/sentry/kernel\",\n\"//pkg/sentry/mm\",\n+ \"//pkg/sentry/vfs\",\n],\n)\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | Add support for /proc/[pid]/cwd to trace procfs.
Added test for this field.
Updates #4805
PiperOrigin-RevId: 449805258 |
259,966 | 19.05.2022 12:51:40 | 25,200 | 28eda96b005ea8130bd3cabd23db3640ec26c67b | Cleanup the multicast routing table.
This change does the following:
Uses shared types for the route key and multicast route.
Returns a bool instead of error from GetRouteOrInsertPending since only one
error type is possible.
Improves the naming of PendingRouteState using the suggestions in
cl/445157188.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/multicast/example_test.go",
"new_path": "pkg/tcpip/network/internal/multicast/example_test.go",
"diff": "@@ -32,6 +32,7 @@ import (\nconst (\ndefaultMinTTL = 10\n+ defaultMTU = 1500\ninputNICID tcpip.NICID = 1\noutgoingNICID tcpip.NI... | Go | Apache License 2.0 | google/gvisor | Cleanup the multicast routing table.
This change does the following:
- Uses shared types for the route key and multicast route.
- Returns a bool instead of error from GetRouteOrInsertPending since only one
error type is possible.
- Improves the naming of PendingRouteState using the suggestions in
cl/445157188.
Updat... |
259,982 | 19.05.2022 18:23:59 | 25,200 | 1228e6c788a0a6f35b9792aaa1ffe20ac72ce1c6 | Adding tests to handle empty size & uint64 overflow in parsing size. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"diff": "@@ -972,7 +972,14 @@ func parseSize(s string) (uint64, error) {\ncount = count << 10\ns = s[:len(s)-1]\n}\n- bytes, err := strconv.ParseUint(s, 10, 64)\n- bytes = bytes... | Go | Apache License 2.0 | google/gvisor | Adding tests to handle empty size & uint64 overflow in parsing size.
PiperOrigin-RevId: 449876821 |
259,853 | 19.05.2022 21:31:53 | 25,200 | ad8960f60401953f9d57809bc3add378487bf039 | Allow to run packetdrill and fsstress tests on arm64 | [
{
"change_type": "RENAME",
"old_path": "images/basic/fsstress/Dockerfile.x86_64",
"new_path": "images/basic/fsstress/Dockerfile",
"diff": "@@ -5,7 +5,7 @@ RUN apk update && apk add git\nRUN git clone https://github.com/linux-test-project/ltp.git --depth 1\nWORKDIR /ltp\n-RUN ./travis/alpine.sh\n+RUN... | Go | Apache License 2.0 | google/gvisor | Allow to run packetdrill and fsstress tests on arm64
PiperOrigin-RevId: 449900552 |
259,853 | 20.05.2022 14:08:46 | 25,200 | bb1a83085b3b0aa230d6256d74f4c6322617020e | buildkite: allow to run containerd tests on arm64
k8s.gcr.io/busybox:latest doesn't have the arm variant, so
let's use the upstream busybox and create /etc/recolv.conf symlink. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -236,35 +236,30 @@ steps:\nlabel: \":docker: Containerd 1.4.3 tests\"\ncommand: make containerd-test-1.4.3\nagents:\n- arch: \"amd64\"\nos: \"ubuntu\"\n- <<: *common\nlabel: \":dock... | Go | Apache License 2.0 | google/gvisor | buildkite: allow to run containerd tests on arm64
k8s.gcr.io/busybox:latest doesn't have the arm variant, so
let's use the upstream busybox and create /etc/recolv.conf symlink.
PiperOrigin-RevId: 450059917 |
259,909 | 23.05.2022 14:05:00 | 25,200 | 8f6b282acc44ddd459715a6f2db8aaafd6b5b11e | Fix data race in remote_test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/checkers/remote/test/server.go",
"new_path": "pkg/sentry/seccheck/checkers/remote/test/server.go",
"diff": "@@ -48,6 +48,7 @@ type Server struct {\n// +checklocks:mu\npoints []Message\n+ // +checklocks:mu\nversion uint32\n}\n@@ -147,7 +148,... | Go | Apache License 2.0 | google/gvisor | Fix data race in remote_test.
PiperOrigin-RevId: 450520804 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.