author
int64 4.98k
943k
| date
stringdate 2017-04-15 16:45:02
2022-02-25 15:32:15
| timezone
int64 -46,800
39.6k
| hash
stringlengths 40
40
| message
stringlengths 8
468
| mods
listlengths 1
16
| language
stringclasses 9
values | license
stringclasses 2
values | repo
stringclasses 119
values | original_message
stringlengths 12
491
| is_CCS
int64 1
1
| commit_type
stringclasses 129
values | commit_scope
stringlengths 1
44
⌀ |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
730,429
|
12.03.2018 15:00:30
| 14,400
|
e1eeb247e2b2ce50abb4af18f36018471b5ec98a
|
feat(react-component-utils): add hydraTypes object
|
[
{
"change_type": "MODIFY",
"diff": "@@ -81,3 +81,10 @@ export function deconstructHydraId(id) {\ntype: payload.pop()\n};\n}\n+\n+export const hydraTypes = {\n+ MESSAGE: 'MESSAGE',\n+ PEOPLE: 'PEOPLE',\n+ ROOM: 'ROOM',\n+ TEAM: 'TEAM'\n+};\n",
"new_path": "packages/node_modules/@ciscospark/react-component-utils/src/uuid-utils.js",
"old_path": "packages/node_modules/@ciscospark/react-component-utils/src/uuid-utils.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
feat(react-component-utils): add hydraTypes object
| 1
|
feat
|
react-component-utils
|
730,429
|
12.03.2018 15:15:13
| 14,400
|
6f28003cea0bf03ebd2d57cc63070a1b3931bf93
|
refactor(widget-meet): use the widgetTypes object
|
[
{
"change_type": "MODIFY",
"diff": "@@ -15,7 +15,7 @@ import {\ncreateNotification\n} from '@ciscospark/react-container-notifications';\nimport {addError, removeError} from '@ciscospark/redux-module-errors';\n-import {constructHydraId} from '@ciscospark/react-component-utils';\n+import {constructHydraId, hydraTypes} from '@ciscospark/react-component-utils';\nimport messages from '../messages';\nimport {\n@@ -94,10 +94,10 @@ function handleCall(props) {\nlet destination = toValue;\nif (toType === toTypes.USERID) {\n- destination = constructHydraId('USER', userId);\n+ destination = constructHydraId(hydraTypes.PEOPLE, userId);\n}\nelse if (toType === toTypes.SPACEID) {\n- destination = constructHydraId('ROOM', spaceId);\n+ destination = constructHydraId(hydraTypes.ROOM, spaceId);\n}\nprops.placeCall(sparkInstance, {destination})\n",
"new_path": "packages/node_modules/@ciscospark/widget-meet/src/enhancers/withCallHandlers.js",
"old_path": "packages/node_modules/@ciscospark/widget-meet/src/enhancers/withCallHandlers.js"
},
{
"change_type": "MODIFY",
"diff": "import {compose, lifecycle} from 'recompose';\n-import {constructHydraId, getConvoIdFromUrl} from '@ciscospark/react-component-utils';\n+import {constructHydraId, getConvoIdFromUrl, hydraTypes} from '@ciscospark/react-component-utils';\nimport {eventNames} from '../events';\n@@ -21,7 +21,7 @@ export default compose(lifecycle({\n};\nif (call.locus && call.locus.conversationUrl) {\n- details.roomId = constructHydraId('ROOM', getConvoIdFromUrl(call.locus.conversationUrl));\n+ details.roomId = constructHydraId(hydraTypes.ROOM, getConvoIdFromUrl(call.locus.conversationUrl));\n}\nreturn onEvent(name, details);\n",
"new_path": "packages/node_modules/@ciscospark/widget-meet/src/enhancers/withCallMemberships.js",
"old_path": "packages/node_modules/@ciscospark/widget-meet/src/enhancers/withCallMemberships.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -2,9 +2,10 @@ import {compose, lifecycle} from 'recompose';\nimport {bindActionCreators} from 'redux';\nimport {connect} from 'react-redux';\nimport {\n+ deconstructHydraId,\n+ hydraTypes,\nvalidateSipUri,\n- validateEmail,\n- deconstructHydraId\n+ validateEmail\n} from '@ciscospark/react-component-utils';\nimport {storeMeetDetails} from '../actions';\n@@ -39,12 +40,12 @@ function storeToType(props) {\ntoValue = to.replace('sip:', '');\n}\nelse if (hydraObject.id && hydraObject.type) {\n- if (hydraObject.type === 'PERSON') {\n+ if (hydraObject.type === hydraTypes.PEOPLE) {\ntoType = toTypes.USERID;\ntoValue = hydraObject.id;\ndetails.userId = toValue;\n}\n- else if (hydraObject.type === 'ROOM') {\n+ else if (hydraObject.type === hydraTypes.ROOM) {\ntoType = toTypes.SPACEID;\ntoValue = hydraObject.id;\ndetails.spaceId = toValue;\n",
"new_path": "packages/node_modules/@ciscospark/widget-meet/src/enhancers/withToType.js",
"old_path": "packages/node_modules/@ciscospark/widget-meet/src/enhancers/withToType.js"
},
{
"change_type": "MODIFY",
"diff": "-import {constructHydraId} from '@ciscospark/react-component-utils';\n+import {constructHydraId, hydraTypes} from '@ciscospark/react-component-utils';\nexport const eventNames = {\nCALLS_CREATED: 'calls:created',\n@@ -23,9 +23,9 @@ export function constructCallEventData({callInstance, actor}) {\nlet personDetails = {};\nif (actor) {\npersonDetails = {\n- actorId: constructHydraId('PEOPLE', actor.id),\n+ actorId: constructHydraId(hydraTypes.PEOPLE, actor.id),\nactorName: actor.name,\n- personId: constructHydraId('PEOPLE', actor.id),\n+ personId: constructHydraId(hydraTypes.PEOPLE, actor.id),\npersonEmail: actor.email\n};\n}\n@@ -35,13 +35,13 @@ export function constructCallEventData({callInstance, actor}) {\nconst conversationId = locus.conversationUrl.split('/');\nconst {host} = locus;\nif (host) {\n- personDetails.actorId = constructHydraId('PEOPLE', host.id);\n+ personDetails.actorId = constructHydraId(hydraTypes.PEOPLE, host.id);\npersonDetails.actorName = host.name;\npersonDetails.personEmail = host.email;\n- personDetails.personId = constructHydraId('PEOPLE', host.id);\n+ personDetails.personId = constructHydraId(hydraTypes.PEOPLE, host.id);\n}\nif (conversationId) {\n- personDetails.roomId = constructHydraId('ROOM', conversationId);\n+ personDetails.roomId = constructHydraId(hydraTypes.ROOM, conversationId);\n}\n}\nreturn {\n",
"new_path": "packages/node_modules/@ciscospark/widget-meet/src/events.js",
"old_path": "packages/node_modules/@ciscospark/widget-meet/src/events.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
refactor(widget-meet): use the widgetTypes object
| 1
|
refactor
|
widget-meet
|
730,429
|
12.03.2018 15:16:28
| 14,400
|
3c125aeeb04a27639a534304657eab7b0b4acc3a
|
fix(widget-space): handle uuids for toPersonId
|
[
{
"change_type": "MODIFY",
"diff": "import {createSelector} from 'reselect';\n-import {isUuid, constructHydraId, deconstructHydraId} from '@ciscospark/react-component-utils';\n+import {isUuid, constructHydraId, deconstructHydraId, hydraTypes} from '@ciscospark/react-component-utils';\nconst getWidget = (state) => state.widgetSpace;\nconst getSpark = (state) => state.spark;\n@@ -86,23 +86,38 @@ const getTo = createSelector(\ntoPersonId,\ntoPersonEmail\n} = ownProps;\n- let to = toPersonId || toPersonEmail;\n+ let to;\nif (spaceDetails && spaceDetails.has('id')) {\nreturn spaceDetails.get('id');\n}\nif (spaceId) {\nif (isUuid(spaceId)) {\n- to = constructHydraId('ROOM', spaceId);\n+ to = constructHydraId(hydraTypes.ROOM, spaceId);\n}\nelse {\nconst {type} = deconstructHydraId(spaceId);\n- if (type === 'ROOM') {\n+ if (type === hydraTypes.ROOM) {\nto = spaceId;\n}\n}\n}\n+ else if (toPersonId) {\n+ if (isUuid(toPersonId)) {\n+ to = constructHydraId(hydraTypes.PEOPLE, toPersonId);\n+ }\n+ else {\n+ const {type} = deconstructHydraId(toPersonId);\n+ if (type === hydraTypes.PEOPLE) {\n+ to = toPersonId;\n+ }\n+ }\n+ }\n+ else {\n+ to = toPersonEmail;\n+ }\n+ // `to` should be an email or hydra id\nreturn to;\n}\n);\n",
"new_path": "packages/node_modules/@ciscospark/widget-space/src/selector.js",
"old_path": "packages/node_modules/@ciscospark/widget-space/src/selector.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
fix(widget-space): handle uuids for toPersonId
| 1
|
fix
|
widget-space
|
730,429
|
12.03.2018 15:16:55
| 14,400
|
0c68673a08d7b5f50acbd14839da85a2c6442fa7
|
refactor(widget-message): use the widgetTypes object
|
[
{
"change_type": "MODIFY",
"diff": "-import {constructHydraId} from '@ciscospark/react-component-utils';\n+import {constructHydraId, hydraTypes} from '@ciscospark/react-component-utils';\nexport const eventNames = {\nSPACES_READ: 'rooms:read',\n@@ -19,13 +19,13 @@ export function constructMessagesEventData(activity, toUser) {\nif (roomType === 'direct' && toUser) {\ntoPersonEmail = toUser.emailAddress;\n- toPersonId = constructHydraId('PEOPLE', toUser.id);\n+ toPersonId = constructHydraId(hydraTypes.PEOPLE, toUser.id);\n}\nlet mentionedPeople = activity.object.mentions;\nif (mentionedPeople && mentionedPeople.items.length) {\nmentionedPeople = mentionedPeople.items.map((people) => ({\n- id: constructHydraId('PEOPLE', people.id)\n+ id: constructHydraId(hydraTypes.PEOPLE, people.id)\n}));\n}\n@@ -34,12 +34,12 @@ export function constructMessagesEventData(activity, toUser) {\nfiles = activity.object.files.items;\n}\n- const personId = constructHydraId('PEOPLE', activity.actor.id);\n+ const personId = constructHydraId(hydraTypes.PEOPLE, activity.actor.id);\nreturn {\nactorId: personId,\nactorName: activity.actor.displayName,\n- id: constructHydraId('MESSAGE', activity.id),\n- roomId: constructHydraId('ROOM', activity.target.id),\n+ id: constructHydraId(hydraTypes.MESSAGE, activity.id),\n+ roomId: constructHydraId(hydraTypes.ROOM, activity.target.id),\nroomType: activity.target.tags.includes('ONE_ON_ONE') ? 'direct' : 'group',\ntext: activity.object.displayName,\nhtml: activity.object.content,\n@@ -64,13 +64,13 @@ export function constructMessagesEventData(activity, toUser) {\n*/\nexport function constructRoomsEventData(space, activity) {\nreturn {\n- id: constructHydraId('ROOM', space.id),\n- actorId: constructHydraId('PEOPLE', activity.actor.id),\n+ id: constructHydraId(hydraTypes.ROOM, space.id),\n+ actorId: constructHydraId(hydraTypes.PEOPLE, activity.actor.id),\nactorName: activity.actor.displayName,\ntitle: space.name,\ntype: space.type,\nisLocked: space.isLocked,\n- teamId: constructHydraId('TEAM', space.teamId),\n+ teamId: constructHydraId(hydraTypes.TEAM, space.teamId),\nlastActivity: activity && activity.published || space.lastActivityTimestamp,\ncreated: space.published\n};\n",
"new_path": "packages/node_modules/@ciscospark/widget-message/src/events.js",
"old_path": "packages/node_modules/@ciscospark/widget-message/src/events.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
refactor(widget-message): use the widgetTypes object
| 1
|
refactor
|
widget-message
|
730,429
|
12.03.2018 15:18:00
| 14,400
|
1ff801a593dbc7f94cc6097d6d7c684c1ea2e82e
|
refactor(widget-recents): use the widgetTypes object
|
[
{
"change_type": "MODIFY",
"diff": "-import {constructHydraId} from '@ciscospark/react-component-utils';\n+import {constructHydraId, hydraTypes} from '@ciscospark/react-component-utils';\nexport const eventNames = {\nSPACES_READ: 'rooms:read',\n@@ -26,13 +26,13 @@ export function constructMessagesEventData(activity, toUser) {\nif (roomType === 'direct' && toUser) {\ntoPersonEmail = toUser.emailAddress;\n- toPersonId = constructHydraId('PEOPLE', toUser.id);\n+ toPersonId = constructHydraId(hydraTypes.PEOPLE, toUser.id);\n}\nlet mentionedPeople = activity.object.mentions;\nif (mentionedPeople && mentionedPeople.items.length) {\nmentionedPeople = mentionedPeople.items.map((people) => ({\n- id: constructHydraId('PEOPLE', people.id)\n+ id: constructHydraId(hydraTypes.PEOPLE, people.id)\n}));\n}\n@@ -41,11 +41,11 @@ export function constructMessagesEventData(activity, toUser) {\nfiles = activity.object.files.items;\n}\n- const personId = constructHydraId('PEOPLE', activity.actor.id);\n+ const personId = constructHydraId(hydraTypes.PEOPLE, activity.actor.id);\nreturn {\nactorId: personId,\n- id: constructHydraId('MESSAGE', activity.id),\n- roomId: constructHydraId('ROOM', activity.target.id),\n+ id: constructHydraId(hydraTypes.MESSAGE, activity.id),\n+ roomId: constructHydraId(hydraTypes.ROOM, activity.target.id),\nroomType: activity.target.tags.includes('ONE_ON_ONE') ? 'direct' : 'group',\ntext: activity.object.displayName,\nhtml: activity.object.content,\n@@ -62,11 +62,11 @@ export function constructMessagesEventData(activity, toUser) {\nexport function constructRoomsEventData(space, activity) {\nreturn {\n- id: constructHydraId('ROOM', space.id),\n+ id: constructHydraId(hydraTypes.ROOM, space.id),\ntitle: space.name,\ntype: space.type,\nisLocked: space.isLocked,\n- teamId: constructHydraId('TEAM', space.teamId),\n+ teamId: constructHydraId(hydraTypes.TEAM, space.teamId),\nlastActivity: activity && activity.published || space.lastActivityTimestamp,\ncreated: space.published,\ntoPersonEmail: space.toPersonEmail\n@@ -76,10 +76,10 @@ export function constructRoomsEventData(space, activity) {\nexport function constructMembershipEventData(activity) {\nreturn {\n- actorId: constructHydraId('PEOPLE', activity.actor.id),\n- id: constructHydraId('MESSAGE', activity.id),\n- roomId: constructHydraId('ROOM', activity.target.id),\n- personId: constructHydraId('PEOPLE', activity.object.id),\n+ actorId: constructHydraId(hydraTypes.PEOPLE, activity.actor.id),\n+ id: constructHydraId(hydraTypes.MESSAGE, activity.id),\n+ roomId: constructHydraId(hydraTypes.ROOM, activity.target.id),\n+ personId: constructHydraId(hydraTypes.PEOPLE, activity.object.id),\npersonEmail: activity.object.emailAddress,\ncreated: activity.published\n};\n@@ -87,10 +87,10 @@ export function constructMembershipEventData(activity) {\nexport function constructCallEventData(call, space) {\nreturn {\n- actorId: constructHydraId('PEOPLE', call.locus.host.id),\n- personId: constructHydraId('PEOPLE', call.locus.host.id),\n+ actorId: constructHydraId(hydraTypes.PEOPLE, call.locus.host.id),\n+ personId: constructHydraId(hydraTypes.PEOPLE, call.locus.host.id),\npersonEmail: call.locus.host.email,\n- roomId: constructHydraId('ROOM', space.id),\n+ roomId: constructHydraId(hydraTypes.ROOM, space.id),\ncall\n};\n}\n",
"new_path": "packages/node_modules/@ciscospark/widget-recents/src/events.js",
"old_path": "packages/node_modules/@ciscospark/widget-recents/src/events.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
refactor(widget-recents): use the widgetTypes object
| 1
|
refactor
|
widget-recents
|
791,834
|
12.03.2018 16:17:46
| 25,200
|
e675e1b4f7c3eca481fad5aae8b9621daf38ad40
|
core: add type checking to connection
|
[
{
"change_type": "MODIFY",
"diff": "* Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n*/\n-// @ts-nocheck\n'use strict';\nconst EventEmitter = require('events').EventEmitter;\n@@ -13,20 +12,20 @@ const LHError = require('../../lib/errors');\nclass Connection {\nconstructor() {\nthis._lastCommandId = 0;\n- /** @type {!Map<number, {resolve: function(*), reject: function(*), method: string}>}*/\n+ /** @type {Map<number, {resolve: function(Promise<*>), method: string, options: {silent?: boolean}}>}*/\nthis._callbacks = new Map();\nthis._eventEmitter = new EventEmitter();\n}\n/**\n- * @return {!Promise}\n+ * @return {Promise<void>}\n*/\nconnect() {\nreturn Promise.reject(new Error('Not implemented'));\n}\n/**\n- * @return {!Promise}\n+ * @return {Promise<void>}\n*/\ndisconnect() {\nreturn Promise.reject(new Error('Not implemented'));\n@@ -34,7 +33,7 @@ class Connection {\n/**\n- * @return {!Promise<string>}\n+ * @return {Promise<string>}\n*/\nwsEndpoint() {\nreturn Promise.reject(new Error('Not implemented'));\n@@ -43,30 +42,34 @@ class Connection {\n/**\n* Call protocol methods\n- * @param {!string} method\n- * @param {!Object} params\n- * @param {{silent: boolean}=} cmdOpts\n- * @return {!Promise}\n+ * @param {string} method\n+ * @param {object=} params\n+ * @param {{silent?: boolean}=} cmdOpts\n+ * @return {Promise<*>}\n*/\nsendCommand(method, params = {}, cmdOpts = {}) {\nlog.formatProtocol('method => browser', {method, params}, 'verbose');\nconst id = ++this._lastCommandId;\nconst message = JSON.stringify({id, method, params});\nthis.sendRawMessage(message);\n- return new Promise((resolve, reject) => {\n- this._callbacks.set(id, {resolve, reject, method, options: cmdOpts});\n+ return new Promise(resolve => {\n+ this._callbacks.set(id, {resolve, method, options: cmdOpts});\n});\n}\n/**\n* Bind listeners for connection events\n- * @param {!string} eventName\n- * @param {function(...args)} cb\n+ * @param {'notification'} eventName\n+ * @param {(...args: any[]) => void} cb\n*/\non(eventName, cb) {\nif (eventName !== 'notification') {\nthrow new Error('Only supports \"notification\" events');\n}\n+\n+ if (!this._eventEmitter) {\n+ throw new Error('Attempted to add event listener after connection disposed.');\n+ }\nthis._eventEmitter.on(eventName, cb);\n}\n@@ -74,31 +77,37 @@ class Connection {\n/**\n* @param {string} message\n- * @return {!Promise}\n* @protected\n*/\nsendRawMessage(message) {\n- return Promise.reject(new Error('Not implemented'));\n+ throw new Error('Not implemented');\n}\n/* eslint-enable no-unused-vars */\n/**\n* @param {string} message\n- * @return {!Promise}\n+ * @return {void}\n* @protected\n*/\nhandleRawMessage(message) {\nconst object = JSON.parse(message);\n// Remote debugging protocol is JSON RPC 2.0 compiant. In terms of that transport,\n// responses to the commands carry \"id\" property, while notifications do not.\n- if (this._callbacks.has(object.id)) {\n+ if (!object.id) {\n+ log.formatProtocol('<= event',\n+ {method: object.method, params: object.params}, 'verbose');\n+ this.emitNotification(object.method, object.params);\n+ return;\n+ }\n+\nconst callback = this._callbacks.get(object.id);\n+ if (callback) {\nthis._callbacks.delete(object.id);\nreturn callback.resolve(Promise.resolve().then(_ => {\nif (object.error) {\n- const logLevel = callback.options && callback.options.silent ? 'verbose' : 'error';\n+ const logLevel = callback.options.silent ? 'verbose' : 'error';\nlog.formatProtocol('method <= browser ERR', {method: callback.method}, logLevel);\nthrow LHError.fromProtocolMessage(callback.method, object.error);\n}\n@@ -107,25 +116,24 @@ class Connection {\n{method: callback.method, params: object.result}, 'verbose');\nreturn object.result;\n}));\n- } else if (object.id) {\n+ } else {\n// In DevTools we receive responses to commands we did not send which we cannot act on, so we\n// just log these occurrences.\nconst error = object.error && object.error.message;\nlog.formatProtocol(`disowned method <= browser ${error ? 'ERR' : 'OK'}`,\n{method: object.method, params: error || object.result}, 'verbose');\n- } else {\n- log.formatProtocol('<= event',\n- {method: object.method, params: object.params}, 'verbose');\n- this.emitNotification(object.method, object.params);\n}\n}\n/**\n- * @param {!string} method\n- * @param {!Object} params\n+ * @param {string} method\n+ * @param {object=} params\n* @protected\n*/\nemitNotification(method, params) {\n+ if (!this._eventEmitter) {\n+ throw new Error('Attempted to emit event after connection disposed.');\n+ }\nthis._eventEmitter.emit('notification', {method, params});\n}\n@@ -133,9 +141,11 @@ class Connection {\n* @protected\n*/\ndispose() {\n+ if (this._eventEmitter) {\nthis._eventEmitter.removeAllListeners();\nthis._eventEmitter = null;\n}\n}\n+}\nmodule.exports = Connection;\n",
"new_path": "lighthouse-core/gather/connections/connection.js",
"old_path": "lighthouse-core/gather/connections/connection.js"
},
{
"change_type": "MODIFY",
"diff": "* Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n*/\n-// @ts-nocheck\n'use strict';\nconst Connection = require('./connection.js');\n@@ -25,34 +24,37 @@ class CriConnection extends Connection {\nsuper();\nthis.port = port;\nthis.hostname = hostname;\n+ this._ws = null;\n+ this._pageId = null;\n}\n/**\n* @override\n- * @return {!Promise}\n+ * @return {Promise<void>}\n*/\nconnect() {\nreturn this._runJsonCommand('new')\n- .then(response => this._connectToSocket(response))\n+ .then(response => this._connectToSocket(/** @type {LH.DevToolsJsonTarget} */(response)))\n.catch(_ => {\n// Compat: headless didn't support `/json/new` before m59. (#970, crbug.com/699392)\n// If no support, we fallback and reuse an existing open tab\nlog.warn('CriConnection', 'Cannot create new tab; reusing open tab.');\nreturn this._runJsonCommand('list').then(tabs => {\n- const firstTab = tabs[0];\n- if (!Array.isArray(tabs) || !firstTab) {\n+ if (!Array.isArray(tabs) || tabs.length === 0) {\nreturn Promise.reject(new Error('Cannot create new tab, and no tabs already open.'));\n}\n+ const firstTab = tabs[0];\n// first, we activate it to a foreground tab, then we connect\nreturn this._runJsonCommand(`activate/${firstTab.id}`)\n- .then(_ => this._connectToSocket(firstTab));\n+ .then(() => this._connectToSocket(firstTab));\n});\n});\n}\n/**\n- * @param {!Object} response\n- * @return {!Promise}\n+ * @param {LH.DevToolsJsonTarget} response\n+ * @return {Promise<void>}\n+ * @private\n*/\n_connectToSocket(response) {\nconst url = response.webSocketDebuggerUrl;\n@@ -66,17 +68,19 @@ class CriConnection extends Connection {\nthis._ws = ws;\nresolve();\n});\n- ws.on('message', data => this.handleRawMessage(data));\n+ ws.on('message', data => this.handleRawMessage(/** @type {string} */ (data)));\nws.on('close', this.dispose.bind(this));\nws.on('error', reject);\n});\n}\n/**\n- * @param {!string} command\n- * @return {!Promise<string>}\n+ * @param {string} command\n+ * @return {Promise<LH.DevToolsJsonTarget | Array<LH.DevToolsJsonTarget> | {message: string}>}\n+ * @private\n*/\n_runJsonCommand(command) {\n+ // TODO(bckenny): can base type on command once conditional types land in TS\nreturn new Promise((resolve, reject) => {\nconst request = http.get({\nhostname: this.hostname,\n@@ -87,7 +91,7 @@ class CriConnection extends Connection {\nresponse.on('data', chunk => {\ndata += chunk;\n});\n- response.on('end', _ => {\n+ response.on('end', () => {\nif (response.statusCode === 200) {\ntry {\nresolve(JSON.parse(data));\n@@ -104,11 +108,12 @@ class CriConnection extends Connection {\n});\n});\n- request.setTimeout(CONNECT_TIMEOUT, _ => {\n+ request.setTimeout(CONNECT_TIMEOUT, () => {\nrequest.abort();\n// After aborting, we expect an ECONNRESET error. Ignore.\nrequest.on('error', err => {\n+ // @ts-ignore `code` property extension to Error by Node.\nif (err.code !== 'ECONNRESET') {\nthrow err;\n}\n@@ -117,6 +122,7 @@ class CriConnection extends Connection {\n// TODO: Replace this with an LHError on next major version bump\n// Reject on error with code specifically indicating timeout in connection setup.\nconst err = new Error('Timeout waiting for initial Debugger Protocol connection.');\n+ // @ts-ignore fixed by above TODO\nerr.code = 'CRI_TIMEOUT';\nlog.error('CriConnection', err.message);\nreject(err);\n@@ -126,34 +132,45 @@ class CriConnection extends Connection {\n/**\n* @override\n+ * @return {Promise<void>}\n*/\ndisconnect() {\nif (!this._ws) {\nlog.warn('CriConnection', 'disconnect() was called without an established connection.');\nreturn Promise.resolve();\n}\n+\nreturn this._runJsonCommand(`close/${this._pageId}`).then(_ => {\n+ if (this._ws) {\nthis._ws.removeAllListeners();\nthis._ws.close();\nthis._ws = null;\n+ }\nthis._pageId = null;\n});\n}\n/**\n* @override\n- * @return {!Promise<string>}\n+ * @return {Promise<string>}\n*/\nwsEndpoint() {\n- return this._runJsonCommand('version').then(response => response.webSocketDebuggerUrl);\n+ return this._runJsonCommand('version').then(response => {\n+ return /** @type {LH.DevToolsJsonTarget} */ (response).webSocketDebuggerUrl;\n+ });\n}\n/**\n* @override\n* @param {string} message\n+ * @protected\n*/\nsendRawMessage(message) {\n+ if (!this._ws) {\n+ log.error('CriConnection', 'sendRawMessage() was called without an established connection.');\n+ throw new Error('sendRawMessage() was called without an established connection.');\n+ }\nthis._ws.send(message);\n}\n}\n",
"new_path": "lighthouse-core/gather/connections/cri.js",
"old_path": "lighthouse-core/gather/connections/cri.js"
},
{
"change_type": "MODIFY",
"diff": "* Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n*/\n+// eslint-disable-next-line spaced-comment\n+/// <reference types=\"chrome\" />\n'use strict';\nconst Connection = require('./connection.js');\n@@ -19,17 +21,32 @@ class ExtensionConnection extends Connection {\nthis._onUnexpectedDetach = this._onUnexpectedDetach.bind(this);\n}\n+ /**\n+ * @param {chrome.debugger.Debuggee} source\n+ * @param {string} method\n+ * @param {object=} params\n+ * @private\n+ */\n_onEvent(source, method, params) {\n// log events received\nlog.log('<=', method, params);\nthis.emitNotification(method, params);\n}\n- _onUnexpectedDetach(debuggee, detachReason) {\n+ /**\n+ * @param {chrome.debugger.Debuggee} source\n+ * @param {string} detachReason\n+ * @return {never}\n+ * @private\n+ */\n+ _onUnexpectedDetach(source, detachReason) {\nthis._detachCleanup();\nthrow new Error('Lighthouse detached from browser: ' + detachReason);\n}\n+ /**\n+ * @private\n+ */\n_detachCleanup() {\nthis._tabId = null;\nchrome.debugger.onEvent.removeListener(this._onEvent);\n@@ -39,25 +56,25 @@ class ExtensionConnection extends Connection {\n/**\n* @override\n- * @return {!Promise}\n+ * @return {Promise<void>}\n*/\nconnect() {\nif (this._tabId !== null) {\nreturn Promise.resolve();\n}\n- return this._queryCurrentTab()\n- .then(tab => {\n- const tabId = this._tabId = tab.id;\n+ return this._getCurrentTabId()\n+ .then(tabId => {\n+ this._tabId = tabId;\nchrome.debugger.onEvent.addListener(this._onEvent);\nchrome.debugger.onDetach.addListener(this._onUnexpectedDetach);\nreturn new Promise((resolve, reject) => {\n- chrome.debugger.attach({tabId}, '1.1', _ => {\n+ chrome.debugger.attach({tabId}, '1.1', () => {\nif (chrome.runtime.lastError) {\nreturn reject(new Error(chrome.runtime.lastError.message));\n}\n- resolve(tabId);\n+ resolve();\n});\n});\n});\n@@ -65,7 +82,7 @@ class ExtensionConnection extends Connection {\n/**\n* @override\n- * @return {!Promise}\n+ * @return {Promise<void>}\n*/\ndisconnect() {\nif (this._tabId === null) {\n@@ -75,7 +92,7 @@ class ExtensionConnection extends Connection {\nconst tabId = this._tabId;\nreturn new Promise((resolve, reject) => {\n- chrome.debugger.detach({tabId}, _ => {\n+ chrome.debugger.detach({tabId}, () => {\nif (chrome.runtime.lastError) {\nreturn reject(new Error(chrome.runtime.lastError.message));\n}\n@@ -87,39 +104,45 @@ class ExtensionConnection extends Connection {\n}\n/**\n+ * Call protocol methods.\n* @override\n- * @param {!string} command\n- * @param {!Object} params\n- * @return {!Promise}\n+ * @param {string} method\n+ * @param {object=} params\n+ * @return {Promise<*>}\n*/\n- sendCommand(command, params) {\n+ sendCommand(method, params) {\nreturn new Promise((resolve, reject) => {\n- log.formatProtocol('method => browser', {method: command, params: params}, 'verbose');\n+ log.formatProtocol('method => browser', {method, params}, 'verbose');\nif (!this._tabId) {\nlog.error('ExtensionConnection', 'No tabId set for sendCommand');\n+ return reject(new Error('No tabId set for sendCommand'));\n}\n- chrome.debugger.sendCommand({tabId: this._tabId}, command, params, result => {\n+ chrome.debugger.sendCommand({tabId: this._tabId}, method, params, result => {\nif (chrome.runtime.lastError) {\n// The error from the extension has a `message` property that is the\n// stringified version of the actual protocol error object.\n- const message = chrome.runtime.lastError.message;\n+ const message = chrome.runtime.lastError.message || '';\nlet errorMessage;\ntry {\nerrorMessage = JSON.parse(message).message;\n} catch (e) {}\nerrorMessage = errorMessage || message || 'Unknown debugger protocol error.';\n- log.formatProtocol('method <= browser ERR', {method: command}, 'error');\n- return reject(new Error(`Protocol error (${command}): ${errorMessage}`));\n+ log.formatProtocol('method <= browser ERR', {method}, 'error');\n+ return reject(new Error(`Protocol error (${method}): ${errorMessage}`));\n}\n- log.formatProtocol('method <= browser OK', {method: command, params: result}, 'verbose');\n+ log.formatProtocol('method <= browser OK', {method, params: result}, 'verbose');\nresolve(result);\n});\n});\n}\n+ /**\n+ * @return {Promise<chrome.tabs.Tab>}\n+ * @private\n+ */\n_queryCurrentTab() {\nreturn new Promise((resolve, reject) => {\nconst queryOpts = {\n@@ -143,13 +166,29 @@ class ExtensionConnection extends Connection {\n});\n}\n+ /**\n+ * @return {Promise<number>}\n+ * @private\n+ */\n+ _getCurrentTabId() {\n+ return this._queryCurrentTab().then(tab => {\n+ if (tab.id === undefined) {\n+ throw new Error('Unable to resolve current tab ID. Check the tab, reload, and try again.');\n+ }\n+\n+ return tab.id;\n+ });\n+ }\n+\n/**\n* Used by lighthouse-ext-background to kick off the run on the current page\n+ * @return {Promise<string>}\n*/\ngetCurrentTabURL() {\nreturn this._queryCurrentTab().then(tab => {\nif (!tab.url) {\nlog.error('ExtensionConnection', 'getCurrentTabURL returned empty string', tab);\n+ throw new Error('getCurrentTabURL returned empty string');\n}\nreturn tab.url;\n});\n",
"new_path": "lighthouse-core/gather/connections/extension.js",
"old_path": "lighthouse-core/gather/connections/extension.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -14,7 +14,7 @@ const Connection = require('./connection.js');\n*/\nclass Port {\n/**\n- * @param {!string} eventName, 'message', 'close'\n+ * @param {'message' | 'close'} eventName\n* @param {function(string|undefined)} cb\n*/\non(eventName, cb) { }\n@@ -30,6 +30,9 @@ class Port {\n/* eslint-enable no-unused-vars */\nclass RawConnection extends Connection {\n+ /**\n+ * @param {Port} port\n+ */\nconstructor(port) {\nsuper();\nthis._port = port;\n@@ -39,14 +42,14 @@ class RawConnection extends Connection {\n/**\n* @override\n- * @return {!Promise}\n+ * @return {Promise<void>}\n*/\nconnect() {\nreturn Promise.resolve();\n}\n/**\n- * @override\n+ * @return {Promise<void>}\n*/\ndisconnect() {\nthis._port.close();\n@@ -56,6 +59,7 @@ class RawConnection extends Connection {\n/**\n* @override\n* @param {string} message\n+ * @protected\n*/\nsendRawMessage(message) {\nthis._port.send(message);\n",
"new_path": "lighthouse-core/gather/connections/raw.js",
"old_path": "lighthouse-core/gather/connections/raw.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -28,7 +28,7 @@ class ReportScoring {\n/**\n* Returns the report JSON object with computed scores.\n* @param {{categories: !Object<string, {id: string|undefined, weight: number|undefined, audits: !Array<{id: string, weight: number|undefined}>}>}} config\n- * @param {!Object<{score: ?number|boolean|undefined}>} resultsByAuditId\n+ * @param {!Object<string, {score: ?number|boolean|undefined, notApplicable: boolean, informative: boolean}>} resultsByAuditId\n* @return {{score: number, categories: !Array<{audits: !Array<{score: number, result: !Object}>}>}}\n*/\nstatic scoreAllCategories(config, resultsByAuditId) {\n",
"new_path": "lighthouse-core/scoring.js",
"old_path": "lighthouse-core/scoring.js"
},
{
"change_type": "MODIFY",
"diff": "\"mixed-content\": \"./lighthouse-cli/index.js --chrome-flags='--headless' --config-path=./lighthouse-core/config/mixed-content.js\"\n},\n\"devDependencies\": {\n+ \"@types/chrome\": \"^0.0.60\",\n\"@types/configstore\": \"^2.1.1\",\n\"@types/inquirer\": \"^0.0.35\",\n\"@types/node\": \"*\",\n\"@types/opn\": \"^3.0.28\",\n\"@types/update-notifier\": \"^1.0.2\",\n+ \"@types/ws\": \"^4.0.1\",\n\"@types/yargs\": \"^8.0.2\",\n\"babel-core\": \"^6.16.0\",\n\"bundlesize\": \"^0.14.4\",\n\"mocha\": \"^3.2.0\",\n\"npm-run-posix-or-windows\": \"^2.0.2\",\n\"sinon\": \"^2.3.5\",\n- \"typescript\": \"^2.6.1\",\n+ \"typescript\": \"2.7.2\",\n\"zone.js\": \"^0.7.3\"\n},\n\"dependencies\": {\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "\"include\": [\n\"lighthouse-cli/**/*.js\",\n\"lighthouse-core/lib/dependency-graph/**/*.js\",\n+ \"lighthouse-core/gather/connections/**/*.js\",\n\"./typings/externs.d.ts\"\n],\n\"exclude\": [\n",
"new_path": "tsconfig.json",
"old_path": "tsconfig.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -130,3 +130,13 @@ export interface DevToolsParsedURL {\nscheme: string;\nhost: string;\n}\n+\n+export interface DevToolsJsonTarget {\n+ description: string;\n+ devtoolsFrontendUrl: string;\n+ id: string;\n+ title: string;\n+ type: string;\n+ url: string;\n+ webSocketDebuggerUrl: string;\n+}\n",
"new_path": "typings/externs.d.ts",
"old_path": "typings/externs.d.ts"
},
{
"change_type": "MODIFY",
"diff": "# yarn lockfile v1\n+\"@types/chrome@^0.0.60\":\n+ version \"0.0.60\"\n+ resolved \"https://registry.yarnpkg.com/@types/chrome/-/chrome-0.0.60.tgz#058eed1587b7aec3b83d4be905c8758ea145ba84\"\n+ dependencies:\n+ \"@types/filesystem\" \"*\"\n+\n\"@types/configstore@^2.1.1\":\nversion \"2.1.1\"\nresolved \"https://registry.yarnpkg.com/@types/configstore/-/configstore-2.1.1.tgz#cd1e8553633ad3185c3f2f239ecff5d2643e92b6\"\nversion \"0.9.43\"\nresolved \"https://registry.yarnpkg.com/@types/core-js/-/core-js-0.9.43.tgz#65d646c5e8c0cd1bdee37065799f9d3d48748253\"\n+\"@types/events@*\":\n+ version \"1.2.0\"\n+ resolved \"https://registry.yarnpkg.com/@types/events/-/events-1.2.0.tgz#81a6731ce4df43619e5c8c945383b3e62a89ea86\"\n+\n+\"@types/filesystem@*\":\n+ version \"0.0.28\"\n+ resolved \"https://registry.yarnpkg.com/@types/filesystem/-/filesystem-0.0.28.tgz#3fd7735830f2c7413cb5ac45780bc45904697b0e\"\n+ dependencies:\n+ \"@types/filewriter\" \"*\"\n+\n+\"@types/filewriter@*\":\n+ version \"0.0.28\"\n+ resolved \"https://registry.yarnpkg.com/@types/filewriter/-/filewriter-0.0.28.tgz#c054e8af4d9dd75db4e63abc76f885168714d4b3\"\n+\n\"@types/inquirer@^0.0.35\":\nversion \"0.0.35\"\nresolved \"https://registry.yarnpkg.com/@types/inquirer/-/inquirer-0.0.35.tgz#e054657cf2d10963823957d4d06ec244f05c65be\"\nversion \"1.0.2\"\nresolved \"https://registry.yarnpkg.com/@types/update-notifier/-/update-notifier-1.0.2.tgz#7a9269a38545bfd90155aac1350669a19f8ecb4a\"\n+\"@types/ws@^4.0.1\":\n+ version \"4.0.1\"\n+ resolved \"https://registry.yarnpkg.com/@types/ws/-/ws-4.0.1.tgz#3309d4d02a1ea9cf617d638b9239a2e1e28ef21e\"\n+ dependencies:\n+ \"@types/events\" \"*\"\n+ \"@types/node\" \"*\"\n+\n\"@types/yargs@^8.0.2\":\nversion \"8.0.2\"\nresolved \"https://registry.yarnpkg.com/@types/yargs/-/yargs-8.0.2.tgz#0f9c7b236e2d78cd8f4b6502de15d0728aa29385\"\n@@ -4070,9 +4097,9 @@ typedarray@^0.0.6:\nversion \"0.0.6\"\nresolved \"https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777\"\n-typescript@^2.6.1:\n- version \"2.6.2\"\n- resolved \"https://registry.yarnpkg.com/typescript/-/typescript-2.6.2.tgz#3c5b6fd7f6de0914269027f03c0946758f7673a4\"\n+typescript@2.7.2:\n+ version \"2.7.2\"\n+ resolved \"https://registry.yarnpkg.com/typescript/-/typescript-2.7.2.tgz#2d615a1ef4aee4f574425cdff7026edf81919836\"\nuglify-js@^2.6:\nversion \"2.7.3\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core: add type checking to connection (#4738)
| 1
|
core
| null |
217,922
|
12.03.2018 19:38:15
| -3,600
|
d6e706b85e8eec8a5310620fd4cbe7e4239bd65a
|
feat: rename workshops
closes
|
[
{
"change_type": "MODIFY",
"diff": "<div *ngFor=\"let workshop of workshops | async; trackBy: trackByWorkshopFn; let i = index\" class=\"row\">\n<mat-expansion-panel [ngClass]=\"{odd: i%2>0}\">\n<mat-expansion-panel-header>\n- <mat-panel-title>\n+ <mat-panel-title class=\"workshop-name\">\n{{workshop.name}}\n+ <button mat-icon-button (click)=\"changeWorkshopName(workshop)\"><mat-icon>edit</mat-icon></button>\n</mat-panel-title>\n<div class=\"buttons\">\n<button mat-icon-button ngxClipboard [cbContent]=\"getLink(workshop)\"\n(cbOnSuccess)=\"showCopiedNotification()\">\n<mat-icon>share</mat-icon>\n</button>\n- <!--<input type=\"text\" #uri readonly hidden value=\"{{getLink()}}\">-->\n<button mat-icon-button routerLink=\"/workshop/{{workshop.$key}}\"\n(click)=\"$event.stopPropagation()\">\n<mat-icon>playlist_play</mat-icon>\n",
"new_path": "src/app/pages/lists/lists/lists.component.html",
"old_path": "src/app/pages/lists/lists/lists.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -12,6 +12,14 @@ mat-slide-toggle {\n}\n}\n+.workshop-name {\n+ display: inline-flex;\n+ align-items: center;\n+ button {\n+ margin-left: 10px;\n+ }\n+}\n+\n.merge-button {\nmargin: 10px 0;\n}\n",
"new_path": "src/app/pages/lists/lists/lists.component.scss",
"old_path": "src/app/pages/lists/lists/lists.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -75,6 +75,19 @@ export class ListsComponent extends ComponentWithSubscriptions implements OnInit\nreturn this.workshopService.update(workshop.$key, workshop);\n}\n+ changeWorkshopName(workshop: Workshop): void {\n+ this.dialog.open(WorkshopNamePopupComponent, {data: workshop.name})\n+ .afterClosed()\n+ .filter(name => name !== undefined && name.length > 0)\n+ .mergeMap(name => {\n+ workshop.name = name;\n+ return this.updateWorkshop(workshop);\n+ })\n+ .subscribe(() => {\n+ this.reloader$.next(null);\n+ });\n+ }\n+\nremoveListFromWorkshop(workshop: Workshop, listKey: string): void {\nworkshop.listIds = workshop.listIds.filter(key => key !== listKey);\nthis.updateWorkshop(workshop).subscribe(() => {\n",
"new_path": "src/app/pages/lists/lists/lists.component.ts",
"old_path": "src/app/pages/lists/lists/lists.component.ts"
},
{
"change_type": "MODIFY",
"diff": "-import {Component} from '@angular/core';\n+import {Component, Inject} from '@angular/core';\nimport {FormControl, Validators} from '@angular/forms';\n-import {MatDialogRef} from '@angular/material';\n+import {MAT_DIALOG_DATA, MatDialogRef} from '@angular/material';\n@Component({\nselector: 'app-workshop-name-popup',\n@@ -11,7 +11,8 @@ export class WorkshopNamePopupComponent {\npublic form: FormControl = new FormControl('', Validators.required);\n- constructor(private ref: MatDialogRef<WorkshopNamePopupComponent>) {\n+ constructor(private ref: MatDialogRef<WorkshopNamePopupComponent>, @Inject(MAT_DIALOG_DATA) data: string) {\n+ this.form.setValue(data === undefined ? '' : data);\n}\nsubmit() {\n",
"new_path": "src/app/pages/lists/workshop-name-popup/workshop-name-popup.component.ts",
"old_path": "src/app/pages/lists/workshop-name-popup/workshop-name-popup.component.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
feat: rename workshops
closes #268
| 1
|
feat
| null |
217,922
|
12.03.2018 20:21:12
| -3,600
|
4849dce66aff217271a03746610a11f19aee780b
|
chore: avoid event propagation on workshop rename button
|
[
{
"change_type": "MODIFY",
"diff": "<mat-expansion-panel-header>\n<mat-panel-title class=\"workshop-name\">\n{{workshop.name}}\n- <button mat-icon-button (click)=\"changeWorkshopName(workshop)\"><mat-icon>edit</mat-icon></button>\n+ <button mat-icon-button (click)=\"$event.stopPropagation();changeWorkshopName(workshop)\"><mat-icon>edit</mat-icon></button>\n</mat-panel-title>\n<div class=\"buttons\">\n<button mat-icon-button ngxClipboard [cbContent]=\"getLink(workshop)\"\n",
"new_path": "src/app/pages/lists/lists/lists.component.html",
"old_path": "src/app/pages/lists/lists/lists.component.html"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore: avoid event propagation on workshop rename button
| 1
|
chore
| null |
217,922
|
12.03.2018 20:46:13
| -3,600
|
bb6b6b26da4e23fbbdabe5e6a415d8156d0b2b05
|
feat: workshops in "add item to list" dialog
closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -5,6 +5,7 @@ import {NgSerializerService} from '@kaiu/ng-serializer';\nimport {AngularFirestore} from 'angularfire2/firestore';\nimport {Observable} from 'rxjs/Observable';\nimport {DocumentChangeAction} from 'angularfire2/firestore/interfaces';\n+import {List} from '../../model/list/list';\n@Injectable()\nexport class WorkshopService extends FirestoreStorage<Workshop> {\n@@ -26,6 +27,22 @@ export class WorkshopService extends FirestoreStorage<Workshop> {\n});\n}\n+ getListsByWorkshop(lists: List[], workshops: Workshop[]): { basicLists: List[], rows: { [index: string]: List[] } } {\n+ const result = {basicLists: lists, rows: {}};\n+ workshops.forEach(workshop => {\n+ result.rows[workshop.$key] = [];\n+ lists.forEach((list) => {\n+ // If this list is in this workshop.\n+ if (workshop.listIds !== undefined && workshop.listIds.indexOf(list.$key) > -1) {\n+ result.rows[workshop.$key].push(list);\n+ // Remove the list from basicLists.\n+ result.basicLists = result.basicLists.filter(l => l.$key !== list.$key);\n+ }\n+ });\n+ });\n+ return result;\n+ }\n+\nprotected getBaseUri(): string {\nreturn '/workshops';\n}\n",
"new_path": "src/app/core/database/workshop.service.ts",
"old_path": "src/app/core/database/workshop.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -248,19 +248,7 @@ export class ListsComponent extends ComponentWithSubscriptions implements OnInit\nreturn match;\n});\n}).map(lists => {\n- const result = {basicLists: lists, rows: {}};\n- workshops.forEach(workshop => {\n- result.rows[workshop.$key] = [];\n- lists.forEach((list) => {\n- // If this list is in this workshop.\n- if (workshop.listIds !== undefined && workshop.listIds.indexOf(list.$key) > -1) {\n- result.rows[workshop.$key].push(list);\n- // Remove the list from basicLists.\n- result.basicLists = result.basicLists.filter(l => l.$key !== list.$key);\n- }\n- });\n- });\n- return result;\n+ return this.workshopService.getListsByWorkshop(lists, workshops);\n});\n}));\n}\n",
"new_path": "src/app/pages/lists/lists/lists.component.ts",
"old_path": "src/app/pages/lists/lists/lists.component.ts"
},
{
"change_type": "MODIFY",
"diff": "<button mat-menu-item (click)=\"addAllToNewList()\">\n<mat-icon>add</mat-icon>\n<span>{{'New_List' | translate}}</span></button>\n- <button mat-menu-item *ngFor=\"let list of lists\"\n+ <button mat-menu-item *ngFor=\"let list of lists.basicLists\"\n(click)=\"addAllRecipes(list, list.$key)\">\n<mat-icon>playlist_play</mat-icon>\n- <span>{{list.name}}</span></button>\n+ <span>{{list.name}}</span>\n+ </button>\n+ <div *ngFor=\"let workshop of workshops | async\">\n+ <span mat-menu-item (click)=\"$event.stopPropagation();\">\n+ <mat-icon>folder_open</mat-icon>\n+ {{workshop.name}}</span>\n+ <button mat-menu-item *ngFor=\"let list of lists.rows[workshop.$key]\"\n+ class=\"workshop-list\"\n+ (click)=\"addAllRecipes(list, list.$key)\">\n+ <mat-icon>playlist_play</mat-icon>\n+ <span>{{list.name}}</span>\n+ </button>\n+ </div>\n</mat-menu>\n<div class=\"add-all-wrapper\">\n<button mat-menu-item (click)=\"addToNewList(recipe, amount.value, collectible.checked)\">\n<mat-icon>add</mat-icon>\n<span>{{'New_List' | translate}}</span></button>\n- <button mat-menu-item *ngFor=\"let list of lists\"\n+ <button mat-menu-item *ngFor=\"let list of lists.basicLists\"\n(click)=\"addRecipe(recipe, list, list.$key, amount.value, collectible.checked)\">\n<mat-icon>playlist_play</mat-icon>\n<span>{{list.name}}</span></button>\n",
"new_path": "src/app/pages/recipes/recipes/recipes.component.html",
"old_path": "src/app/pages/recipes/recipes/recipes.component.html"
},
{
"change_type": "MODIFY",
"diff": "}\n}\n+.workshop-list {\n+ padding-left: 50px;\n+}\n+\n.amount {\nmargin-left: 20px;\nwidth: 80px;\n",
"new_path": "src/app/pages/recipes/recipes/recipes.component.scss",
"old_path": "src/app/pages/recipes/recipes/recipes.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -21,6 +21,8 @@ import {ComponentType} from '@angular/cdk/portal';\nimport {RecipesHelpComponent} from '../recipes-help/recipes-help.component';\nimport {HelpService} from '../../../core/component/help.service';\nimport {ObservableMedia} from '@angular/flex-layout';\n+import {WorkshopService} from 'app/core/database/workshop.service';\n+import {Workshop} from '../../../model/other/workshop';\ndeclare const ga: Function;\n@@ -97,7 +99,9 @@ export class RecipesComponent extends PageComponent implements OnInit {\nquery: string;\n- lists: List[];\n+ lists: { basicLists: List[], rows: { [index: string]: List[] } } = {basicLists: [], rows: {}};\n+\n+ workshops: Observable<Workshop[]>;\nloading = false;\n@@ -107,19 +111,34 @@ export class RecipesComponent extends PageComponent implements OnInit {\nprivate translator: TranslateService, private router: Router,\nprivate htmlTools: HtmlToolsService, private listService: ListService,\nprivate localizedData: LocalizedDataService, private userService: UserService,\n- protected helpService: HelpService, protected media: ObservableMedia) {\n+ protected helpService: HelpService, protected media: ObservableMedia,\n+ private workshopService: WorkshopService) {\nsuper(dialog, helpService, media);\n}\nngOnInit() {\nsuper.ngOnInit();\n+ this.workshops = this.userService.getUserData().mergeMap(user => {\n+ if (user.$key !== undefined) {\n+ return this.workshopService.getUserWorkshops(user.$key);\n+ } else {\n+ return Observable.of([]);\n+ }\n+ });\n// Load user's lists\n- this.subscriptions.push(this.userService.getUserData().switchMap((user) => {\n+ this.subscriptions.push(this.userService.getUserData()\n+ .mergeMap((user) => {\nif (user.$key !== undefined) {\n- return this.listService.getUserLists(user.$key);\n+ return this.listService.getUserLists(user.$key)\n+ .mergeMap(lists => {\n+ return this.workshopService.getUserWorkshops(user.$key)\n+ .map(workshops => this.workshopService.getListsByWorkshop(lists, workshops));\n+ });\n}\n- return Observable.of([]);\n- }).subscribe(lists => this.lists = lists));\n+ return Observable.of({basicLists: [], rows: {}});\n+ }).subscribe(lists => {\n+ this.lists = lists;\n+ }));\n// Connect debounce listener on recipe search field\nthis.subscriptions.push(Observable.fromEvent(this.filterElement.nativeElement, 'keyup')\n",
"new_path": "src/app/pages/recipes/recipes/recipes.component.ts",
"old_path": "src/app/pages/recipes/recipes/recipes.component.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
feat: workshops in "add item to list" dialog
closes #272
| 1
|
feat
| null |
217,922
|
12.03.2018 22:32:35
| -3,600
|
fc4524c4505be14862355f0fd1d2e2e061237785
|
fix: wrong amount used in some crafts for canBeCrafted flag
|
[
{
"change_type": "MODIFY",
"diff": "@@ -345,7 +345,7 @@ export class List extends DataModel {\n// While each requirement has enough items remaining, you can craft the item.\n// If only one misses, then this will turn false for the rest of the loop\ncanCraft = canCraft &&\n- (requirementItem.done - requirementItem.used) >= requirement.amount * (item.amount_needed - item.done);\n+ (requirementItem.done - requirementItem.used) >= requirement.amount * (item.amount_needed - (item.done / item.yield));\n}\n}\nreturn canCraft;\n",
"new_path": "src/app/model/list/list.ts",
"old_path": "src/app/model/list/list.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
fix: wrong amount used in some crafts for canBeCrafted flag
| 1
|
fix
| null |
217,922
|
12.03.2018 23:06:17
| -3,600
|
3dccf0efaa64669a4c2227f18a06eb984176a010
|
feat: alarm notification sound switch
closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -149,6 +149,9 @@ export class AlarmService {\n* @param {Alarm} alarm\n*/\nprivate playAlarm(alarm: Alarm): void {\n+ if (this.settings.alarmsMuted) {\n+ return;\n+ }\nconst lastPlayed = localStorage.getItem('alarms:' + alarm.itemId);\n// Don't play the alarm if it was played less than a minute ago\nif (lastPlayed === null || Date.now() - +lastPlayed > 60000) {\n",
"new_path": "src/app/core/time/alarm.service.ts",
"old_path": "src/app/core/time/alarm.service.ts"
},
{
"change_type": "MODIFY",
"diff": "<app-eorzean-time [date]=\"etime.getEorzeanTime() | async\"></app-eorzean-time>\n</div>\n<div class=\"buttons\">\n+ <mat-checkbox [(ngModel)]=\"muted\" (change)=\"saveMuted()\">{{\"Mute_alarms\" | translate}}</mat-checkbox>\n<mat-checkbox [(ngModel)]=\"compact\" (change)=\"saveCompact()\">{{\"Compact_display\" | translate}}</mat-checkbox>\n<button mat-mini-fab (click)=\"openAddAlarmPopup()\">\n<mat-icon>add_alert</mat-icon>\n",
"new_path": "src/app/pages/alarms/alarms/alarms.component.html",
"old_path": "src/app/pages/alarms/alarms/alarms.component.html"
},
{
"change_type": "MODIFY",
"diff": "position: absolute;\ntop: 10px;\nright: 15px;\n+ & > * {\n+ margin-right: 10px;\n+ }\n}\n",
"new_path": "src/app/pages/alarms/alarms/alarms.component.scss",
"old_path": "src/app/pages/alarms/alarms/alarms.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -19,6 +19,8 @@ export class AlarmsComponent {\ncompact: boolean = this.settings.compactAlarms;\n+ muted: boolean = this.settings.compactAlarms;\n+\ntime: Date = new Date();\nprivate reloader: BehaviorSubject<void> = new BehaviorSubject<void>(null);\n@@ -56,6 +58,10 @@ export class AlarmsComponent {\nthis.settings.compactAlarms = this.compact;\n}\n+ saveMuted(): void {\n+ this.settings.alarmsMuted = this.muted;\n+ }\n+\ndeleteAlarm(alarm: Alarm): void {\nthis.alarmService.unregister(alarm.itemId);\n}\n",
"new_path": "src/app/pages/alarms/alarms/alarms.component.ts",
"old_path": "src/app/pages/alarms/alarms/alarms.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -65,6 +65,14 @@ export class SettingsService {\nthis.setSetting('alarm:volume', volume.toString());\n}\n+ public get alarmsMuted(): boolean {\n+ return this.getSetting('alarms:muted', 'false') === 'true';\n+ }\n+\n+ public set alarmsMuted(compact: boolean) {\n+ this.setSetting('alarms:muted', compact.toString());\n+ }\n+\npublic get ffxivcraftingDisplay(): boolean {\nreturn this.getSetting('ffxivcrafting-display', 'false') === 'true';\n}\n",
"new_path": "src/app/pages/settings/settings.service.ts",
"old_path": "src/app/pages/settings/settings.service.ts"
},
{
"change_type": "MODIFY",
"diff": "</mat-checkbox>\n</div>\n+<div class=\"settings-row\" fxHide fxShow.gt-sm>\n+ <mat-checkbox [(ngModel)]=\"settings.alarmsMuted\">{{'Mute_alarms' | translate}}</mat-checkbox>\n+</div>\n+\n<mat-menu #langMenu=\"matMenu\" yPosition=\"above\">\n<button mat-menu-item (click)=\"use('fr')\">FR</button>\n<button mat-menu-item (click)=\"use('en')\">EN</button>\n",
"new_path": "src/app/pages/settings/settings/settings.component.html",
"old_path": "src/app/pages/settings/settings/settings.component.html"
},
{
"change_type": "MODIFY",
"diff": "\"Work_on_it\": \"I'm working on it\",\n\"Add_as_collectible\": \"Add as collectable\",\n\"Compact_display\": \"Compact display\",\n+ \"Mute_alarms\": \"Mute alarms\",\n\"WORKSHOP\": {\n\"Workshops\": \"Workshops\",\n\"Add_lists\": \"Add lists\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
},
{
"change_type": "MODIFY",
"diff": "\"Work_on_it\": \"Je m'en occupe\",\n\"Add_as_collectible\": \"Ajouter en collectionnable\",\n\"Compact_display\": \"Affichage compact\",\n+ \"Mute_alarms\": \"Mettre en sourdine\",\n\"WORKSHOP\": {\n\"Workshops\": \"Ateliers\",\n\"Add_lists\": \"Ajouter des listes\",\n",
"new_path": "src/assets/i18n/fr.json",
"old_path": "src/assets/i18n/fr.json"
},
{
"change_type": "MODIFY",
"diff": "\"Work_on_it\": \"I'm working on it\",\n\"Add_as_collectible\": \"Add as collectable\",\n\"Compact_display\": \"Compact display\",\n+ \"Mute_alarms\": \"Mute alarms\",\n\"WORKSHOP\": {\n\"Workshops\": \"Workshops\",\n\"Add_lists\": \"Add lists\",\n",
"new_path": "src/assets/i18n/ja.json",
"old_path": "src/assets/i18n/ja.json"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
feat: alarm notification sound switch
closes #274
| 1
|
feat
| null |
217,922
|
12.03.2018 23:15:39
| -3,600
|
33e951ef3669c8f84078b6350136641cbb7bb156
|
chore(release): 3.4.0-beta.1
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"3.4.0-beta.1\"></a>\n+# [3.4.0-beta.1](https://github.com/Supamiu/ffxiv-teamcraft/compare/v3.4.0-beta.0...v3.4.0-beta.1) (2018-03-12)\n+\n+\n+### Bug Fixes\n+\n+* wrong amount used in some crafts for canBeCrafted flag ([fc4524c](https://github.com/Supamiu/ffxiv-teamcraft/commit/fc4524c))\n+* wrong item amount in requirements dialog box ([cabe973](https://github.com/Supamiu/ffxiv-teamcraft/commit/cabe973))\n+\n+\n+### Features\n+\n+* alarm notification sound switch ([3dccf0e](https://github.com/Supamiu/ffxiv-teamcraft/commit/3dccf0e)), closes [#274](https://github.com/Supamiu/ffxiv-teamcraft/issues/274)\n+* rename workshops ([d6e706b](https://github.com/Supamiu/ffxiv-teamcraft/commit/d6e706b)), closes [#268](https://github.com/Supamiu/ffxiv-teamcraft/issues/268)\n+* workshops in \"add item to list\" dialog ([bb6b6b2](https://github.com/Supamiu/ffxiv-teamcraft/commit/bb6b6b2)), closes [#272](https://github.com/Supamiu/ffxiv-teamcraft/issues/272)\n+\n+\n+\n<a name=\"3.4.0-beta.0\"></a>\n# [3.4.0-beta.0](https://github.com/Supamiu/ffxiv-teamcraft/compare/v3.3.1...v3.4.0-beta.0) (2018-03-09)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"teamcraft\",\n- \"version\": \"3.4.0-beta.0\",\n+ \"version\": \"3.4.0-beta.1\",\n\"lockfileVersion\": 1,\n\"requires\": true,\n\"dependencies\": {\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"teamcraft\",\n- \"version\": \"3.4.0-beta.0\",\n+ \"version\": \"3.4.0-beta.1\",\n\"license\": \"MIT\",\n\"scripts\": {\n\"ng\": \"ng\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore(release): 3.4.0-beta.1
| 1
|
chore
|
release
|
217,922
|
12.03.2018 23:44:36
| -3,600
|
4dd5a1386f4aa3b8c261004e3c60592a558acb85
|
build: add firebase-functions to install task
|
[
{
"change_type": "MODIFY",
"diff": "@@ -7,6 +7,9 @@ before_install:\n- export DISPLAY=:99.0\n- sh -e /etc/init.d/xvfb start\n+install:\n+ - npm i -g firebase-functions\n+\nscript:\n- if [ $TRAVIS_BRANCH = \"beta\" ]; then npm run build:beta; else npm run build:prod; fi\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
build: add firebase-functions to install task
| 1
|
build
| null |
815,746
|
13.03.2018 09:11:15
| -7,200
|
3311f8cd60326cf1711fc9fe85fd11e052f068e6
|
fix: clear previous model then setting new programatically
fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -22,6 +22,7 @@ import { DataService } from '../shared/data.service';\n<li *ngFor=\"let item of selectedPeople1\">{{item.name}}</li>\n</ul>\n<button (click)=\"clearModel1()\" class=\"btn btn-secondary btn-sm\">Clear model</button>\n+ <button (click)=\"changeModel1()\" class=\"btn btn-secondary btn-sm\">Change model</button>\n</div>\n<hr/>\n@@ -110,6 +111,10 @@ export class SelectMultiComponent {\nthis.selectedPeople1 = [];\n}\n+ changeModel1() {\n+ this.selectedPeople1 = [{ name: 'New person' }];\n+ }\n+\nclearModel2() {\nthis.selectedPeople2 = [];\n}\n",
"new_path": "demo/app/examples/multi.component.ts",
"old_path": "demo/app/examples/multi.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -308,7 +308,7 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.selectedCity).toBeNull();\n}));\n- it('should clear previous value when setting new model', fakeAsync(() => {\n+ it('should clear previous single select value when setting new model', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectModelChangesTestCmp,\n`<ng-select [items]=\"cities\"\n@@ -328,6 +328,30 @@ describe('NgSelectComponent', function () {\nexpect(lastSelection.selected).toBeFalsy();\n}));\n+ it('should clear previous multiple select value when setting new model', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectModelChangesTestCmp,\n+ `<ng-select [items]=\"cities\"\n+ bindLabel=\"name\"\n+ [multiple]=\"true\"\n+ [clearable]=\"true\"\n+ [(ngModel)]=\"selectedCities\">\n+ </ng-select>`);\n+\n+ fixture.componentInstance.selectedCities = [fixture.componentInstance.cities[0]];\n+ tickAndDetectChanges(fixture);\n+ const select = fixture.componentInstance.select;\n+ expect(select.selectedItems.length).toBe(1);\n+\n+ fixture.componentInstance.selectedCities = [fixture.componentInstance.cities[1]];\n+ tickAndDetectChanges(fixture);\n+ expect(select.selectedItems.length).toBe(1);\n+\n+ fixture.componentInstance.selectedCities = [];\n+ tickAndDetectChanges(fixture);\n+ expect(select.selectedItems.length).toBe(0);\n+ }));\n+\nit('should not add selected items to new items list when [items] are changed', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectModelChangesTestCmp,\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -250,6 +250,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nif (value === undefined) {\nreturn;\n}\n+ this.itemsList.clearSelected();\nthis._validateWriteValue(value);\nthis._handleWriteValue(value);\nthis.detectChanges();\n@@ -496,7 +497,6 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nprivate _handleWriteValue(ngModel: any | any[]) {\nconst isEmptyArray = ngModel && Array.isArray(ngModel) && ngModel.length === 0;\nif (ngModel === null || isEmptyArray) {\n- this.itemsList.clearSelected();\nreturn;\n}\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: clear previous model then setting new programatically (#346)
fixes #343
| 1
|
fix
| null |
815,746
|
13.03.2018 09:17:43
| -7,200
|
32c4b25f759565f17885d3229e42ebaf831cfd80
|
fix: demo custom templates
|
[
{
"change_type": "MODIFY",
"diff": "@@ -89,7 +89,7 @@ import { distinctUntilChanged, debounceTime, switchMap } from 'rxjs/operators'\n---\n<p>\nSelected people: {{selectedPeople}}\n- </p\n+ </p>\n<label>Custom not found, type to search and loading </label>\n---html,true\n@@ -107,15 +107,13 @@ import { distinctUntilChanged, debounceTime, switchMap } from 'rxjs/operators'\n</div>\n</ng-template>\n<ng-template ng-notfound-tmp let-searchTerm=\"searchTerm\">\n-\n<div class=\"ng-option disabled\">\nNo data found for \"{{searchTerm}}\"\n</div>\n</ng-template>\n<ng-template ng-loadingtext-tmp let-searchTerm=\"searchTerm\">\n-\n<div class=\"ng-option disabled\">\n- Fetching Data for \"{{searchTerm}}\"\n+ Fetching data for \"{{searchTerm}}\"\n</div>\n</ng-template>\n</ng-select>\n",
"new_path": "demo/app/examples/custom-templates.component.ts",
"old_path": "demo/app/examples/custom-templates.component.ts"
},
{
"change_type": "MODIFY",
"diff": "</ng-template>\n<ng-template\n- [ngTemplateOutlet]=\"typeToSearchTemplate || defaultTypeToSearchTemplate\"\n- [ngTemplateOutletContext]=\"{ searchTerm: filterValue }\">\n+ [ngTemplateOutlet]=\"typeToSearchTemplate || defaultTypeToSearchTemplate\">\n</ng-template>\n</ng-container>\n<ng-template\n[ngTemplateOutlet]=\"loadingTextTemplate || defaultLoadingTextTemplate\"\n- [ngTemplateOutletContext]=\"{ isearchTerm: filterValue }\">\n+ [ngTemplateOutletContext]=\"{ searchTerm: filterValue }\">\n</ng-template>\n</ng-container>\n",
"new_path": "src/ng-select/ng-select.component.html",
"old_path": "src/ng-select/ng-select.component.html"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: demo custom templates
| 1
|
fix
| null |
815,746
|
13.03.2018 09:18:30
| -7,200
|
b8b4acf2fe26cb5fa75738a98d84d44d0738a6cf
|
chore(release): 0.28.0
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.28.0\"></a>\n+# [0.28.0](https://github.com/ng-select/ng-select/compare/v0.27.1...v0.28.0) (2018-03-13)\n+\n+\n+### Bug Fixes\n+\n+* clear previous model then setting new programatically ([#346](https://github.com/ng-select/ng-select/issues/346)) ([3311f8c](https://github.com/ng-select/ng-select/commit/3311f8c)), closes [#343](https://github.com/ng-select/ng-select/issues/343)\n+* demo custom templates ([32c4b25](https://github.com/ng-select/ng-select/commit/32c4b25))\n+\n+\n+### Features\n+\n+* **template:** loading, not found, type to search state template options. ([#341](https://github.com/ng-select/ng-select/issues/341)) ([acdf5c2](https://github.com/ng-select/ng-select/commit/acdf5c2)), closes [#217](https://github.com/ng-select/ng-select/issues/217) [#201](https://github.com/ng-select/ng-select/issues/201)\n+\n+\n+\n<a name=\"0.27.1\"></a>\n## [0.27.1](https://github.com/ng-select/ng-select/compare/v0.27.0...v0.27.1) (2018-03-12)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"$schema\": \"../node_modules/ng-packagr/package.schema.json\",\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.27.1\",\n+ \"version\": \"0.28.0\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.28.0
| 1
|
chore
|
release
|
807,849
|
13.03.2018 09:22:04
| 25,200
|
4de055dc83c264f9996869bd9d1fc0fbf1a9c3ed
|
feat: Upstream changes warn in CI, throw locally
refs refs
|
[
{
"change_type": "MODIFY",
"diff": "@@ -1030,6 +1030,33 @@ describe(\"PublishCommand\", () => {\n});\n});\n+ describe(\"when local clone is behind upstream\", () => {\n+ it(\"throws an error during interactive publish\", async () => {\n+ const testDir = await initFixture(\"normal\");\n+\n+ GitUtilities.isBehindUpstream.mockReturnValueOnce(true);\n+\n+ try {\n+ await lernaPublish(testDir)();\n+ } catch (err) {\n+ expect(err.message).toMatch(\"behind remote upstream\");\n+ expect(err.message).toMatch(\"Please merge remote changes\");\n+ }\n+ });\n+\n+ it(\"logs a warning and exits early during CI publish\", async () => {\n+ const testDir = await initFixture(\"normal\");\n+\n+ GitUtilities.isBehindUpstream.mockReturnValueOnce(true);\n+\n+ await lernaPublish(testDir)(\"--ci\");\n+\n+ const [warning] = loggingOutput(\"warn\");\n+ expect(warning).toMatch(\"behind remote upstream\");\n+ expect(warning).toMatch(\"exiting\");\n+ });\n+ });\n+\n/** =========================================================================\n* VERSION LIFECYCLE SCRIPTS\n* ======================================================================= */\n",
"new_path": "commands/publish/__tests__/publish-command.test.js",
"old_path": "commands/publish/__tests__/publish-command.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -72,6 +72,7 @@ class PublishCommand extends Command {\n}\nconst currentBranch = GitUtilities.getCurrentBranch(this.execOpts);\n+\nif (\nthis.options.allowBranch &&\n![].concat(this.options.allowBranch).some(x => minimatch(currentBranch, x))\n@@ -86,16 +87,27 @@ class PublishCommand extends Command {\n}\nif (GitUtilities.isBehindUpstream(this.gitRemote, this.execOpts)) {\n- const remote = `${this.gitRemote}/${currentBranch} `;\n+ const message = `Local branch '${currentBranch}' is behind remote upstream ${\n+ this.gitRemote\n+ }/${currentBranch}`;\n+\n+ if (!this.options.ci) {\n+ // interrupt interactive publish\nthrow new ValidationError(\n\"EBEHIND\",\ndedent`\n- Local branch '${currentBranch}' is behind remote upstream ${remote}\n- Please merge in remote changes into '${currentBranch}'.\n- Remote changes can be fetched and merged with git pull\n+ ${message}\n+ Please merge remote changes into '${currentBranch}' with 'git pull'\n`\n);\n}\n+\n+ // CI publish should not error, but warn & exit\n+ this.logger.warn(\"EBEHIND\", `${message}, exiting`);\n+\n+ // still exits zero, aka \"ok\"\n+ return false;\n+ }\n}\nthis.conf = npmConf(this.options);\n",
"new_path": "commands/publish/index.js",
"old_path": "commands/publish/index.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -182,6 +182,11 @@ describe(\"lerna publish\", () => {\nawait gitCommit(cloneDir, \"upstream change\");\nawait execa(\"git\", [\"push\", \"origin\", \"master\"], { cwd: cloneDir });\n- await expect(cliRunner(cwd)(\"publish\")).rejects.toThrowError(/EBEHIND/);\n+ // throws during interactive publish (local)\n+ await expect(cliRunner(cwd)(\"publish\", \"--no-ci\")).rejects.toThrowError(/EBEHIND/);\n+\n+ // warns during non-interactive publish (CI)\n+ const { stderr } = await cliRunner(cwd)(\"publish\", \"--ci\");\n+ expect(stderr).toMatch(\"EBEHIND\");\n});\n});\n",
"new_path": "integration/lerna-publish.test.js",
"old_path": "integration/lerna-publish.test.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
feat: Upstream changes warn in CI, throw locally
refs #1177, refs #1317
| 1
|
feat
| null |
807,849
|
13.03.2018 10:52:03
| 25,200
|
86a4d6534dfb462f7192317649697887d1f2a6cd
|
feat(global-options): Add hidden `ci` option
|
[
{
"change_type": "MODIFY",
"diff": "@@ -5,6 +5,11 @@ module.exports = globalOptions;\nfunction globalOptions(yargs) {\n// the global options applicable to _every_ command\nconst opts = {\n+ ci: {\n+ // set in core/cli via .config()\n+ hidden: true,\n+ type: \"boolean\",\n+ },\nloglevel: {\ndefaultDescription: \"info\",\ndescribe: \"What level of logs to report.\",\n",
"new_path": "core/global-options/index.js",
"old_path": "core/global-options/index.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
feat(global-options): Add hidden `ci` option
| 1
|
feat
|
global-options
|
807,849
|
13.03.2018 10:52:55
| 25,200
|
5452293b1918b52b4cb6d4251941b83d168aab66
|
feat(cli): Set config.ci from env var
|
[
{
"change_type": "MODIFY",
"diff": "@@ -54,6 +54,7 @@ function lernaCLI(argv, cwd) {\nreturn globalOptions(cli)\n.usage(\"Usage: $0 <command> [options]\")\n+ .config({ ci: isCI })\n.command(addCmd)\n.command(bootstrapCmd)\n.command(changedCmd)\n",
"new_path": "core/cli/index.js",
"old_path": "core/cli/index.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
feat(cli): Set config.ci from env var
| 1
|
feat
|
cli
|
791,690
|
13.03.2018 11:20:02
| 25,200
|
cc6dd0be0faa59bb9307a783cea44bb9a53f2d3b
|
core(network-requests): add resource type
|
[
{
"change_type": "MODIFY",
"diff": "@@ -41,6 +41,8 @@ class NetworkRequests extends Audit {\nendTime: (record.endTime - earliestStartTime) * 1000,\ntransferSize: record.transferSize,\nstatusCode: record.statusCode,\n+ mimeType: record.mimeType,\n+ resourceType: record._resourceType && record._resourceType._name,\n};\n});\n@@ -56,13 +58,15 @@ class NetworkRequests extends Audit {\ntext: 'Transfer Size',\n},\n{key: 'statusCode', itemType: 'text', text: 'Status Code'},\n+ {key: 'mimeType', itemType: 'text', text: 'MIME Type'},\n+ {key: 'resourceType', itemType: 'text', text: 'Resource Type'},\n];\nconst tableDetails = Audit.makeTableDetails(headings, results);\nreturn {\nscore: 100,\n- rawValue: records.length,\n+ rawValue: results.length,\nextendedInfo: {value: results},\ndetails: tableDetails,\n};\n",
"new_path": "lighthouse-core/audits/network-requests.js",
"old_path": "lighthouse-core/audits/network-requests.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(network-requests): add resource type (#4743)
| 1
|
core
|
network-requests
|
815,804
|
13.03.2018 12:27:27
| -19,080
|
acdf5c221f793ea7fa6d98829d2dca033b6baec0
|
feat(template): loading, not found, type to search state template options.
closes
|
[
{
"change_type": "MODIFY",
"diff": "-import { Component, ChangeDetectionStrategy } from '@angular/core';\n+import { Component, ChangeDetectionStrategy, EventEmitter, ChangeDetectorRef } from '@angular/core';\nimport { DataService } from '../shared/data.service';\n+import { distinctUntilChanged, debounceTime, switchMap } from 'rxjs/operators'\n+\n@Component({\nselector: 'select-with-templates',\n@@ -85,9 +87,43 @@ import { DataService } from '../shared/data.service';\n</ng-template>\n</ng-select>\n---\n+ <p>\n+ Selected people: {{selectedPeople}}\n+ </p\n+\n+ <label>Custom not found , type to search and loading </label>\n+ ---html,true\n+ <ng-select\n+ [multiple]=\"true\"\n+ [items]=\"serverSideFilterItems\"\n+ [(ngModel)]=\"selectedPeople\"\n+ placeholder=\"Select people\"\n+ bindLabel=\"name\"\n+ bindValue=\"name\"\n+ [typeahead]=\"peopleTypeahead\">\n+ <ng-template ng-typetosearch-tmp>\n+ <div class=\"ng-option disabled\">\n+ Start typing...\n+ </div>\n+ </ng-template>\n+ <ng-template ng-notfound-tmp let-searchTerm=\"searchTerm\">\n+\n+ <div class=\"ng-option disabled\">\n+ No data found for \"{{searchTerm}}\"\n+ </div>\n+ </ng-template>\n+ <ng-template ng-loadingtext-tmp let-searchTerm=\"searchTerm\">\n+\n+ <div class=\"ng-option disabled\">\n+ Fetching Data for \"{{searchTerm}}\"\n+ </div>\n+ </ng-template>\n+ </ng-select>\n+ ---\n<p>\nSelected people: {{selectedPeople}}\n</p>\n+\n<hr />\n<label>Custom search</label>\n@@ -119,13 +155,17 @@ export class SelectWithTemplatesComponent {\npeople = [];\nselectedPeople = [];\n+ serverSideFilterItems = [];\n+\n+ peopleTypeahead = new EventEmitter<string>();\n- constructor(private dataService: DataService) {}\n+ constructor(private dataService: DataService, private cd: ChangeDetectorRef) {}\nngOnInit() {\nthis.dataService.getPeople().subscribe(items => {\nthis.people = items;\n});\n+ this.serverSideSearch();\n}\nselectAll() {\n@@ -135,5 +175,19 @@ export class SelectWithTemplatesComponent {\nunselectAll() {\nthis.selectedPeople = [];\n}\n+\n+ private serverSideSearch() {\n+ this.peopleTypeahead.pipe(\n+ distinctUntilChanged(),\n+ debounceTime(300),\n+ switchMap(term => this.dataService.getPeople(term))\n+ ).subscribe(x => {\n+ this.cd.markForCheck();\n+ this.serverSideFilterItems = x;\n+ }, (err) => {\n+ console.log(err);\n+ this.serverSideFilterItems = [];\n+ });\n+ }\n}\n",
"new_path": "demo/app/examples/custom-templates.component.ts",
"old_path": "demo/app/examples/custom-templates.component.ts"
},
{
"change_type": "MODIFY",
"diff": "</div>\n</ng-container>\n- <div class=\"ng-option disabled\" *ngIf=\"showNoItemsFound()\">\n- {{notFoundText}}\n- </div>\n+ <ng-container *ngIf=\"showNoItemsFound()\">\n+ <ng-template #defaultNotfoundTemplate>\n+ <div class=\"ng-option disabled\" [innerHTML]=\"notFoundText\" *ngIf=\"showNoItemsFound()\"></div>\n+ </ng-template>\n- <div class=\"ng-option disabled\" *ngIf=\"showTypeToSearch()\">\n- {{typeToSearchText}}\n- </div>\n+ <ng-template\n+ [ngTemplateOutlet]=\"notFoundTemplate || defaultNotfoundTemplate\"\n+ [ngTemplateOutletContext]=\"{searchTerm: filterValue }\">\n+ </ng-template>\n+ </ng-container>\n+\n+ <ng-container *ngIf=\"showTypeToSearch()\">\n+ <ng-template #defaultTypeToSearchTemplate>\n+ <div class=\"ng-option disabled\" [innerHTML]=\"typeToSearchText\"></div>\n+ </ng-template>\n+\n+ <ng-template\n+ [ngTemplateOutlet]=\"typeToSearchTemplate || defaultTypeToSearchTemplate\"\n+ [ngTemplateOutletContext]=\"{ searchTerm: filterValue }\">\n+ </ng-template>\n+ </ng-container>\n+\n+ <ng-container *ngIf=\"isLoading && itemsList.filteredItems.length === 0\">\n+ <ng-template #defaultLoadingTextTemplate>\n+ <div class=\"ng-option disabled\" [innerHTML]=\"loadingText\" ></div>\n+ </ng-template>\n+\n+ <ng-template\n+ [ngTemplateOutlet]=\"loadingTextTemplate || defaultLoadingTextTemplate\"\n+ [ngTemplateOutletContext]=\"{ isearchTerm: filterValue }\">\n+ </ng-template>\n+ </ng-container>\n- <div class=\"ng-option disabled\" *ngIf=\"isLoading && itemsList.filteredItems.length === 0\">\n- {{loadingText}}\n- </div>\n</ng-dropdown-panel>\n",
"new_path": "src/ng-select/ng-select.component.html",
"old_path": "src/ng-select/ng-select.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -1139,6 +1139,78 @@ describe('NgSelectComponent', function () {\n});\n}));\n+\n+ it('should display custom loading and no data found template', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectFilterTestCmp,\n+ `<ng-select [items]=\"cities\"\n+ [loading]=\"citiesLoading\"\n+ [(ngModel)]=\"selectedCity\">\n+\n+ <ng-template ng-notfound-tmp let-searchTerm=\"searchTerm\">\n+ <div class=\"custom-notfound\">\n+ No data found for \"{{searchTerm}}\"\n+ </div>\n+ </ng-template>\n+ <ng-template ng-loadingtext-tmp let-searchTerm=\"searchTerm\">\n+ <div class=\"custom-loading\">\n+ Fetching Data for \"{{searchTerm}}\"\n+ </div>\n+ </ng-template>\n+ </ng-select>`);\n+\n+\n+\n+ fixture.whenStable().then(() => {\n+ fixture.componentInstance.cities = [];\n+ fixture.componentInstance.citiesLoading = true;\n+ tickAndDetectChanges(fixture);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n+ tickAndDetectChanges(fixture);\n+ const loadingOption = fixture.debugElement.queryAll(By.css('.custom-loading'));\n+ expect(loadingOption.length).toBe(1);\n+\n+\n+ fixture.componentInstance.citiesLoading = false;\n+ tickAndDetectChanges(fixture);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n+ tickAndDetectChanges(fixture);\n+ const notFoundOptions = fixture.debugElement.queryAll(By.css('.custom-notfound'));\n+ expect(notFoundOptions.length).toBe(1);\n+\n+ });\n+ }));\n+\n+ it('should display custom type for search template', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectFilterTestCmp,\n+ `<ng-select [items]=\"cities\"\n+ [typeahead]=\"customFilter\"\n+ [(ngModel)]=\"selectedCity\">\n+ <ng-template ng-typetosearch-tmp>\n+ <div class=\"custom-typeforsearch\">\n+ Start typing...\n+ </div>\n+ </ng-template>\n+\n+ </ng-select>`);\n+\n+\n+\n+ fixture.whenStable().then(() => {\n+ fixture.componentInstance.cities = [];\n+ fixture.componentInstance.select.open();\n+ fixture.componentInstance.customFilter.subscribe();\n+ tickAndDetectChanges(fixture);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n+ tickAndDetectChanges(fixture);\n+ const loadingOption = fixture.debugElement.queryAll(By.css('.custom-typeforsearch'));\n+ expect(loadingOption.length).toBe(1);\n+\n+ });\n+\n+ }));\n+\nit('should create items from ng-option', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectBasicTestCmp,\n@@ -2182,6 +2254,7 @@ class NgSelectModelChangesTestCmp {\n})\nclass NgSelectFilterTestCmp {\n@ViewChild(NgSelectComponent) select: NgSelectComponent;\n+ citiesLoading = false;\nselectedCity: { id: number; name: string };\ncities = [\n{ id: 1, name: 'Vilnius' },\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -32,7 +32,10 @@ import {\nNgLabelTemplateDirective,\nNgHeaderTemplateDirective,\nNgFooterTemplateDirective,\n- NgOptgroupTemplateDirective\n+ NgOptgroupTemplateDirective,\n+ NgNotFoundTemplateDirective,\n+ NgTypeToSearchTemplateDirective,\n+ NgLoadingTextTemplateDirective\n} from './ng-templates.directive';\nimport { NgOption, KeyCode, NgSelectConfig } from './ng-select.types';\n@@ -110,6 +113,9 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n@ContentChild(NgLabelTemplateDirective, { read: TemplateRef }) labelTemplate: TemplateRef<any>;\n@ContentChild(NgHeaderTemplateDirective, { read: TemplateRef }) headerTemplate: TemplateRef<any>;\n@ContentChild(NgFooterTemplateDirective, { read: TemplateRef }) footerTemplate: TemplateRef<any>;\n+ @ContentChild(NgNotFoundTemplateDirective, { read: TemplateRef }) notFoundTemplate: TemplateRef<any>;\n+ @ContentChild(NgTypeToSearchTemplateDirective, { read: TemplateRef }) typeToSearchTemplate: TemplateRef<any>;\n+ @ContentChild(NgLoadingTextTemplateDirective, { read: TemplateRef }) loadingTextTemplate: TemplateRef<any>;\n@ViewChild(forwardRef(() => NgDropdownPanelComponent)) dropdownPanel: NgDropdownPanelComponent;\n@ContentChildren(NgOptionComponent, { descendants: true }) ngOptions: QueryList<NgOptionComponent>;\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -6,7 +6,10 @@ import {\nNgLabelTemplateDirective,\nNgHeaderTemplateDirective,\nNgFooterTemplateDirective,\n- NgOptgroupTemplateDirective\n+ NgOptgroupTemplateDirective,\n+ NgNotFoundTemplateDirective,\n+ NgTypeToSearchTemplateDirective,\n+ NgLoadingTextTemplateDirective\n} from './ng-templates.directive';\nimport { NgOptionComponent } from './ng-option.component';\nimport { NgOptionHighlightDirective } from './ng-option-highlight.directive' ;\n@@ -25,6 +28,9 @@ import { VirtualScrollService } from './virtual-scroll.service';\nNgLabelTemplateDirective,\nNgHeaderTemplateDirective,\nNgFooterTemplateDirective,\n+ NgNotFoundTemplateDirective,\n+ NgTypeToSearchTemplateDirective,\n+ NgLoadingTextTemplateDirective\n],\nimports: [\nCommonModule\n@@ -37,7 +43,10 @@ import { VirtualScrollService } from './virtual-scroll.service';\nNgOptionTemplateDirective,\nNgLabelTemplateDirective,\nNgHeaderTemplateDirective,\n- NgFooterTemplateDirective\n+ NgFooterTemplateDirective,\n+ NgNotFoundTemplateDirective,\n+ NgTypeToSearchTemplateDirective,\n+ NgLoadingTextTemplateDirective\n],\nproviders: [\nWindowService,\n",
"new_path": "src/ng-select/ng-select.module.ts",
"old_path": "src/ng-select/ng-select.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -29,3 +29,23 @@ export class NgFooterTemplateDirective {\nconstructor(public template: TemplateRef<any>) {\n}\n}\n+\n+@Directive({ selector: '[ng-notfound-tmp]' })\n+export class NgNotFoundTemplateDirective {\n+ constructor(public template: TemplateRef<any>) {\n+ }\n+}\n+\n+\n+@Directive({ selector: '[ng-typetosearch-tmp]' })\n+export class NgTypeToSearchTemplateDirective {\n+ constructor(public template: TemplateRef<any>) {\n+ }\n+}\n+\n+\n+@Directive({ selector: '[ng-loadingtext-tmp]' })\n+export class NgLoadingTextTemplateDirective {\n+ constructor(public template: TemplateRef<any>) {\n+ }\n+}\n",
"new_path": "src/ng-select/ng-templates.directive.ts",
"old_path": "src/ng-select/ng-templates.directive.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
feat(template): loading, not found, type to search state template options. (#341)
closes #217, #201
| 1
|
feat
|
template
|
723,991
|
13.03.2018 13:33:47
| -25,200
|
cbeffec8ce696a5491554133e891a730cad5108c
|
docs: replace hasProp() with props() in docs examples
|
[
{
"change_type": "MODIFY",
"diff": "@@ -42,7 +42,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/en/api/mount.md",
"old_path": "docs/en/api/mount.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -51,7 +51,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/en/api/shallow.md",
"old_path": "docs/en/api/shallow.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -44,7 +44,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/fr/api/mount.md",
"old_path": "docs/fr/api/mount.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -55,7 +55,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/fr/api/shallow.md",
"old_path": "docs/fr/api/shallow.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -41,7 +41,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/ja/api/mount.md",
"old_path": "docs/ja/api/mount.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -52,7 +52,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/ja/api/shallow.md",
"old_path": "docs/ja/api/shallow.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -43,7 +43,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/kr/api/mount.md",
"old_path": "docs/kr/api/mount.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -55,7 +55,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/kr/api/shallow.md",
"old_path": "docs/kr/api/shallow.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -44,7 +44,7 @@ describe('Foo', () => {\ncor: 'vermelha'\n}\n})\n- expect(wrapper.hasProp('cor', 'vermelha')).toBe(true)\n+ expect(wrapper.props().cor).toBe('vermelha')\n})\n})\n```\n",
"new_path": "docs/pt-br/api/mount.md",
"old_path": "docs/pt-br/api/mount.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -55,7 +55,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/pt-br/api/shallow.md",
"old_path": "docs/pt-br/api/shallow.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -42,7 +42,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/ru/api/mount.md",
"old_path": "docs/ru/api/mount.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -51,7 +51,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/ru/api/shallow.md",
"old_path": "docs/ru/api/shallow.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -42,7 +42,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/zh-cn/api/mount.md",
"old_path": "docs/zh-cn/api/mount.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -51,7 +51,7 @@ describe('Foo', () => {\ncolor: 'red'\n}\n})\n- expect(wrapper.hasProp('color', 'red')).toBe(true)\n+ expect(wrapper.props().color).toBe('red')\n})\n})\n```\n",
"new_path": "docs/zh-cn/api/shallow.md",
"old_path": "docs/zh-cn/api/shallow.md"
}
] |
JavaScript
|
MIT License
|
vuejs/vue-test-utils
|
docs: replace hasProp() with props() in docs examples (#466)
| 1
|
docs
| null |
217,922
|
13.03.2018 13:42:49
| -3,600
|
f0bd57265d6a806cc625f0ee3e069069fd757e18
|
feat: add filter for tradeable items
closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -21,6 +21,20 @@ export class LayoutRowFilter {\n.find(source => source.trades\n.find(trade => [20, 21, 22].indexOf(+trade.currencyId) > -1) !== undefined) !== undefined, 'IS_GC_TRADE');\n+ static IS_TOKEN_TRADE = new LayoutRowFilter(row => {\n+ if (row.tradeSources !== undefined) {\n+ // These ids are for voidrake and Althyk lavender.\n+ for (const tokenId of [15858, 15857]) {\n+ if (row.tradeSources\n+ .find(source => source.trades\n+ .find(trade => trade.currencyId === tokenId) !== undefined) !== undefined) {\n+ return true;\n+ }\n+ }\n+ }\n+ return false;\n+ }, 'IS_TOKEN_TRADE');\n+\nstatic IS_MASTERCRAFT = LayoutRowFilter.IS_CRAFT\n._and(new LayoutRowFilter(row => row.craftedBy.find(craft => craft.masterbook !== undefined) !== undefined,\n'IS_MASTERCRAFT'));\n",
"new_path": "src/app/core/layout/layout-row-filter.ts",
"old_path": "src/app/core/layout/layout-row-filter.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
feat: add filter for tradeable items
closes #267
| 1
|
feat
| null |
730,429
|
13.03.2018 14:57:05
| 14,400
|
181730e088a7219bfd830ed53f971366ba42b78b
|
feat(react-component-activity-item-base): add action pending class
|
[
{
"change_type": "MODIFY",
"diff": "// Jest Snapshot v1, https://goo.gl/fbAQLP\nexports[`ActivityItemBase component renders properly 1`] = `\n+<div\n+ className=\"activity-item activityItem\"\n+>\n+ <div\n+ className=\"ciscospark-avatar-wrapper ciscospark-activity-item-avatar-wrapper avatarWrapper\"\n+ >\n+ <Connect(PresenceAvatar)\n+ avatarId=\"user-abc-123\"\n+ iconSize=\"30px\"\n+ isSelfAvatar={false}\n+ name=\"Test User\"\n+ />\n+ </div>\n+ <div\n+ className=\"ciscospark-content-container contentContainer\"\n+ >\n+ <div\n+ className=\"ciscospark-meta meta\"\n+ >\n+ <div\n+ className=\"ciscospark-display-name displayName\"\n+ title=\"Test User\"\n+ >\n+ Test User\n+ </div>\n+ <div\n+ className=\"ciscospark-published published\"\n+ >\n+ 2016-09-20T19:52:57.186Z\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-content content\"\n+ >\n+ <div>\n+ Test Content\n+ </div>\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-post-actions activityPostActions\"\n+ >\n+ <div\n+ className=\"activity-post-action activityPostAction\"\n+ >\n+ <ActivityPostAction\n+ iconType=\"icon-flag_12\"\n+ onClick={[Function]}\n+ title=\"Flag this message\"\n+ />\n+ </div>\n+ <div\n+ className=\"activity-post-action activityPostAction\"\n+ >\n+ <div\n+ className=\"ciscospark-action-spacer actionSpacer\"\n+ />\n+ </div>\n+ </div>\n+</div>\n+`;\n+\n+exports[`ActivityItemBase component renders properly when additional 1`] = `\n+<div\n+ className=\"activity-item activityItem activity-item-additional additional\"\n+>\n+ <div\n+ className=\"ciscospark-avatar-wrapper ciscospark-activity-item-avatar-wrapper avatarWrapper\"\n+ >\n+ <Connect(PresenceAvatar)\n+ avatarId=\"user-abc-123\"\n+ iconSize=\"30px\"\n+ isSelfAvatar={false}\n+ name=\"Test User\"\n+ />\n+ </div>\n+ <div\n+ className=\"ciscospark-content-container contentContainer\"\n+ >\n+ <div\n+ className=\"ciscospark-meta meta\"\n+ >\n+ <div\n+ className=\"ciscospark-display-name displayName\"\n+ title=\"Test User\"\n+ >\n+ Test User\n+ </div>\n+ <div\n+ className=\"ciscospark-published published\"\n+ >\n+ 2016-09-20T19:52:57.186Z\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-content content\"\n+ >\n+ <div>\n+ Test Content\n+ </div>\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-post-actions activityPostActions\"\n+ >\n+ <div\n+ className=\"activity-post-action activityPostAction\"\n+ >\n+ <ActivityPostAction\n+ iconType=\"icon-flag_12\"\n+ onClick={[Function]}\n+ title=\"Flag this message\"\n+ />\n+ </div>\n+ <div\n+ className=\"activity-post-action activityPostAction\"\n+ >\n+ <div\n+ className=\"ciscospark-action-spacer actionSpacer\"\n+ />\n+ </div>\n+ </div>\n+</div>\n+`;\n+\n+exports[`ActivityItemBase component renders properly when flagged 1`] = `\n+<div\n+ className=\"activity-item activityItem\"\n+>\n+ <div\n+ className=\"ciscospark-avatar-wrapper ciscospark-activity-item-avatar-wrapper avatarWrapper\"\n+ >\n+ <Connect(PresenceAvatar)\n+ avatarId=\"user-abc-123\"\n+ iconSize=\"30px\"\n+ isSelfAvatar={false}\n+ name=\"Test User\"\n+ />\n+ </div>\n+ <div\n+ className=\"ciscospark-content-container contentContainer\"\n+ >\n+ <div\n+ className=\"ciscospark-meta meta\"\n+ >\n+ <div\n+ className=\"ciscospark-display-name displayName\"\n+ title=\"Test User\"\n+ >\n+ Test User\n+ </div>\n+ <div\n+ className=\"ciscospark-published published\"\n+ >\n+ 2016-09-20T19:52:57.186Z\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-content content\"\n+ >\n+ <div>\n+ Test Content\n+ </div>\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-post-actions activityPostActions\"\n+ >\n+ <div\n+ className=\"activity-post-action activityPostAction isHighlighted isHighlighted\"\n+ >\n+ <ActivityPostAction\n+ iconType=\"icon-flag_12\"\n+ onClick={[Function]}\n+ title=\"Flag this message\"\n+ />\n+ </div>\n+ <div\n+ className=\"activity-post-action activityPostAction\"\n+ >\n+ <div\n+ className=\"ciscospark-action-spacer actionSpacer\"\n+ />\n+ </div>\n+ </div>\n+</div>\n+`;\n+\n+exports[`ActivityItemBase component renders properly when flagged pending 1`] = `\n+<div\n+ className=\"activity-item activityItem\"\n+>\n+ <div\n+ className=\"ciscospark-avatar-wrapper ciscospark-activity-item-avatar-wrapper avatarWrapper\"\n+ >\n+ <Connect(PresenceAvatar)\n+ avatarId=\"user-abc-123\"\n+ iconSize=\"30px\"\n+ isSelfAvatar={false}\n+ name=\"Test User\"\n+ />\n+ </div>\n+ <div\n+ className=\"ciscospark-content-container contentContainer\"\n+ >\n+ <div\n+ className=\"ciscospark-meta meta\"\n+ >\n+ <div\n+ className=\"ciscospark-display-name displayName\"\n+ title=\"Test User\"\n+ >\n+ Test User\n+ </div>\n+ <div\n+ className=\"ciscospark-published published\"\n+ >\n+ 2016-09-20T19:52:57.186Z\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-content content\"\n+ >\n+ <div>\n+ Test Content\n+ </div>\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-post-actions activityPostActions\"\n+ >\n+ <div\n+ className=\"activity-post-action activityPostAction isHighlighted isHighlighted flagActionPending\"\n+ >\n+ <ActivityPostAction\n+ iconType=\"icon-flag_12\"\n+ onClick={[Function]}\n+ title=\"Flag this message\"\n+ />\n+ </div>\n+ <div\n+ className=\"activity-post-action activityPostAction\"\n+ >\n+ <div\n+ className=\"ciscospark-action-spacer actionSpacer\"\n+ />\n+ </div>\n+ </div>\n+</div>\n+`;\n+\n+exports[`ActivityItemBase component renders properly when pending 1`] = `\n+<div\n+ className=\"activity-item activityItem activity-item-pending pending\"\n+>\n+ <div\n+ className=\"ciscospark-avatar-wrapper ciscospark-activity-item-avatar-wrapper avatarWrapper\"\n+ >\n+ <Connect(PresenceAvatar)\n+ avatarId=\"user-abc-123\"\n+ iconSize=\"30px\"\n+ isSelfAvatar={false}\n+ name=\"Test User\"\n+ />\n+ </div>\n+ <div\n+ className=\"ciscospark-content-container contentContainer\"\n+ >\n+ <div\n+ className=\"ciscospark-meta meta\"\n+ >\n+ <div\n+ className=\"ciscospark-display-name displayName\"\n+ title=\"Test User\"\n+ >\n+ Test User\n+ </div>\n+ <div\n+ className=\"ciscospark-published published\"\n+ >\n+ 2016-09-20T19:52:57.186Z\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-content content\"\n+ >\n+ <div>\n+ Test Content\n+ </div>\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-post-actions activityPostActions\"\n+ />\n+</div>\n+`;\n+\n+exports[`ActivityItemBase component renders properly when self 1`] = `\n<div\nclassName=\"activity-item activityItem\"\n>\n@@ -64,3 +362,76 @@ exports[`ActivityItemBase component renders properly 1`] = `\n</div>\n</div>\n`;\n+\n+exports[`ActivityItemBase component renders properly with error 1`] = `\n+<div\n+ className=\"activity-item activityItem\"\n+>\n+ <div\n+ className=\"ciscospark-avatar-wrapper ciscospark-activity-item-avatar-wrapper avatarWrapper\"\n+ >\n+ <Connect(PresenceAvatar)\n+ avatarId=\"user-abc-123\"\n+ iconSize=\"30px\"\n+ isSelfAvatar={false}\n+ name=\"Test User\"\n+ />\n+ </div>\n+ <div\n+ className=\"ciscospark-content-container contentContainer\"\n+ >\n+ <div\n+ className=\"ciscospark-meta meta\"\n+ >\n+ <div\n+ className=\"ciscospark-display-name displayName\"\n+ title=\"Test User\"\n+ >\n+ Test User\n+ </div>\n+ <div\n+ className=\"ciscospark-published published\"\n+ >\n+ 2016-09-20T19:52:57.186Z\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-content content\"\n+ >\n+ <div>\n+ Test Content\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-error error\"\n+ role=\"presentation\"\n+ >\n+ <button\n+ onClick={[Function]}\n+ >\n+ Unable to post. Click to retry\n+ </button>\n+ </div>\n+ </div>\n+ <div\n+ className=\"ciscospark-activity-post-actions activityPostActions\"\n+ >\n+ <div\n+ className=\"activity-post-action activityPostAction\"\n+ >\n+ <ActivityPostAction\n+ iconType=\"icon-flag_12\"\n+ onClick={[Function]}\n+ title=\"Flag this message\"\n+ />\n+ </div>\n+ <div\n+ className=\"activity-post-action activityPostAction\"\n+ >\n+ <div\n+ className=\"ciscospark-action-spacer actionSpacer\"\n+ />\n+ </div>\n+ </div>\n+</div>\n+`;\n",
"new_path": "packages/node_modules/@ciscospark/react-component-activity-item-base/src/__snapshots__/index.test.js.snap",
"old_path": "packages/node_modules/@ciscospark/react-component-activity-item-base/src/__snapshots__/index.test.js.snap"
},
{
"change_type": "MODIFY",
"diff": "@@ -19,6 +19,7 @@ const propTypes = {\nid: PropTypes.string.isRequired,\nisAdditional: PropTypes.bool,\nisFlagged: PropTypes.bool,\n+ isFlagPending: PropTypes.bool,\nisPending: PropTypes.bool,\nisSelf: PropTypes.bool,\nname: PropTypes.string,\n@@ -33,6 +34,7 @@ const defaultProps = {\nhasError: false,\nisAdditional: false,\nisFlagged: false,\n+ isFlagPending: false,\nisPending: false,\nisSelf: false,\nname: '',\n@@ -49,6 +51,7 @@ function ActivityItemBase({\nisAdditional,\nhasError,\nisFlagged,\n+ isFlagPending,\nisPending,\nisSelf,\nname,\n@@ -74,17 +77,20 @@ function ActivityItemBase({\nonActivityRetry(id);\n}\n- function getActionClassNames(highlight) {\n+ function getActionClassNames({highlight = false, flagActionPending = false} = {}) {\nconst actionClassNames = ['activity-post-action', styles.activityPostAction];\nif (highlight) {\nactionClassNames.push('isHighlighted', styles.isHighlighted);\n}\n+ if (flagActionPending) {\n+ actionClassNames.push('flagActionPending');\n+ }\nreturn actionClassNames;\n}\nif (!isPending) {\nflagAction = (\n- <div className={classNames(getActionClassNames(isFlagged))}>\n+ <div className={classNames(getActionClassNames({highlight: isFlagged, flagActionPending: isFlagPending}))}>\n<ActivityPostAction\niconType={ICON_TYPE_FLAGGED_OUTLINE}\nonClick={handleOnFlag}\n",
"new_path": "packages/node_modules/@ciscospark/react-component-activity-item-base/src/index.js",
"old_path": "packages/node_modules/@ciscospark/react-component-activity-item-base/src/index.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -6,20 +6,95 @@ import ActivityItemBase from '.';\nconst renderer = new ShallowRenderer();\ndescribe('ActivityItemBase component', () => {\n- const activity = {\n+ let props;\n+\n+ const child = <div>Test Content</div>;\n+\n+ beforeEach(() => {\n+ props = {\nactorId: 'user-abc-123',\n+ hasError: false,\nid: 'test-123-123-123-123',\n- isSelf: true,\n+ isAdditional: false,\n+ isFlagged: false,\n+ isFlagPending: false,\n+ isPending: false,\n+ isSelf: false,\nname: 'Test User',\n- timestamp: '2016-09-20T19:52:57.186Z',\n- verb: 'post'\n+ timestamp: '2016-09-20T19:52:57.186Z'\n};\n-\n- const child = <div>Test Content</div>;\n+ });\nit('renders properly', () => {\nrenderer.render(\n- <ActivityItemBase {...activity} >\n+ <ActivityItemBase {...props} >\n+ {child}\n+ </ActivityItemBase>\n+ );\n+ const component = renderer.getRenderOutput();\n+ expect(component).toMatchSnapshot();\n+ });\n+\n+ it('renders properly when self', () => {\n+ props.isSelf = true;\n+ renderer.render(\n+ <ActivityItemBase {...props} >\n+ {child}\n+ </ActivityItemBase>\n+ );\n+ const component = renderer.getRenderOutput();\n+ expect(component).toMatchSnapshot();\n+ });\n+\n+ it('renders properly when pending', () => {\n+ props.isPending = true;\n+ renderer.render(\n+ <ActivityItemBase {...props} >\n+ {child}\n+ </ActivityItemBase>\n+ );\n+ const component = renderer.getRenderOutput();\n+ expect(component).toMatchSnapshot();\n+ });\n+\n+ it('renders properly when flagged', () => {\n+ props.isFlagged = true;\n+ renderer.render(\n+ <ActivityItemBase {...props} >\n+ {child}\n+ </ActivityItemBase>\n+ );\n+ const component = renderer.getRenderOutput();\n+ expect(component).toMatchSnapshot();\n+ });\n+\n+ it('renders properly when flagged pending', () => {\n+ props.isFlagged = true;\n+ props.isFlagPending = true;\n+ renderer.render(\n+ <ActivityItemBase {...props} >\n+ {child}\n+ </ActivityItemBase>\n+ );\n+ const component = renderer.getRenderOutput();\n+ expect(component).toMatchSnapshot();\n+ });\n+\n+ it('renders properly with error', () => {\n+ props.hasError = true;\n+ renderer.render(\n+ <ActivityItemBase {...props} >\n+ {child}\n+ </ActivityItemBase>\n+ );\n+ const component = renderer.getRenderOutput();\n+ expect(component).toMatchSnapshot();\n+ });\n+\n+ it('renders properly when additional', () => {\n+ props.isAdditional = true;\n+ renderer.render(\n+ <ActivityItemBase {...props} >\n{child}\n</ActivityItemBase>\n);\n",
"new_path": "packages/node_modules/@ciscospark/react-component-activity-item-base/src/index.test.js",
"old_path": "packages/node_modules/@ciscospark/react-component-activity-item-base/src/index.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -8,6 +8,7 @@ exports[`ActivityPost post component renders properly 1`] = `\nhasError={false}\nid=\"test-123-123-123-123\"\nisAdditional={false}\n+ isFlagPending={false}\nisFlagged={false}\nisPending={false}\nisSelf={true}\n",
"new_path": "packages/node_modules/@ciscospark/react-component-activity-post/src/__snapshots__/index.test.js.snap",
"old_path": "packages/node_modules/@ciscospark/react-component-activity-post/src/__snapshots__/index.test.js.snap"
},
{
"change_type": "MODIFY",
"diff": "@@ -17,6 +17,7 @@ exports[`ActivityShareFiles post component renders properly 1`] = `\nhasError={false}\nid=\"1234-1234-1234-1234\"\nisAdditional={false}\n+ isFlagPending={false}\nisFlagged={false}\nisPending={false}\nisSelf={false}\n@@ -63,6 +64,7 @@ exports[`ActivityShareFiles post component renders properly while pending 1`] =\nhasError={false}\nid=\"1234-1234-1234-1234\"\nisAdditional={false}\n+ isFlagPending={false}\nisFlagged={false}\nisPending={true}\nisSelf={false}\n",
"new_path": "packages/node_modules/@ciscospark/react-component-activity-share-files/src/__snapshots__/index.test.js.snap",
"old_path": "packages/node_modules/@ciscospark/react-component-activity-share-files/src/__snapshots__/index.test.js.snap"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
feat(react-component-activity-item-base): add action pending class
| 1
|
feat
|
react-component-activity-item-base
|
791,723
|
13.03.2018 15:07:05
| 25,200
|
89e11256ba3b7d128d343688d801433f7f91c8be
|
core(driver): add timeout to getRequestContent
|
[
{
"change_type": "MODIFY",
"diff": "const NetworkRecorder = require('../lib/network-recorder');\nconst emulation = require('../lib/emulation');\nconst Element = require('../lib/element');\n+const LHError = require('../lib/errors');\nconst EventEmitter = require('events').EventEmitter;\nconst URL = require('../lib/url-shim');\nconst TraceParser = require('../lib/traces/trace-parser');\n@@ -714,13 +715,25 @@ class Driver {\n/**\n* Return the body of the response with the given ID.\n* @param {string} requestId\n+ * @param {number|undefined} timeout\n* @return {string}\n*/\n- getRequestContent(requestId) {\n- return this.sendCommand('Network.getResponseBody', {\n- requestId,\n+ getRequestContent(requestId, timeout = 1000) {\n+ return new Promise((resolve, reject) => {\n+ // If this takes more than 1s, reject the Promise.\n+ // Why? Encoding issues can lead to hanging getResponseBody calls: https://github.com/GoogleChrome/lighthouse/pull/4718\n+ const err = new LHError(LHError.errors.REQUEST_CONTENT_TIMEOUT);\n+ const asyncTimeout = setTimeout((_ => reject(err)), timeout);\n+\n+ this.sendCommand('Network.getResponseBody', {requestId}).then(result => {\n+ clearTimeout(asyncTimeout);\n// Ignoring result.base64Encoded, which indicates if body is already encoded\n- }).then(result => result.body);\n+ resolve(result.body);\n+ }).catch(e => {\n+ clearTimeout(asyncTimeout);\n+ reject(e);\n+ });\n+ });\n}\n/**\n",
"new_path": "lighthouse-core/gather/driver.js",
"old_path": "lighthouse-core/gather/driver.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -88,6 +88,9 @@ const ERRORS = {\nTRACING_ALREADY_STARTED: {message: strings.internalChromeError, pattern: /Tracing.*started/},\nPARSING_PROBLEM: {message: strings.internalChromeError, pattern: /Parsing problem/},\nREAD_FAILED: {message: strings.internalChromeError, pattern: /Read failed/},\n+\n+ // Protocol timeout failures\n+ REQUEST_CONTENT_TIMEOUT: {message: strings.requestContentTimeout},\n};\nObject.keys(ERRORS).forEach(code => ERRORS[code].code = code);\n",
"new_path": "lighthouse-core/lib/errors.js",
"old_path": "lighthouse-core/lib/errors.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -12,4 +12,5 @@ module.exports = {\npageLoadTookTooLong: `Your page took too long to load. Please follow the opportunities in the report to reduce your page load time, and then try re-running Lighthouse.`,\npageLoadFailed: `Your page failed to load. Verify that the URL is valid and re-run Lighthouse.`,\ninternalChromeError: `An internal Chrome error occurred. Please restart Chrome and try re-running Lighthouse.`,\n+ requestContentTimeout: 'Fetching resource content has exceeded the allotted time',\n};\n",
"new_path": "lighthouse-core/lib/strings.js",
"old_path": "lighthouse-core/lib/strings.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -17,6 +17,7 @@ const connection = new Connection();\nconst driverStub = new Driver(connection);\nconst redirectDevtoolsLog = require('../fixtures/wikipedia-redirect.devtoolslog.json');\n+const MAX_WAIT_FOR_PROTOCOL = 20;\nfunction createOnceStub(events) {\nreturn (eventName, cb) => {\n@@ -75,6 +76,8 @@ connection.sendCommand = function(command, params) {\nreturn Promise.resolve({frameTree: {frame: {id: 1}}});\ncase 'Page.createIsolatedWorld':\nreturn Promise.resolve({executionContextId: 1});\n+ case 'Network.getResponseBody':\n+ return new Promise(res => setTimeout(res, MAX_WAIT_FOR_PROTOCOL + 20));\ncase 'Page.enable':\ncase 'Tracing.start':\ncase 'ServiceWorker.enable':\n@@ -138,6 +141,14 @@ describe('Browser Driver', () => {\n});\n});\n+ it('throws if getRequestContent takes too long', () => {\n+ return driverStub.getRequestContent(0, MAX_WAIT_FOR_PROTOCOL).then(_ => {\n+ assert.ok(false, 'long-running getRequestContent supposed to reject');\n+ }, e => {\n+ assert.equal(e.code, 'REQUEST_CONTENT_TIMEOUT');\n+ });\n+ });\n+\nit('evaluates an expression', () => {\nreturn driverStub.evaluateAsync('120 + 3').then(value => {\nassert.deepEqual(value, 123);\n",
"new_path": "lighthouse-core/test/gather/driver-test.js",
"old_path": "lighthouse-core/test/gather/driver-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(driver): add timeout to getRequestContent (#4718)
| 1
|
core
|
driver
|
730,429
|
13.03.2018 15:16:52
| 14,400
|
1ebf5fa80a38bf717515dbe5b1c16980e7fc73c9
|
feat(react-component-activity-list): add support for isFlagPending
|
[
{
"change_type": "MODIFY",
"diff": "@@ -65,7 +65,7 @@ function ActivityList(props) {\n}\ncase ITEM_TYPE_ACTIVITY: {\nconst {\n- activity, currentUser, hasError, isPending, isAdditional, isFlagged, isSelf, name\n+ activity, currentUser, hasError, isPending, isAdditional, isFlagged, isFlagPending, isSelf, name\n} = visibleActivity;\nreturn (\n@@ -78,6 +78,7 @@ function ActivityList(props) {\nid={activity.id}\nisAdditional={isAdditional}\nisFlagged={isFlagged}\n+ isFlagPending={isFlagPending}\nisPending={isPending}\nisSelf={isSelf}\nkey={activity.id}\n",
"new_path": "packages/node_modules/@ciscospark/react-component-activity-list/src/index.js",
"old_path": "packages/node_modules/@ciscospark/react-component-activity-list/src/index.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
feat(react-component-activity-list): add support for isFlagPending
| 1
|
feat
|
react-component-activity-list
|
730,429
|
13.03.2018 15:17:21
| 14,400
|
b4dec3ba98530f1a8f0891608080a6045e45ecfc
|
feat(react-container-activity-list): add support for isFlagPending
|
[
{
"change_type": "MODIFY",
"diff": "@@ -21,6 +21,7 @@ exports[`ActivityList component renders properly 1`] = `\nhasError={undefined}\nid=\"test-123-123-123-123\"\nisAdditional={false}\n+ isFlagPending={false}\nisFlagged={false}\nisPending={false}\nisSelf={true}\n@@ -48,6 +49,7 @@ exports[`ActivityList component renders properly 1`] = `\nhasError={undefined}\nid=\"test-456-123-456-123\"\nisAdditional={true}\n+ isFlagPending={undefined}\nisFlagged={false}\nisPending={false}\nisSelf={true}\n@@ -75,6 +77,7 @@ exports[`ActivityList component renders properly 1`] = `\nhasError={undefined}\nid=\"test-789-123-789-123\"\nisAdditional={false}\n+ isFlagPending={false}\nisFlagged={true}\nisPending={true}\nisSelf={false}\n",
"new_path": "packages/node_modules/@ciscospark/react-component-activity-list/src/__snapshots__/index.test.js.snap",
"old_path": "packages/node_modules/@ciscospark/react-component-activity-list/src/__snapshots__/index.test.js.snap"
},
{
"change_type": "MODIFY",
"diff": "@@ -21,6 +21,7 @@ describe('ActivityList component', () => {\n},\nisAdditional: false,\nisFlagged: false,\n+ isFlagPending: false,\nisPending: false,\nisSelf: true,\nname: 'Test User 1',\n@@ -59,6 +60,7 @@ describe('ActivityList component', () => {\n},\nisAdditional: false,\nisFlagged: true,\n+ isFlagPending: false,\nisPending: true,\nisSelf: false,\nname: 'Test User 3',\n",
"new_path": "packages/node_modules/@ciscospark/react-component-activity-list/src/index.test.js",
"old_path": "packages/node_modules/@ciscospark/react-component-activity-list/src/index.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -142,7 +142,8 @@ export const getActivityList = createSelector(\nlastActorId = activity.actor.id;\nlastVerb = activity.verb;\n- const isFlagged = !!flags.count() && flags.some((flag) => flag.get('activityUrl') === activity.url);\n+ const isFlagged = !!flags.count() && flags.has(activity.url);\n+ const isFlagPending = isFlagged && flags.getIn([activity.url, 'isInFlight']);\nlet formattedActivity = activity;\nif (activity.verb === 'post') {\n@@ -164,6 +165,7 @@ export const getActivityList = createSelector(\navatarUrl: avatars.get(activity.actor.id),\nisAdditional,\nisFlagged,\n+ isFlagPending,\nisSelf: currentUser.id === activity.actor.id,\nname\n};\n@@ -188,6 +190,7 @@ export const getActivityList = createSelector(\navatarUrl: avatars.get(currentUser.id),\nisAdditional: false,\nisFlagged: false,\n+ isFlagPending: false,\nisSelf: true,\nisPending: true\n});\n@@ -203,6 +206,7 @@ export const getActivityList = createSelector(\nisAdditional: false,\nhasError: true,\nisFlagged: false,\n+ isFlagPending: false,\nisSelf: true,\nisPending: true\n});\n",
"new_path": "packages/node_modules/@ciscospark/react-container-activity-list/src/selectors.js",
"old_path": "packages/node_modules/@ciscospark/react-container-activity-list/src/selectors.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
feat(react-container-activity-list): add support for isFlagPending
| 1
|
feat
|
react-container-activity-list
|
217,922
|
13.03.2018 16:46:59
| -3,600
|
0fa9d222aaf80e05c4868220e770521780819b7f
|
feat: mark workshops as favourite
closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -3,6 +3,7 @@ import {Injectable} from '@angular/core';\nimport {NgSerializerService} from '@kaiu/ng-serializer';\nimport {Observable} from 'rxjs/Observable';\nimport {ListStore} from './storage/list/list-store';\n+import {Workshop} from '../../model/other/workshop';\n@Injectable()\nexport class ListService {\n@@ -93,6 +94,15 @@ export class ListService {\nreturn this.store.deleteByAuthor(uid);\n}\n+ /**\n+ * Fetches all lists of a given workshop.\n+ * @param {Workshop} workshop\n+ * @returns {Observable<List[]>}\n+ */\n+ public fetchWorkshop(workshop: Workshop): Observable<List[]> {\n+ return Observable.combineLatest(workshop.listIds.map(listId => this.get(listId)));\n+ }\n+\npublic add(list: List): Observable<string> {\nif (list.authorId === undefined) {\nthrow new Error('Tried to persist a list with no author ID');\n",
"new_path": "src/app/core/database/list.service.ts",
"old_path": "src/app/core/database/list.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -27,6 +27,10 @@ export class UserService extends FirebaseStorage<AppUser> {\nsuper(database, serializer, diffService, zone);\n}\n+ public set(uid: string, user: AppUser): Observable<void> {\n+ return super.set(uid, user).do(() => this.reload());\n+ }\n+\n/**\n* Gets user ingame informations.\n* @returns {Observable<any>}\n@@ -64,7 +68,9 @@ export class UserService extends FirebaseStorage<AppUser> {\nreturn Observable.of({name: 'Anonymous', anonymous: true});\n}\nif (user === null || user.isAnonymous) {\n+ return this.get(user.uid).catch(() => {\nreturn Observable.of({$key: user.uid, name: 'Anonymous', anonymous: true});\n+ });\n} else {\nreturn this.get(user.uid).map(u => {\nu.providerId = user.providerId;\n",
"new_path": "src/app/core/database/user.service.ts",
"old_path": "src/app/core/database/user.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -7,6 +7,7 @@ export class AppUser extends DataModel {\nlodestoneId?: number;\navatar?: string;\nfavorites?: string[];\n+ favoriteWorkshops?: string[];\npatron?: boolean;\nanonymous?: boolean;\nproviderId?: string;\n",
"new_path": "src/app/model/list/app-user.ts",
"old_path": "src/app/model/list/app-user.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -5,7 +5,7 @@ import {CoreModule} from '../../core/core.module';\nimport {RouterModule, Routes} from '@angular/router';\nimport {CommonComponentsModule} from '../../modules/common-components/common-components.module';\nimport {MaintenanceGuard} from '../maintenance/maintenance.guard';\n-import {MatListModule} from '@angular/material';\n+import {MatButtonModule, MatIconModule, MatListModule} from '@angular/material';\nconst routes: Routes = [\n{\n@@ -22,6 +22,8 @@ const routes: Routes = [\nRouterModule.forChild(routes),\nMatListModule,\n+ MatIconModule,\n+ MatButtonModule,\nCoreModule,\nCommonComponentsModule,\n",
"new_path": "src/app/pages/favorites/favorites.module.ts",
"old_path": "src/app/pages/favorites/favorites.module.ts"
},
{
"change_type": "MODIFY",
"diff": "<h2>{{'Favorites' | translate}}</h2>\n-<div *ngIf=\"(favorites | async)?.length === 0\" class=\"not-found\">\n+<div *ngIf=\"(favorites | async)?.length === 0 && (favorites | async) === null ||\n+(favoriteWorkshops | async)?.length === 0 || (favoriteWorkshops | async) === null\" class=\"not-found\">\n<h3>{{\"No_favorites\" | translate}}</h3>\n</div>\n-<h3 *ngIf=\"favorites | async\">{{'Lists' | translate}}</h3>\n+<div *ngIf=\"(favorites | async) !== null\">\n+ <h3>{{'Lists' | translate}}</h3>\n<mat-divider class=\"divider\"></mat-divider>\n<app-list-panel *ngFor=\"let list of favorites | async\"\n[list]=\"list\"\n[expanded]=\"false\"\n[readonly]=\"true\"\n[authorUid]=\"list.authorUid\"></app-list-panel>\n+</div>\n+\n+<div *ngIf=\"favoriteWorkshops | async as workshops\">\n+ <h3>{{'WORKSHOP.Workshops' | translate}}</h3>\n+ <mat-divider></mat-divider>\n+ <mat-list>\n+ <mat-list-item *ngFor=\"let workshop of workshops\" class=\"mat-elevation-z5\">\n+ <mat-icon mat-list-icon>folder_open</mat-icon>\n+ <h4 mat-line>{{workshop.name}}</h4>\n+ <div class=\"spacer\"></div>\n+ <button mat-icon-button routerLink=\"/workshop/{{workshop.$key}}\">\n+ <mat-icon>playlist_play</mat-icon>\n+ </button>\n+ </mat-list-item>\n+ </mat-list>\n+</div>\n",
"new_path": "src/app/pages/favorites/favorites/favorites.component.html",
"old_path": "src/app/pages/favorites/favorites/favorites.component.html"
},
{
"change_type": "MODIFY",
"diff": "}\n}\n+.spacer {\n+ flex: 1 1 auto;\n+}\n+\n.divider {\nmargin-bottom: 10px;\n}\n",
"new_path": "src/app/pages/favorites/favorites/favorites.component.scss",
"old_path": "src/app/pages/favorites/favorites/favorites.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -4,6 +4,8 @@ import {List} from '../../../model/list/list';\nimport {Observable} from 'rxjs/Observable';\nimport {ListService} from '../../../core/database/list.service';\nimport {ComponentWithSubscriptions} from '../../../core/component/component-with-subscriptions';\n+import {Workshop} from '../../../model/other/workshop';\n+import {WorkshopService} from '../../../core/database/workshop.service';\n@Component({\nselector: 'app-favorites',\n@@ -14,7 +16,9 @@ export class FavoritesComponent extends ComponentWithSubscriptions {\nfavorites: Observable<List[]>;\n- constructor(private userService: UserService, private listService: ListService) {\n+ favoriteWorkshops: Observable<Workshop[]>;\n+\n+ constructor(private userService: UserService, private listService: ListService, private workshopService: WorkshopService) {\nsuper();\nthis.favorites = this.userService.getUserData()\n.switchMap(userData => {\n@@ -34,5 +38,10 @@ export class FavoritesComponent extends ComponentWithSubscriptions {\n})\n// We need to remove null rows in order to keep the display safe.\n.map(favorites => favorites.filter(row => row !== null));\n+ this.favoriteWorkshops = this.userService.getUserData().switchMap(userData => {\n+ return Observable.combineLatest((userData.favoriteWorkshops || []).map(favWs => this.workshopService.get(favWs).catch(() => {\n+ return Observable.of(null);\n+ })));\n+ });\n}\n}\n",
"new_path": "src/app/pages/favorites/favorites/favorites.component.ts",
"old_path": "src/app/pages/favorites/favorites/favorites.component.ts"
},
{
"change_type": "MODIFY",
"diff": "import {NgModule} from '@angular/core';\nimport {CommonModule} from '@angular/common';\n-import {MatButtonModule, MatCardModule, MatIconModule} from '@angular/material';\n+import {MatButtonModule, MatCardModule, MatIconModule, MatTooltipModule} from '@angular/material';\nimport {CoreModule} from '../../core/core.module';\nimport {RouterModule} from '@angular/router';\nimport {CommonComponentsModule} from '../../modules/common-components/common-components.module';\n@@ -19,6 +19,7 @@ const routes = [{\nMatIconModule,\nMatButtonModule,\nMatCardModule,\n+ MatTooltipModule,\nCoreModule,\nCommonComponentsModule,\n",
"new_path": "src/app/pages/workshop/workshop.module.ts",
"old_path": "src/app/pages/workshop/workshop.module.ts"
},
{
"change_type": "MODIFY",
"diff": "<mat-card *ngIf=\"workshop | async as workshopData\">\n- <mat-card-header *ngIf=\"author | async as authorCharacter\">\n- <img src=\"{{authorCharacter.avatar}}\" alt=\"\" mat-card-avatar routerLink=\"/profile/{{workshopData.authorId}}\">\n+ <mat-card-header>\n+ <img *ngIf=\"author | async as authorCharacter\" src=\"{{authorCharacter.avatar}}\" alt=\"\" mat-card-avatar\n+ routerLink=\"/profile/{{workshopData.authorId}}\">\n<mat-card-title>{{workshopData.name}}</mat-card-title>\n- <mat-card-subtitle>{{'WORKSHOP.Created_by' | translate : {name: authorCharacter.name} }}</mat-card-subtitle>\n+ <mat-card-subtitle *ngIf=\"author | async as authorCharacter\">{{'WORKSHOP.Created_by' | translate : {name: authorCharacter.name} }}</mat-card-subtitle>\n+ <button mat-mini-fab color=\"accent\"\n+ class=\"favorite-fab\"\n+ matTooltip=\"{{'Favorite' | translate}}\"\n+ (click)=\"toggleFavorite(workshopData)\">\n+ <mat-icon *ngIf=\"!(favorite | async)\">favorite_border</mat-icon>\n+ <mat-icon *ngIf=\"favorite | async\">favorite</mat-icon>\n+ </button>\n</mat-card-header>\n<mat-card-content *ngIf=\"lists | async as listsData\">\n<div class=\"row\" *ngFor=\"let list of listsData; trackBy: trackByListsFn; let odd = odd\">\n",
"new_path": "src/app/pages/workshop/workshop/workshop.component.html",
"old_path": "src/app/pages/workshop/workshop/workshop.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -23,12 +23,36 @@ export class WorkshopComponent implements OnInit {\nauthor: Observable<any>;\n+ favorite: Observable<boolean>;\n+\nconstructor(private route: ActivatedRoute, private workshopService: WorkshopService, private listService: ListService,\nprivate userService: UserService) {\n}\n+ toggleFavorite(workshop: Workshop): void {\n+ this.userService.getUserData().first()\n+ .map(appUser => {\n+ if (appUser.favoriteWorkshops === undefined) {\n+ appUser.favoriteWorkshops = [];\n+ }\n+ if (appUser.favoriteWorkshops.indexOf(workshop.$key) > -1) {\n+ appUser.favoriteWorkshops = appUser.favoriteWorkshops.filter(ws => ws !== workshop.$key);\n+ } else {\n+ appUser.favoriteWorkshops.push(workshop.$key);\n+ }\n+ return appUser;\n+ })\n+ .switchMap(appUser => this.userService.set(appUser.$key, appUser))\n+ .subscribe();\n+ }\n+\nngOnInit() {\nthis.workshop = this.route.params.mergeMap(params => this.workshopService.get(params.id));\n+ this.favorite = this.workshop.switchMap(workshop => {\n+ return this.userService.getUserData().map(user => {\n+ return (user.favoriteWorkshops || []).indexOf(workshop.$key) > -1;\n+ });\n+ });\nthis.lists = this.workshop\n.mergeMap(workshop =>\nObservable.combineLatest(...workshop.listIds\n@@ -39,6 +63,7 @@ export class WorkshopComponent implements OnInit {\n)\n).map(lists => lists.filter(l => l !== null));\nthis.author = this.workshop.mergeMap(workshop => this.userService.getCharacter(workshop.authorId))\n+ .catch(() => Observable.of(null));\n}\ntrackByListsFn(index: number, item: List) {\n",
"new_path": "src/app/pages/workshop/workshop/workshop.component.ts",
"old_path": "src/app/pages/workshop/workshop/workshop.component.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
feat: mark workshops as favourite
closes #255
| 1
|
feat
| null |
815,746
|
13.03.2018 18:00:14
| -7,200
|
8edea5aac2be92093e3976962a87057d76b58cf2
|
fix: always clear selected value on writeValue
|
[
{
"change_type": "MODIFY",
"diff": "@@ -247,10 +247,10 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\nwriteValue(value: any | any[]): void {\n+ this.itemsList.clearSelected();\nif (value === undefined) {\nreturn;\n}\n- this.itemsList.clearSelected();\nthis._validateWriteValue(value);\nthis._handleWriteValue(value);\nthis.detectChanges();\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: always clear selected value on writeValue (#349)
| 1
|
fix
| null |
217,922
|
14.03.2018 00:48:53
| -3,600
|
0ad5729f8941b66e6316a439fc7e5b16b0481faf
|
fix: progression kept in list clones
|
[
{
"change_type": "MODIFY",
"diff": "@@ -62,9 +62,14 @@ export class List extends DataModel {\nga('send', 'event', 'List', 'creation');\nga('send', 'event', 'List', 'clone');\nthis.forks++;\n+ clone.reset();\nreturn clone;\n}\n+ public reset(): void {\n+ this.recipes.forEach(recipe => this.resetDone(recipe));\n+ }\n+\n/**\n* Iterates on others, gathers and preCrafts.\n* @param {(arg: ListRow) => void} method\n",
"new_path": "src/app/model/list/list.ts",
"old_path": "src/app/model/list/list.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
fix: progression kept in list clones
| 1
|
fix
| null |
807,892
|
14.03.2018 03:14:57
| -39,600
|
cef0a69ba199d9476169f718ebb744441cb6a148
|
feat: Check for upstream changes before attempting to publish
|
[
{
"change_type": "MODIFY",
"diff": "@@ -84,6 +84,18 @@ class PublishCommand extends Command {\n`\n);\n}\n+\n+ if (GitUtilities.isBehindUpstream(this.gitRemote, this.execOpts)) {\n+ const remote = `${this.gitRemote}/${currentBranch} `;\n+ throw new ValidationError(\n+ \"EBEHIND\",\n+ dedent`\n+ Local branch '${currentBranch}' is behind remote upstream ${remote}\n+ Please merge in remote changes into '${currentBranch}'.\n+ Remote changes can be fetched and merged with git pull\n+ `\n+ );\n+ }\n}\nthis.conf = npmConf(this.options);\n",
"new_path": "commands/publish/index.js",
"old_path": "commands/publish/index.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -347,4 +347,48 @@ describe(\"GitUtilities\", () => {\nexpect(GitUtilities.hasCommit()).toBe(false);\n});\n});\n+\n+ describe(\".isBehindUpstream()\", () => {\n+ const aheadBehindCountOriginal = GitUtilities.aheadBehindCount;\n+ afterEach(() => {\n+ GitUtilities.aheadBehindCount = aheadBehindCountOriginal;\n+ });\n+\n+ it(\"returns true when behind upstream\", () => {\n+ const opts = { cwd: \"test\" };\n+ GitUtilities.aheadBehindCount = jest.fn(() => ({ ahead: 0, behind: 1 }));\n+ expect(GitUtilities.isBehindUpstream(\"origin\", opts)).toBe(true);\n+ });\n+\n+ it(\"returns false when not behind upstream\", () => {\n+ const opts = { cwd: \"test\" };\n+ GitUtilities.aheadBehindCount = jest.fn(() => ({ ahead: 0, behind: 0 }));\n+ expect(GitUtilities.isBehindUpstream(\"origin\", opts)).toBe(false);\n+ });\n+ });\n+\n+ describe(\".aheadBehindCount()\", () => {\n+ const getCurrentBranchOriginal = GitUtilities.getCurrentBranch;\n+ afterEach(() => {\n+ GitUtilities.getCurrentBranch = getCurrentBranchOriginal;\n+ });\n+\n+ it(\"returns the number of commits the local repo is behind upstream\", () => {\n+ const opts = { cwd: \"test\" };\n+ GitUtilities.getCurrentBranch = jest.fn(() => \"master\");\n+ ChildProcessUtilities.execSync.mockReturnValueOnce(\"5\\t0\");\n+\n+ const aheadBehindCount = GitUtilities.aheadBehindCount(\"origin\", opts);\n+ expect(aheadBehindCount.behind).toBe(5);\n+ });\n+\n+ it(\"returns the number of commits the local repo is ahead upstream\", () => {\n+ const opts = { cwd: \"test\" };\n+ GitUtilities.getCurrentBranch = jest.fn(() => \"master\");\n+ ChildProcessUtilities.execSync.mockReturnValueOnce(\"0\\t2\");\n+\n+ const aheadBehindCount = GitUtilities.aheadBehindCount(\"origin\", opts);\n+ expect(aheadBehindCount.ahead).toBe(2);\n+ });\n+ });\n});\n",
"new_path": "core/git-utils/__tests__/git-utils.test.js",
"old_path": "core/git-utils/__tests__/git-utils.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -209,6 +209,42 @@ function hasCommit(opts) {\nreturn retVal;\n}\n+function fetchGitRemote(opts) {\n+ log.silly(\"fetchGitRemote\");\n+ ChildProcessUtilities.execSync(\"git\", [\"remote\", \"update\"], opts);\n+}\n+\n+function isBehindUpstream(gitRemote, opts) {\n+ log.silly(\"isBehindUpstream\");\n+ exports.fetchGitRemote(opts);\n+\n+ const status = exports.aheadBehindCount(gitRemote, opts);\n+ const behind = status.behind >= 1;\n+\n+ log.verbose(\"isBehindUpstream\", behind);\n+ return behind;\n+}\n+\n+function aheadBehindCount(gitRemote, opts) {\n+ const branchName = exports.getCurrentBranch(opts);\n+ const branchComparator = `${gitRemote}/${branchName}...${branchName}`;\n+ const rawAheadBehind = ChildProcessUtilities.execSync(\n+ \"git\",\n+ [\"rev-list\", \"--left-right\", \"--count\", branchComparator],\n+ opts\n+ );\n+\n+ const aheadBehind = rawAheadBehind.split(\"\\t\");\n+ const behind = parseInt(aheadBehind[0], 10);\n+ const ahead = parseInt(aheadBehind[1], 10);\n+\n+ log.silly(\n+ \"aheadBehindCount\",\n+ `behind ${gitRemote}/${branchName} by ${behind} commits; ${branchName} is ahead by ${ahead} commits`\n+ );\n+ return { ahead, behind };\n+}\n+\nexports.isDetachedHead = isDetachedHead;\nexports.isInitialized = isInitialized;\nexports.addFiles = addFiles;\n@@ -229,3 +265,6 @@ exports.getShortSHA = getShortSHA;\nexports.checkoutChanges = checkoutChanges;\nexports.init = init;\nexports.hasCommit = hasCommit;\n+exports.fetchGitRemote = fetchGitRemote;\n+exports.isBehindUpstream = isBehindUpstream;\n+exports.aheadBehindCount = aheadBehindCount;\n",
"new_path": "core/git-utils/index.js",
"old_path": "core/git-utils/index.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -8,6 +8,7 @@ const writeJsonFile = require(\"write-json-file\");\nconst loadJsonFile = require(\"load-json-file\");\nconst path = require(\"path\");\nconst os = require(\"os\");\n+const tempy = require(\"tempy\");\nconst cliRunner = require(\"@lerna-test/cli-runner\");\nconst gitAdd = require(\"@lerna-test/git-add\");\n@@ -169,4 +170,18 @@ describe(\"lerna publish\", () => {\nconst { stdout } = await cliRunner(cwd)(...args);\nexpect(normalizeTestRoot(cwd)(stdout)).toMatchSnapshot();\n});\n+\n+ test(\"exits with EBEHIND when behind upstream remote\", async () => {\n+ const { cwd, repository } = await cloneFixture(\"normal\");\n+ const cloneDir = tempy.directory();\n+\n+ // simulate upstream change from another clone\n+ await execa(\"git\", [\"clone\", repository, cloneDir]);\n+ await fs.outputFile(path.join(cloneDir, \"README.md\"), \"upstream change\");\n+ await gitAdd(cloneDir, \"-A\");\n+ await gitCommit(cloneDir, \"upstream change\");\n+ await execa(\"git\", [\"push\", \"origin\", \"master\"], { cwd: cloneDir });\n+\n+ await expect(cliRunner(cwd)(\"publish\")).rejects.toThrowError(/EBEHIND/);\n+ });\n});\n",
"new_path": "integration/lerna-publish.test.js",
"old_path": "integration/lerna-publish.test.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
feat: Check for upstream changes before attempting to publish (#1317)
| 1
|
feat
| null |
807,849
|
14.03.2018 10:21:59
| 25,200
|
ff349e7b7827f940b6b01533f9041e360b4a1c9c
|
refactor(git-utils): omit git diff location filter when identical to cwd
|
[
{
"change_type": "MODIFY",
"diff": "@@ -260,19 +260,12 @@ describe(\"GitUtilities\", () => {\n);\n});\n- it(\"returns list of files changed since commit at location when location equals cwd\", () => {\n- const cwd = process.cwd();\n- const opts = { cwd };\n- const testLocation = cwd;\n+ it(\"omits location filter when location is current working directory\", () => {\n+ const opts = { cwd: process.cwd() };\n- ChildProcessUtilities.execSync.mockReturnValueOnce(\"files\");\n+ GitUtilities.diffSinceIn(\"v2.0.0\", opts.cwd, opts);\n- expect(GitUtilities.diffSinceIn(\"v1.0.0\", testLocation, opts)).toBe(\"files\");\n- expect(ChildProcessUtilities.execSync).lastCalledWith(\n- \"git\",\n- [\"diff\", \"--name-only\", \"v1.0.0\", \"--\", \".\"],\n- opts\n- );\n+ expect(ChildProcessUtilities.execSync).lastCalledWith(\"git\", [\"diff\", \"--name-only\", \"v2.0.0\"], opts);\n});\n});\n",
"new_path": "core/git-utils/__tests__/git-utils.test.js",
"old_path": "core/git-utils/__tests__/git-utils.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -134,17 +134,17 @@ function describeTag(ref, opts) {\n}\nfunction diffSinceIn(committish, location, opts) {\n- const relativePath = path.relative(opts.cwd, location);\n- const nonEmptyRelativePath = relativePath === \"\" ? \".\" : relativePath;\n- const formattedLocation = slash(nonEmptyRelativePath);\n+ const args = [\"diff\", \"--name-only\", committish];\n+ const formattedLocation = slash(path.relative(opts.cwd, location));\n+\n+ if (formattedLocation) {\n+ // avoid same-directory path.relative() === \"\"\n+ args.push(\"--\", formattedLocation);\n+ }\nlog.silly(\"diffSinceIn\", committish, formattedLocation);\n- const diff = ChildProcessUtilities.execSync(\n- \"git\",\n- [\"diff\", \"--name-only\", committish, \"--\", formattedLocation],\n- opts\n- );\n+ const diff = ChildProcessUtilities.execSync(\"git\", args, opts);\nlog.silly(\"diff\", diff);\nreturn diff;\n",
"new_path": "core/git-utils/index.js",
"old_path": "core/git-utils/index.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
refactor(git-utils): omit git diff location filter when identical to cwd
| 1
|
refactor
|
git-utils
|
807,849
|
14.03.2018 10:50:53
| 25,200
|
81556d054f9908d0b970703e0a6016868d7f0c33
|
fix: fs-extra dependency is a caret range, not exact
|
[
{
"change_type": "MODIFY",
"diff": "\"dependencies\": {\n\"@lerna/command\": \"file:../../core/command\",\n\"@lerna/git-utils\": \"file:../../core/git-utils\",\n- \"fs-extra\": \"5.0.0\",\n+ \"fs-extra\": \"^5.0.0\",\n\"write-json-file\": \"^2.3.0\",\n\"write-pkg\": \"^3.1.0\"\n}\n",
"new_path": "commands/init/package.json",
"old_path": "commands/init/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"conventional-changelog-core\": \"^2.0.5\",\n\"conventional-recommended-bump\": \"^2.0.6\",\n\"dedent\": \"^0.7.0\",\n- \"fs-extra\": \"5.0.0\",\n+ \"fs-extra\": \"^5.0.0\",\n\"get-stream\": \"^3.0.0\",\n\"npm-package-arg\": \"^6.0.0\",\n\"npmlog\": \"^4.1.2\",\n",
"new_path": "core/conventional-commits/package.json",
"old_path": "core/conventional-commits/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"dependencies\": {\n\"@lerna/child-process\": \"file:../../core/child-process\",\n\"@lerna/get-npm-exec-opts\": \"file:../get-npm-exec-opts\",\n- \"fs-extra\": \"5.0.0\",\n+ \"fs-extra\": \"^5.0.0\",\n\"npm-package-arg\": \"^6.0.0\",\n\"npmlog\": \"^4.1.2\",\n\"signal-exit\": \"^3.0.2\",\n",
"new_path": "utils/npm-install/package.json",
"old_path": "utils/npm-install/package.json"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
fix: fs-extra dependency is a caret range, not exact
| 1
|
fix
| null |
730,429
|
14.03.2018 10:51:00
| 14,400
|
5180bf09382dbc398bc5f617a142bdc1ff6f0658
|
test(journeys): add pending flag check
|
[
{
"change_type": "MODIFY",
"diff": "@@ -14,6 +14,7 @@ export const elements = {\ndeleteMessageButton: 'button[aria-label=\"Delete this message\"]',\nflagButton: 'button[aria-label=\"Flag this message\"]',\nhighlighted: '.isHighlighted',\n+ pendingAction: '.flagActionPending',\npendingActivity: '.activity-item-pending',\ninputFile: '.ciscospark-file-input',\nmodalWindow: '.ciscospark-dialogue-modal',\n@@ -103,26 +104,28 @@ export function flagMessage(testObject, messageToFlag) {\nmoveMouse(testObject.browser, elements.lastActivityText);\ntestObject.browser.waitUntil(() =>\ntestObject.browser\n- .element(elements.lastActivity)\n- .element(elements.flagButton)\n+ .element(`${elements.lastActivity} ${elements.flagButton}`)\n.isVisible(),\n'flag button is not visible');\ntestObject.browser\n- .element(elements.lastActivity)\n- .element(elements.flagButton)\n+ .element(`${elements.lastActivity} ${elements.flagButton}`)\n.click();\n+ // Flag has a pending class while it waits for server upload\n+ testObject.browser.waitUntil(() => testObject.browser\n+ .element(`${elements.lastActivity} ${elements.highlighted}${elements.pendingAction} ${elements.flagButton}`)\n+ .isVisible(), 1500, 'flag button did not highlight with pending state');\n+\n// Verify it is highlighted, showing it was flagged\ntestObject.browser.waitUntil(() => testObject.browser\n- .element(elements.lastActivity)\n- .element(elements.highlighted)\n- .element(elements.flagButton)\n- .isVisible(), 'flag button did not highlight');\n-\n- // Since we automatically activate the flag icon before confirming it on the server,\n- // we need to wait a certain timeframe to allow server to recognize flag\n- testObject.browser.pause(2500);\n+ .element(`${elements.lastActivity} ${elements.highlighted} ${elements.flagButton}`)\n+ .isVisible(), 1500, 'flag button did not highlight');\n+\n+ // Remove pending flag\n+ testObject.browser.waitUntil(() => !testObject.browser\n+ .element(`${elements.lastActivity} ${elements.highlighted}${elements.pendingAction} ${elements.flagButton}`)\n+ .isVisible(), 7500, 'flag button did not remove pending state');\n}\n/**\n@@ -137,19 +140,15 @@ export function removeFlagMessage(testObject, messageToUnflag) {\ntestObject.browser.element(elements.lastActivityText).getText() === messageToUnflag, 'message was not found');\ntestObject.browser.waitUntil(() => testObject.browser\n- .element(elements.lastActivity)\n- .element(elements.highlighted)\n- .element(elements.flagButton)\n+ .element(`${elements.lastActivity} ${elements.highlighted} ${elements.flagButton}`)\n.isVisible(), 'message was not flagged');\ntestObject.browser\n- .element(elements.lastActivity)\n- .element(elements.flagButton)\n+ .element(`${elements.lastActivity} ${elements.flagButton}`)\n.click();\ntestObject.browser.waitUntil(() => testObject.browser\n- .element(elements.lastActivity)\n- .element(elements.highlighted)\n+ .element(`${elements.lastActivity} ${elements.highlighted}`)\n.isVisible() === false, 'message was still flagged');\n}\n",
"new_path": "test/journeys/lib/test-helpers/space-widget/messaging.js",
"old_path": "test/journeys/lib/test-helpers/space-widget/messaging.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
test(journeys): add pending flag check
| 1
|
test
|
journeys
|
730,429
|
14.03.2018 11:21:20
| 14,400
|
cf8ba604e9ef79400577f6bd4256e4bf0f9aba7e
|
chore(journeys): add better error messaging
|
[
{
"change_type": "MODIFY",
"diff": "@@ -106,7 +106,7 @@ export function flagMessage(testObject, messageToFlag) {\ntestObject.browser\n.element(`${elements.lastActivity} ${elements.flagButton}`)\n.isVisible(),\n- 'flag button is not visible');\n+ 1500, 'flag button is not visible when hovering');\ntestObject.browser\n.element(`${elements.lastActivity} ${elements.flagButton}`)\n@@ -123,9 +123,9 @@ export function flagMessage(testObject, messageToFlag) {\n.isVisible(), 1500, 'flag button did not highlight');\n// Remove pending flag\n- testObject.browser.waitUntil(() => !testObject.browser\n+ testObject.browser.waitUntil(() => testObject.browser\n.element(`${elements.lastActivity} ${elements.highlighted}${elements.pendingAction} ${elements.flagButton}`)\n- .isVisible(), 7500, 'flag button did not remove pending state');\n+ .isVisible() === false, 7500, 'flag button did not remove pending state');\n}\n/**\n@@ -137,11 +137,11 @@ export function flagMessage(testObject, messageToFlag) {\nexport function removeFlagMessage(testObject, messageToUnflag) {\ntestObject.browser.waitForExist(elements.pendingActivity, 15000, true);\ntestObject.browser.waitUntil(() =>\n- testObject.browser.element(elements.lastActivityText).getText() === messageToUnflag, 'message was not found');\n+ testObject.browser.element(elements.lastActivityText).getText() === messageToUnflag, 1500, 'message was not found');\ntestObject.browser.waitUntil(() => testObject.browser\n.element(`${elements.lastActivity} ${elements.highlighted} ${elements.flagButton}`)\n- .isVisible(), 'message was not flagged');\n+ .isVisible(), 1500, 'message was not flagged');\ntestObject.browser\n.element(`${elements.lastActivity} ${elements.flagButton}`)\n@@ -149,7 +149,7 @@ export function removeFlagMessage(testObject, messageToUnflag) {\ntestObject.browser.waitUntil(() => testObject.browser\n.element(`${elements.lastActivity} ${elements.highlighted}`)\n- .isVisible() === false, 'message was still flagged');\n+ .isVisible() === false, 3500, 'message was still flagged');\n}\n/**\n@@ -184,7 +184,7 @@ export function deleteMessage(testObject, messageToDelete) {\ntestObject.browser\n.element(`${elements.lastActivity} ${elements.deleteMessageButton}`)\n.isVisible(),\n- 'delete button is not visible');\n+ 1500, 'delete button is not visible when hovering');\ntestObject.browser\n.element(`${elements.lastActivity} ${elements.deleteMessageButton}`)\n@@ -195,7 +195,7 @@ export function deleteMessage(testObject, messageToDelete) {\ntestObject.browser\n.element(elements.modalWindow)\n.isVisible(),\n- 'modal window is not visible');\n+ 3500, 'delete modal window is not visible after clicking delete button');\nassert.isTrue(testObject.browser.element(elements.modalDeleteButton).isVisible(), 'modal delete button is not visible');\ntestObject.browser.element(elements.modalDeleteButton).click();\n@@ -204,7 +204,7 @@ export function deleteMessage(testObject, messageToDelete) {\ntestObject.browser.waitUntil(() => {\nconst text = testObject.browser.element(`${elements.lastActivity} ${elements.systemMessage}`).getText();\nreturn text.includes(messages.youDeleted);\n- }, 'message was not deleted');\n+ }, 3500, 'message was not deleted');\n}\n@@ -224,8 +224,8 @@ const sendFileTest = (sender, receiver, fileName, fileSizeVerify = true) => {\nsender.browser.click(elements.shareButton);\nreceiver.browser.waitForExist(fileTitle, 30000);\nreceiver.browser.scroll(fileTitle);\n- const localSize = sender.browser.element(elements.lastActivity).element('.ciscospark-share-file-size').getText();\n- const remoteSize = receiver.browser.element(elements.lastActivity).element('.ciscospark-share-file-size').getText();\n+ const localSize = sender.browser.element(`${elements.lastActivity} .ciscospark-share-file-size`).getText();\n+ const remoteSize = receiver.browser.element(`${elements.lastActivity} .ciscospark-share-file-size`).getText();\n// Some files are embedded and don't display file sizes\nif (fileSizeVerify) {\nassert.equal(localSize, remoteSize);\n",
"new_path": "test/journeys/lib/test-helpers/space-widget/messaging.js",
"old_path": "test/journeys/lib/test-helpers/space-widget/messaging.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
chore(journeys): add better error messaging
| 1
|
chore
|
journeys
|
730,429
|
14.03.2018 11:28:49
| 14,400
|
419cc64a13290b07724e9ae972fb210a042e5675
|
chore(tsconfig): better file exclusion
|
[
{
"change_type": "MODIFY",
"diff": "\"allowJs\": true\n},\n\"include\": [\n- \"packages/node_modules/@ciscospark\"\n+ \"packages/node_modules/@ciscospark/**/*\"\n],\n\"exclude\": [\n- \"node_modules/**/*\"\n+ \"packages/node_modules/@ciscospark/**/dist/*\",\n+ \"node_modules/**/*\",\n+ \"dist\"\n]\n}\n",
"new_path": "tsconfig.json",
"old_path": "tsconfig.json"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
chore(tsconfig): better file exclusion
| 1
|
chore
|
tsconfig
|
791,690
|
14.03.2018 14:43:40
| 25,200
|
818a80f52046c6626312da45710084bc9a80501b
|
core(computed-artifact): remove requiredNumberOfArtifacts
|
[
{
"change_type": "MODIFY",
"diff": "@@ -79,7 +79,7 @@ class UnusedBytes extends Audit {\n.then(networkRecords =>\nPromise.all([\nthis.audit_(artifacts, networkRecords),\n- artifacts.requestPageDependencyGraph(trace, devtoolsLog),\n+ artifacts.requestPageDependencyGraph({trace, devtoolsLog}),\n])\n)\n.then(([result, graph]) => this.createAuditResult(result, graph));\n",
"new_path": "lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js",
"old_path": "lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -243,9 +243,9 @@ class PredictivePerf extends Audit {\n*/\nstatic audit(artifacts) {\nconst trace = artifacts.traces[Audit.DEFAULT_PASS];\n- const devtoolsLogs = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];\n+ const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];\nreturn Promise.all([\n- artifacts.requestPageDependencyGraph(trace, devtoolsLogs),\n+ artifacts.requestPageDependencyGraph({trace, devtoolsLog}),\nartifacts.requestTraceOfTab(trace),\n]).then(([graph, traceOfTab]) => {\nconst graphs = {\n",
"new_path": "lighthouse-core/audits/predictive-perf.js",
"old_path": "lighthouse-core/audits/predictive-perf.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -20,10 +20,6 @@ class ComputedArtifact {\nthis._allComputedArtifacts = allComputedArtifacts;\n}\n- get requiredNumberOfArtifacts() {\n- return 1;\n- }\n-\n/* eslint-disable no-unused-vars */\n/**\n@@ -38,34 +34,20 @@ class ComputedArtifact {\nthrow new Error('compute_() not implemented for computed artifact ' + this.name);\n}\n- /**\n- * Asserts that the length of the array is the same as the number of inputs the class expects\n- * @param {!Array<*>} artifacts\n- */\n- _assertCorrectNumberOfArtifacts(artifacts) {\n- const actual = artifacts.length;\n- const expected = this.requiredNumberOfArtifacts;\n- if (actual !== expected) {\n- const className = this.constructor.name;\n- throw new Error(`${className} requires ${expected} artifacts but ${actual} were given`);\n- }\n- }\n-\n/* eslint-enable no-unused-vars */\n/**\n* Request a computed artifact, caching the result on the input artifact.\n- * @param {...*} artifacts\n+ * @param {*} artifacts\n* @return {!Promise<*>}\n*/\n- request(...artifacts) {\n- this._assertCorrectNumberOfArtifacts(artifacts);\n+ request(artifacts) {\nif (this._cache.has(artifacts)) {\nreturn Promise.resolve(this._cache.get(artifacts));\n}\nconst artifactPromise = Promise.resolve()\n- .then(_ => this.compute_(...artifacts, this._allComputedArtifacts));\n+ .then(_ => this.compute_(artifacts, this._allComputedArtifacts));\nthis._cache.set(artifacts, artifactPromise);\nreturn artifactPromise;\n",
"new_path": "lighthouse-core/gather/computed/computed-artifact.js",
"old_path": "lighthouse-core/gather/computed/computed-artifact.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -22,10 +22,6 @@ class PageDependencyGraphArtifact extends ComputedArtifact {\nreturn 'PageDependencyGraph';\n}\n- get requiredNumberOfArtifacts() {\n- return 2;\n- }\n-\n/**\n* @param {!WebInspector.NetworkRequest} record\n* @return {!Array<string>}\n@@ -284,12 +280,13 @@ class PageDependencyGraphArtifact extends ComputedArtifact {\n}\n/**\n- * @param {!Trace} trace\n- * @param {!DevtoolsLog} devtoolsLog\n+ * @param {{trace: !Trace, devtoolsLog: !DevToolsLog}} data\n* @param {!ComputedArtifacts} artifacts\n* @return {!Promise<!Node>}\n*/\n- compute_(trace, devtoolsLog, artifacts) {\n+ compute_(data, artifacts) {\n+ const trace = data.trace;\n+ const devtoolsLog = data.devtoolsLog;\nconst promises = [\nartifacts.requestTraceOfTab(trace),\nartifacts.requestNetworkRecords(devtoolsLog),\n",
"new_path": "lighthouse-core/gather/computed/page-dependency-graph.js",
"old_path": "lighthouse-core/gather/computed/page-dependency-graph.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -177,7 +177,7 @@ describe('Byte efficiency base audit', () => {\nit('should work on real graphs', () => {\nconst artifacts = Runner.instantiateComputedArtifacts();\n- return artifacts.requestPageDependencyGraph(trace, devtoolsLog).then(graph => {\n+ return artifacts.requestPageDependencyGraph({trace, devtoolsLog}).then(graph => {\nconst result = ByteEfficiencyAudit.createAuditResult(\n{\nheadings: [{key: 'value', text: 'Label'}],\n",
"new_path": "lighthouse-core/test/audits/byte-efficiency/byte-efficiency-audit-test.js",
"old_path": "lighthouse-core/test/audits/byte-efficiency/byte-efficiency-audit-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -29,24 +29,7 @@ class TestComputedArtifact extends ComputedArtifact {\n}\n}\n-class MultipleInputArtifact extends TestComputedArtifact {\n- get requiredNumberOfArtifacts() {\n- return 2;\n- }\n-}\n-\ndescribe('ComputedArtifact base class', () => {\n- it('tests correct number of inputs', () => {\n- const singleInputArtifact = new TestComputedArtifact();\n- const multiInputArtifact = new MultipleInputArtifact();\n-\n- return Promise.resolve()\n- .then(_ => singleInputArtifact.request(1))\n- .then(_ => multiInputArtifact.request(1, 2))\n- .then(_ => assert.throws(() => singleInputArtifact.request(1, 2)))\n- .then(_ => assert.throws(() => multiInputArtifact.request(1)));\n- });\n-\nit('caches computed artifacts by strict equality', () => {\nconst computedArtifact = new TestComputedArtifact();\n@@ -61,24 +44,4 @@ describe('ComputedArtifact base class', () => {\nassert.equal(computedArtifact.computeCounter, 2);\n});\n});\n-\n- it('caches multiple input arguments', () => {\n- const mockComputed = {computed: true};\n- const computedArtifact = new MultipleInputArtifact(mockComputed);\n-\n- const obj0 = {value: 1};\n- const obj1 = {value: 2};\n- const obj2 = {value: 3};\n-\n- return computedArtifact.request(obj0, obj1)\n- .then(result => assert.equal(result, 0))\n- .then(_ => assert.deepEqual(computedArtifact.lastArguments, [obj0, obj1, mockComputed]))\n- .then(_ => computedArtifact.request(obj1, obj2))\n- .then(result => assert.equal(result, 1))\n- .then(_ => assert.deepEqual(computedArtifact.lastArguments, [obj1, obj2, mockComputed]))\n- .then(_ => computedArtifact.request(obj0, obj1))\n- .then(result => assert.equal(result, 0))\n- .then(_ => assert.deepEqual(computedArtifact.lastArguments, [obj1, obj2, mockComputed]))\n- .then(_ => assert.equal(computedArtifact.computeCounter, 2));\n- });\n});\n",
"new_path": "lighthouse-core/test/gather/computed/computed-artifact-test.js",
"old_path": "lighthouse-core/test/gather/computed/computed-artifact-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -55,10 +55,10 @@ describe('PageDependencyGraph computed artifact:', () => {\ndescribe('#compute_', () => {\nit('should compute the dependency graph', () => {\n- return computedArtifacts.requestPageDependencyGraph(\n- sampleTrace,\n- sampleDevtoolsLog\n- ).then(output => {\n+ return computedArtifacts.requestPageDependencyGraph({\n+ trace: sampleTrace,\n+ devtoolsLog: sampleDevtoolsLog,\n+ }).then(output => {\nassert.ok(output instanceof Node, 'did not return a graph');\nconst dependents = output.getDependents();\n",
"new_path": "lighthouse-core/test/gather/computed/page-dependency-graph-test.js",
"old_path": "lighthouse-core/test/gather/computed/page-dependency-graph-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(computed-artifact): remove requiredNumberOfArtifacts (#4764)
| 1
|
core
|
computed-artifact
|
791,690
|
14.03.2018 14:44:33
| 25,200
|
f580c5914c3a009bab5a11112677d74a8d955c6f
|
core: rename uses-request-compression
to uses-text-compression
|
[
{
"change_type": "MODIFY",
"diff": "@@ -15,6 +15,7 @@ module.exports = {\n'offscreen-images',\n'uses-webp-images',\n'uses-optimized-images',\n+ 'uses-text-compression',\n'uses-responsive-images',\n'unminified-css',\n'unminified-javascript',\n",
"new_path": "lighthouse-cli/test/smokehouse/byte-config.js",
"old_path": "lighthouse-cli/test/smokehouse/byte-config.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -90,6 +90,17 @@ module.exports = [\n},\n},\n},\n+ 'uses-text-compression': {\n+ extendedInfo: {\n+ value: {\n+ wastedMs: '>700',\n+ wastedKb: '>50',\n+ results: {\n+ length: 2,\n+ },\n+ },\n+ },\n+ },\n'uses-optimized-images': {\nextendedInfo: {\nvalue: {\n",
"new_path": "lighthouse-cli/test/smokehouse/byte-efficiency/expectations.js",
"old_path": "lighthouse-cli/test/smokehouse/byte-efficiency/expectations.js"
},
{
"change_type": "RENAME",
"diff": "@@ -21,7 +21,7 @@ class ResponsesAreCompressed extends ByteEfficiencyAudit {\n*/\nstatic get meta() {\nreturn {\n- name: 'uses-request-compression',\n+ name: 'uses-text-compression',\ninformative: true,\nscoreDisplayMode: ByteEfficiencyAudit.SCORING_MODES.NUMERIC,\ndescription: 'Enable text compression',\n",
"new_path": "lighthouse-core/audits/byte-efficiency/uses-text-compression.js",
"old_path": "lighthouse-core/audits/byte-efficiency/uses-request-compression.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -159,7 +159,7 @@ module.exports = {\n'byte-efficiency/unused-css-rules',\n'byte-efficiency/uses-webp-images',\n'byte-efficiency/uses-optimized-images',\n- 'byte-efficiency/uses-request-compression',\n+ 'byte-efficiency/uses-text-compression',\n'byte-efficiency/uses-responsive-images',\n'dobetterweb/appcache-manifest',\n'dobetterweb/dom-size',\n@@ -279,7 +279,7 @@ module.exports = {\n{id: 'unused-css-rules', weight: 0, group: 'perf-hint'},\n{id: 'uses-optimized-images', weight: 0, group: 'perf-hint'},\n{id: 'uses-webp-images', weight: 0, group: 'perf-hint'},\n- {id: 'uses-request-compression', weight: 0, group: 'perf-hint'},\n+ {id: 'uses-text-compression', weight: 0, group: 'perf-hint'},\n{id: 'time-to-first-byte', weight: 0, group: 'perf-hint'},\n{id: 'redirects', weight: 0, group: 'perf-hint'},\n{id: 'uses-rel-preload', weight: 0, group: 'perf-hint'},\n",
"new_path": "lighthouse-core/config/default.js",
"old_path": "lighthouse-core/config/default.js"
},
{
"change_type": "RENAME",
"diff": "const KB = 1024;\nconst ResponsesAreCompressedAudit =\n- require('../../../audits/byte-efficiency/uses-request-compression.js');\n+ require('../../../audits/byte-efficiency/uses-text-compression.js');\nconst assert = require('assert');\nfunction generateResponse(options) {\n",
"new_path": "lighthouse-core/test/audits/byte-efficiency/uses-text-compression-test.js",
"old_path": "lighthouse-core/test/audits/byte-efficiency/uses-response-compression-test.js"
},
{
"change_type": "MODIFY",
"diff": "\"items\": []\n}\n},\n- \"uses-request-compression\": {\n+ \"uses-text-compression\": {\n\"score\": 90,\n\"displayValue\": \"Potential savings of 62 KB (~290ms)\",\n\"rawValue\": 290,\n},\n\"scoringMode\": \"binary\",\n\"informative\": true,\n- \"name\": \"uses-request-compression\",\n+ \"name\": \"uses-text-compression\",\n\"category\": \"Performance\",\n\"description\": \"Enable text compression\",\n\"helpText\": \"Text-based responses should be served with compression (gzip, deflate or brotli) to minimize total network bytes. [Learn more](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/optimize-encoding-and-transfer).\",\n\"score\": 100\n},\n{\n- \"id\": \"uses-request-compression\",\n+ \"id\": \"uses-text-compression\",\n\"weight\": 0,\n\"group\": \"perf-hint\",\n\"result\": {\n},\n\"scoringMode\": \"binary\",\n\"informative\": true,\n- \"name\": \"uses-request-compression\",\n+ \"name\": \"uses-text-compression\",\n\"category\": \"Performance\",\n\"description\": \"Enable text compression\",\n\"helpText\": \"Text-based responses should be served with compression (gzip, deflate or brotli) to minimize total network bytes. [Learn more](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/optimize-encoding-and-transfer).\",\n",
"new_path": "lighthouse-core/test/fixtures/dbw_tester-perf-results.json",
"old_path": "lighthouse-core/test/fixtures/dbw_tester-perf-results.json"
},
{
"change_type": "MODIFY",
"diff": "}\n}\n},\n- \"uses-request-compression\": {\n+ \"uses-text-compression\": {\n\"score\": 0.9,\n\"displayValue\": \"Potential savings of 64646 bytes\",\n\"rawValue\": 150,\n},\n\"scoreDisplayMode\": \"numeric\",\n\"informative\": true,\n- \"name\": \"uses-request-compression\",\n+ \"name\": \"uses-text-compression\",\n\"description\": \"Enable text compression\",\n\"helpText\": \"Text-based responses should be served with compression (gzip, deflate or brotli) to minimize total network bytes. [Learn more](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/optimize-encoding-and-transfer).\",\n\"details\": {\n\"group\": \"perf-hint\"\n},\n{\n- \"id\": \"uses-request-compression\",\n+ \"id\": \"uses-text-compression\",\n\"weight\": 0,\n\"group\": \"perf-hint\"\n},\n",
"new_path": "lighthouse-core/test/results/sample_v2.json",
"old_path": "lighthouse-core/test/results/sample_v2.json"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core: rename uses-request-compression (#4763)
to uses-text-compression
| 1
|
core
| null |
791,690
|
14.03.2018 14:45:46
| 25,200
|
c8d84fad13dd92b7faf96dc20e36e9bcf1492291
|
core: remove cache-start-url audit
|
[
{
"change_type": "DELETE",
"diff": "-/**\n- * @license Copyright 2016 Google Inc. All Rights Reserved.\n- * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n- */\n-'use strict';\n-\n-const Audit = require('./audit');\n-\n-class CacheStartUrl extends Audit {\n- /**\n- * @return {!AuditMeta}\n- */\n- static get meta() {\n- return {\n- name: 'cache-start-url',\n- description: 'Cache contains start_url from manifest (alpha)',\n- failureDescription: 'Cache does not contain start_url from manifest (alpha)',\n- requiredArtifacts: ['CacheContents', 'Manifest', 'URL'],\n- };\n- }\n-\n- /**\n- * @param {!Artifacts} artifacts\n- * @return {!AuditResult}\n- */\n- static audit(artifacts) {\n- if (!artifacts.Manifest || !artifacts.Manifest.value) {\n- // Page has no manifest or was invalid JSON.\n- return {\n- rawValue: false,\n- };\n- }\n-\n- const manifest = artifacts.Manifest.value;\n- if (!(manifest.start_url && manifest.start_url.value)) {\n- return {\n- rawValue: false,\n- debugString: 'start_url not present in Manifest',\n- };\n- }\n-\n- // Remove any UTM strings.\n- const startURL = manifest.start_url.value;\n- /** @const {string} */\n- const altStartURL = startURL\n- .replace(/\\?utm_([^=]*)=([^&]|$)*/, '')\n- .replace(/\\?$/, '');\n-\n- // Now find the start_url in the cacheContents. This test is less than ideal since the Service\n- // Worker can rewrite a request from the start URL to anything else in the cache, and so a TODO\n- // here would be to resolve this more completely by asking the service worker about the start\n- // URL. However that would also necessitate the cache contents gatherer relying on the manifest\n- // gather rather than being independent of it.\n- const cacheContents = artifacts.CacheContents;\n- const cacheHasStartUrl = cacheContents.find(req => {\n- return (startURL === req || altStartURL === req);\n- });\n-\n- return {\n- rawValue: (cacheHasStartUrl !== undefined),\n- };\n- }\n-}\n-\n-module.exports = CacheStartUrl;\n",
"new_path": null,
"old_path": "lighthouse-core/audits/cache-start-url.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -9,8 +9,6 @@ const Gatherer = require('./gatherer');\nclass URL extends Gatherer {\nafterPass(options) {\n- // Used currently by cache-start-url audit, which wants to know if the start_url\n- // in the manifest is stored in the cache.\n// Instead of the originally inputted URL (options.initialUrl), we want the resolved\n// post-redirect URL (which is here at options.url)\nreturn {\n",
"new_path": "lighthouse-core/gather/gatherers/url.js",
"old_path": "lighthouse-core/gather/gatherers/url.js"
},
{
"change_type": "DELETE",
"diff": "-/**\n- * @license Copyright 2016 Google Inc. All Rights Reserved.\n- * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n- */\n-'use strict';\n-\n-const CacheStartUrlAudit = require('../../audits/cache-start-url.js');\n-const assert = require('assert');\n-const manifestSrc = JSON.stringify(require('../fixtures/manifest.json'));\n-const manifestParser = require('../../lib/manifest-parser');\n-const CacheContents = ['https://another.example.com/', 'https://example.com/'];\n-const URL = 'https://example.com';\n-const AltURL = 'https://example.com/?utm_source=http203';\n-const exampleManifest = manifestParser(manifestSrc, URL, URL);\n-\n-/* eslint-env mocha */\n-\n-describe('Cache: start_url audit', () => {\n- it('fails with no debugString if page had no manifest', () => {\n- const result = CacheStartUrlAudit.audit({\n- Manifest: null,\n- CacheContents,\n- URL: {finalUrl: URL},\n- });\n- assert.strictEqual(result.rawValue, false);\n- assert.strictEqual(result.debugString, undefined);\n- });\n-\n- it('succeeds when given a manifest with a start_url, cache contents, and a URL', () => {\n- return assert.equal(CacheStartUrlAudit.audit({\n- Manifest: exampleManifest,\n- CacheContents,\n- URL: {finalUrl: URL},\n- }).rawValue, true);\n- });\n-\n- it('handles URLs with utm params', () => {\n- return assert.equal(CacheStartUrlAudit.audit({\n- Manifest: exampleManifest,\n- CacheContents,\n- URL: {finalUrl: AltURL},\n- }).rawValue, true);\n- });\n-});\n",
"new_path": null,
"old_path": "lighthouse-core/test/audits/cache-start-url-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core: remove cache-start-url audit (#4760)
| 1
|
core
| null |
791,690
|
14.03.2018 14:47:18
| 25,200
|
544b7c6c6c9d4d676ebeff2f844bb723283d49c1
|
report(scores): make sure scores are represented out of 100
|
[
{
"change_type": "MODIFY",
"diff": "@@ -70,8 +70,9 @@ class CategoryRenderer {\n*/\n_populateScore(element, score, scoreDisplayMode, title, description) {\n// Fill in the blanks.\n+ const scoreOutOf100 = Math.round(score * 100);\nconst valueEl = this.dom.find('.lh-score__value', element);\n- valueEl.textContent = Util.formatNumber(score);\n+ valueEl.textContent = Util.formatNumber(scoreOutOf100);\nvalueEl.classList.add(`lh-score__value--${Util.calculateRating(score)}`,\n`lh-score__value--${scoreDisplayMode}`);\n@@ -89,13 +90,13 @@ class CategoryRenderer {\n*/\nrenderCategoryScore(category) {\nconst tmpl = this.dom.cloneTemplate('#tmpl-lh-category-score', this.templateContext);\n- const score = Math.round(category.score);\nconst gaugeContainerEl = this.dom.find('.lh-score__gauge', tmpl);\nconst gaugeEl = this.renderScoreGauge(category);\ngaugeContainerEl.appendChild(gaugeEl);\n- return this._populateScore(tmpl, score, 'numeric', category.name, category.description);\n+ const {score, name, description} = category;\n+ return this._populateScore(tmpl, score, 'numeric', name, description);\n}\n/**\n@@ -237,12 +238,12 @@ class CategoryRenderer {\nthis.dom.find('.lh-gauge__wrapper', tmpl).href = `#${category.id}`;\nthis.dom.find('.lh-gauge__label', tmpl).textContent = category.name;\n- const score = Math.round(category.score * 100);\n- const fillRotation = Math.floor((score / 100) * 180);\n+ const scoreOutOf100 = Math.round(category.score * 100);\n+ const fillRotation = Math.floor((scoreOutOf100 / 100) * 180);\nconst gauge = this.dom.find('.lh-gauge', tmpl);\n- gauge.setAttribute('data-progress', score); // .dataset not supported in jsdom.\n- gauge.classList.add(`lh-gauge--${Util.calculateRating(score)}`);\n+ gauge.setAttribute('data-progress', scoreOutOf100); // .dataset not supported in jsdom.\n+ gauge.classList.add(`lh-gauge--${Util.calculateRating(category.score)}`);\nthis.dom.findAll('.lh-gauge__fill', gauge).forEach(el => {\nel.style.transform = `rotate(${fillRotation}deg)`;\n@@ -252,7 +253,7 @@ class CategoryRenderer {\n`rotate(${fillRotation}deg)`;\nthis.dom.find('.lh-gauge__fill--fix', gauge).style.transform =\n`rotate(${fillRotation * 2}deg)`;\n- this.dom.find('.lh-gauge__percentage', gauge).textContent = score;\n+ this.dom.find('.lh-gauge__percentage', gauge).textContent = scoreOutOf100;\nreturn tmpl;\n}\n",
"new_path": "lighthouse-core/report/v2/renderer/category-renderer.js",
"old_path": "lighthouse-core/report/v2/renderer/category-renderer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -109,7 +109,7 @@ class ReportRenderer {\nthis._dom.find('.leftnav-item__category', navItem).textContent = category.name;\nconst score = this._dom.find('.leftnav-item__score', navItem);\nscore.classList.add(`lh-score__value--${Util.calculateRating(category.score)}`);\n- score.textContent = Math.round(category.score);\n+ score.textContent = Math.round(100 * category.score);\nnav.appendChild(navItem);\n}\nreturn leftNav;\n",
"new_path": "lighthouse-core/report/v2/renderer/report-renderer.js",
"old_path": "lighthouse-core/report/v2/renderer/report-renderer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -11,8 +11,8 @@ const ELLIPSIS = '\\u2026';\nconst NBSP = '\\xa0';\nconst RATINGS = {\n- PASS: {label: 'pass', minScore: 75},\n- AVERAGE: {label: 'average', minScore: 45},\n+ PASS: {label: 'pass', minScore: 0.75},\n+ AVERAGE: {label: 'average', minScore: 0.45},\nFAIL: {label: 'fail'},\n};\n",
"new_path": "lighthouse-core/report/v2/renderer/util.js",
"old_path": "lighthouse-core/report/v2/renderer/util.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -97,7 +97,8 @@ describe('CategoryRenderer', () => {\nassert.deepEqual(score, score.firstElementChild, 'first child is a score');\nassert.ok(value.classList.contains('lh-score__value--numeric'),\n'category score is numeric');\n- assert.equal(value.textContent, Math.round(category.score), 'category score is rounded');\n+ const scoreInDom = Number(value.textContent);\n+ assert.ok(Number.isInteger(scoreInDom) && scoreInDom > 10, 'category score is rounded');\nassert.equal(title.textContent, category.name, 'title is set');\nconst audits = categoryDOM.querySelectorAll('.lh-audit');\n@@ -179,7 +180,8 @@ describe('CategoryRenderer', () => {\nassert.deepEqual(score, score.firstElementChild, 'first child is a score');\nassert.ok(value.classList.contains('lh-score__value--numeric'),\n'category score is numeric');\n- assert.equal(value.textContent, Math.round(category.score), 'category score is rounded');\n+ const scoreInDom = Number(value.textContent);\n+ assert.ok(Number.isInteger(scoreInDom) && scoreInDom > 10, 'score is rounded out of 100');\nassert.equal(title.textContent, category.name, 'title is set');\nassert.ok(description.querySelector('a'), 'description contains converted markdown links');\n});\n",
"new_path": "lighthouse-core/test/report/v2/renderer/category-renderer-test.js",
"old_path": "lighthouse-core/test/report/v2/renderer/category-renderer-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -27,12 +27,12 @@ describe('util helpers', () => {\n});\nit('calculates a score ratings', () => {\n- assert.equal(Util.calculateRating(0), 'fail');\n- assert.equal(Util.calculateRating(10), 'fail');\n- assert.equal(Util.calculateRating(45), 'average');\n- assert.equal(Util.calculateRating(55), 'average');\n- assert.equal(Util.calculateRating(75), 'pass');\n- assert.equal(Util.calculateRating(80), 'pass');\n- assert.equal(Util.calculateRating(100), 'pass');\n+ assert.equal(Util.calculateRating(0.0), 'fail');\n+ assert.equal(Util.calculateRating(0.10), 'fail');\n+ assert.equal(Util.calculateRating(0.45), 'average');\n+ assert.equal(Util.calculateRating(0.55), 'average');\n+ assert.equal(Util.calculateRating(0.75), 'pass');\n+ assert.equal(Util.calculateRating(0.80), 'pass');\n+ assert.equal(Util.calculateRating(1.00), 'pass');\n});\n});\n",
"new_path": "lighthouse-core/test/report/v2/renderer/format-helpers-test.js",
"old_path": "lighthouse-core/test/report/v2/renderer/format-helpers-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -60,7 +60,8 @@ describe('PerfCategoryRenderer', () => {\nassert.deepEqual(score, score.firstElementChild, 'first child is a score');\nassert.ok(value.classList.contains('lh-score__value--numeric'),\n'category score is numeric');\n- assert.equal(value.textContent, Math.round(category.score), 'category score is rounded');\n+ const scoreInDom = Number(value.textContent);\n+ assert.ok(Number.isInteger(scoreInDom) && scoreInDom > 10, 'category score is rounded');\nassert.equal(title.textContent, category.name, 'title is set');\n});\n",
"new_path": "lighthouse-core/test/report/v2/renderer/performance-category-renderer-test.js",
"old_path": "lighthouse-core/test/report/v2/renderer/performance-category-renderer-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -131,7 +131,7 @@ describe('ReportRenderer V2', () => {\nconst scores = header.querySelectorAll('.leftnav-item__score');\nsampleResults.reportCategories.forEach((cat, i) => {\nassert.equal(categories[i].textContent, cat.name);\n- assert.equal(scores[i].textContent, Math.round(Util.formatNumber(cat.score)));\n+ assert.equal(Number(scores[i].textContent), cat.score * 100);\n});\n});\n",
"new_path": "lighthouse-core/test/report/v2/renderer/report-renderer-test.js",
"old_path": "lighthouse-core/test/report/v2/renderer/report-renderer-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
report(scores): make sure scores are represented out of 100 (#4750)
| 1
|
report
|
scores
|
791,690
|
14.03.2018 14:53:47
| 25,200
|
a1c5433c0d03b1be5166df0d603e63a89f96ddd2
|
tests(config): add merge-options test
|
[
{
"change_type": "MODIFY",
"diff": "@@ -571,7 +571,7 @@ describe('Config', () => {\n});\n});\n- describe('generateConfigOfCategories', () => {\n+ describe('generateNewFilteredConfig', () => {\nit('should not mutate the original config', () => {\nconst configCopy = JSON.parse(JSON.stringify(origConfig));\nConfig.generateNewFilteredConfig(configCopy, ['performance']);\n@@ -633,6 +633,27 @@ describe('Config', () => {\n});\n});\n+ describe('expandAuditShorthandAndMergeOptions', () => {\n+ it('should merge audits', () => {\n+ const audits = ['a', {path: 'b', options: {x: 1, y: 1}}, {path: 'b', options: {x: 2}}];\n+ const merged = Config.expandAuditShorthandAndMergeOptions(audits);\n+ assert.deepEqual(merged, [{path: 'a', options: {}}, {path: 'b', options: {x: 2, y: 1}}]);\n+ });\n+ });\n+\n+ describe('expandGathererShorthandAndMergeOptions', () => {\n+ it('should merge gatherers', () => {\n+ const gatherers = [\n+ 'viewport-dimensions',\n+ {path: 'viewport-dimensions', options: {x: 1}},\n+ {path: 'viewport-dimensions', options: {y: 1}},\n+ ];\n+\n+ const merged = Config.expandGathererShorthandAndMergeOptions([{gatherers}]);\n+ assert.deepEqual(merged[0].gatherers, [{path: 'viewport-dimensions', options: {x: 1, y: 1}}]);\n+ });\n+ });\n+\ndescribe('#requireGatherers', () => {\nfunction loadGatherer(gathererEntry) {\nconst config = new Config({passes: [{gatherers: [gathererEntry]}]});\n",
"new_path": "lighthouse-core/test/config/config-test.js",
"old_path": "lighthouse-core/test/config/config-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
tests(config): add merge-options test (#4747)
| 1
|
tests
|
config
|
730,429
|
14.03.2018 15:16:20
| 14,400
|
4cf0e96b7e6558b50bc38397a18d799bea7d828b
|
chore(wdio): add screenResolution
|
[
{
"change_type": "MODIFY",
"diff": "@@ -17,6 +17,7 @@ const platform = process.env.PLATFORM || 'mac 10.12';\nconst tunnelId = uuid.v4();\nconst port = process.env.PORT || 4567;\nconst {suite} = argv || 'integration';\n+const screenResolution = '1920x1440';\nconst chromeCapabilities = {\nbrowserName: 'chrome',\n@@ -34,6 +35,7 @@ const chromeCapabilities = {\nidleTimeout: 300,\nmaxDuration: 3600,\nseleniumVersion: '3.4.0',\n+ screenResolution,\nplatform\n};\nconst firefoxCapabilities = {\n@@ -42,6 +44,7 @@ const firefoxCapabilities = {\nidleTimeout: 300,\nmaxDuration: 3600,\nseleniumVersion: '3.4.0',\n+ screenResolution,\nplatform\n};\nlet mochaTimeout = 30000;\n",
"new_path": "wdio.conf.js",
"old_path": "wdio.conf.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
chore(wdio): add screenResolution
| 1
|
chore
|
wdio
|
730,429
|
14.03.2018 15:16:51
| 14,400
|
5495f59d9fbc77ed174ce48232352a09e1986953
|
chore(Jenkinsfile): archive reports
|
[
{
"change_type": "MODIFY",
"diff": "@@ -118,6 +118,7 @@ ansiColor('xterm') {\nsleep 120 && CISCOSPARK_CLIENT_ID=C873b64d70536ed26df6d5f81e01dafccbd0a0af2e25323f7f69c7fe46a7be340 SAUCE=true PORT=4567 SAUCE_CONNECT_PORT=5004 BROWSER=chrome PLATFORM=\"windows 10\" npm run test:integration &\nwait\n'''\n+ archiveArtifacts 'reports/**/*'\njunit '**/reports/junit/wdio/*.xml'\n}\n}\n",
"new_path": "Jenkinsfile",
"old_path": "Jenkinsfile"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
chore(Jenkinsfile): archive reports
| 1
|
chore
|
Jenkinsfile
|
217,922
|
14.03.2018 16:05:49
| -3,600
|
16c7ecdfd32ff51cee0ac05f4a8aa4e492ecd976
|
fix: missing help dialog box for list details page
|
[
{
"change_type": "MODIFY",
"diff": "@@ -12,7 +12,12 @@ export class HelpService {\nconstructor(private router: Router) {\nrouter.events\n.filter(event => event instanceof NavigationEnd)\n- .subscribe((event: any) => this.currentRoute = event.url);\n+ .subscribe((event: any) => {\n+ this.currentRoute = event.url;\n+ if (this.currentRoute.indexOf('/list') > -1) {\n+ this.currentRoute = '/list';\n+ }\n+ });\n}\npublic set currentHelp(dialog: ComponentType<any> | TemplateRef<any>) {\n",
"new_path": "src/app/core/component/help.service.ts",
"old_path": "src/app/core/component/help.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -33,8 +33,7 @@ export abstract class PageComponent extends ComponentWithSubscriptions implement\n// (https://github.com/angular/angular/issues/15634)\nsetTimeout(() => {\nthis.helpService.currentHelp = this.getHelpDialog();\n- if (localStorage.getItem(`${this.constructor.name}:help`) !== 'true' &&\n- !this.media.isActive('print and (max-width: 600px)')) {\n+ if (localStorage.getItem(`${this.constructor.name}:help`) !== 'true') {\nthis.dialog.open(this.getHelpDialog()).afterClosed().subscribe(() => {\nlocalStorage.setItem(`${this.constructor.name}:help`, 'true');\n});\n",
"new_path": "src/app/core/component/page-component.ts",
"old_path": "src/app/core/component/page-component.ts"
},
{
"change_type": "MODIFY",
"diff": "<div class=\"description\">\n<img *ngIf=\"author | async as authorData\" [src]=\"authorData?.avatar\" class=\"author-avatar\"\n[matTooltip]=\"authorData?.name\" matTooltipPosition=\"above\"\n+ hidden=\"{{authorData?.name === 'Anonymous'}}\"\nrouterLink=\"/profile/{{list.authorId}}\">\n<div class=\"tags\">\n<mat-chip-list class=\"inline-chips\">\n",
"new_path": "src/app/modules/common-components/list-panel/list-panel.component.html",
"old_path": "src/app/modules/common-components/list-panel/list-panel.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -40,6 +40,7 @@ export class ListComponent extends PageComponent implements OnInit, OnDestroy {\n}\nngOnInit() {\n+ super.ngOnInit();\nthis.list = this.route.params.switchMap(params => {\nreturn this.reload$\n.mergeMap(() => this.listService.get(params.listId))\n",
"new_path": "src/app/pages/list/list/list.component.ts",
"old_path": "src/app/pages/list/list/list.component.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
fix: missing help dialog box for list details page
| 1
|
fix
| null |
730,429
|
14.03.2018 16:14:16
| 14,400
|
c7f732a211b6def5909c1e3be6f9784195055b62
|
test(journeys): wait for read receipt on verifyMessageReceipt
|
[
{
"change_type": "MODIFY",
"diff": "@@ -24,7 +24,10 @@ export const elements = {\nshareButton: 'button[aria-label=\"Share\"]',\nsystemMessage: '.ciscospark-system-message',\nlastActivity: '.ciscospark-activity-item-container:last-child',\n- lastActivityText: '.ciscospark-activity-item-container:last-child .ciscospark-activity-text'\n+ lastActivityText: '.ciscospark-activity-item-container:last-child .ciscospark-activity-text',\n+ readReceiptsArea: '.ciscospark-read-receipts',\n+ readReceiptsAvatar: '.ciscospark-typing-avatar',\n+ messageComposer: '.ciscospark-message-composer'\n};\nexport const messages = {\n@@ -64,6 +67,13 @@ export function verifyMessageReceipt(receiver, sender, message) {\nreceiver.browser.waitForExist(elements.pendingActivity, 15000, true);\nreceiver.browser.waitForExist(elements.lastActivityText, 15000);\nreceiver.browser.waitUntil(() => receiver.browser.element(elements.lastActivityText).getText() === message);\n+ // Move mouse to send read receipt\n+ moveMouse(receiver.browser, elements.lastActivityText);\n+ // Verify read receipt comes across\n+ sender.browser.waitForExist(`${elements.readReceiptsArea} ${elements.readReceiptsAvatar}`);\n+ // Move Mouse to text area so it doesn't cause any tool tips\n+ moveMouse(receiver.browser, elements.messageComposer);\n+ moveMouse(sender.browser, elements.messageComposer);\n}\n/**\n",
"new_path": "test/journeys/lib/test-helpers/space-widget/messaging.js",
"old_path": "test/journeys/lib/test-helpers/space-widget/messaging.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
test(journeys): wait for read receipt on verifyMessageReceipt
| 1
|
test
|
journeys
|
791,690
|
14.03.2018 16:23:22
| 25,200
|
b5172c9a4924cee5f06ed1ab1f877da49680a437
|
core(is-on-https): consider about:* secure
|
[
{
"change_type": "MODIFY",
"diff": "@@ -9,7 +9,7 @@ const Audit = require('./audit');\nconst URL = require('../lib/url-shim');\nconst Util = require('../report/v2/renderer/util');\n-const SECURE_SCHEMES = ['data', 'https', 'wss', 'blob', 'chrome', 'chrome-extension'];\n+const SECURE_SCHEMES = ['data', 'https', 'wss', 'blob', 'chrome', 'chrome-extension', 'about'];\nconst SECURE_DOMAINS = ['localhost', '127.0.0.1'];\nclass HTTPS extends Audit {\n",
"new_path": "lighthouse-core/audits/is-on-https.js",
"old_path": "lighthouse-core/audits/is-on-https.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -67,6 +67,7 @@ describe('Security: HTTPS audit', () => {\nassert.strictEqual(Audit.isSecureRecord({scheme: 'wss', domain: 'my-service.com'}), true);\nassert.strictEqual(Audit.isSecureRecord({scheme: 'data', domain: ''}), true);\nassert.strictEqual(Audit.isSecureRecord({scheme: 'blob', domain: ''}), true);\n+ assert.strictEqual(Audit.isSecureRecord({scheme: 'about', domain: ''}), true);\nassert.strictEqual(Audit.isSecureRecord({scheme: '', protocol: 'blob', domain: ''}), true);\nassert.strictEqual(Audit.isSecureRecord({scheme: 'chrome', domain: ''}), true);\nassert.strictEqual(Audit.isSecureRecord({scheme: 'chrome-extension', domain: ''}), true);\n",
"new_path": "lighthouse-core/test/audits/is-on-https-test.js",
"old_path": "lighthouse-core/test/audits/is-on-https-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(is-on-https): consider about:* secure (#4749)
| 1
|
core
|
is-on-https
|
807,849
|
14.03.2018 16:29:44
| 25,200
|
cd4317cbeb91472991693952f64439814f69dc6e
|
chore: bump transitive dep validate-npm-package-license
|
[
{
"change_type": "MODIFY",
"diff": "\"parse-json\": \"2.2.0\",\n\"pify\": \"2.3.0\",\n\"strip-bom\": \"3.0.0\"\n- },\n- \"dependencies\": {\n- \"pify\": {\n- \"version\": \"2.3.0\",\n- \"resolved\": \"https://registry.npmjs.org/pify/-/pify-2.3.0.tgz\",\n- \"integrity\": \"sha1-7RQaasBDqEnqWISY59yosVMw6Qw=\",\n- \"dev\": true\n- }\n}\n},\n\"path-type\": {\n\"dev\": true,\n\"requires\": {\n\"pify\": \"2.3.0\"\n+ }\n},\n- \"dependencies\": {\n\"pify\": {\n\"version\": \"2.3.0\",\n\"resolved\": \"https://registry.npmjs.org/pify/-/pify-2.3.0.tgz\",\n\"integrity\": \"sha1-7RQaasBDqEnqWISY59yosVMw6Qw=\",\n\"dev\": true\n- }\n- }\n},\n\"read-pkg\": {\n\"version\": \"2.0.0\",\n\"hosted-git-info\": \"2.5.0\",\n\"is-builtin-module\": \"1.0.0\",\n\"semver\": \"5.5.0\",\n- \"validate-npm-package-license\": \"3.0.1\"\n+ \"validate-npm-package-license\": \"3.0.3\"\n}\n},\n\"normalize-path\": {\n\"integrity\": \"sha1-PpNdfd1zYxuXZZlW1VEo6HtQhKM=\"\n},\n\"spdx-correct\": {\n- \"version\": \"1.0.2\",\n- \"resolved\": \"https://registry.npmjs.org/spdx-correct/-/spdx-correct-1.0.2.tgz\",\n- \"integrity\": \"sha1-SzBz2TP/UfORLwOsVRlJikFQ20A=\",\n+ \"version\": \"3.0.0\",\n+ \"resolved\": \"https://registry.npmjs.org/spdx-correct/-/spdx-correct-3.0.0.tgz\",\n+ \"integrity\": \"sha512-N19o9z5cEyc8yQQPukRCZ9EUmb4HUpnrmaL/fxS2pBo2jbfcFRVuFZ/oFC+vZz0MNNk0h80iMn5/S6qGZOL5+g==\",\n\"requires\": {\n- \"spdx-license-ids\": \"1.2.2\"\n+ \"spdx-expression-parse\": \"3.0.0\",\n+ \"spdx-license-ids\": \"3.0.0\"\n}\n},\n+ \"spdx-exceptions\": {\n+ \"version\": \"2.1.0\",\n+ \"resolved\": \"https://registry.npmjs.org/spdx-exceptions/-/spdx-exceptions-2.1.0.tgz\",\n+ \"integrity\": \"sha512-4K1NsmrlCU1JJgUrtgEeTVyfx8VaYea9J9LvARxhbHtVtohPs/gFGG5yy49beySjlIMhhXZ4QqujIZEfS4l6Cg==\"\n+ },\n\"spdx-expression-parse\": {\n- \"version\": \"1.0.4\",\n- \"resolved\": \"https://registry.npmjs.org/spdx-expression-parse/-/spdx-expression-parse-1.0.4.tgz\",\n- \"integrity\": \"sha1-m98vIOH0DtRH++JzJmGR/O1RYmw=\"\n+ \"version\": \"3.0.0\",\n+ \"resolved\": \"https://registry.npmjs.org/spdx-expression-parse/-/spdx-expression-parse-3.0.0.tgz\",\n+ \"integrity\": \"sha512-Yg6D3XpRD4kkOmTpdgbUiEJFKghJH03fiC1OPll5h/0sO6neh2jqRDVHOQ4o/LMea0tgCkbMgea5ip/e+MkWyg==\",\n+ \"requires\": {\n+ \"spdx-exceptions\": \"2.1.0\",\n+ \"spdx-license-ids\": \"3.0.0\"\n+ }\n},\n\"spdx-license-ids\": {\n- \"version\": \"1.2.2\",\n- \"resolved\": \"https://registry.npmjs.org/spdx-license-ids/-/spdx-license-ids-1.2.2.tgz\",\n- \"integrity\": \"sha1-yd96NCRZSt5r0RkA1ZZpbcBrrFc=\"\n+ \"version\": \"3.0.0\",\n+ \"resolved\": \"https://registry.npmjs.org/spdx-license-ids/-/spdx-license-ids-3.0.0.tgz\",\n+ \"integrity\": \"sha512-2+EPwgbnmOIl8HjGBXXMd9NAu02vLjOO1nWw4kmeRDFyHn+M/ETfHxQUK0oXg8ctgVnl9t3rosNVsZ1jG61nDA==\"\n},\n\"split\": {\n\"version\": \"1.0.1\",\n\"integrity\": \"sha512-jZnMwlb9Iku/O3smGWvZhauCf6cvvpKi4BKRiliS3cxnI+Gz9j5MEpTz2UFuXiKPJocb7gnsLHwiS05ige5BEA==\"\n},\n\"validate-npm-package-license\": {\n- \"version\": \"3.0.1\",\n- \"resolved\": \"https://registry.npmjs.org/validate-npm-package-license/-/validate-npm-package-license-3.0.1.tgz\",\n- \"integrity\": \"sha1-KAS6vnEq0zeUWaz74kdGqywwP7w=\",\n+ \"version\": \"3.0.3\",\n+ \"resolved\": \"https://registry.npmjs.org/validate-npm-package-license/-/validate-npm-package-license-3.0.3.tgz\",\n+ \"integrity\": \"sha512-63ZOUnL4SIXj4L0NixR3L1lcjO38crAbgrTpl28t8jjrfuiOBL5Iygm+60qPs/KsZGzPNg6Smnc/oY16QTjF0g==\",\n\"requires\": {\n- \"spdx-correct\": \"1.0.2\",\n- \"spdx-expression-parse\": \"1.0.4\"\n+ \"spdx-correct\": \"3.0.0\",\n+ \"spdx-expression-parse\": \"3.0.0\"\n}\n},\n\"validate-npm-package-name\": {\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: bump transitive dep validate-npm-package-license
| 1
|
chore
| null |
807,849
|
14.03.2018 16:31:32
| 25,200
|
580b2d5edfcbb84d76d75238f63f416b1e1bb0be
|
fix: ci option should not be visible in help output
|
[
{
"change_type": "MODIFY",
"diff": "@@ -5,11 +5,6 @@ module.exports = globalOptions;\nfunction globalOptions(yargs) {\n// the global options applicable to _every_ command\nconst opts = {\n- ci: {\n- // set in core/cli via .config()\n- hidden: true,\n- type: \"boolean\",\n- },\nloglevel: {\ndefaultDescription: \"info\",\ndescribe: \"What level of logs to report.\",\n@@ -41,5 +36,12 @@ function globalOptions(yargs) {\n// group options under \"Global Options:\" header\nconst globalKeys = Object.keys(opts).concat([\"help\", \"version\"]);\n- return yargs.options(opts).group(globalKeys, \"Global Options:\");\n+ return yargs\n+ .options(opts)\n+ .group(globalKeys, \"Global Options:\")\n+ .option(\"ci\", {\n+ // set in core/cli via .config()\n+ hidden: true,\n+ type: \"boolean\",\n+ });\n}\n",
"new_path": "core/global-options/index.js",
"old_path": "core/global-options/index.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
fix: ci option should not be visible in help output
| 1
|
fix
| null |
217,922
|
14.03.2018 16:53:39
| -3,600
|
dc74170334e5b92ca2992ceba7a1f0adca031202
|
feat: hide when used
closes
|
[
{
"change_type": "MODIFY",
"diff": "<mat-button-toggle [checked]=\"hideCompleted\" (change)=\"toggleHideCompleted()\">\n{{\"Hide_completed\" | translate}}\n</mat-button-toggle>\n+ <mat-button-toggle [checked]=\"hideUsed\" (change)=\"toggleHideUsed()\">\n+ {{\"Hide_used\" | translate}}\n+ </mat-button-toggle>\n<div class=\"spacer\"></div>\n</div>\n</div>\n",
"new_path": "src/app/pages/list/list-details/list-details.component.html",
"old_path": "src/app/pages/list/list-details/list-details.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -68,6 +68,8 @@ export class ListDetailsComponent extends ComponentWithSubscriptions implements\nhideCompleted = false;\n+ hideUsed = false;\n+\netime: Date = this.eorzeanTimeService.toEorzeanDate(new Date());\noutdated = false;\n@@ -120,6 +122,10 @@ export class ListDetailsComponent extends ComponentWithSubscriptions implements\nif (item.done >= item.amount && this.hideCompleted) {\nitem.hidden = true;\n}\n+ // Hide when used\n+ if (item.used >= item.amount_needed && this.hideUsed) {\n+ item.hidden = true;\n+ }\n});\nif (this.accordionState === undefined) {\nthis.initAccordion(this.listData);\n@@ -315,6 +321,11 @@ export class ListDetailsComponent extends ComponentWithSubscriptions implements\nthis.triggerFilter();\n}\n+ public toggleHideUsed(): void {\n+ this.hideUsed = !this.hideUsed;\n+ this.triggerFilter();\n+ }\n+\npublic rename(): void {\nconst dialog = this.dialog.open(NameEditPopupComponent, {data: this.listData.name});\nthis.subscriptions.push(dialog.afterClosed().map(value => {\n",
"new_path": "src/app/pages/list/list-details/list-details.component.ts",
"old_path": "src/app/pages/list/list-details/list-details.component.ts"
},
{
"change_type": "MODIFY",
"diff": "\"Add_as_collectible\": \"Add as collectable\",\n\"Compact_display\": \"Compact display\",\n\"Mute_alarms\": \"Mute alarms\",\n+ \"Hide_used\": \"Hide used rows\",\n\"WORKSHOP\": {\n\"Workshops\": \"Workshops\",\n\"Add_lists\": \"Add lists\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
},
{
"change_type": "MODIFY",
"diff": "\"Add_as_collectible\": \"Add as collectable\",\n\"Compact_display\": \"Compact display\",\n\"Mute_alarms\": \"Mute alarms\",\n+ \"Hide_used\": \"Hide used rows\",\n\"WORKSHOP\": {\n\"Workshops\": \"Workshops\",\n\"Add_lists\": \"Add lists\",\n",
"new_path": "src/assets/i18n/ja.json",
"old_path": "src/assets/i18n/ja.json"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
feat: hide when used
closes #247
| 1
|
feat
| null |
730,429
|
14.03.2018 17:12:55
| 14,400
|
a380fe98b69329ff8534649bff8b323723dc3641
|
fix(journeys): remove check for in flight flag
|
[
{
"change_type": "MODIFY",
"diff": "@@ -122,11 +122,6 @@ export function flagMessage(testObject, messageToFlag) {\n.element(`${elements.lastActivity} ${elements.flagButton}`)\n.click();\n- // Flag has a pending class while it waits for server upload\n- testObject.browser.waitUntil(() => testObject.browser\n- .element(`${elements.lastActivity} ${elements.highlighted}${elements.pendingAction} ${elements.flagButton}`)\n- .isVisible(), 1500, 'flag button did not highlight with pending state');\n-\n// Verify it is highlighted, showing it was flagged\ntestObject.browser.waitUntil(() => testObject.browser\n.element(`${elements.lastActivity} ${elements.highlighted} ${elements.flagButton}`)\n",
"new_path": "test/journeys/lib/test-helpers/space-widget/messaging.js",
"old_path": "test/journeys/lib/test-helpers/space-widget/messaging.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
fix(journeys): remove check for in flight flag
| 1
|
fix
|
journeys
|
679,913
|
14.03.2018 17:31:39
| 0
|
0d2c16fca04940c9031d169383f451a33eb85f2a
|
feat(hiccup): add auto deref() support
|
[
{
"change_type": "MODIFY",
"diff": "+import { implementsFunction } from \"@thi.ng/checks/implements-function\";\nimport { isPlainObject } from \"@thi.ng/checks/is-plain-object\";\nimport { isFunction } from \"@thi.ng/checks/is-function\";\nimport { isString } from \"@thi.ng/checks/is-string\";\n@@ -132,6 +133,9 @@ const _serialize = (tree: any, esc: boolean) => {\nif (isFunction(tree)) {\nreturn _serialize(tree(), esc);\n}\n+ if (implementsFunction(tree, \"deref\")) {\n+ return _serialize(tree.deref(), esc);\n+ }\nif (iter(tree)) {\nreturn _serializeIter(tree, esc);\n}\n",
"new_path": "packages/hiccup/src/serialize.ts",
"old_path": "packages/hiccup/src/serialize.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
feat(hiccup): add auto deref() support
| 1
|
feat
|
hiccup
|
679,913
|
14.03.2018 17:32:48
| 0
|
0fe6c44c5916d6c11fb5123fbd8e8a638cb539d9
|
feat(hdom): add auto deref() support
top-level or child element objects with `deref()` impl will be automatically resolved
|
[
{
"change_type": "MODIFY",
"diff": "@@ -104,6 +104,9 @@ export function normalizeTree(el: any, path = [0], keys = true, span = true) {\nif (isFunction(el)) {\nreturn normalizeTree(el(), path, keys, span);\n}\n+ if (implementsFunction(el, \"deref\")) {\n+ return normalizeTree(el.deref(), path.slice(), keys, span);\n+ }\nreturn span ?\n[\"span\", keys ? { key: path.join(\"-\") } : {}, el.toString()] :\nel.toString();\n",
"new_path": "packages/hdom/src/normalize.ts",
"old_path": "packages/hdom/src/normalize.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
feat(hdom): add auto deref() support
- top-level or child element objects with `deref()` impl will be automatically resolved
| 1
|
feat
|
hdom
|
791,859
|
14.03.2018 17:36:02
| -28,800
|
ce8ed566e994ccfac32f1f24a4909a78130e53a5
|
misc: clean *.screenshots.json
|
[
{
"change_type": "MODIFY",
"diff": "\"build-all:task:windows\": \"yarn build-extension && yarn build-viewer\",\n\"build-extension\": \"cd ./lighthouse-extension && yarn build\",\n\"build-viewer\": \"cd ./lighthouse-viewer && yarn build\",\n- \"clean\": \"rimraf *.report.html *.report.dom.html *.report.json *.screenshots.html *.devtoolslog.json *.trace.json || true\",\n+ \"clean\": \"rimraf *.report.html *.report.dom.html *.report.json *.screenshots.html *.screenshots.json *.devtoolslog.json *.trace.json || true\",\n\"lint\": \"[ \\\"$CI\\\" = true ] && eslint --quiet -f codeframe . || eslint .\",\n\"smoke\": \"bash lighthouse-cli/test/smokehouse/run-all-tests.sh\",\n\"coverage\": \"istanbul cover -x \\\"**/third_party/**\\\" _mocha -- $(find */test -name '*-test.js') --reporter progress --report lcovonly\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
misc: clean *.screenshots.json (#4754)
| 1
|
misc
| null |
679,913
|
14.03.2018 17:53:55
| 0
|
de839e896e0f5ca2fa03c48b6de3b2d70d746781
|
refactor(hiccup): disable deref() for attrib objects
|
[
{
"change_type": "MODIFY",
"diff": "@@ -167,8 +167,9 @@ const normalize = (tag: any[]) => {\n}\nif (tag.length > 1) {\nlet i = 1;\n- if (isPlainObject(tag[1])) {\n- Object.assign(attribs, tag[1]);\n+ const att = tag[1];\n+ if (isPlainObject(att) && !implementsFunction(att, \"deref\")) {\n+ Object.assign(attribs, att);\ni++;\n}\nif (isPlainObject(attribs.style)) {\n",
"new_path": "packages/hiccup/src/serialize.ts",
"old_path": "packages/hiccup/src/serialize.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
refactor(hiccup): disable deref() for attrib objects
| 1
|
refactor
|
hiccup
|
679,913
|
14.03.2018 17:54:18
| 0
|
28b0b578bdeb71632594509547641d77c055398f
|
refactor(hdom): disable deref() for attrib objects
|
[
{
"change_type": "MODIFY",
"diff": "@@ -9,7 +9,7 @@ import { TAG_REGEXP } from \"@thi.ng/hiccup/api\";\nexport function normalizeElement(spec: any[], keys: boolean) {\nlet match, id, clazz, attribs;\nlet tag = spec[0];\n- let hasAttribs = isPlainObject(spec[1]);\n+ let hasAttribs = isPlainObject(spec[1]) && !implementsFunction(spec[1], \"deref\");\nif (!isString(tag) || !(match = TAG_REGEXP.exec(tag))) {\nthrow new Error(`${tag} is not a valid tag name`);\n}\n",
"new_path": "packages/hdom/src/normalize.ts",
"old_path": "packages/hdom/src/normalize.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
refactor(hdom): disable deref() for attrib objects
| 1
|
refactor
|
hdom
|
679,913
|
14.03.2018 17:54:57
| 0
|
93343d638e349f811612a7d66cb9eae2dad483ec
|
feat(hiccup): support fn values in style objects
|
[
{
"change_type": "MODIFY",
"diff": "+import { isFunction } from \"@thi.ng/checks/is-function\";\n+\nexport const css = (rules: any) => {\nconst css = [];\nfor (let r in rules) {\nif (rules.hasOwnProperty(r)) {\n- css.push(r + \":\" + rules[r] + \";\");\n+ let v = rules[r];\n+ if (isFunction(v)) {\n+ v = v(rules);\n+ }\n+ css.push(r + \":\" + v + \";\");\n}\n}\nreturn css.join(\"\");\n",
"new_path": "packages/hiccup/src/css.ts",
"old_path": "packages/hiccup/src/css.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
feat(hiccup): support fn values in style objects
| 1
|
feat
|
hiccup
|
791,690
|
14.03.2018 18:08:53
| 25,200
|
22bd981081bca5ead57eceeaf10baa430b12d9bd
|
deps(browserify): bump browserify for async/await
|
[
{
"change_type": "MODIFY",
"diff": "\"build\": \"gulp build:production\"\n},\n\"devDependencies\": {\n- \"brfs\": \"^1.4.3\",\n- \"browserify\": \"^13.0.0\",\n+ \"brfs\": \"^1.5.0\",\n+ \"browserify\": \"^16.1.1\",\n\"del\": \"^2.2.0\",\n\"gulp\": \"^3.9.1\",\n\"gulp-chrome-manifest\": \"0.0.13\",\n\"gulp-debug\": \"^2.1.2\",\n- \"gulp-eslint\": \"^4.0.0\",\n+ \"gulp-eslint\": \"^4.0.2\",\n\"gulp-header\": \"^1.8.9\",\n\"gulp-livereload\": \"^3.8.1\",\n\"gulp-tap\": \"^0.1.3\",\n",
"new_path": "lighthouse-extension/package.json",
"old_path": "lighthouse-extension/package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -15,6 +15,13 @@ acorn-jsx@^3.0.0:\ndependencies:\nacorn \"^3.0.4\"\n+acorn-node@^1.3.0:\n+ version \"1.3.0\"\n+ resolved \"https://registry.yarnpkg.com/acorn-node/-/acorn-node-1.3.0.tgz#5f86d73346743810ef1269b901dbcbded020861b\"\n+ dependencies:\n+ acorn \"^5.4.1\"\n+ xtend \"^4.0.1\"\n+\nacorn@^1.0.3:\nversion \"1.2.2\"\nresolved \"https://registry.yarnpkg.com/acorn/-/acorn-1.2.2.tgz#c8ce27de0acc76d896d2b1fad3df588d9e82f014\"\n@@ -23,10 +30,14 @@ acorn@^2.7.0:\nversion \"2.7.0\"\nresolved \"https://registry.yarnpkg.com/acorn/-/acorn-2.7.0.tgz#ab6e7d9d886aaca8b085bc3312b79a198433f0e7\"\n-acorn@^3.0.4, acorn@^3.1.0:\n+acorn@^3.0.4:\nversion \"3.3.0\"\nresolved \"https://registry.yarnpkg.com/acorn/-/acorn-3.3.0.tgz#45e37fb39e8da3f25baee3ff5369e2bb5f22017a\"\n+acorn@^5.0.0, acorn@^5.4.1:\n+ version \"5.5.3\"\n+ resolved \"https://registry.yarnpkg.com/acorn/-/acorn-5.5.3.tgz#f473dd47e0277a08e28e9bec5aeeb04751f0b8c9\"\n+\nacorn@^5.1.1:\nversion \"5.1.2\"\nresolved \"https://registry.yarnpkg.com/acorn/-/acorn-5.1.2.tgz#911cb53e036807cf0fa778dc5d370fbd864246d7\"\n@@ -44,14 +55,22 @@ ajv@^5.2.0, ajv@^5.2.3:\njson-schema-traverse \"^0.3.0\"\njson-stable-stringify \"^1.0.1\"\n-amdefine@>=0.0.4:\n- version \"1.0.1\"\n- resolved \"https://registry.yarnpkg.com/amdefine/-/amdefine-1.0.1.tgz#4a5282ac164729e93619bcfd3ad151f817ce91f5\"\n+ansi-colors@^1.0.1:\n+ version \"1.1.0\"\n+ resolved \"https://registry.yarnpkg.com/ansi-colors/-/ansi-colors-1.1.0.tgz#6374b4dd5d4718ff3ce27a671a3b1cad077132a9\"\n+ dependencies:\n+ ansi-wrap \"^0.1.0\"\nansi-escapes@^3.0.0:\nversion \"3.0.0\"\nresolved \"https://registry.yarnpkg.com/ansi-escapes/-/ansi-escapes-3.0.0.tgz#ec3e8b4e9f8064fc02c3ac9b65f1c275bda8ef92\"\n+ansi-gray@^0.1.1:\n+ version \"0.1.1\"\n+ resolved \"https://registry.yarnpkg.com/ansi-gray/-/ansi-gray-0.1.1.tgz#2962cf54ec9792c48510a3deb524436861ef7251\"\n+ dependencies:\n+ ansi-wrap \"0.1.0\"\n+\nansi-regex@^0.2.0, ansi-regex@^0.2.1:\nversion \"0.2.1\"\nresolved \"https://registry.yarnpkg.com/ansi-regex/-/ansi-regex-0.2.1.tgz#0d8e946967a3d8143f93e24e298525fc1b2235f9\"\n@@ -78,6 +97,10 @@ ansi-styles@^3.1.0:\ndependencies:\ncolor-convert \"^1.9.0\"\n+ansi-wrap@0.1.0, ansi-wrap@^0.1.0:\n+ version \"0.1.0\"\n+ resolved \"https://registry.yarnpkg.com/ansi-wrap/-/ansi-wrap-0.1.0.tgz#a82250ddb0015e9a27ca82e82ea603bbfa45efaf\"\n+\narchy@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/archy/-/archy-1.0.0.tgz#f9c8c13757cc1dd7bc379ac77b2c62a5c2868c40\"\n@@ -94,10 +117,18 @@ arr-diff@^2.0.0:\ndependencies:\narr-flatten \"^1.0.1\"\n+arr-diff@^4.0.0:\n+ version \"4.0.0\"\n+ resolved \"https://registry.yarnpkg.com/arr-diff/-/arr-diff-4.0.0.tgz#d6461074febfec71e7e15235761a329a5dc7c520\"\n+\narr-flatten@^1.0.1:\nversion \"1.0.1\"\nresolved \"https://registry.yarnpkg.com/arr-flatten/-/arr-flatten-1.0.1.tgz#e5ffe54d45e19f32f216e91eb99c8ce892bb604b\"\n+arr-union@^3.1.0:\n+ version \"3.1.0\"\n+ resolved \"https://registry.yarnpkg.com/arr-union/-/arr-union-3.1.0.tgz#e39b09aea9def866a8f206e288af63919bae39c4\"\n+\narray-differ@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/array-differ/-/array-differ-1.0.0.tgz#eff52e3758249d33be402b8bb8e564bb2b5d4031\"\n@@ -150,6 +181,10 @@ assert@^1.4.0:\ndependencies:\nutil \"0.10.3\"\n+assign-symbols@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/assign-symbols/-/assign-symbols-1.0.0.tgz#59667f41fadd4f20ccbc2bb96b8d4f7f78ec0367\"\n+\nastw@^2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/astw/-/astw-2.0.0.tgz#08121ac8288d35611c0ceec663f6cd545604897d\"\n@@ -221,13 +256,13 @@ braces@^1.8.2:\npreserve \"^0.2.0\"\nrepeat-element \"^1.1.2\"\n-brfs@^1.4.3:\n- version \"1.4.3\"\n- resolved \"https://registry.yarnpkg.com/brfs/-/brfs-1.4.3.tgz#db675d6f5e923e6df087fca5859c9090aaed3216\"\n+brfs@^1.5.0:\n+ version \"1.5.0\"\n+ resolved \"https://registry.yarnpkg.com/brfs/-/brfs-1.5.0.tgz#a3822ed7a65723e056f89ff4b58e8abc63658f03\"\ndependencies:\nquote-stream \"^1.0.1\"\nresolve \"^1.1.5\"\n- static-module \"^1.1.0\"\n+ static-module \"^2.2.0\"\nthrough2 \"^2.0.0\"\nbrorand@^1.0.1:\n@@ -299,41 +334,42 @@ browserify-sign@^4.0.0:\ninherits \"^2.0.1\"\nparse-asn1 \"^5.0.0\"\n-browserify-zlib@~0.1.2:\n- version \"0.1.4\"\n- resolved \"https://registry.yarnpkg.com/browserify-zlib/-/browserify-zlib-0.1.4.tgz#bb35f8a519f600e0fa6b8485241c979d0141fb2d\"\n+browserify-zlib@~0.2.0:\n+ version \"0.2.0\"\n+ resolved \"https://registry.yarnpkg.com/browserify-zlib/-/browserify-zlib-0.2.0.tgz#2869459d9aa3be245fe8fe2ca1f46e2e7f54d73f\"\ndependencies:\n- pako \"~0.2.0\"\n+ pako \"~1.0.5\"\n-browserify@^13.0.0:\n- version \"13.3.0\"\n- resolved \"https://registry.yarnpkg.com/browserify/-/browserify-13.3.0.tgz#b5a9c9020243f0c70e4675bec8223bc627e415ce\"\n+browserify@^16.1.1:\n+ version \"16.1.1\"\n+ resolved \"https://registry.yarnpkg.com/browserify/-/browserify-16.1.1.tgz#7905ec07e0147c4d90f92001944050a6e1c2844e\"\ndependencies:\nJSONStream \"^1.0.3\"\nassert \"^1.4.0\"\nbrowser-pack \"^6.0.1\"\nbrowser-resolve \"^1.11.0\"\n- browserify-zlib \"~0.1.2\"\n- buffer \"^4.1.0\"\n+ browserify-zlib \"~0.2.0\"\n+ buffer \"^5.0.2\"\ncached-path-relative \"^1.0.0\"\n- concat-stream \"~1.5.1\"\n+ concat-stream \"^1.6.0\"\nconsole-browserify \"^1.1.0\"\nconstants-browserify \"~1.0.0\"\ncrypto-browserify \"^3.0.0\"\ndefined \"^1.0.0\"\ndeps-sort \"^2.0.0\"\n- domain-browser \"~1.1.0\"\n+ domain-browser \"^1.2.0\"\nduplexer2 \"~0.1.2\"\n- events \"~1.1.0\"\n+ events \"^2.0.0\"\nglob \"^7.1.0\"\nhas \"^1.0.0\"\nhtmlescape \"^1.1.0\"\n- https-browserify \"~0.0.0\"\n+ https-browserify \"^1.0.0\"\ninherits \"~2.0.1\"\ninsert-module-globals \"^7.0.0\"\nlabeled-stream-splicer \"^2.0.0\"\n- module-deps \"^4.0.8\"\n- os-browserify \"~0.1.1\"\n+ mkdirp \"^0.5.0\"\n+ module-deps \"^6.0.0\"\n+ os-browserify \"~0.3.0\"\nparents \"^1.0.1\"\npath-browserify \"~0.0.0\"\nprocess \"~0.11.0\"\n@@ -346,12 +382,12 @@ browserify@^13.0.0:\nshell-quote \"^1.6.1\"\nstream-browserify \"^2.0.0\"\nstream-http \"^2.0.0\"\n- string_decoder \"~0.10.0\"\n+ string_decoder \"~1.0.0\"\nsubarg \"^1.0.0\"\nsyntax-error \"^1.1.1\"\nthrough2 \"^2.0.0\"\ntimers-browserify \"^1.0.1\"\n- tty-browserify \"~0.0.0\"\n+ tty-browserify \"0.0.1\"\nurl \"~0.11.0\"\nutil \"~0.10.1\"\nvm-browserify \"~0.0.1\"\n@@ -373,13 +409,12 @@ buffer-xor@^1.0.2:\nversion \"1.0.3\"\nresolved \"https://registry.yarnpkg.com/buffer-xor/-/buffer-xor-1.0.3.tgz#26e61ed1422fb70dd42e6e36729ed51d855fe8d9\"\n-buffer@^4.1.0:\n- version \"4.9.1\"\n- resolved \"https://registry.yarnpkg.com/buffer/-/buffer-4.9.1.tgz#6d1bb601b07a4efced97094132093027c95bc298\"\n+buffer@^5.0.2:\n+ version \"5.1.0\"\n+ resolved \"https://registry.yarnpkg.com/buffer/-/buffer-5.1.0.tgz#c913e43678c7cb7c8bd16afbcddb6c5505e8f9fe\"\ndependencies:\nbase64-js \"^1.0.2\"\nieee754 \"^1.1.4\"\n- isarray \"^1.0.0\"\nbuiltin-modules@^1.0.0:\nversion \"1.1.1\"\n@@ -506,6 +541,10 @@ color-name@^1.1.1:\nversion \"1.1.3\"\nresolved \"https://registry.yarnpkg.com/color-name/-/color-name-1.1.3.tgz#a7d0558bd89c42f795dd42328f740831ca53bc25\"\n+color-support@^1.1.3:\n+ version \"1.1.3\"\n+ resolved \"https://registry.yarnpkg.com/color-support/-/color-support-1.1.3.tgz#93834379a1cc9a0c61f82f52f0d04322251bd5a2\"\n+\ncombine-source-map@~0.7.1:\nversion \"0.7.2\"\nresolved \"https://registry.yarnpkg.com/combine-source-map/-/combine-source-map-0.7.2.tgz#0870312856b307a87cc4ac486f3a9a62aeccc09e\"\n@@ -519,7 +558,7 @@ concat-map@0.0.1:\nversion \"0.0.1\"\nresolved \"https://registry.yarnpkg.com/concat-map/-/concat-map-0.0.1.tgz#d8a96bd77fd68df7793a73036a3ba0d5405d477b\"\n-concat-stream@^1.4.7, concat-stream@~1.5.0, concat-stream@~1.5.1:\n+concat-stream@^1.4.7, concat-stream@~1.5.1:\nversion \"1.5.2\"\nresolved \"https://registry.yarnpkg.com/concat-stream/-/concat-stream-1.5.2.tgz#708978624d856af41a5a741defdd261da752c266\"\ndependencies:\n@@ -535,13 +574,13 @@ concat-stream@^1.6.0:\nreadable-stream \"^2.2.2\"\ntypedarray \"^0.0.6\"\n-concat-stream@~1.4.5:\n- version \"1.4.10\"\n- resolved \"https://registry.yarnpkg.com/concat-stream/-/concat-stream-1.4.10.tgz#acc3bbf5602cb8cc980c6ac840fa7d8603e3ef36\"\n+concat-stream@~1.6.0:\n+ version \"1.6.1\"\n+ resolved \"https://registry.yarnpkg.com/concat-stream/-/concat-stream-1.6.1.tgz#261b8f518301f1d834e36342b9fea095d2620a26\"\ndependencies:\n- inherits \"~2.0.1\"\n- readable-stream \"~1.1.9\"\n- typedarray \"~0.0.5\"\n+ inherits \"^2.0.3\"\n+ readable-stream \"^2.2.2\"\n+ typedarray \"^0.0.6\"\nconcat-with-sourcemaps@*:\nversion \"1.0.4\"\n@@ -563,6 +602,10 @@ content-type@~1.0.1:\nversion \"1.0.2\"\nresolved \"https://registry.yarnpkg.com/content-type/-/content-type-1.0.2.tgz#b7d113aee7a8dd27bd21133c4dc2529df1721eed\"\n+convert-source-map@^1.5.1:\n+ version \"1.5.1\"\n+ resolved \"https://registry.yarnpkg.com/convert-source-map/-/convert-source-map-1.5.1.tgz#b8278097b9bc229365de5c62cf5fcaed8b5599e5\"\n+\nconvert-source-map@~1.1.0:\nversion \"1.1.3\"\nresolved \"https://registry.yarnpkg.com/convert-source-map/-/convert-source-map-1.1.3.tgz#4829c877e9fe49b3161f3bf3673888e204699860\"\n@@ -715,12 +758,13 @@ detect-indent@^4.0.0:\ndependencies:\nrepeating \"^2.0.0\"\n-detective@^4.0.0:\n- version \"4.3.2\"\n- resolved \"https://registry.yarnpkg.com/detective/-/detective-4.3.2.tgz#77697e2e7947ac3fe7c8e26a6d6f115235afa91c\"\n+detective@^5.0.2:\n+ version \"5.1.0\"\n+ resolved \"https://registry.yarnpkg.com/detective/-/detective-5.1.0.tgz#7a20d89236d7b331ccea65832e7123b5551bb7cb\"\ndependencies:\n- acorn \"^3.1.0\"\n+ acorn-node \"^1.3.0\"\ndefined \"^1.0.0\"\n+ minimist \"^1.1.1\"\ndiffie-hellman@^5.0.0:\nversion \"5.0.2\"\n@@ -737,17 +781,17 @@ doctrine@^2.0.0:\nesutils \"^2.0.2\"\nisarray \"^1.0.0\"\n-domain-browser@~1.1.0:\n- version \"1.1.7\"\n- resolved \"https://registry.yarnpkg.com/domain-browser/-/domain-browser-1.1.7.tgz#867aa4b093faa05f1de08c06f4d7b21fdf8698bc\"\n+domain-browser@^1.2.0:\n+ version \"1.2.0\"\n+ resolved \"https://registry.yarnpkg.com/domain-browser/-/domain-browser-1.2.0.tgz#3d31f50191a6749dd1375a7f522e823d42e54eda\"\n-duplexer2@0.0.2, duplexer2@~0.0.2:\n+duplexer2@0.0.2:\nversion \"0.0.2\"\nresolved \"https://registry.yarnpkg.com/duplexer2/-/duplexer2-0.0.2.tgz#c614dcf67e2fb14995a91711e5a617e8a60a31db\"\ndependencies:\nreadable-stream \"~1.1.9\"\n-duplexer2@^0.1.2, duplexer2@~0.1.0, duplexer2@~0.1.2:\n+duplexer2@^0.1.2, duplexer2@~0.1.0, duplexer2@~0.1.2, duplexer2@~0.1.4:\nversion \"0.1.4\"\nresolved \"https://registry.yarnpkg.com/duplexer2/-/duplexer2-0.1.4.tgz#8b12dab878c0d69e3e7891051662a32fc6bddcc1\"\ndependencies:\n@@ -786,24 +830,16 @@ escape-string-regexp@^1.0.0, escape-string-regexp@^1.0.2, escape-string-regexp@^\nversion \"1.0.5\"\nresolved \"https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz#1b61c0562190a8dff6ae3bb2cf0200ca130b86d4\"\n-escodegen@~0.0.24:\n- version \"0.0.28\"\n- resolved \"https://registry.yarnpkg.com/escodegen/-/escodegen-0.0.28.tgz#0e4ff1715f328775d6cab51ac44a406cd7abffd3\"\n+escodegen@^1.8.1, escodegen@~1.9.0:\n+ version \"1.9.1\"\n+ resolved \"https://registry.yarnpkg.com/escodegen/-/escodegen-1.9.1.tgz#dbae17ef96c8e4bedb1356f4504fa4cc2f7cb7e2\"\ndependencies:\n- esprima \"~1.0.2\"\n- estraverse \"~1.3.0\"\n- optionalDependencies:\n- source-map \">= 0.1.2\"\n-\n-escodegen@~1.3.2:\n- version \"1.3.3\"\n- resolved \"https://registry.yarnpkg.com/escodegen/-/escodegen-1.3.3.tgz#f024016f5a88e046fd12005055e939802e6c5f23\"\n- dependencies:\n- esprima \"~1.1.1\"\n- estraverse \"~1.5.0\"\n- esutils \"~1.0.0\"\n+ esprima \"^3.1.3\"\n+ estraverse \"^4.2.0\"\n+ esutils \"^2.0.2\"\n+ optionator \"^0.8.1\"\noptionalDependencies:\n- source-map \"~0.1.33\"\n+ source-map \"~0.6.1\"\neslint-scope@^3.7.1:\nversion \"3.7.1\"\n@@ -861,18 +897,14 @@ espree@^3.5.1:\nacorn \"^5.1.1\"\nacorn-jsx \"^3.0.0\"\n+esprima@^3.1.3:\n+ version \"3.1.3\"\n+ resolved \"https://registry.yarnpkg.com/esprima/-/esprima-3.1.3.tgz#fdca51cee6133895e3c88d535ce49dbff62a4633\"\n+\nesprima@^4.0.0:\nversion \"4.0.0\"\nresolved \"https://registry.yarnpkg.com/esprima/-/esprima-4.0.0.tgz#4499eddcd1110e0b218bacf2fa7f7f59f55ca804\"\n-esprima@~1.0.2:\n- version \"1.0.4\"\n- resolved \"https://registry.yarnpkg.com/esprima/-/esprima-1.0.4.tgz#9f557e08fc3b4d26ece9dd34f8fbf476b62585ad\"\n-\n-esprima@~1.1.1:\n- version \"1.1.1\"\n- resolved \"https://registry.yarnpkg.com/esprima/-/esprima-1.1.1.tgz#5b6f1547f4d102e670e140c509be6771d6aeb549\"\n-\nesquery@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/esquery/-/esquery-1.0.0.tgz#cfba8b57d7fba93f17298a8a006a04cda13d80fa\"\n@@ -890,14 +922,6 @@ estraverse@^4.0.0, estraverse@^4.1.1, estraverse@^4.2.0:\nversion \"4.2.0\"\nresolved \"https://registry.yarnpkg.com/estraverse/-/estraverse-4.2.0.tgz#0dee3fed31fcd469618ce7342099fc1afa0bdb13\"\n-estraverse@~1.3.0:\n- version \"1.3.2\"\n- resolved \"https://registry.yarnpkg.com/estraverse/-/estraverse-1.3.2.tgz#37c2b893ef13d723f276d878d60d8535152a6c42\"\n-\n-estraverse@~1.5.0:\n- version \"1.5.1\"\n- resolved \"https://registry.yarnpkg.com/estraverse/-/estraverse-1.5.1.tgz#867a3e8e58a9f84618afb6c2ddbcd916b7cbaf71\"\n-\nestraverse@~4.1.0:\nversion \"4.1.1\"\nresolved \"https://registry.yarnpkg.com/estraverse/-/estraverse-4.1.1.tgz#f6caca728933a850ef90661d0e17982ba47111a2\"\n@@ -906,10 +930,6 @@ esutils@^2.0.2:\nversion \"2.0.2\"\nresolved \"https://registry.yarnpkg.com/esutils/-/esutils-2.0.2.tgz#0abf4f1caa5bcb1f7a9d8acc6dea4faaa04bac9b\"\n-esutils@~1.0.0:\n- version \"1.0.0\"\n- resolved \"https://registry.yarnpkg.com/esutils/-/esutils-1.0.0.tgz#8151d358e20c8acc7fb745e7472c0025fe496570\"\n-\nevent-stream@^3.1.7:\nversion \"3.3.4\"\nresolved \"https://registry.yarnpkg.com/event-stream/-/event-stream-3.3.4.tgz#4ab4c9a0f5a54db9338b4c34d86bfce8f4b35571\"\n@@ -934,9 +954,9 @@ event-stream@~3.1.0:\nstream-combiner \"~0.0.4\"\nthrough \"~2.3.1\"\n-events@~1.1.0:\n- version \"1.1.1\"\n- resolved \"https://registry.yarnpkg.com/events/-/events-1.1.1.tgz#9ebdb7635ad099c70dcc4c2a1f5004288e8bd924\"\n+events@^2.0.0:\n+ version \"2.0.0\"\n+ resolved \"https://registry.yarnpkg.com/events/-/events-2.0.0.tgz#cbbb56bf3ab1ac18d71c43bb32c86255062769f2\"\nevp_bytestokey@^1.0.0:\nversion \"1.0.0\"\n@@ -962,6 +982,13 @@ expand-tilde@^1.2.1, expand-tilde@^1.2.2:\ndependencies:\nos-homedir \"^1.0.1\"\n+extend-shallow@^3.0.2:\n+ version \"3.0.2\"\n+ resolved \"https://registry.yarnpkg.com/extend-shallow/-/extend-shallow-3.0.2.tgz#26a71aaf073b39fb2127172746131c2704028db8\"\n+ dependencies:\n+ assign-symbols \"^1.0.0\"\n+ is-extendable \"^1.0.1\"\n+\nextend@^3.0.0:\nversion \"3.0.0\"\nresolved \"https://registry.yarnpkg.com/extend/-/extend-3.0.0.tgz#5a474353b9f3353ddd8176dfd37b91c83a46f1d4\"\n@@ -980,11 +1007,11 @@ extglob@^0.3.1:\ndependencies:\nis-extglob \"^1.0.0\"\n-falafel@^1.0.0:\n- version \"1.2.0\"\n- resolved \"https://registry.yarnpkg.com/falafel/-/falafel-1.2.0.tgz#c18d24ef5091174a497f318cd24b026a25cddab4\"\n+falafel@^2.1.0:\n+ version \"2.1.0\"\n+ resolved \"https://registry.yarnpkg.com/falafel/-/falafel-2.1.0.tgz#96bb17761daba94f46d001738b3cedf3a67fe06c\"\ndependencies:\n- acorn \"^1.0.3\"\n+ acorn \"^5.0.0\"\nforeach \"^2.0.5\"\nisarray \"0.0.1\"\nobject-keys \"^1.0.6\"\n@@ -996,6 +1023,14 @@ fancy-log@^1.1.0:\nchalk \"^1.1.1\"\ntime-stamp \"^1.0.0\"\n+fancy-log@^1.3.2:\n+ version \"1.3.2\"\n+ resolved \"https://registry.yarnpkg.com/fancy-log/-/fancy-log-1.3.2.tgz#f41125e3d84f2e7d89a43d06d958c8f78be16be1\"\n+ dependencies:\n+ ansi-gray \"^0.1.1\"\n+ color-support \"^1.1.3\"\n+ time-stamp \"^1.0.0\"\n+\nfast-deep-equal@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-1.0.0.tgz#96256a3bc975595eb36d82e9929d060d893439ff\"\n@@ -1284,12 +1319,13 @@ gulp-debug@^2.1.2:\nthrough2 \"^2.0.0\"\ntildify \"^1.1.2\"\n-gulp-eslint@^4.0.0:\n- version \"4.0.0\"\n- resolved \"https://registry.yarnpkg.com/gulp-eslint/-/gulp-eslint-4.0.0.tgz#16d9ea4d696e7b7a9d65eeb1aa5bc4ba0a22c7f7\"\n+gulp-eslint@^4.0.2:\n+ version \"4.0.2\"\n+ resolved \"https://registry.yarnpkg.com/gulp-eslint/-/gulp-eslint-4.0.2.tgz#18a2a6768e4404cbf3e203239cb57474168fa606\"\ndependencies:\neslint \"^4.0.0\"\n- gulp-util \"^3.0.8\"\n+ fancy-log \"^1.3.2\"\n+ plugin-error \"^1.0.0\"\ngulp-header@^1.8.9:\nversion \"1.8.9\"\n@@ -1317,7 +1353,7 @@ gulp-tap@^0.1.3:\ndependencies:\nevent-stream \"~3.1.0\"\n-gulp-util@*, gulp-util@^3.0.0, gulp-util@^3.0.2, gulp-util@^3.0.6, gulp-util@^3.0.7, gulp-util@^3.0.8:\n+gulp-util@*, gulp-util@^3.0.0, gulp-util@^3.0.2, gulp-util@^3.0.6, gulp-util@^3.0.7:\nversion \"3.0.8\"\nresolved \"https://registry.yarnpkg.com/gulp-util/-/gulp-util-3.0.8.tgz#0054e1e744502e27c04c187c3ecc505dd54bbb4f\"\ndependencies:\n@@ -1396,7 +1432,7 @@ has-gulplog@^0.1.0:\ndependencies:\nsparkles \"^1.0.0\"\n-has@^1.0.0:\n+has@^1.0.0, has@^1.0.1:\nversion \"1.0.1\"\nresolved \"https://registry.yarnpkg.com/has/-/has-1.0.1.tgz#8461733f538b0837c9361e39a9ab9e9704dc2f28\"\ndependencies:\n@@ -1429,9 +1465,9 @@ http-errors@~1.3.1:\ninherits \"~2.0.1\"\nstatuses \"1\"\n-https-browserify@~0.0.0:\n- version \"0.0.1\"\n- resolved \"https://registry.yarnpkg.com/https-browserify/-/https-browserify-0.0.1.tgz#3f91365cabe60b77ed0ebba24b454e3e09d95a82\"\n+https-browserify@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/https-browserify/-/https-browserify-1.0.0.tgz#ec06c10e0a34c0f2faf199f7fd7fc78fffd03c73\"\niconv-lite@0.4.13:\nversion \"0.4.13\"\n@@ -1567,6 +1603,12 @@ is-extendable@^0.1.1:\nversion \"0.1.1\"\nresolved \"https://registry.yarnpkg.com/is-extendable/-/is-extendable-0.1.1.tgz#62b110e289a471418e3ec36a617d472e301dfc89\"\n+is-extendable@^1.0.1:\n+ version \"1.0.1\"\n+ resolved \"https://registry.yarnpkg.com/is-extendable/-/is-extendable-1.0.1.tgz#a7470f9e426733d81bd81e1155264e3a3507cab4\"\n+ dependencies:\n+ is-plain-object \"^2.0.4\"\n+\nis-extglob@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/is-extglob/-/is-extglob-1.0.0.tgz#ac468177c4943405a092fc8f29760c6ffc6206c0\"\n@@ -1617,6 +1659,12 @@ is-plain-obj@^1.0.0:\nversion \"1.1.0\"\nresolved \"https://registry.yarnpkg.com/is-plain-obj/-/is-plain-obj-1.1.0.tgz#71a50c8429dfca773c92a390a4a03b39fcd51d3e\"\n+is-plain-object@^2.0.4:\n+ version \"2.0.4\"\n+ resolved \"https://registry.yarnpkg.com/is-plain-object/-/is-plain-object-2.0.4.tgz#2c163b3fafb1b606d9d17928f05c2a1c38e07677\"\n+ dependencies:\n+ isobject \"^3.0.1\"\n+\nis-posix-bracket@^0.1.0:\nversion \"0.1.1\"\nresolved \"https://registry.yarnpkg.com/is-posix-bracket/-/is-posix-bracket-0.1.1.tgz#3334dc79774368e92f016e6fbc0a88f5cd6e6bc4\"\n@@ -1681,6 +1729,10 @@ isobject@^2.0.0:\ndependencies:\nisarray \"1.0.0\"\n+isobject@^3.0.1:\n+ version \"3.0.1\"\n+ resolved \"https://registry.yarnpkg.com/isobject/-/isobject-3.0.1.tgz#4e431e92b11a9731636aa1f9c8d1ccbcfdab78df\"\n+\njs-tokens@^3.0.2:\nversion \"3.0.2\"\nresolved \"https://registry.yarnpkg.com/js-tokens/-/js-tokens-3.0.2.tgz#9866df395102130e38f7f996bceb65443209c25b\"\n@@ -1939,6 +1991,12 @@ lru-cache@^4.0.1:\npseudomap \"^1.0.2\"\nyallist \"^2.1.2\"\n+magic-string@^0.22.4:\n+ version \"0.22.5\"\n+ resolved \"https://registry.yarnpkg.com/magic-string/-/magic-string-0.22.5.tgz#8e9cf5afddf44385c1da5bc2a6a0dbd10b03657e\"\n+ dependencies:\n+ vlq \"^0.2.2\"\n+\nmaniver@^0.3.1:\nversion \"0.3.1\"\nresolved \"https://registry.yarnpkg.com/maniver/-/maniver-0.3.1.tgz#ef843f213432aeb1ee3b1703743fd991df474603\"\n@@ -1977,6 +2035,12 @@ meow@^3.3.0:\nredent \"^1.0.0\"\ntrim-newlines \"^1.0.0\"\n+merge-source-map@1.0.4:\n+ version \"1.0.4\"\n+ resolved \"https://registry.yarnpkg.com/merge-source-map/-/merge-source-map-1.0.4.tgz#a5de46538dae84d4114cc5ea02b4772a6346701f\"\n+ dependencies:\n+ source-map \"^0.5.6\"\n+\nmicromatch@^2.3.7:\nversion \"2.3.11\"\nresolved \"https://registry.yarnpkg.com/micromatch/-/micromatch-2.3.11.tgz#86677c97d1720b363431d04d0d15293bd38c1565\"\n@@ -2060,7 +2124,7 @@ minimist@0.0.8:\nversion \"0.0.8\"\nresolved \"https://registry.yarnpkg.com/minimist/-/minimist-0.0.8.tgz#857fcabfc3397d2625b8228262e86aa7a011b05d\"\n-minimist@^1.1.0, minimist@^1.1.3:\n+minimist@^1.1.0, minimist@^1.1.1, minimist@^1.1.3:\nversion \"1.2.0\"\nresolved \"https://registry.yarnpkg.com/minimist/-/minimist-1.2.0.tgz#a35008b20f41383eec1fb914f4cd5df79a264284\"\n@@ -2070,21 +2134,21 @@ mkdirp@^0.5.0, mkdirp@^0.5.1:\ndependencies:\nminimist \"0.0.8\"\n-module-deps@^4.0.8:\n- version \"4.1.1\"\n- resolved \"https://registry.yarnpkg.com/module-deps/-/module-deps-4.1.1.tgz#23215833f1da13fd606ccb8087b44852dcb821fd\"\n+module-deps@^6.0.0:\n+ version \"6.0.0\"\n+ resolved \"https://registry.yarnpkg.com/module-deps/-/module-deps-6.0.0.tgz#4417b49a4f4d7af79b104186e5389ea99b1dc837\"\ndependencies:\nJSONStream \"^1.0.3\"\nbrowser-resolve \"^1.7.0\"\ncached-path-relative \"^1.0.0\"\n- concat-stream \"~1.5.0\"\n+ concat-stream \"~1.6.0\"\ndefined \"^1.0.0\"\n- detective \"^4.0.0\"\n+ detective \"^5.0.2\"\nduplexer2 \"^0.1.2\"\ninherits \"^2.0.1\"\nparents \"^1.0.0\"\nreadable-stream \"^2.0.2\"\n- resolve \"^1.1.3\"\n+ resolve \"^1.4.0\"\nstream-combiner2 \"^1.1.1\"\nsubarg \"^1.0.0\"\nthrough2 \"^2.0.0\"\n@@ -2141,18 +2205,14 @@ object-assign@^3.0.0:\nversion \"3.0.0\"\nresolved \"https://registry.yarnpkg.com/object-assign/-/object-assign-3.0.0.tgz#9bedd5ca0897949bca47e7ff408062d549f587f2\"\n-object-inspect@~0.4.0:\n- version \"0.4.0\"\n- resolved \"https://registry.yarnpkg.com/object-inspect/-/object-inspect-0.4.0.tgz#f5157c116c1455b243b06ee97703392c5ad89fec\"\n+object-inspect@~1.4.0:\n+ version \"1.4.1\"\n+ resolved \"https://registry.yarnpkg.com/object-inspect/-/object-inspect-1.4.1.tgz#37ffb10e71adaf3748d05f713b4c9452f402cbc4\"\nobject-keys@^1.0.6:\nversion \"1.0.11\"\nresolved \"https://registry.yarnpkg.com/object-keys/-/object-keys-1.0.11.tgz#c54601778ad560f1142ce0e01bcca8b56d13426d\"\n-object-keys@~0.4.0:\n- version \"0.4.0\"\n- resolved \"https://registry.yarnpkg.com/object-keys/-/object-keys-0.4.0.tgz#28a6aae7428dd2c3a92f3d95f21335dd204e0336\"\n-\nobject.omit@^2.0.0:\nversion \"2.0.1\"\nresolved \"https://registry.yarnpkg.com/object.omit/-/object.omit-2.0.1.tgz#1a9c744829f39dbb858c76ca3579ae2a54ebd1fa\"\n@@ -2184,7 +2244,7 @@ onetime@^2.0.0:\ndependencies:\nmimic-fn \"^1.0.0\"\n-optionator@^0.8.2:\n+optionator@^0.8.1, optionator@^0.8.2:\nversion \"0.8.2\"\nresolved \"https://registry.yarnpkg.com/optionator/-/optionator-0.8.2.tgz#364c5e409d3f4d6301d6c0b4c05bba50180aeb64\"\ndependencies:\n@@ -2207,9 +2267,9 @@ ordered-read-streams@^0.1.0:\nversion \"0.1.0\"\nresolved \"https://registry.yarnpkg.com/ordered-read-streams/-/ordered-read-streams-0.1.0.tgz#fd565a9af8eb4473ba69b6ed8a34352cb552f126\"\n-os-browserify@~0.1.1:\n- version \"0.1.2\"\n- resolved \"https://registry.yarnpkg.com/os-browserify/-/os-browserify-0.1.2.tgz#49ca0293e0b19590a5f5de10c7f265a617d8fe54\"\n+os-browserify@~0.3.0:\n+ version \"0.3.0\"\n+ resolved \"https://registry.yarnpkg.com/os-browserify/-/os-browserify-0.3.0.tgz#854373c7f5c2315914fc9bfc6bd8238fdda1ec27\"\nos-homedir@^1.0.0, os-homedir@^1.0.1:\nversion \"1.0.2\"\n@@ -2225,9 +2285,9 @@ package-json-versionify@^1.0.4:\ndependencies:\nbrowserify-package-json \"^1.0.0\"\n-pako@~0.2.0:\n- version \"0.2.9\"\n- resolved \"https://registry.yarnpkg.com/pako/-/pako-0.2.9.tgz#f3f7522f4ef782348da8161bad9ecfd51bf83a75\"\n+pako@~1.0.5:\n+ version \"1.0.6\"\n+ resolved \"https://registry.yarnpkg.com/pako/-/pako-1.0.6.tgz#0101211baa70c4bca4a0f63f2206e97b7dfaf258\"\nparents@^1.0.0, parents@^1.0.1:\nversion \"1.0.1\"\n@@ -2294,6 +2354,10 @@ path-is-inside@^1.0.1, path-is-inside@^1.0.2:\nversion \"1.0.2\"\nresolved \"https://registry.yarnpkg.com/path-is-inside/-/path-is-inside-1.0.2.tgz#365417dede44430d1c11af61027facf074bdfc53\"\n+path-parse@^1.0.5:\n+ version \"1.0.5\"\n+ resolved \"https://registry.yarnpkg.com/path-parse/-/path-parse-1.0.5.tgz#3c1adf871ea9cd6c9431b6ea2bd74a0ff055c4c1\"\n+\npath-platform@~0.11.15:\nversion \"0.11.15\"\nresolved \"https://registry.yarnpkg.com/path-platform/-/path-platform-0.11.15.tgz#e864217f74c36850f0852b78dc7bf7d4a5721bf2\"\n@@ -2346,6 +2410,15 @@ pinkie@^2.0.0:\nversion \"2.0.4\"\nresolved \"https://registry.yarnpkg.com/pinkie/-/pinkie-2.0.4.tgz#72556b80cfa0d48a974e80e77248e80ed4f7f870\"\n+plugin-error@^1.0.0:\n+ version \"1.0.1\"\n+ resolved \"https://registry.yarnpkg.com/plugin-error/-/plugin-error-1.0.1.tgz#77016bd8919d0ac377fdcdd0322328953ca5781c\"\n+ dependencies:\n+ ansi-colors \"^1.0.1\"\n+ arr-diff \"^4.0.0\"\n+ arr-union \"^3.1.0\"\n+ extend-shallow \"^3.0.2\"\n+\nplur@^2.0.0:\nversion \"2.1.2\"\nresolved \"https://registry.yarnpkg.com/plur/-/plur-2.1.2.tgz#7482452c1a0f508e3e344eaec312c91c29dc655a\"\n@@ -2372,6 +2445,10 @@ process-nextick-args@~1.0.6:\nversion \"1.0.7\"\nresolved \"https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-1.0.7.tgz#150e20b756590ad3f91093f25a4f2ad8bff30ba3\"\n+process-nextick-args@~2.0.0:\n+ version \"2.0.0\"\n+ resolved \"https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-2.0.0.tgz#a37d732f4271b4ab1ad070d35508e8290788ffaa\"\n+\nprocess@~0.11.0:\nversion \"0.11.9\"\nresolved \"https://registry.yarnpkg.com/process/-/process-0.11.9.tgz#7bd5ad21aa6253e7da8682264f1e11d11c0318c1\"\n@@ -2418,7 +2495,7 @@ querystring@0.2.0:\nversion \"0.2.0\"\nresolved \"https://registry.yarnpkg.com/querystring/-/querystring-0.2.0.tgz#b209849203bb25df820da756e747005878521620\"\n-quote-stream@^1.0.1:\n+quote-stream@^1.0.1, quote-stream@~1.0.2:\nversion \"1.0.2\"\nresolved \"https://registry.yarnpkg.com/quote-stream/-/quote-stream-1.0.2.tgz#84963f8c9c26b942e153feeb53aae74652b7e0b2\"\ndependencies:\n@@ -2426,13 +2503,6 @@ quote-stream@^1.0.1:\nminimist \"^1.1.3\"\nthrough2 \"^2.0.0\"\n-quote-stream@~0.0.0:\n- version \"0.0.0\"\n- resolved \"https://registry.yarnpkg.com/quote-stream/-/quote-stream-0.0.0.tgz#cde29e94c409b16e19dc7098b89b6658f9721d3b\"\n- dependencies:\n- minimist \"0.0.8\"\n- through2 \"~0.4.1\"\n-\nrandomatic@^1.1.3:\nversion \"1.1.6\"\nresolved \"https://registry.yarnpkg.com/randomatic/-/randomatic-1.1.6.tgz#110dcabff397e9dcff7c0789ccc0a49adf1ec5bb\"\n@@ -2473,7 +2543,7 @@ read-pkg@^1.0.0:\nnormalize-package-data \"^2.3.2\"\npath-type \"^1.0.0\"\n-\"readable-stream@>=1.0.33-1 <1.1.0-0\", readable-stream@~1.0.17, readable-stream@~1.0.27-1:\n+\"readable-stream@>=1.0.33-1 <1.1.0-0\":\nversion \"1.0.34\"\nresolved \"https://registry.yarnpkg.com/readable-stream/-/readable-stream-1.0.34.tgz#125820e34bc842d2f2aaafafe4c2916ee32c157c\"\ndependencies:\n@@ -2526,6 +2596,18 @@ readable-stream@~2.0.0:\nstring_decoder \"~0.10.x\"\nutil-deprecate \"~1.0.1\"\n+readable-stream@~2.3.3:\n+ version \"2.3.5\"\n+ resolved \"https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.3.5.tgz#b4f85003a938cbb6ecbce2a124fb1012bd1a838d\"\n+ dependencies:\n+ core-util-is \"~1.0.0\"\n+ inherits \"~2.0.3\"\n+ isarray \"~1.0.0\"\n+ process-nextick-args \"~2.0.0\"\n+ safe-buffer \"~5.1.1\"\n+ string_decoder \"~1.0.3\"\n+ util-deprecate \"~1.0.1\"\n+\nrechoir@^0.6.2:\nversion \"0.6.2\"\nresolved \"https://registry.yarnpkg.com/rechoir/-/rechoir-0.6.2.tgz#85204b54dba82d5742e28c96756ef43af50e3384\"\n@@ -2586,10 +2668,16 @@ resolve@1.1.7:\nversion \"1.1.7\"\nresolved \"https://registry.yarnpkg.com/resolve/-/resolve-1.1.7.tgz#203114d82ad2c5ed9e8e0411b3932875e889e97b\"\n-resolve@^1.1.3, resolve@^1.1.4, resolve@^1.1.5, resolve@^1.1.6, resolve@^1.1.7:\n+resolve@^1.1.4, resolve@^1.1.5, resolve@^1.1.6, resolve@^1.1.7:\nversion \"1.2.0\"\nresolved \"https://registry.yarnpkg.com/resolve/-/resolve-1.2.0.tgz#9589c3f2f6149d1417a40becc1663db6ec6bc26c\"\n+resolve@^1.4.0:\n+ version \"1.5.0\"\n+ resolved \"https://registry.yarnpkg.com/resolve/-/resolve-1.5.0.tgz#1f09acce796c9a762579f31b2c1cc4c3cddf9f36\"\n+ dependencies:\n+ path-parse \"^1.0.5\"\n+\nrestore-cursor@^2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/restore-cursor/-/restore-cursor-2.0.0.tgz#9f7ee287f82fd326d4fd162923d62129eee0dfaf\"\n@@ -2702,15 +2790,17 @@ sort-json@^1.2.0:\ndependencies:\ndetect-indent \"^4.0.0\"\n-\"source-map@>= 0.1.2\", source-map@^0.5.1, source-map@~0.5.3:\n+source-map@^0.5.1, source-map@~0.5.3:\nversion \"0.5.6\"\nresolved \"https://registry.yarnpkg.com/source-map/-/source-map-0.5.6.tgz#75ce38f52bf0733c5a7f0c118d81334a2bb5f412\"\n-source-map@~0.1.33:\n- version \"0.1.43\"\n- resolved \"https://registry.yarnpkg.com/source-map/-/source-map-0.1.43.tgz#c24bc146ca517c1471f5dacbe2571b2b7f9e3346\"\n- dependencies:\n- amdefine \">=0.0.4\"\n+source-map@^0.5.6:\n+ version \"0.5.7\"\n+ resolved \"https://registry.yarnpkg.com/source-map/-/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc\"\n+\n+source-map@~0.6.1:\n+ version \"0.6.1\"\n+ resolved \"https://registry.yarnpkg.com/source-map/-/source-map-0.6.1.tgz#74722af32e9614e9c287a8d0bbde48b5e2f1a263\"\nsparkles@^1.0.0:\nversion \"1.0.0\"\n@@ -2746,27 +2836,30 @@ sprintf-js@^1.0.3, sprintf-js@~1.0.2:\nversion \"1.0.3\"\nresolved \"https://registry.yarnpkg.com/sprintf-js/-/sprintf-js-1.0.3.tgz#04e6926f662895354f3dd015203633b857297e2c\"\n-static-eval@~0.2.0:\n- version \"0.2.4\"\n- resolved \"https://registry.yarnpkg.com/static-eval/-/static-eval-0.2.4.tgz#b7d34d838937b969f9641ca07d48f8ede263ea7b\"\n+static-eval@^2.0.0:\n+ version \"2.0.0\"\n+ resolved \"https://registry.yarnpkg.com/static-eval/-/static-eval-2.0.0.tgz#0e821f8926847def7b4b50cda5d55c04a9b13864\"\ndependencies:\n- escodegen \"~0.0.24\"\n+ escodegen \"^1.8.1\"\n-static-module@^1.1.0:\n- version \"1.3.1\"\n- resolved \"https://registry.yarnpkg.com/static-module/-/static-module-1.3.1.tgz#79071d340e4419e4ab5ce87976a9eb67250c8493\"\n- dependencies:\n- concat-stream \"~1.4.5\"\n- duplexer2 \"~0.0.2\"\n- escodegen \"~1.3.2\"\n- falafel \"^1.0.0\"\n- has \"^1.0.0\"\n- object-inspect \"~0.4.0\"\n- quote-stream \"~0.0.0\"\n- readable-stream \"~1.0.27-1\"\n+static-module@^2.2.0:\n+ version \"2.2.2\"\n+ resolved \"https://registry.yarnpkg.com/static-module/-/static-module-2.2.2.tgz#496e9bf1d29cb5177a30fae224511953d7dd291b\"\n+ dependencies:\n+ concat-stream \"~1.6.0\"\n+ convert-source-map \"^1.5.1\"\n+ duplexer2 \"~0.1.4\"\n+ escodegen \"~1.9.0\"\n+ falafel \"^2.1.0\"\n+ has \"^1.0.1\"\n+ magic-string \"^0.22.4\"\n+ merge-source-map \"1.0.4\"\n+ object-inspect \"~1.4.0\"\n+ quote-stream \"~1.0.2\"\n+ readable-stream \"~2.3.3\"\nshallow-copy \"~0.0.1\"\n- static-eval \"~0.2.0\"\n- through2 \"~0.4.1\"\n+ static-eval \"^2.0.0\"\n+ through2 \"~2.0.3\"\nstatuses@1:\nversion \"1.3.1\"\n@@ -2820,11 +2913,11 @@ string-width@^2.1.0, string-width@^2.1.1:\nis-fullwidth-code-point \"^2.0.0\"\nstrip-ansi \"^4.0.0\"\n-string_decoder@~0.10.0, string_decoder@~0.10.x:\n+string_decoder@~0.10.x:\nversion \"0.10.31\"\nresolved \"https://registry.yarnpkg.com/string_decoder/-/string_decoder-0.10.31.tgz#62e203bc41766c6c28c9fc84301dab1c5310fa94\"\n-string_decoder@~1.0.3:\n+string_decoder@~1.0.0, string_decoder@~1.0.3:\nversion \"1.0.3\"\nresolved \"https://registry.yarnpkg.com/string_decoder/-/string_decoder-1.0.3.tgz#0fc67d7c141825de94282dd536bec6b9bce860ab\"\ndependencies:\n@@ -2926,20 +3019,13 @@ through2@^0.6.1:\nreadable-stream \">=1.0.33-1 <1.1.0-0\"\nxtend \">=4.0.0 <4.1.0-0\"\n-through2@^2.0.0, through2@^2.0.1:\n+through2@^2.0.0, through2@^2.0.1, through2@~2.0.3:\nversion \"2.0.3\"\nresolved \"https://registry.yarnpkg.com/through2/-/through2-2.0.3.tgz#0004569b37c7c74ba39c43f3ced78d1ad94140be\"\ndependencies:\nreadable-stream \"^2.1.5\"\nxtend \"~4.0.1\"\n-through2@~0.4.1:\n- version \"0.4.2\"\n- resolved \"https://registry.yarnpkg.com/through2/-/through2-0.4.2.tgz#dbf5866031151ec8352bb6c4db64a2292a840b9b\"\n- dependencies:\n- readable-stream \"~1.0.17\"\n- xtend \"~2.1.1\"\n-\nthrough@2, \"through@>=2.2.7 <3\", through@^2.3.6, through@~2.3, through@~2.3.1:\nversion \"2.3.8\"\nresolved \"https://registry.yarnpkg.com/through/-/through-2.3.8.tgz#0dd4c9ffaabc357960b1b724115d7e0e86a2e1f5\"\n@@ -2978,9 +3064,9 @@ tryit@^1.0.1:\nversion \"1.0.3\"\nresolved \"https://registry.yarnpkg.com/tryit/-/tryit-1.0.3.tgz#393be730a9446fd1ead6da59a014308f36c289cb\"\n-tty-browserify@~0.0.0:\n- version \"0.0.0\"\n- resolved \"https://registry.yarnpkg.com/tty-browserify/-/tty-browserify-0.0.0.tgz#a157ba402da24e9bf957f9aa69d524eed42901a6\"\n+tty-browserify@0.0.1:\n+ version \"0.0.1\"\n+ resolved \"https://registry.yarnpkg.com/tty-browserify/-/tty-browserify-0.0.1.tgz#3f05251ee17904dfd0677546670db9651682b811\"\ntype-check@~0.3.2:\nversion \"0.3.2\"\n@@ -3084,6 +3170,10 @@ vinyl@^0.5.0:\nclone-stats \"^0.0.1\"\nreplace-ext \"0.0.1\"\n+vlq@^0.2.2:\n+ version \"0.2.3\"\n+ resolved \"https://registry.yarnpkg.com/vlq/-/vlq-0.2.3.tgz#8f3e4328cf63b1540c0d67e1b2778386f8975b26\"\n+\nvm-browserify@~0.0.1:\nversion \"0.0.4\"\nresolved \"https://registry.yarnpkg.com/vm-browserify/-/vm-browserify-0.0.4.tgz#5d7ea45bbef9e4a6ff65f95438e0a87c357d5a73\"\n@@ -3126,16 +3216,10 @@ write@^0.2.1:\ndependencies:\nmkdirp \"^0.5.1\"\n-\"xtend@>=4.0.0 <4.1.0-0\", xtend@^4.0.0, xtend@~4.0.1:\n+\"xtend@>=4.0.0 <4.1.0-0\", xtend@^4.0.0, xtend@^4.0.1, xtend@~4.0.1:\nversion \"4.0.1\"\nresolved \"https://registry.yarnpkg.com/xtend/-/xtend-4.0.1.tgz#a5c6d532be656e23db820efb943a1f04998d63af\"\n-xtend@~2.1.1:\n- version \"2.1.2\"\n- resolved \"https://registry.yarnpkg.com/xtend/-/xtend-2.1.2.tgz#6efecc2a4dad8e6962c4901b337ce7ba87b5d28b\"\n- dependencies:\n- object-keys \"~0.4.0\"\n-\nyallist@^2.1.2:\nversion \"2.1.2\"\nresolved \"https://registry.yarnpkg.com/yallist/-/yallist-2.1.2.tgz#1c11f9218f076089a47dd512f93c6699a6a81d52\"\n",
"new_path": "lighthouse-extension/yarn.lock",
"old_path": "lighthouse-extension/yarn.lock"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
deps(browserify): bump browserify for async/await (#4767)
| 1
|
deps
|
browserify
|
815,746
|
14.03.2018 18:14:31
| -7,200
|
9d96e7aea2a7166b55175c65b7f5e4e70e46cb80
|
feat: custom multi label template
closes
|
[
{
"change_type": "MODIFY",
"diff": "<layout-sidenav></layout-sidenav>\n</div>\n<main class=\"col-12 col-md-9 col-xl-8 py-md-4 pl-md-4 bd-content\">\n- <h2 class=\"bd-title\">\n- {{title}}\n- </h2>\n+ <div class=\"d-flex\">\n+ <div style=\"flex:1;\">\n+ <h2 class=\"bd-title\">{{title}}</h2>\n+ </div>\n+ <div style=\"align-self:center;\">\n+ <a href=\"{{exampleSourceUrl}}\" target=\"_blank\"><i class=\"fa fa-code\"></i> Example source code</a>\n+ </div>\n+ </div>\n+\n<div class=\"card\">\n<div class=\"card-body\">\n<router-outlet></router-outlet>\n",
"new_path": "demo/app/app.component.html",
"old_path": "demo/app/app.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -16,6 +16,7 @@ export class AppComponent {\ntitle: string;\nversion: string = window['ngSelectVersion'];\n+ exampleSourceUrl: string;\nconstructor(private router: Router,\nprivate activatedRoute: ActivatedRoute,\n@@ -41,6 +42,7 @@ export class AppComponent {\n.subscribe((event) => {\nthis.title = event['title'];\nthis.titleService.setTitle(this.title);\n+ this.exampleSourceUrl = `https://github.com/ng-select/ng-select/tree/master/demo/app/examples/${event['fileName']}`;\n});\n}\n",
"new_path": "demo/app/app.component.ts",
"old_path": "demo/app/app.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -31,18 +31,20 @@ export const appRoutes: Routes = [\nredirectTo: '/data-sources',\npathMatch: 'full'\n},\n- { path: 'data-sources', component: DataSourceComponent, data: { title: 'Data sources' } },\n- { path: 'forms', component: ReactiveFormsComponent, data: { title: 'Reactive forms' } },\n- { path: 'bindings', component: SelectBindingsComponent, data: { title: 'Data bindings' } },\n- { path: 'filter', component: SelectSearchComponent, data: { title: 'Filter and autocomplete'} },\n- { path: 'tags', component: SelectTagsComponent, data: { title: 'Tags'} },\n- { path: 'templates', component: SelectWithTemplatesComponent, data: { title: 'Templates'} },\n- { path: 'multiselect', component: SelectMultiComponent, data: { title: 'Multiselect'} },\n- { path: 'events', component: SelectEventsComponent, data: { title: 'Output events'} },\n- { path: 'virtual-scroll', component: VirtualScrollComponent, data: { title: 'Virtual scroll'} },\n- { path: 'dropdown-position', component: DropdownPositionsComponent, data: { title: 'Dropdown position'} },\n- { path: 'append-to-element', component: AppendToComponent, data: { title: 'Append to element'} },\n- { path: 'grouping', component: SelectGroupsComponent, data: { title: 'Grouping'} },\n+ { path: 'data-sources', component: DataSourceComponent, data: { title: 'Data sources', fileName: 'data-source.component.ts' } },\n+ { path: 'forms', component: ReactiveFormsComponent, data: { title: 'Reactive forms', fileName: 'reactive-forms.component.ts' } },\n+ { path: 'bindings', component: SelectBindingsComponent, data: { title: 'Data bindings', fileName: 'bindings.component.ts' } },\n+ { path: 'filter', component: SelectSearchComponent, data: { title: 'Filter and autocomplete', fileName: 'search.component.ts' } },\n+ { path: 'tags', component: SelectTagsComponent, data: { title: 'Tags', fileName: 'tags.component.ts' } },\n+ { path: 'templates', component: SelectWithTemplatesComponent, data: { title: 'Templates', fileName: 'custom-templates.component.ts' } },\n+ { path: 'multiselect', component: SelectMultiComponent, data: { title: 'Multiselect', fileName: 'multi.component.ts' } },\n+ { path: 'events', component: SelectEventsComponent, data: { title: 'Output events', fileName: 'events.component.ts' } },\n+ // tslint:disable-next-line:max-line-length\n+ { path: 'virtual-scroll', component: VirtualScrollComponent, data: { title: 'Virtual scroll', fileName: 'virtual-scroll.component.ts' } },\n+ { path: 'dropdown-position', component: DropdownPositionsComponent, data: { title: 'Dropdown position', fileName: 'dropdown-positions.component.ts' } },\n+ // tslint:disable-next-line:max-line-length\n+ { path: 'append-to-element', component: AppendToComponent, data: { title: 'Append to element', fileName: 'append-to.component.ts' } },\n+ { path: 'grouping', component: SelectGroupsComponent, data: { title: 'Grouping', fileName: 'groups.component.ts' } },\n];\n@NgModule({\n",
"new_path": "demo/app/app.module.ts",
"old_path": "demo/app/app.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -48,7 +48,7 @@ import { distinctUntilChanged, debounceTime, switchMap } from 'rxjs/operators'\n</p>\n<hr>\n- <label>Custom label and option and optgroup</label>\n+ <label>Custom label option and optgroup</label>\n---html,true\n<ng-select [items]=\"cities3\" groupBy=\"avatar\" [(ngModel)]=\"selectedCity3\" bindLabel=\"name\" bindValue=\"name\">\n<ng-template ng-label-tmp let-item=\"item\">\n@@ -56,8 +56,7 @@ import { distinctUntilChanged, debounceTime, switchMap } from 'rxjs/operators'\n<b>{{item.name}}</b>\n</ng-template>\n<ng-template ng-optgroup-tmp let-item=\"item\" let-index=\"index\">\n- <img height=\"15\" width=\"15\" [src]=\"item.avatar\"/>\n- <b [innerHTML]=\"item.name\"></b>\n+ City group logo <img height=\"15\" width=\"15\" [src]=\"item.avatar\"/>\n</ng-template>\n<ng-template ng-option-tmp let-item=\"item\" let-index=\"index\" let-search=\"searchTerm\">\n<b [innerHTML]=\"item.name\" [ngOptionHighlight]=\"search\"></b>\n",
"new_path": "demo/app/examples/custom-templates.component.ts",
"old_path": "demo/app/examples/custom-templates.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -1139,6 +1139,22 @@ describe('NgSelectComponent', function () {\n});\n}));\n+ it('should display custom multiple label template', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectBasicTestCmp,\n+ `<ng-select [items]=\"cities\" [multiple]=\"true\" [(ngModel)]=\"selectedCities\">\n+ <ng-template ng-multi-label-tmp let-items=\"items\">\n+ <div class=\"custom-multi-label\">selected {{items.length}}</div>\n+ </ng-template>\n+ </ng-select>`);\n+\n+ fixture.componentInstance.selectedCities = [fixture.componentInstance.cities[0]];\n+ tickAndDetectChanges(fixture);\n+\n+ const el = fixture.debugElement.query(By.css('.custom-multi-label')).nativeElement;\n+ expect(el.innerHTML).toBe('selected 1');\n+ }));\n+\nit('should display custom footer and header template', async(() => {\nconst fixture = createTestingModule(\nNgSelectBasicTestCmp,\n@@ -1163,7 +1179,6 @@ describe('NgSelectComponent', function () {\n});\n}));\n-\nit('should display custom loading and no data found template', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectFilterTestCmp,\n@@ -1183,8 +1198,6 @@ describe('NgSelectComponent', function () {\n</ng-template>\n</ng-select>`);\n-\n-\nfixture.whenStable().then(() => {\nfixture.componentInstance.cities = [];\nfixture.componentInstance.citiesLoading = true;\n@@ -1201,7 +1214,6 @@ describe('NgSelectComponent', function () {\ntickAndDetectChanges(fixture);\nconst notFoundOptions = fixture.debugElement.queryAll(By.css('.custom-notfound'));\nexpect(notFoundOptions.length).toBe(1);\n-\n});\n}));\n@@ -1219,8 +1231,6 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\n-\n-\nfixture.whenStable().then(() => {\nfixture.componentInstance.cities = [];\nfixture.componentInstance.select.open();\n@@ -1230,9 +1240,7 @@ describe('NgSelectComponent', function () {\ntickAndDetectChanges(fixture);\nconst loadingOption = fixture.debugElement.queryAll(By.css('.custom-typeforsearch'));\nexpect(loadingOption.length).toBe(1);\n-\n});\n-\n}));\nit('should create items from ng-option', fakeAsync(() => {\n@@ -2113,6 +2121,7 @@ function createTestingModule<T>(cmp: Type<T>, template: string): ComponentFixtur\nclass NgSelectBasicTestCmp {\n@ViewChild(NgSelectComponent) select: NgSelectComponent;\nselectedCity: { id: number; name: string };\n+ selectedCities: { id: number; name: string }[];\nmultiple = false;\ndisabled = false;\ndropdownPosition = 'bottom';\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -35,7 +35,8 @@ import {\nNgOptgroupTemplateDirective,\nNgNotFoundTemplateDirective,\nNgTypeToSearchTemplateDirective,\n- NgLoadingTextTemplateDirective\n+ NgLoadingTextTemplateDirective,\n+ NgMultiLabelTemplateDirective\n} from './ng-templates.directive';\nimport { NgOption, KeyCode, NgSelectConfig } from './ng-select.types';\n@@ -111,6 +112,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n@ContentChild(NgOptionTemplateDirective, { read: TemplateRef }) optionTemplate: TemplateRef<any>;\n@ContentChild(NgOptgroupTemplateDirective, { read: TemplateRef }) optgroupTemplate: TemplateRef<any>;\n@ContentChild(NgLabelTemplateDirective, { read: TemplateRef }) labelTemplate: TemplateRef<any>;\n+ @ContentChild(NgMultiLabelTemplateDirective, { read: TemplateRef }) multiLabelTemplate: TemplateRef<any>;\n@ContentChild(NgHeaderTemplateDirective, { read: TemplateRef }) headerTemplate: TemplateRef<any>;\n@ContentChild(NgFooterTemplateDirective, { read: TemplateRef }) footerTemplate: TemplateRef<any>;\n@ContentChild(NgNotFoundTemplateDirective, { read: TemplateRef }) notFoundTemplate: TemplateRef<any>;\n@@ -156,6 +158,10 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nreturn this.itemsList.value;\n}\n+ get selectedValues() {\n+ return this.selectedItems.map(x => x.value);\n+ }\n+\nget isLoading() {\nreturn this.loading || this._typeaheadLoading;\n}\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -9,7 +9,8 @@ import {\nNgOptgroupTemplateDirective,\nNgNotFoundTemplateDirective,\nNgTypeToSearchTemplateDirective,\n- NgLoadingTextTemplateDirective\n+ NgLoadingTextTemplateDirective,\n+ NgMultiLabelTemplateDirective\n} from './ng-templates.directive';\nimport { NgOptionComponent } from './ng-option.component';\nimport { NgOptionHighlightDirective } from './ng-option-highlight.directive' ;\n@@ -26,6 +27,7 @@ import { VirtualScrollService } from './virtual-scroll.service';\nNgOptgroupTemplateDirective,\nNgOptionTemplateDirective,\nNgLabelTemplateDirective,\n+ NgMultiLabelTemplateDirective,\nNgHeaderTemplateDirective,\nNgFooterTemplateDirective,\nNgNotFoundTemplateDirective,\n@@ -42,6 +44,7 @@ import { VirtualScrollService } from './virtual-scroll.service';\nNgOptgroupTemplateDirective,\nNgOptionTemplateDirective,\nNgLabelTemplateDirective,\n+ NgMultiLabelTemplateDirective,\nNgHeaderTemplateDirective,\nNgFooterTemplateDirective,\nNgNotFoundTemplateDirective,\n",
"new_path": "src/ng-select/ng-select.module.ts",
"old_path": "src/ng-select/ng-select.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -18,6 +18,12 @@ export class NgLabelTemplateDirective {\n}\n}\n+@Directive({ selector: '[ng-multi-label-tmp]' })\n+export class NgMultiLabelTemplateDirective {\n+ constructor(public template: TemplateRef<any>) {\n+ }\n+}\n+\n@Directive({ selector: '[ng-header-tmp]' })\nexport class NgHeaderTemplateDirective {\nconstructor(public template: TemplateRef<any>) {\n@@ -36,14 +42,12 @@ export class NgNotFoundTemplateDirective {\n}\n}\n-\n@Directive({ selector: '[ng-typetosearch-tmp]' })\nexport class NgTypeToSearchTemplateDirective {\nconstructor(public template: TemplateRef<any>) {\n}\n}\n-\n@Directive({ selector: '[ng-loadingtext-tmp]' })\nexport class NgLoadingTextTemplateDirective {\nconstructor(public template: TemplateRef<any>) {\n",
"new_path": "src/ng-select/ng-templates.directive.ts",
"old_path": "src/ng-select/ng-templates.directive.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
feat: custom multi label template (#350)
closes #336, #344
| 1
|
feat
| null |
815,746
|
14.03.2018 18:15:11
| -7,200
|
32e9bc8704138f1a2333d7c11ac5568290e645bb
|
chore(release): 0.29.0
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.29.0\"></a>\n+# [0.29.0](https://github.com/ng-select/ng-select/compare/v0.28.1...v0.29.0) (2018-03-14)\n+\n+\n+### Features\n+\n+* custom multi label template ([#350](https://github.com/ng-select/ng-select/issues/350)) ([9d96e7a](https://github.com/ng-select/ng-select/commit/9d96e7a)), closes [#336](https://github.com/ng-select/ng-select/issues/336) [#344](https://github.com/ng-select/ng-select/issues/344)\n+\n+\n+\n<a name=\"0.28.1\"></a>\n## [0.28.1](https://github.com/ng-select/ng-select/compare/v0.28.0...v0.28.1) (2018-03-13)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"$schema\": \"../node_modules/ng-packagr/package.schema.json\",\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.28.1\",\n+ \"version\": \"0.29.0\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.29.0
| 1
|
chore
|
release
|
807,842
|
14.03.2018 18:15:16
| -3,600
|
619c477a196e40eb1078cec43750f1540416f477
|
fix(utils): Use safe relative path when calling git diff
|
[
{
"change_type": "MODIFY",
"diff": "@@ -259,6 +259,21 @@ describe(\"GitUtilities\", () => {\nopts\n);\n});\n+\n+ it(\"returns list of files changed since commit at location when location equals cwd\", () => {\n+ const cwd = process.cwd();\n+ const opts = { cwd };\n+ const testLocation = cwd;\n+\n+ ChildProcessUtilities.execSync.mockReturnValueOnce(\"files\");\n+\n+ expect(GitUtilities.diffSinceIn(\"v1.0.0\", testLocation, opts)).toBe(\"files\");\n+ expect(ChildProcessUtilities.execSync).lastCalledWith(\n+ \"git\",\n+ [\"diff\", \"--name-only\", \"v1.0.0\", \"--\", \".\"],\n+ opts\n+ );\n+ });\n});\ndescribe(\".getWorkspaceRoot()\", () => {\n",
"new_path": "core/git-utils/__tests__/git-utils.test.js",
"old_path": "core/git-utils/__tests__/git-utils.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -134,7 +134,9 @@ function describeTag(ref, opts) {\n}\nfunction diffSinceIn(committish, location, opts) {\n- const formattedLocation = slash(path.relative(opts.cwd, location));\n+ const relativePath = path.relative(opts.cwd, location);\n+ const nonEmptyRelativePath = relativePath === \"\" ? \".\" : relativePath;\n+ const formattedLocation = slash(nonEmptyRelativePath);\nlog.silly(\"diffSinceIn\", committish, formattedLocation);\n",
"new_path": "core/git-utils/index.js",
"old_path": "core/git-utils/index.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
fix(utils): Use safe relative path when calling git diff (#1323)
| 1
|
fix
|
utils
|
679,913
|
14.03.2018 18:29:25
| 0
|
c85b1f818b771092e6259881d32c9b5051e66a1e
|
refactor(examples): remove obsolete .deref() calls
|
[
{
"change_type": "MODIFY",
"diff": "@@ -65,6 +65,7 @@ const effects: IObjectOf<EffectDef> = {\n// main app component\nconst app = () => {\n+ // create event bus with empty state (null arg)\nconst bus = new EventBus(null, events, effects);\n// kick off JSON request\n@@ -73,6 +74,7 @@ const app = () => {\n// root component function\nreturn () => {\nif (bus.processQueue()) {\n+ // the event bus' state can be obtained via `deref()`\nconst { json, status } = bus.deref();\nreturn [\"div\",\n[\"p#status\", { class: status[0] }, `status: ${status[1]}`],\n",
"new_path": "examples/async-effect/src/index.ts",
"old_path": "examples/async-effect/src/index.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -48,7 +48,7 @@ function defcard(card: CardFn, state?: IAtom<any>, title?: string, parent?: stri\nconst root = card(state);\n// kick off hdom renderloop\n- start(parent, () => [\"div.card\", [\"h3\", title], [\"div.body\", root, [\"pre\", json.deref()]]]);\n+ start(parent, () => [\"div.card\", [\"h3\", title], [\"div.body\", root, [\"pre\", json]]]);\n}\n/**\n@@ -175,7 +175,7 @@ function bmi(state: IAtom<any>) {\n// perform initial calculation\ncalc();\n- return () => [\"div\", height, weight, bmi, [\"div\", bmiViz.deref()]];\n+ return () => [\"div\", height, weight, bmi, [\"div\", bmiViz]];\n}\n/**\n",
"new_path": "examples/devcards/src/index.ts",
"old_path": "examples/devcards/src/index.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -114,7 +114,7 @@ const app = () => {\n[\"div\",\nbutton(bus, [EV_ADD_COUNTER], \"add counter\", \"addcounter\"),\n[\"div\", ...counters],\n- [\"pre\", json.deref()]];\n+ [\"pre\", json]];\nreturn () => {\n// here we do an optional fail fast check, a useful & energy saving\n",
"new_path": "examples/interceptor-basics/src/index.ts",
"old_path": "examples/interceptor-basics/src/index.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -39,7 +39,7 @@ const uiViews = {\nlogin: () =>\n[\"div#login\",\n[\"h1\", \"Login\"],\n- error.deref() ? [\"div.error\", error.deref()] : undefined,\n+ error.deref() ? [\"div.error\", error] : undefined,\n[\"input\", { type: \"text\", onchange: setUser }],\n[\"button\", { onclick: loginUser }, \"Login\"]\n],\n@@ -77,7 +77,7 @@ const currView = db.addView(\n// app root component\nconst app = () =>\n[\"div#app\",\n- currView.deref(),\n+ currView,\n[\"footer\", \"Made with @thi.ng/atom and @thi.ng/hdom\"]];\nstart(document.body, app);\n",
"new_path": "examples/login-form/src/index.ts",
"old_path": "examples/login-form/src/index.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -19,6 +19,6 @@ export function debugContainer(app: App, ui: any, debug: number, json: IView<any\n},\ndebug ? \"close \\u25bc\" : \"open \\u25b2\"\n],\n- [\"pre\", ui.code, json.deref()]\n+ [\"pre\", ui.code, json]\n];\n}\n",
"new_path": "examples/router-basics/src/components/debug-container.ts",
"old_path": "examples/router-basics/src/components/debug-container.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -16,7 +16,7 @@ class DemoApp extends App {\nreturn [\"div\", ui.root,\n[\"div\", ui.column.content[debug],\n[nav, this, ui.nav],\n- this.views.routeComponent.deref()],\n+ this.views.routeComponent],\n[debugContainer, this, ui, debug, this.views.json],\n];\n}\n",
"new_path": "examples/router-basics/src/index.ts",
"old_path": "examples/router-basics/src/index.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
refactor(examples): remove obsolete .deref() calls
| 1
|
refactor
|
examples
|
815,745
|
14.03.2018 18:38:06
| -7,200
|
68b37265a606bb4f2ed836fd0a016ce83ea9d350
|
fix: don't reset items while selecting
|
[
{
"change_type": "MODIFY",
"diff": "@@ -1627,6 +1627,24 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.select.filterValue).toBe(null);\n}));\n+ it('should not reset items when selecting option', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectFilterTestCmp,\n+ `<ng-select [items]=\"cities\"\n+ bindLabel=\"name\"\n+ [(ngModel)]=\"selectedCity\"\n+ [multiple]=\"true\">\n+ </ng-select>`);\n+\n+ const clearFilter = spyOn(fixture.componentInstance.select.itemsList, 'clearFilter');\n+ tickAndDetectChanges(fixture);\n+\n+ fixture.componentInstance.select.filterValue = null;\n+ selectOption(fixture, KeyCode.ArrowDown, 1);\n+ tickAndDetectChanges(fixture);\n+ expect(clearFilter).not.toHaveBeenCalled();\n+ }));\n+\nit('should filter grouped items', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectGroupingTestCmp,\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -573,6 +573,10 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\nprivate _clearSearch() {\n+ if (!this.filterValue) {\n+ return;\n+ }\n+\nthis.filterValue = null;\nthis.itemsList.clearFilter();\n}\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: don't reset items while selecting
| 1
|
fix
| null |
807,978
|
14.03.2018 19:08:48
| -7,200
|
8eef9ff3ebb45654460260f6fa9cb3b4563f6713
|
feat(publish): Add logging when `--skip-git` or `--skip-npm` are passed
|
[
{
"change_type": "MODIFY",
"diff": "@@ -348,6 +348,14 @@ describe(\"PublishCommand\", () => {\nexpect(publishedTagInDirectories(testDir)).toMatchSnapshot(\"npm published\");\n});\n+\n+ it(\"should display a message that git is skipped\", async () => {\n+ const testDir = await initFixture(\"normal\");\n+ await lernaPublish(testDir)(\"--skip-git\");\n+\n+ const logMessages = loggingOutput(\"info\");\n+ expect(logMessages).toContain(\"Skipping git commit/push\");\n+ });\n});\n/** =========================================================================\n@@ -368,6 +376,14 @@ describe(\"PublishCommand\", () => {\n// FIXME\n// expect(GitUtilities.pushWithTags).lastCalledWith(\"origin\", [\"v1.0.1\"]);\n});\n+\n+ it(\"should display a message that npm is skipped\", async () => {\n+ const testDir = await initFixture(\"normal\");\n+ await lernaPublish(testDir)(\"--skip-npm\");\n+\n+ const logMessages = loggingOutput(\"info\");\n+ expect(logMessages).toContain(\"Skipping publish to registry\");\n+ });\n});\n/** =========================================================================\n@@ -405,6 +421,15 @@ describe(\"PublishCommand\", () => {\nexpect(npmDistTag.remove).not.toBeCalled();\nexpect(npmDistTag.add).not.toBeCalled();\n});\n+\n+ it(\"should display a message that npm and git are skipped\", async () => {\n+ const testDir = await initFixture(\"normal\");\n+ await lernaPublish(testDir)(\"--skip-git\", \"--skip-npm\");\n+\n+ const logMessages = loggingOutput(\"info\");\n+ expect(logMessages).toContain(\"Skipping git commit/push\");\n+ expect(logMessages).toContain(\"Skipping publish to registry\");\n+ });\n});\n/** =========================================================================\n",
"new_path": "commands/publish/__tests__/publish-command.test.js",
"old_path": "commands/publish/__tests__/publish-command.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -154,12 +154,16 @@ class PublishCommand extends Command {\nif (this.gitEnabled) {\ntasks.push(() => this.commitAndTagUpdates());\n+ } else {\n+ this.logger.info(\"execute\", \"Skipping git commit/push\");\n}\ntasks.push(() => this.resolveLocalDependencyLinks());\ntasks.push(() => this.annotateGitHead());\n- if (!this.options.skipNpm) {\n+ if (this.options.skipNpm) {\n+ this.logger.info(\"execute\", \"Skipping publish to registry\");\n+ } else {\ntasks.push(() => this.publishPackagesToNpm());\n}\n",
"new_path": "commands/publish/index.js",
"old_path": "commands/publish/index.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
feat(publish): Add logging when `--skip-git` or `--skip-npm` are passed (#1319)
| 1
|
feat
|
publish
|
217,922
|
14.03.2018 20:31:12
| -3,600
|
90e7d5c7c8767e180d8c9964d64d8dd4229fc2f8
|
fix: error in select all button when user has no masterbooks
|
[
{
"change_type": "MODIFY",
"diff": "@@ -26,6 +26,8 @@ export class MasterbooksPopupComponent {\n}\ncheckAll(ids: number[]): void {\n+ // We set a default value if it's currently undefined.\n+ this.data.user.masterbooks = this.data.user.masterbooks || [];\nids.forEach(id => {\nif (this.data.user.masterbooks.indexOf(id) === -1) {\nthis.data.user.masterbooks.push(id);\n",
"new_path": "src/app/pages/profile/masterbooks-popup/masterbooks-popup.component.ts",
"old_path": "src/app/pages/profile/masterbooks-popup/masterbooks-popup.component.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
fix: error in select all button when user has no masterbooks
| 1
|
fix
| null |
679,913
|
14.03.2018 21:30:30
| 0
|
25d0c309fea7a0294e3fa4c8cab9b86516ae395b
|
test(hiccup): add deref tests
|
[
{
"change_type": "MODIFY",
"diff": "\"test\": \"rm -rf build && tsc -p test && nyc mocha build/test/*.js\"\n},\n\"devDependencies\": {\n+ \"@thi.ng/atom\": \"^0.12.1\",\n\"@types/mocha\": \"^2.2.48\",\n\"@types/node\": \"^9.4.6\",\n\"mocha\": \"^5.0.0\",\n",
"new_path": "packages/hiccup/package.json",
"old_path": "packages/hiccup/package.json"
},
{
"change_type": "MODIFY",
"diff": "import * as assert from \"assert\";\n+import { Atom } from \"@thi.ng/atom\";\nimport { serialize } from \"../src/index\";\n@@ -218,4 +219,27 @@ describe(\"serialize\", () => {\n`<ul><li>a</li><li>b</li></ul>`\n);\n+ check(\n+ \"deref toplevel\",\n+ new Atom([\"a\"]),\n+ `<a></a>`\n+ );\n+\n+ check(\n+ \"deref child\",\n+ [\"a\", new Atom([\"b\"])],\n+ `<a><b></b></a>`\n+ );\n+\n+ check(\n+ \"deref fn result\",\n+ [\"a\", () => new Atom([\"b\"])],\n+ `<a><b></b></a>`\n+ );\n+\n+ check(\n+ \"style fn attribs\",\n+ [\"div\", { style: { a: (x) => x.b, b: 2 } }],\n+ `<div style=\"a:2;b:2;\"></div>`\n+ );\n});\n",
"new_path": "packages/hiccup/test/index.ts",
"old_path": "packages/hiccup/test/index.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
test(hiccup): add deref tests
| 1
|
test
|
hiccup
|
679,913
|
14.03.2018 21:31:01
| 0
|
3a0e97d24b5aa3d353aeb062c1e4238401787db3
|
test(hdom): add tests, update package
|
[
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@thi.ng/hdom\",\n\"version\": \"2.1.1\",\n- \"description\": \"TODO\",\n+ \"description\": \"Lightweight vanilla ES6 UI component & virtual DOM system\",\n\"main\": \"./index.js\",\n\"typings\": \"./index.d.ts\",\n\"repository\": \"https://github.com/thi-ng/umbrella\",\n\"author\": \"Karsten Schmidt <k+npm@thi.ng>\",\n\"license\": \"Apache-2.0\",\n\"scripts\": {\n- \"build\": \"yarn run clean && tsc --declaration\",\n- \"clean\": \"rm -rf *.js *.d.ts build doc\",\n+ \"build\": \"yarn clean && tsc --declaration\",\n+ \"clean\": \"rm -rf *.js *.d.ts .nyc_output build coverage doc\",\n+ \"cover\": \"yarn test && nyc report --reporter=lcov\",\n\"doc\": \"node_modules/.bin/typedoc --mode modules --out doc src\",\n- \"pub\": \"yarn run build && yarn publish --access public\",\n- \"test\": \"rm -rf build && tsc -p test && mocha build/test/*.js\"\n+ \"pub\": \"yarn build && yarn publish --access public\",\n+ \"test\": \"rm -rf build && tsc -p test && nyc mocha build/test/*.js\"\n},\n\"devDependencies\": {\n+ \"@thi.ng/atom\": \"^0.12.1\",\n\"@types/mocha\": \"^2.2.48\",\n\"@types/node\": \"^9.4.6\",\n\"mocha\": \"^5.0.0\",\n",
"new_path": "packages/hdom/package.json",
"old_path": "packages/hdom/package.json"
},
{
"change_type": "MODIFY",
"diff": "-// import * as assert from \"assert\";\n+import * as assert from \"assert\";\n-// import * as hdom from \"../src/index\";\n+import { Atom } from \"@thi.ng/atom/atom\";\n+import { map } from \"@thi.ng/iterators/map\";\n+import { range } from \"@thi.ng/iterators/range\";\n+import { normalizeTree } from \"../src/normalize\";\n-describe(\"hdom\", function () {\n- it(\"tests pending\");\n+function _check(a, b) {\n+ assert.deepEqual(normalizeTree(a, [], false, false), b);\n+}\n+\n+function check(id, a, b) {\n+ it(id, () => _check(a, b));\n+}\n+\n+describe(\"hdom\", () => {\n+\n+ check(\n+ \"undefined\",\n+ undefined,\n+ undefined\n+ );\n+\n+ check(\n+ \"null\",\n+ null,\n+ undefined\n+ );\n+\n+ check(\n+ \"empty tree\",\n+ [],\n+ undefined\n+ );\n+\n+ check(\n+ \"simple div\",\n+ [\"div\", \"foo\"],\n+ [\"div\", {}, \"foo\"]\n+ );\n+\n+ check(\n+ \"emmet id\",\n+ [\"div#foo\", \"hi\"],\n+ [\"div\", { id: \"foo\" }, \"hi\"]\n+ );\n+\n+ check(\n+ \"emmet id + id attr\",\n+ [\"div#foo\", { id: \"bar\" }],\n+ [\"div\", { id: \"foo\" }]\n+ );\n+\n+ check(\n+ \"emmet id + class\",\n+ [\"div#id.foo.bar\", \"hi\"],\n+ [\"div\", { id: \"id\", class: \"foo bar\" }, \"hi\"]\n+ );\n+ check(\n+ \"emmet class + class attr\",\n+ [\"div.foo.bar\", { class: \"baz\" }],\n+ [\"div\", { class: \"baz foo bar\" }]\n+ );\n+\n+ check(\n+ \"emmet id + class + attrib\",\n+ [\"div#id.foo.bar\", { extra: 23 }, \"hi\"],\n+ [\"div\", { id: \"id\", class: \"foo bar\", extra: 23 }, \"hi\"]\n+ );\n+\n+ check(\n+ \"root fn\",\n+ () => [\"div\"],\n+ [\"div\", {}]\n+ );\n+\n+ check(\n+ \"tag fn w/ args\",\n+ [(id, body) => [\"div#\" + id, body], \"foo\", \"bar\"],\n+ [\"div\", { id: \"foo\" }, \"bar\"]\n+ );\n+\n+ check(\n+ \"child fn\",\n+ [\"div\", (x) => [\"span\", x]],\n+ [\"div\", {}, [\"span\", {}]]\n+ );\n+\n+ check(\n+ \"child arrays\",\n+ [\"section\", [[\"div\", \"foo\"], \"bar\"]],\n+ [\"section\", {}, [\"div\", {}, \"foo\"], \"bar\"]\n+ );\n+\n+ check(\n+ \"iterator\",\n+ [\"div\", map((x) => [`div#id${x}`, x], range(3))],\n+ [\"div\", {}, [\"div\", { id: \"id0\" }, 0], [\"div\", { id: \"id1\" }, 1], [\"div\", { id: \"id2\" }, 2]]\n+ );\n+\n+ check(\n+ \"deref toplevel\",\n+ new Atom([\"a\"]),\n+ [\"a\", {}]\n+ );\n+\n+ check(\n+ \"deref child\",\n+ [\"a\", new Atom([\"b\"])],\n+ [\"a\", {}, [\"b\", {}]]\n+ );\n+\n+ it(\"lifecycle\", () => {\n+ const res: any = [\"div\", {}];\n+ res.__init = res.__release = undefined;\n+ res.__args = [];\n+ assert.deepEqual(\n+ normalizeTree([{ render: () => [\"div\"] }], [], false, false),\n+ res\n+ );\n+ });\n});\n",
"new_path": "packages/hdom/test/index.ts",
"old_path": "packages/hdom/test/index.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
test(hdom): add tests, update package
| 1
|
test
|
hdom
|
679,913
|
14.03.2018 21:57:11
| 0
|
6deb4e3307634294a737b490daa28201468faa18
|
build(examples): update hdom deps
|
[
{
"change_type": "MODIFY",
"diff": "\"dependencies\": {\n\"@thi.ng/api\": \"^2.0.4\",\n\"@thi.ng/atom\": \"^0.10.0\",\n- \"@thi.ng/hdom\": \"^2.1.1\"\n+ \"@thi.ng/hdom\": \"^2.2.0\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/async-effect/package.json",
"old_path": "examples/async-effect/package.json"
},
{
"change_type": "MODIFY",
"diff": "},\n\"dependencies\": {\n\"@thi.ng/api\": \"^2.0.4\",\n- \"@thi.ng/hdom\": \"^2.1.1\",\n+ \"@thi.ng/hdom\": \"^2.2.0\",\n\"@thi.ng/hdom-components\": \"^1.0.1\",\n\"@thi.ng/transducers\": \"^1.6.2\"\n}\n",
"new_path": "examples/cellular-automata/package.json",
"old_path": "examples/cellular-automata/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"webpack\": \"^3.11.0\"\n},\n\"dependencies\": {\n- \"@thi.ng/hdom\": \"^2.1.1\"\n+ \"@thi.ng/hdom\": \"^2.2.0\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/dashboard/package.json",
"old_path": "examples/dashboard/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"dependencies\": {\n\"@thi.ng/api\": \"^2.0.4\",\n\"@thi.ng/atom\": \"^0.10.0\",\n- \"@thi.ng/hdom\": \"^2.1.1\"\n+ \"@thi.ng/hdom\": \"^2.2.0\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/devcards/package.json",
"old_path": "examples/devcards/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"webpack\": \"^3.11.0\"\n},\n\"dependencies\": {\n- \"@thi.ng/hdom\": \"^2.1.1\"\n+ \"@thi.ng/hdom\": \"^2.2.0\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/hdom-basics/package.json",
"old_path": "examples/hdom-basics/package.json"
},
{
"change_type": "MODIFY",
"diff": "},\n\"dependencies\": {\n\"@thi.ng/api\": \"^2.0.4\",\n- \"@thi.ng/hdom\": \"^2.1.1\",\n+ \"@thi.ng/hdom\": \"^2.2.0\",\n\"@thi.ng/rstream\": \"^1.0.13\",\n\"@thi.ng/transducers\": \"^1.6.2\"\n}\n",
"new_path": "examples/hdom-benchmark/package.json",
"old_path": "examples/hdom-benchmark/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"dependencies\": {\n\"@thi.ng/api\": \"^2.0.4\",\n\"@thi.ng/atom\": \"^0.10.0\",\n- \"@thi.ng/hdom\": \"^2.1.1\"\n+ \"@thi.ng/hdom\": \"^2.2.0\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/interceptor-basics/package.json",
"old_path": "examples/interceptor-basics/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"webpack\": \"^3.11.0\"\n},\n\"dependencies\": {\n- \"@thi.ng/hdom\": \"^2.1.1\",\n+ \"@thi.ng/hdom\": \"^2.2.0\",\n\"@thi.ng/transducers\": \"^1.6.2\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/json-components/package.json",
"old_path": "examples/json-components/package.json"
},
{
"change_type": "MODIFY",
"diff": "},\n\"dependencies\": {\n\"@thi.ng/atom\": \"^0.10.0\",\n- \"@thi.ng/hdom\": \"^2.1.1\"\n+ \"@thi.ng/hdom\": \"^2.2.0\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/login-form/package.json",
"old_path": "examples/login-form/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"dependencies\": {\n\"@thi.ng/api\": \"^2.0.4\",\n\"@thi.ng/atom\": \"^0.12.1\",\n- \"@thi.ng/hdom\": \"^2.1.1\",\n+ \"@thi.ng/hdom\": \"^2.2.0\",\n\"@thi.ng/router\": \"^0.1.0\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/router-basics/package.json",
"old_path": "examples/router-basics/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"webpack\": \"^3.11.0\"\n},\n\"dependencies\": {\n- \"@thi.ng/hdom\": \"^2.1.1\",\n+ \"@thi.ng/hdom\": \"^2.2.0\",\n\"@thi.ng/transducers\": \"^1.6.2\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/svg-particles/package.json",
"old_path": "examples/svg-particles/package.json"
},
{
"change_type": "MODIFY",
"diff": "},\n\"dependencies\": {\n\"@thi.ng/atom\": \"^0.10.0\",\n- \"@thi.ng/hdom\": \"^2.1.1\",\n+ \"@thi.ng/hdom\": \"^2.2.0\",\n\"@thi.ng/transducers\": \"^1.6.2\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/todo-list/package.json",
"old_path": "examples/todo-list/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"webpack\": \"^3.11.0\"\n},\n\"dependencies\": {\n- \"@thi.ng/hdom\": \"^2.1.1\",\n+ \"@thi.ng/hdom\": \"^2.2.0\",\n\"@thi.ng/hdom-components\": \"^1.0.1\"\n}\n}\n\\ No newline at end of file\n",
"new_path": "examples/webgl/package.json",
"old_path": "examples/webgl/package.json"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
build(examples): update hdom deps
| 1
|
build
|
examples
|
815,746
|
15.03.2018 08:05:01
| -7,200
|
2b88868a220524400e8178e965d322c764d94658
|
chore(release): 0.29.1
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.29.1\"></a>\n+## [0.29.1](https://github.com/ng-select/ng-select/compare/v0.29.0...v0.29.1) (2018-03-15)\n+\n+\n+### Bug Fixes\n+\n+* don't reset items while selecting ([68b3726](https://github.com/ng-select/ng-select/commit/68b3726))\n+* skip writeValue handling if value is empty ([#351](https://github.com/ng-select/ng-select/issues/351)) ([9d5811e](https://github.com/ng-select/ng-select/commit/9d5811e)), closes [#348](https://github.com/ng-select/ng-select/issues/348)\n+\n+\n+\n<a name=\"0.29.0\"></a>\n# [0.29.0](https://github.com/ng-select/ng-select/compare/v0.28.1...v0.29.0) (2018-03-14)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"$schema\": \"../node_modules/ng-packagr/package.schema.json\",\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.29.0\",\n+ \"version\": \"0.29.1\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.29.1
| 1
|
chore
|
release
|
217,922
|
15.03.2018 09:41:18
| -3,600
|
8988489681f6536f0cac98159dfb011580051c42
|
style: properly apply theme on dialog boxes and cdk elements
|
[
{
"change_type": "MODIFY",
"diff": "@@ -22,6 +22,7 @@ import fontawesome from '@fortawesome/fontawesome';\nimport {faDiscord, faFacebookF, faGithub} from '@fortawesome/fontawesome-free-brands';\nimport {faCalculator} from '@fortawesome/fontawesome-free-solid';\nimport {PushNotificationsService} from 'ng-push';\n+import {OverlayContainer} from '@angular/cdk/overlay';\ndeclare const ga: Function;\n@@ -69,7 +70,13 @@ export class AppComponent implements OnInit {\nmedia: ObservableMedia,\npublic settings: SettingsService,\npublic helpService: HelpService,\n- private push: PushNotificationsService) {\n+ private push: PushNotificationsService,\n+ overlayContainer: OverlayContainer) {\n+\n+ settings.themeChange$.subscribe(change => {\n+ overlayContainer.getContainerElement().classList.remove(`${change.previous}-theme`);\n+ overlayContainer.getContainerElement().classList.add(`${change.next}-theme`);\n+ });\nfontawesome.library.add(faDiscord, faFacebookF, faGithub, faCalculator);\n",
"new_path": "src/app/app.component.ts",
"old_path": "src/app/app.component.ts"
},
{
"change_type": "MODIFY",
"diff": "import {Injectable} from '@angular/core';\n+import {Subject} from 'rxjs/Subject';\n@Injectable()\nexport class SettingsService {\nprivate cache: { [id: string]: string };\n+ public themeChange$ = new Subject<{ previous: string, next: string }>();\n+\nconstructor() {\nthis.cache = JSON.parse(localStorage.getItem('settings')) || {};\n}\n@@ -38,6 +41,7 @@ export class SettingsService {\n}\npublic set theme(theme: string) {\n+ this.themeChange$.next({previous: this.theme, next: theme});\nthis.setSetting('theme', theme);\n}\n",
"new_path": "src/app/pages/settings/settings.service.ts",
"old_path": "src/app/pages/settings/settings.service.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
style: properly apply theme on dialog boxes and cdk elements
| 1
|
style
| null |
217,922
|
15.03.2018 10:37:53
| -3,600
|
c1f246510378c33bcb9299928069859411850702
|
chore: [WIP] gathering location page
|
[
{
"change_type": "DELETE",
"diff": "-import { async, ComponentFixture, TestBed } from '@angular/core/testing';\n-\n-import { GatheringLocationComponent } from './gathering-location.component';\n-\n-describe('GatheringLocationComponent', () => {\n- let component: GatheringLocationComponent;\n- let fixture: ComponentFixture<GatheringLocationComponent>;\n-\n- beforeEach(async(() => {\n- TestBed.configureTestingModule({\n- declarations: [ GatheringLocationComponent ]\n- })\n- .compileComponents();\n- }));\n-\n- beforeEach(() => {\n- fixture = TestBed.createComponent(GatheringLocationComponent);\n- component = fixture.componentInstance;\n- fixture.detectChanges();\n- });\n-\n- it('should create', () => {\n- expect(component).toBeTruthy();\n- });\n-});\n",
"new_path": null,
"old_path": "src/app/pages/gathering-location/gathering-location/gathering-location.component.spec.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore: [WIP] gathering location page
#203
| 1
|
chore
| null |
217,922
|
15.03.2018 10:49:34
| -3,600
|
6a40cbe4a4b14bf107eeb2429b8772d59219ef8d
|
fix: missing translation in list layout dialog box
|
[
{
"change_type": "MODIFY",
"diff": "\"Filter\": \"Filter\",\n\"Panel_name\": \"Bereichsname\",\n\"Order_by\": \"Sortiere nach\",\n- \"Order\": \"Sortierung\"\n+ \"Order\": \"Sortierung\",\n+ \"Logic_gate\": \"Logic gate\"\n},\n\"HELP\": {\n\"Title\" : \"Listendetails\",\n",
"new_path": "src/assets/i18n/de.json",
"old_path": "src/assets/i18n/de.json"
},
{
"change_type": "MODIFY",
"diff": "\"Filter\": \"Filter\",\n\"Panel_name\": \"Panel name\",\n\"Order_by\": \"Sort by\",\n- \"Order\": \"Order\"\n+ \"Order\": \"Order\",\n+ \"Logic_gate\": \"Logic gate\"\n},\n\"HELP\": {\n\"Title\": \"List details\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
},
{
"change_type": "MODIFY",
"diff": "\"Filter\": \"Filter\",\n\"Panel_name\": \"Panel name\",\n\"Order_by\": \"Sort by\",\n- \"Order\": \"Order\"\n+ \"Order\": \"Order\",\n+ \"Logic_gate\": \"Logic gate\"\n},\n\"HELP\": {\n\"Title\" : \"List details\",\n",
"new_path": "src/assets/i18n/ja.json",
"old_path": "src/assets/i18n/ja.json"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
fix: missing translation in list layout dialog box
| 1
|
fix
| null |
791,723
|
15.03.2018 12:14:27
| 25,200
|
202d04b3359526cbe49531f03c61258002da073c
|
core(emulation): update Chrome userAgent to 66
|
[
{
"change_type": "MODIFY",
"diff": "@@ -28,7 +28,7 @@ const NEXUS5X_EMULATION_METRICS = {\nconst NEXUS5X_USERAGENT = {\nuserAgent: 'Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5 Build/MRA58N) AppleWebKit/537.36' +\n- '(KHTML, like Gecko) Chrome/61.0.3116.0 Mobile Safari/537.36',\n+ '(KHTML, like Gecko) Chrome/66.0.3359.30 Mobile Safari/537.36',\n};\n/**\n",
"new_path": "lighthouse-core/lib/emulation.js",
"old_path": "lighthouse-core/lib/emulation.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(emulation): update Chrome userAgent to 66 (#4779)
| 1
|
core
|
emulation
|
217,879
|
15.03.2018 14:12:54
| -3,600
|
13833163152faf7bcf7700c615e54253f36c13b1
|
style: add few themes and defects fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -77,6 +77,7 @@ export class AppComponent implements OnInit {\noverlayContainer.getContainerElement().classList.remove(`${change.previous}-theme`);\noverlayContainer.getContainerElement().classList.add(`${change.next}-theme`);\n});\n+ overlayContainer.getContainerElement().classList.add(`${settings.theme}-theme`);\nfontawesome.library.add(faDiscord, faFacebookF, faGithub, faCalculator, faBell);\n",
"new_path": "src/app/app.component.ts",
"old_path": "src/app/app.component.ts"
},
{
"change_type": "MODIFY",
"diff": "-<h2 mat-dialog-title>{{title}}</h2>\n+<div class=\"help-dialog-container\">\n+ <h2 mat-dialog-title class=\"primary-background\">{{title}} </h2>\n<div mat-dialog-content>\n<ng-content></ng-content>\n</div>\n-<div mat-dialog-actions>\n- <button mat-dialog-close color=\"accent\" mat-button>{{\"Ok\" | translate}}</button>\n+ <div mat-dialog-actions class=\"primary-background\">\n+ <button mat-dialog-close mat-raised-button class=\"close\" color=\"primary\">{{\"Ok\" | translate}}</button>\n+ </div>\n</div>\n",
"new_path": "src/app/core/component/help-dialog/help-dialog.component.html",
"old_path": "src/app/core/component/help-dialog/help-dialog.component.html"
},
{
"change_type": "MODIFY",
"diff": "+.help-dialog-container {\n+ margin: -24px;\n+\n+ h2 {\n+ padding-top: 10px;\n+ padding-bottom: 10px;\n+ margin-bottom: 0;\n+ text-align: center;\n+ font-size: 23px;\n+ }\n+\n+ ::ng-deep .mat-list .mat-list-item {\n+ height: auto;\n+ }\n+\n+ ::ng-deep .mat-dialog-content {\n+ display: block;\n+ padding: 14px;\n+ margin: 0;\n+ max-height: 65vh;\n+ overflow: auto;\n+ -webkit-overflow-scrolling: touch;\n+ }\n+\n+ .close {\n+ background-color: rgba(66, 66, 66, 0.1);\n+ width: 200px;\n+ margin: 0 auto;\n+ }\n+}\n",
"new_path": "src/app/core/component/help-dialog/help-dialog.component.scss",
"old_path": "src/app/core/component/help-dialog/help-dialog.component.scss"
},
{
"change_type": "MODIFY",
"diff": "matTooltip=\"{{'Requirements_for_craft' | translate}}\"\nmatTooltipPosition=\"above\" [ngClass]=\"{'requirements-button':true, 'compact': settings.compactLists}\"\n(click)=\"openRequirementsPopup()\">\n- <mat-icon color=\"accent\">assignment</mat-icon>\n+ <mat-icon color=\"primary\">assignment</mat-icon>\n</button>\n<mat-icon *ngIf=\"!hasBook()\" matTooltip=\"{{'LIST_DETAILS.No_book' | translate}}\" matTooltipPosition=\"above\"\ncolor=\"warn\">\n",
"new_path": "src/app/modules/item/item/item.component.html",
"old_path": "src/app/modules/item/item/item.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -16,7 +16,10 @@ export class SettingsComponent {\n// {name: 'Lodestone', value: 'LODESTONE'}, TODO\n];\n- themes = ['dark-orange', 'light-orange', 'dark-teal', 'light-teal'];\n+ themes = ['dark-orange', 'light-orange', 'light-teal', 'dark-teal', 'light-brown',\n+ 'light-amber', 'dark-amber', 'light-green', 'dark-lime', 'light-lime',\n+ 'dark-cyan', 'light-cyan', 'dark-indigo', 'dark-indigo', 'dark-blue', 'light-blue',\n+ 'dark-deep-purple', 'light-deep-purple', 'dark-red', 'light-red', 'dark-pink', 'light-pink'];\nlocale: string;\n",
"new_path": "src/app/pages/settings/settings/settings.component.ts",
"old_path": "src/app/pages/settings/settings/settings.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -10,6 +10,10 @@ body {\nmargin: 0;\nfont-family: Roboto, \"Helvetica Neue\", sans-serif;\n}\n+//Dialog background darker opacity\n+.cdk-overlay-dark-backdrop {\n+ background: rgba(0, 0, 0, 0.81);\n+}\n// Helper class\n.spacer {\n",
"new_path": "src/styles.scss",
"old_path": "src/styles.scss"
},
{
"change_type": "MODIFY",
"diff": "@include mat-core();\n+@mixin text-color($theme) {\n+ @if map-get($theme, is-dark) {\n+ color: white;\n+ } @else {\n+ color: black;\n+ }\n+}\n+\n// Custom mixins for theming\n@mixin theme-background($theme) {\n$accent: map-get($theme, accent);\n$primary: map-get($theme, primary);\n+ $warn: map-get($theme, warn);\n+ $foreground: map-get($theme, foreground);\n+ $background: map-get($theme, background);\n.accent-background {\nbackground: mat-color($accent);\n- color: black;\n+ @include text-color($theme);\n.mat-card-subtitle {\n- color: black;\n+ @include text-color($theme);\n}\n}\n.primary-background {\nbackground: mat-color($primary);\n- color: black;\n+ @include text-color($theme);\n.mat-card-subtitle {\n- color: black;\n+ @include text-color($theme);\n}\n}\n+\n+ .warn-background {\n+ background: mat-color($warn);\n+ @include text-color($theme);\n+ .mat-card-subtitle {\n+ @include text-color($theme);\n}\n+ }\n+}\n+\n+\n@mixin expansion-panel-accent($theme) {\nmat-expansion-panel.accent {\n$foreground: map-get($theme, foreground);\nbackground: mat-color($accent);\n.mat-expansion-panel-header-title {\n- color: black;\n+ @include text-color($theme);\n}\n.mat-expansion-panel-header-description {\n- color: black;\n+ @include text-color($theme);\nopacity: .7;\n}\n.mat-expansion-indicator::after {\n- color: black;\n+ @include text-color($theme);\nopacity: .7;\n}\n}\n@mixin color-fixes($theme) {\na {\n- @if map-get($theme, is-dark) {\n- color: white;\n- } @else {\n- color: black;\n+ @include text-color($theme);\n}\n}\n-}\n-\n+// Palette\n+// orange\n$primary-orange: mat-palette($mat-orange, 700);\n$accent-orange: mat-palette($mat-teal, 500);\n+// teal\n$primary-teal: mat-palette($mat-teal, 300);\n$accent-teal: mat-palette($mat-indigo, 100);\n+// brown\n+$primary-brown: mat-palette($mat-brown, 500);\n+$accent-brown: mat-palette($mat-brown, 200);\n+// amber\n+$primary-amber: mat-palette($mat-amber, 500);\n+$accent-amber: mat-palette($mat-amber, 100);\n+// green\n+$primary-green: mat-palette($mat-green, 800);\n+$accent-green: mat-palette($mat-green, 400);\n+// lime\n+$primary-lime: mat-palette($mat-lime, 800);\n+$accent-lime: mat-palette($mat-lime, 500);\n+// cyan\n+$primary-cyan: mat-palette($mat-cyan, 700);\n+$accent-cyan: mat-palette($mat-cyan, 300);\n+// indigo\n+$primary-indigo: mat-palette($mat-indigo, 500);\n+$accent-indigo: mat-palette($mat-indigo, 200);\n+// blue\n+$primary-blue: mat-palette($mat-blue, 600);\n+$accent-blue: mat-palette($mat-blue, 200);\n+// deep-purple\n+$primary-deep-purple: mat-palette($mat-deep-purple, 500);\n+$accent-deep-purple: mat-palette($mat-deep-purple, 200);\n+// red\n+$primary-red: mat-palette($mat-red, 900);\n+$accent-red: mat-palette($mat-red, 600);\n+$warn-red: mat-palette($mat-deep-purple, 900);\n+// pink\n+$primary-pink: mat-palette($mat-pink, 500);\n+$accent-pink: mat-palette($mat-pink, 300);\n+\n$warn: mat-palette($mat-red, 600);\n+\n+// Dark or Light theme\n+// orange\n$dark-theme: mat-dark-theme($primary-orange, $accent-orange, $warn);\n$light-orange-theme: mat-light-theme($primary-orange, $accent-orange, $warn);\n+// teal\n$light-teal-theme: mat-light-theme($primary-teal, $accent-teal, $warn);\n$dark-teal-theme: mat-dark-theme($primary-teal, $accent-teal, $warn);\n+// brown\n+$light-brown-theme: mat-light-theme($primary-brown, $accent-brown, $warn);\n+// amber\n+$dark-amber-theme: mat-dark-theme($primary-amber, $accent-amber, $warn);\n+$light-amber-theme: mat-light-theme($primary-amber, $accent-amber, $warn);\n+// green\n+$light-green-theme: mat-light-theme($primary-green, $accent-green, $warn);\n+// lime\n+$dark-lime-theme: mat-dark-theme($primary-lime, $accent-lime, $warn);\n+$light-lime-theme: mat-light-theme($primary-lime, $accent-lime, $warn);\n+// cyan\n+$dark-cyan-theme: mat-dark-theme($primary-cyan, $accent-cyan, $warn);\n+$light-cyan-theme: mat-light-theme($primary-cyan, $accent-cyan, $warn);\n+// indigo\n+$dark-indigo-theme: mat-dark-theme($primary-indigo, $accent-indigo, $warn);\n+$light-indigo-theme: mat-light-theme($primary-indigo, $accent-indigo, $warn);\n+// blue\n+$dark-blue-theme: mat-dark-theme($primary-blue, $accent-blue, $warn);\n+$light-blue-theme: mat-light-theme($primary-blue, $accent-blue, $warn);\n+// deep-purple\n+$dark-deep-purple-theme: mat-dark-theme($primary-deep-purple, $accent-deep-purple, $warn);\n+$light-deep-purple-theme: mat-light-theme($primary-deep-purple, $accent-deep-purple, $warn);\n+// red\n+$dark-red-theme: mat-dark-theme($primary-red, $accent-red, $warn-red);\n+$light-red-theme: mat-light-theme($primary-red, $accent-red, $warn-red);\n+// pink\n+$dark-pink-theme: mat-dark-theme($primary-pink, $accent-pink, $warn);\n+$light-pink-theme: mat-light-theme($primary-pink, $accent-pink, $warn);\n-// Default theme is dark orange, we have to apply it here.\n-@include angular-material-theme($dark-theme);\n-@include theme-background($dark-theme);\n-@include expansion-panel-accent($dark-theme);\n-@include card-accent($dark-theme);\n-@include color-fixes($dark-theme);\n-\n-\n+// Dark orange theme class\n.dark-orange-theme {\n@include angular-material-theme($dark-theme);\n@include theme-background($dark-theme);\n@@ -89,7 +165,7 @@ $dark-teal-theme: mat-dark-theme($primary-teal, $accent-teal, $warn);\n@include color-fixes($dark-theme);\n}\n-// Light theme class\n+// Light orange theme class\n.light-orange-theme {\n@include angular-material-theme($light-orange-theme);\n@include theme-background($light-orange-theme);\n@@ -98,7 +174,7 @@ $dark-teal-theme: mat-dark-theme($primary-teal, $accent-teal, $warn);\n@include color-fixes($light-orange-theme);\n}\n-// Light theme class\n+// Light teal theme class\n.light-teal-theme {\n@include angular-material-theme($light-teal-theme);\n@include theme-background($light-teal-theme);\n@@ -107,7 +183,7 @@ $dark-teal-theme: mat-dark-theme($primary-teal, $accent-teal, $warn);\n@include color-fixes($light-teal-theme);\n}\n-// Light theme class\n+// Dark teal theme class\n.dark-teal-theme {\n@include angular-material-theme($dark-teal-theme);\n@include theme-background($dark-teal-theme);\n@@ -116,6 +192,168 @@ $dark-teal-theme: mat-dark-theme($primary-teal, $accent-teal, $warn);\n@include color-fixes($dark-teal-theme);\n}\n+// Light brown theme class\n+.light-brown-theme {\n+ @include angular-material-theme($light-brown-theme);\n+ @include theme-background($light-brown-theme);\n+ @include expansion-panel-accent($light-brown-theme);\n+ @include card-accent($light-brown-theme);\n+ @include color-fixes($light-brown-theme);\n+}\n+\n+// Light amber theme class\n+.light-amber-theme {\n+ @include angular-material-theme($light-amber-theme);\n+ @include theme-background($light-amber-theme);\n+ @include expansion-panel-accent($light-amber-theme);\n+ @include card-accent($light-amber-theme);\n+ @include color-fixes($light-amber-theme);\n+}\n+\n+// Dark amber theme class\n+.dark-amber-theme {\n+ @include angular-material-theme($dark-amber-theme);\n+ @include theme-background($dark-amber-theme);\n+ @include expansion-panel-accent($dark-amber-theme);\n+ @include card-accent($dark-amber-theme);\n+ @include color-fixes($dark-amber-theme);\n+}\n+\n+// Light green theme class\n+.light-green-theme {\n+ @include angular-material-theme($light-green-theme);\n+ @include theme-background($light-green-theme);\n+ @include expansion-panel-accent($light-green-theme);\n+ @include card-accent($light-green-theme);\n+ @include color-fixes($light-green-theme);\n+}\n+\n+// Dark lime theme class\n+.dark-lime-theme {\n+ @include angular-material-theme($dark-lime-theme);\n+ @include theme-background($dark-lime-theme);\n+ @include expansion-panel-accent($dark-lime-theme);\n+ @include card-accent($dark-lime-theme);\n+ @include color-fixes($dark-lime-theme);\n+}\n+\n+// Light lime theme class\n+.light-lime-theme {\n+ @include angular-material-theme($light-lime-theme);\n+ @include theme-background($light-lime-theme);\n+ @include expansion-panel-accent($light-lime-theme);\n+ @include card-accent($light-lime-theme);\n+ @include color-fixes($light-lime-theme);\n+}\n+\n+// Dark cyan theme class\n+.dark-cyan-theme {\n+ @include angular-material-theme($dark-cyan-theme);\n+ @include theme-background($dark-cyan-theme);\n+ @include expansion-panel-accent($dark-cyan-theme);\n+ @include card-accent($dark-cyan-theme);\n+ @include color-fixes($dark-cyan-theme);\n+}\n+\n+// Light cyan theme class\n+.light-cyan-theme {\n+ @include angular-material-theme($light-cyan-theme);\n+ @include theme-background($light-cyan-theme);\n+ @include expansion-panel-accent($light-cyan-theme);\n+ @include card-accent($light-cyan-theme);\n+ @include color-fixes($light-cyan-theme);\n+}\n+\n+// Dark indigo theme class\n+.dark-indigo-theme {\n+ @include angular-material-theme($dark-indigo-theme);\n+ @include theme-background($dark-indigo-theme);\n+ @include expansion-panel-accent($dark-indigo-theme);\n+ @include card-accent($dark-indigo-theme);\n+ @include color-fixes($dark-indigo-theme);\n+}\n+\n+// Light indigo theme class\n+.dark-indigo-theme {\n+ @include angular-material-theme($light-indigo-theme);\n+ @include theme-background($light-indigo-theme);\n+ @include expansion-panel-accent($light-indigo-theme);\n+ @include card-accent($light-indigo-theme);\n+ @include color-fixes($light-indigo-theme);\n+}\n+\n+// Dark blue theme class\n+.dark-blue-theme {\n+ @include angular-material-theme($dark-blue-theme);\n+ @include theme-background($dark-blue-theme);\n+ @include expansion-panel-accent($dark-blue-theme);\n+ @include card-accent($dark-blue-theme);\n+ @include color-fixes($dark-blue-theme);\n+}\n+\n+// Light blue theme class\n+.light-blue-theme {\n+ @include angular-material-theme($light-blue-theme);\n+ @include theme-background($light-blue-theme);\n+ @include expansion-panel-accent($light-blue-theme);\n+ @include card-accent($light-blue-theme);\n+ @include color-fixes($light-blue-theme);\n+}\n+\n+// Dark deep-purple theme class\n+.dark-deep-purple-theme {\n+ @include angular-material-theme($dark-deep-purple-theme);\n+ @include theme-background($dark-deep-purple-theme);\n+ @include expansion-panel-accent($dark-deep-purple-theme);\n+ @include card-accent($dark-deep-purple-theme);\n+ @include color-fixes($dark-deep-purple-theme);\n+}\n+\n+// Light deep-purple theme class\n+.light-deep-purple-theme {\n+ @include angular-material-theme($light-deep-purple-theme);\n+ @include theme-background($light-deep-purple-theme);\n+ @include expansion-panel-accent($light-deep-purple-theme);\n+ @include card-accent($light-deep-purple-theme);\n+ @include color-fixes($light-deep-purple-theme);\n+}\n+\n+// Dark red theme class\n+.dark-red-theme {\n+ @include angular-material-theme($dark-red-theme);\n+ @include theme-background($dark-red-theme);\n+ @include expansion-panel-accent($dark-red-theme);\n+ @include card-accent($dark-red-theme);\n+ @include color-fixes($dark-red-theme);\n+}\n+\n+// Light red theme class\n+.light-red-theme {\n+ @include angular-material-theme($light-red-theme);\n+ @include theme-background($light-red-theme);\n+ @include expansion-panel-accent($light-red-theme);\n+ @include card-accent($light-red-theme);\n+ @include color-fixes($light-red-theme);\n+}\n+\n+// Dark pink theme class\n+.dark-pink-theme {\n+ @include angular-material-theme($dark-pink-theme);\n+ @include theme-background($dark-pink-theme);\n+ @include expansion-panel-accent($dark-pink-theme);\n+ @include card-accent($dark-pink-theme);\n+ @include color-fixes($dark-pink-theme);\n+}\n+\n+// Light pink theme class\n+.light-pink-theme {\n+ @include angular-material-theme($light-pink-theme);\n+ @include theme-background($light-pink-theme);\n+ @include expansion-panel-accent($light-pink-theme);\n+ @include card-accent($light-pink-theme);\n+ @include color-fixes($light-pink-theme);\n+}\n+\n// Responsive breakpoint mixin/definitions\n$min-width-small: 767px;\n$min-width-medium: 992px;\n",
"new_path": "src/theme.scss",
"old_path": "src/theme.scss"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
style: add few themes and defects fixes
| 1
|
style
| null |
730,429
|
15.03.2018 14:47:09
| 14,400
|
5eeedb0fb95e5c3990b09457923967237901c2b5
|
chore(wdio): use resolution by platform
|
[
{
"change_type": "MODIFY",
"diff": "@@ -17,7 +17,9 @@ const platform = process.env.PLATFORM || 'mac 10.12';\nconst tunnelId = uuid.v4();\nconst port = process.env.PORT || 4567;\nconst {suite} = argv || 'integration';\n-const screenResolution = '1920x1440';\n+const screenResolutionMac = '1920x1440';\n+const screenResolutionWin = '1920x1080';\n+const screenResolution = platform.toLowerCase().includes('os x') || platform === 'darwin' || platform.includes('mac') ? screenResolutionMac : screenResolutionWin;\nconst chromeCapabilities = {\nbrowserName: 'chrome',\n",
"new_path": "wdio.conf.js",
"old_path": "wdio.conf.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
chore(wdio): use resolution by platform
| 1
|
chore
|
wdio
|
791,834
|
15.03.2018 15:31:51
| 25,200
|
7c7695bc58fd735ac95539e1490e4657c6a457f2
|
core: add type checking to audit and gatherer base classes
|
[
{
"change_type": "MODIFY",
"diff": "* Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n*/\n-// @ts-nocheck\n'use strict';\nconst statistics = require('../lib/statistics');\n@@ -19,14 +18,14 @@ const clampTo2Decimals = val => Math.round(val * 100) / 100;\nclass Audit {\n/**\n- * @return {!string}\n+ * @return {string}\n*/\nstatic get DEFAULT_PASS() {\nreturn DEFAULT_PASS;\n}\n/**\n- * @return {{NUMERIC: string, BINARY: string}}\n+ * @return {Audit.ScoringModes}\n*/\nstatic get SCORING_MODES() {\nreturn {\n@@ -36,14 +35,14 @@ class Audit {\n}\n/**\n- * @throws {Error}\n+ * @return {Audit.Meta}\n*/\nstatic get meta() {\nthrow new Error('Audit meta information must be overridden.');\n}\n/**\n- * Computes a clamped score between 0 and 100 based on the measured value. Score is determined by\n+ * Computes a clamped score between 0 and 1 based on the measured value. Score is determined by\n* considering a log-normal distribution governed by the two control points, point of diminishing\n* returns and the median value, and returning the percentage of sites that have higher value.\n*\n@@ -65,9 +64,9 @@ class Audit {\n}\n/**\n- * @param {!Audit} audit\n+ * @param {typeof Audit} audit\n* @param {string} debugString\n- * @return {!AuditFullResult}\n+ * @return {LH.AuditFullResult}\n*/\nstatic generateErrorAuditResult(audit, debugString) {\nreturn Audit.generateAuditResult(audit, {\n@@ -78,10 +77,10 @@ class Audit {\n}\n/**\n- * @param {!Audit.Headings} headings\n- * @param {!Array<!Object<string, string>>} results\n- * @param {!DetailsRenderer.DetailsSummary} summary\n- * @return {!DetailsRenderer.DetailsJSON}\n+ * @param {Audit.Headings} headings\n+ * @param {Array<Object<string, string>>} results\n+ * @param {Audit.DetailsRenderer.DetailsSummary} summary\n+ * @return {Audit.DetailsRenderer.DetailsJSON}\n*/\nstatic makeTableDetails(headings, results, summary) {\nif (results.length === 0) {\n@@ -102,9 +101,9 @@ class Audit {\n}\n/**\n- * @param {!Audit} audit\n- * @param {!AuditResult} result\n- * @return {{score: number, scoreDisplayMode: string}}\n+ * @param {typeof Audit} audit\n+ * @param {LH.AuditResult} result\n+ * @return {{score: number, scoreDisplayMode: Audit.ScoringModeValues}}\n*/\nstatic _normalizeAuditScore(audit, result) {\n// Cast true/false to 1/0\n@@ -125,9 +124,9 @@ class Audit {\n}\n/**\n- * @param {!Audit} audit\n- * @param {!AuditResult} result\n- * @return {!AuditFullResult}\n+ * @param {typeof Audit} audit\n+ * @param {LH.AuditResult} result\n+ * @return {LH.AuditFullResult}\n*/\nstatic generateAuditResult(audit, result) {\nif (typeof result.rawValue === 'undefined') {\n@@ -175,6 +174,28 @@ class Audit {\nmodule.exports = Audit;\n+/**\n+ * @typedef {Object} Audit.ScoringModes\n+ * @property {'numeric'} NUMERIC\n+ * @property {'binary'} BINARY\n+ */\n+\n+/**\n+ * @typedef {Audit.ScoringModes[keyof Audit.ScoringModes]} Audit.ScoringModeValues\n+ */\n+\n+/**\n+ * @typedef {Object} Audit.Meta\n+ * @property {string} name\n+ * @property {string} description\n+ * @property {string} helpText\n+ * @property {Array<string>} requiredArtifacts\n+ * @property {string} [failureDescription]\n+ * @property {boolean} [informative]\n+ * @property {boolean} [manual]\n+ * @property {Audit.ScoringModeValues} [scoreDisplayMode]\n+ */\n+\n/**\n* @typedef {Object} Audit.Heading\n* @property {string} key\n@@ -191,5 +212,20 @@ module.exports = Audit;\n* @property {number} results\n* @property {Audit.Headings} headings\n* @property {boolean} passes\n- * @property {string=} debugString\n+ * @property {string} [debugString]\n+ */\n+\n+// TODO: placeholder typedefs until Details are typed\n+/**\n+ * @typedef {void} Audit.DetailsRenderer.DetailsSummary\n+ * @property {number} [wastedMs]\n+ * @property {number} [wastedKb]\n+ */\n+\n+/**\n+ * @typedef {object} Audit.DetailsRenderer.DetailsJSON\n+ * @property {'table'} type\n+ * @property {Array<Audit.Heading>} headings\n+ * @property {Array<Object<string, string>>} items\n+ * @property {Audit.DetailsRenderer.DetailsSummary} summary\n*/\n",
"new_path": "lighthouse-core/audits/audit.js",
"old_path": "lighthouse-core/audits/audit.js"
},
{
"change_type": "MODIFY",
"diff": "},\n\"include\": [\n\"lighthouse-cli/**/*.js\",\n+ \"lighthouse-core/audits/audit.js\",\n\"lighthouse-core/lib/dependency-graph/**/*.js\",\n\"lighthouse-core/gather/connections/**/*.js\",\n+ \"lighthouse-core/gather/gatherers/gatherer.js\",\n\"./typings/externs.d.ts\"\n],\n\"exclude\": [\n",
"new_path": "tsconfig.json",
"old_path": "tsconfig.json"
},
{
"change_type": "MODIFY",
"diff": "* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n*/\n-export as namespace LH;\n+declare namespace LH {\nexport interface Flags {\n_: string[];\n@@ -34,29 +34,30 @@ export interface Flags {\nexport interface Config {}\nexport interface AuditResult {\n- rawValue: boolean | number;\n+ rawValue: boolean | number | null;\ndisplayValue?: string;\ndebugString?: string;\nscore?: number;\n- optimalValue: number | string;\nextendedInfo?: {value: string};\n+ notApplicable?: boolean;\n+ error?: boolean;\n+ // TODO: define details\n+ details?: object;\n}\nexport interface AuditResults {\n[metric: string]: AuditResult;\n}\n-export interface AuditFullResult {\n- rawValue: boolean | number;\n+ export interface AuditFullResult extends AuditResult {\ndisplayValue: string;\n- debugString?: string;\nscore: number;\n- scoreDisplayMode: string;\n- error?: boolean;\n+ scoreDisplayMode: 'numeric' | 'binary';\ndescription: string;\nname: string;\nhelpText?: string;\n- extendedInfo?: {value: string};\n+ informative?: boolean;\n+ manual?: boolean;\n}\nexport interface AuditFullResults {\n@@ -140,3 +141,4 @@ export interface DevToolsJsonTarget {\nurl: string;\nwebSocketDebuggerUrl: string;\n}\n+}\n",
"new_path": "typings/externs.d.ts",
"old_path": "typings/externs.d.ts"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core: add type checking to audit and gatherer base classes (#4762)
| 1
|
core
| null |
217,922
|
15.03.2018 16:31:13
| -3,600
|
e6e1cb2fa455717fc8a637a6cc858ef065ef0fae
|
feat: link patreon email to your profile for automatic patreon recognition
|
[
{
"change_type": "MODIFY",
"diff": "@@ -43,10 +43,21 @@ export class UserService extends FirebaseStorage<AppUser> {\nuserData = this.get(uid);\n}\nreturn userData\n- .switchMap(u => {\n+ .mergeMap(u => {\n+ u.patron = false;\n+ if (u.patreonEmail === undefined) {\n+ return Observable.of(u);\n+ }\n+ return this.firebase.list('/patreon/supporters').valueChanges().map((supporters: { email: string }[]) => {\n+ u.patron = supporters.find(s => s.email === u.patreonEmail) !== undefined;\n+ return u;\n+ });\n+ })\n+ .mergeMap(u => {\nif (u !== null && u.lodestoneId !== null && u.lodestoneId !== undefined) {\nreturn this.dataService.getCharacter(u.lodestoneId).map(c => {\nc.patron = u.patron;\n+ c.patreonEmail = u.patreonEmail;\nreturn c;\n});\n} else {\n@@ -94,7 +105,7 @@ export class UserService extends FirebaseStorage<AppUser> {\n* @returns {Observable<boolean>}\n*/\ncheckPatreonEmailAvailability(email: string): Observable<boolean> {\n- return this.firebase.list(this.getBaseUri(), ref => ref.orderByChild('email').equalTo(email))\n+ return this.firebase.list(this.getBaseUri(), ref => ref.orderByChild('patreonEmail').equalTo(email))\n.valueChanges()\n.map(res => res.length === 0);\n}\n",
"new_path": "src/app/core/database/user.service.ts",
"old_path": "src/app/core/database/user.service.ts"
},
{
"change_type": "ADD",
"diff": "+<h3 mat-dialog-title>{{\"Patreon_link_email\" | translate}}</h3>\n+<div mat-dialog-content>\n+ <form (submit)=\"submit()\">\n+ <mat-input-container>\n+ <input type=\"text\" [formControl]=\"email\" matInput placeholder=\"{{'Patreon_email' | translate}}\">\n+ </mat-input-container>\n+ <mat-error *ngIf=\"alreadyUsed\">{{'Email_already_used' | translate}}</mat-error>\n+ </form>\n+</div>\n+<div mat-dialog-actions>\n+ <button mat-raised-button type=\"submit\" color=\"accent\" [disabled]=\"!email.valid\" (click)=\"submit()\">{{'Confirm' | translate}}\n+ </button>\n+</div>\n",
"new_path": "src/app/pages/profile/patreon-link-popup/patreon-link-popup.component.html",
"old_path": null
},
{
"change_type": "ADD",
"diff": "",
"new_path": "src/app/pages/profile/patreon-link-popup/patreon-link-popup.component.scss",
"old_path": "src/app/pages/profile/patreon-link-popup/patreon-link-popup.component.scss"
},
{
"change_type": "ADD",
"diff": "+import {Component, Inject} from '@angular/core';\n+import {UserService} from '../../../core/database/user.service';\n+import {FormControl, Validators} from '@angular/forms';\n+import {MAT_DIALOG_DATA, MatDialogRef} from '@angular/material';\n+import 'rxjs/add/observable/timer';\n+import {AppUser} from 'app/model/list/app-user';\n+\n+@Component({\n+ selector: 'app-patreon-link-popup',\n+ templateUrl: './patreon-link-popup.component.html',\n+ styleUrls: ['./patreon-link-popup.component.scss']\n+})\n+export class PatreonLinkPopupComponent {\n+\n+ patreonEmail: string;\n+\n+ email: FormControl = new FormControl('', [Validators.required, Validators.email]);\n+\n+ alreadyUsed = false;\n+\n+ constructor(private userService: UserService, private dialogRef: MatDialogRef<PatreonLinkPopupComponent>,\n+ @Inject(MAT_DIALOG_DATA) private user: AppUser) {\n+ }\n+\n+ submit(): void {\n+ this.user.patreonEmail = this.email.value;\n+ this.userService.checkPatreonEmailAvailability(this.email.value)\n+ .first()\n+ .do(res => {\n+ if (!res) {\n+ this.alreadyUsed = true;\n+ }\n+ })\n+ .filter(res => res)\n+ .mergeMap(() => {\n+ return this.userService.set(this.user.$key, this.user)\n+ })\n+ .subscribe(() => {\n+ this.dialogRef.close();\n+ });\n+ }\n+}\n",
"new_path": "src/app/pages/profile/patreon-link-popup/patreon-link-popup.component.ts",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -26,6 +26,7 @@ import {CommonComponentsModule} from '../../modules/common-components/common-com\nimport {FlexLayoutModule} from '@angular/flex-layout';\nimport {ChangeEmailPopupComponent} from './change-email-popup/change-email-popup.component';\nimport {FormsModule, ReactiveFormsModule} from '@angular/forms';\n+import { PatreonLinkPopupComponent } from './patreon-link-popup/patreon-link-popup.component';\nconst routes: Routes = [{\npath: 'profile',\n@@ -69,6 +70,7 @@ const routes: Routes = [{\nProfileHelpComponent,\nPublicProfileComponent,\nChangeEmailPopupComponent,\n+ PatreonLinkPopupComponent,\n],\nproviders: [\nProfileGuard,\n@@ -78,6 +80,7 @@ const routes: Routes = [{\nMasterbooksPopupComponent,\nProfileHelpComponent,\nChangeEmailPopupComponent,\n+ PatreonLinkPopupComponent,\n]\n})\nexport class ProfileModule {\n",
"new_path": "src/app/pages/profile/profile.module.ts",
"old_path": "src/app/pages/profile/profile.module.ts"
},
{
"change_type": "MODIFY",
"diff": "<mat-spinner></mat-spinner>\n</div>\n<div *ngIf=\"character !== undefined && user !== undefined\">\n- <mat-grid-list cols=\"3\" rowHeight=\"600px\">\n+ <mat-grid-list cols=\"3\" rowHeight=\"540px\">\n<mat-grid-tile class=\"portrait-parent\">\n<div class=\"portrait-container\">\n<button mat-icon-button (click)=\"changeCharacter()\" class=\"change-character\">\n<img src=\"https://c5.patreon.com/external/logo/downloads_wordmark_white_on_coral.png\"\nalt=\"patreon supporter\" matTooltip=\"{{'PROFILE.Patreon_supporter' | translate}}\"\nclass=\"patreon-badge\" matTooltipPosition=\"above\" *ngIf=\"character.patron\">\n+ <button mat-button color=\"accent\" class=\"patreon-badge patreon-button\"\n+ (click)=\"openPatreonLinkPopup()\" *ngIf=\"!character.patreon &&\n+ character.patreonEmail === undefined\">\n+ {{\"PROFILE.Patreon_link_email\" | translate}}\n+ </button>\n</mat-card-header>\n<mat-grid-list cols=\"{{getClassesCols()}}\" rowHeight=\"100px\">\n<mat-grid-tile *ngFor=\"let job of getJobs()\">\n",
"new_path": "src/app/pages/profile/profile/profile.component.html",
"old_path": "src/app/pages/profile/profile/profile.component.html"
},
{
"change_type": "MODIFY",
"diff": "}\n.portrait-container {\n- position: relative;\n+ width: 100%;\n.change-character {\nposition: absolute;\ntop: 5px;\nright: 32px;\n}\n.portrait {\n- height: 100%;\n+ top: 0;\n+ width: 100%;\n}\n}\nheight: 40px;\n}\n+ .patreon-button {\n+ width: auto;\n+ }\n+\n.job-container {\ndisplay: flex;\nflex-direction: column;\n",
"new_path": "src/app/pages/profile/profile/profile.component.scss",
"old_path": "src/app/pages/profile/profile/profile.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -10,6 +10,7 @@ import {HelpService} from '../../../core/component/help.service';\nimport {ProfileHelpComponent} from '../profile-help/profile-help.component';\nimport {ChangeEmailPopupComponent} from '../change-email-popup/change-email-popup.component';\nimport {ObservableMedia} from '@angular/flex-layout';\n+import {PatreonLinkPopupComponent} from '../patreon-link-popup/patreon-link-popup.component';\n@Component({\nselector: 'app-profile',\n@@ -77,6 +78,10 @@ export class ProfileComponent extends PageComponent {\nreturn 8;\n}\n+ openPatreonLinkPopup(): void {\n+ this.dialog.open(PatreonLinkPopupComponent, {data: this.user});\n+ }\n+\ngetHelpDialog(): ComponentType<any> | TemplateRef<any> {\nreturn ProfileHelpComponent;\n}\n",
"new_path": "src/app/pages/profile/profile/profile.component.ts",
"old_path": "src/app/pages/profile/profile/profile.component.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
feat: link patreon email to your profile for automatic patreon recognition
| 1
|
feat
| null |
217,922
|
15.03.2018 17:07:45
| -3,600
|
5616d4e70196c36ac1ff17842f9e22f5c07eeafe
|
chore: [WIP] custom links module
|
[
{
"change_type": "MODIFY",
"diff": "@@ -34,6 +34,7 @@ import {LayoutOrderService} from './layout/layout-order.service';\nimport {PushNotificationsModule} from 'ng-push';\nimport {WorkshopService} from './database/workshop.service';\nimport {VenturesExtractor} from './list/data/extractor/ventures-extractor';\n+import {CustomLinksService} from './database/custom-links/custom-links.service';\nconst dataExtractorProviders: Provider[] = [\n@@ -78,6 +79,7 @@ const dataExtractorProviders: Provider[] = [\nLayoutService,\nLayoutOrderService,\nWorkshopService,\n+ CustomLinksService,\n],\ndeclarations: [\nI18nPipe,\n",
"new_path": "src/app/core/core.module.ts",
"old_path": "src/app/core/core.module.ts"
},
{
"change_type": "ADD",
"diff": "+import {DataModel} from '../storage/data-model';\n+\n+export class CustomLink extends DataModel {\n+ uri: string;\n+ redirectTo: string;\n+}\n",
"new_path": "src/app/core/database/custom-links/costum-link.ts",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import {Injectable, NgZone} from '@angular/core';\n+import {FirebaseStorage} from '../storage/firebase/firebase-storage';\n+import {CustomLink} from './costum-link';\n+import {NgSerializerService} from '@kaiu/ng-serializer';\n+import {AngularFireDatabase} from 'angularfire2/database';\n+import {DiffService} from '../diff/diff.service';\n+\n+@Injectable()\n+export class CustomLinksService extends FirebaseStorage<CustomLink> {\n+\n+ constructor(protected database: AngularFireDatabase,\n+ protected serializer: NgSerializerService,\n+ protected diffService: DiffService,\n+ protected zone: NgZone) {\n+ super(database, serializer, diffService, zone);\n+ }\n+\n+ protected getBaseUri(): string {\n+ return 'custom_links';\n+ }\n+\n+ protected getClass(): any {\n+ return CustomLink;\n+ }\n+\n+}\n",
"new_path": "src/app/core/database/custom-links/custom-links.service.ts",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import { NgModule } from '@angular/core';\n+import { CommonModule } from '@angular/common';\n+\n+@NgModule({\n+ imports: [\n+ CommonModule\n+ ],\n+ declarations: []\n+})\n+export class CustomLinksModule { }\n",
"new_path": "src/app/pages/custom-links/custom-links.module.ts",
"old_path": null
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore: [WIP] custom links module
#217
| 1
|
chore
| null |
815,745
|
15.03.2018 17:59:13
| -7,200
|
b5998f6ee7ed87cb8f9c68e76e1cbdbc1b69f7b4
|
fix: don't mark disabled while opening
fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -153,7 +153,7 @@ export class ItemsList {\nif (this._lastSelectedItem && indexOfLastSelected > -1) {\nthis._markedIndex = indexOfLastSelected;\n} else {\n- this._markedIndex = markDefault ? 0 : -1;\n+ this._markedIndex = markDefault ? this.filteredItems.findIndex(x => !x.disabled) : -1;\n}\n}\n",
"new_path": "src/ng-select/items-list.ts",
"old_path": "src/ng-select/items-list.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -864,6 +864,15 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.select.itemsList.markedItem).toEqual(jasmine.objectContaining(result));\n});\n+ it('should open dropdown and mark first not disabled item', fakeAsync(() => {\n+ fixture.componentInstance.cities[0].disabled = true;\n+ fixture.componentInstance.cities = [...fixture.componentInstance.cities];\n+ tickAndDetectChanges(fixture);\n+ const result = { value: fixture.componentInstance.cities[1] };\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n+ expect(fixture.componentInstance.select.itemsList.markedItem).toEqual(jasmine.objectContaining(result));\n+ }));\n+\nit('should open dropdown without marking first item', () => {\nfixture.componentInstance.select.markFirst = false;\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n@@ -2189,8 +2198,8 @@ class NgSelectBasicTestCmp {\ndisabled = false;\ndropdownPosition = 'bottom';\ncitiesLoading = false;\n- cities = [\n- { id: 1, name: 'Vilnius' },\n+ cities: any[] = [\n+ { id: 1, name: 'Vilnius', disabled: false },\n{ id: 2, name: 'Kaunas' },\n{ id: 3, name: 'Pabrade' },\n];\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: don't mark disabled while opening (#360)
fixes #330
| 1
|
fix
| null |
815,745
|
15.03.2018 18:31:38
| -7,200
|
6a9016d15a5c393b1c1cfab645df8e9de1de34d5
|
feat: allow to hide selected items
* feat: allow to hide selected items
closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -138,6 +138,7 @@ map: {\n| loadingText | `string` | `Loading...` | no | Set custom text when for loading items |\n| [markFirst] | `boolean` | `true` | no | Marks first item as focused when opening/filtering. Default `true`|\n| maxSelectedItems | `number` | none | no | When multiple = true, allows to set a limit number of selection. |\n+| hideSelected | `boolean` | `false` | no | Allows to hide selected items. |\n| multiple | `boolean` | `false` | no | Allows to select multiple items. |\n| notFoundText | `string` | `No items found` | no | Set custom text when filter returns empty result |\n| placeholder | `string` | `-` | no | Placeholder text. |\n",
"new_path": "README.md",
"old_path": "README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -33,6 +33,14 @@ export class ItemsList {\nreturn this._markedIndex;\n}\n+ get noItemsToSelect(): boolean {\n+ return this._ngSelect.hideSelected && this._items.length === this._selected.length;\n+ }\n+\n+ get maxItemsSelected(): boolean {\n+ return this._ngSelect.multiple && this._ngSelect.maxSelectedItems <= this._selected.length;\n+ }\n+\nsetItems(items: any[]) {\nthis._items = items.map((item, index) => this.mapItem(item, index));\nif (this._ngSelect.groupBy) {\n@@ -45,7 +53,7 @@ export class ItemsList {\n}\nselect(item: NgOption) {\n- if (item.selected || this.maxItemsSelected()) {\n+ if (item.selected || this.maxItemsSelected) {\nreturn;\n}\nif (!this._ngSelect.multiple) {\n@@ -53,10 +61,10 @@ export class ItemsList {\n}\nthis._selected.push(item);\nitem.selected = true;\n- }\n- maxItemsSelected(): boolean {\n- return this._ngSelect.multiple && this._ngSelect.maxSelectedItems <= this._selected.length;\n+ if (this._ngSelect.hideSelected) {\n+ this._filteredItems = this._filteredItems.filter(x => x !== item);\n+ }\n}\nfindItem(value: any): NgOption {\n@@ -71,15 +79,18 @@ export class ItemsList {\nunselect(item: NgOption) {\nthis._selected = this._selected.filter(x => x !== item);\nitem.selected = false;\n+\n+ if (this._ngSelect.hideSelected) {\n+ this._filteredItems.splice(item.index, 0, item);\n+ this._filteredItems = [...this._filteredItems.sort((a, b) => (a.index - b.index))];\n+ }\n}\nunselectLast() {\nif (this._selected.length === 0) {\nreturn;\n}\n-\n- this._selected[this._selected.length - 1].selected = false;\n- this._selected.splice(this._selected.length - 1, 1);\n+ this.unselect(this._lastSelectedItem);\n}\naddItem(item: any) {\n@@ -95,11 +106,15 @@ export class ItemsList {\nitem.marked = false;\n});\nthis._selected = [];\n+\n+ if (this._ngSelect.hideSelected) {\n+ this.resetItems();\n+ }\n}\nfilter(term: string) {\nif (!term) {\n- this._filteredItems = this._items;\n+ this.resetItems();\nreturn;\n}\n@@ -110,6 +125,9 @@ export class ItemsList {\nconst matchedItems = [];\nfor (const item of this._groups[key]) {\nconst label = searchHelper.stripSpecialChars(item.label).toLocaleLowerCase();\n+ if (this._ngSelect.hideSelected && this._selected.indexOf(item) > -1) {\n+ continue;\n+ }\nif (label.indexOf(term) > -1) {\nmatchedItems.push(item);\n}\n@@ -125,8 +143,13 @@ export class ItemsList {\n}\n}\n- clearFilter() {\n- this._filteredItems = [...this._items];\n+ resetItems() {\n+ if (this._filteredItems.length === this._items.length) {\n+ return;\n+ }\n+ this._filteredItems = this._ngSelect.hideSelected ?\n+ this._items.filter(x => this._selected.indexOf(x) === -1) :\n+ this._items;\n}\nunmarkItem() {\n@@ -149,7 +172,7 @@ export class ItemsList {\nif (this._filteredItems.length === 0) {\nreturn;\n}\n- const indexOfLastSelected = this._filteredItems.indexOf(this._lastSelectedItem);\n+ const indexOfLastSelected = this._ngSelect.hideSelected ? -1 : this._filteredItems.indexOf(this._lastSelectedItem);\nif (this._lastSelectedItem && indexOfLastSelected > -1) {\nthis._markedIndex = indexOfLastSelected;\n} else {\n@@ -186,8 +209,19 @@ export class ItemsList {\n};\n}\n- updateSelectedItem(item: NgOption, index: number) {\n- this._selected[index] = item;\n+ mapSelectedItems() {\n+ this._selected.forEach((selected, i) => {\n+ const value = this._ngSelect.bindValue ? selected.value[this._ngSelect.bindValue] : selected.value;\n+ const item = this.findItem(value);\n+ if (item && selected !== item) {\n+ item.selected = true;\n+ this._selected[i] = item;\n+ }\n+ });\n+\n+ if (this._ngSelect.hideSelected) {\n+ this._filteredItems = this.filteredItems.filter(x => this._selected.indexOf(x) === -1);\n+ }\n}\nprivate _getNextItemIndex(steps: number) {\n",
"new_path": "src/ng-select/items-list.ts",
"old_path": "src/ng-select/items-list.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -1329,14 +1329,14 @@ describe('NgSelectComponent', function () {\ndescribe('Multiple', () => {\nlet fixture: ComponentFixture<NgSelectBasicTestCmp>;\n+ let select: NgSelectComponent;\nbeforeEach(() => {\nfixture = createTestingModule(\nNgSelectBasicTestCmp,\n`<ng-select [items]=\"cities\"\nbindLabel=\"name\"\n- bindValue=\"this\"\nplaceholder=\"select value\"\n- [(ngModel)]=\"selectedCity\"\n+ [(ngModel)]=\"selectedCities\"\n[multiple]=\"true\">\n</ng-select>`);\n});\n@@ -1369,23 +1369,11 @@ describe('NgSelectComponent', function () {\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\nexpect((<NgOption[]>fixture.componentInstance.select.selectedItems).length).toBe(1);\n});\n- });\n- describe('Multiple with max limit of selection', () => {\n- let fixture: ComponentFixture<NgSelectBasicTestCmp>;\n+ describe('max selected items', () => {\nlet arrowIcon: DebugElement = null;\n-\nbeforeEach(() => {\n- fixture = createTestingModule(\n- NgSelectBasicTestCmp,\n- `<ng-select [items]=\"cities\"\n- bindLabel=\"name\"\n- bindValue=\"this\"\n- placeholder=\"select value\"\n- [(ngModel)]=\"selectedCity\"\n- [multiple]=\"true\"\n- [maxSelectedItems]=\"2\">\n- </ng-select>`);\n+ fixture.componentInstance.select.maxSelectedItems = 2;\narrowIcon = fixture.debugElement.query(By.css('.ng-arrow-zone'));\n});\n@@ -1397,12 +1385,11 @@ describe('NgSelectComponent', function () {\nexpect((<NgOption[]>fixture.componentInstance.select.selectedItems).length).toBe(2);\n}));\n- it('should click on arrow be disabled when maximum of items is reached', fakeAsync(() => {\n+ it('should not open dropdown when maximum of items is reached', fakeAsync(() => {\nconst clickArrow = () => arrowIcon.triggerEventHandler('click', { stopPropagation: () => { } });\nselectOption(fixture, KeyCode.ArrowDown, 0);\nselectOption(fixture, KeyCode.ArrowDown, 1);\ntickAndDetectChanges(fixture);\n- // open\nclickArrow();\ntickAndDetectChanges(fixture);\nexpect(fixture.componentInstance.select.isOpen).toBe(false);\n@@ -1410,6 +1397,82 @@ describe('NgSelectComponent', function () {\n}));\n});\n+ describe('show selected', () => {\n+ beforeEach(() => {\n+ select = fixture.componentInstance.select;\n+ select.hideSelected = true;\n+ select.closeOnSelect = false;\n+ });\n+\n+ it('should close dropdown when all items are selected', fakeAsync(() => {\n+ selectOption(fixture, KeyCode.ArrowDown, 1);\n+ selectOption(fixture, KeyCode.ArrowDown, 1);\n+ selectOption(fixture, KeyCode.ArrowDown, 1);\n+ expect(select.selectedItems.length).toBe(3);\n+ expect(select.itemsList.filteredItems.length).toBe(0);\n+ expect(select.isOpen).toBeFalsy();\n+ }));\n+\n+ it('should not open dropdown when all items are selected', fakeAsync(() => {\n+ fixture.componentInstance.selectedCities = [...fixture.componentInstance.cities];\n+ tickAndDetectChanges(fixture);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n+ expect(select.selectedItems.length).toBe(3);\n+ expect(select.itemsList.filteredItems.length).toBe(0);\n+ expect(select.isOpen).toBeFalsy();\n+ }));\n+\n+ it('should remove selected item from items list', fakeAsync(() => {\n+ fixture.componentInstance.selectedCities = [fixture.componentInstance.cities[0]];\n+ tickAndDetectChanges(fixture);\n+ expect(select.selectedItems.length).toBe(1);\n+ expect(select.itemsList.filteredItems.length).toBe(2);\n+ }));\n+\n+ it('should put unselected item back to list', fakeAsync(() => {\n+ fixture.componentInstance.selectedCities = [fixture.componentInstance.cities[0]];\n+ tickAndDetectChanges(fixture);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Backspace);\n+ expect(fixture.componentInstance.select.selectedItems.length).toBe(0);\n+ expect(fixture.componentInstance.select.itemsList.filteredItems.length).toBe(3);\n+ }));\n+\n+ it('should keep same ordering while unselecting', fakeAsync(() => {\n+ fixture.componentInstance.selectedCities = [...fixture.componentInstance.cities.reverse()];\n+ tickAndDetectChanges(fixture);\n+ select.unselect(select.selectedItems[0])\n+ select.unselect(select.selectedItems[0])\n+ select.unselect(select.selectedItems[0])\n+ expect(select.selectedItems.length).toBe(0);\n+ expect(select.itemsList.filteredItems.length).toBe(3);\n+ expect(select.itemsList.filteredItems[0].label).toBe('Vilnius');\n+ expect(select.itemsList.filteredItems[1].label).toBe('Kaunas');\n+ expect(select.itemsList.filteredItems[2].label).toBe('Pabrade');\n+ }));\n+\n+ it('should reset list while clearing all selected items', fakeAsync(() => {\n+ fixture.componentInstance.selectedCities = [...fixture.componentInstance.cities];\n+ tickAndDetectChanges(fixture);\n+ select.handleClearClick(<any>{ stopPropagation: () => { } });\n+ expect(select.selectedItems.length).toBe(0);\n+ expect(select.itemsList.filteredItems.length).toBe(3);\n+ }));\n+\n+ it('should skip selected items while filtering', fakeAsync(() => {\n+ fixture.componentInstance.selectedCities = [fixture.componentInstance.cities[0]];\n+ tickAndDetectChanges(fixture);\n+ select.filter('s');\n+ tickAndDetectChanges(fixture);\n+ expect(select.itemsList.filteredItems.length).toBe(1);\n+ expect(select.itemsList.filteredItems[0].label).toBe('Kaunas');\n+ select.filter('');\n+ tickAndDetectChanges(fixture);\n+ expect(select.itemsList.filteredItems.length).toBe(2);\n+ }));\n+ });\n+ });\n+\ndescribe('Tagging', () => {\nit('should select default tag', fakeAsync(() => {\nlet fixture = createTestingModule(\n@@ -1685,13 +1748,13 @@ describe('NgSelectComponent', function () {\n[multiple]=\"true\">\n</ng-select>`);\n- const clearFilter = spyOn(fixture.componentInstance.select.itemsList, 'clearFilter');\n+ const resetItems = spyOn(fixture.componentInstance.select.itemsList, 'resetItems');\ntickAndDetectChanges(fixture);\nfixture.componentInstance.select.filterValue = null;\nselectOption(fixture, KeyCode.ArrowDown, 1);\ntickAndDetectChanges(fixture);\n- expect(clearFilter).not.toHaveBeenCalled();\n+ expect(resetItems).not.toHaveBeenCalled();\n}));\nit('should filter grouped items', fakeAsync(() => {\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -87,6 +87,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n@Input() appendTo: string;\n@Input() loading = false;\n@Input() closeOnSelect = true;\n+ @Input() hideSelected = false;\n@Input() maxSelectedItems: number;\n@Input() groupBy: string;\n@Input() bufferAmount = 4;\n@@ -282,7 +283,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\nopen() {\n- if (this.isDisabled || this.isOpen || this.itemsList.maxItemsSelected()) {\n+ if (this.isDisabled || this.isOpen || this.itemsList.maxItemsSelected || this.itemsList.noItemsToSelect) {\nreturn;\n}\nthis.isOpen = true;\n@@ -325,7 +326,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nthis.addEvent.emit(item.value);\n}\n- if (this.closeOnSelect) {\n+ if (this.closeOnSelect || this.itemsList.noItemsToSelect) {\nthis.close();\n}\n}\n@@ -432,7 +433,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nthis._primitive = !isObject(firstItem);\nthis.itemsList.setItems(items);\nif (items.length > 0 && this.hasValue) {\n- this._updateSelectedItems();\n+ this.itemsList.mapSelectedItems();\n}\nif (this._isTypeahead) {\n@@ -453,7 +454,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}));\nthis.itemsList.setItems(this.items);\nif (this.hasValue) {\n- this._updateSelectedItems();\n+ this.itemsList.mapSelectedItems();\n}\nthis.detectChanges();\n}\n@@ -537,16 +538,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\n}\n- private _updateSelectedItems() {\n- this.selectedItems.forEach((s, i) => {\n- const val = this.bindValue ? s.value[this.bindValue] : s.value;\n- const item = this.itemsList.findItem(val);\n- if (item && s !== item) {\n- item.selected = true;\n- this.itemsList.updateSelectedItem(item, i);\n- }\n- });\n- }\n+\nprivate _updateNgModel() {\nconst model = [];\n@@ -581,7 +573,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\nthis.filterValue = null;\n- this.itemsList.clearFilter();\n+ this.itemsList.resetItems();\n}\nprivate _scrollToMarked() {\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
feat: allow to hide selected items (#359)
* feat: allow to hide selected items
closes #164
| 1
|
feat
| null |
815,745
|
15.03.2018 18:32:56
| -7,200
|
20f7a9d39dfc3188ece2b222da9d9abc8bbe3d15
|
chore(release): 0.30.0
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.30.0\"></a>\n+# [0.30.0](https://github.com/ng-select/ng-select/compare/v0.29.1...v0.30.0) (2018-03-15)\n+\n+\n+### Bug Fixes\n+\n+* don't mark disabled while opening ([#360](https://github.com/ng-select/ng-select/issues/360)) ([b5998f6](https://github.com/ng-select/ng-select/commit/b5998f6)), closes [#330](https://github.com/ng-select/ng-select/issues/330)\n+\n+\n+### Features\n+\n+* allow to hide selected items ([#359](https://github.com/ng-select/ng-select/issues/359)) ([6a9016d](https://github.com/ng-select/ng-select/commit/6a9016d)), closes [#164](https://github.com/ng-select/ng-select/issues/164)\n+\n+\n+\n<a name=\"0.29.1\"></a>\n## [0.29.1](https://github.com/ng-select/ng-select/compare/v0.29.0...v0.29.1) (2018-03-15)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"$schema\": \"../node_modules/ng-packagr/package.schema.json\",\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.29.1\",\n+ \"version\": \"0.30.0\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.30.0
| 1
|
chore
|
release
|
807,849
|
15.03.2018 19:02:29
| 25,200
|
14fcc1b5646c13b6fd03259553f68d5d1af70788
|
test(git-init): set user.name/email directly during fixture init
|
[
{
"change_type": "MODIFY",
"diff": "@@ -5,7 +5,8 @@ const execa = require(\"execa\");\nmodule.exports = gitInit;\nfunction gitInit(cwd, ...args) {\n- return execa(\"git\", [\"init\", ...args], { cwd }).then(() =>\n- execa(\"git\", [\"config\", \"commit.gpgSign\", \"false\"], { cwd })\n- );\n+ return execa(\"git\", [\"init\", ...args], { cwd })\n+ .then(() => execa(\"git\", [\"config\", \"commit.gpgSign\", \"false\"], { cwd }))\n+ .then(() => execa(\"git\", [\"config\", \"user.email\", \"test@example.com\"], { cwd }))\n+ .then(() => execa(\"git\", [\"config\", \"user.name\", \"Tester McPerson\"], { cwd }));\n}\n",
"new_path": "helpers/git-init/index.js",
"old_path": "helpers/git-init/index.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
test(git-init): set user.name/email directly during fixture init
| 1
|
test
|
git-init
|
679,913
|
15.03.2018 21:48:32
| 0
|
6378eb0b122692d21b85df7eea8eee3a6be3be77
|
fix(examples): re-add html
|
[
{
"change_type": "ADD",
"diff": "+<!DOCTYPE html>\n+<html lang=\"en\">\n+\n+<head>\n+ <meta charset=\"UTF-8\">\n+ <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">\n+ <meta http-equiv=\"X-UA-Compatible\" content=\"ie=edge\">\n+ <title>router-basics2</title>\n+ <link href=\"https://unpkg.com/tachyons@4.9.1/css/tachyons.min.css\" rel=\"stylesheet\">\n+ <style>\n+ #debug {\n+ position: relative;\n+ }\n+\n+ a.toggle {\n+ display: inline-block;\n+ transform: rotate(-90deg);\n+ margin: 0;\n+ padding: 0.25rem 0.5rem;\n+ position: absolute;\n+ top: 3rem;\n+ background: #eee;\n+ color: black;\n+ text-align: right;\n+ text-decoration: none;\n+ border-top-right-radius: 5px;\n+ border-top-left-radius: 5px;\n+ font-size: 0.875rem;\n+ font-weight: 700;\n+ }\n+\n+ #debug.open a.toggle {\n+ left: -0.5rem;\n+ }\n+\n+ #debug.close a.toggle {\n+ right: -1rem;\n+ }\n+\n+ #debug.close pre {\n+ display: none;\n+ }\n+\n+ .fadeout {\n+ opacity: 0;\n+ transition: opacity .5s ease-in;\n+ transition-delay: .5s;\n+ }\n+ </style>\n+</head>\n+\n+<body>\n+ <div id=\"app\"></div>\n+ <footer class=\"fixed bottom-0 z-1 pa2 w-100 bg-black gray sans-serif\">\n+ <a class=\"link moon-gray\" href=\"https://github.com/thi-ng/umbrella/blob/master/examples/router-basics/src/\">Source code</a>, images by\n+ <a class=\"link moon-gray\" href=\"https://www.instagram.com/manomine/\">@manomine</a>\n+ </footer>\n+ <script type=\"text/javascript\" src=\"bundle.js\"></script>\n+</body>\n+\n+</html>\n\\ No newline at end of file\n",
"new_path": "examples/router-basics/public/index.html",
"old_path": null
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
fix(examples): re-add html
| 1
|
fix
|
examples
|
679,913
|
16.03.2018 00:06:14
| 0
|
e52e7e51c46b11843945e5c1d0694a35e2da4e54
|
feat(atom): add FX_FETCH & FX_DELAY sidefx impl, update docs
|
[
{
"change_type": "MODIFY",
"diff": "@@ -16,14 +16,35 @@ export type EffectDef = SideEffect | [SideEffect, number];\nexport type AsyncEffectDef = [string, any, string, string];\nexport type EffectPriority = [string, number];\n+// Built-in event ID constants\n+\nexport const EV_SET_VALUE = \"--set-value\";\nexport const EV_UPDATE_VALUE = \"--update-value\";\n-export const FX_STATE = \"--state\";\n+// Built-in side effect ID constants\n+\n+export const FX_CANCEL = \"--cancel\";\nexport const FX_DISPATCH = \"--dispatch\";\nexport const FX_DISPATCH_ASYNC = \"--dispatch-async\";\nexport const FX_DISPATCH_NOW = \"--dispatch-now\";\n-export const FX_CANCEL = \"--cancel\";\n+export const FX_DELAY = \"--delay\";\n+export const FX_FETCH = \"--fetch\";\n+export const FX_STATE = \"--state\";\n+\n+/**\n+ * Currently unused\n+ */\n+export const FX_REDO_RESTORE = \"--redo-restore\";\n+\n+/**\n+ * Currently unused\n+ */\n+export const FX_UNDO_STORE = \"--undo-store\";\n+\n+/**\n+ * Currently unused\n+ */\n+export const FX_UNDO_RESTORE = \"--undo-restore\";\nexport interface ReadonlyAtom<T> extends\napi.IDeref<T>,\n",
"new_path": "packages/atom/src/api.ts",
"old_path": "packages/atom/src/api.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -101,22 +101,71 @@ export class StatelessEventBus implements\n}\n/**\n- * Adds built-in event & side effect handlers:\n+ * Adds built-in event & side effect handlers. Also see additional\n+ * built-ins defined by the stateful `EventBus` extension of this\n+ * class, as well as comments for these class methods:\n+ *\n+ * - `mergeEffects()`\n+ * - `processEvent()`\n*\n* ### Handlers\n*\n- * currently none\n+ * currently none...\n*\n* ### Side effects\n*\n+ * #### `FX_CANCEL`\n+ *\n+ * If assigned `true`, cancels processing of current event, though\n+ * still applies any side effects already accumulated.\n+ *\n* #### `FX_DISPATCH`\n+ *\n+ * Dispatches assigned events to be processed in next frame.\n+ *\n* #### `FX_DISPATCH_ASYNC`\n*\n+ * Async wrapper for promise based side effects.\n+ *\n+ * #### `FX_DISPATCH_NOW`\n+ *\n+ * Dispatches assigned events as part of currently processed event\n+ * queue (no delay).\n+ *\n+ * #### `FX_DELAY`\n+ *\n+ * Async side effect. Only to be used in conjunction with\n+ * `FX_DISPATCH_ASYNC`. Triggers given event after `x` milliseconds.\n+ *\n+ * ```\n+ * // this triggers `[EV_SUCCESS, \"ok\"]` event after 1000 ms\n+ * { [FX_DISPATCH_ASYNC]: [FX_DELAY, [1000, \"ok\"], EV_SUCCESS, EV_ERROR] }\n+ * ```\n+ *\n+ * #### `FX_FETCH`\n+ *\n+ * Async side effect. Only to be used in conjunction with\n+ * `FX_DISPATCH_ASYNC`. Performs `fetch()` HTTP request and triggers\n+ * success with received response, or if there was an error with\n+ * response's `statusText`. The error event is only triggered if the\n+ * fetched response's `ok` field is non-truthy.\n+ *\n+ * - https://developer.mozilla.org/en-US/docs/Web/API/Response/ok\n+ * - https://developer.mozilla.org/en-US/docs/Web/API/Response/statusText\n+ *\n+ * ```\n+ * // fetches \"foo.json\" and then dispatches EV_SUCCESS or EV_ERROR event\n+ * { [FX_DISPATCH_ASYNC]: [FX_FETCH, \"foo.json\", EV_SUCCESS, EV_ERROR] }\n+ * ```\n*/\naddBuiltIns(): any {\n- this.addEffect(api.FX_DISPATCH, (e) => this.dispatch(e), -999);\n- this.addEffect(api.FX_DISPATCH_ASYNC,\n- ([id, arg, success, err]) => {\n+ this.addEffects({\n+\n+ [api.FX_DISPATCH]:\n+ [(e) => this.dispatch(e), -999],\n+\n+ [api.FX_DISPATCH_ASYNC]:\n+ [([id, arg, success, err]) => {\nconst fx = this.effects[id];\nif (fx) {\nconst p = fx(arg, this);\n@@ -129,9 +178,21 @@ export class StatelessEventBus implements\n} else {\nconsole.warn(`skipping invalid async effect: ${id}`);\n}\n- },\n- -999\n- );\n+ }, -999],\n+\n+ [api.FX_DELAY]:\n+ [([x, body]) => new Promise((res) => setTimeout(() => res(body), x)),\n+ 1000],\n+\n+ [api.FX_FETCH]:\n+ [(req) =>\n+ fetch(req).then((resp) => {\n+ if (!resp.ok) {\n+ throw new Error(resp.statusText);\n+ }\n+ return resp;\n+ }), 1000]\n+ });\n}\naddHandler(id: string, spec: api.EventDef) {\n",
"new_path": "packages/atom/src/event-bus.ts",
"old_path": "packages/atom/src/event-bus.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
feat(atom): add FX_FETCH & FX_DELAY sidefx impl, update docs
| 1
|
feat
|
atom
|
679,913
|
16.03.2018 00:08:00
| 0
|
357c46e0a032e53b31b02972daa2f1252a2e8aa6
|
feat(atom): add forwardSideFx() interceptor
|
[
{
"change_type": "MODIFY",
"diff": "@@ -8,6 +8,16 @@ export function trace(_, e) {\nconsole.log(\"event:\", e);\n}\n+/**\n+ * Higher-order interceptor. Return interceptor which unpacks payload\n+ * from event and assigns it as is to given side effect ID.\n+ *\n+ * @param id side effect ID\n+ */\n+export function forwardSideFx(id: string) {\n+ return (_, [__, body]) => ({ [id]: body });\n+}\n+\n/**\n* Higher-order interceptor for validation purposes. Takes a predicate\n* function and an optional interceptor function, which will only be\n",
"new_path": "packages/atom/src/interceptors.ts",
"old_path": "packages/atom/src/interceptors.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
feat(atom): add forwardSideFx() interceptor
| 1
|
feat
|
atom
|
791,859
|
16.03.2018 00:08:03
| -28,800
|
a58dc1fab30a3009d667aed473b739e4072b662e
|
core: look up custom gatherer relative to the config file path
|
[
{
"change_type": "MODIFY",
"diff": "@@ -336,7 +336,7 @@ class Config {\n// Store the directory of the config path, if one was provided.\nthis._configDir = configPath ? path.dirname(configPath) : undefined;\n- this._passes = Config.requireGatherers(configJSON.passes);\n+ this._passes = Config.requireGatherers(configJSON.passes, this._configDir);\nthis._audits = Config.requireAudits(configJSON.audits, this._configDir);\nthis._artifacts = expandArtifacts(configJSON.artifacts);\nthis._categories = configJSON.categories;\n",
"new_path": "lighthouse-core/config/config.js",
"old_path": "lighthouse-core/config/config.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -673,6 +673,16 @@ describe('Config', () => {\nassert.equal(typeof gatherer.instance.beforePass, 'function');\n});\n+ it('loads a gatherer relative to a config path', () => {\n+ const config = new Config({\n+ passes: [{gatherers: ['../fixtures/valid-custom-gatherer']}],\n+ }, __filename);\n+ const gatherer = config.passes[0].gatherers[0];\n+\n+ assert.equal(gatherer.instance.name, 'CustomGatherer');\n+ assert.equal(typeof gatherer.instance.beforePass, 'function');\n+ });\n+\nit('returns gatherer when gatherer class, not package-name string, is provided', () => {\nclass TestGatherer extends Gatherer {}\nconst gatherer = loadGatherer(TestGatherer);\n",
"new_path": "lighthouse-core/test/config/config-test.js",
"old_path": "lighthouse-core/test/config/config-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core: look up custom gatherer relative to the config file path (#4751)
| 1
|
core
| null |
217,922
|
16.03.2018 00:15:18
| -3,600
|
2600be256d4ed0dfbda948674bfd1b104937250c
|
chore: forgot to add menu in single recipe additions
|
[
{
"change_type": "MODIFY",
"diff": "<mat-input-container class=\"amount with-infix\">\n<input matInput type=\"number\" min=\"1\" value=\"1\" #amount>\n</mat-input-container>\n+\n<mat-menu #appMenu=\"matMenu\" class=\"lists-menu\">\n<button mat-menu-item (click)=\"addToNewList(recipe, amount.value, collectible.checked)\">\n<mat-icon>add</mat-icon>\n<span>{{'New_List' | translate}}</span></button>\n<button mat-menu-item *ngFor=\"let list of lists.basicLists\"\n+ (click)=\"addAllRecipes(list, list.$key)\">\n+ <mat-icon>playlist_play</mat-icon>\n+ <span>{{list.name}}</span>\n+ </button>\n+ <div *ngFor=\"let workshop of workshops | async\">\n+ <span mat-menu-item (click)=\"$event.stopPropagation();\">\n+ <mat-icon>folder_open</mat-icon>\n+ {{workshop.name}}\n+ </span>\n+ <button mat-menu-item *ngFor=\"let list of lists.rows[workshop.$key]\"\n+ class=\"workshop-list\"\n(click)=\"addRecipe(recipe, list, list.$key, amount.value, collectible.checked)\">\n<mat-icon>playlist_play</mat-icon>\n- <span>{{list.name}}</span></button>\n+ <span>{{list.name}}</span>\n+ </button>\n+ </div>\n</mat-menu>\n+\n<button mat-icon-button [matMenuTriggerFor]=\"appMenu\">\n<mat-icon>playlist_add</mat-icon>\n</button>\n",
"new_path": "src/app/pages/recipes/recipes/recipes.component.html",
"old_path": "src/app/pages/recipes/recipes/recipes.component.html"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore: forgot to add menu in single recipe additions
| 1
|
chore
| null |
679,913
|
16.03.2018 00:34:36
| 0
|
f1bc74d2364760830ce78e54bd8f6eb7f0d84c5e
|
docs: update readme files (add create-hdom-app instructions)
|
[
{
"change_type": "MODIFY",
"diff": "@@ -27,6 +27,18 @@ Stable, used in production and in active development.\nyarn add @thi.ng/atom\n```\n+**New since 2018-03-15: You can now create a preconfigured app skeleton\n+using @thi.ng/atom, @thi.ng/hdom & @thi.ng/router using the\n+[create-hdom-app](https://github.com/thi-ng/create-hdom-app) project generator:**\n+\n+```\n+yarn create hdom-app my-app\n+\n+cd my-app\n+yarn install\n+yarn start\n+```\n+\n## Usage examples\nSeveral projects in the\n",
"new_path": "packages/atom/README.md",
"old_path": "packages/atom/README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -92,6 +92,18 @@ This project is currently still in BETA. The overall \"API\" is stable, but there'\nyarn add @thi.ng/hdom\n```\n+**New since 2018-03-15: You can now create a preconfigured app skeleton\n+using @thi.ng/atom, @thi.ng/hdom & @thi.ng/router using the\n+[create-hdom-app](https://github.com/thi-ng/create-hdom-app) project generator:**\n+\n+```\n+yarn create hdom-app my-app\n+\n+cd my-app\n+yarn install\n+yarn start\n+```\n+\n## Usage examples\nEven though the overall approach should be obvious from the code examples\n",
"new_path": "packages/hdom/README.md",
"old_path": "packages/hdom/README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -20,6 +20,18 @@ Generic router for browser & non-browser based applications with support for:\nyarn add @thi.ng/router\n```\n+**New since 2018-03-15: You can now create a preconfigured app skeleton\n+using @thi.ng/atom, @thi.ng/hdom & @thi.ng/router using the\n+[create-hdom-app](https://github.com/thi-ng/create-hdom-app) project generator:**\n+\n+```\n+yarn create hdom-app my-app\n+\n+cd my-app\n+yarn install\n+yarn start\n+```\n+\n## Usage examples\nA complete, full commented demo app is here:\n",
"new_path": "packages/router/README.md",
"old_path": "packages/router/README.md"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
docs: update readme files (add create-hdom-app instructions)
| 1
|
docs
| null |
679,913
|
16.03.2018 00:34:54
| 0
|
d3d66436bdf48fdaab4945f7cc827e009ce05460
|
refactor(examples): update router-basics
|
[
{
"change_type": "MODIFY",
"diff": "\"start\": \"webpack-dev-server --open --mode development --devtool inline-source-map\"\n},\n\"dependencies\": {\n- \"@thi.ng/atom\": \"^0.12.1\",\n+ \"@thi.ng/atom\": \"^0.13.0\",\n\"@thi.ng/hdom\": \"^2.2.0\",\n\"@thi.ng/router\": \"^0.1.0\"\n},\n\"devDependencies\": {\n- \"typescript\": \"^2.7.2\",\n\"ts-loader\": \"^4.0.1\",\n+ \"typescript\": \"^2.7.2\",\n\"webpack\": \"^4.1.1\",\n\"webpack-cli\": \"^2.0.12\",\n\"webpack-dev-server\": \"^3.1.1\"\n",
"new_path": "examples/router-basics/package.json",
"old_path": "examples/router-basics/package.json"
},
{
"change_type": "MODIFY",
"diff": "-import { Event, FX_DISPATCH_ASYNC, FX_DISPATCH_NOW, EV_SET_VALUE } from \"@thi.ng/atom/api\";\n+import { Event, FX_DISPATCH_ASYNC, FX_DISPATCH_NOW, EV_SET_VALUE, FX_DELAY } from \"@thi.ng/atom/api\";\nimport { valueSetter, valueUpdater, trace } from \"@thi.ng/atom/interceptors\";\n-import { Route, EVENT_ROUTE_CHANGED } from \"@thi.ng/router/api\";\n+import { Route, RouteMatch, EVENT_ROUTE_CHANGED } from \"@thi.ng/router/api\";\nimport { AppConfig, StatusType } from \"./api\";\n@@ -67,7 +67,6 @@ export const EV_TOGGLE_DEBUG = \"toggle-debug\";\n// parts of the app should only use events)\nconst FX_JSON = \"load-json\";\n-const FX_DELAY = \"delay\";\n// main App configuration\nexport const CONFIG: AppConfig = {\n@@ -150,7 +149,7 @@ export const CONFIG: AppConfig = {\n}),\n// stores current route details\n- [EVENT_ROUTE_CHANGED]: valueSetter(\"route\"),\n+ [EVENT_ROUTE_CHANGED]: valueSetter<RouteMatch>(\"route\"),\n// stores status (a tuple of `[type, message, done?]`) in app state\n// if status type != DONE & `done` == true, also triggers delayed EV_DONE\n@@ -166,7 +165,7 @@ export const CONFIG: AppConfig = {\n],\n// toggles debug state flag on/off\n- [EV_TOGGLE_DEBUG]: valueUpdater(\"debug\", (x: number) => x ^ 1)\n+ [EV_TOGGLE_DEBUG]: valueUpdater<number>(\"debug\", (x) => x ^ 1)\n},\n// side effects\n@@ -178,12 +177,7 @@ export const CONFIG: AppConfig = {\nthrow new Error(resp.statusText);\n}\nreturn resp.json();\n- }),\n-\n- // resolves promise with `body` after `x` millis\n- // (`body` is the payload passed to success event)\n- [FX_DELAY]: ([x, body]) =>\n- new Promise((res) => setTimeout(() => res(body), x))\n+ })\n},\n// mapping route IDs to their respective UI component functions\n",
"new_path": "examples/router-basics/src/config.ts",
"old_path": "examples/router-basics/src/config.ts"
}
] |
TypeScript
|
Apache License 2.0
|
thi-ng/umbrella
|
refactor(examples): update router-basics
| 1
|
refactor
|
examples
|
217,922
|
16.03.2018 00:55:47
| -3,600
|
2aaf947e28d503d45b6e14706398899270b0d0a8
|
chore: remove useless ngModel breaking build process
|
[
{
"change_type": "MODIFY",
"diff": "<div class=\"input-container compact\">\n<mat-input-container>\n<mat-icon matPrefix>search</mat-icon>\n- <input class=\"filter\" [(ngModel)]=\"query\" matInput placeholder=\"{{'Gathering_name' | translate}}\" #filter>\n+ <input class=\"filter\" matInput placeholder=\"{{'Gathering_name' | translate}}\" #filter>\n<mat-hint align=\"end\">\n<small>{{'Data_from_gt' | translate}}</small>\n</mat-hint>\n",
"new_path": "src/app/pages/gathering-location/gathering-location/gathering-location.component.html",
"old_path": "src/app/pages/gathering-location/gathering-location/gathering-location.component.html"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore: remove useless ngModel breaking build process
| 1
|
chore
| null |
807,849
|
16.03.2018 10:46:17
| 25,200
|
6aa5e01152821b9e5af202fbb78a98799b3d0ef2
|
test(cli): Use copyFixture, git isn't needed
|
[
{
"change_type": "MODIFY",
"diff": "const execa = require(\"execa\");\nconst path = require(\"path\");\n+const tempy = require(\"tempy\");\n-const initFixture = require(\"@lerna-test/init-fixture\")(__dirname);\n+// git init is not necessary\n+const copyFixture = require(\"@lerna-test/copy-fixture\");\n-const BIN = path.join(__dirname, \"../cli.js\");\n-const bin = (args, options) => execa(BIN, args, options);\n+const CLI = path.join(__dirname, \"../cli.js\");\n+const bin = cwd => (...args) => execa(CLI, args, { cwd });\n/* global jasmine */\njasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;\n@@ -16,7 +18,7 @@ describe(\"cli\", () => {\nexpect.assertions(1);\ntry {\n- await bin([]);\n+ await bin()();\n} catch (err) {\nexpect(err.message).toContain(\"Pass --help to see all available commands and options.\");\n}\n@@ -27,7 +29,7 @@ describe(\"cli\", () => {\nlet error = null;\ntry {\n- await bin([\"--help\"]);\n+ await bin()(\"--help\");\n} catch (err) {\nerror = err;\n}\n@@ -36,9 +38,11 @@ describe(\"cli\", () => {\n});\nit(\"should prefer local installs\", async () => {\n- const cwd = await initFixture(\"local-install\");\n- const result = await bin([\"--verbose\"], { cwd });\n- expect(result.stdout).toContain(\"__fixtures__/local-install/node_modules/lerna/cli.js\");\n- expect(result.stdout).toContain(\"__fixtures__/local-install/node_modules/@lerna/cli/index.js\");\n+ const cwd = tempy.directory();\n+ await copyFixture(cwd, \"local-install\", __dirname);\n+\n+ const { stdout } = await bin(cwd)(\"--verbose\");\n+ expect(stdout).toContain(\"__fixtures__/local-install/node_modules/lerna/cli.js\");\n+ expect(stdout).toContain(\"__fixtures__/local-install/node_modules/@lerna/cli/index.js\");\n});\n});\n",
"new_path": "core/lerna/__tests__/cli.test.js",
"old_path": "core/lerna/__tests__/cli.test.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
test(cli): Use copyFixture, git isn't needed
| 1
|
test
|
cli
|
807,849
|
16.03.2018 10:46:28
| 25,200
|
54a4bbcbd87dd6f21b727dbb9df582853072a5c7
|
test(helpers): Use git init --template for config
|
[
{
"change_type": "MODIFY",
"diff": "\"use strict\";\n+const path = require(\"path\");\nconst execa = require(\"execa\");\n+// Contains all relevant git config (user, commit.gpgSign, etc)\n+const TEMPLATE = path.resolve(__dirname, \"template\");\n+\nmodule.exports = gitInit;\nfunction gitInit(cwd, ...args) {\n- return execa(\"git\", [\"init\", ...args], { cwd })\n- .then(() => execa(\"git\", [\"config\", \"commit.gpgSign\", \"false\"], { cwd }))\n- .then(() => execa(\"git\", [\"config\", \"user.email\", \"test@example.com\"], { cwd }))\n- .then(() => execa(\"git\", [\"config\", \"user.name\", \"Tester McPerson\"], { cwd }));\n+ return execa(\"git\", [\"init\", \"--template\", TEMPLATE, ...args], { cwd });\n}\n",
"new_path": "helpers/git-init/index.js",
"old_path": "helpers/git-init/index.js"
},
{
"change_type": "MODIFY",
"diff": "\"version\": \"0.0.0-test-only\",\n\"description\": \"A local test helper\",\n\"main\": \"index.js\",\n+ \"files\": [\n+ \"index.js\",\n+ \"template\"\n+ ],\n\"private\": true,\n\"license\": \"MIT\",\n\"dependencies\": {\n",
"new_path": "helpers/git-init/package.json",
"old_path": "helpers/git-init/package.json"
},
{
"change_type": "ADD",
"diff": "+[core]\n+ repositoryformatversion = 0\n+ filemode = true\n+ bare = false\n+ logallrefupdates = true\n+ ignorecase = true\n+[commit]\n+ gpgSign = false\n+[user]\n+ email = test@example.com\n+ name = Tester McPerson\n",
"new_path": "helpers/git-init/template/config",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+lerna-test-repo\n",
"new_path": "helpers/git-init/template/description",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+# git ls-files --others --exclude-from=.git/info/exclude\n+# Lines that start with '#' are comments.\n+# For a project mostly in C, the following would be a good set of\n+# exclude patterns (uncomment them if you want to use them):\n+node_modules\n+\n",
"new_path": "helpers/git-init/template/info/exclude",
"old_path": null
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
test(helpers): Use git init --template for config
| 1
|
test
|
helpers
|
730,429
|
16.03.2018 11:32:02
| 14,400
|
2d04b7e819b830531d4f255eaa3de4bfae038e2e
|
fix(widget-meet): remove duplicate incoming call handler
The incoming call handler is done with the media enhancer which already
is being used by the meet widget.
|
[
{
"change_type": "MODIFY",
"diff": "@@ -139,38 +139,6 @@ function handleCallNotification(props) {\n};\n}\n-/**\n- * Determines if call is a direct call\n- * @param {Object} call\n- * @returns {Boolean}\n- */\n-function isDirectCall(call) {\n- return call.isCall && call.to && call.from;\n-}\n-\n-function setupIncomingListeners(props) {\n- const {\n- spark,\n- widgetMeet\n- } = props;\n- const sparkInstance = spark.get('spark');\n- if (sparkInstance && !widgetMeet.status.isListeningForIncomingCalls) {\n- props.updateWidgetStatus({isListeningForIncomingCalls: true});\n- sparkInstance.phone.on('call:incoming', (incomingCall) => {\n- // if the incoming call matches our call locusUrl\n- if (\n- incomingCall.locusUrl === widgetMeet.callId // space or previous call\n- || (\n- widgetMeet.userId && isDirectCall(incomingCall)\n- && incomingCall.from.personUuid === widgetMeet.userId\n- ) // direct call from this user\n- ) {\n- props.handleAnswer();\n- }\n- });\n- }\n-}\n-\nexport default compose(\nconnect(\nnull,\n@@ -224,8 +192,6 @@ export default compose(\nnextProps.updateWidgetStatus({hasOpenWithCall: true});\nnextProps.handleCall();\n}\n-\n- setupIncomingListeners(nextProps);\n},\ncomponentWillUnmount() {\nif (this.props.isActive) {\n",
"new_path": "packages/node_modules/@ciscospark/widget-meet/src/enhancers/withCallHandlers.js",
"old_path": "packages/node_modules/@ciscospark/widget-meet/src/enhancers/withCallHandlers.js"
},
{
"change_type": "MODIFY",
"diff": "<body>\n<div style=\"float: left;\">\n<h2>Browser Globals</h2>\n+ <input id=\"token\" placeholder=\"Access Token\" value=\"<%= process.env.CISCOSPARK_ACCESS_TOKEN %>\" />\n+ <input id=\"to\" placeholder=\"To\" value=\"<%= process.env.SPACE_ID %>\" />\n<button onClick=\"createWidget()\">Create Widget</button>\n<button onClick=\"removeWidget()\">Remove Widget</button>\n<div style=\"width: 500px; height: 500px;\">\n<script type=\"text/javascript\">\nvar widgetEl = document.getElementById('ciscospark-widget-global');\nvar widgetEventsEl = document.getElementById('widget-events');\n+var tokenEl = document.getElementById('token');\n+var toEl = document.getElementById('to');\nfunction createWidget() {\nvar widget = ciscospark.widget(widgetEl);\nwidget.meetWidget({\n- accessToken: '<%= process.env.CISCOSPARK_ACCESS_TOKEN %>',\n- to: '<%= process.env.SPACE_ID %>',\n+ accessToken: tokenEl.value,\n+ to: toEl.value,\nonEvent: function(name, data) {\nwidgetEventsEl.innerText = name+'\\n'+data;\nconsole.log(data);\n",
"new_path": "packages/node_modules/@ciscospark/widget-meet/src/index.html",
"old_path": "packages/node_modules/@ciscospark/widget-meet/src/index.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -14,7 +14,6 @@ import {\n} from './actions';\nconst Status = Record({\n- isListeningForIncomingCalls: false,\nhasOpenWithCall: false,\nhasInitiatedCall: false // local user has clicked call button\n});\n",
"new_path": "packages/node_modules/@ciscospark/widget-meet/src/reducer.js",
"old_path": "packages/node_modules/@ciscospark/widget-meet/src/reducer.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
fix(widget-meet): remove duplicate incoming call handler
The incoming call handler is done with the media enhancer which already
is being used by the meet widget.
| 1
|
fix
|
widget-meet
|
791,834
|
16.03.2018 16:04:43
| 25,200
|
8d64c2617266925f51ba398ab7b3c8131d76ce2b
|
misc(tsc): reorganize and expose external interfaces
|
[
{
"change_type": "MODIFY",
"diff": "@@ -16,7 +16,6 @@ const runLighthouse = require('./run').runLighthouse;\nconst log = require('lighthouse-logger');\n// @ts-ignore\nconst perfOnlyConfig = require('../lighthouse-core/config/perf.json');\n-// @ts-ignore\nconst mixedContentConfig = require('../lighthouse-core/config/mixed-content.js');\n// @ts-ignore\nconst pkg = require('../package.json');\n",
"new_path": "lighthouse-cli/bin.js",
"old_path": "lighthouse-cli/bin.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -25,7 +25,7 @@ class Audit {\n}\n/**\n- * @return {Audit.ScoringModes}\n+ * @return {LH.Audit.ScoringModes}\n*/\nstatic get SCORING_MODES() {\nreturn {\n@@ -35,7 +35,7 @@ class Audit {\n}\n/**\n- * @return {Audit.Meta}\n+ * @return {LH.Audit.Meta}\n*/\nstatic get meta() {\nthrow new Error('Audit meta information must be overridden.');\n@@ -66,7 +66,7 @@ class Audit {\n/**\n* @param {typeof Audit} audit\n* @param {string} debugString\n- * @return {LH.AuditFullResult}\n+ * @return {LH.Audit.Result}\n*/\nstatic generateErrorAuditResult(audit, debugString) {\nreturn Audit.generateAuditResult(audit, {\n@@ -77,10 +77,10 @@ class Audit {\n}\n/**\n- * @param {Audit.Headings} headings\n+ * @param {Array<LH.Audit.Heading>} headings\n* @param {Array<Object<string, string>>} results\n- * @param {Audit.DetailsRenderer.DetailsSummary} summary\n- * @return {Audit.DetailsRenderer.DetailsJSON}\n+ * @param {LH.Audit.DetailsRendererDetailsSummary} summary\n+ * @return {LH.Audit.DetailsRendererDetailsJSON}\n*/\nstatic makeTableDetails(headings, results, summary) {\nif (results.length === 0) {\n@@ -102,8 +102,8 @@ class Audit {\n/**\n* @param {typeof Audit} audit\n- * @param {LH.AuditResult} result\n- * @return {{score: number, scoreDisplayMode: Audit.ScoringModeValues}}\n+ * @param {LH.Audit.Product} result\n+ * @return {{score: number, scoreDisplayMode: LH.Audit.ScoringModeValue}}\n*/\nstatic _normalizeAuditScore(audit, result) {\n// Cast true/false to 1/0\n@@ -125,8 +125,8 @@ class Audit {\n/**\n* @param {typeof Audit} audit\n- * @param {LH.AuditResult} result\n- * @return {LH.AuditFullResult}\n+ * @param {LH.Audit.Product} result\n+ * @return {LH.Audit.Result}\n*/\nstatic generateAuditResult(audit, result) {\nif (typeof result.rawValue === 'undefined') {\n@@ -173,59 +173,3 @@ class Audit {\n}\nmodule.exports = Audit;\n-\n-/**\n- * @typedef {Object} Audit.ScoringModes\n- * @property {'numeric'} NUMERIC\n- * @property {'binary'} BINARY\n- */\n-\n-/**\n- * @typedef {Audit.ScoringModes[keyof Audit.ScoringModes]} Audit.ScoringModeValues\n- */\n-\n-/**\n- * @typedef {Object} Audit.Meta\n- * @property {string} name\n- * @property {string} description\n- * @property {string} helpText\n- * @property {Array<string>} requiredArtifacts\n- * @property {string} [failureDescription]\n- * @property {boolean} [informative]\n- * @property {boolean} [manual]\n- * @property {Audit.ScoringModeValues} [scoreDisplayMode]\n- */\n-\n-/**\n- * @typedef {Object} Audit.Heading\n- * @property {string} key\n- * @property {string} itemType\n- * @property {string} text\n- */\n-\n-/**\n- * @typedef {Array<Audit.Heading>} Audit.Headings\n- */\n-\n-/**\n- * @typedef {Object} Audit.HeadingsResult\n- * @property {number} results\n- * @property {Audit.Headings} headings\n- * @property {boolean} passes\n- * @property {string} [debugString]\n- */\n-\n-// TODO: placeholder typedefs until Details are typed\n-/**\n- * @typedef {void} Audit.DetailsRenderer.DetailsSummary\n- * @property {number} [wastedMs]\n- * @property {number} [wastedKb]\n- */\n-\n-/**\n- * @typedef {object} Audit.DetailsRenderer.DetailsJSON\n- * @property {'table'} type\n- * @property {Array<Audit.Heading>} headings\n- * @property {Array<Object<string, string>>} items\n- * @property {Audit.DetailsRenderer.DetailsSummary} summary\n- */\n",
"new_path": "lighthouse-core/audits/audit.js",
"old_path": "lighthouse-core/audits/audit.js"
},
{
"change_type": "MODIFY",
"diff": "const INITIAL_CWD = 14 * 1024;\n-module.exports = class NetworkAnalyzer {\n+class NetworkAnalyzer {\n/**\n* @return {string}\n*/\n@@ -303,7 +303,9 @@ module.exports = class NetworkAnalyzer {\nconst estimatesByOrigin = NetworkAnalyzer._estimateResponseTimeByOrigin(records, rttByOrigin);\nreturn NetworkAnalyzer.summarize(estimatesByOrigin);\n}\n-};\n+}\n+\n+module.exports = NetworkAnalyzer;\n/**\n* @typedef NetworkAnalyzer.Summary\n",
"new_path": "lighthouse-core/lib/dependency-graph/simulator/network-analyzer.js",
"old_path": "lighthouse-core/lib/dependency-graph/simulator/network-analyzer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -122,7 +122,9 @@ class Util {\n* @return {string}\n*/\nstatic getURLDisplayName(parsedUrl, options) {\n- options = options || {};\n+ // Closure optional properties aren't optional in tsc, so fallback needs undefined values.\n+ options = options || {numPathParts: undefined, preserveQuery: undefined,\n+ preserveHost: undefined};\nconst numPathParts = options.numPathParts !== undefined ? options.numPathParts : 2;\nconst preserveQuery = options.preserveQuery !== undefined ? options.preserveQuery : true;\nconst preserveHost = options.preserveHost || false;\n",
"new_path": "lighthouse-core/report/v2/renderer/util.js",
"old_path": "lighthouse-core/report/v2/renderer/util.js"
},
{
"change_type": "MODIFY",
"diff": "\"mocha\": \"^3.2.0\",\n\"npm-run-posix-or-windows\": \"^2.0.2\",\n\"sinon\": \"^2.3.5\",\n- \"typescript\": \"2.7.2\",\n+ \"typescript\": \"^2.8.0-rc\",\n\"zone.js\": \"^0.7.3\"\n},\n\"dependencies\": {\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "\"lighthouse-core/lib/dependency-graph/**/*.js\",\n\"lighthouse-core/gather/connections/**/*.js\",\n\"lighthouse-core/gather/gatherers/gatherer.js\",\n- \"./typings/externs.d.ts\"\n+ \"./typings/*.d.ts\"\n],\n\"exclude\": [\n\"lighthouse-cli/test/**/*.js\"\n",
"new_path": "tsconfig.json",
"old_path": "tsconfig.json"
},
{
"change_type": "ADD",
"diff": "+/**\n+ * @license Copyright 2018 Google Inc. All Rights Reserved.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n+ */\n+\n+declare namespace LH.Audit {\n+ export interface ScoringModes {\n+ NUMERIC: 'numeric';\n+ BINARY: 'binary';\n+ }\n+\n+ export type ScoringModeValue = Audit.ScoringModes[keyof Audit.ScoringModes];\n+\n+ export interface Meta {\n+ name: string;\n+ description: string;\n+ helpText: string;\n+ requiredArtifacts: Array<string>;\n+ failureDescription?: string;\n+ informative?: boolean;\n+ manual?: boolean;\n+ scoreDisplayMode?: Audit.ScoringModeValue;\n+ }\n+\n+ export interface Heading {\n+ key: string;\n+ itemType: string;\n+ text: string;\n+ }\n+\n+ export interface HeadingsResult {\n+ results: number;\n+ headings: Array<Audit.Heading>;\n+ passes: boolean;\n+ debugString?: string;\n+ }\n+\n+ // TODO: placeholder typedefs until Details are typed\n+ export interface DetailsRendererDetailsSummary {\n+ wastedMs?: number;\n+ wastedBytes?: number;\n+ }\n+\n+ // TODO: placeholder typedefs until Details are typed\n+ export interface DetailsRendererDetailsJSON {\n+ type: 'table';\n+ headings: Array<Audit.Heading>;\n+ items: Array<{[x: string]: string}>;\n+ summary: DetailsRendererDetailsSummary;\n+ }\n+\n+ // Type returned by Audit.audit(). Only rawValue is required.\n+ export interface Product {\n+ rawValue: boolean | number | null;\n+ displayValue?: string;\n+ debugString?: string;\n+ score?: number;\n+ extendedInfo?: {value: string};\n+ notApplicable?: boolean;\n+ error?: boolean;\n+ // TODO: define details\n+ details?: object;\n+ }\n+\n+ /* Audit result returned in Lighthouse report. All audits offer a description and score of 0-1 */\n+ export interface Result {\n+ rawValue: boolean | number | null;\n+ displayValue: string;\n+ debugString?: string;\n+ score: number;\n+ scoreDisplayMode: ScoringModeValue;\n+ description: string;\n+ extendedInfo?: {value: string};\n+ notApplicable?: boolean;\n+ error?: boolean;\n+ name: string;\n+ helpText?: string;\n+ informative?: boolean;\n+ manual?: boolean;\n+ // TODO: define details\n+ details?: object;\n+ }\n+\n+ export interface Results {\n+ [metric: string]: Result;\n+ }\n+}\n",
"new_path": "typings/audit.d.ts",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -33,40 +33,9 @@ declare namespace LH {\nexport interface Config {}\n- export interface AuditResult {\n- rawValue: boolean | number | null;\n- displayValue?: string;\n- debugString?: string;\n- score?: number;\n- extendedInfo?: {value: string};\n- notApplicable?: boolean;\n- error?: boolean;\n- // TODO: define details\n- details?: object;\n- }\n-\n- export interface AuditResults {\n- [metric: string]: AuditResult;\n- }\n-\n- export interface AuditFullResult extends AuditResult {\n- displayValue: string;\n- score: number;\n- scoreDisplayMode: 'numeric' | 'binary';\n- description: string;\n- name: string;\n- helpText?: string;\n- informative?: boolean;\n- manual?: boolean;\n- }\n-\n- export interface AuditFullResults {\n- [metric: string]: AuditFullResult;\n- }\n-\nexport interface Results {\nurl: string;\n- audits: AuditFullResults;\n+ audits: LH.Audit.Results;\nlighthouseVersion: string;\nartifacts?: Object;\ninitialUrl: string;\n",
"new_path": "typings/externs.d.ts",
"old_path": "typings/externs.d.ts"
},
{
"change_type": "ADD",
"diff": "+/**\n+ * @license Copyright 2018 Google Inc. All Rights Reserved.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n+ */\n+\n+declare namespace LH.Gatherer {\n+ export interface PassContext {\n+ options: object;\n+ }\n+\n+ export interface LoadData {\n+ networkRecords: Array<LH.NetworkRequest>;\n+ devtoolsLog: Array<void>;\n+ trace: {trraceEvents: Array<LH.TraceEvent>}\n+ }\n+}\n",
"new_path": "typings/gatherer.d.ts",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -4097,9 +4097,9 @@ typedarray@^0.0.6:\nversion \"0.0.6\"\nresolved \"https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777\"\n-typescript@2.7.2:\n- version \"2.7.2\"\n- resolved \"https://registry.yarnpkg.com/typescript/-/typescript-2.7.2.tgz#2d615a1ef4aee4f574425cdff7026edf81919836\"\n+typescript@^2.8.0-rc:\n+ version \"2.8.0-rc\"\n+ resolved \"https://registry.yarnpkg.com/typescript/-/typescript-2.8.0-rc.tgz#a0256b7d1d39fb7493ba0403f55e95d31e8bc374\"\nuglify-js@^2.6:\nversion \"2.7.3\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
misc(tsc): reorganize and expose external interfaces (#4788)
| 1
|
misc
|
tsc
|
730,429
|
16.03.2018 16:14:31
| 14,400
|
ebb1bc9888733a3128114a8960df4d8947e4ea26
|
test(journeys): add wait for call to completely end
|
[
{
"change_type": "MODIFY",
"diff": "@@ -5,6 +5,7 @@ import '@ciscospark/internal-plugin-conversation';\nimport {moveMouse} from '../../../lib/test-helpers';\nimport {elements} from '../../../lib/test-helpers/space-widget/main';\n+import {elements as messageElements} from '../../../lib/test-helpers/space-widget/messaging';\nimport {answer, hangup, elements as meetElements} from '../../../lib/test-helpers/space-widget/meet';\nimport {constructHydraId} from '../../../lib/hydra';\n@@ -170,6 +171,16 @@ describe('Widget Space', () => {\nanswer(browserRemote);\nmoveMouse(browserLocal, meetElements.callContainer);\nhangup(browserLocal);\n+ hangup(browserRemote);\n+ // Wait for end of locus session before continuing\n+ browserLocal.waitUntil(\n+ () => {\n+ const message = browserLocal.getText(`${messageElements.lastActivity} ${messageElements.systemMessage}`);\n+ return message.includes('You had a meeting');\n+ },\n+ 25000,\n+ 'end of call message never posted to space'\n+ );\n});\nafter('refresh browsers to remove widgets', browser.refresh);\n",
"new_path": "test/journeys/specs/space/dataApi/startup-settings.js",
"old_path": "test/journeys/specs/space/dataApi/startup-settings.js"
}
] |
JavaScript
|
MIT License
|
webex/react-widgets
|
test(journeys): add wait for call to completely end
| 1
|
test
|
journeys
|
217,922
|
16.03.2018 22:18:38
| -3,600
|
a78888dbd63dc54385ba59385178bfa30e5b09db
|
fix: add ceil to trade details total amount
|
[
{
"change_type": "MODIFY",
"diff": "{{trade.itemAmount}}\n</div>\n<div class=\"trade-part\">\n- ({{'X_for_total' | translate: {amount: (trade.currencyAmount / trade.itemAmount) * (data.amount_needed - data.done)} }})\n+ ({{'X_for_total' | translate: {amount: getTotal(trade)} }})\n</div>\n</mat-list-item>\n</mat-list>\n",
"new_path": "src/app/modules/item/trade-details-popup/trade-details-popup.component.html",
"old_path": "src/app/modules/item/trade-details-popup/trade-details-popup.component.html"
},
{
"change_type": "MODIFY",
"diff": "import {Component, Inject} from '@angular/core';\nimport {MAT_DIALOG_DATA} from '@angular/material';\n+import {Trade} from '../../../model/list/trade';\n@Component({\nselector: 'app-trade-details-popup',\n@@ -10,4 +11,8 @@ export class TradeDetailsPopupComponent {\nconstructor(@Inject(MAT_DIALOG_DATA) public data: any) {\n}\n+\n+ getTotal(trade: Trade): number {\n+ return Math.ceil((trade.currencyAmount / trade.itemAmount) * (this.data.amount_needed - this.data.done));\n+ }\n}\n",
"new_path": "src/app/modules/item/trade-details-popup/trade-details-popup.component.ts",
"old_path": "src/app/modules/item/trade-details-popup/trade-details-popup.component.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
fix: add ceil to trade details total amount
| 1
|
fix
| null |
217,922
|
16.03.2018 22:20:41
| -3,600
|
5f0287c513d7617ef230a1a448ecfa8a97e6a832
|
chore(release): 3.4.0-beta.2
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"3.4.0-beta.2\"></a>\n+# [3.4.0-beta.2](https://github.com/Supamiu/ffxiv-teamcraft/compare/v3.4.0-beta.1...v3.4.0-beta.2) (2018-03-16)\n+\n+\n+### Bug Fixes\n+\n+* add ceil to trade details total amount ([a78888d](https://github.com/Supamiu/ffxiv-teamcraft/commit/a78888d))\n+* error in select all button when user has no masterbooks ([90e7d5c](https://github.com/Supamiu/ffxiv-teamcraft/commit/90e7d5c))\n+* missing help dialog box for list details page ([16c7ecd](https://github.com/Supamiu/ffxiv-teamcraft/commit/16c7ecd))\n+* missing translation in list layout dialog box ([6a40cbe](https://github.com/Supamiu/ffxiv-teamcraft/commit/6a40cbe))\n+* progression kept in list clones ([0ad5729](https://github.com/Supamiu/ffxiv-teamcraft/commit/0ad5729))\n+\n+\n+### Features\n+\n+* add filter for tradeable items ([f0bd572](https://github.com/Supamiu/ffxiv-teamcraft/commit/f0bd572)), closes [#267](https://github.com/Supamiu/ffxiv-teamcraft/issues/267)\n+* add ventures data extractor ([208562e](https://github.com/Supamiu/ffxiv-teamcraft/commit/208562e)), closes [#161](https://github.com/Supamiu/ffxiv-teamcraft/issues/161)\n+* custom list link (patreon supporters only) ([5f897cd](https://github.com/Supamiu/ffxiv-teamcraft/commit/5f897cd)), closes [#217](https://github.com/Supamiu/ffxiv-teamcraft/issues/217)\n+* hide when used ([dc74170](https://github.com/Supamiu/ffxiv-teamcraft/commit/dc74170)), closes [#247](https://github.com/Supamiu/ffxiv-teamcraft/issues/247)\n+* link patreon email to your profile for automatic patreon recognition ([e6e1cb2](https://github.com/Supamiu/ffxiv-teamcraft/commit/e6e1cb2))\n+* mark workshops as favourite ([0fa9d22](https://github.com/Supamiu/ffxiv-teamcraft/commit/0fa9d22)), closes [#255](https://github.com/Supamiu/ffxiv-teamcraft/issues/255)\n+\n+\n+\n<a name=\"3.4.0-beta.1\"></a>\n# [3.4.0-beta.1](https://github.com/Supamiu/ffxiv-teamcraft/compare/v3.4.0-beta.0...v3.4.0-beta.1) (2018-03-12)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"teamcraft\",\n- \"version\": \"3.4.0-beta.1\",\n+ \"version\": \"3.4.0-beta.2\",\n\"lockfileVersion\": 1,\n\"requires\": true,\n\"dependencies\": {\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"teamcraft\",\n- \"version\": \"3.4.0-beta.1\",\n+ \"version\": \"3.4.0-beta.2\",\n\"license\": \"MIT\",\n\"scripts\": {\n\"ng\": \"ng\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore(release): 3.4.0-beta.2
| 1
|
chore
|
release
|
217,922
|
16.03.2018 22:31:17
| -3,600
|
a0835a7646c90537fe8056a3655e965ae8985d41
|
chore: build-related fix
|
[
{
"change_type": "MODIFY",
"diff": "@@ -17,7 +17,7 @@ export class NicknamePopupComponent {\nconstructor(private linkService: CustomLinksService, private userService: UserService,\nprivate dialogRef: MatDialogRef<NicknamePopupComponent>,\n- @Inject(MAT_DIALOG_DATA) private data: { user: AppUser, hintTextKey: string, canCancel: boolean }) {\n+ @Inject(MAT_DIALOG_DATA) public data: { user: AppUser, hintTextKey: string, canCancel: boolean }) {\nthis.nickname = data.user.nickname;\n}\n",
"new_path": "src/app/pages/profile/nickname-popup/nickname-popup.component.ts",
"old_path": "src/app/pages/profile/nickname-popup/nickname-popup.component.ts"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore: build-related fix
| 1
|
chore
| null |
217,922
|
16.03.2018 22:41:36
| -3,600
|
eca86c6d7513cec350faffda2a3c4ff409960e39
|
chore: fix missing translations
|
[
{
"change_type": "MODIFY",
"diff": "-<h3 mat-dialog-title>{{\"Patreon_link_email\" | translate}}</h3>\n+<h3 mat-dialog-title>{{\"PROFILE.Patreon_link_email\" | translate}}</h3>\n<div mat-dialog-content>\n<form (submit)=\"submit()\">\n<mat-input-container>\n- <input type=\"text\" [formControl]=\"email\" matInput placeholder=\"{{'Patreon_email' | translate}}\">\n+ <input type=\"text\" [formControl]=\"email\" matInput placeholder=\"{{'PROFILE.Patreon_email' | translate}}\">\n</mat-input-container>\n- <mat-error *ngIf=\"alreadyUsed\">{{'Email_already_used' | translate}}</mat-error>\n+ <mat-error *ngIf=\"alreadyUsed\">{{'PROFILE.Email_already_used' | translate}}</mat-error>\n</form>\n</div>\n<div mat-dialog-actions>\n",
"new_path": "src/app/pages/profile/patreon-link-popup/patreon-link-popup.component.html",
"old_path": "src/app/pages/profile/patreon-link-popup/patreon-link-popup.component.html"
},
{
"change_type": "MODIFY",
"diff": "\"Patreon_features\": \"Patreon supporter features\",\n\"Feature_requires_nickname\": \"This feature requires you to set a nickname\",\n\"Nickname\": \"Nickname\",\n+ \"Patreon_link_email\": \"Link patreon email\",\n+ \"Email_already_used\": \"Email already linked to another account\",\n+ \"Patreon_email\": \"Patreon Email\",\n\"HELP\": {\n\"Welcome\": \"Welcome to profile page, this is the place where you can see and edit your own profile.\",\n\"Edit\": \"By clicking on the edit icon, you can edit the character linked to your FFXIV Teamcraft account.\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
},
{
"change_type": "MODIFY",
"diff": "\"Patreon_features\": \"Patreon supporter features\",\n\"Feature_requires_nickname\": \"This feature requires you to set a nickname\",\n\"Nickname\": \"Nickname\",\n+ \"Patreon_link_email\": \"Link patreon email\",\n+ \"Email_already_used\": \"Email already linked to another account\",\n+ \"Patreon_email\": \"Patreon Email\",\n\"HELP\": {\n\"Welcome\": \"Welcome to profile page, this is the place where you can see and edit your own profile.\",\n\"Edit\": \"By clicking on the edit icon, you can edit the character linked to your FFXIV Teamcraft account.\",\n",
"new_path": "src/assets/i18n/ja.json",
"old_path": "src/assets/i18n/ja.json"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
chore: fix missing translations
| 1
|
chore
| null |
217,922
|
16.03.2018 23:59:39
| -3,600
|
1f05c4227e63feeb57874e011a5796ecc7d87f65
|
fix: "NaN to reach total" sometimes shown on amount input fields
|
[
{
"change_type": "MODIFY",
"diff": "[value]=\"recipe.amount\"\nmin=\"1\"\nreadonly=\"{{readonly}}\"\n- (onchange)=\"onedit.emit($event)\">\n+ (onchange)=\"onedit.emit($event)\"\n+ [hideMissingAmount]=\"true\">\n</app-amount-input>\n<button mat-mini-fab *ngIf=\"!readonly\" (click)=\"delete()\">\n<mat-icon>delete</mat-icon>\n",
"new_path": "src/app/modules/common-components/recipe/recipe.component.html",
"old_path": "src/app/modules/common-components/recipe/recipe.component.html"
}
] |
TypeScript
|
MIT License
|
ffxiv-teamcraft/ffxiv-teamcraft
|
fix: "NaN to reach total" sometimes shown on amount input fields
| 1
|
fix
| null |
448,055
|
17.03.2018 11:05:14
| 18,000
|
db3eeb27bd4da1fd1a354b74c245c2d1ebe10759
|
docs: fix type and phrasing in README.md
|
[
{
"change_type": "MODIFY",
"diff": "@@ -315,7 +315,7 @@ The comments property can accept also a regex to selectively remove comments.\n#### License header\n-To prepend a license header on your budles:\n+To prepend a license header in your bundled files:\n```\n{\n",
"new_path": "README.md",
"old_path": "README.md"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
docs: fix type and phrasing in README.md (#697)
| 1
|
docs
| null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.