author int64 4.98k 943k | date stringdate 2017-04-15 16:45:02 2022-02-25 15:32:15 | timezone int64 -46,800 39.6k | hash stringlengths 40 40 | message stringlengths 8 468 | mods listlengths 1 16 | language stringclasses 9 values | license stringclasses 2 values | repo stringclasses 119 values | original_message stringlengths 12 491 | is_CCS int64 1 1 | commit_type stringclasses 129 values | commit_scope stringlengths 1 44 ⌀ |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
217,922 | 28.06.2018 14:10:57 | -7,200 | c76f415d68cc6126bd9446fb53be3961aff633f6 | chore: ux fixes | [
{
"change_type": "MODIFY",
"diff": "@@ -46,6 +46,7 @@ export class CharacterAddPopupComponent implements OnInit {\nmap(user => {\nif (user !== null && !user.anonymous) {\nuser.lodestoneId = id;\n+ user.verified = false;\nthis.userService.update(user.$key, user);\n}\n})\n",
"new_path": "src/app/modules/common-components/character-add-popup/character-add-popup.component.ts",
"old_path": "src/app/modules/common-components/character-add-popup/character-add-popup.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -4,14 +4,16 @@ import {AmountInputComponent} from './amount-input/amount-input.component';\nimport {ItemIconComponent} from './item-icon/item-icon.component';\nimport {RandomGifComponent} from './random-gif/random-gif.component';\nimport {\n- MatButtonModule, MatChipsModule,\n+ MatButtonModule,\n+ MatCheckboxModule,\n+ MatChipsModule,\nMatDialogModule,\nMatExpansionModule,\nMatIconModule,\nMatInputModule,\n- MatListModule, MatProgressSpinnerModule,\n+ MatListModule,\n+ MatProgressSpinnerModule,\nMatTooltipModule,\n- MatCheckboxModule,\n} from '@angular/material';\nimport {FormsModule, ReactiveFormsModule} from '@angular/forms';\nimport {TranslateModule} from '@ngx-translate/core';\n@@ -40,6 +42,7 @@ import { PermissionsRowComponent } from './permissions-popup/permissions-row/per\nimport {AddNewRowPopupComponent} from './permissions-popup/add-new-row-popup/add-new-row-popup.component';\nimport {FcCrestComponent} from './fc-crest/fc-crest.component';\nimport {AlarmGroupNamePopupComponent} from './alarm-group-name-popup/alarm-group-name-popup.component';\n+import {UserVerificationPopupComponent} from './user-verification-popup/user-verification-popup.component';\n@NgModule({\nimports: [\n@@ -91,6 +94,7 @@ import { AlarmGroupNamePopupComponent } from './alarm-group-name-popup/alarm-gro\nAddNewRowPopupComponent,\nFcCrestComponent,\nAlarmGroupNamePopupComponent,\n+ UserVerificationPopupComponent,\n],\nexports: [\nRandomGifComponent,\n@@ -119,6 +123,7 @@ import { AlarmGroupNamePopupComponent } from './alarm-group-name-popup/alarm-gro\nPermissionsPopupComponent,\nAddNewRowPopupComponent,\nAlarmGroupNamePopupComponent,\n+ UserVerificationPopupComponent,\n]\n})\nexport class CommonComponentsModule {\n",
"new_path": "src/app/modules/common-components/common-components.module.ts",
"old_path": "src/app/modules/common-components/common-components.module.ts"
},
{
"change_type": "ADD",
"diff": "+<h2 mat-dialog-title>{{'PROFILE.VERIFICATION.Title' | translate}}</h2>\n+<div mat-dialog-content>\n+ {{'PROFILE.VERIFICATION.Guide' | translate:{userId: user.$key} }}\n+</div>\n+<div mat-dialog-actions>\n+ <button mat-raised-button color=\"accent\" (click)=\"check()\">{{'PROFILE.VERIFICATION.Validate' | translate}}</button>\n+ <button mat-button color=\"warn\" mat-dialog-close>{{'Cancel' | translate}}</button>\n+</div>\n",
"new_path": "src/app/modules/common-components/user-verification-popup/user-verification-popup.component.html",
"old_path": null
},
{
"change_type": "ADD",
"diff": "",
"new_path": "src/app/modules/common-components/user-verification-popup/user-verification-popup.component.scss",
"old_path": "src/app/modules/common-components/user-verification-popup/user-verification-popup.component.scss"
},
{
"change_type": "ADD",
"diff": "+import {Component, Inject} from '@angular/core';\n+import {AppUser} from '../../../model/list/app-user';\n+import {MAT_DIALOG_DATA, MatDialogRef} from '@angular/material';\n+import {UserService} from '../../../core/database/user.service';\n+import {first, mergeMap} from 'rxjs/operators';\n+\n+@Component({\n+ selector: 'app-user-verification-popup',\n+ templateUrl: './user-verification-popup.component.html',\n+ styleUrls: ['./user-verification-popup.component.scss']\n+})\n+export class UserVerificationPopupComponent {\n+\n+ constructor(@Inject(MAT_DIALOG_DATA) private user: AppUser, private userService: UserService,\n+ private ref: MatDialogRef<UserVerificationPopupComponent>) {\n+ }\n+\n+ public check(): void {\n+ this.userService.getCharacter()\n+ .pipe(\n+ first(),\n+ mergeMap((character) => {\n+ this.user.verified = character.biography.indexOf(character.user.$key) > -1;\n+ return this.userService.set(this.user.$key, this.user);\n+ })\n+ )\n+ .subscribe(() => {\n+ this.ref.close();\n+ });\n+ }\n+\n+}\n",
"new_path": "src/app/modules/common-components/user-verification-popup/user-verification-popup.component.ts",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "<mat-card-subtitle>\n<div class=\"buyer-name\">\n{{author.name}}\n- <mat-icon *ngIf=\"author.verified\">verified_user</mat-icon>\n+ <mat-icon *ngIf=\"author.user.verified\">verified_user</mat-icon>\n-\n<span class=\"rating\">\n<span *ngFor=\"let star of getRating(author.user)\">\n<div>{{'COMMISSION_BOARD.Crafted_by' | translate}}</div>\n<img src=\"{{crafter.avatar}}\" alt=\"\" class=\"crafter-avatar\">\n<div class=\"crafter-name\">\n- <span>{{crafter.name}}<mat-icon\n- *ngIf=\"crafter.user.verified\">verified_user</mat-icon></span>\n+ <span class=\"name-and-badge\">{{crafter.name}}\n+ <mat-icon *ngIf=\"crafter.user.verified\">verified_user</mat-icon></span>\n<span class=\"rating\">\n<span *ngFor=\"let star of getRating(crafter.user)\">\n<mat-icon *ngIf=\"star === 1\">\n<button mat-raised-button\ncolor=\"accent\"\n[disabled]=\"!commission.isDone()\"\n- *ngIf=\"commission.status !== 2 && commission.authorId === user.$key\"\n+ *ngIf=\"commission.status === 1 && commission.authorId === user.$key\"\n(click)=\"markAsFinished(commission)\">\n<mat-icon>check</mat-icon>\n{{'COMMISSION_BOARD.Mark_as_finished' | translate}}\n</button>\n+ <a mat-button color=\"accent\"\n+ *ngIf=\"user.$key !== commission.authorId && commission.status < 2\"\n+ matBadge=\"\"\n+ [matBadgeHidden]=\"!hasChatBadge(commission, user)\"\n+ matBadgeColor=\"accent\"\n+ matBadgeSize=\"small\"\n+ routerLink=\"/commission/{{commission.server}}/{{commission.$key}}/chat/{{user.$key}}\">\n+ {{'COMMISSION_BOARD.Contact_buyer' | translate}}\n+ </a>\n</mat-card-actions>\n</mat-card>\n<div *ngIf=\"user$ | async as user\">\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.html",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.html"
},
{
"change_type": "MODIFY",
"diff": ".crafter-name {\ndisplay: flex;\nflex-direction: column;\n+ .name-and-badge {\n+ display: flex;\n+ align-items: center;\n+ }\n}\n}\n}\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.scss",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.scss"
},
{
"change_type": "MODIFY",
"diff": "<mat-grid-tile colspan=\"2\">\n<mat-card class=\"profile-card\">\n<mat-card-header>\n- <mat-card-title>{{character.name}}\n+ <mat-card-title>\n+ <span class=\"character-name\">\n+ {{character.name}}\n+ <mat-icon *ngIf=\"user.verified\">verified_user</mat-icon>\n+ <button mat-icon-button color=\"warn\"\n+ (click)=\"openVerificationPopup()\"\n+ *ngIf=\"!user.verified\"\n+ [matTooltip]=\"'PROFILE.User_not_verified'\"\n+ matTooltipPosition=\"above\">\n+ <mat-icon>warning</mat-icon>\n+ </button>\n<span *ngIf=\"user.providerId === 'firebase'\"> - {{user.email}}\n<button (click)=\"changeEmail()\" mat-icon-button>\n<mat-icon>edit</mat-icon>\n</button>\n</span>\n+ </span>\n</mat-card-title>\n<mat-card-subtitle>{{character.title}}</mat-card-subtitle>\n<div class=\"spacer\"></div>\n",
"new_path": "src/app/pages/profile/profile/profile.component.html",
"old_path": "src/app/pages/profile/profile/profile.component.html"
},
{
"change_type": "MODIFY",
"diff": "bottom: 5px;\nright: 5px;\n}\n+\n+ .character-name {\n+ display: flex;\n+ align-items: center;\n+ }\n}\n",
"new_path": "src/app/pages/profile/profile/profile.component.scss",
"old_path": "src/app/pages/profile/profile/profile.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -18,6 +18,7 @@ import {catchError, filter, map, mergeMap} from 'rxjs/operators';\nimport {StatsEditPopupComponent} from '../stats-edit-popup/stats-edit-popup.component';\nimport {ConfirmationPopupComponent} from '../../../modules/common-components/confirmation-popup/confirmation-popup.component';\nimport {combineLatest, of} from 'rxjs';\n+import {UserVerificationPopupComponent} from '../../../modules/common-components/user-verification-popup/user-verification-popup.component';\n@Component({\nselector: 'app-profile',\n@@ -102,6 +103,10 @@ export class ProfileComponent extends PageComponent {\n).subscribe(res => this.contacts = res));\n}\n+ public openVerificationPopup(): void {\n+ this.dialog.open(UserVerificationPopupComponent, {data: this.user});\n+ }\n+\npublic openNicknamePopup(): void {\nthis.dialog.open(NicknamePopupComponent, {data: {user: this.user}});\n}\n",
"new_path": "src/app/pages/profile/profile/profile.component.ts",
"old_path": "src/app/pages/profile/profile/profile.component.ts"
},
{
"change_type": "MODIFY",
"diff": "}\n}\n+ .character-name {\n+ display: flex;\n+ align-items: center;\n+ }\n+\n.patreon-badge {\nheight: 40px;\n}\n",
"new_path": "src/app/pages/profile/public-profile/public-profile.component.scss",
"old_path": "src/app/pages/profile/public-profile/public-profile.component.scss"
},
{
"change_type": "MODIFY",
"diff": "\"Patreon_email\": \"Patreon Email\",\n\"Contacts\": \"Contacts\",\n\"New_contact\": \"New contact's user ID\",\n+ \"User_not_verified\": \"User not verified, click to verify user\",\n+ \"VERIFICATION\": {\n+ \"Guide\": \"To verify your account, paste this code: \\\"{{userId}}\\\" inside your Lodestone profile biography and click the button below.\",\n+ \"Validate\": \"Validate\"\n+ },\n\"HELP\": {\n\"Welcome\": \"Welcome to profile page, this is the place where you can see and edit your own profile.\",\n\"Edit\": \"By clicking on the edit icon, you can edit the character linked to your FFXIV Teamcraft account.\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: ux fixes | 1 | chore | null |
730,413 | 28.06.2018 14:52:31 | 14,400 | 2263166a96d9d189c173c099f4ff09f0001dfc10 | fix(tooling): cannot run journey tests locally | [
{
"change_type": "MODIFY",
"diff": "@@ -31,7 +31,6 @@ const screenResolution = platform.toLowerCase().includes('os x') || platform ===\nconst chromeCapabilities = {\nbrowserName: 'chrome',\n- name: `react-widget-${suite}`,\nchromeOptions: {\nargs: [\n'--use-fake-device-for-media-stream',\n@@ -41,24 +40,10 @@ const chromeCapabilities = {\nprefs: {\n'profile.default_content_setting_values.notifications': 2\n}\n- },\n- idleTimeout: 300,\n- commandTimeout: 600,\n- maxDuration: 3600,\n- seleniumVersion: '3.4.0',\n- screenResolution,\n- platform,\n- version\n+ }\n};\nconst firefoxCapabilities = {\n- browserName: 'firefox',\n- name: `react-widget-${suite}`,\n- idleTimeout: 300,\n- maxDuration: 3600,\n- seleniumVersion: '3.4.0',\n- screenResolution,\n- platform,\n- version\n+ browserName: 'firefox'\n};\nlet mochaTimeout = 60000;\n@@ -341,6 +326,31 @@ exports.config = {\n};\nif (process.env.SAUCE) {\n+ let sauceCapabilities;\n+ if (browser === 'chrome') {\n+ sauceCapabilities = Object.assign({}, chromeCapabilities, {\n+ name: `react-widget-${suite}`,\n+ idleTimeout: 300,\n+ commandTimeout: 600,\n+ maxDuration: 3600,\n+ seleniumVersion: '3.4.0',\n+ screenResolution,\n+ platform,\n+ version\n+ });\n+ }\n+ else {\n+ sauceCapabilities = Object.assign({}, firefoxCapabilities, {\n+ name: `react-widget-${suite}`,\n+ idleTimeout: 300,\n+ commandTimeout: 600,\n+ maxDuration: 3600,\n+ seleniumVersion: '3.4.0',\n+ screenResolution,\n+ platform,\n+ version\n+ });\n+ }\nexports.config = Object.assign(exports.config, {\ndeprecationWarnings: false, // Deprecation warnings on sauce just make the logs noisy\nuser: process.env.SAUCE_USERNAME,\n@@ -357,6 +367,14 @@ if (process.env.SAUCE) {\n],\ntunnelIdentifier: tunnelId,\nport: process.env.SAUCE_CONNECT_PORT || 4445\n+ },\n+ capabilities: {\n+ browserLocal: {\n+ desiredCapabilities: sauceCapabilities\n+ },\n+ browserRemote: {\n+ desiredCapabilities: sauceCapabilities\n+ }\n}\n});\n}\n",
"new_path": "wdio.conf.js",
"old_path": "wdio.conf.js"
}
] | JavaScript | MIT License | webex/react-widgets | fix(tooling): cannot run journey tests locally | 1 | fix | tooling |
730,429 | 28.06.2018 14:54:00 | 14,400 | 3b9f60db50da7098c7c8bbd681b0d1a54ac56a90 | chore(tooling): static firefox at version 60
Once the sdk is fixed, we can test on later versions. | [
{
"change_type": "MODIFY",
"diff": "@@ -80,7 +80,7 @@ jobs:\ncommand: |\nset -m\n(\n- (PORT=4569 SAUCE_CONNECT_PORT=5006 BROWSER=firefox npm run test:integration || kill 0) &\n+ (PORT=4569 SAUCE_CONNECT_PORT=5006 BROWSER=firefox VERSION=60 npm run test:integration || kill 0) &\n(sleep 60; PORT=4568 SAUCE_CONNECT_PORT=5005 BROWSER=chrome npm run test:integration || kill 0) &\n(sleep 120; PORT=4567 SAUCE_CONNECT_PORT=5004 BROWSER=chrome PLATFORM=\"windows 10\" npm run test:integration || kill 0) &\nwait\n",
"new_path": ".circleci/config.yml",
"old_path": ".circleci/config.yml"
},
{
"change_type": "MODIFY",
"diff": "@@ -164,7 +164,7 @@ ansiColor('xterm') {\nexport BUILD_NUMBER=\"pipeline-build-$BUILD_NUMBER\"\nset -m\n(\n- (CISCOSPARK_CLIENT_ID=C873b64d70536ed26df6d5f81e01dafccbd0a0af2e25323f7f69c7fe46a7be340 SAUCE=true PORT=4569 SAUCE_CONNECT_PORT=5006 BROWSER=firefox npm run test:integration || kill 0) &\n+ (CISCOSPARK_CLIENT_ID=C873b64d70536ed26df6d5f81e01dafccbd0a0af2e25323f7f69c7fe46a7be340 SAUCE=true PORT=4569 SAUCE_CONNECT_PORT=5006 BROWSER=firefox VERSION=60 npm run test:integration || kill 0) &\n(sleep 60; CISCOSPARK_CLIENT_ID=C873b64d70536ed26df6d5f81e01dafccbd0a0af2e25323f7f69c7fe46a7be340 SAUCE=true PORT=4568 SAUCE_CONNECT_PORT=5005 BROWSER=chrome npm run test:integration || kill 0) &\n(sleep 120; CISCOSPARK_CLIENT_ID=C873b64d70536ed26df6d5f81e01dafccbd0a0af2e25323f7f69c7fe46a7be340 SAUCE=true PORT=4567 SAUCE_CONNECT_PORT=5004 BROWSER=chrome PLATFORM=\"windows 10\" npm run test:integration || kill 0) &\nwait\n",
"new_path": "Jenkinsfile",
"old_path": "Jenkinsfile"
}
] | JavaScript | MIT License | webex/react-widgets | chore(tooling): static firefox at version 60
Once the sdk is fixed, we can test on later versions. | 1 | chore | tooling |
217,922 | 28.06.2018 15:52:02 | -7,200 | e396a254165b6f05c884589c8d74a2ab9e6887d3 | chore: new badge for commissions that only require crafting | [
{
"change_type": "MODIFY",
"diff": "@@ -27,6 +27,11 @@ export class Commission extends DataModel {\n*/\nprice = 0;\n+ /**\n+ * Determines if the list has all the mats for crafts, and a crafter only can fill the commission, as he just has to craft things.\n+ */\n+ onlyNeedsCraft: boolean;\n+\n/**\n* The id of the request's author.\n*/\n",
"new_path": "src/app/model/commission/commission.ts",
"old_path": "src/app/model/commission/commission.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -383,6 +383,21 @@ export class List extends DataWithPermissions {\nreturn res;\n}\n+ public onlyNeedsCrafts(): boolean {\n+ // We init a boolean to true for the result.\n+ let onlyNeedsCrafts = true;\n+ // If one of the non-craftable items is not finished, set the boolean to false\n+ this.forEach((row) => {\n+ if (row.id < 20 && row.id > 1) {\n+ return;\n+ }\n+ if (row.craftedBy === undefined || row.craftedBy.length === 0) {\n+ onlyNeedsCrafts = onlyNeedsCrafts && row.done >= row.amount;\n+ }\n+ });\n+ return onlyNeedsCrafts;\n+ }\n+\npublic resetDone(item: ListRow): void {\nitem.done = 0;\nitem.used = 0;\n",
"new_path": "src/app/model/list/list.ts",
"old_path": "src/app/model/list/list.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -30,6 +30,8 @@ export class CommissionCreationPopupComponent {\nmergeMap(character => {\nconst commission = new Commission(character.userId, this.list, character.server);\ncommission.price = this.price;\n+ commission.onlyNeedsCraft = this.list.onlyNeedsCrafts();\n+ console.log(commission.onlyNeedsCraft);\nreturn this.commissionService.add(commission)\n.pipe(\nmap(res => {\n@@ -40,19 +42,16 @@ export class CommissionCreationPopupComponent {\n})\n);\n}),\n- mergeMap((res) => {\n+ mergeMap(() => {\n// Delete list author id to detach it from the author, keeping it attached to the commission.\ndelete this.list.authorId;\nthis.list.permissionsRegistry = new PermissionsRegistry();\nthis.list.permissionsRegistry.everyone = {read: true, write: false, participate: false};\n// Save the list\n- return this.listService.set(this.list.$key, this.list)\n- .pipe(\n- map(() => res)\n- );\n+ return this.listService.set(this.list.$key, this.list);\n})\n)\n- .subscribe(res => {\n+ .subscribe(() => {\nthis.router.navigate(['commissions', 'my-requests']);\nthis.ref.close()\n});\n",
"new_path": "src/app/pages/commission-board/commission-creation-popup/commission-creation-popup.component.ts",
"old_path": "src/app/pages/commission-board/commission-creation-popup/commission-creation-popup.component.ts"
},
{
"change_type": "MODIFY",
"diff": "(click)=\"fireCrafter(commission, crafter.user)\">\n<mat-icon>clear</mat-icon>\n</button>\n+ <button mat-icon-button\n+ color=\"warn\"\n+ *ngIf=\"(user$ | async)?.$key === commission.crafterId && commission.status === 1\"\n+ matTooltip=\"{{'COMMISSION_BOARD.Withdraw' | translate}}\"\n+ (click)=\"withdrawCrafter(commission, author.user)\">\n+ <mat-icon>clear</mat-icon>\n+ </button>\n</div>\n</div>\n<div class=\"right-header\">\n<div *ngFor=\"let candidateId of commission.candidateIds\">\n<mat-list-item *ngIf=\"getCharacter(candidateId) | async as candidate\">\n<img mat-list-avatar src=\"{{candidate.avatar}}\" alt=\"\">\n- <span matLine>{{candidate.name}}\n+ <span matLine>\n+ <span class=\"candidate-name\">\n+ {{candidate.name}}\n<mat-icon *ngIf=\"candidate.user.verified\">verified_user</mat-icon>\n</span>\n+ </span>\n<span matLine class=\"rating\">\n<span *ngFor=\"let star of getRating(candidate.user)\">\n<mat-icon *ngIf=\"star === 1\">\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.html",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.html"
},
{
"change_type": "MODIFY",
"diff": "align-items: center;\n}\n+.candidate-name {\n+ display: flex;\n+ align-items: center;\n+}\n+\n.crafter-container {\nflex: 1 1 auto;\n.crafter {\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.scss",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -141,7 +141,48 @@ export class CommissionDetailsComponent implements OnInit {\nmap(() => {\ncommission.status = CommissionStatus.CREATED;\ndelete commission.crafterId;\n- commission.addNewThing(`application:${crafter.$key}`);\n+ return commission;\n+ }),\n+ mergeMap(com => {\n+ return this.commissionService.set(com.$key, com)\n+ .pipe(\n+ map(() => {\n+ return com;\n+ })\n+ )\n+ }),\n+ mergeMap(com => {\n+ return this.listService.get(com.listId)\n+ .pipe(\n+ first(),\n+ map(list => {\n+ delete list.authorId;\n+ delete list.commissionId;\n+ return list;\n+ }),\n+ mergeMap(list => {\n+ return this.listService.set(list.$key, list);\n+ })\n+ )\n+ })\n+ ).subscribe()\n+ }\n+\n+ withdrawCrafter(commission: Commission, author: AppUser): void {\n+ this.dialog.open(ConfirmationPopupComponent, {data: 'COMMISSION_BOARD.Confirm_withdraw'})\n+ .afterClosed()\n+ .pipe(\n+ filter(res => res),\n+ mergeMap(() => {\n+ return this.dialog.open(RatingPopupComponent, {data: author}).afterClosed();\n+ }),\n+ filter(closed => closed !== 'cancel')\n+ ).pipe(\n+ map(() => {\n+ commission.status = CommissionStatus.CREATED;\n+ commission.candidateIds = commission.candidateIds.filter(id => id !== commission.crafterId);\n+ delete commission.crafterId;\n+ commission.addNewThing(`application:${author.$key}`);\nreturn commission;\n}),\nmergeMap(com => {\n@@ -254,6 +295,7 @@ export class CommissionDetailsComponent implements OnInit {\nmergeMap(data => {\nreturn this.getCharacter(data[0].crafterId)\n.pipe(\n+ first(),\nmergeMap(character => {\nreturn this.dialog.open(RatingPopupComponent, {data: character.user})\n.afterClosed()\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.ts",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.ts"
},
{
"change_type": "MODIFY",
"diff": "<mat-chip selectable=\"false\" color=\"accent\" selected>{{('COMMISSION_BOARD.STATUS.' + getStatus(commission))\n| translate}}\n</mat-chip>\n+ <mat-chip selectable=\"false\" *ngIf=\"commission.onlyNeedsCraft\">{{'COMMISSION_BOARD.TAGS.Only_craft' |\n+ translate}}\n+ </mat-chip>\n<mat-chip selectable=\"false\" *ngIf=\"commission.isCrafting()\">{{'COMMISSION_BOARD.TAGS.Crafting' |\ntranslate}}\n</mat-chip>\n",
"new_path": "src/app/pages/commission-board/commission-panel/commission-panel.component.html",
"old_path": "src/app/pages/commission-board/commission-panel/commission-panel.component.html"
},
{
"change_type": "MODIFY",
"diff": "\"Rating_description\": \"Please take a moment to rate the other user\",\n\"Commissions\": \"Commissions\",\n\"Confirm_archive\": \"Are you sure? This can't be undone.\",\n+ \"Withdraw\": \"Withdraw from the commission\",\n+ \"Confirm_withdraw\": \"Are you sure you want to withdraw from the commission? This can't be undone.\",\n\"STATUS\": {\n\"CREATED\": \"Opened\",\n\"ACCEPTED\": \"In Progress\",\n\"TAGS\": {\n\"Crafting\": \"Crafting\",\n\"Gathering\": \"Gathering\",\n- \"Hunting\": \"Hunting\"\n+ \"Hunting\": \"Hunting\",\n+ \"Only_craft\": \"Materials included\"\n}\n}\n}\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: new badge for commissions that only require crafting | 1 | chore | null |
217,927 | 28.06.2018 16:34:29 | 0 | 50f16da0db7cdebe621a7ea466aeed25b3aaed36 | feat: add specialist stat bonus
When a player is a specialist, they receive a bonus of 20 to both
craftsmanship and control. This feature will reflect that bonus in the
crafting simulator. | [
{
"change_type": "MODIFY",
"diff": "@@ -531,6 +531,7 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nlet bonusFromFood = 0;\nlet bonusFromMedicine = 0;\nlet bonusFromFreeCompanyAction = 0;\n+ let bonusFromSpecialist = 0;\nif (this._selectedFood !== undefined) {\nconst foodBonus = this._selectedFood.getBonus(bonusType);\n@@ -555,7 +556,11 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nbonusFromFreeCompanyAction = this.getFreeCompanyActionValue(bonusType);\n}\n- return bonusFromFood + bonusFromMedicine + bonusFromFreeCompanyAction;\n+ if (this.selectedSet.specialist && bonusType !== <BonusType>'CP') {\n+ bonusFromSpecialist = 20;\n+ }\n+\n+ return bonusFromFood + bonusFromMedicine + bonusFromFreeCompanyAction + bonusFromSpecialist;\n}\ngetFreeCompanyActionValue(bonusType: BonusType): number {\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: add specialist stat bonus
When a player is a specialist, they receive a bonus of 20 to both
craftsmanship and control. This feature will reflect that bonus in the
crafting simulator. | 1 | feat | null |
791,690 | 28.06.2018 16:38:44 | 25,200 | db2265dd550c3d509be190ca2d3ac398d271e5da | core: convert requestIds before sending to backend | [
{
"change_type": "MODIFY",
"diff": "@@ -9,6 +9,7 @@ const NetworkRecorder = require('../lib/network-recorder');\nconst emulation = require('../lib/emulation');\nconst Element = require('../lib/element');\nconst LHError = require('../lib/errors');\n+const NetworkRequest = require('../lib/network-request');\nconst EventEmitter = require('events').EventEmitter;\nconst URL = require('../lib/url-shim');\nconst TraceParser = require('../lib/traces/trace-parser');\n@@ -727,6 +728,8 @@ class Driver {\n* @return {Promise<string>}\n*/\ngetRequestContent(requestId, timeout = 1000) {\n+ requestId = NetworkRequest.getRequestIdForBackend(requestId);\n+\nreturn new Promise((resolve, reject) => {\n// If this takes more than 1s, reject the Promise.\n// Why? Encoding issues can lead to hanging getResponseBody calls: https://github.com/GoogleChrome/lighthouse/pull/4718\n",
"new_path": "lighthouse-core/gather/driver.js",
"old_path": "lighthouse-core/gather/driver.js"
},
{
"change_type": "MODIFY",
"diff": "const Gatherer = require('../gatherer');\nconst URL = require('../../../lib/url-shim');\n+const NetworkRequest = require('../../../lib/network-request');\nconst Sentry = require('../../../lib/sentry');\nconst Driver = require('../../driver.js'); // eslint-disable-line no-unused-vars\n@@ -114,6 +115,8 @@ class OptimizedImages extends Gatherer {\n* @return {Promise<LH.Crdp.Audits.GetEncodedResponseResponse>}\n*/\n_getEncodedResponse(driver, requestId, encoding) {\n+ requestId = NetworkRequest.getRequestIdForBackend(requestId);\n+\nconst quality = encoding === 'jpeg' ? JPEG_QUALITY : WEBP_QUALITY;\nconst params = {requestId, encoding, quality, sizeOnly: true};\nreturn driver.sendCommand('Audits.getEncodedResponse', params);\n",
"new_path": "lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js",
"old_path": "lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -264,6 +264,16 @@ module.exports = class NetworkRequest {\nthis._responseReceivedTime = Math.min(this.endTime, this._responseReceivedTime);\n}\n+ /**\n+ * Convert the requestId to backend-version by removing the `:redirect` portion\n+ *\n+ * @param {string} requestId\n+ * @return {string}\n+ */\n+ static getRequestIdForBackend(requestId) {\n+ return requestId.replace(/(:redirect)+$/, '');\n+ }\n+\n/**\n* Based on DevTools NetworkManager.\n* @see https://github.com/ChromeDevTools/devtools-frontend/blob/3415ee28e86a3f4bcc2e15b652d22069938df3a6/front_end/sdk/NetworkManager.js#L285-L297\n",
"new_path": "lighthouse-core/lib/network-request.js",
"old_path": "lighthouse-core/lib/network-request.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -145,7 +145,7 @@ describe('Browser Driver', () => {\n});\nit('throws if getRequestContent takes too long', () => {\n- return driverStub.getRequestContent(0, MAX_WAIT_FOR_PROTOCOL).then(_ => {\n+ return driverStub.getRequestContent('', MAX_WAIT_FOR_PROTOCOL).then(_ => {\nassert.ok(false, 'long-running getRequestContent supposed to reject');\n}, e => {\nassert.equal(e.code, 'REQUEST_CONTENT_TIMEOUT');\n",
"new_path": "lighthouse-core/test/gather/driver-test.js",
"old_path": "lighthouse-core/test/gather/driver-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -20,6 +20,7 @@ const fakeImageStats = {\nconst traceData = {\nnetworkRecords: [\n{\n+ _requestId: '123.5',\n_url: 'http://google.com/image.jpg',\n_mimeType: 'image/jpeg',\n_resourceSize: 10000,\n@@ -28,6 +29,7 @@ const traceData = {\nfinished: true,\n},\n{\n+ _requestId: '123.6:redirect',\n_url: 'http://google.com/transparent.png',\n_mimeType: 'image/png',\n_resourceSize: 11000,\n@@ -36,6 +38,7 @@ const traceData = {\nfinished: true,\n},\n{\n+ _requestId: '123.5',\n_url: 'http://google.com/image.bmp',\n_mimeType: 'image/bmp',\n_resourceSize: 12000,\n@@ -44,6 +47,7 @@ const traceData = {\nfinished: true,\n},\n{\n+ _requestId: '123.5',\n_url: 'http://google.com/image.bmp',\n_mimeType: 'image/bmp',\n_resourceSize: 12000,\n@@ -52,6 +56,7 @@ const traceData = {\nfinished: true,\n},\n{\n+ _requestId: '123.5',\n_url: 'http://google.com/vector.svg',\n_mimeType: 'image/svg+xml',\n_resourceSize: 13000,\n@@ -60,6 +65,7 @@ const traceData = {\nfinished: true,\n},\n{\n+ _requestId: '123.5',\n_url: 'http://gmail.com/image.jpg',\n_mimeType: 'image/jpeg',\n_resourceSize: 15000,\n@@ -68,6 +74,7 @@ const traceData = {\nfinished: true,\n},\n{\n+ _requestId: '123.5',\n_url: 'data: image/jpeg ; base64 ,SgVcAT32587935321...',\n_mimeType: 'image/jpeg',\n_resourceType: 'Image',\n@@ -76,6 +83,7 @@ const traceData = {\nfinished: true,\n},\n{\n+ _requestId: '123.5',\n_url: 'http://google.com/big-image.bmp',\n_mimeType: 'image/bmp',\n_resourceType: 'Image',\n@@ -84,6 +92,7 @@ const traceData = {\nfinished: false, // ignore for not finishing\n},\n{\n+ _requestId: '123.5',\n_url: 'http://google.com/not-an-image.bmp',\n_mimeType: 'image/bmp',\n_resourceType: 'Document', // ignore for not really being an image\n@@ -162,7 +171,9 @@ describe('Optimized images', () => {\n});\nit('supports Audits.getEncodedResponse', () => {\n+ const calls = [];\noptions.driver.sendCommand = (method, params) => {\n+ calls.push({method, params});\nconst encodedSize = params.encoding === 'webp' ? 60 : 80;\nreturn Promise.resolve({encodedSize});\n};\n@@ -174,6 +185,8 @@ describe('Optimized images', () => {\nassert.equal(artifact[0].jpegSize, 80);\n// supports cross-origin\nassert.ok(/gmail.*image.jpg/.test(artifact[3].url));\n+ // strips the :redirect from requestId\n+ assert.equal(calls[2].params.requestId, '123.6');\n});\n});\n});\n",
"new_path": "lighthouse-core/test/gather/gatherers/dobetterweb/optimized-images-test.js",
"old_path": "lighthouse-core/test/gather/gatherers/dobetterweb/optimized-images-test.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core: convert requestIds before sending to backend (#5580) | 1 | core | null |
679,905 | 28.06.2018 17:10:54 | -7,200 | 8c7d9376f8bcc80dc136add026c21a181e3dabba | fix(rstream): unsubscribe on error in transduce() | [
{
"change_type": "MODIFY",
"diff": "@@ -21,6 +21,7 @@ export function transduce<A, B, C>(src: Subscription<any, A>, tx: Transducer<A,\nresolve(acc);\n},\nerror(e) {\n+ sub.unsubscribe();\nreject(e);\n}\n}, tx);\n",
"new_path": "packages/rstream/src/subs/transduce.ts",
"old_path": "packages/rstream/src/subs/transduce.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | fix(rstream): unsubscribe on error in transduce() | 1 | fix | rstream |
791,723 | 28.06.2018 19:03:22 | -3,600 | 3474c3910d87563a09bd18284abf1df56529bcc9 | core(pwa): revamp and move short_name_length audit | [
{
"change_type": "MODIFY",
"diff": "@@ -14,9 +14,8 @@ class ManifestShortNameLength extends Audit {\nstatic get meta() {\nreturn {\nid: 'manifest-short-name-length',\n- title: 'Manifest\\'s `short_name` won\\'t be truncated when displayed on homescreen',\n- failureTitle: 'Manifest\\'s `short_name` will be truncated when displayed ' +\n- 'on homescreen',\n+ title: 'The `short_name` won\\'t be truncated on the homescreen',\n+ failureTitle: 'The `short_name` will be truncated on the homescreen',\ndescription: 'Make your app\\'s `short_name` fewer than 12 characters to ' +\n'ensure that it\\'s not truncated on homescreens. [Learn ' +\n'more](https://developers.google.com/web/tools/lighthouse/audits/manifest-short_name-is-not-truncated).',\n@@ -28,27 +27,37 @@ class ManifestShortNameLength extends Audit {\n* @param {LH.Artifacts} artifacts\n* @return {Promise<LH.Audit.Product>}\n*/\n- static audit(artifacts) {\n- return artifacts.requestManifestValues(artifacts.Manifest).then(manifestValues => {\n+ static async audit(artifacts) {\n+ const manifestValues = await artifacts.requestManifestValues(artifacts.Manifest);\n+ // If there's no valid manifest, this audit is not applicable\nif (manifestValues.isParseFailure) {\nreturn {\n- rawValue: false,\n+ rawValue: true,\n+ notApplicable: true,\n};\n}\n- const hasShortName = manifestValues.allChecks.find(i => i.id === 'hasShortName');\n- if (!hasShortName || !hasShortName.passing) {\n+ const shortNameCheck = manifestValues.allChecks.find(i => i.id === 'hasShortName');\n+ const shortNameLengthCheck = manifestValues.allChecks.find(i => i.id === 'shortNameLength');\n+\n+ // If there's no short_name present, this audit is not applicable\n+ if (shortNameCheck && !shortNameCheck.passing) {\n+ return {\n+ rawValue: true,\n+ notApplicable: true,\n+ };\n+ }\n+ // Shortname is present, but it's too long\n+ if (shortNameLengthCheck && !shortNameLengthCheck.passing) {\nreturn {\nrawValue: false,\n- explanation: 'No short_name found in manifest.',\n+ explanation: `Failure: ${shortNameLengthCheck.failureText}.`,\n};\n}\n-\n- const isShortEnough = manifestValues.allChecks.find(i => i.id === 'shortNameLength');\n+ // Has a shortname that's under the threshold\nreturn {\n- rawValue: !!isShortEnough && isShortEnough.passing,\n+ rawValue: true,\n};\n- });\n}\n}\n",
"new_path": "lighthouse-core/audits/manifest-short-name-length.js",
"old_path": "lighthouse-core/audits/manifest-short-name-length.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -57,6 +57,12 @@ class WebappInstallBanner extends MultiCheckAudit {\nconst failures = [];\nconst bannerCheckIds = [\n'hasName',\n+ // Technically shortname isn't required (if name is defined):\n+ // https://cs.chromium.org/chromium/src/chrome/browser/installable/installable_manager.cc?type=cs&q=IsManifestValidForWebApp+f:cc+-f:test&sq=package:chromium&l=473\n+ // Despite this, we think it's better to require it anyway.\n+ // short_name is preferred for the homescreen icon, but a longer name can be used in\n+ // the splash screen and app title. Given the different usecases, we'd like to make it clearer\n+ // that the developer has two possible strings to work with.\n'hasShortName',\n'hasStartUrl',\n'hasPWADisplayValue',\n",
"new_path": "lighthouse-core/audits/webapp-install-banner.js",
"old_path": "lighthouse-core/audits/webapp-install-banner.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -302,6 +302,7 @@ module.exports = {\n{id: 'splash-screen', weight: 1},\n{id: 'themed-omnibox', weight: 1},\n{id: 'content-width', weight: 1},\n+ {id: 'manifest-short-name-length', weight: 0},\n// Manual audits\n{id: 'pwa-cross-browser', weight: 0},\n{id: 'pwa-page-transitions', weight: 0},\n@@ -375,7 +376,6 @@ module.exports = {\n{id: 'no-vulnerable-libraries', weight: 1},\n{id: 'notification-on-start', weight: 1},\n{id: 'deprecations', weight: 1},\n- {id: 'manifest-short-name-length', weight: 1},\n{id: 'password-inputs-can-be-pasted-into', weight: 1},\n{id: 'errors-in-console', weight: 1},\n{id: 'image-aspect-ratio', weight: 1},\n",
"new_path": "lighthouse-core/config/default-config.js",
"old_path": "lighthouse-core/config/default-config.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -11,7 +11,7 @@ const icons = require('../../lib/icons');\nconst PWA_DISPLAY_VALUES = ['minimal-ui', 'fullscreen', 'standalone'];\n// Historically, Chrome recommended 12 chars as the maximum short_name length to prevent truncation.\n-// See #69 for more discussion & https://developer.chrome.com/apps/manifest/name#short_name\n+// For more discussion, see https://github.com/GoogleChrome/lighthouse/issues/69 and https://developer.chrome.com/apps/manifest/name#short_name\nconst SUGGESTED_SHORTNAME_LENGTH = 12;\nclass ManifestValues extends ComputedArtifact {\n@@ -69,7 +69,9 @@ class ManifestValues extends ComputedArtifact {\n},\n{\nid: 'shortNameLength',\n- failureText: 'Manifest `short_name` will be truncated when displayed on the homescreen',\n+ failureText: `Manifest's \\`short_name\\` is too long (>${SUGGESTED_SHORTNAME_LENGTH} ` +\n+ `characters) to be displayed on a homescreen without truncation`,\n+ // Pass if there's no short_name. Don't want to report a non-existent string is too long\nvalidate: manifestValue => !!manifestValue.short_name.value &&\nmanifestValue.short_name.value.length <= SUGGESTED_SHORTNAME_LENGTH,\n},\n",
"new_path": "lighthouse-core/gather/computed/manifest-values.js",
"old_path": "lighthouse-core/gather/computed/manifest-values.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -25,34 +25,35 @@ function generateMockArtifacts() {\n/* eslint-env mocha */\ndescribe('Manifest: short_name_length audit', () => {\n- it('fails with no explanation if page had no manifest', () => {\n+ it('marked as notApplicable if page had no manifest', () => {\nconst artifacts = generateMockArtifacts();\nartifacts.Manifest = null;\nreturn ManifestShortNameLengthAudit.audit(artifacts).then(result => {\n- assert.strictEqual(result.rawValue, false);\n- assert.strictEqual(result.explanation, undefined);\n+ assert.strictEqual(result.rawValue, true);\n+ assert.strictEqual(result.notApplicable, true);\n});\n});\n- it('fails when an empty manifest is present', () => {\n+ it('marked as notApplicable if manifest is present but empty', () => {\nconst artifacts = generateMockArtifacts();\nartifacts.Manifest = manifestParser('{}', EXAMPLE_MANIFEST_URL, EXAMPLE_DOC_URL);\nreturn ManifestShortNameLengthAudit.audit(artifacts).then(result => {\n- assert.equal(result.rawValue, false);\n- assert.equal(result.explanation, 'No short_name found in manifest.');\n+ assert.strictEqual(result.rawValue, true);\n+ assert.strictEqual(result.notApplicable, true);\n});\n});\n- it('fails when a manifest contains no short_name and too long name', () => {\n+ it('marked as notApplicable when a manifest contains no short_name', () => {\nconst artifacts = generateMockArtifacts();\nconst manifestSrc = JSON.stringify({\nname: 'i\\'m much longer than the recommended size',\n});\nartifacts.Manifest = manifestParser(manifestSrc, EXAMPLE_MANIFEST_URL, EXAMPLE_DOC_URL);\nreturn ManifestShortNameLengthAudit.audit(artifacts).then(result => {\n- assert.equal(result.rawValue, false);\n- assert.notEqual(result.explanation, undefined);\n+ assert.strictEqual(result.rawValue, true);\n+ assert.strictEqual(result.notApplicable, true);\n+ assert.equal(result.explanation, undefined);\n});\n});\n@@ -66,10 +67,12 @@ describe('Manifest: short_name_length audit', () => {\nartifacts.Manifest = manifestParser(manifestSrc, EXAMPLE_MANIFEST_URL, EXAMPLE_DOC_URL);\nreturn ManifestShortNameLengthAudit.audit(artifacts).then(result => {\nassert.equal(result.rawValue, false);\n+ assert.ok(result.explanation.includes('without truncation'), result.explanation);\n+ assert.equal(result.notApplicable, undefined);\n});\n});\n- it('succeeds when a manifest contains a short_name', () => {\n+ it('passes when a manifest contains a short_name', () => {\nconst artifacts = generateMockArtifacts();\nconst manifestSrc = JSON.stringify({\nshort_name: 'Lighthouse',\n@@ -77,6 +80,8 @@ describe('Manifest: short_name_length audit', () => {\nartifacts.Manifest = manifestParser(manifestSrc, EXAMPLE_MANIFEST_URL, EXAMPLE_DOC_URL);\nreturn ManifestShortNameLengthAudit.audit(artifacts).then(result => {\nassert.equal(result.rawValue, true);\n+ assert.equal(result.explanation, undefined);\n+ assert.equal(result.notApplicable, undefined);\n});\n});\n/* eslint-enable camelcase */\n",
"new_path": "lighthouse-core/test/audits/manifest-short-name-length-test.js",
"old_path": "lighthouse-core/test/audits/manifest-short-name-length-test.js"
},
{
"change_type": "MODIFY",
"diff": "},\n\"manifest-short-name-length\": {\n\"id\": \"manifest-short-name-length\",\n- \"title\": \"Manifest's `short_name` will be truncated when displayed on homescreen\",\n+ \"title\": \"The `short_name` won't be truncated on the homescreen\",\n\"description\": \"Make your app's `short_name` fewer than 12 characters to ensure that it's not truncated on homescreens. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/manifest-short_name-is-not-truncated).\",\n- \"score\": 0,\n- \"scoreDisplayMode\": \"binary\",\n- \"rawValue\": false\n+ \"score\": null,\n+ \"scoreDisplayMode\": \"not-applicable\",\n+ \"rawValue\": true\n},\n\"content-width\": {\n\"id\": \"content-width\",\n\"id\": \"content-width\",\n\"weight\": 1\n},\n+ {\n+ \"id\": \"manifest-short-name-length\",\n+ \"weight\": 0\n+ },\n{\n\"id\": \"pwa-cross-browser\",\n\"weight\": 0\n\"id\": \"deprecations\",\n\"weight\": 1\n},\n- {\n- \"id\": \"manifest-short-name-length\",\n- \"weight\": 1\n- },\n{\n\"id\": \"password-inputs-can-be-pasted-into\",\n\"weight\": 1\n",
"new_path": "lighthouse-core/test/results/sample_v2.json",
"old_path": "lighthouse-core/test/results/sample_v2.json"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(pwa): revamp and move short_name_length audit (#4860) | 1 | core | pwa |
217,922 | 28.06.2018 20:34:47 | -7,200 | 42e689595d4a111ed7f61b4d3daa3515b45cceb5 | ci: added linter to travis CI process | [
{
"change_type": "MODIFY",
"diff": "@@ -9,7 +9,7 @@ before_install:\n- npm i -g firebase-functions\nscript:\n- - npm test && npm run build:prod\n+ - npm run lint && npm test && npm run build:prod\nnotifications:\nemail:\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
},
{
"change_type": "MODIFY",
"diff": "@@ -3,8 +3,6 @@ import {ExternalListData} from './external-list-data';\nexport class FfxivCraftingLinkParser implements ExternalListLinkParser {\n- // http://www.ffxivcrafting.com/list/saved/15538,1:15549,1:15515,1:15516,1:15534,1:15518,1:15519,1:15530,1:15531,1:15532,1:15533,2:5060,2\n-\ncanParse(url: string): boolean {\nreturn url.indexOf('ffxivcrafting.com') > -1 || url.indexOf('craftingasaservice.com') > -1;\n}\n",
"new_path": "src/app/pages/lists/external-list-import-popup/ffxiv-crafting-link-parser.ts",
"old_path": "src/app/pages/lists/external-list-import-popup/ffxiv-crafting-link-parser.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | ci: added linter to travis CI process | 1 | ci | null |
743,863 | 28.06.2018 22:32:13 | 25,200 | cfa7c655f3d196b5185d46fc11abb127a43c5017 | chore: explicit update of yargs-parser | [
{
"change_type": "MODIFY",
"diff": "\"string-width\": \"^2.0.0\",\n\"which-module\": \"^2.0.0\",\n\"y18n\": \"^3.2.1 || ^4.0.0\",\n- \"yargs-parser\": \"^10.0.0\"\n+ \"yargs-parser\": \"^10.1.0\"\n},\n\"devDependencies\": {\n\"chai\": \"^4.1.2\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | yargs/yargs | chore: explicit update of yargs-parser | 1 | chore | null |
791,723 | 29.06.2018 01:26:36 | -3,600 | 4542ab65153b40f0a610dfc3f217a00e151a7b2b | extension: expose devtools hooks reliably | [
{
"change_type": "MODIFY",
"diff": "@@ -79,8 +79,10 @@ if (typeof module !== 'undefined' && module.exports) {\ngetDefaultCategories,\nlistenForStatus,\n};\n-} else {\n- // If not require()d, expose on window for devtools, other consumers of file.\n+}\n+\n+if (typeof window !== 'undefined') {\n+ // Expose on window for devtools, other consumers of file.\n// @ts-ignore\nwindow.runLighthouseInWorker = runLighthouseInWorker;\n// @ts-ignore\n",
"new_path": "lighthouse-extension/app/src/lighthouse-background.js",
"old_path": "lighthouse-extension/app/src/lighthouse-background.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | extension: expose devtools hooks reliably (#5579) | 1 | extension | null |
791,723 | 29.06.2018 02:08:43 | -3,600 | 5539ce1735967a47c4b906151414656a9aeb2501 | extension: 3.0.0 as well | [
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"__MSG_appName__\",\n- \"version\": \"2.10.1.3000\",\n+ \"version\": \"3.0.0\",\n\"minimum_chrome_version\": \"66\",\n\"manifest_version\": 2,\n\"description\": \"__MSG_appDescription__\",\n",
"new_path": "lighthouse-extension/app/manifest.json",
"old_path": "lighthouse-extension/app/manifest.json"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | extension: 3.0.0 as well (#5584) | 1 | extension | null |
217,922 | 29.06.2018 15:07:28 | -7,200 | e74767df524dde914ee96cba3fb3714ae39b4003 | feat: new toggle button to temporarily ignore item in pricing page
closes | [
{
"change_type": "MODIFY",
"diff": "\"integrity\": \"sha512-goqjvdp9ZAHw0tHF/KczQtHlFvK+giYW/LeXQdpxI1fXzP/t/WWapj6wggRZ2QX33iOJ/snGLp4f0ef2r7FO7Q==\"\n},\n\"@kaiu/serializer\": {\n- \"version\": \"1.2.0\",\n- \"resolved\": \"https://registry.npmjs.org/@kaiu/serializer/-/serializer-1.2.0.tgz\",\n- \"integrity\": \"sha512-2EURm7jeZdBDI+RsUoIw7ThOKtplk1kdnY6HK1ggxIM9UwSqRDXCtmhvbUcUOON75Unc3fLLyAoPqLIiEh1e4w==\"\n+ \"version\": \"1.2.1\",\n+ \"resolved\": \"https://registry.npmjs.org/@kaiu/serializer/-/serializer-1.2.1.tgz\",\n+ \"integrity\": \"sha512-L2JC5hozYDjP16DX2mwMoAp7zMYQJR+06u4kQWY/D9fxXcOeYkeQwwcKrzalHDZUUh+x0eP3ajx1ZMwgG2T5Og==\"\n},\n\"@ngtools/webpack\": {\n\"version\": \"6.0.1\",\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
},
{
"change_type": "MODIFY",
"diff": "\"@fortawesome/fontawesome-free-solid\": \"^5.0.13\",\n\"@fortawesome/fontawesome-free-webfonts\": \"^1.0.9\",\n\"@kaiu/ng-serializer\": \"1.1.1\",\n- \"@kaiu/serializer\": \"1.2.0\",\n+ \"@kaiu/serializer\": \"1.2.1\",\n\"@ngx-translate/core\": \"^10.0.1\",\n\"@ngx-translate/http-loader\": \"^3.0.1\",\n\"@types/jwt-decode\": \"^2.2.1\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -44,4 +44,11 @@ export class ListRow extends DataModel {\ncomments?: ResourceComment[];\nhidden?: boolean;\n+\n+ // noinspection TsLint\n+ /**\n+ * Should we ignore the price of this item for pricing mode?\n+ * @type {boolean}\n+ */\n+ usePrice?: boolean = true;\n}\n",
"new_path": "src/app/model/list/list-row.ts",
"old_path": "src/app/model/list/list-row.ts"
},
{
"change_type": "MODIFY",
"diff": "-<mat-list-item [class.odd]=\"odd\" class=\"list-item\">\n+<mat-list-item [class.odd]=\"odd\" class=\"list-item\" [class.ignored]=\"item.usePrice\">\n<div mat-list-avatar class=\"icon\" *ngIf=\"!isMobile()\">\n<img mat-list-avatar src=\"{{item.icon | icon}}\" alt=\"{{item.id | itemName | i18n}}\">\n</div>\nmatTooltipPosition=\"above\">group\n</mat-icon>\n+ <mat-slide-toggle [(ngModel)]=\"item.usePrice\" (change)=\"save.emit()\">\n+ </mat-slide-toggle>\n<div class=\"amount-group\">\n<div class=\"field-group\" matLine>\n<mat-form-field class=\"nofix price\">\n",
"new_path": "src/app/modules/pricing/pricing-row/pricing-row.component.html",
"old_path": "src/app/modules/pricing/pricing-row/pricing-row.component.html"
},
{
"change_type": "MODIFY",
"diff": "-import {Component, Input, OnInit} from '@angular/core';\n+import {Component, EventEmitter, Input, OnInit, Output} from '@angular/core';\nimport {PricingService} from '../pricing.service';\nimport {Price} from '../model/price';\nimport {ItemAmount} from '../model/item-amount';\n@@ -31,6 +31,9 @@ export class PricingRowComponent implements OnInit {\namount: ItemAmount;\n+ @Output()\n+ save: EventEmitter<void> = new EventEmitter<void>();\n+\nconstructor(private pricingService: PricingService, private media: ObservableMedia) {\n}\n@@ -53,6 +56,9 @@ export class PricingRowComponent implements OnInit {\nthis.price = this.pricingService.getPrice(this.item);\n}\nthis.amount = this.pricingService.getAmount(this.listId, this.item, this.earning);\n+ if (this.item.usePrice === undefined) {\n+ this.item.usePrice = true;\n+ }\n}\nisMobile(): boolean {\n",
"new_path": "src/app/modules/pricing/pricing-row/pricing-row.component.ts",
"old_path": "src/app/modules/pricing/pricing-row/pricing-row.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -9,6 +9,7 @@ import {\nMatIconModule,\nMatInputModule,\nMatListModule,\n+ MatSlideToggleModule,\nMatTooltipModule\n} from '@angular/material';\nimport {CoreModule} from '../../core/core.module';\n@@ -21,6 +22,7 @@ import {PipesModule} from '../../pipes/pipes.module';\nimports: [\nCoreModule,\nCommonModule,\n+\nMatCardModule,\nMatExpansionModule,\nMatListModule,\n@@ -28,6 +30,8 @@ import {PipesModule} from '../../pipes/pipes.module';\nMatButtonModule,\nMatIconModule,\nMatTooltipModule,\n+ MatSlideToggleModule,\n+\nFormsModule,\nFlexLayoutModule,\nPipesModule,\n",
"new_path": "src/app/modules/pricing/pricing.module.ts",
"old_path": "src/app/modules/pricing/pricing.module.ts"
},
{
"change_type": "MODIFY",
"diff": "<mat-panel-description>{{getTotalPrice(list.crystals)}} gil</mat-panel-description>\n</mat-expansion-panel-header>\n<mat-list dense>\n- <app-pricing-row *ngFor=\"let item of list.crystals; let odd = odd\" [item]=\"item\" [listId]=\"list.$key\"\n+ <app-pricing-row *ngFor=\"let item of list.crystals; let odd = odd\" (save)=\"save()\" [item]=\"item\"\n+ [listId]=\"list.$key\"\n[odd]=\"odd\"></app-pricing-row>\n</mat-list>\n</mat-expansion-panel>\n<mat-panel-description>{{getTotalPrice(list.gathers).toLocaleString()}} gil</mat-panel-description>\n</mat-expansion-panel-header>\n<mat-list dense>\n- <app-pricing-row *ngFor=\"let item of list.gathers; let odd = odd\" [item]=\"item\" [listId]=\"list.$key\"\n+ <app-pricing-row *ngFor=\"let item of list.gathers; let odd = odd\" (save)=\"save()\" [item]=\"item\"\n+ [listId]=\"list.$key\"\n[odd]=\"odd\"></app-pricing-row>\n</mat-list>\n</mat-expansion-panel>\n<mat-panel-description>{{getTotalPrice(list.others).toLocaleString()}} gil</mat-panel-description>\n</mat-expansion-panel-header>\n<mat-list dense>\n- <app-pricing-row *ngFor=\"let item of list.others; let odd = odd\" [item]=\"item\" [listId]=\"list.$key\"\n+ <app-pricing-row *ngFor=\"let item of list.others; let odd = odd\" (save)=\"save()\" [item]=\"item\"\n+ [listId]=\"list.$key\"\n[odd]=\"odd\"></app-pricing-row>\n</mat-list>\n</mat-expansion-panel>\n<mat-panel-description>{{getTotalPrice(list.preCrafts).toLocaleString()}} gil</mat-panel-description>\n</mat-expansion-panel-header>\n<mat-list dense>\n- <app-pricing-row *ngFor=\"let item of list.preCrafts; let odd = odd\" [item]=\"item\" [listId]=\"list.$key\"\n+ <app-pricing-row *ngFor=\"let item of list.preCrafts; let odd = odd\" (save)=\"save()\" [item]=\"item\"\n+ [listId]=\"list.$key\"\n[odd]=\"odd\"\n[craftCost]=\"getCraftCost(item)\"></app-pricing-row>\n</mat-list>\n<mat-card-title>{{\"Earning\" | translate}}</mat-card-title>\n<mat-card-subtitle>{{getTotalEarnings(list.recipes).toLocaleString()}} gil</mat-card-subtitle>\n<mat-list dense>\n- <app-pricing-row *ngFor=\"let item of list.recipes; let odd = odd\" [item]=\"item\" [listId]=\"list.$key\" [odd]=\"odd\"\n+ <app-pricing-row *ngFor=\"let item of list.recipes; let odd = odd\" (save)=\"save()\" [item]=\"item\"\n+ [listId]=\"list.$key\" [odd]=\"odd\"\n[craftCost]=\"getCraftCost(item)\" [earning]=\"true\"></app-pricing-row>\n</mat-list>\n</mat-card>\n",
"new_path": "src/app/modules/pricing/pricing/pricing.component.html",
"old_path": "src/app/modules/pricing/pricing/pricing.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -3,6 +3,7 @@ import {List} from '../../../model/list/list';\nimport {PricingService} from '../pricing.service';\nimport {ListRow} from '../../../model/list/list-row';\nimport {ObservableMedia} from '@angular/flex-layout';\n+import {ListService} from '../../../core/database/list.service';\n@Component({\nselector: 'app-pricing',\n@@ -17,7 +18,11 @@ export class PricingComponent {\n@Output()\nclose: EventEmitter<void> = new EventEmitter<void>();\n- constructor(private pricingService: PricingService, private media: ObservableMedia) {\n+ constructor(private pricingService: PricingService, private media: ObservableMedia, private listService: ListService) {\n+ }\n+\n+ public save(): void {\n+ this.listService.set(this.list.$key, this.list).subscribe();\n}\npublic isMobile(): boolean {\n@@ -45,7 +50,7 @@ export class PricingComponent {\ngetTotalPrice(rows: ListRow[]): number {\nlet total = 0;\n// For each row of the list\n- rows.forEach(row => {\n+ rows.filter(row => row.usePrice).forEach(row => {\n// Get the amount of items required.\nconst amount = this.pricingService.getAmount(this.list.$key, row);\n// Get the price of the item.\n@@ -57,7 +62,7 @@ export class PricingComponent {\n}\ngetTotalEarnings(rows: ListRow[]): number {\n- return rows.reduce((total, row) => {\n+ return rows.filter(row => row.usePrice).reduce((total, row) => {\nconst price = this.pricingService.getEarnings(row);\nconst amount = this.pricingService.getAmount(this.list.$key, row, true);\nreturn total + amount.nq * price.nq + amount.hq * price.hq;\n@@ -73,6 +78,9 @@ export class PricingComponent {\nlet total = 0;\n(row.requires || []).forEach(requirement => {\nconst listRow = this.list.getItemById(requirement.id);\n+ if (!listRow.usePrice) {\n+ return\n+ }\nconst price = this.pricingService.getPrice(listRow);\nconst amount = this.pricingService.getAmount(this.list.$key, listRow);\n// We're gona get the lowest possible price.\n",
"new_path": "src/app/modules/pricing/pricing/pricing.component.ts",
"old_path": "src/app/modules/pricing/pricing/pricing.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: new toggle button to temporarily ignore item in pricing page
closes #427 | 1 | feat | null |
730,412 | 29.06.2018 20:23:21 | 0 | fcd2016c66d04cf9c250e733678c0387a292e5c3 | chore(release): 0.1.313 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.313\"></a>\n+## [0.1.313](https://github.com/webex/react-ciscospark/compare/v0.1.312...v0.1.313) (2018-06-29)\n+\n+\n+### Bug Fixes\n+\n+* **tooling:** cannot run journey tests locally ([2263166](https://github.com/webex/react-ciscospark/commit/2263166))\n+\n+\n+### Features\n+\n+* **module-users:** use uuid for all user ids ([a450c54](https://github.com/webex/react-ciscospark/commit/a450c54))\n+* **widget-demo:** add destination support ([c3a6857](https://github.com/webex/react-ciscospark/commit/c3a6857))\n+* **widget-meet:** add destination support ([b0f3ffe](https://github.com/webex/react-ciscospark/commit/b0f3ffe))\n+* **widget-message:** add destination prop support ([5d44ac3](https://github.com/webex/react-ciscospark/commit/5d44ac3))\n+* **widget-space:** add destination prop ([67a4a0b](https://github.com/webex/react-ciscospark/commit/67a4a0b))\n+* **widget-space-demo:** update props to destination ([9912b71](https://github.com/webex/react-ciscospark/commit/9912b71))\n+\n+\n+\n<a name=\"0.1.312\"></a>\n## [0.1.312](https://github.com/webex/react-ciscospark/compare/v0.1.311...v0.1.312) (2018-06-21)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.312\",\n+ \"version\": \"0.1.313\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.313 | 1 | chore | release |
217,894 | 01.07.2018 11:14:54 | 14,400 | 8ab5dc8c702aab86c2377ee69ef496d83b390ea0 | docs: added wiki page for selecting a commission | [
{
"change_type": "ADD",
"diff": "+# How to select and craft a commission request.\n+### Video\n+\n+\n+## Steps\n+1. Open the Commission board\n+2. Choose a List.\n+3. You can contact the author of the request to work out the details. When ready, Apply for this commission.\n+4. Once hired, the request goes into the My ongoing commissions tab.\n+5. Open the list, and mark off the items as you finish. This keeps the client up to date on the progress.\n+6. After the items are delivered, and payment has been made, the client will archive the list. When the list is archived, both the you and the crafter will have the opportunity to rate each other.\n+ > PLEASE NOTE, THIS IS A SERIOUS RATING. BASE YOUR RATINGS ON ONLY THE COMMISSION EXPERIENCE - ITEMS DELIVERED ON TIME, IN THE AGREED UPON MANNER.\n+7. Congrats, you're done!\n+\n+---\n+`Written by: Raeanya (Famfrit)`\n",
"new_path": "src/assets/wiki/en/Select_Commisson",
"old_path": null
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | docs: added wiki page for selecting a commission | 1 | docs | null |
217,894 | 01.07.2018 11:17:07 | 14,400 | 3d4ff87f76d1ee14f5f26d457828e4a9d9327c3f | docs: added wiki page for creating a commission | [
{
"change_type": "ADD",
"diff": "+# How to create a commission request.\n+### Video\n+\n+\n+## Steps\n+1. Create a **[List]**\n+2. Open the List.\n+3. Select Create a commission request.\n+4. Enter the price you want to pay for the commission.\n+ > You can also leave this blank and negotiate a price when a crafter claims the commission.\n+5. Crafters can now view your list, and contact you to work out the details of the commission. They will then select apply.\n+6. When a crafter applies to the list, you can view them in the Candidates section of the commission board. You can see their name as well as Teamcraft commission rating. Click Hire to hire the crafter.\n+7. You can now open your commission request to watch the progress as items are marked complete by the crafter. You can add payment if you've made a deposit to the crafter, which will also update the amount owed.\n+8. Once the list is complete, the items have been delivered, and the payment has been made, you can update the final amount of gil, and then Archive the commission.\n+9. The final step is to rate the other user. Both the you and the crafter will have the opportunity to rate each other.\n+ > PLEASE NOTE, THIS IS A SERIOUS RATING. BASE YOUR RATINGS ON ONLY THE COMMISSION EXPERIENCE - ITEMS DELIVERED ON TIME, IN THE AGREED UPON MANNER.\n+10. Congrats, you're done!\n+\n+\n+\n+---\n+`Written by: Raeanya (Famfrit)`\n+\n+[List]: /lists\n+\n",
"new_path": "src/assets/wiki/en/commission_request",
"old_path": null
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | docs: added wiki page for creating a commission | 1 | docs | null |
217,922 | 01.07.2018 14:36:50 | -7,200 | bd199a50839345a747d642dbfa1da6e395b0de3f | chore: fixed a small typo in translation key | [
{
"change_type": "MODIFY",
"diff": "@@ -233,7 +233,7 @@ export class CommissionDetailsComponent implements OnInit {\n}\npublic markAsFinished(commission: Commission): void {\n- this.dialog.open(ConfirmationPopupComponent, {data: 'CONFIRMATION_BOARD.Confirm_archive'})\n+ this.dialog.open(ConfirmationPopupComponent, {data: 'COMMISSION_BOARD.Confirm_archive'})\n.afterClosed()\n.pipe(\nfilter(res => res),\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.ts",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: fixed a small typo in translation key | 1 | chore | null |
217,922 | 02.07.2018 00:17:38 | -7,200 | aac766d8c958983ce001145580a109b9b6e65f26 | fix: fixed a bug making commissions disappear. Needs everybody to restart to be fixed | [
{
"change_type": "MODIFY",
"diff": "@@ -16,6 +16,6 @@ export class DefaultConsumables {\npublic constructor(food: Consumable, medicine: Consumable, freeCompanyActions: FreeCompanyAction[]) {\nthis.food = food;\nthis.medicine = medicine;\n- this.freeCompanyActions = freeCompanyActions;\n+ this.freeCompanyActions = freeCompanyActions || [];\n}\n}\n",
"new_path": "src/app/model/other/default-consumables.ts",
"old_path": "src/app/model/other/default-consumables.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -5,7 +5,7 @@ import {Router} from '@angular/router';\nimport {Commission} from '../../../model/commission/commission';\nimport {CommissionService} from '../../../core/database/commission/commission.service';\nimport {UserService} from '../../../core/database/user.service';\n-import {first, map, mergeMap} from 'rxjs/operators';\n+import {first, map, mergeMap, tap} from 'rxjs/operators';\nimport {ListService} from '../../../core/database/list.service';\nimport {PermissionsRegistry} from '../../../core/database/permissions/permissions-registry';\n@@ -31,7 +31,6 @@ export class CommissionCreationPopupComponent {\nconst commission = new Commission(character.userId, this.list, character.server);\ncommission.price = this.price;\ncommission.onlyNeedsCraft = this.list.onlyNeedsCrafts();\n- console.log(commission.onlyNeedsCraft);\nreturn this.commissionService.add(commission)\n.pipe(\nmap(res => {\n",
"new_path": "src/app/pages/commission-board/commission-creation-popup/commission-creation-popup.component.ts",
"old_path": "src/app/pages/commission-board/commission-creation-popup/commission-creation-popup.component.ts"
},
{
"change_type": "MODIFY",
"diff": "-import {ChangeDetectionStrategy, Component, OnInit, ViewEncapsulation} from '@angular/core';\n+import {ChangeDetectionStrategy, Component, OnDestroy, OnInit, ViewEncapsulation} from '@angular/core';\nimport {ActivatedRoute} from '@angular/router';\nimport {Commission} from '../../../model/commission/commission';\n-import {Observable} from 'rxjs/Observable';\nimport {CommissionService} from '../../../core/database/commission/commission.service';\n-import {catchError, filter, first, map, mergeMap, shareReplay} from 'rxjs/operators';\n+import {catchError, filter, first, map, mergeMap, shareReplay, takeUntil} from 'rxjs/operators';\nimport {UserService} from '../../../core/database/user.service';\nimport {CommissionStatus} from '../../../model/commission/commission-status';\nimport {AppUser} from '../../../model/list/app-user';\n-import {combineLatest, of} from 'rxjs';\n+import {combineLatest, Observable, of, Subject} from 'rxjs';\nimport {MatDialog} from '@angular/material';\nimport {ConfirmationPopupComponent} from '../../../modules/common-components/confirmation-popup/confirmation-popup.component';\nimport {ListService} from '../../../core/database/list.service';\n@@ -20,7 +19,7 @@ import {RatingPopupComponent} from '../rating-popup/rating-popup.component';\nchangeDetection: ChangeDetectionStrategy.OnPush,\nencapsulation: ViewEncapsulation.None\n})\n-export class CommissionDetailsComponent implements OnInit {\n+export class CommissionDetailsComponent implements OnInit, OnDestroy {\npublic commission$: Observable<Commission>;\n@@ -34,6 +33,8 @@ export class CommissionDetailsComponent implements OnInit {\npayment: number;\n+ private onDestroy$: Subject<void> = new Subject<void>();\n+\nconstructor(private activeRoute: ActivatedRoute, private commissionService: CommissionService, private userService: UserService,\nprivate dialog: MatDialog, private listService: ListService) {\n}\n@@ -287,11 +288,11 @@ export class CommissionDetailsComponent implements OnInit {\nthis.removeApplicationNewThing();\ncombineLatest(this.commission$, this.user$)\n.pipe(\n+ takeUntil(this.onDestroy$),\nfilter(data => {\nreturn data[0].status === CommissionStatus.DONE && data[0].ratedBy[data[1].$key] === undefined\n&& (data[0].authorId === data[1].$key || data[0].crafterId === data[1].$key);\n}),\n- first(),\nmergeMap(data => {\nreturn this.getCharacter(data[0].crafterId)\n.pipe(\n@@ -316,4 +317,8 @@ export class CommissionDetailsComponent implements OnInit {\n})\n}\n+ ngOnDestroy(): void {\n+ this.onDestroy$.next(null);\n+ }\n+\n}\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.ts",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -213,6 +213,10 @@ export class ListsComponent extends ComponentWithSubscriptions implements OnInit\nreturn this.commissionService\n.getAll(char.server, ref => ref.where('status', '==', CommissionStatus.CREATED))\n.pipe(\n+ first(),\n+ map(commissions => {\n+ return commissions.filter(commission => commission.listId === list.$key);\n+ }),\nmergeMap(commissions => {\nif (commissions.length > 0) {\nreturn combineLatest(\n",
"new_path": "src/app/pages/lists/lists/lists.component.ts",
"old_path": "src/app/pages/lists/lists/lists.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed a bug making commissions disappear. Needs everybody to restart to be fixed | 1 | fix | null |
791,690 | 02.07.2018 08:58:31 | 25,200 | 65fa9fcf1bd4b1183d9ab99303341225b71ca8df | core(fonts): handle CORS cssRules | [
{
"change_type": "ADD",
"diff": "+@font-face {\n+ font-family: 'Lobster Three';\n+ font-style: normal;\n+ font-weight: 700;\n+ src: url(\"http://localhost:10503/perf/lobster-two-v10-latin-700.woff2?cors=true\") format('woff2');\n+}\n+.corsfont {\n+ font-family: \"Lobster Three\", sans-serif;\n+ color: red;\n+}\n",
"new_path": "lighthouse-cli/test/fixtures/perf/cors-fonts.css",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "font-family: 'Lobster';\nfont-style: normal;\nfont-weight: 400;\n- src: local('Lobster'), url('./lobster-v20-latin-regular.eot?#iefix') format('eot'), url('./lobster-v20-latin-regular.woff2') format('woff2');\n+ /* We don't need `local` but keep around for testing robustness of our regex */\n+ src: local('Lobster'), url('./lobster-v20-latin-regular.woff2') format('woff2');\n}\n@font-face {\nfont-family: 'Lobster Two';\nfont-style: normal;\nfont-weight: 700;\nfont-display: optional;\n+ /* We don't need `local` but keep around for testing robustness of our regex */\nsrc: local(\"Lobster Two\"), url(\"./lobster-two-v10-latin-700.woff2?delay=4000\") format('woff2');\n}\n.webfont {\nfont-family: Unknown, sans-serif;\n}\n</style>\n+ <link rel=\"stylesheet\" href=\"http://localhost:10503/perf/cors-fonts.css\">\n</head>\n<body>\n<p class=\"webfont\">Let's load some sweet webfonts...</p>\n<p><strong class=\"webfont\">Let's load some sweet webfonts...</strong></p>\n- <p class\"nofont\">Some lovely text that uses the fallback font</p>\n+ <p class=\"nofont\">Some lovely text that uses the fallback font</p>\n+ <p class=\"corsfont\">Some lovely text that uses a CORS font</p>\n</body>\n</html>\n",
"new_path": "lighthouse-cli/test/fixtures/perf/fonts.html",
"old_path": "lighthouse-cli/test/fixtures/perf/fonts.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -60,7 +60,7 @@ function requestHandler(request, response) {\n}\nfunction sendResponse(statusCode, data) {\n- const headers = {};\n+ const headers = {'Access-Control-Allow-Origin': '*'};\nif (filePath.endsWith('.js')) {\nheaders['Content-Type'] = 'text/javascript';\n",
"new_path": "lighthouse-cli/test/fixtures/static-server.js",
"old_path": "lighthouse-cli/test/fixtures/static-server.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -64,7 +64,7 @@ module.exports = [\nrawValue: false,\ndetails: {\nitems: {\n- length: 1,\n+ length: 2,\n},\n},\n},\n",
"new_path": "lighthouse-cli/test/smokehouse/perf/expectations.js",
"old_path": "lighthouse-cli/test/smokehouse/perf/expectations.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -13,7 +13,7 @@ const Sentry = require('../../lib/sentry');\n// All the property keys of FontFace where the value is a string and are worth\n// using for finding font matches (see _findSameFontFamily).\n/** @typedef {'family'|'style'|'weight'|'stretch'|'unicodeRange'|'variant'|'featureSettings'|'display'} FontFaceStringKeys */\n-/** @typedef {{err: {message: string, stack: string}}} FontGatherError */\n+/** @typedef {{err: {message: string, stack?: string}}} FontGatherError */\n/** @type {Array<FontFaceStringKeys>} */\nconst fontFaceDescriptors = [\n@@ -124,11 +124,24 @@ function getFontFaceFromStylesheets() {\nreturn new Promise(resolve => {\nnewNode.addEventListener('load', function onload() {\nnewNode.removeEventListener('load', onload);\n- resolve(getFontFaceFromStylesheets());\n+ try {\n+ const stylesheet = Array.from(document.styleSheets).find(s => s.ownerNode === newNode);\n+ if (stylesheet) {\n+ const cssStylesheet = /** @type {CSSStyleSheet} */ (stylesheet);\n+ resolve(getSheetsFontFaces(cssStylesheet));\n+ } else {\n+ resolve([{err: {message: 'Could not load stylesheet with CORS'}}]);\n+ }\n+ } catch (err) {\n+ resolve([{err: {message: err.message, stack: err.stack}}]);\n+ }\n});\nnewNode.crossOrigin = 'anonymous';\noldNode.parentNode && oldNode.parentNode.insertBefore(newNode, oldNode);\noldNode.remove();\n+\n+ // Give each stylesheet 1s to load before giving up\n+ setTimeout(() => resolve([{err: {message: 'Could not load stylesheet (timeout)'}}]), 1000);\n});\n}\n@@ -138,21 +151,30 @@ function getFontFaceFromStylesheets() {\nconst corsDataPromises = [];\n// Get all loaded stylesheets\nfor (const stylesheet of Array.from(document.styleSheets)) {\n- try {\nconst cssStylesheet = /** @type {CSSStyleSheet} */ (stylesheet);\n- // Cross-origin stylesheets don't expose cssRules by default. We reload them w/ CORS headers.\n- if (cssStylesheet.cssRules === null && cssStylesheet.href && cssStylesheet.ownerNode &&\n+\n+ try {\n+ // cssRules can be null or this access can throw when CORS isn't enabled; throw a matching error message.\n+ if (!cssStylesheet.cssRules) {\n+ throw new Error('Failed to read cssRules');\n+ }\n+\n+ data.push(...getSheetsFontFaces(cssStylesheet));\n+ } catch (err) {\n+ const failedToReadRules = /Failed to read.*cssRules/.test(err.message);\n// @ts-ignore - crossOrigin exists if ownerNode is an HTMLLinkElement\n- !cssStylesheet.ownerNode.crossOrigin) {\n+ const alreadyCORS = !cssStylesheet.ownerNode || !!cssStylesheet.ownerNode.crossOrigin;\n+\n+ if (failedToReadRules && !alreadyCORS && cssStylesheet.href) {\n+ // Cross-origin stylesheets don't expose cssRules by default. We reload them w/ CORS headers.\nconst ownerLinkEl = /** @type {HTMLLinkElement} */ (cssStylesheet.ownerNode);\ncorsDataPromises.push(loadStylesheetWithCORS(ownerLinkEl));\n} else {\n- data.push(...getSheetsFontFaces(cssStylesheet));\n- }\n- } catch (err) {\n+ // Otherwise this is a legit error we should report back to the gatherer.\ndata.push({err: {message: err.message, stack: err.stack}});\n}\n}\n+ }\n// Flatten results\nreturn Promise.all(corsDataPromises).then(corsFontFaces => data.concat(...corsFontFaces));\n}\n@@ -194,7 +216,7 @@ class Fonts extends Gatherer {\nconst dataError = /** @type {FontGatherError} */ (fontOrError);\nif (dataError.err) {\nconst err = new Error(dataError.err.message);\n- err.stack = dataError.err.stack;\n+ err.stack = dataError.err.stack || err.stack;\n// @ts-ignore TODO(bckenny): Sentry type checking\nSentry.captureException(err, {tags: {gatherer: 'Fonts'}, level: 'warning'});\nreturn false;\n",
"new_path": "lighthouse-core/gather/gatherers/fonts.js",
"old_path": "lighthouse-core/gather/gatherers/fonts.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -26,6 +26,7 @@ const SAMPLED_ERRORS = [\n{pattern: /(IDLE_PERIOD|FMP_TOO_LATE)/, rate: 0.1},\n{pattern: /^NO_.*/, rate: 0.1},\n// Message based sampling\n+ {pattern: /Could not load stylesheet/, rate: 0.1},\n{pattern: /Failed to decode/, rate: 0.1},\n{pattern: /All image optimizations failed/, rate: 0.1},\n{pattern: /No.*resource with given/, rate: 0.01},\n",
"new_path": "lighthouse-core/lib/sentry.js",
"old_path": "lighthouse-core/lib/sentry.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(fonts): handle CORS cssRules (#5592) | 1 | core | fonts |
791,723 | 02.07.2018 10:18:39 | 25,200 | 6193242bb208e4f660b8bf22a40398e7d832ce12 | tests: run the golden LHR check earlier | [
{
"change_type": "MODIFY",
"diff": "@@ -33,10 +33,10 @@ before_script:\n- yarn build-all\nscript:\n- yarn bundlesize\n+ - yarn diff:sample-json\n- yarn lint\n- yarn unit:silentcoverage\n- yarn type-check\n- - yarn diff:sample-json\n- yarn smoke:silentcoverage\n- yarn test-extension\n- yarn test-viewer\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
},
{
"change_type": "MODIFY",
"diff": "\"debug\": \"node --inspect-brk ./lighthouse-cli/index.js\",\n\"start\": \"node ./lighthouse-cli/index.js\",\n- \"test\": \"yarn lint --quiet && yarn unit && yarn type-check && yarn diff:sample-json\",\n+ \"test\": \"yarn diff:sample-json && yarn lint --quiet && yarn unit && yarn type-check\",\n\"test-extension\": \"cd lighthouse-extension && yarn test\",\n\"test-viewer\": \"cd lighthouse-viewer && yarn pptr-test\",\n\"test-lantern\": \"bash lighthouse-core/scripts/test-lantern.sh\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | tests: run the golden LHR check earlier (#5609) | 1 | tests | null |
791,723 | 02.07.2018 11:59:21 | 25,200 | 36a2a546d207c0f3abf73b7de924c48f8ce93581 | core: bump to v3.0.1 | [
{
"change_type": "MODIFY",
"diff": "+ <a name=\"3.0.1\"></a>\n+# 3.0.1 (2018-07-02)\n+[Full Changelog](https://github.com/googlechrome/lighthouse/compare/v3.0.0...v3.0.1)\n+\n+## Core\n+\n+* fonts: handle CORS cssRules ([#5592](https://github.com/googlechrome/lighthouse/pull/5592))\n+\n+## Tests\n+\n+* adopt jest (leaving mocha) for core & cli ([#5386](https://github.com/googlechrome/lighthouse/pull/5386))\n+\n<a name=\"3.0.0\"></a>\n# 3.0.0 Final (2018-06-29)\n[Changelog of v3.0.0-beta.0 to 3.0 final](https://github.com/googlechrome/lighthouse/compare/v3.0.0-beta.0...v3.0.0)\n",
"new_path": "changelog.md",
"old_path": "changelog.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -38,7 +38,8 @@ yarn install-all\n# * Bump it *\nyarn version --no-git-tag-version\n-# then manually bump extension v in extension/app/manifest.json\n+# manually bump extension v in extension/app/manifest.json\n+yarn update:sample-json\n# * Build it *\nyarn build-all\n",
"new_path": "docs/releasing.md",
"old_path": "docs/releasing.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"userAgent\": \"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3358.0 Safari/537.36\",\n- \"lighthouseVersion\": \"3.0.0\",\n+ \"lighthouseVersion\": \"3.0.1\",\n\"fetchTime\": \"2018-03-13T00:55:45.840Z\",\n\"requestedUrl\": \"http://localhost:10200/dobetterweb/dbw_tester.html\",\n\"finalUrl\": \"http://localhost:10200/dobetterweb/dbw_tester.html\",\n",
"new_path": "lighthouse-core/test/results/sample_v2.json",
"old_path": "lighthouse-core/test/results/sample_v2.json"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"__MSG_appName__\",\n- \"version\": \"3.0.0\",\n+ \"version\": \"3.0.1\",\n\"minimum_chrome_version\": \"66\",\n\"manifest_version\": 2,\n\"description\": \"__MSG_appDescription__\",\n",
"new_path": "lighthouse-extension/app/manifest.json",
"old_path": "lighthouse-extension/app/manifest.json"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"lighthouse\",\n- \"version\": \"3.0.0\",\n+ \"version\": \"3.0.1\",\n\"description\": \"Lighthouse\",\n\"main\": \"./lighthouse-core/index.js\",\n\"bin\": {\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core: bump to v3.0.1 (#5608) | 1 | core | null |
730,429 | 02.07.2018 14:46:38 | 14,400 | 8637a13da7a1417407b855acddaca0ba617be4b3 | chore(tests): shrink test assets | [
{
"change_type": "MODIFY",
"diff": "Binary files a/test/journeys/lib/test-helpers/assets/docx-sample.docx and b/test/journeys/lib/test-helpers/assets/docx-sample.docx differ\n",
"new_path": "test/journeys/lib/test-helpers/assets/docx-sample.docx",
"old_path": "test/journeys/lib/test-helpers/assets/docx-sample.docx"
},
{
"change_type": "MODIFY",
"diff": "Binary files a/test/journeys/lib/test-helpers/assets/gif-sample.gif and b/test/journeys/lib/test-helpers/assets/gif-sample.gif differ\n",
"new_path": "test/journeys/lib/test-helpers/assets/gif-sample.gif",
"old_path": "test/journeys/lib/test-helpers/assets/gif-sample.gif"
},
{
"change_type": "MODIFY",
"diff": "Binary files a/test/journeys/lib/test-helpers/assets/zip-sample.zip and b/test/journeys/lib/test-helpers/assets/zip-sample.zip differ\n",
"new_path": "test/journeys/lib/test-helpers/assets/zip-sample.zip",
"old_path": "test/journeys/lib/test-helpers/assets/zip-sample.zip"
}
] | JavaScript | MIT License | webex/react-widgets | chore(tests): shrink test assets | 1 | chore | tests |
730,429 | 02.07.2018 15:39:41 | 14,400 | f294ba30e415d86770a3cc870b696624ced5fed6 | feat(widget-space): use new webex teams loading screen | [
{
"change_type": "MODIFY",
"diff": "@@ -7,7 +7,7 @@ import {compose} from 'recompose';\nimport TitleBar from '@ciscospark/react-component-title-bar';\nimport Button from '@ciscospark/react-component-button';\n-import LoadingScreen from '@ciscospark/react-component-loading-screen';\n+import LoadingScreen from '@webex/react-component-loading-screen';\nimport Timer from '@ciscospark/react-component-timer';\nimport ErrorDisplay from '@ciscospark/react-component-error-display';\n",
"new_path": "packages/node_modules/@ciscospark/widget-space/src/container.js",
"old_path": "packages/node_modules/@ciscospark/widget-space/src/container.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -8,7 +8,7 @@ import {defineMessages} from 'react-intl';\nexport default defineMessages({\nloadingMessage: {\nid: 'ciscospark.container.space.loading',\n- defaultMessage: 'Loading Cisco Spark'\n+ defaultMessage: 'Loading Webex Teams Space'\n},\nerrorConnection: {\nid: 'ciscospark.container.space.error.connection',\n",
"new_path": "packages/node_modules/@ciscospark/widget-space/src/messages.js",
"old_path": "packages/node_modules/@ciscospark/widget-space/src/messages.js"
}
] | JavaScript | MIT License | webex/react-widgets | feat(widget-space): use new webex teams loading screen | 1 | feat | widget-space |
217,922 | 03.07.2018 09:40:03 | -7,200 | 2cabd177145da776eec3741964f00b4a15237985 | refactor: updater installation is now silent and will re-run app automatically | [
{
"change_type": "MODIFY",
"diff": "@@ -200,7 +200,7 @@ ipcMain.on('notification', (event, config) => {\n});\nipcMain.on('run-update', () => {\n- autoUpdater.quitAndInstall();\n+ autoUpdater.quitAndInstall(true, true);\n});\nipcMain.on('always-on-top', (event, onTop) => {\n",
"new_path": "main.js",
"old_path": "main.js"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | refactor: updater installation is now silent and will re-run app automatically | 1 | refactor | null |
679,913 | 03.07.2018 10:20:07 | -3,600 | 33f0d19786bf620a700a71e91b6730bc0f6230a6 | fix(associative): minor SortedSet fixes
partial opts for SortedSet ctor
update first() return type | [
{
"change_type": "MODIFY",
"diff": "@@ -34,7 +34,7 @@ export class SortedSet<T> extends Set<T> implements\n* @param values\n* @param opts\n*/\n- constructor(values?: Iterable<T>, opts?: SortedSetOpts<T>) {\n+ constructor(values?: Iterable<T>, opts?: Partial<SortedSetOpts<T>>) {\nsuper();\n__private.set(this, new SortedMap<T, T>(\nvalues ? map((x) => [x, x], values) : null,\n@@ -124,7 +124,7 @@ export class SortedSet<T> extends Set<T> implements\n__private.get(this).clear();\n}\n- first() {\n+ first(): T {\nconst first = __private.get(this).first();\nreturn first ? first[0] : undefined;\n}\n",
"new_path": "packages/associative/src/sorted-set.ts",
"old_path": "packages/associative/src/sorted-set.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | fix(associative): minor SortedSet fixes
- partial opts for SortedSet ctor
- update first() return type | 1 | fix | associative |
730,429 | 03.07.2018 10:21:40 | 14,400 | 4df4d40881b653fccc79dce7afc42730e2994ad1 | test(journeys): add pause for each file upload test
Tests were failing with "cannot send" messages. | [
{
"change_type": "MODIFY",
"diff": "@@ -200,6 +200,8 @@ const sendFileTest = (sender, receiver, fileName, fileSizeVerify = true) => {\n// Send receipt acknowledgement and verify before moving on\nsendMessage(receiver, sender, `Received: ${fileName}`);\nverifyMessageReceipt(sender, receiver, `Received: ${fileName}`);\n+ // Wait so we don't overload file uploads\n+ sender.browser.pause(1000);\n};\n/**\n",
"new_path": "test/journeys/lib/test-helpers/space-widget/messaging.js",
"old_path": "test/journeys/lib/test-helpers/space-widget/messaging.js"
}
] | JavaScript | MIT License | webex/react-widgets | test(journeys): add pause for each file upload test
Tests were failing with "cannot send" messages. | 1 | test | journeys |
791,690 | 03.07.2018 10:22:36 | 14,400 | f7d7a9082ccaa985bfdd3f4103a74257dbd0e5c1 | core(without-javascript): allow noscript pages | [
{
"change_type": "MODIFY",
"diff": "@@ -30,7 +30,8 @@ class WithoutJavaScript extends Audit {\nstatic audit(artifacts) {\nconst artifact = artifacts.HTMLWithoutJavaScript;\n- if (artifact.value.trim() === '') {\n+ // Fail pages that have empty text and are missing a noscript tag\n+ if (artifact.bodyText.trim() === '' && !artifact.hasNoScript) {\nreturn {\nrawValue: false,\nexplanation: 'The page body should render some content if its scripts are not available.',\n",
"new_path": "lighthouse-core/audits/without-javascript.js",
"old_path": "lighthouse-core/audits/without-javascript.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -18,7 +18,10 @@ const Gatherer = require('./gatherer');\nfunction getBodyText() {\n// note: we use innerText, not textContent, because textContent includes the content of <script> elements!\nconst body = document.querySelector('body');\n- return Promise.resolve(body ? body.innerText : '');\n+ return Promise.resolve({\n+ bodyText: body ? body.innerText : '',\n+ hasNoScript: !!document.querySelector('noscript'),\n+ });\n}\nclass HTMLWithoutJavaScript extends Gatherer {\n@@ -37,13 +40,15 @@ class HTMLWithoutJavaScript extends Gatherer {\n// Reset the JS disable.\npassContext.disableJavaScript = false;\n- const bodyText = await passContext.driver.evaluateAsync(`(${getBodyText.toString()}())`);\n+ const expression = `(${getBodyText.toString()}())`;\n+ const {bodyText, hasNoScript} = await passContext.driver.evaluateAsync(expression);\nif (typeof bodyText !== 'string') {\nthrow new Error('document body innerText returned by protocol was not a string');\n}\nreturn {\n- value: bodyText,\n+ bodyText,\n+ hasNoScript,\n};\n}\n}\n",
"new_path": "lighthouse-core/gather/gatherers/html-without-javascript.js",
"old_path": "lighthouse-core/gather/gatherers/html-without-javascript.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -14,7 +14,8 @@ describe('Progressive Enhancement: without javascript audit', () => {\nit('fails when the js-less body is empty', () => {\nconst artifacts = {\nHTMLWithoutJavaScript: {\n- value: '',\n+ bodyText: '',\n+ hasNoScript: false,\n},\n};\n@@ -26,7 +27,8 @@ describe('Progressive Enhancement: without javascript audit', () => {\nit('fails when the js-less body is whitespace', () => {\nconst artifacts = {\nHTMLWithoutJavaScript: {\n- value: ' ',\n+ bodyText: ' ',\n+ hasNoScript: false,\n},\n};\n@@ -38,7 +40,19 @@ describe('Progressive Enhancement: without javascript audit', () => {\nit('succeeds when the js-less body contains some content', () => {\nconst artifacts = {\nHTMLWithoutJavaScript: {\n- value: 'test',\n+ bodyText: 'test',\n+ hasNoScript: false,\n+ },\n+ };\n+\n+ assert.equal(withoutJsAudit.audit(artifacts).rawValue, true);\n+ });\n+\n+ it('succeeds when the js-less body contains noscript', () => {\n+ const artifacts = {\n+ HTMLWithoutJavaScript: {\n+ bodyText: '',\n+ hasNoScript: true,\n},\n};\n",
"new_path": "lighthouse-core/test/audits/without-javascript-test.js",
"old_path": "lighthouse-core/test/audits/without-javascript-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -29,7 +29,7 @@ describe('HTML without JavaScript gatherer', () => {\ndisableJavaScript: true,\ndriver: {\nevaluateAsync() {\n- return Promise.resolve('Hello!');\n+ return Promise.resolve({bodyText: 'Hello!'});\n},\n},\n};\n@@ -41,15 +41,16 @@ describe('HTML without JavaScript gatherer', () => {\n});\nit('returns an artifact', () => {\n- const innerText = 'Hello!';\n+ const bodyText = 'Hello!';\n+ const hasNoScript = true;\nreturn htmlWithoutJavaScriptGather.afterPass({\ndriver: {\nevaluateAsync() {\n- return Promise.resolve(innerText);\n+ return Promise.resolve({bodyText, hasNoScript});\n},\n},\n}).then(artifact => {\n- assert.strictEqual(artifact.value, innerText);\n+ assert.deepStrictEqual(artifact, {bodyText, hasNoScript});\n});\n});\n",
"new_path": "lighthouse-core/test/gather/gatherers/html-without-javascript-test.js",
"old_path": "lighthouse-core/test/gather/gatherers/html-without-javascript-test.js"
},
{
"change_type": "MODIFY",
"diff": "\"value\": false\n},\n\"HTMLWithoutJavaScript\": {\n- \"value\": \"Do better web tester page\\nHi there!\\ntouchmove section\\n \"\n+ \"bodyText\": \"Do better web tester page\\nHi there!\\ntouchmove section\\n \"\n}\n}\n",
"new_path": "lighthouse-core/test/results/artifacts/artifacts.json",
"old_path": "lighthouse-core/test/results/artifacts/artifacts.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -67,7 +67,7 @@ declare global {\n/** The hreflang and href values of all link[rel=alternate] nodes found in HEAD. */\nHreflang: {href: string, hreflang: string}[];\n/** The page's document body innerText if loaded with JavaScript disabled. */\n- HTMLWithoutJavaScript: {value: string};\n+ HTMLWithoutJavaScript: {bodyText: string, hasNoScript: boolean};\n/** Whether the page ended up on an HTTPS page after attempting to load the HTTP version. */\nHTTPRedirect: {value: boolean};\n/** Information on size and loading for all the images in the page. */\n",
"new_path": "typings/artifacts.d.ts",
"old_path": "typings/artifacts.d.ts"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(without-javascript): allow noscript pages (#5571) | 1 | core | without-javascript |
679,913 | 03.07.2018 12:35:13 | -3,600 | 17d412af1e715f1290418252e79359016f8f203c | test(rstream-graph): increase timeout to avoid travis errors | [
{
"change_type": "MODIFY",
"diff": "@@ -63,13 +63,13 @@ describe(\"rstream-graph\", () => {\ngraph.mul.node.subscribe({ next: (x) => acc.push(x) });\nsetTimeout(() => {\nstate.resetIn(\"a\", 10);\n- console.log(graph);\n+ // console.log(graph);\nassert.deepEqual(acc, [600, 1200, 1800, 7200]);\nassert.deepEqual(\nstate.deref(),\n{ a: 10, b: 2, foo: { baz: 7200 }, res: { x: 7200, x2: 14400 }, res2: { x: 7200 } }\n);\ndone();\n- }, 10);\n+ }, 30);\n});\n});\n",
"new_path": "packages/rstream-graph/test/index.ts",
"old_path": "packages/rstream-graph/test/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | test(rstream-graph): increase timeout to avoid travis errors | 1 | test | rstream-graph |
791,723 | 03.07.2018 13:50:44 | 25,200 | 94d04313959b11df7ebf07713b70827fc041f56e | docs(architecture): add diagram of module dependencies | [
{
"change_type": "MODIFY",
"diff": "@@ -87,3 +87,9 @@ Tracing processor takes the output of trace of tab and identifies the top-level\nThe return value of each audit [takes this shape](https://github.com/GoogleChrome/lighthouse/blob/8f500e00243e07ef0a80b39334bedcc8ddc8d3d0/typings/audit.d.ts#L117-L130).\nThe `details` object is parsed in report-renderer.js. View other audits for guidance on how to structure `details`.\n+\n+## Lighthouse-core internal module dependencies\n+\n+\n+\n+(Generated July 3, 2018 via `madge lighthouse-core/index.js --image arch.png --layout dot --backgroundColor \"#fafafa\" --nodeColor \"#4d4afc\" --noDependencyColor \"#48ad00\"`)\n",
"new_path": "docs/architecture.md",
"old_path": "docs/architecture.md"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | docs(architecture): add diagram of module dependencies (#5615) | 1 | docs | architecture |
679,913 | 03.07.2018 14:50:03 | -3,600 | 677c7cc0b510b7848e9f8c7e9d08180cdbd693cf | feat(transducers): add ensureArray(), refactor reverse() | [
{
"change_type": "ADD",
"diff": "+import { isArray } from \"@thi.ng/checks/is-array\";\n+import { ensureIterable } from \"./ensure-iterable\";\n+\n+/**\n+ * Helper function to avoid unnecessary copying if `x` is already an\n+ * array. First checks if `x` is an array and if so returns it. Else\n+ * attempts to obtain an iterator from `x` and if successful collects it\n+ * as array and returns it. Throws error if `x` isn't iterable.\n+ *\n+ * @param x\n+ */\n+export function ensureArray(x: any): any[] {\n+ return isArray(x) ? x : [...ensureIterable(x)];\n+}\n",
"new_path": "packages/transducers/src/func/ensure-array.ts",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -97,6 +97,7 @@ export * from \"./func/compr\";\nexport * from \"./func/constantly\";\nexport * from \"./func/deep-transform\";\nexport * from \"./func/delay\";\n+export * from \"./func/ensure-array\";\nexport * from \"./func/ensure-iterable\";\nexport * from \"./func/even\";\nexport * from \"./func/fuzzy-match\";\n",
"new_path": "packages/transducers/src/index.ts",
"old_path": "packages/transducers/src/index.ts"
},
{
"change_type": "MODIFY",
"diff": "-import { isArrayLike } from \"@thi.ng/checks/is-arraylike\";\n+import { ensureArray } from \"../func/ensure-array\";\n/**\n- * Yields iterator producing input in reverse order.\n- * Important: Input MUST be finite. Unless an\n+ * Yields iterator which consumes input and yield its values in reverse\n+ * order. Important: Input MUST be finite.\n+ *\n* ```\n* [...tx.reverse(\"hello world\")]\n* // [ \"d\", \"l\", \"r\", \"o\", \"w\", \" \", \"o\", \"l\", \"l\", \"e\", \"h\" ]\n* ```\n+ *\n* @param input\n*/\nexport function* reverse<T>(input: Iterable<T>): IterableIterator<T> {\n- if (!isArrayLike(input)) {\n- input = [...input];\n- }\n- let n = (<any>input).length;\n+ const _input = ensureArray(input);\n+ let n = _input.length;\nwhile (--n >= 0) {\n- yield input[n];\n+ yield _input[n];\n}\n}\n",
"new_path": "packages/transducers/src/iter/reverse.ts",
"old_path": "packages/transducers/src/iter/reverse.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -37,7 +37,7 @@ import { Reducer, Transducer } from \"../api\";\n*\n* ```\n* // passing `false` to disable tuple reset\n- * [...tx.iterator(tx.partitionSync([\"a\", \"b\"], (x) => x[0], false), src)]\n+ * [...iterator(partitionSync([\"a\", \"b\"], (x) => x[0], false), src)]\n* // [ { a: [\"a\", 2], b: [\"b\", 10] },\n* // { a: [\"a\", 2], b: [\"b\", 11] },\n* // { a: [\"a\", 3], b: [\"b\", 11] } ]\n",
"new_path": "packages/transducers/src/xform/partition-sync.ts",
"old_path": "packages/transducers/src/xform/partition-sync.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | feat(transducers): add ensureArray(), refactor reverse() | 1 | feat | transducers |
217,922 | 03.07.2018 14:58:07 | -7,200 | cbbfc169b57a6f08663c15dc56f9e52421acf094 | feat(desktop): new manual update check button
closes | [
{
"change_type": "ADD",
"diff": "+owner: Supamiu\n+repo: ffxiv-teamcraft\n+provider: github\n",
"new_path": "dev-app-update.yml",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -3,6 +3,7 @@ const {autoUpdater} = require('electron-updater');\nconst path = require('path');\nconst Config = require('electron-config');\nconst config = new Config();\n+const isDev = require('electron-is-dev');\nconst electronOauth2 = require('electron-oauth2');\n@@ -26,6 +27,10 @@ for (let i = 0; i < argv.length; i++) {\n}\n}\n+if (isDev) {\n+ autoUpdater.updateConfigPath = path.join(__dirname, 'dev-app-update.yml');\n+}\n+\nif (!options.multi) {\nconst shouldQuit = app.makeSingleInstance(function (commandLine, workingDirectory) {\n// Someone tried to run a second instance, we should focus our window.\n@@ -132,6 +137,22 @@ app.on('activate', function () {\n}\n});\n+autoUpdater.on('checking-for-update', () => {\n+ win.webContents.send('checking-for-update', true);\n+});\n+\n+autoUpdater.on('download-progress', (progress) => {\n+ win.webContents.send('download-progress', progress);\n+});\n+\n+autoUpdater.on('update-available', () => {\n+ win.webContents.send('update-available', true);\n+});\n+\n+autoUpdater.on('update-not-available', () => {\n+ win.webContents.send('update-available', false);\n+});\n+\nautoUpdater.on('update-downloaded', () => {\nclearInterval(updateInterval);\ndialog.showMessageBox({\n@@ -269,3 +290,7 @@ ipcMain.on('fullscreen-toggle', () => {\nipcMain.on('minimize', () => {\nwin.minimize();\n});\n+\n+ipcMain.on('update:check', () => {\n+ autoUpdater.checkForUpdates();\n+});\n",
"new_path": "main.js",
"old_path": "main.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -8,6 +8,7 @@ import {\nMatCheckboxModule,\nMatFormFieldModule,\nMatMenuModule,\n+ MatProgressBarModule,\nMatSelectModule,\nMatSlideToggleModule\n} from '@angular/material';\n@@ -39,6 +40,7 @@ const routing: Routes = [\nMatMenuModule,\nMatButtonModule,\nMatSlideToggleModule,\n+ MatProgressBarModule,\n],\ndeclarations: [\nSettingsComponent,\n",
"new_path": "src/app/pages/settings/settings.module.ts",
"old_path": "src/app/pages/settings/settings.module.ts"
},
{
"change_type": "MODIFY",
"diff": "{{'SETTINGS.Always_on_top' | translate}}\n</mat-slide-toggle>\n+<div class=\"updater\" *ngIf=\"platform.isDesktop()\">\n+ <button mat-raised-button (click)=\"checkForUpdate()\" *ngIf=\"!updateAvailable\">{{'SETTINGS.Check_for_update' |\n+ translate}}\n+ </button>\n+ <div *ngIf=\"updateAvailable === true\">\n+ {{'SETTINGS.Downloading_update' | translate}}\n+ <mat-progress-bar [value]=\"downloadProgress.percent\"></mat-progress-bar>\n+ <span>{{downloadProgress.transferred/1000000 | number}}/{{downloadProgress.total/1000000 | number}} - {{downloadProgress.bytesPerSecond/1000000 | number}}MBps</span>\n+ </div>\n+ <div *ngIf=\"updateAvailable === false\">\n+ {{'SETTINGS.No_update_available' | translate}}\n+ </div>\n+</div>\n+\n",
"new_path": "src/app/pages/settings/settings/settings.component.html",
"old_path": "src/app/pages/settings/settings/settings.component.html"
},
{
"change_type": "MODIFY",
"diff": "width: 200px !important;\n}\n}\n+ .updater {\n+ margin: 10px 0;\n+ }\n}\n",
"new_path": "src/app/pages/settings/settings/settings.component.scss",
"old_path": "src/app/pages/settings/settings/settings.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -30,6 +30,17 @@ export class SettingsComponent {\nalwaysOnTop = false;\n+ checkingForUpdate = false;\n+\n+ updateAvailable: boolean;\n+\n+ downloadProgress: any = {\n+ bytesPerSecond: 0,\n+ percent: 0,\n+ total: 0,\n+ transferred: 0\n+ };\n+\nconstructor(public settings: SettingsService,\nprivate translate: TranslateService,\nprivate ipc: IpcService,\n@@ -42,12 +53,29 @@ export class SettingsComponent {\nthis.alwaysOnTop = value;\n});\nthis.ipc.send('always-on-top:get');\n+\n+ this.ipc.on('checking-for-update', () => {\n+ this.checkingForUpdate = true;\n+ });\n+\n+ this.ipc.on('update-available', (event, available: boolean) => {\n+ this.checkingForUpdate = false;\n+ this.updateAvailable = available;\n+ });\n+\n+ this.ipc.on('download-progress', (event, progress: any) => {\n+ this.downloadProgress = progress;\n+ });\n}\nalwaysOnTopChange(): void {\nthis.ipc.send('always-on-top', this.alwaysOnTop);\n}\n+ checkForUpdate(): void {\n+ this.ipc.send('update:check');\n+ }\n+\nuse(lang: string): void {\nif (AppComponent.LOCALES.indexOf(lang) === -1) {\nlang = 'en';\n",
"new_path": "src/app/pages/settings/settings/settings.component.ts",
"old_path": "src/app/pages/settings/settings/settings.component.ts"
},
{
"change_type": "MODIFY",
"diff": "\"theme\": \"Theme\",\n\"ffxivcrafting_display\": \"FFXIVcrafting.com-like amounts\",\n\"Simulator_link_base\": \"Simulator link\",\n- \"Always_on_top\": \"Always on top\"\n+ \"Always_on_top\": \"Always on top\",\n+ \"Check_for_update\": \"Check for update\",\n+ \"Downloading_update\": \"Downloading update\",\n+ \"No_update_available\": \"No update available\"\n},\n\"PROFILE\": {\n\"Masterbooks\": \"Masterbooks\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat(desktop): new manual update check button
closes #448 | 1 | feat | desktop |
217,922 | 03.07.2018 15:47:32 | -7,200 | d47d44a26c42e45790c0f7c2ec91dbc28367a478 | fix: fixed an issue with precrafts amount update not updating items properly
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -315,8 +315,10 @@ export class List extends DataWithPermissions {\nconst previousUsed = item.used;\n// Update used amount\nitem.used += amount;\n+ if (item.used > previousUsed && item.used >= Math.max(item.done + amount, item.amount)) {\n// Set amount to the amount of items to add to the total.\namount = amount - (item.done - previousUsed);\n+ }\nitem.done += amount;\nif (item.used > item.amount) {\nitem.used = item.amount;\n",
"new_path": "src/app/model/list/list.ts",
"old_path": "src/app/model/list/list.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed an issue with precrafts amount update not updating items properly
closes #453 | 1 | fix | null |
217,922 | 03.07.2018 16:03:23 | -7,200 | 18ee084d5e5b01f75ac4003ea27aa5bbf4f77a66 | chore: update to garlanddata api v3
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -30,7 +30,7 @@ export class DataService {\n];\nprivate garlandUrl = 'https://www.garlandtools.org/db/doc';\n- private garlandtoolsVersion = 2;\n+ private garlandtoolsVersion = 3;\nprivate garlandApiUrl = 'https://www.garlandtools.org/api';\nprivate characterCache = new Map<number, Observable<any>>();\n",
"new_path": "src/app/core/api/data.service.ts",
"old_path": "src/app/core/api/data.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -15,7 +15,7 @@ export class GarlandToolsService {\npublic preload(): void {\nif (this.gt.jobCategories === undefined) {\n- this.http.get<GarlandToolsData>('https://www.garlandtools.org/db/doc/core/en/2/data.json')\n+ this.http.get<GarlandToolsData>('https://www.garlandtools.org/db/doc/core/en/3/data.json')\n.subscribe(data => this.gt = Object.assign(this.gt, data));\n}\n}\n",
"new_path": "src/app/core/api/garland-tools.service.ts",
"old_path": "src/app/core/api/garland-tools.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -12,17 +12,19 @@ export class TradeSourcesExtractor extends AbstractExtractor<TradeSource[]> {\n}\nprotected canExtract(item: Item): boolean {\n- return item.tradeSources !== undefined;\n+ return item.tradeShops !== undefined;\n}\nprotected doExtract(item: Item, itemData: ItemData): TradeSource[] {\nconst tradeSources: TradeSource [] = [];\n- for (const ts of Object.keys(item.tradeSources)) {\n- const partial = itemData.getPartial(ts, 'npc');\n+ for (const ts of item.tradeShops) {\nconst tradeSource: TradeSource = {\nnpcId: +ts,\n- trades: []\n+ trades: [],\n+ shopName: ts.shop\n};\n+ for (const npcId of ts.npcs) {\n+ const partial = itemData.getPartial(npcId.toString(), 'npc');\nif (partial.c !== undefined && partial.i !== undefined && partial.a !== undefined) {\ntradeSource.coords = {\nx: partial.c[0],\n@@ -31,7 +33,8 @@ export class TradeSourcesExtractor extends AbstractExtractor<TradeSource[]> {\ntradeSource.zoneId = partial.i;\ntradeSource.areaId = partial.a;\n}\n- for (const row of item.tradeSources[ts]) {\n+ }\n+ for (const row of ts.listings) {\nconst currencyPartial = itemData.getPartial(row.currency[0].id, 'item').obj;\nconst trade: Trade = {\nitemIcon: item.icon,\n",
"new_path": "src/app/core/list/data/extractor/trade-sources-extractor.ts",
"old_path": "src/app/core/list/data/extractor/trade-sources-extractor.ts"
},
{
"change_type": "MODIFY",
"diff": "import {Craft} from './craft';\nimport {I18nData} from '../list/i18n-data';\n-import {TradeData} from './trade-data';\nimport {I18nDataRow} from '../list/i18n-data-row';\nimport {DeserializeFieldName} from '@kaiu/serializer';\nimport {Fish} from './fish';\n@@ -27,7 +26,7 @@ export class Item implements I18nData {\ntradeable?: number;\ncraft?: Craft[];\nvendors?: number[];\n- tradeSources?: { [index: number]: TradeData };\n+ tradeShops?: any[];\ndrops?: number[];\nnodes?: number[];\nventures?: number[];\n",
"new_path": "src/app/model/garland-tools/item.ts",
"old_path": "src/app/model/garland-tools/item.ts"
},
{
"change_type": "MODIFY",
"diff": "import {Trade} from './trade';\nexport interface TradeSource {\n+ // The name of the shop, only in english for now\n+ shopName: string;\nnpcId: number;\nzoneId?: number;\nareaId?: number;\n",
"new_path": "src/app/model/list/trade-source.ts",
"old_path": "src/app/model/list/trade-source.ts"
},
{
"change_type": "MODIFY",
"diff": "<h2 mat-dialog-title>{{data.id | itemName | i18n}}</h2>\n<div mat-dialog-content>\n<mat-list *ngFor=\"let tradeSource of data.tradeSources\">\n- <h3 mat-subheader>{{tradeSource.npcId | npcName | i18n}} - {{tradeSource.zoneId | placeName | i18n}}</h3>\n+ <h3 mat-subheader>{{tradeSource.npcId | npcName | i18n}} - {{tradeSource.zoneId | placeName | i18n}}\n+ ({{tradeSource.shopName}})</h3>\n<mat-list-item *ngFor=\"let trade of tradeSource.trades\">\n<div class=\"trade-part\">\n<app-item-icon [item]=\"{icon: trade.currencyIcon, id: trade.currencyId}\"></app-item-icon>\n",
"new_path": "src/app/modules/item/trade-details-popup/trade-details-popup.component.html",
"old_path": "src/app/modules/item/trade-details-popup/trade-details-popup.component.html"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: update to garlanddata api v3
closes #456 | 1 | chore | null |
217,922 | 03.07.2018 19:17:31 | -7,200 | 4dcb005757620bb13ca75859c5ac6be6666b10a7 | fix: fixed a bug with user validation process | [
{
"change_type": "MODIFY",
"diff": "@@ -82,6 +82,15 @@ export class UserService extends FirebaseStorage<AppUser> {\n);\n}\n+ public getCharacterWithoutCache(): Observable<any> {\n+ return this.getUserData()\n+ .pipe(\n+ mergeMap(user => {\n+ return this.dataService.getCharacter(user.lodestoneId);\n+ })\n+ );\n+ }\n+\n/**\n* Returns user data informations.\n* @returns {Observable<AppUser>}\n",
"new_path": "src/app/core/database/user.service.ts",
"old_path": "src/app/core/database/user.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -16,11 +16,11 @@ export class UserVerificationPopupComponent {\n}\npublic check(): void {\n- this.userService.getCharacter()\n+ this.userService.getCharacterWithoutCache()\n.pipe(\nfirst(),\nmergeMap((character) => {\n- this.user.verified = character.biography.indexOf(character.user.$key) > -1;\n+ this.user.verified = character.biography.indexOf(this.user.$key) > -1;\nreturn this.userService.set(this.user.$key, this.user);\n})\n)\n",
"new_path": "src/app/modules/common-components/user-verification-popup/user-verification-popup.component.ts",
"old_path": "src/app/modules/common-components/user-verification-popup/user-verification-popup.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed a bug with user validation process | 1 | fix | null |
791,766 | 03.07.2018 21:56:25 | -7,200 | c1cc09cfe82b40fcdd4eea947604e71fb53a518a | docs(custom-audit): update custom-audit to 3.0.0 api | [
{
"change_type": "MODIFY",
"diff": "@@ -25,9 +25,9 @@ module.exports = {\n// 4. Create a new 'My site metrics' section in the default report for our results.\ncategories: {\nmysite: {\n- name: 'My site metrics',\n+ title: 'My site metrics',\ndescription: 'Metrics for our super awesome site',\n- audits: [\n+ auditRefs: [\n// When we add more custom audits, `weight` controls how they're averaged together.\n{id: 'searchable-audit', weight: 1},\n],\n",
"new_path": "docs/recipes/custom-audit/custom-config.js",
"old_path": "docs/recipes/custom-audit/custom-config.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -37,7 +37,8 @@ class LoadAudit extends Audit {\nreturn {\nrawValue: loadMetrics.searchableTime,\n- score: belowThreshold,\n+ // Cast true/false to 1/0\n+ score: Number(belowThreshold),\n};\n}\n}\n",
"new_path": "docs/recipes/custom-audit/searchable-audit.js",
"old_path": "docs/recipes/custom-audit/searchable-audit.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | docs(custom-audit): update custom-audit to 3.0.0 api (#5612) | 1 | docs | custom-audit |
791,676 | 03.07.2018 21:59:02 | -7,200 | b80e4554864d9c0b86478bb9869011c51573af71 | extension: fix "extension Error: couldn't resolve current tab" | [
{
"change_type": "MODIFY",
"diff": "@@ -34,6 +34,8 @@ const subpageVisibleClass = 'subpage--visible';\n/** @type {?URL} */\nlet siteURL = null;\n+/** @type {boolean} */\n+let isRunning = false;\nfunction getLighthouseVersion() {\nreturn chrome.runtime.getManifest().version;\n@@ -147,6 +149,11 @@ function createOptionItem(text, id, isChecked) {\n* @param {{selectedCategories: Array<string>, useDevTools: boolean}} settings\n*/\nasync function onGenerateReportButtonClick(background, settings) {\n+ if (isRunning) {\n+ return;\n+ }\n+ isRunning = true;\n+\nshowRunningSubpage();\nconst feedbackEl = find('.feedback');\n@@ -185,6 +192,8 @@ async function onGenerateReportButtonClick(background, settings) {\nhideRunningSubpage();\nbackground.console.error(err);\n}\n+\n+ isRunning = false;\n}\n/**\n",
"new_path": "lighthouse-extension/app/src/popup.js",
"old_path": "lighthouse-extension/app/src/popup.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | extension: fix "extension Error: couldn't resolve current tab" (#5591) | 1 | extension | null |
679,913 | 04.07.2018 11:52:50 | -3,600 | d5ac26439fe5c2517d379bc244566e2d02212ce0 | feat(rstream): add support for event listener opts in `fromEvent()` | [
{
"change_type": "MODIFY",
"diff": "import { Stream } from \"../stream\";\n-export function fromEvent(src: EventTarget, id: string) {\n+/**\n+ * Creates a new stream of DOM events attached to given element / event\n+ * target and using given event listener options (same as supported by\n+ * `addEventListener()`, default: false).\n+ *\n+ * @param src event target\n+ * @param name event name\n+ * @param opts listener opts\n+ */\n+export function fromEvent(src: EventTarget, name: string, opts: boolean | AddEventListenerOptions = false) {\nreturn new Stream<Event>((stream) => {\nlet listener = (e) => stream.next(e);\n- src.addEventListener(id, listener);\n- return () => src.removeEventListener(id, listener);\n- }, `event-${id}-${Stream.NEXT_ID++}`);\n+ src.addEventListener(name, listener, opts);\n+ return () => src.removeEventListener(name, listener, opts);\n+ }, `event-${name}-${Stream.NEXT_ID++}`);\n}\n",
"new_path": "packages/rstream/src/from/event.ts",
"old_path": "packages/rstream/src/from/event.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | feat(rstream): add support for event listener opts in `fromEvent()` | 1 | feat | rstream |
679,913 | 04.07.2018 11:54:39 | -3,600 | de17340a26730cd073aa0cdd64dbdbb6bfde6d27 | feat(rstream-gestures): add event & preventDefault opts, update docs | [
{
"change_type": "MODIFY",
"diff": "@@ -24,6 +24,16 @@ export interface GestureEvent {\n}\nexport interface GestureStreamOpts extends IID<string> {\n+ /**\n+ * Event listener options (see standard `addEventListener()`)\n+ * Default: false\n+ */\n+ eventOpts: boolean | AddEventListenerOptions;\n+ /**\n+ * If `true`, calls `preventDefault()` for each event.\n+ * Default: true\n+ */\n+ preventDefault: boolean;\n/**\n* Initial zoom value. Default: 1\n*/\n@@ -58,9 +68,12 @@ export interface GestureStreamOpts extends IID<string> {\n* events. The value will be constrained to `minZoom` ... `maxZoom`\n* interval (provided via options object).\n*\n- * Note: For touch events `preventDefault()` is called automatically.\n- * Since Chrome 56 (other browsers too), this means the event target\n- * element cannot be `document.body` anymore.\n+ * Note: If using `preventDefault` and attaching the event stream to\n+ * `document.body`, the following event listener options SHOULD be used:\n+ *\n+ * ```\n+ * eventOpts: { passive: false }\n+ * ```\n*\n* See: https://www.chromestatus.com/features/5093566007214080\n*\n@@ -75,7 +88,9 @@ export function gestureStream(el: Element, opts?: Partial<GestureStreamOpts>): S\nzoom: 1,\nminZoom: 0.25,\nmaxZoom: 4,\n- smooth: 1\n+ smooth: 1,\n+ eventOpts: { capture: true },\n+ preventDefault: true,\n}, opts);\nlet zoom = Math.min(Math.max(opts.zoom, opts.minZoom), opts.maxZoom);\nreturn merge({\n@@ -84,12 +99,11 @@ export function gestureStream(el: Element, opts?: Partial<GestureStreamOpts>): S\n\"mousedown\", \"mousemove\", \"mouseup\",\n\"touchstart\", \"touchmove\", \"touchend\", \"touchcancel\",\n\"wheel\"\n- ].map((e) => fromEvent(el, e)),\n-\n+ ].map((e) => fromEvent(el, e, opts.eventOpts)),\nxform: map((e: MouseEvent | TouchEvent | WheelEvent) => {\nlet evt, type;\n+ opts.preventDefault && e.preventDefault();\nif (e instanceof TouchEvent) {\n- e.preventDefault();\ntype = {\n\"touchstart\": GestureType.START,\n\"touchmove\": GestureType.DRAG,\n",
"new_path": "packages/rstream-gestures/src/index.ts",
"old_path": "packages/rstream-gestures/src/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | feat(rstream-gestures): add event & preventDefault opts, update docs | 1 | feat | rstream-gestures |
679,913 | 04.07.2018 11:55:00 | -3,600 | 36165be8c8eeb52803f3455a27324ac10d2fd464 | minor(rstream-graph): formatting | [
{
"change_type": "MODIFY",
"diff": "@@ -171,7 +171,7 @@ export const addNode = (graph: Graph, state: IAtom<any>, id: string, spec: NodeS\nreturn graph[id] = nodeFromSpec(state, spec, id)(\n(path) => getIn(graph, absPath([id], path))\n);\n-}\n+};\n/**\n* Calls `.unsubscribe()` on given node and all of its outputs, then\n",
"new_path": "packages/rstream-graph/src/graph.ts",
"old_path": "packages/rstream-graph/src/graph.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | minor(rstream-graph): formatting | 1 | minor | rstream-graph |
749,547 | 04.07.2018 14:08:26 | -36,000 | 1a67f439d876b0bce9646baf7fc62b58a85bc2e9 | feat(theming): Add a document prop and getDocument util to help with iframes
Adds a `getDocument` util and an extra prop to `ThemeProvider`. This allows passing down a different document context. | [
{
"change_type": "MODIFY",
"diff": "import PropTypes from 'prop-types';\nimport scrollTo from 'dom-helpers/util/scrollTo';\n-import { isRtl, withTheme } from '@zendeskgarden/react-theming';\n+import { isRtl, withTheme, getDocument } from '@zendeskgarden/react-theming';\nimport ControlledComponent from '../utils/ControlledComponent';\nimport composeEventHandlers from '../utils/composeEventHandlers';\n@@ -87,13 +87,14 @@ export class SelectionContainer extends ControlledComponent {\ncomponentDidUpdate(prevProps, prevState) {\nconst current = this.props.focusedKey === undefined ? this.state : this.props;\nconst prev = prevProps.focusedKey === undefined ? prevState : prevProps;\n+ const doc = getDocument(this.props) || document;\n/**\n* We must programatically scroll the newly focused element into view.\n* Side-effect of the `aria-activedescendant` accessibility strategy.\n*/\nif (typeof current.focusedKey !== 'undefined' && current.focusedKey !== prev.focusedKey) {\n- const itemNode = document.getElementById(this.getItemId(current.focusedKey));\n+ const itemNode = doc.getElementById(this.getItemId(current.focusedKey));\n/* istanbul ignore if */\nif (itemNode) {\n",
"new_path": "packages/selection/src/containers/SelectionContainer.js",
"old_path": "packages/selection/src/containers/SelectionContainer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -12,7 +12,8 @@ import { ThemeProvider as StyledThemeProvider } from 'styled-components';\nconst ThemeProvider = props => {\nconst theme = {\nrtl: props.rtl,\n- styles: props.theme\n+ styles: props.theme,\n+ document: props.document\n};\nreturn <StyledThemeProvider theme={theme}>{props.children}</StyledThemeProvider>;\n@@ -21,7 +22,8 @@ const ThemeProvider = props => {\nThemeProvider.propTypes = {\nchildren: PropTypes.node,\nrtl: PropTypes.bool,\n- theme: PropTypes.object\n+ theme: PropTypes.object,\n+ document: PropTypes.object\n};\n/** @component */\n",
"new_path": "packages/theming/src/ThemeProvider/ThemeProvider.js",
"old_path": "packages/theming/src/ThemeProvider/ThemeProvider.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -9,3 +9,4 @@ export { default as ThemeProvider } from './ThemeProvider/ThemeProvider';\nexport { default as isRtl } from './utils/isRtl';\nexport { default as retrieveTheme } from './utils/retrieveTheme';\nexport { default as withTheme } from './utils/withTheme';\n+export { default as getDocument } from './utils/getDocument';\n",
"new_path": "packages/theming/src/index.js",
"old_path": "packages/theming/src/index.js"
},
{
"change_type": "ADD",
"diff": "+/**\n+ * Copyright Zendesk, Inc.\n+ *\n+ * Use of this source code is governed under the Apache License, Version 2.0\n+ * found at http://www.apache.org/licenses/LICENSE-2.0.\n+ */\n+\n+/** @component */\n+export default function getDocument({ theme } = {}) {\n+ return theme && theme.document;\n+}\n",
"new_path": "packages/theming/src/utils/getDocument.js",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+/**\n+ * Copyright Zendesk, Inc.\n+ *\n+ * Use of this source code is governed under the Apache License, Version 2.0\n+ * found at http://www.apache.org/licenses/LICENSE-2.0.\n+ */\n+\n+import getDocument from './getDocument';\n+\n+describe('getDocument', () => {\n+ const doc = {};\n+\n+ it('returns document if theme has document prop passed', () => {\n+ expect(\n+ getDocument({\n+ theme: {\n+ document: doc\n+ }\n+ })\n+ ).toBe(doc);\n+ });\n+\n+ it('returns undefined if theme has no document prop passed', () => {\n+ expect(\n+ getDocument({\n+ theme: {}\n+ })\n+ ).toBeUndefined();\n+ });\n+\n+ it('returns undefined if no theme is provided', () => {\n+ expect(getDocument({})).toBeUndefined();\n+ });\n+\n+ it('returns undefined if no props are provided', () => {\n+ expect(getDocument()).toBeUndefined();\n+ });\n+});\n",
"new_path": "packages/theming/src/utils/getDocument.spec.js",
"old_path": null
}
] | TypeScript | Apache License 2.0 | zendeskgarden/react-components | feat(theming): Add a document prop and getDocument util to help with iframes (#49)
Adds a `getDocument` util and an extra prop to `ThemeProvider`. This allows passing down a different document context. | 1 | feat | theming |
807,849 | 04.07.2018 15:16:14 | 25,200 | 903163759699a993ecbe3117cffacb3ff7a81f57 | chore: disable import/order in test files | [
{
"change_type": "MODIFY",
"diff": "rules:\n# dev dependencies are hoisted to the root\nimport/no-extraneous-dependencies: off\n+ # mocked modules are imported before helpers\n+ import/order: off\nnode/no-extraneous-require: off\nnode/no-unpublished-require: off\nnode/no-unsupported-features:\n",
"new_path": ".eslintrc.yaml",
"old_path": ".eslintrc.yaml"
}
] | JavaScript | MIT License | lerna/lerna | chore: disable import/order in test files | 1 | chore | null |
807,849 | 04.07.2018 15:16:24 | 25,200 | 569c09b86791009b2288bd2db4a555a4f445b8c8 | chore: fix new lint errors | [
{
"change_type": "MODIFY",
"diff": "@@ -16,10 +16,10 @@ const npmInstall = require(\"@lerna/npm-install\");\nconst runLifecycle = require(\"@lerna/run-lifecycle\");\nconst batchPackages = require(\"@lerna/batch-packages\");\nconst runParallelBatches = require(\"@lerna/run-parallel-batches\");\n-const hasDependencyInstalled = require(\"./lib/has-dependency-installed\");\nconst symlinkBinary = require(\"@lerna/symlink-binary\");\nconst symlinkDependencies = require(\"@lerna/symlink-dependencies\");\nconst ValidationError = require(\"@lerna/validation-error\");\n+const hasDependencyInstalled = require(\"./lib/has-dependency-installed\");\nconst isHoistedPackage = require(\"./lib/is-hoisted-package\");\nconst makeNpmFeaturePredicate = require(\"./lib/make-npm-feature-predicate\");\n",
"new_path": "commands/bootstrap/index.js",
"old_path": "commands/bootstrap/index.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -50,6 +50,7 @@ describe(\"core-command\", () => {\ninitialize() {\nreturn true;\n}\n+\nexecute() {}\n}\n@@ -181,6 +182,7 @@ describe(\"core-command\", () => {\ninitialize() {\nreturn true;\n}\n+\nexecute() {\nconst err = new Error(\"message\");\n",
"new_path": "core/command/__tests__/command.test.js",
"old_path": "core/command/__tests__/command.test.js"
}
] | JavaScript | MIT License | lerna/lerna | chore: fix new lint errors | 1 | chore | null |
807,849 | 04.07.2018 15:41:30 | 25,200 | a6e41d64d1ec8e86a5ad0b570c2f77c884f815c8 | docs(filter-options): Flesh out readme, correct wishful thinking | [
{
"change_type": "MODIFY",
"diff": "## Usage\n-TODO\n+`--scope`\n+\n+Include only packages with names matching the given glob.\n+\n+`--ignore`\n+\n+Exclude packages with names matching the given glob.\n+\n+`--no-private`\n+\n+Exclude private packages. They are included by default.\n+\n+`--since [ref]`\n+\n+Only include packages that have been updated since the specified `ref`. If no ref is passed, it defaults to the most-recent tag.\n+\n+`--include-filtered-dependents`\n+\n+Include all transitive dependents when running a command regardless of `--scope`, `--ignore`, or `--since`.\n+\n+`--include-filtered-dependencies`\n+\n+Include all transitive dependencies when running a command regardless of `--scope`, `--ignore`, or `--since`.\n",
"new_path": "core/filter-options/README.md",
"old_path": "core/filter-options/README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -29,15 +29,15 @@ function filterOptions(yargs) {\n},\n\"include-filtered-dependents\": {\ndescribe: dedent`\n- Include all transitive dependents when running a command,\n- regardless of --include, --exclude or --since.\n+ Include all transitive dependents when running a command\n+ regardless of --scope, --ignore, or --since.\n`,\nboolean: true,\n},\n\"include-filtered-dependencies\": {\ndescribe: dedent`\n- Include all transitive dependencies when running a command,\n- regardless of --include, --exclude or --since.\n+ Include all transitive dependencies when running a command\n+ regardless of --scope, --ignore, or --since.\n`,\nboolean: true,\n},\n",
"new_path": "core/filter-options/index.js",
"old_path": "core/filter-options/index.js"
}
] | JavaScript | MIT License | lerna/lerna | docs(filter-options): Flesh out readme, correct wishful thinking | 1 | docs | filter-options |
679,913 | 04.07.2018 18:09:53 | -3,600 | 3d9d6200ba43c3bd1bcb36e6d37164cd2bc116a0 | feat(paths): update setter() to support arrays, optimize (~2.5x faster) | [
{
"change_type": "MODIFY",
"diff": "@@ -6,13 +6,11 @@ export type Path = PropertyKey | PropertyKey[];\nexport type UpdateFn<T> = (curr: T, ...args: any[]) => T;\n-function compS(k, f) {\n- return (s, v) => ({ ...s, [k]: f((s || {})[k], v) });\n-}\n+const _copy = (s) => Array.isArray(s) ? s.slice() : { ...s };\n-function compG(k, f) {\n- return (s) => s ? f(s[k]) : undefined;\n-}\n+const compS = (k, f) => (s, v) => { s = _copy(s); s[k] = f ? f(s[k], v) : v; return s; }\n+\n+const compG = (k, f) => (s) => s ? f(s[k]) : undefined;\n/**\n* Converts the given key path to canonical form (array).\n@@ -118,7 +116,7 @@ export function getter(path: Path) {\n* // { a: { b: { c: 24 } } }\n* ```\n*\n- * Only keys in the path will be modied, all other keys present in the\n+ * Only keys in the path will be modified, all other keys present in the\n* given object retain their original values to provide efficient\n* structural sharing / re-use.\n*\n@@ -142,17 +140,16 @@ export function setter(path: Path) {\ncase 0:\nreturn (_, v) => v;\ncase 1:\n- return (s, v) => ({ ...s, [a]: v });\n+ return (s, v) => (s = _copy(s), s[a] = v, s);\ncase 2:\n- return (s, v) => ({ ...(s = s || {}), [a]: { ...s[a], [b]: v } });\n+ return (s, v) => { let x; s = _copy(s); s[a] = x = _copy(s[a]); x[b] = v; return s; };\ncase 3:\n- return (s, v) => ({ ...(s = s || {}), [a]: { ...(s = s[a] || {}), [b]: { ...s[b], [c]: v } } });\n+ return (s, v) => { let x, y; s = _copy(s); s[a] = x = _copy(s[a]); x[b] = y = _copy(x[b]); y[c] = v; return s; };\ncase 4:\n- return (s, v) => ({ ...(s = s || {}), [a]: { ...(s = s[a] || {}), [b]: { ...(s = s[b] || {}), [c]: { ...s[c], [d]: v } } } });\n+ return (s, v) => { let x, y, z; s = _copy(s); s[a] = x = _copy(s[a]); x[b] = y = _copy(x[b]); y[c] = z = _copy(y[c]); z[d] = v; return s; };\ndefault:\n- const kl = ks[ks.length - 1];\n- let f = (s, v) => ({ ...(s || {}), [kl]: v });\n- for (let i = ks.length - 2; i >= 0; i--) {\n+ let f;\n+ for (let i = ks.length - 1; i >= 0; i--) {\nf = compS(ks[i], f);\n}\nreturn f;\n",
"new_path": "packages/paths/src/index.ts",
"old_path": "packages/paths/src/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | feat(paths): update setter() to support arrays, optimize (~2.5x faster) | 1 | feat | paths |
807,864 | 04.07.2018 18:27:13 | 14,400 | 063738e313da12c5703600d2c5febce2796686c8 | doc: Add local links to command sections in TOC [skip ci] | [
{
"change_type": "MODIFY",
"diff": "* [How It Works](#how-it-works)\n* [Troubleshooting](#troubleshooting)\n* [Commands](#commands)\n+ - [init](#init)\n+ - [bootstrap](#bootstrap)\n+ - [add](#add)\n+ - [publish](#publish)\n+ - [updated](#updated)\n+ - [clean](#clean)\n+ - [diff](#diff)\n+ - [ls](#ls)\n+ - [run](#run)\n+ - [exec](#exec)\n+ - [import](#import)\n+ - [link](#link)\n* [Misc](#misc)\n* [Lerna.json](#lernajson)\n* [Flags](#flags)\n",
"new_path": "README.md",
"old_path": "README.md"
}
] | JavaScript | MIT License | lerna/lerna | doc: Add local links to command sections in TOC (#1460) [skip ci] | 1 | doc | null |
679,913 | 04.07.2018 19:25:34 | -3,600 | c7f2f92d84e40bb6a3e21064cc6d4e8bb9772bc3 | test(paths): add/update tests | [
{
"change_type": "MODIFY",
"diff": "@@ -93,6 +93,48 @@ describe(\"paths\", () => {\n);\n});\n+ it(\"setIn (len = 5)\", () => {\n+ assert.deepEqual(\n+ setIn({ a: { b: { c: { d: { e: 23 } } } } }, \"a.b.c.d.e\", 24),\n+ { a: { b: { c: { d: { e: 24 } } } } }\n+ );\n+ assert.deepEqual(\n+ setIn({ a: { b: { c: 23 } } }, \"a.b.d.e.f\", 24),\n+ { a: { b: { c: 23, d: { e: { f: 24 } } } } }\n+ );\n+ assert.deepEqual(\n+ setIn({ x: 23 }, \"a.b.c.d.e\", 24),\n+ { x: 23, a: { b: { c: { d: { e: 24 } } } } }\n+ );\n+ assert.deepEqual(\n+ setIn(null, \"a.b.c.d.e\", 24),\n+ { a: { b: { c: { d: { e: 24 } } } } }\n+ );\n+ });\n+\n+ it(\"setIn arr\", () => {\n+ assert.deepEqual(\n+ setIn([1, 2], 0, 10),\n+ [10, 2]\n+ );\n+ assert.deepEqual(\n+ setIn([[1, 2], 3], [0, 1], 10),\n+ [[1, 10], 3]\n+ );\n+ assert.deepEqual(\n+ setIn([[1, 2, 3], 4], [0, 1, 2], 10),\n+ [[1, { 2: 10 }, 3], 4]\n+ );\n+ assert.deepEqual(\n+ setIn([[1, 2, 3], 4], [0, 1, 2, \"a\"], 10),\n+ [[1, { 2: { a: 10 } }, 3], 4]\n+ );\n+ assert.deepEqual(\n+ setIn([[1, 2, 3], 4], [0, 1, 2, \"a\", \"b\"], 10),\n+ [[1, { 2: { a: { b: 10 } } }, 3], 4]\n+ );\n+ });\n+\nit(\"immutable\", () => {\nconst a = { x: { y: { z: 1 } }, u: { v: 2 } };\nconst b = setIn(a, \"a.b.c\", 3);\n",
"new_path": "packages/paths/test/index.ts",
"old_path": "packages/paths/test/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | test(paths): add/update tests | 1 | test | paths |
679,913 | 04.07.2018 19:37:49 | -3,600 | dbbeffb307c8f474abd2628633488b6c3bc2962f | docs(paths): update docs & readme | [
{
"change_type": "MODIFY",
"diff": "@@ -8,7 +8,8 @@ This project is part of the\n## About\nThis library provides immutable and mutable, optimized path-based\n-accessors for vanilla JS objects.\n+accessors for nested, vanilla JS objects & arrays with structural\n+sharing.\n## Installation\n@@ -27,19 +28,19 @@ yarn add @thi.ng/paths\nimport * as paths from \"@thi.ng/paths\";\n```\n-The `getter()` and `setter()` functions transform a path like `a.b.c`\n-into a function operating directly at the value the path points to in\n-nested object. For getters, this essentially compiles to `val =\n+The `getter()` and `setter()` functions compile a lookup path like\n+`a.b.c` into a function operating directly at the value the path points\n+to in nested object. For getters, this essentially compiles to `val =\nobj.a.b.c`, with the important difference that the function returns\n`undefined` if any intermediate values along the lookup path are\nundefined (and doesn't throw an error).\n-The resulting setter function too accepts a single object to operate on\n-and when called, **immutably** replaces the value at the given path,\n-i.e. it produces a selective deep copy of obj up until given path. If\n-any intermediate key is not present in the given object, it creates a\n-plain empty object for that missing key and descends further along the\n-path.\n+The resulting setter function too accepts a single object (or array) to\n+operate on and when called, **immutably** replaces the value at the\n+given path, i.e. it produces a selective deep copy of obj up until given\n+path. If any intermediate key is not present in the given object, it\n+creates a plain empty object for that missing key and descends further\n+along the path.\n```typescript\ns = setter(\"a.b.c\");\n@@ -79,13 +80,15 @@ deleteIn(state, \"a.b.c.\")\n// {a: {b: {}}}\n```\n+### Structural sharing\n+\nOnly keys in the path will be updated, all other keys present in the\ngiven object retain their original/identical values to provide efficient\nstructural sharing / re-use. This is the same *behavior* as in Clojure's\nimmutable maps or those provided by ImmutableJS (albeit those\nimplementation are completely different - they're using trees, we're\n-using the ES6 spread op and recursive functional composition to produce\n-the setter/updater).\n+using the ES6 spread op (for objects, `slice()` for arrays) and dynamic\n+functional composition to produce the setter/updater).\n```typescript\ns = setter(\"a.b.c\");\n",
"new_path": "packages/paths/README.md",
"old_path": "packages/paths/README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -35,6 +35,8 @@ export function toPath(path: Path) {\n/**\n* Composes a getter function for given nested lookup path. Optimized\n* fast execution paths are provided for path lengths less than 5.\n+ * Supports any `[]`-indexable data structure (arrays, objects,\n+ * strings).\n*\n* If `path` is given as string, it will be split using `.`. Returns\n* function which accepts single object and when called, returns value\n@@ -85,8 +87,12 @@ export function getter(path: Path) {\n}\n/**\n- * Composes a setter function for given nested lookup path. Optimized\n- * fast execution paths are provided for path lengths less than 5.\n+ * Composes a setter function for given nested update path. Optimized\n+ * fast execution paths are provided for path lengths less up to 4.\n+ * Supports both arrays and objects and creates intermediate shallow\n+ * copies at each level of the path. Thus provides structural sharing\n+ * with the original data for any branches not being updated by the\n+ * setter.\n*\n* If `path` is given as string, it will be split using `.`. Returns\n* function which accepts single object and when called, **immutably**\n",
"new_path": "packages/paths/src/index.ts",
"old_path": "packages/paths/src/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | docs(paths): update docs & readme | 1 | docs | paths |
135,426 | 05.07.2018 09:33:39 | 18,000 | e22bd5cfbe7da49aefc59e5ca0c3e905f61df40b | docs(readme): "conventional" not "convention" | [
{
"change_type": "MODIFY",
"diff": "# @commitlint/config-conventional\n-Shareable `commitlint` config enforcing [convention commits](https://conventionalcommits.org/).\n+Shareable `commitlint` config enforcing [conventional commits](https://conventionalcommits.org/).\nUse with [@commitlint/cli](../cli) and [@commitlint/prompt-cli](../prompt-cli).\n| :warning: | |\n",
"new_path": "@commitlint/config-conventional/README.md",
"old_path": "@commitlint/config-conventional/README.md"
}
] | TypeScript | MIT License | conventional-changelog/commitlint | docs(readme): "conventional" not "convention" | 1 | docs | readme |
730,429 | 05.07.2018 11:46:46 | 14,400 | d7ea8676499959ba425b84931dda64088acb7401 | test(journeys): reduce amount of file transfer tests | [
{
"change_type": "MODIFY",
"diff": "@@ -112,61 +112,13 @@ describe('Widget Space: One on One: Data API', () => {\n});\ndescribe('File Transfer Tests', () => {\n- it('sends message with pdf attachment', () => {\n- messageTests.sendFileTest(local, remote, 'pdf-sample.pdf');\n- });\n-\n- it('sends message with txt attachment', () => {\n- messageTests.sendFileTest(local, remote, 'txt-sample.txt');\n- });\n-\n- it('sends message with doc attachment', () => {\n- messageTests.sendFileTest(local, remote, 'doc-sample.doc');\n- });\n-\n- it('sends message with docx attachment', () => {\n- messageTests.sendFileTest(local, remote, 'docx-sample.docx');\n- });\n-\n- it('sends message with ppt attachment', () => {\n- messageTests.sendFileTest(local, remote, 'ppt-sample.ppt');\n- });\n-\n- it('sends message with html attachment', () => {\n- messageTests.sendFileTest(local, remote, 'html-sample.html');\n- });\n-\n- it('sends message with json attachment', () => {\n- messageTests.sendFileTest(local, remote, 'json-sample.json');\n- });\n-\n- it('sends message with zip attachment', () => {\n- messageTests.sendFileTest(local, remote, 'zip-sample.zip');\n- });\n-\n- it('sends message with gif attachment', () => {\n- messageTests.sendFileTest(local, remote, 'gif-sample.gif', false);\n- });\n-\n- it('sends message with jpg attachment', () => {\n- messageTests.sendFileTest(local, remote, 'jpg-sample.jpg', false);\n- });\n-\nit('sends message with png attachment', () => {\nmessageTests.sendFileTest(local, remote, 'png-sample.png');\n});\n- it('sends message with mp3 attachment', () => {\n- messageTests.sendFileTest(local, remote, 'mp3-sample.mp3');\n- });\n-\nit('verifies png-sample is in files tab', () => {\nmessageTests.filesTabTest(local, remote, 'png-sample.png');\n});\n-\n- it('verifies mp3-sample is in files tab', () => {\n- messageTests.filesTabTest(local, remote, 'mp3-sample.mp3', false);\n- });\n});\ndescribe('markdown messaging', () => {\n",
"new_path": "test/journeys/specs/oneOnOne/dataApi/messaging.js",
"old_path": "test/journeys/specs/oneOnOne/dataApi/messaging.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -126,61 +126,13 @@ describe('Widget Space: One on One', () => {\n});\ndescribe('File Transfer Tests', () => {\n- it('sends message with pdf attachment', () => {\n- messageTests.sendFileTest(local, remote, 'pdf-sample.pdf');\n- });\n-\n- it('sends message with txt attachment', () => {\n- messageTests.sendFileTest(local, remote, 'txt-sample.txt');\n- });\n-\n- it('sends message with doc attachment', () => {\n- messageTests.sendFileTest(local, remote, 'doc-sample.doc');\n- });\n-\n- it('sends message with docx attachment', () => {\n- messageTests.sendFileTest(local, remote, 'docx-sample.docx');\n- });\n-\n- it('sends message with ppt attachment', () => {\n- messageTests.sendFileTest(local, remote, 'ppt-sample.ppt');\n- });\n-\n- it('sends message with html attachment', () => {\n- messageTests.sendFileTest(local, remote, 'html-sample.html');\n- });\n-\n- it('sends message with json attachment', () => {\n- messageTests.sendFileTest(local, remote, 'json-sample.json');\n- });\n-\n- it('sends message with zip attachment', () => {\n- messageTests.sendFileTest(local, remote, 'zip-sample.zip');\n- });\n-\n- it('sends message with gif attachment', () => {\n- messageTests.sendFileTest(local, remote, 'gif-sample.gif', false);\n- });\n-\n- it('sends message with jpg attachment', () => {\n- messageTests.sendFileTest(local, remote, 'jpg-sample.jpg', false);\n- });\n-\nit('sends message with png attachment', () => {\nmessageTests.sendFileTest(local, remote, 'png-sample.png');\n});\n- it('sends message with mp3 attachment', () => {\n- messageTests.sendFileTest(local, remote, 'mp3-sample.mp3');\n- });\n-\nit('verifies png-sample is in files tab', () => {\nmessageTests.filesTabTest(local, remote, 'png-sample.png');\n});\n-\n- it('verifies mp3-sample is in files tab', () => {\n- messageTests.filesTabTest(local, remote, 'mp3-sample.mp3', false);\n- });\n});\ndescribe('markdown messaging', () => {\n",
"new_path": "test/journeys/specs/oneOnOne/global/messaging.js",
"old_path": "test/journeys/specs/oneOnOne/global/messaging.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -176,61 +176,13 @@ describe('Widget Space: Data API', () => {\n});\ndescribe('File Transfer Tests', () => {\n- it('sends message with pdf attachment', () => {\n- messageTests.sendFileTest(local, remote, 'pdf-sample.pdf');\n- });\n-\n- it('sends message with txt attachment', () => {\n- messageTests.sendFileTest(local, remote, 'txt-sample.txt');\n- });\n-\n- it('sends message with doc attachment', () => {\n- messageTests.sendFileTest(local, remote, 'doc-sample.doc');\n- });\n-\n- it('sends message with docx attachment', () => {\n- messageTests.sendFileTest(local, remote, 'docx-sample.docx');\n- });\n-\n- it('sends message with ppt attachment', () => {\n- messageTests.sendFileTest(local, remote, 'ppt-sample.ppt');\n- });\n-\n- it('sends message with html attachment', () => {\n- messageTests.sendFileTest(local, remote, 'html-sample.html');\n- });\n-\n- it('sends message with json attachment', () => {\n- messageTests.sendFileTest(local, remote, 'json-sample.json');\n- });\n-\n- it('sends message with zip attachment', () => {\n- messageTests.sendFileTest(local, remote, 'zip-sample.zip');\n- });\n-\n- it('sends message with gif attachment', () => {\n- messageTests.sendFileTest(local, remote, 'gif-sample.gif', false);\n- });\n-\n- it('sends message with jpg attachment', () => {\n- messageTests.sendFileTest(local, remote, 'jpg-sample.jpg', false);\n- });\n-\nit('sends message with png attachment', () => {\nmessageTests.sendFileTest(local, remote, 'png-sample.png');\n});\n- it('sends message with mp3 attachment', () => {\n- messageTests.sendFileTest(local, remote, 'mp3-sample.mp3');\n- });\n-\nit('verifies png-sample is in files tab', () => {\nmessageTests.filesTabTest(local, remote, 'png-sample.png');\n});\n-\n- it('verifies mp3-sample is in files tab', () => {\n- messageTests.filesTabTest(local, remote, 'mp3-sample.mp3', false);\n- });\n});\ndescribe('markdown messaging', () => {\n",
"new_path": "test/journeys/specs/space/dataApi/messaging.js",
"old_path": "test/journeys/specs/space/dataApi/messaging.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -178,61 +178,13 @@ describe('Widget Space', () => {\n});\ndescribe('File Transfer Tests', () => {\n- it('sends message with pdf attachment', () => {\n- messageTests.sendFileTest(local, remote, 'pdf-sample.pdf');\n- });\n-\n- it('sends message with txt attachment', () => {\n- messageTests.sendFileTest(local, remote, 'txt-sample.txt');\n- });\n-\n- it('sends message with doc attachment', () => {\n- messageTests.sendFileTest(local, remote, 'doc-sample.doc');\n- });\n-\n- it('sends message with docx attachment', () => {\n- messageTests.sendFileTest(local, remote, 'docx-sample.docx');\n- });\n-\n- it('sends message with ppt attachment', () => {\n- messageTests.sendFileTest(local, remote, 'ppt-sample.ppt');\n- });\n-\n- it('sends message with html attachment', () => {\n- messageTests.sendFileTest(local, remote, 'html-sample.html');\n- });\n-\n- it('sends message with json attachment', () => {\n- messageTests.sendFileTest(local, remote, 'json-sample.json');\n- });\n-\n- it('sends message with zip attachment', () => {\n- messageTests.sendFileTest(local, remote, 'zip-sample.zip');\n- });\n-\n- it('sends message with gif attachment', () => {\n- messageTests.sendFileTest(local, remote, 'gif-sample.gif', false);\n- });\n-\n- it('sends message with jpg attachment', () => {\n- messageTests.sendFileTest(local, remote, 'jpg-sample.jpg', false);\n- });\n-\nit('sends message with png attachment', () => {\nmessageTests.sendFileTest(local, remote, 'png-sample.png');\n});\n- it('sends message with mp3 attachment', () => {\n- messageTests.sendFileTest(local, remote, 'mp3-sample.mp3');\n- });\n-\nit('verifies png-sample is in files tab', () => {\nmessageTests.filesTabTest(local, remote, 'png-sample.png');\n});\n-\n- it('verifies mp3-sample is in files tab', () => {\n- messageTests.filesTabTest(local, remote, 'mp3-sample.mp3', false);\n- });\n});\ndescribe('markdown messaging', () => {\n",
"new_path": "test/journeys/specs/space/global/messaging.js",
"old_path": "test/journeys/specs/space/global/messaging.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -55,20 +55,8 @@ The \"oneOnOne\" test suite opens a space widget between two individuals. The test\n- accessibility\n- should have no accessibility violations\n- File Transfer Tests\n- - sends message with pdf attachment\n- - sends message with txt attachment\n- - sends message with doc attachment\n- - sends message with docx attachment\n- - sends message with ppt attachment\n- - sends message with html attachment\n- - sends message with json attachment\n- - sends message with zip attachment\n- - sends message with gif attachment\n- - sends message with jpg attachment\n- sends message with png attachment\n- - sends message with mp3 attachment\n- verifies png-sample is in files tab\n- - verifies mp3-sample is in files tab\n- markdown messaging\n- sends message with bold text\n- sends message with italic text\n@@ -140,20 +128,8 @@ The \"oneOnOne\" test suite opens a space widget between two individuals. The test\n- should be able to delete a message from self\n- should not be able to delete a message from others\n- File Transfer Tests\n- - sends message with pdf attachment\n- - sends message with txt attachment\n- - sends message with doc attachment\n- - sends message with docx attachment\n- - sends message with ppt attachment\n- - sends message with html attachment\n- - sends message with json attachment\n- - sends message with zip attachment\n- - sends message with gif attachment\n- - sends message with jpg attachment\n- sends message with png attachment\n- - sends message with mp3 attachment\n- verifies png-sample is in files tab\n- - verifies mp3-sample is in files tab\n- markdown messaging\n- sends message with bold text\n- sends message with italic text\n@@ -229,20 +205,8 @@ The \"space\" test suite opens a space widget to a group space and creates three t\n- should be able to delete a message from self\n- should not be able to delete a message from others\n- File Transfer Tests\n- - sends message with pdf attachment\n- - sends message with txt attachment\n- - sends message with doc attachment\n- - sends message with docx attachment\n- - sends message with ppt attachment\n- - sends message with html attachment\n- - sends message with json attachment\n- - sends message with zip attachment\n- - sends message with gif attachment\n- - sends message with jpg attachment\n- sends message with png attachment\n- - sends message with mp3 attachment\n- verifies png-sample is in files tab\n- - verifies mp3-sample is in files tab\n- markdown messaging\n- sends message with bold text\n- sends message with italic text\n@@ -302,20 +266,8 @@ The \"space\" test suite opens a space widget to a group space and creates three t\n- should be able to delete a message from self\n- should not be able to delete a message from others\n- File Transfer Tests\n- - sends message with pdf attachment\n- - sends message with txt attachment\n- - sends message with doc attachment\n- - sends message with docx attachment\n- - sends message with ppt attachment\n- - sends message with html attachment\n- - sends message with json attachment\n- - sends message with zip attachment\n- - sends message with gif attachment\n- - sends message with jpg attachment\n- sends message with png attachment\n- - sends message with mp3 attachment\n- verifies png-sample is in files tab\n- - verifies mp3-sample is in files tab\n- markdown messaging\n- sends message with bold text\n- sends message with italic text\n",
"new_path": "test/journeys/testplan.md",
"old_path": "test/journeys/testplan.md"
}
] | JavaScript | MIT License | webex/react-widgets | test(journeys): reduce amount of file transfer tests | 1 | test | journeys |
724,226 | 05.07.2018 14:50:07 | -32,400 | bf655f305296261b80f70cd0af1556dba1643ad0 | fix: setProps() throws an error if the property is the same reference | [
{
"change_type": "MODIFY",
"diff": "@@ -659,6 +659,19 @@ export default class Wrapper implements BaseWrapper {\n`is not defined on the component`\n)\n}\n+ if (\n+ typeof data[key] === 'object' &&\n+ data[key] !== null &&\n+ // $FlowIgnore : Problem with possibly null this.vm\n+ data[key] === this.vm[key]\n+ ) {\n+ throwError(\n+ `wrapper.setProps() called with the same object ` +\n+ `of the existing ${key} property. ` +\n+ `You must call wrapper.setProps() with a new object ` +\n+ `to trigger reactivity`\n+ )\n+ }\nif (this.vm && this.vm._props) {\nthis.vm._props[key] = data[key]\n",
"new_path": "packages/test-utils/src/wrapper.js",
"old_path": "packages/test-utils/src/wrapper.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -169,6 +169,36 @@ describeWithShallowAndMount('setProps', mountingMethod => {\nexpect(wrapper.vm.data).to.equal('1,2,3,4,5')\n})\n+ it('should same reference when called with same object', () => {\n+ const TestComponent = {\n+ template: `<div></div>`,\n+ props: ['obj']\n+ }\n+ const wrapper = mountingMethod(TestComponent)\n+ const obj = {}\n+ wrapper.setProps({ obj })\n+ expect(wrapper.props().obj).to.equal(obj)\n+ })\n+\n+ it('throws an error if property is same reference', () => {\n+ const TestComponent = {\n+ template: `<div></div>`,\n+ props: ['obj']\n+ }\n+ const obj = {}\n+ const wrapper = mountingMethod(TestComponent, {\n+ propsData: {\n+ obj\n+ }\n+ })\n+\n+ const message = '[vue-test-utils]: wrapper.setProps() called with the same object of the existing obj property. You must call wrapper.setProps() with a new object to trigger reactivity'\n+ const fn = () => wrapper.setProps({ obj })\n+ expect(fn)\n+ .to.throw()\n+ .with.property('message', message)\n+ })\n+\nit('throws an error if node is not a Vue instance', () => {\nconst message = 'wrapper.setProps() can only be called on a Vue instance'\nconst compiled = compileToFunctions('<div><p></p></div>')\n",
"new_path": "test/specs/wrapper/setProps.spec.js",
"old_path": "test/specs/wrapper/setProps.spec.js"
}
] | JavaScript | MIT License | vuejs/vue-test-utils | fix: setProps() throws an error if the property is the same reference (#791) | 1 | fix | null |
807,849 | 05.07.2018 15:38:41 | 25,200 | 13f07e72e4bf34dc3864dc97240e5779c6cf8fd1 | chore: unmock collect-updates in publish --cd-version tests | [
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"package-4\",\n- \"version\": \"1.0.0\",\n+ \"version\": \"1.0.1-beta.3\",\n\"dependencies\": {\n\"package-5\": \"^1.0.1-beta.3\"\n}\n",
"new_path": "commands/publish/__tests__/__fixtures__/republish-prereleased/packages/package-4/package.json",
"old_path": "commands/publish/__tests__/__fixtures__/republish-prereleased/packages/package-4/package.json"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"package-5\",\n+ \"version\": \"1.0.1-beta.3\",\n\"dependencies\": {\n\"package-1\": \"1.0.0\"\n- },\n- \"private\": true,\n- \"version\": \"1.0.1-beta.3\"\n+ }\n}\n",
"new_path": "commands/publish/__tests__/__fixtures__/republish-prereleased/packages/package-5/package.json",
"old_path": "commands/publish/__tests__/__fixtures__/republish-prereleased/packages/package-5/package.json"
},
{
"change_type": "MODIFY",
"diff": "// Jest Snapshot v1, https://goo.gl/fbAQLP\n-exports[`publish --cd-version with previous prerelease publishes changed & prereleased packages if --cd-version is non-prerelease 1`] = `\n-\"v1.0.1\n+exports[`publish --cd-version patch with previous prerelease also graduates prereleased 1`] = `\n+v1.0.1\nHEAD -> master, tag: v1.0.1\n@@ -10,59 +10,36 @@ index SHA..SHA 100644\n--- a/lerna.json\n+++ b/lerna.json\n-- \\\\\"version\\\\\": \\\\\"1.0.1-beta.3\\\\\"\n-+ \\\\\"version\\\\\": \\\\\"1.0.1\\\\\"\n-diff --git a/packages/package-1/package.json b/packages/package-1/package.json\n-index SHA..SHA 100644\n---- a/packages/package-1/package.json\n-+++ b/packages/package-1/package.json\n-@@ -3 +3 @@\n-- \\\\\"version\\\\\": \\\\\"1.0.0\\\\\"\n-+ \\\\\"version\\\\\": \\\\\"1.0.1\\\\\"\n-diff --git a/packages/package-2/package.json b/packages/package-2/package.json\n-index SHA..SHA 100644\n---- a/packages/package-2/package.json\n-+++ b/packages/package-2/package.json\n-@@ -3 +3 @@\n-- \\\\\"version\\\\\": \\\\\"1.0.0\\\\\",\n-+ \\\\\"version\\\\\": \\\\\"1.0.1\\\\\",\n-@@ -5 +5 @@\n-- \\\\\"package-1\\\\\": \\\\\"^1.0.0\\\\\"\n-+ \\\\\"package-1\\\\\": \\\\\"^1.0.1\\\\\"\n+- \"version\": \"1.0.1-beta.3\"\n++ \"version\": \"1.0.1\"\ndiff --git a/packages/package-3/package.json b/packages/package-3/package.json\nindex SHA..SHA 100644\n--- a/packages/package-3/package.json\n+++ b/packages/package-3/package.json\n-- \\\\\"version\\\\\": \\\\\"1.0.0\\\\\",\n-+ \\\\\"version\\\\\": \\\\\"1.0.1\\\\\",\n-@@ -5 +5 @@\n-- \\\\\"package-2\\\\\": \\\\\"^1.0.0\\\\\"\n-+ \\\\\"package-2\\\\\": \\\\\"^1.0.1\\\\\"\n+- \"version\": \"1.0.0\",\n++ \"version\": \"1.0.1\",\ndiff --git a/packages/package-4/package.json b/packages/package-4/package.json\nindex SHA..SHA 100644\n--- a/packages/package-4/package.json\n+++ b/packages/package-4/package.json\n-- \\\\\"version\\\\\": \\\\\"1.0.0\\\\\",\n-+ \\\\\"version\\\\\": \\\\\"1.0.1\\\\\",\n+- \"version\": \"1.0.1-beta.3\",\n++ \"version\": \"1.0.1\",\n-- \\\\\"package-5\\\\\": \\\\\"^1.0.1-beta.3\\\\\"\n-+ \\\\\"package-5\\\\\": \\\\\"^1.0.1\\\\\"\n+- \"package-5\": \"^1.0.1-beta.3\"\n++ \"package-5\": \"^1.0.1\"\ndiff --git a/packages/package-5/package.json b/packages/package-5/package.json\nindex SHA..SHA 100644\n--- a/packages/package-5/package.json\n+++ b/packages/package-5/package.json\n-@@ -4 +4 @@\n-- \\\\\"package-1\\\\\": \\\\\"1.0.0\\\\\"\n-+ \\\\\"package-1\\\\\": \\\\\"^1.0.1\\\\\"\n-@@ -7 +7 @@\n-- \\\\\"version\\\\\": \\\\\"1.0.1-beta.3\\\\\"\n-+ \\\\\"version\\\\\": \\\\\"1.0.1\\\\\"\"\n+@@ -3 +3 @@\n+- \"version\": \"1.0.1-beta.3\",\n++ \"version\": \"1.0.1\",\n`;\n-exports[`publish --cd-version with previous prerelease should not publish prereleased packages if --cd-version is a pre-* increment 1`] = `\n-\"v1.0.1-beta.4\n+exports[`publish --cd-version prerelease with previous prerelease bumps changed only 1`] = `\n+v1.0.1-beta.4\nHEAD -> master, tag: v1.0.1-beta.4\n@@ -71,53 +48,13 @@ index SHA..SHA 100644\n--- a/lerna.json\n+++ b/lerna.json\n-- \\\\\"version\\\\\": \\\\\"1.0.1-beta.3\\\\\"\n-+ \\\\\"version\\\\\": \\\\\"1.0.1-beta.4\\\\\"\n-diff --git a/packages/package-1/package.json b/packages/package-1/package.json\n-index SHA..SHA 100644\n---- a/packages/package-1/package.json\n-+++ b/packages/package-1/package.json\n-@@ -3 +3 @@\n-- \\\\\"version\\\\\": \\\\\"1.0.0\\\\\"\n-+ \\\\\"version\\\\\": \\\\\"1.0.1-beta.4\\\\\"\n-diff --git a/packages/package-2/package.json b/packages/package-2/package.json\n-index SHA..SHA 100644\n---- a/packages/package-2/package.json\n-+++ b/packages/package-2/package.json\n-@@ -3 +3 @@\n-- \\\\\"version\\\\\": \\\\\"1.0.0\\\\\",\n-+ \\\\\"version\\\\\": \\\\\"1.0.1-beta.4\\\\\",\n-@@ -5 +5 @@\n-- \\\\\"package-1\\\\\": \\\\\"^1.0.0\\\\\"\n-+ \\\\\"package-1\\\\\": \\\\\"^1.0.1-beta.4\\\\\"\n+- \"version\": \"1.0.1-beta.3\"\n++ \"version\": \"1.0.1-beta.4\"\ndiff --git a/packages/package-3/package.json b/packages/package-3/package.json\nindex SHA..SHA 100644\n--- a/packages/package-3/package.json\n+++ b/packages/package-3/package.json\n-- \\\\\"version\\\\\": \\\\\"1.0.0\\\\\",\n-+ \\\\\"version\\\\\": \\\\\"1.0.1-beta.4\\\\\",\n-@@ -5 +5 @@\n-- \\\\\"package-2\\\\\": \\\\\"^1.0.0\\\\\"\n-+ \\\\\"package-2\\\\\": \\\\\"^1.0.1-beta.4\\\\\"\n-diff --git a/packages/package-4/package.json b/packages/package-4/package.json\n-index SHA..SHA 100644\n---- a/packages/package-4/package.json\n-+++ b/packages/package-4/package.json\n-@@ -3 +3 @@\n-- \\\\\"version\\\\\": \\\\\"1.0.0\\\\\",\n-+ \\\\\"version\\\\\": \\\\\"1.0.1-beta.4\\\\\",\n-@@ -5 +5 @@\n-- \\\\\"package-5\\\\\": \\\\\"^1.0.1-beta.3\\\\\"\n-+ \\\\\"package-5\\\\\": \\\\\"^1.0.1-beta.4\\\\\"\n-diff --git a/packages/package-5/package.json b/packages/package-5/package.json\n-index SHA..SHA 100644\n---- a/packages/package-5/package.json\n-+++ b/packages/package-5/package.json\n-@@ -4 +4 @@\n-- \\\\\"package-1\\\\\": \\\\\"1.0.0\\\\\"\n-+ \\\\\"package-1\\\\\": \\\\\"^1.0.1-beta.4\\\\\"\n-@@ -7 +7 @@\n-- \\\\\"version\\\\\": \\\\\"1.0.1-beta.3\\\\\"\n-+ \\\\\"version\\\\\": \\\\\"1.0.1-beta.4\\\\\"\"\n+- \"version\": \"1.0.0\",\n++ \"version\": \"1.0.1-beta.4\",\n`;\n",
"new_path": "commands/publish/__tests__/__snapshots__/publish-cd-version-prerelease.test.js.snap",
"old_path": "commands/publish/__tests__/__snapshots__/publish-cd-version-prerelease.test.js.snap"
},
{
"change_type": "MODIFY",
"diff": "\"use strict\";\n+// we're actually testing integration with git\n+jest.unmock(\"@lerna/collect-updates\");\n+\n// local modules _must_ be explicitly mocked\njest.mock(\"../lib/git-push\");\njest.mock(\"../lib/is-behind-upstream\");\n@@ -7,12 +10,6 @@ jest.mock(\"../lib/is-behind-upstream\");\nconst fs = require(\"fs-extra\");\nconst path = require(\"path\");\n-// mocked modules\n-const collectUpdates = require(\"@lerna/collect-updates\");\n-\n-// certain tests need to use the real thing\n-const collectUpdatesActual = require.requireActual(\"@lerna/collect-updates\");\n-\n// helpers\nconst initFixture = require(\"@lerna-test/init-fixture\")(__dirname);\nconst showCommit = require(\"@lerna-test/show-commit\");\n@@ -26,7 +23,12 @@ const lernaPublish = require(\"@lerna-test/command-runner\")(require(\"../command\")\n// stabilize commit SHA\nexpect.addSnapshotSerializer(require(\"@lerna-test/serialize-git-sha\"));\n-describe(\"publish --cd-version with previous prerelease\", () => {\n+// remove quotes around strings\n+expect.addSnapshotSerializer({\n+ print: val => val,\n+ test: val => typeof val === \"string\",\n+});\n+\nconst setupChanges = async cwd => {\nawait gitTag(cwd, \"v1.0.0-beta.3\");\nawait fs.outputFile(path.join(cwd, \"packages/package-3/hello.js\"), \"world\");\n@@ -34,13 +36,12 @@ describe(\"publish --cd-version with previous prerelease\", () => {\nawait gitCommit(cwd, \"setup\");\n};\n- it(\"publishes changed & prereleased packages if --cd-version is non-prerelease\", async () => {\n+test(\"publish --cd-version patch with previous prerelease also graduates prereleased\", async () => {\nconst testDir = await initFixture(\"republish-prereleased\");\n// should republish 3, 4, and 5 because:\n// package 3 changed\n// package 5 has a prerelease version\n// package 4 depends on package 5\n- collectUpdates.mockImplementationOnce(collectUpdatesActual);\nawait setupChanges(testDir);\nawait lernaPublish(testDir)(\"--cd-version\", \"patch\");\n@@ -49,15 +50,13 @@ describe(\"publish --cd-version with previous prerelease\", () => {\nexpect(patch).toMatchSnapshot();\n});\n- it(\"should not publish prereleased packages if --cd-version is a pre-* increment\", async () => {\n+test(\"publish --cd-version prerelease with previous prerelease bumps changed only\", async () => {\nconst testDir = await initFixture(\"republish-prereleased\");\n// should republish only package 3, because only it changed\n- collectUpdates.mockImplementationOnce(collectUpdatesActual);\nawait setupChanges(testDir);\n- await lernaPublish(testDir)(\"--cd-version\", \"prerelease\", \"---preid\", \"beta\");\n+ await lernaPublish(testDir)(\"--cd-version\", \"prerelease\");\nconst patch = await showCommit(testDir);\nexpect(patch).toMatchSnapshot();\n});\n-});\n",
"new_path": "commands/publish/__tests__/publish-cd-version-prerelease.test.js",
"old_path": "commands/publish/__tests__/publish-cd-version-prerelease.test.js"
}
] | JavaScript | MIT License | lerna/lerna | chore: unmock collect-updates in publish --cd-version tests | 1 | chore | null |
807,849 | 05.07.2018 15:39:43 | 25,200 | 9ca246f5581c392cb969c002761ebdb5af87b9e3 | chore: Test differential --canary publish | [
{
"change_type": "MODIFY",
"diff": "@@ -99,6 +99,99 @@ Map {\n}\n`;\n+exports[`publish --canary differential internal 1`] = `\n+Map {\n+ \"package-3\" => Object {\n+ \"dependencies\": Object {\n+ \"package-2\": \"^1.0.0\",\n+ },\n+ \"description\": \"one local dependency, one direct dependent, one transitive dependency\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-3\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+ \"package-4\" => Object {\n+ \"dependencies\": Object {\n+ \"package-3\": ^1.1.0-alpha.SHA,\n+ },\n+ \"description\": \"one local dependency, one direct dependent, two transitive dependencies\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-4\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+ \"package-5\" => Object {\n+ \"dependencies\": Object {\n+ \"package-4\": ^1.1.0-alpha.SHA,\n+ },\n+ \"description\": \"one local dependency, no dependents, three transitive dependencies\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-5\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+}\n+`;\n+\n+exports[`publish --canary differential pendant 1`] = `\n+Map {\n+ \"package-5\" => Object {\n+ \"dependencies\": Object {\n+ \"package-4\": \"^1.0.0\",\n+ },\n+ \"description\": \"one local dependency, no dependents, three transitive dependencies\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-5\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+}\n+`;\n+\n+exports[`publish --canary differential source 1`] = `\n+Map {\n+ \"package-1\" => Object {\n+ \"description\": \"no local dependencies, four local dependents (three transitive)\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-1\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+ \"package-2\" => Object {\n+ \"dependencies\": Object {\n+ \"package-1\": ^1.1.0-alpha.SHA,\n+ },\n+ \"description\": \"one local dependency, one direct dependent, no transitive dependencies\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-2\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+ \"package-3\" => Object {\n+ \"dependencies\": Object {\n+ \"package-2\": ^1.1.0-alpha.SHA,\n+ },\n+ \"description\": \"one local dependency, one direct dependent, one transitive dependency\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-3\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+ \"package-4\" => Object {\n+ \"dependencies\": Object {\n+ \"package-3\": ^1.1.0-alpha.SHA,\n+ },\n+ \"description\": \"one local dependency, one direct dependent, two transitive dependencies\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-4\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+ \"package-5\" => Object {\n+ \"dependencies\": Object {\n+ \"package-4\": ^1.1.0-alpha.SHA,\n+ },\n+ \"description\": \"one local dependency, no dependents, three transitive dependencies\",\n+ \"gitHead\": GIT_HEAD,\n+ \"name\": \"package-5\",\n+ \"version\": 1.1.0-alpha.SHA,\n+ },\n+}\n+`;\n+\nexports[`publish --canary: npm published 1`] = `\nMap {\n\"package-1\" => \"canary\",\n",
"new_path": "commands/publish/__tests__/__snapshots__/publish-canary.test.js.snap",
"old_path": "commands/publish/__tests__/__snapshots__/publish-canary.test.js.snap"
},
{
"change_type": "MODIFY",
"diff": "\"use strict\";\n+// we're actually testing integration with git\n+jest.unmock(\"@lerna/collect-updates\");\n+\n// local modules _must_ be explicitly mocked\njest.mock(\"../lib/git-push\");\njest.mock(\"../lib/is-behind-upstream\");\n+const fs = require(\"fs-extra\");\n+const path = require(\"path\");\n+\n// mocked modules\nconst writePkg = require(\"write-pkg\");\nconst npmPublish = require(\"@lerna/npm-publish\");\n@@ -11,6 +17,9 @@ const gitPush = require(\"../lib/git-push\");\n// helpers\nconst initFixture = require(\"@lerna-test/init-fixture\")(__dirname);\n+const gitAdd = require(\"@lerna-test/git-add\");\n+const gitTag = require(\"@lerna-test/git-tag\");\n+const gitCommit = require(\"@lerna-test/git-commit\");\n// test command\nconst lernaPublish = require(\"@lerna-test/command-runner\")(require(\"../command\"));\n@@ -48,3 +57,41 @@ test(\"publish --canary --independent\", async () => {\nexpect(writePkg.registry).toMatchSnapshot(\"updated packages\");\nexpect(npmPublish.registry).toMatchSnapshot(\"npm published\");\n});\n+\n+describe(\"publish --canary differential\", () => {\n+ async function setupChanges(cwd, ...tuples) {\n+ await gitTag(cwd, \"v1.0.0\");\n+ await Promise.all(\n+ tuples.map(([filePath, content]) => fs.outputFile(path.join(cwd, filePath), content, \"utf8\"))\n+ );\n+ await gitAdd(cwd, \".\");\n+ await gitCommit(cwd, \"setup\");\n+ }\n+\n+ test(\"source\", async () => {\n+ const cwd = await initFixture(\"snake-graph\");\n+\n+ await setupChanges(cwd, [\"packages/package-1/all-your-base.js\", \"belong to us\"]);\n+ await lernaPublish(cwd)(\"--canary\");\n+\n+ expect(writePkg.registry).toMatchSnapshot();\n+ });\n+\n+ test(\"internal\", async () => {\n+ const cwd = await initFixture(\"snake-graph\");\n+\n+ await setupChanges(cwd, [\"packages/package-3/malcolm.js\", \"in the middle\"]);\n+ await lernaPublish(cwd)(\"--canary\");\n+\n+ expect(writePkg.registry).toMatchSnapshot();\n+ });\n+\n+ test(\"pendant\", async () => {\n+ const cwd = await initFixture(\"snake-graph\");\n+\n+ await setupChanges(cwd, [\"packages/package-5/celine-dion.js\", \"all by myself\"]);\n+ await lernaPublish(cwd)(\"--canary\");\n+\n+ expect(writePkg.registry).toMatchSnapshot();\n+ });\n+});\n",
"new_path": "commands/publish/__tests__/publish-canary.test.js",
"old_path": "commands/publish/__tests__/publish-canary.test.js"
}
] | JavaScript | MIT License | lerna/lerna | chore: Test differential --canary publish | 1 | chore | null |
730,424 | 05.07.2018 18:10:16 | 14,400 | cde50e4ed8fc829f86089d3aee496b72b5fc5c9b | fix(widget-space): update sdk version, fix firefox calling | [
{
"change_type": "MODIFY",
"diff": "\"homepage\": \"https://github.com/webex/react-ciscospark#readme\",\n\"main\": \"src/index.js\",\n\"dependencies\": {\n- \"@ciscospark/common\": \"1.31.1\",\n- \"@ciscospark/helper-html\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-conversation\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-encryption\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-feature\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-flag\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-mercury\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-metrics\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-presence\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-search\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-team\": \"1.31.1\",\n- \"@ciscospark/internal-plugin-user\": \"1.31.1\",\n- \"@ciscospark/plugin-authorization\": \"1.31.1\",\n- \"@ciscospark/plugin-logger\": \"1.31.1\",\n- \"@ciscospark/plugin-people\": \"1.31.1\",\n- \"@ciscospark/plugin-phone\": \"1.31.1\",\n- \"@ciscospark/spark-core\": \"1.31.1\",\n- \"@ciscospark/storage-adapter-local-forage\": \"1.31.1\",\n- \"@ciscospark/storage-adapter-local-storage\": \"1.31.1\",\n+ \"@ciscospark/common\": \"1.32.22\",\n+ \"@ciscospark/helper-html\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-conversation\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-encryption\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-feature\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-flag\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-mercury\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-metrics\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-presence\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-search\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-team\": \"1.32.22\",\n+ \"@ciscospark/internal-plugin-user\": \"1.32.22\",\n+ \"@ciscospark/plugin-authorization\": \"1.32.22\",\n+ \"@ciscospark/plugin-logger\": \"1.32.22\",\n+ \"@ciscospark/plugin-people\": \"1.32.22\",\n+ \"@ciscospark/plugin-phone\": \"1.32.22\",\n+ \"@ciscospark/spark-core\": \"1.32.22\",\n+ \"@ciscospark/storage-adapter-local-forage\": \"1.32.22\",\n+ \"@ciscospark/storage-adapter-local-storage\": \"1.32.22\",\n\"ampersand-events\": \"^2.0.2\",\n\"classnames\": \"^2.2.5\",\n\"core-decorators\": \"^0.20.0\",\n\"devDependencies\": {\n\"@ciscospark/eslint-config-base\": \"^0.6.1\",\n\"@ciscospark/eslint-config-react\": \"^0.6.1\",\n- \"@ciscospark/test-helper-appid\": \"1.31.1\",\n- \"@ciscospark/test-helper-file\": \"1.31.1\",\n- \"@ciscospark/test-helper-server\": \"1.31.1\",\n- \"@ciscospark/test-helper-test-users\": \"1.31.1\",\n+ \"@ciscospark/test-helper-appid\": \"1.32.22\",\n+ \"@ciscospark/test-helper-file\": \"1.32.22\",\n+ \"@ciscospark/test-helper-server\": \"1.32.22\",\n+ \"@ciscospark/test-helper-test-users\": \"1.32.22\",\n\"axe-core\": \"^2.3.1\",\n\"babel-cli\": \"^6.22.2\",\n\"babel-core\": \"^6.22.1\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "data-initial-activity=\"meet\"\ndata-toggle=\"ciscospark-space\"\ndata-access-token=\"<%= process.env.CISCOSPARK_ACCESS_TOKEN %>\"\n- data-to-person-email=\"nzang@cisco.com\"\n+ data-to-person-email=\"<%= process.env.TO_PERSON_EMAIL %>\"\n/>\n</div>\n</div>\n",
"new_path": "packages/node_modules/@ciscospark/widget-space/src/index.html",
"old_path": "packages/node_modules/@ciscospark/widget-space/src/index.html"
}
] | JavaScript | MIT License | webex/react-widgets | fix(widget-space): update sdk version, fix firefox calling | 1 | fix | widget-space |
730,412 | 05.07.2018 18:37:13 | 0 | a09f92dd345adb4f9387ae83849afcdc03d25807 | chore(release): 0.1.314 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.314\"></a>\n+## [0.1.314](https://github.com/webex/react-ciscospark/compare/v0.1.313...v0.1.314) (2018-07-05)\n+\n+\n+### Bug Fixes\n+\n+* **activity-system-message:** remove incorrect isRequired from props ([d9250c9](https://github.com/webex/react-ciscospark/commit/d9250c9))\n+* **day-separator:** add correct prop type ([58285ee](https://github.com/webex/react-ciscospark/commit/58285ee))\n+\n+\n+\n<a name=\"0.1.313\"></a>\n## [0.1.313](https://github.com/webex/react-ciscospark/compare/v0.1.312...v0.1.313) (2018-06-29)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.313\",\n+ \"version\": \"0.1.314\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.314 | 1 | chore | release |
217,922 | 05.07.2018 22:53:18 | -7,200 | 9ffd889e80c2a287ff58916e0f62c0194660ed39 | fix: fixed the alarms sidebar timer not ticking properly | [
{
"change_type": "MODIFY",
"diff": "@@ -3,7 +3,7 @@ import {AlarmService} from '../../../core/time/alarm.service';\nimport {Alarm} from '../../../core/time/alarm';\nimport {combineLatest, Observable} from 'rxjs';\nimport {EorzeanTimeService} from '../../../core/time/eorzean-time.service';\n-import {map} from 'rxjs/operators';\n+import {map, tap} from 'rxjs/operators';\nimport {UserService} from '../../../core/database/user.service';\n@Component({\n@@ -25,13 +25,11 @@ export class AlarmsSidebarComponent implements OnInit {\n}\nngOnInit() {\n- const user$ = this.userService.getUserData();\n- const alarmGroups$ = combineLatest(this.etime.getEorzeanTime(), user$)\n+ const alarmGroups$ = combineLatest(this.etime.getEorzeanTime(), this.userService.getUserData())\n.pipe(\n- map(data => {\n- const time = data[0];\n- const user = data[1];\n+ tap(([time, user]) => this.time = time),\n+ map(([time, user]) => {\nconst result = user.alarmGroups.map(group => {\nreturn {groupName: group.name, enabled: group.enabled, alarms: []};\n});\n",
"new_path": "src/app/modules/alarms-sidebar/alarms-sidebar/alarms-sidebar.component.ts",
"old_path": "src/app/modules/alarms-sidebar/alarms-sidebar/alarms-sidebar.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed the alarms sidebar timer not ticking properly | 1 | fix | null |
730,429 | 06.07.2018 10:24:45 | 14,400 | 703cad4641a82f23e7118194aea0f7ada9b39122 | test(journeys): search for user by email
Test users aren't getting cleaned up quickly
enough so we are getting tons of hits on our
test user name. | [
{
"change_type": "MODIFY",
"diff": "@@ -202,7 +202,7 @@ describe('Widget Space: Data API', () => {\n});\nit('searches and adds person to space', () => {\n- searchForPerson(browserLocal, biff.displayName, true);\n+ searchForPerson(browserLocal, biff.email, true, biff.displayName);\nbrowserLocal.waitForVisible(rosterElements.rosterList);\nbrowserLocal.waitUntil(() => browserLocal.getText(rosterElements.rosterList).includes(biff.displayName));\nbrowserLocal.waitUntil(() => browserLocal.getText(rosterElements.rosterTitle) === 'People (4)');\n",
"new_path": "test/journeys/specs/space/dataApi/basic.js",
"old_path": "test/journeys/specs/space/dataApi/basic.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -199,7 +199,7 @@ describe('Widget Space', () => {\nit('searches and adds person to space', () => {\nopenMenuAndClickButton(browserLocal, rosterElements.peopleButton);\nbrowserLocal.waitForVisible(rosterElements.rosterWidget);\n- searchForPerson(browserLocal, biff.displayName, true);\n+ searchForPerson(browserLocal, biff.email, true, biff.displayName);\nbrowserLocal.waitForVisible(rosterElements.rosterList);\nbrowserLocal.waitUntil(() => browserLocal.getText(rosterElements.rosterList).includes(biff.displayName));\nbrowserLocal.waitUntil(() => browserLocal.getText(rosterElements.rosterTitle) === 'People (4)');\n",
"new_path": "test/journeys/specs/space/global/basic.js",
"old_path": "test/journeys/specs/space/global/basic.js"
}
] | JavaScript | MIT License | webex/react-widgets | test(journeys): search for user by email
Test users aren't getting cleaned up quickly
enough so we are getting tons of hits on our
test user name. | 1 | test | journeys |
730,429 | 06.07.2018 10:34:51 | 14,400 | 5910629e4fca1df84b6dc13861a8513e3c8fbf71 | test(journeys): add support for multile roster results | [
{
"change_type": "MODIFY",
"diff": "@@ -68,7 +68,8 @@ export function searchForPerson(aBrowser, searchString, doAdd = false, searchRes\naBrowser.setValue(elements.searchInput, searchString);\naBrowser.waitForVisible(elements.addParticipantResultsArea);\naBrowser.waitForVisible(elements.addParticipantResultItem);\n- const resultsText = aBrowser.getText(elements.addParticipantResultItem);\n+ const element = aBrowser.element(elements.addParticipantResultItem);\n+ const resultsText = element.getText();\nassert.isTrue(resultsText.includes(searchResult), 'matching search result is not found in results');\nif (doAdd) {\naBrowser.click(elements.addParticipantResultItem);\n",
"new_path": "test/journeys/lib/test-helpers/space-widget/roster.js",
"old_path": "test/journeys/lib/test-helpers/space-widget/roster.js"
}
] | JavaScript | MIT License | webex/react-widgets | test(journeys): add support for multile roster results | 1 | test | journeys |
217,922 | 06.07.2018 11:21:40 | -7,200 | 2db9cec2c1fa9139b1bef2889617382428f1eb19 | feat: better performances with lazy loading panels for lists | [
{
"change_type": "MODIFY",
"diff": "<button mat-icon-button matTooltip=\"{{'LIST_DETAILS.Tags_popup' | translate}}\"\nmatTooltipPosition=\"above\"\n- (click)=\"$event.stopPropagation();openTagsPopup()\" *ngIf=\"list.authorId === userUid && !list.isCommissionList\">\n+ (click)=\"$event.stopPropagation();openTagsPopup()\"\n+ *ngIf=\"list.authorId === userUid && !list.isCommissionList\">\n<mat-icon>label_outline</mat-icon>\n</button>\n</div>\n</div>\n</mat-expansion-panel-header>\n- <mat-list *ngIf=\"expanded\">\n+ <ng-template matExpansionPanelContent>\n+ <mat-list>\n<div class=\"buttons mobile mat-elevation-z2\" mat-list-item *ngIf=\"isMobile()\">\n<app-comments-button *ngIf=\"list.public\" [name]=\"list.name\" [list]=\"list\"\n[isOwnList]=\"list.authorId === authorUid\"\n</app-recipe>\n</div>\n</mat-list>\n+ </ng-template>\n</mat-expansion-panel>\n",
"new_path": "src/app/modules/common-components/list-panel/list-panel.component.html",
"old_path": "src/app/modules/common-components/list-panel/list-panel.component.html"
},
{
"change_type": "MODIFY",
"diff": "<mat-icon>content_copy</mat-icon>\n</button>\n</mat-expansion-panel-header>\n+ <ng-template matExpansionPanelContent>\n<!--DEFAULT LIST-->\n<mat-list dense *ngIf=\"!showTier && !zoneBreakdown\">\n<div *ngFor=\"let row of data; trackBy: trackByFn; let i = index\">\n</div>\n</mat-list>\n</mat-list>\n+ </ng-template>\n</mat-expansion-panel>\n",
"new_path": "src/app/pages/list/list-details-panel/list-details-panel.component.html",
"old_path": "src/app/pages/list/list-details-panel/list-details-panel.component.html"
},
{
"change_type": "MODIFY",
"diff": "<div *ngFor=\"let displayRow of display; trackBy:displayTrackByFn\">\n<app-list-details-panel\n[user]=\"userData\"\n+ [expanded]=\"!listIsLarge\"\n*ngIf=\"displayRow.rows.length > 0 || !displayRow.hideIfEmpty\"\n[list]=\"listData\"\n(update)=\"update(listData)\"\n",
"new_path": "src/app/pages/list/list-details/list-details.component.html",
"old_path": "src/app/pages/list/list-details/list-details.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -87,6 +87,8 @@ export class ListDetailsComponent extends ComponentWithSubscriptions implements\noutdated = false;\n+ listIsLarge = false;\n+\naccordionState: { [index: string]: boolean } = {\n'Crystals': true,\n'Gathering': true,\n@@ -117,6 +119,10 @@ export class ListDetailsComponent extends ComponentWithSubscriptions implements\nthis.listDisplay = this.listData$\n.pipe(\nfilter(data => data !== null),\n+ tap(data => {\n+ console.log(data.isLarge());\n+ this.listIsLarge = data.isLarge();\n+ }),\nmergeMap(data => {\nreturn this.layoutService.getDisplay(data, this.selectedIndex);\n})\n",
"new_path": "src/app/pages/list/list-details/list-details.component.ts",
"old_path": "src/app/pages/list/list-details/list-details.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: better performances with lazy loading panels for lists | 1 | feat | null |
217,922 | 06.07.2018 16:52:23 | -7,200 | 47f67bc384174920c2fdc391c53396b375a06513 | chore: first elements for the team system
Added service, models and page for the first pass | [
{
"change_type": "MODIFY",
"diff": "<mat-icon matListIcon>person</mat-icon>\n<span matLine *ngIf=\"!settings.compactSidebar\">{{'Profile' | translate}}</span>\n</mat-list-item>\n+ <mat-list-item routerLink=\"/teams\" (click)=\"mobile ? sidenav.close() : null\"\n+ *ngIf=\"!(authState | async)?.isAnonymous\"\n+ matTooltipPosition=\"right\"\n+ matTooltip=\"{{'TEAMS.Title' | translate}}\"\n+ [matTooltipDisabled]=\"!settings.compactSidebar\">\n+ <mat-icon matListIcon>people_outline</mat-icon>\n+ <span matLine *ngIf=\"!settings.compactSidebar\">{{'TEAMS.Title' | translate}}</span>\n+ </mat-list-item>\n<mat-list-item routerLink=\"/custom-links\" (click)=\"mobile ? sidenav.close() : null\"\n*ngIf=\"customLinksEnabled\"\nmatTooltipPosition=\"right\"\n",
"new_path": "src/app/app.component.html",
"old_path": "src/app/app.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -66,6 +66,7 @@ import {SimulatorModule} from './pages/simulator/simulator.module';\nimport {NgDragDropModule} from 'ng-drag-drop';\nimport {IS_ELECTRON} from './core/tools/platform.service';\nimport {CommissionBoardModule} from './pages/commission-board/commission-board.module';\n+import {TeamModule} from './pages/team/team.module';\nexport function HttpLoaderFactory(http: HttpClient): TranslateHttpLoader {\nreturn new TranslateHttpLoader(http, 'assets/i18n/', '.json');\n@@ -160,6 +161,7 @@ export function HttpLoaderFactory(http: HttpClient): TranslateHttpLoader {\nTemplateModule,\nSimulatorModule,\nCommissionBoardModule,\n+ TeamModule,\n],\nbootstrap: [AppComponent]\n})\n",
"new_path": "src/app/app.module.ts",
"old_path": "src/app/app.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -8,6 +8,7 @@ import {FirestoreListStorage} from './storage/list/firestore-list-storage';\nimport {ListTemplateService} from './list-template/list-template.service';\nimport {CraftingRotationService} from './crafting-rotation.service';\nimport {CommissionService} from './commission/commission.service';\n+import {TeamService} from './team.service';\n@NgModule({\n@@ -22,6 +23,7 @@ import {CommissionService} from './commission/commission.service';\nListTemplateService,\nCraftingRotationService,\nCommissionService,\n+ TeamService,\n]\n})\nexport class DatabaseModule {\n",
"new_path": "src/app/core/database/database.module.ts",
"old_path": "src/app/core/database/database.module.ts"
},
{
"change_type": "ADD",
"diff": "+import {Injectable, NgZone} from '@angular/core';\n+import {FirestoreStorage} from './storage/firebase/firestore-storage';\n+import {Team} from '../../model/other/team';\n+import {NgSerializerService} from '@kaiu/ng-serializer';\n+import {AngularFirestore} from 'angularfire2/firestore';\n+import {PendingChangesService} from './pending-changes/pending-changes.service';\n+import {UserService} from './user.service';\n+import {Observable} from 'rxjs/index';\n+import {map, mergeMap} from 'rxjs/operators';\n+\n+@Injectable({\n+ providedIn: 'root'\n+})\n+export class TeamService extends FirestoreStorage<Team> {\n+\n+ constructor(protected firestore: AngularFirestore, protected serializer: NgSerializerService, protected zone: NgZone,\n+ protected pendingChangesService: PendingChangesService, private userService: UserService) {\n+ super(firestore, serializer, zone, pendingChangesService);\n+ }\n+\n+ public getUserTeams(): Observable<Team[]> {\n+ return this.userService.getUserData().pipe(\n+ mergeMap(user => {\n+ return this.firestore\n+ .collection(this.getBaseUri(), ref => ref.where(`members.${user.$key}`, '==', true))\n+ .snapshotChanges()\n+ .pipe(\n+ map(snaps => snaps.map(snap => {\n+ const data = snap.payload.doc.data();\n+ delete data.$key;\n+ return (<Team>{$key: snap.payload.doc.id, ...data})\n+ })),\n+ map(teams => this.serializer.deserialize<Team>(teams, [Team]))\n+ );\n+ })\n+ );\n+ }\n+\n+ protected getBaseUri(params?: any): string {\n+ return 'teams';\n+ }\n+\n+ protected getClass(): any {\n+ return Team;\n+ }\n+}\n",
"new_path": "src/app/core/database/team.service.ts",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import {DataModel} from '../../core/database/storage/data-model';\n+\n+export class Team extends DataModel {\n+\n+ name: string;\n+\n+ leader: string;\n+\n+ members: { [index: string]: boolean } = {};\n+}\n",
"new_path": "src/app/model/other/team.ts",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+<h2>{{'TEAMS.Title' | translate}}</h2>\n+<div *ngIf=\"teams$ | async as teams; else loading\">\n+ <mat-expansion-panel *ngFor=\"let team of teams\">\n+\n+ </mat-expansion-panel>\n+</div>\n+<ng-template #loading>\n+ <div class=\"loader-container\">\n+ <mat-spinner></mat-spinner>\n+ </div>\n+</ng-template>\n",
"new_path": "src/app/pages/team/team.component.html",
"old_path": null
},
{
"change_type": "ADD",
"diff": "",
"new_path": "src/app/pages/team/team.component.scss",
"old_path": "src/app/pages/team/team.component.scss"
},
{
"change_type": "ADD",
"diff": "+import {Component, OnInit} from '@angular/core';\n+import {TeamService} from '../../core/database/team.service';\n+import {Team} from '../../model/other/team';\n+import {Observable} from 'rxjs/index';\n+\n+@Component({\n+ selector: 'app-team',\n+ templateUrl: './team.component.html',\n+ styleUrls: ['./team.component.scss']\n+})\n+export class TeamComponent implements OnInit {\n+\n+ public teams$: Observable<Team[]>;\n+\n+ constructor(private teamService: TeamService) {\n+ this.teams$ = this.teamService.getUserTeams()\n+ }\n+\n+ ngOnInit() {\n+ }\n+\n+}\n",
"new_path": "src/app/pages/team/team.component.ts",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import {NgModule} from '@angular/core';\n+import {CommonModule} from '@angular/common';\n+import {TeamComponent} from './team.component';\n+import {RouterModule, Routes} from '@angular/router';\n+import {MatExpansionModule, MatProgressSpinnerModule} from '@angular/material';\n+import {TranslateModule} from '@ngx-translate/core';\n+import {CoreModule} from '../../core/core.module';\n+\n+const routing: Routes = [\n+ {\n+ path: 'teams',\n+ component: TeamComponent\n+ }\n+];\n+\n+@NgModule({\n+ imports: [\n+ CommonModule,\n+\n+ TranslateModule,\n+ CoreModule,\n+\n+ RouterModule.forChild(routing),\n+\n+ MatExpansionModule,\n+ MatProgressSpinnerModule,\n+ ],\n+ declarations: [TeamComponent]\n+})\n+export class TeamModule {\n+}\n",
"new_path": "src/app/pages/team/team.module.ts",
"old_path": null
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: first elements for the team system
Added service, models and page for the first pass | 1 | chore | null |
730,429 | 09.07.2018 10:57:02 | 14,400 | 3dc104a15bd861b072981ec61b402a19f133c81f | test(journeys): skip file transfer tests | [
{
"change_type": "MODIFY",
"diff": "@@ -111,7 +111,8 @@ describe('Widget Space: One on One: Data API', () => {\n});\n});\n- describe('File Transfer Tests', () => {\n+ // Skipped due to file transfer instability (2018-07-09)\n+ describe.skip('File Transfer Tests', () => {\nit('sends message with png attachment', () => {\nmessageTests.sendFileTest(local, remote, 'png-sample.png');\n});\n",
"new_path": "test/journeys/specs/oneOnOne/dataApi/messaging.js",
"old_path": "test/journeys/specs/oneOnOne/dataApi/messaging.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -175,7 +175,8 @@ describe('Widget Space: Data API', () => {\n});\n});\n- describe('File Transfer Tests', () => {\n+ // Skipped due to file transfer instability (2018-07-09)\n+ describe.skip('File Transfer Tests', () => {\nit('sends message with png attachment', () => {\nmessageTests.sendFileTest(local, remote, 'png-sample.png');\n});\n",
"new_path": "test/journeys/specs/space/dataApi/messaging.js",
"old_path": "test/journeys/specs/space/dataApi/messaging.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -177,7 +177,8 @@ describe('Widget Space', () => {\n});\n});\n- describe('File Transfer Tests', () => {\n+ // Skipped due to file transfer instability (2018-07-09)\n+ describe.skip('File Transfer Tests', () => {\nit('sends message with png attachment', () => {\nmessageTests.sendFileTest(local, remote, 'png-sample.png');\n});\n",
"new_path": "test/journeys/specs/space/global/messaging.js",
"old_path": "test/journeys/specs/space/global/messaging.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -127,7 +127,7 @@ The \"oneOnOne\" test suite opens a space widget between two individuals. The test\n- delete message\n- should be able to delete a message from self\n- should not be able to delete a message from others\n- - File Transfer Tests\n+ - File Transfer Tests (Skipped due to instability)\n- sends message with png attachment\n- verifies png-sample is in files tab\n- markdown messaging\n@@ -204,7 +204,7 @@ The \"space\" test suite opens a space widget to a group space and creates three t\n- delete message\n- should be able to delete a message from self\n- should not be able to delete a message from others\n- - File Transfer Tests\n+ - File Transfer Tests (Skipped due to instability)\n- sends message with png attachment\n- verifies png-sample is in files tab\n- markdown messaging\n@@ -265,7 +265,7 @@ The \"space\" test suite opens a space widget to a group space and creates three t\n- delete message\n- should be able to delete a message from self\n- should not be able to delete a message from others\n- - File Transfer Tests\n+ - File Transfer Tests (Skipped due to instability)\n- sends message with png attachment\n- verifies png-sample is in files tab\n- markdown messaging\n",
"new_path": "test/journeys/testplan.md",
"old_path": "test/journeys/testplan.md"
}
] | JavaScript | MIT License | webex/react-widgets | test(journeys): skip file transfer tests | 1 | test | journeys |
815,745 | 09.07.2018 11:14:33 | -10,800 | cbfd9483a92804b8c10dc8b293ba06b649117575 | fix: don't fire addEvent for single select | [
{
"change_type": "MODIFY",
"diff": "@@ -2355,7 +2355,7 @@ describe('NgSelectComponent', function () {\n});\ndescribe('Output events', () => {\n- it('fire open event once', fakeAsync(() => {\n+ it('should fire open event once', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectTestCmp,\n`<ng-select [items]=\"cities\"\n@@ -2372,7 +2372,7 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.onOpen).toHaveBeenCalledTimes(1);\n}));\n- it('fire close event once', fakeAsync(() => {\n+ it('should fire close event once', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectTestCmp,\n`<ng-select [items]=\"cities\"\n@@ -2390,7 +2390,7 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.onClose).toHaveBeenCalledTimes(1);\n}));\n- it('fire change when changed', fakeAsync(() => {\n+ it('should fire change when changed', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectTestCmp,\n`<ng-select [items]=\"cities\"\n@@ -2413,7 +2413,7 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.selectedCityId).toBe(fixture.componentInstance.cities[0].id);\n}));\n- it('do not fire change when item not changed', fakeAsync(() => {\n+ it('should not fire change when item not changed', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectTestCmp,\n`<ng-select [items]=\"cities\"\n@@ -2431,7 +2431,7 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.onChange).toHaveBeenCalledTimes(1);\n}));\n- it('fire add when item is added', fakeAsync(() => {\n+ it('should fire addEvent when item is added', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectTestCmp,\n`<ng-select [items]=\"cities\"\n@@ -2448,7 +2448,23 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.onAdd).toHaveBeenCalledWith(fixture.componentInstance.cities[0]);\n}));\n- it('fire remove when item is removed', fakeAsync(() => {\n+ it('should not fire addEvent for single select', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectTestCmp,\n+ `<ng-select [items]=\"cities\"\n+ (add)=\"onAdd($event)\"\n+ [multiple]=\"false\"\n+ [(ngModel)]=\"selectedCity\">\n+ </ng-select>`);\n+\n+ spyOn(fixture.componentInstance, 'onAdd');\n+\n+ tickAndDetectChanges(fixture);\n+ fixture.componentInstance.select.select(fixture.componentInstance.select.itemsList.items[0]);\n+ expect(fixture.componentInstance.onAdd).not.toHaveBeenCalled();\n+ }));\n+\n+ it('should fire remove when item is removed', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectTestCmp,\n`<ng-select [items]=\"cities\"\n@@ -2467,7 +2483,7 @@ describe('NgSelectComponent', function () {\nexpect(fixture.componentInstance.onRemove).toHaveBeenCalledWith(fixture.componentInstance.cities[0]);\n}));\n- it('fire clear when model is cleared using clear icon', fakeAsync(() => {\n+ it('should fire clear when model is cleared using clear icon', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectTestCmp,\n`<ng-select [items]=\"cities\"\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -373,12 +373,14 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nselect(item: NgOption) {\nthis.itemsList.select(item);\n-\nif (this.clearSearchOnAdd) {\nthis._clearSearch();\n}\n+ if (this.multiple) {\nthis.addEvent.emit(item.value);\n+ }\n+\nif (this.closeOnSelect || this.itemsList.noItemsToSelect) {\nthis.close();\n}\n@@ -633,12 +635,13 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\n}\n+ const selected = this.selectedItems.map(x => x.value);\nif (this.multiple) {\nthis._onChange(model);\n- this.changeEvent.emit(this.selectedItems.map(x => x.value));\n+ this.changeEvent.emit(selected);\n} else {\nthis._onChange(isDefined(model[0]) ? model[0] : null);\n- this.changeEvent.emit(this.selectedItems[0] && this.selectedItems[0].value);\n+ this.changeEvent.emit(selected[0]);\n}\nthis._cd.markForCheck();\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] | TypeScript | MIT License | ng-select/ng-select | fix: don't fire addEvent for single select | 1 | fix | null |
791,723 | 09.07.2018 12:34:59 | 25,200 | 3a43e893d6c7bb923735e6d8c82df51afde5d9e6 | docs: [minor] issue template tweaks | [
{
"change_type": "MODIFY",
"diff": "@@ -6,8 +6,6 @@ about: Report something working incorrectly\n<!-- Before creating an issue please make sure you are using the latest version and have checked for duplicate issues. -->\n-## Bug report\n-\n#### Provide the steps to reproduce\n1. Run LH on <affected url>\n",
"new_path": ".github/ISSUE_TEMPLATE/Bug_report.md",
"old_path": ".github/ISSUE_TEMPLATE/Bug_report.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -8,9 +8,7 @@ about: Suggest an idea to us!\n<!-- If this is a new audit please review the audit doc https://github.com/GoogleChrome/lighthouse/blob/master/docs/new-audits.md -->\n-## Feature request\n-\n-**Summary**\n+**Feature request summary**\n<!-- Describe what you want to be added -->\n<!-- Are you willing to work on this yourself? -->\n",
"new_path": ".github/ISSUE_TEMPLATE/Feature_request.md",
"old_path": ".github/ISSUE_TEMPLATE/Feature_request.md"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | docs: [minor] issue template tweaks (#5641) | 1 | docs | null |
791,690 | 09.07.2018 12:46:32 | 25,200 | 9c279a91201aaec8d3f1edbac650fc0c22cc58d8 | core(fonts): bump gatherer timeout to 5s | [
{
"change_type": "MODIFY",
"diff": "@@ -140,8 +140,8 @@ function getFontFaceFromStylesheets() {\noldNode.parentNode && oldNode.parentNode.insertBefore(newNode, oldNode);\noldNode.remove();\n- // Give each stylesheet 1s to load before giving up\n- setTimeout(() => resolve([{err: {message: 'Could not load stylesheet (timeout)'}}]), 1000);\n+ // Give each stylesheet 5s to load before giving up\n+ setTimeout(() => resolve([{err: {message: 'Could not load stylesheet (timeout)'}}]), 5000);\n});\n}\n",
"new_path": "lighthouse-core/gather/gatherers/fonts.js",
"old_path": "lighthouse-core/gather/gatherers/fonts.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(fonts): bump gatherer timeout to 5s (#5643) | 1 | core | fonts |
815,745 | 09.07.2018 13:06:55 | -10,800 | 8ed435c06902839fdc9bfaaec304a65b963a2a8c | fix: don't fire change event for same selection
fixes | [
{
"change_type": "MODIFY",
"diff": "@@ -2423,10 +2423,11 @@ describe('NgSelectComponent', function () {\nspyOn(fixture.componentInstance, 'onChange');\n- fixture.componentInstance.selectedCity = fixture.componentInstance.cities[0];\n- tickAndDetectChanges(fixture);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\n- fixture.componentInstance.select.select(fixture.componentInstance.cities[0]);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\nexpect(fixture.componentInstance.onChange).toHaveBeenCalledTimes(1);\n}));\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -372,6 +372,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\nselect(item: NgOption) {\n+ if (!item.selected) {\nthis.itemsList.select(item);\nif (this.clearSearchOnAdd) {\nthis._clearSearch();\n@@ -380,12 +381,12 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nif (this.multiple) {\nthis.addEvent.emit(item.value);\n}\n+ this._updateNgModel();\n+ }\nif (this.closeOnSelect || this.itemsList.noItemsToSelect) {\nthis.close();\n}\n-\n- this._updateNgModel();\n}\nfocus() {\n@@ -586,9 +587,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n};\nif (this.multiple) {\n- (<any[]>ngModel).forEach(item => {\n- select(item);\n- });\n+ (<any[]>ngModel).forEach(item => select(item));\n} else {\nselect(ngModel);\n}\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] | TypeScript | MIT License | ng-select/ng-select | fix: don't fire change event for same selection
fixes #664 | 1 | fix | null |
679,913 | 09.07.2018 15:12:46 | -3,600 | 8321660c9ef0b49f3c760e634bcb1a48b09f43fb | feat(examples): add rstream-hdom example | [
{
"change_type": "ADD",
"diff": "+node_modules\n+yarn.lock\n+*.js\n",
"new_path": "examples/rstream-hdom/.gitignore",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+# rstream-hdom\n+\n+[Live demo](http://demo.thi.ng/umbrella/rstream-hdom/)\n+\n+This example shows how\n+[@thi.ng/rstream](https://github.com/thi-ng/umbrella/tree/master/packages/rstream)\n+can be used to reactively trigger\n+[@thi.ng/hdom](https://github.com/thi-ng/umbrella/tree/master/packages/hdom)\n+updates only when the [central app state\n+atom](https://github.com/thi-ng/umbrella/tree/master/packages/atom/README.md#atom)\n+has changed.\n+\n+```\n+git clone https://github.com/thi-ng/umbrella.git\n+cd umbrella/examples/rstream-hdom\n+yarn install\n+yarn start\n+```\n+\n+## Authors\n+\n+- Karsten Schmidt\n+\n+## License\n+\n+© 2018 Karsten Schmidt // Apache Software License 2.0\n",
"new_path": "examples/rstream-hdom/README.md",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+{\n+ \"name\": \"rstream-hdom\",\n+ \"version\": \"0.0.1\",\n+ \"repository\": \"https://github.com/thi-ng/umbrella\",\n+ \"author\": \"Karsten Schmidt <k+npm@thi.ng>\",\n+ \"license\": \"Apache-2.0\",\n+ \"scripts\": {\n+ \"build\": \"webpack --mode production --display-reasons --display-modules\",\n+ \"start\": \"webpack-dev-server --open --mode development --devtool inline-source-map\"\n+ },\n+ \"devDependencies\": {\n+ \"ts-loader\": \"^4.3.0\",\n+ \"typescript\": \"^2.8.3\",\n+ \"webpack\": \"^4.8.1\",\n+ \"webpack-cli\": \"^2.1.3\",\n+ \"webpack-dev-server\": \"^3.1.4\"\n+ },\n+ \"dependencies\": {\n+ \"@thi.ng/api\": \"latest\",\n+ \"@thi.ng/hdom\": \"latest\",\n+ \"@thi.ng/rstream\": \"latest\",\n+ \"@thi.ng/transducers\": \"latest\"\n+ }\n+}\n\\ No newline at end of file\n",
"new_path": "examples/rstream-hdom/package.json",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import { Atom } from \"@thi.ng/atom\";\n+import { diffElement, normalizeTree } from \"@thi.ng/hdom\";\n+import { fromRAF, fromView, sidechainPartition } from \"@thi.ng/rstream\";\n+import { reducer, scan } from \"@thi.ng/transducers\";\n+\n+/**\n+ * Reactively triggers DOM update whenever state atom embedded in given\n+ * user context object has value changes (the context object is assumed\n+ * to have a `state` key holding the atom). Additionally, a RAF side\n+ * chain stream is used to synchronize DOM updates to be processed\n+ * during RAF.\n+ *\n+ * Returns stream of hdom trees.\n+ *\n+ * @param parent root DOM element\n+ * @param root root hdom component\n+ * @param ctx user context object\n+ */\n+const domUpdate = (parent, root, ctx) => {\n+ return fromView(ctx.state, \"\")\n+ // use RAF stream as side chain trigger to\n+ // force DOM updates to execute during RAF\n+ .subscribe(sidechainPartition(fromRAF()))\n+ // transform atom value changes using transducers\n+ .transform(\n+ scan<any, any>(\n+ reducer(\n+ () => [],\n+ (prev, curr) => {\n+ curr = normalizeTree(root, ctx);\n+ diffElement(parent, prev, curr);\n+ return curr;\n+ }\n+ )\n+ )\n+ );\n+};\n+\n+/**\n+ * Generic button\n+ * @param ctx hdom user context\n+ * @param onclick event handler\n+ * @param body button body\n+ */\n+const button = (ctx, onclick, body) =>\n+ [\"button\", { ...ctx.ui.button, onclick }, body];\n+\n+/**\n+ * Specialized button for counters.\n+ *\n+ * @param ctx hdom user context\n+ * @param idx index in `clicks` array\n+ * @param val current click val\n+ */\n+const clickButton = (ctx, idx, val) =>\n+ [button, () => ctx.state.swapIn([\"clicks\", idx], (n: number) => n + 1), `clicks: ${val}`];\n+\n+/**\n+ * Root component function\n+ *\n+ * @param ctx\n+ */\n+const root = (ctx) =>\n+ [\"div\",\n+ ctx.state.deref().clicks.map((x, i) => [clickButton, i, x]),\n+ [button, () => ctx.state.resetIn(\"clicks\", [0, 0, 0]), \"reset\"]\n+ ];\n+\n+// example user context w/ embedded app state atom\n+const ctx = {\n+ state: new Atom({ clicks: [0, 0, 0] }),\n+ ui: {\n+ button: {\n+ style: {\n+ background: \"yellow\",\n+ margin: \"0.5rem\",\n+ padding: \"0.5rem\"\n+ }\n+ }\n+ }\n+};\n+\n+// start app\n+domUpdate(document.getElementById(\"app\"), root, ctx)\n+ // attach debug subscription\n+ .subscribe({ next(tree) { console.log(\"DOM updated\", tree); } });\n",
"new_path": "examples/rstream-hdom/src/index.ts",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+{\n+ \"extends\": \"../../tsconfig.json\",\n+ \"compilerOptions\": {\n+ \"outDir\": \".\"\n+ },\n+ \"include\": [\n+ \"./src/**/*.ts\"\n+ ]\n+}\n",
"new_path": "examples/rstream-hdom/tsconfig.json",
"old_path": null
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | feat(examples): add rstream-hdom example | 1 | feat | examples |
679,905 | 09.07.2018 15:47:48 | -7,200 | 7f2d5dd294d00947125c78a213c0f8899ae1e01f | fix(rstream): Fix potential reference error in transduce() | [
{
"change_type": "MODIFY",
"diff": "-import { Reducer, Transducer } from \"@thi.ng/transducers/api\";\n+import { Subscription } from '@thi.ng/rstream';\n+import { Reducer, Transducer } from '@thi.ng/transducers';\nimport { isReduced } from \"@thi.ng/transducers/reduced\";\n-import { Subscription } from \"../subscription\";\n-\nexport function transduce<A, B, C>(src: Subscription<any, A>, tx: Transducer<A, B>, rfn: Reducer<C, B>, init?: C): Promise<C> {\nlet acc = init !== undefined ? init : rfn[0]();\n- return new Promise((resolve, reject) => {\n- const sub = src.subscribe({\n+ let sub: Subscription<A, B>;\n+\n+ return new Promise<C>((resolve, reject) => {\n+ sub = src.subscribe({\nnext(x) {\nconst _acc = rfn[2](acc, x);\nif (isReduced(_acc)) {\n- sub.unsubscribe();\nresolve(_acc.deref());\n} else {\nacc = _acc;\n}\n},\ndone() {\n- sub.unsubscribe();\nresolve(acc);\n},\nerror(e) {\nreject(e);\n}\n}, tx);\n- });\n+ }).then(\n+ fulfilled => { sub.unsubscribe(); return fulfilled },\n+ rejected => { sub.unsubscribe(); throw rejected }\n+ );\n}\n",
"new_path": "packages/rstream/src/subs/transduce.ts",
"old_path": "packages/rstream/src/subs/transduce.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | fix(rstream): Fix potential reference error in transduce() | 1 | fix | rstream |
730,412 | 09.07.2018 16:31:11 | 0 | b6d2a02ba071056dd5e5a3de659f45b15a7e90d6 | chore(release): 0.1.315 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.315\"></a>\n+## [0.1.315](https://github.com/webex/react-ciscospark/compare/v0.1.314...v0.1.315) (2018-07-09)\n+\n+\n+### Features\n+\n+* **module-conversation:** add reset conversation action ([e1ab8b9](https://github.com/webex/react-ciscospark/commit/e1ab8b9))\n+* **module-errors:** add reset errors action ([09d3bfb](https://github.com/webex/react-ciscospark/commit/09d3bfb))\n+* **redux-module-users:** export immutable records for testing ([2421332](https://github.com/webex/react-ciscospark/commit/2421332))\n+* **widget-demo:** use react component for space widget ([cb10fc2](https://github.com/webex/react-ciscospark/commit/cb10fc2))\n+* **widget-message:** reset widget on destination change ([78e26bc](https://github.com/webex/react-ciscospark/commit/78e26bc))\n+* **widget-space:** reload widget on destination change ([188d6f6](https://github.com/webex/react-ciscospark/commit/188d6f6))\n+\n+\n+\n<a name=\"0.1.314\"></a>\n## [0.1.314](https://github.com/webex/react-ciscospark/compare/v0.1.313...v0.1.314) (2018-07-05)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.314\",\n+ \"version\": \"0.1.315\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.315 | 1 | chore | release |
679,913 | 09.07.2018 17:53:53 | -3,600 | 5ec614068be198c55ecefeac41bf1572a06a042e | build(examples): add missing html/webpack config for rstream-hdom demo | [
{
"change_type": "ADD",
"diff": "+<!DOCTYPE html>\n+<html lang=\"en\">\n+\n+<head>\n+ <meta charset=\"UTF-8\">\n+ <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">\n+ <meta http-equiv=\"X-UA-Compatible\" content=\"ie=edge\">\n+ <title>rstream-hdom</title>\n+ <!-- <link href=\"https://unpkg.com/tachyons@4.9.1/css/tachyons.min.css\" rel=\"stylesheet\"> -->\n+ <style>\n+ </style>\n+</head>\n+\n+<body>\n+ <div id=\"app\"></div>\n+ <script type=\"text/javascript\" src=\"bundle.js\"></script>\n+</body>\n+\n+</html>\n\\ No newline at end of file\n",
"new_path": "examples/rstream-hdom/index.html",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+module.exports = {\n+ entry: \"./src/index.ts\",\n+ output: {\n+ path: __dirname,\n+ filename: \"bundle.js\"\n+ },\n+ resolve: {\n+ extensions: [\".ts\", \".js\"]\n+ },\n+ module: {\n+ rules: [\n+ { test: /\\.ts$/, use: \"ts-loader\" }\n+ ]\n+ },\n+ devServer: {\n+ contentBase: \".\"\n+ }\n+};\n",
"new_path": "examples/rstream-hdom/webpack.config.js",
"old_path": null
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | build(examples): add missing html/webpack config for rstream-hdom demo | 1 | build | examples |
679,913 | 09.07.2018 18:46:09 | -3,600 | 03543ee96e500189ac8581105f1f0557d1a38ece | fix(transducers): revert mean() from regression introduced in | [
{
"change_type": "MODIFY",
"diff": "import { Reducer } from \"../api\";\n-import { reducer } from \"../reduce\";\nexport function mean(): Reducer<number, number> {\nlet n = 0;\n- return reducer(() => 0, (acc, x) => (n++ , acc + x));\n+ return [\n+ () => 0,\n+ (acc) => acc / n,\n+ (acc, x) => (n++ , acc + x),\n+ ];\n}\n",
"new_path": "packages/transducers/src/rfn/mean.ts",
"old_path": "packages/transducers/src/rfn/mean.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | fix(transducers): revert mean() from regression introduced in 095e6ef | 1 | fix | transducers |
730,412 | 09.07.2018 20:01:52 | 0 | aa779300282b71425bdf331c036454730bd9b74f | chore(release): 0.1.316 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.316\"></a>\n+## [0.1.316](https://github.com/webex/react-ciscospark/compare/v0.1.315...v0.1.316) (2018-07-09)\n+\n+\n+### Bug Fixes\n+\n+* **widget-space:** update sdk version, fix firefox calling ([cde50e4](https://github.com/webex/react-ciscospark/commit/cde50e4))\n+\n+\n+\n<a name=\"0.1.315\"></a>\n## [0.1.315](https://github.com/webex/react-ciscospark/compare/v0.1.314...v0.1.315) (2018-07-09)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.315\",\n+ \"version\": \"0.1.316\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.316 | 1 | chore | release |
679,913 | 09.07.2018 21:41:33 | -3,600 | fcfd4bf8234505e8806582d5726b9fba551ce385 | docs(hiccup-css): fix add pseudo-class & attrib selector docs | [
{
"change_type": "MODIFY",
"diff": "This project is part of the\n[@thi.ng/umbrella](https://github.com/thi-ng/umbrella/) monorepo.\n+<!-- TOC -->\n+\n+- [@thi.ng/hiccup-css](#thinghiccup-css)\n+ - [About](#about)\n+ - [Features](#features)\n+ - [Use cases](#use-cases)\n+ - [Installation](#installation)\n+ - [Dependencies](#dependencies)\n+ - [API & usage examples](#api--usage-examples)\n+ - [`css(rules: any, opts?: CSSOpts)`](#cssrules-any-opts-cssopts)\n+ - [Property formatting only](#property-formatting-only)\n+ - [Basic selectors](#basic-selectors)\n+ - [Property object merging & re-use](#property-object-merging--re-use)\n+ - [Iterators & CSS class scoping](#iterators--css-class-scoping)\n+ - [Nested selectors](#nested-selectors)\n+ - [Pseudo-classes](#pseudo-classes)\n+ - [Attribute selectors](#attribute-selectors)\n+ - [Auto-prefixed properties](#auto-prefixed-properties)\n+ - [Media queries](#media-queries)\n+ - [Keyframes](#keyframes)\n+ - [DOM stylesheet injection](#dom-stylesheet-injection)\n+ - [General function handling](#general-function-handling)\n+ - [Functions in scope head position](#functions-in-scope-head-position)\n+ - [Functions in other positions](#functions-in-other-positions)\n+ - [Quoted functions](#quoted-functions)\n+ - [Future plans](#future-plans)\n+ - [Authors](#authors)\n+ - [License](#license)\n+\n+<!-- /TOC -->\n+\n## About\nFollowing a similar pattern as the\n@@ -258,6 +289,38 @@ header, footer {\n}\n```\n+### Pseudo-classes\n+\n+Pseudo-classes follow the same pattern as other nested selectors shown above:\n+\n+```ts\n+css.css(\n+ [\"p\", [\"a\", [\":link\", {color: \"red\"}], [\":visited\", {border: 0}]]],\n+ { format: css.PRETTY }\n+);\n+```\n+\n+```css\n+p a:link {\n+ color:red;\n+}\n+\n+p a:visited {\n+ border: 0;\n+}\n+```\n+\n+### Attribute selectors\n+\n+| hiccup-css selector function | CSS |\n+|----------------------------------------|-----------|\n+| `withAttrib(id)` | `[id]` |\n+| `attribEq(id, x, caseSensitve?)` | `[id=x]` |\n+| `attribContains(id, x, caseSensitve?)` | `[id~=x]` |\n+| `attribPrefix(id, x, caseSensitve?)` | `[id^=x]` |\n+| `attribSuffix(id, x, caseSensitve?)` | `[id$=x]` |\n+| `attribMatches(id, x, caseSensitve?)` | `[id*=x]` |\n+\n### Auto-prefixed properties\n(Currently, only prefixed properties are supported. Auto-prefixing based\n",
"new_path": "packages/hiccup-css/README.md",
"old_path": "packages/hiccup-css/README.md"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | docs(hiccup-css): fix #26, add pseudo-class & attrib selector docs | 1 | docs | hiccup-css |
815,745 | 10.07.2018 10:13:26 | -10,800 | 584c17f4196e77c033f039c21425f2e478d9feac | chore(release): 2.3.3 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"2.3.3\"></a>\n+## [2.3.3](https://github.com/ng-select/ng-select/compare/v2.3.2...v2.3.3) (2018-07-10)\n+\n+\n+### Bug Fixes\n+\n+* don't fire addEvent for single select ([cbfd948](https://github.com/ng-select/ng-select/commit/cbfd948))\n+* don't fire change event for same selection ([8ed435c](https://github.com/ng-select/ng-select/commit/8ed435c)), closes [#664](https://github.com/ng-select/ng-select/issues/664)\n+\n+\n+\n<a name=\"2.3.2\"></a>\n## [2.3.2](https://github.com/ng-select/ng-select/compare/v2.3.1...v2.3.2) (2018-06-27)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"$schema\": \"../node_modules/ng-packagr/package.schema.json\",\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"2.3.2\",\n+ \"version\": \"2.3.3\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] | TypeScript | MIT License | ng-select/ng-select | chore(release): 2.3.3 | 1 | chore | release |
679,913 | 10.07.2018 14:43:42 | -3,600 | 126103b33059ac4246c84bb949d7c4629c138632 | fix(hdom): always update "value" attrib last in diffAttributes()
fixes issue when patching <input type=range> elements
with changed min/max limits | [
{
"change_type": "MODIFY",
"diff": "@@ -15,6 +15,8 @@ const isString = iss.isString;\nconst diffArray = diff.diffArray;\nconst diffObject = diff.diffObject;\n+const SEMAPHORE = Symbol(\"SEMAPHORE\");\n+\n/**\n* Takes a DOM root element and two hiccup trees, `prev` and `curr`.\n* Recursively computes diff between both trees and applies any\n@@ -128,17 +130,29 @@ function diffAttributes(el: Element, prev: any, curr: any) {\nlet i, e, edits;\nconst delta = diffObject(prev, curr);\nremoveAttribs(el, delta.dels, prev);\n+ let value = SEMAPHORE;\nfor (edits = delta.edits, i = edits.length; --i >= 0;) {\ne = edits[i];\nconst a = e[0];\nif (a.indexOf(\"on\") === 0) {\nel.removeEventListener(a.substr(2), prev[a]);\n}\n+ if (a !== \"value\") {\nsetAttrib(el, a, e[1], curr);\n+ } else {\n+ value = e[1];\n+ }\n}\nfor (edits = delta.adds, i = edits.length; --i >= 0;) {\ne = edits[i];\n+ if (e !== \"value\") {\nsetAttrib(el, e, curr[e], curr);\n+ } else {\n+ value = curr[e];\n+ }\n+ }\n+ if (value !== SEMAPHORE) {\n+ setAttrib(el, \"value\", value, curr);\n}\n}\n",
"new_path": "packages/hdom/src/diff.ts",
"old_path": "packages/hdom/src/diff.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | fix(hdom): always update "value" attrib last in diffAttributes()
- fixes issue when patching <input type=range> elements
with changed min/max limits | 1 | fix | hdom |
730,429 | 10.07.2018 15:25:32 | 14,400 | 4e985b8475e22a3b71a7766cf21c80308e9af1e7 | chore(tooling): use webpack env command line feature | [
{
"change_type": "MODIFY",
"diff": "@@ -71,7 +71,7 @@ function webpackBuild(pkgName, pkgPath) {\nconsole.info(`Cleaning ${pkgName} dist folder...`.cyan);\nrimraf.sync(path.resolve(targetPkgPath, 'dist'));\nconsole.info(`Bundling ${pkgName}...`.cyan);\n- execSync(`cd ${targetPkgPath} && webpack --config ${webpackConfigPath}`);\n+ execSync(`cd ${targetPkgPath} && webpack --config ${webpackConfigPath} --env.package=${pkgName}`);\nconsole.info(`${pkgName}... Done\\n\\n`.cyan);\n}\ncatch (err) {\n",
"new_path": "scripts/utils/build.js",
"old_path": "scripts/utils/build.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -158,7 +158,7 @@ function getWidgetPackages() {\n*/\nfunction startPackage(pkgName, pkgPath) {\nreturn runInPackage({\n- constructCommand: (targetPath) => `webpack-dev-server --config scripts/webpack/webpack.dev.babel.js --hot --inline --history-api-fallback --context ${path.resolve(targetPath, 'src')}`,\n+ constructCommand: (targetPath) => `webpack-dev-server --config scripts/webpack/webpack.dev.babel.js --hot --inline --history-api-fallback --context ${path.resolve(targetPath, 'src')} --env.package=${pkgName}`,\ncommandName: 'Start Package',\npkgName,\npkgPath\n",
"new_path": "scripts/utils/package.js",
"old_path": "scripts/utils/package.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -10,7 +10,7 @@ dotenv.config();\nprocess.env.REACT_CISCOSPARK_VERSION = version;\n-export default (options) => {\n+export default (options, env) => {\nconst packageJson = require('../../package.json');\nconst plugins = [\nnew webpack.EnvironmentPlugin([\n@@ -80,7 +80,7 @@ export default (options) => {\noptions: {\ncamelCase: true,\nmodules: true,\n- localIdentName: '[local]--[hash:base64:5]',\n+ localIdentName: `${env && env.package ? env.package : 'widget'}--[local]--[hash:base64:5]`,\nimportLoaders: 1,\nsourceMap: true\n}\n",
"new_path": "scripts/webpack/webpack.base.babel.js",
"old_path": "scripts/webpack/webpack.base.babel.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -26,7 +26,8 @@ const plugins = [\n])\n];\n-export default webpackConfigBase({\n+// env config object from command line: https://webpack.js.org/guides/environment-variables/\n+export default (env) => webpackConfigBase({\nentry: './index.js',\nplugins,\ndevtool: 'source-map',\n@@ -53,4 +54,4 @@ export default webpackConfigBase({\n'Content-Security-Policy': 'script-src \\'self\\' \\'unsafe-inline\\' code.s4d.io; style-src \\'self\\' \\'unsafe-inline\\' code.s4d.io; media-src \\'self\\' code.s4d.io *.clouddrive.com data: blob:; font-src \\'self\\' code.s4d.io; img-src \\'self\\' code.s4d.io *.clouddrive.com data: blob: *.rackcdn.com; connect-src \\'self\\' localhost ws://localhost:8000 wss://*.wbx.com wss://*.wbx2.com ws://*.wbx.com *.wbx2.com *.webex.com code.s4d.io *.ciscospark.com https://*.clouddrive.com/;'\n}\n}\n-});\n+}, env);\n",
"new_path": "scripts/webpack/webpack.dev.babel.js",
"old_path": "scripts/webpack/webpack.dev.babel.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -53,7 +53,8 @@ if (fs.existsSync('./src/index.html')) {\nconst publicPath = process.env.BUILD_PUBLIC_PATH;\n-export default webpackBaseConfig({\n+// env config object from command line: https://webpack.js.org/guides/environment-variables/\n+export default (env) => webpackBaseConfig({\nentry: './index.js',\noutput: {\nfilename: 'bundle.js',\n@@ -70,4 +71,4 @@ export default webpackBaseConfig({\nTO_PERSON_EMAIL: '',\nTO_PERSON_ID: ''\n}\n-});\n+}, env);\n",
"new_path": "scripts/webpack/webpack.prod.babel.js",
"old_path": "scripts/webpack/webpack.prod.babel.js"
}
] | JavaScript | MIT License | webex/react-widgets | chore(tooling): use webpack env command line feature | 1 | chore | tooling |
730,412 | 10.07.2018 20:24:39 | 0 | 2b222ff13b5ff76ff0753bb88e37fd3323f5716b | chore(release): 0.1.317 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.317\"></a>\n+## [0.1.317](https://github.com/webex/react-ciscospark/compare/v0.1.316...v0.1.317) (2018-07-10)\n+\n+\n+### Features\n+\n+* **webex-loading:** create new loading screen component ([1363c97](https://github.com/webex/react-ciscospark/commit/1363c97))\n+\n+\n+\n<a name=\"0.1.316\"></a>\n## [0.1.316](https://github.com/webex/react-ciscospark/compare/v0.1.315...v0.1.316) (2018-07-09)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.316\",\n+ \"version\": \"0.1.317\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.317 | 1 | chore | release |
679,913 | 11.07.2018 11:07:08 | -3,600 | ef16134174fbcf867787bbc1911dbbeb88b59c50 | docs(sax): add tests & DOM parsing example to readme | [
{
"change_type": "MODIFY",
"diff": "@@ -20,6 +20,10 @@ composed with other pre or post-processing steps, e.g. to filter or\ntransform element / attribute values or only do partial parsing with\nearly termination based on some condition.\n+Additionally, since by default the parser emits any children as part of\n+\"element end\" events, it can be used like a tree-walking DOM parser as\n+well (see SVG parsing example further below). The choice is yours!\n+\n## Installation\n```\n@@ -92,7 +96,9 @@ As mentioned earlier, the transducer nature of this parser allows for\nits easy integration into larger transformation pipelines. The next\nexample parses an SVG file, then extracts and selectively applies\ntransformations to only the `<circle>` elements in the first group\n-(`<g>`) element.\n+(`<g>`) element. Btw. The transformed elements can be serialized back\n+into SVG syntax using\n+[@thi.ng/hiccup-svg](https://github.com/thi-ng/umbrella/tree/master/packages/hiccup-svg)...\nGiven the composed transducer below, parsing stops immediately after the\nfirst `<g>` element is complete. This is because the `matchFirst()`\n@@ -128,18 +134,101 @@ svg=`\n// transform attributes\ntx.map((e)=> [e.tag, {\n...e.attribs,\n- cx: parseFloat(e.attribs.cy),\n+ cx: parseFloat(e.attribs.cx),\ncy: parseFloat(e.attribs.cy),\nr: parseFloat(e.attribs.r),\n}])\n),\nsvg\n)]\n-// [ [ 'circle', { cx: 150, cy: 150, r: 50 } ],\n-// [ 'circle', { cx: 150, cy: 150, r: 50 } ],\n+// [ [ 'circle', { cx: 50, cy: 150, r: 50 } ],\n+// [ 'circle', { cx: 250, cy: 150, r: 50 } ],\n// [ 'circle', { cx: 150, cy: 150, fill: 'rgba(0,255,255,0.25)', r: 100, stroke: '#ff0000' } ] ]\n```\n+### DOM-style tree parsing using `defmulti`\n+\n+```ts\n+import { defmulti, DEFAULT } from \"@thi.ng/defmulti\";\n+\n+// coerces given attribute IDs into numeric values and\n+// keeps all other attribs\n+const numericAttribs = (e, ...ids: string[]) =>\n+ ids.reduce(\n+ (acc, id) => (acc[id] = parseFloat(e.attribs[id]), acc),\n+ { ...e.attribs }\n+ );\n+\n+// returns iterator of parsed & filtered children of given element\n+// (iterator is used to avoid extraneous copying at call sites)\n+const parsedChildren = (e) =>\n+ tx.iterator(\n+ tx.comp(\n+ tx.map(parseElement),\n+ tx.filter((e)=> !!e),\n+ ),\n+ e.children\n+ );\n+\n+// define multiple dispatch function, based on element tag name\n+const parseElement = defmulti((e) => e.tag);\n+\n+// tag specific implementations\n+parseElement.add(\"circle\", (e) =>\n+ [e.tag, numericAttribs(e, \"cx\", \"cy\", \"r\")]);\n+\n+parseElement.add(\"rect\", (e) =>\n+ [e.tag, numericAttribs(e, \"x\", \"y\", \"width\", \"height\")]);\n+\n+parseElement.add(\"g\", (e) =>\n+ [e.tag, e.attribs, ...parsedChildren(e)]);\n+\n+parseElement.add(\"svg\", (e) =>\n+ [e.tag, numericAttribs(e, \"width\", \"height\"), ...parsedChildren(e)]);\n+\n+// implementation for unhandled elements\n+parseElement.add(DEFAULT, () => null);\n+\n+// using the same SVG source as in previous example:\n+// the `last()` reducer just returns the ultimate value\n+// which in this case is the SVG root element's ELEM_END parse event\n+// this also contains all children (by default)\n+parseElement(tx.transduce(sax.parse(), tx.last(), svg));\n+\n+// [\"svg\",\n+// {\n+// version: \"1.1\",\n+// height: 300,\n+// width: 300,\n+// xmlns: \"http://www.w3.org/2000/svg\"\n+// },\n+// [\"g\",\n+// { fill: \"yellow\" },\n+// [\"circle\", { cx: 50, cy: 150, r: 50 }],\n+// [\"circle\", { cx: 250, cy: 150, r: 50 }],\n+// [\"circle\",\n+// {\n+// cx: 150,\n+// cy: 150,\n+// fill: \"rgba(0,255,255,0.25)\",\n+// r: 100,\n+// stroke: \"#ff0000\"\n+// }],\n+// [\"rect\",\n+// {\n+// x: 80,\n+// y: 80,\n+// width: 140,\n+// height: 140,\n+// fill: \"none\",\n+// stroke: \"black\"\n+// }]],\n+// [\"g\",\n+// { fill: \"none\", stroke: \"black\" },\n+// [\"circle\", { cx: 150, cy: 150, r: 50 }],\n+// [\"circle\", { cx: 150, cy: 150, r: 25 }]]]\n+```\n+\n### Error handling\nIf the parser encounters a syntax error, an error event value incl. a\n",
"new_path": "packages/sax/README.md",
"old_path": "packages/sax/README.md"
},
{
"change_type": "MODIFY",
"diff": "-// import * as assert from \"assert\";\n-// import * as sax from \"../src/index\";\n+import * as assert from \"assert\";\n+\n+import { defmulti, DEFAULT } from \"@thi.ng/defmulti\";\n+import * as tx from \"@thi.ng/transducers\";\n+\n+import * as sax from \"../src/index\";\n+\n+const svg = `\n+<?xml version=\"1.0\"?>\n+<svg version=\"1.1\" height=\"300\" width=\"300\" xmlns=\"http://www.w3.org/2000/svg\">\n+ <g fill=\"yellow\">\n+ <circle cx=\"50.00\" cy=\"150.00\" r=\"50.00\" />\n+ <circle cx=\"250.00\" cy=\"150.00\" r=\"50.00\" />\n+ <circle cx=\"150.00\" cy=\"150.00\" fill=\"rgba(0,255,255,0.25)\" r=\"100.00\" stroke=\"#ff0000\" />\n+ <rect x=\"80\" y=\"80\" width=\"140\" height=\"140\" fill=\"none\" stroke=\"black\" />\n+ </g>\n+ <g fill=\"none\" stroke=\"black\">\n+ <circle cx=\"150.00\" cy=\"150.00\" r=\"50.00\" />\n+ <circle cx=\"150.00\" cy=\"150.00\" r=\"25.00\" />\n+ </g>\n+</svg>`;\ndescribe(\"sax\", () => {\n- it(\"tests pending\");\n+ it(\"svg parse\", () => {\n+ assert.deepEqual(\n+ [...tx.iterator(\n+ tx.comp(\n+ sax.parse({ children: true }),\n+ tx.matchFirst((e) => e.type == sax.Type.ELEM_END && e.tag == \"g\"),\n+ tx.mapcat((e) => e.children),\n+ tx.filter((e) => e.tag == \"circle\"),\n+ tx.map((e) => [e.tag, {\n+ ...e.attribs,\n+ cx: parseFloat(e.attribs.cx),\n+ cy: parseFloat(e.attribs.cy),\n+ r: parseFloat(e.attribs.r),\n+ }])\n+ ),\n+ svg\n+ )],\n+ [\n+ ['circle', { cx: 50, cy: 150, r: 50 }],\n+ ['circle', { cx: 250, cy: 150, r: 50 }],\n+ ['circle', { cx: 150, cy: 150, fill: 'rgba(0,255,255,0.25)', r: 100, stroke: '#ff0000' }]\n+ ]\n+ );\n+ });\n+\n+ it(\"svg parse (defmulti)\", () => {\n+ const numericAttribs = (e, ...ids: string[]) =>\n+ ids.reduce(\n+ (acc, id) => (acc[id] = parseFloat(e.attribs[id]), acc),\n+ { ...e.attribs }\n+ );\n+\n+ const parsedChildren = (e) =>\n+ tx.iterator(\n+ tx.comp(\n+ tx.map(parseElement),\n+ tx.filter((e) => !!e),\n+ ),\n+ e.children\n+ );\n+\n+ // define multiple dispatch function, based on element tag name\n+ const parseElement = defmulti((e) => e.tag);\n+\n+ // implementations\n+ parseElement.add(\"circle\", (e) =>\n+ [e.tag, numericAttribs(e, \"cx\", \"cy\", \"r\")]);\n+\n+ parseElement.add(\"rect\", (e) =>\n+ [e.tag, numericAttribs(e, \"x\", \"y\", \"width\", \"height\")]);\n+\n+ parseElement.add(\"g\", (e) =>\n+ [e.tag, e.attribs, ...parsedChildren(e)]);\n+\n+ parseElement.add(\"svg\", (e) =>\n+ [e.tag, numericAttribs(e, \"width\", \"height\"), ...parsedChildren(e)]);\n+\n+ // implementation for unhandled elements (just return undefined)\n+ parseElement.add(DEFAULT, () => undefined);\n+\n+ assert.deepEqual(\n+ parseElement(tx.transduce(sax.parse(), tx.last(), svg)),\n+ [\"svg\",\n+ {\n+ version: \"1.1\",\n+ height: 300,\n+ width: 300,\n+ xmlns: \"http://www.w3.org/2000/svg\"\n+ },\n+ [\"g\",\n+ { fill: \"yellow\" },\n+ [\"circle\", { cx: 50, cy: 150, r: 50 }],\n+ [\"circle\", { cx: 250, cy: 150, r: 50 }],\n+ [\"circle\",\n+ {\n+ cx: 150,\n+ cy: 150,\n+ fill: \"rgba(0,255,255,0.25)\",\n+ r: 100,\n+ stroke: \"#ff0000\"\n+ }],\n+ [\"rect\",\n+ {\n+ x: 80,\n+ y: 80,\n+ width: 140,\n+ height: 140,\n+ fill: \"none\",\n+ stroke: \"black\"\n+ }]],\n+ [\"g\",\n+ { fill: \"none\", stroke: \"black\" },\n+ [\"circle\", { cx: 150, cy: 150, r: 50 }],\n+ [\"circle\", { cx: 150, cy: 150, r: 25 }]]]\n+ );\n+ });\n+\n+ it(\"errors\", () => {\n+ assert.deepEqual(\n+ [...tx.iterator(sax.parse(), \"a\")],\n+ [{ type: 7, body: \"unexpected char: 'a' @ pos 1\" }]\n+ );\n+ assert.deepEqual(\n+ [...tx.iterator(sax.parse(), \"<a><b></c></a>\")],\n+ [\n+ { type: 4, tag: \"a\", attribs: {} },\n+ { type: 4, tag: \"b\", attribs: {} },\n+ { type: 7, body: \"unmatched tag: 'c' @ pos 7\" }\n+ ]\n+ );\n+ });\n});\n",
"new_path": "packages/sax/test/index.ts",
"old_path": "packages/sax/test/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | docs(sax): add tests & DOM parsing example to readme | 1 | docs | sax |
679,913 | 11.07.2018 11:10:35 | -3,600 | fd23a34efe34dab44668d5cd97a5e08382afc346 | docs(sax): minor update readme | [
{
"change_type": "MODIFY",
"diff": "@@ -98,7 +98,7 @@ example parses an SVG file, then extracts and selectively applies\ntransformations to only the `<circle>` elements in the first group\n(`<g>`) element. Btw. The transformed elements can be serialized back\ninto SVG syntax using\n-[@thi.ng/hiccup-svg](https://github.com/thi-ng/umbrella/tree/master/packages/hiccup-svg)...\n+[@thi.ng/hiccup](https://github.com/thi-ng/umbrella/tree/master/packages/hiccup)...\nGiven the composed transducer below, parsing stops immediately after the\nfirst `<g>` element is complete. This is because the `matchFirst()`\n",
"new_path": "packages/sax/README.md",
"old_path": "packages/sax/README.md"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | docs(sax): minor update readme | 1 | docs | sax |
730,429 | 11.07.2018 11:47:56 | 14,400 | 9f6540ec3ff25616b9df9396a55ed2381e658308 | chore(tooling): replace child_process with execa
Following react bootstrap's use of execa | [
{
"change_type": "MODIFY",
"diff": "\"eslint-plugin-jsx-a11y\": \"^6.0.2\",\n\"eslint-plugin-mocha\": \"^4.9.0\",\n\"eslint-plugin-react\": \"^7.5.1\",\n+ \"execa\": \"^0.10.0\",\n\"extract-text-webpack-plugin\": \"^3.0.1\",\n\"file-loader\": \"^1.0.0\",\n\"html-webpack-plugin\": \"^2.30.1\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "const path = require('path');\n-const {execSync} = require('../../utils/exec');\n+const {exec} = require('../../utils/exec');\nmodule.exports = {\ncommand: 'samples',\n@@ -9,7 +9,7 @@ module.exports = {\nhandler: () => {\nconsole.info('Starting the samples ...');\nconst command = `webpack-dev-server --config scripts/webpack/webpack.dev.babel.js --hot --inline --history-api-fallback --context ${path.resolve('./samples')}`;\n- execSync(command)\n+ exec(command)\n.catch((error) => {\nconsole.error(error.stdout);\nthrow new Error('Error when running start samples', error);\n",
"new_path": "scripts/start/commands/samples.js",
"old_path": "scripts/start/commands/samples.js"
},
{
"change_type": "MODIFY",
"diff": "* Borrowed from React Bootstrap\n* https://github.com/react-bootstrap/react-bootstrap\n*/\n-const processExecSync = require('child_process').execSync;\n+const {shellSync} = require('execa');\nconst processExec = require('child-process-promise').exec;\nrequire('colors');\n@@ -78,7 +78,7 @@ function setExecOptions(options) {\n}\nfunction execSync(command) {\n- return processExecSync(command, {stdio: 'inherit'});\n+ return shellSync(command, {stdio: 'inherit'});\n}\nmodule.exports = {\n",
"new_path": "scripts/utils/exec.js",
"old_path": "scripts/utils/exec.js"
},
{
"change_type": "MODIFY",
"diff": "/*!\n* Copyright (c) 2015-2017 Cisco Systems, Inc. See LICENSE file.\n*/\n-const {execSync} = require('child_process');\n+const {shellSync} = require('execa');\nconst debug = require('debug')('tooling:git');\nexports.diff = async function diff(tag) {\ndebug(`diffing HEAD against ${tag}`);\ndebug(`Shelling out to \\`git diff --name-only HEAD..${tag}\\``);\n- const raw = String(execSync(`git diff --name-only HEAD..${tag}`));\n+ const raw = String(shellSync(`git diff --name-only HEAD..${tag}`));\ndebug('Done');\n@@ -22,7 +22,7 @@ exports.lastLog = function lastLog() {\nconst treeLike = process.env.GIT_COMMIT || 'HEAD';\nconst cmd = `git log -n 1 --format=%B ${treeLike}`;\ndebug(`Shelling out to ${cmd}`);\n- const log = String(execSync(cmd));\n+ const log = String(shellSync(cmd));\ndebug('Done');\nreturn log;\n};\n",
"new_path": "scripts/utils/git.js",
"old_path": "scripts/utils/git.js"
}
] | JavaScript | MIT License | webex/react-widgets | chore(tooling): replace child_process with execa
Following react bootstrap's use of execa | 1 | chore | tooling |
679,913 | 11.07.2018 11:48:06 | -3,600 | ad4caad943448543d21c10434834ca234a0e3101 | feat(paths): add updater(), refactor updateIn(), update readme | [
{
"change_type": "MODIFY",
"diff": "@@ -28,11 +28,11 @@ yarn add @thi.ng/paths\nimport * as paths from \"@thi.ng/paths\";\n```\n-The `getter()` and `setter()` functions compile a lookup path like\n-`a.b.c` into a function operating directly at the value the path points\n-to in nested object. For getters, this essentially compiles to `val =\n-obj.a.b.c`, with the important difference that the function returns\n-`undefined` if any intermediate values along the lookup path are\n+The `getter()`, `setter()` and `updater()` functions compile a lookup\n+path like `a.b.c` into a function operating directly at the value the\n+path points to in nested object. For getters, this essentially compiles\n+to `val = obj.a.b.c`, with the important difference that the function\n+returns `undefined` if any intermediate values along the lookup path are\nundefined (and doesn't throw an error).\nThe resulting setter function too accepts a single object (or array) to\n@@ -57,6 +57,25 @@ s(null, 24)\n// { a: { b: { c: 24 } } }\n```\n+Nested value updaters follow a similar pattern, but also take a user\n+supplied function to apply to the existing value (incl. any other\n+arguments passed):\n+\n+```ts\n+inc = updater(\"a.b\", (x) => x != null ? x + 1 : 1);\n+\n+inc({a: {b: 10}});\n+// { a: { b: 11 } }\n+inc({});\n+// { a: { b: 1 } }\n+\n+// with additional arguments\n+add = updater(\"a.b\", (x, n) => x + n);\n+\n+add({a: {b: 10}}, 13);\n+// { a: { b: 23 } }\n+```\n+\nIn addition to these higher-order functions, the module also provides\nimmediate-use wrappers: `getIn()`, `setIn()`, `updateIn()` and\n`deleteIn()`. These functions are using `getter` / `setter` internally,\n",
"new_path": "packages/paths/README.md",
"old_path": "packages/paths/README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -139,7 +139,7 @@ export function getter(path: Path) {\n*\n* @param path\n*/\n-export function setter(path: Path) {\n+export function setter(path: Path): (s: any, v: any) => any {\nconst ks = toPath(path);\nlet [a, b, c, d] = ks;\nswitch (ks.length) {\n@@ -217,6 +217,31 @@ export function setInMany(state: any, ...pairs: any[]) {\nreturn state;\n}\n+/**\n+ * Similar to `setter()`, returns a function to update values at given\n+ * `path` using provided update `fn`. The returned function accepts a\n+ * single object / array and applies `fn` to current path value (incl.\n+ * any additional/optional arguments passed) and uses result as new\n+ * value. Does not modify original state (unless given function does so\n+ * itself).\n+ *\n+ * ```\n+ * add = updater(\"a.b\", (x, n) => x + n);\n+ *\n+ * add({a: {b: 10}}, 13);\n+ * // { a: { b: 23 } }\n+ * ```\n+ *\n+ * @param path\n+ * @param fn\n+ */\n+export function updater(path: Path, fn: UpdateFn<any>) {\n+ const g = getter(path);\n+ const s = setter(path);\n+ return (state: any, ...args: any[]) =>\n+ s(state, fn.apply(null, (args.unshift(g(state)), args)));\n+};\n+\n/**\n* Similar to `setIn()`, but applies given function to current path\n* value (incl. any additional/optional arguments passed to `updateIn`)\n@@ -233,8 +258,7 @@ export function setInMany(state: any, ...pairs: any[]) {\n* @param path\n*/\nexport function updateIn(state: any, path: Path, fn: UpdateFn<any>, ...args: any[]) {\n- args.unshift(getIn(state, path));\n- return setter(path)(state, fn.apply(null, args));\n+ return setter(path)(state, fn.apply(null, (args.unshift(getter(path)(state)), args)));\n}\n/**\n",
"new_path": "packages/paths/src/index.ts",
"old_path": "packages/paths/src/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | feat(paths): add updater(), refactor updateIn(), update readme | 1 | feat | paths |
679,913 | 11.07.2018 11:49:33 | -3,600 | 73c7b8acc95744ddeef293ddffef1f7b54095027 | perf(interceptors): update valueSetter()/valueUpdater()
both functions now use pre-built setters/updaters | [
{
"change_type": "MODIFY",
"diff": "import {\ngetIn,\nPath,\n- setIn,\n- updateIn\n+ setter,\n+ updater\n} from \"@thi.ng/paths\";\nimport {\nEvent,\n@@ -225,7 +225,8 @@ export function ensureParamRange(min: number, max: number, value?: (e: Event) =>\n* @param tx\n*/\nexport function valueSetter<T>(path: Path, tx?: (x: T) => T): InterceptorFn {\n- return (state, [_, val]) => ({ [FX_STATE]: setIn(state, path, tx ? tx(val) : val) });\n+ const $ = setter(path);\n+ return (state, [_, val]) => ({ [FX_STATE]: $(state, tx ? tx(val) : val) });\n}\n/**\n@@ -250,5 +251,6 @@ export function valueSetter<T>(path: Path, tx?: (x: T) => T): InterceptorFn {\n* @param fn\n*/\nexport function valueUpdater<T>(path: Path, fn: (x: T, ...args: any[]) => T): InterceptorFn {\n- return (state, [_, ...args]) => ({ [FX_STATE]: updateIn(state, path, fn, ...args) });\n+ const $ = updater(path, fn);\n+ return (state, [_, ...args]) => ({ [FX_STATE]: $(state, ...args) });\n}\n",
"new_path": "packages/interceptors/src/interceptors.ts",
"old_path": "packages/interceptors/src/interceptors.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | perf(interceptors): update valueSetter()/valueUpdater()
- both functions now use pre-built setters/updaters | 1 | perf | interceptors |
730,429 | 11.07.2018 12:16:02 | 14,400 | b117ee0f90f337580e859a70d28521f56c6a3863 | chore(tooling): pass path to publish command | [
{
"change_type": "MODIFY",
"diff": "@@ -9,13 +9,13 @@ module.exports = {\ndesc: 'Publish all component and module packages',\nbuilder: {},\nhandler: () =>\n- getAllPackagePaths().map((pkg) => {\n+ getAllPackagePaths().map((pkgPath) => {\ntry {\n- const pkgJson = require(path.resolve(pkg, 'package.json'));\n+ const pkgJson = require(path.resolve(pkgPath, 'package.json'));\nconst pkgName = pkgJson.name.split('/').pop();\nconst isWidget = pkgName.startsWith('widget-');\nif (!isWidget && !pkgJson.private) {\n- return npmPublishPackage(pkgName);\n+ return npmPublishPackage(pkgName, pkgPath);\n}\n}\ncatch (err) {\n",
"new_path": "scripts/publish/commands/components.js",
"old_path": "scripts/publish/commands/components.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -90,16 +90,12 @@ function runInPackage({\npkgName,\npkgPath\n}) {\n- const outputPkgPath = getPackage(pkgName || pkgPath);\n+ const outputPkgPath = getPackage(pkgPath || pkgName);\nif (outputPkgPath) {\ntry {\nconsole.info(`${commandName} ${pkgName} ...`);\nconst command = constructCommand(outputPkgPath);\n- execSync(command)\n- .catch((error) => {\n- console.error(error.stdout);\n- throw new Error(`Error when running ${commandName} on ${pkgName}`, error);\n- });\n+ execSync(command);\n}\ncatch (err) {\nthrow new Error(`Error ${commandName} ${pkgName} package`, err);\n",
"new_path": "scripts/utils/package.js",
"old_path": "scripts/utils/package.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -2,11 +2,12 @@ const path = require('path');\nconst {runInPackage} = require('./package');\n-function npmPublishPackage(pkgName) {\n+function npmPublishPackage(pkgName, pkgPath) {\nreturn runInPackage({\n- constructCommand: (targetPath) => `cd ${path.resolve(targetPath)} && npm publish --access public`,\n+ constructCommand: (targetPath) => `cd ${path.resolve(targetPath)} && npm pack --access public`,\ncommandName: 'Publish Package to NPM',\n- pkgName\n+ pkgName,\n+ pkgPath\n});\n}\n",
"new_path": "scripts/utils/publish.js",
"old_path": "scripts/utils/publish.js"
}
] | JavaScript | MIT License | webex/react-widgets | chore(tooling): pass path to publish command | 1 | chore | tooling |
791,690 | 11.07.2018 12:49:29 | 25,200 | ff7d162564421094b072ed0b4434a3853bbc6950 | core: bump to 3.0.2 | [
{
"change_type": "MODIFY",
"diff": "+<a name=\"3.0.2\"></a>\n+# 3.0.2 (2018-07-11)\n+[Full Changelog](https://github.com/googlechrome/lighthouse/compare/v3.0.1...v3.0.2)\n+\n+## New Contributors!\n+Thanks to @schalkneethling and @eduardosada for their first contributions!\n+\n+## New Audits\n+\n+* assert a present and valid doctype ([#5274](https://github.com/googlechrome/lighthouse/pull/5274))\n+\n+## Core\n+\n+* fonts: bump gatherer timeout to 5s ([#5643](https://github.com/googlechrome/lighthouse/pull/5643))\n+* network-request: cleanup DevTools property names ([#5606](https://github.com/googlechrome/lighthouse/pull/5606))\n+* preload: remove blob protocol from preload audit ([#5409](https://github.com/googlechrome/lighthouse/pull/5409))\n+* without-javascript: allow noscript pages ([#5571](https://github.com/googlechrome/lighthouse/pull/5571))\n+\n+## Docs\n+\n+* architecture: add diagram of module dependencies ([#5615](https://github.com/googlechrome/lighthouse/pull/5615))\n+* custom-audit: update custom-audit to 3.0.0 api ([#5612](https://github.com/googlechrome/lighthouse/pull/5612))\n+* [minor] issue template tweaks ([#5641](https://github.com/googlechrome/lighthouse/pull/5641))\n+\n+## Extension\n+\n+* fix \"extension Error: couldn't resolve current tab\" ([#5591](https://github.com/googlechrome/lighthouse/pull/5591))\n+* 3.0.0 as well ([#5584](https://github.com/googlechrome/lighthouse/pull/5584))\n+\n+## Tests\n+\n+* [minor] rename robots.txt test file ([#5610](https://github.com/googlechrome/lighthouse/pull/5610))\n+* run the golden LHR check earlier ([#5609](https://github.com/googlechrome/lighthouse/pull/5609))\n+\n+## Misc\n+\n+* scripts: more succinct lantern output ([#5523](https://github.com/googlechrome/lighthouse/pull/5523))\n+\n<a name=\"3.0.1\"></a>\n# 3.0.1 (2018-07-02)\n[Full Changelog](https://github.com/googlechrome/lighthouse/compare/v3.0.0...v3.0.1)\n",
"new_path": "changelog.md",
"old_path": "changelog.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"userAgent\": \"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3358.0 Safari/537.36\",\n- \"lighthouseVersion\": \"3.0.1\",\n+ \"lighthouseVersion\": \"3.0.2\",\n\"fetchTime\": \"2018-03-13T00:55:45.840Z\",\n\"requestedUrl\": \"http://localhost:10200/dobetterweb/dbw_tester.html\",\n\"finalUrl\": \"http://localhost:10200/dobetterweb/dbw_tester.html\",\n",
"new_path": "lighthouse-core/test/results/sample_v2.json",
"old_path": "lighthouse-core/test/results/sample_v2.json"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"__MSG_appName__\",\n- \"version\": \"3.0.1\",\n+ \"version\": \"3.0.2\",\n\"minimum_chrome_version\": \"66\",\n\"manifest_version\": 2,\n\"description\": \"__MSG_appDescription__\",\n",
"new_path": "lighthouse-extension/app/manifest.json",
"old_path": "lighthouse-extension/app/manifest.json"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"lighthouse\",\n- \"version\": \"3.0.1\",\n+ \"version\": \"3.0.2\",\n\"description\": \"Lighthouse\",\n\"main\": \"./lighthouse-core/index.js\",\n\"bin\": {\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core: bump to 3.0.2 (#5656) | 1 | core | null |
730,429 | 11.07.2018 15:42:27 | 14,400 | 0571a75b2c3a7b086bc94405fed1294fc06112b6 | chore(tooling): fix publish from dry run | [
{
"change_type": "MODIFY",
"diff": "@@ -4,7 +4,7 @@ const {runInPackage} = require('./package');\nfunction npmPublishPackage(pkgName, pkgPath) {\nreturn runInPackage({\n- constructCommand: (targetPath) => `cd ${path.resolve(targetPath)} && npm pack --access public`,\n+ constructCommand: (targetPath) => `cd ${path.resolve(targetPath)} && npm publish --access public`,\ncommandName: 'Publish Package to NPM',\npkgName,\npkgPath\n",
"new_path": "scripts/utils/publish.js",
"old_path": "scripts/utils/publish.js"
}
] | JavaScript | MIT License | webex/react-widgets | chore(tooling): fix publish from dry run | 1 | chore | tooling |
217,922 | 11.07.2018 16:57:45 | -7,200 | 6fdbcd6a29230d5e1dec4e203b8b3d4567f3c249 | chore: first implementation for the teams page
TODO: rename feature | [
{
"change_type": "MODIFY",
"diff": "@@ -63,6 +63,10 @@ const routes: Routes = [\npath: 'settings',\nloadChildren: 'app/pages/settings/settings.module#SettingsModule'\n},\n+ {\n+ path: 'teams',\n+ loadChildren: 'app/pages/team/team.module#TeamModule'\n+ },\n];\n@NgModule({\n",
"new_path": "src/app/app-routing.module.ts",
"old_path": "src/app/app-routing.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -6,5 +6,14 @@ export class Team extends DataModel {\nleader: string;\n+ // This is a string <=> boolean map because we need it indexed on userId for easy requests inside firestore.\nmembers: { [index: string]: boolean } = {};\n+\n+ public addMember(userId: string): void {\n+ this.members[userId] = true;\n+ }\n+\n+ public removeMember(userId: string): void {\n+ delete this.members[userId];\n+ }\n}\n",
"new_path": "src/app/model/other/team.ts",
"old_path": "src/app/model/other/team.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -39,7 +39,7 @@ import {FfxivcraftingAmountInputComponent} from './ffxivcrafting-amount-input/ff\nimport {AnnouncementPopupComponent} from './announcement-popup/announcement-popup.component';\nimport {PermissionsPopupComponent} from './permissions-popup/permissions-popup.component';\nimport {PermissionsRowComponent} from './permissions-popup/permissions-row/permissions-row.component';\n-import {AddNewRowPopupComponent} from './permissions-popup/add-new-row-popup/add-new-row-popup.component';\n+import {UserSelectionPopupComponent} from './user-selection-popup/user-selection-popup.component';\nimport {FcCrestComponent} from './fc-crest/fc-crest.component';\nimport {AlarmGroupNamePopupComponent} from './alarm-group-name-popup/alarm-group-name-popup.component';\nimport {UserVerificationPopupComponent} from './user-verification-popup/user-verification-popup.component';\n@@ -91,7 +91,7 @@ import {UserVerificationPopupComponent} from './user-verification-popup/user-ver\nAnnouncementPopupComponent,\nPermissionsPopupComponent,\nPermissionsRowComponent,\n- AddNewRowPopupComponent,\n+ UserSelectionPopupComponent,\nFcCrestComponent,\nAlarmGroupNamePopupComponent,\nUserVerificationPopupComponent,\n@@ -121,7 +121,7 @@ import {UserVerificationPopupComponent} from './user-verification-popup/user-ver\nRegisterPopupComponent,\nAnnouncementPopupComponent,\nPermissionsPopupComponent,\n- AddNewRowPopupComponent,\n+ UserSelectionPopupComponent,\nAlarmGroupNamePopupComponent,\nUserVerificationPopupComponent,\n]\n",
"new_path": "src/app/modules/common-components/common-components.module.ts",
"old_path": "src/app/modules/common-components/common-components.module.ts"
},
{
"change_type": "MODIFY",
"diff": "import {ChangeDetectionStrategy, Component, Inject} from '@angular/core';\nimport {MAT_DIALOG_DATA, MatDialog, MatDialogRef, MatSnackBar} from '@angular/material';\nimport {DataWithPermissions} from '../../../core/database/permissions/data-with-permissions';\n-import {AddNewRowPopupComponent} from './add-new-row-popup/add-new-row-popup.component';\n+import {UserSelectionPopupComponent} from '../user-selection-popup/user-selection-popup.component';\nimport {BehaviorSubject, combineLatest, concat, Observable, of} from 'rxjs';\nimport {Permissions} from '../../../core/database/permissions/permissions';\nimport {PermissionsRegistry} from '../../../core/database/permissions/permissions-registry';\n@@ -115,7 +115,7 @@ export class PermissionsPopupComponent {\n}\naddNewRow(): void {\n- this.dialog.open(AddNewRowPopupComponent).afterClosed()\n+ this.dialog.open(UserSelectionPopupComponent).afterClosed()\n.pipe(filter(u => u !== ''))\n.subscribe(user => {\nif (this.registry.registry[user.$key] === undefined && this.data.authorId !== user.$key) {\n",
"new_path": "src/app/modules/common-components/permissions-popup/permissions-popup.component.ts",
"old_path": "src/app/modules/common-components/permissions-popup/permissions-popup.component.ts"
},
{
"change_type": "RENAME",
"diff": "",
"new_path": "src/app/modules/common-components/user-selection-popup/user-selection-popup.component.html",
"old_path": "src/app/modules/common-components/permissions-popup/add-new-row-popup/add-new-row-popup.component.html"
},
{
"change_type": "RENAME",
"diff": "",
"new_path": "src/app/modules/common-components/user-selection-popup/user-selection-popup.component.scss",
"old_path": "src/app/modules/common-components/permissions-popup/add-new-row-popup/add-new-row-popup.component.scss"
},
{
"change_type": "RENAME",
"diff": "import {Component, ElementRef, OnInit, ViewChild} from '@angular/core';\n-import {UserService} from '../../../../core/database/user.service';\n+import {UserService} from '../../../core/database/user.service';\nimport {fromEvent} from 'rxjs';\nimport {catchError, debounceTime, distinctUntilChanged, first, map, mergeMap} from 'rxjs/operators';\nimport {Observable} from 'rxjs/Observable';\nimport {combineLatest, of} from 'rxjs/index';\n@Component({\n- selector: 'app-add-new-row-popup',\n- templateUrl: './add-new-row-popup.component.html',\n- styleUrls: ['./add-new-row-popup.component.scss']\n+ selector: 'app-user-selection-popup',\n+ templateUrl: './user-selection-popup.component.html',\n+ styleUrls: ['./user-selection-popup.component.scss']\n})\n-export class AddNewRowPopupComponent implements OnInit {\n+export class UserSelectionPopupComponent implements OnInit {\n@ViewChild('inputField')\ninputField: ElementRef;\n",
"new_path": "src/app/modules/common-components/user-selection-popup/user-selection-popup.component.ts",
"old_path": "src/app/modules/common-components/permissions-popup/add-new-row-popup/add-new-row-popup.component.ts"
},
{
"change_type": "ADD",
"diff": "+<h2 mat-dialog-title>{{'TEAMS.Create_team' | translate}}</h2>\n+<div mat-dialog-content>\n+ <form (submit)=\"submit()\">\n+ <mat-form-field>\n+ <input matInput type=\"text\" [formControl]=\"form\" required>\n+ <mat-error *ngIf=\"form.hasError('required')\">\n+ {{'Please_enter_a_name' | translate}}\n+ </mat-error>\n+ </mat-form-field>\n+ <button mat-raised-button type=\"submit\" color=\"accent\">{{'Confirm' | translate}}</button>\n+ </form>\n+</div>\n",
"new_path": "src/app/pages/team/new-team-popup/new-team-popup.component.html",
"old_path": null
},
{
"change_type": "RENAME",
"diff": "",
"new_path": "src/app/pages/team/new-team-popup/new-team-popup.component.scss",
"old_path": "src/app/pages/team/team.component.scss"
},
{
"change_type": "ADD",
"diff": "+import {Component} from '@angular/core';\n+import {FormControl, Validators} from '@angular/forms';\n+import {MatDialogRef} from '@angular/material';\n+\n+@Component({\n+ selector: 'app-new-team-popup',\n+ templateUrl: './new-team-popup.component.html',\n+ styleUrls: ['./new-team-popup.component.scss']\n+})\n+export class NewTeamPopupComponent {\n+\n+ public form: FormControl = new FormControl('', Validators.required);\n+\n+ constructor(private ref: MatDialogRef<NewTeamPopupComponent>) {\n+ }\n+\n+ submit() {\n+ if (this.form.valid) {\n+ this.ref.close(this.form.value);\n+ }\n+ }\n+\n+}\n",
"new_path": "src/app/pages/team/new-team-popup/new-team-popup.component.ts",
"old_path": null
},
{
"change_type": "DELETE",
"diff": "-<h2>{{'TEAMS.Title' | translate}}</h2>\n-<div *ngIf=\"teams$ | async as teams; else loading\">\n- <mat-expansion-panel *ngFor=\"let team of teams\">\n-\n- </mat-expansion-panel>\n-</div>\n-<ng-template #loading>\n- <div class=\"loader-container\">\n- <mat-spinner></mat-spinner>\n- </div>\n-</ng-template>\n",
"new_path": null,
"old_path": "src/app/pages/team/team.component.html"
},
{
"change_type": "DELETE",
"diff": "-import {Component, OnInit} from '@angular/core';\n-import {TeamService} from '../../core/database/team.service';\n-import {Team} from '../../model/other/team';\n-import {Observable} from 'rxjs/index';\n-\n-@Component({\n- selector: 'app-team',\n- templateUrl: './team.component.html',\n- styleUrls: ['./team.component.scss']\n-})\n-export class TeamComponent implements OnInit {\n-\n- public teams$: Observable<Team[]>;\n-\n- constructor(private teamService: TeamService) {\n- this.teams$ = this.teamService.getUserTeams()\n- }\n-\n- ngOnInit() {\n- }\n-\n-}\n",
"new_path": null,
"old_path": "src/app/pages/team/team.component.ts"
},
{
"change_type": "MODIFY",
"diff": "import {NgModule} from '@angular/core';\nimport {CommonModule} from '@angular/common';\n-import {TeamComponent} from './team.component';\n+import {TeamComponent} from './team/team.component';\nimport {RouterModule, Routes} from '@angular/router';\n-import {MatExpansionModule, MatProgressSpinnerModule} from '@angular/material';\n+import {\n+ MatButtonModule,\n+ MatDialogModule,\n+ MatExpansionModule,\n+ MatFormFieldModule,\n+ MatIconModule,\n+ MatInputModule,\n+ MatListModule,\n+ MatProgressSpinnerModule,\n+ MatSnackBarModule,\n+ MatTooltipModule\n+} from '@angular/material';\nimport {TranslateModule} from '@ngx-translate/core';\nimport {CoreModule} from '../../core/core.module';\n+import {NewTeamPopupComponent} from './new-team-popup/new-team-popup.component';\n+import {FormsModule, ReactiveFormsModule} from '@angular/forms';\nconst routing: Routes = [\n{\n- path: 'teams',\n+ path: '',\ncomponent: TeamComponent\n}\n];\n@@ -16,6 +29,8 @@ const routing: Routes = [\n@NgModule({\nimports: [\nCommonModule,\n+ FormsModule,\n+ ReactiveFormsModule,\nTranslateModule,\nCoreModule,\n@@ -24,8 +39,22 @@ const routing: Routes = [\nMatExpansionModule,\nMatProgressSpinnerModule,\n+ MatDialogModule,\n+ MatSnackBarModule,\n+ MatListModule,\n+ MatIconModule,\n+ MatButtonModule,\n+ MatFormFieldModule,\n+ MatInputModule,\n+ MatTooltipModule,\n+ ],\n+ declarations: [\n+ TeamComponent,\n+ NewTeamPopupComponent\n],\n- declarations: [TeamComponent]\n+ entryComponents: [\n+ NewTeamPopupComponent\n+ ]\n})\nexport class TeamModule {\n}\n",
"new_path": "src/app/pages/team/team.module.ts",
"old_path": "src/app/pages/team/team.module.ts"
},
{
"change_type": "ADD",
"diff": "+<h2>{{'TEAMS.Title' | translate}}</h2>\n+<div *ngIf=\"user$ | async as user\">\n+ <div *ngIf=\"teams$ | async as teams; else loading\">\n+ <mat-expansion-panel *ngFor=\"let team of teams; trackBy: trackByTeamFn\" class=\"team-panel\">\n+ <mat-expansion-panel-header>\n+ <mat-panel-title>\n+ <span class=\"team-name\">\n+ {{team.name}}\n+ <button mat-icon-button><mat-icon>edit</mat-icon></button>\n+ </span>\n+ </mat-panel-title>\n+ <button mat-icon-button color=\"warn\" *ngIf=\"team.leader === user.$key\"\n+ (click)=\"$event.stopPropagation();deleteTeam(team)\">\n+ <mat-icon>delete</mat-icon>\n+ </button>\n+ </mat-expansion-panel-header>\n+ <mat-list *ngIf=\"getTeamMembers(team) | async as members; else loadingMembers\">\n+ <mat-list-item *ngFor=\"let member of members\">\n+ <img src=\"{{member.avatar}}\" alt=\"\" mat-list-avatar>\n+ <div matLine class=\"member-name\">\n+ {{member.name}}\n+ <div matTooltip=\"{{'PROFILE.Patreon_supporter' | translate}}\"\n+ matTooltipPosition=\"above\">\n+ <i class=\"fab fa-patreon\" *ngIf=\"member.user.patron || member.user.admin\"></i>\n+ </div>\n+ <mat-icon *ngIf=\"member.user.$key === team.leader\">stars</mat-icon>\n+ </div>\n+ <button mat-icon-button color=\"warn\"\n+ *ngIf=\"team.leader === user.$key && member.user.$key !== team.leader\"\n+ (click)=\"removeUser(team, member.user)\">\n+ <mat-icon>close</mat-icon>\n+ </button>\n+ </mat-list-item>\n+ </mat-list>\n+ <ng-template #loadingMembers>\n+ <div class=\"loader-container\">\n+ <mat-spinner></mat-spinner>\n+ </div>\n+ </ng-template>\n+ <button mat-button (click)=\"addUser(team)\" color=\"accent\" class=\"large-button\">\n+ <mat-icon class=\"button-icon\">person_add</mat-icon>\n+ {{'TEAMS.AddUser' | translate}}\n+ </button>\n+ </mat-expansion-panel>\n+\n+ <div *ngIf=\"teams.length === 0\" class=\"no-teams\">\n+ {{'TEAMS.No_teams' | translate}}\n+ </div>\n+\n+ <button mat-raised-button (click)=\"newTeam()\" color=\"accent\" class=\"large-button\">\n+ <mat-icon class=\"button-icon\">group_add</mat-icon>\n+ {{'TEAMS.Create_team' | translate}}\n+ </button>\n+ </div>\n+</div>\n+<ng-template #loading>\n+ <div class=\"loader-container\">\n+ <mat-spinner></mat-spinner>\n+ </div>\n+</ng-template>\n",
"new_path": "src/app/pages/team/team/team.component.html",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+.member-name {\n+ display: flex !important;\n+ align-items: center;\n+ .fa-patreon {\n+ margin: 0 5px;\n+ }\n+ mat-icon {\n+ margin-left: 5px;\n+ }\n+}\n+\n+.large-button {\n+ width: 100%;\n+ margin-top: 10px;\n+}\n+\n+.button-icon {\n+ margin-right: 5px;\n+}\n+\n+.team-panel {\n+ margin: 10px 0;\n+}\n+\n+.no-teams {\n+ font-size: 40px;\n+ width: 100%;\n+ min-height: 200px;\n+ opacity: .7;\n+ align-items: center;\n+ display: flex;\n+ justify-content: center;\n+}\n",
"new_path": "src/app/pages/team/team/team.component.scss",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import {Component} from '@angular/core';\n+import {TeamService} from '../../../core/database/team.service';\n+import {Team} from '../../../model/other/team';\n+import {combineLatest, Observable, of} from 'rxjs/index';\n+import {MatDialog, MatSnackBar} from '@angular/material';\n+import {NewTeamPopupComponent} from '../new-team-popup/new-team-popup.component';\n+import {filter, first, map, mergeMap, switchMap} from 'rxjs/operators';\n+import {UserService} from '../../../core/database/user.service';\n+import {TranslateService} from '@ngx-translate/core';\n+import {AppUser} from '../../../model/list/app-user';\n+import {UserSelectionPopupComponent} from '../../../modules/common-components/user-selection-popup/user-selection-popup.component';\n+import {faPatreon} from '@fortawesome/fontawesome-free-brands';\n+import fontawesome from '@fortawesome/fontawesome';\n+import {ConfirmationPopupComponent} from '../../../modules/common-components/confirmation-popup/confirmation-popup.component';\n+\n+@Component({\n+ selector: 'app-team',\n+ templateUrl: './team.component.html',\n+ styleUrls: ['./team.component.scss']\n+})\n+export class TeamComponent {\n+\n+ public teams$: Observable<Team[]>;\n+\n+ public teamMembersObservables: { [index: string]: Observable<any[]> } = {};\n+\n+ public user$: Observable<AppUser>;\n+\n+ constructor(private teamService: TeamService, private dialog: MatDialog, private userService: UserService,\n+ private snack: MatSnackBar, private translate: TranslateService) {\n+ this.teams$ = this.teamService.getUserTeams();\n+ this.user$ = this.userService.getUserData();\n+\n+ fontawesome.library.add(faPatreon);\n+ }\n+\n+ addUser(team: Team): void {\n+ this.dialog.open(UserSelectionPopupComponent).afterClosed()\n+ .pipe(\n+ filter(u => u !== ''),\n+ map(user => {\n+ team.addMember(user.$key);\n+ return team;\n+ }),\n+ mergeMap(updatedTeam => this.teamService.set(updatedTeam.$key, updatedTeam))\n+ )\n+ .subscribe(() => {\n+ // Clear team members cache\n+ delete this.teamMembersObservables[team.$key];\n+ });\n+ }\n+\n+ removeUser(team: Team, user: AppUser): void {\n+ this.dialog.open(ConfirmationPopupComponent).afterClosed()\n+ .pipe(\n+ filter(res => res),\n+ mergeMap(() => of(team)),\n+ map((t) => {\n+ t.removeMember(user.$key);\n+ return t;\n+ }),\n+ mergeMap(updatedTeam => this.teamService.set(updatedTeam.$key, updatedTeam))\n+ )\n+ .subscribe(() => {\n+ // Clear team members cache\n+ delete this.teamMembersObservables[team.$key];\n+ });\n+ }\n+\n+ newTeam(): void {\n+ this.userService.getUserData()\n+ .pipe(\n+ first(),\n+ switchMap(user => {\n+ return this.dialog.open(NewTeamPopupComponent)\n+ .afterClosed()\n+ .pipe(\n+ filter(res => res !== undefined && res !== ''),\n+ map(teamName => {\n+ const team = new Team();\n+ team.name = teamName;\n+ team.leader = user.$key;\n+ team.addMember(user.$key);\n+ return team;\n+ }),\n+ mergeMap(team => this.teamService.add(team)),\n+ map(() => this.snack.open(this.translate.instant('TEAMS.Team_created'), '',\n+ {duration: 5000}))\n+ )\n+ })\n+ ).subscribe();\n+ }\n+\n+ deleteTeam(team: Team): void {\n+ this.dialog.open(ConfirmationPopupComponent).afterClosed()\n+ .pipe(\n+ filter(res => res),\n+ mergeMap(() => this.teamService.remove(team.$key))\n+ )\n+ .subscribe(() => {\n+ // Clear team members cache\n+ delete this.teamMembersObservables[team.$key];\n+ });\n+ }\n+\n+ getTeamMembers(team: Team): Observable<any[]> {\n+ if (this.teamMembersObservables[team.$key] === undefined) {\n+ const members$ = Object.keys(team.members)\n+ .map(memberId => this.userService.getCharacter(memberId));\n+ this.teamMembersObservables[team.$key] = combineLatest(members$);\n+ }\n+ return this.teamMembersObservables[team.$key]\n+ }\n+\n+ trackByTeamFn(index: number, team: Team): string {\n+ return team.$key;\n+ }\n+\n+}\n",
"new_path": "src/app/pages/team/team/team.component.ts",
"old_path": null
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: first implementation for the teams page
TODO: rename feature | 1 | chore | null |
791,676 | 11.07.2018 18:45:39 | -7,200 | 82505a157b4c2f0acfedba777b274ebdfed878bb | core(preload): remove blob protocol from preload audit | [
{
"change_type": "MODIFY",
"diff": "@@ -65,7 +65,7 @@ class UsesRelPreloadAudit extends Audit {\n* @return {boolean}\n*/\nstatic shouldPreload(request, mainResource) {\n- if (request.isLinkPreload || request.protocol === 'data') {\n+ if (request.isLinkPreload || URL.NON_NETWORK_PROTOCOLS.includes(request.protocol)) {\nreturn false;\n}\n",
"new_path": "lighthouse-core/audits/uses-rel-preload.js",
"old_path": "lighthouse-core/audits/uses-rel-preload.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -190,6 +190,8 @@ URLShim.URL = URL;\nURLShim.URLSearchParams = (typeof self !== 'undefined' && self.URLSearchParams) ||\nrequire('url').URLSearchParams;\n+URLShim.NON_NETWORK_PROTOCOLS = ['blob', 'data'];\n+\nURLShim.INVALID_URL_DEBUG_STRING =\n'Lighthouse was unable to determine the URL of some script executions. ' +\n'It\\'s possible a Chrome extension or other eval\\'d code is the source.';\n",
"new_path": "lighthouse-core/lib/url-shim.js",
"old_path": "lighthouse-core/lib/url-shim.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -232,6 +232,36 @@ describe('Performance: uses-rel-preload audit', () => {\n});\n});\n+ it(`shouldn't suggest preload for protocol blob`, () => {\n+ const networkRecords = [\n+ {\n+ requestId: '3',\n+ protocol: 'blob',\n+ _startTime: 10,\n+ },\n+ ];\n+\n+ const chains = {\n+ '1': {\n+ children: {\n+ '2': {\n+ children: {\n+ '3': {\n+ request: networkRecords[0],\n+ children: {},\n+ },\n+ },\n+ },\n+ },\n+ },\n+ };\n+\n+ return UsesRelPreload.audit(mockArtifacts(networkRecords, chains), {}).then(output => {\n+ assert.equal(output.rawValue, 0);\n+ assert.equal(output.details.items.length, 0);\n+ });\n+ });\n+\nit('does not throw on a real trace/devtools log', async () => {\nconst artifacts = Object.assign({\nURL: {finalUrl: 'https://pwa.rocks/'},\n",
"new_path": "lighthouse-core/test/audits/uses-rel-preload-test.js",
"old_path": "lighthouse-core/test/audits/uses-rel-preload-test.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(preload): remove blob protocol from preload audit (#5409) | 1 | core | preload |
730,412 | 11.07.2018 18:56:21 | 0 | 21bff1ab49a9cfd2142004a8503f6e0a96367857 | chore(release): 0.1.318 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.318\"></a>\n+## [0.1.318](https://github.com/webex/react-ciscospark/compare/v0.1.317...v0.1.318) (2018-07-11)\n+\n+\n+\n<a name=\"0.1.317\"></a>\n## [0.1.317](https://github.com/webex/react-ciscospark/compare/v0.1.316...v0.1.317) (2018-07-10)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.317\",\n+ \"version\": \"0.1.318\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.318 | 1 | chore | release |
217,922 | 11.07.2018 22:28:14 | -7,200 | 49bf1dfb5046b363af3a783f8270cb30d8191a9b | chore: team name can now be edited | [
{
"change_type": "MODIFY",
"diff": "@@ -35,28 +35,15 @@ import {DatabaseModule} from './core/database/database.module';\nimport {FlexLayoutModule} from '@angular/flex-layout';\nimport {PipesModule} from './pipes/pipes.module';\nimport {DonationModule} from './modules/donation/donation.module';\n-import {SettingsModule} from './pages/settings/settings.module';\nimport {CartImportModule} from './pages/list-import/list-import.module';\nimport {CommonComponentsModule} from './modules/common-components/common-components.module';\n-import {HomeModule} from './pages/home/home.module';\nimport {ItemModule} from './modules/item/item.module';\n-import {FavoritesModule} from './pages/favorites/favorites.module';\nimport {ListModule} from './pages/list/list.module';\n-import {RecipesModule} from './pages/recipes/recipes.module';\n-import {ListsModule} from 'app/pages/lists/lists.module';\nimport {BetaDisclaimerModule} from './modules/beta-disclaimer/beta-disclaimer.module';\nimport {AngularFirestoreModule} from 'angularfire2/firestore';\n-import {AlarmsModule} from './pages/alarms/alarms.module';\n-import {ProfileModule} from './pages/profile/profile.module';\n-import {PublicListsModule} from './pages/public-lists/public-lists.module';\n-import {AddItemModule} from './pages/add-item/add-item.module';\n-import {AboutModule} from './pages/about/about.module';\nimport {MaintenanceModule} from './pages/maintenance/maintenance.module';\nimport {GivewayPopupModule} from './modules/giveway-popup/giveway-popup.module';\n-import {MacroTranslationModule} from './pages/macro-translation/macro-translation.module';\n-import {GatheringLocationModule} from './pages/gathering-location/gathering-location.module';\nimport {WorkshopModule} from './pages/workshop/workshop.module';\n-import {CustomLinksModule} from './pages/custom-links/custom-links.module';\nimport {LinkModule} from './pages/link/link.module';\nimport {TemplateModule} from './pages/template/template.module';\nimport {AlarmsSidebarModule} from './modules/alarms-sidebar/alarms-sidebar.module';\n@@ -66,7 +53,7 @@ import {SimulatorModule} from './pages/simulator/simulator.module';\nimport {NgDragDropModule} from 'ng-drag-drop';\nimport {IS_ELECTRON} from './core/tools/platform.service';\nimport {CommissionBoardModule} from './pages/commission-board/commission-board.module';\n-import {TeamModule} from './pages/team/team.module';\n+import {AppRoutingModule} from './app-routing.module';\nexport function HttpLoaderFactory(http: HttpClient): TranslateHttpLoader {\nreturn new TranslateHttpLoader(http, 'assets/i18n/', '.json');\n@@ -100,6 +87,8 @@ export function HttpLoaderFactory(http: HttpClient): TranslateHttpLoader {\nRouterModule.forRoot([], {useHash: IS_ELECTRON}),\n+ AppRoutingModule,\n+\nHttpClientModule,\n// Animations for material.\nBrowserAnimationsModule,\n@@ -140,28 +129,14 @@ export function HttpLoaderFactory(http: HttpClient): TranslateHttpLoader {\nAlarmsSidebarModule,\n// Pages\n- HomeModule,\n- ProfileModule,\n- CustomLinksModule,\nLinkModule,\nWikiModule,\n- RecipesModule,\n- ListsModule,\n- PublicListsModule,\nListModule,\n- AlarmsModule,\n- FavoritesModule,\n- SettingsModule,\n- AddItemModule,\n- AboutModule,\nMaintenanceModule,\n- MacroTranslationModule,\n- GatheringLocationModule,\nWorkshopModule,\nTemplateModule,\nSimulatorModule,\nCommissionBoardModule,\n- TeamModule,\n],\nbootstrap: [AppComponent]\n})\n",
"new_path": "src/app/app.module.ts",
"old_path": "src/app/app.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -9,7 +9,7 @@ import {MatProgressSpinnerModule} from '@angular/material';\nconst routes: Routes = [\n{\npath: '', children: [{\n- path: '/:nickName/:uri',\n+ path: ':nickName/:uri',\ncomponent: LinkComponent,\ncanActivate: [MaintenanceGuard]\n}]\n",
"new_path": "src/app/pages/link/link.module.ts",
"old_path": "src/app/pages/link/link.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -18,6 +18,7 @@ import {TranslateModule} from '@ngx-translate/core';\nimport {CoreModule} from '../../core/core.module';\nimport {NewTeamPopupComponent} from './new-team-popup/new-team-popup.component';\nimport {FormsModule, ReactiveFormsModule} from '@angular/forms';\n+import {CommonComponentsModule} from '../../modules/common-components/common-components.module';\nconst routing: Routes = [\n{\n@@ -34,6 +35,7 @@ const routing: Routes = [\nTranslateModule,\nCoreModule,\n+ CommonComponentsModule,\nRouterModule.forChild(routing),\n",
"new_path": "src/app/pages/team/team.module.ts",
"old_path": "src/app/pages/team/team.module.ts"
},
{
"change_type": "MODIFY",
"diff": "<mat-panel-title>\n<span class=\"team-name\">\n{{team.name}}\n- <button mat-icon-button><mat-icon>edit</mat-icon></button>\n+ <button mat-icon-button (click)=\"$event.stopPropagation();rename(team)\">\n+ <mat-icon>edit</mat-icon>\n+ </button>\n</span>\n</mat-panel-title>\n<button mat-icon-button color=\"warn\" *ngIf=\"team.leader === user.$key\"\n",
"new_path": "src/app/pages/team/team/team.component.html",
"old_path": "src/app/pages/team/team/team.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -12,6 +12,7 @@ import {UserSelectionPopupComponent} from '../../../modules/common-components/us\nimport {faPatreon} from '@fortawesome/fontawesome-free-brands';\nimport fontawesome from '@fortawesome/fontawesome';\nimport {ConfirmationPopupComponent} from '../../../modules/common-components/confirmation-popup/confirmation-popup.component';\n+import {NameEditPopupComponent} from '../../../modules/common-components/name-edit-popup/name-edit-popup.component';\n@Component({\nselector: 'app-team',\n@@ -34,6 +35,20 @@ export class TeamComponent {\nfontawesome.library.add(faPatreon);\n}\n+ rename(team: Team): void {\n+ this.dialog.open(NameEditPopupComponent, {data: team.name})\n+ .afterClosed()\n+ .pipe(\n+ map(value => {\n+ if (value !== undefined && value.length > 0) {\n+ team.name = value;\n+ }\n+ return team;\n+ }),\n+ mergeMap(updatedTeam => this.teamService.set(updatedTeam.$key, updatedTeam))\n+ ).subscribe();\n+ }\n+\naddUser(team: Team): void {\nthis.dialog.open(UserSelectionPopupComponent).afterClosed()\n.pipe(\n",
"new_path": "src/app/pages/team/team/team.component.ts",
"old_path": "src/app/pages/team/team/team.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: team name can now be edited | 1 | chore | null |
217,910 | 11.07.2018 22:43:05 | -36,000 | ba822418cc65e7c6f643b05e18a67626679e48e3 | ci: Chrome shouldn't fail on Travis | [
{
"change_type": "MODIFY",
"diff": "+dist: trusty\n+addons:\n+ chrome: stable\n+\nlanguage: node_js\nnode_js:\n- '8'\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
},
{
"change_type": "MODIFY",
"diff": "@@ -14,10 +14,17 @@ module.exports = function (config) {\nclearContext: false // leave Jasmine Spec Runner output visible in browser\n},\nport: 9876,\n+ browserNoActivityTimeout: 30000,\ncolors: true,\nlogLevel: config.LOG_INFO,\nautoWatch: true,\n- browsers: process.env.TRAVIS?['Chrome_travis_ci']:['Chrome'],\n+ browsers: process.env.TRAVIS?['ChromeHeadlessNoSandbox']:['Chrome'],\n+ customLaunchers: {\n+ ChromeHeadlessNoSandbox: {\n+ base: 'ChromeHeadless',\n+ flags: ['--no-sandbox']\n+ }\n+ },\nsingleRun: false\n});\n};\n",
"new_path": "karma.conf.js",
"old_path": "karma.conf.js"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | ci: Chrome shouldn't fail on Travis | 1 | ci | null |
217,910 | 11.07.2018 22:45:54 | -36,000 | 4b7c4fcb19397b257e141dc8a229c3d12036b40d | ci: Add proper code coverage | [
{
"change_type": "MODIFY",
"diff": "@@ -15,6 +15,9 @@ before_install:\nscript:\n- npm test && npm run build:prod\n+after_success:\n+ - npm run codecov\n+\nnotifications:\nemail:\non_failure: false\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
},
{
"change_type": "MODIFY",
"diff": "@@ -8,8 +8,19 @@ module.exports = function (config) {\nplugins: [\nrequire('karma-jasmine'),\nrequire('karma-chrome-launcher'),\n+ require('karma-coverage-istanbul-reporter'),\nrequire('@angular-devkit/build-angular/plugins/karma')\n],\n+ coverageIstanbulReporter: {\n+ reports: ['html', 'lcovonly', 'text-summary'],\n+ dir: './coverage',\n+ skipFilesWithNoCoverage: true,\n+ 'report-config': {\n+ html: {\n+ subdir: 'html'\n+ }\n+ }\n+ },\nclient: {\nclearContext: false // leave Jasmine Spec Runner output visible in browser\n},\n",
"new_path": "karma.conf.js",
"old_path": "karma.conf.js"
},
{
"change_type": "MODIFY",
"diff": "\"sprintf-js\": \"~1.0.2\"\n}\n},\n+ \"argv\": {\n+ \"version\": \"0.0.2\",\n+ \"resolved\": \"https://registry.npmjs.org/argv/-/argv-0.0.2.tgz\",\n+ \"integrity\": \"sha1-7L0W+JSbFXGDcRsb2jNPN4QBhas=\",\n+ \"dev\": true\n+ },\n\"arr-diff\": {\n\"version\": \"2.0.0\",\n\"resolved\": \"https://registry.npmjs.org/arr-diff/-/arr-diff-2.0.0.tgz\",\n\"resolved\": \"https://registry.npmjs.org/code-point-at/-/code-point-at-1.1.0.tgz\",\n\"integrity\": \"sha1-DQcLTQQ6W+ozovGkDi7bPZpMz3c=\"\n},\n+ \"codecov\": {\n+ \"version\": \"3.0.4\",\n+ \"resolved\": \"https://registry.npmjs.org/codecov/-/codecov-3.0.4.tgz\",\n+ \"integrity\": \"sha512-KJyzHdg9B8U9LxXa7hS6jnEW5b1cNckLYc2YpnJ1nEFiOW+/iSzDHp+5MYEIQd9fN3/tC6WmGZmYiwxzkuGp/A==\",\n+ \"dev\": true,\n+ \"requires\": {\n+ \"argv\": \"^0.0.2\",\n+ \"ignore-walk\": \"^3.0.1\",\n+ \"request\": \"^2.87.0\",\n+ \"urlgrey\": \"^0.4.4\"\n+ },\n+ \"dependencies\": {\n+ \"request\": {\n+ \"version\": \"2.87.0\",\n+ \"resolved\": \"https://registry.npmjs.org/request/-/request-2.87.0.tgz\",\n+ \"integrity\": \"sha512-fcogkm7Az5bsS6Sl0sibkbhcKsnyon/jV1kF3ajGmF0c8HrttdKTPRT9hieOaQHA5HEq6r8OyWOo/o781C1tNw==\",\n+ \"dev\": true,\n+ \"requires\": {\n+ \"aws-sign2\": \"~0.7.0\",\n+ \"aws4\": \"^1.6.0\",\n+ \"caseless\": \"~0.12.0\",\n+ \"combined-stream\": \"~1.0.5\",\n+ \"extend\": \"~3.0.1\",\n+ \"forever-agent\": \"~0.6.1\",\n+ \"form-data\": \"~2.3.1\",\n+ \"har-validator\": \"~5.0.3\",\n+ \"http-signature\": \"~1.2.0\",\n+ \"is-typedarray\": \"~1.0.0\",\n+ \"isstream\": \"~0.1.2\",\n+ \"json-stringify-safe\": \"~5.0.1\",\n+ \"mime-types\": \"~2.1.17\",\n+ \"oauth-sign\": \"~0.8.2\",\n+ \"performance-now\": \"^2.1.0\",\n+ \"qs\": \"~6.5.1\",\n+ \"safe-buffer\": \"^5.1.1\",\n+ \"tough-cookie\": \"~2.3.3\",\n+ \"tunnel-agent\": \"^0.6.0\",\n+ \"uuid\": \"^3.1.0\"\n+ }\n+ }\n+ }\n+ },\n\"codelyzer\": {\n\"version\": \"4.3.0\",\n\"resolved\": \"https://registry.npmjs.org/codelyzer/-/codelyzer-4.3.0.tgz\",\n\"integrity\": \"sha512-pUh+xUQQhQzevjRHHFqqcTy0/dP/kS9I8HSrUydhihjuD09W6ldVWFtIrwhXdUJHis3i2rZNqEHpZH/cbinFbg==\",\n\"dev\": true\n},\n+ \"ignore-walk\": {\n+ \"version\": \"3.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/ignore-walk/-/ignore-walk-3.0.1.tgz\",\n+ \"integrity\": \"sha512-DTVlMx3IYPe0/JJcYP7Gxg7ttZZu3IInhuEhbchuqneY9wWe5Ojy2mXLBaQFUQmo0AW2r3qG7m1mg86js+gnlQ==\",\n+ \"dev\": true,\n+ \"requires\": {\n+ \"minimatch\": \"^3.0.4\"\n+ }\n+ },\n\"image-size\": {\n\"version\": \"0.5.5\",\n\"resolved\": \"https://registry.npmjs.org/image-size/-/image-size-0.5.5.tgz\",\n\"prepend-http\": \"^1.0.1\"\n}\n},\n+ \"urlgrey\": {\n+ \"version\": \"0.4.4\",\n+ \"resolved\": \"https://registry.npmjs.org/urlgrey/-/urlgrey-0.4.4.tgz\",\n+ \"integrity\": \"sha1-iS/pWWCAXoVRnxzUOJ8stMu3ZS8=\",\n+ \"dev\": true\n+ },\n\"use\": {\n\"version\": \"3.1.0\",\n\"resolved\": \"https://registry.npmjs.org/use/-/use-3.1.0.tgz\",\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
},
{
"change_type": "MODIFY",
"diff": "\"standard-version:dry\": \"standard-version --dry-run\",\n\"release:prod\": \"git push --follow-tags origin master\",\n\"release:beta\": \"npm run standard-version -- --prerelease beta && git push --follow-tags origin beta\",\n- \"test\": \"node ./build/prebuild.js && ng test --watch=false\",\n+ \"test\": \"node ./build/prebuild.js && ng test --watch=false --code-coverage\",\n+ \"codecov\": \"cat coverage/lcov.info | codecov\",\n\"lint\": \"ng lint\",\n\"e2e\": \"ng e2e\",\n\"commitmsg\": \"validate-commit-msg\",\n\"codelyzer\": \"^4.3.0\",\n\"colors\": \"latest\",\n\"commitizen\": \"^2.9.6\",\n+ \"codecov\": \"latest\",\n\"cz-conventional-changelog\": \"^2.1.0\",\n\"del-cli\": \"^1.1.0\",\n\"electron\": \"^1.8.7\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | ci: Add proper code coverage | 1 | ci | null |
217,910 | 11.07.2018 22:46:38 | -36,000 | d1d8a1851afa8454e86429cc345a2fadbfe3cddb | chore: Add more hipster to README | [
{
"change_type": "MODIFY",
"diff": "# ffxiv-teamcraft\n+[](https://github.com/Supamiu/ffxiv-teamcraft/releases)\n+\n+[](https://github.com/Supamiu/ffxiv-teamcraft/issues)\n+[](https://github.com/Supamiu/ffxiv-teamcraft/pulls)\n+[](https://discord.gg/r6qxt6P)\n+\nCollaborative crafting tool for Final Fantasy XIV\nhttps://ffxivteamcraft.com\n@@ -8,7 +14,9 @@ Discord for support, bugs discussion and contributors: https://discord.gg/r6qxt6\n## Development\n+[](https://codecov.io/github/Supamiu/ffxiv-teamcraft?branch=staging)\n[](https://conventionalcommits.org)\n+[](https://github.com/Supamiu/ffxiv-teamcraft/blob/staging/LICENSE)\n### Prepare your environment\n",
"new_path": "README.md",
"old_path": "README.md"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: Add more hipster to README | 1 | chore | null |
217,927 | 12.07.2018 12:01:21 | 0 | 4f26f39390fa6bb92ff00cf2dd1cc5e21ce84d3b | refactor: rating into a component
Refactors the rating into a reusable component. This cleans up the
commission details view and will make it easy to display the rating
on other pages, such as the profile. | [
{
"change_type": "MODIFY",
"diff": "@@ -18,6 +18,7 @@ import {TooltipModule} from '../../modules/tooltip/tooltip.module';\nimport {CommissionChatComponent} from './commission-chat/commission-chat.component';\nimport {RatingPopupComponent} from './rating-popup/rating-popup.component';\nimport {HistoryComponent} from './history/history.component';\n+import {RatingComponent} from './rating/rating.component';\nimport {\nMatBadgeModule,\nMatButtonModule,\n@@ -112,7 +113,8 @@ const routes: Routes = [\nCommissionDetailsComponent,\nCommissionChatComponent,\nRatingPopupComponent,\n- HistoryComponent\n+ HistoryComponent,\n+ RatingComponent\n],\nentryComponents: [\nCommissionCreationPopupComponent,\n",
"new_path": "src/app/pages/commission-board/commission-board.module.ts",
"old_path": "src/app/pages/commission-board/commission-board.module.ts"
},
{
"change_type": "MODIFY",
"diff": "<div *ngIf=\"author$ | async as author; else loader\">\n<mat-card>\n<mat-card-header>\n- <img src=\"{{author.avatar}}\" alt=\"\" mat-card-avatar>\n<mat-card-title>\n{{commission.name}}\n</mat-card-title>\n<mat-card-subtitle>\n- <div class=\"buyer-name\">\n- {{author.name}}\n- <mat-icon *ngIf=\"author.user.verified\">verified_user</mat-icon>\n- -\n- <span class=\"rating\">\n- <span *ngFor=\"let star of getRating(author.user)\">\n- <mat-icon *ngIf=\"star === 1\">\n- star\n- </mat-icon>\n- <mat-icon *ngIf=\"star === .5\">\n- star_half\n- </mat-icon>\n- <mat-icon *ngIf=\"star === 0\">\n- star_border\n- </mat-icon>\n- </span>\n- <span>({{author.user.ratingsLength}})</span>\n- </span>\n- </div>\n+ <app-rating [character]=\"author\"></app-rating>\n</mat-card-subtitle>\n<div class=\"spacer\" *ngIf=\"commission.status <= 0 || commission.crafterId === undefined\"></div>\n<div class=\"crafter-container\" *ngIf=\"commission.status > 0 && commission.crafterId !== undefined\">\n<div *ngIf=\"getCharacter(commission.crafterId) | async as crafter\" class=\"crafter\">\n<div>{{'COMMISSION_BOARD.Crafted_by' | translate}}</div>\n- <img src=\"{{crafter.avatar}}\" alt=\"\" class=\"crafter-avatar\">\n- <div class=\"crafter-name\">\n- <span class=\"name-and-badge\">{{crafter.name}}\n- <mat-icon *ngIf=\"crafter.user.verified\">verified_user</mat-icon></span>\n- <span class=\"rating\">\n- <span *ngFor=\"let star of getRating(crafter.user)\">\n- <mat-icon *ngIf=\"star === 1\">\n- star\n- </mat-icon>\n- <mat-icon *ngIf=\"star === .5\">\n- star_half\n- </mat-icon>\n- <mat-icon *ngIf=\"star === 0\">\n- star_border\n- </mat-icon>\n- </span>\n- <span>({{crafter.user.ratingsLength}})</span>\n- </span>\n- </div>\n+ <app-rating [character]=\"crafter\"></app-rating>\n<button mat-icon-button\ncolor=\"warn\"\n*ngIf=\"(user$ | async)?.$key === commission.authorId && commission.status === 1\"\n<mat-list dense *ngIf=\"commission.candidateIds.length > 0\">\n<div *ngFor=\"let candidateId of commission.candidateIds\">\n<mat-list-item *ngIf=\"getCharacter(candidateId) | async as candidate\">\n- <img mat-list-avatar src=\"{{candidate.avatar}}\" alt=\"\">\n<span matLine>\n- <span class=\"candidate-name\">\n- {{candidate.name}}\n- <mat-icon *ngIf=\"candidate.user.verified\">verified_user</mat-icon>\n- </span>\n- </span>\n- <span matLine class=\"rating\">\n- <span *ngFor=\"let star of getRating(candidate.user)\">\n- <mat-icon *ngIf=\"star === 1\">\n- star\n- </mat-icon>\n- <mat-icon *ngIf=\"star === .5\">\n- star_half\n- </mat-icon>\n- <mat-icon *ngIf=\"star === 0\">\n- star_border\n- </mat-icon>\n- </span>\n- <span>({{candidate.user.ratingsLength}})</span>\n+ <app-rating [character]=\"candidate\"></app-rating>\n</span>\n- <a mat-mini-fab routerLink=\"chat/{{candidateId}}\"\n- *ngIf=\"commission.authorId === user.$key\">\n+ <a mat-mini-fab routerLink=\"chat/{{candidateId}}\" *ngIf=\"commission.authorId === user.$key\">\n<mat-icon>forum</mat-icon>\n</a>\n<button class=\"hire-button\" mat-raised-button color=\"primary\"\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.html",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.html"
},
{
"change_type": "MODIFY",
"diff": "width: auto !important;\n}\n-.buyer-name {\n- display: flex;\n- align-items: center;\n-}\n-\n-.rating {\n- display: flex;\n- align-items: center;\n-}\n-\n.card-actions {\ndisplay: flex;\n}\nalign-items: center;\n}\n-.candidate-name {\n- display: flex;\n- align-items: center;\n-}\n-\n.crafter-container {\nflex: 1 1 auto;\n.crafter {\ndisplay: flex;\nalign-items: center;\njustify-content: center;\n- .crafter-avatar {\n- width: 40px;\n- height: 40px;\n- border-radius: 40px;\n- margin-left: 5px;\n- }\n- .crafter-name {\n- display: flex;\n- flex-direction: column;\n- .name-and-badge {\n- display: flex;\n- align-items: center;\n- }\n+ height: 100%;\n}\n}\n+\n+.candidates {\n+ margin-bottom: 20px;\n}\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.scss",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -71,27 +71,6 @@ export class CommissionDetailsComponent implements OnInit, OnDestroy {\nthis.save(commission);\n}\n- /**\n- * Transforms the rating of a user into an array of length between 1 and 5\n- * @param {AppUser} user\n- * @returns {any[]}\n- */\n- getRating(user: AppUser): 1 | .5 | 0 [] {\n- let rating = user.rating;\n- const result = [];\n- while (rating >= 1) {\n- rating--;\n- result.push(1);\n- }\n- if (rating >= .5) {\n- result.push(.5);\n- }\n- while (result.length < 5) {\n- result.push(0);\n- }\n- return result;\n- }\n-\nhire(commission: Commission, userId: string): void {\nthis.dialog.open(ConfirmationPopupComponent, {data: 'COMMISSION_BOARD.Confirm_hire'})\n.afterClosed()\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.ts",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.ts"
},
{
"change_type": "ADD",
"diff": "+<div class=\"user\">\n+ <img src=\"{{character.avatar}}\" alt=\"\" class=\"avatar\">\n+ <span class=\"name-and-badge\">\n+ {{character.name}}\n+ <mat-icon *ngIf=\"character.user.verified\">verified_user</mat-icon>\n+ </span>\n+ <span class=\"rating\">\n+ <span *ngFor=\"let star of getStars(character.user)\">\n+ <mat-icon *ngIf=\"star === 1\">\n+ star\n+ </mat-icon>\n+ <mat-icon *ngIf=\"star === 0.5\">\n+ star_half\n+ </mat-icon>\n+ <mat-icon *ngIf=\"star === 0\">\n+ star_border\n+ </mat-icon>\n+ </span>\n+ <span>({{character.user.ratingsLength}})</span>\n+ </span>\n+</div>\n",
"new_path": "src/app/pages/commission-board/rating/rating.component.html",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+.user {\n+ display: flex;\n+ flex-direction: row;\n+ .avatar {\n+ width: 40px;\n+ height: 40px;\n+ border-radius: 40px;\n+ margin-left: 5px;\n+ }\n+ .name-and-badge {\n+ display: flex;\n+ align-items: center;\n+ margin: 0px 10px;\n+ }\n+}\n",
"new_path": "src/app/pages/commission-board/rating/rating.component.scss",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import {Component, Input} from '@angular/core';\n+import {AppUser} from '../../../model/list/app-user';\n+\n+@Component({\n+ selector: 'app-rating',\n+ templateUrl: './rating.component.html',\n+ styleUrls: ['./rating.component.scss']\n+})\n+export class RatingComponent {\n+\n+ @Input()\n+ public character: any;\n+\n+ /**\n+ * Transforms the rating of a user into an array of length between 1 and 5\n+ * @param {AppUser} user\n+ * @returns {any[]}\n+ */\n+ getStars(user: AppUser): 1 | 0.5 | 0 [] {\n+ let rating = user.rating;\n+ const result = [];\n+ while (rating >= 1) {\n+ rating--;\n+ result.push(1);\n+ }\n+ if (rating >= 0.5) {\n+ result.push(0.5);\n+ }\n+ while (result.length < 5) {\n+ result.push(0);\n+ }\n+ return result;\n+ }\n+}\n",
"new_path": "src/app/pages/commission-board/rating/rating.component.ts",
"old_path": null
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | refactor: rating into a component
Refactors the rating into a reusable component. This cleans up the
commission details view and will make it easy to display the rating
on other pages, such as the profile. | 1 | refactor | null |
217,922 | 12.07.2018 15:28:55 | -7,200 | 70702fa327afcbda9068ae181a43a1f8cea818e3 | chore: added new $10+ tier patreon supporter to loading screen | [
{
"change_type": "MODIFY",
"diff": "</div>\n</div>\n<script>\n- const patrons = ['Tataru Taru', 'Erys Night', 'Killagouge', 'chiya', 'DaiSuki2U (Leviathan)'];\n+ const patrons = ['Tataru Taru', 'Erys Night', 'Killagouge', 'chiya', 'DaiSuki2U (Leviathan)', 'Maie Arania'];\nconst randomPatron = patrons[Math.floor(Math.random() * patrons.length)];\ndocument.getElementById('random-patron').innerText = randomPatron;\n</script>\n",
"new_path": "src/index.html",
"old_path": "src/index.html"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: added new $10+ tier patreon supporter to loading screen | 1 | chore | null |
217,922 | 12.07.2018 15:45:12 | -7,200 | 5154951a57a8b3c86df90b9302129e919cfb7dcc | fix: fixed an issue that was preventing public profile from loading | [
{
"change_type": "MODIFY",
"diff": "@@ -40,7 +40,7 @@ const routes: Routes = [{\ncomponent: ProfileComponent,\ncanActivate: [ProfileGuard, MaintenanceGuard]\n}, {\n- path: 'profile/:id',\n+ path: ':id',\ncomponent: PublicProfileComponent,\ncanActivate: [MaintenanceGuard]\n}\n",
"new_path": "src/app/pages/profile/profile.module.ts",
"old_path": "src/app/pages/profile/profile.module.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed an issue that was preventing public profile from loading | 1 | fix | null |
730,412 | 12.07.2018 15:55:40 | 0 | c306dd87161837a2ea0bc4d05470f8be5d61b083 | chore(release): 0.1.319 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.319\"></a>\n+## [0.1.319](https://github.com/webex/react-ciscospark/compare/v0.1.318...v0.1.319) (2018-07-12)\n+\n+\n+\n<a name=\"0.1.318\"></a>\n## [0.1.318](https://github.com/webex/react-ciscospark/compare/v0.1.317...v0.1.318) (2018-07-11)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.318\",\n+ \"version\": \"0.1.319\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.319 | 1 | chore | release |
217,922 | 12.07.2018 16:44:34 | -7,200 | 99a9c90b4c37b88c7b2076d94beebcd9393d7e49 | fix(simulator): fixed default consumables | [
{
"change_type": "MODIFY",
"diff": "@@ -37,7 +37,7 @@ import {FreeCompanyAction} from 'app/pages/simulator/model/free-company-action';\nimport {FreeCompanyActionsService} from 'app/pages/simulator/model/free-company-actions.service';\nimport {I18nToolsService} from '../../../../core/tools/i18n-tools.service';\nimport {AppUser} from 'app/model/list/app-user';\n-import {debounceTime, filter, first, map, mergeMap, tap, skip} from 'rxjs/operators';\n+import {bufferTime, debounceTime, filter, first, map, mergeMap, tap} from 'rxjs/operators';\nimport {CraftingJob} from '../../model/crafting-job.enum';\nimport {StepByStepReportPopupComponent} from '../step-by-step-report-popup/step-by-step-report-popup.component';\nimport {RotationNamePopupComponent} from '../rotation-name-popup/rotation-name-popup.component';\n@@ -401,22 +401,21 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nthis.actions$\n.pipe(\n- // Skip first emission, as it's the default value.\n- skip(1)\n- )\n- .subscribe(actions => {\n+ bufferTime(1000),\n+ first(),\n+ map(bufferedValues => bufferedValues[bufferedValues.length - 1]),\n+ filter(actions => actions.length === 0),\n+ mergeMap(() => {\n// Set the default consumables, overridden later if this is an existing rotation\n- if (actions.length === 0) {\n- this.userService.getUserData().pipe(\n- tap(user => {\n+ return this.userService.getUserData();\n+ })\n+ )\n+ .subscribe(user => {\nconst defaultConsumables = (user.defaultConsumables || <DefaultConsumables>{});\nthis._selectedFood = this._selectedFood || defaultConsumables.food;\nthis._selectedMedicine = this._selectedMedicine || defaultConsumables.medicine;\nthis._selectedFreeCompanyActions = this._selectedFreeCompanyActions ||\ndefaultConsumables.freeCompanyActions;\n- })\n- ).subscribe();\n- }\n});\n}\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): fixed default consumables | 1 | fix | simulator |
791,690 | 12.07.2018 22:02:08 | 25,200 | 2a9d806976e27489b7227a245a8d752a87407678 | core(emulation): use setTouchEmulationEnabled | [
{
"change_type": "MODIFY",
"diff": "@@ -64,10 +64,7 @@ function enableNexus5X(driver) {\n// Network.enable must be called for UA overriding to work\ndriver.sendCommand('Network.enable'),\ndriver.sendCommand('Network.setUserAgentOverride', NEXUS5X_USERAGENT),\n- driver.sendCommand('Emulation.setEmitTouchEventsForMouse', {\n- enabled: true,\n- configuration: 'mobile',\n- }),\n+ driver.sendCommand('Emulation.setTouchEmulationEnabled', {enabled: true}),\n]);\n}\n",
"new_path": "lighthouse-core/lib/emulation.js",
"old_path": "lighthouse-core/lib/emulation.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(emulation): use setTouchEmulationEnabled (#5661) | 1 | core | emulation |
217,927 | 12.07.2018 22:02:54 | 0 | cf4ee186e5756d5641bb72fbb3aa6fbc128e7959 | feat: rating shown on profile
Adds a user's rating to their profile page. This is displayed once they
have a received their first rating. Made some style changes, including
moving the star rating below the user's name.
Resolves | [
{
"change_type": "MODIFY",
"diff": "@@ -119,6 +119,9 @@ const routes: Routes = [\nentryComponents: [\nCommissionCreationPopupComponent,\nRatingPopupComponent\n+ ],\n+ exports: [\n+ RatingComponent\n]\n})\nexport class CommissionBoardModule {\n",
"new_path": "src/app/pages/commission-board/commission-board.module.ts",
"old_path": "src/app/pages/commission-board/commission-board.module.ts"
},
{
"change_type": "MODIFY",
"diff": "<div class=\"spacer\" *ngIf=\"commission.status <= 0 || commission.crafterId === undefined\"></div>\n<div class=\"crafter-container\" *ngIf=\"commission.status > 0 && commission.crafterId !== undefined\">\n<div *ngIf=\"getCharacter(commission.crafterId) | async as crafter\" class=\"crafter\">\n- <div>{{'COMMISSION_BOARD.Crafted_by' | translate}}</div>\n+ <span>{{'COMMISSION_BOARD.Crafted_by' | translate}}</span>\n<app-rating [character]=\"crafter\"></app-rating>\n<button mat-icon-button\ncolor=\"warn\"\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.html",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.html"
},
{
"change_type": "MODIFY",
"diff": "align-items: center;\njustify-content: center;\nheight: 100%;\n+ > span {\n+ margin-right: 10px;\n+ }\n}\n}\n",
"new_path": "src/app/pages/commission-board/commission-details/commission-details.component.scss",
"old_path": "src/app/pages/commission-board/commission-details/commission-details.component.scss"
},
{
"change_type": "MODIFY",
"diff": "<div class=\"user\">\n- <img src=\"{{character.avatar}}\" alt=\"\" class=\"avatar\">\n+ <img src=\"{{character.avatar}}\" alt=\"\" class=\"avatar\" *ngIf=\"displayAvatar\">\n+ <div class=\"details\">\n<span class=\"name-and-badge\">\n{{character.name}}\n<mat-icon *ngIf=\"character.user.verified\">verified_user</mat-icon>\n<span>({{character.user.ratingsLength}})</span>\n</span>\n</div>\n+</div>\n",
"new_path": "src/app/pages/commission-board/rating/rating.component.html",
"old_path": "src/app/pages/commission-board/rating/rating.component.html"
},
{
"change_type": "MODIFY",
"diff": "width: 40px;\nheight: 40px;\nborder-radius: 40px;\n- margin-left: 5px;\n+ margin-right: 10px;\n}\n+ .details {\n+ display: flex;\n+ flex-direction: column;\n.name-and-badge {\ndisplay: flex;\nalign-items: center;\n- margin: 0px 10px;\n+ }\n}\n}\n",
"new_path": "src/app/pages/commission-board/rating/rating.component.scss",
"old_path": "src/app/pages/commission-board/rating/rating.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -11,6 +11,9 @@ export class RatingComponent {\n@Input()\npublic character: any;\n+ @Input()\n+ public displayAvatar = true;\n+\n/**\n* Transforms the rating of a user into an array of length between 1 and 5\n* @param {AppUser} user\n",
"new_path": "src/app/pages/commission-board/rating/rating.component.ts",
"old_path": "src/app/pages/commission-board/rating/rating.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -31,6 +31,7 @@ import {FormsModule, ReactiveFormsModule} from '@angular/forms';\nimport {PatreonLinkPopupComponent} from './patreon-link-popup/patreon-link-popup.component';\nimport {NicknamePopupComponent} from './nickname-popup/nickname-popup.component';\nimport {StatsEditPopupComponent} from './stats-edit-popup/stats-edit-popup.component';\n+import {CommissionBoardModule} from '../commission-board/commission-board.module';\nconst routes: Routes = [{\npath: '',\n@@ -73,6 +74,7 @@ const routes: Routes = [{\nPipesModule,\nCoreModule,\nCommonComponentsModule,\n+ CommissionBoardModule\n],\ndeclarations: [\nProfileComponent,\n",
"new_path": "src/app/pages/profile/profile.module.ts",
"old_path": "src/app/pages/profile/profile.module.ts"
},
{
"change_type": "MODIFY",
"diff": "<mat-card-header>\n<mat-card-title>\n<span class=\"character-name\">\n+ <div *ngIf=\"user.ratingsLength > 0; else noRating\">\n+ <app-rating [character]=\"character\" [displayAvatar]=\"false\"></app-rating>\n+ </div>\n+ <ng-template #noRating>\n{{character.name}}\n+ </ng-template>\n<mat-icon *ngIf=\"user.verified\">verified_user</mat-icon>\n- <button mat-icon-button color=\"warn\"\n+ <button mat-icon-button color=\"accent\"\n(click)=\"openVerificationPopup()\"\n*ngIf=\"!user.verified\"\n[matTooltip]=\"'PROFILE.User_not_verified' | translate\"\nmatTooltipPosition=\"above\">\n<mat-icon>warning</mat-icon>\n</button>\n- <span *ngIf=\"user.providerId === 'firebase'\"> - {{user.email}}\n+ <span *ngIf=\"user.providerId === 'firebase'\">{{user.email}}\n<button (click)=\"changeEmail()\" mat-icon-button>\n<mat-icon>edit</mat-icon>\n</button>\n",
"new_path": "src/app/pages/profile/profile/profile.component.html",
"old_path": "src/app/pages/profile/profile/profile.component.html"
},
{
"change_type": "MODIFY",
"diff": "\"filters/lvl\": \"Nivel requerido\",\n\"filters/craft_lvl\": \"Nivel de la receta\",\n\"filters/worn_by\": \"Usado por\",\n- \"filters/crafted_by\": \"Creado por\",\n+ \"filters/crafted_by\": \"Creado por:\",\n\"Adding_recipes\": \"Agregando {{amount}} recetas a la lista {{listname}}\",\n\"Recipe_Added\": \"{{itemname}} agregado a la lista {{listname}}\",\n\"Recipes_Added\": \"Resultados agregados a la lista {{listname}}\",\n",
"new_path": "src/assets/i18n/es.json",
"old_path": "src/assets/i18n/es.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: rating shown on profile
Adds a user's rating to their profile page. This is displayed once they
have a received their first rating. Made some style changes, including
moving the star rating below the user's name.
Resolves #482 | 1 | feat | null |
679,913 | 12.07.2018 22:27:21 | -3,600 | 087f34804c19d620de299e7670f6823c70200ce1 | refactor(iges): emit compressed globals section
reuse formatParams() for globals
add tests
update readme | [
{
"change_type": "MODIFY",
"diff": "@@ -52,38 +52,17 @@ console.log(iges.serialize(doc));\n```\n```iges\n-Generated by @thi.ng/iges S 1\n-1H,, G 1\n-1H;, G 2\n-, G 3\n-, G 4\n-12H@thi.ng/iges, G 5\n-5H0.0.1, G 6\n-32, G 7\n-38, G 8\n-6, G 9\n-308, G 10\n-15, G 11\n-, G 12\n-1.000, G 13\n-2, G 14\n-2HMM, G 15\n-1, G 16\n-0.254, G 17\n-15H20160519.151136, G 18\n-0.001, G 19\n-100.000, G 20\n-4Htoxi, G 21\n-6Hthi.ng, G 22\n-11, G 23\n-0, G 24\n-15H20160519.151136; G 25\n+Example file for @thi.ng/iges S 1\n+Defines single open 2D polyline (type 106) S 2\n+1H,,1H;,,,12H@thi.ng/iges,5H0.0.1,32,38,6,308,15,,1.000,2,2HMM,1,0.254, G 1\n+15H20180712.212228,0.001,100.000,4Htoxi,6Hthi.ng,11,0, G 2\n+15H20180712.212228; G 3\n106 1 0 0 0 0 0 000000000D 1\n106 0 0 3 11 0 0 0D 2\n106,1,9,0.000,0.000,0.000,0.000,100.000,50.000,150.000,100.000, 0000001P 1\n100.000,0.000,100.000,100.000,0.000,0.000,0.000,100.000, 0000001P 2\n100.000,100.000,0.000; 0000001P 3\n-S0000001G0000025D0000002P0000003 T 1\n+S0000002G0000003D0000002P0000003 T 1\n```\n## Authors\n",
"new_path": "packages/iges/README.md",
"old_path": "packages/iges/README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -15,6 +15,8 @@ export enum Type {\nINT,\nFLOAT,\nSTR,\n+ HSTR,\n+ DATE,\nPOINTER\n}\n@@ -154,7 +156,6 @@ export interface IGESDocument {\nD: number;\n};\n$FF: (x: number) => string;\n- $DATE: (d: Date) => string;\n$PARAM: (p: any[]) => string;\n}\n",
"new_path": "packages/iges/src/api.ts",
"old_path": "packages/iges/src/api.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -42,6 +42,16 @@ const $STR = (x: any) => (x != null ? (x = x.toString(), `${x.length}H${x}`) : \"\nconst $SEQ = padl(7, \" \");\nconst $BODY = padr(72, \" \");\nconst $PBODY = padr(64, \" \");\n+const $DATE = (d: Date) =>\n+ $STR([\n+ d.getUTCFullYear(),\n+ $Z2(d.getUTCMonth() + 1),\n+ $Z2(d.getUTCDate()),\n+ \".\",\n+ $Z2(d.getUTCHours()),\n+ $Z2(d.getUTCMinutes()),\n+ $Z2(d.getUTCSeconds())\n+ ].join(\"\"));\nexport const newDocument = (g?: Partial<GlobalParams>): IGESDocument => {\nconst globals = <GlobalParams>{ ...DEFAULT_GLOBALS, ...g };\n@@ -49,6 +59,9 @@ export const newDocument = (g?: Partial<GlobalParams>): IGESDocument => {\nconst $PARAM = defmulti<any[], string>((x) => x[1]);\n$PARAM.add(Type.INT, (x) => x[0].toString());\n$PARAM.add(Type.FLOAT, (x) => $FF(x[0]));\n+ $PARAM.add(Type.STR, (x) => x[0]);\n+ $PARAM.add(Type.HSTR, (x) => $STR(x[0]));\n+ $PARAM.add(Type.DATE, (x) => $DATE(x[0]));\nreturn {\nglobals,\n@@ -63,21 +76,12 @@ export const newDocument = (g?: Partial<GlobalParams>): IGESDocument => {\n},\n$FF,\n$PARAM,\n- $DATE: (d: Date) => $STR([\n- d.getUTCFullYear(),\n- $Z2(d.getUTCMonth() + 1),\n- $Z2(d.getUTCDate()),\n- \".\",\n- $Z2(d.getUTCHours()),\n- $Z2(d.getUTCMinutes()),\n- $Z2(d.getUTCSeconds())\n- ].join(\"\"))\n};\n};\nexport const serialize = (doc: IGESDocument) => [\n- formatSection(doc, doc.start, \"S\", \"\", \"\"),\n- formatGlobals(doc),\n+ ...formatStart(doc),\n+ ...formatGlobals(doc),\n...doc.dict,\n...doc.param,\nformatTerminate(doc)\n@@ -86,46 +90,52 @@ export const serialize = (doc: IGESDocument) => [\nconst formatLine = (body: string, type: string, i: number) =>\n`${$BODY(body)}${type}${$SEQ(i + 1)}`;\n-const formatSection = (doc: IGESDocument, items: any[], type: string, d1 = \"\", d2 = \"\") => {\n- const res = [...iterator(\n- mapIndexed(\n- (i, x) => formatLine(x + (i < items.length - 1 ? d1 : d2), type, i)\n- ),\n- items\n- )];\n- doc.offsets[type] += res.length;\n- return res.join(\"\\n\");\n+const formatStart = (doc: IGESDocument) => {\n+ const res = transduce(\n+ mapIndexed((i, x: string) => formatLine(x, \"S\", i)),\n+ push(),\n+ doc.start\n+ );\n+ doc.offsets.S += res.length;\n+ return res;\n};\nconst formatGlobals = (doc: IGESDocument) => {\nconst g = doc.globals;\n- return formatSection(doc, [\n- $STR(g.delimParam),\n- $STR(g.delimRecord),\n- $STR(g.senderProductID),\n- $STR(g.fileName),\n- $STR(g.generator),\n- $STR(g.generatorVersion),\n- g.intBits,\n- g.singleMaxPow,\n- g.singleDigits,\n- g.doubleMaxPow,\n- g.doubleDigits,\n- $STR(g.receiverProductID),\n- doc.$FF(g.modelScale),\n- g.units,\n- $STR(Unit[g.units]),\n- g.numLineWeights,\n- doc.$FF(g.maxLineWeight),\n- doc.$DATE(g.created || new Date()),\n- doc.$FF(1 / Math.pow(10, g.precision)),\n- g.maxCoord ? doc.$FF(g.maxCoord) : \"\",\n- $STR(g.author),\n- $STR(g.authorOrg),\n- g.specVersion,\n- g.draftVersion,\n- doc.$DATE(g.modified || new Date()),\n- ], \"G\", g.delimParam, g.delimRecord);\n+ const res = formatParams(\n+ doc,\n+ [\n+ [g.delimParam, Type.HSTR],\n+ [g.delimRecord, Type.HSTR],\n+ [g.senderProductID, Type.HSTR],\n+ [g.fileName, Type.HSTR],\n+ [g.generator, Type.HSTR],\n+ [g.generatorVersion, Type.HSTR],\n+ [g.intBits, Type.INT],\n+ [g.singleMaxPow, Type.INT],\n+ [g.singleDigits, Type.INT],\n+ [g.doubleMaxPow, Type.INT],\n+ [g.doubleDigits, Type.INT],\n+ [g.receiverProductID, Type.HSTR],\n+ [g.modelScale, Type.FLOAT],\n+ [g.units, Type.INT],\n+ [Unit[g.units], Type.HSTR],\n+ [g.numLineWeights, Type.INT],\n+ [g.maxLineWeight, Type.FLOAT],\n+ [g.created || new Date(), Type.DATE],\n+ [1 / Math.pow(10, g.precision), Type.FLOAT],\n+ [g.maxCoord || 1000, Type.FLOAT],\n+ [g.author, Type.HSTR],\n+ [g.authorOrg, Type.HSTR],\n+ [g.specVersion, Type.INT],\n+ [g.draftVersion, Type.INT],\n+ [g.modified || new Date(), Type.DATE],\n+ ],\n+ (body, i) => `${$BODY(body)}G${$SEQ(i + 1)}`,\n+ 72\n+ );\n+ doc.offsets.G += res.length;\n+ return res;\n};\nconst formatTerminate = (doc: IGESDocument) =>\n@@ -176,9 +186,11 @@ const formatDictEntry = (e: DictEntry) =>\n]\n);\n-const formatParams = (doc: IGESDocument, params: Param[]) => {\n- const did = doc.offsets.D + 1;\n- const pid = doc.offsets.P;\n+const formatParam = (did: number, pid: number) =>\n+ (body: string, i: number) =>\n+ `${$PBODY(body)} ${$Z7(did + 1)}P${$SEQ(i + pid)}`;\n+\n+const formatParams = (doc: IGESDocument, params: Param[], fmtBody: (body: string, i: number) => string, bodyWidth = 64) => {\nconst lines = transduce(\ncomp(\nmap(doc.$PARAM),\n@@ -187,7 +199,7 @@ const formatParams = (doc: IGESDocument, params: Param[]) => {\nlet flag = false;\nreturn (p) => {\nw += p.length + 1;\n- if (w >= 64) {\n+ if (w >= bodyWidth) {\nflag = !flag;\nw = p.length + 1;\n}\n@@ -200,11 +212,11 @@ const formatParams = (doc: IGESDocument, params: Param[]) => {\nparams);\nconst n = lines.length - 1;\nreturn lines.map(\n- (l, i) => {\n+ (line, i) => {\nconst d = i < n ?\ndoc.globals.delimParam :\ndoc.globals.delimRecord;\n- return `${$PBODY(l + d)} ${$Z7(did)}P${$SEQ(i + pid)}`;\n+ return fmtBody(line + d, i);\n}\n);\n};\n@@ -215,7 +227,9 @@ const formatParams = (doc: IGESDocument, params: Param[]) => {\nexport const addPolyline2d = (doc: IGESDocument, pts: number[][], closed = false) => {\nconst did = doc.offsets.D;\nconst pid = doc.offsets.P;\n- const params = formatParams(doc, [\n+ const params = formatParams(\n+ doc,\n+ [\n[106, Type.INT],\n[1, Type.INT],\n[pts.length + (closed ? 1 : 0), Type.INT],\n@@ -226,7 +240,9 @@ export const addPolyline2d = (doc: IGESDocument, pts: number[][], closed = false\n),\nclosed ? wrap(pts, 1, false, true) : pts\n)\n- ]);\n+ ],\n+ formatParam(did, pid)\n+ );\ndoc.offsets.P += params.length;\ndoc.offsets.D += 2;\ndoc.dict.push(...formatDictEntry(<DictEntry>{\n",
"new_path": "packages/iges/src/index.ts",
"old_path": "packages/iges/src/index.ts"
},
{
"change_type": "MODIFY",
"diff": "-// import * as assert from \"assert\";\n-// import * as iges from \"../src/index\";\n+import * as assert from \"assert\";\n+import * as iges from \"../src/index\";\ndescribe(\"iges\", () => {\n- it(\"tests pending\");\n+ it(\"basic\", () => {\n+ const doc = iges.newDocument({\n+ maxCoord: 100,\n+ precision: 3,\n+ author: \"toxi\",\n+ authorOrg: \"thi.ng\",\n+ created: new Date(123456789),\n+ modified: new Date(123456789),\n+ });\n+\n+ doc.start = [\n+ \"Example file for @thi.ng/iges\",\n+ ];\n+\n+ iges.addPolyline2d(doc, [\n+ [0, 0],\n+ [0, 100],\n+ [50, 150],\n+ [100, 100],\n+ [0, 100],\n+ [100, 0],\n+ [0, 0],\n+ [100, 100],\n+ [100, 0]\n+ ], false);\n+\n+ assert.equal(\n+ iges.serialize(doc),\n+ `Example file for @thi.ng/iges S 1\n+1H,,1H;,,,12H@thi.ng/iges,5H0.0.1,32,38,6,308,15,,1.000,2,2HMM,1,0.254, G 1\n+15H19700102.101736,0.001,100.000,4Htoxi,6Hthi.ng,11,0, G 2\n+15H19700102.101736; G 3\n+ 106 1 0 0 0 0 0 000000000D 1\n+ 106 0 0 3 11 0 0 0D 2\n+106,1,9,0.000,0.000,0.000,0.000,100.000,50.000,150.000,100.000, 0000001P 1\n+100.000,0.000,100.000,100.000,0.000,0.000,0.000,100.000, 0000001P 2\n+100.000,100.000,0.000; 0000001P 3\n+S0000001G0000003D0000002P0000003 T 1`\n+ );\n+ });\n});\n",
"new_path": "packages/iges/test/index.ts",
"old_path": "packages/iges/test/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | refactor(iges): emit compressed globals section
- reuse formatParams() for globals
- add tests
- update readme | 1 | refactor | iges |
679,913 | 12.07.2018 22:32:13 | -3,600 | eb6dfa9bd6d9aca11fb890b934b5f0aa0303a17e | build(iges): update package info | [
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@thi.ng/iges\",\n\"version\": \"0.0.1\",\n- \"description\": \"TODO\",\n+ \"description\": \"IGES 5.3 serializer for (currently only) polygonal geometry, both open & closed\",\n\"main\": \"./index.js\",\n\"typings\": \"./index.d.ts\",\n\"repository\": {\n},\n\"dependencies\": {\n\"@thi.ng/api\": \"^4.0.4\",\n+ \"@thi.ng/defmulti\": \"0.3.5\",\n\"@thi.ng/transducers\": \"^1.12.2\"\n},\n\"keywords\": [\n+ \"CAD\",\n\"ES6\",\n+ \"export\",\n+ \"IGES\",\n+ \"geometry\",\n+ \"serialization\",\n\"typescript\"\n],\n\"publishConfig\": {\n",
"new_path": "packages/iges/package.json",
"old_path": "packages/iges/package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -12,6 +12,7 @@ import {\npartitionBy,\npush\n} from \"@thi.ng/transducers\";\n+\nimport {\nDEFAULT_GLOBALS,\nDictEntry,\n",
"new_path": "packages/iges/src/index.ts",
"old_path": "packages/iges/src/index.ts"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | build(iges): update package info | 1 | build | iges |
679,913 | 12.07.2018 22:45:52 | -3,600 | 634de84db4663d3f00d44298abf7f34bdd235878 | docs: add to package list | [
{
"change_type": "MODIFY",
"diff": "@@ -53,6 +53,7 @@ difficulties, many combining functionality from several packages) in the\n| [`@thi.ng/hiccup`](./packages/hiccup) | [](https://www.npmjs.com/package/@thi.ng/hiccup) | [changelog](./packages/hiccup/CHANGELOG.md) | S-expression based HTML/XML serialization |\n| [`@thi.ng/hiccup-css`](./packages/hiccup-css) | [](https://www.npmjs.com/package/@thi.ng/hiccup-css) | [changelog](./packages/hiccup-css/CHANGELOG.md) | CSS from nested JS data structures |\n| [`@thi.ng/hiccup-svg`](./packages/hiccup-svg) | [](https://www.npmjs.com/package/@thi.ng/hiccup-svg) | [changelog](./packages/hiccup-svg/CHANGELOG.md) | hiccup based SVG vocab |\n+| [`@thi.ng/iges`](./packages/iges) | [](https://www.npmjs.com/package/@thi.ng/iges) | [changelog](./packages/iges/CHANGELOG.md) | IGES format geometry serialization |\n| [`@thi.ng/interceptors`](./packages/interceptors) | [](https://www.npmjs.com/package/@thi.ng/interceptors) | [changelog](./packages/interceptors/CHANGELOG.md) | Composable event handlers & processor |\n| [`@thi.ng/iterators`](./packages/iterators) | [](https://www.npmjs.com/package/@thi.ng/iterators) | [changelog](./packages/iterators/CHANGELOG.md) | ES6 generators / iterators |\n| [`@thi.ng/paths`](./packages/paths) | [](https://www.npmjs.com/package/@thi.ng/paths) | [changelog](./packages/paths/CHANGELOG.md) | Immutable nested object accessors |\n",
"new_path": "README.md",
"old_path": "README.md"
}
] | TypeScript | Apache License 2.0 | thi-ng/umbrella | docs: add @thi.ng/iges to package list | 1 | docs | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.