author int64 4.98k 943k | date stringdate 2017-04-15 16:45:02 2022-02-25 15:32:15 | timezone int64 -46,800 39.6k | hash stringlengths 40 40 | message stringlengths 8 468 | mods listlengths 1 16 | language stringclasses 9 values | license stringclasses 2 values | repo stringclasses 119 values | original_message stringlengths 12 491 | is_CCS int64 1 1 | commit_type stringclasses 129 values | commit_scope stringlengths 1 44 ⌀ |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
217,922 | 21.05.2018 16:26:25 | -7,200 | 2846feb67c9aeb1e4c5465015178feb5f54ccb1f | feat: contacts system for easy permissions management
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -33,4 +33,6 @@ export class AppUser extends DataModel {\nsharedWorkshops: string[] = [];\n// Saved overriden gearsets\ngearSets: GearSet[] = [];\n+ // Contact ids\n+ contacts: string[] = [];\n}\n",
"new_path": "src/app/model/list/app-user.ts",
"old_path": "src/app/model/list/app-user.ts"
},
{
"change_type": "MODIFY",
"diff": "</mat-list-item>\n</mat-list>\n<mat-spinner *ngIf=\"loading\"></mat-spinner>\n+ <div *ngIf=\"contacts$ | async as contacts\">\n+ <mat-divider></mat-divider>\n+ <h3>{{'PROFILE.Contacts' | translate}}</h3>\n+ <mat-list dense *ngIf=\"contacts.length > 0\">\n+ <mat-list-item *ngFor=\"let contact of contacts\">\n+ <img src=\"{{contact.avatar}}\" alt=\"\" mat-list-avatar>\n+ <span matLine>{{contact.name}}</span>\n+ <button mat-icon-button color=\"primary\" [mat-dialog-close]=\"contact\">\n+ <mat-icon>add</mat-icon>\n+ </button>\n+ </mat-list-item>\n+ </mat-list>\n+ </div>\n</div>\n<div mat-dialog-actions>\n<button mat-raised-button [mat-dialog-close]=\"result?.user\" color=\"primary\"\n",
"new_path": "src/app/modules/common-components/permissions-popup/add-new-row-popup/add-new-row-popup.component.html",
"old_path": "src/app/modules/common-components/permissions-popup/add-new-row-popup/add-new-row-popup.component.html"
},
{
"change_type": "MODIFY",
"diff": "import {Component, ElementRef, OnInit, ViewChild} from '@angular/core';\nimport {UserService} from '../../../../core/database/user.service';\nimport {fromEvent} from 'rxjs';\n-import {debounceTime, distinctUntilChanged, first, map, mergeMap} from 'rxjs/operators';\n+import {catchError, debounceTime, distinctUntilChanged, first, map, mergeMap} from 'rxjs/operators';\n+import {Observable} from 'rxjs/Observable';\n+import {combineLatest, of} from 'rxjs/index';\n@Component({\nselector: 'app-add-new-row-popup',\n@@ -22,7 +24,28 @@ export class AddNewRowPopupComponent implements OnInit {\npublic loading = false;\n+ public contacts$: Observable<any[]>;\n+\nconstructor(private userService: UserService) {\n+ this.contacts$ = userService.getUserData()\n+ .pipe(\n+ mergeMap(user => {\n+ return combineLatest(\n+ user.contacts.map(contactId => {\n+ return this.userService.getCharacter(contactId)\n+ .pipe(\n+ map(details => {\n+ details.$key = contactId;\n+ return details;\n+ }),\n+ catchError(() => {\n+ return of(null);\n+ })\n+ );\n+ })\n+ ).pipe(map(res => res.filter(row => row !== null)));\n+ })\n+ )\n}\nprivate doSearch(): void {\n",
"new_path": "src/app/modules/common-components/permissions-popup/add-new-row-popup/add-new-row-popup.component.ts",
"old_path": "src/app/modules/common-components/permissions-popup/add-new-row-popup/add-new-row-popup.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -355,6 +355,8 @@ export class ListDetailsComponent extends ComponentWithSubscriptions implements\nthis.router.navigate(['recipes']);\n})\n);\n+ default:\n+ return of(null)\n}\n})\n).subscribe();\n",
"new_path": "src/app/pages/list/list-details/list-details.component.ts",
"old_path": "src/app/pages/list/list-details/list-details.component.ts"
},
{
"change_type": "MODIFY",
"diff": "</div>\n</mat-card>\n</mat-grid-tile>\n- <mat-grid-tile colspan=\"3\" *ngIf=\"user.patron || user.admin\">\n+ <mat-grid-tile *ngIf=\"user.patron || user.admin\">\n<div class=\"patreon-card-container\">\n<mat-card>\n<h3 mat-card-title>{{\"PROFILE.Patreon_features\" | translate}}</h3>\n</mat-card>\n</div>\n</mat-grid-tile>\n+ <mat-grid-tile colspan=\"2\">\n+ <div class=\"contacts-card-container\">\n+ <mat-card class=\"contacts-card\">\n+ <h3 mat-card-title>{{\"PROFILE.Contacts\" | translate}}</h3>\n+ <mat-card-content>\n+ <mat-list>\n+ <div *ngFor=\"let contact of contacts\">\n+ <mat-list-item class=\"mat-elevation-z5 contact\">\n+ <img src=\"{{contact.avatar}}\" alt=\"\" mat-list-avatar>\n+ <span matLine>{{contact.name}}</span>\n+ <button mat-icon-button color=\"warn\" (click)=\"removeContact(contact.$key)\">\n+ <mat-icon>delete</mat-icon>\n+ </button>\n+ </mat-list-item>\n+ </div>\n+ </mat-list>\n+ </mat-card-content>\n+ <mat-card-actions>\n+ <div class=\"add-contact\">\n+ <mat-form-field>\n+ <input type=\"text\" matInput #newContact\n+ placeholder=\"{{'PROFILE.New_contact' | translate}}\">\n+ </mat-form-field>\n+ <button mat-icon-button (click)=\"addContact(newContact.value); newContact.value = ''\">\n+ <mat-icon>add</mat-icon>\n+ </button>\n+ </div>\n+ </mat-card-actions>\n+ </mat-card>\n+ </div>\n+ </mat-grid-tile>\n</mat-grid-list>\n</div>\n",
"new_path": "src/app/pages/profile/profile/profile.component.html",
"old_path": "src/app/pages/profile/profile/profile.component.html"
},
{
"change_type": "MODIFY",
"diff": "}\n}\n+ .contacts-card-container {\n+ width: 100%;\n+ height: 100%;\n+ display: flex;\n+ align-items: start;\n+ justify-content: start;\n+ .contacts-card {\n+ width: 100%;\n+ .contact {\n+ margin: 5px 0;\n+ }\n+ .add-contact {\n+ padding-left: 10px;\n+ }\n+ }\n+ }\n+\n.profile-card {\nwidth: 100%;\nheight: 100%;\n",
"new_path": "src/app/pages/profile/profile/profile.component.scss",
"old_path": "src/app/pages/profile/profile/profile.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -14,8 +14,10 @@ import {PatreonLinkPopupComponent} from '../patreon-link-popup/patreon-link-popu\nimport {NicknamePopupComponent} from '../nickname-popup/nickname-popup.component';\nimport {GearSet} from '../../simulator/model/gear-set';\nimport {DataService} from '../../../core/api/data.service';\n-import {first, map, mergeMap} from 'rxjs/operators';\n+import {catchError, filter, map, mergeMap} from 'rxjs/operators';\nimport {StatsEditPopupComponent} from '../stats-edit-popup/stats-edit-popup.component';\n+import {ConfirmationPopupComponent} from '../../../modules/common-components/confirmation-popup/confirmation-popup.component';\n+import {combineLatest, of} from 'rxjs';\n@Component({\nselector: 'app-profile',\n@@ -43,6 +45,7 @@ export class ProfileComponent extends PageComponent {\npublic jobs: GearSet[] = [];\n+ public contacts: any[] = [];\nconstructor(private userService: UserService, protected dialog: MatDialog, private help: HelpService, protected media: ObservableMedia,\nprivate dataService: DataService) {\n@@ -72,6 +75,26 @@ export class ProfileComponent extends PageComponent {\n)\n)\n).subscribe(jobs => this.jobs = jobs));\n+ this.subscriptions.push(\n+ userService.getUserData()\n+ .pipe(\n+ mergeMap(user => {\n+ return combineLatest(\n+ user.contacts.map(contactId => {\n+ return this.userService.getCharacter(contactId)\n+ .pipe(\n+ map(details => {\n+ details.$key = contactId;\n+ return details;\n+ }),\n+ catchError(() => {\n+ return of(null);\n+ })\n+ );\n+ })\n+ ).pipe(map(res => res.filter(row => row !== null)));\n+ })\n+ ).subscribe(res => this.contacts = res));\n}\npublic openNicknamePopup(): void {\n@@ -98,6 +121,22 @@ export class ProfileComponent extends PageComponent {\nthis.dialog.open(PatreonLinkPopupComponent, {data: this.user});\n}\n+ addContact(contactId: string): void {\n+ this.user.contacts = this.user.contacts.filter(contact => contact !== contactId);\n+ this.user.contacts.push(contactId);\n+ this.userService.set(this.user.$key, this.user);\n+ }\n+\n+ removeContact(contactId: string): void {\n+ this.dialog.open(ConfirmationPopupComponent)\n+ .afterClosed()\n+ .pipe(filter(res => res))\n+ .subscribe(() => {\n+ this.user.contacts = this.user.contacts.filter(contact => contact !== contactId);\n+ this.userService.set(this.user.$key, this.user);\n+ });\n+ }\n+\ngetHelpDialog(): ComponentType<any> | TemplateRef<any> {\nreturn ProfileHelpComponent;\n}\n",
"new_path": "src/app/pages/profile/profile/profile.component.ts",
"old_path": "src/app/pages/profile/profile/profile.component.ts"
},
{
"change_type": "MODIFY",
"diff": "\"Patreon_edit_email\": \"Edit patreon email\",\n\"Email_already_used\": \"Email already linked to another account\",\n\"Patreon_email\": \"Patreon Email\",\n+ \"Contacts\": \"Contacts\",\n+ \"New_contact\": \"New contact's user ID\",\n\"HELP\": {\n\"Welcome\": \"Welcome to profile page, this is the place where you can see and edit your own profile.\",\n\"Edit\": \"By clicking on the edit icon, you can edit the character linked to your FFXIV Teamcraft account.\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: contacts system for easy permissions management
closes #319 | 1 | feat | null |
217,922 | 21.05.2018 16:58:22 | -7,200 | 1b941d3768e611b8fb0d5541696d3bb2b7c1189e | chore: change version trigger for list isOutdated method | [
{
"change_type": "MODIFY",
"diff": "@@ -370,7 +370,7 @@ export class List extends DataWithPermissions {\n}\nlet res = false;\nres = res || (this.version === undefined);\n- res = res || semver.ltr(this.version, '3.4.6');\n+ res = res || semver.ltr(this.version, '3.9.0');\nreturn res;\n}\n",
"new_path": "src/app/model/list/list.ts",
"old_path": "src/app/model/list/list.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: change version trigger for list isOutdated method | 1 | chore | null |
217,922 | 21.05.2018 17:45:34 | -7,200 | 21209c0482b2d73411d2bcbd5059bf98ccd76ea3 | chore: translation fixes and path fixes | [
{
"change_type": "MODIFY",
"diff": "\"extractLicenses\": true,\n\"vendorChunk\": false,\n\"buildOptimizer\": true,\n- \"baseHref\": \"./\",\n+ \"baseHref\": \"/\",\n\"fileReplacements\": [\n{\n\"replace\": \"src/environments/environment.ts\",\n",
"new_path": "angular.json",
"old_path": "angular.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: translation fixes and path fixes | 1 | chore | null |
217,922 | 21.05.2018 18:47:44 | -7,200 | 6b4c55de4da8e067b5c10902ea1d771b1ba97f6c | fix: fixed an issue with profile component and custom sets | [
{
"change_type": "MODIFY",
"diff": "<div class=\"job-container\" *ngFor=\"let job of jobs\">\n<div>\n<img src=\"https://www.garlandtools.org/db/images/{{job.abbr}}.png\"\n- alt=\"{{job.name.toLowerCase()}}\" class=\"job-icon\">\n+ alt=\"{{job.name}}\" class=\"job-icon\">\n</div>\n<div class=\"job-level\">{{job.level}}</div>\n<button mat-button (click)=\"openMasterbooksPopup(job.abbr)\">\n<mat-icon>book</mat-icon>\n</button>\n- <button mat-button (click)=\"openStatsPopup(job)\">\n+ <button mat-button (click)=\"openStatsPopup(job)\" *ngIf=\"job.jobId < 16\">\n<mat-icon>mode_edit</mat-icon>\n</button>\n</div>\n",
"new_path": "src/app/pages/profile/profile/profile.component.html",
"old_path": "src/app/pages/profile/profile/profile.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -37,7 +37,8 @@ export class ProfileComponent extends PageComponent {\n{abbr: 'CUL', name: 'culinarian'},\n{abbr: 'MIN', name: 'miner'},\n{abbr: 'BTN', name: 'botanist'},\n- {abbr: 'FSH', name: 'fisher'}];\n+ {abbr: 'FSH', name: 'fisher'}\n+ ];\npublic character: any;\n@@ -58,11 +59,6 @@ export class ProfileComponent extends PageComponent {\n.pipe(\nmergeMap(user => this.dataService.getGearsets(user.lodestoneId, false)\n.pipe(\n- map(sets => sets.map(set => {\n- set.abbr = ProfileComponent.craftingJobs[set.jobId - 8].abbr;\n- set.name = ProfileComponent.craftingJobs[set.jobId - 8].name;\n- return set;\n- })),\nmap(gearsets => {\nreturn gearsets.map(set => {\nconst customSet = user.gearSets.find(s => s.jobId === set.jobId);\n@@ -71,7 +67,16 @@ export class ProfileComponent extends PageComponent {\n}\nreturn set;\n});\n- })\n+ }),\n+ map(sets => sets.map(set => {\n+ const job = ProfileComponent.craftingJobs[set.jobId - 8];\n+ if (job !== undefined) {\n+ set.abbr = job.abbr;\n+ set.name = job.name;\n+ return set;\n+ }\n+ }).filter(row => row !== null)\n+ )\n)\n)\n).subscribe(jobs => this.jobs = jobs));\n",
"new_path": "src/app/pages/profile/profile/profile.component.ts",
"old_path": "src/app/pages/profile/profile/profile.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed an issue with profile component and custom sets | 1 | fix | null |
217,922 | 21.05.2018 19:34:02 | -7,200 | 26f133af3da589dbce68687f2cd3458a55038c7e | chore: better implementation for previous commit | [
{
"change_type": "MODIFY",
"diff": "@@ -14,6 +14,20 @@ import {map, mergeMap, publishReplay, refCount, take} from 'rxjs/operators';\n@Injectable()\nexport class DataService {\n+ static craftingJobs = [\n+ {abbr: 'CRP', name: 'carpenter'},\n+ {abbr: 'BSM', name: 'blacksmith'},\n+ {abbr: 'ARM', name: 'armorer'},\n+ {abbr: 'LTW', name: 'leatherworker'},\n+ {abbr: 'WVR', name: 'weaver'},\n+ {abbr: 'GSM', name: 'goldsmith'},\n+ {abbr: 'ALC', name: 'alchemist'},\n+ {abbr: 'CUL', name: 'culinarian'},\n+ {abbr: 'MIN', name: 'miner'},\n+ {abbr: 'BTN', name: 'botanist'},\n+ {abbr: 'FSH', name: 'fisher'}\n+ ];\n+\nprivate garlandUrl = 'https://www.garlandtools.org/db/doc';\nprivate garlandtoolsVersion = 2;\nprivate garlandApiUrl = 'https://www.garlandtools.org/api';\n@@ -53,6 +67,25 @@ export class DataService {\n}\n})\n.sort((a, b) => a.jobId - b.jobId);\n+ }),\n+ map(sets => {\n+ const jobIds = onlyCraft ?\n+ [8, 9, 10, 11, 12, 13, 14, 15] :\n+ [8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18];\n+ jobIds.forEach(jobId => {\n+ if (sets.find(set => set.jobId === jobId) === undefined) {\n+ sets.push({\n+ ilvl: 0,\n+ control: 1350,\n+ craftsmanship: 1500,\n+ cp: 474,\n+ jobId: jobId,\n+ level: character.classjobs[DataService.craftingJobs[jobId - 8].name].level,\n+ specialist: false\n+ });\n+ }\n+ });\n+ return sets;\n})\n);\n})\n",
"new_path": "src/app/core/api/data.service.ts",
"old_path": "src/app/core/api/data.service.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: better implementation for previous commit | 1 | chore | null |
821,196 | 21.05.2018 21:55:27 | 25,200 | 7702f9041c29a4090d294807e75bd63d8f5a56dd | fix: bust circle cache | [
{
"change_type": "MODIFY",
"diff": "@@ -11,9 +11,9 @@ jobs:\n- checkout\n- restore_cache: &restore_cache\nkeys:\n- - v4-{{checksum \".circleci/config.yml\"}}-{{ checksum \"yarn.lock\"}}\n- - v4-{{checksum \".circleci/config.yml\"}}\n- - v4\n+ - v5-{{checksum \".circleci/config.yml\"}}-{{ checksum \"yarn.lock\"}}\n+ - v5-{{checksum \".circleci/config.yml\"}}\n+ - v5\n- run: .circleci/greenkeeper\n- run: yarn add -D mocha-junit-reporter@1\n- run: yarn exec nps lint\n@@ -107,12 +107,12 @@ jobs:\n- checkout\n- restore_cache:\nkeys:\n- - v4-{{checksum \".circleci/config.yml\"}}-{{checksum \"yarn.lock\"}}\n+ - v5-{{checksum \".circleci/config.yml\"}}-{{checksum \"yarn.lock\"}}\n- run: yarn global add greenkeeper-lockfile@1\n- run: yarn add -D mocha-junit-reporter@1\n- run: yarn exec nps test.command\n- save_cache:\n- key: v4-{{checksum \".circleci/config.yml\"}}-{{checksum \"yarn.lock\"}}\n+ key: v5-{{checksum \".circleci/config.yml\"}}-{{checksum \"yarn.lock\"}}\npaths:\n- /usr/local/share/.cache/yarn\n- /usr/local/share/.config/yarn\n",
"new_path": ".circleci/config.yml",
"old_path": ".circleci/config.yml"
}
] | TypeScript | MIT License | oclif/oclif | fix: bust circle cache | 1 | fix | null |
217,922 | 21.05.2018 22:40:57 | -7,200 | b42bcf260b5aa58feda5128b2a208fe4dcc2ff52 | fix: external links are now opened inside OS default browser | [
{
"change_type": "MODIFY",
"diff": "@@ -59,6 +59,16 @@ function createWindow() {\nconst trayIcon = nativeIcon.resize({width: 16, height: 16});\ntray = new Tray(trayIcon);\n+ const handleRedirect = (e, url) => {\n+ if(url !== win.webContents.getURL()) {\n+ e.preventDefault();\n+ require('electron').shell.openExternal(url);\n+ }\n+ };\n+\n+ win.webContents.on('will-navigate', handleRedirect);\n+ win.webContents.on('new-window', handleRedirect);\n+\ntray.on('click', () => {\nwin.isVisible() ? win.hide() : win.show()\n});\n@@ -71,10 +81,6 @@ function createWindow() {\ntray.on('balloon-click', () => {\n!win.isVisible() ? win.show() : null;\n});\n- win.on('new-window', function (event, url) {\n- event.preventDefault();\n- open(url);\n- });\nautoUpdater.checkForUpdatesAndNotify();\n}\n",
"new_path": "main.js",
"old_path": "main.js"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: external links are now opened inside OS default browser | 1 | fix | null |
217,922 | 21.05.2018 22:51:44 | -7,200 | 92b83e154d5e63f88819d7bf202e19e1a9ec5f9d | feat(desktop): new share button inside list details page | [
{
"change_type": "MODIFY",
"diff": "</span>\n</div>\n<div class=\"right-fabs\">\n+ <button mat-mini-fab *ngIf=\"platform.isDesktop()\" ngxClipboard [cbContent]=\"getLink()\"\n+ matTooltip=\"{{'Share' | translate}}\" matTooltipPosition=\"above\"\n+ (cbOnSuccess)=\"showCopiedNotification()\">\n+ <mat-icon>share</mat-icon>\n+ </button>\n+\n<button mat-mini-fab color=\"accent\" matTooltip=\"{{'LIST_DETAILS.Tags_popup' | translate}}\"\n(click)=\"openTagsPopup()\" *ngIf=\"isOwnList()\">\n<mat-icon>label_outline</mat-icon>\n",
"new_path": "src/app/pages/list/list-details/list-details.component.html",
"old_path": "src/app/pages/list/list-details/list-details.component.html"
},
{
"change_type": "MODIFY",
"diff": "position: absolute;\ntop: 10px;\nright: 10px;\n+ button {\n+ margin: 0 5px;\n+ }\n}\n.left-fabs {\nposition: absolute;\ntop: 10px;\nleft: 10px;\n+ button {\n+ margin: 0 5px;\n+ }\n}\n.header {\n",
"new_path": "src/app/pages/list/list-details/list-details.component.scss",
"old_path": "src/app/pages/list/list-details/list-details.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -37,6 +37,8 @@ import {PermissionsPopupComponent} from '../../../modules/common-components/perm\nimport {ListFinishedPopupComponent} from '../list-finished-popup/list-finished-popup.component';\nimport {filter} from 'rxjs/operators';\nimport {first, map, mergeMap, switchMap, tap} from 'rxjs/operators';\n+import {PlatformService} from '../../../core/tools/platform.service';\n+import {LinkToolsService} from '../../../core/tools/link-tools.service';\ndeclare const ga: Function;\n@@ -102,7 +104,8 @@ export class ListDetailsComponent extends ComponentWithSubscriptions implements\nconstructor(private auth: AngularFireAuth, private userService: UserService, protected dialog: MatDialog,\nprivate listService: ListService, private listManager: ListManagerService, private snack: MatSnackBar,\nprivate translate: TranslateService, private router: Router, private eorzeanTimeService: EorzeanTimeService,\n- public settings: SettingsService, private layoutService: LayoutService, private cd: ChangeDetectorRef) {\n+ public settings: SettingsService, private layoutService: LayoutService, private cd: ChangeDetectorRef,\n+ public platform: PlatformService, private linkTools: LinkToolsService) {\nsuper();\nthis.initFilters();\nthis.listDisplay = this.listData$\n@@ -121,6 +124,19 @@ export class ListDetailsComponent extends ComponentWithSubscriptions implements\n);\n}\n+ public getLink(): string {\n+ return this.linkTools.getLink(`/list/${this.listData.$key}`);\n+ }\n+\n+ public showCopiedNotification(): void {\n+ this.snack.open(\n+ this.translate.instant('Share_link_copied'),\n+ '', {\n+ duration: 10000,\n+ panelClass: ['snack']\n+ });\n+ }\n+\ndisplayTrackByFn(index: number, item: LayoutRowDisplay) {\nreturn item.filterChain;\n}\n",
"new_path": "src/app/pages/list/list-details/list-details.component.ts",
"old_path": "src/app/pages/list/list-details/list-details.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat(desktop): new share button inside list details page | 1 | feat | desktop |
217,922 | 22.05.2018 07:42:40 | -7,200 | 3544e0c68110b88d27e6327c3b6891e709554e6e | fix(simulator): fixed an issue with stats not being loaded properly, causing a crash | [
{
"change_type": "MODIFY",
"diff": "@@ -191,7 +191,7 @@ export class SimulatorComponent implements OnInit, OnDestroy {\npublic foods: Consumable[] = [];\n@Input()\n- public levels: CrafterLevels = [70, 70, 70, 70, 70, 70, 70, 70];\n+ public levels: CrafterLevels;\n@Input()\npublic set selectedFood(food: Consumable) {\n@@ -472,7 +472,7 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nset.cp + this.getBonusValue('CP', set.cp),\nset.specialist,\nset.level,\n- levels);\n+ (levels || [70, 70, 70, 70, 70, 70, 70, 70]));\nif (markDirty) {\nthis.markAsDirty();\n}\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -34,7 +34,7 @@ export abstract class CraftingAction {\ncanBeUsed(simulationState: Simulation, linear?: boolean): boolean {\nconst levelRequirement = this.getLevelRequirement();\n- if (levelRequirement.job !== CraftingJob.ANY) {\n+ if (levelRequirement.job !== CraftingJob.ANY && simulationState.crafterStats.levels[levelRequirement.job] !== undefined) {\nreturn simulationState.crafterStats.levels[levelRequirement.job] >= levelRequirement.level\n&& this._canBeUsed(simulationState, linear);\n}\n",
"new_path": "src/app/pages/simulator/model/actions/crafting-action.ts",
"old_path": "src/app/pages/simulator/model/actions/crafting-action.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): fixed an issue with stats not being loaded properly, causing a crash | 1 | fix | simulator |
217,922 | 22.05.2018 10:00:23 | -7,200 | 68cd942fd8f51a00d7acfc6c2f8f7be83b5e6f2e | fix: simulator is now working even with lodestone maintenance | [
{
"change_type": "MODIFY",
"diff": "@@ -53,7 +53,8 @@ export class DataService {\n.map(set => {\n// Get real level from lodestone profile as it's way more accurate and up to date, if not found,\n// default to set level.\n- const setLevel = (Object.keys(character.classjobs)\n+ const setLevel = (\n+ (Object.keys(character.classjobs || {}))\n.map(key => character.classjobs[key])\n.find(job => job.name === set.role.name) || set).level;\nreturn {\n@@ -200,7 +201,8 @@ export class DataService {\nmap(result => result.data),\npublishReplay(1),\nrefCount(),\n- take(1)\n+ take(1),\n+ map(res => res !== false ? res : {name: 'Lodestone under maintenance'})\n);\nthis.characterCache.set(id, request);\n}\n",
"new_path": "src/app/core/api/data.service.ts",
"old_path": "src/app/core/api/data.service.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: simulator is now working even with lodestone maintenance | 1 | fix | null |
815,745 | 22.05.2018 10:56:36 | -10,800 | 4c20e9e27e6a787e73baef753bd73f0c93735bee | fix(typeahead): don't insert option back to list for newly created tag
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -91,7 +91,7 @@ export class ItemsList {\nthis._selected = this._selected.filter(x => x !== item);\nitem.selected = false;\n- if (this._ngSelect.hideSelected) {\n+ if (this._ngSelect.hideSelected && isDefined(item.index)) {\nthis._filteredItems.splice(item.index, 0, item);\nthis._filteredItems = [...this._filteredItems.sort((a, b) => (a.index - b.index))];\n}\n",
"new_path": "src/ng-select/items-list.ts",
"old_path": "src/ng-select/items-list.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -1614,6 +1614,23 @@ describe('NgSelectComponent', function () {\nexpect(select.isOpen).toBeTruthy();\n}));\n+ it('should not insert option back to list if it is newly created option', fakeAsync(() => {\n+ select.addTag = true;\n+ select.typeahead = new Subject();\n+ select.typeahead.subscribe();\n+ fixture.componentInstance.cities = [];\n+ tickAndDetectChanges(fixture);\n+ fixture.componentInstance.select.filter('New item');\n+ tickAndDetectChanges(fixture);\n+ triggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\n+\n+ expect(select.selectedItems.length).toBe(1);\n+ expect(select.items.length).toBe(0);\n+ select.unselect(select.selectedItems[0]);\n+ tickAndDetectChanges(fixture);\n+ expect(select.itemsList.filteredItems.length).toBe(0);\n+ }));\n+\nit('should remove selected item from items list', fakeAsync(() => {\nfixture.componentInstance.selectedCities = [fixture.componentInstance.cities[0]];\ntickAndDetectChanges(fixture);\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -21,7 +21,6 @@ import {\nContentChildren,\nQueryList,\nInjectionToken,\n- NgZone,\nAttribute\n} from '@angular/core';\nimport { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';\n@@ -47,7 +46,6 @@ import { NgOption, KeyCode, NgSelectConfig } from './ng-select.types';\nimport { newId } from './id';\nimport { NgDropdownPanelComponent } from './ng-dropdown-panel.component';\nimport { NgOptionComponent } from './ng-option.component';\n-import { WindowService } from './window.service';\nexport const NG_SELECT_DEFAULT_CONFIG = new InjectionToken<NgSelectConfig>('ng-select-default-options');\nexport type DropdownPosition = 'bottom' | 'top' | 'auto';\n@@ -171,8 +169,6 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n@Attribute('class') public classes: string,\nprivate _cd: ChangeDetectorRef,\nprivate _console: ConsoleService,\n- private _zone: NgZone,\n- private _window: WindowService,\npublic elementRef: ElementRef\n) {\nthis._mergeGlobalConfig(config);\n@@ -385,14 +381,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\nfocus() {\n- if (!this.filterInput) {\n- return;\n- }\n- this._zone.runOutsideAngular(() => {\n- this._window.setTimeout(() => {\nthis.filterInput.nativeElement.focus();\n- }, 5);\n- });\n}\nunselect(item: NgOption) {\n@@ -409,11 +398,11 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\ntag = this._primitive ? this.filterValue : { [this.bindLabel]: this.filterValue };\n}\n+ const handleTag = (item) => this._isTypeahead ? this.itemsList.mapItem(item, null) : this.itemsList.addItem(item);\nif (isPromise(tag)) {\n- tag.then(item => this.select(this.itemsList.addItem(item)))\n- .catch(() => { });\n+ tag.then(item => this.select(handleTag(item))).catch(() => { });\n} else if (tag) {\n- this.select(this.itemsList.addItem(tag));\n+ this.select(handleTag(tag));\n}\n}\n@@ -489,7 +478,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nprivate _setItems(items: any[]) {\nconst firstItem = items[0];\nthis.bindLabel = this.bindLabel || this._defaultLabel;\n- this._primitive = !isObject(firstItem);\n+ this._primitive = !firstItem ? this._primitive : !isObject(firstItem);\nthis.itemsList.setItems(items);\nif (items.length > 0 && this.hasValue) {\nthis.itemsList.mapSelectedItems();\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] | TypeScript | MIT License | ng-select/ng-select | fix(typeahead): don't insert option back to list for newly created tag
closes #513 | 1 | fix | typeahead |
217,922 | 22.05.2018 10:58:30 | -7,200 | 77b7d69b3e28e14bc7dd9944d1ce1d6d77aadbcd | fix(simulator): fixed an issue with lodestone maintenance | [
{
"change_type": "MODIFY",
"diff": "\"balanced-match\": {\n\"version\": \"1.0.0\",\n\"bundled\": true,\n- \"dev\": true,\n- \"optional\": true\n+ \"dev\": true\n},\n\"brace-expansion\": {\n\"version\": \"1.1.11\",\n\"bundled\": true,\n\"dev\": true,\n- \"optional\": true,\n\"requires\": {\n\"balanced-match\": \"^1.0.0\",\n\"concat-map\": \"0.0.1\"\n\"code-point-at\": {\n\"version\": \"1.1.0\",\n\"bundled\": true,\n- \"dev\": true,\n- \"optional\": true\n+ \"dev\": true\n},\n\"concat-map\": {\n\"version\": \"0.0.1\",\n\"bundled\": true,\n- \"dev\": true,\n- \"optional\": true\n+ \"dev\": true\n},\n\"console-control-strings\": {\n\"version\": \"1.1.0\",\n\"bundled\": true,\n- \"dev\": true,\n- \"optional\": true\n+ \"dev\": true\n},\n\"core-util-is\": {\n\"version\": \"1.0.2\",\n\"inherits\": {\n\"version\": \"2.0.3\",\n\"bundled\": true,\n- \"dev\": true,\n- \"optional\": true\n+ \"dev\": true\n},\n\"ini\": {\n\"version\": \"1.3.5\",\n\"version\": \"1.0.0\",\n\"bundled\": true,\n\"dev\": true,\n- \"optional\": true,\n\"requires\": {\n\"number-is-nan\": \"^1.0.0\"\n}\n\"version\": \"3.0.4\",\n\"bundled\": true,\n\"dev\": true,\n- \"optional\": true,\n\"requires\": {\n\"brace-expansion\": \"^1.1.7\"\n}\n\"minizlib\": {\n\"version\": \"1.1.0\",\n\"bundled\": true,\n+ \"dev\": true,\n\"optional\": true,\n\"requires\": {\n\"minipass\": \"^2.2.1\"\n\"number-is-nan\": {\n\"version\": \"1.0.1\",\n\"bundled\": true,\n- \"dev\": true,\n- \"optional\": true\n+ \"dev\": true\n},\n\"object-assign\": {\n\"version\": \"4.1.1\",\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
},
{
"change_type": "MODIFY",
"diff": "\"electron:setup:build\": \"del-cli release/* && npm run build:electron-prod && electron-builder\",\n\"electron:setup:publish\": \"del-cli release/* && npm run build:electron-prod && electron-builder -p always\",\n\"postinstall\": \"electron-builder install-app-deps\",\n- \"release:full\": \"npm run build:prod && firebase deploy -P default && npm run electron:setup:publish\"\n+ \"release:full\": \"npm run build:prod && firebase deploy -P default --only hosting && npm run electron:setup:publish\"\n},\n\"private\": true,\n\"dependencies\": {\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -51,12 +51,15 @@ export class DataService {\n// We want only crafter sets\n.filter(row => row.classjob_id >= 8 && row.classjob_id <= (onlyCraft ? 15 : 18))\n.map(set => {\n+ let setLevel = 70;\n+ if (character.classjobs !== undefined) {\n// Get real level from lodestone profile as it's way more accurate and up to date, if not found,\n// default to set level.\n- const setLevel = (\n+ setLevel = (\n(Object.keys(character.classjobs || {}))\n.map(key => character.classjobs[key])\n.find(job => job.name === set.role.name) || set).level;\n+ }\nreturn {\nilvl: set.item_level_avg,\njobId: set.classjob_id,\n@@ -75,13 +78,17 @@ export class DataService {\n[8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18];\njobIds.forEach(jobId => {\nif (sets.find(set => set.jobId === jobId) === undefined) {\n+ let level = 70;\n+ if (character.classjobs !== undefined) {\n+ level = character.classjobs[DataService.craftingJobs[jobId - 8].name].level\n+ }\nsets.push({\nilvl: 0,\ncontrol: 1350,\ncraftsmanship: 1500,\ncp: 474,\njobId: jobId,\n- level: character.classjobs[DataService.craftingJobs[jobId - 8].name].level,\n+ level: level,\nspecialist: false\n});\n}\n",
"new_path": "src/app/core/api/data.service.ts",
"old_path": "src/app/core/api/data.service.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): fixed an issue with lodestone maintenance | 1 | fix | simulator |
217,922 | 22.05.2018 11:09:01 | -7,200 | cb97f4752f6a28a908d398040bade82680818fa9 | chore: new download app button in sidebar | [
{
"change_type": "MODIFY",
"diff": "<div class=\"fab-container\"><a href=\"https://discord.gg/r6qxt6P\" mat-mini-fab\nclass=\"social-fab discord\" target=\"_blank\"><i\nclass=\"fab fa-discord\"></i></a></div>\n+ <div class=\"fab-container\" matTooltip=\"{{'Download_desktop_app' | translate}}\"\n+ matTooltipPosition=\"above\" *ngIf=\"!mobile && !platformService.isDesktop()\">\n+ <a href=\"https://github.com/Supamiu/ffxiv-teamcraft/releases\" mat-mini-fab target=\"_blank\">\n+ <mat-icon>get_app</mat-icon>\n+ </a>\n+ </div>\n<div class=\"fab-container\"><a href=\"https://github.com/supamiu/ffxiv-teamcraft\" mat-mini-fab\nclass=\"social-fab github\"\ntarget=\"_blank\"><i class=\"fab fa-github\"></i></a></div>\n",
"new_path": "src/app/app.component.html",
"old_path": "src/app/app.component.html"
},
{
"change_type": "MODIFY",
"diff": "{\n+ \"Download_desktop_app\": \"Download desktop app\",\n\"Delete\": \"Delete\",\n\"Timers\": \"Timers\",\n\"Copy_isearch\": \"Copy isearch macro\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: new download app button in sidebar | 1 | chore | null |
791,690 | 22.05.2018 12:11:12 | 25,200 | 40cf8da6b44c6c68ae410e272ed939750cc2ea54 | misc(scripts): add trace/devtoolslog minification scripts | [
{
"change_type": "ADD",
"diff": "+#!/usr/bin/env node\n+/**\n+ * @license Copyright 2018 Google Inc. All Rights Reserved.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n+ */\n+'use strict';\n+\n+/* eslint-disable no-console */\n+\n+/**\n+ * @fileoverview Minifies a devtools log by removing noisy header values, eliminating data URIs, etc.\n+ */\n+\n+const fs = require('fs');\n+const path = require('path');\n+\n+if (process.argv.length !== 4) {\n+ console.error('Usage $0: <input file> <output file>');\n+ process.exit(1);\n+}\n+\n+const inputDevtoolsLogPath = path.resolve(process.cwd(), process.argv[2]);\n+const outputDevtoolsLogPath = path.resolve(process.cwd(), process.argv[3]);\n+const inputDevtoolsLogRaw = fs.readFileSync(inputDevtoolsLogPath, 'utf8');\n+/** @type {LH.DevtoolsLog} */\n+const inputDevtoolsLog = JSON.parse(inputDevtoolsLogRaw);\n+\n+const headersToKeep = new Set([\n+ // Request headers\n+ 'accept',\n+ 'accept-encoding',\n+ 'accept-ranges',\n+ // Response headers\n+ 'status',\n+ 'content-length',\n+ 'content-type',\n+ 'content-encoding',\n+ 'content-range',\n+ 'etag',\n+ 'cache-control',\n+ 'last-modified',\n+ 'link',\n+ 'x-robots-tag',\n+]);\n+\n+/** @param {Partial<LH.Crdp.Network.Headers>} [headers] */\n+function cleanHeaders(headers) {\n+ if (!headers) return;\n+\n+ for (const key of Object.keys(headers)) {\n+ if (!headersToKeep.has(key.toLowerCase())) headers[key] = undefined;\n+ }\n+}\n+\n+/** @param {{url: string}} obj */\n+function cleanDataURI(obj) {\n+ obj.url = obj.url.replace(/^(data:.*?base64,).*/, '$1FILLER');\n+}\n+\n+/** @param {LH.Crdp.Network.Response} [response] */\n+function cleanResponse(response) {\n+ if (!response) return;\n+ cleanDataURI(response);\n+ cleanHeaders(response.requestHeaders);\n+ cleanHeaders(response.headers);\n+ response.securityDetails = undefined;\n+ response.headersText = undefined;\n+ response.requestHeadersText = undefined;\n+\n+ /** @type {any} */\n+ const timing = response.timing || {};\n+ for (const [k, v] of Object.entries(timing)) {\n+ if (v === -1) timing[k] = undefined;\n+ }\n+}\n+\n+/** @param {LH.DevtoolsLog} log */\n+function filterDevtoolsLogEvents(log) {\n+ return log.map(original => {\n+ /** @type {LH.Protocol.RawEventMessage} */\n+ const entry = JSON.parse(JSON.stringify(original));\n+\n+ switch (entry.method) {\n+ case 'Network.requestWillBeSent':\n+ cleanDataURI(entry.params.request);\n+ cleanHeaders(entry.params.request.headers);\n+ cleanResponse(entry.params.redirectResponse);\n+ break;\n+ case 'Network.responseReceived':\n+ cleanResponse(entry.params.response);\n+ break;\n+ }\n+\n+ return entry;\n+ });\n+}\n+\n+const filteredLog = filterDevtoolsLogEvents(inputDevtoolsLog);\n+const output = `[\n+${filteredLog.map(e => ' ' + JSON.stringify(e)).join(',\\n')}\n+]`;\n+\n+/** @param {string} s */\n+const size = s => Math.round(s.length / 1024) + 'kb';\n+console.log(`Reduced DevtoolsLog from ${size(inputDevtoolsLogRaw)} to ${size(output)}`);\n+fs.writeFileSync(outputDevtoolsLogPath, output);\n",
"new_path": "lighthouse-core/scripts/lantern/minify-devtoolslog.js",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+#!/usr/bin/env node\n+/**\n+ * @license Copyright 2018 Google Inc. All Rights Reserved.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n+ */\n+'use strict';\n+\n+/* eslint-disable no-console */\n+\n+/**\n+ * @fileoverview Minifies a trace by removing unnecessary events, throttling screenshots, etc.\n+ * See the following files for necessary events:\n+ * - lighthouse-core/gather/computed/trace-of-tab.js\n+ * - lighthouse-core/gather/computed/page-dependency-graph.js\n+ * - lighthouse-core/lib/traces/tracing-processor.js\n+ */\n+\n+const fs = require('fs');\n+const path = require('path');\n+\n+if (process.argv.length !== 4) {\n+ console.error('Usage $0: <input file> <output file>');\n+ process.exit(1);\n+}\n+\n+const inputTracePath = path.resolve(process.cwd(), process.argv[2]);\n+const outputTracePath = path.resolve(process.cwd(), process.argv[3]);\n+const inputTraceRaw = fs.readFileSync(inputTracePath, 'utf8');\n+/** @type {LH.Trace} */\n+const inputTrace = JSON.parse(inputTraceRaw);\n+\n+const toplevelTaskNames = new Set([\n+ 'TaskQueueManager::ProcessTaskFromWorkQueue',\n+ 'ThreadControllerImpl::DoWork',\n+]);\n+\n+const traceEventsToAlwaysKeep = new Set([\n+ 'Screenshot',\n+ 'TracingStartedInBrowser',\n+ 'TracingStartedInPage',\n+ 'navigationStart',\n+ 'ParseAuthorStyleSheet',\n+ 'ParseHTML',\n+ 'PlatformResourceSendRequest',\n+ 'ResourceSendRequest',\n+ 'ResourceReceiveResponse',\n+ 'ResourceFinish',\n+ 'ResourceReceivedData',\n+ 'EventDispatch',\n+]);\n+\n+const traceEventsToKeepInToplevelTask = new Set([\n+ 'TimerInstall',\n+ 'TimerFire',\n+ 'InvalidateLayout',\n+ 'ScheduleStyleRecalculation',\n+ 'EvaluateScript',\n+ 'XHRReadyStateChange',\n+ 'FunctionCall',\n+ 'v8.compile',\n+]);\n+\n+const traceEventsToKeepInProcess = new Set([\n+ ...toplevelTaskNames,\n+ ...traceEventsToKeepInToplevelTask,\n+ 'firstPaint',\n+ 'firstContentfulPaint',\n+ 'firstMeaningfulPaint',\n+ 'firstMeaningfulPaintCandidate',\n+ 'loadEventEnd',\n+ 'domContentLoadedEventEnd',\n+]);\n+\n+/**\n+ * @param {LH.TraceEvent[]} events\n+ */\n+function filterOutUnnecessaryTasksByNameAndDuration(events) {\n+ // TODO(phulce): update this once https://github.com/GoogleChrome/lighthouse/pull/5271 lands\n+ const startedInPageEvt = events.find(evt => evt.name === 'TracingStartedInPage');\n+ if (!startedInPageEvt) throw new Error('Could not find TracingStartedInPage');\n+\n+ return events.filter(evt => {\n+ if (toplevelTaskNames.has(evt.name) && evt.dur < 1000) return false;\n+ if (evt.pid === startedInPageEvt.pid && traceEventsToKeepInProcess.has(evt.name)) return true;\n+ return traceEventsToAlwaysKeep.has(evt.name);\n+ });\n+}\n+\n+/**\n+ * Filters out tasks that are not within a toplevel task.\n+ * @param {LH.TraceEvent[]} events\n+ */\n+function filterOutOrphanedTasks(events) {\n+ const toplevelRanges = events\n+ .filter(evt => toplevelTaskNames.has(evt.name))\n+ .map(evt => [evt.ts, evt.ts + evt.dur]);\n+\n+ /** @param {LH.TraceEvent} e */\n+ const isInToplevelTask = e => toplevelRanges.some(([start, end]) => e.ts >= start && e.ts <= end);\n+\n+ return events.filter((evt, index) => {\n+ if (!traceEventsToKeepInToplevelTask.has(evt.name)) return true;\n+ if (!isInToplevelTask(evt)) return false;\n+\n+ if (evt.ph === 'B') {\n+ const endEvent = events.slice(index).find(e => e.name === evt.name && e.ph === 'E');\n+ return endEvent && isInToplevelTask(endEvent);\n+ } else {\n+ return true;\n+ }\n+ });\n+}\n+\n+/**\n+ * Throttles screenshot events in the trace to 2fps.\n+ * @param {LH.TraceEvent[]} events\n+ */\n+function filterOutExcessiveScreenshots(events) {\n+ const screenshotTimestamps = events.filter(evt => evt.name === 'Screenshot').map(evt => evt.ts);\n+\n+ let lastScreenshotTs = -Infinity;\n+ return events.filter(evt => {\n+ if (evt.name !== 'Screenshot') return true;\n+ const timeSinceLastScreenshot = evt.ts - lastScreenshotTs;\n+ const nextScreenshotTs = screenshotTimestamps.find(ts => ts > evt.ts);\n+ const timeUntilNextScreenshot = nextScreenshotTs ? nextScreenshotTs - evt.ts : Infinity;\n+ const threshold = 500 * 1000; // Throttle to ~2fps\n+ // Keep the frame if it's been more than 500ms since the last frame we kept or the next frame won't happen for at least 500ms\n+ const shouldKeep = timeUntilNextScreenshot > threshold || timeSinceLastScreenshot > threshold;\n+ if (shouldKeep) lastScreenshotTs = evt.ts;\n+ return shouldKeep;\n+ });\n+}\n+\n+/**\n+ * @param {LH.TraceEvent[]} events\n+ */\n+function filterTraceEvents(events) {\n+ // Filter out event names we don't care about and tasks <1ms\n+ let filtered = filterOutUnnecessaryTasksByNameAndDuration(events);\n+ // Filter out events not inside a toplevel task\n+ filtered = filterOutOrphanedTasks(filtered);\n+ // Filter down the screenshots to key moments + 2fps animations\n+ return filterOutExcessiveScreenshots(filtered);\n+}\n+\n+const filteredEvents = filterTraceEvents(inputTrace.traceEvents);\n+const output = `{\n+ \"traceEvents\": [\n+${filteredEvents.map(e => ' ' + JSON.stringify(e)).join(',\\n')}\n+ ]\n+}`;\n+\n+/** @param {string} s */\n+const size = s => Math.round(s.length / 1024) + 'kb';\n+console.log(`Reduced trace from ${size(inputTraceRaw)} to ${size(output)}`);\n+console.log(`Filtered out ${inputTrace.traceEvents.length - filteredEvents.length} trace events`);\n+fs.writeFileSync(outputTracePath, output);\n",
"new_path": "lighthouse-core/scripts/lantern/minify-trace.js",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "\"update:sample-json\": \"node ./lighthouse-cli -A=./lighthouse-core/test/results/artifacts --throttling-method=devtools --output=json --output-path=./lighthouse-core/test/results/sample_v2.json http://localhost/dobetterweb/dbw_tester.html && node lighthouse-core/scripts/cleanup-LHR-for-diff.js ./lighthouse-core/test/results/sample_v2.json --only-remove-timing\",\n\"diff:sample-json\": \"bash lighthouse-core/scripts/assert-golden-lhr-unchanged.sh\",\n\"update:crdp-typings\": \"node lighthouse-core/scripts/extract-crdp-mapping.js\",\n- \"mixed-content\": \"./lighthouse-cli/index.js --chrome-flags='--headless' --config-path=./lighthouse-core/config/mixed-content.js\"\n+ \"mixed-content\": \"./lighthouse-cli/index.js --chrome-flags='--headless' --config-path=./lighthouse-core/config/mixed-content.js\",\n+ \"minify-latest-run\": \"./lighthouse-core/scripts/lantern/minify-trace.js ./latest-run/defaultPass.trace.json ./latest-run/defaultPass.trace.min.json && ./lighthouse-core/scripts/lantern/minify-devtoolslog.js ./latest-run/defaultPass.devtoolslog.json ./latest-run/defaultPass.devtoolslog.min.json\"\n},\n\"devDependencies\": {\n\"@types/chrome\": \"^0.0.60\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | misc(scripts): add trace/devtoolslog minification scripts (#5237) | 1 | misc | scripts |
217,922 | 22.05.2018 13:31:21 | -7,200 | 796ea58d5d5cc70fe8297c5531df80e0c8f01f1f | fix(simulator): corrected action wait duration for macro generation | [
{
"change_type": "MODIFY",
"diff": "@@ -2,7 +2,6 @@ import {Component, Inject, OnInit} from '@angular/core';\nimport {MAT_DIALOG_DATA} from '@angular/material';\nimport {CraftingAction} from '../../model/actions/crafting-action';\nimport {LocalizedDataService} from '../../../../core/data/localized-data.service';\n-import {ActionType} from '../../model/actions/action-type';\nimport {I18nToolsService} from '../../../../core/tools/i18n-tools.service';\n@Component({\n@@ -32,7 +31,7 @@ export class MacroPopupComponent implements OnInit {\nif (actionName.indexOf(' ') > -1) {\nactionName = `\"${actionName}\"`;\n}\n- macroFragment.push(`/ac ${actionName} <wait.${action.getType() === ActionType.BUFF ? 2 : 3}>`);\n+ macroFragment.push(`/ac ${actionName} <wait.${action.getWaitDuration()}>`);\n});\n}\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -6,6 +6,10 @@ import {CraftingJob} from '../../crafting-job.enum';\nexport class ComfortZone extends BuffAction {\n+ getWaitDuration(): number {\n+ return 3;\n+ }\n+\ngetLevelRequirement(): { job: CraftingJob; level: number } {\nreturn {job: CraftingJob.ALC, level: 50};\n}\n",
"new_path": "src/app/pages/simulator/model/actions/buff/comfort-zone.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/comfort-zone.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -5,6 +5,10 @@ import {CraftingJob} from '../../crafting-job.enum';\nexport class InitialPreparations extends BuffAction {\n+ getWaitDuration(): number {\n+ return 3;\n+ }\n+\ngetLevelRequirement(): { job: CraftingJob; level: number } {\nreturn {job: CraftingJob.ANY, level: 69};\n}\n",
"new_path": "src/app/pages/simulator/model/actions/buff/initial-preparations.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/initial-preparations.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -24,6 +24,10 @@ export abstract class CraftingAction {\nreturn this.getIds()[jobId - 8] || this.getIds()[0];\n}\n+ public getWaitDuration(): number {\n+ return this.getType() === ActionType.BUFF ? 2 : 3;\n+ }\n+\nabstract getLevelRequirement(): { job: CraftingJob, level: number };\nabstract getType(): ActionType;\n",
"new_path": "src/app/pages/simulator/model/actions/crafting-action.ts",
"old_path": "src/app/pages/simulator/model/actions/crafting-action.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): corrected action wait duration for macro generation | 1 | fix | simulator |
791,723 | 22.05.2018 14:56:35 | 25,200 | 0e18bd1031de567913ea73edc8e11a171f792dec | report: move runtime settings to footer | [
{
"change_type": "MODIFY",
"diff": "@@ -65,23 +65,11 @@ class ReportRenderer {\nUtil.formatDateTime(report.fetchTime);\nthis._dom.find('.lh-product-info__version', header).textContent = report.lighthouseVersion;\nconst url = /** @type {HTMLAnchorElement} */ (this._dom.find('.lh-metadata__url', header));\n- url.href = report.finalUrl;\n- url.textContent = report.finalUrl;\nconst toolbarUrl = /** @type {HTMLAnchorElement}*/ (this._dom.find('.lh-toolbar__url', header));\n- toolbarUrl.href = report.finalUrl;\n- toolbarUrl.textContent = report.finalUrl;\n-\n- this._dom.find('.lh-env__item__ua', header).textContent = report.userAgent;\n-\n- const env = this._dom.find('.lh-env__items', header);\n- const environment = Util.getEnvironmentDisplayValues(report.configSettings || {});\n- environment.forEach(runtime => {\n- const item = this._dom.cloneTemplate('#tmpl-lh-env__items', env);\n- this._dom.find('.lh-env__name', item).textContent = runtime.name;\n- this._dom.find('.lh-env__description', item).textContent = runtime.description;\n- env.appendChild(item);\n- });\n+ url.href = url.textContent = toolbarUrl.href = toolbarUrl.textContent = report.finalUrl;\n+ const emulationDescriptions = Util.getEmulationDescriptions(report.configSettings || {});\n+ this._dom.find('.lh-config__emulation', header).textContent = emulationDescriptions.summary;\nreturn header;\n}\n@@ -91,9 +79,23 @@ class ReportRenderer {\n*/\n_renderReportFooter(report) {\nconst footer = this._dom.cloneTemplate('#tmpl-lh-footer', this._templateContext);\n+\n+ const env = this._dom.find('.lh-env__items', footer);\n+ env.id = 'runtime-settings';\n+ const envValues = Util.getEnvironmentDisplayValues(report.configSettings || {});\n+ [\n+ {name: 'URL', description: report.finalUrl},\n+ {name: 'Fetch time', description: Util.formatDateTime(report.fetchTime)},\n+ ...envValues,\n+ {name: 'User agent', description: report.userAgent},\n+ ].forEach(runtime => {\n+ const item = this._dom.cloneTemplate('#tmpl-lh-env__items', env);\n+ this._dom.find('.lh-env__name', item).textContent = `${runtime.name}:`;\n+ this._dom.find('.lh-env__description', item).textContent = runtime.description;\n+ env.appendChild(item);\n+ });\n+\nthis._dom.find('.lh-footer__version', footer).textContent = report.lighthouseVersion;\n- this._dom.find('.lh-footer__timestamp', footer).textContent =\n- Util.formatDateTime(report.fetchTime);\nreturn footer;\n}\n",
"new_path": "lighthouse-core/report/html/renderer/report-renderer.js",
"old_path": "lighthouse-core/report/html/renderer/report-renderer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -130,7 +130,6 @@ class ReportUIFeatures {\nthis.productInfo = this._dom.find('.lh-product-info', this._document);\nthis.toolbar = this._dom.find('.lh-toolbar', this._document);\nthis.toolbarMetadata = this._dom.find('.lh-toolbar__metadata', this._document);\n- this.env = this._dom.find('.lh-env', this._document);\n// @ts-ignore - TODO: move off CSSOM to support other browsers\nthis.headerHeight = this.headerBackground.computedStyleMap().get('height').value;\n@@ -246,7 +245,6 @@ class ReportUIFeatures {\n// Start showing the productinfo when we are at the 50% mark of our animation\nconst opacity = scrollPct < 0.5 ? 0 : (scrollPct - 0.5) * 2;\nthis.productInfo.style.opacity = this.toolbarMetadata.style.opacity = opacity.toString();\n- this.env.style.transform = `translateY(${Math.max(0, heightDiff * scrollPct - 6)}px)`;\nthis.isAnimatingHeader = false;\n}\n",
"new_path": "lighthouse-core/report/html/renderer/report-ui-features.js",
"old_path": "lighthouse-core/report/html/renderer/report-ui-features.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -314,15 +314,15 @@ class Util {\nreturn [\n{\n- name: 'Device Emulation',\n+ name: 'Device',\ndescription: emulationDesc.deviceEmulation,\n},\n{\n- name: 'Network Throttling',\n+ name: 'Network throttling',\ndescription: emulationDesc.networkThrottling,\n},\n{\n- name: 'CPU Throttling',\n+ name: 'CPU throttling',\ndescription: emulationDesc.cpuThrottling,\n},\n];\n@@ -330,11 +330,12 @@ class Util {\n/**\n* @param {LH.Config.Settings} settings\n- * @return {{deviceEmulation: string, networkThrottling: string, cpuThrottling: string}}\n+ * @return {{deviceEmulation: string, networkThrottling: string, cpuThrottling: string, summary: string}}\n*/\nstatic getEmulationDescriptions(settings) {\nlet cpuThrottling;\nlet networkThrottling;\n+ let summary;\nconst throttling = settings.throttling;\n@@ -342,6 +343,7 @@ class Util {\ncase 'provided':\ncpuThrottling = 'Provided by environment';\nnetworkThrottling = 'Provided by environment';\n+ summary = 'No throttling applied';\nbreak;\ncase 'devtools': {\nconst {cpuSlowdownMultiplier, requestLatencyMs} = throttling;\n@@ -349,6 +351,7 @@ class Util {\nnetworkThrottling = `${Util.formatNumber(requestLatencyMs)}${NBSP}ms HTTP RTT, ` +\n`${Util.formatNumber(throttling.downloadThroughputKbps)}${NBSP}Kbps down, ` +\n`${Util.formatNumber(throttling.uploadThroughputKbps)}${NBSP}Kbps up (DevTools)`;\n+ summary = 'Throttled Fast 3G network';\nbreak;\n}\ncase 'simulate': {\n@@ -356,17 +359,21 @@ class Util {\ncpuThrottling = `${Util.formatNumber(cpuSlowdownMultiplier)}x slowdown (Simulated)`;\nnetworkThrottling = `${Util.formatNumber(rttMs)}${NBSP}ms TCP RTT, ` +\n`${Util.formatNumber(throughputKbps)}${NBSP}Kbps throughput (Simulated)`;\n+ summary = 'Simulated Fast 3G network';\nbreak;\n}\ndefault:\ncpuThrottling = 'Unknown';\nnetworkThrottling = 'Unknown';\n+ summary = 'Unknown';\n}\n+ const deviceEmulation = settings.disableDeviceEmulation ? 'No emulation' : 'Emulated Nexus 5X';\nreturn {\n- deviceEmulation: settings.disableDeviceEmulation ? 'Disabled' : 'Nexus 5X',\n+ deviceEmulation,\ncpuThrottling,\nnetworkThrottling,\n+ summary: `${deviceEmulation}, ${summary}`,\n};\n}\n}\n",
"new_path": "lighthouse-core/report/html/renderer/util.js",
"old_path": "lighthouse-core/report/html/renderer/util.js"
},
{
"change_type": "MODIFY",
"diff": "}\n.lh-scores-wrapper__shadow {\nopacity: 0;\n- border-radius: 4px;\n- box-shadow: rgba(0, 0, 0, 0.2) 0px 4px 2px -2px;\n+ border-radius: 0;\n+ box-shadow: rgba(0, 0, 0, 0.2) 0px 3px 0px -2px\n}\n.lh-scores-container {\npadding-bottom: calc(var(--section-indent) / 2);\ndisplay: none;\n}\n.lh-config {\n- display: flex;\n- }\n- .lh-env {\n- padding: var(--default-padding) 0 var(--default-padding) calc(var(--default-padding) * 2);\n- left: 0;\n- top: 100%;\n- position: absolute;\n- width: 100%;\n- background-color: var(--header-bg-color);\n- font-size: 12px;\n- box-shadow: inset var(--report-border-color) 0px -1px 0px 1px;\n- }\n- .lh-env__items {\n- margin: var(--default-padding) 0 0 0;\n- padding-left: calc(var(--default-padding) * 2);\n+ color: var(--secondary-text-color);\n}\n.lh-config__timestamp {\n- margin-right: 6px;\n- }\n- .lh-config__settings-toggle {\n- margin-left: 6px;\n- }\n- .lh-config__timestamp,\n- .lh-config__settings-toggle summary {\n- color: var(--secondary-text-color);\n+ font-size: var(--caption-font-size);\n+ display: block;\n}\n- .lh-config__settings-toggle summary {\n- display: flex;\n- align-items: center;\n+ a.lh-config__emulation {\n+ color: inherit;\n+ text-decoration: none;\n}\n@media screen and (max-width: 964px) {\n.lh-export__dropdown {\n<div class=\"lh-metadata__results\"><a href=\"\" class=\"lh-metadata__url\" target=\"_blank\" rel=\"noopener\"></a></div>\n<div class=\"lh-config\">\n<span class=\"lh-config__timestamp\"></span>\n- <details class=\"lh-config__settings-toggle\">\n- <summary>\n- <span>Runtime settings</span>\n- </summary>\n- <div class=\"lh-env\">\n- <div class=\"lh-env__title\">Runtime environment</div>\n- <ul class=\"lh-env__items\">\n- <li class=\"lh-env__item\">\n- <span class=\"lh-env__name\">User agent:</span>\n- <b class=\"lh-env__item__ua\"></b>\n- </li>\n- <template id=\"tmpl-lh-env__items\">\n- <li class=\"lh-env__item\">\n- <span class=\"lh-env__name\"></span>:\n- <span class=\"lh-env__description\"></span>\n- </li>\n- </template>\n- </ul>\n- </div>\n- </details>\n+ <a href=\"#runtime-settings\" class=\"lh-config__emulation\"></a>\n</div>\n</div>\n</div>\n<template id=\"tmpl-lh-footer\">\n<style>\n.lh-footer {\n- min-height: 90px;\n- display: flex;\n- align-items: center;\n- justify-content: center;\nbackground-color: var(--header-bg-color);\nborder-top: 1px solid var(--report-secondary-border-color);\n+ padding: var(--section-indent) calc(var(--default-padding) * 2);\n}\n-\n- .lh-footer span {\n+ .lh-footer .lh-generated {\ntext-align: center;\n+ border-top: 1px solid var(--report-border-color);\n+ padding-top: var(--default-padding);\n+ }\n+ .lh-env {\n+ padding: var(--default-padding) 0;\n+ }\n+ .lh-env__items {\n+ padding-left: 16px;\n+ }\n+ span.lh-env__name {\n+ font-weight: bold;\n+ color: var(--secondary-text-color);\n+ }\n+ span.lh-env__description {\n+ font-family: var(--monospace-font-family);\n+ font-size: var(--caption-font-size);\n+ padding-left: 5px;\n}\n</style>\n<footer class=\"lh-footer\">\n- <span>\n- Generated by <b>Lighthouse</b> <span class=\"lh-footer__version\"></span> on\n- <span class=\"lh-footer__timestamp\"></span> |\n+ <div class=\"lh-env\">\n+ <div class=\"lh-env__title\">Runtime settings</div>\n+ <ul class=\"lh-env__items\">\n+ <template id=\"tmpl-lh-env__items\">\n+ <li class=\"lh-env__item\">\n+ <span class=\"lh-env__name\"></span>\n+ <span class=\"lh-env__description\"></span>\n+ </li>\n+ </template>\n+ </ul>\n+ </div>\n+\n+ <div class=\"lh-generated\">\n+ Generated by <b>Lighthouse</b> <span class=\"lh-footer__version\"></span> |\n<a href=\"https://github.com/GoogleChrome/Lighthouse/issues\" target=\"_blank\" rel=\"noopener\">File an issue</a>\n- </span>\n+ </div>\n</footer>\n</template>\n",
"new_path": "lighthouse-core/report/html/templates.html",
"old_path": "lighthouse-core/report/html/templates.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -54,7 +54,7 @@ describe('DOM', () => {\n});\nit('should clone a template from a context scope', () => {\n- const heading = dom.cloneTemplate('#tmpl-lh-heading', dom.document());\n+ const heading = dom.cloneTemplate('#tmpl-lh-footer', dom.document());\nconst items = dom.cloneTemplate('#tmpl-lh-env__items', heading);\nassert.ok(items.querySelector('.lh-env__item'));\n});\n",
"new_path": "lighthouse-core/test/report/html/renderer/dom-test.js",
"old_path": "lighthouse-core/test/report/html/renderer/dom-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -101,19 +101,6 @@ describe('ReportRenderer', () => {\nconst url = header.querySelector('.lh-metadata__url');\nassert.equal(url.textContent, sampleResults.finalUrl);\nassert.equal(url.href, sampleResults.finalUrl);\n-\n- const userAgent = header.querySelector('.lh-env__item__ua');\n- assert.equal(userAgent.textContent, sampleResults.userAgent, 'user agent populated');\n-\n- // Check runtime settings were populated.\n- const names = Array.from(header.querySelectorAll('.lh-env__name')).slice(1);\n- const descriptions = Array.from(header.querySelectorAll('.lh-env__description'));\n- assert.equal(names.length, 3);\n- assert.equal(descriptions.length, 3);\n- const descriptionsTxt = descriptions.map(el => el.textContent).join('\\n');\n- assert.ok(/Nexus/.test(descriptionsTxt), 'should have added device emulation');\n- assert.ok(/RTT/.test(descriptionsTxt), 'should have added network');\n- assert.ok(/\\dx/.test(descriptionsTxt), 'should have added CPU');\n});\nit('should not mutate a report object', () => {\n@@ -144,6 +131,18 @@ describe('ReportRenderer', () => {\nconst footerContent = footer.querySelector('.lh-footer').textContent;\nassert.ok(/Generated by Lighthouse \\d/.test(footerContent), 'includes lh version');\nassert.ok(footerContent.match(TIMESTAMP_REGEX), 'includes timestamp');\n+\n+ // Check runtime settings were populated.\n+ const names = Array.from(footer.querySelectorAll('.lh-env__name'));\n+ const descriptions = Array.from(footer.querySelectorAll('.lh-env__description'));\n+ assert.ok(names.length >= 3);\n+ assert.ok(descriptions.length >= 3);\n+\n+ const descriptionsTxt = descriptions.map(el => el.textContent).join('\\n');\n+ assert.ok(/Nexus/.test(descriptionsTxt), 'should have added device emulation');\n+ assert.ok(/RTT/.test(descriptionsTxt), 'should have added network');\n+ assert.ok(/\\dx/.test(descriptionsTxt), 'should have added CPU');\n+ assert.ok(descriptionsTxt.includes(sampleResults.userAgent), 'user agent populated');\n});\n});\n",
"new_path": "lighthouse-core/test/report/html/renderer/report-renderer-test.js",
"old_path": "lighthouse-core/test/report/html/renderer/report-renderer-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -70,8 +70,8 @@ describe('util helpers', () => {\nit('builds device emulation string', () => {\nconst get = opts => Util.getEmulationDescriptions(opts).deviceEmulation;\n- assert.equal(get({disableDeviceEmulation: true}), 'Disabled');\n- assert.equal(get({disableDeviceEmulation: false}), 'Nexus 5X');\n+ assert.equal(get({disableDeviceEmulation: true}), 'No emulation');\n+ assert.equal(get({disableDeviceEmulation: false}), 'Emulated Nexus 5X');\n});\nit('builds throttling strings when provided', () => {\n",
"new_path": "lighthouse-core/test/report/html/renderer/util-test.js",
"old_path": "lighthouse-core/test/report/html/renderer/util-test.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | report: move runtime settings to footer (#5295) | 1 | report | null |
730,413 | 22.05.2018 15:58:07 | 14,400 | 708cf7e9b8c2820ecc7aef097e1c7def7832c02e | feat(react-container-notifications): filter notifications with alertType none | [
{
"change_type": "MODIFY",
"diff": "@@ -20,7 +20,7 @@ import {\nconst TIMEOUT_LENGTH = 10000;\nconst propTypes = {\n- notifications: PropTypes.object,\n+ notifications: PropTypes.array,\nisSupported: PropTypes.bool,\nisMuted: PropTypes.bool,\npermission: PropTypes.string,\n@@ -105,12 +105,12 @@ export class Notifications extends Component {\nnotifications, onEvent, permission, isMuted\n} = this.props;\nconst hasPermission = permission === browserUtilities.PERMISSION_GRANTED;\n- if (notifications && notifications.count() > 0) {\n+ if (notifications && notifications.length > 0) {\nnotifications.forEach((notification) => {\nconst {\n- username, message, avatar, notificationId\n+ username, message, avatar, notificationId, alertType\n} = notification;\n- if (!isMuted && hasPermission && browserUtilities.isBrowserHidden()) {\n+ if (alertType !== 'none' && !isMuted && hasPermission && browserUtilities.isBrowserHidden()) {\n// Actually display notification\nconst n = browserUtilities.spawnNotification(message, avatar, username, TIMEOUT_LENGTH);\n// If there is an onEvent method\n",
"new_path": "packages/node_modules/@ciscospark/react-container-notifications/src/container.js",
"old_path": "packages/node_modules/@ciscospark/react-container-notifications/src/container.js"
},
{
"change_type": "MODIFY",
"diff": "/* eslint-disable-reason needed for component tests */\n/* eslint-disable no-param-reassign */\n-import {Map, fromJS} from 'immutable';\nimport {Notifications} from './container';\nimport browserUtilities from './browserUtils';\nfunction displayNotification(component, notification) {\n- component.props.notifications = fromJS([notification]);\n+ component.props.notifications = [notification];\ncomponent.props.permission = browserUtilities.PERMISSION_GRANTED;\nbrowserUtilities.isBrowserHidden = jest.fn(() => true);\nbrowserUtilities.spawnNotification = jest.fn(() => ({\n@@ -24,12 +23,7 @@ describe('Notifications component', () => {\nlet setNotificationPermission;\nlet setNotificationSupported;\nlet onEvent;\n- const notification = {\n- username: 'username',\n- message: 'message',\n- avatar: 'avatar',\n- notificationId: 'abc123'\n- };\n+ let notification;\nbeforeEach(() => {\nnotificationSent = jest.fn();\n@@ -38,7 +32,7 @@ describe('Notifications component', () => {\nonEvent = jest.fn();\nprops = {\nisSupported: false,\n- notifications: new Map(),\n+ notifications: [],\nonEvent,\npermission: null,\nisMuted: false,\n@@ -46,6 +40,13 @@ describe('Notifications component', () => {\nsetNotificationPermission,\nsetNotificationSupported\n};\n+ notification = {\n+ username: 'username',\n+ message: 'message',\n+ avatar: 'avatar',\n+ notificationId: 'abc123',\n+ alertType: 'full'\n+ };\ncomponent = new Notifications(props);\n});\n@@ -80,7 +81,7 @@ describe('Notifications component', () => {\n});\nit('should mark notification as sent after displaying', () => {\n- component.props.notifications = fromJS([notification]);\n+ component.props.notifications = [notification];\ncomponent.permission = browserUtilities.PERMISSION_GRANTED;\ncomponent.displayNotifications();\nexpect(notificationSent).toBeCalled();\n@@ -97,6 +98,12 @@ describe('Notifications component', () => {\nexpect(browserUtilities.spawnNotification).not.toBeCalled();\n});\n+ it('should not display the notification if alertType is none', () => {\n+ notification.alertType = 'none';\n+ displayNotification(component, notification);\n+ expect(browserUtilities.spawnNotification).not.toBeCalled();\n+ });\n+\nit('should trigger onEvent when notification is created', () => {\ndisplayNotification(component, notification);\nexpect(onEvent).toBeCalled();\n",
"new_path": "packages/node_modules/@ciscospark/react-container-notifications/src/container.test.js",
"old_path": "packages/node_modules/@ciscospark/react-container-notifications/src/container.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -7,12 +7,16 @@ const getUnsentNotifications = createSelector(\n[getNotifications],\n(notifications) =>\nnotifications\n+ .toArray()\n.map((notification) => {\n- const {username, message, avatar} = notification.details;\n+ const {\n+ username, message, avatar, alertType\n+ } = notification.details;\nreturn Object.assign({}, notification, {\nusername,\nmessage,\n- avatar\n+ avatar,\n+ alertType\n});\n})\n);\n",
"new_path": "packages/node_modules/@ciscospark/react-container-notifications/src/selectors.js",
"old_path": "packages/node_modules/@ciscospark/react-container-notifications/src/selectors.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -61,7 +61,7 @@ export default function wrapConversationMercury(WrappedComponent) {\n*/\nlistenToNewActivity(conversationId, sparkInstance) {\nsparkInstance.internal.mercury.on('event:conversation.activity', (event) => {\n- const {activity} = event.data;\n+ const activity = Object.assign({alertType: event.alertType}, event.data.activity);\n// Ignore activity from other conversations\nif (activity.target && activity.target.id === conversationId) {\nif (activity.object.objectType === 'activity') {\n",
"new_path": "packages/node_modules/@ciscospark/react-hoc-conversation-mercury/src/index.js",
"old_path": "packages/node_modules/@ciscospark/react-hoc-conversation-mercury/src/index.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -202,7 +202,8 @@ export class MessageWidget extends Component {\nconst details = {\nusername: lastActivityFromThis.actor.displayName,\nmessage: lastActivityFromThis.object.displayName,\n- avatar: avatars.get(lastActivityFromThis.actor.id)\n+ avatar: avatars.get(lastActivityFromThis.actor.id),\n+ alertType: lastActivityFromThis.alertType\n};\nprops.createNotification(lastActivityFromThis.id, details);\n}\n",
"new_path": "packages/node_modules/@ciscospark/widget-message/src/container.js",
"old_path": "packages/node_modules/@ciscospark/widget-message/src/container.js"
}
] | JavaScript | MIT License | webex/react-widgets | feat(react-container-notifications): filter notifications with alertType none | 1 | feat | react-container-notifications |
217,922 | 22.05.2018 19:07:28 | -7,200 | 0a18197ba877802bbcbda4783585c569a7f27350 | feat: new foods added to simulator | [
{
"change_type": "MODIFY",
"diff": "@@ -81,4 +81,8 @@ export const foods = [{'itemId': 4666, 'Control': [{'amount': 0.08, 'max': 4}, {\n'itemId': 19837,\n'Control': [{'amount': 0.1, 'max': 99}, {'amount': 0.12, 'max': 124}],\n'Craftsmanship': [{'amount': 0.04, 'max': 42}, {'amount': 0.05, 'max': 53}]\n+}, {\n+ 'itemId': 23187,\n+ 'CP': [{'amount': 0.12, 'max': 45}, {'amount': 0.15, 'max': 56}],\n+ 'Control': [{'amount': 0.04, 'max': 49}, {'amount': 0.05, 'max': 61}]\n}];\n",
"new_path": "src/app/core/data/sources/foods.ts",
"old_path": "src/app/core/data/sources/foods.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: new foods added to simulator | 1 | feat | null |
217,922 | 23.05.2018 08:41:17 | -7,200 | fc17369a06bc4d2cf30c05039bf913e451cfafa6 | fix(simulator): consumables are now order by name, hq first | [
{
"change_type": "MODIFY",
"diff": "@@ -229,23 +229,28 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nprivate userData: AppUser;\n+ private consumablesSortFn = (a, b) => {\n+ const aName = this.i18nTools.getName(this.localizedDataService.getItem(a.itemId));\n+ const bName = this.i18nTools.getName(this.localizedDataService.getItem(b.itemId));\n+ if (aName > bName) {\n+ return 1\n+ } else if (aName < bName) {\n+ return -1\n+ } else {\n+ // If they're both the same item, HQ first\n+ return a.hq ? -1 : 1;\n+ }\n+ };\n+\nconstructor(private registry: CraftingActionsRegistry, private media: ObservableMedia, private userService: UserService,\nprivate dataService: DataService, private htmlTools: HtmlToolsService, private dialog: MatDialog,\nprivate pendingChanges: PendingChangesService, private localizedDataService: LocalizedDataService,\n- private translate: TranslateService, consumablesService: ConsumablesService, i18nTools: I18nToolsService) {\n+ private translate: TranslateService, consumablesService: ConsumablesService, private i18nTools: I18nToolsService) {\nthis.foods = consumablesService.fromData(foods)\n- .sort((a, b) => {\n- const aName = i18nTools.getName(this.localizedDataService.getItem(a.itemId));\n- const bName = i18nTools.getName(this.localizedDataService.getItem(b.itemId));\n- return aName > bName || !a.hq ? 1 : -1;\n- });\n+ .sort(this.consumablesSortFn);\nthis.medicines = consumablesService.fromData(medicines)\n- .sort((a, b) => {\n- const aName = i18nTools.getName(this.localizedDataService.getItem(a.itemId));\n- const bName = i18nTools.getName(this.localizedDataService.getItem(b.itemId));\n- return aName > bName || !a.hq ? 1 : -1;\n- });\n+ .sort(this.consumablesSortFn);\nthis.actions$.subscribe(actions => {\nthis.dirty = false;\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): consumables are now order by name, hq first | 1 | fix | simulator |
217,922 | 23.05.2018 09:26:17 | -7,200 | 686027398176df0ece62236faa61fd04409d2dea | fix(desktop): only one instance can run at a given time now
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -19,6 +19,19 @@ let nativeIcon;\nlet openedOverlays = {};\n+const shouldQuit = app.makeSingleInstance(function (commandLine, workingDirectory) {\n+ // Someone tried to run a second instance, we should focus our window.\n+ if (win) {\n+ if (win.isMinimized()) win.restore();\n+ win.focus();\n+ }\n+});\n+\n+if (shouldQuit) {\n+ app.quit();\n+ return;\n+}\n+\nfunction createWindow() {\n// Load the previous state with fallback to defaults\n",
"new_path": "main.js",
"old_path": "main.js"
},
{
"change_type": "MODIFY",
"diff": "\"electron:setup:build\": \"del-cli release/* && npm run build:electron-prod && electron-builder\",\n\"electron:setup:publish\": \"del-cli release/* && npm run build:electron-prod && electron-builder -p always\",\n\"postinstall\": \"electron-builder install-app-deps\",\n- \"release:full\": \"npm run build:prod && firebase deploy -P default --only hosting && npm run electron:setup:publish\"\n+ \"release:full\": \"npm run build:prod && firebase deploy -P default --only hosting && npm run electron:setup:publish\",\n+ \"pack\": \"electron-builder --dir\"\n},\n\"private\": true,\n\"dependencies\": {\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(desktop): only one instance can run at a given time now
closes #353 | 1 | fix | desktop |
217,922 | 23.05.2018 10:07:03 | -7,200 | d7628b921808f3c3328bb7d49d9b2b4541b441bb | fix: facebook oauth (mainly config on fb side) | [
{
"change_type": "MODIFY",
"diff": "const {app, ipcMain, BrowserWindow, Tray, nativeImage} = require('electron');\nconst {autoUpdater} = require('electron-updater');\n-const open = require('open');\nconst path = require('path');\nconst windowStateKeeper = require('electron-window-state');\nconst electronOauth2 = require('electron-oauth2');\n-let win, serve;\n-const args = process.argv.slice(1);\n-serve = args.some(val => val === '--serve');\n-\n-if (serve) {\n- require('electron-reload')(__dirname, {});\n-}\n-\n+let win;\nlet tray;\nlet nativeIcon;\n",
"new_path": "main.js",
"old_path": "main.js"
},
{
"change_type": "MODIFY",
"diff": "\"ng-push\": \"^0.2.1\",\n\"ngx-clipboard\": \"11.0.0\",\n\"ngx-markdown\": \"^1.6.0\",\n- \"open\": \"0.0.5\",\n\"rxjs\": \"^6.1.0\",\n\"semver\": \"^5.4.1\",\n\"web-animations-js\": \"^2.3.1\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: facebook oauth (mainly config on fb side) | 1 | fix | null |
217,922 | 23.05.2018 10:37:33 | -7,200 | c2b8c96309335c0a45cb2a3f5435a1710e2e55e9 | fix(simulator): fixed a bug with rotations being renamed upon saving | [
{
"change_type": "MODIFY",
"diff": "<app-simulator [recipe]=\"recipe\" [inputGearSet]=\"stats\" [actions]=\"actions\"\n[customMode]=\"true\" [canSave]=\"canSave\" [rotationId]=\"rotationId\"\n- (onsave)=\"save($event)\"></app-simulator>\n+ (onsave)=\"save($event)\" [rotationName]=\"rotationName\"></app-simulator>\n</div>\n<ng-template #notFoundTemplate>\n",
"new_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.html",
"old_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -37,6 +37,8 @@ export class CustomSimulatorPageComponent {\npublic notFound = false;\n+ public rotationName: string;\n+\nconstructor(private userService: UserService, private rotationsService: CraftingRotationService,\nprivate router: Router, activeRoute: ActivatedRoute, private registry: CraftingActionsRegistry) {\n@@ -58,6 +60,7 @@ export class CustomSimulatorPageComponent {\nthis.stats = res.rotation.stats;\nthis.canSave = res.userId === res.rotation.authorId;\nthis.rotationId = res.rotation.$key;\n+ this.rotationName = res.rotation.getName();\n}, () => this.notFound = true);\n}\n@@ -72,7 +75,7 @@ export class CustomSimulatorPageComponent {\nresult.authorId = userId;\nresult.recipe = rotation.recipe;\nresult.description = '';\n- result.name = '';\n+ result.name = rotation.name;\nreturn result;\n}),\nmergeMap(preparedRotation => {\n",
"new_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "<div *ngIf=\"recipe$ | async as recipe; else loading\">\n<app-simulator [recipe]=\"recipe\" [actions]=\"actions\" [itemId]=\"itemId\" [itemIcon]=\"itemIcon\" [canSave]=\"canSave\"\n[rotationId]=\"rotationId\" (onsave)=\"save($event)\" [selectedFood]=\"selectedFood\"\n- [selectedMedicine]=\"selectedMedicine\"></app-simulator>\n+ [selectedMedicine]=\"selectedMedicine\" [rotationName]=\"rotationName\"></app-simulator>\n</div>\n</div>\n<ng-template #loading>\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.html",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -35,6 +35,8 @@ export class SimulatorPageComponent {\npublic rotationId: string;\n+ public rotationName: string;\n+\npublic selectedFood: Consumable;\npublic selectedMedicine: Consumable;\n@@ -84,6 +86,7 @@ export class SimulatorPageComponent {\nthis.rotationId = res.rotation.$key;\nthis.selectedFood = res.rotation.consumables.food;\nthis.selectedMedicine = res.rotation.consumables.medicine;\n+ this.rotationName = res.rotation.getName();\n}, () => this.notFound = true);\n}\n@@ -98,7 +101,7 @@ export class SimulatorPageComponent {\nresult.authorId = userId;\nresult.recipe = rotation.recipe;\nresult.description = '';\n- result.name = '';\n+ result.name = rotation.name;\nresult.consumables = rotation.consumables;\nreturn {rotation: result, userId: userId};\n}),\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -186,6 +186,9 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n@Input()\npublic rotationId: string;\n+ @Input()\n+ public rotationName: string;\n+\npublic hqIngredientsData: { id: number, amount: number, max: number, quality: number }[] = [];\npublic foods: Consumable[] = [];\n@@ -407,6 +410,7 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nif (!this.customMode) {\nthis.onsave.emit({\n$key: this.rotationId,\n+ name: this.rotationName,\nrotation: this.serializedRotation,\nrecipe: this.recipeSync,\nconsumables: {food: this._selectedFood, medicine: this._selectedMedicine}\n@@ -414,6 +418,7 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n} else {\nthis.onsave.emit(<CustomCraftingRotation>{\n$key: this.rotationId,\n+ name: this.rotationName,\nstats: this.selectedSet,\nrotation: this.serializedRotation,\nrecipe: this.recipeSync,\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): fixed a bug with rotations being renamed upon saving | 1 | fix | simulator |
791,834 | 23.05.2018 12:23:38 | 25,200 | e04b29d2fc7b863cc0bfea526104e72147991159 | extension: another speculative fix for getCurrentTabURL; more logging | [
{
"change_type": "MODIFY",
"diff": "@@ -122,14 +122,23 @@ class ExtensionConnection extends Connection {\nif (chrome.runtime.lastError) {\nreturn reject(chrome.runtime.lastError);\n}\n+\n+ const errMessage = 'Couldn\\'t resolve current tab. Check your URL, reload, and try again.';\nif (tabs.length === 0) {\n- const message = 'Couldn\\'t resolve current tab. Check your URL, reload, and try again.';\n- return reject(new Error(message));\n+ return reject(new Error(errMessage));\n}\nif (tabs.length > 1) {\nlog.warn('ExtensionConnection', '_queryCurrentTab returned multiple tabs');\n}\n- resolve(tabs[0]);\n+\n+ const firstUrledTab = tabs.find(tab => !!tab.url);\n+ if (!firstUrledTab) {\n+ const tabIds = tabs.map(tab => tab.id).join(', ');\n+ const message = errMessage + ` Found ${tabs.length} tab(s) with id(s) [${tabIds}].`;\n+ return reject(new Error(message));\n+ }\n+\n+ resolve(firstUrledTab);\n}));\n});\n}\n",
"new_path": "lighthouse-core/gather/connections/extension.js",
"old_path": "lighthouse-core/gather/connections/extension.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -40,7 +40,7 @@ class Runner {\n// save the requestedUrl provided by the user\nconst rawRequestedUrl = opts.url;\nif (typeof rawRequestedUrl !== 'string' || rawRequestedUrl.length === 0) {\n- throw new Error('You must provide a url to the runner');\n+ throw new Error(`You must provide a url to the runner. '${rawRequestedUrl}' provided.`);\n}\nlet parsedURL;\n",
"new_path": "lighthouse-core/runner.js",
"old_path": "lighthouse-core/runner.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | extension: another speculative fix for getCurrentTabURL; more logging (#5323) | 1 | extension | null |
217,922 | 23.05.2018 13:29:02 | -7,200 | 00dd1a7ea5d44262a52dbe8550daaf08be193f43 | chore: updated version requirement for outdated list trigger | [
{
"change_type": "MODIFY",
"diff": "@@ -370,7 +370,7 @@ export class List extends DataWithPermissions {\n}\nlet res = false;\nres = res || (this.version === undefined);\n- res = res || semver.ltr(this.version, '3.9.0');\n+ res = res || semver.ltr(this.version, '4.0.5');\nreturn res;\n}\n",
"new_path": "src/app/model/list/list.ts",
"old_path": "src/app/model/list/list.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: updated version requirement for outdated list trigger | 1 | chore | null |
730,429 | 23.05.2018 13:41:08 | 14,400 | 200e29d3ef6cb255b638eb914e5be7d7dd7ba0bb | chore(webpack): add ability to specify dev server port | [
{
"change_type": "MODIFY",
"diff": "@@ -32,7 +32,7 @@ export default webpackConfigBase({\ndevtool: 'source-map',\ndevServer: {\nhost: '0.0.0.0',\n- port: 8000,\n+ port: process.env.PORT || 8000,\nstats: {\ncolors: true,\nhash: false,\n",
"new_path": "scripts/webpack/webpack.dev.babel.js",
"old_path": "scripts/webpack/webpack.dev.babel.js"
}
] | JavaScript | MIT License | webex/react-widgets | chore(webpack): add ability to specify dev server port | 1 | chore | webpack |
730,429 | 23.05.2018 13:41:54 | 14,400 | e9b16bcb75da4428cdec7990569aa45659b98c18 | fix(r-c-read-receipts): add support for empty activities | [
{
"change_type": "MODIFY",
"diff": "@@ -19,7 +19,7 @@ const getReadReceipts = createSelector(\nconst activity = activities.last();\nconst readParticipants = participants\n.filter((participant) =>\n- participant.get('id') !== currentUser.id &&\n+ activity && currentUser && participant.get('id') !== currentUser.id &&\nparticipant.getIn(['roomProperties', 'lastSeenActivityUUID']) === activity.id)\n.toJS();\n",
"new_path": "packages/node_modules/@ciscospark/react-container-read-receipts/src/selectors.js",
"old_path": "packages/node_modules/@ciscospark/react-container-read-receipts/src/selectors.js"
}
] | JavaScript | MIT License | webex/react-widgets | fix(r-c-read-receipts): add support for empty activities | 1 | fix | r-c-read-receipts |
791,690 | 23.05.2018 14:16:21 | 25,200 | 55983025d5f6a7d48ebae9376a2632be74a01a7b | extension: expose URL shim | [
{
"change_type": "MODIFY",
"diff": "@@ -132,6 +132,7 @@ class URLShim extends URL {\n}\n}\n+URLShim.URL = URL;\nURLShim.URLSearchParams = (typeof self !== 'undefined' && self.URLSearchParams) ||\nrequire('url').URLSearchParams;\n",
"new_path": "lighthouse-core/lib/url-shim.js",
"old_path": "lighthouse-core/lib/url-shim.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -141,6 +141,12 @@ gulp.task('browserify-lighthouse', () => {\nbundle = bundle.require(artifact, {expose: artifact.replace(corePath, './')});\n});\n+ // browerify's url shim doesn't work with .URL in node_modules,\n+ // and within robots-parser, it does `var URL = require('url').URL`, so we expose our own.\n+ // @see https://github.com/GoogleChrome/lighthouse/issues/5273\n+ const pathToURLShim = require.resolve('../lighthouse-core/lib/url-shim.js');\n+ bundle = bundle.require(pathToURLShim, {expose: 'url'});\n+\n// Inject the new browserified contents back into our gulp pipeline\nfile.contents = bundle.bundle();\n}))\n",
"new_path": "lighthouse-extension/gulpfile.js",
"old_path": "lighthouse-extension/gulpfile.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -170,4 +170,9 @@ describe('Lighthouse chrome extension', function() {\nconst errors = auditErrors.filter(item => item.debugString.includes('Audit error:'));\nassert.deepStrictEqual(errors, [], 'Audit errors found within the report');\n});\n+\n+ it('should pass the is-crawlable audit', async () => {\n+ // this audit has regressed in the extension twice, so make sure it passes\n+ assert.ok(await extensionPage.$('#is-crawlable.lh-audit--pass'), 'did not pass is-crawlable');\n+ });\n});\n",
"new_path": "lighthouse-extension/test/extension-test.js",
"old_path": "lighthouse-extension/test/extension-test.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | extension: expose URL shim (#5293) | 1 | extension | null |
217,941 | 23.05.2018 14:28:22 | -7,200 | 155dfd77aaee08694c9d51bdcada42a49c9041bc | feat: added 4.3 currencies | [
{
"change_type": "MODIFY",
"diff": "@@ -102,6 +102,7 @@ export class ItemComponent extends ComponentWithSubscriptions implements OnInit,\n21080: 13, // Moogle\n21081: 13, // Kojin\n21935: 13, // Ananta\n+ 22525: 13, // Namazu\n// Primals\n7004: 10, // Weekly quest Garuda/Titan/Ifrit\n7850: 10, // Leviathan\n@@ -117,6 +118,7 @@ export class ItemComponent extends ComponentWithSubscriptions implements OnInit,\n19110: 10, // Lakshmi\n21196: 10, // Shinryu\n21773: 10, // Byakko\n+ 23043: 10, // Tsukuyomi\n// Raids\n7577: 8, // Sands of Time\n7578: 8, // Oil of Time\n@@ -203,6 +205,7 @@ export class ItemComponent extends ComponentWithSubscriptions implements OnInit,\n21783: 8, // Sigmascape Datalog v3.0\n21784: 8, // Sigmascape Datalog v4.0\n21785: 8, // Sigmascape Crystalloid\n+ 23174: 8, // Gougan Coin\n// World bosses\n6155: 5, // Behemoth\n6164: 5, // Odin\n",
"new_path": "src/app/modules/item/item/item.component.ts",
"old_path": "src/app/modules/item/item/item.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: added 4.3 currencies (#356) | 1 | feat | null |
791,690 | 23.05.2018 15:19:51 | 25,200 | 7157f0a12d435d4765bb752fde198235fdbd5a47 | misc: remove checkboxes from bug report template | [
{
"change_type": "MODIFY",
"diff": "---\nname: Bug report\n-about: File an issue ticket to help us improve\n+about: Report something working incorrectly\n---\n<!-- Before creating an issue please make sure you are using the latest version and have checked for duplicate issues. -->\n-# Bug report\n+## Bug report\n-**Provide the steps to reproduce.**\n+#### Provide the steps to reproduce\n1. Run LH on <affected url>\n-**What is the current behavior?**\n+#### What is the current behavior?\n-**What is the expected behavior?**\n+#### What is the expected behavior?\n-**Environment Information**:\n-Affected Channels:\n-- [ ] CLI\n-- [ ] Node Module\n-- [ ] Extension\n-- [ ] DevTools\n-\n-Lighthouse version:\n-Node.js version:\n-Operating System:\n+#### Environment Information\n+* Affected Channels: <!-- CLI, Node, Extension, DevTools -->\n+* Lighthouse version:\n+* Node.js version:\n+* Operating System:\n**Related issues**\n",
"new_path": ".github/ISSUE_TEMPLATE/Bug_report.md",
"old_path": ".github/ISSUE_TEMPLATE/Bug_report.md"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | misc: remove checkboxes from bug report template (#5330) | 1 | misc | null |
791,690 | 23.05.2018 16:26:30 | 25,200 | e523e2d0c097bb334923db887f1889a67942951f | misc(scripts): add lantern evaluation scripts | [
{
"change_type": "MODIFY",
"diff": "@@ -31,6 +31,7 @@ last-run-results.html\n!lighthouse-core/test/fixtures/artifacts/**/*.devtoolslog.json\nlatest-run\n+lantern-data\nclosure-error.log\nyarn-error.log\n",
"new_path": ".gitignore",
"old_path": ".gitignore"
},
{
"change_type": "MODIFY",
"diff": "@@ -31,6 +31,7 @@ lighthouse-cli/types/*.map\nnode_modules/\nresults/\n+lantern-data/\nplots/\n",
"new_path": ".npmignore",
"old_path": ".npmignore"
},
{
"change_type": "MODIFY",
"diff": "@@ -82,7 +82,7 @@ class PredictivePerf extends Audit {\nscore,\nrawValue: values.roughEstimateOfTTI,\ndisplayValue: Util.formatMilliseconds(values.roughEstimateOfTTI),\n- extendedInfo: {value: values},\n+ details: {items: [values]},\n};\n}\n}\n",
"new_path": "lighthouse-core/audits/predictive-perf.js",
"old_path": "lighthouse-core/audits/predictive-perf.js"
},
{
"change_type": "ADD",
"diff": "+#!/bin/bash\n+\n+DIRNAME=\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" && pwd )\"\n+LH_ROOT_PATH=\"$DIRNAME/../../..\"\n+cd $LH_ROOT_PATH\n+\n+# snapshot of ~100 traces with no throttling recorded 2017-12-06 on a HP z840 workstation\n+TAR_URL=\"https://drive.google.com/a/chromium.org/uc?id=1_w2g6fQVLgHI62FApsyUDejZyHNXMLm0&export=download\"\n+curl -o lantern-traces.tar.gz -L $TAR_URL\n+\n+tar -xzf lantern-traces.tar.gz\n+mv lantern-traces-subset lantern-data\n+rm lantern-traces.tar.gz\n",
"new_path": "lighthouse-core/scripts/lantern/download-traces.sh",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+#!/usr/bin/env node\n+/**\n+ * @license Copyright 2018 Google Inc. All Rights Reserved.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n+ */\n+'use strict';\n+\n+/* eslint-disable no-console */\n+\n+const path = require('path');\n+\n+const GOOD_ABSOLUTE_THRESHOLD = 0.2;\n+const OK_ABSOLUTE_THRESHOLD = 0.5;\n+\n+const GOOD_RANK_THRESHOLD = 0.1;\n+\n+if (!process.argv[2]) throw new Error('Usage $0 <computed summary file>');\n+\n+const COMPUTATIONS_PATH = path.resolve(process.cwd(), process.argv[2]);\n+/** @type {{sites: LanternSiteDefinition[]}} */\n+const expectations = require(COMPUTATIONS_PATH);\n+\n+const entries = expectations.sites.filter(site => site.lantern);\n+\n+if (!entries.length) {\n+ throw new Error('No lantern metrics available, did you run run-all-expectations.js');\n+}\n+\n+/** @type {LanternEvaluation[]} */\n+const totalGood = [];\n+/** @type {LanternEvaluation[]} */\n+const totalOk = [];\n+/** @type {LanternEvaluation[]} */\n+const totalBad = [];\n+\n+/**\n+ * @param {keyof LanternSiteDefinition} metric\n+ * @param {keyof LanternMetrics} lanternMetric\n+ */\n+function evaluateBuckets(metric, lanternMetric) {\n+ const good = [];\n+ const ok = [];\n+ const bad = [];\n+\n+ // @ts-ignore\n+ const sortedByMetric = entries.slice().sort((a, b) => a[metric] - b[metric]);\n+ const sortedByLanternMetric = entries\n+ .slice()\n+ .sort((a, b) => a.lantern[lanternMetric] - b.lantern[lanternMetric]);\n+\n+ const rankErrors = [];\n+ const percentErrors = [];\n+ for (const entry of entries) {\n+ // @ts-ignore\n+ const expected = Math.round(entry[metric]);\n+ if (expected === 0) continue;\n+\n+ const expectedRank = sortedByMetric.indexOf(entry);\n+ const actual = Math.round(entry.lantern[lanternMetric]);\n+ const actualRank = sortedByLanternMetric.indexOf(entry);\n+ const diff = Math.abs(actual - expected);\n+ const diffAsPercent = diff / expected;\n+ const rankDiff = Math.abs(expectedRank - actualRank);\n+ const rankDiffAsPercent = rankDiff / entries.length;\n+\n+ rankErrors.push(rankDiffAsPercent);\n+ percentErrors.push(diffAsPercent);\n+ const evaluation = {...entry, expected, actual, diff, rankDiff, rankDiffAsPercent, metric};\n+ if (diffAsPercent < GOOD_ABSOLUTE_THRESHOLD || rankDiffAsPercent < GOOD_RANK_THRESHOLD) {\n+ good.push(evaluation);\n+ } else if (diffAsPercent < OK_ABSOLUTE_THRESHOLD) {\n+ ok.push(evaluation);\n+ } else bad.push(evaluation);\n+ }\n+\n+ if (lanternMetric.includes('roughEstimate')) {\n+ totalGood.push(...good);\n+ totalOk.push(...ok);\n+ totalBad.push(...bad);\n+ }\n+\n+ const MAPE = Math.round(percentErrors.reduce((x, y) => x + y) / percentErrors.length * 1000) / 10;\n+ const rank = Math.round(rankErrors.reduce((x, y) => x + y) / rankErrors.length * 1000) / 10;\n+ const buckets = `${good.length}/${ok.length}/${bad.length}`;\n+ console.log(\n+ metric.padEnd(30),\n+ lanternMetric.padEnd(25),\n+ `${rank}%`.padEnd(12),\n+ `${MAPE}%`.padEnd(10),\n+ buckets.padEnd(15)\n+ );\n+}\n+\n+console.log('---- Metric Stats ----');\n+console.log(\n+ 'metric'.padEnd(30),\n+ 'estimate'.padEnd(25),\n+ 'rank error'.padEnd(12),\n+ 'MAPE'.padEnd(10),\n+ 'Good/OK/Bad'.padEnd(15)\n+);\n+evaluateBuckets('firstContentfulPaint', 'optimisticFCP');\n+evaluateBuckets('firstContentfulPaint', 'pessimisticFCP');\n+evaluateBuckets('firstContentfulPaint', 'roughEstimateOfFCP');\n+\n+evaluateBuckets('firstMeaningfulPaint', 'optimisticFMP');\n+evaluateBuckets('firstMeaningfulPaint', 'pessimisticFMP');\n+evaluateBuckets('firstMeaningfulPaint', 'roughEstimateOfFMP');\n+\n+evaluateBuckets('timeToFirstInteractive', 'optimisticTTFCPUI');\n+evaluateBuckets('timeToFirstInteractive', 'pessimisticTTFCPUI');\n+evaluateBuckets('timeToFirstInteractive', 'roughEstimateOfTTFCPUI');\n+\n+evaluateBuckets('timeToConsistentlyInteractive', 'optimisticTTI');\n+evaluateBuckets('timeToConsistentlyInteractive', 'pessimisticTTI');\n+evaluateBuckets('timeToConsistentlyInteractive', 'roughEstimateOfTTI');\n+\n+evaluateBuckets('speedIndex', 'optimisticSI');\n+evaluateBuckets('speedIndex', 'pessimisticSI');\n+evaluateBuckets('speedIndex', 'roughEstimateOfSI');\n+\n+const total = totalGood.length + totalOk.length + totalBad.length;\n+console.log('\\n---- Summary Stats ----');\n+console.log(`Good: ${Math.round(totalGood.length / total * 100)}%`);\n+console.log(`OK: ${Math.round(totalOk.length / total * 100)}%`);\n+console.log(`Bad: ${Math.round(totalBad.length / total * 100)}%`);\n+\n+console.log('\\n---- Worst10 Sites ----');\n+for (const entry of totalBad.sort((a, b) => b.rankDiff - a.rankDiff).slice(0, 10)) {\n+ console.log(\n+ entry.actual < entry.expected ? 'underestimated' : 'overestimated',\n+ entry.metric,\n+ 'by',\n+ Math.round(entry.diff),\n+ 'on',\n+ entry.url\n+ );\n+}\n+\n+/**\n+ * @typedef LanternSiteDefinition\n+ * @property {string} url\n+ * @property {string} tracePath\n+ * @property {string} devtoolsLogPath\n+ * @property {LanternMetrics} lantern\n+ * @property {number} [firstContentfulPaint]\n+ * @property {number} [firstMeaningfulPaint]\n+ * @property {number} [timeToFirstInteractive]\n+ * @property {number} [timeToConsistentlyInteractive]\n+ * @property {number} [speedIndex]\n+ */\n+\n+/**\n+ * @typedef LanternEvaluation\n+ * @property {string} url\n+ * @property {string} metric\n+ * @property {number} expected\n+ * @property {number} actual\n+ * @property {number} diff\n+ * @property {number} rankDiff\n+ * @property {number} rankDiffAsPercent\n+ */\n+\n+/**\n+ * @typedef LanternMetrics\n+ * @property {number} optimisticFCP\n+ * @property {number} optimisticFMP\n+ * @property {number} optimisticSI\n+ * @property {number} optimisticTTFCPUI\n+ * @property {number} optimisticTTI\n+ * @property {number} pessimisticFCP\n+ * @property {number} pessimisticFMP\n+ * @property {number} pessimisticSI\n+ * @property {number} pessimisticTTFCPUI\n+ * @property {number} pessimisticTTI\n+ * @property {number} roughEstimateOfFCP\n+ * @property {number} roughEstimateOfFMP\n+ * @property {number} roughEstimateOfSI\n+ * @property {number} roughEstimateOfTTFCPUI\n+ * @property {number} roughEstimateOfTTI\n+ */\n",
"new_path": "lighthouse-core/scripts/lantern/evaluate-results.js",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+#!/usr/bin/env node\n+/**\n+ * @license Copyright 2018 Google Inc. All Rights Reserved.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n+ */\n+'use strict';\n+\n+/* eslint-disable no-console */\n+\n+const fs = require('fs');\n+const path = require('path');\n+const execFileSync = require('child_process').execFileSync;\n+\n+if (!process.argv[2]) throw new Error('Usage $0 <expectations file>');\n+\n+const RUN_ONCE_PATH = path.join(__dirname, 'run-once.js');\n+const EXPECTATIONS_PATH = path.resolve(process.cwd(), process.argv[2]);\n+const EXPECTATIONS_DIR = path.dirname(EXPECTATIONS_PATH);\n+const expectations = require(EXPECTATIONS_PATH);\n+\n+for (const site of expectations.sites) {\n+ const trace = path.join(EXPECTATIONS_DIR, site.tracePath);\n+ const log = path.join(EXPECTATIONS_DIR, site.devtoolsLogPath);\n+\n+ console.log('Running', site.url, '...');\n+ const rawOutput = execFileSync(RUN_ONCE_PATH, [trace, log])\n+ .toString()\n+ .trim();\n+ if (!rawOutput) console.log('ERROR EMPTY OUTPUT!');\n+ const lantern = JSON.parse(rawOutput);\n+\n+ Object.assign(site, {lantern});\n+}\n+\n+const computedSummaryPath = path.join(EXPECTATIONS_DIR, 'lantern-computed.json');\n+fs.writeFileSync(computedSummaryPath, JSON.stringify(expectations, null, 2));\n",
"new_path": "lighthouse-core/scripts/lantern/run-all-expectations.js",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+#!/usr/bin/env node\n+/**\n+ * @license Copyright 2018 Google Inc. All Rights Reserved.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n+ */\n+'use strict';\n+\n+const path = require('path');\n+const LH_ROOT_DIR = path.join(__dirname, '../../../');\n+\n+if (process.argv.length !== 4) throw new Error('Usage $0 <trace file> <devtools file>');\n+\n+async function run() {\n+ const PredictivePerf = require(path.join(LH_ROOT_DIR, 'lighthouse-core/audits/predictive-perf'));\n+ const Runner = require(path.join(LH_ROOT_DIR, 'lighthouse-core/runner'));\n+\n+ const traces = {defaultPass: require(process.argv[2])};\n+ const devtoolsLogs = {defaultPass: require(process.argv[3])};\n+ const artifacts = {traces, devtoolsLogs, ...Runner.instantiateComputedArtifacts()};\n+\n+ const result = await PredictivePerf.audit(artifacts);\n+ process.stdout.write(JSON.stringify(result.details.items[0], null, 2));\n+}\n+\n+run().catch(err => {\n+ process.stderr.write(err.stack);\n+ process.exit(1);\n+});\n",
"new_path": "lighthouse-core/scripts/lantern/run-once.js",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -29,7 +29,7 @@ describe('Performance: predictive performance audit', () => {\nassert.equal(Math.round(output.rawValue), 4309);\nassert.equal(output.displayValue, '4,310\\xa0ms');\n- const valueOf = name => Math.round(output.extendedInfo.value[name]);\n+ const valueOf = name => Math.round(output.details.items[0][name]);\nassert.equal(valueOf('roughEstimateOfFCP'), 1038);\nassert.equal(valueOf('optimisticFCP'), 611);\nassert.equal(valueOf('pessimisticFCP'), 611);\n",
"new_path": "lighthouse-core/test/audits/predictive-perf-test.js",
"old_path": "lighthouse-core/test/audits/predictive-perf-test.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | misc(scripts): add lantern evaluation scripts (#5257) | 1 | misc | scripts |
821,196 | 23.05.2018 17:32:43 | 25,200 | 06f5893410d8fe5bf3902f0d837d28dd7e279a7d | fix: add yarn.lock to npm files for plugins | [
{
"change_type": "MODIFY",
"diff": "@@ -270,6 +270,10 @@ class App extends Generator {\nthis.pjson.scripts.version = nps.series('oclif-dev readme', 'git add README.md')\nthis.pjson.files.push('/oclif.manifest.json')\n}\n+ if (this.type === 'plugin' && hasYarn) {\n+ // for plugins, add yarn.lock file to package so we can lock plugin dependencies\n+ this.pjson.files.push('/yarn.lock')\n+ }\nthis.pjson.keywords = defaults.keywords || [this.type === 'plugin' ? 'oclif-plugin' : 'oclif']\nthis.pjson.homepage = defaults.homepage || `https://github.com/${this.pjson.repository}`\nthis.pjson.bugs = defaults.bugs || `https://github.com/${this.pjson.repository}/issues`\n",
"new_path": "src/generators/app.ts",
"old_path": "src/generators/app.ts"
}
] | TypeScript | MIT License | oclif/oclif | fix: add yarn.lock to npm files for plugins | 1 | fix | null |
791,723 | 23.05.2018 18:01:59 | 25,200 | 4820a0bb2250d7b34b00c8eebfde7e68eab215f5 | report: audit warnings are no longer top-level | [
{
"change_type": "MODIFY",
"diff": "@@ -40,10 +40,10 @@ class Viewport extends Audit {\nconst parsedProps = Parser.parseMetaViewPortContent(artifacts.Viewport);\nif (Object.keys(parsedProps.unknownProperties).length) {\n- warnings.push(`Invalid properties found: ${JSON.stringify(parsedProps.unknownProperties)}.`);\n+ warnings.push(`Invalid properties found: ${JSON.stringify(parsedProps.unknownProperties)}`);\n}\nif (Object.keys(parsedProps.invalidValues).length) {\n- warnings.push(`Invalid values found: ${JSON.stringify(parsedProps.invalidValues)}.`);\n+ warnings.push(`Invalid values found: ${JSON.stringify(parsedProps.invalidValues)}`);\n}\nconst viewportProps = parsedProps.validProperties;\n",
"new_path": "lighthouse-core/audits/viewport.js",
"old_path": "lighthouse-core/audits/viewport.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -60,10 +60,8 @@ class CategoryRenderer {\nconst titleEl = this.dom.find('.lh-audit__title', auditEl);\ntitleEl.appendChild(this.dom.convertMarkdownCodeSnippets(audit.result.title));\n- if (audit.result.description) {\nthis.dom.find('.lh-audit__description', auditEl)\n.appendChild(this.dom.convertMarkdownLinkSnippets(audit.result.description));\n- }\nconst header = /** @type {HTMLDetailsElement} */ (this.dom.find('details', auditEl));\nif (audit.result.details && audit.result.details.type) {\n@@ -82,11 +80,26 @@ class CategoryRenderer {\nconst textEl = this.dom.find('.lh-audit__display-text', auditEl);\ntextEl.textContent = 'Error!';\ntextEl.classList.add('tooltip-boundary');\n- const tooltip = this.dom.createChildOf(textEl, 'div', 'tooltip lh-debug');\n+ const tooltip = this.dom.createChildOf(textEl, 'div', 'tooltip tooltip--error');\ntooltip.textContent = audit.result.errorMessage || 'Report error: no audit information';\n} else if (audit.result.explanation) {\n- const explanationEl = this.dom.createChildOf(titleEl, 'div', 'lh-debug');\n- explanationEl.textContent = audit.result.explanation;\n+ const explEl = this.dom.createChildOf(titleEl, 'div', 'lh-audit-explanation');\n+ explEl.textContent = audit.result.explanation;\n+ }\n+ const warnings = audit.result.warnings;\n+ if (!warnings || warnings.length === 0) return auditEl;\n+\n+ // Add list of warnings or singular warning\n+ const warningsEl = this.dom.createChildOf(titleEl, 'div', 'lh-warnings');\n+ if (warnings.length === 1) {\n+ warningsEl.textContent = `Warning: ${warnings.join('')}`;\n+ } else {\n+ warningsEl.textContent = 'Warnings: ';\n+ const warningsUl = this.dom.createChildOf(warningsEl, 'ul');\n+ for (const warning of warnings) {\n+ const item = this.dom.createChildOf(warningsUl, 'li');\n+ item.textContent = warning;\n+ }\n}\nreturn auditEl;\n}\n",
"new_path": "lighthouse-core/report/html/renderer/category-renderer.js",
"old_path": "lighthouse-core/report/html/renderer/category-renderer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -109,7 +109,7 @@ class ReportRenderer {\nreturn this._dom.createElement('div');\n}\n- const container = this._dom.cloneTemplate('#tmpl-lh-run-warnings', this._templateContext);\n+ const container = this._dom.cloneTemplate('#tmpl-lh-warnings--toplevel', this._templateContext);\nconst warnings = this._dom.find('ul', container);\nfor (const warningString of report.runWarnings) {\nconst warning = warnings.appendChild(this._dom.createElement('li'));\n@@ -177,7 +177,7 @@ class ReportRenderer {\n/**\n* Place the AuditResult into the auditDfn (which has just weight & group)\n- * @param {Object<string, AuditResultJSON>} audits\n+ * @param {Object<string, LH.Audit.Result>} audits\n* @param {Array<CategoryJSON>} reportCategories\n*/\nstatic smooshAuditResultsIntoCategories(audits, reportCategories) {\n@@ -196,29 +196,13 @@ if (typeof module !== 'undefined' && module.exports) {\nself.ReportRenderer = ReportRenderer;\n}\n-/**\n- * @typedef {{\n- rawValue: (number|boolean|undefined),\n- id: string,\n- title: string,\n- description: string,\n- explanation?: string,\n- errorMessage?: string,\n- displayValue?: string|Array<string|number>,\n- scoreDisplayMode: string,\n- error: boolean,\n- score: (number|null),\n- details?: DetailsJSON,\n- }} AuditResultJSON\n- */\n-\n/**\n* @typedef {{\nid: string,\nscore: (number|null),\nweight: number,\ngroup?: string,\n- result: AuditResultJSON\n+ result: LH.Audit.Result\n}} AuditJSON\n*/\n@@ -250,7 +234,7 @@ if (typeof module !== 'undefined' && module.exports) {\nfinalUrl: string,\nrunWarnings?: Array<string>,\nartifacts: {traces: {defaultPass: {traceEvents: Array}}},\n- audits: Object<string, AuditResultJSON>,\n+ audits: Object<string, LH.Audit.Result>,\ncategories: Object<string, CategoryJSON>,\nreportCategories: Array<CategoryJSON>,\ncategoryGroups: Object<string, GroupJSON>,\n",
"new_path": "lighthouse-core/report/html/renderer/report-renderer.js",
"old_path": "lighthouse-core/report/html/renderer/report-renderer.js"
},
{
"change_type": "MODIFY",
"diff": "margin-top: 0;\n}\n-\n-.lh-debug {\n- font-size: var(--caption-font-size);\n+.lh-audit-explanation {\n+ margin: var(--lh-audit-vpadding) 0 calc(var(--lh-audit-vpadding) / 2);\nline-height: var(--caption-line-height);\n- color: var(--fail-color);\n- margin-bottom: 3px;\n}\n+.lh-audit--fail .lh-audit-explanation {\n+ color: var(--fail-color);\n+}\n/* Report */\nword-break: break-word;\n}\n-.lh-run-warnings {\n- font-size: var(--body-font-size);\n+.lh-warnings {\n+ --item-margin: calc(var(--body-line-height) / 6);\n+ border: 1px solid var(--average-color);\n+ border-radius: 4px;\n+ margin: var(--lh-audit-vpadding) 0;\n+ padding: calc(var(--lh-audit-vpadding) / 2) var(--lh-audit-vpadding);\n+}\n+\n+.lh-warnings--toplevel {\n+ --item-margin: calc(var(--header-line-height) / 4);\n+ color: var(--secondary-text-color);\nmargin: var(--section-padding);\npadding: var(--section-padding);\n- background-color: hsla(40, 100%, 91%, 1);\n- color: var(--secondary-text-color);\n}\n-.lh-run-warnings li {\n- margin-bottom: calc(var(--header-line-height) / 2);\n+.lh-warnings ul {\n+ padding-left: calc(var(--section-padding) * 2);\n+ margin: 0;\n}\n-.lh-run-warnings::before {\n- display: inline-block;\n+.lh-warnings li {\n+ margin: var(--item-margin) 0;\n}\n+.lh-warnings li:last-of-type {\n+ margin-bottom: 0;\n+}\n+\n.lh-scores-header {\ndisplay: flex;\njustify-content: center;\n",
"new_path": "lighthouse-core/report/html/report-styles.css",
"old_path": "lighthouse-core/report/html/report-styles.css"
},
{
"change_type": "MODIFY",
"diff": "<!-- Lighthouse run warnings -->\n-<template id=\"tmpl-lh-run-warnings\">\n- <div class=\"lh-run-warnings lh-debug\">\n+<template id=\"tmpl-lh-warnings--toplevel\">\n+ <div class=\"lh-warnings lh-warnings--toplevel\">\n<strong>There were issues affecting this run of Lighthouse:</strong>\n<ul></ul>\n</div>\n",
"new_path": "lighthouse-core/report/html/templates.html",
"old_path": "lighthouse-core/report/html/templates.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -112,11 +112,6 @@ class Runner {\nconst resultsById = {};\nfor (const audit of auditResults) {\nresultsById[audit.id] = audit;\n-\n- if (audit.warnings && audit.warnings.length) {\n- const prefixedWarnings = audit.warnings.map(msg => `${audit.title}: ${msg}`);\n- lighthouseRunWarnings.push(...prefixedWarnings);\n- }\n}\n/** @type {Object<string, LH.Result.Category>} */\n",
"new_path": "lighthouse-core/runner.js",
"old_path": "lighthouse-core/runner.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -30,7 +30,7 @@ describe('Mobile-friendly: viewport audit', () => {\nassert.equal(Audit.audit({Viewport: viewport}).rawValue, false);\nassert.equal(Audit.audit({\nViewport: viewport,\n- }).warnings[0], 'Invalid properties found: {\"nonsense\":\"true\"}.');\n+ }).warnings[0], 'Invalid properties found: {\"nonsense\":\"true\"}');\n});\nit('fails when HTML contains an invalid viewport meta tag value', () => {\n@@ -38,15 +38,15 @@ describe('Mobile-friendly: viewport audit', () => {\nassert.equal(Audit.audit({Viewport: viewport}).rawValue, false);\nassert.equal(Audit.audit({\nViewport: viewport,\n- }).warnings[0], 'Invalid values found: {\"initial-scale\":\"microscopic\"}.');\n+ }).warnings[0], 'Invalid values found: {\"initial-scale\":\"microscopic\"}');\n});\nit('fails when HTML contains an invalid viewport meta tag key and value', () => {\nconst viewport = 'nonsense=true, initial-scale=microscopic';\nconst {rawValue, warnings} = Audit.audit({Viewport: viewport});\nassert.equal(rawValue, false);\n- assert.equal(warnings[0], 'Invalid properties found: {\"nonsense\":\"true\"}.');\n- assert.equal(warnings[1], 'Invalid values found: {\"initial-scale\":\"microscopic\"}.');\n+ assert.equal(warnings[0], 'Invalid properties found: {\"nonsense\":\"true\"}');\n+ assert.equal(warnings[1], 'Invalid values found: {\"initial-scale\":\"microscopic\"}');\n});\nit('passes when a valid viewport is provided', () => {\n",
"new_path": "lighthouse-core/test/audits/viewport-test.js",
"old_path": "lighthouse-core/test/audits/viewport-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -69,13 +69,13 @@ describe('CategoryRenderer', () => {\nscoreDisplayMode: 'binary', score: 0,\nresult: {description: 'help text', explanation: 'A reason', title: 'Audit title'},\n});\n- assert.ok(audit1.querySelector('.lh-debug'));\n+ assert.ok(audit1.querySelector('.lh-audit-explanation'));\nconst audit2 = renderer.renderAudit({\nscoreDisplayMode: 'binary', score: 0,\nresult: {description: 'help text', title: 'Audit title'},\n});\n- assert.ok(!audit2.querySelector('.lh-debug'));\n+ assert.ok(!audit2.querySelector('.lh-audit-explanation'));\n});\nit('renders an informative audit', () => {\n@@ -87,6 +87,33 @@ describe('CategoryRenderer', () => {\nassert.ok(auditDOM.matches('.lh-audit--informative'));\n});\n+ it('renders audits with a warning', () => {\n+ const auditResult = {\n+ title: 'Audit',\n+ description: 'Learn more',\n+ warnings: ['It may not have worked!'],\n+ score: 1,\n+ };\n+ const auditDOM = renderer.renderAudit({id: 'foo', score: 1, result: auditResult});\n+ const warningEl = auditDOM.querySelector('.lh-warnings');\n+ assert.ok(warningEl, 'did not render warning message');\n+ assert.ok(warningEl.textContent.includes(auditResult.warnings[0]), 'warning message provided');\n+ });\n+\n+ it('renders audits with multiple warnings', () => {\n+ const auditResult = {\n+ title: 'Audit',\n+ description: 'Learn more',\n+ warnings: ['It may not have worked!', 'You should read this, though'],\n+ score: 1,\n+ };\n+ const auditDOM = renderer.renderAudit({id: 'foo', score: 1, result: auditResult});\n+ const warningEl = auditDOM.querySelector('.lh-warnings');\n+ assert.ok(warningEl, 'did not render warning message');\n+ assert.ok(warningEl.textContent.includes(auditResult.warnings[0]), '1st warning provided');\n+ assert.ok(warningEl.textContent.includes(auditResult.warnings[1]), '2nd warning provided');\n+ });\n+\nit('renders a category', () => {\nconst category = sampleResults.reportCategories.find(c => c.id === 'pwa');\nconst categoryDOM = renderer.render(category, sampleResults.categoryGroups);\n@@ -114,23 +141,6 @@ describe('CategoryRenderer', () => {\ncategory.description = prevDesc;\n});\n- // TODO(phulce): revisit if top-level warnings approach is too noisy\n- it.skip('renders audits with warnings as failed', () => {\n- const auditResult = {\n- title: 'Audit',\n- description: 'Learn more',\n- warnings: ['It may not have worked!'],\n- score: 1,\n- };\n- const audit = {result: auditResult, score: 1};\n- const category = {name: 'Fake', description: '', score: 1, audits: [audit]};\n- const categoryDOM = renderer.render(category, sampleResults.reportGroups);\n- assert.ok(categoryDOM.querySelector(\n- '.lh-category > .lh-audit-group:not(.lh-passed-audits) > .lh-audit'),\n- 'did not render as failed');\n- assert.ok(categoryDOM.querySelector('.lh-debug'), 'did not render debug message');\n- });\n-\nit('renders manual audits if the category contains them', () => {\nconst pwaCategory = sampleResults.reportCategories.find(cat => cat.id === 'pwa');\nconst categoryDOM = renderer.render(pwaCategory, sampleResults.categoryGroups);\n",
"new_path": "lighthouse-core/test/report/html/renderer/category-renderer-test.js",
"old_path": "lighthouse-core/test/report/html/renderer/category-renderer-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -101,36 +101,38 @@ describe('PerfCategoryRenderer', () => {\n});\nit('renders performance opportunities with an errorMessage', () => {\n- const auditWithDebug = {\n+ const auditWithError = {\nscore: 0,\ngroup: 'load-opportunities',\nresult: {\nscore: null, scoreDisplayMode: 'error', errorMessage: 'Yikes!!', title: 'Bug #2',\n+ description: '',\n},\n};\n- const fakeCategory = Object.assign({}, category, {auditRefs: [auditWithDebug]});\n+ const fakeCategory = Object.assign({}, category, {auditRefs: [auditWithError]});\nconst categoryDOM = renderer.render(fakeCategory, sampleResults.categoryGroups);\n- const tooltipEl = categoryDOM.querySelector('.lh-audit--load-opportunity .lh-debug');\n- assert.ok(tooltipEl, 'did not render debug');\n+ const tooltipEl = categoryDOM.querySelector('.lh-audit--load-opportunity .tooltip--error');\n+ assert.ok(tooltipEl, 'did not render error message');\nassert.ok(/Yikes!!/.test(tooltipEl.textContent));\n});\nit('renders performance opportunities\\' explanation', () => {\n- const auditWithDebug = {\n+ const auditWithExplanation = {\nscore: 0,\ngroup: 'load-opportunities',\nresult: {\nscore: 0, scoreDisplayMode: 'numeric',\n- rawValue: 100, explanation: 'Yikes!!', title: 'Bug #2',\n+ rawValue: 100, explanation: 'Yikes!!', title: 'Bug #2', description: '',\n},\n};\n- const fakeCategory = Object.assign({}, category, {auditRefs: [auditWithDebug]});\n+ const fakeCategory = Object.assign({}, category, {auditRefs: [auditWithExplanation]});\nconst categoryDOM = renderer.render(fakeCategory, sampleResults.categoryGroups);\n- const tooltipEl = categoryDOM.querySelector('.lh-audit--load-opportunity .lh-debug');\n- assert.ok(tooltipEl, 'did not render debug');\n+ const selector = '.lh-audit--load-opportunity .lh-audit-explanation';\n+ const tooltipEl = categoryDOM.querySelector(selector);\n+ assert.ok(tooltipEl, 'did not render explanation text');\nassert.ok(/Yikes!!/.test(tooltipEl.textContent));\n});\n",
"new_path": "lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js",
"old_path": "lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -114,16 +114,15 @@ describe('ReportRenderer', () => {\nconst warningResults = Object.assign({}, sampleResults, {runWarnings: []});\nconst container = renderer._dom._document.body;\nconst output = renderer.renderReport(warningResults, container);\n- assert.strictEqual(output.querySelector('.lh-run-warnings'), null);\n+ assert.strictEqual(output.querySelector('.lh-warnings--toplevel'), null);\n});\nit('renders a warning section', () => {\nconst container = renderer._dom._document.body;\nconst output = renderer.renderReport(sampleResults, container);\n- const warningEls = output.querySelectorAll('.lh-run-warnings > ul > li');\n- assert.strictEqual(warningEls.length, 1);\n- assert.ok(/Links.*unsafe/.test(warningEls[0].textContent), 'did not add warning text');\n+ const warningEls = output.querySelectorAll('.lh-warnings--toplevel > ul > li');\n+ assert.strictEqual(warningEls.length, sampleResults.runWarnings.length);\n});\nit('renders a footer', () => {\n",
"new_path": "lighthouse-core/test/report/html/renderer/report-renderer-test.js",
"old_path": "lighthouse-core/test/report/html/renderer/report-renderer-test.js"
},
{
"change_type": "MODIFY",
"diff": "\"fetchTime\": \"2018-03-13T00:55:45.840Z\",\n\"requestedUrl\": \"http://localhost/dobetterweb/dbw_tester.html\",\n\"finalUrl\": \"http://localhost:10200/dobetterweb/dbw_tester.html\",\n- \"runWarnings\": [\n- \"Links to cross-origin destinations are unsafe: Unable to determine the destination for anchor tag. If not used as a hyperlink, consider removing target=_blank.\"\n- ],\n+ \"runWarnings\": [],\n\"audits\": {\n\"is-on-https\": {\n\"id\": \"is-on-https\",\n",
"new_path": "lighthouse-core/test/results/sample_v2.json",
"old_path": "lighthouse-core/test/results/sample_v2.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -166,7 +166,8 @@ describe('Lighthouse chrome extension', function() {\n});\n}\n- const auditErrors = await extensionPage.$$eval('.lh-debug', getDebugStrings, selectors);\n+ const errorSelectors = '.lh-audit-explanation, .tooltip-error';\n+ const auditErrors = await extensionPage.$$eval(errorSelectors, getDebugStrings, selectors);\nconst errors = auditErrors.filter(item => item.debugString.includes('Audit error:'));\nassert.deepStrictEqual(errors, [], 'Audit errors found within the report');\n});\n",
"new_path": "lighthouse-extension/test/extension-test.js",
"old_path": "lighthouse-extension/test/extension-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -131,7 +131,8 @@ describe('Lighthouse Viewer', function() {\n});\n}\n- const auditErrors = await viewerPage.$$eval('.lh-debug', getDebugStrings, selectors);\n+ const errorSelectors = '.lh-audit-explanation, .tooltip-error';\n+ const auditErrors = await viewerPage.$$eval(errorSelectors, getDebugStrings, selectors);\nconst errors = auditErrors.filter(item => item.debugString.includes('Audit error:'));\nconst unexpectedErrrors = errors.filter(item => {\nreturn !item.debugString.includes('Required RobotsTxt gatherer did not run');\n",
"new_path": "lighthouse-viewer/test/viewer-test-pptr.js",
"old_path": "lighthouse-viewer/test/viewer-test-pptr.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -132,9 +132,9 @@ declare global {\nscoreDisplayMode: ScoreDisplayMode;\ntitle: string;\nid: string;\n- description?: string;\n+ description: string;\n// TODO(bckenny): define details\n- details?: object;\n+ details?: any;\n}\nexport interface Results {\n",
"new_path": "typings/audit.d.ts",
"old_path": "typings/audit.d.ts"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | report: audit warnings are no longer top-level (#5270) | 1 | report | null |
815,745 | 23.05.2018 18:51:44 | -10,800 | ad8a644830815c6be9ba8c6b0158f468a65d6e74 | feat: add placeholder as global config | [
{
"change_type": "MODIFY",
"diff": "@@ -69,6 +69,7 @@ export const appRoutes: Routes = [\n{\nprovide: NG_SELECT_DEFAULT_CONFIG,\nuseValue: {\n+ placeholder: 'Select item',\nnotFoundText: 'Items not found',\naddTagText: 'Add item',\ntypeToSearchText: 'Type to search',\n",
"new_path": "demo/app/app.module.ts",
"old_path": "demo/app/app.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -749,6 +749,7 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\n}\nprivate _mergeGlobalConfig(config: NgSelectConfig) {\n+ this.placeholder = this.placeholder || config.placeholder;\nthis.notFoundText = this.notFoundText || config.notFoundText;\nthis.typeToSearchText = this.typeToSearchText || config.typeToSearchText;\nthis.addTagText = this.addTagText || config.addTagText;\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -22,6 +22,7 @@ export enum KeyCode {\n}\nexport interface NgSelectConfig {\n+ placeholder?: string;\nnotFoundText?: string;\ntypeToSearchText?: string;\naddTagText?: string;\n",
"new_path": "src/ng-select/ng-select.types.ts",
"old_path": "src/ng-select/ng-select.types.ts"
}
] | TypeScript | MIT License | ng-select/ng-select | feat: add placeholder as global config | 1 | feat | null |
815,745 | 23.05.2018 20:08:34 | -10,800 | 5808eb7264a7c9e6aa764d982dc4723d5e7cfd6a | fix(styles): make group more distinctable | [
{
"change_type": "MODIFY",
"diff": "@@ -205,15 +205,16 @@ $color-selected: #f5faff;\nuser-select: none;\ncursor: default;\npadding: 8px 10px;\n- &.ng-select-disabled {\n- color: rgba(0, 0, 0, .54);\n+ font-weight: 500;\n+ color: rgba(0, 0, 0, 0.54);\n+ cursor: pointer;\n+ &.ng-option-disabled {\n+ cursor: default;\n}\n&.ng-option-marked {\nbackground-color: #ebf5ff;\n- color: #333;\n}\n&.ng-option-selected {\n- color: #333;\nbackground-color: $color-selected;\nfont-weight: 600;\n}\n",
"new_path": "src/themes/default.theme.scss",
"old_path": "src/themes/default.theme.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -193,16 +193,17 @@ $highlight-color: #3f51b5;\n.ng-dropdown-panel-items {\n.ng-optgroup {\nuser-select: none;\n- cursor: default;\n+ cursor: pointer;\nline-height: 3em;\nheight: 3em;\npadding: 0 16px;\n+ color: rgba(0, 0, 0, .54);\n+ font-weight: 500;\n&.ng-option-marked {\nbackground: rgba(0, 0, 0, .04);\n- color: rgba(0, 0, 0, .87);\n}\n&.ng-option-disabled {\n- color: rgba(0, 0, 0, .54);\n+ cursor: default;\n}\n&.ng-option-selected {\nbackground: rgba(0, 0, 0, .12);\n",
"new_path": "src/themes/material.theme.scss",
"old_path": "src/themes/material.theme.scss"
}
] | TypeScript | MIT License | ng-select/ng-select | fix(styles): make group more distinctable | 1 | fix | styles |
815,745 | 23.05.2018 20:23:53 | -10,800 | 0bf648343dd7a374d2ecddb11114086fecec2b29 | fix: don't group items without key | [
{
"change_type": "MODIFY",
"diff": "@@ -271,7 +271,8 @@ export class ItemsList {\nprivate _groupBy(items: NgOption[], prop: string | Function): OptionGroups {\nconst isFn = isFunction(this._ngSelect.groupBy);\nconst groups = items.reduce((grouped, item) => {\n- const key = isFn ? (<Function>prop).apply(this, [item.value]) : item.value[<string>prop];\n+ let key = isFn ? (<Function>prop).apply(this, [item.value]) : item.value[<string>prop];\n+ key = key || undefined;\nconst group = grouped.get(key);\nif (group) {\ngroup.push(item);\n@@ -285,29 +286,33 @@ export class ItemsList {\nprivate _flatten(groups: OptionGroups) {\nconst isFn = isFunction(this._ngSelect.groupBy);\n- let i = 0;\n-\n- return Array.from(groups.keys()).reduce((items: NgOption[], key: string) => {\n+ const items = [];\n+ const withoutGroup = groups.get(undefined) || [];\n+ items.push(...withoutGroup);\n+ let i = withoutGroup.length;\n+ for (const key of Array.from(groups.keys())) {\n+ if (!key) {\n+ continue;\n+ }\nconst parent: NgOption = {\nlabel: key,\nhasChildren: true,\n- index: i,\n+ index: i++,\ndisabled: !this._ngSelect.selectableGroup,\nhtmlId: newId()\n};\nconst groupKey = isFn ? this._ngSelect.bindLabel : this._ngSelect.groupBy;\nparent.value = { [groupKey]: key };\nitems.push(parent);\n- i++;\nconst children = groups.get(key).map(x => {\nx.parent = parent;\nx.hasChildren = false;\n- i++;\n+ x.index = i++;\nreturn x;\n});\nitems.push(...children);\n+ }\nreturn items;\n- }, []);\n}\n}\n",
"new_path": "src/ng-select/items-list.ts",
"old_path": "src/ng-select/items-list.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -2600,6 +2600,31 @@ describe('NgSelectComponent', function () {\nexpect(items[11].parent).toBe(items[10]);\n}));\n+ it('should not group items without key', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectGroupingTestCmp,\n+ `<ng-select [items]=\"accounts\"\n+ groupBy=\"country\"\n+ [(ngModel)]=\"selectedAccount\">\n+ </ng-select>`);\n+\n+ tickAndDetectChanges(fixture);\n+\n+ fixture.componentInstance.accounts.push(\n+ <any>{ name: 'Henry', email: 'henry@email.com', age: 10 },\n+ <any>{ name: 'Meg', email: 'meg@email.com', age: 7, country: null },\n+ );\n+ fixture.componentInstance.accounts = [...fixture.componentInstance.accounts]\n+ tickAndDetectChanges(fixture);\n+\n+ const items = fixture.componentInstance.select.itemsList.items;\n+ expect(items.length).toBe(16);\n+ expect(items[0].hasChildren).toBeUndefined();\n+ expect(items[0].parent).toBeUndefined();\n+ expect(items[1].hasChildren).toBeUndefined();\n+ expect(items[1].parent).toBeUndefined();\n+ }));\n+\nit('should group by group fn', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectGroupingTestCmp,\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
}
] | TypeScript | MIT License | ng-select/ng-select | fix: don't group items without key | 1 | fix | null |
730,412 | 23.05.2018 21:46:08 | 0 | 0884da92bfec91cba59accec76b628283d32dcc4 | chore(release): 0.1.302 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.302\"></a>\n+## [0.1.302](https://github.com/webex/react-ciscospark/compare/v0.1.301...v0.1.302) (2018-05-23)\n+\n+\n+### Features\n+\n+* **react-container-notifications:** filter notifications with alertType none ([708cf7e](https://github.com/webex/react-ciscospark/commit/708cf7e))\n+\n+\n+\n<a name=\"0.1.301\"></a>\n## [0.1.301](https://github.com/webex/react-ciscospark/compare/v0.1.300...v0.1.301) (2018-05-17)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.301\",\n+ \"version\": \"0.1.302\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.302 | 1 | chore | release |
217,922 | 24.05.2018 09:23:49 | -7,200 | 6797621c08ebfd4adbd82124cb9dcaa0f22c8f50 | fix: rotations now save/copy properly, no more lost rotations !
closes | [
{
"change_type": "MODIFY",
"diff": "<app-simulator [recipe]=\"recipe\" [inputGearSet]=\"stats\" [actions]=\"actions\"\n[customMode]=\"true\" [canSave]=\"canSave\" [rotationId]=\"rotationId\"\n- (onsave)=\"save($event)\" [rotationName]=\"rotationName\"></app-simulator>\n+ (onsave)=\"save($event)\" [rotationName]=\"rotationName\" [authorId]=\"authorId\"></app-simulator>\n</div>\n<ng-template #notFoundTemplate>\n",
"new_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.html",
"old_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -39,6 +39,8 @@ export class CustomSimulatorPageComponent {\npublic rotationName: string;\n+ public authorId;\n+\nconstructor(private userService: UserService, private rotationsService: CraftingRotationService,\nprivate router: Router, activeRoute: ActivatedRoute, private registry: CraftingActionsRegistry) {\n@@ -58,6 +60,7 @@ export class CustomSimulatorPageComponent {\nthis.recipe = res.rotation.recipe;\nthis.actions = this.registry.deserializeRotation(res.rotation.rotation);\nthis.stats = res.rotation.stats;\n+ this.authorId = res.rotation.authorId;\nthis.canSave = res.userId === res.rotation.authorId;\nthis.rotationId = res.rotation.$key;\nthis.rotationName = res.rotation.getName();\n@@ -67,25 +70,23 @@ export class CustomSimulatorPageComponent {\nsave(rotation: Partial<CustomCraftingRotation>): void {\nthis.userId$\n.pipe(\n- map(userId => {\n+ mergeMap(userId => {\nconst result = new CustomCraftingRotation();\nresult.$key = rotation.$key;\nresult.rotation = rotation.rotation;\nresult.stats = rotation.stats;\n- result.authorId = userId;\nresult.recipe = rotation.recipe;\n+ result.authorId = rotation.authorId;\nresult.description = '';\nresult.name = rotation.name;\n- return result;\n- }),\n- mergeMap(preparedRotation => {\n- if (preparedRotation.$key === undefined) {\n+ if (result.$key === undefined || !this.canSave) {\n+ result.authorId = userId;\n// If the rotation has no key, it means that it's a new one, so let's create a rotation entry in the database.\n- return this.rotationsService.add(preparedRotation);\n+ return this.rotationsService.add(result);\n} else {\n- return this.rotationsService.set(preparedRotation.$key, preparedRotation)\n+ return this.rotationsService.set(result.$key, result)\n.pipe(\n- map(() => preparedRotation.$key)\n+ map(() => result.$key)\n)\n}\n})\n",
"new_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "<div *ngIf=\"recipe$ | async as recipe; else loading\">\n<app-simulator [recipe]=\"recipe\" [actions]=\"actions\" [itemId]=\"itemId\" [itemIcon]=\"itemIcon\" [canSave]=\"canSave\"\n[rotationId]=\"rotationId\" (onsave)=\"save($event)\" [selectedFood]=\"selectedFood\"\n- [selectedMedicine]=\"selectedMedicine\" [rotationName]=\"rotationName\"></app-simulator>\n+ [selectedMedicine]=\"selectedMedicine\" [rotationName]=\"rotationName\"\n+ [authorId]=\"authorId\"></app-simulator>\n</div>\n</div>\n<ng-template #loading>\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.html",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -43,6 +43,8 @@ export class SimulatorPageComponent {\npublic notFound = false;\n+ public authorId: string;\n+\nconstructor(private userService: UserService, private rotationsService: CraftingRotationService,\nprivate router: Router, activeRoute: ActivatedRoute, private registry: CraftingActionsRegistry,\nprivate data: DataService) {\n@@ -83,6 +85,7 @@ export class SimulatorPageComponent {\nthis.notFound = false;\nthis.actions = this.registry.deserializeRotation(res.rotation.rotation);\nthis.canSave = res.userId === res.rotation.authorId;\n+ this.authorId = res.rotation.authorId;\nthis.rotationId = res.rotation.$key;\nthis.selectedFood = res.rotation.consumables.food;\nthis.selectedMedicine = res.rotation.consumables.medicine;\n@@ -91,6 +94,7 @@ export class SimulatorPageComponent {\n}\nsave(rotation: Partial<CraftingRotation>): void {\n+ console.log('save', rotation);\nthis.userId$\n.pipe(\nmap(userId => {\n@@ -98,7 +102,7 @@ export class SimulatorPageComponent {\nresult.$key = rotation.$key;\nresult.rotation = rotation.rotation;\nresult.defaultItemId = this.itemId;\n- result.authorId = userId;\n+ result.authorId = rotation.authorId;\nresult.recipe = rotation.recipe;\nresult.description = '';\nresult.name = rotation.name;\n@@ -107,9 +111,10 @@ export class SimulatorPageComponent {\n}),\nmergeMap(data => {\nconst preparedRotation = data.rotation;\n- if (preparedRotation.$key === undefined || data.userId !== data.rotation.authorId) {\n+ if (preparedRotation.$key === undefined || !this.canSave) {\n+ console.log('userId', data.userId);\n// Set new authorId for the newly created rotation\n- data.rotation.authorId = data.userId;\n+ preparedRotation.authorId = data.userId;\n// If the rotation has no key, it means that it's a new one, so let's create a rotation entry in the database.\nreturn this.rotationsService.add(preparedRotation);\n} else {\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -212,6 +212,9 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nthis.applyStats(this.selectedSet, this.levels, false);\n}\n+ @Input()\n+ authorId: string;\n+\npublic _selectedMedicine: Consumable;\nprivate serializedRotation: string[];\n@@ -413,6 +416,7 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nname: this.rotationName,\nrotation: this.serializedRotation,\nrecipe: this.recipeSync,\n+ authorId: this.authorId,\nconsumables: {food: this._selectedFood, medicine: this._selectedMedicine}\n});\n} else {\n@@ -422,6 +426,7 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nstats: this.selectedSet,\nrotation: this.serializedRotation,\nrecipe: this.recipeSync,\n+ authorId: this.authorId,\nconsumables: {food: this._selectedFood, medicine: this._selectedMedicine}\n});\n}\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: rotations now save/copy properly, no more lost rotations !
closes #363 | 1 | fix | null |
217,922 | 24.05.2018 09:39:27 | -7,200 | 6e074e4bf2c61aeea62fdfd39fea4433243b36c1 | fix: you can no longer add an empty id as contact
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -127,10 +127,12 @@ export class ProfileComponent extends PageComponent {\n}\naddContact(contactId: string): void {\n+ if (contactId !== undefined && contactId.length > 0 || contactId.indexOf(' ') > -1) {\nthis.user.contacts = this.user.contacts.filter(contact => contact !== contactId);\nthis.user.contacts.push(contactId);\nthis.userService.set(this.user.$key, this.user);\n}\n+ }\nremoveContact(contactId: string): void {\nthis.dialog.open(ConfirmationPopupComponent)\n",
"new_path": "src/app/pages/profile/profile/profile.component.ts",
"old_path": "src/app/pages/profile/profile/profile.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: you can no longer add an empty id as contact
closes #358 | 1 | fix | null |
217,922 | 24.05.2018 10:39:42 | -7,200 | f2b6462d8f501b178d2198a6918c6f0276a988e9 | fix: better auto-update flow for "all users" installation
closes | [
{
"change_type": "ADD",
"diff": "+!macro customUnInit\n+ ${IfNot} ${Silent}\n+ MessageBox MB_YESNO \"Uninstalling the application will delete all related settings. Do you want to continue?\" IDYES true IDNO false\n+ false:\n+ Quit\n+ true:\n+ RMDir /r \"$PROFILE\\AppData\\Roaming\\zzz\"\n+ DeleteRegValue HKCU \"Software\\Microsoft\\Windows\\CurrentVersion\\Run\" \"zzz\"\n+ ${EndIf}\n+!macroend\n+\n+!macro customInit\n+ ${if} $installMode == \"all\"\n+ ${IfNot} ${UAC_IsAdmin}\n+ ShowWindow $HWNDPARENT ${SW_HIDE}\n+ !insertmacro UAC_RunElevated\n+ Quit\n+ ${endif}\n+ ${endif}\n+!macroend\n",
"new_path": "build/nsis/include.nsh",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "]\n},\n\"nsis\": {\n+ \"include\": \"./build/nsis/include.nsh\",\n\"allowToChangeInstallationDirectory\": true,\n\"oneClick\": false\n}\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: better auto-update flow for "all users" installation
closes #359 | 1 | fix | null |
815,745 | 24.05.2018 10:55:52 | -10,800 | e2c680d5c2e8b2f173ed05c41af924c0885b0547 | chore(release): 2.1.0 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"2.1.0\"></a>\n+# [2.1.0](https://github.com/ng-select/ng-select/compare/v2.0.3...v2.1.0) (2018-05-24)\n+\n+\n+### Bug Fixes\n+\n+* **styles:** make group more distinctable ([5808eb7](https://github.com/ng-select/ng-select/commit/5808eb7))\n+* **typeahead:** don't insert option back to list for newly created tag ([4c20e9e](https://github.com/ng-select/ng-select/commit/4c20e9e)), closes [#513](https://github.com/ng-select/ng-select/issues/513)\n+* don't group items without key ([0bf6483](https://github.com/ng-select/ng-select/commit/0bf6483))\n+\n+\n+### Features\n+\n+* add placeholder as global config ([ad8a644](https://github.com/ng-select/ng-select/commit/ad8a644))\n+\n+\n+\n<a name=\"2.0.3\"></a>\n## [2.0.3](https://github.com/ng-select/ng-select/compare/v2.0.2...v2.0.3) (2018-05-18)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"$schema\": \"../node_modules/ng-packagr/package.schema.json\",\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"2.0.3\",\n+ \"version\": \"2.1.0\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] | TypeScript | MIT License | ng-select/ng-select | chore(release): 2.1.0 | 1 | chore | release |
217,922 | 24.05.2018 11:09:18 | -7,200 | c9ceb8a66b21d4bb2639d64e8538fc5f9b75771b | feat: added timers for duskglow aethersand in alarms page | [
{
"change_type": "MODIFY",
"diff": "@@ -9,5 +9,6 @@ export const reductions: { [ index: number ] : number[] } = {\n20015: [20010],\n20013: [20012, 20011, 20180],\n20017: [20024],\n- 20016 : [ 19937 ]\n-}\n+ 20016: [19937],\n+ 23182: [23220, 23221]\n+};\n",
"new_path": "src/app/core/data/sources/reductions.ts",
"old_path": "src/app/core/data/sources/reductions.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: added timers for duskglow aethersand in alarms page | 1 | feat | null |
217,922 | 24.05.2018 11:40:11 | -7,200 | 3e095006a5ec8b25d3e965fd718693d2f0a204eb | fix: crafting rotations no longer reappearing out of nowhere
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -8,7 +8,7 @@ import {ActivatedRoute, Router} from '@angular/router';\nimport {CraftingActionsRegistry} from '../../model/crafting-actions-registry';\nimport {CraftingAction} from '../../model/actions/crafting-action';\nimport {GearSet} from '../../model/gear-set';\n-import {filter, map, mergeMap} from 'rxjs/operators';\n+import {filter, first, map, mergeMap} from 'rxjs/operators';\n@Component({\nselector: 'app-custom-simulator-page',\n@@ -70,6 +70,7 @@ export class CustomSimulatorPageComponent {\nsave(rotation: Partial<CustomCraftingRotation>): void {\nthis.userId$\n.pipe(\n+ first(),\nmergeMap(userId => {\nconst result = new CustomCraftingRotation();\nresult.$key = rotation.$key;\n",
"new_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -10,7 +10,7 @@ import {CraftingActionsRegistry} from '../../model/crafting-actions-registry';\nimport {CraftingRotationService} from '../../../../core/database/crafting-rotation.service';\nimport {UserService} from '../../../../core/database/user.service';\nimport {Consumable} from '../../model/consumable';\n-import {catchError, distinctUntilChanged, filter, map, mergeMap} from 'rxjs/operators';\n+import {catchError, distinctUntilChanged, filter, first, map, mergeMap} from 'rxjs/operators';\n@Component({\nselector: 'app-simulator-page',\n@@ -97,6 +97,7 @@ export class SimulatorPageComponent {\nconsole.log('save', rotation);\nthis.userId$\n.pipe(\n+ first(),\nmap(userId => {\nconst result = new CraftingRotation();\nresult.$key = rotation.$key;\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: crafting rotations no longer reappearing out of nowhere
closes #355 | 1 | fix | null |
791,723 | 24.05.2018 12:05:58 | 25,200 | 520f9ac06420634ccc03d0326e8e42fe83610a42 | misc(viewer): load *.json if no *.lighthouse.report.json | [
{
"change_type": "MODIFY",
"diff": "@@ -115,9 +115,13 @@ class GithubApi {\nconst etag = resp.headers.get('ETag');\nreturn resp.json().then(json => {\n+ const gistFiles = Object.keys(json.files);\n// Attempt to use first file in gist with report extension.\n- const filename = Object.keys(json.files)\n- .find(filename => filename.endsWith(GithubApi.LH_JSON_EXT));\n+ let filename = gistFiles.find(filename => filename.endsWith(GithubApi.LH_JSON_EXT));\n+ // Otherwise, fall back to first json file in gist\n+ if (!filename) {\n+ filename = gistFiles.find(filename => filename.endsWith('.json'));\n+ }\nif (!filename) {\nthrow new Error(\n`Failed to find a Lighthouse report (*${GithubApi.LH_JSON_EXT}) in gist ${id}`\n",
"new_path": "lighthouse-viewer/app/src/github-api.js",
"old_path": "lighthouse-viewer/app/src/github-api.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | misc(viewer): load *.json if no *.lighthouse.report.json (#5343) | 1 | misc | viewer |
573,234 | 24.05.2018 12:28:16 | -19,080 | de72f49eade48cc14dd916916ea86f88d46d3c8a | fix: proxy events into instance var and add test script | [
{
"change_type": "MODIFY",
"diff": "@@ -34,14 +34,6 @@ patchRequest(http.IncomingMessage);\n///--- Globals\nvar sprintf = util.format;\n-var PROXY_EVENTS = [\n- 'clientError',\n- 'close',\n- 'connection',\n- 'error',\n- 'listening',\n- 'secureConnection'\n-];\n///--- API\n@@ -138,6 +130,14 @@ function Server(options) {\nvar fmt = mergeFormatters(options.formatters);\nthis.acceptable = fmt.acceptable;\nthis.formatters = fmt.formatters;\n+ this.proxyEvents = [\n+ 'clientError',\n+ 'close',\n+ 'connection',\n+ 'error',\n+ 'listening',\n+ 'secureConnection'\n+ ];\nif (options.spdy) {\nthis.spdy = true;\n@@ -187,10 +187,10 @@ function Server(options) {\nthis.router.on('mount', this.emit.bind(this, 'mount'));\n- if (!options.handleUpgrades && PROXY_EVENTS.indexOf('upgrade') === -1) {\n- PROXY_EVENTS.push('upgrade');\n+ if (!options.handleUpgrades) {\n+ this.proxyEvents.push('upgrade');\n}\n- PROXY_EVENTS.forEach(function forEach(e) {\n+ this.proxyEvents.forEach(function forEach(e) {\nself.server.on(e, self.emit.bind(self, e));\n});\n",
"new_path": "lib/server.js",
"old_path": "lib/server.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -2430,3 +2430,19 @@ test('should emit error with multiple next calls with strictNext', function(t) {\n});\n});\n});\n+\n+test('should have proxy event handlers as instance', function(t) {\n+ var server = restify.createServer({\n+ handleUpgrades: false\n+ });\n+ t.equal(server.proxyEvents.length, 7);\n+\n+ server = restify.createServer({\n+ handleUpgrades: true\n+ });\n+\n+ t.equal(server.proxyEvents.length, 6);\n+ server.close(function() {\n+ t.end();\n+ });\n+});\n",
"new_path": "test/server.test.js",
"old_path": "test/server.test.js"
}
] | JavaScript | MIT License | restify/node-restify | fix: proxy events into instance var and add test script (#1661) | 1 | fix | null |
791,723 | 24.05.2018 12:37:12 | 25,200 | 872cba7eac280a0d5deb83ba4c931c7224a0757a | extension: close the popup once the report has opened | [
{
"change_type": "MODIFY",
"diff": "@@ -88,7 +88,7 @@ window.runLighthouseInExtension = function(options, categoryIDs) {\n.then(runnerResult => {\n// return enableOtherChromeExtensions(true).then(_ => {\nconst blobURL = window.createReportPageAsBlob(runnerResult, 'extension');\n- chrome.windows.create({url: blobURL});\n+ return new Promise(resolve => chrome.windows.create({url: blobURL}, resolve));\n// });\n}).catch(err => {\n// return enableOtherChromeExtensions(true).then(_ => {\n",
"new_path": "lighthouse-extension/app/src/lighthouse-ext-background.js",
"old_path": "lighthouse-extension/app/src/lighthouse-ext-background.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -117,7 +117,7 @@ function createOptionItem(text, id, isChecked) {\n* @param {!Window} background Reference to the extension's background page.\n* @param {{selectedCategories: !Object<boolean>, useDevTools: boolean}} settings\n*/\n-function onGenerateReportButtonClick(background, settings) {\n+async function onGenerateReportButtonClick(background, settings) {\nshowRunningSubpage();\nconst feedbackEl = document.querySelector('.feedback');\n@@ -125,10 +125,15 @@ function onGenerateReportButtonClick(background, settings) {\nconst {selectedCategories, useDevTools} = settings;\n- background.runLighthouseInExtension({\n+ try {\n+ await background.runLighthouseInExtension({\nrestoreCleanState: true,\nflags: {throttlingMethod: useDevTools ? 'devtools' : 'simulate'},\n- }, selectedCategories).catch(err => {\n+ }, selectedCategories);\n+\n+ // Close popup once report is opened in a new tab\n+ window.close();\n+ } catch (err) {\nlet message = err.message;\nlet includeReportLink = true;\n@@ -151,7 +156,7 @@ function onGenerateReportButtonClick(background, settings) {\nhideRunningSubpage();\nbackground.console.error(err);\n- });\n+ }\n}\n/**\n",
"new_path": "lighthouse-extension/app/src/popup.js",
"old_path": "lighthouse-extension/app/src/popup.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | extension: close the popup once the report has opened (#5341) | 1 | extension | null |
217,922 | 24.05.2018 13:59:43 | -7,200 | fe9f0f197c16baa4551d5b9c0ea154441f3cf8ed | fix: multi-crafter items now using correct stats in simulator
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -17,6 +17,8 @@ export class CraftingRotation extends DataModel {\npublic defaultItemId?: number;\n+ public defaultRecipeId?: number;\n+\n@DeserializeAs(SavedConsumables)\npublic consumables: SavedConsumables = new SavedConsumables();\n",
"new_path": "src/app/model/other/crafting-rotation.ts",
"old_path": "src/app/model/other/crafting-rotation.ts"
},
{
"change_type": "MODIFY",
"diff": "<div class=\"classes\">\n<div *ngIf=\"recipe\">\n<mat-menu #simulatorMenu=\"matMenu\">\n- <button mat-menu-item routerLink=\"/simulator/{{item.id}}\">{{'SIMULATOR.New_rotation' | translate}}\n+ <button mat-menu-item routerLink=\"/simulator/{{item.id}}/{{item.recipeId}}\">\n+ {{'SIMULATOR.New_rotation' | translate}}\n</button>\n<button mat-menu-item\n*ngFor=\"let rotation of rotations$ | async\"\n- routerLink=\"/simulator/{{item.id}}/{{rotation.$key}}\">{{rotation.getName()}}\n+ routerLink=\"/simulator/{{item.id}}/{{item.recipeId}}/{{rotation.$key}}\">\n+ {{rotation.getName()}}\n</button>\n<mat-divider></mat-divider>\n<a *ngIf=\"getCraft(item.recipeId) as craft\"\n<div *ngIf=\"!recipe\">\n<div *ngFor=\"let craft of item.craftedBy\">\n<mat-menu #simulatorMenu=\"matMenu\">\n- <button mat-menu-item routerLink=\"/simulator/{{item.id}}\">{{'SIMULATOR.New_rotation' |\n+ <button mat-menu-item routerLink=\"/simulator/{{item.id}}/{{craft.recipeId}}\">\n+ {{'SIMULATOR.New_rotation' |\ntranslate}}\n</button>\n<button mat-menu-item\n*ngFor=\"let rotation of rotations$ | async\"\n- routerLink=\"/simulator/{{item.id}}/{{rotation.$key}}\">{{rotation.getName()}}\n+ routerLink=\"/simulator/{{item.id}}/{{craft.recipeId}}/{{rotation.$key}}\">\n+ {{rotation.getName()}}\n</button>\n<mat-divider></mat-divider>\n<a href=\"{{craft | simulatorLink:'http://ffxiv-beta.lokyst.net' | i18n}}\"\n",
"new_path": "src/app/modules/item/item/item.component.html",
"old_path": "src/app/modules/item/item/item.component.html"
},
{
"change_type": "MODIFY",
"diff": "</mat-menu>\n<mat-menu #simulatorMenu=\"matMenu\">\n- <button mat-menu-item routerLink=\"/simulator/{{recipe.itemId}}\">{{'SIMULATOR.New_rotation' | translate}}</button>\n+ <button mat-menu-item routerLink=\"/simulator/{{recipe.itemId}}/{{recipe.recipeId}}\">\n+ {{'SIMULATOR.New_rotation' | translate}}\n+ </button>\n<button mat-menu-item\n*ngFor=\"let rotation of rotations$ | async\"\n- routerLink=\"/simulator/{{recipe.itemId}}/{{rotation.$key}}\">{{rotation.getName()}}</button>\n+ routerLink=\"/simulator/{{recipe.itemId}}/{{recipe.recipeId}}/{{rotation.$key}}\">\n+ {{rotation.getName()}}\n+ </button>\n</mat-menu>\n<button mat-icon-button [matMenuTriggerFor]=\"appMenu\">\n",
"new_path": "src/app/pages/recipes/recipes/recipes.component.html",
"old_path": "src/app/pages/recipes/recipes/recipes.component.html"
},
{
"change_type": "MODIFY",
"diff": "<mat-icon>share</mat-icon>\n</button>\n<button mat-icon-button\n- routerLink=\"{{rotation.defaultItemId?'/simulator/'+rotation.defaultItemId+'/'+rotation.$key:'/simulator/custom/'+rotation.$key}}\"\n+ routerLink=\"{{getLocalLink(rotation)}}\"\n(click)=\"$event.stopPropagation()\">\n<mat-icon>playlist_play</mat-icon>\n</button>\n",
"new_path": "src/app/pages/simulator/components/rotations-page/rotations-page.component.html",
"old_path": "src/app/pages/simulator/components/rotations-page/rotations-page.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -70,14 +70,25 @@ export class RotationsPageComponent {\npublic openLinkPopup(rotation: CraftingRotation): void {\nconst link = new CustomLink();\n- link.redirectTo = `${rotation.defaultItemId ? 'simulator/' +\n- rotation.defaultItemId + '/' + rotation.$key : 'simulator/custom/' + rotation.$key}`;\n+ link.redirectTo = this.getLocalLink(rotation);\nthis.dialog.open(CustomLinkPopupComponent, {data: link});\n}\npublic getLink(rotation: CraftingRotation): string {\n- return this.linkTools.getLink(`${rotation.defaultItemId ? '/simulator/' +\n- rotation.defaultItemId + '/' + rotation.$key : '/simulator/custom/' + rotation.$key}`);\n+ return this.linkTools.getLink(this.getLocalLink(rotation));\n+ }\n+\n+ private getLocalLink(rotation: CraftingRotation): string {\n+ let link = '/simulator';\n+ if (rotation.defaultItemId) {\n+ link += `/${rotation.defaultItemId}`;\n+ if (rotation.defaultRecipeId) {\n+ link += `/${rotation.defaultRecipeId}`;\n+ }\n+ } else {\n+ link += `/custom`;\n+ }\n+ return `${link}/${rotation.$key}`;\n}\npublic showCopiedNotification(): void {\n",
"new_path": "src/app/pages/simulator/components/rotations-page/rotations-page.component.ts",
"old_path": "src/app/pages/simulator/components/rotations-page/rotations-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -45,6 +45,8 @@ export class SimulatorPageComponent {\npublic authorId: string;\n+ private recipeId: string;\n+\nconstructor(private userService: UserService, private rotationsService: CraftingRotationService,\nprivate router: Router, activeRoute: ActivatedRoute, private registry: CraftingActionsRegistry,\nprivate data: DataService) {\n@@ -56,6 +58,14 @@ export class SimulatorPageComponent {\nmap(item => {\nthis.itemId = params.itemId;\nthis.itemIcon = item.item.icon;\n+ // If rotationId is only numbers, it's a recipeId\n+ if (params.rotationId !== undefined && /^\\d+$/.test(params.rotationId)) {\n+ this.recipeId = params.rotationId;\n+ return item.item.craft.find(craft => +craft.id === +this.recipeId);\n+ } else if (params.recipeId !== undefined) {\n+ this.recipeId = params.recipeId;\n+ return item.item.craft.find(craft => +craft.id === +this.recipeId);\n+ }\n// Because only crystals change between recipes, we take the first one.\nreturn item.item.craft[0];\n})\n@@ -75,7 +85,13 @@ export class SimulatorPageComponent {\ncombineLatest(this.userId$,\nactiveRoute.params\n.pipe(\n- map(params => params.rotationId),\n+ map(params => {\n+ // If rotationId is a number only, it means that it's a recipeId.\n+ if (/^\\d+$/.test(params.rotationId)) {\n+ return undefined;\n+ }\n+ return params.rotationId;\n+ }),\nfilter(rotation => rotation !== undefined),\nmergeMap(id => this.rotationsService.get(id).pipe(distinctUntilChanged())),\nmap(res => res))\n@@ -94,7 +110,6 @@ export class SimulatorPageComponent {\n}\nsave(rotation: Partial<CraftingRotation>): void {\n- console.log('save', rotation);\nthis.userId$\n.pipe(\nfirst(),\n@@ -108,12 +123,12 @@ export class SimulatorPageComponent {\nresult.description = '';\nresult.name = rotation.name;\nresult.consumables = rotation.consumables;\n+ result.defaultRecipeId = +this.recipeId;\nreturn {rotation: result, userId: userId};\n}),\nmergeMap(data => {\nconst preparedRotation = data.rotation;\nif (preparedRotation.$key === undefined || !this.canSave) {\n- console.log('userId', data.userId);\n// Set new authorId for the newly created rotation\npreparedRotation.authorId = data.userId;\n// If the rotation has no key, it means that it's a new one, so let's create a rotation entry in the database.\n@@ -124,7 +139,11 @@ export class SimulatorPageComponent {\n}\n})\n).subscribe((rotationKey) => {\n+ if (this.recipeId !== undefined) {\n+ this.router.navigate(['simulator', this.itemId, this.recipeId, rotationKey]);\n+ } else {\nthis.router.navigate(['simulator', this.itemId, rotationKey]);\n+ }\n});\n}\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -56,6 +56,11 @@ const routes: Routes = [\ncomponent: SimulatorPageComponent,\ncanActivate: [MaintenanceGuard]\n},\n+ {\n+ path: 'simulator/:itemId/:recipeId/:rotationId',\n+ component: SimulatorPageComponent,\n+ canActivate: [MaintenanceGuard]\n+ },\n{\npath: 'simulator/:itemId',\ncomponent: SimulatorPageComponent,\n",
"new_path": "src/app/pages/simulator/simulator.module.ts",
"old_path": "src/app/pages/simulator/simulator.module.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: multi-crafter items now using correct stats in simulator
closes #361 | 1 | fix | null |
791,690 | 24.05.2018 14:27:36 | 25,200 | e72d6613d269673aefc91d4b047fba89ff83769b | core(pwa): adjust score weights | [
{
"change_type": "MODIFY",
"diff": "@@ -289,16 +289,20 @@ module.exports = {\n'[PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are ' +\n'not automatically checked by Lighthouse. They do not affect your score but it\\'s important that you verify them manually.',\nauditRefs: [\n+ // Most difficult and critical for good UX\n+ {id: 'load-fast-enough-for-pwa', weight: 7}, // can't be green in the category without being fast\n+ {id: 'works-offline', weight: 5},\n+ // Encompasses most of the other checks\n+ {id: 'webapp-install-banner', weight: 3},\n+ // Important but not too difficult\n+ {id: 'is-on-https', weight: 2},\n+ {id: 'redirects-http', weight: 2},\n+ {id: 'viewport', weight: 2},\n+ // Relatively easy checkboxes to tick with minimal value on their own\n{id: 'service-worker', weight: 1},\n- {id: 'works-offline', weight: 1},\n{id: 'without-javascript', weight: 1},\n- {id: 'is-on-https', weight: 1},\n- {id: 'redirects-http', weight: 1},\n- {id: 'load-fast-enough-for-pwa', weight: 1},\n- {id: 'webapp-install-banner', weight: 1},\n{id: 'splash-screen', weight: 1},\n{id: 'themed-omnibox', weight: 1},\n- {id: 'viewport', weight: 1},\n{id: 'content-width', weight: 1},\n// Manual audits\n{id: 'pwa-cross-browser', weight: 0},\n",
"new_path": "lighthouse-core/config/default-config.js",
"old_path": "lighthouse-core/config/default-config.js"
},
{
"change_type": "MODIFY",
"diff": "\"manualDescription\": \"These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually.\",\n\"auditRefs\": [\n{\n- \"id\": \"service-worker\",\n- \"weight\": 1\n+ \"id\": \"load-fast-enough-for-pwa\",\n+ \"weight\": 7\n},\n{\n\"id\": \"works-offline\",\n- \"weight\": 1\n+ \"weight\": 5\n},\n{\n- \"id\": \"without-javascript\",\n- \"weight\": 1\n+ \"id\": \"webapp-install-banner\",\n+ \"weight\": 3\n},\n{\n\"id\": \"is-on-https\",\n- \"weight\": 1\n+ \"weight\": 2\n},\n{\n\"id\": \"redirects-http\",\n- \"weight\": 1\n+ \"weight\": 2\n},\n{\n- \"id\": \"load-fast-enough-for-pwa\",\n- \"weight\": 1\n+ \"id\": \"viewport\",\n+ \"weight\": 2\n},\n{\n- \"id\": \"webapp-install-banner\",\n+ \"id\": \"service-worker\",\n\"weight\": 1\n},\n{\n- \"id\": \"splash-screen\",\n+ \"id\": \"without-javascript\",\n\"weight\": 1\n},\n{\n- \"id\": \"themed-omnibox\",\n+ \"id\": \"splash-screen\",\n\"weight\": 1\n},\n{\n- \"id\": \"viewport\",\n+ \"id\": \"themed-omnibox\",\n\"weight\": 1\n},\n{\n}\n],\n\"id\": \"pwa\",\n- \"score\": 0.36\n+ \"score\": 0.42\n},\n\"accessibility\": {\n\"title\": \"Accessibility\",\n",
"new_path": "lighthouse-core/test/results/sample_v2.json",
"old_path": "lighthouse-core/test/results/sample_v2.json"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(pwa): adjust score weights (#5233) | 1 | core | pwa |
217,922 | 24.05.2018 14:42:04 | -7,200 | 3d7f2d61d0dd272828bde719551506b331639982 | feat: new collapsible panel in lists for community lists | [
{
"change_type": "MODIFY",
"diff": "@@ -32,7 +32,8 @@ export class WorkshopService extends FirestoreStorage<Workshop> {\n);\n}\n- getListsByWorkshop(lists: List[], workshops: Workshop[]): { basicLists: List[], rows: { [index: string]: List[] } } {\n+ getListsByWorkshop(lists: List[], workshops: Workshop[]):\n+ { basicLists: List[], publicLists?: List[], rows: { [index: string]: List[] } } {\nconst result = {basicLists: lists, rows: {}};\nworkshops.forEach(workshop => {\nresult.rows[workshop.$key] = [];\n",
"new_path": "src/app/core/database/workshop.service.ts",
"old_path": "src/app/core/database/workshop.service.ts"
},
{
"change_type": "MODIFY",
"diff": "[templateButton]=\"userData?.patron || userData?.admin\"\n></app-list-panel>\n</div>\n+ <div *ngIf=\"display.publicLists !== undefined && display.publicLists.length > 0\">\n+ <h2>{{'Public_lists' | translate}}</h2>\n+ <mat-divider class=\"divider\"></mat-divider>\n+ <mat-expansion-panel>\n+ <mat-expansion-panel-header>\n+ <mat-panel-title>\n+ {{'Public_lists' | translate}}\n+ </mat-panel-title>\n+ </mat-expansion-panel-header>\n+ <div class=\"row\" *ngFor=\"let list of display.publicLists;trackBy: trackByListsFn; let i = index;\">\n+ <app-list-panel\n+ [list]=\"list\"\n+ [expanded]=\"expanded.indexOf(list.$key) > -1\"\n+ (onrecipedelete)=\"removeRecipe($event, list, list.$key)\"\n+ (onedit)=\"updateAmount($event.recipe, list, list.$key, $event.amount)\"\n+ (ondelete)=\"delete(list)\"\n+ [authorUid]=\"user.uid\"\n+ [odd]=\"i%2>0\"\n+ [linkButton]=\"userData?.patron || userData?.admin\"\n+ [templateButton]=\"userData?.patron || userData?.admin\"\n+ ></app-list-panel>\n+ </div>\n+ </mat-expansion-panel>\n+ </div>\n+\n<div class=\"shared-lists\" *ngIf=\"sharedLists | async as sharedListsData\">\n<div *ngIf=\"sharedListsData.length > 0\">\n<h2>{{\"LISTS.Shared_lists\" | translate}}</h2>\n",
"new_path": "src/app/pages/lists/lists/lists.component.html",
"old_path": "src/app/pages/lists/lists/lists.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -43,7 +43,7 @@ export class ListsComponent extends ComponentWithSubscriptions implements OnInit\nreloader$ = new BehaviorSubject<void>(null);\n- lists: Observable<{ basicLists: List[], rows?: { [index: string]: List[] } }>;\n+ lists: Observable<{ basicLists: List[], publicLists?: List[], rows?: { [index: string]: List[] } }>;\nsharedLists: Observable<List[]>;\n@@ -382,7 +382,19 @@ export class ListsComponent extends ComponentWithSubscriptions implements OnInit\n}\n}),\nmap(lists => {\n- return this.workshopService.getListsByWorkshop(lists, workshops);\n+ const layout = this.workshopService.getListsByWorkshop(lists, workshops);\n+ const publicLists = [];\n+ const basicLists = [];\n+ layout.basicLists.forEach(list => {\n+ if (list.public) {\n+ publicLists.push(list);\n+ } else {\n+ basicLists.push(list);\n+ }\n+ });\n+ layout.basicLists = basicLists;\n+ layout.publicLists = publicLists;\n+ return layout;\n})\n);\n}))\n",
"new_path": "src/app/pages/lists/lists/lists.component.ts",
"old_path": "src/app/pages/lists/lists/lists.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: new collapsible panel in lists for community lists | 1 | feat | null |
217,922 | 24.05.2018 14:45:54 | -7,200 | 461cdad7c927bbb366d749cc6150bffa485a5044 | fix: no more duplicated tags in lists
closes | [
{
"change_type": "MODIFY",
"diff": "routerLink=\"/profile/{{list.authorId}}\">\n<div class=\"tags\">\n<mat-chip-list class=\"inline-chips\">\n- <mat-chip *ngFor=\"let tag of list.tags\">{{tag}}</mat-chip>\n+ <mat-chip *ngFor=\"let tag of tags\">{{tag}}</mat-chip>\n</mat-chip-list>\n</div>\n<span>{{list.note}}</span>\n",
"new_path": "src/app/modules/common-components/list-panel/list-panel.component.html",
"old_path": "src/app/modules/common-components/list-panel/list-panel.component.html"
},
{
"change_type": "MODIFY",
"diff": "-import {Component, EventEmitter, Input, OnInit, Output} from '@angular/core';\n+import {Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges} from '@angular/core';\nimport {List} from '../../../model/list/list';\nimport {MatDialog, MatExpansionPanel, MatSnackBar} from '@angular/material';\nimport {TranslateService} from '@ngx-translate/core';\n@@ -18,13 +18,14 @@ import {PermissionsPopupComponent} from '../permissions-popup/permissions-popup.\nimport {catchError, filter, first, mergeMap} from 'rxjs/operators';\nimport {ListRow} from '../../../model/list/list-row';\nimport {LinkToolsService} from '../../../core/tools/link-tools.service';\n+import {ListTag} from '../../../model/list/list-tag.enum';\n@Component({\nselector: 'app-list-panel',\ntemplateUrl: './list-panel.component.html',\nstyleUrls: ['./list-panel.component.scss']\n})\n-export class ListPanelComponent extends ComponentWithSubscriptions implements OnInit {\n+export class ListPanelComponent extends ComponentWithSubscriptions implements OnInit, OnChanges {\n@Input()\npublic list: List;\n@@ -78,6 +79,8 @@ export class ListPanelComponent extends ComponentWithSubscriptions implements On\npublic anonymous: boolean;\n+ public tags: ListTag[];\n+\nconstructor(private snack: MatSnackBar, private translator: TranslateService,\nprivate listService: ListService, private translate: TranslateService, private media: ObservableMedia,\nprivate router: Router, private auth: AngularFireAuth, private userService: UserService,\n@@ -184,4 +187,12 @@ export class ListPanelComponent extends ComponentWithSubscriptions implements On\npublic isMobile(): boolean {\nreturn this.media.isActive('xs');\n}\n+\n+ ngOnChanges(changes: SimpleChanges): void {\n+ if (this.list !== undefined && this.list.tags !== undefined && this.list.tags.length > 0) {\n+ this.tags = this.list.tags.filter((value, index, self) => {\n+ return self.indexOf(value) === index;\n+ });\n+ }\n+ }\n}\n",
"new_path": "src/app/modules/common-components/list-panel/list-panel.component.ts",
"old_path": "src/app/modules/common-components/list-panel/list-panel.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: no more duplicated tags in lists
closes #357 | 1 | fix | null |
217,922 | 24.05.2018 15:00:52 | -7,200 | 3628b3e45726a59e330438d23b5d8a3f692812ad | style: better layout for lists page | [
{
"change_type": "MODIFY",
"diff": "{{'LISTS.IMPORT.Title' | translate}}\n</button>\n-<h3 class=\"mat-h3\">{{'Lists' | translate}}</h3>\n-\n<div class=\"filter\">\n<mat-form-field>\n<mat-select (selectionChange)=\"tagFilter.next($event.value)\"\n<mat-icon>call_merge</mat-icon>\n</button>\n-<div class=\"lists-container\" *ngIf=\"lists | async as display\">\n+<div *ngIf=\"lists | async as display\">\n+ <h2>{{'Lists' | translate}}</h2>\n+ <mat-divider class=\"divider\"></mat-divider>\n<div class=\"row\" *ngFor=\"let list of display.basicLists;trackBy: trackByListsFn; let i = index; \">\n<app-list-panel\n[list]=\"list\"\n[templateButton]=\"userData?.patron || userData?.admin\"\n></app-list-panel>\n</div>\n- <div *ngIf=\"display.publicLists !== undefined && display.publicLists.length > 0\">\n+ <div class=\"category\" *ngIf=\"display.publicLists !== undefined && display.publicLists.length > 0\">\n<h2>{{'Public_lists' | translate}}</h2>\n<mat-divider class=\"divider\"></mat-divider>\n<mat-expansion-panel>\n</div>\n</mat-expansion-panel>\n</div>\n-\n- <div class=\"shared-lists\" *ngIf=\"sharedLists | async as sharedListsData\">\n+ <div class=\"category\" *ngIf=\"sharedLists | async as sharedListsData\">\n<div *ngIf=\"sharedListsData.length > 0\">\n<h2>{{\"LISTS.Shared_lists\" | translate}}</h2>\n<mat-divider class=\"divider\"></mat-divider>\n></app-list-panel>\n</div>\n</div>\n- <div class=\"workshops\">\n+ <div class=\"category\">\n<h2>{{'WORKSHOP.Workshops' | translate}}</h2>\n<mat-divider class=\"divider\"></mat-divider>\n<div *ngFor=\"let workshop of workshops | async; trackBy: trackByWorkshopFn; let i = index\" class=\"row\">\n{{'WORKSHOP.Add_workshop' | translate}}\n</button>\n</div>\n- <div class=\"workshops\" *ngIf=\"sharedWorkshops | async as sharedWorkshopsData\">\n+ <div class=\"category\" *ngIf=\"sharedWorkshops | async as sharedWorkshopsData\">\n<div *ngIf=\"sharedWorkshopsData.length > 0\">\n<h2>{{'WORKSHOP.Shared_workshops' | translate}}</h2>\n<mat-divider class=\"divider\"></mat-divider>\n",
"new_path": "src/app/pages/lists/lists/lists.component.html",
"old_path": "src/app/pages/lists/lists/lists.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -65,8 +65,8 @@ mat-slide-toggle {\nwidth: 100%;\n}\n-.workshops {\n- margin-top: 40px;\n+.category {\n+ margin-top: 30px;\n}\n.divider {\n",
"new_path": "src/app/pages/lists/lists/lists.component.scss",
"old_path": "src/app/pages/lists/lists/lists.component.scss"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | style: better layout for lists page | 1 | style | null |
217,922 | 24.05.2018 15:03:30 | -7,200 | adf4c8f46a3424f45ed1a14bb22abd051ae17f04 | fix: rotations name generation now properly done (not retroactive) | [
{
"change_type": "MODIFY",
"diff": "@@ -63,7 +63,7 @@ export class CustomSimulatorPageComponent {\nthis.authorId = res.rotation.authorId;\nthis.canSave = res.userId === res.rotation.authorId;\nthis.rotationId = res.rotation.$key;\n- this.rotationName = res.rotation.getName();\n+ this.rotationName = res.rotation.name;\n}, () => this.notFound = true);\n}\n",
"new_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -105,7 +105,7 @@ export class SimulatorPageComponent {\nthis.rotationId = res.rotation.$key;\nthis.selectedFood = res.rotation.consumables.food;\nthis.selectedMedicine = res.rotation.consumables.medicine;\n- this.rotationName = res.rotation.getName();\n+ this.rotationName = res.rotation.name;\n}, () => this.notFound = true);\n}\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: rotations name generation now properly done (not retroactive) | 1 | fix | null |
724,015 | 24.05.2018 15:05:29 | -28,800 | c0b2101f75b80e1dd5691656d0929085d5adb886 | docs: video link for common tips | [
{
"change_type": "MODIFY",
"diff": "@@ -10,7 +10,7 @@ For example, for the `Counter` component which increments a display counter by 1\nThe benefit of this approach is that as long as your component's public interface remains the same, your tests will pass no matter how the component's internal implementation changes over time.\n-This topic is discussed with more details in a [great presentation by Matt O'Connell](http://slides.com/mattoconnell/deck#/).\n+This topic is discussed with more details in a [great presentation by Matt O'Connell](https://www.youtube.com/watch?v=OIpfWTThrK8).\n### Shallow Rendering\n",
"new_path": "docs/guides/common-tips.md",
"old_path": "docs/guides/common-tips.md"
}
] | JavaScript | MIT License | vuejs/vue-test-utils | docs: video link for common tips (#643) | 1 | docs | null |
217,922 | 24.05.2018 16:14:36 | -7,200 | 6188914d93ed39ce2d57ba28da07ddb775313fd7 | feat: default layout is now the one made by tataru taru ! | [
{
"change_type": "MODIFY",
"diff": "@@ -11,8 +11,7 @@ import {LayoutOrderService} from './layout-order.service';\nimport {Observable, of} from 'rxjs';\nimport {UserService} from '../database/user.service';\nimport {ListRow} from '../../model/list/list-row';\n-import {catchError, map} from 'rxjs/operators';\n-import {first, mergeMap} from 'rxjs/operators';\n+import {catchError, first, map, mergeMap} from 'rxjs/operators';\n@Injectable()\nexport class LayoutService {\n@@ -25,7 +24,7 @@ export class LayoutService {\n.pipe(\nmap(userData => {\nconst layouts = userData.layouts;\n- if (layouts === undefined || layouts === null || layouts.length === 0) {\n+ if (layouts === undefined || layouts === null || layouts.length === 0 || layouts[0].name === 'Default layout') {\nreturn [new ListLayout('Default layout', this.defaultLayout)];\n}\nreturn layouts;\n@@ -119,9 +118,15 @@ export class LayoutService {\npublic get defaultLayout(): LayoutRow[] {\nreturn [\n- new LayoutRow('Gathering', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_GATHERING.name, 0, true),\n- new LayoutRow('Pre_crafts', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_CRAFT.name, 3),\n- new LayoutRow('Other', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.ANYTHING.name, 2),\n+ new LayoutRow('Timed nodes', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_TIMED.name, 0, true, false, true),\n+ new LayoutRow('Vendors ', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.CAN_BE_BOUGHT.name, 1, false, true, true),\n+ new LayoutRow('Reducible', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_REDUCTION.name, 2, false, false, true),\n+ new LayoutRow('Tomes/Tokens/Scripts', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_TOKEN_TRADE.name, 3, false, false, true),\n+ new LayoutRow('Fishing', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_GATHERED_BY_FSH.name, 4, false, false, true),\n+ new LayoutRow('Gatherings', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_GATHERING.name, 5, true, false, true),\n+ new LayoutRow('Dungeons/Drops or GC', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_MONSTER_DROP.name + ':or:' + LayoutRowFilter.IS_GC_TRADE.name, 6, false, false, true),\n+ new LayoutRow('Pre_crafts', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_CRAFT.name, 8, false, true, true),\n+ new LayoutRow('Other', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.ANYTHING.name, 7, true, false, true),\n]\n}\n",
"new_path": "src/app/core/layout/layout.service.ts",
"old_path": "src/app/core/layout/layout.service.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: default layout is now the one made by tataru taru ! | 1 | feat | null |
730,412 | 24.05.2018 16:41:29 | 0 | e438a4f2665fdc54c8039c8f194d68c937e15de2 | chore(release): 0.1.303 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.1.303\"></a>\n+## [0.1.303](https://github.com/webex/react-ciscospark/compare/v0.1.302...v0.1.303) (2018-05-24)\n+\n+\n+### Bug Fixes\n+\n+* **r-c-read-receipts:** add support for empty activities ([e9b16bc](https://github.com/webex/react-ciscospark/commit/e9b16bc))\n+\n+\n+\n<a name=\"0.1.302\"></a>\n## [0.1.302](https://github.com/webex/react-ciscospark/compare/v0.1.301...v0.1.302) (2018-05-23)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ciscospark/react-ciscospark\",\n- \"version\": \"0.1.302\",\n+ \"version\": \"0.1.303\",\n\"description\": \"The Cisco Spark for React library allows developers to easily incorporate Spark functionality into an application.\",\n\"scripts\": {\n\"build\": \"./scripts/build/index.js\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | webex/react-widgets | chore(release): 0.1.303 | 1 | chore | release |
791,690 | 24.05.2018 16:45:19 | 25,200 | c5743e9a376b709d4a0e74d8cec7f02095a8a573 | core(simulator): improved timing typedef | [
{
"change_type": "MODIFY",
"diff": "@@ -102,8 +102,7 @@ class RenderBlockingResources extends Audit {\nnode.traverse(node => deferredNodeIds.add(node.id));\n// \"wastedMs\" is the download time of the network request, responseReceived - requestSent\n- // @ts-ignore - TODO(phulce): nodeTiming.startTime/endTime shouldn't be optional by this point?\n- const wastedMs = Math.round(nodeTiming.endTime - nodeTiming.startTime);\n+ const wastedMs = Math.round(nodeTiming.duration);\nif (wastedMs < MINIMUM_WASTED_MS) continue;\nresults.push({\n",
"new_path": "lighthouse-core/audits/byte-efficiency/render-blocking-resources.js",
"old_path": "lighthouse-core/audits/byte-efficiency/render-blocking-resources.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -75,7 +75,6 @@ class Redirects extends Audit {\nthrow new Error('Could not find redirects in graph');\n}\n- // @ts-ignore TODO(phulce): split NodeTiming typedef, these are always defined\nconst wastedMs = redirectedTiming.startTime - initialTiming.startTime;\ntotalWastedMs += wastedMs;\n",
"new_path": "lighthouse-core/audits/redirects.js",
"old_path": "lighthouse-core/audits/redirects.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -112,7 +112,8 @@ class UsesRelPreloadAudit extends Audit {\nconst originalNode = originalNodesByRecord.get(node.record);\nconst timingAfter = simulationAfterChanges.nodeTimings.get(node);\nconst timingBefore = simulationBeforeChanges.nodeTimings.get(originalNode);\n- // @ts-ignore TODO(phulce): fix timing typedef\n+ if (!timingBefore || !timingAfter) throw new Error('Missing preload node');\n+\nconst wastedMs = Math.round(timingBefore.endTime - timingAfter.endTime);\nif (wastedMs < THRESHOLD_IN_MS) continue;\nresults.push({url: node.record.url, wastedMs});\n",
"new_path": "lighthouse-core/audits/uses-rel-preload.js",
"old_path": "lighthouse-core/audits/uses-rel-preload.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -83,13 +83,12 @@ class LanternEstimatedInputLatency extends LanternMetricArtifact {\nconst events = [];\nfor (const [node, timing] of nodeTimings.entries()) {\nif (node.type !== Node.TYPES.CPU) continue;\n- if (!timing.endTime || !timing.startTime) continue;\nif (timing.endTime < fmpTimeInMs) continue;\nevents.push({\nstart: timing.startTime,\nend: timing.endTime,\n- duration: timing.endTime - timing.startTime,\n+ duration: timing.duration,\n});\n}\n",
"new_path": "lighthouse-core/gather/computed/metrics/lantern-estimated-input-latency.js",
"old_path": "lighthouse-core/gather/computed/metrics/lantern-estimated-input-latency.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -43,8 +43,7 @@ class LanternFirstCPUIdle extends LanternInteractive {\nconst longTasks = [];\nfor (const [node, timing] of nodeTimings.entries()) {\nif (node.type !== Node.TYPES.CPU) continue;\n- if (!timing.endTime || !timing.startTime) continue;\n- if (timing.endTime - timing.startTime < longTaskLength) continue;\n+ if (timing.duration < longTaskLength) continue;\nlongTasks.push({start: timing.startTime, end: timing.endTime});\n}\n",
"new_path": "lighthouse-core/gather/computed/metrics/lantern-first-cpu-idle.js",
"old_path": "lighthouse-core/gather/computed/metrics/lantern-first-cpu-idle.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -102,8 +102,7 @@ class Interactive extends MetricArtifact {\nreturn Array.from(nodeTimings.entries())\n.filter(([node, timing]) => {\nif (node.type !== Node.TYPES.CPU) return false;\n- if (!timing.endTime || !timing.startTime) return false;\n- return timing.endTime - timing.startTime > duration;\n+ return timing.duration > duration;\n})\n.map(([_, timing]) => timing.endTime)\n.reduce((max, x) => Math.max(max || 0, x || 0), 0);\n",
"new_path": "lighthouse-core/gather/computed/metrics/lantern-interactive.js",
"old_path": "lighthouse-core/gather/computed/metrics/lantern-interactive.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -96,7 +96,6 @@ class SpeedIndex extends MetricArtifact {\nconst layoutWeights = [];\nfor (const [node, timing] of nodeTimings.entries()) {\nif (node.type !== Node.TYPES.CPU) continue;\n- if (!timing.startTime || !timing.endTime) continue;\nconst cpuNode = /** @type {CPUNode} */ (node);\nif (cpuNode.childEvents.some(x => x.name === 'Layout')) {\n",
"new_path": "lighthouse-core/gather/computed/metrics/lantern-speed-index.js",
"old_path": "lighthouse-core/gather/computed/metrics/lantern-speed-index.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -56,7 +56,9 @@ class Simulator {\n// Properties reset on every `.simulate` call but duplicated here for type checking\nthis._flexibleOrdering = false;\n+ /** @type {Map<Node, NodeTimingIntermediate>} */\nthis._nodeTimings = new Map();\n+ /** @type {Map<string, number>} */\nthis._numberInProgressByType = new Map();\nthis._nodes = {};\n// @ts-ignore\n@@ -101,7 +103,7 @@ class Simulator {\n/**\n* @param {Node} node\n- * @param {LH.Gatherer.Simulation.NodeTiming} values\n+ * @param {NodeTimingIntermediate} values\n*/\n_setTimingData(node, values) {\nconst timingData = this._nodeTimings.get(node) || {};\n@@ -109,6 +111,16 @@ class Simulator {\nthis._nodeTimings.set(node, timingData);\n}\n+ /**\n+ * @param {Node} node\n+ * @return {NodeTimingIntermediate}\n+ */\n+ _getTimingData(node) {\n+ const timingData = this._nodeTimings.get(node);\n+ if (!timingData) throw new Error(`Unable to get timing data for node ${node.id}`);\n+ return timingData;\n+ }\n+\n/**\n* @param {Node} node\n* @param {number} queuedTime\n@@ -226,7 +238,7 @@ class Simulator {\n* @return {number}\n*/\n_estimateCPUTimeRemaining(cpuNode) {\n- const timingData = this._nodeTimings.get(cpuNode);\n+ const timingData = this._getTimingData(cpuNode);\nconst multiplier = cpuNode.didPerformLayout()\n? this._layoutTaskMultiplier\n: this._cpuSlowdownMultiplier;\n@@ -244,7 +256,7 @@ class Simulator {\n* @return {number}\n*/\n_estimateNetworkTimeRemaining(networkNode) {\n- const timingData = this._nodeTimings.get(networkNode);\n+ const timingData = this._getTimingData(networkNode);\nlet timeElapsed = 0;\nif (networkNode.fromDiskCache) {\n@@ -288,7 +300,7 @@ class Simulator {\n* @param {number} totalElapsedTime\n*/\n_updateProgressMadeInTimePeriod(node, timePeriodLength, totalElapsedTime) {\n- const timingData = this._nodeTimings.get(node);\n+ const timingData = this._getTimingData(node);\nconst isFinished = timingData.estimatedTimeElapsed === timePeriodLength;\nconst networkNode = /** @type {NetworkNode} */ (node);\n@@ -326,6 +338,20 @@ class Simulator {\n}\n}\n+ _computeFinalNodeTimings() {\n+ /** @type {Map<Node, LH.Gatherer.Simulation.NodeTiming>} */\n+ const nodeTimings = new Map();\n+ for (const [node, timing] of this._nodeTimings) {\n+ nodeTimings.set(node, {\n+ startTime: timing.startTime,\n+ endTime: timing.endTime,\n+ duration: timing.endTime - timing.startTime,\n+ });\n+ }\n+\n+ return nodeTimings;\n+ }\n+\n/**\n* @return {Required<LH.Gatherer.Simulation.Options>}\n*/\n@@ -405,9 +431,20 @@ class Simulator {\nreturn {\ntimeInMs: totalElapsedTime,\n- nodeTimings: this._nodeTimings,\n+ nodeTimings: this._computeFinalNodeTimings(),\n};\n}\n}\nmodule.exports = Simulator;\n+\n+/**\n+ * @typedef NodeTimingIntermediate\n+ * @property {number} [startTime]\n+ * @property {number} [endTime]\n+ * @property {number} [queuedTime]\n+ * @property {number} [estimatedTimeElapsed]\n+ * @property {number} [timeElapsed]\n+ * @property {number} [timeElapsedOvershoot]\n+ * @property {number} [bytesDownloaded]\n+ */\n",
"new_path": "lighthouse-core/lib/dependency-graph/simulator/simulator.js",
"old_path": "lighthouse-core/lib/dependency-graph/simulator/simulator.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -51,13 +51,9 @@ declare global {\n}\nexport interface NodeTiming {\n- startTime?: number;\n- endTime?: number;\n- queuedTime?: number;\n- estimatedTimeElapsed?: number;\n- timeElapsed?: number;\n- timeElapsedOvershoot?: number;\n- bytesDownloaded?: number;\n+ startTime: number;\n+ endTime: number;\n+ duration: number;\n}\nexport interface Result {\n",
"new_path": "typings/gatherer.d.ts",
"old_path": "typings/gatherer.d.ts"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(simulator): improved timing typedef (#5347) | 1 | core | simulator |
807,875 | 25.05.2018 04:11:35 | -19,080 | bd799499c843c7b3c3e61386fa32ddc6e89bebc9 | doc(import): add note around uncommitted changes
Lerna throws a Git error when current project has uncommitted changes.
Fixes
[ci skip] | [
{
"change_type": "MODIFY",
"diff": "@@ -62,6 +62,13 @@ lerna ERR! execute CONFLICT (content): Merge conflict in [file]\nRun `lerna import` with the `--flatten` flag to import the history in \"flat\"\nmode, i.e. with each merge commit as a single change the merge introduced.\n+### Failing when git tree has uncommitted changes\n+You will receive `fatal: ambiguous argument 'HEAD':` error, when the current project has **uncommitted changes**.\n+\n+#### Solution\n+Make sure to commit all the changes you have in your lerna project, before importing any packages using `lerna import`.\n+\n+\n## Publish Command\n### Publish does not detect manually created tags in fixed mode with Github/Github Enterprise\n",
"new_path": "doc/troubleshooting.md",
"old_path": "doc/troubleshooting.md"
}
] | JavaScript | MIT License | lerna/lerna | doc(import): add note around uncommitted changes (#1432)
Lerna throws a Git error when current project has uncommitted changes.
Fixes #763
[ci skip] | 1 | doc | import |
807,849 | 25.05.2018 09:21:26 | 25,200 | a27295e0d8ddd98e482e968ff9ea6de8e10e656f | chore: add __mocks__ to jest-related overrides | [
{
"change_type": "MODIFY",
"diff": "- files:\n- \"integration/**\"\n- \"**/__tests__/**\"\n+ - \"**/__mocks__/**\"\nenv:\njest: true\nrules:\n",
"new_path": ".eslintrc.yaml",
"old_path": ".eslintrc.yaml"
},
{
"change_type": "MODIFY",
"diff": "\"use strict\";\n-// eslint-disable-next-line import/no-extraneous-dependencies, node/no-extraneous-require\nconst writePkg = require.requireActual(\"write-pkg\");\nconst registry = new Map();\n",
"new_path": "commands/__mocks__/write-pkg.js",
"old_path": "commands/__mocks__/write-pkg.js"
}
] | JavaScript | MIT License | lerna/lerna | chore: add __mocks__ to jest-related overrides | 1 | chore | null |
217,922 | 25.05.2018 10:10:09 | -7,200 | 3f7bcad68151d241201084c9ebb657ac037eadeb | fix(simulator): way better design for failed actions, thanks to Aurora Phoenix | [
{
"change_type": "MODIFY",
"diff": "<div class=\"action\"\n[ngClass]=\"{'wasted': wasted, 'disabled': disabled || notEnoughCp, 'not-enough-cp': notEnoughCp}\">\n<img src=\"{{action.getId(getJobId()) | actionIcon}}\" alt=\"\">\n+ <div class=\"red-overlay\" *ngIf=\"notEnoughCp || disabled\"></div>\n+ <mat-icon class=\"failed\" *ngIf=\"failed\">close</mat-icon>\n<span class=\"cost\"\n*ngIf=\"!hideCost && action.getBaseCPCost(simulation) > 0 && (cpCost === undefined || cpCost > 0)\">\n{{cpCost === undefined ? action.getBaseCPCost(simulation) : cpCost}}\n",
"new_path": "src/app/pages/simulator/components/action/action.component.html",
"old_path": "src/app/pages/simulator/components/action/action.component.html"
},
{
"change_type": "MODIFY",
"diff": "height: 40px;\n.action {\n&.disabled {\n- opacity: .3;\n+ opacity: .8;\n}\n&.not-enough-cp {\n.cost {\nleft: 4px;\nbottom: -7px;\nz-index: 1;\n- color: rgba(191, 0, 8, 0.94);\n+ color: rgba(255, 100, 100, 1);\ntext-shadow: -1px 0 #820000, 0 1px #820000, 1px 0 #820000, 0 -1px #820000;\n}\n}\nimg {\nborder-radius: 5px;\n}\n+ .failed {\n+ position: absolute;\n+ right: -12px;\n+ bottom: -12px;\n+ z-index: 5;\n+ color: red;\n+ text-shadow: -1px 0 #820000, 0 1px #820000, 1px 0 #820000, 0 -1px #820000;\n+ }\n+ .red-overlay {\n+ position: absolute;\n+ top: 0;\n+ left: 0;\n+ width: 100%;\n+ height: 100%;\n+ border-radius: 5px;\n+ background-color: red;\n+ opacity: .4;\n+ }\n.cost {\nposition: absolute;\nfont-size: 12px;\n",
"new_path": "src/app/pages/simulator/components/action/action.component.scss",
"old_path": "src/app/pages/simulator/components/action/action.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -40,6 +40,9 @@ export class ActionComponent {\n@Input()\ncpCost: number;\n+ @Input()\n+ failed = false;\n+\ngetJobId(): number {\nreturn this.simulation !== undefined ? this.simulation.crafterStats.jobId : this.jobId;\n}\n",
"new_path": "src/app/pages/simulator/components/action/action.component.ts",
"old_path": "src/app/pages/simulator/components/action/action.component.ts"
},
{
"change_type": "MODIFY",
"diff": "</div>\n</div>\n</mat-card>\n- <mat-card>\n+ <mat-card [class.failed]=\"actionFailed\">\n<div class=\"actions\">\n<app-action draggable\ndroppable\n[action]=\"step.action\"\n[simulation]=\"resultData.simulation\"\n[ignoreDisabled]=\"true\"\n- [cpCost]=\"step.cpDifference\"></app-action>\n+ [cpCost]=\"step.cpDifference\"\n+ [failed]=\"!step.success\"></app-action>\n<div class=\"end-drag-zone\" droppable\ndragOverClass=\"drag-over\"\n(onDrop)=\"moveSkill($event.dragData, resultData.simulation.steps.length - 1)\"></div>\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.html",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -225,6 +225,10 @@ mat-progress-bar {\ndisplay: none !important;\n}\n+.failed {\n+ background-color: rgba(255, 0, 0, .3);\n+}\n+\n.actions {\ndisplay: flex;\njustify-content: flex-start;\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.scss",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -174,6 +174,8 @@ export class SimulatorComponent implements OnInit, OnDestroy {\npublic selectedSet: GearSet;\n+ public actionFailed = false;\n+\n@Input()\npublic set inputGearSet(set: GearSet) {\nif (set !== undefined) {\n@@ -313,7 +315,11 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nreturn simulation.run(true, step);\n}\nreturn simulation.run(true);\n- });\n+ }).pipe(\n+ tap(result => {\n+ this.actionFailed = result.steps.find(step => !step.success) !== undefined;\n+ })\n+ );\nthis.report$ = this.result$\n.pipe(\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): way better design for failed actions, thanks to Aurora Phoenix | 1 | fix | simulator |
217,922 | 25.05.2018 11:18:11 | -7,200 | ea7144789b9330c79e65bcdb8b1a76d3856152b4 | feat(simulator): generated macro now includes /aaction setup
closes | [
{
"change_type": "MODIFY",
"diff": "<h3 mat-dialog-title>{{'SIMULATOR.Generated_macro' | translate}}</h3>\n-<div class=\"macro\" mat-dialog-content>\n+<div mat-dialog-content>\n+ <div class=\"macro\">\n<pre *ngFor=\"let macroFragment of macro\" class=\"macro-fragment\">\n<span class=\"macro-line\" *ngFor=\"let line of macroFragment\">{{line}}</span>\n</pre>\n</div>\n+ <b>{{'SIMULATOR.Cross_class_setup' | translate}}</b>\n+ <mat-divider></mat-divider>\n+ <div class=\"macro\">\n+ <pre class=\"macro-fragment\">\n+ <span class=\"macro-line\" *ngFor=\"let line of aactionsMacro\">{{line}}</span>\n+ </pre>\n+ </div>\n+</div>\n<div mat-dialog-actions>\n<button mat-raised-button mat-dialog-close color=\"accent\">{{'Close' | translate}}</button>\n</div>\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.html",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -3,6 +3,7 @@ import {MAT_DIALOG_DATA} from '@angular/material';\nimport {CraftingAction} from '../../model/actions/crafting-action';\nimport {LocalizedDataService} from '../../../../core/data/localized-data.service';\nimport {I18nToolsService} from '../../../../core/tools/i18n-tools.service';\n+import {CraftingJob} from '../../model/crafting-job.enum';\n@Component({\nselector: 'app-macro-popup',\n@@ -13,14 +14,16 @@ export class MacroPopupComponent implements OnInit {\npublic macro: string[][] = [[]];\n+ public aactionsMacro: string[] = [];\n+\nprivate readonly maxMacroLines = 15;\n- constructor(@Inject(MAT_DIALOG_DATA) private rotation: CraftingAction[], private l12n: LocalizedDataService,\n+ constructor(@Inject(MAT_DIALOG_DATA) private data: { rotation: CraftingAction[], job: CraftingJob }, private l12n: LocalizedDataService,\nprivate i18n: I18nToolsService) {\n}\nngOnInit() {\n- this.rotation.forEach((action, index) => {\n+ this.data.rotation.forEach((action) => {\nlet macroFragment = this.macro[this.macro.length - 1];\n// One macro is 15 lines, if this one is full, create another one.\nif (macroFragment.length >= this.maxMacroLines) {\n@@ -31,6 +34,11 @@ export class MacroPopupComponent implements OnInit {\nif (actionName.indexOf(' ') > -1) {\nactionName = `\"${actionName}\"`;\n}\n+ if (action.getLevelRequirement().job !== CraftingJob.ANY && action.getLevelRequirement().job !== this.data.job) {\n+ if (this.aactionsMacro.indexOf(`/aaction ${actionName}`) === -1) {\n+ this.aactionsMacro.push(`/aaction ${actionName}`);\n+ }\n+ }\nmacroFragment.push(`/ac ${actionName} <wait.${action.getWaitDuration()}>`);\n});\n}\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -33,7 +33,8 @@ import {Language} from 'app/core/data/language';\nimport {ConsumablesService} from 'app/pages/simulator/model/consumables.service';\nimport {I18nToolsService} from '../../../../core/tools/i18n-tools.service';\nimport {AppUser} from 'app/model/list/app-user';\n-import {debounceTime, filter, map, mergeMap, tap} from 'rxjs/operators';\n+import {debounceTime, filter, first, map, mergeMap, tap} from 'rxjs/operators';\n+import {CraftingJob} from '../../model/crafting-job.enum';\n@Component({\nselector: 'app-simulator',\n@@ -407,7 +408,18 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n}\ngenerateMacro(): void {\n- this.dialog.open(MacroPopupComponent, {data: this.actions$.getValue()});\n+ this.crafterStats$\n+ .pipe(\n+ first()\n+ ).subscribe(crafterStats => {\n+ this.dialog.open(MacroPopupComponent, {\n+ data:\n+ {\n+ rotation: this.actions$.getValue(),\n+ job: CraftingJob[crafterStats.jobId - 8]\n+ }\n+ });\n+ });\n}\nprivate markAsDirty(): void {\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
},
{
"change_type": "MODIFY",
"diff": "\"Open_in_external\": \"Open in {{name}}'s sim\",\n\"Select_job_please\": \"Please select a job\",\n\"Rename_rotation\": \"Rename Rotation\",\n+ \"Cross_class_setup\": \"Cross-class skills setup\",\n\"CUSTOM\": {\n\"Recipe_configuration\": \"Recipe configuration\",\n\"Recipe_level\": \"Recipe level\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat(simulator): generated macro now includes /aaction setup
closes #368 | 1 | feat | simulator |
217,922 | 25.05.2018 11:45:21 | -7,200 | d52134284e48bb7f3b9c8f0788fcf3fa6bb042c4 | feat(simulator): added possibility to have end of macro sound | [
{
"change_type": "MODIFY",
"diff": "<h3 mat-dialog-title>{{'SIMULATOR.Generated_macro' | translate}}</h3>\n-<div mat-dialog-content>\n+<div mat-dialog-content class=\"content\">\n+ <mat-checkbox [(ngModel)]=\"addEcho\" (ngModelChange)=\"generateMacros()\">\n+ {{'SIMULATOR.Include_sound_end' | translate}}\n+ </mat-checkbox>\n<div class=\"macro\">\n<pre *ngFor=\"let macroFragment of macro\" class=\"macro-fragment\">\n<span class=\"macro-line\" *ngFor=\"let line of macroFragment\">{{line}}</span>\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.html",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.html"
},
{
"change_type": "MODIFY",
"diff": "+.content {\n+ padding-top: 15px;\n.macro-fragment {\ndisplay: flex;\nflex-direction: column;\n+ background: rgba(0, 0, 0, .1);\n+ border: 1px solid darkgrey;\n+ padding: 10px;\n+ }\n}\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.scss",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -18,11 +18,15 @@ export class MacroPopupComponent implements OnInit {\nprivate readonly maxMacroLines = 15;\n+ public addEcho = true;\n+\nconstructor(@Inject(MAT_DIALOG_DATA) private data: { rotation: CraftingAction[], job: CraftingJob }, private l12n: LocalizedDataService,\nprivate i18n: I18nToolsService) {\n}\n- ngOnInit() {\n+ private generateMacros(): void {\n+ this.macro = [[]];\n+ this.aactionsMacro = [];\nthis.data.rotation.forEach((action) => {\nlet macroFragment = this.macro[this.macro.length - 1];\n// One macro is 15 lines, if this one is full, create another one.\n@@ -40,7 +44,17 @@ export class MacroPopupComponent implements OnInit {\n}\n}\nmacroFragment.push(`/ac ${actionName} <wait.${action.getWaitDuration()}>`);\n+ if (macroFragment.length === 14 && this.addEcho) {\n+ macroFragment.push(`/echo Macro #${this.macro.length} finished <se.${this.macro.length}>`);\n+ }\n});\n+ if (this.macro[this.macro.length - 1].length < 15 && this.addEcho) {\n+ this.macro[this.macro.length - 1].push('/echo Craft finished <se.4>')\n+ }\n+ }\n+\n+ ngOnInit() {\n+ this.generateMacros();\n}\n}\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts"
},
{
"change_type": "MODIFY",
"diff": "\"Select_job_please\": \"Please select a job\",\n\"Rename_rotation\": \"Rename Rotation\",\n\"Cross_class_setup\": \"Cross-class skills setup\",\n+ \"Include_sound_end\": \"Include end of macro sound\",\n\"CUSTOM\": {\n\"Recipe_configuration\": \"Recipe configuration\",\n\"Recipe_level\": \"Recipe level\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat(simulator): added possibility to have end of macro sound | 1 | feat | simulator |
217,922 | 25.05.2018 13:04:58 | -7,200 | f517f667a7e1ed37340858e5343e6aa26d2c97de | chore: aaction clear at the beginning of aaction macro | [
{
"change_type": "MODIFY",
"diff": "@@ -26,7 +26,7 @@ export class MacroPopupComponent implements OnInit {\nprivate generateMacros(): void {\nthis.macro = [[]];\n- this.aactionsMacro = [];\n+ this.aactionsMacro = ['/aaction clear'];\nthis.data.rotation.forEach((action) => {\nlet macroFragment = this.macro[this.macro.length - 1];\n// One macro is 15 lines, if this one is full, create another one.\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: aaction clear at the beginning of aaction macro | 1 | chore | null |
217,922 | 25.05.2018 13:52:54 | -7,200 | fdfb4c6642114fe7b55b3e65e260d29b5d7ec35b | fix(simulator): custom stats now save properly
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -69,8 +69,7 @@ export class DataService {\ncp: set.stats.core !== undefined ? set.stats.core.CP : 0,\nspecialist: set.slot_soulcrystal !== null\n}\n- })\n- .sort((a, b) => a.jobId - b.jobId);\n+ });\n}),\nmap(sets => {\nconst jobIds = onlyCraft ?\n@@ -93,7 +92,7 @@ export class DataService {\n});\n}\n});\n- return sets;\n+ return sets.sort((a, b) => a.jobId - b.jobId);\n})\n);\n})\n",
"new_path": "src/app/core/api/data.service.ts",
"old_path": "src/app/core/api/data.service.ts"
},
{
"change_type": "MODIFY",
"diff": "<mat-select *ngIf=\"customMode\"\n[placeholder]=\"'SIMULATOR.CONFIGURATION.Select_job' | translate\"\n[(ngModel)]=\"selectedSet\"\n- (ngModelChange)=\"applyStats(selectedSet)\">\n+ (ngModelChange)=\"applyStats(selectedSet, levels)\">\n<mat-option *ngFor=\"let set of gearsets\" [value]=\"set\">\n{{set.jobId | jobName | i18n}} (ilvl {{set.ilvl}}) <span *ngIf=\"set.specialist\">({{'SIMULATOR.Specialist' | translate}})</span>\n</mat-option>\n{{'SIMULATOR.CONFIGURATION.Specialist' | translate}}\n</mat-checkbox>\n</div>\n- <button mat-raised-button color=\"accent\" (click)=\"applyStats(selectedSet)\">\n+ <button mat-raised-button color=\"accent\" (click)=\"applyStats(selectedSet, levels)\">\n{{'SIMULATOR.CONFIGURATION.Apply_stats' | translate}}\n</button>\n</div>\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.html",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -299,7 +299,7 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n}),\ntap(sets => this.levels = <CrafterLevels>sets.map(set => set.level))\n);\n- })\n+ }),\n);\nthis.simulation$ = combineLatest(\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -3,9 +3,9 @@ export enum CraftingJob {\nCRP = 0,\nBSM = 1,\nARM = 2,\n- LTW = 3,\n- WVR = 4,\n- GSM = 5,\n+ GSM = 3,\n+ LTW = 4,\n+ WVR = 5,\nALC = 6,\nCUL = 7,\n}\n",
"new_path": "src/app/pages/simulator/model/crafting-job.enum.ts",
"old_path": "src/app/pages/simulator/model/crafting-job.enum.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): custom stats now save properly
closes #365 | 1 | fix | simulator |
217,922 | 25.05.2018 14:37:20 | -7,200 | 453635205354698709bd99f604a2328ec5808452 | feat: alarms page now adds all spawns of an item at once | [
{
"change_type": "MODIFY",
"diff": "<input type=\"text\" matInput #searchInput [(ngModel)]=\"itemName\" placeholder=\"{{'Item_name' | translate}}\">\n</mat-form-field>\n<mat-list dense>\n- <mat-list-item *ngFor=\"let node of results | async\">\n- <img mat-list-avatar src=\"{{node.icon | icon}}\" alt=\"\" [appXivdbTooltip]=\"node.itemId\">\n- <span matLine>{{node.itemId | itemName | i18n}} - lvl {{node.lvl}}</span>\n- <span matLine>{{node.zoneId | placeName | i18n}} - {{node.placeId | placeName | i18n}}\n- <span *ngIf=\"node.slot\">({{node.slot}})</span>\n- </span>\n- <span matLine>X: {{node.coords[0]}} - Y: {{node.coords[1]}}</span>\n- <button mat-mini-fab (click)=\"close(node)\">\n+ <mat-list-item *ngFor=\"let row of results | async\">\n+ <img mat-list-avatar src=\"{{row.icon | icon}}\" alt=\"\" [appXivdbTooltip]=\"row.itemId\">\n+ <span matLine>{{row.itemId | itemName | i18n}}</span>\n+ <button mat-mini-fab (click)=\"close(row.nodes)\">\n<mat-icon>alarm_add</mat-icon>\n</button>\n</mat-list-item>\n",
"new_path": "src/app/pages/alarms/add-alarm-popup/add-alarm-popup.component.html",
"old_path": "src/app/pages/alarms/add-alarm-popup/add-alarm-popup.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -23,8 +23,12 @@ export class AddAlarmPopupComponent implements OnInit {\nprivate localizedDataService: LocalizedDataService) {\n}\n- close(node: any): void {\n- this.dialogRef.close(node);\n+ close(nodes: any[]): void {\n+ this.dialogRef.close(nodes.map(node => {\n+ node.zoneId = this.localizedDataService.getAreaIdByENName(node.zone);\n+ node.placeId = this.localizedDataService.getAreaIdByENName(node.title);\n+ return node;\n+ }));\n}\nngOnInit() {\n@@ -35,11 +39,16 @@ export class AddAlarmPopupComponent implements OnInit {\nreturn this.bellNodesService.getNodesByItemName(this.itemName);\n}),\nmap((nodes) => {\n- return nodes.map(node => {\n- node.zoneId = this.localizedDataService.getAreaIdByENName(node.zone);\n- node.placeId = this.localizedDataService.getAreaIdByENName(node.title);\n- return node;\n- })\n+ const res = [];\n+ nodes.forEach((node) => {\n+ const resRow = res.find(n => n.itemId === node.itemId);\n+ if (resRow === undefined) {\n+ res.push({itemId: node.itemId, icon: node.icon, nodes: [node]});\n+ } else {\n+ resRow.nodes.push(node);\n+ }\n+ });\n+ return res;\n})\n);\n}\n",
"new_path": "src/app/pages/alarms/add-alarm-popup/add-alarm-popup.component.ts",
"old_path": "src/app/pages/alarms/add-alarm-popup/add-alarm-popup.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -85,8 +85,9 @@ export class AlarmsComponent {\nopenAddAlarmPopup(): void {\nthis.dialog.open(AddAlarmPopupComponent).afterClosed()\n.pipe(filter(result => result !== undefined))\n- .subscribe((node: any) => {\n+ .subscribe((nodes: any[]) => {\nconst alarms: Alarm[] = [];\n+ nodes.forEach(node => {\nif (node.time !== undefined) {\nnode.time.forEach(spawn => {\nalarms.push({\n@@ -102,6 +103,7 @@ export class AlarmsComponent {\n});\n});\n}\n+ });\nthis.alarmService.registerAlarms(...alarms);\nthis.reloader.next(null);\n});\n",
"new_path": "src/app/pages/alarms/alarms/alarms.component.ts",
"old_path": "src/app/pages/alarms/alarms/alarms.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: alarms page now adds all spawns of an item at once | 1 | feat | null |
217,922 | 25.05.2018 15:49:19 | -7,200 | 9095c3d304b5a7cee6b758892e71e5d5ec354e05 | feat(simulator): new step by step report popup
closes | [
{
"change_type": "MODIFY",
"diff": "(click)=\"showMinStats(simulation)\">\n<mat-icon>offline_pin</mat-icon>\n</button>\n+ <button mat-mini-fab\n+ *ngIf=\"result$ | async as result\"\n+ matTooltip=\"{{'SIMULATOR.Step_by_step_report' | translate}}\"\n+ matTooltipPosition=\"{{isMobile()?'below':'right'}}\"\n+ (click)=\"showStepByStepReport(result)\">\n+ <mat-icon>format_list_numbered</mat-icon>\n+ </button>\n</div>\n<mat-expansion-panel [expanded]=\"customMode\" #configPanel>\n<mat-expansion-panel-header>\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.html",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.html"
},
{
"change_type": "MODIFY",
"diff": "position: fixed;\ndisplay: flex;\nflex-direction: column;\n+ flex-wrap: wrap;\ntransform: translateX(-145%);\n&.mobile {\nflex-direction: row;\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.scss",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -35,6 +35,7 @@ import {I18nToolsService} from '../../../../core/tools/i18n-tools.service';\nimport {AppUser} from 'app/model/list/app-user';\nimport {debounceTime, filter, first, map, mergeMap, tap} from 'rxjs/operators';\nimport {CraftingJob} from '../../model/crafting-job.enum';\n+import {StepByStepReportPopupComponent} from '../step-by-step-report-popup/step-by-step-report-popup.component';\n@Component({\nselector: 'app-simulator',\n@@ -407,6 +408,10 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n});\n}\n+ showStepByStepReport(result: SimulationResult): void {\n+ this.dialog.open(StepByStepReportPopupComponent, {data: result});\n+ }\n+\ngenerateMacro(): void {\nthis.crafterStats$\n.pipe(\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
},
{
"change_type": "ADD",
"diff": "+<h3>{{'SIMULATOR.Step_by_step_report' | translate}}</h3>\n+<div mat-dialog-content class=\"table-container\" [class.mobile]=\"isMobile()\">\n+ <table mat-table [dataSource]=\"dataSource\">\n+ <ng-container matColumnDef=\"position\">\n+ <th mat-header-cell *matHeaderCellDef> Step</th>\n+ <td mat-cell *matCellDef=\"let element\"> {{element.position}}</td>\n+ </ng-container>\n+ <ng-container matColumnDef=\"action\" *ngIf=\"!isMobile()\">\n+ <th mat-header-cell *matHeaderCellDef>Action</th>\n+ <td mat-cell *matCellDef=\"let element\" class=\"action\">\n+ <app-action [action]=\"element.action\" [hideCost]=\"true\" [simulation]=\"data.simulation\"></app-action>\n+ </td>\n+ </ng-container>\n+ <ng-container matColumnDef=\"cpDifference\">\n+ <th mat-header-cell *matHeaderCellDef>CP</th>\n+ <td mat-cell *matCellDef=\"let element\">\n+ {{element.cpDifference >= 0?'+':'-'}} {{element.cpDifference}}\n+ </td>\n+ </ng-container>\n+ <ng-container matColumnDef=\"solidityDifference\">\n+ <th mat-header-cell *matHeaderCellDef>Durability</th>\n+ <td mat-cell *matCellDef=\"let element\">\n+ {{element.solidityDifference >= 0?'+':'-'}}{{element.solidityDifference}}\n+ </td>\n+ </ng-container>\n+ <ng-container matColumnDef=\"addedQuality\">\n+ <th mat-header-cell *matHeaderCellDef>Quality</th>\n+ <td mat-cell *matCellDef=\"let element\">\n+ {{element.addedQuality}}\n+ </td>\n+ </ng-container>\n+ <ng-container matColumnDef=\"addedProgression\">\n+ <th mat-header-cell *matHeaderCellDef>Progress</th>\n+ <td mat-cell *matCellDef=\"let element\">\n+ {{element.addedProgression}}\n+ </td>\n+ </ng-container>\n+ <tr mat-header-row *matHeaderRowDef=\"columnsToDisplay\"></tr>\n+ <tr mat-row *matRowDef=\"let myRowData; columns: columnsToDisplay\"></tr>\n+ </table>\n+</div>\n+<div mat-dialog-actions>\n+ <button mat-raised-button mat-dialog-close color=\"accent\">{{'Close' | translate}}</button>\n+</div>\n",
"new_path": "src/app/pages/simulator/components/step-by-step-report-popup/step-by-step-report-popup.component.html",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+.table-container {\n+ min-width: 500px;\n+ padding-bottom: 20px;\n+ &.mobile {\n+ min-width: 250px;\n+ padding-bottom: 10px;\n+ }\n+ table {\n+ width: 100%;\n+ .action {\n+ width: 40px;\n+ }\n+ }\n+}\n",
"new_path": "src/app/pages/simulator/components/step-by-step-report-popup/step-by-step-report-popup.component.scss",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import {Component, Inject} from '@angular/core';\n+import {MAT_DIALOG_DATA} from '@angular/material';\n+import {SimulationResult} from '../../simulation/simulation-result';\n+import {ObservableMedia} from '@angular/flex-layout';\n+\n+@Component({\n+ selector: 'app-step-by-step-report-popup',\n+ templateUrl: './step-by-step-report-popup.component.html',\n+ styleUrls: ['./step-by-step-report-popup.component.scss']\n+})\n+export class StepByStepReportPopupComponent {\n+\n+ dataSource: any[];\n+\n+ columnsToDisplay = this.isMobile() ? ['position', 'cpDifference', 'solidityDifference', 'addedQuality', 'addedProgression'] :\n+ ['position', 'action', 'cpDifference', 'solidityDifference', 'addedQuality', 'addedProgression'];\n+\n+ constructor(@Inject(MAT_DIALOG_DATA) public data: SimulationResult, private media: ObservableMedia) {\n+ this.dataSource = data.steps.map((row, index) => {\n+ (<any>row).position = index;\n+ return row;\n+ });\n+ }\n+\n+ isMobile(): boolean {\n+ return this.media.isActive('xs') || this.media.isActive('sm');\n+ }\n+\n+}\n",
"new_path": "src/app/pages/simulator/components/step-by-step-report-popup/step-by-step-report-popup.component.ts",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -166,6 +166,7 @@ export class Simulation {\nconst probabilityRoll = linear ? 0 : Math.random() * 100;\nconst qualityBefore = this.quality;\nconst progressionBefore = this.progression;\n+ const durabilityBefore = this.durability;\nif (action.getSuccessRate(this) >= probabilityRoll) {\naction.execute(this);\n} else {\n@@ -184,7 +185,7 @@ export class Simulation {\naddedProgression: this.progression - progressionBefore,\ncpDifference: CPCost,\nskipped: false,\n- solidityDifference: action.getDurabilityCost(this),\n+ solidityDifference: this.durability - durabilityBefore,\nstate: this.state\n});\nif (this.progression >= this.recipe.progress) {\n",
"new_path": "src/app/pages/simulator/simulation/simulation.ts",
"old_path": "src/app/pages/simulator/simulation/simulation.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -29,6 +29,7 @@ import {\nMatProgressSpinnerModule,\nMatSelectModule,\nMatSnackBarModule,\n+ MatTableModule,\nMatTooltipModule,\n} from '@angular/material';\nimport {MacroPopupComponent} from './components/macro-popup/macro-popup.component';\n@@ -39,6 +40,7 @@ import {SimulationMinStatsPopupComponent} from './components/simulation-min-stat\nimport {ImportMacroPopupComponent} from './components/import-macro-popup/import-macro-popup.component';\nimport {ConsumablesService} from './model/consumables.service';\nimport {RotationNamePopupComponent} from './components/rotation-name-popup/rotation-name-popup.component';\n+import {StepByStepReportPopupComponent} from './components/step-by-step-report-popup/step-by-step-report-popup.component';\nconst routes: Routes = [\n{\n@@ -96,6 +98,7 @@ const routes: Routes = [\nMatProgressSpinnerModule,\nMatDialogModule,\nMatSnackBarModule,\n+ MatTableModule,\nClipboardModule,\n@@ -116,14 +119,16 @@ const routes: Routes = [\nImportMacroPopupComponent,\nMacroPopupComponent,\nSimulationMinStatsPopupComponent,\n- RotationNamePopupComponent\n+ RotationNamePopupComponent,\n+ StepByStepReportPopupComponent\n],\nentryComponents: [\nImportRotationPopupComponent,\nImportMacroPopupComponent,\nMacroPopupComponent,\nSimulationMinStatsPopupComponent,\n- RotationNamePopupComponent\n+ RotationNamePopupComponent,\n+ StepByStepReportPopupComponent\n],\nproviders: [\nCraftingActionsRegistry,\n",
"new_path": "src/app/pages/simulator/simulator.module.ts",
"old_path": "src/app/pages/simulator/simulator.module.ts"
},
{
"change_type": "MODIFY",
"diff": "\"Rename_rotation\": \"Rename Rotation\",\n\"Cross_class_setup\": \"Cross-class skills setup\",\n\"Include_sound_end\": \"Include end of macro sound\",\n+ \"Step_by_step_report\": \"Step by step report\",\n\"CUSTOM\": {\n\"Recipe_configuration\": \"Recipe configuration\",\n\"Recipe_level\": \"Recipe level\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat(simulator): new step by step report popup
closes #364 | 1 | feat | simulator |
217,922 | 25.05.2018 16:05:41 | -7,200 | f6eca9f23e15efab81dbeb99db4a05dab928e4e3 | fix: fixed an issue with shared lists not being visible | [
{
"change_type": "MODIFY",
"diff": "@@ -279,15 +279,20 @@ export class ListsComponent extends ComponentWithSubscriptions implements OnInit\nngOnInit() {\nthis.sharedLists = this.userService.getUserData().pipe(\nmergeMap(user => {\n- return combineLatest((user.sharedLists || [])\n- .map(listId => this.listService.get(listId)\n+ return combineLatest((user.sharedLists || []).map(listId => this.listService.get(listId)\n.pipe(\ncatchError(() => {\nuser.sharedLists = user.sharedLists.filter(id => id !== listId);\nreturn this.userService.set(user.$key, user).pipe(map(() => null));\n- }),\n- map(lists => lists.filter(l => l !== null).filter(l => l.getPermissions(user.$key).write === true))\n- )));\n+ })\n+ )\n+ )\n+ )\n+ .pipe(\n+ map(lists => lists.filter(l => l !== null).filter(l => {\n+ return l.getPermissions(user.$key).write === true\n+ }))\n+ );\n})\n);\nthis.workshops = this.userService.getUserData().pipe(\n",
"new_path": "src/app/pages/lists/lists/lists.component.ts",
"old_path": "src/app/pages/lists/lists/lists.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed an issue with shared lists not being visible | 1 | fix | null |
217,922 | 25.05.2018 16:11:28 | -7,200 | bf22ca5fd83515f0139456ba14ef2cdec8f58b7a | chore: aot fixes and translations | [
{
"change_type": "MODIFY",
"diff": "@@ -24,7 +24,7 @@ export class MacroPopupComponent implements OnInit {\nprivate i18n: I18nToolsService) {\n}\n- private generateMacros(): void {\n+ public generateMacros(): void {\nthis.macro = [[]];\nthis.aactionsMacro = ['/aaction clear'];\nthis.data.rotation.forEach((action) => {\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: aot fixes and translations | 1 | chore | null |
217,922 | 25.05.2018 16:13:16 | -7,200 | 82cd4b3ce9633fb846cb36f6675eec18b920c883 | chore: no more -a switch for standard-version | [
{
"change_type": "MODIFY",
"diff": "\"build:prod\": \"node ./build/prebuild.js && ng build --prod\",\n\"build:electron-prod\": \"node ./build/prebuild.js && ng build --configuration=electron\",\n\"build:beta\": \"node ./build/prebuild.js && ng build --configuration=beta\",\n- \"standard-version\": \"standard-version -a\",\n- \"standard-version:patch\": \"standard-version -a --release-as patch\",\n- \"standard-version:minor\": \"standard-version -a --release-as minor\",\n+ \"standard-version\": \"standard-version\",\n+ \"standard-version:patch\": \"standard-version --release-as patch\",\n+ \"standard-version:minor\": \"standard-version --release-as minor\",\n\"standard-version:dry\": \"standard-version --dry-run\",\n\"release:prod\": \"git push --follow-tags origin master\",\n\"release:beta\": \"npm run standard-version -- --prerelease beta && git push --follow-tags origin beta\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: no more -a switch for standard-version | 1 | chore | null |
217,922 | 25.05.2018 16:28:55 | -7,200 | baa65555bc777877a29601b743d6b977a8379d85 | style: less red for disabled actions | [
{
"change_type": "MODIFY",
"diff": "width: 100%;\nheight: 100%;\nborder-radius: 5px;\n- background-color: red;\n+ background-color: rgb(255, 150, 150);\nopacity: .4;\n}\n.cost {\n",
"new_path": "src/app/pages/simulator/components/action/action.component.scss",
"old_path": "src/app/pages/simulator/components/action/action.component.scss"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | style: less red for disabled actions | 1 | style | null |
217,922 | 25.05.2018 16:49:45 | -7,200 | 4af1fc4253c7a48a1119fdb7698a1700d0c4266a | chore: various critical fixes | [
{
"change_type": "MODIFY",
"diff": "@@ -24,7 +24,7 @@ export class LayoutService {\n.pipe(\nmap(userData => {\nconst layouts = userData.layouts;\n- if (layouts === undefined || layouts === null || layouts.length === 0 || layouts[0].name === 'Default layout') {\n+ if (layouts === undefined || layouts === null || layouts.length === 0 || (layouts.length === 1 && layouts[0].name === 'Default layout')) {\nreturn [new ListLayout('Default layout', this.defaultLayout)];\n}\nreturn layouts;\n",
"new_path": "src/app/core/layout/layout.service.ts",
"old_path": "src/app/core/layout/layout.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -30,9 +30,9 @@ export class ProfileComponent extends PageComponent {\n{abbr: 'CRP', name: 'carpenter'},\n{abbr: 'BSM', name: 'blacksmith'},\n{abbr: 'ARM', name: 'armorer'},\n+ {abbr: 'GSM', name: 'goldsmith'},\n{abbr: 'LTW', name: 'leatherworker'},\n{abbr: 'WVR', name: 'weaver'},\n- {abbr: 'GSM', name: 'goldsmith'},\n{abbr: 'ALC', name: 'alchemist'},\n{abbr: 'CUL', name: 'culinarian'},\n{abbr: 'MIN', name: 'miner'},\n",
"new_path": "src/app/pages/profile/profile/profile.component.ts",
"old_path": "src/app/pages/profile/profile/profile.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | chore: various critical fixes | 1 | chore | null |
217,902 | 25.05.2018 17:52:02 | -10,800 | a571ef6173fd5402bbdcae179a88583e7a9c498b | fix: fixes missing linebreaks when copying macro from firefox | [
{
"change_type": "MODIFY",
"diff": "</mat-checkbox>\n<div class=\"macro\">\n<pre *ngFor=\"let macroFragment of macro\" class=\"macro-fragment\">\n- <span class=\"macro-line\" *ngFor=\"let line of macroFragment\">{{line}}</span>\n+ <span class=\"macro-line\" *ngFor=\"let line of macroFragment\">{{line}}<br></span>\n</pre>\n</div>\n<b>{{'SIMULATOR.Cross_class_setup' | translate}}</b>\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.html",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.html"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixes missing linebreaks when copying macro from firefox | 1 | fix | null |
217,922 | 25.05.2018 19:48:27 | -7,200 | 7432a9a9c9b012eb9faf8ba9e8f75efbf6813abd | fix(simulator): fixed an issue with Specialty: Refurbish
closes | [
{
"change_type": "MODIFY",
"diff": "@@ -5,7 +5,7 @@ export class SpecialtyRefurbish extends SpecialtyAction {\napplyReflect(simulation: Simulation): void {\nsimulation.availableCP += 65;\n- if (simulation.availableCP < simulation.maxCP) {\n+ if (simulation.availableCP > simulation.maxCP) {\nsimulation.availableCP = simulation.maxCP;\n}\n}\n",
"new_path": "src/app/pages/simulator/model/actions/other/specialty-refurbish.ts",
"old_path": "src/app/pages/simulator/model/actions/other/specialty-refurbish.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): fixed an issue with Specialty: Refurbish
closes #371 | 1 | fix | simulator |
217,922 | 25.05.2018 19:53:19 | -7,200 | 2b29f97bb9015bca59f6b31e65a6ca61958c1c86 | fix(simulator): better report amounts for step by step report | [
{
"change_type": "MODIFY",
"diff": "<ng-container matColumnDef=\"cpDifference\">\n<th mat-header-cell *matHeaderCellDef>CP</th>\n<td mat-cell *matCellDef=\"let element\">\n- {{element.cpDifference >= 0?'+':'-'}} {{element.cpDifference}}\n+ {{element.cpDifference >= 0?'+':''}}{{element.cpDifference}}\n</td>\n</ng-container>\n<ng-container matColumnDef=\"solidityDifference\">\n<th mat-header-cell *matHeaderCellDef>Durability</th>\n<td mat-cell *matCellDef=\"let element\">\n- {{element.solidityDifference >= 0?'+':'-'}}{{element.solidityDifference}}\n+ {{element.solidityDifference >= 0?'+':''}}{{element.solidityDifference}}\n</td>\n</ng-container>\n<ng-container matColumnDef=\"addedQuality\">\n",
"new_path": "src/app/pages/simulator/components/step-by-step-report-popup/step-by-step-report-popup.component.html",
"old_path": "src/app/pages/simulator/components/step-by-step-report-popup/step-by-step-report-popup.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -167,6 +167,7 @@ export class Simulation {\nconst qualityBefore = this.quality;\nconst progressionBefore = this.progression;\nconst durabilityBefore = this.durability;\n+ const cpBefore = this.availableCP;\nif (action.getSuccessRate(this) >= probabilityRoll) {\naction.execute(this);\n} else {\n@@ -174,16 +175,15 @@ export class Simulation {\n}\n// Even if the action failed, we have to remove the durability cost\nthis.durability -= action.getDurabilityCost(this);\n- const CPCost = action.getCPCost(this, linear);\n// Even if the action failed, CP has to be consumed too\n- this.availableCP -= CPCost;\n+ this.availableCP -= action.getCPCost(this, linear);\n// Push the result to the result array\nthis.steps.push({\naction: action,\nsuccess: action.getSuccessRate(this) >= probabilityRoll,\naddedQuality: this.quality - qualityBefore,\naddedProgression: this.progression - progressionBefore,\n- cpDifference: CPCost,\n+ cpDifference: this.availableCP - cpBefore,\nskipped: false,\nsolidityDifference: this.durability - durabilityBefore,\nstate: this.state\n",
"new_path": "src/app/pages/simulator/simulation/simulation.ts",
"old_path": "src/app/pages/simulator/simulation/simulation.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): better report amounts for step by step report | 1 | fix | simulator |
217,922 | 26.05.2018 12:14:29 | -7,200 | f868827d35942e8507cb23946252bcff65cd48f3 | feat(simulator): added audio signal for end of cross class setup | [
{
"change_type": "MODIFY",
"diff": "@@ -51,6 +51,9 @@ export class MacroPopupComponent implements OnInit {\nif (this.macro[this.macro.length - 1].length < 15 && this.addEcho) {\nthis.macro[this.macro.length - 1].push('/echo Craft finished <se.4>')\n}\n+ if (this.aactionsMacro.length > 0) {\n+ this.aactionsMacro.push('/echo Cross class setup finished <se.4>');\n+ }\n}\nngOnInit() {\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat(simulator): added audio signal for end of cross class setup
#373 | 1 | feat | simulator |
217,922 | 26.05.2018 12:19:07 | -7,200 | ceca8592aac62260e81fe0ebf4d2c494a7eb52d8 | fix(simulator): brand/name actions no longer taken as cross class action
closes | [
{
"change_type": "MODIFY",
"diff": "import {BuffAction} from '../buff-action';\nimport {Simulation} from '../../../simulation/simulation';\nimport {Buff} from '../../buff.enum';\n-import {CraftingJob} from '../../crafting-job.enum';\nexport abstract class NameOfBuff extends BuffAction {\n- getLevelRequirement(): { job: CraftingJob; level: number } {\n- return {job: CraftingJob.ANY, level: 54};\n- }\n-\n_canBeUsed(simulation: Simulation): boolean {\nreturn !simulation.hasBuff(Buff.NAME_OF_FIRE)\n&& !simulation.hasBuff(Buff.NAME_OF_LIGHTNING)\n",
"new_path": "src/app/pages/simulator/model/actions/buff/name-of-buff.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/name-of-buff.ts"
},
{
"change_type": "MODIFY",
"diff": "import {NameOfBuff} from './name-of-buff';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class NameOfEarth extends NameOfBuff {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.LTW, level: 54};\n+ }\n+\nprotected getBuff(): Buff {\nreturn Buff.NAME_OF_EARTH;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/buff/name-of-earth.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/name-of-earth.ts"
},
{
"change_type": "MODIFY",
"diff": "import {NameOfBuff} from './name-of-buff';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class NameOfFire extends NameOfBuff {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.BSM, level: 54};\n+ }\n+\nprotected getBuff(): Buff {\nreturn Buff.NAME_OF_FIRE;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/buff/name-of-fire.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/name-of-fire.ts"
},
{
"change_type": "MODIFY",
"diff": "import {NameOfBuff} from './name-of-buff';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class NameOfIce extends NameOfBuff {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.ARM, level: 54};\n+ }\n+\nprotected getBuff(): Buff {\nreturn Buff.NAME_OF_ICE;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/buff/name-of-ice.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/name-of-ice.ts"
},
{
"change_type": "MODIFY",
"diff": "import {NameOfBuff} from './name-of-buff';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class NameOfLightning extends NameOfBuff {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.WVR, level: 54};\n+ }\n+\nprotected getBuff(): Buff {\nreturn Buff.NAME_OF_LIGHTNING;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/buff/name-of-lightning.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/name-of-lightning.ts"
},
{
"change_type": "MODIFY",
"diff": "import {NameOfBuff} from './name-of-buff';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class NameOfTheWind extends NameOfBuff {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.CRP, level: 54};\n+ }\n+\nprotected getBuff(): Buff {\nreturn Buff.NAME_OF_THE_WIND;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/buff/name-of-the-wind.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/name-of-the-wind.ts"
},
{
"change_type": "MODIFY",
"diff": "import {NameOfBuff} from './name-of-buff';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class NameOfWater extends NameOfBuff {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.ALC, level: 54};\n+ }\n+\nprotected getBuff(): Buff {\nreturn Buff.NAME_OF_WATER;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/buff/name-of-water.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/name-of-water.ts"
},
{
"change_type": "MODIFY",
"diff": "import {ProgressAction} from '../progress-action';\nimport {Simulation} from '../../../simulation/simulation';\nimport {Buff} from '../../buff.enum';\n-import {CraftingJob} from '../../crafting-job.enum';\nexport abstract class BrandAction extends ProgressAction {\n- getLevelRequirement(): { job: CraftingJob; level: number } {\n- return {job: CraftingJob.ANY, level: 37};\n- }\n-\nabstract getBuffedBy(): Buff;\n_canBeUsed(simulationState: Simulation, linear?: boolean): boolean {\n",
"new_path": "src/app/pages/simulator/model/actions/progression/brand-action.ts",
"old_path": "src/app/pages/simulator/model/actions/progression/brand-action.ts"
},
{
"change_type": "MODIFY",
"diff": "import {BrandAction} from './brand-action';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class BrandOfEarth extends BrandAction {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.LTW, level: 37};\n+ }\n+\ngetBuffedBy(): Buff {\nreturn Buff.NAME_OF_EARTH;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/progression/brand-of-earth.ts",
"old_path": "src/app/pages/simulator/model/actions/progression/brand-of-earth.ts"
},
{
"change_type": "MODIFY",
"diff": "import {BrandAction} from './brand-action';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class BrandOfFire extends BrandAction {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.BSM, level: 37};\n+ }\n+\ngetBuffedBy(): Buff {\nreturn Buff.NAME_OF_FIRE;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/progression/brand-of-fire.ts",
"old_path": "src/app/pages/simulator/model/actions/progression/brand-of-fire.ts"
},
{
"change_type": "MODIFY",
"diff": "import {BrandAction} from './brand-action';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class BrandOfIce extends BrandAction {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.ARM, level: 37};\n+ }\n+\ngetBuffedBy(): Buff {\nreturn Buff.NAME_OF_ICE;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/progression/brand-of-ice.ts",
"old_path": "src/app/pages/simulator/model/actions/progression/brand-of-ice.ts"
},
{
"change_type": "MODIFY",
"diff": "import {BrandAction} from './brand-action';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class BrandOfLightning extends BrandAction {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.WVR, level: 37};\n+ }\n+\ngetBuffedBy(): Buff {\nreturn Buff.NAME_OF_LIGHTNING;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/progression/brand-of-lightning.ts",
"old_path": "src/app/pages/simulator/model/actions/progression/brand-of-lightning.ts"
},
{
"change_type": "MODIFY",
"diff": "import {BrandAction} from './brand-action';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class BrandOfWater extends BrandAction {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.ALC, level: 37};\n+ }\n+\ngetBuffedBy(): Buff {\nreturn Buff.NAME_OF_WATER;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/progression/brand-of-water.ts",
"old_path": "src/app/pages/simulator/model/actions/progression/brand-of-water.ts"
},
{
"change_type": "MODIFY",
"diff": "import {BrandAction} from './brand-action';\nimport {Buff} from '../../buff.enum';\n+import {CraftingJob} from '../../crafting-job.enum';\nexport class BrandOfWind extends BrandAction {\n+ getLevelRequirement(): { job: CraftingJob; level: number } {\n+ return {job: CraftingJob.CRP, level: 37};\n+ }\n+\ngetBuffedBy(): Buff {\nreturn Buff.NAME_OF_THE_WIND;\n}\n",
"new_path": "src/app/pages/simulator/model/actions/progression/brand-of-wind.ts",
"old_path": "src/app/pages/simulator/model/actions/progression/brand-of-wind.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): brand/name actions no longer taken as cross class action
closes #373 | 1 | fix | simulator |
217,922 | 26.05.2018 12:40:06 | -7,200 | 283f01deecda47033b5a8837303077ea82dbf3eb | feat(layout): you can now order by job in layout panels | [
{
"change_type": "MODIFY",
"diff": "@@ -7,6 +7,21 @@ import {LocalizedDataService} from '../data/localized-data.service';\n@Injectable()\nexport class LayoutOrderService {\n+ private static JOBS = [\n+ 'carpenter',\n+ 'blacksmith',\n+ 'armorer',\n+ 'goldsmith',\n+ 'leatherworker',\n+ 'weaver',\n+ 'alchemist',\n+ 'culinarian',\n+ 'miner',\n+ 'botanist',\n+ 'fisher'\n+ ];\n+\n+\nprivate orderFunctions: { [index: string]: (rowA: ListRow, rowB: ListRow) => number } = {\n'NAME': (a, b) => {\nconst aName: string = this.localizedData.getItem(a.id)[this.translate.currentLang];\n@@ -20,6 +35,14 @@ export class LayoutOrderService {\nconst bName: string = this.localizedData.getItem(b.id)[this.translate.currentLang];\n// If same level, order by name for these two\nreturn aLevel === bLevel ? aName > bName ? 1 : -1 : aLevel - bLevel;\n+ },\n+ 'JOB': (a, b) => {\n+ const aJobId = this.getJobId(a);\n+ const bJobId = this.getJobId(b);\n+ // If same job, order by level for these two\n+ const aLevel = this.getLevel(a);\n+ const bLevel = this.getLevel(b);\n+ return aJobId === bJobId ? aLevel > bLevel ? 1 : -1 : aJobId - bJobId;\n}\n};\n@@ -35,6 +58,25 @@ export class LayoutOrderService {\nreturn order === LayoutRowOrder.ASC ? orderedASC : orderedASC.reverse();\n}\n+ private getJobId(row: ListRow): number {\n+ if (row.craftedBy !== undefined) {\n+ // Returns the lowest level available for the craft.\n+ const jobName = LayoutOrderService.JOBS.find(job => row.craftedBy[0].icon.indexOf(job) > -1);\n+ if (jobName !== undefined) {\n+ return LayoutOrderService.JOBS.indexOf(jobName);\n+ }\n+ return 0;\n+ }\n+ if (row.gatheredBy !== undefined) {\n+ const jobName = LayoutOrderService.JOBS.find(job => row.gatheredBy.icon.indexOf(job) > -1);\n+ if (jobName !== undefined) {\n+ return LayoutOrderService.JOBS.indexOf(jobName);\n+ }\n+ return 0;\n+ }\n+ return 0;\n+ }\n+\nprivate getLevel(row: ListRow): number {\nif (row.craftedBy !== undefined) {\n// Returns the lowest level available for the craft.\n",
"new_path": "src/app/core/layout/layout-order.service.ts",
"old_path": "src/app/core/layout/layout-order.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -24,7 +24,8 @@ export class LayoutService {\n.pipe(\nmap(userData => {\nconst layouts = userData.layouts;\n- if (layouts === undefined || layouts === null || layouts.length === 0 || (layouts.length === 1 && layouts[0].name === 'Default layout')) {\n+ if (layouts === undefined || layouts === null || layouts.length === 0 ||\n+ (layouts.length === 1 && layouts[0].name === 'Default layout')) {\nreturn [new ListLayout('Default layout', this.defaultLayout)];\n}\nreturn layouts;\n@@ -98,7 +99,7 @@ export class LayoutService {\n}\npublic getLayout(index: number): Observable<ListLayout> {\n- return this._layouts.pipe(map(layouts => layouts[index]));\n+ return this._layouts.pipe(map(layouts => layouts[index] || new ListLayout('Default layout', this.defaultLayout)));\n}\npublic get layouts(): Observable<ListLayout[]> {\n@@ -118,15 +119,25 @@ export class LayoutService {\npublic get defaultLayout(): LayoutRow[] {\nreturn [\n- new LayoutRow('Timed nodes', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_TIMED.name, 0, true, false, true),\n- new LayoutRow('Vendors ', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.CAN_BE_BOUGHT.name, 1, false, true, true),\n- new LayoutRow('Reducible', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_REDUCTION.name, 2, false, false, true),\n- new LayoutRow('Tomes/Tokens/Scripts', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_TOKEN_TRADE.name, 3, false, false, true),\n- new LayoutRow('Fishing', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_GATHERED_BY_FSH.name, 4, false, false, true),\n- new LayoutRow('Gatherings', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_GATHERING.name, 5, true, false, true),\n- new LayoutRow('Dungeons/Drops or GC', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_MONSTER_DROP.name + ':or:' + LayoutRowFilter.IS_GC_TRADE.name, 6, false, false, true),\n- new LayoutRow('Pre_crafts', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_CRAFT.name, 8, false, true, true),\n- new LayoutRow('Other', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.ANYTHING.name, 7, true, false, true),\n+ new LayoutRow('Timed nodes', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_TIMED.name,\n+ 0, true, false, true),\n+ new LayoutRow('Vendors ', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.CAN_BE_BOUGHT.name,\n+ 1, false, true, true),\n+ new LayoutRow('Reducible', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_REDUCTION.name,\n+ 2, false, false, true),\n+ new LayoutRow('Tomes/Tokens/Scripts', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_TOKEN_TRADE.name,\n+ 3, false, false, true),\n+ new LayoutRow('Fishing', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_GATHERED_BY_FSH.name,\n+ 4, false, false, true),\n+ new LayoutRow('Gatherings', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_GATHERING.name,\n+ 5, true, false, true),\n+ new LayoutRow('Dungeons/Drops or GC', 'NAME', LayoutRowOrder.DESC,\n+ LayoutRowFilter.IS_MONSTER_DROP.name + ':or:' + LayoutRowFilter.IS_GC_TRADE.name,\n+ 6, false, false, true),\n+ new LayoutRow('Pre_crafts', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.IS_CRAFT.name,\n+ 8, false, true, true),\n+ new LayoutRow('Other', 'NAME', LayoutRowOrder.DESC, LayoutRowFilter.ANYTHING.name,\n+ 7, true, false, true),\n]\n}\n",
"new_path": "src/app/core/layout/layout.service.ts",
"old_path": "src/app/core/layout/layout.service.ts"
},
{
"change_type": "MODIFY",
"diff": "[(value)]=\"availableLayouts[selectedIndex].recipeOrderBy\">\n<mat-option value=\"NONE\">NONE</mat-option>\n<mat-option value=\"NAME\">NAME</mat-option>\n+ <mat-option value=\"JOB\">JOB</mat-option>\n<mat-option value=\"LEVEL\">LEVEL</mat-option>\n</mat-select>\n</mat-form-field>\n",
"new_path": "src/app/pages/list/list-layout-popup/list-layout-popup.component.html",
"old_path": "src/app/pages/list/list-layout-popup/list-layout-popup.component.html"
},
{
"change_type": "MODIFY",
"diff": "[(value)]=\"row.orderBy\" (change)=\"rowChanged()\">\n<mat-option value=\"NAME\">NAME</mat-option>\n<mat-option value=\"LEVEL\">LEVEL</mat-option>\n+ <mat-option value=\"JOB\">JOB</mat-option>\n</mat-select>\n</mat-form-field>\n<mat-form-field>\n",
"new_path": "src/app/pages/list/list-layout-popup/list-layout-row/list-layout-row.component.html",
"old_path": "src/app/pages/list/list-layout-popup/list-layout-row/list-layout-row.component.html"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat(layout): you can now order by job in layout panels | 1 | feat | layout |
217,922 | 26.05.2018 12:56:00 | -7,200 | bade69f3e2608c114519701d1a9173928000616d | fix(simulator): changed maker's mark wait for 3s instead of 2 | [
{
"change_type": "MODIFY",
"diff": "@@ -5,6 +5,10 @@ import {CraftingJob} from '../../crafting-job.enum';\nexport class MakersMark extends BuffAction {\n+ getWaitDuration(): number {\n+ return 3;\n+ }\n+\ngetLevelRequirement(): { job: CraftingJob; level: number } {\nreturn {job: CraftingJob.GSM, level: 54};\n}\n@@ -18,7 +22,7 @@ export class MakersMark extends BuffAction {\n}\ngetDuration(simulation: Simulation): number {\n- return Math.round(simulation.recipe.progress / 100);\n+ return Math.ceil(simulation.recipe.progress / 100);\n}\ngetIds(): number[] {\n",
"new_path": "src/app/pages/simulator/model/actions/buff/makers-mark.ts",
"old_path": "src/app/pages/simulator/model/actions/buff/makers-mark.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): changed maker's mark wait for 3s instead of 2 | 1 | fix | simulator |
217,922 | 26.05.2018 14:42:02 | -7,200 | 5a469033dae61e8f8065e7b99db029a672e08397 | feat: added more tooltips on list panel buttons | [
{
"change_type": "MODIFY",
"diff": "</button>\n<!--<input type=\"text\" #uri readonly hidden value=\"{{getLink()}}\">-->\n<button mat-icon-button *ngIf=\"buttons\" routerLink=\"/list/{{list.$key}}\"\n+ matTooltip=\"{{'LIST.BUTTONS.Open' | translate}}\" matTooltipPosition=\"above\"\n(click)=\"$event.stopPropagation()\">\n<mat-icon>playlist_play</mat-icon>\n</button>\n<button mat-icon-button *ngIf=\"!readonly && buttons && list.authorId === userUid\"\n+ matTooltip=\"{{'LIST.BUTTONS.Delete' | translate}}\" matTooltipPosition=\"above\"\n(click)=\"ondelete.emit(); $event.stopPropagation()\">\n<mat-icon>delete</mat-icon>\n</button>\n",
"new_path": "src/app/modules/common-components/list-panel/list-panel.component.html",
"old_path": "src/app/modules/common-components/list-panel/list-panel.component.html"
},
{
"change_type": "MODIFY",
"diff": "},\n\"LIST\": {\n\"Copied_x_times\": \"Copied {{count}} times\",\n- \"Enable_crystals_tracking\": \"Enable crystals tracking\"\n+ \"Enable_crystals_tracking\": \"Enable crystals tracking\",\n+ \"BUTTONS\": {\n+ \"Add_link_description\": \"Create a custom link for this list\",\n+ \"Create_template_description\": \"Create a template link for this list, which will create a copy of the list for whoever opens it\",\n+ \"Copy_template_url_description\": \"Copy the template link for this list, which will create a copy of the list for whoever opens it\",\n+ \"Share_description\": \"Copy share link to your clipboard\",\n+ \"Open\": \"Open list\",\n+ \"Open_description\": \"Access the list\",\n+ \"Delete\": \"Delete list\",\n+ \"Delete_description\": \"Deletes the list\",\n+ \"Delete_warning\": \"Deleting a list can't be undone\"\n+ }\n},\n\"LIST_DETAILS\": {\n\"List_finished\": \"List completed\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat: added more tooltips on list panel buttons | 1 | feat | null |
217,922 | 26.05.2018 19:38:42 | -7,200 | 4c6755bcbd7c9175dabc70de69ae4d9b4f6590e7 | fix: layout order by job is no longer flickering | [
{
"change_type": "MODIFY",
"diff": "@@ -42,7 +42,20 @@ export class LayoutOrderService {\n// If same job, order by level for these two\nconst aLevel = this.getLevel(a);\nconst bLevel = this.getLevel(b);\n- return aJobId === bJobId ? aLevel > bLevel ? 1 : -1 : aJobId - bJobId;\n+ // If same level, order by name\n+ const aName: string = this.localizedData.getItem(a.id)[this.translate.currentLang];\n+ const bName: string = this.localizedData.getItem(b.id)[this.translate.currentLang];\n+ if (aJobId === bJobId) {\n+ if (aLevel > bLevel) {\n+ return 1;\n+ } else if (aLevel > bLevel) {\n+ return -1;\n+ } else {\n+ return aName > bName ? 1 : -1;\n+ }\n+ } else {\n+ return aJobId - bJobId;\n+ }\n}\n};\n",
"new_path": "src/app/core/layout/layout-order.service.ts",
"old_path": "src/app/core/layout/layout-order.service.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: layout order by job is no longer flickering | 1 | fix | null |
217,922 | 26.05.2018 20:32:43 | -7,200 | 73acaea56dee1dca8813e254f6926d22bf6e7cb7 | fix: removed reset set button in simulator | [
{
"change_type": "MODIFY",
"diff": "<div class=\"config-row\">\n<h3>{{'SIMULATOR.CONFIGURATION.Job' | translate}}</h3>\n<div class=\"save-button\">\n- <button mat-mini-fab *ngIf=\"selectedSet !== undefined && selectedSet.custom\"\n- matTooltip=\"{{'SIMULATOR.CONFIGURATION.Reset_set'}}\"\n- color=\"accent\"\n- (click)=\"resetSet(selectedSet)\">\n- <mat-icon>refresh</mat-icon>\n- </button>\n<button mat-mini-fab *ngIf=\"customSet && selectedSet !== undefined\"\nmatTooltip=\"{{'SIMULATOR.CONFIGURATION.Save_set' | translate}}\"\ncolor=\"accent\"\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.html",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.html"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: removed reset set button in simulator | 1 | fix | null |
217,901 | 26.05.2018 23:06:56 | 18,000 | acef3fa430696f397ccae1f4e8d36b5dcdcb8bde | style: fix list inventory layout | [
{
"change_type": "MODIFY",
"diff": "@@ -32,6 +32,9 @@ export class Inventory {\n}\ngetDisplay(): { id: number, icon: number, amount: number }[][] {\n- return [this.grid.slice(0, 100), this.grid.slice(101, Inventory.INTENTORY_SIZE)]\n+ return [this.grid.slice(0, 35),\n+ this.grid.slice(35, 70),\n+ this.grid.slice(70, 105),\n+ this.grid.slice(105, Inventory.INTENTORY_SIZE)];\n}\n}\n",
"new_path": "src/app/model/other/inventory.ts",
"old_path": "src/app/model/other/inventory.ts"
},
{
"change_type": "MODIFY",
"diff": "<mat-divider></mat-divider>\n<div class=\"container\" fxLayout=\"row\" fxLayout.lt-sm=\"column\">\n- <mat-grid-list rowHeight=\"40px\" cols=\"10\" class=\"inventory-tab\" gutterSize=\"5px\"\n+ <mat-grid-list rowHeight=\"40px\" cols=\"5\" class=\"inventory-tab\" gutterSize=\"5px\"\n*ngFor=\"let tab of inventory | async\">\n<mat-grid-tile *ngFor=\"let slot of tab\"\nmatTooltip=\"{{slot?.id | itemName | i18n}}\"\n",
"new_path": "src/app/pages/list/list-inventory/list-inventory.component.html",
"old_path": "src/app/pages/list/list-inventory/list-inventory.component.html"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | style: fix list inventory layout | 1 | style | null |
791,788 | 27.05.2018 23:51:27 | -10,800 | 424c7b8c33789a9fdb226a8d079510c48d14500b | misc(externs): import crdp from root node_modules | [
{
"change_type": "MODIFY",
"diff": "* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n*/\n-import _Crdp from '../node_modules/vscode-chrome-debug-core/lib/crdp/crdp';\n+import _Crdp from 'vscode-chrome-debug-core/lib/crdp/crdp';\nimport _StrictEventEmitter from '../third-party/strict-event-emitter-types/index';\nimport { EventEmitter } from 'events';\n",
"new_path": "typings/externs.d.ts",
"old_path": "typings/externs.d.ts"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | misc(externs): import crdp from root node_modules (#5366) | 1 | misc | externs |
573,211 | 28.05.2018 00:11:37 | -3,600 | 45375144feb6a215ebfdb967ff0944e3aa21f48d | feat: jsonBodyParser handles extended content types *+json | [
{
"change_type": "MODIFY",
"diff": "@@ -162,6 +162,12 @@ function bodyParser(options) {\nvar parser;\nvar type = req.contentType().toLowerCase();\n+ var jsonPatternMatcher = new RegExp('^application/[a-zA-Z.]+\\\\+json');\n+ // map any +json to application/json\n+ if (jsonPatternMatcher.test(type)) {\n+ type = 'application/json';\n+ }\n+\nswitch (type) {\ncase 'application/json':\nparser = parseJson[0];\n",
"new_path": "lib/plugins/bodyParser.js",
"old_path": "lib/plugins/bodyParser.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -28,9 +28,14 @@ function jsonBodyParser(options) {\n// save original body on req.rawBody and req._body\nreq.rawBody = req._body = req.body;\n- if (req.getContentType() !== 'application/json' || !req.body) {\n+ var jsonPatternMatcher = new RegExp('^application/[a-zA-Z.]+\\\\+json');\n+ var contentType = req.getContentType();\n+\n+ if (contentType !== 'application/json' || !req.body) {\n+ if (!jsonPatternMatcher.test(contentType)) {\nreturn next();\n}\n+ }\nvar params;\n",
"new_path": "lib/plugins/jsonBodyParser.js",
"old_path": "lib/plugins/jsonBodyParser.js"
},
{
"change_type": "MODIFY",
"diff": "\"Falco Nogatz\",\n\"Gergely Nemeth\",\n\"Guillaume Chauvet\",\n+ \"Ifiok Idiang\",\n\"Isaac Schlueter\",\n\"Jacob Quatier\",\n\"James O'Cull\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -489,4 +489,33 @@ describe('JSON body parser', function() {\nclient.write('{\"malformedJsonWithPercentSign\":30%}');\nclient.end();\n});\n+\n+ it('should handle application/*+json as application/json', function(done) {\n+ SERVER.use(restify.plugins.bodyParser({ maxBodySize: 1024 }));\n+\n+ SERVER.post('/', function(req, res, next) {\n+ res.send(200, { length: req.body.length });\n+ next();\n+ });\n+\n+ var opts = {\n+ hostname: '127.0.0.1',\n+ port: PORT,\n+ path: '/',\n+ method: 'POST',\n+ agent: false,\n+ headers: {\n+ accept: 'application/json',\n+ 'content-type': 'application/hal+json',\n+ 'transfer-encoding': 'chunked'\n+ }\n+ };\n+ var client = http.request(opts, function(res) {\n+ assert.equal(res.statusCode, 413);\n+ res.once('end', done);\n+ res.resume();\n+ });\n+ client.write('{\"a\":[' + new Array(512).join('1,') + '0]}');\n+ client.end();\n+ });\n});\n",
"new_path": "test/plugins/jsonBodyParser.test.js",
"old_path": "test/plugins/jsonBodyParser.test.js"
}
] | JavaScript | MIT License | restify/node-restify | feat: jsonBodyParser handles extended content types *+json (#1663) | 1 | feat | null |
217,922 | 28.05.2018 13:44:34 | -7,200 | 07576c9b5628bc99ac62722e050972222ab316da | fix(simulator): fixed a bug that was making simulation action costs hidden | [
{
"change_type": "MODIFY",
"diff": "<div class=\"red-overlay\" *ngIf=\"notEnoughCp || disabled\"></div>\n<mat-icon class=\"failed\" *ngIf=\"failed\">close</mat-icon>\n<span class=\"cost\"\n- *ngIf=\"!hideCost && action.getBaseCPCost(simulation) > 0 && (cpCost === undefined || cpCost > 0)\">\n- {{cpCost === undefined ? action.getBaseCPCost(simulation) : cpCost}}\n+ *ngIf=\"!hideCost && action.getBaseCPCost(simulation) > 0 && (cpCost === undefined || cpCost !== 0)\">\n+ {{(cpCost === undefined ? action.getBaseCPCost(simulation) : cpCost) | absolute}}\n</span>\n</div>\n</div>\n",
"new_path": "src/app/pages/simulator/components/action/action.component.html",
"old_path": "src/app/pages/simulator/components/action/action.component.html"
},
{
"change_type": "ADD",
"diff": "+import {Pipe, PipeTransform} from '@angular/core';\n+\n+@Pipe({\n+ name: 'absolute'\n+})\n+export class AbsolutePipe implements PipeTransform {\n+\n+ transform(value: number): number {\n+ return Math.abs(value);\n+ }\n+\n+}\n",
"new_path": "src/app/pipes/absolute.pipe.ts",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -9,6 +9,7 @@ import {VentureNamePipe} from './venture-name.pipe';\nimport {ActionIconPipe} from './action-icon.pipe';\nimport {JobAbbrIconPipe} from './job-abbr.pipe';\nimport {JobNameIconPipe} from './job-name.pipe';\n+import {AbsolutePipe} from './absolute.pipe';\n@NgModule({\ndeclarations: [\n@@ -22,6 +23,7 @@ import {JobNameIconPipe} from './job-name.pipe';\nActionIconPipe,\nJobAbbrIconPipe,\nJobNameIconPipe,\n+ AbsolutePipe,\n],\nexports: [\nItemNamePipe,\n@@ -34,6 +36,7 @@ import {JobNameIconPipe} from './job-name.pipe';\nActionIconPipe,\nJobAbbrIconPipe,\nJobNameIconPipe,\n+ AbsolutePipe,\n]\n})\nexport class PipesModule {\n",
"new_path": "src/app/pipes/pipes.module.ts",
"old_path": "src/app/pipes/pipes.module.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): fixed a bug that was making simulation action costs hidden | 1 | fix | simulator |
217,922 | 28.05.2018 14:13:47 | -7,200 | 55e3573512ac3d8352714db92f837ba964e9138b | perf: performance improvements for community lists | [
{
"change_type": "MODIFY",
"diff": "@@ -166,16 +166,17 @@ export class ListPanelComponent extends ComponentWithSubscriptions implements On\nngOnInit(): void {\nthis.author = this.userService.getCharacter(this.list.authorId)\n.pipe(\n- catchError(err => {\n+ catchError(() => {\nreturn of(null);\n})\n);\n-\n+ if (!this.list.public) {\nthis.templateService.getByListId(this.list.$key).subscribe(res => {\nif (res !== undefined) {\nthis.templateUrl = res.getUrl();\n}\n});\n+ }\nthis.userService.getUserData().subscribe(u => {\nthis.userUid = u.$key;\n",
"new_path": "src/app/modules/common-components/list-panel/list-panel.component.ts",
"old_path": "src/app/modules/common-components/list-panel/list-panel.component.ts"
},
{
"change_type": "MODIFY",
"diff": "import {Component, ElementRef, OnInit, ViewChild} from '@angular/core';\nimport {ListService} from '../../../core/database/list.service';\nimport {List} from '../../../model/list/list';\n-import {BehaviorSubject, combineLatest, Observable, fromEvent} from 'rxjs';\n+import {BehaviorSubject, combineLatest, fromEvent, Observable} from 'rxjs';\nimport {ListTag} from '../../../model/list/list-tag.enum';\nimport {MatPaginator, PageEvent} from '@angular/material';\n-import {tap} from 'rxjs/operators';\n-import {debounceTime, map, switchMap} from 'rxjs/operators';\n+import {debounceTime, map, switchMap, tap} from 'rxjs/operators';\n@Component({\nselector: 'app-public-lists',\n@@ -39,8 +38,12 @@ export class PublicListsComponent implements OnInit {\npaginatorRef: MatPaginator;\nconstructor(private listService: ListService) {\n- this.lists = combineLatest(this.listService.getPublicLists(), this.tagFilter, this.nameFilter,\n- (lists, tagFilter, nameFilter) => {\n+ this.lists = combineLatest(this.listService.getPublicLists(), this.tagFilter, this.nameFilter)\n+ .pipe(\n+ map(args => {\n+ let lists = args[0];\n+ const tagFilter = args[1];\n+ const nameFilter = args[2];\nif (nameFilter !== '') {\nlists = lists.filter(list => list.name.toLowerCase().indexOf(nameFilter.toLowerCase()) > -1);\n}\n@@ -53,10 +56,10 @@ export class PublicListsComponent implements OnInit {\nreturn match;\n});\n}\n- lists = lists.filter(list => list.recipes.length > 0);\n- return lists;\n- })\n- .pipe(\n+ return lists\n+ .filter(list => list.recipes.length > 0)\n+ .filter(list => list.tags !== undefined && list.tags.length > 0);\n+ }),\ntap(lists => {\nthis.publicListsLength = lists.length;\nthis.paginatorRef.pageIndex = 0;\n",
"new_path": "src/app/pages/public-lists/public-lists/public-lists.component.ts",
"old_path": "src/app/pages/public-lists/public-lists/public-lists.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | perf: performance improvements for community lists | 1 | perf | null |
217,922 | 28.05.2018 15:26:41 | -7,200 | 03d0548d00b3a712fd5b39a5460bd8af18cc3399 | feat(simulator): new "Save as new" button on rotations, creates a clone of the current rotation | [
{
"change_type": "MODIFY",
"diff": "@@ -5,7 +5,7 @@ import {DeserializeAs} from '@kaiu/serializer';\nexport class CraftingRotation extends DataModel {\n- name: string;\n+ public name: string;\npublic recipe: Partial<Craft>;\n",
"new_path": "src/app/model/other/crafting-rotation.ts",
"old_path": "src/app/model/other/crafting-rotation.ts"
},
{
"change_type": "MODIFY",
"diff": "</mat-expansion-panel>\n<app-simulator [recipe]=\"recipe\" [inputGearSet]=\"stats\" [actions]=\"actions\"\n- [customMode]=\"true\" [canSave]=\"canSave\" [rotationId]=\"rotationId\"\n- (onsave)=\"save($event)\" [rotationName]=\"rotationName\" [authorId]=\"authorId\"></app-simulator>\n+ [customMode]=\"true\" [canSave]=\"canSave\"\n+ (onsave)=\"save($event)\" [authorId]=\"authorId\" [rotation]=\"rotation\"></app-simulator>\n</div>\n<ng-template #notFoundTemplate>\n",
"new_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.html",
"old_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -9,6 +9,7 @@ import {CraftingActionsRegistry} from '../../model/crafting-actions-registry';\nimport {CraftingAction} from '../../model/actions/crafting-action';\nimport {GearSet} from '../../model/gear-set';\nimport {filter, first, map, mergeMap} from 'rxjs/operators';\n+import {CraftingRotation} from '../../../../model/other/crafting-rotation';\n@Component({\nselector: 'app-custom-simulator-page',\n@@ -33,14 +34,12 @@ export class CustomSimulatorPageComponent {\npublic canSave = false;\n- public rotationId: string;\n-\npublic notFound = false;\n- public rotationName: string;\n-\npublic authorId;\n+ public rotation: CraftingRotation;\n+\nconstructor(private userService: UserService, private rotationsService: CraftingRotationService,\nprivate router: Router, activeRoute: ActivatedRoute, private registry: CraftingActionsRegistry) {\n@@ -62,8 +61,7 @@ export class CustomSimulatorPageComponent {\nthis.stats = res.rotation.stats;\nthis.authorId = res.rotation.authorId;\nthis.canSave = res.userId === res.rotation.authorId;\n- this.rotationId = res.rotation.$key;\n- this.rotationName = res.rotation.name;\n+ this.rotation = res.rotation;\n}, () => this.notFound = true);\n}\n",
"new_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/custom-simulator-page/custom-simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "<div *ngIf=\"!notFound; else notFoundTemplate\">\n<div *ngIf=\"recipe$ | async as recipe; else loading\">\n<app-simulator [recipe]=\"recipe\" [actions]=\"actions\" [itemId]=\"itemId\" [itemIcon]=\"itemIcon\" [canSave]=\"canSave\"\n- [rotationId]=\"rotationId\" (onsave)=\"save($event)\" [selectedFood]=\"selectedFood\"\n- [selectedMedicine]=\"selectedMedicine\" [rotationName]=\"rotationName\"\n- [authorId]=\"authorId\"></app-simulator>\n+ (onsave)=\"save($event)\" [selectedFood]=\"selectedFood\"\n+ [selectedMedicine]=\"selectedMedicine\"\n+ [authorId]=\"authorId\" [rotation]=\"rotation\"></app-simulator>\n</div>\n</div>\n<ng-template #loading>\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.html",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -33,10 +33,6 @@ export class SimulatorPageComponent {\npublic canSave = false;\n- public rotationId: string;\n-\n- public rotationName: string;\n-\npublic selectedFood: Consumable;\npublic selectedMedicine: Consumable;\n@@ -47,6 +43,8 @@ export class SimulatorPageComponent {\nprivate recipeId: string;\n+ public rotation: CraftingRotation;\n+\nconstructor(private userService: UserService, private rotationsService: CraftingRotationService,\nprivate router: Router, activeRoute: ActivatedRoute, private registry: CraftingActionsRegistry,\nprivate data: DataService) {\n@@ -102,10 +100,9 @@ export class SimulatorPageComponent {\nthis.actions = this.registry.deserializeRotation(res.rotation.rotation);\nthis.canSave = res.userId === res.rotation.authorId;\nthis.authorId = res.rotation.authorId;\n- this.rotationId = res.rotation.$key;\nthis.selectedFood = res.rotation.consumables.food;\nthis.selectedMedicine = res.rotation.consumables.medicine;\n- this.rotationName = res.rotation.name;\n+ this.rotation = res.rotation;\n}, () => this.notFound = true);\n}\n",
"new_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts",
"old_path": "src/app/pages/simulator/components/simulator-page/simulator-page.component.ts"
},
{
"change_type": "MODIFY",
"diff": "<div class=\"top-buttons\" [class.mobile]=\"isMobile()\">\n+ <button mat-mini-fab\n+ matTooltip=\"{{'SIMULATOR.Save_as_new' | translate}}\"\n+ matTooltipPosition=\"{{isMobile()?'below':'right'}}\"\n+ *ngIf=\"(actions$ | async).length > 0 && authorId === userData.$key\" (click)=\"save(true)\">\n+ <mat-icon>content_copy</mat-icon>\n+ </button>\n<button mat-mini-fab\nmatTooltip=\"{{'SIMULATOR.Persist' | translate}}\"\nmatTooltipPosition=\"{{isMobile()?'below':'right'}}\"\n- *ngIf=\"(actions$ | async).length > 0\" (click)=\"save()\">\n+ *ngIf=\"(actions$ | async).length > 0\"\n+ (click)=\"save()\">\n<mat-icon>save</mat-icon>\n</button>\n<button mat-mini-fab\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.html",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -21,7 +21,7 @@ import {medicines} from '../../../../core/data/sources/medicines';\nimport {BonusType} from '../../model/consumable-bonus';\nimport {CraftingRotation} from '../../../../model/other/crafting-rotation';\nimport {CustomCraftingRotation} from '../../../../model/other/custom-crafting-rotation';\n-import {MatDialog} from '@angular/material';\n+import {MatDialog, MatSnackBar} from '@angular/material';\nimport {ImportRotationPopupComponent} from '../import-rotation-popup/import-rotation-popup.component';\nimport {MacroPopupComponent} from '../macro-popup/macro-popup.component';\nimport {PendingChangesService} from 'app/core/database/pending-changes/pending-changes.service';\n@@ -187,12 +187,6 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n}\n}\n- @Input()\n- public rotationId: string;\n-\n- @Input()\n- public rotationName: string;\n-\npublic hqIngredientsData: { id: number, amount: number, max: number, quality: number }[] = [];\npublic foods: Consumable[] = [];\n@@ -239,6 +233,9 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nprivate userData: AppUser;\n+ @Input()\n+ public rotation: CraftingRotation;\n+\nprivate consumablesSortFn = (a, b) => {\nconst aName = this.i18nTools.getName(this.localizedDataService.getItem(a.itemId));\nconst bName = this.i18nTools.getName(this.localizedDataService.getItem(b.itemId));\n@@ -255,7 +252,8 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nconstructor(private registry: CraftingActionsRegistry, private media: ObservableMedia, private userService: UserService,\nprivate dataService: DataService, private htmlTools: HtmlToolsService, private dialog: MatDialog,\nprivate pendingChanges: PendingChangesService, private localizedDataService: LocalizedDataService,\n- private translate: TranslateService, consumablesService: ConsumablesService, private i18nTools: I18nToolsService) {\n+ private translate: TranslateService, consumablesService: ConsumablesService, private i18nTools: I18nToolsService,\n+ private snack: MatSnackBar) {\nthis.foods = consumablesService.fromData(foods)\n.sort(this.consumablesSortFn);\n@@ -432,11 +430,11 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nthis.dirty = true;\n}\n- save(): void {\n+ save(asNew = false): void {\nif (!this.customMode) {\nthis.onsave.emit({\n- $key: this.rotationId,\n- name: this.rotationName,\n+ $key: asNew ? undefined : this.rotation.$key,\n+ name: this.rotation.name,\nrotation: this.serializedRotation,\nrecipe: this.recipeSync,\nauthorId: this.authorId,\n@@ -444,8 +442,8 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n});\n} else {\nthis.onsave.emit(<CustomCraftingRotation>{\n- $key: this.rotationId,\n- name: this.rotationName,\n+ $key: asNew ? undefined : this.rotation.$key,\n+ name: this.rotation.name,\nstats: this.selectedSet,\nrotation: this.serializedRotation,\nrecipe: this.recipeSync,\n@@ -453,6 +451,9 @@ export class SimulatorComponent implements OnInit, OnDestroy {\nconsumables: {food: this._selectedFood, medicine: this._selectedMedicine}\n});\n}\n+ if (asNew) {\n+ this.snack.open(this.translate.instant('SIMULATOR.Save_as_new_done'), null, {duration: 3000});\n+ }\n}\ngetStars(nb: number): string {\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
},
{
"change_type": "MODIFY",
"diff": "\"Cross_class_setup\": \"Cross-class skills setup\",\n\"Include_sound_end\": \"Include end of macro sound\",\n\"Step_by_step_report\": \"Step by step report\",\n+ \"Save_as_new\": \"Save as new (navigates to the newly created rotation)\",\n+ \"Save_as_new_done\": \"You're now on a copy of your rotation\",\n\"CUSTOM\": {\n\"Recipe_configuration\": \"Recipe configuration\",\n\"Recipe_level\": \"Recipe level\",\n",
"new_path": "src/assets/i18n/en.json",
"old_path": "src/assets/i18n/en.json"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | feat(simulator): new "Save as new" button on rotations, creates a clone of the current rotation | 1 | feat | simulator |
217,922 | 28.05.2018 16:37:06 | -7,200 | fdfd2ed331baf9ccd351a5f9e011bbd8bb50022f | fix(mobile): fixed list panel buttons layout, they're now in the panel content
closes | [
{
"change_type": "MODIFY",
"diff": "</div>\n</mat-panel-description>\n</div>\n- <div class=\"buttons\">\n+ <div class=\"buttons\" *ngIf=\"!isMobile()\">\n<app-comments-button *ngIf=\"list.public\" [name]=\"list.name\" [list]=\"list\"\n[isOwnList]=\"list.authorId === authorUid\"\ncolor=\"null\" (click)=\"$event.stopPropagation()\">\n</div>\n</mat-expansion-panel-header>\n<mat-list *ngIf=\"expanded\">\n+ <div class=\"buttons mobile mat-elevation-z2\" mat-list-item *ngIf=\"isMobile()\">\n+ <app-comments-button *ngIf=\"list.public\" [name]=\"list.name\" [list]=\"list\"\n+ [isOwnList]=\"list.authorId === authorUid\"\n+ color=\"null\" (click)=\"$event.stopPropagation()\">\n+ </app-comments-button>\n+ <button mat-icon-button *ngIf=\"buttons && linkButton\"\n+ matTooltip=\"{{'CUSTOM_LINKS.Add_link' | translate}}\" matTooltipPosition=\"above\"\n+ (click)=\"$event.stopPropagation(); openLinkPopup(list)\">\n+ <mat-icon>link</mat-icon>\n+ </button>\n+ <button mat-icon-button\n+ *ngIf=\"!list.ephemeral && buttons && templateButton && templateUrl === undefined\"\n+ matTooltip=\"{{'LIST_TEMPLATE.Create_template' | translate}}\" matTooltipPosition=\"above\"\n+ (click)=\"$event.stopPropagation(); openTemplatePopup(list)\">\n+ <mat-icon>description</mat-icon>\n+ </button>\n+ <button mat-icon-button\n+ *ngIf=\"!list.ephemeral && buttons && templateButton && templateUrl !== undefined\" ngxClipboard\n+ [cbContent]=\"templateUrl\"\n+ (click)=\"$event.stopPropagation()\"\n+ matTooltip=\"{{'LIST_TEMPLATE.Copy_template_url' | translate}}\" matTooltipPosition=\"above\"\n+ (cbOnSuccess)=\"showTemplateCopiedNotification()\">\n+ <mat-icon>content_paste</mat-icon>\n+ </button>\n+ <span *ngIf=\"list.authorId === userUid\"\n+ [matTooltipDisabled]=\"!anonymous\"\n+ [matTooltip]=\"'PERMISSIONS.No_anonymous' | translate\"\n+ matTooltipPosition=\"above\">\n+ <button mat-icon-button\n+ (click)=\"$event.stopPropagation();openPermissions(list)\"\n+ [disabled]=\"anonymous\"\n+ [matTooltip]=\"'PERMISSIONS.Title' | translate\"\n+ matTooltipPosition=\"above\">\n+ <mat-icon>security</mat-icon>\n+ </button>\n+ </span>\n+ <button mat-icon-button *ngIf=\"buttons\" ngxClipboard [cbContent]=\"getLink()\"\n+ (click)=\"$event.stopPropagation()\"\n+ matTooltip=\"{{'Share' | translate}}\" matTooltipPosition=\"above\"\n+ (cbOnSuccess)=\"showCopiedNotification()\">\n+ <mat-icon>share</mat-icon>\n+ </button>\n+ <!--<input type=\"text\" #uri readonly hidden value=\"{{getLink()}}\">-->\n+ <button mat-icon-button *ngIf=\"buttons\" routerLink=\"/list/{{list.$key}}\"\n+ matTooltip=\"{{'LIST.BUTTONS.Open' | translate}}\" matTooltipPosition=\"above\"\n+ (click)=\"$event.stopPropagation()\">\n+ <mat-icon>playlist_play</mat-icon>\n+ </button>\n+ <button mat-icon-button *ngIf=\"!readonly && buttons && list.authorId === userUid\"\n+ matTooltip=\"{{'LIST.BUTTONS.Delete' | translate}}\" matTooltipPosition=\"above\"\n+ (click)=\"ondelete.emit(); $event.stopPropagation()\">\n+ <mat-icon>delete</mat-icon>\n+ </button>\n+ <button mat-icon-button *ngIf=\"copyButton\" (click)=\"$event.stopPropagation();forkList()\"\n+ [matTooltip]=\"'LIST.Copied_x_times' | translate:{'count': list.forks}\"\n+ matTooltipPosition=\"above\">\n+ <mat-icon>content_copy</mat-icon>\n+ </button>\n+ </div>\n<app-recipe *ngFor=\"let recipe of list.recipes\"\n[recipe]=\"recipe\"\n(ondelete)=\"onrecipedelete.emit(recipe)\"\n",
"new_path": "src/app/modules/common-components/list-panel/list-panel.component.html",
"old_path": "src/app/modules/common-components/list-panel/list-panel.component.html"
},
{
"change_type": "MODIFY",
"diff": "}\n}\n}\n+}\n.buttons {\nflex: 0 0 auto;\nmargin-right: 10px;\n- display: inline-flex !important;\n+ display: flex !important;\n+ &.mobile {\n+ justify-content: center;\n+ margin: 5px 0;\n}\n}\n",
"new_path": "src/app/modules/common-components/list-panel/list-panel.component.scss",
"old_path": "src/app/modules/common-components/list-panel/list-panel.component.scss"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(mobile): fixed list panel buttons layout, they're now in the panel content
closes #360 | 1 | fix | mobile |
217,922 | 28.05.2018 16:40:58 | -7,200 | 2febfa2a1193bdf659df4f27a1b99c308a848f19 | fix(simulator): tooltip now hidden upon drag | [
{
"change_type": "MODIFY",
"diff": "@@ -59,6 +59,8 @@ export class XivdbActionTooltipDirective implements OnDestroy {\nthis._subscription = this._tooltipData.getActionTooltipData(this.actionId).subscribe(this._createTooltip);\n}\n+\n+ @HostListener('mousedown')\n@HostListener('mouseleave')\nhide() {\n// Unsubscribe from the XivDB request if needed.\n",
"new_path": "src/app/modules/tooltip/xivdb-tooltip/xivdb-action-tooltip.directive.ts",
"old_path": "src/app/modules/tooltip/xivdb-tooltip/xivdb-action-tooltip.directive.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): tooltip now hidden upon drag | 1 | fix | simulator |
217,922 | 28.05.2018 16:59:58 | -7,200 | 353a92a5fa498913d707af50ddcae31583a0a9af | fix(alarms): fixed a bug with items search and their seeds (old world fig, etc) | [
{
"change_type": "MODIFY",
"diff": "@@ -27,18 +27,20 @@ export class BellNodesService {\n}\ngetNodesByItemId(id: number): any[] {\n- return this.nodes.filter(node => {\n+ const results = [];\n+ this.nodes.forEach(node => {\nconst match = node.items.find(item => item.id === id);\nif (match !== undefined) {\n- node.icon = match.icon;\n- node.itemId = id;\n- node.slot = +match.slot;\n- node.zoneid = this.localizedDataService.getAreaIdByENName(node.zone);\n- node.areaid = this.localizedDataService.getAreaIdByENName(node.title);\n- return true;\n+ const nodeCopy = JSON.parse(JSON.stringify(node));\n+ nodeCopy.icon = match.icon;\n+ nodeCopy.itemId = id;\n+ nodeCopy.slot = +match.slot;\n+ nodeCopy.zoneid = this.localizedDataService.getAreaIdByENName(node.zone);\n+ nodeCopy.areaid = this.localizedDataService.getAreaIdByENName(node.title);\n+ results.push(nodeCopy);\n}\n- return false;\n});\n+ return results;\n}\ngetNode(id: number): any {\n",
"new_path": "src/app/core/data/bell-nodes.service.ts",
"old_path": "src/app/core/data/bell-nodes.service.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(alarms): fixed a bug with items search and their seeds (old world fig, etc) | 1 | fix | alarms |
217,922 | 28.05.2018 19:36:59 | -7,200 | ce3e091c9b06653f82d6e8817ffc46cb9d899eb0 | fix(simulator): fixed a bug with new rotation save | [
{
"change_type": "MODIFY",
"diff": "@@ -431,10 +431,14 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n}\nsave(asNew = false): void {\n+ let key = undefined;\n+ if (!asNew && this.rotation !== undefined) {\n+ key = this.rotation.$key;\n+ }\nif (!this.customMode) {\nthis.onsave.emit({\n- $key: asNew ? undefined : this.rotation.$key,\n- name: this.rotation.name,\n+ $key: key,\n+ name: this.rotation === undefined ? '' : this.rotation.name,\nrotation: this.serializedRotation,\nrecipe: this.recipeSync,\nauthorId: this.authorId,\n@@ -442,8 +446,8 @@ export class SimulatorComponent implements OnInit, OnDestroy {\n});\n} else {\nthis.onsave.emit(<CustomCraftingRotation>{\n- $key: asNew ? undefined : this.rotation.$key,\n- name: this.rotation.name,\n+ $key: key,\n+ name: this.rotation === undefined ? '' : this.rotation.name,\nstats: this.selectedSet,\nrotation: this.serializedRotation,\nrecipe: this.recipeSync,\n",
"new_path": "src/app/pages/simulator/components/simulator/simulator.component.ts",
"old_path": "src/app/pages/simulator/components/simulator/simulator.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix(simulator): fixed a bug with new rotation save | 1 | fix | simulator |
217,902 | 28.05.2018 21:02:30 | -10,800 | a69faf67d2c79d4365c46686ccad8e9f9ed071fd | fix: missing linebreaks in cross-class setup macro | [
{
"change_type": "MODIFY",
"diff": "<mat-divider></mat-divider>\n<div class=\"macro\">\n<pre class=\"macro-fragment\">\n- <span class=\"macro-line\" *ngFor=\"let line of aactionsMacro\">{{line}}</span>\n+ <span class=\"macro-line\" *ngFor=\"let line of aactionsMacro\">{{line}}<br></span>\n</pre>\n</div>\n</div>\n",
"new_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.html",
"old_path": "src/app/pages/simulator/components/macro-popup/macro-popup.component.html"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: missing linebreaks in cross-class setup macro | 1 | fix | null |
217,922 | 29.05.2018 09:12:20 | -7,200 | dbbdc1996250e87989867ed4406eeaf82d21f109 | fix: fixed an issue with gathering search in some languages (pt, es) | [
{
"change_type": "MODIFY",
"diff": "@@ -174,10 +174,14 @@ export class DataService {\n* @returns {Observable<ItemData[]>}\n*/\npublic searchGathering(name: string): Observable<any[]> {\n+ let lang = this.i18n.currentLang;\n+ if (['en', 'fr', 'de', 'ja'].indexOf(lang) === -1) {\n+ lang = 'en';\n+ }\nconst params = new HttpParams()\n.set('gatherable', '1')\n.set('text', name)\n- .set('lang', this.i18n.currentLang);\n+ .set('lang', lang);\nreturn this.getGarlandSearch(params);\n}\n",
"new_path": "src/app/core/api/data.service.ts",
"old_path": "src/app/core/api/data.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -27,6 +27,9 @@ export class LocalizedDataService {\n}\npublic getItemIdsByName(name: string, language: Language): number[] {\n+ if (['en', 'fr', 'de', 'ja'].indexOf(language) === -1) {\n+ language = 'en';\n+ }\nconst regex = new RegExp(`${name}`, 'i');\nconst res = [];\nconst keys = Object.keys(items);\n@@ -113,7 +116,7 @@ export class LocalizedDataService {\n}\n/**\n- * Gets the id of a row by english name.\n+ * Gets the id of a row by name.\n* @param array\n* @param {string} name\n* @param language\n@@ -123,6 +126,9 @@ export class LocalizedDataService {\nif (array === undefined) {\nreturn -1;\n}\n+ if (['en', 'fr', 'de', 'ja'].indexOf(language) === -1) {\n+ language = 'en';\n+ }\nlet res = -1;\nconst keys = Object.keys(array);\nfor (const key of keys) {\n",
"new_path": "src/app/core/data/localized-data.service.ts",
"old_path": "src/app/core/data/localized-data.service.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed an issue with gathering search in some languages (pt, es) | 1 | fix | null |
807,849 | 29.05.2018 09:28:25 | 25,200 | f7b74b2652a5327af50a658acfd716aa4087492c | chore(helpers): Add getCommitMessage() test helper | [
{
"change_type": "ADD",
"diff": "+\"use strict\";\n+\n+const execa = require(\"execa\");\n+\n+module.exports = getCommitMessage;\n+\n+function getCommitMessage(cwd) {\n+ return execa(\"git\", [\"show\", \"--no-patch\", \"--pretty=%B\"], { cwd }).then(result => result.stdout.trim());\n+}\n",
"new_path": "helpers/get-commit-message/index.js",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+{\n+ \"name\": \"@lerna-test/get-commit-message\",\n+ \"version\": \"0.0.0-test-only\",\n+ \"description\": \"A local test helper\",\n+ \"main\": \"index.js\",\n+ \"private\": true,\n+ \"license\": \"MIT\",\n+ \"dependencies\": {\n+ \"execa\": \"^0.10.0\"\n+ }\n+}\n",
"new_path": "helpers/get-commit-message/package.json",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "\"find-up\": \"^2.1.0\"\n}\n},\n+ \"@lerna-test/get-commit-message\": {\n+ \"version\": \"file:helpers/get-commit-message\",\n+ \"dev\": true,\n+ \"requires\": {\n+ \"execa\": \"^0.10.0\"\n+ }\n+ },\n\"@lerna-test/git-add\": {\n\"version\": \"file:helpers/git-add\",\n\"dev\": true,\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
},
{
"change_type": "MODIFY",
"diff": "\"@lerna-test/console-output\": \"file:helpers/console-output\",\n\"@lerna-test/copy-fixture\": \"file:helpers/copy-fixture\",\n\"@lerna-test/find-fixture\": \"file:helpers/find-fixture\",\n+ \"@lerna-test/get-commit-message\": \"file:helpers/get-commit-message\",\n\"@lerna-test/git-add\": \"file:helpers/git-add\",\n\"@lerna-test/git-commit\": \"file:helpers/git-commit\",\n\"@lerna-test/git-init\": \"file:helpers/git-init\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | lerna/lerna | chore(helpers): Add getCommitMessage() test helper | 1 | chore | helpers |
217,922 | 29.05.2018 10:13:36 | -7,200 | 11272b54fb4df1494c3fa8750e4d5df4a6aa0398 | fix: fixed an issue with pricing mode showing wrong values for precrafts | [
{
"change_type": "MODIFY",
"diff": "</mat-card-title>\n<mat-card-subtitle>{{getSpendingTotal().toLocaleString()}} gil</mat-card-subtitle>\n- <mat-expansion-panel [expanded]=\"true\" *ngIf=\"list.crystals.length > 0\">\n+ <mat-expansion-panel *ngIf=\"list.crystals.length > 0\">\n<mat-expansion-panel-header>\n<mat-panel-title>{{\"Crystals\" | translate}}</mat-panel-title>\n<mat-panel-description>{{getTotalPrice(list.crystals)}} gil</mat-panel-description>\n</mat-list>\n</mat-expansion-panel>\n- <mat-expansion-panel [expanded]=\"true\" *ngIf=\"list.gathers.length > 0\">\n+ <mat-expansion-panel *ngIf=\"list.gathers.length > 0\">\n<mat-expansion-panel-header>\n<mat-panel-title>{{\"Gathering\" | translate}}</mat-panel-title>\n<mat-panel-description>{{getTotalPrice(list.gathers).toLocaleString()}} gil</mat-panel-description>\n</mat-list>\n</mat-expansion-panel>\n- <mat-expansion-panel [expanded]=\"true\" *ngIf=\"list.others.length > 0\">\n+ <mat-expansion-panel *ngIf=\"list.others.length > 0\">\n<mat-expansion-panel-header>\n<mat-panel-title>{{\"Other\" | translate}}</mat-panel-title>\n<mat-panel-description>{{getTotalPrice(list.others).toLocaleString()}} gil</mat-panel-description>\n</mat-list>\n</mat-expansion-panel>\n- <mat-expansion-panel [expanded]=\"true\" *ngIf=\"list.preCrafts.length > 0\">\n+ <mat-expansion-panel *ngIf=\"list.preCrafts.length > 0\">\n<mat-expansion-panel-header>\n<mat-panel-title>{{\"Pre_crafts\" | translate}}</mat-panel-title>\n<mat-panel-description>{{getTotalPrice(list.preCrafts).toLocaleString()}} gil</mat-panel-description>\n",
"new_path": "src/app/modules/pricing/pricing/pricing.component.html",
"old_path": "src/app/modules/pricing/pricing/pricing.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -56,8 +56,8 @@ export class PricingComponent {\nif (row.requires !== undefined) {\n// Compute the price of the craft\nconst craftingPrice = this.getCraftCost(row);\n- // If it's cheaper\n- if (craftingPrice < addition) {\n+ // If it's cheaper or it can't be bought\n+ if (craftingPrice < addition || addition === 0) {\n// If the crafting price is cheaper than the item itself,\n// don't add the price because mats are already used in the price.\ntotal += 0;\n",
"new_path": "src/app/modules/pricing/pricing/pricing.component.ts",
"old_path": "src/app/modules/pricing/pricing/pricing.component.ts"
}
] | TypeScript | MIT License | ffxiv-teamcraft/ffxiv-teamcraft | fix: fixed an issue with pricing mode showing wrong values for precrafts | 1 | fix | null |
815,776 | 29.05.2018 10:18:38 | -7,200 | 5eecd83c1d7bdf4f55edf056d16ab6daad601e50 | fix: keep filter status consistent with items updates | [
{
"change_type": "MODIFY",
"diff": "@@ -2039,6 +2039,42 @@ describe('NgSelectComponent', function () {\nexpect(filteredItems[1].label).toBe('Adam');\n}));\n+ it('should continue filtering items on update of items', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectTestCmp,\n+ `<ng-select [items]=\"cities\"\n+ bindLabel=\"name\"\n+ [(ngModel)]=\"selectedCity\">\n+ </ng-select>`);\n+ tickAndDetectChanges(fixture);\n+\n+ fixture.componentInstance.select.filter('vil');\n+ tickAndDetectChanges(fixture);\n+\n+ let result = [jasmine.objectContaining({\n+ value: { id: 1, name: 'Vilnius' }\n+ })];\n+ expect(fixture.componentInstance.select.itemsList.filteredItems).toEqual(result);\n+\n+ fixture.componentInstance.cities = [\n+ { id: 1, name: 'Vilnius' },\n+ { id: 2, name: 'Kaunas' },\n+ { id: 3, name: 'Pabrade' },\n+ { id: 4, name: 'Bruchhausen-Vilsen' },\n+ ];\n+ tickAndDetectChanges(fixture);\n+\n+ result = [\n+ jasmine.objectContaining({\n+ value: { id: 1, name: 'Vilnius' }\n+ }),\n+ jasmine.objectContaining({\n+ value: { id: 4, name: 'Bruchhausen-Vilsen' }\n+ })\n+ ];\n+ expect(fixture.componentInstance.select.itemsList.filteredItems).toEqual(result);\n+ }));\n+\ndescribe('with typeahead', () => {\nlet fixture: ComponentFixture<NgSelectTestCmp>\nbeforeEach(() => {\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -483,7 +483,9 @@ export class NgSelectComponent implements OnDestroy, OnChanges, AfterViewInit, C\nif (items.length > 0 && this.hasValue) {\nthis.itemsList.mapSelectedItems();\n}\n-\n+ if (this.isOpen && isDefined(this.filterValue) && !this._isTypeahead) {\n+ this.itemsList.filter(this.filterValue);\n+ }\nif (this._isTypeahead || this.isOpen) {\nthis.itemsList.markSelectedOrDefault(this.markFirst);\n}\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] | TypeScript | MIT License | ng-select/ng-select | fix: keep filter status consistent with items updates (#585) | 1 | fix | null |
815,746 | 29.05.2018 11:19:50 | -10,800 | ac2798d4faa6e1cb10c8f094d8ed22bf89e857ce | chore(release): 2.1.1 | [
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"2.1.1\"></a>\n+## [2.1.1](https://github.com/ng-select/ng-select/compare/v2.1.0...v2.1.1) (2018-05-29)\n+\n+\n+### Bug Fixes\n+\n+* keep filter status consistent with items updates ([#585](https://github.com/ng-select/ng-select/issues/585)) ([5eecd83](https://github.com/ng-select/ng-select/commit/5eecd83))\n+\n+\n+\n<a name=\"2.1.0\"></a>\n# [2.1.0](https://github.com/ng-select/ng-select/compare/v2.0.3...v2.1.0) (2018-05-24)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"$schema\": \"../node_modules/ng-packagr/package.schema.json\",\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"2.1.0\",\n+ \"version\": \"2.1.1\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] | TypeScript | MIT License | ng-select/ng-select | chore(release): 2.1.1 | 1 | chore | release |
807,849 | 29.05.2018 12:21:44 | 25,200 | 39ce85c3d8c4063664e06a8e085b910ea150af7c | chore: Add helper methods to write-pkg mock | [
{
"change_type": "MODIFY",
"diff": "@@ -10,6 +10,19 @@ const mockWritePkg = jest.fn((fp, data) => {\nreturn writePkg(fp, data);\n});\n+const updatedManifest = name => registry.get(name);\n+\n+// a convenient format for assertions\n+function updatedVersions() {\n+ const result = {};\n+\n+ registry.forEach((pkg, name) => {\n+ result[name] = pkg.version;\n+ });\n+\n+ return result;\n+}\n+\n// keep test data isolated\nafterEach(() => {\nregistry.clear();\n@@ -17,3 +30,5 @@ afterEach(() => {\nmodule.exports = mockWritePkg;\nmodule.exports.registry = registry;\n+module.exports.updatedManifest = updatedManifest;\n+module.exports.updatedVersions = updatedVersions;\n",
"new_path": "commands/__mocks__/write-pkg.js",
"old_path": "commands/__mocks__/write-pkg.js"
}
] | JavaScript | MIT License | lerna/lerna | chore: Add helper methods to write-pkg mock | 1 | chore | null |
807,849 | 29.05.2018 13:33:10 | 25,200 | 094e7bfab473cc737c071bb84ebbedef7ae85f65 | chore(helpers): replace console-output helper with manual mock method | [
{
"change_type": "MODIFY",
"diff": "@@ -6,9 +6,11 @@ jest.unmock(\"@lerna/collect-updates\");\nconst path = require(\"path\");\nconst touch = require(\"touch\");\n+// mocked modules\n+const output = require(\"@lerna/output\");\n+\n// helpers\nconst initFixture = require(\"@lerna-test/init-fixture\")(__dirname);\n-const consoleOutput = require(\"@lerna-test/console-output\");\nconst gitAdd = require(\"@lerna-test/git-add\");\nconst gitCommit = require(\"@lerna-test/git-commit\");\nconst gitTag = require(\"@lerna-test/git-tag\");\n@@ -38,7 +40,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-2/random-file\"]);\nawait lernaChanged(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list all packages when no tag is found\", async () => {\n@@ -46,7 +48,7 @@ describe(\"ChangedCommand\", () => {\nawait lernaChanged(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list changes with --force-publish\", async () => {\n@@ -55,7 +57,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-2/random-file\"]);\nawait lernaChanged(testDir)(\"--force-publish\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list changes with --force-publish package-2,package-4\", async () => {\n@@ -64,7 +66,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-3/random-file\"]);\nawait lernaChanged(testDir)(\"--force-publish\", \"package-2,package-4\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list changes with --force-publish package-2 --force-publish package-4\", async () => {\n@@ -73,7 +75,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-3/random-file\"]);\nawait lernaChanged(testDir)(\"--force-publish\", \"package-2\", \"--force-publish\", \"package-4\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list changes without ignored files\", async () => {\n@@ -90,7 +92,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-2/ignored-file\", \"packages/package-3/random-file\"]);\nawait lernaChanged(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list changes in private packages\", async () => {\n@@ -99,7 +101,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-5/random-file\"]);\nawait lernaChanged(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should return a non-zero exit code when there are no changes\", async () => {\n@@ -126,7 +128,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-3/random-file\"]);\nawait lernaChanged(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list changes with --force-publish *\", async () => {\n@@ -135,7 +137,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-2/random-file\"]);\nawait lernaChanged(testDir)(\"--force-publish\", \"*\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list changes with --force-publish package-2\", async () => {\n@@ -144,7 +146,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-4/random-file\"]);\nawait lernaChanged(testDir)(\"--force-publish\", \"package-2\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should list changes without ignored files\", async () => {\n@@ -161,7 +163,7 @@ describe(\"ChangedCommand\", () => {\nawait setupGitChanges(testDir, [\"packages/package-2/ignored-file\", \"packages/package-3/random-file\"]);\nawait lernaChanged(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"should return a non-zero exit code when there are no changes\", async () => {\n@@ -189,7 +191,7 @@ describe(\"ChangedCommand\", () => {\nawait lernaChanged(testDir)(\"--json\");\n// Output should be a parseable string\n- const jsonOutput = JSON.parse(consoleOutput());\n+ const jsonOutput = JSON.parse(output.logged());\nexpect(jsonOutput).toMatchSnapshot();\n});\n});\n",
"new_path": "commands/changed/__tests__/changed-command.test.js",
"old_path": "commands/changed/__tests__/changed-command.test.js"
},
{
"change_type": "MODIFY",
"diff": "\"use strict\";\n+// mocked modules\n+const output = require(\"@lerna/output\");\n+\n// helpers\nconst initFixture = require(\"@lerna-test/init-fixture\")(__dirname);\n-const consoleOutput = require(\"@lerna-test/console-output\");\n// file under test\nconst lernaLs = require(\"@lerna-test/command-runner\")(require(\"../command\"));\n@@ -12,25 +14,25 @@ describe(\"LsCommand\", () => {\nit(\"should list packages\", async () => {\nconst testDir = await initFixture(\"basic\");\nawait lernaLs(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"lists changes for a given scope\", async () => {\nconst testDir = await initFixture(\"basic\");\nawait lernaLs(testDir)(\"--scope\", \"package-1\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"does not list changes for ignored packages\", async () => {\nconst testDir = await initFixture(\"basic\");\nawait lernaLs(testDir)(\"--ignore\", \"package-@(2|3|4|5)\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"does not list private packages with --no-private\", async () => {\nconst testDir = await initFixture(\"basic\");\nawait lernaLs(testDir)(\"--no-private\");\n- expect(consoleOutput()).not.toMatch(\"package-5 v1.0.0 (private)\");\n+ expect(output.logged()).not.toMatch(\"package-5 v1.0.0 (private)\");\n});\n});\n@@ -38,7 +40,7 @@ describe(\"LsCommand\", () => {\nit(\"should list packages\", async () => {\nconst testDir = await initFixture(\"extra\");\nawait lernaLs(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\n});\n@@ -46,7 +48,7 @@ describe(\"LsCommand\", () => {\nit(\"should list packages, including filtered ones\", async () => {\nconst testDir = await initFixture(\"include-filtered-dependencies\");\nawait lernaLs(testDir)(\"--scope\", \"@test/package-2\", \"--include-filtered-dependencies\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\n});\n@@ -54,7 +56,7 @@ describe(\"LsCommand\", () => {\nit(\"should list packages, including filtered ones\", async () => {\nconst testDir = await initFixture(\"include-filtered-dependencies\");\nawait lernaLs(testDir)(\"--scope\", \"@test/package-1\", \"--include-filtered-dependents\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\n});\n@@ -62,7 +64,7 @@ describe(\"LsCommand\", () => {\nit(\"should list packages\", async () => {\nconst testDir = await initFixture(\"undefined-version\");\nawait lernaLs(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\n});\n@@ -72,7 +74,7 @@ describe(\"LsCommand\", () => {\nawait lernaLs(testDir)(\"--json\");\n// Output should be a parseable string\n- const jsonOutput = JSON.parse(consoleOutput());\n+ const jsonOutput = JSON.parse(output.logged());\nexpect(jsonOutput).toMatchSnapshot();\n});\n});\n@@ -81,7 +83,7 @@ describe(\"LsCommand\", () => {\nit(\"should use package.json/workspaces setting\", async () => {\nconst testDir = await initFixture(\"yarn-workspaces\");\nawait lernaLs(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\n});\n@@ -96,7 +98,7 @@ describe(\"LsCommand\", () => {\nawait lernaLs(testDir)(\"--scope\", \"package-1\", \"--include-filtered-dependencies\");\n// should follow all transitive deps and pass all packages except 7 with no repeats\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\n});\n@@ -104,13 +106,13 @@ describe(\"LsCommand\", () => {\nit(\"lists globstar-nested packages\", async () => {\nconst testDir = await initFixture(\"globstar\");\nawait lernaLs(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"lists packages under explicitly configured node_modules directories\", async () => {\nconst testDir = await initFixture(\"explicit-node-modules\");\nawait lernaLs(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"throws an error when globstars and explicit node_modules configs are mixed\", async () => {\n@@ -135,37 +137,37 @@ describe(\"LsCommand\", () => {\nit(\"includes all packages when --scope is omitted\", async () => {\nawait lernaLs(testDir)();\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"includes packages when --scope is a package name\", async () => {\nawait lernaLs(testDir)(\"--scope\", \"package-3\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"excludes packages when --ignore is a package name\", async () => {\nawait lernaLs(testDir)(\"--ignore\", \"package-3\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"includes packages when --scope is a glob\", async () => {\nawait lernaLs(testDir)(\"--scope\", \"package-a-*\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"excludes packages when --ignore is a glob\", async () => {\nawait lernaLs(testDir)(\"--ignore\", \"package-@(2|3|4)\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"excludes packages when --ignore is a brace-expanded list\", async () => {\nawait lernaLs(testDir)(\"--ignore\", \"package-{3,4}\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"filters packages when both --scope and --ignore are passed\", async () => {\nawait lernaLs(testDir)(\"--scope\", \"package-a-*\", \"--ignore\", \"package-a-2\");\n- expect(consoleOutput()).toMatchSnapshot();\n+ expect(output.logged()).toMatchSnapshot();\n});\nit(\"throws an error when --scope is lacking an argument\", async () => {\n",
"new_path": "commands/list/__tests__/list-command.test.js",
"old_path": "commands/list/__tests__/list-command.test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -11,10 +11,10 @@ const path = require(\"path\");\n// mocked modules\nconst npmRunScript = require(\"@lerna/npm-run-script\");\n+const output = require(\"@lerna/output\");\n// helpers\nconst initFixture = require(\"@lerna-test/init-fixture\")(__dirname);\n-const consoleOutput = require(\"@lerna-test/console-output\");\nconst loggingOutput = require(\"@lerna-test/logging-output\");\nconst gitAdd = require(\"@lerna-test/git-add\");\nconst gitCommit = require(\"@lerna-test/git-commit\");\n@@ -42,9 +42,9 @@ describe(\"RunCommand\", () => {\nawait lernaRun(testDir)(\"my-script\");\n- const output = consoleOutput().split(\"\\n\");\n- expect(output).toContain(\"package-1\");\n- expect(output).toContain(\"package-3\");\n+ const logLines = output.logged().split(\"\\n\");\n+ expect(logLines).toContain(\"package-1\");\n+ expect(logLines).toContain(\"package-3\");\n});\nit(\"runs a script in packages with --stream\", async () => {\n@@ -68,7 +68,7 @@ describe(\"RunCommand\", () => {\nawait lernaRun(testDir)(\"env\");\n- expect(consoleOutput().split(\"\\n\")).toEqual([\"package-1\", \"package-4\", \"package-2\", \"package-3\"]);\n+ expect(output.logged().split(\"\\n\")).toEqual([\"package-1\", \"package-4\", \"package-2\", \"package-3\"]);\n});\nit(\"runs a script only in scoped packages\", async () => {\n@@ -76,7 +76,7 @@ describe(\"RunCommand\", () => {\nawait lernaRun(testDir)(\"my-script\", \"--scope\", \"package-1\");\n- expect(consoleOutput()).toBe(\"package-1\");\n+ expect(output.logged()).toBe(\"package-1\");\n});\nit(\"does not run a script in ignored packages\", async () => {\n@@ -84,7 +84,7 @@ describe(\"RunCommand\", () => {\nawait lernaRun(testDir)(\"my-script\", \"--ignore\", \"package-@(2|3|4)\");\n- expect(consoleOutput()).toBe(\"package-1\");\n+ expect(output.logged()).toBe(\"package-1\");\n});\nit(\"should filter packages that are not updated with --since\", async () => {\n@@ -107,7 +107,7 @@ describe(\"RunCommand\", () => {\nawait lernaRun(testDir)(\"my-script\", \"--since\", \"master\");\n- expect(consoleOutput()).toBe(\"package-3\");\n+ expect(output.logged()).toBe(\"package-3\");\n});\nit(\"requires a git repo when using --since\", async () => {\n@@ -155,7 +155,7 @@ describe(\"RunCommand\", () => {\nawait lernaRun(testDir)(\"env\", \"--npm-client\", \"yarn\");\n- expect(consoleOutput().split(\"\\n\")).toEqual([\"package-1\", \"package-4\", \"package-2\", \"package-3\"]);\n+ expect(output.logged().split(\"\\n\")).toEqual([\"package-1\", \"package-4\", \"package-2\", \"package-3\"]);\n});\nit(\"reports script errors with early exit\", async () => {\n@@ -185,9 +185,9 @@ describe(\"RunCommand\", () => {\n\"--silent\"\n);\n- const output = consoleOutput().split(\"\\n\");\n- expect(output).toContain(\"@test/package-1\");\n- expect(output).toContain(\"@test/package-2\");\n+ const logLines = output.logged().split(\"\\n\");\n+ expect(logLines).toContain(\"@test/package-1\");\n+ expect(logLines).toContain(\"@test/package-2\");\n});\n});\n@@ -205,7 +205,7 @@ describe(\"RunCommand\", () => {\n\"package-cycle-extraneous -> package-cycle-1 -> package-cycle-2 -> package-cycle-1\"\n);\n- expect(consoleOutput().split(\"\\n\")).toEqual([\n+ expect(output.logged().split(\"\\n\")).toEqual([\n\"package-dag-1\",\n\"package-standalone\",\n\"package-dag-2a\",\n",
"new_path": "commands/run/__tests__/run-command.test.js",
"old_path": "commands/run/__tests__/run-command.test.js"
},
{
"change_type": "DELETE",
"diff": "-\"use strict\";\n-\n-jest.mock(\"@lerna/output\");\n-\n-const chalk = require(\"chalk\");\n-const normalizeNewline = require(\"normalize-newline\");\n-const output = require(\"@lerna/output\");\n-\n-// keep snapshots stable cross-platform\n-chalk.enabled = false;\n-\n-module.exports = consoleOutput;\n-\n-function consoleOutput() {\n- return output.mock.calls\n- .map(args =>\n- normalizeNewline(args[0])\n- .split(\"\\n\")\n- .map(line => line.trimRight())\n- .join(\"\\n\")\n- )\n- .join(\"\\n\");\n-}\n",
"new_path": null,
"old_path": "helpers/console-output/index.js"
},
{
"change_type": "DELETE",
"diff": "-{\n- \"name\": \"@lerna-test/console-output\",\n- \"version\": \"0.0.0-test-only\",\n- \"description\": \"A local test helper\",\n- \"main\": \"index.js\",\n- \"private\": true,\n- \"license\": \"MIT\",\n- \"dependencies\": {\n- \"@lerna/output\": \"file:../../utils/output\",\n- \"chalk\": \"^2.3.1\",\n- \"normalize-newline\": \"^3.0.0\"\n- }\n-}\n",
"new_path": null,
"old_path": "helpers/console-output/package.json"
},
{
"change_type": "MODIFY",
"diff": "\"yargs\": \"^11.0.0\"\n}\n},\n- \"@lerna-test/console-output\": {\n- \"version\": \"file:helpers/console-output\",\n- \"dev\": true,\n- \"requires\": {\n- \"@lerna/output\": \"file:utils/output\",\n- \"chalk\": \"^2.3.1\",\n- \"normalize-newline\": \"^3.0.0\"\n- }\n- },\n\"@lerna-test/copy-fixture\": {\n\"version\": \"file:helpers/copy-fixture\",\n\"dev\": true,\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
},
{
"change_type": "MODIFY",
"diff": "\"@lerna-test/cli-runner\": \"file:helpers/cli-runner\",\n\"@lerna-test/clone-fixture\": \"file:helpers/clone-fixture\",\n\"@lerna-test/command-runner\": \"file:helpers/command-runner\",\n- \"@lerna-test/console-output\": \"file:helpers/console-output\",\n\"@lerna-test/copy-fixture\": \"file:helpers/copy-fixture\",\n\"@lerna-test/find-fixture\": \"file:helpers/find-fixture\",\n\"@lerna-test/get-commit-message\": \"file:helpers/get-commit-message\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | lerna/lerna | chore(helpers): replace console-output helper with manual mock method | 1 | chore | helpers |
791,690 | 29.05.2018 14:00:06 | 25,200 | af7127715a1e62a3e6403c288b77462337a14fdf | core(image-aspect-ratio): loosen ratio check | [
{
"change_type": "MODIFY",
"diff": "const Audit = require('./audit');\nconst URL = require('../lib/url-shim');\n-const THRESHOLD = 0.05;\n+const THRESHOLD_PX = 2;\n/** @typedef {Required<LH.Artifacts.SingleImageUsage>} WellDefinedImage */\n@@ -40,7 +40,9 @@ class ImageAspectRatio extends Audit {\nconst url = URL.elideDataURI(image.src);\nconst actualAspectRatio = image.naturalWidth / image.naturalHeight;\nconst displayedAspectRatio = image.width / image.height;\n- const doRatiosMatch = Math.abs(actualAspectRatio - displayedAspectRatio) < THRESHOLD;\n+\n+ const targetDisplayHeight = image.width / actualAspectRatio;\n+ const doRatiosMatch = Math.abs(targetDisplayHeight - image.height) < THRESHOLD_PX;\nif (!Number.isFinite(actualAspectRatio) ||\n!Number.isFinite(displayedAspectRatio)) {\n",
"new_path": "lighthouse-core/audits/image-aspect-ratio.js",
"old_path": "lighthouse-core/audits/image-aspect-ratio.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -107,6 +107,16 @@ describe('Images: aspect-ratio audit', () => {\n},\n});\n+ testImage('is almost the right aspect ratio', {\n+ rawValue: true,\n+ clientSize: [412, 36],\n+ naturalSize: [800, 69],\n+ props: {\n+ isCss: false,\n+ usesObjectFit: false,\n+ },\n+ });\n+\ntestImage('aspect ratios match', {\nrawValue: true,\nclientSize: [100, 100],\n",
"new_path": "lighthouse-core/test/audits/image-aspect-ratio-test.js",
"old_path": "lighthouse-core/test/audits/image-aspect-ratio-test.js"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | core(image-aspect-ratio): loosen ratio check (#5358) | 1 | core | image-aspect-ratio |
791,834 | 29.05.2018 14:05:24 | 25,200 | 92728c9725318cffd14a5918b83be084b88661fd | extension(tsc): add type checking to extension entry points | [
{
"change_type": "MODIFY",
"diff": "@@ -109,33 +109,3 @@ yarn deploy-viewer\n# * Tell the world!!! *\necho \"Complete the _Release publicity_ tasks documented above\"\n```\n-\n-### Extension Canary release\n-\n-```sh\n-# Pull latest in a clean non-dev clone.\n-\n-yarn install-all\n-\n-# Update manifest_canary.json w/ version bumps.\n-\n-# branch and commit\n-git commmit -m \"bump extension canary to 2.0.0.X\"\n-\n-npm version prerelease # this will commit\n-\n-\n-# overwrite extension's manifest w/ manifest_canary.\n-\n-yarn build-all\n-\n-cd lighthouse-extension/\n-gulp package\n-# upload zip to CWS and publish\n-\n-# verify you build-all'd for the typescript compile\n-# ...\n-\n-# publish to canary tag!\n-npm publish --tag canary\n-```\n",
"new_path": "docs/releasing.md",
"old_path": "docs/releasing.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -160,8 +160,13 @@ function runLighthouse(url, flags, config) {\nconst resultsP = chromeP.then(_ => {\nreturn lighthouse(url, flags, config).then(runnerResult => {\nreturn potentiallyKillChrome().then(_ => runnerResult);\n- }).then(runnerResult => {\n- return saveResults(runnerResult, flags).then(_ => runnerResult);\n+ }).then(async runnerResult => {\n+ // If in gatherMode only, there will be no runnerResult.\n+ if (runnerResult) {\n+ await saveResults(runnerResult, flags);\n+ }\n+\n+ return runnerResult;\n});\n});\n",
"new_path": "lighthouse-cli/run.js",
"old_path": "lighthouse-cli/run.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -10,22 +10,11 @@ const Connection = require('./connection.js');\n/* eslint-disable no-unused-vars */\n/**\n- * @interface\n+ * @typedef {object} Port\n+ * @property {(eventName: 'message'|'close', cb: ((arg: string) => void) | (() => void)) => void} on\n+ * @property {(message: string) => void} send\n+ * @property {() => void} close\n*/\n-class Port {\n- /**\n- * @param {'message' | 'close'} eventName\n- * @param {function(string)|function()} cb\n- */\n- on(eventName, cb) { }\n-\n- /**\n- * @param {string} message\n- */\n- send(message) { }\n-\n- close() { }\n-}\n/* eslint-enable no-unused-vars */\n",
"new_path": "lighthouse-core/gather/connections/raw.js",
"old_path": "lighthouse-core/gather/connections/raw.js"
},
{
"change_type": "MODIFY",
"diff": "* Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n*/\n-// @ts-nocheck\n'use strict';\nconst Runner = require('./runner');\n@@ -28,23 +27,25 @@ const Config = require('./config/config');\n/**\n* @param {string} url\n- * @param {LH.Flags} flags\n+ * @param {LH.Flags=} flags\n* @param {LH.Config.Json|undefined} configJSON\n- * @return {Promise<LH.RunnerResult>}\n+ * @return {Promise<LH.RunnerResult|undefined>}\n*/\n-function lighthouse(url, flags = {}, configJSON) {\n- return Promise.resolve().then(_ => {\n+async function lighthouse(url, flags, configJSON) {\n+ // TODO(bckenny): figure out Flags types.\n+ flags = flags || /** @type {LH.Flags} */ ({});\n+\n// set logging preferences, assume quiet\nflags.logLevel = flags.logLevel || 'error';\nlog.setLevel(flags.logLevel);\n// Use ConfigParser to generate a valid config file\n- const config = new Config(configJSON, flags);\n+ // @ts-ignore - TODO(bckenny): type checking for Config\n+ const config = /** @type {LH.Config} */ (new Config(configJSON, flags));\nconst connection = new ChromeProtocol(flags.port, flags.hostname);\n// kick off a lighthouse run\nreturn Runner.run(connection, {url, config});\n- });\n}\nlighthouse.getAuditList = Runner.getAuditList;\n",
"new_path": "lighthouse-core/index.js",
"old_path": "lighthouse-core/index.js"
},
{
"change_type": "MODIFY",
"diff": "\"default_locale\": \"en\",\n\"background\": {\n\"scripts\": [\n- \"scripts/chromereload.js\",\n\"scripts/lighthouse-ext-background.js\"\n],\n\"persistent\": false\n",
"new_path": "lighthouse-extension/app/manifest.json",
"old_path": "lighthouse-extension/app/manifest.json"
},
{
"change_type": "DELETE",
"diff": "-{\n- \"name\": \"__MSG_appName__\",\n- \"version\": \"2.0.0.7\",\n- \"version_name\": \"2.0.0-alpha.7 2017-05-16\",\n- \"minimum_chrome_version\": \"56\",\n- \"manifest_version\": 2,\n- \"description\": \"__MSG_appDescription__\",\n- \"icons\": {\n- \"16\": \"images/lh_logo_canary_bg.png\",\n- \"128\": \"images/lh_logo_canary_bg.png\"\n- },\n- \"default_locale\": \"en\",\n- \"background\": {\n- \"scripts\": [\n- \"scripts/chromereload.js\",\n- \"scripts/lighthouse-ext-background.js\"\n- ],\n- \"persistent\": false\n- },\n- \"permissions\": [\n- \"activeTab\",\n- \"debugger\",\n- \"storage\"\n- ],\n- \"browser_action\": {\n- \"default_icon\": {\n- \"38\": \"images/lh_logo_canary_icon.png\"\n- },\n- \"default_title\": \"Lighthouse\",\n- \"default_popup\": \"popup.html\"\n- },\n- \"content_security_policy\": \"script-src 'self' 'unsafe-eval'; object-src 'none'\"\n-}\n",
"new_path": null,
"old_path": "lighthouse-extension/app/manifest_canary.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -56,12 +56,6 @@ Unless required by applicable law or agreed to in writing, software distributed\n<aside class=\"options subpage\">\n<h2 class=\"options__title\" hidden>Settings</h2>\n- <div hidden>\n- <label>\n- <input type=\"checkbox\" class=\"setting-disable-extensions\" disabled\n- value=\"Disable other extensions while Lighthouse audits a page\">Disable other extensions while Lighthouse audits a page.\n- </label>\n- </div>\n<h2 class=\"options__title\">Audit categories to include</h2>\n<ul class=\"options__list\">\n",
"new_path": "lighthouse-extension/app/popup.html",
"old_path": "lighthouse-extension/app/popup.html"
},
{
"change_type": "DELETE",
"diff": "-/**\n- * @license Copyright 2016 Google Inc. All Rights Reserved.\n- * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n- */\n-'use strict';\n-\n-/* eslint-disable no-console */\n-\n-// Reload client for Chrome Apps & Extensions.\n-// The reload client has a compatibility with livereload.\n-// WARNING: only supports reload command.\n-\n-const LIVERELOAD_HOST = 'localhost:';\n-const LIVERELOAD_PORT = 35729;\n-const connection = new WebSocket('ws://' + LIVERELOAD_HOST + LIVERELOAD_PORT + '/livereload');\n-\n-connection.onerror = error => {\n- console.log('reload connection got error:', error);\n-};\n-\n-connection.onmessage = e => {\n- if (e.data) {\n- const data = JSON.parse(e.data);\n- if (data && data.command === 'reload') {\n- chrome.runtime.reload();\n- }\n- }\n-};\n",
"new_path": null,
"old_path": "lighthouse-extension/app/src/chromereload.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -11,20 +11,24 @@ const Config = require('../../../lighthouse-core/config/config');\nconst defaultConfig = require('../../../lighthouse-core/config/default-config.js');\nconst log = require('lighthouse-logger');\n+/** @typedef {import('../../../lighthouse-core/gather/connections/connection.js')} Connection */\n+\n/**\n- * @param {!Connection} connection\n+ * @param {Connection} connection\n* @param {string} url\n- * @param {!Object} options Lighthouse options.\n- * @param {!Array<string>} categoryIDs Name values of categories to include.\n- * @return {!Promise}\n+ * @param {{flags: LH.Flags}} options Lighthouse options.\n+ * @param {Array<string>} categoryIDs Name values of categories to include.\n+ * @param {(url?: string) => void} updateBadgeFn\n+ * @return {Promise<LH.RunnerResult|void>}\n*/\n-window.runLighthouseForConnection = function(\n+function runLighthouseForConnection(\nconnection, url, options, categoryIDs,\nupdateBadgeFn = function() { }) {\n- const config = new Config({\n+ // @ts-ignore - TODO(bckenny): type checking for Config\n+ const config = /** @type {LH.Config} */ (new Config({\nextends: 'lighthouse:default',\nsettings: {onlyCategories: categoryIDs},\n- }, options.flags);\n+ }, options.flags));\n// Add url and config to fresh options object.\nconst runOptions = Object.assign({}, options, {url, config});\n@@ -39,30 +43,47 @@ window.runLighthouseForConnection = function(\nupdateBadgeFn();\nthrow err;\n});\n-};\n+}\n/**\n- * @param {!RawProtocol.Port} port\n+ * @param {RawProtocol.Port} port\n* @param {string} url\n- * @param {!Object} options Lighthouse options.\n- * @param {!Array<string>} categoryIDs Name values of categories to include.\n- * @return {!Promise}\n+ * @param {{flags: LH.Flags}} options Lighthouse options.\n+ * @param {Array<string>} categoryIDs Name values of categories to include.\n+ * @return {Promise<LH.RunnerResult|void>}\n*/\n-window.runLighthouseInWorker = function(port, url, options, categoryIDs) {\n+function runLighthouseInWorker(port, url, options, categoryIDs) {\n// Default to 'info' logging level.\nlog.setLevel('info');\nconst connection = new RawProtocol(port);\n- return window.runLighthouseForConnection(connection, url, options, categoryIDs);\n-};\n+ return runLighthouseForConnection(connection, url, options, categoryIDs);\n+}\n/**\n* Returns list of top-level categories from the default config.\n- * @return {!Array<{title: string, id: string}>}\n+ * @return {Array<{title: string, id: string}>}\n*/\n-window.getDefaultCategories = function() {\n+function getDefaultCategories() {\nreturn Config.getCategories(defaultConfig);\n-};\n+}\n-window.listenForStatus = function(listenCallback) {\n+/** @param {(status: [string, string, string]) => void} listenCallback */\n+function listenForStatus(listenCallback) {\nlog.events.addListener('status', listenCallback);\n+}\n+\n+if (typeof module !== 'undefined' && module.exports) {\n+ // export for lighthouse-ext-background to require (via browserify).\n+ module.exports = {\n+ runLighthouseForConnection,\n+ runLighthouseInWorker,\n+ getDefaultCategories,\n+ listenForStatus,\n};\n+} else {\n+ // If not require()d, expose on window for devtools, other consumers of file.\n+ // @ts-ignore\n+ window.runLighthouseInWorker = runLighthouseInWorker;\n+ // @ts-ignore\n+ window.listenForStatus = listenForStatus;\n+}\n",
"new_path": "lighthouse-extension/app/src/lighthouse-background.js",
"old_path": "lighthouse-extension/app/src/lighthouse-background.js"
},
{
"change_type": "MODIFY",
"diff": "*/\n'use strict';\n-require('./lighthouse-background');\n+const background = require('./lighthouse-background');\nconst ExtensionProtocol = require('../../../lighthouse-core/gather/connections/extension');\nconst log = require('lighthouse-logger');\nconst assetSaver = require('../../../lighthouse-core/lib/asset-saver.js');\n+/** @typedef {import('../../../lighthouse-core/gather/connections/connection.js')} Connection */\n+\nconst STORAGE_KEY = 'lighthouse_audits';\nconst SETTINGS_KEY = 'lighthouse_settings';\n-// let installedExtensions = [];\n-let disableExtensionsDuringRun = false;\nlet lighthouseIsRunning = false;\n-let latestStatusLog = [];\n-\n-// /**\n-// * Enables or disables all other installed chrome extensions. The initial list\n-// * of the user's extension is created when the background page is started.\n-// * @param {!boolean} enable If true, enables all other installed extensions.\n-// * False disables them.\n-// * @param {!Promise}\n-// */\n-// function enableOtherChromeExtensions(enable) {\n-// if (!disableExtensionsDuringRun) {\n-// return Promise.resolve();\n-// }\n-\n-// const str = enable ? 'enabling' : 'disabling';\n-// log.log('Chrome', `${str} ${installedExtensions.length} extensions.`);\n-\n-// return Promise.all(installedExtensions.map(info => {\n-// return new Promise((resolve, reject) => {\n-// chrome.management.setEnabled(info.id, enable, _ => {\n-// if (chrome.runtime.lastError) {\n-// reject(chrome.runtime.lastError);\n-// }\n-// resolve();\n-// });\n-// });\n-// }));\n-// }\n+/** @type {?[string, string, string]} */\n+let latestStatusLog = null;\n/**\n* Sets the extension badge text.\n@@ -53,11 +27,14 @@ let latestStatusLog = [];\n*/\nfunction updateBadgeUI(optUrl) {\nlighthouseIsRunning = !!optUrl;\n- if (window.chrome && chrome.runtime) {\n+ if ('chrome' in window && chrome.runtime) {\nconst manifest = chrome.runtime.getManifest();\n+ if (!manifest.browser_action || !manifest.browser_action.default_icon) {\n+ return;\n+ }\n- let title = manifest.browser_action.default_title;\n- let path = manifest.browser_action.default_icon['38'];\n+ let title = manifest.browser_action.default_title || '';\n+ let path = manifest.browser_action.default_icon[38];\nif (lighthouseIsRunning) {\ntitle = `Testing ${optUrl}`;\n@@ -70,109 +47,95 @@ function updateBadgeUI(optUrl) {\n}\n/**\n- * @param {!Object} options Lighthouse options.\n- * @param {!Array<string>} categoryIDs Name values of categories to include.\n- * @return {!Promise}\n+ * @param {{flags: LH.Flags}} options Lighthouse options.\n+ * @param {Array<string>} categoryIDs Name values of categories to include.\n+ * @return {Promise<LH.RunnerResult|void>}\n*/\n-window.runLighthouseInExtension = function(options, categoryIDs) {\n+async function runLighthouseInExtension(options, categoryIDs) {\n// Default to 'info' logging level.\nlog.setLevel('info');\nconst connection = new ExtensionProtocol();\noptions.flags = Object.assign({}, options.flags, {output: 'html'});\n- // return enableOtherChromeExtensions(false)\n- // .then(_ => connection.getCurrentTabURL())\n- return connection.getCurrentTabURL()\n- .then(url => window.runLighthouseForConnection(connection, url, options,\n- categoryIDs, updateBadgeUI))\n- .then(runnerResult => {\n- // return enableOtherChromeExtensions(true).then(_ => {\n- const blobURL = window.createReportPageAsBlob(runnerResult, 'extension');\n- return new Promise(resolve => chrome.windows.create({url: blobURL}, resolve));\n- // });\n- }).catch(err => {\n- // return enableOtherChromeExtensions(true).then(_ => {\n- throw err;\n- // });\n- });\n-};\n+ const url = await connection.getCurrentTabURL();\n+ const runnerResult = await background.runLighthouseForConnection(connection, url, options,\n+ categoryIDs, updateBadgeUI);\n+ if (!runnerResult) {\n+ // For now, should always be a runnerResult as the extension can't do `gatherMode`\n+ throw new Error('no runnerResult generated by Lighthouse');\n+ }\n+\n+ const blobURL = createReportPageAsBlob(runnerResult);\n+ await new Promise(resolve => chrome.windows.create({url: blobURL}, resolve));\n+}\n/**\n* Run lighthouse for connection and provide similar results as in CLI.\n- * @param {!Connection} connection\n+ * @param {Connection} connection\n* @param {string} url\n- * @param {!Object} options Lighthouse options.\n+ * @param {{flags: LH.Flags} & {outputFormat: string, logAssets: boolean}} options Lighthouse options.\nSpecify outputFormat to change the output format.\n- * @param {!Array<string>} categoryIDs Name values of categories to include.\n- * @return {!Promise}\n+ * @param {Array<string>} categoryIDs Name values of categories to include.\n+ * @return {Promise<string|Array<string>|void>}\n*/\n-window.runLighthouseAsInCLI = function(connection, url, options, categoryIDs) {\n+async function runLighthouseAsInCLI(connection, url, options, categoryIDs) {\nlog.setLevel('info');\n- const startTime = Date.now();\noptions.flags = Object.assign({}, options.flags, {output: options.outputFormat});\n- return window.runLighthouseForConnection(connection, url, options, categoryIDs)\n- .then(results => {\n- const endTime = Date.now();\n- results.timing = {total: endTime - startTime};\n- let promise = Promise.resolve();\n+ const results = await background.runLighthouseForConnection(connection, url, options,\n+ categoryIDs);\n+ if (results) {\nif (options && options.logAssets) {\n- promise = promise.then(_ => assetSaver.logAssets(results.artifacts, results.lhr.audits));\n+ await assetSaver.logAssets(results.artifacts, results.lhr.audits);\n}\n- return promise.then( _ => {\n+\nreturn results.report;\n- });\n- });\n-};\n+ }\n+}\n/**\n* @param {LH.RunnerResult} runnerResult Lighthouse results object\n- * @param {!string} reportContext Where the report is going\n- * @return {!string} Blob URL of the report (or error page) HTML\n+ * @return {string} Blob URL of the report (or error page) HTML\n*/\n-window.createReportPageAsBlob = function(runnerResult) {\n+function createReportPageAsBlob(runnerResult) {\nperformance.mark('report-start');\nconst html = runnerResult.report;\nconst blob = new Blob([html], {type: 'text/html'});\n- const blobURL = window.URL.createObjectURL(blob);\n+ const blobURL = URL.createObjectURL(blob);\nperformance.mark('report-end');\nperformance.measure('generate report', 'report-start', 'report-end');\nreturn blobURL;\n-};\n+}\n/**\n* Save currently selected set of category categories to local storage.\n- * @param {{selectedCategories: !Array<string>, disableExtensions: boolean, useDevTools: boolean}} settings\n+ * @param {{selectedCategories: Array<string>, useDevTools: boolean}} settings\n*/\n-window.saveSettings = function(settings) {\n+function saveSettings(settings) {\nconst storage = {\n[STORAGE_KEY]: {},\n[SETTINGS_KEY]: {},\n};\n// Stash selected categories.\n- window.getDefaultCategories().forEach(category => {\n+ background.getDefaultCategories().forEach(category => {\nstorage[STORAGE_KEY][category.id] = settings.selectedCategories.includes(category.id);\n});\n- // Stash disable extensions setting.\n- disableExtensionsDuringRun = settings.disableExtensions;\n- storage[SETTINGS_KEY].disableExtensions = disableExtensionsDuringRun;\n-\n// Stash throttling setting.\nstorage[SETTINGS_KEY].useDevTools = settings.useDevTools;\n// Save object to chrome local storage.\nchrome.storage.local.set(storage);\n-};\n+}\n/**\n* Load selected category categories from local storage.\n- * @return {!Promise<{selectedCategories: !Array<string>, disableExtensions: boolean, useDevTools: boolean}>}\n+ * @return {Promise<{selectedCategories: Array<string>, useDevTools: boolean}>}\n*/\n-window.loadSettings = function() {\n+function loadSettings() {\nreturn new Promise(resolve => {\n// Protip: debug what's in storage with:\n// chrome.storage.local.get(['lighthouse_audits'], console.log)\n@@ -180,7 +143,7 @@ window.loadSettings = function() {\n// Start with list of all default categories set to true so list is\n// always up to date.\nconst defaultCategories = {};\n- window.getDefaultCategories().forEach(category => {\n+ background.getDefaultCategories().forEach(category => {\ndefaultCategories[category.id] = true;\n});\n@@ -190,49 +153,37 @@ window.loadSettings = function() {\nconst defaultSettings = {\nuseDevTools: false,\n- disableExtensions: disableExtensionsDuringRun,\n};\nconst savedSettings = Object.assign(defaultSettings, result[SETTINGS_KEY]);\nresolve({\n- useDevTools: savedSettings.useDevTools,\n+ useDevTools: !!savedSettings.useDevTools,\nselectedCategories: Object.keys(savedCategories).filter(cat => savedCategories[cat]),\n- disableExtensions: savedSettings.disableExtensions,\n});\n});\n});\n-};\n+}\n-window.listenForStatus = function(callback) {\n+/** @param {(status: [string, string, string]) => void} listenCallback */\n+function listenForStatus(listenCallback) {\nlog.events.addListener('status', function(log) {\nlatestStatusLog = log;\n- callback(log);\n+ listenCallback(log);\n});\n// Show latest saved status log to give immediate feedback\n// when reopening the popup message when lighthouse is running\nif (lighthouseIsRunning && latestStatusLog) {\n- callback(latestStatusLog);\n+ listenCallback(latestStatusLog);\n+ }\n}\n-};\n-window.isRunning = function() {\n+function isRunning() {\nreturn lighthouseIsRunning;\n-};\n+}\n// Run when in extension context, but not in devtools.\n-if (window.chrome && chrome.runtime) {\n- // Get list of installed extensions that are enabled and can be disabled.\n- // Extensions are not allowed to be disabled if they are under an admin policy.\n- // chrome.management.getAll(installs => {\n- // chrome.management.getSelf(lighthouseCrxInfo => {\n- // installedExtensions = installs.filter(info => {\n- // return info.id !== lighthouseCrxInfo.id && info.type === 'extension' &&\n- // info.enabled && info.mayDisable;\n- // });\n- // });\n- // });\n-\n+if ('chrome' in window && chrome.runtime) {\nchrome.runtime.onInstalled.addListener(details => {\nif (details.previousVersion) {\n// eslint-disable-next-line no-console\n@@ -240,3 +191,30 @@ if (window.chrome && chrome.runtime) {\n}\n});\n}\n+\n+if (typeof module !== 'undefined' && module.exports) {\n+ // Export for popup.js to import types. We don't want tsc to infer an index\n+ // type, so use exports instead of module.exports.\n+ exports.runLighthouseInExtension = runLighthouseInExtension;\n+ exports.getDefaultCategories = background.getDefaultCategories;\n+ exports.isRunning = isRunning;\n+ exports.listenForStatus = listenForStatus;\n+ exports.saveSettings = saveSettings;\n+ exports.loadSettings = loadSettings;\n+}\n+\n+// Expose on window for extension, other consumers of file.\n+// @ts-ignore\n+window.runLighthouseInExtension = runLighthouseInExtension;\n+// @ts-ignore\n+window.runLighthouseAsInCLI = runLighthouseAsInCLI;\n+// @ts-ignore\n+window.getDefaultCategories = background.getDefaultCategories;\n+// @ts-ignore\n+window.isRunning = isRunning;\n+// @ts-ignore\n+window.listenForStatus = listenForStatus;\n+// @ts-ignore\n+window.loadSettings = loadSettings;\n+// @ts-ignore\n+window.saveSettings = saveSettings;\n",
"new_path": "lighthouse-extension/app/src/lighthouse-ext-background.js",
"old_path": "lighthouse-extension/app/src/lighthouse-ext-background.js"
},
{
"change_type": "MODIFY",
"diff": "\"lighthouse-cli/**/*.js\",\n\"lighthouse-core/**/*.js\",\n+ \"lighthouse-extension/app/src/*.js\",\n\"./typings/*.d.ts\",\n],\n\"exclude\": [\n",
"new_path": "tsconfig.json",
"old_path": "tsconfig.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -12,4 +12,5 @@ declare module 'lighthouse-logger' {\nexport function error(title: string, ...args: any[]): void;\nexport function verbose(title: string, ...args: any[]): void;\nexport function reset(): string;\n+ export var events: import('events').EventEmitter;\n}\n",
"new_path": "typings/lighthouse-logger/index.d.ts",
"old_path": "typings/lighthouse-logger/index.d.ts"
}
] | JavaScript | Apache License 2.0 | googlechrome/lighthouse | extension(tsc): add type checking to extension entry points (#5346) | 1 | extension | tsc |
807,849 | 29.05.2018 14:10:26 | 25,200 | fd41b28bf12f7d73e15a623a6c99c7246c0c115c | deps: Jest 23 | [
{
"change_type": "MODIFY",
"diff": "}\n},\n\"babel-jest\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/babel-jest/-/babel-jest-22.4.4.tgz\",\n- \"integrity\": \"sha512-A9NB6/lZhYyypR9ATryOSDcqBaqNdzq4U+CN+/wcMsLcmKkPxQEoTKLajGfd3IkxNyVBT8NewUK2nWyGbSzHEQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/babel-jest/-/babel-jest-23.0.1.tgz\",\n+ \"integrity\": \"sha1-u6079SP7IC2gXtCmVAtIyE7tE6Y=\",\n\"dev\": true,\n\"requires\": {\n- \"babel-plugin-istanbul\": \"^4.1.5\",\n- \"babel-preset-jest\": \"^22.4.4\"\n+ \"babel-plugin-istanbul\": \"^4.1.6\",\n+ \"babel-preset-jest\": \"^23.0.1\"\n}\n},\n\"babel-messages\": {\n}\n},\n\"babel-plugin-jest-hoist\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/babel-plugin-jest-hoist/-/babel-plugin-jest-hoist-22.4.4.tgz\",\n- \"integrity\": \"sha512-DUvGfYaAIlkdnygVIEl0O4Av69NtuQWcrjMOv6DODPuhuGLDnbsARz3AwiiI/EkIMMlxQDUcrZ9yoyJvTNjcVQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/babel-plugin-jest-hoist/-/babel-plugin-jest-hoist-23.0.1.tgz\",\n+ \"integrity\": \"sha1-6qEclkVjrqnCG+zvK994U/fzwUg=\",\n\"dev\": true\n},\n\"babel-plugin-syntax-object-rest-spread\": {\n\"dev\": true\n},\n\"babel-preset-jest\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/babel-preset-jest/-/babel-preset-jest-22.4.4.tgz\",\n- \"integrity\": \"sha512-+dxMtOFwnSYWfum0NaEc0O03oSdwBsjx4tMSChRDPGwu/4wSY6Q6ANW3wkjKpJzzguaovRs/DODcT4hbSN8yiA==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/babel-preset-jest/-/babel-preset-jest-23.0.1.tgz\",\n+ \"integrity\": \"sha1-YxzFRcbPAhlDATvK8i9F2H/mIZg=\",\n\"dev\": true,\n\"requires\": {\n- \"babel-plugin-jest-hoist\": \"^22.4.4\",\n+ \"babel-plugin-jest-hoist\": \"^23.0.1\",\n\"babel-plugin-syntax-object-rest-spread\": \"^6.13.0\"\n}\n},\n\"lodash\": \"^4.17.4\",\n\"mkdirp\": \"^0.5.1\",\n\"source-map-support\": \"^0.4.15\"\n- },\n- \"dependencies\": {\n- \"source-map\": {\n- \"version\": \"0.5.7\",\n- \"resolved\": \"https://registry.npmjs.org/source-map/-/source-map-0.5.7.tgz\",\n- \"integrity\": \"sha1-igOdLRAh0i0eoUyA2OpGi6LvP8w=\",\n- \"dev\": true\n- },\n- \"source-map-support\": {\n- \"version\": \"0.4.18\",\n- \"resolved\": \"https://registry.npmjs.org/source-map-support/-/source-map-support-0.4.18.tgz\",\n- \"integrity\": \"sha512-try0/JqxPLF9nOjvSta7tVondkP5dwgyLDjVoyMDlmjugT2lRZ1OfsrYTkCd2hkDnJTKRbO/Rl3orm8vlsUzbA==\",\n- \"dev\": true,\n- \"requires\": {\n- \"source-map\": \"^0.5.6\"\n- }\n- }\n}\n},\n\"babel-runtime\": {\n\"requires\": {\n\"fast-diff\": \"^1.1.1\",\n\"jest-docblock\": \"^21.0.0\"\n+ },\n+ \"dependencies\": {\n+ \"jest-docblock\": {\n+ \"version\": \"21.2.0\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-docblock/-/jest-docblock-21.2.0.tgz\",\n+ \"integrity\": \"sha512-5IZ7sY9dBAYSV+YjQ0Ovb540Ku7AO9Z5o2Cg789xj167iQuZ2cG+z0f3Uct6WeYLbU6aQiM2pCs7sZ+4dotydw==\",\n+ \"dev\": true\n+ }\n}\n},\n\"eslint-restricted-globals\": {\n}\n},\n\"expect\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/expect/-/expect-22.4.3.tgz\",\n- \"integrity\": \"sha512-XcNXEPehqn8b/jm8FYotdX0YrXn36qp4HWlrVT4ktwQas1l1LPxiVWncYnnL2eyMtKAmVIaG0XAp0QlrqJaxaA==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/expect/-/expect-23.0.1.tgz\",\n+ \"integrity\": \"sha1-mRMfL9kRVZX4zDaXQB5/BzTUX+8=\",\n\"dev\": true,\n\"requires\": {\n\"ansi-styles\": \"^3.2.0\",\n- \"jest-diff\": \"^22.4.3\",\n- \"jest-get-type\": \"^22.4.3\",\n- \"jest-matcher-utils\": \"^22.4.3\",\n- \"jest-message-util\": \"^22.4.3\",\n- \"jest-regex-util\": \"^22.4.3\"\n+ \"jest-diff\": \"^23.0.1\",\n+ \"jest-get-type\": \"^22.1.0\",\n+ \"jest-matcher-utils\": \"^23.0.1\",\n+ \"jest-message-util\": \"^23.0.0\",\n+ \"jest-regex-util\": \"^23.0.0\"\n}\n},\n\"extend\": {\n\"js-yaml\": \"^3.7.0\",\n\"mkdirp\": \"^0.5.1\",\n\"once\": \"^1.4.0\"\n- },\n- \"dependencies\": {\n- \"istanbul-lib-source-maps\": {\n- \"version\": \"1.2.4\",\n- \"resolved\": \"https://registry.npmjs.org/istanbul-lib-source-maps/-/istanbul-lib-source-maps-1.2.4.tgz\",\n- \"integrity\": \"sha512-UzuK0g1wyQijiaYQxj/CdNycFhAd2TLtO2obKQMTZrZ1jzEMRY3rvpASEKkaxbRR6brvdovfA03znPa/pXcejg==\",\n- \"dev\": true,\n- \"requires\": {\n- \"debug\": \"^3.1.0\",\n- \"istanbul-lib-coverage\": \"^1.2.0\",\n- \"mkdirp\": \"^0.5.1\",\n- \"rimraf\": \"^2.6.1\",\n- \"source-map\": \"^0.5.3\"\n- }\n- },\n- \"source-map\": {\n- \"version\": \"0.5.7\",\n- \"resolved\": \"https://registry.npmjs.org/source-map/-/source-map-0.5.7.tgz\",\n- \"integrity\": \"sha1-igOdLRAh0i0eoUyA2OpGi6LvP8w=\",\n- \"dev\": true\n- }\n}\n},\n\"istanbul-lib-coverage\": {\n}\n},\n\"istanbul-lib-source-maps\": {\n- \"version\": \"1.2.3\",\n- \"resolved\": \"https://registry.npmjs.org/istanbul-lib-source-maps/-/istanbul-lib-source-maps-1.2.3.tgz\",\n- \"integrity\": \"sha512-fDa0hwU/5sDXwAklXgAoCJCOsFsBplVQ6WBldz5UwaqOzmDhUK4nfuR7/G//G2lERlblUNJB8P6e8cXq3a7MlA==\",\n+ \"version\": \"1.2.4\",\n+ \"resolved\": \"https://registry.npmjs.org/istanbul-lib-source-maps/-/istanbul-lib-source-maps-1.2.4.tgz\",\n+ \"integrity\": \"sha512-UzuK0g1wyQijiaYQxj/CdNycFhAd2TLtO2obKQMTZrZ1jzEMRY3rvpASEKkaxbRR6brvdovfA03znPa/pXcejg==\",\n\"dev\": true,\n\"requires\": {\n\"debug\": \"^3.1.0\",\n- \"istanbul-lib-coverage\": \"^1.1.2\",\n+ \"istanbul-lib-coverage\": \"^1.2.0\",\n\"mkdirp\": \"^0.5.1\",\n\"rimraf\": \"^2.6.1\",\n\"source-map\": \"^0.5.3\"\n}\n},\n\"jest\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/jest/-/jest-22.4.4.tgz\",\n- \"integrity\": \"sha512-eBhhW8OS/UuX3HxgzNBSVEVhSuRDh39Z1kdYkQVWna+scpgsrD7vSeBI7tmEvsguPDMnfJodW28YBnhv/BzSew==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest/-/jest-23.0.1.tgz\",\n+ \"integrity\": \"sha1-DQgykO5BEs7Pt4Dfb/gTMu03MgE=\",\n\"dev\": true,\n\"requires\": {\n\"import-local\": \"^1.0.0\",\n- \"jest-cli\": \"^22.4.4\"\n+ \"jest-cli\": \"^23.0.1\"\n},\n\"dependencies\": {\n\"ansi-regex\": {\n\"repeat-element\": \"^1.1.2\"\n}\n},\n- \"cliui\": {\n- \"version\": \"4.1.0\",\n- \"resolved\": \"https://registry.npmjs.org/cliui/-/cliui-4.1.0.tgz\",\n- \"integrity\": \"sha512-4FG+RSG9DL7uEwRUZXZn3SS34DiDPfzP0VOiEwtUWlE+AR2EIg+hSyvrIgUUfhdgR/UkAeW2QHgeP+hWrXs7jQ==\",\n- \"dev\": true,\n- \"requires\": {\n- \"string-width\": \"^2.1.1\",\n- \"strip-ansi\": \"^4.0.0\",\n- \"wrap-ansi\": \"^2.0.0\"\n- }\n- },\n\"expand-brackets\": {\n\"version\": \"0.1.5\",\n\"resolved\": \"https://registry.npmjs.org/expand-brackets/-/expand-brackets-0.1.5.tgz\",\n}\n},\n\"jest-cli\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/jest-cli/-/jest-cli-22.4.4.tgz\",\n- \"integrity\": \"sha512-I9dsgkeyjVEEZj9wrGrqlH+8OlNob9Iptyl+6L5+ToOLJmHm4JwOPatin1b2Bzp5R5YRQJ+oiedx7o1H7wJzhA==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-cli/-/jest-cli-23.0.1.tgz\",\n+ \"integrity\": \"sha1-NRpbpRzyjs8gM22XowuXDR9TClY=\",\n\"dev\": true,\n\"requires\": {\n\"ansi-escapes\": \"^3.0.0\",\n\"graceful-fs\": \"^4.1.11\",\n\"import-local\": \"^1.0.0\",\n\"is-ci\": \"^1.0.10\",\n- \"istanbul-api\": \"^1.1.14\",\n- \"istanbul-lib-coverage\": \"^1.1.1\",\n- \"istanbul-lib-instrument\": \"^1.8.0\",\n- \"istanbul-lib-source-maps\": \"^1.2.1\",\n- \"jest-changed-files\": \"^22.2.0\",\n- \"jest-config\": \"^22.4.4\",\n- \"jest-environment-jsdom\": \"^22.4.1\",\n+ \"istanbul-api\": \"^1.3.1\",\n+ \"istanbul-lib-coverage\": \"^1.2.0\",\n+ \"istanbul-lib-instrument\": \"^1.10.1\",\n+ \"istanbul-lib-source-maps\": \"^1.2.4\",\n+ \"jest-changed-files\": \"^23.0.1\",\n+ \"jest-config\": \"^23.0.1\",\n+ \"jest-environment-jsdom\": \"^23.0.1\",\n\"jest-get-type\": \"^22.1.0\",\n- \"jest-haste-map\": \"^22.4.2\",\n- \"jest-message-util\": \"^22.4.0\",\n- \"jest-regex-util\": \"^22.1.0\",\n- \"jest-resolve-dependencies\": \"^22.1.0\",\n- \"jest-runner\": \"^22.4.4\",\n- \"jest-runtime\": \"^22.4.4\",\n- \"jest-snapshot\": \"^22.4.0\",\n- \"jest-util\": \"^22.4.1\",\n- \"jest-validate\": \"^22.4.4\",\n- \"jest-worker\": \"^22.2.2\",\n+ \"jest-haste-map\": \"^23.0.1\",\n+ \"jest-message-util\": \"^23.0.0\",\n+ \"jest-regex-util\": \"^23.0.0\",\n+ \"jest-resolve-dependencies\": \"^23.0.1\",\n+ \"jest-runner\": \"^23.0.1\",\n+ \"jest-runtime\": \"^23.0.1\",\n+ \"jest-snapshot\": \"^23.0.1\",\n+ \"jest-util\": \"^23.0.1\",\n+ \"jest-validate\": \"^23.0.1\",\n+ \"jest-worker\": \"^23.0.1\",\n\"micromatch\": \"^2.3.11\",\n\"node-notifier\": \"^5.2.1\",\n\"realpath-native\": \"^1.0.0\",\n\"string-length\": \"^2.0.0\",\n\"strip-ansi\": \"^4.0.0\",\n\"which\": \"^1.2.12\",\n- \"yargs\": \"^10.0.3\"\n+ \"yargs\": \"^11.0.0\"\n}\n},\n\"micromatch\": {\n\"requires\": {\n\"ansi-regex\": \"^3.0.0\"\n}\n- },\n- \"yargs\": {\n- \"version\": \"10.1.2\",\n- \"resolved\": \"https://registry.npmjs.org/yargs/-/yargs-10.1.2.tgz\",\n- \"integrity\": \"sha512-ivSoxqBGYOqQVruxD35+EyCFDYNEFL/Uo6FcOnz+9xZdZzK0Zzw4r4KhbrME1Oo2gOggwJod2MnsdamSG7H9ig==\",\n- \"dev\": true,\n- \"requires\": {\n- \"cliui\": \"^4.0.0\",\n- \"decamelize\": \"^1.1.1\",\n- \"find-up\": \"^2.1.0\",\n- \"get-caller-file\": \"^1.0.1\",\n- \"os-locale\": \"^2.0.0\",\n- \"require-directory\": \"^2.1.1\",\n- \"require-main-filename\": \"^1.0.1\",\n- \"set-blocking\": \"^2.0.0\",\n- \"string-width\": \"^2.0.0\",\n- \"which-module\": \"^2.0.0\",\n- \"y18n\": \"^3.2.1\",\n- \"yargs-parser\": \"^8.1.0\"\n- }\n- },\n- \"yargs-parser\": {\n- \"version\": \"8.1.0\",\n- \"resolved\": \"https://registry.npmjs.org/yargs-parser/-/yargs-parser-8.1.0.tgz\",\n- \"integrity\": \"sha512-yP+6QqN8BmrgW2ggLtTbdrOyBNSI7zBa4IykmiV5R1wl1JWNxQvWhMfMdmzIYtKU7oP3OOInY/tl2ov3BDjnJQ==\",\n- \"dev\": true,\n- \"requires\": {\n- \"camelcase\": \"^4.1.0\"\n- }\n}\n}\n},\n\"jest-changed-files\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-changed-files/-/jest-changed-files-22.4.3.tgz\",\n- \"integrity\": \"sha512-83Dh0w1aSkUNFhy5d2dvqWxi/y6weDwVVLU6vmK0cV9VpRxPzhTeGimbsbRDSnEoszhF937M4sDLLeS7Cu/Tmw==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-changed-files/-/jest-changed-files-23.0.1.tgz\",\n+ \"integrity\": \"sha1-95Vy0HIIROpd+EwqRI6GLCJU9gw=\",\n\"dev\": true,\n\"requires\": {\n\"throat\": \"^4.0.0\"\n}\n},\n\"jest-config\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/jest-config/-/jest-config-22.4.4.tgz\",\n- \"integrity\": \"sha512-9CKfo1GC4zrXSoMLcNeDvQBfgtqGTB1uP8iDIZ97oB26RCUb886KkKWhVcpyxVDOUxbhN+uzcBCeFe7w+Iem4A==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-config/-/jest-config-23.0.1.tgz\",\n+ \"integrity\": \"sha1-Z5i/8SR8ejkLEycZMwUAFYL8WPo=\",\n\"dev\": true,\n\"requires\": {\n+ \"babel-core\": \"^6.0.0\",\n+ \"babel-jest\": \"^23.0.1\",\n\"chalk\": \"^2.0.1\",\n\"glob\": \"^7.1.1\",\n- \"jest-environment-jsdom\": \"^22.4.1\",\n- \"jest-environment-node\": \"^22.4.1\",\n+ \"jest-environment-jsdom\": \"^23.0.1\",\n+ \"jest-environment-node\": \"^23.0.1\",\n\"jest-get-type\": \"^22.1.0\",\n- \"jest-jasmine2\": \"^22.4.4\",\n- \"jest-regex-util\": \"^22.1.0\",\n- \"jest-resolve\": \"^22.4.2\",\n- \"jest-util\": \"^22.4.1\",\n- \"jest-validate\": \"^22.4.4\",\n- \"pretty-format\": \"^22.4.0\"\n+ \"jest-jasmine2\": \"^23.0.1\",\n+ \"jest-regex-util\": \"^23.0.0\",\n+ \"jest-resolve\": \"^23.0.1\",\n+ \"jest-util\": \"^23.0.1\",\n+ \"jest-validate\": \"^23.0.1\",\n+ \"pretty-format\": \"^23.0.1\"\n}\n},\n\"jest-diff\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-diff/-/jest-diff-22.4.3.tgz\",\n- \"integrity\": \"sha512-/QqGvCDP5oZOF6PebDuLwrB2BMD8ffJv6TAGAdEVuDx1+uEgrHpSFrfrOiMRx2eJ1hgNjlQrOQEHetVwij90KA==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-diff/-/jest-diff-23.0.1.tgz\",\n+ \"integrity\": \"sha1-PUkTfO4SwyCktNK0pvpugtSRoWo=\",\n\"dev\": true,\n\"requires\": {\n\"chalk\": \"^2.0.1\",\n\"diff\": \"^3.2.0\",\n- \"jest-get-type\": \"^22.4.3\",\n- \"pretty-format\": \"^22.4.3\"\n+ \"jest-get-type\": \"^22.1.0\",\n+ \"pretty-format\": \"^23.0.1\"\n}\n},\n\"jest-docblock\": {\n- \"version\": \"21.2.0\",\n- \"resolved\": \"https://registry.npmjs.org/jest-docblock/-/jest-docblock-21.2.0.tgz\",\n- \"integrity\": \"sha512-5IZ7sY9dBAYSV+YjQ0Ovb540Ku7AO9Z5o2Cg789xj167iQuZ2cG+z0f3Uct6WeYLbU6aQiM2pCs7sZ+4dotydw==\",\n- \"dev\": true\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-docblock/-/jest-docblock-23.0.1.tgz\",\n+ \"integrity\": \"sha1-3t3RgzO+XcJBUmCgTvP86SdrVyU=\",\n+ \"dev\": true,\n+ \"requires\": {\n+ \"detect-newline\": \"^2.1.0\"\n+ }\n+ },\n+ \"jest-each\": {\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-each/-/jest-each-23.0.1.tgz\",\n+ \"integrity\": \"sha1-puXb9TCvxr+ddHkt3mnY23D4RwY=\",\n+ \"dev\": true,\n+ \"requires\": {\n+ \"chalk\": \"^2.0.1\",\n+ \"pretty-format\": \"^23.0.1\"\n+ }\n},\n\"jest-environment-jsdom\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-environment-jsdom/-/jest-environment-jsdom-22.4.3.tgz\",\n- \"integrity\": \"sha512-FviwfR+VyT3Datf13+ULjIMO5CSeajlayhhYQwpzgunswoaLIPutdbrnfUHEMyJCwvqQFaVtTmn9+Y8WCt6n1w==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-environment-jsdom/-/jest-environment-jsdom-23.0.1.tgz\",\n+ \"integrity\": \"sha1-2mieuTWNwW5XCKuyCPTrJqQ5V1w=\",\n\"dev\": true,\n\"requires\": {\n- \"jest-mock\": \"^22.4.3\",\n- \"jest-util\": \"^22.4.3\",\n+ \"jest-mock\": \"^23.0.1\",\n+ \"jest-util\": \"^23.0.1\",\n\"jsdom\": \"^11.5.1\"\n}\n},\n\"jest-environment-node\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-environment-node/-/jest-environment-node-22.4.3.tgz\",\n- \"integrity\": \"sha512-reZl8XF6t/lMEuPWwo9OLfttyC26A5AMgDyEQ6DBgZuyfyeNUzYT8BFo6uxCCP/Av/b7eb9fTi3sIHFPBzmlRA==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-environment-node/-/jest-environment-node-23.0.1.tgz\",\n+ \"integrity\": \"sha1-Z2t0DiBfHyvnckGWnngSvoJO55U=\",\n\"dev\": true,\n\"requires\": {\n- \"jest-mock\": \"^22.4.3\",\n- \"jest-util\": \"^22.4.3\"\n+ \"jest-mock\": \"^23.0.1\",\n+ \"jest-util\": \"^23.0.1\"\n}\n},\n\"jest-get-type\": {\n\"dev\": true\n},\n\"jest-haste-map\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-haste-map/-/jest-haste-map-22.4.3.tgz\",\n- \"integrity\": \"sha512-4Q9fjzuPVwnaqGKDpIsCSoTSnG3cteyk2oNVjBX12HHOaF1oxql+uUiqZb5Ndu7g/vTZfdNwwy4WwYogLh29DQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-haste-map/-/jest-haste-map-23.0.1.tgz\",\n+ \"integrity\": \"sha1-zYkFKr/Iy6AfVgu+wJ1PNq7CXU8=\",\n\"dev\": true,\n\"requires\": {\n\"fb-watchman\": \"^2.0.0\",\n\"graceful-fs\": \"^4.1.11\",\n- \"jest-docblock\": \"^22.4.3\",\n- \"jest-serializer\": \"^22.4.3\",\n- \"jest-worker\": \"^22.4.3\",\n+ \"jest-docblock\": \"^23.0.1\",\n+ \"jest-serializer\": \"^23.0.1\",\n+ \"jest-worker\": \"^23.0.1\",\n\"micromatch\": \"^2.3.11\",\n\"sane\": \"^2.0.0\"\n},\n\"is-extglob\": \"^1.0.0\"\n}\n},\n- \"jest-docblock\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-docblock/-/jest-docblock-22.4.3.tgz\",\n- \"integrity\": \"sha512-uPKBEAw7YrEMcXueMKZXn/rbMxBiSv48fSqy3uEnmgOlQhSX+lthBqHb1fKWNVmFqAp9E/RsSdBfiV31LbzaOg==\",\n- \"dev\": true,\n- \"requires\": {\n- \"detect-newline\": \"^2.1.0\"\n- }\n- },\n\"micromatch\": {\n\"version\": \"2.3.11\",\n\"resolved\": \"https://registry.npmjs.org/micromatch/-/micromatch-2.3.11.tgz\",\n}\n},\n\"jest-jasmine2\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/jest-jasmine2/-/jest-jasmine2-22.4.4.tgz\",\n- \"integrity\": \"sha512-nK3vdUl50MuH7vj/8at7EQVjPGWCi3d5+6aCi7Gxy/XMWdOdbH1qtO/LjKbqD8+8dUAEH+BVVh7HkjpCWC1CSw==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-jasmine2/-/jest-jasmine2-23.0.1.tgz\",\n+ \"integrity\": \"sha1-Fth1NW5jYIcrukhCb30x/cGwvOo=\",\n\"dev\": true,\n\"requires\": {\n\"chalk\": \"^2.0.1\",\n\"co\": \"^4.6.0\",\n- \"expect\": \"^22.4.0\",\n- \"graceful-fs\": \"^4.1.11\",\n+ \"expect\": \"^23.0.1\",\n\"is-generator-fn\": \"^1.0.0\",\n- \"jest-diff\": \"^22.4.0\",\n- \"jest-matcher-utils\": \"^22.4.0\",\n- \"jest-message-util\": \"^22.4.0\",\n- \"jest-snapshot\": \"^22.4.0\",\n- \"jest-util\": \"^22.4.1\",\n- \"source-map-support\": \"^0.5.0\"\n+ \"jest-diff\": \"^23.0.1\",\n+ \"jest-each\": \"^23.0.1\",\n+ \"jest-matcher-utils\": \"^23.0.1\",\n+ \"jest-message-util\": \"^23.0.0\",\n+ \"jest-snapshot\": \"^23.0.1\",\n+ \"jest-util\": \"^23.0.1\",\n+ \"pretty-format\": \"^23.0.1\"\n}\n},\n\"jest-leak-detector\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-leak-detector/-/jest-leak-detector-22.4.3.tgz\",\n- \"integrity\": \"sha512-NZpR/Ls7+ndO57LuXROdgCGz2RmUdC541tTImL9bdUtU3WadgFGm0yV+Ok4Fuia/1rLAn5KaJ+i76L6e3zGJYQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-leak-detector/-/jest-leak-detector-23.0.1.tgz\",\n+ \"integrity\": \"sha1-nboHUFrDSVw50+wJrB5WRZnoYaA=\",\n\"dev\": true,\n\"requires\": {\n- \"pretty-format\": \"^22.4.3\"\n+ \"pretty-format\": \"^23.0.1\"\n}\n},\n\"jest-matcher-utils\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-matcher-utils/-/jest-matcher-utils-22.4.3.tgz\",\n- \"integrity\": \"sha512-lsEHVaTnKzdAPR5t4B6OcxXo9Vy4K+kRRbG5gtddY8lBEC+Mlpvm1CJcsMESRjzUhzkz568exMV1hTB76nAKbA==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-matcher-utils/-/jest-matcher-utils-23.0.1.tgz\",\n+ \"integrity\": \"sha1-DGwNrt+YM8Kn82I2Bp7+y0w/bl8=\",\n\"dev\": true,\n\"requires\": {\n\"chalk\": \"^2.0.1\",\n- \"jest-get-type\": \"^22.4.3\",\n- \"pretty-format\": \"^22.4.3\"\n+ \"jest-get-type\": \"^22.1.0\",\n+ \"pretty-format\": \"^23.0.1\"\n}\n},\n\"jest-message-util\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-message-util/-/jest-message-util-22.4.3.tgz\",\n- \"integrity\": \"sha512-iAMeKxhB3Se5xkSjU0NndLLCHtP4n+GtCqV0bISKA5dmOXQfEbdEmYiu2qpnWBDCQdEafNDDU6Q+l6oBMd/+BA==\",\n+ \"version\": \"23.0.0\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-message-util/-/jest-message-util-23.0.0.tgz\",\n+ \"integrity\": \"sha1-Bz89dscB98cYpLmvHrfxOHksR5Y=\",\n\"dev\": true,\n\"requires\": {\n\"@babel/code-frame\": \"^7.0.0-beta.35\",\n}\n},\n\"jest-mock\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-mock/-/jest-mock-22.4.3.tgz\",\n- \"integrity\": \"sha512-+4R6mH5M1G4NK16CKg9N1DtCaFmuxhcIqF4lQK/Q1CIotqMs/XBemfpDPeVZBFow6iyUNu6EBT9ugdNOTT5o5Q==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-mock/-/jest-mock-23.0.1.tgz\",\n+ \"integrity\": \"sha1-FWn0d5aMZo/HKCc6F8N2d3O0Y1c=\",\n\"dev\": true\n},\n\"jest-regex-util\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-regex-util/-/jest-regex-util-22.4.3.tgz\",\n- \"integrity\": \"sha512-LFg1gWr3QinIjb8j833bq7jtQopiwdAs67OGfkPrvy7uNUbVMfTXXcOKXJaeY5GgjobELkKvKENqq1xrUectWg==\",\n+ \"version\": \"23.0.0\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-regex-util/-/jest-regex-util-23.0.0.tgz\",\n+ \"integrity\": \"sha1-3Vwf3gxG9DcTFM8Q96dRoj9Oj3Y=\",\n\"dev\": true\n},\n\"jest-resolve\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-resolve/-/jest-resolve-22.4.3.tgz\",\n- \"integrity\": \"sha512-u3BkD/MQBmwrOJDzDIaxpyqTxYH+XqAXzVJP51gt29H8jpj3QgKof5GGO2uPGKGeA1yTMlpbMs1gIQ6U4vcRhw==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-resolve/-/jest-resolve-23.0.1.tgz\",\n+ \"integrity\": \"sha1-P4QDRisQo0wt8dR6q1V0xJNbzSQ=\",\n\"dev\": true,\n\"requires\": {\n\"browser-resolve\": \"^1.11.2\",\n- \"chalk\": \"^2.0.1\"\n+ \"chalk\": \"^2.0.1\",\n+ \"realpath-native\": \"^1.0.0\"\n}\n},\n\"jest-resolve-dependencies\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-resolve-dependencies/-/jest-resolve-dependencies-22.4.3.tgz\",\n- \"integrity\": \"sha512-06czCMVToSN8F2U4EvgSB1Bv/56gc7MpCftZ9z9fBgUQM7dzHGCMBsyfVA6dZTx8v0FDcnALf7hupeQxaBCvpA==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-resolve-dependencies/-/jest-resolve-dependencies-23.0.1.tgz\",\n+ \"integrity\": \"sha1-0BoQ3a2RUsTOzfXqwriFccS2pk0=\",\n\"dev\": true,\n\"requires\": {\n- \"jest-regex-util\": \"^22.4.3\"\n+ \"jest-regex-util\": \"^23.0.0\",\n+ \"jest-snapshot\": \"^23.0.1\"\n}\n},\n\"jest-runner\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/jest-runner/-/jest-runner-22.4.4.tgz\",\n- \"integrity\": \"sha512-5S/OpB51igQW9xnkM5Tgd/7ZjiAuIoiJAVtvVTBcEBiXBIFzWM3BAMPBM19FX68gRV0KWyFuGKj0EY3M3aceeQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-runner/-/jest-runner-23.0.1.tgz\",\n+ \"integrity\": \"sha1-sXauPs+eGUqkuEp/z3DRuNsjGqc=\",\n\"dev\": true,\n\"requires\": {\n\"exit\": \"^0.1.2\",\n- \"jest-config\": \"^22.4.4\",\n- \"jest-docblock\": \"^22.4.0\",\n- \"jest-haste-map\": \"^22.4.2\",\n- \"jest-jasmine2\": \"^22.4.4\",\n- \"jest-leak-detector\": \"^22.4.0\",\n- \"jest-message-util\": \"^22.4.0\",\n- \"jest-runtime\": \"^22.4.4\",\n- \"jest-util\": \"^22.4.1\",\n- \"jest-worker\": \"^22.2.2\",\n+ \"graceful-fs\": \"^4.1.11\",\n+ \"jest-config\": \"^23.0.1\",\n+ \"jest-docblock\": \"^23.0.1\",\n+ \"jest-haste-map\": \"^23.0.1\",\n+ \"jest-jasmine2\": \"^23.0.1\",\n+ \"jest-leak-detector\": \"^23.0.1\",\n+ \"jest-message-util\": \"^23.0.0\",\n+ \"jest-runtime\": \"^23.0.1\",\n+ \"jest-util\": \"^23.0.1\",\n+ \"jest-worker\": \"^23.0.1\",\n+ \"source-map-support\": \"^0.5.6\",\n\"throat\": \"^4.0.0\"\n},\n\"dependencies\": {\n- \"jest-docblock\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-docblock/-/jest-docblock-22.4.3.tgz\",\n- \"integrity\": \"sha512-uPKBEAw7YrEMcXueMKZXn/rbMxBiSv48fSqy3uEnmgOlQhSX+lthBqHb1fKWNVmFqAp9E/RsSdBfiV31LbzaOg==\",\n+ \"source-map\": {\n+ \"version\": \"0.6.1\",\n+ \"resolved\": \"https://registry.npmjs.org/source-map/-/source-map-0.6.1.tgz\",\n+ \"integrity\": \"sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g==\",\n+ \"dev\": true\n+ },\n+ \"source-map-support\": {\n+ \"version\": \"0.5.6\",\n+ \"resolved\": \"https://registry.npmjs.org/source-map-support/-/source-map-support-0.5.6.tgz\",\n+ \"integrity\": \"sha512-N4KXEz7jcKqPf2b2vZF11lQIz9W5ZMuUcIOGj243lduidkf2fjkVKJS9vNxVWn3u/uxX38AcE8U9nnH9FPcq+g==\",\n\"dev\": true,\n\"requires\": {\n- \"detect-newline\": \"^2.1.0\"\n+ \"buffer-from\": \"^1.0.0\",\n+ \"source-map\": \"^0.6.0\"\n}\n}\n}\n},\n\"jest-runtime\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/jest-runtime/-/jest-runtime-22.4.4.tgz\",\n- \"integrity\": \"sha512-WRTj9m///npte1YjuphCYX7GRY/c2YvJImU9t7qOwFcqHr4YMzmX6evP/3Sehz5DKW2Vi8ONYPCFWe36JVXxfw==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-runtime/-/jest-runtime-23.0.1.tgz\",\n+ \"integrity\": \"sha1-sddl+wP7bUBDgFrycGdqaT9QTVc=\",\n\"dev\": true,\n\"requires\": {\n\"babel-core\": \"^6.0.0\",\n- \"babel-jest\": \"^22.4.4\",\n- \"babel-plugin-istanbul\": \"^4.1.5\",\n+ \"babel-plugin-istanbul\": \"^4.1.6\",\n\"chalk\": \"^2.0.1\",\n\"convert-source-map\": \"^1.4.0\",\n\"exit\": \"^0.1.2\",\n+ \"fast-json-stable-stringify\": \"^2.0.0\",\n\"graceful-fs\": \"^4.1.11\",\n- \"jest-config\": \"^22.4.4\",\n- \"jest-haste-map\": \"^22.4.2\",\n- \"jest-regex-util\": \"^22.1.0\",\n- \"jest-resolve\": \"^22.4.2\",\n- \"jest-util\": \"^22.4.1\",\n- \"jest-validate\": \"^22.4.4\",\n- \"json-stable-stringify\": \"^1.0.1\",\n+ \"jest-config\": \"^23.0.1\",\n+ \"jest-haste-map\": \"^23.0.1\",\n+ \"jest-message-util\": \"^23.0.0\",\n+ \"jest-regex-util\": \"^23.0.0\",\n+ \"jest-resolve\": \"^23.0.1\",\n+ \"jest-snapshot\": \"^23.0.1\",\n+ \"jest-util\": \"^23.0.1\",\n+ \"jest-validate\": \"^23.0.1\",\n\"micromatch\": \"^2.3.11\",\n\"realpath-native\": \"^1.0.0\",\n\"slash\": \"^1.0.0\",\n\"strip-bom\": \"3.0.0\",\n\"write-file-atomic\": \"^2.1.0\",\n- \"yargs\": \"^10.0.3\"\n+ \"yargs\": \"^11.0.0\"\n},\n\"dependencies\": {\n- \"ansi-regex\": {\n- \"version\": \"3.0.0\",\n- \"resolved\": \"https://registry.npmjs.org/ansi-regex/-/ansi-regex-3.0.0.tgz\",\n- \"integrity\": \"sha1-7QMXwyIGT3lGbAKWa922Bas32Zg=\",\n- \"dev\": true\n- },\n\"arr-diff\": {\n\"version\": \"2.0.0\",\n\"resolved\": \"https://registry.npmjs.org/arr-diff/-/arr-diff-2.0.0.tgz\",\n\"repeat-element\": \"^1.1.2\"\n}\n},\n- \"cliui\": {\n- \"version\": \"4.1.0\",\n- \"resolved\": \"https://registry.npmjs.org/cliui/-/cliui-4.1.0.tgz\",\n- \"integrity\": \"sha512-4FG+RSG9DL7uEwRUZXZn3SS34DiDPfzP0VOiEwtUWlE+AR2EIg+hSyvrIgUUfhdgR/UkAeW2QHgeP+hWrXs7jQ==\",\n- \"dev\": true,\n- \"requires\": {\n- \"string-width\": \"^2.1.1\",\n- \"strip-ansi\": \"^4.0.0\",\n- \"wrap-ansi\": \"^2.0.0\"\n- }\n- },\n\"expand-brackets\": {\n\"version\": \"0.1.5\",\n\"resolved\": \"https://registry.npmjs.org/expand-brackets/-/expand-brackets-0.1.5.tgz\",\n\"regex-cache\": \"^0.4.2\"\n}\n},\n- \"strip-ansi\": {\n- \"version\": \"4.0.0\",\n- \"resolved\": \"https://registry.npmjs.org/strip-ansi/-/strip-ansi-4.0.0.tgz\",\n- \"integrity\": \"sha1-qEeQIusaw2iocTibY1JixQXuNo8=\",\n- \"dev\": true,\n- \"requires\": {\n- \"ansi-regex\": \"^3.0.0\"\n- }\n- },\n\"strip-bom\": {\n\"version\": \"3.0.0\",\n\"resolved\": \"https://registry.npmjs.org/strip-bom/-/strip-bom-3.0.0.tgz\",\n\"integrity\": \"sha1-IzTBjpx1n3vdVv3vfprj1YjmjtM=\",\n\"dev\": true\n- },\n- \"yargs\": {\n- \"version\": \"10.1.2\",\n- \"resolved\": \"https://registry.npmjs.org/yargs/-/yargs-10.1.2.tgz\",\n- \"integrity\": \"sha512-ivSoxqBGYOqQVruxD35+EyCFDYNEFL/Uo6FcOnz+9xZdZzK0Zzw4r4KhbrME1Oo2gOggwJod2MnsdamSG7H9ig==\",\n- \"dev\": true,\n- \"requires\": {\n- \"cliui\": \"^4.0.0\",\n- \"decamelize\": \"^1.1.1\",\n- \"find-up\": \"^2.1.0\",\n- \"get-caller-file\": \"^1.0.1\",\n- \"os-locale\": \"^2.0.0\",\n- \"require-directory\": \"^2.1.1\",\n- \"require-main-filename\": \"^1.0.1\",\n- \"set-blocking\": \"^2.0.0\",\n- \"string-width\": \"^2.0.0\",\n- \"which-module\": \"^2.0.0\",\n- \"y18n\": \"^3.2.1\",\n- \"yargs-parser\": \"^8.1.0\"\n- }\n- },\n- \"yargs-parser\": {\n- \"version\": \"8.1.0\",\n- \"resolved\": \"https://registry.npmjs.org/yargs-parser/-/yargs-parser-8.1.0.tgz\",\n- \"integrity\": \"sha512-yP+6QqN8BmrgW2ggLtTbdrOyBNSI7zBa4IykmiV5R1wl1JWNxQvWhMfMdmzIYtKU7oP3OOInY/tl2ov3BDjnJQ==\",\n- \"dev\": true,\n- \"requires\": {\n- \"camelcase\": \"^4.1.0\"\n- }\n}\n}\n},\n\"jest-serializer\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-serializer/-/jest-serializer-22.4.3.tgz\",\n- \"integrity\": \"sha512-uPaUAppx4VUfJ0QDerpNdF43F68eqKWCzzhUlKNDsUPhjOon7ZehR4C809GCqh765FoMRtTVUVnGvIoskkYHiw==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-serializer/-/jest-serializer-23.0.1.tgz\",\n+ \"integrity\": \"sha1-o3dq6zEekP6D+rnlM+hRAr0WQWU=\",\n\"dev\": true\n},\n\"jest-snapshot\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-snapshot/-/jest-snapshot-22.4.3.tgz\",\n- \"integrity\": \"sha512-JXA0gVs5YL0HtLDCGa9YxcmmV2LZbwJ+0MfyXBBc5qpgkEYITQFJP7XNhcHFbUvRiniRpRbGVfJrOoYhhGE0RQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-snapshot/-/jest-snapshot-23.0.1.tgz\",\n+ \"integrity\": \"sha1-ZnT6Gbnraamcq+zUFb3cQtavPn4=\",\n\"dev\": true,\n\"requires\": {\n\"chalk\": \"^2.0.1\",\n- \"jest-diff\": \"^22.4.3\",\n- \"jest-matcher-utils\": \"^22.4.3\",\n+ \"jest-diff\": \"^23.0.1\",\n+ \"jest-matcher-utils\": \"^23.0.1\",\n\"mkdirp\": \"^0.5.1\",\n\"natural-compare\": \"^1.4.0\",\n- \"pretty-format\": \"^22.4.3\"\n+ \"pretty-format\": \"^23.0.1\"\n}\n},\n\"jest-util\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-util/-/jest-util-22.4.3.tgz\",\n- \"integrity\": \"sha512-rfDfG8wyC5pDPNdcnAlZgwKnzHvZDu8Td2NJI/jAGKEGxJPYiE4F0ss/gSAkG4778Y23Hvbz+0GMrDJTeo7RjQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-util/-/jest-util-23.0.1.tgz\",\n+ \"integrity\": \"sha1-aOpb1+2xd9MFn5eXJZ+ODazOL5k=\",\n\"dev\": true,\n\"requires\": {\n\"callsites\": \"^2.0.0\",\n\"chalk\": \"^2.0.1\",\n\"graceful-fs\": \"^4.1.11\",\n\"is-ci\": \"^1.0.10\",\n- \"jest-message-util\": \"^22.4.3\",\n+ \"jest-message-util\": \"^23.0.0\",\n\"mkdirp\": \"^0.5.1\",\n\"source-map\": \"^0.6.0\"\n},\n}\n},\n\"jest-validate\": {\n- \"version\": \"22.4.4\",\n- \"resolved\": \"https://registry.npmjs.org/jest-validate/-/jest-validate-22.4.4.tgz\",\n- \"integrity\": \"sha512-dmlf4CIZRGvkaVg3fa0uetepcua44DHtktHm6rcoNVtYlpwe6fEJRkMFsaUVcFHLzbuBJ2cPw9Gl9TKfnzMVwg==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-validate/-/jest-validate-23.0.1.tgz\",\n+ \"integrity\": \"sha1-zZ8BqJ0mu4hfEqhmdxXpyGWldU8=\",\n\"dev\": true,\n\"requires\": {\n\"chalk\": \"^2.0.1\",\n- \"jest-config\": \"^22.4.4\",\n\"jest-get-type\": \"^22.1.0\",\n\"leven\": \"^2.1.0\",\n- \"pretty-format\": \"^22.4.0\"\n+ \"pretty-format\": \"^23.0.1\"\n}\n},\n\"jest-worker\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/jest-worker/-/jest-worker-22.4.3.tgz\",\n- \"integrity\": \"sha512-B1ucW4fI8qVAuZmicFxI1R3kr2fNeYJyvIQ1rKcuLYnenFV5K5aMbxFj6J0i00Ju83S8jP2d7Dz14+AvbIHRYQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/jest-worker/-/jest-worker-23.0.1.tgz\",\n+ \"integrity\": \"sha1-nmSd2WP/QEYCb5HEAX8Dmmqkp7w=\",\n\"dev\": true,\n\"requires\": {\n\"merge-stream\": \"^1.0.1\"\n\"resolved\": \"https://registry.npmjs.org/json-schema-traverse/-/json-schema-traverse-0.3.1.tgz\",\n\"integrity\": \"sha1-NJptRMU6Ud6JtAgFxdXlm0F9M0A=\"\n},\n- \"json-stable-stringify\": {\n- \"version\": \"1.0.1\",\n- \"resolved\": \"https://registry.npmjs.org/json-stable-stringify/-/json-stable-stringify-1.0.1.tgz\",\n- \"integrity\": \"sha1-mnWdOcXy/1A/1TAGRu1EX4jE+a8=\",\n- \"dev\": true,\n- \"requires\": {\n- \"jsonify\": \"~0.0.0\"\n- }\n- },\n\"json-stable-stringify-without-jsonify\": {\n\"version\": \"1.0.1\",\n\"resolved\": \"https://registry.npmjs.org/json-stable-stringify-without-jsonify/-/json-stable-stringify-without-jsonify-1.0.1.tgz\",\n\"graceful-fs\": \"^4.1.6\"\n}\n},\n- \"jsonify\": {\n- \"version\": \"0.0.0\",\n- \"resolved\": \"https://registry.npmjs.org/jsonify/-/jsonify-0.0.0.tgz\",\n- \"integrity\": \"sha1-LHS27kHZPKUbe1qu6PUDYx0lKnM=\",\n- \"dev\": true\n- },\n\"jsonparse\": {\n\"version\": \"1.3.1\",\n\"resolved\": \"https://registry.npmjs.org/jsonparse/-/jsonparse-1.3.1.tgz\",\n\"dev\": true\n},\n\"pretty-format\": {\n- \"version\": \"22.4.3\",\n- \"resolved\": \"https://registry.npmjs.org/pretty-format/-/pretty-format-22.4.3.tgz\",\n- \"integrity\": \"sha512-S4oT9/sT6MN7/3COoOy+ZJeA92VmOnveLHgrwBE3Z1W5N9S2A1QGNYiE1z75DAENbJrXXUb+OWXhpJcg05QKQQ==\",\n+ \"version\": \"23.0.1\",\n+ \"resolved\": \"https://registry.npmjs.org/pretty-format/-/pretty-format-23.0.1.tgz\",\n+ \"integrity\": \"sha1-1h0GUmjkx1kIO8y8onoBrXx2AfQ=\",\n\"dev\": true,\n\"requires\": {\n\"ansi-regex\": \"^3.0.0\",\n}\n},\n\"source-map-support\": {\n- \"version\": \"0.5.6\",\n- \"resolved\": \"https://registry.npmjs.org/source-map-support/-/source-map-support-0.5.6.tgz\",\n- \"integrity\": \"sha512-N4KXEz7jcKqPf2b2vZF11lQIz9W5ZMuUcIOGj243lduidkf2fjkVKJS9vNxVWn3u/uxX38AcE8U9nnH9FPcq+g==\",\n+ \"version\": \"0.4.18\",\n+ \"resolved\": \"https://registry.npmjs.org/source-map-support/-/source-map-support-0.4.18.tgz\",\n+ \"integrity\": \"sha512-try0/JqxPLF9nOjvSta7tVondkP5dwgyLDjVoyMDlmjugT2lRZ1OfsrYTkCd2hkDnJTKRbO/Rl3orm8vlsUzbA==\",\n\"dev\": true,\n\"requires\": {\n- \"buffer-from\": \"^1.0.0\",\n- \"source-map\": \"^0.6.0\"\n+ \"source-map\": \"^0.5.6\"\n},\n\"dependencies\": {\n\"source-map\": {\n- \"version\": \"0.6.1\",\n- \"resolved\": \"https://registry.npmjs.org/source-map/-/source-map-0.6.1.tgz\",\n- \"integrity\": \"sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g==\",\n+ \"version\": \"0.5.7\",\n+ \"resolved\": \"https://registry.npmjs.org/source-map/-/source-map-0.5.7.tgz\",\n+ \"integrity\": \"sha1-igOdLRAh0i0eoUyA2OpGi6LvP8w=\",\n\"dev\": true\n}\n}\n",
"new_path": "package-lock.json",
"old_path": "package-lock.json"
},
{
"change_type": "MODIFY",
"diff": "\"eslint-plugin-node\": \"^6.0.1\",\n\"eslint-plugin-prettier\": \"^2.6.0\",\n\"fast-async\": \"^6.3.7\",\n- \"jest\": \"^22.4.4\",\n+ \"jest\": \"^23.0.1\",\n\"normalize-newline\": \"^3.0.0\",\n\"normalize-path\": \"^2.1.1\",\n\"path-key\": \"^2.0.1\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] | JavaScript | MIT License | lerna/lerna | deps: Jest 23 | 1 | deps | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.