author
int64 4.98k
943k
| date
stringdate 2017-04-15 16:45:02
2022-02-25 15:32:15
| timezone
int64 -46,800
39.6k
| hash
stringlengths 40
40
| message
stringlengths 8
468
| mods
listlengths 1
16
| language
stringclasses 9
values | license
stringclasses 2
values | repo
stringclasses 119
values | original_message
stringlengths 12
491
| is_CCS
int64 1
1
| commit_type
stringclasses 129
values | commit_scope
stringlengths 1
44
⌀ |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
815,746
|
05.12.2017 08:46:29
| -7,200
|
8609fe520c3da6c0dc272d7f31a561d968a41620
|
fix: add clear all text Input
closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -16,6 +16,9 @@ addons:\npackages:\n- google-chrome-stable\nbefore_install:\n+- echo \"$TRAVIS_BRANCH\"\n+- echo \"$TRAVIS_PULL_REQUEST\"\n+- if [ \"$TRAVIS_BRANCH\" == \"master\" ] && [ \"$TRAVIS_PULL_REQUEST\" == false ]; then openssl aes-256-cbc -K $encrypted_100b62b33cf9_key -iv $encrypted_100b62b33cf9_iv -in travis_rsa.enc -out travis_rsa -d; fi\n- export DISPLAY=:99.0\n- sh -e /etc/init.d/xvfb start\n- export CHROME_BIN=chromium-browser\n@@ -25,6 +28,7 @@ script:\n- npm run-script coveralls\n- yarn run integration\n- yarn run build:demo\n+- if [ \"$TRAVIS_BRANCH\" == \"master\" ] && [ \"$TRAVIS_PULL_REQUEST\" == false ]; then node_modules/.bin/gh-pages-travis; fi\nenv:\nglobal:\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
},
{
"change_type": "MODIFY",
"diff": "@@ -104,6 +104,7 @@ map: {\n| placeholder | string | `-` | no | Placeholder text. |\n| notFoundText | string | `No items found` | no | Set custom text when filter returns empty result |\n| typeToSearchText | string | `Type to search` | no | Set custom text when using Typeahead |\n+| clearAllText | string | `Clear all` | no | Set custom text for clear all icon title |\n| addTagText | string | `Add item` | no | Set custom text when using tagging |\n| [typeahead] | Subject | `-` | no | Custom autocomplete or filter. |\n| [disableVirtualScroll] | boolean | false | no | Disable virtual scroll |\n",
"new_path": "README.md",
"old_path": "README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -63,6 +63,7 @@ import { DataService } from '../shared/data.service';\nbindValue=\"id\"\n[multiple]=\"true\"\nplaceholder=\"Select cities\"\n+ clearAllText=\"Clear\"\nformControlName=\"selectedCitiesIds\">\n</ng-select>\n---\n",
"new_path": "demo/app/examples/reactive-forms.component.ts",
"old_path": "demo/app/examples/reactive-forms.component.ts"
},
{
"change_type": "MODIFY",
"diff": "\"reflect-metadata\": \"^0.1.10\",\n\"remap-istanbul\": \"^0.6.4\",\n\"rimraf\": \"^2.6.1\",\n- \"rxjs\": \"^5.4.3\",\n+ \"rxjs\": \"^5.5.3\",\n\"sass-loader\": \"^6.0.1\",\n\"standard-version\": \"^4.2.0\",\n\"style-loader\": \"^0.13.0\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -71,6 +71,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\n@Input() typeToSearchText;\n@Input() addTagText;\n@Input() loadingText;\n+ @Input() clearAllText;\n@Input() dropdownPosition: 'below' | 'above' = 'below';\n@Input()\n@@ -621,6 +622,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nthis.typeToSearchText = this.typeToSearchText || config.typeToSearchText;\nthis.addTagText = this.addTagText || config.addTagText;\nthis.loadingText = this.loadingText || config.loadingText;\n+ this.clearAllText = this.clearAllText || config.clearAllText;\nthis.disableVirtualScroll = this.disableVirtualScroll || config.disableVirtualScroll;\n}\n}\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -23,5 +23,6 @@ export class NgSelectConfig {\ntypeToSearchText? = 'Type to search';\naddTagText? = 'Add item';\nloadingText? = 'Loading...';\n+ clearAllText = 'Clear all';\ndisableVirtualScroll? = false;\n}\n",
"new_path": "src/ng-select/ng-select.types.ts",
"old_path": "src/ng-select/ng-select.types.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -5639,9 +5639,9 @@ rollup@^0.50.0:\nversion \"0.50.0\"\nresolved \"https://registry.yarnpkg.com/rollup/-/rollup-0.50.0.tgz#4c158f4e780e6cb33ff0dbfc184a52cc58cd5f3b\"\n-rxjs@^5.4.3:\n- version \"5.4.3\"\n- resolved \"https://registry.yarnpkg.com/rxjs/-/rxjs-5.4.3.tgz#0758cddee6033d68e0fd53676f0f3596ce3d483f\"\n+rxjs@^5.5.3:\n+ version \"5.5.3\"\n+ resolved \"https://registry.yarnpkg.com/rxjs/-/rxjs-5.5.3.tgz#b62227e74b84f4e77bdf440e50b5ee01a1bc7dcd\"\ndependencies:\nsymbol-observable \"^1.0.1\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: add clear all text Input (#155)
closes https://github.com/ng-select/ng-select/issues/153
| 1
|
fix
| null |
791,723
|
05.12.2017 11:19:14
| 28,800
|
b72dffefab4e691c528713a08088102b15dc2379
|
misc(codeowners): represent brendan's leave
|
[
{
"change_type": "MODIFY",
"diff": "# https://help.github.com/articles/about-codeowners/\nlighthouse-cli/ @patrickhulce @paulirish\n-lighthouse-cli/test/fixtures/ @patrickhulce @brendankenny\n-lighthouse-cli/test/smokehouse/ @patrickhulce @brendankenny\n+lighthouse-cli/test/fixtures/ @patrickhulce # @brendankenny\n+lighthouse-cli/test/smokehouse/ @patrickhulce # @brendankenny\nlighthouse-core/gather/ @patrickhulce @paulirish\n-lighthouse-core/audits/ @patrickhulce @brendankenny @paulirish\n+lighthouse-core/audits/ @patrickhulce @paulirish # @brendankenny\nlighthouse-core/report/ @vinamratasingal @paulirish\n-lighthouse-core/config/ @patrickhulce @brendankenny\n-lighthouse-core/lib/ @brendankenny @paulirish\n+lighthouse-core/config/ @patrickhulce # @brendankenny\n+lighthouse-core/lib/ @paulirish # @brendankenny\nlighthouse-extension/ @paulirish @patrickhulce\n-lighthouse-viewer/ @ebidel @brendankenny\n+lighthouse-viewer/ @ebidel # @brendankenny\ndocs/ @vinamratasingal @paulirish\n",
"new_path": ".github/CODEOWNERS",
"old_path": ".github/CODEOWNERS"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
misc(codeowners): represent brendan's leave (#3991)
| 1
|
misc
|
codeowners
|
448,039
|
06.12.2017 09:08:15
| -3,600
|
f3540dc3f4a74fd43c19a93f951ccc77efc936ff
|
release: cut v2.0.0-rc.5
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"2.0.0-rc.5\"></a>\n+# [2.0.0-rc.5](https://github.com/dherges/ng-packagr/compare/v2.0.0-rc.4...v2.0.0-rc.5) (2017-12-06)\n+\n+\n+### Bug Fixes\n+\n+* inline empty stylesheets ([aa621b1](https://github.com/dherges/ng-packagr/commit/aa621b1))\n+* update rollup to version ^0.52.0 ([#318](https://github.com/dherges/ng-packagr/issues/318)) ([317c88b](https://github.com/dherges/ng-packagr/commit/317c88b))\n+\n+\n+### Features\n+\n+* consistent `flatModuleFile` naming for bundles ([#361](https://github.com/dherges/ng-packagr/issues/361)) ([17b4e0f](https://github.com/dherges/ng-packagr/commit/17b4e0f))\n+* enable tslib `importHelpers`, reducing bundle sizes ([#338](https://github.com/dherges/ng-packagr/issues/338)) ([f1e4cf6](https://github.com/dherges/ng-packagr/commit/f1e4cf6))\n+* expose programmatic API and typings ([#342](https://github.com/dherges/ng-packagr/issues/342)) ([61c7b50](https://github.com/dherges/ng-packagr/commit/61c7b50))\n+* implement `transformSources()` w/ domain model ([#356](https://github.com/dherges/ng-packagr/issues/356)) ([89ce2ce](https://github.com/dherges/ng-packagr/commit/89ce2ce))\n+* relocate source map file paths to `ng://<(at)org>/<package>/<sub>` ([#332](https://github.com/dherges/ng-packagr/issues/332)) ([c9b8d73](https://github.com/dherges/ng-packagr/commit/c9b8d73))\n+* resolve \"~\" scss import statements to nearest `node_modules` ([#352](https://github.com/dherges/ng-packagr/issues/352)) ([ee9800b](https://github.com/dherges/ng-packagr/commit/ee9800b)), closes [#346](https://github.com/dherges/ng-packagr/issues/346)\n+* resource inlining w/ TypeScript transformations ([#279](https://github.com/dherges/ng-packagr/issues/279)) ([4753066](https://github.com/dherges/ng-packagr/commit/4753066))\n+\n+\n+### BREAKING CHANGES\n+\n+* Introduces a domain model for _Package_ and _Entry Point_ (as defined in Angular Package Format Specification Glossary). Refactors the source code transformation pipeline. Albeit the refactoring was undertaken with care and integration tests were not changed, it may cause undesired behaviour.\n+\n+\n+\n<a name=\"2.0.0-rc.4\"></a>\n# [2.0.0-rc.4](https://github.com/dherges/ng-packagr/compare/v2.0.0-rc.3...v2.0.0-rc.4) (2017-11-28)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"ng-packagr\",\n- \"version\": \"2.0.0-rc.4\",\n+ \"version\": \"2.0.0-rc.5\",\n\"description\": \"Compile and package a TypeScript library to Angular Package Format\",\n\"keywords\": [\n\"angular\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
release: cut v2.0.0-rc.5
| 1
|
release
| null |
791,897
|
07.12.2017 19:40:55
| -3,600
|
28f816e3f49413e88a0dec4543cdc0f105166d9c
|
core(seo): consistent help text links
* core(help-text): improve help text
Update help text meta-description audit to be more consistent with the other audits.
* core(help-text): improve help text
|
[
{
"change_type": "MODIFY",
"diff": "@@ -17,8 +17,8 @@ class Description extends Audit {\ndescription: 'Document has a meta description',\nfailureDescription: 'Document does not have a meta description',\nhelpText: 'Meta descriptions may be included in search results to concisely summarize ' +\n- 'page content. Read more in the ' +\n- '[Search Console Help page](https://support.google.com/webmasters/answer/35624?hl=en#1).',\n+ 'page content. ' +\n+ '[Learn more](https://support.google.com/webmasters/answer/35624?hl=en#1).',\nrequiredArtifacts: ['MetaDescription'],\n};\n}\n",
"new_path": "lighthouse-core/audits/seo/meta-description.js",
"old_path": "lighthouse-core/audits/seo/meta-description.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(seo): consistent help text links (#3901)
* core(help-text): improve help text
Update help text meta-description audit to be more consistent with the other audits.
* core(help-text): improve help text
| 1
|
core
|
seo
|
791,723
|
08.12.2017 09:49:48
| 28,800
|
d782494d52668cbec75c24f92b8bb0f49c337d92
|
core(web-inspector): keep all experiments disabled, fixing conflict when running in DevTools
|
[
{
"change_type": "MODIFY",
"diff": "@@ -30,10 +30,10 @@ module.exports = (function() {\nconst _setImmediate = global.setImmediate;\nglobal.Runtime = global.Runtime || {};\n-\n- // Required for devtools-timeline-model\nglobal.Runtime.experiments = global.Runtime.experiments || {};\n- global.Runtime.experiments.isEnabled = global.Runtime.experiments.isEnabled || (_ => false);\n+ // DevTools runtime doesn't know about some experiments that DTM looks for\n+ // To avoid exceptions, we assume all experiments are disabled\n+ global.Runtime.experiments.isEnabled = (_ => false);\nconst _queryParam = global.Runtime.queryParam;\nglobal.Runtime.queryParam = function(arg) {\n",
"new_path": "lighthouse-core/lib/web-inspector.js",
"old_path": "lighthouse-core/lib/web-inspector.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(web-inspector): keep all experiments disabled, fixing conflict when running in DevTools (#4010)
| 1
|
core
|
web-inspector
|
791,731
|
08.12.2017 15:33:11
| 28,800
|
b079325f8139864bc0f3af98ff0e51bdaeead54b
|
core(gather-runner): fix headless chrome UA check
|
[
{
"change_type": "MODIFY",
"diff": "@@ -172,7 +172,7 @@ class GatherRunner {\n* @param {!GathererResults} gathererResults\n*/\nstatic warnOnHeadless(userAgent, gathererResults) {\n- if (userAgent.startsWith('HeadlessChrome')) {\n+ if (userAgent.includes('HeadlessChrome')) {\ngathererResults.LighthouseRunWarnings.push('Your site\\'s mobile performance may be ' +\n'worse than the numbers presented in this report. Lighthouse could not test on a ' +\n'mobile connection because Headless Chrome does not support network throttling.');\n",
"new_path": "lighthouse-core/gather/gather-runner.js",
"old_path": "lighthouse-core/gather/gather-runner.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -943,7 +943,7 @@ describe('GatherRunner', function() {\n});\nit('issues a lighthouseRunWarnings if running in Headless', () => {\n- const userAgent = 'HeadlessChrome/64.0.3240.0';\n+ const userAgent = 'Mozilla/5.0 AppleWebKit/537.36 HeadlessChrome/64.0.3264.0 Safari/537.36';\nconst gathererResults = {\nLighthouseRunWarnings: [],\n};\n",
"new_path": "lighthouse-core/test/gather/gather-runner-test.js",
"old_path": "lighthouse-core/test/gather/gather-runner-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(gather-runner): fix headless chrome UA check (#4019)
| 1
|
core
|
gather-runner
|
448,085
|
09.12.2017 00:19:56
| 28,800
|
8c380aa873f2a13246f23a2f86418a4ed7442b2a
|
fix: show proper path of failure on sass inline
when the sass inline fails it showed that it failed in `Object object` when it should tell you which file failed.
|
[
{
"change_type": "MODIFY",
"diff": "@@ -87,7 +87,7 @@ const processStylesheet =\nreturn Promise.resolve(result.css);\n} catch (err) {\n- return Promise.reject(new Error(`Cannot inline stylesheet ${path}`));\n+ return Promise.reject(new Error(`Cannot inline stylesheet ${stylesheetFilePath}`));\n}\n}\n",
"new_path": "src/lib/steps/assets.ts",
"old_path": "src/lib/steps/assets.ts"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
fix: show proper path of failure on sass inline (#380)
when the sass inline fails it showed that it failed in `Object object` when it should tell you which file failed.
| 1
|
fix
| null |
448,072
|
09.12.2017 18:44:01
| -7,200
|
6c36032f60f4e8d56780213765cbda58b78be1bd
|
ci: TravisBuddy Integration :zap:
|
[
{
"change_type": "MODIFY",
"diff": "language: node_js\n-\nnode_js:\n- - \"node\"\n- - \"8\"\n- - \"7\"\n- - \"6\"\n-\n-script: yarn test\n-\n+ - node\n+ - '8'\n+ - '7'\n+ - '6'\n+script: 'yarn test'\ncache:\nyarn: true\n+notifications:\n+ webhooks:\n+ urls:\n+ - 'https://www.travisbuddy.com/'\n+ on_success: never\n+ on_failure: always\n+ on_start: never\n+ on_cancel: never\n+ on_error: never\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
ci: TravisBuddy Integration :zap: (#364)
| 1
|
ci
| null |
791,690
|
09.12.2017 20:07:17
| 28,800
|
e217d090dbdfbbc2532b527537657a68756f34dd
|
core(critical-request-chains): corrected help text
|
[
{
"change_type": "MODIFY",
"diff": "@@ -18,9 +18,9 @@ class CriticalRequestChains extends Audit {\ndescription: 'Critical Request Chains',\ninformative: true,\nhelpText: 'The Critical Request Chains below show you what resources are ' +\n- 'required for first render of this page. Improve page load by reducing ' +\n+ 'issued with a high priority. Consider reducing ' +\n'the length of chains, reducing the download size of resources, or ' +\n- 'deferring the download of unnecessary resources. ' +\n+ 'deferring the download of unnecessary resources to improve page load. ' +\n'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/critical-request-chains).',\nrequiredArtifacts: ['devtoolsLogs'],\n};\n",
"new_path": "lighthouse-core/audits/critical-request-chains.js",
"old_path": "lighthouse-core/audits/critical-request-chains.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(critical-request-chains): corrected help text (#4009)
| 1
|
core
|
critical-request-chains
|
791,723
|
11.12.2017 10:48:52
| 28,800
|
f49ef0602537de1a87e692960d8962974c566e1e
|
report(perf-audits): adjust presentation of runtime cost audits
|
[
{
"change_type": "MODIFY",
"diff": "@@ -18,7 +18,7 @@ class BootupTime extends Audit {\nreturn {\ncategory: 'Performance',\nname: 'bootup-time',\n- description: 'JavaScript boot-up time is high (> 4s)',\n+ description: 'JavaScript boot-up time',\nfailureDescription: 'JavaScript boot-up time is too high',\nhelpText: 'Consider reducing the time spent parsing, compiling and executing JS. ' +\n'You may find delivering smaller JS payloads helps with this.',\n@@ -93,7 +93,7 @@ class BootupTime extends Audit {\nconst tableDetails = BootupTime.makeTableDetails(headings, results);\nreturn {\n- score: totalBootupTime < 4000,\n+ score: totalBootupTime < 2000,\nrawValue: totalBootupTime,\ndisplayValue: Util.formatMilliseconds(totalBootupTime),\ndetails: tableDetails,\n",
"new_path": "lighthouse-core/audits/bootup-time.js",
"old_path": "lighthouse-core/audits/bootup-time.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -85,7 +85,7 @@ class PageExecutionTimings extends Audit {\nconst tableDetails = PageExecutionTimings.makeTableDetails(headings, results);\nreturn {\n- score: false,\n+ score: totalExecutionTime < 3000,\nrawValue: totalExecutionTime,\ndisplayValue: Util.formatMilliseconds(totalExecutionTime),\ndetails: tableDetails,\n",
"new_path": "lighthouse-core/audits/mainthread-work-breakdown.js",
"old_path": "lighthouse-core/audits/mainthread-work-breakdown.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -71,7 +71,7 @@ describe('Performance: page execution timings audit', () => {\nconst valueOf = name => Math.round(output.extendedInfo.value[name]);\nassert.equal(output.details.items.length, 12);\n- assert.equal(output.score, false);\n+ assert.equal(output.score, true);\nassert.equal(Math.round(output.rawValue), 611);\nfor (const category in output.extendedInfo.value) {\n@@ -92,7 +92,7 @@ describe('Performance: page execution timings audit', () => {\nreturn PageExecutionTimings.audit(artifacts).then(output => {\nconst valueOf = name => Math.round(output.extendedInfo.value[name]);\nassert.equal(output.details.items.length, 13);\n- assert.equal(output.score, false);\n+ assert.equal(output.score, true);\nassert.equal(Math.round(output.rawValue), 596);\nfor (const category in output.extendedInfo.value) {\n@@ -113,7 +113,7 @@ describe('Performance: page execution timings audit', () => {\nreturn PageExecutionTimings.audit(artifacts).then(output => {\nconst valueOf = name => Math.round(output.extendedInfo.value[name]);\nassert.equal(output.details.items.length, 12);\n- assert.equal(output.score, false);\n+ assert.equal(output.score, true);\nassert.equal(Math.round(output.rawValue), 524);\nfor (const category in output.extendedInfo.value) {\n@@ -133,7 +133,7 @@ describe('Performance: page execution timings audit', () => {\nreturn PageExecutionTimings.audit(artifacts).then(output => {\nassert.equal(output.details.items.length, 0);\n- assert.equal(output.score, false);\n+ assert.equal(output.score, true);\nassert.equal(Math.round(output.rawValue), 0);\n});\n});\n",
"new_path": "lighthouse-core/test/audits/mainthread-work-breakdown-test.js",
"old_path": "lighthouse-core/test/audits/mainthread-work-breakdown-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
report(perf-audits): adjust presentation of runtime cost audits (#4020)
| 1
|
report
|
perf-audits
|
573,227
|
12.12.2017 00:13:54
| -3,600
|
4c2cb1a7edfe6252e68e409d850aef73961338ca
|
fix(request): date() and time() methods return value
|
[
{
"change_type": "MODIFY",
"diff": "@@ -241,14 +241,9 @@ function patch(Request) {\n* @memberof Request\n* @instance\n* @function date\n- * @returns {Date} date\n+ * @returns {Date} date when request began being processed\n*/\nRequest.prototype.date = function date() {\n- if (this._date !== undefined) {\n- return this._date;\n- }\n-\n- this._date = new Date(this._time);\nreturn this._date;\n};\n@@ -410,10 +405,12 @@ function patch(Request) {\n* @memberof Request\n* @instance\n* @function time\n- * @returns {Number} time\n+ * @returns {Number} time when request began being processed in epoch:\n+ * ellapsed milliseconds since\n+ * January 1, 1970, 00:00:00 UTC\n*/\nRequest.prototype.time = function time() {\n- return this._time;\n+ return this._date.getTime();\n};\n/**\n",
"new_path": "lib/request.js",
"old_path": "lib/request.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -1210,6 +1210,7 @@ Server.prototype._run = function _run(req, res, route, chain, cb) {\nServer.prototype._setupRequest = function _setupRequest(req, res) {\nvar self = this;\nreq.log = res.log = self.log;\n+ req._date = new Date();\nreq._time = process.hrtime();\nreq.serverName = self.name;\n",
"new_path": "lib/server.js",
"old_path": "lib/server.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -191,3 +191,35 @@ test('should provide route object', function(t) {\nt.end();\n});\n});\n+\n+test('should provide time when request started', function(t) {\n+ SERVER.get('/ping/:name', function(req, res, next) {\n+ t.equal(typeof req.time(), 'number');\n+ t.ok(req.time() > Date.now() - 1000);\n+ t.ok(req.time() <= Date.now());\n+ res.send('ok');\n+ return next();\n+ });\n+\n+ CLIENT.get('/ping/lagavulin', function(err, _, res) {\n+ t.ifError(err);\n+ t.equal(res.statusCode, 200);\n+ t.end();\n+ });\n+});\n+\n+test('should provide date when request started', function(t) {\n+ SERVER.get('/ping/:name', function(req, res, next) {\n+ t.ok(req.date() instanceof Date);\n+ t.ok(req.date().getTime() > Date.now() - 1000);\n+ t.ok(req.date().getTime() <= Date.now());\n+ res.send('ok');\n+ return next();\n+ });\n+\n+ CLIENT.get('/ping/lagavulin', function(err, _, res) {\n+ t.ifError(err);\n+ t.equal(res.statusCode, 200);\n+ t.end();\n+ });\n+});\n",
"new_path": "test/request.test.js",
"old_path": "test/request.test.js"
}
] |
JavaScript
|
MIT License
|
restify/node-restify
|
fix(request): date() and time() methods return value (#1576)
| 1
|
fix
|
request
|
791,731
|
12.12.2017 13:53:10
| 28,800
|
a73e7da82b122bdaa10d782eea6b217fc177bb16
|
report(warnings): warn only if using an old headless
|
[
{
"change_type": "MODIFY",
"diff": "@@ -172,10 +172,15 @@ class GatherRunner {\n* @param {!GathererResults} gathererResults\n*/\nstatic warnOnHeadless(userAgent, gathererResults) {\n- if (userAgent.includes('HeadlessChrome')) {\n+ const chromeVersion = userAgent.split(/HeadlessChrome\\/(.*) /)[1];\n+ // Headless Chrome gained throttling support in Chrome 63.\n+ // https://chromium.googlesource.com/chromium/src/+/8931a104b145ccf92390f6f48fba6553a1af92e4\n+ const minVersion = '63.0.3239.0';\n+ if (chromeVersion && chromeVersion < minVersion) {\ngathererResults.LighthouseRunWarnings.push('Your site\\'s mobile performance may be ' +\n'worse than the numbers presented in this report. Lighthouse could not test on a ' +\n- 'mobile connection because Headless Chrome does not support network throttling.');\n+ 'mobile connection because Headless Chrome does not support network throttling ' +\n+ 'prior to version ' + minVersion + '. The version used was ' + chromeVersion);\n}\n}\n",
"new_path": "lighthouse-core/gather/gather-runner.js",
"old_path": "lighthouse-core/gather/gather-runner.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -942,13 +942,17 @@ describe('GatherRunner', function() {\n});\n});\n- it('issues a lighthouseRunWarnings if running in Headless', () => {\n- const userAgent = 'Mozilla/5.0 AppleWebKit/537.36 HeadlessChrome/64.0.3264.0 Safari/537.36';\n+ it('issues a lighthouseRunWarnings if running an old version of Headless', () => {\nconst gathererResults = {\nLighthouseRunWarnings: [],\n};\n+ const userAgent = 'Mozilla/5.0 AppleWebKit/537.36 HeadlessChrome/63.0.3239.0 Safari/537.36';\nGatherRunner.warnOnHeadless(userAgent, gathererResults);\n+ assert.strictEqual(gathererResults.LighthouseRunWarnings.length, 0);\n+\n+ const oldUserAgent = 'Mozilla/5.0 AppleWebKit/537.36 HeadlessChrome/62.0.3239.0 Safari/537.36';\n+ GatherRunner.warnOnHeadless(oldUserAgent, gathererResults);\nassert.strictEqual(gathererResults.LighthouseRunWarnings.length, 1);\nconst warning = gathererResults.LighthouseRunWarnings[0];\nassert.ok(/Headless Chrome/.test(warning));\n",
"new_path": "lighthouse-core/test/gather/gather-runner-test.js",
"old_path": "lighthouse-core/test/gather/gather-runner-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
report(warnings): warn only if using an old headless (#4021)
| 1
|
report
|
warnings
|
448,039
|
12.12.2017 15:16:13
| -3,600
|
816b3b90a1738fccea548db97b5db206ea3ebc8d
|
style: try to avoid the word "conf" and "configuration"
|
[
{
"change_type": "MODIFY",
"diff": "@@ -27,29 +27,32 @@ interface UserPackage {\n}\n/**\n- * Resolves a package conf by testing for 'package.json', 'ng-package.json', or 'ng-package.js'.\n+ * Resolves a user's package by testing for 'package.json', 'ng-package.json', or 'ng-package.js'.\n*\n* @param folderPathOrFilePath A path pointing either to a file or a directory\n- * @return The user's package conf\n+ * @return The user's package\n*/\n-const resolvePackageConf =\n+const resolveUserPackage =\nasync (folderPathOrFilePath: string): Promise<UserPackage | undefined> => {\nconst pathStats = await lstat(folderPathOrFilePath);\nconst fullPath = path.isAbsolute(folderPathOrFilePath) ? folderPathOrFilePath : path.resolve(folderPathOrFilePath);\nconst basePath = pathStats.isDirectory() ? fullPath : path.dirname(fullPath);\nconst packageJson = await readJson(path.join(basePath, 'package.json'));\n- const packageConfPathJson = path.join(basePath, 'ng-package.json');\n- const packageConfPathJs = path.join(basePath, 'ng-package.js');\n+ const ngPackageJsonPath = path.join(basePath, 'ng-package.json');\n+ const ngPackageJsPath = path.join(basePath, 'ng-package.js');\nlet ngPackageJson: undefined | object;\nif (packageJson['ngPackage']) {\n+ // Read `ngPackage` from `package.json`\nngPackageJson = { ...packageJson['ngPackage'] }\n- } else if (await fileExists(packageConfPathJson)) {\n- ngPackageJson = await readJson(packageConfPathJson);\n- } else if ((await fileExists(packageConfPathJs))) {\n- ngPackageJson = await import(packageConfPathJs);\n+ } else if (await fileExists(ngPackageJsonPath)) {\n+ // Read 'ng-package.json' file\n+ ngPackageJson = await readJson(ngPackageJsonPath);\n+ } else if ((await fileExists(ngPackageJsPath))) {\n+ // Dynamic `require('<path>') the given file\n+ ngPackageJson = await import(ngPackageJsPath);\n}\nif (ngPackageJson) {\n@@ -161,13 +164,13 @@ export const discoverPackages =\nasync ({ project }: { project: string }): Promise<NgPackage> => {\nproject = path.isAbsolute(project) ? project : path.resolve(project);\n- const primaryPackage = await resolvePackageConf(project);\n+ const primaryPackage = await resolveUserPackage(project);\nconst primary = primaryEntryPoint(primaryPackage);\nlog.debug(`Found primary entry point: ${primary.moduleId}`);\nconst secondaries = await (findSecondaryPackagesPaths(primaryPackage.basePath, primary.$get('dest'))\n.then((folderPaths) => Promise.all(folderPaths\n- .map((folderPath) => resolvePackageConf(folderPath)\n+ .map((folderPath) => resolveUserPackage(folderPath)\n.catch(() => {\nlog.warn(`Cannot read secondary entry point at ${folderPath}. Skipping.`);\n",
"new_path": "src/lib/steps/init.ts",
"old_path": "src/lib/steps/init.ts"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
style: try to avoid the word "conf" and "configuration"
| 1
|
style
| null |
791,690
|
14.12.2017 13:26:19
| 28,800
|
7f005e5b46e9ef961a438dbfffa21cc2bf354f53
|
core(optimized-images): skip mismatched mimeTypes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -73,7 +73,9 @@ class OptimizedImages extends Gatherer {\n}\nseenUrls.add(record._url);\n- const isOptimizableImage = /image\\/(png|bmp|jpeg)/.test(record._mimeType);\n+ const isOptimizableImage = record._resourceType &&\n+ record._resourceType._name === 'image' &&\n+ /image\\/(png|bmp|jpeg)/.test(record._mimeType);\nconst isSameOrigin = URL.originsMatch(pageUrl, record._url);\nconst isBase64DataUri = /^data:.{2,40}base64\\s*,/.test(record._url);\n",
"new_path": "lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js",
"old_path": "lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -23,50 +23,65 @@ const traceData = {\n_url: 'http://google.com/image.jpg',\n_mimeType: 'image/jpeg',\n_resourceSize: 10000,\n+ _resourceType: {_name: 'image'},\nfinished: true,\n},\n{\n_url: 'http://google.com/transparent.png',\n_mimeType: 'image/png',\n_resourceSize: 11000,\n+ _resourceType: {_name: 'image'},\nfinished: true,\n},\n{\n_url: 'http://google.com/image.bmp',\n_mimeType: 'image/bmp',\n_resourceSize: 12000,\n+ _resourceType: {_name: 'image'},\nfinished: true,\n},\n{\n_url: 'http://google.com/image.bmp',\n_mimeType: 'image/bmp',\n_resourceSize: 12000,\n+ _resourceType: {_name: 'image'},\nfinished: true,\n},\n{\n_url: 'http://google.com/vector.svg',\n_mimeType: 'image/svg+xml',\n_resourceSize: 13000,\n+ _resourceType: {_name: 'image'},\nfinished: true,\n},\n{\n_url: 'http://gmail.com/image.jpg',\n_mimeType: 'image/jpeg',\n_resourceSize: 15000,\n+ _resourceType: {_name: 'image'},\nfinished: true,\n},\n{\n_url: 'data: image/jpeg ; base64 ,SgVcAT32587935321...',\n_mimeType: 'image/jpeg',\n+ _resourceType: {_name: 'image'},\n_resourceSize: 14000,\nfinished: true,\n},\n{\n_url: 'http://google.com/big-image.bmp',\n_mimeType: 'image/bmp',\n+ _resourceType: {_name: 'image'},\n_resourceSize: 12000,\nfinished: false, // ignore for not finishing\n},\n+ {\n+ _url: 'http://google.com/not-an-image.bmp',\n+ _mimeType: 'image/bmp',\n+ _resourceType: {_name: 'document'}, // ignore for not really being an image\n+ _resourceSize: 12000,\n+ finished: true,\n+ },\n],\n};\n",
"new_path": "lighthouse-core/test/gather/gatherers/dobetterweb/optimized-images-test.js",
"old_path": "lighthouse-core/test/gather/gatherers/dobetterweb/optimized-images-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(optimized-images): skip mismatched mimeTypes (#4045)
| 1
|
core
|
optimized-images
|
815,745
|
16.12.2017 14:10:07
| -7,200
|
ff8981c9bdc0a7f6a9795024ae46292f67749156
|
fix: separate extraneous properties with object values closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -5,7 +5,8 @@ import { Component, ChangeDetectionStrategy } from '@angular/core';\nchangeDetection: ChangeDetectionStrategy.OnPush,\ntemplate: `\n<p>\n- By default the dropdown is displayed below the ng-select. You can change the default position by setting dropdownPosition to above or below.\n+ By default the dropdown is displayed below the ng-select.\n+ You can change the default position by setting dropdownPosition to above or below.\n</p>\n---html,true\n",
"new_path": "demo/app/examples/dropdown-positions.component.ts",
"old_path": "demo/app/examples/dropdown-positions.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -10,6 +10,7 @@ export class ItemsList {\nprivate _selected: NgOption[] = [];\nprivate _multiple = false;\nprivate _simple = false;\n+ private _bindLabel: string;\nget value(): NgOption[] {\nreturn this._selected;\n@@ -19,8 +20,9 @@ export class ItemsList {\nreturn this.filteredItems[this._markedIndex];\n}\n- setItems(items: NgOption[], simple: boolean = false) {\n+ setItems(items: NgOption[], bindLabel: string, simple: boolean = false) {\nthis._simple = simple;\n+ this._bindLabel = bindLabel;\nthis.items = this.mapItems(items);\nthis.filteredItems = [...this.items];\n}\n@@ -41,16 +43,16 @@ export class ItemsList {\nitem.selected = true;\n}\n- findItem(value, bindValue: string, bindLabel: string): NgOption {\n+ findItem(value, bindValue: string): NgOption {\nif (!value) {\nreturn null;\n}\nif (bindValue) {\n- return this.items.find(x => x[bindValue] === value);\n+ return this.items.find(item => item.value[bindValue] === value);\n}\nconst index = this.items.indexOf(value);\nreturn index > -1 ? this.items[index] :\n- this.items.find(x => x[bindLabel] === value[bindLabel])\n+ this.items.find(item => item.label === value[this._bindLabel])\n}\nunselect(item: NgOption) {\n@@ -67,10 +69,15 @@ export class ItemsList {\nthis._selected.splice(this._selected.length - 1, 1);\n}\n- addItem(item: NgOption) {\n- item.index = this.items.length;\n- this.items.push(item);\n- this.filteredItems.push(item);\n+ addItem(item: any) {\n+ const option = {\n+ index: this.items.length,\n+ label: item[this._bindLabel],\n+ value: item\n+ }\n+ this.items.push(option);\n+ this.filteredItems.push(option);\n+ return option;\n}\nclearSelected() {\n@@ -81,8 +88,8 @@ export class ItemsList {\nthis._selected = [];\n}\n- filter(term: string, bindLabel: string) {\n- const filterFuncVal = this.getDefaultFilterFunc(term, bindLabel);\n+ filter(term: string) {\n+ const filterFuncVal = this.getDefaultFilterFunc(term);\nthis.filteredItems = term ? this.items.filter(val => filterFuncVal(val)) : this.items;\n}\n@@ -132,9 +139,9 @@ export class ItemsList {\n}\n}\n- private getDefaultFilterFunc(term, bindLabel: string) {\n- return (val: NgOption) => {\n- return searchHelper.stripSpecialChars(val[bindLabel] || '')\n+ private getDefaultFilterFunc(term) {\n+ return (option: NgOption) => {\n+ return searchHelper.stripSpecialChars(option.label || '')\n.toUpperCase()\n.indexOf(searchHelper.stripSpecialChars(term).toUpperCase()) > -1;\n};\n@@ -155,7 +162,9 @@ export class ItemsList {\nreturn {\nindex: index,\n- ...option\n+ label: option[this._bindLabel],\n+ value: option,\n+ disabled: !!option.disabled,\n};\n})\n}\n",
"new_path": "src/ng-select/items-list.ts",
"old_path": "src/ng-select/items-list.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -23,14 +23,10 @@ describe('NgSelectComponent', function () {\n[(ngModel)]=\"selectedCity\">\n</ng-select>`);\n- // select second city\nselectOption(fixture, KeyCode.ArrowDown, 1);\n-\ntickAndDetectChanges(fixture);\n-\nexpect(fixture.componentInstance.selectedCity).toEqual(jasmine.objectContaining(fixture.componentInstance.cities[1]));\n- // clear select\nfixture.componentInstance.select.clearModel();\ntickAndDetectChanges(fixture);\n@@ -47,13 +43,14 @@ describe('NgSelectComponent', function () {\n[(ngModel)]=\"selectedCity\">\n</ng-select>`);\n- // select first city\nfixture.componentInstance.selectedCity = fixture.componentInstance.cities[0];\ntickAndDetectChanges(fixture);\n+ expect(fixture.componentInstance.select.selectedItems).toEqual([\n+ jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[0]\n+ })\n+ ]);\n- expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining(fixture.componentInstance.cities[0])]);\n-\n- // clear model\nfixture.componentInstance.selectedCity = null;\ntickAndDetectChanges(fixture);\n@@ -102,7 +99,11 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.cities = cities;\ntickAndDetectChanges(fixture);\n- expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining(cities[0])]);\n+ expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining(\n+ {\n+ value: cities[0]\n+ }\n+ )]);\n}));\nit('should bind ngModel even if items are empty', fakeAsync(() => {\n@@ -120,7 +121,10 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.selectedCity = { id: 7, name: 'Pailgis' };\ntickAndDetectChanges(fixture);\n- expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining({ id: 7, name: 'Pailgis' })]);\n+ expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining({\n+ value: { id: 7, name: 'Pailgis' },\n+ selected: true\n+ })]);\n}));\nit('should preserve latest selected value when items are changing', fakeAsync(() => {\n@@ -135,7 +139,8 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.selectedCity = fixture.componentInstance.cities[0];\ntickAndDetectChanges(fixture);\n- fixture.componentInstance.select.select(fixture.componentInstance.cities[1]);\n+\n+ fixture.componentInstance.select.select(fixture.componentInstance.select.itemsList.items[1]);\ntickAndDetectChanges(fixture);\nfixture.componentInstance.cities = [...fixture.componentInstance.cities];\n@@ -189,7 +194,9 @@ describe('NgSelectComponent', function () {\n// from model to component\nfixture.componentInstance.selectedCityId = 2;\ntickAndDetectChanges(fixture);\n- expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining(fixture.componentInstance.cities[1])]);\n+ expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[1]\n+ })]);\ndiscardPeriodicTasks();\n}));\n@@ -218,17 +225,16 @@ describe('NgSelectComponent', function () {\n// from component to model\nselectOption(fixture, KeyCode.ArrowDown, 0);\n-\ntickAndDetectChanges(fixture);\n-\n- expect(fixture.componentInstance.selectedCity).toEqual(jasmine.objectContaining(fixture.componentInstance.cities[0]));\n+ expect(fixture.componentInstance.selectedCity).toEqual(fixture.componentInstance.cities[0]);\n// from model to component\nfixture.componentInstance.selectedCity = fixture.componentInstance.cities[1];\n-\ntickAndDetectChanges(fixture);\n- expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining(fixture.componentInstance.cities[1])]);\n+ expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[1]\n+ })]);\ndiscardPeriodicTasks();\n}));\n});\n@@ -246,7 +252,10 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\ntickAndDetectChanges(fixture);\n- const result = [jasmine.objectContaining({ id: 2, name: 'Kaunas', selected: true })];\n+ const result = [jasmine.objectContaining({\n+ value: { id: 2, name: 'Kaunas' },\n+ selected: true\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\n@@ -260,7 +269,10 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\ntickAndDetectChanges(fixture);\n- const result = [jasmine.objectContaining({ id: 2, name: 'Kaunas', selected: true })];\n+ const result = [jasmine.objectContaining({\n+ value: { id: 2, name: 'Kaunas' },\n+ selected: true\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\n@@ -274,7 +286,10 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\ntickAndDetectChanges(fixture);\n- const result = [jasmine.objectContaining({ id: 2, name: 'Kaunas', selected: true })];\n+ const result = [jasmine.objectContaining({\n+ value: { id: 2, name: 'Kaunas' },\n+ selected: true\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\n@@ -295,8 +310,15 @@ describe('NgSelectComponent', function () {\ndescribe('multiple', () => {\nconst result = [\n- jasmine.objectContaining({ id: 2, name: 'Kaunas', selected: true }),\n- jasmine.objectContaining({ id: 3, name: 'Pabrade', selected: true })];\n+ jasmine.objectContaining({\n+ value: { id: 2, name: 'Kaunas' },\n+ selected: true\n+ }),\n+ jasmine.objectContaining({\n+ value: { id: 3, name: 'Pabrade' },\n+ selected: true\n+ })];\n+\nit('should select by bindValue when primitive type', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectSelectedSimpleMultipleCmp,\n@@ -358,7 +380,7 @@ describe('NgSelectComponent', function () {\n}));\nit('should open dropdown and mark first item', () => {\n- const result = fixture.componentInstance.cities[0];\n+ const result = { value: fixture.componentInstance.cities[0] };\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\nexpect(fixture.componentInstance.select.itemsList.markedItem).toEqual(jasmine.objectContaining(result));\n});\n@@ -373,7 +395,9 @@ describe('NgSelectComponent', function () {\ndescribe('arrows', () => {\nit('should select next value on arrow down', () => {\nselectOption(fixture, KeyCode.ArrowDown, 1);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[1])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[1]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n});\n@@ -382,7 +406,9 @@ describe('NgSelectComponent', function () {\ntickAndDetectChanges(fixture);\nselectOption(fixture, KeyCode.ArrowDown, 1);\ntickAndDetectChanges(fixture);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[0])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[0]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\n@@ -391,7 +417,9 @@ describe('NgSelectComponent', function () {\ncity.disabled = true;\nselectOption(fixture, KeyCode.ArrowDown, 1);\ntickAndDetectChanges(fixture);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[1])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[1]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\n@@ -400,13 +428,17 @@ describe('NgSelectComponent', function () {\ntickAndDetectChanges(fixture);\nselectOption(fixture, KeyCode.ArrowUp, 1);\ntickAndDetectChanges(fixture);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[0])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[0]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\nit('should select last value on arrow up', () => {\nselectOption(fixture, KeyCode.ArrowUp, 1);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[2])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[2]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n});\n});\n@@ -441,7 +473,9 @@ describe('NgSelectComponent', function () {\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Tab);\ntickAndDetectChanges(fixture);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[0])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[0]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\nexpect(fixture.componentInstance.select.isOpen).toBeFalsy()\n}));\n@@ -460,7 +494,9 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.selectedCity = fixture.componentInstance.cities[0];\ntickAndDetectChanges(fixture);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Backspace);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[0])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[0]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\n@@ -469,7 +505,9 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.selectedCity = fixture.componentInstance.cities[0];\ntickAndDetectChanges(fixture);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Backspace);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[0])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[0]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\n@@ -488,7 +526,9 @@ describe('NgSelectComponent', function () {\nselectOption(fixture, KeyCode.ArrowDown, 1);\ntickAndDetectChanges(fixture);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Backspace);\n- const result = [jasmine.objectContaining(fixture.componentInstance.cities[1])];\n+ const result = [jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[1]\n+ })];\nexpect(fixture.componentInstance.select.selectedItems).toEqual(result);\n}));\n});\n@@ -594,8 +634,12 @@ describe('NgSelectComponent', function () {\nconst items = fixture.componentInstance.select.itemsList.items;\nexpect(items.length).toBe(2);\n- expect(items[0]).toEqual(jasmine.objectContaining({ label: 'Yes', value: true, index: 0 }));\n- expect(items[1]).toEqual(jasmine.objectContaining({ label: 'No', value: false, index: 1 }));\n+ expect(items[0]).toEqual(jasmine.objectContaining({\n+ value: { label: 'Yes', value: true }\n+ }));\n+ expect(items[1]).toEqual(jasmine.objectContaining({\n+ value: { label: 'No', value: false }\n+ }));\n}));\n});\n@@ -629,7 +673,9 @@ describe('NgSelectComponent', function () {\nselectOption(fixture, KeyCode.ArrowDown, 1);\ntickAndDetectChanges(fixture);\nexpect((<NgOption[]>fixture.componentInstance.select.selectedItems).length).toBe(1);\n- expect(fixture.componentInstance.select.selectedItems[0].name).toBe('Pabrade');\n+ expect(fixture.componentInstance.select.selectedItems[0]).toEqual(jasmine.objectContaining({\n+ value: { id: 3, name: 'Pabrade' }\n+ }));\n}));\nit('should not toggle item on enter when dropdown is closed', () => {\n@@ -691,7 +737,7 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\n});\n- it('shoud be visible when no value selected', async(() => {\n+ it('should be visible when no value selected', async(() => {\nfixture.detectChanges();\nfixture.whenStable().then(() => {\nconst el = fixture.debugElement.query(By.css('.ng-placeholder')).nativeElement;\n@@ -711,7 +757,6 @@ describe('NgSelectComponent', function () {\ndescribe('Filter', () => {\nlet fixture: ComponentFixture<NgSelectFilterTestCmp>;\n-\nit('should filter using default implementation', fakeAsync(() => {\nfixture = createTestingModule(\nNgSelectFilterTestCmp,\n@@ -724,7 +769,9 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.select.onFilter({ target: { value: 'vilnius' } });\ntick(200);\n- const result = [jasmine.objectContaining({ id: 1, name: 'Vilnius' })];\n+ const result = [jasmine.objectContaining({\n+ value: { id: 1, name: 'Vilnius' }\n+ })];\nexpect(fixture.componentInstance.select.itemsList.filteredItems).toEqual(result);\n}));\n@@ -775,7 +822,9 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.select.onFilter({ target: { value: 'pab' } });\ntick(200);\n- const result = jasmine.objectContaining(fixture.componentInstance.cities[2]);\n+ const result = jasmine.objectContaining({\n+ value: fixture.componentInstance.cities[2]\n+ });\nexpect(fixture.componentInstance.select.itemsList.markedItem).toEqual(result)\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\nexpect(fixture.componentInstance.select.selectedItems).toEqual([result]);\n@@ -837,7 +886,9 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.cities = [{ id: 4, name: 'Bukiskes' }];\ntickAndDetectChanges(fixture);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\n- expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining({ id: 4, name: 'Bukiskes' })])\n+ expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining({\n+ value: { id: 4, name: 'Bukiskes' }\n+ })])\n}));\nit('should not mark first item when typeahead results are loaded', fakeAsync(() => {\n@@ -945,7 +996,7 @@ describe('NgSelectComponent', function () {\nspyOn(fixture.componentInstance, 'onAdd');\ntickAndDetectChanges(fixture);\n- fixture.componentInstance.select.select(fixture.componentInstance.cities[0]);\n+ fixture.componentInstance.select.select(fixture.componentInstance.select.itemsList.items[0]);\nexpect(fixture.componentInstance.onAdd).toHaveBeenCalledWith(fixture.componentInstance.cities[0]);\n}));\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -146,7 +146,6 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nngOnInit() {\nthis.handleDocumentClick();\n- this.bindLabel = this.bindLabel || this._defaultLabel;\nif (this._simple) {\nthis.bindValue = this._defaultLabel;\n}\n@@ -288,7 +287,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nthis.itemsList.select(item);\nthis.clearSearch();\nthis.updateModel();\n- this.addEvent.emit(item);\n+ this.addEvent.emit(item.value);\n}\nif (this.single) {\n@@ -305,13 +304,13 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nselectTag() {\nlet tag = {}\nif (this.addTag instanceof Function) {\n- tag = this.addTag(this.filterValue);\n+ tag = this.addTag(this.filterValue)\n} else {\ntag[this.bindLabel] = this.filterValue;\n}\n- this.itemsList.addItem(tag);\n- this.select(tag);\n+ const item = this.itemsList.addItem(tag);\n+ this.select(item);\n}\nshowPlaceholder() {\n@@ -359,7 +358,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nthis.isLoading = true;\nthis.typeahead.next(this.filterValue);\n} else {\n- this.itemsList.filter(this.filterValue, this.bindLabel);\n+ this.itemsList.filter(this.filterValue);\nthis.itemsList.markSelectedOrDefault(this.markFirst);\n}\n}\n@@ -386,8 +385,9 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nprivate setItems(items: NgOption[]) {\nconst firstItem = items[0];\n+ this.bindLabel = this.bindLabel || this._defaultLabel;\nthis._simple = firstItem && !(firstItem instanceof Object);\n- this.itemsList.setItems(items, this._simple);\n+ this.itemsList.setItems(items, this.bindLabel, this._simple);\nif (this._ngModel && items.length > 0) {\nthis.itemsList.clearSelected();\nthis.selectWriteValue(this._ngModel);\n@@ -400,16 +400,14 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\n}\nprivate setItemsFromNgOptions() {\n- if (!this.bindValue) {\n- this.bindValue = this._defaultValue;\n- }\n-\n+ this.bindLabel = this.bindLabel || this._defaultLabel;\n+ this.bindValue = this.bindValue || this._defaultValue;\nconst handleNgOptions = (options) => {\nthis.items = options.map(option => ({\nvalue: option.value,\nlabel: option.elementRef.nativeElement.innerHTML\n}));\n- this.itemsList.setItems(this.items);\n+ this.itemsList.setItems(this.items, this.bindLabel);\nif (this._ngModel) {\nthis.itemsList.clearSelected();\n@@ -477,12 +475,12 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\n}\nconst select = (val: any) => {\n- const item = this.itemsList.findItem(val, this.bindValue, this.bindLabel);\n+ const item = this.itemsList.findItem(val, this.bindValue);\nif (item) {\nthis.itemsList.select(item);\n} else if (val instanceof Object) {\n- this.itemsList.addItem(val);\n- this.itemsList.select(val);\n+ const newItem = this.itemsList.addItem(val);\n+ this.itemsList.select(newItem);\n}\n};\n@@ -576,7 +574,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nthis.onChange(null);\n} else if (this.bindValue) {\nngModel = Array.isArray(ngModel) ?\n- ngModel.map(x => x[this.bindValue]) :\n+ ngModel.map(option => option[this.bindValue]) :\nngModel[this.bindValue];\nthis.onChange(ngModel);\n} else {\n@@ -605,9 +603,10 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nprivate get value() {\nif (this.multiple) {\n- return this.selectedItems;\n+ return this.selectedItems.map(option => option.value);\n}\n- return this.selectedItems[0] || null;\n+ const selectedItem = this.selectedItems[0];\n+ return selectedItem ? selectedItem.value : null;\n}\nprivate get isValueSet() {\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -5,7 +5,7 @@ export interface NgOption {\ndisabled?: boolean;\nmarked?: boolean;\nlabel?: string;\n- value?: string;\n+ value?: string | Object;\n}\nexport enum KeyCode {\n",
"new_path": "src/ng-select/ng-select.types.ts",
"old_path": "src/ng-select/ng-select.types.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: separate extraneous properties with object values closes #165
| 1
|
fix
| null |
815,745
|
16.12.2017 19:44:36
| -7,200
|
b803744ec0263d1cf0bf246499d01520a52a478d
|
feat(bindLabel): support nested expression closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -14,10 +14,10 @@ import { Component, ChangeDetectionStrategy } from '@angular/core';\nSelected city object: {{selectedCity2 | json}}\n</p>\n<hr>\n- <label>Bind label to custom property</label>\n+ <label>Bind label to nested custom property</label>\n---html,true\n- <ng-select [items]=\"cities\"\n- bindLabel=\"name\"\n+ <ng-select [items]=\"countries\"\n+ bindLabel=\"description.name\"\nplaceholder=\"Select value\"\n[clearable]=\"false\"\n[(ngModel)]=\"selectedCity\">\n@@ -54,6 +54,12 @@ export class SelectBindingsComponent {\n{ id: 3, name: 'Pavilnys', disabled: true }\n];\n+ countries = [\n+ { id: 1, description: { name: 'Lithuania' } },\n+ { id: 2, description: { name: 'USA' } },\n+ { id: 3, description: { name: 'Australia' } }\n+ ];\n+\nselectedCity: any;\nselectedCity2: number = null;\nselectedCityId2: number = null;\n",
"new_path": "demo/app/examples/bindings.component.ts",
"old_path": "demo/app/examples/bindings.component.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -50,9 +50,9 @@ export class ItemsList {\nif (bindValue) {\nreturn this.items.find(item => item.value[bindValue] === value);\n}\n- const index = this.items.indexOf(value);\n+ const index = this.items.findIndex(x => x.value === value);\nreturn index > -1 ? this.items[index] :\n- this.items.find(item => item.label === value[this._bindLabel])\n+ this.items.find(item => item.label === this.resolveNested(value, this._bindLabel))\n}\nunselect(item: NgOption) {\n@@ -72,7 +72,7 @@ export class ItemsList {\naddItem(item: any) {\nconst option = {\nindex: this.items.length,\n- label: item[this._bindLabel],\n+ label: this.resolveNested(item, this._bindLabel),\nvalue: item\n}\nthis.items.push(option);\n@@ -162,10 +162,26 @@ export class ItemsList {\nreturn {\nindex: index,\n- label: option[this._bindLabel],\n+ label: this.resolveNested(option, this._bindLabel),\nvalue: option,\ndisabled: !!option.disabled,\n};\n})\n}\n+\n+ resolveNested(option: any, key: string): any {\n+ if (key.indexOf('.') === -1) {\n+ return option[key];\n+ } else {\n+ let keys: string[] = key.split('.');\n+ let value = option;\n+ for (let i = 0, len = keys.length; i < len; ++i) {\n+ if (value == null) {\n+ return null;\n+ }\n+ value = value[keys[i]];\n+ }\n+ return value;\n+ }\n+ }\n}\n",
"new_path": "src/ng-select/items-list.ts",
"old_path": "src/ng-select/items-list.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
feat(bindLabel): support nested expression closes #159
| 1
|
feat
|
bindLabel
|
744,032
|
18.12.2017 06:25:46
| -3,600
|
c679e907d1a19d0858698fdd9fa882d10c4ba5a3
|
fix: 'undefined' should be taken to mean no argument was provided
|
[
{
"change_type": "MODIFY",
"diff": "@@ -57,7 +57,7 @@ module.exports = function validation (yargs, usage, y18n) {\n// make sure that any args that require an\n// value (--foo=bar), have a value.\nself.missingArgumentValue = function missingArgumentValue (argv) {\n- const defaultValues = [true, false, '']\n+ const defaultValues = [true, false, '', undefined]\nconst options = yargs.getOptions()\nif (options.requiresArg.length > 0) {\n",
"new_path": "lib/validation.js",
"old_path": "lib/validation.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -369,6 +369,46 @@ describe('validation tests', () => {\n.argv\n})\n+ it('fails when a required argument of type number is missing', (done) => {\n+ yargs('-w')\n+ .option('w', {type: 'number', requiresArg: true})\n+ .fail((msg) => {\n+ msg.should.equal('Missing argument value: w')\n+ return done()\n+ })\n+ .argv\n+ })\n+\n+ it('fails when a required argument of type string is missing', (done) => {\n+ yargs('-w')\n+ .option('w', {type: 'string', requiresArg: true})\n+ .fail((msg) => {\n+ msg.should.equal('Missing argument value: w')\n+ return done()\n+ })\n+ .argv\n+ })\n+\n+ it('fails when a required argument of type boolean is missing', (done) => {\n+ yargs('-w')\n+ .option('w', {type: 'boolean', requiresArg: true})\n+ .fail((msg) => {\n+ msg.should.equal('Missing argument value: w')\n+ return done()\n+ })\n+ .argv\n+ })\n+\n+ it('fails when a required argument of type array is missing', (done) => {\n+ yargs('-w')\n+ .option('w', {type: 'array', requiresArg: true})\n+ .fail((msg) => {\n+ msg.should.equal('Missing argument value: w')\n+ return done()\n+ })\n+ .argv\n+ })\n+\nit('fails when required arguments are present, but a command is missing', (done) => {\nyargs('-w 10 -m wombat')\n.demand(1, ['w', 'm'])\n",
"new_path": "test/validation.js",
"old_path": "test/validation.js"
}
] |
JavaScript
|
MIT License
|
yargs/yargs
|
fix: 'undefined' should be taken to mean no argument was provided (#1015)
| 1
|
fix
| null |
791,690
|
18.12.2017 11:10:11
| 28,800
|
47122260b285c24b7a369b7e09cede02183bae28
|
core(estimated-input-latency): remove target reference
fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -25,8 +25,8 @@ class EstimatedInputLatency extends Audit {\nhelpText: 'The score above is an estimate of how long your app takes to respond to user ' +\n'input, in milliseconds. There is a 90% probability that a user encounters this amount ' +\n'of latency, or less. 10% of the time a user can expect additional latency. If your ' +\n- 'score is higher than Lighthouse\\'s target score, users may perceive your app as ' +\n- 'laggy. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/estimated-input-latency).',\n+ 'latency is higher than 50 ms, users may perceive your app as laggy. ' +\n+ '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/estimated-input-latency).',\nscoringMode: Audit.SCORING_MODES.NUMERIC,\nrequiredArtifacts: ['traces'],\n};\n",
"new_path": "lighthouse-core/audits/estimated-input-latency.js",
"old_path": "lighthouse-core/audits/estimated-input-latency.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(estimated-input-latency): remove target reference (#4069)
fixes #4061
| 1
|
core
|
estimated-input-latency
|
791,690
|
18.12.2017 11:13:01
| 28,800
|
3f9d94c634c89805c980b02f74af8f893cae8219
|
core(gather-runner): covert assertPageLoaded into soft failure
|
[
{
"change_type": "MODIFY",
"diff": "@@ -138,14 +138,12 @@ class GatherRunner {\n}\n/**\n- * Throws an error if the original network request failed or wasn't found.\n+ * Returns an error if the original network request failed or wasn't found.\n* @param {string} url The URL of the original requested page.\n- * @param {{online: boolean}} driver\n* @param {!Array<WebInspector.NetworkRequest>} networkRecords\n+ * @return {?Error}\n*/\n- static assertPageLoaded(url, driver, networkRecords) {\n- if (!driver.online) return;\n-\n+ static getPageLoadError(url, networkRecords) {\nconst mainRecord = networkRecords.find(record => {\n// record.url is actual request url, so needs to be compared without any URL fragment.\nreturn URL.equalWithExcludedFragments(record.url, url);\n@@ -162,7 +160,7 @@ class GatherRunner {\nlog.error('GatherRunner', errorMessage, url);\nconst error = new Error(`Unable to load page: ${errorMessage}`);\nerror.code = 'PAGE_LOAD_ERROR';\n- throw error;\n+ return error;\n}\n}\n@@ -265,6 +263,7 @@ class GatherRunner {\nconst passData = {};\nlet pass = Promise.resolve();\n+ let pageLoadError;\nif (config.recordTrace) {\npass = pass.then(_ => {\n@@ -285,9 +284,18 @@ class GatherRunner {\nlog.log('status', status);\nconst devtoolsLog = driver.endDevtoolsLog();\nconst networkRecords = NetworkRecorder.recordsFromLogs(devtoolsLog);\n- GatherRunner.assertPageLoaded(options.url, driver, networkRecords);\nlog.verbose('statusEnd', status);\n+ pageLoadError = GatherRunner.getPageLoadError(options.url, networkRecords);\n+ // If the driver was offline, a page load error is expected, so do not save it.\n+ if (!driver.online) pageLoadError = null;\n+\n+ if (pageLoadError) {\n+ gathererResults.LighthouseRunWarnings.push('Lighthouse was unable to reliably load the ' +\n+ 'page you requested. Make sure you are testing the correct URL and that the server is ' +\n+ 'properly responding to all requests.');\n+ }\n+\n// Expose devtoolsLog and networkRecords to gatherers\npassData.devtoolsLog = devtoolsLog;\npassData.networkRecords = networkRecords;\n@@ -300,7 +308,9 @@ class GatherRunner {\nconst status = `Retrieving: ${gatherer.name}`;\nreturn chain.then(_ => {\nlog.log('status', status);\n- const artifactPromise = Promise.resolve().then(_ => gatherer.afterPass(options, passData));\n+ const artifactPromise = pageLoadError ?\n+ Promise.reject(pageLoadError) :\n+ Promise.resolve().then(_ => gatherer.afterPass(options, passData));\ngathererResults[gatherer.name].push(artifactPromise);\nreturn GatherRunner.recoverOrThrow(artifactPromise);\n}).then(_ => {\n@@ -324,8 +334,10 @@ class GatherRunner {\nconst artifacts = {};\n// Nest LighthouseRunWarnings, if any, so they will be collected into artifact.\n- gathererResults.LighthouseRunWarnings = [gathererResults.LighthouseRunWarnings];\n+ const uniqueWarnings = Array.from(new Set(gathererResults.LighthouseRunWarnings));\n+ gathererResults.LighthouseRunWarnings = [uniqueWarnings];\n+ const pageLoadFailures = [];\nreturn Object.keys(gathererResults).reduce((chain, gathererName) => {\nreturn chain.then(_ => {\nconst phaseResultsPromises = gathererResults[gathererName];\n@@ -341,9 +353,16 @@ class GatherRunner {\n// To reach this point, all errors are non-fatal, so return err to\n// runner to handle turning it into an error audit.\nartifacts[gathererName] = err;\n+ // Track page load errors separately, so we can fail loudly if needed.\n+ if (err.code === 'PAGE_LOAD_ERROR') pageLoadFailures.push(err);\n});\n});\n}, Promise.resolve()).then(_ => {\n+ // Fail the run if more than 50% of all artifacts failed due to page load failure.\n+ if (pageLoadFailures.length > Object.keys(artifacts).length * .5) {\n+ throw pageLoadFailures[0];\n+ }\n+\nreturn artifacts;\n});\n}\n",
"new_path": "lighthouse-core/gather/gather-runner.js",
"old_path": "lighthouse-core/gather/gather-runner.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -621,33 +621,31 @@ describe('GatherRunner', function() {\n/afterPass\\(\\) method/);\n});\n- describe('#assertPageLoaded', () => {\n+ describe('#getPageLoadError', () => {\nit('passes when the page is loaded', () => {\nconst url = 'http://the-page.com';\nconst records = [{url}];\n- GatherRunner.assertPageLoaded(url, {online: true}, records);\n+ assert.ok(!GatherRunner.getPageLoadError(url, records));\n});\nit('passes when the page is loaded, ignoring any fragment', () => {\nconst url = 'http://example.com/#/page/list';\nconst records = [{url: 'http://example.com'}];\n- GatherRunner.assertPageLoaded(url, {online: true}, records);\n+ assert.ok(!GatherRunner.getPageLoadError(url, records));\n});\nit('throws when page fails to load', () => {\nconst url = 'http://the-page.com';\nconst records = [{url, failed: true, localizedFailDescription: 'foobar'}];\n- assert.throws(() => {\n- GatherRunner.assertPageLoaded(url, {online: true}, records);\n- }, /Unable.*foobar/);\n+ const error = GatherRunner.getPageLoadError(url, records);\n+ assert.ok(error && /Unable.*foobar/.test(error.message));\n});\nit('throws when page times out', () => {\nconst url = 'http://the-page.com';\nconst records = [];\n- assert.throws(() => {\n- GatherRunner.assertPageLoaded(url, {online: true}, records);\n- }, /Unable.*no document request/);\n+ const error = GatherRunner.getPageLoadError(url, records);\n+ assert.ok(error && /Unable.*no document request/.test(error.message));\n});\n});\n@@ -901,12 +899,9 @@ describe('GatherRunner', function() {\nurl,\nflags: {},\nconfig: new Config({}),\n- })\n- .then(_ => {\n- assert.ok(false);\n- }, error => {\n- assert.ok(true);\n- assert.ok(/net::ERR_NAME_NOT_RESOLVED/.test(error.message));\n+ }).then(artifacts => {\n+ assert.equal(artifacts.LighthouseRunWarnings.length, 1);\n+ assert.ok(/unable.*load the page/.test(artifacts.LighthouseRunWarnings[0]));\n});\n});\n",
"new_path": "lighthouse-core/test/gather/gather-runner-test.js",
"old_path": "lighthouse-core/test/gather/gather-runner-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(gather-runner): covert assertPageLoaded into soft failure (#4048)
| 1
|
core
|
gather-runner
|
791,699
|
18.12.2017 11:18:02
| 28,800
|
48a129fbb6286846625c10a100f4065070688a47
|
core: upstream patches from downstream consumer
|
[
{
"change_type": "MODIFY",
"diff": "@@ -58,7 +58,9 @@ class ResponseCompression extends Gatherer {\nconst driver = options.driver;\nreturn Promise.all(textRecords.map(record => {\n- return driver.getRequestContent(record.requestId).then(content => {\n+ const contentPromise = driver.getRequestContent(record.requestId);\n+ const timeoutPromise = new Promise(resolve => setTimeout(resolve, 3000));\n+ return Promise.race([contentPromise, timeoutPromise]).then(content => {\n// if we don't have any content gzipSize is set to 0\nif (!content) {\nrecord.gzipSize = 0;\n",
"new_path": "lighthouse-core/gather/gatherers/dobetterweb/response-compression.js",
"old_path": "lighthouse-core/gather/gatherers/dobetterweb/response-compression.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -25,7 +25,9 @@ class Manifest extends Gatherer {\n* @return {!Promise<?Manifest>}\n*/\nafterPass(options) {\n- return options.driver.getAppManifest()\n+ const manifestPromise = options.driver.getAppManifest();\n+ const timeoutPromise = new Promise(resolve => setTimeout(resolve, 3000));\n+ return Promise.race([manifestPromise, timeoutPromise])\n.then(response => {\nif (!response) {\nreturn null;\n",
"new_path": "lighthouse-core/gather/gatherers/manifest.js",
"old_path": "lighthouse-core/gather/gatherers/manifest.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -95,6 +95,7 @@ function prepareAssets(artifacts, audits) {\n}\nassets.push({\n+ passName,\ntraceData,\ndevtoolsLog,\nscreenshotsHTML,\n@@ -198,9 +199,30 @@ function saveAssets(artifacts, audits, pathWithBasename) {\n});\n}\n+/**\n+ * Log trace(s) and associated screenshot(s) to console.\n+ * @param {!Artifacts} artifacts\n+ * @param {!Audits} audits\n+ * @return {!Promise}\n+ */\n+function logAssets(artifacts, audits) {\n+ return prepareAssets(artifacts, audits).then(assets => {\n+ assets.map(data => {\n+ log.log('devtoolslog-${data.passName}.json', data.devtoolsLog);\n+ const traceIter = traceJsonGenerator(data.traceData);\n+ let traceJson = '';\n+ for (const trace of traceIter) {\n+ traceJson += trace;\n+ }\n+ log.log('trace-${data.passName}.json', traceJson);\n+ });\n+ });\n+}\n+\nmodule.exports = {\nsaveArtifacts,\nsaveAssets,\nprepareAssets,\nsaveTrace,\n+ logAssets,\n};\n",
"new_path": "lighthouse-core/lib/asset-saver.js",
"old_path": "lighthouse-core/lib/asset-saver.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -10,7 +10,9 @@ const RawProtocol = require('../../../lighthouse-core/gather/connections/raw');\nconst Runner = require('../../../lighthouse-core/runner');\nconst Config = require('../../../lighthouse-core/config/config');\nconst defaultConfig = require('../../../lighthouse-core/config/default.js');\n+const fastConfig = require('../../../lighthouse-core/config/fast-config.js');\nconst log = require('lighthouse-logger');\n+const assetSaver = require('../../../lighthouse-core/lib/asset-saver.js');\nconst ReportGeneratorV2 = require('../../../lighthouse-core/report/v2/report-generator');\n@@ -88,7 +90,7 @@ function filterOutArtifacts(result) {\n* @return {!Promise}\n*/\nwindow.runLighthouseForConnection = function(connection, url, options, categoryIDs) {\n- const config = new Config({\n+ const config = options && options.fastMode ? new Config(fastConfig) : new Config({\nextends: 'lighthouse:default',\nsettings: {onlyCategories: categoryIDs},\n});\n@@ -138,6 +140,34 @@ window.runLighthouseInExtension = function(options, categoryIDs) {\n});\n};\n+/**\n+ * Run lighthouse for connection and provide similar results as in CLI.\n+ * @param {!Connection} connection\n+ * @param {string} url\n+ * @param {!Object} options Lighthouse options.\n+ Specify lightriderFormat to change the output format.\n+ * @param {!Array<string>} categoryIDs Name values of categories to include.\n+ * @return {!Promise}\n+ */\n+window.runLighthouseAsInCLI = function(connection, url, options, categoryIDs) {\n+ log.setLevel('info');\n+ const startTime = Date.now();\n+ return window.runLighthouseForConnection(connection, url, options, categoryIDs)\n+ .then(results => {\n+ const endTime = Date.now();\n+ results.timing = {total: endTime - startTime};\n+ let promise = Promise.resolve();\n+ if (options && options.logAssets) {\n+ promise = promise.then(_ => assetSaver.logAssets(results.artifacts, results.audits));\n+ }\n+ filterOutArtifacts(results);\n+ return promise.then( _ => {\n+ const json = options && options.outputFormat === 'json';\n+ return json ? JSON.stringify(results) : new ReportGeneratorV2().generateReportHtml(results);\n+ });\n+ });\n+};\n+\n/**\n* @param {!RawProtocol.Port} port\n* @param {string} url\n",
"new_path": "lighthouse-extension/app/src/lighthouse-background.js",
"old_path": "lighthouse-extension/app/src/lighthouse-background.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -119,7 +119,6 @@ gulp.task('browserify-lighthouse', () => {\n// Do the additional transform to convert references of devtools-timeline-model\n// to the modified version internal to Lighthouse.\nbundle.transform('./dtm-transform.js', {global: true})\n- .ignore('../lighthouse-core/lib/asset-saver.js') // relative from gulpfile location\n.ignore('source-map')\n.ignore('whatwg-url')\n.ignore('url')\n",
"new_path": "lighthouse-extension/gulpfile.js",
"old_path": "lighthouse-extension/gulpfile.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core: upstream patches from downstream consumer
| 1
|
core
| null |
815,745
|
18.12.2017 14:07:13
| -7,200
|
4cbeb60c603ca6a408c56f66df89709befca182b
|
chore(release): 0.13.0
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.13.0\"></a>\n+# [0.13.0](https://github.com/ng-select/ng-select/compare/v0.12.0...v0.13.0) (2017-12-18)\n+\n+\n+### Bug Fixes\n+\n+* separate extraneous properties with object values closes [#165](https://github.com/ng-select/ng-select/issues/165) ([ff8981c](https://github.com/ng-select/ng-select/commit/ff8981c))\n+\n+\n+### Features\n+\n+* **bindLabel:** support nested expression closes [#159](https://github.com/ng-select/ng-select/issues/159) ([b803744](https://github.com/ng-select/ng-select/commit/b803744))\n+\n+\n+\n<a name=\"0.12.0\"></a>\n# [0.12.0](https://github.com/ng-select/ng-select/compare/v0.11.0...v0.12.0) (2017-12-05)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.12.0\",\n+ \"version\": \"0.13.0\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.13.0
| 1
|
chore
|
release
|
791,690
|
18.12.2017 16:32:06
| 28,800
|
9fa36ceaf25b972311cbc335dd39de15d215ba43
|
deps: bump js-library-detector
|
[
{
"change_type": "MODIFY",
"diff": "\"http-link-header\": \"^0.8.0\",\n\"inquirer\": \"^3.3.0\",\n\"jpeg-js\": \"0.1.2\",\n- \"js-library-detector\": \"^4.0.0\",\n+ \"js-library-detector\": \"^4.3.1\",\n\"json-stringify-safe\": \"5.0.1\",\n\"lighthouse-logger\": \"^1.0.0\",\n\"metaviewport-parser\": \"0.1.0\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -2375,9 +2375,9 @@ jpeg-js@0.1.2, jpeg-js@^0.1.2:\nversion \"0.1.2\"\nresolved \"https://registry.yarnpkg.com/jpeg-js/-/jpeg-js-0.1.2.tgz#135b992c0575c985cfa0f494a3227ed238583ece\"\n-js-library-detector@^4.0.0:\n- version \"4.0.0\"\n- resolved \"https://registry.yarnpkg.com/js-library-detector/-/js-library-detector-4.0.0.tgz#7ebb02ae20f97ad61e4527b97011c409aec318ba\"\n+js-library-detector@^4.3.1:\n+ version \"4.3.1\"\n+ resolved \"https://registry.yarnpkg.com/js-library-detector/-/js-library-detector-4.3.1.tgz#6d34f55002813bc0a7543deef53faa4e2e79767b\"\njs-tokens@^1.0.1:\nversion \"1.0.3\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
deps: bump js-library-detector (#4086)
| 1
|
deps
| null |
791,723
|
19.12.2017 15:21:47
| 28,800
|
485e48556a2b3e98af33701e6468a73d4b256d2f
|
misc(viewer): retain /plots/ when deploying new viewer version
|
[
{
"change_type": "MODIFY",
"diff": "@@ -173,6 +173,7 @@ gulp.task('create-dir-for-gh-pages', () => {\ngulp.task('deploy', cb => {\nrunSequence('clean', 'build', 'create-dir-for-gh-pages', function() {\nghpages.publish(`dist/viewer`, {\n+ add: true, // keep existing files (like `./plots/`)\nlogger: $.util.log,\n}, err => {\nif (err) {\n",
"new_path": "lighthouse-viewer/gulpfile.js",
"old_path": "lighthouse-viewer/gulpfile.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
misc(viewer): retain /plots/ when deploying new viewer version (#4079)
| 1
|
misc
|
viewer
|
791,723
|
19.12.2017 16:46:59
| 28,800
|
c206e0a5a8852bd337253f5b4870458eb05e8ec3
|
report(categories): performance first, then pwa, then the others
|
[
{
"change_type": "MODIFY",
"diff": "@@ -221,7 +221,7 @@ module.exports = {\ndescription: 'These items address areas which an automated testing tool cannot cover. Learn more in our guide on [conducting an accessibility review](https://developers.google.com/web/fundamentals/accessibility/how-to-review).',\n},\n'manual-pwa-checks': {\n- title: 'Manual checks to verify',\n+ title: 'Additional items to manually check',\ndescription: 'These checks are required by the baseline ' +\n'[PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are ' +\n'not automatically checked by Lighthouse. They do not affect your score but it\\'s important that you verify them manually.',\n@@ -241,27 +241,6 @@ module.exports = {\n},\n},\ncategories: {\n- 'pwa': {\n- name: 'Progressive Web App',\n- weight: 1,\n- description: 'These checks validate the aspects of a Progressive Web App, as specified by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist).',\n- audits: [\n- {id: 'service-worker', weight: 1},\n- {id: 'works-offline', weight: 1},\n- {id: 'without-javascript', weight: 1},\n- {id: 'is-on-https', weight: 1},\n- {id: 'redirects-http', weight: 1},\n- {id: 'load-fast-enough-for-pwa', weight: 1},\n- {id: 'webapp-install-banner', weight: 1},\n- {id: 'splash-screen', weight: 1},\n- {id: 'themed-omnibox', weight: 1},\n- {id: 'viewport', weight: 1},\n- {id: 'content-width', weight: 1},\n- {id: 'pwa-cross-browser', weight: 0, group: 'manual-pwa-checks'},\n- {id: 'pwa-page-transitions', weight: 0, group: 'manual-pwa-checks'},\n- {id: 'pwa-each-page-has-url', weight: 0, group: 'manual-pwa-checks'},\n- ],\n- },\n'performance': {\nname: 'Performance',\ndescription: 'These encapsulate your app\\'s current performance and opportunities to improve it.',\n@@ -290,6 +269,27 @@ module.exports = {\n{id: 'mainthread-work-breakdown', weight: 0, group: 'perf-info'},\n],\n},\n+ 'pwa': {\n+ name: 'Progressive Web App',\n+ weight: 1,\n+ description: 'These checks validate the aspects of a Progressive Web App, as specified by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist).',\n+ audits: [\n+ {id: 'service-worker', weight: 1},\n+ {id: 'works-offline', weight: 1},\n+ {id: 'without-javascript', weight: 1},\n+ {id: 'is-on-https', weight: 1},\n+ {id: 'redirects-http', weight: 1},\n+ {id: 'load-fast-enough-for-pwa', weight: 1},\n+ {id: 'webapp-install-banner', weight: 1},\n+ {id: 'splash-screen', weight: 1},\n+ {id: 'themed-omnibox', weight: 1},\n+ {id: 'viewport', weight: 1},\n+ {id: 'content-width', weight: 1},\n+ {id: 'pwa-cross-browser', weight: 0, group: 'manual-pwa-checks'},\n+ {id: 'pwa-page-transitions', weight: 0, group: 'manual-pwa-checks'},\n+ {id: 'pwa-each-page-has-url', weight: 0, group: 'manual-pwa-checks'},\n+ ],\n+ },\n'accessibility': {\nname: 'Accessibility',\ndescription: 'These checks highlight opportunities to [improve the accessibility of your app](https://developers.google.com/web/fundamentals/accessibility). Only a subset of accessibility issues can be automatically detected so manual testing is also encouraged.',\n",
"new_path": "lighthouse-core/config/default.js",
"old_path": "lighthouse-core/config/default.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
report(categories): performance first, then pwa, then the others (#4095)
| 1
|
report
|
categories
|
791,699
|
20.12.2017 04:03:58
| -39,600
|
6ca5ef206ecee6b3f0eca95f5a9dd19eb06bd5af
|
core(asset-saver): minor fix for logAssets
|
[
{
"change_type": "MODIFY",
"diff": "@@ -208,13 +208,13 @@ function saveAssets(artifacts, audits, pathWithBasename) {\nfunction logAssets(artifacts, audits) {\nreturn prepareAssets(artifacts, audits).then(assets => {\nassets.map(data => {\n- log.log('devtoolslog-${data.passName}.json', data.devtoolsLog);\n+ log.log(`devtoolslog-${data.passName}.json`, data.devtoolsLog);\nconst traceIter = traceJsonGenerator(data.traceData);\nlet traceJson = '';\nfor (const trace of traceIter) {\ntraceJson += trace;\n}\n- log.log('trace-${data.passName}.json', traceJson);\n+ log.log(`trace-${data.passName}.json`, traceJson);\n});\n});\n}\n",
"new_path": "lighthouse-core/lib/asset-saver.js",
"old_path": "lighthouse-core/lib/asset-saver.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -160,8 +160,8 @@ window.runLighthouseAsInCLI = function(connection, url, options, categoryIDs) {\nif (options && options.logAssets) {\npromise = promise.then(_ => assetSaver.logAssets(results.artifacts, results.audits));\n}\n- filterOutArtifacts(results);\nreturn promise.then( _ => {\n+ filterOutArtifacts(results);\nconst json = options && options.outputFormat === 'json';\nreturn json ? JSON.stringify(results) : new ReportGeneratorV2().generateReportHtml(results);\n});\n",
"new_path": "lighthouse-extension/app/src/lighthouse-background.js",
"old_path": "lighthouse-extension/app/src/lighthouse-background.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(asset-saver): minor fix for logAssets (#4088)
| 1
|
core
|
asset-saver
|
815,746
|
20.12.2017 18:32:25
| -7,200
|
716ae57998abdb6fdb60e2a3462fe469b3ab160a
|
chore(release): 0.14.0
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.14.0\"></a>\n+# [0.14.0](https://github.com/ng-select/ng-select/compare/v0.13.0...v0.14.0) (2017-12-20)\n+\n+\n+### Features\n+\n+* allow append dropdown to element like body ([#170](https://github.com/ng-select/ng-select/issues/170)) ([d50552f](https://github.com/ng-select/ng-select/commit/d50552f))\n+\n+\n+\n<a name=\"0.13.0\"></a>\n# [0.13.0](https://github.com/ng-select/ng-select/compare/v0.12.0...v0.13.0) (2017-12-18)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.13.0\",\n+ \"version\": \"0.14.0\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.14.0
| 1
|
chore
|
release
|
815,746
|
20.12.2017 19:14:58
| -7,200
|
ffabe34a5f5c8cd677c0e43131a060b1674ac88e
|
fix: export missing function for aot
fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -6,7 +6,6 @@ node_js:\ncache:\ndirectories:\n- node_modules\n- - integration/node_modules\nos:\n- linux\naddons:\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
},
{
"change_type": "MODIFY",
"diff": "@@ -14,7 +14,7 @@ import {NgSelectModule} from '@ng-select/ng-select';\nCommonModule,\nFormsModule,\nBrowserModule,\n- NgSelectModule\n+ NgSelectModule.forRoot({clearAllText: ''})\n],\nproviders: [],\nbootstrap: [AppComponent]\n",
"new_path": "integration/src/app/app.module.ts",
"old_path": "integration/src/app/app.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -36,7 +36,7 @@ export class NgSelectModule {\n}\n}\n-function provideModule(config: NgSelectConfig) {\n+export function provideModule(config: NgSelectConfig) {\nreturn {\nngModule: NgSelectModule,\nproviders: [\n",
"new_path": "src/ng-select/ng-select.module.ts",
"old_path": "src/ng-select/ng-select.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -23,6 +23,6 @@ export class NgSelectConfig {\ntypeToSearchText?= 'Type to search';\naddTagText?= 'Add item';\nloadingText?= 'Loading...';\n- clearAllText = 'Clear all';\n+ clearAllText? = 'Clear all';\ndisableVirtualScroll?= false;\n}\n",
"new_path": "src/ng-select/ng-select.types.ts",
"old_path": "src/ng-select/ng-select.types.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: export missing function for aot (#171)
fixes https://github.com/ng-select/ng-select/issues/169
| 1
|
fix
| null |
815,746
|
20.12.2017 19:16:11
| -7,200
|
21ac928ecc7b6ca74abf87c402444e902e6d04ba
|
chore(release): 0.14.1
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.14.1\"></a>\n+## [0.14.1](https://github.com/ng-select/ng-select/compare/v0.14.0...v0.14.1) (2017-12-20)\n+\n+\n+### Bug Fixes\n+\n+* export missing function for aot ([#171](https://github.com/ng-select/ng-select/issues/171)) ([ffabe34](https://github.com/ng-select/ng-select/commit/ffabe34))\n+\n+\n+\n<a name=\"0.14.0\"></a>\n# [0.14.0](https://github.com/ng-select/ng-select/compare/v0.13.0...v0.14.0) (2017-12-20)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.14.0\",\n+ \"version\": \"0.14.1\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.14.1
| 1
|
chore
|
release
|
135,497
|
21.12.2017 13:59:14
| 0
|
cdbb085f1d44409b1fb0bb18559793d894f06e64
|
fix: ignore semver commits with chore type
Closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -12,6 +12,7 @@ const WILDCARDS = [\nc\n.split('\\n')\n.shift()\n+ .replace(/^chore(\\([^)]+\\))?:/, '')\n.trim()\n)\n];\n",
"new_path": "@commitlint/core/src/library/is-ignored.js",
"old_path": "@commitlint/core/src/library/is-ignored.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -68,6 +68,13 @@ test('should ignore npm semver commits', t => {\nVERSION_MESSAGES.forEach(message => t.true(isIgnored(message)));\n});\n+test('should ignore npm semver commits with chore', t => {\n+ VERSION_MESSAGES.forEach(message => t.true(isIgnored(`chore: ${message}`)));\n+ VERSION_MESSAGES.forEach(message =>\n+ t.true(isIgnored(`chore(release): ${message}`))\n+ );\n+});\n+\ntest('should ignore npm semver commits with footers', t => {\nAMENDED_VERSION_MESSAGES.forEach(message => t.true(isIgnored(message)));\n});\n",
"new_path": "@commitlint/core/src/library/is-ignored.test.js",
"old_path": "@commitlint/core/src/library/is-ignored.test.js"
}
] |
TypeScript
|
MIT License
|
conventional-changelog/commitlint
|
fix: ignore semver commits with chore type
Closes #198
| 1
|
fix
| null |
448,060
|
22.12.2017 13:29:35
| 28,800
|
62b5526c368f6b52f25ef084cb5a5c4d3c6d7589
|
test: fix jsx consumer in integration tests
|
[
{
"change_type": "MODIFY",
"diff": "@@ -2,7 +2,7 @@ import { NgModule } from '@angular/core';\nimport { FooComponent, BarComponent } from 'sample-custom';\nimport { CoreConsumerModule } from './core-consumer/core-consumer.module';\nimport { CustomConsulerModule } from './custom-consumer/custom-consumer.module';\n-//import { JsxConsumerModule } from './jsx-consumer/jsx-consumer.module';\n+import { JsxConsumerModule } from './jsx-consumer/jsx-consumer.module';\nimport { MaterialConsumerModule } from './material-consumer/material-consumer.module';\nimport { ModuleImportDirective } from './module-imports';\n@@ -10,7 +10,7 @@ import { ModuleImportDirective } from './module-imports';\nimports: [\nCoreConsumerModule,\nCustomConsulerModule,\n- //JsxConsumerModule,\n+ JsxConsumerModule,\nMaterialConsumerModule\n],\ndeclarations: [\n",
"new_path": "integration/consumers/tsc/src/main.ts",
"old_path": "integration/consumers/tsc/src/main.ts"
},
{
"change_type": "MODIFY",
"diff": "\"moduleResolution\": \"node\",\n\"outDir\": \"dist\",\n\"rootDir\": \"src\",\n- \"baseUrl\": \"src\",\n+ \"baseUrl\": \"./\",\n\"lib\": [\n\"es2015\",\n\"dom\"\n],\n\"experimentalDecorators\": true,\n\"paths\": {\n- \"@sample/core\": [ \"../../../samples/core/dist\" ],\n- \"sample-custom\": [ \"../../../samples/custom/dist\" ],\n- \"@sample/jsx\": [ \"../../../samples/jsx/dist\" ],\n- \"@sample/material\": [ \"../../../samples/material/dist\" ]\n+ \"@sample/core\": [ \"../../samples/core/dist\" ],\n+ \"sample-custom\": [ \"../../samples/custom/dist\" ],\n+ \"@sample/jsx\": [ \"../../samples/jsx/dist\" ],\n+ \"@sample/material\": [ \"../../samples/material/dist\" ]\n},\n\"types\": [\n\"jasmine\"\n",
"new_path": "integration/consumers/tsc/tsconfig.json",
"old_path": "integration/consumers/tsc/tsconfig.json"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
test: fix jsx consumer in integration tests
| 1
|
test
| null |
448,091
|
30.12.2017 00:27:00
| 28,800
|
4cfd98d6cd9da7e35fcaea8c555abf9d1f0a3c35
|
fix: supports extracting styles from multiple styleUrls
|
[
{
"change_type": "MODIFY",
"diff": "@@ -79,6 +79,7 @@ export const componentTransformer: ComponentTransformer =\n.filter((node) => node.kind === ts.SyntaxKind.SyntaxList)\n.map((node) => node.getChildren().map(n => n.getText()))\n.reduce((prev, current) => prev.concat(...current), [])\n+ .filter(text => text !== ',')\n.map((url) => url.substring(1, url.length - 1));\nconst stylesheets = styleUrls.map((url: string) => {\n",
"new_path": "src/lib/util/ts-transformers.ts",
"old_path": "src/lib/util/ts-transformers.ts"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
fix: supports extracting styles from multiple styleUrls (#455)
| 1
|
fix
| null |
743,863
|
01.01.2018 13:49:25
| 28,800
|
c8adffbea3a2aa454887d40cb83b1503c6630bad
|
docs: remove left over line talking about git-tap donations
|
[
{
"change_type": "MODIFY",
"diff": "# Yargs\n-_Yargs is developed on evenings and weekends by\n-volunteers. Why not grab them dinner or a drink?_\n-\n[![Build Status][travis-image]][travis-url]\n[![Coverage Status][coveralls-image]][coveralls-url]\n[![NPM version][npm-image]][npm-url]\n",
"new_path": "README.md",
"old_path": "README.md"
}
] |
JavaScript
|
MIT License
|
yargs/yargs
|
docs: remove left over line talking about git-tap donations
| 1
|
docs
| null |
743,863
|
01.01.2018 14:12:30
| 28,800
|
6f4640d3f8152a20b6dfcc3637793b7bb431e9ab
|
chore: docs, clarify test a bit
|
[
{
"change_type": "MODIFY",
"diff": "@@ -1996,23 +1996,6 @@ describe('yargs dsl tests', () => {\nargv.heroes.should.eql(['batman', 'Iron Man'])\n})\n- it('allows using a positional of type string', (done) => {\n- yargs('cmd')\n- .command('cmd deploy <version>', 'a command', (yargs) => {\n- yargs\n- .version(false)\n- .positional('version', {\n- type: 'string'\n- })\n- }).parse('cmd deploy 123e123', (err, argv) => {\n- if (err) {\n- return done(err)\n- }\n- argv.version.should.eql('123e123')\n- return done()\n- })\n- })\n-\nit('allows an implied argument to be specified', (done) => {\nyargs()\n.command('cmd <hero>', 'a command', (yargs) => {\n@@ -2130,5 +2113,23 @@ describe('yargs dsl tests', () => {\n})\n}).to.throw(/\\.positional\\(\\) can only be called/)\n})\n+\n+ // see: https://github.com/yargs/yargs-parser/pull/110\n+ it('does not parse large scientific notation values, when type string', (done) => {\n+ yargs('cmd')\n+ .command('cmd deploy <version>', 'a command', (yargs) => {\n+ yargs\n+ .version(false)\n+ .positional('version', {\n+ type: 'string'\n+ })\n+ }).parse('cmd deploy 123e123', (err, argv) => {\n+ if (err) {\n+ return done(err)\n+ }\n+ argv.version.should.eql('123e123')\n+ return done()\n+ })\n+ })\n})\n})\n",
"new_path": "test/yargs.js",
"old_path": "test/yargs.js"
}
] |
JavaScript
|
MIT License
|
yargs/yargs
|
chore: docs, clarify test a bit
| 1
|
chore
| null |
744,008
|
01.01.2018 23:02:54
| -3,600
|
37915fba0c818d7cb074f72bb82381a0a30e844c
|
test: add failing test for scientific notation
|
[
{
"change_type": "MODIFY",
"diff": "@@ -1996,6 +1996,23 @@ describe('yargs dsl tests', () => {\nargv.heroes.should.eql(['batman', 'Iron Man'])\n})\n+ it('allows using a positional of type string', (done) => {\n+ yargs('cmd')\n+ .command('cmd deploy <version>', 'a command', (yargs) => {\n+ yargs\n+ .version(false)\n+ .positional('version', {\n+ type: 'string'\n+ })\n+ }).parse('cmd deploy 123e123', (err, argv) => {\n+ if (err) {\n+ return done(err)\n+ }\n+ argv.version.should.eql('123e123')\n+ return done()\n+ })\n+ })\n+\nit('allows an implied argument to be specified', (done) => {\nyargs()\n.command('cmd <hero>', 'a command', (yargs) => {\n",
"new_path": "test/yargs.js",
"old_path": "test/yargs.js"
}
] |
JavaScript
|
MIT License
|
yargs/yargs
|
test: add failing test for scientific notation (#1019)
| 1
|
test
| null |
743,976
|
02.01.2018 10:09:39
| -19,080
|
0942a1518aad77656c135439194f8f825bd8b33a
|
chore: use chai 4.x
|
[
{
"change_type": "MODIFY",
"diff": "\"yargs-parser\": \"^8.1.0\"\n},\n\"devDependencies\": {\n- \"chai\": \"^3.4.1\",\n+ \"chai\": \"^4.1.2\",\n\"chalk\": \"^1.1.3\",\n\"coveralls\": \"^2.11.11\",\n\"cpr\": \"^2.0.0\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -5,7 +5,6 @@ const expect = require('chai').expect\nconst checkOutput = require('./helpers/utils').checkOutput\nrequire('chai').should()\n-\nconst noop = () => {}\ndescribe('Command', () => {\n@@ -19,11 +18,11 @@ describe('Command', () => {\n.command('foo <bar> [awesome]', 'my awesome command', yargs => yargs)\nconst command = y.getCommandInstance()\nconst handlers = command.getCommandHandlers()\n- handlers.foo.demanded.should.include({\n+ handlers.foo.demanded.should.deep.include({\ncmd: ['bar'],\nvariadic: false\n})\n- handlers.foo.optional.should.include({\n+ handlers.foo.optional.should.deep.include({\ncmd: ['awesome'],\nvariadic: false\n})\n@@ -94,7 +93,7 @@ describe('Command', () => {\n.command(['foo [awesome]', 'wat <yo>'], 'my awesome command')\nconst command = y.getCommandInstance()\nconst handlers = command.getCommandHandlers()\n- handlers.foo.optional.should.include({\n+ handlers.foo.optional.should.deep.include({\ncmd: ['awesome'],\nvariadic: false\n})\n",
"new_path": "test/command.js",
"old_path": "test/command.js"
}
] |
JavaScript
|
MIT License
|
yargs/yargs
|
chore: use chai 4.x (#1033)
| 1
|
chore
| null |
791,690
|
02.01.2018 13:58:44
| 28,800
|
d7a9f3bc3749fa0c36a59e7212a7ed1cf90d2940
|
core(network-recorder): use findNetworkQuietPeriods for networkIdle
core(network-recorder): use findNetworkQuietPeriods for networkIdle calculations
|
[
{
"change_type": "MODIFY",
"diff": "const Audit = require('./audit');\nconst Util = require('../report/v2/renderer/util.js');\n+const NetworkRecorder = require('../lib/network-recorder');\nconst TracingProcessor = require('../lib/traces/tracing-processor');\n// Parameters (in ms) for log-normal CDF scoring. To see the curve:\n@@ -16,7 +17,6 @@ const SCORING_MEDIAN = 10000;\nconst REQUIRED_QUIET_WINDOW = 5000;\nconst ALLOWED_CONCURRENT_REQUESTS = 2;\n-const IGNORED_NETWORK_SCHEMES = ['data', 'ws'];\n/**\n* @fileoverview This audit identifies the time the page is \"consistently interactive\".\n@@ -49,49 +49,8 @@ class ConsistentlyInteractiveMetric extends Audit {\n*/\nstatic _findNetworkQuietPeriods(networkRecords, traceOfTab) {\nconst traceEndTsInMs = traceOfTab.timestamps.traceEnd / 1000;\n-\n- // First collect the timestamps of when requests start and end\n- const timeBoundaries = [];\n- networkRecords.forEach(record => {\n- const scheme = record.parsedURL && record.parsedURL.scheme;\n- if (IGNORED_NETWORK_SCHEMES.includes(scheme)) {\n- return;\n- }\n-\n- // convert the network record timestamp to ms to line-up with traceOfTab\n- timeBoundaries.push({time: record.startTime * 1000, isStart: true});\n- if (record.finished) {\n- timeBoundaries.push({time: record.endTime * 1000, isStart: false});\n- }\n- });\n-\n- timeBoundaries.sort((a, b) => a.time - b.time);\n-\n- let numInflightRequests = 0;\n- let quietPeriodStart = 0;\n- const quietPeriods = [];\n- timeBoundaries.forEach(boundary => {\n- if (boundary.isStart) {\n- // we've just started a new request. are we exiting a quiet period?\n- if (numInflightRequests === ALLOWED_CONCURRENT_REQUESTS) {\n- quietPeriods.push({start: quietPeriodStart, end: boundary.time});\n- }\n- numInflightRequests++;\n- } else {\n- numInflightRequests--;\n- // we've just completed a request. are we entering a quiet period?\n- if (numInflightRequests === ALLOWED_CONCURRENT_REQUESTS) {\n- quietPeriodStart = boundary.time;\n- }\n- }\n- });\n-\n- // Check if the trace ended in a quiet period\n- if (numInflightRequests <= ALLOWED_CONCURRENT_REQUESTS) {\n- quietPeriods.push({start: quietPeriodStart, end: traceEndTsInMs});\n- }\n-\n- return quietPeriods;\n+ return NetworkRecorder.findNetworkQuietPeriods(networkRecords,\n+ ALLOWED_CONCURRENT_REQUESTS, traceEndTsInMs);\n}\n/**\n",
"new_path": "lighthouse-core/audits/consistently-interactive.js",
"old_path": "lighthouse-core/audits/consistently-interactive.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -10,6 +10,8 @@ const NetworkManager = require('./web-inspector').NetworkManager;\nconst EventEmitter = require('events').EventEmitter;\nconst log = require('lighthouse-logger');\n+const IGNORED_NETWORK_SCHEMES = ['data', 'ws'];\n+\nclass NetworkRecorder extends EventEmitter {\n/**\n* Creates an instance of NetworkRecorder.\n@@ -21,54 +23,115 @@ class NetworkRecorder extends EventEmitter {\nthis._records = recordArray;\nthis.networkManager = NetworkManager.createWithFakeTarget();\n- this.startedRequestCount = 0;\n- this.finishedRequestCount = 0;\n-\n- this.networkManager.addEventListener(this.EventTypes.RequestStarted,\n- this.onRequestStarted.bind(this));\n- this.networkManager.addEventListener(this.EventTypes.RequestFinished,\n- this.onRequestFinished.bind(this));\n+ this.networkManager.addEventListener(\n+ this.EventTypes.RequestStarted,\n+ this.onRequestStarted.bind(this)\n+ );\n+ this.networkManager.addEventListener(\n+ this.EventTypes.RequestFinished,\n+ this.onRequestFinished.bind(this)\n+ );\n}\nget EventTypes() {\nreturn NetworkManager.Events;\n}\n- activeRequestCount() {\n- return this.startedRequestCount - this.finishedRequestCount;\n- }\n-\nisIdle() {\n- return this.activeRequestCount() === 0;\n+ return !!this._getActiveIdlePeriod(0);\n}\nis2Idle() {\n- return this.activeRequestCount() <= 2;\n+ return !!this._getActiveIdlePeriod(2);\n+ }\n+\n+ _getActiveIdlePeriod(allowedRequests) {\n+ const quietPeriods = NetworkRecorder.findNetworkQuietPeriods(this._records, allowedRequests);\n+ return quietPeriods.find(period => !Number.isFinite(period.end));\n+ }\n+\n+ _emitNetworkStatus() {\n+ const zeroQuiet = this._getActiveIdlePeriod(0);\n+ const twoQuiet = this._getActiveIdlePeriod(2);\n+\n+ if (twoQuiet && zeroQuiet) {\n+ log.verbose('NetworkRecorder', 'network fully-quiet');\n+ this.emit('network-2-idle');\n+ this.emit('networkidle');\n+ } else if (twoQuiet && !zeroQuiet) {\n+ log.verbose('NetworkRecorder', 'network semi-quiet');\n+ this.emit('network-2-idle');\n+ this.emit('networkbusy');\n+ } else {\n+ log.verbose('NetworkRecorder', 'network busy');\n+ this.emit('network-2-busy');\n+ this.emit('networkbusy');\n+ }\n}\n/**\n- * Listener for the DevTools SDK NetworkManager's RequestStarted event, which includes both\n- * web socket and normal request creation.\n- * @private\n+ * Finds all time periods where the number of inflight requests is less than or equal to the\n+ * number of allowed concurrent requests.\n+ * @param {!Array<!WebInspector.NetworkRequest>} networkRecords\n+ * @param {number} allowedConcurrentRequests\n+ * @param {number=} endTime\n+ * @return {!Array<{start: number, end: number}>}\n*/\n- onRequestStarted(request) {\n- this.startedRequestCount++;\n- this._records.push(request.data);\n+ static findNetworkQuietPeriods(networkRecords, allowedConcurrentRequests, endTime = Infinity) {\n+ // First collect the timestamps of when requests start and end\n+ let timeBoundaries = [];\n+ networkRecords.forEach(record => {\n+ const scheme = record.parsedURL && record.parsedURL.scheme;\n+ if (IGNORED_NETWORK_SCHEMES.includes(scheme)) {\n+ return;\n+ }\n+\n+ // convert the network record timestamp to ms\n+ timeBoundaries.push({time: record.startTime * 1000, isStart: true});\n+ if (record.finished) {\n+ timeBoundaries.push({time: record.endTime * 1000, isStart: false});\n+ }\n+ });\n- const activeCount = this.activeRequestCount();\n- log.verbose('NetworkRecorder', `Request started. ${activeCount} requests in progress` +\n- ` (${this.startedRequestCount} started and ${this.finishedRequestCount} finished).`);\n+ timeBoundaries = timeBoundaries\n+ .filter(boundary => boundary.time <= endTime)\n+ .sort((a, b) => a.time - b.time);\n- // If only one request in progress, emit event that we've transitioned from\n- // idle to busy.\n- if (activeCount === 1) {\n- this.emit('networkbusy');\n+ let numInflightRequests = 0;\n+ let quietPeriodStart = 0;\n+ const quietPeriods = [];\n+ timeBoundaries.forEach(boundary => {\n+ if (boundary.isStart) {\n+ // we've just started a new request. are we exiting a quiet period?\n+ if (numInflightRequests === allowedConcurrentRequests) {\n+ quietPeriods.push({start: quietPeriodStart, end: boundary.time});\n+ }\n+ numInflightRequests++;\n+ } else {\n+ numInflightRequests--;\n+ // we've just completed a request. are we entering a quiet period?\n+ if (numInflightRequests === allowedConcurrentRequests) {\n+ quietPeriodStart = boundary.time;\n+ }\n+ }\n+ });\n+\n+ // Check we ended in a quiet period\n+ if (numInflightRequests <= allowedConcurrentRequests) {\n+ quietPeriods.push({start: quietPeriodStart, end: endTime});\n}\n- // If exactly three requests in progress, we've transitioned from 2-idle to 2-busy.\n- if (activeCount === 3) {\n- this.emit('network-2-busy');\n+ return quietPeriods;\n}\n+\n+ /**\n+ * Listener for the DevTools SDK NetworkManager's RequestStarted event, which includes both\n+ * web socket and normal request creation.\n+ * @private\n+ */\n+ onRequestStarted(request) {\n+ this._records.push(request.data);\n+ this._emitNetworkStatus();\n}\n/**\n@@ -78,22 +141,8 @@ class NetworkRecorder extends EventEmitter {\n* @private\n*/\nonRequestFinished(request) {\n- this.finishedRequestCount++;\nthis.emit('requestloaded', request.data);\n-\n- const activeCount = this.activeRequestCount();\n- log.verbose('NetworkRecorder', `Request finished. ${activeCount} requests in progress` +\n- ` (${this.startedRequestCount} started and ${this.finishedRequestCount} finished).`);\n-\n- // If no requests in progress, emit event that we've transitioned from busy\n- // to idle.\n- if (this.isIdle()) {\n- this.emit('networkidle');\n- }\n-\n- if (this.is2Idle()) {\n- this.emit('network-2-idle');\n- }\n+ this._emitNetworkStatus();\n}\n// The below methods proxy network data into the DevTools SDK network layer.\n",
"new_path": "lighthouse-core/lib/network-recorder.js",
"old_path": "lighthouse-core/lib/network-recorder.js"
},
{
"change_type": "MODIFY",
"diff": "\"smoke\": \"bash lighthouse-cli/test/smokehouse/run-all-tests.sh\",\n\"coverage\": \"istanbul cover -x \\\"**/third_party/**\\\" _mocha -- $(find */test -name '*-test.js') --timeout 10000 --reporter progress --report lcovonly\",\n\"coveralls\": \"yarn coverage && cat ./coverage/lcov.info | coveralls && ./node_modules/codecov/bin/codecov\",\n+ \"debug\": \"node --inspect-brk ./lighthouse-cli/index.js\",\n\"start\": \"node ./lighthouse-cli/index.js\",\n\"test\": \"yarn lint --quiet && yarn unit && yarn type-check && yarn closure\",\n\"unit-core\": \"bash lighthouse-core/scripts/run-mocha.sh --core\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(network-recorder): use findNetworkQuietPeriods for networkIdle (#4102)
core(network-recorder): use findNetworkQuietPeriods for networkIdle calculations
| 1
|
core
|
network-recorder
|
791,723
|
03.01.2018 12:50:36
| 28,800
|
f6234d0a6d407b8b63f6f199db3bc0ce4fac8ab1
|
core(extension): extract a new ext-bg file, splitting extn/devtools usecases
* core(extension): extract a new ext-bg file, splitting extension/devtools
usecases
* core(extension): update extension metadata for new filename.
|
[
{
"change_type": "MODIFY",
"diff": "@@ -144,7 +144,7 @@ class ExtensionConnection extends Connection {\n}\n/**\n- * Used by lighthouse-background to kick off the run on the current page\n+ * Used by lighthouse-ext-background to kick off the run on the current page\n*/\ngetCurrentTabURL() {\nreturn this._queryCurrentTab().then(tab => {\n",
"new_path": "lighthouse-core/gather/connections/extension.js",
"old_path": "lighthouse-core/gather/connections/extension.js"
},
{
"change_type": "MODIFY",
"diff": "\"background\": {\n\"scripts\": [\n\"scripts/chromereload.js\",\n- \"scripts/lighthouse-background.js\"\n+ \"scripts/lighthouse-ext-background.js\"\n],\n\"persistent\": false\n},\n",
"new_path": "lighthouse-extension/app/manifest.json",
"old_path": "lighthouse-extension/app/manifest.json"
},
{
"change_type": "MODIFY",
"diff": "\"background\": {\n\"scripts\": [\n\"scripts/chromereload.js\",\n- \"scripts/lighthouse-background.js\"\n+ \"scripts/lighthouse-ext-background.js\"\n],\n\"persistent\": false\n},\n",
"new_path": "lighthouse-extension/app/manifest_canary.json",
"old_path": "lighthouse-extension/app/manifest_canary.json"
},
{
"change_type": "MODIFY",
"diff": "*/\n'use strict';\n-const ExtensionProtocol = require('../../../lighthouse-core/gather/connections/extension');\nconst RawProtocol = require('../../../lighthouse-core/gather/connections/raw');\nconst Runner = require('../../../lighthouse-core/runner');\nconst Config = require('../../../lighthouse-core/config/config');\nconst defaultConfig = require('../../../lighthouse-core/config/default.js');\nconst fastConfig = require('../../../lighthouse-core/config/fast-config.js');\nconst log = require('lighthouse-logger');\n-const assetSaver = require('../../../lighthouse-core/lib/asset-saver.js');\n-\n-const ReportGeneratorV2 = require('../../../lighthouse-core/report/v2/report-generator');\n-\n-const STORAGE_KEY = 'lighthouse_audits';\n-const SETTINGS_KEY = 'lighthouse_settings';\n-\n-// let installedExtensions = [];\n-let disableExtensionsDuringRun = false;\n-let lighthouseIsRunning = false;\n-let latestStatusLog = [];\n-\n-// /**\n-// * Enables or disables all other installed chrome extensions. The initial list\n-// * of the user's extension is created when the background page is started.\n-// * @param {!boolean} enable If true, enables all other installed extensions.\n-// * False disables them.\n-// * @param {!Promise}\n-// */\n-// function enableOtherChromeExtensions(enable) {\n-// if (!disableExtensionsDuringRun) {\n-// return Promise.resolve();\n-// }\n-\n-// const str = enable ? 'enabling' : 'disabling';\n-// log.log('Chrome', `${str} ${installedExtensions.length} extensions.`);\n-\n-// return Promise.all(installedExtensions.map(info => {\n-// return new Promise((resolve, reject) => {\n-// chrome.management.setEnabled(info.id, enable, _ => {\n-// if (chrome.runtime.lastError) {\n-// reject(chrome.runtime.lastError);\n-// }\n-// resolve();\n-// });\n-// });\n-// }));\n-// }\n-\n-/**\n- * Sets the extension badge text.\n- * @param {string=} optUrl If present, sets the badge text to \"Testing <url>\".\n- * Otherwise, restore the default badge text.\n- */\n-function updateBadgeUI(optUrl) {\n- if (window.chrome && chrome.runtime) {\n- const manifest = chrome.runtime.getManifest();\n-\n- let title = manifest.browser_action.default_title;\n- let path = manifest.browser_action.default_icon['38'];\n-\n- if (lighthouseIsRunning) {\n- title = `Testing ${optUrl}`;\n- path = 'images/lh_logo_icon_light.png';\n- }\n-\n- chrome.browserAction.setTitle({title});\n- chrome.browserAction.setIcon({path});\n- }\n-}\n-\n-/**\n- * Removes artifacts from the result object for portability\n- * @param {!Object} result Lighthouse results object\n- */\n-function filterOutArtifacts(result) {\n- // strip them out, as the networkRecords artifact has circular structures\n- result.artifacts = undefined;\n-}\n/**\n* @param {!Connection} connection\n@@ -89,7 +19,9 @@ function filterOutArtifacts(result) {\n* @param {!Array<string>} categoryIDs Name values of categories to include.\n* @return {!Promise}\n*/\n-window.runLighthouseForConnection = function(connection, url, options, categoryIDs) {\n+window.runLighthouseForConnection = function(\n+ connection, url, options, categoryIDs,\n+ updateBadgeFn = function() { }) {\nconst config = options && options.fastMode ? new Config(fastConfig) : new Config({\nextends: 'lighthouse:default',\nsettings: {onlyCategories: categoryIDs},\n@@ -97,74 +29,16 @@ window.runLighthouseForConnection = function(connection, url, options, categoryI\n// Add url and config to fresh options object.\nconst runOptions = Object.assign({}, options, {url, config});\n-\n- lighthouseIsRunning = true;\n- updateBadgeUI(url);\n+ updateBadgeFn(url);\nreturn Runner.run(connection, runOptions) // Run Lighthouse.\n.then(result => {\n- lighthouseIsRunning = false;\n- updateBadgeUI();\n+ updateBadgeFn();\nreturn result;\n})\n.catch(err => {\n- lighthouseIsRunning = false;\n- updateBadgeUI();\n- throw err;\n- });\n-};\n-\n-/**\n- * @param {!Object} options Lighthouse options.\n- * @param {!Array<string>} categoryIDs Name values of categories to include.\n- * @return {!Promise}\n- */\n-window.runLighthouseInExtension = function(options, categoryIDs) {\n- // Default to 'info' logging level.\n- log.setLevel('info');\n- const connection = new ExtensionProtocol();\n- // return enableOtherChromeExtensions(false)\n- // .then(_ => connection.getCurrentTabURL())\n- return connection.getCurrentTabURL()\n- .then(url => window.runLighthouseForConnection(connection, url, options, categoryIDs))\n- .then(results => {\n- filterOutArtifacts(results);\n- // return enableOtherChromeExtensions(true).then(_ => {\n- const blobURL = window.createReportPageAsBlob(results, 'extension');\n- chrome.windows.create({url: blobURL});\n- // });\n- }).catch(err => {\n- // return enableOtherChromeExtensions(true).then(_ => {\n+ updateBadgeFn();\nthrow err;\n- // });\n- });\n-};\n-\n-/**\n- * Run lighthouse for connection and provide similar results as in CLI.\n- * @param {!Connection} connection\n- * @param {string} url\n- * @param {!Object} options Lighthouse options.\n- Specify lightriderFormat to change the output format.\n- * @param {!Array<string>} categoryIDs Name values of categories to include.\n- * @return {!Promise}\n- */\n-window.runLighthouseAsInCLI = function(connection, url, options, categoryIDs) {\n- log.setLevel('info');\n- const startTime = Date.now();\n- return window.runLighthouseForConnection(connection, url, options, categoryIDs)\n- .then(results => {\n- const endTime = Date.now();\n- results.timing = {total: endTime - startTime};\n- let promise = Promise.resolve();\n- if (options && options.logAssets) {\n- promise = promise.then(_ => assetSaver.logAssets(results.artifacts, results.audits));\n- }\n- return promise.then( _ => {\n- filterOutArtifacts(results);\n- const json = options && options.outputFormat === 'json';\n- return json ? JSON.stringify(results) : new ReportGeneratorV2().generateReportHtml(results);\n- });\n});\n};\n@@ -182,23 +56,6 @@ window.runLighthouseInWorker = function(port, url, options, categoryIDs) {\nreturn window.runLighthouseForConnection(connection, url, options, categoryIDs);\n};\n-/**\n- * @param {!Object} results Lighthouse results object\n- * @param {!string} reportContext Where the report is going\n- * @return {!string} Blob URL of the report (or error page) HTML\n- */\n-window.createReportPageAsBlob = function(results) {\n- performance.mark('report-start');\n- const html = new ReportGeneratorV2().generateReportHtml(results);\n-\n- const blob = new Blob([html], {type: 'text/html'});\n- const blobURL = window.URL.createObjectURL(blob);\n-\n- performance.mark('report-end');\n- performance.measure('generate report', 'report-start', 'report-end');\n- return blobURL;\n-};\n-\n/**\n* Returns list of top-level categories from the default config.\n* @return {!Array<{name: string, id: string}>}\n@@ -206,97 +63,3 @@ window.createReportPageAsBlob = function(results) {\nwindow.getDefaultCategories = function() {\nreturn Config.getCategories(defaultConfig);\n};\n-\n-/**\n- * Save currently selected set of category categories to local storage.\n- * @param {{selectedCategories: !Array<string>, disableExtensions: boolean}} settings\n- */\n-window.saveSettings = function(settings) {\n- const storage = {\n- [STORAGE_KEY]: {},\n- [SETTINGS_KEY]: {},\n- };\n-\n- // Stash selected categories.\n- window.getDefaultCategories().forEach(category => {\n- storage[STORAGE_KEY][category.id] = settings.selectedCategories.includes(category.id);\n- });\n-\n- // Stash disable extensions setting.\n- disableExtensionsDuringRun = settings.disableExtensions;\n- storage[SETTINGS_KEY].disableExtensions = disableExtensionsDuringRun;\n-\n- // Save object to chrome local storage.\n- chrome.storage.local.set(storage);\n-};\n-\n-/**\n- * Load selected category categories from local storage.\n- * @return {!Promise<{selectedCategories: !Object<boolean>, disableExtensions: boolean}>}\n- */\n-window.loadSettings = function() {\n- return new Promise(resolve => {\n- // Protip: debug what's in storage with:\n- // chrome.storage.local.get(['lighthouse_audits'], console.log)\n- chrome.storage.local.get([STORAGE_KEY, SETTINGS_KEY], result => {\n- // Start with list of all default categories set to true so list is\n- // always up to date.\n- const defaultCategories = {};\n- window.getDefaultCategories().forEach(category => {\n- defaultCategories[category.id] = true;\n- });\n-\n- // Load saved categories and settings, overwriting defaults with any\n- // saved selections.\n- const savedCategories = Object.assign(defaultCategories, result[STORAGE_KEY]);\n-\n- const defaultSettings = {\n- disableExtensions: disableExtensionsDuringRun,\n- };\n- const savedSettings = Object.assign(defaultSettings, result[SETTINGS_KEY]);\n-\n- resolve({\n- selectedCategories: savedCategories,\n- disableExtensions: savedSettings.disableExtensions,\n- });\n- });\n- });\n-};\n-\n-window.listenForStatus = function(callback) {\n- log.events.addListener('status', function(log) {\n- latestStatusLog = log;\n- callback(log);\n- });\n-\n- // Show latest saved status log to give immediate feedback\n- // when reopening the popup message when lighthouse is running\n- if (lighthouseIsRunning && latestStatusLog) {\n- callback(latestStatusLog);\n- }\n-};\n-\n-window.isRunning = function() {\n- return lighthouseIsRunning;\n-};\n-\n-// Run when in extension context, but not in devtools.\n-if (window.chrome && chrome.runtime) {\n- // Get list of installed extensions that are enabled and can be disabled.\n- // Extensions are not allowed to be disabled if they are under an admin policy.\n- // chrome.management.getAll(installs => {\n- // chrome.management.getSelf(lighthouseCrxInfo => {\n- // installedExtensions = installs.filter(info => {\n- // return info.id !== lighthouseCrxInfo.id && info.type === 'extension' &&\n- // info.enabled && info.mayDisable;\n- // });\n- // });\n- // });\n-\n- chrome.runtime.onInstalled.addListener(details => {\n- if (details.previousVersion) {\n- // eslint-disable-next-line no-console\n- console.log('previousVersion', details.previousVersion);\n- }\n- });\n-}\n",
"new_path": "lighthouse-extension/app/src/lighthouse-background.js",
"old_path": "lighthouse-extension/app/src/lighthouse-background.js"
},
{
"change_type": "ADD",
"diff": "+/**\n+ * @license Copyright 2018 Google Inc. All Rights Reserved.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.\n+ */\n+'use strict';\n+\n+require('./lighthouse-background');\n+\n+const ExtensionProtocol = require('../../../lighthouse-core/gather/connections/extension');\n+const log = require('lighthouse-logger');\n+const assetSaver = require('../../../lighthouse-core/lib/asset-saver.js');\n+\n+const ReportGeneratorV2 = require('../../../lighthouse-core/report/v2/report-generator');\n+\n+const STORAGE_KEY = 'lighthouse_audits';\n+const SETTINGS_KEY = 'lighthouse_settings';\n+\n+// let installedExtensions = [];\n+let disableExtensionsDuringRun = false;\n+let lighthouseIsRunning = false;\n+let latestStatusLog = [];\n+\n+// /**\n+// * Enables or disables all other installed chrome extensions. The initial list\n+// * of the user's extension is created when the background page is started.\n+// * @param {!boolean} enable If true, enables all other installed extensions.\n+// * False disables them.\n+// * @param {!Promise}\n+// */\n+// function enableOtherChromeExtensions(enable) {\n+// if (!disableExtensionsDuringRun) {\n+// return Promise.resolve();\n+// }\n+\n+// const str = enable ? 'enabling' : 'disabling';\n+// log.log('Chrome', `${str} ${installedExtensions.length} extensions.`);\n+\n+// return Promise.all(installedExtensions.map(info => {\n+// return new Promise((resolve, reject) => {\n+// chrome.management.setEnabled(info.id, enable, _ => {\n+// if (chrome.runtime.lastError) {\n+// reject(chrome.runtime.lastError);\n+// }\n+// resolve();\n+// });\n+// });\n+// }));\n+// }\n+\n+/**\n+ * Sets the extension badge text.\n+ * @param {string=} optUrl If present, sets the badge text to \"Testing <url>\".\n+ * Otherwise, restore the default badge text.\n+ */\n+function updateBadgeUI(optUrl) {\n+ lighthouseIsRunning = !!optUrl;\n+ if (window.chrome && chrome.runtime) {\n+ const manifest = chrome.runtime.getManifest();\n+\n+ let title = manifest.browser_action.default_title;\n+ let path = manifest.browser_action.default_icon['38'];\n+\n+ if (lighthouseIsRunning) {\n+ title = `Testing ${optUrl}`;\n+ path = 'images/lh_logo_icon_light.png';\n+ }\n+\n+ chrome.browserAction.setTitle({title});\n+ chrome.browserAction.setIcon({path});\n+ }\n+}\n+\n+/**\n+ * Removes artifacts from the result object for portability\n+ * @param {!Object} result Lighthouse results object\n+ */\n+function filterOutArtifacts(result) {\n+ // strip them out, as the networkRecords artifact has circular structures\n+ result.artifacts = undefined;\n+}\n+\n+/**\n+ * @param {!Object} options Lighthouse options.\n+ * @param {!Array<string>} categoryIDs Name values of categories to include.\n+ * @return {!Promise}\n+ */\n+window.runLighthouseInExtension = function(options, categoryIDs) {\n+ // Default to 'info' logging level.\n+ log.setLevel('info');\n+ const connection = new ExtensionProtocol();\n+ // return enableOtherChromeExtensions(false)\n+ // .then(_ => connection.getCurrentTabURL())\n+ return connection.getCurrentTabURL()\n+ .then(url => window.runLighthouseForConnection(connection, url, options,\n+ categoryIDs, updateBadgeUI))\n+ .then(results => {\n+ filterOutArtifacts(results);\n+ // return enableOtherChromeExtensions(true).then(_ => {\n+ const blobURL = window.createReportPageAsBlob(results, 'extension');\n+ chrome.windows.create({url: blobURL});\n+ // });\n+ }).catch(err => {\n+ // return enableOtherChromeExtensions(true).then(_ => {\n+ throw err;\n+ // });\n+ });\n+};\n+\n+/**\n+ * Run lighthouse for connection and provide similar results as in CLI.\n+ * @param {!Connection} connection\n+ * @param {string} url\n+ * @param {!Object} options Lighthouse options.\n+ Specify lightriderFormat to change the output format.\n+ * @param {!Array<string>} categoryIDs Name values of categories to include.\n+ * @return {!Promise}\n+ */\n+window.runLighthouseAsInCLI = function(connection, url, options, categoryIDs) {\n+ log.setLevel('info');\n+ const startTime = Date.now();\n+ return window.runLighthouseForConnection(connection, url, options, categoryIDs)\n+ .then(results => {\n+ const endTime = Date.now();\n+ results.timing = {total: endTime - startTime};\n+ let promise = Promise.resolve();\n+ if (options && options.logAssets) {\n+ promise = promise.then(_ => assetSaver.logAssets(results.artifacts, results.audits));\n+ }\n+ return promise.then( _ => {\n+ filterOutArtifacts(results);\n+ const json = options && options.outputFormat === 'json';\n+ return json ? JSON.stringify(results) : new ReportGeneratorV2().generateReportHtml(results);\n+ });\n+ });\n+};\n+\n+\n+/**\n+ * @param {!Object} results Lighthouse results object\n+ * @param {!string} reportContext Where the report is going\n+ * @return {!string} Blob URL of the report (or error page) HTML\n+ */\n+window.createReportPageAsBlob = function(results) {\n+ performance.mark('report-start');\n+ const html = new ReportGeneratorV2().generateReportHtml(results);\n+\n+ const blob = new Blob([html], {type: 'text/html'});\n+ const blobURL = window.URL.createObjectURL(blob);\n+\n+ performance.mark('report-end');\n+ performance.measure('generate report', 'report-start', 'report-end');\n+ return blobURL;\n+};\n+\n+/**\n+ * Save currently selected set of category categories to local storage.\n+ * @param {{selectedCategories: !Array<string>, disableExtensions: boolean}} settings\n+ */\n+window.saveSettings = function(settings) {\n+ const storage = {\n+ [STORAGE_KEY]: {},\n+ [SETTINGS_KEY]: {},\n+ };\n+\n+ // Stash selected categories.\n+ window.getDefaultCategories().forEach(category => {\n+ storage[STORAGE_KEY][category.id] = settings.selectedCategories.includes(category.id);\n+ });\n+\n+ // Stash disable extensions setting.\n+ disableExtensionsDuringRun = settings.disableExtensions;\n+ storage[SETTINGS_KEY].disableExtensions = disableExtensionsDuringRun;\n+\n+ // Save object to chrome local storage.\n+ chrome.storage.local.set(storage);\n+};\n+\n+/**\n+ * Load selected category categories from local storage.\n+ * @return {!Promise<{selectedCategories: !Object<boolean>, disableExtensions: boolean}>}\n+ */\n+window.loadSettings = function() {\n+ return new Promise(resolve => {\n+ // Protip: debug what's in storage with:\n+ // chrome.storage.local.get(['lighthouse_audits'], console.log)\n+ chrome.storage.local.get([STORAGE_KEY, SETTINGS_KEY], result => {\n+ // Start with list of all default categories set to true so list is\n+ // always up to date.\n+ const defaultCategories = {};\n+ window.getDefaultCategories().forEach(category => {\n+ defaultCategories[category.id] = true;\n+ });\n+\n+ // Load saved categories and settings, overwriting defaults with any\n+ // saved selections.\n+ const savedCategories = Object.assign(defaultCategories, result[STORAGE_KEY]);\n+\n+ const defaultSettings = {\n+ disableExtensions: disableExtensionsDuringRun,\n+ };\n+ const savedSettings = Object.assign(defaultSettings, result[SETTINGS_KEY]);\n+\n+ resolve({\n+ selectedCategories: savedCategories,\n+ disableExtensions: savedSettings.disableExtensions,\n+ });\n+ });\n+ });\n+};\n+\n+window.listenForStatus = function(callback) {\n+ log.events.addListener('status', function(log) {\n+ latestStatusLog = log;\n+ callback(log);\n+ });\n+\n+ // Show latest saved status log to give immediate feedback\n+ // when reopening the popup message when lighthouse is running\n+ if (lighthouseIsRunning && latestStatusLog) {\n+ callback(latestStatusLog);\n+ }\n+};\n+\n+window.isRunning = function() {\n+ return lighthouseIsRunning;\n+};\n+\n+// Run when in extension context, but not in devtools.\n+if (window.chrome && chrome.runtime) {\n+ // Get list of installed extensions that are enabled and can be disabled.\n+ // Extensions are not allowed to be disabled if they are under an admin policy.\n+ // chrome.management.getAll(installs => {\n+ // chrome.management.getSelf(lighthouseCrxInfo => {\n+ // installedExtensions = installs.filter(info => {\n+ // return info.id !== lighthouseCrxInfo.id && info.type === 'extension' &&\n+ // info.enabled && info.mayDisable;\n+ // });\n+ // });\n+ // });\n+\n+ chrome.runtime.onInstalled.addListener(details => {\n+ if (details.previousVersion) {\n+ // eslint-disable-next-line no-console\n+ console.log('previousVersion', details.previousVersion);\n+ }\n+ });\n+}\n",
"new_path": "lighthouse-extension/app/src/lighthouse-ext-background.js",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -86,7 +86,7 @@ gulp.task('chromeManifest', () => {\nconst manifestOpts = {\nbuildnumber: false,\nbackground: {\n- target: 'scripts/lighthouse-background.js',\n+ target: 'scripts/lighthouse-ext-background.js',\nexclude: [\n'scripts/chromereload.js',\n],\n@@ -109,6 +109,7 @@ function applyBrowserifyTransforms(bundle) {\ngulp.task('browserify-lighthouse', () => {\nreturn gulp.src([\n'app/src/lighthouse-background.js',\n+ 'app/src/lighthouse-ext-background.js',\n], {read: false})\n.pipe(tap(file => {\nlet bundle = browserify(file.path); // , {debug: true}); // for sourcemaps\n@@ -176,7 +177,9 @@ gulp.task('compilejs', () => {\n// sourceMaps: 'both'\n};\n- return gulp.src(['dist/scripts/lighthouse-background.js'])\n+ return gulp.src([\n+ 'dist/scripts/lighthouse-background.js',\n+ 'dist/scripts/lighthouse-ext-background.js'])\n.pipe(tap(file => {\nconst minified = babel.transform(file.contents.toString(), opts).code;\nfile.contents = new Buffer(minified);\n",
"new_path": "lighthouse-extension/gulpfile.js",
"old_path": "lighthouse-extension/gulpfile.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(extension): extract a new ext-bg file, splitting extn/devtools usecases (#4162)
* core(extension): extract a new ext-bg file, splitting extension/devtools
usecases
* core(extension): update extension metadata for new filename.
| 1
|
core
|
extension
|
743,940
|
03.01.2018 14:26:21
| -28,800
|
331d10305af3991bd225fbd7a1060bf43cff22d3
|
fix: Add `dirname` sanity check on `findUp`
|
[
{
"change_type": "MODIFY",
"diff": "@@ -502,7 +502,7 @@ function Yargs (processArgs, cwd, parentRequire) {\nlet obj = {}\ntry {\nconst pkgJsonPath = findUp.sync('package.json', {\n- cwd: path || require('require-main-filename')(parentRequire || require),\n+ cwd: path || require('path').dirname(require('require-main-filename')(parentRequire || require)),\nnormalize: false\n})\nobj = JSON.parse(fs.readFileSync(pkgJsonPath))\n",
"new_path": "yargs.js",
"old_path": "yargs.js"
}
] |
JavaScript
|
MIT License
|
yargs/yargs
|
fix: Add `dirname` sanity check on `findUp` (#1036)
| 1
|
fix
| null |
791,723
|
03.01.2018 15:17:12
| 28,800
|
29eecce9794c1ffc4a0929a11c584eadb4bec683
|
report: change 'app' => 'web app'
|
[
{
"change_type": "MODIFY",
"diff": "@@ -191,7 +191,7 @@ The groups property controls how to visually group audits within a category. For\ngroups: {\n'perf-metric': {\ntitle: 'Metrics',\n- description: 'These metrics encapsulate your app\\'s performance across a number of dimensions.'\n+ description: 'These metrics encapsulate your web app\\'s performance across a number of dimensions.'\n},\n}\n}\n",
"new_path": "docs/configuration.md",
"old_path": "docs/configuration.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -112,7 +112,7 @@ As an example, here's a trace-only run that's reporting on user timings and crit\n\"categories\": {\n\"performance\": {\n\"name\": \"Performance Metrics\",\n- \"description\": \"These encapsulate your app's performance.\",\n+ \"description\": \"These encapsulate your web app's performance.\",\n\"audits\": [\n{\"id\": \"user-timings\", \"weight\": 1},\n{\"id\": \"critical-request-chains\", \"weight\": 1}\n",
"new_path": "docs/readme.md",
"old_path": "docs/readme.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -176,7 +176,7 @@ module.exports = {\ngroups: {\n'perf-metric': {\ntitle: 'Metrics',\n- description: 'These metrics encapsulate your app\\'s performance across a number of dimensions.',\n+ description: 'These metrics encapsulate your web app\\'s performance across a number of dimensions.',\n},\n'perf-hint': {\ntitle: 'Opportunities',\n@@ -245,7 +245,7 @@ module.exports = {\ncategories: {\n'performance': {\nname: 'Performance',\n- description: 'These encapsulate your app\\'s current performance and opportunities to improve it.',\n+ description: 'These encapsulate your web app\\'s current performance and opportunities to improve it.',\naudits: [\n{id: 'first-meaningful-paint', weight: 5, group: 'perf-metric'},\n{id: 'first-interactive', weight: 5, group: 'perf-metric'},\n@@ -295,7 +295,7 @@ module.exports = {\n},\n'accessibility': {\nname: 'Accessibility',\n- description: 'These checks highlight opportunities to [improve the accessibility of your app](https://developers.google.com/web/fundamentals/accessibility). Only a subset of accessibility issues can be automatically detected so manual testing is also encouraged.',\n+ description: 'These checks highlight opportunities to [improve the accessibility of your web app](https://developers.google.com/web/fundamentals/accessibility). Only a subset of accessibility issues can be automatically detected so manual testing is also encouraged.',\naudits: [\n{id: 'accesskeys', weight: 1, group: 'a11y-correct-attributes'},\n{id: 'aria-allowed-attr', weight: 3, group: 'a11y-aria'},\n",
"new_path": "lighthouse-core/config/default.js",
"old_path": "lighthouse-core/config/default.js"
},
{
"change_type": "MODIFY",
"diff": "\"reportCategories\": [\n{\n\"name\": \"Performance\",\n- \"description\": \"These encapsulate your app's performance.\",\n+ \"description\": \"These encapsulate your web app's performance.\",\n\"audits\": [\n{\n\"id\": \"first-meaningful-paint\",\n\"reportGroups\": {\n\"perf-metric\": {\n\"title\": \"Metrics\",\n- \"description\": \"These metrics encapsulate your app's performance across a number of dimensions.\"\n+ \"description\": \"These metrics encapsulate your web app's performance across a number of dimensions.\"\n},\n\"perf-hint\": {\n\"title\": \"Opportunities\",\n",
"new_path": "lighthouse-core/test/fixtures/dbw_tester-perf-results.json",
"old_path": "lighthouse-core/test/fixtures/dbw_tester-perf-results.json"
},
{
"change_type": "MODIFY",
"diff": "},\n{\n\"name\": \"Performance\",\n- \"description\": \"These encapsulate your app's performance.\",\n+ \"description\": \"These encapsulate your web app's performance.\",\n\"audits\": [\n{\n\"id\": \"first-meaningful-paint\",\n},\n{\n\"name\": \"Accessibility\",\n- \"description\": \"These checks highlight opportunities to [improve the accessibility of your app](https://developers.google.com/web/fundamentals/accessibility).\",\n+ \"description\": \"These checks highlight opportunities to [improve the accessibility of your web app](https://developers.google.com/web/fundamentals/accessibility).\",\n\"audits\": [\n{\n\"id\": \"accesskeys\",\n\"reportGroups\": {\n\"perf-metric\": {\n\"title\": \"Metrics\",\n- \"description\": \"These metrics encapsulate your app's performance across a number of dimensions.\"\n+ \"description\": \"These metrics encapsulate your web app's performance across a number of dimensions.\"\n},\n\"perf-hint\": {\n\"title\": \"Opportunities\",\n",
"new_path": "lighthouse-core/test/results/sample_v2.json",
"old_path": "lighthouse-core/test/results/sample_v2.json"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
report: change 'app' => 'web app'
| 1
|
report
| null |
791,699
|
04.01.2018 03:50:30
| -39,600
|
ca2504e3b97229b4e358c8c7d309de11e8f2cd7c
|
core(trace-of-tab): error when TracingStartedInPage is missing
|
[
{
"change_type": "MODIFY",
"diff": "@@ -51,6 +51,7 @@ class TraceOfTab extends ComputedArtifact {\n// The first TracingStartedInPage in the trace is definitely our renderer thread of interest\n// Beware: the tracingStartedInPage event can appear slightly after a navigationStart\nconst startedInPageEvt = keyEvents.find(e => e.name === 'TracingStartedInPage');\n+ if (!startedInPageEvt) throw new Error('TracingStartedInPage was not found in the trace');\n// Filter to just events matching the frame ID for sanity\nconst frameEvents = keyEvents.filter(e => e.args.frame === startedInPageEvt.args.data.page);\n",
"new_path": "lighthouse-core/gather/computed/trace-of-tab.js",
"old_path": "lighthouse-core/gather/computed/trace-of-tab.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(trace-of-tab): error when TracingStartedInPage is missing (#4164)
| 1
|
core
|
trace-of-tab
|
815,737
|
05.01.2018 09:51:31
| -3,600
|
28d43378faa7dddfc91b9cfba477d7664568732f
|
fix: Styling flaw when using dropdownPosition top
|
[
{
"change_type": "MODIFY",
"diff": "@@ -281,6 +281,14 @@ $color-selected: #f5faff;\nborder-bottom-left-radius: 4px;\nborder-top-color: #e6e6e6;\nmargin-top: -1px;\n+ .ng-select-dropdown {\n+ .ng-option {\n+ &:last-child {\n+ border-bottom-right-radius: 4px;\n+ border-bottom-left-radius: 4px;\n+ }\n+ }\n+ }\n}\n&.top {\n@@ -289,6 +297,14 @@ $color-selected: #f5faff;\nborder-top-left-radius: 4px;\nborder-bottom-color: #e6e6e6;\nmargin-bottom: -1px;\n+ .ng-select-dropdown {\n+ .ng-option {\n+ &:first-child {\n+ border-top-right-radius: 4px;\n+ border-top-left-radius: 4px;\n+ }\n+ }\n+ }\n}\n.ng-select-dropdown {\n@@ -305,10 +321,6 @@ $color-selected: #f5faff;\ncursor: pointer;\ndisplay: block;\npadding: 8px 10px;\n- &:last-child {\n- border-bottom-right-radius: 4px;\n- border-bottom-left-radius: 4px;\n- }\n&.selected {\nbackground-color: $color-selected;\ncolor: #333;\n",
"new_path": "src/ng-select/ng-select.component.scss",
"old_path": "src/ng-select/ng-select.component.scss"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: Styling flaw when using dropdownPosition top (#173)
| 1
|
fix
| null |
791,690
|
05.01.2018 11:15:56
| 28,800
|
b7da166f018455fa276c006d340eb5df8948974e
|
docs(lantern): update accuracy data
|
[
{
"change_type": "MODIFY",
"diff": "@@ -6,44 +6,43 @@ Project Lantern is an ongoing effort to reduce the run time of Lighthouse and im\n## Accuracy\n-All of the following accuracy stats are reported on a set of 1500 URLs sampled from the Alexa top 1000, HTTPArchive dataset, and miscellaneous ad landing pages. Trace and load data were collected for *a single run* in one environment and compared to the trace and load data of *a single run* in a second environment. Some natural variation is expected and is captured by the reference stats in the table below. The most errant 10% of observations were excluded from all comparisons as outliers. For more on the methodology and reasoning, see the [Lantern design doc](https://docs.google.com/a/chromium.org/document/d/1pHEjtQjeycMoFOtheLfFjqzggY8VvNaIRfjC7IgNLq0/edit?usp=sharing).\n+All of the following accuracy stats are reported on a set of 300 URLs sampled from the Alexa top 1000, HTTPArchive dataset, and miscellaneous ad landing pages. Median was collected for *9 runs* in one environment and compared to the median of *9 runs* in a second environment.\nStats were collected using the [trace-evaluation](https://github.com/patrickhulce/lighthouse-trace-evaluations) scripts. Table cells contain [Spearman's rho](https://en.wikipedia.org/wiki/Spearman%27s_rank_correlation_coefficient) and [MAPE](https://en.wikipedia.org/wiki/Mean_absolute_percentage_error) for the respective metric.\n-### Accuracy Stats\n+### Lantern Accuracy Stats\n| Comparison | FCP | FMP | TTI |\n| -- | -- | -- | -- |\n-| Lantern predicting Default LH | .850 : 19.6% | .866 : 21.0% | .907 : 26.9% |\n-| Lantern predicting LH on WPT | .764 : 34.4% | .795 : 32.5% | .879 : 33.1% |\n-| Lantern w/adjusted settings<sup>1</sup> predicting LH on WPT | .769 : 32.9% | .808 : 31.1% | .879 : 32.6% |\n+| Lantern predicting Default LH | .811 : 23.1% | .811 : 23.6% | .869 : 42.5% |\n+| Lantern predicting LH on WPT | .785 : 28.3% | .761 : 33.7% | .854 : 45.4% |\n### Reference Stats\n| Comparison | FCP | FMP | TTI |\n| -- | -- | -- | -- |\n-| Unthrottled LH correlation with Unthrottled LH<sup>2</sup> | .881 : 30.8% | .860 : 30.0% | .845 : 36.5% |\n-| WPT correlation with WPT | .805 : 28.7% | .823 : 30.57% | .795 : 43.7% |\n-| Default LH correlation with LH on WPT<sup>2</sup> | .808 : 30.0% | .818 : 31.3% | .819 : 39.5% |\n-| Unthrottled LH correlation with LH on WPT | .643 : 36.3% | .625 : 40.1% | .731 : 58.4% |\n-\n-<sup>1</sup> 320 ms RTT, 1.3 mbps, 5x CPU\n-\n-<sup>2</sup> Two trace sets were captured several weeks apart, so some site changes may have occurred that skew these stats\n+| Unthrottled LH predicting Default LH | .738 : 27.1% | .694 : 33.8% | .743 : 62.0% |\n+| Unthrottled LH predicting WPT | .691 : 33.8% | .635 : 33.7% | .712 : 66.4% |\n+| Default LH predicting WPT | .855 : 22.3% | .813 : 27.0% | .889 : 32.3% |\n## Conclusions\n### Lantern Accuracy Conclusions\n+We conclude that Lantern is ~6-13% more inaccurate than DevTools throttling. When evaluating rank performance, Lantern achieves correlations within ~.04-.07 of DevTools throttling.\n-* For the single view use case, we conclude that Lantern is roughly as accurate at predicting the rank of a website the next time you visit it as the metrics themselves. That is to say, the average error we observe between a Lantern performance score and a LH on DevTools performance score is within the expectation for standard deviation, which is the highest goal we set out to achieve. As a sanity check, we also see that using the unthrottled metrics to predict throttled performance has a significantly lower correlation than Lantern does.\n-* For the repeat view use case, we require more data to reach a conclusion, but the high correlation of the single view use case suggests the accuracy meets our correlation requirements even if some sites may diverge.\n+* For the single view use case, our original conclusion that Lantern's inaccuracy is roughly equal to the inaccuracy introduced by expected variance seems to hold. The standard deviation of single observations from DevTools throttling is ~9-13%, and given Lantern's much lower variance, single observations from Lantern are not significantly more inaccurate on average than single observations from DevTools throttling.\n+* For the repeat view use case, we can conclude that Lantern is systematically off by ~6-13% more than DevTools throttling.\n### Metric Variability Conclusions\nThe reference stats demonstrate that there is high degree of variability with the user-centric metrics and strengthens the position that every load is just an observation of a point drawn from a distribution and to understand the entire experience, multiple draws must be taken, i.e. multiple runs are needed to have sufficiently small error bounds on the median load experience.\n-## Future Work\n-Conducting this same analysis with a 3/5/9/21 run dataset blocks much of the future work here. Future investments in Lantern accuracy would be ill-spent without this larger dataset to validate their efficacy.\n+The current size of confidence intervals for DevTools throttled performance scores are as follows.\n+\n+* 95% confidence interval for **1-run** of site at median: 50 **+/- 15** = 65-35\n+* 95% confidence interval for **3-runs** of site at median: 50 **+/- 11** = 61-39\n+* 95% confidence interval for **5-runs** of site at median: 50 **+/- 8** = 58-42\n## Links\n+* [Lighthouse Variability and Accuracy Analysis](https://docs.google.com/document/d/1BqtL-nG53rxWOI5RO0pItSRPowZVnYJ_gBEQCJ5EeUE/edit?usp=sharing)\n* [Lantern Deck](https://docs.google.com/presentation/d/1EsuNICCm6uhrR2PLNaI5hNkJ-q-8Mv592kwHmnf4c6U/edit?usp=sharing)\n* [Lantern Design Doc](https://docs.google.com/a/chromium.org/document/d/1pHEjtQjeycMoFOtheLfFjqzggY8VvNaIRfjC7IgNLq0/edit?usp=sharing)\n* [WPT Trace Data Set Half 1](https://drive.google.com/open?id=1Y_duiiJVljzIEaYWEmiTqKQFUBFWbKVZ) (access on request)\n",
"new_path": "docs/lantern.md",
"old_path": "docs/lantern.md"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
docs(lantern): update accuracy data (#4180)
| 1
|
docs
|
lantern
|
791,810
|
05.01.2018 12:36:53
| 28,800
|
8c088a682e06d21b1ab44a8c237e3fe8d3344706
|
report(a11y): Don't count non-applicable a11y audits toward score
|
[
{
"change_type": "MODIFY",
"diff": "@@ -16,7 +16,7 @@ node --trace-warnings lighthouse-cli http://example.com\n## Updating fixture dumps\n`lighthouse-core/test/results/samples_v2.json` is generated from running LH against\n-dbw_tester.html. To update this file, run:\n+dbw_tester.html. To update this file, start a local server on port `8080` and serve the directory `lighthouse-cli/test/fixtures`. Then run:\n```sh\nnpm run start -- --output=json --output-path=lighthouse-core/test/results/sample_v2.json http://localhost:8080/dobetterweb/dbw_tester.html\n",
"new_path": "docs/hacking-tips.md",
"old_path": "docs/hacking-tips.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -51,22 +51,22 @@ module.exports = [\nscore: false,\n},\n'aria-valid-attr': {\n- score: true,\n+ notApplicable: true,\n},\n'aria-allowed-attr': {\n- score: true,\n+ notApplicable: true,\n},\n'color-contrast': {\nscore: true,\n},\n'image-alt': {\n- score: true,\n+ notApplicable: true,\n},\n'label': {\n- score: true,\n+ notApplicable: true,\n},\n'tabindex': {\n- score: true,\n+ notApplicable: true,\n},\n'content-width': {\nscore: true,\n@@ -114,10 +114,10 @@ module.exports = [\nscore: false,\n},\n'aria-valid-attr': {\n- score: true,\n+ notApplicable: true,\n},\n'aria-allowed-attr': {\n- score: true,\n+ notApplicable: true,\n},\n'color-contrast': {\nscore: true,\n@@ -126,10 +126,10 @@ module.exports = [\nscore: false,\n},\n'label': {\n- score: true,\n+ notApplicable: true,\n},\n'tabindex': {\n- score: true,\n+ notApplicable: true,\n},\n'content-width': {\nscore: true,\n",
"new_path": "lighthouse-cli/test/smokehouse/offline-local/offline-expectations.js",
"old_path": "lighthouse-cli/test/smokehouse/offline-local/offline-expectations.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -19,7 +19,19 @@ class AxeAudit extends Audit {\n* @return {!AuditResult}\n*/\nstatic audit(artifacts) {\n- const violations = artifacts.Accessibility.violations;\n+ // Indicate if a test is not applicable.\n+ // This means aXe did not find any nodes which matched these checks.\n+ // Note in Lighthouse we use the phrasing \"Not Applicable\" (aXe uses \"inapplicable\", which sounds weird).\n+ const notApplicables = artifacts.Accessibility.notApplicable || [];\n+ const isNotApplicable = notApplicables.find(result => result.id === this.meta.name);\n+ if (isNotApplicable) {\n+ return {\n+ rawValue: false,\n+ notApplicable: true,\n+ };\n+ }\n+\n+ const violations = artifacts.Accessibility.violations || [];\nconst rule = violations.find(result => result.id === this.meta.name);\nlet nodeDetails = [];\n",
"new_path": "lighthouse-core/audits/accessibility/axe-audit.js",
"old_path": "lighthouse-core/audits/accessibility/axe-audit.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -156,6 +156,7 @@ class Audit {\nscoringMode: audit.meta.scoringMode || Audit.SCORING_MODES.BINARY,\ninformative: audit.meta.informative,\nmanual: audit.meta.manual,\n+ notApplicable: result.notApplicable,\nname: audit.meta.name,\ndescription: auditDescription,\nhelpText: audit.meta.helpText,\n",
"new_path": "lighthouse-core/audits/audit.js",
"old_path": "lighthouse-core/audits/audit.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -43,7 +43,7 @@ function runA11yChecks() {\n}));\n// We only need violations, and circular references are possible outside of violations\n- axeResult = {violations: axeResult.violations};\n+ axeResult = {violations: axeResult.violations, notApplicable: axeResult.inapplicable};\nreturn axeResult;\n});\n",
"new_path": "lighthouse-core/gather/gatherers/accessibility.js",
"old_path": "lighthouse-core/gather/gatherers/accessibility.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -225,19 +225,52 @@ class CategoryRenderer {\nreturn element;\n}\n+ /**\n+ * Find the total number of audits contained within a section.\n+ * Accounts for nested subsections like Accessibility.\n+ * @param {!Array<!Element>} elements\n+ * @return {number}\n+ */\n+ _getTotalAuditsLength(elements) {\n+ // Create a scratch element to append sections to so we can reuse querySelectorAll().\n+ const scratch = this._dom.createElement('div');\n+ elements.forEach(function(element) {\n+ scratch.appendChild(element);\n+ });\n+ const subAudits = scratch.querySelectorAll('.lh-audit');\n+ if (subAudits.length) {\n+ return subAudits.length;\n+ } else {\n+ return elements.length;\n+ }\n+ }\n+\n/**\n* @param {!Array<!Element>} elements\n* @return {!Element}\n*/\n_renderPassedAuditsSection(elements) {\nconst passedElem = this._renderAuditGroup({\n- title: `${elements.length} Passed Audits`,\n+ title: `${this._getTotalAuditsLength(elements)} Passed Audits`,\n}, {expandable: true});\npassedElem.classList.add('lh-passed-audits');\nelements.forEach(elem => passedElem.appendChild(elem));\nreturn passedElem;\n}\n+ /**\n+ * @param {!Array<!Element>} elements\n+ * @return {!Element}\n+ */\n+ _renderNotApplicableAuditsSection(elements) {\n+ const notApplicableElem = this._renderAuditGroup({\n+ title: `${this._getTotalAuditsLength(elements)} Not Applicable Audits`,\n+ }, {expandable: true});\n+ notApplicableElem.classList.add('lh-audit-group--notapplicable');\n+ elements.forEach(elem => notApplicableElem.appendChild(elem));\n+ return notApplicableElem;\n+ }\n+\n/**\n* @param {!Array<!ReportRenderer.AuditJSON>} manualAudits\n* @param {!Object<string, !ReportRenderer.GroupJSON>} groupDefinitions\n@@ -446,12 +479,15 @@ class CategoryRenderer {\nconst nonManualAudits = category.audits.filter(audit => !manualAudits.includes(audit));\nconst auditsGroupedByGroup = /** @type {!Object<string,\n{passed: !Array<!ReportRenderer.AuditJSON>,\n- failed: !Array<!ReportRenderer.AuditJSON>}>} */ ({});\n+ failed: !Array<!ReportRenderer.AuditJSON>,\n+ notApplicable: !Array<!ReportRenderer.AuditJSON>}>} */ ({});\nnonManualAudits.forEach(audit => {\nconst groupId = audit.group;\n- const groups = auditsGroupedByGroup[groupId] || {passed: [], failed: []};\n+ const groups = auditsGroupedByGroup[groupId] || {passed: [], failed: [], notApplicable: []};\n- if (audit.score === 100) {\n+ if (audit.result.notApplicable) {\n+ groups.notApplicable.push(audit);\n+ } else if (audit.score === 100) {\ngroups.passed.push(audit);\n} else {\ngroups.failed.push(audit);\n@@ -461,6 +497,7 @@ class CategoryRenderer {\n});\nconst passedElements = /** @type {!Array<!Element>} */ ([]);\n+ const notApplicableElements = /** @type {!Array<!Element>} */ ([]);\nObject.keys(auditsGroupedByGroup).forEach(groupId => {\nconst group = groupDefinitions[groupId];\nconst groups = auditsGroupedByGroup[groupId];\n@@ -476,13 +513,23 @@ class CategoryRenderer {\ngroups.passed.forEach(item => auditGroupElem.appendChild(this._renderAudit(item)));\npassedElements.push(auditGroupElem);\n}\n- });\n- // don't create a passed section if there are no passed\n- if (!passedElements.length) return element;\n+ if (groups.notApplicable.length) {\n+ const auditGroupElem = this._renderAuditGroup(group, {expandable: true});\n+ groups.notApplicable.forEach(item => auditGroupElem.appendChild(this._renderAudit(item)));\n+ notApplicableElements.push(auditGroupElem);\n+ }\n+ });\n+ if (passedElements.length) {\nconst passedElem = this._renderPassedAuditsSection(passedElements);\nelement.appendChild(passedElem);\n+ }\n+\n+ if (notApplicableElements.length) {\n+ const notApplicableElem = this._renderNotApplicableAuditsSection(notApplicableElements);\n+ element.appendChild(notApplicableElem);\n+ }\n// Render manual audits after passing.\nthis._renderManualAudits(manualAudits, groupDefinitions, element);\n",
"new_path": "lighthouse-core/report/v2/renderer/category-renderer.js",
"old_path": "lighthouse-core/report/v2/renderer/category-renderer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -183,6 +183,7 @@ if (typeof module !== 'undefined' && module.exports) {\n* description: string,\n* informative: boolean,\n* manual: boolean,\n+ * notApplicable: boolean,\n* debugString: string,\n* displayValue: string,\n* helpText: string,\n",
"new_path": "lighthouse-core/report/v2/renderer/report-renderer.js",
"old_path": "lighthouse-core/report/v2/renderer/report-renderer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -43,6 +43,15 @@ class ReportScoring {\nif (typeof result.score === 'boolean') {\nauditScore = result.score ? 100 : 0;\n}\n+ // If a result was not applicable, meaning its checks did not run against anything on\n+ // the page, force it's weight to 0. It will not count during the arithmeticMean() but\n+ // will still be included in the final report json and displayed in the report as\n+ // \"Not Applicable\".\n+ if (result.notApplicable) {\n+ auditScore = 100;\n+ audit.weight = 0;\n+ result.informative = true;\n+ }\nreturn Object.assign({}, audit, {result, score: auditScore});\n});\n",
"new_path": "lighthouse-core/scoring.js",
"old_path": "lighthouse-core/scoring.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -126,6 +126,18 @@ describe('CategoryRenderer', () => {\nassert.ok(!categoryDOM2.querySelector('.lh-audit-group--manual'));\n});\n+ it('renders not applicable audits if the category contains them', () => {\n+ const a11yCategory = sampleResults.reportCategories.find(cat => cat.id === 'accessibility');\n+ const categoryDOM = renderer.render(a11yCategory, sampleResults.reportGroups);\n+ assert.ok(categoryDOM.querySelector('.lh-audit-group--notapplicable .lh-audit-group__summary'));\n+ assert.equal(categoryDOM.querySelectorAll('.lh-score--informative').length, 1,\n+ 'score shows informative and dash icon');\n+\n+ const perfCategory = sampleResults.reportCategories.find(cat => cat.id === 'performance');\n+ const categoryDOM2 = renderer.render(perfCategory, sampleResults.reportGroups);\n+ assert.ok(!categoryDOM2.querySelector('.lh-audit-group--notapplicable'));\n+ });\n+\ndescribe('performance category', () => {\nconst category = sampleResults.reportCategories.find(cat => cat.id === 'performance');\n@@ -245,12 +257,13 @@ describe('CategoryRenderer', () => {\nit('renders the failed audits grouped by group', () => {\nconst categoryDOM = renderer.render(category, sampleResults.reportGroups);\n-\n- const failedAudits = category.audits.filter(audit => audit.score !== 100);\n+ const failedAudits = category.audits.filter(audit => {\n+ return audit.score !== 100 && !audit.result.notApplicable;\n+ });\nconst failedAuditTags = new Set(failedAudits.map(audit => audit.group));\n- const failedAuditGroups = categoryDOM.querySelectorAll('.lh-category > .lh-audit-group');\n- assert.equal(failedAuditGroups.length, failedAuditTags.size+1);\n+ const failedAuditGroups = categoryDOM.querySelectorAll('.lh-category > div.lh-audit-group');\n+ assert.equal(failedAuditGroups.length, failedAuditTags.size);\n});\nit('renders the passed audits grouped by group', () => {\n",
"new_path": "lighthouse-core/test/report/v2/renderer/category-renderer-test.js",
"old_path": "lighthouse-core/test/report/v2/renderer/category-renderer-test.js"
},
{
"change_type": "MODIFY",
"diff": "\"score\": true,\n\"displayValue\": \"\",\n\"rawValue\": true,\n+ \"notApplicable\": true,\n+ \"informative\": true,\n\"extendedInfo\": {},\n\"scoringMode\": \"binary\",\n\"name\": \"accesskeys\",\n",
"new_path": "lighthouse-core/test/results/sample_v2.json",
"old_path": "lighthouse-core/test/results/sample_v2.json"
},
{
"change_type": "MODIFY",
"diff": "\"zone.js\": \"^0.7.3\"\n},\n\"dependencies\": {\n- \"axe-core\": \"2.4.1\",\n+ \"axe-core\": \"2.6.1\",\n\"chrome-devtools-frontend\": \"1.0.422034\",\n\"chrome-launcher\": \"0.8.1\",\n\"configstore\": \"^3.1.1\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -335,9 +335,9 @@ aws4@^1.2.1:\nversion \"1.4.1\"\nresolved \"https://registry.yarnpkg.com/aws4/-/aws4-1.4.1.tgz#fde7d5292466d230e5ee0f4e038d9dfaab08fc61\"\n-axe-core@2.4.1:\n- version \"2.4.1\"\n- resolved \"https://registry.yarnpkg.com/axe-core/-/axe-core-2.4.1.tgz#55b6ceaa847cb1eaef5d559b6c41035dc3e07dbf\"\n+axe-core@2.6.1:\n+ version \"2.6.1\"\n+ resolved \"https://registry.yarnpkg.com/axe-core/-/axe-core-2.6.1.tgz#28772c4f76966d373acda35b9a409299dc00d1b5\"\naxios@0.15.3:\nversion \"0.15.3\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
report(a11y): Don't count non-applicable a11y audits toward score (#4052)
| 1
|
report
|
a11y
|
791,723
|
05.01.2018 13:03:44
| 28,800
|
7fe5031fdfe97955ba52223b438f45f6c77356e7
|
docs(readme): update CLI options, output examples. add GAR/Lifecycle examples
|
[
{
"change_type": "MODIFY",
"diff": "@@ -47,7 +47,6 @@ Logging:\nConfiguration:\n--save-assets Save the trace contents & screenshots to disk [boolean]\n- --save-artifacts Save all gathered artifacts to disk [boolean]\n--list-all-audits Prints a list of all available audits and exits [boolean]\n--list-trace-categories Prints a list of all required trace categories and exits [boolean]\n--additional-trace-categories Additional categories to capture with the trace (comma-delimited).\n@@ -60,14 +59,18 @@ Configuration:\nChromium version 54.0 or later. By default, any detected Chrome Canary or Chrome (stable) will be launched.\n[default: \"\"]\n--perf Use a performance-test-only configuration [boolean]\n- --port The port to use for the debugging protocol. Use 0 for a random port [default: 9222]\n- --hostname The hostname to use for the debugging protocol. [default: localhost]\n+ --port The port to use for the debugging protocol. Use 0 for a random port [default: 0]\n+ --hostname The hostname to use for the debugging protocol. [default: \"localhost\"]\n--max-wait-for-load The timeout (in milliseconds) to wait before the page is considered done loading and the run should continue.\n- WARNING: Very high values can lead to large traces and instability [default: 25000]\n- --enable-error-reporting Enables error reporting (prompts once by default, setting this flag will force error reporting to that state).\n+ WARNING: Very high values can lead to large traces and instability [default: 45000]\n+ --enable-error-reporting Enables error reporting, overriding any saved preference. --no-enable-error-reporting will do the opposite. More:\n+ https://git.io/vFFTO\n+ --gather-mode, -G Collect artifacts from a connected browser and save to disk. If audit-mode is not also enabled, the run will quit\n+ early. [boolean]\n+ --audit-mode, -A Process saved artifacts from disk [boolean]\nOutput:\n- --output Reporter for the results, supports multiple values [choices: \"json\", \"html\", \"domhtml\"] [default: \"html\"]\n+ --output Reporter for the results, supports multiple values [choices: \"json\", \"html\", \"domhtml\"] [default: \"domhtml\"]\n--output-path The file path to output the results. Use 'stdout' to write to stdout.\nIf using JSON output, default is stdout.\nIf using HTML output, default is a file in the working directory with a name based on the test URL and date.\n@@ -94,42 +97,49 @@ Examples:\nlighthouse <url> --quiet --chrome-flags=\"--headless\" Launch Headless Chrome, turn off logging\nFor more information on Lighthouse, see https://developers.google.com/web/tools/lighthouse/.\n-\n-\n```\n##### Output Examples\n-`lighthouse` generates\n-* `./<HOST>_<DATE>.report.html`\n-`lighthouse --output json` generates\n-* json output on `stdout`\n+```sh\n+lighthouse\n+# saves `./<HOST>_<DATE>.report.html`\n+\n+lighthouse --output json\n+# json output sent to stdout\n+\n+lighthouse --output html --output-path ./report.html\n+# saves `./report.html`\n-`lighthouse --output html --output-path ./report.html` generates\n-* `./report.html`\n+# NOTE: specifying an output path with multiple formats ignores your specified extension for *ALL* formats\n+lighthouse --output json --output html --output-path ./myfile.json\n+# saves `./myfile.report.json` and `./myfile.report.html`\n-NOTE: specifying an output path with multiple formats ignores your specified extension for *ALL* formats\n+lighthouse --output json --output html\n+# saves `./<HOST>_<DATE>.report.json` and `./<HOST>_<DATE>.report.html`\n-`lighthouse --output json --output html --output-path ./myfile.json` generates\n-* `./myfile.report.json`\n-* `./myfile.report.html`\n+lighthouse --output-path=~/mydir/foo.out --save-assets\n+# saves `~/mydir/foo.report.html`\n+# saves `~/mydir/foo-0.trace.json` and `~/mydir/foo-0.screenshots.html`\n-`lighthouse --output json --output html` generates\n-* `./<HOST>_<DATE>.report.json`\n-* `./<HOST>_<DATE>.report.html`\n+lighthouse --output-path=./report.json --output json\n+# saves `./report.json`\n+```\n+\n+##### Lifecycle Examples\n+You can run a subset of Lighthouse's lifecycle if desired via the `--gather-mode` (`-G`) and `--audit-mode` (`-A`) CLI flags.\n-`lighthouse --output-path=~/mydir/foo.out --save-assets` generates\n-* `~/mydir/foo.report.html`\n-* `~/mydir/foo-0.trace.json`\n-* `~/mydir/foo-0.screenshots.html`\n+```sh\n+lighthouse -G http://example.com\n+# launches browser, collects artifacts, saves them to disk (in `./latest-run/`) and quits\n-`lighthouse --output-path=./report.json --output json --save-artifacts` generates\n-* `./report.json`\n-* `./report.artifacts.log`\n+lighthouse -A http://example.com\n+# skips browser interaction, loads artifacts from disk (in `./latest-run/`), runs audits on them, generates report\n+\n+lighthouse -GA http://example.com\n+# Normal gather + audit run, but also saves collected artifacts to disk for subsequent -A runs.\n+```\n-`lighthouse --save-artifacts` generates\n-* `./<HOST>_<DATE>.report.html`\n-* `./<HOST>_<DATE>.artifacts.log`\n#### Notes on Error Reporting\n",
"new_path": "readme.md",
"old_path": "readme.md"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
docs(readme): update CLI options, output examples. add GAR/Lifecycle examples (#4185)
| 1
|
docs
|
readme
|
815,745
|
06.01.2018 13:34:44
| -7,200
|
6f245de6af64cf282ad0fac97c848130862dd8c5
|
fix(templates): unselect item using value fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -627,6 +627,23 @@ describe('NgSelectComponent', function () {\n});\n}));\n+ it('should clear item using value', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectBasicTestCmp,\n+ `<ng-select [items]=\"cities\"\n+ bindLabel=\"name\"\n+ [(ngModel)]=\"city\">\n+ </ng-select>`);\n+\n+ selectOption(fixture, KeyCode.ArrowDown, 0);\n+ fixture.detectChanges();\n+ expect(fixture.componentInstance.select.selectedItems.length).toBe(1);\n+\n+ fixture.componentInstance.select.clearItem(fixture.componentInstance.cities[0])\n+ expect(fixture.componentInstance.select.selectedItems.length).toBe(0);\n+ tick();\n+ }));\n+\nit('should display custom dropdown option template', async(() => {\nconst fixture = createTestingModule(\nNgSelectBasicTestCmp,\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -124,7 +124,10 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nprivate disposeDocumentClickListener = () => { };\nprivate disposeDocumentResizeListener = () => { };\n- clearItem = (item) => this.unselect(item);\n+ clearItem = (item) => {\n+ const option = this.itemsList.items.find(x => x.value === item);\n+ this.unselect(option);\n+ };\nget selectedItems(): NgOption[] {\nreturn this.itemsList.value;\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix(templates): unselect item using value fixes #175
| 1
|
fix
|
templates
|
815,745
|
06.01.2018 13:47:21
| -7,200
|
3cf5436dee413744b791b917e76f1190b842aa58
|
chore(release): 0.14.2
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.14.2\"></a>\n+## [0.14.2](https://github.com/ng-select/ng-select/compare/v0.14.1...v0.14.2) (2018-01-06)\n+\n+\n+### Bug Fixes\n+\n+* Styling flaw when using dropdownPosition top ([#173](https://github.com/ng-select/ng-select/issues/173)) ([28d4337](https://github.com/ng-select/ng-select/commit/28d4337))\n+* **templates:** unselect item using value fixes [#175](https://github.com/ng-select/ng-select/issues/175) ([6f245de](https://github.com/ng-select/ng-select/commit/6f245de))\n+\n+\n+\n<a name=\"0.14.1\"></a>\n## [0.14.1](https://github.com/ng-select/ng-select/compare/v0.14.0...v0.14.1) (2017-12-20)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.14.1\",\n+ \"version\": \"0.14.2\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.14.2
| 1
|
chore
|
release
|
791,723
|
08.01.2018 10:06:42
| 28,800
|
daeb239f0bb75722acdebd9ccc356695f14d1b36
|
docs: extract Release Guide into own docs file
|
[
{
"change_type": "MODIFY",
"diff": "@@ -109,104 +109,4 @@ if (networkRecords.length === 1) {\n# For Maintainers\n-## Release guide\n-\n-```sh\n-# * Install the latest. This also builds the cli, extension, and viewer *\n-yarn\n-yarn install-all\n-\n-# * Bump it *\n-yarn version --no-git-tag-version\n-# then manually bump extension v in extension/app/manifest.json\n-\n-# * Build it *\n-yarn build-all\n-\n-# * Test err'thing *\n-echo \"Test the CLI.\"\n-lighthouse --perf \"https://example.com\"\n-yarn smoke\n-\n-echo \"Test the extension\"\n-# ...\n-\n-echo \"Test a fresh local install\"\n-# (starting from lighthouse root...)\n-# npm pack\n-# cd ..; trash tmp; mkdir tmp; cd tmp\n-# npm init -y\n-# npm install ../lighthouse/lighthouse-<version>.tgz\n-# npm explore lighthouse -- npm run smoke\n-# npm explore lighthouse -- npm run smokehouse\n-# npm explore lighthouse -- npm run chrome # try the manual launcher\n-# npm explore lighthouse -- npm run fast -- http://example.com\n-# cd ..; rm -rf ./tmp;\n-\n-echo \"Test the lighthouse-viewer build\"\n-# Manual test for now:\n-# Start a server in lighthouse-viewer/dist/ and open the page in a tab. You should see the viewer.\n-# Drop in a results.json or paste an existing gist url (e.g. https://gist.github.com/ebidel/b9fd478b5f40bf5fab174439dc18f83a).\n-# Check for errors!\n-\n-# * Update changelog *\n-git fetch --tags\n-yarn changelog\n-# add new contributors, e.g. from\n-# git shortlog -s -e -n v2.3.0..HEAD\n-\n-# * Put up the PR *\n-echo \"Branch and commit the version bump.\"\n-git checkout -b bumpv240\n-git commit -am \"2.4.0\"\n-git tag -a v2.4.0 -m \"v2.4.0\"\n-echo \"Generate a PR and get it merged.\"\n-\n-# * Deploy-time *\n-cd lighthouse-extension; gulp package; cd ..\n-echo \"Upload the package zip to CWS dev dashboard\"\n-\n-echo \"Verify the npm package won't include unncessary files\"\n-yarn global add irish-pub pkgfiles\n-irish-pub; pkgfiles;\n-\n-echo \"ship it\"\n-npm publish\n-yarn deploy-viewer\n-\n-echo \"Use the GitHub web interface to tag the release\"\n-echo \"Copy changelog to release notes and update the release page\"\n-\n-# * Tell the world!!! *\n-echo \"Inform various peoples\"\n-```\n-\n-### Canary release\n-\n-```sh\n-# Pull latest in a clean non-dev clone.\n-\n-yarn install-all\n-\n-# Update manifest_canary.json w/ version bumps.\n-\n-# branch and commit\n-git commmit -m \"bump extension canary to 2.0.0.X\"\n-\n-npm version prerelease # this will commit\n-\n-\n-# overwrite extension's manifest w/ manifest_canary.\n-\n-yarn build-all\n-\n-cd lighthouse-extension/\n-gulp package\n-# upload zip to CWS and publish\n-\n-# verify you build-all'd for the typescript compile\n-# ...\n-\n-# publish to canary tag!\n-npm publish --tag canary\n-```\n+The [release guide](./docs/releasing.md).\n",
"new_path": "CONTRIBUTING.md",
"old_path": "CONTRIBUTING.md"
},
{
"change_type": "ADD",
"diff": "+## Release guide for maintainers\n+\n+```sh\n+# * Install the latest. This also builds the cli, extension, and viewer *\n+yarn\n+yarn install-all\n+\n+# * Bump it *\n+yarn version --no-git-tag-version\n+# then manually bump extension v in extension/app/manifest.json\n+\n+# * Build it *\n+yarn build-all\n+\n+# * Test err'thing *\n+echo \"Test the CLI.\"\n+lighthouse --perf \"https://example.com\"\n+yarn smoke\n+\n+echo \"Test the extension\"\n+# ...\n+\n+echo \"Test a fresh local install\"\n+# (starting from lighthouse root...)\n+# npm pack\n+# cd ..; trash tmp; mkdir tmp; cd tmp\n+# npm init -y\n+# npm install ../lighthouse/lighthouse-<version>.tgz\n+# npm explore lighthouse -- npm run smoke\n+# npm explore lighthouse -- npm run smokehouse\n+# npm explore lighthouse -- npm run chrome # try the manual launcher\n+# npm explore lighthouse -- npm run fast -- http://example.com\n+# cd ..; rm -rf ./tmp;\n+\n+echo \"Test the lighthouse-viewer build\"\n+# Manual test for now:\n+# Start a server in lighthouse-viewer/dist/ and open the page in a tab. You should see the viewer.\n+# Drop in a results.json or paste an existing gist url (e.g. https://gist.github.com/ebidel/b9fd478b5f40bf5fab174439dc18f83a).\n+# Check for errors!\n+\n+# * Update changelog *\n+git fetch --tags\n+yarn changelog\n+# add new contributors, e.g. from\n+# git shortlog -s -e -n v2.3.0..HEAD\n+\n+# * Put up the PR *\n+echo \"Branch and commit the version bump.\"\n+git checkout -b bumpv240\n+git commit -am \"2.4.0\"\n+git tag -a v2.4.0 -m \"v2.4.0\"\n+echo \"Generate a PR and get it merged.\"\n+\n+# * Deploy-time *\n+cd lighthouse-extension; gulp package; cd ..\n+echo \"Upload the package zip to CWS dev dashboard\"\n+\n+echo \"Verify the npm package won't include unncessary files\"\n+yarn global add irish-pub pkgfiles\n+irish-pub; pkgfiles;\n+\n+echo \"ship it\"\n+npm publish\n+yarn deploy-viewer\n+\n+echo \"Use the GitHub web interface to tag the release\"\n+echo \"Copy changelog to release notes and update the release page\"\n+\n+# * Tell the world!!! *\n+echo \"Inform various peoples\"\n+```\n+\n+### Canary release\n+\n+```sh\n+# Pull latest in a clean non-dev clone.\n+\n+yarn install-all\n+\n+# Update manifest_canary.json w/ version bumps.\n+\n+# branch and commit\n+git commmit -m \"bump extension canary to 2.0.0.X\"\n+\n+npm version prerelease # this will commit\n+\n+\n+# overwrite extension's manifest w/ manifest_canary.\n+\n+yarn build-all\n+\n+cd lighthouse-extension/\n+gulp package\n+# upload zip to CWS and publish\n+\n+# verify you build-all'd for the typescript compile\n+# ...\n+\n+# publish to canary tag!\n+npm publish --tag canary\n+```\n",
"new_path": "docs/releasing.md",
"old_path": null
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
docs: extract Release Guide into own docs file (#4200)
| 1
|
docs
| null |
807,849
|
08.01.2018 14:09:11
| 28,800
|
f5d76a2301f2049ba40c71386c829bb819723563
|
chore: bump non-major devDependencies
|
[
{
"change_type": "MODIFY",
"diff": "@@ -37,9 +37,9 @@ acorn@^4.0.4:\nversion \"4.0.13\"\nresolved \"https://registry.yarnpkg.com/acorn/-/acorn-4.0.13.tgz#105495ae5361d697bd195c825192e1ad7f253787\"\n-acorn@^5.1.1:\n- version \"5.2.1\"\n- resolved \"https://registry.yarnpkg.com/acorn/-/acorn-5.2.1.tgz#317ac7821826c22c702d66189ab8359675f135d7\"\n+acorn@^5.2.1:\n+ version \"5.3.0\"\n+ resolved \"https://registry.yarnpkg.com/acorn/-/acorn-5.3.0.tgz#7446d39459c54fb49a80e6ee6478149b940ec822\"\nadd-stream@^1.0.0:\nversion \"1.0.0\"\n@@ -56,9 +56,9 @@ ajv@^4.9.1:\nco \"^4.6.0\"\njson-stable-stringify \"^1.0.1\"\n-ajv@^5.2.0, ajv@^5.2.3:\n- version \"5.3.0\"\n- resolved \"https://registry.yarnpkg.com/ajv/-/ajv-5.3.0.tgz#4414ff74a50879c208ee5fdc826e32c303549eda\"\n+ajv@^5.2.3, ajv@^5.3.0:\n+ version \"5.5.2\"\n+ resolved \"https://registry.yarnpkg.com/ajv/-/ajv-5.5.2.tgz#73b5eeca3fab653e3d3f9422b341ad42205dc965\"\ndependencies:\nco \"^4.6.0\"\nfast-deep-equal \"^1.0.0\"\n@@ -905,6 +905,10 @@ chalk@^2.1.0:\nescape-string-regexp \"^1.0.5\"\nsupports-color \"^4.0.0\"\n+chardet@^0.4.0:\n+ version \"0.4.2\"\n+ resolved \"https://registry.yarnpkg.com/chardet/-/chardet-0.4.2.tgz#b5473b33dc97c424e5d98dc87d55d4d8a29c8bf2\"\n+\nchokidar@^1.6.1:\nversion \"1.7.0\"\nresolved \"https://registry.yarnpkg.com/chokidar/-/chokidar-1.7.0.tgz#798e689778151c8076b4b360e5edd28cda2bb468\"\n@@ -974,8 +978,8 @@ code-point-at@^1.0.0:\nresolved \"https://registry.yarnpkg.com/code-point-at/-/code-point-at-1.1.0.tgz#0d070b4d043a5bea33a2f1a40e2edb3d9a4ccf77\"\ncolor-convert@^1.9.0:\n- version \"1.9.0\"\n- resolved \"https://registry.yarnpkg.com/color-convert/-/color-convert-1.9.0.tgz#1accf97dd739b983bf994d56fec8f95853641b7a\"\n+ version \"1.9.1\"\n+ resolved \"https://registry.yarnpkg.com/color-convert/-/color-convert-1.9.1.tgz#c1261107aeb2f294ebffec9ed9ecad529a6097ed\"\ndependencies:\ncolor-name \"^1.1.1\"\n@@ -1213,8 +1217,8 @@ create-error-class@^3.0.0:\ncapture-stack-trace \"^1.0.0\"\ncross-env@^5.0.5:\n- version \"5.1.1\"\n- resolved \"https://registry.yarnpkg.com/cross-env/-/cross-env-5.1.1.tgz#b6d8ab97f304c0f71dae7277b75fe424c08dfa74\"\n+ version \"5.1.3\"\n+ resolved \"https://registry.yarnpkg.com/cross-env/-/cross-env-5.1.3.tgz#f8ae18faac87692b0a8b4d2f7000d4ec3a85dfd7\"\ndependencies:\ncross-spawn \"^5.1.0\"\nis-windows \"^1.0.0\"\n@@ -1291,7 +1295,7 @@ debug@^2.6.8:\ndependencies:\nms \"2.0.0\"\n-debug@^3.0.1:\n+debug@^3.1.0:\nversion \"3.1.0\"\nresolved \"https://registry.yarnpkg.com/debug/-/debug-3.1.0.tgz#5bb5a0672628b64149566ba16819e61518c67261\"\ndependencies:\n@@ -1359,12 +1363,11 @@ diff@^3.0.0:\nversion \"3.3.0\"\nresolved \"https://registry.yarnpkg.com/diff/-/diff-3.3.0.tgz#056695150d7aa93237ca7e378ac3b1682b7963b9\"\n-doctrine@^2.0.0:\n- version \"2.0.0\"\n- resolved \"https://registry.yarnpkg.com/doctrine/-/doctrine-2.0.0.tgz#c73d8d2909d22291e1a007a395804da8b665fe63\"\n+doctrine@^2.0.2:\n+ version \"2.1.0\"\n+ resolved \"https://registry.yarnpkg.com/doctrine/-/doctrine-2.1.0.tgz#5cd01fc101621b42c4cd7f5d1a66243716d3f39d\"\ndependencies:\nesutils \"^2.0.2\"\n- isarray \"^1.0.0\"\ndot-prop@^3.0.0:\nversion \"3.0.0\"\n@@ -1432,8 +1435,8 @@ eslint-plugin-babel@^4.1.2:\nresolved \"https://registry.yarnpkg.com/eslint-plugin-babel/-/eslint-plugin-babel-4.1.2.tgz#79202a0e35757dd92780919b2336f1fa2fe53c1e\"\neslint-plugin-flowtype@^2.35.0:\n- version \"2.39.1\"\n- resolved \"https://registry.yarnpkg.com/eslint-plugin-flowtype/-/eslint-plugin-flowtype-2.39.1.tgz#b5624622a0388bcd969f4351131232dcb9649cd5\"\n+ version \"2.41.0\"\n+ resolved \"https://registry.yarnpkg.com/eslint-plugin-flowtype/-/eslint-plugin-flowtype-2.41.0.tgz#fd5221c60ba917c059d7ef69686a99cca09fd871\"\ndependencies:\nlodash \"^4.15.0\"\n@@ -1453,32 +1456,36 @@ eslint-scope@^3.7.1:\nesrecurse \"^4.1.0\"\nestraverse \"^4.1.1\"\n+eslint-visitor-keys@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-1.0.0.tgz#3f3180fb2e291017716acb4c9d6d5b5c34a6a81d\"\n+\neslint@^4.5.0:\n- version \"4.10.0\"\n- resolved \"https://registry.yarnpkg.com/eslint/-/eslint-4.10.0.tgz#f25d0d7955c81968c2309aa5c9a229e045176bb7\"\n+ version \"4.15.0\"\n+ resolved \"https://registry.yarnpkg.com/eslint/-/eslint-4.15.0.tgz#89ab38c12713eec3d13afac14e4a89e75ef08145\"\ndependencies:\n- ajv \"^5.2.0\"\n+ ajv \"^5.3.0\"\nbabel-code-frame \"^6.22.0\"\nchalk \"^2.1.0\"\nconcat-stream \"^1.6.0\"\ncross-spawn \"^5.1.0\"\n- debug \"^3.0.1\"\n- doctrine \"^2.0.0\"\n+ debug \"^3.1.0\"\n+ doctrine \"^2.0.2\"\neslint-scope \"^3.7.1\"\n- espree \"^3.5.1\"\n+ eslint-visitor-keys \"^1.0.0\"\n+ espree \"^3.5.2\"\nesquery \"^1.0.0\"\n- estraverse \"^4.2.0\"\nesutils \"^2.0.2\"\nfile-entry-cache \"^2.0.0\"\nfunctional-red-black-tree \"^1.0.1\"\nglob \"^7.1.2\"\n- globals \"^9.17.0\"\n+ globals \"^11.0.1\"\nignore \"^3.3.3\"\nimurmurhash \"^0.1.4\"\ninquirer \"^3.0.6\"\nis-resolvable \"^1.0.0\"\njs-yaml \"^3.9.1\"\n- json-stable-stringify \"^1.0.1\"\n+ json-stable-stringify-without-jsonify \"^1.0.1\"\nlevn \"^0.3.0\"\nlodash \"^4.17.4\"\nminimatch \"^3.0.2\"\n@@ -1495,11 +1502,11 @@ eslint@^4.5.0:\ntable \"^4.0.1\"\ntext-table \"~0.2.0\"\n-espree@^3.5.1:\n- version \"3.5.1\"\n- resolved \"https://registry.yarnpkg.com/espree/-/espree-3.5.1.tgz#0c988b8ab46db53100a1954ae4ba995ddd27d87e\"\n+espree@^3.5.2:\n+ version \"3.5.2\"\n+ resolved \"https://registry.yarnpkg.com/espree/-/espree-3.5.2.tgz#756ada8b979e9dcfcdb30aad8d1a9304a905e1ca\"\ndependencies:\n- acorn \"^5.1.1\"\n+ acorn \"^5.2.1\"\nacorn-jsx \"^3.0.0\"\nesprima@^2.7.1:\n@@ -1527,7 +1534,7 @@ estraverse@^1.9.1:\nversion \"1.9.3\"\nresolved \"https://registry.yarnpkg.com/estraverse/-/estraverse-1.9.3.tgz#af67f2dc922582415950926091a4005d29c9bb44\"\n-estraverse@^4.0.0, estraverse@^4.1.0, estraverse@^4.1.1, estraverse@^4.2.0:\n+estraverse@^4.0.0, estraverse@^4.1.0, estraverse@^4.1.1:\nversion \"4.2.0\"\nresolved \"https://registry.yarnpkg.com/estraverse/-/estraverse-4.2.0.tgz#0dee3fed31fcd469618ce7342099fc1afa0bdb13\"\n@@ -1582,11 +1589,11 @@ extend@~3.0.0:\nresolved \"https://registry.yarnpkg.com/extend/-/extend-3.0.1.tgz#a755ea7bc1adfcc5a31ce7e762dbaadc5e636444\"\nexternal-editor@^2.0.4:\n- version \"2.0.5\"\n- resolved \"https://registry.yarnpkg.com/external-editor/-/external-editor-2.0.5.tgz#52c249a3981b9ba187c7cacf5beb50bf1d91a6bc\"\n+ version \"2.1.0\"\n+ resolved \"https://registry.yarnpkg.com/external-editor/-/external-editor-2.1.0.tgz#3d026a21b7f95b5726387d4200ac160d372c3b48\"\ndependencies:\n+ chardet \"^0.4.0\"\niconv-lite \"^0.4.17\"\n- jschardet \"^1.4.2\"\ntmp \"^0.0.33\"\nextglob@^0.3.1:\n@@ -1873,7 +1880,11 @@ glob@^7.0.3, glob@^7.0.5, glob@^7.1.2:\nonce \"^1.3.0\"\npath-is-absolute \"^1.0.0\"\n-globals@^9.17.0, globals@^9.18.0:\n+globals@^11.0.1:\n+ version \"11.1.0\"\n+ resolved \"https://registry.yarnpkg.com/globals/-/globals-11.1.0.tgz#632644457f5f0e3ae711807183700ebf2e4633e4\"\n+\n+globals@^9.18.0:\nversion \"9.18.0\"\nresolved \"https://registry.yarnpkg.com/globals/-/globals-9.18.0.tgz#aa3896b3e69b487f17e31ed2143d69a8e30c2d8a\"\n@@ -2205,8 +2216,8 @@ is-path-in-cwd@^1.0.0:\nis-path-inside \"^1.0.0\"\nis-path-inside@^1.0.0:\n- version \"1.0.0\"\n- resolved \"https://registry.yarnpkg.com/is-path-inside/-/is-path-inside-1.0.0.tgz#fc06e5a1683fbda13de667aff717bbc10a48f37f\"\n+ version \"1.0.1\"\n+ resolved \"https://registry.yarnpkg.com/is-path-inside/-/is-path-inside-1.0.1.tgz#8ef5b7de50437a3fdca6b4e865ef7aa55cb48036\"\ndependencies:\npath-is-inside \"^1.0.1\"\n@@ -2231,10 +2242,8 @@ is-redirect@^1.0.0:\nresolved \"https://registry.yarnpkg.com/is-redirect/-/is-redirect-1.0.0.tgz#1d03dded53bd8db0f30c26e4f95d36fc7c87dc24\"\nis-resolvable@^1.0.0:\n- version \"1.0.0\"\n- resolved \"https://registry.yarnpkg.com/is-resolvable/-/is-resolvable-1.0.0.tgz#8df57c61ea2e3c501408d100fb013cf8d6e0cc62\"\n- dependencies:\n- tryit \"^1.0.1\"\n+ version \"1.0.1\"\n+ resolved \"https://registry.yarnpkg.com/is-resolvable/-/is-resolvable-1.0.1.tgz#acca1cd36dbe44b974b924321555a70ba03b1cf4\"\nis-retry-allowed@^1.0.0:\nversion \"1.1.0\"\n@@ -2266,7 +2275,7 @@ is-windows@^1.0.0:\nversion \"1.0.1\"\nresolved \"https://registry.yarnpkg.com/is-windows/-/is-windows-1.0.1.tgz#310db70f742d259a16a369202b51af84233310d9\"\n-isarray@1.0.0, isarray@^1.0.0, isarray@~1.0.0:\n+isarray@1.0.0, isarray@~1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/isarray/-/isarray-1.0.0.tgz#bb935d48582cba168c06834957a54a3e07124f11\"\n@@ -2571,10 +2580,6 @@ jsbn@~0.1.0:\nversion \"0.1.1\"\nresolved \"https://registry.yarnpkg.com/jsbn/-/jsbn-0.1.1.tgz#a5e654c2e5a2deb5f201d96cefbca80c0ef2f513\"\n-jschardet@^1.4.2:\n- version \"1.6.0\"\n- resolved \"https://registry.yarnpkg.com/jschardet/-/jschardet-1.6.0.tgz#c7d1a71edcff2839db2f9ec30fc5d5ebd3c1a678\"\n-\njsdom@^9.11.0:\nversion \"9.12.0\"\nresolved \"https://registry.yarnpkg.com/jsdom/-/jsdom-9.12.0.tgz#e8c546fffcb06c00d4833ca84410fed7f8a097d4\"\n@@ -2615,6 +2620,10 @@ json-schema@0.2.3:\nversion \"0.2.3\"\nresolved \"https://registry.yarnpkg.com/json-schema/-/json-schema-0.2.3.tgz#b480c892e59a2f05954ce727bd3f2a4e882f9e13\"\n+json-stable-stringify-without-jsonify@^1.0.1:\n+ version \"1.0.1\"\n+ resolved \"https://registry.yarnpkg.com/json-stable-stringify-without-jsonify/-/json-stable-stringify-without-jsonify-1.0.1.tgz#9db7b59496ad3f3cfef30a75142d2d930ad72651\"\n+\njson-stable-stringify@^1.0.1:\nversion \"1.0.1\"\nresolved \"https://registry.yarnpkg.com/json-stable-stringify/-/json-stable-stringify-1.0.1.tgz#9a759d39c5f2ff503fd5300646ed445f88c4f9af\"\n@@ -3908,10 +3917,6 @@ trim-right@^1.0.1:\nversion \"1.0.1\"\nresolved \"https://registry.yarnpkg.com/trim-right/-/trim-right-1.0.1.tgz#cb2e1203067e0c8de1f614094b9fe45704ea6003\"\n-tryit@^1.0.1:\n- version \"1.0.3\"\n- resolved \"https://registry.yarnpkg.com/tryit/-/tryit-1.0.3.tgz#393be730a9446fd1ead6da59a014308f36c289cb\"\n-\ntunnel-agent@^0.6.0:\nversion \"0.6.0\"\nresolved \"https://registry.yarnpkg.com/tunnel-agent/-/tunnel-agent-0.6.0.tgz#27a5dea06b36b04a0a9966774b290868f0fc40fd\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: bump non-major devDependencies
| 1
|
chore
| null |
807,849
|
08.01.2018 14:13:35
| 28,800
|
a63e0ba838969e011f49f8f70156d82be39359dc
|
chore: bump non-major dependencies
|
[
{
"change_type": "MODIFY",
"diff": "JSONStream@^1.0.4:\n- version \"1.3.1\"\n- resolved \"https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.1.tgz#707f761e01dae9e16f1bcf93703b78c70966579a\"\n+ version \"1.3.2\"\n+ resolved \"https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.2.tgz#c102371b6ec3a7cf3b847ca00c20bb0fce4c6dea\"\ndependencies:\njsonparse \"^1.2.0\"\nthrough \">=2.2.7 <3\"\n@@ -81,10 +81,6 @@ ansi-escapes@^1.4.0:\nversion \"1.4.0\"\nresolved \"https://registry.yarnpkg.com/ansi-escapes/-/ansi-escapes-1.4.0.tgz#d3a8a83b319aa67793662b13e761c7911422306e\"\n-ansi-escapes@^2.0.0:\n- version \"2.0.0\"\n- resolved \"https://registry.yarnpkg.com/ansi-escapes/-/ansi-escapes-2.0.0.tgz#5bae52be424878dd9783e8910e3fc2922e83c81b\"\n-\nansi-escapes@^3.0.0:\nversion \"3.0.0\"\nresolved \"https://registry.yarnpkg.com/ansi-escapes/-/ansi-escapes-3.0.0.tgz#ec3e8b4e9f8064fc02c3ac9b65f1c275bda8ef92\"\n@@ -203,10 +199,6 @@ async@^2.1.4:\ndependencies:\nlodash \"^4.14.0\"\n-async@~0.2.6:\n- version \"0.2.10\"\n- resolved \"https://registry.yarnpkg.com/async/-/async-0.2.10.tgz#b6bbe0b0674b9d719708ca38de8c237cb526c3d1\"\n-\nasynckit@^0.4.0:\nversion \"0.4.0\"\nresolved \"https://registry.yarnpkg.com/asynckit/-/asynckit-0.4.0.tgz#c79ed97f7f34cb8f2ba1bc9790bcc366474b4b79\"\n@@ -889,7 +881,7 @@ chalk@^1.1.1, chalk@^1.1.3:\nstrip-ansi \"^3.0.0\"\nsupports-color \"^2.0.0\"\n-chalk@^2.0.0:\n+chalk@^2.0.0, chalk@^2.1.0:\nversion \"2.3.0\"\nresolved \"https://registry.yarnpkg.com/chalk/-/chalk-2.3.0.tgz#b5ea48efc9c1793dccc9b4767c93914d3f2d52ba\"\ndependencies:\n@@ -897,14 +889,6 @@ chalk@^2.0.0:\nescape-string-regexp \"^1.0.5\"\nsupports-color \"^4.0.0\"\n-chalk@^2.1.0:\n- version \"2.1.0\"\n- resolved \"https://registry.yarnpkg.com/chalk/-/chalk-2.1.0.tgz#ac5becf14fa21b99c6c92ca7a7d7cfd5b17e743e\"\n- dependencies:\n- ansi-styles \"^3.1.0\"\n- escape-string-regexp \"^1.0.5\"\n- supports-color \"^4.0.0\"\n-\nchardet@^0.4.0:\nversion \"0.4.2\"\nresolved \"https://registry.yarnpkg.com/chardet/-/chardet-0.4.2.tgz#b5473b33dc97c424e5d98dc87d55d4d8a29c8bf2\"\n@@ -925,8 +909,8 @@ chokidar@^1.6.1:\nfsevents \"^1.0.0\"\nci-info@^1.0.0:\n- version \"1.0.0\"\n- resolved \"https://registry.yarnpkg.com/ci-info/-/ci-info-1.0.0.tgz#dc5285f2b4e251821683681c381c3388f46ec534\"\n+ version \"1.1.2\"\n+ resolved \"https://registry.yarnpkg.com/ci-info/-/ci-info-1.1.2.tgz#03561259db48d0474c8bdc90f5b47b068b6bbfb4\"\ncircular-json@^0.3.1:\nversion \"0.3.3\"\n@@ -1035,48 +1019,46 @@ content-type-parser@^1.0.1:\nversion \"1.0.1\"\nresolved \"https://registry.yarnpkg.com/content-type-parser/-/content-type-parser-1.0.1.tgz#c3e56988c53c65127fb46d4032a3a900246fdc94\"\n-conventional-changelog-angular@^1.3.4:\n- version \"1.4.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-angular/-/conventional-changelog-angular-1.4.0.tgz#118b9f7d41a3d99500bfb6bea1f3525e055e8b9b\"\n+conventional-changelog-angular@^1.5.2:\n+ version \"1.6.0\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-angular/-/conventional-changelog-angular-1.6.0.tgz#0a26a071f2c9fcfcf2b86ba0cfbf6e6301b75bfa\"\ndependencies:\ncompare-func \"^1.3.1\"\n- github-url-from-git \"^1.4.0\"\nq \"^1.4.1\"\n- read-pkg-up \"^2.0.0\"\n-conventional-changelog-atom@^0.1.0:\n- version \"0.1.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-atom/-/conventional-changelog-atom-0.1.0.tgz#67a47c66a42b2f8909ef1587c9989ae1de730b92\"\n+conventional-changelog-atom@^0.1.2:\n+ version \"0.1.2\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-atom/-/conventional-changelog-atom-0.1.2.tgz#12595ad5267a6937c34cf900281b1c65198a4c63\"\ndependencies:\nq \"^1.4.1\"\nconventional-changelog-cli@^1.3.2:\n- version \"1.3.2\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-cli/-/conventional-changelog-cli-1.3.2.tgz#33abf2b5720a9b094df38e81741ccb502e1a4125\"\n+ version \"1.3.5\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-cli/-/conventional-changelog-cli-1.3.5.tgz#46c51496216b7406588883defa6fac589e9bb31e\"\ndependencies:\nadd-stream \"^1.0.0\"\n- conventional-changelog \"^1.1.4\"\n+ conventional-changelog \"^1.1.7\"\nlodash \"^4.1.0\"\nmeow \"^3.7.0\"\ntempfile \"^1.1.1\"\n-conventional-changelog-codemirror@^0.1.0:\n- version \"0.1.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-codemirror/-/conventional-changelog-codemirror-0.1.0.tgz#7577a591dbf9b538e7a150a7ee62f65a2872b334\"\n+conventional-changelog-codemirror@^0.2.1:\n+ version \"0.2.1\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-codemirror/-/conventional-changelog-codemirror-0.2.1.tgz#299a4f7147baf350e6c8158fc54954a291c5cc09\"\ndependencies:\nq \"^1.4.1\"\n-conventional-changelog-core@^1.9.0:\n- version \"1.9.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-core/-/conventional-changelog-core-1.9.0.tgz#de5dfbc091847656508d4a389e35c9a1bc49e7f4\"\n+conventional-changelog-core@^1.9.3:\n+ version \"1.9.5\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-core/-/conventional-changelog-core-1.9.5.tgz#5db7566dad7c0cb75daf47fbb2976f7bf9928c1d\"\ndependencies:\n- conventional-changelog-writer \"^1.1.0\"\n- conventional-commits-parser \"^1.0.0\"\n+ conventional-changelog-writer \"^2.0.3\"\n+ conventional-commits-parser \"^2.1.0\"\ndateformat \"^1.0.12\"\nget-pkg-repo \"^1.0.0\"\n- git-raw-commits \"^1.2.0\"\n+ git-raw-commits \"^1.3.0\"\ngit-remote-origin-url \"^2.0.0\"\n- git-semver-tags \"^1.2.0\"\n+ git-semver-tags \"^1.2.3\"\nlodash \"^4.0.0\"\nnormalize-package-data \"^2.3.5\"\nq \"^1.4.1\"\n@@ -1084,21 +1066,21 @@ conventional-changelog-core@^1.9.0:\nread-pkg-up \"^1.0.1\"\nthrough2 \"^2.0.0\"\n-conventional-changelog-ember@^0.2.6:\n- version \"0.2.6\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-ember/-/conventional-changelog-ember-0.2.6.tgz#8b7355419f5127493c4c562473ab2fc792f1c2b6\"\n+conventional-changelog-ember@^0.2.9:\n+ version \"0.2.10\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-ember/-/conventional-changelog-ember-0.2.10.tgz#dcd6e4cdc2e6c2b58653cf4d2cb1656a60421929\"\ndependencies:\nq \"^1.4.1\"\n-conventional-changelog-eslint@^0.1.0:\n- version \"0.1.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-eslint/-/conventional-changelog-eslint-0.1.0.tgz#a52411e999e0501ce500b856b0a643d0330907e2\"\n+conventional-changelog-eslint@^0.2.1:\n+ version \"0.2.1\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-eslint/-/conventional-changelog-eslint-0.2.1.tgz#2c2a11beb216f80649ba72834180293b687c0662\"\ndependencies:\nq \"^1.4.1\"\n-conventional-changelog-express@^0.1.0:\n- version \"0.1.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-express/-/conventional-changelog-express-0.1.0.tgz#55c6c841c811962036c037bdbd964a54ae310fce\"\n+conventional-changelog-express@^0.2.1:\n+ version \"0.2.1\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-express/-/conventional-changelog-express-0.2.1.tgz#838d9e1e6c9099703b150b9c19aa2d781742bd6c\"\ndependencies:\nq \"^1.4.1\"\n@@ -1114,19 +1096,19 @@ conventional-changelog-jscs@^0.1.0:\ndependencies:\nq \"^1.4.1\"\n-conventional-changelog-jshint@^0.1.0:\n- version \"0.1.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-jshint/-/conventional-changelog-jshint-0.1.0.tgz#00cab8e9a3317487abd94c4d84671342918d2a07\"\n+conventional-changelog-jshint@^0.2.1:\n+ version \"0.2.1\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-jshint/-/conventional-changelog-jshint-0.2.1.tgz#86139bb3ac99899f2b177e9617e09b37d99bcf3a\"\ndependencies:\ncompare-func \"^1.3.1\"\nq \"^1.4.1\"\n-conventional-changelog-writer@^1.1.0:\n- version \"1.4.1\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog-writer/-/conventional-changelog-writer-1.4.1.tgz#3f4cb4d003ebb56989d30d345893b52a43639c8e\"\n+conventional-changelog-writer@^2.0.3:\n+ version \"2.0.3\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog-writer/-/conventional-changelog-writer-2.0.3.tgz#073b0c39f1cc8fc0fd9b1566e93833f51489c81c\"\ndependencies:\ncompare-func \"^1.3.1\"\n- conventional-commits-filter \"^1.0.0\"\n+ conventional-commits-filter \"^1.1.1\"\ndateformat \"^1.0.11\"\nhandlebars \"^4.0.2\"\njson-stringify-safe \"^5.0.1\"\n@@ -1136,43 +1118,31 @@ conventional-changelog-writer@^1.1.0:\nsplit \"^1.0.0\"\nthrough2 \"^2.0.0\"\n-conventional-changelog@^1.1.4:\n- version \"1.1.4\"\n- resolved \"https://registry.yarnpkg.com/conventional-changelog/-/conventional-changelog-1.1.4.tgz#108bc750c2a317e200e2f9b413caaa1f8c7efa3b\"\n- dependencies:\n- conventional-changelog-angular \"^1.3.4\"\n- conventional-changelog-atom \"^0.1.0\"\n- conventional-changelog-codemirror \"^0.1.0\"\n- conventional-changelog-core \"^1.9.0\"\n- conventional-changelog-ember \"^0.2.6\"\n- conventional-changelog-eslint \"^0.1.0\"\n- conventional-changelog-express \"^0.1.0\"\n+conventional-changelog@^1.1.7:\n+ version \"1.1.7\"\n+ resolved \"https://registry.yarnpkg.com/conventional-changelog/-/conventional-changelog-1.1.7.tgz#9151a62b1d8edb2d82711dabf5b7cf71041f82b1\"\n+ dependencies:\n+ conventional-changelog-angular \"^1.5.2\"\n+ conventional-changelog-atom \"^0.1.2\"\n+ conventional-changelog-codemirror \"^0.2.1\"\n+ conventional-changelog-core \"^1.9.3\"\n+ conventional-changelog-ember \"^0.2.9\"\n+ conventional-changelog-eslint \"^0.2.1\"\n+ conventional-changelog-express \"^0.2.1\"\nconventional-changelog-jquery \"^0.1.0\"\nconventional-changelog-jscs \"^0.1.0\"\n- conventional-changelog-jshint \"^0.1.0\"\n+ conventional-changelog-jshint \"^0.2.1\"\n-conventional-commits-filter@^1.0.0:\n- version \"1.0.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-commits-filter/-/conventional-commits-filter-1.0.0.tgz#6fc2a659372bc3f2339cf9ffff7e1b0344b93039\"\n+conventional-commits-filter@^1.1.1:\n+ version \"1.1.1\"\n+ resolved \"https://registry.yarnpkg.com/conventional-commits-filter/-/conventional-commits-filter-1.1.1.tgz#72172319c0c88328a015b30686b55527b3a5e54a\"\ndependencies:\nis-subset \"^0.1.1\"\nmodify-values \"^1.0.0\"\n-conventional-commits-parser@^1.0.0:\n- version \"1.3.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-commits-parser/-/conventional-commits-parser-1.3.0.tgz#e327b53194e1a7ad5dc63479ee9099a52b024865\"\n- dependencies:\n- JSONStream \"^1.0.4\"\n- is-text-path \"^1.0.0\"\n- lodash \"^4.2.1\"\n- meow \"^3.3.0\"\n- split2 \"^2.0.0\"\n- through2 \"^2.0.0\"\n- trim-off-newlines \"^1.0.0\"\n-\n-conventional-commits-parser@^2.0.0:\n- version \"2.0.0\"\n- resolved \"https://registry.yarnpkg.com/conventional-commits-parser/-/conventional-commits-parser-2.0.0.tgz#71d01910cb0a99aeb20c144e50f81f4df3178447\"\n+conventional-commits-parser@^2.1.0:\n+ version \"2.1.0\"\n+ resolved \"https://registry.yarnpkg.com/conventional-commits-parser/-/conventional-commits-parser-2.1.0.tgz#9b4b7c91124bf2a1a9a2cc1c72760d382cbbb229\"\ndependencies:\nJSONStream \"^1.0.4\"\nis-text-path \"^1.0.0\"\n@@ -1183,14 +1153,14 @@ conventional-commits-parser@^2.0.0:\ntrim-off-newlines \"^1.0.0\"\nconventional-recommended-bump@^1.0.1:\n- version \"1.0.1\"\n- resolved \"https://registry.yarnpkg.com/conventional-recommended-bump/-/conventional-recommended-bump-1.0.1.tgz#56b8ae553a8a1152fa069e767599e1f6948bd36c\"\n+ version \"1.1.0\"\n+ resolved \"https://registry.yarnpkg.com/conventional-recommended-bump/-/conventional-recommended-bump-1.1.0.tgz#964d4fcc70fb5259d41fa9b39d3df6afdb87d253\"\ndependencies:\nconcat-stream \"^1.4.10\"\n- conventional-commits-filter \"^1.0.0\"\n- conventional-commits-parser \"^2.0.0\"\n- git-raw-commits \"^1.2.0\"\n- git-semver-tags \"^1.2.1\"\n+ conventional-commits-filter \"^1.1.1\"\n+ conventional-commits-parser \"^2.1.0\"\n+ git-raw-commits \"^1.3.0\"\n+ git-semver-tags \"^1.2.3\"\nmeow \"^3.3.0\"\nobject-assign \"^4.0.1\"\n@@ -1399,13 +1369,7 @@ errno@^0.1.4:\ndependencies:\nprr \"~0.0.0\"\n-error-ex@^1.2.0:\n- version \"1.3.0\"\n- resolved \"https://registry.yarnpkg.com/error-ex/-/error-ex-1.3.0.tgz#e67b43f3e82c96ea3a584ffee0b9fc3325d802d9\"\n- dependencies:\n- is-arrayish \"^0.2.1\"\n-\n-error-ex@^1.3.1:\n+error-ex@^1.2.0, error-ex@^1.3.1:\nversion \"1.3.1\"\nresolved \"https://registry.yarnpkg.com/error-ex/-/error-ex-1.3.1.tgz#f855a86ce61adc4e8621c3cda21e7a7612c3a8dc\"\ndependencies:\n@@ -1713,11 +1677,11 @@ form-data@~2.1.1:\nmime-types \"^2.1.12\"\nfs-extra@^4.0.1:\n- version \"4.0.1\"\n- resolved \"https://registry.yarnpkg.com/fs-extra/-/fs-extra-4.0.1.tgz#7fc0c6c8957f983f57f306a24e5b9ddd8d0dd880\"\n+ version \"4.0.3\"\n+ resolved \"https://registry.yarnpkg.com/fs-extra/-/fs-extra-4.0.3.tgz#0d852122e5bc5beb453fb028e9c0c9bf36340c94\"\ndependencies:\ngraceful-fs \"^4.1.2\"\n- jsonfile \"^3.0.0\"\n+ jsonfile \"^4.0.0\"\nuniversalify \"^0.1.0\"\nfs-readdir-recursive@^1.0.0:\n@@ -1774,8 +1738,8 @@ get-caller-file@^1.0.1:\nresolved \"https://registry.yarnpkg.com/get-caller-file/-/get-caller-file-1.0.2.tgz#f702e63127e7e231c160a80c1554acb70d5047e5\"\nget-pkg-repo@^1.0.0:\n- version \"1.3.0\"\n- resolved \"https://registry.yarnpkg.com/get-pkg-repo/-/get-pkg-repo-1.3.0.tgz#43c6b4c048b75dd604fc5388edecde557f6335df\"\n+ version \"1.4.0\"\n+ resolved \"https://registry.yarnpkg.com/get-pkg-repo/-/get-pkg-repo-1.4.0.tgz#c73b489c06d80cc5536c2c853f9e05232056972d\"\ndependencies:\nhosted-git-info \"^2.1.4\"\nmeow \"^3.3.0\"\n@@ -1808,9 +1772,9 @@ getpass@^0.1.1:\ndependencies:\nassert-plus \"^1.0.0\"\n-git-raw-commits@^1.2.0:\n- version \"1.2.0\"\n- resolved \"https://registry.yarnpkg.com/git-raw-commits/-/git-raw-commits-1.2.0.tgz#0f3a8bfd99ae0f2d8b9224d58892975e9a52d03c\"\n+git-raw-commits@^1.3.0:\n+ version \"1.3.0\"\n+ resolved \"https://registry.yarnpkg.com/git-raw-commits/-/git-raw-commits-1.3.0.tgz#0bc8596e90d5ffe736f7f5546bd2d12f73abaac6\"\ndependencies:\ndargs \"^4.0.1\"\nlodash.template \"^4.0.2\"\n@@ -1825,16 +1789,9 @@ git-remote-origin-url@^2.0.0:\ngitconfiglocal \"^1.0.0\"\npify \"^2.3.0\"\n-git-semver-tags@^1.2.0:\n- version \"1.2.0\"\n- resolved \"https://registry.yarnpkg.com/git-semver-tags/-/git-semver-tags-1.2.0.tgz#b31fd02c8ab578bd6c9b5cacca5e1c64c1177ac1\"\n- dependencies:\n- meow \"^3.3.0\"\n- semver \"^5.0.1\"\n-\n-git-semver-tags@^1.2.1:\n- version \"1.2.1\"\n- resolved \"https://registry.yarnpkg.com/git-semver-tags/-/git-semver-tags-1.2.1.tgz#6ccd2a52e735b736748dc762444fcd9588e27490\"\n+git-semver-tags@^1.2.3:\n+ version \"1.2.3\"\n+ resolved \"https://registry.yarnpkg.com/git-semver-tags/-/git-semver-tags-1.2.3.tgz#188b453882bf9d7a23afd31baba537dab7388d5d\"\ndependencies:\nmeow \"^3.3.0\"\nsemver \"^5.0.1\"\n@@ -1845,10 +1802,6 @@ gitconfiglocal@^1.0.0:\ndependencies:\nini \"^1.3.2\"\n-github-url-from-git@^1.4.0:\n- version \"1.5.0\"\n- resolved \"https://registry.yarnpkg.com/github-url-from-git/-/github-url-from-git-1.5.0.tgz#f985fedcc0a9aa579dc88d7aff068d55cc6251a0\"\n-\nglob-base@^0.3.0:\nversion \"0.3.0\"\nresolved \"https://registry.yarnpkg.com/glob-base/-/glob-base-0.3.0.tgz#dbb164f6221b1c0b1ccf82aea328b497df0ea3c4\"\n@@ -1934,8 +1887,8 @@ growly@^1.3.0:\nresolved \"https://registry.yarnpkg.com/growly/-/growly-1.3.0.tgz#f10748cbe76af964b7c96c93c6bcc28af120c081\"\nhandlebars@^4.0.2:\n- version \"4.0.6\"\n- resolved \"https://registry.yarnpkg.com/handlebars/-/handlebars-4.0.6.tgz#2ce4484850537f9c97a8026d5399b935c4ed4ed7\"\n+ version \"4.0.11\"\n+ resolved \"https://registry.yarnpkg.com/handlebars/-/handlebars-4.0.11.tgz#630a35dfe0294bc281edae6ffc5d329fc7982dcc\"\ndependencies:\nasync \"^1.4.0\"\noptimist \"^0.6.1\"\n@@ -2002,11 +1955,7 @@ home-or-tmp@^2.0.0:\nos-homedir \"^1.0.0\"\nos-tmpdir \"^1.0.1\"\n-hosted-git-info@^2.1.4:\n- version \"2.2.0\"\n- resolved \"https://registry.yarnpkg.com/hosted-git-info/-/hosted-git-info-2.2.0.tgz#7a0d097863d886c0fabbdcd37bf1758d8becf8a5\"\n-\n-hosted-git-info@^2.5.0:\n+hosted-git-info@^2.1.4, hosted-git-info@^2.5.0:\nversion \"2.5.0\"\nresolved \"https://registry.yarnpkg.com/hosted-git-info/-/hosted-git-info-2.5.0.tgz#6d60e34b3abbc8313062c3b798ef8d901a07af3c\"\n@@ -2057,11 +2006,15 @@ inherits@2, inherits@^2.0.1, inherits@^2.0.3, inherits@~2.0.0, inherits@~2.0.1,\nversion \"2.0.3\"\nresolved \"https://registry.yarnpkg.com/inherits/-/inherits-2.0.3.tgz#633c2c83e3da42a502f52466022480f4208261de\"\n-ini@^1.3.2, ini@~1.3.0:\n+ini@^1.3.2:\n+ version \"1.3.5\"\n+ resolved \"https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927\"\n+\n+ini@~1.3.0:\nversion \"1.3.4\"\nresolved \"https://registry.yarnpkg.com/ini/-/ini-1.3.4.tgz#0537cb79daf59b59a1a517dff706c86ec039162e\"\n-inquirer@^3.0.6:\n+inquirer@^3.0.6, inquirer@^3.2.2:\nversion \"3.3.0\"\nresolved \"https://registry.yarnpkg.com/inquirer/-/inquirer-3.3.0.tgz#9dd2f2ad765dcab1ff0443b491442a20ba227dc9\"\ndependencies:\n@@ -2080,25 +2033,6 @@ inquirer@^3.0.6:\nstrip-ansi \"^4.0.0\"\nthrough \"^2.3.6\"\n-inquirer@^3.2.2:\n- version \"3.2.2\"\n- resolved \"https://registry.yarnpkg.com/inquirer/-/inquirer-3.2.2.tgz#c2aaede1507cc54d826818737742d621bef2e823\"\n- dependencies:\n- ansi-escapes \"^2.0.0\"\n- chalk \"^2.0.0\"\n- cli-cursor \"^2.1.0\"\n- cli-width \"^2.0.0\"\n- external-editor \"^2.0.4\"\n- figures \"^2.0.0\"\n- lodash \"^4.3.0\"\n- mute-stream \"0.0.7\"\n- run-async \"^2.2.0\"\n- rx-lite \"^4.0.8\"\n- rx-lite-aggregates \"^4.0.8\"\n- string-width \"^2.1.0\"\n- strip-ansi \"^4.0.0\"\n- through \"^2.3.6\"\n-\ninvariant@^2.2.2:\nversion \"2.2.2\"\nresolved \"https://registry.yarnpkg.com/invariant/-/invariant-2.2.2.tgz#9e1f56ac0acdb6bf303306f338be3b204ae60360\"\n@@ -2119,10 +2053,6 @@ is-binary-path@^1.0.0:\ndependencies:\nbinary-extensions \"^1.0.0\"\n-is-buffer@^1.0.2:\n- version \"1.1.4\"\n- resolved \"https://registry.yarnpkg.com/is-buffer/-/is-buffer-1.1.4.tgz#cfc86ccd5dc5a52fa80489111c6920c457e2d98b\"\n-\nis-buffer@^1.1.5:\nversion \"1.1.5\"\nresolved \"https://registry.yarnpkg.com/is-buffer/-/is-buffer-1.1.5.tgz#1f3b26ef613b214b88cbca23cc6c01d87961eecc\"\n@@ -2133,7 +2063,13 @@ is-builtin-module@^1.0.0:\ndependencies:\nbuiltin-modules \"^1.0.0\"\n-is-ci@^1.0.10, is-ci@^1.0.9:\n+is-ci@^1.0.10:\n+ version \"1.1.0\"\n+ resolved \"https://registry.yarnpkg.com/is-ci/-/is-ci-1.1.0.tgz#247e4162e7860cebbdaf30b774d6b0ac7dcfe7a5\"\n+ dependencies:\n+ ci-info \"^1.0.0\"\n+\n+is-ci@^1.0.9:\nversion \"1.0.10\"\nresolved \"https://registry.yarnpkg.com/is-ci/-/is-ci-1.0.10.tgz#f739336b2632365061a9d48270cd56ae3369318e\"\ndependencies:\n@@ -2638,9 +2574,9 @@ json5@^0.5.1:\nversion \"0.5.1\"\nresolved \"https://registry.yarnpkg.com/json5/-/json5-0.5.1.tgz#1eade7acc012034ad84e2396767ead9fa5495821\"\n-jsonfile@^3.0.0:\n- version \"3.0.0\"\n- resolved \"https://registry.yarnpkg.com/jsonfile/-/jsonfile-3.0.0.tgz#92e7c7444e5ffd5fa32e6a9ae8b85034df8347d0\"\n+jsonfile@^4.0.0:\n+ version \"4.0.0\"\n+ resolved \"https://registry.yarnpkg.com/jsonfile/-/jsonfile-4.0.0.tgz#8771aae0799b64076b76640fca058f9c10e33ecb\"\noptionalDependencies:\ngraceful-fs \"^4.1.6\"\n@@ -2649,8 +2585,8 @@ jsonify@~0.0.0:\nresolved \"https://registry.yarnpkg.com/jsonify/-/jsonify-0.0.0.tgz#2c74b6ee41d93ca51b7b5aaee8f503631d252a73\"\njsonparse@^1.2.0:\n- version \"1.3.0\"\n- resolved \"https://registry.yarnpkg.com/jsonparse/-/jsonparse-1.3.0.tgz#85fc245b1d9259acc6941960b905adf64e7de0e8\"\n+ version \"1.3.1\"\n+ resolved \"https://registry.yarnpkg.com/jsonparse/-/jsonparse-1.3.1.tgz#3f4dae4a91fac315f71062f8521cc239f1366280\"\njsprim@^1.2.2:\nversion \"1.4.1\"\n@@ -2662,10 +2598,10 @@ jsprim@^1.2.2:\nverror \"1.10.0\"\nkind-of@^3.0.2:\n- version \"3.1.0\"\n- resolved \"https://registry.yarnpkg.com/kind-of/-/kind-of-3.1.0.tgz#475d698a5e49ff5e53d14e3e732429dc8bf4cf47\"\n+ version \"3.2.2\"\n+ resolved \"https://registry.yarnpkg.com/kind-of/-/kind-of-3.2.2.tgz#31ea21a734bab9bbb0f32466d893aea51e4a3c64\"\ndependencies:\n- is-buffer \"^1.0.2\"\n+ is-buffer \"^1.1.5\"\nkind-of@^4.0.0:\nversion \"4.0.0\"\n@@ -2779,10 +2715,10 @@ lru-cache@^4.0.1:\nyallist \"^2.1.2\"\nmake-dir@^1.0.0:\n- version \"1.0.0\"\n- resolved \"https://registry.yarnpkg.com/make-dir/-/make-dir-1.0.0.tgz#97a011751e91dd87cfadef58832ebb04936de978\"\n+ version \"1.1.0\"\n+ resolved \"https://registry.yarnpkg.com/make-dir/-/make-dir-1.1.0.tgz#19b4369fe48c116f53c2af95ad102c0e39e85d51\"\ndependencies:\n- pify \"^2.3.0\"\n+ pify \"^3.0.0\"\nmakeerror@1.0.x:\nversion \"1.0.11\"\n@@ -2857,7 +2793,7 @@ minimatch@^3.0.0, minimatch@^3.0.2, minimatch@^3.0.3, minimatch@^3.0.4:\ndependencies:\nbrace-expansion \"^1.1.7\"\n-minimist@0.0.8, minimist@~0.0.1:\n+minimist@0.0.8:\nversion \"0.0.8\"\nresolved \"https://registry.yarnpkg.com/minimist/-/minimist-0.0.8.tgz#857fcabfc3397d2625b8228262e86aa7a011b05d\"\n@@ -2869,6 +2805,10 @@ minimist@^1.1.1, minimist@^1.1.3, minimist@^1.2.0:\nversion \"1.2.0\"\nresolved \"https://registry.yarnpkg.com/minimist/-/minimist-1.2.0.tgz#a35008b20f41383eec1fb914f4cd5df79a264284\"\n+minimist@~0.0.1:\n+ version \"0.0.10\"\n+ resolved \"https://registry.yarnpkg.com/minimist/-/minimist-0.0.10.tgz#de3f98543dbf96082be48ad1a0c7cda836301dcf\"\n+\n\"mkdirp@>=0.5 0\", mkdirp@^0.5.1, mkdirp@~0.5.0:\nversion \"0.5.1\"\nresolved \"https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.5.1.tgz#30057438eac6cf7f8c4767f38648d6697d75c903\"\n@@ -2944,8 +2884,8 @@ normalize-newline@^3.0.0:\nresolved \"https://registry.yarnpkg.com/normalize-newline/-/normalize-newline-3.0.0.tgz#1cbea804aba436001f83938ab21ec039d69ae9d3\"\nnormalize-package-data@^2.3.0, normalize-package-data@^2.3.2, normalize-package-data@^2.3.4, normalize-package-data@^2.3.5:\n- version \"2.3.5\"\n- resolved \"https://registry.yarnpkg.com/normalize-package-data/-/normalize-package-data-2.3.5.tgz#8d924f142960e1777e7ffe170543631cc7cb02df\"\n+ version \"2.4.0\"\n+ resolved \"https://registry.yarnpkg.com/normalize-package-data/-/normalize-package-data-2.4.0.tgz#12f95a307d58352075a04907b84ac8be98ac012f\"\ndependencies:\nhosted-git-info \"^2.1.4\"\nis-builtin-module \"^1.0.0\"\n@@ -3068,8 +3008,10 @@ p-finally@^1.0.0:\nresolved \"https://registry.yarnpkg.com/p-finally/-/p-finally-1.0.0.tgz#3fbcfb15b899a44123b34b6dcc18b724336a2cae\"\np-limit@^1.1.0:\n- version \"1.1.0\"\n- resolved \"https://registry.yarnpkg.com/p-limit/-/p-limit-1.1.0.tgz#b07ff2d9a5d88bec806035895a2bab66a27988bc\"\n+ version \"1.2.0\"\n+ resolved \"https://registry.yarnpkg.com/p-limit/-/p-limit-1.2.0.tgz#0e92b6bedcb59f022c13d0f1949dc82d15909f1c\"\n+ dependencies:\n+ p-try \"^1.0.0\"\np-locate@^2.0.0:\nversion \"2.0.0\"\n@@ -3077,6 +3019,10 @@ p-locate@^2.0.0:\ndependencies:\np-limit \"^1.1.0\"\n+p-try@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/p-try/-/p-try-1.0.0.tgz#cbc79cdbaf8fd4228e13f621f2b1a237c1b207b3\"\n+\npackage-json@^4.0.1:\nversion \"4.0.1\"\nresolved \"https://registry.yarnpkg.com/package-json/-/package-json-4.0.1.tgz#8869a0401253661c4c4ca3da6c2121ed555f5eed\"\n@@ -3087,8 +3033,8 @@ package-json@^4.0.1:\nsemver \"^5.1.0\"\nparse-github-repo-url@^1.3.0:\n- version \"1.4.0\"\n- resolved \"https://registry.yarnpkg.com/parse-github-repo-url/-/parse-github-repo-url-1.4.0.tgz#286c53e2c9962e0641649ee3ac9508fca4dd959c\"\n+ version \"1.4.1\"\n+ resolved \"https://registry.yarnpkg.com/parse-github-repo-url/-/parse-github-repo-url-1.4.1.tgz#9e7d8bb252a6cb6ba42595060b7bf6df3dbc1f50\"\nparse-glob@^3.0.4:\nversion \"3.0.4\"\n@@ -3163,10 +3109,14 @@ performance-now@^0.2.0:\nversion \"0.2.0\"\nresolved \"https://registry.yarnpkg.com/performance-now/-/performance-now-0.2.0.tgz#33ef30c5c77d4ea21c5a53869d91b56d8f2555e5\"\n-pify@^2.0.0, pify@^2.2.0, pify@^2.3.0:\n+pify@^2.0.0, pify@^2.3.0:\nversion \"2.3.0\"\nresolved \"https://registry.yarnpkg.com/pify/-/pify-2.3.0.tgz#ed141a6ac043a849ea588498e7dca8b15330e90c\"\n+pify@^3.0.0:\n+ version \"3.0.0\"\n+ resolved \"https://registry.yarnpkg.com/pify/-/pify-3.0.0.tgz#e5a4acd2c101fdf3d9a4d07f0dbc4db49dd28176\"\n+\npinkie-promise@^2.0.0:\nversion \"2.0.1\"\nresolved \"https://registry.yarnpkg.com/pinkie-promise/-/pinkie-promise-2.0.1.tgz#2135d6dfa7a358c069ac9b178776288228450ffa\"\n@@ -3228,8 +3178,8 @@ punycode@^1.4.1:\nresolved \"https://registry.yarnpkg.com/punycode/-/punycode-1.4.1.tgz#c0d5a63b2718800ad8e1eb0fa5269c84dd41845e\"\nq@^1.4.1:\n- version \"1.4.1\"\n- resolved \"https://registry.yarnpkg.com/q/-/q-1.4.1.tgz#55705bcd93c5f3673530c2c2cbc0c2b3addc286e\"\n+ version \"1.5.1\"\n+ resolved \"https://registry.yarnpkg.com/q/-/q-1.5.1.tgz#7e32f75b41381291d04611f1bf14109ac00651d7\"\nqs@~6.4.0:\nversion \"6.4.0\"\n@@ -3296,7 +3246,7 @@ read-pkg@^2.0.0:\nnormalize-package-data \"^2.3.2\"\npath-type \"^2.0.0\"\n-\"readable-stream@^2.0.0 || ^1.1.13\", readable-stream@^2.1.5:\n+\"readable-stream@^2.0.0 || ^1.1.13\":\nversion \"2.2.2\"\nresolved \"https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.2.2.tgz#a9e6fec3c7dda85f8bb1b3ba7028604556fc825e\"\ndependencies:\n@@ -3308,7 +3258,7 @@ read-pkg@^2.0.0:\nstring_decoder \"~0.10.x\"\nutil-deprecate \"~1.0.1\"\n-readable-stream@^2.0.2, readable-stream@^2.1.4, readable-stream@^2.2.2:\n+readable-stream@^2.0.2, readable-stream@^2.1.4, readable-stream@^2.1.5, readable-stream@^2.2.2:\nversion \"2.3.3\"\nresolved \"https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.3.3.tgz#368f2512d79f9d46fdfc71349ae7878bbc1eb95c\"\ndependencies:\n@@ -3495,13 +3445,13 @@ right-align@^0.1.1:\ndependencies:\nalign-text \"^0.1.1\"\n-rimraf@2, rimraf@^2.5.1, rimraf@^2.6.1:\n+rimraf@2, rimraf@^2.5.1:\nversion \"2.6.1\"\nresolved \"https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.1.tgz#c2338ec643df7a1b7fe5c54fa86f57428a55f33d\"\ndependencies:\nglob \"^7.0.5\"\n-rimraf@^2.2.8:\n+rimraf@^2.2.8, rimraf@^2.6.1:\nversion \"2.6.2\"\nresolved \"https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.2.tgz#2ed8150d24a16ea8651e6d6ef0f47c4158ce7a36\"\ndependencies:\n@@ -3543,14 +3493,14 @@ sax@^1.2.1:\nversion \"1.2.4\"\nresolved \"https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9\"\n-\"semver@2 || 3 || 4 || 5\", semver@5.3.0, semver@^5.0.1:\n- version \"5.3.0\"\n- resolved \"https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f\"\n-\n-semver@^5.1.0, semver@^5.3.0, semver@^5.4.1:\n+\"semver@2 || 3 || 4 || 5\", semver@^5.0.1, semver@^5.1.0, semver@^5.3.0, semver@^5.4.1:\nversion \"5.4.1\"\nresolved \"https://registry.yarnpkg.com/semver/-/semver-5.4.1.tgz#e059c09d8571f0540823733433505d3a2f00b18e\"\n+semver@5.3.0:\n+ version \"5.3.0\"\n+ resolved \"https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f\"\n+\nset-blocking@^2.0.0, set-blocking@~2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/set-blocking/-/set-blocking-2.0.0.tgz#045f9782d011ae9a6803ddd382b24392b3d890f7\"\n@@ -3593,12 +3543,6 @@ sntp@1.x.x:\ndependencies:\nhoek \"2.x.x\"\n-sort-keys@^1.1.1:\n- version \"1.1.2\"\n- resolved \"https://registry.yarnpkg.com/sort-keys/-/sort-keys-1.1.2.tgz#441b6d4d346798f1b4e49e8920adfba0e543f9ad\"\n- dependencies:\n- is-plain-obj \"^1.0.0\"\n-\nsort-keys@^2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/sort-keys/-/sort-keys-2.0.0.tgz#658535584861ec97d730d6cf41822e1f56684128\"\n@@ -3617,7 +3561,7 @@ source-map@^0.4.4:\ndependencies:\namdefine \">=0.0.4\"\n-source-map@^0.5.3, source-map@^0.5.6:\n+source-map@^0.5.3, source-map@^0.5.6, source-map@~0.5.1:\nversion \"0.5.7\"\nresolved \"https://registry.yarnpkg.com/source-map/-/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc\"\n@@ -3627,10 +3571,6 @@ source-map@~0.2.0:\ndependencies:\namdefine \">=0.0.4\"\n-source-map@~0.5.1:\n- version \"0.5.6\"\n- resolved \"https://registry.yarnpkg.com/source-map/-/source-map-0.5.6.tgz#75ce38f52bf0733c5a7f0c118d81334a2bb5f412\"\n-\nspdx-correct@~1.0.0:\nversion \"1.0.2\"\nresolved \"https://registry.yarnpkg.com/spdx-correct/-/spdx-correct-1.0.2.tgz#4b3073d933ff51f3912f03ac5519498a4150db40\"\n@@ -3646,14 +3586,14 @@ spdx-license-ids@^1.0.2:\nresolved \"https://registry.yarnpkg.com/spdx-license-ids/-/spdx-license-ids-1.2.2.tgz#c9df7a3424594ade6bd11900d596696dc06bac57\"\nsplit2@^2.0.0:\n- version \"2.1.1\"\n- resolved \"https://registry.yarnpkg.com/split2/-/split2-2.1.1.tgz#7a1f551e176a90ecd3345f7246a0cfe175ef4fd0\"\n+ version \"2.2.0\"\n+ resolved \"https://registry.yarnpkg.com/split2/-/split2-2.2.0.tgz#186b2575bcf83e85b7d18465756238ee4ee42493\"\ndependencies:\nthrough2 \"^2.0.2\"\nsplit@^1.0.0:\n- version \"1.0.0\"\n- resolved \"https://registry.yarnpkg.com/split/-/split-1.0.0.tgz#c4395ce683abcd254bc28fe1dabb6e5c27dcffae\"\n+ version \"1.0.1\"\n+ resolved \"https://registry.yarnpkg.com/split/-/split-1.0.1.tgz#605bd9be303aa59fb35f9229fbea0ddec9ea07d9\"\ndependencies:\nthrough \"2\"\n@@ -3813,13 +3753,13 @@ temp-dir@^1.0.0:\nresolved \"https://registry.yarnpkg.com/temp-dir/-/temp-dir-1.0.0.tgz#0a7c0ea26d3a39afa7e0ebea9c1fc0bc4daa011d\"\ntemp-write@^3.3.0:\n- version \"3.3.0\"\n- resolved \"https://registry.yarnpkg.com/temp-write/-/temp-write-3.3.0.tgz#c1a96de2b36061342eae81f44ff001aec8f615a9\"\n+ version \"3.4.0\"\n+ resolved \"https://registry.yarnpkg.com/temp-write/-/temp-write-3.4.0.tgz#8cff630fb7e9da05f047c74ce4ce4d685457d492\"\ndependencies:\ngraceful-fs \"^4.1.2\"\nis-stream \"^1.1.0\"\nmake-dir \"^1.0.0\"\n- pify \"^2.2.0\"\n+ pify \"^3.0.0\"\ntemp-dir \"^1.0.0\"\nuuid \"^3.0.1\"\n@@ -3849,8 +3789,8 @@ test-exclude@^4.1.1:\nrequire-main-filename \"^1.0.1\"\ntext-extensions@^1.0.0:\n- version \"1.4.0\"\n- resolved \"https://registry.yarnpkg.com/text-extensions/-/text-extensions-1.4.0.tgz#c385d2e80879fe6ef97893e1709d88d9453726e9\"\n+ version \"1.7.0\"\n+ resolved \"https://registry.yarnpkg.com/text-extensions/-/text-extensions-1.7.0.tgz#faaaba2625ed746d568a23e4d0aacd9bf08a8b39\"\ntext-table@~0.2.0:\nversion \"0.2.0\"\n@@ -3938,13 +3878,13 @@ typedarray@^0.0.6:\nresolved \"https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777\"\nuglify-js@^2.6:\n- version \"2.7.5\"\n- resolved \"https://registry.yarnpkg.com/uglify-js/-/uglify-js-2.7.5.tgz#4612c0c7baaee2ba7c487de4904ae122079f2ca8\"\n+ version \"2.8.29\"\n+ resolved \"https://registry.yarnpkg.com/uglify-js/-/uglify-js-2.8.29.tgz#29c5733148057bb4e1f75df35b7a9cb72e6a59dd\"\ndependencies:\n- async \"~0.2.6\"\nsource-map \"~0.5.1\"\n- uglify-to-browserify \"~1.0.0\"\nyargs \"~3.10.0\"\n+ optionalDependencies:\n+ uglify-to-browserify \"~1.0.0\"\nuglify-to-browserify@~1.0.0:\nversion \"1.0.2\"\n@@ -3961,8 +3901,8 @@ unique-string@^1.0.0:\ncrypto-random-string \"^1.0.0\"\nuniversalify@^0.1.0:\n- version \"0.1.0\"\n- resolved \"https://registry.yarnpkg.com/universalify/-/universalify-0.1.0.tgz#9eb1c4651debcc670cc94f1a75762332bb967778\"\n+ version \"0.1.1\"\n+ resolved \"https://registry.yarnpkg.com/universalify/-/universalify-0.1.1.tgz#fa71badd4437af4c148841e3b3b165f9e9e590b7\"\nunzip-response@^2.0.1:\nversion \"2.0.1\"\n@@ -3986,14 +3926,10 @@ uuid@^2.0.1:\nversion \"2.0.3\"\nresolved \"https://registry.yarnpkg.com/uuid/-/uuid-2.0.3.tgz#67e2e863797215530dff318e5bf9dcebfd47b21a\"\n-uuid@^3.0.0:\n+uuid@^3.0.0, uuid@^3.0.1:\nversion \"3.1.0\"\nresolved \"https://registry.yarnpkg.com/uuid/-/uuid-3.1.0.tgz#3dd3d3e790abc24d7b0d3a034ffababe28ebbc04\"\n-uuid@^3.0.1:\n- version \"3.0.1\"\n- resolved \"https://registry.yarnpkg.com/uuid/-/uuid-3.0.1.tgz#6544bba2dfda8c1cf17e629a3a305e2bb1fee6c1\"\n-\nv8flags@^2.1.1:\nversion \"2.1.1\"\nresolved \"https://registry.yarnpkg.com/v8flags/-/v8flags-2.1.1.tgz#aab1a1fa30d45f88dd321148875ac02c0b55e5b4\"\n@@ -4115,14 +4051,14 @@ write-file-atomic@^2.0.0, write-file-atomic@^2.3.0:\nsignal-exit \"^3.0.2\"\nwrite-json-file@^2.2.0:\n- version \"2.2.0\"\n- resolved \"https://registry.yarnpkg.com/write-json-file/-/write-json-file-2.2.0.tgz#51862506bbb3b619eefab7859f1fd6c6d0530876\"\n+ version \"2.3.0\"\n+ resolved \"https://registry.yarnpkg.com/write-json-file/-/write-json-file-2.3.0.tgz#2b64c8a33004d54b8698c76d585a77ceb61da32f\"\ndependencies:\ndetect-indent \"^5.0.0\"\ngraceful-fs \"^4.1.2\"\nmake-dir \"^1.0.0\"\n- pify \"^2.0.0\"\n- sort-keys \"^1.1.1\"\n+ pify \"^3.0.0\"\n+ sort-keys \"^2.0.0\"\nwrite-file-atomic \"^2.0.0\"\nwrite-pkg@^3.1.0:\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: bump non-major dependencies
| 1
|
chore
| null |
791,723
|
08.01.2018 15:46:19
| 28,800
|
b564cf26f9f8a120bd0cf3f1f5e1f878077ba0ef
|
docs(results): describe audit's notApplicable/error
|
[
{
"change_type": "MODIFY",
"diff": "@@ -53,6 +53,7 @@ An object containing the results of the audits, keyed by their name.\n| description | `string` | The brief description of the audit's successful state. |\n| helpText | `string` | A more detailed description that describes why the audit is important and links to Lighthouse documentation on the audit, markdown links supported. |\n| debugString | <code>string|undefined</code> | A string indicating some additional information to the user explaining an unusual circumstance or reason for failure. |\n+| error | `boolean` | Set to true if there was an an exception thrown within the audit. The error message will be in `debugString`.\n| rawValue | <code>boolean|number</code> | The unscored value determined by the audit. Typically this will match the score if there's no additional information to impart. For performance audits, this value is typically a number indicating the metric value. |\n| displayValue | `string` | The string to display in the report alongside audit results. If empty, nothing additional is shown. This is typically used to explain additional information such as the number and nature of failing items. |\n| score | <code>boolean|number</code> | The scored value determined by the audit as either boolean or a number `0-100`. If the audit is a boolean, the implication is `score ? 100 : 0`. |\n@@ -61,6 +62,8 @@ An object containing the results of the audits, keyed by their name.\n| extendedInfo | `Object` | Extra information found by the audit. The structure of this object varies from audit to audit and is generally for programmatic consumption and debugging, though there is typically overlap with `details`. *WARNING: The structure of this object is not stable and cannot be trusted to follow semver* |\n| manual | `boolean` | Indicator used for display that the audit does not have results and is a placeholder for the user to conduct manual testing. |\n| informative | `boolean` | Indicator used for display that the audit is intended to be informative only. It cannot be passed or failed. |\n+| notApplicable | `boolean` | Indicator used for display that the audit doesn't apply to the page. (e.g. A images audit on a page without images). |\n+\n### Example\n```json\n",
"new_path": "docs/understanding-results.md",
"old_path": "docs/understanding-results.md"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
docs(results): describe audit's notApplicable/error (#4186)
| 1
|
docs
|
results
|
791,690
|
08.01.2018 16:06:11
| 28,800
|
22a6b3d23bd4aad216b15672f3a3a5fc59f4288c
|
core(screenshots): fix getParsedImage of null
|
[
{
"change_type": "MODIFY",
"diff": "@@ -78,9 +78,12 @@ class ScreenshotThumbnails extends Audit {\n]).then(([speedline, ttfi, ttci]) => {\nconst thumbnails = [];\nconst analyzedFrames = speedline.frames.filter(frame => !frame.isProgressInterpolated());\n+ const maxFrameTime =\n+ speedline.complete ||\n+ Math.max(...speedline.frames.map(frame => frame.getTimeStamp() - speedline.beginning));\n// Find thumbnails to cover the full range of the trace (max of last visual change and time\n// to interactive).\n- const timelineEnd = Math.max(speedline.complete, ttfi.rawValue, ttci.rawValue);\n+ const timelineEnd = Math.max(maxFrameTime, ttfi.rawValue, ttci.rawValue);\nfor (let i = 1; i <= NUMBER_OF_THUMBNAILS; i++) {\nconst targetTimestamp = speedline.beginning + timelineEnd * i / NUMBER_OF_THUMBNAILS;\n@@ -98,7 +101,8 @@ class ScreenshotThumbnails extends Audit {\nconst imageData = frameForTimestamp.getParsedImage();\nconst thumbnailImageData = ScreenshotThumbnails.scaleImageToThumbnail(imageData);\n- const base64Data = cachedThumbnails.get(frameForTimestamp) ||\n+ const base64Data =\n+ cachedThumbnails.get(frameForTimestamp) ||\njpeg.encode(thumbnailImageData, 90).data.toString('base64');\ncachedThumbnails.set(frameForTimestamp, base64Data);\n",
"new_path": "lighthouse-core/audits/screenshot-thumbnails.js",
"old_path": "lighthouse-core/audits/screenshot-thumbnails.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -31,7 +31,7 @@ class ViewportDimensions extends Gatherer {\nafterPass(options) {\nconst driver = options.driver;\n- return driver.evaluateAsync(`(${getViewportDimensions.toString()}())`)\n+ return driver.evaluateAsync(`(${getViewportDimensions.toString()}())`, {useIsolation: true})\n.then(dimensions => {\nconst allNumeric = Object.keys(dimensions).every(key => Number.isFinite(dimensions[key]));\n",
"new_path": "lighthouse-core/gather/gatherers/viewport-dimensions.js",
"old_path": "lighthouse-core/gather/gatherers/viewport-dimensions.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(screenshots): fix getParsedImage of null (#4189)
| 1
|
core
|
screenshots
|
791,723
|
08.01.2018 16:10:20
| 28,800
|
171f10cd2ec0e6b05476f18175e86761b36413f6
|
docs(releasing): update release policy
|
[
{
"change_type": "MODIFY",
"diff": "### Cadence\n-We ship twice a month, on the Thursday before the 15th and the Thursday before 1st. These dates are added to the internal Lighthouse calendar.\n+We ship once a month, on the Thursday before the 1st. While not necessary, followup minor/patch releases may be done if warranted. The planned ship dates are added to the internal Lighthouse calendar.\n### Release manager\n-Rather than a rotation, release manager is appointed. However if the appointed manager is absent, the next engineer in the following list owns it:\n+Release manager is appointed, according to the list below. However, if the appointed manager is absent, the next engineer in line in the list would own it.\nbckenny, paulirish, patrickhulce\n@@ -17,9 +17,10 @@ Release manager follows the below _Release Process_.\n### Release publicity\n1. Release mgr copies changelog to a new [Releases](https://github.com/GoogleChrome/lighthouse/releases). Tags and ships it.\n+ * Include a line of `We expect this release to ship in the DevTools of Chrome XX`.\n1. Release mgr tells the _LH public_ Hangout chat about the new version.\n-1. V writes and publishes the [/updates](https://developers.google.com/web/updates/) blog post\n-1. Paul writes the tweet and sends it on [@____lighthouse](https://twitter.com/____lighthouse).\n+1. V & Kayce write and publish the [/updates](https://developers.google.com/web/updates/) blog post\n+1. Paul writes the tweet (linking the /updates post) and sends it on [@____lighthouse](https://twitter.com/____lighthouse).\n1. Paul prepares a roll for DevTools frontend\n### Versioning\n",
"new_path": "docs/releasing.md",
"old_path": "docs/releasing.md"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
docs(releasing): update release policy (#4208)
| 1
|
docs
|
releasing
|
791,690
|
08.01.2018 16:17:37
| 28,800
|
d4603f659030b4c1d727ffe2b3318eb685456a2e
|
tests(trace-parser): use fs over require
|
[
{
"change_type": "MODIFY",
"diff": "'use strict';\n/* eslint-env mocha */\n+const fs = require('fs');\nconst assert = require('assert');\nconst TimelineModel = require('../../../lib/traces/devtools-timeline-model');\nconst filename = 'devtools-homepage-w-screenshots-trace.json';\n-const events = require('../..//fixtures/traces/' + filename);\n+const events = JSON.parse(fs.readFileSync(__dirname + '/../../fixtures/traces/' + filename));\nlet model;\ndescribe('DevTools Timeline Model', function() {\n",
"new_path": "lighthouse-core/test/lib/traces/devtools-timeline-model-test.js",
"old_path": "lighthouse-core/test/lib/traces/devtools-timeline-model-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -40,7 +40,8 @@ describe('traceParser parser', () => {\nconst parser = new TraceParser();\nlet bytesRead = 0;\n// FYI: this trace doesn't have a traceEvents property ;)\n- const events = require('../../fixtures/traces/devtools-homepage-w-screenshots-trace.json');\n+ const filename = '/../../fixtures/traces/devtools-homepage-w-screenshots-trace.json';\n+ const events = JSON.parse(fs.readFileSync(__dirname + filename));\n/**\n* This function will synthesize a trace that's over 256 MB. To do that, we'll take an existing\n@@ -76,7 +77,7 @@ describe('traceParser parser', () => {\nconst streamedTrace = parser.getTrace();\nassert.ok(bytesRead > 256 * 1024 * 1024, `${bytesRead} bytes read`);\n- assert.strictEqual(bytesRead, 270179102, `${bytesRead} bytes read`);\n+ assert.strictEqual(bytesRead, 270128965, `${bytesRead} bytes read`);\n// if > 256 MB are read we should have ~480,000 trace events\nassert.ok(streamedTrace.traceEvents.length > 400 * 1000, 'not >400,000 trace events');\n",
"new_path": "lighthouse-core/test/lib/traces/trace-parser-test.js",
"old_path": "lighthouse-core/test/lib/traces/trace-parser-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
tests(trace-parser): use fs over require (#4209)
| 1
|
tests
|
trace-parser
|
791,723
|
08.01.2018 16:18:02
| 28,800
|
b433a2a5329fb9bb35bbc8802fb16b95c27355a2
|
cli: remove legacy domhtml output
|
[
{
"change_type": "MODIFY",
"diff": "@@ -76,11 +76,8 @@ function getFlags(manualArgv) {\n'Additional categories to capture with the trace (comma-delimited).',\n'config-path': 'The path to the config JSON.',\n'chrome-flags':\n- `Custom flags to pass to Chrome (space-delimited). For a full list of flags, see http://peter.sh/experiments/chromium-command-line-switches/.\n-\n- Environment variables:\n- CHROME_PATH: Explicit path of intended Chrome binary. If set must point to an executable of a build of Chromium version 54.0 or later. By default, any detected Chrome Canary or Chrome (stable) will be launched.\n- `,\n+ `Custom flags to pass to Chrome (space-delimited). For a full list of flags, see http://bit.ly/chrome-flags\n+ Additionally, use the CHROME_PATH environment variable to use a specific Chrome binary. Requires Chromium version 54.0 or later. If omitted, any detected Chrome Canary or Chrome stable will be used.`,\n'perf': 'Use a performance-test-only configuration',\n'hostname': 'The hostname to use for the debugging protocol.',\n'port': 'The port to use for the debugging protocol. Use 0 for a random port',\n@@ -115,7 +112,7 @@ function getFlags(manualArgv) {\n// default values\n.default('chrome-flags', '')\n.default('disable-cpu-throttling', false)\n- .default('output', 'domhtml')\n+ .default('output', 'html')\n.default('port', 0)\n.default('hostname', 'localhost')\n.default('max-wait-for-load', Driver.MAX_WAIT_FOR_FULLY_LOADED)\n",
"new_path": "lighthouse-cli/cli-flags.js",
"old_path": "lighthouse-cli/cli-flags.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -13,12 +13,10 @@ const log = require('lighthouse-logger');\n* An enumeration of acceptable output modes:\n* 'json': JSON formatted results\n* 'html': An HTML report\n- * 'domhtml': Alias for 'html' report\n*/\nconst OutputMode = {\njson: 'json',\nhtml: 'html',\n- domhtml: 'domhtml',\n};\n/**\n@@ -42,7 +40,7 @@ function checkOutputPath(path) {\n*/\nfunction createOutput(results, outputMode) {\n// HTML report.\n- if (outputMode === OutputMode.domhtml || outputMode === OutputMode.html) {\n+ if (outputMode === OutputMode.html) {\nreturn new ReportGenerator().generateReportHtml(results);\n}\n// JSON report.\n",
"new_path": "lighthouse-cli/printer.js",
"old_path": "lighthouse-cli/printer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -128,17 +128,16 @@ function saveResults(results, artifacts, flags) {\nreturn promise.then(_ => {\nif (Array.isArray(flags.output)) {\nreturn flags.output.reduce((innerPromise, outputType) => {\n- const extension = outputType === 'domhtml' ? 'html' : outputType;\n+ const extension = outputType;\nconst outputPath = `${resolvedPath}.report.${extension}`;\nreturn innerPromise.then(() => Printer.write(results, outputType, outputPath));\n}, Promise.resolve());\n} else {\n- const extension = flags.output === 'domhtml' ? 'html' : flags.output;\n+ const extension = flags.output;\nconst outputPath =\nflags.outputPath || `${resolvedPath}.report.${extension}`;\nreturn Printer.write(results, flags.output, outputPath).then(_ => {\n- if (flags.output === Printer.OutputMode[Printer.OutputMode.html] ||\n- flags.output === Printer.OutputMode[Printer.OutputMode.domhtml]) {\n+ if (flags.output === Printer.OutputMode[Printer.OutputMode.html]) {\nif (flags.view) {\nopn(outputPath, {wait: false});\n} else {\n",
"new_path": "lighthouse-cli/run.js",
"old_path": "lighthouse-cli/run.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
cli: remove legacy domhtml output (#4176)
| 1
|
cli
| null |
791,813
|
08.01.2018 18:54:11
| -3,600
|
13b0405e462a2f4dd7f8e107da36f95c70c2b1c5
|
core(font-size): make font size artifact serializable
|
[
{
"change_type": "MODIFY",
"diff": "@@ -12,8 +12,8 @@ const CSSStyleDeclaration = require('../../lib/web-inspector').CSSStyleDeclarati\nconst MINIMAL_PERCENTAGE_OF_LEGIBLE_TEXT = 75;\n/**\n- * @param {Array<{cssRule: WebInspector.CSSStyleDeclaration, fontSize: number, textLength: number, node: Node}>} fontSizeArtifact\n- * @returns {Array<{cssRule: WebInspector.CSSStyleDeclaration, fontSize: number, textLength: number, node: Node}>}\n+ * @param {Array<{cssRule: SimplifiedStyleDeclaration, fontSize: number, textLength: number, node: Node}>} fontSizeArtifact\n+ * @returns {Array<{cssRule: SimplifiedStyleDeclaration, fontSize: number, textLength: number, node: Node}>}\n*/\nfunction getUniqueFailingRules(fontSizeArtifact) {\nconst failingRules = new Map();\n@@ -91,7 +91,7 @@ function nodeToTableNode(node) {\n/**\n* @param {string} baseURL\n- * @param {WebInspector.CSSStyleDeclaration} styleDeclaration\n+ * @param {SimplifiedStyleDeclaration} styleDeclaration\n* @param {Node} node\n* @returns {{source:!string, selector:string|object}}\n*/\n@@ -154,7 +154,7 @@ function findStyleRuleSource(baseURL, styleDeclaration, node) {\n}\n/**\n- * @param {WebInspector.CSSStyleDeclaration} styleDeclaration\n+ * @param {SimplifiedStyleDeclaration} styleDeclaration\n* @param {Node} node\n* @return string\n*/\n",
"new_path": "lighthouse-core/audits/seo/font-size.js",
"old_path": "lighthouse-core/audits/seo/font-size.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -150,7 +150,7 @@ function isNonEmptyTextNode(node) {\nclass FontSize extends Gatherer {\n/**\n* @param {{driver: !Object}} options Run options\n- * @return {!Promise<{totalTextLength: number, failingTextLength: number, visitedTextLength: number, analyzedFailingTextLength: number, analyzedFailingNodesData: Array<{fontSize: number, textLength: number, node: Node, cssRule: WebInspector.CSSStyleDeclaration}>}>} font-size analysis\n+ * @return {!Promise<{totalTextLength: number, failingTextLength: number, visitedTextLength: number, analyzedFailingTextLength: number, analyzedFailingNodesData: Array<{fontSize: number, textLength: number, node: Node, cssRule: SimplifiedStyleDeclaration}>}>} font-size analysis\n*/\nafterPass(options) {\nconst stylesheets = new Map();\n@@ -190,7 +190,20 @@ class FontSize extends Gatherer {\n.map(info =>\ngetFontSizeSourceRule(options.driver, info.node)\n.then(sourceRule => {\n- info.cssRule = sourceRule;\n+ if (sourceRule) {\n+ info.cssRule = {\n+ type: sourceRule.type,\n+ range: sourceRule.range,\n+ styleSheetId: sourceRule.styleSheetId,\n+ };\n+\n+ if (sourceRule.parentRule) {\n+ info.cssRule.parentRule = {\n+ origin: sourceRule.parentRule.origin,\n+ selectors: sourceRule.parentRule.selectors,\n+ };\n+ }\n+ }\nreturn info;\n})\n)\n@@ -222,3 +235,12 @@ class FontSize extends Gatherer {\nmodule.exports = FontSize;\n+/**\n+ * Simplified, for serializability sake, WebInspector.CSSStyleDeclaration\n+ * @typedef {Object} SimplifiedStyleDeclaration\n+ * @property {string} type\n+ * @property {{startLine: number, startColumn: number}} range\n+ * @property {{origin: string, selectors: Array<{text: string}>}} parentRule\n+ * @property {string} styleSheetId\n+ * @property {WebInspector.CSSStyleSheetHeader} stylesheet\n+ */\n",
"new_path": "lighthouse-core/gather/gatherers/seo/font-size.js",
"old_path": "lighthouse-core/gather/gatherers/seo/font-size.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -78,7 +78,6 @@ describe('Font size gatherer', () => {\nvisitedTextLength: expectedVisitedTextLength,\ntotalTextLength: expectedTotalTextLength,\nanalyzedFailingNodesData: [{\n- cssRule: undefined,\nfontSize: 10,\nnode: bodyNode,\ntextLength: expectedFailingTextLength,\n",
"new_path": "lighthouse-core/test/gather/gatherers/seo/font-size-test.js",
"old_path": "lighthouse-core/test/gather/gatherers/seo/font-size-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(font-size): make font size artifact serializable (#4194)
| 1
|
core
|
font-size
|
807,840
|
08.01.2018 23:58:40
| -7,200
|
e4e29db3013fd19c4114f724ae7d57961005367b
|
fix: typo in README.md "in in"
[skip ci]
|
[
{
"change_type": "MODIFY",
"diff": "@@ -229,7 +229,7 @@ Let's use `babel` as an example.\n$ lerna add <package>[@version] [--dev]\n```\n-Add local or remote `package` as dependency to packages in in the current Lerna repo.\n+Add local or remote `package` as dependency to packages in the current Lerna repo.\nWhen run, this command will:\n",
"new_path": "README.md",
"old_path": "README.md"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
fix: typo in README.md "in in" (#1166)
[skip ci]
| 1
|
fix
| null |
791,676
|
09.01.2018 00:38:55
| -3,600
|
0ea37de17e6c6c1eab2fef473e5b55daf8b85048
|
core(errors-in-console): If exception info is not present use exception text
|
[
{
"change_type": "MODIFY",
"diff": "@@ -47,9 +47,12 @@ class ErrorLogs extends Audit {\nconst runtimeExRows =\nruntimeExceptions.filter(entry => entry.exceptionDetails !== undefined)\n.map(entry => {\n+ const description = entry.exceptionDetails.exception ?\n+ entry.exceptionDetails.exception.description : entry.exceptionDetails.text;\n+\nreturn {\nsource: 'Runtime.exception',\n- description: entry.exceptionDetails.exception.description,\n+ description,\nurl: entry.exceptionDetails.url,\n};\n});\n",
"new_path": "lighthouse-core/audits/errors-in-console.js",
"old_path": "lighthouse-core/audits/errors-in-console.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -121,4 +121,34 @@ describe('Console error logs audit', () => {\n// text is undefined\nassert.strictEqual(auditResult.details.items[0][1].text, undefined);\n});\n+\n+ // Checks bug #4188\n+ it('handle the case when exception info is not present', () => {\n+ const auditResult = ErrorLogsAudit.audit({\n+ ChromeConsoleMessages: [],\n+ RuntimeExceptions: [{\n+ 'timestamp': 1506535813608.003,\n+ 'exceptionDetails': {\n+ 'url': 'http://example.com/fancybox.js',\n+ 'text': 'TypeError: Cannot read property \\'msie\\' of undefined',\n+ 'stackTrace': {\n+ 'callFrames': [\n+ {\n+ 'url': 'http://example.com/fancybox.js',\n+ 'lineNumber': 28,\n+ 'columnNumber': 20,\n+ },\n+ ],\n+ },\n+ 'executionContextId': 3,\n+ },\n+ }],\n+ });\n+ assert.equal(auditResult.rawValue, 1);\n+ assert.equal(auditResult.score, false);\n+ assert.equal(auditResult.details.items.length, 1);\n+ assert.strictEqual(auditResult.details.items[0][0].text, 'http://example.com/fancybox.js');\n+ assert.strictEqual(auditResult.details.items[0][1].text,\n+ 'TypeError: Cannot read property \\'msie\\' of undefined');\n+ });\n});\n",
"new_path": "lighthouse-core/test/audits/errors-in-console-test.js",
"old_path": "lighthouse-core/test/audits/errors-in-console-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(errors-in-console): If exception info is not present use exception text (#4191)
| 1
|
core
|
errors-in-console
|
743,960
|
09.01.2018 06:56:05
| -3,600
|
e87f4873012e3541325e7ec6dafb11a93b5717e0
|
docs: fix middlware docs
|
[
{
"change_type": "MODIFY",
"diff": "@@ -467,7 +467,8 @@ var argv = require('yargs')\n.option('password')\n} ,(argv) => {\nauthenticateUser(argv.username, argv.password)\n- })\n- .middlewares([normalizeCredentials])\n+ },\n+ [normalizeCredentials]\n+ )\n.argv;\n```\n",
"new_path": "docs/advanced.md",
"old_path": "docs/advanced.md"
}
] |
JavaScript
|
MIT License
|
yargs/yargs
|
docs: fix middlware docs (#1037)
| 1
|
docs
| null |
448,035
|
09.01.2018 11:16:18
| -7,200
|
38103acea5ea4245de3c4b25322ed3a4a8999741
|
fix: exclude ng-package.json from entry point discovery
Closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -102,18 +102,23 @@ const primaryEntryPoint =\n*/\nconst findSecondaryPackagesPaths =\nasync (directoryPath: string, excludeFolder: string): Promise<string[]> => {\n- const EXCLUDE_FOLDERS = [\n+ let excludedFolders = [\n'node_modules',\n'dist',\n'.ng_build',\n'.ng_pkg_build',\n+ path.resolve(directoryPath, excludeFolder)\n]\n- .map((directoryName) => `**/${directoryName}/**/package.json`)\n- .concat([\n- path.resolve(directoryPath, 'package.json'),\n- path.resolve(directoryPath, 'ng-package.json'),\n- path.resolve(directoryPath, excludeFolder) + '/**/package.json'\n- ]);\n+\n+ const EXCLUDE_FOLDERS = [];\n+ for (let folder of excludedFolders) {\n+ EXCLUDE_FOLDERS.push(`**/${folder}/**/package.json`);\n+ EXCLUDE_FOLDERS.push(`**/${folder}/**/ng-package.json`);\n+ }\n+ EXCLUDE_FOLDERS.push(directoryPath + '/package.json');\n+ EXCLUDE_FOLDERS.push(directoryPath + '/ng-package.json');\n+\n+\nreturn new Promise<string[]>((resolve, reject) => {\nglob(`${directoryPath}/**/*package.json`,\n@@ -143,7 +148,7 @@ const findSecondaryPackagesPaths =\nconst secondaryEntryPoint =\n(primaryDirectoryPath: string, primary: NgEntryPoint, { packageJson, ngPackageJson, basePath }: UserPackage): NgEntryPoint => {\n- if (basePath === primaryDirectoryPath) {\n+ if (path.resolve(basePath) === path.resolve(primaryDirectoryPath)) {\nlog.error(`Cannot read secondary entry point. It's already a primary entry point. path=${basePath}`);\nthrow new Error(`Secondary entry point is already a primary.`);\n}\n",
"new_path": "src/lib/steps/init.ts",
"old_path": "src/lib/steps/init.ts"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
fix: exclude ng-package.json from entry point discovery (#471)
Closes #463
| 1
|
fix
| null |
791,690
|
09.01.2018 11:46:37
| 28,800
|
442d53173f5ab9a3052a80cc5923f2d196588dac
|
tests(travis): remove upload artifacts
|
[
{
"change_type": "MODIFY",
"diff": "@@ -5,12 +5,6 @@ matrix:\n- node_js: \"8\"\n- node_js: \"9\"\ndist: trusty\n-env:\n- global:\n- - ARTIFACTS_AWS_REGION=us-west-2\n- - ARTIFACTS_S3_BUCKET=lighthouse-screenshots-debugging\n- - secure: WNrQ6K8eS8/lVml6qz031oV3HQM0M3WB1+1K9DTbjlVSuYgzu3tLGCRWn67tF8+3AQWIRDXyHByONrGinWTm1teZA9SaTzuVhMrO7CHdsWTWsypQ0UqJ6H4mH/wJwJv/kW6OtQSQJGUTF8kEz33nDQVW+iFWxJx3Ow4egya6cb9D89TnUJ0FBLxYYS2DjNTbIMVBMBqSGyrd/Ww5CoYzKR96Y9jby5IId9TFFJqk3qFfXVh3Diy5TX8hUvqUpD48cfQpxE8cLZ/uOXtRsHjwMvekCSG7fNMlbQ9nJ4MmnIwhdvFrKbx1xS7g5FdRfyN+q3QcDxskytWYmtzREoRjU3N6ao8IGsXG88yXpK1bdGQ2BdNAg4IltQDGMKMzVC37sAFmXvI9S00TmWQOoAu5D4KuW9Gchc+syCpZ+umqPGePgfGryWBt0slOkFi3mixavL0kAr1kAbWbeGFBLEeX80NFFm+F2qOMuwPSsmVJ8bsgsEp0DkceyggAqb9VDyTq9ci8l/pTGTQfqbEBcXgS19BY2zDldvncfmHFisd13zHOYkqn+pi+Ta87xlskL93FOxQFn14avJo/5iNa2HmEh8vq/jBbocVr+Tt+T+OMzN/RFGBfzqU4T2K3rj9hG1cCgZFuVm+sdSuulzeUjV7y3rDAT3eAUwBnERCzwDhCpT0=\n- - secure: UdWqkZHhU2PDMKleiL386FHI6S+N0PETDd5RWPBNM/YvMREWHyWeb3vZwsMqSVri1DNk8SqI2d0PC4/jLGKchRBqlO4+smuw9f09ihn+mGI67GFsyJu6UQ5/nz5eiUKx2ZRsuB8t8BbCGiOWh+UQUuHTEgAi8ndL+ml+Vy1XRpqbT49rOTKcr+G/4J+TyEjq+wRrpZMZmhYeX0EZAcofL8KYvgbV5jbkOnQV2oI0cyCO1FQxnIz9yopvwrMlKz/1jmKiRyJOj0YaKSJ5lWs0G2RFsWmXrEAgDAlOqoJ2QCTCM5M1Fnh+0oWPholN7X4Nj/USqxRlcGaUwDLh5RhcDlrFv+wC9iBIDIay3K1/IKndikkO8OP+tCYDlx2VQRX50LPUTEQzrXEbD6pFUl1ezLQCZPejX7R/HI5rOr8WcmZzKXtl1MP0h8YX1e9HX7gXBUB0RGwnTV/P+Q6WEcxN32T/xdwbYi/YQsXfzeL7fzF5PI5LnaAc141lhcUiILs9HwnEyB7gWWLlut+GNKfse6DrNkKc3I12TVVMbHWuP2waGuc1EMcMCyC/9lb17sk5q1gbIbAsSWki9mHtrJsk0KtriKY/uOFiK5W6Dno1ITbMqbTvIelMKgQPkjYmvqyLDhADRXQz9kxlSmxcdTG5dB9lOm6ubFdRmWEPhPumq4I=\ncache:\nyarn: true\ndirectories:\n@@ -27,7 +21,6 @@ install:\n# travis can't handle the parallel install (without caches)\n- yarn run install-all:task:windows\nbefore_script:\n- - gem install travis-artifacts\n- export DISPLAY=:99.0\n- export CHROME_PATH=\"$(pwd)/chrome-linux/chrome\"\n- sh -e /etc/init.d/xvfb start\n@@ -49,7 +42,5 @@ before_cache:\n- rm -rf ./node_modules/temp-devtoolsprotocol/\nafter_success:\n- yarn coveralls\n-after_failure:\n- - grep 'No screenshots' perf.json && travis-artifacts upload --path perf-0.trace.json\naddons:\nchrome: stable\n",
"new_path": ".travis.yml",
"old_path": ".travis.yml"
},
{
"change_type": "MODIFY",
"diff": "@@ -6,14 +6,8 @@ sleep 0.5s\nconfig=\"lighthouse-core/config/perf.json\"\nexpectations=\"lighthouse-cli/test/smokehouse/perf/expectations.js\"\n-save_assets=\"\"\n-if [[ \"$CI\" = true ]]; then\n- # save assets so that failures may be examined later\n- save_assets=\"--save-assets-path=perf.json\"\n-fi\n-\n-yarn smokehouse -- --config-path=$config --expectations-path=$expectations \"$save_assets\"\n+yarn smokehouse -- --config-path=$config --expectations-path=$expectations\nexit_code=$?\n# kill test servers\n",
"new_path": "lighthouse-cli/test/smokehouse/perf/run-tests.sh",
"old_path": "lighthouse-cli/test/smokehouse/perf/run-tests.sh"
},
{
"change_type": "MODIFY",
"diff": "@@ -43,10 +43,9 @@ function resolveLocalOrCwd(payloadPath) {\n* Launch Chrome and do a full Lighthouse run.\n* @param {string} url\n* @param {string} configPath\n- * @param {string=} saveAssetsPath\n* @return {!LighthouseResults}\n*/\n-function runLighthouse(url, configPath, saveAssetsPath) {\n+function runLighthouse(url, configPath) {\nconst command = 'node';\nconst args = [\n'lighthouse-cli/index.js',\n@@ -57,11 +56,6 @@ function runLighthouse(url, configPath, saveAssetsPath) {\n'--port=0',\n];\n- if (saveAssetsPath) {\n- args.push('--save-assets');\n- args.push(`--output-path=${saveAssetsPath}`);\n- }\n-\n// Lighthouse sometimes times out waiting to for a connection to Chrome in CI.\n// Watch for this error and retry relaunching Chrome and running Lighthouse up\n// to RETRIES times. See https://github.com/GoogleChrome/lighthouse/issues/833\n@@ -86,11 +80,6 @@ function runLighthouse(url, configPath, saveAssetsPath) {\nprocess.exit(runResults.status);\n}\n- if (saveAssetsPath) {\n- // If assets were saved, the JSON output was written to the specified path instead of stdout\n- return require(resolveLocalOrCwd(saveAssetsPath));\n- }\n-\nreturn JSON.parse(runResults.stdout);\n}\n@@ -275,7 +264,6 @@ const cli = yargs\n.describe({\n'config-path': 'The path to the config JSON file',\n'expectations-path': 'The path to the expected audit results file',\n- 'save-assets-path': 'Saves assets to the named path if set',\n})\n.default('config-path', DEFAULT_CONFIG_PATH)\n.default('expectations-path', DEFAULT_EXPECTATIONS_PATH)\n@@ -290,7 +278,7 @@ let passingCount = 0;\nlet failingCount = 0;\nexpectations.forEach(expected => {\nconsole.log(`Checking '${expected.initialUrl}'...`);\n- const results = runLighthouse(expected.initialUrl, configPath, cli['save-assets-path']);\n+ const results = runLighthouse(expected.initialUrl, configPath);\nconst collated = collateResults(results, expected);\nconst counts = report(collated);\npassingCount += counts.passed;\n",
"new_path": "lighthouse-cli/test/smokehouse/smokehouse.js",
"old_path": "lighthouse-cli/test/smokehouse/smokehouse.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
tests(travis): remove upload artifacts (#4219)
| 1
|
tests
|
travis
|
791,723
|
09.01.2018 11:50:47
| 28,800
|
7d8eb6d6c73b854bee74c9ee5dc4f0f4a3a6a264
|
report: more attractive table/URL rendering
|
[
{
"change_type": "MODIFY",
"diff": "@@ -61,7 +61,7 @@ class ErrorLogs extends Audit {\nconst headings = [\n{key: 'url', itemType: 'url', text: 'URL'},\n- {key: 'description', itemType: 'text', text: 'Description'},\n+ {key: 'description', itemType: 'code', text: 'Description'},\n];\nconst details = Audit.makeTableDetails(headings, tableRows);\n",
"new_path": "lighthouse-core/audits/errors-in-console.js",
"old_path": "lighthouse-core/audits/errors-in-console.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -66,28 +66,37 @@ class DetailsRenderer {\n_renderTextURL(text) {\nconst url = text.text || '';\n- let displayedURL;\n+ let displayedPath;\n+ let displayedHost;\nlet title;\ntry {\n- displayedURL = Util.parseURL(url).file;\n+ const parsed = Util.parseURL(url);\n+ displayedPath = parsed.file;\n+ displayedHost = `(${parsed.hostname})`;\ntitle = url;\n} catch (/** @type {!Error} */ e) {\nif (!(e instanceof TypeError)) {\nthrow e;\n}\n- displayedURL = url;\n+ displayedPath = url;\n}\n- const element = this._renderText({\n- type: 'url',\n- text: displayedURL,\n- });\n- element.classList.add('lh-text__url');\n+ const element = this._dom.createElement('div', 'lh-text__url');\n+ element.appendChild(this._renderText({\n+ text: displayedPath,\n+ type: 'text',\n+ }));\n- if (title) {\n- element.title = url;\n+ if (displayedHost) {\n+ const hostElem = this._renderText({\n+ text: displayedHost,\n+ type: 'text',\n+ });\n+ hostElem.classList.add('lh-text__url-host');\n+ element.appendChild(hostElem);\n}\n+ if (title) element.title = url;\nreturn element;\n}\n",
"new_path": "lighthouse-core/report/v2/renderer/details-renderer.js",
"old_path": "lighthouse-core/report/v2/renderer/details-renderer.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -147,8 +147,15 @@ class Util {\n}\nconst MAX_LENGTH = 64;\n- // Always elide hash\n+ // Always elide hexadecimal hash\nname = name.replace(/([a-f0-9]{7})[a-f0-9]{13}[a-f0-9]*/g, `$1${ELLIPSIS}`);\n+ // Also elide other hash-like mixed-case strings\n+ name = name.replace(/([a-zA-Z0-9-_]{9})(?=.*[a-z])(?=.*[A-Z])(?=.*[0-9])[a-zA-Z0-9-_]{10,}/g,\n+ `$1${ELLIPSIS}`);\n+ // Also elide long number sequences\n+ name = name.replace(/(\\d{3})\\d{6,}/g, `$1${ELLIPSIS}`);\n+ // Merge any adjacent ellipses\n+ name = name.replace(/\\u2026+/g, ELLIPSIS);\n// Elide query params first\nif (name.length > MAX_LENGTH && name.includes('?')) {\n",
"new_path": "lighthouse-core/report/v2/renderer/util.js",
"old_path": "lighthouse-core/report/v2/renderer/util.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -744,13 +744,12 @@ span.lh-node:hover {\nfont-size: large;\n}\n-.lh-text__url {\n+.lh-text {\nwhite-space: nowrap;\n}\n.lh-code {\n- text-overflow: ellipsis;\n- white-space: pre-line;\n+ white-space: normal;\nmargin-top: 0;\n}\n@@ -902,8 +901,9 @@ summary.lh-passed-audits-summary {\n--image-preview-size: 24px;\nborder: 1px solid var(--report-secondary-border-color);\nborder-collapse: collapse;\n- table-layout: fixed;\nwidth: 100%;\n+\n+ --url-col-max-width: 450px;\n}\n.lh-table thead {\n@@ -916,8 +916,7 @@ summary.lh-passed-audits-summary {\n.lh-table th,\n.lh-table td {\n- padding: 10px;\n- overflow: auto;\n+ padding: 8px 6px;\n}\n.lh-table-column--text {\n@@ -932,6 +931,31 @@ summary.lh-passed-audits-summary {\ntext-align: left;\nmin-width: 250px;\nwhite-space: nowrap;\n+ max-width: var(--url-col-max-width);\n+}\n+\n+.lh-table-column--code {\n+ max-width: var(--url-col-max-width);\n+}\n+\n+.lh-text__url {\n+ overflow: hidden;\n+ text-overflow: ellipsis;\n+}\n+\n+.lh-text__url:hover {\n+ text-decoration: underline dotted #999;\n+ text-decoration-skip-ink: auto;\n+}\n+\n+.lh-text__url > .lh-text, .lh-text__url-host {\n+ display: inline;\n+}\n+\n+.lh-text__url-host {\n+ margin-left: calc(var(--body-font-size) / 2);\n+ opacity: 0.6;\n+ font-size: 90%\n}\n.lh-thumbnail {\n",
"new_path": "lighthouse-core/report/v2/report-styles.css",
"old_path": "lighthouse-core/report/v2/report-styles.css"
},
{
"change_type": "MODIFY",
"diff": "@@ -86,18 +86,18 @@ describe('Console error logs audit', () => {\nassert.equal(auditResult.details.items.length, 3);\nassert.equal(auditResult.details.items[0][0].type, 'url');\nassert.equal(auditResult.details.items[0][0].text, 'http://www.example.com/favicon.ico');\n- assert.equal(auditResult.details.items[0][1].type, 'text');\n+ assert.equal(auditResult.details.items[0][1].type, 'code');\nassert.equal(auditResult.details.items[0][1].text,\n'The server responded with a status of 404 (Not Found)');\nassert.equal(auditResult.details.items[1][0].type, 'url');\nassert.equal(auditResult.details.items[1][0].text, 'http://www.example.com/wsconnect.ws');\n- assert.equal(auditResult.details.items[1][1].type, 'text');\n+ assert.equal(auditResult.details.items[1][1].type, 'code');\nassert.equal(auditResult.details.items[1][1].text,\n'WebSocket connection failed: Unexpected response code: 500');\nassert.equal(auditResult.details.items[2][0].type, 'url');\nassert.equal(auditResult.details.items[2][0].text,\n'http://example.com/fancybox.js');\n- assert.equal(auditResult.details.items[2][1].type, 'text');\n+ assert.equal(auditResult.details.items[2][1].type, 'code');\nassert.equal(auditResult.details.items[2][1].text,\n'TypeError: Cannot read property \\'msie\\' of undefined');\n});\n",
"new_path": "lighthouse-core/test/audits/errors-in-console-test.js",
"old_path": "lighthouse-core/test/audits/errors-in-console-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -123,6 +123,19 @@ describe('URL Shim', () => {\nassert.equal(result, '/file-f303dec\\u2026-somethingmore.css');\n});\n+ it('Elides google-fonts hashes', () => {\n+ const url = 'https://fonts.gstatic.com/s/droidsans/v8/s-BiyweUPV0v-yRb-cjciAzyDMXhdD8sAj6OAJTFsBI.woff2';\n+ const result = URL.getURLDisplayName(url);\n+ assert.equal(result, '\\u2026v8/s-BiyweUP\\u2026.woff2');\n+ });\n+\n+ it('Elides long number sequences', () => {\n+ const url = 'http://cdn.cnn.com/cnnnext/dam/assets/150507173438-11-week-in-photos-0508-large-169.jpg';\n+ const result = URL.getURLDisplayName(url);\n+ assert.equal(result, '\\u2026assets/150\\u2026-11-week-in-photos-0508-large-169.jpg');\n+ });\n+\n+\nit('Elides query strings when can first parameter', () => {\nconst url = 'http://example.com/file.css?aQueryString=true&other_long_query_stuff=false&some_other_super_long_query';\nconst result = URL.getURLDisplayName(url);\n@@ -145,7 +158,7 @@ describe('URL Shim', () => {\nconst url = superLongName.slice(0, -3) +\n'-f303dec6eec305a4fab8025577db3c2feb418148ac75ba378281399fb1ba670b.css';\nconst result = URL.getURLDisplayName(url);\n- const expected = '/thisIsASuperLongURLThatWillTriggerFilenameTruncationWhichW\\u2026.css';\n+ const expected = '/thisIsASu\\u2026.css';\nassert.equal(result, expected);\n});\n",
"new_path": "lighthouse-core/test/lib/url-shim-test.js",
"old_path": "lighthouse-core/test/lib/url-shim-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -216,7 +216,7 @@ describe('DetailsRenderer', () => {\nit('renders text URLs', () => {\nconst urlText = 'https://example.com/';\n- const displayUrlText = '/';\n+ const displayUrlText = '/(example.com)';\nconst el = renderer.render({\ntype: 'url',\ntext: urlText,\n@@ -224,7 +224,7 @@ describe('DetailsRenderer', () => {\nassert.equal(el.localName, 'div');\nassert.equal(el.textContent, displayUrlText);\n- assert.ok(el.classList.contains('lh-text'), 'adds classes');\n+ assert.ok(el.classList.contains('lh-text__url'), 'adds classes');\n});\n});\n});\n",
"new_path": "lighthouse-core/test/report/v2/renderer/details-renderer-test.js",
"old_path": "lighthouse-core/test/report/v2/renderer/details-renderer-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
report: more attractive table/URL rendering (#4190)
| 1
|
report
| null |
807,915
|
09.01.2018 16:35:53
| -3,600
|
a760939928951b6305c8733b72fb0ae765f528c7
|
fix: Do not pass custom preset to recommended-bump
`conventional-recommended-bump` cannot accept custom preset and thus this should always be `angular` or `eslint`
|
[
{
"change_type": "MODIFY",
"diff": "@@ -19,20 +19,24 @@ const CHANGELOG_CLI = require.resolve(\"conventional-changelog-cli/cli\");\nexport default class ConventionalCommitUtilities {\nstatic recommendIndependentVersion(pkg, opts) {\n+ // `-p` here is overridden because `conventional-recommended-bump`\n+ // cannot accept custom preset.\nconst args = [\nRECOMMEND_CLI,\n\"-l\", pkg.name,\n\"--commit-path\", pkg.location,\n- \"-p\", ConventionalCommitUtilities.changelogPreset(opts),\n+ \"-p\", \"angular\",\n];\nreturn ConventionalCommitUtilities.recommendVersion(pkg, opts, \"recommendIndependentVersion\", args);\n}\nstatic recommendFixedVersion(pkg, opts) {\n+ // `-p` here is overridden because `conventional-recommended-bump`\n+ // cannot accept custom preset.\nconst args = [\nRECOMMEND_CLI,\n\"--commit-path\", pkg.location,\n- \"-p\", ConventionalCommitUtilities.changelogPreset(opts),\n+ \"-p\", \"angular\",\n];\nreturn ConventionalCommitUtilities.recommendVersion(pkg, opts, \"recommendFixedVersion\", args);\n}\n",
"new_path": "src/ConventionalCommitUtilities.js",
"old_path": "src/ConventionalCommitUtilities.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
fix: Do not pass custom preset to recommended-bump (#1185)
`conventional-recommended-bump` cannot accept custom preset and thus this should always be `angular` or `eslint` https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-recommended-bump/presets
| 1
|
fix
| null |
807,915
|
09.01.2018 16:40:55
| -3,600
|
a20601c6e94b3f651b6a8474dd1b1f00269f6be2
|
feat: `--allow-branch` publish option now accepts multiple globs
|
[
{
"change_type": "MODIFY",
"diff": "@@ -489,7 +489,7 @@ This can be configured in lerna.json, as well:\n#### --allow-branch [glob]\n-Lerna allows you to specify a glob in your `lerna.json` that your current branch needs to match to be publishable.\n+Lerna allows you to specify a glob or an array of globs in your `lerna.json` that your current branch needs to match to be publishable.\nYou can use this flag to override this setting.\nIf your `lerna.json` contains something like this:\n@@ -503,6 +503,19 @@ If your `lerna.json` contains something like this:\n}\n```\n+```json\n+{\n+ \"command\": {\n+ \"publish\": {\n+ \"allowBranch\": [\n+ \"master\",\n+ \"feature/*\"\n+ ]\n+ }\n+ }\n+}\n+```\n+\nand you are not on the branch `master` lerna will prevent you from publishing. To force a publish despite this config, pass the `--allow-branch` flag:\n```sh\n",
"new_path": "README.md",
"old_path": "README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -140,8 +140,7 @@ export const builder = {\n\"allow-branch\": {\ngroup: \"Command Options:\",\ndescribe: \"Specify which branches to allow publishing from.\",\n- type: \"string\",\n- default: undefined,\n+ type: \"array\",\n},\n};\n@@ -200,7 +199,10 @@ export default class PublishCommand extends Command {\n}\nconst currentBranch = GitUtilities.getCurrentBranch(this.execOpts);\n- if (this.options.allowBranch && !minimatch(currentBranch, this.options.allowBranch)) {\n+ if (\n+ this.options.allowBranch &&\n+ ![].concat(this.options.allowBranch).some(x => minimatch(currentBranch, x))\n+ ) {\nthrow new ValidationError(\n\"ENOTALLOWED\",\ndedent`\n",
"new_path": "src/commands/PublishCommand.js",
"old_path": "src/commands/PublishCommand.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -1077,6 +1077,13 @@ describe(\"PublishCommand\", () => {\nconst { exitCode } = await run(testDir)(\"--allow-branch\", \"feature/*\");\nexpect(exitCode).toBe(0);\n});\n+\n+ it(\"should accept a branch that matches one of the items passed\", async () => {\n+ GitUtilities.getCurrentBranch.mockReturnValueOnce(\"feature/awesome\");\n+\n+ const { exitCode } = await run(testDir)(\"--allow-branch\", \"master\",\"feature/*\");\n+ expect(exitCode).toBe(0);\n+ });\n});\ndescribe(\"lerna.json\", () => {\n",
"new_path": "test/PublishCommand.js",
"old_path": "test/PublishCommand.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
feat: `--allow-branch` publish option now accepts multiple globs (#1167)
| 1
|
feat
| null |
791,723
|
09.01.2018 17:27:17
| 28,800
|
ff3c8a50e1aa43747e78e67cc31461e7687b70bd
|
misc(tests): add comment to explain assertTraceEventsEqual
[skip ci]
|
[
{
"change_type": "MODIFY",
"diff": "@@ -17,6 +17,7 @@ const dbwResults = require('../fixtures/dbw_tester-perf-results.json');\nconst Audit = require('../../audits/audit.js');\nconst fullTraceObj = require('../fixtures/traces/progressive-app-m60.json');\n+// deepStrictEqual can hang on a full trace, we assert trace same-ness like so\nfunction assertTraceEventsEqual(traceEventsA, traceEventsB) {\nassert.equal(traceEventsA.length, traceEventsB.length);\ntraceEventsA.forEach((evt, i) => {\n",
"new_path": "lighthouse-core/test/lib/asset-saver-test.js",
"old_path": "lighthouse-core/test/lib/asset-saver-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
misc(tests): add comment to explain assertTraceEventsEqual
[skip ci]
| 1
|
misc
|
tests
|
815,745
|
09.01.2018 18:28:53
| -7,200
|
183518733e857436f1eac3020a4fecc3acd513f7
|
fix: check if bindLabel exist while searching for selected items
|
[
{
"change_type": "MODIFY",
"diff": "@@ -52,7 +52,7 @@ export class ItemsList {\n}\nconst index = this.items.findIndex(x => x.value === value);\nreturn index > -1 ? this.items[index] :\n- this.items.find(item => item.label === this.resolveNested(value, this._bindLabel))\n+ this.items.find(item => item.label && item.label === this.resolveNested(value, this._bindLabel));\n}\nunselect(item: NgOption) {\n",
"new_path": "src/ng-select/items-list.ts",
"old_path": "src/ng-select/items-list.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -99,11 +99,28 @@ describe('NgSelectComponent', function () {\nfixture.componentInstance.cities = cities;\ntickAndDetectChanges(fixture);\n- expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining(\n- {\n+ expect(fixture.componentInstance.select.selectedItems).toEqual([jasmine.objectContaining({\nvalue: cities[0]\n- }\n- )]);\n+ })]);\n+ }));\n+\n+ it('should set items correctly if there is no bindLabel', fakeAsync(() => {\n+ const fixture = createTestingModule(\n+ NgSelectModelChangesTestCmp,\n+ `<ng-select\n+ [items]=\"cities\"\n+ [clearable]=\"true\"\n+ [(ngModel)]=\"selectedCity\">\n+ </ng-select>`);\n+\n+ const cities = [{ id: 7, name: 'Pailgis' }];\n+ fixture.componentInstance.selectedCity = { id: 7, name: 'Pailgis' };\n+ tickAndDetectChanges(fixture);\n+ fixture.componentInstance.cities = [{ id: 1, name: 'Vilnius' }, { id: 2, name: 'Kaunas' }];\n+ tickAndDetectChanges(fixture);\n+ expect(fixture.componentInstance.select.selectedItems[0]).toEqual(jasmine.objectContaining({\n+ value: cities[0]\n+ }));\n}));\nit('should bind ngModel even if items are empty', fakeAsync(() => {\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: check if bindLabel exist while searching for selected items
#177
| 1
|
fix
| null |
815,745
|
09.01.2018 18:39:47
| -7,200
|
249d6c46ebf235a619aeff44736cd9b9b84d3b82
|
chore(release): 0.14.3
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.14.3\"></a>\n+## [0.14.3](https://github.com/ng-select/ng-select/compare/v0.14.2...v0.14.3) (2018-01-09)\n+\n+\n+### Bug Fixes\n+\n+* check if bindLabel exist while searching for selected items ([1835187](https://github.com/ng-select/ng-select/commit/1835187))\n+\n+\n+\n<a name=\"0.14.2\"></a>\n## [0.14.2](https://github.com/ng-select/ng-select/compare/v0.14.1...v0.14.2) (2018-01-06)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.14.2\",\n+ \"version\": \"0.14.3\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.14.3
| 1
|
chore
|
release
|
791,676
|
09.01.2018 20:49:46
| -3,600
|
6c5e7a4fcea53d9e708c0bdfbde10c1366a8e37a
|
deps(chrome-launcher): Upgrade chrome-launcher to 0.10.2
|
[
{
"change_type": "MODIFY",
"diff": "\"jsdom\": \"^9.12.0\",\n\"mocha\": \"^3.2.0\",\n\"npm-run-posix-or-windows\": \"^2.0.2\",\n- \"typescript\": \"^2.6.1\",\n\"sinon\": \"^2.3.5\",\n+ \"typescript\": \"^2.6.1\",\n\"zone.js\": \"^0.7.3\"\n},\n\"dependencies\": {\n\"axe-core\": \"2.6.1\",\n\"chrome-devtools-frontend\": \"1.0.422034\",\n- \"chrome-launcher\": \"0.8.1\",\n+ \"chrome-launcher\": \"^0.10.2\",\n\"configstore\": \"^3.1.1\",\n\"devtools-timeline-model\": \"1.1.6\",\n\"esprima\": \"^4.0.0\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "version \"0.3.29\"\nresolved \"https://registry.yarnpkg.com/@types/mkdirp/-/mkdirp-0.3.29.tgz#7f2ad7ec55f914482fc9b1ec4bb1ae6028d46066\"\n-\"@types/node@*\", \"@types/node@6.0.66\":\n+\"@types/node@*\", \"@types/node@^9.3.0\":\nversion \"8.0.49\"\nresolved \"https://registry.yarnpkg.com/@types/node/-/node-8.0.49.tgz#417f86ab4829c629fe561779ee48751e0fe2a11b\"\n@@ -656,13 +656,13 @@ chrome-devtools-frontend@1.0.422034:\nversion \"1.0.422034\"\nresolved \"https://registry.yarnpkg.com/chrome-devtools-frontend/-/chrome-devtools-frontend-1.0.422034.tgz#071c8ce14466b7653032fcd1ad1a4a68d5e3cbd9\"\n-chrome-launcher@0.8.1:\n- version \"0.8.1\"\n- resolved \"https://registry.yarnpkg.com/chrome-launcher/-/chrome-launcher-0.8.1.tgz#e275b738376d294b3228dc32caf3ed7ee0405e57\"\n+chrome-launcher@^0.10.2:\n+ version \"0.10.2\"\n+ resolved \"https://registry.yarnpkg.com/chrome-launcher/-/chrome-launcher-0.10.2.tgz#f7d860ddec627b6f01015736b5ae1e33b3d165b1\"\ndependencies:\n\"@types/core-js\" \"^0.9.41\"\n\"@types/mkdirp\" \"^0.3.29\"\n- \"@types/node\" \"6.0.66\"\n+ \"@types/node\" \"^9.3.0\"\n\"@types/rimraf\" \"^0.0.28\"\nis-wsl \"^1.1.0\"\nlighthouse-logger \"^1.0.0\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
deps(chrome-launcher): Upgrade chrome-launcher to 0.10.2 (#4192)
| 1
|
deps
|
chrome-launcher
|
807,889
|
10.01.2018 03:32:20
| -28,800
|
417e67deb7282ea368a4211ed2a728467143675a
|
docs: replace "command" with "commands" to avoid ambiguity
[skip ci]
|
[
{
"change_type": "MODIFY",
"diff": "@@ -173,7 +173,7 @@ It will configure `lerna.json` to enforce exact match for all subsequent executi\n```json\n{\n\"lerna\": \"2.0.0\",\n- \"command\": {\n+ \"commands\": {\n\"init\": {\n\"exact\": true\n}\n@@ -479,7 +479,7 @@ Note that this only applies when using the default \"fixed\" versioning mode, as t\nThis can be configured in lerna.json, as well:\n```json\n{\n- \"command\": {\n+ \"commands\": {\n\"publish\": {\n\"message\": \"chore(release): publish %s\"\n}\n@@ -495,7 +495,7 @@ If your `lerna.json` contains something like this:\n```json\n{\n- \"command\": {\n+ \"commands\": {\n\"publish\": {\n\"allowBranch\": \"master\"\n}\n@@ -791,7 +791,7 @@ Example:\n\"lerna\": \"x.x.x\",\n\"version\": \"1.2.0\",\n\"exampleOption\": \"foo\",\n- \"command\": {\n+ \"commands\": {\n\"init\": {\n\"exampleOption\": \"bar\",\n}\n",
"new_path": "README.md",
"old_path": "README.md"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
docs: replace "command" with "commands" to avoid ambiguity (#1164)
[skip ci]
| 1
|
docs
| null |
791,723
|
10.01.2018 14:06:17
| 28,800
|
fcfe7eb1fd06140e247cd887e861df0028185393
|
core(plugins): minor wording tweaks to avoid-plugins
|
[
{
"change_type": "MODIFY",
"diff": "@@ -67,10 +67,10 @@ class Plugins extends Audit {\nstatic get meta() {\nreturn {\nname: 'plugins',\n- description: 'Document avoids plugins.',\n+ description: 'Document avoids plugins',\nfailureDescription: 'Document uses plugins',\n- helpText: 'Some types of media or content are not playable on mobile devices. ' +\n- '[Learn more](https://developers.google.com/speed/docs/insights/AvoidPlugins).',\n+ helpText: 'Most mobile devices do not support plugins, and many desktop browsers restrict ' +\n+ 'them.',\nrequiredArtifacts: ['EmbeddedContent'],\n};\n}\n@@ -132,7 +132,7 @@ class Plugins extends Audit {\n});\nconst headings = [\n- {key: 'source', itemType: 'code', text: 'Source'},\n+ {key: 'source', itemType: 'code', text: 'Element source'},\n];\nconst details = Audit.makeTableDetails(headings, plugins);\n",
"new_path": "lighthouse-core/audits/seo/plugins.js",
"old_path": "lighthouse-core/audits/seo/plugins.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(plugins): minor wording tweaks to avoid-plugins
| 1
|
core
|
plugins
|
791,723
|
10.01.2018 14:08:47
| 28,800
|
d713e44f143e54844f61e6f7dc4173d917dcc2de
|
tests: remove global timeout, set timeouts individually
|
[
{
"change_type": "MODIFY",
"diff": "@@ -14,6 +14,7 @@ const WebInspector = require('../web-inspector');\n* streaming JSON parser.\n* The resulting trace doesn't include the \"metadata\" property, as it's excluded via DevTools'\n* implementation.\n+ * FIXME: This can be removed once Node 8 support is dropped. https://stackoverflow.com/a/47781288/89484\n*/\nclass TraceParser {\nconstructor() {\n",
"new_path": "lighthouse-core/lib/traces/trace-parser.js",
"old_path": "lighthouse-core/lib/traces/trace-parser.js"
},
{
"change_type": "MODIFY",
"diff": "flag=$1\nfunction _runmocha() {\n- mocha --reporter dot $2 $(find $1/test -name '*-test.js') --timeout 60000;\n+ mocha --reporter dot $2 $(find $1/test -name '*-test.js');\n}\nif [ \"$flag\" == '--watch' ]; then\n",
"new_path": "lighthouse-core/scripts/run-mocha.sh",
"old_path": "lighthouse-core/scripts/run-mocha.sh"
},
{
"change_type": "MODIFY",
"diff": "@@ -43,7 +43,7 @@ describe('Performance: bootup-time audit', () => {\nassert.deepEqual(roundedValueOf('https://pwa.rocks/'), {[groupIdToName.parseHTML]: 14.2, [groupIdToName.scripting]: 6.1, [groupIdToName.scriptParseCompile]: 1.2});\nassert.deepEqual(roundedValueOf('https://pwa.rocks/0ff789bf.js'), {[groupIdToName.parseHTML]: 0});\n});\n- });\n+ }).timeout(10000);\nit('should get no data when no events are present', () => {\nconst artifacts = Object.assign({\n",
"new_path": "lighthouse-core/test/audits/bootup-time-test.js",
"old_path": "lighthouse-core/test/audits/bootup-time-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -63,7 +63,7 @@ describe('Screenshot thumbnails', () => {\nassert.equal(results.details.items[9].timing, 818);\nassert.equal(results.details.items[0].timestamp, 225414253815);\n});\n- });\n+ }).timeout(10000);\nit('should scale the timeline to TTFI', () => {\nconst artifacts = Object.assign({\n",
"new_path": "lighthouse-core/test/audits/screenshot-thumbnails-test.js",
"old_path": "lighthouse-core/test/audits/screenshot-thumbnails-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -49,7 +49,7 @@ describe('Performance: speed-index-metric audit', () => {\nassert.equal(Math.round(result.extendedInfo.value.timings.visuallyComplete), 1105);\nassert.equal(Math.round(result.extendedInfo.value.timings.perceptualSpeedIndex), 609);\n});\n- });\n+ }).timeout(10000);\nit('throws an error if no frames', () => {\nconst artifacts = mockArtifactsWithSpeedlineResult({frames: []});\n",
"new_path": "lighthouse-core/test/audits/speed-index-metric-test.js",
"old_path": "lighthouse-core/test/audits/speed-index-metric-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -77,5 +77,5 @@ describe('DTM Model gatherer', () => {\nassert.deepStrictEqual(pwaTrace[i], freshTrace[i]);\n}\n});\n- });\n+ }).timeout(20000);\n});\n",
"new_path": "lighthouse-core/test/gather/computed/dtm-model-test.js",
"old_path": "lighthouse-core/test/gather/computed/dtm-model-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -34,14 +34,14 @@ describe('Speedline gatherer', () => {\nassert.equal(speedline.speedIndex, undefined);\nassert.equal(Math.floor(speedline.perceptualSpeedIndex), 609);\n});\n- });\n+ }).timeout(10000);\nit('measures SI of 3 frame trace (blank @1s, content @2s, more content @3s)', () => {\nreturn computedArtifacts.requestSpeedline(threeFrameTrace).then(speedline => {\nassert.equal(speedline.speedIndex, undefined);\nassert.equal(Math.floor(speedline.perceptualSpeedIndex), 2030);\n});\n- });\n+ }).timeout(10000);\nit('uses a cache', () => {\nlet start;\n@@ -62,7 +62,7 @@ describe('Speedline gatherer', () => {\nreturn assert.equal(Math.floor(speedline.perceptualSpeedIndex), 609);\n});\n- });\n+ }).timeout(10000);\nit('does not change order of events in traces', () => {\n// Use fresh trace in case it has been altered by other require()s.\n@@ -78,5 +78,5 @@ describe('Speedline gatherer', () => {\nassert.deepStrictEqual(pwaTrace[i], freshTrace[i]);\n}\n});\n- });\n+ }).timeout(10000);\n});\n",
"new_path": "lighthouse-core/test/gather/computed/speedline-test.js",
"old_path": "lighthouse-core/test/gather/computed/speedline-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -124,7 +124,7 @@ describe('asset-saver helper', () => {\nconst traceEventsFromDisk = JSON.parse(traceFileContents).traceEvents;\nassertTraceEventsEqual(traceEventsFromDisk, fullTraceObj.traceEvents);\n});\n- });\n+ }).timeout(10000);\nit('correctly saves a trace with no trace events to disk', () => {\nconst trace = {\n@@ -186,6 +186,6 @@ describe('asset-saver helper', () => {\nconst fileStats = fs.lstatSync(traceFilename);\nassert.ok(fileStats.size > Math.pow(2, 28));\n});\n- });\n+ }).timeout(40 * 1000);\n});\n});\n",
"new_path": "lighthouse-core/test/lib/asset-saver-test.js",
"old_path": "lighthouse-core/test/lib/asset-saver-test.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -35,7 +35,7 @@ describe('traceParser parser', () => {\ndone();\n});\n- });\n+ }).timeout(10000);\nit('parses a trace > 256mb (slow)', () => {\n@@ -89,5 +89,5 @@ describe('traceParser parser', () => {\nassert.deepStrictEqual(\nstreamedTrace.traceEvents[events.length - 2],\nevents[0]);\n- });\n+ }).timeout(40 * 1000);\n});\n",
"new_path": "lighthouse-core/test/lib/traces/trace-parser-test.js",
"old_path": "lighthouse-core/test/lib/traces/trace-parser-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
tests: remove global timeout, set timeouts individually (#4224)
| 1
|
tests
| null |
791,811
|
10.01.2018 16:26:35
| 28,800
|
fc5c9d75d0d5e0df88db6c2b08fb624e516fcb5d
|
docs: demo flags in example of programmatic use
|
[
{
"change_type": "MODIFY",
"diff": "@@ -11,20 +11,23 @@ assumes you've installed Lighthouse as a dependency (`yarn add --dev lighthouse`\nconst lighthouse = require('lighthouse');\nconst chromeLauncher = require('chrome-launcher');\n-function launchChromeAndRunLighthouse(url, flags = {}, config = null) {\n- return chromeLauncher.launch().then(chrome => {\n- flags.port = chrome.port;\n- return lighthouse(url, flags, config).then(results =>\n+function launchChromeAndRunLighthouse(url, opts, config = null) {\n+ return chromeLauncher.launch({chromeFlags: opts.chromeFlags}).then(chrome => {\n+ opts.port = chrome.port;\n+ return lighthouse(url, opts, config).then(results =>\nchrome.kill().then(() => results));\n});\n}\n-const flags = {};\n+const opts = {\n+ chromeFlags: ['--show-paint-rects']\n+};\n// Usage:\n-launchChromeAndRunLighthouse('https://example.com', flags).then(results => {\n+launchChromeAndRunLighthouse('https://example.com', opts).then(results => {\n// Use results!\n});\n+\n```\n### Performance-only Lighthouse run\n",
"new_path": "docs/readme.md",
"old_path": "docs/readme.md"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
docs: demo flags in example of programmatic use (#3841)
| 1
|
docs
| null |
807,849
|
10.01.2018 18:01:25
| 28,800
|
563b5384aac985975c686d2e3537b3c28e6950bd
|
chore: set NODE_ENV=test for tests, use fast-async instead of regenerator
|
[
{
"change_type": "MODIFY",
"diff": "\"add-module-exports\"\n],\n\"env\": {\n- \"lerna-test\": {\n+ \"test\": {\n\"presets\": [\n[\"env\", {\n+ \"exclude\": [\"transform-async-to-generator\", \"transform-regenerator\"],\n\"targets\": {\n\"node\": \"current\"\n}\n}]\n],\n\"plugins\": [\n+ [\"fast-async\", {\n+ \"compiler\": {\n+ \"noRuntime\": true\n+ }\n+ }],\n\"add-module-exports\"\n]\n}\n",
"new_path": ".babelrc",
"old_path": ".babelrc"
},
{
"change_type": "MODIFY",
"diff": "\"dev\": \"babel -w src -d lib\",\n\"fix\": \"npm run lint -- --fix\",\n\"preintegration\": \"npm pack\",\n- \"integration\": \"cross-env LC_ALL=en-US jest --config test/config/integration.json\",\n+ \"integration\": \"cross-env LC_ALL=en-US NODE_ENV=test jest --config test/config/integration.json\",\n\"lint\": \"eslint . --ignore-path .gitignore --cache\",\n\"prepublish\": \"npm run build\",\n\"pretest\": \"npm run lint\",\n- \"test\": \"cross-env LC_ALL=en-US jest\",\n- \"test:watch\": \"cross-env LC_ALL=en-US jest --watchAll --no-watchman\",\n+ \"test\": \"cross-env LC_ALL=en-US NODE_ENV=test jest\",\n+ \"test:watch\": \"cross-env LC_ALL=en-US NODE_ENV=test jest --watchAll --no-watchman\",\n\"test:watch-integration\": \"npm run integration -- --watchAll --no-watchman\"\n},\n\"repository\": {\n\"eslint-plugin-jest\": \"^21.6.1\",\n\"eslint-plugin-node\": \"^5.1.1\",\n\"eslint-plugin-prettier\": \"^2.4.0\",\n+ \"fast-async\": \"^6.3.0\",\n\"file-url\": \"^2.0.2\",\n\"jest\": \"^19.0.2\",\n\"normalize-newline\": \"^3.0.0\",\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "MODIFY",
"diff": "@@ -17,6 +17,10 @@ abbrev@1:\nversion \"1.0.9\"\nresolved \"https://registry.yarnpkg.com/abbrev/-/abbrev-1.0.9.tgz#91b4792588a7738c25f35dd6f63752a2f8776135\"\n+acorn-es7-plugin@>=1.1.6:\n+ version \"1.1.7\"\n+ resolved \"https://registry.yarnpkg.com/acorn-es7-plugin/-/acorn-es7-plugin-1.1.7.tgz#f2ee1f3228a90eead1245f9ab1922eb2e71d336b\"\n+\nacorn-globals@^3.1.0:\nversion \"3.1.0\"\nresolved \"https://registry.yarnpkg.com/acorn-globals/-/acorn-globals-3.1.0.tgz#fd8270f71fbb4996b004fa880ee5d46573a731bf\"\n@@ -29,6 +33,10 @@ acorn-jsx@^3.0.0:\ndependencies:\nacorn \"^3.0.4\"\n+acorn@>=2.5.2, acorn@^5.2.1:\n+ version \"5.3.0\"\n+ resolved \"https://registry.yarnpkg.com/acorn/-/acorn-5.3.0.tgz#7446d39459c54fb49a80e6ee6478149b940ec822\"\n+\nacorn@^3.0.4:\nversion \"3.3.0\"\nresolved \"https://registry.yarnpkg.com/acorn/-/acorn-3.3.0.tgz#45e37fb39e8da3f25baee3ff5369e2bb5f22017a\"\n@@ -37,10 +45,6 @@ acorn@^4.0.4:\nversion \"4.0.13\"\nresolved \"https://registry.yarnpkg.com/acorn/-/acorn-4.0.13.tgz#105495ae5361d697bd195c825192e1ad7f253787\"\n-acorn@^5.2.1:\n- version \"5.3.0\"\n- resolved \"https://registry.yarnpkg.com/acorn/-/acorn-5.3.0.tgz#7446d39459c54fb49a80e6ee6478149b940ec822\"\n-\nadd-stream@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/add-stream/-/add-stream-1.0.0.tgz#6a7990437ca736d5e1288db92bd3266d5f5cb2aa\"\n@@ -1618,6 +1622,13 @@ extsprintf@1.3.0, extsprintf@^1.2.0:\nversion \"1.3.0\"\nresolved \"https://registry.yarnpkg.com/extsprintf/-/extsprintf-1.3.0.tgz#96918440e3041a7a414f8c52e3c574eb3c3e1e05\"\n+fast-async@^6.3.0:\n+ version \"6.3.0\"\n+ resolved \"https://registry.yarnpkg.com/fast-async/-/fast-async-6.3.0.tgz#b90e7d68f273905878a76ab7047dd080ebc3c40f\"\n+ dependencies:\n+ nodent-compiler \">=3.1.0\"\n+ nodent-runtime \">=3.0.4\"\n+\nfast-deep-equal@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-1.0.0.tgz#96256a3bc975595eb36d82e9929d060d893439ff\"\n@@ -2940,6 +2951,18 @@ node-pre-gyp@^0.6.36:\ntar \"^2.2.1\"\ntar-pack \"^3.4.0\"\n+nodent-compiler@>=3.1.0:\n+ version \"3.1.5\"\n+ resolved \"https://registry.yarnpkg.com/nodent-compiler/-/nodent-compiler-3.1.5.tgz#8c09289eacf7256bda89c2b88941681d5cccf80c\"\n+ dependencies:\n+ acorn \">=2.5.2\"\n+ acorn-es7-plugin \">=1.1.6\"\n+ source-map \"^0.5.6\"\n+\n+nodent-runtime@>=3.0.4:\n+ version \"3.2.0\"\n+ resolved \"https://registry.yarnpkg.com/nodent-runtime/-/nodent-runtime-3.2.0.tgz#8b79500a1274176d732b60284c7a7d10d9e44180\"\n+\nnopt@^4.0.1:\nversion \"4.0.1\"\nresolved \"https://registry.yarnpkg.com/nopt/-/nopt-4.0.1.tgz#d0d4685afd5415193c8c7505602d0d17cd64474d\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: set NODE_ENV=test for tests, use fast-async instead of regenerator
| 1
|
chore
| null |
791,723
|
10.01.2018 18:42:59
| 28,800
|
5e77732968befefba9bb1ce921426c84fb7012fe
|
tests(bootup): fix line-length linting error
|
[
{
"change_type": "MODIFY",
"diff": "@@ -39,7 +39,8 @@ describe('Performance: bootup-time audit', () => {\nassert.deepEqual(roundedValueOf('https://www.google-analytics.com/plugins/ua/linkid.js'), {[groupIdToName.scripting]: 25.2, [groupIdToName.scriptParseCompile]: 1.2});\nassert.deepEqual(roundedValueOf('https://www.google-analytics.com/analytics.js'), {[groupIdToName.scripting]: 40.1, [groupIdToName.scriptParseCompile]: 9.6, [groupIdToName.styleLayout]: 0.2});\n- assert.ok(output.details.items.length < Object.keys(output.extendedInfo.value).length, 'Items below 10ms threshold were not filtered out');\n+ assert.ok(output.details.items.length < Object.keys(output.extendedInfo.value).length,\n+ 'Items below 10ms threshold were not filtered out');\n});\n}).timeout(10000);\n",
"new_path": "lighthouse-core/test/audits/bootup-time-test.js",
"old_path": "lighthouse-core/test/audits/bootup-time-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
tests(bootup): fix line-length linting error
| 1
|
tests
|
bootup
|
448,074
|
10.01.2018 22:29:53
| -3,600
|
616888af1a3578c0586ec316fd0ae4c309af82fd
|
feat: turn on `downlevelIteration` flag for ES5 bundles
Closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -34,5 +34,12 @@ describe(`@sample/core`, () => {\nexpect(API.AngularService).to.be.ok;\n});\n+ it (`should downlevel iteration`, () => {\n+ const iterable = function*() { yield* [1, 2, 3]; };\n+ const values = API.AngularService.iterableToArray(iterable());\n+\n+ expect(values).to.deep.equal([1, 2, 3]);\n+ });\n+\n});\n});\n",
"new_path": "integration/samples/core/specs/es5-api.ts",
"old_path": "integration/samples/core/specs/es5-api.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -50,5 +50,12 @@ describe(`@sample/core`, () => {\nexpect(API.AngularService).to.be.ok;\n});\n+ it (`should downlevel iteration`, () => {\n+ const iterable = function*() { yield* [1, 2, 3]; };\n+ const values = API.AngularService.iterableToArray(iterable());\n+\n+ expect(values).to.deep.equal([1, 2, 3]);\n+ });\n+\n});\n});\n",
"new_path": "integration/samples/core/specs/umd.ts",
"old_path": "integration/samples/core/specs/umd.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -27,4 +27,8 @@ export class AngularService {\nreturn this._subject.asObservable();\n}\n+ public static iterableToArray<T>(iterable: Iterable<T>): T[] {\n+ return [...iterable];\n+ }\n+\n}\n",
"new_path": "integration/samples/core/src/angular.service.ts",
"old_path": "integration/samples/core/src/angular.service.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -24,6 +24,7 @@ export async function downlevelWithTsc(inputFile: string, outputFile: string): P\nmodule: ModuleKind.ES2015,\nallowJs: true,\nsourceMap: true,\n+ downlevelIteration: true,\nmapRoot: path.dirname(inputFile)\n};\nconst transpiled: TranspileOutput = transpileModule(trimSourceMap(input.toString()), {\n",
"new_path": "src/lib/steps/tsc.ts",
"old_path": "src/lib/steps/tsc.ts"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
feat: turn on `downlevelIteration` flag for ES5 bundles (#475)
Closes #418
| 1
|
feat
| null |
791,676
|
11.01.2018 00:55:43
| -3,600
|
5b0ece826be4b67c5dd15deb9c7173f083b2e57c
|
core(audit): Add 10ms threshold to bootup-time audits
|
[
{
"change_type": "MODIFY",
"diff": "@@ -9,6 +9,7 @@ const Audit = require('./audit');\nconst WebInspector = require('../lib/web-inspector');\nconst Util = require('../report/v2/renderer/util');\nconst {groupIdToName, taskToGroup} = require('../lib/task-groups');\n+const THRESHOLD_IN_MS = 10;\nclass BootupTime extends Audit {\n/**\n@@ -73,7 +74,8 @@ class BootupTime extends Audit {\n];\n// map data in correct format to create a table\n- const results = Array.from(executionTimings).map(([url, groups]) => {\n+ const results = Array.from(executionTimings)\n+ .map(([url, groups]) => {\n// Add up the totalBootupTime for all the taskGroups\ntotalBootupTime += Object.keys(groups).reduce((sum, name) => sum += groups[name], 0);\nextendedInfo[url] = groups;\n@@ -88,7 +90,9 @@ class BootupTime extends Audit {\nscripting: Util.formatMilliseconds(scriptingTotal, 1),\nscriptParseCompile: Util.formatMilliseconds(parseCompileTotal, 1),\n};\n- }).sort((a, b) => b.sum - a.sum);\n+ })\n+ .filter(result => result.sum >= THRESHOLD_IN_MS)\n+ .sort((a, b) => b.sum - a.sum);\nconst tableDetails = BootupTime.makeTableDetails(headings, results);\n",
"new_path": "lighthouse-core/audits/bootup-time.js",
"old_path": "lighthouse-core/audits/bootup-time.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -23,7 +23,7 @@ describe('Performance: bootup-time audit', () => {\n}, Runner.instantiateComputedArtifacts());\nreturn BootupTime.audit(artifacts).then(output => {\n- assert.equal(output.details.items.length, 8);\n+ assert.equal(output.details.items.length, 4);\nassert.equal(output.score, true);\nassert.equal(Math.round(output.rawValue), 176);\n@@ -34,14 +34,12 @@ describe('Performance: bootup-time audit', () => {\nreturn roundedValue;\n};\n- assert.deepEqual(roundedValueOf('https://www.google-analytics.com/analytics.js'), {[groupIdToName.scripting]: 40.1, [groupIdToName.scriptParseCompile]: 9.6, [groupIdToName.styleLayout]: 0.2});\nassert.deepEqual(roundedValueOf('https://pwa.rocks/script.js'), {[groupIdToName.scripting]: 31.8, [groupIdToName.styleLayout]: 5.5, [groupIdToName.scriptParseCompile]: 1.3});\nassert.deepEqual(roundedValueOf('https://www.googletagmanager.com/gtm.js?id=GTM-Q5SW'), {[groupIdToName.scripting]: 25, [groupIdToName.scriptParseCompile]: 5.5, [groupIdToName.styleLayout]: 1.2});\nassert.deepEqual(roundedValueOf('https://www.google-analytics.com/plugins/ua/linkid.js'), {[groupIdToName.scripting]: 25.2, [groupIdToName.scriptParseCompile]: 1.2});\n- assert.deepEqual(roundedValueOf('https://www.google-analytics.com/cx/api.js?experiment=jdCfRmudTmy-0USnJ8xPbw'), {[groupIdToName.scriptParseCompile]: 3, [groupIdToName.scripting]: 1.2});\n- assert.deepEqual(roundedValueOf('https://www.google-analytics.com/cx/api.js?experiment=qvpc5qIfRC2EMnbn6bbN5A'), {[groupIdToName.scriptParseCompile]: 2.5, [groupIdToName.scripting]: 1});\n- assert.deepEqual(roundedValueOf('https://pwa.rocks/'), {[groupIdToName.parseHTML]: 14.2, [groupIdToName.scripting]: 6.1, [groupIdToName.scriptParseCompile]: 1.2});\n- assert.deepEqual(roundedValueOf('https://pwa.rocks/0ff789bf.js'), {[groupIdToName.parseHTML]: 0});\n+ assert.deepEqual(roundedValueOf('https://www.google-analytics.com/analytics.js'), {[groupIdToName.scripting]: 40.1, [groupIdToName.scriptParseCompile]: 9.6, [groupIdToName.styleLayout]: 0.2});\n+\n+ assert.ok(output.details.items.length < Object.keys(output.extendedInfo.value).length, 'Items below 10ms threshold were not filtered out');\n});\n}).timeout(10000);\n",
"new_path": "lighthouse-core/test/audits/bootup-time-test.js",
"old_path": "lighthouse-core/test/audits/bootup-time-test.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
core(audit): Add 10ms threshold to bootup-time audits (#4223)
| 1
|
core
|
audit
|
448,030
|
11.01.2018 13:32:13
| -3,600
|
98911286f3b4a5c1418ccc6520f98a879c8f94ae
|
fix: escape unicode characters in css with a double blackslash
Closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -9,6 +9,9 @@ yarn-error.log*\n/.vs\n/.idea\n+# IDE files\n+*.iml\n+\n# Runtime data\npids\n*.pid\n",
"new_path": ".gitignore",
"old_path": ".gitignore"
},
{
"change_type": "MODIFY",
"diff": ".baz {\ncolor: $variable-defined-by-file-not-processed-by-loader;\n+ content: \"\\2014 \\00A0\";\n}\n",
"new_path": "integration/samples/material/baz/baz.component.scss",
"old_path": "integration/samples/material/baz/baz.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -38,6 +38,9 @@ describe(`@sample/material`, () => {\nit(`should have style with: \"color: red\"`, () => {\nexpect(METADATA['metadata'].BazComponent.decorators[0].arguments[0].styles[0]).to.have.string('color: \"red\"');\n});\n+ it(`should have style with: \"content: \\\\2014 \\\\00A0\"`, () => {\n+ expect(METADATA['metadata'].BazComponent.decorators[0].arguments[0].styles[0]).to.have.string('content: \"\\\\2014 \\\\00A0\"');\n+ });\n});\n});\n",
"new_path": "integration/samples/material/specs/metadata.ts",
"old_path": "integration/samples/material/specs/metadata.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -89,6 +89,9 @@ const processStylesheet =\nto: stylesheetFilePath.replace(path.extname(stylesheetFilePath), '.css')\n});\n+ // Escape existing backslashes for the final output into a string literal, which would otherwise escape the character after it\n+ result.css = result.css.replace(/\\\\/g, '\\\\\\\\');\n+\n// Log warnings from postcss\nresult.warnings().forEach((msg) => {\nlog.warn(msg.toString());\n",
"new_path": "src/lib/steps/assets.ts",
"old_path": "src/lib/steps/assets.ts"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
fix: escape unicode characters in css with a double blackslash (#453)
Closes #425
| 1
|
fix
| null |
135,556
|
12.01.2018 02:43:32
| 21,600
|
1f0c5ca4eaa9647a3567f4a252138284e197f631
|
fix: ignore branch merges with multiple newlines
|
[
{
"change_type": "MODIFY",
"diff": "@@ -3,7 +3,7 @@ import semver from 'semver';\nconst WILDCARDS = [\nc =>\nc.match(\n- /^(Merge pull request)|(Merge (.*?) into (.*?)|(Merge branch (.*?))(?:\\r?\\n)?$)/\n+ /^(Merge pull request)|(Merge (.*?) into (.*?)|(Merge branch (.*?))(?:\\r?\\n)*$)/\n),\nc => c.match(/^(R|r)evert (.*)/),\nc => c.match(/^(fixup|squash)!/),\n",
"new_path": "@commitlint/is-ignored/src/index.js",
"old_path": "@commitlint/is-ignored/src/index.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -52,6 +52,11 @@ test('should return true for branch merges with newline characters', t => {\nt.true(isIgnored(\"Merge branch 'ctrom-YarnBuild'\\r\\n\"));\n});\n+test('should return true for branch merges with multiple newline characters', t => {\n+ t.true(isIgnored(\"Merge branch 'ctrom-YarnBuild'\\n\\n\\n\"));\n+ t.true(isIgnored(\"Merge branch 'ctrom-YarnBuild'\\r\\n\\r\\n\\r\\n\"));\n+});\n+\ntest('should return true for merged PRs', t => {\nt.true(isIgnored('Merge pull request #369'));\n});\n",
"new_path": "@commitlint/is-ignored/src/index.test.js",
"old_path": "@commitlint/is-ignored/src/index.test.js"
}
] |
TypeScript
|
MIT License
|
conventional-changelog/commitlint
|
fix: ignore branch merges with multiple newlines (#227)
| 1
|
fix
| null |
791,723
|
12.01.2018 10:01:46
| 28,800
|
55354e64037c8b387024636fae89f65903f1ce13
|
report: improve devtools dark mode rendering
|
[
{
"change_type": "MODIFY",
"diff": "--navitem-line-height: var(--body-line-height);\n--navitem-hpadding: var(--body-font-size);\n--navitem-vpadding: calc(var(--navitem-line-height) / 2);\n- --lh-score-highlight-bg: #fafafa;\n+ --lh-score-highlight-bg: hsla(0, 0%, 90%, 0.2);\n--lh-score-icon-background-size: 24px;\n--lh-score-margin: 12px;\n- --lh-table-header-bg: #ccc;\n- --lh-table-higlight-bg: #fafafa;\n+ --lh-table-header-bg: hsla(0, 0%, 50%, 0.4);\n+ --lh-table-higlight-bg: hsla(0, 0%, 75%, 0.1);\n--lh-sparkline-height: 5px;\n--lh-sparkline-thin-height: 3px;\n--lh-filmstrip-thumbnail-width: 60px;\n",
"new_path": "lighthouse-core/report/v2/report-styles.css",
"old_path": "lighthouse-core/report/v2/report-styles.css"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
report: improve devtools dark mode rendering (#4232)
| 1
|
report
| null |
791,723
|
12.01.2018 14:13:05
| 28,800
|
16133efb31b286acfd14cbbe86558577c605dad6
|
extension(devtools): restore listenForStatus method for devtools build
|
[
{
"change_type": "MODIFY",
"diff": "@@ -63,3 +63,7 @@ window.runLighthouseInWorker = function(port, url, options, categoryIDs) {\nwindow.getDefaultCategories = function() {\nreturn Config.getCategories(defaultConfig);\n};\n+\n+window.listenForStatus = function(listenCallback) {\n+ log.events.addListener('status', listenCallback);\n+};\n",
"new_path": "lighthouse-extension/app/src/lighthouse-background.js",
"old_path": "lighthouse-extension/app/src/lighthouse-background.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
extension(devtools): restore listenForStatus method for devtools build (#4244)
| 1
|
extension
|
devtools
|
791,723
|
12.01.2018 14:49:37
| 28,800
|
db22c38285b4ebca65633ecaa4b3430c4e35e696
|
docs(releasing): add detail to release process
|
[
{
"change_type": "MODIFY",
"diff": "@@ -43,7 +43,7 @@ yarn build-all\n# * Test err'thing *\necho \"Test the CLI.\"\n-lighthouse --perf \"https://example.com\"\n+yarn start \"https://example.com\"\nyarn smoke\necho \"Test the extension\"\n@@ -52,7 +52,7 @@ echo \"Test the extension\"\necho \"Test a fresh local install\"\n# (starting from lighthouse root...)\n# npm pack\n-# cd ..; trash tmp; mkdir tmp; cd tmp\n+# cd ..; rm -rf tmp; mkdir tmp; cd tmp\n# npm init -y\n# npm install ../lighthouse/lighthouse-<version>.tgz\n# npm explore lighthouse -- npm run smoke\n@@ -61,6 +61,8 @@ echo \"Test a fresh local install\"\n# npm explore lighthouse -- npm run fast -- http://example.com\n# cd ..; rm -rf ./tmp;\n+# delete that lighthouse-<version>.tgz\n+\necho \"Test the lighthouse-viewer build\"\n# Manual test for now:\n# Start a server in lighthouse-viewer/dist/ and open the page in a tab. You should see the viewer.\n@@ -82,6 +84,7 @@ echo \"Generate a PR and get it merged.\"\n# * Deploy-time *\ncd lighthouse-extension; gulp package; cd ..\n+echo \"Go here: https://chrome.google.com/webstore/developer/edit/blipmdconlkpinefehnmjammfjpmpbjk \"\necho \"Upload the package zip to CWS dev dashboard\"\necho \"Verify the npm package won't include unncessary files\"\n",
"new_path": "docs/releasing.md",
"old_path": "docs/releasing.md"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
docs(releasing): add detail to release process (#4246)
| 1
|
docs
|
releasing
|
448,079
|
15.01.2018 00:21:20
| 28,800
|
b33e0bcc43fc16429af37be32666c9d1ef449e5b
|
feat: add language level support for library authors
|
[
{
"change_type": "MODIFY",
"diff": "@@ -191,6 +191,21 @@ For example, the following would use `index.ts` as the secondary entry point:\n}\n```\n+##### How do I use es2016 or es2017 features in my TypeScript library?\n+\n+You can change the TypeScript language level support in tsconfig by also using the `ngPackage` configuration field in your secondary `package.json` and setting the `languageLevel` property in `lib`:\n+For example,:\n+\n+```json\n+{\n+ \"ngPackage\": {\n+ \"lib\": {\n+ \"languageLevel\": [ \"dom\", \"es2017\" ]\n+ }\n+ }\n+}\n+```\n+\n#### How to embed assets in CSS?\nYou can embed assets such as font and images inside the outputted css. More information [in the CSS tricks website](https://css-tricks.com/data-uris)\n",
"new_path": "README.md",
"old_path": "README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -153,6 +153,8 @@ If auto-generating a tsconfig, `ng-packagr` would need to read its default value\nThe most important setting here is the `\"files\": []` property, which must contain exactly one file since `\"flatModuleId\"` and `\"flatModuleOutFile\"` options will also be used for flattended library indexes.\nThe value for `\"flatModuleId\"` could be inferred by the library's name as given in `package.json`, `\"flatModuleOutFile\"` could be statically set to `\"index\"`.\n+The `\"lib\"` property that denotes TypeScript language level support can be overriden through a `lib.languageLevel` property in `ng-package.json`.\n+\nOther configuration properties like `\"target\"` or `\"module\"` cannot be set by users since the order of transformations relies on certain settings.\nFor example, `ngc` will need to compile to `\"target\": \"es2015\"` and `\"module\": \"es2015\"` in order to allow subsequent steps to happen.\n",
"new_path": "docs/DESIGN.md",
"old_path": "docs/DESIGN.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@sample/embed-assets\",\n- \"description\": \"A sample library with embeded css assets\",\n+ \"description\": \"A sample library with embedded css assets\",\n\"version\": \"1.0.0-pre.0\",\n\"private\": true,\n\"repository\": \"https://github.com/dherges/ng-packagr.git\",\n",
"new_path": "integration/samples/embed-assets/package.json",
"old_path": "integration/samples/embed-assets/package.json"
},
{
"change_type": "ADD",
"diff": "+{\n+ \"$schema\": \"../../../src/ng-package.schema.json\",\n+ \"lib\": {\n+ \"entryFile\": \"public_api.ts\",\n+ \"languageLevel\": [\n+ \"dom\",\n+ \"es2017\"\n+ ]\n+ }\n+}\n",
"new_path": "integration/samples/language-level/ng-package.json",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+{\n+ \"name\": \"@sample/language-level\",\n+ \"description\": \"A sample library to test es2016/es2017 syntax in TypeScript\",\n+ \"version\": \"1.0.0-pre.0\",\n+ \"private\": true,\n+ \"repository\": \"https://github.com/dherges/ng-packagr.git\",\n+ \"peerDependencies\": {\n+ \"@angular/common\": \"^4.1.3\",\n+ \"@angular/core\": \"^4.1.3\",\n+ \"rxjs\": \"^5.0.1\",\n+ \"zone.js\": \"^0.8.4\"\n+ },\n+ \"scripts\": {\n+ \"test\": \"../../../node_modules/.bin/cross-env TS_NODE_PROJECT=../../../integration/tsconfig.specs.json ../../../node_modules/.bin/mocha --compilers ts:ts-node/register specs/**/*.ts\"\n+ }\n+}\n",
"new_path": "integration/samples/language-level/package.json",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+export * from './src/angular.component';\n+export * from './src/angular.module';\n",
"new_path": "integration/samples/language-level/public_api.ts",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import { Component } from '@angular/core';\n+\n+\n+@Component({\n+ selector: 'ng-component',\n+ template: '<h1>Angular!</h1>'\n+})\n+export class AngularComponent {\n+\n+ es2016Includes() {\n+ const arr = ['foo', 'bar'];\n+ arr.includes('foo');\n+ }\n+\n+ es2017String() {\n+ const str = 'abc';\n+ str.padStart(10); // \" abc\"\n+ str.padEnd(10); // \"abc \"\n+ }\n+}\n",
"new_path": "integration/samples/language-level/src/angular.component.ts",
"old_path": null
},
{
"change_type": "ADD",
"diff": "+import { NgModule } from '@angular/core';\n+import { CommonModule } from '@angular/common';\n+import { AngularComponent } from './angular.component';\n+@NgModule({\n+ imports: [\n+ CommonModule\n+ ],\n+ declarations: [\n+ AngularComponent\n+ ],\n+ providers: [\n+\n+ ]\n+})\n+export class AngularModule {}\n",
"new_path": "integration/samples/language-level/src/angular.module.ts",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -84,6 +84,10 @@ export class NgEntryPoint {\nreturn this.$get('lib.flatModuleFile') || this.flattenModuleId('-');\n}\n+ public get languageLevel(): string[] {\n+ return this.$get('lib.languageLevel');\n+ }\n+\n/**\n* The module ID is an \"identifier of a module used in the import statements, e.g.\n* '@angular/core'. The ID often maps directly to a path on the filesystem, but this\n",
"new_path": "src/lib/ng-package-format/entry-point.ts",
"old_path": "src/lib/ng-package-format/entry-point.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -26,7 +26,7 @@ export const prepareTsConfig: BuildStep =\n// Read the default configuration and overwrite package-specific options\nconst tsConfig = ng.readConfiguration(path.resolve(__dirname, '..', 'conf', 'tsconfig.ngc.json'));\ntsConfig.rootNames = [ entryPoint.entryFilePath ];\n- tsConfig.options.flatModuleId = entryPoint.moduleId\n+ tsConfig.options.flatModuleId = entryPoint.moduleId;\ntsConfig.options.flatModuleOutFile = `${entryPoint.flatModuleFile}.js`;\ntsConfig.options.basePath = basePath;\ntsConfig.options.baseUrl = basePath;\n@@ -34,6 +34,11 @@ export const prepareTsConfig: BuildStep =\ntsConfig.options.outDir = artefacts.outDir;\ntsConfig.options.genDir = artefacts.outDir;\n+ if (entryPoint.languageLevel) {\n+ // ng.readConfiguration implicitly converts \"es6\" to \"lib.es6.d.ts\", etc.\n+ tsConfig.options.lib = entryPoint.languageLevel.map(lib => `lib.${lib}.d.ts`);\n+ }\n+\nswitch (entryPoint.jsxConfig) {\ncase 'preserve':\ntsConfig.options.jsx = ts.JsxEmit.Preserve;\n",
"new_path": "src/lib/steps/ngc.ts",
"old_path": "src/lib/steps/ngc.ts"
},
{
"change_type": "MODIFY",
"diff": "\"inline\"\n],\n\"default\": \"none\"\n+ },\n+ \"languageLevel\": {\n+ \"description\": \"Set typescript language level, i.e. tsconfig.lib. This will enable accessing typescript features available in es2016, es2017, etc.\",\n+ \"type\": \"array\",\n+ \"items\": {\n+ \"type\": \"string\"\n+ },\n+ \"default\": [\n+ \"dom\",\n+ \"es2015\"\n+ ]\n}\n}\n}\n",
"new_path": "src/ng-package.schema.json",
"old_path": "src/ng-package.schema.json"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
feat: add language level support for library authors (#486)
| 1
|
feat
| null |
807,849
|
15.01.2018 20:41:58
| 28,800
|
4dabc7f5e1ab73065d93bf2e79166ccf1203eca2
|
fix: Pass --new-version to yarn when publishing
This avoids an unfortunate interactive prompt due to a questionable conflation of yarn's "version" and "publish" commands.
Fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -136,11 +136,21 @@ export default class NpmUtilities {\nChildProcessUtilities.spawnStreaming(npmClient, [\"run\", script, ...args], opts, pkg.name, callback);\n}\n- static publishTaggedInDir(tag, directory, { client = \"npm\", registry }, callback) {\n+ static publishTaggedInDir(tag, pkg, { npmClient, registry }, callback) {\n+ const directory = pkg.location;\n+\nlog.silly(\"publishTaggedInDir\", tag, path.basename(directory));\nconst opts = NpmUtilities.getExecOpts(directory, registry);\n- ChildProcessUtilities.exec(client, [\"publish\", \"--tag\", tag.trim()], opts, callback);\n+ const args = [\"publish\", \"--tag\", tag.trim()];\n+\n+ if (npmClient === \"yarn\") {\n+ // skip prompt for new version, use existing instead\n+ // https://yarnpkg.com/en/docs/cli/publish#toc-yarn-publish-new-version\n+ args.push(\"--new-version\", pkg.version);\n+ }\n+\n+ ChildProcessUtilities.exec(npmClient, args, opts, callback);\n}\nstatic getExecOpts(directory, registry) {\n",
"new_path": "src/NpmUtilities.js",
"old_path": "src/NpmUtilities.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -173,7 +173,7 @@ export default class PublishCommand extends Command {\nthis.gitEnabled = !(this.options.canary || this.options.skipGit);\nthis.npmConfig = {\n- client: this.options.npmClient || \"npm\",\n+ npmClient: this.options.npmClient || \"npm\",\nregistry: this.npmRegistry,\n};\n@@ -730,7 +730,7 @@ export default class PublishCommand extends Command {\nconst run = cb => {\ntracker.verbose(\"publishing\", pkg.name);\n- NpmUtilities.publishTaggedInDir(tag, pkg.location, this.npmConfig, err => {\n+ NpmUtilities.publishTaggedInDir(tag, pkg, this.npmConfig, err => {\n// FIXME: this err.stack conditional is too cute\nerr = (err && err.stack) || err; // eslint-disable-line no-param-reassign\n",
"new_path": "src/commands/PublishCommand.js",
"old_path": "src/commands/PublishCommand.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -210,35 +210,47 @@ describe(\"NpmUtilities\", () => {\ndescribe(\".publishTaggedInDir()\", () => {\nconst directory = \"/test/publishTaggedInDir\";\n+ const pkg = { name: \"test\", location: directory, version: \"1.10.100\" };\nconst callback = () => {};\nbeforeEach(stubExecOpts);\nafterEach(resetExecOpts);\nit(\"runs npm publish in a directory with --tag support\", () => {\n- NpmUtilities.publishTaggedInDir(\"published-tag\", directory, {}, callback);\n+ const npmClient = \"npm\";\n+ NpmUtilities.publishTaggedInDir(\"published-tag\", pkg, { npmClient }, callback);\n- const cmd = \"npm\";\nconst args = [\"publish\", \"--tag\", \"published-tag\"];\nconst opts = { directory, registry: undefined };\n- expect(ChildProcessUtilities.exec).lastCalledWith(cmd, args, opts, expect.any(Function));\n+ expect(ChildProcessUtilities.exec).lastCalledWith(npmClient, args, opts, expect.any(Function));\n});\nit(\"trims trailing whitespace in tag parameter\", () => {\n- NpmUtilities.publishTaggedInDir(\"trailing-tag \", directory, {}, callback);\n+ NpmUtilities.publishTaggedInDir(\"trailing-tag \", pkg, { npmClient: \"npm\" }, callback);\nconst actualtag = ChildProcessUtilities.exec.mock.calls[0][1][2];\nexpect(actualtag).toBe(\"trailing-tag\");\n});\nit(\"supports custom registry\", () => {\n+ const npmClient = \"npm\";\nconst registry = \"https://custom-registry/publishTaggedInDir\";\n- NpmUtilities.publishTaggedInDir(\"published-tag\", directory, { registry }, callback);\n+ NpmUtilities.publishTaggedInDir(\"custom-registry\", pkg, { npmClient, registry }, callback);\n- const cmd = \"npm\";\n- const args = [\"publish\", \"--tag\", \"published-tag\"];\n+ const args = [\"publish\", \"--tag\", \"custom-registry\"];\nconst opts = { directory, registry };\n- expect(ChildProcessUtilities.exec).lastCalledWith(cmd, args, opts, expect.any(Function));\n+ expect(ChildProcessUtilities.exec).lastCalledWith(npmClient, args, opts, expect.any(Function));\n+ });\n+\n+ describe(\"with npmClient yarn\", () => {\n+ it(\"appends --new-version to avoid interactive prompt\", () => {\n+ const npmClient = \"yarn\";\n+ NpmUtilities.publishTaggedInDir(\"yarn-publish\", pkg, { npmClient }, callback);\n+\n+ const args = [\"publish\", \"--tag\", \"yarn-publish\", \"--new-version\", \"1.10.100\"];\n+ const opts = { directory, registry: undefined };\n+ expect(ChildProcessUtilities.exec).lastCalledWith(npmClient, args, opts, expect.any(Function));\n+ });\n});\n});\n",
"new_path": "test/NpmUtilities.js",
"old_path": "test/NpmUtilities.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -47,7 +47,7 @@ const consoleOutput = () => output.mock.calls.map(args => normalizeNewline(args[\nconst publishedTagInDirectories = testDir =>\nNpmUtilities.publishTaggedInDir.mock.calls.reduce((arr, args) => {\nconst tag = args[0];\n- const dir = normalizeRelativeDir(testDir, args[1]);\n+ const dir = normalizeRelativeDir(testDir, args[1].location);\narr.push({ dir, tag });\nreturn arr;\n}, []);\n",
"new_path": "test/PublishCommand.js",
"old_path": "test/PublishCommand.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
fix: Pass --new-version to yarn when publishing (#1204)
This avoids an unfortunate interactive prompt due to a questionable conflation of yarn's "version" and "publish" commands.
Fixes #1200
| 1
|
fix
| null |
807,849
|
15.01.2018 21:19:59
| 28,800
|
1a9f53b1becbdb1ceaa6e35b1f2fe3d9c2c8da41
|
chore: Update CHANGELOG for v2.7.1
|
[
{
"change_type": "MODIFY",
"diff": "+## v2.7.1 (2018-01-16)\n+\n+#### :bug: Bug Fix\n+\n+* [#1194](https://github.com/lerna/lerna/pull/1194) Treat 'lerna run test' like any other command. ([@tkrotoff](https://github.com/tkrotoff))\n+* [#1199](https://github.com/lerna/lerna/pull/1199) Fix import command so it works if Lerna root is a subdir of git root. [@RoystonS](https://github.com/RoystonS))\n+* [#1204](https://github.com/lerna/lerna/pull/1204) Avoid interactive prompt during yarn publish. ([@evocateur](https://github.com/evocateur))\n+\n+#### Committers: 3\n+\n+* Daniel Stockman ([evocateur](https://github.com/evocateur))\n+* Royston Shufflebotham ([RoystonS](https://github.com/RoystonS))\n+* Tanguy Krotoff ([tkrotoff](https://github.com/tkrotoff))\n+\n## v2.7.0 (2018-01-12)\n#### :rocket: Enhancement\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: Update CHANGELOG for v2.7.1
| 1
|
chore
| null |
807,849
|
15.01.2018 21:25:43
| 28,800
|
06aae0c84e4a1fd5c25a2f84b608e68040f2973e
|
chore: fix typo in changlog
|
[
{
"change_type": "MODIFY",
"diff": "#### :bug: Bug Fix\n* [#1194](https://github.com/lerna/lerna/pull/1194) Treat 'lerna run test' like any other command. ([@tkrotoff](https://github.com/tkrotoff))\n-* [#1199](https://github.com/lerna/lerna/pull/1199) Fix import command so it works if Lerna root is a subdir of git root. [@RoystonS](https://github.com/RoystonS))\n+* [#1199](https://github.com/lerna/lerna/pull/1199) Fix import command so it works if Lerna root is a subdir of git root. ([@RoystonS](https://github.com/RoystonS))\n* [#1204](https://github.com/lerna/lerna/pull/1204) Avoid interactive prompt during yarn publish. ([@evocateur](https://github.com/evocateur))\n#### Committers: 3\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: fix typo in changlog
| 1
|
chore
| null |
808,037
|
16.01.2018 05:48:29
| -3,600
|
67a546d073bb1b4e1322459ec2bfa05dc13fe04d
|
fix: Treat 'lerna run test' like any other command(#1194)
Fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -63,7 +63,7 @@ export default class RunCommand extends Command {\nconst { filteredPackages } = this;\n- if (script === \"test\" || script === \"env\") {\n+ if (script === \"env\") {\nthis.packagesWithScript = filteredPackages;\n} else {\nthis.packagesWithScript = filteredPackages.filter(pkg => pkg.scripts && pkg.scripts[script]);\n",
"new_path": "src/commands/RunCommand.js",
"old_path": "src/commands/RunCommand.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -69,12 +69,6 @@ describe(\"RunCommand\", () => {\nexpect(ranInPackagesStreaming(testDir)).toMatchSnapshot(\"run <script> --stream\");\n});\n- it(\"always runs test script\", async () => {\n- await lernaRun(\"test\");\n-\n- expect(ranInPackages(testDir)).toMatchSnapshot(\"run test\");\n- });\n-\nit(\"always runs env script\", async () => {\nawait lernaRun(\"env\");\n",
"new_path": "test/RunCommand.js",
"old_path": "test/RunCommand.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -56,12 +56,3 @@ Array [\n\"packages/package-3 env\",\n]\n`;\n-\n-exports[`run test 1`] = `\n-Array [\n- \"packages/package-1 test\",\n- \"packages/package-4 test\",\n- \"packages/package-2 test\",\n- \"packages/package-3 test\",\n-]\n-`;\n",
"new_path": "test/__snapshots__/RunCommand.js.snap",
"old_path": "test/__snapshots__/RunCommand.js.snap"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
fix: Treat 'lerna run test' like any other command(#1194)
Fixes #1142
| 1
|
fix
| null |
815,746
|
16.01.2018 08:45:54
| -7,200
|
68d077294783e9ba62e0b88acb3fbbd032b86348
|
fix: make ng-input z-index bigger to focus on placeholder click
fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -201,10 +201,12 @@ $color-selected: #f5faff;\n}\n.ng-input {\nflex: 1;\n+ z-index: 2;\npadding-bottom: 3px;\npadding-left: 3px;\n}\n.ng-placeholder {\n+ z-index: 1;\npadding-bottom: 5px;\npadding-left: 3px;\n}\n",
"new_path": "src/ng-select/ng-select.component.scss",
"old_path": "src/ng-select/ng-select.component.scss"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: make ng-input z-index bigger to focus on placeholder click (#190)
fixes https://github.com/ng-select/ng-select/issues/183
| 1
|
fix
| null |
815,746
|
16.01.2018 08:47:22
| -7,200
|
c33c108fad8ab8f6246b122467d3fc63c453aa16
|
chore(release): 0.14.4
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.14.4\"></a>\n+## [0.14.4](https://github.com/ng-select/ng-select/compare/v0.14.3...v0.14.4) (2018-01-16)\n+\n+\n+### Bug Fixes\n+\n+* make ng-input z-index bigger to focus on placeholder click ([#190](https://github.com/ng-select/ng-select/issues/190)) ([68d0772](https://github.com/ng-select/ng-select/commit/68d0772))\n+\n+\n+\n<a name=\"0.14.3\"></a>\n## [0.14.3](https://github.com/ng-select/ng-select/compare/v0.14.2...v0.14.3) (2018-01-09)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.14.3\",\n+ \"version\": \"0.14.4\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.14.4
| 1
|
chore
|
release
|
448,039
|
16.01.2018 11:29:29
| -3,600
|
1f1ce1859fbbb2e0c6ff2e08a7d265c2c6efbf56
|
style: prettier adoption step by step
|
[
{
"change_type": "MODIFY",
"diff": "\"jasmine\": \"^2.6.0\",\n\"json-schema-to-typescript\": \"^5.0.0\",\n\"mocha\": \"^4.0.0\",\n+ \"prettier\": \"^1.10.2\",\n+ \"pretty-quick\": \"^1.2.1\",\n\"react\": \"^16.0.0\",\n\"react-dom\": \"^16.0.0\",\n\"sinon\": \"^4.0.0\",\n\"publish:ci\": \"yarn prerelease && yarn postrelease\",\n\"integration:samples\": \"integration/samples.sh\",\n\"integration:samples:dev\": \"ts-node --project src/tsconfig.packagr.json ./integration/samples.dev.ts\",\n- \"integration:specs\": \"cross-env TS_NODE_PROJECT=integration/tsconfig.specs.json mocha --require ts-node/register integration/samples/*/specs/**/*.ts\",\n+ \"integration:specs\":\n+ \"cross-env TS_NODE_PROJECT=integration/tsconfig.specs.json mocha --require ts-node/register integration/samples/*/specs/**/*.ts\",\n\"integration:consumers\": \"integration/consumers.sh\",\n\"integration:consumers:ngc\": \"ngc -p integration/consumers/tsc/tsconfig.json\",\n\"test:specs\": \"cross-env TS_NODE_PROJECT=src/tsconfig.specs.json mocha --require ts-node/register src/**/*.spec.ts\",\n- \"test\": \"yarn build && yarn test:specs && yarn integration:samples && yarn integration:specs && yarn integration:consumers\",\n+ \"test\":\n+ \"yarn build && yarn test:specs && yarn integration:samples && yarn integration:specs && yarn integration:consumers\",\n\"commitmsg\": \"commitlint -e\",\n+ \"precommit\": \"pretty-quick --staged\",\n\"gh-pages\": \"gh-pages -d docs/ghpages\"\n}\n}\n",
"new_path": "package.json",
"old_path": "package.json"
},
{
"change_type": "ADD",
"diff": "+module.exports = {\n+ printWidth: 120,\n+ singleQuote: true\n+};\n",
"new_path": "prettier.config.js",
"old_path": null
},
{
"change_type": "MODIFY",
"diff": "@@ -1212,6 +1212,18 @@ execa@^0.7.0:\nsignal-exit \"^3.0.0\"\nstrip-eof \"^1.0.0\"\n+execa@^0.8.0:\n+ version \"0.8.0\"\n+ resolved \"https://trr-orbis-maven.dev.agfahealthcare.com/nexus/repository/npm-all/execa/-/execa-0.8.0.tgz#d8d76bbc1b55217ed190fd6dd49d3c774ecfc8da\"\n+ dependencies:\n+ cross-spawn \"^5.0.1\"\n+ get-stream \"^3.0.0\"\n+ is-stream \"^1.1.0\"\n+ npm-run-path \"^2.0.0\"\n+ p-finally \"^1.0.0\"\n+ signal-exit \"^3.0.0\"\n+ strip-eof \"^1.0.0\"\n+\nexit@^0.1.2:\nversion \"0.1.2\"\nresolved \"https://registry.yarnpkg.com/exit/-/exit-0.1.2.tgz#0632638f8d877cc82107d30a0fff1a17cba1cd0c\"\n@@ -1711,6 +1723,10 @@ iconv-lite@~0.4.13:\nversion \"0.4.19\"\nresolved \"https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.19.tgz#f7468f60135f5e5dad3399c0a81be9a1603a082b\"\n+ignore@^3.3.7:\n+ version \"3.3.7\"\n+ resolved \"https://trr-orbis-maven.dev.agfahealthcare.com/nexus/repository/npm-all/ignore/-/ignore-3.3.7.tgz#612289bfb3c220e186a58118618d5be8c1bab021\"\n+\nimage-size@~0.5.0:\nversion \"0.5.5\"\nresolved \"https://registry.yarnpkg.com/image-size/-/image-size-0.5.5.tgz#09dfd4ab9d20e29eb1c3e80b8990378df9e3cb9c\"\n@@ -2323,6 +2339,10 @@ modify-values@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/modify-values/-/modify-values-1.0.0.tgz#e2b6cdeb9ce19f99317a53722f3dbf5df5eaaab2\"\n+mri@^1.1.0:\n+ version \"1.1.0\"\n+ resolved \"https://trr-orbis-maven.dev.agfahealthcare.com/nexus/repository/npm-all/mri/-/mri-1.1.0.tgz#5c0a3f29c8ccffbbb1ec941dcec09d71fa32f36a\"\n+\nms@2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/ms/-/ms-2.0.0.tgz#5608aeadfc00be6c2901df5f9861788de0d597c8\"\n@@ -2694,10 +2714,24 @@ preserve@^0.2.0:\nversion \"0.2.0\"\nresolved \"https://registry.yarnpkg.com/preserve/-/preserve-0.2.0.tgz#815ed1f6ebc65926f865b310c0713bcb3315ce4b\"\n+prettier@^1.10.2:\n+ version \"1.10.2\"\n+ resolved \"https://trr-orbis-maven.dev.agfahealthcare.com/nexus/repository/npm-all/prettier/-/prettier-1.10.2.tgz#1af8356d1842276a99a5b5529c82dd9e9ad3cc93\"\n+\nprettier@^1.8.2:\nversion \"1.9.1\"\nresolved \"https://registry.yarnpkg.com/prettier/-/prettier-1.9.1.tgz#41638a0d47c1efbd1b7d5a742aaa5548eab86d70\"\n+pretty-quick@^1.2.1:\n+ version \"1.2.1\"\n+ resolved \"https://trr-orbis-maven.dev.agfahealthcare.com/nexus/repository/npm-all/pretty-quick/-/pretty-quick-1.2.1.tgz#2f8ad20cfb576519bd5976b92e06f440d1b3b239\"\n+ dependencies:\n+ chalk \"^2.3.0\"\n+ execa \"^0.8.0\"\n+ find-up \"^2.1.0\"\n+ ignore \"^3.3.7\"\n+ mri \"^1.1.0\"\n+\nprocess-nextick-args@~1.0.6:\nversion \"1.0.7\"\nresolved \"https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-1.0.7.tgz#150e20b756590ad3f91093f25a4f2ad8bff30ba3\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
style: prettier adoption step by step
| 1
|
style
| null |
807,849
|
16.01.2018 11:51:15
| 28,800
|
437faca50123e01b51596a76dec33d3be65aee3c
|
chore: Update CHANGELOG for v2.7.2
|
[
{
"change_type": "MODIFY",
"diff": "+## v2.7.2 (2018-01-16)\n+\n+#### :rocket: Enhancement\n+\n+* [#1205](https://github.com/lerna/lerna/pull/1205) Add %v as placeholder for raw version in `--message`. ([@mojavelinux](https://github.com/mojavelinux))\n+\n+#### :bug: Bug Fix\n+\n+* [#1206](https://github.com/lerna/lerna/pull/1206) Avoid dropping early logs below default level. ([@evocateur](https://github.com/evocateur))\n+\n+#### Committers: 2\n+\n+* Dan Allen ([mojavelinux](https://github.com/mojavelinux))\n+* Daniel Stockman ([evocateur](https://github.com/evocateur))\n+\n## v2.7.1 (2018-01-16)\n#### :bug: Bug Fix\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: Update CHANGELOG for v2.7.2
| 1
|
chore
| null |
448,039
|
17.01.2018 07:36:33
| -3,600
|
bffbdb67c237a9b47e5aaf8b8a88f26105cf1b80
|
release: cut v2.0.0-rc.11
|
[
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"ng-packagr\",\n- \"version\": \"2.0.0-rc.10\",\n+ \"version\": \"2.0.0-rc.11\",\n\"description\": \"Compile and package a TypeScript library to Angular Package Format\",\n\"keywords\": [\n\"angular\",\n",
"new_path": "package.json",
"old_path": "package.json"
}
] |
TypeScript
|
MIT License
|
ng-packagr/ng-packagr
|
release: cut v2.0.0-rc.11
| 1
|
release
| null |
807,849
|
17.01.2018 12:26:30
| 28,800
|
83e1e491427d82de491424894409344721ee4497
|
chore: Retrieve package version before directory is changed in Command test
|
[
{
"change_type": "MODIFY",
"diff": "@@ -17,6 +17,7 @@ const initFixture = require(\"./helpers/initFixture\");\n// file under test\nconst Command = require(\"../src/Command\");\n+const LERNA_VERSION = require(\"../package.json\").version;\n// silence logs\nlog.level = \"silent\";\n@@ -60,8 +61,7 @@ describe(\"Command\", () => {\ndescribe(\".lernaVersion\", () => {\nit(\"should be added to the instance\", async () => {\n- const { version } = await loadJsonFile(path.resolve(__dirname, \"../package.json\"));\n- expect(testFactory().lernaVersion).toEqual(version);\n+ expect(testFactory().lernaVersion).toEqual(LERNA_VERSION);\n});\n});\n",
"new_path": "test/Command.js",
"old_path": "test/Command.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: Retrieve package version before directory is changed in Command test
| 1
|
chore
| null |
807,849
|
17.01.2018 12:28:59
| 28,800
|
7f648df46f9e2f92a41a90680264bddc11249e81
|
fix: toposort does not need to be a lazy getter
BREAKING CHANGE: The `--sort` option no longer supports `null` as a value.
|
[
{
"change_type": "MODIFY",
"diff": "@@ -150,13 +150,9 @@ class Command {\n}\nget toposort() {\n- if (!this._toposort) {\nconst { sort } = this.options;\n// If the option isn't present then the default is to sort.\n- this._toposort = sort == null || sort;\n- }\n-\n- return this._toposort;\n+ return sort === undefined || sort;\n}\nget name() {\n",
"new_path": "src/Command.js",
"old_path": "src/Command.js"
},
{
"change_type": "MODIFY",
"diff": "@@ -94,10 +94,6 @@ describe(\"Command\", () => {\nexpect(testFactory().toposort).toBe(true);\n});\n- it(\"is enabled when sort config is null\", () => {\n- expect(testFactory({ sort: null }).toposort).toBe(true);\n- });\n-\nit(\"is disabled when sort config is explicitly false (--no-sort)\", () => {\nexpect(testFactory({ sort: false }).toposort).toBe(false);\n});\n",
"new_path": "test/Command.js",
"old_path": "test/Command.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
fix: toposort does not need to be a lazy getter
BREAKING CHANGE: The `--sort` option no longer supports `null` as a value.
| 1
|
fix
| null |
807,849
|
17.01.2018 12:43:58
| 28,800
|
a3ce0533bdc47bdfbd30da56b16767249b129214
|
chore: bump jest + eslint-plugin-jest
|
[
{
"change_type": "MODIFY",
"diff": "\"@babel/code-frame@^7.0.0-beta.35\":\n- version \"7.0.0-beta.37\"\n- resolved \"https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0-beta.37.tgz#2da1dd3b1b57bfdea777ddc378df7cd12fe40171\"\n+ version \"7.0.0-beta.38\"\n+ resolved \"https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0-beta.38.tgz#c0af5930617e55e050336838e3a3670983b0b2b2\"\ndependencies:\nchalk \"^2.0.0\"\nesutils \"^2.0.2\"\n@@ -1076,8 +1076,8 @@ eslint-plugin-import@^2.8.0:\nread-pkg-up \"^2.0.0\"\neslint-plugin-jest@^21.6.1:\n- version \"21.6.2\"\n- resolved \"https://registry.yarnpkg.com/eslint-plugin-jest/-/eslint-plugin-jest-21.6.2.tgz#aaa7b37c621e49aa0b13f4dc5f7038f73c64b438\"\n+ version \"21.7.0\"\n+ resolved \"https://registry.yarnpkg.com/eslint-plugin-jest/-/eslint-plugin-jest-21.7.0.tgz#651f1c6ce999af3ac59ab8bf8a376d742fd0fc23\"\neslint-plugin-node@^5.1.1:\nversion \"5.2.1\"\n@@ -2069,9 +2069,9 @@ jest-changed-files@^22.1.0:\ndependencies:\nthroat \"^4.0.0\"\n-jest-cli@^22.1.1:\n- version \"22.1.1\"\n- resolved \"https://registry.yarnpkg.com/jest-cli/-/jest-cli-22.1.1.tgz#fa101866fbce926d875dfe5b3565785dc7922b1d\"\n+jest-cli@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-cli/-/jest-cli-22.1.2.tgz#89497932d7befb8a6952f2712473695c4bbef43f\"\ndependencies:\nansi-escapes \"^3.0.0\"\nchalk \"^2.0.1\"\n@@ -2085,17 +2085,17 @@ jest-cli@^22.1.1:\nistanbul-lib-instrument \"^1.8.0\"\nistanbul-lib-source-maps \"^1.2.1\"\njest-changed-files \"^22.1.0\"\n- jest-config \"^22.1.1\"\n- jest-environment-jsdom \"^22.1.0\"\n+ jest-config \"^22.1.2\"\n+ jest-environment-jsdom \"^22.1.2\"\njest-get-type \"^22.1.0\"\njest-haste-map \"^22.1.0\"\njest-message-util \"^22.1.0\"\njest-regex-util \"^22.1.0\"\njest-resolve-dependencies \"^22.1.0\"\n- jest-runner \"^22.1.1\"\n- jest-runtime \"^22.1.1\"\n- jest-snapshot \"^22.1.0\"\n- jest-util \"^22.1.0\"\n+ jest-runner \"^22.1.2\"\n+ jest-runtime \"^22.1.2\"\n+ jest-snapshot \"^22.1.2\"\n+ jest-util \"^22.1.2\"\njest-worker \"^22.1.0\"\nmicromatch \"^2.3.11\"\nnode-notifier \"^5.1.2\"\n@@ -2107,20 +2107,20 @@ jest-cli@^22.1.1:\nwhich \"^1.2.12\"\nyargs \"^10.0.3\"\n-jest-config@^22.1.1:\n- version \"22.1.1\"\n- resolved \"https://registry.yarnpkg.com/jest-config/-/jest-config-22.1.1.tgz#642ffc0c704ca66a598eae1f2a473d1f9096056d\"\n+jest-config@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-config/-/jest-config-22.1.2.tgz#d3aee5c1df0997f0e2ae5c707eee04a7c87f1653\"\ndependencies:\nchalk \"^2.0.1\"\nglob \"^7.1.1\"\n- jest-environment-jsdom \"^22.1.0\"\n- jest-environment-node \"^22.1.0\"\n+ jest-environment-jsdom \"^22.1.2\"\n+ jest-environment-node \"^22.1.2\"\njest-get-type \"^22.1.0\"\n- jest-jasmine2 \"^22.1.1\"\n+ jest-jasmine2 \"^22.1.2\"\njest-regex-util \"^22.1.0\"\njest-resolve \"^22.1.0\"\n- jest-util \"^22.1.0\"\n- jest-validate \"^22.1.0\"\n+ jest-util \"^22.1.2\"\n+ jest-validate \"^22.1.2\"\npretty-format \"^22.1.0\"\njest-diff@^22.1.0:\n@@ -2142,20 +2142,20 @@ jest-docblock@^22.1.0:\ndependencies:\ndetect-newline \"^2.1.0\"\n-jest-environment-jsdom@^22.1.0:\n- version \"22.1.0\"\n- resolved \"https://registry.yarnpkg.com/jest-environment-jsdom/-/jest-environment-jsdom-22.1.0.tgz#d0b83359a1dd4dc7faa9be27895da1859692b9e8\"\n+jest-environment-jsdom@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-environment-jsdom/-/jest-environment-jsdom-22.1.2.tgz#4488c629631dd5de9059ec747fcd358735247f70\"\ndependencies:\njest-mock \"^22.1.0\"\n- jest-util \"^22.1.0\"\n+ jest-util \"^22.1.2\"\njsdom \"^11.5.1\"\n-jest-environment-node@^22.1.0:\n- version \"22.1.0\"\n- resolved \"https://registry.yarnpkg.com/jest-environment-node/-/jest-environment-node-22.1.0.tgz#372d590c5229a349e882d9404808c4e99bd40f62\"\n+jest-environment-node@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-environment-node/-/jest-environment-node-22.1.2.tgz#77dc32fbe08caa03ef2acb0948dce4b25a14633a\"\ndependencies:\njest-mock \"^22.1.0\"\n- jest-util \"^22.1.0\"\n+ jest-util \"^22.1.2\"\njest-get-type@^22.1.0:\nversion \"22.1.0\"\n@@ -2172,9 +2172,9 @@ jest-haste-map@^22.1.0:\nmicromatch \"^2.3.11\"\nsane \"^2.0.0\"\n-jest-jasmine2@^22.1.1:\n- version \"22.1.1\"\n- resolved \"https://registry.yarnpkg.com/jest-jasmine2/-/jest-jasmine2-22.1.1.tgz#990a13cd62803ae44bcb6e34909d3b0ebd2dcb13\"\n+jest-jasmine2@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-jasmine2/-/jest-jasmine2-22.1.2.tgz#dee4ba04fb2cf462e4c7cfb499426e82e8fde5ac\"\ndependencies:\ncallsites \"^2.0.0\"\nchalk \"^2.0.1\"\n@@ -2185,7 +2185,7 @@ jest-jasmine2@^22.1.1:\njest-diff \"^22.1.0\"\njest-matcher-utils \"^22.1.0\"\njest-message-util \"^22.1.0\"\n- jest-snapshot \"^22.1.0\"\n+ jest-snapshot \"^22.1.2\"\nsource-map-support \"^0.5.0\"\njest-leak-detector@^22.1.0:\n@@ -2233,25 +2233,25 @@ jest-resolve@^22.1.0:\nbrowser-resolve \"^1.11.2\"\nchalk \"^2.0.1\"\n-jest-runner@^22.1.1:\n- version \"22.1.1\"\n- resolved \"https://registry.yarnpkg.com/jest-runner/-/jest-runner-22.1.1.tgz#5486c9312cf24fe6f3a855bdff58009a34e7c5a8\"\n+jest-runner@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-runner/-/jest-runner-22.1.2.tgz#e8565e4eb56c27219352b8486338ced9ceb462da\"\ndependencies:\nexit \"^0.1.2\"\n- jest-config \"^22.1.1\"\n+ jest-config \"^22.1.2\"\njest-docblock \"^22.1.0\"\njest-haste-map \"^22.1.0\"\n- jest-jasmine2 \"^22.1.1\"\n+ jest-jasmine2 \"^22.1.2\"\njest-leak-detector \"^22.1.0\"\njest-message-util \"^22.1.0\"\n- jest-runtime \"^22.1.1\"\n- jest-util \"^22.1.0\"\n+ jest-runtime \"^22.1.2\"\n+ jest-util \"^22.1.2\"\njest-worker \"^22.1.0\"\nthroat \"^4.0.0\"\n-jest-runtime@^22.1.1:\n- version \"22.1.1\"\n- resolved \"https://registry.yarnpkg.com/jest-runtime/-/jest-runtime-22.1.1.tgz#2b765fc750a0cda28806419007e220df08dfe505\"\n+jest-runtime@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-runtime/-/jest-runtime-22.1.2.tgz#42755d7cea2ffc7cdaa7f2dfa8736264a6057bf9\"\ndependencies:\nbabel-core \"^6.0.0\"\nbabel-jest \"^22.1.0\"\n@@ -2260,11 +2260,11 @@ jest-runtime@^22.1.1:\nconvert-source-map \"^1.4.0\"\nexit \"^0.1.2\"\ngraceful-fs \"^4.1.11\"\n- jest-config \"^22.1.1\"\n+ jest-config \"^22.1.2\"\njest-haste-map \"^22.1.0\"\njest-regex-util \"^22.1.0\"\njest-resolve \"^22.1.0\"\n- jest-util \"^22.1.0\"\n+ jest-util \"^22.1.2\"\njson-stable-stringify \"^1.0.1\"\nmicromatch \"^2.3.11\"\nrealpath-native \"^1.0.0\"\n@@ -2273,9 +2273,9 @@ jest-runtime@^22.1.1:\nwrite-file-atomic \"^2.1.0\"\nyargs \"^10.0.3\"\n-jest-snapshot@^22.1.0:\n- version \"22.1.0\"\n- resolved \"https://registry.yarnpkg.com/jest-snapshot/-/jest-snapshot-22.1.0.tgz#4a9b27a1974cff0c48ff0f86bbbefd1a6cc3c5f5\"\n+jest-snapshot@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-snapshot/-/jest-snapshot-22.1.2.tgz#b270cf6e3098f33aceeafda02b13eb0933dc6139\"\ndependencies:\nchalk \"^2.0.1\"\njest-diff \"^22.1.0\"\n@@ -2284,21 +2284,21 @@ jest-snapshot@^22.1.0:\nnatural-compare \"^1.4.0\"\npretty-format \"^22.1.0\"\n-jest-util@^22.1.0:\n- version \"22.1.0\"\n- resolved \"https://registry.yarnpkg.com/jest-util/-/jest-util-22.1.0.tgz#2ce0ead08a00a38383c308d0bd3431a9f159cbaa\"\n+jest-util@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-util/-/jest-util-22.1.2.tgz#4bf098f651e8611d744cefa23fa026c97a6a3d5d\"\ndependencies:\ncallsites \"^2.0.0\"\nchalk \"^2.0.1\"\ngraceful-fs \"^4.1.11\"\nis-ci \"^1.0.10\"\njest-message-util \"^22.1.0\"\n- jest-validate \"^22.1.0\"\n+ jest-validate \"^22.1.2\"\nmkdirp \"^0.5.1\"\n-jest-validate@^22.1.0:\n- version \"22.1.0\"\n- resolved \"https://registry.yarnpkg.com/jest-validate/-/jest-validate-22.1.0.tgz#69d570687029e2349ca5779e209bdd360898746c\"\n+jest-validate@^22.1.2:\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest-validate/-/jest-validate-22.1.2.tgz#c3b06bcba7bd9a850919fe336b5f2a8c3a239404\"\ndependencies:\nchalk \"^2.0.1\"\njest-get-type \"^22.1.0\"\n@@ -2312,10 +2312,10 @@ jest-worker@^22.1.0:\nmerge-stream \"^1.0.1\"\njest@^22.0.4:\n- version \"22.1.1\"\n- resolved \"https://registry.yarnpkg.com/jest/-/jest-22.1.1.tgz#96bf8cc65059e2fdc84c5b4de4e4a736d799a342\"\n+ version \"22.1.2\"\n+ resolved \"https://registry.yarnpkg.com/jest/-/jest-22.1.2.tgz#54dce0f4946a089a00d5fdac8291d5926e24f6ab\"\ndependencies:\n- jest-cli \"^22.1.1\"\n+ jest-cli \"^22.1.2\"\njs-tokens@^3.0.0, js-tokens@^3.0.2:\nversion \"3.0.2\"\n@@ -3077,8 +3077,8 @@ randomatic@^1.1.3:\nkind-of \"^4.0.0\"\nrc@^1.0.1, rc@^1.1.6, rc@^1.1.7:\n- version \"1.2.3\"\n- resolved \"https://registry.yarnpkg.com/rc/-/rc-1.2.3.tgz#51575a900f8dd68381c710b4712c2154c3e2035b\"\n+ version \"1.2.4\"\n+ resolved \"https://registry.yarnpkg.com/rc/-/rc-1.2.4.tgz#a0f606caae2a3b862bbd0ef85482c0125b315fa3\"\ndependencies:\ndeep-extend \"~0.4.0\"\nini \"~1.3.0\"\n",
"new_path": "yarn.lock",
"old_path": "yarn.lock"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: bump jest + eslint-plugin-jest
| 1
|
chore
| null |
815,745
|
17.01.2018 13:46:42
| -7,200
|
5932fec4fd0a7d81f9736fcab3a450af4469cd99
|
fix: add missing types
fixes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -43,7 +43,7 @@ export class ItemsList {\nitem.selected = true;\n}\n- findItem(value, bindValue: string): NgOption {\n+ findItem(value: any, bindValue: string): NgOption {\nif (!value) {\nreturn null;\n}\n@@ -109,7 +109,7 @@ export class ItemsList {\nthis._markedIndex = this.filteredItems.indexOf(item);\n}\n- markSelectedOrDefault(markDefault) {\n+ markSelectedOrDefault(markDefault: boolean) {\nif (this.filteredItems.length === 0) {\nreturn;\n}\n@@ -139,7 +139,7 @@ export class ItemsList {\n}\n}\n- private getDefaultFilterFunc(term) {\n+ private getDefaultFilterFunc(term: string) {\nreturn (option: NgOption) => {\nreturn searchHelper.stripSpecialChars(option.label || '')\n.toUpperCase()\n",
"new_path": "src/ng-select/items-list.ts",
"old_path": "src/ng-select/items-list.ts"
},
{
"change_type": "MODIFY",
"diff": "<input #filterInput\ntype=\"text\"\n[value]=\"filterValue\"\n- (input)=\"onFilter($event)\"\n+ (input)=\"onFilter(filterInput.value)\"\n(focus)=\"onInputFocus($event)\"\n(blur)=\"onInputBlur($event)\"\n(change)=\"$event.stopPropagation()\"\n",
"new_path": "src/ng-select/ng-select.component.html",
"old_path": "src/ng-select/ng-select.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -492,7 +492,7 @@ describe('NgSelectComponent', function () {\ndescribe('tab', () => {\nit('should close dropdown when there are no items', fakeAsync(() => {\n- fixture.componentInstance.select.onFilter({ target: { value: 'random stuff' } });\n+ fixture.componentInstance.select.onFilter('random stuff');\ntick(200);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Space);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Tab);\n@@ -755,7 +755,7 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\ntickAndDetectChanges(fixture);\n- fixture.componentInstance.select.onFilter({ target: { value: 'new tag' } });\n+ fixture.componentInstance.select.onFilter('new tag');\ntickAndDetectChanges(fixture);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\nexpect(fixture.componentInstance.selectedCity.name).toBe('new tag');\n@@ -772,7 +772,7 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\ntickAndDetectChanges(fixture);\n- fixture.componentInstance.select.onFilter({ target: { value: 'custom tag' } });\n+ fixture.componentInstance.select.onFilter('custom tag');\ntickAndDetectChanges(fixture);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\nexpect(<any>fixture.componentInstance.selectedCity).toEqual(jasmine.objectContaining({\n@@ -822,7 +822,7 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\ntick(200);\n- fixture.componentInstance.select.onFilter({ target: { value: 'vilnius' } });\n+ fixture.componentInstance.select.onFilter('vilnius');\ntick(200);\nconst result = [jasmine.objectContaining({\n@@ -861,7 +861,7 @@ describe('NgSelectComponent', function () {\n[(ngModel)]=\"selectedCity\">\n</ng-select>`);\n- fixture.componentInstance.select.onFilter({ target: { value: 'vilnius' } });\n+ fixture.componentInstance.select.onFilter('vilnius');\ntickAndDetectChanges(fixture);\nexpect(fixture.componentInstance.select.filterValue).toBe(null);\n}));\n@@ -875,7 +875,7 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\ntick(200);\n- fixture.componentInstance.select.onFilter({ target: { value: 'pab' } });\n+ fixture.componentInstance.select.onFilter('pab');\ntick(200);\nconst result = jasmine.objectContaining({\n@@ -896,7 +896,7 @@ describe('NgSelectComponent', function () {\n</ng-select>`);\ntick(200);\n- fixture.componentInstance.select.onFilter({ target: { value: 'pab' } });\n+ fixture.componentInstance.select.onFilter('pab');\ntick(200);\nexpect(fixture.componentInstance.select.itemsList.markedItem).toEqual(undefined)\n}));\n@@ -932,13 +932,13 @@ describe('NgSelectComponent', function () {\nexpect(term).toBe('vilnius');\n});\ntick(200);\n- fixture.componentInstance.select.onFilter({ target: { value: 'vilnius' } });\n+ fixture.componentInstance.select.onFilter('vilnius');\ntickAndDetectChanges(fixture);\n}));\nit('should mark first item when typeahead results are loaded', fakeAsync(() => {\nfixture.componentInstance.customFilter.subscribe();\n- fixture.componentInstance.select.onFilter({ target: { value: 'buk' } });\n+ fixture.componentInstance.select.onFilter('buk');\nfixture.componentInstance.cities = [{ id: 4, name: 'Bukiskes' }];\ntickAndDetectChanges(fixture);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\n@@ -950,7 +950,7 @@ describe('NgSelectComponent', function () {\nit('should not mark first item when typeahead results are loaded', fakeAsync(() => {\nfixture.componentInstance.select.markFirst = false;\nfixture.componentInstance.customFilter.subscribe();\n- fixture.componentInstance.select.onFilter({ target: { value: 'buk' } });\n+ fixture.componentInstance.select.onFilter('buk');\nfixture.componentInstance.cities = [{ id: 4, name: 'Bukiskes' }];\ntickAndDetectChanges(fixture);\ntriggerKeyDownEvent(getNgSelectElement(fixture), KeyCode.Enter);\n@@ -959,7 +959,7 @@ describe('NgSelectComponent', function () {\nit('should start and stop loading indicator', fakeAsync(() => {\nfixture.componentInstance.customFilter.subscribe();\n- fixture.componentInstance.select.onFilter({ target: { value: 'buk' } });\n+ fixture.componentInstance.select.onFilter('buk');\nexpect(fixture.componentInstance.select.isLoading).toBeTruthy();\nfixture.componentInstance.cities = [{ id: 4, name: 'Bukiskes' }];\ntickAndDetectChanges(fixture);\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -58,23 +58,23 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\n@ViewChild(VirtualScrollComponent) dropdownList: VirtualScrollComponent;\n@ViewChild('dropdownPanel') dropdownPanel: ElementRef;\n@ContentChildren(NgOptionComponent, { descendants: true }) ngOptions: QueryList<NgOptionComponent>;\n- @ViewChild('filterInput') filterInput;\n+ @ViewChild('filterInput') filterInput: ElementRef;\n// inputs\n- @Input() items = [];\n+ @Input() items: any[] = [];\n@Input() bindLabel: string;\n@Input() bindValue: string;\n@Input() clearable = true;\n@Input() markFirst = true;\n@Input() disableVirtualScroll = false;\n@Input() placeholder: string;\n- @Input() notFoundText;\n- @Input() typeToSearchText;\n- @Input() addTagText;\n- @Input() loadingText;\n- @Input() clearAllText;\n+ @Input() notFoundText: string;\n+ @Input() typeToSearchText: string;\n+ @Input() addTagText: string;\n+ @Input() loadingText: string;\n+ @Input() clearAllText: string;\n@Input() dropdownPosition: 'bottom' | 'top' = 'bottom';\n- @Input() appendTo;\n+ @Input() appendTo: string;\n@Input()\n@HostBinding('class.typeahead') typeahead: Subject<string>;\n@@ -83,7 +83,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\n@HostBinding('class.ng-multiple') multiple = false;\n@Input()\n- @HostBinding('class.taggable') addTag: boolean | ((term) => NgOption) = false;\n+ @HostBinding('class.taggable') addTag: boolean | ((term: string) => NgOption) = false;\n@Input()\n@HostBinding('class.searchable') searchable = true;\n@@ -114,7 +114,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nisLoading = false;\nfilterValue: string = null;\n- private _ngModel = null;\n+ private _ngModel: any = null;\nprivate _simple = false;\nprivate _defaultLabel = 'label';\nprivate _defaultValue = 'value';\n@@ -124,7 +124,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nprivate disposeDocumentClickListener = () => { };\nprivate disposeDocumentResizeListener = () => { };\n- clearItem = (item) => {\n+ clearItem = (item: any) => {\nconst option = this.itemsList.items.find(x => x.value === item);\nthis.unselect(option);\n};\n@@ -360,7 +360,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nreturn empty && this.isTypeahead && !this.filterValue && !this.isLoading;\n}\n- onFilter($event) {\n+ onFilter(term: string) {\nif (!this.searchable) {\nreturn;\n}\n@@ -369,7 +369,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nthis.open();\n}\n- this.filterValue = $event.target.value;\n+ this.filterValue = term;\nif (this.isTypeahead) {\nthis.isLoading = true;\n@@ -419,7 +419,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nprivate setItemsFromNgOptions() {\nthis.bindLabel = this.bindLabel || this._defaultLabel;\nthis.bindValue = this.bindValue || this._defaultValue;\n- const handleNgOptions = (options) => {\n+ const handleNgOptions = (options: QueryList<NgOptionComponent>) => {\nthis.items = options.map(option => ({\nvalue: option.value,\nlabel: option.elementRef.nativeElement.innerHTML\n@@ -438,7 +438,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\n}\nprivate handleDocumentClick() {\n- const handler = ($event) => {\n+ const handler = ($event: any) => {\n// prevent close if clicked on select\nif (this.elementRef.nativeElement.contains($event.target)) {\nreturn;\n@@ -479,7 +479,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nif (this.appendTo === 'body') {\ndocument.body.appendChild(this.dropdownPanel.nativeElement);\n} else {\n- const parent: HTMLElement = document.querySelector(this.appendTo);\n+ const parent = document.querySelector(this.appendTo);\nif (!parent) {\nthrow new Error(`appendTo selector ${this.appendTo} did not found any parent element`)\n}\n@@ -508,7 +508,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nreturn;\n}\n- const validateBinding = (item) => {\n+ const validateBinding = (item: any) => {\nif (item instanceof Object && this.bindValue) {\nthrow new Error('Binding object with bindValue is not allowed.');\n}\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
fix: add missing types (#197)
fixes #196
| 1
|
fix
| null |
815,746
|
17.01.2018 14:26:56
| -7,200
|
f5e99f0aa43f3acd096a44c9cc5ef00625e45172
|
feat: use injection token for module configuration
closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -61,9 +61,16 @@ import {NgSelectModule} from '@ng-select/ng-select';\nexport class AppModule {\n}\n```\n-You can also configure global configuration and localization messages by using NgSelectModule.forRoot:\n+You can also configure global configuration and localization messages by providing custom NG_SELECT_DEFAULT_CONFIG\n```js\n-NgSelectModule.forRoot({notFoundText: 'Your custom not found text', typeToSearchText: 'Your custom type to search text'})\n+ providers: [\n+ {\n+ provide: NG_SELECT_DEFAULT_CONFIG,\n+ useValue: {\n+ notFoundText: 'Custom not found'\n+ }\n+ }\n+ ]\n```\n### SystemJS\nIf you are using SystemJS, you should also adjust your configuration to point to the UMD bundle.\n",
"new_path": "README.md",
"old_path": "README.md"
},
{
"change_type": "MODIFY",
"diff": "@@ -4,7 +4,7 @@ import { HttpClientModule } from '@angular/common/http';\nimport { FormsModule, ReactiveFormsModule } from '@angular/forms';\nimport { BrowserModule } from '@angular/platform-browser';\nimport { RouterModule, Routes } from '@angular/router';\n-import { NgSelectModule } from '@ng-select/ng-select';\n+import { NgSelectModule, NG_SELECT_DEFAULT_CONFIG } from '@ng-select/ng-select';\nimport { NgbModule } from '@ng-bootstrap/ng-bootstrap';\nimport { AppComponent } from './app.component';\n@@ -44,7 +44,7 @@ const appRoutes: Routes = [\n@NgModule({\nimports: [\nBrowserModule,\n- NgSelectModule.forRoot(),\n+ NgSelectModule,\nCommonModule,\nFormsModule,\nReactiveFormsModule,\n@@ -58,7 +58,13 @@ const appRoutes: Routes = [\n)\n],\nproviders: [\n- DataService\n+ DataService,\n+ {\n+ provide: NG_SELECT_DEFAULT_CONFIG,\n+ useValue: {\n+ notFoundText: 'Custom not found'\n+ }\n+ }\n],\ndeclarations: [\nAppComponent,\n",
"new_path": "demo/app/app.module.ts",
"old_path": "demo/app/app.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -4,7 +4,7 @@ import {FormsModule} from '@angular/forms';\nimport {CommonModule} from '@angular/common';\nimport {AppComponent} from './app.component';\n-import {NgSelectModule} from '@ng-select/ng-select';\n+import {NgSelectModule, NG_SELECT_DEFAULT_CONFIG} from '@ng-select/ng-select';\n@NgModule({\ndeclarations: [\n@@ -14,9 +14,16 @@ import {NgSelectModule} from '@ng-select/ng-select';\nCommonModule,\nFormsModule,\nBrowserModule,\n- NgSelectModule.forRoot({clearAllText: ''})\n+ NgSelectModule\n+ ],\n+ providers: [\n+ {\n+ provide: NG_SELECT_DEFAULT_CONFIG,\n+ useValue: {\n+ notFoundText: 'Custom not found'\n+ }\n+ }\n],\n- providers: [],\nbootstrap: [AppComponent]\n})\nexport class AppModule {\n",
"new_path": "integration/src/app/app.module.ts",
"old_path": "integration/src/app/app.module.ts"
},
{
"change_type": "MODIFY",
"diff": "-export { NgSelectComponent } from './ng-select/ng-select.component';\n+export { NgSelectComponent, NG_SELECT_DEFAULT_CONFIG } from './ng-select/ng-select.component';\nexport { NgSelectModule } from './ng-select/ng-select.module';\nexport { NgOption, NgSelectConfig } from './ng-select/ng-select.types';\n",
"new_path": "src/index.ts",
"old_path": "src/index.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -17,9 +17,10 @@ import {\nViewChild,\nElementRef,\nChangeDetectionStrategy,\n- Optional,\n+ Inject,\nSimpleChanges,\n- Renderer2, ContentChildren, QueryList\n+ Renderer2, ContentChildren, QueryList,\n+ InjectionToken\n} from '@angular/core';\nimport { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';\n@@ -30,6 +31,8 @@ import { ItemsList } from './items-list';\nimport { Subject } from 'rxjs/Subject';\nimport { NgOptionComponent } from './ng-option.component';\n+export const NG_SELECT_DEFAULT_CONFIG = new InjectionToken<NgSelectConfig>('ng-select-default-options');\n+\nconst NG_SELECT_VALUE_ACCESSOR = {\nprovide: NG_VALUE_ACCESSOR,\nuseExisting: forwardRef(() => NgSelectComponent),\n@@ -133,7 +136,7 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nreturn this.itemsList.value;\n}\n- constructor( @Optional() config: NgSelectConfig,\n+ constructor(@Inject(NG_SELECT_DEFAULT_CONFIG) config: NgSelectConfig,\nprivate changeDetectorRef: ChangeDetectorRef,\nprivate elementRef: ElementRef,\nprivate renderer: Renderer2\n@@ -669,9 +672,6 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\n}\nprivate mergeGlobalConfig(config: NgSelectConfig) {\n- if (!config) {\n- config = new NgSelectConfig();\n- }\nthis.notFoundText = this.notFoundText || config.notFoundText;\nthis.typeToSearchText = this.typeToSearchText || config.typeToSearchText;\nthis.addTagText = this.addTagText || config.addTagText;\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
},
{
"change_type": "MODIFY",
"diff": "-import { NgModule, ModuleWithProviders } from '@angular/core';\n+import { NgModule } from '@angular/core';\nimport { CommonModule } from '@angular/common';\n-import { NgSelectComponent } from './ng-select.component';\n+import { NgSelectComponent, NG_SELECT_DEFAULT_CONFIG } from './ng-select.component';\nimport { NgOptionTemplateDirective, NgLabelTemplateDirective } from './ng-templates.directive';\nimport { VirtualScrollModule } from './virtual-scroll.component';\nimport { SpinnerComponent } from './spinner.component';\n-import { NgSelectConfig } from './ng-select.types';\nimport { NgOptionComponent } from './ng-option.component';\n@NgModule({\n@@ -24,23 +23,20 @@ import { NgOptionComponent } from './ng-option.component';\nNgOptionComponent,\nNgOptionTemplateDirective,\nNgLabelTemplateDirective\n- ]\n-})\n-export class NgSelectModule {\n- static forRoot(config?: NgSelectConfig): ModuleWithProviders {\n- return provideModule(config);\n- }\n-\n- static forChild(config?: NgSelectConfig): ModuleWithProviders {\n- return provideModule(config);\n+ ],\n+ providers: [\n+ {\n+ provide: NG_SELECT_DEFAULT_CONFIG,\n+ useValue: {\n+ notFoundText: 'No items found',\n+ typeToSearchText: 'Type to search',\n+ addTagText: 'Add item',\n+ loadingText: 'Loading...',\n+ clearAllText: 'Clear all',\n+ disableVirtualScroll: false\n}\n}\n-\n-export function provideModule(config: NgSelectConfig) {\n- return {\n- ngModule: NgSelectModule,\n- providers: [\n- {provide: NgSelectConfig, useValue: config}\n]\n- };\n-}\n+})\n+export class NgSelectModule { }\n+\n",
"new_path": "src/ng-select/ng-select.module.ts",
"old_path": "src/ng-select/ng-select.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -18,11 +18,11 @@ export enum KeyCode {\nBackspace = 8\n}\n-export class NgSelectConfig {\n- notFoundText?= 'No items found';\n- typeToSearchText?= 'Type to search';\n- addTagText?= 'Add item';\n- loadingText?= 'Loading...';\n- clearAllText? = 'Clear all';\n- disableVirtualScroll?= false;\n+export interface NgSelectConfig {\n+ notFoundText?: string;\n+ typeToSearchText?: string;\n+ addTagText?: string;\n+ loadingText?: string;\n+ clearAllText?: string;\n+ disableVirtualScroll?: boolean;\n}\n",
"new_path": "src/ng-select/ng-select.types.ts",
"old_path": "src/ng-select/ng-select.types.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
feat: use injection token for module configuration (#195)
closes https://github.com/ng-select/ng-select/issues/194
| 1
|
feat
| null |
791,690
|
17.01.2018 14:31:58
| 28,800
|
a52378e3a288ff5aba6ed1f85be03ed2a5d3f0a4
|
misc(sentry): update sampled errors list
|
[
{
"change_type": "MODIFY",
"diff": "@@ -23,8 +23,12 @@ const sentryApi = {\nconst SAMPLED_ERRORS = [\n{pattern: /Unable to load/, rate: 0.1},\n{pattern: /Failed to decode/, rate: 0.1},\n- {pattern: /No resource with given id/, rate: 0.01},\n- {pattern: /No node with given id/, rate: 0.01},\n+ {pattern: /activity continued through the end/, rate: 0.1},\n+ {pattern: /All image optimizations failed/, rate: 0.1},\n+ {pattern: /No.*in trace/, rate: 0.1},\n+ {pattern: /No firstMeaningfulPaint found/, rate: 0.1},\n+ {pattern: /No.*resource with given/, rate: 0.01},\n+ {pattern: /No.*node with given id/, rate: 0.01},\n];\n/**\n",
"new_path": "lighthouse-core/lib/sentry.js",
"old_path": "lighthouse-core/lib/sentry.js"
}
] |
JavaScript
|
Apache License 2.0
|
googlechrome/lighthouse
|
misc(sentry): update sampled errors list (#4277)
| 1
|
misc
|
sentry
|
815,746
|
17.01.2018 15:00:58
| -7,200
|
e09eeb56546782d7e1f66065b6cb981a4d8290e1
|
feat: header and footer templates
closes
|
[
{
"change_type": "MODIFY",
"diff": "@@ -234,10 +234,10 @@ export class SelectAutocompleteComponent {\n}\n```\n-### Custom display and option templates\n+### Custom display templates\nThis example in [Plunkr](https://plnkr.co/edit/csZbjH?p=preview)\n-To customize look of input display or option item you can use `ng-template` with `ng-label-tmp` or `ng-option-tmp` directives applied to it.\n+To customize look of ng-select you can use `ng-template` with `ng-label-tmp`, `ng-option-tmp`, `ng-header-tmp`, `ng-footer-tmp` directives applied to it.\n```js\nimport {Component, NgModule} from '@angular/core';\nimport {BrowserModule} from '@angular/platform-browser';\n@@ -254,6 +254,9 @@ import {HttpClient, HttpClientModule} from '@angular/common/http';\nbindLabel=\"title\"\nbindValue=\"id\"\nplaceholder=\"Select album\">\n+ <ng-template ng-header-tmp>\n+ Custom header\n+ </ng-template>\n<ng-template ng-label-tmp let-item=\"item\">\n<b>({{item.id}})</b> {{item.title}}\n</ng-template>\n@@ -261,6 +264,9 @@ import {HttpClient, HttpClientModule} from '@angular/common/http';\n<div>Title: {{item.title}}</div>\n<small><b>Id:</b> {{item.id}} | <b>UserId:</b> {{item.userId}}</small>\n</ng-template>\n+ <ng-template ng-footer-tmp>\n+ Custom footer\n+ </ng-template>\n</ng-select>\n<p>Selected album ID: {{selectedAlbumId || 'none'}}</p>\n`\n",
"new_path": "README.md",
"old_path": "README.md"
},
{
"change_type": "MODIFY",
"diff": "import { Component, ChangeDetectionStrategy } from '@angular/core';\n+import { DataService } from '../shared/data.service';\n@Component({\nselector: 'select-with-templates',\n@@ -48,6 +49,29 @@ import { Component, ChangeDetectionStrategy } from '@angular/core';\n<p>\nSelected city name: {{selectedCity3}}\n</p>\n+ <hr>\n+\n+ <label>Custom header and footer</label>\n+ ---html,true\n+ <ng-select\n+ [multiple]=\"true\"\n+ [items]=\"people\"\n+ [(ngModel)]=\"selectedPeople\"\n+ placeholder=\"Select people\"\n+ bindLabel=\"name\"\n+ bindValue=\"name\">\n+ <ng-template ng-header-tmp>\n+ <button (click)=\"selectAll()\" class=\"btn btn-sm btn-secondary\">Select all</button>\n+ <button (click)=\"unselectAll()\" class=\"btn btn-sm btn-secondary\">Unselect all</button>\n+ </ng-template>\n+ <ng-template ng-footer-tmp>\n+ Selected count: {{selectedPeople.length}}\n+ </ng-template>\n+ </ng-select>\n+ ---\n+ <p>\n+ Selected people: {{selectedPeople}}\n+ </p>\n`\n})\nexport class SelectWithTemplatesComponent {\n@@ -58,14 +82,31 @@ export class SelectWithTemplatesComponent {\n{id: 3, name: 'Pavilnys', avatar: '//www.gravatar.com/avatar/6acb7abf486516ab7fb0a6efa372042b?d=retro&r=g&s=15'}\n];\n- cities2 = JSON.parse(JSON.stringify(this.cities));\n- cities3 = JSON.parse(JSON.stringify(this.cities));\n+ cities2 = this.cities.slice();\n+ cities3 = this.cities.slice();\n+ cities4 = this.cities.slice();\nselectedCity = this.cities[0].name;\nselectedCity2 = this.cities2[1].name;\nselectedCity3 = this.cities3[2].name;\n+ people = [];\n+ selectedPeople = [];\n+\n+ constructor(private dataService: DataService) {}\n+\nngOnInit() {\n+ this.dataService.getPeople().subscribe(items => {\n+ this.people = items;\n+ });\n+ }\n+\n+ selectAll() {\n+ this.selectedPeople = this.people.map(x => x.name);\n+ }\n+\n+ unselectAll() {\n+ this.selectedPeople = [];\n}\n}\n",
"new_path": "demo/app/examples/custom-templates.component.ts",
"old_path": "demo/app/examples/custom-templates.component.ts"
},
{
"change_type": "MODIFY",
"diff": "margin-bottom: .5rem;\nfont-weight: 300;\n}\n+\n+.bd-content {\n+ margin-bottom: 300px;\n+}\n",
"new_path": "demo/style/_content.scss",
"old_path": "demo/style/_content.scss"
},
{
"change_type": "MODIFY",
"diff": "</div>\n<div class=\"ng-select-dropdown-outer\" [class.top]=\"dropdownPosition === 'top'\" [class.bottom]=\"dropdownPosition === 'bottom'\" [ngStyle]=\"{'visibility': isOpen ? 'visible': 'hidden'}\" #dropdownPanel>\n+ <div *ngIf=\"headerTemplate\" class=\"ng-dropdown-header\">\n+ <ng-container [ngTemplateOutlet]=\"headerTemplate\"></ng-container>\n+ </div>\n<virtual-scroll role=\"listbox\" class=\"ng-select-dropdown\" [disabled]=\"disableVirtualScroll\" [bufferAmount]=\"4\" [items]=\"itemsList.filteredItems\" (update)=\"viewPortItems = $event\">\n<div class=\"ng-option\" role=\"option\" (click)=\"toggleItem(item)\" (mousedown)=\"$event.preventDefault()\" (mouseover)=\"onItemHover(item)\"\n*ngFor=\"let item of viewPortItems\"\n{{loadingText}}\n</div>\n</div>\n+\n+ <div *ngIf=\"footerTemplate\" class=\"ng-dropdown-footer\">\n+ <ng-container [ngTemplateOutlet]=\"footerTemplate\"></ng-container>\n+ </div>\n</div>\n",
"new_path": "src/ng-select/ng-select.component.html",
"old_path": "src/ng-select/ng-select.component.html"
},
{
"change_type": "MODIFY",
"diff": "@@ -262,6 +262,16 @@ $color-selected: #f5faff;\n}\n}\n}\n+\n+ .ng-dropdown-header {\n+ border-bottom: 1px solid #ccc;\n+ padding: 5px 7px;\n+ }\n+\n+ .ng-dropdown-footer {\n+ border-top: 1px solid #ccc;\n+ padding: 5px 7px;\n+ }\n}\n@@ -271,7 +281,6 @@ $color-selected: #f5faff;\nborder: 1px solid #ccc;\nbox-shadow: 0 1px 0 rgba(0, 0, 0, 0.06);\nbox-sizing: border-box;\n- max-height: 242px;\nposition: absolute;\nwidth: 100%;\nz-index: 3;\n@@ -314,6 +323,7 @@ $color-selected: #f5faff;\nheight: auto;\n@include box-sizing;\nmax-height: 240px;\n+ margin-bottom: 1px;\noverflow-y: auto;\n.ng-option {\n",
"new_path": "src/ng-select/ng-select.component.scss",
"old_path": "src/ng-select/ng-select.component.scss"
},
{
"change_type": "MODIFY",
"diff": "@@ -678,6 +678,29 @@ describe('NgSelectComponent', function () {\n});\n}));\n+ it('should display custom footer and header template', async(() => {\n+ const fixture = createTestingModule(\n+ NgSelectBasicTestCmp,\n+ `<ng-select [items]=\"cities\" [(ngModel)]=\"selectedCity\">\n+ <ng-template ng-header-tmp>\n+ <span class=\"header-label\">header</span>\n+ </ng-template>\n+ <ng-template ng-footer-tmp>\n+ <span class=\"footer-label\">footer</span>\n+ </ng-template>\n+ </ng-select>`);\n+\n+ fixture.detectChanges();\n+\n+ fixture.whenStable().then(() => {\n+ const header = fixture.debugElement.query(By.css('.header-label')).nativeElement;\n+ expect(header.innerHTML).toBe('header');\n+\n+ const footer = fixture.debugElement.query(By.css('.footer-label')).nativeElement;\n+ expect(footer.innerHTML).toBe('footer');\n+ });\n+ }));\n+\nit('should create items from ng-option', fakeAsync(() => {\nconst fixture = createTestingModule(\nNgSelectBasicTestCmp,\n",
"new_path": "src/ng-select/ng-select.component.spec.ts",
"old_path": "src/ng-select/ng-select.component.spec.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -24,7 +24,12 @@ import {\n} from '@angular/core';\nimport { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';\n-import { NgOptionTemplateDirective, NgLabelTemplateDirective } from './ng-templates.directive';\n+import {\n+ NgOptionTemplateDirective,\n+ NgLabelTemplateDirective,\n+ NgHeaderTemplateDirective,\n+ NgFooterTemplateDirective\n+} from './ng-templates.directive';\nimport { VirtualScrollComponent } from './virtual-scroll.component';\nimport { NgOption, KeyCode, NgSelectConfig } from './ng-select.types';\nimport { ItemsList } from './items-list';\n@@ -57,6 +62,8 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\n@ContentChild(NgOptionTemplateDirective, { read: TemplateRef }) optionTemplate: TemplateRef<any>;\n@ContentChild(NgLabelTemplateDirective, { read: TemplateRef }) labelTemplate: TemplateRef<any>;\n+ @ContentChild(NgHeaderTemplateDirective, { read: TemplateRef }) headerTemplate: TemplateRef<any>;\n+ @ContentChild(NgFooterTemplateDirective, { read: TemplateRef }) footerTemplate: TemplateRef<any>;\n@ViewChild(VirtualScrollComponent) dropdownList: VirtualScrollComponent;\n@ViewChild('dropdownPanel') dropdownPanel: ElementRef;\n@@ -403,6 +410,12 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nthis.itemsList.markItem(item);\n}\n+ detectChanges() {\n+ if (!(<any>this.changeDetectorRef).destroyed) {\n+ this.changeDetectorRef.detectChanges();\n+ }\n+ }\n+\nprivate setItems(items: NgOption[]) {\nconst firstItem = items[0];\nthis.bindLabel = this.bindLabel || this._defaultLabel;\n@@ -653,12 +666,6 @@ export class NgSelectComponent implements OnInit, OnDestroy, OnChanges, AfterVie\nreturn this.typeahead && this.typeahead.observers.length > 0;\n}\n- private detectChanges() {\n- if (!(<any>this.changeDetectorRef).destroyed) {\n- this.changeDetectorRef.detectChanges();\n- }\n- }\n-\nprivate get value() {\nif (this.multiple) {\nreturn this.selectedItems.map(option => option.value);\n",
"new_path": "src/ng-select/ng-select.component.ts",
"old_path": "src/ng-select/ng-select.component.ts"
},
{
"change_type": "MODIFY",
"diff": "import { NgModule } from '@angular/core';\nimport { CommonModule } from '@angular/common';\nimport { NgSelectComponent, NG_SELECT_DEFAULT_CONFIG } from './ng-select.component';\n-import { NgOptionTemplateDirective, NgLabelTemplateDirective } from './ng-templates.directive';\n+import {\n+ NgOptionTemplateDirective,\n+ NgLabelTemplateDirective,\n+ NgHeaderTemplateDirective,\n+ NgFooterTemplateDirective\n+} from './ng-templates.directive';\nimport { VirtualScrollModule } from './virtual-scroll.component';\nimport { SpinnerComponent } from './spinner.component';\nimport { NgOptionComponent } from './ng-option.component';\n@@ -12,6 +17,8 @@ import { NgOptionComponent } from './ng-option.component';\nNgOptionComponent,\nNgOptionTemplateDirective,\nNgLabelTemplateDirective,\n+ NgHeaderTemplateDirective,\n+ NgFooterTemplateDirective,\nSpinnerComponent\n],\nimports: [\n@@ -22,7 +29,10 @@ import { NgOptionComponent } from './ng-option.component';\nNgSelectComponent,\nNgOptionComponent,\nNgOptionTemplateDirective,\n- NgLabelTemplateDirective\n+ NgLabelTemplateDirective,\n+ NgHeaderTemplateDirective,\n+ NgFooterTemplateDirective\n+\n],\nproviders: [\n{\n@@ -39,4 +49,3 @@ import { NgOptionComponent } from './ng-option.component';\n]\n})\nexport class NgSelectModule { }\n-\n",
"new_path": "src/ng-select/ng-select.module.ts",
"old_path": "src/ng-select/ng-select.module.ts"
},
{
"change_type": "MODIFY",
"diff": "@@ -11,3 +11,15 @@ export class NgLabelTemplateDirective {\nconstructor(public template: TemplateRef<any>) {\n}\n}\n+\n+@Directive({ selector: '[ng-header-tmp]' })\n+export class NgHeaderTemplateDirective {\n+ constructor(public template: TemplateRef<any>) {\n+ }\n+}\n+\n+@Directive({ selector: '[ng-footer-tmp]' })\n+export class NgFooterTemplateDirective {\n+ constructor(public template: TemplateRef<any>) {\n+ }\n+}\n",
"new_path": "src/ng-select/ng-templates.directive.ts",
"old_path": "src/ng-select/ng-templates.directive.ts"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
feat: header and footer templates (#193)
closes https://github.com/ng-select/ng-select/issues/184
| 1
|
feat
| null |
815,746
|
18.01.2018 09:44:44
| -7,200
|
b9d3963975480edb8dbafeaf0ad8558d49dad63a
|
chore(release): 0.15.2
|
[
{
"change_type": "MODIFY",
"diff": "All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.\n+<a name=\"0.15.2\"></a>\n+## [0.15.2](https://github.com/ng-select/ng-select/compare/v0.15.1...v0.15.2) (2018-01-18)\n+\n+\n+### Bug Fixes\n+\n+* make filter readonly if not searchable ([#199](https://github.com/ng-select/ng-select/issues/199)) ([47d1087](https://github.com/ng-select/ng-select/commit/47d1087))\n+\n+\n+\n<a name=\"0.15.1\"></a>\n## [0.15.1](https://github.com/ng-select/ng-select/compare/v0.15.0...v0.15.1) (2018-01-17)\n",
"new_path": "CHANGELOG.md",
"old_path": "CHANGELOG.md"
},
{
"change_type": "MODIFY",
"diff": "{\n\"name\": \"@ng-select/ng-select\",\n- \"version\": \"0.15.1\",\n+ \"version\": \"0.15.2\",\n\"description\": \"Angular ng-select - All in One UI Select, Multiselect and Autocomplete\",\n\"author\": \"@ng-select/ng-select\",\n\"license\": \"MIT\",\n",
"new_path": "src/package.json",
"old_path": "src/package.json"
}
] |
TypeScript
|
MIT License
|
ng-select/ng-select
|
chore(release): 0.15.2
| 1
|
chore
|
release
|
807,849
|
18.01.2018 13:01:31
| 28,800
|
927ee98fb6df69d136527fc15ac51b66960a376a
|
chore: use fs-extra JSON methods in helpers/updateLernaConfig
|
[
{
"change_type": "MODIFY",
"diff": "@@ -16,8 +16,7 @@ module.exports = updateLernaConfig;\n*/\nasync function updateLernaConfig(testDir, updates) {\nconst lernaJsonLocation = path.join(testDir, \"lerna.json\");\n- const lernaJsonContent = await fs.readFile(lernaJsonLocation);\n- const lernaJson = JSON.parse(lernaJsonContent);\n+ const lernaJson = await fs.readJson(lernaJsonLocation);\nObject.assign(lernaJson, updates);\n- await fs.writeFile(lernaJsonLocation, JSON.stringify(lernaJson, null, 2));\n+ await fs.writeJson(lernaJsonLocation, lernaJson, { spaces: 2 });\n}\n",
"new_path": "test/helpers/updateLernaConfig.js",
"old_path": "test/helpers/updateLernaConfig.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: use fs-extra JSON methods in helpers/updateLernaConfig
| 1
|
chore
| null |
807,849
|
18.01.2018 13:02:08
| 28,800
|
71c2cacaa3c542ac045ecc39d845eb098153c7a5
|
chore: localize fixture init in PublishCommand conventional-commits tests
|
[
{
"change_type": "MODIFY",
"diff": "@@ -789,15 +789,11 @@ describe(\"PublishCommand\", () => {\n* ======================================================================= */\ndescribe(\"--conventional-commits\", () => {\n- let testDir;\n-\ndescribe(\"independent mode\", () => {\nconst recommendIndependentVersionOriginal = ConventionalCommitUtilities.recommendIndependentVersion;\nconst updateIndependentChangelogOriginal = ConventionalCommitUtilities.updateIndependentChangelog;\nbeforeEach(async () => {\n- testDir = await initFixture(\"PublishCommand/independent\");\n-\nconst reccomendReplies = [\"1.0.1\", \"1.1.0\", \"2.0.0\", \"1.1.0\", \"5.1.1\"];\nConventionalCommitUtilities.recommendIndependentVersion = jest.fn(() => reccomendReplies.shift());\nConventionalCommitUtilities.updateIndependentChangelog = jest.fn();\n@@ -809,6 +805,8 @@ describe(\"PublishCommand\", () => {\n});\nit(\"should use conventional-commits utility to guess version bump and generate CHANGELOG\", async () => {\n+ const testDir = await initFixture(\"PublishCommand/independent\");\n+\nawait run(testDir)(\"--conventional-commits\");\nexpect(gitAddedFiles(testDir)).toMatchSnapshot(\"git added files\");\n@@ -835,6 +833,7 @@ describe(\"PublishCommand\", () => {\n});\nit(\"accepts --changelog-preset option\", async () => {\n+ const testDir = await initFixture(\"PublishCommand/independent\");\nconst name = \"package-3\";\nconst version = \"3.0.0\";\nconst location = path.join(testDir, \"packages\", name);\n@@ -864,8 +863,6 @@ describe(\"PublishCommand\", () => {\nconst updateFixedChangelogOriginal = ConventionalCommitUtilities.updateFixedChangelog;\nbeforeEach(async () => {\n- testDir = await initFixture(\"PublishCommand/normal\");\n-\nconst reccomendReplies = [\"1.0.1\", \"1.1.0\", \"2.0.0\", \"1.1.0\", \"5.1.1\"];\nConventionalCommitUtilities.recommendFixedVersion = jest.fn(() => reccomendReplies.shift());\nConventionalCommitUtilities.updateFixedRootChangelog = jest.fn();\n@@ -879,6 +876,8 @@ describe(\"PublishCommand\", () => {\n});\nit(\"should use conventional-commits utility to guess version bump and generate CHANGELOG\", async () => {\n+ const testDir = await initFixture(\"PublishCommand/normal\");\n+\nawait run(testDir)(\"--conventional-commits\");\nexpect(gitAddedFiles(testDir)).toMatchSnapshot(\"git added files\");\n@@ -914,6 +913,7 @@ describe(\"PublishCommand\", () => {\n});\nit(\"accepts --changelog-preset option\", async () => {\n+ const testDir = await initFixture(\"PublishCommand/normal\");\nconst name = \"package-5\";\nconst version = \"1.0.0\";\nconst location = path.join(testDir, \"packages\", name);\n",
"new_path": "test/PublishCommand.js",
"old_path": "test/PublishCommand.js"
}
] |
JavaScript
|
MIT License
|
lerna/lerna
|
chore: localize fixture init in PublishCommand conventional-commits tests
| 1
|
chore
| null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.