Datasets:

Rami

/

my_section_5

like 0

<p>I just started playing with Python and was hoping to get some feedback regarding the quality of the following snippet. Does this look like proper Python? What would you change? Is this small script well structured?</p> <p>Quick description of functional goal: reorder list such that each element is followed by the value closest to it, starting from 20 (AKA shortest-seek-first algorithm).</p> <p>example: <code>[15, 24, 12, 13, 48, 56, 2]</code><br> becomes: <code>[24, 15, 13, 12, 2, 48, 56]</code></p> <p>better example: <code>[22, 19, 23, 18, 17, 16]</code><br> becomes: <code>[19, 18, 17, 16, 22, 23]</code></p> <pre><code>fcfs_working = [15, 24, 12, 13, 48, 56, 2] fcfs_track = [] track_number = 20 while len(fcfs_working) &gt; 0: track_number = min(fcfs_working, key=lambda x:abs(x-track_number)) fcfs_working.remove(track_number) fcfs_track.append(track_number) </code></pre>

5548

GOOD_ANSWER

<p>I just started playing with Python and was hoping to get some feedback regarding the quality of the following snippet. Does this look like proper Python? What would you change? Is this small script well structured?</p> <p>Quick description of functional goal: reorder list such that each element is followed by the value closest to it, starting from 20 (AKA shortest-seek-first algorithm).</p> <p>example: <code>[15, 24, 12, 13, 48, 56, 2]</code><br> becomes: <code>[24, 15, 13, 12, 2, 48, 56]</code></p> <p>better example: <code>[22, 19, 23, 18, 17, 16]</code><br> becomes: <code>[19, 18, 17, 16, 22, 23]</code></p> <pre><code>fcfs_working = [15, 24, 12, 13, 48, 56, 2] fcfs_track = [] track_number = 20 while len(fcfs_working) &gt; 0: track_number = min(fcfs_working, key=lambda x:abs(x-track_number)) fcfs_working.remove(track_number) fcfs_track.append(track_number) </code></pre>

5548

WEIRD

<p>I just started playing with Python and was hoping to get some feedback regarding the quality of the following snippet. Does this look like proper Python? What would you change? Is this small script well structured?</p> <p>Quick description of functional goal: reorder list such that each element is followed by the value closest to it, starting from 20 (AKA shortest-seek-first algorithm).</p> <p>example: <code>[15, 24, 12, 13, 48, 56, 2]</code><br> becomes: <code>[24, 15, 13, 12, 2, 48, 56]</code></p> <p>better example: <code>[22, 19, 23, 18, 17, 16]</code><br> becomes: <code>[19, 18, 17, 16, 22, 23]</code></p> <pre><code>fcfs_working = [15, 24, 12, 13, 48, 56, 2] fcfs_track = [] track_number = 20 while len(fcfs_working) &gt; 0: track_number = min(fcfs_working, key=lambda x:abs(x-track_number)) fcfs_working.remove(track_number) fcfs_track.append(track_number) </code></pre>

5548

GOOD_ANSWER

<p>I'm working on a feature for the <a href="http://github.com/jessemiller/HamlPy" rel="nofollow">HamlPy (Haml for Django)</a> project:</p> <h2>About Haml</h2> <p>For those who don't know, Haml is an indentation-based markup language which compiles to HTML:</p> <pre><code>%ul#atheletes - for athelete in athelete_list %li.athelete{'id': 'athelete_{{ athelete.pk }}'}= athelete.name </code></pre> <p>compiles to</p> <pre><code>&lt;ul id='atheletes'&gt; {% for athelete in athelete_list %} &lt;li class='athelete' id='athelete_{{ athelete.pk }}'&gt;{{ athelete.name }}&lt;/li&gt; {% endfor %} &lt;/ul&gt; </code></pre> <h2>The code</h2> <p><code>{'id': 'athelete_{{ athelete.pk }}'}</code> is referred to as the 'attribute dictionary'. It is an (almost) valid Python dictionary and is currently parsed with some very ugly regular expressions and an <code>eval()</code>. However, I would like to add some features to it that would no longer make it a valid Python dictionary, e.g. using Haml within the attributes:</p> <pre><code>%a.link{ 'class': - if forloop.first link-first - else - if forloop.last link-last 'href': - url some_view } </code></pre> <p>among other things.</p> <p>I began by writing a class which I could swap out for the eval and would pass all of the current tests: </p> <pre><code>import re # Valid characters for dictionary key re_key = re.compile(r'[a-zA-Z0-9-_]+') re_nums = re.compile(r'[0-9\.]+') class AttributeParser: """Parses comma-separated HamlPy attribute values""" def __init__(self, data, terminator): self.terminator=terminator self.s = data.lstrip() # Index of current character being read self.ptr=1 def consume_whitespace(self, include_newlines=False): """Moves the pointer to the next non-whitespace character""" whitespace = (' ', '\t', '\r', '\n') if include_newlines else (' ', '\t') while self.ptr&lt;len(self.s) and self.s[self.ptr] in whitespace: self.ptr+=1 return self.ptr def consume_end_of_value(self): # End of value comma or end of string self.ptr=self.consume_whitespace() if self.s[self.ptr] != self.terminator: if self.s[self.ptr] == ',': self.ptr+=1 else: raise Exception("Expected comma for end of value (after ...%s), but got '%s' instead" % (self.s[max(self.ptr-10,0):self.ptr], self.s[self.ptr])) def read_until_unescaped_character(self, closing, pos=0): """ Moves the dictionary string starting from position *pos* until a *closing* character not preceded by a backslash is found. Returns a tuple containing the string which was read (without any preceding backslashes) and the number of characters which were read. """ initial_pos=pos while pos&lt;len(self.s): if self.s[pos]==closing and (pos==initial_pos or self.s[pos-1]!='\\'): break pos+=1 return (self.s[initial_pos:pos].replace('\\'+closing,closing), pos-initial_pos+1) def parse_value(self): self.ptr=self.consume_whitespace() # Invalid initial value val=False if self.s[self.ptr]==self.terminator: return val # String if self.s[self.ptr] in ("'",'"'): quote=self.s[self.ptr] self.ptr += 1 val,characters_read = self.read_until_unescaped_character(quote, pos=self.ptr) self.ptr += characters_read # Django variable elif self.s[self.ptr:self.ptr+2] == '={': self.ptr+=2 val,characters_read = self.read_until_unescaped_character('}', pos=self.ptr) self.ptr += characters_read val="{{ %s }}" % val # Django tag elif self.s[self.ptr:self.ptr+2] in ['-{', '#{']: self.ptr+=2 val,characters_read = self.read_until_unescaped_character('}', pos=self.ptr) self.ptr += characters_read val=r"{%% %s %%}" % val # Boolean Attributes elif self.s[self.ptr:self.ptr+4] in ['none','None']: val = None self.ptr+=4 # Integers and floats else: match=re_nums.match(self.s[self.ptr:]) if match: val = match.group(0) self.ptr += len(val) if val is False: raise Exception("Failed to parse dictionary value beginning at: %s" % self.s[self.ptr:]) self.consume_end_of_value() return val class AttributeDictParser(AttributeParser): """ Parses a Haml element's attribute dictionary string and provides a Python dictionary of the element attributes """ def __init__(self, s): AttributeParser.__init__(self, s, '}') self.dict={} def parse(self): while self.ptr&lt;len(self.s)-1: key = self.__parse_key() # Tuple/List parsing self.ptr=self.consume_whitespace() if self.s[self.ptr] in ('(', '['): tl_parser = AttributeTupleAndListParser(self.s[self.ptr:]) val = tl_parser.parse() self.ptr += tl_parser.ptr self.consume_end_of_value() else: val = self.parse_value() self.dict[key]=val return self.dict def __parse_key(self): '''Parse key variable and consume up to the colon''' self.ptr=self.consume_whitespace(include_newlines=True) # Consume opening quote quote=None if self.s[self.ptr] in ("'",'"'): quote = self.s[self.ptr] self.ptr += 1 # Extract key if quote: key,characters_read = self.read_until_unescaped_character(quote, pos=self.ptr) self.ptr+=characters_read else: key_match = re_key.match(self.s[self.ptr:]) if key_match is None: raise Exception("Invalid key beginning at: %s" % self.s[self.ptr:]) key = key_match.group(0) self.ptr += len(key) # Consume colon ptr=self.consume_whitespace() if self.s[self.ptr]==':': self.ptr+=1 else: raise Exception("Expected colon for end of key (after ...%s), but got '%s' instead" % (self.s[max(self.ptr-10,0):self.ptr], self.s[self.ptr])) return key def render_attributes(self): attributes=[] for k, v in self.dict.items(): if k != 'id' and k != 'class': # Boolean attributes if v==None: attributes.append( "%s" % (k,)) else: attributes.append( "%s='%s'" % (k,v)) return ' '.join(attributes) class AttributeTupleAndListParser(AttributeParser): def __init__(self, s): if s[0]=='(': terminator = ')' elif s[0]=='[': terminator = ']' AttributeParser.__init__(self, s, terminator) def parse(self): lst=[] # Todo: Must be easier way... val=True while val != False: val = self.parse_value() if val != False: lst.append(val) self.ptr +=1 if self.terminator==')': return tuple(lst) else: return lst </code></pre> <p>The class can be used stand-alone as follows:</p> <pre><code>&gt;&gt;&gt; from attribute_dict_parser import AttributeDictParser &gt;&gt;&gt; a=AttributeDictParser("{'id': 'a', 'class': 'b'}") &gt;&gt;&gt; d=a.parse() &gt;&gt;&gt; d {'id': 'a', 'class': 'b'} &gt;&gt;&gt; type(d) &lt;type 'dict'&gt; </code></pre> <p><code>AttributeDictParser</code> iterates through characters in <code>s</code> (the attribute dictionary) and uses the variable <code>ptr</code> to track its location (to prevent unnecessary string splicing). The function <code>parse_key</code> parses the keys (<code>'id':</code> and <code>'class':</code>), and the function <code>parse_value</code> parses the values (<code>'a'</code> and <code>'b'</code>). parse_value works with data types other than strings. It returns <code>False</code> if it reaches the end of the attribute dictionary, because <code>Null</code> is a valid value to return.</p> <p><code>AttributeTupleAndListParser</code> parses list and tuple values, as these are valid values (e.g. <code>{'id': ['a','b','c']}</code>. </p> <p>Both of these classes inherit from <code>AttributeParser</code> because they share the same way of parsing values.</p> <h2>Questions:</h2> <ol> <li><p>Is this a sensible approach? Am I insane to think that I can move from <code>eval()</code>ing the code as a Python dictionary to a custom parser without causing issues for users, just because it passes the tests?</p></li> <li><p>I'm worried that the performance hit of writing a parser in an interpreted language will be too much compared to doing the <code>eval()</code>. I've written similar things before for parsing JSON expressions, and was dismayed that for all my optimisations, the two-line regular expression won on the benchmarks. I will do some profiling on it once I've tidied up a few things. Are there any notable ineffeciencies in my approach?</p></li> <li><p>There are some things in the old parser that have not been ported to the new one (e.g. supporting the Ruby Haml <code>=&gt;</code> syntax). This feature has never been documented however and I doubt anybody knows it's there. What is a good rule of thumb for breaking an undocumented feature in open source projects?</p></li> <li><p>I would welcome any feedback on my coding style, as I don't get to be around other developers much.</p></li> </ol>

15395

GOOD_ANSWER

<p>I'm trying to learn how to write functional code with Python and have found some tutorials online. Please note that I know Python is not a promoter for functional programming. I just want to try it out. <a href="http://anandology.com/python-practice-book/functional-programming.html">One tutorial</a> in particular gives this as an exercise:</p> <blockquote> <p>Write a function flatten_dict to flatten a nested dictionary by joining the keys with . character.</p> </blockquote> <p>So I decided to give it a try. Here is what I have and it works fine:</p> <pre><code>def flatten_dict(d, result={}, prv_keys=[]): for k, v in d.iteritems(): if isinstance(v, dict): flatten_dict(v, result, prv_keys + [k]) else: result['.'.join(prv_keys + [k])] = v return result </code></pre> <p>I'd like to know whether this is the best way to solve the problem in python. In particular, I really don't like to pass a list of previous keys to the recursive call. </p>

21033

<p>I'm trying to learn how to write functional code with Python and have found some tutorials online. Please note that I know Python is not a promoter for functional programming. I just want to try it out. <a href="http://anandology.com/python-practice-book/functional-programming.html">One tutorial</a> in particular gives this as an exercise:</p> <blockquote> <p>Write a function flatten_dict to flatten a nested dictionary by joining the keys with . character.</p> </blockquote> <p>So I decided to give it a try. Here is what I have and it works fine:</p> <pre><code>def flatten_dict(d, result={}, prv_keys=[]): for k, v in d.iteritems(): if isinstance(v, dict): flatten_dict(v, result, prv_keys + [k]) else: result['.'.join(prv_keys + [k])] = v return result </code></pre> <p>I'd like to know whether this is the best way to solve the problem in python. In particular, I really don't like to pass a list of previous keys to the recursive call. </p>

21033

GOOD_ANSWER

<p>I have a grid as </p> <pre><code>&gt;&gt;&gt; data = np.zeros((3, 5)) &gt;&gt;&gt; data array([[ 0., 0., 0., 0., 0.], [ 0., 0., 0., 0., 0.], [ 0., 0., 0., 0., 0.]] </code></pre> <p>i wrote a function in order to get the ID of each tile.</p> <pre><code>array([[(0,0), (0,1), (0,2), (0,3), (0,4)], [(1,0), (1,1), (1,2), (1,3), (1,4)], [(2,0), (2,1), (2,2), (2,3), (2,4)]] def get_IDgrid(nx,ny): lstx = list() lsty = list() lstgrid = list() for p in xrange(ny): lstx.append([p]*nx) for p in xrange(ny): lsty.append(range(0,nx)) for p in xrange(ny): lstgrid.extend(zip(lstx[p],lsty[p])) return lstgrid </code></pre> <p>where nx is the number of columns and ny the number of rows</p> <pre><code>test = get_IDgrid(5,3) print test [(0, 0), (0, 1), (0, 2), (0, 3), (0, 4), (1, 0), (1, 1), (1, 2), (1, 3), (1, 4), (2, 0), (2, 1), (2, 2), (2, 3), (2, 4)] </code></pre> <p>this function will be embed inside a class</p> <pre><code>class Grid(object): __slots__= ("xMin","yMax","nx","ny","xDist","yDist","ncell") def __init__(self,xMin,yMax,nx,ny,xDist,yDist): self.xMin = xMin self.yMax = yMax self.nx = nx self.ny = ny self.xDist = xDist self.yDist= yDist self.ncell = nx*ny </code></pre>

22968

GOOD_ANSWER

<p>I have been working on a project where I needed to analyze multiple, large datasets contained inside many CSV files at the same time. I am not a programmer but an engineer, so I did a lot of searching and reading. Python's stock CSV module provides the basic functionality, but I had a lot of trouble getting the methods to run quickly on 50k-500k rows since many strategies were simply appending. I had lots of problems getting what I wanted and I saw the same questions asked over and over again. I decided to spend some time and write a class that performed these functions and would be portable. If nothing else, myself and other people I work with could use it.</p> <p>I would like some input on the class and any suggestions you may have. I am not a programmer and don't have any formal background so this has been a good OOP intro for me. The end result is in two lines you can read all CSV files in a folder into memory as either pure Python lists or, as lists of NumPy arrays. I have tested it in many scenarios and hopefully found most of the bugs. I'd like to think this is good enough that other people can just copy and paste into their code and move on to the more important stuff. I am open to all critiques and suggestions. Is this something you could use? If not, why?</p> <p>You can try it with generic CSV data. The standard Python lists are flexible in size and data type. NumPy will only work with numeric (float specifically) data that is rectangular in format:</p> <pre><code>x, y, z, 1, 2, 3, 4, 5, 6, ... import numpy as np import csv import os import sys class EasyCSV(object): """Easily open from and save CSV files using lists or numpy arrays. Initiating and using the class is as easy as CSV = EasyCSV('location'). The class takes the following arguements: EasyCSV(location, width=None, np_array='false', skip_rows=0) location is the only mandatory field and is string of the folder location containing .CSV file(s). width is optional and specifies a constant width. The default value None will return a list of lists with variable width. When used with numpy the array will have the dimensions of the first valid numeric row of data. np_array will create a fixed-width numpy array of only float values. skip_rows will skip the specified rows at the top of the file. """ def __init__(self, location, width=None, np_array='false', skip_rows=0): # Initialize default vairables self.np_array = np_array self.skip_rows = skip_rows self.loc = str(location) os.chdir(self.loc) self.dataFiles = [] self.width = width self.i = 0 #Find all CSV files in chosen directory. for files in os.listdir(loc): if files.endswith('CSV') or files.endswith('csv'): self.dataFiles.append(files) #Preallocate array to hold csv data later self.allData = [0] * len(self.dataFiles) def read(self,): '''Reads all files contained in the folder into memory. ''' self.Dict = {} #Stores names of files for later lookup #Main processig loop for files in self.dataFiles: self.trim = 0 self.j = 0 with open(files,'rb') as self.rawFile: print files #Read in CSV object self.newData = csv.reader(self.rawFile) self.dataList = [] #Extend iterates through CSV object and passes to datalist self.dataList.extend(self.newData) #Trims off pre specified lines at the top if self.skip_rows != 0: self.dataList = self.dataList[self.skip_rows:] #Numpy route, requires all numeric input if self.np_array == 'true': #Finds width if not specified if self.width is None: self.width = len(self.dataList[self.skip_rows]) self.CSVdata = np.zeros((len(self.dataList),self.width)) #Iterate through data and adds it to numpy array self.k = 0 for data in self.dataList: try: self.CSVdata[self.j,:] = data self.j+=1 except ValueError: #non numeric data if self.width &lt; len(data): sys.exit('Numpy array too narrow. Choose another width') self.trim+=1 pass self.k+=1 #trims off excess if not self.trim == 0: self.CSVdata = self.CSVdata[:-self.trim] #Python nested lists route; tolerates multiple data types else: #Declare required empty str arrays self.CSVdata = [0]*len(self.dataList) for rows in self.dataList: self.k = 0 self.rows = rows #Handle no width imput, flexible width if self.width is None: self.numrow = [0]*len(self.rows) else: self.numrow = [0]*self.width #Try to convert to float, fall back on string. for data in self.rows: try: self.numrow[self.k] = float(data) except ValueError: try: self.numrow[self.k] = data except IndexError: pass except IndexError: pass self.k+=1 self.CSVdata[self.j] = self.numrow self.j+=1 #append file to allData which contains all files self.allData[self.i] = self.CSVdata #trim CSV off filename and store in Dict for indexing of allData self.dataFiles[self.i] = self.dataFiles[self.i][:-4] self.Dict[self.dataFiles[self.i]] = self.i self.i+=1 def write(self, array, name, destination=None): '''Writes array in memory to file. EasyCSV.write(array, name, destination=None) array is a pointer to the array you want written to CSV name will be the name of said file destination is optional and will change the directory to the location specified. Leaving it at the default value None will overwrite any CSVs that may have been read in by the class earlier. ''' self.array = array self.name = name self.dest = destination #Optional change directory if self.dest is not None: os.chdir(self.dest) #Dict does not hold CSV, check to see if present and trim if not self.name[-4:] == '.CSV' or self.name[-4:] == '.csv': self.name = name + '.CSV' #Create files and write data, 'wb' binary req'd for Win compatibility with open(self.name,'wb') as self.newCSV: self.CSVwrite = csv.writer(self.newCSV,dialect='excel') for data in self.array: self.CSVwrite.writerow(data) os.chdir(self.loc) #Change back to original __init__.loc def lookup(self, key=None): '''Prints a preview of data to the console window with just a key input ''' self.key = key #Dict does not hold CSV, check to see if present and trim if self.key[-4:] == '.CSV' or self.key[-4:] == '.csv': self.key = key[:-4] #Print None case elif self.key is None: print self.allData[0] print self.allData[0] print '... ' * len(self.allData[0][-2]) print self.allData[0][-2] print self.allData[0] #Print everything else else: self.index = self.Dict[self.key] print self.allData[self.index][0] print self.allData[self.index][1] print '... ' * len(self.allData[self.index][-2]) print self.allData[self.index][-2] print self.allData[self.index][-1] def output(self, key=None): '''Returns the array for assignment to a var with just a key input ''' self.key = key #Dict does not hold CSV, check to see if present and trim if self.key is None: return self.allData[0] elif self.key[-4:] == '.CSV' or self.key[-4:] == '.csv': self.key = key[:-4] #Return file requested self.index = self.Dict[self.key] return self.allData[self.Dict[self.key]] ################################################ loc = 'C:\Users\Me\Desktop' CSV = EasyCSV(loc, np_array='false', width=None, skip_rows=0) CSV.read() target = 'somecsv' #with or without .csv/.CSV CSV.lookup(target) A = CSV.output(target) loc2 = 'C:\Users\Me\Desktop\New folder' for keys in CSV.Dict: print keys CSV.write(CSV.output(keys),keys,destination=loc2) </code></pre>

24836

GOOD_ANSWER

<p>I have been working on a project where I needed to analyze multiple, large datasets contained inside many CSV files at the same time. I am not a programmer but an engineer, so I did a lot of searching and reading. Python's stock CSV module provides the basic functionality, but I had a lot of trouble getting the methods to run quickly on 50k-500k rows since many strategies were simply appending. I had lots of problems getting what I wanted and I saw the same questions asked over and over again. I decided to spend some time and write a class that performed these functions and would be portable. If nothing else, myself and other people I work with could use it.</p> <p>I would like some input on the class and any suggestions you may have. I am not a programmer and don't have any formal background so this has been a good OOP intro for me. The end result is in two lines you can read all CSV files in a folder into memory as either pure Python lists or, as lists of NumPy arrays. I have tested it in many scenarios and hopefully found most of the bugs. I'd like to think this is good enough that other people can just copy and paste into their code and move on to the more important stuff. I am open to all critiques and suggestions. Is this something you could use? If not, why?</p> <p>You can try it with generic CSV data. The standard Python lists are flexible in size and data type. NumPy will only work with numeric (float specifically) data that is rectangular in format:</p> <pre><code>x, y, z, 1, 2, 3, 4, 5, 6, ... import numpy as np import csv import os import sys class EasyCSV(object): """Easily open from and save CSV files using lists or numpy arrays. Initiating and using the class is as easy as CSV = EasyCSV('location'). The class takes the following arguements: EasyCSV(location, width=None, np_array='false', skip_rows=0) location is the only mandatory field and is string of the folder location containing .CSV file(s). width is optional and specifies a constant width. The default value None will return a list of lists with variable width. When used with numpy the array will have the dimensions of the first valid numeric row of data. np_array will create a fixed-width numpy array of only float values. skip_rows will skip the specified rows at the top of the file. """ def __init__(self, location, width=None, np_array='false', skip_rows=0): # Initialize default vairables self.np_array = np_array self.skip_rows = skip_rows self.loc = str(location) os.chdir(self.loc) self.dataFiles = [] self.width = width self.i = 0 #Find all CSV files in chosen directory. for files in os.listdir(loc): if files.endswith('CSV') or files.endswith('csv'): self.dataFiles.append(files) #Preallocate array to hold csv data later self.allData = [0] * len(self.dataFiles) def read(self,): '''Reads all files contained in the folder into memory. ''' self.Dict = {} #Stores names of files for later lookup #Main processig loop for files in self.dataFiles: self.trim = 0 self.j = 0 with open(files,'rb') as self.rawFile: print files #Read in CSV object self.newData = csv.reader(self.rawFile) self.dataList = [] #Extend iterates through CSV object and passes to datalist self.dataList.extend(self.newData) #Trims off pre specified lines at the top if self.skip_rows != 0: self.dataList = self.dataList[self.skip_rows:] #Numpy route, requires all numeric input if self.np_array == 'true': #Finds width if not specified if self.width is None: self.width = len(self.dataList[self.skip_rows]) self.CSVdata = np.zeros((len(self.dataList),self.width)) #Iterate through data and adds it to numpy array self.k = 0 for data in self.dataList: try: self.CSVdata[self.j,:] = data self.j+=1 except ValueError: #non numeric data if self.width &lt; len(data): sys.exit('Numpy array too narrow. Choose another width') self.trim+=1 pass self.k+=1 #trims off excess if not self.trim == 0: self.CSVdata = self.CSVdata[:-self.trim] #Python nested lists route; tolerates multiple data types else: #Declare required empty str arrays self.CSVdata = [0]*len(self.dataList) for rows in self.dataList: self.k = 0 self.rows = rows #Handle no width imput, flexible width if self.width is None: self.numrow = [0]*len(self.rows) else: self.numrow = [0]*self.width #Try to convert to float, fall back on string. for data in self.rows: try: self.numrow[self.k] = float(data) except ValueError: try: self.numrow[self.k] = data except IndexError: pass except IndexError: pass self.k+=1 self.CSVdata[self.j] = self.numrow self.j+=1 #append file to allData which contains all files self.allData[self.i] = self.CSVdata #trim CSV off filename and store in Dict for indexing of allData self.dataFiles[self.i] = self.dataFiles[self.i][:-4] self.Dict[self.dataFiles[self.i]] = self.i self.i+=1 def write(self, array, name, destination=None): '''Writes array in memory to file. EasyCSV.write(array, name, destination=None) array is a pointer to the array you want written to CSV name will be the name of said file destination is optional and will change the directory to the location specified. Leaving it at the default value None will overwrite any CSVs that may have been read in by the class earlier. ''' self.array = array self.name = name self.dest = destination #Optional change directory if self.dest is not None: os.chdir(self.dest) #Dict does not hold CSV, check to see if present and trim if not self.name[-4:] == '.CSV' or self.name[-4:] == '.csv': self.name = name + '.CSV' #Create files and write data, 'wb' binary req'd for Win compatibility with open(self.name,'wb') as self.newCSV: self.CSVwrite = csv.writer(self.newCSV,dialect='excel') for data in self.array: self.CSVwrite.writerow(data) os.chdir(self.loc) #Change back to original __init__.loc def lookup(self, key=None): '''Prints a preview of data to the console window with just a key input ''' self.key = key #Dict does not hold CSV, check to see if present and trim if self.key[-4:] == '.CSV' or self.key[-4:] == '.csv': self.key = key[:-4] #Print None case elif self.key is None: print self.allData[0] print self.allData[0] print '... ' * len(self.allData[0][-2]) print self.allData[0][-2] print self.allData[0] #Print everything else else: self.index = self.Dict[self.key] print self.allData[self.index][0] print self.allData[self.index][1] print '... ' * len(self.allData[self.index][-2]) print self.allData[self.index][-2] print self.allData[self.index][-1] def output(self, key=None): '''Returns the array for assignment to a var with just a key input ''' self.key = key #Dict does not hold CSV, check to see if present and trim if self.key is None: return self.allData[0] elif self.key[-4:] == '.CSV' or self.key[-4:] == '.csv': self.key = key[:-4] #Return file requested self.index = self.Dict[self.key] return self.allData[self.Dict[self.key]] ################################################ loc = 'C:\Users\Me\Desktop' CSV = EasyCSV(loc, np_array='false', width=None, skip_rows=0) CSV.read() target = 'somecsv' #with or without .csv/.CSV CSV.lookup(target) A = CSV.output(target) loc2 = 'C:\Users\Me\Desktop\New folder' for keys in CSV.Dict: print keys CSV.write(CSV.output(keys),keys,destination=loc2) </code></pre>

24836

GOOD_ANSWER

<p>As a follow-up to my previous <a href="https://codereview.stackexchange.com/questions/26071/computation-of-prefix-free-codes-with-many-repeated-weight-values-in-reduced-spa">question</a> about prefix free code, I learned about the module unittest and wrote the following set of functions, to be used in order to semi-automatically check the optimality of the output of any new algorithm to compute prefix free code.</p> <p>The code works but I would like it to be as elegant (and compact) as possible in order to potentially include it in a research article, in a more formal and reproducible maneer than the traditional "algorithm". I am proud of how it looks, but I do expect you to still criticize it!!!</p> <pre><code>import unittest, doctest, math def codeIsPrefixFreeCodeMinimal(L,W): """Checks if the prefix free code described by an array $L$ of pairs $(codeLenght_i,nbWeights_i)$ is minimal for weights $W$, by 1) checking if the code respects Kraft's inequality and 2) comparing the lenght of a code encoded with $L$ with the entropy of $W$. """ assert respectsKraftInequality(L) return compressedTextLenght(L,W) &lt;= NTimesEntropy(W)+len(W) def respectsKraftInequality(L): """Checks if the given array $L$ of pairs $(codeLenght_i,nbWeights_i)$ corresponds to a prefix free code by checking Kraft's inequality, i.e. $\sum_i nbWeights_i 2^{-codelenght_i} \leq 1$. """ return KraftSum(L) &lt;= 1 ; def KraftSum(L): """Computes the Kraft sum of the prefix free code described by an array $L$ of pairs $(codeLenght_i,nbWeights_i)$ i.e. $\sum_i nbWeights_i 2^{-codelenght_i}$. """ if len(L)==0: return 0 terms = map( lambda x: x[1] * math.pow(2,-x[0]), L) return sum(terms) class TestKraftSum(unittest.TestCase): def test_empty(self): """Empty input.""" self.assertEqual(KraftSum([]),0) def test_singleton(self): """Singleton with one single symbol.""" self.assertEqual(KraftSum([(0,1)]),1) def test_simpleCode(self): """Simple Code with code lenghts [1,2,2].""" self.assertEqual(KraftSum([(1,1),(2,2)]),1) def test_fourEqual(self): """Four equal weights""" self.assertEqual(KraftSum([(2,4)]),1) def test_HuffmanExample(self): """Example from Huffman's article""" self.assertEqual(KraftSum([(5,6),(4,3),(3,3),(2,1)]),1) def test_MoffatTurpinExample(self): """Example from Moffat and Turpin's article""" self.assertEqual(KraftSum([(5,4),(4,4),(3,3),(2,1)]),1) def NTimesEntropy(W): """Returns N times the entropy, rounded to the next integer, as computed by $\lceil \sum_{i=1}^N W[i]/\sum(W) \log (sum(W) / W[i]) \rceil$. """ if len(W)==0: return 0 assert min(W)&gt;0 sumWeights = sum(W) terms = map( lambda x: x * math.log(x,2), W ) return math.ceil(sumWeights * math.log(sumWeights,2) - sum(terms)) class TestNTimesEntropy(unittest.TestCase): def test_empty(self): """Empty input""" self.assertEqual(NTimesEntropy([]),0) def test_singleton(self): """Singleton""" self.assertEqual(NTimesEntropy([1]),0) def test_pair(self): """Pair""" self.assertEqual(NTimesEntropy([1,1]),2) def test_fourEqual(self): """Four equal weights""" self.assertEqual(NTimesEntropy([1,1,1,1]),8) def test_HuffmanExample(self): """Example from Huffman's article""" self.assertEqual(NTimesEntropy([1,3,4,4,4,4,6,6,10,10,10,18,20]),336) def test_MoffatTurpinExample(self): """Example from Moffat and Turpin's article""" self.assertEqual(NTimesEntropy([1,1,1,1,1,2,2,2,2,3,3,6]),84) def compressedTextLength(L,W): """Computes the lengths of a text which frequencies are given by an array $W$, when it is compressed by a prefix free code described by an array $L$ of pairs $(codeLenght_i,nbWeights_i)$. """ compressedTextLength = 0 Ls = sorted(L, reverse=True) Ws = sorted(W) for (l,n) in Ls: compressedTextLength += l*sum(Ws[0:n]) Ws = Ws[n:] return compressedTextLength class TestcompressedTextLength(unittest.TestCase): def test_empty(self): """Empty input""" self.assertEqual(compressedTextLength([],[]),0) def test_pair(self): """Pair of symbols, arbitrary text""" self.assertEqual(compressedTextLength([(1,2)],[1,1]),2) def test_fourEqual(self): """Four equal weights""" self.assertEqual(compressedTextLength([(2,4)],[1,1,1,1]),8) def test_HuffmanExample(self): """Example from Huffman's article (compares with value compared by hand)""" self.assertEqual(compressedTextLength([(5,6),(4,3),(3,3),(2,1)],[1,3,4,4,4,4,6,6,10,10,10,18,20]),342) def test_MoffatTurpinExample(self): """Example from Moffat and Turpin's article (compares with entropy value)""" self.assertEqual(compressedTextLength([(5,4),(4,4),(3,3),(2,1)],[1,1,1,1,1,2,2,2,2,3,3,6]),84) def main(): unittest.main() if __name__ == '__main__': doctest.testmod() main() </code></pre>

27821

GOOD_ANSWER

<p>I have a file with just 3500 lines like these:</p> <pre><code>filecontent= "13P397;Fotostuff;t;IBM;IBM lalala 123|IBM lalala 1234;28.000 things;;IBMlalala123|IBMlalala1234" </code></pre> <p>Then I want to grab every line from the <code>filecontent</code> that matches a certain string (with python 2.7):</p> <pre><code>this_item= "IBMlalala123" matchingitems = re.findall(".*?;.*?;.*?;.*?;.*?;.*?;.*?"+this_item,filecontent) </code></pre> <p>It needs 17 seconds for each <code>findall</code>. I need to search 4000 times in these 3500 lines. It takes forever. Any idea how to speed it up?</p>

32449

GOOD_ANSWER

<p>I have a file with just 3500 lines like these:</p> <pre><code>filecontent= "13P397;Fotostuff;t;IBM;IBM lalala 123|IBM lalala 1234;28.000 things;;IBMlalala123|IBMlalala1234" </code></pre> <p>Then I want to grab every line from the <code>filecontent</code> that matches a certain string (with python 2.7):</p> <pre><code>this_item= "IBMlalala123" matchingitems = re.findall(".*?;.*?;.*?;.*?;.*?;.*?;.*?"+this_item,filecontent) </code></pre> <p>It needs 17 seconds for each <code>findall</code>. I need to search 4000 times in these 3500 lines. It takes forever. Any idea how to speed it up?</p>

32449

BAD_ANSWER

<p>I have a file with just 3500 lines like these:</p> <pre><code>filecontent= "13P397;Fotostuff;t;IBM;IBM lalala 123|IBM lalala 1234;28.000 things;;IBMlalala123|IBMlalala1234" </code></pre> <p>Then I want to grab every line from the <code>filecontent</code> that matches a certain string (with python 2.7):</p> <pre><code>this_item= "IBMlalala123" matchingitems = re.findall(".*?;.*?;.*?;.*?;.*?;.*?;.*?"+this_item,filecontent) </code></pre> <p>It needs 17 seconds for each <code>findall</code>. I need to search 4000 times in these 3500 lines. It takes forever. Any idea how to speed it up?</p>

32449

GOOD_ANSWER

<p>I have a file with just 3500 lines like these:</p> <pre><code>filecontent= "13P397;Fotostuff;t;IBM;IBM lalala 123|IBM lalala 1234;28.000 things;;IBMlalala123|IBMlalala1234" </code></pre> <p>Then I want to grab every line from the <code>filecontent</code> that matches a certain string (with python 2.7):</p> <pre><code>this_item= "IBMlalala123" matchingitems = re.findall(".*?;.*?;.*?;.*?;.*?;.*?;.*?"+this_item,filecontent) </code></pre> <p>It needs 17 seconds for each <code>findall</code>. I need to search 4000 times in these 3500 lines. It takes forever. Any idea how to speed it up?</p>

32449

GOOD_ANSWER

<p>This is a similar question to <a href="https://stackoverflow.com/questions/492716/reversing-a-regular-expression-in-python">this</a>, but I am looking for the set of <strong>all possible values</strong> that will match a regular expression pattern.</p> <p>To avoid an infinite set of possible values, I am willing to restrict the regular expression pattern to a subset of the regular expression language.</p> <p>Here's the approach I took (Python code):</p> <pre><code>def generate_possible_strings(pattern): ''' input: 'K0[2468]' output: ['K02', 'K04', 'K06', 'K08'] generates a list of possible strings that would match pattern ie, any value X such that re.search(pattern, X) is a match ''' query = re.compile(pattern, re.IGNORECASE) fill_in = string.uppercase + string.digits + '_' # Build a re for a language subset that is supported by reverse_search bracket = r'\[[^\]]*\]' #finds [A-Z], [0-5], [02468] symbol = r'\\.' #finds \w, \d expression = '|'.join((bracket,symbol)) #search query tokens = re.split(expression, pattern) for c in product(fill_in, repeat=len(tokens)-1): candidate = ''.join(roundrobin(tokens, c)) #roundrobin recipe from itertools documentation if query.match(candidate): yield candidate </code></pre> <p>Supported subset of regular expressions language</p> <ul> <li>Supports <code>[]</code> set of characters (<code>[A-Z]</code>, <code>[0-5]</code>, etc)</li> <li>Supports escaped special characters (<code>\w</code>, <code>\d</code>, <code>\D</code>, etc)</li> </ul> <p>Basically what this does is locate all parts of a regular expression that could match a single character (<code>[A-Z]</code> or <code>[0-5]</code> or <code>[02468]</code> or <code>\w</code> or <code>\d</code>), then for all of the valid replacement characters <code>A-Z0-9_</code> test to see if the replacement matches the regular expression.</p> <p>This algorithm is slow for regular expressions with many fields or if <code>fill_in</code> is not restricted to just <code>A-Z0-9_</code>, but at least it guarantees finding every possible string that will match a regular expression in finite time (if the solution set is finite).</p> <p>Is there a faster approach to solving this problem, or an approach that supports a larger percentage of the standard regular expression language?</p>

43981

GOOD_ANSWER

<p>I am trying create an algorithm for finding the zero crossing (check that the signs of all the entries around the entry of interest are not the same) in a two dimensional matrix, as part of implementing the Laplacian of Gaussian edge detection filter for a class, but I feel like I'm fighting against Numpy instead of working with it.</p> <pre><code>import numpy as np range_inc = lambda start, end: range(start, end+1) # Find the zero crossing in the l_o_g image # Done in the most naive way possible def z_c_test(l_o_g_image): print(l_o_g_image) z_c_image = np.zeros(l_o_g_image.shape) for i in range(1, l_o_g_image.shape[0] - 1): for j in range(1, l_o_g_image.shape[1] - 1): neg_count = 0 pos_count = 0 for a in range_inc(-1, 1): for b in range_inc(-1, 1): if a != 0 and b != 0: print("a ", a, " b ", b) if l_o_g_image[i + a, j + b] &lt; 0: neg_count += 1 print("neg") elif l_o_g_image[i + a, j + b] &gt; 0: pos_count += 1 print("pos") else: print("zero") # If all the signs around the pixel are the same # and they're not all zero # then it's not a zero crossing and an edge. # Otherwise, copy it to the edge map. z_c = ((neg_count &gt; 0) and (pos_count &gt; 0)) if z_c: print("True for", i, ",", j) print("pos ", pos_count, " neg ", neg_count) z_c_image[i, j] = 1 return z_c_image </code></pre> <p>Here is the test cases it should pass:</p> <pre><code>test1 = np.array([[0,0,1], [0,0,0], [0,0,0]]) test2 = np.array([[0,0,1], [0,0,0], [0,0,-1]]) test3 = np.array([[0,0,0], [0,0,-1], [0,0,0]]) test4 = np.array([[0,0,0], [0,0,0], [0,0,0]]) true_result = np.array([[0,0,0], [0,1,0], [0,0,0]]) false_result = np.array([[0,0,0], [0,0,0], [0,0,0]]) real_result1 = z_c_test(test1) real_result2 = z_c_test(test2) real_result3 = z_c_test(test3) real_result4 = z_c_test(test4) assert(np.array_equal(real_result1, false_result)) assert(np.array_equal(real_result2, true_result)) assert(np.array_equal(real_result3, false_result)) assert(np.array_equal(real_result4, false_result)) </code></pre> <p>How do I vectorize checking a property in a matrix range? Is there a quick way of accessing all of the entries adjacent to an entry in a matrix?</p>

45458

GOOD_ANSWER

<p>I am trying create an algorithm for finding the zero crossing (check that the signs of all the entries around the entry of interest are not the same) in a two dimensional matrix, as part of implementing the Laplacian of Gaussian edge detection filter for a class, but I feel like I'm fighting against Numpy instead of working with it.</p> <pre><code>import numpy as np range_inc = lambda start, end: range(start, end+1) # Find the zero crossing in the l_o_g image # Done in the most naive way possible def z_c_test(l_o_g_image): print(l_o_g_image) z_c_image = np.zeros(l_o_g_image.shape) for i in range(1, l_o_g_image.shape[0] - 1): for j in range(1, l_o_g_image.shape[1] - 1): neg_count = 0 pos_count = 0 for a in range_inc(-1, 1): for b in range_inc(-1, 1): if a != 0 and b != 0: print("a ", a, " b ", b) if l_o_g_image[i + a, j + b] &lt; 0: neg_count += 1 print("neg") elif l_o_g_image[i + a, j + b] &gt; 0: pos_count += 1 print("pos") else: print("zero") # If all the signs around the pixel are the same # and they're not all zero # then it's not a zero crossing and an edge. # Otherwise, copy it to the edge map. z_c = ((neg_count &gt; 0) and (pos_count &gt; 0)) if z_c: print("True for", i, ",", j) print("pos ", pos_count, " neg ", neg_count) z_c_image[i, j] = 1 return z_c_image </code></pre> <p>Here is the test cases it should pass:</p> <pre><code>test1 = np.array([[0,0,1], [0,0,0], [0,0,0]]) test2 = np.array([[0,0,1], [0,0,0], [0,0,-1]]) test3 = np.array([[0,0,0], [0,0,-1], [0,0,0]]) test4 = np.array([[0,0,0], [0,0,0], [0,0,0]]) true_result = np.array([[0,0,0], [0,1,0], [0,0,0]]) false_result = np.array([[0,0,0], [0,0,0], [0,0,0]]) real_result1 = z_c_test(test1) real_result2 = z_c_test(test2) real_result3 = z_c_test(test3) real_result4 = z_c_test(test4) assert(np.array_equal(real_result1, false_result)) assert(np.array_equal(real_result2, true_result)) assert(np.array_equal(real_result3, false_result)) assert(np.array_equal(real_result4, false_result)) </code></pre> <p>How do I vectorize checking a property in a matrix range? Is there a quick way of accessing all of the entries adjacent to an entry in a matrix?</p>

45458

GOOD_ANSWER

<p>I wrote a program that reads a pcap file and parses the HTTP traffic in the pcap to generate a dictionary that contains HTTP headers for each request and response in this pcap.</p> <p>My code does the following:</p> <ol> <li>Uses tcpflow to reassemble the tcp segments</li> <li>Read the files generated by tcpflow and check if it related to HTTP</li> <li>If the file contains HTTP traffic, my code will read the file and generate a corresponding dictionary that contains the HTTP header fields.</li> </ol> <p>I test my code with multiple test cases, but honestly I don't have a good experience in Python, so could anyone check it for me please?</p> <pre><code>import os from os import listdir from os.path import isfile, join from StringIO import StringIO import mimetools def getFields(headers): fields={} i=1 for header in headers: if len(header)==0: continue # if this line is complement for the previous line if header.find(" ")==0 or header.find("\t")==0: continue if len(header.split(":"))&gt;=2: key = header.split(":")[0].strip() # if the key has multiple values such as cookie if fields.has_key(key): fields[key]=fields[key]+" "+header[header.find(":")+1:].strip() else: fields[key]=header[header.find(":")+1:].strip() while headers[i].find(" ")==0 or headers[i].find("\t")==0 : fields[key]=fields[key]+" "+headers[i].strip() i=i+1 # end of the while loop # end of the else else: # else for [if len(header.split(":"))&gt;=2: ] print "ERROR: RFC VIOLATION" # end of the for loop return fields def main(): # you have to write it in the terminal "cd /home/user/Desktop/empty-dir" os.system("tcpflow -r /home/user/Desktop/12.pcap -v") for f in listdir("/home/user/Desktop/empty-dir"): if f.find("80")==19 or f.find("80")==41: with open("/home/user/Desktop/empty-dir"+f) as fh: fields={} content=fh.read() #to test you could replace it with content="any custom http header" if content.find("\r\n\r\n")==-1: print "ERROR: RFC VIOLATION" return headerSection=content.split("\r\n\r\n")[0] headerLines=headerSection.split("\r\n") firstLine=headerLines[0] firstLineFields=firstLine.split(" ") if len(headerLines)&gt;1: fields=getFields(headerLines[1:]) if len(firstLineFields)&gt;=3: if firstLine.find("HTTP")==0: fields["Version"]=firstLineFields[0] fields["Status-code"]=firstLineFields[1] fields["Status-desc"]=" ".join(firstLineFields[2:]) else: fields["Method"]=firstLineFields[0] fields["URL"]=firstLineFields[1] fields["Version"]=firstLineFields[2] else: print "ERROR: RFC VIOLATION" continue print fields print "__________________" return 0 if __name__ == '__main__': main() </code></pre>

57715

GOOD_ANSWER

<p>I wrote a program that reads a pcap file and parses the HTTP traffic in the pcap to generate a dictionary that contains HTTP headers for each request and response in this pcap.</p> <p>My code does the following:</p> <ol> <li>Uses tcpflow to reassemble the tcp segments</li> <li>Read the files generated by tcpflow and check if it related to HTTP</li> <li>If the file contains HTTP traffic, my code will read the file and generate a corresponding dictionary that contains the HTTP header fields.</li> </ol> <p>I test my code with multiple test cases, but honestly I don't have a good experience in Python, so could anyone check it for me please?</p> <pre><code>import os from os import listdir from os.path import isfile, join from StringIO import StringIO import mimetools def getFields(headers): fields={} i=1 for header in headers: if len(header)==0: continue # if this line is complement for the previous line if header.find(" ")==0 or header.find("\t")==0: continue if len(header.split(":"))&gt;=2: key = header.split(":")[0].strip() # if the key has multiple values such as cookie if fields.has_key(key): fields[key]=fields[key]+" "+header[header.find(":")+1:].strip() else: fields[key]=header[header.find(":")+1:].strip() while headers[i].find(" ")==0 or headers[i].find("\t")==0 : fields[key]=fields[key]+" "+headers[i].strip() i=i+1 # end of the while loop # end of the else else: # else for [if len(header.split(":"))&gt;=2: ] print "ERROR: RFC VIOLATION" # end of the for loop return fields def main(): # you have to write it in the terminal "cd /home/user/Desktop/empty-dir" os.system("tcpflow -r /home/user/Desktop/12.pcap -v") for f in listdir("/home/user/Desktop/empty-dir"): if f.find("80")==19 or f.find("80")==41: with open("/home/user/Desktop/empty-dir"+f) as fh: fields={} content=fh.read() #to test you could replace it with content="any custom http header" if content.find("\r\n\r\n")==-1: print "ERROR: RFC VIOLATION" return headerSection=content.split("\r\n\r\n")[0] headerLines=headerSection.split("\r\n") firstLine=headerLines[0] firstLineFields=firstLine.split(" ") if len(headerLines)&gt;1: fields=getFields(headerLines[1:]) if len(firstLineFields)&gt;=3: if firstLine.find("HTTP")==0: fields["Version"]=firstLineFields[0] fields["Status-code"]=firstLineFields[1] fields["Status-desc"]=" ".join(firstLineFields[2:]) else: fields["Method"]=firstLineFields[0] fields["URL"]=firstLineFields[1] fields["Version"]=firstLineFields[2] else: print "ERROR: RFC VIOLATION" continue print fields print "__________________" return 0 if __name__ == '__main__': main() </code></pre>

57715

GOOD_ANSWER

<p>The profile tells me it took ~15s to run, but without telling me more.</p> <blockquote> <pre class="lang-none prettyprint-override"><code>Tue Aug 19 20:55:38 2014 Profile.prof 3 function calls in 15.623 seconds Ordered by: internal time ncalls tottime percall cumtime percall filename:lineno(function) 1 15.623 15.623 15.623 15.623 {singleLoan.genLoan} 1 0.000 0.000 15.623 15.623 &lt;string&gt;:1(&lt;module&gt;) 1 0.000 0.000 0.000 0.000 {method 'disable' of '_lsprof.Profiler' objects} </code></pre> </blockquote> <pre class="lang-python prettyprint-override"><code>import numpy as np cimport numpy as np from libc.stdlib cimport malloc, free from libc.stdlib cimport rand, srand, RAND_MAX import cython cimport cython import StringIO cdef extern from "math.h": int floor(double x) double pow(double x, double y) double exp(double x) cdef double[:] zeros = np.zeros(360) cdef double[:] stepCoupons = np.array([2.0,60,3.0,12.0,4.0,12.0,5.0]) cdef double[:,:] zeros2 = np.empty(shape=(999,2)) paraC2P = StringIO.StringIO('''1 10 0 0 (Intercept) 0 -4.981792 1 10 0 0 lv 50 0.55139 1 10 0 0 lv 51 0.53667 1 10 0 0 lv 52 0.52194 1 10 0 0 lv 53 0.50722 1 10 0 0 lv 54 0.49249 1 10 0 0 lv 55 0.47776 1 10 0 0 lv 56 0.46301 1 10 0 0 lv 57 0.44825 1 10 0 0 lv 58 0.43347 1 10 0 0 lv 59 0.41867 1 10 0 0 lv 60 0.40384 1 10 0 0 lv 61 0.38897 1 10 0 0 lv 62 0.37405 1 10 0 0 lv 63 0.35908 1 10 0 0 lv 64 0.34406 1 10 0 0 lv 65 0.32897 1 10 0 0 lv 66 0.31381 1 10 0 0 lv 67 0.29856 1 10 0 0 lv 68 0.28322 1 10 0 0 lv 69 0.26778 1 10 0 0 lv 70 0.25224 1 10 0 0 lv 71 0.23657 1 10 0 0 lv 72 0.22078 1 10 0 0 lv 73 0.20486 1 10 0 0 lv 74 0.18879 1 10 0 0 lv 75 0.17258 1 10 0 0 lv 76 0.1562 1 10 0 0 lv 77 0.13966 1 10 0 0 lv 78 0.12294 1 10 0 0 lv 79 0.10604 1 10 0 0 lv 80 0.08896 1 10 0 0 lv 81 0.07167 1 10 0 0 lv 82 0.05419 1 10 0 0 lv 83 0.0365 1 10 0 0 lv 84 0.0186 1 10 0 0 lv 85 0.00048 1 10 0 0 lv 86 -0.01785 1 10 0 0 lv 87 -0.03641 1 10 0 0 lv 88 -0.0552 1 10 0 0 lv 89 -0.07422 1 10 0 0 lv 90 -0.09347 1 10 0 0 lv 91 -0.11295 1 10 0 0 lv 92 -0.13267 1 10 0 0 lv 93 -0.15263 1 10 0 0 lv 94 -0.17282 1 10 0 0 lv 95 -0.19325 1 10 0 0 lv 96 -0.21392 1 10 0 0 lv 97 -0.23482 1 10 0 0 lv 98 -0.25596 1 10 0 0 lv 99 -0.27734 1 10 0 0 lv 100 -0.29895 1 10 0 0 lv 101 -0.32078 1 10 0 0 lv 102 -0.34285 1 10 0 0 lv 103 -0.36513 1 10 0 0 lv 104 -0.38764 1 10 0 0 lv 105 -0.41037 1 10 0 0 lv 106 -0.43331 1 10 0 0 lv 107 -0.45646 1 10 0 0 lv 108 -0.47982 1 10 0 0 lv 109 -0.50338 1 10 0 0 lv 110 -0.52713 1 10 0 0 lv 111 -0.55107 1 10 0 0 lv 112 -0.5752 1 10 0 0 lv 113 -0.59952 1 10 0 0 lv 114 -0.624 1 10 0 0 lv 115 -0.64866 1 10 0 0 lv 116 -0.67348 1 10 0 0 lv 117 -0.69846 1 10 0 0 lv 118 -0.72359 1 10 0 0 lv 119 -0.74887 1 10 0 0 lv 120 -0.77429 1 10 0 0 lv 121 -0.79985 1 10 0 0 lv 122 -0.82554 1 10 0 0 lv 123 -0.85135 1 10 0 0 lv 124 -0.87728 1 10 0 0 lv 125 -0.90332 1 10 0 0 lv 126 -0.92947 1 10 0 0 lv 127 -0.95572 1 10 0 0 lv 128 -0.98206 1 10 0 0 lv 129 -1.0085 1 10 0 0 lv 130 -1.03502 1 10 0 0 lv 131 -1.06162 1 10 0 0 lv 132 -1.0883 1 10 0 0 lv 133 -1.11504 1 10 0 0 lv 134 -1.14185 1 10 0 0 lv 135 -1.16872 1 10 0 0 lv 136 -1.19565 1 10 0 0 lv 137 -1.22263 1 10 0 0 lv 138 -1.24965 1 10 0 0 lv 139 -1.27672 1 10 0 0 lv 140 -1.30382 1 10 0 0 lv 141 -1.33097 1 10 0 0 lv 142 -1.35814 1 10 0 0 lv 143 -1.38534 1 10 0 0 lv 144 -1.41257 1 10 0 0 lv 145 -1.43982 1 10 0 0 lv 146 -1.46709 1 10 0 0 lv 147 -1.49437 1 10 0 0 lv 148 -1.52167 1 10 0 0 lv 149 -1.54898 1 10 0 0 lv 150 -1.57629 1 10 0 0 dollarSaving -50 -1.10708 1 10 0 0 dollarSaving -48 -1.08948 1 10 0 0 dollarSaving -46 -1.07188 1 10 0 0 dollarSaving -44 -1.05429 1 10 0 0 dollarSaving -42 -1.03669 1 10 0 0 dollarSaving -40 -1.0191 1 10 0 0 dollarSaving -38 -1.0015 1 10 0 0 dollarSaving -36 -0.98391 1 10 0 0 dollarSaving -34 -0.96632 1 10 0 0 dollarSaving -32 -0.94873 1 10 0 0 dollarSaving -30 -0.93115 1 10 0 0 dollarSaving -28 -0.91357 1 10 0 0 dollarSaving -26 -0.896 1 10 0 0 dollarSaving -24 -0.87843 1 10 0 0 dollarSaving -22 -0.86087 1 10 0 0 dollarSaving -20 -0.84331 1 10 0 0 dollarSaving -18 -0.82577 1 10 0 0 dollarSaving -16 -0.80823 1 10 0 0 dollarSaving -14 -0.79071 1 10 0 0 dollarSaving -12 -0.7732 1 10 0 0 dollarSaving -10 -0.7557 1 10 0 0 dollarSaving -8 -0.73821 1 10 0 0 dollarSaving -6 -0.72074 1 10 0 0 dollarSaving -4 -0.70329 1 10 0 0 dollarSaving -2 -0.68586 1 10 0 0 dollarSaving 0 -0.66844 1 10 0 0 dollarSaving 2 -0.65105 1 10 0 0 dollarSaving 4 -0.63368 1 10 0 0 dollarSaving 6 -0.61634 1 10 0 0 dollarSaving 8 -0.59901 1 10 0 0 dollarSaving 10 -0.58172 1 10 0 0 dollarSaving 12 -0.56446 1 10 0 0 dollarSaving 14 -0.54722 1 10 0 0 dollarSaving 16 -0.53002 1 10 0 0 dollarSaving 18 -0.51285 1 10 0 0 dollarSaving 20 -0.49572 1 10 0 0 dollarSaving 22 -0.47862 1 10 0 0 dollarSaving 24 -0.46157 1 10 0 0 dollarSaving 26 -0.44455 1 10 0 0 dollarSaving 28 -0.42757 1 10 0 0 dollarSaving 30 -0.41064 1 10 0 0 dollarSaving 32 -0.39376 1 10 0 0 dollarSaving 34 -0.37692 1 10 0 0 dollarSaving 36 -0.36014 1 10 0 0 dollarSaving 38 -0.3434 1 10 0 0 dollarSaving 40 -0.32672 1 10 0 0 dollarSaving 42 -0.31009 1 10 0 0 dollarSaving 44 -0.29352 1 10 0 0 dollarSaving 46 -0.27701 1 10 0 0 dollarSaving 48 -0.26056 1 10 0 0 dollarSaving 50 -0.24417 1 10 0 0 dollarSaving 52 -0.22785 1 10 0 0 dollarSaving 54 -0.21159 1 10 0 0 dollarSaving 56 -0.1954 1 10 0 0 dollarSaving 58 -0.17928 1 10 0 0 dollarSaving 60 -0.16323 1 10 0 0 dollarSaving 62 -0.14725 1 10 0 0 dollarSaving 64 -0.13135 1 10 0 0 dollarSaving 66 -0.11553 1 10 0 0 dollarSaving 68 -0.09978 1 10 0 0 dollarSaving 70 -0.08411 1 10 0 0 dollarSaving 72 -0.06853 1 10 0 0 dollarSaving 74 -0.05303 1 10 0 0 dollarSaving 76 -0.03761 1 10 0 0 dollarSaving 78 -0.02229 1 10 0 0 dollarSaving 80 -0.00704 1 10 0 0 dollarSaving 82 0.00811 1 10 0 0 dollarSaving 84 0.02317 1 10 0 0 dollarSaving 86 0.03813 1 10 0 0 dollarSaving 88 0.05301 1 10 0 0 dollarSaving 90 0.06778 1 10 0 0 dollarSaving 92 0.08246 1 10 0 0 dollarSaving 94 0.09704 1 10 0 0 dollarSaving 96 0.11152 1 10 0 0 dollarSaving 98 0.1259 1 10 0 0 dollarSaving 100 0.14018 1 10 0 0 dollarSaving 102 0.15435 1 10 0 0 dollarSaving 104 0.16841 1 10 0 0 dollarSaving 106 0.18237 1 10 0 0 dollarSaving 108 0.19623 1 10 0 0 dollarSaving 110 0.20997 1 10 0 0 dollarSaving 112 0.2236 1 10 0 0 dollarSaving 114 0.23712 1 10 0 0 dollarSaving 116 0.25053 1 10 0 0 dollarSaving 118 0.26383 1 10 0 0 dollarSaving 120 0.27701 1 10 0 0 dollarSaving 122 0.29007 1 10 0 0 dollarSaving 124 0.30302 1 10 0 0 dollarSaving 126 0.31585 1 10 0 0 dollarSaving 128 0.32857 1 10 0 0 dollarSaving 130 0.34116 1 10 0 0 dollarSaving 132 0.35364 1 10 0 0 dollarSaving 134 0.36599 1 10 0 0 dollarSaving 136 0.37822 1 10 0 0 dollarSaving 138 0.39034 1 10 0 0 dollarSaving 140 0.40233 1 10 0 0 dollarSaving 142 0.4142 1 10 0 0 dollarSaving 144 0.42594 1 10 0 0 dollarSaving 146 0.43756 1 10 0 0 dollarSaving 148 0.44906 1 10 0 0 dollarSaving 150 0.46043 1 10 0 0 dollarSaving 152 0.47168 1 10 0 0 dollarSaving 154 0.4828 1 10 0 0 dollarSaving 156 0.49379 1 10 0 0 dollarSaving 158 0.50466 1 10 0 0 dollarSaving 160 0.51541 1 10 0 0 dollarSaving 162 0.52602 1 10 0 0 dollarSaving 164 0.53651 1 10 0 0 dollarSaving 166 0.54687 1 10 0 0 dollarSaving 168 0.55711 1 10 0 0 dollarSaving 170 0.56722 1 10 0 0 dollarSaving 172 0.5772 1 10 0 0 dollarSaving 174 0.58705 1 10 0 0 dollarSaving 176 0.59678 1 10 0 0 dollarSaving 178 0.60637 1 10 0 0 dollarSaving 180 0.61584 1 10 0 0 dollarSaving 182 0.62519 1 10 0 0 dollarSaving 184 0.6344 1 10 0 0 dollarSaving 186 0.64349 1 10 0 0 dollarSaving 188 0.65245 1 10 0 0 dollarSaving 190 0.66129 1 10 0 0 dollarSaving 192 0.67 1 10 0 0 dollarSaving 194 0.67858 1 10 0 0 dollarSaving 196 0.68704 1 10 0 0 dollarSaving 198 0.69537 1 10 0 0 dollarSaving 200 0.70358 1 10 0 0 dollarSaving 202 0.71167 1 10 0 0 dollarSaving 204 0.71963 1 10 0 0 dollarSaving 206 0.72746 1 10 0 0 dollarSaving 208 0.73517 1 10 0 0 dollarSaving 210 0.74276 1 10 0 0 dollarSaving 212 0.75023 1 10 0 0 dollarSaving 214 0.75758 1 10 0 0 dollarSaving 216 0.7648 1 10 0 0 dollarSaving 218 0.77191 1 10 0 0 dollarSaving 220 0.77889 1 10 0 0 dollarSaving 222 0.78576 1 10 0 0 dollarSaving 224 0.79251 1 10 0 0 dollarSaving 226 0.79914 1 10 0 0 dollarSaving 228 0.80565 1 10 0 0 dollarSaving 230 0.81205 1 10 0 0 dollarSaving 232 0.81833 1 10 0 0 dollarSaving 234 0.8245 1 10 0 0 dollarSaving 236 0.83055 1 10 0 0 dollarSaving 238 0.8365 1 10 0 0 dollarSaving 240 0.84233 1 10 0 0 dollarSaving 242 0.84805 1 10 0 0 dollarSaving 244 0.85366 1 10 0 0 dollarSaving 246 0.85916 1 10 0 0 dollarSaving 248 0.86455 1 10 0 0 dollarSaving 250 0.86984 1 10 0 0 dollarSaving 252 0.87502 1 10 0 0 dollarSaving 254 0.8801 1 10 0 0 dollarSaving 256 0.88507 1 10 0 0 dollarSaving 258 0.88994 1 10 0 0 dollarSaving 260 0.89471 1 10 0 0 dollarSaving 262 0.89938 1 10 0 0 dollarSaving 264 0.90395 1 10 0 0 dollarSaving 266 0.90843 1 10 0 0 dollarSaving 268 0.91281 1 10 0 0 dollarSaving 270 0.91709 1 10 0 0 dollarSaving 272 0.92128 1 10 0 0 dollarSaving 274 0.92539 1 10 0 0 dollarSaving 276 0.9294 1 10 0 0 dollarSaving 278 0.93332 1 10 0 0 dollarSaving 280 0.93715 1 10 0 0 dollarSaving 282 0.9409 1 10 0 0 dollarSaving 284 0.94457 1 10 0 0 dollarSaving 286 0.94815 1 10 0 0 dollarSaving 288 0.95165 1 10 0 0 dollarSaving 290 0.95507 1 10 0 0 dollarSaving 292 0.95842 1 10 0 0 dollarSaving 294 0.96169 1 10 0 0 dollarSaving 296 0.96488 1 10 0 0 dollarSaving 298 0.96801 1 10 0 0 dollarSaving 300 0.97106 1 10 0 0 dollarSaving 302 0.97404 1 10 0 0 dollarSaving 304 0.97696 1 10 0 0 dollarSaving 306 0.97981 1 10 0 0 dollarSaving 308 0.9826 1 10 0 0 dollarSaving 310 0.98532 1 10 0 0 dollarSaving 312 0.98799 1 10 0 0 dollarSaving 314 0.9906 1 10 0 0 dollarSaving 316 0.99315 1 10 0 0 dollarSaving 318 0.99565 1 10 0 0 dollarSaving 320 0.99809 1 10 0 0 dollarSaving 322 1.00049 1 10 0 0 dollarSaving 324 1.00283 1 10 0 0 dollarSaving 326 1.00513 1 10 0 0 dollarSaving 328 1.00738 1 10 0 0 dollarSaving 330 1.00959 1 10 0 0 dollarSaving 332 1.01176 1 10 0 0 dollarSaving 334 1.01389 1 10 0 0 dollarSaving 336 1.01598 1 10 0 0 dollarSaving 338 1.01803 1 10 0 0 dollarSaving 340 1.02005 1 10 0 0 dollarSaving 342 1.02204 1 10 0 0 dollarSaving 344 1.02399 1 10 0 0 dollarSaving 346 1.02592 1 10 0 0 dollarSaving 348 1.02782 1 10 0 0 dollarSaving 350 1.02969 1 10 0 0 dollarSaving 352 1.03154 1 10 0 0 dollarSaving 354 1.03337 1 10 0 0 dollarSaving 356 1.03518 1 10 0 0 dollarSaving 358 1.03696 1 10 0 0 dollarSaving 360 1.03873 1 10 0 0 dollarSaving 362 1.04049 1 10 0 0 dollarSaving 364 1.04222 1 10 0 0 dollarSaving 366 1.04395 1 10 0 0 dollarSaving 368 1.04566 1 10 0 0 dollarSaving 370 1.04736 1 10 0 0 dollarSaving 372 1.04906 1 10 0 0 dollarSaving 374 1.05074 1 10 0 0 dollarSaving 376 1.05242 1 10 0 0 dollarSaving 378 1.05409 1 10 0 0 dollarSaving 380 1.05576 1 10 0 0 dollarSaving 382 1.05742 1 10 0 0 dollarSaving 384 1.05908 1 10 0 0 dollarSaving 386 1.06073 1 10 0 0 dollarSaving 388 1.06238 1 10 0 0 dollarSaving 390 1.06403 1 10 0 0 dollarSaving 392 1.06568 1 10 0 0 dollarSaving 394 1.06733 1 10 0 0 dollarSaving 396 1.06898 1 10 0 0 dollarSaving 398 1.07063 1 10 0 0 dollarSaving 400 1.07228 1 10 0 0 fo 500 0.58651 1 10 0 0 fo 501 0.58111 1 10 0 0 fo 502 0.57571 1 10 0 0 fo 503 0.57031 1 10 0 0 fo 504 0.56492 1 10 0 0 fo 505 0.55952 1 10 0 0 fo 506 0.55412 1 10 0 0 fo 507 0.54872 1 10 0 0 fo 508 0.54332 1 10 0 0 fo 509 0.53793 1 10 0 0 fo 510 0.53253 1 10 0 0 fo 511 0.52713 1 10 0 0 fo 512 0.52173 1 10 0 0 fo 513 0.51633 1 10 0 0 fo 514 0.51093 1 10 0 0 fo 515 0.50554 1 10 0 0 fo 516 0.50014 1 10 0 0 fo 517 0.49474 1 10 0 0 fo 518 0.48934 1 10 0 0 fo 519 0.48394 1 10 0 0 fo 520 0.47855 1 10 0 0 fo 521 0.47315 1 10 0 0 fo 522 0.46775 1 10 0 0 fo 523 0.46235 1 10 0 0 fo 524 0.45695 1 10 0 0 fo 525 0.45156 1 10 0 0 fo 526 0.44616 1 10 0 0 fo 527 0.44076 1 10 0 0 fo 528 0.43536 1 10 0 0 fo 529 0.42996 1 10 0 0 fo 530 0.42457 1 10 0 0 fo 531 0.41917 1 10 0 0 fo 532 0.41377 1 10 0 0 fo 533 0.40837 1 10 0 0 fo 534 0.40297 1 10 0 0 fo 535 0.39758 1 10 0 0 fo 536 0.39218 1 10 0 0 fo 537 0.38678 1 10 0 0 fo 538 0.38138 1 10 0 0 fo 539 0.37598 1 10 0 0 fo 540 0.37059 1 10 0 0 fo 541 0.36519 1 10 0 0 fo 542 0.35979 1 10 0 0 fo 543 0.35439 1 10 0 0 fo 544 0.34899 1 10 0 0 fo 545 0.34359 1 10 0 0 fo 546 0.3382 1 10 0 0 fo 547 0.3328 1 10 0 0 fo 548 0.3274 1 10 0 0 fo 549 0.322 1 10 0 0 fo 550 0.3166 1 10 0 0 fo 551 0.31121 1 10 0 0 fo 552 0.30581 1 10 0 0 fo 553 0.30041 1 10 0 0 fo 554 0.29501 1 10 0 0 fo 555 0.28961 1 10 0 0 fo 556 0.28422 1 10 0 0 fo 557 0.27882 1 10 0 0 fo 558 0.27342 1 10 0 0 fo 559 0.26802 1 10 0 0 fo 560 0.26262 1 10 0 0 fo 561 0.25723 1 10 0 0 fo 562 0.25183 1 10 0 0 fo 563 0.24643 1 10 0 0 fo 564 0.24103 1 10 0 0 fo 565 0.23563 1 10 0 0 fo 566 0.23024 1 10 0 0 fo 567 0.22484 1 10 0 0 fo 568 0.21944 1 10 0 0 fo 569 0.21404 1 10 0 0 fo 570 0.20864 1 10 0 0 fo 571 0.20325 1 10 0 0 fo 572 0.19785 1 10 0 0 fo 573 0.19245 1 10 0 0 fo 574 0.18705 1 10 0 0 fo 575 0.18165 1 10 0 0 fo 576 0.17625 1 10 0 0 fo 577 0.17086 1 10 0 0 fo 578 0.16546 1 10 0 0 fo 579 0.16006 1 10 0 0 fo 580 0.15466 1 10 0 0 fo 581 0.14926 1 10 0 0 fo 582 0.14387 1 10 0 0 fo 583 0.13847 1 10 0 0 fo 584 0.13307 1 10 0 0 fo 585 0.12767 1 10 0 0 fo 586 0.12227 1 10 0 0 fo 587 0.11688 1 10 0 0 fo 588 0.11148 1 10 0 0 fo 589 0.10608 1 10 0 0 fo 590 0.10068 1 10 0 0 fo 591 0.09528 1 10 0 0 fo 592 0.08989 1 10 0 0 fo 593 0.08449 1 10 0 0 fo 594 0.07909 1 10 0 0 fo 595 0.07369 1 10 0 0 fo 596 0.06829 1 10 0 0 fo 597 0.0629 1 10 0 0 fo 598 0.0575 1 10 0 0 fo 599 0.0521 1 10 0 0 fo 600 0.0467 1 10 0 0 fo 601 0.0413 1 10 0 0 fo 602 0.03591 1 10 0 0 fo 603 0.03051 1 10 0 0 fo 604 0.02511 1 10 0 0 fo 605 0.01972 1 10 0 0 fo 606 0.01433 1 10 0 0 fo 607 0.00895 1 10 0 0 fo 608 0.00357 1 10 0 0 fo 609 -0.0018 1 10 0 0 fo 610 -0.00716 1 10 0 0 fo 611 -0.01251 1 10 0 0 fo 612 -0.01784 1 10 0 0 fo 613 -0.02316 1 10 0 0 fo 614 -0.02846 1 10 0 0 fo 615 -0.03374 1 10 0 0 fo 616 -0.03899 1 10 0 0 fo 617 -0.04422 1 10 0 0 fo 618 -0.04942 1 10 0 0 fo 619 -0.05459 1 10 0 0 fo 620 -0.05972 1 10 0 0 fo 621 -0.06482 1 10 0 0 fo 622 -0.06988 1 10 0 0 fo 623 -0.07489 1 10 0 0 fo 624 -0.07986 1 10 0 0 fo 625 -0.08478 1 10 0 0 fo 626 -0.08964 1 10 0 0 fo 627 -0.09445 1 10 0 0 fo 628 -0.09921 1 10 0 0 fo 629 -0.1039 1 10 0 0 fo 630 -0.10853 1 10 0 0 fo 631 -0.11309 1 10 0 0 fo 632 -0.11758 1 10 0 0 fo 633 -0.122 1 10 0 0 fo 634 -0.12634 1 10 0 0 fo 635 -0.1306 1 10 0 0 fo 636 -0.13478 1 10 0 0 fo 637 -0.13888 1 10 0 0 fo 638 -0.14288 1 10 0 0 fo 639 -0.1468 1 10 0 0 fo 640 -0.15063 1 10 0 0 fo 641 -0.15436 1 10 0 0 fo 642 -0.15799 1 10 0 0 fo 643 -0.16152 1 10 0 0 fo 644 -0.16494 1 10 0 0 fo 645 -0.16826 1 10 0 0 fo 646 -0.17147 1 10 0 0 fo 647 -0.17457 1 10 0 0 fo 648 -0.17756 1 10 0 0 fo 649 -0.18043 1 10 0 0 fo 650 -0.18319 1 10 0 0 fo 651 -0.18582 1 10 0 0 fo 652 -0.18834 1 10 0 0 fo 653 -0.19073 1 10 0 0 fo 654 -0.19299 1 10 0 0 fo 655 -0.19513 1 10 0 0 fo 656 -0.19714 1 10 0 0 fo 657 -0.19901 1 10 0 0 fo 658 -0.20076 1 10 0 0 fo 659 -0.20237 1 10 0 0 fo 660 -0.20385 1 10 0 0 fo 661 -0.20519 1 10 0 0 fo 662 -0.20639 1 10 0 0 fo 663 -0.20746 1 10 0 0 fo 664 -0.20838 1 10 0 0 fo 665 -0.20917 1 10 0 0 fo 666 -0.20981 1 10 0 0 fo 667 -0.21031 1 10 0 0 fo 668 -0.21067 1 10 0 0 fo 669 -0.21088 1 10 0 0 fo 670 -0.21095 1 10 0 0 fo 671 -0.21087 1 10 0 0 fo 672 -0.21065 1 10 0 0 fo 673 -0.21028 1 10 0 0 fo 674 -0.20977 1 10 0 0 fo 675 -0.20911 1 10 0 0 fo 676 -0.20831 1 10 0 0 fo 677 -0.20736 1 10 0 0 fo 678 -0.20626 1 10 0 0 fo 679 -0.20502 1 10 0 0 fo 680 -0.20363 1 10 0 0 fo 681 -0.2021 1 10 0 0 fo 682 -0.20042 1 10 0 0 fo 683 -0.1986 1 10 0 0 fo 684 -0.19664 1 10 0 0 fo 685 -0.19453 1 10 0 0 fo 686 -0.19228 1 10 0 0 fo 687 -0.1899 1 10 0 0 fo 688 -0.18737 1 10 0 0 fo 689 -0.1847 1 10 0 0 fo 690 -0.1819 1 10 0 0 fo 691 -0.17896 1 10 0 0 fo 692 -0.17588 1 10 0 0 fo 693 -0.17267 1 10 0 0 fo 694 -0.16933 1 10 0 0 fo 695 -0.16586 1 10 0 0 fo 696 -0.16226 1 10 0 0 fo 697 -0.15853 1 10 0 0 fo 698 -0.15468 1 10 0 0 fo 699 -0.1507 1 10 0 0 fo 700 -0.1466 1 10 0 0 fo 701 -0.14238 1 10 0 0 fo 702 -0.13805 1 10 0 0 fo 703 -0.1336 1 10 0 0 fo 704 -0.12903 1 10 0 0 fo 705 -0.12436 1 10 0 0 fo 706 -0.11957 1 10 0 0 fo 707 -0.11468 1 10 0 0 fo 708 -0.10969 1 10 0 0 fo 709 -0.1046 1 10 0 0 fo 710 -0.0994 1 10 0 0 fo 711 -0.09412 1 10 0 0 fo 712 -0.08874 1 10 0 0 fo 713 -0.08326 1 10 0 0 fo 714 -0.0777 1 10 0 0 fo 715 -0.07206 1 10 0 0 fo 716 -0.06633 1 10 0 0 fo 717 -0.06053 1 10 0 0 fo 718 -0.05465 1 10 0 0 fo 719 -0.04869 1 10 0 0 fo 720 -0.04267 1 10 0 0 fo 721 -0.03658 1 10 0 0 fo 722 -0.03042 1 10 0 0 fo 723 -0.02421 1 10 0 0 fo 724 -0.01793 1 10 0 0 fo 725 -0.0116 1 10 0 0 fo 726 -0.00522 1 10 0 0 fo 727 0.00121 1 10 0 0 fo 728 0.00769 1 10 0 0 fo 729 0.01421 1 10 0 0 fo 730 0.02077 1 10 0 0 fo 731 0.02737 1 10 0 0 fo 732 0.034 1 10 0 0 fo 733 0.04066 1 10 0 0 fo 734 0.04735 1 10 0 0 fo 735 0.05407 1 10 0 0 fo 736 0.06081 1 10 0 0 fo 737 0.06758 1 10 0 0 fo 738 0.07436 1 10 0 0 fo 739 0.08115 1 10 0 0 fo 740 0.08797 1 10 0 0 fo 741 0.09479 1 10 0 0 fo 742 0.10162 1 10 0 0 fo 743 0.10846 1 10 0 0 fo 744 0.11531 1 10 0 0 fo 745 0.12216 1 10 0 0 fo 746 0.12902 1 10 0 0 fo 747 0.13588 1 10 0 0 fo 748 0.14274 1 10 0 0 fo 749 0.1496 1 10 0 0 fo 750 0.15646 1 10 0 0 xcumC 0 -0.64115 1 10 0 0 xcumC 1 -0.622 1 10 0 0 xcumC 2 -0.60285 1 10 0 0 xcumC 3 -0.5837 1 10 0 0 xcumC 4 -0.56455 1 10 0 0 xcumC 5 -0.54541 1 10 0 0 xcumC 6 -0.52628 1 10 0 0 xcumC 7 -0.50716 1 10 0 0 xcumC 8 -0.48805 1 10 0 0 xcumC 9 -0.46896 1 10 0 0 xcumC 10 -0.4499 1 10 0 0 xcumC 11 -0.43086 1 10 0 0 xcumC 12 -0.41186 1 10 0 0 xcumC 13 -0.39291 1 10 0 0 xcumC 14 -0.374 1 10 0 0 xcumC 15 -0.35515 1 10 0 0 xcumC 16 -0.33636 1 10 0 0 xcumC 17 -0.31764 1 10 0 0 xcumC 18 -0.29899 1 10 0 0 xcumC 19 -0.28044 1 10 0 0 xcumC 20 -0.26197 1 10 0 0 xcumC 21 -0.24361 1 10 0 0 xcumC 22 -0.22536 1 10 0 0 xcumC 23 -0.20722 1 10 0 0 xcumC 24 -0.18921 1 10 0 0 xcumC 25 -0.17133 1 10 0 0 xcumC 26 -0.1536 1 10 0 0 xcumC 27 -0.13602 1 10 0 0 xcumC 28 -0.11859 1 10 0 0 xcumC 29 -0.10134 1 10 0 0 xcumC 30 -0.08426 1 10 0 0 xcumC 31 -0.06736 1 10 0 0 xcumC 32 -0.05066 1 10 0 0 xcumC 33 -0.03416 1 10 0 0 xcumC 34 -0.01786 1 10 0 0 xcumC 35 -0.00179 ''') matParaC2P = np.genfromtxt(paraC2P, names= ['pt1','ct','mods','mbas','para','x','y'], dtype=['&lt;f8','&lt;f8','&lt;f8','&lt;f8','|S30','&lt;f8','&lt;f8'], delimiter='\t') cdef packed struct paraArray: double pt1 double ct double mods double mbas char[30] para double x double y @cython.boundscheck(False) @cython.wraparound(False) @cython.nonecheck(False) @cython.cdivision(True) cpdef genc2p(paraArray [:] mat_p = matParaC2P, double pt_p= 1.0, double ct_p=10.0, double mbas_p =0.0, double mods_p=0.0, double count_c_p=24.0, double lv_p=60.0, double fo_p=740.0, double incentive_p = 200.0): cdef double[:,:] lvsubmat = getSubParaMat(input_s = mat_p, para_s='lv', ct_s = ct_p, pt1_s=pt_p, mbas_s=mbas_p,mods_s=0.0) cdef double lv0 = interp2d(lvsubmat[:,0], lvsubmat[:,1], lv_p) cdef double[:,:] fosubmat = getSubParaMat(input_s = mat_p, para_s='fo', ct_s = ct_p, pt1_s=pt_p, mbas_s=mbas_p,mods_s=0.0) cdef double fo0 = interp2d(fosubmat[:,0], fosubmat[:,1], fo_p) cdef double[:,:] cumCsubmat = getSubParaMat(input_s = mat_p, para_s='xcumC', ct_s = ct_p, pt1_s=pt_p, mbas_s=mbas_p,mods_s=0.0) cdef double cumC0 = interp2d(cumCsubmat[:,0], cumCsubmat[:,1], count_c_p) cdef double[:,:] incsubmat = getSubParaMat(input_s= mat_p, para_s='dollarSaving', ct_s = ct_p, pt1_s=pt_p, mbas_s=mbas_p,mods_s=mods_p) cdef double inc0 = interp2d(incsubmat[:,0], incsubmat[:,1], incentive_p) cdef double[:,:] intercept = getSubParaMat(input_s= mat_p, para_s='(Intercept)', ct_s = ct_p, pt1_s=pt_p, mbas_s=mbas_p,mods_s=0.0) cdef double intercept0 = intercept[0,1] return genLogit(lv0+fo0+cumC0+inc0+intercept0) #return intercept0 cpdef double[:,:] getSubParaMat(paraArray [:] input_s = matParaC2P, double pt1_s =1.0, double ct_s=10.0, double mods_s=0.0, double mbas_s=0.0, char[30] para_s = 'lv'): cdef int start = 0, end =0, k=0 cdef double[:,:] output = zeros2 for i from 0&lt;=i&lt;input_s.size: if input_s[i].pt1 == pt1_s and input_s[i].ct == ct_s and input_s[i].mods==mods_s and input_s[i].mbas==mbas_s and input_s[i].para[:]==para_s[:] and start==0: start = i end = i while end&lt;input_s.size and input_s[end].pt1 == pt1_s and input_s[end].ct == ct_s and input_s[end].mods==mods_s and input_s[end].mbas==mbas_s and input_s[end].para[:]==para_s[:]: (output[k,0], output[k, 1]) = (input_s[end].x, input_s[end].y) end += 1 k+=1 break return output[:k, :] cpdef double interp2d(double[:] x, double[:] y, double new_x, int ex = 0): cdef int nx = x.shape[0]-1 cdef int ny = y.shape[0]-1 cdef double new_y cdef int steps=0 if ex==0 and new_x&lt;x[0]: new_x = x[0] elif ex==0 and new_x&gt;x[nx]: new_x = x[nx] if new_x&lt;=x[0]: new_y = (new_x - x[0])*(y[0]-y[1])/(x[0] - x[1]) + y[0] elif new_x&gt;=x[nx]: new_y = (new_x - x[nx])*(y[ny] - y[ny-1])/(x[nx] - x[nx-1]) + y[ny] else: while new_x&gt;x[steps]: steps +=1 new_y = (new_x - x[steps-1])*(y[steps] - y[steps-1])/(x[steps] - x[steps-1]) + y[steps-1] return new_y cpdef double genLogit(double total): return 1.0/(1.0+exp(-1.0*(total))) cpdef genLoan(): for j from 0&lt;=j&lt;100: for i from 1&lt;=i&lt;240: prob_p = genc2p(mat_p = matParaC2P) </code></pre>

60540

GOOD_ANSWER

<p>I'm new to Python and I just wrote my first program with OOP. The program works just fine and gives me what I want. Is the code clear? Can you review the style or anything else?</p> <pre><code>import numpy as np import time, os, sys import datetime as dt class TemplateGenerator(object): """This is a general class to generate all of the templates""" def excelWrtGE(self,*typos): for typo in typos: self.excelWriteGE.write(typo) return def create_KeywordsGE(self,list): list1=list.split("/") for x in list1: list1=[list1.strip()for list1 in list1] print list1 keyword1="Patrone, Toner aufladen "+str(list1[0]) keyword2="Patronen, CMYK, Set of, Ein" keyword3="Set, of, Schwarz, Cyan, Magenta, Gelb, Photoblack" keyword4="Remanufactured ink, Druckerpatronen Ersatz " keyword5=str(list1[0]) print keyword5 i=1 while len(keyword5)&lt;50: keyword5_old=keyword5 if i&gt;=len(list1): break if len(list1)==1: break keyword5=keyword5+", "+str(list1[i]) if len(keyword5)&gt;50: keyword5=keyword5_old break i=i+1 keywords=keyword1+"\t"+keyword2+"\t"+keyword3+"\t"+keyword4+"\t"+keyword5 + "\t" return keywords def keyFeaturesGE(self,feat,inkNumber): list1=feat.split(",") for x in list1: list1=[list1.strip()for list1 in list1] if inkNumber==5: feat1="Lieferumfang: : 1 Schwarz, 1 Cyan, 1 Magenta, 1 Gelb , 1 Photoblack" if inkNumber==4: feat1="Lieferumfang: : 1 Schwarz, 1 Cyan, 1 Magenta, 1 Gelb " if inkNumber==1: feat1="Lieferumfang: : 1 Cyan " if inkNumber==2: feat1="Lieferumfang: : 1 Magenta " if inkNumber==3: feat1="Lieferumfang: : 1 Gelb " if inkNumber==0: feat1="Lieferumfang: : 1 Schwarz " if inkNumber==242: feat1="Lieferumfang: : 4 Schwarz, 2 Cyan, 2 Magenta, 2 Gelb " if inkNumber==54: feat1="Lieferumfang: : 5 Schwarz, 5 Cyan, 5 Magenta, 5 Gelb " if inkNumber==11: feat1="Lieferumfang: : 1 Photoblack" if inkNumber==25: feat1="Lieferumfang: : 2 Schwarz, 2 Cyan, 2 Magenta, 2 Gelb, 2 Photoblack " if inkNumber==45: feat1="Lieferumfang: : 4 Schwarz, 4 Cyan, 4 Magenta, 4 Gelb, 4 Photoblack " if inkNumber==24: feat1="Lieferumfang: : 2 Schwarz, 2 Cyan, 2 Magenta, 2 Gelb " feat2="100% Kompatibel" feat3="Bis zu 80% Druckkosten sparen - Premium Qualit\xE4t" feat4="Geeignet f\xFCr Folgende Drucker: "+str(list1[0]) feat5="Inhalt der Druckerpatronen ca. bei 5% Deckung (DIN A4)" print feat1 i=1 while len(feat4)&lt;500: feat4_old=feat4 if i&gt;=len(list1): break if len(list1)==1: break feat4=feat4+", "+str(list1[i]) if len(feat4)&gt;500: feat4=feat4_old break i=i+1 ListOfFeatures=feat1+"\t"+ feat2+"\t"+feat3+"\t"+feat4 + "\t" +feat5+"\t" return ListOfFeatures def ManProNum(self,num): list1=num.split("/") for x in list1: list1=[list1.strip()for list1 in list1] ProdNum=str(list1[0]) i=1 while len(ProdNum)&lt;40: ProdNum_old=ProdNum if i&gt;=len(list1): break if len(list1)==1: break ProdNum=ProdNum+", "+str(list1[i]) if len(ProdNum)&gt;40: ProdNum=ProdNum_old break i=i+1 ProdNum=ProdNum+"\t" return ProdNum def pictureLink(self,amount): if amount==1: linkW="dfghj" elif amount==2: linkW="fgh" elif amount==4: linkW="hj" elif amount==5: linkW="lk" elif amount==6: linkW="erty" return str(linkW) # GERMANY STARTS HERE----------------- def GenerateGETemplatesFor6(self,ElementsOfPrinter): FourSetSalePrice=round((float(ElementsOfPrinter[5])+2.5)*1.26*1.2*1.4*1.2,2) descr="Industriell wiederaufgearbeitete und gepr\xFCfte Druckerpatronen in Premium qualit\xE4t 100% Kompatible, keine Original Geeignet f\xFCr folgende Ger\xE4te: "+ElementsOfPrinter[0]+ ". Hinweis: Die auf unseren Shop aufgef\xFChrten Markennamen und Original Zubeh\xF6rbezeichnungen sind eingetragene Warenzeichen Ihrer jeweiligen Hersteller und dienen nur als Anwenderhilfe f\xFCr die Zubeh\xF6ridentifikation.\t" title0="4 Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4]+" Set mit Chip\t" +str(FourSetSalePrice)+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],4) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" self.excelWrtGE(title0) def GenerateGETemplatesFor7(self,ElementsOfPrinter): FiveSetSalePrice=round((float(ElementsOfPrinter[6])+2.5)*1.26*1.2*1.4*1.2,2) descr="Industriell wiederaufgearbeitete und gepr\xFCfte Druckerpatrone in Premium qualit\xE4t 100% Kompatible, keine Original Geeignet f\xFCr folgende Ger\xE4te: "+ElementsOfPrinter[0]+ ". Hinweis: Die auf unseren Shop aufgef\xFChrten Markennamen und Original Zubeh\xF6rbezeichnungen sind eingetragene Warenzeichen Ihrer jeweiligen Hersteller und dienen nur als Anwenderhilfe f\xFCr die Zubeh\xF6ridentifikation.\t" title0="5 Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4]+" - "+ElementsOfPrinter[5]+" Set mit Chip\t" +str(round(FiveSetSalePrice,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],5) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" self.excelWrtGE(title0) def GenerateGETemplatesFor9(self,ElementsOfPrinter): FourSETBuyingPrice=sum(map(float,ElementsOfPrinter[5::])) FourSetSalePrice=round((FourSETBuyingPrice+2.5)*1.26*1.2*1.4*1.2,2) descr="Industriell wiederaufgearbeitete und gepr\xFCfte Druckerpatrone in Premium qualit\xE4t 100% Kompatible, keine Original Geeignet f\xFCr folgende Ger\xE4te: "+ElementsOfPrinter[0]+ ". Hinweis: Die auf unseren Shop aufgef\xFChrten Markennamen und Original Zubeh\xF6rbezeichnungen sind eingetragene Warenzeichen Ihrer jeweiligen Hersteller und dienen nur als Anwenderhilfe f\xFCr die Zubeh\xF6ridentifikation.\t" title0="4 Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[2]+" - "+ElementsOfPrinter[3]+" - " +ElementsOfPrinter[4]+" - "+ElementsOfPrinter[5]+" Set mit Chip\t" +str(round(FourSetSalePrice-1,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],4) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title1="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[2]+" Schwarz mit Chip\t" +str(round((float(ElementsOfPrinter[5])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],0) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title2="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[3]+" Cyan mit Chip\t" +str(round((float(ElementsOfPrinter[6])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],1) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title3="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[4]+" Magenta mit Chip\t" +str(round((float(ElementsOfPrinter[7])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],2) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title4="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[5]+" Gelb mit Chip\t" +str(round((float(ElementsOfPrinter[8])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],3) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title5="4 Druckerpatronen mit CHIP kompatibel f\xFCr "+ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4] +" Multipack SET f\xFCr" +ElementsOfPrinter[0] +" mit Chip\t" +str(round(FourSetSalePrice,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],4) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title6="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+", "+ElementsOfPrinter[2]+", "+ElementsOfPrinter[3]+", "+ElementsOfPrinter[4]+" SET "+ElementsOfPrinter[0]+"\t" +str(round(FourSetSalePrice,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],4) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title7="20 Patronen MIT CHIP kompatibel zu "+ ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4]+"\t" +str(round((FourSETBuyingPrice*5+2.5)*1.26*1.2*1.4*1.2-5,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],54) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title8="10 Premium Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4]+"f\xFCr"+ElementsOfPrinter[0] +"2 SET + 2 BLACK\t" +str(round(((FourSETBuyingPrice*2+2*float(ElementsOfPrinter[5]))+2.5)*1.26*1.2*1.4*1.2-2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],242) +self.create_KeywordsGE(ElementsOfPrinter[0]) +self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title9="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+ "f\xFCr "+ElementsOfPrinter[2]+" Schwarz\t" +str(round((float(ElementsOfPrinter[5])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],0) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title10="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[2]+ "f\xFCr "+ElementsOfPrinter[3]+" Cyan\t" +str(round((float(ElementsOfPrinter[6])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],1) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title11="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[3]+ "f\xFCr "+ElementsOfPrinter[4]+" Magenta\t" +str(round((float(ElementsOfPrinter[7])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],2) +self.create_KeywordsGE(ElementsOfPrinter[0]) +self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title12="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[4]+ "f\xFCr "+ElementsOfPrinter[5]+" Gelb\t"+str(round((float(ElementsOfPrinter[8])+2.5)*1.26*1.2*1.4*1.2,2))+"\t" +self.keyFeaturesGE(ElementsOfPrinter[0],3) +self.create_KeywordsGE(ElementsOfPrinter[0]) +self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" self.excelWrtGE(title0,title1,title2,title3,title4,title5,title6,title7,title8,title9,title10,title11,title12) def GenerateGETemplatesFor11(self,ElementsOfPrinter): # print ElementsOfPrinter[5], ElementsOfPrinter[10] FiveSETBuyingPrice=sum(map(float,ElementsOfPrinter[6::])) FourSETBuyingPrice=sum(map(float,ElementsOfPrinter[7::])) FourSetSalePrice=(FourSETBuyingPrice+2.5)*1.26*1.2*1.4*1.2 FiveSetSalePrice=round((FiveSETBuyingPrice+2.5)*1.26*1.2*1.4*1.2) descr="Industriell wiederaufgearbeitete und gepr\xFCfte Druckerpatrone in Premium qualit\xE4t 100% Kompatible, keine Original Geeignet f\xFCr folgende Ger\xE4te: "+ElementsOfPrinter[0]+ ". Hinweis: Die auf unseren Shop aufgef\xFChrten Markennamen und Original Zubeh\xF6rbezeichnungen sind eingetragene Warenzeichen Ihrer jeweiligen Hersteller und dienen nur als Anwenderhilfe f\xFCr die Zubeh\xF6ridentifikation.\t" title0="4 Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4]+" Set mit Chip\t" +str(round(FourSetSalePrice,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],4) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title1="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[1]+" Photoblack mit Chip\t" +str(round((float(ElementsOfPrinter[6])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],11) +self.create_KeywordsGE(ElementsOfPrinter[0]) +self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title2="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[2]+" Schwarz mit Chip\t" +str(round((float(ElementsOfPrinter[7])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],1) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title3="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[3]+" Cyan mit Chip\t" +str(round((float(ElementsOfPrinter[8])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],1) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title4="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[4]+" Magenta mit Chip\t" +str(round((float(ElementsOfPrinter[9])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[2],2) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title5="Druckerpatrone kompatibel f\xFCr "+ElementsOfPrinter[5]+" Gelb mit Chip\t" +str(round((float(ElementsOfPrinter[10])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],3) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title6="5 Druckerpatronen mit CHIP kompatibel f\xFCr "+ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4] +" - "+ElementsOfPrinter[5]+" Multipack SET f\xFCr " +ElementsOfPrinter[0] +" mit Chip\t" +str(FiveSetSalePrice)+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],5) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title7="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+", "+ElementsOfPrinter[2]+", "+ElementsOfPrinter[3]+", "+ElementsOfPrinter[4]+","+ElementsOfPrinter[5]+" SET "+ElementsOfPrinter[0]+"\t" +str(round(FiveSetSalePrice,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],5) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title8="20 Patronen MIT CHIP kompatibel zu "+ ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4]+" - "+ElementsOfPrinter[5]+"\t" +str(round((FiveSETBuyingPrice*4+2.5)*1.26*1.2*1.4*1.2-4,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],45) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title9="10 Premium Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+" - "+ElementsOfPrinter[2]+" - " +ElementsOfPrinter[3]+" - "+ElementsOfPrinter[4]+" - "+ElementsOfPrinter[5]+" f\xFCr"+ElementsOfPrinter[0] +"2 SET\t" +str(round((FiveSETBuyingPrice*2+2.5)*1.26*1.2*1.4*1.2-2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],25) +self.create_KeywordsGE(ElementsOfPrinter[0]) +self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title10="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[1]+ "f\xFCr "+ElementsOfPrinter[0]+" Photoblack\t"+str(round((float(ElementsOfPrinter[6])+2.5)*1.26*1.2*1.4*1.2,2))+"\t" +self.keyFeaturesGE(ElementsOfPrinter[0],11) +self.create_KeywordsGE(ElementsOfPrinter[0]) +self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title11="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[2]+ "f\xFCr "+ElementsOfPrinter[0]+" Schwarz\t" +str(round((float(ElementsOfPrinter[7])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],0) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title12="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[3]+ "f\xFCr "+ElementsOfPrinter[0]+" Cyan\t" +str(round((float(ElementsOfPrinter[8])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],1) +self.create_KeywordsGE(ElementsOfPrinter[0])+self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title13="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[4]+ "f\xFCr "+ElementsOfPrinter[0]+" Magenta\t" +str(round((float(ElementsOfPrinter[9])+2.5)*1.26*1.2*1.4*1.2,2))+"\t"+self.keyFeaturesGE(ElementsOfPrinter[0],2) +self.create_KeywordsGE(ElementsOfPrinter[0]) +self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" title14="XXL PREMIUM Druckerpatronen kompatibel f\xFCr "+ElementsOfPrinter[5]+ "f\xFCr "+ElementsOfPrinter[0]+" Gelb\t"+str(round((float(ElementsOfPrinter[10])+2.5)*1.26*1.2*1.4*1.2,2))+"\t" +self.keyFeaturesGE(ElementsOfPrinter[0],3) +self.create_KeywordsGE(ElementsOfPrinter[0]) +self.ManProNum(ElementsOfPrinter[0])+descr+self.pictureLink(1)+"\n" self.excelWrtGE(title0,title1,title2,title3,title4,title5,title6,title7,title8,title9,title10,title11,title12,title13,title14) def __init__(self): super(TemplateGenerator, self).__init__() # self.arg = arg now=dt.datetime.now() cur_time=time.mktime(now.timetuple()) path='/Users/dfghj/Desktop/listings/THM/'+str(cur_time) print str(cur_time) os.mkdir(path) excelRead=open('/Users/dfghj/Desktop/listings/dataGA.txt','r') self.excelWriteGE=open(path +'/Them.GE.Sets.txt','w') header="Titles\t"+"Price equal to title:\t"+"Key Features1\t"+"Key Features2\t"+"Key Features3\t"+"Key Features4\t"+"Key Feature5\t"+"keyword1\t"+"keyword2\t"+"keyword3\t"+"keyword4\t"+"keyword5\t"+"Manufacturer Part Number\t"+"Description\t"+"Picture Link\n" self.excelWrtGE(header) data=np.genfromtxt(excelRead, delimiter="\n", dtype=None) for line in data: titles=line.split("+") # print title, len(title) if len(titles)==11: self.GenerateGETemplatesFor11(titles) elif len(titles)==9: self.GenerateGETemplatesFor9(titles) elif len(titles)==7: self.GenerateGETemplatesFor7(titles) elif len(titles)==6: self.GenerateGETemplatesFor6(titles) else: print "Check your names in file once again!!!" excelRead.close() self.excelWriteGE.close() self.excelWriteSP.close() if __name__=='__main__': TemplateGenerator() </code></pre>

70989

GOOD_ANSWER

<p>In honor of Star Wars day, I've put together this small Python program I'm calling JediScript. JediScript is essentially a scrapped-down version of BrainFuck without input or looping. Here are the commands in JediScript.</p> <ul> <li><code>SlashWithSaber</code>: Move forward on the tape.</li> <li><code>ParryBladeWithSaber</code>: Move backward on the tape.</li> <li><code>StabWithSaber</code>: Increment a cell.</li> <li><code>BlockBladeWithSaber</code>: Decrement cell.</li> <li><code>UseForceWithHands</code>: Output the current cell.</li> </ul> <p>Each command is semicolon <code>;</code> separated, like so: <code>StabWithSaber;UseForceWithHands</code>. Here's an example input. This will output the character <code>p</code>.</p> <blockquote> <pre><code>StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;StabWithSaber;UseForceWithHands; </code></pre> </blockquote> <p>This is something that I threw together in about 20 minutes, so it's not the greatest, but I'd still appreciate a review.</p> <pre><code>#!/usr/bin/env python """ JediScript, BrainFuck for Star Wars. May the 4th be with you. """ DEFAULT_SPLIT = ";" """ Variables below this are environment variables for the user to modify. """ data_tape = [0 for _ in range(256)] tape_pos = 0 def increment_cell(): global data_tape global tape_pos data_tape[tape_pos] += 1 if data_tape[tape_pos] &lt;= 127 else 0 def decrement_cell(): global data_tape global tape_pos data_tape[tape_pos] -= 1 if data_tape[tape_pos] &gt;= 0 else 0 def move_forward(): global tape_pos tape_pos += 1 if tape_pos &lt;= len(data_tape) - 1 else 0 def move_backward(): global tape_pos tape_pos -= 1 if tape_pos &gt;= 0 else 0 def output_cell(): print chr(data_tape[tape_pos]) """ Dictionary contains tokens that reference their relevant functions. """ TOKENS = { "SlashWithSaber": move_forward, "ParryBladeWithSaber": move_backward, "StabWithSaber": increment_cell, "BlockBladeWithSaber": decrement_cell, "UseForceWithHands": output_cell, } def execute_commands(tokenized_string): """ Executes commands from the tokenized string. tokenized_string - The tokenized string """ for token in tokenized_string: if token in TOKENS: TOKENS[token]() def tokenize_input(string): """ Tokenize a string into it's the form [ token, ... ] string - The string to tokenize. """ string = string.replace(" ", "") string = string.split(DEFAULT_SPLIT) return string def get_user_input(prompt): """ Get input from the user. prompt - The prompt to be used. """ while True: string = raw_input(prompt) string = tokenize_input(string) execute_commands(string) if __name__ == "__main__": get_user_input("JediScript $ ") </code></pre>

88783

WEIRD

<h2><strong><a href="https://codegolf.stackexchange.com/questions/50472/check-if-words-are-isomorphs">Are the words isomorphs? (Code-Golf)</a></strong></h2> <p>This is my non-golfed, readable and linear (quasi-linear?) in complexity take of the above problem. For completeness I include the description:</p> <blockquote> <p>Two words are isomorphs if they have the same pattern of letter repetitions. For example, both ESTATE and DUELED have pattern abcdca</p> <pre><code>ESTATE DUELED abcdca </code></pre> <p>because letters 1 and 6 are the same, letters 3 and 5 are the same, and nothing further. This also means the words are related by a substitution cipher, here with the matching <code>E &lt;-&gt; D, S &lt;-&gt; U, T &lt;-&gt; E, A &lt;-&gt; L</code>.</p> <p>Write code that takes two words and checks whether they are isomorphs.</p> </blockquote> <p>As always tests are included for easier understanding and modification.</p> <pre><code>def repetition_pattern(text): """ Same letters get same numbers, small numbers are used first. Note: two-digits or higher numbers may be used if the the text is too long. &gt;&gt;&gt; repetition_pattern('estate') '012320' &gt;&gt;&gt; repetition_pattern('dueled') '012320' &gt;&gt;&gt; repetition_pattern('longer example') '012345647891004' # ^ ^ ^ 4 stands for 'e' because 'e' is at 4-th position. # ^^ Note the use of 10 after 9. """ for index, unique_letter in enumerate(sorted(set(text), key=text.index)): text = text.replace(unique_letter, str(index)) return text def are_isomorph(word_1, word_2): """ Have the words (or string of arbitrary characters) the same the same `repetition_pattern` of letter repetitions? All the words with all different letters are trivially isomorphs to each other. &gt;&gt;&gt; are_isomorph('estate', 'dueled') True &gt;&gt;&gt; are_isomorph('estate'*10**4, 'dueled'*10**4) True &gt;&gt;&gt; are_isomorph('foo', 'bar') False """ return repetition_pattern(word_1) == repetition_pattern(word_2) </code></pre>

94776

GOOD_ANSWER

<h2><strong><a href="https://codegolf.stackexchange.com/questions/50472/check-if-words-are-isomorphs">Are the words isomorphs? (Code-Golf)</a></strong></h2> <p>This is my non-golfed, readable and linear (quasi-linear?) in complexity take of the above problem. For completeness I include the description:</p> <blockquote> <p>Two words are isomorphs if they have the same pattern of letter repetitions. For example, both ESTATE and DUELED have pattern abcdca</p> <pre><code>ESTATE DUELED abcdca </code></pre> <p>because letters 1 and 6 are the same, letters 3 and 5 are the same, and nothing further. This also means the words are related by a substitution cipher, here with the matching <code>E &lt;-&gt; D, S &lt;-&gt; U, T &lt;-&gt; E, A &lt;-&gt; L</code>.</p> <p>Write code that takes two words and checks whether they are isomorphs.</p> </blockquote> <p>As always tests are included for easier understanding and modification.</p> <pre><code>def repetition_pattern(text): """ Same letters get same numbers, small numbers are used first. Note: two-digits or higher numbers may be used if the the text is too long. &gt;&gt;&gt; repetition_pattern('estate') '012320' &gt;&gt;&gt; repetition_pattern('dueled') '012320' &gt;&gt;&gt; repetition_pattern('longer example') '012345647891004' # ^ ^ ^ 4 stands for 'e' because 'e' is at 4-th position. # ^^ Note the use of 10 after 9. """ for index, unique_letter in enumerate(sorted(set(text), key=text.index)): text = text.replace(unique_letter, str(index)) return text def are_isomorph(word_1, word_2): """ Have the words (or string of arbitrary characters) the same the same `repetition_pattern` of letter repetitions? All the words with all different letters are trivially isomorphs to each other. &gt;&gt;&gt; are_isomorph('estate', 'dueled') True &gt;&gt;&gt; are_isomorph('estate'*10**4, 'dueled'*10**4) True &gt;&gt;&gt; are_isomorph('foo', 'bar') False """ return repetition_pattern(word_1) == repetition_pattern(word_2) </code></pre>

94776

WEIRD

<h2><strong><a href="https://codegolf.stackexchange.com/questions/50472/check-if-words-are-isomorphs">Are the words isomorphs? (Code-Golf)</a></strong></h2> <p>This is my non-golfed, readable and linear (quasi-linear?) in complexity take of the above problem. For completeness I include the description:</p> <blockquote> <p>Two words are isomorphs if they have the same pattern of letter repetitions. For example, both ESTATE and DUELED have pattern abcdca</p> <pre><code>ESTATE DUELED abcdca </code></pre> <p>because letters 1 and 6 are the same, letters 3 and 5 are the same, and nothing further. This also means the words are related by a substitution cipher, here with the matching <code>E &lt;-&gt; D, S &lt;-&gt; U, T &lt;-&gt; E, A &lt;-&gt; L</code>.</p> <p>Write code that takes two words and checks whether they are isomorphs.</p> </blockquote> <p>As always tests are included for easier understanding and modification.</p> <pre><code>def repetition_pattern(text): """ Same letters get same numbers, small numbers are used first. Note: two-digits or higher numbers may be used if the the text is too long. &gt;&gt;&gt; repetition_pattern('estate') '012320' &gt;&gt;&gt; repetition_pattern('dueled') '012320' &gt;&gt;&gt; repetition_pattern('longer example') '012345647891004' # ^ ^ ^ 4 stands for 'e' because 'e' is at 4-th position. # ^^ Note the use of 10 after 9. """ for index, unique_letter in enumerate(sorted(set(text), key=text.index)): text = text.replace(unique_letter, str(index)) return text def are_isomorph(word_1, word_2): """ Have the words (or string of arbitrary characters) the same the same `repetition_pattern` of letter repetitions? All the words with all different letters are trivially isomorphs to each other. &gt;&gt;&gt; are_isomorph('estate', 'dueled') True &gt;&gt;&gt; are_isomorph('estate'*10**4, 'dueled'*10**4) True &gt;&gt;&gt; are_isomorph('foo', 'bar') False """ return repetition_pattern(word_1) == repetition_pattern(word_2) </code></pre>

94776

WEIRD

<h2><strong><a href="https://codegolf.stackexchange.com/questions/50472/check-if-words-are-isomorphs">Are the words isomorphs? (Code-Golf)</a></strong></h2> <p>This is my non-golfed, readable and linear (quasi-linear?) in complexity take of the above problem. For completeness I include the description:</p> <blockquote> <p>Two words are isomorphs if they have the same pattern of letter repetitions. For example, both ESTATE and DUELED have pattern abcdca</p> <pre><code>ESTATE DUELED abcdca </code></pre> <p>because letters 1 and 6 are the same, letters 3 and 5 are the same, and nothing further. This also means the words are related by a substitution cipher, here with the matching <code>E &lt;-&gt; D, S &lt;-&gt; U, T &lt;-&gt; E, A &lt;-&gt; L</code>.</p> <p>Write code that takes two words and checks whether they are isomorphs.</p> </blockquote> <p>As always tests are included for easier understanding and modification.</p> <pre><code>def repetition_pattern(text): """ Same letters get same numbers, small numbers are used first. Note: two-digits or higher numbers may be used if the the text is too long. &gt;&gt;&gt; repetition_pattern('estate') '012320' &gt;&gt;&gt; repetition_pattern('dueled') '012320' &gt;&gt;&gt; repetition_pattern('longer example') '012345647891004' # ^ ^ ^ 4 stands for 'e' because 'e' is at 4-th position. # ^^ Note the use of 10 after 9. """ for index, unique_letter in enumerate(sorted(set(text), key=text.index)): text = text.replace(unique_letter, str(index)) return text def are_isomorph(word_1, word_2): """ Have the words (or string of arbitrary characters) the same the same `repetition_pattern` of letter repetitions? All the words with all different letters are trivially isomorphs to each other. &gt;&gt;&gt; are_isomorph('estate', 'dueled') True &gt;&gt;&gt; are_isomorph('estate'*10**4, 'dueled'*10**4) True &gt;&gt;&gt; are_isomorph('foo', 'bar') False """ return repetition_pattern(word_1) == repetition_pattern(word_2) </code></pre>

94776

GOOD_ANSWER

<p>I am new to programming and I am trying to make a simple unit converter in python. I want to convert units within the metric system and metric to imperial and vice-versa. I have started with this code and I found this method is slow and in-efficient, How can I code this more efficiently?</p> <pre><code>import math import time """Unit Converter""" #Welcome and variable setting print ("Welcome to Sam's Unit Converter") cat = raw_input ("Which category would you like to convert? we support length(l) and Weight(w): ") if cat == ("l"): unit1 = raw_input ("Which unit would you like to convert from: ") unit2 = raw_input ("Which unit would you like to convert to: ") num1 = raw_input ("Enter your value: " ) ##Calculations if unit1 == "cm" and unit2 == "m": ans = float(num1)/100 elif unit1 == "mm" and unit2 == "cm": ans = float(num1)/10 elif unit1 == "m" and unit2 == "cm": ans = float(num1)*100 elif unit1 == "cm" and unit2 == "mm": ans = float(num1)*10 elif unit1 == "mm" and unit2 == "m": ans = float(num1)/1000 elif unit1 == "m" and unit2 == "mm": ans = float(num1)*1000 elif unit1 == "km" and unit2 == "m": ans = float(num1)*1000 elif unit1 == "m" and unit2 == "km": ans = float(num1)/1000 elif unit1 == "mm" and unit2 == "km": ans = float(num1)/1000000 </code></pre>

101348

BAD_ANSWER

<p>I am new to programming and I am trying to make a simple unit converter in python. I want to convert units within the metric system and metric to imperial and vice-versa. I have started with this code and I found this method is slow and in-efficient, How can I code this more efficiently?</p> <pre><code>import math import time """Unit Converter""" #Welcome and variable setting print ("Welcome to Sam's Unit Converter") cat = raw_input ("Which category would you like to convert? we support length(l) and Weight(w): ") if cat == ("l"): unit1 = raw_input ("Which unit would you like to convert from: ") unit2 = raw_input ("Which unit would you like to convert to: ") num1 = raw_input ("Enter your value: " ) ##Calculations if unit1 == "cm" and unit2 == "m": ans = float(num1)/100 elif unit1 == "mm" and unit2 == "cm": ans = float(num1)/10 elif unit1 == "m" and unit2 == "cm": ans = float(num1)*100 elif unit1 == "cm" and unit2 == "mm": ans = float(num1)*10 elif unit1 == "mm" and unit2 == "m": ans = float(num1)/1000 elif unit1 == "m" and unit2 == "mm": ans = float(num1)*1000 elif unit1 == "km" and unit2 == "m": ans = float(num1)*1000 elif unit1 == "m" and unit2 == "km": ans = float(num1)/1000 elif unit1 == "mm" and unit2 == "km": ans = float(num1)/1000000 </code></pre>

101348

GOOD_ANSWER

<p>I am new to programming and I am trying to make a simple unit converter in python. I want to convert units within the metric system and metric to imperial and vice-versa. I have started with this code and I found this method is slow and in-efficient, How can I code this more efficiently?</p> <pre><code>import math import time """Unit Converter""" #Welcome and variable setting print ("Welcome to Sam's Unit Converter") cat = raw_input ("Which category would you like to convert? we support length(l) and Weight(w): ") if cat == ("l"): unit1 = raw_input ("Which unit would you like to convert from: ") unit2 = raw_input ("Which unit would you like to convert to: ") num1 = raw_input ("Enter your value: " ) ##Calculations if unit1 == "cm" and unit2 == "m": ans = float(num1)/100 elif unit1 == "mm" and unit2 == "cm": ans = float(num1)/10 elif unit1 == "m" and unit2 == "cm": ans = float(num1)*100 elif unit1 == "cm" and unit2 == "mm": ans = float(num1)*10 elif unit1 == "mm" and unit2 == "m": ans = float(num1)/1000 elif unit1 == "m" and unit2 == "mm": ans = float(num1)*1000 elif unit1 == "km" and unit2 == "m": ans = float(num1)*1000 elif unit1 == "m" and unit2 == "km": ans = float(num1)/1000 elif unit1 == "mm" and unit2 == "km": ans = float(num1)/1000000 </code></pre>

101348

GOOD_ANSWER

<p>I suspect there might be a much more efficient way to accomplish this task. I would appreciate a more clever hint for performance increase. I am also looking for feedback on style and simplification where appropriate. </p> <p>I assume that the set of what counts as English words is a given and that I don't need to do something clever like an actual dictionary or use Google n-grams. That being said, the results could differ depending on the domain and also what is accepted as a word. </p> <p>The original problem set M=3 (3-gram characters), which makes the results not so interesting (ans=<code>[(u'the', 191279), (u'and', 92292), (u'ing', 57323), (u'her', 44627), (u'hat', 38609)]</code>). </p> <pre><code>#gets the top N most common substrings of M characters in English words from nltk import FreqDist from nltk.corpus import gutenberg def get_words(): for fileid in gutenberg.fileids(): for word in gutenberg.words(fileid): yield word def ngrams(N, which_list, strict=False): list_size = len(which_list) stop = list_size if strict: stop -= (N - 1) for i in xrange(0, stop): element = which_list[i] ngram = [element] j = 1 index = j + i while j &lt; N and index &lt; list_size: ngram.append(which_list[index]) j += 1 index += 1 yield ''.join(ngram) def m_most_common_ngram_chars(M=5, N=3): n_grams = [] for word in get_words(): for ngram in ngrams(N, word, strict=True): n_grams.append(ngram) f = FreqDist(n_grams) return f.most_common(M) l = m_most_common_ngram_chars(M=5, N=3) print l </code></pre>

105883

GOOD_ANSWER

<p>I suspect there might be a much more efficient way to accomplish this task. I would appreciate a more clever hint for performance increase. I am also looking for feedback on style and simplification where appropriate. </p> <p>I assume that the set of what counts as English words is a given and that I don't need to do something clever like an actual dictionary or use Google n-grams. That being said, the results could differ depending on the domain and also what is accepted as a word. </p> <p>The original problem set M=3 (3-gram characters), which makes the results not so interesting (ans=<code>[(u'the', 191279), (u'and', 92292), (u'ing', 57323), (u'her', 44627), (u'hat', 38609)]</code>). </p> <pre><code>#gets the top N most common substrings of M characters in English words from nltk import FreqDist from nltk.corpus import gutenberg def get_words(): for fileid in gutenberg.fileids(): for word in gutenberg.words(fileid): yield word def ngrams(N, which_list, strict=False): list_size = len(which_list) stop = list_size if strict: stop -= (N - 1) for i in xrange(0, stop): element = which_list[i] ngram = [element] j = 1 index = j + i while j &lt; N and index &lt; list_size: ngram.append(which_list[index]) j += 1 index += 1 yield ''.join(ngram) def m_most_common_ngram_chars(M=5, N=3): n_grams = [] for word in get_words(): for ngram in ngrams(N, word, strict=True): n_grams.append(ngram) f = FreqDist(n_grams) return f.most_common(M) l = m_most_common_ngram_chars(M=5, N=3) print l </code></pre>

105883

GOOD_ANSWER

<p>Often I need to perform <em>multiple assignment</em> from a sequence (e.g. from the result of a <a href="https://docs.python.org/2/library/string.html#string.split" rel="noreferrer"><code>split()</code></a>) but with some semantics that, AFAIK, are not available in the language:</p> <ol> <li><p>Assign N first elements and silently ignore the rest (like Perl's <a href="http://docstore.mik.ua/orelly/perl4/lperl/ch03_04.htm" rel="noreferrer">list assignment</a>).</p> <pre><code>&gt;&gt;&gt; a, b = 'foo bar is here'.split() &gt;&gt;&gt; a, b ('foo', 'bar') &gt;&gt;&gt; </code></pre></li> <li><p>Assign the remaning items to the last variable in the variable list:</p> <pre><code>&gt;&gt;&gt; a, b, c = 'foo bar is here'.split() &gt;&gt;&gt; a, b, c ('foo', 'bar', ['is', 'here']) &gt;&gt;&gt; </code></pre></li> <li><p>If the sequence doesn't have enough values, set the variables to a default value (<code>None</code> or any other, again similar to <a href="http://docstore.mik.ua/orelly/perl4/lperl/ch03_04.htm" rel="noreferrer">Perl</a>):</p> <pre><code>&gt;&gt;&gt; a, b, c, d, e = 'foo bar is here'.split() &gt;&gt;&gt; a, b, c, d, e ('foo', 'bar', 'is', 'here', None) &gt;&gt;&gt; </code></pre></li> </ol> <p>I have designed an iterator function to help me with this, but I'm concerned about my solution to this problem from the point of view of pythonic adherence:</p> <ul> <li><p>Usefulness: Using an iterator for this kind of job is the right option, or there is something more appropriate? Or even worse: my need to do this kind of assignment in Python is not favoring other language features?</p></li> <li><p>Clearness: The implementation is solid and clear enough? Or is there some other way to implement this that would be cleaner?</p></li> </ul> <p>In other words, this solution is better discarded or can it be improved?</p> <pre class="lang-py prettyprint-override"><code>from itertools import * def iterassign(iterable, *, count, use_default=False, default=None, tail=False): """Iterattor for multiple assignment. :param iterable: The iterable. :param int count: The maximum count of iterations. :param bool use_default: If set, and iterable ends before max_count, continue iteration using :param:`default`. :param default: Default value to use when :param:`use_default` is set to ``True``. """ it = iter(iterable) for idx, element in enumerate(chain(islice(it, 0, count), repeat(default))): if idx &gt;= count: break yield element else: raise StopIteration() if tail: yield list(it) </code></pre> <p>Usage examples:</p> <pre><code>&gt;&gt;&gt; ret = 'foo bar is here'.split() &gt;&gt;&gt; a, b = iterassign(ret, count=2) &gt;&gt;&gt; a, b ('foo', 'bar') &gt;&gt;&gt; a, b, c = iterassign(ret, count=2, tail=True) &gt;&gt;&gt; a, b, c ('foo', 'bar', ['is', 'here']) &gt;&gt;&gt; a, b, c, d, e = iterassign(ret, count=5, use_default=True) ('foo', 'bar', 'is', 'here', None) &gt;&gt;&gt; </code></pre>

110769

GOOD_ANSWER

<p>My code implementing rock, paper and scissors in Python, using dicts to hold choices.</p> <pre><code>import random choices = ['rock', 'paper', 'scissors'] def choice(): player_choice = raw_input('Choose rock, paper or scissors: ') if player_choice.lower() in choices: computer_choice = random.choice(choices) play(player_choice, computer_choice) else: choice() def play(p_choice, c_choice): win_table = {'rock' : {'rock':'It was a Tie', 'paper':'You Lose', 'scissors':'You Win'}, 'paper' : {'rock':'You Win', 'paper':'It was a Tie', 'scissors':'You Lose'}, 'scissors' : {'rock':'You Lose', 'paper':'You Win', 'scissors':'It was a Tie'}} print 'Computer chose', c_choice print win_table[p_choice][c_choice] new = raw_input('Play again ? (Y/N): ') if new.lower() == 'y': choice() else: print 'Have a nice day !' choice() </code></pre> <p><code>win_table</code> dictionary names are player choices and dictionary keys are computer choices, seems more efficient to me. I haven't run any memory usage tests, though.</p>

111684

GOOD_ANSWER

<p>My code implementing rock, paper and scissors in Python, using dicts to hold choices.</p> <pre><code>import random choices = ['rock', 'paper', 'scissors'] def choice(): player_choice = raw_input('Choose rock, paper or scissors: ') if player_choice.lower() in choices: computer_choice = random.choice(choices) play(player_choice, computer_choice) else: choice() def play(p_choice, c_choice): win_table = {'rock' : {'rock':'It was a Tie', 'paper':'You Lose', 'scissors':'You Win'}, 'paper' : {'rock':'You Win', 'paper':'It was a Tie', 'scissors':'You Lose'}, 'scissors' : {'rock':'You Lose', 'paper':'You Win', 'scissors':'It was a Tie'}} print 'Computer chose', c_choice print win_table[p_choice][c_choice] new = raw_input('Play again ? (Y/N): ') if new.lower() == 'y': choice() else: print 'Have a nice day !' choice() </code></pre> <p><code>win_table</code> dictionary names are player choices and dictionary keys are computer choices, seems more efficient to me. I haven't run any memory usage tests, though.</p>

111684

GOOD_ANSWER

<p>This is the "<a href="https://www.codeeval.com/browse/205/" rel="nofollow noreferrer">Clean up the words</a>" challenge from CodeEval:</p> <blockquote> <h3>Challenge</h3> <p>Given a list of words mixed with extra symbols. Write a program that will clean up the words from extra numbers and symbols.</p> <h3>Specifications</h3> <ol> <li>The first argument is a path to a file. </li> <li>Each line includes a test case.</li> <li>Each test case is a list of words.</li> <li>Letters are both lowercase and uppercase, and mixed with extra symbols.</li> <li>Print the words separated by spaces in lowercase letters.</li> </ol> <h3>Constraints</h3> <ol> <li>The length of a test case together with extra symbols can be in a range from 10 to 100 symbols.</li> <li>The number of test cases is 40.</li> </ol> <p><strong>Input Sample</strong></p> <pre><code>(--9Hello----World...--) Can 0$9 ---you~ 13What213are;11you-123+138doing7 </code></pre> <p><strong>Output Sample</strong></p> <pre><code>hello world can you what are you doing </code></pre> </blockquote> <p>In a <a href="https://codereview.stackexchange.com/questions/131730/no-more-filthy-words?noredirect=1#comment245828_131730">previous question</a> someone joked the program would be much shorter / simpler in Python. I accepted this as a challenge and excuse to practice Python.</p> <p><strong>Solution</strong>:</p> <pre><code>import sys import re def sanitized(line): sanitized_line = re.sub("[^a-zA-Z]+", " ", line) return sanitized_line.lower().strip() def main(file): with open(file, 'r') as input_file: for line in input_file: print(sanitized(line)) if __name__ == "__main__": try: file = sys.argv[1] main(file) except: print("No argument provided.") </code></pre> <p>It's so succinct I'm unsure there's enough for a review, but this site surprised me in the past.</p>

131804

GOOD_ANSWER

<p>I am working through Automate the Boring Stuff. How can I make this code cleaner/better?</p> <pre><code>#madlibs.py : ABS Chapter 8 Project #Make mad libs using madlibtemplate.txt file that will prompt user for parts of speech #Will return new file with replacements called madlib.txt import re, os #Create template.txt file if doesn't exist print("Let's play MadLibs! \n Note: Your current working directory is ", os.getcwd()) if os.path.exists('madlibtemplate.txt') == False: print("No template file found. Using default 'madlibtemplate.txt'") template = open('madlibtemplate.txt', 'w+') template.write("""The ADJECTIVE girl walked to the NOUN and then VERB. A nearby NOUN was upset by this.""") else: print("Using your 'madlibtemplate.txt' file:") template = open('madlibtemplate.txt', 'r') #Extract text from template file &amp; turn into list of words template.seek(0) #reset pointer to beginning of file text = (template.read()).lower() #make lowercase to match parts of speech wordregex = re.compile(r'\w+|\s|\S') words = re.findall(wordregex, text) #Find and replace parts of speech for i, word in enumerate(words): for part_of_speech in ['adjective', 'noun', 'adverb', 'verb', 'interjection']: if word == part_of_speech: print('Enter a(n) %s ' % part_of_speech) words[i] = input() madlib_text_unformatted = ''.join(words) #Capitalize first letter in each sentence (Function found on stackoverflow) def sentence_case(text): # Split into sentences. Therefore, find all text that ends # with punctuation followed by white space or end of string. sentences = re.findall('[^.!?]+[.!?](?:\s|\Z)', text) # Capitalize the first letter of each sentence sentences = [x[0].upper() + x[1:] for x in sentences] # Combine sentences return ''.join(sentences) madlib_text = sentence_case(madlib_text_unformatted) #Print result and save to a new file print('Here we go... \n') print(madlib_text) madlib = open('madlib.txt', 'w') madlib.write(madlib_text) madlib.close() template.close() print("\n This has been saved to file 'madlib.txt'") </code></pre>

157698

GOOD_ANSWER

<p>I need to calculate a Bayesian likelihood in its negative logarithmic form:</p> <p>$$-\ln L = N\ln M -\sum\limits_{i=1}^{N} \ln\left\{P_i \sum\limits_{j=1}^M \frac{\exp\left[ -\frac{1}{2}\left(\sum_{k=1}^D \frac{(f_{ik}-g_{jk})^2}{\sigma_{ik}^2 + \rho_{jk}^2}\right) \right]}{\prod_{k=1}^D \sqrt{\sigma_{ik}^2 + \rho_{jk}^2}} \right\}$$</p> <p>where these $$P_i\;\;;\;\; f_{ik} \;\;;\;\; \sigma_{ik}^2\;\;;\;\; g_{jk} \;\;;\;\; \rho_{jk}^2$$ are all known floats. This is my code:</p> <pre><code>import numpy as np # Define random data with correct shapes. N, M = np.random.randint(10, 1000), np.random.randint(10, 1000) D = np.random.randint(2, 5) f_N, g_M = np.random.rand(N, D, 2), np.random.rand(M, D, 2) P_i = np.random.uniform(0., 1., N) # N summatory. # Store here each 'i' element from the M summatory. sum_Mi = [] for f_i in f_N: # M summatory. sum_M_j = 0. for g_j in g_M: # Obtain ijk element inside the M summatory D_sum, sigma_ijk = 0., 1. for k, f_ik in enumerate(f_i): # Where: f_ik[0] = \f_{ik} ; g_j[k][0] = \g_{jk} # and: f_ik[1] = \sigma_{ik}^2 ; g_j[k][1] = \rho_{jk}^2 D_sum += np.square(f_ik[0] - g_j[k][0]) / (f_ik[1] + g_j[k][1]) sigma_ijk = sigma_ijk * (f_ik[1] + g_j[k][1]) sum_M_j += np.exp(-0.5 * D_sum) / np.sqrt(sigma_ijk) sum_Mi.append(sum_M_j) sum_Mi_Pi = P_i * sum_Mi # Remove 0. elements before applying the logarithm below. sum_N = sum_Mi_Pi[sum_Mi_Pi != 0.] # Final negative logarithmic likelihood lik = len(f_N) * np.log(len(g_M)) - sum(np.log(sum_N)) print(lik) </code></pre> <p>I'm after an optimization done at the code level, ie: not using multi-threading.</p> <p>I've tried <code>numpy</code> broadcasting on the inner loop</p> <pre><code># Obtain ijk element inside the M summatory D_sum = sum(np.square((f_i[:, 0] - g_j[:, 0])) / (f_i[:, 1] + g_j[:, 1])) sigma_ijk = np.prod(f_i[:, 1] + g_j[:, 1]) </code></pre> <p>but that actually <em>takes a longer time to complete</em> than using the <code>for</code> loop!</p> <p>I also tried using the <a href="https://docs.scipy.org/doc/scipy-0.13.0/reference/generated/scipy.misc.logsumexp.html" rel="nofollow noreferrer">logsumexp</a> function from <code>scipy</code> combined with the broadcasted arrays:</p> <pre><code># Store here each 'i' element from the M summatory. sum_N = 0. # N summatory. for f_i in f_N: # M summatory. A, B = [], [] for g_j in g_M: # Obtain ijk element inside the M summatory A.append(sum( np.square((f_i[:, 0] - g_j[:, 0])) / (f_i[:, 1] + g_j[:, 1]))) B.append(np.prod(f_i[:, 1] + g_j[:, 1])) sum_N += logsumexp(-.5 * np.array(A), b=1. / np.sqrt(B)) # Final negative logarithmic likelihood lik = len(f_N) * np.log(len(g_M)) - sum(np.log(P_i[P_i != 0.])) - sum_N print(lik) </code></pre> <p>This resulted in a marginal improvement over just using broadcasting, but still slower than the original code.</p>

158049

GOOD_ANSWER

<p>Here is the problem I've been trying to tackle:</p> <blockquote> <p>Design a thread-safe image caching server that can keep in memory only the ten most recently used images.</p> </blockquote> <p>I chose to implement an <a href="https://en.wikipedia.org/wiki/Cache_replacement_policies#Least_Recently_Used_.28LRU.29" rel="nofollow noreferrer">LRU cache</a> to solve this as follows:</p> <pre><code>''' This module defines an LRUCache. Constraints: 1. May only hold upto ten items at a time. 2. Must be able to synchronise multiple requests. 3. Must be able to update its cache. ''' import random import threading class LRUCache(object): def __init__(self, cacheSize=10): # this variables maps image names to file locations self.Cache = {} # this variables maps image names to timestamp of last request # filed for them. Is volatile - requires local clock to never change, # or that there is a separate clock service that guarantees global # consistency. self.RequestTimestamps = {} self.CacheSize = cacheSize def insert(self, imageName, imageLocation): ''' Insert a new image into our cache. If inserting would exceed our cache size, then we shall make room for it by removing the least recently used. ''' with threading.Lock(): if len(self.Cache) == self.CacheSize: self.removeLeastRecentlyUsed() self.Cache[imageName] = imageLocation self.RequestTimestamps[imageName] = time.time() def get(self, imageName): ''' Retrieve an image from our cache, keeping note of the time we last retrieved it. ''' with threading.Lock(): if imageName in self.Cache: self.RequestTimestamps[imageName] = time.time() return self.Cache[imageName] else: raise KeyError("Not found!") def removeLeastRecentlyUsed(self): ''' Should only be called in a threadsafe context. ''' if self.RequestTimestamps: # scan through and find the least recently used key by finding # the lowest timestamp among all the keys. leastRecentlyUsedKey = min(self.RequestTimestamps, key=lambda imageName: self.RequestTimestaps[imageName]) # now that the least recently used key has been found, # remove it from the cache and from our list of request timestamps. self.Cache.pop(leastRecentlyUsedKey, None) self.RequestTimestamps.pop(leastRecentlyUsedKey, None) return # only called in the event requestTimestamps does not exist - randomly # pick a key to erase. randomChoice = random.choice(self.Cache.keys()) self.Cache.pop(randomChoice, None) </code></pre> <p>Questions:</p> <ol> <li><p>Is this <em>actually</em> threadsafe? </p> <p>I'm used to implementing locks on single resources, but not class methods - would multiple threads, one accessing <code>insert</code> and the other doing a <code>get</code> be forced to synchronised as well? </p> <p>Or is my strategy of creating different locks in each method only able to prevent concurrent individual <code>insert</code> requests? </p> <p>Ignore the GIL.</p></li> <li><p>What would be a good strategy to test this code? </p> <p>I have thought of the obvious strategy:</p> <p>a) Insert ten items, make nine requests, attempt to insert a tenth and check if the item that was removed was the tenth.</p> <p>but I am not sure if this is the only way or if there is a better way to implement it. </p></li> </ol>

160277

GOOD_ANSWER

<p>Now that <a href="https://codereview.stackexchange.com/q/160958/27623">I have generated training data</a>, I need to classify each example with a label to train a TensorFlow neural net (first <a href="https://github.com/tensorflow/models/blob/master/inception/inception/data/build_image_data.py" rel="noreferrer">building a suitable dataset</a>). To streamline the process, I wrote this little Python script to help me. Any suggestions for improvement?</p> <hr> <p><strong>classify.py:</strong></p> <pre><code># Builtin modules import glob import sys import os import shutil import wave import time import re from threading import Thread # 3rd party modules import scipy.io.wavfile import pyaudio DATA_DIR = 'raw_data' LABELED_DIR = 'labeled_data' answer = None def classify_files(): global answer # instantiate PyAudio p = pyaudio.PyAudio() for filename in glob.glob('{}/*.wav'.format(DATA_DIR)): # define stream chunk chunk = 1024 #open a wav format music wf = wave.open(filename, 'rb') #open stream stream = p.open(format=p.get_format_from_width(wf.getsampwidth()), channels=wf.getnchannels(), rate=wf.getframerate(), output=True) #read data data = wf.readframes(chunk) #play stream while answer is None: stream.write(data) data = wf.readframes(chunk) if data == b'': # if file is over then rewind wf.rewind() time.sleep(1) data = wf.readframes(chunk) # don't know how to classify, skip sample if answer == '.': answer = None continue # sort spectogram based on input spec_filename = 'spec{}.jpeg'.format(str(re.findall(r'\d+', filename)[0])) os.makedirs('{}/{}'.format(LABELED_DIR, answer), exist_ok=True) shutil.copyfile('{}/{}'.format(DATA_DIR, spec_filename), '{}/{}/{}'.format(LABELED_DIR, answer, spec_filename)) # reset answer field answer = None #stop stream stream.stop_stream() stream.close() #close PyAudio p.terminate() if __name__ == '__main__': try: # exclude file from glob os.remove('{}/ALL.wav'.format(DATA_DIR)) num_files = len(glob.glob('{}/*.wav'.format(DATA_DIR))) Thread(target = classify_files).start() for i in range(0, num_files): answer = input("Enter letter of sound heard: ") except KeyboardInterrupt: sys.exit() </code></pre>

161273

GOOD_ANSWER

<p>I made a program that solves KenKen Puzzles using graphics.py, and I was just wondering if my code was reasonably Pythonic.</p> <p>neknek.py</p> <pre><code>import options import copy from graphics import * from random import randint from itertools import product class Cell: def __init__(self, x, y): self.options = [1, 2, 3, 4, 5, 6] self.x = x self.y = y self.answer = 0 self.text = Text(Point(x * 100 + 50, y * 100 + 50), str(self.options)) self.text.setSize(10) self.marker = Circle(Point(self.x * 100 + 50, self.y * 100 + 80), 10) self.marker.setFill(color_rgb(255, 0, 0)) def update(self): if len(self.options) == 1 and self.answer == 0: self.answer = self.options[0] self.text.setText(str(self.answer)) self.marker.setFill(color_rgb(0, 255, 0)) elif self.answer &gt; 0: self.text.setText(str(self.answer)) self.marker.setFill(color_rgb(0, 255, 0)) elif self.answer == 0: self.text.setText(str(self.options)) def remove_options(self, options): if len(list(set(self.options) - set(options))) &gt; 0: self.options = list(set(self.options) - set(options)) class Group: def __init__(self, cells, goal): self.cells = cells self.goal = goal self.options = [] def happy(self): raise NotImplementedError def check_bend(self): x = [] y = [] for cell in self.cells: x.append(cell.x) y.append(cell.y) return not (self._bend_helper(x) or self._bend_helper(y)) def _all_options(self): temp = [] for cell in self.cells: if cell.answer &gt; 0: temp.append([cell.answer]) else: temp.append(cell.options) temp = list(product(*temp)) li = [] for x in temp: li.append(list(x)) return li def _bend_helper(self, li): for i in li: if li.count(i) == len(li): return True return False def _check_group_options(self, cell, i): for option in self.options: if i == option[self.cells.index(cell)]: return True return False def _remove_group_options(self): possible = self._all_options() remove = [] for option in self.options: if option not in possible: remove.append(option) for option in remove: self.options.remove(option) def _remove_cell_options(self): for cell in self.cells: remove = [] for option in cell.options: if not self._check_group_options(cell, option): remove.append(option) cell.remove_options(remove) def solve(self): self._remove_group_options() self._remove_cell_options() for cell in self.cells: cell.update() class AddGroup(Group): def __init__(self, cells, goal): super().__init__(cells, goal) if self.check_bend(): try: self.options = copy.deepcopy(options.add_options[len(self.cells)][goal + '*']) except KeyError: self.options = copy.deepcopy(options.add_options[len(self.cells)][goal]) else: self.options = copy.deepcopy(options.add_options[len(self.cells)][goal]) def happy(self): total = 0 for cell in self.cells: total += cell.answer return total == int(self.goal) class SubGroup(Group): def __init__(self, cells, goal): super().__init__(cells, goal) if self.check_bend(): try: self.options = copy.deepcopy(options.sub_options[len(self.cells)][goal + '*']) except KeyError: self.options = copy.deepcopy(options.sub_options[len(self.cells)][goal]) else: self.options = copy.deepcopy(options.sub_options[len(self.cells)][goal]) def happy(self): return max(self.cells[0].answer, self.cells[1].answer) - min(self.cells[0].answer, self.cells[1].answer) == int(self.goal) class MulGroup(Group): def __init__(self, cells, goal): super().__init__(cells, goal) if self.check_bend(): try: self.options = copy.deepcopy(options.mul_options[len(self.cells)][goal + '*']) except KeyError: self.options = copy.deepcopy(options.mul_options[len(self.cells)][goal]) else: self.options = copy.deepcopy(options.mul_options[len(self.cells)][goal]) def happy(self): total = 1 for cell in self.cells: total *= cell.answer return total == int(self.goal) class DivGroup(Group): def __init__(self, cells, goal): super().__init__(cells, goal) if self.check_bend(): try: self.options = copy.deepcopy(options.div_options[len(self.cells)][goal + '*']) except KeyError: self.options = copy.deepcopy(options.div_options[len(self.cells)][goal]) else: self.options = copy.deepcopy(options.div_options[len(self.cells)][goal]) def happy(self): return max(self.cells[0].answer, self.cells[1].answer) / min(self.cells[0].answer, self.cells[1].answer) == int(self.goal) class RowColGroup(Group): def __init__(self, cells): super().__init__(cells, '21') self.options = options.row_col_options def happy(self): total = 0 for cell in self.cells: total += cell.answer return total == int(self.goal) def _remove_used_answers(self): remove = [] for cell in self.cells: if cell.answer != 0: remove.append(cell.answer) for cell in self.cells: cell.remove_options(remove) def _remove_used_options(self): remove = [] used_options = [] for cell in self.cells: if len(cell.options) == used_options.count(cell.options) + 1: for i in cell.options: remove.append(i) else: used_options.append(cell.options) for cell in self.cells: cell.remove_options(remove) def _count_options(self): options = [0, 0, 0, 0, 0, 0, 0] for cell in self.cells: for option in cell.options: options[option] += 1 for i in range(1, 7): if options[i] == 1: for cell in self.cells: if i in cell.options and cell.answer != i: cell.options = [i] def solve(self): self._remove_used_answers() self._remove_used_options() self._count_options() for cell in self.cells: cell.update() class Puzzle: def __init__(self, cells, groups, rows, cols, win): self.width = 100 * 6 self.height = 100 * 6 self.cells = cells self.win = win self.prompt = Text(Point((self.width + 150) / 3, self.height + 25), '') self.prompt.setSize(10) self.prompt.draw(self.win) self.input = Entry(Point(2 * (self.width + 150) / 3, self.height + 25), 5) self.input.setSize(10) self.input.draw(self.win) self.groups = groups self.rows = rows self.cols = cols @classmethod def from_gui(cls): width = 100 * 6 height = 100 * 6 cells = {} win = GraphWin('KenKen', width + 200, height + 50) prompt = Text(Point((width + 150) / 3, height + 25), 'How many groups are there?') prompt.setSize(10) prompt.draw(win) input = Entry(Point(2 * (width + 150) / 3, height + 25), 5) input.setSize(10) input.draw(win) groups = [] rows = [] cols = [] r = Rectangle(Point(width + 10, 20), Point(width + 190, 50)) r.setFill(color_rgb(255, 0, 0)) r.draw(win) t = Text(Point(width + 100, 35), 'Remove') t.setSize(10) t.draw(win) r = Rectangle(Point(width + 10, 60), Point(width + 190, 90)) r.setFill(color_rgb(0, 255, 0)) r.draw(win) t = Text(Point(width + 100, 75), 'Enter') t.setSize(10) t.draw(win) for i in range(6): l = Line(Point((i + 1) * 100, 0), Point((i + 1) * 100, height)) l.setWidth(4) l.draw(win) l = Line(Point(0, (i + 1) * 100), Point(width, (i + 1) * 100)) l.setWidth(4) l.draw(win) for y in range(6): for x in range(6): c = Cell(x, y) cells[x, y] = c c.text.draw(win) win.getMouse() group_num = int(input.getText()) input.setText('') for i in range(group_num): g = randint(0, 255) r = randint(g, 255) b = randint(g, 255) color = color_rgb(r, g, b) prompt.setText("Enter the goal and operator for group {}, then select the cells.".format(i)) group_cells = [] while True: p = win.getMouse() inp = input.getText().split() op = inp[1] goal = inp[0] x, y = p.getX(), p.getY() if y &gt; height or x &gt; width: if op == '+': g = AddGroup(group_cells, goal) elif op == '-': g = SubGroup(group_cells, goal) elif op == '*': g = MulGroup(group_cells, goal) else: g = DivGroup(group_cells, goal) groups.append(g) g.solve() input.setText('') break else: if cells[x // 100, y // 100] in cells: group_cells.remove(cells[x // 100, y // 100]) cells[x // 100, y // 100].marker.undraw() else: group_cells.append(cells[x // 100, y // 100]) cells[x // 100, y // 100].marker.setFill(color) cells[x // 100, y // 100].marker.draw(win) for y in range(6): group_cells = [] for x in range(6): group_cells.append(cells[x, y]) rows.append(RowColGroup(group_cells)) for x in range(6): group_cells = [] for y in range(6): group_cells.append(cells[x, y]) cols.append(RowColGroup(group_cells)) prompt.setText('') input.setText('') puzzle = cls(cells, groups, rows, cols, win) return puzzle def copy(self): win = GraphWin('KenKen', 100 * 6, 100 * 6 + 50) for i in range(6): l = Line(Point((i + 1) * 100, 0), Point((i + 1) * 100, 600)) l.setWidth(4) l.draw(win) l = Line(Point(0, (i + 1) * 100), Point(600, (i + 1) * 100)) l.setWidth(4) l.draw(win) cells = {} for y in range(6): for x in range(6): c = Cell(x, y) c.options = copy.deepcopy(self.cells[x, y].options) c.answer = self.cells[x, y].answer c.marker.draw(win) c.text.draw(win) if c.answer &gt; 0: c.update() cells[x, y] = c groups = [] for group in self.groups: c = [] for cell in group.cells: c.append(cells[cell.x, cell.y]) if type(group) is AddGroup: g = AddGroup(c, group.goal) elif type(group) is SubGroup: g = SubGroup(c, group.goal) elif type(group) is MulGroup: g = MulGroup(c, group.goal) else: g = DivGroup(c, group.goal) g.options = copy.deepcopy(group.options) groups.append(g) rows = [] for row in self.rows: c = [] for cell in row.cells: c.append(cells[cell.x, cell.y]) r = RowColGroup(c) r.options = copy.deepcopy(row.options) rows.append(r) cols = [] for col in self.cols: c = [] for cell in col.cells: c.append(cells[cell.x, cell.y]) c = RowColGroup(c) c.options = copy.deepcopy(col.options) cols.append(c) return Puzzle(cells, groups, rows, cols, win) def solve(self): tries = 0 while self.total() &lt; 36 and tries &lt; 60: tries += 1 for row in self.rows: row.solve() self.prompt.setText('Solving Rows... Continue.') for col in self.cols: col.solve() self.prompt.setText('Solving Columns... Continue.') for group in self.groups: group.solve() self.prompt.setText('Solving Groups... Continue.') if self.total() &lt; 36: for row in self.rows: for cell in row.cells: if cell.answer == 0: for option in cell.options: result = self.try_solve(cell, option) if result is not None: self.win.close() return result elif self.happy(): return self self.win.close() return None def try_solve(self, cell, option): c = self.copy() c.cells[cell.x, cell.y].answer = option c.cells[cell.x, cell.y].options = [option] result = c.solve() return result # cell.answer = option # return self.solve() def happy(self): all_groups = self.rows + self.cols + self.groups for group in all_groups: if not group.happy(): return False return True def total(self): total = 0 for y in range(6): for x in range(6): if self.cells[x, y].answer &gt; 0: total += 1 return total def get_input(self): p = self.win.getMouse() x, y = p.getX(), p.getY() if x &gt;= self.width: if 20 &lt; y &lt; 50: self.remove_options(self.win.getMouse(), int(self.prompt.getText())) else: self.solve() def remove_options(self, p, i): pass if __name__ == '__main__': p = Puzzle.from_gui() p = p.solve() p.win.getMouse() </code></pre> <p>options.py is just every possible combination for different groups.</p>

163898

GOOD_ANSWER

<p>I have been working on a 2-player battleship game and have finally got it working, bug free.</p> <p>I'm posting this here to ask you what you think of it. Are there any changes that could be made to improve the performance/general layout of the code?</p> <p>If you come across any issues with the code itself, (maybe a bug yet to be found) then I'd be grateful if you could let me know.</p> <p>The game is a fairly simple console-based battleship game, where the players take it in turns to sink a mutual ship that is defined by an x and y coordinate on a 5x5 game board.</p> <pre><code>from random import randint game_board = [] player_one = { "name": "Player 1", "wins": 0, } player_two = { "name": "Player 2", "wins": 0, } colors = { "reset":"\033[00m", "red":"\033[91m", "blue":"\033[94m", "cyan":"\033[96m", } # Building our 5 x 5 board def build_game_board(board): for item in range(5): board.append(["O"] * 5) def show_board(board): for row in board: print(" ".join(row)) # Defining ships locations def load_game(board): print("WELCOME TO BATTLESHIP!") print("Find and sink the ship!") del board[:] build_game_board(board) print(colors['blue']) show_board(board) print(colors['reset']) ship_col = randint(1, len(board)) ship_row = randint(1, len(board[0])) return { 'ship_col': ship_col, 'ship_row': ship_row, } ship_points = load_game(game_board) # Players will alternate turns. def player_turns(total_turns): if total_turns % 2 == 0: total_turns += 1 return player_one return player_two # Allows new game to start def play_again(): positive = ["yes", "y"] negative = ["no", "n"] global ship_points while True: answer = input("Play again? [Y(es) / N(o)]: ").lower().strip() if answer in positive: ship_points = load_game(game_board) main() break elif answer in negative: print("Thanks for playing!") exit() # What will be done with players guesses def input_check(ship_row, ship_col, player, board): guess_col = 0 guess_row = 0 while True: try: guess_row = int(input("Guess Row:")) - 1 guess_col = int(input("Guess Col:")) - 1 except ValueError: print("Enter a number only: ") continue else: break match = guess_row == ship_row - 1 and guess_col == ship_col - 1 not_on_game_board = (guess_row &lt; 0 or guess_row &gt; 4) or (guess_col &lt; 0 or guess_col &gt; 4) if match: player["wins"] += 1 print("Congratulations! You sunk my battleship!") print('The current match score is %d : %d (Player1 : Player2)' % (player_one["wins"], player_two["wins"])) print("Thanks for playing!") play_again() elif not match: if not_on_game_board: print("Oops, that's not even in the ocean.") elif board[guess_row][guess_col] == "X" or board[guess_row][guess_col] == "Y": print("You guessed that one already.") else: print("You missed my battleship!") if player == player_one: board[guess_row][guess_col] = "X" else: board[guess_row][guess_col] = "Y" print(colors['cyan']) show_board(game_board) print(colors['reset']) else: return 0 begin = input("Type 'start' to begin: ") while (begin != str('start')): begin = input("Type 'start' to begin: ") def main(): for turns in range(6): if player_turns(turns) == player_one: print(ship_points) print("Player One") input_check( ship_points['ship_row'], ship_points['ship_col'], player_one, game_board ) elif player_turns(turns) == player_two: print("Player Two") input_check( ship_points['ship_row'], ship_points['ship_col'], player_two, game_board ) if turns == 5: print("This game is a draw.") print(colors['red']) show_board(game_board) print(colors['reset']) print('The current match score is %d : %d (Player1 : Player2)' % (player_one["wins"], player_two["wins"])) play_again() if __name__ == "__main__": main() </code></pre>

164709

GOOD_ANSWER

<p>I wrote a country name generator in Python 3.5. My goal was to get randomized names that would look as much like real-world names as possible. Each name needed to have a noun and an adjective form (e.g., <code>Italy</code> and <code>Italian</code>).</p> <p>I started with a list of real countries, regions, and cities, which I stored in a text file. The names are broken up by syllables, with the noun and adjective endings separated (e.g., <code>i-ta-l y/ian</code>). The program splits each name into syllables, and each syllable into three <em>segments</em>: <a href="https://en.wikipedia.org/wiki/Syllable#Typical_model" rel="noreferrer">onset, nucleus, and coda</a> (i.e., the leading consonants, the vowels, and the trailing consonants). It then uses the frequency of these segments in relation to each other to drive a <a href="https://en.wikipedia.org/wiki/Markov_chain" rel="noreferrer">Markov process</a> that generates a name. (It's not a pure Markov process because I wanted to ensure a distribution of syllable counts similar to the input set. I also special-cased the endings.) Several types of undesirable names are rejected.</p> <h3>Main code</h3> <pre><code>#!/usr/bin/python3 import re, random # A regex that matches a syllable, with three groups for the three # segments of the syllable: onset (initial consonants), nucleus (vowels), # and coda (final consonants). # The regex also matches if there is just an onset (even an empty # onset); this case corresponds to the final partial syllable of the # stem, which is usually the consonant before a vowel ending (for # example, the d in "ca-na-d a"). syllableRgx = re.compile(r"(y|[^aeiouy]*)([aeiouy]+|$)([^aeiouy]*)") nameFile = "names.txt" # Dictionary that holds the frequency of each syllable count (note that these # are the syllables *before* the ending, so "al-ba-n ia" only counts two) syllableCounts = {} # List of four dictionaries (for onsets, nuclei, codas, and endings): # Each dictionary's key/value pairs are prevSegment:segmentDict, where # segmentDict is a frequency dictionary of various onsets, nuclei, codas, # or endings, and prevSegment is a segment that can be the last nonempty # segment preceding them. A prevSegment of None marks segments at the # beginnings of names. segmentData = [{}, {}, {}, {}] ONSET = 0 NUCLEUS = 1 CODA = 2 ENDING = 3 # Read names from file and generate the segmentData structure with open(nameFile) as f: for line in f.readlines(): # Strip whitespace, ignore blank lines and comments line = line.strip() if not line: continue if line[0] == "#": continue stem, ending = line.split() # Endings should be of the format noun/adj if "/" not in ending: # The noun ending is given; the adjective ending can be # derived by appending -n ending = "{}/{}n".format(ending, ending) # Syllable count is the number of hyphens syllableCount = stem.count("-") if syllableCount in syllableCounts: syllableCounts[syllableCount] += 1 else: syllableCounts[syllableCount] = 1 # Add the segments in this name to segmentData prevSegment = None for syllable in stem.split("-"): segments = syllableRgx.match(syllable).groups() if segments[NUCLEUS] == segments[CODA] == "": # A syllable with emtpy nucleus and coda comes right before # the ending, so we only process the onset segments = (segments[ONSET],) for segType, segment in enumerate(segments): if prevSegment not in segmentData[segType]: segmentData[segType][prevSegment] = {} segFrequencies = segmentData[segType][prevSegment] if segment in segFrequencies: segFrequencies[segment] += 1 else: segFrequencies[segment] = 1 if segment: prevSegment = segment # Add the ending to segmentData if prevSegment not in segmentData[ENDING]: segmentData[ENDING][prevSegment] = {} endFrequencies = segmentData[ENDING][prevSegment] if ending in endFrequencies: endFrequencies[ending] += 1 else: endFrequencies[ending] = 1 def randFromFrequencies(dictionary): "Returns a random dictionary key, where the values represent frequencies." keys = dictionary.keys() frequencies = dictionary.values() index = random.randrange(sum(dictionary.values())) for key, freq in dictionary.items(): if index &lt; freq: # Select this one return key else: index -= freq # Weird, should have returned something raise ValueError("randFromFrequencies didn't pick a value " "(index remainder is {})".format(index)) def markovName(syllableCount): "Generate a country name using a Markov-chain-like process." prevSegment = None stem = "" for syll in range(syllableCount): for segType in [ONSET, NUCLEUS, CODA]: try: segFrequencies = segmentData[segType][prevSegment] except KeyError: # In the unusual situation that the chain fails to find an # appropriate next segment, it's too complicated to try to # roll back and pick a better prevSegment; so instead, # return None and let the caller generate a new name return None segment = randFromFrequencies(segFrequencies) stem += segment if segment: prevSegment = segment endingOnset = None # Try different onsets for the last syllable till we find one that's # legal before an ending; we also allow empty onsets. Because it's # possible we won't find one, we also limit the number of retries # allowed. retries = 10 while (retries and endingOnset != "" and endingOnset not in segmentData[ENDING]): segFrequencies = segmentData[ONSET][prevSegment] endingOnset = randFromFrequencies(segFrequencies) retries -= 1 stem += endingOnset if endingOnset != "": prevSegment = endingOnset if prevSegment in segmentData[ENDING]: # Pick an ending that goes with the prevSegment endFrequencies = segmentData[ENDING][prevSegment] endings = randFromFrequencies(endFrequencies) else: # It can happen, if we used an empty last-syllable onset, that # the previous segment does not appear before any ending in the # data set. In this case, we'll just use -a(n) for the ending. endings = "a/an" endings = endings.split("/") nounForm = stem + endings[0] # Filter out names that are too short or too long if len(nounForm) &lt; 3: # This would give two-letter names like Mo, which don't appeal # to me return None if len(nounForm) &gt; 11: # This would give very long names like Imbadossorbia that are too # much of a mouthful return None # Filter out names with weird consonant clusters at the end for consonants in ["bl", "tn", "sr", "sn", "sm", "shm"]: if nounForm.endswith(consonants): return None # Filter out names that sound like anatomical references for bannedSubstring in ["vag", "coc", "cok", "kok", "peni"]: if bannedSubstring in stem: return None if nounForm == "ass": # This isn't a problem if it's part of a larger name like Assyria, # so filter it out only if it's the entire name return None return stem, endings </code></pre> <h3>Testing code</h3> <pre><code>def printCountryNames(count): for i in range(count): syllableCount = randFromFrequencies(syllableCounts) nameInfo = markovName(syllableCount) while nameInfo is None: nameInfo = markovName(syllableCount) stem, endings = nameInfo stem = stem.capitalize() noun = stem + endings[0] adjective = stem + endings[1] print("{} ({})".format(noun, adjective)) if __name__ == "__main__": printCountryNames(10) </code></pre> <h3>Example <code>names.txt</code> contents</h3> <pre><code># Comments are ignored i-ta-l y/ian # A suffix can be empty i-ra-q /i # The stem can end with a syllable break ge-no- a/ese # Names whose adjective suffix just adds an -n need only list the noun suffix ar-me-n ia sa-mo- a </code></pre> <p>My full <code>names.txt</code> file can be found, along with the code, in <a href="https://gist.github.com/dloscutoff/d4d79df2ab71411d99d6d646e8f45ee6" rel="noreferrer">this Gist</a>.</p> <h3>Example output</h3> <p>Generated using the full data file:</p> <pre class="lang-none prettyprint-override"><code>Slorujarnia (Slorujarnian) Ashmar (Ashmari) Babya (Babyan) Randorkia (Randorkian) Esanoa (Esanoese) Manglalia (Manglalic) Konara (Konaran) Lilvispia (Lilvispian) Cenia (Cenian) Rafri (Rafrian) </code></pre> <h2>Questions</h2> <ul> <li>Is my code readable? Clear variable and function names? Sufficient comments?</li> <li>Should I restructure anything?</li> <li>Are there any Python 3 features I could use or use better? I'm particularly unused to <code>format</code> and the various approaches for using it.</li> </ul> <p>If you see anything else that can be improved, please let me know. Just one exception: I know the PEP standard is snake_case, but <strong>I want to use camelCase</strong> and I don't intend to change that. Other formatting tips are welcome.</p>

172929

GOOD_ANSWER

<p>I wrote a country name generator in Python 3.5. My goal was to get randomized names that would look as much like real-world names as possible. Each name needed to have a noun and an adjective form (e.g., <code>Italy</code> and <code>Italian</code>).</p> <p>I started with a list of real countries, regions, and cities, which I stored in a text file. The names are broken up by syllables, with the noun and adjective endings separated (e.g., <code>i-ta-l y/ian</code>). The program splits each name into syllables, and each syllable into three <em>segments</em>: <a href="https://en.wikipedia.org/wiki/Syllable#Typical_model" rel="noreferrer">onset, nucleus, and coda</a> (i.e., the leading consonants, the vowels, and the trailing consonants). It then uses the frequency of these segments in relation to each other to drive a <a href="https://en.wikipedia.org/wiki/Markov_chain" rel="noreferrer">Markov process</a> that generates a name. (It's not a pure Markov process because I wanted to ensure a distribution of syllable counts similar to the input set. I also special-cased the endings.) Several types of undesirable names are rejected.</p> <h3>Main code</h3> <pre><code>#!/usr/bin/python3 import re, random # A regex that matches a syllable, with three groups for the three # segments of the syllable: onset (initial consonants), nucleus (vowels), # and coda (final consonants). # The regex also matches if there is just an onset (even an empty # onset); this case corresponds to the final partial syllable of the # stem, which is usually the consonant before a vowel ending (for # example, the d in "ca-na-d a"). syllableRgx = re.compile(r"(y|[^aeiouy]*)([aeiouy]+|$)([^aeiouy]*)") nameFile = "names.txt" # Dictionary that holds the frequency of each syllable count (note that these # are the syllables *before* the ending, so "al-ba-n ia" only counts two) syllableCounts = {} # List of four dictionaries (for onsets, nuclei, codas, and endings): # Each dictionary's key/value pairs are prevSegment:segmentDict, where # segmentDict is a frequency dictionary of various onsets, nuclei, codas, # or endings, and prevSegment is a segment that can be the last nonempty # segment preceding them. A prevSegment of None marks segments at the # beginnings of names. segmentData = [{}, {}, {}, {}] ONSET = 0 NUCLEUS = 1 CODA = 2 ENDING = 3 # Read names from file and generate the segmentData structure with open(nameFile) as f: for line in f.readlines(): # Strip whitespace, ignore blank lines and comments line = line.strip() if not line: continue if line[0] == "#": continue stem, ending = line.split() # Endings should be of the format noun/adj if "/" not in ending: # The noun ending is given; the adjective ending can be # derived by appending -n ending = "{}/{}n".format(ending, ending) # Syllable count is the number of hyphens syllableCount = stem.count("-") if syllableCount in syllableCounts: syllableCounts[syllableCount] += 1 else: syllableCounts[syllableCount] = 1 # Add the segments in this name to segmentData prevSegment = None for syllable in stem.split("-"): segments = syllableRgx.match(syllable).groups() if segments[NUCLEUS] == segments[CODA] == "": # A syllable with emtpy nucleus and coda comes right before # the ending, so we only process the onset segments = (segments[ONSET],) for segType, segment in enumerate(segments): if prevSegment not in segmentData[segType]: segmentData[segType][prevSegment] = {} segFrequencies = segmentData[segType][prevSegment] if segment in segFrequencies: segFrequencies[segment] += 1 else: segFrequencies[segment] = 1 if segment: prevSegment = segment # Add the ending to segmentData if prevSegment not in segmentData[ENDING]: segmentData[ENDING][prevSegment] = {} endFrequencies = segmentData[ENDING][prevSegment] if ending in endFrequencies: endFrequencies[ending] += 1 else: endFrequencies[ending] = 1 def randFromFrequencies(dictionary): "Returns a random dictionary key, where the values represent frequencies." keys = dictionary.keys() frequencies = dictionary.values() index = random.randrange(sum(dictionary.values())) for key, freq in dictionary.items(): if index &lt; freq: # Select this one return key else: index -= freq # Weird, should have returned something raise ValueError("randFromFrequencies didn't pick a value " "(index remainder is {})".format(index)) def markovName(syllableCount): "Generate a country name using a Markov-chain-like process." prevSegment = None stem = "" for syll in range(syllableCount): for segType in [ONSET, NUCLEUS, CODA]: try: segFrequencies = segmentData[segType][prevSegment] except KeyError: # In the unusual situation that the chain fails to find an # appropriate next segment, it's too complicated to try to # roll back and pick a better prevSegment; so instead, # return None and let the caller generate a new name return None segment = randFromFrequencies(segFrequencies) stem += segment if segment: prevSegment = segment endingOnset = None # Try different onsets for the last syllable till we find one that's # legal before an ending; we also allow empty onsets. Because it's # possible we won't find one, we also limit the number of retries # allowed. retries = 10 while (retries and endingOnset != "" and endingOnset not in segmentData[ENDING]): segFrequencies = segmentData[ONSET][prevSegment] endingOnset = randFromFrequencies(segFrequencies) retries -= 1 stem += endingOnset if endingOnset != "": prevSegment = endingOnset if prevSegment in segmentData[ENDING]: # Pick an ending that goes with the prevSegment endFrequencies = segmentData[ENDING][prevSegment] endings = randFromFrequencies(endFrequencies) else: # It can happen, if we used an empty last-syllable onset, that # the previous segment does not appear before any ending in the # data set. In this case, we'll just use -a(n) for the ending. endings = "a/an" endings = endings.split("/") nounForm = stem + endings[0] # Filter out names that are too short or too long if len(nounForm) &lt; 3: # This would give two-letter names like Mo, which don't appeal # to me return None if len(nounForm) &gt; 11: # This would give very long names like Imbadossorbia that are too # much of a mouthful return None # Filter out names with weird consonant clusters at the end for consonants in ["bl", "tn", "sr", "sn", "sm", "shm"]: if nounForm.endswith(consonants): return None # Filter out names that sound like anatomical references for bannedSubstring in ["vag", "coc", "cok", "kok", "peni"]: if bannedSubstring in stem: return None if nounForm == "ass": # This isn't a problem if it's part of a larger name like Assyria, # so filter it out only if it's the entire name return None return stem, endings </code></pre> <h3>Testing code</h3> <pre><code>def printCountryNames(count): for i in range(count): syllableCount = randFromFrequencies(syllableCounts) nameInfo = markovName(syllableCount) while nameInfo is None: nameInfo = markovName(syllableCount) stem, endings = nameInfo stem = stem.capitalize() noun = stem + endings[0] adjective = stem + endings[1] print("{} ({})".format(noun, adjective)) if __name__ == "__main__": printCountryNames(10) </code></pre> <h3>Example <code>names.txt</code> contents</h3> <pre><code># Comments are ignored i-ta-l y/ian # A suffix can be empty i-ra-q /i # The stem can end with a syllable break ge-no- a/ese # Names whose adjective suffix just adds an -n need only list the noun suffix ar-me-n ia sa-mo- a </code></pre> <p>My full <code>names.txt</code> file can be found, along with the code, in <a href="https://gist.github.com/dloscutoff/d4d79df2ab71411d99d6d646e8f45ee6" rel="noreferrer">this Gist</a>.</p> <h3>Example output</h3> <p>Generated using the full data file:</p> <pre class="lang-none prettyprint-override"><code>Slorujarnia (Slorujarnian) Ashmar (Ashmari) Babya (Babyan) Randorkia (Randorkian) Esanoa (Esanoese) Manglalia (Manglalic) Konara (Konaran) Lilvispia (Lilvispian) Cenia (Cenian) Rafri (Rafrian) </code></pre> <h2>Questions</h2> <ul> <li>Is my code readable? Clear variable and function names? Sufficient comments?</li> <li>Should I restructure anything?</li> <li>Are there any Python 3 features I could use or use better? I'm particularly unused to <code>format</code> and the various approaches for using it.</li> </ul> <p>If you see anything else that can be improved, please let me know. Just one exception: I know the PEP standard is snake_case, but <strong>I want to use camelCase</strong> and I don't intend to change that. Other formatting tips are welcome.</p>

172929

GOOD_ANSWER

<p>I'd like some feedback on the readability, style, and potential problems or issues. In particular I'm not too happy with how I handle ratelimits.</p> <pre><code>import json import requests import pandas as pd import matplotlib.pyplot as plt from dateutil.relativedelta import relativedelta from datetime import date from flatten_json import flatten from tqdm import tnrange as trange from time import sleep class CrimsonHexagonClient(object): """Interacts with the Crimson Hexagon API to retrieve post data (twitter ids etc.) from a configured monitor. Docs: https://apidocs.crimsonhexagon.com/v1.0/reference Args: username (str): Username on website. password (str): Password on website. monitor_id (str): id of crimson monitor. """ def __init__(self, username, password, monitor_id): self.username = username self.password = password self.monitor_id = monitor_id self.base = 'https://api.crimsonhexagon.com/api/monitor' self.session = requests.Session() self.ratelimit_refresh = 60 self._auth() def _auth(self): """Authenticates a user using their username and password through the authenticate endpoint. """ url = 'https://forsight.crimsonhexagon.com/api/authenticate?' payload = { 'username': self.username, 'password': self.password } r = self.session.get(url, params=payload) j_result = r.json() self.auth_token = j_result["auth"] print('-- Authenticated --') return def make_endpoint(self, endpoint): return '{}/{}?'.format(self.base, endpoint) def get_data_from_endpoint(self, from_, to_, endpoint): """Hits the designated endpoint (volume/posts) for a specified time period. The ratelimit is burned through ASAP and then backed off for one minute. """ endpoint = self.make_endpoint(endpoint) from_, to_ = str(from_), str(to_) payload = { 'auth': self.auth_token, 'id': self.monitor_id, 'start': from_, 'end': to_, 'extendLimit': 'true', 'fullContents': 'true' } r = self.session.get(endpoint, params=payload) self.last_response = r ratelimit_remaining = r.headers['X-RateLimit-Remaining'] # If the header is empty or 0 then wait for a ratelimit refresh. if (not ratelimit_remaining) or (float(ratelimit_remaining) &lt; 1): print('Waiting for ratelimit refresh...') sleep(self.ratelimit_refresh) return r def get_dates_from_timespan(self, r_volume, max_documents=10000): """Divides the time period into chunks of less than 10k where possible. """ # If the count is less than max, just return the original time span. if r_volume.json()['numberOfDocuments'] &lt;= max_documents: l_dates = [[pd.to_datetime(r_volume.json()['startDate']).date(), pd.to_datetime(r_volume.json()['endDate']).date()]] return l_dates # Convert json to df for easier subsetting &amp; to calculate cumulative sum. df = pd.DataFrame(r_volume.json()['volume']) df['startDate'] = pd.to_datetime(df['startDate']) df['endDate'] = pd.to_datetime(df['endDate']) l_dates = [] while True: df['cumulative_sum'] = df['numberOfDocuments'].cumsum() # Find the span whose cumulative sum is below the threshold. df_below = df[df['cumulative_sum'] &lt;= max_documents] # If there are 0 rows under threshold. if (df_below.empty): # If there are still rows left, use the first row. if len(df) &gt; 0: # This entry will have over 10k, but we can't go more # granular than one day. df_below = df.iloc[0:1] else: break # Take the first row's start date and last row's end date. from_ = df_below['startDate'].iloc[0].date() to_ = df_below['endDate'].iloc[-1].date() l_dates.append([from_, to_]) # Reassign df to remaining portion. df = df[df['startDate'] &gt;= to_] return l_dates def plot_volume(self, r_volume): """Plots a time-series chart with two axes to show the daily and cumulative document count. """ # Convert r to df, fix datetime, add cumulative sum. df_volume = pd.DataFrame(r_volume.json()['volume']) df_volume['startDate'] = pd.to_datetime(df_volume['startDate']) df_volume['endDate'] = pd.to_datetime(df_volume['endDate']) df_volume['cumulative_sum'] = df_volume['numberOfDocuments'].cumsum() fig, ax1 = plt.subplots() ax2 = ax1.twinx() df_volume['numberOfDocuments'].plot(ax=ax1, style='b-') df_volume['cumulative_sum'].plot(ax=ax2, style='r-') ax1.set_ylabel('Number of Documents') ax2.set_ylabel('Cumulative Sum') h1, l1 = ax1.get_legend_handles_labels() h2, l2 = ax2.get_legend_handles_labels() ax1.legend(h1+h2, l1+l2, loc=2) plt.show() return def make_data_pipeline(self, from_, to_): """Combines the functionsin this class to make a robust pipeline, that loops through each day in a time period. Data is returned as a dataframe. """ # Get the volume over time data. r_volume = self.get_data_from_endpoint(from_, to_, 'volume') print('There are approximately {} documents.'.format(r_volume.json()['numberOfDocuments'])) self.plot_volume(r_volume) # Carve up time into buckets of volume &lt;10k. l_dates = self.get_dates_from_timespan(r_volume) data = [] for i in trange(len(l_dates), leave=False): from_, to_ = l_dates[i] # Pull posts. r_posts = self.get_data_from_endpoint(from_, to_, 'posts') if r_posts.ok and (r_posts.json()['status'] != 'error'): j_result = json.loads(r_posts.content.decode('utf8')) data.extend(j_result['posts']) l_flat= [flatten(d) for d in data] df = pd.DataFrame(l_flat) return df if __name__ == "__main__": # Credentials. username = 'xxxxx' password = 'xxxxx' # Monitor id - taken from URL on website. monitor_id = '123' # Instantiate client. crimson_api = CrimsonHexagonClient(username, password, monitor_id) from_ = date(2017, 1, 1) to_ = date(2017, 6, 30) # Combine class functions into a typical workflow. df = crimson_api.make_data_pipeline(from_, to_) </code></pre>

173049

GOOD_ANSWER

<p>I have a project and I am trying to do a complex cryptographic method. Is it normal to use nested loops a lot? Or Did I miss something?</p> <p>I intend to create a method which tries all strings to find password. For example, It should create each of these one by one: ('A','A') ('B', 'A') ('A', 'B') ('B', 'B') ('A', 'AA' ) ('A', 'AB') ('B', 'AA') ('B', 'AB') ('A', 'BA') ('B', 'BA') ('A', 'BB') ('B', 'BB') , (triple permutations), (quadruple permutations).. and it goes...</p> <pre><code>def rulefinder(): global externalrul1 global externalrul2 rul2 = uniquestring1[0] rul1 = uniquestring1[0] for n in range (0,3): for m in range (0, len(uniquestring1)): for z in range(0, n+1): for k in range (0,3): for i in range(0, len(uniquestring1)): for o in range(0, k+1): for y in range (0, len(uniquestring1)): rul2 = rul2[:-1] + uniquestring1[y] for x in range (0, len(uniquestring1)): rul1= rul1[:-1] + uniquestring1[x] code="" for cha in Genx1: if cha==uniquestring1[0]: code +=codereplacer(rul1) elif cha==uniquestring1[1]: code +=codereplacer(rul2) print(code) print(uniquestring1[0],rul1) print(uniquestring1[1],rul2) print(LastString) if code == LastString: axiom1=uniquestring1[0] axiom2=uniquestring1[1] externalrul1=rul1 externalrul2=rul2 print('rules are found') print("First RULE:", uniquestring1[0], rul1) print("Second RULE:", uniquestring1[1], rul2) findsubgeneration(code, axiom1, rul1, axiom2, rul2) return rul1 = rul1[:o] + uniquestring1[i] + rul1[(o + 1):] rul1 += codereplacer(uniquestring1[i]) rul2 = rul2[:z] + uniquestring1[m] + rul2[(z + 1):] rul1 ="" rul2 += codereplacer(uniquestring1[m]) </code></pre>

183763

GOOD_ANSWER

<p>I'm using some old <a href="http://usaco.org/index.php" rel="nofollow noreferrer">USA Computing Olympiad</a> (USACO) problems to help teach me programming. This is the second one I've posted, I hope that's okay -- let me know if this is considered abusing the system. </p> <p>You can find my first post <a href="https://codereview.stackexchange.com/questions/195463/milking-order-compatible-with-maximum-number-of-observations">here</a>. As noted there, I'm essentially a beginner at programming in general, so any suggestions you have to improve any aspect of the code will be helpful. I tried to implement the suggestions of Gareth and Peter from the last thread as I worked on this problem. </p> <p>This is the <a href="http://usaco.org/index.php?page=viewproblem2&amp;cpid=839" rel="nofollow noreferrer">"Talent Show" problem</a>:</p> <blockquote> <p>Farmer John is bringing his \$N\$ cows, conveniently numbered \$1,\ldots, N\$, to the county fair, to compete in the annual bovine talent show! His \$i\$th cow has a weight \$w_i\$ and talent level \$t_i,\$ both integers. Upon arrival, Farmer John is quite surprised by the new rules for this year's talent show: </p> <ol> <li>A group of cows of total weight at least \$W\$ must be entered into the show(in order to ensure strong teams of cows are competing, not just strong individuals), and </li> <li>The group with the largest ratio of total talent to total weight shall win. </li> </ol> <p>FJ observes that all of his cows together have weight at least \$W,\$ so he should be able to enter a team satisfying (1). Help him determine the optimal ratio of talent to weight he can achieve for any such team. </p> <h3>Input Format</h3> <p>The first line of input contains \$N\$ (\$1 \le N \le 250 \$) and \$W\$ (\$1 \le W \le 1000\$). The next \$N\$ lines describe a cow with two integers \$w_i\$ and \$t_i.\$</p> <h3>Output Format</h3> <p>Output \$\lfloor 1000A\rfloor\$ where \$A\$ is the largest possible talent ratio Farmer John can achieve with cows having weight at least \$W.\$</p> <h3>Sample input</h3> <pre><code>3 15 20 21 10 11 30 31 </code></pre> <h3>Sample Output</h3> <pre><code>1066 </code></pre> </blockquote> <p>The algorithm is a bit hard to follow, so I'm also curious if my code got across what's going on or not. I started the problem by drawing this picture on paper, which hopefully sheds some light on what I'm trying to do with the code. <a href="https://i.stack.imgur.com/vK6c0.jpg" rel="nofollow noreferrer"><img src="https://i.stack.imgur.com/vK6c0.jpg" alt="enter image description here"></a></p> <p>(Note that when I actually started coding, I realized it was a lot of work for zero gain to keep track of the second index so I dropped it.)</p> <pre><code>import glob def check_possible(talent_ratio, cow_list, min_weight): """ check if the talent ratio possible with the min weight given the cow list Note that talent_ratio is possible if there is some set of cows with total weight at least min_weight and SUM (talent - talent_ratio*weight) &gt;= 0 We use a knapsack like algorithm to keep track of this ------- Inputs: talent_ratio is an integer expressing the ratio of talent we want to check min_weight is an integer expressing how large we force the weight to be cow_list is the list of cows should be a list of tuples (weight, talent) Return: true if the talent ratio is achievable false otherwise """ #max_talent[total_weight] will keep track of the the maximum value of # SUM (talent - talent_ratio*weight) #among all sets of cows with total weight exactly total_weight # #max_talent[min_weight] represents the maximum value of # SUM (talent - talent_ratio*weight) #among all sets of cows with total weight at least min_weight max_talent = ["no_value" for total_weight in range(min_weight+1)] max_talent[0] = 0 number_cows = len(cow_list) #Knapsack type algorithm to compute max_talent[total_weight] for cow in range(number_cows): talent = cow_list[cow][1] weight = cow_list[cow][0] value = talent - talent_ratio*weight for heaviness in range(min_weight,-1,-1): #loop backwards to avoid using individual cows more than once. #For example, say our max_talent[1] was 10 cow 1. #this would be computed at heaviness=0. #But then at heaviness=1 we add cow 1's max talent again, #giving max_talent[2] = 20, but using cow 1 twice. new_weight = min(heaviness+weight, min_weight) #only update if there's a value already for heaviness if max_talent[heaviness] != "no_value": if max_talent[new_weight] == "no_value": max_talent[new_weight] = max_talent[heaviness]+value elif max_talent[heaviness]+value &gt; max_talent[new_weight]: max_talent[new_weight] = max_talent[heaviness]+value return max_talent[min_weight] &gt;= 0 def process_inputs(data): """ Take the input data from file and turn it into a list of lists of ints, and two ints telling us how many cows we have and the min weight. ------- Inputs: data is a file object. Returns: num_cows -- the number of cows we have in total, an INT min_weight -- the minimum weight our cows must have, an INT cow_list -- A list of tuples representing cows. Each tuple describes a cow by (weight, talent) """ lines = data.readlines() #turn the lines into a list of list ints cow_list=[list(map(int,line.split())) for line in lines] num_cows, min_weight = cow_list[0] cow_list.pop(0) return num_cows, min_weight, cow_list inputs = glob.glob("*.in") for input in inputs: with open(input) as data: num_cows, min_weight, cow_list = process_inputs(data) max_talent = 0 #binary search through possible values of floor(1000*max_talent) top = int(1000*max([cow[1]/cow[0] for cow in cow_list])) bottom = 0 while(top &gt; bottom + 1): middle = int((top + bottom)/2) if check_possible(middle/1000, cow_list, min_weight): bottom = middle else: top = middle max_talent = bottom print(max_talent) </code></pre>

195672

GOOD_ANSWER

<p>I have two models in Flask-SQLAlchemy (<strong>Post</strong> and <strong>Comment</strong>) that have many-to-many relationship that is manifested in the third model (<strong>post_mentions</strong>):</p> <pre><code>post_mentions = db.Table( 'post_mentions', db.Column('post_id', db.Integer, db.ForeignKey('posts.id'), primary_key=True), db.Column('comment_id', db.Integer, db.ForeignKey('comments.id'), primary_key=True), ) class Post(db.Model): __tablename__ = 'posts' id = db.Column(db.Integer, primary_key=True) name = db.Column(db.String, unique=True, nullable=False) mentions = db.relationship('Comment', secondary=post_mentions, lazy='dynamic') def __eq__(self, other): return self.name.lower() == other.name.lower() def __hash__(self): return hash(self.name.lower()) class Comment(db.Model): __tablename__ = 'comments' id = db.Column(db.Integer, primary_key=True) text = db.Column(db.Text, nullable=False) created_at = db.Column(db.Integer, nullable=False) </code></pre> <p>There is also a <strong>/posts</strong> endpoint that triggers the following query:</p> <pre><code># flask and other imports @app.route('/posts') def posts(): page_num = request.args.get('page', 1) posts = models.Post.query.join(models.post_mentions)\ .group_by(models.post_mentions.columns.post_id)\ .order_by(func.count(models.post_mentions.columns.post_id).desc())\ .paginate(page=int(page_num), per_page=25) return render_template('posts.html', posts=posts) </code></pre> <p>There are more than 14k+ posts and 32k+ comments stored in SQLite database. As you can see from the snippet above, when someone hits <strong>/posts</strong> endpoint, SQLAlchemy loads all data at once to the memory and then subsequent queries (e.g. retrieving posts, comments to that posts, etc..) take sub-millisecond time, since data is being served from the memory without hitting the database. Initial load takes 10s+ on my laptop, which is, to put it mildly, suboptimal. </p> <p>So the question is: Considering that users won't view 97+% of posts, how can I both order posts by number of mentions in comments and load them on demand instead of doing it in one swoop? </p>

196034

BAD_ANSWER

<p>I built a GUI tool that takes excel files and outputs a finished report to help automate a report at work. It was a fantastic learning experienced and I feel much more comfortable with pandas and python, but I am very aware of some bad programming practices I have included.</p> <p>I am self taught, and a little stuck on what I should focus on how to improve my program, I'm just looking to be pointed in the right direction.</p> <p>Most of the program is wrapped into one "Try/Except" block. I'm really not experienced enough to know what else I can do to improve it, aside from implementing some DRY and wrapping part of the program into a function so its not repeated for multiple files.</p> <p>Could a pandas guru or python guru give me a nudge in the right direction? I'm hitting a block on best practices to implement.</p> <pre><code>import Tkinter import pandas as pd import xlsxwriter class simpleapp_tk(Tkinter.Tk): def __init__(self,parent): Tkinter.Tk.__init__(self,parent) self.parent = parent self.initialize() def initialize(self): self.grid() # Create the grid #Label for entering filename label_one = Tkinter.Label(self, text="Please Enter a Filename:",anchor="w",fg="black", font="Times_New_Roman 10 bold") label_one.grid(column=0,row=1,sticky='W') #Label for entering filename label_one2 = Tkinter.Label(self, text="Please Enter a 2nd Filename:",anchor="w",fg="black", font="Times_New_Roman 10 bold") label_one2.grid(column=0,row=2,sticky='W') #Example label label_two = Tkinter.Label(self, text="RXInfoAug1.xlsx",anchor="center",fg="black", font="Times_New_Roman 10") label_two.grid(column=1,row=3,sticky='EW') #Creating label area for user information. label_three = Tkinter.Label(self, text="Please select User:",anchor='w',fg='black', font="Times_New_Roman 10 bold") label_three.grid(column=0,row=4,sticky='EW') #Label four is for EXAMPLE text label_four = Tkinter.Label(self,text="Example:",anchor='w',fg='black', font="Times_New_Roman 10 bold") label_four.grid(column=0,row=3,sticky='W') #Label five is below Generate RX report, spits out result information. label_five = Tkinter.Label(self,text="----------Result Info----------",anchor='center', fg='black',font="Times_New_Roman 10 bold") label_five.grid(column=0,row=6,sticky='EW',columnspan=2) #Label six is return information after clicking the button self.labelVariable_six = Tkinter.StringVar() #have to create a variable to return label_six = Tkinter.Label(self,text="None",anchor='center',fg='white',bg="blue", font='Times_New_Roman 10 bold', textvariable=self.labelVariable_six) #notice the return variable label_six.grid(column=0,row=8,sticky='EW',columnspan=2) #Label seven is more return information, pertaining to after you click the button. self.labelVariable_seven = Tkinter.StringVar() #creating the return variable label_seven = Tkinter.Label(self,text="None",anchor='center',fg='white',bg='blue', font='Times_New_Roman 10 bold', textvariable=self.labelVariable_seven) label_seven.grid(column=0,row=9,sticky='EW',columnspan=2) #Entry Variable creation and location set. self.entryVariable = Tkinter.StringVar() self.entry = Tkinter.Entry(self,textvariable=self.entryVariable) #NOTICE the entry var name self.entry.grid(column=1,row=1,sticky='EW') #Entry Variable2 creation and location set. self.entryVariable2 = Tkinter.StringVar() self.entry2 = Tkinter.Entry(self,textvariable=self.entryVariable2) #NOTICE the entry var name self.entry2.grid(column=1,row=2,sticky='EW') #Creating the variable of which user used by option menu self.var = Tkinter.StringVar(self) self.var.set("User") #Creating a drop down menu for user selection self.option_menu = Tkinter.OptionMenu(self, self.var, "Corey","Warwick","Jane", "Jacque") self.option_menu.grid(column=1,row=4,sticky='EW') #Button to generate reports - When clicked runs OnButtonClick button = Tkinter.Button(self,text="Generate RX Report", font="Times_New_Roman 12 bold", command=self.OnButtonClick) button.grid(column=0,row=6,sticky="EW",columnspan=2) #Layout management area self.grid_columnconfigure(0,weight=1) self.grid_columnconfigure(1,weight=1) #Layout Manager resizes if you adjust window self.resizable(True,True) self.update() #sets canvas size (Length, depth) self.geometry("320x170+300+300") self.entry.focus_set() self.entry.selection_range(0, Tkinter.END) self.entry2.selection_range(0, Tkinter.END) def OnButtonClick(self): UserName = self.var.get() FileName = self.entryVariable.get() if len(self.entryVariable2.get()) &gt; 0: FileName2 = self.entryVariable2.get() else: FileName2 = self.entryVariable.get() if UserName == "User": self.labelVariable_six.set("Please select a User before Continuing") self.labelVariable_seven.set("") elif UserName == "Corey": FilePath = "\cashley\Desktop\\" self.labelVariable_six.set("Welcome Corey, enjoy the report.") self.labelVariable_seven.set("Output file is located on desktop") writer = pd.ExcelWriter('C:\\Users\\cashley\\Desktop\\RX_STATS.xlsx') elif UserName == "Warwick": FilePath = "\wbarlow.GMSPRIMARY\Desktop\\" self.labelVariable_six.set("Welcome Warwick, always great to see you") self.labelVariable_seven.set("Output file is RX_STATS located on desktop") writer = pd.ExcelWriter('C:\\Users\\wbarlow.GMSPRIMARY\\Desktop\\RX_STATS.xlsx') elif UserName == "Jane": FilePath = "\janen.GMSPRIMARY\Desktop\\" self.labelVariable_six.set("Welcome Jane, enjoy the report") self.labelVariable_seven.set("Output file is RX_STATS located on desktop") writer = pd.ExcelWriter('C:\\Users\\janen.GMSPRIMARY\\Desktop\\RX_STATS.xlsx') elif UserName == "Jacque": FilePath = "\jacquea\Desktop\\" self.labelVariable_six.set("Welcome Jacquea, enjoy the report") self.labelVariable_seven.set("Output file is RX_STATS located on desktop") writer = pd.ExcelWriter('C:\\Users\\jacquea\\Desktop\\RX_STATS.xlsx') try: df = pd.read_excel("C:\Users" + FilePath + FileName) #DF_C Was added in so you can bring two files in to compare the two. df_C = pd.read_excel("C:\Users" + FilePath + FileName2) df.columns = ['GROUP','MEMBER_NAME','DRUG','CLAIM_DATE','SUB_QUANT','DAYS_SUPPLY','COPAY_AMT','TOTAL_COST'] df_C.columns = ['GROUP','MEMBER_NAME','DRUG','CLAIM_DATE','SUB_QUANT','DAYS_SUPPLY','COPAY_AMT','TOTAL_COST'] df['GROUP'] = df['GROUP'].astype(str) df_C['GROUP'] = df_C['GROUP'].astype(str) total_expense = df['TOTAL_COST'].sum() Y = total_expense * .80 df['PERCENT'] = (df['TOTAL_COST'] / total_expense).round(4) #Bad DRY here but metrics for analysis for df_C total_expense_C = df_C['TOTAL_COST'].sum() Y_C = total_expense_C * .80 df_C['PERCENT'] = (df_C['TOTAL_COST'] / total_expense_C).round(4) emp_dict = { 'FAKELASTNAME, FAKEFIRSTNAME': 'REDACTED1', 'BOB, FAKE': 'REDACTED2', 'SARAH, FAKE': 'REDACTED3', } df['MEMBER_NAME'].replace(emp_dict, inplace=True) df.loc[df.DRUG.isin(['LATUDA TAB 20MG', 'LATUDA TAB 60MG','LATUDA TAB 40MG']), 'DRUG'] = 'LATUDA TAB' df.loc[df.DRUG.isin(['HUMIRA START KIT 40MG PEN', 'HUMIRA PEN INJ 40MG/0.8','HUMIRA KIT 40MG SYN']), 'DRUG'] = 'HUMIRA' df.loc[df.DRUG.isin(['ENBREL SCLIK SYR 50MG/ML', 'ENBREL SYR 50MG/ML','ENBREL SYR 25/0.5ML']), 'DRUG'] = 'ENBREL' df.loc[df.DRUG.isin(['TRULICITY(4) PEN 1.5/0.5', 'TRULICITY(4) PEN 0.75/0.5']), 'DRUG'] = 'TRULICITY' df_C['MEMBER_NAME'].replace(emp_dict, inplace=True) df_C.loc[df_C.DRUG.isin(['LATUDA TAB 20MG', 'LATUDA TAB 60MG','LATUDA TAB 40MG']), 'DRUG'] = 'LATUDA TAB' df_C.loc[df_C.DRUG.isin(['HUMIRA START KIT 40MG PEN', 'HUMIRA PEN INJ 40MG/0.8','HUMIRA KIT 40MG SYN']), 'DRUG'] = 'HUMIRA' df_C.loc[df_C.DRUG.isin(['ENBREL SCLIK SYR 50MG/ML', 'ENBREL SYR 50MG/ML','ENBREL SYR 25/0.5ML']), 'DRUG'] = 'ENBREL' df_C.loc[df_C.DRUG.isin(['TRULICITY(4) PEN 1.5/0.5', 'TRULICITY(4) PEN 0.75/0.5']), 'DRUG'] = 'TRULICITY' df2 = df['TOTAL_COST'].groupby(df['MEMBER_NAME']).sum().nlargest(10) df3 = df['TOTAL_COST'].groupby(df['DRUG']).sum().nlargest(20) df4 = df['MEMBER_NAME'].value_counts().nlargest(20) df5 = df['PERCENT'].groupby(df['MEMBER_NAME']).sum().nlargest(20) df7 = df[df['TOTAL_COST'] &gt; 0] df8 = df['TOTAL_COST'].groupby(df['MEMBER_NAME']).sum().nlargest(1000) df13 = df['TOTAL_COST'].groupby(df['GROUP']).sum().nlargest(5) count = 0 total = 0 for row in df8: if total &lt; Y: total = total + row count += 1 WW = count #Count of how many Members are in the file. It combines duplicate individuals with nunique. Ind_count = df['MEMBER_NAME'].nunique() # Count of non zero individuals in the file. Ind_count_nonzero = df7['MEMBER_NAME'].nunique() # Finding what 20 percent of the total is twenty_percent1 = Ind_count_nonzero * .20 twenty_percent = round(twenty_percent1,0) row_count = df.shape[0] df10 = df['PERCENT'].groupby(df['MEMBER_NAME']).sum().nlargest(WW) group_dict = { '2006':'GROUPNAME1', '2033':'GROUPNAME2', '2041':'GROUPNAME3', } df['GROUP'].replace(group_dict, inplace=True) df_C['GROUP'].replace(group_dict, inplace=True) df15 = df_C[~df_C.MEMBER_NAME.isin(df.MEMBER_NAME)] pivot_C = pd.pivot_table(df15, index=['MEMBER_NAME','GROUP'],values=['TOTAL_COST'], aggfunc='sum') pivot_C2 = pivot_C.sort_values(by=['TOTAL_COST'],ascending=False) pv_C = pivot_C2.head(20) pv_C2 = pv_C.reset_index() df13 = df['TOTAL_COST'].groupby(df['GROUP']).sum().nlargest(5) df3 = df3.reset_index() df2 = df2.reset_index() df4 = df4.reset_index() df5 = df5.reset_index() df10 = df10.reset_index() df13 = df13.reset_index() pivot2 = pd.pivot_table(df, index=['MEMBER_NAME','GROUP'],values=['TOTAL_COST'], aggfunc='sum') pivot3 = pivot2.sort_values(by=['TOTAL_COST'],ascending=False) pv3 = pivot3.head(20) pv4 = pv3.reset_index() writer = pd.ExcelWriter('C:\\Users' + FilePath + 'RX_STATS.xlsx') #writer = pd.ExcelWriter('C:\\Users\\wbarlow.GMSPRIMARY\\Desktop\\RX_STATS.xlsx') pv4.to_excel(writer, sheet_name='Summary',index=False,header=True,startcol=0,startrow=10) pv_C2.to_excel(writer, sheet_name='Summary',index=False,header=True,startcol=0,startrow=35) df3.to_excel(writer, sheet_name='Summary',index=False,header=True,startcol=4,startrow=10) df4.to_excel(writer, sheet_name='Summary',index=False,header=True,startcol=7,startrow=10) df10.to_excel(writer, sheet_name='Summary',index=False,header=True,startcol=10,startrow=10) df13.to_excel(writer, sheet_name='Summary',index=False,header=True,startcol=4,startrow=0) df.to_excel(writer, sheet_name='Raw Data',index=False,header=True) df_C.to_excel(writer, sheet_name='Compare Data',index=False,header=True) worksheet1 = writer.sheets['Summary'] worksheet2 = writer.sheets['Raw Data'] worksheet3 = writer.sheets['Compare Data'] workbook = writer.book format1 = workbook.add_format({'num_format':'$#,###.##'}) format6 = workbook.add_format({'num_format':'$#,###.##','bold':True}) format2 = workbook.add_format({'bold': True}) format5 = workbook.add_format({'bold': True,'border':1,'align':'center'}) format3 = workbook.add_format({'bold': True, 'align': 'center'}) format4 = workbook.add_format({'num_format':'0.00%'}) merge_format = workbook.add_format({ 'bold':1, 'border':1, 'align':'center'}) worksheet1.write('A1', "Caremark File Statistics", format2) worksheet1.write('A6', "Individual Count:", format2) worksheet1.write('A3', "Individual Non-Zero Count:", format2) worksheet1.write('A4', "Twenty percent of all individuals:", format2) worksheet1.write('A5', "Count representing eighty percent:", format2) worksheet1.write('A2', "RX Total Expense:", format2) worksheet1.write('B6', Ind_count, format2) worksheet1.write('B3', Ind_count_nonzero, format2) worksheet1.write('B4', twenty_percent, format2) worksheet1.write('B5', WW, format2) worksheet1.write('B2', total_expense, format6) worksheet1.conditional_format('C12:C31',{'type':'cell', 'criteria':'&gt;=', 'value':1, 'format':format1}) worksheet1.conditional_format('F12:F31',{'type':'cell', 'criteria':'&gt;=', 'value':1, 'format':format1}) worksheet1.conditional_format(11,11,11+WW,11,{'type':'cell', 'criteria':'&gt;=', 'value':0, 'format':format4}) worksheet1.conditional_format('F2:F6',{'type':'cell', 'criteria':'&gt;=', 'value':0, 'format':format1}) worksheet2.conditional_format(1,8,row_count,8,{'type':'cell', 'criteria':'&gt;=', 'value':0, 'format':format4}) worksheet3.conditional_format(1,8,row_count,8,{'type':'cell', 'criteria':'&gt;=', 'value':0, 'format':format4}) worksheet1.conditional_format('C37:C56',{'type':'cell', 'criteria':'&gt;=', 'value':1, 'format':format1}) worksheet1.set_column(0,0,32) worksheet1.set_column(1,1,35) worksheet1.set_column(2,2,12) worksheet1.set_column(3,3,5) worksheet1.set_column(4,4,36) worksheet1.set_column(5,5,12) worksheet1.set_column(6,6,5) worksheet1.set_column(7,7,30) worksheet1.set_column(8,8,12) worksheet1.set_column(9,9,5) worksheet1.set_column(10,10,30) worksheet1.set_column(11,11,12) worksheet2.set_column(0,0,35) worksheet2.set_column(1,1,30) worksheet2.set_column(2,2,35) worksheet2.set_column(3,3,20) worksheet2.set_column(4,4,13) worksheet2.set_column(5,5,13) worksheet2.set_column(6,6,13) worksheet2.set_column(7,7,13) worksheet2.set_column(8,8,9) worksheet3.set_column(0,0,35) worksheet3.set_column(1,1,30) worksheet3.set_column(2,2,35) worksheet3.set_column(3,3,20) worksheet3.set_column(4,4,13) worksheet3.set_column(5,5,13) worksheet3.set_column(6,6,13) worksheet3.set_column(7,7,13) worksheet3.set_column(8,8,9) worksheet1.merge_range('A9:C9','Top Twenty Expense Individuals',merge_format) worksheet1.merge_range('E9:F9','Top Twenty RX Prescriptions', merge_format) worksheet1.merge_range('H9:I9','Top Twenty Prescription Fills Per Person', merge_format) worksheet1.merge_range('K9:L9','Individuals Representing 80% of Total Cost', merge_format) worksheet1.merge_range('A34:C34','New Individuals with Largest RX Totals', merge_format) worksheet1.write('H11', 'MEMBER_NAME', format5) worksheet1.write('I11','COUNT',format5) worksheet1.write('E1','LARGEST RX GROUPS',format5) worksheet1.write('A36','MEMBER NAME', format5) writer.save() self.entry.focus_set() self.entry.selection_range(0, Tkinter.END) except: self.labelVariable_six.set("Confirm User is accurate.") self.labelVariable_seven.set("Confirm your filename.") if __name__ == "__main__": app = simpleapp_tk(None) app.title('WB Caremark Cleaner') app.mainloop() </code></pre>

200425

GOOD_ANSWER

<p>I'm very new to python (been coding for about two days) and have created a programme that simulates blackjack games so that I can work out optimal strategy over many iterations.</p> <p>The problem is that when I run it, my CPU goes to about 99.8% and it freezes (I run in terminal) - Does anybody have any suggestions on how I can change my code so that it is less CPU intensive? - I'm looking to learn about what I've done wrong, the code is just a bit of fun!</p> <p>As I said I'm new to this and as such the code isn't very elegant, but it works just fine.</p> <pre><code>import random q = 0 #simple counter that will record the score of games over time win_count = 0 draw_count = 0 lose_count = 0 bust_count = 0 #User input for when the game is run, it will allow them to choose the number of games to be played (iterations) and also the score at which the player will hold. iterations = input('Number of iterations: ') hold_score = input('Hold score for the player: ') #defining the card values, suits and decks. for x in range(0, iterations): s2 = 2 s3 = 3 s4 = 4 s5 = 5 s6 = 6 s7 = 7 s8 = 8 s9 = 9 s10 = 10 sj = 10 sq = 10 sk = 10 sa = 11 c2 = 2 c3 = 3 c4 = 4 c5 = 5 c6 = 6 c7 = 7 c8 = 8 c9 = 9 c10 = 10 cj = 10 cq = 10 ck = 10 ca = 11 d2 = 2 d3 = 3 d4 = 4 d5 = 5 d6 = 6 d7 = 7 d8 = 8 d9 = 9 d10 = 10 dj = 10 dq = 10 dk = 10 da = 11 h2 = 2 h3 = 3 h4 = 4 h5 = 5 h6 = 6 h7 = 7 h8 = 8 h9 = 9 h10 = 10 hj = 10 hq = 10 hk = 10 ha = 11 spades = [s2, s3, s4, s5, s6, s7, s8, s9, s10, sj, sq, sk, sa] clubs = [c2, c3, c4, c5, c6, c7, c7, c8, c9, c10, cj, cq, ck, ca] diamonds = [d2, d3, d4, d5, d6, d7, d8, d9, d10, dj, dq, dk, da] hearts = [h2, h3, h4, h5, h6, h7, h8, h9, h10, hj, hq, hk, ha] deck = [s2, s3, s4, s5, s6, s7, s8, s9, s10, sj, sq, sk, sa, c2, c3, c4, c5, c6, c7, c8, c9, c10, cj, cq, ck, ca, d2, d3, d4, d5, d6, d7, d7, d8, d9, d10, dj, dq, dk, da, h2, h3, h4, h5, h6, h7, h8, h9, h10, hj, hq, hk, ha] deck_standard = [s2, s3, s4, s5, s6, s7, s8, s9, s10, sj, sq, sk, sa, c2, c3, c4, c5, c6, c7, c8, c9, c10, cj, cq, ck, ca, d2, d3, d4, d5, d6, d7, d7, d8, d9, d10, dj, dq, dk, da, h2, h3, h4, h5, h6, h7, h8, h9, h10, hj, hq, hk, ha] #List for the cards the dealer and player holds dealer = [] user_1 = [] #Randomly gives the player and dealer two cards each - and then remove these cards from the deck of cards so it cannot be used again. card_1 = random.choice(deck) deck.remove(card_1) user_1.append(card_1) card_2 = random.choice(deck) deck.remove(card_2) dealer.append(card_2) card_3 = random.choice(deck) deck.remove(card_3) user_1.append(card_3) card_4 = random.choice(deck) deck.remove(card_4) dealer.append(card_4) #Calculates the number of cards the player/dealer has - also defines their scores to be zero. dealer_card_count = len(dealer) user_1_card_count = len(user_1) dealer_score = 0 user_1_score = 0 #Looks at the two cards each player has and calculates their score - then adds this score to their score. for x in range(0, dealer_card_count): dealer_score = dealer_score + int(dealer[x]) for x in range(0, user_1_card_count): user_1_score = user_1_score + int(user_1[x]) #code to say that if the user has less cards than the pre-defined hold score - give them another card and add that card to their score. while (int(user_1_score) &lt;= int(hold_score)): if (int(user_1_card_count)&lt;6): card_5 = random.choice(deck) deck.remove(card_5) user_1.append(card_5) user_1_score = 0 user_1_card_count = len(user_1) for x in range(0, user_1_card_count): user_1_score = user_1_score + int(user_1[x]) # sets the hold score for the dealer as that of the user (so that the dealer knows how high he has to aim for) hold_score_dealer = user_1_score # Same as above - but for the dealer. if (int(user_1_score) &lt; int(21)): while (int(dealer_score) &lt;= int(hold_score_dealer)): if (int(dealer_card_count)&lt;6): card_6 = random.choice(deck) deck.remove(card_6) dealer.append(card_6) dealer_score = 0 dealer_card_count = len(dealer) for x in range(0, dealer_card_count): dealer_score = dealer_score + int(dealer[x]) #code so that if the user or the dealer have 5 cards they win automatically (5 card rule) if (int(user_1_card_count) ==5): if (int(dealer_card_count) !=5): if (int(user_1_score)) &lt;22: win_count = win_count + 1 if (int(user_1_card_count) == 5): if (int(dealer_card_count) == 5): if (int(user_1_score) &lt; 22): if (int(dealer_score) &lt;22): draw_count = draw_count + 1 elif (int(user_1_score) &gt; 22): bust_count = bust_count + 1 if (int(dealer_card_count) == 5): if(int(user_1_card_count) != 5): if (int(dealer_score) &lt;22): lose_count = lose_count + 1 #Code to deal with all possible outcomes (assuming they don't have 5 cards) - and add to the counter. if (int(user_1_card_count) != 5): if (int(dealer_card_count) != 5): if (int(user_1_score) &gt; int(dealer_score)): if (int(user_1_score) &lt; int(22)): win_count = win_count + 1 elif (int(user_1_score) &gt; int(21)): if (int(dealer_score) &lt; int(22)): lose_count = lose_count + 1 elif (int(user_1_score) &gt; int(21)): if (int(dealer_score) &gt; int (21)): draw_count = draw_count + 1 bust_count = bust_count + 1 elif (int(user_1_score) &lt; int(dealer_score)): if(int(user_1_score) &gt; 21): draw_count = draw_count + 1 bust_count = bust_count + 1 if (int(user_1_card_count) != 5): if (int(dealer_card_count) != 5): if (int(user_1_score) == int(dealer_score)): if (int(user_1_score)) &lt; int(22): draw_count = draw_count + 1 elif (int(user_1_score) &gt; 21): draw_count = draw_count + 1 bust_count = bust_count + 1 if (int(user_1_card_count) != 5): if (int(dealer_card_count) != 5): if (int(user_1_score) &lt; int(dealer_score)): if (int(dealer_score) &lt; int(22)): lose_count = lose_count + 1 elif (int(dealer_score) &gt; int(21)): if (int(user_1_score) &lt; int(22)): win_count = win_count + 1 #Code to print the progress of the iterations over time if (q == iterations * 0.2): print "20%" if (q == iterations * 0.4): print "40%" if (q == iterations * 0.6): print "60%" if (q == iterations * 0.8): print "80%" if (q == iterations * 1): print "100%" gc.collect() print q q = q + 1 # Code to print the final scores after all iterations are complete. print "Total iterations: " + str(iterations) print "*****" print "Win count : " + str(win_count) +" ("+ str((float(win_count))/float(iterations)*100) +"%)" print "Draw count : " + str(draw_count) +" ("+ str((float(draw_count))/float(iterations)*100) +"%)" print "Lose count : " + str(lose_count) +" ("+ str((float(lose_count))/float(iterations)*100) +"%)" print "Bust count : " + str(bust_count) +" ("+ str((float(bust_count))/float(iterations)*100) +"%)" print "" </code></pre>

201472

WIERD

<p>I'm very new to python (been coding for about two days) and have created a programme that simulates blackjack games so that I can work out optimal strategy over many iterations.</p> <p>The problem is that when I run it, my CPU goes to about 99.8% and it freezes (I run in terminal) - Does anybody have any suggestions on how I can change my code so that it is less CPU intensive? - I'm looking to learn about what I've done wrong, the code is just a bit of fun!</p> <p>As I said I'm new to this and as such the code isn't very elegant, but it works just fine.</p> <pre><code>import random q = 0 #simple counter that will record the score of games over time win_count = 0 draw_count = 0 lose_count = 0 bust_count = 0 #User input for when the game is run, it will allow them to choose the number of games to be played (iterations) and also the score at which the player will hold. iterations = input('Number of iterations: ') hold_score = input('Hold score for the player: ') #defining the card values, suits and decks. for x in range(0, iterations): s2 = 2 s3 = 3 s4 = 4 s5 = 5 s6 = 6 s7 = 7 s8 = 8 s9 = 9 s10 = 10 sj = 10 sq = 10 sk = 10 sa = 11 c2 = 2 c3 = 3 c4 = 4 c5 = 5 c6 = 6 c7 = 7 c8 = 8 c9 = 9 c10 = 10 cj = 10 cq = 10 ck = 10 ca = 11 d2 = 2 d3 = 3 d4 = 4 d5 = 5 d6 = 6 d7 = 7 d8 = 8 d9 = 9 d10 = 10 dj = 10 dq = 10 dk = 10 da = 11 h2 = 2 h3 = 3 h4 = 4 h5 = 5 h6 = 6 h7 = 7 h8 = 8 h9 = 9 h10 = 10 hj = 10 hq = 10 hk = 10 ha = 11 spades = [s2, s3, s4, s5, s6, s7, s8, s9, s10, sj, sq, sk, sa] clubs = [c2, c3, c4, c5, c6, c7, c7, c8, c9, c10, cj, cq, ck, ca] diamonds = [d2, d3, d4, d5, d6, d7, d8, d9, d10, dj, dq, dk, da] hearts = [h2, h3, h4, h5, h6, h7, h8, h9, h10, hj, hq, hk, ha] deck = [s2, s3, s4, s5, s6, s7, s8, s9, s10, sj, sq, sk, sa, c2, c3, c4, c5, c6, c7, c8, c9, c10, cj, cq, ck, ca, d2, d3, d4, d5, d6, d7, d7, d8, d9, d10, dj, dq, dk, da, h2, h3, h4, h5, h6, h7, h8, h9, h10, hj, hq, hk, ha] deck_standard = [s2, s3, s4, s5, s6, s7, s8, s9, s10, sj, sq, sk, sa, c2, c3, c4, c5, c6, c7, c8, c9, c10, cj, cq, ck, ca, d2, d3, d4, d5, d6, d7, d7, d8, d9, d10, dj, dq, dk, da, h2, h3, h4, h5, h6, h7, h8, h9, h10, hj, hq, hk, ha] #List for the cards the dealer and player holds dealer = [] user_1 = [] #Randomly gives the player and dealer two cards each - and then remove these cards from the deck of cards so it cannot be used again. card_1 = random.choice(deck) deck.remove(card_1) user_1.append(card_1) card_2 = random.choice(deck) deck.remove(card_2) dealer.append(card_2) card_3 = random.choice(deck) deck.remove(card_3) user_1.append(card_3) card_4 = random.choice(deck) deck.remove(card_4) dealer.append(card_4) #Calculates the number of cards the player/dealer has - also defines their scores to be zero. dealer_card_count = len(dealer) user_1_card_count = len(user_1) dealer_score = 0 user_1_score = 0 #Looks at the two cards each player has and calculates their score - then adds this score to their score. for x in range(0, dealer_card_count): dealer_score = dealer_score + int(dealer[x]) for x in range(0, user_1_card_count): user_1_score = user_1_score + int(user_1[x]) #code to say that if the user has less cards than the pre-defined hold score - give them another card and add that card to their score. while (int(user_1_score) &lt;= int(hold_score)): if (int(user_1_card_count)&lt;6): card_5 = random.choice(deck) deck.remove(card_5) user_1.append(card_5) user_1_score = 0 user_1_card_count = len(user_1) for x in range(0, user_1_card_count): user_1_score = user_1_score + int(user_1[x]) # sets the hold score for the dealer as that of the user (so that the dealer knows how high he has to aim for) hold_score_dealer = user_1_score # Same as above - but for the dealer. if (int(user_1_score) &lt; int(21)): while (int(dealer_score) &lt;= int(hold_score_dealer)): if (int(dealer_card_count)&lt;6): card_6 = random.choice(deck) deck.remove(card_6) dealer.append(card_6) dealer_score = 0 dealer_card_count = len(dealer) for x in range(0, dealer_card_count): dealer_score = dealer_score + int(dealer[x]) #code so that if the user or the dealer have 5 cards they win automatically (5 card rule) if (int(user_1_card_count) ==5): if (int(dealer_card_count) !=5): if (int(user_1_score)) &lt;22: win_count = win_count + 1 if (int(user_1_card_count) == 5): if (int(dealer_card_count) == 5): if (int(user_1_score) &lt; 22): if (int(dealer_score) &lt;22): draw_count = draw_count + 1 elif (int(user_1_score) &gt; 22): bust_count = bust_count + 1 if (int(dealer_card_count) == 5): if(int(user_1_card_count) != 5): if (int(dealer_score) &lt;22): lose_count = lose_count + 1 #Code to deal with all possible outcomes (assuming they don't have 5 cards) - and add to the counter. if (int(user_1_card_count) != 5): if (int(dealer_card_count) != 5): if (int(user_1_score) &gt; int(dealer_score)): if (int(user_1_score) &lt; int(22)): win_count = win_count + 1 elif (int(user_1_score) &gt; int(21)): if (int(dealer_score) &lt; int(22)): lose_count = lose_count + 1 elif (int(user_1_score) &gt; int(21)): if (int(dealer_score) &gt; int (21)): draw_count = draw_count + 1 bust_count = bust_count + 1 elif (int(user_1_score) &lt; int(dealer_score)): if(int(user_1_score) &gt; 21): draw_count = draw_count + 1 bust_count = bust_count + 1 if (int(user_1_card_count) != 5): if (int(dealer_card_count) != 5): if (int(user_1_score) == int(dealer_score)): if (int(user_1_score)) &lt; int(22): draw_count = draw_count + 1 elif (int(user_1_score) &gt; 21): draw_count = draw_count + 1 bust_count = bust_count + 1 if (int(user_1_card_count) != 5): if (int(dealer_card_count) != 5): if (int(user_1_score) &lt; int(dealer_score)): if (int(dealer_score) &lt; int(22)): lose_count = lose_count + 1 elif (int(dealer_score) &gt; int(21)): if (int(user_1_score) &lt; int(22)): win_count = win_count + 1 #Code to print the progress of the iterations over time if (q == iterations * 0.2): print "20%" if (q == iterations * 0.4): print "40%" if (q == iterations * 0.6): print "60%" if (q == iterations * 0.8): print "80%" if (q == iterations * 1): print "100%" gc.collect() print q q = q + 1 # Code to print the final scores after all iterations are complete. print "Total iterations: " + str(iterations) print "*****" print "Win count : " + str(win_count) +" ("+ str((float(win_count))/float(iterations)*100) +"%)" print "Draw count : " + str(draw_count) +" ("+ str((float(draw_count))/float(iterations)*100) +"%)" print "Lose count : " + str(lose_count) +" ("+ str((float(lose_count))/float(iterations)*100) +"%)" print "Bust count : " + str(bust_count) +" ("+ str((float(bust_count))/float(iterations)*100) +"%)" print "" </code></pre>

201472

GOOD_ANSWER

<p><strong>Question-</strong></p> <p>Generate all prime numbers between two given numbers.</p> <p><a href="https://www.spoj.com/problems/PRIME1/" rel="nofollow noreferrer">https://www.spoj.com/problems/PRIME1/</a></p> <p><strong>My attempt-</strong></p> <p>I used segmented sieve method.</p> <pre><code>t=int(input()) import math def segsieve(x): if x==1: return False for i in range(2,int(math.sqrt(x))+1): if x%i==0: return False return True while t&gt;0: f,l=map(int,input().split()) for j in range(f,l): a=segsieve(j) if a==True: print(j) t-=1 </code></pre> <p><strong>Issue-</strong></p> <p>I am getting time limit exceeded. How can I make it faster?</p>

202480

BAD_ANSWER

<p>I was able to make a program that parse my samtools output file into a table that can be viewed easily in excel. While I was able to get the final result, is there a recommended improvements that be done for my code. I am trying to improve my python skills and transferring over from C and C++.</p> <p>The strategy I used was to split the data I need based on the "+" sign and make it into an array. Then select the elements of the array that were the information that I needed and write it to my file.</p> <h3>My example input:</h3> <pre><code>15051874 + 0 in total (QC-passed reads + QC-failed reads) 1998052 + 0 secondary 0 + 0 supplementary 0 + 0 duplicates 13457366 + 0 mapped (89.41% : N/A) 13053822 + 0 paired in sequencing 6526911 + 0 read1 6526911 + 0 read2 10670914 + 0 properly paired (81.75% : N/A) 10947288 + 0 with itself and mate mapped 512026 + 0 singletons (3.92% : N/A) 41524 + 0 with mate mapped to a different chr 31302 + 0 with mate mapped to a different chr (mapQ&gt;=5) </code></pre> <h3>My output:</h3> <pre><code>FileName Total Secondary Supplementary duplicates mapped paired in sequencing read1 read2 properly paired with itself and mate mapped singletons with mate mapped to a different chr with mate mapped to a different chr (mapQ&gt;=5) 10_HK_S22.merged.samtools.flag.txt 26541257 2332283 0 0 22895440 24208974 12104487 12104487 19003826 19632880 930277 69030 52261 </code></pre> <h3>My Program:</h3> <pre><code>outFile = open("output.count.txt", "w+") #windows platform add the r os.chdir(r"Susceptible\featurecounts") #open the output file to be able to write output. outFile.write("FileName\tTotal\tSecondary\tSupplementary\tduplicates\tmapped\tpaired in sequencing\tread1\t" "read2\tproperly paired\twith itself and mate mapped\tsingletons\twith mate mapped to a different chr\twith mate mapped to a different chr (mapQ&gt;=5)\n") #Iterate through files in directory with the following ending for file in glob.glob(".flag.txt"): #open file after retrieving the name. with open(file, 'r') as counts_file: #empty list/array for storing the outputs list = [] #add the file name to array. list.append(file) #get values from output file. for line in counts_file: list.append(line.split('+')[0]) #write list to file for item in list: outFile.write("%s\t" % item) #write a newline outFile.write("\n") #close the output file outFile.close() </code></pre>

204792

GOOD_ANSWER

<p>Overall, I feel that my code is a bit verbose.</p> <p><em>game.py</em></p> <pre><code>#!/usr/bin/python3 import sys,os from models import Board, GameState """ Game loop for the minesweeper game. """ class Game: def __init__(self): self.board = Board(rows=10, cols=10) def play(self): self.welcome() while self.board.game_state in [GameState.on_going, GameState.start]: self.board.print_board_wrapper(self.board.print_board_hook) try: raw = input("&gt; ") line = "".join(raw.split()) if line[0] == "f": point = tuple(map(int, line[1:].split(","))) self.board.flag_square(point[0], point[1]) else: point = tuple(map(int, line.split(","))) self.board.click_square(point[0], point[1]) except (IndexError, ValueError): self.help() except KeyboardInterrupt: try: sys.exit(0) except SystemExit: os._exit(0) if self.board.game_state == GameState.lose: print("\n\nYou hit a mine. :(\n") else: print("\n\nYou win!\n") self.board.print_board_wrapper(self.board.print_board_end_hook) def welcome(self): print("\nWelcome to PySweep!") self.help() def help(self): print("\nEnter coordinates") print("&gt; &lt;row&gt;,&lt;column&gt;") print("&gt; 1,1") print("Flag and unflag coordinates") print("&gt; f &lt;row&gt;,&lt;column&gt;") print("&gt; f 1,1") if __name__ == "__main__": game = Game() game.play() </code></pre> <p><em>models.py</em></p> <pre><code>""" Data models for a minesweeper CLI game. """ import random import itertools from enum import Enum class GameState(Enum): start = 0 win = 1 lose = 2 on_going = 3 class Board: """ Represents a minesweeper board with squares. """ def __init__(self, rows, cols): self.rows = rows self.cols = cols self.game_state = GameState.start self.number_of_mines = 0 self.max_mines = (cols-1)*(rows-1) mines_percentage = (100 * self.max_mines / (rows*cols))/3 self.__create_squares(self.cols, self.rows, mines_percentage) def flag_square(self, row, col): if not self.__valid_square(row, col) or self.__get_square(row, col).clicked: return square = self.squares[row][col] square.flag = not square.flag def click_square(self, row, col): """ Click the square and click its neighbors which don't have neighboring mines. """ if not self.__valid_square(row, col) or self.__get_square(row, col).clicked: return square = self.squares[row][col] if self.game_state == GameState.start: square.mine = False for neighbor in square.neighbors(): neighbor.mine = False self.game_state = GameState.on_going if square.mine: self.game_state = GameState.lose return square.clicked = True if square.mine_neighbors() == 0: for neighbor in square.neighbors(): if not neighbor.mine: if neighbor.mine_neighbors() == 0: self.click_square(neighbor.row, neighbor.col) neighbor.clicked = True if self.__win(): self.game_state = GameState.win def print_board_wrapper(self, print_hook): print("\n") col_print = " " for i in range(0, self.cols): col_print += str(i) + " " print(col_print + "\n") for i,row in enumerate(self.squares): row_print = str(i) + " " for square in row: row_print += print_hook(square) print(row_print + "\n") def print_board_hook(self, square): """ Prints the board. If a square is clicked, print the number of neighboring mines. If the square is flagged, print "f". Else print ".". """ if square.clicked: return " " + str(square.mine_neighbors()) + " " elif square.flag: return " f " return " . " def print_board_end_hook(self, square): if square.mine: return " x " return self.print_board_hook(square) def __win(self): for row in self.squares: for square in row: if not square.mine and not square.clicked: return False return True def __get_square(self, row, col): """ Return the square at the given row and column.""" return self.squares[row][col] def __valid_square(self, row, col): return (row &lt; self.rows and row &gt;= 0) and (col &lt; self.cols and col &gt;= 0) def __create_squares(self, cols, rows, mines_percentage): """ Create a grid of squares of size rows by cols. """ self.squares = [[Square(self, row, col, mine=self.__is_mine(mines_percentage)) for col in range(cols)] for row in range(rows)] def __is_mine(self, mines_percentage): """ Determine if a square is a mine while generating the board. """ is_mine = random.randrange(100) &lt; mines_percentage if is_mine: if self.number_of_mines &gt;= self.max_mines: return False self.number_of_mines = self.number_of_mines + 1 return True return False class Square: """ Represents a single square in the minesweeper board. A square may have or may not have a mine, may be clicked or unclicked. """ def __init__(self, board, row, col, mine): self.board = board self.row = row self.col = col self.mine = mine self.flag = False self.clicked = False def mine_neighbors(self): return len(list(filter(lambda square: square.mine, [self.board.squares[point[0]][point[1]] for point in self.__point_neighbors()]))) def neighbors(self): return [self.board.squares[point[0]][point[1]] for point in self.__point_neighbors()] def __point_neighbors(self): row_neighbors = list(filter(lambda val: val &gt;= 0 and val &lt; self.board.rows, [self.row-1, self.row, self.row+1])) col_neighbors = list(filter(lambda val: val &gt;= 0 and val &lt; self.board.cols, [self.col-1, self.col, self.col+1])) neighbor_set = set(itertools.product(row_neighbors, col_neighbors)) neighbor_set.remove((self.row, self.col)) return list(neighbor_set) </code></pre> <p>I think there's lots of places where my code could be made a lot more readable. The hook for the <em>print_board</em> function seems a bit suspect. The <code>__point_neighbors</code> function could probably be improved (having a lambda seems to be overkill).</p> <p>I'm also looking to improve the mine generation algorithm. Currently, each square has an individual probability of being a mine and mine generation is stopped when max_mines is reached. So, the bottom right corner would be likely to have less mines. My solution to the "first click shouldn't be a mine" problem is I clear the space around the first click so you always get the eight spaces around the first click for free.</p> <p>Here's a <a href="https://github.com/kdbeall/pysweep/tree/bfbdf51c87ee89339802fe1b5e195b9ec2d36311" rel="noreferrer">link</a> to the git repository.</p>

205474

GOOD_ANSWER

<p>This code that I wrote is supposed to read/write a pipe-delimited file line by line to a new file with some simple text manipulation. (It also adds two new columns) and publishes a "Status Update" ever 100,000 lines to keep me updated on how close it is to completion. </p> <p>I previously posted this code on StackOverflow to get help with incrementing, and someone mentioned that it would be faster if I did not open the second text file, but being extremely new at Python, I do not understand how to do that without potentially breaking the code.</p> <pre><code>counter=1 for line in open(r"C:\Path\name.txt"): spline = line.split("|") if counter==1: with open(r"C:\PATH\2019.txt",'a') as NewFile: spline.insert(23,"Column A") spline.insert(23,"Column B") s="|" newline=s.join(spline) NewFile.write(newline) elif counter &gt; 1 and not spline[22]=="0.00": spline.insert(23,"") spline.insert(23,"") gl=spline[0] gl=gl.strip() if gl[0]=="-": gl="000" + gl gl=gl.upper() spline[0]=gl if gl[:3]=="000": spline[24]="Incorrect" s="|" newline=s.join(spline) with open(r"C:\PATH\PythonWrittenData.txt",'a') as NewFile: NewFile.write(newline) counter+=1 if counter%100000==0: print("Status Update: \n", "{:,}".format(counter)) </code></pre>

216653

GOOD_ANSWER

<p>This code that I wrote is supposed to read/write a pipe-delimited file line by line to a new file with some simple text manipulation. (It also adds two new columns) and publishes a "Status Update" ever 100,000 lines to keep me updated on how close it is to completion. </p> <p>I previously posted this code on StackOverflow to get help with incrementing, and someone mentioned that it would be faster if I did not open the second text file, but being extremely new at Python, I do not understand how to do that without potentially breaking the code.</p> <pre><code>counter=1 for line in open(r"C:\Path\name.txt"): spline = line.split("|") if counter==1: with open(r"C:\PATH\2019.txt",'a') as NewFile: spline.insert(23,"Column A") spline.insert(23,"Column B") s="|" newline=s.join(spline) NewFile.write(newline) elif counter &gt; 1 and not spline[22]=="0.00": spline.insert(23,"") spline.insert(23,"") gl=spline[0] gl=gl.strip() if gl[0]=="-": gl="000" + gl gl=gl.upper() spline[0]=gl if gl[:3]=="000": spline[24]="Incorrect" s="|" newline=s.join(spline) with open(r"C:\PATH\PythonWrittenData.txt",'a') as NewFile: NewFile.write(newline) counter+=1 if counter%100000==0: print("Status Update: \n", "{:,}".format(counter)) </code></pre>

216653

BAD_ANSWER

<p>This is my first program written outside of using books and tutorials. Any help on style and functionality would be helpful.</p> <pre><code> import sys from textwrap import dedent import os import random os.system('CLS') # board number setup board = [0,1,2, 3,4,5, 6,7,8] # Defines the board layout printed to the console def board_layout(): print(dedent(f''' ************* * {board[0]} | {board[1]} | {board[2]} * *-----------* * {board[3]} | {board[4]} | {board[5]} * *-----------* * {board[6]} | {board[7]} | {board[8]} * ************* ''')) move_count= 0 def main(): while True: #Prints board layout to console. board_layout() #checks for a winner when called at end of each turn def check_winner(): global move_count #list of lists with all the winning combinations for from the tic tac toe board winning_list = [[board[0],board[1],board[2]],[board[3],board[4],board[5],], [board[6],board[7],board[8]],[board[0],board[4],board[8]],[board[2],board[4],board[6]], [board[0],board[3],board[6]],[board[1],board[4],board[7]],[board[2],board[5],board[8]]] #Keeps a reference to winning_list so it is updated at the end of every turn new_list = winning_list #iterates over the lists in winning_list for i,j,k in winning_list: #looks at the lists in winning_list to determine if a list has all x's for a win if i == 'x' and j == 'x' and k == 'x' : print('X wins') end() #looks at the lists in winning_list to determine if a list has all o's for a win elif i == 'o' and j == 'o' and k == 'o' : print('O wins') end() #possible moves is 9 in tic tac toe. If all moves are taken and there is no winner no winner forces a draw. if move_count == 9: print('You Tied') end() #Takes user input for the move move =int(input('Please select a spot: ')) print(move) #Player move, makes sure the spot is not taken and adds 1 to move_count if board[move] !='x' and board[move] != 'o': board[move] = 'x' move_count += 1 check_winner() #npc move, chooses a random spot that is not taken and adds 1 to move_count while True: npc = random.randint(0,8) if board[npc] != 'o' and board[npc] != 'x': board[npc] = 'o' print('Computer chooses spot ', npc) move_count += 1 check_winner() break #If spot is taken prints that the spot is already taken else: print('This spot is taken') #Game ending def end(): print('Thank you for playing') sys.exit() if __name__ == "__main__": main() </code></pre>

217235

GOOD_ANSWER

<p>This is my first program written outside of using books and tutorials. Any help on style and functionality would be helpful.</p> <pre><code> import sys from textwrap import dedent import os import random os.system('CLS') # board number setup board = [0,1,2, 3,4,5, 6,7,8] # Defines the board layout printed to the console def board_layout(): print(dedent(f''' ************* * {board[0]} | {board[1]} | {board[2]} * *-----------* * {board[3]} | {board[4]} | {board[5]} * *-----------* * {board[6]} | {board[7]} | {board[8]} * ************* ''')) move_count= 0 def main(): while True: #Prints board layout to console. board_layout() #checks for a winner when called at end of each turn def check_winner(): global move_count #list of lists with all the winning combinations for from the tic tac toe board winning_list = [[board[0],board[1],board[2]],[board[3],board[4],board[5],], [board[6],board[7],board[8]],[board[0],board[4],board[8]],[board[2],board[4],board[6]], [board[0],board[3],board[6]],[board[1],board[4],board[7]],[board[2],board[5],board[8]]] #Keeps a reference to winning_list so it is updated at the end of every turn new_list = winning_list #iterates over the lists in winning_list for i,j,k in winning_list: #looks at the lists in winning_list to determine if a list has all x's for a win if i == 'x' and j == 'x' and k == 'x' : print('X wins') end() #looks at the lists in winning_list to determine if a list has all o's for a win elif i == 'o' and j == 'o' and k == 'o' : print('O wins') end() #possible moves is 9 in tic tac toe. If all moves are taken and there is no winner no winner forces a draw. if move_count == 9: print('You Tied') end() #Takes user input for the move move =int(input('Please select a spot: ')) print(move) #Player move, makes sure the spot is not taken and adds 1 to move_count if board[move] !='x' and board[move] != 'o': board[move] = 'x' move_count += 1 check_winner() #npc move, chooses a random spot that is not taken and adds 1 to move_count while True: npc = random.randint(0,8) if board[npc] != 'o' and board[npc] != 'x': board[npc] = 'o' print('Computer chooses spot ', npc) move_count += 1 check_winner() break #If spot is taken prints that the spot is already taken else: print('This spot is taken') #Game ending def end(): print('Thank you for playing') sys.exit() if __name__ == "__main__": main() </code></pre>

217235

GOOD_ANSWER

<p>This is my first program written outside of using books and tutorials. Any help on style and functionality would be helpful.</p> <pre><code> import sys from textwrap import dedent import os import random os.system('CLS') # board number setup board = [0,1,2, 3,4,5, 6,7,8] # Defines the board layout printed to the console def board_layout(): print(dedent(f''' ************* * {board[0]} | {board[1]} | {board[2]} * *-----------* * {board[3]} | {board[4]} | {board[5]} * *-----------* * {board[6]} | {board[7]} | {board[8]} * ************* ''')) move_count= 0 def main(): while True: #Prints board layout to console. board_layout() #checks for a winner when called at end of each turn def check_winner(): global move_count #list of lists with all the winning combinations for from the tic tac toe board winning_list = [[board[0],board[1],board[2]],[board[3],board[4],board[5],], [board[6],board[7],board[8]],[board[0],board[4],board[8]],[board[2],board[4],board[6]], [board[0],board[3],board[6]],[board[1],board[4],board[7]],[board[2],board[5],board[8]]] #Keeps a reference to winning_list so it is updated at the end of every turn new_list = winning_list #iterates over the lists in winning_list for i,j,k in winning_list: #looks at the lists in winning_list to determine if a list has all x's for a win if i == 'x' and j == 'x' and k == 'x' : print('X wins') end() #looks at the lists in winning_list to determine if a list has all o's for a win elif i == 'o' and j == 'o' and k == 'o' : print('O wins') end() #possible moves is 9 in tic tac toe. If all moves are taken and there is no winner no winner forces a draw. if move_count == 9: print('You Tied') end() #Takes user input for the move move =int(input('Please select a spot: ')) print(move) #Player move, makes sure the spot is not taken and adds 1 to move_count if board[move] !='x' and board[move] != 'o': board[move] = 'x' move_count += 1 check_winner() #npc move, chooses a random spot that is not taken and adds 1 to move_count while True: npc = random.randint(0,8) if board[npc] != 'o' and board[npc] != 'x': board[npc] = 'o' print('Computer chooses spot ', npc) move_count += 1 check_winner() break #If spot is taken prints that the spot is already taken else: print('This spot is taken') #Game ending def end(): print('Thank you for playing') sys.exit() if __name__ == "__main__": main() </code></pre>

217235

WIERD

<p>The following code is my solution for the following Daily Coding Challenge</p> <blockquote> <p>Given an array of numbers, find the maximum sum of any contiguous subarray of the array.</p> <p>For example, given the array [34, -50, 42, 14, -5, 86], the maximum sum would be 137, since we would take elements 42, 14, -5, and 86.</p> <p>Given the array [-5, -1, -8, -9], the maximum sum would be 0, since we would not take any elements.</p> <p>Do this in O(N) time.</p> </blockquote> <p>I think this is done in <code>O(N)</code> time and is the best solution. If someone can think of a better way, I would be interested. </p> <pre><code>array = [4, -2, 7, -9] running_sum = 0 for i in range(1,len(array)): if array[i-1] &gt; 0: array[i] = array[i] + array[i-1] else: array[i-1] = 0 print(max(array)) </code></pre>

222772

GOOD_ANSWER

<p>The following code is my solution for the following Daily Coding Challenge</p> <blockquote> <p>Given an array of numbers, find the maximum sum of any contiguous subarray of the array.</p> <p>For example, given the array [34, -50, 42, 14, -5, 86], the maximum sum would be 137, since we would take elements 42, 14, -5, and 86.</p> <p>Given the array [-5, -1, -8, -9], the maximum sum would be 0, since we would not take any elements.</p> <p>Do this in O(N) time.</p> </blockquote> <p>I think this is done in <code>O(N)</code> time and is the best solution. If someone can think of a better way, I would be interested. </p> <pre><code>array = [4, -2, 7, -9] running_sum = 0 for i in range(1,len(array)): if array[i-1] &gt; 0: array[i] = array[i] + array[i-1] else: array[i-1] = 0 print(max(array)) </code></pre>

222772

WIERD

<h3>Problem</h3> <p>Write a method to return a boolean if an input grid is magic square.</p> <hr> <p>A magic square is a <span class="math-container">\$NxN\$</span> square grid (where N is the number of cells on each side) filled with distinct positive integers in the range <span class="math-container">\${1,2,...,n^{2}}\$</span> such that each cell contains a different integer and the sum of the integers in each row, column and diagonal is equal. The sum is called the magic constant or magic sum of the magic square. </p> <p><a href="https://i.stack.imgur.com/cmWko.png" rel="noreferrer"><img src="https://i.stack.imgur.com/cmWko.png" alt="enter image description here"></a></p> <hr> <h3>Code</h3> <p>I've tried to solve the above problem. If you'd like to review the code and provide any change/improvement recommendations please do so, and I'd really appreciate that.</p> <pre><code>from typing import List import numpy as np def is_magic_square(grid: List[List[int]]) -&gt; bool: """Returns a boolean if an input grid is magic square""" try: grid_length = len(grid) magic_sum = float(grid_length * (grid_length ** 2 + 1) / 2) diag_positive, diag_negative = [], [] diag_count_positive = 0 diag_count_negative = grid_length - 1 col_grid = np.zeros(shape=(grid_length, grid_length)) unique_elements = set() for index_row, lists in enumerate(grid): diag_negative.append(lists[diag_count_negative]) diag_count_negative -= 1 if len(grid[index_row]) != grid_length: return False if sum(lists) != magic_sum: return False for index_col in range(grid_length): unique_elements.add(lists[index_col]) col_grid[index_col][index_row] = lists[index_col] if index_col == grid_length and index_row == grid_length - 1 and len(unique_elements) != grid_length ** 2 - 1: return False if index_row == grid_length - 1: sum_col = sum(col_grid) temp_col = np.array([magic_sum] * grid_length) if str(temp_col) != str(sum_col): return False if diag_count_positive == index_row: diag_positive.append(lists[index_row]) diag_count_positive += 1 if diag_count_positive == grid_length and sum(diag_positive) != magic_sum: return False if index_row == grid_length - 1 and sum(diag_negative) != magic_sum: return False except: return False return True if __name__ == '__main__': # ---------------------------- TEST --------------------------- DIVIDER_DASH_LINE = '-' * 50 GREEN_APPLE = '\U0001F34F' RED_APPLE = '\U0001F34E' magic_squares = [ [[4, 3, 8], [9, 5, 1], [2, 7, 6]], [[9, 3, 22, 16, 15], [2, 21, 20, 14, 8], [25, 19, 13, 7, 1], [18, 12, 6, 5, 24], [11, 10, 4, 23, 17]], [[60, 53, 44, 37, 4, 13, 20, 29], [3, 14, 19, 30, 59, 54, 43, 38], [58, 55, 42, 39, 2, 15, 18, 31], [1, 16, 17, 32, 57, 56, 41, 40], [61, 52, 45, 36, 5, 12, 21, 28], [6, 11, 22, 27, 62, 51, 46, 35], [63, 50, 47, 34, 7, 10, 23, 26], [8, 9, 24, 25, 64, 49, 48, 33]], [[35, 26, 17, 1, 62, 53, 44], [46, 37, 21, 12, 3, 64, 55], [57, 41, 32, 23, 14, 5, 66], [61, 52, 43, 34, 25, 16, 7], [2, 63, 54, 45, 36, 27, 11], [13, 4, 65, 56, 47, 31, 22], [24, 15, 6, 67, 51, 42, 33]], [[1, 35, 4, 33, 32, 6], [25, 11, 9, 28, 8, 30], [24, 14, 18, 16, 17, 22], [13, 23, 19, 21, 20, 15], [12, 26, 27, 10, 29, 7], [36, 2, 34, 3, 5, 31]], [[16, 14, 7, 30, 23], [24, 17, 10, 8, 31], [32, 25, 18, 11, 4], [5, 28, 26, 19, 12], [13, 6, 29, 22, 20]], [[1, 14, 4, 15], [8, 11, 5, 10], [13, 2, 16, 3], [12, 7, 9, 6]], [[8, 1, 6], [3, 5, 7], [4, 9, 2]] ] for magic_square in magic_squares: print(DIVIDER_DASH_LINE) if is_magic_square(magic_square) is True: print(f'{GREEN_APPLE} "{magic_square}" is a magic square.') else: print(f'{RED_APPLE} "{magic_square}" is not a magic square.') </code></pre> <h3>Output</h3> <pre><code>-------------------------------------------------- "[[4, 3, 8], [9, 5, 1], [2, 7, 6]]" is a magic square. -------------------------------------------------- "[[9, 3, 22, 16, 15], [2, 21, 20, 14, 8], [25, 19, 13, 7, 1], [18, 12, 6, 5, 24], [11, 10, 4, 23, 17]]" is a magic square. -------------------------------------------------- "[[60, 53, 44, 37, 4, 13, 20, 29], [3, 14, 19, 30, 59, 54, 43, 38], [58, 55, 42, 39, 2, 15, 18, 31], [1, 16, 17, 32, 57, 56, 41, 40], [61, 52, 45, 36, 5, 12, 21, 28], [6, 11, 22, 27, 62, 51, 46, 35], [63, 50, 47, 34, 7, 10, 23, 26], [8, 9, 24, 25, 64, 49, 48, 33]]" is a magic square. -------------------------------------------------- "[[35, 26, 17, 1, 62, 53, 44], [46, 37, 21, 12, 3, 64, 55], [57, 41, 32, 23, 14, 5, 66], [61, 52, 43, 34, 25, 16, 7], [2, 63, 54, 45, 36, 27, 11], [13, 4, 65, 56, 47, 31, 22], [24, 15, 6, 67, 51, 42, 33]]" is not a magic square. -------------------------------------------------- "[[1, 35, 4, 33, 32, 6], [25, 11, 9, 28, 8, 30], [24, 14, 18, 16, 17, 22], [13, 23, 19, 21, 20, 15], [12, 26, 27, 10, 29, 7], [36, 2, 34, 3, 5, 31]]" is a magic square. -------------------------------------------------- "[[16, 14, 7, 30, 23], [24, 17, 10, 8, 31], [32, 25, 18, 11, 4], [5, 28, 26, 19, 12], [13, 6, 29, 22, 20]]" is not a magic square. -------------------------------------------------- "[[1, 14, 4, 15], [8, 11, 5, 10], [13, 2, 16, 3], [12, 7, 9, 6]]" is a magic square. -------------------------------------------------- "[[8, 1, 6], [3, 5, 7], [4, 9, 2]]" is a magic square. </code></pre> <h3>Source</h3> <ul> <li><a href="https://en.wikipedia.org/wiki/Magic_square" rel="noreferrer">Magic Square - Wiki</a></li> </ul>

230972

GOOD_ANSWER

<h3>Problem</h3> <p>Write a method to return a boolean if an input grid is magic square.</p> <hr> <p>A magic square is a <span class="math-container">\$NxN\$</span> square grid (where N is the number of cells on each side) filled with distinct positive integers in the range <span class="math-container">\${1,2,...,n^{2}}\$</span> such that each cell contains a different integer and the sum of the integers in each row, column and diagonal is equal. The sum is called the magic constant or magic sum of the magic square. </p> <p><a href="https://i.stack.imgur.com/cmWko.png" rel="noreferrer"><img src="https://i.stack.imgur.com/cmWko.png" alt="enter image description here"></a></p> <hr> <h3>Code</h3> <p>I've tried to solve the above problem. If you'd like to review the code and provide any change/improvement recommendations please do so, and I'd really appreciate that.</p> <pre><code>from typing import List import numpy as np def is_magic_square(grid: List[List[int]]) -&gt; bool: """Returns a boolean if an input grid is magic square""" try: grid_length = len(grid) magic_sum = float(grid_length * (grid_length ** 2 + 1) / 2) diag_positive, diag_negative = [], [] diag_count_positive = 0 diag_count_negative = grid_length - 1 col_grid = np.zeros(shape=(grid_length, grid_length)) unique_elements = set() for index_row, lists in enumerate(grid): diag_negative.append(lists[diag_count_negative]) diag_count_negative -= 1 if len(grid[index_row]) != grid_length: return False if sum(lists) != magic_sum: return False for index_col in range(grid_length): unique_elements.add(lists[index_col]) col_grid[index_col][index_row] = lists[index_col] if index_col == grid_length and index_row == grid_length - 1 and len(unique_elements) != grid_length ** 2 - 1: return False if index_row == grid_length - 1: sum_col = sum(col_grid) temp_col = np.array([magic_sum] * grid_length) if str(temp_col) != str(sum_col): return False if diag_count_positive == index_row: diag_positive.append(lists[index_row]) diag_count_positive += 1 if diag_count_positive == grid_length and sum(diag_positive) != magic_sum: return False if index_row == grid_length - 1 and sum(diag_negative) != magic_sum: return False except: return False return True if __name__ == '__main__': # ---------------------------- TEST --------------------------- DIVIDER_DASH_LINE = '-' * 50 GREEN_APPLE = '\U0001F34F' RED_APPLE = '\U0001F34E' magic_squares = [ [[4, 3, 8], [9, 5, 1], [2, 7, 6]], [[9, 3, 22, 16, 15], [2, 21, 20, 14, 8], [25, 19, 13, 7, 1], [18, 12, 6, 5, 24], [11, 10, 4, 23, 17]], [[60, 53, 44, 37, 4, 13, 20, 29], [3, 14, 19, 30, 59, 54, 43, 38], [58, 55, 42, 39, 2, 15, 18, 31], [1, 16, 17, 32, 57, 56, 41, 40], [61, 52, 45, 36, 5, 12, 21, 28], [6, 11, 22, 27, 62, 51, 46, 35], [63, 50, 47, 34, 7, 10, 23, 26], [8, 9, 24, 25, 64, 49, 48, 33]], [[35, 26, 17, 1, 62, 53, 44], [46, 37, 21, 12, 3, 64, 55], [57, 41, 32, 23, 14, 5, 66], [61, 52, 43, 34, 25, 16, 7], [2, 63, 54, 45, 36, 27, 11], [13, 4, 65, 56, 47, 31, 22], [24, 15, 6, 67, 51, 42, 33]], [[1, 35, 4, 33, 32, 6], [25, 11, 9, 28, 8, 30], [24, 14, 18, 16, 17, 22], [13, 23, 19, 21, 20, 15], [12, 26, 27, 10, 29, 7], [36, 2, 34, 3, 5, 31]], [[16, 14, 7, 30, 23], [24, 17, 10, 8, 31], [32, 25, 18, 11, 4], [5, 28, 26, 19, 12], [13, 6, 29, 22, 20]], [[1, 14, 4, 15], [8, 11, 5, 10], [13, 2, 16, 3], [12, 7, 9, 6]], [[8, 1, 6], [3, 5, 7], [4, 9, 2]] ] for magic_square in magic_squares: print(DIVIDER_DASH_LINE) if is_magic_square(magic_square) is True: print(f'{GREEN_APPLE} "{magic_square}" is a magic square.') else: print(f'{RED_APPLE} "{magic_square}" is not a magic square.') </code></pre> <h3>Output</h3> <pre><code>-------------------------------------------------- "[[4, 3, 8], [9, 5, 1], [2, 7, 6]]" is a magic square. -------------------------------------------------- "[[9, 3, 22, 16, 15], [2, 21, 20, 14, 8], [25, 19, 13, 7, 1], [18, 12, 6, 5, 24], [11, 10, 4, 23, 17]]" is a magic square. -------------------------------------------------- "[[60, 53, 44, 37, 4, 13, 20, 29], [3, 14, 19, 30, 59, 54, 43, 38], [58, 55, 42, 39, 2, 15, 18, 31], [1, 16, 17, 32, 57, 56, 41, 40], [61, 52, 45, 36, 5, 12, 21, 28], [6, 11, 22, 27, 62, 51, 46, 35], [63, 50, 47, 34, 7, 10, 23, 26], [8, 9, 24, 25, 64, 49, 48, 33]]" is a magic square. -------------------------------------------------- "[[35, 26, 17, 1, 62, 53, 44], [46, 37, 21, 12, 3, 64, 55], [57, 41, 32, 23, 14, 5, 66], [61, 52, 43, 34, 25, 16, 7], [2, 63, 54, 45, 36, 27, 11], [13, 4, 65, 56, 47, 31, 22], [24, 15, 6, 67, 51, 42, 33]]" is not a magic square. -------------------------------------------------- "[[1, 35, 4, 33, 32, 6], [25, 11, 9, 28, 8, 30], [24, 14, 18, 16, 17, 22], [13, 23, 19, 21, 20, 15], [12, 26, 27, 10, 29, 7], [36, 2, 34, 3, 5, 31]]" is a magic square. -------------------------------------------------- "[[16, 14, 7, 30, 23], [24, 17, 10, 8, 31], [32, 25, 18, 11, 4], [5, 28, 26, 19, 12], [13, 6, 29, 22, 20]]" is not a magic square. -------------------------------------------------- "[[1, 14, 4, 15], [8, 11, 5, 10], [13, 2, 16, 3], [12, 7, 9, 6]]" is a magic square. -------------------------------------------------- "[[8, 1, 6], [3, 5, 7], [4, 9, 2]]" is a magic square. </code></pre> <h3>Source</h3> <ul> <li><a href="https://en.wikipedia.org/wiki/Magic_square" rel="noreferrer">Magic Square - Wiki</a></li> </ul>

230972

GOOD_ANSWER

<p>I created this program originally for <a href="https://projecteuler.net/problem=14" rel="nofollow noreferrer">Project Euler 14</a>.</p> <p>Here's the code:</p> <pre><code>from sys import setrecursionlimit setrecursionlimit(10 ** 9) def memo(f): f.cache = {} def _f(*args): if args not in f.cache: f.cache[args] = f(*args) return f.cache[args] return _f @memo def collatz(n): if n == 1: return 1 if n % 2: print(3 * n + 1) return 1 + collatz(3 * n + 1) if not n % 2: print(n // 2) return 1 + collatz(n // 2) if __name__ == '__main__': number = None while True: try: number = input('Please enter a number: ') number = int(number) break except ValueError: print(f'Value has to be an interger instead of "{number}"\n') print('\nThe collatz sequence: ') length = collatz(number) print(f'\nLength of the collatz sequence for {number}: {length}') </code></pre> <p>I would like to make this faster and neater if possible.</p>

232981

GOOD_ANSWER

<p>I am a beginner so please keep it in mind while answering! <strong>For player vs CPU is there any more effective way to make CPU better ??</strong></p> <pre><code>import numpy as np board=['-','-','-', '-','-','-', '-','-','-'] def check_win(): global winner global game_over if board[0]=='X' and board[1]=='X' and board[2]=='X': winner='Player' game_over=True elif board[3]=='X' and board[4]=='X' and board[5]=='X': winner='Player' game_over=True elif board[6]=='X' and board[7]=='X' and board[8]=='X': winner='Player' game_over=True elif board[0]=='X' and board[4]=='X' and board[8]=='X': winner='Player' game_over=True elif board[2]=='X' and board[4]=='X' and board[6]=='X': winner='Player' game_over=True elif board[0]=='X' and board[3]=='X' and board[6]=='X': winner='Player' game_over=True elif board[1]=='X' and board[4]=='X' and board[7]=='X': winner='Player' game_over=True elif board[2]=='X' and board[5]=='X' and board[8]=='X': winner='Player' game_over=True elif board[0]=='O' and board[1]=='O' and board[2]=='O': winner='CPU' game_over=True elif board[3]=='O' and board[4]=='O' and board[5]=='O': winner='CPU' game_over=True elif board[6]=='O' and board[7]=='O' and board[8]=='O': winner='CPU' game_over=True elif board[0]=='O' and board[4]=='O' and board[8]=='O': winner='CPU' game_over=True elif board[2]=='O' and board[4]=='O' and board[6]=='O': winner='CPU' game_over=True elif board[0]=='O' and board[3]=='O' and board[6]=='O': winner='CPU' game_over=True elif board[2]=='O' and board[5]=='O' and board[8]=='O': winner='CPU' game_over=True def res_gm(): board=['-','-','-', '-','-','-', '-','-','-'] play_game() def player_turn(): a=int(input("Enter the position to pux X (1-9) : ")) valid=False while valid==False: if a&lt;=9 and board[a-1]=='-': board[a-1]='X' valid=True elif a=='': print("You Cannot Leave This Empty") else: print("This move is invalid ! ") a=int(input("Enter the position to pux X (1-9) : ")) def Compute(): if board[0]=='O' and board[1]=='O' and board[2]=='-': board[2]='O' main_board() elif board[0]=='O' and board[2]=='O' and board[1]=='-': board[1]='O' main_board() elif board[1]=='O' and board[2]=='O' and board[0]=='-': board[0]='O' main_board() elif board[3]=='O' and board[4]=='O' and board[5]=='-': board[5]='O' main_board() elif board[3]=='O' and board[5]=='O' and board[4]=='-': board[4]='O' main_board() elif board[4]=='O' and board[5]=='O' and board[3]=='-': board[3]='O' main_board() elif board[6]=='O' and board[7]=='O' and board[8]=='-': board[8]='O' main_board() elif board[7]=='O' and board[8]=='O' and board[6]=='-': board[6]='O' main_board() elif board[6]=='O' and board[8]=='O' and board[7]=='-': board[7]='O' main_board() elif board[0]=='O' and board[4]=='O' and board[8]=='-': board[8]='O' main_board() elif board[4]=='O' and board[8]=='O' and board[0]=='-': board[0]='O' main_board() elif board[0]=='O' and board[8]=='O' and board[4]=='-': board[4]='O' main_board() elif board[0]=='X' and board[1]=='X' and board[2]=='-': board[2]='O' main_board() elif board[0]=='X' and board[2]=='X' and board[1]=='-': board[1]='O' main_board() elif board[1]=='X' and board[2]=='X' and board[0]=='-': board[0]='O' main_board() elif board[3]=='X' and board[4]=='X' and board[5]=='-': board[5]='O' main_board() elif board[3]=='X' and board[5]=='X' and board[4]=='-': board[4]='O' main_board() elif board[4]=='X' and board[5]=='X' and board[3]=='-': board[3]='O' main_board() elif board[6]=='X' and board[7]=='X' and board[8]=='-': board[8]='O' main_board() elif board[7]=='X' and board[8]=='X' and board[6]=='-': board[6]='O' main_board() elif board[6]=='X' and board[8]=='X' and board[7]=='-': board[7]='O' main_board() elif board[0]=='X' and board[4]=='X' and board[8]=='-': board[8]='O' main_board() elif board[4]=='X' and board[8]=='X' and board[0]=='-': board[0]='O' main_board() elif board[0]=='X' and board[8]=='X' and board[4]=='-': board[4]='O' main_board() elif board[0]=='X' and board[3]=='X' and board[6]=='-': board[6]='O' main_board() elif board[2]=='X' and board[5]=='X' and board[8]=='-': board[8]='O' main_board() elif board[1]=='X' and board[4]=='X' and board[7]=='-': board[7]='O' main_board() else: valid=False while valid==False: b=np.random.randint(0,9) if board[b]=='-': board[b]='O' main_board() valid=True else: valid=False def main_board(): print(board[0]+'|'+board[1]+'|'+board[2]+' For reference 1|2|3') print(board[3]+'|'+board[4]+'|'+board[5]+' 4|5|6') print(board[6]+'|'+board[7]+'|'+board[8]+' 7|8|9') def play_game(): global game_over global winner main_board() game_over=False n=0 while game_over==False: if n&lt;9 and n%2==0: player_turn() n+=1 check_win() elif n&lt;9 and n%2!=0: Compute() check_win() n=n+1 elif n==9 and board[0]!='-' and board[1]!='-' and board[2]!='-' and board[3]!='-'and board[4]!='-' and board[5]!='-' and board[6]!='-' and board[7]!='-' and board[8]!='-' and game_over==False: print('Tie') winner='None' game_over=True print('The winner is ',winner) print('Choose a game mode : \n1. Player Vs CPU \n2. Player1 vs Player2') q=int(input('Enter the Corresponding number of game mode : ')) while q in [1,2,3]: if q==1: p='y' while p=='y': play_game() p=str(input('Want to play again ? ')) else: print('Exiting Game!') q=3 elif q==2: print('this game mode is not available yet, ask Utkarsh to develop it ') q=int(input('Enter the Corresponding number of game mode : ')) else: quit() else: print('There is no game mode like this ') q=int(input('Enter the Corresponding number of game mode : ')) </code></pre>

236229

GOOD_ANSWER

<p>Wrote a python script to web scrape multiple newspapers and arrange them in their respective directories. I have completed the course Using Python to access web data on coursera and I tried to implement what I learned by a mini project. I am sure there would be multiple improvements to this script and I would like to learn and implement them to better.</p> <pre><code>import urllib.request, urllib.error, urllib.parse from bs4 import BeautifulSoup import ssl import requests import regex as re import os from datetime import date, timedelta today = date.today() ctx = ssl.create_default_context() ctx.check_hostname = False ctx.verify_mode = ssl.CERT_NONE def is_downloadable(url): """ Does the url contain a downloadable resource """ h = requests.head(url, allow_redirects=True) header = h.headers content_type = header.get('content-type') if 'text' in content_type.lower(): return False if 'html' in content_type.lower(): return False return True # dictionary for newspaper names and their links newspaper = dict({'Economic_times':'https://dailyepaper.in/economic-times-epaper-pdf-download-2020/', 'Times_of_India':'https://dailyepaper.in/times-of-india-epaper-pdf-download-2020/', 'Financial_Express':'https://dailyepaper.in/financial-express-epaper-pdf-download-2020/', 'Deccan_Chronicle':'https://dailyepaper.in/deccan-chronicle-epaper-pdf-download-2020/', 'The_Telegraph':'https://dailyepaper.in/the-telegraph-epaper-pdf-download-2020/', 'The_Pioneer':'https://dailyepaper.in/the-pioneer-epaper-pdf-download-2020/', 'Business_Line':'https://dailyepaper.in/business-line-epaper-pdf-download-2020/', 'Indian_Express':'https://dailyepaper.in/indian-express-epaper-pdf-download-2020/', 'Hindustan_Times':'https://dailyepaper.in/hindustan-times-epaper-pdf-free-download-2020/', 'The_Hindu':'https://dailyepaper.in/the-hindu-pdf-newspaper-free-download/', 'Dainik_Jagran':'https://dailyepaper.in/dainik-jagran-newspaper-pdf/', 'Dainik_Bhaskar':'https://dailyepaper.in/dainik-bhaskar-epaper-pdf-download-2020/', 'Amar_Ujala':'https://dailyepaper.in/amar-ujala-epaper-pdf-download-2020/'}) #dictionary to give serial numbers to each newspaper #I think something better could be done instead of this dictionary serial_num = dict({1:'Economic_times', 2:'Times_of_India', 3:'Financial_Express', 4:'Deccan_Chronicle', 5:'The_Telegraph', 6:'The_Pioneer', 7:'Business_Line', 8:'Indian_Express', 9:'Hindustan_Times', 10:'The_Hindu', 11:'Dainik_Jagran', 12:'Dainik_Bhaskar', 13:'Amar_Ujala'}) print("The following Newspapers are available for download. Select any of them by giving number inputs - ") print("1. Economic Times") print("2. Times of India") print("3. Financial Express") print("4. Deccan Chronicle") print("5. The Telegraph") print("6. The Pioneer") print("7. Business Line") print("8. Indian Express") print("9. Hindustan Times") print("10. The Hindu") print("11. Dainik Jagran") print("12. Dainik Bhaskar") print("13. Amar Ujala") #taking serial numbers for multiple nespapers and storing them in a list serial_index = input('Enter the number for newspapers - ') serial_index = serial_index.split() indices = [int(x) for x in serial_index] for ser_ind in indices: url = newspaper[serial_num[ser_ind]] req = urllib.request.Request(url, headers={'User-Agent': 'Mozilla/5.0'}) html = urllib.request.urlopen(req).read() soup = BeautifulSoup(html, 'html.parser') tags = soup('a') list_paper = list() directory = serial_num[ser_ind] parent_dir = os.getcwd() path = os.path.join(parent_dir, directory) #make a new directory for given newspaper, if that exists then do nothing try: os.mkdir(path) except OSError as error: pass os.chdir(path) #enter the directory for newspaper #storing links for given newspaper in a list for i in range(len(tags)): links = tags[i].get('href',None) x = re.search("^https://vk.com/", links) if x: list_paper.append(links) print('For how many days you need the '+ serial_num[ser_ind]+' paper?') print('i.e. if only todays paper press 1, if want whole weeks paper press 7') print('Size of each paper is 5-12MB') for_how_many_days = int(input('Enter your number - ')) for i in range(for_how_many_days): url = list_paper[i] req = urllib.request.Request(url, headers={'User-Agent': 'Mozilla/5.0'}) html = urllib.request.urlopen(req).read() soup = BeautifulSoup(html, 'html.parser') tags = soup('iframe') link = tags[0].get('src',None) date_that_day = today - timedelta(days=i) #getting the date if is_downloadable(link): print('Downloading '+serial_num[ser_ind]+'...') r = requests.get(link, allow_redirects=True) with open(serial_num[ser_ind]+"_"+str(date_that_day)+".pdf",'wb') as f: f.write(r.content) print('Done :)') else: print(serial_num[ser_ind] + ' paper not available for '+ str(date_that_day)) os.chdir('../') #after downloading all the newspapers go back to parent directory <span class="math-container">```</span> </code></pre>

242951

GOOD_ANSWER

<p>Wrote a python script to web scrape multiple newspapers and arrange them in their respective directories. I have completed the course Using Python to access web data on coursera and I tried to implement what I learned by a mini project. I am sure there would be multiple improvements to this script and I would like to learn and implement them to better.</p> <pre><code>import urllib.request, urllib.error, urllib.parse from bs4 import BeautifulSoup import ssl import requests import regex as re import os from datetime import date, timedelta today = date.today() ctx = ssl.create_default_context() ctx.check_hostname = False ctx.verify_mode = ssl.CERT_NONE def is_downloadable(url): """ Does the url contain a downloadable resource """ h = requests.head(url, allow_redirects=True) header = h.headers content_type = header.get('content-type') if 'text' in content_type.lower(): return False if 'html' in content_type.lower(): return False return True # dictionary for newspaper names and their links newspaper = dict({'Economic_times':'https://dailyepaper.in/economic-times-epaper-pdf-download-2020/', 'Times_of_India':'https://dailyepaper.in/times-of-india-epaper-pdf-download-2020/', 'Financial_Express':'https://dailyepaper.in/financial-express-epaper-pdf-download-2020/', 'Deccan_Chronicle':'https://dailyepaper.in/deccan-chronicle-epaper-pdf-download-2020/', 'The_Telegraph':'https://dailyepaper.in/the-telegraph-epaper-pdf-download-2020/', 'The_Pioneer':'https://dailyepaper.in/the-pioneer-epaper-pdf-download-2020/', 'Business_Line':'https://dailyepaper.in/business-line-epaper-pdf-download-2020/', 'Indian_Express':'https://dailyepaper.in/indian-express-epaper-pdf-download-2020/', 'Hindustan_Times':'https://dailyepaper.in/hindustan-times-epaper-pdf-free-download-2020/', 'The_Hindu':'https://dailyepaper.in/the-hindu-pdf-newspaper-free-download/', 'Dainik_Jagran':'https://dailyepaper.in/dainik-jagran-newspaper-pdf/', 'Dainik_Bhaskar':'https://dailyepaper.in/dainik-bhaskar-epaper-pdf-download-2020/', 'Amar_Ujala':'https://dailyepaper.in/amar-ujala-epaper-pdf-download-2020/'}) #dictionary to give serial numbers to each newspaper #I think something better could be done instead of this dictionary serial_num = dict({1:'Economic_times', 2:'Times_of_India', 3:'Financial_Express', 4:'Deccan_Chronicle', 5:'The_Telegraph', 6:'The_Pioneer', 7:'Business_Line', 8:'Indian_Express', 9:'Hindustan_Times', 10:'The_Hindu', 11:'Dainik_Jagran', 12:'Dainik_Bhaskar', 13:'Amar_Ujala'}) print("The following Newspapers are available for download. Select any of them by giving number inputs - ") print("1. Economic Times") print("2. Times of India") print("3. Financial Express") print("4. Deccan Chronicle") print("5. The Telegraph") print("6. The Pioneer") print("7. Business Line") print("8. Indian Express") print("9. Hindustan Times") print("10. The Hindu") print("11. Dainik Jagran") print("12. Dainik Bhaskar") print("13. Amar Ujala") #taking serial numbers for multiple nespapers and storing them in a list serial_index = input('Enter the number for newspapers - ') serial_index = serial_index.split() indices = [int(x) for x in serial_index] for ser_ind in indices: url = newspaper[serial_num[ser_ind]] req = urllib.request.Request(url, headers={'User-Agent': 'Mozilla/5.0'}) html = urllib.request.urlopen(req).read() soup = BeautifulSoup(html, 'html.parser') tags = soup('a') list_paper = list() directory = serial_num[ser_ind] parent_dir = os.getcwd() path = os.path.join(parent_dir, directory) #make a new directory for given newspaper, if that exists then do nothing try: os.mkdir(path) except OSError as error: pass os.chdir(path) #enter the directory for newspaper #storing links for given newspaper in a list for i in range(len(tags)): links = tags[i].get('href',None) x = re.search("^https://vk.com/", links) if x: list_paper.append(links) print('For how many days you need the '+ serial_num[ser_ind]+' paper?') print('i.e. if only todays paper press 1, if want whole weeks paper press 7') print('Size of each paper is 5-12MB') for_how_many_days = int(input('Enter your number - ')) for i in range(for_how_many_days): url = list_paper[i] req = urllib.request.Request(url, headers={'User-Agent': 'Mozilla/5.0'}) html = urllib.request.urlopen(req).read() soup = BeautifulSoup(html, 'html.parser') tags = soup('iframe') link = tags[0].get('src',None) date_that_day = today - timedelta(days=i) #getting the date if is_downloadable(link): print('Downloading '+serial_num[ser_ind]+'...') r = requests.get(link, allow_redirects=True) with open(serial_num[ser_ind]+"_"+str(date_that_day)+".pdf",'wb') as f: f.write(r.content) print('Done :)') else: print(serial_num[ser_ind] + ' paper not available for '+ str(date_that_day)) os.chdir('../') #after downloading all the newspapers go back to parent directory <span class="math-container">```</span> </code></pre>

242951

WIERD

<p>I'm new to programming and this is the first thing I'm doing on my own. I would appreciate it if you could point me ways to optimize this RPG dice roller code in Python!</p> <pre><code>import random def dice_reader(): ##this should read messages like '2 d 6 + 3, 5 d 20 + 2 or just 3 d 8'## message = input('&gt;') reader = message.split(' ') times = reader[0] sides = reader[2] output_with_modifier = [] result = [] if len(reader) == 5: modifier = reader[4] else: modifier = 0 for output in range(int(times)): output = random.randint(1, int(sides)) result.append(output) output_with_modifier = [(int(x) + int(modifier)) for x in result] print(f' Dice rolls: {tuple(result)}') if modifier != 0: print(f' With modifier: {tuple(output_with_modifier)}') end = False while end == False: dice_reader() end_message = input('Again? ') if end_message.lower() == 'no': end = True else: pass </code></pre>

245982

GOOD_ANSWER

<h1>The application</h1> <p>I'm making a small app (currently ~500 lines) to manage and download books and other media items. Each item is uniquely identify by its <code>(downloader, code)</code> tuple and the index (save in a pickled file) contains the title, authors, and tags (e.g. &quot;scfi-fi&quot;, &quot;comedy&quot;) of each item. The &quot;downloader&quot; is a module in a collection of user-made modules to scrape certain pages for metadata (title, authors and tags). For example, the module <code>example_dl</code>, given either the url <code>example.com/book/123</code> or code <code>123</code>, handles scraping <code>example.com</code> for the book with the code/ID of <code>123</code>, namely its metadata and possibly download the book to a directory.</p> <p>The code below contains the dictionary <code>config</code> for global configuration variables (stored in a config file <code>shelf.yaml</code>), a short description of the classes <code>Item</code> and <code>Shelf</code> and the function I'd like to be reviewed, <code>search_item()</code>.</p> <h1>Code</h1> <pre><code>import sys import os import re import argparse import importlib.util import yaml import pickle # Default configurations PATH = os.path.expanduser(&quot;~/.config/shelf&quot;) config = { &quot;config_file&quot;: PATH + &quot;/shelf.yaml&quot;, &quot;index_file&quot;: PATH + &quot;/data/index&quot;, &quot;favorites_file&quot;: PATH + &quot;/data/favorites&quot;, &quot;downloaders_dir&quot;: PATH + &quot;/downloaders&quot;, &quot;data_dir&quot;: PATH + &quot;/data&quot;, &quot;threads&quot;: 10, } class Item: &quot;&quot;&quot;Items stored in the Shelf Attributes: title: title of the media item authors: set of authors tags: set of tags media: media type the item is stored as (e.g. png, md, pdf) &quot;&quot;&quot; title = None authors = None tags = None media = None class Shelf: &quot;&quot;&quot;Shelf containing indexed data of items Attributes: downloaders: a dict of available downloaders index: Shelf indexing containing data about all items saved. Data is read from index file and is as follows: ( (downloader1, code1) : item_1, (downloader2, code2) : item_2 ) &quot;&quot;&quot; global config downloaders = dict() index = dict() favorites = set() verbosity = 0 def search_item( self, title_regex: str, authors: set[str], tags: set[str], blacklist: set[str], broad_search=False, favorites=False, ) -&gt; list[tuple[str, str]]: &quot;&quot;&quot;Search item in index Args: title_regex: regex to search title by authors: set of authors OR comma-separated string tags: set of tags OR comma-separated string broad_search: If False (Default), returns only when *all* tags match. If True, returns when at least 1 tag matches. favorites: only search items in favorties Returns: A 2-tuple containing the downloader and code. For example: (&quot;test_dl&quot;, &quot;test_code&quot;) &quot;&quot;&quot; if self.verbosity &gt;= 2: print( &quot;Searching with:\n&quot; f&quot;\tTitle regex: {title_regex}\n&quot; f&quot;\tAuthors: {authors}\n&quot; f&quot;\tTags: {tags}\n&quot; f&quot;\tBroad search: {broad_search}\n&quot; f&quot;\tFavorites: {favorites}&quot; ) result = None if favorites: # Search in favorites result = self.favorites if self.verbosity &gt;= 2: print(f&quot;Filtered by favorites: {result}&quot;) if title_regex: # Search with title regex result = { (k, v) for (k, v) in self.index if re.match(title_regex, self.index[(k, v)].title) } if self.verbosity &gt;= 2: print(f&quot;Filtered by title regex: {result}&quot;) if authors: # Search by authors (always broad search) if type(authors) == str: authors = set(authors.split(&quot;,&quot;)) if result: result = { (k, v) for (k, v) in result if authors &amp; self.index[(k, v)].authors } else: result = { (k, v) for (k, v) in self.index if authors &amp; self.index[(k, v)].authors } if self.verbosity &gt;= 2: print(f&quot;Filtered by authors: {result}&quot;) if tags: # Search by tags if type(tags) == str: tags = set(tags.split(&quot;,&quot;)) if broad_search: # Broad search if result: result = { (k, v) for (k, v) in result if tags &amp; self.index[(k, v)].tags } else: result = { (k, v) for (k, v) in self.index if tags &amp; self.index[(k, v)].tags } if self.verbosity &gt;= 2: print(f&quot;Filtered by broad_search: {result}&quot;) else: # Normal search if result: result = { (k, v) for (k, v) in result if not (tags - self.index[(k, v)].tags) } else: result = { (k, v) for (k, v) in self.index if not (tags - self.index[(k, v)].tags) } if self.verbosity &gt;= 2: print(f&quot;Filtered by broad_search: {result}&quot;) if blacklist: if type(blacklist) == str: blacklist = set(blacklist.split(&quot;,&quot;)) if result: result = { (k, v) for (k, v) in result if not blacklist &amp; self.index[(k, v)].tags } else: result = { (k, v) for (k, v) in self.index if not blacklist &amp; self.index[(k, v)].tags } return result </code></pre> <h1>Description of <code>search_item</code></h1> <p>The function <code>search_item</code> goes runs the <code>index</code> dictionary through 5 filters (kinda): <code>favorites</code>, <code>title_regex</code>, <code>author</code>, <code>tags</code>, and <code>blacklist</code>. The switches available to affect the search are <code>-t TITLE_REGEX</code>, <code>-a AUTHOR</code>, -T <code>TAGS</code>, <code>--broad-search</code>, <code>--favorites</code>, <code>--blacklist</code>.</p> <h2><code>if result</code></h2> <p>I have <code>if result</code> and <code>else</code> in almost every filter to hopefully improve speed and memory usage, since not every filter is required to be used in a single search.</p> <h2><code>favorites</code></h2> <p>The <code>Shelf</code> object has a <code>set</code> of 2-tuples, each tuple being <code>(downloader, code)</code>. Since <code>favorites</code> is a subset of <code>Shelf.index.keys()</code>, I simply copy the entire <code>set</code> of <code>favorites</code> to be further filtered.</p> <h2><code>title_regex</code> and <code>author</code></h2> <p>These 2 are similar in implementation. The only major difference is that <code>title_regex</code> is matched using <code>re.match(user_defined_regex, titles_in_index)</code>, while author is filtered with `author in set_of_authors.</p> <h2><code>tags</code></h2> <p>The <code>--broad-search</code> switch is only used with the <code>search_book</code> function when <code>tags</code> is used, and is ignored otherwise.</p> <h3>Normal Search</h3> <p>In normal search, <em>all</em> of the provided tags (comma-separated) must match the book's tags to show up in the result.</p> <h3>Broad search</h3> <p>In broad search, books show up in the result if <em>at least 1</em> of the provided tags is found in the book's <code>set</code> of tags.</p> <h2><code>blacklist</code></h2> <p>Basically the inverse of broad search.</p>

255491

GOOD_ANSWER

<h1>The application</h1> <p>I'm making a small app (currently ~500 lines) to manage and download books and other media items. Each item is uniquely identify by its <code>(downloader, code)</code> tuple and the index (save in a pickled file) contains the title, authors, and tags (e.g. &quot;scfi-fi&quot;, &quot;comedy&quot;) of each item. The &quot;downloader&quot; is a module in a collection of user-made modules to scrape certain pages for metadata (title, authors and tags). For example, the module <code>example_dl</code>, given either the url <code>example.com/book/123</code> or code <code>123</code>, handles scraping <code>example.com</code> for the book with the code/ID of <code>123</code>, namely its metadata and possibly download the book to a directory.</p> <p>The code below contains the dictionary <code>config</code> for global configuration variables (stored in a config file <code>shelf.yaml</code>), a short description of the classes <code>Item</code> and <code>Shelf</code> and the function I'd like to be reviewed, <code>search_item()</code>.</p> <h1>Code</h1> <pre><code>import sys import os import re import argparse import importlib.util import yaml import pickle # Default configurations PATH = os.path.expanduser(&quot;~/.config/shelf&quot;) config = { &quot;config_file&quot;: PATH + &quot;/shelf.yaml&quot;, &quot;index_file&quot;: PATH + &quot;/data/index&quot;, &quot;favorites_file&quot;: PATH + &quot;/data/favorites&quot;, &quot;downloaders_dir&quot;: PATH + &quot;/downloaders&quot;, &quot;data_dir&quot;: PATH + &quot;/data&quot;, &quot;threads&quot;: 10, } class Item: &quot;&quot;&quot;Items stored in the Shelf Attributes: title: title of the media item authors: set of authors tags: set of tags media: media type the item is stored as (e.g. png, md, pdf) &quot;&quot;&quot; title = None authors = None tags = None media = None class Shelf: &quot;&quot;&quot;Shelf containing indexed data of items Attributes: downloaders: a dict of available downloaders index: Shelf indexing containing data about all items saved. Data is read from index file and is as follows: ( (downloader1, code1) : item_1, (downloader2, code2) : item_2 ) &quot;&quot;&quot; global config downloaders = dict() index = dict() favorites = set() verbosity = 0 def search_item( self, title_regex: str, authors: set[str], tags: set[str], blacklist: set[str], broad_search=False, favorites=False, ) -&gt; list[tuple[str, str]]: &quot;&quot;&quot;Search item in index Args: title_regex: regex to search title by authors: set of authors OR comma-separated string tags: set of tags OR comma-separated string broad_search: If False (Default), returns only when *all* tags match. If True, returns when at least 1 tag matches. favorites: only search items in favorties Returns: A 2-tuple containing the downloader and code. For example: (&quot;test_dl&quot;, &quot;test_code&quot;) &quot;&quot;&quot; if self.verbosity &gt;= 2: print( &quot;Searching with:\n&quot; f&quot;\tTitle regex: {title_regex}\n&quot; f&quot;\tAuthors: {authors}\n&quot; f&quot;\tTags: {tags}\n&quot; f&quot;\tBroad search: {broad_search}\n&quot; f&quot;\tFavorites: {favorites}&quot; ) result = None if favorites: # Search in favorites result = self.favorites if self.verbosity &gt;= 2: print(f&quot;Filtered by favorites: {result}&quot;) if title_regex: # Search with title regex result = { (k, v) for (k, v) in self.index if re.match(title_regex, self.index[(k, v)].title) } if self.verbosity &gt;= 2: print(f&quot;Filtered by title regex: {result}&quot;) if authors: # Search by authors (always broad search) if type(authors) == str: authors = set(authors.split(&quot;,&quot;)) if result: result = { (k, v) for (k, v) in result if authors &amp; self.index[(k, v)].authors } else: result = { (k, v) for (k, v) in self.index if authors &amp; self.index[(k, v)].authors } if self.verbosity &gt;= 2: print(f&quot;Filtered by authors: {result}&quot;) if tags: # Search by tags if type(tags) == str: tags = set(tags.split(&quot;,&quot;)) if broad_search: # Broad search if result: result = { (k, v) for (k, v) in result if tags &amp; self.index[(k, v)].tags } else: result = { (k, v) for (k, v) in self.index if tags &amp; self.index[(k, v)].tags } if self.verbosity &gt;= 2: print(f&quot;Filtered by broad_search: {result}&quot;) else: # Normal search if result: result = { (k, v) for (k, v) in result if not (tags - self.index[(k, v)].tags) } else: result = { (k, v) for (k, v) in self.index if not (tags - self.index[(k, v)].tags) } if self.verbosity &gt;= 2: print(f&quot;Filtered by broad_search: {result}&quot;) if blacklist: if type(blacklist) == str: blacklist = set(blacklist.split(&quot;,&quot;)) if result: result = { (k, v) for (k, v) in result if not blacklist &amp; self.index[(k, v)].tags } else: result = { (k, v) for (k, v) in self.index if not blacklist &amp; self.index[(k, v)].tags } return result </code></pre> <h1>Description of <code>search_item</code></h1> <p>The function <code>search_item</code> goes runs the <code>index</code> dictionary through 5 filters (kinda): <code>favorites</code>, <code>title_regex</code>, <code>author</code>, <code>tags</code>, and <code>blacklist</code>. The switches available to affect the search are <code>-t TITLE_REGEX</code>, <code>-a AUTHOR</code>, -T <code>TAGS</code>, <code>--broad-search</code>, <code>--favorites</code>, <code>--blacklist</code>.</p> <h2><code>if result</code></h2> <p>I have <code>if result</code> and <code>else</code> in almost every filter to hopefully improve speed and memory usage, since not every filter is required to be used in a single search.</p> <h2><code>favorites</code></h2> <p>The <code>Shelf</code> object has a <code>set</code> of 2-tuples, each tuple being <code>(downloader, code)</code>. Since <code>favorites</code> is a subset of <code>Shelf.index.keys()</code>, I simply copy the entire <code>set</code> of <code>favorites</code> to be further filtered.</p> <h2><code>title_regex</code> and <code>author</code></h2> <p>These 2 are similar in implementation. The only major difference is that <code>title_regex</code> is matched using <code>re.match(user_defined_regex, titles_in_index)</code>, while author is filtered with `author in set_of_authors.</p> <h2><code>tags</code></h2> <p>The <code>--broad-search</code> switch is only used with the <code>search_book</code> function when <code>tags</code> is used, and is ignored otherwise.</p> <h3>Normal Search</h3> <p>In normal search, <em>all</em> of the provided tags (comma-separated) must match the book's tags to show up in the result.</p> <h3>Broad search</h3> <p>In broad search, books show up in the result if <em>at least 1</em> of the provided tags is found in the book's <code>set</code> of tags.</p> <h2><code>blacklist</code></h2> <p>Basically the inverse of broad search.</p>

255491

GOOD_ANSWER

<p>I have recently tried converting a singly linked list from a C program into my own python program. I have tested the code myself but I am still unsure if the program has been converted properly. I would like someone to peer review my code to see if there are any errors in methodology, too many methods, any missing methods, etc.</p> <p>I have tried implementing some of my own singly linked list operations based from the advice from this website: <a href="https://afteracademy.com/blog/types-of-linked-list-and-operation-on-linked-list" rel="nofollow noreferrer">https://afteracademy.com/blog/types-of-linked-list-and-operation-on-linked-list</a></p> <p>The original C Program: <a href="https://people.eng.unimelb.edu.au/ammoffat/ppsaa/c/listops.c" rel="nofollow noreferrer">https://people.eng.unimelb.edu.au/ammoffat/ppsaa/c/listops.c</a></p> <p>My own python code:</p> <pre><code>class Node(): # Node for a single linked list def __init__(self, data): self.data = data self.next = None class LinkedList(): def __init__(self): self.head = None self.foot = None def length(self): '''Returns the length of a linked list.''' current_node = self.head node_total = 0 while (current_node != None): node_total += 1 current_node = current_node.next return node_total def is_empty_list(self): '''Checks if a linked list is empty.''' return self.head == None def stack_insert(self, data): '''Inserts a node at the HEAD of the list; LIFO (Last In, First Out).''' new_node = Node(data) # Makes new_node.next point to next node (defualt None if 1st insertion) new_node.next = self.head # Makes the HEAD of linked list point to new node self.head = new_node if (self.foot == None): # First insertion into linked list; node becomes HEAD &amp; FOOT self.foot = new_node def queue_append(self, data): '''Appends a node at the FOOT of the list; FIFO (First In, First Out).''' new_node = Node(data) if (self.head == None): # First insertion into linked list; node becomes HEAD &amp; FOOT self.head = self.foot = new_node else: # Makes the original last node point to the newly appended node self.foot.next = new_node # Makes the newly appended list as the official FOOT of the linked list self.foot = new_node def insert_after(self, data, index): '''Inserts a NEW node AFTER a specific node indicated by index.''' # Need to ensure provided index is within range if (index &lt; 0): print(&quot;ERROR: 'insert_after' Index cannot be negative!&quot;) return elif (index &gt; (self.length() -1)): print(&quot;ERROR: 'insert_after' Index exceeds linked list range!&quot;) return # Use stack_insert to insert as first item elif (self.is_empty_list()) or (index == 0): self.stack_insert(data) return # Use queue_insert to append as last item elif (index == (self.length() -1)): self.queue_append(data) return new_node = Node(data) prior_node = self.head current_node = self.head search_index = 0 # Keep traversering through nodes until desired node while (search_index != index): prior_node = current_node current_node = current_node.next search_index += 1 # Makes prior node is point to target node prior_node = current_node # Makes current node point to the node AFTER target node (default None of last node) current_node = current_node.next # Makes target node point to newly added node prior_node.next = new_node # Makes newly added node point to original node that WAS AFTER target node new_node.next = current_node def delete_head(self): '''Deletes the HEAD node.''' # Linked list is empty if self.is_empty_list(): return old_head = self.head # Adjusts the head pointer to step past original HEAD self.head = self.head.next if (self.head == None): # The only node just got deleted self.foot = None def delete_foot(self): '''Deletes the FOOT node.''' # Linked list is empty if self.is_empty_list(): return old_foot = self.foot prior_node = self.head current_node = self.head # Need to keep cycling until final node is reached while (current_node.next != None): prior_node = current_node current_node = current_node.next # Adjust newly FOOT node to point to nothing prior_node.next = None # Makes linked list forget about original FOOT node self.foot = prior_node def delete_node(self, index): '''Deletes a target node via index.''' # Linked list is empty if self.is_empty_list(): return # Need to ensure index is within proper range elif (index &lt; 0): print(&quot;ERROR: 'delete_node' Index cannot be negative!&quot;) return elif (index &gt; (self.length() -1)): print(&quot;ERROR: 'delete_node' Index exceeds linked list range&quot;) return prior_node = self.head current_node = self.head search_index = 0 # Keep travsersing though nodes until desired node while (search_index != index): prior_node = current_node current_node = current_node.next search_index += 1 # Adjusts node PRIOR to target node to point to the node the AFTER target node prior_node.next = current_node.next def update_node(self, new_data, index): '''Updates target node data via index.''' # Linked list is empty if self.is_empty_list(): print(&quot;ERROR: 'update_node' Linked list is empty; no node data to update!&quot;) return # Need to ensure index is within proper range elif (index &lt; 0): print(&quot;ERROR: 'update_node' Index cannot be negative!&quot;) return elif (index &gt; (self.length() -1)): print(&quot;ERROR: 'update_node' Index exceeds linked list range!&quot;) current_node = self.head search_index = 0 # Keep traversing through nodes until desired node while (search_index != index): current_node = current_node.next search_index += 1 # Can now change data current_node.data = new_data def get_node_data(self, index): '''Extracts that data from a specific node via index.''' # Linked list is empty if self.is_empty_list(): print(&quot;ERROR: 'update_node' Linked list is empty; no node data to update!&quot;) return # Need to ensure index is within proper range elif (index &lt; 0): print(&quot;ERROR: 'update_node' Index cannot be negative!&quot;) return elif (index &gt; (self.length() -1)): print(&quot;ERROR: 'update_node' Index exceeds linked list range!&quot;) # Index matches HEAD or FOOT if (index == 0): return self.head.data elif (index == (self.length() -1)): return self.foot.data current_node = self.head search_index = 0 # Keep traversing though nodes until desired node while (search_index != index): current_node = current_node.next search_index += 1 return current_node.data </code></pre>

256319

GOOD_ANSWER

<p>I wrote a python program to find if a matrix is a magic square or not. It works, but I can't help feeling like I may have overcomplicated the solution. I have seen other implementations that were a lot shorter, but I was wondering how efficient/inefficient my code is and how I could improve it and/or shorten it to achieve the result I am looking for.</p> <pre><code>def main(): matrix = [[4,9,2], [3,5,7], [8,1,6]] result = loShu(matrix) print(result) def loShu(matrix): i = 0 j = 0 for i in range(0, len(matrix)): for j in range(0, len(matrix[j])): if ((matrix[i][j] &lt; 1) or (matrix[i][j] &gt; 9)): return (&quot;This is not a Lo Shu Magic Square - one of the numbers is invalid&quot;) row1 = matrix[0][0] + matrix[0][1] + matrix[0][2] row2 = matrix[1][0] + matrix[1][1] + matrix[1][2] row3 = matrix[2][0] + matrix[2][1] + matrix[2][2] ver1 = matrix[0][0] + matrix[1][0] + matrix[2][0] ver2 = matrix[0][1] + matrix[1][1] + matrix[2][1] ver3 = matrix[0][2] + matrix[1][2] + matrix[2][2] diag1 = matrix[0][0] + matrix[1][1] + matrix[2][2] diag2 = matrix[0][2] + matrix[1][1] + matrix[2][0] checkList = [row1,row2,row3,ver1,ver2,ver3,diag1,diag2] temp = checkList[0] for x in range (0, len(checkList)): if checkList[x] != temp: return (&quot;This is not a Lo Shu Magic Square&quot;) return (&quot;This is a Lo Shu Magic Square&quot;) main() </code></pre>

259665

WIERDgfsd