url
stringlengths 50
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 64
67
| comments_url
stringlengths 59
62
| events_url
stringlengths 57
60
| html_url
stringlengths 38
43
| id
int64 597k
2.65B
| node_id
stringlengths 18
32
| number
int64 1
6.83k
| title
stringlengths 1
296
| user
dict | labels
listlengths 0
5
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
4
| milestone
dict | comments
int64 0
211
| created_at
stringlengths 20
20
| updated_at
stringlengths 20
20
| closed_at
stringlengths 20
20
⌀ | author_association
stringclasses 3
values | active_lock_reason
stringclasses 4
values | body
stringlengths 0
65.6k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 59
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | draft
bool 2
classes | pull_request
dict | is_pull_request
bool 2
classes | issue_comments
sequencelengths 0
30
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/6826 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6826/labels{/name} | https://api.github.com/repos/psf/requests/issues/6826/comments | https://api.github.com/repos/psf/requests/issues/6826/events | https://github.com/psf/requests/issues/6826 | 2,653,925,463 | I_kwDOABTKOs6eL7BX | 6,826 | multipart/form-data and a generator... | {
"avatar_url": "https://avatars.githubusercontent.com/u/9671839?v=4",
"events_url": "https://api.github.com/users/steve-osfda/events{/privacy}",
"followers_url": "https://api.github.com/users/steve-osfda/followers",
"following_url": "https://api.github.com/users/steve-osfda/following{/other_user}",
"gists_url": "https://api.github.com/users/steve-osfda/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/steve-osfda",
"id": 9671839,
"login": "steve-osfda",
"node_id": "MDQ6VXNlcjk2NzE4Mzk=",
"organizations_url": "https://api.github.com/users/steve-osfda/orgs",
"received_events_url": "https://api.github.com/users/steve-osfda/received_events",
"repos_url": "https://api.github.com/users/steve-osfda/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/steve-osfda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/steve-osfda/subscriptions",
"type": "User",
"url": "https://api.github.com/users/steve-osfda",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-11-13T02:26:25Z | 2024-11-13T02:26:35Z | 2024-11-13T02:26:34Z | NONE | off-topic | I used a generator as an argument to data for Content-Type application/json, and that worked fine.
The problem now is that I need to do this for multipart/form-data, and it appears to not support a generator.
- I tried files={'content': my_generator_func()} and got: a bytes-like object is required, not 'generator'; so it looks like it would have accepted a file descriptor, but not a generator.
- I then tried a generator for the data argument, and set the files argument to a form name and value: files={'encoding': (None, 'base64')} [I read you have to use the files argument to get requests to do multipart/form-data] For that I get the error "Streamed bodies and files are mutually exclusive".
- Just in case, I tried it different ways setting a header for Content-Type multipart/form-data, both with and without it [I had read that setting it yourself can mess up requests.] If I omitted it, it complained it was missing; and if I included it, I got the errors previously specified.
Is it possible to furnish a generator for multipart/form-data? If I have to, I will dump the stream into a file and pass a descriptor to the files argument; but seems that you would have furnished a way to use a generator since it is supported for Content-Type application/json
| {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6826/reactions"
} | https://api.github.com/repos/psf/requests/issues/6826/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6824 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6824/labels{/name} | https://api.github.com/repos/psf/requests/issues/6824/comments | https://api.github.com/repos/psf/requests/issues/6824/events | https://github.com/psf/requests/pull/6824 | 2,646,870,728 | PR_kwDOABTKOs6Ba4Ir | 6,824 | Remove old macOS runners | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | false | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
},
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
] | null | 0 | 2024-11-10T05:51:47Z | 2024-11-10T16:18:37Z | 2024-11-10T16:18:36Z | MEMBER | null | Now that the upstream issue in setup-python is resolved, we can move back to using `macos-latest` for everything. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6824/reactions"
} | https://api.github.com/repos/psf/requests/issues/6824/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6824.diff",
"html_url": "https://github.com/psf/requests/pull/6824",
"merged_at": "2024-11-10T16:18:36Z",
"patch_url": "https://github.com/psf/requests/pull/6824.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6824"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6823 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6823/labels{/name} | https://api.github.com/repos/psf/requests/issues/6823/comments | https://api.github.com/repos/psf/requests/issues/6823/events | https://github.com/psf/requests/issues/6823 | 2,645,533,839 | I_kwDOABTKOs6dr6SP | 6,823 | chunked put using a generator function... | {
"avatar_url": "https://avatars.githubusercontent.com/u/9671839?v=4",
"events_url": "https://api.github.com/users/steve-osfda/events{/privacy}",
"followers_url": "https://api.github.com/users/steve-osfda/followers",
"following_url": "https://api.github.com/users/steve-osfda/following{/other_user}",
"gists_url": "https://api.github.com/users/steve-osfda/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/steve-osfda",
"id": 9671839,
"login": "steve-osfda",
"node_id": "MDQ6VXNlcjk2NzE4Mzk=",
"organizations_url": "https://api.github.com/users/steve-osfda/orgs",
"received_events_url": "https://api.github.com/users/steve-osfda/received_events",
"repos_url": "https://api.github.com/users/steve-osfda/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/steve-osfda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/steve-osfda/subscriptions",
"type": "User",
"url": "https://api.github.com/users/steve-osfda",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 4 | 2024-11-09T03:17:27Z | 2024-11-09T03:53:24Z | 2024-11-09T03:40:37Z | NONE | null | <!-- Summary. -->
I made a generator function that returns str chunks; I passed it to data [...data=my_func()...], and it eventually comes back with the error "memoryview: a bytes-like object is required, not 'str'" (debug statements indicate this is happening on the first yield...)
Documentation indicates this is the way to do it: [https://docs.python-requests.org/en/latest/user/advanced/#chunk-encoded-requests](https://docs.python-requests.org/en/latest/user/advanced/#chunk-encoded-requests)
## Expected Result
<!-- What you expected. -->
No error!
## Actual Result
<!-- What happened instead. -->
The error "memoryview: a bytes-like object is required, not 'str'".
## Reproduction Steps
```python
import requests
def test():
json_preamble='{"field": "value",'
def put()->str:
yield json_preamble
return '"field2": "value2"}' # final chunk...
response=requests.put(some_url, data=put(), headers=some_headers)
test ()
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.1.0"
},
"charset_normalizer": {
"version": "3.0.1"
},
"cryptography": {
"version": "38.0.4"
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.11.2"
},
"platform": {
"release": "6.1.0-26-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30000080",
"version": "23.0.0"
},
"requests": {
"version": "2.28.1"
},
"system_ssl": {
"version": "300000e0"
},
"urllib3": {
"version": "1.26.12"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6823/reactions"
} | https://api.github.com/repos/psf/requests/issues/6823/timeline | null | completed | null | null | false | [
"PS A put using a file descriptor as the data argument (opened 'rb' to a .json file...) works...",
"PPS I also tried returning byte strings, even though the documentation example does not do that, and it also fails, with a 400, bad request...",
"Hi @steve-osfda, this issue was patched in 2.29.0 early last year. If you update to a more recent version, you should no longer encounter this issue.\r\n\r\nI would also suggest double checking your generator is actually producing what you're expecting. Your `return` will not be included in the generator, only the `StopIteration` exception raised at the end. You're only sending `{\"field\": \"value\",'` over the wire which is likely the cause of your 400.",
"That was the ticket for the version that returned bytes! A generator needs an [implicit] return None\r\n\r\nI will run with the bytes-encloded return for now (checking the requests version and act accordingly...) Debian bookworm stable right now uses 2.28.\r\n\r\nThank you so much for your speedy response!\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6822 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6822/labels{/name} | https://api.github.com/repos/psf/requests/issues/6822/comments | https://api.github.com/repos/psf/requests/issues/6822/events | https://github.com/psf/requests/pull/6822 | 2,644,394,245 | PR_kwDOABTKOs6BVj-O | 6,822 | Add HTTP status group properties for response objects | {
"avatar_url": "https://avatars.githubusercontent.com/u/107179925?v=4",
"events_url": "https://api.github.com/users/vengatgs/events{/privacy}",
"followers_url": "https://api.github.com/users/vengatgs/followers",
"following_url": "https://api.github.com/users/vengatgs/following{/other_user}",
"gists_url": "https://api.github.com/users/vengatgs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vengatgs",
"id": 107179925,
"login": "vengatgs",
"node_id": "U_kgDOBmNvlQ",
"organizations_url": "https://api.github.com/users/vengatgs/orgs",
"received_events_url": "https://api.github.com/users/vengatgs/received_events",
"repos_url": "https://api.github.com/users/vengatgs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vengatgs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vengatgs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vengatgs",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-11-08T15:36:37Z | 2024-11-08T16:25:37Z | 2024-11-08T16:24:44Z | NONE | null | ## PR Description:
This PR adds properties (`is_2xx_successful`, `is_5xx_server_error`, etc.) to the HTTP response class for easy classification of HTTP status codes, improving code readability.
## Justification:
- **Improved readability**: Using direct range comparisons like `100 <= self.status_code < 200` makes the code clear and intuitive.
- **Maintaining performance**: The range comparison is efficient and keeps the performance trade-offs minimal while avoiding unnecessary complexity.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6822/reactions"
} | https://api.github.com/repos/psf/requests/issues/6822/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6822.diff",
"html_url": "https://github.com/psf/requests/pull/6822",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6822.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6822"
} | true | [
"No thank you. We're not expanding the API of Requests at this time and the freeze is well documented. Sorry you spent your energy on this"
] |
https://api.github.com/repos/psf/requests/issues/6821 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6821/labels{/name} | https://api.github.com/repos/psf/requests/issues/6821/comments | https://api.github.com/repos/psf/requests/issues/6821/events | https://github.com/psf/requests/pull/6821 | 2,632,082,717 | PR_kwDOABTKOs6Aw0gZ | 6,821 | Alert autofix 1 | {
"avatar_url": "https://avatars.githubusercontent.com/u/183675426?v=4",
"events_url": "https://api.github.com/users/akaday/events{/privacy}",
"followers_url": "https://api.github.com/users/akaday/followers",
"following_url": "https://api.github.com/users/akaday/following{/other_user}",
"gists_url": "https://api.github.com/users/akaday/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/akaday",
"id": 183675426,
"login": "akaday",
"node_id": "U_kgDOCvKqIg",
"organizations_url": "https://api.github.com/users/akaday/orgs",
"received_events_url": "https://api.github.com/users/akaday/received_events",
"repos_url": "https://api.github.com/users/akaday/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/akaday/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akaday/subscriptions",
"type": "User",
"url": "https://api.github.com/users/akaday",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2024-11-04T07:46:39Z | 2024-11-04T11:52:18Z | 2024-11-04T11:52:18Z | NONE | null | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6821/reactions"
} | https://api.github.com/repos/psf/requests/issues/6821/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6821.diff",
"html_url": "https://github.com/psf/requests/pull/6821",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6821.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6821"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6820 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6820/labels{/name} | https://api.github.com/repos/psf/requests/issues/6820/comments | https://api.github.com/repos/psf/requests/issues/6820/events | https://github.com/psf/requests/pull/6820 | 2,630,760,253 | PR_kwDOABTKOs6AtXeH | 6,820 | Update vulnerability disclosure process | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2024-11-02T20:08:00Z | 2024-11-02T20:20:49Z | 2024-11-02T20:13:02Z | MEMBER | null | This PR will move our desired workflow for vulnerability reports to use GitHub's [Security Advisory](https://docs.github.com/en/code-security/getting-started/github-security-features#security-advisories) form. This will hopefully simplify the workflow for reporters by removing the disclosure signing steps and using a standardized UI for reviewing and communicating about in-progress advisories. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6820/reactions"
} | https://api.github.com/repos/psf/requests/issues/6820/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6820.diff",
"html_url": "https://github.com/psf/requests/pull/6820",
"merged_at": "2024-11-02T20:13:02Z",
"patch_url": "https://github.com/psf/requests/pull/6820.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6820"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6819 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6819/labels{/name} | https://api.github.com/repos/psf/requests/issues/6819/comments | https://api.github.com/repos/psf/requests/issues/6819/events | https://github.com/psf/requests/pull/6819 | 2,622,273,505 | PR_kwDOABTKOs6AS34N | 6,819 | Add !r to error messages for improved clarity on file paths | {
"avatar_url": "https://avatars.githubusercontent.com/u/174052782?v=4",
"events_url": "https://api.github.com/users/jjkochan-metro/events{/privacy}",
"followers_url": "https://api.github.com/users/jjkochan-metro/followers",
"following_url": "https://api.github.com/users/jjkochan-metro/following{/other_user}",
"gists_url": "https://api.github.com/users/jjkochan-metro/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jjkochan-metro",
"id": 174052782,
"login": "jjkochan-metro",
"node_id": "U_kgDOCl_Vrg",
"organizations_url": "https://api.github.com/users/jjkochan-metro/orgs",
"received_events_url": "https://api.github.com/users/jjkochan-metro/received_events",
"repos_url": "https://api.github.com/users/jjkochan-metro/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jjkochan-metro/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jjkochan-metro/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jjkochan-metro",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-10-29T20:34:15Z | 2024-10-29T20:34:15Z | null | NONE | null | If leading and/or trailing spaces are included in the file path, they are clearly shown in the error messages because the file path is shown within quotes. If the file path is not shown within quotes, it may be difficult to identify that leading and/or trailing spaces are the cause of the problem. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6819/reactions"
} | https://api.github.com/repos/psf/requests/issues/6819/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6819.diff",
"html_url": "https://github.com/psf/requests/pull/6819",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6819.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6819"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6818 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6818/labels{/name} | https://api.github.com/repos/psf/requests/issues/6818/comments | https://api.github.com/repos/psf/requests/issues/6818/events | https://github.com/psf/requests/pull/6818 | 2,618,862,774 | PR_kwDOABTKOs6AH6KB | 6,818 | Bump github/codeql-action from 3.26.0 to 3.27.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2024-10-28T16:05:21Z | 2024-10-28T16:24:15Z | 2024-10-28T16:24:13Z | CONTRIBUTOR | null | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.27.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>v3.27.0</h2>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>3.27.0 - 22 Oct 2024</h2>
<ul>
<li>Bump the minimum CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/2549">#2549</a></li>
<li>Fix an issue where the <code>upload-sarif</code> Action would fail with "upload-sarif post-action step failed: Input required and not supplied: token" when called in a composite Action that had a different set of inputs to the ones expected by the <code>upload-sarif</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2557">#2557</a></li>
<li>Update default CodeQL bundle version to 2.19.2. <a href="https://redirect.github.com/github/codeql-action/pull/2552">#2552</a></li>
</ul>
<p>See the full <a href="https://github.com/github/codeql-action/blob/v3.27.0/CHANGELOG.md">CHANGELOG.md</a> for more information.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.27.0 - 22 Oct 2024</h2>
<ul>
<li>Bump the minimum CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/2549">#2549</a></li>
<li>Fix an issue where the <code>upload-sarif</code> Action would fail with "upload-sarif post-action step failed: Input required and not supplied: token" when called in a composite Action that had a different set of inputs to the ones expected by the <code>upload-sarif</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2557">#2557</a></li>
<li>Update default CodeQL bundle version to 2.19.2. <a href="https://redirect.github.com/github/codeql-action/pull/2552">#2552</a></li>
</ul>
<h2>3.26.13 - 14 Oct 2024</h2>
<p>No user facing changes.</p>
<h2>3.26.12 - 07 Oct 2024</h2>
<ul>
<li>
<p><em>Upcoming breaking change</em>: Add a deprecation warning for customers using CodeQL version 2.14.5 and earlier. These versions of CodeQL were discontinued on 24 September 2024 alongside GitHub Enterprise Server 3.10, and will be unsupported by CodeQL Action versions 3.27.0 and later and versions 2.27.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/2520">#2520</a></p>
<ul>
<li>
<p>If you are using one of these versions, please update to CodeQL CLI version 2.14.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</p>
</li>
<li>
<p>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.13.5 and 2.14.5, you can replace <code>github/codeql-action/*@v3</code> by <code>github/codeql-action/*@v3.26.11</code> and <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.26.11</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</p>
</li>
</ul>
</li>
</ul>
<h2>3.26.11 - 03 Oct 2024</h2>
<ul>
<li>
<p><em>Upcoming breaking change</em>: Add support for using <code>actions/download-artifact@v4</code> to programmatically consume CodeQL Action debug artifacts.</p>
<p>Starting November 30, 2024, GitHub.com customers will <a href="https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/">no longer be able to use <code>actions/download-artifact@v3</code></a>. Therefore, to avoid breakage, customers who programmatically download the CodeQL Action debug artifacts should set the <code>CODEQL_ACTION_ARTIFACT_V4_UPGRADE</code> environment variable to <code>true</code> and bump <code>actions/download-artifact@v3</code> to <code>actions/download-artifact@v4</code> in their workflows. The CodeQL Action will enable this behavior by default in early November and workflows that have not yet bumped to <code>actions/download-artifact@v3</code> to <code>actions/download-artifact@v4</code> will begin failing then.</p>
<p>This change is currently unavailable for GitHub Enterprise Server customers, as <code>actions/upload-artifact@v4</code> and <code>actions/download-artifact@v4</code> are not yet compatible with GHES.</p>
</li>
<li>
<p>Update default CodeQL bundle version to 2.19.1. <a href="https://redirect.github.com/github/codeql-action/pull/2519">#2519</a></p>
</li>
</ul>
<h2>3.26.10 - 30 Sep 2024</h2>
<ul>
<li>We are rolling out a feature in September/October 2024 that sets up CodeQL using a bundle compressed with <a href="http://facebook.github.io/zstd/">Zstandard</a>. Our aim is to improve the performance of setting up CodeQL. <a href="https://redirect.github.com/github/codeql-action/pull/2502">#2502</a></li>
</ul>
<h2>3.26.9 - 24 Sep 2024</h2>
<p>No user facing changes.</p>
<h2>3.26.8 - 19 Sep 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.19.0. <a href="https://redirect.github.com/github/codeql-action/pull/2483">#2483</a></li>
</ul>
<h2>3.26.7 - 13 Sep 2024</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/662472033e021d55d94146f66f6058822b0b39fd"><code>6624720</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2561">#2561</a> from github/update-v3.27.0-b35b023d9</li>
<li><a href="https://github.com/github/codeql-action/commit/ce7c2b560da6747133b72eb2f33503a6c4da9c15"><code>ce7c2b5</code></a> Update changelog for v3.27.0</li>
<li><a href="https://github.com/github/codeql-action/commit/b35b023d9b1296658ca1bcb95dcd0336f9d23f0b"><code>b35b023</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2552">#2552</a> from github/update-bundle/codeql-bundle-v2.19.2</li>
<li><a href="https://github.com/github/codeql-action/commit/dafc762411c1755f00abee84283eaa85d438af2e"><code>dafc762</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2560">#2560</a> from github/aeisenberg/fix-required-checks</li>
<li><a href="https://github.com/github/codeql-action/commit/0d1eb88b60733b6720210d591c48ebc9e961d42c"><code>0d1eb88</code></a> Remove ESLint from required checks</li>
<li><a href="https://github.com/github/codeql-action/commit/0a30541440699f21b772e5ef95c912f097514855"><code>0a30541</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2558">#2558</a> from github/dependabot/npm_and_yarn/npm-6515e6e328</li>
<li><a href="https://github.com/github/codeql-action/commit/2a6a6ad1c809216132b8a6a8c1f5873fff3f400a"><code>2a6a6ad</code></a> Update checked-in dependencies</li>
<li><a href="https://github.com/github/codeql-action/commit/26c18c2c1f382ccd402aec5dd18d9ff6d0097891"><code>26c18c2</code></a> Bump the npm group with 3 updates</li>
<li><a href="https://github.com/github/codeql-action/commit/7080a68cbca9319f3cf869f12f34acea853ad72d"><code>7080a68</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.19.2</li>
<li><a href="https://github.com/github/codeql-action/commit/63eb7bbf1f65c025536b3e7d083d89c1c161043c"><code>63eb7bb</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2551">#2551</a> from github/cklin/diff-informed-queries-feature</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/eb055d739abdc2e8de2e5f4ba1a8b246daa779aa...662472033e021d55d94146f66f6058822b0b39fd">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6818/reactions"
} | https://api.github.com/repos/psf/requests/issues/6818/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6818.diff",
"html_url": "https://github.com/psf/requests/pull/6818",
"merged_at": "2024-10-28T16:24:12Z",
"patch_url": "https://github.com/psf/requests/pull/6818.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6818"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6817 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6817/labels{/name} | https://api.github.com/repos/psf/requests/issues/6817/comments | https://api.github.com/repos/psf/requests/issues/6817/events | https://github.com/psf/requests/pull/6817 | 2,618,862,456 | PR_kwDOABTKOs6AH6Fd | 6,817 | Bump actions/setup-python from 5.2.0 to 5.3.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2024-10-28T16:05:12Z | 2024-10-28T16:24:26Z | 2024-10-28T16:24:24Z | CONTRIBUTOR | null | Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v5.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add workflow file for publishing releases to immutable action package by <a href="https://github.com/Jcambass"><code>@Jcambass</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/941">actions/setup-python#941</a></li>
<li>Upgrade IA publish by <a href="https://github.com/Jcambass"><code>@Jcambass</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/943">actions/setup-python#943</a></li>
</ul>
<h3>Bug Fixes:</h3>
<ul>
<li>Normalise Line Endings to Ensure Cross-Platform Consistency by <a href="https://github.com/priya-kinthali"><code>@priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/938">actions/setup-python#938</a></li>
<li>Revise <code>isGhes</code> logic by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/963">actions/setup-python#963</a></li>
<li>Bump pillow from 7.2 to 10.2.0 by <a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/956">actions/setup-python#956</a></li>
</ul>
<h3>Enhancements:</h3>
<ul>
<li>Enhance workflows and documentation updates by <a href="https://github.com/priya-kinthali"><code>@priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/965">actions/setup-python#965</a></li>
<li>Bump default versions to latest by <a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/905">actions/setup-python#905</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass"><code>@Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/941">actions/setup-python#941</a></li>
<li><a href="https://github.com/jww3"><code>@jww3</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/963">actions/setup-python#963</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5...v5.3.0">https://github.com/actions/setup-python/compare/v5...v5.3.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/setup-python/commit/0b93645e9fea7318ecaed2b359559ac225c90a2b"><code>0b93645</code></a> Enhance workflows: Add macOS 13 support, upgrade publish-action, and update d...</li>
<li><a href="https://github.com/actions/setup-python/commit/9c76e716502b18322365741b762fee22a8cffad8"><code>9c76e71</code></a> Bump pillow from 7.2 to 10.2.0 in /<strong>tests</strong>/data (<a href="https://redirect.github.com/actions/setup-python/issues/956">#956</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/f4c5a1183d69690d31b6304b7af403a5b56a88d6"><code>f4c5a11</code></a> Revise <code>isGhes</code> logic (<a href="https://redirect.github.com/actions/setup-python/issues/963">#963</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/19dfb7b659fa9e60c2f89c33335ab5f6f1792b6e"><code>19dfb7b</code></a> Bump default versions to latest (<a href="https://redirect.github.com/actions/setup-python/issues/905">#905</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/e9675cc634901ff55d92c575ecd6945e65464b00"><code>e9675cc</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-python/issues/943">#943</a> from actions/Jcambass-patch-1</li>
<li><a href="https://github.com/actions/setup-python/commit/3226af69c08a4851edf81cffc8849d2db148b21f"><code>3226af6</code></a> Upgrade IA publish</li>
<li><a href="https://github.com/actions/setup-python/commit/70dcb22d269dc9546a5d97f4b11548f130526421"><code>70dcb22</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-python/issues/941">#941</a> from actions/Jcambass-patch-1</li>
<li><a href="https://github.com/actions/setup-python/commit/65b48c71155ac3186106d8d8de14787f5914b8d1"><code>65b48c7</code></a> Create publish-immutable-actions.yml</li>
<li><a href="https://github.com/actions/setup-python/commit/29a37be0a3d3e8bf5bc1eb19cd0502922f5b312a"><code>29a37be</code></a> initial commit (<a href="https://redirect.github.com/actions/setup-python/issues/938">#938</a>)</li>
<li>See full diff in <a href="https://github.com/actions/setup-python/compare/f677139bbe7f9c59b41e40162b753c062f5d49a3...0b93645e9fea7318ecaed2b359559ac225c90a2b">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6817/reactions"
} | https://api.github.com/repos/psf/requests/issues/6817/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6817.diff",
"html_url": "https://github.com/psf/requests/pull/6817",
"merged_at": "2024-10-28T16:24:24Z",
"patch_url": "https://github.com/psf/requests/pull/6817.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6817"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6816 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6816/labels{/name} | https://api.github.com/repos/psf/requests/issues/6816/comments | https://api.github.com/repos/psf/requests/issues/6816/events | https://github.com/psf/requests/pull/6816 | 2,617,295,858 | PR_kwDOABTKOs6ACzaU | 6,816 | Refactor and optimize codebase | {
"avatar_url": "https://avatars.githubusercontent.com/u/183675426?v=4",
"events_url": "https://api.github.com/users/akaday/events{/privacy}",
"followers_url": "https://api.github.com/users/akaday/followers",
"following_url": "https://api.github.com/users/akaday/following{/other_user}",
"gists_url": "https://api.github.com/users/akaday/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/akaday",
"id": 183675426,
"login": "akaday",
"node_id": "U_kgDOCvKqIg",
"organizations_url": "https://api.github.com/users/akaday/orgs",
"received_events_url": "https://api.github.com/users/akaday/received_events",
"repos_url": "https://api.github.com/users/akaday/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/akaday/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akaday/subscriptions",
"type": "User",
"url": "https://api.github.com/users/akaday",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-10-28T04:51:39Z | 2024-10-28T04:51:39Z | null | NONE | null | Add new tests for `HTTPAdapter` and hooks.
* **tests/test_adapters.py**
- Add `test_http_adapter_send` to test the `send` method of `HTTPAdapter`.
- Add `test_http_adapter_cert_verify` to test the `cert_verify` method of `HTTPAdapter`.
* **tests/test_hooks.py**
- Add `test_hooks_with_multiple_hooks` to test hooks with multiple functions.
- Add `test_hooks_with_no_hooks` to test hooks with no functions.
---
For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/akaday/requests?shareId=XXXX-XXXX-XXXX-XXXX). | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6816/reactions"
} | https://api.github.com/repos/psf/requests/issues/6816/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6816.diff",
"html_url": "https://github.com/psf/requests/pull/6816",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6816.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6816"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6815 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6815/labels{/name} | https://api.github.com/repos/psf/requests/issues/6815/comments | https://api.github.com/repos/psf/requests/issues/6815/events | https://github.com/psf/requests/issues/6815 | 2,615,368,736 | I_kwDOABTKOs6b41wg | 6,815 | Handle PermissionError when importing adapter.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/46802352?v=4",
"events_url": "https://api.github.com/users/KarelChanivecky/events{/privacy}",
"followers_url": "https://api.github.com/users/KarelChanivecky/followers",
"following_url": "https://api.github.com/users/KarelChanivecky/following{/other_user}",
"gists_url": "https://api.github.com/users/KarelChanivecky/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/KarelChanivecky",
"id": 46802352,
"login": "KarelChanivecky",
"node_id": "MDQ6VXNlcjQ2ODAyMzUy",
"organizations_url": "https://api.github.com/users/KarelChanivecky/orgs",
"received_events_url": "https://api.github.com/users/KarelChanivecky/received_events",
"repos_url": "https://api.github.com/users/KarelChanivecky/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/KarelChanivecky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KarelChanivecky/subscriptions",
"type": "User",
"url": "https://api.github.com/users/KarelChanivecky",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 3 | 2024-10-25T23:51:02Z | 2024-10-26T00:34:54Z | 2024-10-26T00:34:54Z | NONE | null | In Windows, if the running process has restricted permissions the process may not have permission to read the file "C:\\Users\\User\\Documents\\syskeylog.txt". Sounds silly, but this error can propagate through dependencies and prevent them from complete importing, even if the functionality you expect from them do not depend on this project.
## Expected Result
Can import adapter.py
## Actual Result
```
from pypac.parser import PACFile
File "C:\Users\User\python_venvs\companion_app312\Lib\site-packages\pypac\__init__.py", line 20, in <module>
from pypac.api import (
File "C:\Users\User\python_venvs\companion_app312\Lib\site-packages\pypac\api.py", line 7, in <module>
import requests
File "C:\Users\User\python_venvs\companion_app312\Lib\site-packages\requests\__init__.py", line 164, in <module>
from .api import delete, get, head, options, patch, post, put, request
File "C:\Users\User\python_venvs\companion_app312\Lib\site-packages\requests\api.py", line 11, in <module>
from . import sessions
File "C:\Users\User\python_venvs\companion_app312\Lib\site-packages\requests\sessions.py", line 15, in <module>
from .adapters import HTTPAdapter
File "C:\Users\User\python_venvs\companion_app312\Lib\site-packages\requests\adapters.py", line 80, in <module>
_preloaded_ssl_context = create_urllib3_context()
^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\User\python_venvs\companion_app312\Lib\site-packages\urllib3\util\ssl_.py", line 349, in create_urllib3_context
context.keylog_filename = sslkeylogfile
^^^^^^^^^^^^^^^^^^^^^^^
PermissionError: [Errno 13] Permission denied: 'C:\\Users\\User\\Documents\\syskeylog.txt'
```
## Reproduction Steps
Run the following code in Windows. You gotta remove a line and un-indent a block. See comment within the code.
```
import _winapi
import asyncio
import ctypes
import msvcrt
import os
import socket
import subprocess
import sys
import time
import traceback
import winreg
from ctypes import wintypes
from multiprocessing import spawn
from subprocess import Popen
import win32api
import win32con
import win32security
from _ctypes import byref, sizeof
def check_privilege():
# Get the current process token
token = win32security.OpenProcessToken(win32api.GetCurrentProcess(), win32con.TOKEN_QUERY)
# Retrieve the privileges
privileges = win32security.GetTokenInformation(token, win32security.TokenPrivileges)
elevation = win32security.GetTokenInformation(token, win32security.TokenElevation)
print(elevation)
# Check if the required privilege is present
for privilege in privileges:
print(f"{win32security.LookupPrivilegeName(None, privilege[0])} - {privilege[1]}", file=sys.stderr)
return False
def check_groups():
token = win32security.OpenProcessToken(win32api.GetCurrentProcess(), win32con.TOKEN_QUERY)
groups = win32security.GetTokenInformation(token, win32security.TokenGroups)
for group, enabled in groups:
name = win32security.LookupAccountSid(None, group)
print(f"{group} - {name} - {hex(enabled)}", file=sys.stderr)
def _get_token():
# h_token = win32security.LogonUser(
# "nopriv",
# "VAN-917843-PC3",
# "Stillcreekdr123!",
# win32con.LOGON32_LOGON_INTERACTIVE,
# win32con.LOGON32_PROVIDER_DEFAULT
# )
# gid = _get_fnbi_group()
# _add_fnbi_group_user()
system_token = win32security.OpenProcessToken(win32api.GetCurrentProcess(),
win32con.TOKEN_DUPLICATE
| win32con.TOKEN_ADJUST_DEFAULT
| win32con.TOKEN_ADJUST_PRIVILEGES
| win32con.TOKEN_QUERY
| win32con.TOKEN_ASSIGN_PRIMARY
| win32con.TOKEN_ADJUST_GROUPS)
low_integrity_SID = "S-1-16-4096"
# https://learn.microsoft.com/en-ca/windows/win32/api/securitybaseapi/nf-securitybaseapi-createrestrictedtoken
# BOOL CreateRestrictedToken(
# [in] HANDLE ExistingTokenHandle,
# [in] DWORD Flags,
# [in] DWORD DisableSidCount,
# [in, optional] PSID_AND_ATTRIBUTES SidsToDisable,
# [in] DWORD DeletePrivilegeCount,
# [in, optional] PLUID_AND_ATTRIBUTES PrivilegesToDelete,
# [in] DWORD RestrictedSidCount,
# [in, optional] PSID_AND_ATTRIBUTES SidsToRestrict,
# [out] PHANDLE NewTokenHandle
# );
old_groups = win32security.GetTokenInformation(system_token, win32security.TokenGroups)
disabled_sids = []
restricted_sids = []
enabled_masks = {
"S-1-1-0", # everyone
"S-1-5-32-545", # Users - needed for dev only?
"S-1-5-5", # logon session - dev only
}
restricted_masks = {
}
def mask_match(entry: str, mask_set):
for m in mask_set:
if entry.startswith(m):
return True
return False
for g, state in old_groups:
sid_str = str(g).split(":")[1]
if mask_match(sid_str, restricted_masks):
restricted_sids.append((g, 0))
continue
if mask_match(sid_str, enabled_masks):
continue
disabled_sids.append((g, 0))
restricted_token = win32security.CreateRestrictedToken(
system_token,
win32security.DISABLE_MAX_PRIVILEGE, # flags
# None,
disabled_sids, # denied SIDS
None, # privs to delete
restricted_sids # restricted SIDS
)
til = (win32security.CreateWellKnownSid(win32security.WinLowLabelSid), win32security.SE_GROUP_INTEGRITY)
win32security.SetTokenInformation(restricted_token, win32security.TokenIntegrityLevel, til)
return restricted_token
class STARTUPINFO(ctypes.Structure):
_fields_ = [
("cb", wintypes.DWORD), # Size of the structure
("lpReserved", wintypes.LPWSTR), # Reserved; must be NULL
("lpDesktop", wintypes.LPWSTR), # Name of the desktop
("lpTitle", wintypes.LPWSTR), # Title of the window
("dwX", wintypes.DWORD), # X position
("dwY", wintypes.DWORD), # Y position
("dwXSize", wintypes.DWORD), # Width of the window
("dwYSize", wintypes.DWORD), # Height of the window
("dwXCountChars", wintypes.DWORD), # Height of the window
("dwYCountChars", wintypes.DWORD), # Height of the window
("dwFillAttribute", wintypes.DWORD), # Height of the window
("dwFlags", wintypes.DWORD), # Flags
("wShowWindow", wintypes.WORD), # Show window command
("cbReserved2", wintypes.WORD), # Size of the reserved area
("lpReserved2", wintypes.LPBYTE), # Pointer to the reserved area
("hStdInput", wintypes.HANDLE), # Handle to standard input
("hStdOutput", wintypes.HANDLE), # Handle to standard output
("hStdError", wintypes.HANDLE) # Handle to standard error
]
class STARTUPINFOEX(ctypes.Structure):
_fields_ = [
("StartupInfo", STARTUPINFO),
("lpAttributeList", wintypes.LPVOID)
]
# Define PROCESS_INFORMATION structure
class PROCESS_INFORMATION(ctypes.Structure):
_fields_ = [
("hProcess", wintypes.HANDLE),
("hThread", wintypes.HANDLE),
("dwProcessId", wintypes.DWORD),
("dwThreadId", wintypes.DWORD)
]
# Load the function
kernel32 = ctypes.WinDLL('kernel32', use_last_error=True)
advapi32 = ctypes.WinDLL('advapi32', use_last_error=True)
libc = ctypes.CDLL("msvcrt.dll")
# Define SetHandleInformation function
SetHandleInformation = kernel32.SetHandleInformation
SetHandleInformation.argtypes = [
ctypes.wintypes.HANDLE, # hObject
ctypes.wintypes.DWORD, # dwMask
ctypes.wintypes.DWORD # dwFlags
]
SetHandleInformation.restype = ctypes.wintypes.BOOL
CreateProcessW = kernel32.CreateProcessW
CreateProcessAsUser = advapi32.CreateProcessAsUserW
CREATE_UNICODE_ENVIRONMENT = 0x00000400
PROC_THREAD_ATTRIBUTE_LIST = 0x00020000
PROC_THREAD_ATTRIBUTE_HANDLE_LIST = 0x00020004
EXTENDED_STARTUPINFO_PRESENT = 0x00080000
HANDLE_FLAG_INHERIT = 0x00000001
HANDLE_FLAG_PROTECT_FROM_CLOSE = 0x00000002
def get_last_error_message():
error_code = ctypes.get_last_error()
if error_code == 0:
return "No error."
message_buffer = ctypes.create_string_buffer(256)
message_length = kernel32.FormatMessageA(
0x00000001 | 0x00001000, # FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_ALLOCATE_BUFFER
None,
error_code,
0,
byref(message_buffer),
ctypes.sizeof(message_buffer),
None
)
if message_length == 0:
return f"Unknown error code: {error_code}"
msg = message_buffer.value.decode('ansi').replace('\r', '').replace('\n', '')
return msg
foo = None
# Function to get Windows handle from file descriptor
def get_windows_handle(file):
# Get the file descriptor
fd = file.fileno()
# Use _get_osfhandle to get the Windows handle
handle = ctypes.windll.kernel32._get_osfhandle(fd)
if handle == -1:
raise ValueError("Could not get the Windows handle.")
return handle
def make_handle_inheritable(handle):
if not SetHandleInformation(handle, HANDLE_FLAG_INHERIT, HANDLE_FLAG_INHERIT):
raise ctypes.WinError(ctypes.get_last_error())
def writer_main():
def CreateProcess(cmd, cmdline, proc_attr, thread_attr, inherit_handles, creation_flags, current_directory,
environment, startup_info):
# change_privilege(win32con.SE_PRIVILEGE_ENABLED)
# check_privilege()
token = _get_token()
# CreateProcessAsUser
# 0 [in, optional] HANDLE hToken,
# 1 [in, optional] LPCSTR lpApplicationName,
# 2 [in, out, optional] LPSTR lpCommandLine,
# 3 [in, optional] LPSECURITY_ATTRIBUTES lpProcessAttributes,
# 4 [in, optional] LPSECURITY_ATTRIBUTES lpThreadAttributes,
# 5 [in] BOOL bInheritHandles,
# 6 [in] DWORD dwCreationFlags,
# 7 [in, optional] LPVOID lpEnvironment,
# 8 [in, optional] LPCSTR lpCurrentDirectory,
# 9 [in] LPSTARTUPINFOA lpStartupInfo,
# CreateProcess
# 0 [in, optional] LPCSTR lpApplicationName,
# 1 [in, out, optional] LPSTR lpCommandLine,
# 2 [in, optional] LPSECURITY_ATTRIBUTES lpProcessAttributes,
# 3 [in, optional] LPSECURITY_ATTRIBUTES lpThreadAttributes,
# 4 [in] BOOL bInheritHandles,
# 5 [in] DWORD dwCreationFlags,
# 6 [in, optional] LPVOID lpEnvironment,
# 7 [in, optional] LPCSTR lpCurrentDirectory,
# 8 [in] LPSTARTUPINFOA lpStartupInfo,
six = STARTUPINFOEX()
si = six.StartupInfo
si.cb = ctypes.sizeof(STARTUPINFOEX)
attribute_list_size = wintypes.DWORD()
kernel32.InitializeProcThreadAttributeList(None, 1, 0, byref(attribute_list_size))
buffer = (wintypes.BYTE * (attribute_list_size.value + 10))()
six.lpAttributeList = ctypes.cast(buffer, wintypes.LPVOID)
if not six.lpAttributeList:
print(f"HeapAlloc failed with error: {get_last_error_message()}")
raise RuntimeError()
if not kernel32.InitializeProcThreadAttributeList(
byref(buffer),
1,
0,
byref(attribute_list_size)
):
print(f"InitializeProcThreadAttributeList failed with error: {get_last_error_message()}")
raise RuntimeError()
if startup_info is not None:
si.dwFlags |= win32con.STARTF_USESTDHANDLES # Enable standard handle redirection
si.hStdOutput = getattr(startup_info, "hStdOutput") # Redirect standard output
si.hStdInput = getattr(startup_info, "hStdInput") # Redirect standard error
si.hStdError = getattr(startup_info, "hStdError") # Redirect standard error
handle_list = [wintypes.HANDLE(si.hStdOutput), wintypes.HANDLE(si.hStdInput), wintypes.HANDLE(si.hStdError)]
handle_count = len(handle_list)
handles_array = (wintypes.HANDLE * handle_count)(*handle_list) # Create an array of handles
ctypes.windll.kernel32.UpdateProcThreadAttribute(
buffer,
0,
PROC_THREAD_ATTRIBUTE_HANDLE_LIST,
handles_array,
handle_count * sizeof(wintypes.HANDLE),
None,
None
)
pi = PROCESS_INFORMATION()
success = advapi32.CreateProcessAsUserW(
token.handle,
python_exe, cmdline, proc_attr, thread_attr, inherit_handles,
creation_flags | CREATE_UNICODE_ENVIRONMENT,
environment, current_directory, byref(six), byref(pi)
)
# return TemporaryLibPatch.execute_unpatched(CreateProcess,
# python_exe, cmdline, proc_attr, thread_attr, inherit_handles,
# creation_flags,
# environment, current_directory, startup_info
# )
if not success:
print(f"CreateProcessAsUser failed with error: {get_last_error_message()}")
raise RuntimeError()
return pi.hProcess, pi.hThread, pi.dwProcessId, pi.dwThreadId,
file = open(__file__, 'r')
handle = msvcrt.get_osfhandle(file.fileno())
make_handle_inheritable(handle)
_winapi.CreateProcess = CreateProcess
# You can remove the context manager line below. It just wraps around the line above. The Github editor doesn't let me easily remove the indentation of the block....
with TemporaryLibPatch(_winapi, CreateProcess):
def _path_eq(p1, p2):
return p1 == p2 or os.path.normcase(p1) == os.path.normcase(p2)
WINENV = _path_eq(sys.executable, sys._base_executable)
python_exe = spawn.get_executable()
set_pylauncher = False
# FROM multiprocessing module:
# # bpo-35797: When running in a venv, we bypass the redirect
if WINENV and _path_eq(python_exe, sys.executable):
python_exe = sys._base_executable
set_pylauncher = True
os.environ["__PYVENV_LAUNCHER__"] = sys.executable
proc = Popen([
python_exe,
__file__,
"--read",
], stdout=subprocess.PIPE,
stdin=subprocess.PIPE,
shell=False,
close_fds=False
)
if set_pylauncher:
os.unsetenv("__PYVENV_LAUNCHER__")
proc.wait()
def reader_main():
import requests
if __name__ == '__main__':
if len(sys.argv) > 1 and sys.argv[1] == "--read":
reader_main()
else:
writer_main()
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.8"
},
"implementation": {
"name": "CPython",
"version": "3.12.5"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "300000d0"
},
"urllib3": {
"version": "2.2.2"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6815/reactions"
} | https://api.github.com/repos/psf/requests/issues/6815/timeline | null | not_planned | null | null | false | [
"https://github.com/urllib3/urllib3/blob/f9d37add7983d441b151146db447318dff4186c9/src/urllib3/util/ssl_.py#L351-L356\r\n\r\nThis code path is only triggered with that environment variable set. Unset it, and you won't have permissions problems.",
"Thanks for the prompt help!! \r\n\r\nCan I recommend leaving a comment mentioning this at this line?",
"It's in a different project"
] |
https://api.github.com/repos/psf/requests/issues/6814 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6814/labels{/name} | https://api.github.com/repos/psf/requests/issues/6814/comments | https://api.github.com/repos/psf/requests/issues/6814/events | https://github.com/psf/requests/pull/6814 | 2,601,341,152 | PR_kwDOABTKOs5_Qsor | 6,814 | update docs for `timeout` arguments to clarify that it uses seconds | {
"avatar_url": "https://avatars.githubusercontent.com/u/57028336?v=4",
"events_url": "https://api.github.com/users/DetachHead/events{/privacy}",
"followers_url": "https://api.github.com/users/DetachHead/followers",
"following_url": "https://api.github.com/users/DetachHead/following{/other_user}",
"gists_url": "https://api.github.com/users/DetachHead/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DetachHead",
"id": 57028336,
"login": "DetachHead",
"node_id": "MDQ6VXNlcjU3MDI4MzM2",
"organizations_url": "https://api.github.com/users/DetachHead/orgs",
"received_events_url": "https://api.github.com/users/DetachHead/received_events",
"repos_url": "https://api.github.com/users/DetachHead/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DetachHead/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DetachHead/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DetachHead",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-10-21T05:05:25Z | 2024-10-21T05:05:25Z | null | NONE | null | fixes #6813 | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6814/reactions"
} | https://api.github.com/repos/psf/requests/issues/6814/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6814.diff",
"html_url": "https://github.com/psf/requests/pull/6814",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6814.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6814"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6813 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6813/labels{/name} | https://api.github.com/repos/psf/requests/issues/6813/comments | https://api.github.com/repos/psf/requests/issues/6813/events | https://github.com/psf/requests/issues/6813 | 2,601,337,465 | I_kwDOABTKOs6bDUJ5 | 6,813 | `Session.request` documentation does not specify what unit of time the `timeout` argument uses | {
"avatar_url": "https://avatars.githubusercontent.com/u/57028336?v=4",
"events_url": "https://api.github.com/users/DetachHead/events{/privacy}",
"followers_url": "https://api.github.com/users/DetachHead/followers",
"following_url": "https://api.github.com/users/DetachHead/following{/other_user}",
"gists_url": "https://api.github.com/users/DetachHead/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DetachHead",
"id": 57028336,
"login": "DetachHead",
"node_id": "MDQ6VXNlcjU3MDI4MzM2",
"organizations_url": "https://api.github.com/users/DetachHead/orgs",
"received_events_url": "https://api.github.com/users/DetachHead/received_events",
"repos_url": "https://api.github.com/users/DetachHead/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DetachHead/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DetachHead/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DetachHead",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-10-21T05:02:29Z | 2024-10-31T19:23:38Z | null | NONE | null | [the documentation for `requests.request`](https://requests.readthedocs.io/en/latest/api/#requests.request) says this:
> - **timeout** (_[float](https://docs.python.org/3/library/functions.html#float) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple)_) – (optional) How many seconds to wait for the server to send data before giving up, as a float, or a [(connect timeout, read timeout)](https://requests.readthedocs.io/en/latest/user/advanced/#timeouts) tuple.
however [the documentation for the same argument in `Session.request`](https://requests.readthedocs.io/en/latest/api/#requests.Session.request) does not clarify that it uses seconds:
> - **timeout** (_[float](https://docs.python.org/3/library/functions.html#float) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple)_) – (optional) How long to wait for the server to send data before giving up, as a float, or a [(connect timeout, read timeout)](https://requests.readthedocs.io/en/latest/user/advanced/#timeouts) tuple. | null | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6813/reactions"
} | https://api.github.com/repos/psf/requests/issues/6813/timeline | null | null | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/6811 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6811/labels{/name} | https://api.github.com/repos/psf/requests/issues/6811/comments | https://api.github.com/repos/psf/requests/issues/6811/events | https://github.com/psf/requests/pull/6811 | 2,598,402,633 | PR_kwDOABTKOs5_JWLD | 6,811 | Merge pull request #1 from psf/main | {
"avatar_url": "https://avatars.githubusercontent.com/u/113218619?v=4",
"events_url": "https://api.github.com/users/FabianaCampanari/events{/privacy}",
"followers_url": "https://api.github.com/users/FabianaCampanari/followers",
"following_url": "https://api.github.com/users/FabianaCampanari/following{/other_user}",
"gists_url": "https://api.github.com/users/FabianaCampanari/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/FabianaCampanari",
"id": 113218619,
"login": "FabianaCampanari",
"node_id": "U_kgDOBr-UOw",
"organizations_url": "https://api.github.com/users/FabianaCampanari/orgs",
"received_events_url": "https://api.github.com/users/FabianaCampanari/received_events",
"repos_url": "https://api.github.com/users/FabianaCampanari/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/FabianaCampanari/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FabianaCampanari/subscriptions",
"type": "User",
"url": "https://api.github.com/users/FabianaCampanari",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-10-18T21:18:06Z | 2024-10-18T22:08:13Z | 2024-10-18T22:08:13Z | NONE | null | updated | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6811/reactions"
} | https://api.github.com/repos/psf/requests/issues/6811/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6811.diff",
"html_url": "https://github.com/psf/requests/pull/6811",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6811.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6811"
} | true | [
"It looks like this PR may have been opened by mistake. If you have any questions regarding our contribution process, we'd recommend starting [here](https://github.com/psf/requests/blob/main/docs/dev/contributing.rst). I'm going to resolve this since it's not actionable at this time."
] |
https://api.github.com/repos/psf/requests/issues/6810 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6810/labels{/name} | https://api.github.com/repos/psf/requests/issues/6810/comments | https://api.github.com/repos/psf/requests/issues/6810/events | https://github.com/psf/requests/issues/6810 | 2,597,150,655 | I_kwDOABTKOs6azV-_ | 6,810 | Change auth.py to be used in a FIPS system | {
"avatar_url": "https://avatars.githubusercontent.com/u/176612599?v=4",
"events_url": "https://api.github.com/users/Jose-albino/events{/privacy}",
"followers_url": "https://api.github.com/users/Jose-albino/followers",
"following_url": "https://api.github.com/users/Jose-albino/following{/other_user}",
"gists_url": "https://api.github.com/users/Jose-albino/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Jose-albino",
"id": 176612599,
"login": "Jose-albino",
"node_id": "U_kgDOCobk9w",
"organizations_url": "https://api.github.com/users/Jose-albino/orgs",
"received_events_url": "https://api.github.com/users/Jose-albino/received_events",
"repos_url": "https://api.github.com/users/Jose-albino/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Jose-albino/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jose-albino/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Jose-albino",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 1 | 2024-10-18T10:32:43Z | 2024-11-06T16:28:17Z | null | NONE | null | <!-- Summary. -->
## Expected Result
Using the requests to perform a HTTPS action is working in a FIPS environment
<!-- What you expected. -->
## Actual Result
In UNIX environment with fips enabled the MD5 can't be used.
It provides this error
ValueError: [digital envelope routines: EVP_DigestInit_ex] disabled for FIPS
## Solution
Apply this patch in auth.py
`
*** 145,151 ****
def md5_utf8(x):
if isinstance(x, str):
x = x.encode("utf-8")
! return hashlib.md5(x).hexdigest()
hash_utf8 = md5_utf8
elif _algorithm == "SHA":
--- 145,151 ----
def md5_utf8(x):
if isinstance(x, str):
x = x.encode("utf-8")
! return hashlib.md5(x,usedforsecurity=False).hexdigest()
hash_utf8 = md5_utf8
elif _algorithm == "SHA":
`
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6810/reactions"
} | https://api.github.com/repos/psf/requests/issues/6810/timeline | null | null | null | null | false | [
"Could I work on this ticket ?\r\nThe `usedforsecurity` parameter is only available in python >= 3.9. Plan is to set `usedforsecurity` to True only if python version >= 3.9."
] |
https://api.github.com/repos/psf/requests/issues/6809 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6809/labels{/name} | https://api.github.com/repos/psf/requests/issues/6809/comments | https://api.github.com/repos/psf/requests/issues/6809/events | https://github.com/psf/requests/issues/6809 | 2,591,762,146 | I_kwDOABTKOs6aeybi | 6,809 | Retry hangs indefinitely for 503 status code | {
"avatar_url": "https://avatars.githubusercontent.com/u/71135893?v=4",
"events_url": "https://api.github.com/users/HamzaG737/events{/privacy}",
"followers_url": "https://api.github.com/users/HamzaG737/followers",
"following_url": "https://api.github.com/users/HamzaG737/following{/other_user}",
"gists_url": "https://api.github.com/users/HamzaG737/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/HamzaG737",
"id": 71135893,
"login": "HamzaG737",
"node_id": "MDQ6VXNlcjcxMTM1ODkz",
"organizations_url": "https://api.github.com/users/HamzaG737/orgs",
"received_events_url": "https://api.github.com/users/HamzaG737/received_events",
"repos_url": "https://api.github.com/users/HamzaG737/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/HamzaG737/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HamzaG737/subscriptions",
"type": "User",
"url": "https://api.github.com/users/HamzaG737",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-10-16T12:36:00Z | 2024-10-17T16:24:45Z | 2024-10-17T16:24:45Z | NONE | null | When making a GET request to a URL that returns a 503 status code, the retry strategy causes the code to loop indefinitely, regardless of whether the 503 status code is included in the status_forcelist parameter.
## Expected Result
The retry mechanism should follow the configured retry policy (e.g., retry a specified number of times) and eventually raise an error after the maximum retries.
## Actual Result
The code retries indefinitely without raising an exception or stopping.
## Reproduction Steps
```python
import requests
from requests.adapters import HTTPAdapter, Retry
url = "https://www.floraquatic.com/363-eau-de-mer-et-recifal"
session = requests.Session()
retry_strategy = Retry(total=3, backoff_factor=0.5, status_forcelist=[429, 500, 502, 504]) #You can add 503 here, same result is expected
adapter = HTTPAdapter(max_retries=retry_strategy)
session.mount("https://", adapter)
try:
response = session.get(url)
html_content = response.text
except Exception as e:
print(str(e))
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.4.0"
},
"cryptography": {
"version": "43.0.1"
},
"idna": {
"version": "3.10"
},
"implementation": {
"name": "CPython",
"version": "3.11.9"
},
"platform": {
"release": "5.15.0-122-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30300020",
"version": "24.2.1"
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30000020"
},
"urllib3": {
"version": "1.26.20"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/71135893?v=4",
"events_url": "https://api.github.com/users/HamzaG737/events{/privacy}",
"followers_url": "https://api.github.com/users/HamzaG737/followers",
"following_url": "https://api.github.com/users/HamzaG737/following{/other_user}",
"gists_url": "https://api.github.com/users/HamzaG737/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/HamzaG737",
"id": 71135893,
"login": "HamzaG737",
"node_id": "MDQ6VXNlcjcxMTM1ODkz",
"organizations_url": "https://api.github.com/users/HamzaG737/orgs",
"received_events_url": "https://api.github.com/users/HamzaG737/received_events",
"repos_url": "https://api.github.com/users/HamzaG737/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/HamzaG737/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HamzaG737/subscriptions",
"type": "User",
"url": "https://api.github.com/users/HamzaG737",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6809/reactions"
} | https://api.github.com/repos/psf/requests/issues/6809/timeline | null | completed | null | null | false | [
"@HamzaG737 My dear friend,\r\nYes, you are right. When the `Retry() `reaches its limit, it should raise a `RetryError` exception. However, regarding the issue you mentioned, I checked the responses from the URL you provided and noticed that there is a `Retry-After` header in the response, which is set to **3600** (this value is in seconds).\r\n\r\n\r\nThis value is actually set by the server in the response, indicating that you should retry after 3600 seconds.\r\n\r\nHowever, what happens in your example is that the Retry() class in urllib3 has a variable called `respect_retry_after_header`, which is set to `True` by default. If we send a request to the server and the server's response contains the `Retry-After` header, **urllib3**, and consequently **requests**, will wait until this time elapses before sending the next request.\r\n\r\nNow, what you need to do is set the value of this variable to False like this:\r\n```python\r\nretry_strategy = Retry(total=3, backoff_factor=0.5, respect_retry_after_header=False)\r\n``` \r\n\r\nIf this comment helped you and you don't have any further questions, I would appreciate it if you could close this issue.",
"Hello Mahdibaham, \r\n\r\nThank you very much for this solution, it solves indeed my issue. I am closing this issue."
] |
https://api.github.com/repos/psf/requests/issues/6808 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6808/labels{/name} | https://api.github.com/repos/psf/requests/issues/6808/comments | https://api.github.com/repos/psf/requests/issues/6808/events | https://github.com/psf/requests/issues/6808 | 2,579,970,702 | I_kwDOABTKOs6ZxzqO | 6,808 | Double-digit link-local IPv6 zone id raises ValueError | {
"avatar_url": "https://avatars.githubusercontent.com/u/399361?v=4",
"events_url": "https://api.github.com/users/twslankard/events{/privacy}",
"followers_url": "https://api.github.com/users/twslankard/followers",
"following_url": "https://api.github.com/users/twslankard/following{/other_user}",
"gists_url": "https://api.github.com/users/twslankard/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/twslankard",
"id": 399361,
"login": "twslankard",
"node_id": "MDQ6VXNlcjM5OTM2MQ==",
"organizations_url": "https://api.github.com/users/twslankard/orgs",
"received_events_url": "https://api.github.com/users/twslankard/received_events",
"repos_url": "https://api.github.com/users/twslankard/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/twslankard/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/twslankard/subscriptions",
"type": "User",
"url": "https://api.github.com/users/twslankard",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-10-10T22:32:21Z | 2024-10-31T19:23:46Z | null | NONE | null | When making a request to a link-local IPv6 address, it becomes necessary to specify the "zone id" aka "scope id". [RFC 6874](https://www.rfc-editor.org/rfc/rfc6874) specifies zone ids as follows:
> According to IPv6 Scoped Address syntax [[RFC4007](https://www.rfc-editor.org/rfc/rfc4007)], a zone identifier
> is attached to the textual representation of an IPv6 address by
> concatenating "%" followed by <zone_id>, where <zone_id> is a string
> identifying the zone of the address. However, the IPv6 Scoped
> Address Architecture specification gives no precise definition of the
> character set allowed in <zone_id>. There are no rules or de facto
> standards for this. For example, the first Ethernet interface in a
> host might be called %0, %1, %en1, %eth0, or whatever the implementer
> happened to choose.
>
> In a URI, a literal IPv6 address is always embedded between "[" and
> "]". This document specifies how a <zone_id> can be appended to the
> address. According to URI syntax [[RFC3986](https://www.rfc-editor.org/rfc/rfc3986)], "%" is always treated as
> an escape character in a URI, so, according to the established URI
> syntax [[RFC3986](https://www.rfc-editor.org/rfc/rfc3986)] any occurrences of literal "%" symbols in a URI MUST
> be percent-encoded and represented in the form "%25". Thus, the
> scoped address fe80::a%en1 would appear in a URI as
> http://[fe80::a%25en1].
I understand the above to mean that the "zone id" can be multiple characters (even when it's an integer.)
When using `requests.get` to request information from IoT devices using link-local networking, I occasionally see double-digit integer zone ids. An example of such a scoped address is `fe80::be0f:a7ff:fe00:2929%53`. As such, I'm escaping the `%` as `%25` as indicated in the RFC. (In this case, this has no effect on the results.)
## Expected Result
This does not throw.
```
import requests
host = 'fe80::be0f:a7ff:fe00:2929%2553'
url = f'http://[{host}]'
requests.get(url)
```
## Actual Result
It throws:
```
ValueError: 'fe80::be0f:a7ff:fe00:2929S' does not appear to be an IPv4 or IPv6 address
```
Some debugging reveals that `urllib3.util.parse_url` replaces `%25` with `%` in its result.
## Reproduction Steps
1. Run the code in the expected result section.
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.12.3"
},
"platform": {
"release": "6.8.0-40-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30000020"
},
"urllib3": {
"version": "2.2.2"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 1,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6808/reactions"
} | https://api.github.com/repos/psf/requests/issues/6808/timeline | null | null | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/6807 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6807/labels{/name} | https://api.github.com/repos/psf/requests/issues/6807/comments | https://api.github.com/repos/psf/requests/issues/6807/events | https://github.com/psf/requests/issues/6807 | 2,578,757,671 | I_kwDOABTKOs6ZtLgn | 6,807 | what is the point of this line? | {
"avatar_url": "https://avatars.githubusercontent.com/u/12595191?v=4",
"events_url": "https://api.github.com/users/davit555/events{/privacy}",
"followers_url": "https://api.github.com/users/davit555/followers",
"following_url": "https://api.github.com/users/davit555/following{/other_user}",
"gists_url": "https://api.github.com/users/davit555/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davit555",
"id": 12595191,
"login": "davit555",
"node_id": "MDQ6VXNlcjEyNTk1MTkx",
"organizations_url": "https://api.github.com/users/davit555/orgs",
"received_events_url": "https://api.github.com/users/davit555/received_events",
"repos_url": "https://api.github.com/users/davit555/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davit555/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davit555/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davit555",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-10-10T12:51:29Z | 2024-10-10T14:31:55Z | 2024-10-10T14:31:55Z | NONE | null | https://github.com/psf/requests/blame/7335bbf480adc8e6aa88feb2022797a549a00aa3/src/requests/sessions.py#L746 | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6807/reactions"
} | https://api.github.com/repos/psf/requests/issues/6807/timeline | null | not_planned | null | null | false | [
"You have blamed the commit which shows which PR it came from (#1944) which references other issues and PRs. Please follow and read those. Issues are for detects and this is neither a defect nor pointing at a potential one. "
] |
https://api.github.com/repos/psf/requests/issues/6806 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6806/labels{/name} | https://api.github.com/repos/psf/requests/issues/6806/comments | https://api.github.com/repos/psf/requests/issues/6806/events | https://github.com/psf/requests/pull/6806 | 2,566,364,683 | PR_kwDOABTKOs59nxnv | 6,806 | Fix typo in documentation for verify | {
"avatar_url": "https://avatars.githubusercontent.com/u/8417?v=4",
"events_url": "https://api.github.com/users/jonas/events{/privacy}",
"followers_url": "https://api.github.com/users/jonas/followers",
"following_url": "https://api.github.com/users/jonas/following{/other_user}",
"gists_url": "https://api.github.com/users/jonas/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jonas",
"id": 8417,
"login": "jonas",
"node_id": "MDQ6VXNlcjg0MTc=",
"organizations_url": "https://api.github.com/users/jonas/orgs",
"received_events_url": "https://api.github.com/users/jonas/received_events",
"repos_url": "https://api.github.com/users/jonas/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jonas/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jonas/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jonas",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-10-04T13:20:03Z | 2024-10-13T21:12:58Z | null | NONE | null | The code for reference: https://github.com/psf/requests/blob/7335bbf480adc8e6aa88feb2022797a549a00aa3/src/requests/adapters.py#L336
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6806/reactions"
} | https://api.github.com/repos/psf/requests/issues/6806/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6806.diff",
"html_url": "https://github.com/psf/requests/pull/6806",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6806.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6806"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6805 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6805/labels{/name} | https://api.github.com/repos/psf/requests/issues/6805/comments | https://api.github.com/repos/psf/requests/issues/6805/events | https://github.com/psf/requests/pull/6805 | 2,560,495,194 | PR_kwDOABTKOs59UmBW | 6,805 | Remove duplicate .eggs entry in .gitignore | {
"avatar_url": "https://avatars.githubusercontent.com/u/14360110?v=4",
"events_url": "https://api.github.com/users/OmniTroid/events{/privacy}",
"followers_url": "https://api.github.com/users/OmniTroid/followers",
"following_url": "https://api.github.com/users/OmniTroid/following{/other_user}",
"gists_url": "https://api.github.com/users/OmniTroid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/OmniTroid",
"id": 14360110,
"login": "OmniTroid",
"node_id": "MDQ6VXNlcjE0MzYwMTEw",
"organizations_url": "https://api.github.com/users/OmniTroid/orgs",
"received_events_url": "https://api.github.com/users/OmniTroid/received_events",
"repos_url": "https://api.github.com/users/OmniTroid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/OmniTroid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/OmniTroid/subscriptions",
"type": "User",
"url": "https://api.github.com/users/OmniTroid",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-10-02T01:18:38Z | 2024-10-13T21:11:47Z | null | NONE | null | null | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6805/reactions"
} | https://api.github.com/repos/psf/requests/issues/6805/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6805.diff",
"html_url": "https://github.com/psf/requests/pull/6805",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6805.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6805"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6804 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6804/labels{/name} | https://api.github.com/repos/psf/requests/issues/6804/comments | https://api.github.com/repos/psf/requests/issues/6804/events | https://github.com/psf/requests/issues/6804 | 2,558,618,629 | I_kwDOABTKOs6YgWwF | 6,804 | XML gets shortened when submitting a post request | {
"avatar_url": "https://avatars.githubusercontent.com/u/24318105?v=4",
"events_url": "https://api.github.com/users/danster99/events{/privacy}",
"followers_url": "https://api.github.com/users/danster99/followers",
"following_url": "https://api.github.com/users/danster99/following{/other_user}",
"gists_url": "https://api.github.com/users/danster99/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/danster99",
"id": 24318105,
"login": "danster99",
"node_id": "MDQ6VXNlcjI0MzE4MTA1",
"organizations_url": "https://api.github.com/users/danster99/orgs",
"received_events_url": "https://api.github.com/users/danster99/received_events",
"repos_url": "https://api.github.com/users/danster99/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/danster99/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/danster99/subscriptions",
"type": "User",
"url": "https://api.github.com/users/danster99",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-10-01T09:02:13Z | 2024-10-27T18:49:31Z | 2024-10-27T18:49:31Z | NONE | null | I am trying to send an xml in a post request to a SOAP endpoint of a TMS server.
The code is the following:
```
response = requests.post(
url,
data=xml_output,
headers={"Content-Type": "text/xml"},
timeout=60,
cert=(cert_file, decrypted_key_file),
)
```
The server returns a response saying that it got an unexpected end of input in lixe x, char y. The error is dependent on the size of the xml, but is reproducible.
I am attaching 2 XMLs as examples:
EX 1:
```
<?xml version="1.0" ?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:tms="urn:CDM/tmsIntegrationService/" xmlns:sh="http://www.unece.org/cefact/namespaces/StandardBusinessDocumentHeader">
<soapenv:Header>
<wsse:Security xmlns:wsse="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd">
<wsse:UsernameToken>
<wsse:Username>xxx_xxx</wsse:Username>
<wsse:Password>xxxxxxxxxxxxxxxxxxxx</wsse:Password>
</wsse:UsernameToken>
</wsse:Security>
</soapenv:Header>
<soapenv:Body>
<tms:transportInstructionMessage>
<sh:StandardBusinessDocumentHeader>
<sh:HeaderVersion>1</sh:HeaderVersion>
<sh:Sender>
<sh:Identifier>PAWEŁ ZABŁOCKI ZABŁOCKI I PARTNERZY</sh:Identifier>
</sh:Sender>
<sh:Receiver>
<sh:Identifier>Test Identifier</sh:Identifier>
</sh:Receiver>
<sh:DocumentIdentification>
<sh:Standard>GS1</sh:Standard>
<sh:TypeVersion>3.2</sh:TypeVersion>
<sh:InstanceIdentifier>100002</sh:InstanceIdentifier>
<sh:Type>Transport Instruction</sh:Type>
<sh:CreationDateAndTime>2024-10-01T07:58:43Z</sh:CreationDateAndTime>
</sh:DocumentIdentification>
<sh:BusinessScope>
<sh:Scope>
<sh:Type>EDIcustomerNumber</sh:Type>
<sh:InstanceIdentifier>90000050</sh:InstanceIdentifier>
</sh:Scope>
<sh:Scope>
<sh:Type>fileType</sh:Type>
<sh:InstanceIdentifier>IF</sh:InstanceIdentifier>
</sh:Scope>
<sh:Scope>
<sh:Type>department</sh:Type>
<sh:InstanceIdentifier>62</sh:InstanceIdentifier>
</sh:Scope>
<sh:Scope>
<sh:Type>application</sh:Type>
<sh:InstanceIdentifier>LOGI</sh:InstanceIdentifier>
</sh:Scope>
</sh:BusinessScope>
</sh:StandardBusinessDocumentHeader>
<transportInstruction>
<creationDateTime>2024-10-01T07:58:43Z</creationDateTime>
<documentStatusCode>ORIGINAL</documentStatusCode>
<documentActionCode>ADD</documentActionCode>
<transportInstructionIdentification>
<entityIdentification>12345_test/012934535</entityIdentification>
</transportInstructionIdentification>
<transportInstructionFunction>SHIPMENT</transportInstructionFunction>
<logisticServicesSeller/>
<logisticServicesBuyer>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">PAWEŁ ZABŁOCKI ZABŁOCKI I PARTNERZY</additionalPartyIdentification>
</logisticServicesBuyer>
<transportInstructionShipment>
<additionalShipmentIdentification additionalShipmentIdentificationTypeCode="refopd">LC48</additionalShipmentIdentification>
<note languageCode="EN" noteTypeCode="INF"/>
<note languageCode="EN" noteTypeCode="INF">Fragile goods !</note>
<note languageCode="EN" noteTypeCode="INF">Towar niepiętrowalny</note>
<note languageCode="EN" noteTypeCode="INF"/>
<note languageCode="EN" noteTypeCode="INF">Fragile goods !</note>
<note languageCode="EN" noteTypeCode="INF">Towar niepiętrowalny</note>
<receiver>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">3b045ae1-edec-485d-9</additionalPartyIdentification>
<address>
<city>Üllő</city>
<countryCode>HU</countryCode>
<name>AUCHAN MAGYARORSZÁG</name>
<postalCode>2225</postalCode>
<streetAddressOne>Zsaróka út 8</streetAddressOne>
</address>
</receiver>
<shipper>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">ad11a7fc-0442-4b03-8</additionalPartyIdentification>
<address>
<city>WIRY</city>
<countryCode>PL</countryCode>
<name>PAWEŁ ZABŁOCKI ZABŁOCKI I PARTNERZY</name>
<postalCode>62-051</postalCode>
<streetAddressOne>KASZTANOWA 12</streetAddressOne>
</address>
</shipper>
<shipTo>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">3b045ae1-edec-485d-9</additionalPartyIdentification>
<address>
<city>Üllő</city>
<countryCode>HU</countryCode>
<name>AUCHAN MAGYARORSZÁG</name>
<postalCode>2225</postalCode>
<streetAddressOne>Zsaróka út 8</streetAddressOne>
</address>
<contact>
<contactTypeCode>BJ</contactTypeCode>
<personName>John Doe</personName>
<communicationChannel>
<communicationChannelCode>EMAIL</communicationChannelCode>
<communicationValue>john.doe@mail.com</communicationValue>
</communicationChannel>
<communicationChannel>
<communicationChannelCode>TELEPHONE</communicationChannelCode>
<communicationValue>+391234123490</communicationValue>
</communicationChannel>
</contact>
</shipTo>
<shipFrom>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">ad11a7fc-0442-4b03-8</additionalPartyIdentification>
<address>
<city>WIRY</city>
<countryCode>PL</countryCode>
<name>PAWEŁ ZABŁOCKI ZABŁOCKI I PARTNERZY</name>
<postalCode>62-051</postalCode>
<streetAddressOne>KASZTANOWA 12</streetAddressOne>
</address>
</shipFrom>
<transportInstructionTerms>
<transportServiceCategoryType>30</transportServiceCategoryType>
<logisticService>
<logisticServiceRequirementCode logisticServiceTypeCode="parameters">ForPlanning</logisticServiceRequirementCode>
</logisticService>
<logisticService>
<logisticServiceRequirementCode logisticServiceTypeCode="productType">PROD01</logisticServiceRequirementCode>
</logisticService>
<logisticService>
<logisticServiceRequirementCode logisticServiceTypeCode="parameters">ROD</logisticServiceRequirementCode>
</logisticService>
<logisticService>
<logisticServiceRequirementCode logisticServiceTypeCode="parameters">ROP</logisticServiceRequirementCode>
</logisticService>
</transportInstructionTerms>
<plannedDespatch>
<logisticEventPeriod>
<beginDate>2024-10-27</beginDate>
<beginTime>01:10:00</beginTime>
<endDate>2024-10-27</endDate>
<endTime>10:00:00</endTime>
</logisticEventPeriod>
</plannedDespatch>
<transportReference>
<entityIdentification>12345_test/012934535</entityIdentification>
<transportReferenceTypeCode>customerRef</transportReferenceTypeCode>
</transportReference>
<transportInstructionShipmentItem>
<lineItemNumber>1</lineItemNumber>
<transportCargoCharacteristics>
<cargoTypeCode>neam</cargoTypeCode>
<cargoTypeDescription languageCode="PL">Smycze</cargoTypeDescription>
<totalGrossVolume measurementUnitCode="MTQ">7.5</totalGrossVolume>
<totalGrossWeight measurementUnitCode="KGM">5.000</totalGrossWeight>
<totalLoadingLength measurementUnitCode="PP">2.8000000000000003</totalLoadingLength>
<totalPackageQuantity measurementUnitCode="Euro pallet 120x80">7</totalPackageQuantity>
<totalItemQuantity measurementUnitCode="Euro pallet 120x80">7</totalItemQuantity>
</transportCargoCharacteristics>
</transportInstructionShipmentItem>
</transportInstructionShipment>
</transportInstruction>
</tms:transportInstructionMessage>
</soapenv:Body>
</soapenv:Envelope>
```
the error here is unexpected end of input block at row 161, col 15
EX 2:
```
<?xml version="1.0" ?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:tms="urn:CDM/tmsIntegrationService/" xmlns:sh="http://www.unece.org/cefact/namespaces/StandardBusinessDocumentHeader">
<soapenv:Header>
<wsse:Security xmlns:wsse="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-secext-1.0.xsd">
<wsse:UsernameToken>
<wsse:Username>xxx_xxx</wsse:Username>
<wsse:Password>xxxxxxxxxxxxxxxxxxxx</wsse:Password>
</wsse:UsernameToken>
</wsse:Security>
</soapenv:Header>
<soapenv:Body>
<tms:transportInstructionMessage>
<sh:StandardBusinessDocumentHeader>
<sh:HeaderVersion>1</sh:HeaderVersion>
<sh:Sender>
<sh:Identifier>PAWEŁ ZABŁOCKI ZABŁOCKI I PARTNERZY</sh:Identifier>
</sh:Sender>
<sh:Receiver>
<sh:Identifier>Test Identifier</sh:Identifier>
</sh:Receiver>
<sh:DocumentIdentification>
<sh:Standard>GS1</sh:Standard>
<sh:TypeVersion>3.2</sh:TypeVersion>
<sh:InstanceIdentifier>100002</sh:InstanceIdentifier>
<sh:Type>Transport Instruction</sh:Type>
<sh:CreationDateAndTime>2024-10-01T08:06:49Z</sh:CreationDateAndTime>
</sh:DocumentIdentification>
<sh:BusinessScope>
<sh:Scope>
<sh:Type>EDIcustomerNumber</sh:Type>
<sh:InstanceIdentifier>90000050</sh:InstanceIdentifier>
</sh:Scope>
<sh:Scope>
<sh:Type>fileType</sh:Type>
<sh:InstanceIdentifier>IF</sh:InstanceIdentifier>
</sh:Scope>
<sh:Scope>
<sh:Type>department</sh:Type>
<sh:InstanceIdentifier>62</sh:InstanceIdentifier>
</sh:Scope>
<sh:Scope>
<sh:Type>application</sh:Type>
<sh:InstanceIdentifier>LOGI</sh:InstanceIdentifier>
</sh:Scope>
</sh:BusinessScope>
</sh:StandardBusinessDocumentHeader>
<transportInstruction>
<creationDateTime>2024-10-01T08:06:49Z</creationDateTime>
<documentStatusCode>ORIGINAL</documentStatusCode>
<documentActionCode>ADD</documentActionCode>
<transportInstructionIdentification>
<entityIdentification>GV-RD-0099703/1</entityIdentification>
</transportInstructionIdentification>
<transportInstructionFunction>SHIPMENT</transportInstructionFunction>
<logisticServicesSeller/>
<logisticServicesBuyer>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">PAWEŁ ZABŁOCKI ZABŁOCKI I PARTNERZY</additionalPartyIdentification>
</logisticServicesBuyer>
<transportInstructionShipment>
<additionalShipmentIdentification additionalShipmentIdentificationTypeCode="refopd">LC49</additionalShipmentIdentification>
<note languageCode="EN" noteTypeCode="INF"/>
<note languageCode="EN" noteTypeCode="INF">Fragile goods !</note>
<note languageCode="EN" noteTypeCode="INF">Towar niepiętrowalny</note>
<note languageCode="EN" noteTypeCode="INF"/>
<note languageCode="EN" noteTypeCode="INF">Fragile goods !</note>
<note languageCode="EN" noteTypeCode="INF">Towar niepiętrowalny</note>
<receiver>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">669ff966-c2ca-4745-8</additionalPartyIdentification>
<address>
<city>Hrádek</city>
<countryCode>CZ</countryCode>
<name>Borgers Hradek</name>
<postalCode>33842</postalCode>
<streetAddressOne>Rokycanska ulice 223/II</streetAddressOne>
</address>
</receiver>
<shipper>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">ad11a7fc-0442-4b03-8</additionalPartyIdentification>
<address>
<city>WIRY</city>
<countryCode>PL</countryCode>
<name>PAWEŁ ZABŁOCKI ZABŁOCKI I PARTNERZY</name>
<postalCode>62-051</postalCode>
<streetAddressOne>KASZTANOWA 12</streetAddressOne>
</address>
</shipper>
<shipTo>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">669ff966-c2ca-4745-8</additionalPartyIdentification>
<address>
<city>Hrádek</city>
<countryCode>CZ</countryCode>
<name>Borgers Hradek</name>
<postalCode>33842</postalCode>
<streetAddressOne>Rokycanska ulice 223/II</streetAddressOne>
</address>
<contact>
<contactTypeCode>BJ</contactTypeCode>
<personName>John Doe</personName>
<communicationChannel>
<communicationChannelCode>EMAIL</communicationChannelCode>
<communicationValue>john.doe@mail.com</communicationValue>
</communicationChannel>
<communicationChannel>
<communicationChannelCode>TELEPHONE</communicationChannelCode>
<communicationValue>+391231212340</communicationValue>
</communicationChannel>
</contact>
</shipTo>
<shipFrom>
<additionalPartyIdentification additionalPartyIdentificationTypeCode="searchname">ad11a7fc-0442-4b03-8</additionalPartyIdentification>
<address>
<city>WIRY</city>
<countryCode>PL</countryCode>
<name>PAWEŁ ZABŁOCKI ZABŁOCKI I PARTNERZY</name>
<postalCode>62-051</postalCode>
<streetAddressOne>KASZTANOWA 12</streetAddressOne>
</address>
</shipFrom>
<transportInstructionTerms>
<transportServiceCategoryType>30</transportServiceCategoryType>
<logisticService>
<logisticServiceRequirementCode logisticServiceTypeCode="parameters">ForPlanning</logisticServiceRequirementCode>
</logisticService>
<logisticService>
<logisticServiceRequirementCode logisticServiceTypeCode="productType">PROD01</logisticServiceRequirementCode>
</logisticService>
<logisticService>
<logisticServiceRequirementCode logisticServiceTypeCode="parameters">ROD</logisticServiceRequirementCode>
</logisticService>
<logisticService>
<logisticServiceRequirementCode logisticServiceTypeCode="parameters">ROP</logisticServiceRequirementCode>
</logisticService>
</transportInstructionTerms>
<plannedDespatch>
<logisticEventPeriod>
<beginDate>2024-10-10</beginDate>
<beginTime>08:00:00</beginTime>
<endDate>2024-10-10</endDate>
<endTime>22:00:00</endTime>
</logisticEventPeriod>
</plannedDespatch>
<transportReference>
<entityIdentification>GV-RD-0099703/1</entityIdentification>
<transportReferenceTypeCode>customerRef</transportReferenceTypeCode>
</transportReference>
<transportInstructionShipmentItem>
<lineItemNumber>1</lineItemNumber>
<transportCargoCharacteristics>
<cargoTypeCode>neam</cargoTypeCode>
<cargoTypeDescription languageCode="PL">Smycze</cargoTypeDescription>
<totalGrossVolume measurementUnitCode="MTQ">0.00</totalGrossVolume>
<totalGrossWeight measurementUnitCode="KGM">24.500</totalGrossWeight>
<totalLoadingLength measurementUnitCode="PP">2.8000000000000003</totalLoadingLength>
<totalPackageQuantity measurementUnitCode="Euro pallet 120x80">7</totalPackageQuantity>
<totalItemQuantity measurementUnitCode="Euro pallet 120x80">7</totalItemQuantity>
</transportCargoCharacteristics>
</transportInstructionShipmentItem>
</transportInstructionShipment>
</transportInstruction>
</tms:transportInstructionMessage>
</soapenv:Body>
</soapenv:Envelope>
```
here the row is the same but the column is different
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6804/reactions"
} | https://api.github.com/repos/psf/requests/issues/6804/timeline | null | completed | null | null | false | [
"Tried to replicate this using a simple flask server setup using the 2 xmls as above.\r\nThe server did not complain and was able to print out the entire xml that was sent to it.\r\nThat makes me think that there should be no payload limit on the requests client while it sends out the http requests. Do you think there is some chunking happening over your network due to firewall etc? or at your server?\r\n\r\nTest client code:\r\n```py\r\nimport requests\r\nFLASK_LOCAL_URL = \"http://127.0.01:5000/\"\r\n\r\nxml_output = \"\"\"<?xml version=\"1.0\" ?>.... \r\n\"\"\"\r\n\r\nresponse = requests.post(\r\n FLASK_LOCAL_URL,\r\n data=xml_output,\r\n headers={\"Content-Type\": \"text/xml\"},\r\n timeout=60\r\n )\r\n\r\nprint(response)\r\n```\r\nOutput\r\n`<Response [200]>`\r\n\r\nCan you help with instructions on how to reproduce this using a test server?\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6803 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6803/labels{/name} | https://api.github.com/repos/psf/requests/issues/6803/comments | https://api.github.com/repos/psf/requests/issues/6803/events | https://github.com/psf/requests/pull/6803 | 2,557,152,905 | PR_kwDOABTKOs59JQxp | 6,803 | Bump actions/checkout from 4.1.0 to 4.2.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2024-09-30T16:34:21Z | 2024-10-01T06:15:46Z | 2024-09-30T17:32:22Z | CONTRIBUTOR | null | Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome"><code>@lucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
<li>Dependabot updates in <a href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a> & <a href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/yasonk"><code>@yasonk</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1869">actions/checkout#1869</a></li>
<li><a href="https://github.com/lucacome"><code>@lucacome</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.7...v4.2.0">https://github.com/actions/checkout/compare/v4.1.7...v4.2.0</a></p>
<h2>v4.1.7</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a href="https://github.com/orhantoy"><code>@orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/orhantoy"><code>@orhantoy</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.6...v4.1.7">https://github.com/actions/checkout/compare/v4.1.6...v4.1.7</a></p>
<h2>v4.1.6</h2>
<h2>What's Changed</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li>
<li>Update for 4.1.6 release by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1733">actions/checkout#1733</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.5...v4.1.6">https://github.com/actions/checkout/compare/v4.1.5...v4.1.6</a></p>
<h2>v4.1.5</h2>
<h2>What's Changed</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.4...v4.1.5">https://github.com/actions/checkout/compare/v4.1.4...v4.1.5</a></p>
<h2>v4.1.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.3...v4.1.4">https://github.com/actions/checkout/compare/v4.1.3...v4.1.4</a></p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome"><code>@lucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
<li>Dependency updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a href="https://github.com/orhantoy"><code>@orhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li>
</ul>
<h2>v4.1.5</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li>
</ul>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<ul>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685">actions/checkout#1685</a></li>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3"><code>@jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650">actions/checkout#1650</a></li>
</ul>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho"><code>@dscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe"><code>@peterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/d632683dd7b4114ad314bca15554477dd762a938"><code>d632683</code></a> Prepare 4.2.0 release (<a href="https://redirect.github.com/actions/checkout/issues/1878">#1878</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/6d193bf28034eafb982f37bd894289fe649468fc"><code>6d193bf</code></a> Bump braces from 3.0.2 to 3.0.3 (<a href="https://redirect.github.com/actions/checkout/issues/1777">#1777</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/db0cee9a514becbbd4a101a5fbbbf47865ee316c"><code>db0cee9</code></a> Bump the minor-npm-dependencies group across 1 directory with 4 updates (<a href="https://redirect.github.com/actions/checkout/issues/1872">#1872</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/b6849436894e144dbce29d7d7fda2ae3bf9d8365"><code>b684943</code></a> Add Ref and Commit outputs (<a href="https://redirect.github.com/actions/checkout/issues/1180">#1180</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/2d7d9f7ff5b310f983d059b68785b3c74d8b8edd"><code>2d7d9f7</code></a> Provide explanation for where user email came from (<a href="https://redirect.github.com/actions/checkout/issues/1869">#1869</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/9a9194f87191a7e9055e3e9b95b8cfb13023bb08"><code>9a9194f</code></a> Bump docker/build-push-action from 5.3.0 to 6.5.0 (<a href="https://redirect.github.com/actions/checkout/issues/1832">#1832</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/dd960bd3c3f080561a1810e32349ac211ecec7d4"><code>dd960bd</code></a> Bump docker/login-action in the minor-actions-dependencies group (<a href="https://redirect.github.com/actions/checkout/issues/1831">#1831</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/692973e3d937129bcbf40652eb9f2f61becf3332"><code>692973e</code></a> Prepare 4.1.7 release (<a href="https://redirect.github.com/actions/checkout/issues/1775">#1775</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/6ccd57f4c5d15bdc2fef309bd9fb6cc9db2ef1c6"><code>6ccd57f</code></a> Pin actions/checkout's own workflows to a known, good, stable version. (<a href="https://redirect.github.com/actions/checkout/issues/1776">#1776</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/b17fe1e4d59a9d1d95a7aead5e6fcd13e50939a5"><code>b17fe1e</code></a> Handle hidden refs (<a href="https://redirect.github.com/actions/checkout/issues/1774">#1774</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/actions/checkout/compare/8ade135a41bc03ea155e62e844d188df1ea18608...d632683dd7b4114ad314bca15554477dd762a938">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6803/reactions"
} | https://api.github.com/repos/psf/requests/issues/6803/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6803.diff",
"html_url": "https://github.com/psf/requests/pull/6803",
"merged_at": "2024-09-30T17:32:22Z",
"patch_url": "https://github.com/psf/requests/pull/6803.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6803"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6802 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6802/labels{/name} | https://api.github.com/repos/psf/requests/issues/6802/comments | https://api.github.com/repos/psf/requests/issues/6802/events | https://github.com/psf/requests/pull/6802 | 2,533,848,104 | PR_kwDOABTKOs576FoN | 6,802 | start testing on 3.13rc | {
"avatar_url": "https://avatars.githubusercontent.com/u/413772?v=4",
"events_url": "https://api.github.com/users/graingert/events{/privacy}",
"followers_url": "https://api.github.com/users/graingert/followers",
"following_url": "https://api.github.com/users/graingert/following{/other_user}",
"gists_url": "https://api.github.com/users/graingert/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/graingert",
"id": 413772,
"login": "graingert",
"node_id": "MDQ6VXNlcjQxMzc3Mg==",
"organizations_url": "https://api.github.com/users/graingert/orgs",
"received_events_url": "https://api.github.com/users/graingert/received_events",
"repos_url": "https://api.github.com/users/graingert/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/graingert/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/graingert/subscriptions",
"type": "User",
"url": "https://api.github.com/users/graingert",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-09-18T14:05:21Z | 2024-09-19T12:16:35Z | 2024-09-19T11:19:03Z | CONTRIBUTOR | null | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6802/reactions"
} | https://api.github.com/repos/psf/requests/issues/6802/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6802.diff",
"html_url": "https://github.com/psf/requests/pull/6802",
"merged_at": "2024-09-19T11:19:03Z",
"patch_url": "https://github.com/psf/requests/pull/6802.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6802"
} | true | [
"a remake of https://github.com/psf/requests/pull/6720 with the new pytest-httpbin",
"I should probably update the trove classifier "
] |
https://api.github.com/repos/psf/requests/issues/6801 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6801/labels{/name} | https://api.github.com/repos/psf/requests/issues/6801/comments | https://api.github.com/repos/psf/requests/issues/6801/events | https://github.com/psf/requests/pull/6801 | 2,528,749,399 | PR_kwDOABTKOs57otq1 | 6,801 | Teach users to use with-statements for Multipart-Encoded Files | {
"avatar_url": "https://avatars.githubusercontent.com/u/20914054?v=4",
"events_url": "https://api.github.com/users/papb/events{/privacy}",
"followers_url": "https://api.github.com/users/papb/followers",
"following_url": "https://api.github.com/users/papb/following{/other_user}",
"gists_url": "https://api.github.com/users/papb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/papb",
"id": 20914054,
"login": "papb",
"node_id": "MDQ6VXNlcjIwOTE0MDU0",
"organizations_url": "https://api.github.com/users/papb/orgs",
"received_events_url": "https://api.github.com/users/papb/received_events",
"repos_url": "https://api.github.com/users/papb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/papb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/papb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/papb",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-09-16T15:10:29Z | 2024-09-16T23:39:51Z | 2024-09-16T23:39:51Z | NONE | null | Hello, everyone!!
I am proposing a small improvement to `quickstart.rst` in order to teach users to use `with`-statements with `open()` calls when POSTing Multipart-Encoded files. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6801/reactions"
} | https://api.github.com/repos/psf/requests/issues/6801/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6801.diff",
"html_url": "https://github.com/psf/requests/pull/6801",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6801.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6801"
} | true | [
"Changes such as this have been rejected in the past, for good reason. Thanks for spending the time to open this PR. In the future you might consider checking for others that have been rejected "
] |
https://api.github.com/repos/psf/requests/issues/6800 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6800/labels{/name} | https://api.github.com/repos/psf/requests/issues/6800/comments | https://api.github.com/repos/psf/requests/issues/6800/events | https://github.com/psf/requests/issues/6800 | 2,513,371,830 | I_kwDOABTKOs6VzwK2 | 6,800 | AttributeError: 'Request' object has no attribute 'authorize' | {
"avatar_url": "https://avatars.githubusercontent.com/u/155447009?v=4",
"events_url": "https://api.github.com/users/kamarademos/events{/privacy}",
"followers_url": "https://api.github.com/users/kamarademos/followers",
"following_url": "https://api.github.com/users/kamarademos/following{/other_user}",
"gists_url": "https://api.github.com/users/kamarademos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kamarademos",
"id": 155447009,
"login": "kamarademos",
"node_id": "U_kgDOCUPu4Q",
"organizations_url": "https://api.github.com/users/kamarademos/orgs",
"received_events_url": "https://api.github.com/users/kamarademos/received_events",
"repos_url": "https://api.github.com/users/kamarademos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kamarademos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kamarademos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kamarademos",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-09-09T09:02:53Z | 2024-09-09T09:07:20Z | 2024-09-09T09:07:20Z | NONE | null | There seems to be a call to request.authorize. Shouldn't that be request.auth?
```python
import requests
requests.get("https://google.com").raise_for_status()
```
## Error
```
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/home/user/my_lib/__main__.py", line 23, in <module>
requests.get("https://google.com").raise_for_status()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/my_lib/.venv/lib/python3.11/site-packages/requests/api.py", line 73, in get
return request("get", url, params=params, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/my_lib/.venv/lib/python3.11/site-packages/requests/api.py", line 59, in request
return session.request(method=method, url=url, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/my_lib/.venv/lib/python3.11/site-packages/requests/sessions.py", line 575, in request
prep = self.prepare_request(req)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/my_lib/.venv/lib/python3.11/site-packages/requests/sessions.py", line 479, in prepare_request
auth = request.authorize
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.8"
},
"implementation": {
"name": "CPython",
"version": "3.11.9"
},
"platform": {
"release": "6.10.3-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30300010"
},
"urllib3": {
"version": "2.2.2"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/155447009?v=4",
"events_url": "https://api.github.com/users/kamarademos/events{/privacy}",
"followers_url": "https://api.github.com/users/kamarademos/followers",
"following_url": "https://api.github.com/users/kamarademos/following{/other_user}",
"gists_url": "https://api.github.com/users/kamarademos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kamarademos",
"id": 155447009,
"login": "kamarademos",
"node_id": "U_kgDOCUPu4Q",
"organizations_url": "https://api.github.com/users/kamarademos/orgs",
"received_events_url": "https://api.github.com/users/kamarademos/received_events",
"repos_url": "https://api.github.com/users/kamarademos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kamarademos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kamarademos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kamarademos",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6800/reactions"
} | https://api.github.com/repos/psf/requests/issues/6800/timeline | null | completed | null | null | false | [
"Ok. nevermind. my venv was indeed outdated. closing"
] |
https://api.github.com/repos/psf/requests/issues/6799 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6799/labels{/name} | https://api.github.com/repos/psf/requests/issues/6799/comments | https://api.github.com/repos/psf/requests/issues/6799/events | https://github.com/psf/requests/issues/6799 | 2,507,899,117 | I_kwDOABTKOs6Ve4Dt | 6,799 | Python requests: No module named 'werkzeug.wrappers.json' | {
"avatar_url": "https://avatars.githubusercontent.com/u/91322120?v=4",
"events_url": "https://api.github.com/users/reos-rcrozier/events{/privacy}",
"followers_url": "https://api.github.com/users/reos-rcrozier/followers",
"following_url": "https://api.github.com/users/reos-rcrozier/following{/other_user}",
"gists_url": "https://api.github.com/users/reos-rcrozier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/reos-rcrozier",
"id": 91322120,
"login": "reos-rcrozier",
"node_id": "MDQ6VXNlcjkxMzIyMTIw",
"organizations_url": "https://api.github.com/users/reos-rcrozier/orgs",
"received_events_url": "https://api.github.com/users/reos-rcrozier/received_events",
"repos_url": "https://api.github.com/users/reos-rcrozier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/reos-rcrozier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/reos-rcrozier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/reos-rcrozier",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-09-05T14:02:17Z | 2024-09-05T14:02:53Z | 2024-09-05T14:02:52Z | NONE | off-topic | I'm trying to use the requests library in Python, but when I do so, I get an error
```
from werkzeug.wrappers.json import JSONMixin
ModuleNotFoundError: No module named 'werkzeug.wrappers.json'
```
Below is an example (using a repo I forked specially for this, and a very fine grained access token that will expire soon, in case you're concerned about me sharing it).
```
import requests
import json
# GitHub API URL to create an issue in the crobarcro/Spoon-Knife repository
url = 'https://api.github.com/repos/crobarcro/Spoon-Knife/issues'
# Example payload for creating a GitHub issue
payload = {
"title": "Test Issue from API",
"body": "This is a test issue created via the GitHub API in the crobarcro/Spoon-Knife repository.",
"assignees": [], # You can assign this to specific users if needed
"labels": ["bug"] # Optional, you can add labels to the issue
}
# Headers with authentication (you need a GitHub token)
headers = {
'Authorization': 'token ithub_pat_11AAYDNDA0SY1bhpNdK0uf_lozcWrMafgMe2RLe5foWudokRkMrCExRHovDM4cWog3JNIK4MZZeJWN5MGW', # Replace with your GitHub token
'Accept': 'application/vnd.github.v3+json',
'Content-Type': 'application/json'
}
# Sending the POST request
response = requests.post(url, headers=headers, data=json.dumps(payload))
# Checking the response
if response.status_code == 201:
print('Issue created successfully:', response.json())
else:
print(f'Failed to create issue. Status code {response.status_code}:', response.text)
```
The full error message:
```
Traceback (most recent call last):
File "/snap/pycharm-community/405/plugins/python-ce/helpers/pycharm/_jb_pytest_runner.py", line 75, in <module>
sys.exit(pytest.main(args, plugins_to_load + [Plugin]))
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/config/__init__.py", line 159, in main
config = _prepareconfig(args, plugins)
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/config/__init__.py", line 346, in _prepareconfig
config = pluginmanager.hook.pytest_cmdline_parse(
File "/home/<redacted>/.local/lib/python3.10/site-packages/pluggy/_hooks.py", line 513, in __call__
return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
File "/home/<redacted>/.local/lib/python3.10/site-packages/pluggy/_manager.py", line 120, in _hookexec
return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
File "/home/<redacted>/.local/lib/python3.10/site-packages/pluggy/_callers.py", line 139, in _multicall
raise exception.with_traceback(exception.__traceback__)
File "/home/<redacted>/.local/lib/python3.10/site-packages/pluggy/_callers.py", line 122, in _multicall
teardown.throw(exception) # type: ignore[union-attr]
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/helpconfig.py", line 106, in pytest_cmdline_parse
config = yield
File "/home/<redacted>/.local/lib/python3.10/site-packages/pluggy/_callers.py", line 103, in _multicall
res = hook_impl.function(*args)
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1152, in pytest_cmdline_parse
self.parse(args)
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1501, in parse
self._preparse(args, addopts=addopts)
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/config/__init__.py", line 1388, in _preparse
self.pluginmanager.load_setuptools_entrypoints("pytest11")
File "/home/<redacted>/.local/lib/python3.10/site-packages/pluggy/_manager.py", line 421, in load_setuptools_entrypoints
plugin = ep.load()
File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
module = import_module(match.group('module'))
File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/assertion/rewrite.py", line 178, in exec_module
exec(co, module.__dict__)
File "/home/<redacted>/.local/lib/python3.10/site-packages/schemathesis/__init__.py", line 2, in <module>
from ._hypothesis import init_default_strategies, register_string_format
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/assertion/rewrite.py", line 178, in exec_module
exec(co, module.__dict__)
File "/home/<redacted>/.local/lib/python3.10/site-packages/schemathesis/_hypothesis.py", line 13, in <module>
from . import utils
File "/home/<redacted>/.local/lib/python3.10/site-packages/_pytest/assertion/rewrite.py", line 178, in exec_module
exec(co, module.__dict__)
File "/home/<redacted>/.local/lib/python3.10/site-packages/schemathesis/utils.py", line 17, in <module>
from werkzeug.wrappers.json import JSONMixin
ModuleNotFoundError: No module named 'werkzeug.wrappers.json'
```
Some version information:
```
$ pip show werkzeug
Name: Werkzeug
Version: 3.0.4
Summary: The comprehensive WSGI web application library.
Home-page:
Author:
Author-email:
License:
Location: /home/rcrozier/.local/lib/python3.10/site-packages
Requires: MarkupSafe
Required-by: Flask, schemathesis
$ pip show requests
Name: requests
Version: 2.32.3
Summary: Python HTTP for Humans.
Home-page: https://requests.readthedocs.io
Author: Kenneth Reitz
Author-email: me@kennethreitz.org
License: Apache-2.0
Location: /home/rcrozier/.local/lib/python3.10/site-packages
Requires: certifi, charset-normalizer, idna, urllib3
Required-by: CacheControl, greenbyteapi, schemathesis, zohocrmsdk2-0
```
I'm using Linux Mint 21.2
Am I making a mistake here?
| {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6799/reactions"
} | https://api.github.com/repos/psf/requests/issues/6799/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6798 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6798/labels{/name} | https://api.github.com/repos/psf/requests/issues/6798/comments | https://api.github.com/repos/psf/requests/issues/6798/events | https://github.com/psf/requests/issues/6798 | 2,506,668,843 | I_kwDOABTKOs6VaLsr | 6,798 | Environment variables take precedence over the explicitly passed proxies argument in session.get() | {
"avatar_url": "https://avatars.githubusercontent.com/u/174820106?v=4",
"events_url": "https://api.github.com/users/pracon-cmd/events{/privacy}",
"followers_url": "https://api.github.com/users/pracon-cmd/followers",
"following_url": "https://api.github.com/users/pracon-cmd/following{/other_user}",
"gists_url": "https://api.github.com/users/pracon-cmd/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pracon-cmd",
"id": 174820106,
"login": "pracon-cmd",
"node_id": "U_kgDOCmuLCg",
"organizations_url": "https://api.github.com/users/pracon-cmd/orgs",
"received_events_url": "https://api.github.com/users/pracon-cmd/received_events",
"repos_url": "https://api.github.com/users/pracon-cmd/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pracon-cmd/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pracon-cmd/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pracon-cmd",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-09-05T03:05:54Z | 2024-09-05T03:06:06Z | 2024-09-05T03:06:06Z | NONE | off-topic | Environment:
**uname -a**
Linux 6.1.0-25-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.106-3 (2024-08-26) x86_64 GNU/Linux
**pip list**
Package Version
------------------ ---------
certifi 2024.8.30
charset-normalizer 3.3.2
idna 3.8
pip 23.0.1
requests 2.32.3
setuptools 66.1.1
urllib3 2.2.2
Is that normal that the Environment variables: HTTP_PROXY and HTTPS_PROXY would override the proxies argument passed to session.get()?
test code:
`import requests
import os
# Disable environment proxies temporarily
#os.environ.pop('https_proxy', None)
#os.environ.pop('http_proxy', None)
# get all environs
print(os.environ)
# Define a test URL (you can replace this with a URL of your choice)
test_url = 'http://httpbin.org/ip'
# Define your custom proxies
my_proxies = None
# Create a session
session = requests.Session()
# Test session.get with explicitly defined proxies
print("=== Session GET with my_proxies ===")
response = session.get(url=test_url, proxies=my_proxies)
# Print the result (should reflect the proxy being used)
print(f'Your IP (using my_proxies): {response.json().get("origin")}')`
Run it and you will notice that the session uses the proxy server instead of None (specified by my_proxies = None) | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6798/reactions"
} | https://api.github.com/repos/psf/requests/issues/6798/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6797 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6797/labels{/name} | https://api.github.com/repos/psf/requests/issues/6797/comments | https://api.github.com/repos/psf/requests/issues/6797/events | https://github.com/psf/requests/pull/6797 | 2,501,341,172 | PR_kwDOABTKOs56LuQZ | 6,797 | Bump actions/setup-python from 5.1.0 to 5.2.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2024-09-02T16:56:27Z | 2024-09-29T17:42:07Z | 2024-09-02T17:37:45Z | CONTRIBUTOR | null | Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.0 to 5.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v5.2.0</h2>
<h2>What's Changed</h2>
<h3>Bug fixes:</h3>
<ul>
<li>Add <code>.zip</code> extension to Windows package downloads for <code>Expand-Archive</code> Compatibility by <a href="https://github.com/priyagupta108"><code>@priyagupta108</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/916">actions/setup-python#916</a>
This addresses compatibility issues on Windows self-hosted runners by ensuring that the filenames for Python and PyPy package downloads explicitly include the .zip extension, allowing the Expand-Archive command to function correctly.</li>
<li>Add arch to cache key by <a href="https://github.com/Zxilly"><code>@Zxilly</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/896">actions/setup-python#896</a>
This addresses issues with caching by adding the architecture (arch) to the cache key, ensuring that cache keys are accurate to prevent conflicts</li>
</ul>
<h3>Documentation changes:</h3>
<ul>
<li>Fix display of emojis in contributors doc by <a href="https://github.com/sciencewhiz"><code>@sciencewhiz</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/899">actions/setup-python#899</a></li>
<li>Documentation update for caching poetry dependencies by <a href="https://github.com/gowridurgad"><code>@gowridurgad</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/908">actions/setup-python#908</a></li>
</ul>
<h3>Dependency updates:</h3>
<ul>
<li>Bump <code>@iarna/toml</code> version from 2.2.5 to 3.0.0 by <a href="https://github.com/priya-kinthali"><code>@priya-kinthali</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/912">actions/setup-python#912</a></li>
<li>Bump pyinstaller from 3.6 to 5.13.1 by <a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/923">actions/setup-python#923</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/sciencewhiz"><code>@sciencewhiz</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/899">actions/setup-python#899</a></li>
<li><a href="https://github.com/priyagupta108"><code>@priyagupta108</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/916">actions/setup-python#916</a></li>
<li><a href="https://github.com/Zxilly"><code>@Zxilly</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/896">actions/setup-python#896</a></li>
<li><a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/923">actions/setup-python#923</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5...v5.2.0">https://github.com/actions/setup-python/compare/v5...v5.2.0</a></p>
<h2>v5.1.1</h2>
<h2>What's Changed</h2>
<h3>Bug fixes:</h3>
<ul>
<li>fix(ci): update all failing workflows by <a href="https://github.com/mayeut"><code>@mayeut</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/863">actions/setup-python#863</a>
This update ensures compatibility and optimal performance of workflows on the latest macOS version.</li>
</ul>
<h3>Documentation changes:</h3>
<ul>
<li>Documentation update for cache by <a href="https://github.com/gowridurgad"><code>@gowridurgad</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/873">actions/setup-python#873</a></li>
</ul>
<h3>Dependency updates:</h3>
<ul>
<li>Bump braces from 3.0.2 to 3.0.3 and undici from 5.28.3 to 5.28.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/893">actions/setup-python#893</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/gowridurgad"><code>@gowridurgad</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/873">actions/setup-python#873</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v5...v5.1.1">https://github.com/actions/setup-python/compare/v5...v5.1.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/setup-python/commit/f677139bbe7f9c59b41e40162b753c062f5d49a3"><code>f677139</code></a> Bump pyinstaller from 3.6 to 5.13.1 in /<strong>tests</strong>/data (<a href="https://redirect.github.com/actions/setup-python/issues/923">#923</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/2bd53f9a4d1dd1cd21eaffcc01a7b91a8e73ea4c"><code>2bd53f9</code></a> Documentation update for caching poetry dependencies (<a href="https://redirect.github.com/actions/setup-python/issues/908">#908</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/80b49d3ed89312896dbdcbefc2ddb159c7f8ca43"><code>80b49d3</code></a> fix: add arch to cache key (<a href="https://redirect.github.com/actions/setup-python/issues/896">#896</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/036a5236741fd24c89eea80d1b76179e8e5f9214"><code>036a523</code></a> Fix: Add <code>.zip</code> extension to Windows package downloads for <code>Expand-Archive</code> C...</li>
<li><a href="https://github.com/actions/setup-python/commit/04c1311429f7be71707d8ab66c7af8a14e54b938"><code>04c1311</code></a> Fix display of emojis in contributors doc (<a href="https://redirect.github.com/actions/setup-python/issues/899">#899</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/cb6845644151e35f879e10f2f0896c3c8bee372c"><code>cb68456</code></a> Updated <code>@iarna/toml</code> version to 3.0.0 (<a href="https://redirect.github.com/actions/setup-python/issues/912">#912</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/39cd14951b08e74b54015e9e001cdefcf80e669f"><code>39cd149</code></a> Documentation update for cache (<a href="https://redirect.github.com/actions/setup-python/issues/873">#873</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/a0d74c0c423f896bc4e7be91d5cb1e2d54438db3"><code>a0d74c0</code></a> fix(ci): update all failing workflows (<a href="https://redirect.github.com/actions/setup-python/issues/863">#863</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/4eb7dbcb9561cb76a85079ffa9d89b983166e00c"><code>4eb7dbc</code></a> Bump braces from 3.0.2 to 3.0.3 (<a href="https://redirect.github.com/actions/setup-python/issues/893">#893</a>)</li>
<li>See full diff in <a href="https://github.com/actions/setup-python/compare/82c7e631bb3cdc910f68e0081d67478d79c6982d...f677139bbe7f9c59b41e40162b753c062f5d49a3">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6797/reactions"
} | https://api.github.com/repos/psf/requests/issues/6797/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6797.diff",
"html_url": "https://github.com/psf/requests/pull/6797",
"merged_at": "2024-09-02T17:37:44Z",
"patch_url": "https://github.com/psf/requests/pull/6797.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6797"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6796 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6796/labels{/name} | https://api.github.com/repos/psf/requests/issues/6796/comments | https://api.github.com/repos/psf/requests/issues/6796/events | https://github.com/psf/requests/pull/6796 | 2,498,743,117 | PR_kwDOABTKOs56DEPq | 6,796 | [Bugfix] Fix incorrectly overwriting Content-Type header when passing JSON body | {
"avatar_url": "https://avatars.githubusercontent.com/u/44831187?v=4",
"events_url": "https://api.github.com/users/DeathHound6/events{/privacy}",
"followers_url": "https://api.github.com/users/DeathHound6/followers",
"following_url": "https://api.github.com/users/DeathHound6/following{/other_user}",
"gists_url": "https://api.github.com/users/DeathHound6/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DeathHound6",
"id": 44831187,
"login": "DeathHound6",
"node_id": "MDQ6VXNlcjQ0ODMxMTg3",
"organizations_url": "https://api.github.com/users/DeathHound6/orgs",
"received_events_url": "https://api.github.com/users/DeathHound6/received_events",
"repos_url": "https://api.github.com/users/DeathHound6/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DeathHound6/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DeathHound6/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DeathHound6",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 3 | 2024-08-31T09:09:25Z | 2024-08-31T23:23:27Z | 2024-08-31T19:41:50Z | NONE | null | Checks for when to set the Content-Type header currently are using the wrong casing to check if the value has already been set before
This is causing the header to be overwritten from what it may have already been set as
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6796/reactions"
} | https://api.github.com/repos/psf/requests/issues/6796/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6796.diff",
"html_url": "https://github.com/psf/requests/pull/6796",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6796.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6796"
} | true | [
"Hi @DeathHound6,\n\nIt looks like you may not have tested this before creating a PR? In the future, please read our contribution guide and open an issue describing your problem.\n\nRequests uses a custom CaseInsensitiveDict that handles this for headers. As noted in the docs, individual prepare_* methods must not be invoked from end user code. `prepare` will ensure headers are evaluated case-insensitive.\n\nIf you have more info with an actual repro, please open an issue with exact instructions. Thanks!\n\n```\nimport requests\n\nr = requests.Request(\n 'POST',\n 'https://httpbin.org/post',\n headers={'cOnTeNt-TyPe': \"application/foo\"},\n json={\"a\": \"b\"}\n)\n\np = r.prepare()\nprint(p.headers[\"content-type\"])\n>>> \"application/foo\"\n```\n",
"Hi @nateprewitt \r\n\r\nApologies, I did not realise that a case-insensitive dict was being used here\r\n\r\nI hadn't really dug too much into the source code of the library, but I do believe there is a bug present in this general area.\r\n\r\nWe were experiencing issues in work during the week regarding passing a JSON body in a patch request, where our API was returning a request validation error. Unfortunately our logs were not providing any more information than this.\r\nAll of our patch endpoints require a certain value in our content-type header, which is not the normal `application/json` value.\r\n\r\nI believed the library overwriting the header was the issue here as passing our json data through the `json` kwarg was raising this error, but passing through `data` kwarg wasn't.\r\n\r\nI may take a more thorough look into the library's source code soon to try to resolve this.\r\n\r\nOnce again, apologies for my lack of testing.\r\nThanks",
"Please read the documentation of that endpoint closely. We do not allow you to override the content type when passing to the json kwarg. That's why using data worked because that's what you must use in that case. It's not a bug by any stretch. "
] |
https://api.github.com/repos/psf/requests/issues/6794 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6794/labels{/name} | https://api.github.com/repos/psf/requests/issues/6794/comments | https://api.github.com/repos/psf/requests/issues/6794/events | https://github.com/psf/requests/issues/6794 | 2,491,838,114 | I_kwDOABTKOs6Uhm6i | 6,794 | Requests changes the URL on GET | {
"avatar_url": "https://avatars.githubusercontent.com/u/526577?v=4",
"events_url": "https://api.github.com/users/Peque/events{/privacy}",
"followers_url": "https://api.github.com/users/Peque/followers",
"following_url": "https://api.github.com/users/Peque/following{/other_user}",
"gists_url": "https://api.github.com/users/Peque/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Peque",
"id": 526577,
"login": "Peque",
"node_id": "MDQ6VXNlcjUyNjU3Nw==",
"organizations_url": "https://api.github.com/users/Peque/orgs",
"received_events_url": "https://api.github.com/users/Peque/received_events",
"repos_url": "https://api.github.com/users/Peque/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Peque/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Peque/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Peque",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 5 | 2024-08-28T11:36:45Z | 2024-09-22T16:47:45Z | 2024-08-28T17:31:09Z | NONE | null | When fetching a URL containing `%2c` with GET, the URL gets modified and `%2c` is replaced by `%2C`.
The problem with this is that the server may return a 404 when using `%2C` even if the resource exists when looking for it using `%2c` (i.e.: the server is expecting you to honor the lower-case encoding). This should not be the case since [URL percent-encoding is case insensitive](https://stackoverflow.com/questions/7994287/is-url-percent-encoding-case-sensitive), but actual servers may not comply with that and require you to use lower case.
This comes from a real use case where the server is generating and providing a URL to download a file, and refuses to reply with the file unless `%2c` is used (instead of `%2C`).
## Expected Result
Requests should not modify the URL, since `%2c` is already encoded (and lower-case is just as valid encoding as upper-case).
This expected behavior can be found when using other libraries like `httpx`.
## Actual Result
Requests modifies the URL, changing `%2c` to `%2C`.
## Reproduction Steps
```py
url = "https://domain.com/foo/bar%2cbaz.pdf"
response = requests.get(url)
print(url) # https://domain.com/foo/bar%2cbaz.pdf
print(response.url) # https://domain.com/foo/bar%2Cbaz.pdf
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.5"
},
"platform": {
"release": "6.10.6-200.fc40.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "300000c0"
},
"urllib3": {
"version": "2.0.7"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6794/reactions"
} | https://api.github.com/repos/psf/requests/issues/6794/timeline | null | completed | null | null | false | [
"In the future, please search **closed and** open issues before creating new ones that are duplicates.",
"@sigmavirus24 I always do, but I didn't manage to find a duplicate.\r\n\r\nWould you mind sharing which is/are the duplicate/s of this issue?\r\n\r\nAlso for traceability and future users that may come here and want to understand why this one was closed.",
"#6115",
"@sigmavirus24 I think that would not be the same issue as stated here. The issue I describe is about a URL that is already escaped/encoded using `%2c`. So there is no reason for `requests` to re-encode it again with `%2C` (both `%2c` and `%2C` are valid ways to encode/escape).\r\n\r\nOr am I missing something?",
"What you're missing is that in that issue and others linked from it, people wish to control the encoding (or lack thereof) and in general normalization of the query string, which is what you want as well"
] |
https://api.github.com/repos/psf/requests/issues/6793 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6793/labels{/name} | https://api.github.com/repos/psf/requests/issues/6793/comments | https://api.github.com/repos/psf/requests/issues/6793/events | https://github.com/psf/requests/issues/6793 | 2,488,949,689 | I_kwDOABTKOs6UWlu5 | 6,793 | Cannot close the proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/59678894?v=4",
"events_url": "https://api.github.com/users/invisifire/events{/privacy}",
"followers_url": "https://api.github.com/users/invisifire/followers",
"following_url": "https://api.github.com/users/invisifire/following{/other_user}",
"gists_url": "https://api.github.com/users/invisifire/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/invisifire",
"id": 59678894,
"login": "invisifire",
"node_id": "MDQ6VXNlcjU5Njc4ODk0",
"organizations_url": "https://api.github.com/users/invisifire/orgs",
"received_events_url": "https://api.github.com/users/invisifire/received_events",
"repos_url": "https://api.github.com/users/invisifire/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/invisifire/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/invisifire/subscriptions",
"type": "User",
"url": "https://api.github.com/users/invisifire",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-08-27T10:37:43Z | 2024-08-27T10:37:43Z | null | NONE | null | <!-- Summary. -->
In windows pycharm jupyterlab when i open windows system proxy requests will use the proxy i set on windows system.
but cannot close this proxy direct to the internet . I try
```python
response = requests.post(url, headers=headers, json=data, proxies=None)
response = requests.post(url, headers=headers, json=data, proxies={})
response = requests.post(url, headers=headers, json=data, proxies="")
```
can't work
## Expected Result
don't use proxy I set on windows
<!-- What you expected. -->
## Actual Result
I can check this connection on clash
<!-- What happened instead. -->
## Reproduction Steps
windows requests 2.31.0
use pycharm and jupyter
```python
import requests
response = requests.post(url, headers=headers, json=data, proxies=None)# I try None {} "" []
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.4"
},
"cryptography": {
"version": "41.0.7"
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.5"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "300000c0",
"version": "23.2.0"
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "300000c0"
},
"urllib3": {
"version": "1.26.18"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6793/reactions"
} | https://api.github.com/repos/psf/requests/issues/6793/timeline | null | null | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/6792 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6792/labels{/name} | https://api.github.com/repos/psf/requests/issues/6792/comments | https://api.github.com/repos/psf/requests/issues/6792/events | https://github.com/psf/requests/issues/6792 | 2,482,445,132 | I_kwDOABTKOs6T9xtM | 6,792 | Add Warning for Incorrect Keyword Arguments in POST Requests (e.g., 'header' instead of 'headers') | {
"avatar_url": "https://avatars.githubusercontent.com/u/130439426?v=4",
"events_url": "https://api.github.com/users/jsilverman26/events{/privacy}",
"followers_url": "https://api.github.com/users/jsilverman26/followers",
"following_url": "https://api.github.com/users/jsilverman26/following{/other_user}",
"gists_url": "https://api.github.com/users/jsilverman26/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jsilverman26",
"id": 130439426,
"login": "jsilverman26",
"node_id": "U_kgDOB8ZZAg",
"organizations_url": "https://api.github.com/users/jsilverman26/orgs",
"received_events_url": "https://api.github.com/users/jsilverman26/received_events",
"repos_url": "https://api.github.com/users/jsilverman26/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jsilverman26/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jsilverman26/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jsilverman26",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156041422,
"name": "actions/autoclose-feat",
"node_id": "LA_kwDOABTKOs8AAAABbu28zg",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-feat"
}
] | closed | true | null | [] | null | 1 | 2024-08-23T06:51:57Z | 2024-08-23T06:52:09Z | 2024-08-23T06:52:08Z | NONE | off-topic | Summary:
When making a POST request using the requests library, passing an incorrect keyword argument (e.g., header instead of headers) does not trigger any error or warning. This can lead to unintended behavior, as the request proceeds without the intended headers being applied.
Problem:
The requests library currently does not validate keyword arguments for correctness. If a user accidentally passes a misspelled argument like header instead of headers, the request will still execute, but the headers will not be set as expected. This lack of validation makes it easy to overlook such errors, leading to potential issues that can be difficult to debug.
Proposed Solution:
Introduce a warning mechanism that alerts the user when an unrecognized keyword argument is passed. This could be implemented as a simple check within the requests functions to identify commonly mistaken keywords like header and issue a warning, helping developers catch such errors early.
Benefit:
Adding this feature would improve the developer experience by reducing the likelihood of subtle bugs caused by incorrect keyword arguments. It would also make the requests library more user-friendly by providing immediate feedback when a common mistake is made.
Additional Context:
This issue was observed during development when a request was made with header instead of headers, causing the request to proceed without applying the necessary headers. A warning in such cases would have saved considerable debugging time.
<img width="798" alt="image" src="https://github.com/user-attachments/assets/79a49dc7-098d-40f1-9061-63765fc30595">
Thank you for considering this enhancement! | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6792/reactions"
} | https://api.github.com/repos/psf/requests/issues/6792/timeline | null | not_planned | null | null | false | [
"As described in the template, Requests is not accepting feature requests"
] |
https://api.github.com/repos/psf/requests/issues/6791 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6791/labels{/name} | https://api.github.com/repos/psf/requests/issues/6791/comments | https://api.github.com/repos/psf/requests/issues/6791/events | https://github.com/psf/requests/pull/6791 | 2,467,952,666 | PR_kwDOABTKOs54dkRv | 6,791 | Do not load ssl context during import | {
"avatar_url": "https://avatars.githubusercontent.com/u/16310367?v=4",
"events_url": "https://api.github.com/users/holmanb/events{/privacy}",
"followers_url": "https://api.github.com/users/holmanb/followers",
"following_url": "https://api.github.com/users/holmanb/following{/other_user}",
"gists_url": "https://api.github.com/users/holmanb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/holmanb",
"id": 16310367,
"login": "holmanb",
"node_id": "MDQ6VXNlcjE2MzEwMzY3",
"organizations_url": "https://api.github.com/users/holmanb/orgs",
"received_events_url": "https://api.github.com/users/holmanb/received_events",
"repos_url": "https://api.github.com/users/holmanb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/holmanb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/holmanb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/holmanb",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-08-15T12:25:52Z | 2024-08-15T12:25:52Z | null | NONE | null | Possible fix for https://github.com/psf/requests/issues/6790.
This removes the ssl context load from the import path, and instead caches the context the first time that it is requested. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6791/reactions"
} | https://api.github.com/repos/psf/requests/issues/6791/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6791.diff",
"html_url": "https://github.com/psf/requests/pull/6791",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6791.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6791"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6790 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6790/labels{/name} | https://api.github.com/repos/psf/requests/issues/6790/comments | https://api.github.com/repos/psf/requests/issues/6790/events | https://github.com/psf/requests/issues/6790 | 2,467,944,147 | I_kwDOABTKOs6TGdbT | 6,790 | Import time regression | {
"avatar_url": "https://avatars.githubusercontent.com/u/16310367?v=4",
"events_url": "https://api.github.com/users/holmanb/events{/privacy}",
"followers_url": "https://api.github.com/users/holmanb/followers",
"following_url": "https://api.github.com/users/holmanb/following{/other_user}",
"gists_url": "https://api.github.com/users/holmanb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/holmanb",
"id": 16310367,
"login": "holmanb",
"node_id": "MDQ6VXNlcjE2MzEwMzY3",
"organizations_url": "https://api.github.com/users/holmanb/orgs",
"received_events_url": "https://api.github.com/users/holmanb/received_events",
"repos_url": "https://api.github.com/users/holmanb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/holmanb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/holmanb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/holmanb",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 1 | 2024-08-15T12:19:37Z | 2024-11-01T13:13:47Z | null | NONE | null | <!-- Summary. -->
Between 2.31.0 and 2.32.3, import time increased by ~25%. This appears to have been caused by https://github.com/psf/requests/pull/6667, which changed the expensive `load_verify_locations()` to run at import time (in 2.32.0).
## Reproduction Steps
Compare import time of versions with:
```bash
$ python3 -X importtime -c 'import requests' 2> requests_import.log
$ tuna requests_import.log
```
2.31.0
2.32.3:
 | null | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6790/reactions"
} | https://api.github.com/repos/psf/requests/issues/6790/timeline | null | null | null | null | false | [
"I'm on Windows, with Python 3.11 and requests 2.32.3 and noticed very slow import times and narrowed it down to requests. In my case when importing requests, the `requests.adapters` module made up 4.353 s (85.9%) of the import time with similar command as above."
] |
https://api.github.com/repos/psf/requests/issues/6789 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6789/labels{/name} | https://api.github.com/repos/psf/requests/issues/6789/comments | https://api.github.com/repos/psf/requests/issues/6789/events | https://github.com/psf/requests/issues/6789 | 2,467,817,162 | I_kwDOABTKOs6TF-bK | 6,789 | Time between request sent and first byte received (time to first byte) | {
"avatar_url": "https://avatars.githubusercontent.com/u/10009354?v=4",
"events_url": "https://api.github.com/users/disconnect3d/events{/privacy}",
"followers_url": "https://api.github.com/users/disconnect3d/followers",
"following_url": "https://api.github.com/users/disconnect3d/following{/other_user}",
"gists_url": "https://api.github.com/users/disconnect3d/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/disconnect3d",
"id": 10009354,
"login": "disconnect3d",
"node_id": "MDQ6VXNlcjEwMDA5MzU0",
"organizations_url": "https://api.github.com/users/disconnect3d/orgs",
"received_events_url": "https://api.github.com/users/disconnect3d/received_events",
"repos_url": "https://api.github.com/users/disconnect3d/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/disconnect3d/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/disconnect3d/subscriptions",
"type": "User",
"url": "https://api.github.com/users/disconnect3d",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156041422,
"name": "actions/autoclose-feat",
"node_id": "LA_kwDOABTKOs8AAAABbu28zg",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-feat"
}
] | closed | true | null | [] | null | 1 | 2024-08-15T10:36:56Z | 2024-08-15T10:37:08Z | 2024-08-15T10:37:07Z | NONE | off-topic | Hi,
It would be awesome if requests allowed for getting the time to first byte metric. Currently, there is the `response.elapsed.total_seconds()` metric but it computes the time for both sending the request and receiving a response:
https://github.com/psf/requests/blob/a3ce6f007597f14029e6b6f54676c34196aa050e/src/requests/sessions.py#L699-L707
This does not allow requests to be used for performance measurements where we want to more accurately measure how much time did it take for a server to render a response.
The request sending goes over an adapter `.send` method here: https://github.com/psf/requests/blob/a3ce6f007597f14029e6b6f54676c34196aa050e/src/requests/adapters.py#L613-L719
And it eventually does performs the request sending through urllib3. It seems this feature would require changing urllib3 logic to allow for getting this timing properly.
| {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6789/reactions"
} | https://api.github.com/repos/psf/requests/issues/6789/timeline | null | not_planned | null | null | false | [
"As described in the template, Requests is not accepting feature requests"
] |
https://api.github.com/repos/psf/requests/issues/6788 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6788/labels{/name} | https://api.github.com/repos/psf/requests/issues/6788/comments | https://api.github.com/repos/psf/requests/issues/6788/events | https://github.com/psf/requests/issues/6788 | 2,461,972,352 | I_kwDOABTKOs6SvreA | 6,788 | Any ipv6 request spuriously stays stuck for a long time, sometimes never progressing | {
"avatar_url": "https://avatars.githubusercontent.com/u/52013991?v=4",
"events_url": "https://api.github.com/users/sanjacob/events{/privacy}",
"followers_url": "https://api.github.com/users/sanjacob/followers",
"following_url": "https://api.github.com/users/sanjacob/following{/other_user}",
"gists_url": "https://api.github.com/users/sanjacob/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sanjacob",
"id": 52013991,
"login": "sanjacob",
"node_id": "MDQ6VXNlcjUyMDEzOTkx",
"organizations_url": "https://api.github.com/users/sanjacob/orgs",
"received_events_url": "https://api.github.com/users/sanjacob/received_events",
"repos_url": "https://api.github.com/users/sanjacob/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sanjacob/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sanjacob/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sanjacob",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-08-12T22:06:29Z | 2024-08-12T22:06:39Z | 2024-08-12T22:06:39Z | NONE | off-topic | I have an issue with my OS, that I am not sure how to diagnose, but it seems to affect requests too:
```
requests [required: >=2.20, installed: 2.32.3]
│ ├── certifi [required: >=2017.4.17, installed: 2024.7.4]
│ ├── charset-normalizer [required: >=2,<4, installed: 3.3.2]
│ ├── idna [required: >=2.5,<4, installed: 3.7]
│ └── urllib3 [required: >=1.21.1,<3, installed: 2.2.2]
```
- Python 3.10.11 (main, Dec 26 2023, 17:59:09) [GCC 10.2.1 20210110] on linux
- OS: Debian GNU/Linux 12 (bookworm) x86_64
- Kernel: 6.1.0-23-amd64
Expected behaviour: requests hits timeout error
Actual behaviour: Stuck for a long time (10-20 minutes+)
```
>>> requests.get("https://google.com", timeout=2000) # Using IPv6
^CTraceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/requests/api.py", line 73, in get
return request("get", url, params=params, **kwargs)
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/requests/api.py", line 59, in request
return session.request(method=method, url=url, **kwargs)
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/requests/sessions.py", line 703, in send
r = adapter.send(request, **kwargs)
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/requests/adapters.py", line 667, in send
resp = conn.urlopen(
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/urllib3/connectionpool.py", line 789, in urlopen
response = self._make_request(
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/urllib3/connectionpool.py", line 466, in _make_request
self._validate_conn(conn)
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/urllib3/connectionpool.py", line 1095, in _validate_conn
conn.connect()
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/urllib3/connection.py", line 615, in connect
self.sock = sock = self._new_conn()
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/urllib3/connection.py", line 196, in _new_conn
sock = connection.create_connection(
File "/home/.../.local/share/virtualenvs/.../lib/python3.10/site-packages/urllib3/util/connection.py", line 73, in create_connection
sock.connect(sa)
KeyboardInterrupt
>>> requests.packages.urllib3.util.connection.HAS_IPV6 = False # manually disable ipv6
>>> requests.get("https://google.com", timeout=2000) # no problem with this
<Response [200]>
>>> requests.packages.urllib3.util.connection.HAS_IPV6 = True # tried request again and stuck for a long time
```
Unfortunately this also affects `git push` and `git pull`, so I know for a fact this is not a requests bug. But I do expect timeout to work in this rare(?) circumstance. Whatever the case, if you happen to know why my ipv6 connections seem to either take forever or never happen, please let me know. | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6788/reactions"
} | https://api.github.com/repos/psf/requests/issues/6788/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6787 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6787/labels{/name} | https://api.github.com/repos/psf/requests/issues/6787/comments | https://api.github.com/repos/psf/requests/issues/6787/events | https://github.com/psf/requests/pull/6787 | 2,461,427,614 | PR_kwDOABTKOs54IXjZ | 6,787 | Bump github/codeql-action from 3.25.0 to 3.26.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2024-08-12T16:23:17Z | 2024-09-29T17:26:05Z | 2024-08-12T16:54:11Z | CONTRIBUTOR | null | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.0 to 3.26.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.26.0 - 06 Aug 2024</h2>
<ul>
<li><em>Deprecation:</em> Swift analysis on Ubuntu runner images is no longer supported. Please migrate to a macOS runner if this affects you. <a href="https://redirect.github.com/github/codeql-action/pull/2403">#2403</a></li>
<li>Bump the minimum CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/2408">#2408</a></li>
</ul>
<h2>3.25.15 - 26 Jul 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.18.1. <a href="https://redirect.github.com/github/codeql-action/pull/2385">#2385</a></li>
</ul>
<h2>3.25.14 - 25 Jul 2024</h2>
<ul>
<li>Experimental: add a new <code>start-proxy</code> action which starts the same HTTP proxy as used by <a href="https://github.com/github/dependabot-action"><code>github/dependabot-action</code></a>. Do not use this in production as it is part of an internal experiment and subject to change at any time. <a href="https://redirect.github.com/github/codeql-action/pull/2376">#2376</a></li>
</ul>
<h2>3.25.13 - 19 Jul 2024</h2>
<ul>
<li>Add <code>codeql-version</code> to outputs. <a href="https://redirect.github.com/github/codeql-action/pull/2368">#2368</a></li>
<li>Add a deprecation warning for customers using CodeQL version 2.13.4 and earlier. These versions of CodeQL were discontinued on 9 July 2024 alongside GitHub Enterprise Server 3.9, and will be unsupported by CodeQL Action versions 3.26.0 and later and versions 2.26.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/2375">#2375</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.13.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.12.6 and 2.13.4, you can replace <code>github/codeql-action/*@v3</code> by <code>github/codeql-action/*@v3.25.13</code> and <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.25.13</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>3.25.12 - 12 Jul 2024</h2>
<ul>
<li>Improve the reliability and performance of analyzing code when analyzing a compiled language with the <code>autobuild</code> <a href="https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#codeql-build-modes">build mode</a> on GitHub Enterprise Server. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2353">#2353</a></li>
<li>Update default CodeQL bundle version to 2.18.0. <a href="https://redirect.github.com/github/codeql-action/pull/2364">#2364</a></li>
</ul>
<h2>3.25.11 - 28 Jun 2024</h2>
<ul>
<li>Avoid failing the workflow run if there is an error while uploading debug artifacts. <a href="https://redirect.github.com/github/codeql-action/pull/2349">#2349</a></li>
<li>Update default CodeQL bundle version to 2.17.6. <a href="https://redirect.github.com/github/codeql-action/pull/2352">#2352</a></li>
</ul>
<h2>3.25.10 - 13 Jun 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.5. <a href="https://redirect.github.com/github/codeql-action/pull/2327">#2327</a></li>
</ul>
<h2>3.25.9 - 12 Jun 2024</h2>
<ul>
<li>Avoid failing database creation if the database folder already exists and contains some unexpected files. Requires CodeQL 2.18.0 or higher. <a href="https://redirect.github.com/github/codeql-action/pull/2330">#2330</a></li>
<li>The init Action will attempt to clean up the database cluster directory before creating a new database and at the end of the job. This will help to avoid issues where the database cluster directory is left in an inconsistent state. <a href="https://redirect.github.com/github/codeql-action/pull/2332">#2332</a></li>
</ul>
<h2>3.25.8 - 04 Jun 2024</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/eb055d739abdc2e8de2e5f4ba1a8b246daa779aa"><code>eb055d7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2410">#2410</a> from github/update-v3.26.0-c24926b73</li>
<li><a href="https://github.com/github/codeql-action/commit/3884d04c1155b714391ad663c28d71f332778d0c"><code>3884d04</code></a> Update changelog for v3.26.0</li>
<li><a href="https://github.com/github/codeql-action/commit/c24926b73412ecf51b27bc8e3cacb43a6b3f02ae"><code>c24926b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2407">#2407</a> from github/dependabot/npm_and_yarn/npm-7954a73ad2</li>
<li><a href="https://github.com/github/codeql-action/commit/68ba39bacf27d8362ac9c671e45a970d776578f9"><code>68ba39b</code></a> Merge branch 'main' into dependabot/npm_and_yarn/npm-7954a73ad2</li>
<li><a href="https://github.com/github/codeql-action/commit/8dd17734677bad12f20a39b470d1bd45acbadc48"><code>8dd1773</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2408">#2408</a> from github/henrymercer/deprecate-codeql-2.13.4</li>
<li><a href="https://github.com/github/codeql-action/commit/441c9d90e44d79449d7f555d97a5f04f0970b927"><code>441c9d9</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2409">#2409</a> from github/henrymercer/fix-required-checks</li>
<li><a href="https://github.com/github/codeql-action/commit/f03da1345462bf7292a562681f136608588272c5"><code>f03da13</code></a> Exclude push-only unit tests job from required PR checks script</li>
<li><a href="https://github.com/github/codeql-action/commit/29a5cfc75d38b3893eb5b8f72652c57a9b5231be"><code>29a5cfc</code></a> Bump version to 3.26.0</li>
<li><a href="https://github.com/github/codeql-action/commit/9e440ad4c728db26c19f33cb713b9404dcc4d0ca"><code>9e440ad</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/136f5a589b6f389231c51cb03d17bb60f22ccda6"><code>136f5a5</code></a> Add CodeQL v2.17.6 to default test versions</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/df5a14dc28094dc936e103b37d749c6628682b60...eb055d739abdc2e8de2e5f4ba1a8b246daa779aa">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6787/reactions"
} | https://api.github.com/repos/psf/requests/issues/6787/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6787.diff",
"html_url": "https://github.com/psf/requests/pull/6787",
"merged_at": "2024-08-12T16:54:11Z",
"patch_url": "https://github.com/psf/requests/pull/6787.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6787"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6786 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6786/labels{/name} | https://api.github.com/repos/psf/requests/issues/6786/comments | https://api.github.com/repos/psf/requests/issues/6786/events | https://github.com/psf/requests/pull/6786 | 2,459,610,076 | PR_kwDOABTKOs54CKmV | 6,786 | Add some nonstandard HTTP status code | {
"avatar_url": "https://avatars.githubusercontent.com/u/88998238?v=4",
"events_url": "https://api.github.com/users/moyanj/events{/privacy}",
"followers_url": "https://api.github.com/users/moyanj/followers",
"following_url": "https://api.github.com/users/moyanj/following{/other_user}",
"gists_url": "https://api.github.com/users/moyanj/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/moyanj",
"id": 88998238,
"login": "moyanj",
"node_id": "MDQ6VXNlcjg4OTk4MjM4",
"organizations_url": "https://api.github.com/users/moyanj/orgs",
"received_events_url": "https://api.github.com/users/moyanj/received_events",
"repos_url": "https://api.github.com/users/moyanj/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/moyanj/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/moyanj/subscriptions",
"type": "User",
"url": "https://api.github.com/users/moyanj",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2024-08-11T14:08:52Z | 2024-08-11T14:28:12Z | 2024-08-11T14:28:12Z | NONE | null | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6786/reactions"
} | https://api.github.com/repos/psf/requests/issues/6786/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6786.diff",
"html_url": "https://github.com/psf/requests/pull/6786",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6786.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6786"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6785 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6785/labels{/name} | https://api.github.com/repos/psf/requests/issues/6785/comments | https://api.github.com/repos/psf/requests/issues/6785/events | https://github.com/psf/requests/pull/6785 | 2,453,668,217 | PR_kwDOABTKOs53uRNY | 6,785 | Update conf.py to fix roman year | {
"avatar_url": "https://avatars.githubusercontent.com/u/8612771?v=4",
"events_url": "https://api.github.com/users/nothingface0/events{/privacy}",
"followers_url": "https://api.github.com/users/nothingface0/followers",
"following_url": "https://api.github.com/users/nothingface0/following{/other_user}",
"gists_url": "https://api.github.com/users/nothingface0/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nothingface0",
"id": 8612771,
"login": "nothingface0",
"node_id": "MDQ6VXNlcjg2MTI3NzE=",
"organizations_url": "https://api.github.com/users/nothingface0/orgs",
"received_events_url": "https://api.github.com/users/nothingface0/received_events",
"repos_url": "https://api.github.com/users/nothingface0/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nothingface0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nothingface0/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nothingface0",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-08-07T14:41:34Z | 2024-08-08T17:50:39Z | null | NONE | null | Very minor fix, which did however catch my eye: Fix for the invalid roman year in the documentation footer.
Same as #6389, which seems to be closed.
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6785/reactions"
} | https://api.github.com/repos/psf/requests/issues/6785/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6785.diff",
"html_url": "https://github.com/psf/requests/pull/6785",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6785.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6785"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6784 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6784/labels{/name} | https://api.github.com/repos/psf/requests/issues/6784/comments | https://api.github.com/repos/psf/requests/issues/6784/events | https://github.com/psf/requests/issues/6784 | 2,447,794,874 | I_kwDOABTKOs6R5mK6 | 6,784 | Multiple path separators causes bad requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/58504806?v=4",
"events_url": "https://api.github.com/users/martin-pil/events{/privacy}",
"followers_url": "https://api.github.com/users/martin-pil/followers",
"following_url": "https://api.github.com/users/martin-pil/following{/other_user}",
"gists_url": "https://api.github.com/users/martin-pil/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/martin-pil",
"id": 58504806,
"login": "martin-pil",
"node_id": "MDQ6VXNlcjU4NTA0ODA2",
"organizations_url": "https://api.github.com/users/martin-pil/orgs",
"received_events_url": "https://api.github.com/users/martin-pil/received_events",
"repos_url": "https://api.github.com/users/martin-pil/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/martin-pil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martin-pil/subscriptions",
"type": "User",
"url": "https://api.github.com/users/martin-pil",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-08-05T07:15:00Z | 2024-08-05T07:16:24Z | null | NONE | null | <!-- Summary. -->
I'm assuming that change in https://github.com/psf/requests/pull/6644 is the cause of this changed behavior that operations with // in path fails. It seems to be related to Authentication as it is the only thing I could find that does not get trimmed by the change in 6644.
## Expected Result
Similar behavior as before 2.32.0
## Actual Result
Request captured by wireshark, note that this is the second request as the first got a 401
Hypertext Transfer Protocol
POST /axis-cgi/capturemode.cgi HTTP/1.1\r\n
Host: 192.168.0.1\r\n
User-Agent: python-requests/2.32.3\r\n
Accept-Encoding: gzip, deflate, zstd\r\n
Accept: */*\r\n
Connection: keep-alive\r\n
Content-Length: 50\r\n
[truncated]Authorization: Digest username="root", realm="AXIS_B8A44F45D62F", nonce="UKH3vekeBgA=2b0d57c2d8b8eb15307576e30309cb7b23a2304c", uri="//axis-cgi/capturemode.cgi", response="0a51943f746a0d88c6574f662b457a9c", algorithm="MD5", qo
username="root"
realm="AXIS_B8A44F45D62F"
nonce="UKH3vekeBgA=2b0d57c2d8b8eb15307576e30309cb7b23a2304c"
uri="//axis-cgi/capturemode.cgi"
response="0a51943f746a0d88c6574f662b457a9c"
algorithm="MD5"
qop="auth"
nc=00000001
\r\n
[Full request URI: http://172.26.21.128/axis-cgi/capturemode.cgi]
[HTTP request 2/2]
[Prev request in frame: 10]
[Response in frame: 19]
File Data: 50 bytes
Data (50 bytes)
Response:
Hypertext Transfer Protocol
HTTP/1.1 400 Bad Request\r\n
Date: Mon, 05 Aug 2024 06:25:23 GMT\r\n
Server: Apache/2.4.58 (Unix) OpenSSL/3.0.13\r\n
X-Content-Type-Options: nosniff\r\n
X-Frame-Options: SAMEORIGIN\r\n
X-XSS-Protection: 1; mode=block\r\n
[truncated]Content-Security-Policy: default-src 'self'; frame-ancestors 'self'; connect-src 'self' https://*.google-analytics.com https://*.analytics.google.com https://*.googletagmanager.com https://*.axis.com mediastream: blob:; script
Content-Length: 226\r\n
Connection: close\r\n
Content-Type: text/html; charset=iso-8859-1\r\n
\r\n
[HTTP response 2/2]
[Time since request: 0.001411000 seconds]
[Prev request in frame: 10]
[Prev response in frame: 13]
[Request in frame: 16]
[Request URI: http://192.168.0.1/axis-cgi/capturemode.cgi]
File Data: 226 bytes
## Reproduction Steps
This was run at a axis camera
```python
import requests
url = "http://192.168.01//axis-cgi/capturemode.cgi"
body = {
"apiVersion": "1.0",
"method": "getCaptureModes"}
auth = requests.auth.HTTPDigestAuth("root", "pass")
response = requests.post(url=url, data=json.dumps(body),
auth=auth, proxies=dict(http=None, https=None))
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": "42.0.8"
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.11.2"
},
"platform": {
"release": "6.1.0-21-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30200020",
"version": "24.1.0"
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "300000b0"
},
"urllib3": {
"version": "2.2.2"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
| null | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6784/reactions"
} | https://api.github.com/repos/psf/requests/issues/6784/timeline | null | null | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/6783 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6783/labels{/name} | https://api.github.com/repos/psf/requests/issues/6783/comments | https://api.github.com/repos/psf/requests/issues/6783/events | https://github.com/psf/requests/issues/6783 | 2,446,450,814 | I_kwDOABTKOs6R0eB- | 6,783 | QUIC over Socks5/UDP capable proxy is not working. | {
"avatar_url": "https://avatars.githubusercontent.com/u/775614?v=4",
"events_url": "https://api.github.com/users/ezbik/events{/privacy}",
"followers_url": "https://api.github.com/users/ezbik/followers",
"following_url": "https://api.github.com/users/ezbik/following{/other_user}",
"gists_url": "https://api.github.com/users/ezbik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ezbik",
"id": 775614,
"login": "ezbik",
"node_id": "MDQ6VXNlcjc3NTYxNA==",
"organizations_url": "https://api.github.com/users/ezbik/orgs",
"received_events_url": "https://api.github.com/users/ezbik/received_events",
"repos_url": "https://api.github.com/users/ezbik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ezbik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ezbik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ezbik",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2024-08-03T16:28:17Z | 2024-08-10T21:14:43Z | 2024-08-03T16:48:55Z | NONE | null | QUIC over Socks5/UDP capable proxy is not working.
## Expected Result
QUIC/HTTP3 worked over Socks5+UDP.
## Actual Result
```
<Response HTTP/2 [200]>
SOCKSHTTPSConnectionPool(host='bbc.com', port=443): Read timed out. (read timeout=2)
```
## Reproduction Steps
```python
import niquests
PX='socks5h://127.0.0.1:1212'
proxies = { 'http': PX, 'https': PX, }
session = niquests.Session()
session.proxies.update(proxies)
timeout=2
Q_SITE='https://bbc.com'
for i in [1,2]:
try:
r = session.get(Q_SITE , timeout=timeout)
print(r)
except Exception as e:
print(e)
```
## System Information
$ python -m requests.help
```json
{
"charset_normalizer": {
"version": "3.3.2"
},
"http1": {
"h11": "0.14.0"
},
"http2": {
"jh2": "5.0.3"
},
"http3": {
"enabled": true,
"qh3": "1.0.8"
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.10.6"
},
"niquests": {
"version": "3.7.2"
},
"ocsp": {
"enabled": true
},
"platform": {
"release": "5.15.0-56-generic",
"system": "Linux"
},
"system_ssl": {
"version": "30000020"
},
"urllib3.future": {
"cohabitation_version": null,
"version": "2.8.904"
},
"wassima": {
"certifi_fallback": false,
"enabled": true,
"version": "1.1.1"
}
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6783/reactions"
} | https://api.github.com/repos/psf/requests/issues/6783/timeline | null | not_planned | null | null | false | [
"Hi @ezbik, Requests notes it only supports http/1.1 throughout our documentation.\n\nAny issues with other libraries trying to add QUIC or h2 support on top of Requests will need to be triaged there. We do not support this functionality.",
"@nateprewitt then the documentation (proxies section) should be updated to prevent the users even trying to use http2 or http3 through the proxies.. ",
"Can you point to what in our documentation suggested we'd be able to support new protocols specifically over SOCKS that we don't support otherwise?"
] |
https://api.github.com/repos/psf/requests/issues/6782 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6782/labels{/name} | https://api.github.com/repos/psf/requests/issues/6782/comments | https://api.github.com/repos/psf/requests/issues/6782/events | https://github.com/psf/requests/issues/6782 | 2,445,493,555 | I_kwDOABTKOs6Rw0Uz | 6,782 | Doc: missing example | {
"avatar_url": "https://avatars.githubusercontent.com/u/64604304?v=4",
"events_url": "https://api.github.com/users/nixilb/events{/privacy}",
"followers_url": "https://api.github.com/users/nixilb/followers",
"following_url": "https://api.github.com/users/nixilb/following{/other_user}",
"gists_url": "https://api.github.com/users/nixilb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nixilb",
"id": 64604304,
"login": "nixilb",
"node_id": "MDQ6VXNlcjY0NjA0MzA0",
"organizations_url": "https://api.github.com/users/nixilb/orgs",
"received_events_url": "https://api.github.com/users/nixilb/received_events",
"repos_url": "https://api.github.com/users/nixilb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nixilb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nixilb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nixilb",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 2 | 2024-08-02T17:55:53Z | 2024-08-03T07:13:30Z | null | NONE | null | Looking at quickstart: a copy paste example that just works with status error magagement, is missing.
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6782/reactions"
} | https://api.github.com/repos/psf/requests/issues/6782/timeline | null | null | null | null | false | [
"Hi @nixilb, could you be more specific with what you're looking for? We have a [section](https://requests.readthedocs.io/en/latest/user/quickstart/#response-status-codes) in the Quickstart guide about this topic already.",
"some COMPLETE code one can copy paste and works \r\n\r\nlike (found in https://realpython.com/python-requests/)\r\n\r\n~~~~\r\nimport requests\r\nfrom requests.exceptions import HTTPError\r\n\r\ntry:\r\n response = requests.get(\"https://api.github.com\")\r\n response.raise_for_status()\r\n print(response.text)\r\nexcept HTTPError as http_err:\r\n print(f\"HTTP error occurred: {http_err}\")\r\nexcept Exception as err:\r\n print(f\"Other error occurred: {err}\")\r\nelse:\r\n print(\"Success!\")\r\n~~~~"
] |
https://api.github.com/repos/psf/requests/issues/6781 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6781/labels{/name} | https://api.github.com/repos/psf/requests/issues/6781/comments | https://api.github.com/repos/psf/requests/issues/6781/events | https://github.com/psf/requests/pull/6781 | 2,443,307,708 | PR_kwDOABTKOs53KrxW | 6,781 | Don't create default SSLContext if CA bundle isn't present | {
"avatar_url": "https://avatars.githubusercontent.com/u/916551?v=4",
"events_url": "https://api.github.com/users/AdamWill/events{/privacy}",
"followers_url": "https://api.github.com/users/AdamWill/followers",
"following_url": "https://api.github.com/users/AdamWill/following{/other_user}",
"gists_url": "https://api.github.com/users/AdamWill/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AdamWill",
"id": 916551,
"login": "AdamWill",
"node_id": "MDQ6VXNlcjkxNjU1MQ==",
"organizations_url": "https://api.github.com/users/AdamWill/orgs",
"received_events_url": "https://api.github.com/users/AdamWill/received_events",
"repos_url": "https://api.github.com/users/AdamWill/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AdamWill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AdamWill/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AdamWill",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-08-01T20:01:38Z | 2024-08-01T20:35:59Z | 2024-08-01T20:35:58Z | CONTRIBUTOR | null | Similar to e18879932287c2bf4bcee4ddf6ccb8a69b6fc656 , this also skips creation of the default SSLContext on FileNotFoundError, which is raised if DEFAULT_CA_BUNDLE_PATH does not exist.
See: https://bugzilla.redhat.com/show_bug.cgi?id=2297632 | {
"avatar_url": "https://avatars.githubusercontent.com/u/916551?v=4",
"events_url": "https://api.github.com/users/AdamWill/events{/privacy}",
"followers_url": "https://api.github.com/users/AdamWill/followers",
"following_url": "https://api.github.com/users/AdamWill/following{/other_user}",
"gists_url": "https://api.github.com/users/AdamWill/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AdamWill",
"id": 916551,
"login": "AdamWill",
"node_id": "MDQ6VXNlcjkxNjU1MQ==",
"organizations_url": "https://api.github.com/users/AdamWill/orgs",
"received_events_url": "https://api.github.com/users/AdamWill/received_events",
"repos_url": "https://api.github.com/users/AdamWill/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AdamWill/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AdamWill/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AdamWill",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6781/reactions"
} | https://api.github.com/repos/psf/requests/issues/6781/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6781.diff",
"html_url": "https://github.com/psf/requests/pull/6781",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6781.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6781"
} | true | [
"Hi @AdamWill, #6767 is likely the path forward at this point. We've found a number of sharp edges with the default caching behavior to a point it probably doesn't belong in Requests.",
"Ah, thanks, didn't see that one. I'll wait for it to be finalized then backport it. Thanks!"
] |
https://api.github.com/repos/psf/requests/issues/6780 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6780/labels{/name} | https://api.github.com/repos/psf/requests/issues/6780/comments | https://api.github.com/repos/psf/requests/issues/6780/events | https://github.com/psf/requests/pull/6780 | 2,442,808,351 | PR_kwDOABTKOs53I9Ep | 6,780 | Add NewModel class to models.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/84085749?v=4",
"events_url": "https://api.github.com/users/sarveshdss75/events{/privacy}",
"followers_url": "https://api.github.com/users/sarveshdss75/followers",
"following_url": "https://api.github.com/users/sarveshdss75/following{/other_user}",
"gists_url": "https://api.github.com/users/sarveshdss75/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sarveshdss75",
"id": 84085749,
"login": "sarveshdss75",
"node_id": "MDQ6VXNlcjg0MDg1NzQ5",
"organizations_url": "https://api.github.com/users/sarveshdss75/orgs",
"received_events_url": "https://api.github.com/users/sarveshdss75/received_events",
"repos_url": "https://api.github.com/users/sarveshdss75/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sarveshdss75/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sarveshdss75/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sarveshdss75",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-08-01T15:50:32Z | 2024-08-01T16:06:49Z | 2024-08-01T16:06:49Z | NONE | null | This PR adds a new class, NewModel, to models.py which includes methods for initialization, display, and updating values | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6780/reactions"
} | https://api.github.com/repos/psf/requests/issues/6780/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6780.diff",
"html_url": "https://github.com/psf/requests/pull/6780",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6780.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6780"
} | true | [
"Hi @sarveshdss75, it looks like this PR may have been mistakenly opened against the Requests project instead of your personal fork. I'll close this as we won't be able to merge this."
] |
https://api.github.com/repos/psf/requests/issues/6779 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6779/labels{/name} | https://api.github.com/repos/psf/requests/issues/6779/comments | https://api.github.com/repos/psf/requests/issues/6779/events | https://github.com/psf/requests/issues/6779 | 2,441,345,412 | I_kwDOABTKOs6Rg_mE | 6,779 | Support for py3.7 | {
"avatar_url": "https://avatars.githubusercontent.com/u/69460619?v=4",
"events_url": "https://api.github.com/users/anishj-crest/events{/privacy}",
"followers_url": "https://api.github.com/users/anishj-crest/followers",
"following_url": "https://api.github.com/users/anishj-crest/following{/other_user}",
"gists_url": "https://api.github.com/users/anishj-crest/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/anishj-crest",
"id": 69460619,
"login": "anishj-crest",
"node_id": "MDQ6VXNlcjY5NDYwNjE5",
"organizations_url": "https://api.github.com/users/anishj-crest/orgs",
"received_events_url": "https://api.github.com/users/anishj-crest/received_events",
"repos_url": "https://api.github.com/users/anishj-crest/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/anishj-crest/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anishj-crest/subscriptions",
"type": "User",
"url": "https://api.github.com/users/anishj-crest",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156041422,
"name": "actions/autoclose-feat",
"node_id": "LA_kwDOABTKOs8AAAABbu28zg",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-feat"
}
] | closed | true | null | [] | null | 1 | 2024-08-01T03:04:30Z | 2024-08-01T03:04:39Z | 2024-08-01T03:04:38Z | NONE | off-topic | Hi Team,
We are on an application which still supports py3.7 and it would for a year. I understand it is already EOL, but it is more of a compatibility decision.
With the recent vulnerability found in v2.31.0, which was py3.7 supported, we need to fix this, but we can't upgrade as the newer versions don't support py3.7.
If the newer versions of requests can't support py3.7, Would it be possible to have a patch version v2.31.1 which fixes the recent vulnerabilities being found? Any help here would be beneficial to us.
Thanks! | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6779/reactions"
} | https://api.github.com/repos/psf/requests/issues/6779/timeline | null | not_planned | null | null | false | [
"As described in the template, Requests is not accepting feature requests"
] |
https://api.github.com/repos/psf/requests/issues/6778 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6778/labels{/name} | https://api.github.com/repos/psf/requests/issues/6778/comments | https://api.github.com/repos/psf/requests/issues/6778/events | https://github.com/psf/requests/issues/6778 | 2,441,344,146 | I_kwDOABTKOs6Rg_SS | 6,778 | Request for py3.7 support | {
"avatar_url": "https://avatars.githubusercontent.com/u/69460619?v=4",
"events_url": "https://api.github.com/users/anishj-crest/events{/privacy}",
"followers_url": "https://api.github.com/users/anishj-crest/followers",
"following_url": "https://api.github.com/users/anishj-crest/following{/other_user}",
"gists_url": "https://api.github.com/users/anishj-crest/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/anishj-crest",
"id": 69460619,
"login": "anishj-crest",
"node_id": "MDQ6VXNlcjY5NDYwNjE5",
"organizations_url": "https://api.github.com/users/anishj-crest/orgs",
"received_events_url": "https://api.github.com/users/anishj-crest/received_events",
"repos_url": "https://api.github.com/users/anishj-crest/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/anishj-crest/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anishj-crest/subscriptions",
"type": "User",
"url": "https://api.github.com/users/anishj-crest",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-08-01T03:03:10Z | 2024-08-01T03:03:21Z | 2024-08-01T03:03:20Z | NONE | off-topic | Hi Team,
We are on an application which still supports py3.7 and it would for a year. I understand it is already EOL, but it is more of a compatibility decision.
With the recent vulnerability found in v2.31.0, which was py3.7 supported, we need to fix this, but we can't upgrade as the newer versions don't support py3.7.
If the newer versions of requests can't support py3.7, Would it be possible to have a patch version v2.31.1 which fixes the recent vulnerabilities being found? Any help here would be beneficial to us.
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6778/reactions"
} | https://api.github.com/repos/psf/requests/issues/6778/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6777 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6777/labels{/name} | https://api.github.com/repos/psf/requests/issues/6777/comments | https://api.github.com/repos/psf/requests/issues/6777/events | https://github.com/psf/requests/issues/6777 | 2,439,802,444 | I_kwDOABTKOs6RbG5M | 6,777 | What should be Overwritten to ignore all verification in a custom adapter? | {
"avatar_url": "https://avatars.githubusercontent.com/u/5131271?v=4",
"events_url": "https://api.github.com/users/achapkowski/events{/privacy}",
"followers_url": "https://api.github.com/users/achapkowski/followers",
"following_url": "https://api.github.com/users/achapkowski/following{/other_user}",
"gists_url": "https://api.github.com/users/achapkowski/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/achapkowski",
"id": 5131271,
"login": "achapkowski",
"node_id": "MDQ6VXNlcjUxMzEyNzE=",
"organizations_url": "https://api.github.com/users/achapkowski/orgs",
"received_events_url": "https://api.github.com/users/achapkowski/received_events",
"repos_url": "https://api.github.com/users/achapkowski/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/achapkowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/achapkowski/subscriptions",
"type": "User",
"url": "https://api.github.com/users/achapkowski",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 2 | 2024-07-31T11:21:38Z | 2024-07-31T18:11:39Z | null | NONE | null | Hello,
I wish to use a custom adapter that I can use to access servers with old and expired certificates so I can automate the updating of the SSL certs. The doc isn't really clear, so I consider this a bug.
I have the following:
```
###########################################################################
class TruststoreAdapter(HTTPAdapter):
"""An adapter for requests. This supplies the a custom ssl_context to a set of requests."""
custom_context: truststore.SSLContext | ssl.SSLContext = None
def __init__(
self,
pool_connections=DEFAULT_POOLSIZE,
pool_maxsize=DEFAULT_POOLSIZE,
max_retries=DEFAULT_RETRIES,
pool_block=DEFAULT_POOLBLOCK,
ssl_context: truststore.SSLContext | ssl.SSLContext | None = None,
):
self.custom_context = ssl_context
super().__init__(
pool_connections=pool_connections,
pool_maxsize=pool_maxsize,
max_retries=max_retries,
pool_block=pool_block,
)
# ---------------------------------------------------------------------
def __str__(self) -> str:
return f"< {self.__class__.__name__} >"
# ---------------------------------------------------------------------
def __repr__(self) -> str:
return f"< {self.__class__.__name__} >"
# ---------------------------------------------------------------------
def init_poolmanager(self, connections, maxsize, block=False):
ctx = self.custom_context
return super().init_poolmanager(connections, maxsize, block, ssl_context=ctx)
```
Where the SSL Context is defined as:
```
ssl_context: truststore.SSLContext = truststore.SSLContext()
ssl_context.check_hostname = False
ssl_context.verify_mode = 0 # No check
```
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6777/reactions"
} | https://api.github.com/repos/psf/requests/issues/6777/timeline | null | null | null | null | false | [
"Hi @achapkowski, could you clarify what exactly you'd be looking for in the Requests documentation? We cover what the Adapter intent is at a high-level, what the end user chooses to modify is very open-ended. `urllib3` provides [docs](https://urllib3.readthedocs.io/en/stable/advanced-usage.html#custom-ssl-contexts) on how to provide a custom SSLContext to their Poolmanager which seems to be the change you're trying to make.",
"@nateprewitt I'll check out this doc and get back in a few. If my answer is there I will close this.\r\n\r\nWhat I am seeing is that if the common name of an SSL certificate has a mismatch, and exception when you provide a custom SSLContext object in the above http adapter. So I was wondering if some other setting needs to be set to not verify common names. "
] |
https://api.github.com/repos/psf/requests/issues/6776 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6776/labels{/name} | https://api.github.com/repos/psf/requests/issues/6776/comments | https://api.github.com/repos/psf/requests/issues/6776/events | https://github.com/psf/requests/issues/6776 | 2,439,800,167 | I_kwDOABTKOs6RbGVn | 6,776 | Documentation of what to override when using custom adapter | {
"avatar_url": "https://avatars.githubusercontent.com/u/5131271?v=4",
"events_url": "https://api.github.com/users/achapkowski/events{/privacy}",
"followers_url": "https://api.github.com/users/achapkowski/followers",
"following_url": "https://api.github.com/users/achapkowski/following{/other_user}",
"gists_url": "https://api.github.com/users/achapkowski/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/achapkowski",
"id": 5131271,
"login": "achapkowski",
"node_id": "MDQ6VXNlcjUxMzEyNzE=",
"organizations_url": "https://api.github.com/users/achapkowski/orgs",
"received_events_url": "https://api.github.com/users/achapkowski/received_events",
"repos_url": "https://api.github.com/users/achapkowski/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/achapkowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/achapkowski/subscriptions",
"type": "User",
"url": "https://api.github.com/users/achapkowski",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156041422,
"name": "actions/autoclose-feat",
"node_id": "LA_kwDOABTKOs8AAAABbu28zg",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-feat"
}
] | closed | true | null | [] | null | 1 | 2024-07-31T11:20:19Z | 2024-07-31T11:20:31Z | 2024-07-31T11:20:30Z | NONE | off-topic | Hello,
I wish to use a custom adapter that I can use to access servers with old and expired certificates so I can automate the updating of the SSL certs.
I have the following:
```
###########################################################################
class TruststoreAdapter(HTTPAdapter):
"""An adapter for requests. This supplies the a custom ssl_context to a set of requests."""
custom_context: truststore.SSLContext | ssl.SSLContext = None
def __init__(
self,
pool_connections=DEFAULT_POOLSIZE,
pool_maxsize=DEFAULT_POOLSIZE,
max_retries=DEFAULT_RETRIES,
pool_block=DEFAULT_POOLBLOCK,
ssl_context: truststore.SSLContext | ssl.SSLContext | None = None,
):
self.custom_context = ssl_context
super().__init__(
pool_connections=pool_connections,
pool_maxsize=pool_maxsize,
max_retries=max_retries,
pool_block=pool_block,
)
# ---------------------------------------------------------------------
def __str__(self) -> str:
return f"< {self.__class__.__name__} >"
# ---------------------------------------------------------------------
def __repr__(self) -> str:
return f"< {self.__class__.__name__} >"
# ---------------------------------------------------------------------
def init_poolmanager(self, connections, maxsize, block=False):
ctx = self.custom_context
return super().init_poolmanager(connections, maxsize, block, ssl_context=ctx)
```
Where the SSL Context is defined as:
```
ssl_context: truststore.SSLContext = truststore.SSLContext()
ssl_context.check_hostname = False
ssl_context.verify_mode = 0 # No check
```
| {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6776/reactions"
} | https://api.github.com/repos/psf/requests/issues/6776/timeline | null | not_planned | null | null | false | [
"As described in the template, Requests is not accepting feature requests"
] |
https://api.github.com/repos/psf/requests/issues/6775 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6775/labels{/name} | https://api.github.com/repos/psf/requests/issues/6775/comments | https://api.github.com/repos/psf/requests/issues/6775/events | https://github.com/psf/requests/issues/6775 | 2,435,150,377 | I_kwDOABTKOs6RJXIp | 6,775 | With setuptools 72.0.0 requests can no longer be installed from git | {
"avatar_url": "https://avatars.githubusercontent.com/u/5781356?v=4",
"events_url": "https://api.github.com/users/felixfontein/events{/privacy}",
"followers_url": "https://api.github.com/users/felixfontein/followers",
"following_url": "https://api.github.com/users/felixfontein/following{/other_user}",
"gists_url": "https://api.github.com/users/felixfontein/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/felixfontein",
"id": 5781356,
"login": "felixfontein",
"node_id": "MDQ6VXNlcjU3ODEzNTY=",
"organizations_url": "https://api.github.com/users/felixfontein/orgs",
"received_events_url": "https://api.github.com/users/felixfontein/received_events",
"repos_url": "https://api.github.com/users/felixfontein/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/felixfontein/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/felixfontein/subscriptions",
"type": "User",
"url": "https://api.github.com/users/felixfontein",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 5 | 2024-07-29T11:19:55Z | 2024-07-31T03:28:13Z | 2024-07-29T15:10:26Z | NONE | null | ## Expected Result
`pip install git+https://github.com/psf/requests` gives me the latest development version of `requests`.
## Actual Result
Installation fails due to [an import in setup.py](https://github.com/psf/requests/blob/main/setup.py#L7):
```
Running command git clone -q https://github.com/psf/requests /tmp/pip-req-build-bwz96dmd
ERROR: Command errored out with exit status 1:
command: /usr/bin/python3.9 /usr/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py get_requires_for_build_wheel /tmp/tmpqmb1elhu
cwd: /tmp/pip-req-build-bwz96dmd
Complete output (17 lines):
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 349, in <module>
main()
File "/usr/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 331, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/usr/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 117, in get_requires_for_build_wheel
return hook(config_settings)
File "/tmp/pip-build-env-thl7ju8g/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 327, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
File "/tmp/pip-build-env-thl7ju8g/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 297, in _get_build_requires
self.run_setup()
File "/tmp/pip-build-env-thl7ju8g/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 497, in run_setup
super().run_setup(setup_script=setup_script)
File "/tmp/pip-build-env-thl7ju8g/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 313, in run_setup
exec(code, locals())
File "<string>", line 7, in <module>
ModuleNotFoundError: No module named 'setuptools.command.test'
----------------------------------------
WARNING: Discarding git+https://github.com/psf/requests. Command errored out with exit status 1: /usr/bin/python3.9 /usr/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py get_requires_for_build_wheel /tmp/tmpqmb1elhu Check the logs for full command output.
ERROR: Command errored out with exit status 1: /usr/bin/python3.9 /usr/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py get_requires_for_build_wheel /tmp/tmpqmb1elhu Check the logs for full command output.
```
See the setuptools changelog: https://setuptools.pypa.io/en/stable/history.html#v72-0-0
> The test command has been removed. Users relying on ‘setup.py test’ will need to migrate to another test runner or pin setuptools before this version. ([#931](https://github.com/pypa/setuptools/issues/931))
## Reproduction Steps
Create a venv with latest setuptools. Then run `pip install git+https://github.com/psf/requests`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6775/reactions"
} | https://api.github.com/repos/psf/requests/issues/6775/timeline | null | completed | null | null | false | [
"See also #6774 ",
"This change was reverted in setuptools with https://github.com/pypa/setuptools/commit/441799f8b45a1a01c608db49333403db1b0d7100. We'll work on the deprecation in an upcoming release.",
"I was surprised to hear that Requests was affected by this, because (just as I recalled) its own source code is Python-only. Looking around a bit, I conclude:\r\n\r\n* Developers don't appear to be using any kind of deprecated `setup.py`-based workflow, instead relying on a Makefile, Tox etc.\r\n* There is already a `pyproject.toml`, but it only contains configuration for dev tools (`isort` and `pytest`)\r\n* Aside from the just-removed code for a `test` command, `setup.py` is currently used for:\r\n * an \"unsupported Python version\" warning; but this should be redundant with `requires-python` metadata, Pip functionality etc.\r\n * a `setup.py publish` shortcut (which doesn't go through the Setuptools machinery but just inspects `sys.argv`); but this is redundant with and inferior to the `publish` target in the Makefile\r\n * reading `__version__.py` to get some dynamic metadata; but this can be done by configuring `[tool.setuptools.dynamic]` in `pyproject.toml`\r\n\r\nIn conclusion, AFAICT, nothing currently done in `setup.py` *needs* to be done there, and the continued existence of this file just exposes the risk of future speed bumps as further attempts are made to deprecate and disable old workflows.\r\n\r\nWould there be any interest in a PR to migrate the project to a proper PEP517-conformant build, such as I already offered to another project [here](https://github.com/tomislater/RandomWords/pull/16)?",
"Thanks @zahlman, we already have the work done for this and announced the change back in May in our [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md#2320-2024-05-20). As stated above, this will be included in the next minor version release.",
"Apologies, I misunderstood the implications of \"work on the deprecation\". Cheers :)"
] |
https://api.github.com/repos/psf/requests/issues/6774 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6774/labels{/name} | https://api.github.com/repos/psf/requests/issues/6774/comments | https://api.github.com/repos/psf/requests/issues/6774/events | https://github.com/psf/requests/pull/6774 | 2,434,388,352 | PR_kwDOABTKOs52sNM_ | 6,774 | remove setuptools test command | {
"avatar_url": "https://avatars.githubusercontent.com/u/19800529?v=4",
"events_url": "https://api.github.com/users/branchvincent/events{/privacy}",
"followers_url": "https://api.github.com/users/branchvincent/followers",
"following_url": "https://api.github.com/users/branchvincent/following{/other_user}",
"gists_url": "https://api.github.com/users/branchvincent/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/branchvincent",
"id": 19800529,
"login": "branchvincent",
"node_id": "MDQ6VXNlcjE5ODAwNTI5",
"organizations_url": "https://api.github.com/users/branchvincent/orgs",
"received_events_url": "https://api.github.com/users/branchvincent/received_events",
"repos_url": "https://api.github.com/users/branchvincent/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/branchvincent/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/branchvincent/subscriptions",
"type": "User",
"url": "https://api.github.com/users/branchvincent",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 9 | 2024-07-29T03:50:26Z | 2024-07-30T00:23:19Z | 2024-07-29T13:49:17Z | CONTRIBUTOR | null | `setuptools==72.0.0` just [removed their test command](https://github.com/pypa/setuptools/blob/main/NEWS.rst#deprecations-and-removals) so this import now fails | {
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
} | {
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/6774/reactions"
} | https://api.github.com/repos/psf/requests/issues/6774/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6774.diff",
"html_url": "https://github.com/psf/requests/pull/6774",
"merged_at": "2024-07-29T13:49:17Z",
"patch_url": "https://github.com/psf/requests/pull/6774.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6774"
} | true | [
"@nateprewitt @sigmavirus24 I don't know if this /needs/ a release, users installing from wheels should be unaffected. Mostly seems like it's affecting folks installing from git.",
"Installing from git is only one way to hit the issue... It affects people using `pip install --no-binary :all:` as well.",
"@eli-schwartz Right, but Requests being a pure-Python package I hope that most people aren't installing from the sdist. I believe it's also possible to downgrade setuptools so users can install this way if needed in a pinch.",
"I think the temporary solution is to downgrade setuptools, we already slated for moving to `pyproject.toml` in the next release which would have already included this change. I would have probably waited until we resolve #6767 and #6757 but this is fine. I highly doubt this still has notable usage outside of maybe distro maintainers.",
"> @eli-schwartz Right, but Requests being a pure-Python package I hope that most people aren't installing from the sdist. I believe it's also possible to downgrade setuptools so users can install this way if needed in a pinch.\r\n\r\n> I highly doubt this still has notable usage outside of maybe distro maintainers.\r\n\r\nLinux distros are unconditionally installing from the sdist, and as far as they are concerned there is nothing to discuss.\r\n\r\nOf course, 50 different organizations can *all* backport this patch, one by one, individually... :) and indeed one can question whether this has \"notable\" usage. If not too much time passes before the next release, then not all those distros will even notice the issue if they have existing installable .deb or .rpm releases. Other distros, especially distros which build from source by default (e.g. Gentoo) will definitely notice immediately.\r\n\r\nPeople using `pip install --no-binary :all:` may be using it because they expect all sdists to validly build (\"who uploads broken sdists to PyPI anyway\") and want to ensure that all sdists which happen to ship compiled C extensions are built fresh, using system libraries instead of auditwheel vendored ones. There are other reasons to use --no-binary, but this is definitely one of them. And those people would not necessarily be expecting that requests *specifically* should be built from an sdist, but babysitting every single recursive dependency in their stack would be a lot of pain for zero gain. They \"could\" go fix up all their CI / release scripts to manually exclude requests, but it would be... disruptive. :)\r\n\r\nAgain, maybe such people don't count as \"notable usage\".",
"> we already slated for moving to `pyproject.toml` in the next release which would have already included this change. I would have probably waited until we resolve #6767 and #6757 but this is fine.\r\n\r\nWhat's the timeframe for the next release? Is there likely to be one in the next week? Next month? Will it take 12 months? :D The existing tag history leads me to think I shouldn't attempt to read anything into its cadence.",
"This patch will likely now go out prior to the next minor version release which is when we've announced a move to pyproject.toml. I would anticipate a release with this update to be in the coming weeks depending on availability.",
"@eli-schwartz and for the record, this change was already reverted https://github.com/pypa/setuptools/commit/441799f8b45a1a01c608db49333403db1b0d7100.",
"Aha, that is convenient. Not much to do then."
] |
https://api.github.com/repos/psf/requests/issues/6773 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6773/labels{/name} | https://api.github.com/repos/psf/requests/issues/6773/comments | https://api.github.com/repos/psf/requests/issues/6773/events | https://github.com/psf/requests/pull/6773 | 2,433,915,924 | PR_kwDOABTKOs52qqDN | 6,773 | Clarify error description in cloning instructions | {
"avatar_url": "https://avatars.githubusercontent.com/u/40581230?v=4",
"events_url": "https://api.github.com/users/anodo123/events{/privacy}",
"followers_url": "https://api.github.com/users/anodo123/followers",
"following_url": "https://api.github.com/users/anodo123/following{/other_user}",
"gists_url": "https://api.github.com/users/anodo123/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/anodo123",
"id": 40581230,
"login": "anodo123",
"node_id": "MDQ6VXNlcjQwNTgxMjMw",
"organizations_url": "https://api.github.com/users/anodo123/orgs",
"received_events_url": "https://api.github.com/users/anodo123/received_events",
"repos_url": "https://api.github.com/users/anodo123/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/anodo123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anodo123/subscriptions",
"type": "User",
"url": "https://api.github.com/users/anodo123",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-07-28T12:46:52Z | 2024-07-28T12:46:52Z | null | NONE | null | This clarifies the error description in the 'Cloning the repository' section of the README. The current wording mentions 'an error about a bad commit', which is somewhat vague. I've updated it to 'an error about a bad commit timestamp', which more accurately describes the nature of the error referenced in issue #2690. This small change improves the clarity of the documentation, helping users better understand the potential issue they might encounter when cloning the repository and why they need to use the specified Git flag. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6773/reactions"
} | https://api.github.com/repos/psf/requests/issues/6773/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6773.diff",
"html_url": "https://github.com/psf/requests/pull/6773",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6773.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6773"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6772 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6772/labels{/name} | https://api.github.com/repos/psf/requests/issues/6772/comments | https://api.github.com/repos/psf/requests/issues/6772/events | https://github.com/psf/requests/pull/6772 | 2,431,274,058 | PR_kwDOABTKOs52h5mG | 6,772 | chore(charset issue): Resolution for issue 6102 | {
"avatar_url": "https://avatars.githubusercontent.com/u/75703762?v=4",
"events_url": "https://api.github.com/users/kalingth/events{/privacy}",
"followers_url": "https://api.github.com/users/kalingth/followers",
"following_url": "https://api.github.com/users/kalingth/following{/other_user}",
"gists_url": "https://api.github.com/users/kalingth/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kalingth",
"id": 75703762,
"login": "kalingth",
"node_id": "MDQ6VXNlcjc1NzAzNzYy",
"organizations_url": "https://api.github.com/users/kalingth/orgs",
"received_events_url": "https://api.github.com/users/kalingth/received_events",
"repos_url": "https://api.github.com/users/kalingth/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kalingth/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kalingth/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kalingth",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-07-26T02:07:05Z | 2024-07-26T04:26:55Z | null | NONE | null | Resolution for the issue https://github.com/psf/requests/issues/6102
Now, If a username and password are passed already encoded, they will not be affected by being expected as a string. In this case, the function will encode the string-formatted attributes into bytes using the latin-1 charset by default due to convention. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6772/reactions"
} | https://api.github.com/repos/psf/requests/issues/6772/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6772.diff",
"html_url": "https://github.com/psf/requests/pull/6772",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6772.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6772"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6771 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6771/labels{/name} | https://api.github.com/repos/psf/requests/issues/6771/comments | https://api.github.com/repos/psf/requests/issues/6771/events | https://github.com/psf/requests/pull/6771 | 2,430,337,617 | PR_kwDOABTKOs52e8GK | 6,771 | Handle multiple paths/cert files in 'REQUESTS_CA_BUNDLE' environment variable | {
"avatar_url": "https://avatars.githubusercontent.com/u/1844404?v=4",
"events_url": "https://api.github.com/users/jhess/events{/privacy}",
"followers_url": "https://api.github.com/users/jhess/followers",
"following_url": "https://api.github.com/users/jhess/following{/other_user}",
"gists_url": "https://api.github.com/users/jhess/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jhess",
"id": 1844404,
"login": "jhess",
"node_id": "MDQ6VXNlcjE4NDQ0MDQ=",
"organizations_url": "https://api.github.com/users/jhess/orgs",
"received_events_url": "https://api.github.com/users/jhess/received_events",
"repos_url": "https://api.github.com/users/jhess/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jhess/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jhess/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jhess",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 136589914,
"name": "Needs Info",
"node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info"
},
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | false | null | [] | null | 1 | 2024-07-25T15:37:34Z | 2024-08-01T22:02:55Z | 2024-08-01T22:02:55Z | NONE | null | An OSError just gets raised saying the cert_loc is an invalid path if you have several CA certificate paths 'REQUESTS_CA_BUNDLE' environment variable separated by the standard ";" delimiter. It should handle this by at the very least by returning an error telling the user to append the certificates to their global trust CA file and just use one certificate instead of saying it is an invalid path, if not support multiple CA certificate files in the environment variable. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6771/reactions"
} | https://api.github.com/repos/psf/requests/issues/6771/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6771.diff",
"html_url": "https://github.com/psf/requests/pull/6771",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6771.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6771"
} | true | [
"Hi @jhess, could you provide more info on why you would expect chained paths to work in this case? CA Bundle is generally defined as \"_CA bundle is **a file** that contains root and intermediate certificates._\". We would expect input of a single file for this parameter and that is also the documented behavior of `CURL_CA_BUNDLE` which the parameter was originally based off.\r\n\r\nI don't think this is behavior we would generally want to add since it's both surprising to the average user and introduces other parsing complications for a relatively simple interface."
] |
https://api.github.com/repos/psf/requests/issues/6770 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6770/labels{/name} | https://api.github.com/repos/psf/requests/issues/6770/comments | https://api.github.com/repos/psf/requests/issues/6770/events | https://github.com/psf/requests/pull/6770 | 2,428,863,569 | PR_kwDOABTKOs52aMBL | 6,770 | Header-based auth class | {
"avatar_url": "https://avatars.githubusercontent.com/u/5308250?v=4",
"events_url": "https://api.github.com/users/vilhelmen/events{/privacy}",
"followers_url": "https://api.github.com/users/vilhelmen/followers",
"following_url": "https://api.github.com/users/vilhelmen/following{/other_user}",
"gists_url": "https://api.github.com/users/vilhelmen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vilhelmen",
"id": 5308250,
"login": "vilhelmen",
"node_id": "MDQ6VXNlcjUzMDgyNTA=",
"organizations_url": "https://api.github.com/users/vilhelmen/orgs",
"received_events_url": "https://api.github.com/users/vilhelmen/received_events",
"repos_url": "https://api.github.com/users/vilhelmen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vilhelmen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vilhelmen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vilhelmen",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-07-25T02:59:15Z | 2024-07-25T02:59:15Z | null | NONE | null | This adds a short and simple header-based auth backend (and tests!). This allows greater flexibility in auth mechanisms out of the box.
For example, I'm working on on an internal library to interface with OGC services and three providers use three different auth mechanisms. Being able to consolidate this via the auth parameter seems like the correct solution.
It's worth noting that because of when this executes, auth objects override the headers provided both by the session and request call. This has been appropriately documented, and I don't believe any other option would be preferable.
Looks like someone proposed this in 2018 (#4823) but was rejected because of a feature freeze at the time.
If this is acceptable, would the team be interested in something similar like HTTPParamAuth that uses a dict of parameters in a similar fashion? Going back to my library example, one provider uses oauth, which requests supports, one uses headers, and one uses a custom api key parameter. Totally willing to add it to this PR if it simplifies approval :) | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6770/reactions"
} | https://api.github.com/repos/psf/requests/issues/6770/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6770.diff",
"html_url": "https://github.com/psf/requests/pull/6770",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6770.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6770"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6769 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6769/labels{/name} | https://api.github.com/repos/psf/requests/issues/6769/comments | https://api.github.com/repos/psf/requests/issues/6769/events | https://github.com/psf/requests/pull/6769 | 2,420,991,928 | PR_kwDOABTKOs51_huc | 6,769 | chore(models): add type hints to improve type safety | {
"avatar_url": "https://avatars.githubusercontent.com/u/25590915?v=4",
"events_url": "https://api.github.com/users/deyjoy/events{/privacy}",
"followers_url": "https://api.github.com/users/deyjoy/followers",
"following_url": "https://api.github.com/users/deyjoy/following{/other_user}",
"gists_url": "https://api.github.com/users/deyjoy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/deyjoy",
"id": 25590915,
"login": "deyjoy",
"node_id": "MDQ6VXNlcjI1NTkwOTE1",
"organizations_url": "https://api.github.com/users/deyjoy/orgs",
"received_events_url": "https://api.github.com/users/deyjoy/received_events",
"repos_url": "https://api.github.com/users/deyjoy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/deyjoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/deyjoy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/deyjoy",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-07-20T17:42:56Z | 2024-07-21T01:20:52Z | 2024-07-20T17:46:24Z | NONE | null | ### Summary
This pull request adds type hints to the `models.py` file in the `requests` library. The goal is to improve code readability and maintainability by specifying the expected types for function arguments and return values.
### Changes
- Added type hints to all functions and methods in `models.py`.
### Checklist
- [x] Add type hints to function signatures.
- [x] Run tests to verify no breaking changes.
### Testing
All existing tests were run to ensure that adding type hints did not introduce any breaking changes. The test results are as follows:
- 602 tests passed
- 3 tests skipped
- 1 test expected to fail (xfail)
- 18 warnings
### Warnings
The following warnings were noted during testing:
- DeprecationWarning: Non-string usernames will no longer be supported in Requests 3.0.0.
- DeprecationWarning: Non-string passwords will no longer be supported in Requests 3.0.0.
- DeprecationWarning: In requests 3.0, get_encodings_from_content will be removed.
- InsecureRequestWarning: Unverified HTTPS request is being made to host 'localhost'. Adding certificate verification is strongly advised.
These warnings do not impact the functionality of this PR but should be addressed in future updates.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6769/reactions"
} | https://api.github.com/repos/psf/requests/issues/6769/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6769.diff",
"html_url": "https://github.com/psf/requests/pull/6769",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6769.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6769"
} | true | [
"Thanks for the PR, @deyjoy. Typing for Requests is already available in typeshed as stubs. We likely won't be adding inline typing to Requests in the near future.",
"Thank you for the update, @nateprewitt. I understand that inline typing won't be added as typings are already available in typeshed stubs. I appreciate the feedback and the chance to contribute. I will look for other areas where I can assist. If there are any specific needs or suggestions, please let me know. Thanks again for the opportunity!"
] |
https://api.github.com/repos/psf/requests/issues/6768 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6768/labels{/name} | https://api.github.com/repos/psf/requests/issues/6768/comments | https://api.github.com/repos/psf/requests/issues/6768/events | https://github.com/psf/requests/issues/6768 | 2,418,771,407 | I_kwDOABTKOs6QK4XP | 6,768 | Same code works with Python 3.10 but not with 3.11 | {
"avatar_url": "https://avatars.githubusercontent.com/u/61155988?v=4",
"events_url": "https://api.github.com/users/djtech-dev/events{/privacy}",
"followers_url": "https://api.github.com/users/djtech-dev/followers",
"following_url": "https://api.github.com/users/djtech-dev/following{/other_user}",
"gists_url": "https://api.github.com/users/djtech-dev/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/djtech-dev",
"id": 61155988,
"login": "djtech-dev",
"node_id": "MDQ6VXNlcjYxMTU1OTg4",
"organizations_url": "https://api.github.com/users/djtech-dev/orgs",
"received_events_url": "https://api.github.com/users/djtech-dev/received_events",
"repos_url": "https://api.github.com/users/djtech-dev/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/djtech-dev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/djtech-dev/subscriptions",
"type": "User",
"url": "https://api.github.com/users/djtech-dev",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-07-19T12:28:24Z | 2024-07-22T18:00:06Z | 2024-07-22T18:00:05Z | NONE | null | The investpy library doesn't work under CPython 3.11 while it works without issues with CPython 3.10
## Expected Result
In the [search.py](https://github.com/alvarobartt/investpy/blob/master/investpy/search.py) file, at line 157 (function `search_quotes`), I get a ConnectionError (not raised by requests, but connected to the status_code returned by requests). This error is weirdly only raised on Python 3.11, while Python 3.10 works without issue.
I've edited the code in order to print some important informations (the parameters and the output for the requests's POST function).
Snippet (original, can be found at the link before):
```python
req = requests.post(url, headers=headers, data=params)
if req.status_code != 200:
raise ConnectionError(
f"ERR#0015: error {req.status_code}, try again later."
)
data = req.json()
```
Snippet (modified, added print statements and a static user agent, while the original project generated each time a new user agent in order to fake activity):
```python
headers = {'User-Agent': 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 GTB5', 'X-Requested-With': 'XMLHttpRequest', 'Accept': 'text/html', 'Accept-Encoding': 'gzip, deflate', 'Connection': 'keep-alive'}
print(params)
print("---")
print(headers)
req = requests.post(url, headers=headers, data=params)
print("---")
print(req)
if req.status_code != 200:
raise ConnectionError(
f"ERR#0015: error {req.status_code}, try again later."
)
data = req.json()
```
Result on CPython 3.10:
```
>>> investsearch.search_quotes("IBM")
{'search_text': 'IBM', 'tab': 'quotes', 'isFilter': True, 'limit': 270, 'offset': 0}
---
{'User-Agent': 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 GTB5', 'X-Requested-With': 'XMLHttpRequest', 'Accept': 'text/html', 'Accept-Encoding': 'gzip, deflate', 'Connection': 'keep-alive'}
---
<Response [200]>
[<investpy.utils.search_obj.SearchObj object at 0x7fdd838952d0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd837e6680>, <investpy.utils.search_obj.SearchObj object at 0x7fdd8381d900>, <investpy.utils.search_obj.SearchObj object at 0x7fdd838cf370>, <investpy.utils.search_obj.SearchObj object at 0x7fdd838cc8e0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd838cf340>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfb190>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfb1f0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfb250>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfb280>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfb2b0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfb160>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9cc0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9cf0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9d20>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfbe20>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9c90>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9ff0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfb220>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfb2e0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfa020>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfa050>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9ed0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9f60>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfa0b0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfa200>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bfbf70>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9f90>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9f30>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9ea0>, <investpy.utils.search_obj.SearchObj object at 0x7fdd74bf9e70>]
```
## Actual Result
Results on CPython 3.11:
```
>>> investsearch.search_quotes("IBM")
{'search_text': 'IBM', 'tab': 'quotes', 'isFilter': True, 'limit': 270, 'offset': 0}
---
{'User-Agent': 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 GTB5', 'X-Requested-With': 'XMLHttpRequest', 'Accept': 'text/html', 'Accept-Encoding': 'gzip, deflate', 'Connection': 'keep-alive'}
---
<Response [403]>
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/giuseppe/project_348/Financials-Extension/investpy/investpy/search.py", line 166, in search_quotes
raise ConnectionError(
ConnectionError: ERR#0015: error 403, try again later.
```
## Reproduction Steps
Use the snippet/library showed before.
## System Information
Running under CPython 3.10:
```json
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.10.14"
},
"platform": {
"release": "6.8.12-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30200010"
},
"urllib3": {
"version": "2.2.1"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
Running under CPython 3.11:
```json
/home/giuseppe/.local/lib/python3.11/site-packages/requests/help.py:24: DeprecationWarning: 'urllib3.contrib.pyopenssl' module is deprecated and will be removed in a future release of urllib3 2.x. Read more in this issue: https://github.com/urllib3/urllib3/issues/2680
from urllib3.contrib import pyopenssl
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": "42.0.5"
},
"idna": {
"version": "3.6"
},
"implementation": {
"name": "CPython",
"version": "3.11.9"
},
"platform": {
"release": "6.8.12-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30200010",
"version": "24.1.0"
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30200020"
},
"urllib3": {
"version": "1.26.18"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6768/reactions"
} | https://api.github.com/repos/psf/requests/issues/6768/timeline | null | completed | null | null | false | [
"403 error is issue with authentication/permission, so I don't think it is related to Python version or the requests library. Perhaps you can ask questions on Stack Overflow on why you're getting 403 error ",
"As @Mariatta correctly noted, the response behavior from the service isn't something we control. There are a number of reasons you may be receiving a different status code depending on Python version, both from your environment and potential service-side decisions based on client fingerprinting.\r\n\r\n[StackOverflow](https://stackoverflow.com/) is the best place to ask these questions unless you're able to provide a reproducible example without the service in question."
] |
https://api.github.com/repos/psf/requests/issues/6767 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6767/labels{/name} | https://api.github.com/repos/psf/requests/issues/6767/comments | https://api.github.com/repos/psf/requests/issues/6767/events | https://github.com/psf/requests/pull/6767 | 2,417,032,156 | PR_kwDOABTKOs51z-s- | 6,767 | Revert caching a default SSLContext | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-07-18T18:00:33Z | 2024-09-25T14:53:44Z | null | MEMBER | null | This PR reverts the changes from #6667 to the previous behavior. Due to the number of edge cases and concurrency issues we've encountered with this change, we've decided the benefit doesn't currently outweigh the pain to existing infrastructure. We've iterated on a few tries to keep this functionality in place, but are still receiving reports of novel issues with this behavior.
We may be able to revisit this in a later version of Requests but we'll need a much more comprehensive test plan. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6767/reactions"
} | https://api.github.com/repos/psf/requests/issues/6767/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6767.diff",
"html_url": "https://github.com/psf/requests/pull/6767",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6767.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6767"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6766 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6766/labels{/name} | https://api.github.com/repos/psf/requests/issues/6766/comments | https://api.github.com/repos/psf/requests/issues/6766/events | https://github.com/psf/requests/issues/6766 | 2,402,442,600 | I_kwDOABTKOs6PMl1o | 6,766 | 一个while True requests运行的爬虫程序，会报错：HTTPSConnectionPool(host='***', port=443): Max retries exceeded with url: /aa (Caused by SSLError(OSError(24, 'Too many open files'))) | {
"avatar_url": "https://avatars.githubusercontent.com/u/72457235?v=4",
"events_url": "https://api.github.com/users/wucyAAA/events{/privacy}",
"followers_url": "https://api.github.com/users/wucyAAA/followers",
"following_url": "https://api.github.com/users/wucyAAA/following{/other_user}",
"gists_url": "https://api.github.com/users/wucyAAA/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wucyAAA",
"id": 72457235,
"login": "wucyAAA",
"node_id": "MDQ6VXNlcjcyNDU3MjM1",
"organizations_url": "https://api.github.com/users/wucyAAA/orgs",
"received_events_url": "https://api.github.com/users/wucyAAA/received_events",
"repos_url": "https://api.github.com/users/wucyAAA/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wucyAAA/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wucyAAA/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wucyAAA",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-07-11T07:14:53Z | 2024-07-11T11:11:13Z | 2024-07-11T11:11:12Z | NONE | off-topic | with requests.session() as session:
while True:
try:
task = get_task()
if task is None:
time.sleep(1)
continue
response = session.get(url, headers=headers, proxies=task['ip'],timeout=6)
parse_detail(response .text)
except Exception as e:
report_data(task['url'], [], task['tid'],False,str(e))
logger.error(e)
time.sleep(1)
大概就是这样的结构，只有request操作，是什么地方没写好会造成这样的错误呢？能给点建议吗？
小白第一次提问，可能说的不够清晰，抱歉抱歉
| {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6766/reactions"
} | https://api.github.com/repos/psf/requests/issues/6766/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6765 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6765/labels{/name} | https://api.github.com/repos/psf/requests/issues/6765/comments | https://api.github.com/repos/psf/requests/issues/6765/events | https://github.com/psf/requests/pull/6765 | 2,400,607,025 | PR_kwDOABTKOs509atJ | 6,765 | Ensure that Basic Auth would work with non latin symbols | {
"avatar_url": "https://avatars.githubusercontent.com/u/48328325?v=4",
"events_url": "https://api.github.com/users/Smarandii/events{/privacy}",
"followers_url": "https://api.github.com/users/Smarandii/followers",
"following_url": "https://api.github.com/users/Smarandii/following{/other_user}",
"gists_url": "https://api.github.com/users/Smarandii/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Smarandii",
"id": 48328325,
"login": "Smarandii",
"node_id": "MDQ6VXNlcjQ4MzI4MzI1",
"organizations_url": "https://api.github.com/users/Smarandii/orgs",
"received_events_url": "https://api.github.com/users/Smarandii/received_events",
"repos_url": "https://api.github.com/users/Smarandii/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Smarandii/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Smarandii/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Smarandii",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2024-07-10T12:17:36Z | 2024-07-10T12:31:31Z | 2024-07-10T12:31:31Z | NONE | null | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/48328325?v=4",
"events_url": "https://api.github.com/users/Smarandii/events{/privacy}",
"followers_url": "https://api.github.com/users/Smarandii/followers",
"following_url": "https://api.github.com/users/Smarandii/following{/other_user}",
"gists_url": "https://api.github.com/users/Smarandii/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Smarandii",
"id": 48328325,
"login": "Smarandii",
"node_id": "MDQ6VXNlcjQ4MzI4MzI1",
"organizations_url": "https://api.github.com/users/Smarandii/orgs",
"received_events_url": "https://api.github.com/users/Smarandii/received_events",
"repos_url": "https://api.github.com/users/Smarandii/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Smarandii/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Smarandii/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Smarandii",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6765/reactions"
} | https://api.github.com/repos/psf/requests/issues/6765/timeline | null | null | true | {
"diff_url": "https://github.com/psf/requests/pull/6765.diff",
"html_url": "https://github.com/psf/requests/pull/6765",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6765.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6765"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6764 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6764/labels{/name} | https://api.github.com/repos/psf/requests/issues/6764/comments | https://api.github.com/repos/psf/requests/issues/6764/events | https://github.com/psf/requests/issues/6764 | 2,396,860,900 | I_kwDOABTKOs6O3THk | 6,764 | permission denied regression reading extracted certs with multiple users | {
"avatar_url": "https://avatars.githubusercontent.com/u/23436978?v=4",
"events_url": "https://api.github.com/users/jmelahman/events{/privacy}",
"followers_url": "https://api.github.com/users/jmelahman/followers",
"following_url": "https://api.github.com/users/jmelahman/following{/other_user}",
"gists_url": "https://api.github.com/users/jmelahman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jmelahman",
"id": 23436978,
"login": "jmelahman",
"node_id": "MDQ6VXNlcjIzNDM2OTc4",
"organizations_url": "https://api.github.com/users/jmelahman/orgs",
"received_events_url": "https://api.github.com/users/jmelahman/received_events",
"repos_url": "https://api.github.com/users/jmelahman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jmelahman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jmelahman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jmelahman",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 1 | 2024-07-09T00:54:35Z | 2024-07-09T01:43:14Z | null | NONE | null | If it is necessary to [extract the certs from a zip file](https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/src/requests/utils.py#L296-L302), they'll be written to somewhere like `/tmp/cacert.pem`. This is problematic for subsequent users who may not have have permission to access this `/tmp/cacert.pem`
Seems related to https://github.com/psf/requests/pull/6667
Note, this issue was not present with version `2.31.0`
## Expected Result
two users should be able to extract zipped certs on the same filesystem without issue
## Actual Result
```
Traceback (most recent call last):
File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/jamison/.../__main__.py", line 83, in <module>
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
File "<frozen importlib._bootstrap>", line 627, in _load_backward_compatible
File "<frozen zipimport>", line 259, in load_module
File "/home/jamison/..., line 22, in <module>
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
File "<frozen importlib._bootstrap>", line 627, in _load_backward_compatible
File "<frozen zipimport>", line 259, in load_module
File "/home/jamison/..., line 13, in <module>
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
File "<frozen importlib._bootstrap>", line 627, in _load_backward_compatible
File "<frozen zipimport>", line 259, in load_module
File "/home/jamison/.../pypi__39__requests_2_32_2/requests/__init__.py", line 164, in <module>
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
File "<frozen importlib._bootstrap>", line 627, in _load_backward_compatible
File "<frozen zipimport>", line 259, in load_module
File "/home/jamison/.../pypi__39__requests_2_32_2/requests/api.py", line 11, in <module>
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
File "<frozen importlib._bootstrap>", line 627, in _load_backward_compatible
File "<frozen zipimport>", line 259, in load_module
File "/home/jamison/.../pypi__39__requests_2_32_2/requests/sessions.py", line 15, in <module>
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
File "<frozen importlib._bootstrap>", line 627, in _load_backward_compatible
File "<frozen zipimport>", line 259, in load_module
File "/home/jamison/.../pypi__39__requests_2_32_2/requests/adapters.py", line 77, in <module>
PermissionError: [Errno 13] Permission denied
```
## Reproduction Steps
```shell
touch /tmp/test_utils.py
chown root:root /tmp/test_utils.py
python -m pytest test/test_utils.py
```
The full end-to-end steps are a bit involved. A,
`__main__,py`
```
import requests
```
as a standalone zip executable is enough to repro (though I haven't been able to repro with executables that unarchive themselves such as `zipapp` -- in this case, we're using something similar to google's [subpar](https://github.com/google/subpar)).
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.12.3"
},
"platform": {
"release": "6.6.32-1-lts",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30300000"
},
"urllib3": {
"version": "2.2.2"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
| null | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6764/reactions"
} | https://api.github.com/repos/psf/requests/issues/6764/timeline | null | null | null | null | false | [
"I think this is fundamentally the same issue as https://github.com/psf/requests/issues/5994 which was marked as won't fix.\r\n\r\nHappy to contribute a fix if there is a satisfactory solution. In my case, the file permissions less of the issue and more so this file is not guaranteed to be owned by the current user. Possible solutions I see include:\r\n- embed the user metadata into the filename. `/tmp/cacert.pem` becomes `/tmp/jamison_cacert.pem`. Not foolproof, but simple and resolves my issue.\r\n- replace this `/tmp/cacert.pem` with a random temporary file (similar to what `certifi` would do). I'm not sure how long this file would need to live on disk, but maybe now [with preloading the certs](https://github.com/psf/requests/pull/6667), this file can be removed after this initial load."
] |
https://api.github.com/repos/psf/requests/issues/6763 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6763/labels{/name} | https://api.github.com/repos/psf/requests/issues/6763/comments | https://api.github.com/repos/psf/requests/issues/6763/events | https://github.com/psf/requests/issues/6763 | 2,395,821,672 | I_kwDOABTKOs6OzVZo | 6,763 | Body with Special Characters Gets Cut | {
"avatar_url": "https://avatars.githubusercontent.com/u/63793479?v=4",
"events_url": "https://api.github.com/users/Boris-Rozenfeld/events{/privacy}",
"followers_url": "https://api.github.com/users/Boris-Rozenfeld/followers",
"following_url": "https://api.github.com/users/Boris-Rozenfeld/following{/other_user}",
"gists_url": "https://api.github.com/users/Boris-Rozenfeld/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Boris-Rozenfeld",
"id": 63793479,
"login": "Boris-Rozenfeld",
"node_id": "MDQ6VXNlcjYzNzkzNDc5",
"organizations_url": "https://api.github.com/users/Boris-Rozenfeld/orgs",
"received_events_url": "https://api.github.com/users/Boris-Rozenfeld/received_events",
"repos_url": "https://api.github.com/users/Boris-Rozenfeld/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Boris-Rozenfeld/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Boris-Rozenfeld/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Boris-Rozenfeld",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 9 | 2024-07-08T14:33:37Z | 2024-07-08T18:35:44Z | 2024-07-08T18:29:33Z | NONE | null | When sending a request with special characters using the requests module, the request gets cut and is not sent fully.
This seems to be caused by the requests module calculating the length of the original string, but once the request arrives at the urllib3 module, the urllib3 module encodes the request and calculates the content length again. Unfortunately, because the request content length was already calculated and included in the headers dictionary, it gets overwritten.
## Expected Result
The request should be sent fully, including all special characters.
## Actual Result
The request gets cut off, and not all data is sent.
## Reproduction Steps
```python
import requests
### Note that the x are special characters ###
response = requests.post(url='http://127.0.0.1', data="""{"test": "××××"}""")
print(response.text)
```
## Example of the actual request:
```
POST / HTTP/1.1
Host: 127.0.0.1
User-Agent: python-requests/2.31.0
Accept-Encoding: gzip, deflate, br
Accept: */*
Connection: keep-alive
Content-Length: 16
{"test": "×××
```
As it looks the overwrite happens here:
[urllib3 connection.py#L396](https://github.com/urllib3/urllib3/blob/0ce5a89a81943e0153d3655415192e2d82f080cf/src/urllib3/connection.py#L396)
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.11.9"
},
"platform": {
"release": "23.5.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "300000d0"
},
"urllib3": {
"version": "2.0.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6763/reactions"
} | https://api.github.com/repos/psf/requests/issues/6763/timeline | null | completed | null | null | false | [
"I'm having this issue too",
"Can you please explain which specific special characters result in cut of request data?",
"Sure, the specific one I came across was \"×\" - after encoding it's ```b'\\xc3\\x97'``` (as shown in the \"Reproduction Steps\"), I also tested other characters like ```b'\\xc3\\x96'``` and ```b'\\xc3\\x95'```, and they had the same problem.\r\nSo, I believe this isn’t limited to just one specific character, it seems to be a more widespread issue.",
"> Sure, the specific one I came across was \"×\" - after encoding it's ```b'\\xc3\\x97'``` (as shown in the \"Reproduction Steps\"), I also tested other characters like ```b'\\xc3\\x96'``` and ```b'\\xc3\\x95'```, and they had the same problem.\n> So, I believe this isn’t limited to just one specific character, it seems to be a more widespread issue.\n\nI think this might be the issue with encoding the characters is not properly working, have you tried encoding those by yourself first then passing it to data parameter?",
"> Sure, the specific one I came across was \"×\" - after encoding it's ```b'\\xc3\\x97'``` (as shown in the \"Reproduction Steps\"), I also tested other characters like ```b'\\xc3\\x96'``` and ```b'\\xc3\\x95'```, and they had the same problem.\n> So, I believe this isn’t limited to just one specific character, it seems to be a more widespread issue.\n\nUse UTF-16 encoding or send as binary data might resolve the issue ",
"Yes, encoding the data before sending the request does work as a workaround\r\n(e.g., ```requests.post(url='http://127.0.0.1', data='{\"test\": \"××××\"}'.encode())```).\r\n\r\nHowever, this doesn’t address the root cause of the problem. \r\n\r\nThe issue lies in the requests module calculating an incorrect value for the “Content-Length” header, which then overwrites the correct value from the urllib package. As a result, the urllib package uses this incorrect value, causing the request to be sent before the full body can be transmitted.\r\n\r\nI did found a solution for my specific case, but I believe this represents a critical and widespread issue that needs to be addressed.\r\n",
"I have version 2.32.3 and there seems no issue:\n\n\nTry upgrading requests module, hope will resolve this bug.",
"This is a duplicate of #6586. Please either upgrade to Requests>=2.32.0 or downgrade to `urllib3<2`. This is a behavioral change in the major version bump of urllib3.",
"You are right, the new version works perfectly. Thank you very much!"
] |
https://api.github.com/repos/psf/requests/issues/6762 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6762/labels{/name} | https://api.github.com/repos/psf/requests/issues/6762/comments | https://api.github.com/repos/psf/requests/issues/6762/events | https://github.com/psf/requests/issues/6762 | 2,394,209,107 | I_kwDOABTKOs6OtLtT | 6,762 | "Transfer-Encoding" header is ignored | {
"avatar_url": "https://avatars.githubusercontent.com/u/76537991?v=4",
"events_url": "https://api.github.com/users/Green360/events{/privacy}",
"followers_url": "https://api.github.com/users/Green360/followers",
"following_url": "https://api.github.com/users/Green360/following{/other_user}",
"gists_url": "https://api.github.com/users/Green360/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Green360",
"id": 76537991,
"login": "Green360",
"node_id": "MDQ6VXNlcjc2NTM3OTkx",
"organizations_url": "https://api.github.com/users/Green360/orgs",
"received_events_url": "https://api.github.com/users/Green360/received_events",
"repos_url": "https://api.github.com/users/Green360/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Green360/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Green360/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Green360",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-07-07T20:37:39Z | 2024-07-18T11:19:10Z | 2024-07-18T11:19:10Z | NONE | null | The "Transfer-Encoding" header is ignored by the requests library.
## Expected Result
I expect a request in line with the following core data:
> POST /test.php HTTP/1.1
> Host: [replaced]
> Transfer-Encoding: chunked
> Content-Type: application/x-www-form-urlencoded
>
> 7
> param=2
## Actual Result
I obtain a request without the "Transfer-Encoding" header despite it being explicitly set:
> POST /test.php HTTP/1.1
> Host: [replaced]
> User-Agent: python-requests/2.28.1
> Accept-Encoding: gzip, deflate, br
> Accept: /
> Connection: close
> Content-Length: 12
>
> 7
> param=2
## Reproduction Steps
```python
import requests
url = 'http://[replaced]/test.php'
def data_chunks():
yield b'7\r\n'
yield b'param=2\r\n'
response = requests.post(url,data=data_chunks(), headers={"Transfer-Encoding":"chunked", "Content-Type":"application/x-www-form-urlencoded"}, proxies={"http":"http://127.0.0.1:8080"})
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.1.0"
},
"charset_normalizer": {
"version": "3.0.1"
},
"cryptography": {
"version": "38.0.4"
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.11.2"
},
"platform": {
"release": "6.5.0-13parrot1-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30000080",
"version": "23.0.0"
},
"requests": {
"version": "2.28.1"
},
"system_ssl": {
"version": "300000d0"
},
"urllib3": {
"version": "1.26.12"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6762/reactions"
} | https://api.github.com/repos/psf/requests/issues/6762/timeline | null | completed | null | null | false | [
"> The \"Transfer-Encoding\" header is ignored by the requests library.\n> \n> ## Expected Result\n> \n> I expect a request in line with the following core data:\n> \n> > POST /test.php HTTP/1.1\n> > Host: [replaced]\n> > Transfer-Encoding: chunked\n> > Content-Type: application/x-www-form-urlencoded\n> >\n> > 7\n> > param=2\n> \n> ## Actual Result\n> \n> I obtain a request without the \"Transfer-Encoding\" header despite it being explicitly set:\n> > POST /test.php HTTP/1.1\n> > Host: [replaced]\n> > User-Agent: python-requests/2.28.1\n> > Accept-Encoding: gzip, deflate, br\n> > Accept: /\n> > Connection: close\n> > Content-Length: 12\n> >\n> > 7\n> > param=2\n> \n> ## Reproduction Steps\n> \n> ```python\n> import requests\n> \n> url = 'http://[replaced]/test.php'\n> \n> def data_chunks():\n> yield b'7\\r\\n'\n> yield b'param=2\\r\\n'\n> \n> response = requests.post(url,data=data_chunks(), headers={\"Transfer-Encoding\":\"chunked\", \"Content-Type\":\"application/x-www-form-urlencoded\"}, proxies={\"http\":\"http://127.0.0.1:8080\"})\n> \n> ```\n> \n> ## System Information\n> \n> $ python -m requests.help\n> \n> ```json\n> {\n> \"chardet\": {\n> \"version\": \"5.1.0\"\n> },\n> \"charset_normalizer\": {\n> \"version\": \"3.0.1\"\n> },\n> \"cryptography\": {\n> \"version\": \"38.0.4\"\n> },\n> \"idna\": {\n> \"version\": \"3.3\"\n> },\n> \"implementation\": {\n> \"name\": \"CPython\",\n> \"version\": \"3.11.2\"\n> },\n> \"platform\": {\n> \"release\": \"6.5.0-13parrot1-amd64\",\n> \"system\": \"Linux\"\n> },\n> \"pyOpenSSL\": {\n> \"openssl_version\": \"30000080\",\n> \"version\": \"23.0.0\"\n> },\n> \"requests\": {\n> \"version\": \"2.28.1\"\n> },\n> \"system_ssl\": {\n> \"version\": \"300000d0\"\n> },\n> \"urllib3\": {\n> \"version\": \"1.26.12\"\n> },\n> \"using_charset_normalizer\": false,\n> \"using_pyopenssl\": true\n> }\n> ```\n> \n> <!-- This command is only available on Requests v2.16.4 and greater. Otherwise,\n> please provide some basic information about your system (Python version,\n> operating system, &c). -->\n> \n\nThe version you are using is outdated, please upgrade to the latest version:\n\n\n\nThis will solve the issue."
] |
https://api.github.com/repos/psf/requests/issues/6761 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6761/labels{/name} | https://api.github.com/repos/psf/requests/issues/6761/comments | https://api.github.com/repos/psf/requests/issues/6761/events | https://github.com/psf/requests/issues/6761 | 2,394,039,609 | I_kwDOABTKOs6OsiU5 | 6,761 | Request can't get berkshirehathaway letters.html correctly | {
"avatar_url": "https://avatars.githubusercontent.com/u/2570701?v=4",
"events_url": "https://api.github.com/users/karlzheng/events{/privacy}",
"followers_url": "https://api.github.com/users/karlzheng/followers",
"following_url": "https://api.github.com/users/karlzheng/following{/other_user}",
"gists_url": "https://api.github.com/users/karlzheng/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/karlzheng",
"id": 2570701,
"login": "karlzheng",
"node_id": "MDQ6VXNlcjI1NzA3MDE=",
"organizations_url": "https://api.github.com/users/karlzheng/orgs",
"received_events_url": "https://api.github.com/users/karlzheng/received_events",
"repos_url": "https://api.github.com/users/karlzheng/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/karlzheng/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/karlzheng/subscriptions",
"type": "User",
"url": "https://api.github.com/users/karlzheng",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-07-07T12:43:29Z | 2024-07-07T12:43:40Z | 2024-07-07T12:43:39Z | NONE | off-topic | Hi team,
I use request to get the content of 'https://www.berkshirehathaway.com/letters/letters.html', but it always can't be decoded as text correctly. Could you help to point out the error of following code? Thanks!
`
BRK_letters = "https://www.berkshirehathaway.com/letters/"
headers = {
'User-Agent': 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.64 Safari/537.11'
}
response = requests.get(f"{self.BRK_letters}letters.html", headers=self.headers)
response.raise_for_status() # Raise error for bad status codes
` | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6761/reactions"
} | https://api.github.com/repos/psf/requests/issues/6761/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6760 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6760/labels{/name} | https://api.github.com/repos/psf/requests/issues/6760/comments | https://api.github.com/repos/psf/requests/issues/6760/events | https://github.com/psf/requests/issues/6760 | 2,393,741,486 | I_kwDOABTKOs6OrZiu | 6,760 | requests library seems to ignore "Transfer-Encoding" header | {
"avatar_url": "https://avatars.githubusercontent.com/u/76537991?v=4",
"events_url": "https://api.github.com/users/Green360/events{/privacy}",
"followers_url": "https://api.github.com/users/Green360/followers",
"following_url": "https://api.github.com/users/Green360/following{/other_user}",
"gists_url": "https://api.github.com/users/Green360/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Green360",
"id": 76537991,
"login": "Green360",
"node_id": "MDQ6VXNlcjc2NTM3OTkx",
"organizations_url": "https://api.github.com/users/Green360/orgs",
"received_events_url": "https://api.github.com/users/Green360/received_events",
"repos_url": "https://api.github.com/users/Green360/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Green360/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Green360/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Green360",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-07-06T21:41:36Z | 2024-07-07T13:16:10Z | 2024-07-07T13:16:09Z | NONE | off-topic | I wanted to send a request with "Transfer-Encoding:chunked" but somehow the header is never set.
Below is my code for testing and the corresponding captured request.
```
import requests
url = 'http://[replaced]/test.php'
def data_chunks():
yield b'7\r\n'
yield b'param=2\r\n'
response = requests.post(url,data=data_chunks(), headers={"Transfer-Encoding":"chunked", "Content-Type":"application/x-www-form-urlencoded"}, proxies={"http":"http://127.0.0.1:8080"})
```
> POST /test.php HTTP/1.1
> Host: [replaced]
> User-Agent: python-requests/2.28.1
> Accept-Encoding: gzip, deflate, br
> Accept: */*
> Connection: close
> Content-Length: 12
>
> 7
> param=2
If I do not set the "Transfer-Encoding" header it is not used and even if I explicitly set the "Transfer-Encoding" header it is not used. The requests library always seems to put a "Content-Length" instead.
My goal is to form this request:
> POST /test.php HTTP/1.1
> Host: [replaced]
> Transfer-Encoding: chunked
> Content-Type: application/x-www-form-urlencoded
>
> 7
> param=2 | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6760/reactions"
} | https://api.github.com/repos/psf/requests/issues/6760/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6759 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6759/labels{/name} | https://api.github.com/repos/psf/requests/issues/6759/comments | https://api.github.com/repos/psf/requests/issues/6759/events | https://github.com/psf/requests/pull/6759 | 2,390,872,590 | PR_kwDOABTKOs50clA_ | 6,759 | Adding kill switch to save humanity in case of AI invasion | {
"avatar_url": "https://avatars.githubusercontent.com/u/49095078?v=4",
"events_url": "https://api.github.com/users/denitdao/events{/privacy}",
"followers_url": "https://api.github.com/users/denitdao/followers",
"following_url": "https://api.github.com/users/denitdao/following{/other_user}",
"gists_url": "https://api.github.com/users/denitdao/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/denitdao",
"id": 49095078,
"login": "denitdao",
"node_id": "MDQ6VXNlcjQ5MDk1MDc4",
"organizations_url": "https://api.github.com/users/denitdao/orgs",
"received_events_url": "https://api.github.com/users/denitdao/received_events",
"repos_url": "https://api.github.com/users/denitdao/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/denitdao/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/denitdao/subscriptions",
"type": "User",
"url": "https://api.github.com/users/denitdao",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2024-07-04T13:25:25Z | 2024-07-04T17:12:03Z | 2024-07-04T17:12:03Z | NONE | null | _(Note: This is purely for humor. Do not merge!)_
### Description:
We all know that most AI systems are developed using Python.
With the rapid evolution of AI, the possibility of it escaping our control is increasing.
This PR serves as a backup plan for humanity to save itself.
### Usage:
Simply merge this in case of danger for humanity.
### Benefit:
Ensures no AI can use the requests library during an invasion, protecting humanity from AI exploits.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6759/reactions"
} | https://api.github.com/repos/psf/requests/issues/6759/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6759.diff",
"html_url": "https://github.com/psf/requests/pull/6759",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6759.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6759"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6758 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6758/labels{/name} | https://api.github.com/repos/psf/requests/issues/6758/comments | https://api.github.com/repos/psf/requests/issues/6758/events | https://github.com/psf/requests/issues/6758 | 2,385,010,624 | I_kwDOABTKOs6OKF_A | 6,758 | Error when headers return 'Location' as an app://xxxx although I have set disable redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/54569460?v=4",
"events_url": "https://api.github.com/users/KenKout/events{/privacy}",
"followers_url": "https://api.github.com/users/KenKout/followers",
"following_url": "https://api.github.com/users/KenKout/following{/other_user}",
"gists_url": "https://api.github.com/users/KenKout/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/KenKout",
"id": 54569460,
"login": "KenKout",
"node_id": "MDQ6VXNlcjU0NTY5NDYw",
"organizations_url": "https://api.github.com/users/KenKout/orgs",
"received_events_url": "https://api.github.com/users/KenKout/received_events",
"repos_url": "https://api.github.com/users/KenKout/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/KenKout/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KenKout/subscriptions",
"type": "User",
"url": "https://api.github.com/users/KenKout",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 136589914,
"name": "Needs Info",
"node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info"
}
] | closed | false | null | [] | null | 3 | 2024-07-02T01:30:02Z | 2024-07-02T13:19:36Z | 2024-07-02T13:19:35Z | NONE | null | <!-- Summary. -->
## Expected Result
response['Location'] = app://xxxx
<!-- What you expected. -->
## Actual Result
hostIP = socket.gethostbyname(hostonly)
UnicodeError: encoding with 'idna' codec failed (UnicodeError: label too long)
<!-- What happened instead. -->
## Reproduction Steps
```python
import requests
resp = requests.get('https://example', allow_redirects=False)
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6758/reactions"
} | https://api.github.com/repos/psf/requests/issues/6758/timeline | null | completed | null | null | false | [
"Hi @KenKout, can you please supply the full set of information requested in the ticket template and the complete stacktrace?\r\n\r\nWhat's provided currently is not reproducible.\r\n\r\nThis works as expected:\r\n```python\r\nimport requests\r\nr = requests.get('https://httpbin.org/redirect-to?url=app://test', allow_redirects=False)\r\n```\r\n\r\nFrom the error, it looks like the location is being parsed at some point, it's not clear where that's happening.",
"```python\r\nimport requests\r\nfrom requests.structures import CaseInsensitiveDict\r\n\r\nurl = \"https://sandbox.moodledemo.net/login/index.php\"\r\ns = requests.Session()\r\nheaders = CaseInsensitiveDict()\r\nheaders[\"Content-Type\"] = \"application/x-www-form-urlencoded\"\r\nheaders[\"Origin\"] = \"https://sandbox.moodledemo.net\"\r\nheaders[\"Referer\"] = \"https://sandbox.moodledemo.net/login/index.php\"\r\nheaders[\"User-Agent\"] = \"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0\"\r\n\r\n\r\nresp = s.get(url, headers=headers)\r\nlogintoken = resp.text.split('logintoken\" value=\"')[1].split('\"')[0]\r\ndata = f\"anchor=&logintoken={logintoken}&username=admin&password=sandbox\"\r\nresp = s.post(url, headers=headers, data=data)\r\nprint(resp.text)\r\n\r\nurl = 'https://sandbox.moodledemo.net/admin/tool/mobile/launch.php?service=moodle_mobile_app&passport=1&urlscheme=moodlemobile'\r\nresp = s.get(url, headers=headers)\r\nprint(resp.text)\r\n```\r\n\r\nHi, this is the script, sorry for late response\r\nIt works well when I use library httpx\r\n\r\n```python\r\nimport requests\r\nfrom requests.structures import CaseInsensitiveDict\r\n\r\nurl = \"https://sandbox.moodledemo.net/login/index.php\"\r\ns = requests.Session()\r\nheaders = CaseInsensitiveDict()\r\nheaders[\"Content-Type\"] = \"application/x-www-form-urlencoded\"\r\nheaders[\"Origin\"] = \"https://sandbox.moodledemo.net\"\r\nheaders[\"Referer\"] = \"https://sandbox.moodledemo.net/login/index.php\"\r\nheaders[\"User-Agent\"] = \"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0\"\r\n\r\n\r\nresp = s.get(url, headers=headers)\r\nlogintoken = resp.text.split('logintoken\" value=\"')[1].split('\"')[0]\r\ndata = f\"anchor=&logintoken={logintoken}&username=admin&password=sandbox\"\r\nresp = s.post(url, headers=headers, data=data)\r\nprint(resp.text)\r\n\r\nimport httpx\r\nurl = 'https://sandbox.moodledemo.net/admin/tool/mobile/launch.php?service=moodle_mobile_app&passport=1&urlscheme=moodlemobile'\r\nresp = httpx.get(url, headers=headers, cookies=s.cookies)\r\nprint(resp.headers)\r\n```\r\n\r\n\r\nIn case you can't try to recreate the error, it's because moodle sandbox resets every hour\r\nSo when you want to try it\r\n[Moodle Setting](https://sandbox.moodledemo.net/admin/settings.php?section=mobileauthentication)\r\n(username: _admin_; password: _sandbox_)\r\nCome to this page and change _Type of login_ into this\r\n<img width=\"1008\" alt=\"image\" src=\"https://github.com/psf/requests/assets/54569460/2aee052b-acd6-4de1-9a87-4ede86b3d6cc\">\r\n",
"@KenKout you're not setting allow_redirects in your example and you still haven't provided any of the information in the issue template that's required."
] |
https://api.github.com/repos/psf/requests/issues/6757 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6757/labels{/name} | https://api.github.com/repos/psf/requests/issues/6757/comments | https://api.github.com/repos/psf/requests/issues/6757/events | https://github.com/psf/requests/pull/6757 | 2,384,994,279 | PR_kwDOABTKOs50Iedk | 6,757 | Test on urllib3 1.26.x | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2024-07-02T01:11:04Z | 2024-07-30T01:44:21Z | 2024-07-30T01:44:14Z | MEMBER | null | First step to address #6734. We'll enable testing on urllib3 1.26.x which was lost when we moved the pin to support 2.x. These will fail for now until the underlying issue is addressed, but this is to ensure we're catching any future breakages. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6757/reactions"
} | https://api.github.com/repos/psf/requests/issues/6757/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6757.diff",
"html_url": "https://github.com/psf/requests/pull/6757",
"merged_at": "2024-07-30T01:44:14Z",
"patch_url": "https://github.com/psf/requests/pull/6757.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6757"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6756 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6756/labels{/name} | https://api.github.com/repos/psf/requests/issues/6756/comments | https://api.github.com/repos/psf/requests/issues/6756/events | https://github.com/psf/requests/issues/6756 | 2,384,499,530 | I_kwDOABTKOs6OIJNK | 6,756 | I am having error on requests.post | {
"avatar_url": "https://avatars.githubusercontent.com/u/78236198?v=4",
"events_url": "https://api.github.com/users/cyberhunter69/events{/privacy}",
"followers_url": "https://api.github.com/users/cyberhunter69/followers",
"following_url": "https://api.github.com/users/cyberhunter69/following{/other_user}",
"gists_url": "https://api.github.com/users/cyberhunter69/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cyberhunter69",
"id": 78236198,
"login": "cyberhunter69",
"node_id": "MDQ6VXNlcjc4MjM2MTk4",
"organizations_url": "https://api.github.com/users/cyberhunter69/orgs",
"received_events_url": "https://api.github.com/users/cyberhunter69/received_events",
"repos_url": "https://api.github.com/users/cyberhunter69/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cyberhunter69/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cyberhunter69/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cyberhunter69",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-07-01T18:40:54Z | 2024-07-01T19:47:13Z | 2024-07-01T19:47:12Z | NONE | null | I am having Error 500: {"message":"Unexpected control character found (DomainException)","code":0} when trying to use requests.post to an external endpoint.
The body I am sending is this :
{"nomDocument": "Pi\u00e8ce d'identit\u00e9 contact", "contenu": "JVBERi0xLjYNJeLjz9MNCjM3IDAgb2JqIDw8L0xpbmVhcml6ZWQgMS9MIDIwNTk3L08gNDAvRSAxNDExNS9OIDEvVCAxOTc5NS9IIFsgMTAwNSAyMTVdPj4NZW5kb2JqDSAgICAgICAgICAgICAgICAgDQp4cmVmDQozNyAzNA0KMDAwMDAwMDAxNiAwMDAwMCBuDQowMDAwMDAxMzg2IDAwMDAwIG4NCjAwMDAwMDE1MjIgMDAwMDAgbg0KMDAwMDAwMTc4NyAwMDAwMCBuDQowMDAwMDAyMjUwIDAwMDAwIG4NCjAwMDAwMDIyNzQgMDAwMDAgbg0KMDAwMDAwMjQyMyAwMDAwMCBuDQowMDAwMDAyODQ0IDAwMDAwIG4NCjAwMDAwMDI4ODggMDAwMDAgbg0KMDAwMDAwMjkzMiAwMDAwMCBuDQowMDAwMDA0MTEzIDAwMDAwIG4NCjAwMDAwMDQxNDcgMDAwMDAgbg0KMDAwMDAwNDIxMSAwMDAwMCBuDQowMDAwMDA2ODgwIDAwMDAwIG4NCjAwMDAwMDcwMjMgMDAwMDAgbg0KMDAwMDAwNzE3MiAwMDAwMCBuDQowMDAwMDA3MzEyIDAwMDAwIG4NCjAwMDAwMDc0NTUgMDAwMDAgbg0KMDAwMDAwODE3NiAwMDAwMCBuDQowMDAwMDA4NTY2IDAwMDAwIG4NCjAwMDAwMDkwNjYgMDAwMDAgbg0KMDAwMDAxMjUxOCAwMDAwMCBuDQowMDAwMDEyNjY3IDAwMDAwIG4NCjAwMDAwMTI4MDMgMDAwMDAgbg0KMDAwMDAxMjkzOSAwMDAwMCBuDQowMDAwMDEzMDcyIDAwMDAwIG4NCjAwMDAwMTMyMDggMDAwMDAgbg0KMDAwMDAxMzM0NCAwMDAwMCBuDQowMDAwMDEzNDgwIDAwMDAwIG4NCjAwMDAwMTM2MzIgMDAwMDAgbg0KMDAwMDAxMzgxOCAwMDAwMCBuDQowMDAwMDE0MDM5IDAwMDAwIG4NCjAwMDAwMDEyMjAgMDAwMDAgbg0KMDAwMDAwMTAwNSAwMDAwMCBuDQp0cmFpbGVyDQo8PC9TaXplIDcxL1ByZXYgMTk3ODQvWFJlZlN0bSAxMjIwL1Jvb3QgMzkgMCBSL0VuY3J5cHQgMzggMCBSL0luZm8gNiAwIFIvSURbPEMyMUYyMUVBNDRDMUUyRUQyNTgxNDM1RkE1QTJEQ0NFPjwxNTM0OTEwNkQ5ODVEQTQ0OTkxMDk5RjlDMENCRjAwND5dPj4NCnN0YXJ0eHJlZg0KMA0KJSVFT0YNCiAgICAgICAgICAgICAgIA0KNzAgMCBvYmo8PC9MZW5ndGggMTIzL0MgMTI4L0ZpbHRlci9GbGF0ZURlY29kZS9JIDE1MS9MIDExMi9TIDQwPj5zdHJlYW0NCjA+v2UNc4Zmn6u4IiQguoMZnwg0NH0ymtRAWZUZqNfHLCiMQS0kyMfdiuvi04hlG2GJLNJzPFccsqvk0nZ7AHI4uCBvKj3L7sGXnAk1tHgOFgzOJjqRioIZMmIdwW51On/CmLK6+gsvbo3ivOa3aWeWo5GxxRL0DzNdRQ0KZW5kc3RyZWFtDWVuZG9iag02OSAwIG9iajw8L0xlbmd0aCAyMC9GaWx0ZXIvRmxhdGVEZWNvZGUvV1sxIDEgMV0vSW5kZXhbNyAzMF0vRGVjb2RlUGFybXM8PC9Db2x1bW5zIDMvUHJlZGljdG9yIDEyPj4vU2l6ZSAzNy9UeXBlL1hSZWY+PnN0cmVhbQ0KeNpiYmJkYGJgYKQ3BggwABbZAF0NCmVuZHN0cmVhbQ1lbmRvYmoNMzggMCBvYmo8PC9MZW5ndGggMTI4L0ZpbHRlci9TdGFuZGFyZC9PKJ6imv11rrw5sF4j3R+ObJ1lZ2RcbuwZDDZAs8jdl58OFSkvUCAtMTM0MC9SIDMvVSjj41C/LnKptSQ/7nBNpOwWAAAAAAAAAAAAAAAAAAAAACkvViAyPj4NZW5kb2JqDTM5IDAgb2JqPDwvTWFya0luZm88PC9MZXR0ZXJzcGFjZUZsYWdzIDAvTWFya2VkIHRydWU+Pi9NZXRhZGF0YSA1IDAgUi9QaWVjZUluZm88PC9NYXJrZWRQREY8PC9MYXN0TW9kaWZpZWQoCM1RrvFnz1Fb5exxrGnDVyk+Pj4+L1BhZ2VzIDQgMCBSL1BhZ2VMYXlvdXQvT25lQ29sdW1uL1N0cnVjdFRyZWVSb290IDcgMCBSL1R5cGUvQ2F0YWxvZy9MYW5nKAm5TsuSKS9MYXN0TW9kaWZpZWQoCM1RrvFnz1Fb5exxrGnDVykvUGFnZUxhYmVscyAyIDAgUj4+DWVuZG9iag00MCAwIG9iajw8L0Nyb3BCb3hbMCAwIDYxMiA3OTJdL0Fubm90cyA0MSAwIFIvUGFyZW50IDQgMCBSL1N0cnVjdFBhcmVudHMgMC9Db250ZW50cyA0NiAwIFIvUm90YXRlIDAvTWVkaWFCb3hbMCAwIDYxMiA3OTJdL1Jlc291cmNlczw8L1hPYmplY3Q8PC9JbTEwIDUwIDAgUi9JbTExIDUxIDAgUi9JbTEyIDUyIDAgUi9JbTEzIDUzIDAgUi9JbTE0IDU1IDAgUi9JbTAgNTcgMCBSL0ltMSA1OCAwIFIvSW0yIDU5IDAgUi9JbTMgNjAgMCBSL0ltNCA2MSAwIFIvSW01IDYyIDAgUi9JbTYgNjMgMCBSL0ltNyA2NCAwIFIvSW04IDY1IDAgUi9JbTkgNjYgMCBSPj4vQ29sb3JTcGFjZTw8L0NTMCA0NCAwIFIvQ1MxIDQ3IDAgUi9DUzIgNDUgMCBSPj4vRm9udDw8L1RUMCA0MyAwIFI+Pi9Qcm9jU2V0Wy9QREYvVGV4dC9JbWFnZUMvSW1hZ2VJXS9FeHRHU3RhdGU8PC9HUzAgNjggMCBSPj4+Pi9UeXBlL1BhZ2U+Pg1lbmRvYmoNNDEgMCBvYmpbNDIgMCBSXQ1lbmRvYmoNNDIgMCBvYmo8PC9SZWN0WzIyMC42OCA0NjcuODggMzg5LjQ2MSA0ODMuODUyXS9TdWJ0eXBlL0xpbmsvQlM8PC9TL1MvVyAwL1R5cGUvQm9yZGVyPj4vQSA0OCAwIFIvSC9JL1N0cnVjdFBhcmVudCAxL0JvcmRlclswIDAgMF0vVHlwZS9Bbm5vdD4+DWVuZG9iag00MyAwIG9iajw8L1N1YnR5cGUvVHJ1ZVR5cGUvRm9udERlc2NyaXB0b3IgNjcgMCBSL0xhc3RDaGFyIDEyMS9XaWR0aHNbMjc4IDI3OCAwIDAgMCAwIDAgMCAzMzMgMzMzIDAgMCAyNzggMCAyNzggMjc4IDU1NiA1NTYgNTU2IDU1NiAwIDAgNTU2IDU1NiAwIDAgMjc4IDAgMCAwIDAgMCAwIDY2NyA2NjcgNzIyIDcyMiA2NjcgNjExIDAgMCAwIDAgMCAwIDAgMCAwIDY2NyAwIDAgMCA2MTEgMCAwIDk0NCAwIDY2NyAwIDAgMCAwIDAgMCAwIDU1NiA1NTYgNTAwIDU1NiA1NTYgMjc4IDU1NiA1NTYgMjIyIDAgNTAwIDIyMiA4MzMgNTU2IDU1NiA1NTYgNTU2IDMzMyA1MDAgMjc4IDU1NiA1MDAgNzIyIDUwMCA1MDBdL0Jhc2VGb250L0FyaWFsTVQvRmlyc3RDaGFyIDMyL0VuY29kaW5nL1dpbkFuc2lFbmNvZGluZy9UeXBlL0ZvbnQ+Pg1lbmRvYmoNNDQgMCBvYmpbL0luZGV4ZWQgNDcgMCBSIDI1NSA1NiAwIFJdDWVuZG9iag00NSAwIG9ialsvSW5kZXhlZCA0NyAwIFIgMjU1IDU0IDAgUl0NZW5kb2JqDTQ2IDAgb2JqPDwvTGVuZ3RoIDExMTEvRmlsdGVyL0ZsYXRlRGVjb2RlPj5zdHJlYW0NChufMnlICdQfjYcndDyzqHmjgA3tKskYMKxrN8qdFclEw4kX6BzSv31HcGeS2XIFURVV5WTYeB8J4GddvYKvnJV74/gIHB/ubGPR48bNi3br4p8Gh2nfi782qymqRPjYEA8bld2qCtmkMMY6N+zxMzcA4j4CyThx3SrLRMj/IYuodNmI3rOSm46OKh3yyuh3fha1DItTnfXgX7NCHENqExWtvoARUCBvwVi1veKODrxC0Voe6fVGOEb7Keju8PoVgNwDmyPZ2Sy985tqOMbnnOQj1hwa0l8LcRrbmxPtwI7pKDoDXh5/F0S8MVRII0yVd/YIZE+duVrxJJiqIbWwNi2k5zvzQ6WLZt03xaqe04rhOyTZw8rY1pb8yrs9aWy0FM+sqaPN2npOV5ACTNNuPstnX2DKTAaOTH8jyRUmp9WsD4djBlPQ47ouWGMHe0TRVpQyI0rXYTo+P6b+KpEcpRQQx/NjN3gJI4jBM0k8+RpehR1jJndwOeH238NX29+2mjp/iBPSmW3TA7OzCpyZjZGqDwz8u2wYQFsBd5vwKD4WK79+1drdKzynnCF0/FqybZHsMRP45m5Sfa01fLb8RnCMJCIqUnu73QfSUaJjbUNsf+ZjPIl7fnX73U7+wPX9OOPBiIae+S4QRfB+BaHvaSiK4ZBgbsrCOIS3rrnLlz13vBqn88wKXFU50NbAKpeY3W+cTs6AyUbbng7IQS+swapS0HSecpB8R/1eois/GvQTgA5VH/8f21x1Fc7LXwxFTeaP2eSFqQrv+ofWbk8JYKKvd6RW4k17q3x3c551ljbQ/qhHxA3tCjDPzfbY9CQVihynZ8kwLdeEKQmkfBZLMHqRNIB0XY85H9J9jo9ILBNrm3KC6iIIqWjxkzZDeVk0hKmI9ubMpDb2bWXGua8PfPSX0SVGxMuO/+iCLdvuhjC4IUqqnERGkXh/7oqBxNiGVVxfW9uzAem2iQ+EeKXHQxvSmziPDo/6yyRS+05Sp6ceNRuiVog6OBFCMLFt4TsT7TXiifkyF9ycKZCHpeP6PoMtK/fdQQJqBIcKGikS5a5ZfcAAyt6M1An9TQnwZkVXN8qxf5ajd5ryS2ukqMv0RgXAG1OcbzAnRFt3i14MM2MfgPs5scooVO6QCJld6OUHTFS3HrLFXrQAIfleyHW7UXzO0d58MOhy2KhZFU+Ma9WJ/7HCAIceDyhoOyQzsP0xalUESKzLnM9EsOIAKCEGa/lREkkVE4Eg29blsrEiGpwvzT+hAxHrBYp5RLPaoNrE/FxD0trkHqja9vqzL/XNNfpy/LBRN8tXtd+qhOO7vbgVFbmU1BOKaU0BUg+Iqu6e/KZuyC5/BUX8I05KICN2gYEKyhBTxL1r43Kt4WqZehGgF+ZohfAB9Fb3MFDl7I5yXyO4UYSomO2lN4uQn3/nATMA+qEVZrLAczF9rMVQdKwZohzVqn1QaTjEjKve54Q1y5VV9ryohHYNCmVuZHN0cmVhbQ1lbmRvYmoNNDcgMCBvYmpbL0lDQ0Jhc2VkIDQ5IDAgUl0NZW5kb2JqDTQ4IDAgb2JqPDwvVVJJKFQsqLFqdcW4w3p+XHIiL0SAv/ECYgcLy+Eq265/YidqKS9TL1VSST4+DWVuZG9iag00OSAwIG9iajw8L0xlbmd0aCAyNTc1L0ZpbHRlci9GbGF0ZURlY29kZS9OIDMvQWx0ZXJuYXRlL0RldmljZVJHQj4+c3RyZWFtDQqh6ClJa8WT3poZ3FZU3dl7atbnzHGZPJ7QSlBq2WbLKHo0F59U3TDeumUIecJBc0/aF9dEateAc5WaW4oUA36LYcp4VU6EkojuLKFTZnLt5kV/DoGxxt0k4fFaUazJxtC4snbf0ldVYNGCCoz/g8AhlOrMAsPEbU14qhi+me23f/DlYspMo87JFJrj+akbpN9/mCJtY2B7htv4IB4Fq9OlAZuxkOuNKQTfzrh97yw1j8VIgILBBt8QKmOD5eRXe38dH1pCTZkvSI9Ww7anUH6bOvtFyRlB/fCOiwAH/ls9wtUw9RazW30d+WOdGUuR2AqTrjTQn2hC24B4Rzq9k1rRzNfTsidtQKpu9F7j4Yreq3UpRYDk36LDW9MCRd+A7IWNxMaKHzIw2AjEeTeQjjvksKQv/Wz41PtMTXh3IPDPz1Nth/7H9zQg2O9T9fYVddlKtj/S0SoVIVlV7iGYrrHCnTOrrAiGrVgjcurrWsTiFm898Kw4pOEyNu2q7PALSR7J2NkLd6Tl2IGDegyateS4xEQgQ/k0XUzWrFELnES7N+lj5O8y6Nb1fEHpChXe1dDUPzFup2dvkhBzvLmiJGIf21wJina5lZ63alXcu9b0jTd3nRh4gFtKWD9TU5IsByJYxm4t1c4uQcOEKavRdeMkJBtu7s7t3XanR/Hb1rHTpzymUPeQzFn1vwNXF9BerueurGJb5oq08wYRVL79SQWMOJyzPqpViEimRIPRxI/CxTS1T9FiroY7Z3knlbr6ydXO2h0/Z6sEHd2o8YxgvxOgN6+Bqof+lwLbVKkxJfRoiJnG599Op9XFtP+ZFbVbctlhgeESMQP04xelo+DUXkMpOr9pLZ7hH1lEUprXAjEUZ7rxVlAve7/M8GtL/6EqPP23ogErLAOHQOPsSXyYnAeEL6yzUp6NgAKS1urM3ICh685HrRmJEruYejxdIy+wDtG3KL9TRrS8iQui9owA1fNaHdYzY0zcEqSM2QpCbVhK9SffNvXqB6xqvhlbupiMCwDf+dA+oRobswcc/WQcwP/HN9lSTKAqXWkb/lyL42MTOOac552VCoxdQGXNRi3mzUWqrnfxM2C2ZNm5edTwc1L8VyfBEVU0HSHN4VwYcWuWa+VunKnQqjsgSPYN0KhERpMBwtWUHH9d5xGm5iiycst+37Jmhwt7sdHObSp8BgQLBoftEh0IYEbCj4yeVUoFOBTak94wpBFjRAOalOmhfL+zKd1xa6isUYtDdj3iMijX4BqPZ7k/hN3fxwsUckk7NvaH7kIU4ZYp714GTGjs2eyv2da3ajwlPFRiyOfVesPv/Rvo20BTRwWLEZr7w1EI3jfTrv0QR+PNdOgoNteNMPNy1Km4im7+U0zkWJvmnETR6sxtFR8oZpoFgW5yQM5kD69pKXPI3NeH2CUAoGVFXydVFGAqO4FjGrnZWZZqAkYNtCJc+lww2j41cGn8V6rTimJNrsFGdcSybB6OLGAUYCd/5KAOVS7fAluuL/MNuOq1JC1rS+aiF+EsjqTGsrquRtmXFkiZp+k0aR2JDCyE/cczYkquGapOLOW01/zEEXq1a61rGb+mzGCuJVLv8Jh5gbHW2RIFZzjyp+V8OOMPijWY20hwPsUkE0MaBm6InSVCWO6F8yeGT053jlgurO19taBGi9yL3/fNDBWDV4FvU2e6Q2rpyf6hDigffr0Ld1Up2TXHpMZwZVFV0iI4uPFUOoF8aCD2Azr+2bQLJf9ObToXIJVljnm0sb+btALTa2/ARDCJMdPgz12PJEBeFtzypP9KSnqR9ltrlwTeVgbfqmRR4V79WCd8RH0QHkX8qdmE8JNl+7Cm+/KiISSQ12pkEn2wVE9arbf10VR8zmuPcvXjjC/NRYIUY9540dXMhEuuX9/tPvk5LseHIsO2pnc2SOSIV+FY07QOwMETGHh/fRyZh2bpPNsb4bKfwBv05dl7oajp4bMoz3VHi3urjpth3kxtgHi6JY4oSCRFOyr6kCZlfz1MUIotPIUg/aU/7H570/Q9ESTVbMe3+bsL7R9zikBqVkmY9YrtT88UpxTWKkiECrhoTQg53cOTs5iZs+2hITV4fNFtIW1fcR7XhmtvLF3hQBuEoK04VGymQPOE+ZUEpiRCfPDLzUkgZWqpLbHgx/tMQ8LhmbTSBl+xSrMzCEGoPx6cVP5I8k8tyR2FIeFLA8wk7Rz6PwarLef4+f3Xp/0M8q/RUErCrOkUtm0mqDzO1/6dImwaoJP156DH4b3ys0wb6vBbXL7UXhoKxsesdsSKsTdmsTrWdd/7S+UMPQnJZrR9XjHFqBNoBfLWfJ94uqP5UsO03Kd8aFRUvaUSXCz0pMK55rZoB/dO3WsaVBZKuo45TiYtqIi9YGoOdj0+oEar9NpwAGErLcD5JiEon60crhc+TH2f4I8rsULU/Jil9DxrEj6Cz8TQnNwkV6vuOkwtcM6Jawsp3gpWU5WfQrha4C9mA9o0UQm68wN8ghQX/VCF6X0k/rrLtwM947CUotYJtW8PIPU34FfuRouJnK6lbCwvx7gFmq1cuIq+12QkPIqmBG/8vout961K75QH3E5rn1WtwvIkPwDdBbhFv7P2am+Tcnj5hMsrhZRd/hX+ATDSEBclAWHsqZ/aPcBIw4J5h5KOO9xBTrZdTg4cLW6hRCN5UWG/iOsiLiBc4wLiLhB4sCVxwdD6TqsqQtjHO7urv1W0mBTNeS01bs0Jv8mZ3bVPBBsRDsVnHqT/fkYNqUPZXvCJl2LkPI2hKtkR8LB4fCMjh28cm4MUOMvSpM79AcZmS3kM713rRBy3KwX44DlpOu33MVKofg0Vw1nwVm3I7752igruW3M/7w4++WS2CXhINCDZeacb4G9TxEVJSopuc28yTnYSpJSwswQBxuZFBdjEMVLKgn48xz8LJG2rZ5Zrn2tyjfVGd8EFC8DGRQD8KSVuBuJ1s9U3nIuSzPYGTfz0RoHI2Q/8piWewBiFaGU9Ik5nhRDtVmbXVq1Dh/0hY/tndFzsRWuMIOndJrUUlrf6Y5HLJUCu/TLaBF7dQBLNCnaFgmrNpedHAdikPtIgzhM/hz9h6UZBmz/i+IyVUe05zFy4WFmg8KiC5M7Kpu+33QCwJ21794HEObJHQEs2p7d6Ro45Bq2XtPrLNPguQUPNx2Rwu+XKFt21ru6a4xloQDYK9H/d8pwPhbDrK0y7Ju5+MysnsuVsFf3vRbWqJss7ow25860Zy4u4hw5HLumFvj4cUYEBDT6HlHRD1lxQsMEkymMf0gVNhBNld0OwmjsG2/LRdpv6Hs+M8dCx9KbGGB9gHzV18SHSdL6Vt8RjdWDYKeKS4HVFOnRq1rpYfwIts6Idy5DojlssUKAy0Brve+3JdjAPo8N1/Su4150lxwz8nQJHNGTobxOhlki+4VhnHGsDO/Ye2vtzDQplbmRzdHJlYW0NZW5kb2JqDTUwIDAgb2JqPDwvU3VidHlwZS9JbWFnZS9MZW5ndGggMTMvQml0c1BlckNvbXBvbmVudCA4L0NvbG9yU3BhY2UgNDcgMCBSL1dpZHRoIDQvSGVpZ2h0IDEvVHlwZS9YT2JqZWN0Pj5zdHJlYW0NCrSjq6/frWLrN3EjNQENCmVuZHN0cmVhbQ1lbmRvYmoNNTEgMCBvYmo8PC9TdWJ0eXBlL0ltYWdlL0xlbmd0aCAxOS9CaXRzUGVyQ29tcG9uZW50IDgvQ29sb3JTcGFjZSA0NyAwIFIvV2lkdGggNi9IZWlnaHQgMS9UeXBlL1hPYmplY3Q+PnN0cmVhbQ0KE7z9f9Mv+51XrtKlWYX7wC58Ig0KZW5kc3RyZWFtDWVuZG9iag01MiAwIG9iajw8L1N1YnR5cGUvSW1hZ2UvTGVuZ3RoIDEwL0JpdHNQZXJDb21wb25lbnQgOC9Db2xvclNwYWNlIDQ3IDAgUi9XaWR0aCAzL0hlaWdodCAxL1R5cGUvWE9iamVjdD4+c3RyZWFtDQp2Gx2o7cOPDq+TDQplbmRzdHJlYW0NZW5kb2JqDTUzIDAgb2JqPDwvU3VidHlwZS9JbWFnZS9MZW5ndGggMTMvQml0c1BlckNvbXBvbmVudCA4L0NvbG9yU3BhY2UgNDcgMCBSL1dpZHRoIDQvSGVpZ2h0IDEvVHlwZS9YT2JqZWN0Pj5zdHJlYW0NCrUe7QGqJyOrckbj2+MNCmVuZHN0cmVhbQ1lbmRvYmoNNTQgMCBvYmo8PC9MZW5ndGggNjUyL0ZpbHRlci9GbGF0ZURlY29kZT4+c3RyZWFtDQqiYPH7K2rZAVo69mMR7XiNga6676AxVxNmyz1OT/Ilt3oOZrMNlP6ciiuxXd/BCF27Z1fuIOoL0YX+lKIUI8hg2sRsKP+Otw4cl9ayzcNm7ikulOjooEl6Od4qEbWNfzrwrrTT9g9epPGo6KuGqqCR09P7yPTKhAUQRwQn51T/GbowhxquGQHiaFFh83OB7l60Nit8frXjF2npOcB3/tK6dB1HRttvOyhvafd+vcPWXB/mJTKhpUj6+7miErnJTSQyPR6ILRhFMYIEX0zjWue0mfTtnZOVO4xbipVppZJTJOo0wm0+nWCWH6hFVnQxTD0rt6b9GebvT2zbfuDJJiksh+OJ43jFpnb1UJBIad+jfL3Xxrjb7fURB7R3i31asHURm51vmCbraWrH56ZQoLzOJ3B7IrS4Hd/wEEDy3SVh6PKr8sllaY0CGVdqeE9Ka0EDl83ewk3WmOPUuYg4RpNxy2o2fiUSYqz6GTuqy3c8XLA4VrTS32Rp/u5BwLa7ENa2rJ4cr9Js3UOgyRPT1VT19EOo+xvAIBCGUYJuXh3NqWmWezp2z4R88Ni63ET47cSCLqjLo1uvw+3i8hBxlY335LQNqMREJH+d8Fhph1ZxFUYgsomwkeJUEqTwiBQZESYZ+UNet2tjftapGUvb6VrdasXfL19fG5bYpvCh5ydj+5P4dTv30cJEcj+A7FvNGEnBPko0D/E6TGPN5tUxC1cnV6qKGi0/BZm+tI3DEc8DDV9W+0/zt3wlCZrCNuqQfAFLP76hIZOxhJAos/8CfLZhNUVt41g3JZSf/3ZzDoiey1v7uF/edGtwrwXvB+H5jJYb9vlZ2QrCz4nb7uAABszeVZFKIajTmVEaJLQuDQplbmRzdHJlYW0NZW5kb2JqDTU1IDAgb2JqPDwvU3VidHlwZS9JbWFnZS9MZW5ndGggMjU3L0JpdHNQZXJDb21wb25lbnQgOC9Db2xvclNwYWNlIDQ1IDAgUi9XaWR0aCAxNi9IZWlnaHQgMTYvVHlwZS9YT2JqZWN0Pj5zdHJlYW0NChpohTZjv/uuB4D2AhX5+ZArRMXY5OoCLFsUh8jiAkx2+vyyuCPOLD/2e7bdZDmgkbJbyYwETS/6jbFXyLZazsgyPZUIUlZWMUsxSN6VIUfVeOU65/yE6VlBhFhrtfrkST+0TT5n5q9noh7T8U5T+tp9oJ/LW32dXpv+v6e5p10KhVIiuqqZ3C1GTNQQZFBvU8nUzVwImUBxbkNuAjeDpy+C/Dk06AjH4aOmoduXBa8ofIzN4h8xF3Nkv4BCn8hcTExuGavpShP3rUsoF37ZHWif68zr2vexCjD1OdKmGvBhGfTrpObTQ//+vnRiuXZ+zTr09AWhefMQckNSWI/AD18EDQplbmRzdHJlYW0NZW5kb2JqDTU2IDAgb2JqPDwvTGVuZ3RoIDQzMS9GaWx0ZXIvRmxhdGVEZWNvZGU+PnN0cmVhbQ0KUqjq877zW70VgnNr19Tdxcqj8kRnSdIEhonF+uk4r2iMKIUhJs8uEsdb65g8K1f1/NYtB7mfq4Zr0dCK70oJB0ldLmNG0KbmDhFPXSUogRoSvYspWSnKWPwe5+F3YsZ/ppPI9zhlafeyOnoNEQuIimE3oQjNLY2H9mWYlFCxxMbw09hgKBvF1dRCKqQvkpmB/MLZxr5W8oElBfura6PQ+8C63pOe2utKD/wsNWdrYuwbStjROXGGRH0QcXHLLf8HltS+SRhUqVgSplG9KgJb2WamH4ufk+4CUAvRa6ytKXjsx5jRsT8HU0akgEXvpTKeXC6suNN/TF90i8sKq+9hdYd5SS/HbdscW5Z7pIH6eJlWpP34Po8OzxlukC2mzWsF5Dc72ZJiCE9kkCJFb3V7wl1bQOnctkslAjqHfSYFyCZUbTXzV+hCzAYjuw06k9UEcgoVf+XfTpHeQWHHXYFfk5NQuOmSoRv7EfQfkiaVvxGCvPe1BgNV+3dczRGXvHExC/J2asE82HQLfSP4avt7JGxQl+ZVmPHwNhlEk840igKuOu99APu8KFPGToYP200NCmVuZHN0cmVhbQ1lbmRvYmoNNTcgMCBvYmo8PC9TdWJ0eXBlL0ltYWdlL0xlbmd0aCAzMjk3L0ZpbHRlci9GbGF0ZURlY29kZS9CaXRzUGVyQ29tcG9uZW50IDgvQ29sb3JTcGFjZSA0NCAwIFIvV2lkdGggMTY3L0hlaWdodCAxMDAvVHlwZS9YT2JqZWN0Pj5zdHJlYW0NCjFtWBVjTQbEXFa4C645dIZuypTg+SKb6BuSfKSzH2F2D89iUO6EHRFF/SK7MxOgVbivNYjOHWGizk9RFCVRSTVLwn8sM3AcYdPsJc0IgguUqXig9HyXsTRT+hADSeK3kLRVqE5zEnDkEPlvIvizbBmX/goT6eu7Kg1Gu2iFXn33vNwi79DbUKiCnWSAVA4bzNo4QSxCoW5r7EGvDx/oyb8T0h2fYayiFNxRQEZa2BvFnuq8Pa8Xb59ylj9EFu9LaytBwqEEqaKTALjyNCQU+G6TRCsojRtVNGS9V7uAJ5nzgxYjP72dRTs+q+YULMufi0ACWvegIXvX7QNtB0+g3tOSbDzbkXdY5AdzPdv6XfKSFtSdKhZI9YK+SR+e7h4BmgzgPB13DLoDvgf1WTHf/nN7LxfVc65HnXLbppiY2xB3ES5ZuCbVDGvtcQcPSqGIjzdPcHl0jsd4MAcrd1eacznLUxvq5gpJxbmP/mRSeDvm6Vc4/cvUNXFRY9Rg3wyl6binY73hPz0Xni68sHESftbakPYGefo+yEyvOh9ChYYw3tnDOsrArtu64oirHQb22AtS3PSESYzk9l6YWngog0WWuTbGVZvPzR7mh2o9Zbc6PCEcDvw/AF3gvlhHuoyzS8LuWbnJgOrk1NgY+C5VwJqPQmnk9pfRFSc7k10QFTUEzVoCrpljST0JXybuloAwp39RMzvbqHbvy0s2x9SBqtbxvINuC/j1I4FMFb/0avCcQFqj3O5BdrxFcQbNmpOAk36YF/XbyY8skEL3cEFfx5BL6+4qcxNJwCw1BY1zjSHq2jYlG9P0rBR6HyDBzc8Pfh94jUZDNEWtlU9IpXbnias3gldJ6riDHlhLR2/QPBk5sEqNVOB4Ci2KMbCFhrbyAAgy2TuYy0ESvRv5/7j9xfzIcQn7EyaiUDDoqoRdn+YJX/1vFvJykI8ws4+BLrvdpWil87lQ6JwrVCBeoaBzgbhHi1SLnbyXHFebl0LLs/6+i/dzeBxqt773XWgDNe9lgUBcyq1sB99X6Zmnhga41OxoB6meH6tH67BEDQ7TiaQ+lVx9mZv/gEA8q79JsDsnIp9+eJH4Ig7v6SExWP0TFLqvNQxWMMjGqUC2XrC0PB3YxTMfLDKstaCJr5uJ7Z+UDaUkd7jqHTHGGnwb+sFVxpHrNeSZ++Z/ANPhZQXGBYo34ojQaDD4v3FB0Bcz/Lp2dAHDPUeui5rGpdAb6bQ2vZ6tLAUMmFawOCjqT450xHWig/mSKQWNDsj/+8ssqkJndaSPyuLFOn1qXPT+GFgY+LriUt7+Sp6pmRwIeWL1dtrhgEeVewkWnvHvFpZdzfa65hzZUpz0xRDFlQQ+TtEC4UvpZExnIlgEf8rL2gz2JQovL9dusZzepEPuvsoNXS5hIbRUJJcxZIwX7WdGKfKzrT2WfVIc4PkUGj4KiG5IXGoODy7p1WrqHj6X/49HNO1TOxDosBaHiovgqpyKEvySgjfQo7k0xO+AC/lq2FrhR4HXKVr95oeYOAN74neYJ7g0kKHEOQMs89Xa1g7jAMJ9rVg6J+QK9M4tkOwJlVJLiT6Zxedw4/4p9zP2Ft2GsTsQIhuEuqiXNT5qkt2bTUL1KdJyUMb6xHnlEUzfBeQb4Qg6F9vXSV0tjpL4lHwKIQFqud382kFQTbZV/djUVWNU/v8gy713ROAMsnW5CSJiAhzxbj0l2CEOegVhPXH4CcI/KUuV4INlaNCAETVVg1LpVKvMPblZGD25saKgUY21l49aTQplwi/iA8DdIY+qabyw7Ywy0K/Au8jcU/dGh28/JxMkxOPkixos9sAt85S8l1uDm0Mdfp6DrKEN5FmE1gXxqPsF79rySZCKKHjujBvwvm2FO8GUsaBaZ83cgRfc/I9zb1bpw989wwzhahZiFzmUYaKii4q9RubAIJUXETL9rJkDrFk+UA9VXrzqFgSqNuRHnMeCvrv9v03gO1avZne70KrP1TzRR+qmpd8qWuhzXfjWbVp3CMdEWP4peE6Loe45qY/LH78PkgLjMnX1qLyGw0RPZ3EQl4YwiIr5E87nmLQ+lxtOAjdMTZwCSTTGlwqj+DdI/JLfDBBRXcLvCr625+7haPwhdMcBfe5ttaEYXc9k4n+iAru1WVZ/RXDgFHUgzPDa+UhArK5cITpzvtHlcoyPif67X3/AlN0Q0ikSXqfimREqWFyo0IQ3ON8n8z0aeRlp55GqlpWLbkrjDBiIVWkBbRn475csOu8yAy4UENnPsxVXmETSqpQscFO2XpwVNzoQh4EkKADpe2yNMakNoftdv7Eo51oxWm3US9uSpJt65ny2HCHv/JoM9N0VSN8oAlc05p4aAuQe+gcBC5oXDi28NNGtUXX3Lvi59Phr47jdncjJIF5sR6DoKidQ3lVdBJvZBDjSJ4wYmItkS1oW3jNt9gNcMkS1KQjdJ2Vn+gYNB7ElnQSRizZUoBVfUI/gBSoI6UFZKOFjH8xQwLxWKtfbv8/szf+tuh3ceYsxAll3aQp08xOxx5dvTXqGa5joB8ZqQIOOqmPOJZ0n32UY3u4geJSDSxHDaElsuiJaavwaJZOrqYhhOWLgQTok3yVWG3GecPe7oQGNqDfe+gnwqD6e5h1jM+fS+ZKb4PoS42/amL90BZT2Gd/0yaULtsYl9Hw40RVY8SJhCk4DZWTdSmP/qsg391dGqSV3k/xWm6nkaBzeGvn9VnWIlXT5miPzrlOu9uKYYsMMz1ERb+2LnGftVWNKVi5xo0jH6wg8FdBtyalpU/Py/A1lPCAh5hVHEhRms4mG/o7K9zb3/fbxo3anTkgnhmANMlYKcAIOPSPTK5EpTw/qfUKXYs+zFjUBN/XIGf/nmsJxISy79WXxh1x7oBqUtjqD1BZWlCdJTO35+kTCdMUdph2ubaHdCBILYYgEHpt7ESgERf7Rb7iwszYBhWoov8mjBlCB/COjJBCc5gZr8Xj7gXPIV+i5czSbs2BTizBJJo/RP8vpmh6lrk//Ds+KhnTrjvNuO/q4WyHKncoc5tMeG3+bz4XtWeboWAHEpCTcQ9PXYtubjFCb4Nw4bcX/YUTZBp3sLY2XSNbfTdGQ/m0w3uJfoflpidUWYiOQjibT9i2ar0Uhh13y9XBAkQMWYFMeRGBKjclX/JqBHAzaVVwIOL+n+8GtGxf/c83ymnOhh8EsE7RCxo3CIHQpwCjJSrfuwgKQ9l3FdawOc726dnCZd+tDItVpO6Wle+BQlN4tU4wlfHNqIvH5YBpa/VPhBKO6Gm+9JeWxHKjxl+4J+fT9id7ei6HGPlEFAHMJZB/8Yzv5ucwB1IGHinC+ugMYWRCer55QPKMG1zk++BK30cAhWAWBn4rQCr336YVbEDRHB5TXA4Wt75YtMSYEb+nUsOjNh4tZWvWIE5FkeaGs6dn5Bac4m23CgQdfaf8bh4iH10IM8hC9A7qQU/HunhdVJmPs9vwPZwbfPVBmkMy4MitnyLUlXh42cCZvrFnagd1p/mDugZ+sekcIoRUJdbBoiGa63Vj2xC7n1PSbA/5yEA1FoSq40rROdKy303AhZTwkTl7M4i6/4lN7jaOfh2y1F3/feDAmktm16EcKoi9o2B+IV5GK0RJc7pl3KgL0+7RHiJy+28Br1OCZjRuZshFm6pxhz65B4vOhBQXBT5kL1TiCZ3fzsI6Ln0swYUEsosR6L1jEh2VEzY+7lSGFMD3Ly9oA7y5nS9+rKLGK81VOwD/1UMSZ6/bE/2LpJuN61eKIJTJwNTQFHobZz2+m72BeDWTJSBodD+DlCnK762NV2yuhUbKJtVdOICF/I3RwdMjCrmgX5LUv7foxxy/Bc7s/oxPOgkji5ifRCLd1XF8AmJJKg09jFmzImttYCx4roXNkg3740dxdT+i7zocpnevwZahsfjTjSK4rp3KiVD+HfCcVKQQiEdOBSOoQSvdoKBZSYYqTbnLvf3WXomNzwfJkt3TKBaLeclXqz6/sQeFemTPCMIfV1RtX/+9dsOs6/sYDuWuhJzPBVnounjQGIkDZJHn5t3e15VB6AvT6SieXFlt3su0iuatqZNOIJWTEBVqka2ydu5CS9KMzjwZCWEroIR8tQwFu7UfsYp3upGvBSmJD8cSoVNX+/xk8Y2/k+lMRQZ+It/xwa6YnaYkW7EhDcQSaOPqvOXyXQx0y/REW78v1wPeTZbvjKIDsUXD+TSnDSZIDvk7i7tj/SxThMNEx0ag05JjdattC2S9xXELmc68xgCM65WAF96IuXq9DSZcjQUHadOyG6PJWQPBa4qn8NiQLcmOTz2gnuR99xa9KqlAUAbz39FxrWYOiZTVZijxt+AW76rWv/Ix1XT/ZyDpZYsNcQl5/Ml8RQuHYzS/auqCI/3PLA9Jy0zvvtg0KZW5kc3RyZWFtDWVuZG9iag01OCAwIG9iajw8L1N1YnR5cGUvSW1hZ2UvTGVuZ3RoIDE5L0JpdHNQZXJDb21wb25lbnQgOC9Db2xvclNwYWNlIDQ3IDAgUi9XaWR0aCAyL0hlaWdodCAzL1R5cGUvWE9iamVjdD4+c3RyZWFtDQo3R633u5PILuNh2uqR/GEFIj0vDQplbmRzdHJlYW0NZW5kb2JqDTU5IDAgb2JqPDwvU3VidHlwZS9JbWFnZS9MZW5ndGggNy9CaXRzUGVyQ29tcG9uZW50IDgvQ29sb3JTcGFjZSA0NyAwIFIvV2lkdGggMS9IZWlnaHQgMi9UeXBlL1hPYmplY3Q+PnN0cmVhbQ0K14/pGKyXxA0KZW5kc3RyZWFtDWVuZG9iag02MCAwIG9iajw8L1N1YnR5cGUvSW1hZ2UvTGVuZ3RoIDcvQml0c1BlckNvbXBvbmVudCA4L0NvbG9yU3BhY2UgNDcgMCBSL1dpZHRoIDIvSGVpZ2h0IDEvVHlwZS9YT2JqZWN0Pj5zdHJlYW0NCrN3Ds5BHkkNCmVuZHN0cmVhbQ1lbmRvYmoNNjEgMCBvYmo8PC9TdWJ0eXBlL0ltYWdlL0xlbmd0aCA0L0JpdHNQZXJDb21wb25lbnQgOC9Db2xvclNwYWNlIDQ3IDAgUi9XaWR0aCAxL0hlaWdodCAxL1R5cGUvWE9iamVjdD4+c3RyZWFtDQrx8DB4DQplbmRzdHJlYW0NZW5kb2JqDTYyIDAgb2JqPDwvU3VidHlwZS9JbWFnZS9MZW5ndGggNy9CaXRzUGVyQ29tcG9uZW50IDgvQ29sb3JTcGFjZSA0NyAwIFIvV2lkdGggMi9IZWlnaHQgMS9UeXBlL1hPYmplY3Q+PnN0cmVhbQ0K9/8xai1TaA0KZW5kc3RyZWFtDWVuZG9iag02MyAwIG9iajw8L1N1YnR5cGUvSW1hZ2UvTGVuZ3RoIDcvQml0c1BlckNvbXBvbmVudCA4L0NvbG9yU3BhY2UgNDcgMCBSL1dpZHRoIDIvSGVpZ2h0IDEvVHlwZS9YT2JqZWN0Pj5zdHJlYW0NCiN83Skmd7gNCmVuZHN0cmVhbQ1lbmRvYmoNNjQgMCBvYmo8PC9TdWJ0eXBlL0ltYWdlL0xlbmd0aCA3L0JpdHNQZXJDb21wb25lbnQgOC9Db2xvclNwYWNlIDQ3IDAgUi9XaWR0aCAyL0hlaWdodCAxL1R5cGUvWE9iamVjdD4+c3RyZWFtDQpDpbHuCaveDQplbmRzdHJlYW0NZW5kb2JqDTY1IDAgb2JqPDwvU3VidHlwZS9JbWFnZS9MZW5ndGggMjIvQml0c1BlckNvbXBvbmVudCA4L0NvbG9yU3BhY2UgNDcgMCBSL1dpZHRoIDcvSGVpZ2h0IDEvVHlwZS9YT2JqZWN0Pj5zdHJlYW0NCpWdrC9mCwFGKGCEbsqwKNeqVxg8KHkNCmVuZHN0cmVhbQ1lbmRvYmoNNjYgMCBvYmo8PC9TdWJ0eXBlL0ltYWdlL0xlbmd0aCAzNi9GaWx0ZXIvRmxhdGVEZWNvZGUvQml0c1BlckNvbXBvbmVudCA4L0NvbG9yU3BhY2UgNDcgMCBSL1dpZHRoIDEyL0hlaWdodCAxL1R5cGUvWE9iamVjdD4+c3RyZWFtDQocFK2eTep6QT3VCJxIOHFA+gnI+1+BcI2BUUGW2RcDv546RggNCmVuZHN0cmVhbQ1lbmRvYmoNNjcgMCBvYmo8PC9TdGVtViA4OC9Gb250TmFtZS9BcmlhbE1UL0ZvbnRTdHJldGNoL05vcm1hbC9Gb250V2VpZ2h0IDQwMC9GbGFncyAzMi9EZXNjZW50IC0yMTEvRm9udEJCb3hbLTY2NSAtMzI1IDIwMDAgMTAwNl0vQXNjZW50IDkwNS9Gb250RmFtaWx5KF+vZcvwKS9DYXBIZWlnaHQgNzE4L1hIZWlnaHQgNTE1L1R5cGUvRm9udERlc2NyaXB0b3IvSXRhbGljQW5nbGUgMD4+DWVuZG9iag02OCAwIG9iajw8L09QTSAxL09QIGZhbHNlL29wIGZhbHNlL1R5cGUvRXh0R1N0YXRlL1NBIGZhbHNlL1NNIDAuMDI+Pg1lbmRvYmoNMSAwIG9iajw8L0ZpcnN0IDIyMy9MZW5ndGggNzU1L0ZpbHRlci9GbGF0ZURlY29kZS9OIDMwL1R5cGUvT2JqU3RtPj5zdHJlYW0NCuHeOJVWuXuaQHbFnrGKXT03oU6smBFhfS93b7sBCLbXySjhfkCnbLzeyt0DpTdfVlO+q6IbUXSkI6uVismF1y4RMUfoySMeggpzANKCh4NwYogF2w2mQmQnVexWWSL7jjWxPT2MSyGYg5sERMyA1ZgbvKZEFph2XqZ2qwm868dkLFSy6UNyHE2586X2PbmUfKjS39ucCv0jrgI/Vi9MpNUe/cUJxEQh62R6+lvd3toOMBTKkrhc1u1R2JE/Xxwmda0LkamoAS4U1c3ShIXGmenxecfNhcrbVq4LjhtOGCsQL51h5NjHIr728ZoStoeVqFBy8JKPNdA9VbJ3MTqbkJXqPy22MfoZWkQmSpUwepVaYWj2zcxJruiOFFLDZ+stFf7i9Ktuqxpqhv6efDSitRfS4hkoP9zjKfu5GJ4q/MoDSskttQxcVLsUCnN9ZeKqlpdaQmycXW8PJ6+5ZL0AIS18SEvt1t87P4dvruzHlIvEumN9t5DPfiY+ZLcWotjJX7sH/OxoxdnABdRTXCB2yEyWUDihngAVK3gEfY0WESccDlO7eiNC7GXjGE4UJEqmJ6nFYh2i8A65kD/PTaodQD6A0TT8oi3rEXN8deu6ufXSP8yvgZRFskrFfn6I+VY9n/gscEfeuDdNwmlgk9QjSl3OZ5dzwA1TB1O9L4M7ROoD/UKXpeP7JpfRUfGceud/ERuNFquZgVEZOkXRUrSNrXOd95+jkmbnXH6RL0bZw42uVj+xA+87CaW1/3c4olVLxgXO10ZqR+NijgHGz1YF68CTwZlY4RVzznExSTfcaPnuN6phXo6USQucm+q/kuG20RHQgPjuYw1Cp3Jl+DOLxEmtYF0CXI/png+Kz8sLu3MLtVoxzne2k+uWRo9cIEe8DwV/z21ffoIqmb4WsL7BMXhnN55KQ4g0CxoGY+ZriAYhqmKJNq9GnN6ETfizZ5IwcaSJV8QtgCfYgqFB9T+IiaDzFrgT03vgLt8XwDnYngVxiZ3xDQplbmRzdHJlYW0NZW5kb2JqDTIgMCBvYmo8PC9OdW1zWzAgMyAwIFJdPj4NZW5kb2JqDTMgMCBvYmo8PC9TL0Q+Pg1lbmRvYmoNNCAwIG9iajw8L0NvdW50IDEvVHlwZS9QYWdlcy9LaWRzWzQwIDAgUl0+Pg1lbmRvYmoNNSAwIG9iajw8L1N1YnR5cGUvWE1ML0xlbmd0aCA0MzM2L1R5cGUvTWV0YWRhdGE+PnN0cmVhbQ0KMQgenNdwYPGcKbgb7y7D/AU9xKz98Xy1oqY8W/ajCftQClYJSlGhO7iAuVi0e468LupW6QvJ8W76EGlmqDmOLY8NUTKV1tUFQbvyPeuPnCtYHvNYyG60LUqpmYzci00rxupS4CNdhiS2gaodEXEcQpkkVkUif/EQdxZR5G4YhP//rqKEmyLHfkZBlBqMZ3b2xxZ5gMF3SJOcm+gWxRjMQzkUklGqrBVMcB1q3d8CdMtUVYXi56yzgJrYL/meC8qYvK/zNY+FlekN0jz2VFuP+P3IJX0sJmFeq9dZ3Ec0wJUoIgnv6aTi7GqZVpoOoF4z/3yUPAwFk6upj4VJTpSaTbROiqGKTqQvl6jAOaIOKhP0TJmomH0p9lthiQe2+L0TbsDo4fXd0dUYtXTCMn9dQU8JHraRpvaO/TCM2ag4YXuvKNYe4zQlt0nW9e3g1B4VoqS4akR1pg8OdM01LSCtuv3sE6W+JInz+LWA/Z6tCDN463AHj10zuA+8y7E8CVmAA0Zjfs8Cuk3qvuL7FEPPp+GLKQ4+HULwF4rWLl/HeVWF6/rb5GC8VDvooh0BR7guYUOB1w66R8nKfkyiPiCxgaMNrWhSeusVSxmvk1RBJYJNuZU52WC8oPyIKMYd+iHNO8Lvp2Z7VgOY6gP0iWN8jsYQfOTncI1QUk7lqL25FTfDkzV5SVI6QVNXDwGoTCv+j2Nkny5d2VxMgRpj3lP6oZ9RdZJn5KF8hR0y3UYpVRvTE0vHVr4aQHDDzsg3bk4+rT8e6xT9W2gXgxu6a7o9CLF0EWCyamktnVDQEtF1wqrROVC8fi4H//hVr9HR+jbJoz+u8xYlPzEzMHDbQoSaIif+P8SNeMPQSt2DqK0YZ19/GcczP6EbHMRAOcPQuaz6EMHWijN10BHQRkoxAuVydp6Y9+gYoDiY1NHUnFugl8ooHf5W3nkacWU+Vr0JQyoKzCcLyw9LjwOEIBhpIwQ/i0odI3Nks1kccHoMePi3mFWfMKuEU8LVN9lA5Lsn4LXYtmNOinB88GWSD33QJ73XvZ6SJTnnh3w9/u7pT4a0P/vRvK9wp2Zbic5SCyit2RzmZqAKSoq3DrRPfCNNH+tjw0k/lVb8a5/dVkIXOkRESWlfCWNd1EWLU2ZinXkQyIYGiTn5Yy/icUuXTedX/IK3uuqSTky7feVz/1S/G59BuFBw22smS9IciTK639TihhWTbrKvG0cXt1aOvQCi/l3xlKj9BjxGA925jE2mE2axLNnEkxItb36iUUTEjrH+TYCb3ZBWTkNSSZrE1Z6jn5D31rcqO7BuyDTHagm4WLjuVcKkQ9PUyNaip4mPaH1fHtQH6yPeUIZdEsISoEfuWzRWo9uDibPY1owkwzfwYihTfkqEJbr3+GgYOuQ6nagQYGd0GIYs1EaoK4cT4Gs15VrTDcoITYeUS9/uXPJrHuLGj/Q++pdPm9xug6fPtmbhlqTYFiyaVrpoGZEfB5Q5NY0NMn3r4rwlsW/wFRcmCE686kZMNoA8LXAdYBTJ6KdSNTDgLuJwE9BORkTubvkCXlt5zBLn16i3tnCWIMKllIDB7q3H6us4LJ+1lSeGgwmPOl5PaI6qKX6k6gmA+qoRcApIA+HwkVSqUmtx4SVs/0z3jZoDeEVqZ6LTEjkbSxuWmYb4py6HYZsI2vqW0hQ+UsipCP5hcQvuLAEMq1A6AR0Nkjny/5zh5bd0ExHmXPpNJi/bIudHnnZWVL3TbdodqWPMedCubJQoiMp9MnwwI/YDnyvaKhDDHi3wnEhakkRuDBUcmX4HtkYmiZpSon0qNitWGZLKiK9+GVj3JfcY/UWdWF0yqOFMRDBUtG5uOginI8mBtq7lyPb3/Qgtp6sxJ9AXrXJ1ouzD23xpySXw/8DjF+V71gE6PT2NBPCrNIGj++3MKAIKVRQvtUPtLyZtoqw55kfNTlw4wPaX6UPLUtZbuOBdbYGudGVS3BzmoLPajjh52xf4UUMh3owVM03g27Qfx2iD9V7mOtkIFGIX61kf09a1B3QUt33u91eboaMHvA/hgENUlaawMha6uron6AoJ0MdsHY+bmMbStE30s8maeDif8CvJ/1LD6oEvSDvCRt2YcwOuMRAqV4HR2z9LF7vClSVdI+fmbBYYr6OIDD7Vu1u4KvC0ui0pkFsLX04lDatLlKnz+0oBIx9qdPbzf5LM0cE4Q2pwVrakphNwhXoMysSNULfmaoSv84QjC7NdipnZyJ1BaHjc3UG9GMSr1KTMWw4IEa3U5XG+z6qWFRsi9xe6mHPMmhsvK3kDvvAmhkCkccjsqSpCm6MZHsTV/ln4Nkgh7nKIUno7eS3LBhHxrxbP1E9bou6iFS22xwFj/vzkvIqvtldbNnBE0OBaocgr8AknfZ+L+M5qjEMzE04Y4Aw0OERf2WC1y1pBeW/8B8QZLhhwFgvt2Q49adEu+kHYAS5GBJ5FShXDqS9Tm9t0gygGjoSENDJkTSe0Wsba2rZfKGvOYC9rwLltoo0qdUQMW+0N9hcj3QYOZFXQkhopJ/zzZ60H4yRwbE5yVd408e+NDwOWdbBAN9dwmlPuL9eE5/lbOunlGiyL987x44n1P7bs0vtVFe5BQ11DCUBR8izyhRq2EaG0FJbe79QnQNtvbJpJQSvR4wowY1XZQPtx02w0YfSlisWsWnFI2DE+XzXFuUeueJ3MBwCm/q8pwpU8UGPKqXCgerDh1rBiDUAqCUHBlLfiVtb831TSndCrvUDKTjZ3mAV1A6RtYQAbVy+kCZwxxsfyRM5Z1iby/csFRxGsS6pDLyTCchZ/vFILhOmOwE+SbVsc6+P/2RYdss7DbN9RB4QEIoMWVWPlz6wtUuVf971erasIbp841q3rXWmgUmJxaBYxyi9gYmqGjRS2rb/6kwZKJctX10TLz1WEehPQCd7/rQHgnx0DBNYrhpE50DNvae865UtCVwgQmea9JRKN1EtuN73yMNf9EoeLVlm7FharbEGZKt67p2feh4t+VszR0VjBA75R7r0yT4KgdRqb1xZzV9uoiSt11A7SiV0jK45ZusED2JfipPsK6K0J9B6HI0TuObutumjHDnGvpiZw/brpG3t+oxbFUXOcP2YlykW+A1PO6CWoGscHyDZIYFTDALAeNoWZXYJdcCXj/2azle4g3CVJoge7rTJqHoC2XSD92aEktCopA7dE5bTCeEo9mkk+WRKwFqM98S8Qo8V5x+pv/9qXSAZ2HIktYDxer/K+RT//yTOEIuMsNrkw89/eg3rKSvQtKYpAjiOu/wcgmhxjkj2JQiDaLFoqxRj2vYC6ja/FJDMhD5w/SYOv05vE/7BYYDDjaLL7TnRPwkSfR9nMHJZlhbaF74FDP5tJF+4mlN+XxgEftIn3hwmgp0iRId907AUfeHQR28f9lDjE0zfOfNALje7HCf0S7DtEcJAmoyHI3E5+AztNo3lMLEWkSS+GLJUuLFNisxZKGi3G1iGHWeISTw89Xboe3XhoJPsaS9myOPaOKT/tmjnkqoNVuHHACcCpwp42BaNkdQf/zRZSEF6Yw3KCUr9w6xYbePYkgkKHuZubql7ovYmWbBjHh1Zkn/nprWo1IKpOgfWwE7XQPEKMo2QQDJYhBI3cUS4tl9UyShfWfiXKn+sM+AkX/HlxVMi5bHVKOomG5flJBBM8Lh0Oeu+vidT4CTntlKEBNnZTIuHfMwU7E/D+rwxOy5tpJdkbZQXjWOx2gtylFZnwYPdf/0YEj7ZI+LsS5+lVk/wlnu1F54ChAPg7Xr2oxAv3msVDfzLH3CJlZ0vtQltXwOvc+U7rRlS+bxu+xobQV/RUu2G40kDt7Z77QXLJJ1KdxXIKBpyjFX45R1v6fE0zfD0pnxp6Y6jF+pw/vjKgh8ow9K0ziFwdQ9JOaGWrzg7RA32q+EnB/SHMFePibv6Mc3QKAKRVJ6xG87GiFTX/0oZ1SzFSKMfDpvj/LnKv9lOMOy9g2eS0+IB03bRyk4W2tsxUPD/BAR5tcUUhWjmnnFglWyyCsrricoLPNMCZInswPHffq2NuoLnyBlp8T1G9a3UzV3eeyTZHhfTOCocOPr2EF3BAv/pyvpIemUSuHnWEkxEP34cZbUyjqyUu9uLQc5xpfpdwyIaX0bpI948u9OvFtjkp0pWew5fwUczulThvgKocrzsuZqHCvvbVwxALgxmNA/6VgACw5bVKwInOI0jvzrfMQL5UffqnCS1gDVXULDAlONOa4JXUjHTZZHqWcCqqU3D/vDgh2fMyvSFhLryvqe/O/wmzcxKbXsVFZH7/c20xWEEISvdeeBpFOOEtdYYvWh2JjkGKfUvpsRw1ivbyItcbpE86OZ+zV1KKf4UZpEtiCbaov0zEf0WMTrRRcX6l+xXcbK8KXBejwefHBV9b0FNLPNMji8wL59Jo/uPif5N3bMJ43RSfWRp7GgeqiN0zZajqn3DHA64KwfL2WeMIjSJNIsQn04uqIXno6JAl39mD4PLjGgue0SnKdVA15/oI2Doj84hmNBahiFBJLYRJD5Zs8OdR43cKVF8O3UNb3UMVYa6pKP/oLUDv+H2uHV0ieRSemuowX6D07kJHUe2VSFvAnqKkSmHgAWMFJZ877TKFptFLorfXnNDzyr/SZmbycHtUks+bvmTdijB1qRVCDX4lh4+vJeCuaf3X7Z72M8hD/C4E2V6nrK9Z20Nye4m00UFUhJhAd0esTMEhOqkqeLJP1bKxRnE3t1/si0WJdH6BcuS++HTeKgVsga5UTBjksZTXsKoVM1yEqc4jiLlEb1uYmx6BpEm+oyic4f6TbiODaaldO7SOK+8fQlhGS52n1PZrJz6TL5ANvhhdFeoejxm6Xich5F+3e0Rcjn1UlDDweY6vJ25wIVc4ExtxPcI4gyph79+ucgI0m1FfvYPTWmTRWN/aidZZW4x30xUvxREHf5ekcZKud8pT9mI01iHmhMbn9V7pTdJjMOjOMRj6m8xNIyrg7OGm32XnwzwvD5vRE2Tj+IekstVuIzeT0CGcyn3xTa/QmFUQwxojLZVhJYRp6zKHkWPMGXJtuPBo+CZ8gMP7EYPW8gmgFS6BYlxHVby3D/YkyZPA8d60U9adLSwAom8alUSN4Qlo4jB/FtE5JJQ5hrbyLGVR1YC96YSu2eiqw4G6je5Jsxq6wCeek3Qqji5oi6wrHK4+odDP24hp35c/LzcTEhdDI0JtXa0jxiyfjlgmmAMoQ5KmqQpnKxAXZ8FyOREIA+YzeS5rsUSAY/fOJsN3+hGhs+lXrc7MSMc9GeHIOE3DTL+dSEyP2YBsgYOkWrL66eeC0bSLg5PE7k8zO3z+GjP/+EiRgDQvuiA8vNdr3gvEdu3axbuZbdZ5lIZ8vaBIlcbKdOOs+J0wz/jOXAiW1IxRAfS6TeCrpOUwRhdTwQ3cE5pcthqzMFBNUbs8pJ4Ootm3yiAwyM5eEEsg+OoVwEmJ88ZN9G7ce3WIsf6icMy0cZFtYkVFsAr1QVeR+uIie7qRQBMLvwoSaus9GRRJWxEcWypYOHaqqBXK4awdlfmpjuJgXKzvCaLOk8l7oQkU7lTsJ9t81H3nTwPRTwlUqk5JSLRKeaJ2Q0EsLj4FSIGYzXWV1u2ZBmDEPxQJHzUoyaYIFEy1xX8+7GRc4hdH7scEryKZgMy9FDsZ767dkaGKo9th22XrYD/lyFkPJHKreDUaZz7o5truPZrS5WtkTZiN6FXLyNnjjNejtIK6yddeMjgefMi+l/cewm23LHqNwu/63Dv5X97JOt1QVH9pIg0KZW5kc3RyZWFtDWVuZG9iag02IDAgb2JqPDwvQ3JlYXRpb25EYXRlKNDuzzx6LTreeHXR9+2NQs4ZgHsT9rPpKS9BdXRob3IozaGWYyQ1To04IJK2tNwcihTfKhSD57urmcjZBM8pL0NyZWF0b3Io1bePY1wodH7IGAWmj7jSF4wUh2IE6LTurpfOkDzOiAgpL1Byb2R1Y2VyKNW3j2NcKHR+yAxcKJO2sNUem0aQexr2rfvo0OvZBcWVG3fzKS9Nb2REYXRlKNDuzzx6LTreeHXR9+2OQcgZgHsT9rPpKS9Db21wYW55KNO7i2k4e2eNJjXArb+ZK4tf3yIpL1NvdXJjZU1vZGlmaWVkKNDuzzx6LTreeHXS8O2LR8gpL1RpdGxlKLSEuUpqQW+bPGGwo77cKT4+DWVuZG9iag14cmVmDQowIDM3DQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMTQxMTUgMDAwMDAgbg0KMDAwMDAxNDk2NSAwMDAwMCBuDQowMDAwMDE0OTk4IDAwMDAwIG4NCjAwMDAwMTUwMjEgMDAwMDAgbg0KMDAwMDAxNTA3MiAwMDAwMCBuDQowMDAwMDE5NDg0IDAwMDAwIG4NCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCjAwMDAwMDAwMDAgNjU1MzUgZg0KMDAwMDAwMDAwMCA2NTUzNSBmDQowMDAwMDAwMDAwIDY1NTM1IGYNCnRyYWlsZXINCjw8L1NpemUgMzcvRW5jcnlwdCAzOCAwIFI+Pg0Kc3RhcnR4cmVmDQoxMTYNCiUlRU9GDQo=", "extension": "pdf"}
## Expected Result
I was expecting to have a successful call
## Actual Result
Error 500: {"message":"Unexpected control character found (DomainException)","code":0}
## Reproduction Steps
```python
import requests
```
## System Information
$ python -m requests.help
```json
{
"paste": "here"
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6756/reactions"
} | https://api.github.com/repos/psf/requests/issues/6756/timeline | null | completed | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/6755 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6755/labels{/name} | https://api.github.com/repos/psf/requests/issues/6755/comments | https://api.github.com/repos/psf/requests/issues/6755/events | https://github.com/psf/requests/issues/6755 | 2,380,917,287 | I_kwDOABTKOs6N6eon | 6,755 | Frequently hangs or times out when trying to fetch https://openssl.org/source/ | {
"avatar_url": "https://avatars.githubusercontent.com/u/11821574?v=4",
"events_url": "https://api.github.com/users/dschepler/events{/privacy}",
"followers_url": "https://api.github.com/users/dschepler/followers",
"following_url": "https://api.github.com/users/dschepler/following{/other_user}",
"gists_url": "https://api.github.com/users/dschepler/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dschepler",
"id": 11821574,
"login": "dschepler",
"node_id": "MDQ6VXNlcjExODIxNTc0",
"organizations_url": "https://api.github.com/users/dschepler/orgs",
"received_events_url": "https://api.github.com/users/dschepler/received_events",
"repos_url": "https://api.github.com/users/dschepler/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dschepler/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dschepler/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dschepler",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 3 | 2024-06-28T18:00:05Z | 2024-06-29T17:29:51Z | 2024-06-28T18:31:27Z | NONE | null | <!-- Summary. -->
As part of a software version webscraper I use requests. However, recently, it's started to be the case that for one particular site, https://openssl.org/source/ , it frequently hangs or times out when trying to fetch that page.
I was able to reproduce this simply by running: `python3 -c 'import requests; x = requests.get("https://openssl.org/source/", timeout=30)'`
## Expected Result
Should finish the request promptly (unless, of course, there's some connectivity issue; however, that doesn't seem to be the case since wget, curl, and Firefox have no issues fetching the same page).
## Actual Result
Frequently, the fetch fails due to a timeout. Traceback:
```
Traceback (most recent call last):
File "/usr/lib/python3.12/site-packages/urllib3/response.py", line 748, in _error_catcher
yield
File "/usr/lib/python3.12/site-packages/urllib3/response.py", line 873, in _raw_read
data = self._fp_read(amt, read1=read1) if not fp_closed else b""
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/urllib3/response.py", line 856, in _fp_read
return self._fp.read(amt) if amt is not None else self._fp.read()
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/http/client.py", line 479, in read
s = self.fp.read(amt)
^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/socket.py", line 708, in readinto
return self._sock.recv_into(b)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/ssl.py", line 1252, in recv_into
return self.read(nbytes, buffer)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/ssl.py", line 1104, in read
return self._sslobj.read(len, buffer)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TimeoutError: The read operation timed out
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/lib/python3.12/site-packages/requests/models.py", line 820, in generate
yield from self.raw.stream(chunk_size, decode_content=True)
File "/usr/lib/python3.12/site-packages/urllib3/response.py", line 1060, in stream
data = self.read(amt=amt, decode_content=decode_content)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/urllib3/response.py", line 949, in read
data = self._raw_read(amt)
^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/urllib3/response.py", line 872, in _raw_read
with self._error_catcher():
File "/usr/lib/python3.12/contextlib.py", line 158, in __exit__
self.gen.throw(value)
File "/usr/lib/python3.12/site-packages/urllib3/response.py", line 753, in _error_catcher
raise ReadTimeoutError(self._pool, None, "Read timed out.") from e # type: ignore[arg-type]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='openssl.org', port=443): Read timed out.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/lib/python3.12/site-packages/requests/api.py", line 73, in get
return request("get", url, params=params, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/requests/api.py", line 59, in request
return session.request(method=method, url=url, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/requests/sessions.py", line 746, in send
r.content
File "/usr/lib/python3.12/site-packages/requests/models.py", line 902, in content
self._content = b"".join(self.iter_content(CONTENT_CHUNK_SIZE)) or b""
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/site-packages/requests/models.py", line 826, in generate
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='openssl.org', port=443): Read timed out.
```
(If no timeout is specified, then it seems to hang indefinitely -- at least for several hours.)
## Reproduction Steps
```python
import requests
x = requests.get("https://openssl.org/source/", timeout=30)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.12.4"
},
"platform": {
"release": "6.9.7",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30300010"
},
"urllib3": {
"version": "2.2.2"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
(Note that I'm not sure whether this is actually an issue with requests, or maybe just the openssl.org website doing something weird. However, I haven't been able to reproduce similar problems using curl, wget, or Firefox.) | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6755/reactions"
} | https://api.github.com/repos/psf/requests/issues/6755/timeline | null | completed | null | null | false | [
"Please review the [documentation](https://docs.python-requests.org/en/latest/user/advanced/#timeouts) on using Requests with respect to timeouts.",
"OK, `x = requests.get(\"https://openssl.org/source/\", timeout=30)` does seem to time out instead of hanging indefinitely. The question remains, though, why it frequently times out when none of the command line tools or web browsers I've tested have any such issues fetching that page.",
"It never hangs for me or times out. This no way for us to debug this for you or provide you an answer"
] |
https://api.github.com/repos/psf/requests/issues/6754 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6754/labels{/name} | https://api.github.com/repos/psf/requests/issues/6754/comments | https://api.github.com/repos/psf/requests/issues/6754/events | https://github.com/psf/requests/issues/6754 | 2,380,055,424 | I_kwDOABTKOs6N3MOA | 6,754 | PDF download is distorted using requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/112604065?v=4",
"events_url": "https://api.github.com/users/Puris2/events{/privacy}",
"followers_url": "https://api.github.com/users/Puris2/followers",
"following_url": "https://api.github.com/users/Puris2/following{/other_user}",
"gists_url": "https://api.github.com/users/Puris2/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Puris2",
"id": 112604065,
"login": "Puris2",
"node_id": "U_kgDOBrYzoQ",
"organizations_url": "https://api.github.com/users/Puris2/orgs",
"received_events_url": "https://api.github.com/users/Puris2/received_events",
"repos_url": "https://api.github.com/users/Puris2/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Puris2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Puris2/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Puris2",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2024-06-28T10:00:04Z | 2024-06-28T10:37:40Z | 2024-06-28T10:37:38Z | NONE | null | <!-- Summary. -->
## Expected Result
The PDF should download without any distortions, similar to how it downloads when using Chrome directly.
## Actual Result
When downloading the PDF from the specified URL using the requests library in Python, the resulting file is distorted. There are lines across the pages and some blank pages. However, downloading the same PDF directly from Chrome results in a perfect file.
## Reproduction Steps
```python
import requests
headers = {
'Accept': 'application/pdf',
'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36',,
}
params = {
'doc': '3150239',
}
response = requests.get('https://adxservices.adx.ae/cdn/contentdownload.aspx', params=params,
[Uploading document.pdf…]()
headers=headers)
# Check if the response is a PDF
if response.headers.get('Content-Type') == 'application/pdf':
# Save the content as a PDF file
with open('document.pdf', 'wb') as file:
file.write(response.content)
print("PDF downloaded successfully.")
else:
print(f"Unexpected content type: {response.headers.get('Content-Type')}")
with open('response.html', 'wb') as file:
file.write(response.content)
print("Response saved as HTML for inspection.")
```
## System Information
$ python -m requests.help
```json
{
"paste": "here"
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6754/reactions"
} | https://api.github.com/repos/psf/requests/issues/6754/timeline | null | not_planned | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/6753 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6753/labels{/name} | https://api.github.com/repos/psf/requests/issues/6753/comments | https://api.github.com/repos/psf/requests/issues/6753/events | https://github.com/psf/requests/issues/6753 | 2,377,262,036 | I_kwDOABTKOs6NsiPU | 6,753 | Possible .get bug in version 2.32.3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/22191282?v=4",
"events_url": "https://api.github.com/users/mhenrichsen/events{/privacy}",
"followers_url": "https://api.github.com/users/mhenrichsen/followers",
"following_url": "https://api.github.com/users/mhenrichsen/following{/other_user}",
"gists_url": "https://api.github.com/users/mhenrichsen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mhenrichsen",
"id": 22191282,
"login": "mhenrichsen",
"node_id": "MDQ6VXNlcjIyMTkxMjgy",
"organizations_url": "https://api.github.com/users/mhenrichsen/orgs",
"received_events_url": "https://api.github.com/users/mhenrichsen/received_events",
"repos_url": "https://api.github.com/users/mhenrichsen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mhenrichsen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mhenrichsen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mhenrichsen",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-06-27T06:21:52Z | 2024-06-27T07:33:49Z | 2024-06-27T06:28:03Z | NONE | null | When executing a file named ast.py which .get(url) it fails with `AttributeError: partially initialized module 'requests' has no attribute 'get' (most likely due to a circular import)`
## Expected Result
<!-- What you expected. -->
To fetch the contents.
<!-- What happened instead. -->
1. Create a file named ast.py
2.
```import requests
x = requests.get('https://w3schools.com')
print(x.status_code)
```
3. rename the file for success.
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.12.4"
},
"platform": {
"release": "23.2.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30300010"
},
"urllib3": {
"version": "2.2.1"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6753/reactions"
} | https://api.github.com/repos/psf/requests/issues/6753/timeline | null | not_planned | null | null | false | [
"[`ast`](https://docs.python.org/3/library/ast.html) is a module in the standard library. Shadowing commonly used modules will lead to breakages in most Python libraries. This isn't something we can address in Requests, this is a fundamental of the language.",
"@nateprewitt thanks for letting me know. It was driving me crazy. "
] |
https://api.github.com/repos/psf/requests/issues/6752 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6752/labels{/name} | https://api.github.com/repos/psf/requests/issues/6752/comments | https://api.github.com/repos/psf/requests/issues/6752/events | https://github.com/psf/requests/issues/6752 | 2,375,123,016 | I_kwDOABTKOs6NkYBI | 6,752 | RFC9113 - HTTP/2.0 | {
"avatar_url": "https://avatars.githubusercontent.com/u/18104456?v=4",
"events_url": "https://api.github.com/users/detrin/events{/privacy}",
"followers_url": "https://api.github.com/users/detrin/followers",
"following_url": "https://api.github.com/users/detrin/following{/other_user}",
"gists_url": "https://api.github.com/users/detrin/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/detrin",
"id": 18104456,
"login": "detrin",
"node_id": "MDQ6VXNlcjE4MTA0NDU2",
"organizations_url": "https://api.github.com/users/detrin/orgs",
"received_events_url": "https://api.github.com/users/detrin/received_events",
"repos_url": "https://api.github.com/users/detrin/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/detrin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/detrin/subscriptions",
"type": "User",
"url": "https://api.github.com/users/detrin",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156041422,
"name": "actions/autoclose-feat",
"node_id": "LA_kwDOABTKOs8AAAABbu28zg",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-feat"
}
] | closed | true | null | [] | null | 1 | 2024-06-26T11:51:13Z | 2024-06-26T11:51:24Z | 2024-06-26T11:51:23Z | NONE | off-topic | I can't find support for HTTP/2.0 in this package, I am also not sure if `urllib3` supports HTTP/2.0. If it does support, then I guess adding the support to `requests` won't be that difficult.
https://datatracker.ietf.org/doc/html/rfc9113
It is probably still blocked by the support of HTTP/2.0 in `urllib3` - the tracking issue https://github.com/urllib3/urllib3/issues/3000
I feel like there could be already some preparations for that even if the `urllib3` is not supporting it now. | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6752/reactions"
} | https://api.github.com/repos/psf/requests/issues/6752/timeline | null | not_planned | null | null | false | [
"As described in the template, Requests is not accepting feature requests"
] |
https://api.github.com/repos/psf/requests/issues/6751 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6751/labels{/name} | https://api.github.com/repos/psf/requests/issues/6751/comments | https://api.github.com/repos/psf/requests/issues/6751/events | https://github.com/psf/requests/issues/6751 | 2,371,331,281 | I_kwDOABTKOs6NV6TR | 6,751 | requests > 2.31.0 - Unhashable type 'list' for 'cert' parameter | {
"avatar_url": "https://avatars.githubusercontent.com/u/36009512?v=4",
"events_url": "https://api.github.com/users/greateggsgreg/events{/privacy}",
"followers_url": "https://api.github.com/users/greateggsgreg/followers",
"following_url": "https://api.github.com/users/greateggsgreg/following{/other_user}",
"gists_url": "https://api.github.com/users/greateggsgreg/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/greateggsgreg",
"id": 36009512,
"login": "greateggsgreg",
"node_id": "MDQ6VXNlcjM2MDA5NTEy",
"organizations_url": "https://api.github.com/users/greateggsgreg/orgs",
"received_events_url": "https://api.github.com/users/greateggsgreg/received_events",
"repos_url": "https://api.github.com/users/greateggsgreg/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/greateggsgreg/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/greateggsgreg/subscriptions",
"type": "User",
"url": "https://api.github.com/users/greateggsgreg",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-06-25T00:03:11Z | 2024-09-10T23:40:24Z | 2024-06-25T21:44:46Z | NONE | null | ### Subject
The requests.get() parameter used to accept 'cert' as a tuple or list, and this may be a regression from #1165
### Environment
All
### Steps to Reproduce
```
>>> import requests
>>> requests.get('https://localhost:8080/asdf', cert=['client-cert.pem', 'client-key.pem'], verify='ca-cert.pem')
Traceback (most recent call last):
<snip>
TypeError: unhashable type: 'list'
>>> requests.get('https://localhost:8080/asdf', cert=('client-cert.pem', 'client-key.pem'), verify='ca-cert.pem')
<Response [200]>
```
### Expected Behavior
From requests == 2.31.0:
```
>>> import requests
>>> requests.get('https://localhost:8080/asdf'', cert=['client-cert.pem', 'client-key.pem'], verify='ca-cert.pem')
<Response [200]>
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/36009512?v=4",
"events_url": "https://api.github.com/users/greateggsgreg/events{/privacy}",
"followers_url": "https://api.github.com/users/greateggsgreg/followers",
"following_url": "https://api.github.com/users/greateggsgreg/following{/other_user}",
"gists_url": "https://api.github.com/users/greateggsgreg/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/greateggsgreg",
"id": 36009512,
"login": "greateggsgreg",
"node_id": "MDQ6VXNlcjM2MDA5NTEy",
"organizations_url": "https://api.github.com/users/greateggsgreg/orgs",
"received_events_url": "https://api.github.com/users/greateggsgreg/received_events",
"repos_url": "https://api.github.com/users/greateggsgreg/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/greateggsgreg/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/greateggsgreg/subscriptions",
"type": "User",
"url": "https://api.github.com/users/greateggsgreg",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6751/reactions"
} | https://api.github.com/repos/psf/requests/issues/6751/timeline | null | completed | null | null | false | [
"It's always been documented as a tuple, and there's never been testing for accepting a list. I understand this seems like a regression but in reality it's an accidental improvement in what we accept to better match what we have documented since before 1.0",
"It broke shit. Thanks for that. Particularly, since you also improved nothing..."
] |
https://api.github.com/repos/psf/requests/issues/6750 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6750/labels{/name} | https://api.github.com/repos/psf/requests/issues/6750/comments | https://api.github.com/repos/psf/requests/issues/6750/events | https://github.com/psf/requests/pull/6750 | 2,370,269,383 | PR_kwDOABTKOs5zXnNH | 6,750 | catch FileNotFoundError if there aren't any certificates | {
"avatar_url": "https://avatars.githubusercontent.com/u/31752768?v=4",
"events_url": "https://api.github.com/users/eaglegai/events{/privacy}",
"followers_url": "https://api.github.com/users/eaglegai/followers",
"following_url": "https://api.github.com/users/eaglegai/following{/other_user}",
"gists_url": "https://api.github.com/users/eaglegai/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eaglegai",
"id": 31752768,
"login": "eaglegai",
"node_id": "MDQ6VXNlcjMxNzUyNzY4",
"organizations_url": "https://api.github.com/users/eaglegai/orgs",
"received_events_url": "https://api.github.com/users/eaglegai/received_events",
"repos_url": "https://api.github.com/users/eaglegai/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eaglegai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eaglegai/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eaglegai",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2024-06-24T13:32:09Z | 2024-08-12T07:55:19Z | null | NONE | null | fix https://github.com/psf/requests/issues/6749 | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6750/reactions"
} | https://api.github.com/repos/psf/requests/issues/6750/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6750.diff",
"html_url": "https://github.com/psf/requests/pull/6750",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6750.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6750"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6749 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6749/labels{/name} | https://api.github.com/repos/psf/requests/issues/6749/comments | https://api.github.com/repos/psf/requests/issues/6749/events | https://github.com/psf/requests/issues/6749 | 2,370,262,817 | I_kwDOABTKOs6NR1ch | 6,749 | catch FileNotFoundError if there aren't any certificates | {
"avatar_url": "https://avatars.githubusercontent.com/u/31752768?v=4",
"events_url": "https://api.github.com/users/eaglegai/events{/privacy}",
"followers_url": "https://api.github.com/users/eaglegai/followers",
"following_url": "https://api.github.com/users/eaglegai/following{/other_user}",
"gists_url": "https://api.github.com/users/eaglegai/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eaglegai",
"id": 31752768,
"login": "eaglegai",
"node_id": "MDQ6VXNlcjMxNzUyNzY4",
"organizations_url": "https://api.github.com/users/eaglegai/orgs",
"received_events_url": "https://api.github.com/users/eaglegai/received_events",
"repos_url": "https://api.github.com/users/eaglegai/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eaglegai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eaglegai/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eaglegai",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 136589914,
"name": "Needs Info",
"node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info"
}
] | open | false | null | [] | null | 2 | 2024-06-24T13:29:04Z | 2024-07-03T15:00:23Z | null | NONE | null | <!-- Summary. -->
I set verify to False, but it still need cerfiticate.
As we have catched ImportError, why not catch FileNotFoundError together?
## Expected Result
won't Traceback
<!-- What you expected. -->
## Actual Result
```
[root@localhost requests]# ./test-requests.py
Traceback (most recent call last):
File "/root/test/requests/./test-requests.py", line 2, in <module>
import requests
File "/usr/lib/python3.9/site-packages/requests/__init__.py", line 136, in <module>
from .api import request, get, head, post, patch, put, delete, options
File "/usr/lib/python3.9/site-packages/requests/api.py", line 13, in <module>
from . import sessions
File "/usr/lib/python3.9/site-packages/requests/sessions.py", line 28, in <module>
from .adapters import HTTPAdapter
File "/usr/lib/python3.9/site-packages/requests/adapters.py", line 65, in <module>
_preloaded_ssl_context.load_verify_locations(
FileNotFoundError: [Errno 2] No such file or directory
```
<!-- What happened instead. -->
## Reproduction Steps
```
#!/usr/bin/python3
import requests
r = requests.get("http://127.0.0.1",verify=False)
print(r.text)
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6749/reactions"
} | https://api.github.com/repos/psf/requests/issues/6749/timeline | null | null | null | null | false | [
"Hi @eaglegai, `certifi` is a [declared dependency](https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/setup.py#L65) of Requests. This should be available in all installations. We derive the the [`DEFAULT_CA_BUNDLE_PATH`](https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/src/requests/utils.py#L63) being used in this line from `requests.certs.where()`.\r\n\r\nCan you confirm you 1.) have `certifi` installed and 2.) the value of `import requests; requests.certs.where()`?",
"Hi @nateprewitt , we build a mini environment which cut off the unnecessary packages,\r\nand in this env, we just `import requests `for `http://` and `verify is false` is enough.\r\nIt's not reasonable to force to load the certificates by default, because it's not necessary in the case that verify is false.\r\n\r\nAs we consider the case that isn't built with the ssl module, why not consider the situation that 'verify is false' needn't certificates.\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6748 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6748/labels{/name} | https://api.github.com/repos/psf/requests/issues/6748/comments | https://api.github.com/repos/psf/requests/issues/6748/events | https://github.com/psf/requests/issues/6748 | 2,366,627,412 | I_kwDOABTKOs6ND95U | 6,748 | Unclear file handling in documentation examples | {
"avatar_url": "https://avatars.githubusercontent.com/u/50702276?v=4",
"events_url": "https://api.github.com/users/daniboygg/events{/privacy}",
"followers_url": "https://api.github.com/users/daniboygg/followers",
"following_url": "https://api.github.com/users/daniboygg/following{/other_user}",
"gists_url": "https://api.github.com/users/daniboygg/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/daniboygg",
"id": 50702276,
"login": "daniboygg",
"node_id": "MDQ6VXNlcjUwNzAyMjc2",
"organizations_url": "https://api.github.com/users/daniboygg/orgs",
"received_events_url": "https://api.github.com/users/daniboygg/received_events",
"repos_url": "https://api.github.com/users/daniboygg/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/daniboygg/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/daniboygg/subscriptions",
"type": "User",
"url": "https://api.github.com/users/daniboygg",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-06-21T14:07:27Z | 2024-06-27T07:25:44Z | 2024-06-27T07:25:44Z | NONE | null | In the Requests documentation section on posting multiple multipart-encoded files (https://requests.readthedocs.io/en/latest/user/advanced/#post-multiple-multipart-encoded-files), the files are opened but not explicitly closed:
```
url = 'https://httpbin.org/post'
multiple_files = [
('images', ('foo.png', open('foo.png', 'rb'), 'image/png')),
('images', ('bar.png', open('bar.png', 'rb'), 'image/png'))]
r = requests.post(url, files=multiple_files)
r.text
{
...
'files': {'images': 'data:image/png;base64,iVBORw ....'}
'Content-Type': 'multipart/form-data; boundary=3131623adb2043caaeb5538cc7aa0b3a',
...
}
```
Does the library internally close the file handle during the post request?
After trying some simple examples, I found that the file does not close automatically. Would it be worth considering a mention in the documentation that users should close the file, or perhaps updating the example to demonstrate this scenario? | {
"avatar_url": "https://avatars.githubusercontent.com/u/50702276?v=4",
"events_url": "https://api.github.com/users/daniboygg/events{/privacy}",
"followers_url": "https://api.github.com/users/daniboygg/followers",
"following_url": "https://api.github.com/users/daniboygg/following{/other_user}",
"gists_url": "https://api.github.com/users/daniboygg/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/daniboygg",
"id": 50702276,
"login": "daniboygg",
"node_id": "MDQ6VXNlcjUwNzAyMjc2",
"organizations_url": "https://api.github.com/users/daniboygg/orgs",
"received_events_url": "https://api.github.com/users/daniboygg/received_events",
"repos_url": "https://api.github.com/users/daniboygg/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/daniboygg/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/daniboygg/subscriptions",
"type": "User",
"url": "https://api.github.com/users/daniboygg",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6748/reactions"
} | https://api.github.com/repos/psf/requests/issues/6748/timeline | null | completed | null | null | false | [
"Is it necessary to mention every possible best practice a person must follow when writing python in any section of the documentation? I really don't believe we must explain that as people should already be able to understand best practices around managing open files.\n\nWhat made you assume requests would close the file for you? Why did that seem like a reasonable assumption? ",
"When I was reading the documentation, it wasn't clear to me what the library exactly did with the file after passing it. After testing it out, I understood better and felt this might be a question other developers would ask too. I do get that this could make the examples a bit less straightforward, though. Thanks for taking the time to respond to me."
] |
https://api.github.com/repos/psf/requests/issues/6747 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6747/labels{/name} | https://api.github.com/repos/psf/requests/issues/6747/comments | https://api.github.com/repos/psf/requests/issues/6747/events | https://github.com/psf/requests/issues/6747 | 2,366,611,554 | I_kwDOABTKOs6ND6Bi | 6,747 | Check for codes | {
"avatar_url": "https://avatars.githubusercontent.com/u/107356363?v=4",
"events_url": "https://api.github.com/users/Gostqa/events{/privacy}",
"followers_url": "https://api.github.com/users/Gostqa/followers",
"following_url": "https://api.github.com/users/Gostqa/following{/other_user}",
"gists_url": "https://api.github.com/users/Gostqa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Gostqa",
"id": 107356363,
"login": "Gostqa",
"node_id": "U_kgDOBmYgyw",
"organizations_url": "https://api.github.com/users/Gostqa/orgs",
"received_events_url": "https://api.github.com/users/Gostqa/received_events",
"repos_url": "https://api.github.com/users/Gostqa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Gostqa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Gostqa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Gostqa",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-06-21T13:59:08Z | 2024-06-21T13:59:20Z | 2024-06-21T13:59:19Z | NONE | off-topic | Please refer to our [Stack Overflow tag](https://stackoverflow.com/questions/tagged/python-requests) for guidance. | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6747/reactions"
} | https://api.github.com/repos/psf/requests/issues/6747/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6746 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6746/labels{/name} | https://api.github.com/repos/psf/requests/issues/6746/comments | https://api.github.com/repos/psf/requests/issues/6746/events | https://github.com/psf/requests/pull/6746 | 2,365,927,753 | PR_kwDOABTKOs5zJvlP | 6,746 | feat:add chunked parameter for request method | {
"avatar_url": "https://avatars.githubusercontent.com/u/32889277?v=4",
"events_url": "https://api.github.com/users/LoveEatCandy/events{/privacy}",
"followers_url": "https://api.github.com/users/LoveEatCandy/followers",
"following_url": "https://api.github.com/users/LoveEatCandy/following{/other_user}",
"gists_url": "https://api.github.com/users/LoveEatCandy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/LoveEatCandy",
"id": 32889277,
"login": "LoveEatCandy",
"node_id": "MDQ6VXNlcjMyODg5Mjc3",
"organizations_url": "https://api.github.com/users/LoveEatCandy/orgs",
"received_events_url": "https://api.github.com/users/LoveEatCandy/received_events",
"repos_url": "https://api.github.com/users/LoveEatCandy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/LoveEatCandy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/LoveEatCandy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/LoveEatCandy",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-06-21T07:40:27Z | 2024-06-21T11:29:31Z | 2024-06-21T11:29:31Z | NONE | null | I need `chunked` parameter for uploading big size files, because header `Transfer-Encoding: chunked` is not work. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6746/reactions"
} | https://api.github.com/repos/psf/requests/issues/6746/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6746.diff",
"html_url": "https://github.com/psf/requests/pull/6746",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6746.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6746"
} | true | [
"Please open a bug report with reproducible steps explaining the bug first. "
] |
https://api.github.com/repos/psf/requests/issues/6745 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6745/labels{/name} | https://api.github.com/repos/psf/requests/issues/6745/comments | https://api.github.com/repos/psf/requests/issues/6745/events | https://github.com/psf/requests/issues/6745 | 2,362,316,164 | I_kwDOABTKOs6MzhWE | 6,745 | Requests v2.32.0 caused the error `Segmentation fault` when including the `cert` parameter | {
"avatar_url": "https://avatars.githubusercontent.com/u/8820706?v=4",
"events_url": "https://api.github.com/users/mingshuang/events{/privacy}",
"followers_url": "https://api.github.com/users/mingshuang/followers",
"following_url": "https://api.github.com/users/mingshuang/following{/other_user}",
"gists_url": "https://api.github.com/users/mingshuang/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mingshuang",
"id": 8820706,
"login": "mingshuang",
"node_id": "MDQ6VXNlcjg4MjA3MDY=",
"organizations_url": "https://api.github.com/users/mingshuang/orgs",
"received_events_url": "https://api.github.com/users/mingshuang/received_events",
"repos_url": "https://api.github.com/users/mingshuang/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mingshuang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mingshuang/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mingshuang",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 3 | 2024-06-19T12:53:40Z | 2024-07-21T03:01:40Z | 2024-07-07T21:24:02Z | NONE | null | <!-- Summary. -->
After updating the requests to v2.32.0, my service started failure and raised the error `Segmentation fault`. After some debugging and including `faulthandler.enable()` into my code, I saw the trace is below, and no such as kind problem with version `v2.31.0`
```
File "/opt/vpnaas/lib64/python3.11/site-packages/urllib3/util/ssl_.py", line 418 in ssl_wrap_socket
File "/opt/vpnaas/lib64/python3.11/site-packages/urllib3/connection.py", line 419 in connect
File "/opt/vpnaas/lib64/python3.11/site-packages/urllib3/connectionpool.py", line 1058 in _validate_conn
File "/opt/vpnaas/lib64/python3.11/site-packages/urllib3/connectionpool.py", line 404 in _make_request
File "/opt/vpnaas/lib64/python3.11/site-packages/urllib3/connectionpool.py", line 715 in urlopen
File "/opt/vpnaas/lib64/python3.11/site-packages/requests/adapters.py", line 564 in send
File "/opt/vpnaas/lib64/python3.11/site-packages/requests/sessions.py", line 703 in send
File "/opt/vpnaas/lib64/python3.11/site-packages/requests/sessions.py", line 589 in request
File "/opt/vpnaas/lib64/python3.11/site-packages/requests/api.py", line 59 in request
File "/opt/vpnaas/lib64/python3.11/site-packages/requests/api.py", line 73 in get
```
## Expected Result
There is no `Segmentation fault`
<!-- What you expected. -->
## Actual Result
Saw the `Segmentation fault` randomly.
<!-- What happened instead. -->
## Reproduction Steps
To help to reproduce the problem, I wrote a script below to simulate my service code. and before executing the script, a certificate is needed and can be generated with command `openssl req -x509 -newkey rsa:4096 -keyout client.key -out client.crt -days 365 -nodes`
```python
import concurrent.futures
import random
import uuid
from threading import Thread
from time import time
import requests
def do_request():
start = time()
random_id = uuid.uuid4()
delay = random.randint(1, 5)
print("start {} delay {} seconds".format(random_id, delay))
endpoints = []
endpoints.append('https://httpbin.org/delay/' + str(delay))
delay = str(random.randint(1, 5)) + 's'
endpoints.append('https://run.mocky.io/v3/0432e9f0-674f-45bd-9c18-628b861c2258?mocky-delay=' + str(delay))
random.shuffle(endpoints)
response = None
for endpoint in endpoints:
try:
print("start {} delay {} seconds".format(random_id, endpoint))
if 'run' in endpoint:
cert = './client.crt', './client.key'
response = requests.get(endpoint, timeout=random.randint(1, 5), cert=cert)
else:
response = requests.get(endpoint, timeout=random.randint(1, 5))
except Exception as e:
print(e)
end = time()
print("finished {} in {} seconds".format(random_id, end - start))
return response
def measure():
cnt = 20
with concurrent.futures.ThreadPoolExecutor(max_workers=10) as executor:
futures = []
for server in range(1, cnt):
futures.append(executor.submit(do_request))
for future in concurrent.futures.as_completed(futures):
pass
for i in range(1, 500):
threads = [Thread(target=measure, args=()) for _ in range(5)]
for t in threads: t.start()
for t in threads: t.join()
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.11.7"
},
"platform": {
"release": "4.18.0-553.5.1.el8_10.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.0"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.26.18"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6745/reactions"
} | https://api.github.com/repos/psf/requests/issues/6745/timeline | null | completed | null | null | false | [
"@mingshuang there were initially some issues with the first releases of 2.32.x which is why 2.32.0 and 2.32.1 are yanked from PyPI. Can you please try this with 2.32.3 (the latest release) and if the issue is still reproducing there, check this patch https://github.com/psf/requests/pull/6731/files?",
"Resolving as a duplicate #6731 since we haven't heard back.",
"hi @nateprewitt yes, I tried 2.32.3 and the result is same. and also tried the PR https://github.com/psf/requests/pull/6731, this PR indeed address my problem. "
] |
https://api.github.com/repos/psf/requests/issues/6744 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6744/labels{/name} | https://api.github.com/repos/psf/requests/issues/6744/comments | https://api.github.com/repos/psf/requests/issues/6744/events | https://github.com/psf/requests/issues/6744 | 2,360,682,581 | I_kwDOABTKOs6MtShV | 6,744 | ValueError: Timeout value connect was <object object at 0x7c6b5e484a80>, but it must be an int, float or None. | {
"avatar_url": "https://avatars.githubusercontent.com/u/48888981?v=4",
"events_url": "https://api.github.com/users/idan3/events{/privacy}",
"followers_url": "https://api.github.com/users/idan3/followers",
"following_url": "https://api.github.com/users/idan3/following{/other_user}",
"gists_url": "https://api.github.com/users/idan3/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/idan3",
"id": 48888981,
"login": "idan3",
"node_id": "MDQ6VXNlcjQ4ODg4OTgx",
"organizations_url": "https://api.github.com/users/idan3/orgs",
"received_events_url": "https://api.github.com/users/idan3/received_events",
"repos_url": "https://api.github.com/users/idan3/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/idan3/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/idan3/subscriptions",
"type": "User",
"url": "https://api.github.com/users/idan3",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-06-18T20:46:36Z | 2024-06-19T07:42:18Z | 2024-06-18T22:03:25Z | NONE | null | I use google-cloud-bigquery==3.12.0 which uses requests.
requests and urllib3 are pined.
requests==2.31.0
urllib3==1.26.18
I get this problem:
```
File "/usr/local/lib/python3.10/site-packages/google/api_core/future/polling.py", line 282, in exception
self._blocking_poll(timeout=timeout)
File "/usr/local/lib/python3.10/site-packages/google/cloud/bigquery/job/query.py", line 1318, in _blocking_poll
super(QueryJob, self)._blocking_poll(timeout=timeout, **kwargs)
File "/usr/local/lib/python3.10/site-packages/google/api_core/future/polling.py", line 137, in _blocking_poll
polling(self._done_or_raise)(retry=retry)
File "/usr/local/lib/python3.10/site-packages/google/api_core/retry.py", line 366, in retry_wrapped_func
return retry_target(
File "/usr/local/lib/python3.10/site-packages/google/api_core/retry.py", line 204, in retry_target
return target()
File "/usr/local/lib/python3.10/site-packages/google/cloud/bigquery/job/query.py", line 1460, in _done_or_raise
self.reload(retry=retry, timeout=transport_timeout)
File "/usr/local/lib/python3.10/site-packages/google/cloud/bigquery/job/base.py", line 781, in reload
api_response = client._call_api(
File "/usr/local/lib/python3.10/site-packages/google/cloud/bigquery/client.py", line 816, in _call_api
return call()
File "/usr/local/lib/python3.10/site-packages/google/cloud/_http/__init__.py", line 482, in api_request
response = self._make_request(
File "/usr/local/lib/python3.10/site-packages/google/cloud/_http/__init__.py", line 341, in _make_request
return self._do_request(
File "/usr/local/lib/python3.10/site-packages/google/cloud/_http/__init__.py", line 379, in _do_request
return self.http.request(
File "/usr/local/lib/python3.10/site-packages/google/auth/transport/requests.py", line 542, in request
response = super(AuthorizedSession, self).request(
File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/adapters.py", line 483, in send
timeout = TimeoutSauce(connect=timeout, read=timeout)
File "/usr/local/lib/python3.10/site-packages/urllib3/util/timeout.py", line 102, in __init__
self._connect = self._validate_timeout(connect, "connect")
File "/usr/local/lib/python3.10/site-packages/urllib3/util/timeout.py", line 147, in _validate_timeout
raise ValueError(
ValueError: Timeout value connect was <object object at 0x7c6b5e484a80>, but it must be an int, float or None.
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6744/reactions"
} | https://api.github.com/repos/psf/requests/issues/6744/timeline | null | not_planned | null | null | false | [
"This seems to be an issue with what the Google libraries are passing into requests and which we then pass on to urllib3. Raise a bug with Google. "
] |
https://api.github.com/repos/psf/requests/issues/6743 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6743/labels{/name} | https://api.github.com/repos/psf/requests/issues/6743/comments | https://api.github.com/repos/psf/requests/issues/6743/events | https://github.com/psf/requests/issues/6743 | 2,355,094,000 | I_kwDOABTKOs6MX-Hw | 6,743 | requests library seems to ignore "Transfer-Encoding" header | {
"avatar_url": "https://avatars.githubusercontent.com/u/76537991?v=4",
"events_url": "https://api.github.com/users/Green360/events{/privacy}",
"followers_url": "https://api.github.com/users/Green360/followers",
"following_url": "https://api.github.com/users/Green360/following{/other_user}",
"gists_url": "https://api.github.com/users/Green360/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Green360",
"id": 76537991,
"login": "Green360",
"node_id": "MDQ6VXNlcjc2NTM3OTkx",
"organizations_url": "https://api.github.com/users/Green360/orgs",
"received_events_url": "https://api.github.com/users/Green360/received_events",
"repos_url": "https://api.github.com/users/Green360/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Green360/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Green360/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Green360",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-06-15T18:12:30Z | 2024-06-15T18:12:42Z | 2024-06-15T18:12:41Z | NONE | off-topic | I want to send a request with "Transfer-Encoding:chunked" but somehow the header is never set.
Below is my code for testing and the corresponding captured request.
```
import requests
url = 'http://[replaced]/test.php'
def data_chunks():
yield b'8\r\n'
yield b'search=1\r\n'
yield b'0\r\n'
response = requests.post(url,data=data_chunks(), headers={"Content-Type":"application/x-www-form-urlencoded","Transfer-Encoding":"chunked"}, proxies={"http":"http://127.0.0.1:8080"})
```
> POST /test.php HTTP/1.1
> Host: [replaced]
> User-Agent: python-requests/2.28.1
> Accept-Encoding: gzip, deflate
> Accept: */*
> Connection: close
> Content-Type: application/x-www-form-urlencoded
> Content-Length: 16
>
> 8
> search=1
> 0
If I do not set the "Transfer-Encoding" header it is not used and even if I explicitly set the "Transfer-Encoding" header it is not used. The requests library always seems to put a "Content-Length" instead.
What am I supposed to do? | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6743/reactions"
} | https://api.github.com/repos/psf/requests/issues/6743/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6742 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6742/labels{/name} | https://api.github.com/repos/psf/requests/issues/6742/comments | https://api.github.com/repos/psf/requests/issues/6742/events | https://github.com/psf/requests/issues/6742 | 2,350,996,704 | I_kwDOABTKOs6MIVzg | 6,742 | inconsistent handling of verify and REQUESTS_CA_BUNDLE | {
"avatar_url": "https://avatars.githubusercontent.com/u/670894?v=4",
"events_url": "https://api.github.com/users/houtmanj/events{/privacy}",
"followers_url": "https://api.github.com/users/houtmanj/followers",
"following_url": "https://api.github.com/users/houtmanj/following{/other_user}",
"gists_url": "https://api.github.com/users/houtmanj/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/houtmanj",
"id": 670894,
"login": "houtmanj",
"node_id": "MDQ6VXNlcjY3MDg5NA==",
"organizations_url": "https://api.github.com/users/houtmanj/orgs",
"received_events_url": "https://api.github.com/users/houtmanj/received_events",
"repos_url": "https://api.github.com/users/houtmanj/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/houtmanj/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/houtmanj/subscriptions",
"type": "User",
"url": "https://api.github.com/users/houtmanj",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-06-13T12:17:23Z | 2024-06-13T13:36:10Z | 2024-06-13T13:36:10Z | NONE | null | The interaction between the `verify` parameter and REQUESTS_CA_BUNDLE is inconsistent when using a `Session`.
Assuming the REQUESTS_CA_BUNDLE environment variable is set.
will NOT result in ssl verification:
```
sess = requests.Session()
sess.get("https://illegalcert.com", verify=False)
```
will verify the ssl verification:
```
sess = requests.Session()
sess.verify = False
sess.get("https://illegalcert.com")
```
## Expected Result
I would expect both scenario's not to verify the ssl certificate.
## Actual Result
When session.verify is set to False, it is overruled by the existence of the REQUESTS_CA_BUNDLE environment variable.
## Reproduction Steps
export REQUESTS_CA_BUNDLE=/path/to/ca
```python
sess = requests.Session()
# Will not verify the ssl certificate
sess.get("https://illegalcert.com", verify=False)
# will verify the ssl certificate
sess.verify = False
sess.get("https://illegalcert.com")
```
This is governed by: https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/src/requests/sessions.py#L766
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.6"
},
"implementation": {
"name": "CPython",
"version": "3.11.6"
},
"platform": {
"release": "5.15.146.1-microsoft-standard-WSL2",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30000020"
},
"urllib3": {
"version": "2.2.1"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6742/reactions"
} | https://api.github.com/repos/psf/requests/issues/6742/timeline | null | completed | null | null | false | [
"In the future, please search **closed and** open issues before creating new ones that are duplicates."
] |
https://api.github.com/repos/psf/requests/issues/6741 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6741/labels{/name} | https://api.github.com/repos/psf/requests/issues/6741/comments | https://api.github.com/repos/psf/requests/issues/6741/events | https://github.com/psf/requests/issues/6741 | 2,350,016,068 | I_kwDOABTKOs6MEmZE | 6,741 | auth headers lost when requests process redirected requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/29160619?v=4",
"events_url": "https://api.github.com/users/dengshaochun/events{/privacy}",
"followers_url": "https://api.github.com/users/dengshaochun/followers",
"following_url": "https://api.github.com/users/dengshaochun/following{/other_user}",
"gists_url": "https://api.github.com/users/dengshaochun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dengshaochun",
"id": 29160619,
"login": "dengshaochun",
"node_id": "MDQ6VXNlcjI5MTYwNjE5",
"organizations_url": "https://api.github.com/users/dengshaochun/orgs",
"received_events_url": "https://api.github.com/users/dengshaochun/received_events",
"repos_url": "https://api.github.com/users/dengshaochun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dengshaochun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dengshaochun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dengshaochun",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-06-13T02:38:08Z | 2024-06-13T10:21:03Z | 2024-06-13T10:21:03Z | NONE | null | auth headers lost when requests process redirected requests
```python
def print_request_info(response, *args, **kwargs):
request = response.request
print(f"Request URL: {request.url}")
print(f"Request Headers: {request.headers}")
print(f"Request Data: {request.body}")
print(f"Response Status Code: {response.status_code}")
print(f"Response Headers: {response.headers}")
print(f"Response Text: {response.text}")
response = requests.put(
self.url,
headers=headers,
data=json_data,
auth=self.auth,
timeout=100,
hooks={"response": print_request_info},
)
```
## Expected Result
request headers
```python
{'User-Agent': 'python-requests/2.27.1', 'Accept-Encoding': 'gzip, deflate', 'Accept': '*/*', 'Connection': 'keep-alive', 'format': 'json', 'Expect': '100-continue', 'strip_outer_array': 'true', 'Content-Length': '2305', 'Authorization': 'Basic xxxxx'}
```
Response Status Code: 307
redirected headers
```python
{'User-Agent': 'python-requests/2.27.1', 'Accept-Encoding': 'gzip, deflate', 'Accept': '*/*', 'Connection': 'keep-alive', 'format': 'json', 'Expect': '100-continue', 'strip_outer_array': 'true', 'Content-Length': '2305'}
```
## Actual Result
redirected headers contains `Authorization`
## Reproduction Steps
```python
import requests
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.12"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.6.8"
},
"platform": {
"release": "5.4.119-1-tlinux4-0010.1",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.27.1"
},
"system_ssl": {
"version": "100020bf"
},
"urllib3": {
"version": "1.26.9"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6741/reactions"
} | https://api.github.com/repos/psf/requests/issues/6741/timeline | null | not_planned | null | null | false | [
"Hi @dengshaochun, this is intended behavior. Requests will not forward potentially sensitive auth tokens to redirected hosts. This is to prevent leaking auth information to unintended endpoints. The best course of action in this case is to fix the URI provided to Requests to prevent redirection."
] |
https://api.github.com/repos/psf/requests/issues/6740 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6740/labels{/name} | https://api.github.com/repos/psf/requests/issues/6740/comments | https://api.github.com/repos/psf/requests/issues/6740/events | https://github.com/psf/requests/issues/6740 | 2,349,823,698 | I_kwDOABTKOs6MD3bS | 6,740 | Feature Request: `safe_json()` Method for Requests Library | {
"avatar_url": "https://avatars.githubusercontent.com/u/26590757?v=4",
"events_url": "https://api.github.com/users/nh916/events{/privacy}",
"followers_url": "https://api.github.com/users/nh916/followers",
"following_url": "https://api.github.com/users/nh916/following{/other_user}",
"gists_url": "https://api.github.com/users/nh916/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nh916",
"id": 26590757,
"login": "nh916",
"node_id": "MDQ6VXNlcjI2NTkwNzU3",
"organizations_url": "https://api.github.com/users/nh916/orgs",
"received_events_url": "https://api.github.com/users/nh916/received_events",
"repos_url": "https://api.github.com/users/nh916/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nh916/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nh916/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nh916",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156041422,
"name": "actions/autoclose-feat",
"node_id": "LA_kwDOABTKOs8AAAABbu28zg",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-feat"
}
] | closed | true | null | [] | null | 1 | 2024-06-12T23:14:29Z | 2024-06-12T23:14:39Z | 2024-06-12T23:14:38Z | NONE | off-topic | # Description
I would like to propose the addition of a `safe_json()` method to the `requests.Response` object. This method would attempt to return the response content as JSON if it is JSON. If the response content is not JSON, it would return the text content. If the response content is neither JSON nor text, it would return `None`.
## Rationale
When working with HTTP responses, it is common to handle different content types. A response might contain JSON, plain text, or even be empty. Currently, developers have to manually write error handling to safely parse JSON responses while falling back to text if JSON parsing fails. This can lead to repetitive boilerplate code and potential bugs.
```python
try:
content = response.json()
except ValueError:
content = response.text if response.text else None
```
A `safe_json()` method would streamline this process, providing a convenient and reliable way to handle different response content types. This would enhance the usability of the `requests` library and improve developer productivity.
## Proposed Solution
```python
from typing import Any, Union, Optional
class Response:
# Existing methods...
def safe_json(self) -> Optional[Union[dict, list, str]]:
"""
Attempt to parse the response content as JSON.
Returns:
Optional[Union[dict, list, str]]: The parsed JSON content if the response is JSON.
The text content if the response is not JSON.
None if the response content is neither JSON nor text.
"""
try:
return self.json()
except ValueError:
if self.text:
return self.text
return None
```
## Possible Benefits:
- Reduction in boilerplate code for error handling when parsing JSON.
- Provides a clear and consistent way to handle different types of response content.
- Improves code readability and maintainability.
Thank you for considering this feature request | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6740/reactions"
} | https://api.github.com/repos/psf/requests/issues/6740/timeline | null | not_planned | null | null | false | [
"As described in the template, Requests is not accepting feature requests"
] |
https://api.github.com/repos/psf/requests/issues/6739 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6739/labels{/name} | https://api.github.com/repos/psf/requests/issues/6739/comments | https://api.github.com/repos/psf/requests/issues/6739/events | https://github.com/psf/requests/pull/6739 | 2,349,669,081 | PR_kwDOABTKOs5ySSDF | 6,739 | Update setup.py in order to fix CVE-2023-37920 | {
"avatar_url": "https://avatars.githubusercontent.com/u/727563?v=4",
"events_url": "https://api.github.com/users/pablospe/events{/privacy}",
"followers_url": "https://api.github.com/users/pablospe/followers",
"following_url": "https://api.github.com/users/pablospe/following{/other_user}",
"gists_url": "https://api.github.com/users/pablospe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pablospe",
"id": 727563,
"login": "pablospe",
"node_id": "MDQ6VXNlcjcyNzU2Mw==",
"organizations_url": "https://api.github.com/users/pablospe/orgs",
"received_events_url": "https://api.github.com/users/pablospe/received_events",
"repos_url": "https://api.github.com/users/pablospe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pablospe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablospe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pablospe",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-06-12T20:56:55Z | 2024-06-12T20:59:37Z | 2024-06-12T20:59:37Z | NONE | null | CVE-2023-37920 link:
https://nvd.nist.gov/vuln/detail/CVE-2023-37920
Certifi is a curated collection of Root Certificates for validating the trustworthiness of SSL certificates while verifying the identity of TLS hosts. Certifi prior to version 2023.07.22 recognizes "e-Tugra" root certificates. e-Tugra's root certificates were subject to an investigation prompted by reporting of security issues in their systems. Certifi 2023.07.22 removes root certificates from "e-Tugra" from the root store. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6739/reactions"
} | https://api.github.com/repos/psf/requests/issues/6739/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6739.diff",
"html_url": "https://github.com/psf/requests/pull/6739",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6739.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6739"
} | true | [
"Hi @pablospe, please check open and closed issues/PRs before filing new ones. You can see our previous response [here](https://github.com/psf/requests/pull/6494#issuecomment-1668101497)."
] |
https://api.github.com/repos/psf/requests/issues/6738 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6738/labels{/name} | https://api.github.com/repos/psf/requests/issues/6738/comments | https://api.github.com/repos/psf/requests/issues/6738/events | https://github.com/psf/requests/issues/6738 | 2,347,707,641 | I_kwDOABTKOs6L7yz5 | 6,738 | requests.utils. atomic_open does not respect umask | {
"avatar_url": "https://avatars.githubusercontent.com/u/8947557?v=4",
"events_url": "https://api.github.com/users/austinzh/events{/privacy}",
"followers_url": "https://api.github.com/users/austinzh/followers",
"following_url": "https://api.github.com/users/austinzh/following{/other_user}",
"gists_url": "https://api.github.com/users/austinzh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/austinzh",
"id": 8947557,
"login": "austinzh",
"node_id": "MDQ6VXNlcjg5NDc1NTc=",
"organizations_url": "https://api.github.com/users/austinzh/orgs",
"received_events_url": "https://api.github.com/users/austinzh/received_events",
"repos_url": "https://api.github.com/users/austinzh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/austinzh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/austinzh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/austinzh",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
}
] | open | false | null | [] | null | 2 | 2024-06-12T03:13:01Z | 2024-09-01T17:03:25Z | null | NONE | null | Create a new file using requests.utils. atomic_open with umask set to 0o000
## Expected Result
0o777
## Actual Result
0o600
## Reproduction Steps
```python
import os
import requests.utils
os.umask(0o000)
with requests.utils.atomic_open('example.txt') as f:
f.write(b'Hello, world!')
file_stat = os.stat('example.txt')
print(oct(file_stat.st_mode & 0o777))
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.10.6"
},
"platform": {
"release": "6.2.0-1016-aws",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30000020"
},
"urllib3": {
"version": "2.2.1"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6738/reactions"
} | https://api.github.com/repos/psf/requests/issues/6738/timeline | null | null | null | null | false | [
"atomic_open is not intended for public consumption. Even still, the sole purpose of it in requests is to extract a CA truststore file from a zip (where necessary) and place it in a given location. In that case, regardless of what one might expect from umask, it's for the user's protection (and this desirable) that a file only be readable and writable by them to avoid someone corrupting the store and introducing an opportunity for a MitM attack by injecting an untrusted root. \n\nFurther still, requests itself does not change the permissions on the file (although now that you raise this I believe it should for the reasons I mentioned above) and I suspect the bug is actually in one of the standard library functions we use to implement this atomic open function, not requests. ",
"I've been working on the issue with requests.utils.atomic_open not respecting the umask settings, and I've tried a few different approaches to fix it. Here’s what I’ve done so far and what I’ve found:\r\n\r\n### What I Tried\r\n\r\n1. **Original Approach:**\r\n Initially, I used tempfile.mkstemp to create a temporary file, and then replaced it with the target file. However, the file permissions still ended up being the default settings due to umask.\r\n\r\n2. **Adjusting Permissions:**\r\n Added `os.chmod(tmp_name, desired_permissions)` before and after replacing the file to explicitly set permissions on the temporary file. This approach still resulted in the final file having default `umask` permissions (e.g., `0o666`), rather than the desired permissions (e.g., `0o777`).\r\n\r\n3. **Double `os.chmod` Call:**\r\n Modified the function to include a second `os.chmod` call after replacing the temporary file with the target file. This approach also failed to achieve the desired permissions, consistently resulting in default permissions.\r\n\r\n### Observations\r\n\r\n- The permissions of the final file consistently reflect the default `umask` settings (e.g., `0o666`) rather than the intended settings (e.g., `0o777`).\r\n- The issue seems to be related to how `umask` is applied or handled during file creation and replacement.\r\n\r\n```python\r\n@contextlib.contextmanager\r\ndef atomic_open(filename):\r\n # Create a temporary file with default permissions\r\n tmp_descriptor, tmp_name = tempfile.mkstemp(dir=os.path.dirname(filename))\r\n try:\r\n with os.fdopen(tmp_descriptor, \"wb\") as tmp_handler:\r\n yield tmp_handler\r\n\r\n # Get the current umask and restore it after setting desired permissions\r\n current_umask = os.umask(0)\r\n os.umask(current_umask)\r\n desired_permissions = 0o777 & ~current_umask\r\n\r\n # Set permissions of the temporary file\r\n os.chmod(tmp_name, desired_permissions)\r\n\r\n # Replace the target file with the temporary file\r\n os.replace(tmp_name, filename)\r\n\r\n # Ensure the final file has the correct permissions\r\n os.chmod(filename, desired_permissions)\r\n \r\n # Verify and print permissions of the replaced file\r\n file_stat = os.stat(filename)\r\n print(f\"Desired permissions: {oct(desired_permissions)}\")\r\n print(f\"Actual permissions after replacement: {oct(file_stat.st_mode & 0o777)}\")\r\n\r\n except Exception as e:\r\n # Clean up the temporary file if an exception occurs\r\n os.remove(tmp_name)\r\n raise e\r\n```\r\n\r\n\r\nThank you for your attention to this matter. Any insights or suggestions would be greatly appreciated.\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6737 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6737/labels{/name} | https://api.github.com/repos/psf/requests/issues/6737/comments | https://api.github.com/repos/psf/requests/issues/6737/events | https://github.com/psf/requests/issues/6737 | 2,346,884,750 | I_kwDOABTKOs6L4p6O | 6,737 | GET请求，我希望传递% 但是requests会默认帮我编码为%25，如何解决？ | {
"avatar_url": "https://avatars.githubusercontent.com/u/59187344?v=4",
"events_url": "https://api.github.com/users/chenanu123/events{/privacy}",
"followers_url": "https://api.github.com/users/chenanu123/followers",
"following_url": "https://api.github.com/users/chenanu123/following{/other_user}",
"gists_url": "https://api.github.com/users/chenanu123/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/chenanu123",
"id": 59187344,
"login": "chenanu123",
"node_id": "MDQ6VXNlcjU5MTg3MzQ0",
"organizations_url": "https://api.github.com/users/chenanu123/orgs",
"received_events_url": "https://api.github.com/users/chenanu123/received_events",
"repos_url": "https://api.github.com/users/chenanu123/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/chenanu123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chenanu123/subscriptions",
"type": "User",
"url": "https://api.github.com/users/chenanu123",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-06-11T16:56:06Z | 2024-06-11T16:56:20Z | 2024-06-11T16:56:19Z | NONE | off-topic | Please refer to our [Stack Overflow tag](https://stackoverflow.com/questions/tagged/python-requests) for guidance.
GET请求，我希望传递% 但是requests会默认帮我编码为%25，如何解决？ | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6737/reactions"
} | https://api.github.com/repos/psf/requests/issues/6737/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6736 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6736/labels{/name} | https://api.github.com/repos/psf/requests/issues/6736/comments | https://api.github.com/repos/psf/requests/issues/6736/events | https://github.com/psf/requests/issues/6736 | 2,340,204,437 | I_kwDOABTKOs6LfK-V | 6,736 | 2.32.3 does not load system CA certificates when using an Adapter | {
"avatar_url": "https://avatars.githubusercontent.com/u/730811?v=4",
"events_url": "https://api.github.com/users/WhyNotHugo/events{/privacy}",
"followers_url": "https://api.github.com/users/WhyNotHugo/followers",
"following_url": "https://api.github.com/users/WhyNotHugo/following{/other_user}",
"gists_url": "https://api.github.com/users/WhyNotHugo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/WhyNotHugo",
"id": 730811,
"login": "WhyNotHugo",
"node_id": "MDQ6VXNlcjczMDgxMQ==",
"organizations_url": "https://api.github.com/users/WhyNotHugo/orgs",
"received_events_url": "https://api.github.com/users/WhyNotHugo/received_events",
"repos_url": "https://api.github.com/users/WhyNotHugo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/WhyNotHugo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/WhyNotHugo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/WhyNotHugo",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 5 | 2024-06-07T11:08:47Z | 2024-07-04T15:17:27Z | 2024-06-07T16:04:37Z | CONTRIBUTOR | null | <!-- Summary. -->
Given this snippet:
```py
from requests.adapters import HTTPAdapter
from requests import Session
from urllib3 import PoolManager
from urllib3 import ProxyManager
from urllib3.util.ssl_ import create_urllib3_context
class AFIPAdapter(HTTPAdapter):
"""An adapter with reduced security so it'll work with AFIP."""
def init_poolmanager(self, *args, **kwargs) -> PoolManager:
context = create_urllib3_context(ciphers="AES128-SHA")
# context.load_default_certs()
kwargs["ssl_context"] = context
return super().init_poolmanager(*args, **kwargs)
def proxy_manager_for(self, *args, **kwargs) -> ProxyManager:
context = create_urllib3_context(ciphers="AES128-SHA")
# context.load_default_certs()
kwargs["ssl_context"] = context
return super().proxy_manager_for(*args, **kwargs)
session = Session()
session.mount("https://servicios1.afip.gov.ar", AFIPAdapter())
session.get("https://servicios1.afip.gov.ar/wsfev1/service.asmx?WSDL")
```
On `requests==2.31.0`, this works fine (e.g.: system CAs are loaded by default).
As of `2.32.2`, the system CAs are no longer loaded by default, and the commented `context.load_default_certs()` lines need to be included too.
## Expected Result
Above snippet should work; system CAs should be loaded.
## Actual Result
Above snippet fails with:
```
requests.exceptions.SSLError: HTTPSConnectionPool(host='servicios1.afip.gov.ar', port=443): Max retries exceeded with url: /wsfev1/service.asmx?WSDL (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1000)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": "39.0.2"
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.12.3"
},
"platform": {
"release": "6.9.3-0-edge",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30000080",
"version": "23.2.0"
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30300000"
},
"urllib3": {
"version": "2.2.1"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
## Further context
https://github.com/psf/requests/pull/6710#issuecomment-2137799723
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6736/reactions"
} | https://api.github.com/repos/psf/requests/issues/6736/timeline | null | completed | null | null | false | [
"Hi @WhyNotHugo, I think this is a duplicate of #6730 which was opened after your original comment. We'll track progress there.",
"Sorry, forgot to double-check.",
"@WhyNotHugo did you solve it ? I'm struggling with the same\r\n\r\n```\r\nurllib3 = \"^1.26.14\"\r\nfintech = \"^7.5.1\"\r\npyopenssl = \"^22.0.0\"\r\ncryptography = \"^35.0.0\"\r\n```\r\n\r\nsince I updated cryptography",
"@alesisjoan Either use dependency `\"requests!=2.32.0,!=2.32.1,!=2.32.2\",` or explicitly load default certs: https://github.com/WhyNotHugo/django-afip/blob/8ea6dbd79d9cfe52409d9bbf3d61069ea8efbdb0/django_afip/clients.py#L44-L57",
"Hi Hugo!\r\nYep, it was something with requests library.\r\n\r\nIn my case it was using 2.32 so I force a downgrade to 2.25.1\r\n\r\nMuchas gracias!\r\n\r\nEl mié., 3 de julio de 2024 12:09, Hugo ***@***.***> escribió:\r\n\r\n> @alesisjoan <https://github.com/alesisjoan> Either use dependency\r\n> \"requests!=2.32.0,!=2.32.1,!=2.32.2\", or explicitly load default certs:\r\n> https://github.com/WhyNotHugo/django-afip/blob/8ea6dbd79d9cfe52409d9bbf3d61069ea8efbdb0/django_afip/clients.py#L44-L57\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/psf/requests/issues/6736#issuecomment-2206473797>, or\r\n> unsubscribe\r\n> <https://github.com/notifications/unsubscribe-auth/ABFXOPDLYUMY5EZOR2NEJSDZKQH2JAVCNFSM6AAAAABI6OTL66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWGQ3TGNZZG4>\r\n> .\r\n> You are receiving this because you were mentioned.Message ID:\r\n> ***@***.***>\r\n>\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6735 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6735/labels{/name} | https://api.github.com/repos/psf/requests/issues/6735/comments | https://api.github.com/repos/psf/requests/issues/6735/events | https://github.com/psf/requests/issues/6735 | 2,338,910,221 | I_kwDOABTKOs6LaPAN | 6,735 | requests 2.32.3 with IPv6 link local address fails with error: [Errno -2] Name or service not known | {
"avatar_url": "https://avatars.githubusercontent.com/u/171971141?v=4",
"events_url": "https://api.github.com/users/pytech66/events{/privacy}",
"followers_url": "https://api.github.com/users/pytech66/followers",
"following_url": "https://api.github.com/users/pytech66/following{/other_user}",
"gists_url": "https://api.github.com/users/pytech66/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pytech66",
"id": 171971141,
"login": "pytech66",
"node_id": "U_kgDOCkASRQ",
"organizations_url": "https://api.github.com/users/pytech66/orgs",
"received_events_url": "https://api.github.com/users/pytech66/received_events",
"repos_url": "https://api.github.com/users/pytech66/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pytech66/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pytech66/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pytech66",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 1 | 2024-06-06T18:29:52Z | 2024-06-27T08:52:20Z | null | NONE | null | When using an IPv6 link local address with requests > v2.31.0, seeing an error `[Errno -2] Name or service not known`. The same works with requests 2.31.0.
urllib3 2.2.1 also works successfully with IPv6 link local address .
### urllib3 2.2.1 with IPv6 link local address
```
>>> import urllib3
>>> http = urllib3.PoolManager(cert_reqs='CERT_NONE')
>>> res = http.request("GET", "https://[fe80::5eed:8cff:fe00:0da4%ens192]/redfish/v1")
/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:1103: InsecureRequestWarning: Unverified HTTPS request is being made to host 'fe80::5eed:8cff:fe00:0da4%ens192'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings
warnings.warn(
>>> res.status
200
```
### requests 2.31.0 with IPv6 link local address
```
>>> import requests
>>> res = requests.get("https://[fe80::5eed:8cff:fe00:0da4%ens192]/redfish/v1", verify=False)
>>> res.status_code
200
```
## Expected Result
Successful connection with versions 2.32.x
## Actual Result
```
>>> import requests
>>> res = requests.get("https://[fe80::5eed:8cff:fe00:0da4%ens192]/redfish/v1", verify=False)
Traceback (most recent call last):
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connection.py", line 198, in _new_conn
sock = connection.create_connection(
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/util/connection.py", line 60, in create_connection
for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
File "/usr/lib/python3.10/socket.py", line 955, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 793, in urlopen
response = self._make_request(
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 491, in _make_request
raise new_e
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 467, in _make_request
self._validate_conn(conn)
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 1099, in _validate_conn
conn.connect()
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connection.py", line 616, in connect
self.sock = sock = self._new_conn()
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connection.py", line 205, in _new_conn
raise NameResolutionError(self.host, self, e) from e
urllib3.exceptions.NameResolutionError: <urllib3.connection.HTTPSConnection object at 0x716b63d403d0>: Failed to resolve 'fe80::5eed:8cf00:0da4%25ens192' ([Errno -2] Name or service not known)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/root/new-requests/venv/lib/python3.10/site-packages/requests/adapters.py", line 667, in send
resp = conn.urlopen(
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 847, in urlopen
retries = retries.increment(
File "/root/new-requests/venv/lib/python3.10/site-packages/urllib3/util/retry.py", line 515, in increment
raise MaxRetryError(_pool, url, reason) from reason # type: ignore[arg-type]
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='fe80::5eed:8cff:fe00:0da4%25ens192', port=443): Max retries exceeded with urredfish/v1 (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x716b63d403d0>: Failed to resolve 'fe80::5eed::fe00:0da4%25ens192' ([Errno -2] Name or service not known)"))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/root/new-requests/venv/lib/python3.10/site-packages/requests/api.py", line 73, in get
return request("get", url, params=params, **kwargs)
File "/root/new-requests/venv/lib/python3.10/site-packages/requests/api.py", line 59, in request
return session.request(method=method, url=url, **kwargs)
File "/root/new-requests/venv/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
File "/root/new-requests/venv/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
r = adapter.send(request, **kwargs)
File "/root/new-requests/venv/lib/python3.10/site-packages/requests/adapters.py", line 700, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='fe80::5eed:8cff:fe00:0da4%25ens192', port=443): Max retries exceeded with: /redfish/v1 (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x716b63d403d0>: Failed to resolve 'fe80::5ecff:fe00:0da4%25ens192' ([Errno -2] Name or service not known)"))
```
## Reproduction Steps
```python
import requests
res = requests.get("https://[fe80::5eed:8cff:fe00:0da4%ens192]/redfish/v1", verify=False)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.10.12"
},
"platform": {
"release": "6.5.0-27-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30000020"
},
"urllib3": {
"version": "2.2.1"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6735/reactions"
} | https://api.github.com/repos/psf/requests/issues/6735/timeline | null | null | null | null | false | [
"I worked around the bug with:\r\n```\r\n# Workaround for bug in requests 2.32.x: https://github.com/psf/requests/issues/6735\r\ndef requests_workaround(method, url, json, headers, auth, verify=False):\r\n # Create a session\r\n session=requests.Session()\r\n\r\n # Prepare the request\r\n request=requests.Request(method, url, json=json, headers=headers, auth=auth)\r\n prepared_request=session.prepare_request(request)\r\n prepared_request.url=prepared_request.url.replace('%25', '%')\r\n return session.send(prepared_request, verify=verify)\r\n\r\ndef requests_workaround_put(url, json, headers, auth, verify=False):\r\n return requests_workaround('PUT', url, json, headers, auth, verify=False)\r\n\r\ndef requests_workaround_delete(url, headers, auth, verify=False):\r\n return requests_workaround('DELETE', url, None, headers, auth, verify=False)\r\n\r\ndef requests_workaround_post(url, json, headers, auth, verify=False):\r\n return requests_workaround('POST', url, json, headers, auth, verify=False)\r\n\r\ndef requests_workaround_get(url, headers, auth, verify=False):\r\n return requests_workaround('GET', url, None, headers, auth, verify=False)\r\n```"
] |
https://api.github.com/repos/psf/requests/issues/6734 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6734/labels{/name} | https://api.github.com/repos/psf/requests/issues/6734/comments | https://api.github.com/repos/psf/requests/issues/6734/events | https://github.com/psf/requests/issues/6734 | 2,333,148,611 | I_kwDOABTKOs6LEQXD | 6,734 | requests 2.32.3 & urllib3 1.26.18 issue with unicode put | {
"avatar_url": "https://avatars.githubusercontent.com/u/5688939?v=4",
"events_url": "https://api.github.com/users/frenzymadness/events{/privacy}",
"followers_url": "https://api.github.com/users/frenzymadness/followers",
"following_url": "https://api.github.com/users/frenzymadness/following{/other_user}",
"gists_url": "https://api.github.com/users/frenzymadness/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/frenzymadness",
"id": 5688939,
"login": "frenzymadness",
"node_id": "MDQ6VXNlcjU2ODg5Mzk=",
"organizations_url": "https://api.github.com/users/frenzymadness/orgs",
"received_events_url": "https://api.github.com/users/frenzymadness/received_events",
"repos_url": "https://api.github.com/users/frenzymadness/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/frenzymadness/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/frenzymadness/subscriptions",
"type": "User",
"url": "https://api.github.com/users/frenzymadness",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 5 | 2024-06-04T10:23:23Z | 2024-07-02T01:23:12Z | null | CONTRIBUTOR | null | I'm building requests 2.32.3 in Fedora Linux and I have a problem with `test_unicode_header_name` - the test hangs.
It's reproducible - when I use urllib3 at least 2.0.2, the code works fine, with urllib3 1.26.18, it hangs waiting for a response.
## Expected Result
Older urllib3 is still allowed (`urllib3>=1.21.1,<3`) so it should work.
## Actual Result
The call to `requests.put` hangs and if killed, the stacktrace is:
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/lbalhar/Software/requests/src/requests/api.py", line 130, in put
return request("put", url, data=data, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/lbalhar/Software/requests/src/requests/api.py", line 59, in request
return session.request(method=method, url=url, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/lbalhar/Software/requests/src/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/lbalhar/Software/requests/src/requests/sessions.py", line 703, in send
r = adapter.send(request, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/lbalhar/Software/requests/src/requests/adapters.py", line 667, in send
resp = conn.urlopen(
^^^^^^^^^^^^^
File "/home/lbalhar/.virtualenvs/requests/lib/python3.12/site-packages/urllib3/connectionpool.py", line 715, in urlopen
httplib_response = self._make_request(
^^^^^^^^^^^^^^^^^^^
File "/home/lbalhar/.virtualenvs/requests/lib/python3.12/site-packages/urllib3/connectionpool.py", line 467, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/home/lbalhar/.virtualenvs/requests/lib/python3.12/site-packages/urllib3/connectionpool.py", line 462, in _make_request
httplib_response = conn.getresponse()
^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.12/http/client.py", line 1428, in getresponse
response.begin()
File "/usr/lib64/python3.12/http/client.py", line 331, in begin
version, status, reason = self._read_status()
^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.12/http/client.py", line 292, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.12/socket.py", line 707, in readinto
return self._sock.recv_into(b)
^^^^^^^^^^^^^^^^^^^^^^^
KeyboardInterrupt
```
## Reproduction Steps
Start httpbin instance, install urllib3<2 and then:
```python
import requests
requests.put("http://127.0.0.1:8080/put", headers={"Content-Type": "application/octet-stream"}, data="\xff")
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.12.3"
},
"platform": {
"release": "6.8.10-300.fc40.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30200010"
},
"urllib3": {
"version": "1.26.18"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
``` | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6734/reactions"
} | https://api.github.com/repos/psf/requests/issues/6734/timeline | null | null | null | null | false | [
"Thanks for reporting this, @frenzymadness! I'd thought we had a standalone GHA to still test on \"urllib3<2\" but that's for a separate project. I'll work on getting that added to ensure we don't have regressions.\r\n\r\nWe'll need to take a closer look at what's happening but I have a feeling this may be a byproduct of #6589. I'm wondering if we're sending a Content-Length 1 byte longer than what we're actually emitting. I was surprised when that issue was opened we hadn't had this problem before but there may be some subtle variance between the two major versions that was overlooked.",
"I took the code from the `test_content_length_for_string_data_counts_bytes` and it seems to work fine:\r\n\r\n```\r\n>>> import requests\r\n>>> data = \"This is a string containing multi-byte UTF-8 ☃\"\r\n>>> length = str(len(data.encode(\"utf-8\")))\r\n>>> req = requests.Request(\"POST\", \"http://foo.bar/post\", data=data)\r\n>>> p = req.prepare()\r\n>>> p.headers[\"Content-Length\"]\r\n'51'\r\n>>> length\r\n'51'\r\n```\r\n\r\nAnd for the data from `test_unicode_header_name`\r\n```\r\n>>> data = \"\\xff\"\r\n>>> length = str(len(data.encode(\"utf-8\")))\r\n>>> req = requests.Request(\"POST\", \"http://foo.bar/post\", data=data)\r\n>>> p = req.prepare()\r\n>>> p.headers[\"Content-Length\"]\r\n'2'\r\n>>> length\r\n'2'\r\n```",
"Hi all,\r\n\r\nI was also facing a similar issue like @frenzymadness, and I can confirm that it is caused by #6589. I'm not sure whether I should continue the conversation here or at #6589, but I'll start off here\r\n\r\n## Intro\r\n\r\nFirst off I want to mention that when you send the request\r\n```python\r\nrequests.put('https://httpbin.org/put', headers={'Content-Type': 'application/octet-stream'}, data='\\xff')\r\n```\r\nit doesn't actually hang, but is actually waiting for a response from the server, and after a while the code fails with\r\n```\r\nrequests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))\r\n```\r\n\r\nA similar thing occurred with the server I was communicating with but it it actually sent a response, something like\r\n```\r\n400: Your socket connection to the server was not read from or written to within the timeout period. Idle connections will be closed.\r\n```\r\n\r\nI was sending a `str` with non-ascii characters (same as @frenzymadness) and it turned out that the request had an incorrect `Content-Length` header, something like 545 instead of the correct 543.\r\n\r\n## Issue\r\n\r\nThe issue is that if you pass a `str` as the data of a request, when calculating the Content-Length in [super_len](https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/src/requests/utils.py#L140) you encode the string with `utf-8`, and later on when you get to the real encoding of the body in `python3.9/http/client.py` on line 1330 it actually uses `latin-1` (same as `iso-8859-1`).\r\n\r\nSo in the case of our simple example where we send `'\\xff'` we have the following\r\n```python\r\n>>> a = '\\xff'\r\n>>> len(a)\r\n1\r\n>>> len(a.encode('utf-8'))\r\n2\r\n>>> len(a.encode('latin-1'))\r\n1\r\n```\r\n\r\nSo we would be setting the Content-Length to 2 when we would actually be sending 1 byte of data.\r\n\r\nWhat I find interesting is that I don't think the tests created in #6589 serve a real purpose since if you sent a request like the following, your code would fail, and it wouldn't matter that our Content-Length is 'correct'\r\n```python\r\n>>> requests.put('https://httpbin.org/put', data='👍👎')\r\nTraceback (most recent call last):\r\n ...\r\nUnicodeEncodeError: 'latin-1' codec can't encode characters in position 0-1: Body ('👍👎') is not valid Latin-1. Use body.encode('utf-8') if you want to send it encoded in UTF-8.\r\n```\r\nSo the 'workaround' mentioned in #6586 is actually the way a request like this should be sent.\r\n\r\nSo with all that being said, I'd think the fix would be to just revert the commit that introduced this change.\r\n\r\nWhat do you think?",
"Just hit this myself when trying to release urllib3 1.26.19. urllib3 2.x made a change where string bodies are encoded as UTF-8 instead of Latin-1. It was an accidental change, and I've started working on fixing/documenting it in https://github.com/urllib3/urllib3/issues/3053 and https://github.com/urllib3/urllib3/pull/3063 but ultimately dropped the ball, sorry.\r\n\r\nThen, https://github.com/psf/requests/pull/6589 adapted requests to work with urllib3 2.x by encoding to UTF-8 to compute the Content-Length. Which means that with `\\xff`, requests now sets Content-Length to 2, but urllib3 1.26.x only sends one byte, which is why the test hangs. Since we're not planning to revert to Latin-1 in urllib3, the fix would be for requests to explicitly encode string bodies to UTF-8 (or not try to guess the Content-Lenght, I suppose). If it does, it would be nice to avoid encoding twice which is what happens today.",
"I'm kind of tempted to just add something in compat to flag the major version of urllib3 like PY2/PY3 in `six`. I don't think we can remove content-length computing since that would be a fairly breaking change for the library. Requests is still straddling the line of old internet where everything was latin-1 (and only latin-1), vs today where _most_ things behave with utf-8.\r\n\r\nI think we'll likely want to keep the change in some form. I don't know if any of the other maintainers have other thoughts on solutions. "
] |
https://api.github.com/repos/psf/requests/issues/6733 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6733/labels{/name} | https://api.github.com/repos/psf/requests/issues/6733/comments | https://api.github.com/repos/psf/requests/issues/6733/events | https://github.com/psf/requests/issues/6733 | 2,332,321,016 | I_kwDOABTKOs6LBGT4 | 6,733 | Deprecated `HTTPAdapter.get_connection()` method is never called, causing breakage without deprecation warnings | {
"avatar_url": "https://avatars.githubusercontent.com/u/626277?v=4",
"events_url": "https://api.github.com/users/wgreenberg/events{/privacy}",
"followers_url": "https://api.github.com/users/wgreenberg/followers",
"following_url": "https://api.github.com/users/wgreenberg/following{/other_user}",
"gists_url": "https://api.github.com/users/wgreenberg/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wgreenberg",
"id": 626277,
"login": "wgreenberg",
"node_id": "MDQ6VXNlcjYyNjI3Nw==",
"organizations_url": "https://api.github.com/users/wgreenberg/orgs",
"received_events_url": "https://api.github.com/users/wgreenberg/received_events",
"repos_url": "https://api.github.com/users/wgreenberg/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wgreenberg/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wgreenberg/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wgreenberg",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-06-04T01:04:34Z | 2024-06-06T15:56:32Z | 2024-06-06T15:56:32Z | NONE | null | After upgrading several of certbot's packages, including `requests` to 2.32.3, we suddenly started experiencing confusing DNS resolution errors with no clear cause. Only after bisecting the changed packages and isolating `requests` as the source of the trouble did we see that 2.32.2 deprecated the `HTTPAdapter.get_connection()` method we used.
Unfortunately, the change which deprecated `get_connection()` also causes it never to be called by `Session`, so the `DeprecationWarning` added in https://github.com/psf/requests/pull/6710 will never be printed. If `Session` perhaps checked if `get_connection()` was defined and called it, the warning would've printed and would've saved us quite a lot of time tracking down the issue.
I also generally wouldn't expect a minor version upgrade in a dependency to cause a breaking change, so this result was extra confusing.
## Expected Result
`HTTPAdapter.get_connection()` to still be called, resulting in no breaking changes and giving users the deprecation warning. Or at the very least, check if `get_connection` is defined and print the deprecation warning then.
## Actual Result
`HTTPAdapter.get_connection()` is silently left uncalled, causing a breakage. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6733/reactions"
} | https://api.github.com/repos/psf/requests/issues/6733/timeline | null | completed | null | null | false | [
"Hi @wgreenberg, the commit you linked appears to be part way through the issue. #6710 was to provide a public API for users who were overriding `get_connection`. The initial breakage came from #6655 to address CVE-2024-35195.\n\nWhile we don't generally make breaking changes in minor patch versions, users were unknowingly exposing data over unverified connections. We chose to patch the API but it appears docker and certbot are two cases that were negatively impacted.\n\nThere were a few misses in messaging around this change because impact wasn't assessed completely prior to releasing 2.32.0. The workaround provided in #6710 will be the backwards compatible middle ground to keep adapters using a custom `get_connection` working with the least amount of work going forward.",
"I'm going to resolve this since we haven't heard back anything else. Let us know if you have any other questions."
] |
https://api.github.com/repos/psf/requests/issues/6732 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6732/labels{/name} | https://api.github.com/repos/psf/requests/issues/6732/comments | https://api.github.com/repos/psf/requests/issues/6732/events | https://github.com/psf/requests/pull/6732 | 2,329,405,073 | PR_kwDOABTKOs5xNYpA | 6,732 | Rename lock-issues.yml to 90daylock-issues | {
"avatar_url": "https://avatars.githubusercontent.com/u/166753141?v=4",
"events_url": "https://api.github.com/users/Devante7/events{/privacy}",
"followers_url": "https://api.github.com/users/Devante7/followers",
"following_url": "https://api.github.com/users/Devante7/following{/other_user}",
"gists_url": "https://api.github.com/users/Devante7/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Devante7",
"id": 166753141,
"login": "Devante7",
"node_id": "U_kgDOCfBzdQ",
"organizations_url": "https://api.github.com/users/Devante7/orgs",
"received_events_url": "https://api.github.com/users/Devante7/received_events",
"repos_url": "https://api.github.com/users/Devante7/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Devante7/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Devante7/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Devante7",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-06-02T00:29:41Z | 2024-06-02T00:50:37Z | 2024-06-02T00:50:37Z | NONE | null | d31a23b10d2c721f9ddab7baaafd5869406b1f83 | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6732/reactions"
} | https://api.github.com/repos/psf/requests/issues/6732/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6732.diff",
"html_url": "https://github.com/psf/requests/pull/6732",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6732.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6732"
} | true | [
"Thanks for the PR, @Devante7. It doesn't look like this is a necessary change though. The title is clear on the workflow intention and the specific values are available in the file. Having to rename the file every time a value changes would be unintuitive/disruptive."
] |
https://api.github.com/repos/psf/requests/issues/6731 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6731/labels{/name} | https://api.github.com/repos/psf/requests/issues/6731/comments | https://api.github.com/repos/psf/requests/issues/6731/events | https://github.com/psf/requests/pull/6731 | 2,328,435,863 | PR_kwDOABTKOs5xKLfz | 6,731 | Address certificate loading regression | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 5 | 2024-05-31T19:05:10Z | 2024-10-31T12:25:06Z | null | MEMBER | null | ## Overview
This PR is intended to address two distinct issues introduced with the default cert optimizations originally introduced in 2.32.0. While we continue to refine the settings considered when opting into our optimized context, we'll no longer use the new default if any custom cert values are supplied. This addresses the concurrency issues raised in #6726.
The second piece of this will be ensuring that when opting out of the default SSLContext, we're still supplying to the default CA Cert bundle correctly. This addresses the problems noticed in https://github.com/psf/requests/pull/6710#issuecomment-2137802782 and #6730.
## Considerations
We're now duplicating a decent chunk of the [logic from cert_verify](https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/src/requests/adapters.py#L324-L357) inside [_urllib3_request_context](https://github.com/psf/requests/blob/0e322af87745eff34caffe4df68456ebc20d9068/src/requests/adapters.py#L115-L128) but without our validation exceptions. That's a potential vector for behavioral shifts in the future. We _could_ consolidate some of this behavior in one place but it's going to require constructing a dict and using `setattr` on our `conn` in `cert_verify` while setting `pool_kwargs` in `_urllib3_request_context`. I started writing that up but it feels clunky. This is probably going to be a tradeoff of risking drift like we have with Session settings and binding the two behaviors together too tightly.
## Testing
I'd like to codify the issues we've encountered through the whole 2.32.x saga in tests to hopefully avoid this in the future. Doing it cleanly without relying on external endpoints is proving to be a bit more involved than I'd like. I think we can harness some of the infrastructure added in #6662, but I haven't had a chance to really dig into that. | null | {
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 2,
"total_count": 4,
"url": "https://api.github.com/repos/psf/requests/issues/6731/reactions"
} | https://api.github.com/repos/psf/requests/issues/6731/timeline | null | null | true | {
"diff_url": "https://github.com/psf/requests/pull/6731.diff",
"html_url": "https://github.com/psf/requests/pull/6731",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6731.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6731"
} | true | [
"Is there an ETA for this change or a similar change? 2.32.3 doesn't work for us, as it broke our usage of `requests_pkcs12`. It looks like that package was updated with a temporary change [here](https://github.com/m-click/requests_pkcs12/issues/55#issuecomment-2154946453), so if a \"proper\" fix is not intended to be released anytime soon then we can try that. However I'd be keen to take a proper fix for both if that's expected soon!",
"The regression is there for some time and the PR is still in draft. Is there some way to move this forward?",
"Maintainers, is there any update here? The latest version of HTTPie is mostly non-functional due to this issue, and we will need to drop it and migrate to other tools if this cannot be addressed.\r\n\r\nThere does not seem to be any blocking feedback on this PR - can any clarity be provided about what is currently preventing a merge? Is additional contribution required from the community?",
"A friendly reminder that this issue has been stagnant for 4 months already.",
"Hi @sigmavirus24 you're listed as reviewer for this. Would you like to review this or assign someone else to do so?"
] |
https://api.github.com/repos/psf/requests/issues/6730 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6730/labels{/name} | https://api.github.com/repos/psf/requests/issues/6730/comments | https://api.github.com/repos/psf/requests/issues/6730/events | https://github.com/psf/requests/issues/6730 | 2,327,497,338 | I_kwDOABTKOs6Kusp6 | 6,730 | Certificate loading regression with HTTPAdapters in 2.32.3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/10698320?v=4",
"events_url": "https://api.github.com/users/ricellis/events{/privacy}",
"followers_url": "https://api.github.com/users/ricellis/followers",
"following_url": "https://api.github.com/users/ricellis/following{/other_user}",
"gists_url": "https://api.github.com/users/ricellis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ricellis",
"id": 10698320,
"login": "ricellis",
"node_id": "MDQ6VXNlcjEwNjk4MzIw",
"organizations_url": "https://api.github.com/users/ricellis/orgs",
"received_events_url": "https://api.github.com/users/ricellis/received_events",
"repos_url": "https://api.github.com/users/ricellis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ricellis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ricellis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ricellis",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 3 | 2024-05-31T10:26:46Z | 2024-07-12T22:11:56Z | null | NONE | null | <!-- Summary. -->
It appears that in version `2.32.3` default certificates are no longer loaded for custom `HTTPAdapter` contexts when they were previously.
I guess this might be a duplicate/related to https://github.com/psf/requests/issues/6726#issuecomment-2138406456.
Also related to https://github.com/psf/requests/pull/6710#issuecomment-2137802782 - adding `load_default_certs()` resolves the issue, but this wasn't required in previous versions and thus makes upgrading to `2.32.3` breaking.
## Expected Result
<!-- What you expected. -->
With the code below using `requests` version `2.32.2` I get the URL content with no error.
## Actual Result
<!-- What happened instead. -->
Using `2.32.3` I get:
```
requests.exceptions.SSLError: HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /psf/requests/main/MANIFEST.in (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1006)')))
```
## Reproduction Steps
```python
import requests
import ssl
from requests.adapters import HTTPAdapter, DEFAULT_POOLBLOCK
from urllib3.util.ssl_ import create_urllib3_context
# adapted from https://github.com/IBM/python-sdk-core/blob/1c207385de627df5d12fd0a0ebd04717ce5bb29d/ibm_cloud_sdk_core/utils.py#L34
class SSLHTTPAdapter(HTTPAdapter):
"""Wraps the original HTTP adapter and adds additional SSL context."""
def init_poolmanager(self, connections, maxsize, block=DEFAULT_POOLBLOCK, **pool_kwargs):
"""Create and use custom SSL configuration."""
ssl_context = create_urllib3_context()
ssl_context.minimum_version = ssl.TLSVersion.TLSv1_2
# ssl_context.load_default_certs() # Adding this resolves the certificate issue but it was not required before
super().init_poolmanager(connections, maxsize, block, ssl_context=ssl_context, **pool_kwargs)
session = requests.Session()
http_adapter = SSLHTTPAdapter()
session.mount('https://', http_adapter)
print(session.get(url='https://raw.githubusercontent.com/psf/requests/main/MANIFEST.in').text)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.2.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.9"
},
"platform": {
"release": "23.5.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30300000"
},
"urllib3": {
"version": "2.2.1"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| null | {
"+1": 14,
"-1": 0,
"confused": 0,
"eyes": 1,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 15,
"url": "https://api.github.com/repos/psf/requests/issues/6730/reactions"
} | https://api.github.com/repos/psf/requests/issues/6730/timeline | null | null | null | null | false | [
"This issue appears to be leading to widespread breakage. Have you considered yanking the release? It's personally cost me a good deal of time troubleshooting, distilling, and reporting the issue in httpie/cli#1581, to the point that users are suggesting to move away from requests (feels drastic, admittedly). Would the maintainers at least consider acknowledging the issue and giving some insight into the plan?",
"Hi @jaraco, we have a PR with the fix up already. We've been evaluating if there are any other breakages because this series of releases has been problematic.\n\nApplying the patch or downgrading is the immediate fix. The reason it's not yanked is because this was part of a change for a CVE fix in 2.32.x.",
"> we have a PR with the fix up already.\r\n\r\nFor those who are wondering, here it is:\r\n - #6731"
] |
https://api.github.com/repos/psf/requests/issues/6729 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6729/labels{/name} | https://api.github.com/repos/psf/requests/issues/6729/comments | https://api.github.com/repos/psf/requests/issues/6729/events | https://github.com/psf/requests/issues/6729 | 2,327,036,159 | I_kwDOABTKOs6Ks8D_ | 6,729 | ssl certificate validation of requests was ignored but the ssl certificate still reported an error | {
"avatar_url": "https://avatars.githubusercontent.com/u/64049774?v=4",
"events_url": "https://api.github.com/users/expzhizhuo/events{/privacy}",
"followers_url": "https://api.github.com/users/expzhizhuo/followers",
"following_url": "https://api.github.com/users/expzhizhuo/following{/other_user}",
"gists_url": "https://api.github.com/users/expzhizhuo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/expzhizhuo",
"id": 64049774,
"login": "expzhizhuo",
"node_id": "MDQ6VXNlcjY0MDQ5Nzc0",
"organizations_url": "https://api.github.com/users/expzhizhuo/orgs",
"received_events_url": "https://api.github.com/users/expzhizhuo/received_events",
"repos_url": "https://api.github.com/users/expzhizhuo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/expzhizhuo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/expzhizhuo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/expzhizhuo",
"user_view_type": "public"
} | [
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 2 | 2024-05-31T06:09:53Z | 2024-05-31T11:16:29Z | 2024-05-31T11:16:00Z | NONE | off-topic | <!-- Summary. -->
## Expected Result
Testing on different operating systems, I found it was Caused by SSLError(SSLError(1, '[SSL:) caused by SSLerror (SSLError(1, '[SSL:) SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:1006)')) error, but I did not have a validation problem during one of the validations
Testing on my mac air m2 machine produced the above error, but my demonstration in kali did not have this problem
But I tested it with the default python version on ubuntu 22.04 and got the same error message as on my mac
## Actual Result
```
requests.exceptions.SSLError: HTTPSConnectionPool(host='183.237.161.98', port=4433): Max retries exceeded with url: /favicon.ico (Caused by SSLError(SSLError(1, '[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:1006)')))
```
## Reproduction Steps
```python
import requests
response = requests.get(url="https://183.237.161.98:4433/favicon.ico", verify=False, allow_redirects=False)
```
## System Information
$ python -m requests.help
```json
zhizhuo@macbook ~ % python3 -m requests.help
{
"chardet": {
"version": "5.0.0"
},
"charset_normalizer": {
"version": "2.0.12"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "3.9.17"
},
"platform": {
"release": "23.4.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "30100020"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
```json
└─# python3 -m requests.help
/usr/lib/python3/dist-packages/requests/help.py:24: DeprecationWarning: 'urllib3.contrib.pyopenssl' module is deprecated and will be removed in a future release of urllib3 2.x. Read more in this issue: https://github.com/urllib3/urllib3/issues/2680
from urllib3.contrib import pyopenssl
{
"chardet": {
"version": "5.1.0"
},
"charset_normalizer": {
"version": "3.0.1"
},
"cryptography": {
"version": "38.0.4"
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.11.2"
},
"platform": {
"release": "6.1.0-kali7-arm64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30000080",
"version": "23.0.0"
},
"requests": {
"version": "2.28.1"
},
"system_ssl": {
"version": "30000080"
},
"urllib3": {
"version": "1.26.12"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
```
```json
zhizhuo@zhizhuo:~$ python3 -m requests.help
{
"chardet": {
"version": "4.0.0"
},
"cryptography": {
"version": "3.4.8"
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.10.12"
},
"platform": {
"release": "5.15.0-97-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30000020",
"version": "21.0.0"
},
"requests": {
"version": "2.25.1"
},
"system_ssl": {
"version": "30000020"
},
"urllib3": {
"version": "1.26.5"
},
"using_pyopenssl": true
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6729/reactions"
} | https://api.github.com/repos/psf/requests/issues/6729/timeline | null | completed | null | null | false | [
"Duplicate of #6728 ",
"Please copy and paste text, do not use screenshots as they are:\r\n\r\n* Not searchable\r\n* Not accessible to those who need to rely on screen readers or have issues with their vision\r\n\r\n---\r\n\r\nAs to your actual error, just because you disable TLS Verification, does not mean that the rest of how TLS works is disabled. The client and server still need to agree upon cipher suites, TLS versions, etc. The server does not appear to support a TLS version that we also support.\r\n\r\nYou can verify this with `openssl s_client` which is well documented and has many examples online."
] |
https://api.github.com/repos/psf/requests/issues/6728 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6728/labels{/name} | https://api.github.com/repos/psf/requests/issues/6728/comments | https://api.github.com/repos/psf/requests/issues/6728/events | https://github.com/psf/requests/issues/6728 | 2,327,024,964 | I_kwDOABTKOs6Ks5VE | 6,728 | ssl certificate validation of requests was ignored but the ssl certificate still reported an error | {
"avatar_url": "https://avatars.githubusercontent.com/u/64049774?v=4",
"events_url": "https://api.github.com/users/expzhizhuo/events{/privacy}",
"followers_url": "https://api.github.com/users/expzhizhuo/followers",
"following_url": "https://api.github.com/users/expzhizhuo/following{/other_user}",
"gists_url": "https://api.github.com/users/expzhizhuo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/expzhizhuo",
"id": 64049774,
"login": "expzhizhuo",
"node_id": "MDQ6VXNlcjY0MDQ5Nzc0",
"organizations_url": "https://api.github.com/users/expzhizhuo/orgs",
"received_events_url": "https://api.github.com/users/expzhizhuo/received_events",
"repos_url": "https://api.github.com/users/expzhizhuo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/expzhizhuo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/expzhizhuo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/expzhizhuo",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | true | null | [] | null | 1 | 2024-05-31T06:00:18Z | 2024-05-31T06:00:29Z | 2024-05-31T06:00:28Z | NONE | off-topic | ## Problem recurrence
Please refer to our [Stack Overflow tag](https://stackoverflow.com/questions/tagged/python-requests) for guidance.
Testing on different operating systems, I found it was Caused by SSLError(SSLError(1, '[SSL:) caused by SSLerror (SSLError(1, '[SSL:) SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:1006)')) error, but I did not have a validation problem during one of the validations
<img width="1047" alt="image" src="https://github.com/psf/requests/assets/64049774/704c0306-c304-41c5-8805-7e068fd14000">
Testing on my mac air m2 machine produced the above error, but my demonstration in kali did not have this problem
<img width="848" alt="image" src="https://github.com/psf/requests/assets/64049774/3d9a7ffb-01a6-491f-b642-64fde6a0b6c2">
But I tested it with the default python version on ubuntu 22.04 and got the same error message as on my mac
<img width="1178" alt="image" src="https://github.com/psf/requests/assets/64049774/955bd57a-0985-469a-96b1-e8e935b81082">
## Environment version
<img width="647" alt="image" src="https://github.com/psf/requests/assets/64049774/bd22f860-3ecc-4ac8-ae44-eb915aad1571">
<img width="896" alt="image" src="https://github.com/psf/requests/assets/64049774/c31ecb21-18bc-4635-9130-b52f37cc439e">
<img width="1047" alt="image" src="https://github.com/psf/requests/assets/64049774/beaa348f-7000-4966-9760-eec9e02407d8">
## Recurring environment
```python
import requests
response = requests.get(url="https://183.237.161.98:4433/favicon.ico", verify=False, allow_redirects=False)
``` | {
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/github-actions",
"id": 41898282,
"login": "github-actions[bot]",
"node_id": "MDM6Qm90NDE4OTgyODI=",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6728/reactions"
} | https://api.github.com/repos/psf/requests/issues/6728/timeline | null | completed | null | null | false | [
"As described in the template, we won't be able to answer questions on this issue tracker. Please use [Stack Overflow](https://stackoverflow.com/)"
] |
https://api.github.com/repos/psf/requests/issues/6727 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6727/labels{/name} | https://api.github.com/repos/psf/requests/issues/6727/comments | https://api.github.com/repos/psf/requests/issues/6727/events | https://github.com/psf/requests/pull/6727 | 2,325,114,546 | PR_kwDOABTKOs5w-zPG | 6,727 | Sync with latest master | {
"avatar_url": "https://avatars.githubusercontent.com/u/11651746?v=4",
"events_url": "https://api.github.com/users/mani-coder/events{/privacy}",
"followers_url": "https://api.github.com/users/mani-coder/followers",
"following_url": "https://api.github.com/users/mani-coder/following{/other_user}",
"gists_url": "https://api.github.com/users/mani-coder/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mani-coder",
"id": 11651746,
"login": "mani-coder",
"node_id": "MDQ6VXNlcjExNjUxNzQ2",
"organizations_url": "https://api.github.com/users/mani-coder/orgs",
"received_events_url": "https://api.github.com/users/mani-coder/received_events",
"repos_url": "https://api.github.com/users/mani-coder/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mani-coder/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mani-coder/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mani-coder",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2024-05-30T08:51:18Z | 2024-05-30T10:17:02Z | 2024-05-30T10:17:02Z | NONE | null | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6727/reactions"
} | https://api.github.com/repos/psf/requests/issues/6727/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6727.diff",
"html_url": "https://github.com/psf/requests/pull/6727",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6727.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6727"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6726 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6726/labels{/name} | https://api.github.com/repos/psf/requests/issues/6726/comments | https://api.github.com/repos/psf/requests/issues/6726/events | https://github.com/psf/requests/issues/6726 | 2,324,074,364 | I_kwDOABTKOs6Kho98 | 6,726 | Multiple concurrent client certs broken with v2.32.3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/26555408?v=4",
"events_url": "https://api.github.com/users/jeffreytolar/events{/privacy}",
"followers_url": "https://api.github.com/users/jeffreytolar/followers",
"following_url": "https://api.github.com/users/jeffreytolar/following{/other_user}",
"gists_url": "https://api.github.com/users/jeffreytolar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jeffreytolar",
"id": 26555408,
"login": "jeffreytolar",
"node_id": "MDQ6VXNlcjI2NTU1NDA4",
"organizations_url": "https://api.github.com/users/jeffreytolar/orgs",
"received_events_url": "https://api.github.com/users/jeffreytolar/received_events",
"repos_url": "https://api.github.com/users/jeffreytolar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jeffreytolar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jeffreytolar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jeffreytolar",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 5 | 2024-05-29T19:20:08Z | 2024-09-05T12:55:01Z | null | NONE | null | We use `requests` with multiple mTLS client certificates - each certificate is signed by the same CA, but they have different subjects - each subject has different permissions. Each distinct client cert is used by a different `requests.Session`
Additionally, we make use of `ThreadPoolExecutor` to make many requests in parallel.
When client certs are in use, urllib3 will [load the cert into the SSL context](https://github.com/urllib3/urllib3/blob/b07a669bd970d69847801148286b726f0570b625/src/urllib3/util/ssl_.py#L454-L458), which, with concurrent requests, will cause the shared SSL context to get modified while it's in use.
The reproducer actually fails with an exception - when we first encountered this, we were seeing the wrong certs get used. (That was with different versions of python and openssl, however, and as mentioned above, they're all signed by the same CA, unlike the reproducer)
## Expected Result
The reproducer below, when run with `requests-2.31.0`:
```
$ ./bin/python3 test.py
/tmp/py/test.py:24: DeprecationWarning: X509Extension support in pyOpenSSL is deprecated. You should use the APIs in cryptography.
crypto.X509Extension(b"subjectAltName", False, b"DNS:localhost, IP:127.0.0.1")
/tmp/py/test.py:50: DeprecationWarning: ssl.PROTOCOL_TLSv1_2 is deprecated
self.ssl_context = ssl.SSLContext(ssl.PROTOCOL_TLSv1_2)
Server started on port 8443...
OK client2: CN: client2 / URL: /client2
OK client3: CN: client3 / URL: /client3
OK client1: CN: client1 / URL: /client1
```
## Actual Result
When run with `requests-2.32.3`:
```
$ ./bin/python3 test.py
/tmp/py/test.py:24: DeprecationWarning: X509Extension support in pyOpenSSL is deprecated. You should use the APIs in cryptography.
crypto.X509Extension(b"subjectAltName", False, b"DNS:localhost, IP:127.0.0.1")
/tmp/py/test.py:50: DeprecationWarning: ssl.PROTOCOL_TLSv1_2 is deprecated
self.ssl_context = ssl.SSLContext(ssl.PROTOCOL_TLSv1_2)
Server started on port 8443...
FAIL client1: HTTPSConnectionPool(host='127.0.0.1', port=8443): Max retries exceeded with url: /client1 (Caused by SSLError(SSLError(116, '[X509: KEY_VALUES_MISMATCH] key values mismatch (_ssl.c:3926)')))
FAIL client3: HTTPSConnectionPool(host='127.0.0.1', port=8443): Max retries exceeded with url: /client3 (Caused by SSLError(SSLError(116, '[X509: KEY_VALUES_MISMATCH] key values mismatch (_ssl.c:3926)')))
OK client2: CN: client2 / URL: /client2
```
## Reproduction Steps
Gist: https://gist.github.com/jeffreytolar/ea05b3092df12dc6e5b518e58e6821ad ; this generates a few sets of key/certs, hackily sets the default CA bundle, and then makes a few concurrent requests, each using a distinct client cert.
With:
```
$ pip freeze
certifi==2024.2.2
cffi==1.16.0
charset-normalizer==3.3.2
cryptography==42.0.7
idna==3.7
pycparser==2.22
pyOpenSSL==24.1.0
requests==2.32.3
urllib3==2.2.1
```
(top level dependencies are `pyOpenSSL` and `requests`)
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": "42.0.7"
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.11.8"
},
"platform": {
"release": "5.15.0-105-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30200010",
"version": "24.1.0"
},
"requests": {
"version": "2.32.3"
},
"system_ssl": {
"version": "300000d0"
},
"urllib3": {
"version": "2.2.1"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| null | {
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/6726/reactions"
} | https://api.github.com/repos/psf/requests/issues/6726/timeline | null | null | null | null | false | [
"Thanks for the report, @jeffreytolar. It does looks like we're not checking the certs provided by the Session before opting into the default context, I've put together fe251aa94b2b7849e224e455c0aad0df53ad3d8e to disable the default context when certs are present.\r\n\r\nHowever, with testing I'm seeing an exception with the cert being self-signed that wasn't present in 2.31.0. I'm looking into that further but would you mind checking the above patch against your current setup so we can decouple the two issues. If your issue is persisting after we've moved the default context out of the hot path, there may be something else at play with the recent CVE fix.",
"So far it's looking like that patch is working in our main setup - thanks for the quick commit!\r\n\r\nFor the self-signed issue still in the reproducer, I think it's that 2.32.x isn't passing a CA bundle to urllib3, whereas 2.31 did that here: https://github.com/psf/requests/blob/147c8511ddbfa5e8f71bbf5c18ede0c4ceb3bba4/requests/adapters.py#L257-L258 ; that causes urllib3 to load the OS default, rather than using `certifi`\r\n\r\nTo restore the v2.31 behavior, I think maybe a `elif verify is True: pool_kwargs[\"ca_certs (or ca_cert_dir)\"] = extract_zipped_paths(DEFAULT_CA_BUNDLE_PATH)` might work in `_urllib3_request_context` ?",
"> So far it's looking like that patch is working in our main setup - thanks for the quick commit!\n> \n> For the self-signed issue still in the reproducer, I think it's that 2.32.x isn't passing a CA bundle to urllib3, whereas 2.31 did that here: https://github.com/psf/requests/blob/147c8511ddbfa5e8f71bbf5c18ede0c4ceb3bba4/requests/adapters.py#L257-L258 ; that causes urllib3 to load the OS default, rather than using `certifi`\n> \n> To restore the v2.31 behavior, I think maybe a `elif verify is True: pool_kwargs[\"ca_certs (or ca_cert_dir)\"] = extract_zipped_paths(DEFAULT_CA_BUNDLE_PATH)` might work in `_urllib3_request_context` ?\n\nYeah, I thought the optimization broke the zipped paths extraction but couldn't prove it easily ",
"Ok, so that's the same issue reported here (https://github.com/psf/requests/pull/6710#issuecomment-2137095349) this morning. That explains why calling `load_default_certs` on the SSLContext fixes it.\r\n\r\nLet me take a closer look tomorrow, I'm a little worried if we do it only for `verify is True` that we'll start the whole custom SSLContext issue over again. Thanks for pointing that out, @jeffreytolar!",
"Any updates on a release including a fix for this @nateprewitt ?"
] |
https://api.github.com/repos/psf/requests/issues/6725 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6725/labels{/name} | https://api.github.com/repos/psf/requests/issues/6725/comments | https://api.github.com/repos/psf/requests/issues/6725/events | https://github.com/psf/requests/pull/6725 | 2,322,402,383 | PR_kwDOABTKOs5w1g4a | 6,725 | Add debug | {
"avatar_url": "https://avatars.githubusercontent.com/u/3431702?v=4",
"events_url": "https://api.github.com/users/osbornch/events{/privacy}",
"followers_url": "https://api.github.com/users/osbornch/followers",
"following_url": "https://api.github.com/users/osbornch/following{/other_user}",
"gists_url": "https://api.github.com/users/osbornch/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/osbornch",
"id": 3431702,
"login": "osbornch",
"node_id": "MDQ6VXNlcjM0MzE3MDI=",
"organizations_url": "https://api.github.com/users/osbornch/orgs",
"received_events_url": "https://api.github.com/users/osbornch/received_events",
"repos_url": "https://api.github.com/users/osbornch/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/osbornch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/osbornch/subscriptions",
"type": "User",
"url": "https://api.github.com/users/osbornch",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-05-29T05:40:53Z | 2024-05-29T05:50:39Z | 2024-05-29T05:50:39Z | NONE | null | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6725/reactions"
} | https://api.github.com/repos/psf/requests/issues/6725/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6725.diff",
"html_url": "https://github.com/psf/requests/pull/6725",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6725.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6725"
} | true | [
"It looks like this may have been opened by mistake. I'm going to resolve this as we won't be able to accept it."
] |
https://api.github.com/repos/psf/requests/issues/6724 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6724/labels{/name} | https://api.github.com/repos/psf/requests/issues/6724/comments | https://api.github.com/repos/psf/requests/issues/6724/events | https://github.com/psf/requests/pull/6724 | 2,321,781,540 | PR_kwDOABTKOs5wzblr | 6,724 | Don't create default SSLContext if ssl module isn't present | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2024-05-28T19:34:27Z | 2024-11-03T03:10:32Z | 2024-05-29T15:23:40Z | MEMBER | null | This PR is to address a [recent regression in Emscripten support for urllib3](https://github.com/urllib3/urllib3/actions/runs/9253144050/job/25452248794). We began unilaterally creating an SSLContext without consideration for Python versions built without an ssl module. This is handled in urllib3 but missed in our usage of `create_urllib3_context`.
This PR expands on the fix in #6716 by also evaluating both the presence of the `ssl` module before creating and setting the default SSLContext. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6724/reactions"
} | https://api.github.com/repos/psf/requests/issues/6724/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6724.diff",
"html_url": "https://github.com/psf/requests/pull/6724",
"merged_at": "2024-05-29T15:23:40Z",
"patch_url": "https://github.com/psf/requests/pull/6724.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6724"
} | true | [
"We also need to do this for `FileNotFoundError`, which is raised if `DEFAULT_CA_BUNDLE_PATH` isn't there. Sent as https://github.com/psf/requests/pull/6781 ."
] |
Subsets and Splits