User1: User4 we have a small problem with the theming in MainWindow
User1: the theming extension is made for QQUickItem, and that doesn't really work now on the window
User2: I already asked over at #ubuntu-touch but this probably the better group
User2: I did an update to an app of mine in the store yesterday which got aproved okay  but isnt getting published
User2: am I missing something or is this a click store issue
User3: User2 or here :)
User2: oh hi popey
User2: stUd
User2: is the appname :)
User2: matv1 is my devname
User3: looking...
User3: User2 click the publish button at the bottom of https://myapps.developer.ubuntu.com/dev/click-apps/4735/rev/9/
User2: popey argh
User2: sorry
User3: np
User3: it's a silly place to have a button IMO
 * popey pokes pindonga :)
User3: you're not the first and won't be the last not to find a button at the bottom of the page.
User2: on the other hand, I apparently had no trouble finding that button the previous 8 times as this is the 9th update :) So its really me going senile. No way around it :(
User4: User1 Hmmmmm so QQuickWindow can't be themed, as it's a QObject... but we don't actually need to load a theme, right? All we need is to propagate the value
User1: User4 it can be themed, but I need to do more modifications on the UCThemingExtension and UCTheme so it works with other than QQuickItem
User1: yes, all we need to propagate the theme changes to the children
User1: that's what UCThemingExtension also does
User4: User1 I might have to check the code again.. I'm not sure why it would matter if it's an Item or an Object
User1: User4 it uses some Item specific things, but I am in the middle to adjust the things
User1: it is the UCTheme which does watch some itemXXXChanged things
User4: User1 Ah, I see now. We never expected to deal with objects there. I ran into that assumption even with a simple unit test earlier this week, where getting an *item* by object name used QQuickItem for no reason and didn't work for a window for that reason
User1: +!
User1: so a Window needs special treatment...
User4: Yes and no... the logic of children and properties doesn't even need an Item
User4: But we assume that's what we always get
User4: The code just has some prejudice
User4: User5 I don't know if you've seen yet, but your MR now gets CI results https://code.launchpad.net/~artmello/ubuntu-ui-toolkit/ubuntu-ui-toolkit-clipboard-dbus/+merge/314072 Although it looks like a flaky one anyway so you can probably ignore that and focus to the ones you're adding
User5: User4 yep, I saw that, thx. We got new design spec for the clipboard ui so I put the tests on hold until I finish implementing that. Hopefully I am back to finishing the tests today
User4: User5 Oh, okay. So just FYI if you get them ready in the next couple of days we might be having a landing including your code
User5: User4 cool, I think it will be done by that
User6: Does "Ubuntu.Components.TextArea" support support "append", i only see "insert" with position
User6: ?
User4: User6 I'm afraid not. It's basically a matter of convenience: TextArea mirrors the most important API from TextEdit (QtQuick)
User4: You can use insert, effectively appending it, or of course you can just .text += as well
User4: If you were to propose a small MR adding "append" I'd say that's welcome - I don't know that it's absolutely necessary, personally, but it makes sense to add it for completeness
User6: User4 TextEdit does have "append", for now i am doing textArea.text = textArea.displayText + str
User4: User6 Right, hence my saying 'most important API'. It's a manual cherry-picking processes where someone finds a method worth having and we add it.
User6: User4 ya i'll do it
User4: Cool
User4: Let me know when you, and I'll be happy to review it
User6: User4 is this correct https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1658121/ ?
User4: User6 I see some unrelated changes in there
User4: The last bit looks fine, though, if you could fix that
User6: User4 ya not sure how do you branch guys, i just pulled trunk, made the change, commited and proposed the MR against staging
User4: User6 You need to have a branch based on staging, not trunk
User4: Probably need to rebase it
User6: User4 ah ok tha's why, how can i rebase ?
User4: Only landings go to trunk
User4: User6 It might be easiest to just bzr branch lp:ubuntu-ui-toolkit/staging, and copy the changed TextArea.qml there, since you don't have any other changes
User4: And make a new MR
User6: User4 ok
User6: User4 https://code.launchpad.net/~daker/ubuntu-ui-toolkit/fix.1658121/+merge/315241
User4: happroved!
User6: User4 thanks!
ubuntu-app-devel
Ubuntu IRC