User1: Saviq, hey, do you know what's the status of https://bugs.launchpad.net/canonical-devices-system-image/+bug/1393438? is the fix on that bug supposed to address the issue? where is the translatable string in that case?
User2: Launchpad bug 1393438 in unity8 (Ubuntu) ""Enable location data" string displays untranslated" [Undecided,Confirmed]
User3: seb128, digging...
User3: seb128, right, so it's missing some work on our (unity8) side
User1: Saviq, k, that explains, thanks
User1: Saviq, any chance that get assigned to somebody? the string is quite visible in the ui
User3: seb128, just did
User1: thanks
User1: Saviq, sorry to have reported that dialer bug against unity8, I was unsure what component to pick, it's a bit of an app management issue ... could be the job from whoever started it to close it, or could be up to the dialer to exit after call
User3: seb128, no worries, I left a unity8 task just in case
User3: as it's indeed not clear dialer can do all it needs to do
User4: tsdgeos, testing the temp scope to temp scope is a bit tricky: the only scope calling activate is the click scope, but the click scope cant be made unfavourite
User5: User4 so what's the real world scenario we are fixing?
User5: it's store as temp, and then a preview in store calling another temp, no?
User3: Cimi, the store scope calls activate too
User5: if that's what we're having
User3: Cimi, you go to store, install a scope, press Search
User5: we should try to replicate something similar
User5: it doesn't need to be "the store" in our mocks
User5: but something similar to what we're fixing
User5: so the test is at least the real world case
User4: we're fixing temp scope from tempo scope
User5: User4 via what? preview or just activation of a result?
User4: tsdgeos, for now preview, but I guess we need to see other possible scenarios
User5: sure
User4: in the test I am manually calling activate
User5: yeah
User4: from a temp scope
User5: don't do that
User5: let's please make a test that does the same the user does
User4: but how do I create a ubuntu store scope with previews?
User5: it doesn't need to be a ubuntu scope
User5: it can be any of the mock scopes
User5: and they have previews already
User5: you just need to make one of those previews be special and do the same the store scope does to us when pressed
User4: yeah, don't know what it does
User4: have to dig
User4: where is the code of the store?
User5: you don't need the code for the store
User5: just add some console.log in the preview code
User5: and see how what it does
User5: triggeredAction looks like a good place to add a console log
User4: OK
User3: /food
User4: tsdgeos, it might be that is the preview model launching actions?
User4: I see in Preview.qml that the buttons call previewModel.triggered()
User4: (with action  open_click [object Object] with the latter probably a scope)
User5: User4 and how does that come back to us? in gotoScope/openScope of Dash.qml/DashContent.qml ?
User4: tsdgeos, don't know
User5: User4 console.log!
User4: tsdgeos, the action is called by the backend
User5: of course
User5: i'm just trying for you to understand the call path
User5: so you can make our mock do something similar
User6: User7 hey
User7: mzanetti, hello!
User6: User7 I'm trying to fix the as launcher model
User6: User7 can I know if the session is running?
User6: in order to ignore the non pinned ones
User7: mzanetti, umm..  I just checked and I actually can't see that in the greeter API that LightDM exposes...
User7: mzanetti, LightDM surely knows
User7: mzanetti, but...  oh wait.
User7: mzanetti, no the greeter does know
User7: mzanetti, so the greeter can know via liblightdm
User7: mzanetti, but your branch doesn't care about that side of things, right?
User7: mzanetti, your branch doesn't actually *use* the AS launcher model?
User6: User7 not really
User6: User7 it's just preparing it for you, so you can take it into use without having to mess with the launcher too much
User6: User7 I've added the pinned information to the sync process now
User6: User7 so what do you propose?
User7: mzanetti, let me see if you can do anything with that information, given the current state of the LightDM plugin... hold on
User6: I could add a "hideUnpinned" property to the launcher api. then when you use that in the split greeter, set that to true somehow when the session is not running
User7: mzanetti, so it is exported via the "loggedIn" data property on the LightDM.UsersModel object
User7: mzanetti, so that should be simple to hook up to your hideUnpinned property, yeah
User6: ack
User8: Anyone have an opinion on QQmlListProperty versus QAbstractListModel? I preferred QQmlListProperty for simple lists of objects, but now I think about it, it just has a "list changed" signal - it doesn't inform the view more detail about what changed like QAbstractItemList does (dataChanged, itemAdded/Removed)
User6: User8 yeah... QQmlListItem is pretty useless unless you want to create/change the list from qml
User6: err. QQmlListProperty
User8: User6 so I'm seeing. But I never really liked creating a QAbstractListModel with a single roleName either, since the  role is kinda pointless
User6: yeah...
User6: I for one so far always ended up converting my QQmlListProperties into real models at some point
 * greyback takes note
User5: User3 User4 how do you guys see https://code.launchpad.net/~aacid/unity8/properVRangesCurrentScope/+merge/246465 ?
User3: tsdgeos, "see" in what way? it's a Needs-review MP?
User5: User3 yeah
User5: and i need someone not me
User5: to check if we actually want that :D
User5: or not
User3: ok, I'll check it out
User4: Saviq, thx
User9: Cimi, hey! can we land https://code.launchpad.net/~stolowski/unity-scopes-shell/fix-temp-scopes/+merge/248235 ? did you have a chance to test it with your fix?
User4: tsdgeos, today I noticed that when we open or switch to a scope, we load all results then we do collapse
User4: pstolowski, seems to work, I am working on unity side
User5: User4 what you mean load all results and then collapse?
User4: tsdgeos, try with the kickstarter scope from the store
User9: Cimi, ok, cool
User4: tsdgeos, you see the categories start populating, then it collapses
User4: it starts expanded then collapse
User4: maybe when we load scopes we should load just collapsed results at first, then load the rest later?
User10: Seems mumble dies again?
User5: User4 hmmm we load everything collapsed
User5: or we should
User5: User4 can you record a video?
User3: paulliu, yeah, it looks like
User4: tsdgeos, ok
User4: tsdgeos, https://www.youtube.com/watch?v=RTG6xPYmR48
User4: also, this "hide manage dash and scroll right to the scope" isn't the best, but it is more a design thing
User3: Cimi, I assigned you to the bug today, the one about "Enable location" being untranslated in our UI, we need to add a special setting type that will have the strings to translate hardcoded
User4: Saviq, saw it
User4: Saviq, I am still trying to do this test for the temp scope fix
User3: Cimi, yeah sure, just wanted to let you know the desired approach
User3: Cimi, this looks like we're leaving the first category expanded until there's more categories, which is per design, but I agree the visual glitches are not nice
User5: User4 hmmm, that's weird, we default to non expanded for all categories, does this only happen on that scope or all?
User3: tsdgeos, don't we have code that expands if there's only one category?
User4: tsdgeos,  noticed only on that scope
User3: tsdgeos, Cimi, it might be that the scope registers the categories as they come in
User4: it's tedg fault :P
User3: instead of early in the reply
User5: User3 hmmmm, can't find anything like that in the code tbh
User11: Cimi, Me? Temperature? It's nice here, not cloudy London.
User3: tsdgeos, GSV.qml:236
User11: Cimi, Do you even remember what the sun is like anymore? ;-)
User3: tsdgeos, and then GSV.qml:307-308
User3: tsdgeos, one category == not expandable; == expanded
User5: User3 but it has to match expandedCategoryId
User5: expandedCategoryId is only set when clicking on see all
User4: tedg, morning.
User3: tsdgeos, not really, height is selected based on bool expanded, which is always true if bool expandable is false
User4: tedg, I forgot :(
User11: Cimi, You need to come visit!
User5: ah right right
User5: User3 not expandable means not collapsable either
User3: tsdgeos, yup, it's just full-height always
User3: tsdgeos, which means that if we're just getting one category, all results, then another category
User5: yeah i think the code expects the categories not to change on runtime
User3: tsdgeos, we load them all just to collapse them again
User5: yeah
User3: yeah, the scope API I'm afraid allows that, if not encourages
User4: tedg, will come to see you and evan...
User5: User11 User3 so on https://code.launchpad.net/~ted/unity8/delay-indicator-start/+merge/241124 ? discard?
User11: I'm still +1 on it. I think it makes more sense. Doesn't fix that bug, but it should help.
User11: No reason to make Unity compete for resources.
User5: User6 any idea why daniel didn't top approve https://code.launchpad.net/~mzanetti/unity8/launcher-fixes/+merge/248761 ?
User6: User5 he probably just forgot... was sitting next to him when he told me he's ok with it
User5: is he on holidays this week?
User6: don't think so... I guess having a swap day for travelling across the sea
User5: ok, let's wait for him tomorrow then
User5: User6 can you do https://code.launchpad.net/~dandrader/unity8/improveLauncherTests/+merge/248919 alternatively?
User6: User5 yep, on my list
User6: lemme claim it
User5: cool
User5: User12 so where are we on https://code.launchpad.net/~macslow/unity8/swipe-dismiss-snap-decisions/+merge/233347 can you reproduce the errors Saviq mentions?
User3: tsdgeos, that seems fixed already, but he's got some other failures
User5: i see
User3: actually a hash sum mismatch for qmluitests, /me rebuilds
User3: MacSlow, the ap test for lifecycle is sometimes flaky, don't worry about that
User12: Saviq, I assumed that after a few tries on my machines here
User3: MacSlow, just start with kicking a jenkins rebuild next time
User6: User7 ok. pushed the branch
User6: User7 didn't change the appid/url thing for the reason of consistency. We use appId all over to identify items... not sure I want to do something else here
User7: mzanetti, OK makes sense.  Like I said, I was just half-remembering a conversation about that
User7: mzanetti, will review again, thanks!
User6: User7 ah, I agree that we should collect split greeter based plugins in the Greeter dir. also that it should be another MP :D
User7: mzanetti, yeah it's grown beyond a thin layer on top of lightdm
User6: indeed
ubuntu-unity
Ubuntu IRC