User1: huwshimi so besides the var things code review ok?
User2: User1 I don't really know. I mean there's code there, it does some stuff. I'm not sure I know enough to be reviewing branches like this.
User1: ahh ok
User1: huwshimi can you respond with QA OK and then I'll land it, if there are some code issues that others don't like we can fix them in a follow-up
User1: I just don't want to get held up as there are more changes to be made in this section
User2: User1 Left a note
User1: lol, nice passive agressive comment
User1: if you would like you could fire an email off to design :)
User2: User1 I'm not sure about landing this without a proper code review though. I can't see if Kyle did one either
User3: User2 hatch what do you need?
User3: User1 I can do one in the morning before you start if required
User1: huwshimi ok that's fine if you're not comfortable
User3: no calls until 10 yay!
User1: rick_h__ that would be awesome thanks
User3: User1 ok, I've got it on my morning todo.
User3: too shut down to look right now sorry
User3: thanks for looking huw
User1: np it's well past EOD :)
User1: rick_h__ https://github.com/juju/juju-gui/pull/437 then https://github.com/juju/juju-gui/pull/439 is branched from it
User3: User1 rgr
User1: and now I'm also done :)
User3: night hatch
User1: night rick_h__ huwshimi
User3: go find your watch :P
User1: lol
User1: right!
User4: User5 morning!
User5: User4 morning
User4: User5 how're you feeling today?
User5: User4 better, at least i feel hungry now :D
User4: User5 always a good sign...
User4: User5 do you fancy pairing on moving the charm store apiHandler stuff forward?
User5: sure. give me 10min to grab something to eat
User4: User5 np
User5: User4 sorry, that breakfast didn't land well :S
User4: User5 oh dear :-\
User5: User4 yeah, fats to soon ... nevermind, it'll pass ...
User5: User4 gogogo?
User4: User5 if you'd prefer to go back to bed, or not interact much, that's fine
User4: User5 yup, i'm there
 * urulama lunches
User3: morning all
User3: User4 have you followed the license thread?
User4: User3 i have
User4: User3 (g'morning, BTW)
User3: User4 can you please make sure all our repos, charmstore, charm, etc are ok on that front please?
User3: User4 it looked like the agreement was lgpl with exception?
User3: for outside libs
User4: User3 yes
User4: User3 charmstore is fine
User4: User3 charm should probably be LGPL but is currently AGPL
User3: ah, since it was pulled from core which is agpl?
User4: User3 yes
User4: User3 but it could easily be changed to LGPL
User3: ok
User4: User3 (with a possible caveat of whether LGPL is compatible with the apache 2 license)
User3: moving to the coffee shop, biab
User6: hola
User3: morning bac
User6: how was swim lessons?  i remember enjoying them until they tried to make us go off the high dive.  didn't go back.
User3: heh, due to scheduling fun we had to go private lessons this round and the boy is loving the personal attention
User3: show off "I can swim under water" and he just throws himself into the lake
User3: then comes up with half the lake being swallowed
User3: but it's fun, hard to not get eager for him to do real swimming so we can trust him to be more indenpendent at water parks/etc
User5: i need to change place, "feels" too crowdy at home today :D
User3: User5 yea, coffee shops ftw
User5: User3 i actually have access to place with net and everything on the other side of town, near woods and more important, no kids singing and dancing around :D
User3: User5 sounds like a winner
User7: morning.
User3: morning jrwren
User3: User1 sorry, I'm behind on your reviews. Been a busy morning
User3: User1 looking now and will try to get done asap
User1: np thx
User3: User1 one round of comments in
User1: thx will check
User3: User1 going to wait on the second one until the diff is one vs both
User1: ok I'm going to have to fix the markup to enable enter submissions as it uses multiple form elements
User1: atm you can submit the constraints form, the unit count form, etc which doesn't make any sense
User3: User1 ah, yea that's ungood. To the user it's all the same form
User1: I'm guessing huw did that on purpose so I wonder what surprises await me in doing that
 * rick_h__ heads back home, coffee shop is getting crowded.
User3: User1 heh, well that's fine to do it as a follow up
User3: User1 but your current branch can land without the block
User1: without the block?
User3: User1 but take a stab at it, if you end up in css hell, create a card and punt it
User3: without the block on the enter key
User3: saying "if you use the enter key it doesn't work predictably" is a follow on bug/card
User1: well not really - they can submit the constraints form
User1: so it falls apart if they hit enter on that
User1: I'll take a stab, see where it ends up
User6: hi abentley
User8: User6 otp
User6: User8 ok, please ping me when you have a few minutes free
User1: jujugui call in 5
User3: jujugui call in 1 and go
User3: or now ish
User4: jujugui: hmm, i'm getting "Couldn't start the video call because of an error"
User5: User3 same here
User3: User4 urulama another browser?
User3: User11 ^
User4: i'll try incognito
User3: User6 ^
User6: trying
User4: that didn't work
User5: me neither
User4: unfortunately i don't have another browser installed currently
User5: tried firefox and chrome
User5: (and safari /me runs away)
User4: User5 our previous session seems to have tainted both of us...
User5: i get the "due to the number of participants ..." error
User4: i don't get that
User4: it lets me in (apparently) and then gives me the error
User4: jujugui: sorry guys
User5: yes, same here ... see who is there but not able to join :(
User3: sounds like it hates EU folks :/
User3: everyone else is here
User4: User3 for the record, the "store: start version api responses" card is making good progress. urulama and i should have something to show very soon
User4: User5 can you still join gogogo?
User5: User4 yes
User5: User4 no
User5: :S
User4: User5 i thought it was working for me too...
User4: User5 and then not
User4: User5 bugger
User5: User4 maybe google blocked us due to the usage today :D :D
User4: User5 hmm
User5: User4 let's give it 10min and retry
User4: User5 yeah
User3: User4 urulama k, reported. Nothing big from the team. I've got a vet appt and will be afk some this afternoon, but that's post your EOD so no worried on your end
User9: User3 re the tagging notion--are we going to be on the hook to do that as proper tagging? e.g. a charm can have multiple tags, and a search should be able to do multiple tags?
User7: In go, I know we follow gofmt. do we have style guidelines beyond that?  e.g. prefer multiline string to string with embedded \n after a certain number of newlines?
User9: User7 in python, flake8 is your style bible.
User7: yes, I flake8 in python.
User9: that's about it, afaik.
User7: ok.
User9: and for js in the gui, i have no idea what our style rules are--i just fix what the linter screams at me about. :P
User9: seems to be working so far. :P
User3: User7 there's a pull request in juju core for style guide
User3: User7 take a peek and see if you can find it in current or recently closed pull requests in /juju/juju
User3: User9 it'll be just like categories now, a list of string. And yes, we'll index those and allow searching on that filter
User9: User3 cool.
User5: User3 ok, good luck at the vet, maybe see you later
User3: User5 sure thing, I think we should chat in a bit. just cathing up
User5: User3 ok, ping when you come back, otherwise, first thing in the morning?
User3: User5 yep
User3: User7 https://github.com/juju/juju/tree/master/doc/contribution
User7: thanks rick_h__
User3: np, it's a WIP but something we should get familiar with and support across projects. rogpeppe urulama ^ as well
User3: User6 Makyo ^
User5: User3 checking
User4: User7 also, this is well worth reading: https://code.google.com/p/go-wiki/wiki/CodeReviewComments
User4: User7 and in general, the go stdlib is very well written and idomatically designed - if it does something a particular way, it's usually a good way to do it
User7: Great to know.
User4: User7 there's also this: https://github.com/golang/lint
 * urulama brb
User7: oooh, golint, lots of messages. I like it.
User6: User3 got a sec? http://91.69.162.6:8080/job/charmworld-autoland/165/console  -- search for "Selec+" ... it seems the console output abruptly halted, not capturing the actual problem
User6: not a one off
User3: User6 looking
User3: User6 hmm, yea. It was still installing deps and then failed. Mabye a netork issue?
User6: perhaps.  i'll look to see if it failed at the same point previously
User3: network, the jenkins-launchpad-plugin? Maybe a missing dep?
User3: from the download cache?
User3: User6 I'd look at a normal fresh run and see what package it's grabbing after the python-lazr and see if something is up with fetching it?
User6: ok
User5: User4 still no gogogog :(
User3: User5 rogpeppe I'm going to setup a call for the morning. Hopefully the hangouts issues work out by then
User5: User3 ok
User1: rick_h__ moving that form stuff is causing issues, I'll land my two branches then do it as a follow-up right away, will be muuuch easier when I don't have to worry about conflicts from my next branch
User4: User5 yeah, i'm still having the same problems
User3: User1 rgr
User4: User5 this is what splitId is looking like now, BTW: http://paste.ubuntu.com/7803979/
User5: User4 ok, this is muuuch better then the clutter before :D
User5: User4 but we do "parse" it twice, right (with the Charm.parse) call?
User4: User5 sure. but the first parsing is very lightweight. i doubt it'll take more than a small number of ns
User1: rick_h__ ok while these things land I'm just going to pick off another bug card from the pile
User3: User1 rgr
 * rick_h__ goes to get some lunch
User5: User4 yes, i was just thinking in a way, that this splitId could be part of Charm, so that it is always in sync to all
User4: User5 that's a good idea
User4: User5 i guess you'd probably want to make the knownSeries an argument to it then
User5: User4 that part i don't like :D (but have no alternative atm)
User5: (as agreed before)
User4: User5 yeah, i'm not keen either. i'm tempted to just leave this logic in the charm store for the time being, as we don't really want other people doing the same thing
User5: User4 +1
User4: User5 after all, we do double-check that the final URL parses ok
User4: User5 so if charm urls change, then our tests will break immediately
User7: User4 https://github.com/juju/charm/pull/19 look good?
User4: User7 LGTM
User7: ty.
User7: now I can bug rick_h__ for moar! :)
User3: ruh roh
 * rick_h__ pulls up the board of work item doom
User3: User7 side task, can you git pull origin develop from the ci slave machine in the /var/lib/jenkins/jenkins-github-lander directory?
User7: oh, to get changes there?  sure.
User3: User7 yea, catch it up to latest src
User7: I can't status the ci-environment :(    http://pastebin.ubuntu.com/7804136/
User3: User7 there's been a bug going around on that, /me looks
User3: User7 https://bugs.launchpad.net/juju-core/+bug/1307434
User10: Bug #1307434: talking to mongo can fail with "TCP i/o timeout" <cloud-installer> <landscape> <performance> <reliability> <juju-core:In Progress by mfoord> <https://launchpad.net/bugs/1307434>
User3: restarting the state server seems to have helped?
User3: User7 marked as in progress
User3: User7 did you get access to azure?
User3: User7 or need me to do the bouncing?
User7: i don't have access to the web portal. I could probably use azure cmdline tools to do it.
User7: that might be a good exercise for me :)
User3: User7 will reboot it here, one sec
User3: User7 give it a shot?
User7: thanks.
User1: thanks to all the hard work jcsackett  put into the changes in rendering the inspector my current branch is super trivial to implement :) yay jcsackett
User3: woot yay jcsackett :)
User7: User3 just trusty-slave or other slaves too?
User3: User7 I can't recall which I updated, please check all three
User3: jenkins machines
User1: rick_h__ hey I just wanted to point this bug out that my branch will create - I'm not sure what priority you want to put it at https://bugs.launchpad.net/juju-gui/+bug/1342809
User10: Bug #1342809: Inspector tabs should route the url <juju-gui:New> <https://launchpad.net/bugs/1342809>
User3: User1 they can't route because it's too hard to figure out inspector tab vs details/browser tabs
User3: User1 and we've prioritized the charm details over inspector tabs
User1: I'm not sure I understand, I don't see why they both can't work?
User1: http://91.69.162.6:8888/inspector/wordpress/charm/tab/relations/:flags:/mv/ seems to work just fine
User1: oh I see a bug in it... showTab() closes the breakout
User1: so you can't have a tab navigate and the breakout visible
User1: I'm pretty sure that's the viewlet slot issue and not a routing issue though
User6: User3 the jenkins issues was due to it running out of disk while doing an install inside the lxc, so the error message got swallowed.  cleaned up some old lxc directories and trying again.
User6: s/issues/issue/
User3: User6 ah!
User3: User1 looking, sorry. in my head tabs in the inspector would be just like the browser as #tabname
User3: and so we have two namespaces living in the one propery
User3: User1 but it looks like I'm mistaken and the inspector tab is part of the root url?
User1: it is now :)
User3: User1 hangout?
User1: sure
User1: trying to join the standup one
User1: rick_h__ does your watch disconnect from the phone a lot? This one dc's like every hour then you have to turn the phone on and hit the button to reconnect
User3: User1 no, it's been really good
User3: User1 does your phone do BT LE, 4.0 I think?
User1: yep, running the latest android and everything - all power saving options turned off
User1: I can't even find anyone complaining online so this might be an isolated incident
User1: rick_h__ https://github.com/juju/juju-gui/pull/439 is ready for review - sidenote: I had to pull it down and rebase develop into it to remove the old commits, I kind of assumed the Pr would do that automatically
User3: User1 rgr, loading
User5: jujugui night all
User3: User5 have a good evening
User3: User1 can I ask you about non machine view uses?
User1: pourquoi?
User3: qa without :flags:/mv
User1: oh...
User1: hmm
User3: it seems to be wanting a bit now
User1: heh
User1: ok I guess my removal branch can't land?
User3: not at this time.
User1: hmm
User3: it can make sure you only get the new UX in MV, but without the flag is still important for 3wks
User3: well, 2 we'll call it
User1: hmm ok I think I can use those new flag css classes to hide it with mv
User1: I'll leave this branch for reference, close the PR, and create a new one to hide the old stuff under mv
User3: User1 k, so I this branch will be a bit diff to land
User3: User1 ok, sounds good thanks
User3: sorry for the blockage there :/
User1: s'ok there will be some conflicts in the future but the majority of the code will still be usable so definitely want to keep it around
User3: k
User3: jujugui, just a reminder to QA both with and without the feature flag.
User1: rick_h__ can you comment about the non mv stuff on #439 PR?
User1: jujugui looking for a quick review/qa on https://github.com/juju/juju-gui/pull/440
User11: User1 checking
User1: th
User1: x
User11: welcom
User11: e
User1: :
User1: P
User1: LOL airbnb's new logo
User1: clearly they didn't run that one past the internet lewd machine first
User1: arosales hey did you see the ghost charm is now promulgated?
User1: jujugui looking for a review/qa on https://github.com/juju/juju-gui/pull/441
User1: really trivial css change
User1: kadams54 did you get lost on #440? The diff isn't that big ;)
User11: User1 sorry, had an important phone call come in.
User1: those are the worst - getting in the way of the daily activities
User11: User1 all done with review and QA.
User1: thanks! Can I sucker you into doing #441 too?
User1: it's really really small :)
User11: To make up for it, I'll check out your trivial CSS change.
User11: Hah!
User11: Great minds.
User1: lol
User11: Trivial thing I just noticed: we don't have proper pluralization in the new scale up UI or in the unit list belowâ¦ "1 units" and "1 running units".
User11: Not in the scope of your work though
User3: it's a simple helper, add it real quick :P
User11: OK, #441 is ready to ship
User3: we're getting bad about not catching drive by stuff with that plural stuff. It's getting wrong all over
User1: kadams54 thanks, I'll add that pluralization in the follow-up
User1: http://blog.atom.io/2014/07/02/moving-atom-to-react.html
User3: User11 how goes your branch?
User1: it says they are using jquery...I really have no idea what for when they control the environment it operates in
User3: User11 I'm heading to the vet, but I'd like to get another set of eyes on your WIP to help move the card of work through. hatch or Makyo can one of you take a peek and see how you can help please?
User1: sure
User1: kadams54 what's he talking about?
User1: ;)
 * rick_h__ goes to get the dog poked
User6: yay, my favorite test case now works: https://jujucharms.com/?text=ouch
User9: User11 are you leaving friday morning from london?
User1: jcsackett I am
User1: well...friday noon i think
User1: iunno it's in the spreadsheet heh
User9: User1 i'm pinging kadams54 b/c i think he is on the same flight as me, and mine got modified--i'm leaving the 26th, but the sheet says the 25th. i would imagine kyle is in the same boat, unless he really is leaving friday AM.
User1: ohhh
User9: yeah, i just emailed sarah to sort it, but kadams54 might need to do the same.
User11: User9 Uh oh, yeah, that wouldn't be good
User9: User11 you're in the same boat, then?
User11: User9 I haven't seen any e-mails about changes yet.
User9: User11 are you leaving sat or fri?
User11: Last I knew, Friday
User9: User11 ok, so you're fine. that's what it says for you. we're both DL-19, just on different days.
User11: DL0019, leaving at 9:35 AM
User9: cool, figured there was a chance we were both on the same flight, rather than just flight num, and yours had been goofed too.
User11: hatch, User12 I'll have a PR shortly for you to look at on that branch.
User9: but it's just the same flight, so i'm the only one goofed. :P
User9: er, flight no. anyway.
User11: User9 I'll try not to trash the plane too much on my flight then :-)
User9: User11 i would appreciate that. :p
User11: guihelp: is there a reason /:flags:/mv/ is 404ing for me on comingsoon?
User1: bac ^ comingsoon isn't dispatching paths to the guiserver
User1: kadams54 ^ the app is supposed to be handling the urls but the server isn't passing them through
User6: User1 ungood
User1: that's your fault right?
User1: :)
User6: User1 yes, it was my mid-afternoon time bomb
User1: lol
User1: bac is it something you can take a look at or should someone else?
User6: User1 i'm looking.
User1: thank yas!
User6: User1 [client 91.69.162.6] File does not exist: /var/www/juju-gui/build-prod/:flags:
User1: bac right, but why is it now thinking that that's a file?
User1: http://comingsoon.jujucharms.com/machine also fails for example
User6: so apache is attempting to
User1: bac it should be passing anything that's not in the juju-ui path to the GUI
User6: serve it instead of having the app do it
User1: yeah...did someone break the charm?
User6: charm or apache config?
User1: doesn't the charm contain the apache config?
User1: heh
User6: not charm.  this isn't installed via  charm
User1: ohhh
User6: it were hand-rolled by me
User1: I thought this was the charm which was just updated every time
User6: has anyone tried :flags: in the last week or so?
User1: I thought I used it yesterday tbh
User1: maybe it was monday?
User6: this config hasn't changed since the 10th
User1: hmm, well then...
User1: maybe I didn't use a flag or direct url
User1: sorry I can't be of more help
User1: I could look at the config though if you want
User6: User1 http://bazaar.launchpad.net/~juju-gui-charmers/charms/trusty/juju-gui/trunk/view/head:/config/apache-site.template
User6: that's what the charm does
User6: i didn't think to copy the charm and just manually created an apache config from the nginx config we used on the old site
User6: User1 FallbackResource looks interesting
User1: I was just going to say that might be the trick, I was just looking it up heh
User1: yep that does look like what we need
User1: wow it's been a long time since I've had to read an apache config
User6: ha
User1: brings me back to the good ol days of multiple client PHP work on the same server
User1: oy
User1: "directive all the things!"
User6: thanks hatch.  kadams54 http://comingsoon.jujucharms.com/:flags:/mv/ works
User11: User6 thanks
User1: bac thanks for doing that so quick! u rock
User6: np
User11: Makyo, User1 WIP PR at https://github.com/juju/juju-gui/pull/442
User12: Looking
User11: Makyo, User1 I also ran into something that may have invalidated work today. Need to talk to someone about the supportedContainers attribute on machines.
User1: oh?
User1: what's the issue?
User3: and the dog has a high temp right before I leave for a trip. Go pets!
User1: poor puppy
User11: User1 got a few minutes to chat?
User1: sure 1min just got to relocate to somewhere cooler
User11: You're in Canada already.
User1: it's like 20c out there...way to hot ;) ( rick_h__ )
User1: kadams54 ok joining the standup room
User7: today, bundles don't have ability to run services on existing machine, does it?
User7: I know this is coming as part of charm store api
User1: jrwren correct
User1: bundles are just a yaml file
User1: actually
User1: that's a deployer file
User1: :)
User1: go conflated terminology!
User7: a yaml file with no to: machine node :)
User7: oh THAT juju-deployer!
User7: thanks hatch
User1: kadams54 your branch will conflict with Makyo's that just landed
User11: User1 Got it.
User1: jrwren lol np, don't worry it's confusing to people who have been working with it for a long time :)
User1: the deployer will be moving into juju-core at some point
User9: jujugui: can someone review https://github.com/juju/juju-gui/pull/443 for me?
User1: yup
User1: I can
User9: thanks hatch.
User12: Totally spaced out lunch.  Sorry kadams54, didn't mean to go awol
User11: User12 np
User1: psshhht Colorado.....
User11: lol
User12: What? D:
User1: "sorry bro I like..................totally space out.............what was I doing again?.........."
User12: Pff.  I just meant I got hungry and realized how late it was :P
User1: lol suuuure
User1: ;) ;)
User9: User1 you've got to get a new joke about colorado.
User1: "what are you 50 and run in bare feet??"
User1: how's that?
User1: that's all the stereotypes I know about CO :P
User1: jcsackett comments made - maybe if you want to check them out before I do a qa
User9: User1 looking into switching to a truthier way of doing things now.
User9: changes should be up in a sec.
User1: cool thanks
User9: User1 the only "not major" change we've got spec for is containers, unless there's a bug i don't know about.
User1: jcsackett right, I mean, the rule is that only things that cost money are in the top right?
User1: config changes don't involve $ changes
User9: User1 this whole rule is new to me, and like i said, only containers have been mentioned to me.
User9: we can add config if we're told to put config in.
User9: but until that's marching orders, i don't think we should expand this scope.
User1: ok that's cool - want to reply to that in the PR?
User9: already did.
User1: :) thanks
User1: lemme know when changes are up and I'll pull it down for qa
User9: User1 sure thing. hit one weird thing having changed to truthy
User9: User1 finally pushed up. had a surprising amount of fallout from badly structured tests.
User1: ahh, well then!
User9: well, badly is a bit strong--but brittle, anyway. :)
User1: thanks I'll take a look
User1: :)
User9: cool. i'm off to get stuff for dinner. if you run into anything QA bad i'll have to deal with it tomorrow morning, otherwise i'll rebase and :shipit: when i return if you qa ok.
User1: sounds like a plan
User1: cya
User9: lata
User1: jcsackett looks good +1, I have some issues with the UI but I sent an email off to design about them
User2: Morning
User1: mooooooorning
User1: tonight I'm going to try and convince myself web components make sense
User2: Yay!
User1: so far it's just seamed like they are going to become the next jquery plugin mess
User1: but maybe....just maybe I'll find an example which makes sense heh
User2: User1 What are you looking at exactly?
User1: huwshimi polymer/web components
User1: there are still going to end up being 200 different modal dialogue web components each adding different frameworks to the page, each with different css, aria support etc etc etc
User1: so I'm really not sure how it's going to get us further ahead than we already are right now
User1: I'm still not going to take some calendar web component which adds jquery to the page and include it in our app for example
User1: and it moves the configuration into the DOM essentially making html xml :)
User2: yeah, it definitely has an xslt thing going on.
User1: for people making web pages it's probably really awesome
User1: web apps...not so much
User1: at least that's where I'm at now :)
juju-gui
Ubuntu IRC