Repository: Cloud-CV/EvalAI
Issue: Frontend: Add validation before sending invite to other team members
GitHub labels: enhancement

frontend

good first issue

inactivity

- [ ] Handle errors (email required & email valid ) with ng-messages as it is done in auth pages.
- [x] Show notification on invitation success after closing the modal of email invite (depend on issue #482 )

@spyshiv shall I try the first one ? I just made a PR which used ng-messages. And Handle errors (email required & email valid ) for which views ?

I have reviewed your PR #593 . First complete the changes then ask for this.
Till then this is issue is open for all.

@spyshiv this is to be done for verify-email view right ?

@spyshiv  @aka-jain  Can I work on this?

sure @RishabhJain2018, Assigning it to you.

@anweshknayak : it is regarding email invitation on dashboard.

@RishabhJain2018 any update on this. This one is easier and should have been fixed by now. 

@deshraj Actually last week, I was busy with some of my college work.I am really sorry for the delay. I will fix this asap.

@RishabhJain2018 : What is the current status regarding this issue? 

@spyshiv As discussed with you, I will fix this asap.

@spyshiv @RishabhJain2018 can I try ?

Sure @anweshknayak. 

@spyshiv let me know when the notification thing is ready :)

@anweshknayak : Have you done first task which is not dependent on notification things ?
and Notification feature has been added in PR #684. 
You can start working on first task. I will let you know when the PR #684 will be merged 

sure @spyshiv. And yes I will complete the first task.

@anweshknayak: I have already completed 2nd task. 3rd task is not required now so i have removed that. So finally you have  to do only first task. Ask me for code review when you are done

@spyshiv need some help. How do I get to this view? I need to test.

@anweshknayak: Sorry I was busy.
![screenshot from 2017-02-24 14 10 29](https://cloud.githubusercontent.com/assets/7015220/23296437/0f55ce26-fa9b-11e6-8019-a3c52f064622.png)

The issue is related to make this email input required. Let me know if you can/can't get this view.

@spyshiv do I need to create separate template for mdDialog to integrate ng-messages with it ?

@anweshknayak Are you working on any other issue too?

@anweshknayak : what is the status of this issue. If you are too busy in doing other issues then let me know so that I can assign this to someone else

@spyshiv I won't be able to work on issues for a few days. Please assign to someone else. :) 

@RishabhJain2018 : can you take this up ?

@TroJan Yeah sure. Currently I am on #850 . I will take this up asap.

I think you have few issues on your plate. You can work on this once you complete the other issues assigned to you. :) 

FYI: This issue is still open. Please feel free to pick it up. Also,  tagged it as a good first issue. :) 

@deshraj Can I work on this issue?

Sure, go ahead. 

@deshraj Hey! I have done with email required. How should I proceed for checking if email is valid?

@deshraj @RishabhJain2018 I think you missed the above message. Also, do I have to do the same implementation as in done in https://github.com/Cloud-CV/EvalAI/pull/1542  by creating a separate `invite-template.html`.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.


This issue has been automatically closed as there is no further activity. Thank you for your contributions.