zhiminy/EvalEng huggingface dataset:
Repository: Cloud-CV/EvalAI
Issue: Update Facebook's logo on home page
GitHub labels: enhancement

easy_to_fix

frontend

We would like to change the Facebook's logo with the one uploaded here. 
![facebook-logo-preview](https://user-images.githubusercontent.com/2945708/30350572-41840eac-97e5-11e7-90a3-bc9808d0057d.png)


Please assign me

Sure @xamfy, go ahead. :) 

@xamfy it would be nice if you can crop the facebook logo from top and bottom so that it's of similar size as others.

Sure, I'll do that. Alternatively we can get a fb wordmark logo from https://en.facebookbrand.com/ of the same quality.

![image](https://user-images.githubusercontent.com/19357995/30386676-16f9bd1a-98c8-11e7-9a13-8f694e549f08.png)
Is this ok?

Can we please use the colored logo for VT?

> On Sep 13, 2017, at 11:41 AM, xamfy <notifications@github.com> wrote:
> 
>  <https://user-images.githubusercontent.com/19357995/30386676-16f9bd1a-98c8-11e7-9a13-8f694e549f08.png>
> Is this ok?
> 
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub <https://github.com/Cloud-CV/EvalAI/issues/1243#issuecomment-329209012>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzgoyxp9FUHChAMTe06OCcb29vkOIZOks5sh_ezgaJpZM4PVUjH>.
> 



Sir, it is already colored, while taking screenshot I hovered over it.

Ah, I see. Thanks!

> On Sep 13, 2017, at 11:59 AM, xamfy <notifications@github.com> wrote:
> 
> Sir, it is already colored, while taking screenshot I hovered over it.
> 
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <https://github.com/Cloud-CV/EvalAI/issues/1243#issuecomment-329214642>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzgo4egiN1KKNOxkQGwT1ma92fKz4hlks5sh_vqgaJpZM4PVUjH>.
> 



![image](https://user-images.githubusercontent.com/19357995/30389554-c924b38e-98d0-11e7-8c43-b22511fd11b5.png)
@deshraj Is it ok?
Repository: Cloud-CV/EvalAI
Issue: Challenge List page should not require login
Root cause: Unimplemented Feature Gap


What the title says. 

Just like the VQA challenge details are not being auth-wall, everything else should be visible as well. 

Can I take this?

@xamfy: Yeah go ahead. 

Before you start working on this, the deliverable of this issue is:

- [ ] Show the list of all the challenges whether the user is logged in or not. The UI can be similar to what we have on the dashboard for listing all the challenges.

Please let me know if something is unclear. 

@deshraj I've done the following things as of now:
1. Create a new route for all challenges
2. Create a new controller for that
3. New template for displaying the list of challenges

If the issue is still unresolved, can I can take this issue? @RishabhJain2018
Repository: Cloud-CV/EvalAI
Issue: Remove debugging statements from auth controller
GitHub labels: enhancement

easy_to_fix

frontend

**Expected Output** : Remove `console.log` statements from `authCtrl.js` so that the lint warnings are removed.

@RishabhJain2018 the ```console.log``` are in a context to show some error when occours an exception, just remove them or put something in place..

Can I take this?

@Marlysson Yes, You need to remove them & you can send the same error to the user using `$rootScope.notify`. Please let me know if you are interested in working on this.

@xamfy If @Marlysson doesn't take this up, then you can. :)

@RishabhJain2018 Yes, I do.

I will send a pull request soon..

Great ! Assigning this to you.
@xamfy Please feel free to take up any other issue.
Repository: Cloud-CV/EvalAI
Issue: Github and Twitter links are not working in dashboard footer
Root cause: Validation Gap

The Hyperlink to Github and Twitter Page is not working in Footer area of the Dashboard Page.
 
Expected Behaviour: Clicking on the Github and Twitter logo should open their respective cloudcv profile               

Observed Behaviour: Clicking on the Hyperlink does nothing.

Adding the URL in the href tag can solve the problem.




Are you working on this?

Good catch @Ayukha . Please let me know if you are interested in working on this.

 Yes i would like to work on this . @RishabhJain2018 

**Issue** : The `github` and `twitter` link in dashboard footer aren't working. Please refer [here](https://github.com/Cloud-CV/EvalAI/blob/master/frontend/src/views/web/partials/dashboard-footer.html#L8)
**Solution**: We need to create a hyperlink to them.
**Hint**: Take reference from [here](https://github.com/Cloud-CV/EvalAI/blob/master/frontend/src/views/web/partials/footer.html#L8)

Great @Ayukha . Assigning this to you. 
@xamfy Please feel free to take up any other issue from the list.

Done with the changes . Please review @RishabhJain2018
Repository: Cloud-CV/EvalAI
Issue: Frontend (angular-ui-router): State change events are deprecated
Root cause: External Dependency Breakage

**Issue:** 
In `angular-ui-router<=1.x`,  State change events are deprecated, DISABLED and replaced by Transition Hooks. So redirection and state change will not work if lnstalled version of `angular-ui-router` is `>=1.x`. 
[More info](https://github.com/angular-ui/ui-router/wiki#state-change-events)

**How to Fix:**
* change bower dependencies `"angular-ui-router": "^0.3.1"` to  `"angular-ui-router": "0.3.1"` (without `^`) so that installation will be restricted to version `0.3.1`
or 
* if we need to go with latest version of angular-ui-router then we have to replace `$rootScope.$on('$stateChangeStart', function(){ ... })` with `$transitions.onStart({...})` and also have to update bower dependency for the same.

@aka-jain @RishabhJain2018 @deshraj  

I want to do this, should I just update the dependencies?

@xamfy I think you are currently working on #1247 . Please complete that first then you can take this up as it blocks the development of the whole project. Till then it is open for everyone. :)

Can i try ? @RishabhJain2018 

@Ayukha Yes you can. Assigning this to you.

@spyshiv @deshraj @aka-jain I would prefer to go with the second approach of @spyshiv as in future many dependency conflicts can  be avoided by using the latest version of `angular-ui-router`. What do you say?

 second approach 👍 

I can give the second one a shot if @Ayukha isn't working on it. I only found three uses of the old method when I searched.

Second approach doesn't seem like a good option for now as we are using state related functions heavily in project and updation of ui router might break any functionality. We can only continue with the second approach once we are confident with the change. 
Let's stick to the same version or first list all the functions that has been depricated in current version of UI ROUTER. 
Thoughts @RishabhJain2018 @spyshiv ?


Not sure @spyshiv @aka-jain If we are planning long-term goals here, removing `^` is the solution for temporary purposes, I am in doubt that we need to maintain different packages like them too and have to restrict ourselves to the old AngularJS. 



I also agree to go with the new version but first we have to be confident about all the changes that have been made to new update. 
I've already tried out the latest version of UI router and there are lots of changes. We should only continue with the new version when all the changes and usage get listed down otherwise chances of code breakage will become high.

Let's do a small POC on this and will check wether all functionalities work fine or not with the new update. Till then let's stick to the older version.
@aayusharora

Agree @aka-jain, which UI router version have you tried ?
 

@aka-jain @RishabhJain2018 I am assigning this to me.

@Obtin : Sure!! Go ahead. 
Let me know if you face any issue or need any guidance regarding this.

You're right. Second approach.

Closing this since we don't need this issue now. Same reason: we will release Cloud-CV/EvalAI-Ngx soon :)
Repository: Cloud-CV/EvalAI
Issue: RuntimeWarning: DateTimeField received a naive datetime
Root cause: Validation Gap

This error occurs while running the tests.
See https://stackoverflow.com/questions/18622007/runtimewarning-datetimefield-received-a-naive-datetime
![image](https://user-images.githubusercontent.com/19357995/30781069-271fd94c-a136-11e7-8f19-c1997be6cd11.png)
Partial solution: change
```
when_made_public=datetime.datetime.now()
```
in tests/unit/jobs/test_views.py to 
```
when_made_public=timezone.now()
```


@RishabhJain2018  Should I fix this?

Go ahead ! Assigning this to you.
Repository: Cloud-CV/EvalAI
Issue: NoReverseMatch: Reverse for 'summary'

While running the tests following error occurs:
```
NoReverseMatch: Reverse for 'summary' with arguments '()' and keyword arguments '{}' not found. 0 pattern(s) tried: []
```
Possible fix:
Add silk urls to urlpatterns
See https://github.com/jazzband/silk/issues/74
Repository: Cloud-CV/EvalAI
Issue: Methods of model redundant implemented

In some models there are the method : ```get_attribute_model``` to get the your value, but your implementation don't there are nothing different , just a return.

There are some reason to this are implemented? And no a ```property``` ( if necessary )

@Marlysson Can you please explain the issue. I didn't get your point.

Sure.
I was analysing the EvalAI code searching something to contribute and I saw this, by example:

https://github.com/Cloud-CV/EvalAI/blob/master/apps/challenges/models.py#L67-L73

A ```get_*``` method just return the same value from model's django, then I asked because this method if haven't any implementation into them.

@Marlysson I get your point of what you are trying to say. Those methods are implemented intentionally since we want to use these methods in the future to show the start and end date time in a different way than what it is being shown now. 

Please feel free to take any other issues if you are interested in contributing to EvalAI. :)
Repository: Cloud-CV/EvalAI
Issue: Error in Running EvalAI
Root cause: Configuration Error

After the last Merge, the project is not able to work locally.
![screen shot 2017-09-26 at 7 29 17 pm](https://user-images.githubusercontent.com/12194719/30864437-365d657a-a2f1-11e7-9529-ffee7744803c.png)


@aayusharora Please update your `dev.py` file with `dev.sample.py` specifically the `INSTALLED APPS` section. I hope it will solve the issue.

@aayusharora I think the issue is resolved. Hence I am closing this. Please reopen if the problem still persists.
Repository: Cloud-CV/EvalAI
Issue: Fix team page content placement and modify hyperlinks
GitHub labels: bug

easy_to_fix

frontend

- Observed behavior

1) The heading 'Core Team' is hiding behind the navigation-bar.

![laptop](https://user-images.githubusercontent.com/22499864/30984609-67c2b564-a4ab-11e7-8831-5720caa9e1d0.jpg)

![phone](https://user-images.githubusercontent.com/22499864/30984639-7b7a8f00-a4ab-11e7-92bc-e852f1ec801d.jpg)


2) All the hyperlinks in team-cards open up in the same tab which is hindering the user-experience.


- Expected behavior 

1) The content of team page should be placed a little lower. (Adding margin-top to the content will work)

2) Hyperlinks should open up in another tab. (Adding target attribute to the anchor tag will solve this)



Good catch @geekayush .  Let me know if you are interested in working on this. :)

@RishabhJain2018 can i do this ?

@gabru-md Let's wait for @geekayush . If he doesn't take this up, then you are good to go :)

@RishabhJain2018 I would like to solve this :)

Go ahead! @geekayush 
@gabru-md Feel free to take up any other issue from the list. :)
Repository: Cloud-CV/EvalAI
Issue: Add support editing a challenge details on UI
GitHub labels: enhancement

frontend

critical

docs

priority-high

## Current Status

Currently, we have all the APIs required for editing the challenge. UI needs to be implemented so that the challenge hosts can edit the challenge on their own. 

## Deliverables

Note: There is a constraint that only challenge host should be able to edit the details on the frontend and hence the edit buttons should be avilable to the challenge hosts only.

1. Challenge host should be able to  edit the following fields:
- [x] Challenge name
- [x]  Challenge short description
- [x]  Challenge long description
- [x]  Terms and conditions
- [x]  submission guidelines
- [ ]  start date
- [ ]  end date
- [x]  evaluation script

2. For a challenge phase, following fields should be editable:
- [ ] phase name 
- [ ] phase description
- [ ] start date
- [ ] end date
- [ ] test_annotation file (Open a dialog box showing warning "Do you really want to do this? " Also, ask the host to enter the phase name here to make sure that he/she is not drunk while doing this)
- [ ] max submisasions per day
- [ ] max submissions

Note that this is a big issue and can be submitted as two different pull requests: one for editing the challenge details and the other for changing the challenge phase details. We want to add support for editing more meta details of the challenge and we would like to do that once we have these features in place. 

@deshraj I would like to take lead on this.

Sure. Assigning it to you. 

@deshraj Please take a look at the UI.
![cancel1](https://user-images.githubusercontent.com/12206047/31058004-333bc70c-a70a-11e7-8277-eec6c129d6c8.jpg)


Challenge description will be really long so it would be nice if you can increase the width and height of the dialog box. Rest this looks good to me. 

Currently, I am doing the First part(`Editing Challenge`) of the issue, **the second part is still open to everyone**, as we will have two PR's for the same issue.
Please make the UI as shown in the above comment.
Let me know if there is any problem.
Repository: Cloud-CV/EvalAI
Issue: Show a loader when a challenge zip configuration is submitted
Root cause: Unimplemented Feature Gap

## Current Status

When a host tries to upload a challenge zip configuration and the zip config is huge file, then he has no clue that what is happening at the backend: whether the file is being uploaded or not. 

## Deliverables

We would want to show a loader till the request is completed. 



@deshraj  I'm working on it.

If nobody is working on this issue can I work on this?


@deshraj Fixed it.

Sorry guys for not being responsive. Seems like this is already fixed. Thanks @adamstafa
Repository: Cloud-CV/EvalAI
Issue: Add a boolean field to challenge to make it featured challenge
Root cause: Unimplemented Feature Gap

## Current behavior

Currently, the first challenge is considered as the featured challenge on EvalAI. We would like to change this and the admin should have the functionality to choose which challenge should be featured challenge. 

## Deliverables

- [x] Add a new field in the challenge model which makes a challenge featured
- [x] Don't forget to name the migration

Hi sir, can I take up this issue?

@sehgalayush1 sure, go ahead. :) 

@deshraj Please clear something for me, You want the default value of the featured field to be false right?

Also, should i just push the new code in the master of my fork and create a PR or should I create a new branch?

@sehgalayush1 Please make a new branch for that

Reopening this issue since one part of this issue is still not resolved. 

@deshraj Which part is still left?

Sorry, this one is done. Closing again.
Repository: Cloud-CV/EvalAI
Issue: Change the logic to show featured challenge
Root cause: Unimplemented Feature Gap

## Current behavior

Currently, the challenge whose primary key is 1 is shown as the featured challenge on EvalAI. We would like to change it and show the challenge which has the featured challenge flag set as True in the database.

## Dependency : #1290 

## Deliverables

- [ ] Update the get challenges API to add support for the filtering the featured challenges as a query parameter "featured=True"
- [ ] Update the controller to fetch the featured challenge instead of fetching the first challenge
- [ ] Write unit tests for the updated API endpoint

Also, this depends on #1290 

@deshraj I'm done with #1277. Can I work on this?

@deshraj @xamfy Actually since this issue was related to #1290 I already started working on this as I am finished with #1290 . So should I go through with this?

@sehgalayush1 @xamfy Since this issue requires both front-end and backend changes, we will break it into two PR's.
1. For updating the API and writing its tests.
2. For updating the controller and the view.
Since both of you are interested in working on this. Please let us know which part you are working on. :)

@RishabhJain2018 first one

@RishabhJain2018 I'll work on the second one.
@xamfy Please add a /challenge/featured route in the get_all_challenges API, so that only challenges that have featured=True can be fetched and I'll modify the controller to fetch challenges from that url and display them.

Awesome!

I see!!

Can I work on this?

@codervivek sure, go ahead.
Repository: Cloud-CV/EvalAI
Issue: 'Dataset split with that codename already exists' error 
Root cause: Validation Gap

## Current Scenario

When a user creates a challenge using a zip configuration that has some dataset split codename, then the challenge is created successfully. If he tries to create a similar challenge with similar dataset split name then he gets an error that `Dataset split with that codename already exists` which should not happen since different challenges can have same dataset split codename. 

## Deliverables

- [ ] Remove `unique=True` from DatasetSplit's codename field
- [ ] Set unique_together `pk` and `dataset_split` in Challenge phase model
- [ ] Don't forget to name migrations


@deshraj can you explain the second point of Deliverables

@deshraj I'm quite familiar with this error, can I look into it? :smile: 

Sure @isht3. :) 

I think we @isht3 have already completed this. Hence, closing this.
Repository: Cloud-CV/EvalAI
Issue: Increase the data upload limit.
Root cause: Configuration Error

## Current Behaviour
By default django supports only 2.5 MB of the data to be uploaded on the web app. Refer [here](https://docs.djangoproject.com/en/1.10/ref/settings/#data-upload-max-memory-size) for more info.

## Effects
Due to the low upload limit the file in challenge creation using zip isn't being uploaded on the app as the size exceeds.

## Expected Behaviour
The upload limit must be increased to 10MB.

Hello! I took the task

@memclutter Go ahead! :)

Edit: there are challenges where the challenge configuration file is of more than 100MB. We would like to update the size to 500MB

My PR #1310 increases the max file upload size to 500MB.
Repository: Cloud-CV/EvalAI
Issue: Add cancel button in update submission metadata
GitHub labels: enhancement

easy_to_fix

frontend

## Current Behaviour
The update submission is a modal form which has only submit button to submit and it can be disabled using the `Esc` key. Please see the screenshot.
![cancel](https://user-images.githubusercontent.com/12206047/31057087-5bc6995a-a6fa-11e7-84e3-21307119df3c.jpg)
## Expected Behaviour
We need to add a cancel button near the submit button so as to make the disable feature more user-friendly.
Please let us know if something is unclear.
Repository: Cloud-CV/EvalAI
Issue: Add challenge filtering using featured parameter.
Root cause: Unimplemented Feature Gap

We need to add filtering in challenge model on the basis of `featured` parameter.

@RishabhJain2018  this sounds interesting. Can you provide more details?

@pohzipohzi Currently the challenges are filtered in django admin using [these](https://github.com/Cloud-CV/EvalAI/blob/master/apps/challenges/admin.py#L18) fields. We need to add `featured` field to it.
Please let me know if you need more help.

@RishabhJain2018 I made a PR based on my understanding of what you posted
Repository: Cloud-CV/EvalAI
Issue: Add instructions to update settings.dev.py in Docker Installation section
Root cause: Documentation Deficiency

## Deliverables

- [ ] Add a section to add instructions about renaming `dev.sample.py` to `dev.py` in the docker installation section in docs. See https://github.com/Cloud-CV/EvalAI/blob/master/README.md (4th point of installation instructions) for the text to add. 

Pointed out in #1286 

I can work on this.
Repository: Cloud-CV/EvalAI
Issue: Remove models from Accounts app
GitHub labels: enhancement

easy_to_fix

backend

priority-low

**Expected Behaviour** : Remove the `Affiliation` and `UserAffiliation` model from the `Accounts` app.
**Deliverables:**
- [ ] Remove the `Affiliation` and `UserAffiliation` model from accounts app.
- [ ] Create and name the migration.


I'll pick this one up


@markslingerland sure. Assigning this to you!

@RishabhJain2018 can I look into this?

@markslingerland is working on it. @HargovindArora Please take up any other issue from the list. :)

Sure @RishabhJain2018 .

@deshraj @RishabhJain2018 Working on it!
Repository: Cloud-CV/EvalAI
Issue: Adding respective organizations links to the images and footer improvements.

![screenshot from 2017-10-10 02-18-30](https://user-images.githubusercontent.com/22341493/31400054-e7163dc2-ae0b-11e7-9b2d-bbdacbbe1c7a.png)

On the homepage of EvalAI, the section containing the list of Organizations that use EvalAI should have clickable links to their respective website pages so that any user can see what that organization does and that organization's particular information.


![screenshot from 2017-10-10 02-22-16](https://user-images.githubusercontent.com/22341493/31400081-fba5b268-ae0b-11e7-8473-974805cba712.png)

The EvalAI and CloudCV logos should also be links to the respective website page so that a user can navigate to the website from any particular page of the website through footer too.


![screenshot from 2017-10-10 02-22-39](https://user-images.githubusercontent.com/22341493/31400184-4cad2880-ae0c-11e7-94da-14a8f228ab13.png)

The Dashboard footer does not contain the CloudCV logo on it. I think the logo must be present there.

Hey anyone please review it. Should it be done? :smile: 

@HargovindArora I missed it . I will do it by tonight.

@HargovindArora closing this issue since we don't want to have the link to images of different organizations. I removed it intentionally in my previous pull request. 

Ohkay . Got it @deshraj :smile:
Repository: Cloud-CV/EvalAI
Issue: Stop showing success message for unregistered E-mails while resetting password.
Root cause: Validation Gap

## Problem
When we try to reset password, it asks us for our Email to send the link. Now after we click submit, even if the email is not registered, it still says reset link sent.

![](https://image.prntscr.com/image/-xQ-2t8VRWSUocZt0exp9Q.png)

![](https://image.prntscr.com/image/uSew-wojRB6GoRY9HziKVQ.png)

What I noticed from other sites were that, It should be actually be saying the email is not registered if it is not present, so that the user knows whether they typed in correct email and avoids hassles.

I'd like to hear your views. :smile: 

This is being handled by Django allauth so that the email id of registered users shouldn't get exposed. Hence, we don't need this feature. 

@deshraj Okay, cool. :smile: