yashsingh1/xdaforums huggingface dataset:
[EVO 4G Themes and Apps] spiicytuna:
I'll talk to someone who knows for sure in the morning but it looks like this is the trick:

"Commit files to branch: git commit -a; The commit command transfers your staging area into the current branch. The -a option tells it to automatically stage any modified or deleted files (but not newly added files), and commit those. This is generally the easiest way to commit your changes, if you know you just want to commit all of your current work. For more complicated situations, you can use the git add command as described above, or git commit --interactive to invoke the same interactive editor as available in git add. An option for those that are command line impaired is git gui."

Taken from here: http://groups.google.com/group/repo-discuss/web/repo-gerrit-git-workflow?pli=1

Also check this out from the Cyanogenmod team: http://wiki.cyanogenmod.com/index.php?title=Howto:_Gerrit

(scroll down to: "Submitting Changes")

Submitting Patches

Patches are always welcome! Please submit your patches via CyanogenMod Gerrit! You can do this by using these commands:

(From root android directory)

. build/envsetup.sh

(Go to repo you are patching, make your changes and commit)

cmgerrit <for(new)/changes(patch set)> <branch/change-id>

repo start gingerbread .

(Make your changes and commit)

repo upload .

Note: "." meaning current directory For more help on using this tool, use this command: repo help upload

Make your changes and commit with a detailed message, starting with what you are working with (i.e. vision: Update Kernel) Commit your patches in a single commit. Squash multiple commit using this command: git rebase -i HEAD~<# of commits>

To view the status of your and others' patches, visit CyanogenMod Code Review

.
[EVO 4G Themes and Apps] mwielgosz:
Thank you for your response.

The way I originally submitted it was basically copy and paste from the CM Wiki. I think the trick is to add everything, then commit. When I committed, I added one file, committed it, repeat.

I should be doing:

git add path/to/file1

git add path/to/file2

git add path/to/file3

git add path/to/file4

git commit -m 'Description'

git upload path/to/project

This was taken from here:

http://library.edgecase.com/git_immersion/

Specifically:

http://library.edgecase.com/git_immersion/lab_07.html

I think that's the right way to do it but I think I'll wait until tomorrow when you can confirm the true way to commit this. I don't want to commit it wrong again lol.

Thanks very much for you're ongoing help!
[EVO 4G Themes and Apps] spiicytuna:
Well here's what they say on irc in #cyanogenmod:

[00:29] <@ciwrl|away> Sucalakafufu question isnt how to submit
[00:29] <@ciwrl|away> its how to get multiple changes as one commit
[00:29] <@ciwrl|away> :p
[00:29] <Sucalakafufu> ah
[00:29] <spiicytuna> Sucalakafufu - ya what ciwrl|away said
[00:29] <Sucalakafufu> that's different
[00:29] <Sucalakafufu> pfft
[00:29] <spiicytuna> lol
[00:29] <@ciwrl|away> git rebase, then do the git add, then 1 single git commit
[00:29] <@ciwrl|away> should work
[00:30] <spiicytuna> so: git rebase, git add path/to/file1, git add path/to/file2, git add path/to/file3, git add path/to/file4, git commit -m 'Description', git upload path/to/project
[00:30] <@ciwrl|away> yea
[00:30] <spiicytuna> we dont want to do it wrong again...
[00:30] <@ciwrl|away> hehe, no harm
[00:31] <Sucalakafufu> lots of people dont know how to use gerrit well
[00:31] <spiicytuna> Sucalakafufu - so the syntax I posted was right?
[00:31] <spiicytuna> :P
[00:32] <Sucalakafufu> seems so to be
[00:33] <ciwrl|away> From my logs: <@cyanogen> git rebase <@cyanogen> or yeah <@cyanogen> add the files <@cyanogen> 1 commit <@cyanogen> more information here, I gotta run: http://source.android.com/source/submit-patches.html
[00:38] <@cyanogen> rebase lets you rewrite history, but yeah. you want to add all of your files and then commit them at the same time.

That's as official as it's gonna get since the man himself chimed in. :) Commit!!! :)

.
[EVO 4G Themes and Apps] mwielgosz:
Ok well I completely get how to commit it correctly now. Just one issue...

When I run the 'git commit -m 'Description' it displays the status. It should show that it has files to update. Currently, the original commit is still there. How do I delete the original commit and basically start fresh again?

mike@mike-laptop:~/android/system/packages/apps/Mms$ git commit -m 'Added SMS Split by encoding and counter at end of message with settings.'
# On branch gingerbread
nothing to commit (working directory clean)
[EVO 4G Themes and Apps] mwielgosz:
Holy **** I finally got it!

Ok, onto really seeing if this will get included lol.

Thanks everyone who had input :) You guys/gals rock

http://review.cyanogenmod.com/#change,3305
[EVO 4G Themes and Apps] 94tbird:
Tried downloading fro mthe link in the OP for the newest version and it isnt working on my work or home pc.

Also on a side note, does anyone set the background to black, and then for no reason have it change back to white occasionally and randomly?
[EVO 4G Themes and Apps] JOEOZUNA4U:
this works great on cm7/wimax
[EVO 4G Themes and Apps] spiicytuna:
\o/

.......
[EVO 4G Themes and Apps] jakejm79:
Depending on when and if you have rebooted/last cleared Dalvik-Cache, it may or may not be there.

Another simple way is to replace the Mms.apk in the ROM before flashing then just disable ROM signing (or resign it, when you flash it).

I also created this zip file, tested RA recovery it isn't signed so you have to disable signing checks. I couldnt get it signed, but then again I haven't really signed anything since my HeroC days.
[EVO 4G Themes and Apps] jamsterzak:
Goodcall on the flashable zip..if u have the sdk tools or 7zip..all's u have to do is right click on the zip and click sign:)
[EVO 4G Themes and Apps] jamsterzak:
Ftw! excited to see this
[EVO 4G Themes and Apps] jakejm79:
Yeah I don't have either, I was using a modified version of signapk.jar and java to do it, but didnt seem to work like it did when I was doing Hero zips/apks. Feel free to resign and post.
[EVO 4G Themes and Apps] spiicytuna:
Looks like cyanogen's only complaints were OCD related... he likes lowercase for second word, first letter, in strings :p;):D Oh, yeah, and your last upload links (depends) on previous code which he mentioned. BUT all of that said looks like it will make it in! w00t!

Edit: w00t! He fixed it for you: http://review.cyanogenmod.com/#change,3316
[EVO 4G Themes and Apps] spiicytuna:
\o/

It's in! Will be in tonights nightly!!

http://twitter.com/#!/cmsrc/status/40159100650262528
[EVO 4G Themes and Apps] mwielgosz:
Win!

Now onto adding blacklisting. :) thanks everyone!
[EVO 4G Themes and Apps] DomSim:
well this was cool to see start and now get incorporated, congrats OP!

Works well for me, tested large sms and all came through. also tested on 4g and worked fine. mms worked fine as well.

i also would request having the message counter at the beginning of the text instead of at the end if possible. thank and keep up the good work!
[EVO 4G Themes and Apps] spiicytuna:
In my opinion, the best bet for blacklisting may be to tie it to the already existent blacklist for incoming calls (Settings > Call Settings > Blacklist). That's just my $.02 after seeing how ocd cyanogen is—and if you look at the open projects on gerrit a lot are still open because the coder has been asked to tie into existing CM7 menus/options/settings.
[EVO 4G Themes and Apps] jamsterzak:
\°/..big win tonight

^ spiicy.. i concur...it seems that would be the easiest way..

@mwielgosz- ill be out of work at 9est..ready to be a testbot/help in anyway :)
[EVO 4G Themes and Apps] Jason Black:
Love it!

Thanks for making the app useable .
[EVO 4G Themes and Apps] mdubs:
Awesome! You take on the task and two days later it is getting merged into CM7!

You are a wizard sir. Handcent can now go sell some other schmucks data instead of mine!

Can't wait for blacklist too.
[EVO 4G Themes and Apps] jamsterzak:
Probably can do it from ur phone these days lol..I love signapktic app, it rules..stericsons the man
[EVO 4G Themes and Apps] DomSim:
Just had a weird happening, sent a long text with a couple of urls in it, the last text was one word and a url. The "(2/2)" text count was then made part of the URL. All but the last parnethesis, like this http://xdaforums.com/showthread.php?t=948109(2/2) maybe an easy fix, just add a space before the text count I would think?
[EVO 4G Themes and Apps] jgalan14:
It does that on regular sense sms app so is normal
[EVO 4G Themes and Apps] mwielgosz:
I've thought about tying it into the existing blacklist options available in the call settings menu. The only thing that I'm concerned about is it being slightly confusing for the user. If you want to blacklist something in the text messaging program, normally you would find such an option in the settings to the messaging program itself. Also, what if you wanted to allow calls from one number but allow texts from the same number? That option wouldn't be possible without modifying the Phone app itself.

The good side to having the options apply to both text and phone is that it would be much easier to implement and it's less options for the user to get tangled up on overall. Maybe having blacklisting in two places would be confusing?

I would love to hear some input from people on this matter. Which option would you prefer? In the end, the call settings blacklist description could be changed to reflect that it affects text messaging as well. Let me know what you would prefer. Maybe a poll is in order :cool:
[EVO 4G Themes and Apps] matt2053:
Perhaps adding it to Phone Googles? Or is Phone Goggles meant to strictly limit outgoing communications?

EDIT: Nevermind, I actually hate that idea now.
[EVO 4G Themes and Apps] mwielgosz:
Originally, I had it configured to add a space before the counter. Then I noticed the following:

Each of the messages sent when splitting was 153 characters. This leaves 7 characters open before the network will not accept the message

If you are sending a message with 10 or more pages, the number of characters required to send with a counter would be 7 "(00/00)"

Therefore, if I did add a space at the end and you send a text over 10 pages with the counter enabled (rare but possible), the counter string would be 8 characters making the total message length 161 characters.

The network would refuse this message and we would be back at square one :)

I would absolutely prefer to add the space, not only for the issue you experienced, but just for the look of the messages itself. It's just not that simple
[EVO 4G Themes and Apps] DomSim:
Sounds f'n complicated! Would the same problems persist if the counter was at the beginning instead of the end? I would assume so. Oh well, its a very uncommon occurrence.
[EVO 4G Themes and Apps] mwielgosz:
Whether the counter is at the beginning or end of the message, adding a space would still cause the above mentioned issues.

I may add the option to have the counter at the beginning or end eventually.
[EVO 4G Themes and Apps] plmiller0905:
I can't get this to work properly. I copied MMS.apk to /system/app/, changed the permissions.

I didn't have the " /data/dalvik-cache/system@app@mms.apk@classes.dex "

so I skipped that step.

I deleted " /data/data/com.android.mms "

rebooted

then when the phone comes back on,i attempt to send a long text and it still gets stuck at "Sending"

I also tried the zip also with the same results.
[EVO 4G Themes and Apps] mwielgosz:
Did you enable the options in the MMS settings?
[EVO 4G Themes and Apps] plmiller0905:
I'll give that a try now...thanks for the quick reply too
[EVO 4G Themes and Apps] spiicytuna:
You could just download tonights nightly and everything will work correctly out of the box.

Cheers!
[EVO 4G Themes and Apps] jamsterzak:
+1 Brilliant :)
[EVO 4G Themes and Apps] jamsterzak:
Sounds like you have a If-then-else situation going on...

just spaghetti code it and see what happens..:p
[EVO 4G Themes and Apps] thoughtlesskyle:
congrats on the merge, i will keep this as part of the android EVOlved project, till the next RC then (i will also keep an eye on this thread and update it as needed)
[EVO 4G Themes and Apps] spiicytuna:
Sounds like you still need to vote haha
[EVO 4G Themes and Apps] mwielgosz:
hey, hez a funni guy!

lol that's EXACTLY what I have going on!
[EVO 4G Themes and Apps] jamsterzak:
Haha..just by preference,not work involved lol..the ocd in me says I'd prefer it in mms settings..but all in all it wouldn't bother me wherever it ends up:)

Lmao I really hate that situation...it leads me to facepalm /hair removal
[EVO 4G Themes and Apps] spiicytuna:
Well couldn't you just make it so when you clicked menu > settings in the sms app that there was a line item that linked to Settings > Call Settings > Blacklist.... know what I mean? That way the user ends up in the same place but doesn't get confused as to how they got there.

Kinda like this crappy 10-second drawing:
[EVO 4G Themes and Apps] jamsterzak:
+1 mischievous...I like it..and the drawing:eek:
[EVO 4G Themes and Apps] mwielgosz:
In the end I do think this would make the most sense. I'm also going to have to decide if when blacklisted, should we still receive the message but not show it (which I believe, in theory, would keep compatibility with sprint vvm) or just reject it or receive then delete...I think I'm going to have to sort through the phone app and see how it handles blacklists.
[EVO 4G Themes and Apps] spiicytuna:
Right now I use an App from the market that deletes the sms before it shows up in my sms history, and obviously without an alert--vvm works too. It works quite well actually, but its another thing running taking memory hence my push for this.

Sent on the go from my HTC EVO
[EVO 4G Themes and Apps] mwielgosz:
The same reason I started this is the same reason you want blacklisting. To use less memory. Before, I had handcent set up to look exactly like stock mms...just with splitting. Now there's no need for that pos app.

If that's how the other app works, and it works well, that's more than likely how it will get done. Good input
[EVO 4G Themes and Apps] jamsterzak:
Good observation ..didn't think of it as received but not shown..

*whitelist?

*This would be sweet to implement in:Long press on contact to blacklist

blacklist_sample.txt
[EVO 4G Themes and Apps] spiicytuna:
Dev gives and inch and you want a mile ;-) hahaha j/k
[EVO 4G Themes and Apps] DomSim:
I vote for spiicy's implementation but with a bit more, modify the phone blacklist options to give you a check list when you add new numbers. One check box for block calls, and one to block texts so you can block either or or both for any number. Then I think all parties will he satisfied. Cyanogen since it uses an existing database, uses since the option is reached from the SMS menu, and nit pickers who need as many options and controls as possible. Also if this checklist option was prompted anytime a number was added to the list,I would think the above request by jamsterzak would be satisfied.

Btw I have no idea how to do any of this or if its even possible so please forgive me if I have thought of a stupid "un-doable" idea. Thanks for all the hard work!
[EVO 4G Themes and Apps] sarahlegs:
That is SO RIGHT!
[EVO 4G Themes and Apps] IOInterrupt:
Great news!!!!

I know this is a completely different beast, but it's the only thing that the stock messaging app is now missing (thanks to you).

Do you think there would be any possibility of adding an option for splitting group messages? Essentially, what Handcent does with the "Send as split threads" option?
[EVO 4G Themes and Apps] timtlm:
I say you keep it simple at first and just create a blacklist within the messaging app itself. The existing blacklist exists under call settings, which really is separate from messaging. However, if you choose to go the route of using the existing blacklist (or cyanogen requests you do), I would say blocking both texts and calls is sufficient without adding all that complexity. I can’t think of any situation where you would want to block one and not the other. However going the first route would give that ability, and probably be the easiest to implement.
[EVO 4G Themes and Apps] mwielgosz:
Correct me if I'm wrong but youre asking when you send a message to more than one contact, have the option to split?

Although I haven't tested it myself, if you send to more than one contact with splitting enabled, my mod will split the message and send it to each contact.

If I'm not responding correctly, let me know.
[EVO 4G Themes and Apps] IOInterrupt:
It doesn't really have anything to do with message length. For example if I send a message to 5 people it would group the original message with their chat history instead of creating an entirely new message thread for the group message. I'm not sure if that makes sense or not.
[EVO 4G Themes and Apps] paulieb81:
I haven't tested your app yet but have been following it everyday, I will when it is in the next nightly I flash. However I do hope it has this feature, I hate sending a text to multiple people and then it shows that as a thread by itself instead of adding the message to each contact thread. Great work on the app so far, I am really looking forward to ditching handcent.
[EVO 4G Themes and Apps] mwielgosz:
Well, when you send a multi contact text, it puts it on one thread instead of placing in each contact. This is how the app works by default and is not something that I modified.
[EVO 4G Themes and Apps] paulieb81:
Correct, i was trying to mention i hate how it does that and will love you forever if you could correct that! :)
[EVO 4G Themes and Apps] mwielgosz:
It definitely annoys me two. For instance, if you send the same question to two people, when one of them responds, it ends up in that one contact's thread. If you ever went back to look at the question you originally asked, you would have to find the multi contact thread.

I will look into it.
[EVO 4G Themes and Apps] paulieb81:
You are the man!
[EVO 4G Themes and Apps] mwielgosz:
As far as the Blacklist feature goes, I think that spiicytuna is correct in saying that cyanogen would probably prefer it to run off of the existing Blacklist database. He also suggested that I link the MMS settings to the Blacklist settings, which also makes sense. This would basically combine both of the ideas into one...the user sees the blacklist settings in MMS (so they don't get confused as to where to look for the settings) AND it links to a database that already exists therefore making the memory footprint less than it would be if I created a new one.

I'm 99% sure that this is the way I'm going to go with it.
[EVO 4G Themes and Apps] paulieb81:
Sounds like a good idea, from a fellow programmers point of view, that is what i would recommend also.
[EVO 4G Themes and Apps] spiicytuna:
w00t! Good deal! I'm excited now...
[EVO 4G Themes and Apps] twister99403:
quick question, yes i'm being picky lol but everytime I restart my phone the option to split the messages I have to click again...is there a way to save that so it doesn't reset on reboot?
[EVO 4G Themes and Apps] mwielgosz:
If you haven't flashed either nightly 5 or 6 (which now includes WiMAX :D) you need to follow the instructions in the OP to a T. If you don't have the permissions set correctly and you didn't delete the old app files, saving your configuration will be impossible.

Once you have followed the installation instructions and reset your phone, you can test that the settings hold by checking the boxes and then Force Stopping the Messaging app. If the boxes are still checked when you reload the app, you're good to go.
[EVO 4G Themes and Apps] twister99403:
OH HAHAHA SORRY ! total noob mistake...once I actually followed instructions, imagine that ! it worked ! thanks man :):D
[EVO 4G Themes and Apps] matt2053:
For blacklist, what about if you go to Menu > Settings > Call Settings > Black List > Add Number, below the number field, two checkbox toggles: Block Calls and Block SMS/MMS. You could check or uncheck either one. Both functions would be in the same list.

EDIT: Well, ****. Looks like that's already up in da poll and everything. Duh.
[EVO 4G Themes and Apps] IOInterrupt:
Awesome! That's exactly what I was referring to!
[EVO 4G Themes and Apps] nttdemented:
Just stumbled upon this thread while downloading the latest CM7 nightly to format everything and start fresh. Gonna test it out as soon as my phone boots up again! Thanks for this!!

Any idea when this will be included into the CM build?
[EVO 4G Themes and Apps] jamsterzak:
Just a weird instance I ran into..not really sure why it does this ..but to sum it up..

*symbols in texts..once applied it seems to use a lot of characters..but when used by itself, it counts only as one character.

*anyone?

*sorry for pic size I'm doing this via mobile
[EVO 4G Themes and Apps] jamsterzak:
It's already in:)

..latest nightlys... 5 and above..so you have it already I presume ..haha
[EVO 4G Themes and Apps] mwielgosz:
It has already been merged into CM nightlies as of #5
[EVO 4G Themes and Apps] mwielgosz:
Thanks for letting me know about this, about to test it myself now and see if I can tell whats going on.
[EVO 4G Themes and Apps] mwielgosz:
It seems that any special character takes up a bunch of characters to send. There is no (c) in the alphabet so it would have to send a string that represents the character. When received by another phone, it would translate it back into the correct special character.

The weird thing is that the app splits the message at a strange interval. Every 67 characters instead of the normal 160. This (like the normal 7-bit 160 character messages) probably leaves a few open characters at the end of a message for the network to append some kind of data making the maximum number of characters supported 70.

Taken from:

http://en.wikipedia.org/wiki/SMS#Message_size

"Depending on which alphabet the subscriber has configured in the handset, this leads to the maximum individual short message sizes of 160 7-bit characters, 140 8-bit characters, or 70 16-bit characters (including spaces)."

When sending a special character, I bet it encodes the message using 16-bit characters instead of the normal 7-bit alphabet. Still though, when adding the counter, it puts the number of characters per text sent at 72, which would be over the maximum...but I bet if you added the number of bits it took to make a special character to the number of bits required to make your message, it would probably be around 160 characters, which is the true network limit.

The code in the MMS app uses android libraries to split the message at specific intervals based on the encoding used. Therefore, if you send a message with a special character, android would split the message using 16-bit encoding therefore making the maximum number of characters per text 70...making the message look funny.

It's probably better off that it did this. If it decided to split the message based on how many characters were in the text (counting special characters as 1), when you sent the text and the phone encoded the special character to a longer string, it might go over the limit and fail to send.

If that makes any sense....
[EVO 4G Themes and Apps] jamsterzak:
Sure did!:) thxs for the info..I agree its probably better that way..
[EVO 4G Themes and Apps] -shift-:
@mwielgosz

i'm just catching up with all the commits and wanted to give you props for getting this particular issue resolved. it's good to see coders chipping in and contributing :)

awesome work and hope to see more of your contributions!
[EVO 4G Themes and Apps] Saturn2K:
I just wanted to thank you again for doing this. I finally got a chance to try it with a new Cm nightly, and it works great.
[EVO 4G Themes and Apps] jaydeebee24:
sorry if this has already been addressed, but does this only support cm7? or wouldnt it work on something like myns roms.
[EVO 4G Themes and Apps] Jason Black:
I believe all asop roms.

Sent From My CM 7 Nightly #7 (Mixer theme) Monster Evo.