yashsingh1/xdaforums huggingface dataset:
[Galaxy S I9000 Android Development] Arkanius:
Just tested it and in fact, yeah, the pops disappear when Wifi is off

That's just sloppy engineering, how come the "audio" section of the phone isn't properly shielded? That or it's a software problem since people said it was fixed in 2.1 and returned again in 2.2

Poor Pandora and Spotify users...
[Galaxy S I9000 Android Development] vzoltan:
it has "pop" on every stock rom without installing your kernel(even on samsung galaxy 3 not just on S ), i guess its a samsung driver issue, not voodoo.

(try (just for testing) it on MONO pop-sound will disapear.)
[Galaxy S I9000 Android Development] supercurio:
There are also a lot of users not having any trouble, remember a forum act as a magnifier in some very specific issues ;)
[Galaxy S I9000 Android Development] kletiz:
a2dp bitpool

I would gladly donate $20USD for we could get the bitpool change to 54. It definitely seems that Cyanogen based ROMs are the only one with the 54 as the bitpool.

I've done some pretty thorough research on how to fix this and not being a developer makes it difficult.

Some resources I've come across...

http://xdaforums.com/showthread.php?p=9281971

http://code.google.com/p/android/issues/detail?id=9888 <--star this and we can vote it to the top so google finally recognizes it!

http://xdaforums.com/showthread.php?t=866393

http://permalink.gmane.org/gmane.comp.audio.pulseaudio.general/8086

http://gitorious.org/pulseaudio/mai...0772e626b3e71fa4d7b7cbd5de5e7?diffmode=inline

I tried asking how they did it in their IRC channel and got no response. :(
[Galaxy S I9000 Android Development] Arkanius:
Which makes me afraid it might be a hardware problem :(
[Galaxy S I9000 Android Development] supercurio:
Yes, but it doesn't mean there is no solution or at least workarounds. I have already one in mind.
[Galaxy S I9000 Android Development] kiazand:
can i run this on my samsung galaxy s from tmobile SGH-T959...i am not sure if its a i9000 or not because in my phone it says . SGH-T959 model number.
[Galaxy S I9000 Android Development] supercurio:
You can use Dragon Kernel for Vibrant, I suggest you read the instructions attached.

http://xdaforums.com/showthread.php?p=10542408#post10542408
[Galaxy S I9000 Android Development] MildWildChild:
it rocks!!! thanx for sharing ~~~
[Galaxy S I9000 Android Development] mengsuan:
I think that higher gain may introduce more hiss and pops. I find better sound quality by reducing the amplifier's gain but putting music player's volume to maximum.

The theory, PCM software volume control will reduce approximately 1 bit of resolution in exchange of -6dB of volume attenuation. Letting the hardware gain take over the attenuation should be better.

Higher hardware gain would as well amplify any noise present in the circuit. I.e. Interference from wifi would be audible. SNR will reduce at non optimal high gain settings.

However high impedence headphones needs the voltage swing from the high gain to produce decent volume. The working solution at the moment is to use an external headphone amplifier and use lower gain setting on the phone. Otherwise, we need a solution to get rid of the pops, then we can raise the gain for the high impedence headphones we have.
[Galaxy S I9000 Android Development] supercurio:
Thanks mengsuan, that's exact.

I added a quick guide to the first post that explain how to get the best sound quality.
[Galaxy S I9000 Android Development] Arkanius:
I do that as well, digital volume is at max and I control the volume with the Analogue amplification slider. I do this as well with my PC since I use an external amplifier

Say curio, have you thought about including a widget for controlling the amplification volume directly from the Launcher?
[Galaxy S I9000 Android Development] mengsuan:
I have a wild idea. Max out all the digital attenuator internally within a kernel. Then map the volume rocker to adjust the hardware gain directly. Best SNR or highest volume in your fingertips. Profit!
[Galaxy S I9000 Android Development] Arkanius:
That's what high end PMP like the Cowon's do I think
[Galaxy S I9000 Android Development] supercurio:
I believe you will be pleased by one of the very next feature ;)
[Galaxy S I9000 Android Development] mengsuan:
Yes. Some amplifiers adjusts the gain on the fly by design.

Asides from the pops when wifi is active while driving high impedence headphones, SGS has top of the line audio quality I could ask from a mobile phone.
[Galaxy S I9000 Android Development] mengsuan:
Oh yes, please surprise me!
[Galaxy S I9000 Android Development] eeyunopper:
lol, made my day :D:D
[Galaxy S I9000 Android Development] xbeater:
Ok well im feeling a bit more optimistic about the pops dissapearing.

The strange thing is, I never use WiFi anymore since I got data. Do you think 3G could have the same effect? Actually, why the h*** am I asking I should just go try and figure that out!

Regardless, I will try and get a recording of the pops online soon, just don't have time to put together a cable now. Loads of school work.
[Galaxy S I9000 Android Development] gicgi:
i see future in this.

if u add higher volume options for earphones-speaker (like mixget), equalizers and mic gain control to your next version, that would be great.

can u solve "radio cant be played without earphones" thing?
[Galaxy S I9000 Android Development] supercurio:
Speaker volume can be set to much higher values that what's accessible through alsa/mixget/Audioboost, but the quality is not here anymore, and also the speaker can burn.

This is the reason why Speaker volume boost is not top priority now, but eventually I will provide improved settings if they are worth it.

Radio needs something connected to the 3.5mm jack because it's the antenna ;)

But it doesn't prevent you to switch to the speaker via the dedicated button in the FM app
[Galaxy S I9000 Android Development] tobiasth:
one of the most important sentence ....

some people don't know this! ....
[Galaxy S I9000 Android Development] CLANK10:
@supercurio and other mates:

I have an asian gt-i9000 fw 2.2, baseband and build = JPE (latest fw, Kies doesn't have 2.2.1). I was using voodoo stable 5.0.1 and now flashed stable 5.1.

If I want to flash an euro JPY fw 2.2.1, do I need to disable anything or just flash over with odin? Tks for helping me.
[Galaxy S I9000 Android Development] BronzedDroid:
Just a question. I am using the latest speedmod k12l (don't hate me), which supposedly has integrated your sound fix. Everything works and I love it, but I was just wondering what would happen if I used your app with another kernel, e.g. stock samsung kernel. Would the app give a warning? Would the anolog volume slider work?
[Galaxy S I9000 Android Development] mike.sw:
it won't show you the slider if it won't recognize supported kernel.
[Galaxy S I9000 Android Development] adrianmak:
any suggested settings of the Voodoo app ?
[Galaxy S I9000 Android Development] gicgi:
thank you sir kernel-porter :)

sometimes i want to listen a conversation recording (like almost-silent movie scenes, guy on the back ground of the recorded video etc...) so, sometimes volume is more important than quality for me.

looks like alsa is not compatible with your kernel anymore.
[Galaxy S I9000 Android Development] supercurio:
Ah, I see. This is something else that can be done and actually a excellent idea.

You did well by taking the time to explain the usage scenario.

Alright, adding this feature to my giant TODO list!
[Galaxy S I9000 Android Development] supercurio:
Sure, I recommend reading the FAQ added to the first post.
[Galaxy S I9000 Android Development] bigmo7:
Don't hate me or anything but tbh I can't hear much difference? :confused: Most of the songs on my phone are 320kbps and I'm not sure how I could hear the difference before and after...cos I removed the app and I don't think there was any difference tbh. :o

Edit: Definite improvement in the FM radio though...:p
[Galaxy S I9000 Android Development] dannybuoy:
Removing the app doesn't remove the new sound driver, just the settings for it. ;)

I can't say I hear much difference but then again I haven't done any proper A/B testing - is the quality supposed to be majorly upgraded with this release or is it just an analog gain control and FM radio bass boost at this point?
[Galaxy S I9000 Android Development] Mevos:
Wouldn't that mean its better to reduce the volume using your tool to keep the quality?

That would mean it would be a good idea to have the volume buttons control your tool instead of the system sound. After all, depending on your surroundings, you will want to increase or decrease the volume. I've got to adjust the volume depending on the song too as some are louder or have more bass.

p.s. I really like the new sound. :)
[Galaxy S I9000 Android Development] st4rk:
Yup I thinks its at the stage you mention.

Very noticeable when using something that would usuaslly need an amp to power it..

I have some Logitech speakers for my gfs iphone that I can use also, before the fix the sgs provided a very low sound from these, after the fix they are reeeeally powerful.. and they didn't lose any quality at the higher volume.

Also my friend has a nexus s and he tried to plug it into these speakers today.. afterwards when he heard how mine sounded he was very impressed.

Essentially what this fix does at the moment is allow us to utilise the phones internal amp, which was previously gimped by Samsung. Also as you mention.. the FM base fix as well. But SC has mentioned that sound quality fixes will be coming as well as many other cool features. :-)
[Galaxy S I9000 Android Development] xan:
Heres something I've noticed today: (guess its not related to voodoo)

Play a song... Besides of usual click or two you hear during device usage, when you put a finger over notification bar and start changing screen brightness rapidly you will hear a lot of clicks.

I have no idea why it is related? too much I2C traffic?
[Galaxy S I9000 Android Development] adrianmak:
From FAQ of 1st post

What is android digital sound level and analog level referring to ?

In my understanding,

Isn't digital sound level refer to the hardware button vol control ？

Isn't analog level refer to the headphone amplified control in the app ?
[Galaxy S I9000 Android Development] st4rk:
Yup you got it..
[Galaxy S I9000 Android Development] wolfcomplex:
Hi as requested my elaboration on my tweet to you. When i have my headphones pluged in i can listen to music watch videos ans play games with good audio. But when android gets an notification (email tweet etc) it can be heard through the phone speaker and through the headphones at the same time.

I was wondering if its the voodoo sound improvement or darkys rom v8 or a combination maybe?

Can be a bug bur im not sertain
[Galaxy S I9000 Android Development] supercurio:
Screen hardware uses its own bus, named LDI for LVDS display interface. It's a high bandwidth serial bus that transport both Images and Commands.

Maybe the explanation is both more simple and more absurd.

kernel log output generate clicks/skips (like when you use printk), when your code run in the sound driver.

I might be wrong, you'll be able to verify if it affects not only the sound driver with cat /proc/kmsg during the operation.
[Galaxy S I9000 Android Development] wolfcomplex:
I tried to reproduce your problem but i could not do it. I use winamp ..bur no clicks etc... also the files i play where losseless Flac
[Galaxy S I9000 Android Development] xan:
It seems that click occur when

<3>[ 998.239952] init: sys.settings_system_version:XXX

(and it prints ALOT when changing brightness from notif bar)

But they dont seem to occur with this output:

<7>[ 998.261719] touch_led_control: 1

(touchkey usage when device locked)

If unlocked and touching touchkeys:

<3>[ 998.073527] init: sys.settings_system_version:683
<7>[ 998.095684] touch_led_control: 1
<3>[ 998.202363] init: sys.settings_system_version:684
<7>[ 998.223693] touch_led_control: 1
<3>[ 998.239952] init: sys.settings_system_version:685
<7>[ 998.261719] touch_led_control: 1

So it seems that this line:

<3>[ 998.239952] init: sys.settings_system_version:685

(and possibly others) triggers the clicks.
[Galaxy S I9000 Android Development] supercurio:
And this is the most verbose kernel *ever* isn't it?

We know what's left to do now, KILL THIS INSANE LOGGING :D

BTW that's what Google do for the Nexus S kernel.
[Galaxy S I9000 Android Development] xan:
logcat is quite fun to watch too :D

Start a music player /fm radio with rds..

(100+ lines changing a track + 1 line per second during playback, FM radio is even more fun, like 50+ lines per second just tuned and playing music)

Kill em all. (dmesg at least)
[Galaxy S I9000 Android Development] supercurio:
In logcat, this is the same or even worse with FM radio.
[Galaxy S I9000 Android Development] Spirit02:
Re hardcore's speedmod kernel:

It's the only time I reboot ;)
[Galaxy S I9000 Android Development] android53:
About the static 'pop' issue.

Doing an odin flash, pit and repartition to JM9 completely solves this.

It is definately an issue with the latest firmware

By the way the touch response on JM9 is still far ahead of anything we have for froyo... pretty sad

Scrolling a menu (finger held on screen) is smooth as butter on eclair, it is slightly choppy on froyo

*update*

Going back to JPY (manual, no kies updates currently) from JM9 (no pit or repartition) causes these horrible static pops again. ARGH
[Galaxy S I9000 Android Development] xbeater:
Ok so I did not get around to getting a recording yet, but just to try out see if it works, I flashed Speedmod's K12L BIGMEM kernel, and it seems to have taken away the pops for now. I could still be wrong though, since I've only been testing for a few minutes, but so far so good...

Sorry SuperCurio for being a terrible traitor and getting another kernel. I do get a lower quadrant score though....
[Galaxy S I9000 Android Development] supercurio:
Lol, please don't see me like that :D and anyway I'm extremely happy people enjoy sound enhancement, and on several kernels and not only the ones distributed by me.

It's an honor to see other developers trusting enough my code to distribute it.

I will investigate this pop thing. Sound must be perfect.
[Galaxy S I9000 Android Development] xbeater:
Recording of the annoying static pops

Ok well I've made the recording after a painful burn on my hand due to clumsiness with a soldering iron, but I have it.

It's a 15MB Wave file, 24 bits, whatever I could get my X-fi to record. The file I played is a calm vocal to make sure the pops are clear, its a 1 minute sample from Armin van Buuren's - Mirage album. The file I played from my phone is in FLAC format, so no problems there. I have turned off the EQ and all effects to make sure it is flat output. Volume was obviously maxed out in all aspects.

To do this, I have also changed back to the Voodoo kernel, so was not using the K12L kernel anymore. I have noticed that with the K12L kernel the pops are much much less, although still there. They are also a lot more silent, and sound different, and happen far less frequently. (However I think those pops are due to my amplifier being 10+ years old, and it has some issues, even with perfect digital input.)

I do like Voodoo kernel performance a lot more, K12L seems a little jittery to me.

EDIT: It appears XDA doesn't like you uploading 15MB files. Suggestions where to upload? Have to go to gym now will be back in an hour.
[Galaxy S I9000 Android Development] ntrdung:
Hi supercuiro,

I'm using the first version of supercurio voodoo sound, I noticed that sound quality is much better than before a lot. However, compared to Wave S8500 is clear this version bass sound weaker then S8500. On the other hand, we use PowerAMP is an application that uses the CPU rather than using audio hardware implementation, the bass is better than the supercurio's first version.

A few comments to supercurio to improve the next version.

Thank you.
[Galaxy S I9000 Android Development] pitagorasz:
Hi supercuiro,

I'm on JPY and I flashed with Odin your new realese 5.1 Voodoo... after that i got some force closes from a few third party programs and my wifi is doesn't work ..it say's that the search can't be done and after that it's shout down the wifi conection..

Can you tell me what to do to solve this?

Thank's in advance
[Galaxy S I9000 Android Development] Arkanius:
Check the logcat while listening music and having Wifi on since the pops seem much more frequent there
[Galaxy S I9000 Android Development] xbeater:
Files

Hey SC,

Im back from the gym, and thought of a solution: split the file into 3 rar files each of less than 8MB.

Enjoy! :D (Or should I say "good luck enjoying"? :rolleyes: )

Cheerz, :cool:

EDIT: GRRRRR Uploading is still not working.... Anybody suggestions?
[Galaxy S I9000 Android Development] bub181:
Upload to mediafire or hotfile
[Galaxy S I9000 Android Development] layziebone:
hows the battery drainage with this kernel compared to speedmod? not really fussed about the sound update, more battery life.
[Galaxy S I9000 Android Development] xbeater:
Thank you, I will post the link here in a second! :cool:
[Galaxy S I9000 Android Development] xbeater:
Finally, Popping sounds WAV

http://hotfile.com/dl/96452652/b7f31f5/Line-In_(Creative_SB_X-Fi)_2011-01-13_11-53-44.wav.html

Here you all have the WAV of the popping sounds I promised to post.

Sorry that it took so long. :o

Supercurio: I hope this helps! :D

Cheerz,

NB
[Galaxy S I9000 Android Development] SexyIceCream:
hi guys, sorry i'm abit noob to all this. if i install the update.zip from the voodoo website, voodoo lagfix + voodoo colour + voodoo sound are all installed together right?
[Galaxy S I9000 Android Development] Meneldor:
+$20 from me! :)
[Galaxy S I9000 Android Development] Mercury0660:
yay would be great
[Galaxy S I9000 Android Development] lazarvd:
settings in voodooApp doesnt save after reboot ...
[Galaxy S I9000 Android Development] glitterballs:
Yeah...I have to say, I thought I'd try out the patch before putting out a kernel with it. I like to think I have pretty sensitive ears, and I have both my 16GB internal and a 32GB external jam packed with all kinds of high quality audio. Using Neldar's app I switched back and forth between kernels several times and listened to the same song with and without Voodoo sound. Using a kernel with the sound patch, I did notice some hissing and pops when I enabled 5.1 sound, and overall 5.1 sounded, imo, and for lack of a better term, noticeably 'flatter'. (I only use 5.1 with live albums, sound is much richer imo.) Without 5.1 enabled, I'm undecided...sometimes I think it sounds better, sometimes I think it sounds worse...maybe I'm just weird but bass seems to be a little reduced using only the sound patch (Captivate doesn't have FM anyways so I didn't use those patches).

I don't mean any of this to knock your work in any way supercurio. Really glad we have you as a dev for our line of phones. I just noticed that someone else mentioned something about pop so I thought I'd chime in as well.
[Galaxy S I9000 Android Development] vzoltan:
A2DP

Can you make the radio work on A2DP ?

i know that radio needs jack 3.5 + wire as an antenna.

what is you connect a jack 3.5+wire as an antenna, and switch the sound to a2dp ?

can you make that kind of modification?
[Galaxy S I9000 Android Development] jamesd256:
There are a number of comments on this thread about sound quality where people do not state what equipment they plug the phone in to to listen.

IMHO, feedback supplied without this information attached is of little value.

I would not expect to hear a huge difference on low grade headphones, where as a lot of people who state that the improvement is impressive are also using good equipment, and making a-b comparisons with other good equipment.

If you are hearing little or negative difference through Grado's or Etymotics, by all means let us know. That WOULD be interesting.
[Galaxy S I9000 Android Development] supercurio:
Hi !

I believe both use the same hardware, but I saw somewhere that the S8500 was applying EQ on headphone output, like the firsts Firmware versions did on the Galaxy S.

If the S8500 has more bass, it because it force apply a "bass boost"

Voodoo sound target output is a true flat frequency response by default.

If you want more bass, customize the color tone or correct headphones deficiencies, you'll be able to use the upcoming fully Parametric EQ ;)
[Galaxy S I9000 Android Development] supercurio:
The battery life of this kernel is the same as the official Samsung.
[Galaxy S I9000 Android Development] supercurio:
I will help by removing a few doubt you could have today.

On captivate, for the today version, only the headphone amplifier level is changed.

When booting, the exact same level as with other firmware is set, which means there is no difference between this and and another kernel.

This is a scientific fact I can tell because I know exactly what changes are made or not, and precisely what's in the hardware registers ;)

Also, for piece of mind of listener, every change will be configurable by the app. It does exactly what it says.

I invite you to look at the source, which is pretty readable for a Kernel driver i hope!

https://github.com/project-voodoo/l...oodoo/Kernel/sound/soc/codecs/wm8994_voodoo.c :)
[Galaxy S I9000 Android Development] supercurio:
Remember this is a Bounty thread ;)

new features request are supposed to be associated with how much you can spent to support the dev. thanks !
[Galaxy S I9000 Android Development] soulzero:
What exactly is a "bounty" thread?

Nvm i see.
[Galaxy S I9000 Android Development] glitterballs:
I'm sorry...I'm not sure I understand what you're saying here:

What level are you referring to there? The bass level? If so, wouldn't that depend on what the default amplification level was set to? (Which, btw, I didn't see if you had a recommended level or not, so I think I set it to 1 during config.) What amplification setting would be equivalent to the stock kernel? Or was your comment about the levels being the same as another firmware in response to the way (I perceive) 5.1 audio sounds?
[Galaxy S I9000 Android Development] supercurio:
What i mean, is that there is no difference in bass level.

But when you change the sound pressure by increasing it, you increase the sensation of bass. Same thing if you reduce the level, you will have the feeling there is less bass :)

As the new feature allow you to really change the volume, it's perfectly understandable you perceive a change, that's how psychoacoustics work.

I answered you because i can tell you as a scientific fact: there is no difference in bass response (except for FM) or anything else except the output level on headphones.

But it will eventually in next versions. You also have my word each possible change will be described by an option in the controlling app.
[Galaxy S I9000 Android Development] xbeater:
SC,

the wav file did you get it?

Is that kind of what you expected in terms of pops that we were describing?

What are your thoughs on it?

Cheerz, :cool:

NB
[Galaxy S I9000 Android Development] glitterballs:
edit - Ah, nevermind, I got what you're saying.
[Galaxy S I9000 Android Development] pspbirte:
Hi!

I believe that the sound on the S8500 is actually "hardware" driven, opposed to software driven... First off, the S8500 sounds like a DREAM! I have compared it to the iPhone 4, HTC Desire HD and the Galaxy S, and it CLEARLY comes out as the clear winner... No hiss, deep bass, crisp treble etc... AND you can listen to music on it for around 40 hours on a charge = really shows that its hardware driven? :)

Supercurio, u have REALLY improved the sound on the Galaxy S... Its crazy... Do you think you will be able to archive the 40 hours + of music playback on a single charge? If you use the hardware to make it more efficient...

BUT: Really, the thing i'm looking for the most, is the audio on the video recording... It could be SOOOO much better :) .... Please fix it... Please! :)